1 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3 Fix export of symbols to GDB (Bug#12036).
4 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
5 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
6 emacs.c, as this is a more-suitable home. Had this been done earlier
7 the fix for 12036 would have avoided some of the problems noted in
8 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
9 would have been more obvious.
10 * emacs.c: Do not include <verify.h>; no longer needed.
11 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
12 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
13 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
14 Remove; now done in lisp.h.
15 * lisp.h (PUBLISH_TO_GDB): New macro.
16 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
17 (DATA_SEG_BITS): Use it.
18 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
19 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
20 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
21 not be usable in #if. This simplifies things.
23 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
25 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
27 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
29 Simplify export of symbols to GDB (Bug#12036).
30 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
31 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
32 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
33 Adjust to changes in lisp.h and emacs.c, by using
34 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
35 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
36 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
37 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
38 instead of gdb_valbits.
39 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
40 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
41 instead of gdb_array_mark_flag.
42 (xboolvector): Get size from $->size, not $->header.size.
43 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
44 (xreload, hook-run, hookpost-run): Remove.
45 * emacs.c: Include <verify.h>.
46 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
47 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
49 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
50 (gdb_USE_LSB_TAG): New enum constants.
51 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
52 Also define these as enum constants, so they're visible to GDB.
53 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
54 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
55 as constants, so they're visible to GDB.
56 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
57 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
58 Now enum constants, not macros, so they're visible to GDB.
59 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
60 more convenient now. All uses changed.
61 (VALMASK) [USE_LSB_TAG]: Also define in this case.
62 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
64 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
66 Explicitly free restriction data that are not needed anymore.
67 * editfns.c (save_restriction_restore): Free restriction data.
69 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
71 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
72 add argument, tune behavior, and adjust all callers.
74 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
76 Use typedef for EMACS_INT, EMACS_UINT.
77 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
78 than macros. This simplifies debugging in the usual case, since
79 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
80 and it allows expressions involving EMACS_INT casts.
81 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
83 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
85 * nsterm.m (ns_read_socket): Return early if there is a modal
88 2012-07-25 Martin Rudalics <rudalics@gmx.at>
90 * frame.c (Fredirect_frame_focus): In doc-string don't mention
91 that FOCUS-FRAME can be omitted.
93 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
95 Adjust buffer text indirection counters at the end of Fkill_buffer.
96 * buffer.c (Fkill_buffer): Adjust indirection counters when the
97 buffer is definitely dead. This should really fix an issue reported
98 by Christoph Scholtes again. (Bug#12007).
99 (init_buffer_once): Initialize indirection counters of
100 buffer_defaults and buffer_local_symbols (for sanity and safety).
102 2012-07-24 Eli Zaretskii <eliz@gnu.org>
104 * xdisp.c (init_iterator): Don't compute dimensions of truncation
105 and continuation glyphs on tooltip frames, leave them at zero.
106 Avoids continued lines in tooltips. (Bug#11832)
108 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
110 Simplify copy_overlay.
111 * buffer.c (copy_overlay): Simplify. Use build_marker.
112 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
114 2012-07-23 Eli Zaretskii <eliz@gnu.org>
116 * print.c (print_object): Don't crash when a frame's name is nil
117 or invalid. (Bug#12025)
119 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
120 it signals an error when a tooltip frame is being created.
122 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
124 Cleanup miscellaneous objects allocation and initialization.
125 * alloc.c (allocate_misc): Change to static. Add argument to
126 specify the subtype. Adjust comment and users.
127 (build_overlay): New function.
128 * buffer.c (copy_overlays, Fmake_overlay): Use it.
129 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
130 (allocate_misc): Remove prototype.
131 (build_overlay): Add prototype.
133 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
135 Swap buffer text indirection counters in Fbuffer_swap_text.
136 * buffer.c (Fbuffer_swap_text): Swap indirections too.
137 This avoids crash reported by Christoph Scholtes at
138 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
140 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
142 * nsmenu.m (Popdown_data): New struct.
143 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
145 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
146 (initWithContentRect): Make imgView and contentView non-static
147 and autorelease them. Also autorelease img and matrix (Bug#12005).
148 (dealloc): Remove (Bug#12005).
150 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
152 Adjust consing_since_gc when objects are explicitly freed.
153 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
154 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
155 (free_cons, free_misc): Subtract object size from consing_since_gc.
157 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
159 Simplify and cleanup markers positioning code.
160 * marker.c (attach_marker): More useful eassert.
161 (live_buffer, set_marker_internal): New function.
162 (Fset_marker, set_marker_restricted): Use set_marker_internal.
163 (set_marker_both, set_marker_restricted_both): Use live_buffer.
165 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
167 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
168 as it's limited by the amount of memory, not by INT_MAX.
170 2012-07-21 Eli Zaretskii <eliz@gnu.org>
172 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
173 in special-event-map. See the discussion at
174 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
177 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
178 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
179 Fabrice Popineau <fabrice.popineau@supelec.fr>.
181 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
183 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
184 (conversationIdentifier): Return value is NSInteger.
185 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
187 2012-07-21 Chong Yidong <cyd@gnu.org>
189 * window.c (decode_any_window): Signal an error if the window is
190 on a dead frame (Bug#11984).
192 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
194 Add indirection counting to speed up Fkill_buffer.
195 * buffer.h (struct buffer): New member.
196 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
197 (Fmake_indirect_buffer): Set indirection counter to -1, increment
198 base buffer indirection counter.
199 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
200 (Fkill_buffer): Adjust indirection counters as needed, don't walk
201 through buffer list if indirection counter is 0.
203 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
205 Extend the value returned by Fgarbage_collect with heap statistics.
206 * alloc.c (Qheap): New symbol.
207 (syms_of_alloc): DEFSYM it.
208 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
209 (Fmemory_free): Remove.
210 (syms_of_alloc): Don't defsubr it.
211 * buffer.c (Fcompact_buffer): Remove.
212 (syms_of_buffer): Don't defsubr it.
214 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
216 Make maybe_gc inline.
217 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
218 * lisp.h (consing_since_gc, gc_relative_threshold)
219 (memory_full_cons_threshold): Revert declaration.
220 (maybe_gc): Remove prototype, define as inline.
221 * alloc.c: Remove old commented-out code.
222 (consing_since_gc, gc_relative_threshold)
223 (memory_full_cons_threshold): Revert to global.
226 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
228 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
229 * lisp.h (build_unibyte_string): New function.
230 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
231 * sysdep.c, w32fns.c, xfns.c: Use it.
232 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
233 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
234 Adjust users accordingly.
235 * font.h (font_open_by_name): Adjust prototype.
237 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
239 Cleanup calls to Fgarbage_collect.
240 * lisp.h (maybe_gc): New prototype.
241 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
243 * alloc.c (maybe_gc): New function.
244 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
246 * bytecode.c (MAYBE_GC): Use maybe_gc.
247 * eval.c (eval_sub, Ffuncall): Likewise.
248 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
249 to avoid dependency from auto-save feature.
251 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
253 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
254 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
255 'for_each_per_buffer_object_at'.
256 All uses changed. It's better to use upper-case for macros that
257 cannot be implemented as functions, to give the reader a clue
258 that they're special.
260 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
262 * alloc.c (Fgarbage_collect): Tweak docstring.
264 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
266 Tweak the value returned from Fgarbage_collect again.
267 * alloc.c (Fgarbage_collect): New return value, as confirmed in
268 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
269 Adjust documentation.
270 (total_vector_bytes): Rename to total_vector_slots, adjust
272 (total_free_vector_bytes): Rename to total_free_vector_slots,
274 (Qstring_bytes, Qvector_slots): New symbols.
275 (syms_of_alloc): DEFSYM them.
277 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
279 Buffer compaction primitive which may be used from Lisp.
280 * buffer.c (compact_buffer, Fcompact_buffer): New function.
281 (syms_of_buffer): Register Fcompact_buffer.
282 * alloc.c (Fgarbage_collect): Use compact_buffer.
283 * buffer.h (compact_buffer): New prototype.
284 (struct buffer_text): New member.
286 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
288 New macro to iterate over all buffers, miscellaneous cleanups.
289 * lisp.h (all_buffers): Remove declaration.
290 * buffer.h (all_buffers): Add declaration, with comment.
291 (for_each_buffer): New macro.
292 * alloc.c (Fgarbage_collect, mark_object): Use it.
293 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
294 (init_buffer): Likewise.
295 * data.c (Fset_default): Likewise.
296 * coding.c (code_conversion_restore): Remove redundant check
298 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
300 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
302 Fix bug that created negative-length intervals.
303 * intervals.c (merge_interval_right, merge_interval_left):
304 Do not zero out this interval if it is absorbed by its children,
305 as this interval's total length doesn't change in that case. See
306 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
308 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
310 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
311 when invoking (make-bool-vector N t) and N is a positive
312 multiple of 8 -- the last 8 bits were mistakenly cleared.
314 Remove some struct layout assumptions in bool vectors.
315 * alloc.c (bool_header_size): New constant.
316 (header_size, word_size): Move earlier, as they're now used earlier.
317 Use 'word_size' in a few more places, where it's appropriate.
318 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
319 padding before the data member of a bool vector.
320 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
321 than doing the check by hand with an abort ().
323 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
325 * eval.c (Fdefvar): Don't check constants since we only set the var if
326 it's not yet defined anyway (bug#11904).
328 * lisp.h (last_undo_boundary): Declare new var.
329 * keyboard.c (command_loop_1): Set it.
330 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
331 were auto-added by the command loop (bug#11774).
333 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
335 * w32font.c (Qsymbol): Remove local definition.
336 (syms_of_w32font): Don't DEFSYM it.
338 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
340 Fix sweep_vectors to handle large bool vectors correctly.
341 * alloc.c (sweep_vectors): Account total_vector_bytes for
342 bool vectors larger than VBLOCK_BYTES_MAX.
344 2012-07-18 Chong Yidong <cyd@gnu.org>
346 * frame.c (x_set_frame_parameters): Revert bogus change introduced
347 in 2012-05-25 commit by Paul Eggert (Bug#11738).
349 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
351 Return more descriptive data from Fgarbage_collect.
352 Suggested by Stefan Monnier in
353 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
354 * alloc.c (bounded_number): New function.
355 (total_buffers, total_vectors): New variable.
356 (total_string_size): Rename to total_string_bytes, adjust users.
357 (total_vector_size): Rename to total_vector_bytes, adjust users.
358 (sweep_vectors): Account total_vectors and total_vector_bytes.
359 (Fgarbage_collect): New return value. Adjust documentation.
360 (gc_sweep): Account total_buffers.
361 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
362 (VECTOR_SIZE): Remove.
363 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
364 (Qinterval, Qmisc): New symbols.
365 (syms_of_data): Initialize them.
366 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
367 (Qcons, Qbuffer): New declarations.
369 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
371 * alloc.c (Fmemory_free): Account for memory-free's own storage.
372 Round up, not down. Improve doc.
374 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
376 Restore old code in allocate_string_data to avoid Faset breakage.
377 Reported by Julien Danjou <julien@danjou.info> in
378 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
379 * alloc.c (allocate_string_data): Restore old code with minor
380 adjustments, fix comment to explain this subtle issue.
382 2012-07-17 Eli Zaretskii <eliz@gnu.org>
384 Remove FILE_SYSTEM_CASE.
385 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
387 * fileio.c (FILE_SYSTEM_CASE): Don't define.
388 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
389 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
390 call-process-region passes it through expand-file-name.
392 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
394 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
396 Fix crash when creating indirect buffer (Bug#11917)
397 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
398 Don't handle unbound variables specially if non-zero.
399 (Fbuffer_local_variables): Pass zero.
400 (clone_per_buffer_values): Pass non-zero.
402 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
404 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
405 to make the loop interruptible.
407 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
409 * gnutls.c (emacs_gnutls_handshake): Only retry if
410 GNUTLS_E_INTERRUPTED.
412 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
414 Cleanup and convert miscellaneous checks to eassert.
415 * alloc.c (mark_interval): Fix comment, partially rephrase
416 old comment from intervals.h (see below).
417 * intervals.c (find_interval, adjust_intervals_for_insertion)
418 (delete_interval, adjust_intervals_for_deletion)
419 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
421 (adjust_intervals_for_insertion, make_new_interval):
422 Remove obsolete and unused code.
423 * intervals.h (struct interval): Remove obsolete comment.
424 * textprotp.c (erase_properties): Remove unused code.
425 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
426 (Fremove_list_of_text_properties): Convert to eassert.
428 2012-07-17 Chong Yidong <cyd@gnu.org>
430 * editfns.c (Finsert_char): Doc fix.
432 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
434 Fix previous change to make Fmemory_free always accurate.
435 * alloc.c (make_interval): Update total_free_intervals.
436 (make_float): Likewise for total_free_floats.
437 (free_cons, Fcons): Likewise for total_free_conses.
438 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
439 Likewise for total_free_vector_bytes.
440 (Fmake_symbol): Likewise for total_free_symbols.
441 (bytes_free): Remove.
443 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
445 Simple free memory accounting feature.
446 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
447 (sweep_vectors): Accumulate size of free vectors.
448 (Fgarbage_collect): Setup bytes_free.
449 (Fmemory_free): New function.
450 (syms_of_alloc): Register it.
452 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
454 Cleanup overlays checking.
455 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
456 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
457 eassert and OVERLAYP.
458 (sort_overlays): Change to use OVERLAYP.
460 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
462 * editfns.c (Finsert_char): Make it interactive, and make the
463 second arg optional. Copy interactive spec and docstring from
466 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
468 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
469 Unlike the other wrapped functions, fabs has an unspecified
472 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
474 * nsterm.m (keyDown): Interpret flags without left/right bits
475 as the left key (Bug#11670).
477 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
479 Remove empty and useless init functions.
480 * lisp.h (init_character_once, init_fns, init_image)
481 (init_filelock, init_sound): Remove prototype.
482 * character.c (init_character_once): Remove.
483 * filelock.c (init_filelock): Likewise.
484 * fns.c (init_fns): Likewise.
485 * image.c (init_image): Likewise.
486 * sound.c (init_sound): Likewise.
487 * emacs.c (main): Adjust accordingly.
489 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
491 * gtkutil.h: Tiny cleanups.
492 (use_old_gtk_file_dialog): Remove useless declaration.
493 (xg_uses_old_file_dialog): Add suggested const attribute.
495 2012-07-15 Eli Zaretskii <eliz@gnu.org>
497 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
498 (bidi_paragraph_init): Use it to limit search forward for a strong
499 directional character in abnormally large paragraphs full of
500 neutral or weak characters. (Bug#11943)
502 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
504 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
505 the toolbar (Bug#9451).
506 (xg_make_tool_item): Give the widget event box a transparent
509 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
511 Cleanup basic allocation variables and functions.
512 * alloc.c (ignore_warnings, init_intervals, init_float)
513 (init_cons, init_symbol, init_marker): Remove.
514 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
515 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
516 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
517 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
518 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
519 (staticidx, init_alloc_once, init_strings, free_ablock):
520 Remove redundant initialization.
521 * fns.c (init_weak_hash_tables): Remove.
522 * lisp.h (init_weak_hash_tables): Remove prototype.
524 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
526 Use zero_vector where appropriate.
527 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
529 * lisp.h (zero_vector): New declaration.
530 * font.c (null_vector): Remove.
531 (syms_of_font): Remove initialization and staticpro.
532 (font_list_entities, font_find_for_lface): Change to use zero_vector.
533 * keymap.c (Faccessible_keymaps): Likewise.
535 2012-07-15 Leo Liu <sdl.web@gmail.com>
537 * fringe.c: Fix typo in comments.
539 2012-07-14 Leo Liu <sdl.web@gmail.com>
541 * fringe.c: Add a new bitmap exclamation-mark.
543 2012-07-14 Eli Zaretskii <eliz@gnu.org>
545 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
547 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
548 (HAVE_MENUS): Don't define, defined by editing config.in with
550 (GMALLOC_INHIBIT_VALLOC): Don't define.
551 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
553 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
555 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
557 2012-07-14 Glenn Morris <rgm@gnu.org>
559 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
560 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
561 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
563 2012-07-13 Glenn Morris <rgm@gnu.org>
565 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
567 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
568 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
570 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
572 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
573 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
574 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
575 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
577 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
578 as boolean expression.
579 (x_set_window_size): Remove unused variable toolbar.
580 (ns_get_color_default, ns_mod_to_lisp): Remove.
581 (ns_mouse_position): Remove unused variables xchar and ychar.
582 (ns_compute_glyph_string_overhangs): Remove unused variable face.
583 (ns_set_vertical_scroll_bar): Remove unused variable count.
584 (ns_delete_terminal): Remove unused variable i.
585 (ns_term_init): Remove unused variables r, g and b.
586 (mouseDown): Remove unused variable window.
587 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
588 (initFrameFromEmacs): Remove unused variable vbextra.
589 (mouseEntered): Remove unused variables p and dpyinfo.
590 (mouseExited): Remove unused variables p and r.
591 (ns_define_frame_cursor, ns_clear_frame_area)
592 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
593 (menuDown): Assign [sender tag] to variable and cast the variable.
595 * nsterm.h (menuDown): Add id as type to argument sender.
596 (ns_display_info_for_name): Add Lisp_Object argument.
597 (ns_term_init): Add Lisp_Object argument.
598 (ns_map_event_to_object): Add void argument.
599 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
600 prototype with arguments and only declare if __OBJC__.
601 (nxatoms_of_nsselect): Add void argument.
602 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
603 (ns_alloc_autorelease_pool): Add void argument.
604 (ns_release_autorelease_pool): Add void* argument.
605 (ns_get_defaults_value): Add const char* argument.
607 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
608 (initFromContents): Use SSDATA where appropriate.
609 (ns_update_menubar): Add braces to ambigous if-else.
610 (initWithTitle): Put () around assignment in if statement.
611 (ns_menu_show): Remove unused variables window and keymap.
612 (update_frame_tool_bar): Remove unused variable selected_p.
613 (initWithContentRect): Remove unused variable this_cmd_name.
615 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
617 (setXBMColor): Remove unused variable len.
618 (setPixmapData): Put () around assignment in loop statement.
620 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
621 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
623 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
624 around assignment in loop statement.
625 (nsfont_open): Remove unused variable i.
626 (nsfont_open): Remove unused variable len.
627 (nsfont_draw): Remove unused variable cs.
629 * nsfns.m (x_set_icon_name, ns_set_name_internal)
630 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
631 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
632 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
633 (Fns_font_name, Fns_perform_service)
634 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
635 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
636 (ns_set_name): Remove unused variable view.
637 (x_set_menu_bar_lines): Remove unused variable olines.
638 (x_set_tool_bar_lines): Remove unused variable root_window.
639 (Fns_list_colors): Put () around assignment in while statement.
640 (Fns_perform_service): Remove unused variable len.
641 (Fns_display_usable_bounds): Remove unused variable top.
642 (syms_of_nsfns): Remove unused variable i.
644 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
647 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
649 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
650 and free it with DestroyExceptionInfo (Bug#11558).
652 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
654 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
655 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
656 Set here, not in nt/config.nt.
658 2012-07-13 Eli Zaretskii <eliz@gnu.org>
660 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
661 cursor overflow into the last glyph on display line when the right
662 fringe is off. (Bug#11832)
664 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
666 * xdisp.c (produce_special_glyphs): Now static.
667 * dispextern.h (produce_special_glyphs): Remove decl.
669 2012-07-13 Glenn Morris <rgm@gnu.org>
671 * s/bsd-common, s/cygwin.h: Remove empty files.
672 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
674 * s/usg5-4-common.h (USG, USG5):
675 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
676 * s/sol2-6.h (SOLARIS2):
677 * s/irix6-5.h (IRIX6_5):
678 * s/hpux10-20.h (USG, USG5, HPUX):
679 * s/gnu-linux.h (USG, GNU_LINUX):
680 * s/freebsd.h (BSD_SYSTEM):
681 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
682 * s/cygwin.h (CYGWIN):
683 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
684 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
686 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
688 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
690 2012-07-13 Glenn Morris <rgm@gnu.org>
692 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
694 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
696 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
697 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
699 2012-07-12 Glenn Morris <rgm@gnu.org>
701 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
703 * process.c (init_process_emacs): Rename from init_process.
704 The old name is also the name of a Mach system call.
705 * lisp.h, emacs.c: Update for this name change.
706 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
709 2012-07-12 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
712 memmove call that removes glyphs covered by the left truncation
713 glyph. Improve commentary.
714 (display_line): Fix display of continuation glyphs on GUI frames
715 when the right fringe is turned off and variable-size fonts are
716 used in the window. Move the code that appends a stretch glyph to
717 produce_special_glyphs, so that it could be used for truncation
718 and continuation glyphs alike.
719 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
720 glyph of a suitably computed width, to align the special glyphs at
721 the window margin. Code moved from display_line. (Bug#11832)
723 2012-07-12 Glenn Morris <rgm@gnu.org>
725 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
727 * s/gnu-linux.h, s/hpux10-20.h:
728 Do not unconditionally define HAVE_XRMSETDATABASE.
730 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
732 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
734 Fix typos that broke OS X build.
735 Reported by Randal L. Schwartz in
736 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
737 * nsterm.m (ns_timeout): Add missing local decl.
738 (ns_get_color): snprintf -> sprintf, to fix typo.
740 2012-07-12 Glenn Morris <rgm@gnu.org>
742 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
743 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
744 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
745 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
747 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
748 Move PTY_OPEN to configure.
750 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
751 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
752 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
754 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
756 Use empty_unibyte_string where applicable.
757 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
758 * lread.c (read1): Likewise.
759 * xsettings.c (syms_of_xsettings): Likewise.
761 2012-07-12 Glenn Morris <rgm@gnu.org>
763 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
764 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
765 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
766 * s/hpux10-20.h (RUN_TIME_REMAP):
767 * s/bsd-common.h (TABDLY): Move to configure.
769 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
771 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
773 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
774 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
776 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
778 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
779 * s/template.h: Move NARROWPROTO to configure.
781 2012-07-11 Glenn Morris <rgm@gnu.org>
783 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
784 unused since 2011-01-17 change to systty.h.
786 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
787 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
788 Move HAVE_PTYS and HAVE_SOCKETS to configure.
790 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
792 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
794 2012-07-11 Glenn Morris <rgm@gnu.org>
796 * s/darwin.h, s/gnu-linux.h, s/template.h:
797 Move INTERRUPT_INPUT to configure.
799 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
801 Minor adjustments to interning code.
802 * lisp.h (intern, intern_c_string): Redefine as static inline
803 wrappers for intern_1 and intern_c_string_1, respectively.
804 (intern_1, intern_c_string_1): Rename prototypes.
805 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
807 * font.c (font_intern_prop): Likewise. Adjust comment.
808 * w32font.c (intern_font_name): Likewise.
810 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
812 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
814 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
815 of Fcar/Fcdr if possible.
816 * font.c (check_otf_features): Likewise.
817 * fontset.c (Fnew_fontset): Likewise.
818 * gnutls.c (Fgnutls_boot): Likewise.
819 * minibuf.c (read_minibuf): Likewise.
820 * msdos.c (IT_set_frame_parameters): Likewise.
821 * xmenu.c (Fx_popup_dialog): Likewise.
822 * w32menu.c (Fx_popup_dialog): Likewise.
824 2012-07-11 Glenn Morris <rgm@gnu.org>
826 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
827 since nothing has defined it on these platforms.
829 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
830 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
832 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
833 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
834 Move CLASH_DETECTION to configure.
836 * s/gnu.h: Remove file, which is now empty.
838 * s/gnu.h, s/gnu-linux.h:
839 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
841 2012-07-11 John Wiegley <johnw@newartisans.com>
843 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
844 function attribute, so we only use it if it exists in the
847 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
849 Avoid call to strlen in fast_c_string_match_ignore_case.
850 * search.c (fast_c_string_match_ignore_case): Change to use
851 length argument. Adjust users accordingly.
852 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
854 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
857 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
858 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
861 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
864 * s/hpux10-20.h (HAVE_PERROR): Remove.
865 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
866 Remove dummy definition, as this problem was obsolete long ago.
869 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
871 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
873 Avoid calls to strlen in font processing functions.
874 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
875 (font_open_by_name): Change to use length argument. Adjust
877 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
879 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
880 Change to return ptrdiff_t.
881 (xfont_list_pattern, xfont_match): Use length returned by
882 xfont_decode_coding_xlfd.
883 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
885 2012-07-11 Glenn Morris <rgm@gnu.org>
887 * s/darwin.h, s/freebsd.h, s/netbsd.h:
888 Move DONT_REOPEN_PTY to configure.
890 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
891 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
893 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
895 Remove "#define unix" that is no longer needed (Bug#11905).
896 * s/aix4-2.h (unix): Remove; no longer needed.
898 EMACS_TIME simplification (Bug#11875).
899 This replaces macros (which typically do not work in GDB)
900 with functions, typedefs and enums, making the code easier to debug.
901 The functional style also makes code easier to read and maintain.
902 * systime.h: Include <sys/time.h> on all hosts, not just if
903 WINDOWSNT, since 'struct timeval' is needed in general.
904 (EMACS_TIME): Now a typedef, not a macro.
905 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
907 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
908 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
909 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
910 (EMACS_TIME_LE): Now functions, not macros.
911 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
912 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
913 which are not functions. All uses rewritten to use:
914 (make_emacs_time): New function.
915 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
916 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
917 not functions. All uses rewritten to use the following, respectively:
918 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
919 (add_emacs_time, sub_emacs_time): New functions.
920 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
921 * fileio.c (Fcopy_file):
922 * xterm.c (XTflash): Get the current time closer to when it's used.
923 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
925 * bytecode.c (targets): Suppress -Woverride-init warnings.
927 Simplify by avoiding confusing use of strncpy etc.
928 * doc.c (Fsnarf_documentation):
929 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
930 * frame.c (Fmake_terminal_frame):
931 * gtkutil.c (get_utf8_string):
933 * nsmenu.m (ns_update_menubar):
934 * regex.c (regerror):
935 Prefer memcpy to strncpy and strncat when either will do.
936 * fileio.c (Fsubstitute_in_file_name):
937 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
938 (menu_separator_name_p):
939 * nsmenu.m (ns_update_menubar):
940 Prefer memcmp to strncmp when either will do.
941 * nsterm.m: Include <ftoastr.h>.
943 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
944 Prefer snprintf to strncpy.
945 * nsterm.m (ns_term_init):
946 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
947 * nsterm.m (ns_term_init):
948 Avoid the need for strncpy, by using build_string or
949 make_unibyte_string directly. Use dtoastr, not snprintf.
950 * process.c (Fmake_network_process): Diagnose service names that
951 are too long, rather than silently truncating them or creating
952 non-null-terminated names.
953 (Fnetwork_interface_info): Likewise, for interface names.
954 * sysdep.c (system_process_attributes) [GNU_LINUX]:
955 Prefer sprintf to strncat.
956 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
957 Prefer vsnprintf to vsprintf + strncpy.
959 2012-07-10 Glenn Morris <rgm@gnu.org>
961 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
962 Clarify fallback case.
964 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
966 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
967 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
968 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
969 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
970 where argument type is known to be a Lisp_Cons.
972 2012-07-10 Tom Tromey <tromey@redhat.com>
974 * bytecode.c (BYTE_CODE_THREADED): New macro.
975 (BYTE_CODES): New macro. Replaces all old byte-code defines.
976 (enum byte_code_op): New type.
977 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
978 (exec_byte_code): Use them. Use token threading when applicable.
980 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
982 Optimize pure C strings initialization.
983 * lisp.h (make_pure_string): Fix prototype.
984 (build_pure_c_string): New function, defined as static inline. This
985 provides a better opportunity to optimize away calls to strlen when
986 the function is called with compile-time constant argument.
987 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
988 argument, adjust users accordingly. Use build_pure_c_string where
990 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
991 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
992 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
994 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
996 Avoid calls to strlen in miscellaneous functions.
997 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
998 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
999 * lread.c (openp): Likewise.
1001 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1003 Avoid calls to strlen in path processing functions.
1004 * fileio.c (file_name_as_directory): Add comment. Change to add
1005 srclen argument and return the length of result. Adjust users
1007 (directory_file_name): Fix comment. Change to add srclen argument,
1008 swap 1st and 2nd arguments to obey the common convention. Adjust
1010 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1012 2012-07-10 Glenn Morris <rgm@gnu.org>
1014 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1015 Move PENDING_OUTPUT_COUNT definition to configure.
1017 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1018 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1019 * s/gnu.h (DATA_START): Move definitions to configure.
1021 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1022 We include usg5-4-common.h, which defines them both.
1024 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1025 O_RDONLY already includes it).
1027 Stop ns builds setting the EMACSLOADPATH environment variable.
1028 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1029 Now it does not set EMACSLOADPATH, just returns the load-path string.
1030 * nsterm.h: Update accordingly.
1031 * lread.c [HAVE_NS]: Include nsterm.h.
1032 (init_lread) [HAVE_NS]: Use ns_load_path.
1033 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1035 2012-07-09 Glenn Morris <rgm@gnu.org>
1037 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1038 since the included bsd-common.h does so.
1040 Stop ns builds setting the EMACSPATH environment variable.
1041 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1042 (ns_init_paths): Do not set EMACSPATH.
1043 * nsterm.h (ns_exec_path): Add it.
1044 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1047 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1049 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1051 * process.c (wait_reading_process_output): 'waitchannels' was unset
1052 when read_kbd || !NILP (wait_for_cell); fix this.
1054 Add GCC-style 'const' attribute to functions that can use it.
1055 * character.h (char_resolve_modifier_mask):
1056 * keyboard.h (make_ctrl_char):
1057 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1058 (init_character_once, next_almost_prime, init_fns, init_image)
1059 (flush_pending_output, init_sound):
1060 * mem-limits.h (start_of_data):
1061 * menu.h (finish_menu_items):
1062 Add ATTRIBUTE_CONST.
1063 * emacs.c (DEFINE_DUMMY_FUNCTION):
1064 Declare the dummy function with ATTRIBUTE_CONST.
1065 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1066 Add decls with ATTRIBUTE_CONST.
1068 Minor improvements to make_formatted_string.
1069 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1070 where int is good enough, as vsprintf returns an int.
1071 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1073 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1075 Use make_formatted_string to avoid double length calculation.
1076 * lisp.h (make_formatted_string): New prototype.
1077 * alloc.c (make_formatted_string): New function.
1078 * buffer.c (Fgenerate_new_buffer_name): Use it.
1079 * dbus.c (syms_of_dbusbind): Likewise.
1080 * editfns.c (Fcurrent_time_zone): Likewise.
1081 * filelock.c (get_boot_time): Likewise.
1082 * frame.c (make_terminal_frame, set_term_frame_name)
1083 (x_report_frame_params): Likewise.
1084 * image.c (gs_load): Likewise.
1085 * minibuf.c (get_minibuffer): Likewise.
1086 * msdos.c (dos_set_window_size): Likewise.
1087 * process.c (make_process): Likewise.
1088 * xdisp.c (ensure_echo_area_buffers): Likewise.
1089 * xsettings.c (apply_xft_settings): Likewise.
1091 2012-07-09 Glenn Morris <rgm@gnu.org>
1093 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1094 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1095 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1096 * nsterm.h (ns_etc_directory): Add it.
1097 * callproc.c [HAVE_NS]: Include nsterm.h.
1098 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1100 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1102 Move marker debugging code under MARKER_DEBUG.
1103 * marker.c (MARKER_DEBUG): Move marker debugging code under
1104 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1105 for bootstrap with --enable-checking (~3x slowdown reported
1106 by Juanma Barranquero <lekktu@gmail.com>).
1107 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1109 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1111 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1112 See <http://bugs.gnu.org/11825#29>.
1114 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1117 has no font, use the frame's font. (Bug#11813)
1118 (display_line): Add commentary about displaying truncation glyphs
1120 (produce_special_glyphs): Move here from term.c.
1122 * term.c (produce_special_glyphs): Move to xdisp.c.
1124 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1127 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1129 * xdisp.c (display_line): Avoid warning about implicit declaration
1132 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1134 * lisp.h: Remove empty conditional.
1136 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1138 * lread.c (load_path_check): Now static.
1140 Fix some minor --with-ns problems found by static checking.
1141 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1142 (x_set_font) [!HAVE_X_WINDOWS]:
1143 * image.c (xpm_load_image) [HAVE_NS]:
1144 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1145 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1146 Remove unused local.
1147 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1148 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1149 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1150 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1151 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1152 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1153 Fix pointer signedness problem.
1154 * xfaces.c (FRAME_X_FONT_TABLE):
1155 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1157 2012-07-07 Glenn Morris <rgm@gnu.org>
1159 * lread.c (load_path_check): New function, split from init_lread.
1160 (init_lread): Reorganize. Motivation:
1161 If EMACSLOADPATH is set, check/warn about that rather than the
1162 defaults, which we are not going to use. Hence we can remove
1163 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1164 Don't warn if site-lisp directories are missing.
1165 If not installed, start from a blank load-path, since
1166 PATH_LOADSEARCH refers to the eventual installation directories.
1168 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1170 Support truncation and continuation glyphs on GUI frames, when
1171 fringes are disabled. (Bug#11832)
1172 * xdisp.c (init_iterator): Get dimensions of truncation and
1173 continuation glyphs even if on GUI frames. Adjust
1174 it->last_visible_x on GUI frames when the left or right fringes,
1175 or both, are absent.
1176 (start_display, move_it_in_display_line_to): Handle the case of a
1177 GUI frame without a fringe to display continuation or truncation
1179 (insert_left_trunc_glyphs): Support GUI frames: make sure
1180 truncation glyphs overwrite enough glyphs from the current line to
1181 have sufficient space in pixels.
1182 (display_line): Support truncation and continuation glyphs on GUI
1183 frames. If some spare pixels are left on the line after inserting
1184 the truncation glyphs, fill that space with a stretch glyph of a
1185 suitably computed width.
1187 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1188 produce_glyphs, to support GUI sessions.
1190 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1192 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1194 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1196 Do not require float-time's arg to fit in time_t (Bug#11825).
1197 This works better on hosts where time_t is unsigned, and where
1198 float-time is applied to the (negative) difference between two times.
1199 * editfns.c (decode_time_components): Last arg is now double *,
1200 not int *, and means to store all the result as a double, without
1201 worrying about whether the seconds part fits in time_t.
1202 All callers changed.
1203 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1204 All callers changed.
1205 (Ffloat_time): Do not fail merely because the specified time falls
1206 outside of time_t range.
1208 2012-07-07 Glenn Morris <rgm@gnu.org>
1210 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1211 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1212 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1214 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1216 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1217 Update dependencies.
1219 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1221 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1223 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1224 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1225 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1226 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1227 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1228 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1230 * xfont.c (compare_font_names): Redo to omit the need for casts.
1232 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1234 * xfns.c (Fx_change_window_property): Doc fix.
1235 * w32fns.c (Fx_change_window_property): Doc fix.
1237 * w32fns.c (Fx_window_property): Accept the same arguments as the
1238 X Windows version. Doc fix.
1239 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1241 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1242 Eli Zaretskii <eliz@gnu.org>
1244 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1245 Windows-specific code from nt/config.nt moved here.
1246 Obsolete settings removed.
1248 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1250 * process.c: Avoid unnecessary calls to gettime.
1251 (wait_reading_process_output): Don't get the time of day
1252 when gobbling data immediately and not waiting, as there's no need
1253 for it in that case. This removes a FIXME.
1255 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1257 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1258 is defined (Bug#11768).
1260 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1262 Fix marker debugging code.
1263 * marker.c (byte_char_debug_check): Do not perform the check
1264 if buffer is not multibyte.
1265 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1266 Call byte_char_debug_check with correct arguments.
1268 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1270 Compile marker debugging code only if ENABLE_CHECKING is defined.
1271 * marker.c (byte_char_debug_check, count_markers):
1272 Use only if ENABLE_CHECKING is defined.
1273 (byte_debug_flag): Remove.
1274 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1275 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1277 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1279 Avoid code repetition in marker-related functions.
1280 * marker.c (attach_marker): New function.
1281 (Fset_marker, set_marker_restricted, set_marker_both)
1282 (set_marker_restricted_both): Use it.
1283 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1284 Consistently rename charno to charpos.
1285 (marker_position): Add eassert.
1286 (marker_byte_position): Convert to eassert.
1288 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1290 Simplify list operations in unchain_overlay and unchain_marker.
1291 * buffer.c (unchain_overlay): Simplify. Add comment.
1292 * marker.c (unchain_marker): Simplify. Fix comments.
1294 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1296 Introduce fast path for the widely used marker operation.
1297 * alloc.c (build_marker): New function.
1298 * lisp.h (build_marker): New prototype.
1299 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1300 * composite.c (autocmp_chars): Likewise.
1301 * editfns.c (buildmark): Remove.
1302 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1303 (save_restriction_save): Use build_marker.
1304 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1305 * window.c (save_window_save): Likewise.
1307 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1309 Do not use Fdelete_overlay in delete_all_overlays
1310 to avoid redundant calls to unchain_overlay.
1311 * buffer.c (drop_overlay): New function.
1312 (delete_all_overlays, Fdelete_overlay): Use it.
1313 * minibuf.c (get_minibuffer): Fix comment.
1315 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1317 Port to OpenBSD 5.1 amd64.
1318 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1319 This is needed for OpenBSD, and should be harmless on all BSD systems.
1320 Also, include <sys/sysctl.h>, as it should be available on all
1321 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1322 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1323 use p_pid member, not kp_proc.pid.
1325 2012-07-06 Glenn Morris <rgm@gnu.org>
1327 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1329 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1331 More xmalloc and related cleanup.
1332 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1333 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1334 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1335 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1336 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1337 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1338 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1339 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1340 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1342 Omit needless casts involving void * pointers and allocation.
1343 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1344 as the former is more robust if P's type is changed.
1345 Prefer xzalloc to xmalloc + memset 0.
1346 Simplify malloc-or-realloc to realloc.
1347 Don't worry about xmalloc returning a null pointer.
1348 Prefer xstrdup to xmalloc + strcpy.
1349 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1351 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1352 alloca of a constant.
1354 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1356 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1357 hscroll is larger than the line width. Fixes long and futile
1358 looping inside extend_face_to_end_of_line (on a TTY) producing
1359 glyphs that are not needed and thrown away.
1361 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1363 * marker.c (set_marker_restricted_both): Simplify by using
1366 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1368 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1370 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1372 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1373 not defined (Bug#11768).
1374 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1375 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1376 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1377 followed by gtk_box_set_homogeneous (Bug#11768).
1378 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1379 (update_theme_scrollbar_width, xg_create_scroll_bar):
1380 Use gtk_scrollbar_new (Bug#11768).
1381 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1382 (is_box_type): New function (Bug#11768).
1383 (xg_tool_item_stale_p): Call is_box_type.
1384 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1385 with default display (Bug#11768).
1387 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1389 * xdisp.c (window_hscroll_limited): New function.
1390 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1391 coordinates when window's hscroll is set to insanely large
1394 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1396 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1397 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1399 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1402 * lisp.h (xzalloc): New prototype. Omit needless casts.
1403 * alloc.c (xzalloc): New function. Omit needless casts.
1404 * charset.c: Omit needless casts. Convert all calls to
1405 xmalloc with following memset to xzalloc.
1406 * dispnew.c: Likewise.
1407 * fringe.c: Likewise.
1408 * image.c: Likewise.
1409 * sound.c: Likewise.
1411 * w32fns.c: Likewise.
1412 * w32font.c: Likewise.
1413 * w32term.c: Likewise.
1414 * xfaces.c: Likewise.
1416 * xterm.c: Likewise.
1417 * atimer.c: Omit needless casts.
1418 * buffer.c: Likewise.
1419 * callproc.c: Likewise.
1421 * coding.c: Likewise.
1422 * composite.c: Likewise.
1424 * doprnt.c: Likewise.
1425 * editfns.c: Likewise.
1426 * emacs.c: Likewise.
1428 * filelock.c: Likewise.
1430 * gtkutil.c: Likewise.
1431 * keyboard.c: Likewise.
1433 * lread.c: Likewise.
1434 * minibuf.c: Likewise.
1435 * msdos.c: Likewise.
1436 * print.c: Likewise.
1437 * process.c: Likewise.
1438 * region-cache.c: Likewise.
1439 * search.c: Likewise.
1440 * sysdep.c: Likewise.
1441 * termcap.c: Likewise.
1442 * terminal.c: Likewise.
1443 * tparam.c: Likewise.
1444 * w16select.c: Likewise.
1446 * w32reg.c: Likewise.
1447 * w32select.c: Likewise.
1448 * w32uniscribe.c: Likewise.
1449 * widget.c: Likewise.
1450 * xdisp.c: Likewise.
1451 * xmenu.c: Likewise.
1453 * xselect.c: Likewise.
1455 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1457 * fileio.c (time_error_value): Check the right error number.
1458 Problem reported by Troels Nielsen in
1459 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1461 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1463 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1464 This should be fixed in a better way; see Eli Zaretskii in
1465 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1466 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1468 * fileio.c (time_error_value): Rename from special_mtime.
1469 The old name's problems were noted by Eli Zaretskii in
1470 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1472 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1473 This variable's comment says Emacs needs at least one GDB-visible
1474 symbol of type enum pvec_type, to work around GDB problems.
1475 The symbol's value doesn't matter.
1477 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1478 that causes compilation to fail on pre-C99 compilers.
1480 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1482 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1483 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1485 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1487 * buffer.c (init_buffer_once): Fix initialization of
1488 headers for buffer_defaults and buffer_local_symbols.
1489 Reported by Juanma Barranquero <lekktu@gmail.com>.
1491 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1493 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1494 * lisp.h (enum pvec_type): Use fewer bits.
1495 (PSEUDOVECTOR_SIZE_BITS): New constant.
1496 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1497 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1498 change in pvec_type.
1499 (PSEUDOVECTOR_TYPEP): New macro.
1500 (TYPED_PSEUDOVECTORP): Use it.
1501 * fns.c (internal_equal): Adapt code to extract pvectype.
1502 * emacs.c (gdb_pvec_type): Update type.
1503 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1504 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1505 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1506 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1507 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1508 abusing vector->header.next.nbytes.
1509 (live_vector_p): Use PVEC_TYPE.
1510 (mark_object): Adapt code to extract pvectype. Use switch.
1512 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1514 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1515 Tighten new eassert a bit.
1517 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1519 Fix compilation with --enable-gcc-warnings and -O1
1521 * doprnt.c (doprnt): Change type of tem to int, initialize
1522 to avoid compiler warning. Add eassert.
1523 * search.c (simple_search): Initialize match_byte to avoid
1524 compiler warning. Add eassert.
1526 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1528 Avoid weird behavior with large horizontal scrolls.
1529 Without this change, for example, large hscroll values would
1530 mess up Emacs's display on Fedora 15 x86, presumably due to
1531 overflows in int calculations in the display code.
1532 Also, if buffers had long lines, Emacs would freeze.
1533 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1534 (set_window_hscroll): New function, containing the old guts of
1535 Fset_window_hscroll. Return the clipped value.
1536 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1537 This avoids the need to check against PTRDIFF_MAX.
1539 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1541 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1543 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1545 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1547 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1548 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1549 since GCC 4.4.6 issues a bogus warning for them.
1551 Fix bugs in file timestamp newness comparisons.
1552 * fileio.c (Ffile_newer_than_file_p):
1553 * lread.c (Fload): Use full timestamp resolution of files,
1554 not just the 1-second resolution, so that files that are only
1555 slightly newer still count as newer.
1556 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1557 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1559 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1561 * fileio.c: Improve handling of file time marker. (Bug#11852)
1562 (special_mtime): New function.
1563 (Finsert_file_contents, Fverify_visited_file_modtime):
1564 Use it to set special mtime values consistently.
1566 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1568 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1569 marker for non-existing file. (Bug#11852)
1571 2012-07-03 Glenn Morris <rgm@gnu.org>
1573 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1574 and did not make it into globals.h).
1576 2012-07-03 Tom Tromey <tromey@redhat.com>
1578 * window.c (Fset_window_margins, Fset_window_fringes)
1579 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1580 * textprop.c (Fprevious_property_change): No longer static.
1581 * syntax.c (Fsyntax_table_p): No longer static.
1582 * process.c (Fget_process, Fprocess_datagram_address): No longer
1584 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1585 * keyboard.c (Fcommand_execute): No longer static.
1587 * insdel.c (Fcombine_after_change_execute): No longer static.
1588 * image.c (Finit_image_library): No longer static.
1589 * fileio.c (Fmake_symbolic_link): No longer static.
1590 * eval.c (Ffetch_bytecode): No longer static.
1591 * editfns.c (Fuser_full_name): No longer static.
1592 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1594 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1596 * dired.c (Ffile_attributes): No longer static.
1597 * composite.c (Fcomposition_get_gstring): No longer static.
1598 * callproc.c (Fgetenv_internal): No longer static.
1600 * ccl.h: Remove EXFUNs.
1601 * buffer.h: Remove EXFUNs.
1602 * dispextern.h: Remove EXFUNs.
1603 * intervals.h: Remove EXFUNs.
1604 * fontset.h: Remove EXFUN.
1605 * font.h: Remove EXFUNs.
1606 * dosfns.c (system_process_attributes): Remove EXFUN.
1607 * keymap.h: Remove EXFUNs.
1608 * lisp.h: Remove EXFUNs.
1609 * w32term.h: Remove EXFUNs.
1610 * window.h: Remove EXFUNs.
1611 * xsettings.h: Remove EXFUN.
1612 * xterm.h: Remove EXFUN.
1614 2012-07-03 Glenn Morris <rgm@gnu.org>
1616 * lisp.h (Frandom): Make it visible to C.
1617 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1618 buffer for invisible buffers. (Bug#1229)
1620 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1622 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1623 values which aren't power of 2.
1624 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1625 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1628 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1630 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1632 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1634 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1636 * alloc.c (allocate_vector_block): Remove redundant
1637 calls to mallopt if DOUG_LEA_MALLOC is defined.
1638 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1639 avoid calls to mallopt if zero_vector is returned.
1641 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1643 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1644 is enabled, avoid dereferencing NULL current_sblock if
1647 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1649 Cleanup basic buffer management.
1650 * buffer.h (struct buffer): Change layout to use generic vector
1651 marking code. Fix some comments. Change type of 'clip_changed'
1652 to bitfield. Remove unused #ifndef old.
1653 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1654 (GET_OVERLAYS_AT): Fix indentation.
1655 (for_each_per_buffer_object_at): New macro.
1656 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1657 (Fbuffer_local_variables): Use it.
1658 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1659 * alloc.c (allocate_buffer): Adjust to match new layout of
1660 struct buffer. Fix comment.
1661 (mark_overlay): New function.
1662 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1663 Lisp area of struct buffer.
1664 (mark_object): Use it. Adjust marking of misc objects
1665 and related comments.
1667 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1669 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1670 wrapper that is not needed because the wrapped code is a no-op (zero
1671 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1672 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1674 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1676 * alloc.c (mark_buffer): Simplify. Remove prototype.
1677 (mark_object): Add comment. Reorganize marking of vector-like
1678 objects. Use CHECK_LIVE for all vector-like objects except buffers
1679 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1680 redundant calls to mark_vectorlike for bool vectors.
1682 2012-06-30 Glenn Morris <rgm@gnu.org>
1684 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1686 * epaths.in (PATH_SITELOADSEARCH): New.
1687 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1688 This is rather than relying on --enable-locallisppath elements
1689 having "site-lisp" in their names. (Bug#10208#25, 11658)
1691 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1693 * w32proc.c (sys_select): Accept and ignore one more argument.
1695 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1697 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1698 (pselect) [!MS_DOS]: Redirect to sys_select.
1700 * sysdep.c: Don't include dos.h and dosfns.h.
1702 * process.c (sys_select):
1703 * msdos.c (sys_select): Accept one more argument and ignore it.
1705 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1706 adapt data types and code to that.
1709 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1710 which clashes with the gnulib function of the same name.
1712 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1714 * font.c (font_style_to_value, font_style_symbolic)
1715 (font_prop_validate_style): Add type checks for values in
1718 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1720 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1723 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1725 * xdisp.c (try_window_id): Undo last change.
1727 * w32.c (getwd): Adjust commentary about startup_dir.
1728 (init_environment): Always call sys_access, even in non-MSVC
1729 builds. Don't chdir to the directory of the Emacs executable.
1730 This undoes code from 1997 which was justified by the need to
1731 "avoid conflicts when removing and renaming directories". But its
1732 downside was that every relative file name was being interpreted
1733 relative to the directory of the Emacs executable, which can never
1734 be TRT. In particular, it broke sys_access when called with
1735 relative file names.
1736 (sys_access): Map GetLastError to errno.
1738 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1740 * window.h (struct window): Change type of 'fringes_outside_margins'
1741 to bitfield. Fix comment. Adjust users accordingly.
1742 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1744 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1747 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1749 * gnutls.c (emacs_gnutls_handshake):
1750 Add QUIT to make the loop interruptible.
1752 2012-06-29 Glenn Morris <rgm@gnu.org>
1754 * charset.c (init_charset): Make lack of etc/charsets fatal.
1756 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1758 * editfns.c (region_limit): Fix type mismatch.
1760 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1762 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1763 undefined. Convert from xassert to eassert.
1764 * nsmenu.m: Convert from xassert to eassert.
1765 * nsterm.m: Likewise.
1767 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1769 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1771 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1773 Avoid integer overflow on scroll-left and scroll-right.
1774 * window.c (HSCROLL_MAX): New macro.
1775 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1776 overflow when requested scroll falls outside ptrdiff_t range.
1778 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1780 * window.h (struct window): Change type of 'hscroll',
1781 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1782 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1783 Adjust users accordingly.
1784 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1785 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1786 from EMACS_INT to ptrdiff_t.
1787 (make_window): Omit redundant initialization.
1789 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1791 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1793 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1795 * window.h (struct window): Change type of 'use_time' and
1796 'sequence_number' from Lisp_Object to int.
1797 * frame.c (make_frame): Adjust users accordingly.
1798 * print.c (print_object): Likewise.
1799 * window.c (select_window, Fwindow_use_time, make_parent_window)
1800 (make_window): Likewise.
1802 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1804 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1805 enabled with --enable-checking=[all,glyphs] configure option.
1806 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1807 adjust comments accordingly.
1808 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1809 undefined, adjust comments accordingly.
1810 * image.c: Likewise.
1811 * scroll.c: Likewise.
1812 * w32fns.c: Likewise.
1813 * w32term.c: Likewise.
1814 * xdisp.c: Likewise.
1815 * xfaces.c: Likewise.
1817 * xterm.c: Likewise.
1819 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1821 Generalize run-time debugging checks.
1822 * dispextern.h (XASSERTS): Remove.
1823 * fontset.c (xassert): Remove.
1824 Convert from xassert to eassert.
1825 * alloc.c: Convert from xassert to eassert.
1827 * dispnew.c: Likewise.
1829 * fringe.c: Likewise.
1830 * ftfont.c: Likewise.
1831 * gtkutil.c: Likewise.
1832 * image.c: Likewise.
1833 * keyboard.c: Likewise.
1835 * process.c: Likewise.
1836 * scroll.c: Likewise.
1837 * sound.c: Likewise.
1839 * w32console.c: Likewise.
1840 * w32fns.c: Likewise.
1841 * w32term.c: Likewise.
1842 * window.c: Likewise.
1843 * xdisp.c: Likewise.
1844 * xfaces.c: Likewise.
1846 * xselect.c: Likewise.
1847 * xterm.c: Likewise.
1849 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1851 * fns.c (maybe_resize_hash_table): Output message when growing the
1854 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1856 * alloc.c (allocate_string_data): Remove dead code.
1857 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1858 avoid GCC warning about unused macro.
1860 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1862 * alloc.c (allocate_string): Omit intervals initialization.
1863 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1864 as in make_pure_string and make_pure_c_string.
1866 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1868 * alloc.c (allocate_string): Fix last change.
1870 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1872 * alloc.c (allocate_string): Remove two redundant calls
1873 to memset, add explicit initialization where appropriate.
1875 2012-06-27 Glenn Morris <rgm@gnu.org>
1877 * lisp.mk (lisp): Remove paths.elc.
1879 2012-06-27 Chong Yidong <cyd@gnu.org>
1881 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1883 2012-06-26 John Wiegley <johnw@newartisans.com>
1885 * unexmacosx.c (copy_data_segment): Add two section names used
1886 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1888 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1889 when building with Clang.
1891 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1893 * eval.c (Fapply): Allow calling it with a single argument.
1895 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1897 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1898 _stricmp and _strnicmp.
1899 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1901 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1903 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1905 (allocate_process): Likewise for new process.
1906 (allocate_terminal): Change to use offsetof.
1907 (allocate_frame): Likewise.
1908 * frame.c (make_frame): Omit redundant initialization.
1909 * window.c (make_parent_window): Use memset.
1910 (make_window): Omit redundant initialization.
1911 * process.c (make_process): Omit redundant initialization.
1912 * terminal.c (create_terminal): Likewise.
1914 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1916 * term.c (delete_tty): Remove redundant call to memset.
1918 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1920 * alloc.c: Remove build_string.
1921 * lisp.h: Define build_string as static inline. This provides
1922 a better opportunity to optimize away calls to strlen when the
1923 function is called with compile-time constant argument.
1924 * image.c (imagemagick_error): Convert to build_string.
1925 * w32proc.c (sys_spawnve): Likewise.
1926 * xterm.c (x_term_init): Likewise.
1928 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1930 Use sprintf return value instead of invoking strlen on result.
1931 In the old days this wasn't portable, since some sprintf
1932 implementations returned char *. But they died out years ago and
1933 Emacs already assumes sprintf returns int.
1934 Similarly for float_to_string.
1935 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1936 * ccl.c (ccl_driver):
1937 * character.c (string_escape_byte8):
1938 * data.c (Fnumber_to_string):
1939 * doprnt.c (doprnt):
1940 * print.c (print_object):
1941 * xdisp.c (message_dolog):
1942 * xfns.c (syms_of_xfns):
1943 Use sprintf or float_to_string result to avoid need to call strlen.
1944 * data.c (Fnumber_to_string):
1945 Use make_unibyte_string, since the string must be ASCII.
1946 * lisp.h, print.c (float_to_string): Now returns int length.
1947 * term.c (produce_glyphless_glyph):
1948 Use sprintf result rather than recomputing it.
1950 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1951 * Makefile.in (ALL_CFLAGS):
1952 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1953 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1955 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1957 * dispextern.h (xstrcasecmp): Define to library function
1958 strcasecmp if available.
1959 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1961 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1963 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1964 Avoid comma operator.
1965 * menu.c (push_submenu_start, push_submenu_end)
1966 (push_left_right_boundary, push_menu_pane): Likewise.
1967 * msdos.c (dos_rawgetc): Likewise.
1969 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1971 * xfns.c (xic_create_fontsetname): Remove redundant calls
1974 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1976 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1977 sprintf already null-terminates its output.
1979 * xfns.c (x_window): Remove redundant cast.
1981 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1983 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1984 `const char *' to `char *' to avoid compiler warning.
1986 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1988 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1989 instead of truncating it to 63 (admittedly a generous limit).
1991 * process.c: Fix spelling and caps in comments.
1993 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1995 * emacs.c (setpgrp): Remove definition, unused.
1996 * sysdep.c (setpgrp): Remove definition, not used in this file.
1998 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2000 * makefile.w32-in: Update dependencies.
2002 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2004 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2005 (SYSTIME_H): Add nt/inc/sys/time.h.
2007 * systime.h [WINDOWSNT]: Include sys/time.h.
2009 * s/ms-w32.h (struct timespec): Definition moved from
2010 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2012 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2014 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2015 * buffer.h (buffer_slot_type_mismatch):
2016 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2017 * eval.c (unwind_to_catch):
2018 * image.c (my_png_error, my_error_exit):
2019 * keyboard.c (quit_throw_to_read_char, user_error)
2020 (Fexit_recursive_edit, Fabort_recursive_edit):
2021 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2022 (wrong_type_argument, buffer_overflow, __executable_start)
2023 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2024 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2025 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2027 (child_setup) [!DOS_NT]:
2028 * lread.c (end_of_file_error, invalid_syntax):
2029 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2030 * puresize.h (pure_write_error):
2031 * search.c (matcher_overflow):
2032 * sound.c (sound_perror, alsa_sound_perror):
2033 * sysdep.c, syssignal.h (croak):
2034 * term.c (maybe_fatal, vfatal):
2035 * textprop.c (text_read_only):
2036 * undo.c (user_error):
2037 * unexmacosx.c (unexec_error):
2038 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2039 Use _Noreturn rather than NO_RETURN.
2040 No need for separate decl merely because of _Noreturn.
2041 * sound.c (sound_warning, parse_sound):
2042 Remove unnecessary forward decls.
2044 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2046 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2047 * lisp.h (WAIT_READING_MAX): New macro.
2048 * dispnew.c (Fsleep_for, sit_for):
2049 * keyboard.c (kbd_buffer_get_event):
2050 * process.c (Faccept_process_output):
2051 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2052 This improves on the previous patch, which introduced a bug
2053 when time_t is unsigned and as wide as intmax_t.
2054 See <http://bugs.gnu.org/9000#51>.
2056 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2058 * dispnew.c (sit_for, Fsleep_for):
2059 * keyboard.c (kbd_buffer_get_event):
2060 * process.c (Faccept_process_output): Avoid compiler warnings when
2061 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2063 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2065 * makefile.w32-in: Update dependencies.
2067 * w32.c (ltime): Add return type and declare static.
2068 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2070 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2072 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2073 Privately reported by Herbert J. Skuhra.
2074 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2076 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2077 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2079 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2081 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2082 last argument of make_unibyte_string.
2084 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2085 language ID in the event parameters.
2087 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2088 event.code, not the obscure "character set ID".
2090 2012-06-23 Chong Yidong <cyd@gnu.org>
2092 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2094 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2096 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2097 * w32.c (fdutimens): New function.
2099 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2101 * s/ms-w32.h (pselect): Redirect to sys_select.
2103 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2105 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2106 in the logic of incrementing and decrementing the value of
2107 use_relocatable_buffers.
2109 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2111 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2112 Privately reported by Herbert J. Skuhra.
2113 [__FreeBSD__]: Remove "*/" typo after "#include".
2114 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2115 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2116 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2117 Don't assume EMACS_TIME and struct timeval are the same type.
2119 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2121 Support higher-resolution time stamps (Bug#9000).
2122 The time stamps are only nanosecond-resolution at the C level,
2123 since that's the best that any real-world system supports now.
2124 But they are picosecond-resolution at the Lisp level, as that's
2125 easy, and leaves room for future OS improvements.
2127 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2130 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2131 Don't get current time unless it's needed.
2133 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2134 now provides it if it's absent.
2135 (start_atimer): Port to higher-res time stamps.
2136 Check for time stamp overflow. Don't get current time more
2137 often than is needed.
2139 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2140 Include systime.h, not time.h.
2141 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2143 * dired.c: Include stat-time.h.
2144 (Ffile-attributes): File times now have higher resolution.
2146 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2147 (struct image): Timestamp now has higher resolution.
2149 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2150 has at least microseconds now. All uses removed.
2151 (update_frame, update_single_window, update_window, update_frame_1)
2152 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2154 * editfns.c (time_overflow): Now extern.
2155 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2156 (float-time, Fformat_time_string, Fcurrent_time_string)
2157 (Fcurrent_time_zone): Accept and generate higher-resolution
2159 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2160 (decode_time_components, lisp_seconds_argument): New functions.
2161 (make_time): Now static.
2162 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2163 Report an error if the time is invalid, rather than having the caller
2166 * fileio.c: Include <stat-time.h>
2167 (Fcopy_file): Copy higher-resolution time stamps.
2168 Prefer to set the time stamp via a file descriptor if that works.
2169 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2170 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2171 (Fvisited_file_modtime, Fset_visited_file_modtime):
2172 Support higher-resolution time stamps.
2174 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2176 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2178 * image.c (prepare_image_for_display, clear_image_cache)
2179 (lookup_image): Port to higer-resolution time stamps.
2181 * keyboard.c (start_polling, bind_polling_period):
2182 Check for time stamp overflow.
2183 (read_char, kbd_buffer_get_event, timer_start_idle)
2184 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2185 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2186 Port to higher-resolution time stamps. Do not assume time_t is signed.
2187 (decode_timer): New function. Timers are now vectors of length 9,
2188 not 8, to accommodate the picosecond component.
2189 (timer_check_2): Use it.
2191 * nsterm.m (select_timeout, timeval_subtract): Remove.
2192 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2193 as they're a bit more accurate and handle overflow better.
2194 (ns_select): Change prototype to be compatible with pselect.
2195 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2196 * nsterm.h (ns_select): Adjust prototype.
2198 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2199 us-resolution time stamps.
2200 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2202 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2204 * lisp.h (time_overflow): New decl.
2205 (wait_reading_process_output): First arg is now intmax_t, not int,
2206 to accommodate larger waits.
2208 * process.h (struct Lisp_Process.read_output_delay):
2209 Now counts nanoseconds, not microseconds.
2210 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2212 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2213 (wait_reading_process_output):
2214 Port to ns-resolution time stamps.
2215 (Faccept_process_output, wait_reading_process_output):
2216 Check for time stamp overflow. Do not assume time_t is signed.
2217 (select_wrapper): Remove; we now use pselect.
2218 (Fprocess_attributes): Now generates ns-resolution time stamps.
2220 * sysdep.c: Include utimens.h. Don't include utime.h
2221 or worry about struct utimbuf; gnulib does that for us now.
2222 (gettimeofday): Remove; gnulib provides a substitute.
2223 (make_timeval): New function.
2224 (set_file_times): Now sets ns-resolution time stamps.
2225 New arg FD; all uses changed.
2226 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2227 (system_process_attributes):
2228 Now returns ns-resolution time stamp. All uses changed.
2229 Check for time stamp overflow.
2231 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2232 provides a substitute now.
2234 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2235 since it guarantees struct timespec.
2236 (EMACS_TIME): Now struct timespec, so that we can support
2237 ns-resolution time stamps.
2238 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2239 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2240 (EMACS_USECS): Remove.
2241 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2242 so multiply the arg by 1000 before storing it.
2243 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2245 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2246 Port to ns-resolution time stamps.
2247 (EMACS_TIME_NEG_P): Remove; replaced by....
2248 (EMACS_TIME_SIGN): New macro.
2249 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2250 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2251 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2252 (make_timeval, make_lisp_time, decode_time_components): New decls.
2253 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2254 that it mishandled time_t overflow. You can't compare by subtracting!
2255 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2256 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2258 * term.c: Include <sys/time.h>.
2259 (timeval_to_Time): New function, for proper overflow wraparound.
2260 (term_mouse_position, term_mouse_click): Use it.
2262 * undo.c (record_first_change): Support higher-resolution time stamps
2264 (Fprimitive_undo): Use them when restoring time stamps.
2266 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2267 (w32_get_internal_run_time):
2268 Port to higher-resolution Emacs time stamps.
2269 (ltime): Now accepts single 64-bit integer, as that's more convenient
2272 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2274 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2275 for compatibility with pselect. Support ns-resolution time stamps.
2277 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2279 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2280 Check for time stamp overflow, and support ns-resolution time stamps.
2282 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2283 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2284 (timeval_subtract): Remove; no longer needed.
2285 (XTflash, XTring_bell, x_wait_for_event):
2286 Port to ns-resolution time stamps. Don't assume time_t is signed.
2288 2012-06-22 Chong Yidong <cyd@gnu.org>
2290 * xdisp.c (x_consider_frame_title): Revert last change.
2292 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2294 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2295 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2296 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2297 staticidx goes up to 1597 out of 1600 = 0x640.)
2299 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2301 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2302 Otherwise, the umask might be mistakenly 0 while handling input signals.
2304 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2306 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2308 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2310 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2311 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2312 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2313 access to `contents' member of Lisp_Vector objects with AREF and ASET
2316 2012-06-19 Chong Yidong <cyd@gnu.org>
2318 * frame.c (delete_frame): When selecting a frame on a different
2319 text terminal, do not alter the terminal's top-frame.
2321 * xdisp.c (format_mode_line_unwind_data): Record the target
2322 frame's selected window and its terminal's top-frame.
2323 (unwind_format_mode_line): Restore them.
2324 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2326 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2327 since tty frames can be explicitly named.
2328 (prepare_menu_bars): Likewise.
2330 * term.c (Ftty_top_frame): New function.
2332 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2334 Port byte-code-meter to modern targets.
2335 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2336 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2337 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2338 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2339 (METER_1, METER_2): Simplify.
2341 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2343 * data.c (Fdefalias): Return `symbol' (bug#11686).
2345 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2347 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2348 gets killed during executing of this function (Bug#11665).
2349 Try to always return Qt when the buffer has been actually killed.
2350 (Vkill_buffer_query_functions): In doc-string say that functions
2351 run by this hook should not change the current buffer.
2353 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2355 Fix recently-introduced process.c problems found by static checking.
2356 * process.c (write_queue_push, write_queue_pop, send_process):
2357 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2358 (write_queue_pop): Fix pointer signedness problem.
2359 (send_process): Remove unused local.
2361 2012-06-17 Chong Yidong <cyd@gnu.org>
2363 * xdisp.c (redisplay_internal): No need to redisplay terminal
2364 frames that are not on top.
2366 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2368 * process.c (make_process): Initialize write_queue.
2369 (write_queue_push, write_queue_pop): New functions.
2370 (send_process): Use them to maintain correct ordering of process
2373 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2375 * lisp.h (eassert): Assume C89 or later.
2376 This removes the need for CHECK.
2377 (CHECK): Remove. Its comments about always evaluating its
2378 argument were confusing, as 'eassert' typically does not evaluate
2381 * coding.c (produce_chars): Use ptrdiff_t, not int.
2383 * xterm.c (x_draw_underwave): Check for integer overflow.
2384 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2386 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2388 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2389 referenced (Bug#11583).
2391 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2393 Implement wave-style variant of underlining.
2394 * dispextern.h (face_underline_type): New enum.
2395 (face): Add field for underline type.
2396 * nsterm.m (ns_draw_underwave): New function.
2397 (ns_draw_text_decoration): Use it.
2398 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2400 (x_draw_glyph_string): Use them.
2401 * xfaces.c (Qline, Qwave): New Lisp objects.
2402 (check_lface_attrs, merge_face_ref)
2403 (Finternal_set_lisp_face_attribute, realize_x_face):
2404 Handle wave-style underline face attributes.
2405 * xterm.c (x_draw_underwave): New function.
2406 (x_draw_glyph_string): Use it.
2408 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2410 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2411 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2412 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2413 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2414 ($(BLD)/w32select.$(O)): Update dependencies.
2416 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2418 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2419 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2420 * character.c (_fetch_multibyte_char_p): Remove.
2421 * alloc.c: Include "character.h" before "buffer.h".
2423 * buffer.c: Likewise.
2424 * bytecode.c: Likewise.
2425 * callint.c: Likewise.
2426 * callproc.c: Likewise.
2427 * casefiddle.c: Likewise.
2428 * casetab.c: Likewise.
2429 * category.c: Likewise.
2431 * coding.c: Likewise.
2432 * composite.c: Likewise.
2433 * dired.c: Likewise.
2434 * dispnew.c: Likewise.
2436 * dosfns.c: Likewise.
2437 * editfns.c: Likewise.
2438 * emacs.c: Likewise.
2439 * fileio.c: Likewise.
2440 * filelock.c: Likewise.
2442 * fontset.c: Likewise.
2443 * fringe.c: Likewise.
2444 * indent.c: Likewise.
2445 * insdel.c: Likewise.
2446 * intervals.c: Likewise.
2447 * keyboard.c: Likewise.
2448 * keymap.c: Likewise.
2449 * lread.c: Likewise.
2450 * macros.c: Likewise.
2451 * marker.c: Likewise.
2452 * minibuf.c: Likewise.
2453 * nsfns.m: Likewise.
2454 * nsmenu.m: Likewise.
2455 * print.c: Likewise.
2456 * process.c: Likewise.
2457 * regex.c: Likewise.
2458 * region-cache.c: Likewise.
2459 * search.c: Likewise.
2460 * syntax.c: Likewise.
2462 * textprop.c: Likewise.
2464 * unexsol.c: Likewise.
2465 * w16select.c: Likewise.
2466 * w32fns.c: Likewise.
2467 * w32menu.c: Likewise.
2468 * window.c: Likewise.
2469 * xdisp.c: Likewise.
2471 * xmenu.c: Likewise.
2473 * xselect.c: Likewise.
2475 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2478 If all the glyphs of the glyph row came from strings, and we have no
2479 cursor positioning clues, put the cursor on the first glyph of the
2481 (handle_face_prop): Use chunk-relative overlay string index when
2482 indexing into it->string_overlays array. (Bug#11653)
2483 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2484 the rightmost. (Bug#11720)
2486 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2488 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2489 (CATEGORY_MEMBER): Enforce 1/0 value.
2490 * category.c (_temp_category_set): Remove.
2492 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2494 * window.c (Fdelete_other_windows_internal)
2495 (Fdelete_window_internal): Don't access frame's mouse highlight
2496 info of the initial frame. (Bug#11677)
2498 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2500 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2501 Assume USE_2_TAGS_FOR_INTS.
2502 (xreload): Adjust $tagmask width to match recent lisp.h change.
2504 Simplify lisp.h in minor ways that should not affect code.
2505 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2506 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2507 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2508 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2509 (INTTYPEBITS): New macro, for clarity.
2510 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2511 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2512 Simplify now that USE_LSB_TAG is always defined.
2513 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2514 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2516 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2518 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2520 2012-06-13 Glenn Morris <rgm@gnu.org>
2522 * s/bsd-common.h (BSD4_3):
2523 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2525 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2527 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2530 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2532 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2533 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2534 * alloc.c (widen_to_Lisp_Object): Remove.
2535 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2536 * frame.c (delete_frame): Remove outdated comment.
2537 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2538 USE_LISP_UNION_TYPE.
2539 (Fw32_unregister_hot_key): Likewise.
2540 (Fw32_toggle_lock_key): Likewise.
2541 * w32menu.c (add_menu_item): Likewise.
2542 (w32_menu_display_help): Use XIL instead of checking
2543 USE_LISP_UNION_TYPE.
2544 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2545 (init_heap): Likewise.
2546 * w32term.c (w32_read_socket): Update comment.
2548 2012-06-13 Glenn Morris <rgm@gnu.org>
2550 * s/usg5-4-common.h, src/s/unixware.h:
2551 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2553 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2555 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2557 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2558 * alloc.c (make_number) [!defined make_number]:
2559 Remove, as lisp.h always defines this now.
2560 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2561 (roundup_size): Verify that it is a power of 2.
2562 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2563 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2564 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2565 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2566 USE_LSB_TAG now is always defined to be either 0 or 1.
2568 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2569 code works fine either way, and efficiency is not a concern here,
2570 as the union type is for debugging, not for production.
2571 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2572 Use an inline function on all platforms when using the union type,
2573 since this is simpler and 'static inline' can be used portably
2575 (LISP_INITIALLY_ZERO): New macro.
2576 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2577 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2579 2012-06-12 Glenn Morris <rgm@gnu.org>
2581 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2583 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2585 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2586 Move BROKEN_SIGIO to configure.
2588 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2589 Move NO_TERMIO to configure.
2591 2012-06-12 Chong Yidong <cyd@gnu.org>
2593 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2594 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2595 MagickExportImagePixels is undefined.
2597 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2599 * image.c (imagemagick_load_image): Remove unused label.
2601 2012-06-11 Glenn Morris <rgm@gnu.org>
2603 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2604 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2605 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2606 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2608 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2610 * alloc.c (make_byte_code): New function.
2611 (Fmake_byte_code): Use it. Don't purify here.
2612 * lread.c (read1): Use it as well to avoid extra allocation.
2614 2012-06-11 Chong Yidong <cyd@gnu.org>
2616 * image.c (imagemagick_load_image): Implement transparency.
2618 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2620 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2621 account for preceding backslashes. (Bug#11663)
2623 2012-06-09 Chong Yidong <cyd@gnu.org>
2625 * term.c: Support italics in capable terminals (Bug#9652).
2626 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2627 (turn_on_face): Output using TS_enter_italic_mode if available.
2628 Don't handle unused blinking and alt-charset cases.
2629 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2630 and tty_alt_charset_p cases.
2631 (tty_capable_p, init_tty): Support italics.
2633 * termchar.h (struct tty_display_info): Add field for italics.
2634 Remove unused blink field.
2636 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2639 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2640 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2641 tty_alt_charset_p. Add tty_italic_p.
2643 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2645 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2646 dbus_type_is_basic if available.
2647 (xd_extract_signed, xd_extract_unsigned): Rename from
2648 extract_signed and extract_unsigned, respectively. Adapt callers.
2650 2012-06-09 Chong Yidong <cyd@gnu.org>
2652 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2654 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2657 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2659 * xdisp.c (vmessage): Treat frame message as multibyte.
2660 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2661 would generate the diagnostic "Making \302\247 buffer-local while
2664 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2666 * dispnew.c (showing_window_margins_p): Undo last change, which
2667 was done due to an inadvertent commit.
2668 (adjust_frame_glyphs_for_frame_redisplay): Do call
2669 showing_window_margins_p.
2671 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2673 * eval.c (Fmake_var_non_special): New primitive.
2674 (syms_of_eval): Defsubr it.
2675 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2677 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2679 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2680 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2682 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2684 * alloc.c (allocate_vectorlike): Fix last change.
2686 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2688 Block-based vector allocation of small vectors.
2689 * lisp.h (struct vectorlike_header): New field `nbytes',
2690 adjust comment accordingly.
2691 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2692 to denote vector blocks. Adjust users (live_vector_p,
2693 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2694 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2695 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2696 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2697 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2698 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2699 (roundup_size): New constant.
2700 (struct vector_block): New data type.
2701 (vector_blocks, vector_free_lists, zero_vector): New variables.
2702 (all_vectors): Rename to `large_vectors'.
2703 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2704 (sweep_vectors): New functions.
2705 (allocate_vectorlike): Return `zero_vector' as the only vector of
2706 0 items. Allocate new vector from block if vector size is less than
2707 or equal to VBLOCK_BYTES_MAX.
2708 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2709 (init_alloc_once): Add call to init_vectors.
2711 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2713 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2715 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2717 * doprnt.c (doprnt): Truncate multibyte char correctly.
2718 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2719 would mishandle a string argument "Xc" if X was a multibyte
2720 character of length 2: it would truncate after X's first byte
2721 rather than including all of X.
2723 2012-06-06 Chong Yidong <cyd@gnu.org>
2725 * buffer.c (word_wrap): Doc fix.
2727 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2729 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2731 2012-06-03 Glenn Morris <rgm@gnu.org>
2733 * xdisp.c (tool-bar-style): Doc fix.
2735 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2737 * Makefile.in (PAXCTL): Define.
2738 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2739 binary via PaX flags if the paxctl utility is available.
2740 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2741 Restore PaX flags to their default. (Bug#11398)
2743 2012-06-03 Chong Yidong <cyd@gnu.org>
2745 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2748 2012-06-03 Chong Yidong <cyd@gnu.org>
2750 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2751 (note_mode_line_or_margin_highlight): If there is no help echo,
2752 use mode-line-default-help-echo. Handle the case where the mouse
2753 position is past the end of the mode line string.
2755 * buffer.c (buffer_local_value_1): New function, split from
2756 Fbuffer_local_value; can return Qunbound.
2757 (Fbuffer_local_value): Use it.
2758 (Vmode_line_format): Docstring tweaks.
2760 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2762 * sysdep.c (system_process_attributes): Improve comment.
2764 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2766 * keyboard.c: Export real-this-command to Elisp.
2767 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2768 and DEFVAR it. Update all users.
2770 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2772 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2774 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2775 Convert pctcpu and pctmem to Lisp float properly.
2776 Let the compiler fold better, as 100.0/0x8000 is exact.
2778 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2780 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2783 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2785 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2787 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2789 For a 'struct window', replace some Lisp_Object fields to
2790 bitfields where appropriate, remove unused fields.
2791 * window.h (struct window): Remove unused 'last_mark_x' and
2792 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2793 change it's type from Lisp_Object to bitfield.
2794 Change type of 'force_start', 'optional_new_start',
2795 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2796 fields from Lisp_Object to bitfield. Adjust users accordingly.
2798 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2800 Pacify gcc -Wdouble-precision when using Xaw.
2801 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2802 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2803 Use 'float' consistently, rather than 'float' in most places
2804 and 'double' in a couple of places.
2806 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2808 * xdisp.c (handle_stop): Detect whether we have overlay strings
2809 loaded by testing it->current.overlay_string_index to be
2810 non-negative, instead of checking whether n_overlay_strings is
2811 positive. (Bug#11587)
2813 2012-05-31 Chong Yidong <cyd@gnu.org>
2815 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2817 * doc.c (Fsubstitute_command_keys): Doc fix.
2819 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2821 * search.c (search_buffer): Remove calls to
2822 r_alloc_inhibit_buffer_relocation, as it is now called by
2823 maybe_unify_char, which was the cause of relocation of buffer text
2826 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2828 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2829 for the duration of call to load_charset, to avoid problems with
2830 callers of maybe_unify_char that access buffer text through C
2833 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2834 decrement the inhibition flag, instead of just setting or
2837 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2839 Remove obsolete '#define static' cruft.
2840 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2841 This #undef was "temporary" in 2000; it is no longer needed
2842 now that '#define static' has gone away.
2843 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2844 (gray_bitmap_bits): Remove; no longer needed.
2845 All uses replaced with definiens.
2846 * xterm.c: Include "bitmaps/gray.xbm".
2848 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2850 Clean up __executable_start, monstartup when --enable-profiling.
2851 The following changes affect the code only when profiling.
2852 * dispnew.c (__executable_start): Rename from safe_bcopy.
2853 Define only on platforms that need it.
2854 * emacs.c: Include <sys/gmon.h> when profiling.
2855 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2856 (__executable_start): Remove decl, since lisp.h does it now.
2857 (safe_bcopy): Remove decl; no longer has that name.
2858 (main): Coalesce #if into single bit of code, for simplicity.
2859 Cast pointers to uintptr_t, since standard libraries want integers
2861 * lisp.h (__executable_start): New decl.
2863 2012-05-31 Glenn Morris <rgm@gnu.org>
2865 * image.c (Fimagemagick_types): Doc fix.
2867 2012-05-30 Jim Meyering <meyering@redhat.com>
2869 * callproc.c (Fcall_process_region): Include directory component
2870 in mkstemp error message (Bug#11586).
2872 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2874 * alloc.c, lisp.h (make_pure_vector): Now static.
2876 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2878 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2879 Move to byte-run.el.
2880 (Fautoload): Do the hash-doc more carefully.
2881 * data.c (Fdefalias): Purify definition, except for keymaps.
2882 (Qdefun): Move from eval.c.
2883 * lisp.h (Qdefun): Remove.
2884 * lread.c (read1): Tiny simplification.
2886 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2888 Do not create empty overlays with the evaporate property (Bug#9642).
2889 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2890 Bug#9642, but explicitly check that the buffer the overlay would
2891 be moved to is live and rearrange lines to make sure that errors
2892 will not put the overlay in an inconsistent state.
2893 (Fdelete_overlay): Cosmetics.
2895 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2897 * w32term.c (my_bring_window_to_top): New function.
2898 (x_raise_frame): Use handle returned by DeferWindowPos, which
2899 could be different from the original one.
2900 Call my_bring_window_to_top instead of my_set_foreground_window.
2903 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2904 by calling BringWindowToTop.
2906 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2907 (WM_EMACS_END): Increase by one.
2909 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2911 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2912 This avoids undefined behavior that might cause the eassert
2913 to not catch an out-of-range value.
2915 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2917 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2918 Update dependencies.
2920 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2922 * bidi.c (bidi_mirror_char): Fix last change.
2924 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2926 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2927 when referring to sectname field in printf format.
2929 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2931 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2932 Only r_alloc_inhibit_buffer_relocation needed to be added;
2933 the others were already declared.
2935 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2936 before checking whether it's out of range. Put the check inside
2938 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2940 2012-05-27 Ken Brown <kbrown@cornell.edu>
2942 * callproc.c (Fcall_process): Restore a line that was accidentally
2943 commented out in the 2011-02-13 change (bug#11547).
2945 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2947 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2948 defined on ralloc.c.
2950 * buffer.c [REL_ALLOC]: Remove prototypes of
2951 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2952 they are now on lisp.h.
2954 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2956 * search.c (search_buffer): Use it to inhibit relocation of buffer
2957 text while re_search_2 is doing its job, because re_search_2 is
2958 passed C pointers to buffer text. (Bug#11519)
2960 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2963 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2964 state after an additional call to move_it_in_display_line_to, keep
2965 the values of it->max_ascent and it->max_descent found for the
2967 (pos_visible_p): Revert the comparison against bottom_y to what it
2968 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2971 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2973 Fix coding-related core dumps with gcc -ftrapv.
2974 The code was computing A - B, where A and B are pointers, and B is
2975 random garbage. This can lead to core dumps on platforms that
2976 have special pointer registers, and it also leads to core dumps on
2977 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2978 A - B only when B is initialized properly.
2979 * coding.c (coding_set_source, coding_set_destination): Return void.
2980 (coding_change_source, coding_change_destinations): New functions,
2981 with the old behaviors of coding_set_source and coding_set_destination.
2982 All callers that need an offset changed to use these new functions.
2984 2012-05-26 Glenn Morris <rgm@gnu.org>
2986 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2988 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2990 Extend mouse support on W32 text-mode console.
2991 * xdisp.c (draw_row_with_mouse_face):
2992 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2994 * w32console.c: Include window.h.
2995 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2997 (initialize_w32_display): Initialize mouse-highlight data.
2999 * w32inevt.c: Include termchar.h and window.h.
3000 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3001 moves, call note_mouse_highlight. If help_echo changed, call
3002 gen_help_event to produce help-echo message in the echo area.
3003 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3006 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3008 * lread.c (read1): Simplify slightly to avoid an overflow warning
3009 with GCC 4.7.0 on x86-64.
3011 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3013 * bidi.c (bidi_mirror_char): Revert last change: an int is
3014 definitely wide enough here.
3016 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3018 Fix integer width and related bugs (Bug#9874).
3019 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3020 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3021 (string_bytes, check_sblock, allocate_string_data):
3022 (compact_small_strings, Fmake_bool_vector, make_string)
3023 (make_unibyte_string, make_multibyte_string)
3024 (make_string_from_bytes, make_specified_string)
3025 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3026 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3029 (allocate_pseudovector):
3030 Use int, not EMACS_INT, where int is wide enough.
3031 (inhibit_garbage_collection, Fgarbage_collect):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3034 int might not be wide enough.
3035 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3036 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3037 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3038 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3039 (bidi_level_of_next_char, bidi_move_to_visually_next):
3040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3041 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3042 (Fkill_buffer, Fset_buffer_major_mode)
3043 (advance_to_char_boundary, Fbuffer_swap_text)
3044 (Fset_buffer_multibyte, overlays_at, overlays_in)
3045 (overlay_touches_p, struct sortvec, record_overlay_string)
3046 (overlay_strings, recenter_overlay_lists)
3047 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3048 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3049 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3050 (Foverlay_recenter, last_overlay_modification_hooks_used)
3051 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3053 (validate_region): Omit unnecessary test for b <= e,
3054 since that's guaranteed by the previous test.
3055 (adjust_overlays_for_delete): Avoid pos + length overflow.
3056 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3057 (report_overlay_modification):
3058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3059 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3060 Omit pointer cast, which isn't needed anyway, and doesn't work
3061 after the EMACS_INT -> ptrdiff_t change.
3062 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3063 * buffer.h: Adjust decls to match defn changes elsewhere.
3064 (struct buffer_text, struct buffer):
3065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3066 Use EMACS_INT, not int, where int might not be wide enough.
3067 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3068 not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 (exec_byte_code): Use tighter memory-full test, one that checks
3070 for alloca overflow. Don't compute the address of the object just
3071 before an array, as that's not portable. Use EMACS_INT, not
3072 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3073 * callint.c (Fcall_interactively):
3074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3075 * callproc.c (call_process_kill, Fcall_process):
3076 Don't assume pid_t fits into an Emacs fixnum.
3077 (call_process_cleanup, Fcall_process, child_setup):
3078 Don't assume pid_t fits into int.
3079 (call_process_cleanup, Fcall_process, delete_temp_file)
3080 (Fcall_process_region):
3081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3082 (Fcall_process): Simplify handling of volatile integers.
3083 Use int, not EMACS_INT, where int will do.
3084 * casefiddle.c (casify_object, casify_region, operate_on_word)
3085 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3087 (casify_object): Avoid integer overflow when overallocating buffer.
3088 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3089 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3090 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3091 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3092 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3093 integers are now checked earlier. All uses replaced with XINT.
3095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3096 For CCL_MapSingle, check that content and value are in int range.
3097 (ccl_driver, Fregister_code_conversion_map):
3098 Check that Vcode_version_map_vector is a vector.
3099 (resolve_symbol_ccl_program): Check that vector header is in range.
3100 Always copy the vector, so that we can check its contents reliably
3101 now rather than having to recheck each instruction as it's being
3102 executed. Check that vector words fit in 'int'.
3103 (ccl_get_compiled_code, Fregister_ccl_program)
3104 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3105 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3106 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3107 contents are in range.
3108 (Fccl_execute_on_string): Check that status is in range.
3109 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3110 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3111 Accept and return EMACS_INT, not int, because callers can pass values
3113 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3114 (multibyte_chars_in_text, parse_str_as_multibyte)
3115 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3116 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3117 (string_escape_byte8, Fget_byte):
3118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3119 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3120 avoid mishandling large integers.
3121 * character.h: Adjust decls to match defn changes elsewhere.
3122 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3123 (Ffind_charset_region):
3124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3125 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3126 (load_charset_map_from_vector, Fdefine_charset_internal):
3127 Don't assume fixnum fits in int.
3128 (load_charset_map_from_vector, Fmap_charset_chars):
3129 Remove now-unnecessary CHECK_NATNUMs.
3130 (Fdefine_charset_internal): Check ranges here, more carefully.
3131 Don't rely on undefined behavior with signed left shift overflow.
3132 Don't assume unsigned int fits into fixnum, or that fixnum fits
3133 into unsigned int. Don't require max_code to be a valid fixnum;
3134 that's not true for gb10830 4-byte on a 32-bit host. Allow
3135 invalid_code to be a cons, for the same reason. Require code_offset
3136 to be a character. Avoid int overflow if max_char is close
3138 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3139 this is intended anyway and avoids some undefined behavior.
3140 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3141 INDEX_TO_CODE_POINT, as that's what it expects.
3142 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3143 * charset.h (DECODE_CHAR): Return int, not unsigned;
3144 this is what was intended anyway, and it avoids undefined behavior.
3145 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3146 integer-overflow issues.
3147 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3148 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3149 where the argument is EMACS_INT, and this behavior is not intended.
3150 * chartab.c (Fmake_char_table, Fset_char_table_range)
3151 (uniprop_get_decoder, uniprop_get_encoder):
3152 Don't assume fixnum fits in int.
3153 * cmds.c (move_point): New function, that does the gist of
3154 Fforward_char and Fbackward_char, but does so while checking
3155 for integer overflow more accurately.
3156 (Fforward_char, Fbackward_char): Use it.
3157 (Fforward_line, Fend_of_line, internal_self_insert)
3158 (internal_self_insert):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 Fix a FIXME, by checking for integer overflow when calculating
3161 target_clm and actual_clm.
3162 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3163 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3164 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3165 (coding_alloc_by_making_gap, alloc_destination)
3166 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3167 (encode_coding_utf_16, detect_coding_emacs_mule)
3168 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3169 (detect_coding_iso_2022, decode_coding_iso_2022)
3170 (encode_invocation_designation, encode_designation_at_bol)
3171 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3172 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3173 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3174 (encode_coding_ccl, encode_coding_raw_text)
3175 (detect_coding_charset, decode_coding_charset)
3176 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3177 (produce_composition, produce_charset, produce_annotation)
3178 (decode_coding, handle_composition_annotation)
3179 (handle_charset_annotation, consume_chars, decode_coding_gap)
3180 (decode_coding_object, encode_coding_object, detect_coding_system)
3181 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3182 (code_convert_region, code_convert_string)
3183 (Fdefine_coding_system_internal)
3184 (coding_set_source, coding_set_destination):
3185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3186 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3187 (Fdefine_coding_system_internal):
3188 Don't assume fixnums fit in int.
3189 (decode_coding_gap, decode_coding_object, encode_coding_object)
3190 (Fread_coding_system, Fdetect_coding_region)
3191 (Funencodable_char_position, Fcheck_coding_systems_region)
3192 (get_translation, handle_composition_annotation, consume_chars):
3193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3194 (consume_chars): Rewrite to not calculate an address outside buffer.
3195 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3196 Don't access memory outside of the args array.
3197 (Fdefine_coding_system_internal): Check for charset-id overflow.
3198 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3199 result of ENCODE_CHAR.
3200 * coding.h: Adjust decls to match defn changes elsewhere.
3201 (struct coding_system):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 * composite.c (get_composition_id, find_composition)
3204 (run_composition_function, update_compositions)
3205 (compose_text, composition_gstring_put_cache)
3206 (composition_gstring_p, composition_gstring_width)
3207 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3208 (composition_compute_stop_pos, composition_reseat_it)
3209 (composition_update_it, struct position_record)
3210 (find_automatic_composition, composition_adjust_point)
3211 (Fcomposition_get_gstring, Ffind_composition_internal):
3212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3213 (update_compositions):
3214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3215 * composite.h: Adjust decls to match defn changes elsewhere.
3216 (struct composition):
3217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3218 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3219 Do not attempt to compute the address of the object just before a
3220 buffer; this is not portable.
3222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3223 (Faset): Use int, not EMACS_INT, where int is wide enough.
3224 (Fstring_to_number): Don't assume fixnums fit in int.
3225 (Frem): Don't assume arg is nonnegative.
3226 * dbusbind.c (xd_append_arg): Check for integers out of range.
3227 (Fdbus_call_method): Don't overflow the timeout int.
3228 (extract_signed, extract_unsigned): New functions.
3229 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3230 (xd_get_connection_references): Return ptrdiff_t, not int.
3232 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3233 (xd_read_message_1):
3234 Use int, not unsigned, where the dbus API uses int.
3235 (Fdbus_message_internal): Don't overflow mtype.
3236 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3237 * dired.c (directory_files_internal, file_name_completion, scmp)
3238 (file_name_completion_stat):
3239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3240 (file_name_completion): Don't overflow matchcount.
3241 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3242 * dispextern.h: Adjust decls to match defn changes elsewhere.
3243 (struct text_pos, struct glyph, struct bidi_saved_info)
3244 (struct bidi_string_data, struct bidi_it, struct composition_it)
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 (struct display_pos, struct composition_it, struct it):
3248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3249 * dispnew.c (increment_matrix_positions)
3250 (increment_row_positions, mode_line_string)
3251 (marginal_area_string):
3252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3253 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3255 (duration_to_sec_usec): New function, to check for overflow better.
3256 (Fsleep_for, sit_for): Use it.
3257 * doc.c (get_doc_string, store_function_docstring):
3258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3259 (get_doc_string, Fsnarf_documentation):
3260 Use int, not EMACS_INT, where int is wide enough.
3262 Use SAFE_ALLOCA, not alloca.
3263 Check for overflow when converting EMACS_INT to off_t.
3264 * doprnt.c (doprnt):
3265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3266 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3267 Don't assume uid_t fits into fixnum.
3268 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3269 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3270 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3271 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3272 (general_insert_function)
3273 (Finsert_char, make_buffer_string, make_buffer_string_both)
3274 (update_buffer_properties, Fbuffer_substring)
3275 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3276 (Fsubst_char_in_region, check_translation)
3277 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3278 (transpose_markers, Ftranspose_regions):
3279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3280 (clip_to_bounds): Move to lisp.h as an inline function).
3281 (Fconstrain_to_field): Don't assume integers are nonnegative.
3282 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3283 (Fsubst_char_in_region, Fsave_restriction):
3284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3285 (Femacs_pid): Don't assume pid_t fits into fixnum.
3286 (lo_time): Use int, not EMACS_INT, when int suffices.
3287 (lisp_time_argument): Check for usec out of range.
3288 (Fencode_time): Don't assume fixnum fits in int.
3289 (Fuser_login_name, Fuser_full_name): Signal an error
3290 if a uid argument is out of range, rather than relying on
3292 (Fformat_time_string): Remove now-unnecessary check.
3293 lisp_time_argument checks for out-of-range usec now.
3294 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3295 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3296 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3297 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3298 (init_cmdargs, Fdump_emacs):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3301 the bottom (typically) 32 bits of the fixnum.
3302 * eval.c (specpdl_size, call_debugger):
3303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3304 (when_entered_debugger, Fbacktrace_debug):
3305 Don't assume fixnum can fit in int.
3306 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3307 the object just before a buffer; this is not portable.
3308 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3309 (grow_specpdl, unbind_to):
3310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3311 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3312 (grow_specpdl): Simplify allocation by using xpalloc.
3313 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3314 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3315 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3317 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3320 (Fcopy_file, non_regular_nbytes, read_non_regular)
3321 (Finsert_file_contents):
3322 Use int, not EMACS_INT, where int is wide enough.
3323 (READ_BUF_SIZE): Verify that it fits in int.
3324 (Finsert_file_contents): Check that counts are in proper range,
3325 rather than assuming fixnums fit into ptrdiff_t etc.
3326 Don't assume fixnums fit into int.
3327 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3328 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3329 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3330 (string_char_to_byte, string_byte_to_char)
3331 (string_make_multibyte, string_to_multibyte)
3332 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3333 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3334 (substring_both, Fdelete, internal_equal, Ffillarray)
3335 (Fclear_string, mapcar1)
3336 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3337 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3338 (larger_vector, make_hash_table, maybe_resize_hash_table)
3339 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3340 (Fmaphash, secure_hash):
3341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3342 (concat): Check for string index and length overflow.
3343 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3346 (larger_vector): New API (vec, incr_min, size_max) replaces old
3347 one (vec, new_size, init). This catches size overflow.
3348 INIT was removed because it was always Qnil.
3349 All callers changed.
3350 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3351 the upper bound on a hash table index size.
3352 (make_hash_table, maybe_resize_hash_table): Use it.
3353 (secure_hash): Computer start_byte and end_byte only after
3354 they're known to be in ptrdiff_t range.
3355 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3356 (Ffont_get_glyphs, Ffont_at):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3359 (Flist_fonts, Fopen_font):
3360 Don't assume fixnum can fit in int.
3361 (check_gstring): Don't assume index can fit in int.
3362 (font_match_p): Check that fixnum is a character, not a nonnegative
3363 fixnum, since the later code needs to stuff it into an int.
3364 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3365 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3366 conversion overflow issues.
3367 (Fopen_font): Check for integer out of range.
3368 (Ffont_get_glyphs): Don't assume index can fit in int.
3369 * font.h: Adjust decls to match defn changes elsewhere.
3370 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3372 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3373 printmax_t, where ptrdiff_t is wide enough.
3374 (Finternal_char_font):
3375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3376 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3377 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3378 (Fset_frame_position, x_set_frame_parameters)
3379 (x_set_line_spacing, x_set_border_width)
3380 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3381 Check that fixnums are in proper range for system types.
3382 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3385 Use SAFE_ALLOCA_LISP, not alloca.
3386 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3387 intptr_t is wide enough.
3388 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3389 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3390 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3391 Check for fixnum out of range.
3392 * ftfont.c (ftfont_list): Don't assume index fits in int.
3393 Check that fixnums are in proper range for system types.
3394 (ftfont_shape_by_flt):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3396 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3399 Check that fixnums are in proper range for system types.
3400 * gnutls.h: Adjust decls to match defn changes elsewhere.
3401 * gtkutil.c (xg_dialog_run):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 (update_frame_tool_bar):
3404 Check that fixnums are in proper range for system types.
3405 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3406 (lookup_image): Check that fixnums are in range for system types.
3407 * indent.c (last_known_column, last_known_column_point):
3408 (current_column_bol_cache):
3409 (skip_invisible, current_column, check_display_width):
3410 (check_display_width, scan_for_column, current_column_1)
3411 (Findent_to, Fcurrent_indentation, position_indentation)
3412 (indented_beyond_p, Fmove_to_column, compute_motion):
3413 (Fcompute_motion, Fvertical_motion):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (last_known_column_modified): Use EMACS_INT, not int.
3416 (check_display_width):
3418 Check that fixnums and floats are in proper range for system types.
3419 (compute_motion): Don't assume index or fixnum fits in int.
3420 (compute_motion, Fcompute_motion):
3421 Use int, not EMACS_INT, when it is wide enough.
3422 (vmotion): Omit local var start_hpos that is always 0; that way
3423 we don't need to worry about overflow in expressions involving it.
3424 * indent.h: Adjust decls to match defn changes elsewhere.
3426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3427 Use int, not EMACS_INT, where int is wide enough.
3428 Remove unused members ovstring_chars_done and tab_offset;
3430 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3431 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3432 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3433 (make_gap, copy_text, insert, insert_and_inherit)
3434 (insert_before_markers, insert_before_markers_and_inherit)
3435 (insert_1, count_combining_before, count_combining_after)
3436 (insert_1_both, insert_from_string)
3437 (insert_from_string_before_markers, insert_from_string_1)
3438 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3439 (adjust_after_replace, adjust_after_insert, replace_range)
3440 (replace_range_2, del_range, del_range_1, del_range_byte)
3441 (del_range_both, del_range_2, modify_region)
3442 (prepare_to_modify_buffer, signal_before_change)
3443 (signal_after_change, Fcombine_after_change_execute):
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3446 (balance_an_interval, split_interval_right, split_interval_left)
3447 (find_interval, next_interval, update_interval)
3448 (adjust_intervals_for_insertion, delete_node, delete_interval)
3449 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3450 (static_offset_intervals, offset_intervals)
3451 (merge_interval_right, merge_interval_left, make_new_interval)
3452 (graft_intervals_into_buffer, temp_set_point_both)
3453 (temp_set_point, set_point, adjust_for_invis_intang)
3454 (set_point_both, move_if_not_intangible, get_property_and_range)
3455 (get_local_map, copy_intervals, copy_intervals_to_string)
3456 (compare_string_intervals, set_intervals_multibyte_1):
3457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3458 * intervals.h: Adjust decls to match defn changes elsewhere.
3460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3461 * keyboard.c (this_command_key_count, this_single_command_key_start)
3462 (before_command_key_count, before_command_echo_length, echo_now)
3463 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3464 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3465 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3466 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (last_non_minibuf_size, last_point_position, echo_truncate)
3469 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3470 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3471 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3472 (stuff_buffered_input):
3473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3474 (last_auto_save, command_loop_1, read_char):
3475 Use EMACS_INT, not int, to avoid integer overflow.
3476 (record_char): Avoid overflow in total_keys computation.
3477 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3478 * keyboard.h: Adjust decls to match defn changes elsewhere.
3479 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3480 (Fkey_description, Fdescribe_vector, Flookup_key):
3481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3482 (click_position): New function, to check that positions are in range.
3483 (Fcurrent_active_maps):
3485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3486 (Faccessible_keymaps, Fkey_description):
3487 (preferred_sequence_p):
3488 Don't assume fixnum can fit into int.
3489 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3490 Check for integer overflow in size calculations.
3491 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3492 avoid mishandling large integers.
3493 * lisp.h: Adjust decls to match defn changes elsewhere.
3494 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3495 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3496 (struct Lisp_Marker):
3497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3498 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3499 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3500 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3501 All callers changed.
3502 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3503 Assume the arg has valid form, since it always does.
3504 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3505 unsigned integer system type.
3506 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3507 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3510 (duration_to_sec_usec): New decl.
3511 * lread.c (read_from_string_index, read_from_string_index_byte)
3512 (read_from_string_limit, readchar, unreadchar, openp)
3513 (read_internal_start, read1, oblookup):
3514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3515 (Fload, readevalloop, Feval_buffer, Feval_region):
3516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3517 (openp): Check for out-of-range argument to 'access'.
3518 (read1): Use int, not EMACS_INT, where int is wide enough.
3519 Don't assume fixnum fits into int.
3520 Fix off-by-one error that can read outside a buffer.
3521 (read_filtered_event): Use duration_to_sec_usec
3522 to do proper overflow checking on durations.
3523 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3524 in size calculation.
3525 (Fexecute_kbd_macro):
3526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3527 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3528 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3529 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3530 (set_marker_both, set_marker_restricted_both, marker_position)
3531 (marker_byte_position, Fbuffer_has_markers_at):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3534 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3535 It now merely ensures that the menu is large enough, without
3536 necessarily growing it, as this avoids some integer overflow issues.
3537 All callers changed.
3538 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3540 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3541 Use SAFE_ALLOCA_LISP, not alloca.
3542 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3543 to EMACS_INT. Check that fixnums are in proper range for system types.
3544 * minibuf.c (minibuf_prompt_width, string_to_object)
3545 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3546 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3548 (get_minibuffer, read_minibuf_unwind):
3549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3550 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3551 this simplifies overflow checking. All callers changed.
3552 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3555 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3556 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3557 Check that fixnums are in proper range for system types.
3558 (Fx_create_frame, Fx_show_tip):
3559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3560 * nsfont.m (ns_findfonts, nsfont_list_family):
3561 Don't assume fixnum fits in long.
3562 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3564 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3566 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3569 (PRINTDECLARE, PRINTPREPARE):
3570 (strout, print_string):
3571 (print, print_preprocess, print_check_string_charset_prop)
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3575 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3578 (printchar, strout): Use xpalloc to catch size calculation overflow.
3579 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3580 (print_error_message): Use SAFE_ALLOCA, not alloca.
3581 (print_object): Use int, not EMACS_INT, where int is wide enough.
3582 (print_depth, new_backquote_output, print_number_index):
3583 Use ptrdiff_t, not int, where int might not be wide enough.
3584 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3585 (Fset_process_window_size, Fformat_network_address)
3586 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3588 Check that fixnums are in proper range for system types.
3589 (Fsignal_process): Simplify by avoiding a goto.
3590 Check for process-ids out of pid_t range rather than relying on
3592 (process_tick, update_tick): Use EMACS_INT, not int.
3593 (Fformat_network_address, read_process_output, send_process)
3594 (Fprocess_send_region, status_notify):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3597 (wait_reading_process_output, read_process_output, exec_sentinel):
3598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3599 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3600 (Faccept_process_output): Use duration_to_sec_usec to do proper
3601 overflow checking on durations.
3602 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3603 Don't assume pid_t fits in int.
3604 * process.h (struct Lisp_Process): Members tick and update_tick
3605 are now of type EMACS_INT, not int.
3606 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3607 configured --with-wide-int.
3608 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3609 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3610 * search.c (looking_at_1, string_match_1):
3611 (fast_string_match, fast_c_string_match_ignore_case)
3612 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3613 (scan_newline, find_before_next_newline, search_command)
3614 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3615 (set_search_regs, wordify):
3618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3619 (string_match_1, search_buffer, set_search_regs):
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 (wordify): Check for overflow in size calculation.
3623 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3624 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3625 Check that fixnums are in proper range for system types.
3626 * sound.c (struct sound_device)
3627 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 (Fplay_sound_internal):
3630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3631 * syntax.c (struct lisp_parse_state, find_start_modiff)
3632 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3633 (Fparse_partial_sexp):
3634 Don't assume fixnums can fit in int.
3635 (struct lisp_parse_state, find_start_pos, find_start_value)
3636 (find_start_value_byte, find_start_begv)
3637 (update_syntax_table, char_quoted, dec_bytepos)
3638 (find_defun_start, prev_char_comend_first, back_comment):
3639 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3640 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (Finternal_describe_syntax_value): Check that match_lisp is a
3643 character, not an integer, since the code stuffs it into int.
3644 (scan_words, scan_sexps_forward):
3645 Check that fixnums are in proper range for system types.
3647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3648 (scan_sexps_forward):
3649 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3650 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3651 * syntax.h: Adjust decls to match defn changes elsewhere.
3652 (struct gl_state_s):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3654 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3655 MOST_POSITIVE_FIXNUM.
3656 * sysdep.c (wait_for_termination_1, wait_for_termination)
3657 (interruptible_wait_for_termination, mkdir):
3658 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3659 (emacs_read, emacs_write):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3662 and double all fit in int.
3663 * term.c (set_tty_color_mode):
3664 Check that fixnums are in proper range for system types.
3665 * termhooks.h (struct input_event):
3666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3667 * textprop.c (validate_interval_range, interval_of)
3668 (Fadd_text_properties, set_text_properties_1)
3669 (Fremove_text_properties, Fremove_list_of_text_properties)
3670 (Ftext_property_any, Ftext_property_not_all)
3671 (copy_text_properties, text_property_list, extend_property_ranges)
3672 (verify_interval_modification):
3673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3674 (Fnext_single_char_property_change)
3675 (Fprevious_single_char_property_change):
3676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3677 (copy_text_properties):
3678 Check for integer overflow in index calculation.
3679 * undo.c (last_boundary_position, record_point, record_insert)
3680 (record_delete, record_marker_adjustment, record_change)
3681 (record_property_change):
3682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3683 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3685 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3686 (Fx_hide_tip, Fx_file_dialog):
3687 * w32menu.c (set_frame_menubar):
3688 Use ptrdiff_t, not int, for consistency with rest of code.
3689 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3690 (select_window, Fdelete_other_windows_internal)
3691 (window_scroll_pixel_based, window_scroll_line_based)
3692 (Frecenter, Fset_window_configuration):
3693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3694 (Fset_window_hscroll, run_window_configuration_change_hook)
3695 (set_window_buffer, temp_output_buffer_show, scroll_command)
3696 (Fscroll_other_window, Frecenter):
3697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3698 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3699 Don't assume fixnum fits in int.
3700 (Fset_window_scroll_bars):
3701 Check that fixnums are in proper range for system types.
3702 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3703 (string_pos, c_string_pos, number_of_chars, init_iterator)
3704 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3705 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3706 (compute_display_string_end, handle_face_prop)
3707 (face_before_or_after_it_pos, handle_invisible_prop)
3708 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3709 (display_prop_intangible_p, string_buffer_position_lim)
3710 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3711 (get_overlay_strings_1, get_overlay_strings)
3712 (iterate_out_of_display_property, forward_to_next_line_start)
3713 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3714 (get_next_display_element, set_iterator_to_next)
3715 (get_visually_first_element, compute_stop_pos_backwards)
3716 (handle_stop_backwards, next_element_from_buffer)
3717 (move_it_in_display_line_to, move_it_in_display_line)
3718 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3719 (add_to_log, message_dolog, message_log_check_duplicate)
3720 (message2, message2_nolog, message3, message3_nolog
3721 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3722 (current_message_1, truncate_echo_area, truncate_message_1)
3723 (set_message, set_message_1, store_mode_line_noprop)
3724 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3725 (text_outside_line_unchanged_p, check_point_in_composition)
3726 (reconsider_clip_changes)
3727 (redisplay_internal, set_cursor_from_row, try_scrolling)
3728 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3729 (redisplay_window, find_last_unchanged_at_beg_row)
3730 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3731 (trailing_whitespace_p, find_row_edges, display_line)
3732 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3733 (display_mode_element, store_mode_line_string)
3734 (pint2str, pint2hrstr, decode_mode_spec)
3735 (display_count_lines, display_string, draw_glyphs)
3736 (x_produce_glyphs, x_insert_glyphs)
3737 (rows_from_pos_range, mouse_face_from_buffer_pos)
3738 (fast_find_string_pos, mouse_face_from_string_pos)
3739 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (safe_call, init_from_display_pos, handle_fontified_prop)
3742 (handle_single_display_spec, load_overlay_strings)
3743 (with_echo_area_buffer, setup_echo_area_for_printing)
3744 (display_echo_area, echo_area_display)
3745 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3746 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3747 (redisplay_window, dump_glyph_row, display_mode_line)
3748 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3749 (handle_display_spec, display_prop_string_p):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 (handle_single_display_spec, build_desired_tool_bar_string)
3752 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3753 (get_specified_cursor_type):
3754 Check that fixnums are in proper range for system types.
3755 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3756 (Flookup_image_map):
3757 Don't assume fixnums fit in int.
3758 (compare_overlay_entries):
3759 Avoid mishandling comparisons due to subtraction overflow.
3760 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3761 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3762 (handle_tool_bar_click):
3763 Use int, not unsigned, since we prefer signed and the signedness
3764 doesn't matter here.
3765 (get_next_display_element, next_element_from_display_vector):
3766 Use int, not EMACS_INT, when int is wide enough.
3767 (start_hourglass): Use duration_to_sec_usec to do proper
3768 overflow checking on durations.
3769 * xfaces.c (Fbitmap_spec_p):
3770 Check that fixnums are in proper range for system types.
3771 (compare_fonts_by_sort_order):
3772 Avoid mishandling comparisons due to subtraction overflow.
3773 (Fx_family_fonts, realize_basic_faces):
3774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3776 Don't assume fixnum fits in int.
3777 Use SAFE_ALLOCA_LISP, not alloca.
3778 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3779 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3780 (face_at_buffer_position, face_for_overlay_string)
3781 (face_at_string_position):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3784 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3786 Check that fixnums are in proper range for system types.
3787 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3788 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3790 (Fx_change_window_property): Don't assume fixnums fit in int.
3791 * xfont.c (xfont_chars_supported):
3792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3793 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3794 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3796 * xml.c (parse_region):
3797 * xrdb.c (magic_file_p):
3798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3799 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3800 (x_get_local_selection, x_reply_selection_request)
3801 (x_handle_selection_request, wait_for_property_change):
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3804 short is wide enough.
3805 (x_send_client_event): Don't assume fixnum fits in int.
3806 * xterm.c (x_x_to_emacs_modifiers):
3807 Don't assume EMACS_INT overflows nicely into int.
3808 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3810 (handle_one_xevent): NATNUMP can eval its arg twice.
3811 (x_connection_closed):
3812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3813 * xterm.h: Adjust decls to match defn changes elsewhere.
3814 (struct scroll_bar): Use struct vectorlike_header
3815 rather than rolling our own approximation.
3816 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3818 2012-05-25 Glenn Morris <rgm@gnu.org>
3820 * lisp.mk (lisp): Update for more files being compiled now.
3822 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3824 * lread.c: Remove `read_pure' which makes no difference.
3825 (read_pure): Remove var.
3826 (unreadpure): Remove function.
3827 (readevalloop): Don't call read_list with -1 flag.
3828 (read1, read_vector): Don't test read_pure any more.
3829 (read_list): Simplify.
3831 * fileio.c, character.h: Minor style tweaks.
3833 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3835 * window.h (clip_changed): Remove useless declaration.
3837 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3839 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3840 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3842 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3845 This directory predates autoconf and is no longer needed nowadays.
3846 Move its few remaining bits of functionality to where they're needed.
3847 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3848 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3849 * m/template.h: Remove.
3850 * Makefile.in (M_FILE): Remove. All uses removed.
3851 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3852 * lisp.h (USE_LSB_TAG):
3853 * mem-limits.h (EXCEEDS_LISP_PTR):
3854 Use VAL_MAX, not VALBITS, in #if.
3855 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3856 (EMACS_UINT): Define unconditionally now.
3857 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3858 (BITS_PER_EMACS_INT): New constants, replacing
3859 what used to be in config.h, but not useful in #if.
3860 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3861 define them any more.
3862 (VAL_MAX): New macro.
3864 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3865 BITS_PER_EMACS_INT, in #if.
3866 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3867 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3868 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3869 * s/ms-w32.h (DATA_START):
3870 Move here from removed file m/intel386.h.
3871 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3872 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3874 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3876 Assume C89 or later.
3877 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3878 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3880 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3881 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3882 * textprop.c, tparam.c (NULL): Remove.
3883 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3884 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3885 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3886 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3887 * xterm.c (input_signal_count): Assume volatile works.
3889 2012-05-21 Ken Brown <kbrown@cornell.edu>
3891 * xgselect.c (xg_select): Fix first argument in call to 'select'
3894 2012-05-20 Ken Brown <kbrown@cornell.edu>
3896 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3897 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3899 2012-05-19 Ken Brown <kbrown@cornell.edu>
3901 * xfns.c (x_in_use): Remove `static' qualifier.
3902 * xterm.h (x_in_use): Declare.
3903 * xgselect.c: Include xterm.h.
3904 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3905 and `display_arg' (bug#9754).
3907 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3909 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3911 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3912 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3914 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3916 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3918 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3919 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3921 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3922 reference to image_cache->refcount.
3923 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3925 2012-05-17 Juri Linkov <juri@jurta.org>
3927 * search.c (Fword_search_regexp, Fword_search_backward)
3928 (Fword_search_forward, Fword_search_backward_lax)
3929 (Fword_search_forward_lax): Move functions to isearch.el
3930 (bug#10145, bug#11381).
3932 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3934 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3936 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3938 * lread.c (init_obarray): Declare Qt and Qnil as special.
3940 2012-05-14 Glenn Morris <rgm@gnu.org>
3942 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3943 Put "libexec" before "bin", for the sake of init_callproc_1.
3945 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3947 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3949 * unexaix.c: Port to more-recent AIX compilers.
3950 (report_error, report_error_1, make_hdr, copy_sym)
3951 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3952 Make arguments const char *, not char *, to avoid violations of C
3953 standard and to fix some AIX warnings reported by Gilles Pion.
3955 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3957 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3958 already have overlays loaded.
3959 (handle_single_display_spec): Before returning without displaying
3960 fringe bitmap, synchronize the bidi iterator with the main display
3961 iterator, by calling iterate_out_of_display_property.
3962 (iterate_out_of_display_property): Detect buffer iteration by
3963 testing that it->string is a Lisp string.
3964 (get_next_display_element): When the current object is exhausted,
3965 and there's something on it->stack, call set_iterator_to_next to
3966 proceed with what's on the stack, instead of returning zero.
3967 (set_iterator_to_next): If called at the end of a Lisp string,
3968 proceed to consider_string_end without incrementing string
3969 position. Don't increment display vector index past the end of
3970 the display vector. (Bug#11417)
3971 (pos_visible_p): Don't report a position visible when move_it_to
3972 stopped at the last line of window, which happens to be scanned
3973 backwards by the bidi iteration. (Bug#11464)
3975 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3977 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3978 and right-margin display specs even if the spec is invalid or we
3979 are on a TTY, and thus unable to display on the fringes.
3980 That's because the text with the property will not be displayed anyway,
3981 so we need to signal to the caller that this is a "replacing"
3982 display spec. This fixes display when the spec is invalid or we
3985 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3987 * unexaix.c (make_hdr): Fix typo in prototype.
3988 This bug broke the build on AIX. Problem reported by Gilles Pion.
3990 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3992 * keyboard.c (kbd_buffer_get_event): Read special events also in
3993 batch mode. (Bug#11415)
3995 2012-05-12 Glenn Morris <rgm@gnu.org>
3997 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3999 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4001 * lisp.mk (lisp): Add newcomment.elc.
4003 2012-05-12 Glenn Morris <rgm@gnu.org>
4005 * Makefile.in (MKDIR_P): New, set by configure.
4006 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4008 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4010 Remove unused function hourglass_started.
4011 * dispextern.h (hourglass_started):
4012 * w32fns.c (hourglass_started):
4013 * xdisp.c (hourglass_started): Remove.
4015 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4017 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4018 Update dependencies.
4020 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4022 * xgselect.c (xg_select): Put maxfds+1 into a var.
4023 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4025 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4027 2012-05-10 Dave Abrahams <dave@boostpro.com>
4029 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4030 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4032 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4034 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4035 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4036 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4037 Initialize xd_registered_buses.
4039 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4041 Untag more efficiently if USE_LSB_TAG.
4042 This is based on a proposal by YAMAMOTO Mitsuharu in
4043 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4044 For an admittedly artificial (nth 8000 longlist) benchmark on
4045 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4046 Emacs's overall text size by 1%.
4047 * lisp.h (XUNTAG): New macro.
4048 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4049 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4050 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4051 * eval.c (Fautoload):
4052 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4053 * frame.h (XFRAME): Use XUNTAG.
4055 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4056 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4057 Remove unportable assumptions about print widths of types like
4059 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4060 intptr_t when converting between pointer and integer, to avoid GCC
4061 warnings about wrong width.
4063 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4065 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4066 stack for each reader_thread, instead of defaulting to 8MB
4067 determined by the linker. This avoids failures in creating
4068 subprocesses on Windows 7, see the discussion in this thread:
4069 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4071 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4073 Fix up display of the *Minibuf-0* buffer in the mini window.
4074 * keyboard.c (read_char): Don't clear the echo area if there's no
4076 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4077 contents of *Minibuf-0*) if there's no message displayed in its stead.
4079 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4081 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4084 2012-05-06 Chong Yidong <cyd@gnu.org>
4086 * lisp.mk (lisp): Update.
4088 2012-05-05 Jim Meyering <meyering@redhat.com>
4090 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4092 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4094 * data.c (PUT_ERROR): New macro.
4095 (syms_of_data): Use it. Add new error type `user-error'.
4096 * undo.c (user_error): New function.
4097 (Fprimitive_undo): Use it.
4098 * print.c (print_error_message): Adjust print style for `user-error'.
4099 * keyboard.c (user_error): New function.
4100 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4102 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4104 Do not limit current-time-string to years 1000..9999.
4105 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4106 (Fcurrent_time_string): Support any year that is supported by the
4107 underlying localtime representation. Don't use asctime, as it
4108 has undefined behavior for years outside the range -999..9999.
4110 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4112 Fix race conditions involving setenv, gmtime, localtime, asctime.
4113 Without this fix, interrupts could mess up code that uses these
4114 nonreentrant functions, since setting TZ invalidates existing
4115 tm_zone or tzname values, and since most of these functions return
4116 pointers to static storage.
4117 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4118 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4119 Grow the critical sections to include not just invoking
4120 localtime/gmtime, but also accessing these functions' results
4121 including their tm_zone values if any, and any related TZ setting.
4122 (format_time_string): Last arg is now struct tm *, not struct tm **,
4123 so that the struct tm is saved in the critical section.
4124 All callers changed. Simplify allocation of initial buffer, partly
4125 motivated by the fact that memory allocation needs to be outside
4126 the critical section.
4128 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4130 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4131 with RESET_INTERVAL.
4133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4134 Remove duplicated buffer name initialization.
4136 2012-05-02 Jim Meyering <jim@meyering.net>
4138 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4140 * xfns.c (x_window): Use xstrdup (Bug#11375).
4142 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4144 * xdisp.c (pos_visible_p): If already at a newline from the
4145 display string before the 'while' loop, don't walk back the glyphs
4146 from it3.glyph_row. Solves assertion violation when the display
4147 string begins with a newline (egg.el). (Bug#11367)
4149 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4151 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4154 2012-05-01 Glenn Morris <rgm@gnu.org>
4156 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4157 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4158 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4159 All were removed before 23.1.
4161 * dispnew.c: Remove HAVE_LIBNCURSES test;
4162 it is always true on relevant platforms.
4164 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4165 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4167 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4169 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4171 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4172 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4175 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4177 Do not avoid creating empty evaporating overlays (Bug#9642).
4178 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4179 That is, do not delete an evaporating overlay if it becomes
4180 empty after its bounds are adjusted to fit within its buffer.
4181 This fix caused other problems, and I'm reverting it until we get
4182 to the bottom of them.
4184 2012-04-27 Chong Yidong <cyd@gnu.org>
4186 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4188 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4190 * xdisp.c (pos_visible_p): If the window start position is beyond
4191 ZV, start the display from buffer beginning. Prevents assertion
4192 violation in init_iterator when the minibuffer window is scrolled
4195 * window.c (window_scroll_pixel_based): Likewise.
4197 2012-04-27 Chong Yidong <cyd@gnu.org>
4199 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4201 2012-04-27 Glenn Morris <rgm@gnu.org>
4203 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4204 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4206 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4208 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4209 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4211 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4213 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4214 display element, check also the underlying string or buffer
4215 character. (Bug#11341)
4217 * w32menu.c: Include w32heap.h.
4218 (add_menu_item): If the call to AppendMenuW (via
4219 unicode_append_menu) fails, disable Unicode menus only if we are
4220 running on Windows 9X/Me.
4222 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4224 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4225 (xgetint): Add missing shift for LSB tags.
4227 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4229 * keyboard.c (read_char): Don't wipe echo area for select window
4230 events: These might get delayed via `mouse-autoselect-window'
4233 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4235 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4236 manipulation of :loaded-from data.
4238 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4240 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4241 now a cons (bug#11311).
4243 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4245 Do not create empty overlays with the evaporate property (Bug#9642).
4246 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4247 if it becomes empty after its bounds are adjusted to fit within
4248 its buffer. Without this fix, in a nonempty buffer (let ((o
4249 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4250 yields an empty overlay that has the evaporate property, which is
4251 not supposed to happen.
4253 Fix minor GTK3 problems found by static checking.
4254 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4255 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4256 (struct _EmacsFixedClass, emacs_fixed_get_type):
4257 Move decls here from emacsgtkfixed.h, since they needn't be public.
4258 (emacs_fixed_get_type): Now static.
4259 (emacs_fixed_class_init): Omit unused local.
4260 (emacs_fixed_child_type): Remove; unused.
4261 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4262 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4263 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4264 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4265 (EMACS_FIXED_GET_CLASS): Remove; unused.
4266 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4268 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4269 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4271 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4273 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4274 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4275 (__malloc_size_t, __malloc_ptrdiff_t):
4276 Remove. All uses removed, replaced by the definiens if needed,
4277 since we can assume C89 or better now.
4278 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4279 (protect_malloc_state, align, get_contiguous_space)
4280 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4281 (malloc_atfork_handler_child, malloc_enable_thread)
4282 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4283 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4284 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4285 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4286 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4287 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4288 Define using prototypes, not old style.
4289 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4290 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4291 (align): Don't assume that signed integer overflow wraps around.
4292 Omit unused local var.
4293 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4294 (_free_internal_nolock, memalign, mallochook, reallochook):
4295 Omit no-longer-needed casts.
4296 (valloc): Use getpagesize, not __getpagesize.
4297 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4298 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4300 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4302 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4304 Move functions from C to Lisp. Make non-blocking method calls
4305 the default. Implement further D-Bus standard interfaces.
4307 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4308 (QCdbus_request_name_allow_replacement)
4309 (QCdbus_request_name_replace_existing)
4310 (QCdbus_request_name_do_not_queue)
4311 (QCdbus_request_name_reply_primary_owner)
4312 (QCdbus_request_name_reply_in_queue)
4313 (QCdbus_request_name_reply_exists)
4314 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4315 (QCdbus_registered_serial, QCdbus_registered_method)
4316 (QCdbus_registered_signal): New Lisp objects.
4317 (XD_DEBUG_MESSAGE): Use sizeof.
4318 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4319 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4320 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4321 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4322 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4323 (xd_signature, xd_append_arg): Allow float for integer types.
4324 (xd_get_connection_references): New function.
4325 (xd_get_connection_address): Rename from xd_initialize.
4326 Return cached address.
4327 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4328 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4330 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4331 Return number of refcounts.
4332 (Fdbus_get_unique_name): Make stronger parameter check.
4333 (Fdbus_message_internal): New defun.
4334 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4335 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4336 (Fdbus_send_signal, Fdbus_register_service)
4337 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4338 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4339 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4340 (Vdbus_compiled_version, Vdbus_runtime_version)
4341 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4342 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4343 (Vdbus_message_type_signal): New defvars.
4344 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4347 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4349 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4350 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4351 Do not assume ptrdiff_t is the same width as 'int'.
4353 * alloc.c: Handle unusual debugging option combinations.
4354 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4355 since the two debugging options are incompatible.
4356 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4358 (mem_init, mem_insert, mem_insert_fixup):
4359 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4360 (NEED_MEM_INSERT): Remove; no longer needed.
4362 2012-04-22 Leo Liu <sdl.web@gmail.com>
4364 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4366 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4368 * sysdep.c [__FreeBSD__]: Minor cleanups.
4369 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4370 Use Emacs indenting style more consistently. Avoid some casts.
4371 Use 'double' consistently rather than mixing 'float' and 'double'.
4373 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4375 * sysdep.c (list_system_processes, system_process_attributes):
4376 Add implementation for FreeBSD (Bug#5243).
4378 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4380 * lisp.mk (lisp): Update.
4382 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4384 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4385 It is never used otherwise.
4387 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4389 * print.c (print_preprocess): Only check print_depth if print-circle
4391 (print_object): Check for cycles even when print-circle is nil and
4392 print-gensym is t, but only check print_depth if print-circle is nil.
4394 2012-04-20 Chong Yidong <cyd@gnu.org>
4396 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4397 set the status to "failed" and ensure that sentinel is run.
4399 2012-04-20 Glenn Morris <rgm@gnu.org>
4401 * process.c (Fset_process_inherit_coding_system_flag)
4402 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4403 (Fmake_network_process, Fmake_serial_process): Doc fix.
4405 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4407 * xdisp.c (string_buffer_position_lim): Limit starting position to
4409 (set_cursor_from_row): If called for a mode-line or header-line
4410 row, return zero immediately.
4411 (try_cursor_movement): If inside continuation line, don't back up
4412 farther than the first row after the header line, if any.
4413 Don't consider the header-line row as "partially visible", even if
4414 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4416 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4418 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4421 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4422 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4424 configure: new option --enable-gcc-warnings (Bug#11207)
4425 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4426 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4427 (ALL_CFLAGS): Use new macros rather than old.
4428 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4429 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4430 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4431 -Wunused-result, -Wunused-variable. This should go away once
4432 the Emacs and Gnulib regex code is merged.
4433 (xmalloc, xrealloc): Now static.
4435 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4437 * dired.c (Fsystem_groups): Remove unused local.
4439 2012-04-17 Glenn Morris <rgm@gnu.org>
4441 * dired.c (Fsystem_users): Doc fix.
4443 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4445 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4446 (syms_of_dired): Add them.
4448 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4450 Fix minor alloc.c problems found by static checking.
4451 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4452 New extern decls, to avoid calling undeclared functions.
4453 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4454 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4455 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4456 (NEED_MEM_INSERT): New macro.
4457 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4458 Remove one incorrect comment and fix another.
4460 Fix minor ralloc.c problems found by static checking.
4461 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4462 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4463 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4464 (r_alloc_sbrk): Now static.
4466 Improve ralloc.c interface checking.
4467 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4468 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4469 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4470 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4471 [REL_ALLOC]: ... to here, to check interface.
4472 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4473 Remove decls. This fixes an "It stinks!".
4475 * alloc.c (which_symbols): Fix alignment issue / type clash.
4477 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4479 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4480 (struct Lisp_Misc_Any): Likewise.
4481 (struct Lisp_Free): Likewise.
4482 * alloc.c (union aligned_Lisp_Symbol): Define.
4483 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4484 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4485 (union aligned_Lisp_Misc): Define.
4486 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4487 aligned_Lisp_Misc instead of union Lisp_Misc.
4488 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4490 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4492 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4493 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4494 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4495 * s/netbsd.h, s/sol2-6.h:
4496 Remove definition of GC_MARK_STACK, since the default now works.
4497 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4498 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4499 no longer the default.
4500 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4502 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4504 * lread.c (lisp_file_lexically_bound_p):
4505 Fix hang at ";-*-\n" (bug#11238).
4507 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4509 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4510 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4512 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4514 * nsterm.m (constrainFrameRect): Always constrain when there is only
4515 one screen (Bug#10962).
4517 2012-04-13 Ken Brown <kbrown@cornell.edu>
4519 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4521 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4523 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4525 2012-04-11 Daniel Colascione <dancol@dancol.org>
4527 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4528 against is gone. It's better to use vfork now so that when Cygwin
4529 gains a new, working vfork, we use it automatically (bug#10398).
4531 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4533 * window.c (save_window_save): Obey window-point-insertion-type.
4535 2012-04-11 Glenn Morris <rgm@gnu.org>
4537 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4539 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4541 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4543 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4545 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4546 (force_quit_count): New var.
4547 (handle_interrupt): Use it.
4549 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4551 * w32.c (w32_delayed_load): Record the full path of the library
4552 being loaded (bug#10424).
4554 2012-04-09 Glenn Morris <rgm@gnu.org>
4556 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4557 not just in the obarray, before snarfing them. (Bug#11036)
4559 * Makefile.in ($(leimdir)/leim-list.el):
4560 Pass EMACS rather than BUILT_EMACS.
4562 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4564 * process.c (make_process):
4565 * process.h: Add integer `gnutls_handshakes_tried' member to
4568 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4569 Add convenience `GNUTLS_LOG2i' macro.
4571 * gnutls.c (gnutls_log_function2i): Convenience log function.
4572 (emacs_gnutls_read): Use new log functions,
4573 `gnutls_handshakes_tried' process member, and
4574 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4575 attempts per process (connection).
4577 2012-04-09 Chong Yidong <cyd@gnu.org>
4579 * eval.c (Fuser_variable_p, user_variable_p_eh)
4580 (lisp_indirect_variable): Functions deleted.
4581 (Fdefvar): Caller changed.
4583 * callint.c (Finteractive, Fcall_interactively):
4584 * minibuf.c (Fread_variable): Callers changed.
4586 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4588 * xdisp.c (set_cursor_from_row): If the display string appears in
4589 the buffer at position that is closer to point than the position
4590 after the display string, display the cursor on the first glyph of
4591 the display string. Fixes cursor display when a 'display' text
4592 property immediately follows invisible text. (Bug#11094)
4594 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4596 composite.c: use 'double' consistently
4597 * composite.c (get_composition_id): Use 'double' consistently
4598 instead of converting 'float' to 'double' and vice versa; this is
4599 easier to understand and avoids a GCC warning.
4601 2012-04-09 Glenn Morris <rgm@gnu.org>
4603 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4604 preparation for dumping it with emacs. (Bug#4789)
4605 (leimdir): New variable.
4606 ($(leimdir)/leim-list.el): New rule.
4607 (emacs$(EXEEXT)): Depend on leim-list.el.
4609 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4610 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4611 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4613 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4615 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4618 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4620 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4621 Remove unused local variable.
4623 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4625 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4626 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4627 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4628 objects, as mark_maybe_pointer will catch them otherwise.
4629 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4630 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4632 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4634 Fix typo that broke non-Windows builds.
4635 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4637 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4639 Support building on MS-Windows with libxml2.
4641 * makefile.w32-in (OBJ2): Add xml.$(O).
4642 (GLOBAL_SOURCES): Add xml.c.
4643 ($(BLD)/xml.$(O)): New dependency list.
4645 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4646 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4647 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4648 [!WINDOWSNT]: New macros.
4649 (init_libxml2_functions, libxml2_loaded_p): New functions.
4650 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4651 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4652 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4653 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4655 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4656 Call init_libxml2_functions before calling libxml2 functions.
4657 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4659 * emacs.c: Don't include libxml/parser.h.
4660 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4661 xmlCleanupParser directly.
4663 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4665 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4667 * indent.c (Fvertical_motion): If there is a display string at
4668 point, use it.vpos to compute how many lines to backtrack after
4669 move_it_to point. (Bug#11133)
4671 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4673 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4674 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4675 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4676 macros related to unification of CJK characters. For the details,
4677 see the discussion following the message here:
4678 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4680 2012-04-04 Chong Yidong <cyd@gnu.org>
4682 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4684 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4686 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4687 instead of alloca. (Bug#11138)
4689 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4691 * w32menu.c (is_simple_dialog): Properly check lisp types.
4694 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4696 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4697 position we get to after a call to move_it_to fails the
4698 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4699 only if we wind up in a string from display property. (Bug#11063)
4701 * window.c (Fdelete_other_windows_internal): Invalidate the row
4702 and column information about mouse highlight, so that redisplay
4703 restores it after reallocating the glyph matrices. (Bug#7464)
4705 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4706 string comes from a `display' text property, use the buffer
4707 position of that property as if we actually saw that position in
4709 (move_it_by_lines): Remove the assertion that
4710 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4711 violated when there's a before-string at the beginning of a line.
4714 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4716 * xdisp.c (append_space_for_newline): If the default face was
4717 remapped, use the remapped face for the appended newline.
4718 (extend_face_to_end_of_line): Use the remapped default face for
4719 extending the face to the end of the line.
4720 (display_line): Call extend_face_to_end_of_line when the default
4721 face was remapped. (Bug#11068)
4723 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4725 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4727 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4729 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4731 2012-03-27 Glenn Morris <rgm@gnu.org>
4733 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4736 2012-03-26 Kenichi Handa <handa@m17n.org>
4738 * dispextern.h (struct glyph): Fix previous change. Change the
4739 bit length of glyphless.ch to 25 (Bug#11082).
4741 2012-03-26 Chong Yidong <cyd@gnu.org>
4743 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4744 (command_loop_1): Use it; inhibit selection update for
4745 handle-select-window too (Bug#8996).
4747 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4749 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4751 2012-03-25 Kenichi Handa <handa@m17n.org>
4753 * dispextern.h (struct glyph): Change the bit length of
4754 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4756 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4758 * s/ms-w32.h (tzname): Include time.h before redirecting to
4759 _tzname. Fixes the MSVC build. (Bug#9960)
4761 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4763 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4766 * xterm.c (XTread_socket): Only modify handling_signal if
4767 !SYNC_INPUT. (Bug#11080)
4769 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4771 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4772 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4773 when fetching a multibyte character consumes more bytes than
4774 CHAR_BYTES returns, due to unification of CJK characters in
4775 string_char. (Bug#11073)
4777 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4779 * process.c (wait_reading_process_output): Handle pty disconnect
4780 by refraining from sending oneself a SIGCHLD (bug#10933).
4782 2012-03-22 Chong Yidong <cyd@gnu.org>
4784 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4786 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4787 Mark string as coming from a prefix property.
4788 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4789 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4791 2012-03-21 Chong Yidong <cyd@gnu.org>
4793 * xfaces.c (Vface_remapping_alist): Doc fix.
4795 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4797 * w32proc.c (Fw32_set_console_codepage)
4798 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4801 2012-03-20 Chong Yidong <cyd@gnu.org>
4803 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4804 to reflect default non-nil value of redisplay-dont-pause.
4806 2012-03-19 Kenichi Handa <handa@m17n.org>
4808 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4809 it fit in a valid range (Bug#11003).
4811 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4813 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4814 that is not from display property, accept the row as a "cursor
4815 row" if one of the string's character has a non-nil `cursor'
4816 property. Fixes cursor positioning when there are newlines in
4817 overlay strings, e.g. in icomplete.el. (Bug#11035)
4819 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4821 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4823 2012-03-12 Chong Yidong <cyd@gnu.org>
4825 * eval.c (inhibit_lisp_code): Rename from
4826 inhibit_window_configuration_change_hook; move from window.c.
4828 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4829 * window.c (run_window_configuration_change_hook)
4830 (syms_of_window): Callers changed.
4832 2012-03-11 Chong Yidong <cyd@gnu.org>
4834 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4836 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4838 2012-03-10 Chong Yidong <cyd@gnu.org>
4840 * frame.c (other_visible_frames): Don't assume the selected frame
4841 is visible (Bug#10955).
4843 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4845 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4847 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4849 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4850 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4853 2012-03-03 Glenn Morris <rgm@gnu.org>
4855 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4857 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4859 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4860 position past the first glyph_row that ends at ZV. (Bug#10902)
4861 (redisplay_window, next_element_from_string): Fix typos in
4863 (redisplay_window): Pass to move_it_vertically the margin in
4864 pixels, not in screen lines.
4866 2012-03-02 Glenn Morris <rgm@gnu.org>
4868 * buffer.c (buffer-list-update-hook): Doc fix.
4870 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4872 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4873 push_it before setting up the iterator for the first overlay
4874 string, even if we have an empty string loaded.
4875 (next_overlay_string): If there's an empty string on the iterator
4876 stack, pop the stack. (Bug#10903)
4878 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4880 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4881 Suggested by Stefan Monnier in
4882 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4883 * alloc.c (widen_to_Lisp_Object): New static function.
4884 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4885 and widening them to Lisp_Objects. This would work even if
4886 USE_LSB_TAG is defined and wide integers are used, which might
4887 happen in a future version of Emacs.
4889 2012-02-25 Chong Yidong <cyd@gnu.org>
4891 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4894 * xselect.c (Fx_selection_exists_p): Doc fix.
4895 (x_clipboard_manager_save_all): Print an informative message
4896 before saving to clipboard manager.
4898 2012-02-24 Chong Yidong <cyd@gnu.org>
4900 * keyboard.c (process_special_events): Handle all X selection
4901 requests in kbd_buffer, not just the next one (Bug#8869).
4903 2012-02-23 Chong Yidong <cyd@gnu.org>
4905 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4906 call when setting menu-bar-lines and tool-bar-lines parameters.
4907 (unwind_create_frame_1): New helper function.
4909 * window.c (inhibit_window_configuration_change_hook): New var.
4910 (run_window_configuration_change_hook): Obey it.
4911 (syms_of_window): Initialize it.
4913 2012-02-22 Chong Yidong <cyd@gnu.org>
4915 * xterm.c (x_draw_image_relief): Add missing type check for
4916 Vtool_bar_button_margin (Bug#10743).
4918 2012-02-21 Chong Yidong <cyd@gnu.org>
4920 * fileio.c (Vfile_name_handler_alist): Doc fix.
4922 * buffer.c (Fget_file_buffer): Protect against invalid file
4923 handler return value.
4925 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4927 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4928 when computing $valmask.
4930 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4931 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4932 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4933 It's useless in that case, and it can cause problems on hosts
4934 that allocate halves of EMACS_INT values separately.
4935 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4936 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4937 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4938 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4939 it avoids undefined behavior on hosts where shifting right by more
4940 than the word width has undefined behavior.
4942 2012-02-19 Chong Yidong <cyd@gnu.org>
4944 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4945 (Funhandled_file_name_directory, Ffile_name_as_directory)
4946 (Fdirectory_file_name, Fexpand_file_name)
4947 (Fsubstitute_in_file_name): Protect against invalid file handler
4948 return values (Bug#10845).
4950 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4952 * .gdbinit (pitx): Fix incorrect references to fields of the
4955 2012-02-17 Chong Yidong <cyd@gnu.org>
4957 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4959 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4961 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4962 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4964 2012-02-15 Chong Yidong <cyd@gnu.org>
4966 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4967 marked as special. Also, starting docstrings with * is obsolete.
4969 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4971 * gnutls.c (emacs_gnutls_write): Fix last change.
4973 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4975 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4978 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4980 * keymap.c (Fsingle_key_description): Handle char ranges.
4982 2012-02-12 Chong Yidong <cyd@gnu.org>
4984 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4985 as that creates a dangerous corner case.
4987 * window.c (Fdelete_window_internal): Invalidate the mouse
4988 highlight (Bug#9904).
4990 2012-02-12 Glenn Morris <rgm@gnu.org>
4992 * xselect.c (Fx_own_selection_internal)
4993 (Fx_get_selection_internal, Fx_disown_selection_internal)
4994 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4995 * nsselect.m (Fx_own_selection_internal)
4996 (Fx_disown_selection_internal, Fx_selection_exists_p)
4997 (Fx_selection_owner_p, Fx_get_selection_internal):
4998 Sync docs and argument specs with the xselect.c versions.
5000 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5002 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5004 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5006 * w32select.c (Fx_selection_exists_p): Sync doc string and
5007 argument list with xselect.c. (Bug#10783)
5009 * w16select.c (Fx_selection_exists_p): Sync doc string and
5010 argument list with xselect.c. (Bug#10783)
5012 2012-02-10 Glenn Morris <rgm@gnu.org>
5014 * fns.c (Fsecure_hash): Doc fix.
5016 2012-02-09 Kenichi Handa <handa@m17n.org>
5018 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5020 2012-02-07 Chong Yidong <cyd@gnu.org>
5022 * buffer.c (Fbuffer_local_variables)
5023 (buffer_lisp_local_variables): Handle unbound vars correctly;
5024 don't let Qunbound leak into Lisp.
5026 2012-02-07 Glenn Morris <rgm@gnu.org>
5028 * image.c (Fimagemagick_types): Doc fix.
5030 * image.c (imagemagick-render-type): Change it from a lisp object
5031 to an integer. Move the doc here from the lisp manual.
5032 Treat all values not equal to 0 the same.
5034 2012-02-06 Chong Yidong <cyd@gnu.org>
5036 * doc.c (store_function_docstring): Avoid applying docstring of
5037 alias to base function (Bug#2603).
5039 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5041 * .gdbinit (pp1, pv1): Remove redundant defines.
5044 2012-02-04 Chong Yidong <cyd@gnu.org>
5046 * nsterm.m: Declare a global (Bug#10694).
5048 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5050 * w32.c (get_emacs_configuration_options):
5051 Include --enable-checking, if specified, in the return value.
5053 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5055 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5056 after rounding frame sizes. (Bug#9723)
5058 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5060 * keyboard.c (adjust_point_for_property): Don't position point
5061 before BEGV. (Bug#10696)
5063 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5065 Handle overflow when computing char display width (Bug#9496).
5066 * character.c (char_width): Return EMACS_INT, not int.
5067 (char_width, c_string_width): Check for overflow when
5068 computing the width; this is possible now that individual
5069 characters can have unbounded width. Problem introduced
5070 by merge from Emacs 23 on 2012-01-19.
5072 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5074 * dbusbind.c (Fdbus_register_method): Mention the return value
5075 :ignore in the docstring.
5077 2012-02-02 Glenn Morris <rgm@gnu.org>
5079 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5081 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5082 Unconditionally set to t. (Bug#10673)
5083 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5084 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5085 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5087 2012-02-02 Kenichi Handa <handa@m17n.org>
5089 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5090 0, do not call append_composite_glyph.
5092 2012-02-02 Kenichi Handa <handa@m17n.org>
5094 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5096 (x_produce_glyphs): If the component of a composition is a null
5097 string, set it->pixel_width to 1 to avoid zero-width glyph.
5099 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5101 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5102 first 2 arguments are identical. This makes inserting large
5103 output from a subprocess an order of magnitude faster on
5104 MS-Windows, where all sbrk'ed memory is always contiguous.
5106 2012-01-31 Glenn Morris <rgm@gnu.org>
5108 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5109 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5110 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5112 2012-01-29 Glenn Morris <rgm@gnu.org>
5114 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5116 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5118 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5120 2012-01-28 Chong Yidong <cyd@gnu.org>
5122 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5124 2012-01-26 Chong Yidong <cyd@gnu.org>
5126 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5128 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5129 repeat counts (Bug#10507).
5131 2012-01-26 Glenn Morris <rgm@gnu.org>
5133 * lread.c (syms_of_lread): Doc fix.
5135 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5137 * coding.c (encode_designation_at_bol): Change return value to
5140 2012-01-25 Chong Yidong <cyd@gnu.org>
5142 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5144 2012-01-21 Chong Yidong <cyd@gnu.org>
5146 * floatfns.c (Fcopysign): Make the second argument non-optional,
5147 since nil is not allowed anyway.
5149 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5151 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5152 (send_process): Likewise.
5154 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5156 * window.c (save_window_save, Fcurrent_window_configuration)
5157 (Vwindow_persistent_parameters): Do not use Qstate.
5158 Rewrite doc-strings.
5160 2012-01-19 Kenichi Handa <handa@m17n.org>
5162 * character.c (char_width): New function.
5163 (Fchar_width, c_string_width, lisp_string_width):
5164 Use char_width (Bug#9496).
5166 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5168 * window.c (Vwindow_persistent_parameters): New variable.
5169 (Fset_window_configuration, save_window_save): Handle persistent
5172 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5174 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5175 thrashing the stack of the thread. (Bug#9087)
5177 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5179 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5181 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5183 * xdisp.c (rows_from_pos_range): Handle the case where the
5184 highlight ends on a newline. (Bug#10464)
5185 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5186 he end column for display of highlight that ends on a newline
5189 2012-01-11 Glenn Morris <rgm@gnu.org>
5191 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5192 from load-path also when installation-directory is nil. (Bug#10208)
5194 2012-01-10 Glenn Morris <rgm@gnu.org>
5196 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5198 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5199 Update template values to be closer to their typical values these days.
5201 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5203 * xdisp.c (rows_from_pos_range): Accept additional argument
5204 DISP_STRING, and accept any glyph in a row whose object is that
5205 string as eligible for mouse highlight. Fixes mouse highlight of
5206 display strings from overlays. (Bug#10464)
5208 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5210 emacs: fix an auto-save permissions race condition (Bug#10400)
5211 * fileio.c (auto_saving_dir_umask): New static var.
5212 (Fmake_directory_internal): Use it.
5213 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5214 creating the directory. The old code temporarily assigns
5215 too-generous permissions to the directory.
5216 (do_auto_save_eh): Clear it.
5217 (Fdo_auto_save): Catch all errors, not just file errors, so
5218 that the var is always cleared.
5220 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5222 * search.c (scan_buffer): Pass character positions to
5223 know_region_cache, not byte positions. (Bug#6540)
5225 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5227 * w32.c (sys_rename): Report EXDEV when rename of a directory
5228 fails because the target is on another logical disk. (Bug#10284)
5230 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5232 * xterm.c (x_embed_request_focus): New function.
5234 * xterm.h: Add prototype.
5236 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5238 2012-01-05 Glenn Morris <rgm@gnu.org>
5240 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5242 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5244 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5245 Load gnutls_transport_set_lowat only if GnuTLS version is below
5247 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5248 GnuTLS versions below 2.11.1.
5250 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5252 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5253 to the doc string advising against its use for altering the way
5254 windows are scrolled.
5256 2011-12-28 Kenichi Handa <handa@m17n.org>
5258 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5259 coding-system ASCII compatible only when it does not produce BOM
5260 on encoding (Bug#10383).
5262 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5264 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5266 (create_and_show_popup_menu): Always use menu_position_func for
5269 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5271 * callint.c (Fcall_interactively): Don't truncate prompt string.
5273 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5275 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5276 property that ends at ZV, so that the bidi iteration could be
5277 resumed from there (after widening). (Bug#10360)
5279 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5281 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5283 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5285 * nsterm.m (x_free_frame_resources):
5286 Release f->output_data.ns->miniimage.
5287 (ns_index_color): Fix indentation. Do not retain
5288 color_table->colors[i].
5290 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5293 * nsfns.m (x_set_background_color): Assign return value from
5294 ns_index_color to face-background instead of NSColor*.
5295 (ns_implicitly_set_icon_type): Fix indentation.
5296 Change assignment in for loop to comparison.
5298 * emacs.c (ns_pool): New variable.
5299 (main): Assign ns_pool.
5300 (Fkill_emacs): Call ns_release_autorelease_pool.
5302 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5303 autorelease fdesc, release fdAttrs and tdict.
5304 (ns_get_covering_families): Release charset.
5305 (ns_findfonts): Release NSFontDescriptor created with new.
5306 (ns_uni_to_glyphs): Fix indentation.
5307 (setString): Release attrStr before assigning new value.
5309 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5311 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5313 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5314 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5316 2011-12-18 David Reitter <reitter@cmu.edu>
5318 * nsterm.m (ns_term_init): Subscribe for notifications
5319 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5320 to method trackingNotification in EmacsMenu.
5322 * nsmenu.m (trackingMenu): New variable.
5323 (trackingNotification): New method (from Aquamacs).
5324 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5325 from Aquamacs (Bug#7030).
5327 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5329 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5330 (symbol_to_nsstring): Fix indentation.
5331 (ns_symbol_to_pb): New function.
5332 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5333 (Fns_rotate_cut_buffers_internal): Remove.
5334 (Fns_store_selection_internal): Rename from
5335 Fns_store_cut_buffer_internal.
5336 (ns_get_foreign_selection, Fx_own_selection_internal)
5337 (Fx_disown_selection_internal, Fx_selection_exists_p)
5338 (Fns_get_selection_internal, Fns_store_selection_internal):
5339 Use ns_symbol_to_pb and check if return value is nil.
5340 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5341 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5342 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5343 renamed to Sns_store_selection_internal.
5344 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5345 and remove this function.
5346 (ns_handle_selection_clear): Remove, never used.
5347 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5350 2011-12-17 Ken Brown <kbrown@cornell.edu>
5352 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5353 GID is unknown (Bug#10257).
5355 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5357 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5358 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5359 which caused a build failure on GNU/Linux IA-64. This problem was
5360 introduced by my 2011-10-07 patch.
5362 2011-12-15 Juri Linkov <juri@jurta.org>
5364 * image.c (imagemagick_error): New function. (Bug#10112)
5365 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5366 Use `imagemagick_error' where ImageMagick functions return
5368 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5371 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5373 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5374 fill background (Bug#8992).
5376 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5378 * window.c (Vwindow_combination_resize)
5379 (Vwindow_combination_limit): Use t instead of non-nil in
5381 (Vrecenter_redisplay): Add first sentence of doc-string on
5383 (Frecenter): Fix doc-string typo.
5385 2011-12-11 Kenichi Handa <handa@m17n.org>
5387 * coding.c (Funencodable_char_position): Pay attention to the
5388 buffer text relocation (Bug#9389).
5390 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5392 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5393 gtk_init (Bug#10100).
5395 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5397 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5398 IT->string is nil. (Bug#10263)
5400 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5402 * nsterm.h (x_free_frame_resources): Declare.
5404 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5405 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5407 * nsterm.h (ns_get_defaults_value): Declare.
5409 * nsterm.m (ns_default): Call ns_get_defaults_value.
5411 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5413 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5416 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5418 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5419 that where the value of an _OBJC_* symbol points to is in the .bss
5420 section (Bug#10240).
5422 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5424 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5425 after the loop to call ccl_driver at least once (Bug#8619).
5427 2011-12-08 Kenichi Handa <handa@m17n.org>
5429 * ftfont.c (get_adstyle_property): Fix previous change
5432 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5434 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5435 dirs from the default value of EMACSLOADPATH (bug#10208).
5437 2011-12-07 Glenn Morris <rgm@gnu.org>
5439 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5440 installation and source directories as well. (Bug#10208)
5442 2011-12-06 Chong Yidong <cyd@gnu.org>
5444 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5446 2011-12-06 Glenn Morris <rgm@gnu.org>
5448 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5449 as an error, not just -1. (Bug#10217)
5451 2011-12-05 Chong Yidong <cyd@gnu.org>
5453 * keyboard.c (process_special_events): New function.
5454 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5456 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5458 * coding.c (encode_designation_at_bol): Don't use uninitialized
5459 local variable (Bug#9318).
5461 2011-12-05 Kenichi Handa <handa@m17n.org>
5463 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5464 return Qnil (Bug#8046, Bug#10193).
5466 2011-12-05 Kenichi Handa <handa@m17n.org>
5468 * coding.c (encode_designation_at_bol): New args charbuf_end and
5469 dst. Return the number of produced bytes. Callers changed.
5470 (coding_set_source): Return how many bytes coding->source was
5472 (coding_set_destination): Return how many bytes
5473 coding->destination was relocated.
5474 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5475 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5477 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5479 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5480 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5483 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5485 The following changes are to fix Bug#9318.
5487 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5488 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5489 (encode_coding_iso_2022, encode_coding_sjis)
5490 (encode_coding_big5, encode_coding_charset): Use the above macros.
5492 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5494 * lisp.h (process_quit_flag): Fix external declaration.
5496 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5498 Don't macro-inline non-performance-critical code.
5499 * eval.c (process_quit_flag): New function.
5500 * lisp.h (QUIT): Use it.
5502 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5504 * nsfns.m (get_geometry_from_preferences): New function.
5505 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5507 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5509 * emacs.c (Qkill_emacs): Define.
5510 (syms_of_emacs): Initialize it.
5511 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5512 Qquit_flag to `kill-emacs' instead.
5513 (quit_throw_to_read_char): Add parameter `from_signal'.
5514 All callers changed. Call Fkill_emacs if requested and safe.
5515 * lisp.h (QUIT): Call Fkill_emacs if requested.
5517 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5519 * widget.c (update_wm_hints): Return if wmshell is null.
5520 (widget_update_wm_size_hints): New function.
5522 * widget.h (widget_update_wm_size_hints): Declare.
5524 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5525 widget_update_wm_size_hints (Bug#10104).
5527 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5529 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5530 before a newline, prepare the bidi iterator for consuming the
5531 newline, and keep the current paragraph direction. (Bug#10183)
5532 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5534 2011-12-02 Juri Linkov <juri@jurta.org>
5536 * search.c (Fword_search_regexp): New Lisp function created from
5537 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5538 (Fword_search_backward, Fword_search_forward)
5539 (Fword_search_backward_lax, Fword_search_forward_lax):
5540 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5541 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5543 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5545 * fileio.c (Finsert_file_contents): Move after-change-function call
5546 to before the "handled:" label, since all "goto handled" appear in
5547 cases where the *-change-functions have already been properly called
5550 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5552 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5553 waiting for input. (Bug#10169)
5555 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5557 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5558 verifies glyph row's hash code--we have just reallocated the
5559 glyphs, so their contents can be complete garbage. (Bug#10164)
5561 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5563 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5565 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5567 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5568 attributes are tested _before_ calling verify_row_hash, to protect
5569 against GCC re-ordering of the tests. (Bug#10164)
5571 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5573 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5575 * xterm.c (handle_one_xevent): Only set async_visible and friends
5576 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5577 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5578 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5580 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5582 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5583 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5584 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5585 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5586 All uses changed to use GCPRO1 etc.
5587 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5588 Revert to old implementation (i.e., before 2011-03-11).
5590 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5592 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5593 of scroll runs so as to avoid assigning disabled bogus rows and
5594 unnecessary graphics copy operations.
5596 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5598 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5599 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5600 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5601 (malloc, free, realloc, calloc): Redirect to e_* only when
5604 * lisp.h (GCTYPEBITS): Move before first use.
5605 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5606 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5607 this macro definition.
5609 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5612 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5614 * gtkutil.c (xg_create_frame_widgets):
5615 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5616 present with Gtk+ 2.0.
5618 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5620 * fileio.c (Finsert_file_contents): Undo previous change; see
5621 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5623 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5625 Rename locals to avoid shadowing.
5626 * fileio.c (Finsert_file_contents):
5627 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5628 * process.c (wait_reading_process_output):
5629 Rename inner 'proc' to 'p' to avoid shadowing.
5630 Indent for consistency with usual Emacs style.
5632 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5634 * xdisp.c (redisplay_window): If cursor row is not fully visible
5635 after recentering, and scroll-conservatively is set to a large
5636 number, scroll window by a few more lines to make the cursor fully
5637 visible and out of scroll-margin. (Bug#10105)
5638 (start_display): Don't move to the next line if the display should
5639 start at a newline that is part of a display vector or an overlay
5642 2011-11-24 Juri Linkov <juri@jurta.org>
5644 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5645 after the `MagickPingImage' call. (Bug#10112)
5647 2011-11-23 Chong Yidong <cyd@gnu.org>
5649 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5651 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5653 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5654 making another buffer current. (Bug#10114)
5656 2011-11-23 Glenn Morris <rgm@gnu.org>
5658 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5660 2011-11-23 Chong Yidong <cyd@gnu.org>
5662 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5663 using it (Bug#5984).
5665 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5667 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5668 and header-lines, as they don't have one computed for them.
5671 * .gdbinit (prow): Make displayed values more self-explaining.
5672 Add row's hash code.
5674 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5676 * process.c (wait_reading_process_output): Fix asynchrounous
5677 GnuTLS socket handling on some versions of the GnuTLS library.
5678 (wait_reading_process_output): Add comment and URL.
5680 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5682 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5684 2011-11-21 Chong Yidong <cyd@gnu.org>
5686 * window.c (Fnext_window, Fprevious_window): Doc fix.
5688 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5690 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5692 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5694 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5696 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5698 * window.c (Fset_window_combination_limit): Rename argument
5700 (Vwindow_combination_limit): Remove "status" from doc-string.
5702 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5704 * m/ibms390.h: Remove.
5705 * m/ibms390x.h: Don't include "ibms390.h".
5707 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5709 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5710 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5712 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5714 * casetab.c (Fset_case_table):
5715 * charset.c (Fcharset_after): Fix typos.
5717 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5719 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5720 Otherwise, valgrind does not work on some platforms.
5721 Problem reported by Andreas Schwab in
5722 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5723 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5724 is set, removing the need for VIRT_ADDRESS_VARIES.
5725 (PURE_P): Use a more-efficient implementation that needs just one
5726 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5727 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5728 to 4 (xorl, subq, cmpq, setbe).
5729 * alloc.c (pure): Always extern now, since that's the
5730 VIRT_ADDR_VARIES behavior.
5731 (PURE_POINTER_P): Use a single comparison, not two, for
5732 consistency with the new puresize.h.
5733 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5734 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5735 Remove VIRT_ADDR_VARIES no longer needed.
5737 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5739 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5740 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5741 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5742 behave as if the cursor position were at the window margin.
5744 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5745 and the cursor position is out of bounds, behave as if the cursor
5746 position were at the window margin. (Bug#10075)
5748 2011-11-18 Chong Yidong <cyd@gnu.org>
5750 * window.c (Fwindow_combination_limit): Make first argument
5751 non-optional, since it is meaningless for live windows like the
5754 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5756 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5758 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5760 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5761 (graft_intervals_into_buffer): Simplify.
5763 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5765 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5766 hash values of the two rows.
5767 (copy_row_except_pointers): Preserve the used[] arrays and the
5768 hash values of the two rows. (Bug#10035)
5769 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5771 * xdisp.c (row_hash): New function, body extracted from
5772 compute_line_metrics.
5773 (compute_line_metrics): Call row_hash, instead of computing the
5776 * dispnew.c (verify_row_hash): Call row_hash for computing the
5777 hash code of a row, instead of duplicating code from xdisp.c.
5779 * dispextern.h (row_hash): Add prototype.
5781 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5783 * frame.c (delete_frame): Don't delete the terminal when the last
5784 X frame is closed if emacs is built with GTK toolkit.
5786 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5788 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5790 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5792 * window.c (Vwindow_splits): Rename to
5793 Vwindow_combination_resize. Suggested by Juri Linkov.
5794 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5797 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5799 * nsfns.m (Fns_font_name):
5800 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5802 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5804 * window.h (window): Rename slot "nest" to "combination_limit".
5805 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5806 (Fset_window_nest): Rename to Fset_window_combination_limit.
5807 (Vwindow_nest): Rename to Vwindow_combination_limit.
5808 (recombine_windows, make_parent_window, make_window)
5809 (Fsplit_window_internal, saved_window)
5810 (Fset_window_configuration, save_window_save): Rename all
5811 occurrences of window_nest to window_combination_limit.
5813 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5815 * image.c (imagemagick_load_image): Fix typo.
5817 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5819 * xdisp.c (display_line): Move the call to
5820 highlight_trailing_whitespace before the call to
5821 compute_line_metrics, since the latter needs to see the final
5822 faces of all the glyphs to compute ROW's hash value.
5823 Fixes assertion violations in row_equal_p. (Bug#10035)
5825 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5827 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5828 just return (bug#10044).
5830 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5832 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5833 with user-defined heap size. Bump the default size of the temacs
5834 heap to 27MB, to avoid memory warning when running temacs.
5835 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5837 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5838 current_matrix and desired_matrix. (Bug#9990)
5839 (verify_row_hash) [XASSERTS]: New function.
5840 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5841 that the hash value of glyph rows is correct.
5843 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5845 * window.h (window): Remove splits slot.
5846 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5847 (Fdelete_other_windows_internal, make_parent_window)
5848 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5849 (Fset_window_configuration, save_window_save): Don't deal with
5850 split status of windows.
5851 (saved_window): Remove splits slot.
5852 (Vwindow_splits): Rewrite doc-string.
5854 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5856 * xfns.c (unwind_create_frame):
5857 * nsfns.m (unwind_create_frame):
5858 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5859 Vframe_list (Bug#9999).
5861 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5863 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5865 2011-11-11 Kenichi Handa <handa@m17n.org>
5867 * callproc.c (Fcall_process): Set the member dst_multibyte of
5870 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5872 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5873 avoid a crash (bug#9496).
5875 2011-11-09 Chong Yidong <cyd@gnu.org>
5877 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5878 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5880 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5882 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5884 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5886 Avoid some portability problems by eschewing 'extern inline' functions.
5887 The trivial performance wins aren't worth the portability hassles; see
5888 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5890 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5891 (window_box_width, window_box_left, window_box_left_offset)
5892 (window_box_right, window_box_right_offset): Undo previous change,
5893 by removing the "extern"s.
5894 * intervals.c (adjust_intervals_for_insertion)
5895 (adjust_intervals_for_deletion): Undo previous change,
5896 making these static again.
5897 (offset_intervals, temp_set_point_both, temp_set_point)
5898 (copy_intervals_to_string): No longer inline.
5899 * xdisp.c (window_text_bottom_y, window_box_width)
5900 (window_box_height, window_box_left_offset)
5901 (window_box_right_offset, window_box_left, window_box_right)
5902 (window_box): No longer inline.
5904 2011-11-08 Chong Yidong <cyd@gnu.org>
5906 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5907 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5908 Signal an error if not a live window.
5909 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5910 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5912 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5914 * lisp.h (syms_of_abbrev): Remove declaration.
5915 Reported by CHENG Gao <chenggao@royau.me>.
5917 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5919 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5920 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5921 of temacs in GUI mode.
5923 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5925 * window.h: Declare delete_all_child_windows instead of
5926 delete_all_subwindows.
5927 * window.c (Fwindow_nest, Fset_window_nest)
5928 (Fset_window_new_total, Fset_window_new_normal)
5929 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5930 (delete_all_subwindows): Rename to delete_all_child_windows.
5931 (Fdelete_other_windows_internal, Fset_window_configuration):
5932 Call delete_all_child_windows instead of delete_all_subwindows.
5933 * frame.c (delete_frame): Call delete_all_child_windows instead
5934 of delete_all_subwindows.
5936 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5938 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5939 This is also needed for porting to any host where GC_MARK_STACK is
5940 not GC_MAKE_GCPROS_NOOPS.
5941 (which_symbols): Use it.
5943 2011-11-07 Kenichi Handa <handa@m17n.org>
5945 * coding.c (coding_set_destination): Check coding->src_pos only
5946 when coding->src_object is a buffer (bug#9910).
5948 * process.c (send_process): Set the member src_multibyte of coding
5949 to 0 (bug#9911) when sending a unibyte text.
5951 * callproc.c (Fcall_process): Set the member src_multibyte of
5952 process_coding to 0 (bug#9912).
5954 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5956 * xmenu.c (cleanup_widget_value_tree): New function.
5957 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5958 calling free_menubar_widget_value_tree directly (Bug#9830).
5960 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5962 Fix some portability problems with 'inline'.
5963 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5964 (window_box_width, window_box_left, window_box_left_offset)
5965 (window_box_right, window_box_right_offset): Declare extern.
5966 Otherwise, these inline functions do not conform to C99 and
5967 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5968 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5969 * intervals.c (adjust_intervals_for_insertion)
5970 (adjust_intervals_for_deletion): Now extern, because otherwise the
5971 extern inline functions 'offset_intervals' couldn't refer to it.
5972 (static_offset_intervals): Remove.
5973 (offset_intervals): Rewrite using the old contents of
5974 static_offset_intervals. The old version didn't conform to C99
5975 because an extern inline function contained a reference to an
5976 identifier with static linkage.
5978 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5980 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5983 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5985 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5986 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5987 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5988 return Qleft_to_right.
5990 2011-11-06 Chong Yidong <cyd@gnu.org>
5992 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5993 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5994 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5995 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5996 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5997 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5998 (Fwindow_vscroll): Doc fix.
5999 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6000 argument, since it makes no sense to pass a live window and for
6001 consistency with window-child.
6003 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6005 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6008 2011-11-05 Jason Rumney <jasonr@gnu.org>
6010 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6011 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6013 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6014 bitwise arithmetic preventing use of unicode-sip and non-truetype
6017 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6019 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6022 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6023 initialization code to keep similarity to xfns.c after changes
6026 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6028 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6029 (unwind_create_frame): New function (Bug#9943).
6030 (Fx_create_frame): Restructure code to be more similar to the one in
6031 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6032 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6033 Move terminal->reference_count++ just before making the frame official
6036 * nsterm.m (x_free_frame_resources): New function.
6037 (x_destroy_window): Move code to x_free_frame_resources.
6039 * xfns.c (unwind_create_frame): Fix comment.
6040 (Fx_create_frame, x_create_tip_frame):
6041 Move terminal->reference_count++ just before making the frame
6042 official. Move initialization of image_cache_refcount and
6043 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6045 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6047 Support MSVC build with newer versions of Visual Studio.
6048 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6049 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6052 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6053 which are not supported by MSVC.
6054 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6055 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6057 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6059 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6061 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6063 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6065 Support MSVC build with newer versions of Visual Studio.
6066 * w32.c: Don't include w32api.h for MSVC.
6067 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6069 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6070 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6071 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6072 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6074 (alloca) [_MSC_VER]: Define to _alloca.
6076 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6078 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6080 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6082 * xdisp.c (note_mouse_highlight): If either of
6083 previous/next-single-property-change returns nil, treat that as
6084 the beginning or the end of the buffer. (Bug#9955)
6086 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6088 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6089 label is not null (Bug#9951).
6090 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6093 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6095 * window.c (Fwindow_body_size): Mention in the doc string that the
6096 return value is in frame's canonical units. (Bug#9949)
6098 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6100 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6102 * w32fns.c (unwind_create_frame): If needed, free the glyph
6103 matrices of the partially constructed frame. (Bug#9943)
6104 * xfns.c (unwind_create_frame): Likewise.
6106 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6108 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6109 Don't stop backward scan on the continuation glyph, even though
6110 its CHARPOS is positive.
6111 (mouse_face_from_buffer_pos, note_mouse_highlight):
6112 Rename cover_string to disp_string.
6114 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6116 * window.c (temp_output_buffer_show): Don't use
6117 Vtemp_buffer_show_specifiers.
6118 (Vtemp_buffer_show_specifiers): Remove unused variable.
6120 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6122 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6123 past the beginning of the current glyph matrix.
6125 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6127 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6128 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6129 HAVE_GTK3 (Bug#9869).
6131 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6132 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6134 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6136 * xterm.c: Declare x_handle_net_wm_state to return int.
6137 (handle_one_xevent): Check if we are iconified but don't have
6138 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6139 (get_current_wm_state): Return non-zero if not hidden,
6140 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6141 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6142 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6143 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6145 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6147 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6148 so that this new function doesn't get optimized away by a
6149 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6151 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6153 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6155 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6157 Fix the `xbytecode' command.
6158 * .gdbinit (xprintbytestr): New command.
6159 (xwhichsymbols): Rename from `which'; all callers changed.
6160 (xbytecode): Print the byte-code string as well.
6162 2011-10-29 Kim Storm <storm@cua.dk>
6164 * alloc.c (which_symbols): New function.
6166 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6168 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6171 2011-10-29 Glenn Morris <rgm@gnu.org>
6173 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6174 Not clear what it was for, and it causes various bugs. (Bug#9839)
6176 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6178 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6179 possible random value that matches one of those tested as
6180 condition to clear the mouse face.
6182 2011-10-28 Chong Yidong <cyd@gnu.org>
6184 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6186 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6188 * window.c (make_window): Initialize phys_cursor_on_p.
6190 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6192 * lisp.h (struct Lisp_Symbol): Update comments.
6194 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6196 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6198 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6200 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6201 <oslsachem@gmail.com> for helping to debug this.
6203 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6204 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6205 (g_b_init_get_glyph_outline_w): New static variables.
6206 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6207 (GetGlyphOutlineW_Proc): New typedefs.
6208 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6209 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6211 (w32font_open_internal, compute_metrics):
6212 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6213 instead of calling the "wide" APIs directly.
6215 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6217 * w32.h (syms_of_w32font): Add prototype.
6219 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6221 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6222 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6223 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6224 (Fmove_to_window_line): Doc fix.
6226 2011-10-27 Chong Yidong <cyd@gnu.org>
6228 * process.c (make_process): Set gnutls_state to NULL.
6230 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6231 non-NULL, regardless of GNUTLS_INITSTAGE.
6232 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6233 an error. Set process slots as soon as we allocate them.
6235 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6237 2011-10-27 Chong Yidong <cyd@gnu.org>
6239 * gnutls.c (emacs_gnutls_deinit): New function.
6240 Deallocate credentials structures as well as calling gnutls_deinit.
6241 (Fgnutls_deinit, Fgnutls_boot): Use it.
6243 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6244 (deactivate_process): Call emacs_gnutls_deinit.
6246 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6248 * image.c (x_create_x_image_and_pixmap):
6249 * w32.c (sys_rename, w32_delayed_load):
6250 * w32font.c (fill_in_logfont):
6251 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6253 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6255 * w32fns.c (w32_default_color_map): New function,
6256 extracted from Fw32_default_color_map.
6257 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6259 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6261 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6263 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6265 * keyboard.c (test_undefined): New function (bug#9751).
6266 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6268 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6270 * sysdep.c (init_sys_modes): Fix the check for the controlling
6271 terminal (Bug#6649).
6273 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6275 * dispextern.h (struct bidi_it): New member next_en_type.
6277 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6278 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6279 current character, check also for next_en_type being WEAK_EN.
6280 (bidi_resolve_weak): Don't enter the expensive loop if the current
6281 position is before next_en_pos. Record the bidi type of the first
6282 non-ET, non-BN character we find, in addition to its position.
6283 (bidi_level_of_next_char): Invalidate next_en_type when
6284 next_en_pos is over-stepped.
6286 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6288 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6289 * editfns.c: Rewrite current-time-zone so that it invokes
6290 the equivalent of (format-time-string "%Z") to get the time zone name.
6291 This fixes a bug when the time zone name contains characters that
6292 need converting from the system time locale to Emacs internal format.
6293 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6294 that patch fixed format-time-string to do the conversion, but
6295 I forgot to fix current-time-zone.
6296 (format_time_string): New function, containing most of
6297 what Fformat_time_string used to contain.
6298 (Fformat_time_string): Rewrite in terms of format_time_string.
6299 This doesn't change this function's behavior.
6300 (current-time-zone): Rewrite to use format_time_string.
6301 This fixes the bug reported by Michael Schierl in
6302 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6303 Jason Rumney's 2007-06-07 change worked around this bug, but
6305 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6307 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6309 * xdisp.c (start_display): If the character at POS is displayed
6310 via a display vector, reset IT->current.dpvec_index to zero.
6311 (try_window_reusing_current_matrix): If a line ends in a display
6312 vector or the next line starts in a display vector, continue
6313 redrawing the window even though the character position of
6314 start_row was reached.
6317 2011-10-18 Chong Yidong <cyd@gnu.org>
6319 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6320 with nobreak-char-display too.
6322 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6324 Fix part 3 of bug#9771.
6325 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6326 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6327 non-neutral characters if the current character is a paragraph
6328 separator (a.k.a. Newline). This avoids running the same
6329 expensive loop twice, once when we consume the preceding newline
6330 and the other time when the line actually needs to be displayed.
6331 Avoid the loop when we see neutrals on the base embedding level
6332 following a character whose directionality is the same as the
6333 paragraph's. This avoids running the expensive loop when a line
6334 ends in a long sequence of neutrals, like control characters.
6335 Add assertion against STRONG_AL type. Slightly rearrange code
6336 that determines the type of a neutral given the first non-neutral
6338 (bidi_level_of_next_char): Set next_en_pos to zero when
6339 invalidating its info.
6341 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6343 * xdisp.c (push_display_prop): Determine whether to record string
6344 or buffer position by IT->string, not by IT->method. Allow
6345 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6346 (move_it_vertically_backward): Don't look for character position
6347 immediately after the newline when in a continuation line.
6350 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6352 * window.c (coordinates_in_window): Rewrite and delabelize
6353 vertical border check. (Bug#5357) (Bug#9618)
6355 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6357 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6358 errors in XSetWindowBorder (bug#9310).
6360 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6362 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6363 avoid crash when xmalloc overrun checking is enabled.
6365 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6367 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6368 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6369 cursor motion with <left> and <right> arrow keys.
6371 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6372 some callers set that themselves.
6374 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6376 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6377 display string and the previous row comes from the same string and
6378 is empty. (Bug#9739) (Bug#9738)
6380 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6382 * doc.c (get_doc_string): Encode file name (bug#9735).
6384 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6386 * bidi.c (bidi_level_of_next_char):
6387 * xdisp.c (get_visually_first_element): Remove old incorrect
6388 comments regarding the Unicode Line Separator character.
6390 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6392 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6394 * alloc.c (Fgc_status): Do not access beyond zombies array
6395 boundary if nzombies > MAX_ZOMBIES.
6396 * alloc.c (dump_zombies): Add missing format specifier.
6398 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6400 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6401 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6403 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6404 Some packages use them to denote characters with modifiers.
6406 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6408 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6409 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6410 matching a pp-number. Rename parameter var to var1.
6412 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6414 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6416 2011-10-08 Glenn Morris <rgm@gnu.org>
6418 * callint.c (Fcall_interactively): Give a more explicit error for the
6419 'c' case with a non-character input. (Bug#8479)
6421 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6423 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6425 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6426 lines that are hscrolled on the left.
6428 * dispnew.c (buffer_posn_from_coords): Account for a possible
6429 presence of header-line. (Bug#4426)
6431 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6433 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6434 Don't advertise functionality which we discourage or doesn't work.
6436 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6438 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6439 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6440 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6441 this makes Emacs dump core during garbage collection on rare
6442 occasions. sizeof is obviously inferior to offsetof here, so
6443 stick with offsetof.
6444 (GC_POINTER_ALIGNMENT): New macro.
6445 (mark_memory): Omit 3rd (offset) arg; caller changed.
6446 Don't assume EMACS_INT alignment is the same as pointer alignment.
6448 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6450 * keyboard.c (read_key_sequence_remapped): New var.
6451 (read_key_sequence): Compute remapping in the right buffer.
6452 (command_loop_1): Use read_key_sequence's remapping directly.
6454 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6456 * dired.c (file_name_completion): Don't expand file name.
6457 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6458 before checking file name handler.
6460 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6461 they've been requested explicitly (bug#9591).
6463 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6465 * keymap.c (Fsingle_key_description): Use make_specified_string
6466 instead of build_string to build string from push_key_description.
6469 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6471 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6472 This fixes a Y2038 bug on 64-bit hosts.
6473 * buffer.c (reset_buffer):
6474 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6475 (Fclear_buffer_auto_save_failure):
6476 Use 0, not -1, to represent an unset failure time, since time_t
6477 might not be signed.
6479 Remove dependency on glibc malloc internals.
6480 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6481 Move back here from lisp.h, but with their new implementations.
6482 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6483 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6484 * charset.c (charset_table_init): New static var.
6485 (syms_of_charset): Use it instead of xmalloc. This removes a
6486 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6487 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6488 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6489 Move back to alloc.c.
6490 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6491 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6493 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6495 * nsterm.m (windowDidResize): Call x_set_window_size only when
6496 ns_in_resize is true. Otherwise set pixelwidth/height and
6497 call change_frame_size (Bug#9628).
6499 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6501 Port --enable-checking=all to Fedora 14 x86-64.
6502 * charset.c (syms_of_charset): Also account for glibc malloc's
6503 internal overhead when calculating the initial malloc maximum.
6505 Port --enable-checking=all to Fedora 14 x86.
6506 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6508 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6509 (overrun_check_realloc, overrun_check_free):
6510 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6511 That way, xmalloc returns a properly-aligned pointer even if
6512 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6513 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6514 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6515 into account when calculating the initial malloc maximum.
6516 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6517 Move here from alloc.c, so that charset.c can use it too.
6518 Properly align; the old code wasn't right for common 32-bit hosts
6519 when configured with --enable-checking=all.
6520 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6521 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6523 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6525 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6528 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6530 * xdisp.c (compute_display_string_end): If there's no display
6531 string at CHARPOS, return -1.
6533 * bidi.c (bidi_fetch_char): When compute_display_string_end
6534 returns a negative value, treat the character as a normal
6535 character not covered by a display string. (Bug#9624)
6537 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6539 * lread.c (Fread_from_string): Fix typo in docstring.
6541 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6543 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6544 newline, reseat the iterator instead of bidi-iterating there one
6545 character at a time. (Bug#9610)
6546 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6547 TO_CHARPOS if the bidi iterator is at base embedding level.
6549 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6551 * lread.c (readevalloop): Use correct code for NBSP.
6552 (read1): Likewise. (Bug#9608)
6554 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6556 * dbusbind.c (Fdbus_register_signal): When service is not
6557 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6559 2011-09-25 Glenn Morris <rgm@gnu.org>
6561 * buffer.c (truncate-lines): Doc fix.
6563 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6565 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6566 (Fset_window_next_buffers): Doc fix.
6568 2011-09-24 Glenn Morris <rgm@gnu.org>
6570 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6572 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6574 Fix minor problems found by static checking.
6575 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6576 * indent.c (Fvertical_motion): Fix == vs = typo.
6578 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6580 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6581 Default value is now t. Doc fix.
6583 * indent.c (Fvertical_motion): Compute and apply the overshoot
6584 logic when moving up, not only when moving down. Fix the
6585 confusing name and values of the it_overshoot_expected variable;
6586 logic changes accordingly. (Bug#9254) (Bug#9549)
6588 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6589 CHARPOS is covered by a display string which includes newlines.
6590 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6591 is covered by a display string with embedded newlines.
6593 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6595 * dbusbind.c (Fdbus_register_signal): Add match rule to
6596 Vdbus_registered_objects_table. (Bug#9581)
6597 (Fdbus_register_method, Vdbus_registered_objects_table):
6600 2011-09-24 Jim Meyering <meyering@redhat.com>
6602 do not ignore write error for any output size
6603 The previous change was incomplete.
6604 While it makes emacs --batch detect the vast majority of stdout
6605 write failures, errors were still ignored whenever the output size is
6606 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6607 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6608 && echo FAIL: ignored write error
6609 FAIL: ignored write error
6610 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6611 && echo FAIL: ignored write error
6612 FAIL: ignored write error
6613 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6615 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6617 * emacs.c (Fkill_emacs): In noninteractive mode exit
6618 non-successfully if a write error occurred on stdout. (Bug#9574)
6620 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6622 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6625 * dispextern.h (struct it): Update the comment documenting what
6628 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6630 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6631 a display string, extend search for cursor position to end of row.
6632 (find_row_edges): If the row ends in a newline from a display
6633 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6634 Handle the case of a display string with multiple newlines.
6635 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6636 non-empty line. Fixes confusing cursor motion with arrow keys at
6637 the beginning of a line that starts with whitespace.
6639 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6641 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6644 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6646 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6649 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6651 * xdisp.c (display_line): Record maximum and minimum buffer
6652 positions even if no glyphs were produced (e.g., by a zero-width
6653 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6654 buffer positions that will be removed from the glyph row because
6656 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6657 column is beyond frame width: don't subtract 1 "pixel" when
6658 computing width of the stretch.
6659 (reseat_at_next_visible_line_start): Undo the change made on
6660 2011-09-17 that saved paragraph information and restored it after
6661 the call to `reseat'. (Bug#9545)
6663 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6665 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6666 and turn window cursor on if cleared (Bug#9415).
6668 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6670 * search.c (boyer_moore): Take unibyte characters from pattern
6671 literally. (Bug#9458)
6673 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6675 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6677 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6679 Fix minor problem found by static checking.
6680 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6681 initialized, to pacify gcc -Wuninitialized.
6683 * fileio.c: Report proper errno when syscall falls.
6684 (Finsert_file_contents): Save and restore errno,
6685 so that report_file_error outputs the correct diagnostic.
6686 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6688 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6690 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6692 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6694 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6695 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6697 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6699 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6700 about the current paragraph and restore it after the call to reseat.
6702 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6703 (bidi_find_paragraph_start): Search back for paragraph beginning
6704 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6705 (bidi_move_to_visually_next): Only trigger paragraph-related
6706 computations when the last character is a newline or at EOB, not
6707 just any NEUTRAL_B. (Bug#9470)
6709 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6710 truncated lines if point is covered by a display string. (Bug#9524)
6712 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6714 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6715 (cons_to_x_long): New function.
6716 (lisp_data_to_selection_data): Use it. Correct the test for
6717 short-versus-long data; it was negated. Break out of vector
6718 loop, for efficiency, when a long datum is discovered.
6720 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6722 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6724 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6726 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6727 GCC PR/17406) by declaring this function with external scope.
6729 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6731 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6732 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6734 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6736 * editfns.c (Fformat): Correctly handle text properties on "%%".
6738 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6740 * xterm.c (x_draw_composite_glyph_string_foreground):
6741 * w32term.c (x_draw_composite_glyph_string_foreground):
6742 * term.c (encode_terminal_code):
6743 * composite.c (composition_update_it, get_composition_id):
6744 * xdisp.c (get_next_display_element)
6745 (fill_composite_glyph_string): Add comments about special meaning
6746 of TAB characters in a composition.
6748 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6750 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6751 This occurs when processing a multibyte format.
6752 Problem reported by Wolfgang Jenker.
6754 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6756 * xdisp.c (try_cursor_movement): Only check for exact match if
6757 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6759 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6761 Remove unused external symbols.
6762 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6763 * xdisp.c (calc_pixel_width_or_height): Now static.
6764 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6765 * indent.c (check_display_width):
6766 * w32term.c: Fix comment to match code.
6767 * xterm.c, xterm.h (x_catching_errors): Remove.
6769 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6771 * xselect.c: Use signed conversions more consistently (Bug#9498).
6772 (selection_data_to_lisp_data): Assume incoming selection data are
6773 signed integers, not unsigned. This is to be consistent with
6774 outgoing selection data, which was modified to use signed integers
6775 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6776 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6777 expects long, not unsigned long.
6779 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6781 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6782 computation of loop end. Reported by Johan Bockgård
6785 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6787 * frame.c (Fother_visible_frames_p): Function deleted.
6789 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6791 * indent.c (compute_motion): Process display vector front to back
6792 rather than the other way around. (Bug#2496)
6794 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6796 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6798 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6800 * minibuf.c (Fread_from_minibuffer): Doc fix.
6802 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6804 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6805 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6807 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6809 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6810 value for non-existent files.
6812 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6814 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6815 set its "size" to -1. This will set the modtime_size field of
6816 the corresponding buffer to -1, which is what
6817 verify-visited-file-modtime expects for files that do not exist.
6820 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6822 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6824 * lisp.h: ... from here. push_key_description is no longer
6825 defined in keyboard.c, so its declaration should not be in
6826 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6827 logically belongs with push_key_description.
6829 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6831 * buffer.h: Include <sys/types.h> instead of <time.h>.
6832 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6833 Problem reported by Herbert J. Skuhra.
6835 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6837 * xml.c (parse_region): Make the parsing work for
6838 non-comment-starting XML files again (bug#9144).
6840 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6842 * image.c (gif_load): Fix calculation of bottom and right corner.
6845 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6847 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6848 redisplay in small windows.
6850 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6852 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6854 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6856 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6857 Operate on live windows only.
6859 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6861 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6863 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6865 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6866 only under bidi iteration.
6868 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6870 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6872 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6874 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6875 Without this fix, the command to link temacs failed due to an
6876 undefined symbol __builtin_isnan. This is because
6877 /usr/include/iso/math_c99.h #defines isnan(x) to
6878 __builtin_isnan(x), but the bundled gcc, which identifies itself
6879 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6881 * floatfns.c (isnan): #undef, and then #define to a clone of
6883 (Fisnan): Always define, since it's always available now.
6884 (syms_of_floatfns): Always define isnan at the Lisp level.
6886 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6888 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6890 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6892 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6893 The previous code assumed that file offsets (off_t values) fit in
6894 EMACS_INT variables, which is not true on typical 32-bit hosts.
6895 The code messed up by falsely reporting buffer overflow in cases
6896 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6897 when "big" contains more than 2**29 bytes, even though this
6898 inserts just one byte and does not overflow the buffer.
6899 (Finsert_file_contents): Store file offsets as off_t
6900 values, not as EMACS_INT values. Check for overflow when
6901 converting between EMACS_INT and off_t. When checking for
6902 buffer overflow or for overlap, take the offsets into account.
6903 Don't use EMACS_INT for small values where int suffices.
6904 When checking for overlap, fix a typo: ZV was used where
6905 ZV_BYTE was intended.
6906 (Fwrite_region): Don't assume off_t fits into 'long'.
6907 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6909 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6911 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6913 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6915 sprintf-related integer and memory overflow issues (Bug#9412).
6917 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6918 (esprintf, exprintf, evxprintf): New functions.
6919 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6920 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6921 (modify_event_symbol): Do not assume that the length of
6922 name_alist_or_stem is safe to alloca and fits in int.
6923 (Fexecute_extended_command): Likewise for function name and binding.
6924 (Frecursion_depth): Wrap around reliably on integer overflow.
6925 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6926 since some callers pass EMACS_INT values.
6927 (Fsingle_key_description): Don't crash if symbol name contains more
6928 than MAX_ALLOCA bytes.
6929 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6930 (get_minibuffer): Arg is now EMACS_INT, not int.
6931 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6932 (esprintf, exprintf, evxprintf): New decls.
6933 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6935 * dbusbind.c (signature_cat): New function.
6936 (xd_signature, Fdbus_register_signal):
6937 Do not overrun buffer; instead, report string overflow.
6939 * dispnew.c (add_window_display_history): Don't overrun buffer.
6940 Truncate instead; this is OK since it's just a log.
6942 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6943 even if the time zone offset is outlandishly large.
6944 Don't mishandle offset == INT_MIN.
6946 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6947 when creating daemon; the previous buffer-overflow check was incorrect.
6949 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6950 which has the guts of the old verror function.
6952 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6953 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6955 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6956 (font_unparse_xlfd): Don't blindly alloca long strings.
6957 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6958 fits in int, when using sprintf. Use single snprintf to count
6959 length of string rather than counting it via multiple sprintfs;
6960 that's simpler and more reliable.
6961 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6962 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6963 sprintf, in case result does not fit in int.
6965 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6966 (fontset_from_font): Print it.
6968 * frame.c (tty_frame_count): Now printmax_t, not int.
6969 (make_terminal_frame, set_term_frame_name): Print it.
6970 (x_report_frame_params): In X, window IDs are unsigned long,
6971 not signed long, so print them as unsigned.
6972 (validate_x_resource_name): Check for implausibly long names,
6973 and don't assume name length fits in 'int'.
6974 (x_get_resource_string): Don't blindly alloca invocation name;
6975 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6978 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6979 (xg_check_special_colors, xg_set_geometry):
6980 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6982 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6983 Use esprintf, not sprintf, in case result does not fit in int.
6985 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6986 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6987 it as a large positive number.
6988 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6989 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6991 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6992 in case result does not fit in int.
6994 * print.c (float_to_string): Detect width overflow more reliably.
6995 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6996 buffer overrun. Don't assume list length fits in 'int'. Treat
6997 print length of 0 as 0, not as infinity; to be consistent with other
6998 uses of print length in this function. Don't overflow print length
6999 index. Don't assume hash table size fits in 'long', or that
7000 vectorlike size fits in 'unsigned long'.
7002 * process.c (make_process): Use printmax_t, not int, to format
7003 process-name gensyms.
7005 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7007 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7008 to avoid potential buffer overrun.
7010 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7011 if X resource line is longer than 512 bytes.
7013 * xfns.c (x_window): Make sprintf buffer a bit bigger
7014 to avoid potential buffer overrun.
7016 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7018 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7020 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7022 Integer overflow fixes for scrolling, etc.
7023 Without these, Emacs silently mishandles large integers sometimes.
7024 For example, "C-u 4294967297 M-x recenter" was treated as if
7025 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7027 * xdisp.c (try_window_id): Check Emacs fixnum range before
7028 converting to 'int'.
7030 * window.c (window_scroll_line_based, Frecenter):
7031 Check that an Emacs fixnum is in range before assigning it to 'int'.
7032 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7033 values converted from Emacs fixnums.
7034 (Frecenter): Don't wrap around a line count if it is out of 'int'
7035 range; instead, treat it as an extreme value.
7036 (Fset_window_configuration, compare_window_configurations):
7037 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7039 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7040 that can exceed INT_MAX. Check that EMACS_INT value is in range
7041 before assigning it to the (possibly-narrower) index.
7042 (match_limit): Don't assume that a fixnum can fit in 'int'.
7044 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7047 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7048 (Fvertical_motion): Don't wrap around LINES values that don't fit
7049 in 'int'. Instead, treat them as extreme values. This is good
7050 enough for windows, which can't have more than INT_MAX lines anyway.
7052 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7054 * Require libxml/parser.h to avoid compilation warning.
7056 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7058 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7059 since this reportedly can destroy thread storage.
7061 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7063 * syntax.c (find_defun_start): Update all cache variables if
7064 exiting early (Bug#9401).
7066 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7068 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7070 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7071 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7072 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7074 * term.c (tty_append_glyph): New function.
7075 (produce_stretch_glyph): Static function and its prototype deleted.
7077 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7080 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7082 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7083 when checking :margin (Bug#9390).
7084 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7085 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7086 so that the name doesn't mislead. All uses changed.
7088 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7090 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7093 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7095 * xdisp.c (move_it_to): Don't bail out early when reaching
7096 position beyond to_charpos, if we are scanning backwards.
7097 (move_it_vertically_backward): When DY == 0, make sure we get to
7098 the first character in the line after the newline.
7100 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7102 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7103 (ccl_driver): Do not generate an out-of-range pointer.
7104 (Fccl_execute_on_string): Remove unnecessary check for
7105 integer overflow, noted by Stefan Monnier in
7106 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7107 Remove a FIXME that didn't need fixing.
7108 Simplify the newly-introduced buffer reallocation code.
7110 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7112 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7114 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7116 Integer and memory overflow issues (Bug#9196).
7118 * doc.c (get_doc_string): Rework so that
7119 get_doc_string_buffer_size is the actual buffer size, rather than
7120 being 1 less than the actual buffer size; this makes xpalloc more
7123 * image.c (x_allocate_bitmap_record, cache_image):
7124 * xselect.c (Fx_register_dnd_atom):
7125 Simplify previous changes by using xpalloc.
7127 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7128 since either will do and ptrdiff_t is convenient with xpalloc.
7130 * charset.c (charset_table_size)
7131 (struct charset_sort_data.priority): Now ptrdiff_t.
7132 (charset_compare): Don't overflow if priorities differ greatly.
7133 (Fsort_charsets): Don't assume list length fits in int.
7134 Check for size-calculation overflow when allocating sort data.
7135 (syms_of_charset): Allocate an initial charset table that is
7136 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7138 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7140 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7141 The actual value is always <= INT_MAX, and leaving it unsigned made
7142 overflow checking harder.
7144 * dispextern.h (struct glyph_matrix.rows_allocated)
7145 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7146 with xpalloc. The values are still always <= INT_MAX.
7148 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7150 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7151 (SAFE_NALLOCA): New macro.
7153 * region-cache.c (struct boundary.pos, find_cache_boundary)
7154 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7155 (set_cache_region, invalidate_region_cache)
7156 (revalidate_region_cache, know_region_cache, region_cache_forward)
7157 (region_cache_backward, pp_cache):
7158 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7159 so that ptrdiff_t * can be passed to xpalloc.
7160 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7161 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7162 (pp_cache): Don't assume cache_len fits in int.
7163 * region-cache.h: Adjust extern decls to match.
7165 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7166 EMACS_INT, since either will do, for xpalloc.
7168 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7169 (xnmalloc, xnrealloc, xpalloc): New functions.
7171 * bidi.c (bidi_shelve_header_size): New constant.
7172 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7173 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7175 * bidi.c (bidi_cache_shrink):
7176 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7178 Don't update size of array until after memory allocation succeeds,
7179 because xmalloc/xrealloc may not return.
7180 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7181 now that we have proper integer overflow checking.
7182 (record_overlay_string, overlay_strings): Catch overflows when
7183 calculating size of overlay_str_buf.
7185 * callproc.c (Fcall_process): Check for size overflow when
7186 calculating size of args2.
7187 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7188 Normally we prefer signed values, but sticking with ptrdiff_t would
7189 require adding more-complicated checks.
7191 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7192 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7193 Redo buffer-overflow calculations to avoid integer overflow.
7194 Add a FIXME comment where memory seems to be over-allocated.
7196 * character.c (Fstring): Check for size-calculation overflow.
7198 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7199 unnecessary integer overflow. Check for size overflow.
7200 (encode_coding_object): Don't update size until xmalloc succeeds.
7202 * composite.c (get_composition_id): Check for overflow in glyph
7203 length calculations.
7205 Integer and memory overflow fixes for display code.
7206 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7207 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7208 (scrolling_window): Check for overflow in size calculations.
7209 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7210 Don't assume glyph table len fits in int.
7211 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7212 (row_table_size): Now ptrdiff_t, not int.
7213 (scrolling_window): Avoid overflow in size calculations.
7214 Don't update size until allocation succeeds.
7215 * fns.c (concat): Check for overflow in size calculations.
7216 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7217 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7218 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7220 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7221 (get_doc_string): Check for size calculation overflow.
7222 Don't update size until allocation succeeds.
7223 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7224 EMACS_INT, where ptrdiff_t will do.
7225 (Fsubstitute_command_keys): Check for string overflow.
7227 * editfns.c (set_time_zone_rule): Don't assume environment length
7229 (message_length): Now ptrdiff_t, not int.
7230 (Fmessage_box): Don't update size until allocation succeeds.
7231 Don't assume message length fits in int.
7232 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7234 * emacs.c (main): Do not reallocate argv, since there is a null at
7235 the end that can be overwritten, and this way there's no need to
7236 worry about size-calculation overflow.
7237 (sort_args): Check for size-calculation overflow.
7239 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7241 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7243 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7244 (x_set_scroll_bar_width, x_figure_window_size):
7245 Check for integer overflow.
7246 (x_set_alpha): Do not assume XINT fits in int.
7248 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7249 This is for the members text_lines, text_cols, total_lines, total_cols,
7250 where the system imposes an 'int' limit.
7252 * fringe.c (Fdefine_fringe_bitmap):
7253 Don't update size until alloc works.
7255 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7256 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7258 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7259 Check for size-calculation overflow.
7260 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7261 do, as we prefer signed integers.
7262 (id_to_widget.max_size, id_to_widget.used)
7263 (xg_store_widget_in_map, xg_remove_widget_from_map)
7264 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7265 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7266 Use and return ptrdiff_t, not int.
7267 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7268 * gtkutil.h: Change prototypes to match the above.
7270 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7271 are duplicate now that they've been promoted to lisp.h.
7272 (x_allocate_bitmap_record, x_alloc_image_color)
7273 (make_image_cache, cache_image, xpm_load):
7274 Don't update size until alloc is done.
7275 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7277 Check for size calculation overflow.
7278 (ct_colors_allocated_max): New constant.
7279 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7282 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7283 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7284 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7285 Use ptrdiff_t, not int, to count maps.
7286 (read_char_minibuf_menu_prompt): Check for overflow in size
7287 calculations. Don't update size until allocation succeeds.
7288 Redo calculations to avoid overflow.
7289 * keyboard.h: Change prototypes to match the above.
7291 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7293 (current_minor_maps): Check for size calculation overflow.
7294 * keymap.h: Change prototypes to match the above.
7296 * lread.c (read1, init_obarray): Don't update size until alloc done.
7298 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7299 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7301 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7302 Now ptrdiff_t, not int.
7303 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7304 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7306 * process.c (Fnetwork_interface_list): Check for overflow
7307 in size calculation.
7309 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7311 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7312 overflow. Don't bother calling xmalloc when xrealloc will do.
7314 * search.c (Freplace_match): Check for size calculation overflow.
7315 (Fset_match_data): Don't assume list lengths fit in 'int'.
7317 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7318 for command line length. Do not attempt to address one before the
7319 beginning of an array, as that's not portable.
7321 * term.c (max_frame_lines): Remove; unused.
7322 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7324 (encode_terminal_code, calculate_costs): Check for size
7325 calculation overflow.
7326 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7327 table lengths and related sizes. Don't update size until alloc
7328 done. Redo calculations to avoid overflow.
7329 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7331 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7332 subtracting pointers.
7333 (gobble_line): Check for overflow more carefully. Don't update size
7336 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7337 Don't update size until alloc done.
7338 Redo size calculations to avoid overflow.
7339 Check for size calculation overflow.
7340 (main) [DEBUG]: Fix typo in invoking tparam1.
7342 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7343 Use ptrdiff_t, not int, for sizes.
7344 (store_mode_line_noprop_char): Don't update size until alloc done.
7346 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7347 Use ptrdiff_t, not int, for sizes.
7348 (Finternal_make_lisp_face, cache_face):
7349 Check for size calculation overflow.
7350 (cache_face): Treat size calculation overflows as if they were
7351 memory exhaustion (the usual treatment), rather than aborting.
7353 * xfns.c (x_encode_text, x_set_name_internal)
7354 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7355 sizes, since they can exceed INT_MAX in size. Check for size
7356 calculation overflow.
7358 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7359 (xg_select): Check for size calculation overflow.
7360 Don't update size until alloc done.
7362 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7363 as sprintf is limited to int lengths.
7365 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7366 (X_LONG_MIN): New macros.
7367 Use them to make the following changes clearer.
7368 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7369 This change doesn't affect the value now, but it may help remind
7370 future maintainers not to raise the value too much later.
7371 (SELECTION_QUANTUM): Remove, replacing with ...
7372 (selection_quantum): ... new function, which avoids overflow.
7374 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7375 assumption that selection length fits in 'int'.
7376 (x_reply_selection_request, x_handle_selection_request)
7377 (x_get_window_property, receive_incremental_selection)
7378 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7379 (lisp_data_to_selection_data, clean_local_selection_data):
7380 Use ptrdiff_t, not int, to record length of selection.
7381 (x_reply_selection_request, x_get_window_property)
7382 (receive_incremental_selection, x_property_data_to_lisp):
7383 Redo calculations to avoid overflow.
7384 (x_reply_selection_request): When sending hint, ceiling it at
7385 X_LONG_MAX rather than relying on wraparound overflow to send
7387 (x_get_window_property, receive_incremental_selection)
7388 (lisp_data_to_selection_data, x_property_data_to_lisp):
7389 Check for size-calculation overflow.
7390 (x_get_window_property, receive_incremental_selection)
7391 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7392 Don't store size until memory allocation succeeds.
7393 (x_get_window_property): Plug memory leak on memory exhaustion.
7394 Don't double-block input; malloc is safe here. Don't assume 2**34
7395 - 4 fits in unsigned long. Add an xassert to check
7396 XGetWindowProperty overflow. Be more careful about overflow
7397 calculations, and distinguish size from memory overflow better.
7398 (receive_incremental_selection): When tracing, don't assume
7399 unsigned int is less than INT_MAX.
7400 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7401 harmful) conversions of unsigned short to int.
7402 (lisp_data_to_selection_data): Don't assume that integers
7403 in the range -65535 through -1 fit in an X unsigned short.
7404 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7405 result parameters unless successful. Rely on cons_to_unsigned
7406 to report problems with elements; the old code wasn't right anyway.
7407 (x_check_property_data): Check for int overflow; we cannot use
7408 a wider type due to X limits.
7409 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7411 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7413 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7414 (x_term_init): Check for size calculation overflow.
7415 (x_color_cells): Don't store size until memory allocation succeeds.
7416 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7417 Don't assume alloca size is less than MAX_ALLOCA.
7418 (x_term_init): Don't assume length fits in int (sprintf is limited
7421 Use ptrdiff_t for composition IDs.
7422 * character.c (lisp_string_width):
7423 * composite.c (composition_table_size, n_compositions)
7424 (get_composition_id, composition_gstring_from_id):
7425 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7426 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7427 * window.c (Frecenter):
7428 Use ptrdiff_t, not int, for composition IDs.
7429 * composite.c (get_composition_id): Check for integer overflow.
7430 * composite.h: Adjust prototypes to match the above changes.
7432 Use ptrdiff_t for hash table indexes.
7433 * category.c (hash_get_category_set):
7434 * ccl.c (ccl_driver):
7435 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7436 * coding.c (coding_system_charset_list, detect_coding_system):
7437 * coding.h (struct coding_system.id):
7438 * composite.c (get_composition_id, gstring_lookup_cache):
7439 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7440 * image.c (xpm_get_color_table_h):
7441 * lisp.h (hash_lookup, hash_put):
7442 * minibuf.c (Ftest_completion):
7443 Use ptrdiff_t for hash table indexes, not int (which is too
7444 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7445 32-bit --with-wide-int hosts).
7447 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7448 Add a FIXME comment about memory leaks.
7449 (syms_of_charset): Don't assume xmalloc returns.
7451 Don't assume that stated character widths fit in int.
7452 * character.c (Fchar_width, c_string_width, lisp_string_width):
7453 * character.h (CHAR_WIDTH):
7454 * indent.c (MULTIBYTE_BYTES_WIDTH):
7455 Use sanitize_char_width to avoid undefined and/or bad behavior
7456 with outlandish widths.
7457 * character.h (sanitize_tab_width): Rename from sanitize_width,
7458 now that we have two such functions. All uses changed.
7459 (sanitize_char_width): New inline function.
7461 Don't assume that tab-width fits in int.
7462 * character.h (sanitize_width): New inline function.
7463 (SANE_TAB_WIDTH): New macro.
7464 (ASCII_CHAR_WIDTH): Use it.
7465 * indent.c (sane_tab_width): Remove. All uses replaced by
7466 SANE_TAB_WIDTH (current_buffer).
7467 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7469 * fileio.c: Integer overflow issues with file modes.
7470 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7472 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7473 Remove unreachable code.
7474 (read_hex, load_charset_map_from_file): Check for integer overflow.
7476 * xterm.c: Don't go over XClientMessageEvent limit.
7477 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7478 (x_send_scroll_bar_event): Likewise. Check that the size does not
7479 exceed limits imposed by XClientMessageEvent, as well as the usual
7480 ptrdiff_t and size_t limits.
7482 * keyboard.c: Overflow, signedness and related fixes.
7483 (make_lispy_movement): Use same integer type in forward decl
7484 that is used in the definition.
7485 (read_key_sequence, keyremap_step):
7486 Change bufsize argument back to int, undoing my 2011-03-30 change.
7487 We prefer signed types, and int is wide enough here.
7488 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7489 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7490 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7491 length, not size_t. Use ptrdiff_t for index, not int.
7492 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7493 possibility of integer overflow.
7495 Overflow, signedness and related fixes for images.
7497 * dispextern.h (struct it.stack[0].u.image.image_id)
7498 (struct_it.image_id, struct image.id, struct image_cache.size)
7499 (struct image_cache.used, struct image_cache.ref_count):
7500 * gtkutil.c (update_frame_tool_bar):
7501 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7502 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7503 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7504 * nsmenu.m (update_frame_tool_bar):
7505 * xdisp.c (calc_pixel_width_or_height):
7506 * xfns.c (image_cache_refcount):
7507 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7508 on typical 64-bit hosts.
7510 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7511 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7512 Omit unnecessary casts to int.
7513 (parse_image_spec): Check that integers fall into 'int' range
7514 when the callers expect that.
7515 (image_ascent): Redo ascent calculation to avoid int overflow.
7516 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7517 (lookup_image): Remove unnecessary tests.
7518 (xbm_image_p): Locals are now of int, not EMACS_INT,
7519 since parse_image_check makes sure they fit into int.
7520 (png_load, gif_load, svg_load_image):
7521 Prefer int to unsigned where either will do.
7522 (tiff_handler): New function, combining the cores of the
7523 old tiff_error_handler and tiff_warning_handler.
7524 This function is rewritten to use vsnprintf and thereby avoid
7525 stack buffer overflows. It uses only the features of vsnprintf
7526 that are common to both POSIX and native Microsoft.
7527 (tiff_error_handler, tiff_warning_handler): Use it.
7528 (tiff_load, gif_load, imagemagick_load_image):
7529 Don't assume :index value fits in 'int'.
7530 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7531 (imagemagick_load_image): Check that crop parameters fit into
7532 the integer types that MagickCropImage accepts. Don't assume
7533 Vimagemagick_render_type has a nonnegative value. Don't assume
7534 size_t fits in 'long'.
7535 (gs_load): Use printmax_t to print the widest integers possible.
7536 Check for integer overflow when computing image height and width.
7538 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7540 * xdisp.c (redisplay_window): Don't force window start if point
7541 will be invisible in the resulting window. (Bug#9324)
7543 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7545 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7546 the display spec is of the form `(space ...)'.
7547 (handle_display_spec): Return the value returned by
7548 handle_single_display_spec, not just 1 or zero.
7549 (handle_single_display_spec): If the display spec is of the form
7550 `(space ...)', and specifies display in the text area, return 2
7552 (try_cursor_movement): Check for the need to scroll more
7553 accurately, and prefer exact match for point under bidi.
7554 Don't advance `row' beyond the last row of the window.
7556 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7557 into disp_prop; all users changed.
7559 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7560 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7561 for the text covered by the display property.
7563 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7565 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7566 Change return value to nil.
7567 (Frecord_buffer): Delete unused function.
7569 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7571 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7572 buffers, return left-to-right.
7573 (set_cursor_from_row): Consider candidate row a win if its glyph
7574 represents a newline and point is on that newline. Fixes cursor
7575 positioning on the newline at EOL of R2L text within L2R
7576 paragraph, and vice versa.
7577 (try_cursor_movement): Check continued rows, in addition to
7578 continuation rows. Fixes unwarranted scroll when point enters a
7579 continued line of R2L text within an L2R paragraph, or vice versa.
7580 (cursor_row_p): Consider the case of point being equal to
7581 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7582 from the end of a short line to the beginning of a continued line
7583 of R2L text within L2R paragraph.
7584 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7585 composed characters.
7587 * bidi.c (bidi_check_type): Use xassert.
7588 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7591 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7593 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7596 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7598 * nsfont.m (ns_otf_to_script): Fix typo.
7600 2011-08-22 Kenichi Handa <handa@m17n.org>
7602 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7603 extra slot even if the purpose is char-code-property-table.
7605 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7607 * xdisp.c (redisplay_window): When computing centering_position,
7608 account for the height of the header line. (Bug#8874)
7610 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7611 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7612 candidate is selected by the mouse, and that candidate has a
7613 composed character under the mouse.
7615 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7616 coordinates reported by pos-visible-in-window-p for a composed
7617 character in column zero.
7619 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7621 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7623 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7625 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7626 consider it a hit if to_charpos is anywhere in the range of the
7627 composed buffer positions.
7629 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7631 * image.c (gif_load): Don't assume that each subimage has the same
7632 dimensions as the base image. Handle disposal method that is
7633 "undefined" by the gif spec (Bug#9335).
7635 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7637 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7638 (Fcondition_case): Document `debug' symbol in error handler.
7640 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7642 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7643 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7644 from an Org mode buffer to a Speedbar frame.
7646 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7647 a composition, take its buffer position from IT->cmp_it.charpos.
7648 Fixes cursor positioning at the beginning of a line that begins
7649 with a composed character.
7651 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7653 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7654 character bidirectional type, use STRONG_L instead. Fixes crashes
7655 in a buffer produced by `describe-categories'.
7657 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7658 members before the level stack, so they would be saved and
7659 restored when copying iterator state. Fixes incorrect reordering
7660 around TABs covered by display properties.
7662 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7664 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7666 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7668 * eval.c (internal_condition_case, internal_condition_case_1)
7669 (internal_condition_case_2, internal_condition_case_n):
7670 Remove unnecessary aborts (Bug#9081).
7672 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7674 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7675 has no `load' handler, try opening the file locally. (Bug#9311)
7677 2011-08-16 Ken Brown <kbrown@cornell.edu>
7679 * gmalloc.c: Expand comment.
7681 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7683 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7684 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7686 2011-08-16 Ken Brown <kbrown@cornell.edu>
7688 Fix memory allocation problems in Cygwin build (Bug#9273).
7690 * unexcw.c ( __malloc_initialized): Declare external variable.
7691 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7693 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7695 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7697 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7699 [CYGWIN] (special_realloc): New function.
7700 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7701 requests to realloc storage in the static heap.
7703 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7705 * bidi.c (bidi_initialize): Remove unused local.
7707 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7710 * biditype.h: Remove file.
7711 * makefile.w32-in ($(BLD)/bidi.$(O)):
7712 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7714 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7716 * chartab.c: Improve commentary for the uniprop_table API.
7718 * bidi.c (bidi_paragraph_init): Support zero value of
7719 bidi_ignore_explicit_marks_for_paragraph_level.
7720 (bidi_initialize): Use uniprop_table instead of including
7721 biditype.h and bidimirror.h.
7723 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7724 coordinates of the iterator when restoring from ppos_it.
7727 2011-08-14 Kenichi Handa <handa@m17n.org>
7729 * process.c (create_process): Call setup_process_coding_systems
7730 after the pid of the process is set to -1 (Bug#8162).
7732 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7734 * xdisp.c (move_it_in_display_line_to): Don't invoke
7735 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7736 ppos_it. Fixes vertical cursor motion when line beginning is
7737 covered by an image. (Bug#9296)
7739 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7741 * nsterm.h (ns_run_ascript): Declare.
7742 (NSAPP_DATA2_RUNASSCRIPT): Define.
7744 * nsfns.m (as_script, as_result, as_status): New static variables.
7745 (ns_run_ascript): New function.
7746 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7747 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7748 the event loop. Get status from as_status (Bug#7276).
7750 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7751 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7752 the event loop (Bug#7276).
7754 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7756 * gnutls.c (QCgnutls_bootprop_priority)
7757 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7758 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7759 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7760 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7761 (QCgnutls_bootprop_verify_hostname_error)
7762 (QCgnutls_bootprop_callbacks_verify): Rename from
7763 Qgnutls_bootprop_..., all uses changed.
7765 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7768 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7770 * xfaces.c (Qframe_set_background_mode): Now static.
7771 * dispextern.h (Qframe_set_background_mode): Remove decl.
7773 * process.c (Fnetwork_interface_info): Declare local only if needed.
7775 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7777 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7778 (Fnetwork_interface_list): Allocate in increments of bytes instead
7779 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7780 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7782 (struct ifflag_def): notrailers is smart on OSX.
7783 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7784 Get hardware address with getifaddrs if available.
7786 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7788 * xdisp.c (iterate_out_of_display_property): xassert that
7789 IT->position is set to within IT->object's boundaries. Break from
7790 the loop as soon as EOB is reached; avoids infloops in redisplay
7791 when IT->position is set up wrongly due to some bug.
7792 Set IT->current to match the bidi iterator unconditionally.
7793 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7794 entry. Force push_it to save on the stack the current
7795 buffer/string position, to be restored by pop_it. Fix flags in
7796 the iterator structure wrt the object coming from a display
7797 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7798 properties. (Bug#9284)
7800 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7802 * fontset.c (fontset_get_font_group): Add proper type checks.
7805 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7807 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7808 and LC_VERSION_MIN_MACOSX.
7809 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7810 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7812 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7814 * xdisp.c (forward_to_next_line_start): Allow to use the
7815 no-display-properties-and-no-overlays under bidi display.
7816 Set disp_pos in the bidi iterator to avoid searches for display
7817 properties and overlays.
7819 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7821 * editfns.c (Fset_time_zone_rule): Document relationship with the
7824 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7825 the font entity extracted from the cache (Bug#8109).
7827 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7829 * composite.c (autocmp_chars): Don't reset point. That is done by
7830 restore_point_unwind (Bug#5984).
7832 2011-08-07 Juri Linkov <juri@jurta.org>
7834 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7835 to show the arg `TIME' instead of `TIMEVAL'.
7837 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7839 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7840 display property strides EOL and includes a newline, as in
7841 longlines-mode. (Bug#9254)
7842 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7843 word-wrap under bidirectional display. (Bug#9224)
7845 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7846 is non-zero, even if the data buffer is NULL. Fixes a crash in
7847 vertical-motion with longlines-mode. (Bug#9254)
7849 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7851 * bidi.c <bidi_cache_total_alloc>: Now static.
7852 (bidi_initialize): Initialize bidi_cache_total_alloc.
7854 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7857 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7858 amount allocated this far in `bidi_cache_total_alloc'.
7859 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7860 non-zero, only free the data buffer without restoring the cache
7861 contents. All callers changed.
7863 * dispextern.h (bidi_unshelve_cache): Update prototype.
7865 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7866 (move_it_in_display_line, move_it_to)
7867 (move_it_vertically_backward, move_it_by_lines): Replace the call
7868 to xfree to an equivalent call to bidi_unshelve_cache.
7869 (move_it_in_display_line_to): Fix logic of returning
7870 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7872 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7874 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7875 came from a string character with a `cursor' property. (Bug#9229)
7877 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7879 * Makefile.in (LIB_PTHREAD): New variable.
7880 (LIBES): Add LIB_PTHREAD (Bug#9216).
7882 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7883 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7885 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7887 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7889 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7891 * xterm.c (x_find_topmost_parent): New function.
7892 (x_set_frame_alpha): Find topmost parent window with
7893 x_find_topmost_parent and set the property there also (bug#9181).
7894 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7896 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7898 * callproc.c (Fcall_process): Avoid vfork clobbering
7899 the local vars buffer, coding_systems, current_dir.
7901 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7903 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7905 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7907 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7908 so that it is not optimized away.
7910 * xdisp.c (compute_display_string_pos): Remove unused local.
7912 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7914 Fix slow cursor motion and scrolling in large buffers with
7915 selective display, like Org Mode buffers. (Bug#9218)
7917 * dispextern.h (struct bidi_it): New member disp_prop_p.
7919 * xdisp.c: Remove one-slot cache of display string positions.
7920 (compute_display_string_pos): Accept an additional argument
7921 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7922 for a display string or property. If found, set DISP_PROP_P
7925 * bidi.c (bidi_fetch_char): Accept an additional argument
7926 DISP_PROP_P, and pass it to compute_display_string_pos.
7927 Only handle text covered by a display string if DISP_PROP_P is returned
7928 non-zero. All callers of bidi_fetch_char changed.
7930 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7932 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7934 2010-12-03 Don March <don@ohspite.net>
7936 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7937 last character M-[char] is translated to ESC [char] (bug#7541).
7939 2011-08-02 Kenichi Handa <handa@m17n.org>
7941 * lisp.h (uniprop_table): Extern it.
7943 * chartab.c (uniprop_table): Make it non-static.
7945 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7947 * xdisp.c (forward_to_next_line_start): Accept additional argument
7948 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7950 (reseat_at_next_visible_line_start): Use the bidi iterator state
7951 returned by forward_to_next_line_start to restore the state of
7952 it->bidi_it after backing up to previous newline. (Bug#9212)
7954 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7956 * regex.c (re_comp): Protoize.
7957 (re_exec): Fix return type.
7958 (regexec): Fix type of `ret'. (Bug#9203)
7960 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7962 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7963 This is needed if max-image-size is a floating-point number.
7965 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7967 * print.c (print_object): Print empty symbol as ##.
7969 * lread.c (read1): Read ## as empty symbol.
7971 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7973 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7974 setting frame foreground color (Bug#9175).
7975 (x_set_background_color): Likewise.
7977 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7978 contents (Bug#9176).
7979 (EmacsTooltip -init): Remove bezels and add shadows to
7982 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7983 or scroll bar (Bug#8470).
7985 * nsfont.m (nsfont_open): Remove assignment to voffset and
7986 unnecessary vars hshink, expand, hd, full_height, min_height.
7987 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7989 * nsterm.h (nsfont_info): Remove voffset field.
7991 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7993 Implement strike-through and overline on NextStep (Bug#8863).
7995 * nsfont.m (nsfont_open): Use underline position provided by font,
7996 instead of hard-coded value of 2.
7997 (nsfont_draw): Call ns_draw_text_decoration instead.
7999 * nsterm.h: Add declaration for ns_draw_text_decoration.
8001 * nsterm.m (ns_draw_text_decoration): New function for drawing
8002 underline, overline, and strike-through.
8003 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8004 ns_draw_text_decoration. Change treatment of cursor drawing to
8005 accommodate underlining, etc.
8007 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8009 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8012 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8014 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8015 Without this fix, if a signal arrives just after memory fills up,
8016 'malloc' might be invoked reentrantly.
8018 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8019 In other words, assume that every image size is allowed, on non-X
8020 hosts. This assumption is probably wrong, but it lets Emacs compile.
8022 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8024 * regex.c (re_iswctype): Convert return values to boolean.
8026 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8028 * xdisp.c (compute_display_string_pos): Don't use cached display
8029 string position if the buffer had its restriction changed.
8032 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8034 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8036 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8038 Integer signedness and overflow and related fixes. (Bug#9079)
8040 * bidi.c: Integer size and overflow fixes.
8041 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8042 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8043 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8044 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8045 (bidi_find_other_level_edge):
8046 Use ptrdiff_t instead of EMACS_INT where either will do.
8047 This works better on 32-bit hosts configured --with-wide-int.
8048 (bidi_cache_ensure_space): Check for size-calculation overflow.
8049 Use % rather than repeated addition, for better worst-case speed.
8050 Don't set bidi_cache_size until after xrealloc returns, because it
8052 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8053 (bidi_cache_ensure_space): Also check that the bidi cache size
8054 does not exceed that of the largest Lisp string or buffer. See Eli
8055 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8057 * alloc.c (__malloc_size_t): Remove.
8058 All uses replaced by size_t. See Andreas Schwab's note
8059 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8061 * image.c: Improve checking for integer overflow.
8062 (check_image_size): Assume that f is nonnull, since
8063 it is always nonnull in practice. This is one less thing to
8064 worry about when checking for integer overflow later.
8065 (x_check_image_size): New function, which checks for integer
8066 overflow issues inside X.
8067 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8068 This removes the need for a memory_full check.
8069 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8070 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8071 (xbm_read_bitmap_data): Change locals back to 'int', since
8072 their values must fit in 'int'.
8073 (xpm_load_image, png_load, tiff_load):
8074 Invoke x_create_x_image_and_pixmap earlier,
8075 to avoid much needless work if the image is too large.
8076 (tiff_load): Treat overly large images as if
8077 x_create_x_image_and_pixmap failed, not as malloc failures.
8078 (gs_load): Use x_check_image_size.
8080 * gtkutil.c: Omit integer casts.
8081 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8082 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8084 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8086 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8087 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8088 would wrongly return t on a 64-bit host.
8090 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8091 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8092 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8093 and therefore cause GCC to emit a bogus diagnostic in some cases.
8095 * image.c: Integer signedness and overflow and related fixes.
8096 This is not an exhaustive set of fixes, but it's time to
8097 record what I've got.
8098 (lookup_pixel_color, check_image_size): Remove redundant decls.
8099 (check_image_size): Don't assume that arbitrary EMACS_INT values
8100 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8101 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8102 (tiff_load, imagemagick_load_image):
8103 Check for overflow in size calculations.
8104 (x_create_x_image_and_pixmap): Remove unnecessary test for
8105 xmalloc returning NULL; that can't happen.
8106 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8107 (xpm_color_bucket): Use better integer hashing function.
8108 (xpm_cache_color): Don't possibly over-allocate memory.
8109 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8110 (gif_memory_source):
8111 Use ptrdiff_t, not int or size_t, to record sizes.
8112 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8113 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8114 either works, as we prefer signed integers.
8115 (tiff_read_from_memory, tiff_write_from_memory):
8116 Return tsize_t, not size_t, since that's what the TIFF API wants.
8117 (tiff_read_from_memory): Don't fail simply because the read would
8118 go past EOF; instead, return a short read.
8119 (tiff_load): Omit no-longer-needed casts.
8120 (Fimagemagick_types): Don't assume size fits into 'int'.
8122 Improve hashing quality when configured --with-wide-int.
8123 * fns.c (hash_string): New function, taken from sxhash_string.
8124 Do not discard information about ASCII character case; this
8125 discarding is no longer needed.
8126 (sxhash-string): Use it. Change sig to match it. Caller changed.
8127 * lisp.h: Declare it.
8128 * lread.c (hash_string): Remove, since we now use fns.c's version.
8129 The fns.c version returns a wider integer if --with-wide-int is
8130 specified, so this should help the quality of the hashing a bit.
8132 * emacs.c: Integer overflow minor fix.
8133 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8134 Define only if GNU_LINUX.
8135 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8137 * dispnew.c: Integer signedness and overflow fixes.
8138 Remove unnecessary forward decls, that were a maintenance hassle.
8139 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8141 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8142 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8143 (prepare_desired_row, line_draw_cost):
8144 Use int, not unsigned, where either works.
8145 (save_current_matrix, restore_current_matrix):
8146 Use ptrdiff_t, not size_t, where either works.
8147 (init_display): Check for overflow more accurately, and without
8148 relying on undefined behavior.
8150 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8151 Remove, replacing with the new symbols in lisp.h. All uses changed.
8152 * fileio.c (make_temp_name):
8153 * filelock.c (lock_file_1, lock_file):
8154 * xdisp.c (message_dolog):
8155 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8156 Use pMd etc. instead.
8157 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8158 replacing the pWIDE etc. symbols removed from editfns.c.
8160 * keyboard.h (num_input_events): Now uintmax_t.
8161 This is (very slightly) less likely to mess up due to wraparound.
8164 * buffer.c: Integer signedness fixes.
8165 (alloc_buffer_text, enlarge_buffer_text):
8166 Use ptrdiff_t rather than size_t when either will do, as we prefer
8169 * alloc.c: Integer signedness and overflow fixes.
8170 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8171 (__malloc_size_t): Default to size_t, not to int.
8172 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8173 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8174 Prefer ptrdiff_t to size_t when either would do, as we prefer
8176 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8177 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8178 Now const. Initialize with values that are in range even if char
8180 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8181 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8182 These functions do the right thing with sizes > 2**32.
8183 (check_depth): Now ptrdiff_t, not int.
8184 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8185 Adjust to new way of storing sizes. Check for size overflow bugs
8187 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8188 slightly wrong anyway, as it missed one instance of
8189 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8190 (refill_memory_reserve): Omit needless cast to size_t.
8191 (mark_object_loop_halt): Mark as externally visible.
8193 * xselect.c: Integer signedness and overflow fixes.
8194 (Fx_register_dnd_atom, x_handle_dnd_message):
8195 Use ptrdiff_t, not size_t, since we prefer signed.
8196 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8197 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8198 x_dnd_atoms_size and x_dnd_atoms_length.
8200 * doprnt.c: Prefer signed to unsigned when either works.
8202 * doprnt.c (doprnt):
8204 * xdisp.c (vmessage):
8205 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8206 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8207 prefer signed arithmetic to avoid comparison confusion.
8208 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8209 but is a bit tricky.
8211 Assume freestanding C89 headers, string.h, stdlib.h.
8212 * data.c, doprnt.c, floatfns.c, print.c:
8213 Include float.h unconditionally.
8214 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8215 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8216 * regex.c: Likewise for stddef.h, string.h.
8217 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8218 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8219 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8220 (STDC_HEADERS): Remove obsolete defines.
8221 * sysdep.c: Include limits.h unconditionally.
8223 Assume support for memcmp, memcpy, memmove, memset.
8224 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8225 * regex.c (memcmp, memcpy):
8226 Remove; we assume C89 now.
8228 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8229 (__malloc_safe_bcopy): Remove; no longer needed.
8231 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8232 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8233 well either way, and we prefer signed to unsigned.
8235 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8237 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8238 closes the connection while we're reading (bug#9182).
8240 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8242 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8243 are specified (Bug#9168).
8245 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8247 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8248 Found by GCC static checking and --with-wide-int on a 32-bit host.
8250 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8252 * xdisp.c (compute_display_string_pos): Fix logic of caching
8253 previous display string position. Initialize cached_prev_pos to
8254 -1. Fixes slow-down at the beginning of a buffer.
8256 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8258 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8259 for attrs[LFACE_FONTSET_INDEX].
8261 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8263 * xml.c (parse_region): Remove unused local
8264 that was recently introduced.
8266 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8268 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8269 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8271 * xdisp.c (move_it_in_display_line_to): Record the best matching
8272 position for TO_CHARPOS while scanning the line, and restore it on
8273 exit if none of the characters scanned was an exact match.
8274 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8275 when exact match is impossible due to invisible text, and the
8276 lines are truncated.
8278 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8280 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8283 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8285 Fix a significant slow-down of cursor motion with C-n, C-p,
8286 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8287 auto-repeat under bidi redisplay in fontified buffers.
8288 * xdisp.c (compute_stop_pos_backwards): New function.
8289 (next_element_from_buffer): Call compute_stop_pos_backwards to
8290 find a suitable prev_stop when we find ourselves before
8292 (reseat): Don't look for prev_stop, as that could mean a very long
8294 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8295 <cached_disp_overlay_modiff>: Cache for last found display string
8297 (compute_display_string_pos): Return the cached position if asked
8298 about the same buffer in the same area of character positions, and
8299 the buffer wasn't changed since the time the display string
8300 position was cached.
8302 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8304 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8305 is an integer, which is important for empty lines. (Bug#9149)
8307 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8309 * frame.c (Fmodify_frame_parameters): In tty case, update the
8310 default face if necessary (Bug#4238).
8312 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8314 * editfns.c (Fstring_to_char): No need to explain what a character
8315 is in the docstring (Bug#6576).
8317 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8319 * xml.c (parse_region): Make sure we always return a tree.
8321 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8323 * xml.c (parse_region): If a document contains only comments,
8326 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8328 * xml.c (make_dom): Return comments, too.
8330 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8333 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8334 and the surrounding thread.
8335 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8336 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8337 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8339 * s/openbsd.h (BROKEN_SIGIO): Define.
8340 * unexelf.c (unexec) [__OpenBSD__]:
8341 Don't update the .mdebug section of the Alpha COFF symbol table.
8343 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8345 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8348 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8350 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8351 This fixes some race conditions on the permissions of any newly
8354 * alloc.c (valid_pointer_p): Use pipe, not open.
8355 This fixes some permissions issues when debugging.
8357 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8358 If fchown fails to set both uid and gid, try to set just gid,
8359 as that is sometimes allowed. Adjust the file's mode to eliminate
8360 setuid or setgid bits that are inappropriate if fchown fails.
8362 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8364 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8365 to compare Lisp_Objects.
8366 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8367 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8368 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8370 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8372 * lread.c (read_integer): Unread even EOF character.
8373 (read1): Likewise. Properly record start position of symbol.
8375 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8376 symbol character follows.
8378 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8380 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8381 This works around a problem with the previous change to Fcopy_file.
8382 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8383 and without this change, GCC might complain about discarding
8384 fchown's return value.
8386 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8388 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8390 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8392 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8394 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8396 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8397 it's used from the C level.
8399 * process.c: Use the same condition for POLL_FOR_INPUT in both
8400 keyboard.c and process.c (bug#1858).
8402 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8404 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8405 (Fgnutls_boot): Use it.
8407 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8409 * doc.c (Fsubstitute_command_keys): Revert last change.
8411 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8413 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8414 quotes the next character, and doesn't affect other longer
8415 sequences (bug#8935).
8417 * lread.c (syms_of_lread): Clarify that is isn't only
8418 `eval-buffer' and `eval-defun' that's affected by
8419 `lexical-binding' (bug#8460).
8421 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8423 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8424 bidi redisplay when a line includes both an image and is truncated.
8426 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8428 Fix minor problems found by static checking.
8429 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8430 (elsz): Now a signed constant, not a size_t var. We prefer signed
8431 types to unsigned, to avoid integer comparison confusion. Without
8432 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8433 "cannot optimize loop, the loop counter may overflow", a symptom
8435 * indent.c (Fvertical_motion): Mark locals as initialized.
8436 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8438 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8440 * search.c (Fre_search_backward): Mention `case-fold-search' in
8441 all the re_search_* functions (bug#8138).
8443 * keyboard.c (Fopen_dribble_file): Document when the file is
8446 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8448 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8451 Support bidi reordering of display and overlay strings.
8452 * xdisp.c (compute_display_string_pos)
8453 (compute_display_string_end): Accept additional argument STRING.
8454 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8455 (reseat_to_string): Initialize bidi_it->string.s and
8456 bidi_it->string.schars.
8457 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8458 NULL (avoids a crash in bidi_paragraph_init).
8459 Initialize itb.string.lstring.
8460 (init_iterator): Call bidi_init_it only of a valid
8461 buffer position was specified. Initialize paragraph_embedding to
8463 (reseat_to_string): Initialize the bidi iterator.
8464 (display_string): If we need to ignore text properties of
8465 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8466 original value of -1 will not work with bidi.)
8467 (compute_display_string_pos): First arg is now struct
8468 `text_pos *'; all callers changed. Support display properties on
8470 (compute_display_string_end): Support display properties on Lisp
8472 (init_iterator, reseat_1, reseat_to_string): Initialize the
8473 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8474 when iterating on a string not from display properties).
8475 (compute_display_string_pos, compute_display_string_end):
8476 Fix calculation of the object to scan. Fixes an error when using
8478 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8479 base_level_stop; instead, set base_level_stop to BEGV.
8480 Fixes crashes in vertical-motion.
8481 (next_element_from_buffer): Improve commentary for when
8482 the iterator is before prev_stop.
8483 (init_iterator): Initialize bidi_p from the default value of
8484 bidi-display-reordering, not from buffer-local value. Use the
8485 buffer-local value only if initializing for buffer iteration.
8486 (handle_invisible_prop): Support invisible properties on strings
8487 that are being bidi-reordered.
8488 (set_iterator_to_next): Support bidi reordering of C strings and
8490 (next_element_from_string): Support bidi reordering of Lisp
8492 (handle_stop_backwards): Support Lisp strings as well.
8493 (display_string): Support display of R2L glyph rows.
8494 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8495 (init_iterator): Don't initialize it->bidi_p for strings
8497 (reseat_to_string): Initialize it->bidi_p for strings here.
8498 (next_element_from_string, next_element_from_c_string)
8499 (next_element_from_buffer): Add xassert's for correspondence
8500 between IT's object being iterated and it->bidi_it.string
8502 (face_before_or_after_it_pos): Support bidi iteration.
8503 (next_element_from_c_string): Handle the case of the first string
8504 character that is not the first one in the visual order.
8505 (get_visually_first_element): New function, refactored from common
8506 parts of next_element_from_buffer, next_element_from_string, and
8507 next_element_from_c_string.
8508 (tool_bar_lines_needed, redisplay_tool_bar)
8509 (display_menu_bar): Force left-to-right direction. Add a FIXME
8510 comment for making that be controlled by a user option.
8511 (push_it, pop_it): Save and restore the state of the
8512 bidi iterator. Save and restore the bidi_p flag.
8513 (pop_it): Iterate out of display property for string iteration as
8515 (iterate_out_of_display_property): Support iteration over strings.
8516 (handle_single_display_spec): Set up it->bidi_it for iteration
8517 over a display string, and call bidi_init_it.
8518 (handle_single_display_spec, next_overlay_string)
8519 (get_overlay_strings_1, push_display_prop): Set up the bidi
8520 iterator for displaying display or overlay strings.
8521 (forward_to_next_line_start): Don't use the shortcut if
8523 (back_to_previous_visible_line_start): If handle_display_prop
8524 pushed the iterator stack, restore the internal state of the bidi
8525 iterator by calling bidi_pop_it same number of times.
8526 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8527 and we are bidi-iterating, don't decrement the iterator position;
8528 instead, set the first_elt flag in the bidi iterator, to produce
8530 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8531 (push_display_prop): xassert that we are iterating a buffer.
8532 (push_it, pop_it): Save and restore paragraph_embedding member.
8533 (handle_single_display_spec, next_overlay_string)
8534 (get_overlay_strings_1, reseat_1, reseat_to_string)
8535 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8536 correctly. Don't assume unibyte strings are not bidi-reordered.
8537 (compute_display_string_pos)
8538 (compute_display_string_end): Fix handling the case of C string.
8539 (push_it, pop_it): Save and restore from_disp_prop_p.
8540 (handle_single_display_spec, push_display_prop): Set the
8541 from_disp_prop_p flag.
8542 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8543 (pop_it): Call iterate_out_of_display_property only if we are
8544 popping after iteration over a string that came from a display
8545 property. Fix a typo in popping stretch info. Add an assertion
8546 for verifying that the iterator position is in sync with the bidi
8548 (handle_single_display_spec, get_overlay_strings_1)
8549 (push_display_prop): Fix initialization of paragraph direction for
8550 string when that of the parent object is not yet determined.
8551 (reseat_1): Call bidi_init_it to resync the bidi
8552 iterator with IT's position. (Bug#7616)
8553 (find_row_edges): If ROW->start.pos gives position
8554 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8555 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8556 Reset the from_disp_prop_p flag.
8557 (SAVE_IT, RESTORE_IT): New macros.
8558 (pos_visible_p, face_before_or_after_it_pos)
8559 (back_to_previous_visible_line_start)
8560 (move_it_in_display_line_to, move_it_in_display_line)
8561 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8562 (try_scrolling, redisplay_window, display_line): Use them when
8563 saving a temporary copy of the iterator and restoring it back.
8564 (back_to_previous_visible_line_start, reseat_1)
8565 (init_iterator): Empty the bidi cache "stack".
8566 (move_it_in_display_line_to): If iterator ended up at
8567 EOL, but we never saw any buffer positions smaller than
8568 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8569 motion in bidi-reordered lines.
8570 (move_it_in_display_line_to): Record prev_method and prev_pos
8571 immediately before the call to set_iterator_to_next. Fixes cursor
8572 motion in bidi-reordered lines with stretch glyphs and strings
8573 displayed in margins. (Bug#8133) (Bug#8867)
8574 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8576 (pos_visible_p): Support positions in bidi-reordered lines.
8577 Save and restore bidi cache.
8579 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8580 (bidi_paragraph_info): Delete unused struct.
8581 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8582 (bidi_cache_start): New variable.
8583 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8585 (bidi_cache_fetch_state, bidi_cache_search)
8586 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8587 (bidi_cache_find, bidi_peek_at_next_level)
8588 (bidi_level_of_next_char, bidi_find_other_level_edge)
8589 (bidi_move_to_visually_next): Compare cache index with
8590 bidi_cache_start rather than with zero.
8591 (bidi_fetch_char): Accept new argument STRING; all callers
8592 changed. Support iteration over a string. Support strings with
8593 display properties. Support unibyte strings. Fix the type of
8594 `len' according to what STRING_CHAR_AND_LENGTH expects.
8595 (bidi_paragraph_init, bidi_resolve_explicit_1)
8596 (bidi_resolve_explicit, bidi_resolve_weak)
8597 (bidi_level_of_next_char, bidi_move_to_visually_next):
8598 Support iteration over a string.
8599 (bidi_set_sor_type, bidi_resolve_explicit_1)
8600 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8601 can now be zero (for strings); special values 0 and -1 were
8602 changed to -1 and -2, respectively.
8603 (bidi_char_at_pos): New function.
8604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8605 Call it instead of FETCH_MULTIBYTE_CHAR.
8606 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8607 initialized to valid values.
8608 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8610 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8611 the test for valid cached positions. Fix the logic for looking up
8612 the sentinel state in the cache. GCPRO the Lisp string we are
8614 (bidi_push_it, bidi_pop_it): New functions.
8615 (bidi_initialize): Initialize the bidi cache start stack pointer.
8616 (bidi_cache_ensure_space): New function, refactored from part of
8617 bidi_cache_iterator_state. Don't assume the required size is just
8618 one BIDI_CACHE_CHUNK away.
8619 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8620 (bidi_count_bytes, bidi_char_at_pos): New functions.
8621 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8622 always valid if bidi_cache_idx is valid.
8623 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8624 is valid if it's going to be used.
8625 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8626 (bidi_cache_fetch_state, bidi_cache_search)
8627 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8628 (bidi_cache_iterator_state, bidi_cache_find)
8629 (bidi_find_other_level_edge, bidi_cache_start_stack):
8630 All variables related to cache indices are now EMACS_INT.
8632 * dispextern.h (struct bidi_string_data): New structure.
8633 (struct bidi_it): New member `string'. Make flag members be 1-bit
8634 fields, and put them last in the struct.
8635 (compute_display_string_pos, compute_display_string_end):
8637 (bidi_push_it, bidi_pop_it): Add prototypes.
8638 (struct iterator_stack_entry): New members bidi_p,
8639 paragraph_embedding, and from_disp_prop_p.
8640 (struct it): Member bidi_p is now a bit field 1 bit wide.
8641 (bidi_shelve_cache, bidi_unshelve_cache):
8644 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8645 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8646 and vector-like objects.
8648 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8649 cache around display iteration.
8651 * window.c (Fwindow_end, window_scroll_pixel_based)
8652 (displayed_window_lines, Frecenter): Save and restore the bidi
8653 cache around display iteration.
8655 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8657 * editfns.c (Fdelete_region): Clarify the use of the named
8658 parameters (bug#6788).
8660 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8662 * indent.c (Fvertical_motion): Set and restore w->pointm when
8663 saving and restoring the window's buffer (Bug#9006).
8665 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8667 * editfns.c (Fstring_to_char): Clarify just what is returned
8668 (bug#6576). Text by Eli Zaretskii.
8670 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8672 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8674 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8676 * buffer.c (mmap_find): Fix a typo.
8678 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8680 Fix execution of x selection hooks.
8681 * xselect.c (Qx_lost_selection_functions)
8682 (Qx_sent_selection_functions): New vars.
8683 (syms_of_xselect): DEFSYM them.
8684 (x_handle_selection_request): Pass Qx_sent_selection_functions
8685 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8686 (x_handle_selection_clear,x_clear_frame_selections):
8687 Pass Qx_lost_selection_functions rather than
8688 Vx_lost_selection_functions to Frun_hook_with_args.
8690 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8692 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8693 The old code sometimes used this field without initializing it.
8695 * alloc.c (gc_sweep): Don't read past end of array.
8696 In theory, the old code could also have corrupted Emacs internals,
8697 though it'd be very unlikely.
8699 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8701 * character.c (Fcharacterp): Don't advertise optional ignored
8702 argument. (Bug#4026)
8704 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8706 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8709 * window.c (Fset_window_start): Doc fix (bug#4199).
8710 (Fset_window_hscroll): Ditto.
8712 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8714 Fix minor new problems caught by GCC 4.6.1.
8715 * term.c (init_tty): Remove unused local.
8716 * xsettings.c (store_monospaced_changed): Define this function only
8717 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8720 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8722 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8724 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8726 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8727 are the mini-buffer and the echo area (bug#3320).
8729 * term.c (init_tty): Remove support for supdup, c10 and perq
8730 terminals, which are no longer supported (bug#1482).
8732 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8734 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8736 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8738 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8739 for non-popups (Bug#3642).
8741 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8743 * alloc.c (reset_malloc_hooks): Protoize.
8744 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8745 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8746 * cm.c (losecursor): Likewise.
8747 * data.c (fmod): Likewise.
8748 * dispnew.c (swap_glyphs_in_rows): Likewise.
8749 * emacs.c (memory_warning_signal): Likewise.
8750 * floatfns.c (float_error): Likewise.
8751 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8752 (otf_open, font_otf_capability, generate_otf_features)
8753 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8755 * image.c (pbm_read_file): Likewise.
8756 * indent.c (string_display_width): Likewise.
8757 * intervals.c (check_for_interval, search_for_interval)
8758 (inc_interval_count, count_intervals, root_interval)
8759 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8760 * lread.c (defalias): Likewise.
8761 * ralloc.c (r_alloc_check): Likewise.
8762 * regex.c (set_image_of_range_1, set_image_of_range)
8763 (regex_grow_registers): Likewise.
8764 * sysdep.c (strerror): Likewise.
8765 * termcap.c (valid_filename_p, tprint, main): Likewise.
8766 * tparam.c (main): Likewise.
8767 * unexhp9k800.c (run_time_remap, save_data_space)
8768 (update_file_ptrs, read_header, write_header, calculate_checksum)
8769 (copy_file, copy_rest, display_header): Likewise.
8770 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8772 * xdisp.c (check_it): Likewise.
8773 * xfaces.c (register_color, unregister_color, unregister_colors):
8775 * xfns.c (print_fontset_result): Likewise.
8776 * xrdb.c (member, fatal, main): Likewise.
8778 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8780 Fix minor problems found by static checking (Bug#9031).
8781 * chartab.c (char_table_set_range, map_sub_char_table):
8782 Remove unused locals.
8783 (uniprop_table): Now static.
8784 * composite.c (_work_char): Remove unused static var.
8786 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8788 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8790 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8792 * gtkutil.c (qttip_cb): Remove code without function.
8794 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8796 * w32.c (pthread_sigmask): New stub.
8798 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8800 Use pthread_sigmask, not sigprocmask (Bug#9010).
8801 sigprocmask is portable only for single-threaded applications, and
8802 Emacs can be multi-threaded when it uses GTK.
8803 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8805 * callproc.c (Fcall_process):
8806 * process.c (create_process):
8807 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8808 Use pthread_sigmask, not sigprocmask.
8810 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8812 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8813 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8816 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8818 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8819 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8820 (xg_hide_tooltip): Fix comment.
8822 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8823 in registerServicesMenuSendTypes.
8824 (validRequestorForSendType): Don't check ns_return_types.
8826 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8829 2011-07-08 Jason Rumney <jasonr@gnu.org>
8831 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8832 SH_SHOW for hidden windows (Bug#5482).
8834 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8835 frame struct members of non-existent frames (Bug#6284).
8837 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8839 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8840 variable firstTime not needed on OSX >= 10.6.
8841 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8842 >= 10.5. Use setKnobProportion, setDoubleValue.
8844 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8845 (MAC_OS_X_VERSION_10_5): Define if not defined.
8846 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8847 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8848 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8850 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8851 cString and lossyCString on OSX >= 10.4.
8853 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8854 sizeToFit on OSX >= 10.2.
8856 * nsimage.m (allocInitFromFile): Don't use deprecated method
8857 bestRepresentationForDevice on OSX >= 10.6.
8859 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8862 * emacs.c: Declare unexec_init_emacs_zone.
8864 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8866 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8868 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8869 on svcsMenu (Bug#8842).
8871 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8873 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8875 * nsterm.m (QUTF8_STRING): Declare.
8876 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8877 (validRequestorForSendType): Return type is (id).
8878 Change indexOfObjectIdenticalTo to indexOfObject.
8879 Check if we have local selection before returning self (Bug#8842).
8880 (writeSelectionToPasteboard): Put local selection into paste board
8881 if we have a local selection (Bug#8842).
8882 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8884 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8885 (ns_get_local_selection): Declare.
8887 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8889 * keymap.c (describe_map_tree): Don't insert a double newline at
8890 the end of the buffer (bug#1169) and return whether we inserted
8893 * callint.c (Fcall_interactively): Change "reading args" to
8894 "providing args" to try to clarify what it does (bug#1010).
8896 2011-07-07 Kenichi Handa <handa@m17n.org>
8898 * composite.c (composition_compute_stop_pos): Ignore a static
8899 composition starting before CHARPOS (Bug#8915).
8901 * xdisp.c (handle_composition_prop): Likewise.
8903 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8905 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8908 2011-07-07 Kenichi Handa <handa@m17n.org>
8910 * character.h (unicode_category_t): New enum type.
8912 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8913 (Qchar_code_property_table): New variable.
8914 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8915 (UNIPROP_COMPRESSED_FORM_P): New macros.
8916 (char_table_ascii): Uncompress the compressed values.
8917 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8918 Uncompress the compressed values.
8919 (sub_char_table_ref_and_range): Likewise.
8920 (char_table_ref_and_range): Uncompress the compressed values.
8921 (sub_char_table_set): New arg is_uniprop. Callers changed.
8922 Uncompress the compressed values.
8923 (sub_char_table_set_range): Args changed. Callers changed.
8924 (char_table_set_range): Adjuted for the above change.
8925 (map_sub_char_table): Delete args default_val and parent. Add arg
8926 top. Give decoded values to a Lisp function.
8927 (map_char_table): Adjust for the above change. Give decoded
8928 values to a Lisp function. Gcpro more variables.
8929 (uniprop_table_uncompress)
8930 (uniprop_decode_value_run_length): New functions.
8931 (uniprop_decoder, uniprop_decoder_count): New variables.
8932 (uniprop_get_decoder, uniprop_encode_value_character)
8933 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8935 (uniprop_encoder, uniprop_encoder_count): New variables.
8936 (uniprop_get_encoder, uniprop_table)
8937 (Funicode_property_table_internal, Fget_unicode_property_internal)
8938 (Fput_unicode_property_internal): New functions.
8939 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8940 Sunicode_property_table_internal, Sget_unicode_property_internal,
8941 and Sput_unicode_property_internal. Defvar_lisp
8942 char-code-property-alist.
8944 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8945 Vunicode_category_table.
8947 * font.c (font_range): Adjust for the change of
8948 Vunicode_category_table.
8950 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8952 * m/iris4d.h: Remove file, move contents ...
8953 * s/irix6-5.h: ... here.
8955 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8957 Remove unportable assumption about struct layout (Bug#8884).
8958 * alloc.c (mark_buffer):
8959 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8960 (clone_per_buffer_values): Don't assume that
8961 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8962 This isn't true in general, and it's particularly not true
8963 if Emacs is configured with --with-wide-int.
8964 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8965 New macros, used in the buffer.c change.
8967 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8969 * xsettings.c: Use both GConf and GSettings if both are available.
8970 (store_config_changed_event): Add comment.
8971 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8972 (store_tool_bar_style_changed): New functions.
8973 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8974 (struct xsettings): Move font inside HAVE_XFT.
8975 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8976 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8977 Move inside HAVE_XFT.
8978 (something_changed_gsettingsCB): Rename from something_changedCB.
8979 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8981 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8982 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8983 (something_changed_gconfCB): Rename from something_changedCB.
8984 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8985 (parse_settings): Move check for font inside HAVE_XFT.
8986 (read_settings, apply_xft_settings): Add comment.
8987 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8988 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8989 call store_font_name_changed.
8990 (xft_settings_event): Add comment.
8991 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8992 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8993 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8994 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8995 (xsettings_initialize): Call init_gsettings last.
8996 (xsettings_get_system_font, xsettings_get_system_normal_font):
8999 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9001 Random fixes. E.g., (random) never returned negative values.
9002 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9003 subseconds part to the entropy, as that's a bit more random.
9004 Prefer signed to unsigned, since the signedness doesn't matter and
9005 in general we prefer signed. When given a limit, use a
9006 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9007 latter isn't right if USE_2_TAGS_FOR_INTS.
9008 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9009 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9011 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9013 * textprop.c (text_property_stickiness):
9014 Obey Vtext_property_default_nonsticky.
9015 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9016 * w32fns.c (syms_of_w32fns):
9017 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9019 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9021 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9022 This is more efficient than Ffile_directory_p and avoids a minor race.
9024 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9026 * buffer.c (Foverlay_put): Say what the return value is
9029 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9030 is a directory before asking whether to use the file name
9032 (barf_or_query_if_file_exists): Make the "File is a directory"
9033 error be more correct.
9035 * fns.c (Frequire): Remove the mention of the .gz files, since
9036 that's installation-specific, but keep the mention of
9037 `get-load-suffixes'.
9039 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9041 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9042 Report string overflow if the output is too long.
9044 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9046 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9047 (syms_of_gnutls): Remove duplicate DEFSYM for
9048 Qgnutls_bootprop_verify_hostname_error, an error for
9049 Qgnutls_bootprop_verify_error (which is no longer used).
9051 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9052 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9053 Also (re)move comments that are misplaced or no longer relevant.
9055 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9057 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9059 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9061 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9062 and background color parameters if they have been changed.
9064 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9066 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9068 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9070 * xsettings.c (SYSTEM_FONT): Define only when used.
9071 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9073 * keymap.c (access_keymap_1): Now static.
9075 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9077 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9078 leave any prefix arg for the up event (Bug#1586).
9080 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9082 * lread.c (syms_of_lread): Mention single symbols defined by
9083 `defvar' or `defconst' (bug#7154).
9085 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9086 (Frequire): Mention get-load-suffixes.
9088 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9090 * window.h (window): Remove clone_number slot.
9091 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9093 (make_parent_window, make_window, saved_window)
9094 (Fset_window_configuration, save_window_save): Don't deal with
9096 * buffer.c (Qclone_number): Remove declaration.
9097 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9099 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9101 Add multiple inheritance to keymaps.
9102 * keymap.c (Fmake_composed_keymap): New function.
9103 (Fset_keymap_parent): Simplify.
9104 (fix_submap_inheritance): Remove.
9105 (access_keymap_1): New function extracted from access_keymap to handle
9106 embedded parents and handle lists of maps.
9107 (access_keymap): Use it.
9108 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9109 (Fcopy_keymap): Handle embedded parents.
9110 (Fcommand_remapping, define_as_prefix): Simplify.
9111 (Fkey_binding): Simplify.
9112 (syms_of_keymap): Move minibuffer-local-completion-map,
9113 minibuffer-local-filename-completion-map,
9114 minibuffer-local-must-match-map, and
9115 minibuffer-local-filename-must-match-map to Elisp.
9116 (syms_of_keymap): Defsubr make-composed-keymap.
9117 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9118 (parse_menu_item): Trivial simplification.
9120 2011-07-01 Glenn Morris <rgm@gnu.org>
9122 * Makefile.in (SETTINGS_LIBS): Fix typo.
9124 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9126 * coding.c (Fencode_coding_string): Record the last coding system
9127 used, as the function doc string says (bug#8738).
9129 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9131 * xsettings.c (store_monospaced_changed): Take new font as arg and
9132 check for change against current_mono_font.
9133 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9134 (emacs_settings_constructor, emacs_settings_get_property)
9135 (emacs_settings_set_property, emacs_settings_class_init)
9136 (emacs_settings_init, gsettings_obj): Remove.
9137 (something_changedCB): New function for HAVE_GSETTINGS.
9138 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9139 with value as argument.
9140 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9141 g_settings_new (Bug#8967). Do not create gsettings_obj.
9142 Remove calls to g_settings_bind. Connect something_changedCB to
9145 * xgselect.c: Add defined (HAVE_GSETTINGS).
9146 (xgselect_initialize): Ditto.
9148 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9149 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9152 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9154 * eval.c (struct backtrace): Simplify and port the data structure.
9155 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9156 signed bit field, as this assumption is not portable and it makes
9157 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9158 "char debug_on_exit : 1" as this is not portable either; instead,
9159 use the portable "unsigned int debug_on_exit : 1". Remove unused
9160 member evalargs. Remove obsolete comments about cc bombing out.
9162 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9164 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9165 Let HAVE_GSETTINGS override HAVE_GCONF.
9166 (store_monospaced_changed): New function.
9167 (EMACS_SETTINGS): A new type derived from GObject to handle
9168 GSettings notifications.
9169 (emacs_settings_constructor, emacs_settings_get_property)
9170 (emacs_settings_set_property, emacs_settings_class_init):
9172 (gsettings_client, gsettings_obj): New variables.
9173 (GSETTINGS_SCHEMA): New define.
9174 (something_changedCB): Call store_monospaced_changed.
9175 (init_gsettings): New function.
9176 (xsettings_initialize): Call init_gsettings.
9177 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9180 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9183 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9185 * window.c (resize_root_window, grow_mini_window)
9186 (shrink_mini_window): Rename Qresize_root_window to
9187 Qwindow_resize_root_window and Qresize_root_window_vertically to
9188 Qwindow_resize_root_window_vertically.
9190 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9192 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9194 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9196 * makefile.w32-in: Redesign dependencies so they reflect more
9197 clearly which files are directly included by each source file,
9198 and not through other includes.
9200 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9202 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9203 (sort_overlays, overlay_strings): When an overlay's clone number
9204 matches the window's clone number process the overlay even if
9205 the overlay's window property doesn't match the current window.
9207 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9208 (Fwindow_hchild): Rename to Fwindow_left_child.
9209 (Fwindow_next): Rename to Fwindow_next_sibling.
9210 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9211 (resize_window_check): Rename to window_resize_check.
9212 (resize_window_apply): Rename to window_resize_apply.
9213 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9214 (Fdelete_other_windows_internal, resize_frame_windows)
9215 (Fsplit_window_internal, Fdelete_window_internal)
9216 (grow_mini_window, shrink_mini_window)
9217 (Fresize_mini_window_internal): Fix callers accordingly.
9219 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9221 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9222 (emacs_fixed_set_min_size): Remove.
9223 (emacs_fixed_new): Take frame as argument.
9225 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9226 (_EmacsFixedPrivate): Remove minwidth/height.
9227 Add struct frame *f.
9228 (emacs_fixed_init): Initialize priv->f.
9229 (get_parent_class, emacs_fixed_set_min_size): Remove.
9230 (emacs_fixed_new): Set priv->f to argument.
9231 (emacs_fixed_get_preferred_width)
9232 (emacs_fixed_get_preferred_height): Use min_width/height from
9233 frames size_hint to set minimum and natural (Bug#8919).
9234 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9235 and use min_width/height from frames size_hint to set
9236 min_width/height (Bug#8919).
9238 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9239 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9242 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9244 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9245 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9248 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9250 * process.c (wait_reading_process_output): Bypass select if
9251 waiting for a cell while ignoring keyboard input, and input is
9252 pending. Suggested by Jan Djärv (Bug#8869).
9254 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9256 Use gnulib's dup2 module instead of rolling our own.
9257 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9259 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9261 * dispnew.c (scrolling_window): Before scrolling, turn off a
9262 mouse-highlight in the window being scrolled.
9264 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9266 Move DEFSYM to lisp.h and use everywhere.
9268 * character.h (DEFSYM): Move declaration...
9269 * lisp.h (DEFSYM): ...here.
9275 * w32select.c: Don't include character.h.
9277 * alloc.c (syms_of_alloc):
9278 * buffer.c (syms_of_buffer):
9279 * bytecode.c (syms_of_bytecode):
9280 * callint.c (syms_of_callint):
9281 * casefiddle.c (syms_of_casefiddle):
9282 * casetab.c (init_casetab_once):
9283 * category.c (init_category_once, syms_of_category):
9284 * ccl.c (syms_of_ccl):
9285 * cmds.c (syms_of_cmds):
9286 * composite.c (syms_of_composite):
9287 * dbusbind.c (syms_of_dbusbind):
9288 * dired.c (syms_of_dired):
9289 * dispnew.c (syms_of_display):
9290 * doc.c (syms_of_doc):
9291 * editfns.c (syms_of_editfns):
9292 * emacs.c (syms_of_emacs):
9293 * eval.c (syms_of_eval):
9294 * fileio.c (syms_of_fileio):
9295 * fns.c (syms_of_fns):
9296 * frame.c (syms_of_frame):
9297 * fringe.c (syms_of_fringe):
9298 * insdel.c (syms_of_insdel):
9299 * keymap.c (syms_of_keymap):
9300 * lread.c (init_obarray, syms_of_lread):
9301 * macros.c (syms_of_macros):
9302 * msdos.c (syms_of_msdos):
9303 * print.c (syms_of_print):
9304 * process.c (syms_of_process):
9305 * search.c (syms_of_search):
9306 * sound.c (syms_of_sound):
9307 * syntax.c (init_syntax_once, syms_of_syntax):
9308 * terminal.c (syms_of_terminal):
9309 * textprop.c (syms_of_textprop):
9310 * undo.c (syms_of_undo):
9311 * w32.c (globals_of_w32):
9312 * window.c (syms_of_window):
9313 * xdisp.c (syms_of_xdisp):
9314 * xfaces.c (syms_of_xfaces):
9315 * xfns.c (syms_of_xfns):
9316 * xmenu.c (syms_of_xmenu):
9317 * xsettings.c (syms_of_xsettings):
9318 * xterm.c (syms_of_xterm): Use DEFSYM.
9320 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9322 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9324 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9326 Integer and buffer overflow fixes (Bug#8873).
9328 * print.c (printchar, strout): Check for string overflow.
9329 (PRINTPREPARE, printchar, strout):
9330 Don't set size unless allocation succeeds.
9332 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9333 for sizes. Check for string overflow more accurately.
9334 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9336 * macros.c: Integer and buffer overflow fixes.
9337 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9338 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9339 Use ptrdiff_t, not int, for sizes.
9340 Don't increment bufsize until after realloc succeeds.
9341 Check for size-calculation overflow.
9342 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9344 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9346 * lread.c: Integer overflow fixes.
9347 (read_integer): Radix is now EMACS_INT, not int,
9348 to improve quality of diagnostics for out-of-range radices.
9349 Calculate buffer size correctly for out-of-range radices.
9350 (read1): Check for integer overflow in radices, and in
9351 read-circle numbers.
9352 (read_escape): Avoid int overflow.
9353 (Fload, openp, read_buffer_size, read1)
9354 (substitute_object_recurse, read_vector, read_list, map_obarray):
9355 Use ptrdiff_t, not int, for sizes.
9356 (read1): Use EMACS_INT, not int, for sizes.
9357 Check for size overflow.
9359 * image.c (cache_image): Check for size arithmetic overflow.
9361 * lread.c: Integer overflow issues.
9362 (saved_doc_string_size, saved_doc_string_length)
9363 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9364 Now ptrdiff_t, not int.
9365 (read1): Don't assume doc string length fits in int. Check for
9366 out-of-range doc string lengths.
9367 (read_list): Don't assume file position fits in int.
9368 (read_escape): Check for hex character overflow.
9370 2011-06-22 Leo Liu <sdl.web@gmail.com>
9372 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9373 Move to minibuffer.el.
9375 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9377 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9378 The following patches are for when GLYPH_DEBUG && !XASSERT.
9379 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9380 * dispnew.c (flush_stdout):
9381 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9382 Mark as externally visible.
9383 * dispnew.c (check_window_matrix_pointers): Now static.
9384 * dispnew.c (window_to_frame_vpos):
9385 * xfns.c (unwind_create_frame):
9386 * xterm.c (x_check_font): Remove unused local.
9387 * scroll.c (CHECK_BOUNDS):
9388 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9389 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9390 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9391 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9392 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9394 (debug_method_add): Use va_list and vsprintf rather than relying
9395 on undefined behavior with wrong number of arguments.
9396 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9397 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9398 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9399 since we're not interested in debugging glyphs with old libraries.
9400 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9401 GCC 4.6.0's static checking.
9403 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9405 Integer overflow and signedness fixes (Bug#8873).
9406 A few related buffer overrun fixes, too.
9408 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9410 * dispextern.h (struct face.stipple):
9411 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9412 (x_bitmap_mask, x_allocate_bitmap_record)
9413 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9414 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9415 (x_create_bitmap_from_xpm_data):
9416 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9417 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9419 * xfaces.c (load_pixmap):
9420 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9421 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9422 (.bitmaps_last, struct x_output.icon_bitmap):
9423 Use ptrdiff_t, not int, for bitmap indexes.
9424 (x_allocate_bitmap_record): Check for size overflow.
9425 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9427 Use ptrdiff_t, not int, for overlay counts.
9428 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9429 * editfns.c (overlays_around, get_pos_property):
9430 * textprop.c (get_char_property_and_overlay):
9431 * xdisp.c (next_overlay_change, note_mouse_highlight):
9432 * xfaces.c (face_at_buffer_position):
9433 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9434 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9435 (Fnext_overlay_change, Fprevious_overlay_change)
9436 (mouse_face_overlay_overlaps, Foverlays_in):
9437 Use ptrdiff_t, not int, for sizes.
9438 (overlays_at, overlays_in): Check for size-calculation overflow.
9440 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9442 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9443 (x_session_initialize): Do not assume string length fits in int.
9445 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9446 This is unlikely, but can occur if DPI is outlandish.
9448 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9449 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9451 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9452 * xrdb.c (magic_file_p, search_magic_path):
9453 Omit last arg SUFFIX; it was always 0. All callers changed.
9454 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9456 * xfont.c (xfont_match): Avoid need for strlen.
9458 * xfns.c: Don't assume strlen fits in int.
9459 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9461 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9462 not unsigned long, as we prefer signed integers. All callers changed.
9463 Detect integer overflow in repeat count.
9464 (message_dolog): Don't assume print length fits in 39 bytes.
9465 (display_mode_element): Don't assume strlen fits in int.
9467 * termcap.c: Don't assume sizes fit in int and never overflow.
9468 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9469 (gobble_line): Check for size-calculation overflow.
9471 * minibuf.c (Fread_buffer):
9472 * lread.c (intern, intern_c_string):
9473 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9474 Don't assume string length fits in int.
9476 * keyboard.c (parse_tool_bar_item):
9477 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9479 * font.c: Don't assume string length fits in int.
9480 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9481 Use ptrdiff_t, not int.
9482 (font_intern_prop): Don't assume string length fits in int.
9483 Don't assume integer property fits in fixnum.
9484 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9486 * filelock.c: Fix some buffer overrun and integer overflow issues.
9487 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9488 Reformulate so as not to need the command string.
9489 Invoke gzip -cd rather than gunzip, as it's more portable.
9490 (lock_info_type, lock_file_1, lock_file):
9491 Don't assume pid_t and time_t fit in unsigned long.
9492 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9493 (current_lock_owner): Prefer signed type for sizes.
9494 Use memcpy, not strncpy, where memcpy is what is really wanted.
9495 Don't assume (via atoi) that time_t and pid_t fit in int.
9496 Check for time_t and/or pid_t out of range, e.g., via a network share.
9497 Don't alloca where an auto var works fine.
9499 * fileio.c: Fix some integer overflow issues.
9500 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9501 Don't assume string length fits in int.
9502 (directory_file_name): Don't assume string length fits in long.
9503 (make_temp_name): Don't assume pid fits in int, or that its print
9504 length is less than 20.
9506 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9508 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9510 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9512 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9513 We prefer signed integers, even for size calculations.
9515 * emacs.c: Don't assume string length fits in 'int'.
9516 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9517 (main): Don't invoke strlen when not needed.
9519 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9520 (XD_DEBUG_MESSAGE): Don't waste a byte.
9522 * callproc.c (getenv_internal_1, getenv_internal)
9524 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9526 * lread.c (invalid_syntax): Omit length argument.
9527 All uses changed. This doesn't fix a bug, but it simplifies the
9528 code away from its former Hollerith-constant appearance, and it's
9529 one less 'int' to worry about when looking at integer-overflow issues.
9530 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9532 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9533 This didn't break anything, but it didn't help either.
9534 It's confusing to put a bogus integer in a place where the actual
9535 value does not matter.
9536 (LIST_END_P): Remove unused macro and its bogus comment.
9537 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9539 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9540 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9542 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9543 We prefer signed types, and the value cannot exceed the EMACS_INT
9544 range anyway (because otherwise the length would not be representable).
9545 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9546 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9547 This avoids a GCC warning when WIDE_EMACS_INT.
9549 * indent.c (sane_tab_width): New function.
9550 (current_column, scan_for_column, Findent_to, position_indentation)
9551 (compute_motion): Use it. This is just for clarity.
9552 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9554 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9556 * lisp.h (lint_assume): New macro.
9557 * composite.c (composition_gstring_put_cache):
9558 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9560 * editfns.c, insdel.c:
9561 Omit unnecessary forward decls, to simplify future changes.
9563 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9565 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9567 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9568 Use much-faster test for byte-length change.
9569 Don't assume string byte-length fits in 'int'.
9570 Check that character arg fits in 'int'.
9571 (mapcar1): Declare byte as byte, for clarity.
9573 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9575 * fns.c (concat): Catch string overflow earlier.
9576 Do not rely on integer wraparound.
9578 * dispextern.h (struct it.overlay_strings_charpos)
9579 (struct it.selective): Now EMACS_INT, not int.
9580 * xdisp.c (forward_to_next_line_start)
9581 (back_to_previous_visible_line_start)
9582 (reseat_at_next_visible_line_start, next_element_from_buffer):
9583 Don't arbitrarily truncate the value of 'selective' to int.
9585 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9587 * composite.c: Don't truncate sizes to 'int'.
9588 (composition_gstring_p, composition_reseat_it)
9589 (composition_adjust_point): Use EMACS_INT, not int.
9590 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9591 not EMACS_UINT, for indexes.
9593 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9595 * buffer.c: Include <verify.h>.
9596 (struct sortvec.priority, struct sortstr.priority):
9597 Now EMACS_INT, not int.
9598 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9599 (struct sortstr.size, record_overlay_string)
9600 (struct sortstrlist.size, struct sortlist.used):
9601 Don't truncate size to int.
9602 (record_overlay_string): Check for size-calculation overflow.
9603 (init_buffer_once): Check at compile-time, not run-time.
9605 2011-06-22 Jim Meyering <meyering@redhat.com>
9607 Don't leak an XBM-image-sized buffer
9608 * image.c (xbm_load): Free the image buffer after using it.
9610 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9613 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9614 that Sun C diagnosed.
9615 * fns.c (secure_hash): Fix pointer signedness issue.
9616 * intervals.c (static_offset_intervals): New function.
9617 (offset_intervals): Use it.
9619 2011-06-21 Leo Liu <sdl.web@gmail.com>
9622 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9625 * fns.c (secure_hash): Rename from crypto_hash_function and change
9626 the first arg to accept symbols.
9627 (Fsecure_hash): New primitive.
9628 (syms_of_fns): New symbols.
9630 2011-06-20 Deniz Dogan <deniz@dogan.se>
9632 * process.c (Fset_process_buffer): Clarify return value in
9635 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9637 * dispnew.c (add_window_display_history): Use BVAR.
9639 * xdisp.c (debug_method_add): Use BVAR.
9640 (check_window_end, dump_glyph_matrix, dump_glyph)
9641 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9643 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9646 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9647 check till after the cache is created in init_frame_faces.
9649 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9651 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9653 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9655 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9656 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9657 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9659 Improve buffer-overflow checking (Bug#8873).
9660 * fileio.c (Finsert_file_contents):
9661 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9662 Remove the old (too-loose) buffer overflow checks.
9663 They weren't needed, since make_gap checks for buffer overflow.
9664 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9665 The old code merely checked for Emacs fixnum overflow, and relied
9666 on undefined (wraparound) behavior. The new code avoids undefined
9667 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9669 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9670 Tune. Don't use wider integers than needed. Don't use alloca.
9671 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9673 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9675 * insdel.c, lisp.h (buffer_overflow): New function.
9676 (insert_from_buffer_1, replace_range, replace_range_2):
9677 * insdel.c (make_gap_larger):
9678 * editfns.c (Finsert_char):
9679 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9681 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9683 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9685 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9687 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9688 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9690 * fileio.c: Don't assume EMACS_INT fits in off_t.
9691 (emacs_lseek): New static function.
9692 (Finsert_file_contents, Fwrite_region): Use it.
9693 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9695 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9697 * fns.c: Don't overflow int when computing a list length.
9698 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9699 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9700 truncation on 64-bit hosts. Check for QUIT every
9701 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9702 faster and is responsive enough.
9703 (Flength): Report an error instead of overflowing an integer.
9704 (Fsafe_length): Return a float if the value is not representable
9705 as a fixnum. This shouldn't happen except in contrived situations.
9706 (Fnthcdr, Fsort): Don't assume list length fits in int.
9707 (Fcopy_sequence): Don't assume vector length fits in int.
9709 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9710 (header_size, word_size): New constants.
9711 (allocate_vectorlike): Don't check size overflow here.
9712 (allocate_vector): Check it here instead, since this is the only
9713 caller of allocate_vectorlike that could cause overflow.
9714 Check that the new vector's length is representable as a fixnum.
9716 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9717 The previous code was bogus. For example, next_almost_prime (32)
9718 returned 39, which is undesirable as it is a multiple of 3; and
9719 next_almost_prime (24) returned 25, which is a multiple of 5 so
9720 why was the code bothering to check for multiples of 7?
9722 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9724 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9726 Variadic C functions now count arguments with ptrdiff_t.
9727 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9728 Back then I didn't know that the Emacs coding style prefers signed int.
9729 Also, in the meantime I found a few more instances where arguments
9730 were being counted with int, which may truncate counts on 64-bit
9731 machines, or EMACS_INT, which may be unnecessarily wide.
9732 * lisp.h (struct Lisp_Subr.function.aMANY)
9733 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9734 Arg counts are now ptrdiff_t, not size_t.
9735 All variadic functions and their callers changed accordingly.
9736 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9737 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9738 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9739 * callint.c (Fcall_interactively): Check arg count for overflow,
9740 to avoid potential buffer overrun. Use signed char, not 'int',
9741 for 'varies' array, so that we needn't bother to check its size
9742 calculation for overflow.
9743 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9744 * eval.c (apply_lambda):
9745 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9746 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9747 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9749 * callint.c (Fcall_interactively): Don't use index var as event count.
9751 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9752 * mem-limits.h (SIZE): Remove; no longer used.
9754 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9756 Remove unnecessary casts.
9757 * xterm.c (x_term_init):
9758 * xfns.c (x_set_border_pixel):
9759 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9760 These aren't needed now that we assume ANSI C.
9762 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9763 It's more likely to cause problems (due to unsigned overflow)
9766 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9768 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9770 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9772 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9774 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9776 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9778 GLYPH_CODE_FACE returns EMACS_INT, not int.
9779 * dispextern.h (merge_faces):
9780 * xfaces.c (merge_faces):
9781 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9782 Don't assume EMACS_INT fits in int.
9784 * character.h (CHAR_VALID_P): Remove unused parameter.
9785 * fontset.c, lisp.h, xdisp.c: All uses changed.
9787 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9789 * fns.c (concat): Minor tuning based on overflow analysis.
9790 This doesn't fix any bugs. Use int to hold character, instead
9791 of constantly refetching from Emacs object. Use XFASTINT, not
9792 XINT, for value known to be a character. Don't bother comparing
9793 a single byte to 0400, as it's always less.
9795 * floatfns.c (Fexpt):
9796 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9798 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9801 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9803 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9804 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9805 incorrectly succeed when S was a string, because 4294967386 was
9806 truncated before it was used.
9808 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9809 Otherwise, an out-of-range integer could cause undefined behavior
9812 * composite.c: Use int, not EMACS_INT, for characters.
9813 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9814 EMACS_INT, for values that are known to be in character range.
9815 This doesn't fix any bugs but is the usual style inside Emacs and
9816 may generate better code on 32-bit machines.
9818 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9819 This is for reasons similar to the recent CHAR_STRING fix.
9820 * charset.c (Fencode_char): Check that character arg is actually
9821 a character. Pass an int to ENCODE_CHAR.
9822 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9823 wider than 'int', as a compile-time check to prevent future regressions
9826 * character.c (char_string): Remove unnecessary casts.
9828 Make sure a 64-bit char is never passed to CHAR_STRING.
9829 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9830 by silently ignoring the top 32 bits, allowing some values
9831 that were far too large to be valid characters.
9832 * character.h: Include <verify.h>.
9833 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9834 arguments are no wider than unsigned, as a compile-time check
9835 to prevent future regressions in this area.
9837 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9838 (Fsubst_char_in_region):
9840 * xdisp.c (decode_mode_spec_coding):
9841 Adjust to CHAR_STRING's new requirement.
9842 * editfns.c (Finsert_char, Fsubst_char_in_region):
9843 * fns.c (concat): Check that character args are actually
9844 characters. Without this test, these functions did the wrong
9845 thing with wildly out-of-range values on 64-bit hosts.
9847 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9848 These casts should not be needed on 32-bit hosts, either.
9849 * keyboard.c (read_char):
9850 * lread.c (Fload): Remove casts to unsigned.
9852 * lisp.h (UNSIGNED_CMP): New macro.
9853 This fixes comparison bugs on 64-bit hosts.
9854 (ASCII_CHAR_P): Use it.
9855 * casefiddle.c (casify_object):
9856 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9857 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9858 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9859 * dispextern.h (FACE_FROM_ID):
9860 * keyboard.c (read_char): Use UNSIGNED_CMP.
9862 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9863 not to EMACS_INT, to avoid GCC warning.
9865 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9867 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9868 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9869 isn't needed on 32-bit machines.
9871 * buffer.c (Fgenerate_new_buffer_name):
9872 Use EMACS_INT for count, not int.
9873 (advance_to_char_boundary): Return EMACS_INT, not int.
9875 * data.c (Qcompiled_function): Now static.
9877 * window.c (window_body_lines): Now static.
9879 * image.c (gif_load): Rename local to avoid shadowing.
9881 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9882 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9883 * alloc.c (make_save_value): Integer argument is now of type
9885 (mark_object): Use ptrdiff_t, not int.
9886 * lisp.h (pD): New macro.
9887 * print.c (print_object): Use it.
9889 * alloc.c: Use EMACS_INT, not int, to count objects.
9890 (total_conses, total_markers, total_symbols, total_vector_size)
9891 (total_free_conses, total_free_markers, total_free_symbols)
9892 (total_free_floats, total_floats, total_free_intervals)
9893 (total_intervals, total_strings, total_free_strings):
9894 Now EMACS_INT, not int. All uses changed.
9895 (Fgarbage_collect): Compute overall total using a double, so that
9896 integer overflow is less likely to be a problem. Check for overflow
9897 when converting back to an integer.
9898 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9899 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9900 These were 'int' variables that could overflow on 64-bit hosts;
9901 they were never used, so remove them instead of repairing them.
9902 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9903 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9904 Previously, this ceilinged at INT_MAX, but that doesn't work on
9906 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9908 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9909 (allocate_vectorlike): Check for ptrdiff_t overflow.
9910 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9911 when a (possibly-narrower) signed value would do just as well.
9912 We prefer using signed arithmetic, to avoid comparison confusion.
9914 * alloc.c: Catch some string size overflows that we were missing.
9915 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9916 for convenience in STRING_BYTES_MAX.
9917 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9918 The definition here is exact; the one in lisp.h was approximate.
9919 (allocate_string_data): Check for string overflow. This catches
9920 some instances we weren't catching before. Also, it catches
9921 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9922 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9923 and ptrdiff_t and EMACS_INT are both 64 bits.
9925 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9926 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9927 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9929 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9931 * alloc.c (Fmake_string): Check for out-of-range init.
9933 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9935 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9937 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9939 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9940 xg_get_default_scrollbar_width.
9942 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9943 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9944 (style_changed_cb): Call update_theme_scrollbar_width and call
9945 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9946 all frames (Bug#8505).
9947 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9948 Call gtk_window_set_resizable if HAVE_GTK3.
9949 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9950 and height if HAVE_GTK3 (Bug#8505).
9951 (scroll_bar_width_for_theme): New variable.
9952 (update_theme_scrollbar_width): New function.
9953 (xg_get_default_scrollbar_width): Move code to
9954 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9955 (xg_initialize): Call update_theme_scrollbar_width.
9957 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9959 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9961 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9963 * frame.c (make_frame): Call other_buffer_safely instead of
9966 * window.c (temp_output_buffer_show): Call display_buffer with
9967 second argument Vtemp_buffer_show_specifiers and reset latter
9968 immediately after the call.
9969 (Vtemp_buffer_show_specifiers): New variable.
9970 (auto_window_vscroll_p, next_screen_context_lines)
9971 (Vscroll_preserve_screen_position): Remove leading asterisks from
9974 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9976 Fix minor problems found by GCC 4.6.0 static checking.
9977 * buffer.c (Qclone_number): Remove for now, as it's unused.
9978 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9979 (record_buffer): Remove unused local.
9980 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9981 (set_frame_buffer_list): Remove; unused.
9982 * frame.h (other_visible_frames): Remove decl.
9983 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9984 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9985 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9987 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9988 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9989 Define only if HAVE_GPM.
9990 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9991 (update_hints_inhibit): Remove; never set. All uses removed.
9992 * widgetprv.h (emacsFrameClassRec): Remove decl.
9993 * window.c (delete_deletable_window): Now returns void, since it
9994 wasn't returning anything.
9995 (compare_window_configurations): Remove unused locals.
9996 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9997 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9998 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9999 the same widths as pointers. This follows up on the 2011-05-06 patch.
10000 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10001 * xterm.h: Likewise.
10002 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10004 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10006 * makefile.w32-in: Update dependencies.
10007 (LISP_H): Add lib/intprops.h.
10009 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10011 * image.c (gif_load): Add animation frame delay to the metadata.
10012 (syms_of_image): Use DEFSYM. New symbol `delay'.
10014 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10016 * window.c (delete_deletable_window): Re-add.
10017 (Fset_window_configuration): Rewrite to handle dead buffers and
10018 consequently deletable windows.
10019 (window_tree, Fwindow_tree): Remove. Supply functionality in
10021 (compare_window_configurations): Simplify code.
10023 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10025 * image.c (imagemagick_load_image): Fix type mismatch.
10026 (Fimagemagick_types): Likewise.
10028 * window.h (replace_buffer_in_windows): Declare.
10030 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10032 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10033 Qclone_number. Remove external declaration of Qdelete_window.
10034 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10036 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10037 Run Qbuffer_list_update_hook if allowed.
10038 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10039 buffer list implementation.
10040 (other_buffer_safely): New function.
10041 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10042 calls to replace_buffer_in_windows and
10043 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10045 (record_buffer): Inhibit quitting and rewrite using quittable
10046 functions. Run Qbuffer_list_update_hook if allowed.
10047 (Frecord_buffer, Funrecord_buffer): New functions.
10048 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10049 Move switch-to-buffer to window.el.
10050 (bury-buffer): Move to window.el.
10051 (Vbuffer_list_update_hook): New variable.
10053 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10056 * window.h (resize_frame_windows): Move up in code.
10057 (Fwindow_frame): Remove EXFUN.
10058 (replace_buffer_in_all_windows): Remove prototype.
10059 (replace_buffer_in_windows_safely): Add prototype.
10061 * window.c: Declare Qdelete_window static again. Move down
10062 declaration of select_count.
10063 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10064 (Fother_window): Move to window.el.
10065 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10066 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10067 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10069 (replace_buffer_in_windows): Implement by calling
10070 Qreplace_buffer_in_windows.
10071 (replace_buffer_in_all_windows): Remove with some functionality
10072 moved into replace_buffer_in_windows_safely.
10073 (replace_buffer_in_windows_safely): New function.
10074 (select_window_norecord, select_frame_norecord): Move in front
10075 of run_window_configuration_change_hook. Remove now obsolete
10077 (Fset_window_buffer): Rewrite doc-string.
10078 Call Qrecord_window_buffer.
10079 (keys_of_window): Move binding for other-window to window.el.
10081 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10083 * dispextern.h (struct image): Replace data member, whose int_val
10084 and ptr_val fields were not used by anything, with a single
10087 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10088 (gif_clear_image, gif_load, imagemagick_load_image)
10089 (gs_clear_image, gs_load): Callers changed.
10091 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10093 * buffer.h: Include <time.h>, for time_t.
10094 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10096 Fix minor problems found by static checking.
10098 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10100 Make identifiers static if they are not used in other modules.
10101 * data.c (Qcompiled_function, Qframe, Qvector):
10102 * image.c (QimageMagick, Qsvg):
10103 * minibuf.c (Qmetadata):
10104 * window.c (resize_window_check, resize_root_window): Now static.
10105 * window.h (resize_window_check, resize_root_window): Remove decls.
10107 * window.c (window_deletion_count, delete_deletable_window):
10109 (window_body_lines): Now static.
10110 (Fdelete_other_windows_internal): Mark vars as initialized.
10111 Make sure 'resize_failed' is initialized.
10112 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10113 (resize_window_apply): Remove unused local.
10114 * window.h (delete_deletable_window): Remove decl.
10116 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10117 (imagemagick_load_image): Fix pointer signedness problem by changing
10118 last arg from unsigned char * to char *. All uses changed.
10119 Also, fix a local for similar reasons.
10120 Remove unused locals. Remove locals to avoid shadowing.
10121 (fn_rsvg_handle_free): Remove; unused.
10122 (svg_load, svg_load_image): Fix pointer signedness problem.
10123 (imagemagick_load_image): Don't use garbage pointer image_wand.
10125 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10127 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10129 * image.c (gif_load): Fix omitted cast error introduced by
10132 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10134 * window.h (resize_proportionally, orig_total_lines)
10135 (orig_top_line): Remove from window structure.
10136 (set_window_height, set_window_width, change_window_heights)
10137 (Fdelete_window): Remove prototypes.
10138 (resize_frame_windows): Remove duplicate declaration.
10140 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10142 * window.h (resize_frame_windows, resize_window_check)
10143 (delete_deletable_window, resize_root_window)
10144 (resize_frame_windows): Declare prototypes.
10146 * window.c (resize_window_apply): Make definition be "static" to
10147 match the prototype.
10149 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10151 * window.c: Remove declarations of Qwindow_size_fixed,
10152 window_min_size_1, window_min_size_2, window_min_size,
10153 size_window, window_fixed_size_p, enlarge_window, delete_window.
10154 Remove static from declaration of Qdelete_window, it's
10155 temporarily needed by Fbury_buffer.
10156 (replace_window): Don't assign orig_top_line and
10158 (Fdelete_window, delete_window): Remove. Window deletion is
10159 handled by window.el.
10160 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10161 Replace Fdelete_window calls with calls to Qdelete_window.
10162 (Fdelete_other_windows): Remove. Deleting other windows is
10163 handled by window.el.
10164 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10165 handled in window.el.
10166 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10167 Window minimum sizes are handled in window.el.
10168 (shrink_windows, size_window, set_window_height)
10169 (set_window_width, change_window_heights, window_height)
10170 (window_width, CURBEG, CURSIZE, enlarge_window)
10171 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10172 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10173 handled in window.el.
10174 (make_dummy_parent): Rename to make_parent_window and give it a
10175 second argument horflag.
10176 (make_window): Don't set resize_proportionally any more.
10177 (Fsplit_window): Remove. Windows are split in window.el.
10178 (save_restore_action, save_restore_orig_size)
10179 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10180 Resize mini windows in window.el.
10181 (grow_mini_window, shrink_mini_window): Implement by calling
10182 Qresize_root_window_vertically, resize_window_check and
10183 resize_window_apply.
10184 (saved_window, Fset_window_configuration, save_window_save):
10185 Do not handle orig_top_line, orig_total_lines, and
10186 resize_proportionally.
10187 (window_min_height, window_min_width): Move to window.el.
10188 (keys_of_window): Move bindings for delete-other-windows,
10189 split-window, delete-window and enlarge-window to window.el.
10191 * buffer.c: Temporarily extern Qdelete_window.
10192 (Fbury_buffer): Temporarily call Qdelete_window instead of
10193 Fdelete_window (Fbury_buffer will move to window.el soon).
10195 * frame.c (set_menu_bar_lines_1): Remove code handling
10196 orig_top_line and orig_total_lines.
10198 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10199 set_window_height but set heights directly.
10200 (change_frame_size_1): Use resize_frame_windows.
10202 * xdisp.c (init_xdisp): Don't use set_window_height but set
10205 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10206 Use resize_frame_windows instead of change_window_heights and run
10207 run_window_configuration_change_hook.
10209 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10210 instead of change_window_heights and run
10211 run_window_configuration_change_hook.
10213 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10215 * window.c (replace_window): Rename second argument REPLACEMENT to
10216 NEW. New third argument SETFLAG. Rewrite.
10217 (delete_window, make_dummy_parent): Call replace_window with
10219 (window_list_1): Move down in code.
10220 (run_window_configuration_change_hook): Move set_buffer part
10221 before select_frame_norecord part in order to unwind correctly.
10222 Rename count1 to count.
10223 (recombine_windows, delete_deletable_window, resize_root_window)
10224 (Fdelete_other_windows_internal)
10225 (Frun_window_configuration_change_hook, make_parent_window)
10226 (resize_window_check, resize_window_apply, Fresize_window_apply)
10227 (resize_frame_windows, Fsplit_window_internal)
10228 (Fdelete_window_internal, Fresize_mini_window_internal):
10230 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10232 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10234 * window.h (window): Add some new members to window structure -
10235 normal_lines, normal_cols, new_total, new_normal, clone_number,
10236 splits, nest, prev_buffers, next_buffers.
10237 (WINDOW_TOTAL_SIZE): Move here from window.c.
10238 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10240 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10242 (make_dummy_parent): Set new members of windows structure.
10243 (make_window): Move down in code. Handle new members of window
10245 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10246 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10247 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10248 (Fset_window_prev_buffers, Fwindow_next_buffers)
10249 (Fset_window_next_buffers, Fset_window_clone_number):
10251 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10252 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10254 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10255 Argument WINDOW can be now internal window too.
10256 (Fwindow_use_time): Move up in code.
10257 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10258 Rewrite doc-string.
10259 (Fset_window_configuration, saved_window)
10260 (Fcurrent_window_configuration, save_window_save): Handle new
10261 members of window structure.
10262 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10263 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10264 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10265 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10266 Qget_mru_window, Qresize_root_window,
10267 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10268 Qauto_buffer_name; staticpro them.
10270 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10272 * window.c (Fwindow_total_size, Fwindow_left_column)
10273 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10274 (Fwindow_list_1): New functions.
10275 (window_box_text_cols): Replace with window_body_cols.
10276 (Fwindow_width, Fscroll_left, Fscroll_right):
10277 Use window_body_cols instead of window_box_text_cols.
10278 (delete_window, Fset_window_configuration):
10279 Call delete_all_subwindows with window as argument.
10280 (delete_all_subwindows): Take a window as argument and not a
10281 structure. Rewrite.
10282 (window_loop): Remove handling of GET_LRU_WINDOW and
10283 GET_LARGEST_WINDOW.
10284 (Fget_lru_window, Fget_largest_window): Move to window.el.
10286 * window.h: Extern window_body_cols instead of
10287 window_box_text_cols. delete_all_subwindows now takes a
10288 Lisp_Object as argument.
10290 * indent.c (compute_motion, Fcompute_motion):
10291 Use window_body_cols instead of window_box_text_cols.
10293 * frame.c (delete_frame): Call delete_all_subwindows with root
10294 window as argument.
10296 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10298 * fns.c (Fputhash): Document return value.
10300 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10302 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10304 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10306 Cons<->int and similar integer overflow fixes (Bug#8794).
10308 Check for overflow when converting integer to cons and back.
10309 * charset.c (Fdefine_charset_internal, Fdecode_char):
10310 Use cons_to_unsigned to catch overflow.
10311 (Fencode_char): Use INTEGER_TO_CONS.
10312 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10313 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10314 * data.c (long_to_cons, cons_to_long): Remove.
10315 (cons_to_unsigned, cons_to_signed): New functions.
10316 These signal an error for invalid or out-of-range values.
10317 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10318 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10319 * font.c (Ffont_variation_glyphs):
10320 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10321 * lisp.h: Include <intprops.h>.
10322 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10323 (cons_to_signed, cons_to_unsigned): New decls.
10324 (long_to_cons, cons_to_long): Remove decls.
10325 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10326 (Fprimitive_undo): Use CONS_TO_INTEGER.
10327 * xfns.c (Fx_window_property): Likewise.
10328 * xselect.c: Include <limits.h>.
10329 (x_own_selection, selection_data_to_lisp_data):
10330 Use INTEGER_TO_CONS.
10331 (x_handle_selection_request, x_handle_selection_clear)
10332 (x_get_foreign_selection, Fx_disown_selection_internal)
10333 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10334 (lisp_data_to_selection_data): Use cons_to_unsigned.
10335 (x_fill_property_data): Use cons_to_signed.
10336 Report values out of range.
10338 Check for buffer and string overflow more precisely.
10339 * buffer.h (BUF_BYTES_MAX): New macro.
10340 * lisp.h (STRING_BYTES_MAX): New macro.
10341 * alloc.c (Fmake_string):
10342 * character.c (string_escape_byte8):
10343 * coding.c (coding_alloc_by_realloc):
10344 * doprnt.c (doprnt):
10345 * editfns.c (Fformat):
10347 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10348 since they may not be the same number.
10349 * editfns.c (Finsert_char):
10350 * fileio.c (Finsert_file_contents):
10351 Likewise for BUF_BYTES_MAX.
10353 * image.c: Use ptrdiff_t, not int, for sizes.
10354 (slurp_file): Switch from int to ptrdiff_t.
10356 (slurp_file): Check that file size fits in both size_t (for
10357 malloc) and ptrdiff_t (for sanity and safety).
10359 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10360 if b->modtime has its maximal value.
10362 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10364 Don't assume time_t can fit into int.
10365 * buffer.h (struct buffer.modtime): Now time_t, not int.
10366 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10367 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10369 Minor fixes for signed vs unsigned integers.
10370 * character.h (MAYBE_UNIFY_CHAR):
10371 * charset.c (maybe_unify_char):
10372 * keyboard.c (read_char, reorder_modifiers):
10373 XINT -> XFASTINT, since the integer must be nonnegative.
10374 * ftfont.c (ftfont_spec_pattern):
10375 * keymap.c (access_keymap, silly_event_symbol_error):
10376 XUINT -> XFASTINT, since the integer must be nonnegative.
10377 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10378 since it makes no difference and we prefer signed.
10379 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10380 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10383 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10385 * window.h (Fwindow_frame): Declare.
10387 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10389 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10390 (SPARE_MEMORY): Always define.
10391 (LARGE_REQUEST): Remove.
10392 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10394 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10396 * lisp.h: Move EXFUNS for Fframe_root_window,
10397 Fframe_first_window and Fset_frame_selected_window to window.h.
10399 * window.h: Move EXFUNS for Fframe_root_window,
10400 Fframe_first_window and Fset_frame_selected_window here from
10403 * frame.c (Fwindow_frame, Fframe_first_window)
10404 (Fframe_root_window, Fframe_selected_window)
10405 (Fset_frame_selected_window): Move to window.c.
10406 (Factive_minibuffer_window): Move to minibuf.c.
10407 (Fother_visible_frames_p): New function.
10409 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10411 * window.c (decode_window, decode_any_window): Move up in code.
10412 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10413 (inhibit_frame_unsplittable): Remove unused variable.
10414 (Fwindow_buffer): Move up and rewrite doc-string.
10415 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10416 (Fwindow_prev): New functions.
10417 (Fwindow_frame): Move here from frame.c. Accept any window as
10419 (Fframe_root_window, Fframe_first_window)
10420 (Fframe_selected_window): Move here from frame.c. Accept frame
10421 or arbitrary window as argument. Update doc-strings.
10422 (Fminibuffer_window): Move up in code.
10423 (Fwindow_minibuffer_p): Move up in code and simplify.
10424 (Fset_frame_selected_window): Move here from frame.c.
10426 (Fselected_window, select_window, Fselect_window): Move up in
10427 code. Minor doc-string fixes.
10429 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10431 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10432 Do not assume that spare memory exists; that assumption is valid
10433 only if SYSTEM_MALLOC.
10434 (LARGE_REQUEST): New macro, so that the issue of large requests
10435 is separated from the issue of spare memory.
10437 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10439 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10442 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10444 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10447 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10449 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10451 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10453 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10454 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10456 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10458 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10460 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10462 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10463 (x_clipboard_manager_save): Add return value.
10464 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10465 New error handlers.
10466 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10467 Obey Vx_select_enable_clipboard_manager. Catch errors in
10468 x_clipboard_manager_save (Bug#8779).
10469 (Vx_select_enable_clipboard_manager): New variable.
10470 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10472 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10474 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10476 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10478 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10479 in the current matrix if keep_current_p is non-zero.
10481 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10483 * bidi.c (bidi_level_of_next_char): Fix last change.
10485 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10487 Support bidi reordering of text covered by display properties.
10489 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10490 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10491 (bidi_cache_search, bidi_cache_iterator_state)
10492 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10493 (bidi_level_of_next_char, bidi_move_to_visually_next):
10494 Support character positions inside a run of characters covered by a
10496 (bidi_paragraph_init, bidi_resolve_explicit_1)
10497 (bidi_level_of_next_char): Call bidi_fetch_char and
10498 bidi_fetch_char_advance instead of FETCH_CHAR and
10499 FETCH_CHAR_ADVANCE.
10500 (bidi_init_it): Initialize new members.
10501 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10503 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10504 instead of using explicit *_CHAR codes.
10505 (bidi_resolve_explicit, bidi_resolve_weak):
10506 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10507 bidirectional text is supported only in multibyte buffers.
10508 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10509 it to initialize the frame_window_p member of struct bidi_it.
10510 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10511 (bidi_resolve_explicit, bidi_resolve_weak)
10512 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10513 bidi_it->nchars is non-positive.
10514 (bidi_level_of_next_char): Don't try to lookup the cache for the
10515 next/previous character if nothing is cached there yet, or if we
10516 were just reseat()'ed to a new position.
10518 * xdisp.c (set_cursor_from_row): Set start and stop points
10519 according to the row's direction when priming the loop that looks
10520 for the glyph on which to display cursor.
10521 (single_display_spec_intangible_p): Function deleted.
10522 (display_prop_intangible_p): Reimplement to call
10523 handle_display_spec instead of single_display_spec_intangible_p.
10524 Accept 3 additional arguments needed by handle_display_spec.
10525 This fixes incorrect cursor motion across display property with complex
10526 values: lists, `(when COND...)' forms, etc.
10527 (single_display_spec_string_p): Support property values that are
10528 lists with the argument STRING its top-level element.
10529 (display_prop_string_p): Fix the condition for processing a
10530 property that is a list to be consistent with handle_display_spec.
10531 (handle_display_spec): New function, refactored from the
10532 last portion of handle_display_prop.
10533 (compute_display_string_pos): Accept additional argument
10534 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10535 value of a `display' property is a "replacing spec".
10536 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10537 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10538 the display property, but just return a value indicating whether
10539 the display property will replace the characters it covers.
10540 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10541 frame_window_p members of struct bidi_it.
10542 (compute_display_string_pos, compute_display_string_end):
10544 (push_it): Accept second argument POSITION, where pop_it should
10545 jump to continue iteration.
10546 (reseat_1): Initialize bidi_it.disp_pos.
10548 * keyboard.c (adjust_point_for_property): Adjust the call to
10549 display_prop_intangible_p to its new signature.
10551 * dispextern.h (struct bidi_it): New member frame_window_p.
10552 (bidi_init_it): Update prototypes.
10553 (display_prop_intangible_p): Update prototype.
10554 (compute_display_string_pos, compute_display_string_end):
10555 Declare prototypes.
10556 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10559 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10561 Malloc failure behavior now depends on size of allocation.
10562 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10563 * lisp.h: Change signatures accordingly.
10564 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10565 All callers changed. (Bug#8762)
10567 * gnutls.c: Use Emacs's memory allocators.
10568 Without this change, the gnutls library would invoke malloc etc.
10569 directly, which causes problems on non-SYNC_INPUT hosts, and which
10570 runs afoul of improving memory_full behavior. (Bug#8761)
10571 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10572 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10573 xfree instead of the default malloc, realloc, free.
10574 (Fgnutls_boot): No need to check for memory allocation failure,
10575 since xmalloc does that for us.
10577 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10578 * category.c (hash_get_category_set):
10579 * ccl.c (ccl_driver):
10580 * charset.c (Fdefine_charset_internal):
10581 * charset.h (struct charset.hash_index):
10582 * composite.c (get_composition_id, gstring_lookup_cache)
10583 (composition_gstring_put_cache):
10584 * composite.h (struct composition.hash_index):
10585 * dispextern.h (struct image.hash):
10586 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10587 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10588 (hashfn_equal, hashfn_user_defined, make_hash_table)
10589 (maybe_resize_hash_table, hash_lookup, hash_put)
10590 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10591 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10592 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10593 * image.c (make_image, search_image_cache, lookup_image)
10594 (xpm_put_color_table_h):
10595 * lisp.h (struct Lisp_Hash_Table):
10596 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10597 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10598 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10599 * alloc.c (allocate_vectorlike):
10600 Check for overflow in vector size calculations.
10601 * ccl.c (ccl_driver):
10602 Check for overflow when converting EMACS_INT to int.
10603 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10604 need to be updated by these changes.
10605 * fns.c (make_hash_table, maybe_resize_hash_table):
10606 Check for integer overflow with large hash tables.
10607 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10608 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10609 (SXHASH_REDUCE): New macro.
10610 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10611 Use it instead of discarding useful hash info with large hash values.
10612 (sxhash_float): New function.
10613 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10614 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10615 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10616 Rewrite to use FIXNUM_BITS, as this simplifies things.
10617 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10618 Adjust signatures to match updated version of code.
10619 (consing_since_gc): Now EMACS_INT, since a single hash table can
10620 use more than INT_MAX bytes.
10622 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10624 Make it possible to build with GCC-4.6+ -O2 -flto.
10626 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10628 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10630 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10631 Call minibuffer-inactive-mode.
10633 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10635 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10636 Update dependencies.
10638 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10640 * data.c (init_data): Remove code for UTS, this system is not
10643 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10645 Don't force ./temacs to start in terminal mode.
10647 * frame.c (make_initial_frame): Initialize faces in all cases, not
10648 only when CANNOT_DUMP is defined.
10649 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10651 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10653 * dispnew.c (add_window_display_history): Use const for the string
10654 pointer. Remove declaration, not needed.
10656 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10658 Use 'inline', not 'INLINE'.
10659 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10660 * alloc.c, fontset.c (INLINE): Remove.
10661 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10662 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10663 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10664 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10665 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10667 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10669 Make it possible to run ./temacs.
10671 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10672 syms_of_callproc does the same thing. Remove test for
10673 "initialized", do it in the caller.
10674 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10676 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10678 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10679 (read_minibuf): Use get_minibuffer.
10680 (syms_of_minibuf): Use DEFSYM.
10681 (Qmetadata): New var.
10682 * data.c (Qbuffer): Don't make it static.
10683 (syms_of_data): Use DEFSYM.
10685 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10687 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10688 (CCL_CODE_MIN): New macro.
10690 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10692 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10694 * eval.c (Qdebug): Now static.
10695 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10696 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10697 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10699 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10701 * image.c: Various fixes to ImageMagick code comments.
10702 (Fimagemagick_types): Doc fix.
10704 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10706 Minor fixes prompted by GCC 4.6.0 warnings.
10708 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10710 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10711 (x_clipboard_manager_save_all): Move extern decl to ...
10712 * xterm.h: ... here, so that it can be checked for consistency.
10714 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10716 * xselect.c (x_clipboard_manager_save_frame)
10717 (x_clipboard_manager_save_all): New functions.
10718 (Fx_clipboard_manager_save): Lisp function deleted.
10720 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10721 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10723 * xterm.h: Update prototype.
10725 2011-05-28 William Xu <william.xwl@gmail.com>
10727 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10728 exiting (Bug#8239).
10730 2011-05-28 Jim Meyering <meyering@redhat.com>
10732 Avoid a sign-extension bug in crypto_hash_function.
10733 * fns.c (to_uchar): Define.
10734 (crypto_hash_function): Use it to convert some newly-signed
10735 variables to unsigned, to avoid sign-extension bugs. For example,
10736 without this change, (md5 "truc") would evaluate to
10737 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10738 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10739 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10741 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10743 Integer overflow fixes.
10745 * dbusbind.c: Serial number integer overflow fixes.
10746 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10747 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10748 to hold a serial number that is too large for a fixnum.
10749 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10750 Check for serial numbers out of range. Decode any serial number
10751 that was so large that it became a float. (Bug#8722)
10753 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10754 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10755 Use XFASTINT rather than XUINT when numbers are nonnegative.
10756 (xd_append_arg, Fdbus_method_return_internal):
10757 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10758 arguments, check that Lisp number is nonnegative, rather than
10759 silently wrapping negative numbers around. (Bug#8722)
10760 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10763 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10765 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10767 ccl: Add integer overflow checks.
10768 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10769 (IN_INT_RANGE): New macros.
10770 (ccl_driver): Use them to check for integer overflow when
10771 decoding a CCL program. Many of the new checks are whether XINT (x)
10772 fits in int; it doesn't always, on 64-bit hosts. The new version
10773 doesn't catch all possible integer overflows, but it's an
10774 improvement. (Bug#8719)
10776 * alloc.c (make_event_array): Use XINT, not XUINT.
10777 There's no need for unsigned here.
10779 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10780 This follows up to the 2011-05-06 change that substituted uintptr_t
10781 for EMACS_INT. This case wasn't caught back then.
10783 Rework Fformat to avoid integer overflow issues.
10784 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10785 now (part of C89). Include <verify.h>.
10786 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10787 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10788 (Fformat): Avoid the prepass trying to compute sizes; it was only
10789 approximate and thus did not catch overflow reliably. Instead, walk
10790 through the format just once, formatting and computing sizes as we go,
10791 checking for integer overflow at every step, and allocating a larger
10792 buffer as needed. Keep track separately whether the format is
10793 multibyte. Keep only the most-recently calculated precision, rather
10794 than them all. Record whether each argument has been converted to
10795 string. Use EMACS_INT, not int, for byte and char and arg counts.
10796 Support field widths and precisions larger than INT_MAX. Avoid
10797 sprintf's undefined behavior with conversion specifications such as %#d
10798 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10799 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10800 formatting out-of-range floating point numbers with int
10801 formats. (Bug#8668)
10803 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10805 * data.c: Avoid integer truncation in expressions involving floats.
10806 * data.c: Include <intprops.h>.
10807 (arith_driver): When there's an integer overflow in an expression
10808 involving floating point, convert the integers to floating point
10809 so that the resulting value does not suffer from catastrophic
10810 integer truncation. For example, on a 64-bit host (* 4
10811 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10812 Do not rely on undefined behavior after integer overflow.
10814 merge count_size_as_multibyte, parse_str_to_multibyte
10815 * character.c, character.h (count_size_as_multibyte):
10816 Rename from parse_str_to_multibyte; all uses changed.
10817 Check for integer overflow.
10818 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10819 since it's now a duplicate of the other. This is more of
10820 a character than a buffer op, so better that it's in character.c.
10821 * fns.c, print.c: Adjust to above changes.
10823 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10825 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10827 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10829 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10830 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10831 (x_clipboard_manager_save): Now static.
10832 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10834 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10835 (crypto_hash_function): Now static.
10836 Fix pointer signedness problems. Avoid unnecessary initializations.
10838 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10840 * termhooks.h (Vselection_alist): Make it terminal-local.
10842 * terminal.c (create_terminal): Initialize it.
10844 * xselect.c: Support for clipboard managers.
10845 (Vselection_alist): Move to termhooks.h as terminal-local var.
10846 (LOCAL_SELECTION): New macro.
10847 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10848 (symbol_to_x_atom): Remove gratuitous arg.
10849 (x_handle_selection_request, lisp_data_to_selection_data)
10850 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10851 (x_own_selection, x_get_local_selection, x_convert_selection):
10852 New arg, specifying work frame. Use terminal-local Vselection_alist.
10853 (some_frame_on_display): Delete unused function.
10854 (Fx_own_selection_internal, Fx_get_selection_internal)
10855 (Fx_disown_selection_internal, Fx_selection_owner_p)
10856 (Fx_selection_exists_p): New optional frame arg.
10857 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10858 (x_handle_selection_clear): Don't treat other terminals with the
10859 same keyboard specially. Use the terminal-local Vselection_alist.
10860 (x_clear_frame_selections): Use Frun_hook_with_args.
10862 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10864 * xterm.h: Add support for those atoms.
10866 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10868 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10869 (converted_selections, conversion_fail_tag): New global variables.
10870 (x_selection_request_lisp_error): Free the above.
10871 (x_get_local_selection): Remove unnecessary code.
10872 (x_reply_selection_request): Args changed; handle arbitrary array
10873 of converted selections stored in converted_selections.
10874 Separate the XChangeProperty and SelectionNotify steps.
10875 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10876 (x_convert_selection): New function.
10877 (x_handle_selection_event): Simplify.
10878 (x_get_foreign_selection): Don't ignore incoming requests while
10879 waiting for an answer; this will fail when we implement
10880 SAVE_TARGETS, and seems unnecessary anyway.
10881 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10882 (Vx_sent_selection_functions): Doc fix.
10884 2011-05-26 Leo Liu <sdl.web@gmail.com>
10886 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10888 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10890 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10892 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10893 for fringe update if it has periodic bitmap.
10894 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10895 and fringe_bitmap_periodic_p.
10897 * fringe.c (get_fringe_bitmap_data): New function.
10898 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10899 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10900 row. Mark glyph row for fringe update if periodicity changed.
10902 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10903 for fringe update unless it has periodic bitmap.
10905 2011-05-25 Kenichi Handa <handa@m17n.org>
10907 * xdisp.c (get_next_display_element): Set correct it->face_id for
10908 a static composition.
10910 2011-05-24 Leo Liu <sdl.web@gmail.com>
10913 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10915 * fns.c (crypto_hash_function, Fsha1): New function.
10916 (Fmd5): Use crypto_hash_function.
10917 (syms_of_fns): Add Ssha1.
10919 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10921 * gnutls.c: Remove unused macros.
10922 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10923 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10924 Remove macros that are defined and never used.
10925 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10927 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10929 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10930 (Fx_get_selection_internal): Minor cleanup.
10931 (Fx_own_selection_internal): Rename arguments for consistency with
10934 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10936 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10938 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10940 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10942 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10944 * dispnew.c (scrolling_window): Don't exclude the case that the
10945 last enabled row in the desired matrix touches the bottom boundary.
10947 2011-05-21 Glenn Morris <rgm@gnu.org>
10949 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10950 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10951 and add some more files.
10953 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10955 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10956 report_file_error introduced by the change from 2011-05-07.
10958 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10960 * systime.h (Time): Define only if emacs is defined.
10961 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10962 where the include path doesn't have X11/X.h by default. See
10963 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10965 2011-05-20 Kenichi Handa <handa@m17n.org>
10967 * composite.c (find_automatic_composition): Fix previous change.
10969 2011-05-20 Glenn Morris <rgm@gnu.org>
10971 * lisp.mk: New file, split from Makefile.in.
10972 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10973 (shortlisp): Remove.
10974 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10976 2011-05-19 Glenn Morris <rgm@gnu.org>
10978 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10979 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10980 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10981 (lisp): Set the order to that of loadup.el.
10982 (shortlisp): Make it a copy of $lisp.
10983 (SOME_MACHINE_LISP): Remove.
10984 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10985 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10987 2011-05-18 Kenichi Handa <handa@m17n.org>
10989 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10990 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10991 (find_automatic_composition): Mostly rewrite for efficiency.
10993 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10995 * makefile.w32-in: Update dependencies.
10997 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10999 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11000 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11002 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11004 Fix some integer overflow issues, such as string length overflow.
11006 * insdel.c (count_size_as_multibyte): Check for string overflow.
11008 * character.c (lisp_string_width): Check for string overflow.
11009 Use EMACS_INT, not int, for string indexes and lengths; in
11010 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11011 the resulting string length overflows an EMACS_INT; instead,
11012 report a string overflow if no precision given. When checking for
11013 precision exhaustion, use a check that cannot possibly have
11014 integer overflow. (Bug#8675)
11015 * character.h (lisp_string_width): Adjust to new signature.
11017 * alloc.c (string_overflow): New function.
11018 (Fmake_string): Use it. This doesn't change behavior, but saves
11019 a few bytes and will simplify future changes.
11020 * character.c (string_escape_byte8): Likewise.
11021 * lisp.h (string_overflow): New decl.
11023 Fixups, following up to the user-interface timestamp change.
11024 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11025 for UI timestamps, instead of unsigned long.
11026 * msdos.c (mouse_get_pos): Likewise.
11027 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11028 * w32gui.h (Time): Define by including "systime.h" rather than by
11029 declaring it ourselves. (Bug#8664)
11031 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11032 * image.c (clear_image_cache): Likewise.
11034 * term.c (term_mouse_position): Don't assume time_t wraparound.
11036 Be more systematic about user-interface timestamps.
11037 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11038 and sometimes 'EMACS_UINT', to represent these timestamps.
11039 This change causes it to use 'Time' uniformly, as that's what X uses.
11040 This makes the code easier to follow, and makes it easier to catch
11041 integer overflow bugs such as Bug#8664.
11042 * frame.c (Fmouse_position, Fmouse_pixel_position):
11043 Use Time, not unsigned long, for user-interface timestamps.
11044 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11045 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11046 * keyboard.h (last_event_timestamp): Likewise.
11047 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11048 * menu.h (xmenu_show): Likewise.
11049 * term.c (term_mouse_position): Likewise.
11050 * termhooks.h (struct input_event.timestamp): Likewise.
11051 (struct terminal.mouse_position_hook): Likewise.
11052 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11053 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11054 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11055 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11056 what it was before.
11057 * menu.h, termhooks.h: Include "systime.h", for Time.
11059 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11060 Don't assume that the difference between two unsigned long values
11061 can fit into an integer. At this point, we know button_down_time
11062 <= event->timestamp, so the difference must be nonnegative, so
11063 there's no need to cast the result if double-click-time is
11064 nonnegative, as it should be; check that it's nonnegative, just in
11065 case. This bug is triggered when events are more than 2**31 ms
11066 apart (about 25 days). (Bug#8664)
11068 * xselect.c (last_event_timestamp): Remove duplicate decl.
11069 (x_own_selection): Remove needless cast to unsigned long.
11071 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11072 that always fit in int. Use a sentinel instead of a counter, to
11073 avoid a temp and to allay GCC's concerns about possible int overflow.
11074 * frame.h (struct frame): Use int for menu_bar_items_used
11075 instead of EMACS_INT, since it always fits in int.
11077 * menu.c (grow_menu_items): Check for int overflow.
11079 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11081 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11082 Before, the code was not consistent. These values cannot exceed
11083 2**31 - 1 so there's no need to make them unsigned.
11084 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11085 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11086 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11088 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11090 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11091 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11092 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11093 presumably because the widths might not match.
11095 * window.c (size_window): Avoid needless test at loop start.
11097 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11099 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11101 2011-05-12 Drew Adams <drew.adams@oracle.com>
11103 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11105 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11107 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11108 `width' to `bar_area_x' and `bar_area_width', respectively.
11109 (x_scroll_run): Take account of fringe background extension.
11111 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11112 Rename local vars `left' and `width' to `bar_area_x' and
11113 `bar_area_width', respectively.
11114 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11115 background extension.
11117 2011-05-10 Jim Meyering <meyering@redhat.com>
11119 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11121 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11123 * image.c (Finit_image_library): Return t for built-in image types,
11124 like pbm and xbm. (Bug#8640)
11126 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11128 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11130 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11132 * w32console.c (Fset_screen_color): Doc fix.
11133 (Fget_screen_color): New function.
11134 (syms_of_ntterm): Defsubr it.
11136 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11137 unlink the temporary file if Fcall_process didn't create it in the
11139 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11140 child process will be redirected to a file specified with `:file'.
11141 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11142 cue to call_process_cleanup not to close that handle.
11144 2011-05-07 Ben Key <bkey76@gmail.com>
11146 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11147 one of two shell specific rules, either bootstrap-temacs-CMD or
11148 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11149 to the previous implementation of the bootstrap-temacs rule.
11150 The bootstrap-temacs-CMD rule is similar to the previous
11151 implementation of the bootstrap-temacs rule except that it
11152 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11155 These changes, along with some changes to nt/configure.bat,
11156 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11157 earlier fix to add support for --cflags and --ldflags options
11158 that include quotes so that it works whether make uses cmd or
11161 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11163 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11164 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11166 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11167 a string. Handle both cases.
11168 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11169 (Fdbus_register_method): Use Qinvalid_function.
11171 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11173 * makefile.w32-in: Update dependencies.
11174 (LISP_H): Add inttypes.h and stdin.h.
11175 (PROCESS_H): Add unistd.h.
11177 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11179 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11180 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11182 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11184 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11186 * term.c (vfatal): Remove stray call to va_end.
11187 It's not needed and the C Standard doesn't allow it here anyway.
11189 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11190 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11192 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11195 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11199 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11201 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11203 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11205 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11206 * charset.c (Fdefine_charset_internal): Don't initialize
11207 charset.code_space[15]. The value was garbage, on hosts with
11208 32-bit int (Bug#8600).
11210 * lread.c (read_integer): Be more consistent with string-to-number.
11211 Use string_to_number to do the actual conversion; this avoids
11212 rounding errors and fixes some other screwups. Without this fix,
11213 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11214 (digit_to_number): Move earlier, for benefit of read_integer.
11215 Return -1 if the digit is out of range for the base, -2 if it is
11216 not a digit in any supported base. (Bug#8602)
11218 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11220 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11221 to match comment at start of function. This also removes a
11222 GCC warning about overflow in a 32+64-bit port.
11224 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11226 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11227 Reported by Stefan Monnier in
11228 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11229 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11230 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11232 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11233 (EMACS_UINTPTR): Likewise, with uintptr_t.
11235 * lisp.h: Prefer 64-bit EMACS_INT if available.
11236 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11237 on 32-bit hosts that have 64-bit int, so that they can access
11239 However, temporarily disable this change unless the temporary
11240 symbol WIDE_EMACS_INT is defined.
11242 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11244 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11245 This removes an assumption that EMACS_INT and long are the same
11246 width as pointers. The assumption is true for Emacs porting targets
11247 now, but we want to make other targets possible.
11248 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11249 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11250 In the rest of the code, change types of integers that hold casted
11251 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11252 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11253 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11254 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11255 No need to cast type when ORing.
11256 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11257 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11258 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11259 assume EMACS_INT is the same width as char *.
11260 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11261 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11262 Remove no-longer-needed casts.
11263 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11264 (xg_tool_bar_help_callback, xg_make_tool_item):
11265 Use EMACS_INTPTR to hold an integer
11266 that will be cast to void *; this can avoid a GCC warning
11267 if EMACS_INT is not the same width as void *.
11268 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11269 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11270 (current_message_1, set_message_1):
11271 Use a local to convert to proper width without a cast.
11272 * xmenu.c (dialog_selection_callback): Likewise.
11274 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11275 Also, don't assume VALBITS / RAND_BITS is less than 5,
11276 and don't rely on undefined behavior when shifting a 1 left into
11278 * lisp.h (get_random): Change signature to match.
11280 * lread.c (hash_string): Use size_t, not int, for hash computation.
11281 Normally we prefer signed values; but hashing is special, because
11282 it's better to use unsigned division on hash table sizes so that
11283 the remainder is nonnegative. Also, size_t is the natural width
11284 for hashing into memory. The previous code used 'int', which doesn't
11285 retain enough info to hash well into very large tables.
11286 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11288 * dbusbind.c: Don't possibly lose pointer info when converting.
11289 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11290 Use XPNTR rather than XHASH, so that the high-order bits of
11291 the pointer aren't lost when converting through void *.
11293 * eval.c (Fautoload): Don't double-shift a pointer.
11295 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11297 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11299 * gnutls.c (DEF_GNUTLS_FN):
11300 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11302 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11304 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11307 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11309 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11310 New version that can reserve upto 2GB of heap space.
11312 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11314 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11316 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11318 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11319 `gnutls_certificate_set_x509_key_file'.
11321 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11323 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11324 Update dependencies.
11326 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11328 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11329 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11330 Remove unused parameter `fildes'.
11331 * process.c (read_process_output, send_process): Don't pass it.
11333 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11335 Fix previous change: the library cache is defined in w32.c.
11336 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11337 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11339 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11341 Implement dynamic loading of GnuTLS on Windows.
11343 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11344 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11345 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11348 * gnutls.c (Qgnutls_dll): Define.
11349 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11350 (gnutls_*): Declare function pointers.
11351 (init_gnutls_functions): New function to initialize function pointers.
11352 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11353 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11354 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11355 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11356 (emacs_gnutls_write, emacs_gnutls_read)
11357 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11358 (Fgnutls_available_p): New function.
11359 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11360 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11361 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11363 * image.c: Include w32.h.
11364 (Vimage_type_cache): Delete.
11365 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11366 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11367 (w32_delayed_load): Move to w32.c.
11369 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11371 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11372 (w32_delayed_load): Move from image.c. When loading a library, record
11373 its filename in the :loaded-from property of the library id.
11374 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11375 Initialize and staticpro them.
11376 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11378 * process.c: Include lisp.h before w32.h, not after.
11379 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11380 instead of gnutls_record_check_pending.
11382 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11384 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11386 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11387 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11390 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11392 * xterm.c (x_set_frame_alpha): Do not set property on anything
11393 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11395 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11397 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11399 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11401 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11402 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11403 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11404 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11405 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11406 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11407 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11408 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11409 (Qgnutls_bootprop_callbacks_verify): Make static.
11411 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11413 * callproc.c: Indentation fixup.
11415 * sysdep.c (wait_for_termination_1): Make static.
11416 (wait_for_termination, interruptible_wait_for_termination):
11417 Move after wait_for_termination_1.
11419 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11421 * sysdep.c (interruptible_wait_for_termination): New function
11422 which is like wait_for_termination, but allows keyboard
11425 * callproc.c (Fcall_process): Add (:file "file") as an option for
11427 (Fcall_process_region): Ditto.
11429 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11431 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11432 rather than `XVECTOR (FOO)->size'.
11434 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11435 inttypes.h, as a gnulib replacement is used if it not available in
11438 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11440 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11441 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11442 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11444 * coding.c (coding_alloc_by_realloc): Error out if destination
11445 will grow beyond MOST_POSITIVE_FIXNUM.
11446 (decode_coding_emacs_mule): Abort if there isn't enough place in
11447 charbuf for the composition carryover bytes. Reserve an extra
11448 space for up to 2 characters produced in a loop.
11449 (decode_coding_iso_2022): Abort if there isn't enough place in
11450 charbuf for the composition carryover bytes.
11452 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11454 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11455 aborting when %lld or %lll format is passed.
11456 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11457 %llo or %llx format is passed. (Bug#8545)
11459 * window.c (window_scroll_line_based): Use a marker instead of
11460 simple variables to record original value of point. (Bug#7952)
11462 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11463 produced by %s or %c overflows available buffer space. (Bug#8545)
11465 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11467 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11468 (SIZE_MAX): Move defn after all includes, as they might #define it.
11470 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11472 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11474 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11476 * keyboard.c (Qdelayed_warnings_hook): Define.
11477 (command_loop_1): Run `delayed-warnings-hook'
11478 if Vdelayed_warnings_list is non-nil.
11479 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11480 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11482 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11484 * doprnt.c (doprnt): Don't return value smaller than the buffer
11485 size if the message was truncated. (Bug#8545).
11487 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11489 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11490 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11492 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11494 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11496 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11498 * makefile.w32-in: Update dependencies.
11500 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11502 Improve `doprnt' and its usage. (Bug#8545)
11503 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11504 `format_end'. Remove support for %l as a conversion specifier.
11505 Don't use xrealloc. Improve diagnostics when the %l size modifier
11506 is used. Update the commentary.
11508 * eval.c (verror): Simplify calculation of size_t.
11510 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11513 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11515 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11518 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11520 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11521 This makes this file independent of the recent pseudovector change.
11523 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11525 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11527 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11528 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11529 Remove unused local.
11530 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11532 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11533 GCC 4.6.0 optimizes based on type-based alias analysis.
11534 For example, if b is of type struct buffer * and v of type struct
11535 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11536 != &v->size, and therefore "v->size = 1; b->size = 2; return
11537 v->size;" must therefore return 1. This assumption is incorrect
11538 for Emacs, since it type-puns struct Lisp_Vector * with many other
11539 types. To fix this problem, this patch adds a new type struct
11540 vectorlike_header that documents the constraints on layout of vectors
11541 and pseudovectors, and helps optimizing compilers not get fooled
11542 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11543 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11544 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11546 (XSETPVECTYPE): Rewrite in terms of new macro.
11547 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11548 This is a bit clearer, and further avoids the possibility of
11549 undesirable aliasing.
11550 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11551 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11552 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11553 since Lisp_Subr is a special case (no "next" field).
11554 (ASIZE): Now uses header.size rather than size.
11555 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11556 to avoid the hassle of writing XVECTOR (foo)->header.size.
11557 (struct vectorlike_header): New type.
11558 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11559 object, to help avoid aliasing.
11560 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11561 (SUBRP): Likewise, since Lisp_Subr is a special case.
11562 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11563 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11564 (struct Lisp_Hash_Table): Combine first two members into a single
11565 struct vectorlike_header member. All uses of "size" and "next" members
11566 changed to be "header.size" and "header.next".
11567 * buffer.h (struct buffer): Likewise.
11568 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11569 * frame.h (struct frame): Likewise.
11570 * process.h (struct Lisp_Process): Likewise.
11571 * termhooks.h (struct terminal): Likewise.
11572 * window.c (struct save_window_data, struct saved_window): Likewise.
11573 * window.h (struct window): Likewise.
11574 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11575 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11576 * buffer.c (init_buffer_once): Likewise.
11577 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11579 * process.c (Fformat_network_address): Use local var for size,
11582 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11584 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11585 * data.c (atof): Remove decl; no longer used or needed.
11586 (digit_to_number): Move to lread.c.
11587 (Fstring_to_number): Use new string_to_number function, to be
11588 consistent with how the Lisp reader treats infinities and NaNs.
11589 Do not assume that floating-point numbers represent EMACS_INT
11590 without losing information; this is not true on most 64-bit hosts.
11591 Avoid double-rounding errors, by insisting on integers when
11592 parsing non-base-10 numbers, as the documentation specifies.
11593 * lisp.h (string_to_number): New decl, replacing ...
11594 (isfloat_string): Remove.
11595 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11596 (read1): Do not accept +. and -. as integers; this
11597 appears to have been a coding error. Similarly, do not accept
11598 strings like +-1e0 as floating point numbers. Do not report
11599 overflow for integer overflows unless the base is not 10 which
11600 means we have no simple and reliable way to continue.
11601 Break out the floating-point parsing into a new
11602 function string_to_number, so that Fstring_to_number parses
11603 floating point numbers consistently with the Lisp reader.
11604 (digit_to_number): Move here from data.c. Make it static inline.
11605 (E_CHAR, EXP_INT): Remove, replacing with ...
11606 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11607 (string_to_number): New function, replacing isfloat_string.
11608 This function checks for valid syntax and produces the resulting
11609 Lisp float number too. Rework it so that string-to-number
11610 no longer mishandles examples like "1.0e+". Use strtoumax,
11611 so that overflow for non-base-10 numbers is reported only when
11612 there's no portable and simple way to convert to floating point.
11614 * textprop.c (set_text_properties_1): Rewrite for clarity,
11615 and to avoid GCC warning about integer overflow.
11617 * intervals.h (struct interval): Use EMACS_INT for members
11618 where EMACS_UINT might cause problems. See
11619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11620 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11621 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11623 (offset_intervals): Tell GCC not to worry about length overflow
11624 when negating a negative length.
11626 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11627 (overrun_check_free): Likewise.
11629 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11630 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11633 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11634 (gnutls_make_error): Rename local to avoid shadowing.
11635 (gnutls_emacs_global_deinit): ifdef out; not used.
11636 (Fgnutls_boot): Use const for pointer to readonly storage.
11637 Comment out unused local. Fix pointer signedness problems.
11639 * lread.c (openp): Don't stuff size_t into an 'int'.
11640 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11641 about possible signed overflow.
11643 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11644 (GDK_KEY_g): Don't define if already defined.
11645 (xg_prepare_tooltip): Avoid pointer signedness problem.
11646 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11648 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11649 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11651 * xfns.c (Fx_window_property): Simplify a bit,
11652 to make a bit faster and to avoid GCC 4.6.0 warning.
11653 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11655 * fns.c (internal_equal): Don't assume size_t fits in int.
11657 * alloc.c (compact_small_strings): Tighten assertion a little.
11659 Replace pEd with more-general pI, and fix some printf arg casts.
11660 * lisp.h (pI): New macro, generalizing old pEd macro to other
11661 conversion specifiers. For example, use "...%"pI"d..." rather
11662 than "...%"pEd"...".
11663 (pEd): Remove. All uses replaced with similar uses of pI.
11664 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11665 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11666 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11667 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11668 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11669 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11670 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11672 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11673 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11674 * print.c (safe_debug_print, print_object): Likewise.
11675 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11677 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11678 avoiding the 0 flag, which is not portable.
11679 * process.c (Fmake_network_process): Use pI to avoid cast.
11680 * region-cache.c (pp_cache): Likewise.
11681 * xdisp.c (decode_mode_spec): Likewise.
11682 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11683 behavior on 64-bit hosts with printf arg.
11684 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11685 (x_stop_queuing_selection_requests): Likewise.
11686 (x_get_window_property): Don't truncate byte count to an 'int'
11689 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11690 here, since it parses constructs like leading '-' and spaces,
11691 which are not wanted; and it overflows with large numbers.
11692 Instead, simply match F[0-9]+, which is what is wanted anyway.
11694 * alloc.c: Remove unportable assumptions about struct layout.
11695 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11696 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11697 (allocate_vectorlike, make_pure_vector): Use the new macros,
11698 plus offsetof, to remove unportable assumptions about struct layout.
11699 These assumptions hold on all porting targets that I know of, but
11700 they are not guaranteed, they're easy to remove, and removing them
11701 makes further changes easier.
11703 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11704 This doesn't fix a bug but makes the code clearer.
11705 (string_overrun_cookie): Now const. Use initializers that
11706 don't formally overflow signed char, to avoid warnings.
11707 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11708 can cause Emacs to crash when string overrun checking is enabled.
11709 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11710 multiple of sizeof (EMACS_INT); it need not be, if
11711 alignof(EMACS_INT) < sizeof (EMACS_INT).
11712 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11714 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11716 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11718 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11720 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11721 supposed to be handshaking. (Bug#8556)
11722 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11724 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11726 * lisp.h (Qdebug): List symbol.
11727 * eval.c (Qdebug): Restore global linkage.
11728 * keyboard.c (debug-on-event): New variable.
11729 (handle_user_signal): Break into debugger when debug-on-event
11730 matches the current signal symbol.
11732 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11734 * alloc.c (check_sblock, check_string_bytes)
11735 (check_string_free_list): Convert to standard C.
11737 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11739 * w32.c (emacs_gnutls_push): Fix typo.
11741 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11743 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11744 "cast to pointer from integer of different size".
11746 Improve doprnt and its use in verror. (Bug#8545)
11747 * doprnt.c (doprnt): Document the set of format control sequences
11748 supported by the function. Use SAFE_ALLOCA instead of always
11751 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11752 is one byte too soon. Don't use xrealloc; instead xfree and
11755 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11757 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11760 * gnutls.c: Renamed global_initialized to
11761 gnutls_global_initialized. Added internals for the
11762 :verify-hostname-error, :verify-error, and :verify-flags
11763 parameters of `gnutls-boot' and documented those parameters in the
11764 docstring. Start callback support.
11765 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11766 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11767 on error. Return error code.
11768 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11769 (emacs_gnutls_read): Likewise.
11770 (Fgnutls_boot): Return handshake error code.
11771 (emacs_gnutls_handle_error): New function.
11772 (wsaerror_to_errno): Likewise.
11774 * w32.h (emacs_gnutls_pull): Add prototype.
11775 (emacs_gnutls_push): Likewise.
11777 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11778 (emacs_gnutls_push): Likewise.
11780 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11782 * process.c (wait_reading_process_output): Check if GnuTLS
11783 buffered some data internally if no FDs are set for TLS
11786 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11787 (LIBS): Link to USER_LIBS.
11788 ($(BLD)/gnutls.$(0)): New target.
11790 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11792 * xdisp.c (handle_single_display_spec): Rename the
11793 display_replaced_before_p argument into display_replaced_p, to
11794 make it consistent with the commentary. Fix typos in the
11797 * textprop.c (syms_of_textprop): Remove dead code.
11798 (copy_text_properties): Delete obsolete commentary about an
11799 interface that was deleted long ago. Fix typos in the description
11802 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11803 to changes in oldXMenu/XMenu.h from 2011-04-16.
11804 <menu_help_message, prev_menu_help_message>: Constify.
11805 (IT_menu_make_room): menu->help_text is now `const char **';
11808 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11809 to changes in oldXMenu/XMenu.h from 2011-04-16.
11810 (struct XMenu): Declare `help_text' `const char **'.
11812 * xfaces.c <Qunspecified>: Make extern again.
11814 * syntax.c: Include sys/types.h before including regex.h, as
11817 * doc.c (get_doc_string): Improve the format passed to `error'.
11819 * doprnt.c (doprnt): Improve commentary.
11821 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11823 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11826 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11827 changes in globals.h immediately force recompilation.
11828 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11829 $(CURDIR)/s/ms-w32.h.
11830 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11832 * character.c (Fchar_direction): Function deleted.
11833 (syms_of_character): Don't defsubr it.
11834 <char-direction-table>: Deleted.
11836 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11838 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11839 * doprnt.c: Include limits.h.
11840 (SIZE_MAX): New macro.
11841 (doprnt): Return a size_t value. 2nd arg is now size_t.
11842 Many local variables are now size_t instead of int or unsigned.
11843 Improve overflow protection. Support `l' modifier for integer
11844 conversions. Support %l conversion. Don't assume an EMACS_INT
11845 argument for integer conversions and for %c.
11847 * lisp.h (doprnt): Restore prototype.
11849 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11850 $(SRC)/character.h.
11852 * Makefile.in (base_obj): Add back doprnt.o.
11854 * deps.mk (doprnt.o): Add back prerequisites.
11855 (callint.o): Depend on character.h.
11857 * eval.c (internal_lisp_condition_case): Include the handler
11858 representation in the error message.
11859 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11860 when breaking from the loop.
11862 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11864 * callint.c (Fcall_interactively): When displaying error message
11865 about invalid control letter, pass the character's codepoint, not
11866 a pointer to its multibyte form. Improve display of the character
11867 in octal and display also its hex code.
11869 * character.c (char_string): Use %x to display the (unsigned)
11870 codepoint of an invalid character, to avoid displaying a bogus
11873 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11874 `error', not SYMBOL_NAME itself.
11876 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11877 character arguments to `error'.
11879 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11880 to `error' in error message about FINAL_CHAR argument. Make sure
11881 FINAL_CHAR is a character, and use %c when it is passed as
11882 argument to `error'.
11884 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11886 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11888 * w32.c: Include <time.h>.
11889 (sys_localtime): New function.
11891 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11893 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11895 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11897 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11899 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11900 zombies (Bug#8467).
11902 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11904 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11905 gl_state.e_property when gl_state.object is Qt.
11907 * insdel.c (make_gap_larger): Remove limitation of buffer size
11910 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11912 * xdisp.c (lookup_glyphless_char_display)
11913 (produce_glyphless_glyph): Handle cons cell entry in
11914 glyphless-char-display.
11915 (Vglyphless_char_display): Document it.
11917 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11918 glyphless-char-display.
11920 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11922 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11924 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11926 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11927 definition for no-X builds.
11929 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11931 Static checks with GCC 4.6.0 and non-default toolkits.
11933 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11935 * process.c (keyboard_bit_set): Define only if SIGIO.
11936 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11937 (send_process): Repair possible setjmp clobbering.
11939 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11941 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11943 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11945 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11946 Define only if needed.
11948 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11949 by pacifying GCC about it. Maybe it's time to retire it?
11950 * xfaces.c (USG, __TIMEVAL__): Likewise.
11952 * dispextern.h (struct redisplay_interface): Rename param
11953 to avoid shadowing.
11954 * termhooks.h (struct terminal): Likewise.
11955 * xterm.c (xembed_send_message): Likewise.
11957 * insdel.c (make_gap_smaller): Define only if
11958 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11960 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11963 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11964 so that we aren't warned about unused symbols.
11966 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11968 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11970 * xfns.c (x_real_positions): Mark locals as initialized.
11972 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11974 * xterm.c: Fix problems found by static analysis with other toolkits.
11975 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11976 (x_dispatch_event): Declare static if USE_GTK, and
11977 define if USE_GTK || USE_X_TOOLKIT.
11978 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11979 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11980 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11981 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11983 * xmenu.c (menu_help_callback): Pointer type fixes.
11984 Use const pointers when pointing at readonly data. Avoid pointer
11985 signedness clashes.
11986 (FALSE): Remove unused macro.
11987 (update_frame_menubar): Remove unused decl.
11989 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11991 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11992 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11993 (single_menu_item): Rename local to avoid shadowing.
11995 * keyboard.c (make_lispy_event): Remove unused local var.
11997 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11998 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12000 * bitmaps: Change bitmaps from unsigned char back to the X11
12001 compatible char. Avoid the old compiler warnings about
12002 out-of-range initializers by using, for example, '\xab' rather
12005 * xgselect.c (xgselect_initialize): Check vs interface
12006 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12008 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12010 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12011 to read-only memory.
12013 * fns.c (vector): Remove; this old hack is no longer needed.
12015 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12017 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12019 * xrdb.c (x_load_resources): Omit unused local.
12021 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12022 (x_window): Rename locals to avoid shadowing.
12023 (USG): Use the kludged USG macro, to pacify gcc.
12025 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12026 (x_term_init): Remove local to avoid shadowing.
12028 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12030 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12031 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12033 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12035 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12037 Fix regex.c, syntax.c and friends for buffers > 2GB.
12038 * syntax.h (struct gl_state_s): Declare character position members
12041 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12043 * textprop.c (verify_interval_modification, interval_of):
12044 Declare arguments EMACS_INT.
12046 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12049 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12051 * indent.c (Fvertical_motion): Local variable it_start is now
12054 * regex.c (re_match, re_match_2, re_match_2_internal)
12055 (bcmp_translate, regcomp, regexec, print_double_string)
12056 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12057 (re_compile_pattern, re_exec): Declare arguments and local
12058 variables `size_t' and `ssize_t' and return values `regoff_t', as
12060 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12061 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12062 <compile_stack_type>: `size' and `avail' are now `size_t'.
12064 * regex.h <regoff_t>: Use ssize_t, not int.
12065 (re_search, re_search_2, re_match, re_match_2): Arguments that
12066 specify buffer/string position and length are now ssize_t and
12067 size_t. Return type is regoff_t.
12069 2011-04-16 Ben Key <bkey76@gmail.com>
12071 * nsfont.m: Fixed bugs in ns_get_family and
12072 ns_descriptor_to_entity that were caused by using free to
12073 deallocate memory blocks that were allocated by xmalloc (via
12074 xstrdup). This caused Emacs to crash when compiled with
12075 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12076 --enable-checking=xmallocoverrun). xfree is now used to
12077 deallocate these memory blocks.
12079 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12081 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12083 emacs_write: Accept and return EMACS_INT for sizes.
12084 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12086 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12087 Accept and return EMACS_INT.
12088 (emacs_gnutls_write): Return the number of bytes written on
12090 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12091 (emacs_read, emacs_write): Remove check for negative size, as the
12092 Emacs source code has been audited now.
12093 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12094 (emacs_read, emacs_write): Use it.
12095 * process.c (send_process): Adjust to the new signatures of
12096 emacs_write and emacs_gnutls_write. Do not attempt to store
12097 a byte offset into an 'int'; it might overflow.
12098 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12100 * sound.c: Don't assume sizes fit in 'int'.
12101 (struct sound_device.period_size, alsa_period_size):
12102 Return EMACS_INT, not int.
12103 (struct sound_device.write, vox_write, alsa_write):
12104 Accept EMACS_INT, not int.
12105 (wav_play, au_play): Use EMACS_INT to store sizes and to
12106 record read return values.
12108 2011-04-15 Ben Key <bkey76@gmail.com>
12110 * keyboard.c (Qundefined): Don't declare static since it is used
12112 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12113 static since they are used in nsfont.m.
12115 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12117 * process.c (Qprocessp): Don't declare static.
12118 * lisp.h (Qprocessp): Declare again.
12120 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12122 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12124 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12126 Improve C-level modularity by making more things 'static'.
12128 Don't publish debugger-only interfaces to other modules.
12129 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12130 (verify_bytepos, count_markers): Move decls to the only modules
12132 * region-cache.h (pp_cache): Likewise.
12133 * window.h (check_all_windows): Likewise.
12134 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12136 * sysdep.c (croak): Now static, if
12137 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12138 * syssignal.h (croak): Declare only if not static.
12140 * alloc.c (refill_memory_reserve): Now static if
12141 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12142 * lisp.h (refill_memory_reserve): Declare only if not static.
12144 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12145 Define only if USE_LUCID.
12147 * xrdb.c (x_customization_string, x_rm_string): Now static.
12149 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12150 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12152 * xdisp.c (draw_row_with_mouse_face): Now static.
12153 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12155 * window.h (check_all_windows): Mark externally visible.
12157 * window.c (window_deletion_count): Now static.
12159 * undo.c: Make symbols static if they're not exported.
12160 (last_undo_buffer, last_boundary_position, pending_boundary):
12163 * textprop.c (interval_insert_behind_hooks): Now static.
12164 (interval_insert_in_front_hooks): Likewise.
12166 * term.c: Make symbols static if they're not exported.
12167 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12168 (max_frame_lines, tty_set_terminal_modes):
12169 (tty_reset_terminal_modes, tty_turn_off_highlight):
12170 (get_tty_terminal): Now static.
12171 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12172 * termhooks.h (term_mouse_moveto): Do not declare if
12173 HAVE_WINDOW_SYSTEM.
12174 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12175 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12177 * sysdep.c: Make symbols static if they're not exported.
12178 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12180 (sigprocmask_set, full_mask): Remove; unused.
12181 (wait_debugging): Mark as visible.
12182 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12183 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12185 * syntax.c (syntax_temp): Define only if !__GNUC__.
12187 * sound.c (current_sound_device, current_sound): Now static.
12189 * search.c (searchbufs, searchbuf_head): Now static.
12191 * scroll.c (scroll_cost): Remove; unused.
12192 * dispextern.h (scroll_cost): Remove decl.
12194 * region-cache.h (pp_cache): Mark as externally visible.
12196 * process.c: Make symbols static if they're not exported.
12197 (process_tick, update_tick, create_process, chan_process):
12198 (Vprocess_alist, proc_buffered_char, datagram_access):
12199 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12200 (deactivate_process): Mark defn as static, as well as decl.
12201 * lisp.h (create_process): Remove decl.
12202 * process.h (chan_process, Vprocess_alist): Remove decls.
12204 * print.c: Make symbols static if they're not exported.
12205 (print_depth, new_backquote_output, being_printed, print_buffer):
12206 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12207 (print_interval, print_number_index, initial_stderr_stream):
12209 * lisp.h (Fprinc): Remove decl.
12210 (debug_output_compilation_hack): Mark as externally visible.
12212 * sysdep.c (croak): Move decl from here to syssignal.h.
12213 * syssignal.h (croak): Put it here, so the API can be checked when
12214 'croak' is called from dissociate_if_controlling_tty.
12216 * minibuf.c: Make symbols static if they're not exported.
12217 (minibuf_save_list, choose_minibuf_frame): Now static.
12218 * lisp.h (choose_minibuf_frame): Remove decl.
12220 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12222 * lread.c: Make symbols static if they're not exported.
12223 (read_objects, initial_obarray, oblookup_last_bucket_number):
12225 (make_symbol): Remove; unused.
12226 * lisp.h (initial_obarray, make_symbol): Remove decls.
12228 * keyboard.c: Make symbols static if they're not exported.
12229 (single_kboard, recent_keys_index, total_keys, recent_keys):
12230 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12231 (this_single_command_key_start, echoing, last_auto_save):
12232 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12233 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12234 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12235 (Vlispy_mouse_stem, double_click_count):
12237 (force_auto_save_soon): Define only if SIGDANGER.
12238 (ignore_mouse_drag_p): Now static if
12239 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12240 (print_help): Remove; unused.
12241 (stop_character, last_timer_event): Mark as externally visible.
12242 * keyboard.h (ignore_mouse_drag_p): Declare only if
12243 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12244 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12245 * lisp.h (echoing): Remove decl.
12246 (force_auto_save_soon): Declare only if SIGDANGER.
12247 * xdisp.c (redisplay_window): Simplify code, to make it more
12248 obvious that ignore_mouse_drag_p is not accessed if !defined
12249 USE_GTK && !defined HAVE_NS.
12251 * intervals.c: Make symbols static if they're not exported.
12252 (merge_properties_sticky, merge_interval_right, delete_interval):
12254 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12256 * insdel.c: Make symbols static if they're not exported.
12257 However, leave prepare_to_modify_buffer alone. It's never
12258 called from outside this function, but that appears to be a bug.
12259 (combine_after_change_list, combine_after_change_buffer):
12260 (adjust_after_replace, signal_before_change): Now static.
12261 (adjust_after_replace_noundo): Remove; unused.
12262 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12263 (signal_before_change): Remove decls.
12265 * indent.c (val_compute_motion, val_vmotion): Now static.
12267 * image.c: Make symbols static if they're not exported.
12268 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12270 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12271 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12273 * fringe.c (standard_bitmaps): Now static.
12274 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12276 * frame.c: Make symbols static if they're not exported.
12277 (x_report_frame_params, make_terminal_frame): Now static.
12278 (get_frame_param): Now static, unless HAVE_NS.
12279 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12280 (x_get_resource_string): Remove; not used.
12281 * frame.h (make_terminal_frame, x_report_frame_params):
12282 (x_get_resource_string); Remove decls.
12283 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12284 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12286 * font.c, fontset.c: Make symbols static if they're not exported.
12287 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12288 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12289 * font.c (font_close_object): Now static.
12290 * font.h (font_close_object): Remove.
12291 * fontset.c (FONTSET_OBJLIST): Remove.
12292 (free_realized_fontset) #if-0 the body, which does nothing.
12293 (face_suitable_for_char_p): #if-0, as it's never called.
12294 * fontset.h (face_suitable_for_char_p): Remove decl.
12295 * xfaces.c (face_at_string_position):
12296 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12297 since 0 is always ASCII.
12299 * fns.c (weak_hash_tables): Now static.
12301 * fileio.c: Make symbols static if they're not exported.
12302 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12303 (Vwrite_region_annotation_buffers): Now static.
12305 * eval.c: Make symbols static if they're not exported.
12306 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12307 * lisp.h (backtrace_list): Remove decl.
12309 * emacs.c: Make symbols static if they're not exported.
12310 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12311 (fatal_error_code, fatal_error_signal_hook, standard_args):
12313 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12314 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12315 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12316 * lisp.h (fatal_error_signal_hook): Remove decl.
12317 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12319 * editfns.c: Move a (normally-unused) function to its only use.
12320 * editfns.c, lisp.h (get_operating_system_release): Remove.
12321 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12322 worth the hassle of breaking this out.
12324 * xterm.c: Make symbols static if they're not exported.
12325 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12326 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12327 (x_destroy_window, x_delete_display):
12329 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12330 (x_mouse_leave): Remove; unused.
12331 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12332 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12333 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12335 (x_mouse_leave): Declare only if WINDOWSNT.
12336 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12337 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12340 * ftxfont.c: Make symbols static if they're not exported.
12341 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12343 * font.h (ftxfont_driver): Likewise.
12345 * xfns.c: Make symbols static if they're not exported.
12346 (x_last_font_name, x_display_info_for_name):
12347 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12348 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12349 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12350 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12351 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12352 (last_show_tip_args): Now static.
12353 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12354 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12355 (x_screen_planes): Remove; unused.
12356 * dispextern.h (x_screen_planes): Remove decl.
12358 * dispnew.c: Make symbols static if they're not exported.
12359 * dispextern.h (redraw_garbaged_frames, scrolling):
12360 (increment_row_positions): Remove.
12361 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12362 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12364 (redraw_garbaged_frames): Remove; unused.
12366 * xfaces.c: Make symbols static if they're not exported.
12367 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12369 * xterm.h (defined_color): Remove decls.
12370 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12371 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12372 (menu_face_changed_default, defined_color, free_realized_face):
12373 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12374 (ascii_face_of_lisp_face): Remove; unused.
12376 * xdisp.c: Make symbols static if they're not exported.
12377 * dispextern.h (scratch_glyph_row, window_box_edges):
12378 (glyph_to_pixel_coords, set_cursor_from_row):
12379 (get_next_display_element, set_iterator_to_next):
12380 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12381 (show_mouse_face): Remove decls
12382 * frame.h (message_buf_print): Likewise.
12383 * lisp.h (pop_message, set_message, check_point_in_composition):
12385 * xterm.h (set_vertical_scroll_bar): Likewise.
12386 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12387 (message_buf_print, scratch_glyph_row, displayed_buffer):
12388 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12389 (get_next_display_element, show_mouse_face, window_box_edges):
12390 (frame_to_window_pixel_xy, check_point_in_composition):
12391 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12392 (glyph_to_pixel_coords): Remove; unused.
12394 * dired.c (file_name_completion): Now static.
12396 * dbusbind.c (xd_in_read_queued_messages): Now static.
12398 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12399 * data.c (circular_list_error): Remove.
12401 * commands.h (last_point_position, last_point_position_buffer):
12402 (last_point_position_window): Remove decls.
12403 * keyboard.c: Make these variables static.
12405 * coding.h (coding, code_convert_region, encode_coding_gap):
12407 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12408 (iso_code_class, detect_coding, code_convert_region): Now static.
12409 (encode_coding_gap): Remove; unused.
12411 * chartab.c (chartab_chars, chartab_bits): Now static.
12413 * charset.h (charset_iso_8859_1): Remove decl.
12414 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12417 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12418 * ccl.c (Vccl_program_table): Now static.
12419 (check_ccl_update): Remove; unused.
12421 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12422 * category.h: ... from here.
12423 * category.c (check_category_table, set_category_set): Now static.
12425 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12426 * lisp.h: Remove these decls.
12428 * buffer.c (buffer_count): Remove unused var.
12430 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12431 so that it's not optimized away.
12432 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12433 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12434 exported only to the debugger.
12436 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12437 * atimer.h (run_all_atimers): Remove; not exported.
12439 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12440 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12441 was inaccessible from Lisp.
12442 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12443 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12445 alloc.c: Import and export fewer symbols, and remove unused items.
12446 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12448 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12449 it's not optimized away by whole-program optimization.
12450 (message_enable_multibyte, free_misc): Remove.
12451 (catchlist, handlerlist, mark_backtrace):
12452 Declare only if BYTE_MARK_STACK.
12453 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12454 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12455 (message_enable_multibyte): Remove decl.
12456 (free_misc, interval_free_list, float_block, float_block_index):
12457 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12458 (cons_free_list, last_marked_index):
12460 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12461 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12462 (mark_backtrace): Define only if BYTE_MARK_STACK.
12463 * xdisp.c (message_enable_multibyte): Now static.
12465 Declare Lisp_Object Q* variables to be 'static' if not exported.
12466 This makes it easier for human readers (and static analyzers)
12467 to see whether these variables are used from other modules.
12468 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12469 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12470 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12471 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12472 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12473 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12474 * xmenu.c, xselect.c:
12475 Declare Q* vars static if they are not used in other modules.
12476 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12477 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12478 Remove decls of unexported vars.
12479 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12481 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12483 Make Emacs functions such as Fatom 'static' by default.
12484 This makes it easier for human readers (and static analyzers)
12485 to see whether these functions can be called from other modules.
12486 DEFUN now defines a static function. To make the function external
12487 so that it can be used in other C modules, use the new macro DEFUE.
12488 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12489 (Finit_image_library):
12490 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12491 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12492 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12493 Remove decls, since these functions are now static.
12494 (Funintern, Fget_internal_run_time): New decls, since these functions
12495 were already external.
12497 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12498 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12499 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12500 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12501 * keyboard.c, keymap.c, lread.c:
12502 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12503 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12504 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12505 Mark functions with DEFUE instead of DEFUN,
12506 if they are used in other modules.
12507 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12508 decls for now-static functions.
12509 * buffer.h (Fdelete_overlay): Remove decl.
12510 * callproc.c (Fgetenv_internal): Mark as internal.
12511 * composite.c (Fremove_list_of_text_properties): Remove decl.
12512 (Fcomposition_get_gstring): New forward static decl.
12513 * composite.h (Fcomposite_get_gstring): Remove decl.
12514 * dired.c (Ffile_attributes): New forward static decl.
12515 * doc.c (Fdocumntation_property): New forward static decl.
12516 * eval.c (Ffetch_bytecode): New forward static decl.
12517 (Funintern): Remove extern decl; now in .h file where it belongs.
12518 * fileio.c (Fmake_symbolic_link): New forward static decl.
12519 * image.c (Finit_image_library): New forward static decl.
12520 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12521 * intervals.h (Fprevious_property_change):
12522 (Fremove_list_of_text_properties): Remove decls.
12523 * keyboard.c (Fthis_command_keys): Remove decl.
12524 (Fcommand_execute): New forward static decl.
12525 * keymap.c (Flookup_key): New forward static decl.
12526 (Fcopy_keymap): Now static.
12527 * keymap.h (Flookup_key): Remove decl.
12528 * process.c (Fget_process): New forward static decl.
12529 (Fprocess_datagram_address): Mark as internal.
12530 * syntax.c (Fsyntax_table_p): New forward static decl.
12531 (skip_chars): Remove duplicate decl.
12532 * textprop.c (Fprevious_property_change): New forward static decl.
12533 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12535 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12536 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12538 * editfns.c (Fformat): Remove unreachable code.
12540 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12542 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12545 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12547 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12548 when at ZV. (Bug#8487)
12550 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12552 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12554 * keyboard.c (parse_tool_bar_item): Likewise.
12555 * sound.c (sound_cleanup, alsa_close): Likewise.
12556 * termcap.c (tgetent): Likewise.
12557 * xfns.c (x_default_font_parameter): Likewise.
12558 * xsettings.c (read_and_apply_settings): Likewise.
12560 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12561 (overrun_check_free): Protoize.
12563 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12565 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12566 since callers should never pass a negative size.
12567 Change the signature to match that of plain 'read' and 'write'; see
12568 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12569 * lisp.h: Update prototypes of emacs_write and emacs_read.
12571 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12573 * xdisp.c (redisplay_window): Don't try to determine the character
12574 position of the scroll margin if the window start point w->startp
12575 is outside the buffer's accessible region. (Bug#8468)
12577 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12579 Fix write-region and its subroutines for buffers > 2GB.
12580 * fileio.c (a_write, e_write): Modify declaration of arguments and
12581 local variables to support buffers larger than 2GB.
12582 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12584 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12585 argument, local variables, and return value.
12587 * lisp.h: Update prototypes of emacs_write and emacs_read.
12589 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12591 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12593 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12595 Fix more problems found by GCC 4.6.0's static checks.
12597 * xdisp.c (vmessage): Use a better test for character truncation.
12599 * charset.c (load_charset_map): <, not <=, for optimization,
12600 and to avoid potential problems with integer overflow.
12601 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12602 * casetab.c (set_identity, shuffle): Likewise.
12603 * editfns.c (Fformat): Likewise.
12604 * syntax.c (skip_chars): Likewise.
12606 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12607 This also lets GCC 4.6.0 generate slightly better loop code.
12609 * callint.c (Fcall_interactively): <, not <=, for optimization.
12610 (Fcall_interactively): Count the number of arguments produced,
12611 not the number of arguments given. This is simpler and lets GCC
12612 4.6.0 generate slightly better code.
12614 * ftfont.c: Distingish more carefully between FcChar8 and char.
12615 The previous code passed unsigned char * to a functions like
12616 strlen and xstrcasecmp that expect char *, which does not
12617 conform to the C standard.
12618 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12619 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12620 char * when the C standard requires it.
12622 * keyboard.c (read_char): Remove unused var.
12624 * eval.c: Port to Windows vsnprintf (Bug#8435).
12625 Include <limits.h>.
12626 (SIZE_MAX): Define if the headers do not.
12627 (verror): Do not give up if vsnprintf returns a negative count.
12628 Instead, grow the buffer. This ports to Windows vsnprintf, which
12629 does not conform to C99. Problem reported by Eli Zaretskii.
12630 Also, simplify the allocation scheme, by avoiding the need for
12631 calling realloc, and removing the ALLOCATED variable.
12633 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12635 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12636 But keep the doprint source code for now, as we might revamp it
12637 and use it again (Bug#8435).
12638 * lisp.h (doprnt): Remove.
12639 * Makefile.in (base_obj): Remove doprnt.o.
12640 * deps.mk (doprnt.o): Remove.
12642 error: Print 32- and 64-bit integers portably (Bug#8435).
12643 Without this change, on typical 64-bit hosts error ("...%d...", N)
12644 was used to print both 32- and 64-bit integers N, which relied on
12645 undefined behavior.
12646 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12647 * lisp.h (error, verror): Mark as printf-like functions.
12648 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12649 Report overflow in size calculations when allocating printf buffer.
12650 Do not truncate output string at its first null byte.
12651 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12652 Truncate the output at a character boundary, since vsnprintf does not
12654 * charset.c (check_iso_charset_parameter): Convert internal
12655 character to string before calling 'error', since %c now has the
12657 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12658 overflow when computing char to be passed to 'error'. Do not
12659 pass Lisp_Object to 'error'; pass the integer instead.
12660 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12661 formatted with plain %d.
12663 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12665 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12667 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12669 * xterm.c (x_catch_errors): Remove duplicate declaration.
12671 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12673 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12675 2011-04-10 Jim Meyering <meyering@redhat.com>
12677 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12678 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12679 return ssize_t not "int", and use size_t as the buffer length.
12680 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12681 * gnutls.h: Update declarations.
12682 * process.c (read_process_output): Use ssize_t, to match.
12683 (send_process): Likewise.
12685 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12687 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12689 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12691 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12692 Use unsigned char, to match FcChar8 type definition.
12694 * xterm.c (handle_one_xevent):
12695 * xmenu.c (create_and_show_popup_menu):
12696 * xselect.c (x_decline_selection_request)
12697 (x_reply_selection_request): Avoid type-punned deref of X events.
12699 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12701 Fix some uses of `int' instead of EMACS_INT.
12702 * search.c (string_match_1, fast_string_match)
12703 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12704 (scan_buffer, find_next_newline_no_quit)
12705 (find_before_next_newline, search_command, Freplace_match)
12706 (Fmatch_data): Make some `int' variables be EMACS_INT.
12708 * xdisp.c (display_count_lines): 3rd argument and return value now
12709 EMACS_INT. All callers changed.
12710 (pint2hrstr): Last argument is now EMACS_INT.
12712 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12713 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12714 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12715 (decode_coding_utf_16, decode_coding_emacs_mule)
12716 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12717 (decode_coding_ccl, decode_coding_charset)
12718 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12719 (decode_coding_iso_2022, decode_coding_emacs_mule)
12720 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12721 <char_offset, last_offset>: Declare EMACS_INT.
12722 (encode_coding_utf_8, encode_coding_utf_16)
12723 (encode_coding_emacs_mule, encode_invocation_designation)
12724 (encode_designation_at_bol, encode_coding_iso_2022)
12725 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12726 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12728 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12729 (encode_invocation_designation): Last argument P_NCHARS is now
12731 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12732 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12734 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12737 * ccl.c (Fccl_execute_on_string): Declare some variables
12740 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12742 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12744 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12746 * process.c (Fformat_network_address): Doc fix.
12748 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12750 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12752 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12754 * keyboard.c (read_char): Call Lisp function help-form-show,
12755 instead of using internal_with_output_to_temp_buffer.
12756 (Qhelp_form_show): New var.
12757 (syms_of_keyboard): Use DEFSYM macro.
12759 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12761 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12763 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12765 * process.c (Flist_processes): Remove to Lisp.
12766 (list_processes_1): Delete.
12768 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12770 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12772 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12774 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12776 Fix more problems found by GCC 4.6.0's static checks.
12778 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12780 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12782 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12784 * xdisp.c (vmessage): Mark as a printf-like function.
12786 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12788 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12790 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12791 printf-like functions.
12792 (tiff_load): Add casts to remove these marks before passing them
12793 to system-supplied API.
12795 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12797 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12798 This avoids several warnings with gcc -Wstrict-overflow.
12799 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12800 directly, rather than having caller test rule sign. This avoids
12801 some unnecessary tests.
12802 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12803 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12804 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12806 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12807 (xfont_open): Avoid unnecessary tests.
12809 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12811 * composite.h, composite.c (composition_gstring_put_cache):
12812 Use EMACS_INT, not int, for length.
12814 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12815 breaking out part of COMPOSITION_DECODE_RULE.
12816 (COMPOSITION_DECODE_RULE): Use it.
12817 * composite.c (get_composition_id): Remove unused local vars,
12818 by using the new macro.
12820 * textprop.c (set_text_properties_1): Change while to do-while,
12821 since the condition is always true at first.
12823 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12824 (interval_deletion_adjustment): Return unsigned value.
12827 * process.c (list_processes_1, create_pty, read_process_output):
12828 (exec_sentinel): Remove vars that were set but not used.
12829 (create_pty): Remove unnecessary "volatile"s.
12830 (Fnetwork_interface_info): Avoid possibility of int overflow.
12831 (read_process_output): Do adaptive read buffering even if carryover.
12832 (read_process_output): Simplify nbytes computation if buffered.
12834 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12836 * syntax.c (scan_words): Remove var that was set but not used.
12837 (update_syntax_table): Use unsigned instead of int.
12839 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12840 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12841 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12843 * print.c (print_error_message): Avoid int overflow.
12845 * font.c (font_list_entities): Redo for clarity,
12846 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12848 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12849 (font_score): Avoid potential overflow in diff calculation.
12851 * fns.c (substring_both): Remove var that is set but not used.
12852 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12854 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12856 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12857 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12858 can always succeed if overflow has undefined behavior.
12860 * search.c (boyer_moore, wordify): Remove vars set but not used.
12861 (wordify): Omit three unnecessary tests.
12863 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12864 All callers changed. This avoids the need for an unused var.
12866 * casefiddle.c (casify_region): Remove var that is set but not used.
12868 * dired.c (file_name_completion): Remove var that is set but not used.
12870 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12872 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12873 (Finsert_file_contents): Remove unnecessary code checking fd.
12875 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12876 Check for integer overflow on size calculations.
12878 * buffer.c (Fprevious_overlay_change): Remove var that is set
12881 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12882 Remove vars that are set but not used.
12883 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12884 (timer_check_2): Mark vars as initialized.
12886 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12888 * image.c (lookup_image): Remove var that is set but not used.
12889 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12891 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12892 that are set but not used.
12894 * xfns.c (make_invisible_cursor): Don't return garbage
12895 if XCreateBitmapFromData fails (Bug#8410).
12897 * xselect.c (x_get_local_selection, x_handle_property_notify):
12898 Remove vars that are set but not used.
12900 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12901 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12903 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12904 Remove var that is set but not used.
12905 (scroll_bar_windows_size): Now size_t, not int.
12906 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12907 Check for overflow.
12909 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12910 (map_tty_color) [!defined MSDOS]: Likewise.
12912 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12914 * coding.c: Remove vars that are set but not used.
12915 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12916 All callers changed.
12917 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12918 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12919 (decode_coding_charset): Remove vars that are set but not used.
12921 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12922 that is set but not used.
12924 * print.c (print_object): Remove var that is set but not used.
12926 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12927 The gnulib version avoids calling malloc in the usual case,
12928 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12929 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12930 * filelock.c (current_lock_owner): Likewise.
12931 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12932 * sysdep.c: Include allocator.h, careadlinkat.h.
12933 (emacs_no_realloc_allocator): New static constant.
12934 (emacs_readlink): New function.
12935 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12936 ../lib/careadlinkat.h.
12938 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12940 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12941 first non-nil return value).
12943 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12945 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12946 if not defined (Bug#8403).
12948 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12950 * xdisp.c (display_count_lines): Remove parameter `start',
12951 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12952 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12953 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12954 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12955 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12956 and thereabouts. All callers changed.
12957 (get_per_char_metric): Remove parameter `f', unused since
12958 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12960 2011-04-02 Jim Meyering <meyering@redhat.com>
12962 do not dereference NULL upon failed strdup
12963 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12964 (ns_get_family): Likewise.
12966 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12968 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12970 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12972 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12975 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12977 Add lexical binding.
12979 * window.c (Ftemp_output_buffer_show): New fun.
12980 (Fsave_window_excursion):
12981 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12983 * lread.c (lisp_file_lexically_bound_p): New function.
12984 (Fload): Bind Qlexical_binding.
12985 (readevalloop): Remove `evalfun' arg.
12986 Bind Qinternal_interpreter_environment.
12987 (Feval_buffer): Bind Qlexical_binding.
12988 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12990 (syms_of_lread): Declare `lexical-binding'.
12992 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12994 * keyboard.c (eval_dyn): New fun.
12995 (menu_item_eval_property): Use it.
12997 * image.c (parse_image_spec): Use Ffunctionp.
12999 * fns.c (concat, mapcar1): Accept byte-code-functions.
13001 * eval.c (Fsetq): Handle lexical vars.
13002 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13003 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13004 (FletX, Flet): Obey lexical binding.
13005 (Fcommandp): Handle closures.
13006 (Feval): New `lexical' arg.
13007 (eval_sub): New function extracted from Feval. Use it almost
13008 everywhere where Feval was used. Look up vars in lexical env.
13010 (Ffunctionp): Move from subr.el.
13011 (Ffuncall): Handle closures.
13012 (apply_lambda): Remove `eval_flags'.
13013 (funcall_lambda): Handle closures and new byte-code-functions.
13014 (Fspecial_variable_p): New function.
13015 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13016 but without exporting it to Lisp.
13018 * doc.c (Fdocumentation, store_function_docstring):
13019 * data.c (Finteractive_form): Handle closures.
13021 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13024 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13026 (exec_byte_code): New function extracted from Fbyte_code to handle new
13027 calling convention for byte-code-functions. Add new byte-codes.
13029 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13031 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13033 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13035 * xdisp.c (redisplay_internal): Fix prototype.
13037 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13039 * xdisp.c (SCROLL_LIMIT): New macro.
13040 (try_scrolling): Use it when setting scroll_limit.
13041 Limit scrolling to 100 screen lines.
13042 (redisplay_window): Even when falling back on "recentering",
13043 position point in the window according to scroll-conservatively,
13044 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13046 (try_scrolling): When point is above the window, allow searching
13047 as far as scroll_max, or one screenful, to compute vertical
13048 distance from PT to the scroll margin position. This prevents
13049 try_scrolling from unnecessarily failing when
13050 scroll-conservatively is set to a value slightly larger than the
13051 window height. Clean up the case of PT below the margin at bottom
13052 of window: scroll_max can no longer be INT_MAX. When aggressive
13053 scrolling is in use, don't let point enter the opposite scroll
13054 margin as result of the scroll.
13055 (syms_of_xdisp) <scroll-conservatively>: Document the
13056 threshold of 100 lines for never-recentering scrolling.
13058 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13060 * dispextern.h (move_it_by_lines):
13061 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13062 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13063 (message_log_check_duplicate): Remove parameters `prev_bol' and
13064 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13065 (redisplay_internal): Remove parameter `preserve_echo_area',
13066 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13068 * indent.c (Fvertical_motion):
13069 * window.c (window_scroll_pixel_based, Frecenter):
13070 Don't pass `need_y_p' to `move_it_by_lines'.
13072 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13074 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13075 steal a few bits to be more compact.
13076 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13077 Remove unneeded casts.
13079 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13081 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13083 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13084 binding" message (bug#7967).
13086 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13088 Fix more problems found by GCC 4.6.0's static checks.
13090 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13091 Remove unused local var.
13093 * editfns.c (Fmessage_box): Remove unused local var.
13095 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13096 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13097 Omit unused local vars.
13098 * window.c (shrink_windows): Omit unused local var.
13099 * menu.c (digest_single_submenu): Omit unused local var.
13100 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13101 Omit unused local var.
13103 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13104 Don't assume string length fits in int.
13105 (keyremap_step, read_key_sequence): Use size_t for sizes.
13106 (read_key_sequence): Don't check last_real_key_start redundantly.
13108 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13109 instead of alloca (Bug#8344).
13111 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13112 (Fbacktrace_frame): Don't assume nframes fits in int.
13114 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13116 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13119 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13121 * cm.c (calccost): Turn while-do into do-while, for clarity.
13123 * keyboard.c (syms_of_keyboard): Use the same style as later
13124 in this function when indexing through an array. This also
13125 works around GCC bug 48267.
13127 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13129 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13131 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13132 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13134 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13135 This avoids undefined behavior on integer overflow, and is a bit
13136 more convenient anyway since it is compared to a size_t variable.
13138 Variadic C functions now count arguments with size_t, not int.
13139 This avoids an unnecessary limitation on 64-bit machines, which
13140 caused (substring ...) to crash on large vectors (Bug#8344).
13141 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13142 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13143 All variadic functions and their callers changed accordingly.
13144 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13145 * data.c (arith_driver, float_arith_driver): Likewise.
13146 * editfns.c (general_insert_function): Likewise.
13147 * eval.c (struct backtrace.nargs, interactive_p)
13148 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13149 (funcall_lambda, mark_backtrace): Likewise.
13150 * fns.c (concat): Likewise.
13151 * frame.c (x_set_frame_parameters): Likewise.
13152 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13153 0 if not found, not -1. All callers changed.
13155 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13156 (stack_copy_size): Now size_t, not int.
13157 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13159 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13161 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13162 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13163 All callers changed.
13165 * lisp.h (multibyte_char_to_unibyte):
13166 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13167 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13168 * character.h (CHAR_TO_BYTE8):
13169 * cmds.c (internal_self_insert):
13170 * editfns.c (general_insert_function):
13171 * keymap.c (push_key_description):
13172 * search.c (Freplace_match):
13173 * xdisp.c (message_dolog, set_message_1): All callers changed.
13175 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13177 * keyboard.c (safe_run_hook_funcall): New function.
13178 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13179 don't set the hook to nil, but remove the offending function instead.
13180 (Qcommand_hook_internal): Remove, unused.
13181 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13182 Vcommand_hook_internal.
13184 * eval.c (enum run_hooks_condition): Remove.
13185 (funcall_nil, funcall_not): New functions.
13186 (run_hook_with_args): Call each function through a `funcall' argument.
13187 Remove `cond' argument, now redundant.
13188 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13189 (Frun_hook_with_args_until_failure): Adjust accordingly.
13190 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13192 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13194 * dispextern.h (string_buffer_position): Remove declaration.
13196 * print.c (strout): Remove parameter `multibyte', unused since
13197 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13199 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13200 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13201 All callers changed.
13203 * w32.c (_wsa_errlist): Use braces for struct initializers.
13205 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13206 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13207 All callers changed.
13208 (string_buffer_position): Likewise. Also, make static (it's never
13209 used outside xdisp.c).
13210 (cursor_row_p): Remove parameter `w', unused since
13211 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13212 (decode_mode_spec): Remove parameter `precision', introduced during
13213 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13214 All callers changed.
13216 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13218 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13220 2011-03-27 Anders Lindgren <andlind@gmail.com>
13222 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13223 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13224 (ns_update_auto_hide_menu_bar): New functions.
13225 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13226 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13227 ns_constrain_all_frames.
13228 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13229 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13231 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13233 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13235 2011-03-27 Glenn Morris <rgm@gnu.org>
13237 * syssignal.h: Replace RETSIGTYPE with void.
13238 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13239 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13240 Replace SIGTYPE with void everywhere.
13241 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13242 * s/template.h (SIGTYPE): Remove commented out definition.
13244 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13246 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13247 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13249 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13251 * w32.c (read_unc_volume): Use parameter `henum', instead of
13252 global variable `wget_enum_handle'.
13254 * keymap.c (describe_vector): Remove parameters `indices' and
13255 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13256 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13258 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13260 * keyboard.c (timer_check): Remove parameter `do_it_now',
13261 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13262 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13263 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13265 * keyboard.c (read_char):
13266 * w32menu.c (w32_menu_display_help):
13267 * xmenu.c (show_help_event, menu_help_callback):
13268 Adjust calls to `show_help_echo'.
13270 * gtkutil.c (xg_maybe_add_timer):
13271 * keyboard.c (readable_events):
13272 * process.c (wait_reading_process_output):
13273 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13275 * insdel.c (adjust_markers_gap_motion):
13276 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13277 (gap_left, gap_right): Don't call it.
13279 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13281 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13282 incurred during fontification.
13284 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13286 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13287 (DEFVAR_PER_BUFFER): Don't pass it.
13289 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13290 (scrolling_window): Don't pass it.
13292 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13294 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13296 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13298 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13299 of variables specific to SELinux and computation of `encoded_absname'.
13301 * image.c (XPutPixel): Remove unused variable `height'.
13303 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13305 * unexw32.c (get_section_info): Remove unused variable `section'.
13307 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13308 (system_process_attributes): Remove unused variable `sess'.
13309 (sys_read): Remove unused variable `err'.
13311 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13312 (w32_wnd_proc): Remove unused variable `isdead'.
13313 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13314 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13315 (x_create_tip_frame): Remove unused variable `tem'.
13317 * w32inevt.c (w32_console_read_socket):
13318 Remove unused variable `no_events'.
13320 * w32term.c (x_draw_composite_glyph_string_foreground):
13321 Remove unused variable `width'.
13323 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13325 * w32term.c (x_set_glyph_string_clipping):
13326 Don't pass uninitialized region to CombineRgn.
13328 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13330 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13331 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13332 (Fx_close_connection): Remove unused variable `i'.
13334 * w32font.c (w32font_draw): Return number of glyphs.
13335 (w32font_open_internal): Remove unused variable `i'.
13336 (w32font_driver): Add missing initializer.
13338 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13339 (fill_in_menu): Remove unused variable `items_added'.
13341 * w32term.c (last_mouse_press_frame): Remove static global variable.
13342 (w32_clip_to_row): Remove unused variable `f'.
13343 (x_delete_terminal): Remove unused variable `i'.
13345 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13346 (NOTHING): Remove unused static global variable.
13347 (uniscribe_check_otf): Remove unused variable `table'.
13348 (uniscribe_font_driver): Add missing initializers.
13350 2011-03-23 Julien Danjou <julien@danjou.info>
13352 * term.c (Fsuspend_tty, Fresume_tty):
13353 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13354 * window.c (temp_output_buffer_show):
13355 * insdel.c (signal_before_change):
13356 * frame.c (Fhandle_switch_frame):
13357 * fileio.c (Fdo_auto_save):
13358 * emacs.c (Fkill_emacs):
13359 * editfns.c (save_excursion_restore):
13360 * cmds.c (internal_self_insert):
13361 * callint.c (Fcall_interactively):
13362 * buffer.c (Fkill_all_local_variables):
13363 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13365 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13366 unconditionally since it does the check itself.
13368 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13370 Fix more problems found by GCC 4.5.2's static checks.
13372 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13373 the first time through the loop, since we know p0 < p1 then.
13374 This also avoids a gcc -Wstrict-overflow warning.
13376 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13377 leading to a memory leak, possible in functions like
13378 load_charset_map_from_file that can allocate an unbounded number
13379 of objects (Bug#8318).
13381 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13382 that could (at least in theory) be that large.
13384 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13385 This is less likely to overflow, and avoids undefined behavior if
13386 overflow does occur. All callers changed. Use strtoul to scan
13387 for the unsigned long integer.
13388 (pint2hrstr): Simplify and tune code slightly.
13389 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13391 * scroll.c (do_scrolling): Work around GCC bug 48228.
13392 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13394 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13395 This also avoids a warning with gcc -Wstrict-overflow.
13396 (validate_x_resource_name): Simplify count usage.
13397 This also avoids a warning with gcc -Wstrict-overflow.
13399 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13402 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13404 * process.c (Fmake_network_process): Use socklen_t, not int,
13405 where POSIX says socklen_t is required in portable programs.
13406 This fixes a porting bug on hosts like 64-bit HP-UX, where
13407 socklen_t is wider than int (Bug#8277).
13408 (Fmake_network_process, server_accept_connection):
13409 (wait_reading_process_output, read_process_output):
13412 * process.c: Rename or move locals to avoid shadowing.
13413 (list_processes_1, Fmake_network_process):
13414 (read_process_output_error_handler, exec_sentinel_error_handler):
13415 Rename or move locals.
13416 (Fmake_network_process): Define label "retry_connect" only if needed.
13417 (Fnetwork_interface_info): Fix pointer signedness.
13418 (process_send_signal): Add cast to avoid pointer signedness problem.
13419 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13420 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13422 Make tparam.h and terminfo.c consistent.
13423 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13424 Include tparam.h instead, since it declares them.
13425 * cm.h (PC): Remove extern decl; tparam.h now does this.
13426 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13427 * terminfo.c: Include tparam.h, to check interfaces.
13428 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13429 (tparam): Adjust signature to match interface in tparam.h;
13430 this removes some undefined behavior. Check that outstring and len
13431 are zero, which they always are with Emacs.
13432 * tparam.h (PC, BC, UP): New extern decls.
13434 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13435 (xftfont_open): Rename locals to avoid shadowing.
13437 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13438 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13439 (OTF_TAG_SYM): Omit macro if not needed.
13440 (ftfont_list): Remove unused local.
13441 (get_adstyle_property, ftfont_pattern_entity):
13442 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13443 Rename locals to avoid shadowing.
13445 * xfont.c (xfont_list_family): Mark var as initialized.
13447 * xml.c (make_dom): Now static.
13449 * composite.c (composition_compute_stop_pos): Rename local to
13451 (composition_reseat_it): Remove unused locals.
13452 (find_automatic_composition, composition_adjust_point): Likewise.
13453 (composition_update_it): Mark var as initialized.
13454 (find_automatic_composition): Mark vars as initialized,
13455 with a FIXME (Bug#8290).
13457 character.h: Rename locals to avoid shadowing.
13458 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13459 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13460 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13461 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13462 to avoid shadowing.
13464 * textprop.c (property_change_between_p): Remove; unused.
13466 * intervals.c (interval_start_pos): Now static.
13468 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13470 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13471 Rename locals to avoid shadowing.
13473 * sound.c (wav_play, au_play, Fplay_sound_internal):
13474 Fix pointer signedness.
13475 (alsa_choose_format): Remove unused local var.
13476 (wav_play): Initialize a variable to 0, to prevent undefined
13477 behavior (Bug#8278).
13479 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13481 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13483 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13484 clobbering (Bug#8298).
13485 * sysdep.c (sys_subshell): Likewise.
13486 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13488 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13489 This should get cleaned up, so that child_setup has the
13490 same signature on all platforms.
13492 * callproc.c (call_process_cleanup): Now static.
13493 (relocate_fd): Rename locals to avoid shadowing.
13495 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13497 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13498 not to be necessary, and produces flickering.
13500 2011-03-20 Glenn Morris <rgm@gnu.org>
13502 * config.in: Remove file.
13504 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13506 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13507 are now in src/globals.h.
13508 (syms_of_minibuf): Remove spurious & from previous change.
13510 2011-03-20 Leo Liu <sdl.web@gmail.com>
13512 * minibuf.c (completing-read-function): New variable.
13513 (completing-read-default): Rename from completing-read.
13514 (completing-read): Call completing-read-function.
13516 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13518 * xfaces.c (Fx_load_color_file):
13519 Read color file from absolute filename (bug#8250).
13521 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13523 * makefile.w32-in: Update dependencies.
13525 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13527 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13529 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13531 Fix more problems found by GCC 4.5.2's static checks.
13533 * process.c (make_serial_process_unwind, send_process_trap):
13534 (sigchld_handler): Now static.
13536 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13537 That way, the code declares only the vars that it needs.
13538 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13539 * s/cygwin.h (PTY_ITERATION): Likewise.
13540 * s/darwin.h (PTY_ITERATION): Likewise.
13541 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13543 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13544 * process.c (allocate_pty): Don't declare stb unless it's needed.
13546 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13547 (CONSTANTLIM): Remove; unused.
13548 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13549 Define only if needed.
13551 * unexelf.c (unexec): Name an expression,
13552 to avoid gcc -Wbad-function-cast warning.
13553 Use a different way to cause a compilation error if anyone uses
13554 n rather than nn, a way that does not involve shadowing.
13555 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13557 * deps.mk (unexalpha.o): Remove; unused.
13559 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13560 * unexec.h: New file.
13561 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13562 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13563 Depend on unexec.h.
13564 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13565 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13566 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13567 Change as necessary to match prototype in unexec.h.
13569 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13571 (back_comment, skip_chars): Mark vars as initialized.
13573 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13574 Rename locals to avoid shadowing.
13576 * lread.c (read1): Rewrite so as not to use empty "else".
13577 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13579 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13581 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13582 warning when compiling print.c.
13584 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13585 instead of using an uninitialized var.
13586 (font_sort_entities): Mark var as initialized.
13588 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13590 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13591 pointers to constants.
13592 (font_parse_fcname): Remove unused vars.
13593 (font_delete_unmatched): Now static.
13594 (font_get_spec): Remove; unused.
13595 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13596 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13597 Rename or move locals to avoid shadowing.
13599 * fns.c (require_nesting_list, require_unwind): Now static.
13600 (Ffillarray): Rename locals to avoid shadowing.
13602 * floatfns.c (domain_error2): Define only if needed.
13603 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13605 * alloc.c (mark_backtrace): Move decl from here ...
13606 * lisp.h: ... to here, so that it can be checked.
13608 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13609 (Fdefvar): Rewrite so as not to use empty "else".
13610 (lisp_indirect_variable): Name an expression,
13611 to avoid gcc -Wbad-function-cast warning.
13612 (Fdefvar): Rename locals to avoid shadowing.
13614 * callint.c (quotify_arg, quotify_args): Now static.
13615 (Fcall_interactively): Rename locals to avoid shadowing.
13616 Use const pointer when appropriate.
13618 * lisp.h (get_system_name, get_operating_system_release):
13619 Move decls here, to check interfaces.
13620 * process.c (get_operating_system_release): Move decl to lisp.h.
13621 * xrdb.c (get_system_name): Likewise.
13622 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13623 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13624 some of which prompt warnings from gcc -Wbad-function-cast.
13625 (Fformat_time_string, Fencode_time, Finsert_char):
13626 (Ftranslate_region_internal, Fformat):
13627 Rename or remove local vars to avoid shadowing.
13628 (Ftranslate_region_internal): Mark var as initialized.
13630 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13633 * lisp.h (eassert): Check that the argument compiles, even if
13634 ENABLE_CHECKING is not defined.
13636 * data.c (Findirect_variable): Name an expression, to avoid
13637 gcc -Wbad-function-cast warning.
13638 (default_value, arithcompare, arith_driver, arith_error): Now static.
13639 (store_symval_forwarding): Rename local to avoid shadowing.
13640 (Fmake_variable_buffer_local, Fmake_local_variable):
13641 Mark variables as initialized.
13642 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13644 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13645 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13646 Rename locals to avoid shadowing.
13647 (mark_stack): Move local variables into the #ifdef region where
13649 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13650 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13652 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13653 (GC_STRING_CHARS): Remove; not used.
13654 (Fmemory_limit): Cast sbrk's returned value to char *.
13656 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13657 avoids undefined behavior in theory.
13659 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13661 Use functions, not macros, for up- and down-casing (Bug#8254).
13662 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13663 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13664 to use the following functions instead of these macros.
13665 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13666 EMACS_INT, since callers assume the returned value fits in int.
13667 (upcase1): Likewise, for UPCASE_TABLE.
13668 (uppercasep, lowercasep, upcase): New static inline functions.
13669 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13670 the race-condition problem in the old DOWNCASE.
13672 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13673 Rename locals to avoid shadowing.
13674 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13675 (regex_compile, re_search_2, re_match_2_internal):
13676 Remove unused local vars.
13677 (FREE_VAR): Rewrite so as not to use empty "else",
13678 which gcc can warn about.
13679 (regex_compile, re_match_2_internal): Mark locals as initialized.
13680 (RETALLOC_IF): Define only if needed.
13681 (WORDCHAR_P): Likewise. This one is never needed, but is used
13682 only in a comment talking about a compiler bug, so put inside
13683 the #if 0 of that comment.
13684 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13685 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13688 * search.c (boyer_moore): Rename locals to avoid shadowing.
13689 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13690 (PREV_CHAR_BOUNDARY): Likewise.
13692 * search.c (simple_search): Remove unused var.
13694 * dired.c (compile_pattern): Move decl from here ...
13695 * lisp.h: ... to here, so that it can be checked.
13696 (struct re_registers): New forward decl.
13698 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13700 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13702 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13703 Rename locals to avoid shadowing.
13704 (Fvertical_motion): Mark locals as initialized.
13706 * casefiddle.c (casify_object, casify_region): Now static.
13707 (casify_region): Mark local as initialized.
13709 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13711 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13712 New macros, so that the caller can use some names other than
13713 gcpro1, gcpro2, etc.
13714 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13716 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13717 argument, for consistency with GCPRO2_VAR, etc: it is now the
13718 prefix of the variable, not the variable itself. All uses
13720 * dired.c (directory_files_internal, file_name_completion):
13721 Rename locals to avoid shadowing.
13723 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13724 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13725 dired.c's scmp function, had undefined behavior.
13726 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13727 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13728 * buffer.h: ... to here, because these macros use current_buffer,
13729 and the new implementation with inline functions needs to have
13730 current_buffer in scope now, rather than later when the macros
13732 (downcase, upcase1): New static inline functions.
13733 (DOWNCASE, UPCASE1): Reimplement using these functions.
13734 This avoids undefined behavior in expressions like
13735 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13736 from race conditions in accessing the global variables
13737 case_temp1 and case_temp2.
13738 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13739 * lisp.h (case_temp1, case_temp2): Remove their decls.
13740 * character.h (ASCII_CHAR_P): Move from here ...
13741 * lisp.h: ... to here, so that the inline functions mentioned
13742 above can use them.
13744 * dired.c (directory_files_internal_unwind): Now static.
13746 * fileio.c (file_name_as_directory, directory_file_name):
13747 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13749 (file_name_as_directory): Use const pointers when appropriate.
13750 (Fexpand_file_name): Likewise. In particular, newdir might
13751 point at constant storage, so make it a const pointer.
13752 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13753 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13755 (Fset_file_times, Finsert_file_contents, auto_save_error):
13756 Rename locals to avoid shadowing.
13758 * minibuf.c (choose_minibuf_frame_1): Now static.
13759 (Ftry_completion, Fall_completions): Rename or remove locals
13760 to avoid shadowing.
13762 * marker.c (bytepos_to_charpos): Remove; unused.
13764 * lisp.h (verify_bytepos, count_markers): New decls,
13765 so that gcc does not warn that these functions aren't declared.
13767 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13768 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13769 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13770 (copy_text): Remove unused local var.
13772 * filelock.c (within_one_second): Now static.
13773 (lock_file_1): Rename local to avoid shadowing.
13775 * buffer.c (fix_overlays_before): Mark locals as initialized.
13776 (fix_start_end_in_overlays): Likewise. This function should be
13777 simplified by using pointers-to-pointers, but that's a different
13779 (switch_to_buffer_1): Now static.
13780 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13781 (report_overlay_modification): Rename locals to avoid shadowing.
13783 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13784 Fix pointer signedness issue.
13785 (sys_subshell): Mark local as volatile if checking for lint,
13786 to suppress a gcc -Wclobbered warning that does not seem to be right.
13787 (MAXPATHLEN): Define only if needed.
13789 * process.c (serial_open, serial_configure): Move decls from here ...
13790 * systty.h: ... to here, so that they can be checked.
13792 * fns.c (get_random, seed_random): Move extern decls from here ...
13793 * lisp.h: ... to here, so that they can be checked.
13795 * sysdep.c (reset_io): Now static.
13796 (wait_for_termination_signal): Remove; unused.
13798 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13799 (copy_keymap_item, append_key, push_text_char_description):
13801 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13802 (DENSE_TABLE_SIZE): Remove; unused.
13803 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13804 (describe_map_tree):
13805 Rename locals to avoid shadowing.
13807 * keyboard.c: Declare functions static if they are not used elsewhere.
13808 (echo_char, echo_dash, cmd_error, top_level_2):
13809 (poll_for_input, handle_async_input): Now static.
13810 (read_char, kbd_buffer_get_event, make_lispy_position):
13811 (make_lispy_event, make_lispy_movement, apply_modifiers):
13812 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13813 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13814 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13815 (read_key_sequence, read_char): Mark locals as initialized.
13816 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13818 * keyboard.h (make_ctrl_char): New decl.
13819 (mark_kboards): Move decl here ...
13820 * alloc.c (mark_kboards): ... from here.
13822 * lisp.h (force_auto_save_soon): New decl.
13824 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13825 (DEFINE_DUMMY_FUNCTION): New macro.
13826 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13828 (main): Add casts to avoid warnings
13829 if GCC considers string literals to be constants.
13831 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13833 * dbusbind.c: Pointer signedness fixes.
13834 (xd_signature, xd_append_arg, xd_initialize):
13835 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13836 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13837 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13838 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13840 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13841 if GCC considers string literals to be constants.
13842 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13844 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13846 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13847 (print_preprocess, print_object): New macro to fix last change.
13849 * print.c (print_preprocess): Don't forget font objects.
13851 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13853 * emacs.c (USAGE3): Doc fixes.
13855 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13857 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13860 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13862 * lisp.h (VWindow_system, Qfile_name_history):
13863 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13864 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13865 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13867 * w32select.c: Don't #include "keyboard.h".
13868 (run_protected): Add extern declaration for waiting_for_input.
13870 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13871 * w32console.c (detect_input_pending, read_input_pending)
13872 (encode_terminal_code):
13873 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13874 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13875 (w32_system_caret_y, Qfile_name_history):
13876 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13877 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13878 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13879 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13880 * w32proc.c (Qlocal, report_file_error):
13881 * w32term.c (Vwindow_system, updating_frame):
13882 * w32uniscribe.c (initialized, uniscribe_font_driver):
13883 Remove unneeded extern declarations.
13885 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13887 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13889 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13891 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13892 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13893 These macros can no longer be used for assignment.
13895 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13896 Assign struct members directly, instead of using BUF_BEGV etc.
13897 (record_buffer_markers, fetch_buffer_markers): New functions for
13898 recording and fetching special buffer markers.
13899 (set_buffer_internal_1, set_buffer_temp): Use them.
13901 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13903 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13905 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13906 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13908 * xdisp.c (hscroll_window_tree):
13909 (reconsider_clip_changes): Use PT instead of BUF_PT.
13911 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13913 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13914 $(EMACS_ROOT)/lib/intprops.h.
13916 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13918 Fix more problems found by GCC 4.5.2's static checks.
13920 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13921 to unsigned char * to avoid compiler diagnostic.
13922 (xg_free_frame_widgets): Make it clear that a local variable is
13923 needed only if USE_GTK_TOOLTIP.
13924 (gdk_window_get_screen): Make it clear that this macro is needed
13925 only if USE_GTK_TOOLTIP.
13926 (int_gtk_range_get_value): New function, which avoids a diagnostic
13927 from gcc -Wbad-function-cast.
13928 (xg_set_toolkit_scroll_bar_thumb): Use it.
13929 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13930 diagnostic from gcc -Wbad-function-cast.
13931 (get_utf8_string, xg_get_file_with_chooser):
13932 Rename locals to avoid shadowing.
13933 (create_dialog): Move locals to avoid shadowing.
13935 * xgselect.c (xg_select): Remove unused var.
13937 * image.c (four_corners_best): Mark locals as initialized.
13938 (gif_load): Initialize transparent_p to zero (Bug#8238).
13939 Mark another local as initialized.
13940 (my_png_error, my_error_exit): Mark with NO_RETURN.
13942 * image.c (clear_image_cache): Now static.
13943 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13944 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13945 (x_edge_detection): Remove unnecessary cast that
13946 gcc -Wbad-function-cast diagnoses.
13947 (gif_load): Fix pointer signedness.
13948 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13949 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13951 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13953 Improve quality of tests for time stamp overflow.
13954 For example, without this patch (encode-time 0 0 0 1 1
13955 1152921504606846976) returns the obviously-bogus value (-948597
13956 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13957 reports time overflow. See
13958 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13959 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13960 * editfns.c: Include limits.h and intprops.h.
13961 (TIME_T_MIN, TIME_T_MAX): New macros.
13962 (time_overflow): Move earlier, to before first use.
13963 (hi_time, lo_time): New functions, for an accurate test for
13964 out-of-range times.
13965 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13966 (Fget_internal_run_time): Don't assume time_t fits in int.
13967 (make_time): Use list2 instead of Fcons twice.
13968 (Fdecode_time): More accurate test for out-of-range times.
13969 (check_tm_member): New function.
13970 (Fencode_time): Use it, to test for out-of-range times.
13971 (lisp_time_argument): Don't rely on undefined left-shift and
13972 right-shift behavior when checking for time stamp overflow.
13974 * editfns.c (time_overflow): New function, refactoring common code.
13975 (Fformat_time_string, Fdecode_time, Fencode_time):
13976 (Fcurrent_time_string): Use it.
13978 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13979 * dired.c (make_time): Move to ...
13980 * editfns.c (make_time): ... here.
13981 * systime.h: Note the move.
13983 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13985 * fringe.c (update_window_fringes): Remove unused variables.
13987 * unexmacosx.c (copy_data_segment): Also copy __got section.
13990 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13992 * termcap.c [MSDOS]: Include "msdos.h".
13993 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13994 Constify `char *' arguments and their references according to
13995 prototypes in tparam.h.
13997 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13999 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14000 Adapt all references accordingly.
14002 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14004 2011-03-11 Tom Tromey <tromey@redhat.com>
14006 * buffer.c (syms_of_buffer): Remove obsolete comment.
14008 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14010 * termhooks.h (encode_terminal_code): Declare prototype.
14012 * msdos.c (encode_terminal_code): Don't declare prototype.
14014 * term.c (encode_terminal_code): Now external again, used by
14015 w32console.c and msdos.c.
14017 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14018 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14020 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14022 Fix some minor problems found by GCC 4.5.2's static checks.
14024 * fringe.c (update_window_fringes): Mark locals as initialized
14026 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14028 * alloc.c (mark_fringe_data): Move decl from here ...
14029 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14030 to check its interface.
14031 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14033 * fontset.c (free_realized_fontset): Now static.
14034 (Fset_fontset_font): Rename local to avoid shadowing.
14035 (fontset_font): Mark local as initialized.
14036 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14038 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14040 * xselect.c (x_disown_buffer_selections): Remove; not used.
14041 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14042 (x_own_selection, Fx_disown_selection_internal): Rename locals
14043 to avoid shadowing.
14044 (x_handle_dnd_message): Remove local to avoid shadowing.
14046 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14047 so that the caller can use some name other than gcpro1.
14048 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14049 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14050 (Fx_backspace_delete_keys_p):
14051 Use them to avoid shadowing, and rename vars to avoid shadowing.
14052 (x_decode_color, x_set_name, x_window): Now static.
14053 (Fx_create_frame): Add braces to silence GCC warning.
14054 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14055 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14056 Remove unused locals.
14057 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14058 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14059 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14062 * xterm.h (x_mouse_leave): New decl.
14064 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14065 Remove unused functions.
14066 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14067 (x_calc_absolute_position): Now static.
14068 (XTread_socket): Don't define label "out" unless it's used.
14069 Don't declare local "event" unless it's used.
14070 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14071 unless they are used.
14072 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14073 (x_fatal_error_signal): Remove; not used.
14074 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14075 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14076 (x_error_catcher, x_connection_closed, x_error_handler):
14077 (x_error_quitter, xembed_send_message, x_iconify_frame):
14078 (my_log_handler): Rename locals to avoid shadowing.
14079 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14080 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14082 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14083 Rename or move locals to avoid shadowing.
14084 (tty_defined_color, merge_face_heights): Now static.
14085 (free_realized_faces_for_fontset): Remove; not used.
14086 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14087 does not deduce is never used uninitialized.
14088 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14089 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14091 * terminal.c (store_terminal_param): Now static.
14093 * xmenu.c (menu_highlight_callback): Now static.
14094 (set_frame_menubar): Remove unused local.
14095 (xmenu_show): Rename parameter to avoid shadowing.
14096 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14097 since they might point to immutable storage.
14098 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14099 since it's unused otherwise.
14101 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14102 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14103 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14104 avoids a gcc -Wuninitialized diagnostic.
14105 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14106 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14107 does not deduce are never used uninitialized.
14109 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14111 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14112 * window.c (window_loop, size_window):
14113 (run_window_configuration_change_hook, enlarge_window): Likewise.
14115 * window.c (display_buffer): Now static.
14116 (size_window): Mark variables that gcc -Wuninitialized
14117 does not deduce are never used uninitialized.
14118 * window.h (check_all_windows): New decl, to forestall
14119 gcc -Wmissing-prototypes diagnostic.
14120 * dispextern.h (bidi_dump_cached_states): Likewise.
14122 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14124 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14125 Include <limits.h>.
14126 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14127 and to avoid gcc -Wuninitialized warning.
14128 (load_charset_map): Mark variables that gcc -Wuninitialized
14129 does not deduce are never used uninitialized.
14130 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14132 * coding.c (coding_set_source, coding_set_destination):
14133 Use "else { /* comment */ }" rather than "else /* comment */;"
14134 for clarity, and to avoid gcc -Wempty-body warning.
14135 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14136 a block, when the outer 'i' will do.
14137 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14138 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14139 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14140 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14141 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14142 Rename locals to avoid shadowing.
14143 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14144 * coding.c (emacs_mule_char, encode_invocation_designation):
14145 Now static, since they're not used elsewhere.
14146 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14147 (decode_coding_object, encode_coding_object, detect_coding_system):
14148 (decode_coding_emacs_mule): Mark variables that gcc
14149 -Wuninitialized does not deduce are never used uninitialized.
14150 (detect_coding_iso_2022): Initialize a local variable that might
14151 be used uninitialized. Leave a FIXME because it's not clear that
14152 this initialization is needed. (Bug#8211)
14153 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14154 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14155 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14156 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14157 Remove unused macros.
14159 * category.c (hash_get_category_set): Remove unused local var.
14160 (copy_category_table): Now static, since it's not used elsewhere.
14161 * character.c (string_count_byte8): Likewise.
14163 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14164 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14166 * chartab.c (copy_sub_char_table): Now static, since it's not used
14168 (sub_char_table_ref_and_range, char_table_ref_and_range):
14169 Rename locals to avoid shadowing.
14170 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14172 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14173 (BIDI_BOB): Remove unused macro.
14175 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14176 deduce are never used uninitialized.
14177 * term.c (encode_terminal_code): Likewise.
14179 * term.c (encode_terminal_code): Now static. Remove unused local.
14181 * tparam.h: New file.
14182 * term.c, tparam.h: Include it.
14183 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14184 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14185 Move these decls to tparam.h, and make them agree with what
14186 is actually in tparam.c. The previous trick of using incompatible
14187 decls in different modules does not conform to the C standard.
14188 All callers of tparam changed to use tparam's actual API.
14189 * tparam.c (tparam1, tparam, tgoto):
14190 Use const pointers where appropriate.
14192 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14193 * cm.h (struct cm): Likewise.
14194 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14195 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14196 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14197 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14198 (turn_on_face, init_tty): Likewise.
14199 * termchar.h (struct tty_display_info): Likewise.
14201 * term.c (term_mouse_position): Rename local to avoid shadowing.
14203 * alloc.c (mark_ttys): Move decl from here ...
14204 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14206 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14208 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14210 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14212 * search.c (compile_pattern_1): Remove argument regp, unused since
14213 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14214 (compile_pattern): Don't pass it.
14216 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14218 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14219 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14221 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14223 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14225 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14226 gdk_window_get_screen, gdk_window_get_geometry,
14227 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14228 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14229 (xg_get_pixbuf_from_pixmap): New function.
14230 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14231 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14232 Call xg_get_pixbuf_from_pixmap instead of
14233 gdk_pixbuf_get_from_drawable.
14234 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14235 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14236 (xg_check_special_colors): Use GtkStyleContext and its functions
14238 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14239 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14240 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14241 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14242 Call gtk_widget_get_preferred_size.
14243 (xg_frame_resized): gdk_window_get_geometry only takes 5
14245 (xg_win_to_widget, xg_event_is_for_menubar):
14246 Call gdk_x11_window_lookup_for_display.
14247 (xg_set_widget_bg): New function.
14248 (delete_cb): New function.
14249 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14250 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14251 (xg_set_background_color): Call xg_set_widget_bg.
14252 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14253 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14254 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14255 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14257 (update_frame_tool_bar): Call gtk_widget_hide.
14258 (xg_initialize): Use GDK_KEY_g.
14260 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14262 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14264 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14265 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14266 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14268 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14270 * w32xfns.c (select_palette): Check success of RealizePalette against
14271 GDI_ERROR, not zero.
14273 See ChangeLog.11 for earlier changes.
14275 ;; Local Variables:
14279 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14281 This file is part of GNU Emacs.
14283 GNU Emacs is free software: you can redistribute it and/or modify
14284 it under the terms of the GNU General Public License as published by
14285 the Free Software Foundation, either version 3 of the License, or
14286 (at your option) any later version.
14288 GNU Emacs is distributed in the hope that it will be useful,
14289 but WITHOUT ANY WARRANTY; without even the implied warranty of
14290 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14291 GNU General Public License for more details.
14293 You should have received a copy of the GNU General Public License
14294 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.