1 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5 2011-11-11 Kenichi Handa <handa@m17n.org>
7 * callproc.c (Fcall_process): Set the member dst_multibyte of
10 2011-11-11 Johan Bockgård <bojohan@gnu.org>
12 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
13 avoid a crash (bug#9496).
15 2011-11-09 Chong Yidong <cyd@gnu.org>
17 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
18 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
20 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
22 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
24 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
26 Avoid some portability problems by eschewing 'extern inline' functions.
27 The trivial performance wins aren't worth the portability hassles; see
28 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
30 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
31 (window_box_width, window_box_left, window_box_left_offset)
32 (window_box_right, window_box_right_offset): Undo previous change,
33 by removing the "extern"s.
34 * intervals.c (adjust_intervals_for_insertion)
35 (adjust_intervals_for_deletion): Undo previous change,
36 making these static again.
37 (offset_intervals, temp_set_point_both, temp_set_point)
38 (copy_intervals_to_string): No longer inline.
39 * xdisp.c (window_text_bottom_y, window_box_width)
40 (window_box_height, window_box_left_offset)
41 (window_box_right_offset, window_box_left, window_box_right)
42 (window_box): No longer inline.
44 2011-11-08 Chong Yidong <cyd@gnu.org>
46 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
47 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
48 an error if not a live window.
49 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
50 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
52 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
54 * lisp.h (syms_of_abbrev): Remove declaration.
55 Reported by CHENG Gao <chenggao@royau.me>.
57 2011-11-07 Eli Zaretskii <eliz@gnu.org>
59 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
60 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
61 of temacs in GUI mode.
63 2011-11-07 Martin Rudalics <rudalics@gmx.at>
65 * window.h: Declare delete_all_child_windows instead of
66 delete_all_subwindows.
67 * window.c (Fwindow_nest, Fset_window_nest)
68 (Fset_window_new_total, Fset_window_new_normal)
69 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
70 (delete_all_subwindows): Rename to delete_all_child_windows.
71 (Fdelete_other_windows_internal, Fset_window_configuration):
72 Call delete_all_child_windows instead of delete_all_subwindows.
73 * frame.c (delete_frame): Call delete_all_child_windows instead
74 of delete_all_subwindows.
76 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
78 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
79 This is also needed for porting to any host where GC_MARK_STACK is
80 not GC_MAKE_GCPROS_NOOPS.
81 (which_symbols): Use it.
83 2011-11-07 Kenichi Handa <handa@m17n.org>
85 * coding.c (coding_set_destination): Check coding->src_pos only
86 when coding->src_object is a buffer (bug#9910).
88 * process.c (send_process): Set the member src_multibyte of coding
89 to 0 (bug#9911) when sending a unibyte text.
91 * callproc.c (Fcall_process): Set the member src_multibyte of
92 process_coding to 0 (bug#9912).
94 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
96 * xmenu.c (cleanup_widget_value_tree): New function.
97 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
98 calling free_menubar_widget_value_tree directly (Bug#9830).
100 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
102 Fix some portability problems with 'inline'.
103 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
104 (window_box_width, window_box_left, window_box_left_offset)
105 (window_box_right, window_box_right_offset): Declare extern.
106 Otherwise, these inline functions do not conform to C99 and
107 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
108 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
109 * intervals.c (adjust_intervals_for_insertion)
110 (adjust_intervals_for_deletion): Now extern, because otherwise the
111 extern inline functions 'offset_intervals' couldn't refer to it.
112 (static_offset_intervals): Remove.
113 (offset_intervals): Rewrite using the old contents of
114 static_offset_intervals. The old version didn't conform to C99
115 because an extern inline function contained a reference to an
116 identifier with static linkage.
118 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
120 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
123 2011-11-06 Eli Zaretskii <eliz@gnu.org>
125 * xdisp.c (init_iterator, reseat_to_string): Don't set the
126 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
127 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
128 return Qleft_to_right.
130 2011-11-06 Chong Yidong <cyd@gnu.org>
132 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
133 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
134 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
135 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
136 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
137 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
138 (Fwindow_vscroll): Doc fix.
139 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
140 argument, since it makes no sense to pass a live window and for
141 consistency with window-child.
143 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
145 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
148 2011-11-05 Jason Rumney <jasonr@gnu.org>
150 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
151 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
153 (add_font_entity_to_list): Fix logic errors in mixed boolean and
154 bitwise arithmetic preventing use of unicode-sip and non-truetype
157 2011-11-05 Eli Zaretskii <eliz@gnu.org>
159 * s/ms-w32.h (fstat, stat, utime): Move redirections to
162 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
163 initialization code to keep similarity to xfns.c after changes
166 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
168 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
169 (unwind_create_frame): New function (Bug#9943).
170 (Fx_create_frame): Restructure code to be more similar to the one in
171 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
172 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
173 Move terminal->reference_count++ just before making the frame official
176 * nsterm.m (x_free_frame_resources): New function.
177 (x_destroy_window): Move code to x_free_frame_resources.
179 * xfns.c (unwind_create_frame): Fix comment.
180 (Fx_create_frame, x_create_tip_frame): Move
181 terminal->reference_count++ just before making the frame
182 official. Move initialization of image_cache_refcount and
183 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
185 2011-11-05 Eli Zaretskii <eliz@gnu.org>
187 Support MSVC build with newer versions of Visual Studio.
188 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
189 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
192 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
193 which are not supported by MSVC.
194 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
195 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
197 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
199 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
201 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
203 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
205 Support MSVC build with newer versions of Visual Studio.
206 * w32.c: Don't include w32api.h for MSVC.
207 (init_environment) [_MSC_VER]: Call sys_access, not _access.
209 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
210 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
211 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
212 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
214 (alloca) [_MSC_VER]: Define to _alloca.
216 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
218 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
220 2011-11-04 Eli Zaretskii <eliz@gnu.org>
222 * xdisp.c (note_mouse_highlight): If either of
223 previous/next-single-property-change returns nil, treat that as
224 the beginning or the end of the buffer. (Bug#9955)
226 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
228 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
229 label is not null (Bug#9951).
230 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
233 2011-11-04 Eli Zaretskii <eliz@gnu.org>
235 * window.c (Fwindow_body_size): Mention in the doc string that the
236 return value is in frame's canonical units. (Bug#9949)
238 2011-11-03 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
242 * w32fns.c (unwind_create_frame): If needed, free the glyph
243 matrices of the partially constructed frame. (Bug#9943)
244 * xfns.c (unwind_create_frame): Likewise.
246 2011-11-01 Eli Zaretskii <eliz@gnu.org>
248 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
249 Don't stop backward scan on the continuation glyph, even though
250 its CHARPOS is positive.
251 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
252 cover_string to disp_string.
254 2011-11-01 Martin Rudalics <rudalics@gmx.at>
256 * window.c (temp_output_buffer_show): Don't use
257 Vtemp_buffer_show_specifiers.
258 (Vtemp_buffer_show_specifiers): Remove unused variable.
260 2011-10-30 Eli Zaretskii <eliz@gnu.org>
262 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
263 past the beginning of the current glyph matrix.
265 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
267 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
268 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
269 HAVE_GTK3 (Bug#9869).
271 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
272 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
274 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
276 * xterm.c: Declare x_handle_net_wm_state to return int.
277 (handle_one_xevent): Check if we are iconified but don't have
278 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
279 (get_current_wm_state): Return non-zero if not hidden,
280 check for _NET_WM_STATE_HIDDEN (Bug#9893).
281 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
282 (x_handle_net_wm_state): Return what get_current_wm_state returns.
283 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
285 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
287 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
288 so that this new function doesn't get optimized away by a
289 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
291 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
293 * frame.h (MOUSE_HL_INFO): Remove excess parens.
295 2011-10-29 Eli Zaretskii <eliz@gnu.org>
297 Fix the `xbytecode' command.
298 * .gdbinit (xprintbytestr): New command.
299 (xwhichsymbols): Renamed from `which'; all callers changed.
300 (xbytecode): Print the byte-code string as well.
302 2011-10-29 Kim Storm <storm@cua.dk>
304 * alloc.c (which_symbols): New function.
306 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
308 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
311 2011-10-29 Glenn Morris <rgm@gnu.org>
313 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
314 Not clear what it was for, and it causes various bugs. (Bug#9839)
316 2011-10-28 Eli Zaretskii <eliz@gnu.org>
318 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
319 possible random value that matches one of those tested as
320 condition to clear the mouse face.
322 2011-10-28 Chong Yidong <cyd@gnu.org>
324 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
326 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
328 * window.c (make_window): Initialize phys_cursor_on_p.
330 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
332 * lisp.h (struct Lisp_Symbol): Update comments.
334 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
336 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
338 2011-10-28 Eli Zaretskii <eliz@gnu.org>
340 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
341 <oslsachem@gmail.com> for helping to debug this.
343 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
344 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
345 (g_b_init_get_glyph_outline_w): New static variables.
346 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
347 (GetGlyphOutlineW_Proc): New typedefs.
348 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
349 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
351 (w32font_open_internal, compute_metrics):
352 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
353 instead of calling the "wide" APIs directly.
355 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
357 * w32.h (syms_of_w32font): Add prototype.
359 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
361 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
362 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
363 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
364 (Fmove_to_window_line): Doc fix.
366 2011-10-27 Chong Yidong <cyd@gnu.org>
368 * process.c (make_process): Set gnutls_state to NULL.
370 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
371 non-NULL, regardless of GNUTLS_INITSTAGE.
372 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
373 an error. Set process slots as soon as we allocate them.
375 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
377 2011-10-27 Chong Yidong <cyd@gnu.org>
379 * gnutls.c (emacs_gnutls_deinit): New function.
380 Deallocate credentials structures as well as calling gnutls_deinit.
381 (Fgnutls_deinit, Fgnutls_boot): Use it.
383 * process.c (make_process): Initialize GnuTLS credentials to NULL.
384 (deactivate_process): Call emacs_gnutls_deinit.
386 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
388 * image.c (x_create_x_image_and_pixmap):
389 * w32.c (sys_rename, w32_delayed_load):
390 * w32font.c (fill_in_logfont):
391 * w32reg.c (x_get_string_resource): Silence compiler warnings.
393 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
395 * w32fns.c (w32_default_color_map): New function,
396 extracted from Fw32_default_color_map.
397 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
399 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
401 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
403 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
405 * keyboard.c (test_undefined): New function (bug#9751).
406 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
408 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
410 * sysdep.c (init_sys_modes): Fix the check for the controlling
413 2011-10-20 Eli Zaretskii <eliz@gnu.org>
415 * dispextern.h (struct bidi_it): New member next_en_type.
417 * bidi.c (bidi_line_init): Initialize the next_en_type member.
418 (bidi_resolve_explicit_1): When next_en_pos is valid for the
419 current character, check also for next_en_type being WEAK_EN.
420 (bidi_resolve_weak): Don't enter the expensive loop if the current
421 position is before next_en_pos. Record the bidi type of the first
422 non-ET, non-BN character we find, in addition to its position.
423 (bidi_level_of_next_char): Invalidate next_en_type when
424 next_en_pos is over-stepped.
426 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
428 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
429 * editfns.c: Rewrite current-time-zone so that it invokes
430 the equivalent of (format-time-string "%Z") to get the time zone name.
431 This fixes a bug when the time zone name contains characters that
432 need converting from the system time locale to Emacs internal format.
433 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
434 that patch fixed format-time-string to do the conversion, but
435 I forgot to fix current-time-zone.
436 (format_time_string): New function, containing most of
437 what Fformat_time_string used to contain.
438 (Fformat_time_string): Rewrite in terms of format_time_string.
439 This doesn't change this function's behavior.
440 (current-time-zone): Rewrite to use format_time_string.
441 This fixes the bug reported by Michael Schierl in
442 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
443 Jason Rumney's 2007-06-07 change worked around this bug, but
445 * systime.h (tzname, timezone): Remove no-longer-used declarations.
447 2011-10-19 Eli Zaretskii <eliz@gnu.org>
449 * xdisp.c (start_display): If the character at POS is displayed
450 via a display vector, reset IT->current.dpvec_index to zero.
451 (try_window_reusing_current_matrix): If a line ends in a display
452 vector or the next line starts in a display vector, continue
453 redrawing the window even though the character position of
454 start_row was reached.
457 2011-10-18 Chong Yidong <cyd@gnu.org>
459 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
460 with nobreak-char-display too.
462 2011-10-18 Eli Zaretskii <eliz@gnu.org>
464 Fix part 3 of bug#9771.
465 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
466 (bidi_resolve_neutral): Don't enter the expensive loop looking for
467 non-neutral characters if the current character is a paragraph
468 separator (a.k.a. Newline). This avoids running the same
469 expensive loop twice, once when we consume the preceding newline
470 and the other time when the line actually needs to be displayed.
471 Avoid the loop when we see neutrals on the base embedding level
472 following a character whose directionality is the same as the
473 paragraph's. This avoids running the expensive loop when a line
474 ends in a long sequence of neutrals, like control characters.
475 Add assertion against STRONG_AL type. Slightly rearrange code
476 that determines the type of a neutral given the first non-neutral
478 (bidi_level_of_next_char): Set next_en_pos to zero when
479 invalidating its info.
481 2011-10-17 Eli Zaretskii <eliz@gnu.org>
483 * xdisp.c (push_display_prop): Determine whether to record string
484 or buffer position by IT->string, not by IT->method. Allow
485 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
486 (move_it_vertically_backward): Don't look for character position
487 immediately after the newline when in a continuation line.
490 2011-10-15 Martin Rudalics <rudalics@gmx.at>
492 * window.c (coordinates_in_window): Rewrite and delabelize
493 vertical border check. (Bug#5357) (Bug#9618)
495 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
497 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
498 errors in XSetWindowBorder (bug#9310).
500 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
502 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
503 avoid crash when xmalloc overrun checking is enabled.
505 2011-10-13 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
508 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
509 cursor motion with <left> and <right> arrow keys.
511 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
512 some callers set that themselves.
514 2011-10-12 Eli Zaretskii <eliz@gnu.org>
516 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
517 display string and the previous row comes from the same string and
518 is empty. (Bug#9739) (Bug#9738)
520 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
522 * doc.c (get_doc_string): Encode file name (bug#9735).
524 2011-10-12 Eli Zaretskii <eliz@gnu.org>
526 * bidi.c (bidi_level_of_next_char):
527 * xdisp.c (get_visually_first_element): Remove old incorrect
528 comments regarding the Unicode Line Separator character.
530 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
532 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
534 * alloc.c (Fgc_status): Do not access beyond zombies array
535 boundary if nzombies > MAX_ZOMBIES.
536 * alloc.c (dump_zombies): Add missing format specifier.
538 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
540 * xdisp.c (set_cursor_from_row): Simplify conditionals,
541 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
543 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
544 Some packages use them to denote characters with modifiers.
546 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
548 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
549 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
550 matching a pp-number. Rename parameter var to var1.
552 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
554 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
556 2011-10-08 Glenn Morris <rgm@gnu.org>
558 * callint.c (Fcall_interactively): Give a more explicit error for the
559 'c' case with a non-character input. (Bug#8479)
561 2011-10-08 Eli Zaretskii <eliz@gnu.org>
563 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
565 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
566 lines that are hscrolled on the left.
568 * dispnew.c (buffer_posn_from_coords): Account for a possible
569 presence of header-line. (Bug#4426)
571 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
573 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
574 Don't advertise functionality which we discourage or doesn't work.
576 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
578 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
579 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
580 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
581 this makes Emacs dump core during garbage collection on rare
582 occasions. sizeof is obviously inferior to offsetof here, so
584 (GC_POINTER_ALIGNMENT): New macro.
585 (mark_memory): Omit 3rd (offset) arg; caller changed.
586 Don't assume EMACS_INT alignment is the same as pointer alignment.
588 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
590 * keyboard.c (read_key_sequence_remapped): New var.
591 (read_key_sequence): Compute remapping in the right buffer.
592 (command_loop_1): Use read_key_sequence's remapping directly.
594 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
596 * dired.c (file_name_completion): Don't expand file name.
597 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
598 before checking file name handler.
600 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
601 they've been requested explicitly (bug#9591).
603 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
605 * keymap.c (Fsingle_key_description): Use make_specified_string
606 instead of build_string to build string from push_key_description.
609 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
611 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
612 This fixes a Y2038 bug on 64-bit hosts.
613 * buffer.c (reset_buffer):
614 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
615 (Fclear_buffer_auto_save_failure):
616 Use 0, not -1, to represent an unset failure time, since time_t
619 Remove dependency on glibc malloc internals.
620 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
621 Move back here from lisp.h, but with their new implementations.
622 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
623 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
624 * charset.c (charset_table_init): New static var.
625 (syms_of_charset): Use it instead of xmalloc. This removes a
626 dependency on glibc malloc internals. See Eli Zaretskii's comment in
627 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
629 Move back to alloc.c.
630 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
631 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
633 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
635 * nsterm.m (windowDidResize): Call x_set_window_size only when
636 ns_in_resize is true. Otherwise set pixelwidth/height and
637 call change_frame_size (Bug#9628).
639 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
641 Port --enable-checking=all to Fedora 14 x86-64.
642 * charset.c (syms_of_charset): Also account for glibc malloc's
643 internal overhead when calculating the initial malloc maximum.
645 Port --enable-checking=all to Fedora 14 x86.
646 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
648 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
649 (overrun_check_realloc, overrun_check_free):
650 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
651 That way, xmalloc returns a properly-aligned pointer even if
652 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
653 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
654 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
655 into account when calculating the initial malloc maximum.
656 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
657 Move here from alloc.c, so that charset.c can use it too.
658 Properly align; the old code wasn't right for common 32-bit hosts
659 when configured with --enable-checking=all.
660 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
661 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
663 2011-09-29 Eli Zaretskii <eliz@gnu.org>
665 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
668 2011-09-28 Eli Zaretskii <eliz@gnu.org>
670 * xdisp.c (compute_display_string_end): If there's no display
671 string at CHARPOS, return -1.
673 * bidi.c (bidi_fetch_char): When compute_display_string_end
674 returns a negative value, treat the character as a normal
675 character not covered by a display string. (Bug#9624)
677 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
679 * lread.c (Fread_from_string): Fix typo in docstring.
681 2011-09-27 Eli Zaretskii <eliz@gnu.org>
683 * xdisp.c (handle_invisible_prop): If invisible text ends on a
684 newline, reseat the iterator instead of bidi-iterating there one
685 character at a time. (Bug#9610)
686 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
687 TO_CHARPOS if the bidi iterator is at base embedding level.
689 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
691 * lread.c (readevalloop): Use correct code for NBSP.
692 (read1): Likewise. (Bug#9608)
694 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
696 * dbusbind.c (Fdbus_register_signal): When service is not
697 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
699 2011-09-25 Glenn Morris <rgm@gnu.org>
701 * buffer.c (truncate-lines): Doc fix.
703 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
705 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
706 (Fset_window_next_buffers): Doc fix.
708 2011-09-24 Glenn Morris <rgm@gnu.org>
710 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
712 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
714 Fix minor problems found by static checking.
715 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
716 * indent.c (Fvertical_motion): Fix == vs = typo.
718 2011-09-24 Eli Zaretskii <eliz@gnu.org>
720 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
721 Default value is now t. Doc fix.
723 * indent.c (Fvertical_motion): Compute and apply the overshoot
724 logic when moving up, not only when moving down. Fix the
725 confusing name and values of the it_overshoot_expected variable;
726 logic changes accordingly. (Bug#9254) (Bug#9549)
728 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
729 CHARPOS is covered by a display string which includes newlines.
730 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
731 is covered by a display string with embedded newlines.
733 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
735 * dbusbind.c (Fdbus_register_signal): Add match rule to
736 Vdbus_registered_objects_table. (Bug#9581)
737 (Fdbus_register_method, Vdbus_registered_objects_table):
740 2011-09-24 Jim Meyering <meyering@redhat.com>
742 do not ignore write error for any output size
743 The previous change was incomplete.
744 While it makes emacs --batch detect the vast majority of stdout
745 write failures, errors were still ignored whenever the output size is
746 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
747 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
748 && echo FAIL: ignored write error
749 FAIL: ignored write error
750 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
751 && echo FAIL: ignored write error
752 FAIL: ignored write error
753 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
755 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
757 * emacs.c (Fkill_emacs): In noninteractive mode exit
758 non-successfully if a write error occurred on stdout. (Bug#9574)
760 2011-09-21 Eli Zaretskii <eliz@gnu.org>
762 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
765 * dispextern.h (struct it): Update the comment documenting what
768 2011-09-20 Eli Zaretskii <eliz@gnu.org>
770 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
771 a display string, extend search for cursor position to end of row.
772 (find_row_edges): If the row ends in a newline from a display
773 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
774 Handle the case of a display string with multiple newlines.
775 (Fcurrent_bidi_paragraph_direction): Fix search for previous
776 non-empty line. Fixes confusing cursor motion with arrow keys at
777 the beginning of a line that starts with whitespace.
779 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
781 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
784 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
786 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
789 2011-09-18 Eli Zaretskii <eliz@gnu.org>
791 * xdisp.c (display_line): Record maximum and minimum buffer
792 positions even if no glyphs were produced (e.g., by a zero-width
793 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
794 buffer positions that will be removed from the glyph row because
796 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
797 column is beyond frame width: don't subtract 1 "pixel" when
798 computing width of the stretch.
799 (reseat_at_next_visible_line_start): Undo the change made on
800 2011-09-17 that saved paragraph information and restored it after
801 the call to `reseat'. (Bug#9545)
803 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
805 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
806 and turn window cursor on if cleared (Bug#9415).
808 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
810 * search.c (boyer_moore): Take unibyte characters from pattern
811 literally. (Bug#9458)
813 2011-09-18 Eli Zaretskii <eliz@gnu.org>
815 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
817 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
819 Fix minor problem found by static checking.
820 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
821 initialized, to pacify gcc -Wuninitialized.
823 * fileio.c: Report proper errno when syscall falls.
824 (Finsert_file_contents): Save and restore errno,
825 so that report_file_error outputs the correct diagnostic.
826 (Fwrite_region) [CLASH_DETECTION]: Likewise.
828 2011-09-18 Eli Zaretskii <eliz@gnu.org>
830 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
832 2011-09-17 Eli Zaretskii <eliz@gnu.org>
834 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
835 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
837 2011-09-17 Eli Zaretskii <eliz@gnu.org>
839 * xdisp.c (reseat_at_next_visible_line_start): Keep information
840 about the current paragraph and restore it after the call to reseat.
842 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
843 (bidi_find_paragraph_start): Search back for paragraph beginning
844 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
845 (bidi_move_to_visually_next): Only trigger paragraph-related
846 computations when the last character is a newline or at EOB, not
847 just any NEUTRAL_B. (Bug#9470)
849 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
850 truncated lines if point is covered by a display string. (Bug#9524)
852 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
854 * xselect.c: Relax test for outgoing X longs (Bug#9498).
855 (cons_to_x_long): New function.
856 (lisp_data_to_selection_data): Use it. Correct the test for
857 short-versus-long data; it was negated. Break out of vector
858 loop, for efficiency, when a long datum is discovered.
860 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
862 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
864 2011-09-16 Eli Zaretskii <eliz@gnu.org>
866 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
867 GCC PR/17406) by declaring this function with external scope.
869 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
871 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
872 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
874 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
876 * editfns.c (Fformat): Correctly handle text properties on "%%".
878 2011-09-15 Eli Zaretskii <eliz@gnu.org>
880 * xterm.c (x_draw_composite_glyph_string_foreground):
881 * w32term.c (x_draw_composite_glyph_string_foreground):
882 * term.c (encode_terminal_code):
883 * composite.c (composition_update_it, get_composition_id):
884 * xdisp.c (get_next_display_element)
885 (fill_composite_glyph_string): Add comments about special meaning
886 of TAB characters in a composition.
888 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
890 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
891 This occurs when processing a multibyte format.
892 Problem reported by Wolfgang Jenker.
894 2011-09-15 Johan Bockgård <bojohan@gnu.org>
896 * xdisp.c (try_cursor_movement): Only check for exact match if
897 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
899 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
901 Remove unused external symbols.
902 * dispextern.h (calc_pixel_width_or_height): Remove decl.
903 * xdisp.c (calc_pixel_width_or_height): Now static.
904 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
905 * indent.c (check_display_width):
906 * w32term.c: Fix comment to match code.
907 * xterm.c, xterm.h (x_catching_errors): Remove.
909 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
911 * xselect.c: Use signed conversions more consistently (Bug#9498).
912 (selection_data_to_lisp_data): Assume incoming selection data are
913 signed integers, not unsigned. This is to be consistent with
914 outgoing selection data, which was modified to use signed integers
915 in as part of the fix to Bug#9196 in response to Jan D.'s comment
916 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
917 expects long, not unsigned long.
919 2011-09-14 Eli Zaretskii <eliz@gnu.org>
921 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
922 computation of loop end. Reported by Johan Bockgård
925 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
927 * frame.c (Fother_visible_frames_p): Function deleted.
929 2011-09-12 Eli Zaretskii <eliz@gnu.org>
931 * indent.c (compute_motion): Process display vector front to back
932 rather than the other way around. (Bug#2496)
934 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
936 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
938 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
940 * minibuf.c (Fread_from_minibuffer): Doc fix.
942 2011-09-11 Eli Zaretskii <eliz@gnu.org>
944 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
945 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
947 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
949 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
950 value for non-existent files.
952 2011-09-11 Eli Zaretskii <eliz@gnu.org>
954 * fileio.c (Finsert_file_contents): If the file cannot be opened,
955 set its "size" to -1. This will set the modtime_size field of
956 the corresponding buffer to -1, which is what
957 verify-visited-file-modtime expects for files that do not exist.
960 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
962 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
964 * lisp.h: ... from here. push_key_description is no longer
965 defined in keyboard.c, so its declaration should not be in
966 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
967 logically belongs with push_key_description.
969 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
971 * buffer.h: Include <sys/types.h> instead of <time.h>.
972 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
973 Problem reported by Herbert J. Skuhra.
975 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
977 * xml.c (parse_region): Make the parsing work for
978 non-comment-starting XML files again (bug#9144).
980 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
982 * image.c (gif_load): Fix calculation of bottom and right corner.
985 2011-09-10 Eli Zaretskii <eliz@gnu.org>
987 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
988 redisplay in small windows.
990 2011-09-09 Eli Zaretskii <eliz@gnu.org>
992 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
994 2011-09-08 Martin Rudalics <rudalics@gmx.at>
996 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
997 Operate on live windows only.
999 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1001 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1003 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1005 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1006 only under bidi iteration.
1008 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1010 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1012 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1014 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1015 Without this fix, the command to link temacs failed due to an
1016 undefined symbol __builtin_isnan. This is because
1017 /usr/include/iso/math_c99.h #defines isnan(x) to
1018 __builtin_isnan(x), but the bundled gcc, which identifies itself
1019 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1021 * floatfns.c (isnan): #undef, and then #define to a clone of
1023 (Fisnan): Always define, since it's always available now.
1024 (syms_of_floatfns): Always define isnan at the Lisp level.
1026 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1028 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1030 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1032 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1033 The previous code assumed that file offsets (off_t values) fit in
1034 EMACS_INT variables, which is not true on typical 32-bit hosts.
1035 The code messed up by falsely reporting buffer overflow in cases
1036 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1037 when "big" contains more than 2**29 bytes, even though this
1038 inserts just one byte and does not overflow the buffer.
1039 (Finsert_file_contents): Store file offsets as off_t
1040 values, not as EMACS_INT values. Check for overflow when
1041 converting between EMACS_INT and off_t. When checking for
1042 buffer overflow or for overlap, take the offsets into account.
1043 Don't use EMACS_INT for small values where int suffices.
1044 When checking for overlap, fix a typo: ZV was used where
1045 ZV_BYTE was intended.
1046 (Fwrite_region): Don't assume off_t fits into 'long'.
1047 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1049 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1051 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1053 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1055 sprintf-related integer and memory overflow issues (Bug#9412).
1057 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1058 (esprintf, exprintf, evxprintf): New functions.
1059 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1060 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1061 (modify_event_symbol): Do not assume that the length of
1062 name_alist_or_stem is safe to alloca and fits in int.
1063 (Fexecute_extended_command): Likewise for function name and binding.
1064 (Frecursion_depth): Wrap around reliably on integer overflow.
1065 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1066 since some callers pass EMACS_INT values.
1067 (Fsingle_key_description): Don't crash if symbol name contains more
1068 than MAX_ALLOCA bytes.
1069 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1070 (get_minibuffer): Arg is now EMACS_INT, not int.
1071 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1072 (esprintf, exprintf, evxprintf): New decls.
1073 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1075 * dbusbind.c (signature_cat): New function.
1076 (xd_signature, Fdbus_register_signal):
1077 Do not overrun buffer; instead, report string overflow.
1079 * dispnew.c (add_window_display_history): Don't overrun buffer.
1080 Truncate instead; this is OK since it's just a log.
1082 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1083 even if the time zone offset is outlandishly large.
1084 Don't mishandle offset == INT_MIN.
1086 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1087 when creating daemon; the previous buffer-overflow check was incorrect.
1089 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1090 which has the guts of the old verror function.
1092 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1093 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1095 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1096 (font_unparse_xlfd): Don't blindly alloca long strings.
1097 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1098 fits in int, when using sprintf. Use single snprintf to count
1099 length of string rather than counting it via multiple sprintfs;
1100 that's simpler and more reliable.
1101 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1102 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1103 sprintf, in case result does not fit in int.
1105 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1106 (fontset_from_font): Print it.
1108 * frame.c (tty_frame_count): Now printmax_t, not int.
1109 (make_terminal_frame, set_term_frame_name): Print it.
1110 (x_report_frame_params): In X, window IDs are unsigned long,
1111 not signed long, so print them as unsigned.
1112 (validate_x_resource_name): Check for implausibly long names,
1113 and don't assume name length fits in 'int'.
1114 (x_get_resource_string): Don't blindly alloca invocation name;
1115 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1118 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1119 (xg_check_special_colors, xg_set_geometry):
1120 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1122 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1123 Use esprintf, not sprintf, in case result does not fit in int.
1125 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1126 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1127 it as a large positive number.
1128 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1129 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1131 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1132 in case result does not fit in int.
1134 * print.c (float_to_string): Detect width overflow more reliably.
1135 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1136 buffer overrun. Don't assume list length fits in 'int'. Treat
1137 print length of 0 as 0, not as infinity; to be consistent with other
1138 uses of print length in this function. Don't overflow print length
1139 index. Don't assume hash table size fits in 'long', or that
1140 vectorlike size fits in 'unsigned long'.
1142 * process.c (make_process): Use printmax_t, not int, to format
1143 process-name gensyms.
1145 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1147 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1148 to avoid potential buffer overrun.
1150 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1151 if X resource line is longer than 512 bytes.
1153 * xfns.c (x_window): Make sprintf buffer a bit bigger
1154 to avoid potential buffer overrun.
1156 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1158 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1160 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1162 Integer overflow fixes for scrolling, etc.
1163 Without these, Emacs silently mishandles large integers sometimes.
1164 For example, "C-u 4294967297 M-x recenter" was treated as if
1165 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1167 * xdisp.c (try_window_id): Check Emacs fixnum range before
1168 converting to 'int'.
1170 * window.c (window_scroll_line_based, Frecenter):
1171 Check that an Emacs fixnum is in range before assigning it to 'int'.
1172 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1173 values converted from Emacs fixnums.
1174 (Frecenter): Don't wrap around a line count if it is out of 'int'
1175 range; instead, treat it as an extreme value.
1176 (Fset_window_configuration, compare_window_configurations):
1177 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1179 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1180 that can exceed INT_MAX. Check that EMACS_INT value is in range
1181 before assigning it to the (possibly-narrower) index.
1182 (match_limit): Don't assume that a fixnum can fit in 'int'.
1184 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1187 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1188 (Fvertical_motion): Don't wrap around LINES values that don't fit
1189 in 'int'. Instead, treat them as extreme values. This is good
1190 enough for windows, which can't have more than INT_MAX lines anyway.
1192 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1194 * Require libxml/parser.h to avoid compilation warning.
1196 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1198 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1199 since this reportedly can destroy thread storage.
1201 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1203 * syntax.c (find_defun_start): Update all cache variables if
1204 exiting early (Bug#9401).
1206 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1208 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1210 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1211 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1212 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1214 * term.c (tty_append_glyph): New function.
1215 (produce_stretch_glyph): Static function and its prototype deleted.
1217 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1220 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1222 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1223 when checking :margin (Bug#9390).
1224 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1225 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1226 so that the name doesn't mislead. All uses changed.
1228 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1230 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1233 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (move_it_to): Don't bail out early when reaching
1236 position beyond to_charpos, if we are scanning backwards.
1237 (move_it_vertically_backward): When DY == 0, make sure we get to
1238 the first character in the line after the newline.
1240 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1242 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1243 (ccl_driver): Do not generate an out-of-range pointer.
1244 (Fccl_execute_on_string): Remove unnecessary check for
1245 integer overflow, noted by Stefan Monnier in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1247 Remove a FIXME that didn't need fixing.
1248 Simplify the newly-introduced buffer reallocation code.
1250 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1252 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1254 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1256 Integer and memory overflow issues (Bug#9196).
1258 * doc.c (get_doc_string): Rework so that
1259 get_doc_string_buffer_size is the actual buffer size, rather than
1260 being 1 less than the actual buffer size; this makes xpalloc more
1263 * image.c (x_allocate_bitmap_record, cache_image):
1264 * xselect.c (Fx_register_dnd_atom):
1265 Simplify previous changes by using xpalloc.
1267 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1268 since either will do and ptrdiff_t is convenient with xpalloc.
1270 * charset.c (charset_table_size)
1271 (struct charset_sort_data.priority): Now ptrdiff_t.
1272 (charset_compare): Don't overflow if priorities differ greatly.
1273 (Fsort_charsets): Don't assume list length fits in int.
1274 Check for size-calculation overflow when allocating sort data.
1275 (syms_of_charset): Allocate an initial charset table that is
1276 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1278 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1280 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1281 The actual value is always <= INT_MAX, and leaving it unsigned made
1282 overflow checking harder.
1284 * dispextern.h (struct glyph_matrix.rows_allocated)
1285 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1286 with xpalloc. The values are still always <= INT_MAX.
1288 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1290 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1291 (SAFE_NALLOCA): New macro.
1293 * region-cache.c (struct boundary.pos, find_cache_boundary)
1294 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1295 (set_cache_region, invalidate_region_cache)
1296 (revalidate_region_cache, know_region_cache, region_cache_forward)
1297 (region_cache_backward, pp_cache):
1298 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1299 so that ptrdiff_t * can be passed to xpalloc.
1300 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1301 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1302 (pp_cache): Don't assume cache_len fits in int.
1303 * region-cache.h: Adjust extern decls to match.
1305 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1306 EMACS_INT, since either will do, for xpalloc.
1308 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1309 (xnmalloc, xnrealloc, xpalloc): New functions.
1311 * bidi.c (bidi_shelve_header_size): New constant.
1312 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1313 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1315 * bidi.c (bidi_cache_shrink):
1316 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1318 Don't update size of array until after memory allocation succeeds,
1319 because xmalloc/xrealloc may not return.
1320 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1321 now that we have proper integer overflow checking.
1322 (record_overlay_string, overlay_strings): Catch overflows when
1323 calculating size of overlay_str_buf.
1325 * callproc.c (Fcall_process): Check for size overflow when
1326 calculating size of args2.
1327 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1328 Normally we prefer signed values, but sticking with ptrdiff_t would
1329 require adding more-complicated checks.
1331 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1332 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1333 Redo buffer-overflow calculations to avoid integer overflow.
1334 Add a FIXME comment where memory seems to be over-allocated.
1336 * character.c (Fstring): Check for size-calculation overflow.
1338 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1339 unnecessary integer overflow. Check for size overflow.
1340 (encode_coding_object): Don't update size until xmalloc succeeds.
1342 * composite.c (get_composition_id): Check for overflow in glyph
1343 length calculations.
1345 Integer and memory overflow fixes for display code.
1346 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1347 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1348 (scrolling_window): Check for overflow in size calculations.
1349 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1350 Don't assume glyph table len fits in int.
1351 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1352 (row_table_size): Now ptrdiff_t, not int.
1353 (scrolling_window): Avoid overflow in size calculations.
1354 Don't update size until allocation succeeds.
1355 * fns.c (concat): Check for overflow in size calculations.
1356 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1357 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1358 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1360 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1361 (get_doc_string): Check for size calculation overflow.
1362 Don't update size until allocation succeeds.
1363 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1364 EMACS_INT, where ptrdiff_t will do.
1365 (Fsubstitute_command_keys): Check for string overflow.
1367 * editfns.c (set_time_zone_rule): Don't assume environment length
1369 (message_length): Now ptrdiff_t, not int.
1370 (Fmessage_box): Don't update size until allocation succeeds.
1371 Don't assume message length fits in int.
1372 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1374 * emacs.c (main): Do not reallocate argv, since there is a null at
1375 the end that can be overwritten, and this way there's no need to
1376 worry about size-calculation overflow.
1377 (sort_args): Check for size-calculation overflow.
1379 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1381 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1383 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1384 (x_set_scroll_bar_width, x_figure_window_size):
1385 Check for integer overflow.
1386 (x_set_alpha): Do not assume XINT fits in int.
1388 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1389 This is for the members text_lines, text_cols, total_lines, total_cols,
1390 where the system imposes an 'int' limit.
1392 * fringe.c (Fdefine_fringe_bitmap):
1393 Don't update size until alloc works.
1395 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1396 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1398 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1399 Check for size-calculation overflow.
1400 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1401 do, as we prefer signed integers.
1402 (id_to_widget.max_size, id_to_widget.used)
1403 (xg_store_widget_in_map, xg_remove_widget_from_map)
1404 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1405 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1406 Use and return ptrdiff_t, not int.
1407 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1408 * gtkutil.h: Change prototypes to match the above.
1410 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1411 are duplicate now that they've been promoted to lisp.h.
1412 (x_allocate_bitmap_record, x_alloc_image_color)
1413 (make_image_cache, cache_image, xpm_load):
1414 Don't update size until alloc is done.
1415 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1417 Check for size calculation overflow.
1418 (ct_colors_allocated_max): New constant.
1419 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1422 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1423 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1424 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1425 Use ptrdiff_t, not int, to count maps.
1426 (read_char_minibuf_menu_prompt): Check for overflow in size
1427 calculations. Don't update size until allocation succeeds.
1428 Redo calculations to avoid overflow.
1429 * keyboard.h: Change prototypes to match the above.
1431 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1433 (current_minor_maps): Check for size calculation overflow.
1434 * keymap.h: Change prototypes to match the above.
1436 * lread.c (read1, init_obarray): Don't update size until alloc done.
1438 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1439 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1441 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1442 Now ptrdiff_t, not int.
1443 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1444 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1446 * process.c (Fnetwork_interface_list): Check for overflow
1447 in size calculation.
1449 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1451 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1452 overflow. Don't bother calling xmalloc when xrealloc will do.
1454 * search.c (Freplace_match): Check for size calculation overflow.
1455 (Fset_match_data): Don't assume list lengths fit in 'int'.
1457 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1458 for command line length. Do not attempt to address one before the
1459 beginning of an array, as that's not portable.
1461 * term.c (max_frame_lines): Remove; unused.
1462 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1464 (encode_terminal_code, calculate_costs): Check for size
1465 calculation overflow.
1466 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1467 table lengths and related sizes. Don't update size until alloc
1468 done. Redo calculations to avoid overflow.
1469 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1471 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1472 subtracting pointers.
1473 (gobble_line): Check for overflow more carefully. Don't update size
1476 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1477 Don't update size until alloc done.
1478 Redo size calculations to avoid overflow.
1479 Check for size calculation overflow.
1480 (main) [DEBUG]: Fix typo in invoking tparam1.
1482 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1483 Use ptrdiff_t, not int, for sizes.
1484 (store_mode_line_noprop_char): Don't update size until alloc done.
1486 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1487 Use ptrdiff_t, not int, for sizes.
1488 (Finternal_make_lisp_face, cache_face):
1489 Check for size calculation overflow.
1490 (cache_face): Treat size calculation overflows as if they were
1491 memory exhaustion (the usual treatment), rather than aborting.
1493 * xfns.c (x_encode_text, x_set_name_internal)
1494 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1495 sizes, since they can exceed INT_MAX in size. Check for size
1496 calculation overflow.
1498 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1499 (xg_select): Check for size calculation overflow.
1500 Don't update size until alloc done.
1502 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1503 as sprintf is limited to int lengths.
1505 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1506 (X_LONG_MIN): New macros.
1507 Use them to make the following changes clearer.
1508 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1509 This change doesn't affect the value now, but it may help remind
1510 future maintainers not to raise the value too much later.
1511 (SELECTION_QUANTUM): Remove, replacing with ...
1512 (selection_quantum): ... new function, which avoids overflow.
1514 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1515 assumption that selection length fits in 'int'.
1516 (x_reply_selection_request, x_handle_selection_request)
1517 (x_get_window_property, receive_incremental_selection)
1518 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1519 (lisp_data_to_selection_data, clean_local_selection_data):
1520 Use ptrdiff_t, not int, to record length of selection.
1521 (x_reply_selection_request, x_get_window_property)
1522 (receive_incremental_selection, x_property_data_to_lisp):
1523 Redo calculations to avoid overflow.
1524 (x_reply_selection_request): When sending hint, ceiling it at
1525 X_LONG_MAX rather than relying on wraparound overflow to send
1527 (x_get_window_property, receive_incremental_selection)
1528 (lisp_data_to_selection_data, x_property_data_to_lisp):
1529 Check for size-calculation overflow.
1530 (x_get_window_property, receive_incremental_selection)
1531 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1532 Don't store size until memory allocation succeeds.
1533 (x_get_window_property): Plug memory leak on memory exhaustion.
1534 Don't double-block input; malloc is safe here. Don't assume 2**34
1535 - 4 fits in unsigned long. Add an xassert to check
1536 XGetWindowProperty overflow. Be more careful about overflow
1537 calculations, and distinguish size from memory overflow better.
1538 (receive_incremental_selection): When tracing, don't assume
1539 unsigned int is less than INT_MAX.
1540 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1541 harmful) conversions of unsigned short to int.
1542 (lisp_data_to_selection_data): Don't assume that integers
1543 in the range -65535 through -1 fit in an X unsigned short.
1544 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1545 result parameters unless successful. Rely on cons_to_unsigned
1546 to report problems with elements; the old code wasn't right anyway.
1547 (x_check_property_data): Check for int overflow; we cannot use
1548 a wider type due to X limits.
1549 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1551 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1553 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1554 (x_term_init): Check for size calculation overflow.
1555 (x_color_cells): Don't store size until memory allocation succeeds.
1556 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1557 Don't assume alloca size is less than MAX_ALLOCA.
1558 (x_term_init): Don't assume length fits in int (sprintf is limited
1561 Use ptrdiff_t for composition IDs.
1562 * character.c (lisp_string_width):
1563 * composite.c (composition_table_size, n_compositions)
1564 (get_composition_id, composition_gstring_from_id):
1565 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1566 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1567 * window.c (Frecenter):
1568 Use ptrdiff_t, not int, for composition IDs.
1569 * composite.c (get_composition_id): Check for integer overflow.
1570 * composite.h: Adjust prototypes to match the above changes.
1572 Use ptrdiff_t for hash table indexes.
1573 * category.c (hash_get_category_set):
1574 * ccl.c (ccl_driver):
1575 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1576 * coding.c (coding_system_charset_list, detect_coding_system):
1577 * coding.h (struct coding_system.id):
1578 * composite.c (get_composition_id, gstring_lookup_cache):
1579 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1580 * image.c (xpm_get_color_table_h):
1581 * lisp.h (hash_lookup, hash_put):
1582 * minibuf.c (Ftest_completion):
1583 Use ptrdiff_t for hash table indexes, not int (which is too
1584 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1585 32-bit --with-wide-int hosts).
1587 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1588 Add a FIXME comment about memory leaks.
1589 (syms_of_charset): Don't assume xmalloc returns.
1591 Don't assume that stated character widths fit in int.
1592 * character.c (Fchar_width, c_string_width, lisp_string_width):
1593 * character.h (CHAR_WIDTH):
1594 * indent.c (MULTIBYTE_BYTES_WIDTH):
1595 Use sanitize_char_width to avoid undefined and/or bad behavior
1596 with outlandish widths.
1597 * character.h (sanitize_tab_width): Rename from sanitize_width,
1598 now that we have two such functions. All uses changed.
1599 (sanitize_char_width): New inline function.
1601 Don't assume that tab-width fits in int.
1602 * character.h (sanitize_width): New inline function.
1603 (SANE_TAB_WIDTH): New macro.
1604 (ASCII_CHAR_WIDTH): Use it.
1605 * indent.c (sane_tab_width): Remove. All uses replaced by
1606 SANE_TAB_WIDTH (current_buffer).
1607 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1609 * fileio.c: Integer overflow issues with file modes.
1610 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1612 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1613 Remove unreachable code.
1614 (read_hex, load_charset_map_from_file): Check for integer overflow.
1616 * xterm.c: don't go over XClientMessageEvent limit
1617 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1618 (x_send_scroll_bar_event): Likewise. Check that the size does not
1619 exceed limits imposed by XClientMessageEvent, as well as the usual
1620 ptrdiff_t and size_t limits.
1622 * keyboard.c: Overflow, signedness and related fixes.
1623 (make_lispy_movement): Use same integer type in forward decl
1624 that is used in the definition.
1625 (read_key_sequence, keyremap_step):
1626 Change bufsize argument back to int, undoing my 2011-03-30 change.
1627 We prefer signed types, and int is wide enough here.
1628 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1629 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1630 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1631 length, not size_t. Use ptrdiff_t for index, not int.
1632 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1633 possibility of integer overflow.
1635 Overflow, signedness and related fixes for images.
1637 * dispextern.h (struct it.stack[0].u.image.image_id)
1638 (struct_it.image_id, struct image.id, struct image_cache.size)
1639 (struct image_cache.used, struct image_cache.ref_count):
1640 * gtkutil.c (update_frame_tool_bar):
1641 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1642 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1643 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1644 * nsmenu.m (update_frame_tool_bar):
1645 * xdisp.c (calc_pixel_width_or_height):
1646 * xfns.c (image_cache_refcount):
1647 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1648 on typical 64-bit hosts.
1650 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1651 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1652 Omit unnecessary casts to int.
1653 (parse_image_spec): Check that integers fall into 'int' range
1654 when the callers expect that.
1655 (image_ascent): Redo ascent calculation to avoid int overflow.
1656 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1657 (lookup_image): Remove unnecessary tests.
1658 (xbm_image_p): Locals are now of int, not EMACS_INT,
1659 since parse_image_check makes sure they fit into int.
1660 (png_load, gif_load, svg_load_image):
1661 Prefer int to unsigned where either will do.
1662 (tiff_handler): New function, combining the cores of the
1663 old tiff_error_handler and tiff_warning_handler.
1664 This function is rewritten to use vsnprintf and thereby avoid
1665 stack buffer overflows. It uses only the features of vsnprintf
1666 that are common to both POSIX and native Microsoft.
1667 (tiff_error_handler, tiff_warning_handler): Use it.
1668 (tiff_load, gif_load, imagemagick_load_image):
1669 Don't assume :index value fits in 'int'.
1670 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1671 (imagemagick_load_image): Check that crop parameters fit into
1672 the integer types that MagickCropImage accepts. Don't assume
1673 Vimagemagick_render_type has a nonnegative value. Don't assume
1674 size_t fits in 'long'.
1675 (gs_load): Use printmax_t to print the widest integers possible.
1676 Check for integer overflow when computing image height and width.
1678 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1680 * xdisp.c (redisplay_window): Don't force window start if point
1681 will be invisible in the resulting window. (Bug#9324)
1683 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1685 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1686 the display spec is of the form `(space ...)'.
1687 (handle_display_spec): Return the value returned by
1688 handle_single_display_spec, not just 1 or zero.
1689 (handle_single_display_spec): If the display spec is of the form
1690 `(space ...)', and specifies display in the text area, return 2
1692 (try_cursor_movement): Check for the need to scroll more
1693 accurately, and prefer exact match for point under bidi.
1694 Don't advance `row' beyond the last row of the window.
1696 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1697 into disp_prop; all users changed.
1699 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1700 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1701 for the text covered by the display property.
1703 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1705 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1706 Change return value to nil.
1707 (Frecord_buffer): Delete unused function.
1709 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1711 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1712 buffers, return left-to-right.
1713 (set_cursor_from_row): Consider candidate row a win if its glyph
1714 represents a newline and point is on that newline. Fixes cursor
1715 positioning on the newline at EOL of R2L text within L2R
1716 paragraph, and vice versa.
1717 (try_cursor_movement): Check continued rows, in addition to
1718 continuation rows. Fixes unwarranted scroll when point enters a
1719 continued line of R2L text within an L2R paragraph, or vice versa.
1720 (cursor_row_p): Consider the case of point being equal to
1721 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1722 from the end of a short line to the beginning of a continued line
1723 of R2L text within L2R paragraph.
1724 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1725 composed characters.
1727 * bidi.c (bidi_check_type): Use xassert.
1728 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1731 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1733 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1736 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1738 * nsfont.m (ns_otf_to_script): Fix typo.
1740 2011-08-22 Kenichi Handa <handa@m17n.org>
1742 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1743 extra slot even if the purpose is char-code-property-table.
1745 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1747 * xdisp.c (redisplay_window): When computing centering_position,
1748 account for the height of the header line. (Bug#8874)
1750 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1751 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1752 candidate is selected by the mouse, and that candidate has a
1753 composed character under the mouse.
1755 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1756 coordinates reported by pos-visible-in-window-p for a composed
1757 character in column zero.
1759 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1761 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1763 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1765 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1766 consider it a hit if to_charpos is anywhere in the range of the
1767 composed buffer positions.
1769 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1771 * image.c (gif_load): Don't assume that each subimage has the same
1772 dimensions as the base image. Handle disposal method that is
1773 "undefined" by the gif spec (Bug#9335).
1775 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1777 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1778 (Fcondition_case): Document `debug' symbol in error handler.
1780 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1782 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1783 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1784 from an Org mode buffer to a Speedbar frame.
1786 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1787 a composition, take its buffer position from IT->cmp_it.charpos.
1788 Fixes cursor positioning at the beginning of a line that begins
1789 with a composed character.
1791 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1793 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1794 character bidirectional type, use STRONG_L instead. Fixes crashes
1795 in a buffer produced by `describe-categories'.
1797 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1798 members before the level stack, so they would be saved and
1799 restored when copying iterator state. Fixes incorrect reordering
1800 around TABs covered by display properties.
1802 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1804 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1806 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1808 * eval.c (internal_condition_case, internal_condition_case_1)
1809 (internal_condition_case_2, internal_condition_case_n):
1810 Remove unnecessary aborts (Bug#9081).
1812 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1814 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1815 has no `load' handler, try opening the file locally. (Bug#9311)
1817 2011-08-16 Ken Brown <kbrown@cornell.edu>
1819 * gmalloc.c: Expand comment.
1821 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1823 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1824 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1826 2011-08-16 Ken Brown <kbrown@cornell.edu>
1828 Fix memory allocation problems in Cygwin build (Bug#9273).
1830 * unexcw.c ( __malloc_initialized): Declare external variable.
1831 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1833 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1835 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1837 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1839 [CYGWIN] (special_realloc): New function.
1840 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1841 requests to realloc storage in the static heap.
1843 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1845 * bidi.c (bidi_initialize): Remove unused local.
1847 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1850 * biditype.h: Remove file.
1851 * makefile.w32-in ($(BLD)/bidi.$(O)):
1852 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1854 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1856 * chartab.c: Improve commentary for the uniprop_table API.
1858 * bidi.c (bidi_paragraph_init): Support zero value of
1859 bidi_ignore_explicit_marks_for_paragraph_level.
1860 (bidi_initialize): Use uniprop_table instead of including
1861 biditype.h and bidimirror.h.
1863 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1864 coordinates of the iterator when restoring from ppos_it.
1867 2011-08-14 Kenichi Handa <handa@m17n.org>
1869 * process.c (create_process): Call setup_process_coding_systems
1870 after the pid of the process is set to -1 (Bug#8162).
1872 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1874 * xdisp.c (move_it_in_display_line_to): Don't invoke
1875 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1876 ppos_it. Fixes vertical cursor motion when line beginning is
1877 covered by an image. (Bug#9296)
1879 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1881 * nsterm.h (ns_run_ascript): Declare.
1882 (NSAPP_DATA2_RUNASSCRIPT): Define.
1884 * nsfns.m (as_script, as_result, as_status): New static variables.
1885 (ns_run_ascript): New function.
1886 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1887 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1888 the event loop. Get status from as_status (Bug#7276).
1890 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1891 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1892 the event loop (Bug#7276).
1894 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1896 * gnutls.c (QCgnutls_bootprop_priority)
1897 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1898 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1899 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1900 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1901 (QCgnutls_bootprop_verify_hostname_error)
1902 (QCgnutls_bootprop_callbacks_verify): Rename from
1903 Qgnutls_bootprop_..., all uses changed.
1905 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1908 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1910 * xfaces.c (Qframe_set_background_mode): Now static.
1911 * dispextern.h (Qframe_set_background_mode): Remove decl.
1913 * process.c (Fnetwork_interface_info): Declare local only if needed.
1915 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1917 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1918 (Fnetwork_interface_list): Allocate in increments of bytes instead
1919 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1920 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1922 (struct ifflag_def): notrailers is smart on OSX.
1923 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1924 Get hardware address with getifaddrs if available.
1926 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1928 * xdisp.c (iterate_out_of_display_property): xassert that
1929 IT->position is set to within IT->object's boundaries. Break from
1930 the loop as soon as EOB is reached; avoids infloops in redisplay
1931 when IT->position is set up wrongly due to some bug.
1932 Set IT->current to match the bidi iterator unconditionally.
1933 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1934 entry. Force push_it to save on the stack the current
1935 buffer/string position, to be restored by pop_it. Fix flags in
1936 the iterator structure wrt the object coming from a display
1937 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1938 properties. (Bug#9284)
1940 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1942 * fontset.c (fontset_get_font_group): Add proper type checks.
1945 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1947 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1948 and LC_VERSION_MIN_MACOSX.
1949 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1950 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1952 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1954 * xdisp.c (forward_to_next_line_start): Allow to use the
1955 no-display-properties-and-no-overlays under bidi display.
1956 Set disp_pos in the bidi iterator to avoid searches for display
1957 properties and overlays.
1959 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1961 * editfns.c (Fset_time_zone_rule): Document relationship with the
1964 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1965 the font entity extracted from the cache (Bug#8109).
1967 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1969 * composite.c (autocmp_chars): Don't reset point. That is done by
1970 restore_point_unwind (Bug#5984).
1972 2011-08-07 Juri Linkov <juri@jurta.org>
1974 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1975 to show the arg `TIME' instead of `TIMEVAL'.
1977 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1979 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1980 display property strides EOL and includes a newline, as in
1981 longlines-mode. (Bug#9254)
1982 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1983 word-wrap under bidirectional display. (Bug#9224)
1985 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1986 is non-zero, even if the data buffer is NULL. Fixes a crash in
1987 vertical-motion with longlines-mode. (Bug#9254)
1989 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1991 * bidi.c <bidi_cache_total_alloc>: Now static.
1992 (bidi_initialize): Initialize bidi_cache_total_alloc.
1994 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1997 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1998 amount allocated this far in `bidi_cache_total_alloc'.
1999 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2000 non-zero, only free the data buffer without restoring the cache
2001 contents. All callers changed.
2003 * dispextern.h (bidi_unshelve_cache): Update prototype.
2005 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2006 (move_it_in_display_line, move_it_to)
2007 (move_it_vertically_backward, move_it_by_lines): Replace the call
2008 to xfree to an equivalent call to bidi_unshelve_cache.
2009 (move_it_in_display_line_to): Fix logic of returning
2010 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2012 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2015 came from a string character with a `cursor' property. (Bug#9229)
2017 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2019 * Makefile.in (LIB_PTHREAD): New variable.
2020 (LIBES): Add LIB_PTHREAD (Bug#9216).
2022 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2023 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2025 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2027 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2029 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2031 * xterm.c (x_find_topmost_parent): New function.
2032 (x_set_frame_alpha): Find topmost parent window with
2033 x_find_topmost_parent and set the property there also (bug#9181).
2034 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2036 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2038 * callproc.c (Fcall_process): Avoid vfork clobbering
2039 the local vars buffer, coding_systems, current_dir.
2041 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2043 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2045 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2047 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2048 so that it is not optimized away.
2050 * xdisp.c (compute_display_string_pos): Remove unused local.
2052 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2054 Fix slow cursor motion and scrolling in large buffers with
2055 selective display, like Org Mode buffers. (Bug#9218)
2057 * dispextern.h (struct bidi_it): New member disp_prop_p.
2059 * xdisp.c: Remove one-slot cache of display string positions.
2060 (compute_display_string_pos): Accept an additional argument
2061 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2062 for a display string or property. If found, set DISP_PROP_P
2065 * bidi.c (bidi_fetch_char): Accept an additional argument
2066 DISP_PROP_P, and pass it to compute_display_string_pos.
2067 Only handle text covered by a display string if DISP_PROP_P is returned
2068 non-zero. All callers of bidi_fetch_char changed.
2070 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2072 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2074 2010-12-03 Don March <don@ohspite.net>
2076 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2077 last character M-[char] is translated to ESC [char] (bug#7541).
2079 2011-08-02 Kenichi Handa <handa@m17n.org>
2081 * lisp.h (uniprop_table): Extern it.
2083 * chartab.c (uniprop_table): Make it non-static.
2085 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2087 * xdisp.c (forward_to_next_line_start): Accept additional argument
2088 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2090 (reseat_at_next_visible_line_start): Use the bidi iterator state
2091 returned by forward_to_next_line_start to restore the state of
2092 it->bidi_it after backing up to previous newline. (Bug#9212)
2094 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2096 * regex.c (re_comp): Protoize.
2097 (re_exec): Fix return type.
2098 (regexec): Fix type of `ret'. (Bug#9203)
2100 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2102 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2103 This is needed if max-image-size is a floating-point number.
2105 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2107 * print.c (print_object): Print empty symbol as ##.
2109 * lread.c (read1): Read ## as empty symbol.
2111 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2113 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2114 setting frame foreground color (Bug#9175).
2115 (x_set_background_color): Likewise.
2117 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2118 contents (Bug#9176).
2119 (EmacsTooltip -init): Remove bezels and add shadows to
2122 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2123 or scroll bar (Bug#8470).
2125 * nsfont.m (nsfont_open): Remove assignment to voffset and
2126 unnecessary vars hshink, expand, hd, full_height, min_height.
2127 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2129 * nsterm.h (nsfont_info): Remove voffset field.
2131 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2133 Implement strike-through and overline on NextStep (Bug#8863).
2135 * nsfont.m (nsfont_open): Use underline position provided by font,
2136 instead of hard-coded value of 2.
2137 (nsfont_draw): Call ns_draw_text_decoration instead.
2139 * nsterm.h: Add declaration for ns_draw_text_decoration.
2141 * nsterm.m (ns_draw_text_decoration): New function for drawing
2142 underline, overline, and strike-through.
2143 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2144 ns_draw_text_decoration. Change treatment of cursor drawing to
2145 accommodate underlining, etc.
2147 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2149 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2152 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2154 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2155 Without this fix, if a signal arrives just after memory fills up,
2156 'malloc' might be invoked reentrantly.
2158 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2159 In other words, assume that every image size is allowed, on non-X
2160 hosts. This assumption is probably wrong, but it lets Emacs compile.
2162 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2164 * regex.c (re_iswctype): Convert return values to boolean.
2166 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2168 * xdisp.c (compute_display_string_pos): Don't use cached display
2169 string position if the buffer had its restriction changed.
2172 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2174 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2176 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2178 Integer signedness and overflow and related fixes. (Bug#9079)
2180 * bidi.c: Integer size and overflow fixes.
2181 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2182 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2183 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2184 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2185 (bidi_find_other_level_edge):
2186 Use ptrdiff_t instead of EMACS_INT where either will do.
2187 This works better on 32-bit hosts configured --with-wide-int.
2188 (bidi_cache_ensure_space): Check for size-calculation overflow.
2189 Use % rather than repeated addition, for better worst-case speed.
2190 Don't set bidi_cache_size until after xrealloc returns, because it
2192 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2193 (bidi_cache_ensure_space): Also check that the bidi cache size
2194 does not exceed that of the largest Lisp string or buffer. See Eli
2195 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2197 * alloc.c (__malloc_size_t): Remove.
2198 All uses replaced by size_t. See Andreas Schwab's note
2199 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2201 * image.c: Improve checking for integer overflow.
2202 (check_image_size): Assume that f is nonnull, since
2203 it is always nonnull in practice. This is one less thing to
2204 worry about when checking for integer overflow later.
2205 (x_check_image_size): New function, which checks for integer
2206 overflow issues inside X.
2207 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2208 This removes the need for a memory_full check.
2209 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2210 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2211 (xbm_read_bitmap_data): Change locals back to 'int', since
2212 their values must fit in 'int'.
2213 (xpm_load_image, png_load, tiff_load):
2214 Invoke x_create_x_image_and_pixmap earlier,
2215 to avoid much needless work if the image is too large.
2216 (tiff_load): Treat overly large images as if
2217 x_create_x_image_and_pixmap failed, not as malloc failures.
2218 (gs_load): Use x_check_image_size.
2220 * gtkutil.c: Omit integer casts.
2221 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2222 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2224 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2226 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2227 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2228 would wrongly return t on a 64-bit host.
2230 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2231 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2232 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2233 and therefore cause GCC to emit a bogus diagnostic in some cases.
2235 * image.c: Integer signedness and overflow and related fixes.
2236 This is not an exhaustive set of fixes, but it's time to
2237 record what I've got.
2238 (lookup_pixel_color, check_image_size): Remove redundant decls.
2239 (check_image_size): Don't assume that arbitrary EMACS_INT values
2240 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2241 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2242 (tiff_load, imagemagick_load_image):
2243 Check for overflow in size calculations.
2244 (x_create_x_image_and_pixmap): Remove unnecessary test for
2245 xmalloc returning NULL; that can't happen.
2246 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2247 (xpm_color_bucket): Use better integer hashing function.
2248 (xpm_cache_color): Don't possibly over-allocate memory.
2249 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2250 (gif_memory_source):
2251 Use ptrdiff_t, not int or size_t, to record sizes.
2252 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2253 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2254 either works, as we prefer signed integers.
2255 (tiff_read_from_memory, tiff_write_from_memory):
2256 Return tsize_t, not size_t, since that's what the TIFF API wants.
2257 (tiff_read_from_memory): Don't fail simply because the read would
2258 go past EOF; instead, return a short read.
2259 (tiff_load): Omit no-longer-needed casts.
2260 (Fimagemagick_types): Don't assume size fits into 'int'.
2262 Improve hashing quality when configured --with-wide-int.
2263 * fns.c (hash_string): New function, taken from sxhash_string.
2264 Do not discard information about ASCII character case; this
2265 discarding is no longer needed.
2266 (sxhash-string): Use it. Change sig to match it. Caller changed.
2267 * lisp.h: Declare it.
2268 * lread.c (hash_string): Remove, since we now use fns.c's version.
2269 The fns.c version returns a wider integer if --with-wide-int is
2270 specified, so this should help the quality of the hashing a bit.
2272 * emacs.c: Integer overflow minor fix.
2273 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2274 Define only if GNU_LINUX.
2275 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2277 * dispnew.c: Integer signedness and overflow fixes.
2278 Remove unnecessary forward decls, that were a maintenance hassle.
2279 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2281 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2282 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2283 (prepare_desired_row, line_draw_cost):
2284 Use int, not unsigned, where either works.
2285 (save_current_matrix, restore_current_matrix):
2286 Use ptrdiff_t, not size_t, where either works.
2287 (init_display): Check for overflow more accurately, and without
2288 relying on undefined behavior.
2290 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2291 Remove, replacing with the new symbols in lisp.h. All uses changed.
2292 * fileio.c (make_temp_name):
2293 * filelock.c (lock_file_1, lock_file):
2294 * xdisp.c (message_dolog):
2295 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2296 Use pMd etc. instead.
2297 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2298 replacing the pWIDE etc. symbols removed from editfns.c.
2300 * keyboard.h (num_input_events): Now uintmax_t.
2301 This is (very slightly) less likely to mess up due to wraparound.
2304 * buffer.c: Integer signedness fixes.
2305 (alloc_buffer_text, enlarge_buffer_text):
2306 Use ptrdiff_t rather than size_t when either will do, as we prefer
2309 * alloc.c: Integer signedness and overflow fixes.
2310 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2311 (__malloc_size_t): Default to size_t, not to int.
2312 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2313 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2314 Prefer ptrdiff_t to size_t when either would do, as we prefer
2316 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2317 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2318 Now const. Initialize with values that are in range even if char
2320 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2321 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2322 These functions do the right thing with sizes > 2**32.
2323 (check_depth): Now ptrdiff_t, not int.
2324 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2325 Adjust to new way of storing sizes. Check for size overflow bugs
2327 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2328 slightly wrong anyway, as it missed one instance of
2329 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2330 (refill_memory_reserve): Omit needless cast to size_t.
2331 (mark_object_loop_halt): Mark as externally visible.
2333 * xselect.c: Integer signedness and overflow fixes.
2334 (Fx_register_dnd_atom, x_handle_dnd_message):
2335 Use ptrdiff_t, not size_t, since we prefer signed.
2336 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2337 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2338 x_dnd_atoms_size and x_dnd_atoms_length.
2340 * doprnt.c: Prefer signed to unsigned when either works.
2342 * doprnt.c (doprnt):
2344 * xdisp.c (vmessage):
2345 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2346 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2347 prefer signed arithmetic to avoid comparison confusion.
2348 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2349 but is a bit tricky.
2351 Assume freestanding C89 headers, string.h, stdlib.h.
2352 * data.c, doprnt.c, floatfns.c, print.c:
2353 Include float.h unconditionally.
2354 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2355 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2356 * regex.c: Likewise for stddef.h, string.h.
2357 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2358 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2359 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2360 (STDC_HEADERS): Remove obsolete defines.
2361 * sysdep.c: Include limits.h unconditionally.
2363 Assume support for memcmp, memcpy, memmove, memset.
2364 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2365 * regex.c (memcmp, memcpy):
2366 Remove; we assume C89 now.
2368 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2369 (__malloc_safe_bcopy): Remove; no longer needed.
2371 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2372 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2373 well either way, and we prefer signed to unsigned.
2375 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2377 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2378 closes the connection while we're reading (bug#9182).
2380 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2382 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2383 are specified (Bug#9168).
2385 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2387 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2388 Found by GCC static checking and --with-wide-int on a 32-bit host.
2390 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2392 * xdisp.c (compute_display_string_pos): Fix logic of caching
2393 previous display string position. Initialize cached_prev_pos to
2394 -1. Fixes slow-down at the beginning of a buffer.
2396 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2398 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2399 for attrs[LFACE_FONTSET_INDEX].
2401 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2403 * xml.c (parse_region): Remove unused local
2404 that was recently introduced.
2406 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2408 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2409 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2411 * xdisp.c (move_it_in_display_line_to): Record the best matching
2412 position for TO_CHARPOS while scanning the line, and restore it on
2413 exit if none of the characters scanned was an exact match.
2414 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2415 when exact match is impossible due to invisible text, and the
2416 lines are truncated.
2418 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2420 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2423 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2425 Fix a significant slow-down of cursor motion with C-n, C-p,
2426 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2427 auto-repeat under bidi redisplay in fontified buffers.
2428 * xdisp.c (compute_stop_pos_backwards): New function.
2429 (next_element_from_buffer): Call compute_stop_pos_backwards to
2430 find a suitable prev_stop when we find ourselves before
2432 (reseat): Don't look for prev_stop, as that could mean a very long
2434 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2435 <cached_disp_overlay_modiff>: Cache for last found display string
2437 (compute_display_string_pos): Return the cached position if asked
2438 about the same buffer in the same area of character positions, and
2439 the buffer wasn't changed since the time the display string
2440 position was cached.
2442 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2444 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2445 is an integer, which is important for empty lines. (Bug#9149)
2447 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2449 * frame.c (Fmodify_frame_parameters): In tty case, update the
2450 default face if necessary (Bug#4238).
2452 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2454 * editfns.c (Fstring_to_char): No need to explain what a character
2455 is in the docstring (Bug#6576).
2457 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2459 * xml.c (parse_region): Make sure we always return a tree.
2461 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2463 * xml.c (parse_region): If a document contains only comments,
2466 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2468 * xml.c (make_dom): Return comments, too.
2470 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2473 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2474 and the surrounding thread.
2475 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2476 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2477 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2479 * s/openbsd.h (BROKEN_SIGIO): Define.
2480 * unexelf.c (unexec) [__OpenBSD__]:
2481 Don't update the .mdebug section of the Alpha COFF symbol table.
2483 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2485 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2488 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2490 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2491 This fixes some race conditions on the permissions of any newly
2494 * alloc.c (valid_pointer_p): Use pipe, not open.
2495 This fixes some permissions issues when debugging.
2497 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2498 If fchown fails to set both uid and gid, try to set just gid,
2499 as that is sometimes allowed. Adjust the file's mode to eliminate
2500 setuid or setgid bits that are inappropriate if fchown fails.
2502 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2504 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2505 to compare Lisp_Objects.
2506 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2507 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2508 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2510 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2512 * lread.c (read_integer): Unread even EOF character.
2513 (read1): Likewise. Properly record start position of symbol.
2515 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2516 symbol character follows.
2518 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2520 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2521 This works around a problem with the previous change to Fcopy_file.
2522 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2523 and without this change, GCC might complain about discarding
2524 fchown's return value.
2526 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2528 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2530 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2532 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2534 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2536 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2537 it's used from the C level.
2539 * process.c: Use the same condition for POLL_FOR_INPUT in both
2540 keyboard.c and process.c (bug#1858).
2542 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2544 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2545 (Fgnutls_boot): Use it.
2547 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2549 * doc.c (Fsubstitute_command_keys): Revert last change.
2551 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2553 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2554 quotes the next character, and doesn't affect other longer
2555 sequences (bug#8935).
2557 * lread.c (syms_of_lread): Clarify that is isn't only
2558 `eval-buffer' and `eval-defun' that's affected by
2559 `lexical-binding' (bug#8460).
2561 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2563 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2564 bidi redisplay when a line includes both an image and is truncated.
2566 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2568 Fix minor problems found by static checking.
2569 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2570 (elsz): Now a signed constant, not a size_t var. We prefer signed
2571 types to unsigned, to avoid integer comparison confusion. Without
2572 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2573 "cannot optimize loop, the loop counter may overflow", a symptom
2575 * indent.c (Fvertical_motion): Mark locals as initialized.
2576 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2578 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2580 * search.c (Fre_search_backward): Mention `case-fold-search' in
2581 all the re_search_* functions (bug#8138).
2583 * keyboard.c (Fopen_dribble_file): Document when the file is
2586 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2588 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2591 Support bidi reordering of display and overlay strings.
2592 * xdisp.c (compute_display_string_pos)
2593 (compute_display_string_end): Accept additional argument STRING.
2594 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2595 (reseat_to_string): Initialize bidi_it->string.s and
2596 bidi_it->string.schars.
2597 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2598 NULL (avoids a crash in bidi_paragraph_init).
2599 Initialize itb.string.lstring.
2600 (init_iterator): Call bidi_init_it only of a valid
2601 buffer position was specified. Initialize paragraph_embedding to
2603 (reseat_to_string): Initialize the bidi iterator.
2604 (display_string): If we need to ignore text properties of
2605 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2606 original value of -1 will not work with bidi.)
2607 (compute_display_string_pos): First arg is now struct
2608 `text_pos *'; all callers changed. Support display properties on
2610 (compute_display_string_end): Support display properties on Lisp
2612 (init_iterator, reseat_1, reseat_to_string): Initialize the
2613 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2614 when iterating on a string not from display properties).
2615 (compute_display_string_pos, compute_display_string_end):
2616 Fix calculation of the object to scan. Fixes an error when using
2618 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2619 base_level_stop; instead, set base_level_stop to BEGV.
2620 Fixes crashes in vertical-motion.
2621 (next_element_from_buffer): Improve commentary for when
2622 the iterator is before prev_stop.
2623 (init_iterator): Initialize bidi_p from the default value of
2624 bidi-display-reordering, not from buffer-local value. Use the
2625 buffer-local value only if initializing for buffer iteration.
2626 (handle_invisible_prop): Support invisible properties on strings
2627 that are being bidi-reordered.
2628 (set_iterator_to_next): Support bidi reordering of C strings and
2630 (next_element_from_string): Support bidi reordering of Lisp
2632 (handle_stop_backwards): Support Lisp strings as well.
2633 (display_string): Support display of R2L glyph rows.
2634 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2635 (init_iterator): Don't initialize it->bidi_p for strings
2637 (reseat_to_string): Initialize it->bidi_p for strings here.
2638 (next_element_from_string, next_element_from_c_string)
2639 (next_element_from_buffer): Add xassert's for correspondence
2640 between IT's object being iterated and it->bidi_it.string
2642 (face_before_or_after_it_pos): Support bidi iteration.
2643 (next_element_from_c_string): Handle the case of the first string
2644 character that is not the first one in the visual order.
2645 (get_visually_first_element): New function, refactored from common
2646 parts of next_element_from_buffer, next_element_from_string, and
2647 next_element_from_c_string.
2648 (tool_bar_lines_needed, redisplay_tool_bar)
2649 (display_menu_bar): Force left-to-right direction. Add a FIXME
2650 comment for making that be controlled by a user option.
2651 (push_it, pop_it): Save and restore the state of the
2652 bidi iterator. Save and restore the bidi_p flag.
2653 (pop_it): Iterate out of display property for string iteration as
2655 (iterate_out_of_display_property): Support iteration over strings.
2656 (handle_single_display_spec): Set up it->bidi_it for iteration
2657 over a display string, and call bidi_init_it.
2658 (handle_single_display_spec, next_overlay_string)
2659 (get_overlay_strings_1, push_display_prop): Set up the bidi
2660 iterator for displaying display or overlay strings.
2661 (forward_to_next_line_start): Don't use the shortcut if
2663 (back_to_previous_visible_line_start): If handle_display_prop
2664 pushed the iterator stack, restore the internal state of the bidi
2665 iterator by calling bidi_pop_it same number of times.
2666 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2667 and we are bidi-iterating, don't decrement the iterator position;
2668 instead, set the first_elt flag in the bidi iterator, to produce
2670 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2671 (push_display_prop): xassert that we are iterating a buffer.
2672 (push_it, pop_it): Save and restore paragraph_embedding member.
2673 (handle_single_display_spec, next_overlay_string)
2674 (get_overlay_strings_1, reseat_1, reseat_to_string)
2675 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2676 correctly. Don't assume unibyte strings are not bidi-reordered.
2677 (compute_display_string_pos)
2678 (compute_display_string_end): Fix handling the case of C string.
2679 (push_it, pop_it): Save and restore from_disp_prop_p.
2680 (handle_single_display_spec, push_display_prop): Set the
2681 from_disp_prop_p flag.
2682 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2683 (pop_it): Call iterate_out_of_display_property only if we are
2684 popping after iteration over a string that came from a display
2685 property. Fix a typo in popping stretch info. Add an assertion
2686 for verifying that the iterator position is in sync with the bidi
2688 (handle_single_display_spec, get_overlay_strings_1)
2689 (push_display_prop): Fix initialization of paragraph direction for
2690 string when that of the parent object is not yet determined.
2691 (reseat_1): Call bidi_init_it to resync the bidi
2692 iterator with IT's position. (Bug#7616)
2693 (find_row_edges): If ROW->start.pos gives position
2694 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2695 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2696 Reset the from_disp_prop_p flag.
2697 (SAVE_IT, RESTORE_IT): New macros.
2698 (pos_visible_p, face_before_or_after_it_pos)
2699 (back_to_previous_visible_line_start)
2700 (move_it_in_display_line_to, move_it_in_display_line)
2701 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2702 (try_scrolling, redisplay_window, display_line): Use them when
2703 saving a temporary copy of the iterator and restoring it back.
2704 (back_to_previous_visible_line_start, reseat_1)
2705 (init_iterator): Empty the bidi cache "stack".
2706 (move_it_in_display_line_to): If iterator ended up at
2707 EOL, but we never saw any buffer positions smaller than
2708 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2709 motion in bidi-reordered lines.
2710 (move_it_in_display_line_to): Record prev_method and prev_pos
2711 immediately before the call to set_iterator_to_next. Fixes cursor
2712 motion in bidi-reordered lines with stretch glyphs and strings
2713 displayed in margins. (Bug#8133) (Bug#8867)
2714 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2716 (pos_visible_p): Support positions in bidi-reordered lines.
2717 Save and restore bidi cache.
2719 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2720 (bidi_paragraph_info): Delete unused struct.
2721 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2722 (bidi_cache_start): New variable.
2723 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2725 (bidi_cache_fetch_state, bidi_cache_search)
2726 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2727 (bidi_cache_find, bidi_peek_at_next_level)
2728 (bidi_level_of_next_char, bidi_find_other_level_edge)
2729 (bidi_move_to_visually_next): Compare cache index with
2730 bidi_cache_start rather than with zero.
2731 (bidi_fetch_char): Accept new argument STRING; all callers
2732 changed. Support iteration over a string. Support strings with
2733 display properties. Support unibyte strings. Fix the type of
2734 `len' according to what STRING_CHAR_AND_LENGTH expects.
2735 (bidi_paragraph_init, bidi_resolve_explicit_1)
2736 (bidi_resolve_explicit, bidi_resolve_weak)
2737 (bidi_level_of_next_char, bidi_move_to_visually_next):
2738 Support iteration over a string.
2739 (bidi_set_sor_type, bidi_resolve_explicit_1)
2740 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2741 can now be zero (for strings); special values 0 and -1 were
2742 changed to -1 and -2, respectively.
2743 (bidi_char_at_pos): New function.
2744 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2745 Call it instead of FETCH_MULTIBYTE_CHAR.
2746 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2747 initialized to valid values.
2748 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2750 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2751 the test for valid cached positions. Fix the logic for looking up
2752 the sentinel state in the cache. GCPRO the Lisp string we are
2754 (bidi_push_it, bidi_pop_it): New functions.
2755 (bidi_initialize): Initialize the bidi cache start stack pointer.
2756 (bidi_cache_ensure_space): New function, refactored from part of
2757 bidi_cache_iterator_state. Don't assume the required size is just
2758 one BIDI_CACHE_CHUNK away.
2759 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2760 (bidi_count_bytes, bidi_char_at_pos): New functions.
2761 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2762 always valid if bidi_cache_idx is valid.
2763 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2764 is valid if it's going to be used.
2765 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2766 (bidi_cache_fetch_state, bidi_cache_search)
2767 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2768 (bidi_cache_iterator_state, bidi_cache_find)
2769 (bidi_find_other_level_edge, bidi_cache_start_stack):
2770 All variables related to cache indices are now EMACS_INT.
2772 * dispextern.h (struct bidi_string_data): New structure.
2773 (struct bidi_it): New member `string'. Make flag members be 1-bit
2774 fields, and put them last in the struct.
2775 (compute_display_string_pos, compute_display_string_end):
2777 (bidi_push_it, bidi_pop_it): Add prototypes.
2778 (struct iterator_stack_entry): New members bidi_p,
2779 paragraph_embedding, and from_disp_prop_p.
2780 (struct it): Member bidi_p is now a bit field 1 bit wide.
2781 (bidi_shelve_cache, bidi_unshelve_cache):
2784 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2785 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2786 and vector-like objects.
2788 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2789 cache around display iteration.
2791 * window.c (Fwindow_end, window_scroll_pixel_based)
2792 (displayed_window_lines, Frecenter): Save and restore the bidi
2793 cache around display iteration.
2795 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2797 * editfns.c (Fdelete_region): Clarify the use of the named
2798 parameters (bug#6788).
2800 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2802 * indent.c (Fvertical_motion): Set and restore w->pointm when
2803 saving and restoring the window's buffer (Bug#9006).
2805 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2807 * editfns.c (Fstring_to_char): Clarify just what is returned
2808 (bug#6576). Text by Eli Zaretskii.
2810 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2812 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2814 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2816 * buffer.c (mmap_find): Fix a typo.
2818 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2820 Fix execution of x selection hooks.
2821 * xselect.c (Qx_lost_selection_functions)
2822 (Qx_sent_selection_functions): New vars.
2823 (syms_of_xselect): DEFSYM them.
2824 (x_handle_selection_request): Pass Qx_sent_selection_functions
2825 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2826 (x_handle_selection_clear,x_clear_frame_selections):
2827 Pass Qx_lost_selection_functions rather than
2828 Vx_lost_selection_functions to Frun_hook_with_args.
2830 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2832 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2833 The old code sometimes used this field without initializing it.
2835 * alloc.c (gc_sweep): Don't read past end of array.
2836 In theory, the old code could also have corrupted Emacs internals,
2837 though it'd be very unlikely.
2839 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2841 * character.c (Fcharacterp): Don't advertise optional ignored
2842 argument. (Bug#4026)
2844 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2846 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2849 * window.c (Fset_window_start): Doc fix (bug#4199).
2850 (Fset_window_hscroll): Ditto.
2852 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2854 Fix minor new problems caught by GCC 4.6.1.
2855 * term.c (init_tty): Remove unused local.
2856 * xsettings.c (store_monospaced_changed): Define this function only
2857 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2860 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2862 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2864 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2866 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2867 are the mini-buffer and the echo area (bug#3320).
2869 * term.c (init_tty): Remove support for supdup, c10 and perq
2870 terminals, which are no longer supported (bug#1482).
2872 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2874 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2876 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2878 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2879 for non-popups (Bug#3642).
2881 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2883 * alloc.c (reset_malloc_hooks): Protoize.
2884 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2885 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2886 * cm.c (losecursor): Likewise.
2887 * data.c (fmod): Likewise.
2888 * dispnew.c (swap_glyphs_in_rows): Likewise.
2889 * emacs.c (memory_warning_signal): Likewise.
2890 * floatfns.c (float_error): Likewise.
2891 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2892 (otf_open, font_otf_capability, generate_otf_features)
2893 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2895 * image.c (pbm_read_file): Likewise.
2896 * indent.c (string_display_width): Likewise.
2897 * intervals.c (check_for_interval, search_for_interval)
2898 (inc_interval_count, count_intervals, root_interval)
2899 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2900 * lread.c (defalias): Likewise.
2901 * ralloc.c (r_alloc_check): Likewise.
2902 * regex.c (set_image_of_range_1, set_image_of_range)
2903 (regex_grow_registers): Likewise.
2904 * sysdep.c (strerror): Likewise.
2905 * termcap.c (valid_filename_p, tprint, main): Likewise.
2906 * tparam.c (main): Likewise.
2907 * unexhp9k800.c (run_time_remap, save_data_space)
2908 (update_file_ptrs, read_header, write_header, calculate_checksum)
2909 (copy_file, copy_rest, display_header): Likewise.
2910 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2912 * xdisp.c (check_it): Likewise.
2913 * xfaces.c (register_color, unregister_color, unregister_colors):
2915 * xfns.c (print_fontset_result): Likewise.
2916 * xrdb.c (member, fatal, main): Likewise.
2918 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2920 Fix minor problems found by static checking (Bug#9031).
2921 * chartab.c (char_table_set_range, map_sub_char_table):
2922 Remove unused locals.
2923 (uniprop_table): Now static.
2924 * composite.c (_work_char): Remove unused static var.
2926 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2928 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2930 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2932 * gtkutil.c (qttip_cb): Remove code without function.
2934 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2936 * w32.c (pthread_sigmask): New stub.
2938 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2940 Use pthread_sigmask, not sigprocmask (Bug#9010).
2941 sigprocmask is portable only for single-threaded applications, and
2942 Emacs can be multi-threaded when it uses GTK.
2943 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2945 * callproc.c (Fcall_process):
2946 * process.c (create_process):
2947 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2948 Use pthread_sigmask, not sigprocmask.
2950 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2952 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2953 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2956 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2958 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2959 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2960 (xg_hide_tooltip): Fix comment.
2962 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2963 in registerServicesMenuSendTypes.
2964 (validRequestorForSendType): Don't check ns_return_types.
2966 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2969 2011-07-08 Jason Rumney <jasonr@gnu.org>
2971 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2972 SH_SHOW for hidden windows (Bug#5482).
2974 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2975 frame struct members of non-existent frames (Bug#6284).
2977 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2979 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2980 variable firstTime not needed on OSX >= 10.6.
2981 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2982 >= 10.5. Use setKnobProportion, setDoubleValue.
2984 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2985 (MAC_OS_X_VERSION_10_5): Define if not defined.
2986 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2987 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2988 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2990 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2991 cString and lossyCString on OSX >= 10.4
2993 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2994 sizeToFit on OSX >= 10.2.
2996 * nsimage.m (allocInitFromFile): Don't use deprecated method
2997 bestRepresentationForDevice on OSX >= 10.6.
2999 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3002 * emacs.c: Declare unexec_init_emacs_zone.
3004 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3006 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3008 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3009 on svcsMenu (Bug#8842).
3011 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3013 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3015 * nsterm.m (QUTF8_STRING): Declare.
3016 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3017 (validRequestorForSendType): Return type is (id).
3018 Change indexOfObjectIdenticalTo to indexOfObject.
3019 Check if we have local selection before returning self (Bug#8842).
3020 (writeSelectionToPasteboard): Put local selection into paste board
3021 if we have a local selection (Bug#8842).
3022 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3024 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3025 (ns_get_local_selection): Declare.
3027 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3029 * keymap.c (describe_map_tree): Don't insert a double newline at
3030 the end of the buffer (bug#1169) and return whether we inserted
3033 * callint.c (Fcall_interactively): Change "reading args" to
3034 "providing args" to try to clarify what it does (bug#1010).
3036 2011-07-07 Kenichi Handa <handa@m17n.org>
3038 * composite.c (composition_compute_stop_pos): Ignore a static
3039 composition starting before CHARPOS (Bug#8915).
3041 * xdisp.c (handle_composition_prop): Likewise.
3043 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3045 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3048 2011-07-07 Kenichi Handa <handa@m17n.org>
3050 * character.h (unicode_category_t): New enum type.
3052 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3053 (Qchar_code_property_table): New variable.
3054 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3055 (UNIPROP_COMPRESSED_FORM_P): New macros.
3056 (char_table_ascii): Uncompress the compressed values.
3057 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3058 Uncompress the compressed values.
3059 (sub_char_table_ref_and_range): Likewise.
3060 (char_table_ref_and_range): Uncompress the compressed values.
3061 (sub_char_table_set): New arg is_uniprop. Callers changed.
3062 Uncompress the compressed values.
3063 (sub_char_table_set_range): Args changed. Callers changed.
3064 (char_table_set_range): Adjuted for the above change.
3065 (map_sub_char_table): Delete args default_val and parent. Add arg
3066 top. Give decoded values to a Lisp function.
3067 (map_char_table): Adjust for the above change. Give decoded
3068 values to a Lisp function. Gcpro more variables.
3069 (uniprop_table_uncompress)
3070 (uniprop_decode_value_run_length): New functions.
3071 (uniprop_decoder, uniprop_decoder_count): New variables.
3072 (uniprop_get_decoder, uniprop_encode_value_character)
3073 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3075 (uniprop_encoder, uniprop_encoder_count): New variables.
3076 (uniprop_get_encoder, uniprop_table)
3077 (Funicode_property_table_internal, Fget_unicode_property_internal)
3078 (Fput_unicode_property_internal): New functions.
3079 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3080 Sunicode_property_table_internal, Sget_unicode_property_internal,
3081 and Sput_unicode_property_internal. Defvar_lisp
3082 char-code-property-alist.
3084 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3085 Vunicode_category_table.
3087 * font.c (font_range): Adjust for the change of
3088 Vunicode_category_table.
3090 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3092 * m/iris4d.h: Remove file, move contents ...
3093 * s/irix6-5.h: ... here.
3095 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3097 Remove unportable assumption about struct layout (Bug#8884).
3098 * alloc.c (mark_buffer):
3099 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3100 (clone_per_buffer_values): Don't assume that
3101 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3102 This isn't true in general, and it's particularly not true
3103 if Emacs is configured with --with-wide-int.
3104 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3105 New macros, used in the buffer.c change.
3107 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3109 * xsettings.c: Use both GConf and GSettings if both are available.
3110 (store_config_changed_event): Add comment.
3111 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3112 (store_tool_bar_style_changed): New functions.
3113 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3114 (struct xsettings): Move font inside HAVE_XFT.
3115 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3116 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3117 Move inside HAVE_XFT.
3118 (something_changed_gsettingsCB): Rename from something_changedCB.
3119 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3121 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3122 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3123 (something_changed_gconfCB): Rename from something_changedCB.
3124 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3125 (parse_settings): Move check for font inside HAVE_XFT.
3126 (read_settings, apply_xft_settings): Add comment.
3127 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3128 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3129 call store_font_name_changed.
3130 (xft_settings_event): Add comment.
3131 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3132 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3133 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3134 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3135 (xsettings_initialize): Call init_gsettings last.
3136 (xsettings_get_system_font, xsettings_get_system_normal_font):
3139 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3141 Random fixes. E.g., (random) never returned negative values.
3142 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3143 subseconds part to the entropy, as that's a bit more random.
3144 Prefer signed to unsigned, since the signedness doesn't matter and
3145 in general we prefer signed. When given a limit, use a
3146 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3147 latter isn't right if USE_2_TAGS_FOR_INTS.
3148 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3149 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3151 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * textprop.c (text_property_stickiness):
3154 Obey Vtext_property_default_nonsticky.
3155 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3156 * w32fns.c (syms_of_w32fns):
3157 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3159 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3161 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3162 This is more efficient than Ffile_directory_p and avoids a minor race.
3164 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3166 * buffer.c (Foverlay_put): Say what the return value is
3169 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3170 is a directory before asking whether to use the file name
3172 (barf_or_query_if_file_exists): Make the "File is a directory"
3173 error be more correct.
3175 * fns.c (Frequire): Remove the mention of the .gz files, since
3176 that's installation-specific, but keep the mention of
3177 `get-load-suffixes'.
3179 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3181 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3182 Report string overflow if the output is too long.
3184 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3186 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3187 (syms_of_gnutls): Remove duplicate DEFSYM for
3188 Qgnutls_bootprop_verify_hostname_error, an error for
3189 Qgnutls_bootprop_verify_error (which is no longer used).
3191 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3192 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3193 Also (re)move comments that are misplaced or no longer relevant.
3195 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3197 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3199 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3201 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3202 and background color parameters if they have been changed.
3204 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3206 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3208 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3210 * xsettings.c (SYSTEM_FONT): Define only when used.
3211 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3213 * keymap.c (access_keymap_1): Now static.
3215 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3217 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3218 leave any prefix arg for the up event (Bug#1586).
3220 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3222 * lread.c (syms_of_lread): Mention single symbols defined by
3223 `defvar' or `defconst' (bug#7154).
3225 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3226 (Frequire): Mention get-load-suffixes.
3228 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3230 * window.h (window): Remove clone_number slot.
3231 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3233 (make_parent_window, make_window, saved_window)
3234 (Fset_window_configuration, save_window_save): Don't deal with
3236 * buffer.c (Qclone_number): Remove declaration.
3237 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3239 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3241 Add multiple inheritance to keymaps.
3242 * keymap.c (Fmake_composed_keymap): New function.
3243 (Fset_keymap_parent): Simplify.
3244 (fix_submap_inheritance): Remove.
3245 (access_keymap_1): New function extracted from access_keymap to handle
3246 embedded parents and handle lists of maps.
3247 (access_keymap): Use it.
3248 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3249 (Fcopy_keymap): Handle embedded parents.
3250 (Fcommand_remapping, define_as_prefix): Simplify.
3251 (Fkey_binding): Simplify.
3252 (syms_of_keymap): Move minibuffer-local-completion-map,
3253 minibuffer-local-filename-completion-map,
3254 minibuffer-local-must-match-map, and
3255 minibuffer-local-filename-must-match-map to Elisp.
3256 (syms_of_keymap): Defsubr make-composed-keymap.
3257 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3258 (parse_menu_item): Trivial simplification.
3260 2011-07-01 Glenn Morris <rgm@gnu.org>
3262 * Makefile.in (SETTINGS_LIBS): Fix typo.
3264 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3266 * coding.c (Fencode_coding_string): Record the last coding system
3267 used, as the function doc string says (bug#8738).
3269 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3271 * xsettings.c (store_monospaced_changed): Take new font as arg and
3272 check for change against current_mono_font.
3273 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3274 (emacs_settings_constructor, emacs_settings_get_property)
3275 (emacs_settings_set_property, emacs_settings_class_init)
3276 (emacs_settings_init, gsettings_obj): Remove.
3277 (something_changedCB): New function for HAVE_GSETTINGS.
3278 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3279 with value as argument.
3280 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3281 g_settings_new (Bug#8967). Do not create gsettings_obj.
3282 Remove calls to g_settings_bind. Connect something_changedCB to
3285 * xgselect.c: Add defined (HAVE_GSETTINGS).
3286 (xgselect_initialize): Ditto.
3288 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3289 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3292 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3294 * eval.c (struct backtrace): Simplify and port the data structure.
3295 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3296 signed bit field, as this assumption is not portable and it makes
3297 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3298 "char debug_on_exit : 1" as this is not portable either; instead,
3299 use the portable "unsigned int debug_on_exit : 1". Remove unused
3300 member evalargs. Remove obsolete comments about cc bombing out.
3302 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3304 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3305 Let HAVE_GSETTINGS override HAVE_GCONF.
3306 (store_monospaced_changed): New function.
3307 (EMACS_SETTINGS): A new type derived from GObject to handle
3308 GSettings notifications.
3309 (emacs_settings_constructor, emacs_settings_get_property)
3310 (emacs_settings_set_property, emacs_settings_class_init):
3312 (gsettings_client, gsettings_obj): New variables.
3313 (GSETTINGS_SCHEMA): New define.
3314 (something_changedCB): Call store_monospaced_changed.
3315 (init_gsettings): New function.
3316 (xsettings_initialize): Call init_gsettings.
3317 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3320 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3323 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3325 * window.c (resize_root_window, grow_mini_window)
3326 (shrink_mini_window): Rename Qresize_root_window to
3327 Qwindow_resize_root_window and Qresize_root_window_vertically to
3328 Qwindow_resize_root_window_vertically.
3330 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3332 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3334 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3336 * makefile.w32-in: Redesign dependencies so they reflect more
3337 clearly which files are directly included by each source file,
3338 and not through other includes.
3340 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3342 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3343 (sort_overlays, overlay_strings): When an overlay's clone number
3344 matches the window's clone number process the overlay even if
3345 the overlay's window property doesn't match the current window.
3347 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3348 (Fwindow_hchild): Rename to Fwindow_left_child.
3349 (Fwindow_next): Rename to Fwindow_next_sibling.
3350 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3351 (resize_window_check): Rename to window_resize_check.
3352 (resize_window_apply): Rename to window_resize_apply.
3353 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3354 (Fdelete_other_windows_internal, resize_frame_windows)
3355 (Fsplit_window_internal, Fdelete_window_internal)
3356 (grow_mini_window, shrink_mini_window)
3357 (Fresize_mini_window_internal): Fix callers accordingly.
3359 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3361 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3362 (emacs_fixed_set_min_size): Remove.
3363 (emacs_fixed_new): Take frame as argument.
3365 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3366 (_EmacsFixedPrivate): Remove minwidth/height.
3367 Add struct frame *f.
3368 (emacs_fixed_init): Initialize priv->f.
3369 (get_parent_class, emacs_fixed_set_min_size): Remove.
3370 (emacs_fixed_new): Set priv->f to argument.
3371 (emacs_fixed_get_preferred_width)
3372 (emacs_fixed_get_preferred_height): Use min_width/height from
3373 frames size_hint to set minimum and natural (Bug#8919).
3374 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3375 and use min_width/height from frames size_hint to set
3376 min_width/height (Bug#8919).
3378 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3379 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3382 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3384 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3385 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3388 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3390 * process.c (wait_reading_process_output): Bypass select if
3391 waiting for a cell while ignoring keyboard input, and input is
3392 pending. Suggested by Jan Djärv (Bug#8869).
3394 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3396 Use gnulib's dup2 module instead of rolling our own.
3397 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3399 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3401 * dispnew.c (scrolling_window): Before scrolling, turn off a
3402 mouse-highlight in the window being scrolled.
3404 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3406 Move DEFSYM to lisp.h and use everywhere.
3408 * character.h (DEFSYM): Move declaration...
3409 * lisp.h (DEFSYM): ...here.
3415 * w32select.c: Don't include character.h.
3417 * alloc.c (syms_of_alloc):
3418 * buffer.c (syms_of_buffer):
3419 * bytecode.c (syms_of_bytecode):
3420 * callint.c (syms_of_callint):
3421 * casefiddle.c (syms_of_casefiddle):
3422 * casetab.c (init_casetab_once):
3423 * category.c (init_category_once, syms_of_category):
3424 * ccl.c (syms_of_ccl):
3425 * cmds.c (syms_of_cmds):
3426 * composite.c (syms_of_composite):
3427 * dbusbind.c (syms_of_dbusbind):
3428 * dired.c (syms_of_dired):
3429 * dispnew.c (syms_of_display):
3430 * doc.c (syms_of_doc):
3431 * editfns.c (syms_of_editfns):
3432 * emacs.c (syms_of_emacs):
3433 * eval.c (syms_of_eval):
3434 * fileio.c (syms_of_fileio):
3435 * fns.c (syms_of_fns):
3436 * frame.c (syms_of_frame):
3437 * fringe.c (syms_of_fringe):
3438 * insdel.c (syms_of_insdel):
3439 * keymap.c (syms_of_keymap):
3440 * lread.c (init_obarray, syms_of_lread):
3441 * macros.c (syms_of_macros):
3442 * msdos.c (syms_of_msdos):
3443 * print.c (syms_of_print):
3444 * process.c (syms_of_process):
3445 * search.c (syms_of_search):
3446 * sound.c (syms_of_sound):
3447 * syntax.c (init_syntax_once, syms_of_syntax):
3448 * terminal.c (syms_of_terminal):
3449 * textprop.c (syms_of_textprop):
3450 * undo.c (syms_of_undo):
3451 * w32.c (globals_of_w32):
3452 * window.c (syms_of_window):
3453 * xdisp.c (syms_of_xdisp):
3454 * xfaces.c (syms_of_xfaces):
3455 * xfns.c (syms_of_xfns):
3456 * xmenu.c (syms_of_xmenu):
3457 * xsettings.c (syms_of_xsettings):
3458 * xterm.c (syms_of_xterm): Use DEFSYM.
3460 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3462 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3464 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3466 Integer and buffer overflow fixes (Bug#8873).
3468 * print.c (printchar, strout): Check for string overflow.
3469 (PRINTPREPARE, printchar, strout):
3470 Don't set size unless allocation succeeds.
3472 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3473 for sizes. Check for string overflow more accurately.
3474 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3476 * macros.c: Integer and buffer overflow fixes.
3477 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3478 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3479 Use ptrdiff_t, not int, for sizes.
3480 Don't increment bufsize until after realloc succeeds.
3481 Check for size-calculation overflow.
3482 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3484 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3486 * lread.c: Integer overflow fixes.
3487 (read_integer): Radix is now EMACS_INT, not int,
3488 to improve quality of diagnostics for out-of-range radices.
3489 Calculate buffer size correctly for out-of-range radices.
3490 (read1): Check for integer overflow in radices, and in
3491 read-circle numbers.
3492 (read_escape): Avoid int overflow.
3493 (Fload, openp, read_buffer_size, read1)
3494 (substitute_object_recurse, read_vector, read_list, map_obarray):
3495 Use ptrdiff_t, not int, for sizes.
3496 (read1): Use EMACS_INT, not int, for sizes.
3497 Check for size overflow.
3499 * image.c (cache_image): Check for size arithmetic overflow.
3501 * lread.c: Integer overflow issues.
3502 (saved_doc_string_size, saved_doc_string_length)
3503 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3504 Now ptrdiff_t, not int.
3505 (read1): Don't assume doc string length fits in int. Check for
3506 out-of-range doc string lengths.
3507 (read_list): Don't assume file position fits in int.
3508 (read_escape): Check for hex character overflow.
3510 2011-06-22 Leo Liu <sdl.web@gmail.com>
3512 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3513 Move to minibuffer.el.
3515 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3517 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3518 The following patches are for when GLYPH_DEBUG && !XASSERT.
3519 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3520 * dispnew.c (flush_stdout):
3521 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3522 Mark as externally visible.
3523 * dispnew.c (check_window_matrix_pointers): Now static.
3524 * dispnew.c (window_to_frame_vpos):
3525 * xfns.c (unwind_create_frame):
3526 * xterm.c (x_check_font): Remove unused local.
3527 * scroll.c (CHECK_BOUNDS):
3528 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3529 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3530 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3531 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3532 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3534 (debug_method_add): Use va_list and vsprintf rather than relying
3535 on undefined behavior with wrong number of arguments.
3536 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3537 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3538 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3539 since we're not interested in debugging glyphs with old libraries.
3540 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3541 GCC 4.6.0's static checking.
3543 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3545 Integer overflow and signedness fixes (Bug#8873).
3546 A few related buffer overrun fixes, too.
3548 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3550 * dispextern.h (struct face.stipple):
3551 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3552 (x_bitmap_mask, x_allocate_bitmap_record)
3553 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3554 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3555 (x_create_bitmap_from_xpm_data):
3556 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3557 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3559 * xfaces.c (load_pixmap):
3560 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3561 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3562 (.bitmaps_last, struct x_output.icon_bitmap):
3563 Use ptrdiff_t, not int, for bitmap indexes.
3564 (x_allocate_bitmap_record): Check for size overflow.
3565 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3567 Use ptrdiff_t, not int, for overlay counts.
3568 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3569 * editfns.c (overlays_around, get_pos_property):
3570 * textprop.c (get_char_property_and_overlay):
3571 * xdisp.c (next_overlay_change, note_mouse_highlight):
3572 * xfaces.c (face_at_buffer_position):
3573 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3574 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3575 (Fnext_overlay_change, Fprevious_overlay_change)
3576 (mouse_face_overlay_overlaps, Foverlays_in):
3577 Use ptrdiff_t, not int, for sizes.
3578 (overlays_at, overlays_in): Check for size-calculation overflow.
3580 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3582 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3583 (x_session_initialize): Do not assume string length fits in int.
3585 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3586 This is unlikely, but can occur if DPI is outlandish.
3588 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3589 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3591 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3592 * xrdb.c (magic_file_p, search_magic_path):
3593 Omit last arg SUFFIX; it was always 0. All callers changed.
3594 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3596 * xfont.c (xfont_match): Avoid need for strlen.
3598 * xfns.c: Don't assume strlen fits in int.
3599 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3601 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3602 not unsigned long, as we prefer signed integers. All callers changed.
3603 Detect integer overflow in repeat count.
3604 (message_dolog): Don't assume print length fits in 39 bytes.
3605 (display_mode_element): Don't assume strlen fits in int.
3607 * termcap.c: Don't assume sizes fit in int and never overflow.
3608 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3609 (gobble_line): Check for size-calculation overflow.
3611 * minibuf.c (Fread_buffer):
3612 * lread.c (intern, intern_c_string):
3613 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3614 Don't assume string length fits in int.
3616 * keyboard.c (parse_tool_bar_item):
3617 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3619 * font.c: Don't assume string length fits in int.
3620 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3621 Use ptrdiff_t, not int.
3622 (font_intern_prop): Don't assume string length fits in int.
3623 Don't assume integer property fits in fixnum.
3624 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3626 * filelock.c: Fix some buffer overrun and integer overflow issues.
3627 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3628 Reformulate so as not to need the command string.
3629 Invoke gzip -cd rather than gunzip, as it's more portable.
3630 (lock_info_type, lock_file_1, lock_file):
3631 Don't assume pid_t and time_t fit in unsigned long.
3632 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3633 (current_lock_owner): Prefer signed type for sizes.
3634 Use memcpy, not strncpy, where memcpy is what is really wanted.
3635 Don't assume (via atoi) that time_t and pid_t fit in int.
3636 Check for time_t and/or pid_t out of range, e.g., via a network share.
3637 Don't alloca where an auto var works fine.
3639 * fileio.c: Fix some integer overflow issues.
3640 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3641 Don't assume string length fits in int.
3642 (directory_file_name): Don't assume string length fits in long.
3643 (make_temp_name): Don't assume pid fits in int, or that its print
3644 length is less than 20.
3646 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3648 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3650 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3652 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3653 We prefer signed integers, even for size calculations.
3655 * emacs.c: Don't assume string length fits in 'int'.
3656 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3657 (main): Don't invoke strlen when not needed.
3659 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3660 (XD_DEBUG_MESSAGE): Don't waste a byte.
3662 * callproc.c (getenv_internal_1, getenv_internal)
3664 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3666 * lread.c (invalid_syntax): Omit length argument.
3667 All uses changed. This doesn't fix a bug, but it simplifies the
3668 code away from its former Hollerith-constant appearance, and it's
3669 one less 'int' to worry about when looking at integer-overflow issues.
3670 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3672 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3673 This didn't break anything, but it didn't help either.
3674 It's confusing to put a bogus integer in a place where the actual
3675 value does not matter.
3676 (LIST_END_P): Remove unused macro and its bogus comment.
3677 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3679 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3680 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3682 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3683 We prefer signed types, and the value cannot exceed the EMACS_INT
3684 range anyway (because otherwise the length would not be representable).
3685 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3686 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3687 This avoids a GCC warning when WIDE_EMACS_INT.
3689 * indent.c (sane_tab_width): New function.
3690 (current_column, scan_for_column, Findent_to, position_indentation)
3691 (compute_motion): Use it. This is just for clarity.
3692 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3694 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3696 * lisp.h (lint_assume): New macro.
3697 * composite.c (composition_gstring_put_cache):
3698 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3700 * editfns.c, insdel.c:
3701 Omit unnecessary forward decls, to simplify future changes.
3703 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3705 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3707 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3708 Use much-faster test for byte-length change.
3709 Don't assume string byte-length fits in 'int'.
3710 Check that character arg fits in 'int'.
3711 (mapcar1): Declare byte as byte, for clarity.
3713 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3715 * fns.c (concat): Catch string overflow earlier.
3716 Do not rely on integer wraparound.
3718 * dispextern.h (struct it.overlay_strings_charpos)
3719 (struct it.selective): Now EMACS_INT, not int.
3720 * xdisp.c (forward_to_next_line_start)
3721 (back_to_previous_visible_line_start)
3722 (reseat_at_next_visible_line_start, next_element_from_buffer):
3723 Don't arbitrarily truncate the value of 'selective' to int.
3725 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3727 * composite.c: Don't truncate sizes to 'int'.
3728 (composition_gstring_p, composition_reseat_it)
3729 (composition_adjust_point): Use EMACS_INT, not int.
3730 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3731 not EMACS_UINT, for indexes.
3733 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3735 * buffer.c: Include <verify.h>.
3736 (struct sortvec.priority, struct sortstr.priority):
3737 Now EMACS_INT, not int.
3738 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3739 (struct sortstr.size, record_overlay_string)
3740 (struct sortstrlist.size, struct sortlist.used):
3741 Don't truncate size to int.
3742 (record_overlay_string): Check for size-calculation overflow.
3743 (init_buffer_once): Check at compile-time, not run-time.
3745 2011-06-22 Jim Meyering <meyering@redhat.com>
3747 Don't leak an XBM-image-sized buffer
3748 * image.c (xbm_load): Free the image buffer after using it.
3750 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3753 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3754 that Sun C diagnosed.
3755 * fns.c (secure_hash): Fix pointer signedness issue.
3756 * intervals.c (static_offset_intervals): New function.
3757 (offset_intervals): Use it.
3759 2011-06-21 Leo Liu <sdl.web@gmail.com>
3762 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3765 * fns.c (secure_hash): Rename from crypto_hash_function and change
3766 the first arg to accept symbols.
3767 (Fsecure_hash): New primitive.
3768 (syms_of_fns): New symbols.
3770 2011-06-20 Deniz Dogan <deniz@dogan.se>
3772 * process.c (Fset_process_buffer): Clarify return value in
3775 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3777 * dispnew.c (add_window_display_history): Use BVAR.
3779 * xdisp.c (debug_method_add): Use BVAR.
3780 (check_window_end, dump_glyph_matrix, dump_glyph)
3781 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3783 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3786 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3787 check till after the cache is created in init_frame_faces.
3789 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3791 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3793 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3795 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3796 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3797 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3799 Improve buffer-overflow checking (Bug#8873).
3800 * fileio.c (Finsert_file_contents):
3801 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3802 Remove the old (too-loose) buffer overflow checks.
3803 They weren't needed, since make_gap checks for buffer overflow.
3804 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3805 The old code merely checked for Emacs fixnum overflow, and relied
3806 on undefined (wraparound) behavior. The new code avoids undefined
3807 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3809 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3810 Tune. Don't use wider integers than needed. Don't use alloca.
3811 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3813 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3815 * insdel.c, lisp.h (buffer_overflow): New function.
3816 (insert_from_buffer_1, replace_range, replace_range_2):
3817 * insdel.c (make_gap_larger):
3818 * editfns.c (Finsert_char):
3819 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3821 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3823 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3825 Integer overflow and signedness fixes (Bug#8873).
3827 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3828 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3830 * fileio.c: Don't assume EMACS_INT fits in off_t.
3831 (emacs_lseek): New static function.
3832 (Finsert_file_contents, Fwrite_region): Use it.
3833 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3835 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3837 * fns.c: Don't overflow int when computing a list length.
3838 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3839 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3840 truncation on 64-bit hosts. Check for QUIT every
3841 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3842 faster and is responsive enough.
3843 (Flength): Report an error instead of overflowing an integer.
3844 (Fsafe_length): Return a float if the value is not representable
3845 as a fixnum. This shouldn't happen except in contrived situations.
3846 (Fnthcdr, Fsort): Don't assume list length fits in int.
3847 (Fcopy_sequence): Don't assume vector length fits in int.
3849 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3850 (header_size, word_size): New constants.
3851 (allocate_vectorlike): Don't check size overflow here.
3852 (allocate_vector): Check it here instead, since this is the only
3853 caller of allocate_vectorlike that could cause overflow.
3854 Check that the new vector's length is representable as a fixnum.
3856 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3857 The previous code was bogus. For example, next_almost_prime (32)
3858 returned 39, which is undesirable as it is a multiple of 3; and
3859 next_almost_prime (24) returned 25, which is a multiple of 5 so
3860 why was the code bothering to check for multiples of 7?
3862 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3864 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3866 Variadic C functions now count arguments with ptrdiff_t.
3867 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3868 Back then I didn't know that the Emacs coding style prefers signed int.
3869 Also, in the meantime I found a few more instances where arguments
3870 were being counted with int, which may truncate counts on 64-bit
3871 machines, or EMACS_INT, which may be unnecessarily wide.
3872 * lisp.h (struct Lisp_Subr.function.aMANY)
3873 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3874 Arg counts are now ptrdiff_t, not size_t.
3875 All variadic functions and their callers changed accordingly.
3876 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3877 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3878 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3879 * callint.c (Fcall_interactively): Check arg count for overflow,
3880 to avoid potential buffer overrun. Use signed char, not 'int',
3881 for 'varies' array, so that we needn't bother to check its size
3882 calculation for overflow.
3883 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3884 * eval.c (apply_lambda):
3885 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3886 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3887 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3889 * callint.c (Fcall_interactively): Don't use index var as event count.
3891 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3892 * mem-limits.h (SIZE): Remove; no longer used.
3894 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3896 Remove unnecessary casts.
3897 * xterm.c (x_term_init):
3898 * xfns.c (x_set_border_pixel):
3899 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3900 These aren't needed now that we assume ANSI C.
3902 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3903 It's more likely to cause problems (due to unsigned overflow)
3906 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3908 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3910 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3912 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3914 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3916 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3918 GLYPH_CODE_FACE returns EMACS_INT, not int.
3919 * dispextern.h (merge_faces):
3920 * xfaces.c (merge_faces):
3921 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3922 Don't assume EMACS_INT fits in int.
3924 * character.h (CHAR_VALID_P): Remove unused parameter.
3925 * fontset.c, lisp.h, xdisp.c: All uses changed.
3927 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3929 * fns.c (concat): Minor tuning based on overflow analysis.
3930 This doesn't fix any bugs. Use int to hold character, instead
3931 of constantly refetching from Emacs object. Use XFASTINT, not
3932 XINT, for value known to be a character. Don't bother comparing
3933 a single byte to 0400, as it's always less.
3935 * floatfns.c (Fexpt):
3936 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3938 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3941 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3943 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3944 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3945 incorrectly succeed when S was a string, because 4294967386 was
3946 truncated before it was used.
3948 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3949 Otherwise, an out-of-range integer could cause undefined behavior
3952 * composite.c: Use int, not EMACS_INT, for characters.
3953 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3954 EMACS_INT, for values that are known to be in character range.
3955 This doesn't fix any bugs but is the usual style inside Emacs and
3956 may generate better code on 32-bit machines.
3958 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3959 This is for reasons similar to the recent CHAR_STRING fix.
3960 * charset.c (Fencode_char): Check that character arg is actually
3961 a character. Pass an int to ENCODE_CHAR.
3962 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3963 wider than 'int', as a compile-time check to prevent future regressions
3966 * character.c (char_string): Remove unnecessary casts.
3968 Make sure a 64-bit char is never passed to CHAR_STRING.
3969 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3970 by silently ignoring the top 32 bits, allowing some values
3971 that were far too large to be valid characters.
3972 * character.h: Include <verify.h>.
3973 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3974 arguments are no wider than unsigned, as a compile-time check
3975 to prevent future regressions in this area.
3977 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3978 (Fsubst_char_in_region):
3980 * xdisp.c (decode_mode_spec_coding):
3981 Adjust to CHAR_STRING's new requirement.
3982 * editfns.c (Finsert_char, Fsubst_char_in_region):
3983 * fns.c (concat): Check that character args are actually
3984 characters. Without this test, these functions did the wrong
3985 thing with wildly out-of-range values on 64-bit hosts.
3987 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3988 These casts should not be needed on 32-bit hosts, either.
3989 * keyboard.c (read_char):
3990 * lread.c (Fload): Remove casts to unsigned.
3992 * lisp.h (UNSIGNED_CMP): New macro.
3993 This fixes comparison bugs on 64-bit hosts.
3994 (ASCII_CHAR_P): Use it.
3995 * casefiddle.c (casify_object):
3996 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3997 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3998 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3999 * dispextern.h (FACE_FROM_ID):
4000 * keyboard.c (read_char): Use UNSIGNED_CMP.
4002 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4003 not to EMACS_INT, to avoid GCC warning.
4005 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4007 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4008 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4009 isn't needed on 32-bit machines.
4011 * buffer.c (Fgenerate_new_buffer_name):
4012 Use EMACS_INT for count, not int.
4013 (advance_to_char_boundary): Return EMACS_INT, not int.
4015 * data.c (Qcompiled_function): Now static.
4017 * window.c (window_body_lines): Now static.
4019 * image.c (gif_load): Rename local to avoid shadowing.
4021 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4022 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4023 * alloc.c (make_save_value): Integer argument is now of type
4025 (mark_object): Use ptrdiff_t, not int.
4026 * lisp.h (pD): New macro.
4027 * print.c (print_object): Use it.
4029 * alloc.c: Use EMACS_INT, not int, to count objects.
4030 (total_conses, total_markers, total_symbols, total_vector_size)
4031 (total_free_conses, total_free_markers, total_free_symbols)
4032 (total_free_floats, total_floats, total_free_intervals)
4033 (total_intervals, total_strings, total_free_strings):
4034 Now EMACS_INT, not int. All uses changed.
4035 (Fgarbage_collect): Compute overall total using a double, so that
4036 integer overflow is less likely to be a problem. Check for overflow
4037 when converting back to an integer.
4038 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4039 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4040 These were 'int' variables that could overflow on 64-bit hosts;
4041 they were never used, so remove them instead of repairing them.
4042 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4043 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4044 Previously, this ceilinged at INT_MAX, but that doesn't work on
4046 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4048 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4049 (allocate_vectorlike): Check for ptrdiff_t overflow.
4050 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4051 when a (possibly-narrower) signed value would do just as well.
4052 We prefer using signed arithmetic, to avoid comparison confusion.
4054 * alloc.c: Catch some string size overflows that we were missing.
4055 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4056 for convenience in STRING_BYTES_MAX.
4057 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4058 The definition here is exact; the one in lisp.h was approximate.
4059 (allocate_string_data): Check for string overflow. This catches
4060 some instances we weren't catching before. Also, it catches
4061 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4062 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4063 and ptrdiff_t and EMACS_INT are both 64 bits.
4065 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4066 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4067 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4069 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4071 * alloc.c (Fmake_string): Check for out-of-range init.
4073 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4075 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4077 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4079 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4080 xg_get_default_scrollbar_width.
4082 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4083 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4084 (style_changed_cb): Call update_theme_scrollbar_width and call
4085 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4086 all frames (Bug#8505).
4087 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4088 Call gtk_window_set_resizable if HAVE_GTK3.
4089 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4090 and height if HAVE_GTK3 (Bug#8505).
4091 (scroll_bar_width_for_theme): New variable.
4092 (update_theme_scrollbar_width): New function.
4093 (xg_get_default_scrollbar_width): Move code to
4094 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4095 (xg_initialize): Call update_theme_scrollbar_width.
4097 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4099 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4101 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4103 * frame.c (make_frame): Call other_buffer_safely instead of
4106 * window.c (temp_output_buffer_show): Call display_buffer with
4107 second argument Vtemp_buffer_show_specifiers and reset latter
4108 immediately after the call.
4109 (Vtemp_buffer_show_specifiers): New variable.
4110 (auto_window_vscroll_p, next_screen_context_lines)
4111 (Vscroll_preserve_screen_position): Remove leading asterisks from
4114 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4116 Fix minor problems found by GCC 4.6.0 static checking.
4117 * buffer.c (Qclone_number): Remove for now, as it's unused.
4118 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4119 (record_buffer): Remove unused local.
4120 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4121 (set_frame_buffer_list): Remove; unused.
4122 * frame.h (other_visible_frames): Remove decl.
4123 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4124 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4125 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4127 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4128 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4129 Define only if HAVE_GPM.
4130 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4131 (update_hints_inhibit): Remove; never set. All uses removed.
4132 * widgetprv.h (emacsFrameClassRec): Remove decl.
4133 * window.c (delete_deletable_window): Now returns void, since it
4134 wasn't returning anything.
4135 (compare_window_configurations): Remove unused locals.
4136 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4137 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4138 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4139 the same widths as pointers. This follows up on the 2011-05-06 patch.
4140 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4141 * xterm.h: Likewise.
4142 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4144 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4146 * makefile.w32-in: Update dependencies.
4147 (LISP_H): Add lib/intprops.h.
4149 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4151 * image.c (gif_load): Add animation frame delay to the metadata.
4152 (syms_of_image): Use DEFSYM. New symbol `delay'.
4154 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4156 * window.c (delete_deletable_window): Re-add.
4157 (Fset_window_configuration): Rewrite to handle dead buffers and
4158 consequently deletable windows.
4159 (window_tree, Fwindow_tree): Remove. Supply functionality in
4161 (compare_window_configurations): Simplify code.
4163 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4165 * image.c (imagemagick_load_image): Fix type mismatch.
4166 (Fimagemagick_types): Likewise.
4168 * window.h (replace_buffer_in_windows): Declare.
4170 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4172 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4173 Qclone_number. Remove external declaration of Qdelete_window.
4174 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4176 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4177 Run Qbuffer_list_update_hook if allowed.
4178 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4179 buffer list implementation.
4180 (other_buffer_safely): New function.
4181 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4182 calls to replace_buffer_in_windows and
4183 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4185 (record_buffer): Inhibit quitting and rewrite using quittable
4186 functions. Run Qbuffer_list_update_hook if allowed.
4187 (Frecord_buffer, Funrecord_buffer): New functions.
4188 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4189 Move switch-to-buffer to window.el.
4190 (bury-buffer): Move to window.el.
4191 (Vbuffer_list_update_hook): New variable.
4193 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4196 * window.h (resize_frame_windows): Move up in code.
4197 (Fwindow_frame): Remove EXFUN.
4198 (replace_buffer_in_all_windows): Remove prototype.
4199 (replace_buffer_in_windows_safely): Add prototype.
4201 * window.c: Declare Qdelete_window static again. Move down
4202 declaration of select_count.
4203 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4204 (Fother_window): Move to window.el.
4205 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4206 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4207 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4209 (replace_buffer_in_windows): Implement by calling
4210 Qreplace_buffer_in_windows.
4211 (replace_buffer_in_all_windows): Remove with some functionality
4212 moved into replace_buffer_in_windows_safely.
4213 (replace_buffer_in_windows_safely): New function.
4214 (select_window_norecord, select_frame_norecord): Move in front
4215 of run_window_configuration_change_hook. Remove now obsolete
4217 (Fset_window_buffer): Rewrite doc-string.
4218 Call Qrecord_window_buffer.
4219 (keys_of_window): Move binding for other-window to window.el.
4221 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4223 * dispextern.h (struct image): Replace data member, whose int_val
4224 and ptr_val fields were not used by anything, with a single
4227 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4228 (gif_clear_image, gif_load, imagemagick_load_image)
4229 (gs_clear_image, gs_load): Callers changed.
4231 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4233 * buffer.h: Include <time.h>, for time_t.
4234 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4236 Fix minor problems found by static checking.
4238 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4240 Make identifiers static if they are not used in other modules.
4241 * data.c (Qcompiled_function, Qframe, Qvector):
4242 * image.c (QimageMagick, Qsvg):
4243 * minibuf.c (Qmetadata):
4244 * window.c (resize_window_check, resize_root_window): Now static.
4245 * window.h (resize_window_check, resize_root_window): Remove decls.
4247 * window.c (window_deletion_count, delete_deletable_window):
4249 (window_body_lines): Now static.
4250 (Fdelete_other_windows_internal): Mark vars as initialized.
4251 Make sure 'resize_failed' is initialized.
4252 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4253 (resize_window_apply): Remove unused local.
4254 * window.h (delete_deletable_window): Remove decl.
4256 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4257 (imagemagick_load_image): Fix pointer signedness problem by changing
4258 last arg from unsigned char * to char *. All uses changed.
4259 Also, fix a local for similar reasons.
4260 Remove unused locals. Remove locals to avoid shadowing.
4261 (fn_rsvg_handle_free): Remove; unused.
4262 (svg_load, svg_load_image): Fix pointer signedness problem.
4263 (imagemagick_load_image): Don't use garbage pointer image_wand.
4265 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4267 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4269 * image.c (gif_load): Fix omitted cast error introduced by
4272 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4274 * window.h (resize_proportionally, orig_total_lines)
4275 (orig_top_line): Remove from window structure.
4276 (set_window_height, set_window_width, change_window_heights)
4277 (Fdelete_window): Remove prototypes.
4278 (resize_frame_windows): Remove duplicate declaration.
4280 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4282 * window.h (resize_frame_windows, resize_window_check)
4283 (delete_deletable_window, resize_root_window)
4284 (resize_frame_windows): Declare prototypes.
4286 * window.c (resize_window_apply): Make definition be "static" to
4287 match the prototype.
4289 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4291 * window.c: Remove declarations of Qwindow_size_fixed,
4292 window_min_size_1, window_min_size_2, window_min_size,
4293 size_window, window_fixed_size_p, enlarge_window, delete_window.
4294 Remove static from declaration of Qdelete_window, it's
4295 temporarily needed by Fbury_buffer.
4296 (replace_window): Don't assign orig_top_line and
4298 (Fdelete_window, delete_window): Remove. Window deletion is
4299 handled by window.el.
4300 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4301 Replace Fdelete_window calls with calls to Qdelete_window.
4302 (Fdelete_other_windows): Remove. Deleting other windows is
4303 handled by window.el.
4304 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4305 handled in window.el.
4306 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4307 Window minimum sizes are handled in window.el.
4308 (shrink_windows, size_window, set_window_height)
4309 (set_window_width, change_window_heights, window_height)
4310 (window_width, CURBEG, CURSIZE, enlarge_window)
4311 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4312 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4313 handled in window.el.
4314 (make_dummy_parent): Rename to make_parent_window and give it a
4315 second argument horflag.
4316 (make_window): Don't set resize_proportionally any more.
4317 (Fsplit_window): Remove. Windows are split in window.el.
4318 (save_restore_action, save_restore_orig_size)
4319 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4320 Resize mini windows in window.el.
4321 (grow_mini_window, shrink_mini_window): Implement by calling
4322 Qresize_root_window_vertically, resize_window_check and
4323 resize_window_apply.
4324 (saved_window, Fset_window_configuration, save_window_save):
4325 Do not handle orig_top_line, orig_total_lines, and
4326 resize_proportionally.
4327 (window_min_height, window_min_width): Move to window.el.
4328 (keys_of_window): Move bindings for delete-other-windows,
4329 split-window, delete-window and enlarge-window to window.el.
4331 * buffer.c: Temporarily extern Qdelete_window.
4332 (Fbury_buffer): Temporarily call Qdelete_window instead of
4333 Fdelete_window (Fbury_buffer will move to window.el soon).
4335 * frame.c (set_menu_bar_lines_1): Remove code handling
4336 orig_top_line and orig_total_lines.
4338 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4339 set_window_height but set heights directly.
4340 (change_frame_size_1): Use resize_frame_windows.
4342 * xdisp.c (init_xdisp): Don't use set_window_height but set
4345 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4346 Use resize_frame_windows instead of change_window_heights and run
4347 run_window_configuration_change_hook.
4349 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4350 instead of change_window_heights and run
4351 run_window_configuration_change_hook.
4353 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4355 * window.c (replace_window): Rename second argument REPLACEMENT to
4356 NEW. New third argument SETFLAG. Rewrite.
4357 (delete_window, make_dummy_parent): Call replace_window with
4359 (window_list_1): Move down in code.
4360 (run_window_configuration_change_hook): Move set_buffer part
4361 before select_frame_norecord part in order to unwind correctly.
4362 Rename count1 to count.
4363 (recombine_windows, delete_deletable_window, resize_root_window)
4364 (Fdelete_other_windows_internal)
4365 (Frun_window_configuration_change_hook, make_parent_window)
4366 (resize_window_check, resize_window_apply, Fresize_window_apply)
4367 (resize_frame_windows, Fsplit_window_internal)
4368 (Fdelete_window_internal, Fresize_mini_window_internal):
4370 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4372 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4374 * window.h (window): Add some new members to window structure -
4375 normal_lines, normal_cols, new_total, new_normal, clone_number,
4376 splits, nest, prev_buffers, next_buffers.
4377 (WINDOW_TOTAL_SIZE): Move here from window.c.
4378 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4380 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4382 (make_dummy_parent): Set new members of windows structure.
4383 (make_window): Move down in code. Handle new members of window
4385 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4386 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4387 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4388 (Fset_window_prev_buffers, Fwindow_next_buffers)
4389 (Fset_window_next_buffers, Fset_window_clone_number):
4391 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4392 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4394 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4395 Argument WINDOW can be now internal window too.
4396 (Fwindow_use_time): Move up in code.
4397 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4399 (Fset_window_configuration, saved_window)
4400 (Fcurrent_window_configuration, save_window_save): Handle new
4401 members of window structure.
4402 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4403 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4404 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4405 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4406 Qget_mru_window, Qresize_root_window,
4407 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4408 Qauto_buffer_name; staticpro them.
4410 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4412 * window.c (Fwindow_total_size, Fwindow_left_column)
4413 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4414 (Fwindow_list_1): New functions.
4415 (window_box_text_cols): Replace with window_body_cols.
4416 (Fwindow_width, Fscroll_left, Fscroll_right):
4417 Use window_body_cols instead of window_box_text_cols.
4418 (delete_window, Fset_window_configuration):
4419 Call delete_all_subwindows with window as argument.
4420 (delete_all_subwindows): Take a window as argument and not a
4422 (window_loop): Remove handling of GET_LRU_WINDOW and
4424 (Fget_lru_window, Fget_largest_window): Move to window.el.
4426 * window.h: Extern window_body_cols instead of
4427 window_box_text_cols. delete_all_subwindows now takes a
4428 Lisp_Object as argument.
4430 * indent.c (compute_motion, Fcompute_motion):
4431 Use window_body_cols instead of window_box_text_cols.
4433 * frame.c (delete_frame): Call delete_all_subwindows with root
4436 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4438 * fns.c (Fputhash): Document return value.
4440 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4442 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4444 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4446 Cons<->int and similar integer overflow fixes (Bug#8794).
4448 Check for overflow when converting integer to cons and back.
4449 * charset.c (Fdefine_charset_internal, Fdecode_char):
4450 Use cons_to_unsigned to catch overflow.
4451 (Fencode_char): Use INTEGER_TO_CONS.
4452 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4453 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4454 * data.c (long_to_cons, cons_to_long): Remove.
4455 (cons_to_unsigned, cons_to_signed): New functions.
4456 These signal an error for invalid or out-of-range values.
4457 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4458 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4459 * font.c (Ffont_variation_glyphs):
4460 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4461 * lisp.h: Include <intprops.h>.
4462 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4463 (cons_to_signed, cons_to_unsigned): New decls.
4464 (long_to_cons, cons_to_long): Remove decls.
4465 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4466 (Fprimitive_undo): Use CONS_TO_INTEGER.
4467 * xfns.c (Fx_window_property): Likewise.
4468 * xselect.c: Include <limits.h>.
4469 (x_own_selection, selection_data_to_lisp_data):
4470 Use INTEGER_TO_CONS.
4471 (x_handle_selection_request, x_handle_selection_clear)
4472 (x_get_foreign_selection, Fx_disown_selection_internal)
4473 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4474 (lisp_data_to_selection_data): Use cons_to_unsigned.
4475 (x_fill_property_data): Use cons_to_signed.
4476 Report values out of range.
4478 Check for buffer and string overflow more precisely.
4479 * buffer.h (BUF_BYTES_MAX): New macro.
4480 * lisp.h (STRING_BYTES_MAX): New macro.
4481 * alloc.c (Fmake_string):
4482 * character.c (string_escape_byte8):
4483 * coding.c (coding_alloc_by_realloc):
4484 * doprnt.c (doprnt):
4485 * editfns.c (Fformat):
4487 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4488 since they may not be the same number.
4489 * editfns.c (Finsert_char):
4490 * fileio.c (Finsert_file_contents):
4491 Likewise for BUF_BYTES_MAX.
4493 * image.c: Use ptrdiff_t, not int, for sizes.
4494 (slurp_file): Switch from int to ptrdiff_t.
4496 (slurp_file): Check that file size fits in both size_t (for
4497 malloc) and ptrdiff_t (for sanity and safety).
4499 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4500 if b->modtime has its maximal value.
4502 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4504 Don't assume time_t can fit into int.
4505 * buffer.h (struct buffer.modtime): Now time_t, not int.
4506 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4507 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4509 Minor fixes for signed vs unsigned integers.
4510 * character.h (MAYBE_UNIFY_CHAR):
4511 * charset.c (maybe_unify_char):
4512 * keyboard.c (read_char, reorder_modifiers):
4513 XINT -> XFASTINT, since the integer must be nonnegative.
4514 * ftfont.c (ftfont_spec_pattern):
4515 * keymap.c (access_keymap, silly_event_symbol_error):
4516 XUINT -> XFASTINT, since the integer must be nonnegative.
4517 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4518 since it makes no difference and we prefer signed.
4519 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4520 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4523 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4525 * window.h (Fwindow_frame): Declare.
4527 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4529 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4530 (SPARE_MEMORY): Always define.
4531 (LARGE_REQUEST): Remove.
4532 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4534 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4536 * lisp.h: Move EXFUNS for Fframe_root_window,
4537 Fframe_first_window and Fset_frame_selected_window to window.h.
4539 * window.h: Move EXFUNS for Fframe_root_window,
4540 Fframe_first_window and Fset_frame_selected_window here from
4543 * frame.c (Fwindow_frame, Fframe_first_window)
4544 (Fframe_root_window, Fframe_selected_window)
4545 (Fset_frame_selected_window): Move to window.c.
4546 (Factive_minibuffer_window): Move to minibuf.c.
4547 (Fother_visible_frames_p): New function.
4549 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4551 * window.c (decode_window, decode_any_window): Move up in code.
4552 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4553 (inhibit_frame_unsplittable): Remove unused variable.
4554 (Fwindow_buffer): Move up and rewrite doc-string.
4555 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4556 (Fwindow_prev): New functions.
4557 (Fwindow_frame): Move here from frame.c. Accept any window as
4559 (Fframe_root_window, Fframe_first_window)
4560 (Fframe_selected_window): Move here from frame.c. Accept frame
4561 or arbitrary window as argument. Update doc-strings.
4562 (Fminibuffer_window): Move up in code.
4563 (Fwindow_minibuffer_p): Move up in code and simplify.
4564 (Fset_frame_selected_window): Move here from frame.c.
4566 (Fselected_window, select_window, Fselect_window): Move up in
4567 code. Minor doc-string fixes.
4569 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4571 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4572 Do not assume that spare memory exists; that assumption is valid
4573 only if SYSTEM_MALLOC.
4574 (LARGE_REQUEST): New macro, so that the issue of large requests
4575 is separated from the issue of spare memory.
4577 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4579 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4582 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4584 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4587 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4589 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4591 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4593 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4594 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4596 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4598 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4600 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4602 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4603 (x_clipboard_manager_save): Add return value.
4604 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4606 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4607 Obey Vx_select_enable_clipboard_manager. Catch errors in
4608 x_clipboard_manager_save (Bug#8779).
4609 (Vx_select_enable_clipboard_manager): New variable.
4610 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4612 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4614 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4616 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4618 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4619 in the current matrix if keep_current_p is non-zero.
4621 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4623 * bidi.c (bidi_level_of_next_char): Fix last change.
4625 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4627 Support bidi reordering of text covered by display properties.
4629 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4630 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4631 (bidi_cache_search, bidi_cache_iterator_state)
4632 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4633 (bidi_level_of_next_char, bidi_move_to_visually_next):
4634 Support character positions inside a run of characters covered by a
4636 (bidi_paragraph_init, bidi_resolve_explicit_1)
4637 (bidi_level_of_next_char): Call bidi_fetch_char and
4638 bidi_fetch_char_advance instead of FETCH_CHAR and
4640 (bidi_init_it): Initialize new members.
4641 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4643 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4644 instead of using explicit *_CHAR codes.
4645 (bidi_resolve_explicit, bidi_resolve_weak):
4646 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4647 bidirectional text is supported only in multibyte buffers.
4648 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4649 it to initialize the frame_window_p member of struct bidi_it.
4650 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4651 (bidi_resolve_explicit, bidi_resolve_weak)
4652 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4653 bidi_it->nchars is non-positive.
4654 (bidi_level_of_next_char): Don't try to lookup the cache for the
4655 next/previous character if nothing is cached there yet, or if we
4656 were just reseat()'ed to a new position.
4658 * xdisp.c (set_cursor_from_row): Set start and stop points
4659 according to the row's direction when priming the loop that looks
4660 for the glyph on which to display cursor.
4661 (single_display_spec_intangible_p): Function deleted.
4662 (display_prop_intangible_p): Reimplement to call
4663 handle_display_spec instead of single_display_spec_intangible_p.
4664 Accept 3 additional arguments needed by handle_display_spec.
4665 This fixes incorrect cursor motion across display property with complex
4666 values: lists, `(when COND...)' forms, etc.
4667 (single_display_spec_string_p): Support property values that are
4668 lists with the argument STRING its top-level element.
4669 (display_prop_string_p): Fix the condition for processing a
4670 property that is a list to be consistent with handle_display_spec.
4671 (handle_display_spec): New function, refactored from the
4672 last portion of handle_display_prop.
4673 (compute_display_string_pos): Accept additional argument
4674 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4675 value of a `display' property is a "replacing spec".
4676 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4677 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4678 the display property, but just return a value indicating whether
4679 the display property will replace the characters it covers.
4680 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4681 frame_window_p members of struct bidi_it.
4682 (compute_display_string_pos, compute_display_string_end):
4684 (push_it): Accept second argument POSITION, where pop_it should
4685 jump to continue iteration.
4686 (reseat_1): Initialize bidi_it.disp_pos.
4688 * keyboard.c (adjust_point_for_property): Adjust the call to
4689 display_prop_intangible_p to its new signature.
4691 * dispextern.h (struct bidi_it): New member frame_window_p.
4692 (bidi_init_it): Update prototypes.
4693 (display_prop_intangible_p): Update prototype.
4694 (compute_display_string_pos, compute_display_string_end):
4696 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4699 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4701 Malloc failure behavior now depends on size of allocation.
4702 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4703 * lisp.h: Change signatures accordingly.
4704 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4705 All callers changed. (Bug#8762)
4707 * gnutls.c: Use Emacs's memory allocators.
4708 Without this change, the gnutls library would invoke malloc etc.
4709 directly, which causes problems on non-SYNC_INPUT hosts, and which
4710 runs afoul of improving memory_full behavior. (Bug#8761)
4711 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4712 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4713 xfree instead of the default malloc, realloc, free.
4714 (Fgnutls_boot): No need to check for memory allocation failure,
4715 since xmalloc does that for us.
4717 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4718 * category.c (hash_get_category_set):
4719 * ccl.c (ccl_driver):
4720 * charset.c (Fdefine_charset_internal):
4721 * charset.h (struct charset.hash_index):
4722 * composite.c (get_composition_id, gstring_lookup_cache)
4723 (composition_gstring_put_cache):
4724 * composite.h (struct composition.hash_index):
4725 * dispextern.h (struct image.hash):
4726 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4727 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4728 (hashfn_equal, hashfn_user_defined, make_hash_table)
4729 (maybe_resize_hash_table, hash_lookup, hash_put)
4730 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4731 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4732 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4733 * image.c (make_image, search_image_cache, lookup_image)
4734 (xpm_put_color_table_h):
4735 * lisp.h (struct Lisp_Hash_Table):
4736 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4737 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4738 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4739 * alloc.c (allocate_vectorlike):
4740 Check for overflow in vector size calculations.
4741 * ccl.c (ccl_driver):
4742 Check for overflow when converting EMACS_INT to int.
4743 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4744 need to be updated by these changes.
4745 * fns.c (make_hash_table, maybe_resize_hash_table):
4746 Check for integer overflow with large hash tables.
4747 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4748 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4749 (SXHASH_REDUCE): New macro.
4750 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4751 Use it instead of discarding useful hash info with large hash values.
4752 (sxhash_float): New function.
4753 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4754 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4755 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4756 Rewrite to use FIXNUM_BITS, as this simplifies things.
4757 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4758 Adjust signatures to match updated version of code.
4759 (consing_since_gc): Now EMACS_INT, since a single hash table can
4760 use more than INT_MAX bytes.
4762 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4764 Make it possible to build with GCC-4.6+ -O2 -flto.
4766 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4768 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4770 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4771 Call minibuffer-inactive-mode.
4773 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4775 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4776 Update dependencies.
4778 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4780 * data.c (init_data): Remove code for UTS, this system is not
4783 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4785 Don't force ./temacs to start in terminal mode.
4787 * frame.c (make_initial_frame): Initialize faces in all cases, not
4788 only when CANNOT_DUMP is defined.
4789 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4791 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4793 * dispnew.c (add_window_display_history): Use const for the string
4794 pointer. Remove declaration, not needed.
4796 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4798 Use 'inline', not 'INLINE'.
4799 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4800 * alloc.c, fontset.c (INLINE): Remove.
4801 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4802 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4803 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4804 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4805 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4807 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4809 Make it possible to run ./temacs.
4811 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4812 syms_of_callproc does the same thing. Remove test for
4813 "initialized", do it in the caller.
4814 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4816 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4818 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4819 (read_minibuf): Use get_minibuffer.
4820 (syms_of_minibuf): Use DEFSYM.
4821 (Qmetadata): New var.
4822 * data.c (Qbuffer): Don't make it static.
4823 (syms_of_data): Use DEFSYM.
4825 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4827 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4828 (CCL_CODE_MIN): New macro.
4830 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4832 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4834 * eval.c (Qdebug): Now static.
4835 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4836 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4837 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4839 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4841 * image.c: Various fixes to ImageMagick code comments.
4842 (Fimagemagick_types): Doc fix.
4844 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4846 Minor fixes prompted by GCC 4.6.0 warnings.
4848 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4850 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4851 (x_clipboard_manager_save_all): Move extern decl to ...
4852 * xterm.h: ... here, so that it can be checked for consistency.
4854 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4856 * xselect.c (x_clipboard_manager_save_frame)
4857 (x_clipboard_manager_save_all): New functions.
4858 (Fx_clipboard_manager_save): Lisp function deleted.
4860 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4861 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4863 * xterm.h: Update prototype.
4865 2011-05-28 William Xu <william.xwl@gmail.com>
4867 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4870 2011-05-28 Jim Meyering <meyering@redhat.com>
4872 Avoid a sign-extension bug in crypto_hash_function.
4873 * fns.c (to_uchar): Define.
4874 (crypto_hash_function): Use it to convert some newly-signed
4875 variables to unsigned, to avoid sign-extension bugs. For example,
4876 without this change, (md5 "truc") would evaluate to
4877 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4878 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4879 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4881 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4883 Integer overflow fixes.
4885 * dbusbind.c: Serial number integer overflow fixes.
4886 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4887 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4888 to hold a serial number that is too large for a fixnum.
4889 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4890 Check for serial numbers out of range. Decode any serial number
4891 that was so large that it became a float. (Bug#8722)
4893 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4894 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4895 Use XFASTINT rather than XUINT when numbers are nonnegative.
4896 (xd_append_arg, Fdbus_method_return_internal):
4897 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4898 arguments, check that Lisp number is nonnegative, rather than
4899 silently wrapping negative numbers around. (Bug#8722)
4900 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4903 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4905 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4907 ccl: add integer overflow checks
4908 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4909 (IN_INT_RANGE): New macros.
4910 (ccl_driver): Use them to check for integer overflow when
4911 decoding a CCL program. Many of the new checks are whether XINT (x)
4912 fits in int; it doesn't always, on 64-bit hosts. The new version
4913 doesn't catch all possible integer overflows, but it's an
4914 improvement. (Bug#8719)
4916 * alloc.c (make_event_array): Use XINT, not XUINT.
4917 There's no need for unsigned here.
4919 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4920 This follows up to the 2011-05-06 change that substituted uintptr_t
4921 for EMACS_INT. This case wasn't caught back then.
4923 Rework Fformat to avoid integer overflow issues.
4924 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4925 now (part of C89). Include <verify.h>.
4926 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4927 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4928 (Fformat): Avoid the prepass trying to compute sizes; it was only
4929 approximate and thus did not catch overflow reliably. Instead, walk
4930 through the format just once, formatting and computing sizes as we go,
4931 checking for integer overflow at every step, and allocating a larger
4932 buffer as needed. Keep track separately whether the format is
4933 multibyte. Keep only the most-recently calculated precision, rather
4934 than them all. Record whether each argument has been converted to
4935 string. Use EMACS_INT, not int, for byte and char and arg counts.
4936 Support field widths and precisions larger than INT_MAX. Avoid
4937 sprintf's undefined behavior with conversion specifications such as %#d
4938 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4939 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4940 formatting out-of-range floating point numbers with int
4943 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4945 * data.c: Avoid integer truncation in expressions involving floats.
4946 * data.c: Include <intprops.h>.
4947 (arith_driver): When there's an integer overflow in an expression
4948 involving floating point, convert the integers to floating point
4949 so that the resulting value does not suffer from catastrophic
4950 integer truncation. For example, on a 64-bit host (* 4
4951 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4952 Do not rely on undefined behavior after integer overflow.
4954 merge count_size_as_multibyte, parse_str_to_multibyte
4955 * character.c, character.h (count_size_as_multibyte):
4956 Rename from parse_str_to_multibyte; all uses changed.
4957 Check for integer overflow.
4958 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4959 since it's now a duplicate of the other. This is more of
4960 a character than a buffer op, so better that it's in character.c.
4961 * fns.c, print.c: Adjust to above changes.
4963 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4965 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4967 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4969 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4970 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4971 (x_clipboard_manager_save): Now static.
4972 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4974 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4975 (crypto_hash_function): Now static.
4976 Fix pointer signedness problems. Avoid unnecessary initializations.
4978 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4980 * termhooks.h (Vselection_alist): Make it terminal-local.
4982 * terminal.c (create_terminal): Initialize it.
4984 * xselect.c: Support for clipboard managers.
4985 (Vselection_alist): Move to termhooks.h as terminal-local var.
4986 (LOCAL_SELECTION): New macro.
4987 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4988 (symbol_to_x_atom): Remove gratuitous arg.
4989 (x_handle_selection_request, lisp_data_to_selection_data)
4990 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4991 (x_own_selection, x_get_local_selection, x_convert_selection):
4992 New arg, specifying work frame. Use terminal-local Vselection_alist.
4993 (some_frame_on_display): Delete unused function.
4994 (Fx_own_selection_internal, Fx_get_selection_internal)
4995 (Fx_disown_selection_internal, Fx_selection_owner_p)
4996 (Fx_selection_exists_p): New optional frame arg.
4997 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4998 (x_handle_selection_clear): Don't treat other terminals with the
4999 same keyboard specially. Use the terminal-local Vselection_alist.
5000 (x_clear_frame_selections): Use Frun_hook_with_args.
5002 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5004 * xterm.h: Add support for those atoms.
5006 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5008 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5009 (converted_selections, conversion_fail_tag): New global variables.
5010 (x_selection_request_lisp_error): Free the above.
5011 (x_get_local_selection): Remove unnecessary code.
5012 (x_reply_selection_request): Args changed; handle arbitrary array
5013 of converted selections stored in converted_selections.
5014 Separate the XChangeProperty and SelectionNotify steps.
5015 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5016 (x_convert_selection): New function.
5017 (x_handle_selection_event): Simplify.
5018 (x_get_foreign_selection): Don't ignore incoming requests while
5019 waiting for an answer; this will fail when we implement
5020 SAVE_TARGETS, and seems unnecessary anyway.
5021 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5022 (Vx_sent_selection_functions): Doc fix.
5024 2011-05-26 Leo Liu <sdl.web@gmail.com>
5026 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5028 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5030 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5032 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5033 for fringe update if it has periodic bitmap.
5034 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5035 and fringe_bitmap_periodic_p.
5037 * fringe.c (get_fringe_bitmap_data): New function.
5038 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5039 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5040 row. Mark glyph row for fringe update if periodicity changed.
5042 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5043 for fringe update unless it has periodic bitmap.
5045 2011-05-25 Kenichi Handa <handa@m17n.org>
5047 * xdisp.c (get_next_display_element): Set correct it->face_id for
5048 a static composition.
5050 2011-05-24 Leo Liu <sdl.web@gmail.com>
5053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5055 * fns.c (crypto_hash_function, Fsha1): New function.
5056 (Fmd5): Use crypto_hash_function.
5057 (syms_of_fns): Add Ssha1.
5059 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5061 * gnutls.c: Remove unused macros.
5062 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5063 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5064 Remove macros that are defined and never used.
5065 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5067 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5069 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5070 (Fx_get_selection_internal): Minor cleanup.
5071 (Fx_own_selection_internal): Rename arguments for consistency with
5074 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5076 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5078 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5080 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5082 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5084 * dispnew.c (scrolling_window): Don't exclude the case that the
5085 last enabled row in the desired matrix touches the bottom boundary.
5087 2011-05-21 Glenn Morris <rgm@gnu.org>
5089 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5090 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5091 and add some more files.
5093 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5095 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5096 report_file_error introduced by the change from 2011-05-07.
5098 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5100 * systime.h (Time): Define only if emacs is defined.
5101 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5102 where the include path doesn't have X11/X.h by default. See
5103 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5105 2011-05-20 Kenichi Handa <handa@m17n.org>
5107 * composite.c (find_automatic_composition): Fix previous change.
5109 2011-05-20 Glenn Morris <rgm@gnu.org>
5111 * lisp.mk: New file, split from Makefile.in.
5112 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5113 (shortlisp): Remove.
5114 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5116 2011-05-19 Glenn Morris <rgm@gnu.org>
5118 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5119 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5120 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5121 (lisp): Set the order to that of loadup.el.
5122 (shortlisp): Make it a copy of $lisp.
5123 (SOME_MACHINE_LISP): Remove.
5124 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5125 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5127 2011-05-18 Kenichi Handa <handa@m17n.org>
5129 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5130 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5131 (find_automatic_composition): Mostly rewrite for efficiency.
5133 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5135 * makefile.w32-in: Update dependencies.
5137 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5139 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5140 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5142 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5144 Fix some integer overflow issues, such as string length overflow.
5146 * insdel.c (count_size_as_multibyte): Check for string overflow.
5148 * character.c (lisp_string_width): Check for string overflow.
5149 Use EMACS_INT, not int, for string indexes and lengths; in
5150 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5151 the resulting string length overflows an EMACS_INT; instead,
5152 report a string overflow if no precision given. When checking for
5153 precision exhaustion, use a check that cannot possibly have
5154 integer overflow. (Bug#8675)
5155 * character.h (lisp_string_width): Adjust to new signature.
5157 * alloc.c (string_overflow): New function.
5158 (Fmake_string): Use it. This doesn't change behavior, but saves
5159 a few bytes and will simplify future changes.
5160 * character.c (string_escape_byte8): Likewise.
5161 * lisp.h (string_overflow): New decl.
5163 Fixups, following up to the user-interface timestamp change.
5164 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5165 for UI timestamps, instead of unsigned long.
5166 * msdos.c (mouse_get_pos): Likewise.
5167 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5168 * w32gui.h (Time): Define by including "systime.h" rather than by
5169 declaring it ourselves. (Bug#8664)
5171 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5172 * image.c (clear_image_cache): Likewise.
5174 * term.c (term_mouse_position): Don't assume time_t wraparound.
5176 Be more systematic about user-interface timestamps.
5177 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5178 and sometimes 'EMACS_UINT', to represent these timestamps.
5179 This change causes it to use 'Time' uniformly, as that's what X uses.
5180 This makes the code easier to follow, and makes it easier to catch
5181 integer overflow bugs such as Bug#8664.
5182 * frame.c (Fmouse_position, Fmouse_pixel_position):
5183 Use Time, not unsigned long, for user-interface timestamps.
5184 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5185 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5186 * keyboard.h (last_event_timestamp): Likewise.
5187 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5188 * menu.h (xmenu_show): Likewise.
5189 * term.c (term_mouse_position): Likewise.
5190 * termhooks.h (struct input_event.timestamp): Likewise.
5191 (struct terminal.mouse_position_hook): Likewise.
5192 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5193 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5194 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5195 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5197 * menu.h, termhooks.h: Include "systime.h", for Time.
5199 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5200 Don't assume that the difference between two unsigned long values
5201 can fit into an integer. At this point, we know button_down_time
5202 <= event->timestamp, so the difference must be nonnegative, so
5203 there's no need to cast the result if double-click-time is
5204 nonnegative, as it should be; check that it's nonnegative, just in
5205 case. This bug is triggered when events are more than 2**31 ms
5206 apart (about 25 days). (Bug#8664)
5208 * xselect.c (last_event_timestamp): Remove duplicate decl.
5209 (x_own_selection): Remove needless cast to unsigned long.
5211 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5212 that always fit in int. Use a sentinel instead of a counter, to
5213 avoid a temp and to allay GCC's concerns about possible int overflow.
5214 * frame.h (struct frame): Use int for menu_bar_items_used
5215 instead of EMACS_INT, since it always fits in int.
5217 * menu.c (grow_menu_items): Check for int overflow.
5219 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5221 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5222 Before, the code was not consistent. These values cannot exceed
5223 2**31 - 1 so there's no need to make them unsigned.
5224 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5225 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5226 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5228 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5230 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5231 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5232 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5233 presumably because the widths might not match.
5235 * window.c (size_window): Avoid needless test at loop start.
5237 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5239 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5241 2011-05-12 Drew Adams <drew.adams@oracle.com>
5243 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5245 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5247 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5248 `width' to `bar_area_x' and `bar_area_width', respectively.
5249 (x_scroll_run): Take account of fringe background extension.
5251 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5252 Rename local vars `left' and `width' to `bar_area_x' and
5253 `bar_area_width', respectively.
5254 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5255 background extension.
5257 2011-05-10 Jim Meyering <meyering@redhat.com>
5259 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5261 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5263 * image.c (Finit_image_library): Return t for built-in image types,
5264 like pbm and xbm. (Bug#8640)
5266 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5268 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5270 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5272 * w32console.c (Fset_screen_color): Doc fix.
5273 (Fget_screen_color): New function.
5274 (syms_of_ntterm): Defsubr it.
5276 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5277 unlink the temporary file if Fcall_process didn't create it in the
5279 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5280 child process will be redirected to a file specified with `:file'.
5281 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5282 cue to call_process_cleanup not to close that handle.
5284 2011-05-07 Ben Key <bkey76@gmail.com>
5286 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5287 one of two shell specific rules, either bootstrap-temacs-CMD or
5288 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5289 to the previous implementation of the bootstrap-temacs rule.
5290 The bootstrap-temacs-CMD rule is similar to the previous
5291 implementation of the bootstrap-temacs rule except that it
5292 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5295 These changes, along with some changes to nt/configure.bat,
5296 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5297 earlier fix to add support for --cflags and --ldflags options
5298 that include quotes so that it works whether make uses cmd or
5301 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5303 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5304 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5306 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5307 a string. Handle both cases.
5308 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5309 (Fdbus_register_method): Use Qinvalid_function.
5311 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5313 * makefile.w32-in: Update dependencies.
5314 (LISP_H): Add inttypes.h and stdin.h.
5315 (PROCESS_H): Add unistd.h.
5317 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5319 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5320 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5322 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5324 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5326 * term.c (vfatal): Remove stray call to va_end.
5327 It's not needed and the C Standard doesn't allow it here anyway.
5329 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5330 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5332 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5335 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5337 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5339 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5341 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5343 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5345 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5346 * charset.c (Fdefine_charset_internal): Don't initialize
5347 charset.code_space[15]. The value was garbage, on hosts with
5348 32-bit int (Bug#8600).
5350 * lread.c (read_integer): Be more consistent with string-to-number.
5351 Use string_to_number to do the actual conversion; this avoids
5352 rounding errors and fixes some other screwups. Without this fix,
5353 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5354 (digit_to_number): Move earlier, for benefit of read_integer.
5355 Return -1 if the digit is out of range for the base, -2 if it is
5356 not a digit in any supported base. (Bug#8602)
5358 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5360 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5361 to match comment at start of function. This also removes a
5362 GCC warning about overflow in a 32+64-bit port.
5364 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5366 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5367 Reported by Stefan Monnier in
5368 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5369 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5370 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5372 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5373 (EMACS_UINTPTR): Likewise, with uintptr_t.
5375 * lisp.h: Prefer 64-bit EMACS_INT if available.
5376 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5377 on 32-bit hosts that have 64-bit int, so that they can access
5379 However, temporarily disable this change unless the temporary
5380 symbol WIDE_EMACS_INT is defined.
5382 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5384 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5385 This removes an assumption that EMACS_INT and long are the same
5386 width as pointers. The assumption is true for Emacs porting targets
5387 now, but we want to make other targets possible.
5388 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5389 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5390 In the rest of the code, change types of integers that hold casted
5391 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5392 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5393 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5394 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5395 No need to cast type when ORing.
5396 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5397 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5398 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5399 assume EMACS_INT is the same width as char *.
5400 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5401 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5402 Remove no-longer-needed casts.
5403 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5404 (xg_tool_bar_help_callback, xg_make_tool_item):
5405 Use EMACS_INTPTR to hold an integer
5406 that will be cast to void *; this can avoid a GCC warning
5407 if EMACS_INT is not the same width as void *.
5408 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5409 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5410 (current_message_1, set_message_1):
5411 Use a local to convert to proper width without a cast.
5412 * xmenu.c (dialog_selection_callback): Likewise.
5414 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5415 Also, don't assume VALBITS / RAND_BITS is less than 5,
5416 and don't rely on undefined behavior when shifting a 1 left into
5418 * lisp.h (get_random): Change signature to match.
5420 * lread.c (hash_string): Use size_t, not int, for hash computation.
5421 Normally we prefer signed values; but hashing is special, because
5422 it's better to use unsigned division on hash table sizes so that
5423 the remainder is nonnegative. Also, size_t is the natural width
5424 for hashing into memory. The previous code used 'int', which doesn't
5425 retain enough info to hash well into very large tables.
5426 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5428 * dbusbind.c: Don't possibly lose pointer info when converting.
5429 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5430 Use XPNTR rather than XHASH, so that the high-order bits of
5431 the pointer aren't lost when converting through void *.
5433 * eval.c (Fautoload): Don't double-shift a pointer.
5435 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5437 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5439 * gnutls.c (DEF_GNUTLS_FN):
5440 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5442 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5444 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5447 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5449 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5450 New version that can reserve upto 2GB of heap space.
5452 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5454 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5456 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5458 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5459 `gnutls_certificate_set_x509_key_file'.
5461 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5463 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5464 Update dependencies.
5466 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5468 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5469 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5470 Remove unused parameter `fildes'.
5471 * process.c (read_process_output, send_process): Don't pass it.
5473 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5475 Fix previous change: the library cache is defined in w32.c.
5476 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5477 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5479 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5481 Implement dynamic loading of GnuTLS on Windows.
5483 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5484 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5488 * gnutls.c (Qgnutls_dll): Define.
5489 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5490 (gnutls_*): Declare function pointers.
5491 (init_gnutls_functions): New function to initialize function pointers.
5492 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5493 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5494 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5495 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5496 (emacs_gnutls_write, emacs_gnutls_read)
5497 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5498 (Fgnutls_available_p): New function.
5499 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5500 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5501 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5503 * image.c: Include w32.h.
5504 (Vimage_type_cache): Delete.
5505 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5506 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5507 (w32_delayed_load): Move to w32.c.
5509 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5511 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5512 (w32_delayed_load): Move from image.c. When loading a library, record
5513 its filename in the :loaded-from property of the library id.
5514 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5515 Initialize and staticpro them.
5516 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5518 * process.c: Include lisp.h before w32.h, not after.
5519 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5520 instead of gnutls_record_check_pending.
5522 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5524 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5526 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5527 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5530 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5532 * xterm.c (x_set_frame_alpha): Do not set property on anything
5533 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5535 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5537 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5539 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5541 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5542 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5543 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5544 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5545 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5546 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5547 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5548 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5549 (Qgnutls_bootprop_callbacks_verify): Make static.
5551 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5553 * callproc.c: Indentation fixup.
5555 * sysdep.c (wait_for_termination_1): Make static.
5556 (wait_for_termination, interruptible_wait_for_termination):
5557 Move after wait_for_termination_1.
5559 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5561 * sysdep.c (interruptible_wait_for_termination): New function
5562 which is like wait_for_termination, but allows keyboard
5565 * callproc.c (Fcall_process): Add (:file "file") as an option for
5567 (Fcall_process_region): Ditto.
5569 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5571 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5572 rather than `XVECTOR (FOO)->size'.
5574 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5575 inttypes.h, as a gnulib replacement is used if it not available in
5578 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5580 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5581 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5582 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5584 * coding.c (coding_alloc_by_realloc): Error out if destination
5585 will grow beyond MOST_POSITIVE_FIXNUM.
5586 (decode_coding_emacs_mule): Abort if there isn't enough place in
5587 charbuf for the composition carryover bytes. Reserve an extra
5588 space for up to 2 characters produced in a loop.
5589 (decode_coding_iso_2022): Abort if there isn't enough place in
5590 charbuf for the composition carryover bytes.
5592 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5594 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5595 aborting when %lld or %lll format is passed.
5596 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5597 %llo or %llx format is passed. (Bug#8545)
5599 * window.c (window_scroll_line_based): Use a marker instead of
5600 simple variables to record original value of point. (Bug#7952)
5602 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5603 produced by %s or %c overflows available buffer space. (Bug#8545)
5605 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5607 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5608 (SIZE_MAX): Move defn after all includes, as they might #define it.
5610 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5612 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5614 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5616 * keyboard.c (Qdelayed_warnings_hook): Define.
5617 (command_loop_1): Run `delayed-warnings-hook'
5618 if Vdelayed_warnings_list is non-nil.
5619 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5620 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5622 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5624 * doprnt.c (doprnt): Don't return value smaller than the buffer
5625 size if the message was truncated. (Bug#8545).
5627 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5629 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5630 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5632 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5634 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5636 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5638 * makefile.w32-in: Update dependencies.
5640 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5642 Improve `doprnt' and its usage. (Bug#8545)
5643 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5644 `format_end'. Remove support for %l as a conversion specifier.
5645 Don't use xrealloc. Improve diagnostics when the %l size modifier
5646 is used. Update the commentary.
5648 * eval.c (verror): Simplify calculation of size_t.
5650 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5653 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5655 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5658 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5660 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5661 This makes this file independent of the recent pseudovector change.
5663 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5665 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5667 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5668 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5669 Remove unused local.
5670 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5672 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5673 GCC 4.6.0 optimizes based on type-based alias analysis.
5674 For example, if b is of type struct buffer * and v of type struct
5675 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5676 != &v->size, and therefore "v->size = 1; b->size = 2; return
5677 v->size;" must therefore return 1. This assumption is incorrect
5678 for Emacs, since it type-puns struct Lisp_Vector * with many other
5679 types. To fix this problem, this patch adds a new type struct
5680 vectorlike_header that documents the constraints on layout of vectors
5681 and pseudovectors, and helps optimizing compilers not get fooled
5682 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5683 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5684 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5686 (XSETPVECTYPE): Rewrite in terms of new macro.
5687 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5688 This is a bit clearer, and further avoids the possibility of
5689 undesirable aliasing.
5690 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5691 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5692 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5693 since Lisp_Subr is a special case (no "next" field).
5694 (ASIZE): Now uses header.size rather than size.
5695 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5696 to avoid the hassle of writing XVECTOR (foo)->header.size.
5697 (struct vectorlike_header): New type.
5698 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5699 object, to help avoid aliasing.
5700 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5701 (SUBRP): Likewise, since Lisp_Subr is a special case.
5702 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5703 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5704 (struct Lisp_Hash_Table): Combine first two members into a single
5705 struct vectorlike_header member. All uses of "size" and "next" members
5706 changed to be "header.size" and "header.next".
5707 * buffer.h (struct buffer): Likewise.
5708 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5709 * frame.h (struct frame): Likewise.
5710 * process.h (struct Lisp_Process): Likewise.
5711 * termhooks.h (struct terminal): Likewise.
5712 * window.c (struct save_window_data, struct saved_window): Likewise.
5713 * window.h (struct window): Likewise.
5714 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5715 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5716 * buffer.c (init_buffer_once): Likewise.
5717 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5719 * process.c (Fformat_network_address): Use local var for size,
5722 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5724 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5725 * data.c (atof): Remove decl; no longer used or needed.
5726 (digit_to_number): Move to lread.c.
5727 (Fstring_to_number): Use new string_to_number function, to be
5728 consistent with how the Lisp reader treats infinities and NaNs.
5729 Do not assume that floating-point numbers represent EMACS_INT
5730 without losing information; this is not true on most 64-bit hosts.
5731 Avoid double-rounding errors, by insisting on integers when
5732 parsing non-base-10 numbers, as the documentation specifies.
5733 * lisp.h (string_to_number): New decl, replacing ...
5734 (isfloat_string): Remove.
5735 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5736 (read1): Do not accept +. and -. as integers; this
5737 appears to have been a coding error. Similarly, do not accept
5738 strings like +-1e0 as floating point numbers. Do not report
5739 overflow for integer overflows unless the base is not 10 which
5740 means we have no simple and reliable way to continue.
5741 Break out the floating-point parsing into a new
5742 function string_to_number, so that Fstring_to_number parses
5743 floating point numbers consistently with the Lisp reader.
5744 (digit_to_number): Move here from data.c. Make it static inline.
5745 (E_CHAR, EXP_INT): Remove, replacing with ...
5746 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5747 (string_to_number): New function, replacing isfloat_string.
5748 This function checks for valid syntax and produces the resulting
5749 Lisp float number too. Rework it so that string-to-number
5750 no longer mishandles examples like "1.0e+". Use strtoumax,
5751 so that overflow for non-base-10 numbers is reported only when
5752 there's no portable and simple way to convert to floating point.
5754 * textprop.c (set_text_properties_1): Rewrite for clarity,
5755 and to avoid GCC warning about integer overflow.
5757 * intervals.h (struct interval): Use EMACS_INT for members
5758 where EMACS_UINT might cause problems. See
5759 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5760 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5761 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5763 (offset_intervals): Tell GCC not to worry about length overflow
5764 when negating a negative length.
5766 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5767 (overrun_check_free): Likewise.
5769 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5770 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5773 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5774 (gnutls_make_error): Rename local to avoid shadowing.
5775 (gnutls_emacs_global_deinit): ifdef out; not used.
5776 (Fgnutls_boot): Use const for pointer to readonly storage.
5777 Comment out unused local. Fix pointer signedness problems.
5779 * lread.c (openp): Don't stuff size_t into an 'int'.
5780 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5781 about possible signed overflow.
5783 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5784 (GDK_KEY_g): Don't define if already defined.
5785 (xg_prepare_tooltip): Avoid pointer signedness problem.
5786 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5788 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5789 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5791 * xfns.c (Fx_window_property): Simplify a bit,
5792 to make a bit faster and to avoid GCC 4.6.0 warning.
5793 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5795 * fns.c (internal_equal): Don't assume size_t fits in int.
5797 * alloc.c (compact_small_strings): Tighten assertion a little.
5799 Replace pEd with more-general pI, and fix some printf arg casts.
5800 * lisp.h (pI): New macro, generalizing old pEd macro to other
5801 conversion specifiers. For example, use "...%"pI"d..." rather
5802 than "...%"pEd"...".
5803 (pEd): Remove. All uses replaced with similar uses of pI.
5804 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5805 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5806 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5807 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5808 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5809 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5810 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5812 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5813 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5814 * print.c (safe_debug_print, print_object): Likewise.
5815 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5817 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5818 avoiding the 0 flag, which is not portable.
5819 * process.c (Fmake_network_process): Use pI to avoid cast.
5820 * region-cache.c (pp_cache): Likewise.
5821 * xdisp.c (decode_mode_spec): Likewise.
5822 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5823 behavior on 64-bit hosts with printf arg.
5824 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5825 (x_stop_queuing_selection_requests): Likewise.
5826 (x_get_window_property): Don't truncate byte count to an 'int'
5829 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5830 here, since it parses constructs like leading '-' and spaces,
5831 which are not wanted; and it overflows with large numbers.
5832 Instead, simply match F[0-9]+, which is what is wanted anyway.
5834 * alloc.c: Remove unportable assumptions about struct layout.
5835 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5836 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5837 (allocate_vectorlike, make_pure_vector): Use the new macros,
5838 plus offsetof, to remove unportable assumptions about struct layout.
5839 These assumptions hold on all porting targets that I know of, but
5840 they are not guaranteed, they're easy to remove, and removing them
5841 makes further changes easier.
5843 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5844 This doesn't fix a bug but makes the code clearer.
5845 (string_overrun_cookie): Now const. Use initializers that
5846 don't formally overflow signed char, to avoid warnings.
5847 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5848 can cause Emacs to crash when string overrun checking is enabled.
5849 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5850 multiple of sizeof (EMACS_INT); it need not be, if
5851 alignof(EMACS_INT) < sizeof (EMACS_INT).
5852 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5854 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5856 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5858 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5860 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5861 supposed to be handshaking. (Bug#8556)
5862 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5864 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5866 * lisp.h (Qdebug): List symbol.
5867 * eval.c (Qdebug): Restore global linkage.
5868 * keyboard.c (debug-on-event): New variable.
5869 (handle_user_signal): Break into debugger when debug-on-event
5870 matches the current signal symbol.
5872 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5874 * alloc.c (check_sblock, check_string_bytes)
5875 (check_string_free_list): Convert to standard C.
5877 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5879 * w32.c (emacs_gnutls_push): Fix typo.
5881 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5883 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5884 "cast to pointer from integer of different size".
5886 Improve doprnt and its use in verror. (Bug#8545)
5887 * doprnt.c (doprnt): Document the set of format control sequences
5888 supported by the function. Use SAFE_ALLOCA instead of always
5891 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5892 is one byte too soon. Don't use xrealloc; instead xfree and
5895 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5897 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5900 * gnutls.c: Renamed global_initialized to
5901 gnutls_global_initialized. Added internals for the
5902 :verify-hostname-error, :verify-error, and :verify-flags
5903 parameters of `gnutls-boot' and documented those parameters in the
5904 docstring. Start callback support.
5905 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5906 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5907 on error. Return error code.
5908 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5909 (emacs_gnutls_read): Likewise.
5910 (Fgnutls_boot): Return handshake error code.
5911 (emacs_gnutls_handle_error): New function.
5912 (wsaerror_to_errno): Likewise.
5914 * w32.h (emacs_gnutls_pull): Add prototype.
5915 (emacs_gnutls_push): Likewise.
5917 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5918 (emacs_gnutls_push): Likewise.
5920 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5922 * process.c (wait_reading_process_output): Check if GnuTLS
5923 buffered some data internally if no FDs are set for TLS
5926 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5927 (LIBS): Link to USER_LIBS.
5928 ($(BLD)/gnutls.$(0)): New target.
5930 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5932 * xdisp.c (handle_single_display_spec): Rename the
5933 display_replaced_before_p argument into display_replaced_p, to
5934 make it consistent with the commentary. Fix typos in the
5937 * textprop.c (syms_of_textprop): Remove dead code.
5938 (copy_text_properties): Delete obsolete commentary about an
5939 interface that was deleted long ago. Fix typos in the description
5942 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5943 to changes in oldXMenu/XMenu.h from 2011-04-16.
5944 <menu_help_message, prev_menu_help_message>: Constify.
5945 (IT_menu_make_room): menu->help_text is now `const char **';
5948 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5949 to changes in oldXMenu/XMenu.h from 2011-04-16.
5950 (struct XMenu): Declare `help_text' `const char **'.
5952 * xfaces.c <Qunspecified>: Make extern again.
5954 * syntax.c: Include sys/types.h before including regex.h, as
5957 * doc.c (get_doc_string): Improve the format passed to `error'.
5959 * doprnt.c (doprnt): Improve commentary.
5961 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5963 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5966 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5967 changes in globals.h immediately force recompilation.
5968 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5969 $(CURDIR)/s/ms-w32.h.
5970 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5972 * character.c (Fchar_direction): Function deleted.
5973 (syms_of_character): Don't defsubr it.
5974 <char-direction-table>: Deleted.
5976 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5978 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5979 * doprnt.c: Include limits.h.
5980 (SIZE_MAX): New macro.
5981 (doprnt): Return a size_t value. 2nd arg is now size_t.
5982 Many local variables are now size_t instead of int or unsigned.
5983 Improve overflow protection. Support `l' modifier for integer
5984 conversions. Support %l conversion. Don't assume an EMACS_INT
5985 argument for integer conversions and for %c.
5987 * lisp.h (doprnt): Restore prototype.
5989 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5992 * Makefile.in (base_obj): Add back doprnt.o.
5994 * deps.mk (doprnt.o): Add back prerequisites.
5995 (callint.o): Depend on character.h.
5997 * eval.c (internal_lisp_condition_case): Include the handler
5998 representation in the error message.
5999 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6000 when breaking from the loop.
6002 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6004 * callint.c (Fcall_interactively): When displaying error message
6005 about invalid control letter, pass the character's codepoint, not
6006 a pointer to its multibyte form. Improve display of the character
6007 in octal and display also its hex code.
6009 * character.c (char_string): Use %x to display the (unsigned)
6010 codepoint of an invalid character, to avoid displaying a bogus
6013 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6014 `error', not SYMBOL_NAME itself.
6016 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6017 character arguments to `error'.
6019 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6020 to `error' in error message about FINAL_CHAR argument. Make sure
6021 FINAL_CHAR is a character, and use %c when it is passed as
6022 argument to `error'.
6024 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6026 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6028 * w32.c: Include <time.h>.
6029 (sys_localtime): New function.
6031 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6033 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6035 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6037 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6039 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6042 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6044 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6045 gl_state.e_property when gl_state.object is Qt.
6047 * insdel.c (make_gap_larger): Remove limitation of buffer size
6050 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6052 * xdisp.c (lookup_glyphless_char_display)
6053 (produce_glyphless_glyph): Handle cons cell entry in
6054 glyphless-char-display.
6055 (Vglyphless_char_display): Document it.
6057 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6058 glyphless-char-display.
6060 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6062 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6064 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6066 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6067 definition for no-X builds.
6069 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6071 Static checks with GCC 4.6.0 and non-default toolkits.
6073 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6075 * process.c (keyboard_bit_set): Define only if SIGIO.
6076 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6077 (send_process): Repair possible setjmp clobbering.
6079 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6081 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6083 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6085 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6086 Define only if needed.
6088 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6089 by pacifying GCC about it. Maybe it's time to retire it?
6090 * xfaces.c (USG, __TIMEVAL__): Likewise.
6092 * dispextern.h (struct redisplay_interface): Rename param
6094 * termhooks.h (struct terminal): Likewise.
6095 * xterm.c (xembed_send_message): Likewise.
6097 * insdel.c (make_gap_smaller): Define only if
6098 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6100 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6103 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6104 so that we aren't warned about unused symbols.
6106 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6108 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6110 * xfns.c (x_real_positions): Mark locals as initialized.
6112 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6114 * xterm.c: Fix problems found by static analysis with other toolkits.
6115 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6116 (x_dispatch_event): Declare static if USE_GTK, and
6117 define if USE_GTK || USE_X_TOOLKIT.
6118 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6119 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6120 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6121 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6123 * xmenu.c (menu_help_callback): Pointer type fixes.
6124 Use const pointers when pointing at readonly data. Avoid pointer
6126 (FALSE): Remove unused macro.
6127 (update_frame_menubar): Remove unused decl.
6129 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6131 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6132 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6133 (single_menu_item): Rename local to avoid shadowing.
6135 * keyboard.c (make_lispy_event): Remove unused local var.
6137 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6138 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6140 * bitmaps: Change bitmaps from unsigned char back to the X11
6141 compatible char. Avoid the old compiler warnings about
6142 out-of-range initializers by using, for example, '\xab' rather
6145 * xgselect.c (xgselect_initialize): Check vs interface
6146 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6148 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6150 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6151 to read-only memory.
6153 * fns.c (vector): Remove; this old hack is no longer needed.
6155 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6157 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6159 * xrdb.c (x_load_resources): Omit unused local.
6161 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6162 (x_window): Rename locals to avoid shadowing.
6163 (USG): Use the kludged USG macro, to pacify gcc.
6165 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6166 (x_term_init): Remove local to avoid shadowing.
6168 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6170 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6171 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6173 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6175 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6177 Fix regex.c, syntax.c and friends for buffers > 2GB.
6178 * syntax.h (struct gl_state_s): Declare character position members
6181 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6183 * textprop.c (verify_interval_modification, interval_of):
6184 Declare arguments EMACS_INT.
6186 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6189 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6191 * indent.c (Fvertical_motion): Local variable it_start is now
6194 * regex.c (re_match, re_match_2, re_match_2_internal)
6195 (bcmp_translate, regcomp, regexec, print_double_string)
6196 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6197 (re_compile_pattern, re_exec): Declare arguments and local
6198 variables `size_t' and `ssize_t' and return values `regoff_t', as
6200 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6201 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6202 <compile_stack_type>: `size' and `avail' are now `size_t'.
6204 * regex.h <regoff_t>: Use ssize_t, not int.
6205 (re_search, re_search_2, re_match, re_match_2): Arguments that
6206 specify buffer/string position and length are now ssize_t and
6207 size_t. Return type is regoff_t.
6209 2011-04-16 Ben Key <bkey76@gmail.com>
6211 * nsfont.m: Fixed bugs in ns_get_family and
6212 ns_descriptor_to_entity that were caused by using free to
6213 deallocate memory blocks that were allocated by xmalloc (via
6214 xstrdup). This caused Emacs to crash when compiled with
6215 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6216 --enable-checking=xmallocoverrun). xfree is now used to
6217 deallocate these memory blocks.
6219 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6221 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6223 emacs_write: Accept and return EMACS_INT for sizes.
6224 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6226 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6227 Accept and return EMACS_INT.
6228 (emacs_gnutls_write): Return the number of bytes written on
6230 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6231 (emacs_read, emacs_write): Remove check for negative size, as the
6232 Emacs source code has been audited now.
6233 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6234 (emacs_read, emacs_write): Use it.
6235 * process.c (send_process): Adjust to the new signatures of
6236 emacs_write and emacs_gnutls_write. Do not attempt to store
6237 a byte offset into an 'int'; it might overflow.
6238 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6240 * sound.c: Don't assume sizes fit in 'int'.
6241 (struct sound_device.period_size, alsa_period_size):
6242 Return EMACS_INT, not int.
6243 (struct sound_device.write, vox_write, alsa_write):
6244 Accept EMACS_INT, not int.
6245 (wav_play, au_play): Use EMACS_INT to store sizes and to
6246 record read return values.
6248 2011-04-15 Ben Key <bkey76@gmail.com>
6250 * keyboard.c (Qundefined): Don't declare static since it is used
6252 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6253 static since they are used in nsfont.m.
6255 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6257 * process.c (Qprocessp): Don't declare static.
6258 * lisp.h (Qprocessp): Declare again.
6260 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6262 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6264 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6266 Improve C-level modularity by making more things 'static'.
6268 Don't publish debugger-only interfaces to other modules.
6269 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6270 (verify_bytepos, count_markers): Move decls to the only modules
6272 * region-cache.h (pp_cache): Likewise.
6273 * window.h (check_all_windows): Likewise.
6274 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6276 * sysdep.c (croak): Now static, if
6277 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6278 * syssignal.h (croak): Declare only if not static.
6280 * alloc.c (refill_memory_reserve): Now static if
6281 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6282 * lisp.h (refill_memory_reserve): Declare only if not static.
6284 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6285 Define only if USE_LUCID.
6287 * xrdb.c (x_customization_string, x_rm_string): Now static.
6289 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6290 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6292 * xdisp.c (draw_row_with_mouse_face): Now static.
6293 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6295 * window.h (check_all_windows): Mark externally visible.
6297 * window.c (window_deletion_count): Now static.
6299 * undo.c: Make symbols static if they're not exported.
6300 (last_undo_buffer, last_boundary_position, pending_boundary):
6303 * textprop.c (interval_insert_behind_hooks): Now static.
6304 (interval_insert_in_front_hooks): Likewise.
6306 * term.c: Make symbols static if they're not exported.
6307 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6308 (max_frame_lines, tty_set_terminal_modes):
6309 (tty_reset_terminal_modes, tty_turn_off_highlight):
6310 (get_tty_terminal): Now static.
6311 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6312 * termhooks.h (term_mouse_moveto): Do not declare if
6314 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6315 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6317 * sysdep.c: Make symbols static if they're not exported.
6318 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6320 (sigprocmask_set, full_mask): Remove; unused.
6321 (wait_debugging): Mark as visible.
6322 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6323 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6325 * syntax.c (syntax_temp): Define only if !__GNUC__.
6327 * sound.c (current_sound_device, current_sound): Now static.
6329 * search.c (searchbufs, searchbuf_head): Now static.
6331 * scroll.c (scroll_cost): Remove; unused.
6332 * dispextern.h (scroll_cost): Remove decl.
6334 * region-cache.h (pp_cache): Mark as externally visible.
6336 * process.c: Make symbols static if they're not exported.
6337 (process_tick, update_tick, create_process, chan_process):
6338 (Vprocess_alist, proc_buffered_char, datagram_access):
6339 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6340 (deactivate_process): Mark defn as static, as well as decl.
6341 * lisp.h (create_process): Remove decl.
6342 * process.h (chan_process, Vprocess_alist): Remove decls.
6344 * print.c: Make symbols static if they're not exported.
6345 (print_depth, new_backquote_output, being_printed, print_buffer):
6346 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6347 (print_interval, print_number_index, initial_stderr_stream):
6349 * lisp.h (Fprinc): Remove decl.
6350 (debug_output_compilation_hack): Mark as externally visible.
6352 * sysdep.c (croak): Move decl from here to syssignal.h.
6353 * syssignal.h (croak): Put it here, so the API can be checked when
6354 'croak' is called from dissociate_if_controlling_tty.
6356 * minibuf.c: Make symbols static if they're not exported.
6357 (minibuf_save_list, choose_minibuf_frame): Now static.
6358 * lisp.h (choose_minibuf_frame): Remove decl.
6360 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6362 * lread.c: Make symbols static if they're not exported.
6363 (read_objects, initial_obarray, oblookup_last_bucket_number):
6365 (make_symbol): Remove; unused.
6366 * lisp.h (initial_obarray, make_symbol): Remove decls.
6368 * keyboard.c: Make symbols static if they're not exported.
6369 (single_kboard, recent_keys_index, total_keys, recent_keys):
6370 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6371 (this_single_command_key_start, echoing, last_auto_save):
6372 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6373 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6374 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6375 (Vlispy_mouse_stem, double_click_count):
6377 (force_auto_save_soon): Define only if SIGDANGER.
6378 (ignore_mouse_drag_p): Now static if
6379 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6380 (print_help): Remove; unused.
6381 (stop_character, last_timer_event): Mark as externally visible.
6382 * keyboard.h (ignore_mouse_drag_p): Declare only if
6383 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6384 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6385 * lisp.h (echoing): Remove decl.
6386 (force_auto_save_soon): Declare only if SIGDANGER.
6387 * xdisp.c (redisplay_window): Simplify code, to make it more
6388 obvious that ignore_mouse_drag_p is not accessed if !defined
6389 USE_GTK && !defined HAVE_NS.
6391 * intervals.c: Make symbols static if they're not exported.
6392 (merge_properties_sticky, merge_interval_right, delete_interval):
6394 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6396 * insdel.c: Make symbols static if they're not exported.
6397 However, leave prepare_to_modify_buffer alone. It's never
6398 called from outside this function, but that appears to be a bug.
6399 (combine_after_change_list, combine_after_change_buffer):
6400 (adjust_after_replace, signal_before_change): Now static.
6401 (adjust_after_replace_noundo): Remove; unused.
6402 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6403 (signal_before_change): Remove decls.
6405 * indent.c (val_compute_motion, val_vmotion): Now static.
6407 * image.c: Make symbols static if they're not exported.
6408 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6410 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6411 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6413 * fringe.c (standard_bitmaps): Now static.
6414 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6416 * frame.c: Make symbols static if they're not exported.
6417 (x_report_frame_params, make_terminal_frame): Now static.
6418 (get_frame_param): Now static, unless HAVE_NS.
6419 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6420 (x_get_resource_string): Remove; not used.
6421 * frame.h (make_terminal_frame, x_report_frame_params):
6422 (x_get_resource_string); Remove decls.
6423 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6424 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6426 * font.c, fontset.c: Make symbols static if they're not exported.
6427 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6428 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6429 * font.c (font_close_object): Now static.
6430 * font.h (font_close_object): Remove.
6431 * fontset.c (FONTSET_OBJLIST): Remove.
6432 (free_realized_fontset) #if-0 the body, which does nothing.
6433 (face_suitable_for_char_p): #if-0, as it's never called.
6434 * fontset.h (face_suitable_for_char_p): Remove decl.
6435 * xfaces.c (face_at_string_position):
6436 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6437 since 0 is always ASCII.
6439 * fns.c (weak_hash_tables): Now static.
6441 * fileio.c: Make symbols static if they're not exported.
6442 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6443 (Vwrite_region_annotation_buffers): Now static.
6445 * eval.c: Make symbols static if they're not exported.
6446 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6447 * lisp.h (backtrace_list): Remove decl.
6449 * emacs.c: Make symbols static if they're not exported.
6450 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6451 (fatal_error_code, fatal_error_signal_hook, standard_args):
6453 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6454 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6455 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6456 * lisp.h (fatal_error_signal_hook): Remove decl.
6457 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6459 * editfns.c: Move a (normally-unused) function to its only use.
6460 * editfns.c, lisp.h (get_operating_system_release): Remove.
6461 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6462 worth the hassle of breaking this out.
6464 * xterm.c: Make symbols static if they're not exported.
6465 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6466 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6467 (x_destroy_window, x_delete_display):
6469 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6470 (x_mouse_leave): Remove; unused.
6471 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6472 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6473 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6475 (x_mouse_leave): Declare only if WINDOWSNT.
6476 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6477 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6480 * ftxfont.c: Make symbols static if they're not exported.
6481 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6483 * font.h (ftxfont_driver): Likewise.
6485 * xfns.c: Make symbols static if they're not exported.
6486 (x_last_font_name, x_display_info_for_name):
6487 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6488 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6489 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6490 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6491 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6492 (last_show_tip_args): Now static.
6493 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6494 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6495 (x_screen_planes): Remove; unused.
6496 * dispextern.h (x_screen_planes): Remove decl.
6498 * dispnew.c: Make symbols static if they're not exported.
6499 * dispextern.h (redraw_garbaged_frames, scrolling):
6500 (increment_row_positions): Remove.
6501 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6502 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6504 (redraw_garbaged_frames): Remove; unused.
6506 * xfaces.c: Make symbols static if they're not exported.
6507 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6509 * xterm.h (defined_color): Remove decls.
6510 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6511 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6512 (menu_face_changed_default, defined_color, free_realized_face):
6513 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6514 (ascii_face_of_lisp_face): Remove; unused.
6516 * xdisp.c: Make symbols static if they're not exported.
6517 * dispextern.h (scratch_glyph_row, window_box_edges):
6518 (glyph_to_pixel_coords, set_cursor_from_row):
6519 (get_next_display_element, set_iterator_to_next):
6520 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6521 (show_mouse_face): Remove decls
6522 * frame.h (message_buf_print): Likewise.
6523 * lisp.h (pop_message, set_message, check_point_in_composition):
6525 * xterm.h (set_vertical_scroll_bar): Likewise.
6526 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6527 (message_buf_print, scratch_glyph_row, displayed_buffer):
6528 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6529 (get_next_display_element, show_mouse_face, window_box_edges):
6530 (frame_to_window_pixel_xy, check_point_in_composition):
6531 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6532 (glyph_to_pixel_coords): Remove; unused.
6534 * dired.c (file_name_completion): Now static.
6536 * dbusbind.c (xd_in_read_queued_messages): Now static.
6538 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6539 * data.c (circular_list_error): Remove.
6541 * commands.h (last_point_position, last_point_position_buffer):
6542 (last_point_position_window): Remove decls.
6543 * keyboard.c: Make these variables static.
6545 * coding.h (coding, code_convert_region, encode_coding_gap):
6547 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6548 (iso_code_class, detect_coding, code_convert_region): Now static.
6549 (encode_coding_gap): Remove; unused.
6551 * chartab.c (chartab_chars, chartab_bits): Now static.
6553 * charset.h (charset_iso_8859_1): Remove decl.
6554 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6557 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6558 * ccl.c (Vccl_program_table): Now static.
6559 (check_ccl_update): Remove; unused.
6561 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6562 * category.h: ... from here.
6563 * category.c (check_category_table, set_category_set): Now static.
6565 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6566 * lisp.h: Remove these decls.
6568 * buffer.c (buffer_count): Remove unused var.
6570 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6571 so that it's not optimized away.
6572 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6573 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6574 exported only to the debugger.
6576 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6577 * atimer.h (run_all_atimers): Remove; not exported.
6579 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6580 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6581 was inaccessible from Lisp.
6582 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6583 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6585 alloc.c: Import and export fewer symbols, and remove unused items.
6586 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6588 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6589 it's not optimized away by whole-program optimization.
6590 (message_enable_multibyte, free_misc): Remove.
6591 (catchlist, handlerlist, mark_backtrace):
6592 Declare only if BYTE_MARK_STACK.
6593 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6594 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6595 (message_enable_multibyte): Remove decl.
6596 (free_misc, interval_free_list, float_block, float_block_index):
6597 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6598 (cons_free_list, last_marked_index):
6600 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6601 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6602 (mark_backtrace): Define only if BYTE_MARK_STACK.
6603 * xdisp.c (message_enable_multibyte): Now static.
6605 Declare Lisp_Object Q* variables to be 'static' if not exported.
6606 This makes it easier for human readers (and static analyzers)
6607 to see whether these variables are used from other modules.
6608 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6609 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6610 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6611 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6612 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6613 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6614 * xmenu.c, xselect.c:
6615 Declare Q* vars static if they are not used in other modules.
6616 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6617 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6618 Remove decls of unexported vars.
6619 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6621 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6623 Make Emacs functions such as Fatom 'static' by default.
6624 This makes it easier for human readers (and static analyzers)
6625 to see whether these functions can be called from other modules.
6626 DEFUN now defines a static function. To make the function external
6627 so that it can be used in other C modules, use the new macro DEFUE.
6628 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6629 (Finit_image_library):
6630 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6631 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6632 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6633 Remove decls, since these functions are now static.
6634 (Funintern, Fget_internal_run_time): New decls, since these functions
6635 were already external.
6637 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6638 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6639 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6640 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6641 * keyboard.c, keymap.c, lread.c:
6642 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6643 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6644 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6645 Mark functions with DEFUE instead of DEFUN,
6646 if they are used in other modules.
6647 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6648 decls for now-static functions.
6649 * buffer.h (Fdelete_overlay): Remove decl.
6650 * callproc.c (Fgetenv_internal): Mark as internal.
6651 * composite.c (Fremove_list_of_text_properties): Remove decl.
6652 (Fcomposition_get_gstring): New forward static decl.
6653 * composite.h (Fcomposite_get_gstring): Remove decl.
6654 * dired.c (Ffile_attributes): New forward static decl.
6655 * doc.c (Fdocumntation_property): New forward static decl.
6656 * eval.c (Ffetch_bytecode): New forward static decl.
6657 (Funintern): Remove extern decl; now in .h file where it belongs.
6658 * fileio.c (Fmake_symbolic_link): New forward static decl.
6659 * image.c (Finit_image_library): New forward static decl.
6660 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6661 * intervals.h (Fprevious_property_change):
6662 (Fremove_list_of_text_properties): Remove decls.
6663 * keyboard.c (Fthis_command_keys): Remove decl.
6664 (Fcommand_execute): New forward static decl.
6665 * keymap.c (Flookup_key): New forward static decl.
6666 (Fcopy_keymap): Now static.
6667 * keymap.h (Flookup_key): Remove decl.
6668 * process.c (Fget_process): New forward static decl.
6669 (Fprocess_datagram_address): Mark as internal.
6670 * syntax.c (Fsyntax_table_p): New forward static decl.
6671 (skip_chars): Remove duplicate decl.
6672 * textprop.c (Fprevious_property_change): New forward static decl.
6673 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6675 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6676 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6678 * editfns.c (Fformat): Remove unreachable code.
6680 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6682 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6685 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6687 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6688 when at ZV. (Bug#8487)
6690 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6692 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6694 * keyboard.c (parse_tool_bar_item): Likewise.
6695 * sound.c (sound_cleanup, alsa_close): Likewise.
6696 * termcap.c (tgetent): Likewise.
6697 * xfns.c (x_default_font_parameter): Likewise.
6698 * xsettings.c (read_and_apply_settings): Likewise.
6700 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6701 (overrun_check_free): Protoize.
6703 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6705 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6706 since callers should never pass a negative size.
6707 Change the signature to match that of plain 'read' and 'write'; see
6708 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6709 * lisp.h: Update prototypes of emacs_write and emacs_read.
6711 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6713 * xdisp.c (redisplay_window): Don't try to determine the character
6714 position of the scroll margin if the window start point w->startp
6715 is outside the buffer's accessible region. (Bug#8468)
6717 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6719 Fix write-region and its subroutines for buffers > 2GB.
6720 * fileio.c (a_write, e_write): Modify declaration of arguments and
6721 local variables to support buffers larger than 2GB.
6722 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6724 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6725 argument, local variables, and return value.
6727 * lisp.h: Update prototypes of emacs_write and emacs_read.
6729 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6731 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6733 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6735 Fix more problems found by GCC 4.6.0's static checks.
6737 * xdisp.c (vmessage): Use a better test for character truncation.
6739 * charset.c (load_charset_map): <, not <=, for optimization,
6740 and to avoid potential problems with integer overflow.
6741 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6742 * casetab.c (set_identity, shuffle): Likewise.
6743 * editfns.c (Fformat): Likewise.
6744 * syntax.c (skip_chars): Likewise.
6746 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6747 This also lets GCC 4.6.0 generate slightly better loop code.
6749 * callint.c (Fcall_interactively): <, not <=, for optimization.
6750 (Fcall_interactively): Count the number of arguments produced,
6751 not the number of arguments given. This is simpler and lets GCC
6752 4.6.0 generate slightly better code.
6754 * ftfont.c: Distingish more carefully between FcChar8 and char.
6755 The previous code passed unsigned char * to a functions like
6756 strlen and xstrcasecmp that expect char *, which does not
6757 conform to the C standard.
6758 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6759 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6760 char * when the C standard requires it.
6762 * keyboard.c (read_char): Remove unused var.
6764 * eval.c: Port to Windows vsnprintf (Bug#8435).
6766 (SIZE_MAX): Define if the headers do not.
6767 (verror): Do not give up if vsnprintf returns a negative count.
6768 Instead, grow the buffer. This ports to Windows vsnprintf, which
6769 does not conform to C99. Problem reported by Eli Zaretskii.
6770 Also, simplify the allocation scheme, by avoiding the need for
6771 calling realloc, and removing the ALLOCATED variable.
6773 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6775 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6776 But keep the doprint source code for now, as we might revamp it
6777 and use it again (Bug#8435).
6778 * lisp.h (doprnt): Remove.
6779 * Makefile.in (base_obj): Remove doprnt.o.
6780 * deps.mk (doprnt.o): Remove.
6782 error: Print 32- and 64-bit integers portably (Bug#8435).
6783 Without this change, on typical 64-bit hosts error ("...%d...", N)
6784 was used to print both 32- and 64-bit integers N, which relied on
6786 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6788 * lisp.h (error, verror): Mark as printf-like functions.
6789 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6790 Report overflow in size calculations when allocating printf buffer.
6791 Do not truncate output string at its first null byte.
6792 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6793 Truncate the output at a character boundary, since vsnprintf does not
6795 * charset.c (check_iso_charset_parameter): Convert internal
6796 character to string before calling 'error', since %c now has the
6798 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6799 overflow when computing char to be passed to 'error'. Do not
6800 pass Lisp_Object to 'error'; pass the integer instead.
6801 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6802 formatted with plain %d.
6804 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6806 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6808 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6810 * xterm.c (x_catch_errors): Remove duplicate declaration.
6812 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6814 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6816 2011-04-10 Jim Meyering <meyering@redhat.com>
6818 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6819 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6820 return ssize_t not "int", and use size_t as the buffer length.
6821 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6822 * gnutls.h: Update declarations.
6823 * process.c (read_process_output): Use ssize_t, to match.
6824 (send_process): Likewise.
6826 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6828 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6830 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6832 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6833 Use unsigned char, to match FcChar8 type definition.
6835 * xterm.c (handle_one_xevent):
6836 * xmenu.c (create_and_show_popup_menu):
6837 * xselect.c (x_decline_selection_request)
6838 (x_reply_selection_request): Avoid type-punned deref of X events.
6840 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6842 Fix some uses of `int' instead of EMACS_INT.
6843 * search.c (string_match_1, fast_string_match)
6844 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6845 (scan_buffer, find_next_newline_no_quit)
6846 (find_before_next_newline, search_command, Freplace_match)
6847 (Fmatch_data): Make some `int' variables be EMACS_INT.
6849 * xdisp.c (display_count_lines): 3rd argument and return value now
6850 EMACS_INT. All callers changed.
6851 (pint2hrstr): Last argument is now EMACS_INT.
6853 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6854 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6855 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6856 (decode_coding_utf_16, decode_coding_emacs_mule)
6857 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6858 (decode_coding_ccl, decode_coding_charset)
6859 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6860 (decode_coding_iso_2022, decode_coding_emacs_mule)
6861 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6862 <char_offset, last_offset>: Declare EMACS_INT.
6863 (encode_coding_utf_8, encode_coding_utf_16)
6864 (encode_coding_emacs_mule, encode_invocation_designation)
6865 (encode_designation_at_bol, encode_coding_iso_2022)
6866 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6867 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6869 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6870 (encode_invocation_designation): Last argument P_NCHARS is now
6872 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6873 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6875 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6878 * ccl.c (Fccl_execute_on_string): Declare some variables
6881 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6883 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6885 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6887 * process.c (Fformat_network_address): Doc fix.
6889 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6891 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6893 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6895 * keyboard.c (read_char): Call Lisp function help-form-show,
6896 instead of using internal_with_output_to_temp_buffer.
6897 (Qhelp_form_show): New var.
6898 (syms_of_keyboard): Use DEFSYM macro.
6900 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6902 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6904 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6906 * process.c (Flist_processes): Remove to Lisp.
6907 (list_processes_1): Delete.
6909 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6911 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6913 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6915 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6917 Fix more problems found by GCC 4.6.0's static checks.
6919 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6921 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6923 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6925 * xdisp.c (vmessage): Mark as a printf-like function.
6927 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6929 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6931 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6932 printf-like functions.
6933 (tiff_load): Add casts to remove these marks before passing them
6934 to system-supplied API.
6936 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6938 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6939 This avoids several warnings with gcc -Wstrict-overflow.
6940 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6941 directly, rather than having caller test rule sign. This avoids
6942 some unnecessary tests.
6943 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6944 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6945 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6947 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6948 (xfont_open): Avoid unnecessary tests.
6950 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6952 * composite.h, composite.c (composition_gstring_put_cache):
6953 Use EMACS_INT, not int, for length.
6955 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6956 breaking out part of COMPOSITION_DECODE_RULE.
6957 (COMPOSITION_DECODE_RULE): Use it.
6958 * composite.c (get_composition_id): Remove unused local vars,
6959 by using the new macro.
6961 * textprop.c (set_text_properties_1): Change while to do-while,
6962 since the condition is always true at first.
6964 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6965 (interval_deletion_adjustment): Return unsigned value.
6968 * process.c (list_processes_1, create_pty, read_process_output):
6969 (exec_sentinel): Remove vars that were set but not used.
6970 (create_pty): Remove unnecessary "volatile"s.
6971 (Fnetwork_interface_info): Avoid possibility of int overflow.
6972 (read_process_output): Do adaptive read buffering even if carryover.
6973 (read_process_output): Simplify nbytes computation if buffered.
6975 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6977 * syntax.c (scan_words): Remove var that was set but not used.
6978 (update_syntax_table): Use unsigned instead of int.
6980 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6981 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6982 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6984 * print.c (print_error_message): Avoid int overflow.
6986 * font.c (font_list_entities): Redo for clarity,
6987 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6989 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6990 (font_score): Avoid potential overflow in diff calculation.
6992 * fns.c (substring_both): Remove var that is set but not used.
6993 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6995 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6997 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6998 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6999 can always succeed if overflow has undefined behavior.
7001 * search.c (boyer_moore, wordify): Remove vars set but not used.
7002 (wordify): Omit three unnecessary tests.
7004 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7005 All callers changed. This avoids the need for an unused var.
7007 * casefiddle.c (casify_region): Remove var that is set but not used.
7009 * dired.c (file_name_completion): Remove var that is set but not used.
7011 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7013 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7014 (Finsert_file_contents): Remove unnecessary code checking fd.
7016 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7017 Check for integer overflow on size calculations.
7019 * buffer.c (Fprevious_overlay_change): Remove var that is set
7022 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7023 Remove vars that are set but not used.
7024 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7025 (timer_check_2): Mark vars as initialized.
7027 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7029 * image.c (lookup_image): Remove var that is set but not used.
7030 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7032 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7033 that are set but not used.
7035 * xfns.c (make_invisible_cursor): Don't return garbage
7036 if XCreateBitmapFromData fails (Bug#8410).
7038 * xselect.c (x_get_local_selection, x_handle_property_notify):
7039 Remove vars that are set but not used.
7041 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7042 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7044 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7045 Remove var that is set but not used.
7046 (scroll_bar_windows_size): Now size_t, not int.
7047 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7050 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7051 (map_tty_color) [!defined MSDOS]: Likewise.
7053 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7055 * coding.c: Remove vars that are set but not used.
7056 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7057 All callers changed.
7058 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7059 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7060 (decode_coding_charset): Remove vars that are set but not used.
7062 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7063 that is set but not used.
7065 * print.c (print_object): Remove var that is set but not used.
7067 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7068 The gnulib version avoids calling malloc in the usual case,
7069 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7070 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7071 * filelock.c (current_lock_owner): Likewise.
7072 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7073 * sysdep.c: Include allocator.h, careadlinkat.h.
7074 (emacs_no_realloc_allocator): New static constant.
7075 (emacs_readlink): New function.
7076 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7077 ../lib/careadlinkat.h.
7079 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7081 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7082 first non-nil return value).
7084 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7086 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7087 if not defined (Bug#8403).
7089 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7091 * xdisp.c (display_count_lines): Remove parameter `start',
7092 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7093 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7094 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7095 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7096 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7097 and thereabouts. All callers changed.
7098 (get_per_char_metric): Remove parameter `f', unused since
7099 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7101 2011-04-02 Jim Meyering <meyering@redhat.com>
7103 do not dereference NULL upon failed strdup
7104 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7105 (ns_get_family): Likewise.
7107 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7109 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7111 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7113 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7116 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7118 Add lexical binding.
7120 * window.c (Ftemp_output_buffer_show): New fun.
7121 (Fsave_window_excursion):
7122 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7124 * lread.c (lisp_file_lexically_bound_p): New function.
7125 (Fload): Bind Qlexical_binding.
7126 (readevalloop): Remove `evalfun' arg.
7127 Bind Qinternal_interpreter_environment.
7128 (Feval_buffer): Bind Qlexical_binding.
7129 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7131 (syms_of_lread): Declare `lexical-binding'.
7133 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7135 * keyboard.c (eval_dyn): New fun.
7136 (menu_item_eval_property): Use it.
7138 * image.c (parse_image_spec): Use Ffunctionp.
7140 * fns.c (concat, mapcar1): Accept byte-code-functions.
7142 * eval.c (Fsetq): Handle lexical vars.
7143 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7144 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7145 (FletX, Flet): Obey lexical binding.
7146 (Fcommandp): Handle closures.
7147 (Feval): New `lexical' arg.
7148 (eval_sub): New function extracted from Feval. Use it almost
7149 everywhere where Feval was used. Look up vars in lexical env.
7151 (Ffunctionp): Move from subr.el.
7152 (Ffuncall): Handle closures.
7153 (apply_lambda): Remove `eval_flags'.
7154 (funcall_lambda): Handle closures and new byte-code-functions.
7155 (Fspecial_variable_p): New function.
7156 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7157 but without exporting it to Lisp.
7159 * doc.c (Fdocumentation, store_function_docstring):
7160 * data.c (Finteractive_form): Handle closures.
7162 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7165 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7167 (exec_byte_code): New function extracted from Fbyte_code to handle new
7168 calling convention for byte-code-functions. Add new byte-codes.
7170 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7172 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7174 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7176 * xdisp.c (redisplay_internal): Fix prototype.
7178 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7180 * xdisp.c (SCROLL_LIMIT): New macro.
7181 (try_scrolling): Use it when setting scroll_limit.
7182 Limit scrolling to 100 screen lines.
7183 (redisplay_window): Even when falling back on "recentering",
7184 position point in the window according to scroll-conservatively,
7185 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7187 (try_scrolling): When point is above the window, allow searching
7188 as far as scroll_max, or one screenful, to compute vertical
7189 distance from PT to the scroll margin position. This prevents
7190 try_scrolling from unnecessarily failing when
7191 scroll-conservatively is set to a value slightly larger than the
7192 window height. Clean up the case of PT below the margin at bottom
7193 of window: scroll_max can no longer be INT_MAX. When aggressive
7194 scrolling is in use, don't let point enter the opposite scroll
7195 margin as result of the scroll.
7196 (syms_of_xdisp) <scroll-conservatively>: Document the
7197 threshold of 100 lines for never-recentering scrolling.
7199 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7201 * dispextern.h (move_it_by_lines):
7202 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7203 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7204 (message_log_check_duplicate): Remove parameters `prev_bol' and
7205 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7206 (redisplay_internal): Remove parameter `preserve_echo_area',
7207 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7209 * indent.c (Fvertical_motion):
7210 * window.c (window_scroll_pixel_based, Frecenter):
7211 Don't pass `need_y_p' to `move_it_by_lines'.
7213 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7215 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7216 steal a few bits to be more compact.
7217 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7218 Remove unneeded casts.
7220 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7222 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7224 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7225 binding" message (bug#7967).
7227 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7229 Fix more problems found by GCC 4.6.0's static checks.
7231 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7232 Remove unused local var.
7234 * editfns.c (Fmessage_box): Remove unused local var.
7236 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7237 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7238 Omit unused local vars.
7239 * window.c (shrink_windows): Omit unused local var.
7240 * menu.c (digest_single_submenu): Omit unused local var.
7241 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7242 Omit unused local var.
7244 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7245 Don't assume string length fits in int.
7246 (keyremap_step, read_key_sequence): Use size_t for sizes.
7247 (read_key_sequence): Don't check last_real_key_start redundantly.
7249 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7250 instead of alloca (Bug#8344).
7252 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7253 (Fbacktrace_frame): Don't assume nframes fits in int.
7255 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7257 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7260 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7262 * cm.c (calccost): Turn while-do into do-while, for clarity.
7264 * keyboard.c (syms_of_keyboard): Use the same style as later
7265 in this function when indexing through an array. This also
7266 works around GCC bug 48267.
7268 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7270 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7272 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7273 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7275 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7276 This avoids undefined behavior on integer overflow, and is a bit
7277 more convenient anyway since it is compared to a size_t variable.
7279 Variadic C functions now count arguments with size_t, not int.
7280 This avoids an unnecessary limitation on 64-bit machines, which
7281 caused (substring ...) to crash on large vectors (Bug#8344).
7282 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7283 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7284 All variadic functions and their callers changed accordingly.
7285 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7286 * data.c (arith_driver, float_arith_driver): Likewise.
7287 * editfns.c (general_insert_function): Likewise.
7288 * eval.c (struct backtrace.nargs, interactive_p)
7289 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7290 (funcall_lambda, mark_backtrace): Likewise.
7291 * fns.c (concat): Likewise.
7292 * frame.c (x_set_frame_parameters): Likewise.
7293 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7294 0 if not found, not -1. All callers changed.
7296 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7297 (stack_copy_size): Now size_t, not int.
7298 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7300 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7302 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7303 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7304 All callers changed.
7306 * lisp.h (multibyte_char_to_unibyte):
7307 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7308 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7309 * character.h (CHAR_TO_BYTE8):
7310 * cmds.c (internal_self_insert):
7311 * editfns.c (general_insert_function):
7312 * keymap.c (push_key_description):
7313 * search.c (Freplace_match):
7314 * xdisp.c (message_dolog, set_message_1): All callers changed.
7316 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7318 * keyboard.c (safe_run_hook_funcall): New function.
7319 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7320 don't set the hook to nil, but remove the offending function instead.
7321 (Qcommand_hook_internal): Remove, unused.
7322 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7323 Vcommand_hook_internal.
7325 * eval.c (enum run_hooks_condition): Remove.
7326 (funcall_nil, funcall_not): New functions.
7327 (run_hook_with_args): Call each function through a `funcall' argument.
7328 Remove `cond' argument, now redundant.
7329 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7330 (Frun_hook_with_args_until_failure): Adjust accordingly.
7331 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7333 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7335 * dispextern.h (string_buffer_position): Remove declaration.
7337 * print.c (strout): Remove parameter `multibyte', unused since
7338 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7340 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7341 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7342 All callers changed.
7344 * w32.c (_wsa_errlist): Use braces for struct initializers.
7346 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7347 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7348 All callers changed.
7349 (string_buffer_position): Likewise. Also, make static (it's never
7350 used outside xdisp.c).
7351 (cursor_row_p): Remove parameter `w', unused since
7352 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7353 (decode_mode_spec): Remove parameter `precision', introduced during
7354 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7355 All callers changed.
7357 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7359 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7361 2011-03-27 Anders Lindgren <andlind@gmail.com>
7363 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7364 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7365 (ns_update_auto_hide_menu_bar): New functions.
7366 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7367 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7368 ns_constrain_all_frames.
7369 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7370 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7372 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7374 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7376 2011-03-27 Glenn Morris <rgm@gnu.org>
7378 * syssignal.h: Replace RETSIGTYPE with void.
7379 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7380 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7381 Replace SIGTYPE with void everywhere.
7382 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7383 * s/template.h (SIGTYPE): Remove commented out definition.
7385 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7387 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7388 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7390 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7392 * w32.c (read_unc_volume): Use parameter `henum', instead of
7393 global variable `wget_enum_handle'.
7395 * keymap.c (describe_vector): Remove parameters `indices' and
7396 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7397 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7399 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7401 * keyboard.c (timer_check): Remove parameter `do_it_now',
7402 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7403 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7404 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7406 * keyboard.c (read_char):
7407 * w32menu.c (w32_menu_display_help):
7408 * xmenu.c (show_help_event, menu_help_callback):
7409 Adjust calls to `show_help_echo'.
7411 * gtkutil.c (xg_maybe_add_timer):
7412 * keyboard.c (readable_events):
7413 * process.c (wait_reading_process_output):
7414 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7416 * insdel.c (adjust_markers_gap_motion):
7417 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7418 (gap_left, gap_right): Don't call it.
7420 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7422 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7423 incurred during fontification.
7425 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7427 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7428 (DEFVAR_PER_BUFFER): Don't pass it.
7430 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7431 (scrolling_window): Don't pass it.
7433 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7435 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7437 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7439 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7440 of variables specific to SELinux and computation of `encoded_absname'.
7442 * image.c (XPutPixel): Remove unused variable `height'.
7444 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7446 * unexw32.c (get_section_info): Remove unused variable `section'.
7448 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7449 (system_process_attributes): Remove unused variable `sess'.
7450 (sys_read): Remove unused variable `err'.
7452 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7453 (w32_wnd_proc): Remove unused variable `isdead'.
7454 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7455 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7456 (x_create_tip_frame): Remove unused variable `tem'.
7458 * w32inevt.c (w32_console_read_socket):
7459 Remove unused variable `no_events'.
7461 * w32term.c (x_draw_composite_glyph_string_foreground):
7462 Remove unused variable `width'.
7464 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7466 * w32term.c (x_set_glyph_string_clipping):
7467 Don't pass uninitialized region to CombineRgn.
7469 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7471 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7472 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7473 (Fx_close_connection): Remove unused variable `i'.
7475 * w32font.c (w32font_draw): Return number of glyphs.
7476 (w32font_open_internal): Remove unused variable `i'.
7477 (w32font_driver): Add missing initializer.
7479 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7480 (fill_in_menu): Remove unused variable `items_added'.
7482 * w32term.c (last_mouse_press_frame): Remove static global variable.
7483 (w32_clip_to_row): Remove unused variable `f'.
7484 (x_delete_terminal): Remove unused variable `i'.
7486 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7487 (NOTHING): Remove unused static global variable.
7488 (uniscribe_check_otf): Remove unused variable `table'.
7489 (uniscribe_font_driver): Add missing initializers.
7491 2011-03-23 Julien Danjou <julien@danjou.info>
7493 * term.c (Fsuspend_tty, Fresume_tty):
7494 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7495 * window.c (temp_output_buffer_show):
7496 * insdel.c (signal_before_change):
7497 * frame.c (Fhandle_switch_frame):
7498 * fileio.c (Fdo_auto_save):
7499 * emacs.c (Fkill_emacs):
7500 * editfns.c (save_excursion_restore):
7501 * cmds.c (internal_self_insert):
7502 * callint.c (Fcall_interactively):
7503 * buffer.c (Fkill_all_local_variables):
7504 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7506 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7507 unconditionnaly since it does the check itself.
7509 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7511 Fix more problems found by GCC 4.5.2's static checks.
7513 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7514 the first time through the loop, since we know p0 < p1 then.
7515 This also avoids a gcc -Wstrict-overflow warning.
7517 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7518 leading to a memory leak, possible in functions like
7519 load_charset_map_from_file that can allocate an unbounded number
7520 of objects (Bug#8318).
7522 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7523 that could (at least in theory) be that large.
7525 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7526 This is less likely to overflow, and avoids undefined behavior if
7527 overflow does occur. All callers changed. Use strtoul to scan
7528 for the unsigned long integer.
7529 (pint2hrstr): Simplify and tune code slightly.
7530 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7532 * scroll.c (do_scrolling): Work around GCC bug 48228.
7533 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7535 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7536 This also avoids a warning with gcc -Wstrict-overflow.
7537 (validate_x_resource_name): Simplify count usage.
7538 This also avoids a warning with gcc -Wstrict-overflow.
7540 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7543 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7545 * process.c (Fmake_network_process): Use socklen_t, not int,
7546 where POSIX says socklen_t is required in portable programs.
7547 This fixes a porting bug on hosts like 64-bit HP-UX, where
7548 socklen_t is wider than int (Bug#8277).
7549 (Fmake_network_process, server_accept_connection):
7550 (wait_reading_process_output, read_process_output):
7553 * process.c: Rename or move locals to avoid shadowing.
7554 (list_processes_1, Fmake_network_process):
7555 (read_process_output_error_handler, exec_sentinel_error_handler):
7556 Rename or move locals.
7557 (Fmake_network_process): Define label "retry_connect" only if needed.
7558 (Fnetwork_interface_info): Fix pointer signedness.
7559 (process_send_signal): Add cast to avoid pointer signedness problem.
7560 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7561 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7563 Make tparam.h and terminfo.c consistent.
7564 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7565 Include tparam.h instead, since it declares them.
7566 * cm.h (PC): Remove extern decl; tparam.h now does this.
7567 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7568 * terminfo.c: Include tparam.h, to check interfaces.
7569 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7570 (tparam): Adjust signature to match interface in tparam.h;
7571 this removes some undefined behavior. Check that outstring and len
7572 are zero, which they always are with Emacs.
7573 * tparam.h (PC, BC, UP): New extern decls.
7575 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7576 (xftfont_open): Rename locals to avoid shadowing.
7578 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7579 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7580 (OTF_TAG_SYM): Omit macro if not needed.
7581 (ftfont_list): Remove unused local.
7582 (get_adstyle_property, ftfont_pattern_entity):
7583 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7584 Rename locals to avoid shadowing.
7586 * xfont.c (xfont_list_family): Mark var as initialized.
7588 * xml.c (make_dom): Now static.
7590 * composite.c (composition_compute_stop_pos): Rename local to
7592 (composition_reseat_it): Remove unused locals.
7593 (find_automatic_composition, composition_adjust_point): Likewise.
7594 (composition_update_it): Mark var as initialized.
7595 (find_automatic_composition): Mark vars as initialized,
7596 with a FIXME (Bug#8290).
7598 character.h: Rename locals to avoid shadowing.
7599 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7600 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7601 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7602 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7605 * textprop.c (property_change_between_p): Remove; unused.
7607 * intervals.c (interval_start_pos): Now static.
7609 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7611 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7612 Rename locals to avoid shadowing.
7614 * sound.c (wav_play, au_play, Fplay_sound_internal):
7615 Fix pointer signedness.
7616 (alsa_choose_format): Remove unused local var.
7617 (wav_play): Initialize a variable to 0, to prevent undefined
7618 behavior (Bug#8278).
7620 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7622 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7625 clobbering (Bug#8298).
7626 * sysdep.c (sys_subshell): Likewise.
7627 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7629 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7630 This should get cleaned up, so that child_setup has the
7631 same signature on all platforms.
7633 * callproc.c (call_process_cleanup): Now static.
7634 (relocate_fd): Rename locals to avoid shadowing.
7636 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7638 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7639 not to be necessary, and produces flickering.
7641 2011-03-20 Glenn Morris <rgm@gnu.org>
7643 * config.in: Remove file.
7645 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7647 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7648 are now in src/globals.h.
7649 (syms_of_minibuf): Remove spurious & from previous change.
7651 2011-03-20 Leo <sdl.web@gmail.com>
7653 * minibuf.c (completing-read-function): New variable.
7654 (completing-read-default): Rename from completing-read.
7655 (completing-read): Call completing-read-function.
7657 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7659 * xfaces.c (Fx_load_color_file):
7660 Read color file from absolute filename (bug#8250).
7662 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7664 * makefile.w32-in: Update dependencies.
7666 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7668 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7670 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7672 Fix more problems found by GCC 4.5.2's static checks.
7674 * process.c (make_serial_process_unwind, send_process_trap):
7675 (sigchld_handler): Now static.
7677 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7678 That way, the code declares only the vars that it needs.
7679 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7680 * s/cygwin.h (PTY_ITERATION): Likewise.
7681 * s/darwin.h (PTY_ITERATION): Likewise.
7682 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7684 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7685 * process.c (allocate_pty): Don't declare stb unless it's needed.
7687 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7688 (CONSTANTLIM): Remove; unused.
7689 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7690 Define only if needed.
7692 * unexelf.c (unexec): Name an expression,
7693 to avoid gcc -Wbad-function-cast warning.
7694 Use a different way to cause a compilation error if anyone uses
7695 n rather than nn, a way that does not involve shadowing.
7696 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7698 * deps.mk (unexalpha.o): Remove; unused.
7700 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7701 * unexec.h: New file.
7702 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7703 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7705 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7706 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7707 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7708 Change as necessary to match prototype in unexec.h.
7710 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7712 (back_comment, skip_chars): Mark vars as initialized.
7714 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7715 Rename locals to avoid shadowing.
7717 * lread.c (read1): Rewrite so as not to use empty "else".
7718 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7720 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7722 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7723 warning when compiling print.c.
7725 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7726 instead of using an uninitialized var.
7727 (font_sort_entities): Mark var as initialized.
7729 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7731 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7732 pointers to constants.
7733 (font_parse_fcname): Remove unused vars.
7734 (font_delete_unmatched): Now static.
7735 (font_get_spec): Remove; unused.
7736 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7737 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7738 Rename or move locals to avoid shadowing.
7740 * fns.c (require_nesting_list, require_unwind): Now static.
7741 (Ffillarray): Rename locals to avoid shadowing.
7743 * floatfns.c (domain_error2): Define only if needed.
7744 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7746 * alloc.c (mark_backtrace): Move decl from here ...
7747 * lisp.h: ... to here, so that it can be checked.
7749 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7750 (Fdefvar): Rewrite so as not to use empty "else".
7751 (lisp_indirect_variable): Name an expression,
7752 to avoid gcc -Wbad-function-cast warning.
7753 (Fdefvar): Rename locals to avoid shadowing.
7755 * callint.c (quotify_arg, quotify_args): Now static.
7756 (Fcall_interactively): Rename locals to avoid shadowing.
7757 Use const pointer when appropriate.
7759 * lisp.h (get_system_name, get_operating_system_release):
7760 Move decls here, to check interfaces.
7761 * process.c (get_operating_system_release): Move decl to lisp.h.
7762 * xrdb.c (get_system_name): Likewise.
7763 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7764 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7765 some of which prompt warnings from gcc -Wbad-function-cast.
7766 (Fformat_time_string, Fencode_time, Finsert_char):
7767 (Ftranslate_region_internal, Fformat):
7768 Rename or remove local vars to avoid shadowing.
7769 (Ftranslate_region_internal): Mark var as initialized.
7771 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7774 * lisp.h (eassert): Check that the argument compiles, even if
7775 ENABLE_CHECKING is not defined.
7777 * data.c (Findirect_variable): Name an expression, to avoid
7778 gcc -Wbad-function-cast warning.
7779 (default_value, arithcompare, arith_driver, arith_error): Now static.
7780 (store_symval_forwarding): Rename local to avoid shadowing.
7781 (Fmake_variable_buffer_local, Fmake_local_variable):
7782 Mark variables as initialized.
7783 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7785 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7786 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7787 Rename locals to avoid shadowing.
7788 (mark_stack): Move local variables into the #ifdef region where
7790 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7791 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7793 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7794 (GC_STRING_CHARS): Remove; not used.
7795 (Fmemory_limit): Cast sbrk's returned value to char *.
7797 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7798 avoids undefined behavior in theory.
7800 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7802 Use functions, not macros, for up- and down-casing (Bug#8254).
7803 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7804 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7805 to use the following functions instead of these macros.
7806 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7807 EMACS_INT, since callers assume the returned value fits in int.
7808 (upcase1): Likewise, for UPCASE_TABLE.
7809 (uppercasep, lowercasep, upcase): New static inline functions.
7810 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7811 the race-condition problem in the old DOWNCASE.
7813 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7814 Rename locals to avoid shadowing.
7815 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7816 (regex_compile, re_search_2, re_match_2_internal):
7817 Remove unused local vars.
7818 (FREE_VAR): Rewrite so as not to use empty "else",
7819 which gcc can warn about.
7820 (regex_compile, re_match_2_internal): Mark locals as initialized.
7821 (RETALLOC_IF): Define only if needed.
7822 (WORDCHAR_P): Likewise. This one is never needed, but is used
7823 only in a comment talking about a compiler bug, so put inside
7824 the #if 0 of that comment.
7825 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7826 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7829 * search.c (boyer_moore): Rename locals to avoid shadowing.
7830 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7831 (PREV_CHAR_BOUNDARY): Likewise.
7833 * search.c (simple_search): Remove unused var.
7835 * dired.c (compile_pattern): Move decl from here ...
7836 * lisp.h: ... to here, so that it can be checked.
7837 (struct re_registers): New forward decl.
7839 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7841 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7843 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7844 Rename locals to avoid shadowing.
7845 (Fvertical_motion): Mark locals as initialized.
7847 * casefiddle.c (casify_object, casify_region): Now static.
7848 (casify_region): Mark local as initialized.
7850 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7852 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7853 New macros, so that the caller can use some names other than
7854 gcpro1, gcpro2, etc.
7855 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7857 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7858 argument, for consistency with GCPRO2_VAR, etc: it is now the
7859 prefix of the variable, not the variable itself. All uses
7861 * dired.c (directory_files_internal, file_name_completion):
7862 Rename locals to avoid shadowing.
7864 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7865 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7866 dired.c's scmp function, had undefined behavior.
7867 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7868 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7869 * buffer.h: ... to here, because these macros use current_buffer,
7870 and the new implementation with inline functions needs to have
7871 current_buffer in scope now, rather than later when the macros
7873 (downcase, upcase1): New static inline functions.
7874 (DOWNCASE, UPCASE1): Reimplement using these functions.
7875 This avoids undefined behavior in expressions like
7876 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7877 from race conditions in accessing the global variables
7878 case_temp1 and case_temp2.
7879 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7880 * lisp.h (case_temp1, case_temp2): Remove their decls.
7881 * character.h (ASCII_CHAR_P): Move from here ...
7882 * lisp.h: ... to here, so that the inline functions mentioned
7885 * dired.c (directory_files_internal_unwind): Now static.
7887 * fileio.c (file_name_as_directory, directory_file_name):
7888 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7890 (file_name_as_directory): Use const pointers when appropriate.
7891 (Fexpand_file_name): Likewise. In particular, newdir might
7892 point at constant storage, so make it a const pointer.
7893 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7894 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7896 (Fset_file_times, Finsert_file_contents, auto_save_error):
7897 Rename locals to avoid shadowing.
7899 * minibuf.c (choose_minibuf_frame_1): Now static.
7900 (Ftry_completion, Fall_completions): Rename or remove locals
7903 * marker.c (bytepos_to_charpos): Remove; unused.
7905 * lisp.h (verify_bytepos, count_markers): New decls,
7906 so that gcc does not warn that these functions aren't declared.
7908 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7909 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7910 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7911 (copy_text): Remove unused local var.
7913 * filelock.c (within_one_second): Now static.
7914 (lock_file_1): Rename local to avoid shadowing.
7916 * buffer.c (fix_overlays_before): Mark locals as initialized.
7917 (fix_start_end_in_overlays): Likewise. This function should be
7918 simplified by using pointers-to-pointers, but that's a different
7920 (switch_to_buffer_1): Now static.
7921 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7922 (report_overlay_modification): Rename locals to avoid shadowing.
7924 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7925 Fix pointer signedness issue.
7926 (sys_subshell): Mark local as volatile if checking for lint,
7927 to suppress a gcc -Wclobbered warning that does not seem to be right.
7928 (MAXPATHLEN): Define only if needed.
7930 * process.c (serial_open, serial_configure): Move decls from here ...
7931 * systty.h: ... to here, so that they can be checked.
7933 * fns.c (get_random, seed_random): Move extern decls from here ...
7934 * lisp.h: ... to here, so that they can be checked.
7936 * sysdep.c (reset_io): Now static.
7937 (wait_for_termination_signal): Remove; unused.
7939 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7940 (copy_keymap_item, append_key, push_text_char_description):
7942 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7943 (DENSE_TABLE_SIZE): Remove; unused.
7944 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7945 (describe_map_tree):
7946 Rename locals to avoid shadowing.
7948 * keyboard.c: Declare functions static if they are not used elsewhere.
7949 (echo_char, echo_dash, cmd_error, top_level_2):
7950 (poll_for_input, handle_async_input): Now static.
7951 (read_char, kbd_buffer_get_event, make_lispy_position):
7952 (make_lispy_event, make_lispy_movement, apply_modifiers):
7953 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7954 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7955 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7956 (read_key_sequence, read_char): Mark locals as initialized.
7957 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7959 * keyboard.h (make_ctrl_char): New decl.
7960 (mark_kboards): Move decl here ...
7961 * alloc.c (mark_kboards): ... from here.
7963 * lisp.h (force_auto_save_soon): New decl.
7965 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7966 (DEFINE_DUMMY_FUNCTION): New macro.
7967 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7969 (main): Add casts to avoid warnings
7970 if GCC considers string literals to be constants.
7972 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7974 * dbusbind.c: Pointer signedness fixes.
7975 (xd_signature, xd_append_arg, xd_initialize):
7976 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7977 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7978 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7979 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7981 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7982 if GCC considers string literals to be constants.
7983 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7985 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7987 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7988 (print_preprocess, print_object): New macro to fix last change.
7990 * print.c (print_preprocess): Don't forget font objects.
7992 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7994 * emacs.c (USAGE3): Doc fixes.
7996 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7998 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8001 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8003 * lisp.h (VWindow_system, Qfile_name_history):
8004 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8005 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8006 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8008 * w32select.c: Don't #include "keyboard.h".
8009 (run_protected): Add extern declaration for waiting_for_input.
8011 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8012 * w32console.c (detect_input_pending, read_input_pending)
8013 (encode_terminal_code):
8014 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8015 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8016 (w32_system_caret_y, Qfile_name_history):
8017 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8018 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8019 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8020 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8021 * w32proc.c (Qlocal, report_file_error):
8022 * w32term.c (Vwindow_system, updating_frame):
8023 * w32uniscribe.c (initialized, uniscribe_font_driver):
8024 Remove unneeded extern declarations.
8026 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8028 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8030 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8032 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8033 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8034 These macros can no longer be used for assignment.
8036 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8037 Assign struct members directly, instead of using BUF_BEGV etc.
8038 (record_buffer_markers, fetch_buffer_markers): New functions for
8039 recording and fetching special buffer markers.
8040 (set_buffer_internal_1, set_buffer_temp): Use them.
8042 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8044 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8046 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8047 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8049 * xdisp.c (hscroll_window_tree):
8050 (reconsider_clip_changes): Use PT instead of BUF_PT.
8052 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8054 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8055 $(EMACS_ROOT)/lib/intprops.h.
8057 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8059 Fix more problems found by GCC 4.5.2's static checks.
8061 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8062 to unsigned char * to avoid compiler diagnostic.
8063 (xg_free_frame_widgets): Make it clear that a local variable is
8064 needed only if USE_GTK_TOOLTIP.
8065 (gdk_window_get_screen): Make it clear that this macro is needed
8066 only if USE_GTK_TOOLTIP.
8067 (int_gtk_range_get_value): New function, which avoids a diagnostic
8068 from gcc -Wbad-function-cast.
8069 (xg_set_toolkit_scroll_bar_thumb): Use it.
8070 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8071 diagnostic from gcc -Wbad-function-cast.
8072 (get_utf8_string, xg_get_file_with_chooser):
8073 Rename locals to avoid shadowing.
8074 (create_dialog): Move locals to avoid shadowing.
8076 * xgselect.c (xg_select): Remove unused var.
8078 * image.c (four_corners_best): Mark locals as initialized.
8079 (gif_load): Initialize transparent_p to zero (Bug#8238).
8080 Mark another local as initialized.
8081 (my_png_error, my_error_exit): Mark with NO_RETURN.
8083 * image.c (clear_image_cache): Now static.
8084 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8085 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8086 (x_edge_detection): Remove unnecessary cast that
8087 gcc -Wbad-function-cast diagnoses.
8088 (gif_load): Fix pointer signedness.
8089 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8090 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8092 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8094 Improve quality of tests for time stamp overflow.
8095 For example, without this patch (encode-time 0 0 0 1 1
8096 1152921504606846976) returns the obviously-bogus value (-948597
8097 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8098 reports time overflow. See
8099 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8100 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8101 * editfns.c: Include limits.h and intprops.h.
8102 (TIME_T_MIN, TIME_T_MAX): New macros.
8103 (time_overflow): Move earlier, to before first use.
8104 (hi_time, lo_time): New functions, for an accurate test for
8106 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8107 (Fget_internal_run_time): Don't assume time_t fits in int.
8108 (make_time): Use list2 instead of Fcons twice.
8109 (Fdecode_time): More accurate test for out-of-range times.
8110 (check_tm_member): New function.
8111 (Fencode_time): Use it, to test for out-of-range times.
8112 (lisp_time_argument): Don't rely on undefined left-shift and
8113 right-shift behavior when checking for time stamp overflow.
8115 * editfns.c (time_overflow): New function, refactoring common code.
8116 (Fformat_time_string, Fdecode_time, Fencode_time):
8117 (Fcurrent_time_string): Use it.
8119 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8120 * dired.c (make_time): Move to ...
8121 * editfns.c (make_time): ... here.
8122 * systime.h: Note the move.
8124 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8126 * fringe.c (update_window_fringes): Remove unused variables.
8128 * unexmacosx.c (copy_data_segment): Also copy __got section.
8131 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8133 * termcap.c [MSDOS]: Include "msdos.h".
8134 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8135 Constify `char *' arguments and their references according to
8136 prototypes in tparam.h.
8138 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8140 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8141 Adapt all references accordingly.
8143 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8145 2011-03-11 Tom Tromey <tromey@redhat.com>
8147 * buffer.c (syms_of_buffer): Remove obsolete comment.
8149 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8151 * termhooks.h (encode_terminal_code): Declare prototype.
8153 * msdos.c (encode_terminal_code): Don't declare prototype.
8155 * term.c (encode_terminal_code): Now external again, used by
8156 w32console.c and msdos.c.
8158 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8159 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8161 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8163 Fix some minor problems found by GCC 4.5.2's static checks.
8165 * fringe.c (update_window_fringes): Mark locals as initialized
8167 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8169 * alloc.c (mark_fringe_data): Move decl from here ...
8170 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8171 to check its interface.
8172 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8174 * fontset.c (free_realized_fontset): Now static.
8175 (Fset_fontset_font): Rename local to avoid shadowing.
8176 (fontset_font): Mark local as initialized.
8177 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8179 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8181 * xselect.c (x_disown_buffer_selections): Remove; not used.
8182 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8183 (x_own_selection, Fx_disown_selection_internal): Rename locals
8185 (x_handle_dnd_message): Remove local to avoid shadowing.
8187 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8188 so that the caller can use some name other than gcpro1.
8189 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8190 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8191 (Fx_backspace_delete_keys_p):
8192 Use them to avoid shadowing, and rename vars to avoid shadowing.
8193 (x_decode_color, x_set_name, x_window): Now static.
8194 (Fx_create_frame): Add braces to silence GCC warning.
8195 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8196 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8197 Remove unused locals.
8198 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8199 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8200 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8203 * xterm.h (x_mouse_leave): New decl.
8205 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8206 Remove unused functions.
8207 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8208 (x_calc_absolute_position): Now static.
8209 (XTread_socket): Don't define label "out" unless it's used.
8210 Don't declare local "event" unless it's used.
8211 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8212 unless they are used.
8213 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8214 (x_fatal_error_signal): Remove; not used.
8215 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8216 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8217 (x_error_catcher, x_connection_closed, x_error_handler):
8218 (x_error_quitter, xembed_send_message, x_iconify_frame):
8219 (my_log_handler): Rename locals to avoid shadowing.
8220 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8221 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8223 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8224 Rename or move locals to avoid shadowing.
8225 (tty_defined_color, merge_face_heights): Now static.
8226 (free_realized_faces_for_fontset): Remove; not used.
8227 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8228 does not deduce is never used uninitialized.
8229 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8230 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8232 * terminal.c (store_terminal_param): Now static.
8234 * xmenu.c (menu_highlight_callback): Now static.
8235 (set_frame_menubar): Remove unused local.
8236 (xmenu_show): Rename parameter to avoid shadowing.
8237 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8238 since they might point to immutable storage.
8239 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8240 since it's unused otherwise.
8242 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8243 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8244 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8245 avoids a gcc -Wuninitialized diagnostic.
8246 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8247 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8248 does not deduce are never used uninitialized.
8250 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8252 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8253 * window.c (window_loop, size_window):
8254 (run_window_configuration_change_hook, enlarge_window): Likewise.
8256 * window.c (display_buffer): Now static.
8257 (size_window): Mark variables that gcc -Wuninitialized
8258 does not deduce are never used uninitialized.
8259 * window.h (check_all_windows): New decl, to forestall
8260 gcc -Wmissing-prototypes diagnostic.
8261 * dispextern.h (bidi_dump_cached_states): Likewise.
8263 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8265 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8267 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8268 and to avoid gcc -Wuninitialized warning.
8269 (load_charset_map): Mark variables that gcc -Wuninitialized
8270 does not deduce are never used uninitialized.
8271 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8273 * coding.c (coding_set_source, coding_set_destination):
8274 Use "else { /* comment */ }" rather than "else /* comment */;"
8275 for clarity, and to avoid gcc -Wempty-body warning.
8276 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8277 a block, when the outer 'i' will do.
8278 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8279 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8280 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8281 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8282 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8283 Rename locals to avoid shadowing.
8284 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8285 * coding.c (emacs_mule_char, encode_invocation_designation):
8286 Now static, since they're not used elsewhere.
8287 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8288 (decode_coding_object, encode_coding_object, detect_coding_system):
8289 (decode_coding_emacs_mule): Mark variables that gcc
8290 -Wuninitialized does not deduce are never used uninitialized.
8291 (detect_coding_iso_2022): Initialize a local variable that might
8292 be used uninitialized. Leave a FIXME because it's not clear that
8293 this initialization is needed. (Bug#8211)
8294 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8295 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8296 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8297 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8298 Remove unused macros.
8300 * category.c (hash_get_category_set): Remove unused local var.
8301 (copy_category_table): Now static, since it's not used elsewhere.
8302 * character.c (string_count_byte8): Likewise.
8304 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8305 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8307 * chartab.c (copy_sub_char_table): Now static, since it's not used
8309 (sub_char_table_ref_and_range, char_table_ref_and_range):
8310 Rename locals to avoid shadowing.
8311 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8313 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8314 (BIDI_BOB): Remove unused macro.
8316 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8317 deduce are never used uninitialized.
8318 * term.c (encode_terminal_code): Likewise.
8320 * term.c (encode_terminal_code): Now static. Remove unused local.
8322 * tparam.h: New file.
8323 * term.c, tparam.h: Include it.
8324 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8325 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8326 Move these decls to tparam.h, and make them agree with what
8327 is actually in tparam.c. The previous trick of using incompatible
8328 decls in different modules does not conform to the C standard.
8329 All callers of tparam changed to use tparam's actual API.
8330 * tparam.c (tparam1, tparam, tgoto):
8331 Use const pointers where appropriate.
8333 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8334 * cm.h (struct cm): Likewise.
8335 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8336 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8337 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8338 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8339 (turn_on_face, init_tty): Likewise.
8340 * termchar.h (struct tty_display_info): Likewise.
8342 * term.c (term_mouse_position): Rename local to avoid shadowing.
8344 * alloc.c (mark_ttys): Move decl from here ...
8345 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8347 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8349 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8351 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8353 * search.c (compile_pattern_1): Remove argument regp, unused since
8354 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8355 (compile_pattern): Don't pass it.
8357 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8359 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8360 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8362 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8364 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8366 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8367 gdk_window_get_screen, gdk_window_get_geometry,
8368 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8369 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8370 (xg_get_pixbuf_from_pixmap): New function.
8371 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8372 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8373 Call xg_get_pixbuf_from_pixmap instead of
8374 gdk_pixbuf_get_from_drawable.
8375 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8376 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8377 (xg_check_special_colors): Use GtkStyleContext and its functions
8379 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8380 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8381 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8382 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8383 Call gtk_widget_get_preferred_size.
8384 (xg_frame_resized): gdk_window_get_geometry only takes 5
8386 (xg_win_to_widget, xg_event_is_for_menubar):
8387 Call gdk_x11_window_lookup_for_display.
8388 (xg_set_widget_bg): New function.
8389 (delete_cb): New function.
8390 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8391 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8392 (xg_set_background_color): Call xg_set_widget_bg.
8393 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8394 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8395 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8396 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8398 (update_frame_tool_bar): Call gtk_widget_hide.
8399 (xg_initialize): Use GDK_KEY_g.
8401 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8403 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8405 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8406 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8407 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8409 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8411 * w32xfns.c (select_palette): Check success of RealizePalette against
8412 GDI_ERROR, not zero.
8414 See ChangeLog.11 for earlier changes.
8420 Copyright (C) 2011 Free Software Foundation, Inc.
8422 This file is part of GNU Emacs.
8424 GNU Emacs is free software: you can redistribute it and/or modify
8425 it under the terms of the GNU General Public License as published by
8426 the Free Software Foundation, either version 3 of the License, or
8427 (at your option) any later version.
8429 GNU Emacs is distributed in the hope that it will be useful,
8430 but WITHOUT ANY WARRANTY; without even the implied warranty of
8431 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8432 GNU General Public License for more details.
8434 You should have received a copy of the GNU General Public License
8435 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.