1 2012-05-23 Eli Zaretskii <eliz@gnu.org>
3 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6 * buffer.c [REL_ALLOC]: Remove prototypes of
7 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
8 they are now on lisp.h.
10 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
12 * search.c (search_buffer): Use it to inhibit relocation of buffer
13 text while re_search_2 is doing its job, because re_search_2 is
14 passed C pointers to buffer text. (Bug#11519)
16 2012-05-21 Eli Zaretskii <eliz@gnu.org>
18 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
21 2012-05-19 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
24 state after an additional call to move_it_in_display_line_to, keep
25 the values of it->max_ascent and it->max_descent found for the
27 (pos_visible_p): Revert the comparison against bottom_y to what it
28 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
31 2012-05-15 Eli Zaretskii <eliz@gnu.org>
33 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
35 2012-05-13 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
38 already have overlays loaded.
39 (handle_single_display_spec): Before returning without displaying
40 fringe bitmap, synchronize the bidi iterator with the main display
41 iterator, by calling iterate_out_of_display_property.
42 (iterate_out_of_display_property): Detect buffer iteration by
43 testing that it->string is a Lisp string.
44 (get_next_display_element): When the current object is exhausted,
45 and there's something on it->stack, call set_iterator_to_next to
46 proceed with what's on the stack, instead of returning zero.
47 (set_iterator_to_next): If called at the end of a Lisp string,
48 proceed to consider_string_end without incrementing string
49 position. Don't increment display vector index past the end of
50 the display vector. (Bug#11417)
51 (pos_visible_p): Don't report a position visible when move_it_to
52 stopped at the last line of window, which happens to be scanned
53 backwards by the bidi iteration. (Bug#11464)
55 2012-05-11 Eli Zaretskii <eliz@gnu.org>
57 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
58 and right-margin display specs even if the spec is invalid or we
59 are on a TTY, and thus unable to display on the fringes. That's
60 because the text with the property will not be displayed anyway,
61 so we need to signal to the caller that this is a "replacing"
62 display spec. This fixes display when the spec is invalid or we
65 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
67 * unexaix.c (make_hdr): Fix typo in prototype.
68 This bug broke the build on AIX. Problem reported by Gilles Pion.
70 2012-05-05 Eli Zaretskii <eliz@gnu.org>
72 * w32proc.c (new_child): Force Windows to reserve only 64KB of
73 stack for each reader_thread, instead of defaulting to 8MB
74 determined by the linker. This avoids failures in creating
75 subprocesses on Windows 7, see the discussion in this thread:
76 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
78 2012-05-02 Jim Meyering <meyering@redhat.com>
80 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
82 2012-04-29 Eli Zaretskii <eliz@gnu.org>
84 * xdisp.c (pos_visible_p): If already at a newline from the
85 display string before the 'while' loop, don't walk back the glyphs
86 from it3.glyph_row. Solves assertion violation when the display
87 string begins with a newline (egg.el). (Bug#11367)
89 2012-04-24 Chong Yidong <cyd@gnu.org>
91 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
93 2012-04-23 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (pos_visible_p): If the window start position is beyond
96 ZV, start the display from buffer beginning. Prevents assertion
97 violation in init_iterator when the minibuffer window is scrolled
100 * window.c (window_scroll_pixel_based): Likewise.
102 2012-04-23 Chong Yidong <cyd@gnu.org>
104 * keymap.c (where_is_internal): Doc fix (Bug#10872).
106 2012-04-20 Glenn Morris <rgm@gnu.org>
108 * fileio.c (Fcopy_file, Fset_file_selinux_context):
109 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
111 2012-04-20 Eli Zaretskii <eliz@gnu.org>
113 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
114 overrun array limits of glyph row's used[] array. (Bug#11288)
116 2012-04-20 Chong Yidong <cyd@gnu.org>
118 * process.c (wait_reading_process_output): If EIO occurs on a pty,
119 set the status to "failed" and ensure that sentinel is run.
121 2012-04-18 Glenn Morris <rgm@gnu.org>
123 * process.c (Fset_process_inherit_coding_system_flag)
124 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
125 (Fmake_network_process, Fmake_serial_process): Doc fix.
127 2012-04-17 Eli Zaretskii <eliz@gnu.org>
129 * xdisp.c (string_buffer_position_lim): Limit starting position to
131 (set_cursor_from_row): If called for a mode-line or header-line
132 row, return zero immediately.
133 (try_cursor_movement): If inside continuation line, don't back up
134 farther than the first row after the header line, if any. Don't
135 consider the header-line row as "partially visible", even if
136 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
138 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
140 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
142 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
144 * process.c (make_process):
145 * process.h: Add integer `gnutls_handshakes_tried' member to
148 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
149 Add convenience `GNUTLS_LOG2i' macro.
151 * gnutls.c (gnutls_log_function2i): Convenience log function.
152 (emacs_gnutls_read): Use new log functions,
153 `gnutls_handshakes_tried' process member, and
154 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
155 attempts per process (connection).
157 2012-04-09 Eli Zaretskii <eliz@gnu.org>
159 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
160 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
162 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
164 * nsterm.m (constrainFrameRect): Always constrain when there is only
165 one screen (Bug#10962).
167 2012-04-06 Eli Zaretskii <eliz@gnu.org>
169 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
170 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
171 about subtle differences between FETCH_CHAR* and STRING_CHAR*
172 macros related to unification of CJK characters. For the details,
173 see the discussion following the message here:
174 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
176 2012-04-04 Chong Yidong <cyd@gnu.org>
178 * keyboard.c (Vdelayed_warnings_list): Doc fix.
180 2012-04-01 Eli Zaretskii <eliz@gnu.org>
182 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
183 instead of alloca. (Bug#11138)
185 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
187 * w32menu.c (is_simple_dialog): Properly check lisp types.
190 2012-03-31 Eli Zaretskii <eliz@gnu.org>
192 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
193 position we get to after a call to move_it_to fails the
194 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
195 only if we wind up in a string from display property. (Bug#11063)
197 * window.c (Fdelete_other_windows_internal): Invalidate the row
198 and column information about mouse highlight, so that redisplay
199 restores it after reallocating the glyph matrices. (Bug#7464)
201 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
202 string comes from a `display' text property, use the buffer
203 position of that property as if we actually saw that position in
205 (move_it_by_lines): Remove the assertion that
206 "it->current_x == 0 && it->hpos == 0" which can be legitimately
207 violated when there's a before-string at the beginning of a line.
210 2012-03-30 Eli Zaretskii <eliz@gnu.org>
212 * xdisp.c (append_space_for_newline): If the default face was
213 remapped, use the remapped face for the appended newline.
214 (extend_face_to_end_of_line): Use the remapped default face for
215 extending the face to the end of the line.
216 (display_line): Call extend_face_to_end_of_line when the default
217 face was remapped. (Bug#11068)
219 2012-03-29 Eli Zaretskii <eliz@gnu.org>
221 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
223 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
225 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
227 2012-03-27 Glenn Morris <rgm@gnu.org>
229 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
232 2012-03-26 Kenichi Handa <handa@m17n.org>
234 * dispextern.h (struct glyph): Fix previous change. Change the
235 bit length of glyphless.ch to 25 (Bug#11082).
237 2012-03-26 Chong Yidong <cyd@gnu.org>
239 * keyboard.c (Vselection_inhibit_update_commands): New variable.
240 (command_loop_1): Use it; inhibit selection update for
241 handle-select-window too (Bug#8996).
243 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
245 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
247 2012-03-25 Kenichi Handa <handa@m17n.org>
249 * dispextern.h (struct glyph): Change the bit length of
250 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
252 2012-03-24 Eli Zaretskii <eliz@gnu.org>
254 * s/ms-w32.h (tzname): Include time.h before redirecting to
255 _tzname. Fixes the MSVC build. (Bug#9960)
257 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
259 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
262 * xterm.c (XTread_socket): Only modify handling_signal if
263 !SYNC_INPUT. (Bug#11080)
265 2012-03-23 Eli Zaretskii <eliz@gnu.org>
267 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
268 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
269 when fetching a multibyte character consumes more bytes than
270 CHAR_BYTES returns, due to unification of CJK characters in
271 string_char. (Bug#11073)
273 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
275 * process.c (wait_reading_process_output): Handle pty disconnect
276 by refraining from sending oneself a SIGCHLD (bug#10933).
278 2012-03-22 Chong Yidong <cyd@gnu.org>
280 * dispextern.h (struct it): New member string_from_prefix_prop_p.
282 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
283 Mark string as coming from a prefix property.
284 (handle_face_prop): Use default face for prefix strings (Bug#4281).
285 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
287 2012-03-21 Chong Yidong <cyd@gnu.org>
289 * xfaces.c (Vface_remapping_alist): Doc fix.
291 2012-03-20 Eli Zaretskii <eliz@gnu.org>
293 * w32proc.c (Fw32_set_console_codepage)
294 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
297 2012-03-20 Chong Yidong <cyd@gnu.org>
299 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
300 to reflect default non-nil value of redisplay-dont-pause.
302 2012-03-19 Kenichi Handa <handa@m17n.org>
304 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
305 it fit in a valid range (Bug#11003).
307 2012-03-18 Eli Zaretskii <eliz@gnu.org>
309 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
310 that is not from display property, accept the row as a "cursor
311 row" if one of the string's character has a non-nil `cursor'
312 property. Fixes cursor positioning when there are newlines in
313 overlay strings, e.g. in icomplete.el. (Bug#11035)
315 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
317 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
319 2012-03-12 Chong Yidong <cyd@gnu.org>
321 * eval.c (inhibit_lisp_code): Rename from
322 inhibit_window_configuration_change_hook; move from window.c.
324 * xfns.c (unwind_create_frame_1, Fx_create_frame):
325 * window.c (run_window_configuration_change_hook)
326 (syms_of_window): Callers changed.
328 2012-03-11 Chong Yidong <cyd@gnu.org>
330 * keymap.c (Fkey_description): Doc fix (Bug#9700).
332 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
334 2012-03-10 Chong Yidong <cyd@gnu.org>
336 * frame.c (other_visible_frames): Don't assume the selected frame
337 is visible (Bug#10955).
339 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
341 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
343 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
345 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
346 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
349 2012-03-03 Glenn Morris <rgm@gnu.org>
351 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
353 2012-03-02 Eli Zaretskii <eliz@gnu.org>
355 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
356 position past the first glyph_row that ends at ZV. (Bug#10902)
357 (redisplay_window, next_element_from_string): Fix typos in
359 (redisplay_window): Pass to move_it_vertically the margin in
360 pixels, not in screen lines.
362 2012-03-02 Glenn Morris <rgm@gnu.org>
364 * buffer.c (buffer-list-update-hook): Doc fix.
366 2012-02-29 Eli Zaretskii <eliz@gnu.org>
368 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
369 push_it before setting up the iterator for the first overlay
370 string, even if we have an empty string loaded.
371 (next_overlay_string): If there's an empty string on the iterator
372 stack, pop the stack. (Bug#10903)
374 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
376 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
377 Suggested by Stefan Monnier in
378 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
379 * alloc.c (widen_to_Lisp_Object): New static function.
380 (mark_memory): Also mark Lisp_Objects by fetching pointer words
381 and widening them to Lisp_Objects. This would work even if
382 USE_LSB_TAG is defined and wide integers are used, which might
383 happen in a future version of Emacs.
385 2012-02-25 Chong Yidong <cyd@gnu.org>
387 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
390 * xselect.c (Fx_selection_exists_p): Doc fix.
391 (x_clipboard_manager_save_all): Print an informative message
392 before saving to clipboard manager.
394 2012-02-24 Chong Yidong <cyd@gnu.org>
396 * keyboard.c (process_special_events): Handle all X selection
397 requests in kbd_buffer, not just the next one (Bug#8869).
399 2012-02-23 Chong Yidong <cyd@gnu.org>
401 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
402 call when setting menu-bar-lines and tool-bar-lines parameters.
403 (unwind_create_frame_1): New helper function.
405 * window.c (inhibit_window_configuration_change_hook): New var.
406 (run_window_configuration_change_hook): Obey it.
407 (syms_of_window): Initialize it.
409 2012-02-22 Chong Yidong <cyd@gnu.org>
411 * xterm.c (x_draw_image_relief): Add missing type check for
412 Vtool_bar_button_margin (Bug#10743).
414 2012-02-21 Chong Yidong <cyd@gnu.org>
416 * fileio.c (Vfile_name_handler_alist): Doc fix.
418 * buffer.c (Fget_file_buffer): Protect against invalid file
419 handler return value.
421 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
423 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
424 when computing $valmask.
426 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
427 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
428 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
429 It's useless in that case, and it can cause problems on hosts
430 that allocate halves of EMACS_INT values separately.
431 Reported by Dan Horák. Diagnosed by Andreas Schwab in
432 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
433 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
434 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
435 it avoids undefined behavior on hosts where shifting right by more
436 than the word width has undefined behavior.
438 2012-02-19 Chong Yidong <cyd@gnu.org>
440 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
441 (Funhandled_file_name_directory, Ffile_name_as_directory)
442 (Fdirectory_file_name, Fexpand_file_name)
443 (Fsubstitute_in_file_name): Protect against invalid file handler
444 return values (Bug#10845).
446 2012-02-18 Eli Zaretskii <eliz@gnu.org>
448 * .gdbinit (pitx): Fix incorrect references to fields of the
451 2012-02-17 Chong Yidong <cyd@gnu.org>
453 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
455 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
457 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
458 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
460 2012-02-15 Chong Yidong <cyd@gnu.org>
462 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
463 marked as special. Also, starting docstrings with * is obsolete.
465 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
467 * gnutls.c (emacs_gnutls_write): Fix last change.
469 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
471 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
474 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
476 * keymap.c (Fsingle_key_description): Handle char ranges.
478 2012-02-12 Chong Yidong <cyd@gnu.org>
480 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
481 as that creates a dangerous corner case.
483 * window.c (Fdelete_window_internal): Invalidate the mouse
484 highlight (Bug#9904).
486 2012-02-12 Glenn Morris <rgm@gnu.org>
488 * xselect.c (Fx_own_selection_internal)
489 (Fx_get_selection_internal, Fx_disown_selection_internal)
490 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
491 * nsselect.m (Fx_own_selection_internal)
492 (Fx_disown_selection_internal, Fx_selection_exists_p)
493 (Fx_selection_owner_p, Fx_get_selection_internal):
494 Sync docs and argument specs with the xselect.c versions.
496 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
498 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
500 2012-02-11 Eli Zaretskii <eliz@gnu.org>
502 * w32select.c (Fx_selection_exists_p): Sync doc string and
503 argument list with xselect.c. (Bug#10783)
505 * w16select.c (Fx_selection_exists_p): Sync doc string and
506 argument list with xselect.c. (Bug#10783)
508 2012-02-10 Glenn Morris <rgm@gnu.org>
510 * fns.c (Fsecure_hash): Doc fix.
512 2012-02-09 Kenichi Handa <handa@m17n.org>
514 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
516 2012-02-07 Chong Yidong <cyd@gnu.org>
518 * buffer.c (Fbuffer_local_variables)
519 (buffer_lisp_local_variables): Handle unbound vars correctly;
520 don't let Qunbound leak into Lisp.
522 2012-02-07 Glenn Morris <rgm@gnu.org>
524 * image.c (Fimagemagick_types): Doc fix.
526 * image.c (imagemagick-render-type): Change it from a lisp object
527 to an integer. Move the doc here from the lisp manual.
528 Treat all values not equal to 0 the same.
530 2012-02-06 Chong Yidong <cyd@gnu.org>
532 * doc.c (store_function_docstring): Avoid applying docstring of
533 alias to base function (Bug#2603).
535 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
537 * .gdbinit (pp1, pv1): Remove redundant defines.
540 2012-02-04 Chong Yidong <cyd@gnu.org>
542 * nsterm.m: Declare a global (Bug#10694).
544 2012-02-04 Eli Zaretskii <eliz@gnu.org>
546 * w32.c (get_emacs_configuration_options):
547 Include --enable-checking, if specified, in the return value.
549 2012-02-04 Martin Rudalics <rudalics@gmx.at>
551 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
552 after rounding frame sizes. (Bug#9723)
554 2012-02-04 Eli Zaretskii <eliz@gnu.org>
556 * keyboard.c (adjust_point_for_property): Don't position point
557 before BEGV. (Bug#10696)
559 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
561 Handle overflow when computing char display width (Bug#9496).
562 * character.c (char_width): Return EMACS_INT, not int.
563 (char_width, c_string_width): Check for overflow when
564 computing the width; this is possible now that individual
565 characters can have unbounded width. Problem introduced
566 by merge from Emacs 23 on 2012-01-19.
568 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
570 * dbusbind.c (Fdbus_register_method): Mention the return value
571 :ignore in the docstring.
573 2012-02-02 Glenn Morris <rgm@gnu.org>
575 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
577 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
578 Unconditionally set to t. (Bug#10673)
579 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
580 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
581 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
583 2012-02-02 Kenichi Handa <handa@m17n.org>
585 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
586 0, do not call append_composite_glyph.
588 2012-02-02 Kenichi Handa <handa@m17n.org>
590 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
592 (x_produce_glyphs): If the component of a composition is a null
593 string, set it->pixel_width to 1 to avoid zero-width glyph.
595 2012-02-01 Eli Zaretskii <eliz@gnu.org>
597 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
598 first 2 arguments are identical. This makes inserting large
599 output from a subprocess an order of magnitude faster on
600 MS-Windows, where all sbrk'ed memory is always contiguous.
602 2012-01-31 Glenn Morris <rgm@gnu.org>
604 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
605 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
606 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
608 2012-01-29 Glenn Morris <rgm@gnu.org>
610 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
612 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
614 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
616 2012-01-28 Chong Yidong <cyd@gnu.org>
618 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
620 2012-01-26 Chong Yidong <cyd@gnu.org>
622 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
624 * search.c (Fsearch_forward, Fsearch_backward): Document negative
625 repeat counts (Bug#10507).
627 2012-01-26 Glenn Morris <rgm@gnu.org>
629 * lread.c (syms_of_lread): Doc fix.
631 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
633 * coding.c (encode_designation_at_bol): Change return value to
636 2012-01-25 Chong Yidong <cyd@gnu.org>
638 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
640 2012-01-21 Chong Yidong <cyd@gnu.org>
642 * floatfns.c (Fcopysign): Make the second argument non-optional,
643 since nil is not allowed anyway.
645 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
647 * process.c (read_process_output): Use p instead of XPROCESS (proc).
648 (send_process): Likewise.
650 2012-01-19 Martin Rudalics <rudalics@gmx.at>
652 * window.c (save_window_save, Fcurrent_window_configuration)
653 (Vwindow_persistent_parameters): Do not use Qstate.
656 2012-01-19 Kenichi Handa <handa@m17n.org>
658 * character.c (char_width): New function.
659 (Fchar_width, c_string_width, lisp_string_width):
660 Use char_width (Bug#9496).
662 2012-01-16 Martin Rudalics <rudalics@gmx.at>
664 * window.c (Vwindow_persistent_parameters): New variable.
665 (Fset_window_configuration, save_window_save): Handle persistent
668 2012-01-14 Eli Zaretskii <eliz@gnu.org>
670 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
671 thrashing the stack of the thread. (Bug#9087)
673 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
675 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
677 2012-01-11 Eli Zaretskii <eliz@gnu.org>
679 * xdisp.c (rows_from_pos_range): Handle the case where the
680 highlight ends on a newline. (Bug#10464)
681 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
682 he end column for display of highlight that ends on a newline
685 2012-01-11 Glenn Morris <rgm@gnu.org>
687 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
688 from load-path also when installation-directory is nil. (Bug#10208)
690 2012-01-10 Glenn Morris <rgm@gnu.org>
692 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
694 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
695 Update template values to be closer to their typical values these days.
697 2012-01-09 Eli Zaretskii <eliz@gnu.org>
699 * xdisp.c (rows_from_pos_range): Accept additional argument
700 DISP_STRING, and accept any glyph in a row whose object is that
701 string as eligible for mouse highlight. Fixes mouse highlight of
702 display strings from overlays. (Bug#10464)
704 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
706 emacs: fix an auto-save permissions race condition (Bug#10400)
707 * fileio.c (auto_saving_dir_umask): New static var.
708 (Fmake_directory_internal): Use it.
709 (do_auto_save_make_dir): Set it, instead of invoking chmod after
710 creating the directory. The old code temporarily assigns
711 too-generous permissions to the directory.
712 (do_auto_save_eh): Clear it.
713 (Fdo_auto_save): Catch all errors, not just file errors, so
714 that the var is always cleared.
716 2012-01-07 Eli Zaretskii <eliz@gnu.org>
718 * search.c (scan_buffer): Pass character positions to
719 know_region_cache, not byte positions. (Bug#6540)
721 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
723 * w32.c (sys_rename): Report EXDEV when rename of a directory
724 fails because the target is on another logical disk. (Bug#10284)
726 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
728 * xterm.c (x_embed_request_focus): New function.
730 * xterm.h: Add prototype.
732 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
734 2012-01-05 Glenn Morris <rgm@gnu.org>
736 * emacs.c (emacs_copyright): Update short copyright year to 2012.
738 2012-01-01 Eli Zaretskii <eliz@gnu.org>
740 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
741 Load gnutls_transport_set_lowat only if GnuTLS version is below
743 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
744 GnuTLS versions below 2.11.1.
746 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
748 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
749 to the doc string advising against its use for altering the way
750 windows are scrolled.
752 2011-12-28 Kenichi Handa <handa@m17n.org>
754 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
755 coding-system ASCII compatible only when it does not produce BOM
756 on encoding (Bug#10383).
758 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
760 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
762 (create_and_show_popup_menu): Always use menu_position_func for
765 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
767 * callint.c (Fcall_interactively): Don't truncate prompt string.
769 2011-12-23 Eli Zaretskii <eliz@gnu.org>
771 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
772 property that ends at ZV, so that the bidi iteration could be
773 resumed from there (after widening). (Bug#10360)
775 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
777 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
779 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
781 * nsterm.m (x_free_frame_resources):
782 Release f->output_data.ns->miniimage.
783 (ns_index_color): Fix indentation. Do not retain
784 color_table->colors[i].
786 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
789 * nsfns.m (x_set_background_color): Assign return value from
790 ns_index_color to face-background instead of NSColor*.
791 (ns_implicitly_set_icon_type): Fix indentation.
792 Change assignment in for loop to comparison.
794 * emacs.c (ns_pool): New variable.
795 (main): Assign ns_pool.
796 (Fkill_emacs): Call ns_release_autorelease_pool.
798 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
799 autorelease fdesc, release fdAttrs and tdict.
800 (ns_get_covering_families): Release charset.
801 (ns_findfonts): Release NSFontDescriptor created with new.
802 (ns_uni_to_glyphs): Fix indentation.
803 (setString): Release attrStr before assigning new value.
805 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
807 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
809 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
810 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
812 2011-12-18 David Reitter <reitter@cmu.edu>
814 * nsterm.m (ns_term_init): Subscribe for notifications
815 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
816 to method trackingNotification in EmacsMenu.
818 * nsmenu.m (trackingMenu): New variable.
819 (trackingNotification): New method (from Aquamacs).
820 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
821 from Aquamacs (Bug#7030).
823 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
825 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
826 (symbol_to_nsstring): Fix indentation.
827 (ns_symbol_to_pb): New function.
828 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
829 (Fns_rotate_cut_buffers_internal): Remove.
830 (Fns_store_selection_internal): Rename from
831 Fns_store_cut_buffer_internal.
832 (ns_get_foreign_selection, Fx_own_selection_internal)
833 (Fx_disown_selection_internal, Fx_selection_exists_p)
834 (Fns_get_selection_internal, Fns_store_selection_internal):
835 Use ns_symbol_to_pb and check if return value is nil.
836 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
837 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
838 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
839 renamed to Sns_store_selection_internal.
840 (ns_handle_selection_request): Move code to Fx_own_selection_internal
841 and remove this function.
842 (ns_handle_selection_clear): Remove, never used.
843 (Fx_own_selection_internal): Move code from ns_handle_selection_request
846 2011-12-17 Ken Brown <kbrown@cornell.edu>
848 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
849 GID is unknown (Bug#10257).
851 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
853 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
854 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
855 which caused a build failure on GNU/Linux IA-64. This problem was
856 introduced by my 2011-10-07 patch.
858 2011-12-15 Juri Linkov <juri@jurta.org>
860 * image.c (imagemagick_error): New function. (Bug#10112)
861 (imagemagick_load_image): Comment out `MagickSetResolution' call.
862 Use `imagemagick_error' where ImageMagick functions return
864 (Fimagemagick_types): Add `Fnreverse' to return the list in the
867 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
869 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
870 fill background (Bug#8992).
872 2011-12-13 Martin Rudalics <rudalics@gmx.at>
874 * window.c (Vwindow_combination_resize)
875 (Vwindow_combination_limit): Use t instead of non-nil in
877 (Vrecenter_redisplay): Add first sentence of doc-string on
879 (Frecenter): Fix doc-string typo.
881 2011-12-11 Kenichi Handa <handa@m17n.org>
883 * coding.c (Funencodable_char_position): Pay attention to the
884 buffer text relocation (Bug#9389).
886 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
888 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
889 gtk_init (Bug#10100).
891 2011-12-10 Eli Zaretskii <eliz@gnu.org>
893 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
894 IT->string is nil. (Bug#10263)
896 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
898 * nsterm.h (x_free_frame_resources): Declare.
900 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
901 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
903 * nsterm.h (ns_get_defaults_value): Declare.
905 * nsterm.m (ns_default): Call ns_get_defaults_value.
907 2011-12-09 Eli Zaretskii <eliz@gnu.org>
909 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
912 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
914 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
915 that where the value of an _OBJC_* symbol points to is in the .bss
918 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
920 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
921 after the loop to call ccl_driver at least once (Bug#8619).
923 2011-12-08 Kenichi Handa <handa@m17n.org>
925 * ftfont.c (get_adstyle_property): Fix previous change
928 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
930 * w32.c (init_environment): If no_site_lisp, remove site-lisp
931 dirs from the default value of EMACSLOADPATH (bug#10208).
933 2011-12-07 Glenn Morris <rgm@gnu.org>
935 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
936 installation and source directories as well. (Bug#10208)
938 2011-12-06 Chong Yidong <cyd@gnu.org>
940 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
942 2011-12-06 Glenn Morris <rgm@gnu.org>
944 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
945 as an error, not just -1. (Bug#10217)
947 2011-12-05 Chong Yidong <cyd@gnu.org>
949 * keyboard.c (process_special_events): New function.
950 (swallow_events, Finput_pending_p): Use it (Bug#10195).
952 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
954 * coding.c (encode_designation_at_bol): Don't use uninitialized
955 local variable (Bug#9318).
957 2011-12-05 Kenichi Handa <handa@m17n.org>
959 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
960 return Qnil (Bug#8046, Bug#10193).
962 2011-12-05 Kenichi Handa <handa@m17n.org>
964 * coding.c (encode_designation_at_bol): New args charbuf_end and
965 dst. Return the number of produced bytes. Callers changed.
966 (coding_set_source): Return how many bytes coding->source was
968 (coding_set_destination): Return how many bytes
969 coding->destination was relocated.
970 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
971 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
973 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
975 * coding.c (CODING_CHAR_CHARSET_P): New macro.
976 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
979 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
981 The following changes are to fix Bug#9318.
983 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
984 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
985 (encode_coding_iso_2022, encode_coding_sjis)
986 (encode_coding_big5, encode_coding_charset): Use the above macros.
988 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
990 * lisp.h (process_quit_flag): Fix external declaration.
992 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
994 Don't macro-inline non-performance-critical code.
995 * eval.c (process_quit_flag): New function.
996 * lisp.h (QUIT): Use it.
998 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1000 * nsfns.m (get_geometry_from_preferences): New function.
1001 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1003 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1005 * emacs.c (Qkill_emacs): Define.
1006 (syms_of_emacs): Initialize it.
1007 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1008 Qquit_flag to `kill-emacs' instead.
1009 (quit_throw_to_read_char): Add parameter `from_signal'.
1010 All callers changed. Call Fkill_emacs if requested and safe.
1011 * lisp.h (QUIT): Call Fkill_emacs if requested.
1013 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1015 * widget.c (update_wm_hints): Return if wmshell is null.
1016 (widget_update_wm_size_hints): New function.
1018 * widget.h (widget_update_wm_size_hints): Declare.
1020 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1021 widget_update_wm_size_hints (Bug#10104).
1023 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1026 before a newline, prepare the bidi iterator for consuming the
1027 newline, and keep the current paragraph direction. (Bug#10183)
1028 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1030 2011-12-02 Juri Linkov <juri@jurta.org>
1032 * search.c (Fword_search_regexp): New Lisp function created from
1033 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1034 (Fword_search_backward, Fword_search_forward)
1035 (Fword_search_backward_lax, Fword_search_forward_lax):
1036 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1037 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1039 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1041 * fileio.c (Finsert_file_contents): Move after-change-function call
1042 to before the "handled:" label, since all "goto handled" appear in
1043 cases where the *-change-functions have already been properly called
1046 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1048 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1049 waiting for input. (Bug#10169)
1051 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1053 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1054 verifies glyph row's hash code--we have just reallocated the
1055 glyphs, so their contents can be complete garbage. (Bug#10164)
1057 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1059 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1061 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1063 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1064 attributes are tested _before_ calling verify_row_hash, to protect
1065 against GCC re-ordering of the tests. (Bug#10164)
1067 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1069 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1071 * xterm.c (handle_one_xevent): Only set async_visible and friends
1072 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1073 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1074 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1076 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1078 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1079 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1080 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1081 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1082 All uses changed to use GCPRO1 etc.
1083 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1084 Revert to old implementation (i.e., before 2011-03-11).
1086 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1088 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1089 of scroll runs so as to avoid assigning disabled bogus rows and
1090 unnecessary graphics copy operations.
1092 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1094 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1095 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1096 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1097 (malloc, free, realloc, calloc): Redirect to e_* only when
1100 * lisp.h (GCTYPEBITS): Move before first use.
1101 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1102 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1103 this macro definition.
1105 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1108 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1110 * gtkutil.c (xg_create_frame_widgets):
1111 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1112 present with Gtk+ 2.0.
1114 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1116 * fileio.c (Finsert_file_contents): Undo previous change; see
1117 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1119 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1121 Rename locals to avoid shadowing.
1122 * fileio.c (Finsert_file_contents):
1123 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1124 * process.c (wait_reading_process_output):
1125 Rename inner 'proc' to 'p' to avoid shadowing.
1126 Indent for consistency with usual Emacs style.
1128 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1130 * xdisp.c (redisplay_window): If cursor row is not fully visible
1131 after recentering, and scroll-conservatively is set to a large
1132 number, scroll window by a few more lines to make the cursor fully
1133 visible and out of scroll-margin. (Bug#10105)
1134 (start_display): Don't move to the next line if the display should
1135 start at a newline that is part of a display vector or an overlay
1138 2011-11-24 Juri Linkov <juri@jurta.org>
1140 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1141 after the `MagickPingImage' call. (Bug#10112)
1143 2011-11-23 Chong Yidong <cyd@gnu.org>
1145 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1147 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1149 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1150 making another buffer current. (Bug#10114)
1152 2011-11-23 Glenn Morris <rgm@gnu.org>
1154 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1156 2011-11-23 Chong Yidong <cyd@gnu.org>
1158 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1159 using it (Bug#5984).
1161 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1163 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1164 and header-lines, as they don't have one computed for them.
1167 * .gdbinit (prow): Make displayed values more self-explaining.
1168 Add row's hash code.
1170 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1172 * process.c (wait_reading_process_output): Fix asynchrounous
1173 GnuTLS socket handling on some versions of the GnuTLS library.
1174 (wait_reading_process_output): Add comment and URL.
1176 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1178 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1180 2011-11-21 Chong Yidong <cyd@gnu.org>
1182 * window.c (Fnext_window, Fprevious_window): Doc fix.
1184 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1186 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1188 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1190 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1192 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1194 * window.c (Fset_window_combination_limit): Rename argument
1196 (Vwindow_combination_limit): Remove "status" from doc-string.
1198 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1200 * m/ibms390.h: Remove.
1201 * m/ibms390x.h: Don't include "ibms390.h".
1203 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1205 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1206 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1208 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1210 * casetab.c (Fset_case_table):
1211 * charset.c (Fcharset_after): Fix typos.
1213 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1215 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1216 Otherwise, valgrind does not work on some platforms.
1217 Problem reported by Andreas Schwab in
1218 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1219 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1220 is set, removing the need for VIRT_ADDRESS_VARIES.
1221 (PURE_P): Use a more-efficient implementation that needs just one
1222 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1223 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1224 to 4 (xorl, subq, cmpq, setbe).
1225 * alloc.c (pure): Always extern now, since that's the
1226 VIRT_ADDR_VARIES behavior.
1227 (PURE_POINTER_P): Use a single comparison, not two, for
1228 consistency with the new puresize.h.
1229 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1230 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1231 Remove VIRT_ADDR_VARIES no longer needed.
1233 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1236 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1237 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1238 behave as if the cursor position were at the window margin.
1240 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1241 and the cursor position is out of bounds, behave as if the cursor
1242 position were at the window margin. (Bug#10075)
1244 2011-11-18 Chong Yidong <cyd@gnu.org>
1246 * window.c (Fwindow_combination_limit): Make first argument
1247 non-optional, since it is meaningless for live windows like the
1250 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1252 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1254 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1256 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1257 (graft_intervals_into_buffer): Simplify.
1259 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1261 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1262 hash values of the two rows.
1263 (copy_row_except_pointers): Preserve the used[] arrays and the
1264 hash values of the two rows. (Bug#10035)
1265 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1267 * xdisp.c (row_hash): New function, body extracted from
1268 compute_line_metrics.
1269 (compute_line_metrics): Call row_hash, instead of computing the
1272 * dispnew.c (verify_row_hash): Call row_hash for computing the
1273 hash code of a row, instead of duplicating code from xdisp.c.
1275 * dispextern.h (row_hash): Add prototype.
1277 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1279 * frame.c (delete_frame): Don't delete the terminal when the last
1280 X frame is closed if emacs is built with GTK toolkit.
1282 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1284 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1286 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1288 * window.c (Vwindow_splits): Rename to
1289 Vwindow_combination_resize. Suggested by Juri Linkov.
1290 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1293 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1295 * nsfns.m (Fns_font_name):
1296 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1298 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1300 * window.h (window): Rename slot "nest" to "combination_limit".
1301 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1302 (Fset_window_nest): Rename to Fset_window_combination_limit.
1303 (Vwindow_nest): Rename to Vwindow_combination_limit.
1304 (recombine_windows, make_parent_window, make_window)
1305 (Fsplit_window_internal, saved_window)
1306 (Fset_window_configuration, save_window_save): Rename all
1307 occurrences of window_nest to window_combination_limit.
1309 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1311 * image.c (imagemagick_load_image): Fix typo.
1313 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1315 * xdisp.c (display_line): Move the call to
1316 highlight_trailing_whitespace before the call to
1317 compute_line_metrics, since the latter needs to see the final
1318 faces of all the glyphs to compute ROW's hash value.
1319 Fixes assertion violations in row_equal_p. (Bug#10035)
1321 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1323 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1324 just return (bug#10044).
1326 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1328 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1329 with user-defined heap size. Bump the default size of the temacs
1330 heap to 27MB, to avoid memory warning when running temacs.
1331 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1333 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1334 current_matrix and desired_matrix. (Bug#9990)
1335 (verify_row_hash) [XASSERTS]: New function.
1336 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1337 that the hash value of glyph rows is correct.
1339 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1341 * window.h (window): Remove splits slot.
1342 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1343 (Fdelete_other_windows_internal, make_parent_window)
1344 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1345 (Fset_window_configuration, save_window_save): Don't deal with
1346 split status of windows.
1347 (saved_window): Remove splits slot.
1348 (Vwindow_splits): Rewrite doc-string.
1350 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1352 * xfns.c (unwind_create_frame):
1353 * nsfns.m (unwind_create_frame):
1354 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1355 Vframe_list (Bug#9999).
1357 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1359 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1361 2011-11-11 Kenichi Handa <handa@m17n.org>
1363 * callproc.c (Fcall_process): Set the member dst_multibyte of
1366 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1368 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1369 avoid a crash (bug#9496).
1371 2011-11-09 Chong Yidong <cyd@gnu.org>
1373 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1374 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1376 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1378 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1380 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1382 Avoid some portability problems by eschewing 'extern inline' functions.
1383 The trivial performance wins aren't worth the portability hassles; see
1384 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1386 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1387 (window_box_width, window_box_left, window_box_left_offset)
1388 (window_box_right, window_box_right_offset): Undo previous change,
1389 by removing the "extern"s.
1390 * intervals.c (adjust_intervals_for_insertion)
1391 (adjust_intervals_for_deletion): Undo previous change,
1392 making these static again.
1393 (offset_intervals, temp_set_point_both, temp_set_point)
1394 (copy_intervals_to_string): No longer inline.
1395 * xdisp.c (window_text_bottom_y, window_box_width)
1396 (window_box_height, window_box_left_offset)
1397 (window_box_right_offset, window_box_left, window_box_right)
1398 (window_box): No longer inline.
1400 2011-11-08 Chong Yidong <cyd@gnu.org>
1402 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1403 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1404 Signal an error if not a live window.
1405 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1406 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1408 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1410 * lisp.h (syms_of_abbrev): Remove declaration.
1411 Reported by CHENG Gao <chenggao@royau.me>.
1413 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1415 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1416 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1417 of temacs in GUI mode.
1419 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1421 * window.h: Declare delete_all_child_windows instead of
1422 delete_all_subwindows.
1423 * window.c (Fwindow_nest, Fset_window_nest)
1424 (Fset_window_new_total, Fset_window_new_normal)
1425 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1426 (delete_all_subwindows): Rename to delete_all_child_windows.
1427 (Fdelete_other_windows_internal, Fset_window_configuration):
1428 Call delete_all_child_windows instead of delete_all_subwindows.
1429 * frame.c (delete_frame): Call delete_all_child_windows instead
1430 of delete_all_subwindows.
1432 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1434 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1435 This is also needed for porting to any host where GC_MARK_STACK is
1436 not GC_MAKE_GCPROS_NOOPS.
1437 (which_symbols): Use it.
1439 2011-11-07 Kenichi Handa <handa@m17n.org>
1441 * coding.c (coding_set_destination): Check coding->src_pos only
1442 when coding->src_object is a buffer (bug#9910).
1444 * process.c (send_process): Set the member src_multibyte of coding
1445 to 0 (bug#9911) when sending a unibyte text.
1447 * callproc.c (Fcall_process): Set the member src_multibyte of
1448 process_coding to 0 (bug#9912).
1450 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1452 * xmenu.c (cleanup_widget_value_tree): New function.
1453 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1454 calling free_menubar_widget_value_tree directly (Bug#9830).
1456 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1458 Fix some portability problems with 'inline'.
1459 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1460 (window_box_width, window_box_left, window_box_left_offset)
1461 (window_box_right, window_box_right_offset): Declare extern.
1462 Otherwise, these inline functions do not conform to C99 and
1463 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1464 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1465 * intervals.c (adjust_intervals_for_insertion)
1466 (adjust_intervals_for_deletion): Now extern, because otherwise the
1467 extern inline functions 'offset_intervals' couldn't refer to it.
1468 (static_offset_intervals): Remove.
1469 (offset_intervals): Rewrite using the old contents of
1470 static_offset_intervals. The old version didn't conform to C99
1471 because an extern inline function contained a reference to an
1472 identifier with static linkage.
1474 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1476 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1479 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1481 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1482 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1483 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1484 return Qleft_to_right.
1486 2011-11-06 Chong Yidong <cyd@gnu.org>
1488 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1489 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1490 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1491 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1492 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1493 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1494 (Fwindow_vscroll): Doc fix.
1495 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1496 argument, since it makes no sense to pass a live window and for
1497 consistency with window-child.
1499 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1501 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1504 2011-11-05 Jason Rumney <jasonr@gnu.org>
1506 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1507 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1509 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1510 bitwise arithmetic preventing use of unicode-sip and non-truetype
1513 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1515 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1518 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1519 initialization code to keep similarity to xfns.c after changes
1522 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1524 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1525 (unwind_create_frame): New function (Bug#9943).
1526 (Fx_create_frame): Restructure code to be more similar to the one in
1527 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1528 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1529 Move terminal->reference_count++ just before making the frame official
1532 * nsterm.m (x_free_frame_resources): New function.
1533 (x_destroy_window): Move code to x_free_frame_resources.
1535 * xfns.c (unwind_create_frame): Fix comment.
1536 (Fx_create_frame, x_create_tip_frame):
1537 Move terminal->reference_count++ just before making the frame
1538 official. Move initialization of image_cache_refcount and
1539 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1541 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1543 Support MSVC build with newer versions of Visual Studio.
1544 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1545 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1548 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1549 which are not supported by MSVC.
1550 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1551 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1553 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1555 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1557 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1559 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1561 Support MSVC build with newer versions of Visual Studio.
1562 * w32.c: Don't include w32api.h for MSVC.
1563 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1565 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1566 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1567 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1568 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1570 (alloca) [_MSC_VER]: Define to _alloca.
1572 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1574 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1576 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1578 * xdisp.c (note_mouse_highlight): If either of
1579 previous/next-single-property-change returns nil, treat that as
1580 the beginning or the end of the buffer. (Bug#9955)
1582 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1584 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1585 label is not null (Bug#9951).
1586 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1589 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1591 * window.c (Fwindow_body_size): Mention in the doc string that the
1592 return value is in frame's canonical units. (Bug#9949)
1594 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1596 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1598 * w32fns.c (unwind_create_frame): If needed, free the glyph
1599 matrices of the partially constructed frame. (Bug#9943)
1600 * xfns.c (unwind_create_frame): Likewise.
1602 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1604 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1605 Don't stop backward scan on the continuation glyph, even though
1606 its CHARPOS is positive.
1607 (mouse_face_from_buffer_pos, note_mouse_highlight):
1608 Rename cover_string to disp_string.
1610 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1612 * window.c (temp_output_buffer_show): Don't use
1613 Vtemp_buffer_show_specifiers.
1614 (Vtemp_buffer_show_specifiers): Remove unused variable.
1616 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1619 past the beginning of the current glyph matrix.
1621 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1623 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1624 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1625 HAVE_GTK3 (Bug#9869).
1627 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1628 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1630 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1632 * xterm.c: Declare x_handle_net_wm_state to return int.
1633 (handle_one_xevent): Check if we are iconified but don't have
1634 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1635 (get_current_wm_state): Return non-zero if not hidden,
1636 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1637 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1638 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1639 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1641 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1643 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1644 so that this new function doesn't get optimized away by a
1645 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1647 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1649 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1651 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1653 Fix the `xbytecode' command.
1654 * .gdbinit (xprintbytestr): New command.
1655 (xwhichsymbols): Rename from `which'; all callers changed.
1656 (xbytecode): Print the byte-code string as well.
1658 2011-10-29 Kim Storm <storm@cua.dk>
1660 * alloc.c (which_symbols): New function.
1662 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1664 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1667 2011-10-29 Glenn Morris <rgm@gnu.org>
1669 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1670 Not clear what it was for, and it causes various bugs. (Bug#9839)
1672 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1675 possible random value that matches one of those tested as
1676 condition to clear the mouse face.
1678 2011-10-28 Chong Yidong <cyd@gnu.org>
1680 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1682 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1684 * window.c (make_window): Initialize phys_cursor_on_p.
1686 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1688 * lisp.h (struct Lisp_Symbol): Update comments.
1690 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1692 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1694 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1696 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1697 <oslsachem@gmail.com> for helping to debug this.
1699 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1700 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1701 (g_b_init_get_glyph_outline_w): New static variables.
1702 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1703 (GetGlyphOutlineW_Proc): New typedefs.
1704 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1705 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1707 (w32font_open_internal, compute_metrics):
1708 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1709 instead of calling the "wide" APIs directly.
1711 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1713 * w32.h (syms_of_w32font): Add prototype.
1715 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1717 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1718 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1719 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1720 (Fmove_to_window_line): Doc fix.
1722 2011-10-27 Chong Yidong <cyd@gnu.org>
1724 * process.c (make_process): Set gnutls_state to NULL.
1726 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1727 non-NULL, regardless of GNUTLS_INITSTAGE.
1728 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1729 an error. Set process slots as soon as we allocate them.
1731 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1733 2011-10-27 Chong Yidong <cyd@gnu.org>
1735 * gnutls.c (emacs_gnutls_deinit): New function.
1736 Deallocate credentials structures as well as calling gnutls_deinit.
1737 (Fgnutls_deinit, Fgnutls_boot): Use it.
1739 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1740 (deactivate_process): Call emacs_gnutls_deinit.
1742 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1744 * image.c (x_create_x_image_and_pixmap):
1745 * w32.c (sys_rename, w32_delayed_load):
1746 * w32font.c (fill_in_logfont):
1747 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1749 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1751 * w32fns.c (w32_default_color_map): New function,
1752 extracted from Fw32_default_color_map.
1753 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1755 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1757 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1759 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1761 * keyboard.c (test_undefined): New function (bug#9751).
1762 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1764 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1766 * sysdep.c (init_sys_modes): Fix the check for the controlling
1767 terminal (Bug#6649).
1769 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1771 * dispextern.h (struct bidi_it): New member next_en_type.
1773 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1774 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1775 current character, check also for next_en_type being WEAK_EN.
1776 (bidi_resolve_weak): Don't enter the expensive loop if the current
1777 position is before next_en_pos. Record the bidi type of the first
1778 non-ET, non-BN character we find, in addition to its position.
1779 (bidi_level_of_next_char): Invalidate next_en_type when
1780 next_en_pos is over-stepped.
1782 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1784 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1785 * editfns.c: Rewrite current-time-zone so that it invokes
1786 the equivalent of (format-time-string "%Z") to get the time zone name.
1787 This fixes a bug when the time zone name contains characters that
1788 need converting from the system time locale to Emacs internal format.
1789 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1790 that patch fixed format-time-string to do the conversion, but
1791 I forgot to fix current-time-zone.
1792 (format_time_string): New function, containing most of
1793 what Fformat_time_string used to contain.
1794 (Fformat_time_string): Rewrite in terms of format_time_string.
1795 This doesn't change this function's behavior.
1796 (current-time-zone): Rewrite to use format_time_string.
1797 This fixes the bug reported by Michael Schierl in
1798 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1799 Jason Rumney's 2007-06-07 change worked around this bug, but
1801 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1803 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (start_display): If the character at POS is displayed
1806 via a display vector, reset IT->current.dpvec_index to zero.
1807 (try_window_reusing_current_matrix): If a line ends in a display
1808 vector or the next line starts in a display vector, continue
1809 redrawing the window even though the character position of
1810 start_row was reached.
1813 2011-10-18 Chong Yidong <cyd@gnu.org>
1815 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1816 with nobreak-char-display too.
1818 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1820 Fix part 3 of bug#9771.
1821 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1822 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1823 non-neutral characters if the current character is a paragraph
1824 separator (a.k.a. Newline). This avoids running the same
1825 expensive loop twice, once when we consume the preceding newline
1826 and the other time when the line actually needs to be displayed.
1827 Avoid the loop when we see neutrals on the base embedding level
1828 following a character whose directionality is the same as the
1829 paragraph's. This avoids running the expensive loop when a line
1830 ends in a long sequence of neutrals, like control characters.
1831 Add assertion against STRONG_AL type. Slightly rearrange code
1832 that determines the type of a neutral given the first non-neutral
1834 (bidi_level_of_next_char): Set next_en_pos to zero when
1835 invalidating its info.
1837 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1839 * xdisp.c (push_display_prop): Determine whether to record string
1840 or buffer position by IT->string, not by IT->method. Allow
1841 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1842 (move_it_vertically_backward): Don't look for character position
1843 immediately after the newline when in a continuation line.
1846 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1848 * window.c (coordinates_in_window): Rewrite and delabelize
1849 vertical border check. (Bug#5357) (Bug#9618)
1851 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1853 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1854 errors in XSetWindowBorder (bug#9310).
1856 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1858 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1859 avoid crash when xmalloc overrun checking is enabled.
1861 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1863 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1864 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1865 cursor motion with <left> and <right> arrow keys.
1867 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1868 some callers set that themselves.
1870 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1873 display string and the previous row comes from the same string and
1874 is empty. (Bug#9739) (Bug#9738)
1876 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1878 * doc.c (get_doc_string): Encode file name (bug#9735).
1880 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1882 * bidi.c (bidi_level_of_next_char):
1883 * xdisp.c (get_visually_first_element): Remove old incorrect
1884 comments regarding the Unicode Line Separator character.
1886 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1888 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1890 * alloc.c (Fgc_status): Do not access beyond zombies array
1891 boundary if nzombies > MAX_ZOMBIES.
1892 * alloc.c (dump_zombies): Add missing format specifier.
1894 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1896 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1897 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1899 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1900 Some packages use them to denote characters with modifiers.
1902 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1904 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1905 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1906 matching a pp-number. Rename parameter var to var1.
1908 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1910 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1912 2011-10-08 Glenn Morris <rgm@gnu.org>
1914 * callint.c (Fcall_interactively): Give a more explicit error for the
1915 'c' case with a non-character input. (Bug#8479)
1917 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1919 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1921 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1922 lines that are hscrolled on the left.
1924 * dispnew.c (buffer_posn_from_coords): Account for a possible
1925 presence of header-line. (Bug#4426)
1927 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1929 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1930 Don't advertise functionality which we discourage or doesn't work.
1932 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1934 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1935 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1936 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1937 this makes Emacs dump core during garbage collection on rare
1938 occasions. sizeof is obviously inferior to offsetof here, so
1939 stick with offsetof.
1940 (GC_POINTER_ALIGNMENT): New macro.
1941 (mark_memory): Omit 3rd (offset) arg; caller changed.
1942 Don't assume EMACS_INT alignment is the same as pointer alignment.
1944 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1946 * keyboard.c (read_key_sequence_remapped): New var.
1947 (read_key_sequence): Compute remapping in the right buffer.
1948 (command_loop_1): Use read_key_sequence's remapping directly.
1950 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1952 * dired.c (file_name_completion): Don't expand file name.
1953 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1954 before checking file name handler.
1956 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1957 they've been requested explicitly (bug#9591).
1959 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1961 * keymap.c (Fsingle_key_description): Use make_specified_string
1962 instead of build_string to build string from push_key_description.
1965 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1967 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1968 This fixes a Y2038 bug on 64-bit hosts.
1969 * buffer.c (reset_buffer):
1970 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1971 (Fclear_buffer_auto_save_failure):
1972 Use 0, not -1, to represent an unset failure time, since time_t
1973 might not be signed.
1975 Remove dependency on glibc malloc internals.
1976 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1977 Move back here from lisp.h, but with their new implementations.
1978 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1979 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1980 * charset.c (charset_table_init): New static var.
1981 (syms_of_charset): Use it instead of xmalloc. This removes a
1982 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1983 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1984 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1985 Move back to alloc.c.
1986 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1987 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1989 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1991 * nsterm.m (windowDidResize): Call x_set_window_size only when
1992 ns_in_resize is true. Otherwise set pixelwidth/height and
1993 call change_frame_size (Bug#9628).
1995 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1997 Port --enable-checking=all to Fedora 14 x86-64.
1998 * charset.c (syms_of_charset): Also account for glibc malloc's
1999 internal overhead when calculating the initial malloc maximum.
2001 Port --enable-checking=all to Fedora 14 x86.
2002 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2004 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2005 (overrun_check_realloc, overrun_check_free):
2006 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2007 That way, xmalloc returns a properly-aligned pointer even if
2008 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2009 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2010 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2011 into account when calculating the initial malloc maximum.
2012 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2013 Move here from alloc.c, so that charset.c can use it too.
2014 Properly align; the old code wasn't right for common 32-bit hosts
2015 when configured with --enable-checking=all.
2016 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2017 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2019 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2021 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2024 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (compute_display_string_end): If there's no display
2027 string at CHARPOS, return -1.
2029 * bidi.c (bidi_fetch_char): When compute_display_string_end
2030 returns a negative value, treat the character as a normal
2031 character not covered by a display string. (Bug#9624)
2033 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2035 * lread.c (Fread_from_string): Fix typo in docstring.
2037 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2039 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2040 newline, reseat the iterator instead of bidi-iterating there one
2041 character at a time. (Bug#9610)
2042 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2043 TO_CHARPOS if the bidi iterator is at base embedding level.
2045 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2047 * lread.c (readevalloop): Use correct code for NBSP.
2048 (read1): Likewise. (Bug#9608)
2050 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2052 * dbusbind.c (Fdbus_register_signal): When service is not
2053 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2055 2011-09-25 Glenn Morris <rgm@gnu.org>
2057 * buffer.c (truncate-lines): Doc fix.
2059 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2061 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2062 (Fset_window_next_buffers): Doc fix.
2064 2011-09-24 Glenn Morris <rgm@gnu.org>
2066 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2068 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2070 Fix minor problems found by static checking.
2071 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2072 * indent.c (Fvertical_motion): Fix == vs = typo.
2074 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2076 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2077 Default value is now t. Doc fix.
2079 * indent.c (Fvertical_motion): Compute and apply the overshoot
2080 logic when moving up, not only when moving down. Fix the
2081 confusing name and values of the it_overshoot_expected variable;
2082 logic changes accordingly. (Bug#9254) (Bug#9549)
2084 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2085 CHARPOS is covered by a display string which includes newlines.
2086 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2087 is covered by a display string with embedded newlines.
2089 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2091 * dbusbind.c (Fdbus_register_signal): Add match rule to
2092 Vdbus_registered_objects_table. (Bug#9581)
2093 (Fdbus_register_method, Vdbus_registered_objects_table):
2096 2011-09-24 Jim Meyering <meyering@redhat.com>
2098 do not ignore write error for any output size
2099 The previous change was incomplete.
2100 While it makes emacs --batch detect the vast majority of stdout
2101 write failures, errors were still ignored whenever the output size is
2102 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2103 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2104 && echo FAIL: ignored write error
2105 FAIL: ignored write error
2106 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2107 && echo FAIL: ignored write error
2108 FAIL: ignored write error
2109 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2111 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2113 * emacs.c (Fkill_emacs): In noninteractive mode exit
2114 non-successfully if a write error occurred on stdout. (Bug#9574)
2116 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2118 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2121 * dispextern.h (struct it): Update the comment documenting what
2124 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2126 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2127 a display string, extend search for cursor position to end of row.
2128 (find_row_edges): If the row ends in a newline from a display
2129 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2130 Handle the case of a display string with multiple newlines.
2131 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2132 non-empty line. Fixes confusing cursor motion with arrow keys at
2133 the beginning of a line that starts with whitespace.
2135 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2137 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2140 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2142 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2145 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2147 * xdisp.c (display_line): Record maximum and minimum buffer
2148 positions even if no glyphs were produced (e.g., by a zero-width
2149 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2150 buffer positions that will be removed from the glyph row because
2152 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2153 column is beyond frame width: don't subtract 1 "pixel" when
2154 computing width of the stretch.
2155 (reseat_at_next_visible_line_start): Undo the change made on
2156 2011-09-17 that saved paragraph information and restored it after
2157 the call to `reseat'. (Bug#9545)
2159 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2161 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2162 and turn window cursor on if cleared (Bug#9415).
2164 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2166 * search.c (boyer_moore): Take unibyte characters from pattern
2167 literally. (Bug#9458)
2169 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2171 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2173 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2175 Fix minor problem found by static checking.
2176 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2177 initialized, to pacify gcc -Wuninitialized.
2179 * fileio.c: Report proper errno when syscall falls.
2180 (Finsert_file_contents): Save and restore errno,
2181 so that report_file_error outputs the correct diagnostic.
2182 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2184 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2186 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2188 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2190 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2191 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2193 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2195 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2196 about the current paragraph and restore it after the call to reseat.
2198 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2199 (bidi_find_paragraph_start): Search back for paragraph beginning
2200 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2201 (bidi_move_to_visually_next): Only trigger paragraph-related
2202 computations when the last character is a newline or at EOB, not
2203 just any NEUTRAL_B. (Bug#9470)
2205 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2206 truncated lines if point is covered by a display string. (Bug#9524)
2208 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2210 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2211 (cons_to_x_long): New function.
2212 (lisp_data_to_selection_data): Use it. Correct the test for
2213 short-versus-long data; it was negated. Break out of vector
2214 loop, for efficiency, when a long datum is discovered.
2216 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2218 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2220 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2222 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2223 GCC PR/17406) by declaring this function with external scope.
2225 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2227 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2228 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2230 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2232 * editfns.c (Fformat): Correctly handle text properties on "%%".
2234 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2236 * xterm.c (x_draw_composite_glyph_string_foreground):
2237 * w32term.c (x_draw_composite_glyph_string_foreground):
2238 * term.c (encode_terminal_code):
2239 * composite.c (composition_update_it, get_composition_id):
2240 * xdisp.c (get_next_display_element)
2241 (fill_composite_glyph_string): Add comments about special meaning
2242 of TAB characters in a composition.
2244 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2246 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2247 This occurs when processing a multibyte format.
2248 Problem reported by Wolfgang Jenker.
2250 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2252 * xdisp.c (try_cursor_movement): Only check for exact match if
2253 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2255 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2257 Remove unused external symbols.
2258 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2259 * xdisp.c (calc_pixel_width_or_height): Now static.
2260 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2261 * indent.c (check_display_width):
2262 * w32term.c: Fix comment to match code.
2263 * xterm.c, xterm.h (x_catching_errors): Remove.
2265 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2267 * xselect.c: Use signed conversions more consistently (Bug#9498).
2268 (selection_data_to_lisp_data): Assume incoming selection data are
2269 signed integers, not unsigned. This is to be consistent with
2270 outgoing selection data, which was modified to use signed integers
2271 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2272 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2273 expects long, not unsigned long.
2275 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2277 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2278 computation of loop end. Reported by Johan Bockgård
2281 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2283 * frame.c (Fother_visible_frames_p): Function deleted.
2285 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2287 * indent.c (compute_motion): Process display vector front to back
2288 rather than the other way around. (Bug#2496)
2290 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2292 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2294 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2296 * minibuf.c (Fread_from_minibuffer): Doc fix.
2298 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2300 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2301 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2303 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2305 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2306 value for non-existent files.
2308 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2310 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2311 set its "size" to -1. This will set the modtime_size field of
2312 the corresponding buffer to -1, which is what
2313 verify-visited-file-modtime expects for files that do not exist.
2316 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2318 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2320 * lisp.h: ... from here. push_key_description is no longer
2321 defined in keyboard.c, so its declaration should not be in
2322 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2323 logically belongs with push_key_description.
2325 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2327 * buffer.h: Include <sys/types.h> instead of <time.h>.
2328 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2329 Problem reported by Herbert J. Skuhra.
2331 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2333 * xml.c (parse_region): Make the parsing work for
2334 non-comment-starting XML files again (bug#9144).
2336 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2338 * image.c (gif_load): Fix calculation of bottom and right corner.
2341 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2343 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2344 redisplay in small windows.
2346 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2348 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2350 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2352 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2353 Operate on live windows only.
2355 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2357 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2359 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2361 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2362 only under bidi iteration.
2364 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2366 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2368 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2370 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2371 Without this fix, the command to link temacs failed due to an
2372 undefined symbol __builtin_isnan. This is because
2373 /usr/include/iso/math_c99.h #defines isnan(x) to
2374 __builtin_isnan(x), but the bundled gcc, which identifies itself
2375 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2377 * floatfns.c (isnan): #undef, and then #define to a clone of
2379 (Fisnan): Always define, since it's always available now.
2380 (syms_of_floatfns): Always define isnan at the Lisp level.
2382 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2384 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2386 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2388 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2389 The previous code assumed that file offsets (off_t values) fit in
2390 EMACS_INT variables, which is not true on typical 32-bit hosts.
2391 The code messed up by falsely reporting buffer overflow in cases
2392 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2393 when "big" contains more than 2**29 bytes, even though this
2394 inserts just one byte and does not overflow the buffer.
2395 (Finsert_file_contents): Store file offsets as off_t
2396 values, not as EMACS_INT values. Check for overflow when
2397 converting between EMACS_INT and off_t. When checking for
2398 buffer overflow or for overlap, take the offsets into account.
2399 Don't use EMACS_INT for small values where int suffices.
2400 When checking for overlap, fix a typo: ZV was used where
2401 ZV_BYTE was intended.
2402 (Fwrite_region): Don't assume off_t fits into 'long'.
2403 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2405 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2407 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2409 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2411 sprintf-related integer and memory overflow issues (Bug#9412).
2413 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2414 (esprintf, exprintf, evxprintf): New functions.
2415 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2416 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2417 (modify_event_symbol): Do not assume that the length of
2418 name_alist_or_stem is safe to alloca and fits in int.
2419 (Fexecute_extended_command): Likewise for function name and binding.
2420 (Frecursion_depth): Wrap around reliably on integer overflow.
2421 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2422 since some callers pass EMACS_INT values.
2423 (Fsingle_key_description): Don't crash if symbol name contains more
2424 than MAX_ALLOCA bytes.
2425 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2426 (get_minibuffer): Arg is now EMACS_INT, not int.
2427 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2428 (esprintf, exprintf, evxprintf): New decls.
2429 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2431 * dbusbind.c (signature_cat): New function.
2432 (xd_signature, Fdbus_register_signal):
2433 Do not overrun buffer; instead, report string overflow.
2435 * dispnew.c (add_window_display_history): Don't overrun buffer.
2436 Truncate instead; this is OK since it's just a log.
2438 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2439 even if the time zone offset is outlandishly large.
2440 Don't mishandle offset == INT_MIN.
2442 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2443 when creating daemon; the previous buffer-overflow check was incorrect.
2445 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2446 which has the guts of the old verror function.
2448 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2449 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2451 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2452 (font_unparse_xlfd): Don't blindly alloca long strings.
2453 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2454 fits in int, when using sprintf. Use single snprintf to count
2455 length of string rather than counting it via multiple sprintfs;
2456 that's simpler and more reliable.
2457 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2458 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2459 sprintf, in case result does not fit in int.
2461 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2462 (fontset_from_font): Print it.
2464 * frame.c (tty_frame_count): Now printmax_t, not int.
2465 (make_terminal_frame, set_term_frame_name): Print it.
2466 (x_report_frame_params): In X, window IDs are unsigned long,
2467 not signed long, so print them as unsigned.
2468 (validate_x_resource_name): Check for implausibly long names,
2469 and don't assume name length fits in 'int'.
2470 (x_get_resource_string): Don't blindly alloca invocation name;
2471 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2474 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2475 (xg_check_special_colors, xg_set_geometry):
2476 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2478 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2479 Use esprintf, not sprintf, in case result does not fit in int.
2481 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2482 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2483 it as a large positive number.
2484 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2485 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2487 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2488 in case result does not fit in int.
2490 * print.c (float_to_string): Detect width overflow more reliably.
2491 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2492 buffer overrun. Don't assume list length fits in 'int'. Treat
2493 print length of 0 as 0, not as infinity; to be consistent with other
2494 uses of print length in this function. Don't overflow print length
2495 index. Don't assume hash table size fits in 'long', or that
2496 vectorlike size fits in 'unsigned long'.
2498 * process.c (make_process): Use printmax_t, not int, to format
2499 process-name gensyms.
2501 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2503 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2504 to avoid potential buffer overrun.
2506 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2507 if X resource line is longer than 512 bytes.
2509 * xfns.c (x_window): Make sprintf buffer a bit bigger
2510 to avoid potential buffer overrun.
2512 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2514 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2516 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2518 Integer overflow fixes for scrolling, etc.
2519 Without these, Emacs silently mishandles large integers sometimes.
2520 For example, "C-u 4294967297 M-x recenter" was treated as if
2521 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2523 * xdisp.c (try_window_id): Check Emacs fixnum range before
2524 converting to 'int'.
2526 * window.c (window_scroll_line_based, Frecenter):
2527 Check that an Emacs fixnum is in range before assigning it to 'int'.
2528 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2529 values converted from Emacs fixnums.
2530 (Frecenter): Don't wrap around a line count if it is out of 'int'
2531 range; instead, treat it as an extreme value.
2532 (Fset_window_configuration, compare_window_configurations):
2533 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2535 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2536 that can exceed INT_MAX. Check that EMACS_INT value is in range
2537 before assigning it to the (possibly-narrower) index.
2538 (match_limit): Don't assume that a fixnum can fit in 'int'.
2540 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2543 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2544 (Fvertical_motion): Don't wrap around LINES values that don't fit
2545 in 'int'. Instead, treat them as extreme values. This is good
2546 enough for windows, which can't have more than INT_MAX lines anyway.
2548 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2550 * Require libxml/parser.h to avoid compilation warning.
2552 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2554 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2555 since this reportedly can destroy thread storage.
2557 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2559 * syntax.c (find_defun_start): Update all cache variables if
2560 exiting early (Bug#9401).
2562 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2564 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2566 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2567 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2568 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2570 * term.c (tty_append_glyph): New function.
2571 (produce_stretch_glyph): Static function and its prototype deleted.
2573 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2576 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2578 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2579 when checking :margin (Bug#9390).
2580 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2581 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2582 so that the name doesn't mislead. All uses changed.
2584 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2586 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2589 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2591 * xdisp.c (move_it_to): Don't bail out early when reaching
2592 position beyond to_charpos, if we are scanning backwards.
2593 (move_it_vertically_backward): When DY == 0, make sure we get to
2594 the first character in the line after the newline.
2596 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2598 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2599 (ccl_driver): Do not generate an out-of-range pointer.
2600 (Fccl_execute_on_string): Remove unnecessary check for
2601 integer overflow, noted by Stefan Monnier in
2602 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2603 Remove a FIXME that didn't need fixing.
2604 Simplify the newly-introduced buffer reallocation code.
2606 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2608 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2610 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2612 Integer and memory overflow issues (Bug#9196).
2614 * doc.c (get_doc_string): Rework so that
2615 get_doc_string_buffer_size is the actual buffer size, rather than
2616 being 1 less than the actual buffer size; this makes xpalloc more
2619 * image.c (x_allocate_bitmap_record, cache_image):
2620 * xselect.c (Fx_register_dnd_atom):
2621 Simplify previous changes by using xpalloc.
2623 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2624 since either will do and ptrdiff_t is convenient with xpalloc.
2626 * charset.c (charset_table_size)
2627 (struct charset_sort_data.priority): Now ptrdiff_t.
2628 (charset_compare): Don't overflow if priorities differ greatly.
2629 (Fsort_charsets): Don't assume list length fits in int.
2630 Check for size-calculation overflow when allocating sort data.
2631 (syms_of_charset): Allocate an initial charset table that is
2632 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2634 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2636 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2637 The actual value is always <= INT_MAX, and leaving it unsigned made
2638 overflow checking harder.
2640 * dispextern.h (struct glyph_matrix.rows_allocated)
2641 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2642 with xpalloc. The values are still always <= INT_MAX.
2644 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2646 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2647 (SAFE_NALLOCA): New macro.
2649 * region-cache.c (struct boundary.pos, find_cache_boundary)
2650 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2651 (set_cache_region, invalidate_region_cache)
2652 (revalidate_region_cache, know_region_cache, region_cache_forward)
2653 (region_cache_backward, pp_cache):
2654 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2655 so that ptrdiff_t * can be passed to xpalloc.
2656 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2657 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2658 (pp_cache): Don't assume cache_len fits in int.
2659 * region-cache.h: Adjust extern decls to match.
2661 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2662 EMACS_INT, since either will do, for xpalloc.
2664 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2665 (xnmalloc, xnrealloc, xpalloc): New functions.
2667 * bidi.c (bidi_shelve_header_size): New constant.
2668 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2669 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2671 * bidi.c (bidi_cache_shrink):
2672 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2674 Don't update size of array until after memory allocation succeeds,
2675 because xmalloc/xrealloc may not return.
2676 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2677 now that we have proper integer overflow checking.
2678 (record_overlay_string, overlay_strings): Catch overflows when
2679 calculating size of overlay_str_buf.
2681 * callproc.c (Fcall_process): Check for size overflow when
2682 calculating size of args2.
2683 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2684 Normally we prefer signed values, but sticking with ptrdiff_t would
2685 require adding more-complicated checks.
2687 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2688 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2689 Redo buffer-overflow calculations to avoid integer overflow.
2690 Add a FIXME comment where memory seems to be over-allocated.
2692 * character.c (Fstring): Check for size-calculation overflow.
2694 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2695 unnecessary integer overflow. Check for size overflow.
2696 (encode_coding_object): Don't update size until xmalloc succeeds.
2698 * composite.c (get_composition_id): Check for overflow in glyph
2699 length calculations.
2701 Integer and memory overflow fixes for display code.
2702 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2703 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2704 (scrolling_window): Check for overflow in size calculations.
2705 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2706 Don't assume glyph table len fits in int.
2707 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2708 (row_table_size): Now ptrdiff_t, not int.
2709 (scrolling_window): Avoid overflow in size calculations.
2710 Don't update size until allocation succeeds.
2711 * fns.c (concat): Check for overflow in size calculations.
2712 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2713 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2714 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2716 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2717 (get_doc_string): Check for size calculation overflow.
2718 Don't update size until allocation succeeds.
2719 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2720 EMACS_INT, where ptrdiff_t will do.
2721 (Fsubstitute_command_keys): Check for string overflow.
2723 * editfns.c (set_time_zone_rule): Don't assume environment length
2725 (message_length): Now ptrdiff_t, not int.
2726 (Fmessage_box): Don't update size until allocation succeeds.
2727 Don't assume message length fits in int.
2728 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2730 * emacs.c (main): Do not reallocate argv, since there is a null at
2731 the end that can be overwritten, and this way there's no need to
2732 worry about size-calculation overflow.
2733 (sort_args): Check for size-calculation overflow.
2735 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2737 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2739 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2740 (x_set_scroll_bar_width, x_figure_window_size):
2741 Check for integer overflow.
2742 (x_set_alpha): Do not assume XINT fits in int.
2744 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2745 This is for the members text_lines, text_cols, total_lines, total_cols,
2746 where the system imposes an 'int' limit.
2748 * fringe.c (Fdefine_fringe_bitmap):
2749 Don't update size until alloc works.
2751 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2752 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2754 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2755 Check for size-calculation overflow.
2756 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2757 do, as we prefer signed integers.
2758 (id_to_widget.max_size, id_to_widget.used)
2759 (xg_store_widget_in_map, xg_remove_widget_from_map)
2760 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2761 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2762 Use and return ptrdiff_t, not int.
2763 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2764 * gtkutil.h: Change prototypes to match the above.
2766 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2767 are duplicate now that they've been promoted to lisp.h.
2768 (x_allocate_bitmap_record, x_alloc_image_color)
2769 (make_image_cache, cache_image, xpm_load):
2770 Don't update size until alloc is done.
2771 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2773 Check for size calculation overflow.
2774 (ct_colors_allocated_max): New constant.
2775 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2778 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2779 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2780 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2781 Use ptrdiff_t, not int, to count maps.
2782 (read_char_minibuf_menu_prompt): Check for overflow in size
2783 calculations. Don't update size until allocation succeeds.
2784 Redo calculations to avoid overflow.
2785 * keyboard.h: Change prototypes to match the above.
2787 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2789 (current_minor_maps): Check for size calculation overflow.
2790 * keymap.h: Change prototypes to match the above.
2792 * lread.c (read1, init_obarray): Don't update size until alloc done.
2794 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2795 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2797 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2798 Now ptrdiff_t, not int.
2799 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2800 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2802 * process.c (Fnetwork_interface_list): Check for overflow
2803 in size calculation.
2805 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2807 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2808 overflow. Don't bother calling xmalloc when xrealloc will do.
2810 * search.c (Freplace_match): Check for size calculation overflow.
2811 (Fset_match_data): Don't assume list lengths fit in 'int'.
2813 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2814 for command line length. Do not attempt to address one before the
2815 beginning of an array, as that's not portable.
2817 * term.c (max_frame_lines): Remove; unused.
2818 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2820 (encode_terminal_code, calculate_costs): Check for size
2821 calculation overflow.
2822 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2823 table lengths and related sizes. Don't update size until alloc
2824 done. Redo calculations to avoid overflow.
2825 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2827 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2828 subtracting pointers.
2829 (gobble_line): Check for overflow more carefully. Don't update size
2832 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2833 Don't update size until alloc done.
2834 Redo size calculations to avoid overflow.
2835 Check for size calculation overflow.
2836 (main) [DEBUG]: Fix typo in invoking tparam1.
2838 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2839 Use ptrdiff_t, not int, for sizes.
2840 (store_mode_line_noprop_char): Don't update size until alloc done.
2842 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2843 Use ptrdiff_t, not int, for sizes.
2844 (Finternal_make_lisp_face, cache_face):
2845 Check for size calculation overflow.
2846 (cache_face): Treat size calculation overflows as if they were
2847 memory exhaustion (the usual treatment), rather than aborting.
2849 * xfns.c (x_encode_text, x_set_name_internal)
2850 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2851 sizes, since they can exceed INT_MAX in size. Check for size
2852 calculation overflow.
2854 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2855 (xg_select): Check for size calculation overflow.
2856 Don't update size until alloc done.
2858 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2859 as sprintf is limited to int lengths.
2861 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2862 (X_LONG_MIN): New macros.
2863 Use them to make the following changes clearer.
2864 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2865 This change doesn't affect the value now, but it may help remind
2866 future maintainers not to raise the value too much later.
2867 (SELECTION_QUANTUM): Remove, replacing with ...
2868 (selection_quantum): ... new function, which avoids overflow.
2870 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2871 assumption that selection length fits in 'int'.
2872 (x_reply_selection_request, x_handle_selection_request)
2873 (x_get_window_property, receive_incremental_selection)
2874 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2875 (lisp_data_to_selection_data, clean_local_selection_data):
2876 Use ptrdiff_t, not int, to record length of selection.
2877 (x_reply_selection_request, x_get_window_property)
2878 (receive_incremental_selection, x_property_data_to_lisp):
2879 Redo calculations to avoid overflow.
2880 (x_reply_selection_request): When sending hint, ceiling it at
2881 X_LONG_MAX rather than relying on wraparound overflow to send
2883 (x_get_window_property, receive_incremental_selection)
2884 (lisp_data_to_selection_data, x_property_data_to_lisp):
2885 Check for size-calculation overflow.
2886 (x_get_window_property, receive_incremental_selection)
2887 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2888 Don't store size until memory allocation succeeds.
2889 (x_get_window_property): Plug memory leak on memory exhaustion.
2890 Don't double-block input; malloc is safe here. Don't assume 2**34
2891 - 4 fits in unsigned long. Add an xassert to check
2892 XGetWindowProperty overflow. Be more careful about overflow
2893 calculations, and distinguish size from memory overflow better.
2894 (receive_incremental_selection): When tracing, don't assume
2895 unsigned int is less than INT_MAX.
2896 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2897 harmful) conversions of unsigned short to int.
2898 (lisp_data_to_selection_data): Don't assume that integers
2899 in the range -65535 through -1 fit in an X unsigned short.
2900 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2901 result parameters unless successful. Rely on cons_to_unsigned
2902 to report problems with elements; the old code wasn't right anyway.
2903 (x_check_property_data): Check for int overflow; we cannot use
2904 a wider type due to X limits.
2905 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2907 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2909 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2910 (x_term_init): Check for size calculation overflow.
2911 (x_color_cells): Don't store size until memory allocation succeeds.
2912 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2913 Don't assume alloca size is less than MAX_ALLOCA.
2914 (x_term_init): Don't assume length fits in int (sprintf is limited
2917 Use ptrdiff_t for composition IDs.
2918 * character.c (lisp_string_width):
2919 * composite.c (composition_table_size, n_compositions)
2920 (get_composition_id, composition_gstring_from_id):
2921 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2922 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2923 * window.c (Frecenter):
2924 Use ptrdiff_t, not int, for composition IDs.
2925 * composite.c (get_composition_id): Check for integer overflow.
2926 * composite.h: Adjust prototypes to match the above changes.
2928 Use ptrdiff_t for hash table indexes.
2929 * category.c (hash_get_category_set):
2930 * ccl.c (ccl_driver):
2931 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2932 * coding.c (coding_system_charset_list, detect_coding_system):
2933 * coding.h (struct coding_system.id):
2934 * composite.c (get_composition_id, gstring_lookup_cache):
2935 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2936 * image.c (xpm_get_color_table_h):
2937 * lisp.h (hash_lookup, hash_put):
2938 * minibuf.c (Ftest_completion):
2939 Use ptrdiff_t for hash table indexes, not int (which is too
2940 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2941 32-bit --with-wide-int hosts).
2943 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2944 Add a FIXME comment about memory leaks.
2945 (syms_of_charset): Don't assume xmalloc returns.
2947 Don't assume that stated character widths fit in int.
2948 * character.c (Fchar_width, c_string_width, lisp_string_width):
2949 * character.h (CHAR_WIDTH):
2950 * indent.c (MULTIBYTE_BYTES_WIDTH):
2951 Use sanitize_char_width to avoid undefined and/or bad behavior
2952 with outlandish widths.
2953 * character.h (sanitize_tab_width): Rename from sanitize_width,
2954 now that we have two such functions. All uses changed.
2955 (sanitize_char_width): New inline function.
2957 Don't assume that tab-width fits in int.
2958 * character.h (sanitize_width): New inline function.
2959 (SANE_TAB_WIDTH): New macro.
2960 (ASCII_CHAR_WIDTH): Use it.
2961 * indent.c (sane_tab_width): Remove. All uses replaced by
2962 SANE_TAB_WIDTH (current_buffer).
2963 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2965 * fileio.c: Integer overflow issues with file modes.
2966 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2968 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2969 Remove unreachable code.
2970 (read_hex, load_charset_map_from_file): Check for integer overflow.
2972 * xterm.c: Don't go over XClientMessageEvent limit.
2973 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2974 (x_send_scroll_bar_event): Likewise. Check that the size does not
2975 exceed limits imposed by XClientMessageEvent, as well as the usual
2976 ptrdiff_t and size_t limits.
2978 * keyboard.c: Overflow, signedness and related fixes.
2979 (make_lispy_movement): Use same integer type in forward decl
2980 that is used in the definition.
2981 (read_key_sequence, keyremap_step):
2982 Change bufsize argument back to int, undoing my 2011-03-30 change.
2983 We prefer signed types, and int is wide enough here.
2984 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2985 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2986 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2987 length, not size_t. Use ptrdiff_t for index, not int.
2988 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2989 possibility of integer overflow.
2991 Overflow, signedness and related fixes for images.
2993 * dispextern.h (struct it.stack[0].u.image.image_id)
2994 (struct_it.image_id, struct image.id, struct image_cache.size)
2995 (struct image_cache.used, struct image_cache.ref_count):
2996 * gtkutil.c (update_frame_tool_bar):
2997 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2998 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2999 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3000 * nsmenu.m (update_frame_tool_bar):
3001 * xdisp.c (calc_pixel_width_or_height):
3002 * xfns.c (image_cache_refcount):
3003 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3004 on typical 64-bit hosts.
3006 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3007 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3008 Omit unnecessary casts to int.
3009 (parse_image_spec): Check that integers fall into 'int' range
3010 when the callers expect that.
3011 (image_ascent): Redo ascent calculation to avoid int overflow.
3012 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3013 (lookup_image): Remove unnecessary tests.
3014 (xbm_image_p): Locals are now of int, not EMACS_INT,
3015 since parse_image_check makes sure they fit into int.
3016 (png_load, gif_load, svg_load_image):
3017 Prefer int to unsigned where either will do.
3018 (tiff_handler): New function, combining the cores of the
3019 old tiff_error_handler and tiff_warning_handler.
3020 This function is rewritten to use vsnprintf and thereby avoid
3021 stack buffer overflows. It uses only the features of vsnprintf
3022 that are common to both POSIX and native Microsoft.
3023 (tiff_error_handler, tiff_warning_handler): Use it.
3024 (tiff_load, gif_load, imagemagick_load_image):
3025 Don't assume :index value fits in 'int'.
3026 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3027 (imagemagick_load_image): Check that crop parameters fit into
3028 the integer types that MagickCropImage accepts. Don't assume
3029 Vimagemagick_render_type has a nonnegative value. Don't assume
3030 size_t fits in 'long'.
3031 (gs_load): Use printmax_t to print the widest integers possible.
3032 Check for integer overflow when computing image height and width.
3034 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3036 * xdisp.c (redisplay_window): Don't force window start if point
3037 will be invisible in the resulting window. (Bug#9324)
3039 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3041 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3042 the display spec is of the form `(space ...)'.
3043 (handle_display_spec): Return the value returned by
3044 handle_single_display_spec, not just 1 or zero.
3045 (handle_single_display_spec): If the display spec is of the form
3046 `(space ...)', and specifies display in the text area, return 2
3048 (try_cursor_movement): Check for the need to scroll more
3049 accurately, and prefer exact match for point under bidi.
3050 Don't advance `row' beyond the last row of the window.
3052 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3053 into disp_prop; all users changed.
3055 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3056 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3057 for the text covered by the display property.
3059 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3061 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3062 Change return value to nil.
3063 (Frecord_buffer): Delete unused function.
3065 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3067 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3068 buffers, return left-to-right.
3069 (set_cursor_from_row): Consider candidate row a win if its glyph
3070 represents a newline and point is on that newline. Fixes cursor
3071 positioning on the newline at EOL of R2L text within L2R
3072 paragraph, and vice versa.
3073 (try_cursor_movement): Check continued rows, in addition to
3074 continuation rows. Fixes unwarranted scroll when point enters a
3075 continued line of R2L text within an L2R paragraph, or vice versa.
3076 (cursor_row_p): Consider the case of point being equal to
3077 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3078 from the end of a short line to the beginning of a continued line
3079 of R2L text within L2R paragraph.
3080 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3081 composed characters.
3083 * bidi.c (bidi_check_type): Use xassert.
3084 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3087 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3089 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3092 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3094 * nsfont.m (ns_otf_to_script): Fix typo.
3096 2011-08-22 Kenichi Handa <handa@m17n.org>
3098 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3099 extra slot even if the purpose is char-code-property-table.
3101 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3103 * xdisp.c (redisplay_window): When computing centering_position,
3104 account for the height of the header line. (Bug#8874)
3106 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3107 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3108 candidate is selected by the mouse, and that candidate has a
3109 composed character under the mouse.
3111 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3112 coordinates reported by pos-visible-in-window-p for a composed
3113 character in column zero.
3115 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3117 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3119 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3121 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3122 consider it a hit if to_charpos is anywhere in the range of the
3123 composed buffer positions.
3125 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3127 * image.c (gif_load): Don't assume that each subimage has the same
3128 dimensions as the base image. Handle disposal method that is
3129 "undefined" by the gif spec (Bug#9335).
3131 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3133 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3134 (Fcondition_case): Document `debug' symbol in error handler.
3136 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3138 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3139 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3140 from an Org mode buffer to a Speedbar frame.
3142 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3143 a composition, take its buffer position from IT->cmp_it.charpos.
3144 Fixes cursor positioning at the beginning of a line that begins
3145 with a composed character.
3147 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3149 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3150 character bidirectional type, use STRONG_L instead. Fixes crashes
3151 in a buffer produced by `describe-categories'.
3153 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3154 members before the level stack, so they would be saved and
3155 restored when copying iterator state. Fixes incorrect reordering
3156 around TABs covered by display properties.
3158 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3160 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3162 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3164 * eval.c (internal_condition_case, internal_condition_case_1)
3165 (internal_condition_case_2, internal_condition_case_n):
3166 Remove unnecessary aborts (Bug#9081).
3168 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3170 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3171 has no `load' handler, try opening the file locally. (Bug#9311)
3173 2011-08-16 Ken Brown <kbrown@cornell.edu>
3175 * gmalloc.c: Expand comment.
3177 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3179 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3180 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3182 2011-08-16 Ken Brown <kbrown@cornell.edu>
3184 Fix memory allocation problems in Cygwin build (Bug#9273).
3186 * unexcw.c ( __malloc_initialized): Declare external variable.
3187 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3189 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3191 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3193 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3195 [CYGWIN] (special_realloc): New function.
3196 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3197 requests to realloc storage in the static heap.
3199 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3201 * bidi.c (bidi_initialize): Remove unused local.
3203 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3206 * biditype.h: Remove file.
3207 * makefile.w32-in ($(BLD)/bidi.$(O)):
3208 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3210 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3212 * chartab.c: Improve commentary for the uniprop_table API.
3214 * bidi.c (bidi_paragraph_init): Support zero value of
3215 bidi_ignore_explicit_marks_for_paragraph_level.
3216 (bidi_initialize): Use uniprop_table instead of including
3217 biditype.h and bidimirror.h.
3219 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3220 coordinates of the iterator when restoring from ppos_it.
3223 2011-08-14 Kenichi Handa <handa@m17n.org>
3225 * process.c (create_process): Call setup_process_coding_systems
3226 after the pid of the process is set to -1 (Bug#8162).
3228 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3230 * xdisp.c (move_it_in_display_line_to): Don't invoke
3231 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3232 ppos_it. Fixes vertical cursor motion when line beginning is
3233 covered by an image. (Bug#9296)
3235 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3237 * nsterm.h (ns_run_ascript): Declare.
3238 (NSAPP_DATA2_RUNASSCRIPT): Define.
3240 * nsfns.m (as_script, as_result, as_status): New static variables.
3241 (ns_run_ascript): New function.
3242 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3243 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3244 the event loop. Get status from as_status (Bug#7276).
3246 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3247 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3248 the event loop (Bug#7276).
3250 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3252 * gnutls.c (QCgnutls_bootprop_priority)
3253 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3254 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3255 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3256 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3257 (QCgnutls_bootprop_verify_hostname_error)
3258 (QCgnutls_bootprop_callbacks_verify): Rename from
3259 Qgnutls_bootprop_..., all uses changed.
3261 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3264 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3266 * xfaces.c (Qframe_set_background_mode): Now static.
3267 * dispextern.h (Qframe_set_background_mode): Remove decl.
3269 * process.c (Fnetwork_interface_info): Declare local only if needed.
3271 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3273 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3274 (Fnetwork_interface_list): Allocate in increments of bytes instead
3275 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3276 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3278 (struct ifflag_def): notrailers is smart on OSX.
3279 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3280 Get hardware address with getifaddrs if available.
3282 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3284 * xdisp.c (iterate_out_of_display_property): xassert that
3285 IT->position is set to within IT->object's boundaries. Break from
3286 the loop as soon as EOB is reached; avoids infloops in redisplay
3287 when IT->position is set up wrongly due to some bug.
3288 Set IT->current to match the bidi iterator unconditionally.
3289 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3290 entry. Force push_it to save on the stack the current
3291 buffer/string position, to be restored by pop_it. Fix flags in
3292 the iterator structure wrt the object coming from a display
3293 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3294 properties. (Bug#9284)
3296 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3298 * fontset.c (fontset_get_font_group): Add proper type checks.
3301 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3303 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3304 and LC_VERSION_MIN_MACOSX.
3305 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3306 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3308 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3310 * xdisp.c (forward_to_next_line_start): Allow to use the
3311 no-display-properties-and-no-overlays under bidi display.
3312 Set disp_pos in the bidi iterator to avoid searches for display
3313 properties and overlays.
3315 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3317 * editfns.c (Fset_time_zone_rule): Document relationship with the
3320 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3321 the font entity extracted from the cache (Bug#8109).
3323 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3325 * composite.c (autocmp_chars): Don't reset point. That is done by
3326 restore_point_unwind (Bug#5984).
3328 2011-08-07 Juri Linkov <juri@jurta.org>
3330 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3331 to show the arg `TIME' instead of `TIMEVAL'.
3333 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3335 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3336 display property strides EOL and includes a newline, as in
3337 longlines-mode. (Bug#9254)
3338 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3339 word-wrap under bidirectional display. (Bug#9224)
3341 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3342 is non-zero, even if the data buffer is NULL. Fixes a crash in
3343 vertical-motion with longlines-mode. (Bug#9254)
3345 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3347 * bidi.c <bidi_cache_total_alloc>: Now static.
3348 (bidi_initialize): Initialize bidi_cache_total_alloc.
3350 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3353 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3354 amount allocated this far in `bidi_cache_total_alloc'.
3355 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3356 non-zero, only free the data buffer without restoring the cache
3357 contents. All callers changed.
3359 * dispextern.h (bidi_unshelve_cache): Update prototype.
3361 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3362 (move_it_in_display_line, move_it_to)
3363 (move_it_vertically_backward, move_it_by_lines): Replace the call
3364 to xfree to an equivalent call to bidi_unshelve_cache.
3365 (move_it_in_display_line_to): Fix logic of returning
3366 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3368 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3370 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3371 came from a string character with a `cursor' property. (Bug#9229)
3373 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3375 * Makefile.in (LIB_PTHREAD): New variable.
3376 (LIBES): Add LIB_PTHREAD (Bug#9216).
3378 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3379 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3381 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3383 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3385 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3387 * xterm.c (x_find_topmost_parent): New function.
3388 (x_set_frame_alpha): Find topmost parent window with
3389 x_find_topmost_parent and set the property there also (bug#9181).
3390 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3392 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3394 * callproc.c (Fcall_process): Avoid vfork clobbering
3395 the local vars buffer, coding_systems, current_dir.
3397 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3399 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3401 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3403 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3404 so that it is not optimized away.
3406 * xdisp.c (compute_display_string_pos): Remove unused local.
3408 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3410 Fix slow cursor motion and scrolling in large buffers with
3411 selective display, like Org Mode buffers. (Bug#9218)
3413 * dispextern.h (struct bidi_it): New member disp_prop_p.
3415 * xdisp.c: Remove one-slot cache of display string positions.
3416 (compute_display_string_pos): Accept an additional argument
3417 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3418 for a display string or property. If found, set DISP_PROP_P
3421 * bidi.c (bidi_fetch_char): Accept an additional argument
3422 DISP_PROP_P, and pass it to compute_display_string_pos.
3423 Only handle text covered by a display string if DISP_PROP_P is returned
3424 non-zero. All callers of bidi_fetch_char changed.
3426 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3428 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3430 2010-12-03 Don March <don@ohspite.net>
3432 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3433 last character M-[char] is translated to ESC [char] (bug#7541).
3435 2011-08-02 Kenichi Handa <handa@m17n.org>
3437 * lisp.h (uniprop_table): Extern it.
3439 * chartab.c (uniprop_table): Make it non-static.
3441 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3443 * xdisp.c (forward_to_next_line_start): Accept additional argument
3444 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3446 (reseat_at_next_visible_line_start): Use the bidi iterator state
3447 returned by forward_to_next_line_start to restore the state of
3448 it->bidi_it after backing up to previous newline. (Bug#9212)
3450 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3452 * regex.c (re_comp): Protoize.
3453 (re_exec): Fix return type.
3454 (regexec): Fix type of `ret'. (Bug#9203)
3456 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3458 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3459 This is needed if max-image-size is a floating-point number.
3461 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3463 * print.c (print_object): Print empty symbol as ##.
3465 * lread.c (read1): Read ## as empty symbol.
3467 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3469 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3470 setting frame foreground color (Bug#9175).
3471 (x_set_background_color): Likewise.
3473 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3474 contents (Bug#9176).
3475 (EmacsTooltip -init): Remove bezels and add shadows to
3478 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3479 or scroll bar (Bug#8470).
3481 * nsfont.m (nsfont_open): Remove assignment to voffset and
3482 unnecessary vars hshink, expand, hd, full_height, min_height.
3483 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3485 * nsterm.h (nsfont_info): Remove voffset field.
3487 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3489 Implement strike-through and overline on NextStep (Bug#8863).
3491 * nsfont.m (nsfont_open): Use underline position provided by font,
3492 instead of hard-coded value of 2.
3493 (nsfont_draw): Call ns_draw_text_decoration instead.
3495 * nsterm.h: Add declaration for ns_draw_text_decoration.
3497 * nsterm.m (ns_draw_text_decoration): New function for drawing
3498 underline, overline, and strike-through.
3499 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3500 ns_draw_text_decoration. Change treatment of cursor drawing to
3501 accommodate underlining, etc.
3503 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3505 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3508 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3510 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3511 Without this fix, if a signal arrives just after memory fills up,
3512 'malloc' might be invoked reentrantly.
3514 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3515 In other words, assume that every image size is allowed, on non-X
3516 hosts. This assumption is probably wrong, but it lets Emacs compile.
3518 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3520 * regex.c (re_iswctype): Convert return values to boolean.
3522 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3524 * xdisp.c (compute_display_string_pos): Don't use cached display
3525 string position if the buffer had its restriction changed.
3528 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3530 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3532 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3534 Integer signedness and overflow and related fixes. (Bug#9079)
3536 * bidi.c: Integer size and overflow fixes.
3537 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3538 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3539 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3540 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3541 (bidi_find_other_level_edge):
3542 Use ptrdiff_t instead of EMACS_INT where either will do.
3543 This works better on 32-bit hosts configured --with-wide-int.
3544 (bidi_cache_ensure_space): Check for size-calculation overflow.
3545 Use % rather than repeated addition, for better worst-case speed.
3546 Don't set bidi_cache_size until after xrealloc returns, because it
3548 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3549 (bidi_cache_ensure_space): Also check that the bidi cache size
3550 does not exceed that of the largest Lisp string or buffer. See Eli
3551 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3553 * alloc.c (__malloc_size_t): Remove.
3554 All uses replaced by size_t. See Andreas Schwab's note
3555 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3557 * image.c: Improve checking for integer overflow.
3558 (check_image_size): Assume that f is nonnull, since
3559 it is always nonnull in practice. This is one less thing to
3560 worry about when checking for integer overflow later.
3561 (x_check_image_size): New function, which checks for integer
3562 overflow issues inside X.
3563 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3564 This removes the need for a memory_full check.
3565 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3566 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3567 (xbm_read_bitmap_data): Change locals back to 'int', since
3568 their values must fit in 'int'.
3569 (xpm_load_image, png_load, tiff_load):
3570 Invoke x_create_x_image_and_pixmap earlier,
3571 to avoid much needless work if the image is too large.
3572 (tiff_load): Treat overly large images as if
3573 x_create_x_image_and_pixmap failed, not as malloc failures.
3574 (gs_load): Use x_check_image_size.
3576 * gtkutil.c: Omit integer casts.
3577 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3578 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3580 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3582 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3583 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3584 would wrongly return t on a 64-bit host.
3586 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3587 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3588 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3589 and therefore cause GCC to emit a bogus diagnostic in some cases.
3591 * image.c: Integer signedness and overflow and related fixes.
3592 This is not an exhaustive set of fixes, but it's time to
3593 record what I've got.
3594 (lookup_pixel_color, check_image_size): Remove redundant decls.
3595 (check_image_size): Don't assume that arbitrary EMACS_INT values
3596 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3597 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3598 (tiff_load, imagemagick_load_image):
3599 Check for overflow in size calculations.
3600 (x_create_x_image_and_pixmap): Remove unnecessary test for
3601 xmalloc returning NULL; that can't happen.
3602 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3603 (xpm_color_bucket): Use better integer hashing function.
3604 (xpm_cache_color): Don't possibly over-allocate memory.
3605 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3606 (gif_memory_source):
3607 Use ptrdiff_t, not int or size_t, to record sizes.
3608 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3609 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3610 either works, as we prefer signed integers.
3611 (tiff_read_from_memory, tiff_write_from_memory):
3612 Return tsize_t, not size_t, since that's what the TIFF API wants.
3613 (tiff_read_from_memory): Don't fail simply because the read would
3614 go past EOF; instead, return a short read.
3615 (tiff_load): Omit no-longer-needed casts.
3616 (Fimagemagick_types): Don't assume size fits into 'int'.
3618 Improve hashing quality when configured --with-wide-int.
3619 * fns.c (hash_string): New function, taken from sxhash_string.
3620 Do not discard information about ASCII character case; this
3621 discarding is no longer needed.
3622 (sxhash-string): Use it. Change sig to match it. Caller changed.
3623 * lisp.h: Declare it.
3624 * lread.c (hash_string): Remove, since we now use fns.c's version.
3625 The fns.c version returns a wider integer if --with-wide-int is
3626 specified, so this should help the quality of the hashing a bit.
3628 * emacs.c: Integer overflow minor fix.
3629 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3630 Define only if GNU_LINUX.
3631 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3633 * dispnew.c: Integer signedness and overflow fixes.
3634 Remove unnecessary forward decls, that were a maintenance hassle.
3635 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3637 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3638 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3639 (prepare_desired_row, line_draw_cost):
3640 Use int, not unsigned, where either works.
3641 (save_current_matrix, restore_current_matrix):
3642 Use ptrdiff_t, not size_t, where either works.
3643 (init_display): Check for overflow more accurately, and without
3644 relying on undefined behavior.
3646 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3647 Remove, replacing with the new symbols in lisp.h. All uses changed.
3648 * fileio.c (make_temp_name):
3649 * filelock.c (lock_file_1, lock_file):
3650 * xdisp.c (message_dolog):
3651 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3652 Use pMd etc. instead.
3653 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3654 replacing the pWIDE etc. symbols removed from editfns.c.
3656 * keyboard.h (num_input_events): Now uintmax_t.
3657 This is (very slightly) less likely to mess up due to wraparound.
3660 * buffer.c: Integer signedness fixes.
3661 (alloc_buffer_text, enlarge_buffer_text):
3662 Use ptrdiff_t rather than size_t when either will do, as we prefer
3665 * alloc.c: Integer signedness and overflow fixes.
3666 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3667 (__malloc_size_t): Default to size_t, not to int.
3668 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3669 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3670 Prefer ptrdiff_t to size_t when either would do, as we prefer
3672 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3673 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3674 Now const. Initialize with values that are in range even if char
3676 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3677 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3678 These functions do the right thing with sizes > 2**32.
3679 (check_depth): Now ptrdiff_t, not int.
3680 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3681 Adjust to new way of storing sizes. Check for size overflow bugs
3683 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3684 slightly wrong anyway, as it missed one instance of
3685 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3686 (refill_memory_reserve): Omit needless cast to size_t.
3687 (mark_object_loop_halt): Mark as externally visible.
3689 * xselect.c: Integer signedness and overflow fixes.
3690 (Fx_register_dnd_atom, x_handle_dnd_message):
3691 Use ptrdiff_t, not size_t, since we prefer signed.
3692 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3693 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3694 x_dnd_atoms_size and x_dnd_atoms_length.
3696 * doprnt.c: Prefer signed to unsigned when either works.
3698 * doprnt.c (doprnt):
3700 * xdisp.c (vmessage):
3701 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3702 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3703 prefer signed arithmetic to avoid comparison confusion.
3704 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3705 but is a bit tricky.
3707 Assume freestanding C89 headers, string.h, stdlib.h.
3708 * data.c, doprnt.c, floatfns.c, print.c:
3709 Include float.h unconditionally.
3710 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3711 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3712 * regex.c: Likewise for stddef.h, string.h.
3713 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3714 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3715 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3716 (STDC_HEADERS): Remove obsolete defines.
3717 * sysdep.c: Include limits.h unconditionally.
3719 Assume support for memcmp, memcpy, memmove, memset.
3720 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3721 * regex.c (memcmp, memcpy):
3722 Remove; we assume C89 now.
3724 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3725 (__malloc_safe_bcopy): Remove; no longer needed.
3727 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3728 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3729 well either way, and we prefer signed to unsigned.
3731 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3733 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3734 closes the connection while we're reading (bug#9182).
3736 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3738 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3739 are specified (Bug#9168).
3741 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3743 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3744 Found by GCC static checking and --with-wide-int on a 32-bit host.
3746 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3748 * xdisp.c (compute_display_string_pos): Fix logic of caching
3749 previous display string position. Initialize cached_prev_pos to
3750 -1. Fixes slow-down at the beginning of a buffer.
3752 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3754 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3755 for attrs[LFACE_FONTSET_INDEX].
3757 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3759 * xml.c (parse_region): Remove unused local
3760 that was recently introduced.
3762 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3764 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3765 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3767 * xdisp.c (move_it_in_display_line_to): Record the best matching
3768 position for TO_CHARPOS while scanning the line, and restore it on
3769 exit if none of the characters scanned was an exact match.
3770 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3771 when exact match is impossible due to invisible text, and the
3772 lines are truncated.
3774 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3776 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3779 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3781 Fix a significant slow-down of cursor motion with C-n, C-p,
3782 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3783 auto-repeat under bidi redisplay in fontified buffers.
3784 * xdisp.c (compute_stop_pos_backwards): New function.
3785 (next_element_from_buffer): Call compute_stop_pos_backwards to
3786 find a suitable prev_stop when we find ourselves before
3788 (reseat): Don't look for prev_stop, as that could mean a very long
3790 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3791 <cached_disp_overlay_modiff>: Cache for last found display string
3793 (compute_display_string_pos): Return the cached position if asked
3794 about the same buffer in the same area of character positions, and
3795 the buffer wasn't changed since the time the display string
3796 position was cached.
3798 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3800 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3801 is an integer, which is important for empty lines. (Bug#9149)
3803 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3805 * frame.c (Fmodify_frame_parameters): In tty case, update the
3806 default face if necessary (Bug#4238).
3808 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3810 * editfns.c (Fstring_to_char): No need to explain what a character
3811 is in the docstring (Bug#6576).
3813 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3815 * xml.c (parse_region): Make sure we always return a tree.
3817 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3819 * xml.c (parse_region): If a document contains only comments,
3822 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824 * xml.c (make_dom): Return comments, too.
3826 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3829 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3830 and the surrounding thread.
3831 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3832 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3833 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3835 * s/openbsd.h (BROKEN_SIGIO): Define.
3836 * unexelf.c (unexec) [__OpenBSD__]:
3837 Don't update the .mdebug section of the Alpha COFF symbol table.
3839 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3841 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3844 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3846 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3847 This fixes some race conditions on the permissions of any newly
3850 * alloc.c (valid_pointer_p): Use pipe, not open.
3851 This fixes some permissions issues when debugging.
3853 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3854 If fchown fails to set both uid and gid, try to set just gid,
3855 as that is sometimes allowed. Adjust the file's mode to eliminate
3856 setuid or setgid bits that are inappropriate if fchown fails.
3858 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3861 to compare Lisp_Objects.
3862 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3863 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3864 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3866 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3868 * lread.c (read_integer): Unread even EOF character.
3869 (read1): Likewise. Properly record start position of symbol.
3871 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3872 symbol character follows.
3874 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3876 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3877 This works around a problem with the previous change to Fcopy_file.
3878 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3879 and without this change, GCC might complain about discarding
3880 fchown's return value.
3882 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3884 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3886 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3888 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3890 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3892 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3893 it's used from the C level.
3895 * process.c: Use the same condition for POLL_FOR_INPUT in both
3896 keyboard.c and process.c (bug#1858).
3898 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3900 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3901 (Fgnutls_boot): Use it.
3903 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3905 * doc.c (Fsubstitute_command_keys): Revert last change.
3907 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3910 quotes the next character, and doesn't affect other longer
3911 sequences (bug#8935).
3913 * lread.c (syms_of_lread): Clarify that is isn't only
3914 `eval-buffer' and `eval-defun' that's affected by
3915 `lexical-binding' (bug#8460).
3917 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3919 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3920 bidi redisplay when a line includes both an image and is truncated.
3922 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3924 Fix minor problems found by static checking.
3925 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3926 (elsz): Now a signed constant, not a size_t var. We prefer signed
3927 types to unsigned, to avoid integer comparison confusion. Without
3928 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3929 "cannot optimize loop, the loop counter may overflow", a symptom
3931 * indent.c (Fvertical_motion): Mark locals as initialized.
3932 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3934 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3936 * search.c (Fre_search_backward): Mention `case-fold-search' in
3937 all the re_search_* functions (bug#8138).
3939 * keyboard.c (Fopen_dribble_file): Document when the file is
3942 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3944 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3947 Support bidi reordering of display and overlay strings.
3948 * xdisp.c (compute_display_string_pos)
3949 (compute_display_string_end): Accept additional argument STRING.
3950 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3951 (reseat_to_string): Initialize bidi_it->string.s and
3952 bidi_it->string.schars.
3953 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3954 NULL (avoids a crash in bidi_paragraph_init).
3955 Initialize itb.string.lstring.
3956 (init_iterator): Call bidi_init_it only of a valid
3957 buffer position was specified. Initialize paragraph_embedding to
3959 (reseat_to_string): Initialize the bidi iterator.
3960 (display_string): If we need to ignore text properties of
3961 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3962 original value of -1 will not work with bidi.)
3963 (compute_display_string_pos): First arg is now struct
3964 `text_pos *'; all callers changed. Support display properties on
3966 (compute_display_string_end): Support display properties on Lisp
3968 (init_iterator, reseat_1, reseat_to_string): Initialize the
3969 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3970 when iterating on a string not from display properties).
3971 (compute_display_string_pos, compute_display_string_end):
3972 Fix calculation of the object to scan. Fixes an error when using
3974 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3975 base_level_stop; instead, set base_level_stop to BEGV.
3976 Fixes crashes in vertical-motion.
3977 (next_element_from_buffer): Improve commentary for when
3978 the iterator is before prev_stop.
3979 (init_iterator): Initialize bidi_p from the default value of
3980 bidi-display-reordering, not from buffer-local value. Use the
3981 buffer-local value only if initializing for buffer iteration.
3982 (handle_invisible_prop): Support invisible properties on strings
3983 that are being bidi-reordered.
3984 (set_iterator_to_next): Support bidi reordering of C strings and
3986 (next_element_from_string): Support bidi reordering of Lisp
3988 (handle_stop_backwards): Support Lisp strings as well.
3989 (display_string): Support display of R2L glyph rows.
3990 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3991 (init_iterator): Don't initialize it->bidi_p for strings
3993 (reseat_to_string): Initialize it->bidi_p for strings here.
3994 (next_element_from_string, next_element_from_c_string)
3995 (next_element_from_buffer): Add xassert's for correspondence
3996 between IT's object being iterated and it->bidi_it.string
3998 (face_before_or_after_it_pos): Support bidi iteration.
3999 (next_element_from_c_string): Handle the case of the first string
4000 character that is not the first one in the visual order.
4001 (get_visually_first_element): New function, refactored from common
4002 parts of next_element_from_buffer, next_element_from_string, and
4003 next_element_from_c_string.
4004 (tool_bar_lines_needed, redisplay_tool_bar)
4005 (display_menu_bar): Force left-to-right direction. Add a FIXME
4006 comment for making that be controlled by a user option.
4007 (push_it, pop_it): Save and restore the state of the
4008 bidi iterator. Save and restore the bidi_p flag.
4009 (pop_it): Iterate out of display property for string iteration as
4011 (iterate_out_of_display_property): Support iteration over strings.
4012 (handle_single_display_spec): Set up it->bidi_it for iteration
4013 over a display string, and call bidi_init_it.
4014 (handle_single_display_spec, next_overlay_string)
4015 (get_overlay_strings_1, push_display_prop): Set up the bidi
4016 iterator for displaying display or overlay strings.
4017 (forward_to_next_line_start): Don't use the shortcut if
4019 (back_to_previous_visible_line_start): If handle_display_prop
4020 pushed the iterator stack, restore the internal state of the bidi
4021 iterator by calling bidi_pop_it same number of times.
4022 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4023 and we are bidi-iterating, don't decrement the iterator position;
4024 instead, set the first_elt flag in the bidi iterator, to produce
4026 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4027 (push_display_prop): xassert that we are iterating a buffer.
4028 (push_it, pop_it): Save and restore paragraph_embedding member.
4029 (handle_single_display_spec, next_overlay_string)
4030 (get_overlay_strings_1, reseat_1, reseat_to_string)
4031 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4032 correctly. Don't assume unibyte strings are not bidi-reordered.
4033 (compute_display_string_pos)
4034 (compute_display_string_end): Fix handling the case of C string.
4035 (push_it, pop_it): Save and restore from_disp_prop_p.
4036 (handle_single_display_spec, push_display_prop): Set the
4037 from_disp_prop_p flag.
4038 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4039 (pop_it): Call iterate_out_of_display_property only if we are
4040 popping after iteration over a string that came from a display
4041 property. Fix a typo in popping stretch info. Add an assertion
4042 for verifying that the iterator position is in sync with the bidi
4044 (handle_single_display_spec, get_overlay_strings_1)
4045 (push_display_prop): Fix initialization of paragraph direction for
4046 string when that of the parent object is not yet determined.
4047 (reseat_1): Call bidi_init_it to resync the bidi
4048 iterator with IT's position. (Bug#7616)
4049 (find_row_edges): If ROW->start.pos gives position
4050 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4051 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4052 Reset the from_disp_prop_p flag.
4053 (SAVE_IT, RESTORE_IT): New macros.
4054 (pos_visible_p, face_before_or_after_it_pos)
4055 (back_to_previous_visible_line_start)
4056 (move_it_in_display_line_to, move_it_in_display_line)
4057 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4058 (try_scrolling, redisplay_window, display_line): Use them when
4059 saving a temporary copy of the iterator and restoring it back.
4060 (back_to_previous_visible_line_start, reseat_1)
4061 (init_iterator): Empty the bidi cache "stack".
4062 (move_it_in_display_line_to): If iterator ended up at
4063 EOL, but we never saw any buffer positions smaller than
4064 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4065 motion in bidi-reordered lines.
4066 (move_it_in_display_line_to): Record prev_method and prev_pos
4067 immediately before the call to set_iterator_to_next. Fixes cursor
4068 motion in bidi-reordered lines with stretch glyphs and strings
4069 displayed in margins. (Bug#8133) (Bug#8867)
4070 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4072 (pos_visible_p): Support positions in bidi-reordered lines.
4073 Save and restore bidi cache.
4075 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4076 (bidi_paragraph_info): Delete unused struct.
4077 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4078 (bidi_cache_start): New variable.
4079 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4081 (bidi_cache_fetch_state, bidi_cache_search)
4082 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4083 (bidi_cache_find, bidi_peek_at_next_level)
4084 (bidi_level_of_next_char, bidi_find_other_level_edge)
4085 (bidi_move_to_visually_next): Compare cache index with
4086 bidi_cache_start rather than with zero.
4087 (bidi_fetch_char): Accept new argument STRING; all callers
4088 changed. Support iteration over a string. Support strings with
4089 display properties. Support unibyte strings. Fix the type of
4090 `len' according to what STRING_CHAR_AND_LENGTH expects.
4091 (bidi_paragraph_init, bidi_resolve_explicit_1)
4092 (bidi_resolve_explicit, bidi_resolve_weak)
4093 (bidi_level_of_next_char, bidi_move_to_visually_next):
4094 Support iteration over a string.
4095 (bidi_set_sor_type, bidi_resolve_explicit_1)
4096 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4097 can now be zero (for strings); special values 0 and -1 were
4098 changed to -1 and -2, respectively.
4099 (bidi_char_at_pos): New function.
4100 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4101 Call it instead of FETCH_MULTIBYTE_CHAR.
4102 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4103 initialized to valid values.
4104 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4106 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4107 the test for valid cached positions. Fix the logic for looking up
4108 the sentinel state in the cache. GCPRO the Lisp string we are
4110 (bidi_push_it, bidi_pop_it): New functions.
4111 (bidi_initialize): Initialize the bidi cache start stack pointer.
4112 (bidi_cache_ensure_space): New function, refactored from part of
4113 bidi_cache_iterator_state. Don't assume the required size is just
4114 one BIDI_CACHE_CHUNK away.
4115 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4116 (bidi_count_bytes, bidi_char_at_pos): New functions.
4117 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4118 always valid if bidi_cache_idx is valid.
4119 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4120 is valid if it's going to be used.
4121 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4122 (bidi_cache_fetch_state, bidi_cache_search)
4123 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4124 (bidi_cache_iterator_state, bidi_cache_find)
4125 (bidi_find_other_level_edge, bidi_cache_start_stack):
4126 All variables related to cache indices are now EMACS_INT.
4128 * dispextern.h (struct bidi_string_data): New structure.
4129 (struct bidi_it): New member `string'. Make flag members be 1-bit
4130 fields, and put them last in the struct.
4131 (compute_display_string_pos, compute_display_string_end):
4133 (bidi_push_it, bidi_pop_it): Add prototypes.
4134 (struct iterator_stack_entry): New members bidi_p,
4135 paragraph_embedding, and from_disp_prop_p.
4136 (struct it): Member bidi_p is now a bit field 1 bit wide.
4137 (bidi_shelve_cache, bidi_unshelve_cache):
4140 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4141 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4142 and vector-like objects.
4144 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4145 cache around display iteration.
4147 * window.c (Fwindow_end, window_scroll_pixel_based)
4148 (displayed_window_lines, Frecenter): Save and restore the bidi
4149 cache around display iteration.
4151 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4153 * editfns.c (Fdelete_region): Clarify the use of the named
4154 parameters (bug#6788).
4156 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4158 * indent.c (Fvertical_motion): Set and restore w->pointm when
4159 saving and restoring the window's buffer (Bug#9006).
4161 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163 * editfns.c (Fstring_to_char): Clarify just what is returned
4164 (bug#6576). Text by Eli Zaretskii.
4166 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4168 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4170 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4172 * buffer.c (mmap_find): Fix a typo.
4174 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4176 Fix execution of x selection hooks.
4177 * xselect.c (Qx_lost_selection_functions)
4178 (Qx_sent_selection_functions): New vars.
4179 (syms_of_xselect): DEFSYM them.
4180 (x_handle_selection_request): Pass Qx_sent_selection_functions
4181 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4182 (x_handle_selection_clear,x_clear_frame_selections):
4183 Pass Qx_lost_selection_functions rather than
4184 Vx_lost_selection_functions to Frun_hook_with_args.
4186 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4188 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4189 The old code sometimes used this field without initializing it.
4191 * alloc.c (gc_sweep): Don't read past end of array.
4192 In theory, the old code could also have corrupted Emacs internals,
4193 though it'd be very unlikely.
4195 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4197 * character.c (Fcharacterp): Don't advertise optional ignored
4198 argument. (Bug#4026)
4200 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4202 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4205 * window.c (Fset_window_start): Doc fix (bug#4199).
4206 (Fset_window_hscroll): Ditto.
4208 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4210 Fix minor new problems caught by GCC 4.6.1.
4211 * term.c (init_tty): Remove unused local.
4212 * xsettings.c (store_monospaced_changed): Define this function only
4213 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4216 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4218 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4220 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4222 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4223 are the mini-buffer and the echo area (bug#3320).
4225 * term.c (init_tty): Remove support for supdup, c10 and perq
4226 terminals, which are no longer supported (bug#1482).
4228 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4230 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4232 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4234 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4235 for non-popups (Bug#3642).
4237 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4239 * alloc.c (reset_malloc_hooks): Protoize.
4240 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4241 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4242 * cm.c (losecursor): Likewise.
4243 * data.c (fmod): Likewise.
4244 * dispnew.c (swap_glyphs_in_rows): Likewise.
4245 * emacs.c (memory_warning_signal): Likewise.
4246 * floatfns.c (float_error): Likewise.
4247 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4248 (otf_open, font_otf_capability, generate_otf_features)
4249 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4251 * image.c (pbm_read_file): Likewise.
4252 * indent.c (string_display_width): Likewise.
4253 * intervals.c (check_for_interval, search_for_interval)
4254 (inc_interval_count, count_intervals, root_interval)
4255 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4256 * lread.c (defalias): Likewise.
4257 * ralloc.c (r_alloc_check): Likewise.
4258 * regex.c (set_image_of_range_1, set_image_of_range)
4259 (regex_grow_registers): Likewise.
4260 * sysdep.c (strerror): Likewise.
4261 * termcap.c (valid_filename_p, tprint, main): Likewise.
4262 * tparam.c (main): Likewise.
4263 * unexhp9k800.c (run_time_remap, save_data_space)
4264 (update_file_ptrs, read_header, write_header, calculate_checksum)
4265 (copy_file, copy_rest, display_header): Likewise.
4266 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4268 * xdisp.c (check_it): Likewise.
4269 * xfaces.c (register_color, unregister_color, unregister_colors):
4271 * xfns.c (print_fontset_result): Likewise.
4272 * xrdb.c (member, fatal, main): Likewise.
4274 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4276 Fix minor problems found by static checking (Bug#9031).
4277 * chartab.c (char_table_set_range, map_sub_char_table):
4278 Remove unused locals.
4279 (uniprop_table): Now static.
4280 * composite.c (_work_char): Remove unused static var.
4282 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4284 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4286 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4288 * gtkutil.c (qttip_cb): Remove code without function.
4290 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4292 * w32.c (pthread_sigmask): New stub.
4294 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4296 Use pthread_sigmask, not sigprocmask (Bug#9010).
4297 sigprocmask is portable only for single-threaded applications, and
4298 Emacs can be multi-threaded when it uses GTK.
4299 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4301 * callproc.c (Fcall_process):
4302 * process.c (create_process):
4303 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4304 Use pthread_sigmask, not sigprocmask.
4306 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4308 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4309 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4312 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4314 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4315 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4316 (xg_hide_tooltip): Fix comment.
4318 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4319 in registerServicesMenuSendTypes.
4320 (validRequestorForSendType): Don't check ns_return_types.
4322 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4325 2011-07-08 Jason Rumney <jasonr@gnu.org>
4327 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4328 SH_SHOW for hidden windows (Bug#5482).
4330 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4331 frame struct members of non-existent frames (Bug#6284).
4333 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4335 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4336 variable firstTime not needed on OSX >= 10.6.
4337 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4338 >= 10.5. Use setKnobProportion, setDoubleValue.
4340 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4341 (MAC_OS_X_VERSION_10_5): Define if not defined.
4342 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4343 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4344 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4346 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4347 cString and lossyCString on OSX >= 10.4
4349 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4350 sizeToFit on OSX >= 10.2.
4352 * nsimage.m (allocInitFromFile): Don't use deprecated method
4353 bestRepresentationForDevice on OSX >= 10.6.
4355 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4358 * emacs.c: Declare unexec_init_emacs_zone.
4360 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4362 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4364 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4365 on svcsMenu (Bug#8842).
4367 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4369 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4371 * nsterm.m (QUTF8_STRING): Declare.
4372 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4373 (validRequestorForSendType): Return type is (id).
4374 Change indexOfObjectIdenticalTo to indexOfObject.
4375 Check if we have local selection before returning self (Bug#8842).
4376 (writeSelectionToPasteboard): Put local selection into paste board
4377 if we have a local selection (Bug#8842).
4378 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4380 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4381 (ns_get_local_selection): Declare.
4383 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4385 * keymap.c (describe_map_tree): Don't insert a double newline at
4386 the end of the buffer (bug#1169) and return whether we inserted
4389 * callint.c (Fcall_interactively): Change "reading args" to
4390 "providing args" to try to clarify what it does (bug#1010).
4392 2011-07-07 Kenichi Handa <handa@m17n.org>
4394 * composite.c (composition_compute_stop_pos): Ignore a static
4395 composition starting before CHARPOS (Bug#8915).
4397 * xdisp.c (handle_composition_prop): Likewise.
4399 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4401 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4404 2011-07-07 Kenichi Handa <handa@m17n.org>
4406 * character.h (unicode_category_t): New enum type.
4408 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4409 (Qchar_code_property_table): New variable.
4410 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4411 (UNIPROP_COMPRESSED_FORM_P): New macros.
4412 (char_table_ascii): Uncompress the compressed values.
4413 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4414 Uncompress the compressed values.
4415 (sub_char_table_ref_and_range): Likewise.
4416 (char_table_ref_and_range): Uncompress the compressed values.
4417 (sub_char_table_set): New arg is_uniprop. Callers changed.
4418 Uncompress the compressed values.
4419 (sub_char_table_set_range): Args changed. Callers changed.
4420 (char_table_set_range): Adjuted for the above change.
4421 (map_sub_char_table): Delete args default_val and parent. Add arg
4422 top. Give decoded values to a Lisp function.
4423 (map_char_table): Adjust for the above change. Give decoded
4424 values to a Lisp function. Gcpro more variables.
4425 (uniprop_table_uncompress)
4426 (uniprop_decode_value_run_length): New functions.
4427 (uniprop_decoder, uniprop_decoder_count): New variables.
4428 (uniprop_get_decoder, uniprop_encode_value_character)
4429 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4431 (uniprop_encoder, uniprop_encoder_count): New variables.
4432 (uniprop_get_encoder, uniprop_table)
4433 (Funicode_property_table_internal, Fget_unicode_property_internal)
4434 (Fput_unicode_property_internal): New functions.
4435 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4436 Sunicode_property_table_internal, Sget_unicode_property_internal,
4437 and Sput_unicode_property_internal. Defvar_lisp
4438 char-code-property-alist.
4440 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4441 Vunicode_category_table.
4443 * font.c (font_range): Adjust for the change of
4444 Vunicode_category_table.
4446 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4448 * m/iris4d.h: Remove file, move contents ...
4449 * s/irix6-5.h: ... here.
4451 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4453 Remove unportable assumption about struct layout (Bug#8884).
4454 * alloc.c (mark_buffer):
4455 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4456 (clone_per_buffer_values): Don't assume that
4457 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4458 This isn't true in general, and it's particularly not true
4459 if Emacs is configured with --with-wide-int.
4460 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4461 New macros, used in the buffer.c change.
4463 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4465 * xsettings.c: Use both GConf and GSettings if both are available.
4466 (store_config_changed_event): Add comment.
4467 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4468 (store_tool_bar_style_changed): New functions.
4469 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4470 (struct xsettings): Move font inside HAVE_XFT.
4471 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4472 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4473 Move inside HAVE_XFT.
4474 (something_changed_gsettingsCB): Rename from something_changedCB.
4475 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4477 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4478 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4479 (something_changed_gconfCB): Rename from something_changedCB.
4480 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4481 (parse_settings): Move check for font inside HAVE_XFT.
4482 (read_settings, apply_xft_settings): Add comment.
4483 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4484 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4485 call store_font_name_changed.
4486 (xft_settings_event): Add comment.
4487 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4488 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4489 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4490 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4491 (xsettings_initialize): Call init_gsettings last.
4492 (xsettings_get_system_font, xsettings_get_system_normal_font):
4495 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4497 Random fixes. E.g., (random) never returned negative values.
4498 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4499 subseconds part to the entropy, as that's a bit more random.
4500 Prefer signed to unsigned, since the signedness doesn't matter and
4501 in general we prefer signed. When given a limit, use a
4502 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4503 latter isn't right if USE_2_TAGS_FOR_INTS.
4504 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4505 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4507 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4509 * textprop.c (text_property_stickiness):
4510 Obey Vtext_property_default_nonsticky.
4511 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4512 * w32fns.c (syms_of_w32fns):
4513 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4515 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4517 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4518 This is more efficient than Ffile_directory_p and avoids a minor race.
4520 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4522 * buffer.c (Foverlay_put): Say what the return value is
4525 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4526 is a directory before asking whether to use the file name
4528 (barf_or_query_if_file_exists): Make the "File is a directory"
4529 error be more correct.
4531 * fns.c (Frequire): Remove the mention of the .gz files, since
4532 that's installation-specific, but keep the mention of
4533 `get-load-suffixes'.
4535 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4537 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4538 Report string overflow if the output is too long.
4540 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4542 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4543 (syms_of_gnutls): Remove duplicate DEFSYM for
4544 Qgnutls_bootprop_verify_hostname_error, an error for
4545 Qgnutls_bootprop_verify_error (which is no longer used).
4547 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4548 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4549 Also (re)move comments that are misplaced or no longer relevant.
4551 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4553 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4555 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4557 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4558 and background color parameters if they have been changed.
4560 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4562 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4564 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4566 * xsettings.c (SYSTEM_FONT): Define only when used.
4567 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4569 * keymap.c (access_keymap_1): Now static.
4571 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4573 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4574 leave any prefix arg for the up event (Bug#1586).
4576 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4578 * lread.c (syms_of_lread): Mention single symbols defined by
4579 `defvar' or `defconst' (bug#7154).
4581 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4582 (Frequire): Mention get-load-suffixes.
4584 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4586 * window.h (window): Remove clone_number slot.
4587 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4589 (make_parent_window, make_window, saved_window)
4590 (Fset_window_configuration, save_window_save): Don't deal with
4592 * buffer.c (Qclone_number): Remove declaration.
4593 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4595 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4597 Add multiple inheritance to keymaps.
4598 * keymap.c (Fmake_composed_keymap): New function.
4599 (Fset_keymap_parent): Simplify.
4600 (fix_submap_inheritance): Remove.
4601 (access_keymap_1): New function extracted from access_keymap to handle
4602 embedded parents and handle lists of maps.
4603 (access_keymap): Use it.
4604 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4605 (Fcopy_keymap): Handle embedded parents.
4606 (Fcommand_remapping, define_as_prefix): Simplify.
4607 (Fkey_binding): Simplify.
4608 (syms_of_keymap): Move minibuffer-local-completion-map,
4609 minibuffer-local-filename-completion-map,
4610 minibuffer-local-must-match-map, and
4611 minibuffer-local-filename-must-match-map to Elisp.
4612 (syms_of_keymap): Defsubr make-composed-keymap.
4613 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4614 (parse_menu_item): Trivial simplification.
4616 2011-07-01 Glenn Morris <rgm@gnu.org>
4618 * Makefile.in (SETTINGS_LIBS): Fix typo.
4620 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4622 * coding.c (Fencode_coding_string): Record the last coding system
4623 used, as the function doc string says (bug#8738).
4625 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4627 * xsettings.c (store_monospaced_changed): Take new font as arg and
4628 check for change against current_mono_font.
4629 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4630 (emacs_settings_constructor, emacs_settings_get_property)
4631 (emacs_settings_set_property, emacs_settings_class_init)
4632 (emacs_settings_init, gsettings_obj): Remove.
4633 (something_changedCB): New function for HAVE_GSETTINGS.
4634 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4635 with value as argument.
4636 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4637 g_settings_new (Bug#8967). Do not create gsettings_obj.
4638 Remove calls to g_settings_bind. Connect something_changedCB to
4641 * xgselect.c: Add defined (HAVE_GSETTINGS).
4642 (xgselect_initialize): Ditto.
4644 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4645 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4648 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4650 * eval.c (struct backtrace): Simplify and port the data structure.
4651 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4652 signed bit field, as this assumption is not portable and it makes
4653 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4654 "char debug_on_exit : 1" as this is not portable either; instead,
4655 use the portable "unsigned int debug_on_exit : 1". Remove unused
4656 member evalargs. Remove obsolete comments about cc bombing out.
4658 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4660 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4661 Let HAVE_GSETTINGS override HAVE_GCONF.
4662 (store_monospaced_changed): New function.
4663 (EMACS_SETTINGS): A new type derived from GObject to handle
4664 GSettings notifications.
4665 (emacs_settings_constructor, emacs_settings_get_property)
4666 (emacs_settings_set_property, emacs_settings_class_init):
4668 (gsettings_client, gsettings_obj): New variables.
4669 (GSETTINGS_SCHEMA): New define.
4670 (something_changedCB): Call store_monospaced_changed.
4671 (init_gsettings): New function.
4672 (xsettings_initialize): Call init_gsettings.
4673 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4676 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4679 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4681 * window.c (resize_root_window, grow_mini_window)
4682 (shrink_mini_window): Rename Qresize_root_window to
4683 Qwindow_resize_root_window and Qresize_root_window_vertically to
4684 Qwindow_resize_root_window_vertically.
4686 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4688 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4690 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4692 * makefile.w32-in: Redesign dependencies so they reflect more
4693 clearly which files are directly included by each source file,
4694 and not through other includes.
4696 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4698 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4699 (sort_overlays, overlay_strings): When an overlay's clone number
4700 matches the window's clone number process the overlay even if
4701 the overlay's window property doesn't match the current window.
4703 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4704 (Fwindow_hchild): Rename to Fwindow_left_child.
4705 (Fwindow_next): Rename to Fwindow_next_sibling.
4706 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4707 (resize_window_check): Rename to window_resize_check.
4708 (resize_window_apply): Rename to window_resize_apply.
4709 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4710 (Fdelete_other_windows_internal, resize_frame_windows)
4711 (Fsplit_window_internal, Fdelete_window_internal)
4712 (grow_mini_window, shrink_mini_window)
4713 (Fresize_mini_window_internal): Fix callers accordingly.
4715 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4717 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4718 (emacs_fixed_set_min_size): Remove.
4719 (emacs_fixed_new): Take frame as argument.
4721 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4722 (_EmacsFixedPrivate): Remove minwidth/height.
4723 Add struct frame *f.
4724 (emacs_fixed_init): Initialize priv->f.
4725 (get_parent_class, emacs_fixed_set_min_size): Remove.
4726 (emacs_fixed_new): Set priv->f to argument.
4727 (emacs_fixed_get_preferred_width)
4728 (emacs_fixed_get_preferred_height): Use min_width/height from
4729 frames size_hint to set minimum and natural (Bug#8919).
4730 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4731 and use min_width/height from frames size_hint to set
4732 min_width/height (Bug#8919).
4734 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4735 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4738 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4740 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4741 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4744 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4746 * process.c (wait_reading_process_output): Bypass select if
4747 waiting for a cell while ignoring keyboard input, and input is
4748 pending. Suggested by Jan Djärv (Bug#8869).
4750 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4752 Use gnulib's dup2 module instead of rolling our own.
4753 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4755 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4757 * dispnew.c (scrolling_window): Before scrolling, turn off a
4758 mouse-highlight in the window being scrolled.
4760 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4762 Move DEFSYM to lisp.h and use everywhere.
4764 * character.h (DEFSYM): Move declaration...
4765 * lisp.h (DEFSYM): ...here.
4771 * w32select.c: Don't include character.h.
4773 * alloc.c (syms_of_alloc):
4774 * buffer.c (syms_of_buffer):
4775 * bytecode.c (syms_of_bytecode):
4776 * callint.c (syms_of_callint):
4777 * casefiddle.c (syms_of_casefiddle):
4778 * casetab.c (init_casetab_once):
4779 * category.c (init_category_once, syms_of_category):
4780 * ccl.c (syms_of_ccl):
4781 * cmds.c (syms_of_cmds):
4782 * composite.c (syms_of_composite):
4783 * dbusbind.c (syms_of_dbusbind):
4784 * dired.c (syms_of_dired):
4785 * dispnew.c (syms_of_display):
4786 * doc.c (syms_of_doc):
4787 * editfns.c (syms_of_editfns):
4788 * emacs.c (syms_of_emacs):
4789 * eval.c (syms_of_eval):
4790 * fileio.c (syms_of_fileio):
4791 * fns.c (syms_of_fns):
4792 * frame.c (syms_of_frame):
4793 * fringe.c (syms_of_fringe):
4794 * insdel.c (syms_of_insdel):
4795 * keymap.c (syms_of_keymap):
4796 * lread.c (init_obarray, syms_of_lread):
4797 * macros.c (syms_of_macros):
4798 * msdos.c (syms_of_msdos):
4799 * print.c (syms_of_print):
4800 * process.c (syms_of_process):
4801 * search.c (syms_of_search):
4802 * sound.c (syms_of_sound):
4803 * syntax.c (init_syntax_once, syms_of_syntax):
4804 * terminal.c (syms_of_terminal):
4805 * textprop.c (syms_of_textprop):
4806 * undo.c (syms_of_undo):
4807 * w32.c (globals_of_w32):
4808 * window.c (syms_of_window):
4809 * xdisp.c (syms_of_xdisp):
4810 * xfaces.c (syms_of_xfaces):
4811 * xfns.c (syms_of_xfns):
4812 * xmenu.c (syms_of_xmenu):
4813 * xsettings.c (syms_of_xsettings):
4814 * xterm.c (syms_of_xterm): Use DEFSYM.
4816 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4818 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4820 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4822 Integer and buffer overflow fixes (Bug#8873).
4824 * print.c (printchar, strout): Check for string overflow.
4825 (PRINTPREPARE, printchar, strout):
4826 Don't set size unless allocation succeeds.
4828 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4829 for sizes. Check for string overflow more accurately.
4830 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4832 * macros.c: Integer and buffer overflow fixes.
4833 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4834 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4835 Use ptrdiff_t, not int, for sizes.
4836 Don't increment bufsize until after realloc succeeds.
4837 Check for size-calculation overflow.
4838 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4840 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4842 * lread.c: Integer overflow fixes.
4843 (read_integer): Radix is now EMACS_INT, not int,
4844 to improve quality of diagnostics for out-of-range radices.
4845 Calculate buffer size correctly for out-of-range radices.
4846 (read1): Check for integer overflow in radices, and in
4847 read-circle numbers.
4848 (read_escape): Avoid int overflow.
4849 (Fload, openp, read_buffer_size, read1)
4850 (substitute_object_recurse, read_vector, read_list, map_obarray):
4851 Use ptrdiff_t, not int, for sizes.
4852 (read1): Use EMACS_INT, not int, for sizes.
4853 Check for size overflow.
4855 * image.c (cache_image): Check for size arithmetic overflow.
4857 * lread.c: Integer overflow issues.
4858 (saved_doc_string_size, saved_doc_string_length)
4859 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4860 Now ptrdiff_t, not int.
4861 (read1): Don't assume doc string length fits in int. Check for
4862 out-of-range doc string lengths.
4863 (read_list): Don't assume file position fits in int.
4864 (read_escape): Check for hex character overflow.
4866 2011-06-22 Leo Liu <sdl.web@gmail.com>
4868 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4869 Move to minibuffer.el.
4871 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4873 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4874 The following patches are for when GLYPH_DEBUG && !XASSERT.
4875 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4876 * dispnew.c (flush_stdout):
4877 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4878 Mark as externally visible.
4879 * dispnew.c (check_window_matrix_pointers): Now static.
4880 * dispnew.c (window_to_frame_vpos):
4881 * xfns.c (unwind_create_frame):
4882 * xterm.c (x_check_font): Remove unused local.
4883 * scroll.c (CHECK_BOUNDS):
4884 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4885 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4886 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4887 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4888 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4890 (debug_method_add): Use va_list and vsprintf rather than relying
4891 on undefined behavior with wrong number of arguments.
4892 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4893 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4894 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4895 since we're not interested in debugging glyphs with old libraries.
4896 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4897 GCC 4.6.0's static checking.
4899 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4901 Integer overflow and signedness fixes (Bug#8873).
4902 A few related buffer overrun fixes, too.
4904 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4906 * dispextern.h (struct face.stipple):
4907 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4908 (x_bitmap_mask, x_allocate_bitmap_record)
4909 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4910 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4911 (x_create_bitmap_from_xpm_data):
4912 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4913 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4915 * xfaces.c (load_pixmap):
4916 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4917 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4918 (.bitmaps_last, struct x_output.icon_bitmap):
4919 Use ptrdiff_t, not int, for bitmap indexes.
4920 (x_allocate_bitmap_record): Check for size overflow.
4921 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4923 Use ptrdiff_t, not int, for overlay counts.
4924 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4925 * editfns.c (overlays_around, get_pos_property):
4926 * textprop.c (get_char_property_and_overlay):
4927 * xdisp.c (next_overlay_change, note_mouse_highlight):
4928 * xfaces.c (face_at_buffer_position):
4929 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4930 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4931 (Fnext_overlay_change, Fprevious_overlay_change)
4932 (mouse_face_overlay_overlaps, Foverlays_in):
4933 Use ptrdiff_t, not int, for sizes.
4934 (overlays_at, overlays_in): Check for size-calculation overflow.
4936 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4938 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4939 (x_session_initialize): Do not assume string length fits in int.
4941 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4942 This is unlikely, but can occur if DPI is outlandish.
4944 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4945 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4947 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4948 * xrdb.c (magic_file_p, search_magic_path):
4949 Omit last arg SUFFIX; it was always 0. All callers changed.
4950 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4952 * xfont.c (xfont_match): Avoid need for strlen.
4954 * xfns.c: Don't assume strlen fits in int.
4955 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4957 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4958 not unsigned long, as we prefer signed integers. All callers changed.
4959 Detect integer overflow in repeat count.
4960 (message_dolog): Don't assume print length fits in 39 bytes.
4961 (display_mode_element): Don't assume strlen fits in int.
4963 * termcap.c: Don't assume sizes fit in int and never overflow.
4964 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4965 (gobble_line): Check for size-calculation overflow.
4967 * minibuf.c (Fread_buffer):
4968 * lread.c (intern, intern_c_string):
4969 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4970 Don't assume string length fits in int.
4972 * keyboard.c (parse_tool_bar_item):
4973 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4975 * font.c: Don't assume string length fits in int.
4976 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4977 Use ptrdiff_t, not int.
4978 (font_intern_prop): Don't assume string length fits in int.
4979 Don't assume integer property fits in fixnum.
4980 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4982 * filelock.c: Fix some buffer overrun and integer overflow issues.
4983 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4984 Reformulate so as not to need the command string.
4985 Invoke gzip -cd rather than gunzip, as it's more portable.
4986 (lock_info_type, lock_file_1, lock_file):
4987 Don't assume pid_t and time_t fit in unsigned long.
4988 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4989 (current_lock_owner): Prefer signed type for sizes.
4990 Use memcpy, not strncpy, where memcpy is what is really wanted.
4991 Don't assume (via atoi) that time_t and pid_t fit in int.
4992 Check for time_t and/or pid_t out of range, e.g., via a network share.
4993 Don't alloca where an auto var works fine.
4995 * fileio.c: Fix some integer overflow issues.
4996 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4997 Don't assume string length fits in int.
4998 (directory_file_name): Don't assume string length fits in long.
4999 (make_temp_name): Don't assume pid fits in int, or that its print
5000 length is less than 20.
5002 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5004 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5006 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5008 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5009 We prefer signed integers, even for size calculations.
5011 * emacs.c: Don't assume string length fits in 'int'.
5012 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5013 (main): Don't invoke strlen when not needed.
5015 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5016 (XD_DEBUG_MESSAGE): Don't waste a byte.
5018 * callproc.c (getenv_internal_1, getenv_internal)
5020 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5022 * lread.c (invalid_syntax): Omit length argument.
5023 All uses changed. This doesn't fix a bug, but it simplifies the
5024 code away from its former Hollerith-constant appearance, and it's
5025 one less 'int' to worry about when looking at integer-overflow issues.
5026 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5028 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5029 This didn't break anything, but it didn't help either.
5030 It's confusing to put a bogus integer in a place where the actual
5031 value does not matter.
5032 (LIST_END_P): Remove unused macro and its bogus comment.
5033 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5035 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5036 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5038 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5039 We prefer signed types, and the value cannot exceed the EMACS_INT
5040 range anyway (because otherwise the length would not be representable).
5041 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5042 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5043 This avoids a GCC warning when WIDE_EMACS_INT.
5045 * indent.c (sane_tab_width): New function.
5046 (current_column, scan_for_column, Findent_to, position_indentation)
5047 (compute_motion): Use it. This is just for clarity.
5048 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5050 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5052 * lisp.h (lint_assume): New macro.
5053 * composite.c (composition_gstring_put_cache):
5054 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5056 * editfns.c, insdel.c:
5057 Omit unnecessary forward decls, to simplify future changes.
5059 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5061 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5063 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5064 Use much-faster test for byte-length change.
5065 Don't assume string byte-length fits in 'int'.
5066 Check that character arg fits in 'int'.
5067 (mapcar1): Declare byte as byte, for clarity.
5069 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5071 * fns.c (concat): Catch string overflow earlier.
5072 Do not rely on integer wraparound.
5074 * dispextern.h (struct it.overlay_strings_charpos)
5075 (struct it.selective): Now EMACS_INT, not int.
5076 * xdisp.c (forward_to_next_line_start)
5077 (back_to_previous_visible_line_start)
5078 (reseat_at_next_visible_line_start, next_element_from_buffer):
5079 Don't arbitrarily truncate the value of 'selective' to int.
5081 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5083 * composite.c: Don't truncate sizes to 'int'.
5084 (composition_gstring_p, composition_reseat_it)
5085 (composition_adjust_point): Use EMACS_INT, not int.
5086 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5087 not EMACS_UINT, for indexes.
5089 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5091 * buffer.c: Include <verify.h>.
5092 (struct sortvec.priority, struct sortstr.priority):
5093 Now EMACS_INT, not int.
5094 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5095 (struct sortstr.size, record_overlay_string)
5096 (struct sortstrlist.size, struct sortlist.used):
5097 Don't truncate size to int.
5098 (record_overlay_string): Check for size-calculation overflow.
5099 (init_buffer_once): Check at compile-time, not run-time.
5101 2011-06-22 Jim Meyering <meyering@redhat.com>
5103 Don't leak an XBM-image-sized buffer
5104 * image.c (xbm_load): Free the image buffer after using it.
5106 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5109 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5110 that Sun C diagnosed.
5111 * fns.c (secure_hash): Fix pointer signedness issue.
5112 * intervals.c (static_offset_intervals): New function.
5113 (offset_intervals): Use it.
5115 2011-06-21 Leo Liu <sdl.web@gmail.com>
5118 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5121 * fns.c (secure_hash): Rename from crypto_hash_function and change
5122 the first arg to accept symbols.
5123 (Fsecure_hash): New primitive.
5124 (syms_of_fns): New symbols.
5126 2011-06-20 Deniz Dogan <deniz@dogan.se>
5128 * process.c (Fset_process_buffer): Clarify return value in
5131 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5133 * dispnew.c (add_window_display_history): Use BVAR.
5135 * xdisp.c (debug_method_add): Use BVAR.
5136 (check_window_end, dump_glyph_matrix, dump_glyph)
5137 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5139 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5142 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5143 check till after the cache is created in init_frame_faces.
5145 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5147 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5149 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5151 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5152 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5153 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5155 Improve buffer-overflow checking (Bug#8873).
5156 * fileio.c (Finsert_file_contents):
5157 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5158 Remove the old (too-loose) buffer overflow checks.
5159 They weren't needed, since make_gap checks for buffer overflow.
5160 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5161 The old code merely checked for Emacs fixnum overflow, and relied
5162 on undefined (wraparound) behavior. The new code avoids undefined
5163 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5165 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5166 Tune. Don't use wider integers than needed. Don't use alloca.
5167 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5169 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5171 * insdel.c, lisp.h (buffer_overflow): New function.
5172 (insert_from_buffer_1, replace_range, replace_range_2):
5173 * insdel.c (make_gap_larger):
5174 * editfns.c (Finsert_char):
5175 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5177 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5179 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5181 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5183 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5184 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5186 * fileio.c: Don't assume EMACS_INT fits in off_t.
5187 (emacs_lseek): New static function.
5188 (Finsert_file_contents, Fwrite_region): Use it.
5189 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5191 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5193 * fns.c: Don't overflow int when computing a list length.
5194 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5195 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5196 truncation on 64-bit hosts. Check for QUIT every
5197 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5198 faster and is responsive enough.
5199 (Flength): Report an error instead of overflowing an integer.
5200 (Fsafe_length): Return a float if the value is not representable
5201 as a fixnum. This shouldn't happen except in contrived situations.
5202 (Fnthcdr, Fsort): Don't assume list length fits in int.
5203 (Fcopy_sequence): Don't assume vector length fits in int.
5205 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5206 (header_size, word_size): New constants.
5207 (allocate_vectorlike): Don't check size overflow here.
5208 (allocate_vector): Check it here instead, since this is the only
5209 caller of allocate_vectorlike that could cause overflow.
5210 Check that the new vector's length is representable as a fixnum.
5212 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5213 The previous code was bogus. For example, next_almost_prime (32)
5214 returned 39, which is undesirable as it is a multiple of 3; and
5215 next_almost_prime (24) returned 25, which is a multiple of 5 so
5216 why was the code bothering to check for multiples of 7?
5218 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5220 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5222 Variadic C functions now count arguments with ptrdiff_t.
5223 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5224 Back then I didn't know that the Emacs coding style prefers signed int.
5225 Also, in the meantime I found a few more instances where arguments
5226 were being counted with int, which may truncate counts on 64-bit
5227 machines, or EMACS_INT, which may be unnecessarily wide.
5228 * lisp.h (struct Lisp_Subr.function.aMANY)
5229 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5230 Arg counts are now ptrdiff_t, not size_t.
5231 All variadic functions and their callers changed accordingly.
5232 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5233 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5234 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5235 * callint.c (Fcall_interactively): Check arg count for overflow,
5236 to avoid potential buffer overrun. Use signed char, not 'int',
5237 for 'varies' array, so that we needn't bother to check its size
5238 calculation for overflow.
5239 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5240 * eval.c (apply_lambda):
5241 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5242 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5243 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5245 * callint.c (Fcall_interactively): Don't use index var as event count.
5247 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5248 * mem-limits.h (SIZE): Remove; no longer used.
5250 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5252 Remove unnecessary casts.
5253 * xterm.c (x_term_init):
5254 * xfns.c (x_set_border_pixel):
5255 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5256 These aren't needed now that we assume ANSI C.
5258 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5259 It's more likely to cause problems (due to unsigned overflow)
5262 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5264 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5266 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5268 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5270 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5272 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5274 GLYPH_CODE_FACE returns EMACS_INT, not int.
5275 * dispextern.h (merge_faces):
5276 * xfaces.c (merge_faces):
5277 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5278 Don't assume EMACS_INT fits in int.
5280 * character.h (CHAR_VALID_P): Remove unused parameter.
5281 * fontset.c, lisp.h, xdisp.c: All uses changed.
5283 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5285 * fns.c (concat): Minor tuning based on overflow analysis.
5286 This doesn't fix any bugs. Use int to hold character, instead
5287 of constantly refetching from Emacs object. Use XFASTINT, not
5288 XINT, for value known to be a character. Don't bother comparing
5289 a single byte to 0400, as it's always less.
5291 * floatfns.c (Fexpt):
5292 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5294 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5297 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5299 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5300 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5301 incorrectly succeed when S was a string, because 4294967386 was
5302 truncated before it was used.
5304 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5305 Otherwise, an out-of-range integer could cause undefined behavior
5308 * composite.c: Use int, not EMACS_INT, for characters.
5309 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5310 EMACS_INT, for values that are known to be in character range.
5311 This doesn't fix any bugs but is the usual style inside Emacs and
5312 may generate better code on 32-bit machines.
5314 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5315 This is for reasons similar to the recent CHAR_STRING fix.
5316 * charset.c (Fencode_char): Check that character arg is actually
5317 a character. Pass an int to ENCODE_CHAR.
5318 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5319 wider than 'int', as a compile-time check to prevent future regressions
5322 * character.c (char_string): Remove unnecessary casts.
5324 Make sure a 64-bit char is never passed to CHAR_STRING.
5325 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5326 by silently ignoring the top 32 bits, allowing some values
5327 that were far too large to be valid characters.
5328 * character.h: Include <verify.h>.
5329 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5330 arguments are no wider than unsigned, as a compile-time check
5331 to prevent future regressions in this area.
5333 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5334 (Fsubst_char_in_region):
5336 * xdisp.c (decode_mode_spec_coding):
5337 Adjust to CHAR_STRING's new requirement.
5338 * editfns.c (Finsert_char, Fsubst_char_in_region):
5339 * fns.c (concat): Check that character args are actually
5340 characters. Without this test, these functions did the wrong
5341 thing with wildly out-of-range values on 64-bit hosts.
5343 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5344 These casts should not be needed on 32-bit hosts, either.
5345 * keyboard.c (read_char):
5346 * lread.c (Fload): Remove casts to unsigned.
5348 * lisp.h (UNSIGNED_CMP): New macro.
5349 This fixes comparison bugs on 64-bit hosts.
5350 (ASCII_CHAR_P): Use it.
5351 * casefiddle.c (casify_object):
5352 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5353 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5354 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5355 * dispextern.h (FACE_FROM_ID):
5356 * keyboard.c (read_char): Use UNSIGNED_CMP.
5358 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5359 not to EMACS_INT, to avoid GCC warning.
5361 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5363 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5364 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5365 isn't needed on 32-bit machines.
5367 * buffer.c (Fgenerate_new_buffer_name):
5368 Use EMACS_INT for count, not int.
5369 (advance_to_char_boundary): Return EMACS_INT, not int.
5371 * data.c (Qcompiled_function): Now static.
5373 * window.c (window_body_lines): Now static.
5375 * image.c (gif_load): Rename local to avoid shadowing.
5377 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5378 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5379 * alloc.c (make_save_value): Integer argument is now of type
5381 (mark_object): Use ptrdiff_t, not int.
5382 * lisp.h (pD): New macro.
5383 * print.c (print_object): Use it.
5385 * alloc.c: Use EMACS_INT, not int, to count objects.
5386 (total_conses, total_markers, total_symbols, total_vector_size)
5387 (total_free_conses, total_free_markers, total_free_symbols)
5388 (total_free_floats, total_floats, total_free_intervals)
5389 (total_intervals, total_strings, total_free_strings):
5390 Now EMACS_INT, not int. All uses changed.
5391 (Fgarbage_collect): Compute overall total using a double, so that
5392 integer overflow is less likely to be a problem. Check for overflow
5393 when converting back to an integer.
5394 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5395 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5396 These were 'int' variables that could overflow on 64-bit hosts;
5397 they were never used, so remove them instead of repairing them.
5398 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5399 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5400 Previously, this ceilinged at INT_MAX, but that doesn't work on
5402 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5404 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5405 (allocate_vectorlike): Check for ptrdiff_t overflow.
5406 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5407 when a (possibly-narrower) signed value would do just as well.
5408 We prefer using signed arithmetic, to avoid comparison confusion.
5410 * alloc.c: Catch some string size overflows that we were missing.
5411 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5412 for convenience in STRING_BYTES_MAX.
5413 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5414 The definition here is exact; the one in lisp.h was approximate.
5415 (allocate_string_data): Check for string overflow. This catches
5416 some instances we weren't catching before. Also, it catches
5417 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5418 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5419 and ptrdiff_t and EMACS_INT are both 64 bits.
5421 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5422 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5423 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5425 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5427 * alloc.c (Fmake_string): Check for out-of-range init.
5429 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5431 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5433 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5435 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5436 xg_get_default_scrollbar_width.
5438 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5439 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5440 (style_changed_cb): Call update_theme_scrollbar_width and call
5441 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5442 all frames (Bug#8505).
5443 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5444 Call gtk_window_set_resizable if HAVE_GTK3.
5445 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5446 and height if HAVE_GTK3 (Bug#8505).
5447 (scroll_bar_width_for_theme): New variable.
5448 (update_theme_scrollbar_width): New function.
5449 (xg_get_default_scrollbar_width): Move code to
5450 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5451 (xg_initialize): Call update_theme_scrollbar_width.
5453 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5455 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5457 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5459 * frame.c (make_frame): Call other_buffer_safely instead of
5462 * window.c (temp_output_buffer_show): Call display_buffer with
5463 second argument Vtemp_buffer_show_specifiers and reset latter
5464 immediately after the call.
5465 (Vtemp_buffer_show_specifiers): New variable.
5466 (auto_window_vscroll_p, next_screen_context_lines)
5467 (Vscroll_preserve_screen_position): Remove leading asterisks from
5470 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5472 Fix minor problems found by GCC 4.6.0 static checking.
5473 * buffer.c (Qclone_number): Remove for now, as it's unused.
5474 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5475 (record_buffer): Remove unused local.
5476 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5477 (set_frame_buffer_list): Remove; unused.
5478 * frame.h (other_visible_frames): Remove decl.
5479 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5480 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5481 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5483 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5484 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5485 Define only if HAVE_GPM.
5486 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5487 (update_hints_inhibit): Remove; never set. All uses removed.
5488 * widgetprv.h (emacsFrameClassRec): Remove decl.
5489 * window.c (delete_deletable_window): Now returns void, since it
5490 wasn't returning anything.
5491 (compare_window_configurations): Remove unused locals.
5492 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5493 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5494 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5495 the same widths as pointers. This follows up on the 2011-05-06 patch.
5496 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5497 * xterm.h: Likewise.
5498 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5500 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5502 * makefile.w32-in: Update dependencies.
5503 (LISP_H): Add lib/intprops.h.
5505 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5507 * image.c (gif_load): Add animation frame delay to the metadata.
5508 (syms_of_image): Use DEFSYM. New symbol `delay'.
5510 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5512 * window.c (delete_deletable_window): Re-add.
5513 (Fset_window_configuration): Rewrite to handle dead buffers and
5514 consequently deletable windows.
5515 (window_tree, Fwindow_tree): Remove. Supply functionality in
5517 (compare_window_configurations): Simplify code.
5519 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5521 * image.c (imagemagick_load_image): Fix type mismatch.
5522 (Fimagemagick_types): Likewise.
5524 * window.h (replace_buffer_in_windows): Declare.
5526 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5528 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5529 Qclone_number. Remove external declaration of Qdelete_window.
5530 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5532 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5533 Run Qbuffer_list_update_hook if allowed.
5534 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5535 buffer list implementation.
5536 (other_buffer_safely): New function.
5537 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5538 calls to replace_buffer_in_windows and
5539 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5541 (record_buffer): Inhibit quitting and rewrite using quittable
5542 functions. Run Qbuffer_list_update_hook if allowed.
5543 (Frecord_buffer, Funrecord_buffer): New functions.
5544 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5545 Move switch-to-buffer to window.el.
5546 (bury-buffer): Move to window.el.
5547 (Vbuffer_list_update_hook): New variable.
5549 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5552 * window.h (resize_frame_windows): Move up in code.
5553 (Fwindow_frame): Remove EXFUN.
5554 (replace_buffer_in_all_windows): Remove prototype.
5555 (replace_buffer_in_windows_safely): Add prototype.
5557 * window.c: Declare Qdelete_window static again. Move down
5558 declaration of select_count.
5559 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5560 (Fother_window): Move to window.el.
5561 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5562 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5563 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5565 (replace_buffer_in_windows): Implement by calling
5566 Qreplace_buffer_in_windows.
5567 (replace_buffer_in_all_windows): Remove with some functionality
5568 moved into replace_buffer_in_windows_safely.
5569 (replace_buffer_in_windows_safely): New function.
5570 (select_window_norecord, select_frame_norecord): Move in front
5571 of run_window_configuration_change_hook. Remove now obsolete
5573 (Fset_window_buffer): Rewrite doc-string.
5574 Call Qrecord_window_buffer.
5575 (keys_of_window): Move binding for other-window to window.el.
5577 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5579 * dispextern.h (struct image): Replace data member, whose int_val
5580 and ptr_val fields were not used by anything, with a single
5583 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5584 (gif_clear_image, gif_load, imagemagick_load_image)
5585 (gs_clear_image, gs_load): Callers changed.
5587 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5589 * buffer.h: Include <time.h>, for time_t.
5590 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5592 Fix minor problems found by static checking.
5594 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5596 Make identifiers static if they are not used in other modules.
5597 * data.c (Qcompiled_function, Qframe, Qvector):
5598 * image.c (QimageMagick, Qsvg):
5599 * minibuf.c (Qmetadata):
5600 * window.c (resize_window_check, resize_root_window): Now static.
5601 * window.h (resize_window_check, resize_root_window): Remove decls.
5603 * window.c (window_deletion_count, delete_deletable_window):
5605 (window_body_lines): Now static.
5606 (Fdelete_other_windows_internal): Mark vars as initialized.
5607 Make sure 'resize_failed' is initialized.
5608 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5609 (resize_window_apply): Remove unused local.
5610 * window.h (delete_deletable_window): Remove decl.
5612 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5613 (imagemagick_load_image): Fix pointer signedness problem by changing
5614 last arg from unsigned char * to char *. All uses changed.
5615 Also, fix a local for similar reasons.
5616 Remove unused locals. Remove locals to avoid shadowing.
5617 (fn_rsvg_handle_free): Remove; unused.
5618 (svg_load, svg_load_image): Fix pointer signedness problem.
5619 (imagemagick_load_image): Don't use garbage pointer image_wand.
5621 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5623 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5625 * image.c (gif_load): Fix omitted cast error introduced by
5628 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5630 * window.h (resize_proportionally, orig_total_lines)
5631 (orig_top_line): Remove from window structure.
5632 (set_window_height, set_window_width, change_window_heights)
5633 (Fdelete_window): Remove prototypes.
5634 (resize_frame_windows): Remove duplicate declaration.
5636 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5638 * window.h (resize_frame_windows, resize_window_check)
5639 (delete_deletable_window, resize_root_window)
5640 (resize_frame_windows): Declare prototypes.
5642 * window.c (resize_window_apply): Make definition be "static" to
5643 match the prototype.
5645 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5647 * window.c: Remove declarations of Qwindow_size_fixed,
5648 window_min_size_1, window_min_size_2, window_min_size,
5649 size_window, window_fixed_size_p, enlarge_window, delete_window.
5650 Remove static from declaration of Qdelete_window, it's
5651 temporarily needed by Fbury_buffer.
5652 (replace_window): Don't assign orig_top_line and
5654 (Fdelete_window, delete_window): Remove. Window deletion is
5655 handled by window.el.
5656 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5657 Replace Fdelete_window calls with calls to Qdelete_window.
5658 (Fdelete_other_windows): Remove. Deleting other windows is
5659 handled by window.el.
5660 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5661 handled in window.el.
5662 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5663 Window minimum sizes are handled in window.el.
5664 (shrink_windows, size_window, set_window_height)
5665 (set_window_width, change_window_heights, window_height)
5666 (window_width, CURBEG, CURSIZE, enlarge_window)
5667 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5668 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5669 handled in window.el.
5670 (make_dummy_parent): Rename to make_parent_window and give it a
5671 second argument horflag.
5672 (make_window): Don't set resize_proportionally any more.
5673 (Fsplit_window): Remove. Windows are split in window.el.
5674 (save_restore_action, save_restore_orig_size)
5675 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5676 Resize mini windows in window.el.
5677 (grow_mini_window, shrink_mini_window): Implement by calling
5678 Qresize_root_window_vertically, resize_window_check and
5679 resize_window_apply.
5680 (saved_window, Fset_window_configuration, save_window_save):
5681 Do not handle orig_top_line, orig_total_lines, and
5682 resize_proportionally.
5683 (window_min_height, window_min_width): Move to window.el.
5684 (keys_of_window): Move bindings for delete-other-windows,
5685 split-window, delete-window and enlarge-window to window.el.
5687 * buffer.c: Temporarily extern Qdelete_window.
5688 (Fbury_buffer): Temporarily call Qdelete_window instead of
5689 Fdelete_window (Fbury_buffer will move to window.el soon).
5691 * frame.c (set_menu_bar_lines_1): Remove code handling
5692 orig_top_line and orig_total_lines.
5694 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5695 set_window_height but set heights directly.
5696 (change_frame_size_1): Use resize_frame_windows.
5698 * xdisp.c (init_xdisp): Don't use set_window_height but set
5701 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5702 Use resize_frame_windows instead of change_window_heights and run
5703 run_window_configuration_change_hook.
5705 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5706 instead of change_window_heights and run
5707 run_window_configuration_change_hook.
5709 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5711 * window.c (replace_window): Rename second argument REPLACEMENT to
5712 NEW. New third argument SETFLAG. Rewrite.
5713 (delete_window, make_dummy_parent): Call replace_window with
5715 (window_list_1): Move down in code.
5716 (run_window_configuration_change_hook): Move set_buffer part
5717 before select_frame_norecord part in order to unwind correctly.
5718 Rename count1 to count.
5719 (recombine_windows, delete_deletable_window, resize_root_window)
5720 (Fdelete_other_windows_internal)
5721 (Frun_window_configuration_change_hook, make_parent_window)
5722 (resize_window_check, resize_window_apply, Fresize_window_apply)
5723 (resize_frame_windows, Fsplit_window_internal)
5724 (Fdelete_window_internal, Fresize_mini_window_internal):
5726 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5728 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5730 * window.h (window): Add some new members to window structure -
5731 normal_lines, normal_cols, new_total, new_normal, clone_number,
5732 splits, nest, prev_buffers, next_buffers.
5733 (WINDOW_TOTAL_SIZE): Move here from window.c.
5734 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5736 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5738 (make_dummy_parent): Set new members of windows structure.
5739 (make_window): Move down in code. Handle new members of window
5741 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5742 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5743 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5744 (Fset_window_prev_buffers, Fwindow_next_buffers)
5745 (Fset_window_next_buffers, Fset_window_clone_number):
5747 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5748 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5750 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5751 Argument WINDOW can be now internal window too.
5752 (Fwindow_use_time): Move up in code.
5753 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5755 (Fset_window_configuration, saved_window)
5756 (Fcurrent_window_configuration, save_window_save): Handle new
5757 members of window structure.
5758 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5759 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5760 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5761 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5762 Qget_mru_window, Qresize_root_window,
5763 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5764 Qauto_buffer_name; staticpro them.
5766 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5768 * window.c (Fwindow_total_size, Fwindow_left_column)
5769 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5770 (Fwindow_list_1): New functions.
5771 (window_box_text_cols): Replace with window_body_cols.
5772 (Fwindow_width, Fscroll_left, Fscroll_right):
5773 Use window_body_cols instead of window_box_text_cols.
5774 (delete_window, Fset_window_configuration):
5775 Call delete_all_subwindows with window as argument.
5776 (delete_all_subwindows): Take a window as argument and not a
5778 (window_loop): Remove handling of GET_LRU_WINDOW and
5780 (Fget_lru_window, Fget_largest_window): Move to window.el.
5782 * window.h: Extern window_body_cols instead of
5783 window_box_text_cols. delete_all_subwindows now takes a
5784 Lisp_Object as argument.
5786 * indent.c (compute_motion, Fcompute_motion):
5787 Use window_body_cols instead of window_box_text_cols.
5789 * frame.c (delete_frame): Call delete_all_subwindows with root
5792 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5794 * fns.c (Fputhash): Document return value.
5796 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5798 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5800 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5802 Cons<->int and similar integer overflow fixes (Bug#8794).
5804 Check for overflow when converting integer to cons and back.
5805 * charset.c (Fdefine_charset_internal, Fdecode_char):
5806 Use cons_to_unsigned to catch overflow.
5807 (Fencode_char): Use INTEGER_TO_CONS.
5808 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5809 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5810 * data.c (long_to_cons, cons_to_long): Remove.
5811 (cons_to_unsigned, cons_to_signed): New functions.
5812 These signal an error for invalid or out-of-range values.
5813 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5814 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5815 * font.c (Ffont_variation_glyphs):
5816 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5817 * lisp.h: Include <intprops.h>.
5818 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5819 (cons_to_signed, cons_to_unsigned): New decls.
5820 (long_to_cons, cons_to_long): Remove decls.
5821 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5822 (Fprimitive_undo): Use CONS_TO_INTEGER.
5823 * xfns.c (Fx_window_property): Likewise.
5824 * xselect.c: Include <limits.h>.
5825 (x_own_selection, selection_data_to_lisp_data):
5826 Use INTEGER_TO_CONS.
5827 (x_handle_selection_request, x_handle_selection_clear)
5828 (x_get_foreign_selection, Fx_disown_selection_internal)
5829 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5830 (lisp_data_to_selection_data): Use cons_to_unsigned.
5831 (x_fill_property_data): Use cons_to_signed.
5832 Report values out of range.
5834 Check for buffer and string overflow more precisely.
5835 * buffer.h (BUF_BYTES_MAX): New macro.
5836 * lisp.h (STRING_BYTES_MAX): New macro.
5837 * alloc.c (Fmake_string):
5838 * character.c (string_escape_byte8):
5839 * coding.c (coding_alloc_by_realloc):
5840 * doprnt.c (doprnt):
5841 * editfns.c (Fformat):
5843 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5844 since they may not be the same number.
5845 * editfns.c (Finsert_char):
5846 * fileio.c (Finsert_file_contents):
5847 Likewise for BUF_BYTES_MAX.
5849 * image.c: Use ptrdiff_t, not int, for sizes.
5850 (slurp_file): Switch from int to ptrdiff_t.
5852 (slurp_file): Check that file size fits in both size_t (for
5853 malloc) and ptrdiff_t (for sanity and safety).
5855 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5856 if b->modtime has its maximal value.
5858 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5860 Don't assume time_t can fit into int.
5861 * buffer.h (struct buffer.modtime): Now time_t, not int.
5862 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5863 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5865 Minor fixes for signed vs unsigned integers.
5866 * character.h (MAYBE_UNIFY_CHAR):
5867 * charset.c (maybe_unify_char):
5868 * keyboard.c (read_char, reorder_modifiers):
5869 XINT -> XFASTINT, since the integer must be nonnegative.
5870 * ftfont.c (ftfont_spec_pattern):
5871 * keymap.c (access_keymap, silly_event_symbol_error):
5872 XUINT -> XFASTINT, since the integer must be nonnegative.
5873 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5874 since it makes no difference and we prefer signed.
5875 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5876 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5879 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5881 * window.h (Fwindow_frame): Declare.
5883 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5885 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5886 (SPARE_MEMORY): Always define.
5887 (LARGE_REQUEST): Remove.
5888 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5890 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5892 * lisp.h: Move EXFUNS for Fframe_root_window,
5893 Fframe_first_window and Fset_frame_selected_window to window.h.
5895 * window.h: Move EXFUNS for Fframe_root_window,
5896 Fframe_first_window and Fset_frame_selected_window here from
5899 * frame.c (Fwindow_frame, Fframe_first_window)
5900 (Fframe_root_window, Fframe_selected_window)
5901 (Fset_frame_selected_window): Move to window.c.
5902 (Factive_minibuffer_window): Move to minibuf.c.
5903 (Fother_visible_frames_p): New function.
5905 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5907 * window.c (decode_window, decode_any_window): Move up in code.
5908 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5909 (inhibit_frame_unsplittable): Remove unused variable.
5910 (Fwindow_buffer): Move up and rewrite doc-string.
5911 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5912 (Fwindow_prev): New functions.
5913 (Fwindow_frame): Move here from frame.c. Accept any window as
5915 (Fframe_root_window, Fframe_first_window)
5916 (Fframe_selected_window): Move here from frame.c. Accept frame
5917 or arbitrary window as argument. Update doc-strings.
5918 (Fminibuffer_window): Move up in code.
5919 (Fwindow_minibuffer_p): Move up in code and simplify.
5920 (Fset_frame_selected_window): Move here from frame.c.
5922 (Fselected_window, select_window, Fselect_window): Move up in
5923 code. Minor doc-string fixes.
5925 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5927 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5928 Do not assume that spare memory exists; that assumption is valid
5929 only if SYSTEM_MALLOC.
5930 (LARGE_REQUEST): New macro, so that the issue of large requests
5931 is separated from the issue of spare memory.
5933 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5935 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5938 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5940 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5943 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5945 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5947 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5949 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5950 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5952 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5954 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5956 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5958 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5959 (x_clipboard_manager_save): Add return value.
5960 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5962 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5963 Obey Vx_select_enable_clipboard_manager. Catch errors in
5964 x_clipboard_manager_save (Bug#8779).
5965 (Vx_select_enable_clipboard_manager): New variable.
5966 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5968 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5970 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5972 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5974 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5975 in the current matrix if keep_current_p is non-zero.
5977 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5979 * bidi.c (bidi_level_of_next_char): Fix last change.
5981 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5983 Support bidi reordering of text covered by display properties.
5985 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5986 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5987 (bidi_cache_search, bidi_cache_iterator_state)
5988 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5989 (bidi_level_of_next_char, bidi_move_to_visually_next):
5990 Support character positions inside a run of characters covered by a
5992 (bidi_paragraph_init, bidi_resolve_explicit_1)
5993 (bidi_level_of_next_char): Call bidi_fetch_char and
5994 bidi_fetch_char_advance instead of FETCH_CHAR and
5996 (bidi_init_it): Initialize new members.
5997 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5999 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6000 instead of using explicit *_CHAR codes.
6001 (bidi_resolve_explicit, bidi_resolve_weak):
6002 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6003 bidirectional text is supported only in multibyte buffers.
6004 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6005 it to initialize the frame_window_p member of struct bidi_it.
6006 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6007 (bidi_resolve_explicit, bidi_resolve_weak)
6008 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6009 bidi_it->nchars is non-positive.
6010 (bidi_level_of_next_char): Don't try to lookup the cache for the
6011 next/previous character if nothing is cached there yet, or if we
6012 were just reseat()'ed to a new position.
6014 * xdisp.c (set_cursor_from_row): Set start and stop points
6015 according to the row's direction when priming the loop that looks
6016 for the glyph on which to display cursor.
6017 (single_display_spec_intangible_p): Function deleted.
6018 (display_prop_intangible_p): Reimplement to call
6019 handle_display_spec instead of single_display_spec_intangible_p.
6020 Accept 3 additional arguments needed by handle_display_spec.
6021 This fixes incorrect cursor motion across display property with complex
6022 values: lists, `(when COND...)' forms, etc.
6023 (single_display_spec_string_p): Support property values that are
6024 lists with the argument STRING its top-level element.
6025 (display_prop_string_p): Fix the condition for processing a
6026 property that is a list to be consistent with handle_display_spec.
6027 (handle_display_spec): New function, refactored from the
6028 last portion of handle_display_prop.
6029 (compute_display_string_pos): Accept additional argument
6030 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6031 value of a `display' property is a "replacing spec".
6032 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6033 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6034 the display property, but just return a value indicating whether
6035 the display property will replace the characters it covers.
6036 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6037 frame_window_p members of struct bidi_it.
6038 (compute_display_string_pos, compute_display_string_end):
6040 (push_it): Accept second argument POSITION, where pop_it should
6041 jump to continue iteration.
6042 (reseat_1): Initialize bidi_it.disp_pos.
6044 * keyboard.c (adjust_point_for_property): Adjust the call to
6045 display_prop_intangible_p to its new signature.
6047 * dispextern.h (struct bidi_it): New member frame_window_p.
6048 (bidi_init_it): Update prototypes.
6049 (display_prop_intangible_p): Update prototype.
6050 (compute_display_string_pos, compute_display_string_end):
6052 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6055 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6057 Malloc failure behavior now depends on size of allocation.
6058 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6059 * lisp.h: Change signatures accordingly.
6060 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6061 All callers changed. (Bug#8762)
6063 * gnutls.c: Use Emacs's memory allocators.
6064 Without this change, the gnutls library would invoke malloc etc.
6065 directly, which causes problems on non-SYNC_INPUT hosts, and which
6066 runs afoul of improving memory_full behavior. (Bug#8761)
6067 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6068 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6069 xfree instead of the default malloc, realloc, free.
6070 (Fgnutls_boot): No need to check for memory allocation failure,
6071 since xmalloc does that for us.
6073 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6074 * category.c (hash_get_category_set):
6075 * ccl.c (ccl_driver):
6076 * charset.c (Fdefine_charset_internal):
6077 * charset.h (struct charset.hash_index):
6078 * composite.c (get_composition_id, gstring_lookup_cache)
6079 (composition_gstring_put_cache):
6080 * composite.h (struct composition.hash_index):
6081 * dispextern.h (struct image.hash):
6082 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6083 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6084 (hashfn_equal, hashfn_user_defined, make_hash_table)
6085 (maybe_resize_hash_table, hash_lookup, hash_put)
6086 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6087 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6088 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6089 * image.c (make_image, search_image_cache, lookup_image)
6090 (xpm_put_color_table_h):
6091 * lisp.h (struct Lisp_Hash_Table):
6092 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6093 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6094 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6095 * alloc.c (allocate_vectorlike):
6096 Check for overflow in vector size calculations.
6097 * ccl.c (ccl_driver):
6098 Check for overflow when converting EMACS_INT to int.
6099 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6100 need to be updated by these changes.
6101 * fns.c (make_hash_table, maybe_resize_hash_table):
6102 Check for integer overflow with large hash tables.
6103 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6104 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6105 (SXHASH_REDUCE): New macro.
6106 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6107 Use it instead of discarding useful hash info with large hash values.
6108 (sxhash_float): New function.
6109 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6110 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6111 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6112 Rewrite to use FIXNUM_BITS, as this simplifies things.
6113 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6114 Adjust signatures to match updated version of code.
6115 (consing_since_gc): Now EMACS_INT, since a single hash table can
6116 use more than INT_MAX bytes.
6118 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6120 Make it possible to build with GCC-4.6+ -O2 -flto.
6122 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6124 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6126 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6127 Call minibuffer-inactive-mode.
6129 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6131 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6132 Update dependencies.
6134 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6136 * data.c (init_data): Remove code for UTS, this system is not
6139 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6141 Don't force ./temacs to start in terminal mode.
6143 * frame.c (make_initial_frame): Initialize faces in all cases, not
6144 only when CANNOT_DUMP is defined.
6145 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6147 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6149 * dispnew.c (add_window_display_history): Use const for the string
6150 pointer. Remove declaration, not needed.
6152 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6154 Use 'inline', not 'INLINE'.
6155 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6156 * alloc.c, fontset.c (INLINE): Remove.
6157 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6158 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6159 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6160 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6161 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6163 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6165 Make it possible to run ./temacs.
6167 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6168 syms_of_callproc does the same thing. Remove test for
6169 "initialized", do it in the caller.
6170 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6172 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6174 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6175 (read_minibuf): Use get_minibuffer.
6176 (syms_of_minibuf): Use DEFSYM.
6177 (Qmetadata): New var.
6178 * data.c (Qbuffer): Don't make it static.
6179 (syms_of_data): Use DEFSYM.
6181 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6183 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6184 (CCL_CODE_MIN): New macro.
6186 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6188 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6190 * eval.c (Qdebug): Now static.
6191 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6192 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6193 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6195 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6197 * image.c: Various fixes to ImageMagick code comments.
6198 (Fimagemagick_types): Doc fix.
6200 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6202 Minor fixes prompted by GCC 4.6.0 warnings.
6204 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6206 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6207 (x_clipboard_manager_save_all): Move extern decl to ...
6208 * xterm.h: ... here, so that it can be checked for consistency.
6210 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6212 * xselect.c (x_clipboard_manager_save_frame)
6213 (x_clipboard_manager_save_all): New functions.
6214 (Fx_clipboard_manager_save): Lisp function deleted.
6216 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6217 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6219 * xterm.h: Update prototype.
6221 2011-05-28 William Xu <william.xwl@gmail.com>
6223 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6226 2011-05-28 Jim Meyering <meyering@redhat.com>
6228 Avoid a sign-extension bug in crypto_hash_function.
6229 * fns.c (to_uchar): Define.
6230 (crypto_hash_function): Use it to convert some newly-signed
6231 variables to unsigned, to avoid sign-extension bugs. For example,
6232 without this change, (md5 "truc") would evaluate to
6233 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6234 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6235 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6237 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6239 Integer overflow fixes.
6241 * dbusbind.c: Serial number integer overflow fixes.
6242 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6243 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6244 to hold a serial number that is too large for a fixnum.
6245 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6246 Check for serial numbers out of range. Decode any serial number
6247 that was so large that it became a float. (Bug#8722)
6249 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6250 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6251 Use XFASTINT rather than XUINT when numbers are nonnegative.
6252 (xd_append_arg, Fdbus_method_return_internal):
6253 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6254 arguments, check that Lisp number is nonnegative, rather than
6255 silently wrapping negative numbers around. (Bug#8722)
6256 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6259 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6261 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6263 ccl: Add integer overflow checks.
6264 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6265 (IN_INT_RANGE): New macros.
6266 (ccl_driver): Use them to check for integer overflow when
6267 decoding a CCL program. Many of the new checks are whether XINT (x)
6268 fits in int; it doesn't always, on 64-bit hosts. The new version
6269 doesn't catch all possible integer overflows, but it's an
6270 improvement. (Bug#8719)
6272 * alloc.c (make_event_array): Use XINT, not XUINT.
6273 There's no need for unsigned here.
6275 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6276 This follows up to the 2011-05-06 change that substituted uintptr_t
6277 for EMACS_INT. This case wasn't caught back then.
6279 Rework Fformat to avoid integer overflow issues.
6280 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6281 now (part of C89). Include <verify.h>.
6282 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6283 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6284 (Fformat): Avoid the prepass trying to compute sizes; it was only
6285 approximate and thus did not catch overflow reliably. Instead, walk
6286 through the format just once, formatting and computing sizes as we go,
6287 checking for integer overflow at every step, and allocating a larger
6288 buffer as needed. Keep track separately whether the format is
6289 multibyte. Keep only the most-recently calculated precision, rather
6290 than them all. Record whether each argument has been converted to
6291 string. Use EMACS_INT, not int, for byte and char and arg counts.
6292 Support field widths and precisions larger than INT_MAX. Avoid
6293 sprintf's undefined behavior with conversion specifications such as %#d
6294 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6295 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6296 formatting out-of-range floating point numbers with int
6299 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6301 * data.c: Avoid integer truncation in expressions involving floats.
6302 * data.c: Include <intprops.h>.
6303 (arith_driver): When there's an integer overflow in an expression
6304 involving floating point, convert the integers to floating point
6305 so that the resulting value does not suffer from catastrophic
6306 integer truncation. For example, on a 64-bit host (* 4
6307 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6308 Do not rely on undefined behavior after integer overflow.
6310 merge count_size_as_multibyte, parse_str_to_multibyte
6311 * character.c, character.h (count_size_as_multibyte):
6312 Rename from parse_str_to_multibyte; all uses changed.
6313 Check for integer overflow.
6314 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6315 since it's now a duplicate of the other. This is more of
6316 a character than a buffer op, so better that it's in character.c.
6317 * fns.c, print.c: Adjust to above changes.
6319 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6321 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6323 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6325 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6326 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6327 (x_clipboard_manager_save): Now static.
6328 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6330 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6331 (crypto_hash_function): Now static.
6332 Fix pointer signedness problems. Avoid unnecessary initializations.
6334 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6336 * termhooks.h (Vselection_alist): Make it terminal-local.
6338 * terminal.c (create_terminal): Initialize it.
6340 * xselect.c: Support for clipboard managers.
6341 (Vselection_alist): Move to termhooks.h as terminal-local var.
6342 (LOCAL_SELECTION): New macro.
6343 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6344 (symbol_to_x_atom): Remove gratuitous arg.
6345 (x_handle_selection_request, lisp_data_to_selection_data)
6346 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6347 (x_own_selection, x_get_local_selection, x_convert_selection):
6348 New arg, specifying work frame. Use terminal-local Vselection_alist.
6349 (some_frame_on_display): Delete unused function.
6350 (Fx_own_selection_internal, Fx_get_selection_internal)
6351 (Fx_disown_selection_internal, Fx_selection_owner_p)
6352 (Fx_selection_exists_p): New optional frame arg.
6353 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6354 (x_handle_selection_clear): Don't treat other terminals with the
6355 same keyboard specially. Use the terminal-local Vselection_alist.
6356 (x_clear_frame_selections): Use Frun_hook_with_args.
6358 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6360 * xterm.h: Add support for those atoms.
6362 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6364 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6365 (converted_selections, conversion_fail_tag): New global variables.
6366 (x_selection_request_lisp_error): Free the above.
6367 (x_get_local_selection): Remove unnecessary code.
6368 (x_reply_selection_request): Args changed; handle arbitrary array
6369 of converted selections stored in converted_selections.
6370 Separate the XChangeProperty and SelectionNotify steps.
6371 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6372 (x_convert_selection): New function.
6373 (x_handle_selection_event): Simplify.
6374 (x_get_foreign_selection): Don't ignore incoming requests while
6375 waiting for an answer; this will fail when we implement
6376 SAVE_TARGETS, and seems unnecessary anyway.
6377 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6378 (Vx_sent_selection_functions): Doc fix.
6380 2011-05-26 Leo Liu <sdl.web@gmail.com>
6382 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6384 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6386 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6388 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6389 for fringe update if it has periodic bitmap.
6390 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6391 and fringe_bitmap_periodic_p.
6393 * fringe.c (get_fringe_bitmap_data): New function.
6394 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6395 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6396 row. Mark glyph row for fringe update if periodicity changed.
6398 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6399 for fringe update unless it has periodic bitmap.
6401 2011-05-25 Kenichi Handa <handa@m17n.org>
6403 * xdisp.c (get_next_display_element): Set correct it->face_id for
6404 a static composition.
6406 2011-05-24 Leo Liu <sdl.web@gmail.com>
6409 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6411 * fns.c (crypto_hash_function, Fsha1): New function.
6412 (Fmd5): Use crypto_hash_function.
6413 (syms_of_fns): Add Ssha1.
6415 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6417 * gnutls.c: Remove unused macros.
6418 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6419 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6420 Remove macros that are defined and never used.
6421 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6423 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6425 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6426 (Fx_get_selection_internal): Minor cleanup.
6427 (Fx_own_selection_internal): Rename arguments for consistency with
6430 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6432 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6434 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6436 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6438 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6440 * dispnew.c (scrolling_window): Don't exclude the case that the
6441 last enabled row in the desired matrix touches the bottom boundary.
6443 2011-05-21 Glenn Morris <rgm@gnu.org>
6445 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6446 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6447 and add some more files.
6449 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6451 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6452 report_file_error introduced by the change from 2011-05-07.
6454 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6456 * systime.h (Time): Define only if emacs is defined.
6457 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6458 where the include path doesn't have X11/X.h by default. See
6459 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6461 2011-05-20 Kenichi Handa <handa@m17n.org>
6463 * composite.c (find_automatic_composition): Fix previous change.
6465 2011-05-20 Glenn Morris <rgm@gnu.org>
6467 * lisp.mk: New file, split from Makefile.in.
6468 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6469 (shortlisp): Remove.
6470 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6472 2011-05-19 Glenn Morris <rgm@gnu.org>
6474 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6475 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6476 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6477 (lisp): Set the order to that of loadup.el.
6478 (shortlisp): Make it a copy of $lisp.
6479 (SOME_MACHINE_LISP): Remove.
6480 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6481 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6483 2011-05-18 Kenichi Handa <handa@m17n.org>
6485 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6486 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6487 (find_automatic_composition): Mostly rewrite for efficiency.
6489 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6491 * makefile.w32-in: Update dependencies.
6493 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6495 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6496 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6498 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6500 Fix some integer overflow issues, such as string length overflow.
6502 * insdel.c (count_size_as_multibyte): Check for string overflow.
6504 * character.c (lisp_string_width): Check for string overflow.
6505 Use EMACS_INT, not int, for string indexes and lengths; in
6506 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6507 the resulting string length overflows an EMACS_INT; instead,
6508 report a string overflow if no precision given. When checking for
6509 precision exhaustion, use a check that cannot possibly have
6510 integer overflow. (Bug#8675)
6511 * character.h (lisp_string_width): Adjust to new signature.
6513 * alloc.c (string_overflow): New function.
6514 (Fmake_string): Use it. This doesn't change behavior, but saves
6515 a few bytes and will simplify future changes.
6516 * character.c (string_escape_byte8): Likewise.
6517 * lisp.h (string_overflow): New decl.
6519 Fixups, following up to the user-interface timestamp change.
6520 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6521 for UI timestamps, instead of unsigned long.
6522 * msdos.c (mouse_get_pos): Likewise.
6523 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6524 * w32gui.h (Time): Define by including "systime.h" rather than by
6525 declaring it ourselves. (Bug#8664)
6527 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6528 * image.c (clear_image_cache): Likewise.
6530 * term.c (term_mouse_position): Don't assume time_t wraparound.
6532 Be more systematic about user-interface timestamps.
6533 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6534 and sometimes 'EMACS_UINT', to represent these timestamps.
6535 This change causes it to use 'Time' uniformly, as that's what X uses.
6536 This makes the code easier to follow, and makes it easier to catch
6537 integer overflow bugs such as Bug#8664.
6538 * frame.c (Fmouse_position, Fmouse_pixel_position):
6539 Use Time, not unsigned long, for user-interface timestamps.
6540 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6541 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6542 * keyboard.h (last_event_timestamp): Likewise.
6543 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6544 * menu.h (xmenu_show): Likewise.
6545 * term.c (term_mouse_position): Likewise.
6546 * termhooks.h (struct input_event.timestamp): Likewise.
6547 (struct terminal.mouse_position_hook): Likewise.
6548 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6549 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6550 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6551 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6553 * menu.h, termhooks.h: Include "systime.h", for Time.
6555 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6556 Don't assume that the difference between two unsigned long values
6557 can fit into an integer. At this point, we know button_down_time
6558 <= event->timestamp, so the difference must be nonnegative, so
6559 there's no need to cast the result if double-click-time is
6560 nonnegative, as it should be; check that it's nonnegative, just in
6561 case. This bug is triggered when events are more than 2**31 ms
6562 apart (about 25 days). (Bug#8664)
6564 * xselect.c (last_event_timestamp): Remove duplicate decl.
6565 (x_own_selection): Remove needless cast to unsigned long.
6567 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6568 that always fit in int. Use a sentinel instead of a counter, to
6569 avoid a temp and to allay GCC's concerns about possible int overflow.
6570 * frame.h (struct frame): Use int for menu_bar_items_used
6571 instead of EMACS_INT, since it always fits in int.
6573 * menu.c (grow_menu_items): Check for int overflow.
6575 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6577 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6578 Before, the code was not consistent. These values cannot exceed
6579 2**31 - 1 so there's no need to make them unsigned.
6580 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6581 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6582 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6584 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6586 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6587 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6588 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6589 presumably because the widths might not match.
6591 * window.c (size_window): Avoid needless test at loop start.
6593 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6595 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6597 2011-05-12 Drew Adams <drew.adams@oracle.com>
6599 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6601 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6603 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6604 `width' to `bar_area_x' and `bar_area_width', respectively.
6605 (x_scroll_run): Take account of fringe background extension.
6607 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6608 Rename local vars `left' and `width' to `bar_area_x' and
6609 `bar_area_width', respectively.
6610 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6611 background extension.
6613 2011-05-10 Jim Meyering <meyering@redhat.com>
6615 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6617 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6619 * image.c (Finit_image_library): Return t for built-in image types,
6620 like pbm and xbm. (Bug#8640)
6622 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6624 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6626 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6628 * w32console.c (Fset_screen_color): Doc fix.
6629 (Fget_screen_color): New function.
6630 (syms_of_ntterm): Defsubr it.
6632 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6633 unlink the temporary file if Fcall_process didn't create it in the
6635 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6636 child process will be redirected to a file specified with `:file'.
6637 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6638 cue to call_process_cleanup not to close that handle.
6640 2011-05-07 Ben Key <bkey76@gmail.com>
6642 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6643 one of two shell specific rules, either bootstrap-temacs-CMD or
6644 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6645 to the previous implementation of the bootstrap-temacs rule.
6646 The bootstrap-temacs-CMD rule is similar to the previous
6647 implementation of the bootstrap-temacs rule except that it
6648 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6651 These changes, along with some changes to nt/configure.bat,
6652 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6653 earlier fix to add support for --cflags and --ldflags options
6654 that include quotes so that it works whether make uses cmd or
6657 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6659 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6660 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6662 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6663 a string. Handle both cases.
6664 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6665 (Fdbus_register_method): Use Qinvalid_function.
6667 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6669 * makefile.w32-in: Update dependencies.
6670 (LISP_H): Add inttypes.h and stdin.h.
6671 (PROCESS_H): Add unistd.h.
6673 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6675 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6676 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6678 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6680 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6682 * term.c (vfatal): Remove stray call to va_end.
6683 It's not needed and the C Standard doesn't allow it here anyway.
6685 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6686 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6688 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6691 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6693 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6695 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6697 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6699 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6701 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6702 * charset.c (Fdefine_charset_internal): Don't initialize
6703 charset.code_space[15]. The value was garbage, on hosts with
6704 32-bit int (Bug#8600).
6706 * lread.c (read_integer): Be more consistent with string-to-number.
6707 Use string_to_number to do the actual conversion; this avoids
6708 rounding errors and fixes some other screwups. Without this fix,
6709 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6710 (digit_to_number): Move earlier, for benefit of read_integer.
6711 Return -1 if the digit is out of range for the base, -2 if it is
6712 not a digit in any supported base. (Bug#8602)
6714 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6716 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6717 to match comment at start of function. This also removes a
6718 GCC warning about overflow in a 32+64-bit port.
6720 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6722 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6723 Reported by Stefan Monnier in
6724 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6725 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6726 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6728 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6729 (EMACS_UINTPTR): Likewise, with uintptr_t.
6731 * lisp.h: Prefer 64-bit EMACS_INT if available.
6732 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6733 on 32-bit hosts that have 64-bit int, so that they can access
6735 However, temporarily disable this change unless the temporary
6736 symbol WIDE_EMACS_INT is defined.
6738 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6740 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6741 This removes an assumption that EMACS_INT and long are the same
6742 width as pointers. The assumption is true for Emacs porting targets
6743 now, but we want to make other targets possible.
6744 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6745 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6746 In the rest of the code, change types of integers that hold casted
6747 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6748 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6749 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6750 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6751 No need to cast type when ORing.
6752 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6753 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6754 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6755 assume EMACS_INT is the same width as char *.
6756 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6757 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6758 Remove no-longer-needed casts.
6759 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6760 (xg_tool_bar_help_callback, xg_make_tool_item):
6761 Use EMACS_INTPTR to hold an integer
6762 that will be cast to void *; this can avoid a GCC warning
6763 if EMACS_INT is not the same width as void *.
6764 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6765 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6766 (current_message_1, set_message_1):
6767 Use a local to convert to proper width without a cast.
6768 * xmenu.c (dialog_selection_callback): Likewise.
6770 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6771 Also, don't assume VALBITS / RAND_BITS is less than 5,
6772 and don't rely on undefined behavior when shifting a 1 left into
6774 * lisp.h (get_random): Change signature to match.
6776 * lread.c (hash_string): Use size_t, not int, for hash computation.
6777 Normally we prefer signed values; but hashing is special, because
6778 it's better to use unsigned division on hash table sizes so that
6779 the remainder is nonnegative. Also, size_t is the natural width
6780 for hashing into memory. The previous code used 'int', which doesn't
6781 retain enough info to hash well into very large tables.
6782 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6784 * dbusbind.c: Don't possibly lose pointer info when converting.
6785 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6786 Use XPNTR rather than XHASH, so that the high-order bits of
6787 the pointer aren't lost when converting through void *.
6789 * eval.c (Fautoload): Don't double-shift a pointer.
6791 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6793 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6795 * gnutls.c (DEF_GNUTLS_FN):
6796 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6798 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6800 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6803 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6805 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6806 New version that can reserve upto 2GB of heap space.
6808 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6810 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6812 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6814 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6815 `gnutls_certificate_set_x509_key_file'.
6817 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6819 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6820 Update dependencies.
6822 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6824 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6825 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6826 Remove unused parameter `fildes'.
6827 * process.c (read_process_output, send_process): Don't pass it.
6829 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6831 Fix previous change: the library cache is defined in w32.c.
6832 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6833 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6835 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6837 Implement dynamic loading of GnuTLS on Windows.
6839 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6840 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6841 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6844 * gnutls.c (Qgnutls_dll): Define.
6845 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6846 (gnutls_*): Declare function pointers.
6847 (init_gnutls_functions): New function to initialize function pointers.
6848 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6849 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6850 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6851 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6852 (emacs_gnutls_write, emacs_gnutls_read)
6853 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6854 (Fgnutls_available_p): New function.
6855 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6856 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6857 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6859 * image.c: Include w32.h.
6860 (Vimage_type_cache): Delete.
6861 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6862 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6863 (w32_delayed_load): Move to w32.c.
6865 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6867 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6868 (w32_delayed_load): Move from image.c. When loading a library, record
6869 its filename in the :loaded-from property of the library id.
6870 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6871 Initialize and staticpro them.
6872 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6874 * process.c: Include lisp.h before w32.h, not after.
6875 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6876 instead of gnutls_record_check_pending.
6878 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6880 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6882 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6883 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6886 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6888 * xterm.c (x_set_frame_alpha): Do not set property on anything
6889 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6891 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6893 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6895 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6897 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6898 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6899 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6900 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6901 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6902 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6903 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6904 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6905 (Qgnutls_bootprop_callbacks_verify): Make static.
6907 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6909 * callproc.c: Indentation fixup.
6911 * sysdep.c (wait_for_termination_1): Make static.
6912 (wait_for_termination, interruptible_wait_for_termination):
6913 Move after wait_for_termination_1.
6915 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6917 * sysdep.c (interruptible_wait_for_termination): New function
6918 which is like wait_for_termination, but allows keyboard
6921 * callproc.c (Fcall_process): Add (:file "file") as an option for
6923 (Fcall_process_region): Ditto.
6925 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6927 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6928 rather than `XVECTOR (FOO)->size'.
6930 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6931 inttypes.h, as a gnulib replacement is used if it not available in
6934 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6936 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6937 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6938 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6940 * coding.c (coding_alloc_by_realloc): Error out if destination
6941 will grow beyond MOST_POSITIVE_FIXNUM.
6942 (decode_coding_emacs_mule): Abort if there isn't enough place in
6943 charbuf for the composition carryover bytes. Reserve an extra
6944 space for up to 2 characters produced in a loop.
6945 (decode_coding_iso_2022): Abort if there isn't enough place in
6946 charbuf for the composition carryover bytes.
6948 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6950 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6951 aborting when %lld or %lll format is passed.
6952 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6953 %llo or %llx format is passed. (Bug#8545)
6955 * window.c (window_scroll_line_based): Use a marker instead of
6956 simple variables to record original value of point. (Bug#7952)
6958 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6959 produced by %s or %c overflows available buffer space. (Bug#8545)
6961 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6963 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6964 (SIZE_MAX): Move defn after all includes, as they might #define it.
6966 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6968 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6970 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6972 * keyboard.c (Qdelayed_warnings_hook): Define.
6973 (command_loop_1): Run `delayed-warnings-hook'
6974 if Vdelayed_warnings_list is non-nil.
6975 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6976 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6978 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6980 * doprnt.c (doprnt): Don't return value smaller than the buffer
6981 size if the message was truncated. (Bug#8545).
6983 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6985 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6986 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6988 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6990 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6992 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6994 * makefile.w32-in: Update dependencies.
6996 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6998 Improve `doprnt' and its usage. (Bug#8545)
6999 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7000 `format_end'. Remove support for %l as a conversion specifier.
7001 Don't use xrealloc. Improve diagnostics when the %l size modifier
7002 is used. Update the commentary.
7004 * eval.c (verror): Simplify calculation of size_t.
7006 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7009 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7011 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7014 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7016 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7017 This makes this file independent of the recent pseudovector change.
7019 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7021 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7023 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7024 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7025 Remove unused local.
7026 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7028 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7029 GCC 4.6.0 optimizes based on type-based alias analysis.
7030 For example, if b is of type struct buffer * and v of type struct
7031 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7032 != &v->size, and therefore "v->size = 1; b->size = 2; return
7033 v->size;" must therefore return 1. This assumption is incorrect
7034 for Emacs, since it type-puns struct Lisp_Vector * with many other
7035 types. To fix this problem, this patch adds a new type struct
7036 vectorlike_header that documents the constraints on layout of vectors
7037 and pseudovectors, and helps optimizing compilers not get fooled
7038 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7039 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7040 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7042 (XSETPVECTYPE): Rewrite in terms of new macro.
7043 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7044 This is a bit clearer, and further avoids the possibility of
7045 undesirable aliasing.
7046 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7047 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7048 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7049 since Lisp_Subr is a special case (no "next" field).
7050 (ASIZE): Now uses header.size rather than size.
7051 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7052 to avoid the hassle of writing XVECTOR (foo)->header.size.
7053 (struct vectorlike_header): New type.
7054 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7055 object, to help avoid aliasing.
7056 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7057 (SUBRP): Likewise, since Lisp_Subr is a special case.
7058 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7059 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7060 (struct Lisp_Hash_Table): Combine first two members into a single
7061 struct vectorlike_header member. All uses of "size" and "next" members
7062 changed to be "header.size" and "header.next".
7063 * buffer.h (struct buffer): Likewise.
7064 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7065 * frame.h (struct frame): Likewise.
7066 * process.h (struct Lisp_Process): Likewise.
7067 * termhooks.h (struct terminal): Likewise.
7068 * window.c (struct save_window_data, struct saved_window): Likewise.
7069 * window.h (struct window): Likewise.
7070 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7071 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7072 * buffer.c (init_buffer_once): Likewise.
7073 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7075 * process.c (Fformat_network_address): Use local var for size,
7078 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7080 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7081 * data.c (atof): Remove decl; no longer used or needed.
7082 (digit_to_number): Move to lread.c.
7083 (Fstring_to_number): Use new string_to_number function, to be
7084 consistent with how the Lisp reader treats infinities and NaNs.
7085 Do not assume that floating-point numbers represent EMACS_INT
7086 without losing information; this is not true on most 64-bit hosts.
7087 Avoid double-rounding errors, by insisting on integers when
7088 parsing non-base-10 numbers, as the documentation specifies.
7089 * lisp.h (string_to_number): New decl, replacing ...
7090 (isfloat_string): Remove.
7091 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7092 (read1): Do not accept +. and -. as integers; this
7093 appears to have been a coding error. Similarly, do not accept
7094 strings like +-1e0 as floating point numbers. Do not report
7095 overflow for integer overflows unless the base is not 10 which
7096 means we have no simple and reliable way to continue.
7097 Break out the floating-point parsing into a new
7098 function string_to_number, so that Fstring_to_number parses
7099 floating point numbers consistently with the Lisp reader.
7100 (digit_to_number): Move here from data.c. Make it static inline.
7101 (E_CHAR, EXP_INT): Remove, replacing with ...
7102 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7103 (string_to_number): New function, replacing isfloat_string.
7104 This function checks for valid syntax and produces the resulting
7105 Lisp float number too. Rework it so that string-to-number
7106 no longer mishandles examples like "1.0e+". Use strtoumax,
7107 so that overflow for non-base-10 numbers is reported only when
7108 there's no portable and simple way to convert to floating point.
7110 * textprop.c (set_text_properties_1): Rewrite for clarity,
7111 and to avoid GCC warning about integer overflow.
7113 * intervals.h (struct interval): Use EMACS_INT for members
7114 where EMACS_UINT might cause problems. See
7115 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7116 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7117 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7119 (offset_intervals): Tell GCC not to worry about length overflow
7120 when negating a negative length.
7122 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7123 (overrun_check_free): Likewise.
7125 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7126 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7129 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7130 (gnutls_make_error): Rename local to avoid shadowing.
7131 (gnutls_emacs_global_deinit): ifdef out; not used.
7132 (Fgnutls_boot): Use const for pointer to readonly storage.
7133 Comment out unused local. Fix pointer signedness problems.
7135 * lread.c (openp): Don't stuff size_t into an 'int'.
7136 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7137 about possible signed overflow.
7139 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7140 (GDK_KEY_g): Don't define if already defined.
7141 (xg_prepare_tooltip): Avoid pointer signedness problem.
7142 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7144 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7145 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7147 * xfns.c (Fx_window_property): Simplify a bit,
7148 to make a bit faster and to avoid GCC 4.6.0 warning.
7149 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7151 * fns.c (internal_equal): Don't assume size_t fits in int.
7153 * alloc.c (compact_small_strings): Tighten assertion a little.
7155 Replace pEd with more-general pI, and fix some printf arg casts.
7156 * lisp.h (pI): New macro, generalizing old pEd macro to other
7157 conversion specifiers. For example, use "...%"pI"d..." rather
7158 than "...%"pEd"...".
7159 (pEd): Remove. All uses replaced with similar uses of pI.
7160 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7161 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7162 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7163 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7164 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7165 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7166 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7168 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7169 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7170 * print.c (safe_debug_print, print_object): Likewise.
7171 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7173 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7174 avoiding the 0 flag, which is not portable.
7175 * process.c (Fmake_network_process): Use pI to avoid cast.
7176 * region-cache.c (pp_cache): Likewise.
7177 * xdisp.c (decode_mode_spec): Likewise.
7178 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7179 behavior on 64-bit hosts with printf arg.
7180 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7181 (x_stop_queuing_selection_requests): Likewise.
7182 (x_get_window_property): Don't truncate byte count to an 'int'
7185 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7186 here, since it parses constructs like leading '-' and spaces,
7187 which are not wanted; and it overflows with large numbers.
7188 Instead, simply match F[0-9]+, which is what is wanted anyway.
7190 * alloc.c: Remove unportable assumptions about struct layout.
7191 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7192 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7193 (allocate_vectorlike, make_pure_vector): Use the new macros,
7194 plus offsetof, to remove unportable assumptions about struct layout.
7195 These assumptions hold on all porting targets that I know of, but
7196 they are not guaranteed, they're easy to remove, and removing them
7197 makes further changes easier.
7199 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7200 This doesn't fix a bug but makes the code clearer.
7201 (string_overrun_cookie): Now const. Use initializers that
7202 don't formally overflow signed char, to avoid warnings.
7203 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7204 can cause Emacs to crash when string overrun checking is enabled.
7205 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7206 multiple of sizeof (EMACS_INT); it need not be, if
7207 alignof(EMACS_INT) < sizeof (EMACS_INT).
7208 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7210 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7212 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7214 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7216 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7217 supposed to be handshaking. (Bug#8556)
7218 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7220 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7222 * lisp.h (Qdebug): List symbol.
7223 * eval.c (Qdebug): Restore global linkage.
7224 * keyboard.c (debug-on-event): New variable.
7225 (handle_user_signal): Break into debugger when debug-on-event
7226 matches the current signal symbol.
7228 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7230 * alloc.c (check_sblock, check_string_bytes)
7231 (check_string_free_list): Convert to standard C.
7233 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7235 * w32.c (emacs_gnutls_push): Fix typo.
7237 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7239 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7240 "cast to pointer from integer of different size".
7242 Improve doprnt and its use in verror. (Bug#8545)
7243 * doprnt.c (doprnt): Document the set of format control sequences
7244 supported by the function. Use SAFE_ALLOCA instead of always
7247 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7248 is one byte too soon. Don't use xrealloc; instead xfree and
7251 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7253 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7256 * gnutls.c: Renamed global_initialized to
7257 gnutls_global_initialized. Added internals for the
7258 :verify-hostname-error, :verify-error, and :verify-flags
7259 parameters of `gnutls-boot' and documented those parameters in the
7260 docstring. Start callback support.
7261 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7262 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7263 on error. Return error code.
7264 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7265 (emacs_gnutls_read): Likewise.
7266 (Fgnutls_boot): Return handshake error code.
7267 (emacs_gnutls_handle_error): New function.
7268 (wsaerror_to_errno): Likewise.
7270 * w32.h (emacs_gnutls_pull): Add prototype.
7271 (emacs_gnutls_push): Likewise.
7273 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7274 (emacs_gnutls_push): Likewise.
7276 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7278 * process.c (wait_reading_process_output): Check if GnuTLS
7279 buffered some data internally if no FDs are set for TLS
7282 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7283 (LIBS): Link to USER_LIBS.
7284 ($(BLD)/gnutls.$(0)): New target.
7286 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7288 * xdisp.c (handle_single_display_spec): Rename the
7289 display_replaced_before_p argument into display_replaced_p, to
7290 make it consistent with the commentary. Fix typos in the
7293 * textprop.c (syms_of_textprop): Remove dead code.
7294 (copy_text_properties): Delete obsolete commentary about an
7295 interface that was deleted long ago. Fix typos in the description
7298 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7299 to changes in oldXMenu/XMenu.h from 2011-04-16.
7300 <menu_help_message, prev_menu_help_message>: Constify.
7301 (IT_menu_make_room): menu->help_text is now `const char **';
7304 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7305 to changes in oldXMenu/XMenu.h from 2011-04-16.
7306 (struct XMenu): Declare `help_text' `const char **'.
7308 * xfaces.c <Qunspecified>: Make extern again.
7310 * syntax.c: Include sys/types.h before including regex.h, as
7313 * doc.c (get_doc_string): Improve the format passed to `error'.
7315 * doprnt.c (doprnt): Improve commentary.
7317 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7319 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7322 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7323 changes in globals.h immediately force recompilation.
7324 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7325 $(CURDIR)/s/ms-w32.h.
7326 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7328 * character.c (Fchar_direction): Function deleted.
7329 (syms_of_character): Don't defsubr it.
7330 <char-direction-table>: Deleted.
7332 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7334 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7335 * doprnt.c: Include limits.h.
7336 (SIZE_MAX): New macro.
7337 (doprnt): Return a size_t value. 2nd arg is now size_t.
7338 Many local variables are now size_t instead of int or unsigned.
7339 Improve overflow protection. Support `l' modifier for integer
7340 conversions. Support %l conversion. Don't assume an EMACS_INT
7341 argument for integer conversions and for %c.
7343 * lisp.h (doprnt): Restore prototype.
7345 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7348 * Makefile.in (base_obj): Add back doprnt.o.
7350 * deps.mk (doprnt.o): Add back prerequisites.
7351 (callint.o): Depend on character.h.
7353 * eval.c (internal_lisp_condition_case): Include the handler
7354 representation in the error message.
7355 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7356 when breaking from the loop.
7358 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7360 * callint.c (Fcall_interactively): When displaying error message
7361 about invalid control letter, pass the character's codepoint, not
7362 a pointer to its multibyte form. Improve display of the character
7363 in octal and display also its hex code.
7365 * character.c (char_string): Use %x to display the (unsigned)
7366 codepoint of an invalid character, to avoid displaying a bogus
7369 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7370 `error', not SYMBOL_NAME itself.
7372 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7373 character arguments to `error'.
7375 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7376 to `error' in error message about FINAL_CHAR argument. Make sure
7377 FINAL_CHAR is a character, and use %c when it is passed as
7378 argument to `error'.
7380 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7382 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7384 * w32.c: Include <time.h>.
7385 (sys_localtime): New function.
7387 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7389 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7391 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7393 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7395 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7398 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7400 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7401 gl_state.e_property when gl_state.object is Qt.
7403 * insdel.c (make_gap_larger): Remove limitation of buffer size
7406 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7408 * xdisp.c (lookup_glyphless_char_display)
7409 (produce_glyphless_glyph): Handle cons cell entry in
7410 glyphless-char-display.
7411 (Vglyphless_char_display): Document it.
7413 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7414 glyphless-char-display.
7416 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7418 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7420 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7422 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7423 definition for no-X builds.
7425 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7427 Static checks with GCC 4.6.0 and non-default toolkits.
7429 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7431 * process.c (keyboard_bit_set): Define only if SIGIO.
7432 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7433 (send_process): Repair possible setjmp clobbering.
7435 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7437 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7439 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7441 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7442 Define only if needed.
7444 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7445 by pacifying GCC about it. Maybe it's time to retire it?
7446 * xfaces.c (USG, __TIMEVAL__): Likewise.
7448 * dispextern.h (struct redisplay_interface): Rename param
7450 * termhooks.h (struct terminal): Likewise.
7451 * xterm.c (xembed_send_message): Likewise.
7453 * insdel.c (make_gap_smaller): Define only if
7454 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7456 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7459 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7460 so that we aren't warned about unused symbols.
7462 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7464 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7466 * xfns.c (x_real_positions): Mark locals as initialized.
7468 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7470 * xterm.c: Fix problems found by static analysis with other toolkits.
7471 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7472 (x_dispatch_event): Declare static if USE_GTK, and
7473 define if USE_GTK || USE_X_TOOLKIT.
7474 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7475 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7476 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7477 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7479 * xmenu.c (menu_help_callback): Pointer type fixes.
7480 Use const pointers when pointing at readonly data. Avoid pointer
7482 (FALSE): Remove unused macro.
7483 (update_frame_menubar): Remove unused decl.
7485 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7487 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7488 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7489 (single_menu_item): Rename local to avoid shadowing.
7491 * keyboard.c (make_lispy_event): Remove unused local var.
7493 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7494 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7496 * bitmaps: Change bitmaps from unsigned char back to the X11
7497 compatible char. Avoid the old compiler warnings about
7498 out-of-range initializers by using, for example, '\xab' rather
7501 * xgselect.c (xgselect_initialize): Check vs interface
7502 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7504 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7506 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7507 to read-only memory.
7509 * fns.c (vector): Remove; this old hack is no longer needed.
7511 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7513 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7515 * xrdb.c (x_load_resources): Omit unused local.
7517 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7518 (x_window): Rename locals to avoid shadowing.
7519 (USG): Use the kludged USG macro, to pacify gcc.
7521 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7522 (x_term_init): Remove local to avoid shadowing.
7524 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7526 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7527 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7529 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7531 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7533 Fix regex.c, syntax.c and friends for buffers > 2GB.
7534 * syntax.h (struct gl_state_s): Declare character position members
7537 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7539 * textprop.c (verify_interval_modification, interval_of):
7540 Declare arguments EMACS_INT.
7542 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7545 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7547 * indent.c (Fvertical_motion): Local variable it_start is now
7550 * regex.c (re_match, re_match_2, re_match_2_internal)
7551 (bcmp_translate, regcomp, regexec, print_double_string)
7552 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7553 (re_compile_pattern, re_exec): Declare arguments and local
7554 variables `size_t' and `ssize_t' and return values `regoff_t', as
7556 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7557 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7558 <compile_stack_type>: `size' and `avail' are now `size_t'.
7560 * regex.h <regoff_t>: Use ssize_t, not int.
7561 (re_search, re_search_2, re_match, re_match_2): Arguments that
7562 specify buffer/string position and length are now ssize_t and
7563 size_t. Return type is regoff_t.
7565 2011-04-16 Ben Key <bkey76@gmail.com>
7567 * nsfont.m: Fixed bugs in ns_get_family and
7568 ns_descriptor_to_entity that were caused by using free to
7569 deallocate memory blocks that were allocated by xmalloc (via
7570 xstrdup). This caused Emacs to crash when compiled with
7571 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7572 --enable-checking=xmallocoverrun). xfree is now used to
7573 deallocate these memory blocks.
7575 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7577 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7579 emacs_write: Accept and return EMACS_INT for sizes.
7580 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7582 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7583 Accept and return EMACS_INT.
7584 (emacs_gnutls_write): Return the number of bytes written on
7586 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7587 (emacs_read, emacs_write): Remove check for negative size, as the
7588 Emacs source code has been audited now.
7589 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7590 (emacs_read, emacs_write): Use it.
7591 * process.c (send_process): Adjust to the new signatures of
7592 emacs_write and emacs_gnutls_write. Do not attempt to store
7593 a byte offset into an 'int'; it might overflow.
7594 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7596 * sound.c: Don't assume sizes fit in 'int'.
7597 (struct sound_device.period_size, alsa_period_size):
7598 Return EMACS_INT, not int.
7599 (struct sound_device.write, vox_write, alsa_write):
7600 Accept EMACS_INT, not int.
7601 (wav_play, au_play): Use EMACS_INT to store sizes and to
7602 record read return values.
7604 2011-04-15 Ben Key <bkey76@gmail.com>
7606 * keyboard.c (Qundefined): Don't declare static since it is used
7608 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7609 static since they are used in nsfont.m.
7611 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7613 * process.c (Qprocessp): Don't declare static.
7614 * lisp.h (Qprocessp): Declare again.
7616 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7618 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7620 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7622 Improve C-level modularity by making more things 'static'.
7624 Don't publish debugger-only interfaces to other modules.
7625 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7626 (verify_bytepos, count_markers): Move decls to the only modules
7628 * region-cache.h (pp_cache): Likewise.
7629 * window.h (check_all_windows): Likewise.
7630 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7632 * sysdep.c (croak): Now static, if
7633 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7634 * syssignal.h (croak): Declare only if not static.
7636 * alloc.c (refill_memory_reserve): Now static if
7637 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7638 * lisp.h (refill_memory_reserve): Declare only if not static.
7640 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7641 Define only if USE_LUCID.
7643 * xrdb.c (x_customization_string, x_rm_string): Now static.
7645 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7646 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7648 * xdisp.c (draw_row_with_mouse_face): Now static.
7649 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7651 * window.h (check_all_windows): Mark externally visible.
7653 * window.c (window_deletion_count): Now static.
7655 * undo.c: Make symbols static if they're not exported.
7656 (last_undo_buffer, last_boundary_position, pending_boundary):
7659 * textprop.c (interval_insert_behind_hooks): Now static.
7660 (interval_insert_in_front_hooks): Likewise.
7662 * term.c: Make symbols static if they're not exported.
7663 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7664 (max_frame_lines, tty_set_terminal_modes):
7665 (tty_reset_terminal_modes, tty_turn_off_highlight):
7666 (get_tty_terminal): Now static.
7667 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7668 * termhooks.h (term_mouse_moveto): Do not declare if
7670 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7671 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7673 * sysdep.c: Make symbols static if they're not exported.
7674 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7676 (sigprocmask_set, full_mask): Remove; unused.
7677 (wait_debugging): Mark as visible.
7678 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7679 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7681 * syntax.c (syntax_temp): Define only if !__GNUC__.
7683 * sound.c (current_sound_device, current_sound): Now static.
7685 * search.c (searchbufs, searchbuf_head): Now static.
7687 * scroll.c (scroll_cost): Remove; unused.
7688 * dispextern.h (scroll_cost): Remove decl.
7690 * region-cache.h (pp_cache): Mark as externally visible.
7692 * process.c: Make symbols static if they're not exported.
7693 (process_tick, update_tick, create_process, chan_process):
7694 (Vprocess_alist, proc_buffered_char, datagram_access):
7695 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7696 (deactivate_process): Mark defn as static, as well as decl.
7697 * lisp.h (create_process): Remove decl.
7698 * process.h (chan_process, Vprocess_alist): Remove decls.
7700 * print.c: Make symbols static if they're not exported.
7701 (print_depth, new_backquote_output, being_printed, print_buffer):
7702 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7703 (print_interval, print_number_index, initial_stderr_stream):
7705 * lisp.h (Fprinc): Remove decl.
7706 (debug_output_compilation_hack): Mark as externally visible.
7708 * sysdep.c (croak): Move decl from here to syssignal.h.
7709 * syssignal.h (croak): Put it here, so the API can be checked when
7710 'croak' is called from dissociate_if_controlling_tty.
7712 * minibuf.c: Make symbols static if they're not exported.
7713 (minibuf_save_list, choose_minibuf_frame): Now static.
7714 * lisp.h (choose_minibuf_frame): Remove decl.
7716 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7718 * lread.c: Make symbols static if they're not exported.
7719 (read_objects, initial_obarray, oblookup_last_bucket_number):
7721 (make_symbol): Remove; unused.
7722 * lisp.h (initial_obarray, make_symbol): Remove decls.
7724 * keyboard.c: Make symbols static if they're not exported.
7725 (single_kboard, recent_keys_index, total_keys, recent_keys):
7726 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7727 (this_single_command_key_start, echoing, last_auto_save):
7728 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7729 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7730 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7731 (Vlispy_mouse_stem, double_click_count):
7733 (force_auto_save_soon): Define only if SIGDANGER.
7734 (ignore_mouse_drag_p): Now static if
7735 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7736 (print_help): Remove; unused.
7737 (stop_character, last_timer_event): Mark as externally visible.
7738 * keyboard.h (ignore_mouse_drag_p): Declare only if
7739 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7740 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7741 * lisp.h (echoing): Remove decl.
7742 (force_auto_save_soon): Declare only if SIGDANGER.
7743 * xdisp.c (redisplay_window): Simplify code, to make it more
7744 obvious that ignore_mouse_drag_p is not accessed if !defined
7745 USE_GTK && !defined HAVE_NS.
7747 * intervals.c: Make symbols static if they're not exported.
7748 (merge_properties_sticky, merge_interval_right, delete_interval):
7750 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7752 * insdel.c: Make symbols static if they're not exported.
7753 However, leave prepare_to_modify_buffer alone. It's never
7754 called from outside this function, but that appears to be a bug.
7755 (combine_after_change_list, combine_after_change_buffer):
7756 (adjust_after_replace, signal_before_change): Now static.
7757 (adjust_after_replace_noundo): Remove; unused.
7758 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7759 (signal_before_change): Remove decls.
7761 * indent.c (val_compute_motion, val_vmotion): Now static.
7763 * image.c: Make symbols static if they're not exported.
7764 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7766 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7767 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7769 * fringe.c (standard_bitmaps): Now static.
7770 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7772 * frame.c: Make symbols static if they're not exported.
7773 (x_report_frame_params, make_terminal_frame): Now static.
7774 (get_frame_param): Now static, unless HAVE_NS.
7775 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7776 (x_get_resource_string): Remove; not used.
7777 * frame.h (make_terminal_frame, x_report_frame_params):
7778 (x_get_resource_string); Remove decls.
7779 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7780 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7782 * font.c, fontset.c: Make symbols static if they're not exported.
7783 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7784 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7785 * font.c (font_close_object): Now static.
7786 * font.h (font_close_object): Remove.
7787 * fontset.c (FONTSET_OBJLIST): Remove.
7788 (free_realized_fontset) #if-0 the body, which does nothing.
7789 (face_suitable_for_char_p): #if-0, as it's never called.
7790 * fontset.h (face_suitable_for_char_p): Remove decl.
7791 * xfaces.c (face_at_string_position):
7792 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7793 since 0 is always ASCII.
7795 * fns.c (weak_hash_tables): Now static.
7797 * fileio.c: Make symbols static if they're not exported.
7798 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7799 (Vwrite_region_annotation_buffers): Now static.
7801 * eval.c: Make symbols static if they're not exported.
7802 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7803 * lisp.h (backtrace_list): Remove decl.
7805 * emacs.c: Make symbols static if they're not exported.
7806 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7807 (fatal_error_code, fatal_error_signal_hook, standard_args):
7809 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7810 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7811 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7812 * lisp.h (fatal_error_signal_hook): Remove decl.
7813 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7815 * editfns.c: Move a (normally-unused) function to its only use.
7816 * editfns.c, lisp.h (get_operating_system_release): Remove.
7817 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7818 worth the hassle of breaking this out.
7820 * xterm.c: Make symbols static if they're not exported.
7821 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7822 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7823 (x_destroy_window, x_delete_display):
7825 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7826 (x_mouse_leave): Remove; unused.
7827 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7828 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7829 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7831 (x_mouse_leave): Declare only if WINDOWSNT.
7832 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7833 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7836 * ftxfont.c: Make symbols static if they're not exported.
7837 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7839 * font.h (ftxfont_driver): Likewise.
7841 * xfns.c: Make symbols static if they're not exported.
7842 (x_last_font_name, x_display_info_for_name):
7843 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7844 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7845 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7846 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7847 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7848 (last_show_tip_args): Now static.
7849 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7850 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7851 (x_screen_planes): Remove; unused.
7852 * dispextern.h (x_screen_planes): Remove decl.
7854 * dispnew.c: Make symbols static if they're not exported.
7855 * dispextern.h (redraw_garbaged_frames, scrolling):
7856 (increment_row_positions): Remove.
7857 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7858 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7860 (redraw_garbaged_frames): Remove; unused.
7862 * xfaces.c: Make symbols static if they're not exported.
7863 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7865 * xterm.h (defined_color): Remove decls.
7866 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7867 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7868 (menu_face_changed_default, defined_color, free_realized_face):
7869 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7870 (ascii_face_of_lisp_face): Remove; unused.
7872 * xdisp.c: Make symbols static if they're not exported.
7873 * dispextern.h (scratch_glyph_row, window_box_edges):
7874 (glyph_to_pixel_coords, set_cursor_from_row):
7875 (get_next_display_element, set_iterator_to_next):
7876 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7877 (show_mouse_face): Remove decls
7878 * frame.h (message_buf_print): Likewise.
7879 * lisp.h (pop_message, set_message, check_point_in_composition):
7881 * xterm.h (set_vertical_scroll_bar): Likewise.
7882 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7883 (message_buf_print, scratch_glyph_row, displayed_buffer):
7884 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7885 (get_next_display_element, show_mouse_face, window_box_edges):
7886 (frame_to_window_pixel_xy, check_point_in_composition):
7887 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7888 (glyph_to_pixel_coords): Remove; unused.
7890 * dired.c (file_name_completion): Now static.
7892 * dbusbind.c (xd_in_read_queued_messages): Now static.
7894 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7895 * data.c (circular_list_error): Remove.
7897 * commands.h (last_point_position, last_point_position_buffer):
7898 (last_point_position_window): Remove decls.
7899 * keyboard.c: Make these variables static.
7901 * coding.h (coding, code_convert_region, encode_coding_gap):
7903 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7904 (iso_code_class, detect_coding, code_convert_region): Now static.
7905 (encode_coding_gap): Remove; unused.
7907 * chartab.c (chartab_chars, chartab_bits): Now static.
7909 * charset.h (charset_iso_8859_1): Remove decl.
7910 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7913 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7914 * ccl.c (Vccl_program_table): Now static.
7915 (check_ccl_update): Remove; unused.
7917 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7918 * category.h: ... from here.
7919 * category.c (check_category_table, set_category_set): Now static.
7921 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7922 * lisp.h: Remove these decls.
7924 * buffer.c (buffer_count): Remove unused var.
7926 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7927 so that it's not optimized away.
7928 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7929 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7930 exported only to the debugger.
7932 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7933 * atimer.h (run_all_atimers): Remove; not exported.
7935 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7936 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7937 was inaccessible from Lisp.
7938 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7939 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7941 alloc.c: Import and export fewer symbols, and remove unused items.
7942 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7944 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7945 it's not optimized away by whole-program optimization.
7946 (message_enable_multibyte, free_misc): Remove.
7947 (catchlist, handlerlist, mark_backtrace):
7948 Declare only if BYTE_MARK_STACK.
7949 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7950 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7951 (message_enable_multibyte): Remove decl.
7952 (free_misc, interval_free_list, float_block, float_block_index):
7953 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7954 (cons_free_list, last_marked_index):
7956 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7957 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7958 (mark_backtrace): Define only if BYTE_MARK_STACK.
7959 * xdisp.c (message_enable_multibyte): Now static.
7961 Declare Lisp_Object Q* variables to be 'static' if not exported.
7962 This makes it easier for human readers (and static analyzers)
7963 to see whether these variables are used from other modules.
7964 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7965 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7966 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7967 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7968 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7969 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7970 * xmenu.c, xselect.c:
7971 Declare Q* vars static if they are not used in other modules.
7972 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7973 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7974 Remove decls of unexported vars.
7975 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7977 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7979 Make Emacs functions such as Fatom 'static' by default.
7980 This makes it easier for human readers (and static analyzers)
7981 to see whether these functions can be called from other modules.
7982 DEFUN now defines a static function. To make the function external
7983 so that it can be used in other C modules, use the new macro DEFUE.
7984 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7985 (Finit_image_library):
7986 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7987 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7988 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7989 Remove decls, since these functions are now static.
7990 (Funintern, Fget_internal_run_time): New decls, since these functions
7991 were already external.
7993 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7994 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7995 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7996 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7997 * keyboard.c, keymap.c, lread.c:
7998 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7999 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8000 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8001 Mark functions with DEFUE instead of DEFUN,
8002 if they are used in other modules.
8003 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8004 decls for now-static functions.
8005 * buffer.h (Fdelete_overlay): Remove decl.
8006 * callproc.c (Fgetenv_internal): Mark as internal.
8007 * composite.c (Fremove_list_of_text_properties): Remove decl.
8008 (Fcomposition_get_gstring): New forward static decl.
8009 * composite.h (Fcomposite_get_gstring): Remove decl.
8010 * dired.c (Ffile_attributes): New forward static decl.
8011 * doc.c (Fdocumntation_property): New forward static decl.
8012 * eval.c (Ffetch_bytecode): New forward static decl.
8013 (Funintern): Remove extern decl; now in .h file where it belongs.
8014 * fileio.c (Fmake_symbolic_link): New forward static decl.
8015 * image.c (Finit_image_library): New forward static decl.
8016 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8017 * intervals.h (Fprevious_property_change):
8018 (Fremove_list_of_text_properties): Remove decls.
8019 * keyboard.c (Fthis_command_keys): Remove decl.
8020 (Fcommand_execute): New forward static decl.
8021 * keymap.c (Flookup_key): New forward static decl.
8022 (Fcopy_keymap): Now static.
8023 * keymap.h (Flookup_key): Remove decl.
8024 * process.c (Fget_process): New forward static decl.
8025 (Fprocess_datagram_address): Mark as internal.
8026 * syntax.c (Fsyntax_table_p): New forward static decl.
8027 (skip_chars): Remove duplicate decl.
8028 * textprop.c (Fprevious_property_change): New forward static decl.
8029 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8031 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8032 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8034 * editfns.c (Fformat): Remove unreachable code.
8036 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8038 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8041 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8043 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8044 when at ZV. (Bug#8487)
8046 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8048 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8050 * keyboard.c (parse_tool_bar_item): Likewise.
8051 * sound.c (sound_cleanup, alsa_close): Likewise.
8052 * termcap.c (tgetent): Likewise.
8053 * xfns.c (x_default_font_parameter): Likewise.
8054 * xsettings.c (read_and_apply_settings): Likewise.
8056 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8057 (overrun_check_free): Protoize.
8059 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8061 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8062 since callers should never pass a negative size.
8063 Change the signature to match that of plain 'read' and 'write'; see
8064 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8065 * lisp.h: Update prototypes of emacs_write and emacs_read.
8067 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8069 * xdisp.c (redisplay_window): Don't try to determine the character
8070 position of the scroll margin if the window start point w->startp
8071 is outside the buffer's accessible region. (Bug#8468)
8073 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8075 Fix write-region and its subroutines for buffers > 2GB.
8076 * fileio.c (a_write, e_write): Modify declaration of arguments and
8077 local variables to support buffers larger than 2GB.
8078 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8080 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8081 argument, local variables, and return value.
8083 * lisp.h: Update prototypes of emacs_write and emacs_read.
8085 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8087 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8089 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8091 Fix more problems found by GCC 4.6.0's static checks.
8093 * xdisp.c (vmessage): Use a better test for character truncation.
8095 * charset.c (load_charset_map): <, not <=, for optimization,
8096 and to avoid potential problems with integer overflow.
8097 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8098 * casetab.c (set_identity, shuffle): Likewise.
8099 * editfns.c (Fformat): Likewise.
8100 * syntax.c (skip_chars): Likewise.
8102 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8103 This also lets GCC 4.6.0 generate slightly better loop code.
8105 * callint.c (Fcall_interactively): <, not <=, for optimization.
8106 (Fcall_interactively): Count the number of arguments produced,
8107 not the number of arguments given. This is simpler and lets GCC
8108 4.6.0 generate slightly better code.
8110 * ftfont.c: Distingish more carefully between FcChar8 and char.
8111 The previous code passed unsigned char * to a functions like
8112 strlen and xstrcasecmp that expect char *, which does not
8113 conform to the C standard.
8114 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8115 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8116 char * when the C standard requires it.
8118 * keyboard.c (read_char): Remove unused var.
8120 * eval.c: Port to Windows vsnprintf (Bug#8435).
8122 (SIZE_MAX): Define if the headers do not.
8123 (verror): Do not give up if vsnprintf returns a negative count.
8124 Instead, grow the buffer. This ports to Windows vsnprintf, which
8125 does not conform to C99. Problem reported by Eli Zaretskii.
8126 Also, simplify the allocation scheme, by avoiding the need for
8127 calling realloc, and removing the ALLOCATED variable.
8129 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8131 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8132 But keep the doprint source code for now, as we might revamp it
8133 and use it again (Bug#8435).
8134 * lisp.h (doprnt): Remove.
8135 * Makefile.in (base_obj): Remove doprnt.o.
8136 * deps.mk (doprnt.o): Remove.
8138 error: Print 32- and 64-bit integers portably (Bug#8435).
8139 Without this change, on typical 64-bit hosts error ("...%d...", N)
8140 was used to print both 32- and 64-bit integers N, which relied on
8142 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8143 * lisp.h (error, verror): Mark as printf-like functions.
8144 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8145 Report overflow in size calculations when allocating printf buffer.
8146 Do not truncate output string at its first null byte.
8147 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8148 Truncate the output at a character boundary, since vsnprintf does not
8150 * charset.c (check_iso_charset_parameter): Convert internal
8151 character to string before calling 'error', since %c now has the
8153 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8154 overflow when computing char to be passed to 'error'. Do not
8155 pass Lisp_Object to 'error'; pass the integer instead.
8156 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8157 formatted with plain %d.
8159 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8161 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8163 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8165 * xterm.c (x_catch_errors): Remove duplicate declaration.
8167 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8169 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8171 2011-04-10 Jim Meyering <meyering@redhat.com>
8173 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8174 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8175 return ssize_t not "int", and use size_t as the buffer length.
8176 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8177 * gnutls.h: Update declarations.
8178 * process.c (read_process_output): Use ssize_t, to match.
8179 (send_process): Likewise.
8181 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8183 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8185 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8187 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8188 Use unsigned char, to match FcChar8 type definition.
8190 * xterm.c (handle_one_xevent):
8191 * xmenu.c (create_and_show_popup_menu):
8192 * xselect.c (x_decline_selection_request)
8193 (x_reply_selection_request): Avoid type-punned deref of X events.
8195 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8197 Fix some uses of `int' instead of EMACS_INT.
8198 * search.c (string_match_1, fast_string_match)
8199 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8200 (scan_buffer, find_next_newline_no_quit)
8201 (find_before_next_newline, search_command, Freplace_match)
8202 (Fmatch_data): Make some `int' variables be EMACS_INT.
8204 * xdisp.c (display_count_lines): 3rd argument and return value now
8205 EMACS_INT. All callers changed.
8206 (pint2hrstr): Last argument is now EMACS_INT.
8208 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8209 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8210 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8211 (decode_coding_utf_16, decode_coding_emacs_mule)
8212 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8213 (decode_coding_ccl, decode_coding_charset)
8214 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8215 (decode_coding_iso_2022, decode_coding_emacs_mule)
8216 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8217 <char_offset, last_offset>: Declare EMACS_INT.
8218 (encode_coding_utf_8, encode_coding_utf_16)
8219 (encode_coding_emacs_mule, encode_invocation_designation)
8220 (encode_designation_at_bol, encode_coding_iso_2022)
8221 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8222 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8224 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8225 (encode_invocation_designation): Last argument P_NCHARS is now
8227 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8228 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8230 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8233 * ccl.c (Fccl_execute_on_string): Declare some variables
8236 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8238 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8240 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8242 * process.c (Fformat_network_address): Doc fix.
8244 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8246 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8248 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8250 * keyboard.c (read_char): Call Lisp function help-form-show,
8251 instead of using internal_with_output_to_temp_buffer.
8252 (Qhelp_form_show): New var.
8253 (syms_of_keyboard): Use DEFSYM macro.
8255 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8257 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8259 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8261 * process.c (Flist_processes): Remove to Lisp.
8262 (list_processes_1): Delete.
8264 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8266 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8268 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8270 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8272 Fix more problems found by GCC 4.6.0's static checks.
8274 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8276 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8278 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8280 * xdisp.c (vmessage): Mark as a printf-like function.
8282 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8284 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8286 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8287 printf-like functions.
8288 (tiff_load): Add casts to remove these marks before passing them
8289 to system-supplied API.
8291 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8293 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8294 This avoids several warnings with gcc -Wstrict-overflow.
8295 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8296 directly, rather than having caller test rule sign. This avoids
8297 some unnecessary tests.
8298 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8299 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8300 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8302 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8303 (xfont_open): Avoid unnecessary tests.
8305 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8307 * composite.h, composite.c (composition_gstring_put_cache):
8308 Use EMACS_INT, not int, for length.
8310 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8311 breaking out part of COMPOSITION_DECODE_RULE.
8312 (COMPOSITION_DECODE_RULE): Use it.
8313 * composite.c (get_composition_id): Remove unused local vars,
8314 by using the new macro.
8316 * textprop.c (set_text_properties_1): Change while to do-while,
8317 since the condition is always true at first.
8319 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8320 (interval_deletion_adjustment): Return unsigned value.
8323 * process.c (list_processes_1, create_pty, read_process_output):
8324 (exec_sentinel): Remove vars that were set but not used.
8325 (create_pty): Remove unnecessary "volatile"s.
8326 (Fnetwork_interface_info): Avoid possibility of int overflow.
8327 (read_process_output): Do adaptive read buffering even if carryover.
8328 (read_process_output): Simplify nbytes computation if buffered.
8330 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8332 * syntax.c (scan_words): Remove var that was set but not used.
8333 (update_syntax_table): Use unsigned instead of int.
8335 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8336 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8337 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8339 * print.c (print_error_message): Avoid int overflow.
8341 * font.c (font_list_entities): Redo for clarity,
8342 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8344 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8345 (font_score): Avoid potential overflow in diff calculation.
8347 * fns.c (substring_both): Remove var that is set but not used.
8348 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8350 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8352 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8353 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8354 can always succeed if overflow has undefined behavior.
8356 * search.c (boyer_moore, wordify): Remove vars set but not used.
8357 (wordify): Omit three unnecessary tests.
8359 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8360 All callers changed. This avoids the need for an unused var.
8362 * casefiddle.c (casify_region): Remove var that is set but not used.
8364 * dired.c (file_name_completion): Remove var that is set but not used.
8366 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8368 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8369 (Finsert_file_contents): Remove unnecessary code checking fd.
8371 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8372 Check for integer overflow on size calculations.
8374 * buffer.c (Fprevious_overlay_change): Remove var that is set
8377 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8378 Remove vars that are set but not used.
8379 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8380 (timer_check_2): Mark vars as initialized.
8382 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8384 * image.c (lookup_image): Remove var that is set but not used.
8385 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8387 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8388 that are set but not used.
8390 * xfns.c (make_invisible_cursor): Don't return garbage
8391 if XCreateBitmapFromData fails (Bug#8410).
8393 * xselect.c (x_get_local_selection, x_handle_property_notify):
8394 Remove vars that are set but not used.
8396 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8397 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8399 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8400 Remove var that is set but not used.
8401 (scroll_bar_windows_size): Now size_t, not int.
8402 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8405 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8406 (map_tty_color) [!defined MSDOS]: Likewise.
8408 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8410 * coding.c: Remove vars that are set but not used.
8411 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8412 All callers changed.
8413 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8414 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8415 (decode_coding_charset): Remove vars that are set but not used.
8417 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8418 that is set but not used.
8420 * print.c (print_object): Remove var that is set but not used.
8422 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8423 The gnulib version avoids calling malloc in the usual case,
8424 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8425 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8426 * filelock.c (current_lock_owner): Likewise.
8427 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8428 * sysdep.c: Include allocator.h, careadlinkat.h.
8429 (emacs_no_realloc_allocator): New static constant.
8430 (emacs_readlink): New function.
8431 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8432 ../lib/careadlinkat.h.
8434 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8436 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8437 first non-nil return value).
8439 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8441 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8442 if not defined (Bug#8403).
8444 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8446 * xdisp.c (display_count_lines): Remove parameter `start',
8447 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8448 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8449 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8450 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8451 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8452 and thereabouts. All callers changed.
8453 (get_per_char_metric): Remove parameter `f', unused since
8454 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8456 2011-04-02 Jim Meyering <meyering@redhat.com>
8458 do not dereference NULL upon failed strdup
8459 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8460 (ns_get_family): Likewise.
8462 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8464 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8466 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8468 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8471 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8473 Add lexical binding.
8475 * window.c (Ftemp_output_buffer_show): New fun.
8476 (Fsave_window_excursion):
8477 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8479 * lread.c (lisp_file_lexically_bound_p): New function.
8480 (Fload): Bind Qlexical_binding.
8481 (readevalloop): Remove `evalfun' arg.
8482 Bind Qinternal_interpreter_environment.
8483 (Feval_buffer): Bind Qlexical_binding.
8484 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8486 (syms_of_lread): Declare `lexical-binding'.
8488 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8490 * keyboard.c (eval_dyn): New fun.
8491 (menu_item_eval_property): Use it.
8493 * image.c (parse_image_spec): Use Ffunctionp.
8495 * fns.c (concat, mapcar1): Accept byte-code-functions.
8497 * eval.c (Fsetq): Handle lexical vars.
8498 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8499 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8500 (FletX, Flet): Obey lexical binding.
8501 (Fcommandp): Handle closures.
8502 (Feval): New `lexical' arg.
8503 (eval_sub): New function extracted from Feval. Use it almost
8504 everywhere where Feval was used. Look up vars in lexical env.
8506 (Ffunctionp): Move from subr.el.
8507 (Ffuncall): Handle closures.
8508 (apply_lambda): Remove `eval_flags'.
8509 (funcall_lambda): Handle closures and new byte-code-functions.
8510 (Fspecial_variable_p): New function.
8511 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8512 but without exporting it to Lisp.
8514 * doc.c (Fdocumentation, store_function_docstring):
8515 * data.c (Finteractive_form): Handle closures.
8517 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8520 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8522 (exec_byte_code): New function extracted from Fbyte_code to handle new
8523 calling convention for byte-code-functions. Add new byte-codes.
8525 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8527 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8529 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8531 * xdisp.c (redisplay_internal): Fix prototype.
8533 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8535 * xdisp.c (SCROLL_LIMIT): New macro.
8536 (try_scrolling): Use it when setting scroll_limit.
8537 Limit scrolling to 100 screen lines.
8538 (redisplay_window): Even when falling back on "recentering",
8539 position point in the window according to scroll-conservatively,
8540 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8542 (try_scrolling): When point is above the window, allow searching
8543 as far as scroll_max, or one screenful, to compute vertical
8544 distance from PT to the scroll margin position. This prevents
8545 try_scrolling from unnecessarily failing when
8546 scroll-conservatively is set to a value slightly larger than the
8547 window height. Clean up the case of PT below the margin at bottom
8548 of window: scroll_max can no longer be INT_MAX. When aggressive
8549 scrolling is in use, don't let point enter the opposite scroll
8550 margin as result of the scroll.
8551 (syms_of_xdisp) <scroll-conservatively>: Document the
8552 threshold of 100 lines for never-recentering scrolling.
8554 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8556 * dispextern.h (move_it_by_lines):
8557 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8558 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8559 (message_log_check_duplicate): Remove parameters `prev_bol' and
8560 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8561 (redisplay_internal): Remove parameter `preserve_echo_area',
8562 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8564 * indent.c (Fvertical_motion):
8565 * window.c (window_scroll_pixel_based, Frecenter):
8566 Don't pass `need_y_p' to `move_it_by_lines'.
8568 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8570 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8571 steal a few bits to be more compact.
8572 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8573 Remove unneeded casts.
8575 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8577 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8579 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8580 binding" message (bug#7967).
8582 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8584 Fix more problems found by GCC 4.6.0's static checks.
8586 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8587 Remove unused local var.
8589 * editfns.c (Fmessage_box): Remove unused local var.
8591 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8592 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8593 Omit unused local vars.
8594 * window.c (shrink_windows): Omit unused local var.
8595 * menu.c (digest_single_submenu): Omit unused local var.
8596 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8597 Omit unused local var.
8599 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8600 Don't assume string length fits in int.
8601 (keyremap_step, read_key_sequence): Use size_t for sizes.
8602 (read_key_sequence): Don't check last_real_key_start redundantly.
8604 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8605 instead of alloca (Bug#8344).
8607 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8608 (Fbacktrace_frame): Don't assume nframes fits in int.
8610 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8612 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8615 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8617 * cm.c (calccost): Turn while-do into do-while, for clarity.
8619 * keyboard.c (syms_of_keyboard): Use the same style as later
8620 in this function when indexing through an array. This also
8621 works around GCC bug 48267.
8623 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8625 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8627 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8628 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8630 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8631 This avoids undefined behavior on integer overflow, and is a bit
8632 more convenient anyway since it is compared to a size_t variable.
8634 Variadic C functions now count arguments with size_t, not int.
8635 This avoids an unnecessary limitation on 64-bit machines, which
8636 caused (substring ...) to crash on large vectors (Bug#8344).
8637 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8638 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8639 All variadic functions and their callers changed accordingly.
8640 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8641 * data.c (arith_driver, float_arith_driver): Likewise.
8642 * editfns.c (general_insert_function): Likewise.
8643 * eval.c (struct backtrace.nargs, interactive_p)
8644 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8645 (funcall_lambda, mark_backtrace): Likewise.
8646 * fns.c (concat): Likewise.
8647 * frame.c (x_set_frame_parameters): Likewise.
8648 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8649 0 if not found, not -1. All callers changed.
8651 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8652 (stack_copy_size): Now size_t, not int.
8653 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8655 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8657 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8658 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8659 All callers changed.
8661 * lisp.h (multibyte_char_to_unibyte):
8662 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8663 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8664 * character.h (CHAR_TO_BYTE8):
8665 * cmds.c (internal_self_insert):
8666 * editfns.c (general_insert_function):
8667 * keymap.c (push_key_description):
8668 * search.c (Freplace_match):
8669 * xdisp.c (message_dolog, set_message_1): All callers changed.
8671 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8673 * keyboard.c (safe_run_hook_funcall): New function.
8674 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8675 don't set the hook to nil, but remove the offending function instead.
8676 (Qcommand_hook_internal): Remove, unused.
8677 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8678 Vcommand_hook_internal.
8680 * eval.c (enum run_hooks_condition): Remove.
8681 (funcall_nil, funcall_not): New functions.
8682 (run_hook_with_args): Call each function through a `funcall' argument.
8683 Remove `cond' argument, now redundant.
8684 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8685 (Frun_hook_with_args_until_failure): Adjust accordingly.
8686 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8688 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8690 * dispextern.h (string_buffer_position): Remove declaration.
8692 * print.c (strout): Remove parameter `multibyte', unused since
8693 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8695 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8696 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8697 All callers changed.
8699 * w32.c (_wsa_errlist): Use braces for struct initializers.
8701 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8702 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8703 All callers changed.
8704 (string_buffer_position): Likewise. Also, make static (it's never
8705 used outside xdisp.c).
8706 (cursor_row_p): Remove parameter `w', unused since
8707 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8708 (decode_mode_spec): Remove parameter `precision', introduced during
8709 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8710 All callers changed.
8712 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8714 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8716 2011-03-27 Anders Lindgren <andlind@gmail.com>
8718 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8719 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8720 (ns_update_auto_hide_menu_bar): New functions.
8721 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8722 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8723 ns_constrain_all_frames.
8724 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8725 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8727 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8729 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8731 2011-03-27 Glenn Morris <rgm@gnu.org>
8733 * syssignal.h: Replace RETSIGTYPE with void.
8734 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8735 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8736 Replace SIGTYPE with void everywhere.
8737 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8738 * s/template.h (SIGTYPE): Remove commented out definition.
8740 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8742 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8743 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8745 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8747 * w32.c (read_unc_volume): Use parameter `henum', instead of
8748 global variable `wget_enum_handle'.
8750 * keymap.c (describe_vector): Remove parameters `indices' and
8751 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8752 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8754 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8756 * keyboard.c (timer_check): Remove parameter `do_it_now',
8757 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8758 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8759 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8761 * keyboard.c (read_char):
8762 * w32menu.c (w32_menu_display_help):
8763 * xmenu.c (show_help_event, menu_help_callback):
8764 Adjust calls to `show_help_echo'.
8766 * gtkutil.c (xg_maybe_add_timer):
8767 * keyboard.c (readable_events):
8768 * process.c (wait_reading_process_output):
8769 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8771 * insdel.c (adjust_markers_gap_motion):
8772 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8773 (gap_left, gap_right): Don't call it.
8775 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8777 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8778 incurred during fontification.
8780 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8782 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8783 (DEFVAR_PER_BUFFER): Don't pass it.
8785 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8786 (scrolling_window): Don't pass it.
8788 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8790 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8792 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8794 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8795 of variables specific to SELinux and computation of `encoded_absname'.
8797 * image.c (XPutPixel): Remove unused variable `height'.
8799 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8801 * unexw32.c (get_section_info): Remove unused variable `section'.
8803 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8804 (system_process_attributes): Remove unused variable `sess'.
8805 (sys_read): Remove unused variable `err'.
8807 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8808 (w32_wnd_proc): Remove unused variable `isdead'.
8809 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8810 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8811 (x_create_tip_frame): Remove unused variable `tem'.
8813 * w32inevt.c (w32_console_read_socket):
8814 Remove unused variable `no_events'.
8816 * w32term.c (x_draw_composite_glyph_string_foreground):
8817 Remove unused variable `width'.
8819 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8821 * w32term.c (x_set_glyph_string_clipping):
8822 Don't pass uninitialized region to CombineRgn.
8824 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8826 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8827 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8828 (Fx_close_connection): Remove unused variable `i'.
8830 * w32font.c (w32font_draw): Return number of glyphs.
8831 (w32font_open_internal): Remove unused variable `i'.
8832 (w32font_driver): Add missing initializer.
8834 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8835 (fill_in_menu): Remove unused variable `items_added'.
8837 * w32term.c (last_mouse_press_frame): Remove static global variable.
8838 (w32_clip_to_row): Remove unused variable `f'.
8839 (x_delete_terminal): Remove unused variable `i'.
8841 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8842 (NOTHING): Remove unused static global variable.
8843 (uniscribe_check_otf): Remove unused variable `table'.
8844 (uniscribe_font_driver): Add missing initializers.
8846 2011-03-23 Julien Danjou <julien@danjou.info>
8848 * term.c (Fsuspend_tty, Fresume_tty):
8849 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8850 * window.c (temp_output_buffer_show):
8851 * insdel.c (signal_before_change):
8852 * frame.c (Fhandle_switch_frame):
8853 * fileio.c (Fdo_auto_save):
8854 * emacs.c (Fkill_emacs):
8855 * editfns.c (save_excursion_restore):
8856 * cmds.c (internal_self_insert):
8857 * callint.c (Fcall_interactively):
8858 * buffer.c (Fkill_all_local_variables):
8859 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8861 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8862 unconditionally since it does the check itself.
8864 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8866 Fix more problems found by GCC 4.5.2's static checks.
8868 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8869 the first time through the loop, since we know p0 < p1 then.
8870 This also avoids a gcc -Wstrict-overflow warning.
8872 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8873 leading to a memory leak, possible in functions like
8874 load_charset_map_from_file that can allocate an unbounded number
8875 of objects (Bug#8318).
8877 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8878 that could (at least in theory) be that large.
8880 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8881 This is less likely to overflow, and avoids undefined behavior if
8882 overflow does occur. All callers changed. Use strtoul to scan
8883 for the unsigned long integer.
8884 (pint2hrstr): Simplify and tune code slightly.
8885 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8887 * scroll.c (do_scrolling): Work around GCC bug 48228.
8888 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8890 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8891 This also avoids a warning with gcc -Wstrict-overflow.
8892 (validate_x_resource_name): Simplify count usage.
8893 This also avoids a warning with gcc -Wstrict-overflow.
8895 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8898 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8900 * process.c (Fmake_network_process): Use socklen_t, not int,
8901 where POSIX says socklen_t is required in portable programs.
8902 This fixes a porting bug on hosts like 64-bit HP-UX, where
8903 socklen_t is wider than int (Bug#8277).
8904 (Fmake_network_process, server_accept_connection):
8905 (wait_reading_process_output, read_process_output):
8908 * process.c: Rename or move locals to avoid shadowing.
8909 (list_processes_1, Fmake_network_process):
8910 (read_process_output_error_handler, exec_sentinel_error_handler):
8911 Rename or move locals.
8912 (Fmake_network_process): Define label "retry_connect" only if needed.
8913 (Fnetwork_interface_info): Fix pointer signedness.
8914 (process_send_signal): Add cast to avoid pointer signedness problem.
8915 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8916 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8918 Make tparam.h and terminfo.c consistent.
8919 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8920 Include tparam.h instead, since it declares them.
8921 * cm.h (PC): Remove extern decl; tparam.h now does this.
8922 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8923 * terminfo.c: Include tparam.h, to check interfaces.
8924 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8925 (tparam): Adjust signature to match interface in tparam.h;
8926 this removes some undefined behavior. Check that outstring and len
8927 are zero, which they always are with Emacs.
8928 * tparam.h (PC, BC, UP): New extern decls.
8930 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8931 (xftfont_open): Rename locals to avoid shadowing.
8933 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8934 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8935 (OTF_TAG_SYM): Omit macro if not needed.
8936 (ftfont_list): Remove unused local.
8937 (get_adstyle_property, ftfont_pattern_entity):
8938 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8939 Rename locals to avoid shadowing.
8941 * xfont.c (xfont_list_family): Mark var as initialized.
8943 * xml.c (make_dom): Now static.
8945 * composite.c (composition_compute_stop_pos): Rename local to
8947 (composition_reseat_it): Remove unused locals.
8948 (find_automatic_composition, composition_adjust_point): Likewise.
8949 (composition_update_it): Mark var as initialized.
8950 (find_automatic_composition): Mark vars as initialized,
8951 with a FIXME (Bug#8290).
8953 character.h: Rename locals to avoid shadowing.
8954 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8955 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8956 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8957 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8960 * textprop.c (property_change_between_p): Remove; unused.
8962 * intervals.c (interval_start_pos): Now static.
8964 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8966 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8967 Rename locals to avoid shadowing.
8969 * sound.c (wav_play, au_play, Fplay_sound_internal):
8970 Fix pointer signedness.
8971 (alsa_choose_format): Remove unused local var.
8972 (wav_play): Initialize a variable to 0, to prevent undefined
8973 behavior (Bug#8278).
8975 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8977 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8979 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8980 clobbering (Bug#8298).
8981 * sysdep.c (sys_subshell): Likewise.
8982 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8984 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8985 This should get cleaned up, so that child_setup has the
8986 same signature on all platforms.
8988 * callproc.c (call_process_cleanup): Now static.
8989 (relocate_fd): Rename locals to avoid shadowing.
8991 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8993 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8994 not to be necessary, and produces flickering.
8996 2011-03-20 Glenn Morris <rgm@gnu.org>
8998 * config.in: Remove file.
9000 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9002 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9003 are now in src/globals.h.
9004 (syms_of_minibuf): Remove spurious & from previous change.
9006 2011-03-20 Leo Liu <sdl.web@gmail.com>
9008 * minibuf.c (completing-read-function): New variable.
9009 (completing-read-default): Rename from completing-read.
9010 (completing-read): Call completing-read-function.
9012 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9014 * xfaces.c (Fx_load_color_file):
9015 Read color file from absolute filename (bug#8250).
9017 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9019 * makefile.w32-in: Update dependencies.
9021 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9023 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9025 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9027 Fix more problems found by GCC 4.5.2's static checks.
9029 * process.c (make_serial_process_unwind, send_process_trap):
9030 (sigchld_handler): Now static.
9032 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9033 That way, the code declares only the vars that it needs.
9034 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9035 * s/cygwin.h (PTY_ITERATION): Likewise.
9036 * s/darwin.h (PTY_ITERATION): Likewise.
9037 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9039 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9040 * process.c (allocate_pty): Don't declare stb unless it's needed.
9042 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9043 (CONSTANTLIM): Remove; unused.
9044 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9045 Define only if needed.
9047 * unexelf.c (unexec): Name an expression,
9048 to avoid gcc -Wbad-function-cast warning.
9049 Use a different way to cause a compilation error if anyone uses
9050 n rather than nn, a way that does not involve shadowing.
9051 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9053 * deps.mk (unexalpha.o): Remove; unused.
9055 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9056 * unexec.h: New file.
9057 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9058 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9060 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9061 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9062 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9063 Change as necessary to match prototype in unexec.h.
9065 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9067 (back_comment, skip_chars): Mark vars as initialized.
9069 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9070 Rename locals to avoid shadowing.
9072 * lread.c (read1): Rewrite so as not to use empty "else".
9073 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9075 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9077 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9078 warning when compiling print.c.
9080 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9081 instead of using an uninitialized var.
9082 (font_sort_entities): Mark var as initialized.
9084 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9086 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9087 pointers to constants.
9088 (font_parse_fcname): Remove unused vars.
9089 (font_delete_unmatched): Now static.
9090 (font_get_spec): Remove; unused.
9091 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9092 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9093 Rename or move locals to avoid shadowing.
9095 * fns.c (require_nesting_list, require_unwind): Now static.
9096 (Ffillarray): Rename locals to avoid shadowing.
9098 * floatfns.c (domain_error2): Define only if needed.
9099 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9101 * alloc.c (mark_backtrace): Move decl from here ...
9102 * lisp.h: ... to here, so that it can be checked.
9104 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9105 (Fdefvar): Rewrite so as not to use empty "else".
9106 (lisp_indirect_variable): Name an expression,
9107 to avoid gcc -Wbad-function-cast warning.
9108 (Fdefvar): Rename locals to avoid shadowing.
9110 * callint.c (quotify_arg, quotify_args): Now static.
9111 (Fcall_interactively): Rename locals to avoid shadowing.
9112 Use const pointer when appropriate.
9114 * lisp.h (get_system_name, get_operating_system_release):
9115 Move decls here, to check interfaces.
9116 * process.c (get_operating_system_release): Move decl to lisp.h.
9117 * xrdb.c (get_system_name): Likewise.
9118 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9119 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9120 some of which prompt warnings from gcc -Wbad-function-cast.
9121 (Fformat_time_string, Fencode_time, Finsert_char):
9122 (Ftranslate_region_internal, Fformat):
9123 Rename or remove local vars to avoid shadowing.
9124 (Ftranslate_region_internal): Mark var as initialized.
9126 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9129 * lisp.h (eassert): Check that the argument compiles, even if
9130 ENABLE_CHECKING is not defined.
9132 * data.c (Findirect_variable): Name an expression, to avoid
9133 gcc -Wbad-function-cast warning.
9134 (default_value, arithcompare, arith_driver, arith_error): Now static.
9135 (store_symval_forwarding): Rename local to avoid shadowing.
9136 (Fmake_variable_buffer_local, Fmake_local_variable):
9137 Mark variables as initialized.
9138 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9140 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9141 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9142 Rename locals to avoid shadowing.
9143 (mark_stack): Move local variables into the #ifdef region where
9145 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9146 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9148 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9149 (GC_STRING_CHARS): Remove; not used.
9150 (Fmemory_limit): Cast sbrk's returned value to char *.
9152 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9153 avoids undefined behavior in theory.
9155 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9157 Use functions, not macros, for up- and down-casing (Bug#8254).
9158 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9159 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9160 to use the following functions instead of these macros.
9161 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9162 EMACS_INT, since callers assume the returned value fits in int.
9163 (upcase1): Likewise, for UPCASE_TABLE.
9164 (uppercasep, lowercasep, upcase): New static inline functions.
9165 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9166 the race-condition problem in the old DOWNCASE.
9168 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9169 Rename locals to avoid shadowing.
9170 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9171 (regex_compile, re_search_2, re_match_2_internal):
9172 Remove unused local vars.
9173 (FREE_VAR): Rewrite so as not to use empty "else",
9174 which gcc can warn about.
9175 (regex_compile, re_match_2_internal): Mark locals as initialized.
9176 (RETALLOC_IF): Define only if needed.
9177 (WORDCHAR_P): Likewise. This one is never needed, but is used
9178 only in a comment talking about a compiler bug, so put inside
9179 the #if 0 of that comment.
9180 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9181 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9184 * search.c (boyer_moore): Rename locals to avoid shadowing.
9185 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9186 (PREV_CHAR_BOUNDARY): Likewise.
9188 * search.c (simple_search): Remove unused var.
9190 * dired.c (compile_pattern): Move decl from here ...
9191 * lisp.h: ... to here, so that it can be checked.
9192 (struct re_registers): New forward decl.
9194 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9196 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9198 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9199 Rename locals to avoid shadowing.
9200 (Fvertical_motion): Mark locals as initialized.
9202 * casefiddle.c (casify_object, casify_region): Now static.
9203 (casify_region): Mark local as initialized.
9205 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9207 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9208 New macros, so that the caller can use some names other than
9209 gcpro1, gcpro2, etc.
9210 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9212 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9213 argument, for consistency with GCPRO2_VAR, etc: it is now the
9214 prefix of the variable, not the variable itself. All uses
9216 * dired.c (directory_files_internal, file_name_completion):
9217 Rename locals to avoid shadowing.
9219 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9220 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9221 dired.c's scmp function, had undefined behavior.
9222 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9223 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9224 * buffer.h: ... to here, because these macros use current_buffer,
9225 and the new implementation with inline functions needs to have
9226 current_buffer in scope now, rather than later when the macros
9228 (downcase, upcase1): New static inline functions.
9229 (DOWNCASE, UPCASE1): Reimplement using these functions.
9230 This avoids undefined behavior in expressions like
9231 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9232 from race conditions in accessing the global variables
9233 case_temp1 and case_temp2.
9234 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9235 * lisp.h (case_temp1, case_temp2): Remove their decls.
9236 * character.h (ASCII_CHAR_P): Move from here ...
9237 * lisp.h: ... to here, so that the inline functions mentioned
9240 * dired.c (directory_files_internal_unwind): Now static.
9242 * fileio.c (file_name_as_directory, directory_file_name):
9243 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9245 (file_name_as_directory): Use const pointers when appropriate.
9246 (Fexpand_file_name): Likewise. In particular, newdir might
9247 point at constant storage, so make it a const pointer.
9248 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9249 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9251 (Fset_file_times, Finsert_file_contents, auto_save_error):
9252 Rename locals to avoid shadowing.
9254 * minibuf.c (choose_minibuf_frame_1): Now static.
9255 (Ftry_completion, Fall_completions): Rename or remove locals
9258 * marker.c (bytepos_to_charpos): Remove; unused.
9260 * lisp.h (verify_bytepos, count_markers): New decls,
9261 so that gcc does not warn that these functions aren't declared.
9263 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9264 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9265 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9266 (copy_text): Remove unused local var.
9268 * filelock.c (within_one_second): Now static.
9269 (lock_file_1): Rename local to avoid shadowing.
9271 * buffer.c (fix_overlays_before): Mark locals as initialized.
9272 (fix_start_end_in_overlays): Likewise. This function should be
9273 simplified by using pointers-to-pointers, but that's a different
9275 (switch_to_buffer_1): Now static.
9276 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9277 (report_overlay_modification): Rename locals to avoid shadowing.
9279 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9280 Fix pointer signedness issue.
9281 (sys_subshell): Mark local as volatile if checking for lint,
9282 to suppress a gcc -Wclobbered warning that does not seem to be right.
9283 (MAXPATHLEN): Define only if needed.
9285 * process.c (serial_open, serial_configure): Move decls from here ...
9286 * systty.h: ... to here, so that they can be checked.
9288 * fns.c (get_random, seed_random): Move extern decls from here ...
9289 * lisp.h: ... to here, so that they can be checked.
9291 * sysdep.c (reset_io): Now static.
9292 (wait_for_termination_signal): Remove; unused.
9294 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9295 (copy_keymap_item, append_key, push_text_char_description):
9297 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9298 (DENSE_TABLE_SIZE): Remove; unused.
9299 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9300 (describe_map_tree):
9301 Rename locals to avoid shadowing.
9303 * keyboard.c: Declare functions static if they are not used elsewhere.
9304 (echo_char, echo_dash, cmd_error, top_level_2):
9305 (poll_for_input, handle_async_input): Now static.
9306 (read_char, kbd_buffer_get_event, make_lispy_position):
9307 (make_lispy_event, make_lispy_movement, apply_modifiers):
9308 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9309 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9310 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9311 (read_key_sequence, read_char): Mark locals as initialized.
9312 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9314 * keyboard.h (make_ctrl_char): New decl.
9315 (mark_kboards): Move decl here ...
9316 * alloc.c (mark_kboards): ... from here.
9318 * lisp.h (force_auto_save_soon): New decl.
9320 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9321 (DEFINE_DUMMY_FUNCTION): New macro.
9322 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9324 (main): Add casts to avoid warnings
9325 if GCC considers string literals to be constants.
9327 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9329 * dbusbind.c: Pointer signedness fixes.
9330 (xd_signature, xd_append_arg, xd_initialize):
9331 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9332 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9333 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9334 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9336 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9337 if GCC considers string literals to be constants.
9338 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9340 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9342 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9343 (print_preprocess, print_object): New macro to fix last change.
9345 * print.c (print_preprocess): Don't forget font objects.
9347 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9349 * emacs.c (USAGE3): Doc fixes.
9351 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9353 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9356 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9358 * lisp.h (VWindow_system, Qfile_name_history):
9359 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9360 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9361 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9363 * w32select.c: Don't #include "keyboard.h".
9364 (run_protected): Add extern declaration for waiting_for_input.
9366 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9367 * w32console.c (detect_input_pending, read_input_pending)
9368 (encode_terminal_code):
9369 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9370 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9371 (w32_system_caret_y, Qfile_name_history):
9372 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9373 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9374 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9375 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9376 * w32proc.c (Qlocal, report_file_error):
9377 * w32term.c (Vwindow_system, updating_frame):
9378 * w32uniscribe.c (initialized, uniscribe_font_driver):
9379 Remove unneeded extern declarations.
9381 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9383 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9385 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9387 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9388 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9389 These macros can no longer be used for assignment.
9391 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9392 Assign struct members directly, instead of using BUF_BEGV etc.
9393 (record_buffer_markers, fetch_buffer_markers): New functions for
9394 recording and fetching special buffer markers.
9395 (set_buffer_internal_1, set_buffer_temp): Use them.
9397 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9399 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9401 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9402 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9404 * xdisp.c (hscroll_window_tree):
9405 (reconsider_clip_changes): Use PT instead of BUF_PT.
9407 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9409 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9410 $(EMACS_ROOT)/lib/intprops.h.
9412 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9414 Fix more problems found by GCC 4.5.2's static checks.
9416 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9417 to unsigned char * to avoid compiler diagnostic.
9418 (xg_free_frame_widgets): Make it clear that a local variable is
9419 needed only if USE_GTK_TOOLTIP.
9420 (gdk_window_get_screen): Make it clear that this macro is needed
9421 only if USE_GTK_TOOLTIP.
9422 (int_gtk_range_get_value): New function, which avoids a diagnostic
9423 from gcc -Wbad-function-cast.
9424 (xg_set_toolkit_scroll_bar_thumb): Use it.
9425 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9426 diagnostic from gcc -Wbad-function-cast.
9427 (get_utf8_string, xg_get_file_with_chooser):
9428 Rename locals to avoid shadowing.
9429 (create_dialog): Move locals to avoid shadowing.
9431 * xgselect.c (xg_select): Remove unused var.
9433 * image.c (four_corners_best): Mark locals as initialized.
9434 (gif_load): Initialize transparent_p to zero (Bug#8238).
9435 Mark another local as initialized.
9436 (my_png_error, my_error_exit): Mark with NO_RETURN.
9438 * image.c (clear_image_cache): Now static.
9439 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9440 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9441 (x_edge_detection): Remove unnecessary cast that
9442 gcc -Wbad-function-cast diagnoses.
9443 (gif_load): Fix pointer signedness.
9444 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9445 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9447 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9449 Improve quality of tests for time stamp overflow.
9450 For example, without this patch (encode-time 0 0 0 1 1
9451 1152921504606846976) returns the obviously-bogus value (-948597
9452 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9453 reports time overflow. See
9454 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9455 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9456 * editfns.c: Include limits.h and intprops.h.
9457 (TIME_T_MIN, TIME_T_MAX): New macros.
9458 (time_overflow): Move earlier, to before first use.
9459 (hi_time, lo_time): New functions, for an accurate test for
9461 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9462 (Fget_internal_run_time): Don't assume time_t fits in int.
9463 (make_time): Use list2 instead of Fcons twice.
9464 (Fdecode_time): More accurate test for out-of-range times.
9465 (check_tm_member): New function.
9466 (Fencode_time): Use it, to test for out-of-range times.
9467 (lisp_time_argument): Don't rely on undefined left-shift and
9468 right-shift behavior when checking for time stamp overflow.
9470 * editfns.c (time_overflow): New function, refactoring common code.
9471 (Fformat_time_string, Fdecode_time, Fencode_time):
9472 (Fcurrent_time_string): Use it.
9474 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9475 * dired.c (make_time): Move to ...
9476 * editfns.c (make_time): ... here.
9477 * systime.h: Note the move.
9479 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9481 * fringe.c (update_window_fringes): Remove unused variables.
9483 * unexmacosx.c (copy_data_segment): Also copy __got section.
9486 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9488 * termcap.c [MSDOS]: Include "msdos.h".
9489 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9490 Constify `char *' arguments and their references according to
9491 prototypes in tparam.h.
9493 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9495 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9496 Adapt all references accordingly.
9498 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9500 2011-03-11 Tom Tromey <tromey@redhat.com>
9502 * buffer.c (syms_of_buffer): Remove obsolete comment.
9504 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9506 * termhooks.h (encode_terminal_code): Declare prototype.
9508 * msdos.c (encode_terminal_code): Don't declare prototype.
9510 * term.c (encode_terminal_code): Now external again, used by
9511 w32console.c and msdos.c.
9513 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9514 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9516 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9518 Fix some minor problems found by GCC 4.5.2's static checks.
9520 * fringe.c (update_window_fringes): Mark locals as initialized
9522 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9524 * alloc.c (mark_fringe_data): Move decl from here ...
9525 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9526 to check its interface.
9527 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9529 * fontset.c (free_realized_fontset): Now static.
9530 (Fset_fontset_font): Rename local to avoid shadowing.
9531 (fontset_font): Mark local as initialized.
9532 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9534 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9536 * xselect.c (x_disown_buffer_selections): Remove; not used.
9537 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9538 (x_own_selection, Fx_disown_selection_internal): Rename locals
9540 (x_handle_dnd_message): Remove local to avoid shadowing.
9542 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9543 so that the caller can use some name other than gcpro1.
9544 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9545 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9546 (Fx_backspace_delete_keys_p):
9547 Use them to avoid shadowing, and rename vars to avoid shadowing.
9548 (x_decode_color, x_set_name, x_window): Now static.
9549 (Fx_create_frame): Add braces to silence GCC warning.
9550 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9551 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9552 Remove unused locals.
9553 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9554 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9555 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9558 * xterm.h (x_mouse_leave): New decl.
9560 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9561 Remove unused functions.
9562 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9563 (x_calc_absolute_position): Now static.
9564 (XTread_socket): Don't define label "out" unless it's used.
9565 Don't declare local "event" unless it's used.
9566 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9567 unless they are used.
9568 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9569 (x_fatal_error_signal): Remove; not used.
9570 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9571 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9572 (x_error_catcher, x_connection_closed, x_error_handler):
9573 (x_error_quitter, xembed_send_message, x_iconify_frame):
9574 (my_log_handler): Rename locals to avoid shadowing.
9575 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9576 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9578 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9579 Rename or move locals to avoid shadowing.
9580 (tty_defined_color, merge_face_heights): Now static.
9581 (free_realized_faces_for_fontset): Remove; not used.
9582 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9583 does not deduce is never used uninitialized.
9584 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9585 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9587 * terminal.c (store_terminal_param): Now static.
9589 * xmenu.c (menu_highlight_callback): Now static.
9590 (set_frame_menubar): Remove unused local.
9591 (xmenu_show): Rename parameter to avoid shadowing.
9592 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9593 since they might point to immutable storage.
9594 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9595 since it's unused otherwise.
9597 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9598 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9599 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9600 avoids a gcc -Wuninitialized diagnostic.
9601 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9602 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9603 does not deduce are never used uninitialized.
9605 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9607 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9608 * window.c (window_loop, size_window):
9609 (run_window_configuration_change_hook, enlarge_window): Likewise.
9611 * window.c (display_buffer): Now static.
9612 (size_window): Mark variables that gcc -Wuninitialized
9613 does not deduce are never used uninitialized.
9614 * window.h (check_all_windows): New decl, to forestall
9615 gcc -Wmissing-prototypes diagnostic.
9616 * dispextern.h (bidi_dump_cached_states): Likewise.
9618 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9620 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9622 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9623 and to avoid gcc -Wuninitialized warning.
9624 (load_charset_map): Mark variables that gcc -Wuninitialized
9625 does not deduce are never used uninitialized.
9626 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9628 * coding.c (coding_set_source, coding_set_destination):
9629 Use "else { /* comment */ }" rather than "else /* comment */;"
9630 for clarity, and to avoid gcc -Wempty-body warning.
9631 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9632 a block, when the outer 'i' will do.
9633 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9634 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9635 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9636 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9637 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9638 Rename locals to avoid shadowing.
9639 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9640 * coding.c (emacs_mule_char, encode_invocation_designation):
9641 Now static, since they're not used elsewhere.
9642 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9643 (decode_coding_object, encode_coding_object, detect_coding_system):
9644 (decode_coding_emacs_mule): Mark variables that gcc
9645 -Wuninitialized does not deduce are never used uninitialized.
9646 (detect_coding_iso_2022): Initialize a local variable that might
9647 be used uninitialized. Leave a FIXME because it's not clear that
9648 this initialization is needed. (Bug#8211)
9649 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9650 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9651 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9652 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9653 Remove unused macros.
9655 * category.c (hash_get_category_set): Remove unused local var.
9656 (copy_category_table): Now static, since it's not used elsewhere.
9657 * character.c (string_count_byte8): Likewise.
9659 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9660 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9662 * chartab.c (copy_sub_char_table): Now static, since it's not used
9664 (sub_char_table_ref_and_range, char_table_ref_and_range):
9665 Rename locals to avoid shadowing.
9666 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9668 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9669 (BIDI_BOB): Remove unused macro.
9671 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9672 deduce are never used uninitialized.
9673 * term.c (encode_terminal_code): Likewise.
9675 * term.c (encode_terminal_code): Now static. Remove unused local.
9677 * tparam.h: New file.
9678 * term.c, tparam.h: Include it.
9679 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9680 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9681 Move these decls to tparam.h, and make them agree with what
9682 is actually in tparam.c. The previous trick of using incompatible
9683 decls in different modules does not conform to the C standard.
9684 All callers of tparam changed to use tparam's actual API.
9685 * tparam.c (tparam1, tparam, tgoto):
9686 Use const pointers where appropriate.
9688 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9689 * cm.h (struct cm): Likewise.
9690 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9691 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9692 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9693 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9694 (turn_on_face, init_tty): Likewise.
9695 * termchar.h (struct tty_display_info): Likewise.
9697 * term.c (term_mouse_position): Rename local to avoid shadowing.
9699 * alloc.c (mark_ttys): Move decl from here ...
9700 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9702 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9704 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9706 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9708 * search.c (compile_pattern_1): Remove argument regp, unused since
9709 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9710 (compile_pattern): Don't pass it.
9712 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9714 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9715 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9717 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9719 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9721 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9722 gdk_window_get_screen, gdk_window_get_geometry,
9723 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9724 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9725 (xg_get_pixbuf_from_pixmap): New function.
9726 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9727 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9728 Call xg_get_pixbuf_from_pixmap instead of
9729 gdk_pixbuf_get_from_drawable.
9730 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9731 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9732 (xg_check_special_colors): Use GtkStyleContext and its functions
9734 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9735 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9736 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9737 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9738 Call gtk_widget_get_preferred_size.
9739 (xg_frame_resized): gdk_window_get_geometry only takes 5
9741 (xg_win_to_widget, xg_event_is_for_menubar):
9742 Call gdk_x11_window_lookup_for_display.
9743 (xg_set_widget_bg): New function.
9744 (delete_cb): New function.
9745 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9746 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9747 (xg_set_background_color): Call xg_set_widget_bg.
9748 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9749 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9750 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9751 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9753 (update_frame_tool_bar): Call gtk_widget_hide.
9754 (xg_initialize): Use GDK_KEY_g.
9756 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9758 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9760 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9761 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9762 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9764 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9766 * w32xfns.c (select_palette): Check success of RealizePalette against
9767 GDI_ERROR, not zero.
9769 See ChangeLog.11 for earlier changes.
9775 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9777 This file is part of GNU Emacs.
9779 GNU Emacs is free software: you can redistribute it and/or modify
9780 it under the terms of the GNU General Public License as published by
9781 the Free Software Foundation, either version 3 of the License, or
9782 (at your option) any later version.
9784 GNU Emacs is distributed in the hope that it will be useful,
9785 but WITHOUT ANY WARRANTY; without even the implied warranty of
9786 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9787 GNU General Public License for more details.
9789 You should have received a copy of the GNU General Public License
9790 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.