1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3 * termcap.c: Don't assume sizes fit in int and never overflow.
4 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5 (gobble_line): Check for size-calculation overflow.
7 * minibuf.c (Fread_buffer):
8 * lread.c (intern, intern_c_string):
9 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10 Don't assume string length fits in int.
12 * keyboard.c (parse_tool_bar_item):
13 * gtkutil.c (style_changed_cb): Avoid need for strlen.
15 * font.c: Don't assume string length fits in int.
16 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
17 Use ptrdiff_t, not int.
18 (font_intern_prop): Don't assume string length fits in int.
19 Don't assume integer property fits in fixnum.
20 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
22 * filelock.c: Fix some buffer overrun and integer overflow issues.
23 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
24 Reformulate so as not to need the command string.
25 Invoke gzip -cd rather than gunzip, as it's more portable.
26 (lock_info_type, lock_file_1, lock_file):
27 Don't assume pid_t and time_t fit in unsigned long.
28 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
29 (current_lock_owner): Prefer signed type for sizes.
30 Use memcpy, not strncpy, where memcpy is what is really wanted.
31 Don't assume (via atoi) that time_t and pid_t fit in int.
32 Check for time_t and/or pid_t out of range, e.g., via a network share.
33 Don't alloca where an auto var works fine.
35 * fileio.c: Fix some integer overflow issues.
36 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
37 Don't assume string length fits in int.
38 (directory_file_name): Don't assume string length fits in long.
39 (make_temp_name): Don't assume pid fits in int, or that its print
40 length is less than 20.
42 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
44 * coding.c (make_subsidiaries): Don't assume string length fits in int.
46 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
48 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
49 We prefer signed integers, even for size calculations.
51 * emacs.c: Don't assume string length fits in 'int'.
52 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
53 (main): Don't invoke strlen when not needed.
55 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
56 (XD_DEBUG_MESSAGE): Don't waste a byte.
58 * callproc.c (getenv_internal_1, getenv_internal)
60 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
62 * lread.c (invalid_syntax): Omit length argument.
63 All uses changed. This doesn't fix a bug, but it simplifies the
64 code away from its former Hollerith-constant appearance, and it's
65 one less 'int' to worry about when looking at integer-overflow issues.
66 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
68 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
69 This didn't break anything, but it didn't help either.
70 It's confusing to put a bogus integer in a place where the actual
71 value does not matter.
72 (LIST_END_P): Remove unused macro and its bogus comment.
73 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
75 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
76 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
78 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
79 We prefer signed types, and the value cannot exceed the EMACS_INT
80 range anyway (because otherwise the length would not be representable).
81 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
82 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
83 This avoids a GCC warning when WIDE_EMACS_INT.
85 * indent.c (sane_tab_width): New function.
86 (current_column, scan_for_column, Findent_to, position_indentation)
87 (compute_motion): Use it. This is just for clarity.
88 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
90 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
92 * lisp.h (lint_assume): New macro.
93 * composite.c (composition_gstring_put_cache):
94 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
96 * editfns.c, insdel.c:
97 Omit unnecessary forward decls, to simplify future changes.
99 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
101 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
103 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
104 Use much-faster test for byte-length change.
105 Don't assume string byte-length fits in 'int'.
106 Check that character arg fits in 'int'.
107 (mapcar1): Declare byte as byte, for clarity.
109 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
111 * fns.c (concat): Catch string overflow earlier.
112 Do not rely on integer wraparound.
114 * dispextern.h (struct it.overlay_strings_charpos)
115 (struct it.selective): Now EMACS_INT, not int.
116 * xdisp.c (forward_to_next_line_start)
117 (back_to_previous_visible_line_start)
118 (reseat_at_next_visible_line_start, next_element_from_buffer):
119 Don't arbitrarily truncate the value of 'selective' to int.
121 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
123 * composite.c: Don't truncate sizes to 'int'.
124 (composition_gstring_p, composition_reseat_it)
125 (composition_adjust_point): Use EMACS_INT, not int.
126 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
127 not EMACS_UINT, for indexes.
129 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
131 * buffer.c: Include <verify.h>.
132 (struct sortvec.priority, struct sortstr.priority):
133 Now EMACS_INT, not int.
134 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
135 (struct sortstr.size, record_overlay_string)
136 (struct sortstrlist.size, struct sortlist.used):
137 Don't truncate size to int.
138 (record_overlay_string): Check for size-calculation overflow.
139 (init_buffer_once): Check at compile-time, not run-time.
141 2011-06-20 Deniz Dogan <deniz@dogan.se>
143 * process.c (Fset_process_buffer): Clarify return value in
146 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
148 * dispnew.c (add_window_display_history): Use BVAR.
150 * xdisp.c (debug_method_add): Use BVAR.
151 (check_window_end, dump_glyph_matrix, dump_glyph)
152 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
154 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
157 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
158 check till after the cache is created in init_frame_faces.
160 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
162 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
164 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
166 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
167 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
168 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
170 Improve buffer-overflow checking (Bug#8873).
171 * fileio.c (Finsert_file_contents):
172 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
173 Remove the old (too-loose) buffer overflow checks.
174 They weren't needed, since make_gap checks for buffer overflow.
175 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
176 The old code merely checked for Emacs fixnum overflow, and relied
177 on undefined (wraparound) behavior. The new code avoids undefined
178 behavior, and also checks for ptrdiff_t and/or size_t overflow.
180 * editfns.c (Finsert_char): Don't dump core with very negative counts.
181 Tune. Don't use wider integers than needed. Don't use alloca.
182 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
184 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
186 * insdel.c, lisp.h (buffer_overflow): New function.
187 (insert_from_buffer_1, replace_range, replace_range_2):
188 * insdel.c (make_gap_larger):
189 * editfns.c (Finsert_char):
190 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
192 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
194 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
196 Integer overflow and signedness fixes (Bug#8873).
198 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
199 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
201 * fileio.c: Don't assume EMACS_INT fits in off_t.
202 (emacs_lseek): New static function.
203 (Finsert_file_contents, Fwrite_region): Use it.
204 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
206 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
208 * fns.c: Don't overflow int when computing a list length.
209 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
210 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
211 truncation on 64-bit hosts. Check for QUIT every
212 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
213 faster and is responsive enough.
214 (Flength): Report an error instead of overflowing an integer.
215 (Fsafe_length): Return a float if the value is not representable
216 as a fixnum. This shouldn't happen except in contrived situations.
217 (Fnthcdr, Fsort): Don't assume list length fits in int.
218 (Fcopy_sequence): Don't assume vector length fits in int.
220 * alloc.c: Check that resized vectors' lengths fit in fixnums.
221 (header_size, word_size): New constants.
222 (allocate_vectorlike): Don't check size overflow here.
223 (allocate_vector): Check it here instead, since this is the only
224 caller of allocate_vectorlike that could cause overflow.
225 Check that the new vector's length is representable as a fixnum.
227 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
228 The previous code was bogus. For example, next_almost_prime (32)
229 returned 39, which is undesirable as it is a multiple of 3; and
230 next_almost_prime (24) returned 25, which is a multiple of 5 so
231 why was the code bothering to check for multiples of 7?
233 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
235 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
237 Variadic C functions now count arguments with ptrdiff_t.
238 This partly undoes my 2011-03-30 change, which replaced int with size_t.
239 Back then I didn't know that the Emacs coding style prefers signed int.
240 Also, in the meantime I found a few more instances where arguments
241 were being counted with int, which may truncate counts on 64-bit
242 machines, or EMACS_INT, which may be unnecessarily wide.
243 * lisp.h (struct Lisp_Subr.function.aMANY)
244 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
245 Arg counts are now ptrdiff_t, not size_t.
246 All variadic functions and their callers changed accordingly.
247 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
248 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
249 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
250 * callint.c (Fcall_interactively): Check arg count for overflow,
251 to avoid potential buffer overrun. Use signed char, not 'int',
252 for 'varies' array, so that we needn't bother to check its size
253 calculation for overflow.
254 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
255 * eval.c (apply_lambda):
256 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
257 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
258 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
260 * callint.c (Fcall_interactively): Don't use index var as event count.
262 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
263 * mem-limits.h (SIZE): Remove; no longer used.
265 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
267 Remove unnecessary casts.
268 * xterm.c (x_term_init):
269 * xfns.c (x_set_border_pixel):
270 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
271 These aren't needed now that we assume ANSI C.
273 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
274 It's more likely to cause problems (due to unsigned overflow)
277 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
279 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
281 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
283 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
285 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
287 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
289 GLYPH_CODE_FACE returns EMACS_INT, not int.
290 * dispextern.h (merge_faces):
291 * xfaces.c (merge_faces):
292 * xdisp.c (get_next_display_element, next_element_from_display_vector):
293 Don't assume EMACS_INT fits in int.
295 * character.h (CHAR_VALID_P): Remove unused parameter.
296 * fontset.c, lisp.h, xdisp.c: All uses changed.
298 * editfns.c (Ftranslate_region_internal): Omit redundant test.
300 * fns.c (concat): Minor tuning based on overflow analysis.
301 This doesn't fix any bugs. Use int to hold character, instead
302 of constantly refetching from Emacs object. Use XFASTINT, not
303 XINT, for value known to be a character. Don't bother comparing
304 a single byte to 0400, as it's always less.
306 * floatfns.c (Fexpt):
307 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
309 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
312 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
314 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
315 Without this fix, on a 64-bit host (aset S 0 4294967386) would
316 incorrectly succeed when S was a string, because 4294967386 was
317 truncated before it was used.
319 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
320 Otherwise, an out-of-range integer could cause undefined behavior
323 * composite.c: Use int, not EMACS_INT, for characters.
324 (fill_gstring_body, composition_compute_stop_pos): Use int, not
325 EMACS_INT, for values that are known to be in character range.
326 This doesn't fix any bugs but is the usual style inside Emacs and
327 may generate better code on 32-bit machines.
329 Make sure a 64-bit char is never passed to ENCODE_CHAR.
330 This is for reasons similar to the recent CHAR_STRING fix.
331 * charset.c (Fencode_char): Check that character arg is actually
332 a character. Pass an int to ENCODE_CHAR.
333 * charset.h (ENCODE_CHAR): Verify that the character argument is no
334 wider than 'int', as a compile-time check to prevent future regressions
337 * character.c (char_string): Remove unnecessary casts.
339 Make sure a 64-bit char is never passed to CHAR_STRING.
340 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
341 by silently ignoring the top 32 bits, allowing some values
342 that were far too large to be valid characters.
343 * character.h: Include <verify.h>.
344 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
345 arguments are no wider than unsigned, as a compile-time check
346 to prevent future regressions in this area.
348 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
349 (Fsubst_char_in_region):
351 * xdisp.c (decode_mode_spec_coding):
352 Adjust to CHAR_STRING's new requirement.
353 * editfns.c (Finsert_char, Fsubst_char_in_region):
354 * fns.c (concat): Check that character args are actually
355 characters. Without this test, these functions did the wrong
356 thing with wildly out-of-range values on 64-bit hosts.
358 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
359 These casts should not be needed on 32-bit hosts, either.
360 * keyboard.c (read_char):
361 * lread.c (Fload): Remove casts to unsigned.
363 * lisp.h (UNSIGNED_CMP): New macro.
364 This fixes comparison bugs on 64-bit hosts.
365 (ASCII_CHAR_P): Use it.
366 * casefiddle.c (casify_object):
367 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
368 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
369 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
370 * dispextern.h (FACE_FROM_ID):
371 * keyboard.c (read_char): Use UNSIGNED_CMP.
373 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
374 not to EMACS_INT, to avoid GCC warning.
376 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
378 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
379 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
380 isn't needed on 32-bit machines.
382 * buffer.c (Fgenerate_new_buffer_name):
383 Use EMACS_INT for count, not int.
384 (advance_to_char_boundary): Return EMACS_INT, not int.
386 * data.c (Qcompiled_function): Now static.
388 * window.c (window_body_lines): Now static.
390 * image.c (gif_load): Rename local to avoid shadowing.
392 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
393 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
394 * alloc.c (make_save_value): Integer argument is now of type
396 (mark_object): Use ptrdiff_t, not int.
397 * lisp.h (pD): New macro.
398 * print.c (print_object): Use it.
400 * alloc.c: Use EMACS_INT, not int, to count objects.
401 (total_conses, total_markers, total_symbols, total_vector_size)
402 (total_free_conses, total_free_markers, total_free_symbols)
403 (total_free_floats, total_floats, total_free_intervals)
404 (total_intervals, total_strings, total_free_strings):
405 Now EMACS_INT, not int. All uses changed.
406 (Fgarbage_collect): Compute overall total using a double, so that
407 integer overflow is less likely to be a problem. Check for overflow
408 when converting back to an integer.
409 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
410 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
411 These were 'int' variables that could overflow on 64-bit hosts;
412 they were never used, so remove them instead of repairing them.
413 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
414 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
415 Previously, this ceilinged at INT_MAX, but that doesn't work on
417 (allocate_pseudovector): Don't use EMACS_INT when int would do.
419 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
420 (allocate_vectorlike): Check for ptrdiff_t overflow.
421 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
422 when a (possibly-narrower) signed value would do just as well.
423 We prefer using signed arithmetic, to avoid comparison confusion.
425 * alloc.c: Catch some string size overflows that we were missing.
426 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
427 for convenience in STRING_BYTES_MAX.
428 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
429 The definition here is exact; the one in lisp.h was approximate.
430 (allocate_string_data): Check for string overflow. This catches
431 some instances we weren't catching before. Also, it catches
432 size_t overflow on (unusual) hosts where SIZE_MAX <= min
433 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
434 and ptrdiff_t and EMACS_INT are both 64 bits.
436 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
437 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
438 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
440 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
442 * alloc.c (Fmake_string): Check for out-of-range init.
444 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
446 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
448 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
450 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
451 xg_get_default_scrollbar_width.
453 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
454 (int_gtk_range_get_value): Move to the scroll bar part of the file.
455 (style_changed_cb): Call update_theme_scrollbar_width and call
456 x_set_scroll_bar_default_width and xg_frame_set_char_size for
457 all frames (Bug#8505).
458 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
459 Call gtk_window_set_resizable if HAVE_GTK3.
460 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
461 and height if HAVE_GTK3 (Bug#8505).
462 (scroll_bar_width_for_theme): New variable.
463 (update_theme_scrollbar_width): New function.
464 (xg_get_default_scrollbar_width): Move code to
465 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
466 (xg_initialize): Call update_theme_scrollbar_width.
468 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
470 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
472 2011-06-12 Martin Rudalics <rudalics@gmx.at>
474 * frame.c (make_frame): Call other_buffer_safely instead of
477 * window.c (temp_output_buffer_show): Call display_buffer with
478 second argument Vtemp_buffer_show_specifiers and reset latter
479 immediately after the call.
480 (Vtemp_buffer_show_specifiers): New variable.
481 (auto_window_vscroll_p, next_screen_context_lines)
482 (Vscroll_preserve_screen_position): Remove leading asterisks from
485 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
487 Fix minor problems found by GCC 4.6.0 static checking.
488 * buffer.c (Qclone_number): Remove for now, as it's unused.
489 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
490 (record_buffer): Remove unused local.
491 * frame.c (other_visible_frames, frame_buffer_list): Now static.
492 (set_frame_buffer_list): Remove; unused.
493 * frame.h (other_visible_frames): Remove decl.
494 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
495 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
496 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
498 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
499 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
500 Define only if HAVE_GPM.
501 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
502 (update_hints_inhibit): Remove; never set. All uses removed.
503 * widgetprv.h (emacsFrameClassRec): Remove decl.
504 * window.c (delete_deletable_window): Now returns void, since it
505 wasn't returning anything.
506 (compare_window_configurations): Remove unused locals.
507 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
508 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
509 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
510 the same widths as pointers. This follows up on the 2011-05-06 patch.
511 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
513 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
515 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
517 * makefile.w32-in: Update dependencies.
518 (LISP_H): Add lib/intprops.h.
520 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
522 * image.c (gif_load): Add animation frame delay to the metadata.
523 (syms_of_image): Use DEFSYM. New symbol `delay'.
525 2011-06-11 Martin Rudalics <rudalics@gmx.at>
527 * window.c (delete_deletable_window): Re-add.
528 (Fset_window_configuration): Rewrite to handle dead buffers and
529 consequently deletable windows.
530 (window_tree, Fwindow_tree): Remove. Supply functionality in
532 (compare_window_configurations): Simplify code.
534 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
536 * image.c (imagemagick_load_image): Fix type mismatch.
537 (Fimagemagick_types): Likewise.
539 * window.h (replace_buffer_in_windows): Declare.
541 2011-06-11 Martin Rudalics <rudalics@gmx.at>
543 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
544 Qclone_number. Remove external declaration of Qdelete_window.
545 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
547 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
548 Qbuffer_list_update_hook if allowed.
549 (Fother_buffer): Rewrite doc-string. Major rewrite for new
550 buffer list implementation.
551 (other_buffer_safely): New function.
552 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
553 calls to replace_buffer_in_windows and
554 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
556 (record_buffer): Inhibit quitting and rewrite using quittable
557 functions. Run Qbuffer_list_update_hook if allowed.
558 (Frecord_buffer, Funrecord_buffer): New functions.
559 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
560 switch-to-buffer to window.el.
561 (bury-buffer): Move to window.el.
562 (Vbuffer_list_update_hook): New variable.
564 * lisp.h (other_buffer_safely): Add prototype in buffer.c
567 * window.h (resize_frame_windows): Move up in code.
568 (Fwindow_frame): Remove EXFUN.
569 (replace_buffer_in_all_windows): Remove prototype.
570 (replace_buffer_in_windows_safely): Add prototype.
572 * window.c: Declare Qdelete_window static again. Move down
573 declaration of select_count.
574 (Fnext_window, Fprevious_window): Rewrite doc-strings.
575 (Fother_window): Move to window.el.
576 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
577 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
578 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
580 (replace_buffer_in_windows): Implement by calling
581 Qreplace_buffer_in_windows.
582 (replace_buffer_in_all_windows): Remove with some functionality
583 moved into replace_buffer_in_windows_safely.
584 (replace_buffer_in_windows_safely): New function.
585 (select_window_norecord, select_frame_norecord): Move in front
586 of run_window_configuration_change_hook. Remove now obsolete
588 (Fset_window_buffer): Rewrite doc-string. Call
589 Qrecord_window_buffer.
590 (keys_of_window): Move binding for other-window to window.el.
592 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
594 * dispextern.h (struct image): Replace data member, whose int_val
595 and ptr_val fields were not used by anything, with a single
598 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
599 (gif_clear_image, gif_load, imagemagick_load_image)
600 (gs_clear_image, gs_load): Callers changed.
602 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
604 * buffer.h: Include <time.h>, for time_t.
605 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
607 Fix minor problems found by static checking.
609 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
611 Make identifiers static if they are not used in other modules.
612 * data.c (Qcompiled_function, Qframe, Qvector):
613 * image.c (QimageMagick, Qsvg):
614 * minibuf.c (Qmetadata):
615 * window.c (resize_window_check, resize_root_window): Now static.
616 * window.h (resize_window_check, resize_root_window): Remove decls.
618 * window.c (window_deletion_count, delete_deletable_window):
620 (window_body_lines): Now static.
621 (Fdelete_other_windows_internal): Mark vars as initialized.
622 Make sure 'resize_failed' is initialized.
623 (run_window_configuration_change_hook): Rename local to avoid shadowing.
624 (resize_window_apply): Remove unused local.
625 * window.h (delete_deletable_window): Remove decl.
627 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
628 (imagemagick_load_image): Fix pointer signedness problem by changing
629 last arg from unsigned char * to char *. All uses changed.
630 Also, fix a local for similar reasons.
631 Remove unused locals. Remove locals to avoid shadowing.
632 (fn_rsvg_handle_free): Remove; unused.
633 (svg_load, svg_load_image): Fix pointer signedness problem.
634 (imagemagick_load_image): Don't use garbage pointer image_wand.
636 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
638 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
640 * image.c (gif_load): Fix omitted cast error introduced by
643 2011-06-10 Martin Rudalics <rudalics@gmx.at>
645 * window.h (resize_proportionally, orig_total_lines)
646 (orig_top_line): Remove from window structure.
647 (set_window_height, set_window_width, change_window_heights)
648 (Fdelete_window): Remove prototypes.
649 (resize_frame_windows): Remove duplicate declaration.
651 2011-06-10 Eli Zaretskii <eliz@gnu.org>
653 * window.h (resize_frame_windows, resize_window_check)
654 (delete_deletable_window, resize_root_window)
655 (resize_frame_windows): Declare prototypes.
657 * window.c (resize_window_apply): Make definition be "static" to
660 2011-06-10 Martin Rudalics <rudalics@gmx.at>
662 * window.c: Remove declarations of Qwindow_size_fixed,
663 window_min_size_1, window_min_size_2, window_min_size,
664 size_window, window_fixed_size_p, enlarge_window, delete_window.
665 Remove static from declaration of Qdelete_window, it's
666 temporarily needed by Fbury_buffer.
667 (replace_window): Don't assign orig_top_line and
669 (Fdelete_window, delete_window): Remove. Window deletion is
670 handled by window.el.
671 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
672 Fdelete_window calls with calls to Qdelete_window.
673 (Fdelete_other_windows): Remove. Deleting other windows is
674 handled by window.el.
675 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
676 handled in window.el.
677 (window_min_size_2, window_min_size_1, window_min_size): Remove.
678 Window minimum sizes are handled in window.el.
679 (shrink_windows, size_window, set_window_height)
680 (set_window_width, change_window_heights, window_height)
681 (window_width, CURBEG, CURSIZE, enlarge_window)
682 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
683 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
684 handled in window.el.
685 (make_dummy_parent): Rename to make_parent_window and give it a
686 second argument horflag.
687 (make_window): Don't set resize_proportionally any more.
688 (Fsplit_window): Remove. Windows are split in window.el.
689 (save_restore_action, save_restore_orig_size)
690 (shrink_window_lowest_first, save_restore_orig_size): Remove.
691 Resize mini windows in window.el.
692 (grow_mini_window, shrink_mini_window): Implement by calling
693 Qresize_root_window_vertically, resize_window_check and
695 (saved_window, Fset_window_configuration, save_window_save): Do
696 not handle orig_top_line, orig_total_lines, and
697 resize_proportionally.
698 (window_min_height, window_min_width): Move to window.el.
699 (keys_of_window): Move bindings for delete-other-windows,
700 split-window, delete-window and enlarge-window to window.el.
702 * buffer.c: Temporarily extern Qdelete_window.
703 (Fbury_buffer): Temporarily call Qdelete_window instead of
704 Fdelete_window (Fbury_buffer will move to window.el soon).
706 * frame.c (set_menu_bar_lines_1): Remove code handling
707 orig_top_line and orig_total_lines.
709 * dispnew.c (adjust_frame_glyphs_initially): Don't use
710 set_window_height but set heights directly.
711 (change_frame_size_1): Use resize_frame_windows.
713 * xdisp.c (init_xdisp): Don't use set_window_height but set
716 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
717 resize_frame_windows instead of change_window_heights and run
718 run_window_configuration_change_hook.
720 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
721 instead of change_window_heights and run
722 run_window_configuration_change_hook.
724 2011-06-09 Martin Rudalics <rudalics@gmx.at>
726 * window.c (replace_window): Rename second argument REPLACEMENT to
727 NEW. New third argument SETFLAG. Rewrite.
728 (delete_window, make_dummy_parent): Call replace_window with
730 (window_list_1): Move down in code.
731 (run_window_configuration_change_hook): Move set_buffer part
732 before select_frame_norecord part in order to unwind correctly.
733 Rename count1 to count.
734 (recombine_windows, delete_deletable_window, resize_root_window)
735 (Fdelete_other_windows_internal)
736 (Frun_window_configuration_change_hook, make_parent_window)
737 (resize_window_check, resize_window_apply, Fresize_window_apply)
738 (resize_frame_windows, Fsplit_window_internal)
739 (Fdelete_window_internal, Fresize_mini_window_internal): New
741 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
743 2011-06-08 Martin Rudalics <rudalics@gmx.at>
745 * window.h (window): Add some new members to window structure -
746 normal_lines, normal_cols, new_total, new_normal, clone_number,
747 splits, nest, prev_buffers, next_buffers.
748 (WINDOW_TOTAL_SIZE): Move here from window.c.
749 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
751 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
753 (make_dummy_parent): Set new members of windows structure.
754 (make_window): Move down in code. Handle new members of window
756 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
757 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
758 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
759 (Fset_window_prev_buffers, Fwindow_next_buffers)
760 (Fset_window_next_buffers, Fset_window_clone_number): New
762 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
763 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
765 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
766 Argument WINDOW can be now internal window too.
767 (Fwindow_use_time): Move up in code.
768 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
770 (Fset_window_configuration, saved_window)
771 (Fcurrent_window_configuration, save_window_save): Handle new
772 members of window structure.
773 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
774 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
775 (syms_of_window): New Lisp objects Qrecord_window_buffer,
776 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
777 Qget_mru_window, Qresize_root_window,
778 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
779 Qauto_buffer_name; staticpro them.
781 2011-06-07 Martin Rudalics <rudalics@gmx.at>
783 * window.c (Fwindow_total_size, Fwindow_left_column)
784 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
785 (Fwindow_list_1): New functions.
786 (window_box_text_cols): Replace with window_body_cols.
787 (Fwindow_width, Fscroll_left, Fscroll_right): Use
788 window_body_cols instead of window_box_text_cols.
789 (delete_window, Fset_window_configuration): Call
790 delete_all_subwindows with window as argument.
791 (delete_all_subwindows): Take a window as argument and not a
793 (window_loop): Remove handling of GET_LRU_WINDOW and
795 (Fget_lru_window, Fget_largest_window): Move to window.el.
797 * window.h: Extern window_body_cols instead of
798 window_box_text_cols. delete_all_subwindows now takes a
799 Lisp_Object as argument.
801 * indent.c (compute_motion, Fcompute_motion): Use
802 window_body_cols instead of window_box_text_cols.
804 * frame.c (delete_frame): Call delete_all_subwindows with root
807 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
809 * fns.c (Fputhash): Document return value.
811 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
813 * image.c (gif_load): Implement gif89a spec "no disposal" method.
815 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
817 Cons<->int and similar integer overflow fixes (Bug#8794).
819 Check for overflow when converting integer to cons and back.
820 * charset.c (Fdefine_charset_internal, Fdecode_char):
821 Use cons_to_unsigned to catch overflow.
822 (Fencode_char): Use INTEGER_TO_CONS.
823 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
824 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
825 * data.c (long_to_cons, cons_to_long): Remove.
826 (cons_to_unsigned, cons_to_signed): New functions.
827 These signal an error for invalid or out-of-range values.
828 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
829 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
830 * font.c (Ffont_variation_glyphs):
831 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
832 * lisp.h: Include <intprops.h>.
833 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
834 (cons_to_signed, cons_to_unsigned): New decls.
835 (long_to_cons, cons_to_long): Remove decls.
836 * undo.c (record_first_change): Use INTEGER_TO_CONS.
837 (Fprimitive_undo): Use CONS_TO_INTEGER.
838 * xfns.c (Fx_window_property): Likewise.
839 * xselect.c: Include <limits.h>.
840 (x_own_selection, selection_data_to_lisp_data):
842 (x_handle_selection_request, x_handle_selection_clear)
843 (x_get_foreign_selection, Fx_disown_selection_internal)
844 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
845 (lisp_data_to_selection_data): Use cons_to_unsigned.
846 (x_fill_property_data): Use cons_to_signed.
847 Report values out of range.
849 Check for buffer and string overflow more precisely.
850 * buffer.h (BUF_BYTES_MAX): New macro.
851 * lisp.h (STRING_BYTES_MAX): New macro.
852 * alloc.c (Fmake_string):
853 * character.c (string_escape_byte8):
854 * coding.c (coding_alloc_by_realloc):
856 * editfns.c (Fformat):
858 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
859 since they may not be the same number.
860 * editfns.c (Finsert_char):
861 * fileio.c (Finsert_file_contents):
862 Likewise for BUF_BYTES_MAX.
864 * image.c: Use ptrdiff_t, not int, for sizes.
865 (slurp_file): Switch from int to ptrdiff_t.
867 (slurp_file): Check that file size fits in both size_t (for
868 malloc) and ptrdiff_t (for sanity and safety).
870 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
871 if b->modtime has its maximal value.
873 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
875 Don't assume time_t can fit into int.
876 * buffer.h (struct buffer.modtime): Now time_t, not int.
877 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
878 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
880 Minor fixes for signed vs unsigned integers.
881 * character.h (MAYBE_UNIFY_CHAR):
882 * charset.c (maybe_unify_char):
883 * keyboard.c (read_char, reorder_modifiers):
884 XINT -> XFASTINT, since the integer must be nonnegative.
885 * ftfont.c (ftfont_spec_pattern):
886 * keymap.c (access_keymap, silly_event_symbol_error):
887 XUINT -> XFASTINT, since the integer must be nonnegative.
888 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
889 since it makes no difference and we prefer signed.
890 * keyboard.c (record_char): Use XUINT when all the neighbors do.
891 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
894 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
896 * window.h (Fwindow_frame): Declare.
898 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
900 * alloc.c: Simplify handling of large-request failures (Bug#8800).
901 (SPARE_MEMORY): Always define.
902 (LARGE_REQUEST): Remove.
903 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
905 2011-06-06 Martin Rudalics <rudalics@gmx.at>
907 * lisp.h: Move EXFUNS for Fframe_root_window,
908 Fframe_first_window and Fset_frame_selected_window to window.h.
910 * window.h: Move EXFUNS for Fframe_root_window,
911 Fframe_first_window and Fset_frame_selected_window here from
914 * frame.c (Fwindow_frame, Fframe_first_window)
915 (Fframe_root_window, Fframe_selected_window)
916 (Fset_frame_selected_window): Move to window.c.
917 (Factive_minibuffer_window): Move to minibuf.c.
918 (Fother_visible_frames_p): New function.
920 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
922 * window.c (decode_window, decode_any_window): Move up in code.
923 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
924 (inhibit_frame_unsplittable): Remove unused variable.
925 (Fwindow_buffer): Move up and rewrite doc-string.
926 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
927 (Fwindow_prev): New functions.
928 (Fwindow_frame): Move here from frame.c. Accept any window as
930 (Fframe_root_window, Fframe_first_window)
931 (Fframe_selected_window): Move here from frame.c. Accept frame
932 or arbitrary window as argument. Update doc-strings.
933 (Fminibuffer_window): Move up in code.
934 (Fwindow_minibuffer_p): Move up in code and simplify.
935 (Fset_frame_selected_window): Move here from frame.c.
937 (Fselected_window, select_window, Fselect_window): Move up in
938 code. Minor doc-string fixes.
940 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
942 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
943 Do not assume that spare memory exists; that assumption is valid
944 only if SYSTEM_MALLOC.
945 (LARGE_REQUEST): New macro, so that the issue of large requests
946 is separated from the issue of spare memory.
948 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
950 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
953 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
955 * xfns.c (x_set_scroll_bar_default_width): Move declarations
958 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
960 * gtkutil.c (xg_get_default_scrollbar_width): New function.
962 * gtkutil.h: Declare xg_get_default_scrollbar_width.
964 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
965 min width by calling x_set_scroll_bar_default_width (Bug#8505).
967 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
969 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
971 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
973 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
974 (x_clipboard_manager_save): Add return value.
975 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
977 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
978 Obey Vx_select_enable_clipboard_manager. Catch errors in
979 x_clipboard_manager_save (Bug#8779).
980 (Vx_select_enable_clipboard_manager): New variable.
981 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
983 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
985 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
987 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
990 in the current matrix if keep_current_p is non-zero.
992 2011-06-04 Eli Zaretskii <eliz@gnu.org>
994 * bidi.c (bidi_level_of_next_char): Fix last change.
996 2011-06-03 Eli Zaretskii <eliz@gnu.org>
998 Support bidi reordering of text covered by display properties.
1000 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1001 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1002 (bidi_cache_search, bidi_cache_iterator_state)
1003 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1004 (bidi_level_of_next_char, bidi_move_to_visually_next):
1005 Support character positions inside a run of characters covered by a
1007 (bidi_paragraph_init, bidi_resolve_explicit_1)
1008 (bidi_level_of_next_char): Call bidi_fetch_char and
1009 bidi_fetch_char_advance instead of FETCH_CHAR and
1011 (bidi_init_it): Initialize new members.
1012 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1014 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1015 instead of using explicit *_CHAR codes.
1016 (bidi_resolve_explicit, bidi_resolve_weak):
1017 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1018 bidirectional text is supported only in multibyte buffers.
1019 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1020 it to initialize the frame_window_p member of struct bidi_it.
1021 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1022 (bidi_resolve_explicit, bidi_resolve_weak)
1023 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1024 bidi_it->nchars is non-positive.
1025 (bidi_level_of_next_char): Don't try to lookup the cache for the
1026 next/previous character if nothing is cached there yet, or if we
1027 were just reseat()'ed to a new position.
1029 * xdisp.c (set_cursor_from_row): Set start and stop points
1030 according to the row's direction when priming the loop that looks
1031 for the glyph on which to display cursor.
1032 (single_display_spec_intangible_p): Function deleted.
1033 (display_prop_intangible_p): Reimplement to call
1034 handle_display_spec instead of single_display_spec_intangible_p.
1035 Accept 3 additional arguments needed by handle_display_spec.
1036 This fixes incorrect cursor motion across display property with complex
1037 values: lists, `(when COND...)' forms, etc.
1038 (single_display_spec_string_p): Support property values that are
1039 lists with the argument STRING its top-level element.
1040 (display_prop_string_p): Fix the condition for processing a
1041 property that is a list to be consistent with handle_display_spec.
1042 (handle_display_spec): New function, refactored from the
1043 last portion of handle_display_prop.
1044 (compute_display_string_pos): Accept additional argument
1045 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1046 value of a `display' property is a "replacing spec".
1047 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1048 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1049 the display property, but just return a value indicating whether
1050 the display property will replace the characters it covers.
1051 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1052 frame_window_p members of struct bidi_it.
1053 (compute_display_string_pos, compute_display_string_end):
1055 (push_it): Accept second argument POSITION, where pop_it should
1056 jump to continue iteration.
1057 (reseat_1): Initialize bidi_it.disp_pos.
1059 * keyboard.c (adjust_point_for_property): Adjust the call to
1060 display_prop_intangible_p to its new signature.
1062 * dispextern.h (struct bidi_it): New member frame_window_p.
1063 (bidi_init_it): Update prototypes.
1064 (display_prop_intangible_p): Update prototype.
1065 (compute_display_string_pos, compute_display_string_end):
1067 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1070 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1072 Malloc failure behavior now depends on size of allocation.
1073 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1074 * lisp.h: Change signatures accordingly.
1075 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1076 All callers changed. (Bug#8762)
1078 * gnutls.c: Use Emacs's memory allocators.
1079 Without this change, the gnutls library would invoke malloc etc.
1080 directly, which causes problems on non-SYNC_INPUT hosts, and which
1081 runs afoul of improving memory_full behavior. (Bug#8761)
1082 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1083 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1084 xfree instead of the default malloc, realloc, free.
1085 (Fgnutls_boot): No need to check for memory allocation failure,
1086 since xmalloc does that for us.
1088 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1089 * category.c (hash_get_category_set):
1090 * ccl.c (ccl_driver):
1091 * charset.c (Fdefine_charset_internal):
1092 * charset.h (struct charset.hash_index):
1093 * composite.c (get_composition_id, gstring_lookup_cache)
1094 (composition_gstring_put_cache):
1095 * composite.h (struct composition.hash_index):
1096 * dispextern.h (struct image.hash):
1097 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1098 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1099 (hashfn_equal, hashfn_user_defined, make_hash_table)
1100 (maybe_resize_hash_table, hash_lookup, hash_put)
1101 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1102 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1103 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1104 * image.c (make_image, search_image_cache, lookup_image)
1105 (xpm_put_color_table_h):
1106 * lisp.h (struct Lisp_Hash_Table):
1107 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1108 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1109 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1110 * alloc.c (allocate_vectorlike):
1111 Check for overflow in vector size calculations.
1112 * ccl.c (ccl_driver):
1113 Check for overflow when converting EMACS_INT to int.
1114 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1115 need to be updated by these changes.
1116 * fns.c (make_hash_table, maybe_resize_hash_table):
1117 Check for integer overflow with large hash tables.
1118 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1119 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1120 (SXHASH_REDUCE): New macro.
1121 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1122 Use it instead of discarding useful hash info with large hash values.
1123 (sxhash_float): New function.
1124 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1125 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1126 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1127 Rewrite to use FIXNUM_BITS, as this simplifies things.
1128 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1129 Adjust signatures to match updated version of code.
1130 (consing_since_gc): Now EMACS_INT, since a single hash table can
1131 use more than INT_MAX bytes.
1133 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1135 Make it possible to build with GCC-4.6+ -O2 -flto.
1137 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1139 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1141 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1142 Call minibuffer-inactive-mode.
1144 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1146 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1147 Update dependencies.
1149 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1151 * data.c (init_data): Remove code for UTS, this system is not
1154 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1156 Don't force ./temacs to start in terminal mode.
1158 * frame.c (make_initial_frame): Initialize faces in all cases, not
1159 only when CANNOT_DUMP is defined.
1160 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1162 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1164 * dispnew.c (add_window_display_history): Use const for the string
1165 pointer. Remove declaration, not needed.
1167 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1169 Use 'inline', not 'INLINE'.
1170 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1171 * alloc.c, fontset.c (INLINE): Remove.
1172 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1173 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1174 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1175 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1176 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1180 Make it possible to run ./temacs.
1182 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1183 syms_of_callproc does the same thing. Remove test for
1184 "initialized", do it in the caller.
1185 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1187 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1189 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1190 (read_minibuf): Use get_minibuffer.
1191 (syms_of_minibuf): Use DEFSYM.
1192 (Qmetadata): New var.
1193 * data.c (Qbuffer): Don't make it static.
1194 (syms_of_data): Use DEFSYM.
1196 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1198 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1199 (CCL_CODE_MIN): New macro.
1201 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1203 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1205 * eval.c (Qdebug): Now static.
1206 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1207 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1208 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1210 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1212 * image.c: Various fixes to ImageMagick code comments.
1213 (Fimagemagick_types): Doc fix.
1215 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1217 Minor fixes prompted by GCC 4.6.0 warnings.
1219 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1221 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1222 (x_clipboard_manager_save_all): Move extern decl to ...
1223 * xterm.h: ... here, so that it can be checked for consistency.
1225 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1227 * xselect.c (x_clipboard_manager_save_frame)
1228 (x_clipboard_manager_save_all): New functions.
1229 (Fx_clipboard_manager_save): Lisp function deleted.
1231 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1232 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1234 * xterm.h: Update prototype.
1236 2011-05-28 William Xu <william.xwl@gmail.com>
1238 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1241 2011-05-28 Jim Meyering <meyering@redhat.com>
1243 Avoid a sign-extension bug in crypto_hash_function.
1244 * fns.c (to_uchar): Define.
1245 (crypto_hash_function): Use it to convert some newly-signed
1246 variables to unsigned, to avoid sign-extension bugs. For example,
1247 without this change, (md5 "truc") would evaluate to
1248 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1249 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1250 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1252 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1254 Integer overflow fixes.
1256 * dbusbind.c: Serial number integer overflow fixes.
1257 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1258 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1259 to hold a serial number that is too large for a fixnum.
1260 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1261 Check for serial numbers out of range. Decode any serial number
1262 that was so large that it became a float. (Bug#8722)
1264 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1265 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1266 Use XFASTINT rather than XUINT when numbers are nonnegative.
1267 (xd_append_arg, Fdbus_method_return_internal):
1268 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1269 arguments, check that Lisp number is nonnegative, rather than
1270 silently wrapping negative numbers around. (Bug#8722)
1271 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1274 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1276 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1278 ccl: add integer overflow checks
1279 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1280 (IN_INT_RANGE): New macros.
1281 (ccl_driver): Use them to check for integer overflow when
1282 decoding a CCL program. Many of the new checks are whether XINT (x)
1283 fits in int; it doesn't always, on 64-bit hosts. The new version
1284 doesn't catch all possible integer overflows, but it's an
1285 improvement. (Bug#8719)
1287 * alloc.c (make_event_array): Use XINT, not XUINT.
1288 There's no need for unsigned here.
1290 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1291 This follows up to the 2011-05-06 change that substituted uintptr_t
1292 for EMACS_INT. This case wasn't caught back then.
1294 Rework Fformat to avoid integer overflow issues.
1295 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1296 now (part of C89). Include <verify.h>.
1297 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1298 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1299 (Fformat): Avoid the prepass trying to compute sizes; it was only
1300 approximate and thus did not catch overflow reliably. Instead, walk
1301 through the format just once, formatting and computing sizes as we go,
1302 checking for integer overflow at every step, and allocating a larger
1303 buffer as needed. Keep track separately whether the format is
1304 multibyte. Keep only the most-recently calculated precision, rather
1305 than them all. Record whether each argument has been converted to
1306 string. Use EMACS_INT, not int, for byte and char and arg counts.
1307 Support field widths and precisions larger than INT_MAX. Avoid
1308 sprintf's undefined behavior with conversion specifications such as %#d
1309 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1310 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1311 formatting out-of-range floating point numbers with int
1314 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1316 * data.c: Avoid integer truncation in expressions involving floats.
1317 * data.c: Include <intprops.h>.
1318 (arith_driver): When there's an integer overflow in an expression
1319 involving floating point, convert the integers to floating point
1320 so that the resulting value does not suffer from catastrophic
1321 integer truncation. For example, on a 64-bit host (* 4
1322 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1323 Do not rely on undefined behavior after integer overflow.
1325 merge count_size_as_multibyte, parse_str_to_multibyte
1326 * character.c, character.h (count_size_as_multibyte):
1327 Rename from parse_str_to_multibyte; all uses changed.
1328 Check for integer overflow.
1329 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1330 since it's now a duplicate of the other. This is more of
1331 a character than a buffer op, so better that it's in character.c.
1332 * fns.c, print.c: Adjust to above changes.
1334 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1336 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1338 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1340 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1341 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1342 (x_clipboard_manager_save): Now static.
1343 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1345 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1346 (crypto_hash_function): Now static.
1347 Fix pointer signedness problems. Avoid unnecessary initializations.
1349 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1351 * termhooks.h (Vselection_alist): Make it terminal-local.
1353 * terminal.c (create_terminal): Initialize it.
1355 * xselect.c: Support for clipboard managers.
1356 (Vselection_alist): Move to termhooks.h as terminal-local var.
1357 (LOCAL_SELECTION): New macro.
1358 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1359 (symbol_to_x_atom): Remove gratuitous arg.
1360 (x_handle_selection_request, lisp_data_to_selection_data)
1361 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1362 (x_own_selection, x_get_local_selection, x_convert_selection):
1363 New arg, specifying work frame. Use terminal-local Vselection_alist.
1364 (some_frame_on_display): Delete unused function.
1365 (Fx_own_selection_internal, Fx_get_selection_internal)
1366 (Fx_disown_selection_internal, Fx_selection_owner_p)
1367 (Fx_selection_exists_p): New optional frame arg.
1368 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1369 (x_handle_selection_clear): Don't treat other terminals with the
1370 same keyboard specially. Use the terminal-local Vselection_alist.
1371 (x_clear_frame_selections): Use Frun_hook_with_args.
1373 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1375 * xterm.h: Add support for those atoms.
1377 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1379 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1380 (converted_selections, conversion_fail_tag): New global variables.
1381 (x_selection_request_lisp_error): Free the above.
1382 (x_get_local_selection): Remove unnecessary code.
1383 (x_reply_selection_request): Args changed; handle arbitrary array
1384 of converted selections stored in converted_selections.
1385 Separate the XChangeProperty and SelectionNotify steps.
1386 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1387 (x_convert_selection): New function.
1388 (x_handle_selection_event): Simplify.
1389 (x_get_foreign_selection): Don't ignore incoming requests while
1390 waiting for an answer; this will fail when we implement
1391 SAVE_TARGETS, and seems unnecessary anyway.
1392 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1393 (Vx_sent_selection_functions): Doc fix.
1395 2011-05-26 Leo Liu <sdl.web@gmail.com>
1397 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1399 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1401 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1403 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1404 for fringe update if it has periodic bitmap.
1405 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1406 and fringe_bitmap_periodic_p.
1408 * fringe.c (get_fringe_bitmap_data): New function.
1409 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1410 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1411 row. Mark glyph row for fringe update if periodicity changed.
1413 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1414 for fringe update unless it has periodic bitmap.
1416 2011-05-25 Kenichi Handa <handa@m17n.org>
1418 * xdisp.c (get_next_display_element): Set correct it->face_id for
1419 a static composition.
1421 2011-05-24 Leo Liu <sdl.web@gmail.com>
1424 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1426 * fns.c (crypto_hash_function, Fsha1): New function.
1427 (Fmd5): Use crypto_hash_function.
1428 (syms_of_fns): Add Ssha1.
1430 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1432 * gnutls.c: Remove unused macros.
1433 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1434 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1435 Remove macros that are defined and never used.
1436 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1438 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1440 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1441 (Fx_get_selection_internal): Minor cleanup.
1442 (Fx_own_selection_internal): Rename arguments for consistency with
1445 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1447 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1449 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1451 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1453 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1455 * dispnew.c (scrolling_window): Don't exclude the case that the
1456 last enabled row in the desired matrix touches the bottom boundary.
1458 2011-05-21 Glenn Morris <rgm@gnu.org>
1460 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1461 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1462 and add some more files.
1464 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1466 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1467 report_file_error introduced by the change from 2011-05-07.
1469 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1471 * systime.h (Time): Define only if emacs is defined.
1472 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1473 where the include path doesn't have X11/X.h by default. See
1474 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1476 2011-05-20 Kenichi Handa <handa@m17n.org>
1478 * composite.c (find_automatic_composition): Fix previous change.
1480 2011-05-20 Glenn Morris <rgm@gnu.org>
1482 * lisp.mk: New file, split from Makefile.in.
1483 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1484 (shortlisp): Remove.
1485 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1487 2011-05-19 Glenn Morris <rgm@gnu.org>
1489 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1490 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1491 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1492 (lisp): Set the order to that of loadup.el.
1493 (shortlisp): Make it a copy of $lisp.
1494 (SOME_MACHINE_LISP): Remove.
1495 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1496 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1498 2011-05-18 Kenichi Handa <handa@m17n.org>
1500 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1501 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1502 (find_automatic_composition): Mostly rewrite for efficiency.
1504 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1506 * makefile.w32-in: Update dependencies.
1508 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1510 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1511 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1513 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1515 Fix some integer overflow issues, such as string length overflow.
1517 * insdel.c (count_size_as_multibyte): Check for string overflow.
1519 * character.c (lisp_string_width): Check for string overflow.
1520 Use EMACS_INT, not int, for string indexes and lengths; in
1521 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1522 the resulting string length overflows an EMACS_INT; instead,
1523 report a string overflow if no precision given. When checking for
1524 precision exhaustion, use a check that cannot possibly have
1525 integer overflow. (Bug#8675)
1526 * character.h (lisp_string_width): Adjust to new signature.
1528 * alloc.c (string_overflow): New function.
1529 (Fmake_string): Use it. This doesn't change behavior, but saves
1530 a few bytes and will simplify future changes.
1531 * character.c (string_escape_byte8): Likewise.
1532 * lisp.h (string_overflow): New decl.
1534 Fixups, following up to the user-interface timestamp change.
1535 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1536 for UI timestamps, instead of unsigned long.
1537 * msdos.c (mouse_get_pos): Likewise.
1538 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1539 * w32gui.h (Time): Define by including "systime.h" rather than by
1540 declaring it ourselves. (Bug#8664)
1542 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1543 * image.c (clear_image_cache): Likewise.
1545 * term.c (term_mouse_position): Don't assume time_t wraparound.
1547 Be more systematic about user-interface timestamps.
1548 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1549 and sometimes 'EMACS_UINT', to represent these timestamps.
1550 This change causes it to use 'Time' uniformly, as that's what X uses.
1551 This makes the code easier to follow, and makes it easier to catch
1552 integer overflow bugs such as Bug#8664.
1553 * frame.c (Fmouse_position, Fmouse_pixel_position):
1554 Use Time, not unsigned long, for user-interface timestamps.
1555 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1556 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1557 * keyboard.h (last_event_timestamp): Likewise.
1558 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1559 * menu.h (xmenu_show): Likewise.
1560 * term.c (term_mouse_position): Likewise.
1561 * termhooks.h (struct input_event.timestamp): Likewise.
1562 (struct terminal.mouse_position_hook): Likewise.
1563 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1564 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1565 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1566 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1568 * menu.h, termhooks.h: Include "systime.h", for Time.
1570 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1571 Don't assume that the difference between two unsigned long values
1572 can fit into an integer. At this point, we know button_down_time
1573 <= event->timestamp, so the difference must be nonnegative, so
1574 there's no need to cast the result if double-click-time is
1575 nonnegative, as it should be; check that it's nonnegative, just in
1576 case. This bug is triggered when events are more than 2**31 ms
1577 apart (about 25 days). (Bug#8664)
1579 * xselect.c (last_event_timestamp): Remove duplicate decl.
1580 (x_own_selection): Remove needless cast to unsigned long.
1582 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1583 that always fit in int. Use a sentinel instead of a counter, to
1584 avoid a temp and to allay GCC's concerns about possible int overflow.
1585 * frame.h (struct frame): Use int for menu_bar_items_used
1586 instead of EMACS_INT, since it always fits in int.
1588 * menu.c (grow_menu_items): Check for int overflow.
1590 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1592 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1593 Before, the code was not consistent. These values cannot exceed
1594 2**31 - 1 so there's no need to make them unsigned.
1595 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1596 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1597 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1599 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1601 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1602 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1603 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1604 presumably because the widths might not match.
1606 * window.c (size_window): Avoid needless test at loop start.
1608 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1610 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1612 2011-05-12 Drew Adams <drew.adams@oracle.com>
1614 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1616 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1618 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1619 `width' to `bar_area_x' and `bar_area_width', respectively.
1620 (x_scroll_run): Take account of fringe background extension.
1622 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1623 Rename local vars `left' and `width' to `bar_area_x' and
1624 `bar_area_width', respectively.
1625 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1626 background extension.
1628 2011-05-10 Jim Meyering <meyering@redhat.com>
1630 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1632 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1634 * image.c (Finit_image_library): Return t for built-in image types,
1635 like pbm and xbm. (Bug#8640)
1637 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1639 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1641 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1643 * w32console.c (Fset_screen_color): Doc fix.
1644 (Fget_screen_color): New function.
1645 (syms_of_ntterm): Defsubr it.
1647 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1648 unlink the temporary file if Fcall_process didn't create it in the
1650 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1651 child process will be redirected to a file specified with `:file'.
1652 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1653 cue to call_process_cleanup not to close that handle.
1655 2011-05-07 Ben Key <bkey76@gmail.com>
1657 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1658 one of two shell specific rules, either bootstrap-temacs-CMD or
1659 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1660 to the previous implementation of the bootstrap-temacs rule.
1661 The bootstrap-temacs-CMD rule is similar to the previous
1662 implementation of the bootstrap-temacs rule except that it
1663 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1666 These changes, along with some changes to nt/configure.bat,
1667 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1668 earlier fix to add support for --cflags and --ldflags options
1669 that include quotes so that it works whether make uses cmd or
1672 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1674 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1675 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1677 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1678 a string. Handle both cases.
1679 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1680 (Fdbus_register_method): Use Qinvalid_function.
1682 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1684 * makefile.w32-in: Update dependencies.
1685 (LISP_H): Add inttypes.h and stdin.h.
1686 (PROCESS_H): Add unistd.h.
1688 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1690 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1691 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1693 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1695 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1697 * term.c (vfatal): Remove stray call to va_end.
1698 It's not needed and the C Standard doesn't allow it here anyway.
1700 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1701 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1703 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1706 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1708 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1710 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1712 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1714 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1716 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1717 * charset.c (Fdefine_charset_internal): Don't initialize
1718 charset.code_space[15]. The value was garbage, on hosts with
1719 32-bit int (Bug#8600).
1721 * lread.c (read_integer): Be more consistent with string-to-number.
1722 Use string_to_number to do the actual conversion; this avoids
1723 rounding errors and fixes some other screwups. Without this fix,
1724 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1725 (digit_to_number): Move earlier, for benefit of read_integer.
1726 Return -1 if the digit is out of range for the base, -2 if it is
1727 not a digit in any supported base. (Bug#8602)
1729 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1731 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1732 to match comment at start of function. This also removes a
1733 GCC warning about overflow in a 32+64-bit port.
1735 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1737 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1738 Reported by Stefan Monnier in
1739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1740 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1741 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1743 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1744 (EMACS_UINTPTR): Likewise, with uintptr_t.
1746 * lisp.h: Prefer 64-bit EMACS_INT if available.
1747 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1748 on 32-bit hosts that have 64-bit int, so that they can access
1750 However, temporarily disable this change unless the temporary
1751 symbol WIDE_EMACS_INT is defined.
1753 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1755 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1756 This removes an assumption that EMACS_INT and long are the same
1757 width as pointers. The assumption is true for Emacs porting targets
1758 now, but we want to make other targets possible.
1759 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1760 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1761 In the rest of the code, change types of integers that hold casted
1762 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1763 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1764 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1765 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1766 No need to cast type when ORing.
1767 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1768 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1769 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1770 assume EMACS_INT is the same width as char *.
1771 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1772 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1773 Remove no-longer-needed casts.
1774 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1775 (xg_tool_bar_help_callback, xg_make_tool_item):
1776 Use EMACS_INTPTR to hold an integer
1777 that will be cast to void *; this can avoid a GCC warning
1778 if EMACS_INT is not the same width as void *.
1779 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1780 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1781 (current_message_1, set_message_1):
1782 Use a local to convert to proper width without a cast.
1783 * xmenu.c (dialog_selection_callback): Likewise.
1785 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1786 Also, don't assume VALBITS / RAND_BITS is less than 5,
1787 and don't rely on undefined behavior when shifting a 1 left into
1789 * lisp.h (get_random): Change signature to match.
1791 * lread.c (hash_string): Use size_t, not int, for hash computation.
1792 Normally we prefer signed values; but hashing is special, because
1793 it's better to use unsigned division on hash table sizes so that
1794 the remainder is nonnegative. Also, size_t is the natural width
1795 for hashing into memory. The previous code used 'int', which doesn't
1796 retain enough info to hash well into very large tables.
1797 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1799 * dbusbind.c: Don't possibly lose pointer info when converting.
1800 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1801 Use XPNTR rather than XHASH, so that the high-order bits of
1802 the pointer aren't lost when converting through void *.
1804 * eval.c (Fautoload): Don't double-shift a pointer.
1806 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1808 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1810 * gnutls.c (DEF_GNUTLS_FN):
1811 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1813 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1815 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1818 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1820 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1821 New version that can reserve upto 2GB of heap space.
1823 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1825 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1827 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1829 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1830 `gnutls_certificate_set_x509_key_file'.
1832 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1834 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1835 Update dependencies.
1837 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1839 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1840 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1841 Remove unused parameter `fildes'.
1842 * process.c (read_process_output, send_process): Don't pass it.
1844 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1846 Fix previous change: the library cache is defined in w32.c.
1847 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1848 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1850 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1852 Implement dynamic loading of GnuTLS on Windows.
1854 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1855 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1856 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1859 * gnutls.c (Qgnutls_dll): Define.
1860 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1861 (gnutls_*): Declare function pointers.
1862 (init_gnutls_functions): New function to initialize function pointers.
1863 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1864 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1865 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1866 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1867 (emacs_gnutls_write, emacs_gnutls_read)
1868 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1869 (Fgnutls_available_p): New function.
1870 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1871 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1872 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1874 * image.c: Include w32.h.
1875 (Vimage_type_cache): Delete.
1876 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1877 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1878 (w32_delayed_load): Move to w32.c.
1880 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1882 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1883 (w32_delayed_load): Move from image.c. When loading a library, record
1884 its filename in the :loaded-from property of the library id.
1885 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1886 Initialize and staticpro them.
1887 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1889 * process.c: Include lisp.h before w32.h, not after.
1890 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1891 instead of gnutls_record_check_pending.
1893 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1895 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1897 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1898 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1901 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1903 * xterm.c (x_set_frame_alpha): Do not set property on anything
1904 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1906 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1908 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1910 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1912 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1913 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1914 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1915 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1916 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1917 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1918 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1919 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1920 (Qgnutls_bootprop_callbacks_verify): Make static.
1922 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1924 * callproc.c: Indentation fixup.
1926 * sysdep.c (wait_for_termination_1): Make static.
1927 (wait_for_termination, interruptible_wait_for_termination):
1928 Move after wait_for_termination_1.
1930 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1932 * sysdep.c (interruptible_wait_for_termination): New function
1933 which is like wait_for_termination, but allows keyboard
1936 * callproc.c (Fcall_process): Add (:file "file") as an option for
1938 (Fcall_process_region): Ditto.
1940 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1942 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1943 rather than `XVECTOR (FOO)->size'.
1945 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1946 inttypes.h, as a gnulib replacement is used if it not available in
1949 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1951 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1952 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1953 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1955 * coding.c (coding_alloc_by_realloc): Error out if destination
1956 will grow beyond MOST_POSITIVE_FIXNUM.
1957 (decode_coding_emacs_mule): Abort if there isn't enough place in
1958 charbuf for the composition carryover bytes. Reserve an extra
1959 space for up to 2 characters produced in a loop.
1960 (decode_coding_iso_2022): Abort if there isn't enough place in
1961 charbuf for the composition carryover bytes.
1963 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1965 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1966 aborting when %lld or %lll format is passed.
1967 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1968 %llo or %llx format is passed. (Bug#8545)
1970 * window.c (window_scroll_line_based): Use a marker instead of
1971 simple variables to record original value of point. (Bug#7952)
1973 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1974 produced by %s or %c overflows available buffer space. (Bug#8545)
1976 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1978 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1979 (SIZE_MAX): Move defn after all includes, as they might #define it.
1981 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1983 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1985 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1987 * keyboard.c (Qdelayed_warnings_hook): Define.
1988 (command_loop_1): Run `delayed-warnings-hook'
1989 if Vdelayed_warnings_list is non-nil.
1990 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1991 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1993 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1995 * doprnt.c (doprnt): Don't return value smaller than the buffer
1996 size if the message was truncated. (Bug#8545).
1998 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2000 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2001 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2003 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2005 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2007 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2009 * makefile.w32-in: Update dependencies.
2011 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2013 Improve `doprnt' and its usage. (Bug#8545)
2014 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2015 `format_end'. Remove support for %l as a conversion specifier.
2016 Don't use xrealloc. Improve diagnostics when the %l size modifier
2017 is used. Update the commentary.
2019 * eval.c (verror): Simplify calculation of size_t.
2021 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2024 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2026 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2029 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2031 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2032 This makes this file independent of the recent pseudovector change.
2034 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2036 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2038 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2039 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2040 Remove unused local.
2041 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2043 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2044 GCC 4.6.0 optimizes based on type-based alias analysis.
2045 For example, if b is of type struct buffer * and v of type struct
2046 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2047 != &v->size, and therefore "v->size = 1; b->size = 2; return
2048 v->size;" must therefore return 1. This assumption is incorrect
2049 for Emacs, since it type-puns struct Lisp_Vector * with many other
2050 types. To fix this problem, this patch adds a new type struct
2051 vectorlike_header that documents the constraints on layout of vectors
2052 and pseudovectors, and helps optimizing compilers not get fooled
2053 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2054 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2055 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2057 (XSETPVECTYPE): Rewrite in terms of new macro.
2058 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2059 This is a bit clearer, and further avoids the possibility of
2060 undesirable aliasing.
2061 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2062 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2063 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2064 since Lisp_Subr is a special case (no "next" field).
2065 (ASIZE): Now uses header.size rather than size.
2066 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2067 to avoid the hassle of writing XVECTOR (foo)->header.size.
2068 (struct vectorlike_header): New type.
2069 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2070 object, to help avoid aliasing.
2071 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2072 (SUBRP): Likewise, since Lisp_Subr is a special case.
2073 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2074 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2075 (struct Lisp_Hash_Table): Combine first two members into a single
2076 struct vectorlike_header member. All uses of "size" and "next" members
2077 changed to be "header.size" and "header.next".
2078 * buffer.h (struct buffer): Likewise.
2079 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2080 * frame.h (struct frame): Likewise.
2081 * process.h (struct Lisp_Process): Likewise.
2082 * termhooks.h (struct terminal): Likewise.
2083 * window.c (struct save_window_data, struct saved_window): Likewise.
2084 * window.h (struct window): Likewise.
2085 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2086 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2087 * buffer.c (init_buffer_once): Likewise.
2088 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2090 * process.c (Fformat_network_address): Use local var for size,
2093 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2095 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2096 * data.c (atof): Remove decl; no longer used or needed.
2097 (digit_to_number): Move to lread.c.
2098 (Fstring_to_number): Use new string_to_number function, to be
2099 consistent with how the Lisp reader treats infinities and NaNs.
2100 Do not assume that floating-point numbers represent EMACS_INT
2101 without losing information; this is not true on most 64-bit hosts.
2102 Avoid double-rounding errors, by insisting on integers when
2103 parsing non-base-10 numbers, as the documentation specifies.
2104 * lisp.h (string_to_number): New decl, replacing ...
2105 (isfloat_string): Remove.
2106 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2107 (read1): Do not accept +. and -. as integers; this
2108 appears to have been a coding error. Similarly, do not accept
2109 strings like +-1e0 as floating point numbers. Do not report
2110 overflow for integer overflows unless the base is not 10 which
2111 means we have no simple and reliable way to continue.
2112 Break out the floating-point parsing into a new
2113 function string_to_number, so that Fstring_to_number parses
2114 floating point numbers consistently with the Lisp reader.
2115 (digit_to_number): Move here from data.c. Make it static inline.
2116 (E_CHAR, EXP_INT): Remove, replacing with ...
2117 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2118 (string_to_number): New function, replacing isfloat_string.
2119 This function checks for valid syntax and produces the resulting
2120 Lisp float number too. Rework it so that string-to-number
2121 no longer mishandles examples like "1.0e+". Use strtoumax,
2122 so that overflow for non-base-10 numbers is reported only when
2123 there's no portable and simple way to convert to floating point.
2125 * textprop.c (set_text_properties_1): Rewrite for clarity,
2126 and to avoid GCC warning about integer overflow.
2128 * intervals.h (struct interval): Use EMACS_INT for members
2129 where EMACS_UINT might cause problems. See
2130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2131 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2132 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2134 (offset_intervals): Tell GCC not to worry about length overflow
2135 when negating a negative length.
2137 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2138 (overrun_check_free): Likewise.
2140 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2141 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2144 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2145 (gnutls_make_error): Rename local to avoid shadowing.
2146 (gnutls_emacs_global_deinit): ifdef out; not used.
2147 (Fgnutls_boot): Use const for pointer to readonly storage.
2148 Comment out unused local. Fix pointer signedness problems.
2150 * lread.c (openp): Don't stuff size_t into an 'int'.
2151 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2152 about possible signed overflow.
2154 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2155 (GDK_KEY_g): Don't define if already defined.
2156 (xg_prepare_tooltip): Avoid pointer signedness problem.
2157 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2159 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2160 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2162 * xfns.c (Fx_window_property): Simplify a bit,
2163 to make a bit faster and to avoid GCC 4.6.0 warning.
2164 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2166 * fns.c (internal_equal): Don't assume size_t fits in int.
2168 * alloc.c (compact_small_strings): Tighten assertion a little.
2170 Replace pEd with more-general pI, and fix some printf arg casts.
2171 * lisp.h (pI): New macro, generalizing old pEd macro to other
2172 conversion specifiers. For example, use "...%"pI"d..." rather
2173 than "...%"pEd"...".
2174 (pEd): Remove. All uses replaced with similar uses of pI.
2175 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2176 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2177 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2178 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2179 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2180 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2181 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2183 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2184 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2185 * print.c (safe_debug_print, print_object): Likewise.
2186 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2188 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2189 avoiding the 0 flag, which is not portable.
2190 * process.c (Fmake_network_process): Use pI to avoid cast.
2191 * region-cache.c (pp_cache): Likewise.
2192 * xdisp.c (decode_mode_spec): Likewise.
2193 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2194 behavior on 64-bit hosts with printf arg.
2195 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2196 (x_stop_queuing_selection_requests): Likewise.
2197 (x_get_window_property): Don't truncate byte count to an 'int'
2200 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2201 here, since it parses constructs like leading '-' and spaces,
2202 which are not wanted; and it overflows with large numbers.
2203 Instead, simply match F[0-9]+, which is what is wanted anyway.
2205 * alloc.c: Remove unportable assumptions about struct layout.
2206 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2207 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2208 (allocate_vectorlike, make_pure_vector): Use the new macros,
2209 plus offsetof, to remove unportable assumptions about struct layout.
2210 These assumptions hold on all porting targets that I know of, but
2211 they are not guaranteed, they're easy to remove, and removing them
2212 makes further changes easier.
2214 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2215 This doesn't fix a bug but makes the code clearer.
2216 (string_overrun_cookie): Now const. Use initializers that
2217 don't formally overflow signed char, to avoid warnings.
2218 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2219 can cause Emacs to crash when string overrun checking is enabled.
2220 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2221 multiple of sizeof (EMACS_INT); it need not be, if
2222 alignof(EMACS_INT) < sizeof (EMACS_INT).
2223 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2225 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2227 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2229 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2231 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2232 supposed to be handshaking. (Bug#8556)
2233 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2235 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2237 * lisp.h (Qdebug): List symbol.
2238 * eval.c (Qdebug): Restore global linkage.
2239 * keyboard.c (debug-on-event): New variable.
2240 (handle_user_signal): Break into debugger when debug-on-event
2241 matches the current signal symbol.
2243 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2245 * alloc.c (check_sblock, check_string_bytes)
2246 (check_string_free_list): Convert to standard C.
2248 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2250 * w32.c (emacs_gnutls_push): Fix typo.
2252 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2254 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2255 "cast to pointer from integer of different size".
2257 Improve doprnt and its use in verror. (Bug#8545)
2258 * doprnt.c (doprnt): Document the set of format control sequences
2259 supported by the function. Use SAFE_ALLOCA instead of always
2262 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2263 is one byte too soon. Don't use xrealloc; instead xfree and
2266 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2268 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2271 * gnutls.c: Renamed global_initialized to
2272 gnutls_global_initialized. Added internals for the
2273 :verify-hostname-error, :verify-error, and :verify-flags
2274 parameters of `gnutls-boot' and documented those parameters in the
2275 docstring. Start callback support.
2276 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2277 unless a fatal error occured. Call gnutls_alert_send_appropriate
2278 on error. Return error code.
2279 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2280 (emacs_gnutls_read): Likewise.
2281 (Fgnutls_boot): Return handshake error code.
2282 (emacs_gnutls_handle_error): New function.
2283 (wsaerror_to_errno): Likewise.
2285 * w32.h (emacs_gnutls_pull): Add prototype.
2286 (emacs_gnutls_push): Likewise.
2288 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2289 (emacs_gnutls_push): Likewise.
2291 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2293 * process.c (wait_reading_process_output): Check if GnuTLS
2294 buffered some data internally if no FDs are set for TLS
2297 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2298 (LIBS): Link to USER_LIBS.
2299 ($(BLD)/gnutls.$(0)): New target.
2301 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2303 * xdisp.c (handle_single_display_spec): Rename the
2304 display_replaced_before_p argument into display_replaced_p, to
2305 make it consistent with the commentary. Fix typos in the
2308 * textprop.c (syms_of_textprop): Remove dead code.
2309 (copy_text_properties): Delete obsolete commentary about an
2310 interface that was deleted long ago. Fix typos in the description
2313 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2314 to changes in oldXMenu/XMenu.h from 2011-04-16.
2315 <menu_help_message, prev_menu_help_message>: Constify.
2316 (IT_menu_make_room): menu->help_text is now `const char **';
2319 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2320 to changes in oldXMenu/XMenu.h from 2011-04-16.
2321 (struct XMenu): Declare `help_text' `const char **'.
2323 * xfaces.c <Qunspecified>: Make extern again.
2325 * syntax.c: Include sys/types.h before including regex.h, as
2328 * doc.c (get_doc_string): Improve the format passed to `error'.
2330 * doprnt.c (doprnt): Improve commentary.
2332 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2334 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2337 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2338 changes in globals.h immediately force recompilation.
2339 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2340 $(CURDIR)/s/ms-w32.h.
2341 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2343 * character.c (Fchar_direction): Function deleted.
2344 (syms_of_character): Don't defsubr it.
2345 <char-direction-table>: Deleted.
2347 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2349 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2350 * doprnt.c: Include limits.h.
2351 (SIZE_MAX): New macro.
2352 (doprnt): Return a size_t value. 2nd arg is now size_t.
2353 Many local variables are now size_t instead of int or unsigned.
2354 Improve overflow protection. Support `l' modifier for integer
2355 conversions. Support %l conversion. Don't assume an EMACS_INT
2356 argument for integer conversions and for %c.
2358 * lisp.h (doprnt): Restore prototype.
2360 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2363 * Makefile.in (base_obj): Add back doprnt.o.
2365 * deps.mk (doprnt.o): Add back prerequisites.
2366 (callint.o): Depend on character.h.
2368 * eval.c (internal_lisp_condition_case): Include the handler
2369 representation in the error message.
2370 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2371 when breaking from the loop.
2373 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2375 * callint.c (Fcall_interactively): When displaying error message
2376 about invalid control letter, pass the character's codepoint, not
2377 a pointer to its multibyte form. Improve display of the character
2378 in octal and display also its hex code.
2380 * character.c (char_string): Use %x to display the (unsigned)
2381 codepoint of an invalid character, to avoid displaying a bogus
2384 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2385 `error', not SYMBOL_NAME itself.
2387 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2388 character arguments to `error'.
2390 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2391 to `error' in error message about FINAL_CHAR argument. Make sure
2392 FINAL_CHAR is a character, and use %c when it is passed as
2393 argument to `error'.
2395 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2397 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2399 * w32.c: Include <time.h>.
2400 (sys_localtime): New function.
2402 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2404 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2406 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2408 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2410 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2413 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2415 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2416 gl_state.e_property when gl_state.object is Qt.
2418 * insdel.c (make_gap_larger): Remove limitation of buffer size
2421 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2423 * xdisp.c (lookup_glyphless_char_display)
2424 (produce_glyphless_glyph): Handle cons cell entry in
2425 glyphless-char-display.
2426 (Vglyphless_char_display): Document it.
2428 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2429 glyphless-char-display.
2431 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2433 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2435 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2437 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2438 definition for no-X builds.
2440 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2442 Static checks with GCC 4.6.0 and non-default toolkits.
2444 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2446 * process.c (keyboard_bit_set): Define only if SIGIO.
2447 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2448 (send_process): Repair possible setjmp clobbering.
2450 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2452 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2454 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2456 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2457 Define only if needed.
2459 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2460 by pacifying GCC about it. Maybe it's time to retire it?
2461 * xfaces.c (USG, __TIMEVAL__): Likewise.
2463 * dispextern.h (struct redisplay_interface): Rename param
2465 * termhooks.h (struct terminal): Likewise.
2466 * xterm.c (xembed_send_message): Likewise.
2468 * insdel.c (make_gap_smaller): Define only if
2469 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2471 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2474 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2475 so that we aren't warned about unused symbols.
2477 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2479 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2481 * xfns.c (x_real_positions): Mark locals as initialized.
2483 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2485 * xterm.c: Fix problems found by static analysis with other toolkits.
2486 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2487 (x_dispatch_event): Declare static if USE_GTK, and
2488 define if USE_GTK || USE_X_TOOLKIT.
2489 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2490 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2491 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2492 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2494 * xmenu.c (menu_help_callback): Pointer type fixes.
2495 Use const pointers when pointing at readonly data. Avoid pointer
2497 (FALSE): Remove unused macro.
2498 (update_frame_menubar): Remove unused decl.
2500 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2502 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2503 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2504 (single_menu_item): Rename local to avoid shadowing.
2506 * keyboard.c (make_lispy_event): Remove unused local var.
2508 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2509 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2511 * bitmaps: Change bitmaps from unsigned char back to the X11
2512 compatible char. Avoid the old compiler warnings about
2513 out-of-range initializers by using, for example, '\xab' rather
2516 * xgselect.c (xgselect_initialize): Check vs interface
2517 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2519 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2521 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2522 to read-only memory.
2524 * fns.c (vector): Remove; this old hack is no longer needed.
2526 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2528 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2530 * xrdb.c (x_load_resources): Omit unused local.
2532 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2533 (x_window): Rename locals to avoid shadowing.
2534 (USG): Use the kludged USG macro, to pacify gcc.
2536 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2537 (x_term_init): Remove local to avoid shadowing.
2539 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2541 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2542 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2544 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2546 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2548 Fix regex.c, syntax.c and friends for buffers > 2GB.
2549 * syntax.h (struct gl_state_s): Declare character position members
2552 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2554 * textprop.c (verify_interval_modification, interval_of):
2555 Declare arguments EMACS_INT.
2557 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2560 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2562 * indent.c (Fvertical_motion): Local variable it_start is now
2565 * regex.c (re_match, re_match_2, re_match_2_internal)
2566 (bcmp_translate, regcomp, regexec, print_double_string)
2567 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2568 (re_compile_pattern, re_exec): Declare arguments and local
2569 variables `size_t' and `ssize_t' and return values `regoff_t', as
2571 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2572 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2573 <compile_stack_type>: `size' and `avail' are now `size_t'.
2575 * regex.h <regoff_t>: Use ssize_t, not int.
2576 (re_search, re_search_2, re_match, re_match_2): Arguments that
2577 specify buffer/string position and length are now ssize_t and
2578 size_t. Return type is regoff_t.
2580 2011-04-16 Ben Key <bkey76@gmail.com>
2582 * nsfont.m: Fixed bugs in ns_get_family and
2583 ns_descriptor_to_entity that were caused by using free to
2584 deallocate memory blocks that were allocated by xmalloc (via
2585 xstrdup). This caused Emacs to crash when compiled with
2586 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2587 --enable-checking=xmallocoverrun). xfree is now used to
2588 deallocate these memory blocks.
2590 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2592 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2594 emacs_write: Accept and return EMACS_INT for sizes.
2595 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2597 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2598 Accept and return EMACS_INT.
2599 (emacs_gnutls_write): Return the number of bytes written on
2601 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2602 (emacs_read, emacs_write): Remove check for negative size, as the
2603 Emacs source code has been audited now.
2604 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2605 (emacs_read, emacs_write): Use it.
2606 * process.c (send_process): Adjust to the new signatures of
2607 emacs_write and emacs_gnutls_write. Do not attempt to store
2608 a byte offset into an 'int'; it might overflow.
2609 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2611 * sound.c: Don't assume sizes fit in 'int'.
2612 (struct sound_device.period_size, alsa_period_size):
2613 Return EMACS_INT, not int.
2614 (struct sound_device.write, vox_write, alsa_write):
2615 Accept EMACS_INT, not int.
2616 (wav_play, au_play): Use EMACS_INT to store sizes and to
2617 record read return values.
2619 2011-04-15 Ben Key <bkey76@gmail.com>
2621 * keyboard.c (Qundefined): Don't declare static since it is used
2623 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2624 static since they are used in nsfont.m.
2626 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2628 * process.c (Qprocessp): Don't declare static.
2629 * lisp.h (Qprocessp): Declare again.
2631 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2633 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2635 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2637 Improve C-level modularity by making more things 'static'.
2639 Don't publish debugger-only interfaces to other modules.
2640 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2641 (verify_bytepos, count_markers): Move decls to the only modules
2643 * region-cache.h (pp_cache): Likewise.
2644 * window.h (check_all_windows): Likewise.
2645 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2647 * sysdep.c (croak): Now static, if
2648 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2649 * syssignal.h (croak): Declare only if not static.
2651 * alloc.c (refill_memory_reserve): Now static if
2652 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2653 * lisp.h (refill_memory_reserve): Declare only if not static.
2655 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2656 Define only if USE_LUCID.
2658 * xrdb.c (x_customization_string, x_rm_string): Now static.
2660 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2661 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2663 * xdisp.c (draw_row_with_mouse_face): Now static.
2664 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2666 * window.h (check_all_windows): Mark externally visible.
2668 * window.c (window_deletion_count): Now static.
2670 * undo.c: Make symbols static if they're not exported.
2671 (last_undo_buffer, last_boundary_position, pending_boundary):
2674 * textprop.c (interval_insert_behind_hooks): Now static.
2675 (interval_insert_in_front_hooks): Likewise.
2677 * term.c: Make symbols static if they're not exported.
2678 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2679 (max_frame_lines, tty_set_terminal_modes):
2680 (tty_reset_terminal_modes, tty_turn_off_highlight):
2681 (get_tty_terminal): Now static.
2682 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2683 * termhooks.h (term_mouse_moveto): Do not declare if
2685 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2686 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2688 * sysdep.c: Make symbols static if they're not exported.
2689 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2691 (sigprocmask_set, full_mask): Remove; unused.
2692 (wait_debugging): Mark as visible.
2693 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2694 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2696 * syntax.c (syntax_temp): Define only if !__GNUC__.
2698 * sound.c (current_sound_device, current_sound): Now static.
2700 * search.c (searchbufs, searchbuf_head): Now static.
2702 * scroll.c (scroll_cost): Remove; unused.
2703 * dispextern.h (scroll_cost): Remove decl.
2705 * region-cache.h (pp_cache): Mark as externally visible.
2707 * process.c: Make symbols static if they're not exported.
2708 (process_tick, update_tick, create_process, chan_process):
2709 (Vprocess_alist, proc_buffered_char, datagram_access):
2710 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2711 (deactivate_process): Mark defn as static, as well as decl.
2712 * lisp.h (create_process): Remove decl.
2713 * process.h (chan_process, Vprocess_alist): Remove decls.
2715 * print.c: Make symbols static if they're not exported.
2716 (print_depth, new_backquote_output, being_printed, print_buffer):
2717 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2718 (print_interval, print_number_index, initial_stderr_stream):
2720 * lisp.h (Fprinc): Remove decl.
2721 (debug_output_compilation_hack): Mark as externally visible.
2723 * sysdep.c (croak): Move decl from here to syssignal.h.
2724 * syssignal.h (croak): Put it here, so the API can be checked when
2725 'croak' is called from dissociate_if_controlling_tty.
2727 * minibuf.c: Make symbols static if they're not exported.
2728 (minibuf_save_list, choose_minibuf_frame): Now static.
2729 * lisp.h (choose_minibuf_frame): Remove decl.
2731 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2733 * lread.c: Make symbols static if they're not exported.
2734 (read_objects, initial_obarray, oblookup_last_bucket_number):
2736 (make_symbol): Remove; unused.
2737 * lisp.h (initial_obarray, make_symbol): Remove decls.
2739 * keyboard.c: Make symbols static if they're not exported.
2740 (single_kboard, recent_keys_index, total_keys, recent_keys):
2741 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2742 (this_single_command_key_start, echoing, last_auto_save):
2743 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2744 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2745 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2746 (Vlispy_mouse_stem, double_click_count):
2748 (force_auto_save_soon): Define only if SIGDANGER.
2749 (ignore_mouse_drag_p): Now static if
2750 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2751 (print_help): Remove; unused.
2752 (stop_character, last_timer_event): Mark as externally visible.
2753 * keyboard.h (ignore_mouse_drag_p): Declare only if
2754 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2755 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2756 * lisp.h (echoing): Remove decl.
2757 (force_auto_save_soon): Declare only if SIGDANGER.
2758 * xdisp.c (redisplay_window): Simplify code, to make it more
2759 obvious that ignore_mouse_drag_p is not accessed if !defined
2760 USE_GTK && !defined HAVE_NS.
2762 * intervals.c: Make symbols static if they're not exported.
2763 (merge_properties_sticky, merge_interval_right, delete_interval):
2765 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2767 * insdel.c: Make symbols static if they're not exported.
2768 However, leave prepare_to_modify_buffer alone. It's never
2769 called from outside this function, but that appears to be a bug.
2770 (combine_after_change_list, combine_after_change_buffer):
2771 (adjust_after_replace, signal_before_change): Now static.
2772 (adjust_after_replace_noundo): Remove; unused.
2773 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2774 (signal_before_change): Remove decls.
2776 * indent.c (val_compute_motion, val_vmotion): Now static.
2778 * image.c: Make symbols static if they're not exported.
2779 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2781 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2782 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2784 * fringe.c (standard_bitmaps): Now static.
2785 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2787 * frame.c: Make symbols static if they're not exported.
2788 (x_report_frame_params, make_terminal_frame): Now static.
2789 (get_frame_param): Now static, unless HAVE_NS.
2790 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2791 (x_get_resource_string): Remove; not used.
2792 * frame.h (make_terminal_frame, x_report_frame_params):
2793 (x_get_resource_string); Remove decls.
2794 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2795 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2797 * font.c, fontset.c: Make symbols static if they're not exported.
2798 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2799 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2800 * font.c (font_close_object): Now static.
2801 * font.h (font_close_object): Remove.
2802 * fontset.c (FONTSET_OBJLIST): Remove.
2803 (free_realized_fontset) #if-0 the body, which does nothing.
2804 (face_suitable_for_char_p): #if-0, as it's never called.
2805 * fontset.h (face_suitable_for_char_p): Remove decl.
2806 * xfaces.c (face_at_string_position):
2807 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2808 since 0 is always ASCII.
2810 * fns.c (weak_hash_tables): Now static.
2812 * fileio.c: Make symbols static if they're not exported.
2813 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2814 (Vwrite_region_annotation_buffers): Now static.
2816 * eval.c: Make symbols static if they're not exported.
2817 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2818 * lisp.h (backtrace_list): Remove decl.
2820 * emacs.c: Make symbols static if they're not exported.
2821 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2822 (fatal_error_code, fatal_error_signal_hook, standard_args):
2824 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2825 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2826 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2827 * lisp.h (fatal_error_signal_hook): Remove decl.
2828 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2830 * editfns.c: Move a (normally-unused) function to its only use.
2831 * editfns.c, lisp.h (get_operating_system_release): Remove.
2832 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2833 worth the hassle of breaking this out.
2835 * xterm.c: Make symbols static if they're not exported.
2836 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2837 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2838 (x_destroy_window, x_delete_display):
2840 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2841 (x_mouse_leave): Remove; unused.
2842 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2843 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2844 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2846 (x_mouse_leave): Declare only if WINDOWSNT.
2847 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2848 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2851 * ftxfont.c: Make symbols static if they're not exported.
2852 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2854 * font.h (ftxfont_driver): Likewise.
2856 * xfns.c: Make symbols static if they're not exported.
2857 (x_last_font_name, x_display_info_for_name):
2858 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2859 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2860 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2861 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2862 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2863 (last_show_tip_args): Now static.
2864 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2865 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2866 (x_screen_planes): Remove; unused.
2867 * dispextern.h (x_screen_planes): Remove decl.
2869 * dispnew.c: Make symbols static if they're not exported.
2870 * dispextern.h (redraw_garbaged_frames, scrolling):
2871 (increment_row_positions): Remove.
2872 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2873 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2875 (redraw_garbaged_frames): Remove; unused.
2877 * xfaces.c: Make symbols static if they're not exported.
2878 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2880 * xterm.h (defined_color): Remove decls.
2881 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2882 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2883 (menu_face_changed_default, defined_color, free_realized_face):
2884 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2885 (ascii_face_of_lisp_face): Remove; unused.
2887 * xdisp.c: Make symbols static if they're not exported.
2888 * dispextern.h (scratch_glyph_row, window_box_edges):
2889 (glyph_to_pixel_coords, set_cursor_from_row):
2890 (get_next_display_element, set_iterator_to_next):
2891 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2892 (show_mouse_face): Remove decls
2893 * frame.h (message_buf_print): Likewise.
2894 * lisp.h (pop_message, set_message, check_point_in_composition):
2896 * xterm.h (set_vertical_scroll_bar): Likewise.
2897 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2898 (message_buf_print, scratch_glyph_row, displayed_buffer):
2899 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2900 (get_next_display_element, show_mouse_face, window_box_edges):
2901 (frame_to_window_pixel_xy, check_point_in_composition):
2902 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2903 (glyph_to_pixel_coords): Remove; unused.
2905 * dired.c (file_name_completion): Now static.
2907 * dbusbind.c (xd_in_read_queued_messages): Now static.
2909 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2910 * data.c (circular_list_error): Remove.
2912 * commands.h (last_point_position, last_point_position_buffer):
2913 (last_point_position_window): Remove decls.
2914 * keyboard.c: Make these variables static.
2916 * coding.h (coding, code_convert_region, encode_coding_gap):
2918 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2919 (iso_code_class, detect_coding, code_convert_region): Now static.
2920 (encode_coding_gap): Remove; unused.
2922 * chartab.c (chartab_chars, chartab_bits): Now static.
2924 * charset.h (charset_iso_8859_1): Remove decl.
2925 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2928 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2929 * ccl.c (Vccl_program_table): Now static.
2930 (check_ccl_update): Remove; unused.
2932 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2933 * category.h: ... from here.
2934 * category.c (check_category_table, set_category_set): Now static.
2936 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2937 * lisp.h: Remove these decls.
2939 * buffer.c (buffer_count): Remove unused var.
2941 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2942 so that it's not optimized away.
2943 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2944 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2945 exported only to the debugger.
2947 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2948 * atimer.h (run_all_atimers): Remove; not exported.
2950 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2951 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2952 was inaccessible from Lisp.
2953 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2954 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2956 alloc.c: Import and export fewer symbols, and remove unused items.
2957 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2959 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2960 it's not optimized away by whole-program optimization.
2961 (message_enable_multibyte, free_misc): Remove.
2962 (catchlist, handlerlist, mark_backtrace):
2963 Declare only if BYTE_MARK_STACK.
2964 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2965 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2966 (message_enable_multibyte): Remove decl.
2967 (free_misc, interval_free_list, float_block, float_block_index):
2968 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2969 (cons_free_list, last_marked_index):
2971 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2972 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2973 (mark_backtrace): Define only if BYTE_MARK_STACK.
2974 * xdisp.c (message_enable_multibyte): Now static.
2976 Declare Lisp_Object Q* variables to be 'static' if not exported.
2977 This makes it easier for human readers (and static analyzers)
2978 to see whether these variables are used from other modules.
2979 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2980 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2981 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2982 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2983 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2984 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2985 * xmenu.c, xselect.c:
2986 Declare Q* vars static if they are not used in other modules.
2987 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2988 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2989 Remove decls of unexported vars.
2990 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2992 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2994 Make Emacs functions such as Fatom 'static' by default.
2995 This makes it easier for human readers (and static analyzers)
2996 to see whether these functions can be called from other modules.
2997 DEFUN now defines a static function. To make the function external
2998 so that it can be used in other C modules, use the new macro DEFUE.
2999 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3000 (Finit_image_library):
3001 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3002 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3003 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3004 Remove decls, since these functions are now static.
3005 (Funintern, Fget_internal_run_time): New decls, since these functions
3006 were already external.
3008 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3009 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3010 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3011 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3012 * keyboard.c, keymap.c, lread.c:
3013 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3014 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3015 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3016 Mark functions with DEFUE instead of DEFUN,
3017 if they are used in other modules.
3018 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3019 decls for now-static functions.
3020 * buffer.h (Fdelete_overlay): Remove decl.
3021 * callproc.c (Fgetenv_internal): Mark as internal.
3022 * composite.c (Fremove_list_of_text_properties): Remove decl.
3023 (Fcomposition_get_gstring): New forward static decl.
3024 * composite.h (Fcomposite_get_gstring): Remove decl.
3025 * dired.c (Ffile_attributes): New forward static decl.
3026 * doc.c (Fdocumntation_property): New forward static decl.
3027 * eval.c (Ffetch_bytecode): New forward static decl.
3028 (Funintern): Remove extern decl; now in .h file where it belongs.
3029 * fileio.c (Fmake_symbolic_link): New forward static decl.
3030 * image.c (Finit_image_library): New forward static decl.
3031 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3032 * intervals.h (Fprevious_property_change):
3033 (Fremove_list_of_text_properties): Remove decls.
3034 * keyboard.c (Fthis_command_keys): Remove decl.
3035 (Fcommand_execute): New forward static decl.
3036 * keymap.c (Flookup_key): New forward static decl.
3037 (Fcopy_keymap): Now static.
3038 * keymap.h (Flookup_key): Remove decl.
3039 * process.c (Fget_process): New forward static decl.
3040 (Fprocess_datagram_address): Mark as internal.
3041 * syntax.c (Fsyntax_table_p): New forward static decl.
3042 (skip_chars): Remove duplicate decl.
3043 * textprop.c (Fprevious_property_change): New forward static decl.
3044 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3046 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3047 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3049 * editfns.c (Fformat): Remove unreachable code.
3051 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3053 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3056 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3058 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3059 when at ZV. (Bug#8487)
3061 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3063 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3065 * keyboard.c (parse_tool_bar_item): Likewise.
3066 * sound.c (sound_cleanup, alsa_close): Likewise.
3067 * termcap.c (tgetent): Likewise.
3068 * xfns.c (x_default_font_parameter): Likewise.
3069 * xsettings.c (read_and_apply_settings): Likewise.
3071 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3072 (overrun_check_free): Protoize.
3074 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3076 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3077 since callers should never pass a negative size.
3078 Change the signature to match that of plain 'read' and 'write'; see
3079 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3080 * lisp.h: Update prototypes of emacs_write and emacs_read.
3082 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3084 * xdisp.c (redisplay_window): Don't try to determine the character
3085 position of the scroll margin if the window start point w->startp
3086 is outside the buffer's accessible region. (Bug#8468)
3088 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3090 Fix write-region and its subroutines for buffers > 2GB.
3091 * fileio.c (a_write, e_write): Modify declaration of arguments and
3092 local variables to support buffers larger than 2GB.
3093 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3095 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3096 argument, local variables, and return value.
3098 * lisp.h: Update prototypes of emacs_write and emacs_read.
3100 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3102 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3104 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3106 Fix more problems found by GCC 4.6.0's static checks.
3108 * xdisp.c (vmessage): Use a better test for character truncation.
3110 * charset.c (load_charset_map): <, not <=, for optimization,
3111 and to avoid potential problems with integer overflow.
3112 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3113 * casetab.c (set_identity, shuffle): Likewise.
3114 * editfns.c (Fformat): Likewise.
3115 * syntax.c (skip_chars): Likewise.
3117 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3118 This also lets GCC 4.6.0 generate slightly better loop code.
3120 * callint.c (Fcall_interactively): <, not <=, for optimization.
3121 (Fcall_interactively): Count the number of arguments produced,
3122 not the number of arguments given. This is simpler and lets GCC
3123 4.6.0 generate slightly better code.
3125 * ftfont.c: Distingish more carefully between FcChar8 and char.
3126 The previous code passed unsigned char * to a functions like
3127 strlen and xstrcasecmp that expect char *, which does not
3128 conform to the C standard.
3129 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3130 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3131 char * when the C standard requires it.
3133 * keyboard.c (read_char): Remove unused var.
3135 * eval.c: Port to Windows vsnprintf (Bug#8435).
3137 (SIZE_MAX): Define if the headers do not.
3138 (verror): Do not give up if vsnprintf returns a negative count.
3139 Instead, grow the buffer. This ports to Windows vsnprintf, which
3140 does not conform to C99. Problem reported by Eli Zaretskii.
3141 Also, simplify the allocation scheme, by avoiding the need for
3142 calling realloc, and removing the ALLOCATED variable.
3144 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3146 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3147 But keep the doprint source code for now, as we might revamp it
3148 and use it again (Bug#8435).
3149 * lisp.h (doprnt): Remove.
3150 * Makefile.in (base_obj): Remove doprnt.o.
3151 * deps.mk (doprnt.o): Remove.
3153 error: Print 32- and 64-bit integers portably (Bug#8435).
3154 Without this change, on typical 64-bit hosts error ("...%d...", N)
3155 was used to print both 32- and 64-bit integers N, which relied on
3157 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3159 * lisp.h (error, verror): Mark as printf-like functions.
3160 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3161 Report overflow in size calculations when allocating printf buffer.
3162 Do not truncate output string at its first null byte.
3163 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3164 Truncate the output at a character boundary, since vsnprintf does not
3166 * charset.c (check_iso_charset_parameter): Convert internal
3167 character to string before calling 'error', since %c now has the
3169 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3170 overflow when computing char to be passed to 'error'. Do not
3171 pass Lisp_Object to 'error'; pass the integer instead.
3172 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3173 formatted with plain %d.
3175 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3177 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3179 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3181 * xterm.c (x_catch_errors): Remove duplicate declaration.
3183 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3185 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3187 2011-04-10 Jim Meyering <meyering@redhat.com>
3189 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3190 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3191 return ssize_t not "int", and use size_t as the buffer length.
3192 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3193 * gnutls.h: Update declarations.
3194 * process.c (read_process_output): Use ssize_t, to match.
3195 (send_process): Likewise.
3197 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3199 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3201 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3203 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3204 Use unsigned char, to match FcChar8 type definition.
3206 * xterm.c (handle_one_xevent):
3207 * xmenu.c (create_and_show_popup_menu):
3208 * xselect.c (x_decline_selection_request)
3209 (x_reply_selection_request): Avoid type-punned deref of X events.
3211 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3213 Fix some uses of `int' instead of EMACS_INT.
3214 * search.c (string_match_1, fast_string_match)
3215 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3216 (scan_buffer, find_next_newline_no_quit)
3217 (find_before_next_newline, search_command, Freplace_match)
3218 (Fmatch_data): Make some `int' variables be EMACS_INT.
3220 * xdisp.c (display_count_lines): 3rd argument and return value now
3221 EMACS_INT. All callers changed.
3222 (pint2hrstr): Last argument is now EMACS_INT.
3224 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3225 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3226 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3227 (decode_coding_utf_16, decode_coding_emacs_mule)
3228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3229 (decode_coding_ccl, decode_coding_charset)
3230 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3231 (decode_coding_iso_2022, decode_coding_emacs_mule)
3232 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3233 <char_offset, last_offset>: Declare EMACS_INT.
3234 (encode_coding_utf_8, encode_coding_utf_16)
3235 (encode_coding_emacs_mule, encode_invocation_designation)
3236 (encode_designation_at_bol, encode_coding_iso_2022)
3237 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3238 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3240 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3241 (encode_invocation_designation): Last argument P_NCHARS is now
3243 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3244 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3246 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3249 * ccl.c (Fccl_execute_on_string): Declare some variables
3252 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3254 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3256 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3258 * process.c (Fformat_network_address): Doc fix.
3260 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3262 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3264 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3266 * keyboard.c (read_char): Call Lisp function help-form-show,
3267 instead of using internal_with_output_to_temp_buffer.
3268 (Qhelp_form_show): New var.
3269 (syms_of_keyboard): Use DEFSYM macro.
3271 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3273 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3275 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3277 * process.c (Flist_processes): Remove to Lisp.
3278 (list_processes_1): Delete.
3280 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3282 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3284 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3286 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3288 Fix more problems found by GCC 4.6.0's static checks.
3290 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3292 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3294 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3296 * xdisp.c (vmessage): Mark as a printf-like function.
3298 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3300 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3302 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3303 printf-like functions.
3304 (tiff_load): Add casts to remove these marks before passing them
3305 to system-supplied API.
3307 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3309 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3310 This avoids several warnings with gcc -Wstrict-overflow.
3311 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3312 directly, rather than having caller test rule sign. This avoids
3313 some unnecessary tests.
3314 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3315 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3316 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3318 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3319 (xfont_open): Avoid unnecessary tests.
3321 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3323 * composite.h, composite.c (composition_gstring_put_cache):
3324 Use EMACS_INT, not int, for length.
3326 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3327 breaking out part of COMPOSITION_DECODE_RULE.
3328 (COMPOSITION_DECODE_RULE): Use it.
3329 * composite.c (get_composition_id): Remove unused local vars,
3330 by using the new macro.
3332 * textprop.c (set_text_properties_1): Change while to do-while,
3333 since the condition is always true at first.
3335 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3336 (interval_deletion_adjustment): Return unsigned value.
3339 * process.c (list_processes_1, create_pty, read_process_output):
3340 (exec_sentinel): Remove vars that were set but not used.
3341 (create_pty): Remove unnecessary "volatile"s.
3342 (Fnetwork_interface_info): Avoid possibility of int overflow.
3343 (read_process_output): Do adaptive read buffering even if carryover.
3344 (read_process_output): Simplify nbytes computation if buffered.
3346 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3348 * syntax.c (scan_words): Remove var that was set but not used.
3349 (update_syntax_table): Use unsigned instead of int.
3351 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3352 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3353 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3355 * print.c (print_error_message): Avoid int overflow.
3357 * font.c (font_list_entities): Redo for clarity,
3358 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3360 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3361 (font_score): Avoid potential overflow in diff calculation.
3363 * fns.c (substring_both): Remove var that is set but not used.
3364 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3366 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3368 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3369 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3370 can always succeed if overflow has undefined behavior.
3372 * search.c (boyer_moore, wordify): Remove vars set but not used.
3373 (wordify): Omit three unnecessary tests.
3375 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3376 All callers changed. This avoids the need for an unused var.
3378 * casefiddle.c (casify_region): Remove var that is set but not used.
3380 * dired.c (file_name_completion): Remove var that is set but not used.
3382 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3384 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3385 (Finsert_file_contents): Remove unnecessary code checking fd.
3387 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3388 Check for integer overflow on size calculations.
3390 * buffer.c (Fprevious_overlay_change): Remove var that is set
3393 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3394 Remove vars that are set but not used.
3395 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3396 (timer_check_2): Mark vars as initialized.
3398 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3400 * image.c (lookup_image): Remove var that is set but not used.
3401 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3403 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3404 that are set but not used.
3406 * xfns.c (make_invisible_cursor): Don't return garbage
3407 if XCreateBitmapFromData fails (Bug#8410).
3409 * xselect.c (x_get_local_selection, x_handle_property_notify):
3410 Remove vars that are set but not used.
3412 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3413 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3415 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3416 Remove var that is set but not used.
3417 (scroll_bar_windows_size): Now size_t, not int.
3418 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3421 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3422 (map_tty_color) [!defined MSDOS]: Likewise.
3424 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3426 * coding.c: Remove vars that are set but not used.
3427 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3428 All callers changed.
3429 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3430 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3431 (decode_coding_charset): Remove vars that are set but not used.
3433 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3434 that is set but not used.
3436 * print.c (print_object): Remove var that is set but not used.
3438 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3439 The gnulib version avoids calling malloc in the usual case,
3440 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3441 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3442 * filelock.c (current_lock_owner): Likewise.
3443 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3444 * sysdep.c: Include allocator.h, careadlinkat.h.
3445 (emacs_no_realloc_allocator): New static constant.
3446 (emacs_readlink): New function.
3447 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3448 ../lib/careadlinkat.h.
3450 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3452 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3453 first non-nil return value).
3455 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3457 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3458 if not defined (Bug#8403).
3460 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3462 * xdisp.c (display_count_lines): Remove parameter `start',
3463 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3464 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3465 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3466 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3467 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3468 and thereabouts. All callers changed.
3469 (get_per_char_metric): Remove parameter `f', unused since
3470 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3472 2011-04-02 Jim Meyering <meyering@redhat.com>
3474 do not dereference NULL upon failed strdup
3475 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3476 (ns_get_family): Likewise.
3478 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3480 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3482 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3484 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3487 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3489 Add lexical binding.
3491 * window.c (Ftemp_output_buffer_show): New fun.
3492 (Fsave_window_excursion):
3493 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3495 * lread.c (lisp_file_lexically_bound_p): New function.
3496 (Fload): Bind Qlexical_binding.
3497 (readevalloop): Remove `evalfun' arg.
3498 Bind Qinternal_interpreter_environment.
3499 (Feval_buffer): Bind Qlexical_binding.
3500 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3502 (syms_of_lread): Declare `lexical-binding'.
3504 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3506 * keyboard.c (eval_dyn): New fun.
3507 (menu_item_eval_property): Use it.
3509 * image.c (parse_image_spec): Use Ffunctionp.
3511 * fns.c (concat, mapcar1): Accept byte-code-functions.
3513 * eval.c (Fsetq): Handle lexical vars.
3514 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3515 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3516 (FletX, Flet): Obey lexical binding.
3517 (Fcommandp): Handle closures.
3518 (Feval): New `lexical' arg.
3519 (eval_sub): New function extracted from Feval. Use it almost
3520 everywhere where Feval was used. Look up vars in lexical env.
3522 (Ffunctionp): Move from subr.el.
3523 (Ffuncall): Handle closures.
3524 (apply_lambda): Remove `eval_flags'.
3525 (funcall_lambda): Handle closures and new byte-code-functions.
3526 (Fspecial_variable_p): New function.
3527 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3528 but without exporting it to Lisp.
3530 * doc.c (Fdocumentation, store_function_docstring):
3531 * data.c (Finteractive_form): Handle closures.
3533 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3536 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3538 (exec_byte_code): New function extracted from Fbyte_code to handle new
3539 calling convention for byte-code-functions. Add new byte-codes.
3541 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3543 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3545 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3547 * xdisp.c (redisplay_internal): Fix prototype.
3549 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3551 * xdisp.c (SCROLL_LIMIT): New macro.
3552 (try_scrolling): Use it when setting scroll_limit.
3553 Limit scrolling to 100 screen lines.
3554 (redisplay_window): Even when falling back on "recentering",
3555 position point in the window according to scroll-conservatively,
3556 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3558 (try_scrolling): When point is above the window, allow searching
3559 as far as scroll_max, or one screenful, to compute vertical
3560 distance from PT to the scroll margin position. This prevents
3561 try_scrolling from unnecessarily failing when
3562 scroll-conservatively is set to a value slightly larger than the
3563 window height. Clean up the case of PT below the margin at bottom
3564 of window: scroll_max can no longer be INT_MAX. When aggressive
3565 scrolling is in use, don't let point enter the opposite scroll
3566 margin as result of the scroll.
3567 (syms_of_xdisp) <scroll-conservatively>: Document the
3568 threshold of 100 lines for never-recentering scrolling.
3570 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3572 * dispextern.h (move_it_by_lines):
3573 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3574 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3575 (message_log_check_duplicate): Remove parameters `prev_bol' and
3576 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3577 (redisplay_internal): Remove parameter `preserve_echo_area',
3578 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3580 * indent.c (Fvertical_motion):
3581 * window.c (window_scroll_pixel_based, Frecenter):
3582 Don't pass `need_y_p' to `move_it_by_lines'.
3584 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3586 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3587 steal a few bits to be more compact.
3588 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3589 Remove unneeded casts.
3591 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3593 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3595 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3596 binding" message (bug#7967).
3598 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3600 Fix more problems found by GCC 4.6.0's static checks.
3602 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3603 Remove unused local var.
3605 * editfns.c (Fmessage_box): Remove unused local var.
3607 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3608 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3609 Omit unused local vars.
3610 * window.c (shrink_windows): Omit unused local var.
3611 * menu.c (digest_single_submenu): Omit unused local var.
3612 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3613 Omit unused local var.
3615 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3616 Don't assume string length fits in int.
3617 (keyremap_step, read_key_sequence): Use size_t for sizes.
3618 (read_key_sequence): Don't check last_real_key_start redundantly.
3620 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3621 instead of alloca (Bug#8344).
3623 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3624 (Fbacktrace_frame): Don't assume nframes fits in int.
3626 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3628 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3631 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3633 * cm.c (calccost): Turn while-do into do-while, for clarity.
3635 * keyboard.c (syms_of_keyboard): Use the same style as later
3636 in this function when indexing through an array. This also
3637 works around GCC bug 48267.
3639 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3641 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3643 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3644 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3646 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3647 This avoids undefined behavior on integer overflow, and is a bit
3648 more convenient anyway since it is compared to a size_t variable.
3650 Variadic C functions now count arguments with size_t, not int.
3651 This avoids an unnecessary limitation on 64-bit machines, which
3652 caused (substring ...) to crash on large vectors (Bug#8344).
3653 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3654 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3655 All variadic functions and their callers changed accordingly.
3656 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3657 * data.c (arith_driver, float_arith_driver): Likewise.
3658 * editfns.c (general_insert_function): Likewise.
3659 * eval.c (struct backtrace.nargs, interactive_p)
3660 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3661 (funcall_lambda, mark_backtrace): Likewise.
3662 * fns.c (concat): Likewise.
3663 * frame.c (x_set_frame_parameters): Likewise.
3664 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3665 0 if not found, not -1. All callers changed.
3667 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3668 (stack_copy_size): Now size_t, not int.
3669 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3671 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3673 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3674 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3675 All callers changed.
3677 * lisp.h (multibyte_char_to_unibyte):
3678 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3679 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3680 * character.h (CHAR_TO_BYTE8):
3681 * cmds.c (internal_self_insert):
3682 * editfns.c (general_insert_function):
3683 * keymap.c (push_key_description):
3684 * search.c (Freplace_match):
3685 * xdisp.c (message_dolog, set_message_1): All callers changed.
3687 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3689 * keyboard.c (safe_run_hook_funcall): New function.
3690 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3691 don't set the hook to nil, but remove the offending function instead.
3692 (Qcommand_hook_internal): Remove, unused.
3693 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3694 Vcommand_hook_internal.
3696 * eval.c (enum run_hooks_condition): Remove.
3697 (funcall_nil, funcall_not): New functions.
3698 (run_hook_with_args): Call each function through a `funcall' argument.
3699 Remove `cond' argument, now redundant.
3700 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3701 (Frun_hook_with_args_until_failure): Adjust accordingly.
3702 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3704 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3706 * dispextern.h (string_buffer_position): Remove declaration.
3708 * print.c (strout): Remove parameter `multibyte', unused since
3709 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3711 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3712 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3713 All callers changed.
3715 * w32.c (_wsa_errlist): Use braces for struct initializers.
3717 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3718 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3719 All callers changed.
3720 (string_buffer_position): Likewise. Also, make static (it's never
3721 used outside xdisp.c).
3722 (cursor_row_p): Remove parameter `w', unused since
3723 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3724 (decode_mode_spec): Remove parameter `precision', introduced during
3725 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3726 All callers changed.
3728 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3730 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3732 2011-03-27 Anders Lindgren <andlind@gmail.com>
3734 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3735 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3736 (ns_update_auto_hide_menu_bar): New functions.
3737 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3738 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3739 ns_constrain_all_frames.
3740 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3741 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3743 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3745 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3747 2011-03-27 Glenn Morris <rgm@gnu.org>
3749 * syssignal.h: Replace RETSIGTYPE with void.
3750 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3751 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3752 Replace SIGTYPE with void everywhere.
3753 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3754 * s/template.h (SIGTYPE): Remove commented out definition.
3756 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3758 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3759 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3761 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3763 * w32.c (read_unc_volume): Use parameter `henum', instead of
3764 global variable `wget_enum_handle'.
3766 * keymap.c (describe_vector): Remove parameters `indices' and
3767 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3768 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3770 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3772 * keyboard.c (timer_check): Remove parameter `do_it_now',
3773 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3774 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3775 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3777 * keyboard.c (read_char):
3778 * w32menu.c (w32_menu_display_help):
3779 * xmenu.c (show_help_event, menu_help_callback):
3780 Adjust calls to `show_help_echo'.
3782 * gtkutil.c (xg_maybe_add_timer):
3783 * keyboard.c (readable_events):
3784 * process.c (wait_reading_process_output):
3785 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3787 * insdel.c (adjust_markers_gap_motion):
3788 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3789 (gap_left, gap_right): Don't call it.
3791 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3793 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3794 incurred during fontification.
3796 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3798 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3799 (DEFVAR_PER_BUFFER): Don't pass it.
3801 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3802 (scrolling_window): Don't pass it.
3804 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3806 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3808 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3810 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3811 of variables specific to SELinux and computation of `encoded_absname'.
3813 * image.c (XPutPixel): Remove unused variable `height'.
3815 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3817 * unexw32.c (get_section_info): Remove unused variable `section'.
3819 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3820 (system_process_attributes): Remove unused variable `sess'.
3821 (sys_read): Remove unused variable `err'.
3823 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3824 (w32_wnd_proc): Remove unused variable `isdead'.
3825 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3826 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3827 (x_create_tip_frame): Remove unused variable `tem'.
3829 * w32inevt.c (w32_console_read_socket):
3830 Remove unused variable `no_events'.
3832 * w32term.c (x_draw_composite_glyph_string_foreground):
3833 Remove unused variable `width'.
3835 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3837 * w32term.c (x_set_glyph_string_clipping):
3838 Don't pass uninitialized region to CombineRgn.
3840 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3842 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3843 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3844 (Fx_close_connection): Remove unused variable `i'.
3846 * w32font.c (w32font_draw): Return number of glyphs.
3847 (w32font_open_internal): Remove unused variable `i'.
3848 (w32font_driver): Add missing initializer.
3850 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3851 (fill_in_menu): Remove unused variable `items_added'.
3853 * w32term.c (last_mouse_press_frame): Remove static global variable.
3854 (w32_clip_to_row): Remove unused variable `f'.
3855 (x_delete_terminal): Remove unused variable `i'.
3857 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3858 (NOTHING): Remove unused static global variable.
3859 (uniscribe_check_otf): Remove unused variable `table'.
3860 (uniscribe_font_driver): Add missing initializers.
3862 2011-03-23 Julien Danjou <julien@danjou.info>
3864 * term.c (Fsuspend_tty, Fresume_tty):
3865 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3866 * window.c (temp_output_buffer_show):
3867 * insdel.c (signal_before_change):
3868 * frame.c (Fhandle_switch_frame):
3869 * fileio.c (Fdo_auto_save):
3870 * emacs.c (Fkill_emacs):
3871 * editfns.c (save_excursion_restore):
3872 * cmds.c (internal_self_insert):
3873 * callint.c (Fcall_interactively):
3874 * buffer.c (Fkill_all_local_variables):
3875 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3877 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3878 unconditionnaly since it does the check itself.
3880 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3882 Fix more problems found by GCC 4.5.2's static checks.
3884 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3885 the first time through the loop, since we know p0 < p1 then.
3886 This also avoids a gcc -Wstrict-overflow warning.
3888 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3889 leading to a memory leak, possible in functions like
3890 load_charset_map_from_file that can allocate an unbounded number
3891 of objects (Bug#8318).
3893 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3894 that could (at least in theory) be that large.
3896 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3897 This is less likely to overflow, and avoids undefined behavior if
3898 overflow does occur. All callers changed. Use strtoul to scan
3899 for the unsigned long integer.
3900 (pint2hrstr): Simplify and tune code slightly.
3901 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3903 * scroll.c (do_scrolling): Work around GCC bug 48228.
3904 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3906 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3907 This also avoids a warning with gcc -Wstrict-overflow.
3908 (validate_x_resource_name): Simplify count usage.
3909 This also avoids a warning with gcc -Wstrict-overflow.
3911 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3914 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3916 * process.c (Fmake_network_process): Use socklen_t, not int,
3917 where POSIX says socklen_t is required in portable programs.
3918 This fixes a porting bug on hosts like 64-bit HP-UX, where
3919 socklen_t is wider than int (Bug#8277).
3920 (Fmake_network_process, server_accept_connection):
3921 (wait_reading_process_output, read_process_output):
3924 * process.c: Rename or move locals to avoid shadowing.
3925 (list_processes_1, Fmake_network_process):
3926 (read_process_output_error_handler, exec_sentinel_error_handler):
3927 Rename or move locals.
3928 (Fmake_network_process): Define label "retry_connect" only if needed.
3929 (Fnetwork_interface_info): Fix pointer signedness.
3930 (process_send_signal): Add cast to avoid pointer signedness problem.
3931 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3932 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3934 Make tparam.h and terminfo.c consistent.
3935 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3936 Include tparam.h instead, since it declares them.
3937 * cm.h (PC): Remove extern decl; tparam.h now does this.
3938 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3939 * terminfo.c: Include tparam.h, to check interfaces.
3940 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3941 (tparam): Adjust signature to match interface in tparam.h;
3942 this removes some undefined behavior. Check that outstring and len
3943 are zero, which they always are with Emacs.
3944 * tparam.h (PC, BC, UP): New extern decls.
3946 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3947 (xftfont_open): Rename locals to avoid shadowing.
3949 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3950 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3951 (OTF_TAG_SYM): Omit macro if not needed.
3952 (ftfont_list): Remove unused local.
3953 (get_adstyle_property, ftfont_pattern_entity):
3954 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3955 Rename locals to avoid shadowing.
3957 * xfont.c (xfont_list_family): Mark var as initialized.
3959 * xml.c (make_dom): Now static.
3961 * composite.c (composition_compute_stop_pos): Rename local to
3963 (composition_reseat_it): Remove unused locals.
3964 (find_automatic_composition, composition_adjust_point): Likewise.
3965 (composition_update_it): Mark var as initialized.
3966 (find_automatic_composition): Mark vars as initialized,
3967 with a FIXME (Bug#8290).
3969 character.h: Rename locals to avoid shadowing.
3970 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3971 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3972 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3973 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3976 * textprop.c (property_change_between_p): Remove; unused.
3978 * intervals.c (interval_start_pos): Now static.
3980 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3982 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3983 Rename locals to avoid shadowing.
3985 * sound.c (wav_play, au_play, Fplay_sound_internal):
3986 Fix pointer signedness.
3987 (alsa_choose_format): Remove unused local var.
3988 (wav_play): Initialize a variable to 0, to prevent undefined
3989 behavior (Bug#8278).
3991 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3993 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3995 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3996 clobbering (Bug#8298).
3997 * sysdep.c (sys_subshell): Likewise.
3998 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4000 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4001 This should get cleaned up, so that child_setup has the
4002 same signature on all platforms.
4004 * callproc.c (call_process_cleanup): Now static.
4005 (relocate_fd): Rename locals to avoid shadowing.
4007 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4009 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4010 not to be necessary, and produces flickering.
4012 2011-03-20 Glenn Morris <rgm@gnu.org>
4014 * config.in: Remove file.
4016 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4018 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4019 are now in src/globals.h.
4020 (syms_of_minibuf): Remove spurious & from previous change.
4022 2011-03-20 Leo <sdl.web@gmail.com>
4024 * minibuf.c (completing-read-function): New variable.
4025 (completing-read-default): Rename from completing-read.
4026 (completing-read): Call completing-read-function.
4028 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4030 * xfaces.c (Fx_load_color_file):
4031 Read color file from absolute filename (bug#8250).
4033 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4035 * makefile.w32-in: Update dependencies.
4037 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4039 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4041 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4043 Fix more problems found by GCC 4.5.2's static checks.
4045 * process.c (make_serial_process_unwind, send_process_trap):
4046 (sigchld_handler): Now static.
4048 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4049 That way, the code declares only the vars that it needs.
4050 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4051 * s/cygwin.h (PTY_ITERATION): Likewise.
4052 * s/darwin.h (PTY_ITERATION): Likewise.
4053 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4055 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4056 * process.c (allocate_pty): Don't declare stb unless it's needed.
4058 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4059 (CONSTANTLIM): Remove; unused.
4060 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4061 Define only if needed.
4063 * unexelf.c (unexec): Name an expression,
4064 to avoid gcc -Wbad-function-cast warning.
4065 Use a different way to cause a compilation error if anyone uses
4066 n rather than nn, a way that does not involve shadowing.
4067 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4069 * deps.mk (unexalpha.o): Remove; unused.
4071 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4072 * unexec.h: New file.
4073 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4074 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4076 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4077 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4078 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4079 Change as necessary to match prototype in unexec.h.
4081 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4083 (back_comment, skip_chars): Mark vars as initialized.
4085 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4086 Rename locals to avoid shadowing.
4088 * lread.c (read1): Rewrite so as not to use empty "else".
4089 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4091 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4093 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4094 warning when compiling print.c.
4096 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4097 instead of using an uninitialized var.
4098 (font_sort_entities): Mark var as initialized.
4100 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4102 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4103 pointers to constants.
4104 (font_parse_fcname): Remove unused vars.
4105 (font_delete_unmatched): Now static.
4106 (font_get_spec): Remove; unused.
4107 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4108 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4109 Rename or move locals to avoid shadowing.
4111 * fns.c (require_nesting_list, require_unwind): Now static.
4112 (Ffillarray): Rename locals to avoid shadowing.
4114 * floatfns.c (domain_error2): Define only if needed.
4115 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4117 * alloc.c (mark_backtrace): Move decl from here ...
4118 * lisp.h: ... to here, so that it can be checked.
4120 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4121 (Fdefvar): Rewrite so as not to use empty "else".
4122 (lisp_indirect_variable): Name an expression,
4123 to avoid gcc -Wbad-function-cast warning.
4124 (Fdefvar): Rename locals to avoid shadowing.
4126 * callint.c (quotify_arg, quotify_args): Now static.
4127 (Fcall_interactively): Rename locals to avoid shadowing.
4128 Use const pointer when appropriate.
4130 * lisp.h (get_system_name, get_operating_system_release):
4131 Move decls here, to check interfaces.
4132 * process.c (get_operating_system_release): Move decl to lisp.h.
4133 * xrdb.c (get_system_name): Likewise.
4134 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4135 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4136 some of which prompt warnings from gcc -Wbad-function-cast.
4137 (Fformat_time_string, Fencode_time, Finsert_char):
4138 (Ftranslate_region_internal, Fformat):
4139 Rename or remove local vars to avoid shadowing.
4140 (Ftranslate_region_internal): Mark var as initialized.
4142 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4145 * lisp.h (eassert): Check that the argument compiles, even if
4146 ENABLE_CHECKING is not defined.
4148 * data.c (Findirect_variable): Name an expression, to avoid
4149 gcc -Wbad-function-cast warning.
4150 (default_value, arithcompare, arith_driver, arith_error): Now static.
4151 (store_symval_forwarding): Rename local to avoid shadowing.
4152 (Fmake_variable_buffer_local, Fmake_local_variable):
4153 Mark variables as initialized.
4154 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4156 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4157 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4158 Rename locals to avoid shadowing.
4159 (mark_stack): Move local variables into the #ifdef region where
4161 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4162 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4164 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4165 (GC_STRING_CHARS): Remove; not used.
4166 (Fmemory_limit): Cast sbrk's returned value to char *.
4168 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4169 avoids undefined behavior in theory.
4171 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4173 Use functions, not macros, for up- and down-casing (Bug#8254).
4174 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4175 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4176 to use the following functions instead of these macros.
4177 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4178 EMACS_INT, since callers assume the returned value fits in int.
4179 (upcase1): Likewise, for UPCASE_TABLE.
4180 (uppercasep, lowercasep, upcase): New static inline functions.
4181 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4182 the race-condition problem in the old DOWNCASE.
4184 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4185 Rename locals to avoid shadowing.
4186 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4187 (regex_compile, re_search_2, re_match_2_internal):
4188 Remove unused local vars.
4189 (FREE_VAR): Rewrite so as not to use empty "else",
4190 which gcc can warn about.
4191 (regex_compile, re_match_2_internal): Mark locals as initialized.
4192 (RETALLOC_IF): Define only if needed.
4193 (WORDCHAR_P): Likewise. This one is never needed, but is used
4194 only in a comment talking about a compiler bug, so put inside
4195 the #if 0 of that comment.
4196 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4197 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4200 * search.c (boyer_moore): Rename locals to avoid shadowing.
4201 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4202 (PREV_CHAR_BOUNDARY): Likewise.
4204 * search.c (simple_search): Remove unused var.
4206 * dired.c (compile_pattern): Move decl from here ...
4207 * lisp.h: ... to here, so that it can be checked.
4208 (struct re_registers): New forward decl.
4210 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4212 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4214 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4215 Rename locals to avoid shadowing.
4216 (Fvertical_motion): Mark locals as initialized.
4218 * casefiddle.c (casify_object, casify_region): Now static.
4219 (casify_region): Mark local as initialized.
4221 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4223 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4224 New macros, so that the caller can use some names other than
4225 gcpro1, gcpro2, etc.
4226 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4228 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4229 argument, for consistency with GCPRO2_VAR, etc: it is now the
4230 prefix of the variable, not the variable itself. All uses
4232 * dired.c (directory_files_internal, file_name_completion):
4233 Rename locals to avoid shadowing.
4235 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4236 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4237 dired.c's scmp function, had undefined behavior.
4238 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4239 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4240 * buffer.h: ... to here, because these macros use current_buffer,
4241 and the new implementation with inline functions needs to have
4242 current_buffer in scope now, rather than later when the macros
4244 (downcase, upcase1): New static inline functions.
4245 (DOWNCASE, UPCASE1): Reimplement using these functions.
4246 This avoids undefined behavior in expressions like
4247 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4248 from race conditions in accessing the global variables
4249 case_temp1 and case_temp2.
4250 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4251 * lisp.h (case_temp1, case_temp2): Remove their decls.
4252 * character.h (ASCII_CHAR_P): Move from here ...
4253 * lisp.h: ... to here, so that the inline functions mentioned
4256 * dired.c (directory_files_internal_unwind): Now static.
4258 * fileio.c (file_name_as_directory, directory_file_name):
4259 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4261 (file_name_as_directory): Use const pointers when appropriate.
4262 (Fexpand_file_name): Likewise. In particular, newdir might
4263 point at constant storage, so make it a const pointer.
4264 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4265 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4267 (Fset_file_times, Finsert_file_contents, auto_save_error):
4268 Rename locals to avoid shadowing.
4270 * minibuf.c (choose_minibuf_frame_1): Now static.
4271 (Ftry_completion, Fall_completions): Rename or remove locals
4274 * marker.c (bytepos_to_charpos): Remove; unused.
4276 * lisp.h (verify_bytepos, count_markers): New decls,
4277 so that gcc does not warn that these functions aren't declared.
4279 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4280 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4281 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4282 (copy_text): Remove unused local var.
4284 * filelock.c (within_one_second): Now static.
4285 (lock_file_1): Rename local to avoid shadowing.
4287 * buffer.c (fix_overlays_before): Mark locals as initialized.
4288 (fix_start_end_in_overlays): Likewise. This function should be
4289 simplified by using pointers-to-pointers, but that's a different
4291 (switch_to_buffer_1): Now static.
4292 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4293 (report_overlay_modification): Rename locals to avoid shadowing.
4295 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4296 Fix pointer signedness issue.
4297 (sys_subshell): Mark local as volatile if checking for lint,
4298 to suppress a gcc -Wclobbered warning that does not seem to be right.
4299 (MAXPATHLEN): Define only if needed.
4301 * process.c (serial_open, serial_configure): Move decls from here ...
4302 * systty.h: ... to here, so that they can be checked.
4304 * fns.c (get_random, seed_random): Move extern decls from here ...
4305 * lisp.h: ... to here, so that they can be checked.
4307 * sysdep.c (reset_io): Now static.
4308 (wait_for_termination_signal): Remove; unused.
4310 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4311 (copy_keymap_item, append_key, push_text_char_description):
4313 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4314 (DENSE_TABLE_SIZE): Remove; unused.
4315 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4316 (describe_map_tree):
4317 Rename locals to avoid shadowing.
4319 * keyboard.c: Declare functions static if they are not used elsewhere.
4320 (echo_char, echo_dash, cmd_error, top_level_2):
4321 (poll_for_input, handle_async_input): Now static.
4322 (read_char, kbd_buffer_get_event, make_lispy_position):
4323 (make_lispy_event, make_lispy_movement, apply_modifiers):
4324 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4325 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4326 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4327 (read_key_sequence, read_char): Mark locals as initialized.
4328 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4330 * keyboard.h (make_ctrl_char): New decl.
4331 (mark_kboards): Move decl here ...
4332 * alloc.c (mark_kboards): ... from here.
4334 * lisp.h (force_auto_save_soon): New decl.
4336 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4337 (DEFINE_DUMMY_FUNCTION): New macro.
4338 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4340 (main): Add casts to avoid warnings
4341 if GCC considers string literals to be constants.
4343 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4345 * dbusbind.c: Pointer signedness fixes.
4346 (xd_signature, xd_append_arg, xd_initialize):
4347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4348 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4349 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4350 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4352 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4353 if GCC considers string literals to be constants.
4354 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4356 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4358 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4359 (print_preprocess, print_object): New macro to fix last change.
4361 * print.c (print_preprocess): Don't forget font objects.
4363 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4365 * emacs.c (USAGE3): Doc fixes.
4367 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4369 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4372 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4374 * lisp.h (VWindow_system, Qfile_name_history):
4375 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4376 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4377 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4379 * w32select.c: Don't #include "keyboard.h".
4380 (run_protected): Add extern declaration for waiting_for_input.
4382 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4383 * w32console.c (detect_input_pending, read_input_pending)
4384 (encode_terminal_code):
4385 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4386 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4387 (w32_system_caret_y, Qfile_name_history):
4388 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4389 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4390 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4391 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4392 * w32proc.c (Qlocal, report_file_error):
4393 * w32term.c (Vwindow_system, updating_frame):
4394 * w32uniscribe.c (initialized, uniscribe_font_driver):
4395 Remove unneeded extern declarations.
4397 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4399 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4401 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4403 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4404 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4405 These macros can no longer be used for assignment.
4407 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4408 Assign struct members directly, instead of using BUF_BEGV etc.
4409 (record_buffer_markers, fetch_buffer_markers): New functions for
4410 recording and fetching special buffer markers.
4411 (set_buffer_internal_1, set_buffer_temp): Use them.
4413 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4415 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4417 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4418 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4420 * xdisp.c (hscroll_window_tree):
4421 (reconsider_clip_changes): Use PT instead of BUF_PT.
4423 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4425 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4426 $(EMACS_ROOT)/lib/intprops.h.
4428 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4430 Fix more problems found by GCC 4.5.2's static checks.
4432 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4433 to unsigned char * to avoid compiler diagnostic.
4434 (xg_free_frame_widgets): Make it clear that a local variable is
4435 needed only if USE_GTK_TOOLTIP.
4436 (gdk_window_get_screen): Make it clear that this macro is needed
4437 only if USE_GTK_TOOLTIP.
4438 (int_gtk_range_get_value): New function, which avoids a diagnostic
4439 from gcc -Wbad-function-cast.
4440 (xg_set_toolkit_scroll_bar_thumb): Use it.
4441 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4442 diagnostic from gcc -Wbad-function-cast.
4443 (get_utf8_string, xg_get_file_with_chooser):
4444 Rename locals to avoid shadowing.
4445 (create_dialog): Move locals to avoid shadowing.
4447 * xgselect.c (xg_select): Remove unused var.
4449 * image.c (four_corners_best): Mark locals as initialized.
4450 (gif_load): Initialize transparent_p to zero (Bug#8238).
4451 Mark another local as initialized.
4452 (my_png_error, my_error_exit): Mark with NO_RETURN.
4454 * image.c (clear_image_cache): Now static.
4455 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4456 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4457 (x_edge_detection): Remove unnecessary cast that
4458 gcc -Wbad-function-cast diagnoses.
4459 (gif_load): Fix pointer signedness.
4460 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4461 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4463 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4465 Improve quality of tests for time stamp overflow.
4466 For example, without this patch (encode-time 0 0 0 1 1
4467 1152921504606846976) returns the obviously-bogus value (-948597
4468 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4469 reports time overflow. See
4470 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4471 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4472 * editfns.c: Include limits.h and intprops.h.
4473 (TIME_T_MIN, TIME_T_MAX): New macros.
4474 (time_overflow): Move earlier, to before first use.
4475 (hi_time, lo_time): New functions, for an accurate test for
4477 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4478 (Fget_internal_run_time): Don't assume time_t fits in int.
4479 (make_time): Use list2 instead of Fcons twice.
4480 (Fdecode_time): More accurate test for out-of-range times.
4481 (check_tm_member): New function.
4482 (Fencode_time): Use it, to test for out-of-range times.
4483 (lisp_time_argument): Don't rely on undefined left-shift and
4484 right-shift behavior when checking for time stamp overflow.
4486 * editfns.c (time_overflow): New function, refactoring common code.
4487 (Fformat_time_string, Fdecode_time, Fencode_time):
4488 (Fcurrent_time_string): Use it.
4490 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4491 * dired.c (make_time): Move to ...
4492 * editfns.c (make_time): ... here.
4493 * systime.h: Note the move.
4495 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4497 * fringe.c (update_window_fringes): Remove unused variables.
4499 * unexmacosx.c (copy_data_segment): Also copy __got section.
4502 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4504 * termcap.c [MSDOS]: Include "msdos.h".
4505 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4506 Constify `char *' arguments and their references according to
4507 prototypes in tparam.h.
4509 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4511 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4512 Adapt all references accordingly.
4514 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4516 2011-03-11 Tom Tromey <tromey@redhat.com>
4518 * buffer.c (syms_of_buffer): Remove obsolete comment.
4520 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4522 * termhooks.h (encode_terminal_code): Declare prototype.
4524 * msdos.c (encode_terminal_code): Don't declare prototype.
4526 * term.c (encode_terminal_code): Now external again, used by
4527 w32console.c and msdos.c.
4529 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4530 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4532 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4534 Fix some minor problems found by GCC 4.5.2's static checks.
4536 * fringe.c (update_window_fringes): Mark locals as initialized
4538 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4540 * alloc.c (mark_fringe_data): Move decl from here ...
4541 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4542 to check its interface.
4543 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4545 * fontset.c (free_realized_fontset): Now static.
4546 (Fset_fontset_font): Rename local to avoid shadowing.
4547 (fontset_font): Mark local as initialized.
4548 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4550 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4552 * xselect.c (x_disown_buffer_selections): Remove; not used.
4553 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4554 (x_own_selection, Fx_disown_selection_internal): Rename locals
4556 (x_handle_dnd_message): Remove local to avoid shadowing.
4558 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4559 so that the caller can use some name other than gcpro1.
4560 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4561 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4562 (Fx_backspace_delete_keys_p):
4563 Use them to avoid shadowing, and rename vars to avoid shadowing.
4564 (x_decode_color, x_set_name, x_window): Now static.
4565 (Fx_create_frame): Add braces to silence GCC warning.
4566 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4567 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4568 Remove unused locals.
4569 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4570 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4571 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4574 * xterm.h (x_mouse_leave): New decl.
4576 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4577 Remove unused functions.
4578 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4579 (x_calc_absolute_position): Now static.
4580 (XTread_socket): Don't define label "out" unless it's used.
4581 Don't declare local "event" unless it's used.
4582 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4583 unless they are used.
4584 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4585 (x_fatal_error_signal): Remove; not used.
4586 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4587 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4588 (x_error_catcher, x_connection_closed, x_error_handler):
4589 (x_error_quitter, xembed_send_message, x_iconify_frame):
4590 (my_log_handler): Rename locals to avoid shadowing.
4591 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4592 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4594 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4595 Rename or move locals to avoid shadowing.
4596 (tty_defined_color, merge_face_heights): Now static.
4597 (free_realized_faces_for_fontset): Remove; not used.
4598 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4599 does not deduce is never used uninitialized.
4600 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4601 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4603 * terminal.c (store_terminal_param): Now static.
4605 * xmenu.c (menu_highlight_callback): Now static.
4606 (set_frame_menubar): Remove unused local.
4607 (xmenu_show): Rename parameter to avoid shadowing.
4608 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4609 since they might point to immutable storage.
4610 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4611 since it's unused otherwise.
4613 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4614 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4615 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4616 avoids a gcc -Wuninitialized diagnostic.
4617 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4618 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4619 does not deduce are never used uninitialized.
4621 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4623 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4624 * window.c (window_loop, size_window):
4625 (run_window_configuration_change_hook, enlarge_window): Likewise.
4627 * window.c (display_buffer): Now static.
4628 (size_window): Mark variables that gcc -Wuninitialized
4629 does not deduce are never used uninitialized.
4630 * window.h (check_all_windows): New decl, to forestall
4631 gcc -Wmissing-prototypes diagnostic.
4632 * dispextern.h (bidi_dump_cached_states): Likewise.
4634 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4636 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4638 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4639 and to avoid gcc -Wuninitialized warning.
4640 (load_charset_map): Mark variables that gcc -Wuninitialized
4641 does not deduce are never used uninitialized.
4642 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4644 * coding.c (coding_set_source, coding_set_destination):
4645 Use "else { /* comment */ }" rather than "else /* comment */;"
4646 for clarity, and to avoid gcc -Wempty-body warning.
4647 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4648 a block, when the outer 'i' will do.
4649 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4650 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4652 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4653 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4654 Rename locals to avoid shadowing.
4655 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4656 * coding.c (emacs_mule_char, encode_invocation_designation):
4657 Now static, since they're not used elsewhere.
4658 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4659 (decode_coding_object, encode_coding_object, detect_coding_system):
4660 (decode_coding_emacs_mule): Mark variables that gcc
4661 -Wuninitialized does not deduce are never used uninitialized.
4662 (detect_coding_iso_2022): Initialize a local variable that might
4663 be used uninitialized. Leave a FIXME because it's not clear that
4664 this initialization is needed. (Bug#8211)
4665 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4666 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4667 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4668 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4669 Remove unused macros.
4671 * category.c (hash_get_category_set): Remove unused local var.
4672 (copy_category_table): Now static, since it's not used elsewhere.
4673 * character.c (string_count_byte8): Likewise.
4675 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4676 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4678 * chartab.c (copy_sub_char_table): Now static, since it's not used
4680 (sub_char_table_ref_and_range, char_table_ref_and_range):
4681 Rename locals to avoid shadowing.
4682 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4684 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4685 (BIDI_BOB): Remove unused macro.
4687 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4688 deduce are never used uninitialized.
4689 * term.c (encode_terminal_code): Likewise.
4691 * term.c (encode_terminal_code): Now static. Remove unused local.
4693 * tparam.h: New file.
4694 * term.c, tparam.h: Include it.
4695 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4696 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4697 Move these decls to tparam.h, and make them agree with what
4698 is actually in tparam.c. The previous trick of using incompatible
4699 decls in different modules does not conform to the C standard.
4700 All callers of tparam changed to use tparam's actual API.
4701 * tparam.c (tparam1, tparam, tgoto):
4702 Use const pointers where appropriate.
4704 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4705 * cm.h (struct cm): Likewise.
4706 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4707 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4708 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4709 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4710 (turn_on_face, init_tty): Likewise.
4711 * termchar.h (struct tty_display_info): Likewise.
4713 * term.c (term_mouse_position): Rename local to avoid shadowing.
4715 * alloc.c (mark_ttys): Move decl from here ...
4716 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4718 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4720 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4722 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4724 * search.c (compile_pattern_1): Remove argument regp, unused since
4725 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4726 (compile_pattern): Don't pass it.
4728 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4730 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4731 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4733 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4735 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4737 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4738 gdk_window_get_screen, gdk_window_get_geometry,
4739 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4740 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4741 (xg_get_pixbuf_from_pixmap): New function.
4742 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4743 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4744 Call xg_get_pixbuf_from_pixmap instead of
4745 gdk_pixbuf_get_from_drawable.
4746 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4747 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4748 (xg_check_special_colors): Use GtkStyleContext and its functions
4750 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4751 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4752 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4753 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4754 Call gtk_widget_get_preferred_size.
4755 (xg_frame_resized): gdk_window_get_geometry only takes 5
4757 (xg_win_to_widget, xg_event_is_for_menubar):
4758 Call gdk_x11_window_lookup_for_display.
4759 (xg_set_widget_bg): New function.
4760 (delete_cb): New function.
4761 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4762 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4763 (xg_set_background_color): Call xg_set_widget_bg.
4764 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4765 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4766 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4767 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4769 (update_frame_tool_bar): Call gtk_widget_hide.
4770 (xg_initialize): Use GDK_KEY_g.
4772 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4774 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4776 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4777 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4778 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4780 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4782 * w32xfns.c (select_palette): Check success of RealizePalette against
4783 GDI_ERROR, not zero.
4785 See ChangeLog.11 for earlier changes.
4791 Copyright (C) 2011 Free Software Foundation, Inc.
4793 This file is part of GNU Emacs.
4795 GNU Emacs is free software: you can redistribute it and/or modify
4796 it under the terms of the GNU General Public License as published by
4797 the Free Software Foundation, either version 3 of the License, or
4798 (at your option) any later version.
4800 GNU Emacs is distributed in the hope that it will be useful,
4801 but WITHOUT ANY WARRANTY; without even the implied warranty of
4802 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4803 GNU General Public License for more details.
4805 You should have received a copy of the GNU General Public License
4806 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.