1 2011-05-23 Paul Eggert <eggert@cs.ucla.edu>
3 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5 ccl: add integer overflow checks
6 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7 (IN_INT_RANGE): New macros.
8 (ccl_driver): Use them to check for integer overflow when
9 decoding a CCL program. Many of the new checks are whether XINT (x)
10 fits in int; it doesn't always, on 64-bit hosts. The new version
11 doesn't catch all possible integer overflows, but it's an
12 improvement. (Bug#8719)
14 * alloc.c (make_event_array): Use XINT, not XUINT.
15 There's no need for unsigned here.
17 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
18 This follows up to the 2011-05-06 change that substituted uintptr_t
19 for EMACS_INT. This case wasn't caught back then.
21 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
23 Rework Fformat to avoid integer overflow issues.
24 * editfns.c: Include <float.h> unconditionally, as it's everywhere
25 now (part of C89). Include <verify.h>.
26 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
27 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
28 (Fformat): Avoid the prepass trying to compute sizes; it was only
29 approximate and thus did not catch overflow reliably. Instead, walk
30 through the format just once, formatting and computing sizes as we go,
31 checking for integer overflow at every step, and allocating a larger
32 buffer as needed. Keep track separately whether the format is
33 multibyte. Keep only the most-recently calculated precision, rather
34 than them all. Record whether each argument has been converted to
35 string. Use EMACS_INT, not int, for byte and char and arg counts.
36 Support field widths and precisions larger than INT_MAX. Avoid
37 sprintf's undefined behavior with conversion specifications such as %#d
38 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
39 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
40 formatting out-of-range floating point numbers with int
43 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
45 * data.c: Avoid integer truncation in expressions involving floats.
46 * data.c: Include <intprops.h>.
47 (arith_driver): When there's an integer overflow in an expression
48 involving floating point, convert the integers to floating point
49 so that the resulting value does not suffer from catastrophic
50 integer truncation. For example, on a 64-bit host (* 4
51 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
52 Do not rely on undefined behavior after integer overflow.
54 merge count_size_as_multibyte, parse_str_to_multibyte
55 * character.c, character.h (count_size_as_multibyte):
56 Renamed from parse_str_to_multibyte; all uses changed.
57 Check for integer overflow.
58 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
59 since it's now a duplicate of the other. This is more of
60 a character than a buffer op, so better that it's in character.c.
61 * fns.c, print.c: Adjust to above changes.
63 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
65 * gnutls.c: Remove unused macros.
66 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
67 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
68 Remove macros that are defined and never used.
69 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
71 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
73 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
74 (Fx_get_selection_internal): Minor cleanup.
75 (Fx_own_selection_internal): Rename arguments for consistency with
78 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
80 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
82 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
84 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
86 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
88 * dispnew.c (scrolling_window): Don't exclude the case that the
89 last enabled row in the desired matrix touches the bottom boundary.
91 2011-05-21 Glenn Morris <rgm@gnu.org>
93 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
94 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
95 and add some more files.
97 2011-05-20 Eli Zaretskii <eliz@gnu.org>
99 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
100 report_file_error introduced by the change from 2011-05-07.
102 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
104 * systime.h (Time): Define only if emacs is defined.
105 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
106 where the include path doesn't have X11/X.h by default. See
107 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
109 2011-05-20 Kenichi Handa <handa@m17n.org>
111 * composite.c (find_automatic_composition): Fix previous change.
113 2011-05-20 Glenn Morris <rgm@gnu.org>
115 * lisp.mk: New file, split from Makefile.in.
116 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
118 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
120 2011-05-19 Glenn Morris <rgm@gnu.org>
122 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
123 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
124 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
125 (lisp): Set the order to that of loadup.el.
126 (shortlisp): Make it a copy of $lisp.
127 (SOME_MACHINE_LISP): Remove.
128 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
129 Use just $shortlisp, not $SOME_MACHINE_LISP too.
131 2011-05-18 Kenichi Handa <handa@m17n.org>
133 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
134 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
135 (find_automatic_composition): Mostly rewrite for efficiency.
137 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
139 * makefile.w32-in: Update dependencies.
141 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
143 * menu.c: Include limits.h (fixes the MS-Windows build broken by
146 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
148 Fix some integer overflow issues, such as string length overflow.
150 * insdel.c (count_size_as_multibyte): Check for string overflow.
152 * character.c (lisp_string_width): Check for string overflow.
153 Use EMACS_INT, not int, for string indexes and lengths; in
154 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
155 the resulting string length overflows an EMACS_INT; instead,
156 report a string overflow if no precision given. When checking for
157 precision exhaustion, use a check that cannot possibly have
158 integer overflow. (Bug#8675)
159 * character.h (lisp_string_width): Adjust to new signature.
161 * alloc.c (string_overflow): New function.
162 (Fmake_string): Use it. This doesn't change behavior, but saves
163 a few bytes and will simplify future changes.
164 * character.c (string_escape_byte8): Likewise.
165 * lisp.h (string_overflow): New decl.
167 Fixups, following up to the user-interface timestamp change.
168 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
169 for UI timestamps, instead of unsigned long.
170 * msdos.c (mouse_get_pos): Likewise.
171 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
172 * w32gui.h (Time): Define by including "systime.h" rather than by
173 declaring it ourselves. (Bug#8664)
175 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
176 * image.c (clear_image_cache): Likewise.
178 * term.c (term_mouse_position): Don't assume time_t wraparound.
180 Be more systematic about user-interface timestamps.
181 Before, the code sometimes used 'Time', sometimes 'unsigned long',
182 and sometimes 'EMACS_UINT', to represent these timestamps. This
183 change causes it to use 'Time' uniformly, as that's what X uses.
184 This makes the code easier to follow, and makes it easier to catch
185 integer overflow bugs such as Bug#8664.
186 * frame.c (Fmouse_position, Fmouse_pixel_position):
187 Use Time, not unsigned long, for user-interface timestamps.
188 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
189 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
190 * keyboard.h (last_event_timestamp): Likewise.
191 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
192 * menu.h (xmenu_show): Likewise.
193 * term.c (term_mouse_position): Likewise.
194 * termhooks.h (struct input_event.timestamp): Likewise.
195 (struct terminal.mouse_position_hook): Likewise.
196 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
197 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
198 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
199 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
201 * menu.h, termhooks.h: Include "systime.h", for Time.
203 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
204 Don't assume that the difference between two unsigned long values
205 can fit into an integer. At this point, we know button_down_time
206 <= event->timestamp, so the difference must be nonnegative, so
207 there's no need to cast the result if double-click-time is
208 nonnegative, as it should be; check that it's nonnegative, just in
209 case. This bug is triggered when events are more than 2**31 ms
210 apart (about 25 days). (Bug#8664)
212 * xselect.c (last_event_timestamp): Remove duplicate decl.
213 (x_own_selection): Remove needless cast to unsigned long.
215 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
216 that always fit in int. Use a sentinel instead of a counter, to
217 avoid a temp and to allay GCC's concerns about possible int overflow.
218 * frame.h (struct frame): Use int for menu_bar_items_used
219 instead of EMACS_INT, since it always fits in int.
221 * menu.c (grow_menu_items): Check for int overflow.
223 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
225 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
226 Before, the code was not consistent. These values cannot exceed
227 2**31 - 1 so there's no need to make them unsigned.
228 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
229 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
230 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
232 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
234 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
235 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
236 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
237 presumably because the widths might not match.
239 * window.c (size_window): Avoid needless test at loop start.
241 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
243 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
245 2011-05-12 Drew Adams <drew.adams@oracle.com>
247 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
249 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
251 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
252 `width' to `bar_area_x' and `bar_area_width', respectively.
253 (x_scroll_run): Take account of fringe background extension.
255 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
256 Rename local vars `left' and `width' to `bar_area_x' and
257 `bar_area_width', respectively.
258 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
259 background extension.
261 2011-05-10 Jim Meyering <meyering@redhat.com>
263 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
265 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
267 * image.c (Finit_image_library): Return t for built-in image types,
268 like pbm and xbm. (Bug#8640)
270 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
272 * w32menu.c (set_frame_menubar): Fix submenu allocation.
274 2011-05-07 Eli Zaretskii <eliz@gnu.org>
276 * w32console.c (Fset_screen_color): Doc fix.
277 (Fget_screen_color): New function.
278 (syms_of_ntterm): Defsubr it.
280 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
281 unlink the temporary file if Fcall_process didn't create it in the
283 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
284 child process will be redirected to a file specified with `:file'.
285 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
286 cue to call_process_cleanup not to close that handle.
288 2011-05-07 Ben Key <bkey76@gmail.com>
290 * makefile.w32-in: The bootstrap-temacs rule now makes use of
291 one of two shell specific rules, either bootstrap-temacs-CMD or
292 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
293 to the previous implementation of the bootstrap-temacs rule.
294 The bootstrap-temacs-CMD rule is similar to the previous
295 implementation of the bootstrap-temacs rule except that it
296 makes use of the ESC_CFLAGS variable instead of the CFLAGS
299 These changes, along with some changes to nt/configure.bat,
300 nt/gmake.defs, and nt/nmake.defs, are required to extend my
301 earlier fix to add support for --cflags and --ldflags options
302 that include quotes so that it works whether make uses cmd or
305 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
307 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
308 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
310 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
311 a string. Handle both cases.
312 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
313 (Fdbus_register_method): Use Qinvalid_function.
315 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
317 * makefile.w32-in: Update dependencies.
318 (LISP_H): Add inttypes.h and stdin.h.
319 (PROCESS_H): Add unistd.h.
321 2011-05-06 Eli Zaretskii <eliz@gnu.org>
323 * lread.c: Include limits.h (fixes the MS-Windows build broken by
324 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
326 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
328 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
330 * term.c (vfatal): Remove stray call to va_end.
331 It's not needed and the C Standard doesn't allow it here anyway.
333 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
334 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
336 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
339 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
341 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
343 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
345 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
347 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
349 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
350 * charset.c (Fdefine_charset_internal): Don't initialize
351 charset.code_space[15]. The value was garbage, on hosts with
352 32-bit int (Bug#8600).
354 * lread.c (read_integer): Be more consistent with string-to-number.
355 Use string_to_number to do the actual conversion; this avoids
356 rounding errors and fixes some other screwups. Without this fix,
357 for example, #x1fffffffffffffff was misread as -2305843009213693952.
358 (digit_to_number): Move earlier, for benefit of read_integer.
359 Return -1 if the digit is out of range for the base, -2 if it is
360 not a digit in any supported base. (Bug#8602)
362 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
364 * dispnew.c (scrolling_window): Return 1 if we scrolled,
365 to match comment at start of function. This also removes a
366 GCC warning about overflow in a 32+64-bit port.
368 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
370 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
371 Reported by Stefan Monnier in
372 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
373 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
374 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
376 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
377 (EMACS_UINTPTR): Likewise, with uintptr_t.
379 * lisp.h: Prefer 64-bit EMACS_INT if available.
380 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
381 on 32-bit hosts that have 64-bit int, so that they can access
383 However, temporarily disable this change unless the temporary
384 symbol WIDE_EMACS_INT is defined.
386 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
388 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
389 This removes an assumption that EMACS_INT and long are the same
390 width as pointers. The assumption is true for Emacs porting targets
391 now, but we want to make other targets possible.
392 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
393 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
394 In the rest of the code, change types of integers that hold casted
395 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
396 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
397 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
398 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
399 No need to cast type when ORing.
400 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
401 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
402 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
403 assume EMACS_INT is the same width as char *.
404 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
405 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
406 Remove no-longer-needed casts.
407 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
408 (xg_tool_bar_help_callback, xg_make_tool_item):
409 Use EMACS_INTPTR to hold an integer
410 that will be cast to void *; this can avoid a GCC warning
411 if EMACS_INT is not the same width as void *.
412 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
413 * xdisp.c (display_echo_area_1, resize_mini_window_1):
414 (current_message_1, set_message_1):
415 Use a local to convert to proper width without a cast.
416 * xmenu.c (dialog_selection_callback): Likewise.
418 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
419 Also, don't assume VALBITS / RAND_BITS is less than 5,
420 and don't rely on undefined behavior when shifting a 1 left into
422 * lisp.h (get_random): Change signature to match.
424 * lread.c (hash_string): Use size_t, not int, for hash computation.
425 Normally we prefer signed values; but hashing is special, because
426 it's better to use unsigned division on hash table sizes so that
427 the remainder is nonnegative. Also, size_t is the natural width
428 for hashing into memory. The previous code used 'int', which doesn't
429 retain enough info to hash well into very large tables.
430 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
432 * dbusbind.c: Don't possibly lose pointer info when converting.
433 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
434 Use XPNTR rather than XHASH, so that the high-order bits of
435 the pointer aren't lost when converting through void *.
437 * eval.c (Fautoload): Don't double-shift a pointer.
439 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
441 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
443 * gnutls.c (DEF_GNUTLS_FN):
444 * image.c (DEF_IMGLIB_FN): Make function pointers static.
446 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
448 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
451 2011-05-05 Eli Zaretskii <eliz@gnu.org>
453 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
454 New version that can reserve upto 2GB of heap space.
456 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
458 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
460 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
462 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
463 `gnutls_certificate_set_x509_key_file'.
465 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
467 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
470 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
472 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
473 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
474 Remove unused parameter `fildes'.
475 * process.c (read_process_output, send_process): Don't pass it.
477 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
479 Fix previous change: the library cache is defined in w32.c.
480 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
481 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
483 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
485 Implement dynamic loading of GnuTLS on Windows.
487 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
488 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
492 * gnutls.c (Qgnutls_dll): Define.
493 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
494 (gnutls_*): Declare function pointers.
495 (init_gnutls_functions): New function to initialize function pointers.
496 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
497 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
498 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
499 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
500 (emacs_gnutls_write, emacs_gnutls_read)
501 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
502 (Fgnutls_available_p): New function.
503 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
504 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
505 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
507 * image.c: Include w32.h.
508 (Vimage_type_cache): Delete.
509 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
510 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
511 (w32_delayed_load): Move to w32.c.
513 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
515 * w32.c (QCloaded_from, Vlibrary_cache): Define.
516 (w32_delayed_load): Move from image.c. When loading a library, record
517 its filename in the :loaded-from property of the library id.
518 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
519 Initialize and staticpro them.
520 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
522 * process.c: Include lisp.h before w32.h, not after.
523 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
524 instead of gnutls_record_check_pending.
526 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
528 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
530 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
531 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
534 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
536 * xterm.c (x_set_frame_alpha): Do not set property on anything
537 else than FRAME_X_OUTER_WINDOW (Bug#8608).
539 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
541 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
543 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
545 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
546 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
547 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
548 (gnutls_global_initialized, Qgnutls_bootprop_priority)
549 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
550 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
551 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
552 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
553 (Qgnutls_bootprop_callbacks_verify): Make static.
555 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
557 * callproc.c: Indentation fixup.
559 * sysdep.c (wait_for_termination_1): Make static.
560 (wait_for_termination, interruptible_wait_for_termination):
561 Move after wait_for_termination_1.
563 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
565 * sysdep.c (interruptible_wait_for_termination): New function
566 which is like wait_for_termination, but allows keyboard
569 * callproc.c (Fcall_process): Add (:file "file") as an option for
571 (Fcall_process_region): Ditto.
573 2011-04-30 Eli Zaretskii <eliz@gnu.org>
575 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
576 rather than `XVECTOR (FOO)->size'.
578 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
579 inttypes.h, as a gnulib replacement is used if it not available in
582 2011-04-21 Eli Zaretskii <eliz@gnu.org>
584 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
585 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
586 of MOST_POSITIVE_FIXNUM. (Bug#8528)
588 * coding.c (coding_alloc_by_realloc): Error out if destination
589 will grow beyond MOST_POSITIVE_FIXNUM.
590 (decode_coding_emacs_mule): Abort if there isn't enough place in
591 charbuf for the composition carryover bytes. Reserve an extra
592 space for up to 2 characters produced in a loop.
593 (decode_coding_iso_2022): Abort if there isn't enough place in
594 charbuf for the composition carryover bytes.
596 2011-04-21 Eli Zaretskii <eliz@gnu.org>
598 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
599 aborting when %lld or %lll format is passed.
600 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
601 %llo or %llx format is passed. (Bug#8545)
603 * window.c (window_scroll_line_based): Use a marker instead of
604 simple variables to record original value of point. (Bug#7952)
606 * doprnt.c (doprnt): Fix the case where a multibyte sequence
607 produced by %s or %c overflows available buffer space. (Bug#8545)
609 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
611 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
612 (SIZE_MAX): Move defn after all includes, as they might #define it.
614 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
616 * w32.c (init_environment): Warn about defaulting HOME to C:\.
618 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
620 * keyboard.c (Qdelayed_warnings_hook): Define.
621 (command_loop_1): Run `delayed-warnings-hook'
622 if Vdelayed_warnings_list is non-nil.
623 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
624 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
626 2011-04-28 Eli Zaretskii <eliz@gnu.org>
628 * doprnt.c (doprnt): Don't return value smaller than the buffer
629 size if the message was truncated. (Bug#8545).
631 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
633 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
634 (Fx_window_property): #if-0 the whole functions, not just the bodies.
636 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
638 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
640 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
642 * makefile.w32-in: Update dependencies.
644 2011-04-27 Eli Zaretskii <eliz@gnu.org>
646 Improve `doprnt' and its usage. (Bug#8545)
647 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
648 `format_end'. Remove support for %l as a conversion specifier.
649 Don't use xrealloc. Improve diagnostics when the %l size modifier
650 is used. Update the commentary.
652 * eval.c (verror): Simplify calculation of size_t.
654 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
657 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
659 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
662 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
664 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
665 This makes this file independent of the recent pseudovector change.
667 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
669 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
671 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
672 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
674 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
676 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
677 GCC 4.6.0 optimizes based on type-based alias analysis.
678 For example, if b is of type struct buffer * and v of type struct
679 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
680 != &v->size, and therefore "v->size = 1; b->size = 2; return
681 v->size;" must therefore return 1. This assumption is incorrect
682 for Emacs, since it type-puns struct Lisp_Vector * with many other
683 types. To fix this problem, this patch adds a new type struct
684 vectorlike_header that documents the constraints on layout of vectors
685 and pseudovectors, and helps optimizing compilers not get fooled
686 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
687 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
688 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
690 (XSETPVECTYPE): Rewrite in terms of new macro.
691 (XSETPVECTYPESIZE): New macro, specifying both type and size.
692 This is a bit clearer, and further avoids the possibility of
693 undesirable aliasing.
694 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
695 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
696 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
697 since Lisp_Subr is a special case (no "next" field).
698 (ASIZE): Now uses header.size rather than size.
699 All previous uses of XVECTOR (foo)->size replaced to use this macro,
700 to avoid the hassle of writing XVECTOR (foo)->header.size.
701 (struct vectorlike_header): New type.
702 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
703 object, to help avoid aliasing.
704 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
705 (SUBRP): Likewise, since Lisp_Subr is a special case.
706 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
707 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
708 (struct Lisp_Hash_Table): Combine first two members into a single
709 struct vectorlike_header member. All uses of "size" and "next" members
710 changed to be "header.size" and "header.next".
711 * buffer.h (struct buffer): Likewise.
712 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
713 * frame.h (struct frame): Likewise.
714 * process.h (struct Lisp_Process): Likewise.
715 * termhooks.h (struct terminal): Likewise.
716 * window.c (struct save_window_data, struct saved_window): Likewise.
717 * window.h (struct window): Likewise.
718 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
719 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
720 * buffer.c (init_buffer_once): Likewise.
721 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
723 * process.c (Fformat_network_address): Use local var for size,
726 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
728 Make the Lisp reader and string-to-float more consistent (Bug#8525)
729 * data.c (atof): Remove decl; no longer used or needed.
730 (digit_to_number): Move to lread.c.
731 (Fstring_to_number): Use new string_to_number function, to be
732 consistent with how the Lisp reader treats infinities and NaNs.
733 Do not assume that floating-point numbers represent EMACS_INT
734 without losing information; this is not true on most 64-bit hosts.
735 Avoid double-rounding errors, by insisting on integers when
736 parsing non-base-10 numbers, as the documentation specifies.
737 * lisp.h (string_to_number): New decl, replacing ...
738 (isfloat_string): Remove.
739 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
740 (read1): Do not accept +. and -. as integers; this
741 appears to have been a coding error. Similarly, do not accept
742 strings like +-1e0 as floating point numbers. Do not report
743 overflow for integer overflows unless the base is not 10 which
744 means we have no simple and reliable way to continue.
745 Break out the floating-point parsing into a new
746 function string_to_number, so that Fstring_to_number parses
747 floating point numbers consistently with the Lisp reader.
748 (digit_to_number): Move here from data.c. Make it static inline.
749 (E_CHAR, EXP_INT): Remove, replacing with ...
750 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
751 (string_to_number): New function, replacing isfloat_string.
752 This function checks for valid syntax and produces the resulting
753 Lisp float number too. Rework it so that string-to-number
754 no longer mishandles examples like "1.0e+". Use strtoumax,
755 so that overflow for non-base-10 numbers is reported only when
756 there's no portable and simple way to convert to floating point.
758 * textprop.c (set_text_properties_1): Rewrite for clarity,
759 and to avoid GCC warning about integer overflow.
761 * intervals.h (struct interval): Use EMACS_INT for members
762 where EMACS_UINT might cause problems. See
763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
764 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
765 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
767 (offset_intervals): Tell GCC not to worry about length overflow
768 when negating a negative length.
770 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
771 (overrun_check_free): Likewise.
773 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
774 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
777 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
778 (gnutls_make_error): Rename local to avoid shadowing.
779 (gnutls_emacs_global_deinit): ifdef out; not used.
780 (Fgnutls_boot): Use const for pointer to readonly storage.
781 Comment out unused local. Fix pointer signedness problems.
783 * lread.c (openp): Don't stuff size_t into an 'int'.
784 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
785 about possible signed overflow.
787 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
788 (GDK_KEY_g): Don't define if already defined.
789 (xg_prepare_tooltip): Avoid pointer signedness problem.
790 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
792 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
793 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
795 * xfns.c (Fx_window_property): Simplify a bit,
796 to make a bit faster and to avoid GCC 4.6.0 warning.
797 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
799 * fns.c (internal_equal): Don't assume size_t fits in int.
801 * alloc.c (compact_small_strings): Tighten assertion a little.
803 Replace pEd with more-general pI, and fix some printf arg casts.
804 * lisp.h (pI): New macro, generalizing old pEd macro to other
805 conversion specifiers. For example, use "...%"pI"d..." rather
807 (pEd): Remove. All uses replaced with similar uses of pI.
808 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
809 * alloc.c (check_pure_size): Don't overflow by converting size to int.
810 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
811 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
812 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
813 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
814 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
816 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
817 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
818 * print.c (safe_debug_print, print_object): Likewise.
819 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
821 Use pI instead of if-then-else-abort. Use %p to avoid casts,
822 avoiding the 0 flag, which is not portable.
823 * process.c (Fmake_network_process): Use pI to avoid cast.
824 * region-cache.c (pp_cache): Likewise.
825 * xdisp.c (decode_mode_spec): Likewise.
826 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
827 behavior on 64-bit hosts with printf arg.
828 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
829 (x_stop_queuing_selection_requests): Likewise.
830 (x_get_window_property): Don't truncate byte count to an 'int'
833 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
834 here, since it parses constructs like leading '-' and spaces,
835 which are not wanted; and it overflows with large numbers.
836 Instead, simply match F[0-9]+, which is what is wanted anyway.
838 * alloc.c: Remove unportable assumptions about struct layout.
839 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
840 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
841 (allocate_vectorlike, make_pure_vector): Use the new macros,
842 plus offsetof, to remove unportable assumptions about struct layout.
843 These assumptions hold on all porting targets that I know of, but
844 they are not guaranteed, they're easy to remove, and removing them
845 makes further changes easier.
847 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
848 This doesn't fix a bug but makes the code clearer.
849 (string_overrun_cookie): Now const. Use initializers that
850 don't formally overflow signed char, to avoid warnings.
851 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
852 can cause Emacs to crash when string overrun checking is enabled.
853 (allocate_buffer): Don't assume sizeof (struct buffer) is a
854 multiple of sizeof (EMACS_INT); it need not be, if
855 alignof(EMACS_INT) < sizeof (EMACS_INT).
856 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
858 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
860 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
862 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
864 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
865 supposed to be handshaking. (Bug#8556)
866 Reported by Paul Eggert <eggert@cs.ucla.edu>.
868 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
870 * lisp.h (Qdebug): List symbol.
871 * eval.c (Qdebug): Restore global linkage.
872 * keyboard.c (debug-on-event): New variable.
873 (handle_user_signal): Break into debugger when debug-on-event
874 matches the current signal symbol.
876 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
878 * alloc.c (check_sblock, check_string_bytes)
879 (check_string_free_list): Convert to standard C.
881 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
883 * w32.c (emacs_gnutls_push): Fix typo.
885 2011-04-25 Eli Zaretskii <eliz@gnu.org>
887 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
888 "cast to pointer from integer of different size".
890 Improve doprnt and its use in verror. (Bug#8545)
891 * doprnt.c (doprnt): Document the set of format control sequences
892 supported by the function. Use SAFE_ALLOCA instead of always
895 * eval.c (verror): Don't limit the buffer size at size_max-1, that
896 is one byte too soon. Don't use xrealloc; instead xfree and
899 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
901 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
904 * gnutls.c: Renamed global_initialized to
905 gnutls_global_initialized. Added internals for the
906 :verify-hostname-error, :verify-error, and :verify-flags
907 parameters of `gnutls-boot' and documented those parameters in the
908 docstring. Start callback support.
909 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
910 unless a fatal error occured. Call gnutls_alert_send_appropriate
911 on error. Return error code.
912 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
913 (emacs_gnutls_read): Likewise.
914 (Fgnutls_boot): Return handshake error code.
915 (emacs_gnutls_handle_error): New function.
916 (wsaerror_to_errno): Likewise.
918 * w32.h (emacs_gnutls_pull): Add prototype.
919 (emacs_gnutls_push): Likewise.
921 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
922 (emacs_gnutls_push): Likewise.
924 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
926 * process.c (wait_reading_process_output): Check if GnuTLS
927 buffered some data internally if no FDs are set for TLS
930 * makefile.w32-in (OBJ2): Add gnutls.$(O).
931 (LIBS): Link to USER_LIBS.
932 ($(BLD)/gnutls.$(0)): New target.
934 2011-04-24 Eli Zaretskii <eliz@gnu.org>
936 * xdisp.c (handle_single_display_spec): Rename the
937 display_replaced_before_p argument into display_replaced_p, to
938 make it consistent with the commentary. Fix typos in the
941 * textprop.c (syms_of_textprop): Remove dead code.
942 (copy_text_properties): Delete obsolete commentary about an
943 interface that was deleted long ago. Fix typos in the description
946 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
947 to changes in oldXMenu/XMenu.h from 2011-04-16.
948 <menu_help_message, prev_menu_help_message>: Constify.
949 (IT_menu_make_room): menu->help_text is now `const char **';
952 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
953 to changes in oldXMenu/XMenu.h from 2011-04-16.
954 (struct XMenu): Declare `help_text' `const char **'.
956 * xfaces.c <Qunspecified>: Make extern again.
958 * syntax.c: Include sys/types.h before including regex.h, as
961 * doc.c (get_doc_string): Improve the format passed to `error'.
963 * doprnt.c (doprnt): Improve commentary.
965 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
967 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
970 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
971 changes in globals.h immediately force recompilation.
972 (TAGS): Depend on $(CURDIR)/m/intel386.h and
973 $(CURDIR)/s/ms-w32.h.
974 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
976 * character.c (Fchar_direction): Function deleted.
977 (syms_of_character): Don't defsubr it.
978 <char-direction-table>: Deleted.
980 2011-04-23 Eli Zaretskii <eliz@gnu.org>
982 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
983 * doprnt.c: Include limits.h.
984 (SIZE_MAX): New macro.
985 (doprnt): Return a size_t value. 2nd arg is now size_t.
986 Many local variables are now size_t instead of int or unsigned.
987 Improve overflow protection. Support `l' modifier for integer
988 conversions. Support %l conversion. Don't assume an EMACS_INT
989 argument for integer conversions and for %c.
991 * lisp.h (doprnt): Restore prototype.
993 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
996 * Makefile.in (base_obj): Add back doprnt.o.
998 * deps.mk (doprnt.o): Add back prerequisites.
999 (callint.o): Depend on character.h.
1001 * eval.c (internal_lisp_condition_case): Include the handler
1002 representation in the error message.
1003 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1004 when breaking from the loop.
1006 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1008 * callint.c (Fcall_interactively): When displaying error message
1009 about invalid control letter, pass the character's codepoint, not
1010 a pointer to its multibyte form. Improve display of the character
1011 in octal and display also its hex code.
1013 * character.c (char_string): Use %x to display the (unsigned)
1014 codepoint of an invalid character, to avoid displaying a bogus
1017 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1018 `error', not SYMBOL_NAME itself.
1020 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1021 character arguments to `error'.
1023 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1024 to `error' in error message about FINAL_CHAR argument. Make sure
1025 FINAL_CHAR is a character, and use %c when it is passed as
1026 argument to `error'.
1028 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1030 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1032 * w32.c: Include <time.h>.
1033 (sys_localtime): New function.
1035 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1037 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1039 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1041 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1043 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1046 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1048 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1049 gl_state.e_property when gl_state.object is Qt.
1051 * insdel.c (make_gap_larger): Remove limitation of buffer size
1054 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1056 * xdisp.c (lookup_glyphless_char_display)
1057 (produce_glyphless_glyph): Handle cons cell entry in
1058 glyphless-char-display.
1059 (Vglyphless_char_display): Document it.
1061 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1062 glyphless-char-display.
1064 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1066 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1068 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1070 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1071 definition for no-X builds.
1073 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1075 Static checks with GCC 4.6.0 and non-default toolkits.
1077 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1079 * process.c (keyboard_bit_set): Define only if SIGIO.
1080 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1081 (send_process): Repair possible setjmp clobbering.
1083 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1085 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1087 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1089 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1090 Define only if needed.
1092 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1093 by pacifying GCC about it. Maybe it's time to retire it?
1094 * xfaces.c (USG, __TIMEVAL__): Likewise.
1096 * dispextern.h (struct redisplay_interface): Rename param
1098 * termhooks.h (struct terminal): Likewise.
1099 * xterm.c (xembed_send_message): Likewise.
1101 * insdel.c (make_gap_smaller): Define only if
1102 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1104 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1107 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1108 so that we aren't warned about unused symbols.
1110 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1112 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1114 * xfns.c (x_real_positions): Mark locals as initialized.
1116 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1118 * xterm.c: Fix problems found by static analysis with other toolkits.
1119 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1120 (x_dispatch_event): Declare static if USE_GTK, and
1121 define if USE_GTK || USE_X_TOOLKIT.
1122 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1123 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1124 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1125 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1127 * xmenu.c (menu_help_callback): Pointer type fixes.
1128 Use const pointers when pointing at readonly data. Avoid pointer
1130 (FALSE): Remove unused macro.
1131 (update_frame_menubar): Remove unused decl.
1133 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1135 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1136 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1137 (single_menu_item): Rename local to avoid shadowing.
1139 * keyboard.c (make_lispy_event): Remove unused local var.
1141 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1142 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1144 * bitmaps: Change bitmaps from unsigned char back to the X11
1145 compatible char. Avoid the old compiler warnings about
1146 out-of-range initializers by using, for example, '\xab' rather
1149 * xgselect.c (xgselect_initialize): Check vs interface
1150 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1152 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1154 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1155 to read-only memory.
1157 * fns.c (vector): Remove; this old hack is no longer needed.
1159 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1161 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1163 * xrdb.c (x_load_resources): Omit unused local.
1165 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1166 (x_window): Rename locals to avoid shadowing.
1167 (USG): Use the kludged USG macro, to pacify gcc.
1169 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1170 (x_term_init): Remove local to avoid shadowing.
1172 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1174 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1175 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1177 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1179 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1181 Fix regex.c, syntax.c and friends for buffers > 2GB.
1182 * syntax.h (struct gl_state_s): Declare character position members
1185 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1187 * textprop.c (verify_interval_modification, interval_of):
1188 Declare arguments EMACS_INT.
1190 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1193 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1195 * indent.c (Fvertical_motion): Local variable it_start is now
1198 * regex.c (re_match, re_match_2, re_match_2_internal)
1199 (bcmp_translate, regcomp, regexec, print_double_string)
1200 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1201 (re_compile_pattern, re_exec): Declare arguments and local
1202 variables `size_t' and `ssize_t' and return values `regoff_t', as
1204 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1205 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1206 <compile_stack_type>: `size' and `avail' are now `size_t'.
1208 * regex.h <regoff_t>: Use ssize_t, not int.
1209 (re_search, re_search_2, re_match, re_match_2): Arguments that
1210 specify buffer/string position and length are now ssize_t and
1211 size_t. Return type is regoff_t.
1213 2011-04-16 Ben Key <bkey76@gmail.com>
1215 * nsfont.m: Fixed bugs in ns_get_family and
1216 ns_descriptor_to_entity that were caused by using free to
1217 deallocate memory blocks that were allocated by xmalloc (via
1218 xstrdup). This caused Emacs to crash when compiled with
1219 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1220 --enable-checking=xmallocoverrun). xfree is now used to
1221 deallocate these memory blocks.
1223 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1225 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1227 emacs_write: Accept and return EMACS_INT for sizes.
1228 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1230 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1231 Accept and return EMACS_INT.
1232 (emacs_gnutls_write): Return the number of bytes written on
1234 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1235 (emacs_read, emacs_write): Remove check for negative size, as the
1236 Emacs source code has been audited now.
1237 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1238 (emacs_read, emacs_write): Use it.
1239 * process.c (send_process): Adjust to the new signatures of
1240 emacs_write and emacs_gnutls_write. Do not attempt to store
1241 a byte offset into an 'int'; it might overflow.
1242 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1244 * sound.c: Don't assume sizes fit in 'int'.
1245 (struct sound_device.period_size, alsa_period_size):
1246 Return EMACS_INT, not int.
1247 (struct sound_device.write, vox_write, alsa_write):
1248 Accept EMACS_INT, not int.
1249 (wav_play, au_play): Use EMACS_INT to store sizes and to
1250 record read return values.
1252 2011-04-15 Ben Key <bkey76@gmail.com>
1254 * keyboard.c (Qundefined): Don't declare static since it is used
1256 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1257 static since they are used in nsfont.m.
1259 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1261 * process.c (Qprocessp): Don't declare static.
1262 * lisp.h (Qprocessp): Declare again.
1264 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1266 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1268 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1270 Improve C-level modularity by making more things 'static'.
1272 Don't publish debugger-only interfaces to other modules.
1273 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1274 (verify_bytepos, count_markers): Move decls to the only modules
1276 * region-cache.h (pp_cache): Likewise.
1277 * window.h (check_all_windows): Likewise.
1278 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1280 * sysdep.c (croak): Now static, if
1281 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1282 * syssignal.h (croak): Declare only if not static.
1284 * alloc.c (refill_memory_reserve): Now static if
1285 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1286 * lisp.h (refill_memory_reserve): Declare only if not static.
1288 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1289 Define only if USE_LUCID.
1291 * xrdb.c (x_customization_string, x_rm_string): Now static.
1293 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1294 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1296 * xdisp.c (draw_row_with_mouse_face): Now static.
1297 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1299 * window.h (check_all_windows): Mark externally visible.
1301 * window.c (window_deletion_count): Now static.
1303 * undo.c: Make symbols static if they're not exported.
1304 (last_undo_buffer, last_boundary_position, pending_boundary):
1307 * textprop.c (interval_insert_behind_hooks): Now static.
1308 (interval_insert_in_front_hooks): Likewise.
1310 * term.c: Make symbols static if they're not exported.
1311 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1312 (max_frame_lines, tty_set_terminal_modes):
1313 (tty_reset_terminal_modes, tty_turn_off_highlight):
1314 (get_tty_terminal): Now static.
1315 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1316 * termhooks.h (term_mouse_moveto): Do not declare if
1318 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1319 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1321 * sysdep.c: Make symbols static if they're not exported.
1322 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1324 (sigprocmask_set, full_mask): Remove; unused.
1325 (wait_debugging): Mark as visible.
1326 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1327 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1329 * syntax.c (syntax_temp): Define only if !__GNUC__.
1331 * sound.c (current_sound_device, current_sound): Now static.
1333 * search.c (searchbufs, searchbuf_head): Now static.
1335 * scroll.c (scroll_cost): Remove; unused.
1336 * dispextern.h (scroll_cost): Remove decl.
1338 * region-cache.h (pp_cache): Mark as externally visible.
1340 * process.c: Make symbols static if they're not exported.
1341 (process_tick, update_tick, create_process, chan_process):
1342 (Vprocess_alist, proc_buffered_char, datagram_access):
1343 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1344 (deactivate_process): Mark defn as static, as well as decl.
1345 * lisp.h (create_process): Remove decl.
1346 * process.h (chan_process, Vprocess_alist): Remove decls.
1348 * print.c: Make symbols static if they're not exported.
1349 (print_depth, new_backquote_output, being_printed, print_buffer):
1350 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1351 (print_interval, print_number_index, initial_stderr_stream):
1353 * lisp.h (Fprinc): Remove decl.
1354 (debug_output_compilation_hack): Mark as externally visible.
1356 * sysdep.c (croak): Move decl from here to syssignal.h.
1357 * syssignal.h (croak): Put it here, so the API can be checked when
1358 'croak' is called from dissociate_if_controlling_tty.
1360 * minibuf.c: Make symbols static if they're not exported.
1361 (minibuf_save_list, choose_minibuf_frame): Now static.
1362 * lisp.h (choose_minibuf_frame): Remove decl.
1364 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1366 * lread.c: Make symbols static if they're not exported.
1367 (read_objects, initial_obarray, oblookup_last_bucket_number):
1369 (make_symbol): Remove; unused.
1370 * lisp.h (initial_obarray, make_symbol): Remove decls.
1372 * keyboard.c: Make symbols static if they're not exported.
1373 (single_kboard, recent_keys_index, total_keys, recent_keys):
1374 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1375 (this_single_command_key_start, echoing, last_auto_save):
1376 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1377 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1378 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1379 (Vlispy_mouse_stem, double_click_count):
1381 (force_auto_save_soon): Define only if SIGDANGER.
1382 (ignore_mouse_drag_p): Now static if
1383 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1384 (print_help): Remove; unused.
1385 (stop_character, last_timer_event): Mark as externally visible.
1386 * keyboard.h (ignore_mouse_drag_p): Declare only if
1387 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1388 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1389 * lisp.h (echoing): Remove decl.
1390 (force_auto_save_soon): Declare only if SIGDANGER.
1391 * xdisp.c (redisplay_window): Simplify code, to make it more
1392 obvious that ignore_mouse_drag_p is not accessed if !defined
1393 USE_GTK && !defined HAVE_NS.
1395 * intervals.c: Make symbols static if they're not exported.
1396 (merge_properties_sticky, merge_interval_right, delete_interval):
1398 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1400 * insdel.c: Make symbols static if they're not exported.
1401 However, leave prepare_to_modify_buffer alone. It's never
1402 called from outside this function, but that appears to be a bug.
1403 (combine_after_change_list, combine_after_change_buffer):
1404 (adjust_after_replace, signal_before_change): Now static.
1405 (adjust_after_replace_noundo): Remove; unused.
1406 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1407 (signal_before_change): Remove decls.
1409 * indent.c (val_compute_motion, val_vmotion): Now static.
1411 * image.c: Make symbols static if they're not exported.
1412 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1414 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1415 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1417 * fringe.c (standard_bitmaps): Now static.
1418 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1420 * frame.c: Make symbols static if they're not exported.
1421 (x_report_frame_params, make_terminal_frame): Now static.
1422 (get_frame_param): Now static, unless HAVE_NS.
1423 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1424 (x_get_resource_string): Remove; not used.
1425 * frame.h (make_terminal_frame, x_report_frame_params):
1426 (x_get_resource_string); Remove decls.
1427 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1428 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1430 * font.c, fontset.c: Make symbols static if they're not exported.
1431 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1432 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1433 * font.c (font_close_object): Now static.
1434 * font.h (font_close_object): Remove.
1435 * fontset.c (FONTSET_OBJLIST): Remove.
1436 (free_realized_fontset) #if-0 the body, which does nothing.
1437 (face_suitable_for_char_p): #if-0, as it's never called.
1438 * fontset.h (face_suitable_for_char_p): Remove decl.
1439 * xfaces.c (face_at_string_position):
1440 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1441 since 0 is always ASCII.
1443 * fns.c (weak_hash_tables): Now static.
1445 * fileio.c: Make symbols static if they're not exported.
1446 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1447 (Vwrite_region_annotation_buffers): Now static.
1449 * eval.c: Make symbols static if they're not exported.
1450 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1451 * lisp.h (backtrace_list): Remove decl.
1453 * emacs.c: Make symbols static if they're not exported.
1454 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1455 (fatal_error_code, fatal_error_signal_hook, standard_args):
1457 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1458 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1459 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1460 * lisp.h (fatal_error_signal_hook): Remove decl.
1461 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1463 * editfns.c: Move a (normally-unused) function to its only use.
1464 * editfns.c, lisp.h (get_operating_system_release): Remove.
1465 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1466 worth the hassle of breaking this out.
1468 * xterm.c: Make symbols static if they're not exported.
1469 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1470 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1471 (x_destroy_window, x_delete_display):
1473 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1474 (x_mouse_leave): Remove; unused.
1475 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1476 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1477 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1479 (x_mouse_leave): Declare only if WINDOWSNT.
1480 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1481 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1484 * ftxfont.c: Make symbols static if they're not exported.
1485 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1487 * font.h (ftxfont_driver): Likewise.
1489 * xfns.c: Make symbols static if they're not exported.
1490 (x_last_font_name, x_display_info_for_name):
1491 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1492 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1493 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1494 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1495 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1496 (last_show_tip_args): Now static.
1497 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1498 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1499 (x_screen_planes): Remove; unused.
1500 * dispextern.h (x_screen_planes): Remove decl.
1502 * dispnew.c: Make symbols static if they're not exported.
1503 * dispextern.h (redraw_garbaged_frames, scrolling):
1504 (increment_row_positions): Remove.
1505 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1506 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1508 (redraw_garbaged_frames): Remove; unused.
1510 * xfaces.c: Make symbols static if they're not exported.
1511 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1513 * xterm.h (defined_color): Remove decls.
1514 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1515 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1516 (menu_face_changed_default, defined_color, free_realized_face):
1517 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1518 (ascii_face_of_lisp_face): Remove; unused.
1520 * xdisp.c: Make symbols static if they're not exported.
1521 * dispextern.h (scratch_glyph_row, window_box_edges):
1522 (glyph_to_pixel_coords, set_cursor_from_row):
1523 (get_next_display_element, set_iterator_to_next):
1524 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1525 (show_mouse_face): Remove decls
1526 * frame.h (message_buf_print): Likewise.
1527 * lisp.h (pop_message, set_message, check_point_in_composition):
1529 * xterm.h (set_vertical_scroll_bar): Likewise.
1530 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1531 (message_buf_print, scratch_glyph_row, displayed_buffer):
1532 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1533 (get_next_display_element, show_mouse_face, window_box_edges):
1534 (frame_to_window_pixel_xy, check_point_in_composition):
1535 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1536 (glyph_to_pixel_coords): Remove; unused.
1538 * dired.c (file_name_completion): Now static.
1540 * dbusbind.c (xd_in_read_queued_messages): Now static.
1542 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1543 * data.c (circular_list_error): Remove.
1545 * commands.h (last_point_position, last_point_position_buffer):
1546 (last_point_position_window): Remove decls.
1547 * keyboard.c: Make these variables static.
1549 * coding.h (coding, code_convert_region, encode_coding_gap):
1551 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1552 (iso_code_class, detect_coding, code_convert_region): Now static.
1553 (encode_coding_gap): Remove; unused.
1555 * chartab.c (chartab_chars, chartab_bits): Now static.
1557 * charset.h (charset_iso_8859_1): Remove decl.
1558 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1561 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1562 * ccl.c (Vccl_program_table): Now static.
1563 (check_ccl_update): Remove; unused.
1565 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1566 * category.h: ... from here.
1567 * category.c (check_category_table, set_category_set): Now static.
1569 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1570 * lisp.h: Remove these decls.
1572 * buffer.c (buffer_count): Remove unused var.
1574 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1575 so that it's not optimized away.
1576 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1577 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1578 exported only to the debugger.
1580 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1581 * atimer.h (run_all_atimers): Remove; not exported.
1583 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1584 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1585 was inaccessible from Lisp.
1586 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1587 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1589 alloc.c: Import and export fewer symbols, and remove unused items.
1590 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1592 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1593 it's not optimized away by whole-program optimization.
1594 (message_enable_multibyte, free_misc): Remove.
1595 (catchlist, handlerlist, mark_backtrace):
1596 Declare only if BYTE_MARK_STACK.
1597 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1598 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1599 (message_enable_multibyte): Remove decl.
1600 (free_misc, interval_free_list, float_block, float_block_index):
1601 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1602 (cons_free_list, last_marked_index):
1604 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1605 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1606 (mark_backtrace): Define only if BYTE_MARK_STACK.
1607 * xdisp.c (message_enable_multibyte): Now static.
1609 Declare Lisp_Object Q* variables to be 'static' if not exported.
1610 This makes it easier for human readers (and static analyzers)
1611 to see whether these variables are used from other modules.
1612 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1613 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1614 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1615 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1616 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1617 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1618 * xmenu.c, xselect.c:
1619 Declare Q* vars static if they are not used in other modules.
1620 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1621 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1622 Remove decls of unexported vars.
1623 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1625 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1627 Make Emacs functions such as Fatom 'static' by default.
1628 This makes it easier for human readers (and static analyzers)
1629 to see whether these functions can be called from other modules.
1630 DEFUN now defines a static function. To make the function external
1631 so that it can be used in other C modules, use the new macro DEFUE.
1632 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1633 (Finit_image_library):
1634 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1635 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1636 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1637 Remove decls, since these functions are now static.
1638 (Funintern, Fget_internal_run_time): New decls, since these functions
1639 were already external.
1641 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1642 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1643 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1644 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1645 * keyboard.c, keymap.c, lread.c:
1646 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1647 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1648 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1649 Mark functions with DEFUE instead of DEFUN,
1650 if they are used in other modules.
1651 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1652 decls for now-static functions.
1653 * buffer.h (Fdelete_overlay): Remove decl.
1654 * callproc.c (Fgetenv_internal): Mark as internal.
1655 * composite.c (Fremove_list_of_text_properties): Remove decl.
1656 (Fcomposition_get_gstring): New forward static decl.
1657 * composite.h (Fcomposite_get_gstring): Remove decl.
1658 * dired.c (Ffile_attributes): New forward static decl.
1659 * doc.c (Fdocumntation_property): New forward static decl.
1660 * eval.c (Ffetch_bytecode): New forward static decl.
1661 (Funintern): Remove extern decl; now in .h file where it belongs.
1662 * fileio.c (Fmake_symbolic_link): New forward static decl.
1663 * image.c (Finit_image_library): New forward static decl.
1664 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1665 * intervals.h (Fprevious_property_change):
1666 (Fremove_list_of_text_properties): Remove decls.
1667 * keyboard.c (Fthis_command_keys): Remove decl.
1668 (Fcommand_execute): New forward static decl.
1669 * keymap.c (Flookup_key): New forward static decl.
1670 (Fcopy_keymap): Now static.
1671 * keymap.h (Flookup_key): Remove decl.
1672 * process.c (Fget_process): New forward static decl.
1673 (Fprocess_datagram_address): Mark as internal.
1674 * syntax.c (Fsyntax_table_p): New forward static decl.
1675 (skip_chars): Remove duplicate decl.
1676 * textprop.c (Fprevious_property_change): New forward static decl.
1677 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1679 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1680 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1682 * editfns.c (Fformat): Remove unreachable code.
1684 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1686 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1689 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1691 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1692 when at ZV. (Bug#8487)
1694 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1696 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1698 * keyboard.c (parse_tool_bar_item): Likewise.
1699 * sound.c (sound_cleanup, alsa_close): Likewise.
1700 * termcap.c (tgetent): Likewise.
1701 * xfns.c (x_default_font_parameter): Likewise.
1702 * xsettings.c (read_and_apply_settings): Likewise.
1704 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1705 (overrun_check_free): Protoize.
1707 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1709 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1710 since callers should never pass a negative size.
1711 Change the signature to match that of plain 'read' and 'write'; see
1712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1713 * lisp.h: Update prototypes of emacs_write and emacs_read.
1715 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (redisplay_window): Don't try to determine the character
1718 position of the scroll margin if the window start point w->startp
1719 is outside the buffer's accessible region. (Bug#8468)
1721 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1723 Fix write-region and its subroutines for buffers > 2GB.
1724 * fileio.c (a_write, e_write): Modify declaration of arguments and
1725 local variables to support buffers larger than 2GB.
1726 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1728 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1729 argument, local variables, and return value.
1731 * lisp.h: Update prototypes of emacs_write and emacs_read.
1733 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1735 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1737 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1739 Fix more problems found by GCC 4.6.0's static checks.
1741 * xdisp.c (vmessage): Use a better test for character truncation.
1743 * charset.c (load_charset_map): <, not <=, for optimization,
1744 and to avoid potential problems with integer overflow.
1745 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1746 * casetab.c (set_identity, shuffle): Likewise.
1747 * editfns.c (Fformat): Likewise.
1748 * syntax.c (skip_chars): Likewise.
1750 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1751 This also lets GCC 4.6.0 generate slightly better loop code.
1753 * callint.c (Fcall_interactively): <, not <=, for optimization.
1754 (Fcall_interactively): Count the number of arguments produced,
1755 not the number of arguments given. This is simpler and lets GCC
1756 4.6.0 generate slightly better code.
1758 * ftfont.c: Distingish more carefully between FcChar8 and char.
1759 The previous code passed unsigned char * to a functions like
1760 strlen and xstrcasecmp that expect char *, which does not
1761 conform to the C standard.
1762 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1763 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1764 char * when the C standard requires it.
1766 * keyboard.c (read_char): Remove unused var.
1768 * eval.c: Port to Windows vsnprintf (Bug#8435).
1770 (SIZE_MAX): Define if the headers do not.
1771 (verror): Do not give up if vsnprintf returns a negative count.
1772 Instead, grow the buffer. This ports to Windows vsnprintf, which
1773 does not conform to C99. Problem reported by Eli Zaretskii.
1774 Also, simplify the allocation scheme, by avoiding the need for
1775 calling realloc, and removing the ALLOCATED variable.
1777 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1779 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1780 But keep the doprint source code for now, as we might revamp it
1781 and use it again (Bug#8435).
1782 * lisp.h (doprnt): Remove.
1783 * Makefile.in (base_obj): Remove doprnt.o.
1784 * deps.mk (doprnt.o): Remove.
1786 error: Print 32- and 64-bit integers portably (Bug#8435).
1787 Without this change, on typical 64-bit hosts error ("...%d...", N)
1788 was used to print both 32- and 64-bit integers N, which relied on
1790 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1792 * lisp.h (error, verror): Mark as printf-like functions.
1793 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1794 Report overflow in size calculations when allocating printf buffer.
1795 Do not truncate output string at its first null byte.
1796 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1797 Truncate the output at a character boundary, since vsnprintf does not
1799 * charset.c (check_iso_charset_parameter): Convert internal
1800 character to string before calling 'error', since %c now has the
1802 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1803 overflow when computing char to be passed to 'error'. Do not
1804 pass Lisp_Object to 'error'; pass the integer instead.
1805 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1806 formatted with plain %d.
1808 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1810 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1812 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1814 * xterm.c (x_catch_errors): Remove duplicate declaration.
1816 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1818 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1820 2011-04-10 Jim Meyering <meyering@redhat.com>
1822 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1823 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1824 return ssize_t not "int", and use size_t as the buffer length.
1825 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1826 * gnutls.h: Update declarations.
1827 * process.c (read_process_output): Use ssize_t, to match.
1828 (send_process): Likewise.
1830 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1832 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1834 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1836 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1837 Use unsigned char, to match FcChar8 type definition.
1839 * xterm.c (handle_one_xevent):
1840 * xmenu.c (create_and_show_popup_menu):
1841 * xselect.c (x_decline_selection_request)
1842 (x_reply_selection_request): Avoid type-punned deref of X events.
1844 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1846 Fix some uses of `int' instead of EMACS_INT.
1847 * search.c (string_match_1, fast_string_match)
1848 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1849 (scan_buffer, find_next_newline_no_quit)
1850 (find_before_next_newline, search_command, Freplace_match)
1851 (Fmatch_data): Make some `int' variables be EMACS_INT.
1853 * xdisp.c (display_count_lines): 3rd argument and return value now
1854 EMACS_INT. All callers changed.
1855 (pint2hrstr): Last argument is now EMACS_INT.
1857 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1858 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1859 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1860 (decode_coding_utf_16, decode_coding_emacs_mule)
1861 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1862 (decode_coding_ccl, decode_coding_charset)
1863 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1864 (decode_coding_iso_2022, decode_coding_emacs_mule)
1865 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1866 <char_offset, last_offset>: Declare EMACS_INT.
1867 (encode_coding_utf_8, encode_coding_utf_16)
1868 (encode_coding_emacs_mule, encode_invocation_designation)
1869 (encode_designation_at_bol, encode_coding_iso_2022)
1870 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1871 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1873 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1874 (encode_invocation_designation): Last argument P_NCHARS is now
1876 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1877 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1879 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1882 * ccl.c (Fccl_execute_on_string): Declare some variables
1885 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1887 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1889 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1891 * process.c (Fformat_network_address): Doc fix.
1893 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1895 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1897 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1899 * keyboard.c (read_char): Call Lisp function help-form-show,
1900 instead of using internal_with_output_to_temp_buffer.
1901 (Qhelp_form_show): New var.
1902 (syms_of_keyboard): Use DEFSYM macro.
1904 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1906 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1908 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1910 * process.c (Flist_processes): Remove to Lisp.
1911 (list_processes_1): Delete.
1913 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1915 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1917 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1919 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1921 Fix more problems found by GCC 4.6.0's static checks.
1923 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1925 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1927 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1929 * xdisp.c (vmessage): Mark as a printf-like function.
1931 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1933 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1935 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1936 printf-like functions.
1937 (tiff_load): Add casts to remove these marks before passing them
1938 to system-supplied API.
1940 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1942 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1943 This avoids several warnings with gcc -Wstrict-overflow.
1944 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1945 directly, rather than having caller test rule sign. This avoids
1946 some unnecessary tests.
1947 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1948 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1949 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1951 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1952 (xfont_open): Avoid unnecessary tests.
1954 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1956 * composite.h, composite.c (composition_gstring_put_cache):
1957 Use EMACS_INT, not int, for length.
1959 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1960 breaking out part of COMPOSITION_DECODE_RULE.
1961 (COMPOSITION_DECODE_RULE): Use it.
1962 * composite.c (get_composition_id): Remove unused local vars,
1963 by using the new macro.
1965 * textprop.c (set_text_properties_1): Change while to do-while,
1966 since the condition is always true at first.
1968 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1969 (interval_deletion_adjustment): Return unsigned value.
1972 * process.c (list_processes_1, create_pty, read_process_output):
1973 (exec_sentinel): Remove vars that were set but not used.
1974 (create_pty): Remove unnecessary "volatile"s.
1975 (Fnetwork_interface_info): Avoid possibility of int overflow.
1976 (read_process_output): Do adaptive read buffering even if carryover.
1977 (read_process_output): Simplify nbytes computation if buffered.
1979 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1981 * syntax.c (scan_words): Remove var that was set but not used.
1982 (update_syntax_table): Use unsigned instead of int.
1984 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1985 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1986 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1988 * print.c (print_error_message): Avoid int overflow.
1990 * font.c (font_list_entities): Redo for clarity,
1991 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1993 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1994 (font_score): Avoid potential overflow in diff calculation.
1996 * fns.c (substring_both): Remove var that is set but not used.
1997 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1999 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2001 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2002 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2003 can always succeed if overflow has undefined behavior.
2005 * search.c (boyer_moore, wordify): Remove vars set but not used.
2006 (wordify): Omit three unnecessary tests.
2008 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2009 All callers changed. This avoids the need for an unused var.
2011 * casefiddle.c (casify_region): Remove var that is set but not used.
2013 * dired.c (file_name_completion): Remove var that is set but not used.
2015 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2017 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2018 (Finsert_file_contents): Remove unnecessary code checking fd.
2020 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2021 Check for integer overflow on size calculations.
2023 * buffer.c (Fprevious_overlay_change): Remove var that is set
2026 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2027 Remove vars that are set but not used.
2028 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2029 (timer_check_2): Mark vars as initialized.
2031 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2033 * image.c (lookup_image): Remove var that is set but not used.
2034 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2036 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2037 that are set but not used.
2039 * xfns.c (make_invisible_cursor): Don't return garbage
2040 if XCreateBitmapFromData fails (Bug#8410).
2042 * xselect.c (x_get_local_selection, x_handle_property_notify):
2043 Remove vars that are set but not used.
2045 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2046 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2048 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2049 Remove var that is set but not used.
2050 (scroll_bar_windows_size): Now size_t, not int.
2051 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2054 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2055 (map_tty_color) [!defined MSDOS]: Likewise.
2057 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2059 * coding.c: Remove vars that are set but not used.
2060 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2061 All callers changed.
2062 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2063 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2064 (decode_coding_charset): Remove vars that are set but not used.
2066 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2067 that is set but not used.
2069 * print.c (print_object): Remove var that is set but not used.
2071 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2072 The gnulib version avoids calling malloc in the usual case,
2073 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2074 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2075 * filelock.c (current_lock_owner): Likewise.
2076 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2077 * sysdep.c: Include allocator.h, careadlinkat.h.
2078 (emacs_no_realloc_allocator): New static constant.
2079 (emacs_readlink): New function.
2080 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2081 ../lib/careadlinkat.h.
2083 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2085 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2086 first non-nil return value).
2088 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2090 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2091 if not defined (Bug#8403).
2093 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2095 * xdisp.c (display_count_lines): Remove parameter `start',
2096 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2097 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2098 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2099 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2100 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2101 and thereabouts. All callers changed.
2102 (get_per_char_metric): Remove parameter `f', unused since
2103 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2105 2011-04-02 Jim Meyering <meyering@redhat.com>
2107 do not dereference NULL upon failed strdup
2108 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2109 (ns_get_family): Likewise.
2111 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2113 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2115 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2117 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2120 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2122 Add lexical binding.
2124 * window.c (Ftemp_output_buffer_show): New fun.
2125 (Fsave_window_excursion):
2126 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2128 * lread.c (lisp_file_lexically_bound_p): New function.
2129 (Fload): Bind Qlexical_binding.
2130 (readevalloop): Remove `evalfun' arg.
2131 Bind Qinternal_interpreter_environment.
2132 (Feval_buffer): Bind Qlexical_binding.
2133 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2135 (syms_of_lread): Declare `lexical-binding'.
2137 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2139 * keyboard.c (eval_dyn): New fun.
2140 (menu_item_eval_property): Use it.
2142 * image.c (parse_image_spec): Use Ffunctionp.
2144 * fns.c (concat, mapcar1): Accept byte-code-functions.
2146 * eval.c (Fsetq): Handle lexical vars.
2147 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2148 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2149 (FletX, Flet): Obey lexical binding.
2150 (Fcommandp): Handle closures.
2151 (Feval): New `lexical' arg.
2152 (eval_sub): New function extracted from Feval. Use it almost
2153 everywhere where Feval was used. Look up vars in lexical env.
2155 (Ffunctionp): Move from subr.el.
2156 (Ffuncall): Handle closures.
2157 (apply_lambda): Remove `eval_flags'.
2158 (funcall_lambda): Handle closures and new byte-code-functions.
2159 (Fspecial_variable_p): New function.
2160 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2161 but without exporting it to Lisp.
2163 * doc.c (Fdocumentation, store_function_docstring):
2164 * data.c (Finteractive_form): Handle closures.
2166 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2169 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2171 (exec_byte_code): New function extracted from Fbyte_code to handle new
2172 calling convention for byte-code-functions. Add new byte-codes.
2174 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2176 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2178 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2180 * xdisp.c (redisplay_internal): Fix prototype.
2182 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2184 * xdisp.c (SCROLL_LIMIT): New macro.
2185 (try_scrolling): Use it when setting scroll_limit.
2186 Limit scrolling to 100 screen lines.
2187 (redisplay_window): Even when falling back on "recentering",
2188 position point in the window according to scroll-conservatively,
2189 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2191 (try_scrolling): When point is above the window, allow searching
2192 as far as scroll_max, or one screenful, to compute vertical
2193 distance from PT to the scroll margin position. This prevents
2194 try_scrolling from unnecessarily failing when
2195 scroll-conservatively is set to a value slightly larger than the
2196 window height. Clean up the case of PT below the margin at bottom
2197 of window: scroll_max can no longer be INT_MAX. When aggressive
2198 scrolling is in use, don't let point enter the opposite scroll
2199 margin as result of the scroll.
2200 (syms_of_xdisp) <scroll-conservatively>: Document the
2201 threshold of 100 lines for never-recentering scrolling.
2203 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2205 * dispextern.h (move_it_by_lines):
2206 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2207 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2208 (message_log_check_duplicate): Remove parameters `prev_bol' and
2209 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2210 (redisplay_internal): Remove parameter `preserve_echo_area',
2211 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2213 * indent.c (Fvertical_motion):
2214 * window.c (window_scroll_pixel_based, Frecenter):
2215 Don't pass `need_y_p' to `move_it_by_lines'.
2217 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2219 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2220 steal a few bits to be more compact.
2221 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2222 Remove unneeded casts.
2224 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2226 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2228 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2229 binding" message (bug#7967).
2231 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2233 Fix more problems found by GCC 4.6.0's static checks.
2235 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2236 Remove unused local var.
2238 * editfns.c (Fmessage_box): Remove unused local var.
2240 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2241 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2242 Omit unused local vars.
2243 * window.c (shrink_windows): Omit unused local var.
2244 * menu.c (digest_single_submenu): Omit unused local var.
2245 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2246 Omit unused local var.
2248 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2249 Don't assume string length fits in int.
2250 (keyremap_step, read_key_sequence): Use size_t for sizes.
2251 (read_key_sequence): Don't check last_real_key_start redundantly.
2253 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2254 instead of alloca (Bug#8344).
2256 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2257 (Fbacktrace_frame): Don't assume nframes fits in int.
2259 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2261 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2264 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2266 * cm.c (calccost): Turn while-do into do-while, for clarity.
2268 * keyboard.c (syms_of_keyboard): Use the same style as later
2269 in this function when indexing through an array. This also
2270 works around GCC bug 48267.
2272 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2274 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2276 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2277 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2279 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2280 This avoids undefined behavior on integer overflow, and is a bit
2281 more convenient anyway since it is compared to a size_t variable.
2283 Variadic C functions now count arguments with size_t, not int.
2284 This avoids an unnecessary limitation on 64-bit machines, which
2285 caused (substring ...) to crash on large vectors (Bug#8344).
2286 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2287 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2288 All variadic functions and their callers changed accordingly.
2289 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2290 * data.c (arith_driver, float_arith_driver): Likewise.
2291 * editfns.c (general_insert_function): Likewise.
2292 * eval.c (struct backtrace.nargs, interactive_p)
2293 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2294 (funcall_lambda, mark_backtrace): Likewise.
2295 * fns.c (concat): Likewise.
2296 * frame.c (x_set_frame_parameters): Likewise.
2297 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2298 0 if not found, not -1. All callers changed.
2300 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2301 (stack_copy_size): Now size_t, not int.
2302 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2304 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2306 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2307 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2308 All callers changed.
2310 * lisp.h (multibyte_char_to_unibyte):
2311 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2312 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2313 * character.h (CHAR_TO_BYTE8):
2314 * cmds.c (internal_self_insert):
2315 * editfns.c (general_insert_function):
2316 * keymap.c (push_key_description):
2317 * search.c (Freplace_match):
2318 * xdisp.c (message_dolog, set_message_1): All callers changed.
2320 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2322 * keyboard.c (safe_run_hook_funcall): New function.
2323 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2324 don't set the hook to nil, but remove the offending function instead.
2325 (Qcommand_hook_internal): Remove, unused.
2326 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2327 Vcommand_hook_internal.
2329 * eval.c (enum run_hooks_condition): Remove.
2330 (funcall_nil, funcall_not): New functions.
2331 (run_hook_with_args): Call each function through a `funcall' argument.
2332 Remove `cond' argument, now redundant.
2333 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2334 (Frun_hook_with_args_until_failure): Adjust accordingly.
2335 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2337 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2339 * dispextern.h (string_buffer_position): Remove declaration.
2341 * print.c (strout): Remove parameter `multibyte', unused since
2342 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2344 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2345 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2346 All callers changed.
2348 * w32.c (_wsa_errlist): Use braces for struct initializers.
2350 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2351 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2352 All callers changed.
2353 (string_buffer_position): Likewise. Also, make static (it's never
2354 used outside xdisp.c).
2355 (cursor_row_p): Remove parameter `w', unused since
2356 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2357 (decode_mode_spec): Remove parameter `precision', introduced during
2358 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2359 All callers changed.
2361 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2363 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2365 2011-03-27 Anders Lindgren <andlind@gmail.com>
2367 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2368 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2369 (ns_update_auto_hide_menu_bar): New functions.
2370 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2371 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2372 ns_constrain_all_frames.
2373 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2374 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2376 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2378 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2380 2011-03-27 Glenn Morris <rgm@gnu.org>
2382 * syssignal.h: Replace RETSIGTYPE with void.
2383 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2384 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2385 Replace SIGTYPE with void everywhere.
2386 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2387 * s/template.h (SIGTYPE): Remove commented out definition.
2389 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2391 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2392 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2394 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2396 * w32.c (read_unc_volume): Use parameter `henum', instead of
2397 global variable `wget_enum_handle'.
2399 * keymap.c (describe_vector): Remove parameters `indices' and
2400 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2401 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2403 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2405 * keyboard.c (timer_check): Remove parameter `do_it_now',
2406 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2407 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2408 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2410 * keyboard.c (read_char):
2411 * w32menu.c (w32_menu_display_help):
2412 * xmenu.c (show_help_event, menu_help_callback):
2413 Adjust calls to `show_help_echo'.
2415 * gtkutil.c (xg_maybe_add_timer):
2416 * keyboard.c (readable_events):
2417 * process.c (wait_reading_process_output):
2418 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2420 * insdel.c (adjust_markers_gap_motion):
2421 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2422 (gap_left, gap_right): Don't call it.
2424 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2426 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2427 incurred during fontification.
2429 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2431 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2432 (DEFVAR_PER_BUFFER): Don't pass it.
2434 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2435 (scrolling_window): Don't pass it.
2437 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2439 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2441 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2443 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2444 of variables specific to SELinux and computation of `encoded_absname'.
2446 * image.c (XPutPixel): Remove unused variable `height'.
2448 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2450 * unexw32.c (get_section_info): Remove unused variable `section'.
2452 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2453 (system_process_attributes): Remove unused variable `sess'.
2454 (sys_read): Remove unused variable `err'.
2456 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2457 (w32_wnd_proc): Remove unused variable `isdead'.
2458 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2459 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2460 (x_create_tip_frame): Remove unused variable `tem'.
2462 * w32inevt.c (w32_console_read_socket):
2463 Remove unused variable `no_events'.
2465 * w32term.c (x_draw_composite_glyph_string_foreground):
2466 Remove unused variable `width'.
2468 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2470 * w32term.c (x_set_glyph_string_clipping):
2471 Don't pass uninitialized region to CombineRgn.
2473 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2475 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2476 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2477 (Fx_close_connection): Remove unused variable `i'.
2479 * w32font.c (w32font_draw): Return number of glyphs.
2480 (w32font_open_internal): Remove unused variable `i'.
2481 (w32font_driver): Add missing initializer.
2483 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2484 (fill_in_menu): Remove unused variable `items_added'.
2486 * w32term.c (last_mouse_press_frame): Remove static global variable.
2487 (w32_clip_to_row): Remove unused variable `f'.
2488 (x_delete_terminal): Remove unused variable `i'.
2490 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2491 (NOTHING): Remove unused static global variable.
2492 (uniscribe_check_otf): Remove unused variable `table'.
2493 (uniscribe_font_driver): Add missing initializers.
2495 2011-03-23 Julien Danjou <julien@danjou.info>
2497 * term.c (Fsuspend_tty, Fresume_tty):
2498 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2499 * window.c (temp_output_buffer_show):
2500 * insdel.c (signal_before_change):
2501 * frame.c (Fhandle_switch_frame):
2502 * fileio.c (Fdo_auto_save):
2503 * emacs.c (Fkill_emacs):
2504 * editfns.c (save_excursion_restore):
2505 * cmds.c (internal_self_insert):
2506 * callint.c (Fcall_interactively):
2507 * buffer.c (Fkill_all_local_variables):
2508 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2510 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2511 unconditionnaly since it does the check itself.
2513 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2515 Fix more problems found by GCC 4.5.2's static checks.
2517 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2518 the first time through the loop, since we know p0 < p1 then.
2519 This also avoids a gcc -Wstrict-overflow warning.
2521 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2522 leading to a memory leak, possible in functions like
2523 load_charset_map_from_file that can allocate an unbounded number
2524 of objects (Bug#8318).
2526 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2527 that could (at least in theory) be that large.
2529 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2530 This is less likely to overflow, and avoids undefined behavior if
2531 overflow does occur. All callers changed. Use strtoul to scan
2532 for the unsigned long integer.
2533 (pint2hrstr): Simplify and tune code slightly.
2534 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2536 * scroll.c (do_scrolling): Work around GCC bug 48228.
2537 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2539 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2540 This also avoids a warning with gcc -Wstrict-overflow.
2541 (validate_x_resource_name): Simplify count usage.
2542 This also avoids a warning with gcc -Wstrict-overflow.
2544 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2547 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2549 * process.c (Fmake_network_process): Use socklen_t, not int,
2550 where POSIX says socklen_t is required in portable programs.
2551 This fixes a porting bug on hosts like 64-bit HP-UX, where
2552 socklen_t is wider than int (Bug#8277).
2553 (Fmake_network_process, server_accept_connection):
2554 (wait_reading_process_output, read_process_output):
2557 * process.c: Rename or move locals to avoid shadowing.
2558 (list_processes_1, Fmake_network_process):
2559 (read_process_output_error_handler, exec_sentinel_error_handler):
2560 Rename or move locals.
2561 (Fmake_network_process): Define label "retry_connect" only if needed.
2562 (Fnetwork_interface_info): Fix pointer signedness.
2563 (process_send_signal): Add cast to avoid pointer signedness problem.
2564 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2565 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2567 Make tparam.h and terminfo.c consistent.
2568 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2569 Include tparam.h instead, since it declares them.
2570 * cm.h (PC): Remove extern decl; tparam.h now does this.
2571 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2572 * terminfo.c: Include tparam.h, to check interfaces.
2573 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2574 (tparam): Adjust signature to match interface in tparam.h;
2575 this removes some undefined behavior. Check that outstring and len
2576 are zero, which they always are with Emacs.
2577 * tparam.h (PC, BC, UP): New extern decls.
2579 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2580 (xftfont_open): Rename locals to avoid shadowing.
2582 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2583 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2584 (OTF_TAG_SYM): Omit macro if not needed.
2585 (ftfont_list): Remove unused local.
2586 (get_adstyle_property, ftfont_pattern_entity):
2587 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2588 Rename locals to avoid shadowing.
2590 * xfont.c (xfont_list_family): Mark var as initialized.
2592 * xml.c (make_dom): Now static.
2594 * composite.c (composition_compute_stop_pos): Rename local to
2596 (composition_reseat_it): Remove unused locals.
2597 (find_automatic_composition, composition_adjust_point): Likewise.
2598 (composition_update_it): Mark var as initialized.
2599 (find_automatic_composition): Mark vars as initialized,
2600 with a FIXME (Bug#8290).
2602 character.h: Rename locals to avoid shadowing.
2603 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2604 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2605 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2606 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2609 * textprop.c (property_change_between_p): Remove; unused.
2611 * intervals.c (interval_start_pos): Now static.
2613 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2615 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2616 Rename locals to avoid shadowing.
2618 * sound.c (wav_play, au_play, Fplay_sound_internal):
2619 Fix pointer signedness.
2620 (alsa_choose_format): Remove unused local var.
2621 (wav_play): Initialize a variable to 0, to prevent undefined
2622 behavior (Bug#8278).
2624 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2626 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2628 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2629 clobbering (Bug#8298).
2630 * sysdep.c (sys_subshell): Likewise.
2631 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2633 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2634 This should get cleaned up, so that child_setup has the
2635 same signature on all platforms.
2637 * callproc.c (call_process_cleanup): Now static.
2638 (relocate_fd): Rename locals to avoid shadowing.
2640 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2642 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2643 not to be necessary, and produces flickering.
2645 2011-03-20 Glenn Morris <rgm@gnu.org>
2647 * config.in: Remove file.
2649 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2651 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2652 are now in src/globals.h.
2653 (syms_of_minibuf): Remove spurious & from previous change.
2655 2011-03-20 Leo <sdl.web@gmail.com>
2657 * minibuf.c (completing-read-function): New variable.
2658 (completing-read-default): Rename from completing-read.
2659 (completing-read): Call completing-read-function.
2661 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2663 * xfaces.c (Fx_load_color_file):
2664 Read color file from absolute filename (bug#8250).
2666 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2668 * makefile.w32-in: Update dependencies.
2670 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2672 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2674 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2676 Fix more problems found by GCC 4.5.2's static checks.
2678 * process.c (make_serial_process_unwind, send_process_trap):
2679 (sigchld_handler): Now static.
2681 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2682 That way, the code declares only the vars that it needs.
2683 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2684 * s/cygwin.h (PTY_ITERATION): Likewise.
2685 * s/darwin.h (PTY_ITERATION): Likewise.
2686 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2688 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2689 * process.c (allocate_pty): Don't declare stb unless it's needed.
2691 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2692 (CONSTANTLIM): Remove; unused.
2693 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2694 Define only if needed.
2696 * unexelf.c (unexec): Name an expression,
2697 to avoid gcc -Wbad-function-cast warning.
2698 Use a different way to cause a compilation error if anyone uses
2699 n rather than nn, a way that does not involve shadowing.
2700 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2702 * deps.mk (unexalpha.o): Remove; unused.
2704 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2705 * unexec.h: New file.
2706 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2707 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2709 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2710 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2711 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2712 Change as necessary to match prototype in unexec.h.
2714 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2716 (back_comment, skip_chars): Mark vars as initialized.
2718 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2719 Rename locals to avoid shadowing.
2721 * lread.c (read1): Rewrite so as not to use empty "else".
2722 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2724 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2726 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2727 warning when compiling print.c.
2729 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2730 instead of using an uninitialized var.
2731 (font_sort_entities): Mark var as initialized.
2733 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2735 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2736 pointers to constants.
2737 (font_parse_fcname): Remove unused vars.
2738 (font_delete_unmatched): Now static.
2739 (font_get_spec): Remove; unused.
2740 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2741 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2742 Rename or move locals to avoid shadowing.
2744 * fns.c (require_nesting_list, require_unwind): Now static.
2745 (Ffillarray): Rename locals to avoid shadowing.
2747 * floatfns.c (domain_error2): Define only if needed.
2748 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2750 * alloc.c (mark_backtrace): Move decl from here ...
2751 * lisp.h: ... to here, so that it can be checked.
2753 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2754 (Fdefvar): Rewrite so as not to use empty "else".
2755 (lisp_indirect_variable): Name an expression,
2756 to avoid gcc -Wbad-function-cast warning.
2757 (Fdefvar): Rename locals to avoid shadowing.
2759 * callint.c (quotify_arg, quotify_args): Now static.
2760 (Fcall_interactively): Rename locals to avoid shadowing.
2761 Use const pointer when appropriate.
2763 * lisp.h (get_system_name, get_operating_system_release):
2764 Move decls here, to check interfaces.
2765 * process.c (get_operating_system_release): Move decl to lisp.h.
2766 * xrdb.c (get_system_name): Likewise.
2767 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2768 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2769 some of which prompt warnings from gcc -Wbad-function-cast.
2770 (Fformat_time_string, Fencode_time, Finsert_char):
2771 (Ftranslate_region_internal, Fformat):
2772 Rename or remove local vars to avoid shadowing.
2773 (Ftranslate_region_internal): Mark var as initialized.
2775 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2778 * lisp.h (eassert): Check that the argument compiles, even if
2779 ENABLE_CHECKING is not defined.
2781 * data.c (Findirect_variable): Name an expression, to avoid
2782 gcc -Wbad-function-cast warning.
2783 (default_value, arithcompare, arith_driver, arith_error): Now static.
2784 (store_symval_forwarding): Rename local to avoid shadowing.
2785 (Fmake_variable_buffer_local, Fmake_local_variable):
2786 Mark variables as initialized.
2787 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2789 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2790 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2791 Rename locals to avoid shadowing.
2792 (mark_stack): Move local variables into the #ifdef region where
2794 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2795 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2797 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2798 (GC_STRING_CHARS): Remove; not used.
2799 (Fmemory_limit): Cast sbrk's returned value to char *.
2801 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2802 avoids undefined behavior in theory.
2804 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2806 Use functions, not macros, for up- and down-casing (Bug#8254).
2807 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2808 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2809 to use the following functions instead of these macros.
2810 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2811 EMACS_INT, since callers assume the returned value fits in int.
2812 (upcase1): Likewise, for UPCASE_TABLE.
2813 (uppercasep, lowercasep, upcase): New static inline functions.
2814 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2815 the race-condition problem in the old DOWNCASE.
2817 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2818 Rename locals to avoid shadowing.
2819 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2820 (regex_compile, re_search_2, re_match_2_internal):
2821 Remove unused local vars.
2822 (FREE_VAR): Rewrite so as not to use empty "else",
2823 which gcc can warn about.
2824 (regex_compile, re_match_2_internal): Mark locals as initialized.
2825 (RETALLOC_IF): Define only if needed.
2826 (WORDCHAR_P): Likewise. This one is never needed, but is used
2827 only in a comment talking about a compiler bug, so put inside
2828 the #if 0 of that comment.
2829 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2830 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2833 * search.c (boyer_moore): Rename locals to avoid shadowing.
2834 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2835 (PREV_CHAR_BOUNDARY): Likewise.
2837 * search.c (simple_search): Remove unused var.
2839 * dired.c (compile_pattern): Move decl from here ...
2840 * lisp.h: ... to here, so that it can be checked.
2841 (struct re_registers): New forward decl.
2843 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2845 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2847 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2848 Rename locals to avoid shadowing.
2849 (Fvertical_motion): Mark locals as initialized.
2851 * casefiddle.c (casify_object, casify_region): Now static.
2852 (casify_region): Mark local as initialized.
2854 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2856 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2857 New macros, so that the caller can use some names other than
2858 gcpro1, gcpro2, etc.
2859 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2861 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2862 argument, for consistency with GCPRO2_VAR, etc: it is now the
2863 prefix of the variable, not the variable itself. All uses
2865 * dired.c (directory_files_internal, file_name_completion):
2866 Rename locals to avoid shadowing.
2868 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2869 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2870 dired.c's scmp function, had undefined behavior.
2871 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2872 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2873 * buffer.h: ... to here, because these macros use current_buffer,
2874 and the new implementation with inline functions needs to have
2875 current_buffer in scope now, rather than later when the macros
2877 (downcase, upcase1): New static inline functions.
2878 (DOWNCASE, UPCASE1): Reimplement using these functions.
2879 This avoids undefined behavior in expressions like
2880 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2881 from race conditions in accessing the global variables
2882 case_temp1 and case_temp2.
2883 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2884 * lisp.h (case_temp1, case_temp2): Remove their decls.
2885 * character.h (ASCII_CHAR_P): Move from here ...
2886 * lisp.h: ... to here, so that the inline functions mentioned
2889 * dired.c (directory_files_internal_unwind): Now static.
2891 * fileio.c (file_name_as_directory, directory_file_name):
2892 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2894 (file_name_as_directory): Use const pointers when appropriate.
2895 (Fexpand_file_name): Likewise. In particular, newdir might
2896 point at constant storage, so make it a const pointer.
2897 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2898 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2900 (Fset_file_times, Finsert_file_contents, auto_save_error):
2901 Rename locals to avoid shadowing.
2903 * minibuf.c (choose_minibuf_frame_1): Now static.
2904 (Ftry_completion, Fall_completions): Rename or remove locals
2907 * marker.c (bytepos_to_charpos): Remove; unused.
2909 * lisp.h (verify_bytepos, count_markers): New decls,
2910 so that gcc does not warn that these functions aren't declared.
2912 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2913 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2914 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2915 (copy_text): Remove unused local var.
2917 * filelock.c (within_one_second): Now static.
2918 (lock_file_1): Rename local to avoid shadowing.
2920 * buffer.c (fix_overlays_before): Mark locals as initialized.
2921 (fix_start_end_in_overlays): Likewise. This function should be
2922 simplified by using pointers-to-pointers, but that's a different
2924 (switch_to_buffer_1): Now static.
2925 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2926 (report_overlay_modification): Rename locals to avoid shadowing.
2928 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2929 Fix pointer signedness issue.
2930 (sys_subshell): Mark local as volatile if checking for lint,
2931 to suppress a gcc -Wclobbered warning that does not seem to be right.
2932 (MAXPATHLEN): Define only if needed.
2934 * process.c (serial_open, serial_configure): Move decls from here ...
2935 * systty.h: ... to here, so that they can be checked.
2937 * fns.c (get_random, seed_random): Move extern decls from here ...
2938 * lisp.h: ... to here, so that they can be checked.
2940 * sysdep.c (reset_io): Now static.
2941 (wait_for_termination_signal): Remove; unused.
2943 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2944 (copy_keymap_item, append_key, push_text_char_description):
2946 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2947 (DENSE_TABLE_SIZE): Remove; unused.
2948 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2949 (describe_map_tree):
2950 Rename locals to avoid shadowing.
2952 * keyboard.c: Declare functions static if they are not used elsewhere.
2953 (echo_char, echo_dash, cmd_error, top_level_2):
2954 (poll_for_input, handle_async_input): Now static.
2955 (read_char, kbd_buffer_get_event, make_lispy_position):
2956 (make_lispy_event, make_lispy_movement, apply_modifiers):
2957 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2958 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2959 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2960 (read_key_sequence, read_char): Mark locals as initialized.
2961 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2963 * keyboard.h (make_ctrl_char): New decl.
2964 (mark_kboards): Move decl here ...
2965 * alloc.c (mark_kboards): ... from here.
2967 * lisp.h (force_auto_save_soon): New decl.
2969 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2970 (DEFINE_DUMMY_FUNCTION): New macro.
2971 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2973 (main): Add casts to avoid warnings
2974 if GCC considers string literals to be constants.
2976 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2978 * dbusbind.c: Pointer signedness fixes.
2979 (xd_signature, xd_append_arg, xd_initialize):
2980 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2981 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2982 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2983 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2985 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2986 if GCC considers string literals to be constants.
2987 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2989 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2991 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2992 (print_preprocess, print_object): New macro to fix last change.
2994 * print.c (print_preprocess): Don't forget font objects.
2996 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2998 * emacs.c (USAGE3): Doc fixes.
3000 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3002 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3005 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3007 * lisp.h (VWindow_system, Qfile_name_history):
3008 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3009 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3010 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3012 * w32select.c: Don't #include "keyboard.h".
3013 (run_protected): Add extern declaration for waiting_for_input.
3015 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3016 * w32console.c (detect_input_pending, read_input_pending)
3017 (encode_terminal_code):
3018 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3019 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3020 (w32_system_caret_y, Qfile_name_history):
3021 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3022 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3023 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3024 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3025 * w32proc.c (Qlocal, report_file_error):
3026 * w32term.c (Vwindow_system, updating_frame):
3027 * w32uniscribe.c (initialized, uniscribe_font_driver):
3028 Remove unneeded extern declarations.
3030 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3032 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3034 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3036 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3037 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3038 These macros can no longer be used for assignment.
3040 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3041 Assign struct members directly, instead of using BUF_BEGV etc.
3042 (record_buffer_markers, fetch_buffer_markers): New functions for
3043 recording and fetching special buffer markers.
3044 (set_buffer_internal_1, set_buffer_temp): Use them.
3046 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3048 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3050 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3051 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3053 * xdisp.c (hscroll_window_tree):
3054 (reconsider_clip_changes): Use PT instead of BUF_PT.
3056 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3058 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3059 $(EMACS_ROOT)/lib/intprops.h.
3061 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3063 Fix more problems found by GCC 4.5.2's static checks.
3065 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3066 to unsigned char * to avoid compiler diagnostic.
3067 (xg_free_frame_widgets): Make it clear that a local variable is
3068 needed only if USE_GTK_TOOLTIP.
3069 (gdk_window_get_screen): Make it clear that this macro is needed
3070 only if USE_GTK_TOOLTIP.
3071 (int_gtk_range_get_value): New function, which avoids a diagnostic
3072 from gcc -Wbad-function-cast.
3073 (xg_set_toolkit_scroll_bar_thumb): Use it.
3074 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3075 diagnostic from gcc -Wbad-function-cast.
3076 (get_utf8_string, xg_get_file_with_chooser):
3077 Rename locals to avoid shadowing.
3078 (create_dialog): Move locals to avoid shadowing.
3080 * xgselect.c (xg_select): Remove unused var.
3082 * image.c (four_corners_best): Mark locals as initialized.
3083 (gif_load): Initialize transparent_p to zero (Bug#8238).
3084 Mark another local as initialized.
3085 (my_png_error, my_error_exit): Mark with NO_RETURN.
3087 * image.c (clear_image_cache): Now static.
3088 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3089 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3090 (x_edge_detection): Remove unnecessary cast that
3091 gcc -Wbad-function-cast diagnoses.
3092 (gif_load): Fix pointer signedness.
3093 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3094 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3096 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3098 Improve quality of tests for time stamp overflow.
3099 For example, without this patch (encode-time 0 0 0 1 1
3100 1152921504606846976) returns the obviously-bogus value (-948597
3101 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3102 reports time overflow. See
3103 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3104 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3105 * editfns.c: Include limits.h and intprops.h.
3106 (TIME_T_MIN, TIME_T_MAX): New macros.
3107 (time_overflow): Move earlier, to before first use.
3108 (hi_time, lo_time): New functions, for an accurate test for
3110 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3111 (Fget_internal_run_time): Don't assume time_t fits in int.
3112 (make_time): Use list2 instead of Fcons twice.
3113 (Fdecode_time): More accurate test for out-of-range times.
3114 (check_tm_member): New function.
3115 (Fencode_time): Use it, to test for out-of-range times.
3116 (lisp_time_argument): Don't rely on undefined left-shift and
3117 right-shift behavior when checking for time stamp overflow.
3119 * editfns.c (time_overflow): New function, refactoring common code.
3120 (Fformat_time_string, Fdecode_time, Fencode_time):
3121 (Fcurrent_time_string): Use it.
3123 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3124 * dired.c (make_time): Move to ...
3125 * editfns.c (make_time): ... here.
3126 * systime.h: Note the move.
3128 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3130 * fringe.c (update_window_fringes): Remove unused variables.
3132 * unexmacosx.c (copy_data_segment): Also copy __got section.
3135 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3137 * termcap.c [MSDOS]: Include "msdos.h".
3138 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3139 Constify `char *' arguments and their references according to
3140 prototypes in tparam.h.
3142 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3144 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3145 Adapt all references accordingly.
3147 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3149 2011-03-11 Tom Tromey <tromey@redhat.com>
3151 * buffer.c (syms_of_buffer): Remove obsolete comment.
3153 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3155 * termhooks.h (encode_terminal_code): Declare prototype.
3157 * msdos.c (encode_terminal_code): Don't declare prototype.
3159 * term.c (encode_terminal_code): Now external again, used by
3160 w32console.c and msdos.c.
3162 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3163 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3165 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3167 Fix some minor problems found by GCC 4.5.2's static checks.
3169 * fringe.c (update_window_fringes): Mark locals as initialized
3171 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3173 * alloc.c (mark_fringe_data): Move decl from here ...
3174 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3175 to check its interface.
3176 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3178 * fontset.c (free_realized_fontset): Now static.
3179 (Fset_fontset_font): Rename local to avoid shadowing.
3180 (fontset_font): Mark local as initialized.
3181 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3183 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3185 * xselect.c (x_disown_buffer_selections): Remove; not used.
3186 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3187 (x_own_selection, Fx_disown_selection_internal): Rename locals
3189 (x_handle_dnd_message): Remove local to avoid shadowing.
3191 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3192 so that the caller can use some name other than gcpro1.
3193 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3194 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3195 (Fx_backspace_delete_keys_p):
3196 Use them to avoid shadowing, and rename vars to avoid shadowing.
3197 (x_decode_color, x_set_name, x_window): Now static.
3198 (Fx_create_frame): Add braces to silence GCC warning.
3199 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3200 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3201 Remove unused locals.
3202 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3203 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3204 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3207 * xterm.h (x_mouse_leave): New decl.
3209 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3210 Remove unused functions.
3211 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3212 (x_calc_absolute_position): Now static.
3213 (XTread_socket): Don't define label "out" unless it's used.
3214 Don't declare local "event" unless it's used.
3215 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3216 unless they are used.
3217 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3218 (x_fatal_error_signal): Remove; not used.
3219 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3220 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3221 (x_error_catcher, x_connection_closed, x_error_handler):
3222 (x_error_quitter, xembed_send_message, x_iconify_frame):
3223 (my_log_handler): Rename locals to avoid shadowing.
3224 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3225 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3227 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3228 Rename or move locals to avoid shadowing.
3229 (tty_defined_color, merge_face_heights): Now static.
3230 (free_realized_faces_for_fontset): Remove; not used.
3231 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3232 does not deduce is never used uninitialized.
3233 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3234 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3236 * terminal.c (store_terminal_param): Now static.
3238 * xmenu.c (menu_highlight_callback): Now static.
3239 (set_frame_menubar): Remove unused local.
3240 (xmenu_show): Rename parameter to avoid shadowing.
3241 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3242 since they might point to immutable storage.
3243 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3244 since it's unused otherwise.
3246 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3247 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3248 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3249 avoids a gcc -Wuninitialized diagnostic.
3250 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3251 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3252 does not deduce are never used uninitialized.
3254 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3256 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3257 * window.c (window_loop, size_window):
3258 (run_window_configuration_change_hook, enlarge_window): Likewise.
3260 * window.c (display_buffer): Now static.
3261 (size_window): Mark variables that gcc -Wuninitialized
3262 does not deduce are never used uninitialized.
3263 * window.h (check_all_windows): New decl, to forestall
3264 gcc -Wmissing-prototypes diagnostic.
3265 * dispextern.h (bidi_dump_cached_states): Likewise.
3267 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3269 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3271 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3272 and to avoid gcc -Wuninitialized warning.
3273 (load_charset_map): Mark variables that gcc -Wuninitialized
3274 does not deduce are never used uninitialized.
3275 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3277 * coding.c (coding_set_source, coding_set_destination):
3278 Use "else { /* comment */ }" rather than "else /* comment */;"
3279 for clarity, and to avoid gcc -Wempty-body warning.
3280 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3281 a block, when the outer 'i' will do.
3282 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3283 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3284 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3285 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3286 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3287 Rename locals to avoid shadowing.
3288 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3289 * coding.c (emacs_mule_char, encode_invocation_designation):
3290 Now static, since they're not used elsewhere.
3291 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3292 (decode_coding_object, encode_coding_object, detect_coding_system):
3293 (decode_coding_emacs_mule): Mark variables that gcc
3294 -Wuninitialized does not deduce are never used uninitialized.
3295 (detect_coding_iso_2022): Initialize a local variable that might
3296 be used uninitialized. Leave a FIXME because it's not clear that
3297 this initialization is needed. (Bug#8211)
3298 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3299 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3300 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3301 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3302 Remove unused macros.
3304 * category.c (hash_get_category_set): Remove unused local var.
3305 (copy_category_table): Now static, since it's not used elsewhere.
3306 * character.c (string_count_byte8): Likewise.
3308 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3309 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3311 * chartab.c (copy_sub_char_table): Now static, since it's not used
3313 (sub_char_table_ref_and_range, char_table_ref_and_range):
3314 Rename locals to avoid shadowing.
3315 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3317 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3318 (BIDI_BOB): Remove unused macro.
3320 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3321 deduce are never used uninitialized.
3322 * term.c (encode_terminal_code): Likewise.
3324 * term.c (encode_terminal_code): Now static. Remove unused local.
3326 * tparam.h: New file.
3327 * term.c, tparam.h: Include it.
3328 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3329 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3330 Move these decls to tparam.h, and make them agree with what
3331 is actually in tparam.c. The previous trick of using incompatible
3332 decls in different modules does not conform to the C standard.
3333 All callers of tparam changed to use tparam's actual API.
3334 * tparam.c (tparam1, tparam, tgoto):
3335 Use const pointers where appropriate.
3337 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3338 * cm.h (struct cm): Likewise.
3339 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3340 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3341 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3342 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3343 (turn_on_face, init_tty): Likewise.
3344 * termchar.h (struct tty_display_info): Likewise.
3346 * term.c (term_mouse_position): Rename local to avoid shadowing.
3348 * alloc.c (mark_ttys): Move decl from here ...
3349 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3351 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3353 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3355 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3357 * search.c (compile_pattern_1): Remove argument regp, unused since
3358 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3359 (compile_pattern): Don't pass it.
3361 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3363 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3364 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3366 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3368 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3370 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3371 gdk_window_get_screen, gdk_window_get_geometry,
3372 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3373 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3374 (xg_get_pixbuf_from_pixmap): New function.
3375 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3376 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3377 Call xg_get_pixbuf_from_pixmap instead of
3378 gdk_pixbuf_get_from_drawable.
3379 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3380 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3381 (xg_check_special_colors): Use GtkStyleContext and its functions
3383 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3384 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3385 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3386 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3387 Call gtk_widget_get_preferred_size.
3388 (xg_frame_resized): gdk_window_get_geometry only takes 5
3390 (xg_win_to_widget, xg_event_is_for_menubar):
3391 Call gdk_x11_window_lookup_for_display.
3392 (xg_set_widget_bg): New function.
3393 (delete_cb): New function.
3394 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3395 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3396 (xg_set_background_color): Call xg_set_widget_bg.
3397 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3398 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3399 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3400 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3402 (update_frame_tool_bar): Call gtk_widget_hide.
3403 (xg_initialize): Use GDK_KEY_g.
3405 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3407 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3409 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3410 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3411 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3413 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3415 * w32xfns.c (select_palette): Check success of RealizePalette against
3416 GDI_ERROR, not zero.
3418 See ChangeLog.11 for earlier changes.
3424 Copyright (C) 2011 Free Software Foundation, Inc.
3426 This file is part of GNU Emacs.
3428 GNU Emacs is free software: you can redistribute it and/or modify
3429 it under the terms of the GNU General Public License as published by
3430 the Free Software Foundation, either version 3 of the License, or
3431 (at your option) any later version.
3433 GNU Emacs is distributed in the hope that it will be useful,
3434 but WITHOUT ANY WARRANTY; without even the implied warranty of
3435 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3436 GNU General Public License for more details.
3438 You should have received a copy of the GNU General Public License
3439 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.