1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3 Make identifiers static if they are not used in other modules.
4 * data.c (Qcompiled_function, Qframe, Qvector):
5 * image.c (QimageMagick, Qsvg):
6 * minibuf.c (Qmetadata):
7 * window.c (resize_window_check, resize_root_window): Now static.
8 * window.h (resize_window_check, resize_root_window): Remove decls.
10 * window.c: Fix minor problems reported by GCC 4.6.0.
11 (window_deletion_count, delete_deletable_window): Remove; unused.
12 (window_body_lines): Now static.
13 (Fdelete_other_windows_internal): Mark vars as initialized.
14 Make sure 'resize_failed' is initialized.
15 (run_window_configuration_change_hook): Rename local to avoid shadowing.
16 (resize_window_apply): Remove unused local.
17 * window.h (delete_deletable_window): Remove decl.
19 * image.c: Fix minor problems reported by GCC 4.6.0.
20 (gif_load, svg_load_image): Rename locals to avoid shadowing.
21 (imagemagick_load_image): Fix pointer signedness problem by changing
22 last arg from unsigned char * to char *. All uses changed.
23 Also, fix a local for similar reasons.
24 Remove unused locals. Remove locals to avoid shadowing.
25 (fn_rsvg_handle_free): Remove; unused.
26 (svg_load, svg_load_image): Fix pointer signedness problem.
27 (imagemagick_load_image): Don't use garbage pointer image_wand.
29 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
31 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
33 * image.c (gif_load): Fix omitted cast error introduced by
36 2011-06-10 Martin Rudalics <rudalics@gmx.at>
38 * window.h (resize_proportionally, orig_total_lines)
39 (orig_top_line): Remove from window structure.
40 (set_window_height, set_window_width, change_window_heights)
41 (Fdelete_window): Remove prototypes.
42 (resize_frame_windows): Remove duplicate declaration.
44 2011-06-10 Eli Zaretskii <eliz@gnu.org>
46 * window.h (resize_frame_windows, resize_window_check)
47 (delete_deletable_window, resize_root_window)
48 (resize_frame_windows): Declare prototypes.
50 * window.c (resize_window_apply): Make definition be "static" to
53 2011-06-10 Martin Rudalics <rudalics@gmx.at>
55 * window.c: Remove declarations of Qwindow_size_fixed,
56 window_min_size_1, window_min_size_2, window_min_size,
57 size_window, window_fixed_size_p, enlarge_window, delete_window.
58 Remove static from declaration of Qdelete_window, it's
59 temporarily needed by Fbury_buffer.
60 (replace_window): Don't assign orig_top_line and
62 (Fdelete_window, delete_window): Remove. Window deletion is
64 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
65 Fdelete_window calls with calls to Qdelete_window.
66 (Fdelete_other_windows): Remove. Deleting other windows is
68 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
70 (window_min_size_2, window_min_size_1, window_min_size): Remove.
71 Window minimum sizes are handled in window.el.
72 (shrink_windows, size_window, set_window_height)
73 (set_window_width, change_window_heights, window_height)
74 (window_width, CURBEG, CURSIZE, enlarge_window)
75 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
76 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
78 (make_dummy_parent): Rename to make_parent_window and give it a
79 second argument horflag.
80 (make_window): Don't set resize_proportionally any more.
81 (Fsplit_window): Remove. Windows are split in window.el.
82 (save_restore_action, save_restore_orig_size)
83 (shrink_window_lowest_first, save_restore_orig_size): Remove.
84 Resize mini windows in window.el.
85 (grow_mini_window, shrink_mini_window): Implement by calling
86 Qresize_root_window_vertically, resize_window_check and
88 (saved_window, Fset_window_configuration, save_window_save): Do
89 not handle orig_top_line, orig_total_lines, and
90 resize_proportionally.
91 (window_min_height, window_min_width): Move to window.el.
92 (keys_of_window): Move bindings for delete-other-windows,
93 split-window, delete-window and enlarge-window to window.el.
95 * buffer.c: Temporarily extern Qdelete_window.
96 (Fbury_buffer): Temporarily call Qdelete_window instead of
97 Fdelete_window (Fbury_buffer will move to window.el soon).
99 * frame.c (set_menu_bar_lines_1): Remove code handling
100 orig_top_line and orig_total_lines.
102 * dispnew.c (adjust_frame_glyphs_initially): Don't use
103 set_window_height but set heights directly.
104 (change_frame_size_1): Use resize_frame_windows.
106 * xdisp.c (init_xdisp): Don't use set_window_height but set
109 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
110 resize_frame_windows instead of change_window_heights and run
111 run_window_configuration_change_hook.
113 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
114 instead of change_window_heights and run
115 run_window_configuration_change_hook.
117 2011-06-09 Martin Rudalics <rudalics@gmx.at>
119 * window.c (replace_window): Rename second argument REPLACEMENT to
120 NEW. New third argument SETFLAG. Rewrite.
121 (delete_window, make_dummy_parent): Call replace_window with
123 (window_list_1): Move down in code.
124 (run_window_configuration_change_hook): Move set_buffer part
125 before select_frame_norecord part in order to unwind correctly.
126 Rename count1 to count.
127 (recombine_windows, delete_deletable_window, resize_root_window)
128 (Fdelete_other_windows_internal)
129 (Frun_window_configuration_change_hook, make_parent_window)
130 (resize_window_check, resize_window_apply, Fresize_window_apply)
131 (resize_frame_windows, Fsplit_window_internal)
132 (Fdelete_window_internal, Fresize_mini_window_internal): New
134 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
136 2011-06-08 Martin Rudalics <rudalics@gmx.at>
138 * window.h (window): Add some new members to window structure -
139 normal_lines, normal_cols, new_total, new_normal, clone_number,
140 splits, nest, prev_buffers, next_buffers.
141 (WINDOW_TOTAL_SIZE): Move here from window.c.
142 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
144 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
146 (make_dummy_parent): Set new members of windows structure.
147 (make_window): Move down in code. Handle new members of window
149 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
150 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
151 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
152 (Fset_window_prev_buffers, Fwindow_next_buffers)
153 (Fset_window_next_buffers, Fset_window_clone_number): New
155 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
156 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
158 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
159 Argument WINDOW can be now internal window too.
160 (Fwindow_use_time): Move up in code.
161 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
163 (Fset_window_configuration, saved_window)
164 (Fcurrent_window_configuration, save_window_save): Handle new
165 members of window structure.
166 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
167 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
168 (syms_of_window): New Lisp objects Qrecord_window_buffer,
169 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
170 Qget_mru_window, Qresize_root_window,
171 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
172 Qauto_buffer_name; staticpro them.
174 2011-06-07 Martin Rudalics <rudalics@gmx.at>
176 * window.c (Fwindow_total_size, Fwindow_left_column)
177 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
178 (Fwindow_list_1): New functions.
179 (window_box_text_cols): Replace with window_body_cols.
180 (Fwindow_width, Fscroll_left, Fscroll_right): Use
181 window_body_cols instead of window_box_text_cols.
182 (delete_window, Fset_window_configuration): Call
183 delete_all_subwindows with window as argument.
184 (delete_all_subwindows): Take a window as argument and not a
186 (window_loop): Remove handling of GET_LRU_WINDOW and
188 (Fget_lru_window, Fget_largest_window): Move to window.el.
190 * window.h: Extern window_body_cols instead of
191 window_box_text_cols. delete_all_subwindows now takes a
192 Lisp_Object as argument.
194 * indent.c (compute_motion, Fcompute_motion): Use
195 window_body_cols instead of window_box_text_cols.
197 * frame.c (delete_frame): Call delete_all_subwindows with root
200 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
202 * fns.c (Fputhash): Document return value.
204 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
206 * image.c (gif_load): Implement gif89a spec "no disposal" method.
208 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
210 Cons<->int and similar integer overflow fixes (Bug#8794).
212 Check for overflow when converting integer to cons and back.
213 * charset.c (Fdefine_charset_internal, Fdecode_char):
214 Use cons_to_unsigned to catch overflow.
215 (Fencode_char): Use INTEGER_TO_CONS.
216 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
217 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
218 * data.c (long_to_cons, cons_to_long): Remove.
219 (cons_to_unsigned, cons_to_signed): New functions.
220 These signal an error for invalid or out-of-range values.
221 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
222 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
223 * font.c (Ffont_variation_glyphs):
224 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
225 * lisp.h: Include <intprops.h>.
226 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
227 (cons_to_signed, cons_to_unsigned): New decls.
228 (long_to_cons, cons_to_long): Remove decls.
229 * undo.c (record_first_change): Use INTEGER_TO_CONS.
230 (Fprimitive_undo): Use CONS_TO_INTEGER.
231 * xfns.c (Fx_window_property): Likewise.
232 * xselect.c: Include <limits.h>.
233 (x_own_selection, selection_data_to_lisp_data):
235 (x_handle_selection_request, x_handle_selection_clear)
236 (x_get_foreign_selection, Fx_disown_selection_internal)
237 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
238 (lisp_data_to_selection_data): Use cons_to_unsigned.
239 (x_fill_property_data): Use cons_to_signed.
240 Report values out of range.
242 Check for buffer and string overflow more precisely.
243 * buffer.h (BUF_BYTES_MAX): New macro.
244 * lisp.h (STRING_BYTES_MAX): New macro.
245 * alloc.c (Fmake_string):
246 * character.c (string_escape_byte8):
247 * coding.c (coding_alloc_by_realloc):
249 * editfns.c (Fformat):
251 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
252 since they may not be the same number.
253 * editfns.c (Finsert_char):
254 * fileio.c (Finsert_file_contents):
255 Likewise for BUF_BYTES_MAX.
257 * image.c: Use ptrdiff_t, not int, for sizes.
258 (slurp_file): Switch from int to ptrdiff_t.
260 (slurp_file): Check that file size fits in both size_t (for
261 malloc) and ptrdiff_t (for sanity and safety).
263 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
264 if b->modtime has its maximal value.
266 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
268 Don't assume time_t can fit into int.
269 * buffer.h (struct buffer.modtime): Now time_t, not int.
270 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
271 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
273 Minor fixes for signed vs unsigned integers.
274 * character.h (MAYBE_UNIFY_CHAR):
275 * charset.c (maybe_unify_char):
276 * keyboard.c (read_char, reorder_modifiers):
277 XINT -> XFASTINT, since the integer must be nonnegative.
278 * ftfont.c (ftfont_spec_pattern):
279 * keymap.c (access_keymap, silly_event_symbol_error):
280 XUINT -> XFASTINT, since the integer must be nonnegative.
281 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
282 since it makes no difference and we prefer signed.
283 * keyboard.c (record_char): Use XUINT when all the neighbors do.
284 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
287 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
289 * window.h (Fwindow_frame): Declare.
291 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
293 * alloc.c: Simplify handling of large-request failures (Bug#8800).
294 (SPARE_MEMORY): Always define.
295 (LARGE_REQUEST): Remove.
296 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
298 2011-06-06 Martin Rudalics <rudalics@gmx.at>
300 * lisp.h: Move EXFUNS for Fframe_root_window,
301 Fframe_first_window and Fset_frame_selected_window to window.h.
303 * window.h: Move EXFUNS for Fframe_root_window,
304 Fframe_first_window and Fset_frame_selected_window here from
307 * frame.c (Fwindow_frame, Fframe_first_window)
308 (Fframe_root_window, Fframe_selected_window)
309 (Fset_frame_selected_window): Move to window.c.
310 (Factive_minibuffer_window): Move to minibuf.c.
311 (Fother_visible_frames_p): New function.
313 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
315 * window.c (decode_window, decode_any_window): Move up in code.
316 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
317 (inhibit_frame_unsplittable): Remove unused variable.
318 (Fwindow_buffer): Move up and rewrite doc-string.
319 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
320 (Fwindow_prev): New functions.
321 (Fwindow_frame): Move here from frame.c. Accept any window as
323 (Fframe_root_window, Fframe_first_window)
324 (Fframe_selected_window): Move here from frame.c. Accept frame
325 or arbitrary window as argument. Update doc-strings.
326 (Fminibuffer_window): Move up in code.
327 (Fwindow_minibuffer_p): Move up in code and simplify.
328 (Fset_frame_selected_window): Move here from frame.c.
330 (Fselected_window, select_window, Fselect_window): Move up in
331 code. Minor doc-string fixes.
333 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
335 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
336 Do not assume that spare memory exists; that assumption is valid
337 only if SYSTEM_MALLOC.
338 (LARGE_REQUEST): New macro, so that the issue of large requests
339 is separated from the issue of spare memory.
341 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
343 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
346 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
348 * xfns.c (x_set_scroll_bar_default_width): Move declarations
351 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
353 * gtkutil.c (xg_get_default_scrollbar_width): New function.
355 * gtkutil.h: Declare xg_get_default_scrollbar_width.
357 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
358 min width by calling x_set_scroll_bar_default_width (Bug#8505).
360 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
362 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
364 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
366 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
367 (x_clipboard_manager_save): Add return value.
368 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
370 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
371 Obey Vx_select_enable_clipboard_manager. Catch errors in
372 x_clipboard_manager_save (Bug#8779).
373 (Vx_select_enable_clipboard_manager): New variable.
374 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
376 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
378 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
380 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
382 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
383 in the current matrix if keep_current_p is non-zero.
385 2011-06-04 Eli Zaretskii <eliz@gnu.org>
387 * bidi.c (bidi_level_of_next_char): Fix last change.
389 2011-06-03 Eli Zaretskii <eliz@gnu.org>
391 Support bidi reordering of text covered by display properties.
393 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
394 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
395 (bidi_cache_search, bidi_cache_iterator_state)
396 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
397 (bidi_level_of_next_char, bidi_move_to_visually_next):
398 Support character positions inside a run of characters covered by a
400 (bidi_paragraph_init, bidi_resolve_explicit_1)
401 (bidi_level_of_next_char): Call bidi_fetch_char and
402 bidi_fetch_char_advance instead of FETCH_CHAR and
404 (bidi_init_it): Initialize new members.
405 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
407 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
408 instead of using explicit *_CHAR codes.
409 (bidi_resolve_explicit, bidi_resolve_weak):
410 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
411 bidirectional text is supported only in multibyte buffers.
412 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
413 it to initialize the frame_window_p member of struct bidi_it.
414 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
415 (bidi_resolve_explicit, bidi_resolve_weak)
416 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
417 bidi_it->nchars is non-positive.
418 (bidi_level_of_next_char): Don't try to lookup the cache for the
419 next/previous character if nothing is cached there yet, or if we
420 were just reseat()'ed to a new position.
422 * xdisp.c (set_cursor_from_row): Set start and stop points
423 according to the row's direction when priming the loop that looks
424 for the glyph on which to display cursor.
425 (single_display_spec_intangible_p): Function deleted.
426 (display_prop_intangible_p): Reimplement to call
427 handle_display_spec instead of single_display_spec_intangible_p.
428 Accept 3 additional arguments needed by handle_display_spec.
429 This fixes incorrect cursor motion across display property with complex
430 values: lists, `(when COND...)' forms, etc.
431 (single_display_spec_string_p): Support property values that are
432 lists with the argument STRING its top-level element.
433 (display_prop_string_p): Fix the condition for processing a
434 property that is a list to be consistent with handle_display_spec.
435 (handle_display_spec): New function, refactored from the
436 last portion of handle_display_prop.
437 (compute_display_string_pos): Accept additional argument
438 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
439 value of a `display' property is a "replacing spec".
440 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
441 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
442 the display property, but just return a value indicating whether
443 the display property will replace the characters it covers.
444 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
445 frame_window_p members of struct bidi_it.
446 (compute_display_string_pos, compute_display_string_end):
448 (push_it): Accept second argument POSITION, where pop_it should
449 jump to continue iteration.
450 (reseat_1): Initialize bidi_it.disp_pos.
452 * keyboard.c (adjust_point_for_property): Adjust the call to
453 display_prop_intangible_p to its new signature.
455 * dispextern.h (struct bidi_it): New member frame_window_p.
456 (bidi_init_it): Update prototypes.
457 (display_prop_intangible_p): Update prototype.
458 (compute_display_string_pos, compute_display_string_end):
460 (struct bidi_it): New members nchars and disp_pos. ch_len is now
463 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
465 Malloc failure behavior now depends on size of allocation.
466 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
467 * lisp.h: Change signatures accordingly.
468 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
469 All callers changed. (Bug#8762)
471 * gnutls.c: Use Emacs's memory allocators.
472 Without this change, the gnutls library would invoke malloc etc.
473 directly, which causes problems on non-SYNC_INPUT hosts, and which
474 runs afoul of improving memory_full behavior. (Bug#8761)
475 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
476 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
477 xfree instead of the default malloc, realloc, free.
478 (Fgnutls_boot): No need to check for memory allocation failure,
479 since xmalloc does that for us.
481 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
482 * category.c (hash_get_category_set):
483 * ccl.c (ccl_driver):
484 * charset.c (Fdefine_charset_internal):
485 * charset.h (struct charset.hash_index):
486 * composite.c (get_composition_id, gstring_lookup_cache)
487 (composition_gstring_put_cache):
488 * composite.h (struct composition.hash_index):
489 * dispextern.h (struct image.hash):
490 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
491 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
492 (hashfn_equal, hashfn_user_defined, make_hash_table)
493 (maybe_resize_hash_table, hash_lookup, hash_put)
494 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
495 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
496 (Fsxhash, Fgethash, Fputhash, Fmaphash):
497 * image.c (make_image, search_image_cache, lookup_image)
498 (xpm_put_color_table_h):
499 * lisp.h (struct Lisp_Hash_Table):
500 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
501 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
502 for hashes and hash indexes, instead of 'unsigned' and 'int'.
503 * alloc.c (allocate_vectorlike):
504 Check for overflow in vector size calculations.
505 * ccl.c (ccl_driver):
506 Check for overflow when converting EMACS_INT to int.
507 * fns.c, image.c: Remove unnecessary static decls that would otherwise
508 need to be updated by these changes.
509 * fns.c (make_hash_table, maybe_resize_hash_table):
510 Check for integer overflow with large hash tables.
511 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
512 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
513 (SXHASH_REDUCE): New macro.
514 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
515 Use it instead of discarding useful hash info with large hash values.
516 (sxhash_float): New function.
517 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
518 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
519 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
520 Rewrite to use FIXNUM_BITS, as this simplifies things.
521 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
522 Adjust signatures to match updated version of code.
523 (consing_since_gc): Now EMACS_INT, since a single hash table can
524 use more than INT_MAX bytes.
526 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
528 Make it possible to build with GCC-4.6+ -O2 -flto.
530 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
532 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
534 * minibuf.c (get_minibuffer, read_minibuf_unwind):
535 Call minibuffer-inactive-mode.
537 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
539 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
542 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
544 * data.c (init_data): Remove code for UTS, this system is not
547 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
549 Don't force ./temacs to start in terminal mode.
551 * frame.c (make_initial_frame): Initialize faces in all cases, not
552 only when CANNOT_DUMP is defined.
553 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
555 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
557 * dispnew.c (add_window_display_history): Use const for the string
558 pointer. Remove declaration, not needed.
560 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
562 Use 'inline', not 'INLINE'.
563 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
564 * alloc.c, fontset.c (INLINE): Remove.
565 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
566 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
567 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
568 * gmalloc.c (register_heapinfo): Use inline unconditionally.
569 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
571 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
573 Make it possible to run ./temacs.
575 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
576 syms_of_callproc does the same thing. Remove test for
577 "initialized", do it in the caller.
578 * emacs.c (main): Avoid calling set_initial_environment when dumping.
580 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
582 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
583 (read_minibuf): Use get_minibuffer.
584 (syms_of_minibuf): Use DEFSYM.
585 (Qmetadata): New var.
586 * data.c (Qbuffer): Don't make it static.
587 (syms_of_data): Use DEFSYM.
589 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
591 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
592 (CCL_CODE_MIN): New macro.
594 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
596 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
598 * eval.c (Qdebug): Now static.
599 * lisp.h (Qdebug): Remove decl. This reverts a part of the
600 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
601 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
603 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
605 * image.c: Various fixes to ImageMagick code comments.
606 (Fimagemagick_types): Doc fix.
608 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
610 Minor fixes prompted by GCC 4.6.0 warnings.
612 * xselect.c (converted_selections, conversion_fail_tag): Now static.
614 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
615 (x_clipboard_manager_save_all): Move extern decl to ...
616 * xterm.h: ... here, so that it can be checked for consistency.
618 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
620 * xselect.c (x_clipboard_manager_save_frame)
621 (x_clipboard_manager_save_all): New functions.
622 (Fx_clipboard_manager_save): Lisp function deleted.
624 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
625 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
627 * xterm.h: Update prototype.
629 2011-05-28 William Xu <william.xwl@gmail.com>
631 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
634 2011-05-28 Jim Meyering <meyering@redhat.com>
636 Avoid a sign-extension bug in crypto_hash_function.
637 * fns.c (to_uchar): Define.
638 (crypto_hash_function): Use it to convert some newly-signed
639 variables to unsigned, to avoid sign-extension bugs. For example,
640 without this change, (md5 "truc") would evaluate to
641 45723a2aff78ff4fff7fff1114760e62 rather than the expected
642 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
643 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
645 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
647 Integer overflow fixes.
649 * dbusbind.c: Serial number integer overflow fixes.
650 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
651 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
652 to hold a serial number that is too large for a fixnum.
653 (Fdbus_method_return_internal, Fdbus_method_error_internal):
654 Check for serial numbers out of range. Decode any serial number
655 that was so large that it became a float. (Bug#8722)
657 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
658 (Fdbus_call_method, Fdbus_call_method_asynchronously):
659 Use XFASTINT rather than XUINT when numbers are nonnegative.
660 (xd_append_arg, Fdbus_method_return_internal):
661 (Fdbus_method_error_internal): Likewise. Also, for unsigned
662 arguments, check that Lisp number is nonnegative, rather than
663 silently wrapping negative numbers around. (Bug#8722)
664 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
667 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
669 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
671 ccl: add integer overflow checks
672 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
673 (IN_INT_RANGE): New macros.
674 (ccl_driver): Use them to check for integer overflow when
675 decoding a CCL program. Many of the new checks are whether XINT (x)
676 fits in int; it doesn't always, on 64-bit hosts. The new version
677 doesn't catch all possible integer overflows, but it's an
678 improvement. (Bug#8719)
680 * alloc.c (make_event_array): Use XINT, not XUINT.
681 There's no need for unsigned here.
683 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
684 This follows up to the 2011-05-06 change that substituted uintptr_t
685 for EMACS_INT. This case wasn't caught back then.
687 Rework Fformat to avoid integer overflow issues.
688 * editfns.c: Include <float.h> unconditionally, as it's everywhere
689 now (part of C89). Include <verify.h>.
690 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
691 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
692 (Fformat): Avoid the prepass trying to compute sizes; it was only
693 approximate and thus did not catch overflow reliably. Instead, walk
694 through the format just once, formatting and computing sizes as we go,
695 checking for integer overflow at every step, and allocating a larger
696 buffer as needed. Keep track separately whether the format is
697 multibyte. Keep only the most-recently calculated precision, rather
698 than them all. Record whether each argument has been converted to
699 string. Use EMACS_INT, not int, for byte and char and arg counts.
700 Support field widths and precisions larger than INT_MAX. Avoid
701 sprintf's undefined behavior with conversion specifications such as %#d
702 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
703 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
704 formatting out-of-range floating point numbers with int
707 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
709 * data.c: Avoid integer truncation in expressions involving floats.
710 * data.c: Include <intprops.h>.
711 (arith_driver): When there's an integer overflow in an expression
712 involving floating point, convert the integers to floating point
713 so that the resulting value does not suffer from catastrophic
714 integer truncation. For example, on a 64-bit host (* 4
715 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
716 Do not rely on undefined behavior after integer overflow.
718 merge count_size_as_multibyte, parse_str_to_multibyte
719 * character.c, character.h (count_size_as_multibyte):
720 Rename from parse_str_to_multibyte; all uses changed.
721 Check for integer overflow.
722 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
723 since it's now a duplicate of the other. This is more of
724 a character than a buffer op, so better that it's in character.c.
725 * fns.c, print.c: Adjust to above changes.
727 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
729 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
731 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
733 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
734 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
735 (x_clipboard_manager_save): Now static.
736 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
738 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
739 (crypto_hash_function): Now static.
740 Fix pointer signedness problems. Avoid unnecessary initializations.
742 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
744 * termhooks.h (Vselection_alist): Make it terminal-local.
746 * terminal.c (create_terminal): Initialize it.
748 * xselect.c: Support for clipboard managers.
749 (Vselection_alist): Move to termhooks.h as terminal-local var.
750 (LOCAL_SELECTION): New macro.
751 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
752 (symbol_to_x_atom): Remove gratuitous arg.
753 (x_handle_selection_request, lisp_data_to_selection_data)
754 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
755 (x_own_selection, x_get_local_selection, x_convert_selection):
756 New arg, specifying work frame. Use terminal-local Vselection_alist.
757 (some_frame_on_display): Delete unused function.
758 (Fx_own_selection_internal, Fx_get_selection_internal)
759 (Fx_disown_selection_internal, Fx_selection_owner_p)
760 (Fx_selection_exists_p): New optional frame arg.
761 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
762 (x_handle_selection_clear): Don't treat other terminals with the
763 same keyboard specially. Use the terminal-local Vselection_alist.
764 (x_clear_frame_selections): Use Frun_hook_with_args.
766 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
768 * xterm.h: Add support for those atoms.
770 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
772 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
773 (converted_selections, conversion_fail_tag): New global variables.
774 (x_selection_request_lisp_error): Free the above.
775 (x_get_local_selection): Remove unnecessary code.
776 (x_reply_selection_request): Args changed; handle arbitrary array
777 of converted selections stored in converted_selections.
778 Separate the XChangeProperty and SelectionNotify steps.
779 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
780 (x_convert_selection): New function.
781 (x_handle_selection_event): Simplify.
782 (x_get_foreign_selection): Don't ignore incoming requests while
783 waiting for an answer; this will fail when we implement
784 SAVE_TARGETS, and seems unnecessary anyway.
785 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
786 (Vx_sent_selection_functions): Doc fix.
788 2011-05-26 Leo Liu <sdl.web@gmail.com>
790 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
792 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
794 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
796 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
797 for fringe update if it has periodic bitmap.
798 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
799 and fringe_bitmap_periodic_p.
801 * fringe.c (get_fringe_bitmap_data): New function.
802 (draw_fringe_bitmap_1, update_window_fringes): Use it.
803 (update_window_fringes): Record periodicity of fringe bitmap in glyph
804 row. Mark glyph row for fringe update if periodicity changed.
806 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
807 for fringe update unless it has periodic bitmap.
809 2011-05-25 Kenichi Handa <handa@m17n.org>
811 * xdisp.c (get_next_display_element): Set correct it->face_id for
812 a static composition.
814 2011-05-24 Leo Liu <sdl.web@gmail.com>
817 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
819 * fns.c (crypto_hash_function, Fsha1): New function.
820 (Fmd5): Use crypto_hash_function.
821 (syms_of_fns): Add Ssha1.
823 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
825 * gnutls.c: Remove unused macros.
826 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
827 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
828 Remove macros that are defined and never used.
829 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
831 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
833 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
834 (Fx_get_selection_internal): Minor cleanup.
835 (Fx_own_selection_internal): Rename arguments for consistency with
838 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
840 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
842 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
844 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
846 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
848 * dispnew.c (scrolling_window): Don't exclude the case that the
849 last enabled row in the desired matrix touches the bottom boundary.
851 2011-05-21 Glenn Morris <rgm@gnu.org>
853 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
854 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
855 and add some more files.
857 2011-05-20 Eli Zaretskii <eliz@gnu.org>
859 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
860 report_file_error introduced by the change from 2011-05-07.
862 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
864 * systime.h (Time): Define only if emacs is defined.
865 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
866 where the include path doesn't have X11/X.h by default. See
867 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
869 2011-05-20 Kenichi Handa <handa@m17n.org>
871 * composite.c (find_automatic_composition): Fix previous change.
873 2011-05-20 Glenn Morris <rgm@gnu.org>
875 * lisp.mk: New file, split from Makefile.in.
876 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
878 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
880 2011-05-19 Glenn Morris <rgm@gnu.org>
882 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
883 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
884 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
885 (lisp): Set the order to that of loadup.el.
886 (shortlisp): Make it a copy of $lisp.
887 (SOME_MACHINE_LISP): Remove.
888 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
889 Use just $shortlisp, not $SOME_MACHINE_LISP too.
891 2011-05-18 Kenichi Handa <handa@m17n.org>
893 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
894 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
895 (find_automatic_composition): Mostly rewrite for efficiency.
897 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
899 * makefile.w32-in: Update dependencies.
901 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
903 * menu.c: Include limits.h (fixes the MS-Windows build broken by
906 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
908 Fix some integer overflow issues, such as string length overflow.
910 * insdel.c (count_size_as_multibyte): Check for string overflow.
912 * character.c (lisp_string_width): Check for string overflow.
913 Use EMACS_INT, not int, for string indexes and lengths; in
914 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
915 the resulting string length overflows an EMACS_INT; instead,
916 report a string overflow if no precision given. When checking for
917 precision exhaustion, use a check that cannot possibly have
918 integer overflow. (Bug#8675)
919 * character.h (lisp_string_width): Adjust to new signature.
921 * alloc.c (string_overflow): New function.
922 (Fmake_string): Use it. This doesn't change behavior, but saves
923 a few bytes and will simplify future changes.
924 * character.c (string_escape_byte8): Likewise.
925 * lisp.h (string_overflow): New decl.
927 Fixups, following up to the user-interface timestamp change.
928 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
929 for UI timestamps, instead of unsigned long.
930 * msdos.c (mouse_get_pos): Likewise.
931 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
932 * w32gui.h (Time): Define by including "systime.h" rather than by
933 declaring it ourselves. (Bug#8664)
935 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
936 * image.c (clear_image_cache): Likewise.
938 * term.c (term_mouse_position): Don't assume time_t wraparound.
940 Be more systematic about user-interface timestamps.
941 Before, the code sometimes used 'Time', sometimes 'unsigned long',
942 and sometimes 'EMACS_UINT', to represent these timestamps.
943 This change causes it to use 'Time' uniformly, as that's what X uses.
944 This makes the code easier to follow, and makes it easier to catch
945 integer overflow bugs such as Bug#8664.
946 * frame.c (Fmouse_position, Fmouse_pixel_position):
947 Use Time, not unsigned long, for user-interface timestamps.
948 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
949 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
950 * keyboard.h (last_event_timestamp): Likewise.
951 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
952 * menu.h (xmenu_show): Likewise.
953 * term.c (term_mouse_position): Likewise.
954 * termhooks.h (struct input_event.timestamp): Likewise.
955 (struct terminal.mouse_position_hook): Likewise.
956 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
957 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
958 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
959 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
961 * menu.h, termhooks.h: Include "systime.h", for Time.
963 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
964 Don't assume that the difference between two unsigned long values
965 can fit into an integer. At this point, we know button_down_time
966 <= event->timestamp, so the difference must be nonnegative, so
967 there's no need to cast the result if double-click-time is
968 nonnegative, as it should be; check that it's nonnegative, just in
969 case. This bug is triggered when events are more than 2**31 ms
970 apart (about 25 days). (Bug#8664)
972 * xselect.c (last_event_timestamp): Remove duplicate decl.
973 (x_own_selection): Remove needless cast to unsigned long.
975 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
976 that always fit in int. Use a sentinel instead of a counter, to
977 avoid a temp and to allay GCC's concerns about possible int overflow.
978 * frame.h (struct frame): Use int for menu_bar_items_used
979 instead of EMACS_INT, since it always fits in int.
981 * menu.c (grow_menu_items): Check for int overflow.
983 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
985 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
986 Before, the code was not consistent. These values cannot exceed
987 2**31 - 1 so there's no need to make them unsigned.
988 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
989 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
990 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
992 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
994 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
995 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
996 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
997 presumably because the widths might not match.
999 * window.c (size_window): Avoid needless test at loop start.
1001 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1003 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1005 2011-05-12 Drew Adams <drew.adams@oracle.com>
1007 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1009 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1011 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1012 `width' to `bar_area_x' and `bar_area_width', respectively.
1013 (x_scroll_run): Take account of fringe background extension.
1015 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1016 Rename local vars `left' and `width' to `bar_area_x' and
1017 `bar_area_width', respectively.
1018 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1019 background extension.
1021 2011-05-10 Jim Meyering <meyering@redhat.com>
1023 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1025 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1027 * image.c (Finit_image_library): Return t for built-in image types,
1028 like pbm and xbm. (Bug#8640)
1030 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1032 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1034 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1036 * w32console.c (Fset_screen_color): Doc fix.
1037 (Fget_screen_color): New function.
1038 (syms_of_ntterm): Defsubr it.
1040 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1041 unlink the temporary file if Fcall_process didn't create it in the
1043 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1044 child process will be redirected to a file specified with `:file'.
1045 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1046 cue to call_process_cleanup not to close that handle.
1048 2011-05-07 Ben Key <bkey76@gmail.com>
1050 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1051 one of two shell specific rules, either bootstrap-temacs-CMD or
1052 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1053 to the previous implementation of the bootstrap-temacs rule.
1054 The bootstrap-temacs-CMD rule is similar to the previous
1055 implementation of the bootstrap-temacs rule except that it
1056 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1059 These changes, along with some changes to nt/configure.bat,
1060 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1061 earlier fix to add support for --cflags and --ldflags options
1062 that include quotes so that it works whether make uses cmd or
1065 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1067 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1068 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1070 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1071 a string. Handle both cases.
1072 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1073 (Fdbus_register_method): Use Qinvalid_function.
1075 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1077 * makefile.w32-in: Update dependencies.
1078 (LISP_H): Add inttypes.h and stdin.h.
1079 (PROCESS_H): Add unistd.h.
1081 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1083 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1084 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1086 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1088 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1090 * term.c (vfatal): Remove stray call to va_end.
1091 It's not needed and the C Standard doesn't allow it here anyway.
1093 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1094 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1096 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1099 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1101 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1103 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1105 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1107 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1109 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1110 * charset.c (Fdefine_charset_internal): Don't initialize
1111 charset.code_space[15]. The value was garbage, on hosts with
1112 32-bit int (Bug#8600).
1114 * lread.c (read_integer): Be more consistent with string-to-number.
1115 Use string_to_number to do the actual conversion; this avoids
1116 rounding errors and fixes some other screwups. Without this fix,
1117 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1118 (digit_to_number): Move earlier, for benefit of read_integer.
1119 Return -1 if the digit is out of range for the base, -2 if it is
1120 not a digit in any supported base. (Bug#8602)
1122 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1124 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1125 to match comment at start of function. This also removes a
1126 GCC warning about overflow in a 32+64-bit port.
1128 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1130 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1131 Reported by Stefan Monnier in
1132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1133 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1134 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1136 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1137 (EMACS_UINTPTR): Likewise, with uintptr_t.
1139 * lisp.h: Prefer 64-bit EMACS_INT if available.
1140 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1141 on 32-bit hosts that have 64-bit int, so that they can access
1143 However, temporarily disable this change unless the temporary
1144 symbol WIDE_EMACS_INT is defined.
1146 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1148 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1149 This removes an assumption that EMACS_INT and long are the same
1150 width as pointers. The assumption is true for Emacs porting targets
1151 now, but we want to make other targets possible.
1152 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1153 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1154 In the rest of the code, change types of integers that hold casted
1155 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1156 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1157 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1158 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1159 No need to cast type when ORing.
1160 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1161 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1162 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1163 assume EMACS_INT is the same width as char *.
1164 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1165 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1166 Remove no-longer-needed casts.
1167 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1168 (xg_tool_bar_help_callback, xg_make_tool_item):
1169 Use EMACS_INTPTR to hold an integer
1170 that will be cast to void *; this can avoid a GCC warning
1171 if EMACS_INT is not the same width as void *.
1172 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1173 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1174 (current_message_1, set_message_1):
1175 Use a local to convert to proper width without a cast.
1176 * xmenu.c (dialog_selection_callback): Likewise.
1178 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1179 Also, don't assume VALBITS / RAND_BITS is less than 5,
1180 and don't rely on undefined behavior when shifting a 1 left into
1182 * lisp.h (get_random): Change signature to match.
1184 * lread.c (hash_string): Use size_t, not int, for hash computation.
1185 Normally we prefer signed values; but hashing is special, because
1186 it's better to use unsigned division on hash table sizes so that
1187 the remainder is nonnegative. Also, size_t is the natural width
1188 for hashing into memory. The previous code used 'int', which doesn't
1189 retain enough info to hash well into very large tables.
1190 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1192 * dbusbind.c: Don't possibly lose pointer info when converting.
1193 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1194 Use XPNTR rather than XHASH, so that the high-order bits of
1195 the pointer aren't lost when converting through void *.
1197 * eval.c (Fautoload): Don't double-shift a pointer.
1199 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1201 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1203 * gnutls.c (DEF_GNUTLS_FN):
1204 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1206 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1208 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1211 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1213 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1214 New version that can reserve upto 2GB of heap space.
1216 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1218 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1220 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1222 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1223 `gnutls_certificate_set_x509_key_file'.
1225 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1227 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1228 Update dependencies.
1230 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1232 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1233 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1234 Remove unused parameter `fildes'.
1235 * process.c (read_process_output, send_process): Don't pass it.
1237 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1239 Fix previous change: the library cache is defined in w32.c.
1240 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1241 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1243 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1245 Implement dynamic loading of GnuTLS on Windows.
1247 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1248 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1249 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1252 * gnutls.c (Qgnutls_dll): Define.
1253 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1254 (gnutls_*): Declare function pointers.
1255 (init_gnutls_functions): New function to initialize function pointers.
1256 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1257 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1258 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1259 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1260 (emacs_gnutls_write, emacs_gnutls_read)
1261 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1262 (Fgnutls_available_p): New function.
1263 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1264 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1265 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1267 * image.c: Include w32.h.
1268 (Vimage_type_cache): Delete.
1269 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1270 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1271 (w32_delayed_load): Move to w32.c.
1273 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1275 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1276 (w32_delayed_load): Move from image.c. When loading a library, record
1277 its filename in the :loaded-from property of the library id.
1278 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1279 Initialize and staticpro them.
1280 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1282 * process.c: Include lisp.h before w32.h, not after.
1283 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1284 instead of gnutls_record_check_pending.
1286 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1288 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1290 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1291 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1294 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1296 * xterm.c (x_set_frame_alpha): Do not set property on anything
1297 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1299 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1301 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1303 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1305 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1306 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1307 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1308 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1309 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1310 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1311 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1312 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1313 (Qgnutls_bootprop_callbacks_verify): Make static.
1315 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1317 * callproc.c: Indentation fixup.
1319 * sysdep.c (wait_for_termination_1): Make static.
1320 (wait_for_termination, interruptible_wait_for_termination):
1321 Move after wait_for_termination_1.
1323 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1325 * sysdep.c (interruptible_wait_for_termination): New function
1326 which is like wait_for_termination, but allows keyboard
1329 * callproc.c (Fcall_process): Add (:file "file") as an option for
1331 (Fcall_process_region): Ditto.
1333 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1335 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1336 rather than `XVECTOR (FOO)->size'.
1338 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1339 inttypes.h, as a gnulib replacement is used if it not available in
1342 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1344 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1345 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1346 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1348 * coding.c (coding_alloc_by_realloc): Error out if destination
1349 will grow beyond MOST_POSITIVE_FIXNUM.
1350 (decode_coding_emacs_mule): Abort if there isn't enough place in
1351 charbuf for the composition carryover bytes. Reserve an extra
1352 space for up to 2 characters produced in a loop.
1353 (decode_coding_iso_2022): Abort if there isn't enough place in
1354 charbuf for the composition carryover bytes.
1356 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1358 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1359 aborting when %lld or %lll format is passed.
1360 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1361 %llo or %llx format is passed. (Bug#8545)
1363 * window.c (window_scroll_line_based): Use a marker instead of
1364 simple variables to record original value of point. (Bug#7952)
1366 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1367 produced by %s or %c overflows available buffer space. (Bug#8545)
1369 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1371 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1372 (SIZE_MAX): Move defn after all includes, as they might #define it.
1374 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1376 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1378 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1380 * keyboard.c (Qdelayed_warnings_hook): Define.
1381 (command_loop_1): Run `delayed-warnings-hook'
1382 if Vdelayed_warnings_list is non-nil.
1383 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1384 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1386 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1388 * doprnt.c (doprnt): Don't return value smaller than the buffer
1389 size if the message was truncated. (Bug#8545).
1391 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1393 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1394 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1396 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1398 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1400 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1402 * makefile.w32-in: Update dependencies.
1404 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1406 Improve `doprnt' and its usage. (Bug#8545)
1407 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1408 `format_end'. Remove support for %l as a conversion specifier.
1409 Don't use xrealloc. Improve diagnostics when the %l size modifier
1410 is used. Update the commentary.
1412 * eval.c (verror): Simplify calculation of size_t.
1414 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1417 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1419 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1422 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1424 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1425 This makes this file independent of the recent pseudovector change.
1427 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1429 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1431 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1432 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1433 Remove unused local.
1434 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1436 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1437 GCC 4.6.0 optimizes based on type-based alias analysis.
1438 For example, if b is of type struct buffer * and v of type struct
1439 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1440 != &v->size, and therefore "v->size = 1; b->size = 2; return
1441 v->size;" must therefore return 1. This assumption is incorrect
1442 for Emacs, since it type-puns struct Lisp_Vector * with many other
1443 types. To fix this problem, this patch adds a new type struct
1444 vectorlike_header that documents the constraints on layout of vectors
1445 and pseudovectors, and helps optimizing compilers not get fooled
1446 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1447 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1448 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1450 (XSETPVECTYPE): Rewrite in terms of new macro.
1451 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1452 This is a bit clearer, and further avoids the possibility of
1453 undesirable aliasing.
1454 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1455 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1456 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1457 since Lisp_Subr is a special case (no "next" field).
1458 (ASIZE): Now uses header.size rather than size.
1459 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1460 to avoid the hassle of writing XVECTOR (foo)->header.size.
1461 (struct vectorlike_header): New type.
1462 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1463 object, to help avoid aliasing.
1464 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1465 (SUBRP): Likewise, since Lisp_Subr is a special case.
1466 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1467 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1468 (struct Lisp_Hash_Table): Combine first two members into a single
1469 struct vectorlike_header member. All uses of "size" and "next" members
1470 changed to be "header.size" and "header.next".
1471 * buffer.h (struct buffer): Likewise.
1472 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1473 * frame.h (struct frame): Likewise.
1474 * process.h (struct Lisp_Process): Likewise.
1475 * termhooks.h (struct terminal): Likewise.
1476 * window.c (struct save_window_data, struct saved_window): Likewise.
1477 * window.h (struct window): Likewise.
1478 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1479 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1480 * buffer.c (init_buffer_once): Likewise.
1481 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1483 * process.c (Fformat_network_address): Use local var for size,
1486 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1488 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1489 * data.c (atof): Remove decl; no longer used or needed.
1490 (digit_to_number): Move to lread.c.
1491 (Fstring_to_number): Use new string_to_number function, to be
1492 consistent with how the Lisp reader treats infinities and NaNs.
1493 Do not assume that floating-point numbers represent EMACS_INT
1494 without losing information; this is not true on most 64-bit hosts.
1495 Avoid double-rounding errors, by insisting on integers when
1496 parsing non-base-10 numbers, as the documentation specifies.
1497 * lisp.h (string_to_number): New decl, replacing ...
1498 (isfloat_string): Remove.
1499 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1500 (read1): Do not accept +. and -. as integers; this
1501 appears to have been a coding error. Similarly, do not accept
1502 strings like +-1e0 as floating point numbers. Do not report
1503 overflow for integer overflows unless the base is not 10 which
1504 means we have no simple and reliable way to continue.
1505 Break out the floating-point parsing into a new
1506 function string_to_number, so that Fstring_to_number parses
1507 floating point numbers consistently with the Lisp reader.
1508 (digit_to_number): Move here from data.c. Make it static inline.
1509 (E_CHAR, EXP_INT): Remove, replacing with ...
1510 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1511 (string_to_number): New function, replacing isfloat_string.
1512 This function checks for valid syntax and produces the resulting
1513 Lisp float number too. Rework it so that string-to-number
1514 no longer mishandles examples like "1.0e+". Use strtoumax,
1515 so that overflow for non-base-10 numbers is reported only when
1516 there's no portable and simple way to convert to floating point.
1518 * textprop.c (set_text_properties_1): Rewrite for clarity,
1519 and to avoid GCC warning about integer overflow.
1521 * intervals.h (struct interval): Use EMACS_INT for members
1522 where EMACS_UINT might cause problems. See
1523 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1524 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1525 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1527 (offset_intervals): Tell GCC not to worry about length overflow
1528 when negating a negative length.
1530 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1531 (overrun_check_free): Likewise.
1533 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1534 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1537 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1538 (gnutls_make_error): Rename local to avoid shadowing.
1539 (gnutls_emacs_global_deinit): ifdef out; not used.
1540 (Fgnutls_boot): Use const for pointer to readonly storage.
1541 Comment out unused local. Fix pointer signedness problems.
1543 * lread.c (openp): Don't stuff size_t into an 'int'.
1544 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1545 about possible signed overflow.
1547 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1548 (GDK_KEY_g): Don't define if already defined.
1549 (xg_prepare_tooltip): Avoid pointer signedness problem.
1550 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1552 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1553 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1555 * xfns.c (Fx_window_property): Simplify a bit,
1556 to make a bit faster and to avoid GCC 4.6.0 warning.
1557 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1559 * fns.c (internal_equal): Don't assume size_t fits in int.
1561 * alloc.c (compact_small_strings): Tighten assertion a little.
1563 Replace pEd with more-general pI, and fix some printf arg casts.
1564 * lisp.h (pI): New macro, generalizing old pEd macro to other
1565 conversion specifiers. For example, use "...%"pI"d..." rather
1566 than "...%"pEd"...".
1567 (pEd): Remove. All uses replaced with similar uses of pI.
1568 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1569 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1570 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1571 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1572 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1573 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1574 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1576 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1577 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1578 * print.c (safe_debug_print, print_object): Likewise.
1579 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1581 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1582 avoiding the 0 flag, which is not portable.
1583 * process.c (Fmake_network_process): Use pI to avoid cast.
1584 * region-cache.c (pp_cache): Likewise.
1585 * xdisp.c (decode_mode_spec): Likewise.
1586 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1587 behavior on 64-bit hosts with printf arg.
1588 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1589 (x_stop_queuing_selection_requests): Likewise.
1590 (x_get_window_property): Don't truncate byte count to an 'int'
1593 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1594 here, since it parses constructs like leading '-' and spaces,
1595 which are not wanted; and it overflows with large numbers.
1596 Instead, simply match F[0-9]+, which is what is wanted anyway.
1598 * alloc.c: Remove unportable assumptions about struct layout.
1599 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1600 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1601 (allocate_vectorlike, make_pure_vector): Use the new macros,
1602 plus offsetof, to remove unportable assumptions about struct layout.
1603 These assumptions hold on all porting targets that I know of, but
1604 they are not guaranteed, they're easy to remove, and removing them
1605 makes further changes easier.
1607 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1608 This doesn't fix a bug but makes the code clearer.
1609 (string_overrun_cookie): Now const. Use initializers that
1610 don't formally overflow signed char, to avoid warnings.
1611 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1612 can cause Emacs to crash when string overrun checking is enabled.
1613 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1614 multiple of sizeof (EMACS_INT); it need not be, if
1615 alignof(EMACS_INT) < sizeof (EMACS_INT).
1616 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1618 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1620 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1622 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1624 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1625 supposed to be handshaking. (Bug#8556)
1626 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1628 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1630 * lisp.h (Qdebug): List symbol.
1631 * eval.c (Qdebug): Restore global linkage.
1632 * keyboard.c (debug-on-event): New variable.
1633 (handle_user_signal): Break into debugger when debug-on-event
1634 matches the current signal symbol.
1636 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1638 * alloc.c (check_sblock, check_string_bytes)
1639 (check_string_free_list): Convert to standard C.
1641 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1643 * w32.c (emacs_gnutls_push): Fix typo.
1645 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1647 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1648 "cast to pointer from integer of different size".
1650 Improve doprnt and its use in verror. (Bug#8545)
1651 * doprnt.c (doprnt): Document the set of format control sequences
1652 supported by the function. Use SAFE_ALLOCA instead of always
1655 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1656 is one byte too soon. Don't use xrealloc; instead xfree and
1659 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1661 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1664 * gnutls.c: Renamed global_initialized to
1665 gnutls_global_initialized. Added internals for the
1666 :verify-hostname-error, :verify-error, and :verify-flags
1667 parameters of `gnutls-boot' and documented those parameters in the
1668 docstring. Start callback support.
1669 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1670 unless a fatal error occured. Call gnutls_alert_send_appropriate
1671 on error. Return error code.
1672 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1673 (emacs_gnutls_read): Likewise.
1674 (Fgnutls_boot): Return handshake error code.
1675 (emacs_gnutls_handle_error): New function.
1676 (wsaerror_to_errno): Likewise.
1678 * w32.h (emacs_gnutls_pull): Add prototype.
1679 (emacs_gnutls_push): Likewise.
1681 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1682 (emacs_gnutls_push): Likewise.
1684 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1686 * process.c (wait_reading_process_output): Check if GnuTLS
1687 buffered some data internally if no FDs are set for TLS
1690 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1691 (LIBS): Link to USER_LIBS.
1692 ($(BLD)/gnutls.$(0)): New target.
1694 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1696 * xdisp.c (handle_single_display_spec): Rename the
1697 display_replaced_before_p argument into display_replaced_p, to
1698 make it consistent with the commentary. Fix typos in the
1701 * textprop.c (syms_of_textprop): Remove dead code.
1702 (copy_text_properties): Delete obsolete commentary about an
1703 interface that was deleted long ago. Fix typos in the description
1706 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1707 to changes in oldXMenu/XMenu.h from 2011-04-16.
1708 <menu_help_message, prev_menu_help_message>: Constify.
1709 (IT_menu_make_room): menu->help_text is now `const char **';
1712 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1713 to changes in oldXMenu/XMenu.h from 2011-04-16.
1714 (struct XMenu): Declare `help_text' `const char **'.
1716 * xfaces.c <Qunspecified>: Make extern again.
1718 * syntax.c: Include sys/types.h before including regex.h, as
1721 * doc.c (get_doc_string): Improve the format passed to `error'.
1723 * doprnt.c (doprnt): Improve commentary.
1725 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1727 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1730 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1731 changes in globals.h immediately force recompilation.
1732 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1733 $(CURDIR)/s/ms-w32.h.
1734 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1736 * character.c (Fchar_direction): Function deleted.
1737 (syms_of_character): Don't defsubr it.
1738 <char-direction-table>: Deleted.
1740 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1742 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1743 * doprnt.c: Include limits.h.
1744 (SIZE_MAX): New macro.
1745 (doprnt): Return a size_t value. 2nd arg is now size_t.
1746 Many local variables are now size_t instead of int or unsigned.
1747 Improve overflow protection. Support `l' modifier for integer
1748 conversions. Support %l conversion. Don't assume an EMACS_INT
1749 argument for integer conversions and for %c.
1751 * lisp.h (doprnt): Restore prototype.
1753 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1756 * Makefile.in (base_obj): Add back doprnt.o.
1758 * deps.mk (doprnt.o): Add back prerequisites.
1759 (callint.o): Depend on character.h.
1761 * eval.c (internal_lisp_condition_case): Include the handler
1762 representation in the error message.
1763 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1764 when breaking from the loop.
1766 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1768 * callint.c (Fcall_interactively): When displaying error message
1769 about invalid control letter, pass the character's codepoint, not
1770 a pointer to its multibyte form. Improve display of the character
1771 in octal and display also its hex code.
1773 * character.c (char_string): Use %x to display the (unsigned)
1774 codepoint of an invalid character, to avoid displaying a bogus
1777 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1778 `error', not SYMBOL_NAME itself.
1780 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1781 character arguments to `error'.
1783 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1784 to `error' in error message about FINAL_CHAR argument. Make sure
1785 FINAL_CHAR is a character, and use %c when it is passed as
1786 argument to `error'.
1788 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1790 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1792 * w32.c: Include <time.h>.
1793 (sys_localtime): New function.
1795 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1797 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1799 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1801 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1803 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1806 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1808 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1809 gl_state.e_property when gl_state.object is Qt.
1811 * insdel.c (make_gap_larger): Remove limitation of buffer size
1814 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1816 * xdisp.c (lookup_glyphless_char_display)
1817 (produce_glyphless_glyph): Handle cons cell entry in
1818 glyphless-char-display.
1819 (Vglyphless_char_display): Document it.
1821 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1822 glyphless-char-display.
1824 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1826 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1828 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1830 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1831 definition for no-X builds.
1833 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1835 Static checks with GCC 4.6.0 and non-default toolkits.
1837 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1839 * process.c (keyboard_bit_set): Define only if SIGIO.
1840 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1841 (send_process): Repair possible setjmp clobbering.
1843 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1845 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1847 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1849 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1850 Define only if needed.
1852 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1853 by pacifying GCC about it. Maybe it's time to retire it?
1854 * xfaces.c (USG, __TIMEVAL__): Likewise.
1856 * dispextern.h (struct redisplay_interface): Rename param
1858 * termhooks.h (struct terminal): Likewise.
1859 * xterm.c (xembed_send_message): Likewise.
1861 * insdel.c (make_gap_smaller): Define only if
1862 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1864 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1867 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1868 so that we aren't warned about unused symbols.
1870 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1872 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1874 * xfns.c (x_real_positions): Mark locals as initialized.
1876 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1878 * xterm.c: Fix problems found by static analysis with other toolkits.
1879 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1880 (x_dispatch_event): Declare static if USE_GTK, and
1881 define if USE_GTK || USE_X_TOOLKIT.
1882 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1883 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1884 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1885 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1887 * xmenu.c (menu_help_callback): Pointer type fixes.
1888 Use const pointers when pointing at readonly data. Avoid pointer
1890 (FALSE): Remove unused macro.
1891 (update_frame_menubar): Remove unused decl.
1893 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1895 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1896 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1897 (single_menu_item): Rename local to avoid shadowing.
1899 * keyboard.c (make_lispy_event): Remove unused local var.
1901 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1902 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1904 * bitmaps: Change bitmaps from unsigned char back to the X11
1905 compatible char. Avoid the old compiler warnings about
1906 out-of-range initializers by using, for example, '\xab' rather
1909 * xgselect.c (xgselect_initialize): Check vs interface
1910 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1912 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1914 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1915 to read-only memory.
1917 * fns.c (vector): Remove; this old hack is no longer needed.
1919 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1921 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1923 * xrdb.c (x_load_resources): Omit unused local.
1925 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1926 (x_window): Rename locals to avoid shadowing.
1927 (USG): Use the kludged USG macro, to pacify gcc.
1929 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1930 (x_term_init): Remove local to avoid shadowing.
1932 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1934 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1935 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1937 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1939 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1941 Fix regex.c, syntax.c and friends for buffers > 2GB.
1942 * syntax.h (struct gl_state_s): Declare character position members
1945 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1947 * textprop.c (verify_interval_modification, interval_of):
1948 Declare arguments EMACS_INT.
1950 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1953 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1955 * indent.c (Fvertical_motion): Local variable it_start is now
1958 * regex.c (re_match, re_match_2, re_match_2_internal)
1959 (bcmp_translate, regcomp, regexec, print_double_string)
1960 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1961 (re_compile_pattern, re_exec): Declare arguments and local
1962 variables `size_t' and `ssize_t' and return values `regoff_t', as
1964 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1965 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1966 <compile_stack_type>: `size' and `avail' are now `size_t'.
1968 * regex.h <regoff_t>: Use ssize_t, not int.
1969 (re_search, re_search_2, re_match, re_match_2): Arguments that
1970 specify buffer/string position and length are now ssize_t and
1971 size_t. Return type is regoff_t.
1973 2011-04-16 Ben Key <bkey76@gmail.com>
1975 * nsfont.m: Fixed bugs in ns_get_family and
1976 ns_descriptor_to_entity that were caused by using free to
1977 deallocate memory blocks that were allocated by xmalloc (via
1978 xstrdup). This caused Emacs to crash when compiled with
1979 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1980 --enable-checking=xmallocoverrun). xfree is now used to
1981 deallocate these memory blocks.
1983 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1985 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1987 emacs_write: Accept and return EMACS_INT for sizes.
1988 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1990 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1991 Accept and return EMACS_INT.
1992 (emacs_gnutls_write): Return the number of bytes written on
1994 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1995 (emacs_read, emacs_write): Remove check for negative size, as the
1996 Emacs source code has been audited now.
1997 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1998 (emacs_read, emacs_write): Use it.
1999 * process.c (send_process): Adjust to the new signatures of
2000 emacs_write and emacs_gnutls_write. Do not attempt to store
2001 a byte offset into an 'int'; it might overflow.
2002 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2004 * sound.c: Don't assume sizes fit in 'int'.
2005 (struct sound_device.period_size, alsa_period_size):
2006 Return EMACS_INT, not int.
2007 (struct sound_device.write, vox_write, alsa_write):
2008 Accept EMACS_INT, not int.
2009 (wav_play, au_play): Use EMACS_INT to store sizes and to
2010 record read return values.
2012 2011-04-15 Ben Key <bkey76@gmail.com>
2014 * keyboard.c (Qundefined): Don't declare static since it is used
2016 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2017 static since they are used in nsfont.m.
2019 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2021 * process.c (Qprocessp): Don't declare static.
2022 * lisp.h (Qprocessp): Declare again.
2024 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2026 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2028 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2030 Improve C-level modularity by making more things 'static'.
2032 Don't publish debugger-only interfaces to other modules.
2033 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2034 (verify_bytepos, count_markers): Move decls to the only modules
2036 * region-cache.h (pp_cache): Likewise.
2037 * window.h (check_all_windows): Likewise.
2038 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2040 * sysdep.c (croak): Now static, if
2041 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2042 * syssignal.h (croak): Declare only if not static.
2044 * alloc.c (refill_memory_reserve): Now static if
2045 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2046 * lisp.h (refill_memory_reserve): Declare only if not static.
2048 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2049 Define only if USE_LUCID.
2051 * xrdb.c (x_customization_string, x_rm_string): Now static.
2053 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2054 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2056 * xdisp.c (draw_row_with_mouse_face): Now static.
2057 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2059 * window.h (check_all_windows): Mark externally visible.
2061 * window.c (window_deletion_count): Now static.
2063 * undo.c: Make symbols static if they're not exported.
2064 (last_undo_buffer, last_boundary_position, pending_boundary):
2067 * textprop.c (interval_insert_behind_hooks): Now static.
2068 (interval_insert_in_front_hooks): Likewise.
2070 * term.c: Make symbols static if they're not exported.
2071 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2072 (max_frame_lines, tty_set_terminal_modes):
2073 (tty_reset_terminal_modes, tty_turn_off_highlight):
2074 (get_tty_terminal): Now static.
2075 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2076 * termhooks.h (term_mouse_moveto): Do not declare if
2078 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2079 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2081 * sysdep.c: Make symbols static if they're not exported.
2082 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2084 (sigprocmask_set, full_mask): Remove; unused.
2085 (wait_debugging): Mark as visible.
2086 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2087 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2089 * syntax.c (syntax_temp): Define only if !__GNUC__.
2091 * sound.c (current_sound_device, current_sound): Now static.
2093 * search.c (searchbufs, searchbuf_head): Now static.
2095 * scroll.c (scroll_cost): Remove; unused.
2096 * dispextern.h (scroll_cost): Remove decl.
2098 * region-cache.h (pp_cache): Mark as externally visible.
2100 * process.c: Make symbols static if they're not exported.
2101 (process_tick, update_tick, create_process, chan_process):
2102 (Vprocess_alist, proc_buffered_char, datagram_access):
2103 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2104 (deactivate_process): Mark defn as static, as well as decl.
2105 * lisp.h (create_process): Remove decl.
2106 * process.h (chan_process, Vprocess_alist): Remove decls.
2108 * print.c: Make symbols static if they're not exported.
2109 (print_depth, new_backquote_output, being_printed, print_buffer):
2110 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2111 (print_interval, print_number_index, initial_stderr_stream):
2113 * lisp.h (Fprinc): Remove decl.
2114 (debug_output_compilation_hack): Mark as externally visible.
2116 * sysdep.c (croak): Move decl from here to syssignal.h.
2117 * syssignal.h (croak): Put it here, so the API can be checked when
2118 'croak' is called from dissociate_if_controlling_tty.
2120 * minibuf.c: Make symbols static if they're not exported.
2121 (minibuf_save_list, choose_minibuf_frame): Now static.
2122 * lisp.h (choose_minibuf_frame): Remove decl.
2124 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2126 * lread.c: Make symbols static if they're not exported.
2127 (read_objects, initial_obarray, oblookup_last_bucket_number):
2129 (make_symbol): Remove; unused.
2130 * lisp.h (initial_obarray, make_symbol): Remove decls.
2132 * keyboard.c: Make symbols static if they're not exported.
2133 (single_kboard, recent_keys_index, total_keys, recent_keys):
2134 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2135 (this_single_command_key_start, echoing, last_auto_save):
2136 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2137 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2138 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2139 (Vlispy_mouse_stem, double_click_count):
2141 (force_auto_save_soon): Define only if SIGDANGER.
2142 (ignore_mouse_drag_p): Now static if
2143 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2144 (print_help): Remove; unused.
2145 (stop_character, last_timer_event): Mark as externally visible.
2146 * keyboard.h (ignore_mouse_drag_p): Declare only if
2147 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2148 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2149 * lisp.h (echoing): Remove decl.
2150 (force_auto_save_soon): Declare only if SIGDANGER.
2151 * xdisp.c (redisplay_window): Simplify code, to make it more
2152 obvious that ignore_mouse_drag_p is not accessed if !defined
2153 USE_GTK && !defined HAVE_NS.
2155 * intervals.c: Make symbols static if they're not exported.
2156 (merge_properties_sticky, merge_interval_right, delete_interval):
2158 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2160 * insdel.c: Make symbols static if they're not exported.
2161 However, leave prepare_to_modify_buffer alone. It's never
2162 called from outside this function, but that appears to be a bug.
2163 (combine_after_change_list, combine_after_change_buffer):
2164 (adjust_after_replace, signal_before_change): Now static.
2165 (adjust_after_replace_noundo): Remove; unused.
2166 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2167 (signal_before_change): Remove decls.
2169 * indent.c (val_compute_motion, val_vmotion): Now static.
2171 * image.c: Make symbols static if they're not exported.
2172 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2174 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2175 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2177 * fringe.c (standard_bitmaps): Now static.
2178 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2180 * frame.c: Make symbols static if they're not exported.
2181 (x_report_frame_params, make_terminal_frame): Now static.
2182 (get_frame_param): Now static, unless HAVE_NS.
2183 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2184 (x_get_resource_string): Remove; not used.
2185 * frame.h (make_terminal_frame, x_report_frame_params):
2186 (x_get_resource_string); Remove decls.
2187 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2188 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2190 * font.c, fontset.c: Make symbols static if they're not exported.
2191 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2192 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2193 * font.c (font_close_object): Now static.
2194 * font.h (font_close_object): Remove.
2195 * fontset.c (FONTSET_OBJLIST): Remove.
2196 (free_realized_fontset) #if-0 the body, which does nothing.
2197 (face_suitable_for_char_p): #if-0, as it's never called.
2198 * fontset.h (face_suitable_for_char_p): Remove decl.
2199 * xfaces.c (face_at_string_position):
2200 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2201 since 0 is always ASCII.
2203 * fns.c (weak_hash_tables): Now static.
2205 * fileio.c: Make symbols static if they're not exported.
2206 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2207 (Vwrite_region_annotation_buffers): Now static.
2209 * eval.c: Make symbols static if they're not exported.
2210 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2211 * lisp.h (backtrace_list): Remove decl.
2213 * emacs.c: Make symbols static if they're not exported.
2214 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2215 (fatal_error_code, fatal_error_signal_hook, standard_args):
2217 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2218 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2219 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2220 * lisp.h (fatal_error_signal_hook): Remove decl.
2221 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2223 * editfns.c: Move a (normally-unused) function to its only use.
2224 * editfns.c, lisp.h (get_operating_system_release): Remove.
2225 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2226 worth the hassle of breaking this out.
2228 * xterm.c: Make symbols static if they're not exported.
2229 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2230 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2231 (x_destroy_window, x_delete_display):
2233 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2234 (x_mouse_leave): Remove; unused.
2235 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2236 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2237 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2239 (x_mouse_leave): Declare only if WINDOWSNT.
2240 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2241 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2244 * ftxfont.c: Make symbols static if they're not exported.
2245 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2247 * font.h (ftxfont_driver): Likewise.
2249 * xfns.c: Make symbols static if they're not exported.
2250 (x_last_font_name, x_display_info_for_name):
2251 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2252 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2253 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2254 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2255 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2256 (last_show_tip_args): Now static.
2257 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2258 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2259 (x_screen_planes): Remove; unused.
2260 * dispextern.h (x_screen_planes): Remove decl.
2262 * dispnew.c: Make symbols static if they're not exported.
2263 * dispextern.h (redraw_garbaged_frames, scrolling):
2264 (increment_row_positions): Remove.
2265 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2266 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2268 (redraw_garbaged_frames): Remove; unused.
2270 * xfaces.c: Make symbols static if they're not exported.
2271 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2273 * xterm.h (defined_color): Remove decls.
2274 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2275 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2276 (menu_face_changed_default, defined_color, free_realized_face):
2277 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2278 (ascii_face_of_lisp_face): Remove; unused.
2280 * xdisp.c: Make symbols static if they're not exported.
2281 * dispextern.h (scratch_glyph_row, window_box_edges):
2282 (glyph_to_pixel_coords, set_cursor_from_row):
2283 (get_next_display_element, set_iterator_to_next):
2284 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2285 (show_mouse_face): Remove decls
2286 * frame.h (message_buf_print): Likewise.
2287 * lisp.h (pop_message, set_message, check_point_in_composition):
2289 * xterm.h (set_vertical_scroll_bar): Likewise.
2290 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2291 (message_buf_print, scratch_glyph_row, displayed_buffer):
2292 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2293 (get_next_display_element, show_mouse_face, window_box_edges):
2294 (frame_to_window_pixel_xy, check_point_in_composition):
2295 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2296 (glyph_to_pixel_coords): Remove; unused.
2298 * dired.c (file_name_completion): Now static.
2300 * dbusbind.c (xd_in_read_queued_messages): Now static.
2302 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2303 * data.c (circular_list_error): Remove.
2305 * commands.h (last_point_position, last_point_position_buffer):
2306 (last_point_position_window): Remove decls.
2307 * keyboard.c: Make these variables static.
2309 * coding.h (coding, code_convert_region, encode_coding_gap):
2311 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2312 (iso_code_class, detect_coding, code_convert_region): Now static.
2313 (encode_coding_gap): Remove; unused.
2315 * chartab.c (chartab_chars, chartab_bits): Now static.
2317 * charset.h (charset_iso_8859_1): Remove decl.
2318 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2321 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2322 * ccl.c (Vccl_program_table): Now static.
2323 (check_ccl_update): Remove; unused.
2325 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2326 * category.h: ... from here.
2327 * category.c (check_category_table, set_category_set): Now static.
2329 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2330 * lisp.h: Remove these decls.
2332 * buffer.c (buffer_count): Remove unused var.
2334 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2335 so that it's not optimized away.
2336 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2337 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2338 exported only to the debugger.
2340 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2341 * atimer.h (run_all_atimers): Remove; not exported.
2343 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2344 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2345 was inaccessible from Lisp.
2346 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2347 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2349 alloc.c: Import and export fewer symbols, and remove unused items.
2350 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2352 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2353 it's not optimized away by whole-program optimization.
2354 (message_enable_multibyte, free_misc): Remove.
2355 (catchlist, handlerlist, mark_backtrace):
2356 Declare only if BYTE_MARK_STACK.
2357 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2358 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2359 (message_enable_multibyte): Remove decl.
2360 (free_misc, interval_free_list, float_block, float_block_index):
2361 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2362 (cons_free_list, last_marked_index):
2364 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2365 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2366 (mark_backtrace): Define only if BYTE_MARK_STACK.
2367 * xdisp.c (message_enable_multibyte): Now static.
2369 Declare Lisp_Object Q* variables to be 'static' if not exported.
2370 This makes it easier for human readers (and static analyzers)
2371 to see whether these variables are used from other modules.
2372 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2373 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2374 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2375 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2376 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2377 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2378 * xmenu.c, xselect.c:
2379 Declare Q* vars static if they are not used in other modules.
2380 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2381 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2382 Remove decls of unexported vars.
2383 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2385 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2387 Make Emacs functions such as Fatom 'static' by default.
2388 This makes it easier for human readers (and static analyzers)
2389 to see whether these functions can be called from other modules.
2390 DEFUN now defines a static function. To make the function external
2391 so that it can be used in other C modules, use the new macro DEFUE.
2392 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2393 (Finit_image_library):
2394 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2395 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2396 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2397 Remove decls, since these functions are now static.
2398 (Funintern, Fget_internal_run_time): New decls, since these functions
2399 were already external.
2401 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2402 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2403 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2404 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2405 * keyboard.c, keymap.c, lread.c:
2406 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2407 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2408 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2409 Mark functions with DEFUE instead of DEFUN,
2410 if they are used in other modules.
2411 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2412 decls for now-static functions.
2413 * buffer.h (Fdelete_overlay): Remove decl.
2414 * callproc.c (Fgetenv_internal): Mark as internal.
2415 * composite.c (Fremove_list_of_text_properties): Remove decl.
2416 (Fcomposition_get_gstring): New forward static decl.
2417 * composite.h (Fcomposite_get_gstring): Remove decl.
2418 * dired.c (Ffile_attributes): New forward static decl.
2419 * doc.c (Fdocumntation_property): New forward static decl.
2420 * eval.c (Ffetch_bytecode): New forward static decl.
2421 (Funintern): Remove extern decl; now in .h file where it belongs.
2422 * fileio.c (Fmake_symbolic_link): New forward static decl.
2423 * image.c (Finit_image_library): New forward static decl.
2424 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2425 * intervals.h (Fprevious_property_change):
2426 (Fremove_list_of_text_properties): Remove decls.
2427 * keyboard.c (Fthis_command_keys): Remove decl.
2428 (Fcommand_execute): New forward static decl.
2429 * keymap.c (Flookup_key): New forward static decl.
2430 (Fcopy_keymap): Now static.
2431 * keymap.h (Flookup_key): Remove decl.
2432 * process.c (Fget_process): New forward static decl.
2433 (Fprocess_datagram_address): Mark as internal.
2434 * syntax.c (Fsyntax_table_p): New forward static decl.
2435 (skip_chars): Remove duplicate decl.
2436 * textprop.c (Fprevious_property_change): New forward static decl.
2437 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2439 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2440 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2442 * editfns.c (Fformat): Remove unreachable code.
2444 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2446 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2449 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2451 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2452 when at ZV. (Bug#8487)
2454 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2456 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2458 * keyboard.c (parse_tool_bar_item): Likewise.
2459 * sound.c (sound_cleanup, alsa_close): Likewise.
2460 * termcap.c (tgetent): Likewise.
2461 * xfns.c (x_default_font_parameter): Likewise.
2462 * xsettings.c (read_and_apply_settings): Likewise.
2464 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2465 (overrun_check_free): Protoize.
2467 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2469 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2470 since callers should never pass a negative size.
2471 Change the signature to match that of plain 'read' and 'write'; see
2472 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2473 * lisp.h: Update prototypes of emacs_write and emacs_read.
2475 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2477 * xdisp.c (redisplay_window): Don't try to determine the character
2478 position of the scroll margin if the window start point w->startp
2479 is outside the buffer's accessible region. (Bug#8468)
2481 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2483 Fix write-region and its subroutines for buffers > 2GB.
2484 * fileio.c (a_write, e_write): Modify declaration of arguments and
2485 local variables to support buffers larger than 2GB.
2486 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2488 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2489 argument, local variables, and return value.
2491 * lisp.h: Update prototypes of emacs_write and emacs_read.
2493 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2495 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2497 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2499 Fix more problems found by GCC 4.6.0's static checks.
2501 * xdisp.c (vmessage): Use a better test for character truncation.
2503 * charset.c (load_charset_map): <, not <=, for optimization,
2504 and to avoid potential problems with integer overflow.
2505 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2506 * casetab.c (set_identity, shuffle): Likewise.
2507 * editfns.c (Fformat): Likewise.
2508 * syntax.c (skip_chars): Likewise.
2510 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2511 This also lets GCC 4.6.0 generate slightly better loop code.
2513 * callint.c (Fcall_interactively): <, not <=, for optimization.
2514 (Fcall_interactively): Count the number of arguments produced,
2515 not the number of arguments given. This is simpler and lets GCC
2516 4.6.0 generate slightly better code.
2518 * ftfont.c: Distingish more carefully between FcChar8 and char.
2519 The previous code passed unsigned char * to a functions like
2520 strlen and xstrcasecmp that expect char *, which does not
2521 conform to the C standard.
2522 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2523 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2524 char * when the C standard requires it.
2526 * keyboard.c (read_char): Remove unused var.
2528 * eval.c: Port to Windows vsnprintf (Bug#8435).
2530 (SIZE_MAX): Define if the headers do not.
2531 (verror): Do not give up if vsnprintf returns a negative count.
2532 Instead, grow the buffer. This ports to Windows vsnprintf, which
2533 does not conform to C99. Problem reported by Eli Zaretskii.
2534 Also, simplify the allocation scheme, by avoiding the need for
2535 calling realloc, and removing the ALLOCATED variable.
2537 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2539 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2540 But keep the doprint source code for now, as we might revamp it
2541 and use it again (Bug#8435).
2542 * lisp.h (doprnt): Remove.
2543 * Makefile.in (base_obj): Remove doprnt.o.
2544 * deps.mk (doprnt.o): Remove.
2546 error: Print 32- and 64-bit integers portably (Bug#8435).
2547 Without this change, on typical 64-bit hosts error ("...%d...", N)
2548 was used to print both 32- and 64-bit integers N, which relied on
2550 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2552 * lisp.h (error, verror): Mark as printf-like functions.
2553 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2554 Report overflow in size calculations when allocating printf buffer.
2555 Do not truncate output string at its first null byte.
2556 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2557 Truncate the output at a character boundary, since vsnprintf does not
2559 * charset.c (check_iso_charset_parameter): Convert internal
2560 character to string before calling 'error', since %c now has the
2562 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2563 overflow when computing char to be passed to 'error'. Do not
2564 pass Lisp_Object to 'error'; pass the integer instead.
2565 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2566 formatted with plain %d.
2568 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2570 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2572 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2574 * xterm.c (x_catch_errors): Remove duplicate declaration.
2576 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2578 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2580 2011-04-10 Jim Meyering <meyering@redhat.com>
2582 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2583 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2584 return ssize_t not "int", and use size_t as the buffer length.
2585 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2586 * gnutls.h: Update declarations.
2587 * process.c (read_process_output): Use ssize_t, to match.
2588 (send_process): Likewise.
2590 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2592 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2594 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2596 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2597 Use unsigned char, to match FcChar8 type definition.
2599 * xterm.c (handle_one_xevent):
2600 * xmenu.c (create_and_show_popup_menu):
2601 * xselect.c (x_decline_selection_request)
2602 (x_reply_selection_request): Avoid type-punned deref of X events.
2604 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2606 Fix some uses of `int' instead of EMACS_INT.
2607 * search.c (string_match_1, fast_string_match)
2608 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2609 (scan_buffer, find_next_newline_no_quit)
2610 (find_before_next_newline, search_command, Freplace_match)
2611 (Fmatch_data): Make some `int' variables be EMACS_INT.
2613 * xdisp.c (display_count_lines): 3rd argument and return value now
2614 EMACS_INT. All callers changed.
2615 (pint2hrstr): Last argument is now EMACS_INT.
2617 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2618 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2619 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2620 (decode_coding_utf_16, decode_coding_emacs_mule)
2621 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2622 (decode_coding_ccl, decode_coding_charset)
2623 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2624 (decode_coding_iso_2022, decode_coding_emacs_mule)
2625 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2626 <char_offset, last_offset>: Declare EMACS_INT.
2627 (encode_coding_utf_8, encode_coding_utf_16)
2628 (encode_coding_emacs_mule, encode_invocation_designation)
2629 (encode_designation_at_bol, encode_coding_iso_2022)
2630 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2631 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2633 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2634 (encode_invocation_designation): Last argument P_NCHARS is now
2636 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2637 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2639 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2642 * ccl.c (Fccl_execute_on_string): Declare some variables
2645 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2647 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2649 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2651 * process.c (Fformat_network_address): Doc fix.
2653 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2655 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2657 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2659 * keyboard.c (read_char): Call Lisp function help-form-show,
2660 instead of using internal_with_output_to_temp_buffer.
2661 (Qhelp_form_show): New var.
2662 (syms_of_keyboard): Use DEFSYM macro.
2664 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2666 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2668 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2670 * process.c (Flist_processes): Remove to Lisp.
2671 (list_processes_1): Delete.
2673 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2675 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2677 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2679 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2681 Fix more problems found by GCC 4.6.0's static checks.
2683 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2685 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2687 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2689 * xdisp.c (vmessage): Mark as a printf-like function.
2691 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2693 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2695 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2696 printf-like functions.
2697 (tiff_load): Add casts to remove these marks before passing them
2698 to system-supplied API.
2700 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2702 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2703 This avoids several warnings with gcc -Wstrict-overflow.
2704 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2705 directly, rather than having caller test rule sign. This avoids
2706 some unnecessary tests.
2707 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2708 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2709 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2711 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2712 (xfont_open): Avoid unnecessary tests.
2714 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2716 * composite.h, composite.c (composition_gstring_put_cache):
2717 Use EMACS_INT, not int, for length.
2719 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2720 breaking out part of COMPOSITION_DECODE_RULE.
2721 (COMPOSITION_DECODE_RULE): Use it.
2722 * composite.c (get_composition_id): Remove unused local vars,
2723 by using the new macro.
2725 * textprop.c (set_text_properties_1): Change while to do-while,
2726 since the condition is always true at first.
2728 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2729 (interval_deletion_adjustment): Return unsigned value.
2732 * process.c (list_processes_1, create_pty, read_process_output):
2733 (exec_sentinel): Remove vars that were set but not used.
2734 (create_pty): Remove unnecessary "volatile"s.
2735 (Fnetwork_interface_info): Avoid possibility of int overflow.
2736 (read_process_output): Do adaptive read buffering even if carryover.
2737 (read_process_output): Simplify nbytes computation if buffered.
2739 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2741 * syntax.c (scan_words): Remove var that was set but not used.
2742 (update_syntax_table): Use unsigned instead of int.
2744 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2745 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2746 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2748 * print.c (print_error_message): Avoid int overflow.
2750 * font.c (font_list_entities): Redo for clarity,
2751 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2753 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2754 (font_score): Avoid potential overflow in diff calculation.
2756 * fns.c (substring_both): Remove var that is set but not used.
2757 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2759 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2761 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2762 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2763 can always succeed if overflow has undefined behavior.
2765 * search.c (boyer_moore, wordify): Remove vars set but not used.
2766 (wordify): Omit three unnecessary tests.
2768 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2769 All callers changed. This avoids the need for an unused var.
2771 * casefiddle.c (casify_region): Remove var that is set but not used.
2773 * dired.c (file_name_completion): Remove var that is set but not used.
2775 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2777 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2778 (Finsert_file_contents): Remove unnecessary code checking fd.
2780 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2781 Check for integer overflow on size calculations.
2783 * buffer.c (Fprevious_overlay_change): Remove var that is set
2786 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2787 Remove vars that are set but not used.
2788 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2789 (timer_check_2): Mark vars as initialized.
2791 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2793 * image.c (lookup_image): Remove var that is set but not used.
2794 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2796 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2797 that are set but not used.
2799 * xfns.c (make_invisible_cursor): Don't return garbage
2800 if XCreateBitmapFromData fails (Bug#8410).
2802 * xselect.c (x_get_local_selection, x_handle_property_notify):
2803 Remove vars that are set but not used.
2805 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2806 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2808 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2809 Remove var that is set but not used.
2810 (scroll_bar_windows_size): Now size_t, not int.
2811 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2814 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2815 (map_tty_color) [!defined MSDOS]: Likewise.
2817 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2819 * coding.c: Remove vars that are set but not used.
2820 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2821 All callers changed.
2822 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2823 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2824 (decode_coding_charset): Remove vars that are set but not used.
2826 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2827 that is set but not used.
2829 * print.c (print_object): Remove var that is set but not used.
2831 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2832 The gnulib version avoids calling malloc in the usual case,
2833 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2834 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2835 * filelock.c (current_lock_owner): Likewise.
2836 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2837 * sysdep.c: Include allocator.h, careadlinkat.h.
2838 (emacs_no_realloc_allocator): New static constant.
2839 (emacs_readlink): New function.
2840 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2841 ../lib/careadlinkat.h.
2843 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2845 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2846 first non-nil return value).
2848 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2850 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2851 if not defined (Bug#8403).
2853 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2855 * xdisp.c (display_count_lines): Remove parameter `start',
2856 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2857 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2858 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2859 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2860 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2861 and thereabouts. All callers changed.
2862 (get_per_char_metric): Remove parameter `f', unused since
2863 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2865 2011-04-02 Jim Meyering <meyering@redhat.com>
2867 do not dereference NULL upon failed strdup
2868 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2869 (ns_get_family): Likewise.
2871 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2873 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2875 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2877 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2880 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2882 Add lexical binding.
2884 * window.c (Ftemp_output_buffer_show): New fun.
2885 (Fsave_window_excursion):
2886 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2888 * lread.c (lisp_file_lexically_bound_p): New function.
2889 (Fload): Bind Qlexical_binding.
2890 (readevalloop): Remove `evalfun' arg.
2891 Bind Qinternal_interpreter_environment.
2892 (Feval_buffer): Bind Qlexical_binding.
2893 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2895 (syms_of_lread): Declare `lexical-binding'.
2897 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2899 * keyboard.c (eval_dyn): New fun.
2900 (menu_item_eval_property): Use it.
2902 * image.c (parse_image_spec): Use Ffunctionp.
2904 * fns.c (concat, mapcar1): Accept byte-code-functions.
2906 * eval.c (Fsetq): Handle lexical vars.
2907 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2908 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2909 (FletX, Flet): Obey lexical binding.
2910 (Fcommandp): Handle closures.
2911 (Feval): New `lexical' arg.
2912 (eval_sub): New function extracted from Feval. Use it almost
2913 everywhere where Feval was used. Look up vars in lexical env.
2915 (Ffunctionp): Move from subr.el.
2916 (Ffuncall): Handle closures.
2917 (apply_lambda): Remove `eval_flags'.
2918 (funcall_lambda): Handle closures and new byte-code-functions.
2919 (Fspecial_variable_p): New function.
2920 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2921 but without exporting it to Lisp.
2923 * doc.c (Fdocumentation, store_function_docstring):
2924 * data.c (Finteractive_form): Handle closures.
2926 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2929 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2931 (exec_byte_code): New function extracted from Fbyte_code to handle new
2932 calling convention for byte-code-functions. Add new byte-codes.
2934 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2936 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2938 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2940 * xdisp.c (redisplay_internal): Fix prototype.
2942 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2944 * xdisp.c (SCROLL_LIMIT): New macro.
2945 (try_scrolling): Use it when setting scroll_limit.
2946 Limit scrolling to 100 screen lines.
2947 (redisplay_window): Even when falling back on "recentering",
2948 position point in the window according to scroll-conservatively,
2949 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2951 (try_scrolling): When point is above the window, allow searching
2952 as far as scroll_max, or one screenful, to compute vertical
2953 distance from PT to the scroll margin position. This prevents
2954 try_scrolling from unnecessarily failing when
2955 scroll-conservatively is set to a value slightly larger than the
2956 window height. Clean up the case of PT below the margin at bottom
2957 of window: scroll_max can no longer be INT_MAX. When aggressive
2958 scrolling is in use, don't let point enter the opposite scroll
2959 margin as result of the scroll.
2960 (syms_of_xdisp) <scroll-conservatively>: Document the
2961 threshold of 100 lines for never-recentering scrolling.
2963 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2965 * dispextern.h (move_it_by_lines):
2966 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2967 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2968 (message_log_check_duplicate): Remove parameters `prev_bol' and
2969 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2970 (redisplay_internal): Remove parameter `preserve_echo_area',
2971 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2973 * indent.c (Fvertical_motion):
2974 * window.c (window_scroll_pixel_based, Frecenter):
2975 Don't pass `need_y_p' to `move_it_by_lines'.
2977 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2979 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2980 steal a few bits to be more compact.
2981 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2982 Remove unneeded casts.
2984 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2986 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2988 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2989 binding" message (bug#7967).
2991 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2993 Fix more problems found by GCC 4.6.0's static checks.
2995 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2996 Remove unused local var.
2998 * editfns.c (Fmessage_box): Remove unused local var.
3000 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3001 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3002 Omit unused local vars.
3003 * window.c (shrink_windows): Omit unused local var.
3004 * menu.c (digest_single_submenu): Omit unused local var.
3005 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3006 Omit unused local var.
3008 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3009 Don't assume string length fits in int.
3010 (keyremap_step, read_key_sequence): Use size_t for sizes.
3011 (read_key_sequence): Don't check last_real_key_start redundantly.
3013 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3014 instead of alloca (Bug#8344).
3016 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3017 (Fbacktrace_frame): Don't assume nframes fits in int.
3019 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3021 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3024 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3026 * cm.c (calccost): Turn while-do into do-while, for clarity.
3028 * keyboard.c (syms_of_keyboard): Use the same style as later
3029 in this function when indexing through an array. This also
3030 works around GCC bug 48267.
3032 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3034 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3036 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3037 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3039 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3040 This avoids undefined behavior on integer overflow, and is a bit
3041 more convenient anyway since it is compared to a size_t variable.
3043 Variadic C functions now count arguments with size_t, not int.
3044 This avoids an unnecessary limitation on 64-bit machines, which
3045 caused (substring ...) to crash on large vectors (Bug#8344).
3046 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3047 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3048 All variadic functions and their callers changed accordingly.
3049 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3050 * data.c (arith_driver, float_arith_driver): Likewise.
3051 * editfns.c (general_insert_function): Likewise.
3052 * eval.c (struct backtrace.nargs, interactive_p)
3053 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3054 (funcall_lambda, mark_backtrace): Likewise.
3055 * fns.c (concat): Likewise.
3056 * frame.c (x_set_frame_parameters): Likewise.
3057 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3058 0 if not found, not -1. All callers changed.
3060 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3061 (stack_copy_size): Now size_t, not int.
3062 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3064 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3066 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3067 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3068 All callers changed.
3070 * lisp.h (multibyte_char_to_unibyte):
3071 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3072 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3073 * character.h (CHAR_TO_BYTE8):
3074 * cmds.c (internal_self_insert):
3075 * editfns.c (general_insert_function):
3076 * keymap.c (push_key_description):
3077 * search.c (Freplace_match):
3078 * xdisp.c (message_dolog, set_message_1): All callers changed.
3080 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3082 * keyboard.c (safe_run_hook_funcall): New function.
3083 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3084 don't set the hook to nil, but remove the offending function instead.
3085 (Qcommand_hook_internal): Remove, unused.
3086 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3087 Vcommand_hook_internal.
3089 * eval.c (enum run_hooks_condition): Remove.
3090 (funcall_nil, funcall_not): New functions.
3091 (run_hook_with_args): Call each function through a `funcall' argument.
3092 Remove `cond' argument, now redundant.
3093 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3094 (Frun_hook_with_args_until_failure): Adjust accordingly.
3095 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3097 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3099 * dispextern.h (string_buffer_position): Remove declaration.
3101 * print.c (strout): Remove parameter `multibyte', unused since
3102 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3104 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3105 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3106 All callers changed.
3108 * w32.c (_wsa_errlist): Use braces for struct initializers.
3110 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3111 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3112 All callers changed.
3113 (string_buffer_position): Likewise. Also, make static (it's never
3114 used outside xdisp.c).
3115 (cursor_row_p): Remove parameter `w', unused since
3116 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3117 (decode_mode_spec): Remove parameter `precision', introduced during
3118 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3119 All callers changed.
3121 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3123 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3125 2011-03-27 Anders Lindgren <andlind@gmail.com>
3127 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3128 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3129 (ns_update_auto_hide_menu_bar): New functions.
3130 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3131 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3132 ns_constrain_all_frames.
3133 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3134 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3136 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3138 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3140 2011-03-27 Glenn Morris <rgm@gnu.org>
3142 * syssignal.h: Replace RETSIGTYPE with void.
3143 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3144 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3145 Replace SIGTYPE with void everywhere.
3146 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3147 * s/template.h (SIGTYPE): Remove commented out definition.
3149 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3152 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3154 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3156 * w32.c (read_unc_volume): Use parameter `henum', instead of
3157 global variable `wget_enum_handle'.
3159 * keymap.c (describe_vector): Remove parameters `indices' and
3160 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3161 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3163 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3165 * keyboard.c (timer_check): Remove parameter `do_it_now',
3166 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3167 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3168 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3170 * keyboard.c (read_char):
3171 * w32menu.c (w32_menu_display_help):
3172 * xmenu.c (show_help_event, menu_help_callback):
3173 Adjust calls to `show_help_echo'.
3175 * gtkutil.c (xg_maybe_add_timer):
3176 * keyboard.c (readable_events):
3177 * process.c (wait_reading_process_output):
3178 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3180 * insdel.c (adjust_markers_gap_motion):
3181 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3182 (gap_left, gap_right): Don't call it.
3184 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3186 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3187 incurred during fontification.
3189 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3191 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3192 (DEFVAR_PER_BUFFER): Don't pass it.
3194 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3195 (scrolling_window): Don't pass it.
3197 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3199 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3201 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3203 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3204 of variables specific to SELinux and computation of `encoded_absname'.
3206 * image.c (XPutPixel): Remove unused variable `height'.
3208 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3210 * unexw32.c (get_section_info): Remove unused variable `section'.
3212 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3213 (system_process_attributes): Remove unused variable `sess'.
3214 (sys_read): Remove unused variable `err'.
3216 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3217 (w32_wnd_proc): Remove unused variable `isdead'.
3218 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3219 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3220 (x_create_tip_frame): Remove unused variable `tem'.
3222 * w32inevt.c (w32_console_read_socket):
3223 Remove unused variable `no_events'.
3225 * w32term.c (x_draw_composite_glyph_string_foreground):
3226 Remove unused variable `width'.
3228 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3230 * w32term.c (x_set_glyph_string_clipping):
3231 Don't pass uninitialized region to CombineRgn.
3233 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3235 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3236 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3237 (Fx_close_connection): Remove unused variable `i'.
3239 * w32font.c (w32font_draw): Return number of glyphs.
3240 (w32font_open_internal): Remove unused variable `i'.
3241 (w32font_driver): Add missing initializer.
3243 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3244 (fill_in_menu): Remove unused variable `items_added'.
3246 * w32term.c (last_mouse_press_frame): Remove static global variable.
3247 (w32_clip_to_row): Remove unused variable `f'.
3248 (x_delete_terminal): Remove unused variable `i'.
3250 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3251 (NOTHING): Remove unused static global variable.
3252 (uniscribe_check_otf): Remove unused variable `table'.
3253 (uniscribe_font_driver): Add missing initializers.
3255 2011-03-23 Julien Danjou <julien@danjou.info>
3257 * term.c (Fsuspend_tty, Fresume_tty):
3258 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3259 * window.c (temp_output_buffer_show):
3260 * insdel.c (signal_before_change):
3261 * frame.c (Fhandle_switch_frame):
3262 * fileio.c (Fdo_auto_save):
3263 * emacs.c (Fkill_emacs):
3264 * editfns.c (save_excursion_restore):
3265 * cmds.c (internal_self_insert):
3266 * callint.c (Fcall_interactively):
3267 * buffer.c (Fkill_all_local_variables):
3268 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3270 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3271 unconditionnaly since it does the check itself.
3273 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3275 Fix more problems found by GCC 4.5.2's static checks.
3277 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3278 the first time through the loop, since we know p0 < p1 then.
3279 This also avoids a gcc -Wstrict-overflow warning.
3281 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3282 leading to a memory leak, possible in functions like
3283 load_charset_map_from_file that can allocate an unbounded number
3284 of objects (Bug#8318).
3286 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3287 that could (at least in theory) be that large.
3289 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3290 This is less likely to overflow, and avoids undefined behavior if
3291 overflow does occur. All callers changed. Use strtoul to scan
3292 for the unsigned long integer.
3293 (pint2hrstr): Simplify and tune code slightly.
3294 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3296 * scroll.c (do_scrolling): Work around GCC bug 48228.
3297 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3299 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3300 This also avoids a warning with gcc -Wstrict-overflow.
3301 (validate_x_resource_name): Simplify count usage.
3302 This also avoids a warning with gcc -Wstrict-overflow.
3304 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3307 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3309 * process.c (Fmake_network_process): Use socklen_t, not int,
3310 where POSIX says socklen_t is required in portable programs.
3311 This fixes a porting bug on hosts like 64-bit HP-UX, where
3312 socklen_t is wider than int (Bug#8277).
3313 (Fmake_network_process, server_accept_connection):
3314 (wait_reading_process_output, read_process_output):
3317 * process.c: Rename or move locals to avoid shadowing.
3318 (list_processes_1, Fmake_network_process):
3319 (read_process_output_error_handler, exec_sentinel_error_handler):
3320 Rename or move locals.
3321 (Fmake_network_process): Define label "retry_connect" only if needed.
3322 (Fnetwork_interface_info): Fix pointer signedness.
3323 (process_send_signal): Add cast to avoid pointer signedness problem.
3324 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3325 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3327 Make tparam.h and terminfo.c consistent.
3328 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3329 Include tparam.h instead, since it declares them.
3330 * cm.h (PC): Remove extern decl; tparam.h now does this.
3331 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3332 * terminfo.c: Include tparam.h, to check interfaces.
3333 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3334 (tparam): Adjust signature to match interface in tparam.h;
3335 this removes some undefined behavior. Check that outstring and len
3336 are zero, which they always are with Emacs.
3337 * tparam.h (PC, BC, UP): New extern decls.
3339 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3340 (xftfont_open): Rename locals to avoid shadowing.
3342 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3343 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3344 (OTF_TAG_SYM): Omit macro if not needed.
3345 (ftfont_list): Remove unused local.
3346 (get_adstyle_property, ftfont_pattern_entity):
3347 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3348 Rename locals to avoid shadowing.
3350 * xfont.c (xfont_list_family): Mark var as initialized.
3352 * xml.c (make_dom): Now static.
3354 * composite.c (composition_compute_stop_pos): Rename local to
3356 (composition_reseat_it): Remove unused locals.
3357 (find_automatic_composition, composition_adjust_point): Likewise.
3358 (composition_update_it): Mark var as initialized.
3359 (find_automatic_composition): Mark vars as initialized,
3360 with a FIXME (Bug#8290).
3362 character.h: Rename locals to avoid shadowing.
3363 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3364 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3365 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3366 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3369 * textprop.c (property_change_between_p): Remove; unused.
3371 * intervals.c (interval_start_pos): Now static.
3373 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3375 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3376 Rename locals to avoid shadowing.
3378 * sound.c (wav_play, au_play, Fplay_sound_internal):
3379 Fix pointer signedness.
3380 (alsa_choose_format): Remove unused local var.
3381 (wav_play): Initialize a variable to 0, to prevent undefined
3382 behavior (Bug#8278).
3384 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3386 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3389 clobbering (Bug#8298).
3390 * sysdep.c (sys_subshell): Likewise.
3391 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3393 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3394 This should get cleaned up, so that child_setup has the
3395 same signature on all platforms.
3397 * callproc.c (call_process_cleanup): Now static.
3398 (relocate_fd): Rename locals to avoid shadowing.
3400 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3402 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3403 not to be necessary, and produces flickering.
3405 2011-03-20 Glenn Morris <rgm@gnu.org>
3407 * config.in: Remove file.
3409 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3411 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3412 are now in src/globals.h.
3413 (syms_of_minibuf): Remove spurious & from previous change.
3415 2011-03-20 Leo <sdl.web@gmail.com>
3417 * minibuf.c (completing-read-function): New variable.
3418 (completing-read-default): Rename from completing-read.
3419 (completing-read): Call completing-read-function.
3421 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3423 * xfaces.c (Fx_load_color_file):
3424 Read color file from absolute filename (bug#8250).
3426 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3428 * makefile.w32-in: Update dependencies.
3430 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3432 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3434 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3436 Fix more problems found by GCC 4.5.2's static checks.
3438 * process.c (make_serial_process_unwind, send_process_trap):
3439 (sigchld_handler): Now static.
3441 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3442 That way, the code declares only the vars that it needs.
3443 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3444 * s/cygwin.h (PTY_ITERATION): Likewise.
3445 * s/darwin.h (PTY_ITERATION): Likewise.
3446 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3448 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3449 * process.c (allocate_pty): Don't declare stb unless it's needed.
3451 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3452 (CONSTANTLIM): Remove; unused.
3453 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3454 Define only if needed.
3456 * unexelf.c (unexec): Name an expression,
3457 to avoid gcc -Wbad-function-cast warning.
3458 Use a different way to cause a compilation error if anyone uses
3459 n rather than nn, a way that does not involve shadowing.
3460 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3462 * deps.mk (unexalpha.o): Remove; unused.
3464 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3465 * unexec.h: New file.
3466 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3467 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3469 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3470 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3471 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3472 Change as necessary to match prototype in unexec.h.
3474 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3476 (back_comment, skip_chars): Mark vars as initialized.
3478 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3479 Rename locals to avoid shadowing.
3481 * lread.c (read1): Rewrite so as not to use empty "else".
3482 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3484 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3486 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3487 warning when compiling print.c.
3489 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3490 instead of using an uninitialized var.
3491 (font_sort_entities): Mark var as initialized.
3493 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3495 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3496 pointers to constants.
3497 (font_parse_fcname): Remove unused vars.
3498 (font_delete_unmatched): Now static.
3499 (font_get_spec): Remove; unused.
3500 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3501 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3502 Rename or move locals to avoid shadowing.
3504 * fns.c (require_nesting_list, require_unwind): Now static.
3505 (Ffillarray): Rename locals to avoid shadowing.
3507 * floatfns.c (domain_error2): Define only if needed.
3508 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3510 * alloc.c (mark_backtrace): Move decl from here ...
3511 * lisp.h: ... to here, so that it can be checked.
3513 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3514 (Fdefvar): Rewrite so as not to use empty "else".
3515 (lisp_indirect_variable): Name an expression,
3516 to avoid gcc -Wbad-function-cast warning.
3517 (Fdefvar): Rename locals to avoid shadowing.
3519 * callint.c (quotify_arg, quotify_args): Now static.
3520 (Fcall_interactively): Rename locals to avoid shadowing.
3521 Use const pointer when appropriate.
3523 * lisp.h (get_system_name, get_operating_system_release):
3524 Move decls here, to check interfaces.
3525 * process.c (get_operating_system_release): Move decl to lisp.h.
3526 * xrdb.c (get_system_name): Likewise.
3527 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3528 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3529 some of which prompt warnings from gcc -Wbad-function-cast.
3530 (Fformat_time_string, Fencode_time, Finsert_char):
3531 (Ftranslate_region_internal, Fformat):
3532 Rename or remove local vars to avoid shadowing.
3533 (Ftranslate_region_internal): Mark var as initialized.
3535 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3538 * lisp.h (eassert): Check that the argument compiles, even if
3539 ENABLE_CHECKING is not defined.
3541 * data.c (Findirect_variable): Name an expression, to avoid
3542 gcc -Wbad-function-cast warning.
3543 (default_value, arithcompare, arith_driver, arith_error): Now static.
3544 (store_symval_forwarding): Rename local to avoid shadowing.
3545 (Fmake_variable_buffer_local, Fmake_local_variable):
3546 Mark variables as initialized.
3547 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3549 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3550 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3551 Rename locals to avoid shadowing.
3552 (mark_stack): Move local variables into the #ifdef region where
3554 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3555 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3557 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3558 (GC_STRING_CHARS): Remove; not used.
3559 (Fmemory_limit): Cast sbrk's returned value to char *.
3561 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3562 avoids undefined behavior in theory.
3564 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3566 Use functions, not macros, for up- and down-casing (Bug#8254).
3567 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3568 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3569 to use the following functions instead of these macros.
3570 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3571 EMACS_INT, since callers assume the returned value fits in int.
3572 (upcase1): Likewise, for UPCASE_TABLE.
3573 (uppercasep, lowercasep, upcase): New static inline functions.
3574 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3575 the race-condition problem in the old DOWNCASE.
3577 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3578 Rename locals to avoid shadowing.
3579 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3580 (regex_compile, re_search_2, re_match_2_internal):
3581 Remove unused local vars.
3582 (FREE_VAR): Rewrite so as not to use empty "else",
3583 which gcc can warn about.
3584 (regex_compile, re_match_2_internal): Mark locals as initialized.
3585 (RETALLOC_IF): Define only if needed.
3586 (WORDCHAR_P): Likewise. This one is never needed, but is used
3587 only in a comment talking about a compiler bug, so put inside
3588 the #if 0 of that comment.
3589 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3590 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3593 * search.c (boyer_moore): Rename locals to avoid shadowing.
3594 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3595 (PREV_CHAR_BOUNDARY): Likewise.
3597 * search.c (simple_search): Remove unused var.
3599 * dired.c (compile_pattern): Move decl from here ...
3600 * lisp.h: ... to here, so that it can be checked.
3601 (struct re_registers): New forward decl.
3603 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3605 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3607 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3608 Rename locals to avoid shadowing.
3609 (Fvertical_motion): Mark locals as initialized.
3611 * casefiddle.c (casify_object, casify_region): Now static.
3612 (casify_region): Mark local as initialized.
3614 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3616 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3617 New macros, so that the caller can use some names other than
3618 gcpro1, gcpro2, etc.
3619 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3621 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3622 argument, for consistency with GCPRO2_VAR, etc: it is now the
3623 prefix of the variable, not the variable itself. All uses
3625 * dired.c (directory_files_internal, file_name_completion):
3626 Rename locals to avoid shadowing.
3628 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3629 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3630 dired.c's scmp function, had undefined behavior.
3631 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3632 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3633 * buffer.h: ... to here, because these macros use current_buffer,
3634 and the new implementation with inline functions needs to have
3635 current_buffer in scope now, rather than later when the macros
3637 (downcase, upcase1): New static inline functions.
3638 (DOWNCASE, UPCASE1): Reimplement using these functions.
3639 This avoids undefined behavior in expressions like
3640 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3641 from race conditions in accessing the global variables
3642 case_temp1 and case_temp2.
3643 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3644 * lisp.h (case_temp1, case_temp2): Remove their decls.
3645 * character.h (ASCII_CHAR_P): Move from here ...
3646 * lisp.h: ... to here, so that the inline functions mentioned
3649 * dired.c (directory_files_internal_unwind): Now static.
3651 * fileio.c (file_name_as_directory, directory_file_name):
3652 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3654 (file_name_as_directory): Use const pointers when appropriate.
3655 (Fexpand_file_name): Likewise. In particular, newdir might
3656 point at constant storage, so make it a const pointer.
3657 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3658 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3660 (Fset_file_times, Finsert_file_contents, auto_save_error):
3661 Rename locals to avoid shadowing.
3663 * minibuf.c (choose_minibuf_frame_1): Now static.
3664 (Ftry_completion, Fall_completions): Rename or remove locals
3667 * marker.c (bytepos_to_charpos): Remove; unused.
3669 * lisp.h (verify_bytepos, count_markers): New decls,
3670 so that gcc does not warn that these functions aren't declared.
3672 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3673 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3674 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3675 (copy_text): Remove unused local var.
3677 * filelock.c (within_one_second): Now static.
3678 (lock_file_1): Rename local to avoid shadowing.
3680 * buffer.c (fix_overlays_before): Mark locals as initialized.
3681 (fix_start_end_in_overlays): Likewise. This function should be
3682 simplified by using pointers-to-pointers, but that's a different
3684 (switch_to_buffer_1): Now static.
3685 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3686 (report_overlay_modification): Rename locals to avoid shadowing.
3688 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3689 Fix pointer signedness issue.
3690 (sys_subshell): Mark local as volatile if checking for lint,
3691 to suppress a gcc -Wclobbered warning that does not seem to be right.
3692 (MAXPATHLEN): Define only if needed.
3694 * process.c (serial_open, serial_configure): Move decls from here ...
3695 * systty.h: ... to here, so that they can be checked.
3697 * fns.c (get_random, seed_random): Move extern decls from here ...
3698 * lisp.h: ... to here, so that they can be checked.
3700 * sysdep.c (reset_io): Now static.
3701 (wait_for_termination_signal): Remove; unused.
3703 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3704 (copy_keymap_item, append_key, push_text_char_description):
3706 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3707 (DENSE_TABLE_SIZE): Remove; unused.
3708 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3709 (describe_map_tree):
3710 Rename locals to avoid shadowing.
3712 * keyboard.c: Declare functions static if they are not used elsewhere.
3713 (echo_char, echo_dash, cmd_error, top_level_2):
3714 (poll_for_input, handle_async_input): Now static.
3715 (read_char, kbd_buffer_get_event, make_lispy_position):
3716 (make_lispy_event, make_lispy_movement, apply_modifiers):
3717 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3718 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3719 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3720 (read_key_sequence, read_char): Mark locals as initialized.
3721 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3723 * keyboard.h (make_ctrl_char): New decl.
3724 (mark_kboards): Move decl here ...
3725 * alloc.c (mark_kboards): ... from here.
3727 * lisp.h (force_auto_save_soon): New decl.
3729 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3730 (DEFINE_DUMMY_FUNCTION): New macro.
3731 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3733 (main): Add casts to avoid warnings
3734 if GCC considers string literals to be constants.
3736 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3738 * dbusbind.c: Pointer signedness fixes.
3739 (xd_signature, xd_append_arg, xd_initialize):
3740 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3741 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3742 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3743 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3745 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3746 if GCC considers string literals to be constants.
3747 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3749 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3751 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3752 (print_preprocess, print_object): New macro to fix last change.
3754 * print.c (print_preprocess): Don't forget font objects.
3756 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3758 * emacs.c (USAGE3): Doc fixes.
3760 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3762 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3765 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3767 * lisp.h (VWindow_system, Qfile_name_history):
3768 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3769 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3770 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3772 * w32select.c: Don't #include "keyboard.h".
3773 (run_protected): Add extern declaration for waiting_for_input.
3775 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3776 * w32console.c (detect_input_pending, read_input_pending)
3777 (encode_terminal_code):
3778 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3779 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3780 (w32_system_caret_y, Qfile_name_history):
3781 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3782 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3783 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3784 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3785 * w32proc.c (Qlocal, report_file_error):
3786 * w32term.c (Vwindow_system, updating_frame):
3787 * w32uniscribe.c (initialized, uniscribe_font_driver):
3788 Remove unneeded extern declarations.
3790 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3792 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3794 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3796 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3797 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3798 These macros can no longer be used for assignment.
3800 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3801 Assign struct members directly, instead of using BUF_BEGV etc.
3802 (record_buffer_markers, fetch_buffer_markers): New functions for
3803 recording and fetching special buffer markers.
3804 (set_buffer_internal_1, set_buffer_temp): Use them.
3806 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3808 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3810 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3811 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3813 * xdisp.c (hscroll_window_tree):
3814 (reconsider_clip_changes): Use PT instead of BUF_PT.
3816 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3818 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3819 $(EMACS_ROOT)/lib/intprops.h.
3821 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3823 Fix more problems found by GCC 4.5.2's static checks.
3825 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3826 to unsigned char * to avoid compiler diagnostic.
3827 (xg_free_frame_widgets): Make it clear that a local variable is
3828 needed only if USE_GTK_TOOLTIP.
3829 (gdk_window_get_screen): Make it clear that this macro is needed
3830 only if USE_GTK_TOOLTIP.
3831 (int_gtk_range_get_value): New function, which avoids a diagnostic
3832 from gcc -Wbad-function-cast.
3833 (xg_set_toolkit_scroll_bar_thumb): Use it.
3834 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3835 diagnostic from gcc -Wbad-function-cast.
3836 (get_utf8_string, xg_get_file_with_chooser):
3837 Rename locals to avoid shadowing.
3838 (create_dialog): Move locals to avoid shadowing.
3840 * xgselect.c (xg_select): Remove unused var.
3842 * image.c (four_corners_best): Mark locals as initialized.
3843 (gif_load): Initialize transparent_p to zero (Bug#8238).
3844 Mark another local as initialized.
3845 (my_png_error, my_error_exit): Mark with NO_RETURN.
3847 * image.c (clear_image_cache): Now static.
3848 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3849 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3850 (x_edge_detection): Remove unnecessary cast that
3851 gcc -Wbad-function-cast diagnoses.
3852 (gif_load): Fix pointer signedness.
3853 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3854 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3856 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3858 Improve quality of tests for time stamp overflow.
3859 For example, without this patch (encode-time 0 0 0 1 1
3860 1152921504606846976) returns the obviously-bogus value (-948597
3861 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3862 reports time overflow. See
3863 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3864 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3865 * editfns.c: Include limits.h and intprops.h.
3866 (TIME_T_MIN, TIME_T_MAX): New macros.
3867 (time_overflow): Move earlier, to before first use.
3868 (hi_time, lo_time): New functions, for an accurate test for
3870 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3871 (Fget_internal_run_time): Don't assume time_t fits in int.
3872 (make_time): Use list2 instead of Fcons twice.
3873 (Fdecode_time): More accurate test for out-of-range times.
3874 (check_tm_member): New function.
3875 (Fencode_time): Use it, to test for out-of-range times.
3876 (lisp_time_argument): Don't rely on undefined left-shift and
3877 right-shift behavior when checking for time stamp overflow.
3879 * editfns.c (time_overflow): New function, refactoring common code.
3880 (Fformat_time_string, Fdecode_time, Fencode_time):
3881 (Fcurrent_time_string): Use it.
3883 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3884 * dired.c (make_time): Move to ...
3885 * editfns.c (make_time): ... here.
3886 * systime.h: Note the move.
3888 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3890 * fringe.c (update_window_fringes): Remove unused variables.
3892 * unexmacosx.c (copy_data_segment): Also copy __got section.
3895 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3897 * termcap.c [MSDOS]: Include "msdos.h".
3898 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3899 Constify `char *' arguments and their references according to
3900 prototypes in tparam.h.
3902 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3904 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3905 Adapt all references accordingly.
3907 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3909 2011-03-11 Tom Tromey <tromey@redhat.com>
3911 * buffer.c (syms_of_buffer): Remove obsolete comment.
3913 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3915 * termhooks.h (encode_terminal_code): Declare prototype.
3917 * msdos.c (encode_terminal_code): Don't declare prototype.
3919 * term.c (encode_terminal_code): Now external again, used by
3920 w32console.c and msdos.c.
3922 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3923 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3925 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3927 Fix some minor problems found by GCC 4.5.2's static checks.
3929 * fringe.c (update_window_fringes): Mark locals as initialized
3931 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3933 * alloc.c (mark_fringe_data): Move decl from here ...
3934 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3935 to check its interface.
3936 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3938 * fontset.c (free_realized_fontset): Now static.
3939 (Fset_fontset_font): Rename local to avoid shadowing.
3940 (fontset_font): Mark local as initialized.
3941 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3943 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3945 * xselect.c (x_disown_buffer_selections): Remove; not used.
3946 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3947 (x_own_selection, Fx_disown_selection_internal): Rename locals
3949 (x_handle_dnd_message): Remove local to avoid shadowing.
3951 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3952 so that the caller can use some name other than gcpro1.
3953 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3954 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3955 (Fx_backspace_delete_keys_p):
3956 Use them to avoid shadowing, and rename vars to avoid shadowing.
3957 (x_decode_color, x_set_name, x_window): Now static.
3958 (Fx_create_frame): Add braces to silence GCC warning.
3959 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3960 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3961 Remove unused locals.
3962 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3963 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3964 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3967 * xterm.h (x_mouse_leave): New decl.
3969 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3970 Remove unused functions.
3971 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3972 (x_calc_absolute_position): Now static.
3973 (XTread_socket): Don't define label "out" unless it's used.
3974 Don't declare local "event" unless it's used.
3975 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3976 unless they are used.
3977 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3978 (x_fatal_error_signal): Remove; not used.
3979 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3980 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3981 (x_error_catcher, x_connection_closed, x_error_handler):
3982 (x_error_quitter, xembed_send_message, x_iconify_frame):
3983 (my_log_handler): Rename locals to avoid shadowing.
3984 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3985 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3987 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3988 Rename or move locals to avoid shadowing.
3989 (tty_defined_color, merge_face_heights): Now static.
3990 (free_realized_faces_for_fontset): Remove; not used.
3991 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3992 does not deduce is never used uninitialized.
3993 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3994 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3996 * terminal.c (store_terminal_param): Now static.
3998 * xmenu.c (menu_highlight_callback): Now static.
3999 (set_frame_menubar): Remove unused local.
4000 (xmenu_show): Rename parameter to avoid shadowing.
4001 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4002 since they might point to immutable storage.
4003 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4004 since it's unused otherwise.
4006 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4007 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4008 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4009 avoids a gcc -Wuninitialized diagnostic.
4010 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4011 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4012 does not deduce are never used uninitialized.
4014 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4016 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4017 * window.c (window_loop, size_window):
4018 (run_window_configuration_change_hook, enlarge_window): Likewise.
4020 * window.c (display_buffer): Now static.
4021 (size_window): Mark variables that gcc -Wuninitialized
4022 does not deduce are never used uninitialized.
4023 * window.h (check_all_windows): New decl, to forestall
4024 gcc -Wmissing-prototypes diagnostic.
4025 * dispextern.h (bidi_dump_cached_states): Likewise.
4027 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4029 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4031 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4032 and to avoid gcc -Wuninitialized warning.
4033 (load_charset_map): Mark variables that gcc -Wuninitialized
4034 does not deduce are never used uninitialized.
4035 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4037 * coding.c (coding_set_source, coding_set_destination):
4038 Use "else { /* comment */ }" rather than "else /* comment */;"
4039 for clarity, and to avoid gcc -Wempty-body warning.
4040 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4041 a block, when the outer 'i' will do.
4042 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4043 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4044 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4045 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4046 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4047 Rename locals to avoid shadowing.
4048 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4049 * coding.c (emacs_mule_char, encode_invocation_designation):
4050 Now static, since they're not used elsewhere.
4051 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4052 (decode_coding_object, encode_coding_object, detect_coding_system):
4053 (decode_coding_emacs_mule): Mark variables that gcc
4054 -Wuninitialized does not deduce are never used uninitialized.
4055 (detect_coding_iso_2022): Initialize a local variable that might
4056 be used uninitialized. Leave a FIXME because it's not clear that
4057 this initialization is needed. (Bug#8211)
4058 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4059 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4060 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4061 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4062 Remove unused macros.
4064 * category.c (hash_get_category_set): Remove unused local var.
4065 (copy_category_table): Now static, since it's not used elsewhere.
4066 * character.c (string_count_byte8): Likewise.
4068 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4069 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4071 * chartab.c (copy_sub_char_table): Now static, since it's not used
4073 (sub_char_table_ref_and_range, char_table_ref_and_range):
4074 Rename locals to avoid shadowing.
4075 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4077 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4078 (BIDI_BOB): Remove unused macro.
4080 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4081 deduce are never used uninitialized.
4082 * term.c (encode_terminal_code): Likewise.
4084 * term.c (encode_terminal_code): Now static. Remove unused local.
4086 * tparam.h: New file.
4087 * term.c, tparam.h: Include it.
4088 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4089 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4090 Move these decls to tparam.h, and make them agree with what
4091 is actually in tparam.c. The previous trick of using incompatible
4092 decls in different modules does not conform to the C standard.
4093 All callers of tparam changed to use tparam's actual API.
4094 * tparam.c (tparam1, tparam, tgoto):
4095 Use const pointers where appropriate.
4097 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4098 * cm.h (struct cm): Likewise.
4099 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4100 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4101 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4102 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4103 (turn_on_face, init_tty): Likewise.
4104 * termchar.h (struct tty_display_info): Likewise.
4106 * term.c (term_mouse_position): Rename local to avoid shadowing.
4108 * alloc.c (mark_ttys): Move decl from here ...
4109 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4111 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4113 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4115 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4117 * search.c (compile_pattern_1): Remove argument regp, unused since
4118 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4119 (compile_pattern): Don't pass it.
4121 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4123 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4124 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4126 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4128 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4130 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4131 gdk_window_get_screen, gdk_window_get_geometry,
4132 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4133 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4134 (xg_get_pixbuf_from_pixmap): New function.
4135 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4136 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4137 Call xg_get_pixbuf_from_pixmap instead of
4138 gdk_pixbuf_get_from_drawable.
4139 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4140 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4141 (xg_check_special_colors): Use GtkStyleContext and its functions
4143 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4144 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4145 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4146 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4147 Call gtk_widget_get_preferred_size.
4148 (xg_frame_resized): gdk_window_get_geometry only takes 5
4150 (xg_win_to_widget, xg_event_is_for_menubar):
4151 Call gdk_x11_window_lookup_for_display.
4152 (xg_set_widget_bg): New function.
4153 (delete_cb): New function.
4154 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4155 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4156 (xg_set_background_color): Call xg_set_widget_bg.
4157 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4158 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4159 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4160 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4162 (update_frame_tool_bar): Call gtk_widget_hide.
4163 (xg_initialize): Use GDK_KEY_g.
4165 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4167 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4169 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4170 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4171 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4173 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4175 * w32xfns.c (select_palette): Check success of RealizePalette against
4176 GDI_ERROR, not zero.
4178 See ChangeLog.11 for earlier changes.
4184 Copyright (C) 2011 Free Software Foundation, Inc.
4186 This file is part of GNU Emacs.
4188 GNU Emacs is free software: you can redistribute it and/or modify
4189 it under the terms of the GNU General Public License as published by
4190 the Free Software Foundation, either version 3 of the License, or
4191 (at your option) any later version.
4193 GNU Emacs is distributed in the hope that it will be useful,
4194 but WITHOUT ANY WARRANTY; without even the implied warranty of
4195 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4196 GNU General Public License for more details.
4198 You should have received a copy of the GNU General Public License
4199 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.