1 2011-11-06 Chong Yidong <cyd@gnu.org>
3 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9 (Fwindow_vscroll): Doc fix.
10 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
11 argument, since it makes no sense to pass a live window and for
12 consistency with window-child.
14 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
16 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
19 2011-11-05 Jason Rumney <jasonr@gnu.org>
21 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
22 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
24 (add_font_entity_to_list): Fix logic errors in mixed boolean and
25 bitwise arithmetic preventing use of unicode-sip and non-truetype
28 2011-11-05 Eli Zaretskii <eliz@gnu.org>
30 * s/ms-w32.h (fstat, stat, utime): Move redirections to
33 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
34 initialization code to keep similarity to xfns.c after changes
37 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
39 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
40 (unwind_create_frame): New function (Bug#9943).
41 (Fx_create_frame): Restructure code to be more similar to the one in
42 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
43 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
44 Move terminal->reference_count++ just before making the frame official
47 * nsterm.m (x_free_frame_resources): New function.
48 (x_destroy_window): Move code to x_free_frame_resources.
50 * xfns.c (unwind_create_frame): Fix comment.
51 (Fx_create_frame, x_create_tip_frame): Move
52 terminal->reference_count++ just before making the frame
53 official. Move initialization of image_cache_refcount and
54 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
56 2011-11-05 Eli Zaretskii <eliz@gnu.org>
58 Support MSVC build with newer versions of Visual Studio.
59 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
60 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
63 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
64 which are not supported by MSVC.
65 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
66 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
68 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
70 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
72 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
74 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
76 Support MSVC build with newer versions of Visual Studio.
77 * w32.c: Don't include w32api.h for MSVC.
78 (init_environment) [_MSC_VER]: Call sys_access, not _access.
80 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
81 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
82 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
83 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
85 (alloca) [_MSC_VER]: Define to _alloca.
87 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
89 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
91 2011-11-04 Eli Zaretskii <eliz@gnu.org>
93 * xdisp.c (note_mouse_highlight): If either of
94 previous/next-single-property-change returns nil, treat that as
95 the beginning or the end of the buffer. (Bug#9955)
97 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
99 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
100 label is not null (Bug#9951).
101 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
104 2011-11-04 Eli Zaretskii <eliz@gnu.org>
106 * window.c (Fwindow_body_size): Mention in the doc string that the
107 return value is in frame's canonical units. (Bug#9949)
109 2011-11-03 Eli Zaretskii <eliz@gnu.org>
111 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
113 * w32fns.c (unwind_create_frame): If needed, free the glyph
114 matrices of the partially constructed frame. (Bug#9943)
115 * xfns.c (unwind_create_frame): Likewise.
117 2011-11-01 Eli Zaretskii <eliz@gnu.org>
119 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
120 Don't stop backward scan on the continuation glyph, even though
121 its CHARPOS is positive.
122 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
123 cover_string to disp_string.
125 2011-11-01 Martin Rudalics <rudalics@gmx.at>
127 * window.c (temp_output_buffer_show): Don't use
128 Vtemp_buffer_show_specifiers.
129 (Vtemp_buffer_show_specifiers): Remove unused variable.
131 2011-10-30 Eli Zaretskii <eliz@gnu.org>
133 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
134 past the beginning of the current glyph matrix.
136 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
138 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
139 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
140 HAVE_GTK3 (Bug#9869).
142 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
143 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
145 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
147 * xterm.c: Declare x_handle_net_wm_state to return int.
148 (handle_one_xevent): Check if we are iconified but don't have
149 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
150 (get_current_wm_state): Return non-zero if not hidden,
151 check for _NET_WM_STATE_HIDDEN (Bug#9893).
152 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
153 (x_handle_net_wm_state): Return what get_current_wm_state returns.
154 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
156 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
158 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
159 so that this new function doesn't get optimized away by a
160 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
162 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
164 * frame.h (MOUSE_HL_INFO): Remove excess parens.
166 2011-10-29 Eli Zaretskii <eliz@gnu.org>
168 Fix the `xbytecode' command.
169 * .gdbinit (xprintbytestr): New command.
170 (xwhichsymbols): Renamed from `which'; all callers changed.
171 (xbytecode): Print the byte-code string as well.
173 2011-10-29 Kim Storm <storm@cua.dk>
175 * alloc.c (which_symbols): New function.
177 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
179 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
182 2011-10-29 Glenn Morris <rgm@gnu.org>
184 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
185 Not clear what it was for, and it causes various bugs. (Bug#9839)
187 2011-10-28 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
190 possible random value that matches one of those tested as
191 condition to clear the mouse face.
193 2011-10-28 Chong Yidong <cyd@gnu.org>
195 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
197 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
199 * window.c (make_window): Initialize phys_cursor_on_p.
201 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
203 * lisp.h (struct Lisp_Symbol): Update comments.
205 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
207 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
209 2011-10-28 Eli Zaretskii <eliz@gnu.org>
211 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
212 <oslsachem@gmail.com> for helping to debug this.
214 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
215 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
216 (g_b_init_get_glyph_outline_w): New static variables.
217 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
218 (GetGlyphOutlineW_Proc): New typedefs.
219 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
220 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
222 (w32font_open_internal, compute_metrics):
223 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
224 instead of calling the "wide" APIs directly.
226 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
228 * w32.h (syms_of_w32font): Add prototype.
230 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
232 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
233 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
234 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
235 (Fmove_to_window_line): Doc fix.
237 2011-10-27 Chong Yidong <cyd@gnu.org>
239 * process.c (make_process): Set gnutls_state to NULL.
241 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
242 non-NULL, regardless of GNUTLS_INITSTAGE.
243 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
244 an error. Set process slots as soon as we allocate them.
246 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
248 2011-10-27 Chong Yidong <cyd@gnu.org>
250 * gnutls.c (emacs_gnutls_deinit): New function.
251 Deallocate credentials structures as well as calling gnutls_deinit.
252 (Fgnutls_deinit, Fgnutls_boot): Use it.
254 * process.c (make_process): Initialize GnuTLS credentials to NULL.
255 (deactivate_process): Call emacs_gnutls_deinit.
257 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
259 * image.c (x_create_x_image_and_pixmap):
260 * w32.c (sys_rename, w32_delayed_load):
261 * w32font.c (fill_in_logfont):
262 * w32reg.c (x_get_string_resource): Silence compiler warnings.
264 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
266 * w32fns.c (w32_default_color_map): New function,
267 extracted from Fw32_default_color_map.
268 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
270 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
272 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
274 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
276 * keyboard.c (test_undefined): New function (bug#9751).
277 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
279 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
281 * sysdep.c (init_sys_modes): Fix the check for the controlling
284 2011-10-20 Eli Zaretskii <eliz@gnu.org>
286 * dispextern.h (struct bidi_it): New member next_en_type.
288 * bidi.c (bidi_line_init): Initialize the next_en_type member.
289 (bidi_resolve_explicit_1): When next_en_pos is valid for the
290 current character, check also for next_en_type being WEAK_EN.
291 (bidi_resolve_weak): Don't enter the expensive loop if the current
292 position is before next_en_pos. Record the bidi type of the first
293 non-ET, non-BN character we find, in addition to its position.
294 (bidi_level_of_next_char): Invalidate next_en_type when
295 next_en_pos is over-stepped.
297 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
299 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
300 * editfns.c: Rewrite current-time-zone so that it invokes
301 the equivalent of (format-time-string "%Z") to get the time zone name.
302 This fixes a bug when the time zone name contains characters that
303 need converting from the system time locale to Emacs internal format.
304 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
305 that patch fixed format-time-string to do the conversion, but
306 I forgot to fix current-time-zone.
307 (format_time_string): New function, containing most of
308 what Fformat_time_string used to contain.
309 (Fformat_time_string): Rewrite in terms of format_time_string.
310 This doesn't change this function's behavior.
311 (current-time-zone): Rewrite to use format_time_string.
312 This fixes the bug reported by Michael Schierl in
313 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
314 Jason Rumney's 2007-06-07 change worked around this bug, but
316 * systime.h (tzname, timezone): Remove no-longer-used declarations.
318 2011-10-19 Eli Zaretskii <eliz@gnu.org>
320 * xdisp.c (start_display): If the character at POS is displayed
321 via a display vector, reset IT->current.dpvec_index to zero.
322 (try_window_reusing_current_matrix): If a line ends in a display
323 vector or the next line starts in a display vector, continue
324 redrawing the window even though the character position of
325 start_row was reached.
328 2011-10-18 Chong Yidong <cyd@gnu.org>
330 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
331 with nobreak-char-display too.
333 2011-10-18 Eli Zaretskii <eliz@gnu.org>
335 Fix part 3 of bug#9771.
336 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
337 (bidi_resolve_neutral): Don't enter the expensive loop looking for
338 non-neutral characters if the current character is a paragraph
339 separator (a.k.a. Newline). This avoids running the same
340 expensive loop twice, once when we consume the preceding newline
341 and the other time when the line actually needs to be displayed.
342 Avoid the loop when we see neutrals on the base embedding level
343 following a character whose directionality is the same as the
344 paragraph's. This avoids running the expensive loop when a line
345 ends in a long sequence of neutrals, like control characters.
346 Add assertion against STRONG_AL type. Slightly rearrange code
347 that determines the type of a neutral given the first non-neutral
349 (bidi_level_of_next_char): Set next_en_pos to zero when
350 invalidating its info.
352 2011-10-17 Eli Zaretskii <eliz@gnu.org>
354 * xdisp.c (push_display_prop): Determine whether to record string
355 or buffer position by IT->string, not by IT->method. Allow
356 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
357 (move_it_vertically_backward): Don't look for character position
358 immediately after the newline when in a continuation line.
361 2011-10-15 Martin Rudalics <rudalics@gmx.at>
363 * window.c (coordinates_in_window): Rewrite and delabelize
364 vertical border check. (Bug#5357) (Bug#9618)
366 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
368 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
369 errors in XSetWindowBorder (bug#9310).
371 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
373 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
374 avoid crash when xmalloc overrun checking is enabled.
376 2011-10-13 Eli Zaretskii <eliz@gnu.org>
378 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
379 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
380 cursor motion with <left> and <right> arrow keys.
382 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
383 some callers set that themselves.
385 2011-10-12 Eli Zaretskii <eliz@gnu.org>
387 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
388 display string and the previous row comes from the same string and
389 is empty. (Bug#9739) (Bug#9738)
391 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
393 * doc.c (get_doc_string): Encode file name (bug#9735).
395 2011-10-12 Eli Zaretskii <eliz@gnu.org>
397 * bidi.c (bidi_level_of_next_char):
398 * xdisp.c (get_visually_first_element): Remove old incorrect
399 comments regarding the Unicode Line Separator character.
401 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
403 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
405 * alloc.c (Fgc_status): Do not access beyond zombies array
406 boundary if nzombies > MAX_ZOMBIES.
407 * alloc.c (dump_zombies): Add missing format specifier.
409 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
411 * xdisp.c (set_cursor_from_row): Simplify conditionals,
412 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
414 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
415 Some packages use them to denote characters with modifiers.
417 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
419 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
420 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
421 matching a pp-number. Rename parameter var to var1.
423 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
425 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
427 2011-10-08 Glenn Morris <rgm@gnu.org>
429 * callint.c (Fcall_interactively): Give a more explicit error for the
430 'c' case with a non-character input. (Bug#8479)
432 2011-10-08 Eli Zaretskii <eliz@gnu.org>
434 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
436 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
437 lines that are hscrolled on the left.
439 * dispnew.c (buffer_posn_from_coords): Account for a possible
440 presence of header-line. (Bug#4426)
442 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
444 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
445 Don't advertise functionality which we discourage or doesn't work.
447 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
449 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
450 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
451 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
452 this makes Emacs dump core during garbage collection on rare
453 occasions. sizeof is obviously inferior to offsetof here, so
455 (GC_POINTER_ALIGNMENT): New macro.
456 (mark_memory): Omit 3rd (offset) arg; caller changed.
457 Don't assume EMACS_INT alignment is the same as pointer alignment.
459 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
461 * keyboard.c (read_key_sequence_remapped): New var.
462 (read_key_sequence): Compute remapping in the right buffer.
463 (command_loop_1): Use read_key_sequence's remapping directly.
465 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
467 * dired.c (file_name_completion): Don't expand file name.
468 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
469 before checking file name handler.
471 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
472 they've been requested explicitly (bug#9591).
474 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
476 * keymap.c (Fsingle_key_description): Use make_specified_string
477 instead of build_string to build string from push_key_description.
480 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
482 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
483 This fixes a Y2038 bug on 64-bit hosts.
484 * buffer.c (reset_buffer):
485 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
486 (Fclear_buffer_auto_save_failure):
487 Use 0, not -1, to represent an unset failure time, since time_t
490 Remove dependency on glibc malloc internals.
491 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
492 Move back here from lisp.h, but with their new implementations.
493 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
494 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
495 * charset.c (charset_table_init): New static var.
496 (syms_of_charset): Use it instead of xmalloc. This removes a
497 dependency on glibc malloc internals. See Eli Zaretskii's comment in
498 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
499 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
500 Move back to alloc.c.
501 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
502 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
504 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
506 * nsterm.m (windowDidResize): Call x_set_window_size only when
507 ns_in_resize is true. Otherwise set pixelwidth/height and
508 call change_frame_size (Bug#9628).
510 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
512 Port --enable-checking=all to Fedora 14 x86-64.
513 * charset.c (syms_of_charset): Also account for glibc malloc's
514 internal overhead when calculating the initial malloc maximum.
516 Port --enable-checking=all to Fedora 14 x86.
517 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
519 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
520 (overrun_check_realloc, overrun_check_free):
521 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
522 That way, xmalloc returns a properly-aligned pointer even if
523 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
524 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
525 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
526 into account when calculating the initial malloc maximum.
527 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
528 Move here from alloc.c, so that charset.c can use it too.
529 Properly align; the old code wasn't right for common 32-bit hosts
530 when configured with --enable-checking=all.
531 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
532 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
534 2011-09-29 Eli Zaretskii <eliz@gnu.org>
536 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
539 2011-09-28 Eli Zaretskii <eliz@gnu.org>
541 * xdisp.c (compute_display_string_end): If there's no display
542 string at CHARPOS, return -1.
544 * bidi.c (bidi_fetch_char): When compute_display_string_end
545 returns a negative value, treat the character as a normal
546 character not covered by a display string. (Bug#9624)
548 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
550 * lread.c (Fread_from_string): Fix typo in docstring.
552 2011-09-27 Eli Zaretskii <eliz@gnu.org>
554 * xdisp.c (handle_invisible_prop): If invisible text ends on a
555 newline, reseat the iterator instead of bidi-iterating there one
556 character at a time. (Bug#9610)
557 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
558 TO_CHARPOS if the bidi iterator is at base embedding level.
560 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
562 * lread.c (readevalloop): Use correct code for NBSP.
563 (read1): Likewise. (Bug#9608)
565 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
567 * dbusbind.c (Fdbus_register_signal): When service is not
568 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
570 2011-09-25 Glenn Morris <rgm@gnu.org>
572 * buffer.c (truncate-lines): Doc fix.
574 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
576 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
577 (Fset_window_next_buffers): Doc fix.
579 2011-09-24 Glenn Morris <rgm@gnu.org>
581 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
583 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
585 Fix minor problems found by static checking.
586 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
587 * indent.c (Fvertical_motion): Fix == vs = typo.
589 2011-09-24 Eli Zaretskii <eliz@gnu.org>
591 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
592 Default value is now t. Doc fix.
594 * indent.c (Fvertical_motion): Compute and apply the overshoot
595 logic when moving up, not only when moving down. Fix the
596 confusing name and values of the it_overshoot_expected variable;
597 logic changes accordingly. (Bug#9254) (Bug#9549)
599 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
600 CHARPOS is covered by a display string which includes newlines.
601 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
602 is covered by a display string with embedded newlines.
604 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
606 * dbusbind.c (Fdbus_register_signal): Add match rule to
607 Vdbus_registered_objects_table. (Bug#9581)
608 (Fdbus_register_method, Vdbus_registered_objects_table):
611 2011-09-24 Jim Meyering <meyering@redhat.com>
613 do not ignore write error for any output size
614 The previous change was incomplete.
615 While it makes emacs --batch detect the vast majority of stdout
616 write failures, errors were still ignored whenever the output size is
617 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
618 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
619 && echo FAIL: ignored write error
620 FAIL: ignored write error
621 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
622 && echo FAIL: ignored write error
623 FAIL: ignored write error
624 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
626 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
628 * emacs.c (Fkill_emacs): In noninteractive mode exit
629 non-successfully if a write error occurred on stdout. (Bug#9574)
631 2011-09-21 Eli Zaretskii <eliz@gnu.org>
633 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
636 * dispextern.h (struct it): Update the comment documenting what
639 2011-09-20 Eli Zaretskii <eliz@gnu.org>
641 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
642 a display string, extend search for cursor position to end of row.
643 (find_row_edges): If the row ends in a newline from a display
644 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
645 Handle the case of a display string with multiple newlines.
646 (Fcurrent_bidi_paragraph_direction): Fix search for previous
647 non-empty line. Fixes confusing cursor motion with arrow keys at
648 the beginning of a line that starts with whitespace.
650 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
652 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
655 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
657 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
660 2011-09-18 Eli Zaretskii <eliz@gnu.org>
662 * xdisp.c (display_line): Record maximum and minimum buffer
663 positions even if no glyphs were produced (e.g., by a zero-width
664 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
665 buffer positions that will be removed from the glyph row because
667 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
668 column is beyond frame width: don't subtract 1 "pixel" when
669 computing width of the stretch.
670 (reseat_at_next_visible_line_start): Undo the change made on
671 2011-09-17 that saved paragraph information and restored it after
672 the call to `reseat'. (Bug#9545)
674 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
676 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
677 and turn window cursor on if cleared (Bug#9415).
679 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
681 * search.c (boyer_moore): Take unibyte characters from pattern
682 literally. (Bug#9458)
684 2011-09-18 Eli Zaretskii <eliz@gnu.org>
686 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
688 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
690 Fix minor problem found by static checking.
691 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
692 initialized, to pacify gcc -Wuninitialized.
694 * fileio.c: Report proper errno when syscall falls.
695 (Finsert_file_contents): Save and restore errno,
696 so that report_file_error outputs the correct diagnostic.
697 (Fwrite_region) [CLASH_DETECTION]: Likewise.
699 2011-09-18 Eli Zaretskii <eliz@gnu.org>
701 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
703 2011-09-17 Eli Zaretskii <eliz@gnu.org>
705 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
706 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
708 2011-09-17 Eli Zaretskii <eliz@gnu.org>
710 * xdisp.c (reseat_at_next_visible_line_start): Keep information
711 about the current paragraph and restore it after the call to reseat.
713 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
714 (bidi_find_paragraph_start): Search back for paragraph beginning
715 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
716 (bidi_move_to_visually_next): Only trigger paragraph-related
717 computations when the last character is a newline or at EOB, not
718 just any NEUTRAL_B. (Bug#9470)
720 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
721 truncated lines if point is covered by a display string. (Bug#9524)
723 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
725 * xselect.c: Relax test for outgoing X longs (Bug#9498).
726 (cons_to_x_long): New function.
727 (lisp_data_to_selection_data): Use it. Correct the test for
728 short-versus-long data; it was negated. Break out of vector
729 loop, for efficiency, when a long datum is discovered.
731 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
733 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
735 2011-09-16 Eli Zaretskii <eliz@gnu.org>
737 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
738 GCC PR/17406) by declaring this function with external scope.
740 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
742 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
743 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
745 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
747 * editfns.c (Fformat): Correctly handle text properties on "%%".
749 2011-09-15 Eli Zaretskii <eliz@gnu.org>
751 * xterm.c (x_draw_composite_glyph_string_foreground):
752 * w32term.c (x_draw_composite_glyph_string_foreground):
753 * term.c (encode_terminal_code):
754 * composite.c (composition_update_it, get_composition_id):
755 * xdisp.c (get_next_display_element)
756 (fill_composite_glyph_string): Add comments about special meaning
757 of TAB characters in a composition.
759 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
761 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
762 This occurs when processing a multibyte format.
763 Problem reported by Wolfgang Jenker.
765 2011-09-15 Johan Bockgård <bojohan@gnu.org>
767 * xdisp.c (try_cursor_movement): Only check for exact match if
768 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
770 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
772 Remove unused external symbols.
773 * dispextern.h (calc_pixel_width_or_height): Remove decl.
774 * xdisp.c (calc_pixel_width_or_height): Now static.
775 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
776 * indent.c (check_display_width):
777 * w32term.c: Fix comment to match code.
778 * xterm.c, xterm.h (x_catching_errors): Remove.
780 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
782 * xselect.c: Use signed conversions more consistently (Bug#9498).
783 (selection_data_to_lisp_data): Assume incoming selection data are
784 signed integers, not unsigned. This is to be consistent with
785 outgoing selection data, which was modified to use signed integers
786 in as part of the fix to Bug#9196 in response to Jan D.'s comment
787 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
788 expects long, not unsigned long.
790 2011-09-14 Eli Zaretskii <eliz@gnu.org>
792 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
793 computation of loop end. Reported by Johan Bockgård
796 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
798 * frame.c (Fother_visible_frames_p): Function deleted.
800 2011-09-12 Eli Zaretskii <eliz@gnu.org>
802 * indent.c (compute_motion): Process display vector front to back
803 rather than the other way around. (Bug#2496)
805 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
807 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
809 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
811 * minibuf.c (Fread_from_minibuffer): Doc fix.
813 2011-09-11 Eli Zaretskii <eliz@gnu.org>
815 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
816 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
818 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
820 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
821 value for non-existent files.
823 2011-09-11 Eli Zaretskii <eliz@gnu.org>
825 * fileio.c (Finsert_file_contents): If the file cannot be opened,
826 set its "size" to -1. This will set the modtime_size field of
827 the corresponding buffer to -1, which is what
828 verify-visited-file-modtime expects for files that do not exist.
831 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
833 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
835 * lisp.h: ... from here. push_key_description is no longer
836 defined in keyboard.c, so its declaration should not be in
837 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
838 logically belongs with push_key_description.
840 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
842 * buffer.h: Include <sys/types.h> instead of <time.h>.
843 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
844 Problem reported by Herbert J. Skuhra.
846 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
848 * xml.c (parse_region): Make the parsing work for
849 non-comment-starting XML files again (bug#9144).
851 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
853 * image.c (gif_load): Fix calculation of bottom and right corner.
856 2011-09-10 Eli Zaretskii <eliz@gnu.org>
858 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
859 redisplay in small windows.
861 2011-09-09 Eli Zaretskii <eliz@gnu.org>
863 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
865 2011-09-08 Martin Rudalics <rudalics@gmx.at>
867 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
868 Operate on live windows only.
870 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
872 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
874 2011-09-07 Eli Zaretskii <eliz@gnu.org>
876 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
877 only under bidi iteration.
879 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
881 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
883 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
885 isnan: Fix porting problem to Solaris 10 with bundled gcc.
886 Without this fix, the command to link temacs failed due to an
887 undefined symbol __builtin_isnan. This is because
888 /usr/include/iso/math_c99.h #defines isnan(x) to
889 __builtin_isnan(x), but the bundled gcc, which identifies itself
890 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
892 * floatfns.c (isnan): #undef, and then #define to a clone of
894 (Fisnan): Always define, since it's always available now.
895 (syms_of_floatfns): Always define isnan at the Lisp level.
897 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
899 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
901 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
903 * fileio.c: Fix bugs with large file offsets (Bug#9428).
904 The previous code assumed that file offsets (off_t values) fit in
905 EMACS_INT variables, which is not true on typical 32-bit hosts.
906 The code messed up by falsely reporting buffer overflow in cases
907 such as (insert-file-contents "big" nil 1 2) into an empty buffer
908 when "big" contains more than 2**29 bytes, even though this
909 inserts just one byte and does not overflow the buffer.
910 (Finsert_file_contents): Store file offsets as off_t
911 values, not as EMACS_INT values. Check for overflow when
912 converting between EMACS_INT and off_t. When checking for
913 buffer overflow or for overlap, take the offsets into account.
914 Don't use EMACS_INT for small values where int suffices.
915 When checking for overlap, fix a typo: ZV was used where
916 ZV_BYTE was intended.
917 (Fwrite_region): Don't assume off_t fits into 'long'.
918 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
920 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
922 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
924 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
926 sprintf-related integer and memory overflow issues (Bug#9412).
928 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
929 (esprintf, exprintf, evxprintf): New functions.
930 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
931 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
932 (modify_event_symbol): Do not assume that the length of
933 name_alist_or_stem is safe to alloca and fits in int.
934 (Fexecute_extended_command): Likewise for function name and binding.
935 (Frecursion_depth): Wrap around reliably on integer overflow.
936 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
937 since some callers pass EMACS_INT values.
938 (Fsingle_key_description): Don't crash if symbol name contains more
939 than MAX_ALLOCA bytes.
940 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
941 (get_minibuffer): Arg is now EMACS_INT, not int.
942 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
943 (esprintf, exprintf, evxprintf): New decls.
944 * window.h (command_loop_level, minibuf_level): Reflect API changes.
946 * dbusbind.c (signature_cat): New function.
947 (xd_signature, Fdbus_register_signal):
948 Do not overrun buffer; instead, report string overflow.
950 * dispnew.c (add_window_display_history): Don't overrun buffer.
951 Truncate instead; this is OK since it's just a log.
953 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
954 even if the time zone offset is outlandishly large.
955 Don't mishandle offset == INT_MIN.
957 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
958 when creating daemon; the previous buffer-overflow check was incorrect.
960 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
961 which has the guts of the old verror function.
963 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
964 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
966 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
967 (font_unparse_xlfd): Don't blindly alloca long strings.
968 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
969 fits in int, when using sprintf. Use single snprintf to count
970 length of string rather than counting it via multiple sprintfs;
971 that's simpler and more reliable.
972 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
973 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
974 sprintf, in case result does not fit in int.
976 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
977 (fontset_from_font): Print it.
979 * frame.c (tty_frame_count): Now printmax_t, not int.
980 (make_terminal_frame, set_term_frame_name): Print it.
981 (x_report_frame_params): In X, window IDs are unsigned long,
982 not signed long, so print them as unsigned.
983 (validate_x_resource_name): Check for implausibly long names,
984 and don't assume name length fits in 'int'.
985 (x_get_resource_string): Don't blindly alloca invocation name;
986 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
989 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
990 (xg_check_special_colors, xg_set_geometry):
991 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
993 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
994 Use esprintf, not sprintf, in case result does not fit in int.
996 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
997 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
998 it as a large positive number.
999 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1000 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1002 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1003 in case result does not fit in int.
1005 * print.c (float_to_string): Detect width overflow more reliably.
1006 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1007 buffer overrun. Don't assume list length fits in 'int'. Treat
1008 print length of 0 as 0, not as infinity; to be consistent with other
1009 uses of print length in this function. Don't overflow print length
1010 index. Don't assume hash table size fits in 'long', or that
1011 vectorlike size fits in 'unsigned long'.
1013 * process.c (make_process): Use printmax_t, not int, to format
1014 process-name gensyms.
1016 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1018 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1019 to avoid potential buffer overrun.
1021 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1022 if X resource line is longer than 512 bytes.
1024 * xfns.c (x_window): Make sprintf buffer a bit bigger
1025 to avoid potential buffer overrun.
1027 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1029 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1031 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1033 Integer overflow fixes for scrolling, etc.
1034 Without these, Emacs silently mishandles large integers sometimes.
1035 For example, "C-u 4294967297 M-x recenter" was treated as if
1036 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1038 * xdisp.c (try_window_id): Check Emacs fixnum range before
1039 converting to 'int'.
1041 * window.c (window_scroll_line_based, Frecenter):
1042 Check that an Emacs fixnum is in range before assigning it to 'int'.
1043 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1044 values converted from Emacs fixnums.
1045 (Frecenter): Don't wrap around a line count if it is out of 'int'
1046 range; instead, treat it as an extreme value.
1047 (Fset_window_configuration, compare_window_configurations):
1048 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1050 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1051 that can exceed INT_MAX. Check that EMACS_INT value is in range
1052 before assigning it to the (possibly-narrower) index.
1053 (match_limit): Don't assume that a fixnum can fit in 'int'.
1055 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1058 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1059 (Fvertical_motion): Don't wrap around LINES values that don't fit
1060 in 'int'. Instead, treat them as extreme values. This is good
1061 enough for windows, which can't have more than INT_MAX lines anyway.
1063 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1065 * Require libxml/parser.h to avoid compilation warning.
1067 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1069 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1070 since this reportedly can destroy thread storage.
1072 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1074 * syntax.c (find_defun_start): Update all cache variables if
1075 exiting early (Bug#9401).
1077 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1079 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1081 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1082 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1083 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1085 * term.c (tty_append_glyph): New function.
1086 (produce_stretch_glyph): Static function and its prototype deleted.
1088 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1091 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1093 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1094 when checking :margin (Bug#9390).
1095 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1096 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1097 so that the name doesn't mislead. All uses changed.
1099 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1101 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1104 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1106 * xdisp.c (move_it_to): Don't bail out early when reaching
1107 position beyond to_charpos, if we are scanning backwards.
1108 (move_it_vertically_backward): When DY == 0, make sure we get to
1109 the first character in the line after the newline.
1111 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1113 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1114 (ccl_driver): Do not generate an out-of-range pointer.
1115 (Fccl_execute_on_string): Remove unnecessary check for
1116 integer overflow, noted by Stefan Monnier in
1117 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1118 Remove a FIXME that didn't need fixing.
1119 Simplify the newly-introduced buffer reallocation code.
1121 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1123 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1125 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1127 Integer and memory overflow issues (Bug#9196).
1129 * doc.c (get_doc_string): Rework so that
1130 get_doc_string_buffer_size is the actual buffer size, rather than
1131 being 1 less than the actual buffer size; this makes xpalloc more
1134 * image.c (x_allocate_bitmap_record, cache_image):
1135 * xselect.c (Fx_register_dnd_atom):
1136 Simplify previous changes by using xpalloc.
1138 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1139 since either will do and ptrdiff_t is convenient with xpalloc.
1141 * charset.c (charset_table_size)
1142 (struct charset_sort_data.priority): Now ptrdiff_t.
1143 (charset_compare): Don't overflow if priorities differ greatly.
1144 (Fsort_charsets): Don't assume list length fits in int.
1145 Check for size-calculation overflow when allocating sort data.
1146 (syms_of_charset): Allocate an initial charset table that is
1147 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1149 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1151 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1152 The actual value is always <= INT_MAX, and leaving it unsigned made
1153 overflow checking harder.
1155 * dispextern.h (struct glyph_matrix.rows_allocated)
1156 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1157 with xpalloc. The values are still always <= INT_MAX.
1159 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1161 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1162 (SAFE_NALLOCA): New macro.
1164 * region-cache.c (struct boundary.pos, find_cache_boundary)
1165 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1166 (set_cache_region, invalidate_region_cache)
1167 (revalidate_region_cache, know_region_cache, region_cache_forward)
1168 (region_cache_backward, pp_cache):
1169 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1170 so that ptrdiff_t * can be passed to xpalloc.
1171 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1172 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1173 (pp_cache): Don't assume cache_len fits in int.
1174 * region-cache.h: Adjust extern decls to match.
1176 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1177 EMACS_INT, since either will do, for xpalloc.
1179 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1180 (xnmalloc, xnrealloc, xpalloc): New functions.
1182 * bidi.c (bidi_shelve_header_size): New constant.
1183 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1184 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1186 * bidi.c (bidi_cache_shrink):
1187 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1189 Don't update size of array until after memory allocation succeeds,
1190 because xmalloc/xrealloc may not return.
1191 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1192 now that we have proper integer overflow checking.
1193 (record_overlay_string, overlay_strings): Catch overflows when
1194 calculating size of overlay_str_buf.
1196 * callproc.c (Fcall_process): Check for size overflow when
1197 calculating size of args2.
1198 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1199 Normally we prefer signed values, but sticking with ptrdiff_t would
1200 require adding more-complicated checks.
1202 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1203 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1204 Redo buffer-overflow calculations to avoid integer overflow.
1205 Add a FIXME comment where memory seems to be over-allocated.
1207 * character.c (Fstring): Check for size-calculation overflow.
1209 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1210 unnecessary integer overflow. Check for size overflow.
1211 (encode_coding_object): Don't update size until xmalloc succeeds.
1213 * composite.c (get_composition_id): Check for overflow in glyph
1214 length calculations.
1216 Integer and memory overflow fixes for display code.
1217 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1218 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1219 (scrolling_window): Check for overflow in size calculations.
1220 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1221 Don't assume glyph table len fits in int.
1222 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1223 (row_table_size): Now ptrdiff_t, not int.
1224 (scrolling_window): Avoid overflow in size calculations.
1225 Don't update size until allocation succeeds.
1226 * fns.c (concat): Check for overflow in size calculations.
1227 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1228 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1229 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1231 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1232 (get_doc_string): Check for size calculation overflow.
1233 Don't update size until allocation succeeds.
1234 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1235 EMACS_INT, where ptrdiff_t will do.
1236 (Fsubstitute_command_keys): Check for string overflow.
1238 * editfns.c (set_time_zone_rule): Don't assume environment length
1240 (message_length): Now ptrdiff_t, not int.
1241 (Fmessage_box): Don't update size until allocation succeeds.
1242 Don't assume message length fits in int.
1243 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1245 * emacs.c (main): Do not reallocate argv, since there is a null at
1246 the end that can be overwritten, and this way there's no need to
1247 worry about size-calculation overflow.
1248 (sort_args): Check for size-calculation overflow.
1250 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1252 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1254 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1255 (x_set_scroll_bar_width, x_figure_window_size):
1256 Check for integer overflow.
1257 (x_set_alpha): Do not assume XINT fits in int.
1259 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1260 This is for the members text_lines, text_cols, total_lines, total_cols,
1261 where the system imposes an 'int' limit.
1263 * fringe.c (Fdefine_fringe_bitmap):
1264 Don't update size until alloc works.
1266 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1267 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1269 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1270 Check for size-calculation overflow.
1271 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1272 do, as we prefer signed integers.
1273 (id_to_widget.max_size, id_to_widget.used)
1274 (xg_store_widget_in_map, xg_remove_widget_from_map)
1275 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1276 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1277 Use and return ptrdiff_t, not int.
1278 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1279 * gtkutil.h: Change prototypes to match the above.
1281 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1282 are duplicate now that they've been promoted to lisp.h.
1283 (x_allocate_bitmap_record, x_alloc_image_color)
1284 (make_image_cache, cache_image, xpm_load):
1285 Don't update size until alloc is done.
1286 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1288 Check for size calculation overflow.
1289 (ct_colors_allocated_max): New constant.
1290 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1293 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1294 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1295 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1296 Use ptrdiff_t, not int, to count maps.
1297 (read_char_minibuf_menu_prompt): Check for overflow in size
1298 calculations. Don't update size until allocation succeeds.
1299 Redo calculations to avoid overflow.
1300 * keyboard.h: Change prototypes to match the above.
1302 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1304 (current_minor_maps): Check for size calculation overflow.
1305 * keymap.h: Change prototypes to match the above.
1307 * lread.c (read1, init_obarray): Don't update size until alloc done.
1309 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1310 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1312 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1313 Now ptrdiff_t, not int.
1314 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1315 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1317 * process.c (Fnetwork_interface_list): Check for overflow
1318 in size calculation.
1320 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1322 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1323 overflow. Don't bother calling xmalloc when xrealloc will do.
1325 * search.c (Freplace_match): Check for size calculation overflow.
1326 (Fset_match_data): Don't assume list lengths fit in 'int'.
1328 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1329 for command line length. Do not attempt to address one before the
1330 beginning of an array, as that's not portable.
1332 * term.c (max_frame_lines): Remove; unused.
1333 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1335 (encode_terminal_code, calculate_costs): Check for size
1336 calculation overflow.
1337 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1338 table lengths and related sizes. Don't update size until alloc
1339 done. Redo calculations to avoid overflow.
1340 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1342 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1343 subtracting pointers.
1344 (gobble_line): Check for overflow more carefully. Don't update size
1347 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1348 Don't update size until alloc done.
1349 Redo size calculations to avoid overflow.
1350 Check for size calculation overflow.
1351 (main) [DEBUG]: Fix typo in invoking tparam1.
1353 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1354 Use ptrdiff_t, not int, for sizes.
1355 (store_mode_line_noprop_char): Don't update size until alloc done.
1357 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1358 Use ptrdiff_t, not int, for sizes.
1359 (Finternal_make_lisp_face, cache_face):
1360 Check for size calculation overflow.
1361 (cache_face): Treat size calculation overflows as if they were
1362 memory exhaustion (the usual treatment), rather than aborting.
1364 * xfns.c (x_encode_text, x_set_name_internal)
1365 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1366 sizes, since they can exceed INT_MAX in size. Check for size
1367 calculation overflow.
1369 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1370 (xg_select): Check for size calculation overflow.
1371 Don't update size until alloc done.
1373 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1374 as sprintf is limited to int lengths.
1376 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1377 (X_LONG_MIN): New macros.
1378 Use them to make the following changes clearer.
1379 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1380 This change doesn't affect the value now, but it may help remind
1381 future maintainers not to raise the value too much later.
1382 (SELECTION_QUANTUM): Remove, replacing with ...
1383 (selection_quantum): ... new function, which avoids overflow.
1385 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1386 assumption that selection length fits in 'int'.
1387 (x_reply_selection_request, x_handle_selection_request)
1388 (x_get_window_property, receive_incremental_selection)
1389 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1390 (lisp_data_to_selection_data, clean_local_selection_data):
1391 Use ptrdiff_t, not int, to record length of selection.
1392 (x_reply_selection_request, x_get_window_property)
1393 (receive_incremental_selection, x_property_data_to_lisp):
1394 Redo calculations to avoid overflow.
1395 (x_reply_selection_request): When sending hint, ceiling it at
1396 X_LONG_MAX rather than relying on wraparound overflow to send
1398 (x_get_window_property, receive_incremental_selection)
1399 (lisp_data_to_selection_data, x_property_data_to_lisp):
1400 Check for size-calculation overflow.
1401 (x_get_window_property, receive_incremental_selection)
1402 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1403 Don't store size until memory allocation succeeds.
1404 (x_get_window_property): Plug memory leak on memory exhaustion.
1405 Don't double-block input; malloc is safe here. Don't assume 2**34
1406 - 4 fits in unsigned long. Add an xassert to check
1407 XGetWindowProperty overflow. Be more careful about overflow
1408 calculations, and distinguish size from memory overflow better.
1409 (receive_incremental_selection): When tracing, don't assume
1410 unsigned int is less than INT_MAX.
1411 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1412 harmful) conversions of unsigned short to int.
1413 (lisp_data_to_selection_data): Don't assume that integers
1414 in the range -65535 through -1 fit in an X unsigned short.
1415 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1416 result parameters unless successful. Rely on cons_to_unsigned
1417 to report problems with elements; the old code wasn't right anyway.
1418 (x_check_property_data): Check for int overflow; we cannot use
1419 a wider type due to X limits.
1420 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1422 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1424 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1425 (x_term_init): Check for size calculation overflow.
1426 (x_color_cells): Don't store size until memory allocation succeeds.
1427 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1428 Don't assume alloca size is less than MAX_ALLOCA.
1429 (x_term_init): Don't assume length fits in int (sprintf is limited
1432 Use ptrdiff_t for composition IDs.
1433 * character.c (lisp_string_width):
1434 * composite.c (composition_table_size, n_compositions)
1435 (get_composition_id, composition_gstring_from_id):
1436 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1438 * window.c (Frecenter):
1439 Use ptrdiff_t, not int, for composition IDs.
1440 * composite.c (get_composition_id): Check for integer overflow.
1441 * composite.h: Adjust prototypes to match the above changes.
1443 Use ptrdiff_t for hash table indexes.
1444 * category.c (hash_get_category_set):
1445 * ccl.c (ccl_driver):
1446 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1447 * coding.c (coding_system_charset_list, detect_coding_system):
1448 * coding.h (struct coding_system.id):
1449 * composite.c (get_composition_id, gstring_lookup_cache):
1450 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1451 * image.c (xpm_get_color_table_h):
1452 * lisp.h (hash_lookup, hash_put):
1453 * minibuf.c (Ftest_completion):
1454 Use ptrdiff_t for hash table indexes, not int (which is too
1455 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1456 32-bit --with-wide-int hosts).
1458 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1459 Add a FIXME comment about memory leaks.
1460 (syms_of_charset): Don't assume xmalloc returns.
1462 Don't assume that stated character widths fit in int.
1463 * character.c (Fchar_width, c_string_width, lisp_string_width):
1464 * character.h (CHAR_WIDTH):
1465 * indent.c (MULTIBYTE_BYTES_WIDTH):
1466 Use sanitize_char_width to avoid undefined and/or bad behavior
1467 with outlandish widths.
1468 * character.h (sanitize_tab_width): Rename from sanitize_width,
1469 now that we have two such functions. All uses changed.
1470 (sanitize_char_width): New inline function.
1472 Don't assume that tab-width fits in int.
1473 * character.h (sanitize_width): New inline function.
1474 (SANE_TAB_WIDTH): New macro.
1475 (ASCII_CHAR_WIDTH): Use it.
1476 * indent.c (sane_tab_width): Remove. All uses replaced by
1477 SANE_TAB_WIDTH (current_buffer).
1478 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1480 * fileio.c: Integer overflow issues with file modes.
1481 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1483 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1484 Remove unreachable code.
1485 (read_hex, load_charset_map_from_file): Check for integer overflow.
1487 * xterm.c: don't go over XClientMessageEvent limit
1488 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1489 (x_send_scroll_bar_event): Likewise. Check that the size does not
1490 exceed limits imposed by XClientMessageEvent, as well as the usual
1491 ptrdiff_t and size_t limits.
1493 * keyboard.c: Overflow, signedness and related fixes.
1494 (make_lispy_movement): Use same integer type in forward decl
1495 that is used in the definition.
1496 (read_key_sequence, keyremap_step):
1497 Change bufsize argument back to int, undoing my 2011-03-30 change.
1498 We prefer signed types, and int is wide enough here.
1499 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1500 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1501 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1502 length, not size_t. Use ptrdiff_t for index, not int.
1503 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1504 possibility of integer overflow.
1506 Overflow, signedness and related fixes for images.
1508 * dispextern.h (struct it.stack[0].u.image.image_id)
1509 (struct_it.image_id, struct image.id, struct image_cache.size)
1510 (struct image_cache.used, struct image_cache.ref_count):
1511 * gtkutil.c (update_frame_tool_bar):
1512 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1513 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1514 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1515 * nsmenu.m (update_frame_tool_bar):
1516 * xdisp.c (calc_pixel_width_or_height):
1517 * xfns.c (image_cache_refcount):
1518 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1519 on typical 64-bit hosts.
1521 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1522 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1523 Omit unnecessary casts to int.
1524 (parse_image_spec): Check that integers fall into 'int' range
1525 when the callers expect that.
1526 (image_ascent): Redo ascent calculation to avoid int overflow.
1527 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1528 (lookup_image): Remove unnecessary tests.
1529 (xbm_image_p): Locals are now of int, not EMACS_INT,
1530 since parse_image_check makes sure they fit into int.
1531 (png_load, gif_load, svg_load_image):
1532 Prefer int to unsigned where either will do.
1533 (tiff_handler): New function, combining the cores of the
1534 old tiff_error_handler and tiff_warning_handler.
1535 This function is rewritten to use vsnprintf and thereby avoid
1536 stack buffer overflows. It uses only the features of vsnprintf
1537 that are common to both POSIX and native Microsoft.
1538 (tiff_error_handler, tiff_warning_handler): Use it.
1539 (tiff_load, gif_load, imagemagick_load_image):
1540 Don't assume :index value fits in 'int'.
1541 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1542 (imagemagick_load_image): Check that crop parameters fit into
1543 the integer types that MagickCropImage accepts. Don't assume
1544 Vimagemagick_render_type has a nonnegative value. Don't assume
1545 size_t fits in 'long'.
1546 (gs_load): Use printmax_t to print the widest integers possible.
1547 Check for integer overflow when computing image height and width.
1549 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1551 * xdisp.c (redisplay_window): Don't force window start if point
1552 will be invisible in the resulting window. (Bug#9324)
1554 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1556 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1557 the display spec is of the form `(space ...)'.
1558 (handle_display_spec): Return the value returned by
1559 handle_single_display_spec, not just 1 or zero.
1560 (handle_single_display_spec): If the display spec is of the form
1561 `(space ...)', and specifies display in the text area, return 2
1563 (try_cursor_movement): Check for the need to scroll more
1564 accurately, and prefer exact match for point under bidi.
1565 Don't advance `row' beyond the last row of the window.
1567 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1568 into disp_prop; all users changed.
1570 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1571 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1572 for the text covered by the display property.
1574 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1576 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1577 Change return value to nil.
1578 (Frecord_buffer): Delete unused function.
1580 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1582 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1583 buffers, return left-to-right.
1584 (set_cursor_from_row): Consider candidate row a win if its glyph
1585 represents a newline and point is on that newline. Fixes cursor
1586 positioning on the newline at EOL of R2L text within L2R
1587 paragraph, and vice versa.
1588 (try_cursor_movement): Check continued rows, in addition to
1589 continuation rows. Fixes unwarranted scroll when point enters a
1590 continued line of R2L text within an L2R paragraph, or vice versa.
1591 (cursor_row_p): Consider the case of point being equal to
1592 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1593 from the end of a short line to the beginning of a continued line
1594 of R2L text within L2R paragraph.
1595 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1596 composed characters.
1598 * bidi.c (bidi_check_type): Use xassert.
1599 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1602 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1604 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1607 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1609 * nsfont.m (ns_otf_to_script): Fix typo.
1611 2011-08-22 Kenichi Handa <handa@m17n.org>
1613 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1614 extra slot even if the purpose is char-code-property-table.
1616 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (redisplay_window): When computing centering_position,
1619 account for the height of the header line. (Bug#8874)
1621 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1622 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1623 candidate is selected by the mouse, and that candidate has a
1624 composed character under the mouse.
1626 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1627 coordinates reported by pos-visible-in-window-p for a composed
1628 character in column zero.
1630 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1632 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1634 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1636 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1637 consider it a hit if to_charpos is anywhere in the range of the
1638 composed buffer positions.
1640 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1642 * image.c (gif_load): Don't assume that each subimage has the same
1643 dimensions as the base image. Handle disposal method that is
1644 "undefined" by the gif spec (Bug#9335).
1646 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1648 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1649 (Fcondition_case): Document `debug' symbol in error handler.
1651 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1653 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1654 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1655 from an Org mode buffer to a Speedbar frame.
1657 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1658 a composition, take its buffer position from IT->cmp_it.charpos.
1659 Fixes cursor positioning at the beginning of a line that begins
1660 with a composed character.
1662 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1664 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1665 character bidirectional type, use STRONG_L instead. Fixes crashes
1666 in a buffer produced by `describe-categories'.
1668 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1669 members before the level stack, so they would be saved and
1670 restored when copying iterator state. Fixes incorrect reordering
1671 around TABs covered by display properties.
1673 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1675 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1677 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1679 * eval.c (internal_condition_case, internal_condition_case_1)
1680 (internal_condition_case_2, internal_condition_case_n):
1681 Remove unnecessary aborts (Bug#9081).
1683 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1685 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1686 has no `load' handler, try opening the file locally. (Bug#9311)
1688 2011-08-16 Ken Brown <kbrown@cornell.edu>
1690 * gmalloc.c: Expand comment.
1692 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1694 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1695 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1697 2011-08-16 Ken Brown <kbrown@cornell.edu>
1699 Fix memory allocation problems in Cygwin build (Bug#9273).
1701 * unexcw.c ( __malloc_initialized): Declare external variable.
1702 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1704 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1706 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1708 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1710 [CYGWIN] (special_realloc): New function.
1711 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1712 requests to realloc storage in the static heap.
1714 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1716 * bidi.c (bidi_initialize): Remove unused local.
1718 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1721 * biditype.h: Remove file.
1722 * makefile.w32-in ($(BLD)/bidi.$(O)):
1723 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1725 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1727 * chartab.c: Improve commentary for the uniprop_table API.
1729 * bidi.c (bidi_paragraph_init): Support zero value of
1730 bidi_ignore_explicit_marks_for_paragraph_level.
1731 (bidi_initialize): Use uniprop_table instead of including
1732 biditype.h and bidimirror.h.
1734 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1735 coordinates of the iterator when restoring from ppos_it.
1738 2011-08-14 Kenichi Handa <handa@m17n.org>
1740 * process.c (create_process): Call setup_process_coding_systems
1741 after the pid of the process is set to -1 (Bug#8162).
1743 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1745 * xdisp.c (move_it_in_display_line_to): Don't invoke
1746 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1747 ppos_it. Fixes vertical cursor motion when line beginning is
1748 covered by an image. (Bug#9296)
1750 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1752 * nsterm.h (ns_run_ascript): Declare.
1753 (NSAPP_DATA2_RUNASSCRIPT): Define.
1755 * nsfns.m (as_script, as_result, as_status): New static variables.
1756 (ns_run_ascript): New function.
1757 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1758 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1759 the event loop. Get status from as_status (Bug#7276).
1761 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1762 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1763 the event loop (Bug#7276).
1765 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1767 * gnutls.c (QCgnutls_bootprop_priority)
1768 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1769 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1770 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1771 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1772 (QCgnutls_bootprop_verify_hostname_error)
1773 (QCgnutls_bootprop_callbacks_verify): Rename from
1774 Qgnutls_bootprop_..., all uses changed.
1776 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1779 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1781 * xfaces.c (Qframe_set_background_mode): Now static.
1782 * dispextern.h (Qframe_set_background_mode): Remove decl.
1784 * process.c (Fnetwork_interface_info): Declare local only if needed.
1786 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1788 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1789 (Fnetwork_interface_list): Allocate in increments of bytes instead
1790 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1791 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1793 (struct ifflag_def): notrailers is smart on OSX.
1794 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1795 Get hardware address with getifaddrs if available.
1797 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1799 * xdisp.c (iterate_out_of_display_property): xassert that
1800 IT->position is set to within IT->object's boundaries. Break from
1801 the loop as soon as EOB is reached; avoids infloops in redisplay
1802 when IT->position is set up wrongly due to some bug.
1803 Set IT->current to match the bidi iterator unconditionally.
1804 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1805 entry. Force push_it to save on the stack the current
1806 buffer/string position, to be restored by pop_it. Fix flags in
1807 the iterator structure wrt the object coming from a display
1808 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1809 properties. (Bug#9284)
1811 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1813 * fontset.c (fontset_get_font_group): Add proper type checks.
1816 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1818 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1819 and LC_VERSION_MIN_MACOSX.
1820 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1821 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1823 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (forward_to_next_line_start): Allow to use the
1826 no-display-properties-and-no-overlays under bidi display.
1827 Set disp_pos in the bidi iterator to avoid searches for display
1828 properties and overlays.
1830 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1832 * editfns.c (Fset_time_zone_rule): Document relationship with the
1835 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1836 the font entity extracted from the cache (Bug#8109).
1838 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1840 * composite.c (autocmp_chars): Don't reset point. That is done by
1841 restore_point_unwind (Bug#5984).
1843 2011-08-07 Juri Linkov <juri@jurta.org>
1845 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1846 to show the arg `TIME' instead of `TIMEVAL'.
1848 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1851 display property strides EOL and includes a newline, as in
1852 longlines-mode. (Bug#9254)
1853 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1854 word-wrap under bidirectional display. (Bug#9224)
1856 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1857 is non-zero, even if the data buffer is NULL. Fixes a crash in
1858 vertical-motion with longlines-mode. (Bug#9254)
1860 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1862 * bidi.c <bidi_cache_total_alloc>: Now static.
1863 (bidi_initialize): Initialize bidi_cache_total_alloc.
1865 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1868 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1869 amount allocated this far in `bidi_cache_total_alloc'.
1870 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1871 non-zero, only free the data buffer without restoring the cache
1872 contents. All callers changed.
1874 * dispextern.h (bidi_unshelve_cache): Update prototype.
1876 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1877 (move_it_in_display_line, move_it_to)
1878 (move_it_vertically_backward, move_it_by_lines): Replace the call
1879 to xfree to an equivalent call to bidi_unshelve_cache.
1880 (move_it_in_display_line_to): Fix logic of returning
1881 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1883 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1886 came from a string character with a `cursor' property. (Bug#9229)
1888 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1890 * Makefile.in (LIB_PTHREAD): New variable.
1891 (LIBES): Add LIB_PTHREAD (Bug#9216).
1893 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1894 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1896 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1898 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1900 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1902 * xterm.c (x_find_topmost_parent): New function.
1903 (x_set_frame_alpha): Find topmost parent window with
1904 x_find_topmost_parent and set the property there also (bug#9181).
1905 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1907 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1909 * callproc.c (Fcall_process): Avoid vfork clobbering
1910 the local vars buffer, coding_systems, current_dir.
1912 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1914 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1916 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1918 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1919 so that it is not optimized away.
1921 * xdisp.c (compute_display_string_pos): Remove unused local.
1923 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1925 Fix slow cursor motion and scrolling in large buffers with
1926 selective display, like Org Mode buffers. (Bug#9218)
1928 * dispextern.h (struct bidi_it): New member disp_prop_p.
1930 * xdisp.c: Remove one-slot cache of display string positions.
1931 (compute_display_string_pos): Accept an additional argument
1932 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1933 for a display string or property. If found, set DISP_PROP_P
1936 * bidi.c (bidi_fetch_char): Accept an additional argument
1937 DISP_PROP_P, and pass it to compute_display_string_pos.
1938 Only handle text covered by a display string if DISP_PROP_P is returned
1939 non-zero. All callers of bidi_fetch_char changed.
1941 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1943 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1945 2010-12-03 Don March <don@ohspite.net>
1947 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1948 last character M-[char] is translated to ESC [char] (bug#7541).
1950 2011-08-02 Kenichi Handa <handa@m17n.org>
1952 * lisp.h (uniprop_table): Extern it.
1954 * chartab.c (uniprop_table): Make it non-static.
1956 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1958 * xdisp.c (forward_to_next_line_start): Accept additional argument
1959 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1961 (reseat_at_next_visible_line_start): Use the bidi iterator state
1962 returned by forward_to_next_line_start to restore the state of
1963 it->bidi_it after backing up to previous newline. (Bug#9212)
1965 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1967 * regex.c (re_comp): Protoize.
1968 (re_exec): Fix return type.
1969 (regexec): Fix type of `ret'. (Bug#9203)
1971 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1973 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1974 This is needed if max-image-size is a floating-point number.
1976 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1978 * print.c (print_object): Print empty symbol as ##.
1980 * lread.c (read1): Read ## as empty symbol.
1982 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1984 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1985 setting frame foreground color (Bug#9175).
1986 (x_set_background_color): Likewise.
1988 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1989 contents (Bug#9176).
1990 (EmacsTooltip -init): Remove bezels and add shadows to
1993 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1994 or scroll bar (Bug#8470).
1996 * nsfont.m (nsfont_open): Remove assignment to voffset and
1997 unnecessary vars hshink, expand, hd, full_height, min_height.
1998 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2000 * nsterm.h (nsfont_info): Remove voffset field.
2002 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2004 Implement strike-through and overline on NextStep (Bug#8863).
2006 * nsfont.m (nsfont_open): Use underline position provided by font,
2007 instead of hard-coded value of 2.
2008 (nsfont_draw): Call ns_draw_text_decoration instead.
2010 * nsterm.h: Add declaration for ns_draw_text_decoration.
2012 * nsterm.m (ns_draw_text_decoration): New function for drawing
2013 underline, overline, and strike-through.
2014 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2015 ns_draw_text_decoration. Change treatment of cursor drawing to
2016 accommodate underlining, etc.
2018 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2020 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2023 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2025 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2026 Without this fix, if a signal arrives just after memory fills up,
2027 'malloc' might be invoked reentrantly.
2029 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2030 In other words, assume that every image size is allowed, on non-X
2031 hosts. This assumption is probably wrong, but it lets Emacs compile.
2033 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2035 * regex.c (re_iswctype): Convert return values to boolean.
2037 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2039 * xdisp.c (compute_display_string_pos): Don't use cached display
2040 string position if the buffer had its restriction changed.
2043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2047 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2049 Integer signedness and overflow and related fixes. (Bug#9079)
2051 * bidi.c: Integer size and overflow fixes.
2052 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2053 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2054 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2055 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2056 (bidi_find_other_level_edge):
2057 Use ptrdiff_t instead of EMACS_INT where either will do.
2058 This works better on 32-bit hosts configured --with-wide-int.
2059 (bidi_cache_ensure_space): Check for size-calculation overflow.
2060 Use % rather than repeated addition, for better worst-case speed.
2061 Don't set bidi_cache_size until after xrealloc returns, because it
2063 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2064 (bidi_cache_ensure_space): Also check that the bidi cache size
2065 does not exceed that of the largest Lisp string or buffer. See Eli
2066 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2068 * alloc.c (__malloc_size_t): Remove.
2069 All uses replaced by size_t. See Andreas Schwab's note
2070 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2072 * image.c: Improve checking for integer overflow.
2073 (check_image_size): Assume that f is nonnull, since
2074 it is always nonnull in practice. This is one less thing to
2075 worry about when checking for integer overflow later.
2076 (x_check_image_size): New function, which checks for integer
2077 overflow issues inside X.
2078 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2079 This removes the need for a memory_full check.
2080 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2081 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2082 (xbm_read_bitmap_data): Change locals back to 'int', since
2083 their values must fit in 'int'.
2084 (xpm_load_image, png_load, tiff_load):
2085 Invoke x_create_x_image_and_pixmap earlier,
2086 to avoid much needless work if the image is too large.
2087 (tiff_load): Treat overly large images as if
2088 x_create_x_image_and_pixmap failed, not as malloc failures.
2089 (gs_load): Use x_check_image_size.
2091 * gtkutil.c: Omit integer casts.
2092 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2093 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2095 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2097 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2098 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2099 would wrongly return t on a 64-bit host.
2101 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2102 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2103 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2104 and therefore cause GCC to emit a bogus diagnostic in some cases.
2106 * image.c: Integer signedness and overflow and related fixes.
2107 This is not an exhaustive set of fixes, but it's time to
2108 record what I've got.
2109 (lookup_pixel_color, check_image_size): Remove redundant decls.
2110 (check_image_size): Don't assume that arbitrary EMACS_INT values
2111 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2112 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2113 (tiff_load, imagemagick_load_image):
2114 Check for overflow in size calculations.
2115 (x_create_x_image_and_pixmap): Remove unnecessary test for
2116 xmalloc returning NULL; that can't happen.
2117 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2118 (xpm_color_bucket): Use better integer hashing function.
2119 (xpm_cache_color): Don't possibly over-allocate memory.
2120 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2121 (gif_memory_source):
2122 Use ptrdiff_t, not int or size_t, to record sizes.
2123 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2124 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2125 either works, as we prefer signed integers.
2126 (tiff_read_from_memory, tiff_write_from_memory):
2127 Return tsize_t, not size_t, since that's what the TIFF API wants.
2128 (tiff_read_from_memory): Don't fail simply because the read would
2129 go past EOF; instead, return a short read.
2130 (tiff_load): Omit no-longer-needed casts.
2131 (Fimagemagick_types): Don't assume size fits into 'int'.
2133 Improve hashing quality when configured --with-wide-int.
2134 * fns.c (hash_string): New function, taken from sxhash_string.
2135 Do not discard information about ASCII character case; this
2136 discarding is no longer needed.
2137 (sxhash-string): Use it. Change sig to match it. Caller changed.
2138 * lisp.h: Declare it.
2139 * lread.c (hash_string): Remove, since we now use fns.c's version.
2140 The fns.c version returns a wider integer if --with-wide-int is
2141 specified, so this should help the quality of the hashing a bit.
2143 * emacs.c: Integer overflow minor fix.
2144 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2145 Define only if GNU_LINUX.
2146 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2148 * dispnew.c: Integer signedness and overflow fixes.
2149 Remove unnecessary forward decls, that were a maintenance hassle.
2150 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2152 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2153 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2154 (prepare_desired_row, line_draw_cost):
2155 Use int, not unsigned, where either works.
2156 (save_current_matrix, restore_current_matrix):
2157 Use ptrdiff_t, not size_t, where either works.
2158 (init_display): Check for overflow more accurately, and without
2159 relying on undefined behavior.
2161 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2162 Remove, replacing with the new symbols in lisp.h. All uses changed.
2163 * fileio.c (make_temp_name):
2164 * filelock.c (lock_file_1, lock_file):
2165 * xdisp.c (message_dolog):
2166 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2167 Use pMd etc. instead.
2168 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2169 replacing the pWIDE etc. symbols removed from editfns.c.
2171 * keyboard.h (num_input_events): Now uintmax_t.
2172 This is (very slightly) less likely to mess up due to wraparound.
2175 * buffer.c: Integer signedness fixes.
2176 (alloc_buffer_text, enlarge_buffer_text):
2177 Use ptrdiff_t rather than size_t when either will do, as we prefer
2180 * alloc.c: Integer signedness and overflow fixes.
2181 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2182 (__malloc_size_t): Default to size_t, not to int.
2183 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2184 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2185 Prefer ptrdiff_t to size_t when either would do, as we prefer
2187 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2188 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2189 Now const. Initialize with values that are in range even if char
2191 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2192 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2193 These functions do the right thing with sizes > 2**32.
2194 (check_depth): Now ptrdiff_t, not int.
2195 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2196 Adjust to new way of storing sizes. Check for size overflow bugs
2198 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2199 slightly wrong anyway, as it missed one instance of
2200 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2201 (refill_memory_reserve): Omit needless cast to size_t.
2202 (mark_object_loop_halt): Mark as externally visible.
2204 * xselect.c: Integer signedness and overflow fixes.
2205 (Fx_register_dnd_atom, x_handle_dnd_message):
2206 Use ptrdiff_t, not size_t, since we prefer signed.
2207 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2208 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2209 x_dnd_atoms_size and x_dnd_atoms_length.
2211 * doprnt.c: Prefer signed to unsigned when either works.
2213 * doprnt.c (doprnt):
2215 * xdisp.c (vmessage):
2216 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2217 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2218 prefer signed arithmetic to avoid comparison confusion.
2219 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2220 but is a bit tricky.
2222 Assume freestanding C89 headers, string.h, stdlib.h.
2223 * data.c, doprnt.c, floatfns.c, print.c:
2224 Include float.h unconditionally.
2225 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2226 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2227 * regex.c: Likewise for stddef.h, string.h.
2228 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2229 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2230 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2231 (STDC_HEADERS): Remove obsolete defines.
2232 * sysdep.c: Include limits.h unconditionally.
2234 Assume support for memcmp, memcpy, memmove, memset.
2235 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2236 * regex.c (memcmp, memcpy):
2237 Remove; we assume C89 now.
2239 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2240 (__malloc_safe_bcopy): Remove; no longer needed.
2242 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2243 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2244 well either way, and we prefer signed to unsigned.
2246 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2248 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2249 closes the connection while we're reading (bug#9182).
2251 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2253 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2254 are specified (Bug#9168).
2256 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2258 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2259 Found by GCC static checking and --with-wide-int on a 32-bit host.
2261 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2263 * xdisp.c (compute_display_string_pos): Fix logic of caching
2264 previous display string position. Initialize cached_prev_pos to
2265 -1. Fixes slow-down at the beginning of a buffer.
2267 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2269 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2270 for attrs[LFACE_FONTSET_INDEX].
2272 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2274 * xml.c (parse_region): Remove unused local
2275 that was recently introduced.
2277 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2279 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2280 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2282 * xdisp.c (move_it_in_display_line_to): Record the best matching
2283 position for TO_CHARPOS while scanning the line, and restore it on
2284 exit if none of the characters scanned was an exact match.
2285 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2286 when exact match is impossible due to invisible text, and the
2287 lines are truncated.
2289 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2291 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2294 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2296 Fix a significant slow-down of cursor motion with C-n, C-p,
2297 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2298 auto-repeat under bidi redisplay in fontified buffers.
2299 * xdisp.c (compute_stop_pos_backwards): New function.
2300 (next_element_from_buffer): Call compute_stop_pos_backwards to
2301 find a suitable prev_stop when we find ourselves before
2303 (reseat): Don't look for prev_stop, as that could mean a very long
2305 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2306 <cached_disp_overlay_modiff>: Cache for last found display string
2308 (compute_display_string_pos): Return the cached position if asked
2309 about the same buffer in the same area of character positions, and
2310 the buffer wasn't changed since the time the display string
2311 position was cached.
2313 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2315 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2316 is an integer, which is important for empty lines. (Bug#9149)
2318 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2320 * frame.c (Fmodify_frame_parameters): In tty case, update the
2321 default face if necessary (Bug#4238).
2323 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2325 * editfns.c (Fstring_to_char): No need to explain what a character
2326 is in the docstring (Bug#6576).
2328 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2330 * xml.c (parse_region): Make sure we always return a tree.
2332 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2334 * xml.c (parse_region): If a document contains only comments,
2337 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2339 * xml.c (make_dom): Return comments, too.
2341 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2344 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2345 and the surrounding thread.
2346 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2347 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2348 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2350 * s/openbsd.h (BROKEN_SIGIO): Define.
2351 * unexelf.c (unexec) [__OpenBSD__]:
2352 Don't update the .mdebug section of the Alpha COFF symbol table.
2354 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2356 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2359 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2361 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2362 This fixes some race conditions on the permissions of any newly
2365 * alloc.c (valid_pointer_p): Use pipe, not open.
2366 This fixes some permissions issues when debugging.
2368 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2369 If fchown fails to set both uid and gid, try to set just gid,
2370 as that is sometimes allowed. Adjust the file's mode to eliminate
2371 setuid or setgid bits that are inappropriate if fchown fails.
2373 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2375 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2376 to compare Lisp_Objects.
2377 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2378 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2379 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2381 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2383 * lread.c (read_integer): Unread even EOF character.
2384 (read1): Likewise. Properly record start position of symbol.
2386 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2387 symbol character follows.
2389 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2391 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2392 This works around a problem with the previous change to Fcopy_file.
2393 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2394 and without this change, GCC might complain about discarding
2395 fchown's return value.
2397 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2399 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2401 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2403 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2405 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2407 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2408 it's used from the C level.
2410 * process.c: Use the same condition for POLL_FOR_INPUT in both
2411 keyboard.c and process.c (bug#1858).
2413 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2415 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2416 (Fgnutls_boot): Use it.
2418 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2420 * doc.c (Fsubstitute_command_keys): Revert last change.
2422 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2424 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2425 quotes the next character, and doesn't affect other longer
2426 sequences (bug#8935).
2428 * lread.c (syms_of_lread): Clarify that is isn't only
2429 `eval-buffer' and `eval-defun' that's affected by
2430 `lexical-binding' (bug#8460).
2432 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2435 bidi redisplay when a line includes both an image and is truncated.
2437 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2439 Fix minor problems found by static checking.
2440 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2441 (elsz): Now a signed constant, not a size_t var. We prefer signed
2442 types to unsigned, to avoid integer comparison confusion. Without
2443 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2444 "cannot optimize loop, the loop counter may overflow", a symptom
2446 * indent.c (Fvertical_motion): Mark locals as initialized.
2447 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2449 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2451 * search.c (Fre_search_backward): Mention `case-fold-search' in
2452 all the re_search_* functions (bug#8138).
2454 * keyboard.c (Fopen_dribble_file): Document when the file is
2457 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2459 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2462 Support bidi reordering of display and overlay strings.
2463 * xdisp.c (compute_display_string_pos)
2464 (compute_display_string_end): Accept additional argument STRING.
2465 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2466 (reseat_to_string): Initialize bidi_it->string.s and
2467 bidi_it->string.schars.
2468 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2469 NULL (avoids a crash in bidi_paragraph_init).
2470 Initialize itb.string.lstring.
2471 (init_iterator): Call bidi_init_it only of a valid
2472 buffer position was specified. Initialize paragraph_embedding to
2474 (reseat_to_string): Initialize the bidi iterator.
2475 (display_string): If we need to ignore text properties of
2476 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2477 original value of -1 will not work with bidi.)
2478 (compute_display_string_pos): First arg is now struct
2479 `text_pos *'; all callers changed. Support display properties on
2481 (compute_display_string_end): Support display properties on Lisp
2483 (init_iterator, reseat_1, reseat_to_string): Initialize the
2484 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2485 when iterating on a string not from display properties).
2486 (compute_display_string_pos, compute_display_string_end):
2487 Fix calculation of the object to scan. Fixes an error when using
2489 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2490 base_level_stop; instead, set base_level_stop to BEGV.
2491 Fixes crashes in vertical-motion.
2492 (next_element_from_buffer): Improve commentary for when
2493 the iterator is before prev_stop.
2494 (init_iterator): Initialize bidi_p from the default value of
2495 bidi-display-reordering, not from buffer-local value. Use the
2496 buffer-local value only if initializing for buffer iteration.
2497 (handle_invisible_prop): Support invisible properties on strings
2498 that are being bidi-reordered.
2499 (set_iterator_to_next): Support bidi reordering of C strings and
2501 (next_element_from_string): Support bidi reordering of Lisp
2503 (handle_stop_backwards): Support Lisp strings as well.
2504 (display_string): Support display of R2L glyph rows.
2505 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2506 (init_iterator): Don't initialize it->bidi_p for strings
2508 (reseat_to_string): Initialize it->bidi_p for strings here.
2509 (next_element_from_string, next_element_from_c_string)
2510 (next_element_from_buffer): Add xassert's for correspondence
2511 between IT's object being iterated and it->bidi_it.string
2513 (face_before_or_after_it_pos): Support bidi iteration.
2514 (next_element_from_c_string): Handle the case of the first string
2515 character that is not the first one in the visual order.
2516 (get_visually_first_element): New function, refactored from common
2517 parts of next_element_from_buffer, next_element_from_string, and
2518 next_element_from_c_string.
2519 (tool_bar_lines_needed, redisplay_tool_bar)
2520 (display_menu_bar): Force left-to-right direction. Add a FIXME
2521 comment for making that be controlled by a user option.
2522 (push_it, pop_it): Save and restore the state of the
2523 bidi iterator. Save and restore the bidi_p flag.
2524 (pop_it): Iterate out of display property for string iteration as
2526 (iterate_out_of_display_property): Support iteration over strings.
2527 (handle_single_display_spec): Set up it->bidi_it for iteration
2528 over a display string, and call bidi_init_it.
2529 (handle_single_display_spec, next_overlay_string)
2530 (get_overlay_strings_1, push_display_prop): Set up the bidi
2531 iterator for displaying display or overlay strings.
2532 (forward_to_next_line_start): Don't use the shortcut if
2534 (back_to_previous_visible_line_start): If handle_display_prop
2535 pushed the iterator stack, restore the internal state of the bidi
2536 iterator by calling bidi_pop_it same number of times.
2537 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2538 and we are bidi-iterating, don't decrement the iterator position;
2539 instead, set the first_elt flag in the bidi iterator, to produce
2541 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2542 (push_display_prop): xassert that we are iterating a buffer.
2543 (push_it, pop_it): Save and restore paragraph_embedding member.
2544 (handle_single_display_spec, next_overlay_string)
2545 (get_overlay_strings_1, reseat_1, reseat_to_string)
2546 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2547 correctly. Don't assume unibyte strings are not bidi-reordered.
2548 (compute_display_string_pos)
2549 (compute_display_string_end): Fix handling the case of C string.
2550 (push_it, pop_it): Save and restore from_disp_prop_p.
2551 (handle_single_display_spec, push_display_prop): Set the
2552 from_disp_prop_p flag.
2553 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2554 (pop_it): Call iterate_out_of_display_property only if we are
2555 popping after iteration over a string that came from a display
2556 property. Fix a typo in popping stretch info. Add an assertion
2557 for verifying that the iterator position is in sync with the bidi
2559 (handle_single_display_spec, get_overlay_strings_1)
2560 (push_display_prop): Fix initialization of paragraph direction for
2561 string when that of the parent object is not yet determined.
2562 (reseat_1): Call bidi_init_it to resync the bidi
2563 iterator with IT's position. (Bug#7616)
2564 (find_row_edges): If ROW->start.pos gives position
2565 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2566 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2567 Reset the from_disp_prop_p flag.
2568 (SAVE_IT, RESTORE_IT): New macros.
2569 (pos_visible_p, face_before_or_after_it_pos)
2570 (back_to_previous_visible_line_start)
2571 (move_it_in_display_line_to, move_it_in_display_line)
2572 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2573 (try_scrolling, redisplay_window, display_line): Use them when
2574 saving a temporary copy of the iterator and restoring it back.
2575 (back_to_previous_visible_line_start, reseat_1)
2576 (init_iterator): Empty the bidi cache "stack".
2577 (move_it_in_display_line_to): If iterator ended up at
2578 EOL, but we never saw any buffer positions smaller than
2579 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2580 motion in bidi-reordered lines.
2581 (move_it_in_display_line_to): Record prev_method and prev_pos
2582 immediately before the call to set_iterator_to_next. Fixes cursor
2583 motion in bidi-reordered lines with stretch glyphs and strings
2584 displayed in margins. (Bug#8133) (Bug#8867)
2585 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2587 (pos_visible_p): Support positions in bidi-reordered lines.
2588 Save and restore bidi cache.
2590 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2591 (bidi_paragraph_info): Delete unused struct.
2592 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2593 (bidi_cache_start): New variable.
2594 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2596 (bidi_cache_fetch_state, bidi_cache_search)
2597 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2598 (bidi_cache_find, bidi_peek_at_next_level)
2599 (bidi_level_of_next_char, bidi_find_other_level_edge)
2600 (bidi_move_to_visually_next): Compare cache index with
2601 bidi_cache_start rather than with zero.
2602 (bidi_fetch_char): Accept new argument STRING; all callers
2603 changed. Support iteration over a string. Support strings with
2604 display properties. Support unibyte strings. Fix the type of
2605 `len' according to what STRING_CHAR_AND_LENGTH expects.
2606 (bidi_paragraph_init, bidi_resolve_explicit_1)
2607 (bidi_resolve_explicit, bidi_resolve_weak)
2608 (bidi_level_of_next_char, bidi_move_to_visually_next):
2609 Support iteration over a string.
2610 (bidi_set_sor_type, bidi_resolve_explicit_1)
2611 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2612 can now be zero (for strings); special values 0 and -1 were
2613 changed to -1 and -2, respectively.
2614 (bidi_char_at_pos): New function.
2615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2616 Call it instead of FETCH_MULTIBYTE_CHAR.
2617 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2618 initialized to valid values.
2619 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2621 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2622 the test for valid cached positions. Fix the logic for looking up
2623 the sentinel state in the cache. GCPRO the Lisp string we are
2625 (bidi_push_it, bidi_pop_it): New functions.
2626 (bidi_initialize): Initialize the bidi cache start stack pointer.
2627 (bidi_cache_ensure_space): New function, refactored from part of
2628 bidi_cache_iterator_state. Don't assume the required size is just
2629 one BIDI_CACHE_CHUNK away.
2630 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2631 (bidi_count_bytes, bidi_char_at_pos): New functions.
2632 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2633 always valid if bidi_cache_idx is valid.
2634 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2635 is valid if it's going to be used.
2636 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2637 (bidi_cache_fetch_state, bidi_cache_search)
2638 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2639 (bidi_cache_iterator_state, bidi_cache_find)
2640 (bidi_find_other_level_edge, bidi_cache_start_stack):
2641 All variables related to cache indices are now EMACS_INT.
2643 * dispextern.h (struct bidi_string_data): New structure.
2644 (struct bidi_it): New member `string'. Make flag members be 1-bit
2645 fields, and put them last in the struct.
2646 (compute_display_string_pos, compute_display_string_end):
2648 (bidi_push_it, bidi_pop_it): Add prototypes.
2649 (struct iterator_stack_entry): New members bidi_p,
2650 paragraph_embedding, and from_disp_prop_p.
2651 (struct it): Member bidi_p is now a bit field 1 bit wide.
2652 (bidi_shelve_cache, bidi_unshelve_cache):
2655 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2656 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2657 and vector-like objects.
2659 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2660 cache around display iteration.
2662 * window.c (Fwindow_end, window_scroll_pixel_based)
2663 (displayed_window_lines, Frecenter): Save and restore the bidi
2664 cache around display iteration.
2666 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668 * editfns.c (Fdelete_region): Clarify the use of the named
2669 parameters (bug#6788).
2671 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2673 * indent.c (Fvertical_motion): Set and restore w->pointm when
2674 saving and restoring the window's buffer (Bug#9006).
2676 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2678 * editfns.c (Fstring_to_char): Clarify just what is returned
2679 (bug#6576). Text by Eli Zaretskii.
2681 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2683 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2685 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2687 * buffer.c (mmap_find): Fix a typo.
2689 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2691 Fix execution of x selection hooks.
2692 * xselect.c (Qx_lost_selection_functions)
2693 (Qx_sent_selection_functions): New vars.
2694 (syms_of_xselect): DEFSYM them.
2695 (x_handle_selection_request): Pass Qx_sent_selection_functions
2696 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2697 (x_handle_selection_clear,x_clear_frame_selections):
2698 Pass Qx_lost_selection_functions rather than
2699 Vx_lost_selection_functions to Frun_hook_with_args.
2701 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2703 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2704 The old code sometimes used this field without initializing it.
2706 * alloc.c (gc_sweep): Don't read past end of array.
2707 In theory, the old code could also have corrupted Emacs internals,
2708 though it'd be very unlikely.
2710 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2712 * character.c (Fcharacterp): Don't advertise optional ignored
2713 argument. (Bug#4026)
2715 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2717 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2720 * window.c (Fset_window_start): Doc fix (bug#4199).
2721 (Fset_window_hscroll): Ditto.
2723 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2725 Fix minor new problems caught by GCC 4.6.1.
2726 * term.c (init_tty): Remove unused local.
2727 * xsettings.c (store_monospaced_changed): Define this function only
2728 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2731 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2733 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2735 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2737 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2738 are the mini-buffer and the echo area (bug#3320).
2740 * term.c (init_tty): Remove support for supdup, c10 and perq
2741 terminals, which are no longer supported (bug#1482).
2743 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2745 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2747 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2749 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2750 for non-popups (Bug#3642).
2752 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2754 * alloc.c (reset_malloc_hooks): Protoize.
2755 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2756 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2757 * cm.c (losecursor): Likewise.
2758 * data.c (fmod): Likewise.
2759 * dispnew.c (swap_glyphs_in_rows): Likewise.
2760 * emacs.c (memory_warning_signal): Likewise.
2761 * floatfns.c (float_error): Likewise.
2762 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2763 (otf_open, font_otf_capability, generate_otf_features)
2764 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2766 * image.c (pbm_read_file): Likewise.
2767 * indent.c (string_display_width): Likewise.
2768 * intervals.c (check_for_interval, search_for_interval)
2769 (inc_interval_count, count_intervals, root_interval)
2770 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2771 * lread.c (defalias): Likewise.
2772 * ralloc.c (r_alloc_check): Likewise.
2773 * regex.c (set_image_of_range_1, set_image_of_range)
2774 (regex_grow_registers): Likewise.
2775 * sysdep.c (strerror): Likewise.
2776 * termcap.c (valid_filename_p, tprint, main): Likewise.
2777 * tparam.c (main): Likewise.
2778 * unexhp9k800.c (run_time_remap, save_data_space)
2779 (update_file_ptrs, read_header, write_header, calculate_checksum)
2780 (copy_file, copy_rest, display_header): Likewise.
2781 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2783 * xdisp.c (check_it): Likewise.
2784 * xfaces.c (register_color, unregister_color, unregister_colors):
2786 * xfns.c (print_fontset_result): Likewise.
2787 * xrdb.c (member, fatal, main): Likewise.
2789 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2791 Fix minor problems found by static checking (Bug#9031).
2792 * chartab.c (char_table_set_range, map_sub_char_table):
2793 Remove unused locals.
2794 (uniprop_table): Now static.
2795 * composite.c (_work_char): Remove unused static var.
2797 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2799 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2801 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2803 * gtkutil.c (qttip_cb): Remove code without function.
2805 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2807 * w32.c (pthread_sigmask): New stub.
2809 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2811 Use pthread_sigmask, not sigprocmask (Bug#9010).
2812 sigprocmask is portable only for single-threaded applications, and
2813 Emacs can be multi-threaded when it uses GTK.
2814 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2816 * callproc.c (Fcall_process):
2817 * process.c (create_process):
2818 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2819 Use pthread_sigmask, not sigprocmask.
2821 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2823 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2824 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2829 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2830 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2831 (xg_hide_tooltip): Fix comment.
2833 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2834 in registerServicesMenuSendTypes.
2835 (validRequestorForSendType): Don't check ns_return_types.
2837 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2840 2011-07-08 Jason Rumney <jasonr@gnu.org>
2842 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2843 SH_SHOW for hidden windows (Bug#5482).
2845 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2846 frame struct members of non-existent frames (Bug#6284).
2848 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2850 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2851 variable firstTime not needed on OSX >= 10.6.
2852 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2853 >= 10.5. Use setKnobProportion, setDoubleValue.
2855 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2856 (MAC_OS_X_VERSION_10_5): Define if not defined.
2857 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2858 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2859 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2861 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2862 cString and lossyCString on OSX >= 10.4
2864 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2865 sizeToFit on OSX >= 10.2.
2867 * nsimage.m (allocInitFromFile): Don't use deprecated method
2868 bestRepresentationForDevice on OSX >= 10.6.
2870 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2873 * emacs.c: Declare unexec_init_emacs_zone.
2875 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2877 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2879 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2880 on svcsMenu (Bug#8842).
2882 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2884 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2886 * nsterm.m (QUTF8_STRING): Declare.
2887 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2888 (validRequestorForSendType): Return type is (id).
2889 Change indexOfObjectIdenticalTo to indexOfObject.
2890 Check if we have local selection before returning self (Bug#8842).
2891 (writeSelectionToPasteboard): Put local selection into paste board
2892 if we have a local selection (Bug#8842).
2893 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2895 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2896 (ns_get_local_selection): Declare.
2898 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2900 * keymap.c (describe_map_tree): Don't insert a double newline at
2901 the end of the buffer (bug#1169) and return whether we inserted
2904 * callint.c (Fcall_interactively): Change "reading args" to
2905 "providing args" to try to clarify what it does (bug#1010).
2907 2011-07-07 Kenichi Handa <handa@m17n.org>
2909 * composite.c (composition_compute_stop_pos): Ignore a static
2910 composition starting before CHARPOS (Bug#8915).
2912 * xdisp.c (handle_composition_prop): Likewise.
2914 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2916 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2919 2011-07-07 Kenichi Handa <handa@m17n.org>
2921 * character.h (unicode_category_t): New enum type.
2923 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2924 (Qchar_code_property_table): New variable.
2925 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2926 (UNIPROP_COMPRESSED_FORM_P): New macros.
2927 (char_table_ascii): Uncompress the compressed values.
2928 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2929 Uncompress the compressed values.
2930 (sub_char_table_ref_and_range): Likewise.
2931 (char_table_ref_and_range): Uncompress the compressed values.
2932 (sub_char_table_set): New arg is_uniprop. Callers changed.
2933 Uncompress the compressed values.
2934 (sub_char_table_set_range): Args changed. Callers changed.
2935 (char_table_set_range): Adjuted for the above change.
2936 (map_sub_char_table): Delete args default_val and parent. Add arg
2937 top. Give decoded values to a Lisp function.
2938 (map_char_table): Adjust for the above change. Give decoded
2939 values to a Lisp function. Gcpro more variables.
2940 (uniprop_table_uncompress)
2941 (uniprop_decode_value_run_length): New functions.
2942 (uniprop_decoder, uniprop_decoder_count): New variables.
2943 (uniprop_get_decoder, uniprop_encode_value_character)
2944 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2946 (uniprop_encoder, uniprop_encoder_count): New variables.
2947 (uniprop_get_encoder, uniprop_table)
2948 (Funicode_property_table_internal, Fget_unicode_property_internal)
2949 (Fput_unicode_property_internal): New functions.
2950 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2951 Sunicode_property_table_internal, Sget_unicode_property_internal,
2952 and Sput_unicode_property_internal. Defvar_lisp
2953 char-code-property-alist.
2955 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2956 Vunicode_category_table.
2958 * font.c (font_range): Adjust for the change of
2959 Vunicode_category_table.
2961 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2963 * m/iris4d.h: Remove file, move contents ...
2964 * s/irix6-5.h: ... here.
2966 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2968 Remove unportable assumption about struct layout (Bug#8884).
2969 * alloc.c (mark_buffer):
2970 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2971 (clone_per_buffer_values): Don't assume that
2972 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2973 This isn't true in general, and it's particularly not true
2974 if Emacs is configured with --with-wide-int.
2975 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2976 New macros, used in the buffer.c change.
2978 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2980 * xsettings.c: Use both GConf and GSettings if both are available.
2981 (store_config_changed_event): Add comment.
2982 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2983 (store_tool_bar_style_changed): New functions.
2984 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2985 (struct xsettings): Move font inside HAVE_XFT.
2986 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2987 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2988 Move inside HAVE_XFT.
2989 (something_changed_gsettingsCB): Rename from something_changedCB.
2990 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2992 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2993 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2994 (something_changed_gconfCB): Rename from something_changedCB.
2995 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2996 (parse_settings): Move check for font inside HAVE_XFT.
2997 (read_settings, apply_xft_settings): Add comment.
2998 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2999 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3000 call store_font_name_changed.
3001 (xft_settings_event): Add comment.
3002 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3003 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3004 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3005 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3006 (xsettings_initialize): Call init_gsettings last.
3007 (xsettings_get_system_font, xsettings_get_system_normal_font):
3010 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3012 Random fixes. E.g., (random) never returned negative values.
3013 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3014 subseconds part to the entropy, as that's a bit more random.
3015 Prefer signed to unsigned, since the signedness doesn't matter and
3016 in general we prefer signed. When given a limit, use a
3017 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3018 latter isn't right if USE_2_TAGS_FOR_INTS.
3019 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3020 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3022 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3024 * textprop.c (text_property_stickiness):
3025 Obey Vtext_property_default_nonsticky.
3026 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3027 * w32fns.c (syms_of_w32fns):
3028 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3030 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3032 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3033 This is more efficient than Ffile_directory_p and avoids a minor race.
3035 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3037 * buffer.c (Foverlay_put): Say what the return value is
3040 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3041 is a directory before asking whether to use the file name
3043 (barf_or_query_if_file_exists): Make the "File is a directory"
3044 error be more correct.
3046 * fns.c (Frequire): Remove the mention of the .gz files, since
3047 that's installation-specific, but keep the mention of
3048 `get-load-suffixes'.
3050 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3052 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3053 Report string overflow if the output is too long.
3055 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3057 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3058 (syms_of_gnutls): Remove duplicate DEFSYM for
3059 Qgnutls_bootprop_verify_hostname_error, an error for
3060 Qgnutls_bootprop_verify_error (which is no longer used).
3062 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3063 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3064 Also (re)move comments that are misplaced or no longer relevant.
3066 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3068 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3070 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3072 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3073 and background color parameters if they have been changed.
3075 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3077 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3079 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3081 * xsettings.c (SYSTEM_FONT): Define only when used.
3082 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3084 * keymap.c (access_keymap_1): Now static.
3086 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3088 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3089 leave any prefix arg for the up event (Bug#1586).
3091 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3093 * lread.c (syms_of_lread): Mention single symbols defined by
3094 `defvar' or `defconst' (bug#7154).
3096 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3097 (Frequire): Mention get-load-suffixes.
3099 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3101 * window.h (window): Remove clone_number slot.
3102 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3104 (make_parent_window, make_window, saved_window)
3105 (Fset_window_configuration, save_window_save): Don't deal with
3107 * buffer.c (Qclone_number): Remove declaration.
3108 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3110 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3112 Add multiple inheritance to keymaps.
3113 * keymap.c (Fmake_composed_keymap): New function.
3114 (Fset_keymap_parent): Simplify.
3115 (fix_submap_inheritance): Remove.
3116 (access_keymap_1): New function extracted from access_keymap to handle
3117 embedded parents and handle lists of maps.
3118 (access_keymap): Use it.
3119 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3120 (Fcopy_keymap): Handle embedded parents.
3121 (Fcommand_remapping, define_as_prefix): Simplify.
3122 (Fkey_binding): Simplify.
3123 (syms_of_keymap): Move minibuffer-local-completion-map,
3124 minibuffer-local-filename-completion-map,
3125 minibuffer-local-must-match-map, and
3126 minibuffer-local-filename-must-match-map to Elisp.
3127 (syms_of_keymap): Defsubr make-composed-keymap.
3128 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3129 (parse_menu_item): Trivial simplification.
3131 2011-07-01 Glenn Morris <rgm@gnu.org>
3133 * Makefile.in (SETTINGS_LIBS): Fix typo.
3135 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3137 * coding.c (Fencode_coding_string): Record the last coding system
3138 used, as the function doc string says (bug#8738).
3140 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3142 * xsettings.c (store_monospaced_changed): Take new font as arg and
3143 check for change against current_mono_font.
3144 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3145 (emacs_settings_constructor, emacs_settings_get_property)
3146 (emacs_settings_set_property, emacs_settings_class_init)
3147 (emacs_settings_init, gsettings_obj): Remove.
3148 (something_changedCB): New function for HAVE_GSETTINGS.
3149 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3150 with value as argument.
3151 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3152 g_settings_new (Bug#8967). Do not create gsettings_obj.
3153 Remove calls to g_settings_bind. Connect something_changedCB to
3156 * xgselect.c: Add defined (HAVE_GSETTINGS).
3157 (xgselect_initialize): Ditto.
3159 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3160 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3163 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3165 * eval.c (struct backtrace): Simplify and port the data structure.
3166 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3167 signed bit field, as this assumption is not portable and it makes
3168 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3169 "char debug_on_exit : 1" as this is not portable either; instead,
3170 use the portable "unsigned int debug_on_exit : 1". Remove unused
3171 member evalargs. Remove obsolete comments about cc bombing out.
3173 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3175 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3176 Let HAVE_GSETTINGS override HAVE_GCONF.
3177 (store_monospaced_changed): New function.
3178 (EMACS_SETTINGS): A new type derived from GObject to handle
3179 GSettings notifications.
3180 (emacs_settings_constructor, emacs_settings_get_property)
3181 (emacs_settings_set_property, emacs_settings_class_init):
3183 (gsettings_client, gsettings_obj): New variables.
3184 (GSETTINGS_SCHEMA): New define.
3185 (something_changedCB): Call store_monospaced_changed.
3186 (init_gsettings): New function.
3187 (xsettings_initialize): Call init_gsettings.
3188 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3191 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3194 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3196 * window.c (resize_root_window, grow_mini_window)
3197 (shrink_mini_window): Rename Qresize_root_window to
3198 Qwindow_resize_root_window and Qresize_root_window_vertically to
3199 Qwindow_resize_root_window_vertically.
3201 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3203 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3205 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3207 * makefile.w32-in: Redesign dependencies so they reflect more
3208 clearly which files are directly included by each source file,
3209 and not through other includes.
3211 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3213 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3214 (sort_overlays, overlay_strings): When an overlay's clone number
3215 matches the window's clone number process the overlay even if
3216 the overlay's window property doesn't match the current window.
3218 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3219 (Fwindow_hchild): Rename to Fwindow_left_child.
3220 (Fwindow_next): Rename to Fwindow_next_sibling.
3221 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3222 (resize_window_check): Rename to window_resize_check.
3223 (resize_window_apply): Rename to window_resize_apply.
3224 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3225 (Fdelete_other_windows_internal, resize_frame_windows)
3226 (Fsplit_window_internal, Fdelete_window_internal)
3227 (grow_mini_window, shrink_mini_window)
3228 (Fresize_mini_window_internal): Fix callers accordingly.
3230 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3232 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3233 (emacs_fixed_set_min_size): Remove.
3234 (emacs_fixed_new): Take frame as argument.
3236 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3237 (_EmacsFixedPrivate): Remove minwidth/height.
3238 Add struct frame *f.
3239 (emacs_fixed_init): Initialize priv->f.
3240 (get_parent_class, emacs_fixed_set_min_size): Remove.
3241 (emacs_fixed_new): Set priv->f to argument.
3242 (emacs_fixed_get_preferred_width)
3243 (emacs_fixed_get_preferred_height): Use min_width/height from
3244 frames size_hint to set minimum and natural (Bug#8919).
3245 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3246 and use min_width/height from frames size_hint to set
3247 min_width/height (Bug#8919).
3249 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3250 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3253 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3255 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3256 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3259 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3261 * process.c (wait_reading_process_output): Bypass select if
3262 waiting for a cell while ignoring keyboard input, and input is
3263 pending. Suggested by Jan Djärv (Bug#8869).
3265 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3267 Use gnulib's dup2 module instead of rolling our own.
3268 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3270 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3272 * dispnew.c (scrolling_window): Before scrolling, turn off a
3273 mouse-highlight in the window being scrolled.
3275 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3277 Move DEFSYM to lisp.h and use everywhere.
3279 * character.h (DEFSYM): Move declaration...
3280 * lisp.h (DEFSYM): ...here.
3286 * w32select.c: Don't include character.h.
3288 * alloc.c (syms_of_alloc):
3289 * buffer.c (syms_of_buffer):
3290 * bytecode.c (syms_of_bytecode):
3291 * callint.c (syms_of_callint):
3292 * casefiddle.c (syms_of_casefiddle):
3293 * casetab.c (init_casetab_once):
3294 * category.c (init_category_once, syms_of_category):
3295 * ccl.c (syms_of_ccl):
3296 * cmds.c (syms_of_cmds):
3297 * composite.c (syms_of_composite):
3298 * dbusbind.c (syms_of_dbusbind):
3299 * dired.c (syms_of_dired):
3300 * dispnew.c (syms_of_display):
3301 * doc.c (syms_of_doc):
3302 * editfns.c (syms_of_editfns):
3303 * emacs.c (syms_of_emacs):
3304 * eval.c (syms_of_eval):
3305 * fileio.c (syms_of_fileio):
3306 * fns.c (syms_of_fns):
3307 * frame.c (syms_of_frame):
3308 * fringe.c (syms_of_fringe):
3309 * insdel.c (syms_of_insdel):
3310 * keymap.c (syms_of_keymap):
3311 * lread.c (init_obarray, syms_of_lread):
3312 * macros.c (syms_of_macros):
3313 * msdos.c (syms_of_msdos):
3314 * print.c (syms_of_print):
3315 * process.c (syms_of_process):
3316 * search.c (syms_of_search):
3317 * sound.c (syms_of_sound):
3318 * syntax.c (init_syntax_once, syms_of_syntax):
3319 * terminal.c (syms_of_terminal):
3320 * textprop.c (syms_of_textprop):
3321 * undo.c (syms_of_undo):
3322 * w32.c (globals_of_w32):
3323 * window.c (syms_of_window):
3324 * xdisp.c (syms_of_xdisp):
3325 * xfaces.c (syms_of_xfaces):
3326 * xfns.c (syms_of_xfns):
3327 * xmenu.c (syms_of_xmenu):
3328 * xsettings.c (syms_of_xsettings):
3329 * xterm.c (syms_of_xterm): Use DEFSYM.
3331 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3333 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3335 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3337 Integer and buffer overflow fixes (Bug#8873).
3339 * print.c (printchar, strout): Check for string overflow.
3340 (PRINTPREPARE, printchar, strout):
3341 Don't set size unless allocation succeeds.
3343 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3344 for sizes. Check for string overflow more accurately.
3345 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3347 * macros.c: Integer and buffer overflow fixes.
3348 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3349 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3350 Use ptrdiff_t, not int, for sizes.
3351 Don't increment bufsize until after realloc succeeds.
3352 Check for size-calculation overflow.
3353 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3355 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3357 * lread.c: Integer overflow fixes.
3358 (read_integer): Radix is now EMACS_INT, not int,
3359 to improve quality of diagnostics for out-of-range radices.
3360 Calculate buffer size correctly for out-of-range radices.
3361 (read1): Check for integer overflow in radices, and in
3362 read-circle numbers.
3363 (read_escape): Avoid int overflow.
3364 (Fload, openp, read_buffer_size, read1)
3365 (substitute_object_recurse, read_vector, read_list, map_obarray):
3366 Use ptrdiff_t, not int, for sizes.
3367 (read1): Use EMACS_INT, not int, for sizes.
3368 Check for size overflow.
3370 * image.c (cache_image): Check for size arithmetic overflow.
3372 * lread.c: Integer overflow issues.
3373 (saved_doc_string_size, saved_doc_string_length)
3374 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3375 Now ptrdiff_t, not int.
3376 (read1): Don't assume doc string length fits in int. Check for
3377 out-of-range doc string lengths.
3378 (read_list): Don't assume file position fits in int.
3379 (read_escape): Check for hex character overflow.
3381 2011-06-22 Leo Liu <sdl.web@gmail.com>
3383 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3384 Move to minibuffer.el.
3386 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3388 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3389 The following patches are for when GLYPH_DEBUG && !XASSERT.
3390 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3391 * dispnew.c (flush_stdout):
3392 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3393 Mark as externally visible.
3394 * dispnew.c (check_window_matrix_pointers): Now static.
3395 * dispnew.c (window_to_frame_vpos):
3396 * xfns.c (unwind_create_frame):
3397 * xterm.c (x_check_font): Remove unused local.
3398 * scroll.c (CHECK_BOUNDS):
3399 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3400 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3401 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3402 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3403 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3405 (debug_method_add): Use va_list and vsprintf rather than relying
3406 on undefined behavior with wrong number of arguments.
3407 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3408 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3409 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3410 since we're not interested in debugging glyphs with old libraries.
3411 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3412 GCC 4.6.0's static checking.
3414 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3416 Integer overflow and signedness fixes (Bug#8873).
3417 A few related buffer overrun fixes, too.
3419 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3421 * dispextern.h (struct face.stipple):
3422 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3423 (x_bitmap_mask, x_allocate_bitmap_record)
3424 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3425 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3426 (x_create_bitmap_from_xpm_data):
3427 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3428 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3430 * xfaces.c (load_pixmap):
3431 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3432 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3433 (.bitmaps_last, struct x_output.icon_bitmap):
3434 Use ptrdiff_t, not int, for bitmap indexes.
3435 (x_allocate_bitmap_record): Check for size overflow.
3436 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3438 Use ptrdiff_t, not int, for overlay counts.
3439 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3440 * editfns.c (overlays_around, get_pos_property):
3441 * textprop.c (get_char_property_and_overlay):
3442 * xdisp.c (next_overlay_change, note_mouse_highlight):
3443 * xfaces.c (face_at_buffer_position):
3444 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3445 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3446 (Fnext_overlay_change, Fprevious_overlay_change)
3447 (mouse_face_overlay_overlaps, Foverlays_in):
3448 Use ptrdiff_t, not int, for sizes.
3449 (overlays_at, overlays_in): Check for size-calculation overflow.
3451 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3453 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3454 (x_session_initialize): Do not assume string length fits in int.
3456 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3457 This is unlikely, but can occur if DPI is outlandish.
3459 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3460 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3462 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3463 * xrdb.c (magic_file_p, search_magic_path):
3464 Omit last arg SUFFIX; it was always 0. All callers changed.
3465 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3467 * xfont.c (xfont_match): Avoid need for strlen.
3469 * xfns.c: Don't assume strlen fits in int.
3470 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3472 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3473 not unsigned long, as we prefer signed integers. All callers changed.
3474 Detect integer overflow in repeat count.
3475 (message_dolog): Don't assume print length fits in 39 bytes.
3476 (display_mode_element): Don't assume strlen fits in int.
3478 * termcap.c: Don't assume sizes fit in int and never overflow.
3479 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3480 (gobble_line): Check for size-calculation overflow.
3482 * minibuf.c (Fread_buffer):
3483 * lread.c (intern, intern_c_string):
3484 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3485 Don't assume string length fits in int.
3487 * keyboard.c (parse_tool_bar_item):
3488 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3490 * font.c: Don't assume string length fits in int.
3491 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3492 Use ptrdiff_t, not int.
3493 (font_intern_prop): Don't assume string length fits in int.
3494 Don't assume integer property fits in fixnum.
3495 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3497 * filelock.c: Fix some buffer overrun and integer overflow issues.
3498 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3499 Reformulate so as not to need the command string.
3500 Invoke gzip -cd rather than gunzip, as it's more portable.
3501 (lock_info_type, lock_file_1, lock_file):
3502 Don't assume pid_t and time_t fit in unsigned long.
3503 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3504 (current_lock_owner): Prefer signed type for sizes.
3505 Use memcpy, not strncpy, where memcpy is what is really wanted.
3506 Don't assume (via atoi) that time_t and pid_t fit in int.
3507 Check for time_t and/or pid_t out of range, e.g., via a network share.
3508 Don't alloca where an auto var works fine.
3510 * fileio.c: Fix some integer overflow issues.
3511 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3512 Don't assume string length fits in int.
3513 (directory_file_name): Don't assume string length fits in long.
3514 (make_temp_name): Don't assume pid fits in int, or that its print
3515 length is less than 20.
3517 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3519 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3521 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3523 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3524 We prefer signed integers, even for size calculations.
3526 * emacs.c: Don't assume string length fits in 'int'.
3527 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3528 (main): Don't invoke strlen when not needed.
3530 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3531 (XD_DEBUG_MESSAGE): Don't waste a byte.
3533 * callproc.c (getenv_internal_1, getenv_internal)
3535 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3537 * lread.c (invalid_syntax): Omit length argument.
3538 All uses changed. This doesn't fix a bug, but it simplifies the
3539 code away from its former Hollerith-constant appearance, and it's
3540 one less 'int' to worry about when looking at integer-overflow issues.
3541 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3543 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3544 This didn't break anything, but it didn't help either.
3545 It's confusing to put a bogus integer in a place where the actual
3546 value does not matter.
3547 (LIST_END_P): Remove unused macro and its bogus comment.
3548 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3550 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3551 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3553 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3554 We prefer signed types, and the value cannot exceed the EMACS_INT
3555 range anyway (because otherwise the length would not be representable).
3556 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3557 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3558 This avoids a GCC warning when WIDE_EMACS_INT.
3560 * indent.c (sane_tab_width): New function.
3561 (current_column, scan_for_column, Findent_to, position_indentation)
3562 (compute_motion): Use it. This is just for clarity.
3563 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3565 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3567 * lisp.h (lint_assume): New macro.
3568 * composite.c (composition_gstring_put_cache):
3569 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3571 * editfns.c, insdel.c:
3572 Omit unnecessary forward decls, to simplify future changes.
3574 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3576 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3578 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3579 Use much-faster test for byte-length change.
3580 Don't assume string byte-length fits in 'int'.
3581 Check that character arg fits in 'int'.
3582 (mapcar1): Declare byte as byte, for clarity.
3584 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3586 * fns.c (concat): Catch string overflow earlier.
3587 Do not rely on integer wraparound.
3589 * dispextern.h (struct it.overlay_strings_charpos)
3590 (struct it.selective): Now EMACS_INT, not int.
3591 * xdisp.c (forward_to_next_line_start)
3592 (back_to_previous_visible_line_start)
3593 (reseat_at_next_visible_line_start, next_element_from_buffer):
3594 Don't arbitrarily truncate the value of 'selective' to int.
3596 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3598 * composite.c: Don't truncate sizes to 'int'.
3599 (composition_gstring_p, composition_reseat_it)
3600 (composition_adjust_point): Use EMACS_INT, not int.
3601 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3602 not EMACS_UINT, for indexes.
3604 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3606 * buffer.c: Include <verify.h>.
3607 (struct sortvec.priority, struct sortstr.priority):
3608 Now EMACS_INT, not int.
3609 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3610 (struct sortstr.size, record_overlay_string)
3611 (struct sortstrlist.size, struct sortlist.used):
3612 Don't truncate size to int.
3613 (record_overlay_string): Check for size-calculation overflow.
3614 (init_buffer_once): Check at compile-time, not run-time.
3616 2011-06-22 Jim Meyering <meyering@redhat.com>
3618 Don't leak an XBM-image-sized buffer
3619 * image.c (xbm_load): Free the image buffer after using it.
3621 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3624 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3625 that Sun C diagnosed.
3626 * fns.c (secure_hash): Fix pointer signedness issue.
3627 * intervals.c (static_offset_intervals): New function.
3628 (offset_intervals): Use it.
3630 2011-06-21 Leo Liu <sdl.web@gmail.com>
3633 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3636 * fns.c (secure_hash): Rename from crypto_hash_function and change
3637 the first arg to accept symbols.
3638 (Fsecure_hash): New primitive.
3639 (syms_of_fns): New symbols.
3641 2011-06-20 Deniz Dogan <deniz@dogan.se>
3643 * process.c (Fset_process_buffer): Clarify return value in
3646 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3648 * dispnew.c (add_window_display_history): Use BVAR.
3650 * xdisp.c (debug_method_add): Use BVAR.
3651 (check_window_end, dump_glyph_matrix, dump_glyph)
3652 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3654 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3657 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3658 check till after the cache is created in init_frame_faces.
3660 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3662 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3664 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3666 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3667 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3668 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3670 Improve buffer-overflow checking (Bug#8873).
3671 * fileio.c (Finsert_file_contents):
3672 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3673 Remove the old (too-loose) buffer overflow checks.
3674 They weren't needed, since make_gap checks for buffer overflow.
3675 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3676 The old code merely checked for Emacs fixnum overflow, and relied
3677 on undefined (wraparound) behavior. The new code avoids undefined
3678 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3680 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3681 Tune. Don't use wider integers than needed. Don't use alloca.
3682 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3684 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3686 * insdel.c, lisp.h (buffer_overflow): New function.
3687 (insert_from_buffer_1, replace_range, replace_range_2):
3688 * insdel.c (make_gap_larger):
3689 * editfns.c (Finsert_char):
3690 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3692 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3694 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3696 Integer overflow and signedness fixes (Bug#8873).
3698 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3699 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3701 * fileio.c: Don't assume EMACS_INT fits in off_t.
3702 (emacs_lseek): New static function.
3703 (Finsert_file_contents, Fwrite_region): Use it.
3704 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3706 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3708 * fns.c: Don't overflow int when computing a list length.
3709 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3710 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3711 truncation on 64-bit hosts. Check for QUIT every
3712 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3713 faster and is responsive enough.
3714 (Flength): Report an error instead of overflowing an integer.
3715 (Fsafe_length): Return a float if the value is not representable
3716 as a fixnum. This shouldn't happen except in contrived situations.
3717 (Fnthcdr, Fsort): Don't assume list length fits in int.
3718 (Fcopy_sequence): Don't assume vector length fits in int.
3720 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3721 (header_size, word_size): New constants.
3722 (allocate_vectorlike): Don't check size overflow here.
3723 (allocate_vector): Check it here instead, since this is the only
3724 caller of allocate_vectorlike that could cause overflow.
3725 Check that the new vector's length is representable as a fixnum.
3727 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3728 The previous code was bogus. For example, next_almost_prime (32)
3729 returned 39, which is undesirable as it is a multiple of 3; and
3730 next_almost_prime (24) returned 25, which is a multiple of 5 so
3731 why was the code bothering to check for multiples of 7?
3733 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3735 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3737 Variadic C functions now count arguments with ptrdiff_t.
3738 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3739 Back then I didn't know that the Emacs coding style prefers signed int.
3740 Also, in the meantime I found a few more instances where arguments
3741 were being counted with int, which may truncate counts on 64-bit
3742 machines, or EMACS_INT, which may be unnecessarily wide.
3743 * lisp.h (struct Lisp_Subr.function.aMANY)
3744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3745 Arg counts are now ptrdiff_t, not size_t.
3746 All variadic functions and their callers changed accordingly.
3747 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3748 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3749 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3750 * callint.c (Fcall_interactively): Check arg count for overflow,
3751 to avoid potential buffer overrun. Use signed char, not 'int',
3752 for 'varies' array, so that we needn't bother to check its size
3753 calculation for overflow.
3754 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3755 * eval.c (apply_lambda):
3756 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3757 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3758 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3760 * callint.c (Fcall_interactively): Don't use index var as event count.
3762 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3763 * mem-limits.h (SIZE): Remove; no longer used.
3765 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3767 Remove unnecessary casts.
3768 * xterm.c (x_term_init):
3769 * xfns.c (x_set_border_pixel):
3770 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3771 These aren't needed now that we assume ANSI C.
3773 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3774 It's more likely to cause problems (due to unsigned overflow)
3777 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3779 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3781 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3783 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3785 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3787 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3789 GLYPH_CODE_FACE returns EMACS_INT, not int.
3790 * dispextern.h (merge_faces):
3791 * xfaces.c (merge_faces):
3792 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3793 Don't assume EMACS_INT fits in int.
3795 * character.h (CHAR_VALID_P): Remove unused parameter.
3796 * fontset.c, lisp.h, xdisp.c: All uses changed.
3798 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3800 * fns.c (concat): Minor tuning based on overflow analysis.
3801 This doesn't fix any bugs. Use int to hold character, instead
3802 of constantly refetching from Emacs object. Use XFASTINT, not
3803 XINT, for value known to be a character. Don't bother comparing
3804 a single byte to 0400, as it's always less.
3806 * floatfns.c (Fexpt):
3807 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3809 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3812 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3814 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3815 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3816 incorrectly succeed when S was a string, because 4294967386 was
3817 truncated before it was used.
3819 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3820 Otherwise, an out-of-range integer could cause undefined behavior
3823 * composite.c: Use int, not EMACS_INT, for characters.
3824 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3825 EMACS_INT, for values that are known to be in character range.
3826 This doesn't fix any bugs but is the usual style inside Emacs and
3827 may generate better code on 32-bit machines.
3829 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3830 This is for reasons similar to the recent CHAR_STRING fix.
3831 * charset.c (Fencode_char): Check that character arg is actually
3832 a character. Pass an int to ENCODE_CHAR.
3833 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3834 wider than 'int', as a compile-time check to prevent future regressions
3837 * character.c (char_string): Remove unnecessary casts.
3839 Make sure a 64-bit char is never passed to CHAR_STRING.
3840 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3841 by silently ignoring the top 32 bits, allowing some values
3842 that were far too large to be valid characters.
3843 * character.h: Include <verify.h>.
3844 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3845 arguments are no wider than unsigned, as a compile-time check
3846 to prevent future regressions in this area.
3848 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3849 (Fsubst_char_in_region):
3851 * xdisp.c (decode_mode_spec_coding):
3852 Adjust to CHAR_STRING's new requirement.
3853 * editfns.c (Finsert_char, Fsubst_char_in_region):
3854 * fns.c (concat): Check that character args are actually
3855 characters. Without this test, these functions did the wrong
3856 thing with wildly out-of-range values on 64-bit hosts.
3858 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3859 These casts should not be needed on 32-bit hosts, either.
3860 * keyboard.c (read_char):
3861 * lread.c (Fload): Remove casts to unsigned.
3863 * lisp.h (UNSIGNED_CMP): New macro.
3864 This fixes comparison bugs on 64-bit hosts.
3865 (ASCII_CHAR_P): Use it.
3866 * casefiddle.c (casify_object):
3867 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3868 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3869 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3870 * dispextern.h (FACE_FROM_ID):
3871 * keyboard.c (read_char): Use UNSIGNED_CMP.
3873 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3874 not to EMACS_INT, to avoid GCC warning.
3876 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3878 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3879 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3880 isn't needed on 32-bit machines.
3882 * buffer.c (Fgenerate_new_buffer_name):
3883 Use EMACS_INT for count, not int.
3884 (advance_to_char_boundary): Return EMACS_INT, not int.
3886 * data.c (Qcompiled_function): Now static.
3888 * window.c (window_body_lines): Now static.
3890 * image.c (gif_load): Rename local to avoid shadowing.
3892 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3893 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3894 * alloc.c (make_save_value): Integer argument is now of type
3896 (mark_object): Use ptrdiff_t, not int.
3897 * lisp.h (pD): New macro.
3898 * print.c (print_object): Use it.
3900 * alloc.c: Use EMACS_INT, not int, to count objects.
3901 (total_conses, total_markers, total_symbols, total_vector_size)
3902 (total_free_conses, total_free_markers, total_free_symbols)
3903 (total_free_floats, total_floats, total_free_intervals)
3904 (total_intervals, total_strings, total_free_strings):
3905 Now EMACS_INT, not int. All uses changed.
3906 (Fgarbage_collect): Compute overall total using a double, so that
3907 integer overflow is less likely to be a problem. Check for overflow
3908 when converting back to an integer.
3909 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3910 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3911 These were 'int' variables that could overflow on 64-bit hosts;
3912 they were never used, so remove them instead of repairing them.
3913 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3914 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3915 Previously, this ceilinged at INT_MAX, but that doesn't work on
3917 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3919 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3920 (allocate_vectorlike): Check for ptrdiff_t overflow.
3921 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3922 when a (possibly-narrower) signed value would do just as well.
3923 We prefer using signed arithmetic, to avoid comparison confusion.
3925 * alloc.c: Catch some string size overflows that we were missing.
3926 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3927 for convenience in STRING_BYTES_MAX.
3928 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3929 The definition here is exact; the one in lisp.h was approximate.
3930 (allocate_string_data): Check for string overflow. This catches
3931 some instances we weren't catching before. Also, it catches
3932 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3933 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3934 and ptrdiff_t and EMACS_INT are both 64 bits.
3936 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3937 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3938 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3940 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3942 * alloc.c (Fmake_string): Check for out-of-range init.
3944 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3946 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3948 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3950 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3951 xg_get_default_scrollbar_width.
3953 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3954 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3955 (style_changed_cb): Call update_theme_scrollbar_width and call
3956 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3957 all frames (Bug#8505).
3958 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3959 Call gtk_window_set_resizable if HAVE_GTK3.
3960 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3961 and height if HAVE_GTK3 (Bug#8505).
3962 (scroll_bar_width_for_theme): New variable.
3963 (update_theme_scrollbar_width): New function.
3964 (xg_get_default_scrollbar_width): Move code to
3965 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3966 (xg_initialize): Call update_theme_scrollbar_width.
3968 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3970 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3972 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3974 * frame.c (make_frame): Call other_buffer_safely instead of
3977 * window.c (temp_output_buffer_show): Call display_buffer with
3978 second argument Vtemp_buffer_show_specifiers and reset latter
3979 immediately after the call.
3980 (Vtemp_buffer_show_specifiers): New variable.
3981 (auto_window_vscroll_p, next_screen_context_lines)
3982 (Vscroll_preserve_screen_position): Remove leading asterisks from
3985 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3987 Fix minor problems found by GCC 4.6.0 static checking.
3988 * buffer.c (Qclone_number): Remove for now, as it's unused.
3989 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3990 (record_buffer): Remove unused local.
3991 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3992 (set_frame_buffer_list): Remove; unused.
3993 * frame.h (other_visible_frames): Remove decl.
3994 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3995 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3996 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3998 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3999 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4000 Define only if HAVE_GPM.
4001 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4002 (update_hints_inhibit): Remove; never set. All uses removed.
4003 * widgetprv.h (emacsFrameClassRec): Remove decl.
4004 * window.c (delete_deletable_window): Now returns void, since it
4005 wasn't returning anything.
4006 (compare_window_configurations): Remove unused locals.
4007 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4008 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4009 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4010 the same widths as pointers. This follows up on the 2011-05-06 patch.
4011 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4012 * xterm.h: Likewise.
4013 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4015 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4017 * makefile.w32-in: Update dependencies.
4018 (LISP_H): Add lib/intprops.h.
4020 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4022 * image.c (gif_load): Add animation frame delay to the metadata.
4023 (syms_of_image): Use DEFSYM. New symbol `delay'.
4025 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4027 * window.c (delete_deletable_window): Re-add.
4028 (Fset_window_configuration): Rewrite to handle dead buffers and
4029 consequently deletable windows.
4030 (window_tree, Fwindow_tree): Remove. Supply functionality in
4032 (compare_window_configurations): Simplify code.
4034 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4036 * image.c (imagemagick_load_image): Fix type mismatch.
4037 (Fimagemagick_types): Likewise.
4039 * window.h (replace_buffer_in_windows): Declare.
4041 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4043 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4044 Qclone_number. Remove external declaration of Qdelete_window.
4045 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4047 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4048 Run Qbuffer_list_update_hook if allowed.
4049 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4050 buffer list implementation.
4051 (other_buffer_safely): New function.
4052 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4053 calls to replace_buffer_in_windows and
4054 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4056 (record_buffer): Inhibit quitting and rewrite using quittable
4057 functions. Run Qbuffer_list_update_hook if allowed.
4058 (Frecord_buffer, Funrecord_buffer): New functions.
4059 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4060 Move switch-to-buffer to window.el.
4061 (bury-buffer): Move to window.el.
4062 (Vbuffer_list_update_hook): New variable.
4064 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4067 * window.h (resize_frame_windows): Move up in code.
4068 (Fwindow_frame): Remove EXFUN.
4069 (replace_buffer_in_all_windows): Remove prototype.
4070 (replace_buffer_in_windows_safely): Add prototype.
4072 * window.c: Declare Qdelete_window static again. Move down
4073 declaration of select_count.
4074 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4075 (Fother_window): Move to window.el.
4076 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4077 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4078 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4080 (replace_buffer_in_windows): Implement by calling
4081 Qreplace_buffer_in_windows.
4082 (replace_buffer_in_all_windows): Remove with some functionality
4083 moved into replace_buffer_in_windows_safely.
4084 (replace_buffer_in_windows_safely): New function.
4085 (select_window_norecord, select_frame_norecord): Move in front
4086 of run_window_configuration_change_hook. Remove now obsolete
4088 (Fset_window_buffer): Rewrite doc-string.
4089 Call Qrecord_window_buffer.
4090 (keys_of_window): Move binding for other-window to window.el.
4092 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4094 * dispextern.h (struct image): Replace data member, whose int_val
4095 and ptr_val fields were not used by anything, with a single
4098 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4099 (gif_clear_image, gif_load, imagemagick_load_image)
4100 (gs_clear_image, gs_load): Callers changed.
4102 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4104 * buffer.h: Include <time.h>, for time_t.
4105 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4107 Fix minor problems found by static checking.
4109 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4111 Make identifiers static if they are not used in other modules.
4112 * data.c (Qcompiled_function, Qframe, Qvector):
4113 * image.c (QimageMagick, Qsvg):
4114 * minibuf.c (Qmetadata):
4115 * window.c (resize_window_check, resize_root_window): Now static.
4116 * window.h (resize_window_check, resize_root_window): Remove decls.
4118 * window.c (window_deletion_count, delete_deletable_window):
4120 (window_body_lines): Now static.
4121 (Fdelete_other_windows_internal): Mark vars as initialized.
4122 Make sure 'resize_failed' is initialized.
4123 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4124 (resize_window_apply): Remove unused local.
4125 * window.h (delete_deletable_window): Remove decl.
4127 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4128 (imagemagick_load_image): Fix pointer signedness problem by changing
4129 last arg from unsigned char * to char *. All uses changed.
4130 Also, fix a local for similar reasons.
4131 Remove unused locals. Remove locals to avoid shadowing.
4132 (fn_rsvg_handle_free): Remove; unused.
4133 (svg_load, svg_load_image): Fix pointer signedness problem.
4134 (imagemagick_load_image): Don't use garbage pointer image_wand.
4136 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4138 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4140 * image.c (gif_load): Fix omitted cast error introduced by
4143 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4145 * window.h (resize_proportionally, orig_total_lines)
4146 (orig_top_line): Remove from window structure.
4147 (set_window_height, set_window_width, change_window_heights)
4148 (Fdelete_window): Remove prototypes.
4149 (resize_frame_windows): Remove duplicate declaration.
4151 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4153 * window.h (resize_frame_windows, resize_window_check)
4154 (delete_deletable_window, resize_root_window)
4155 (resize_frame_windows): Declare prototypes.
4157 * window.c (resize_window_apply): Make definition be "static" to
4158 match the prototype.
4160 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4162 * window.c: Remove declarations of Qwindow_size_fixed,
4163 window_min_size_1, window_min_size_2, window_min_size,
4164 size_window, window_fixed_size_p, enlarge_window, delete_window.
4165 Remove static from declaration of Qdelete_window, it's
4166 temporarily needed by Fbury_buffer.
4167 (replace_window): Don't assign orig_top_line and
4169 (Fdelete_window, delete_window): Remove. Window deletion is
4170 handled by window.el.
4171 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4172 Replace Fdelete_window calls with calls to Qdelete_window.
4173 (Fdelete_other_windows): Remove. Deleting other windows is
4174 handled by window.el.
4175 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4176 handled in window.el.
4177 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4178 Window minimum sizes are handled in window.el.
4179 (shrink_windows, size_window, set_window_height)
4180 (set_window_width, change_window_heights, window_height)
4181 (window_width, CURBEG, CURSIZE, enlarge_window)
4182 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4183 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4184 handled in window.el.
4185 (make_dummy_parent): Rename to make_parent_window and give it a
4186 second argument horflag.
4187 (make_window): Don't set resize_proportionally any more.
4188 (Fsplit_window): Remove. Windows are split in window.el.
4189 (save_restore_action, save_restore_orig_size)
4190 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4191 Resize mini windows in window.el.
4192 (grow_mini_window, shrink_mini_window): Implement by calling
4193 Qresize_root_window_vertically, resize_window_check and
4194 resize_window_apply.
4195 (saved_window, Fset_window_configuration, save_window_save):
4196 Do not handle orig_top_line, orig_total_lines, and
4197 resize_proportionally.
4198 (window_min_height, window_min_width): Move to window.el.
4199 (keys_of_window): Move bindings for delete-other-windows,
4200 split-window, delete-window and enlarge-window to window.el.
4202 * buffer.c: Temporarily extern Qdelete_window.
4203 (Fbury_buffer): Temporarily call Qdelete_window instead of
4204 Fdelete_window (Fbury_buffer will move to window.el soon).
4206 * frame.c (set_menu_bar_lines_1): Remove code handling
4207 orig_top_line and orig_total_lines.
4209 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4210 set_window_height but set heights directly.
4211 (change_frame_size_1): Use resize_frame_windows.
4213 * xdisp.c (init_xdisp): Don't use set_window_height but set
4216 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4217 Use resize_frame_windows instead of change_window_heights and run
4218 run_window_configuration_change_hook.
4220 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4221 instead of change_window_heights and run
4222 run_window_configuration_change_hook.
4224 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4226 * window.c (replace_window): Rename second argument REPLACEMENT to
4227 NEW. New third argument SETFLAG. Rewrite.
4228 (delete_window, make_dummy_parent): Call replace_window with
4230 (window_list_1): Move down in code.
4231 (run_window_configuration_change_hook): Move set_buffer part
4232 before select_frame_norecord part in order to unwind correctly.
4233 Rename count1 to count.
4234 (recombine_windows, delete_deletable_window, resize_root_window)
4235 (Fdelete_other_windows_internal)
4236 (Frun_window_configuration_change_hook, make_parent_window)
4237 (resize_window_check, resize_window_apply, Fresize_window_apply)
4238 (resize_frame_windows, Fsplit_window_internal)
4239 (Fdelete_window_internal, Fresize_mini_window_internal):
4241 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4243 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4245 * window.h (window): Add some new members to window structure -
4246 normal_lines, normal_cols, new_total, new_normal, clone_number,
4247 splits, nest, prev_buffers, next_buffers.
4248 (WINDOW_TOTAL_SIZE): Move here from window.c.
4249 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4251 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4253 (make_dummy_parent): Set new members of windows structure.
4254 (make_window): Move down in code. Handle new members of window
4256 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4257 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4258 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4259 (Fset_window_prev_buffers, Fwindow_next_buffers)
4260 (Fset_window_next_buffers, Fset_window_clone_number):
4262 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4263 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4265 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4266 Argument WINDOW can be now internal window too.
4267 (Fwindow_use_time): Move up in code.
4268 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4270 (Fset_window_configuration, saved_window)
4271 (Fcurrent_window_configuration, save_window_save): Handle new
4272 members of window structure.
4273 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4274 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4275 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4276 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4277 Qget_mru_window, Qresize_root_window,
4278 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4279 Qauto_buffer_name; staticpro them.
4281 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4283 * window.c (Fwindow_total_size, Fwindow_left_column)
4284 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4285 (Fwindow_list_1): New functions.
4286 (window_box_text_cols): Replace with window_body_cols.
4287 (Fwindow_width, Fscroll_left, Fscroll_right):
4288 Use window_body_cols instead of window_box_text_cols.
4289 (delete_window, Fset_window_configuration):
4290 Call delete_all_subwindows with window as argument.
4291 (delete_all_subwindows): Take a window as argument and not a
4293 (window_loop): Remove handling of GET_LRU_WINDOW and
4295 (Fget_lru_window, Fget_largest_window): Move to window.el.
4297 * window.h: Extern window_body_cols instead of
4298 window_box_text_cols. delete_all_subwindows now takes a
4299 Lisp_Object as argument.
4301 * indent.c (compute_motion, Fcompute_motion):
4302 Use window_body_cols instead of window_box_text_cols.
4304 * frame.c (delete_frame): Call delete_all_subwindows with root
4307 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4309 * fns.c (Fputhash): Document return value.
4311 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4313 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4315 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4317 Cons<->int and similar integer overflow fixes (Bug#8794).
4319 Check for overflow when converting integer to cons and back.
4320 * charset.c (Fdefine_charset_internal, Fdecode_char):
4321 Use cons_to_unsigned to catch overflow.
4322 (Fencode_char): Use INTEGER_TO_CONS.
4323 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4324 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4325 * data.c (long_to_cons, cons_to_long): Remove.
4326 (cons_to_unsigned, cons_to_signed): New functions.
4327 These signal an error for invalid or out-of-range values.
4328 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4329 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4330 * font.c (Ffont_variation_glyphs):
4331 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4332 * lisp.h: Include <intprops.h>.
4333 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4334 (cons_to_signed, cons_to_unsigned): New decls.
4335 (long_to_cons, cons_to_long): Remove decls.
4336 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4337 (Fprimitive_undo): Use CONS_TO_INTEGER.
4338 * xfns.c (Fx_window_property): Likewise.
4339 * xselect.c: Include <limits.h>.
4340 (x_own_selection, selection_data_to_lisp_data):
4341 Use INTEGER_TO_CONS.
4342 (x_handle_selection_request, x_handle_selection_clear)
4343 (x_get_foreign_selection, Fx_disown_selection_internal)
4344 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4345 (lisp_data_to_selection_data): Use cons_to_unsigned.
4346 (x_fill_property_data): Use cons_to_signed.
4347 Report values out of range.
4349 Check for buffer and string overflow more precisely.
4350 * buffer.h (BUF_BYTES_MAX): New macro.
4351 * lisp.h (STRING_BYTES_MAX): New macro.
4352 * alloc.c (Fmake_string):
4353 * character.c (string_escape_byte8):
4354 * coding.c (coding_alloc_by_realloc):
4355 * doprnt.c (doprnt):
4356 * editfns.c (Fformat):
4358 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4359 since they may not be the same number.
4360 * editfns.c (Finsert_char):
4361 * fileio.c (Finsert_file_contents):
4362 Likewise for BUF_BYTES_MAX.
4364 * image.c: Use ptrdiff_t, not int, for sizes.
4365 (slurp_file): Switch from int to ptrdiff_t.
4367 (slurp_file): Check that file size fits in both size_t (for
4368 malloc) and ptrdiff_t (for sanity and safety).
4370 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4371 if b->modtime has its maximal value.
4373 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4375 Don't assume time_t can fit into int.
4376 * buffer.h (struct buffer.modtime): Now time_t, not int.
4377 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4378 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4380 Minor fixes for signed vs unsigned integers.
4381 * character.h (MAYBE_UNIFY_CHAR):
4382 * charset.c (maybe_unify_char):
4383 * keyboard.c (read_char, reorder_modifiers):
4384 XINT -> XFASTINT, since the integer must be nonnegative.
4385 * ftfont.c (ftfont_spec_pattern):
4386 * keymap.c (access_keymap, silly_event_symbol_error):
4387 XUINT -> XFASTINT, since the integer must be nonnegative.
4388 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4389 since it makes no difference and we prefer signed.
4390 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4391 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4394 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4396 * window.h (Fwindow_frame): Declare.
4398 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4400 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4401 (SPARE_MEMORY): Always define.
4402 (LARGE_REQUEST): Remove.
4403 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4405 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4407 * lisp.h: Move EXFUNS for Fframe_root_window,
4408 Fframe_first_window and Fset_frame_selected_window to window.h.
4410 * window.h: Move EXFUNS for Fframe_root_window,
4411 Fframe_first_window and Fset_frame_selected_window here from
4414 * frame.c (Fwindow_frame, Fframe_first_window)
4415 (Fframe_root_window, Fframe_selected_window)
4416 (Fset_frame_selected_window): Move to window.c.
4417 (Factive_minibuffer_window): Move to minibuf.c.
4418 (Fother_visible_frames_p): New function.
4420 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4422 * window.c (decode_window, decode_any_window): Move up in code.
4423 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4424 (inhibit_frame_unsplittable): Remove unused variable.
4425 (Fwindow_buffer): Move up and rewrite doc-string.
4426 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4427 (Fwindow_prev): New functions.
4428 (Fwindow_frame): Move here from frame.c. Accept any window as
4430 (Fframe_root_window, Fframe_first_window)
4431 (Fframe_selected_window): Move here from frame.c. Accept frame
4432 or arbitrary window as argument. Update doc-strings.
4433 (Fminibuffer_window): Move up in code.
4434 (Fwindow_minibuffer_p): Move up in code and simplify.
4435 (Fset_frame_selected_window): Move here from frame.c.
4437 (Fselected_window, select_window, Fselect_window): Move up in
4438 code. Minor doc-string fixes.
4440 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4442 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4443 Do not assume that spare memory exists; that assumption is valid
4444 only if SYSTEM_MALLOC.
4445 (LARGE_REQUEST): New macro, so that the issue of large requests
4446 is separated from the issue of spare memory.
4448 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4450 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4453 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4455 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4458 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4460 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4462 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4464 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4465 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4467 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4469 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4471 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4473 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4474 (x_clipboard_manager_save): Add return value.
4475 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4477 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4478 Obey Vx_select_enable_clipboard_manager. Catch errors in
4479 x_clipboard_manager_save (Bug#8779).
4480 (Vx_select_enable_clipboard_manager): New variable.
4481 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4483 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4485 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4487 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4489 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4490 in the current matrix if keep_current_p is non-zero.
4492 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4494 * bidi.c (bidi_level_of_next_char): Fix last change.
4496 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4498 Support bidi reordering of text covered by display properties.
4500 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4501 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4502 (bidi_cache_search, bidi_cache_iterator_state)
4503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4504 (bidi_level_of_next_char, bidi_move_to_visually_next):
4505 Support character positions inside a run of characters covered by a
4507 (bidi_paragraph_init, bidi_resolve_explicit_1)
4508 (bidi_level_of_next_char): Call bidi_fetch_char and
4509 bidi_fetch_char_advance instead of FETCH_CHAR and
4511 (bidi_init_it): Initialize new members.
4512 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4514 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4515 instead of using explicit *_CHAR codes.
4516 (bidi_resolve_explicit, bidi_resolve_weak):
4517 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4518 bidirectional text is supported only in multibyte buffers.
4519 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4520 it to initialize the frame_window_p member of struct bidi_it.
4521 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4522 (bidi_resolve_explicit, bidi_resolve_weak)
4523 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4524 bidi_it->nchars is non-positive.
4525 (bidi_level_of_next_char): Don't try to lookup the cache for the
4526 next/previous character if nothing is cached there yet, or if we
4527 were just reseat()'ed to a new position.
4529 * xdisp.c (set_cursor_from_row): Set start and stop points
4530 according to the row's direction when priming the loop that looks
4531 for the glyph on which to display cursor.
4532 (single_display_spec_intangible_p): Function deleted.
4533 (display_prop_intangible_p): Reimplement to call
4534 handle_display_spec instead of single_display_spec_intangible_p.
4535 Accept 3 additional arguments needed by handle_display_spec.
4536 This fixes incorrect cursor motion across display property with complex
4537 values: lists, `(when COND...)' forms, etc.
4538 (single_display_spec_string_p): Support property values that are
4539 lists with the argument STRING its top-level element.
4540 (display_prop_string_p): Fix the condition for processing a
4541 property that is a list to be consistent with handle_display_spec.
4542 (handle_display_spec): New function, refactored from the
4543 last portion of handle_display_prop.
4544 (compute_display_string_pos): Accept additional argument
4545 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4546 value of a `display' property is a "replacing spec".
4547 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4548 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4549 the display property, but just return a value indicating whether
4550 the display property will replace the characters it covers.
4551 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4552 frame_window_p members of struct bidi_it.
4553 (compute_display_string_pos, compute_display_string_end):
4555 (push_it): Accept second argument POSITION, where pop_it should
4556 jump to continue iteration.
4557 (reseat_1): Initialize bidi_it.disp_pos.
4559 * keyboard.c (adjust_point_for_property): Adjust the call to
4560 display_prop_intangible_p to its new signature.
4562 * dispextern.h (struct bidi_it): New member frame_window_p.
4563 (bidi_init_it): Update prototypes.
4564 (display_prop_intangible_p): Update prototype.
4565 (compute_display_string_pos, compute_display_string_end):
4567 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4570 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4572 Malloc failure behavior now depends on size of allocation.
4573 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4574 * lisp.h: Change signatures accordingly.
4575 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4576 All callers changed. (Bug#8762)
4578 * gnutls.c: Use Emacs's memory allocators.
4579 Without this change, the gnutls library would invoke malloc etc.
4580 directly, which causes problems on non-SYNC_INPUT hosts, and which
4581 runs afoul of improving memory_full behavior. (Bug#8761)
4582 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4583 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4584 xfree instead of the default malloc, realloc, free.
4585 (Fgnutls_boot): No need to check for memory allocation failure,
4586 since xmalloc does that for us.
4588 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4589 * category.c (hash_get_category_set):
4590 * ccl.c (ccl_driver):
4591 * charset.c (Fdefine_charset_internal):
4592 * charset.h (struct charset.hash_index):
4593 * composite.c (get_composition_id, gstring_lookup_cache)
4594 (composition_gstring_put_cache):
4595 * composite.h (struct composition.hash_index):
4596 * dispextern.h (struct image.hash):
4597 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4598 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4599 (hashfn_equal, hashfn_user_defined, make_hash_table)
4600 (maybe_resize_hash_table, hash_lookup, hash_put)
4601 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4602 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4603 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4604 * image.c (make_image, search_image_cache, lookup_image)
4605 (xpm_put_color_table_h):
4606 * lisp.h (struct Lisp_Hash_Table):
4607 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4608 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4609 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4610 * alloc.c (allocate_vectorlike):
4611 Check for overflow in vector size calculations.
4612 * ccl.c (ccl_driver):
4613 Check for overflow when converting EMACS_INT to int.
4614 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4615 need to be updated by these changes.
4616 * fns.c (make_hash_table, maybe_resize_hash_table):
4617 Check for integer overflow with large hash tables.
4618 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4619 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4620 (SXHASH_REDUCE): New macro.
4621 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4622 Use it instead of discarding useful hash info with large hash values.
4623 (sxhash_float): New function.
4624 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4625 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4626 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4627 Rewrite to use FIXNUM_BITS, as this simplifies things.
4628 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4629 Adjust signatures to match updated version of code.
4630 (consing_since_gc): Now EMACS_INT, since a single hash table can
4631 use more than INT_MAX bytes.
4633 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4635 Make it possible to build with GCC-4.6+ -O2 -flto.
4637 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4639 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4641 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4642 Call minibuffer-inactive-mode.
4644 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4646 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4647 Update dependencies.
4649 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4651 * data.c (init_data): Remove code for UTS, this system is not
4654 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4656 Don't force ./temacs to start in terminal mode.
4658 * frame.c (make_initial_frame): Initialize faces in all cases, not
4659 only when CANNOT_DUMP is defined.
4660 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4662 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4664 * dispnew.c (add_window_display_history): Use const for the string
4665 pointer. Remove declaration, not needed.
4667 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4669 Use 'inline', not 'INLINE'.
4670 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4671 * alloc.c, fontset.c (INLINE): Remove.
4672 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4673 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4674 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4675 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4676 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4678 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4680 Make it possible to run ./temacs.
4682 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4683 syms_of_callproc does the same thing. Remove test for
4684 "initialized", do it in the caller.
4685 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4687 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4689 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4690 (read_minibuf): Use get_minibuffer.
4691 (syms_of_minibuf): Use DEFSYM.
4692 (Qmetadata): New var.
4693 * data.c (Qbuffer): Don't make it static.
4694 (syms_of_data): Use DEFSYM.
4696 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4698 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4699 (CCL_CODE_MIN): New macro.
4701 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4703 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4705 * eval.c (Qdebug): Now static.
4706 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4707 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4708 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4710 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4712 * image.c: Various fixes to ImageMagick code comments.
4713 (Fimagemagick_types): Doc fix.
4715 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4717 Minor fixes prompted by GCC 4.6.0 warnings.
4719 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4721 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4722 (x_clipboard_manager_save_all): Move extern decl to ...
4723 * xterm.h: ... here, so that it can be checked for consistency.
4725 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4727 * xselect.c (x_clipboard_manager_save_frame)
4728 (x_clipboard_manager_save_all): New functions.
4729 (Fx_clipboard_manager_save): Lisp function deleted.
4731 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4732 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4734 * xterm.h: Update prototype.
4736 2011-05-28 William Xu <william.xwl@gmail.com>
4738 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4741 2011-05-28 Jim Meyering <meyering@redhat.com>
4743 Avoid a sign-extension bug in crypto_hash_function.
4744 * fns.c (to_uchar): Define.
4745 (crypto_hash_function): Use it to convert some newly-signed
4746 variables to unsigned, to avoid sign-extension bugs. For example,
4747 without this change, (md5 "truc") would evaluate to
4748 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4749 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4750 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4752 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4754 Integer overflow fixes.
4756 * dbusbind.c: Serial number integer overflow fixes.
4757 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4758 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4759 to hold a serial number that is too large for a fixnum.
4760 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4761 Check for serial numbers out of range. Decode any serial number
4762 that was so large that it became a float. (Bug#8722)
4764 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4765 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4766 Use XFASTINT rather than XUINT when numbers are nonnegative.
4767 (xd_append_arg, Fdbus_method_return_internal):
4768 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4769 arguments, check that Lisp number is nonnegative, rather than
4770 silently wrapping negative numbers around. (Bug#8722)
4771 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4774 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4776 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4778 ccl: add integer overflow checks
4779 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4780 (IN_INT_RANGE): New macros.
4781 (ccl_driver): Use them to check for integer overflow when
4782 decoding a CCL program. Many of the new checks are whether XINT (x)
4783 fits in int; it doesn't always, on 64-bit hosts. The new version
4784 doesn't catch all possible integer overflows, but it's an
4785 improvement. (Bug#8719)
4787 * alloc.c (make_event_array): Use XINT, not XUINT.
4788 There's no need for unsigned here.
4790 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4791 This follows up to the 2011-05-06 change that substituted uintptr_t
4792 for EMACS_INT. This case wasn't caught back then.
4794 Rework Fformat to avoid integer overflow issues.
4795 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4796 now (part of C89). Include <verify.h>.
4797 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4798 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4799 (Fformat): Avoid the prepass trying to compute sizes; it was only
4800 approximate and thus did not catch overflow reliably. Instead, walk
4801 through the format just once, formatting and computing sizes as we go,
4802 checking for integer overflow at every step, and allocating a larger
4803 buffer as needed. Keep track separately whether the format is
4804 multibyte. Keep only the most-recently calculated precision, rather
4805 than them all. Record whether each argument has been converted to
4806 string. Use EMACS_INT, not int, for byte and char and arg counts.
4807 Support field widths and precisions larger than INT_MAX. Avoid
4808 sprintf's undefined behavior with conversion specifications such as %#d
4809 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4810 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4811 formatting out-of-range floating point numbers with int
4814 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4816 * data.c: Avoid integer truncation in expressions involving floats.
4817 * data.c: Include <intprops.h>.
4818 (arith_driver): When there's an integer overflow in an expression
4819 involving floating point, convert the integers to floating point
4820 so that the resulting value does not suffer from catastrophic
4821 integer truncation. For example, on a 64-bit host (* 4
4822 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4823 Do not rely on undefined behavior after integer overflow.
4825 merge count_size_as_multibyte, parse_str_to_multibyte
4826 * character.c, character.h (count_size_as_multibyte):
4827 Rename from parse_str_to_multibyte; all uses changed.
4828 Check for integer overflow.
4829 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4830 since it's now a duplicate of the other. This is more of
4831 a character than a buffer op, so better that it's in character.c.
4832 * fns.c, print.c: Adjust to above changes.
4834 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4836 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4838 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4840 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4841 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4842 (x_clipboard_manager_save): Now static.
4843 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4845 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4846 (crypto_hash_function): Now static.
4847 Fix pointer signedness problems. Avoid unnecessary initializations.
4849 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4851 * termhooks.h (Vselection_alist): Make it terminal-local.
4853 * terminal.c (create_terminal): Initialize it.
4855 * xselect.c: Support for clipboard managers.
4856 (Vselection_alist): Move to termhooks.h as terminal-local var.
4857 (LOCAL_SELECTION): New macro.
4858 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4859 (symbol_to_x_atom): Remove gratuitous arg.
4860 (x_handle_selection_request, lisp_data_to_selection_data)
4861 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4862 (x_own_selection, x_get_local_selection, x_convert_selection):
4863 New arg, specifying work frame. Use terminal-local Vselection_alist.
4864 (some_frame_on_display): Delete unused function.
4865 (Fx_own_selection_internal, Fx_get_selection_internal)
4866 (Fx_disown_selection_internal, Fx_selection_owner_p)
4867 (Fx_selection_exists_p): New optional frame arg.
4868 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4869 (x_handle_selection_clear): Don't treat other terminals with the
4870 same keyboard specially. Use the terminal-local Vselection_alist.
4871 (x_clear_frame_selections): Use Frun_hook_with_args.
4873 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4875 * xterm.h: Add support for those atoms.
4877 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4879 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4880 (converted_selections, conversion_fail_tag): New global variables.
4881 (x_selection_request_lisp_error): Free the above.
4882 (x_get_local_selection): Remove unnecessary code.
4883 (x_reply_selection_request): Args changed; handle arbitrary array
4884 of converted selections stored in converted_selections.
4885 Separate the XChangeProperty and SelectionNotify steps.
4886 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4887 (x_convert_selection): New function.
4888 (x_handle_selection_event): Simplify.
4889 (x_get_foreign_selection): Don't ignore incoming requests while
4890 waiting for an answer; this will fail when we implement
4891 SAVE_TARGETS, and seems unnecessary anyway.
4892 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4893 (Vx_sent_selection_functions): Doc fix.
4895 2011-05-26 Leo Liu <sdl.web@gmail.com>
4897 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4899 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4901 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4903 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4904 for fringe update if it has periodic bitmap.
4905 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4906 and fringe_bitmap_periodic_p.
4908 * fringe.c (get_fringe_bitmap_data): New function.
4909 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4910 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4911 row. Mark glyph row for fringe update if periodicity changed.
4913 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4914 for fringe update unless it has periodic bitmap.
4916 2011-05-25 Kenichi Handa <handa@m17n.org>
4918 * xdisp.c (get_next_display_element): Set correct it->face_id for
4919 a static composition.
4921 2011-05-24 Leo Liu <sdl.web@gmail.com>
4924 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4926 * fns.c (crypto_hash_function, Fsha1): New function.
4927 (Fmd5): Use crypto_hash_function.
4928 (syms_of_fns): Add Ssha1.
4930 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4932 * gnutls.c: Remove unused macros.
4933 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4934 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4935 Remove macros that are defined and never used.
4936 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4938 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4940 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4941 (Fx_get_selection_internal): Minor cleanup.
4942 (Fx_own_selection_internal): Rename arguments for consistency with
4945 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4947 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4949 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4951 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4953 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4955 * dispnew.c (scrolling_window): Don't exclude the case that the
4956 last enabled row in the desired matrix touches the bottom boundary.
4958 2011-05-21 Glenn Morris <rgm@gnu.org>
4960 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4961 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4962 and add some more files.
4964 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4966 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4967 report_file_error introduced by the change from 2011-05-07.
4969 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4971 * systime.h (Time): Define only if emacs is defined.
4972 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4973 where the include path doesn't have X11/X.h by default. See
4974 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4976 2011-05-20 Kenichi Handa <handa@m17n.org>
4978 * composite.c (find_automatic_composition): Fix previous change.
4980 2011-05-20 Glenn Morris <rgm@gnu.org>
4982 * lisp.mk: New file, split from Makefile.in.
4983 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4984 (shortlisp): Remove.
4985 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4987 2011-05-19 Glenn Morris <rgm@gnu.org>
4989 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4990 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4991 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4992 (lisp): Set the order to that of loadup.el.
4993 (shortlisp): Make it a copy of $lisp.
4994 (SOME_MACHINE_LISP): Remove.
4995 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4996 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4998 2011-05-18 Kenichi Handa <handa@m17n.org>
5000 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5001 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5002 (find_automatic_composition): Mostly rewrite for efficiency.
5004 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5006 * makefile.w32-in: Update dependencies.
5008 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5010 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5011 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5013 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5015 Fix some integer overflow issues, such as string length overflow.
5017 * insdel.c (count_size_as_multibyte): Check for string overflow.
5019 * character.c (lisp_string_width): Check for string overflow.
5020 Use EMACS_INT, not int, for string indexes and lengths; in
5021 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5022 the resulting string length overflows an EMACS_INT; instead,
5023 report a string overflow if no precision given. When checking for
5024 precision exhaustion, use a check that cannot possibly have
5025 integer overflow. (Bug#8675)
5026 * character.h (lisp_string_width): Adjust to new signature.
5028 * alloc.c (string_overflow): New function.
5029 (Fmake_string): Use it. This doesn't change behavior, but saves
5030 a few bytes and will simplify future changes.
5031 * character.c (string_escape_byte8): Likewise.
5032 * lisp.h (string_overflow): New decl.
5034 Fixups, following up to the user-interface timestamp change.
5035 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5036 for UI timestamps, instead of unsigned long.
5037 * msdos.c (mouse_get_pos): Likewise.
5038 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5039 * w32gui.h (Time): Define by including "systime.h" rather than by
5040 declaring it ourselves. (Bug#8664)
5042 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5043 * image.c (clear_image_cache): Likewise.
5045 * term.c (term_mouse_position): Don't assume time_t wraparound.
5047 Be more systematic about user-interface timestamps.
5048 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5049 and sometimes 'EMACS_UINT', to represent these timestamps.
5050 This change causes it to use 'Time' uniformly, as that's what X uses.
5051 This makes the code easier to follow, and makes it easier to catch
5052 integer overflow bugs such as Bug#8664.
5053 * frame.c (Fmouse_position, Fmouse_pixel_position):
5054 Use Time, not unsigned long, for user-interface timestamps.
5055 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5056 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5057 * keyboard.h (last_event_timestamp): Likewise.
5058 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5059 * menu.h (xmenu_show): Likewise.
5060 * term.c (term_mouse_position): Likewise.
5061 * termhooks.h (struct input_event.timestamp): Likewise.
5062 (struct terminal.mouse_position_hook): Likewise.
5063 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5064 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5065 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5066 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5068 * menu.h, termhooks.h: Include "systime.h", for Time.
5070 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5071 Don't assume that the difference between two unsigned long values
5072 can fit into an integer. At this point, we know button_down_time
5073 <= event->timestamp, so the difference must be nonnegative, so
5074 there's no need to cast the result if double-click-time is
5075 nonnegative, as it should be; check that it's nonnegative, just in
5076 case. This bug is triggered when events are more than 2**31 ms
5077 apart (about 25 days). (Bug#8664)
5079 * xselect.c (last_event_timestamp): Remove duplicate decl.
5080 (x_own_selection): Remove needless cast to unsigned long.
5082 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5083 that always fit in int. Use a sentinel instead of a counter, to
5084 avoid a temp and to allay GCC's concerns about possible int overflow.
5085 * frame.h (struct frame): Use int for menu_bar_items_used
5086 instead of EMACS_INT, since it always fits in int.
5088 * menu.c (grow_menu_items): Check for int overflow.
5090 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5092 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5093 Before, the code was not consistent. These values cannot exceed
5094 2**31 - 1 so there's no need to make them unsigned.
5095 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5096 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5097 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5099 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5101 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5102 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5103 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5104 presumably because the widths might not match.
5106 * window.c (size_window): Avoid needless test at loop start.
5108 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5110 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5112 2011-05-12 Drew Adams <drew.adams@oracle.com>
5114 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5116 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5118 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5119 `width' to `bar_area_x' and `bar_area_width', respectively.
5120 (x_scroll_run): Take account of fringe background extension.
5122 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5123 Rename local vars `left' and `width' to `bar_area_x' and
5124 `bar_area_width', respectively.
5125 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5126 background extension.
5128 2011-05-10 Jim Meyering <meyering@redhat.com>
5130 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5132 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5134 * image.c (Finit_image_library): Return t for built-in image types,
5135 like pbm and xbm. (Bug#8640)
5137 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5139 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5141 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5143 * w32console.c (Fset_screen_color): Doc fix.
5144 (Fget_screen_color): New function.
5145 (syms_of_ntterm): Defsubr it.
5147 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5148 unlink the temporary file if Fcall_process didn't create it in the
5150 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5151 child process will be redirected to a file specified with `:file'.
5152 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5153 cue to call_process_cleanup not to close that handle.
5155 2011-05-07 Ben Key <bkey76@gmail.com>
5157 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5158 one of two shell specific rules, either bootstrap-temacs-CMD or
5159 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5160 to the previous implementation of the bootstrap-temacs rule.
5161 The bootstrap-temacs-CMD rule is similar to the previous
5162 implementation of the bootstrap-temacs rule except that it
5163 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5166 These changes, along with some changes to nt/configure.bat,
5167 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5168 earlier fix to add support for --cflags and --ldflags options
5169 that include quotes so that it works whether make uses cmd or
5172 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5174 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5175 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5177 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5178 a string. Handle both cases.
5179 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5180 (Fdbus_register_method): Use Qinvalid_function.
5182 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5184 * makefile.w32-in: Update dependencies.
5185 (LISP_H): Add inttypes.h and stdin.h.
5186 (PROCESS_H): Add unistd.h.
5188 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5190 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5191 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5193 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5195 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5197 * term.c (vfatal): Remove stray call to va_end.
5198 It's not needed and the C Standard doesn't allow it here anyway.
5200 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5201 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5203 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5206 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5208 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5210 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5212 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5214 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5216 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5217 * charset.c (Fdefine_charset_internal): Don't initialize
5218 charset.code_space[15]. The value was garbage, on hosts with
5219 32-bit int (Bug#8600).
5221 * lread.c (read_integer): Be more consistent with string-to-number.
5222 Use string_to_number to do the actual conversion; this avoids
5223 rounding errors and fixes some other screwups. Without this fix,
5224 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5225 (digit_to_number): Move earlier, for benefit of read_integer.
5226 Return -1 if the digit is out of range for the base, -2 if it is
5227 not a digit in any supported base. (Bug#8602)
5229 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5231 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5232 to match comment at start of function. This also removes a
5233 GCC warning about overflow in a 32+64-bit port.
5235 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5237 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5238 Reported by Stefan Monnier in
5239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5240 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5241 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5243 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5244 (EMACS_UINTPTR): Likewise, with uintptr_t.
5246 * lisp.h: Prefer 64-bit EMACS_INT if available.
5247 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5248 on 32-bit hosts that have 64-bit int, so that they can access
5250 However, temporarily disable this change unless the temporary
5251 symbol WIDE_EMACS_INT is defined.
5253 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5255 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5256 This removes an assumption that EMACS_INT and long are the same
5257 width as pointers. The assumption is true for Emacs porting targets
5258 now, but we want to make other targets possible.
5259 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5260 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5261 In the rest of the code, change types of integers that hold casted
5262 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5263 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5264 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5265 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5266 No need to cast type when ORing.
5267 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5268 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5269 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5270 assume EMACS_INT is the same width as char *.
5271 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5272 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5273 Remove no-longer-needed casts.
5274 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5275 (xg_tool_bar_help_callback, xg_make_tool_item):
5276 Use EMACS_INTPTR to hold an integer
5277 that will be cast to void *; this can avoid a GCC warning
5278 if EMACS_INT is not the same width as void *.
5279 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5280 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5281 (current_message_1, set_message_1):
5282 Use a local to convert to proper width without a cast.
5283 * xmenu.c (dialog_selection_callback): Likewise.
5285 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5286 Also, don't assume VALBITS / RAND_BITS is less than 5,
5287 and don't rely on undefined behavior when shifting a 1 left into
5289 * lisp.h (get_random): Change signature to match.
5291 * lread.c (hash_string): Use size_t, not int, for hash computation.
5292 Normally we prefer signed values; but hashing is special, because
5293 it's better to use unsigned division on hash table sizes so that
5294 the remainder is nonnegative. Also, size_t is the natural width
5295 for hashing into memory. The previous code used 'int', which doesn't
5296 retain enough info to hash well into very large tables.
5297 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5299 * dbusbind.c: Don't possibly lose pointer info when converting.
5300 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5301 Use XPNTR rather than XHASH, so that the high-order bits of
5302 the pointer aren't lost when converting through void *.
5304 * eval.c (Fautoload): Don't double-shift a pointer.
5306 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5308 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5310 * gnutls.c (DEF_GNUTLS_FN):
5311 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5313 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5315 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5318 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5320 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5321 New version that can reserve upto 2GB of heap space.
5323 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5325 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5327 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5329 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5330 `gnutls_certificate_set_x509_key_file'.
5332 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5334 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5335 Update dependencies.
5337 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5339 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5340 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5341 Remove unused parameter `fildes'.
5342 * process.c (read_process_output, send_process): Don't pass it.
5344 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5346 Fix previous change: the library cache is defined in w32.c.
5347 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5348 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5350 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5352 Implement dynamic loading of GnuTLS on Windows.
5354 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5355 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5356 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5359 * gnutls.c (Qgnutls_dll): Define.
5360 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5361 (gnutls_*): Declare function pointers.
5362 (init_gnutls_functions): New function to initialize function pointers.
5363 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5364 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5365 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5366 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5367 (emacs_gnutls_write, emacs_gnutls_read)
5368 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5369 (Fgnutls_available_p): New function.
5370 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5371 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5372 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5374 * image.c: Include w32.h.
5375 (Vimage_type_cache): Delete.
5376 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5377 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5378 (w32_delayed_load): Move to w32.c.
5380 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5382 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5383 (w32_delayed_load): Move from image.c. When loading a library, record
5384 its filename in the :loaded-from property of the library id.
5385 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5386 Initialize and staticpro them.
5387 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5389 * process.c: Include lisp.h before w32.h, not after.
5390 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5391 instead of gnutls_record_check_pending.
5393 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5395 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5397 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5398 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5401 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5403 * xterm.c (x_set_frame_alpha): Do not set property on anything
5404 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5406 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5408 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5410 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5412 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5413 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5414 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5415 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5416 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5417 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5418 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5419 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5420 (Qgnutls_bootprop_callbacks_verify): Make static.
5422 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5424 * callproc.c: Indentation fixup.
5426 * sysdep.c (wait_for_termination_1): Make static.
5427 (wait_for_termination, interruptible_wait_for_termination):
5428 Move after wait_for_termination_1.
5430 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5432 * sysdep.c (interruptible_wait_for_termination): New function
5433 which is like wait_for_termination, but allows keyboard
5436 * callproc.c (Fcall_process): Add (:file "file") as an option for
5438 (Fcall_process_region): Ditto.
5440 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5442 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5443 rather than `XVECTOR (FOO)->size'.
5445 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5446 inttypes.h, as a gnulib replacement is used if it not available in
5449 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5451 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5452 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5453 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5455 * coding.c (coding_alloc_by_realloc): Error out if destination
5456 will grow beyond MOST_POSITIVE_FIXNUM.
5457 (decode_coding_emacs_mule): Abort if there isn't enough place in
5458 charbuf for the composition carryover bytes. Reserve an extra
5459 space for up to 2 characters produced in a loop.
5460 (decode_coding_iso_2022): Abort if there isn't enough place in
5461 charbuf for the composition carryover bytes.
5463 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5465 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5466 aborting when %lld or %lll format is passed.
5467 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5468 %llo or %llx format is passed. (Bug#8545)
5470 * window.c (window_scroll_line_based): Use a marker instead of
5471 simple variables to record original value of point. (Bug#7952)
5473 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5474 produced by %s or %c overflows available buffer space. (Bug#8545)
5476 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5478 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5479 (SIZE_MAX): Move defn after all includes, as they might #define it.
5481 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5483 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5485 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5487 * keyboard.c (Qdelayed_warnings_hook): Define.
5488 (command_loop_1): Run `delayed-warnings-hook'
5489 if Vdelayed_warnings_list is non-nil.
5490 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5491 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5493 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5495 * doprnt.c (doprnt): Don't return value smaller than the buffer
5496 size if the message was truncated. (Bug#8545).
5498 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5500 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5501 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5503 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5505 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5507 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5509 * makefile.w32-in: Update dependencies.
5511 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5513 Improve `doprnt' and its usage. (Bug#8545)
5514 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5515 `format_end'. Remove support for %l as a conversion specifier.
5516 Don't use xrealloc. Improve diagnostics when the %l size modifier
5517 is used. Update the commentary.
5519 * eval.c (verror): Simplify calculation of size_t.
5521 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5524 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5526 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5529 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5531 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5532 This makes this file independent of the recent pseudovector change.
5534 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5536 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5538 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5539 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5540 Remove unused local.
5541 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5543 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5544 GCC 4.6.0 optimizes based on type-based alias analysis.
5545 For example, if b is of type struct buffer * and v of type struct
5546 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5547 != &v->size, and therefore "v->size = 1; b->size = 2; return
5548 v->size;" must therefore return 1. This assumption is incorrect
5549 for Emacs, since it type-puns struct Lisp_Vector * with many other
5550 types. To fix this problem, this patch adds a new type struct
5551 vectorlike_header that documents the constraints on layout of vectors
5552 and pseudovectors, and helps optimizing compilers not get fooled
5553 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5554 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5555 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5557 (XSETPVECTYPE): Rewrite in terms of new macro.
5558 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5559 This is a bit clearer, and further avoids the possibility of
5560 undesirable aliasing.
5561 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5562 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5563 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5564 since Lisp_Subr is a special case (no "next" field).
5565 (ASIZE): Now uses header.size rather than size.
5566 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5567 to avoid the hassle of writing XVECTOR (foo)->header.size.
5568 (struct vectorlike_header): New type.
5569 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5570 object, to help avoid aliasing.
5571 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5572 (SUBRP): Likewise, since Lisp_Subr is a special case.
5573 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5574 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5575 (struct Lisp_Hash_Table): Combine first two members into a single
5576 struct vectorlike_header member. All uses of "size" and "next" members
5577 changed to be "header.size" and "header.next".
5578 * buffer.h (struct buffer): Likewise.
5579 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5580 * frame.h (struct frame): Likewise.
5581 * process.h (struct Lisp_Process): Likewise.
5582 * termhooks.h (struct terminal): Likewise.
5583 * window.c (struct save_window_data, struct saved_window): Likewise.
5584 * window.h (struct window): Likewise.
5585 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5586 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5587 * buffer.c (init_buffer_once): Likewise.
5588 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5590 * process.c (Fformat_network_address): Use local var for size,
5593 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5595 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5596 * data.c (atof): Remove decl; no longer used or needed.
5597 (digit_to_number): Move to lread.c.
5598 (Fstring_to_number): Use new string_to_number function, to be
5599 consistent with how the Lisp reader treats infinities and NaNs.
5600 Do not assume that floating-point numbers represent EMACS_INT
5601 without losing information; this is not true on most 64-bit hosts.
5602 Avoid double-rounding errors, by insisting on integers when
5603 parsing non-base-10 numbers, as the documentation specifies.
5604 * lisp.h (string_to_number): New decl, replacing ...
5605 (isfloat_string): Remove.
5606 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5607 (read1): Do not accept +. and -. as integers; this
5608 appears to have been a coding error. Similarly, do not accept
5609 strings like +-1e0 as floating point numbers. Do not report
5610 overflow for integer overflows unless the base is not 10 which
5611 means we have no simple and reliable way to continue.
5612 Break out the floating-point parsing into a new
5613 function string_to_number, so that Fstring_to_number parses
5614 floating point numbers consistently with the Lisp reader.
5615 (digit_to_number): Move here from data.c. Make it static inline.
5616 (E_CHAR, EXP_INT): Remove, replacing with ...
5617 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5618 (string_to_number): New function, replacing isfloat_string.
5619 This function checks for valid syntax and produces the resulting
5620 Lisp float number too. Rework it so that string-to-number
5621 no longer mishandles examples like "1.0e+". Use strtoumax,
5622 so that overflow for non-base-10 numbers is reported only when
5623 there's no portable and simple way to convert to floating point.
5625 * textprop.c (set_text_properties_1): Rewrite for clarity,
5626 and to avoid GCC warning about integer overflow.
5628 * intervals.h (struct interval): Use EMACS_INT for members
5629 where EMACS_UINT might cause problems. See
5630 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5631 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5632 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5634 (offset_intervals): Tell GCC not to worry about length overflow
5635 when negating a negative length.
5637 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5638 (overrun_check_free): Likewise.
5640 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5641 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5644 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5645 (gnutls_make_error): Rename local to avoid shadowing.
5646 (gnutls_emacs_global_deinit): ifdef out; not used.
5647 (Fgnutls_boot): Use const for pointer to readonly storage.
5648 Comment out unused local. Fix pointer signedness problems.
5650 * lread.c (openp): Don't stuff size_t into an 'int'.
5651 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5652 about possible signed overflow.
5654 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5655 (GDK_KEY_g): Don't define if already defined.
5656 (xg_prepare_tooltip): Avoid pointer signedness problem.
5657 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5659 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5660 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5662 * xfns.c (Fx_window_property): Simplify a bit,
5663 to make a bit faster and to avoid GCC 4.6.0 warning.
5664 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5666 * fns.c (internal_equal): Don't assume size_t fits in int.
5668 * alloc.c (compact_small_strings): Tighten assertion a little.
5670 Replace pEd with more-general pI, and fix some printf arg casts.
5671 * lisp.h (pI): New macro, generalizing old pEd macro to other
5672 conversion specifiers. For example, use "...%"pI"d..." rather
5673 than "...%"pEd"...".
5674 (pEd): Remove. All uses replaced with similar uses of pI.
5675 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5676 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5677 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5678 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5679 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5680 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5681 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5683 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5684 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5685 * print.c (safe_debug_print, print_object): Likewise.
5686 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5688 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5689 avoiding the 0 flag, which is not portable.
5690 * process.c (Fmake_network_process): Use pI to avoid cast.
5691 * region-cache.c (pp_cache): Likewise.
5692 * xdisp.c (decode_mode_spec): Likewise.
5693 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5694 behavior on 64-bit hosts with printf arg.
5695 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5696 (x_stop_queuing_selection_requests): Likewise.
5697 (x_get_window_property): Don't truncate byte count to an 'int'
5700 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5701 here, since it parses constructs like leading '-' and spaces,
5702 which are not wanted; and it overflows with large numbers.
5703 Instead, simply match F[0-9]+, which is what is wanted anyway.
5705 * alloc.c: Remove unportable assumptions about struct layout.
5706 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5707 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5708 (allocate_vectorlike, make_pure_vector): Use the new macros,
5709 plus offsetof, to remove unportable assumptions about struct layout.
5710 These assumptions hold on all porting targets that I know of, but
5711 they are not guaranteed, they're easy to remove, and removing them
5712 makes further changes easier.
5714 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5715 This doesn't fix a bug but makes the code clearer.
5716 (string_overrun_cookie): Now const. Use initializers that
5717 don't formally overflow signed char, to avoid warnings.
5718 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5719 can cause Emacs to crash when string overrun checking is enabled.
5720 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5721 multiple of sizeof (EMACS_INT); it need not be, if
5722 alignof(EMACS_INT) < sizeof (EMACS_INT).
5723 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5725 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5727 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5729 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5731 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5732 supposed to be handshaking. (Bug#8556)
5733 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5735 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5737 * lisp.h (Qdebug): List symbol.
5738 * eval.c (Qdebug): Restore global linkage.
5739 * keyboard.c (debug-on-event): New variable.
5740 (handle_user_signal): Break into debugger when debug-on-event
5741 matches the current signal symbol.
5743 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5745 * alloc.c (check_sblock, check_string_bytes)
5746 (check_string_free_list): Convert to standard C.
5748 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5750 * w32.c (emacs_gnutls_push): Fix typo.
5752 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5754 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5755 "cast to pointer from integer of different size".
5757 Improve doprnt and its use in verror. (Bug#8545)
5758 * doprnt.c (doprnt): Document the set of format control sequences
5759 supported by the function. Use SAFE_ALLOCA instead of always
5762 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5763 is one byte too soon. Don't use xrealloc; instead xfree and
5766 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5768 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5771 * gnutls.c: Renamed global_initialized to
5772 gnutls_global_initialized. Added internals for the
5773 :verify-hostname-error, :verify-error, and :verify-flags
5774 parameters of `gnutls-boot' and documented those parameters in the
5775 docstring. Start callback support.
5776 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5777 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5778 on error. Return error code.
5779 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5780 (emacs_gnutls_read): Likewise.
5781 (Fgnutls_boot): Return handshake error code.
5782 (emacs_gnutls_handle_error): New function.
5783 (wsaerror_to_errno): Likewise.
5785 * w32.h (emacs_gnutls_pull): Add prototype.
5786 (emacs_gnutls_push): Likewise.
5788 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5789 (emacs_gnutls_push): Likewise.
5791 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5793 * process.c (wait_reading_process_output): Check if GnuTLS
5794 buffered some data internally if no FDs are set for TLS
5797 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5798 (LIBS): Link to USER_LIBS.
5799 ($(BLD)/gnutls.$(0)): New target.
5801 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5803 * xdisp.c (handle_single_display_spec): Rename the
5804 display_replaced_before_p argument into display_replaced_p, to
5805 make it consistent with the commentary. Fix typos in the
5808 * textprop.c (syms_of_textprop): Remove dead code.
5809 (copy_text_properties): Delete obsolete commentary about an
5810 interface that was deleted long ago. Fix typos in the description
5813 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5814 to changes in oldXMenu/XMenu.h from 2011-04-16.
5815 <menu_help_message, prev_menu_help_message>: Constify.
5816 (IT_menu_make_room): menu->help_text is now `const char **';
5819 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5820 to changes in oldXMenu/XMenu.h from 2011-04-16.
5821 (struct XMenu): Declare `help_text' `const char **'.
5823 * xfaces.c <Qunspecified>: Make extern again.
5825 * syntax.c: Include sys/types.h before including regex.h, as
5828 * doc.c (get_doc_string): Improve the format passed to `error'.
5830 * doprnt.c (doprnt): Improve commentary.
5832 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5834 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5837 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5838 changes in globals.h immediately force recompilation.
5839 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5840 $(CURDIR)/s/ms-w32.h.
5841 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5843 * character.c (Fchar_direction): Function deleted.
5844 (syms_of_character): Don't defsubr it.
5845 <char-direction-table>: Deleted.
5847 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5849 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5850 * doprnt.c: Include limits.h.
5851 (SIZE_MAX): New macro.
5852 (doprnt): Return a size_t value. 2nd arg is now size_t.
5853 Many local variables are now size_t instead of int or unsigned.
5854 Improve overflow protection. Support `l' modifier for integer
5855 conversions. Support %l conversion. Don't assume an EMACS_INT
5856 argument for integer conversions and for %c.
5858 * lisp.h (doprnt): Restore prototype.
5860 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5863 * Makefile.in (base_obj): Add back doprnt.o.
5865 * deps.mk (doprnt.o): Add back prerequisites.
5866 (callint.o): Depend on character.h.
5868 * eval.c (internal_lisp_condition_case): Include the handler
5869 representation in the error message.
5870 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5871 when breaking from the loop.
5873 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5875 * callint.c (Fcall_interactively): When displaying error message
5876 about invalid control letter, pass the character's codepoint, not
5877 a pointer to its multibyte form. Improve display of the character
5878 in octal and display also its hex code.
5880 * character.c (char_string): Use %x to display the (unsigned)
5881 codepoint of an invalid character, to avoid displaying a bogus
5884 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5885 `error', not SYMBOL_NAME itself.
5887 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5888 character arguments to `error'.
5890 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5891 to `error' in error message about FINAL_CHAR argument. Make sure
5892 FINAL_CHAR is a character, and use %c when it is passed as
5893 argument to `error'.
5895 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5897 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5899 * w32.c: Include <time.h>.
5900 (sys_localtime): New function.
5902 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5904 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5906 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5908 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5910 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5913 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5915 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5916 gl_state.e_property when gl_state.object is Qt.
5918 * insdel.c (make_gap_larger): Remove limitation of buffer size
5921 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5923 * xdisp.c (lookup_glyphless_char_display)
5924 (produce_glyphless_glyph): Handle cons cell entry in
5925 glyphless-char-display.
5926 (Vglyphless_char_display): Document it.
5928 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5929 glyphless-char-display.
5931 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5933 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5935 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5937 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5938 definition for no-X builds.
5940 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5942 Static checks with GCC 4.6.0 and non-default toolkits.
5944 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5946 * process.c (keyboard_bit_set): Define only if SIGIO.
5947 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5948 (send_process): Repair possible setjmp clobbering.
5950 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5952 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5954 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5956 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5957 Define only if needed.
5959 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5960 by pacifying GCC about it. Maybe it's time to retire it?
5961 * xfaces.c (USG, __TIMEVAL__): Likewise.
5963 * dispextern.h (struct redisplay_interface): Rename param
5965 * termhooks.h (struct terminal): Likewise.
5966 * xterm.c (xembed_send_message): Likewise.
5968 * insdel.c (make_gap_smaller): Define only if
5969 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5971 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5974 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5975 so that we aren't warned about unused symbols.
5977 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5979 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5981 * xfns.c (x_real_positions): Mark locals as initialized.
5983 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5985 * xterm.c: Fix problems found by static analysis with other toolkits.
5986 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5987 (x_dispatch_event): Declare static if USE_GTK, and
5988 define if USE_GTK || USE_X_TOOLKIT.
5989 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5990 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5991 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5992 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5994 * xmenu.c (menu_help_callback): Pointer type fixes.
5995 Use const pointers when pointing at readonly data. Avoid pointer
5997 (FALSE): Remove unused macro.
5998 (update_frame_menubar): Remove unused decl.
6000 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6002 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6003 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6004 (single_menu_item): Rename local to avoid shadowing.
6006 * keyboard.c (make_lispy_event): Remove unused local var.
6008 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6009 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6011 * bitmaps: Change bitmaps from unsigned char back to the X11
6012 compatible char. Avoid the old compiler warnings about
6013 out-of-range initializers by using, for example, '\xab' rather
6016 * xgselect.c (xgselect_initialize): Check vs interface
6017 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6019 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6021 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6022 to read-only memory.
6024 * fns.c (vector): Remove; this old hack is no longer needed.
6026 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6028 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6030 * xrdb.c (x_load_resources): Omit unused local.
6032 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6033 (x_window): Rename locals to avoid shadowing.
6034 (USG): Use the kludged USG macro, to pacify gcc.
6036 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6037 (x_term_init): Remove local to avoid shadowing.
6039 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6041 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6042 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6044 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6046 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6048 Fix regex.c, syntax.c and friends for buffers > 2GB.
6049 * syntax.h (struct gl_state_s): Declare character position members
6052 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6054 * textprop.c (verify_interval_modification, interval_of):
6055 Declare arguments EMACS_INT.
6057 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6060 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6062 * indent.c (Fvertical_motion): Local variable it_start is now
6065 * regex.c (re_match, re_match_2, re_match_2_internal)
6066 (bcmp_translate, regcomp, regexec, print_double_string)
6067 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6068 (re_compile_pattern, re_exec): Declare arguments and local
6069 variables `size_t' and `ssize_t' and return values `regoff_t', as
6071 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6072 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6073 <compile_stack_type>: `size' and `avail' are now `size_t'.
6075 * regex.h <regoff_t>: Use ssize_t, not int.
6076 (re_search, re_search_2, re_match, re_match_2): Arguments that
6077 specify buffer/string position and length are now ssize_t and
6078 size_t. Return type is regoff_t.
6080 2011-04-16 Ben Key <bkey76@gmail.com>
6082 * nsfont.m: Fixed bugs in ns_get_family and
6083 ns_descriptor_to_entity that were caused by using free to
6084 deallocate memory blocks that were allocated by xmalloc (via
6085 xstrdup). This caused Emacs to crash when compiled with
6086 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6087 --enable-checking=xmallocoverrun). xfree is now used to
6088 deallocate these memory blocks.
6090 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6092 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6094 emacs_write: Accept and return EMACS_INT for sizes.
6095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6097 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6098 Accept and return EMACS_INT.
6099 (emacs_gnutls_write): Return the number of bytes written on
6101 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6102 (emacs_read, emacs_write): Remove check for negative size, as the
6103 Emacs source code has been audited now.
6104 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6105 (emacs_read, emacs_write): Use it.
6106 * process.c (send_process): Adjust to the new signatures of
6107 emacs_write and emacs_gnutls_write. Do not attempt to store
6108 a byte offset into an 'int'; it might overflow.
6109 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6111 * sound.c: Don't assume sizes fit in 'int'.
6112 (struct sound_device.period_size, alsa_period_size):
6113 Return EMACS_INT, not int.
6114 (struct sound_device.write, vox_write, alsa_write):
6115 Accept EMACS_INT, not int.
6116 (wav_play, au_play): Use EMACS_INT to store sizes and to
6117 record read return values.
6119 2011-04-15 Ben Key <bkey76@gmail.com>
6121 * keyboard.c (Qundefined): Don't declare static since it is used
6123 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6124 static since they are used in nsfont.m.
6126 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6128 * process.c (Qprocessp): Don't declare static.
6129 * lisp.h (Qprocessp): Declare again.
6131 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6133 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6135 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6137 Improve C-level modularity by making more things 'static'.
6139 Don't publish debugger-only interfaces to other modules.
6140 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6141 (verify_bytepos, count_markers): Move decls to the only modules
6143 * region-cache.h (pp_cache): Likewise.
6144 * window.h (check_all_windows): Likewise.
6145 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6147 * sysdep.c (croak): Now static, if
6148 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6149 * syssignal.h (croak): Declare only if not static.
6151 * alloc.c (refill_memory_reserve): Now static if
6152 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6153 * lisp.h (refill_memory_reserve): Declare only if not static.
6155 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6156 Define only if USE_LUCID.
6158 * xrdb.c (x_customization_string, x_rm_string): Now static.
6160 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6161 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6163 * xdisp.c (draw_row_with_mouse_face): Now static.
6164 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6166 * window.h (check_all_windows): Mark externally visible.
6168 * window.c (window_deletion_count): Now static.
6170 * undo.c: Make symbols static if they're not exported.
6171 (last_undo_buffer, last_boundary_position, pending_boundary):
6174 * textprop.c (interval_insert_behind_hooks): Now static.
6175 (interval_insert_in_front_hooks): Likewise.
6177 * term.c: Make symbols static if they're not exported.
6178 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6179 (max_frame_lines, tty_set_terminal_modes):
6180 (tty_reset_terminal_modes, tty_turn_off_highlight):
6181 (get_tty_terminal): Now static.
6182 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6183 * termhooks.h (term_mouse_moveto): Do not declare if
6185 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6186 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6188 * sysdep.c: Make symbols static if they're not exported.
6189 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6191 (sigprocmask_set, full_mask): Remove; unused.
6192 (wait_debugging): Mark as visible.
6193 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6194 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6196 * syntax.c (syntax_temp): Define only if !__GNUC__.
6198 * sound.c (current_sound_device, current_sound): Now static.
6200 * search.c (searchbufs, searchbuf_head): Now static.
6202 * scroll.c (scroll_cost): Remove; unused.
6203 * dispextern.h (scroll_cost): Remove decl.
6205 * region-cache.h (pp_cache): Mark as externally visible.
6207 * process.c: Make symbols static if they're not exported.
6208 (process_tick, update_tick, create_process, chan_process):
6209 (Vprocess_alist, proc_buffered_char, datagram_access):
6210 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6211 (deactivate_process): Mark defn as static, as well as decl.
6212 * lisp.h (create_process): Remove decl.
6213 * process.h (chan_process, Vprocess_alist): Remove decls.
6215 * print.c: Make symbols static if they're not exported.
6216 (print_depth, new_backquote_output, being_printed, print_buffer):
6217 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6218 (print_interval, print_number_index, initial_stderr_stream):
6220 * lisp.h (Fprinc): Remove decl.
6221 (debug_output_compilation_hack): Mark as externally visible.
6223 * sysdep.c (croak): Move decl from here to syssignal.h.
6224 * syssignal.h (croak): Put it here, so the API can be checked when
6225 'croak' is called from dissociate_if_controlling_tty.
6227 * minibuf.c: Make symbols static if they're not exported.
6228 (minibuf_save_list, choose_minibuf_frame): Now static.
6229 * lisp.h (choose_minibuf_frame): Remove decl.
6231 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6233 * lread.c: Make symbols static if they're not exported.
6234 (read_objects, initial_obarray, oblookup_last_bucket_number):
6236 (make_symbol): Remove; unused.
6237 * lisp.h (initial_obarray, make_symbol): Remove decls.
6239 * keyboard.c: Make symbols static if they're not exported.
6240 (single_kboard, recent_keys_index, total_keys, recent_keys):
6241 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6242 (this_single_command_key_start, echoing, last_auto_save):
6243 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6244 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6245 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6246 (Vlispy_mouse_stem, double_click_count):
6248 (force_auto_save_soon): Define only if SIGDANGER.
6249 (ignore_mouse_drag_p): Now static if
6250 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6251 (print_help): Remove; unused.
6252 (stop_character, last_timer_event): Mark as externally visible.
6253 * keyboard.h (ignore_mouse_drag_p): Declare only if
6254 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6255 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6256 * lisp.h (echoing): Remove decl.
6257 (force_auto_save_soon): Declare only if SIGDANGER.
6258 * xdisp.c (redisplay_window): Simplify code, to make it more
6259 obvious that ignore_mouse_drag_p is not accessed if !defined
6260 USE_GTK && !defined HAVE_NS.
6262 * intervals.c: Make symbols static if they're not exported.
6263 (merge_properties_sticky, merge_interval_right, delete_interval):
6265 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6267 * insdel.c: Make symbols static if they're not exported.
6268 However, leave prepare_to_modify_buffer alone. It's never
6269 called from outside this function, but that appears to be a bug.
6270 (combine_after_change_list, combine_after_change_buffer):
6271 (adjust_after_replace, signal_before_change): Now static.
6272 (adjust_after_replace_noundo): Remove; unused.
6273 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6274 (signal_before_change): Remove decls.
6276 * indent.c (val_compute_motion, val_vmotion): Now static.
6278 * image.c: Make symbols static if they're not exported.
6279 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6281 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6282 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6284 * fringe.c (standard_bitmaps): Now static.
6285 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6287 * frame.c: Make symbols static if they're not exported.
6288 (x_report_frame_params, make_terminal_frame): Now static.
6289 (get_frame_param): Now static, unless HAVE_NS.
6290 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6291 (x_get_resource_string): Remove; not used.
6292 * frame.h (make_terminal_frame, x_report_frame_params):
6293 (x_get_resource_string); Remove decls.
6294 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6295 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6297 * font.c, fontset.c: Make symbols static if they're not exported.
6298 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6299 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6300 * font.c (font_close_object): Now static.
6301 * font.h (font_close_object): Remove.
6302 * fontset.c (FONTSET_OBJLIST): Remove.
6303 (free_realized_fontset) #if-0 the body, which does nothing.
6304 (face_suitable_for_char_p): #if-0, as it's never called.
6305 * fontset.h (face_suitable_for_char_p): Remove decl.
6306 * xfaces.c (face_at_string_position):
6307 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6308 since 0 is always ASCII.
6310 * fns.c (weak_hash_tables): Now static.
6312 * fileio.c: Make symbols static if they're not exported.
6313 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6314 (Vwrite_region_annotation_buffers): Now static.
6316 * eval.c: Make symbols static if they're not exported.
6317 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6318 * lisp.h (backtrace_list): Remove decl.
6320 * emacs.c: Make symbols static if they're not exported.
6321 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6322 (fatal_error_code, fatal_error_signal_hook, standard_args):
6324 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6325 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6326 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6327 * lisp.h (fatal_error_signal_hook): Remove decl.
6328 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6330 * editfns.c: Move a (normally-unused) function to its only use.
6331 * editfns.c, lisp.h (get_operating_system_release): Remove.
6332 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6333 worth the hassle of breaking this out.
6335 * xterm.c: Make symbols static if they're not exported.
6336 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6337 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6338 (x_destroy_window, x_delete_display):
6340 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6341 (x_mouse_leave): Remove; unused.
6342 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6343 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6344 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6346 (x_mouse_leave): Declare only if WINDOWSNT.
6347 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6348 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6351 * ftxfont.c: Make symbols static if they're not exported.
6352 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6354 * font.h (ftxfont_driver): Likewise.
6356 * xfns.c: Make symbols static if they're not exported.
6357 (x_last_font_name, x_display_info_for_name):
6358 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6359 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6360 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6361 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6362 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6363 (last_show_tip_args): Now static.
6364 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6365 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6366 (x_screen_planes): Remove; unused.
6367 * dispextern.h (x_screen_planes): Remove decl.
6369 * dispnew.c: Make symbols static if they're not exported.
6370 * dispextern.h (redraw_garbaged_frames, scrolling):
6371 (increment_row_positions): Remove.
6372 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6373 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6375 (redraw_garbaged_frames): Remove; unused.
6377 * xfaces.c: Make symbols static if they're not exported.
6378 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6380 * xterm.h (defined_color): Remove decls.
6381 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6382 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6383 (menu_face_changed_default, defined_color, free_realized_face):
6384 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6385 (ascii_face_of_lisp_face): Remove; unused.
6387 * xdisp.c: Make symbols static if they're not exported.
6388 * dispextern.h (scratch_glyph_row, window_box_edges):
6389 (glyph_to_pixel_coords, set_cursor_from_row):
6390 (get_next_display_element, set_iterator_to_next):
6391 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6392 (show_mouse_face): Remove decls
6393 * frame.h (message_buf_print): Likewise.
6394 * lisp.h (pop_message, set_message, check_point_in_composition):
6396 * xterm.h (set_vertical_scroll_bar): Likewise.
6397 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6398 (message_buf_print, scratch_glyph_row, displayed_buffer):
6399 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6400 (get_next_display_element, show_mouse_face, window_box_edges):
6401 (frame_to_window_pixel_xy, check_point_in_composition):
6402 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6403 (glyph_to_pixel_coords): Remove; unused.
6405 * dired.c (file_name_completion): Now static.
6407 * dbusbind.c (xd_in_read_queued_messages): Now static.
6409 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6410 * data.c (circular_list_error): Remove.
6412 * commands.h (last_point_position, last_point_position_buffer):
6413 (last_point_position_window): Remove decls.
6414 * keyboard.c: Make these variables static.
6416 * coding.h (coding, code_convert_region, encode_coding_gap):
6418 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6419 (iso_code_class, detect_coding, code_convert_region): Now static.
6420 (encode_coding_gap): Remove; unused.
6422 * chartab.c (chartab_chars, chartab_bits): Now static.
6424 * charset.h (charset_iso_8859_1): Remove decl.
6425 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6428 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6429 * ccl.c (Vccl_program_table): Now static.
6430 (check_ccl_update): Remove; unused.
6432 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6433 * category.h: ... from here.
6434 * category.c (check_category_table, set_category_set): Now static.
6436 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6437 * lisp.h: Remove these decls.
6439 * buffer.c (buffer_count): Remove unused var.
6441 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6442 so that it's not optimized away.
6443 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6444 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6445 exported only to the debugger.
6447 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6448 * atimer.h (run_all_atimers): Remove; not exported.
6450 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6451 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6452 was inaccessible from Lisp.
6453 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6454 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6456 alloc.c: Import and export fewer symbols, and remove unused items.
6457 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6459 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6460 it's not optimized away by whole-program optimization.
6461 (message_enable_multibyte, free_misc): Remove.
6462 (catchlist, handlerlist, mark_backtrace):
6463 Declare only if BYTE_MARK_STACK.
6464 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6465 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6466 (message_enable_multibyte): Remove decl.
6467 (free_misc, interval_free_list, float_block, float_block_index):
6468 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6469 (cons_free_list, last_marked_index):
6471 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6472 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6473 (mark_backtrace): Define only if BYTE_MARK_STACK.
6474 * xdisp.c (message_enable_multibyte): Now static.
6476 Declare Lisp_Object Q* variables to be 'static' if not exported.
6477 This makes it easier for human readers (and static analyzers)
6478 to see whether these variables are used from other modules.
6479 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6480 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6481 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6482 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6483 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6484 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6485 * xmenu.c, xselect.c:
6486 Declare Q* vars static if they are not used in other modules.
6487 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6488 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6489 Remove decls of unexported vars.
6490 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6492 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6494 Make Emacs functions such as Fatom 'static' by default.
6495 This makes it easier for human readers (and static analyzers)
6496 to see whether these functions can be called from other modules.
6497 DEFUN now defines a static function. To make the function external
6498 so that it can be used in other C modules, use the new macro DEFUE.
6499 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6500 (Finit_image_library):
6501 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6502 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6503 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6504 Remove decls, since these functions are now static.
6505 (Funintern, Fget_internal_run_time): New decls, since these functions
6506 were already external.
6508 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6509 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6510 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6511 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6512 * keyboard.c, keymap.c, lread.c:
6513 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6514 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6515 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6516 Mark functions with DEFUE instead of DEFUN,
6517 if they are used in other modules.
6518 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6519 decls for now-static functions.
6520 * buffer.h (Fdelete_overlay): Remove decl.
6521 * callproc.c (Fgetenv_internal): Mark as internal.
6522 * composite.c (Fremove_list_of_text_properties): Remove decl.
6523 (Fcomposition_get_gstring): New forward static decl.
6524 * composite.h (Fcomposite_get_gstring): Remove decl.
6525 * dired.c (Ffile_attributes): New forward static decl.
6526 * doc.c (Fdocumntation_property): New forward static decl.
6527 * eval.c (Ffetch_bytecode): New forward static decl.
6528 (Funintern): Remove extern decl; now in .h file where it belongs.
6529 * fileio.c (Fmake_symbolic_link): New forward static decl.
6530 * image.c (Finit_image_library): New forward static decl.
6531 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6532 * intervals.h (Fprevious_property_change):
6533 (Fremove_list_of_text_properties): Remove decls.
6534 * keyboard.c (Fthis_command_keys): Remove decl.
6535 (Fcommand_execute): New forward static decl.
6536 * keymap.c (Flookup_key): New forward static decl.
6537 (Fcopy_keymap): Now static.
6538 * keymap.h (Flookup_key): Remove decl.
6539 * process.c (Fget_process): New forward static decl.
6540 (Fprocess_datagram_address): Mark as internal.
6541 * syntax.c (Fsyntax_table_p): New forward static decl.
6542 (skip_chars): Remove duplicate decl.
6543 * textprop.c (Fprevious_property_change): New forward static decl.
6544 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6546 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6547 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6549 * editfns.c (Fformat): Remove unreachable code.
6551 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6553 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6556 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6558 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6559 when at ZV. (Bug#8487)
6561 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6563 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6565 * keyboard.c (parse_tool_bar_item): Likewise.
6566 * sound.c (sound_cleanup, alsa_close): Likewise.
6567 * termcap.c (tgetent): Likewise.
6568 * xfns.c (x_default_font_parameter): Likewise.
6569 * xsettings.c (read_and_apply_settings): Likewise.
6571 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6572 (overrun_check_free): Protoize.
6574 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6576 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6577 since callers should never pass a negative size.
6578 Change the signature to match that of plain 'read' and 'write'; see
6579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6580 * lisp.h: Update prototypes of emacs_write and emacs_read.
6582 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6584 * xdisp.c (redisplay_window): Don't try to determine the character
6585 position of the scroll margin if the window start point w->startp
6586 is outside the buffer's accessible region. (Bug#8468)
6588 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6590 Fix write-region and its subroutines for buffers > 2GB.
6591 * fileio.c (a_write, e_write): Modify declaration of arguments and
6592 local variables to support buffers larger than 2GB.
6593 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6595 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6596 argument, local variables, and return value.
6598 * lisp.h: Update prototypes of emacs_write and emacs_read.
6600 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6602 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6604 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6606 Fix more problems found by GCC 4.6.0's static checks.
6608 * xdisp.c (vmessage): Use a better test for character truncation.
6610 * charset.c (load_charset_map): <, not <=, for optimization,
6611 and to avoid potential problems with integer overflow.
6612 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6613 * casetab.c (set_identity, shuffle): Likewise.
6614 * editfns.c (Fformat): Likewise.
6615 * syntax.c (skip_chars): Likewise.
6617 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6618 This also lets GCC 4.6.0 generate slightly better loop code.
6620 * callint.c (Fcall_interactively): <, not <=, for optimization.
6621 (Fcall_interactively): Count the number of arguments produced,
6622 not the number of arguments given. This is simpler and lets GCC
6623 4.6.0 generate slightly better code.
6625 * ftfont.c: Distingish more carefully between FcChar8 and char.
6626 The previous code passed unsigned char * to a functions like
6627 strlen and xstrcasecmp that expect char *, which does not
6628 conform to the C standard.
6629 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6630 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6631 char * when the C standard requires it.
6633 * keyboard.c (read_char): Remove unused var.
6635 * eval.c: Port to Windows vsnprintf (Bug#8435).
6637 (SIZE_MAX): Define if the headers do not.
6638 (verror): Do not give up if vsnprintf returns a negative count.
6639 Instead, grow the buffer. This ports to Windows vsnprintf, which
6640 does not conform to C99. Problem reported by Eli Zaretskii.
6641 Also, simplify the allocation scheme, by avoiding the need for
6642 calling realloc, and removing the ALLOCATED variable.
6644 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6646 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6647 But keep the doprint source code for now, as we might revamp it
6648 and use it again (Bug#8435).
6649 * lisp.h (doprnt): Remove.
6650 * Makefile.in (base_obj): Remove doprnt.o.
6651 * deps.mk (doprnt.o): Remove.
6653 error: Print 32- and 64-bit integers portably (Bug#8435).
6654 Without this change, on typical 64-bit hosts error ("...%d...", N)
6655 was used to print both 32- and 64-bit integers N, which relied on
6657 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6659 * lisp.h (error, verror): Mark as printf-like functions.
6660 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6661 Report overflow in size calculations when allocating printf buffer.
6662 Do not truncate output string at its first null byte.
6663 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6664 Truncate the output at a character boundary, since vsnprintf does not
6666 * charset.c (check_iso_charset_parameter): Convert internal
6667 character to string before calling 'error', since %c now has the
6669 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6670 overflow when computing char to be passed to 'error'. Do not
6671 pass Lisp_Object to 'error'; pass the integer instead.
6672 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6673 formatted with plain %d.
6675 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6677 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6679 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6681 * xterm.c (x_catch_errors): Remove duplicate declaration.
6683 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6685 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6687 2011-04-10 Jim Meyering <meyering@redhat.com>
6689 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6690 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6691 return ssize_t not "int", and use size_t as the buffer length.
6692 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6693 * gnutls.h: Update declarations.
6694 * process.c (read_process_output): Use ssize_t, to match.
6695 (send_process): Likewise.
6697 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6699 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6701 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6703 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6704 Use unsigned char, to match FcChar8 type definition.
6706 * xterm.c (handle_one_xevent):
6707 * xmenu.c (create_and_show_popup_menu):
6708 * xselect.c (x_decline_selection_request)
6709 (x_reply_selection_request): Avoid type-punned deref of X events.
6711 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6713 Fix some uses of `int' instead of EMACS_INT.
6714 * search.c (string_match_1, fast_string_match)
6715 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6716 (scan_buffer, find_next_newline_no_quit)
6717 (find_before_next_newline, search_command, Freplace_match)
6718 (Fmatch_data): Make some `int' variables be EMACS_INT.
6720 * xdisp.c (display_count_lines): 3rd argument and return value now
6721 EMACS_INT. All callers changed.
6722 (pint2hrstr): Last argument is now EMACS_INT.
6724 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6725 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6726 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6727 (decode_coding_utf_16, decode_coding_emacs_mule)
6728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6729 (decode_coding_ccl, decode_coding_charset)
6730 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6731 (decode_coding_iso_2022, decode_coding_emacs_mule)
6732 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6733 <char_offset, last_offset>: Declare EMACS_INT.
6734 (encode_coding_utf_8, encode_coding_utf_16)
6735 (encode_coding_emacs_mule, encode_invocation_designation)
6736 (encode_designation_at_bol, encode_coding_iso_2022)
6737 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6738 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6740 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6741 (encode_invocation_designation): Last argument P_NCHARS is now
6743 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6744 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6746 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6749 * ccl.c (Fccl_execute_on_string): Declare some variables
6752 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6754 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6756 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6758 * process.c (Fformat_network_address): Doc fix.
6760 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6762 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6764 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6766 * keyboard.c (read_char): Call Lisp function help-form-show,
6767 instead of using internal_with_output_to_temp_buffer.
6768 (Qhelp_form_show): New var.
6769 (syms_of_keyboard): Use DEFSYM macro.
6771 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6773 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6775 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6777 * process.c (Flist_processes): Remove to Lisp.
6778 (list_processes_1): Delete.
6780 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6782 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6784 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6786 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6788 Fix more problems found by GCC 4.6.0's static checks.
6790 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6792 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6794 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6796 * xdisp.c (vmessage): Mark as a printf-like function.
6798 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6800 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6802 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6803 printf-like functions.
6804 (tiff_load): Add casts to remove these marks before passing them
6805 to system-supplied API.
6807 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6809 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6810 This avoids several warnings with gcc -Wstrict-overflow.
6811 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6812 directly, rather than having caller test rule sign. This avoids
6813 some unnecessary tests.
6814 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6815 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6816 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6818 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6819 (xfont_open): Avoid unnecessary tests.
6821 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6823 * composite.h, composite.c (composition_gstring_put_cache):
6824 Use EMACS_INT, not int, for length.
6826 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6827 breaking out part of COMPOSITION_DECODE_RULE.
6828 (COMPOSITION_DECODE_RULE): Use it.
6829 * composite.c (get_composition_id): Remove unused local vars,
6830 by using the new macro.
6832 * textprop.c (set_text_properties_1): Change while to do-while,
6833 since the condition is always true at first.
6835 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6836 (interval_deletion_adjustment): Return unsigned value.
6839 * process.c (list_processes_1, create_pty, read_process_output):
6840 (exec_sentinel): Remove vars that were set but not used.
6841 (create_pty): Remove unnecessary "volatile"s.
6842 (Fnetwork_interface_info): Avoid possibility of int overflow.
6843 (read_process_output): Do adaptive read buffering even if carryover.
6844 (read_process_output): Simplify nbytes computation if buffered.
6846 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6848 * syntax.c (scan_words): Remove var that was set but not used.
6849 (update_syntax_table): Use unsigned instead of int.
6851 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6852 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6853 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6855 * print.c (print_error_message): Avoid int overflow.
6857 * font.c (font_list_entities): Redo for clarity,
6858 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6860 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6861 (font_score): Avoid potential overflow in diff calculation.
6863 * fns.c (substring_both): Remove var that is set but not used.
6864 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6866 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6868 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6869 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6870 can always succeed if overflow has undefined behavior.
6872 * search.c (boyer_moore, wordify): Remove vars set but not used.
6873 (wordify): Omit three unnecessary tests.
6875 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6876 All callers changed. This avoids the need for an unused var.
6878 * casefiddle.c (casify_region): Remove var that is set but not used.
6880 * dired.c (file_name_completion): Remove var that is set but not used.
6882 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6884 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6885 (Finsert_file_contents): Remove unnecessary code checking fd.
6887 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6888 Check for integer overflow on size calculations.
6890 * buffer.c (Fprevious_overlay_change): Remove var that is set
6893 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6894 Remove vars that are set but not used.
6895 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6896 (timer_check_2): Mark vars as initialized.
6898 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6900 * image.c (lookup_image): Remove var that is set but not used.
6901 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6903 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6904 that are set but not used.
6906 * xfns.c (make_invisible_cursor): Don't return garbage
6907 if XCreateBitmapFromData fails (Bug#8410).
6909 * xselect.c (x_get_local_selection, x_handle_property_notify):
6910 Remove vars that are set but not used.
6912 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6913 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6915 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6916 Remove var that is set but not used.
6917 (scroll_bar_windows_size): Now size_t, not int.
6918 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6921 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6922 (map_tty_color) [!defined MSDOS]: Likewise.
6924 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6926 * coding.c: Remove vars that are set but not used.
6927 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6928 All callers changed.
6929 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6930 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6931 (decode_coding_charset): Remove vars that are set but not used.
6933 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6934 that is set but not used.
6936 * print.c (print_object): Remove var that is set but not used.
6938 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6939 The gnulib version avoids calling malloc in the usual case,
6940 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6941 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6942 * filelock.c (current_lock_owner): Likewise.
6943 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6944 * sysdep.c: Include allocator.h, careadlinkat.h.
6945 (emacs_no_realloc_allocator): New static constant.
6946 (emacs_readlink): New function.
6947 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6948 ../lib/careadlinkat.h.
6950 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6952 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6953 first non-nil return value).
6955 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6957 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6958 if not defined (Bug#8403).
6960 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6962 * xdisp.c (display_count_lines): Remove parameter `start',
6963 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6964 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6965 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6966 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6967 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6968 and thereabouts. All callers changed.
6969 (get_per_char_metric): Remove parameter `f', unused since
6970 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6972 2011-04-02 Jim Meyering <meyering@redhat.com>
6974 do not dereference NULL upon failed strdup
6975 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6976 (ns_get_family): Likewise.
6978 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6980 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6982 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6984 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6987 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6989 Add lexical binding.
6991 * window.c (Ftemp_output_buffer_show): New fun.
6992 (Fsave_window_excursion):
6993 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6995 * lread.c (lisp_file_lexically_bound_p): New function.
6996 (Fload): Bind Qlexical_binding.
6997 (readevalloop): Remove `evalfun' arg.
6998 Bind Qinternal_interpreter_environment.
6999 (Feval_buffer): Bind Qlexical_binding.
7000 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7002 (syms_of_lread): Declare `lexical-binding'.
7004 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7006 * keyboard.c (eval_dyn): New fun.
7007 (menu_item_eval_property): Use it.
7009 * image.c (parse_image_spec): Use Ffunctionp.
7011 * fns.c (concat, mapcar1): Accept byte-code-functions.
7013 * eval.c (Fsetq): Handle lexical vars.
7014 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7015 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7016 (FletX, Flet): Obey lexical binding.
7017 (Fcommandp): Handle closures.
7018 (Feval): New `lexical' arg.
7019 (eval_sub): New function extracted from Feval. Use it almost
7020 everywhere where Feval was used. Look up vars in lexical env.
7022 (Ffunctionp): Move from subr.el.
7023 (Ffuncall): Handle closures.
7024 (apply_lambda): Remove `eval_flags'.
7025 (funcall_lambda): Handle closures and new byte-code-functions.
7026 (Fspecial_variable_p): New function.
7027 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7028 but without exporting it to Lisp.
7030 * doc.c (Fdocumentation, store_function_docstring):
7031 * data.c (Finteractive_form): Handle closures.
7033 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7036 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7038 (exec_byte_code): New function extracted from Fbyte_code to handle new
7039 calling convention for byte-code-functions. Add new byte-codes.
7041 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7043 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7045 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7047 * xdisp.c (redisplay_internal): Fix prototype.
7049 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7051 * xdisp.c (SCROLL_LIMIT): New macro.
7052 (try_scrolling): Use it when setting scroll_limit.
7053 Limit scrolling to 100 screen lines.
7054 (redisplay_window): Even when falling back on "recentering",
7055 position point in the window according to scroll-conservatively,
7056 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7058 (try_scrolling): When point is above the window, allow searching
7059 as far as scroll_max, or one screenful, to compute vertical
7060 distance from PT to the scroll margin position. This prevents
7061 try_scrolling from unnecessarily failing when
7062 scroll-conservatively is set to a value slightly larger than the
7063 window height. Clean up the case of PT below the margin at bottom
7064 of window: scroll_max can no longer be INT_MAX. When aggressive
7065 scrolling is in use, don't let point enter the opposite scroll
7066 margin as result of the scroll.
7067 (syms_of_xdisp) <scroll-conservatively>: Document the
7068 threshold of 100 lines for never-recentering scrolling.
7070 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7072 * dispextern.h (move_it_by_lines):
7073 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7074 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7075 (message_log_check_duplicate): Remove parameters `prev_bol' and
7076 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7077 (redisplay_internal): Remove parameter `preserve_echo_area',
7078 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7080 * indent.c (Fvertical_motion):
7081 * window.c (window_scroll_pixel_based, Frecenter):
7082 Don't pass `need_y_p' to `move_it_by_lines'.
7084 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7086 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7087 steal a few bits to be more compact.
7088 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7089 Remove unneeded casts.
7091 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7093 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7095 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7096 binding" message (bug#7967).
7098 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7100 Fix more problems found by GCC 4.6.0's static checks.
7102 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7103 Remove unused local var.
7105 * editfns.c (Fmessage_box): Remove unused local var.
7107 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7108 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7109 Omit unused local vars.
7110 * window.c (shrink_windows): Omit unused local var.
7111 * menu.c (digest_single_submenu): Omit unused local var.
7112 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7113 Omit unused local var.
7115 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7116 Don't assume string length fits in int.
7117 (keyremap_step, read_key_sequence): Use size_t for sizes.
7118 (read_key_sequence): Don't check last_real_key_start redundantly.
7120 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7121 instead of alloca (Bug#8344).
7123 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7124 (Fbacktrace_frame): Don't assume nframes fits in int.
7126 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7128 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7131 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7133 * cm.c (calccost): Turn while-do into do-while, for clarity.
7135 * keyboard.c (syms_of_keyboard): Use the same style as later
7136 in this function when indexing through an array. This also
7137 works around GCC bug 48267.
7139 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7141 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7143 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7144 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7146 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7147 This avoids undefined behavior on integer overflow, and is a bit
7148 more convenient anyway since it is compared to a size_t variable.
7150 Variadic C functions now count arguments with size_t, not int.
7151 This avoids an unnecessary limitation on 64-bit machines, which
7152 caused (substring ...) to crash on large vectors (Bug#8344).
7153 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7154 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7155 All variadic functions and their callers changed accordingly.
7156 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7157 * data.c (arith_driver, float_arith_driver): Likewise.
7158 * editfns.c (general_insert_function): Likewise.
7159 * eval.c (struct backtrace.nargs, interactive_p)
7160 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7161 (funcall_lambda, mark_backtrace): Likewise.
7162 * fns.c (concat): Likewise.
7163 * frame.c (x_set_frame_parameters): Likewise.
7164 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7165 0 if not found, not -1. All callers changed.
7167 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7168 (stack_copy_size): Now size_t, not int.
7169 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7171 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7173 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7174 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7175 All callers changed.
7177 * lisp.h (multibyte_char_to_unibyte):
7178 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7179 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7180 * character.h (CHAR_TO_BYTE8):
7181 * cmds.c (internal_self_insert):
7182 * editfns.c (general_insert_function):
7183 * keymap.c (push_key_description):
7184 * search.c (Freplace_match):
7185 * xdisp.c (message_dolog, set_message_1): All callers changed.
7187 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7189 * keyboard.c (safe_run_hook_funcall): New function.
7190 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7191 don't set the hook to nil, but remove the offending function instead.
7192 (Qcommand_hook_internal): Remove, unused.
7193 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7194 Vcommand_hook_internal.
7196 * eval.c (enum run_hooks_condition): Remove.
7197 (funcall_nil, funcall_not): New functions.
7198 (run_hook_with_args): Call each function through a `funcall' argument.
7199 Remove `cond' argument, now redundant.
7200 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7201 (Frun_hook_with_args_until_failure): Adjust accordingly.
7202 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7204 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7206 * dispextern.h (string_buffer_position): Remove declaration.
7208 * print.c (strout): Remove parameter `multibyte', unused since
7209 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7211 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7212 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7213 All callers changed.
7215 * w32.c (_wsa_errlist): Use braces for struct initializers.
7217 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7218 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7219 All callers changed.
7220 (string_buffer_position): Likewise. Also, make static (it's never
7221 used outside xdisp.c).
7222 (cursor_row_p): Remove parameter `w', unused since
7223 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7224 (decode_mode_spec): Remove parameter `precision', introduced during
7225 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7226 All callers changed.
7228 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7230 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7232 2011-03-27 Anders Lindgren <andlind@gmail.com>
7234 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7235 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7236 (ns_update_auto_hide_menu_bar): New functions.
7237 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7238 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7239 ns_constrain_all_frames.
7240 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7241 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7243 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7245 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7247 2011-03-27 Glenn Morris <rgm@gnu.org>
7249 * syssignal.h: Replace RETSIGTYPE with void.
7250 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7251 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7252 Replace SIGTYPE with void everywhere.
7253 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7254 * s/template.h (SIGTYPE): Remove commented out definition.
7256 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7258 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7259 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7261 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7263 * w32.c (read_unc_volume): Use parameter `henum', instead of
7264 global variable `wget_enum_handle'.
7266 * keymap.c (describe_vector): Remove parameters `indices' and
7267 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7268 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7270 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7272 * keyboard.c (timer_check): Remove parameter `do_it_now',
7273 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7274 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7275 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7277 * keyboard.c (read_char):
7278 * w32menu.c (w32_menu_display_help):
7279 * xmenu.c (show_help_event, menu_help_callback):
7280 Adjust calls to `show_help_echo'.
7282 * gtkutil.c (xg_maybe_add_timer):
7283 * keyboard.c (readable_events):
7284 * process.c (wait_reading_process_output):
7285 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7287 * insdel.c (adjust_markers_gap_motion):
7288 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7289 (gap_left, gap_right): Don't call it.
7291 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7293 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7294 incurred during fontification.
7296 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7298 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7299 (DEFVAR_PER_BUFFER): Don't pass it.
7301 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7302 (scrolling_window): Don't pass it.
7304 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7306 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7308 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7310 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7311 of variables specific to SELinux and computation of `encoded_absname'.
7313 * image.c (XPutPixel): Remove unused variable `height'.
7315 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7317 * unexw32.c (get_section_info): Remove unused variable `section'.
7319 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7320 (system_process_attributes): Remove unused variable `sess'.
7321 (sys_read): Remove unused variable `err'.
7323 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7324 (w32_wnd_proc): Remove unused variable `isdead'.
7325 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7326 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7327 (x_create_tip_frame): Remove unused variable `tem'.
7329 * w32inevt.c (w32_console_read_socket):
7330 Remove unused variable `no_events'.
7332 * w32term.c (x_draw_composite_glyph_string_foreground):
7333 Remove unused variable `width'.
7335 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7337 * w32term.c (x_set_glyph_string_clipping):
7338 Don't pass uninitialized region to CombineRgn.
7340 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7342 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7343 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7344 (Fx_close_connection): Remove unused variable `i'.
7346 * w32font.c (w32font_draw): Return number of glyphs.
7347 (w32font_open_internal): Remove unused variable `i'.
7348 (w32font_driver): Add missing initializer.
7350 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7351 (fill_in_menu): Remove unused variable `items_added'.
7353 * w32term.c (last_mouse_press_frame): Remove static global variable.
7354 (w32_clip_to_row): Remove unused variable `f'.
7355 (x_delete_terminal): Remove unused variable `i'.
7357 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7358 (NOTHING): Remove unused static global variable.
7359 (uniscribe_check_otf): Remove unused variable `table'.
7360 (uniscribe_font_driver): Add missing initializers.
7362 2011-03-23 Julien Danjou <julien@danjou.info>
7364 * term.c (Fsuspend_tty, Fresume_tty):
7365 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7366 * window.c (temp_output_buffer_show):
7367 * insdel.c (signal_before_change):
7368 * frame.c (Fhandle_switch_frame):
7369 * fileio.c (Fdo_auto_save):
7370 * emacs.c (Fkill_emacs):
7371 * editfns.c (save_excursion_restore):
7372 * cmds.c (internal_self_insert):
7373 * callint.c (Fcall_interactively):
7374 * buffer.c (Fkill_all_local_variables):
7375 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7377 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7378 unconditionnaly since it does the check itself.
7380 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7382 Fix more problems found by GCC 4.5.2's static checks.
7384 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7385 the first time through the loop, since we know p0 < p1 then.
7386 This also avoids a gcc -Wstrict-overflow warning.
7388 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7389 leading to a memory leak, possible in functions like
7390 load_charset_map_from_file that can allocate an unbounded number
7391 of objects (Bug#8318).
7393 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7394 that could (at least in theory) be that large.
7396 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7397 This is less likely to overflow, and avoids undefined behavior if
7398 overflow does occur. All callers changed. Use strtoul to scan
7399 for the unsigned long integer.
7400 (pint2hrstr): Simplify and tune code slightly.
7401 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7403 * scroll.c (do_scrolling): Work around GCC bug 48228.
7404 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7406 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7407 This also avoids a warning with gcc -Wstrict-overflow.
7408 (validate_x_resource_name): Simplify count usage.
7409 This also avoids a warning with gcc -Wstrict-overflow.
7411 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7414 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7416 * process.c (Fmake_network_process): Use socklen_t, not int,
7417 where POSIX says socklen_t is required in portable programs.
7418 This fixes a porting bug on hosts like 64-bit HP-UX, where
7419 socklen_t is wider than int (Bug#8277).
7420 (Fmake_network_process, server_accept_connection):
7421 (wait_reading_process_output, read_process_output):
7424 * process.c: Rename or move locals to avoid shadowing.
7425 (list_processes_1, Fmake_network_process):
7426 (read_process_output_error_handler, exec_sentinel_error_handler):
7427 Rename or move locals.
7428 (Fmake_network_process): Define label "retry_connect" only if needed.
7429 (Fnetwork_interface_info): Fix pointer signedness.
7430 (process_send_signal): Add cast to avoid pointer signedness problem.
7431 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7432 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7434 Make tparam.h and terminfo.c consistent.
7435 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7436 Include tparam.h instead, since it declares them.
7437 * cm.h (PC): Remove extern decl; tparam.h now does this.
7438 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7439 * terminfo.c: Include tparam.h, to check interfaces.
7440 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7441 (tparam): Adjust signature to match interface in tparam.h;
7442 this removes some undefined behavior. Check that outstring and len
7443 are zero, which they always are with Emacs.
7444 * tparam.h (PC, BC, UP): New extern decls.
7446 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7447 (xftfont_open): Rename locals to avoid shadowing.
7449 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7450 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7451 (OTF_TAG_SYM): Omit macro if not needed.
7452 (ftfont_list): Remove unused local.
7453 (get_adstyle_property, ftfont_pattern_entity):
7454 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7455 Rename locals to avoid shadowing.
7457 * xfont.c (xfont_list_family): Mark var as initialized.
7459 * xml.c (make_dom): Now static.
7461 * composite.c (composition_compute_stop_pos): Rename local to
7463 (composition_reseat_it): Remove unused locals.
7464 (find_automatic_composition, composition_adjust_point): Likewise.
7465 (composition_update_it): Mark var as initialized.
7466 (find_automatic_composition): Mark vars as initialized,
7467 with a FIXME (Bug#8290).
7469 character.h: Rename locals to avoid shadowing.
7470 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7471 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7472 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7473 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7476 * textprop.c (property_change_between_p): Remove; unused.
7478 * intervals.c (interval_start_pos): Now static.
7480 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7482 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7483 Rename locals to avoid shadowing.
7485 * sound.c (wav_play, au_play, Fplay_sound_internal):
7486 Fix pointer signedness.
7487 (alsa_choose_format): Remove unused local var.
7488 (wav_play): Initialize a variable to 0, to prevent undefined
7489 behavior (Bug#8278).
7491 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7493 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7495 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7496 clobbering (Bug#8298).
7497 * sysdep.c (sys_subshell): Likewise.
7498 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7500 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7501 This should get cleaned up, so that child_setup has the
7502 same signature on all platforms.
7504 * callproc.c (call_process_cleanup): Now static.
7505 (relocate_fd): Rename locals to avoid shadowing.
7507 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7509 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7510 not to be necessary, and produces flickering.
7512 2011-03-20 Glenn Morris <rgm@gnu.org>
7514 * config.in: Remove file.
7516 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7518 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7519 are now in src/globals.h.
7520 (syms_of_minibuf): Remove spurious & from previous change.
7522 2011-03-20 Leo <sdl.web@gmail.com>
7524 * minibuf.c (completing-read-function): New variable.
7525 (completing-read-default): Rename from completing-read.
7526 (completing-read): Call completing-read-function.
7528 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7530 * xfaces.c (Fx_load_color_file):
7531 Read color file from absolute filename (bug#8250).
7533 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7535 * makefile.w32-in: Update dependencies.
7537 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7539 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7541 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7543 Fix more problems found by GCC 4.5.2's static checks.
7545 * process.c (make_serial_process_unwind, send_process_trap):
7546 (sigchld_handler): Now static.
7548 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7549 That way, the code declares only the vars that it needs.
7550 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7551 * s/cygwin.h (PTY_ITERATION): Likewise.
7552 * s/darwin.h (PTY_ITERATION): Likewise.
7553 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7555 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7556 * process.c (allocate_pty): Don't declare stb unless it's needed.
7558 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7559 (CONSTANTLIM): Remove; unused.
7560 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7561 Define only if needed.
7563 * unexelf.c (unexec): Name an expression,
7564 to avoid gcc -Wbad-function-cast warning.
7565 Use a different way to cause a compilation error if anyone uses
7566 n rather than nn, a way that does not involve shadowing.
7567 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7569 * deps.mk (unexalpha.o): Remove; unused.
7571 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7572 * unexec.h: New file.
7573 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7574 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7576 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7577 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7578 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7579 Change as necessary to match prototype in unexec.h.
7581 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7583 (back_comment, skip_chars): Mark vars as initialized.
7585 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7586 Rename locals to avoid shadowing.
7588 * lread.c (read1): Rewrite so as not to use empty "else".
7589 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7591 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7593 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7594 warning when compiling print.c.
7596 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7597 instead of using an uninitialized var.
7598 (font_sort_entities): Mark var as initialized.
7600 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7602 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7603 pointers to constants.
7604 (font_parse_fcname): Remove unused vars.
7605 (font_delete_unmatched): Now static.
7606 (font_get_spec): Remove; unused.
7607 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7608 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7609 Rename or move locals to avoid shadowing.
7611 * fns.c (require_nesting_list, require_unwind): Now static.
7612 (Ffillarray): Rename locals to avoid shadowing.
7614 * floatfns.c (domain_error2): Define only if needed.
7615 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7617 * alloc.c (mark_backtrace): Move decl from here ...
7618 * lisp.h: ... to here, so that it can be checked.
7620 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7621 (Fdefvar): Rewrite so as not to use empty "else".
7622 (lisp_indirect_variable): Name an expression,
7623 to avoid gcc -Wbad-function-cast warning.
7624 (Fdefvar): Rename locals to avoid shadowing.
7626 * callint.c (quotify_arg, quotify_args): Now static.
7627 (Fcall_interactively): Rename locals to avoid shadowing.
7628 Use const pointer when appropriate.
7630 * lisp.h (get_system_name, get_operating_system_release):
7631 Move decls here, to check interfaces.
7632 * process.c (get_operating_system_release): Move decl to lisp.h.
7633 * xrdb.c (get_system_name): Likewise.
7634 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7635 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7636 some of which prompt warnings from gcc -Wbad-function-cast.
7637 (Fformat_time_string, Fencode_time, Finsert_char):
7638 (Ftranslate_region_internal, Fformat):
7639 Rename or remove local vars to avoid shadowing.
7640 (Ftranslate_region_internal): Mark var as initialized.
7642 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7645 * lisp.h (eassert): Check that the argument compiles, even if
7646 ENABLE_CHECKING is not defined.
7648 * data.c (Findirect_variable): Name an expression, to avoid
7649 gcc -Wbad-function-cast warning.
7650 (default_value, arithcompare, arith_driver, arith_error): Now static.
7651 (store_symval_forwarding): Rename local to avoid shadowing.
7652 (Fmake_variable_buffer_local, Fmake_local_variable):
7653 Mark variables as initialized.
7654 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7656 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7657 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7658 Rename locals to avoid shadowing.
7659 (mark_stack): Move local variables into the #ifdef region where
7661 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7662 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7664 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7665 (GC_STRING_CHARS): Remove; not used.
7666 (Fmemory_limit): Cast sbrk's returned value to char *.
7668 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7669 avoids undefined behavior in theory.
7671 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7673 Use functions, not macros, for up- and down-casing (Bug#8254).
7674 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7675 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7676 to use the following functions instead of these macros.
7677 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7678 EMACS_INT, since callers assume the returned value fits in int.
7679 (upcase1): Likewise, for UPCASE_TABLE.
7680 (uppercasep, lowercasep, upcase): New static inline functions.
7681 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7682 the race-condition problem in the old DOWNCASE.
7684 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7685 Rename locals to avoid shadowing.
7686 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7687 (regex_compile, re_search_2, re_match_2_internal):
7688 Remove unused local vars.
7689 (FREE_VAR): Rewrite so as not to use empty "else",
7690 which gcc can warn about.
7691 (regex_compile, re_match_2_internal): Mark locals as initialized.
7692 (RETALLOC_IF): Define only if needed.
7693 (WORDCHAR_P): Likewise. This one is never needed, but is used
7694 only in a comment talking about a compiler bug, so put inside
7695 the #if 0 of that comment.
7696 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7697 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7700 * search.c (boyer_moore): Rename locals to avoid shadowing.
7701 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7702 (PREV_CHAR_BOUNDARY): Likewise.
7704 * search.c (simple_search): Remove unused var.
7706 * dired.c (compile_pattern): Move decl from here ...
7707 * lisp.h: ... to here, so that it can be checked.
7708 (struct re_registers): New forward decl.
7710 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7712 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7714 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7715 Rename locals to avoid shadowing.
7716 (Fvertical_motion): Mark locals as initialized.
7718 * casefiddle.c (casify_object, casify_region): Now static.
7719 (casify_region): Mark local as initialized.
7721 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7723 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7724 New macros, so that the caller can use some names other than
7725 gcpro1, gcpro2, etc.
7726 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7728 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7729 argument, for consistency with GCPRO2_VAR, etc: it is now the
7730 prefix of the variable, not the variable itself. All uses
7732 * dired.c (directory_files_internal, file_name_completion):
7733 Rename locals to avoid shadowing.
7735 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7736 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7737 dired.c's scmp function, had undefined behavior.
7738 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7739 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7740 * buffer.h: ... to here, because these macros use current_buffer,
7741 and the new implementation with inline functions needs to have
7742 current_buffer in scope now, rather than later when the macros
7744 (downcase, upcase1): New static inline functions.
7745 (DOWNCASE, UPCASE1): Reimplement using these functions.
7746 This avoids undefined behavior in expressions like
7747 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7748 from race conditions in accessing the global variables
7749 case_temp1 and case_temp2.
7750 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7751 * lisp.h (case_temp1, case_temp2): Remove their decls.
7752 * character.h (ASCII_CHAR_P): Move from here ...
7753 * lisp.h: ... to here, so that the inline functions mentioned
7756 * dired.c (directory_files_internal_unwind): Now static.
7758 * fileio.c (file_name_as_directory, directory_file_name):
7759 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7761 (file_name_as_directory): Use const pointers when appropriate.
7762 (Fexpand_file_name): Likewise. In particular, newdir might
7763 point at constant storage, so make it a const pointer.
7764 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7765 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7767 (Fset_file_times, Finsert_file_contents, auto_save_error):
7768 Rename locals to avoid shadowing.
7770 * minibuf.c (choose_minibuf_frame_1): Now static.
7771 (Ftry_completion, Fall_completions): Rename or remove locals
7774 * marker.c (bytepos_to_charpos): Remove; unused.
7776 * lisp.h (verify_bytepos, count_markers): New decls,
7777 so that gcc does not warn that these functions aren't declared.
7779 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7780 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7781 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7782 (copy_text): Remove unused local var.
7784 * filelock.c (within_one_second): Now static.
7785 (lock_file_1): Rename local to avoid shadowing.
7787 * buffer.c (fix_overlays_before): Mark locals as initialized.
7788 (fix_start_end_in_overlays): Likewise. This function should be
7789 simplified by using pointers-to-pointers, but that's a different
7791 (switch_to_buffer_1): Now static.
7792 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7793 (report_overlay_modification): Rename locals to avoid shadowing.
7795 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7796 Fix pointer signedness issue.
7797 (sys_subshell): Mark local as volatile if checking for lint,
7798 to suppress a gcc -Wclobbered warning that does not seem to be right.
7799 (MAXPATHLEN): Define only if needed.
7801 * process.c (serial_open, serial_configure): Move decls from here ...
7802 * systty.h: ... to here, so that they can be checked.
7804 * fns.c (get_random, seed_random): Move extern decls from here ...
7805 * lisp.h: ... to here, so that they can be checked.
7807 * sysdep.c (reset_io): Now static.
7808 (wait_for_termination_signal): Remove; unused.
7810 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7811 (copy_keymap_item, append_key, push_text_char_description):
7813 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7814 (DENSE_TABLE_SIZE): Remove; unused.
7815 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7816 (describe_map_tree):
7817 Rename locals to avoid shadowing.
7819 * keyboard.c: Declare functions static if they are not used elsewhere.
7820 (echo_char, echo_dash, cmd_error, top_level_2):
7821 (poll_for_input, handle_async_input): Now static.
7822 (read_char, kbd_buffer_get_event, make_lispy_position):
7823 (make_lispy_event, make_lispy_movement, apply_modifiers):
7824 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7825 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7826 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7827 (read_key_sequence, read_char): Mark locals as initialized.
7828 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7830 * keyboard.h (make_ctrl_char): New decl.
7831 (mark_kboards): Move decl here ...
7832 * alloc.c (mark_kboards): ... from here.
7834 * lisp.h (force_auto_save_soon): New decl.
7836 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7837 (DEFINE_DUMMY_FUNCTION): New macro.
7838 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7840 (main): Add casts to avoid warnings
7841 if GCC considers string literals to be constants.
7843 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7845 * dbusbind.c: Pointer signedness fixes.
7846 (xd_signature, xd_append_arg, xd_initialize):
7847 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7848 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7849 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7850 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7852 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7853 if GCC considers string literals to be constants.
7854 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7856 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7858 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7859 (print_preprocess, print_object): New macro to fix last change.
7861 * print.c (print_preprocess): Don't forget font objects.
7863 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7865 * emacs.c (USAGE3): Doc fixes.
7867 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7869 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7872 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7874 * lisp.h (VWindow_system, Qfile_name_history):
7875 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7876 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7877 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7879 * w32select.c: Don't #include "keyboard.h".
7880 (run_protected): Add extern declaration for waiting_for_input.
7882 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7883 * w32console.c (detect_input_pending, read_input_pending)
7884 (encode_terminal_code):
7885 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7886 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7887 (w32_system_caret_y, Qfile_name_history):
7888 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7889 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7890 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7891 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7892 * w32proc.c (Qlocal, report_file_error):
7893 * w32term.c (Vwindow_system, updating_frame):
7894 * w32uniscribe.c (initialized, uniscribe_font_driver):
7895 Remove unneeded extern declarations.
7897 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7899 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7901 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7903 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7904 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7905 These macros can no longer be used for assignment.
7907 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7908 Assign struct members directly, instead of using BUF_BEGV etc.
7909 (record_buffer_markers, fetch_buffer_markers): New functions for
7910 recording and fetching special buffer markers.
7911 (set_buffer_internal_1, set_buffer_temp): Use them.
7913 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7915 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7917 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7918 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7920 * xdisp.c (hscroll_window_tree):
7921 (reconsider_clip_changes): Use PT instead of BUF_PT.
7923 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7925 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7926 $(EMACS_ROOT)/lib/intprops.h.
7928 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7930 Fix more problems found by GCC 4.5.2's static checks.
7932 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7933 to unsigned char * to avoid compiler diagnostic.
7934 (xg_free_frame_widgets): Make it clear that a local variable is
7935 needed only if USE_GTK_TOOLTIP.
7936 (gdk_window_get_screen): Make it clear that this macro is needed
7937 only if USE_GTK_TOOLTIP.
7938 (int_gtk_range_get_value): New function, which avoids a diagnostic
7939 from gcc -Wbad-function-cast.
7940 (xg_set_toolkit_scroll_bar_thumb): Use it.
7941 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7942 diagnostic from gcc -Wbad-function-cast.
7943 (get_utf8_string, xg_get_file_with_chooser):
7944 Rename locals to avoid shadowing.
7945 (create_dialog): Move locals to avoid shadowing.
7947 * xgselect.c (xg_select): Remove unused var.
7949 * image.c (four_corners_best): Mark locals as initialized.
7950 (gif_load): Initialize transparent_p to zero (Bug#8238).
7951 Mark another local as initialized.
7952 (my_png_error, my_error_exit): Mark with NO_RETURN.
7954 * image.c (clear_image_cache): Now static.
7955 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7956 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7957 (x_edge_detection): Remove unnecessary cast that
7958 gcc -Wbad-function-cast diagnoses.
7959 (gif_load): Fix pointer signedness.
7960 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7961 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7963 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7965 Improve quality of tests for time stamp overflow.
7966 For example, without this patch (encode-time 0 0 0 1 1
7967 1152921504606846976) returns the obviously-bogus value (-948597
7968 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7969 reports time overflow. See
7970 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7971 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7972 * editfns.c: Include limits.h and intprops.h.
7973 (TIME_T_MIN, TIME_T_MAX): New macros.
7974 (time_overflow): Move earlier, to before first use.
7975 (hi_time, lo_time): New functions, for an accurate test for
7977 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7978 (Fget_internal_run_time): Don't assume time_t fits in int.
7979 (make_time): Use list2 instead of Fcons twice.
7980 (Fdecode_time): More accurate test for out-of-range times.
7981 (check_tm_member): New function.
7982 (Fencode_time): Use it, to test for out-of-range times.
7983 (lisp_time_argument): Don't rely on undefined left-shift and
7984 right-shift behavior when checking for time stamp overflow.
7986 * editfns.c (time_overflow): New function, refactoring common code.
7987 (Fformat_time_string, Fdecode_time, Fencode_time):
7988 (Fcurrent_time_string): Use it.
7990 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7991 * dired.c (make_time): Move to ...
7992 * editfns.c (make_time): ... here.
7993 * systime.h: Note the move.
7995 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7997 * fringe.c (update_window_fringes): Remove unused variables.
7999 * unexmacosx.c (copy_data_segment): Also copy __got section.
8002 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8004 * termcap.c [MSDOS]: Include "msdos.h".
8005 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8006 Constify `char *' arguments and their references according to
8007 prototypes in tparam.h.
8009 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8011 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8012 Adapt all references accordingly.
8014 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8016 2011-03-11 Tom Tromey <tromey@redhat.com>
8018 * buffer.c (syms_of_buffer): Remove obsolete comment.
8020 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8022 * termhooks.h (encode_terminal_code): Declare prototype.
8024 * msdos.c (encode_terminal_code): Don't declare prototype.
8026 * term.c (encode_terminal_code): Now external again, used by
8027 w32console.c and msdos.c.
8029 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8030 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8032 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8034 Fix some minor problems found by GCC 4.5.2's static checks.
8036 * fringe.c (update_window_fringes): Mark locals as initialized
8038 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8040 * alloc.c (mark_fringe_data): Move decl from here ...
8041 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8042 to check its interface.
8043 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8045 * fontset.c (free_realized_fontset): Now static.
8046 (Fset_fontset_font): Rename local to avoid shadowing.
8047 (fontset_font): Mark local as initialized.
8048 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8050 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8052 * xselect.c (x_disown_buffer_selections): Remove; not used.
8053 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8054 (x_own_selection, Fx_disown_selection_internal): Rename locals
8056 (x_handle_dnd_message): Remove local to avoid shadowing.
8058 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8059 so that the caller can use some name other than gcpro1.
8060 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8061 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8062 (Fx_backspace_delete_keys_p):
8063 Use them to avoid shadowing, and rename vars to avoid shadowing.
8064 (x_decode_color, x_set_name, x_window): Now static.
8065 (Fx_create_frame): Add braces to silence GCC warning.
8066 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8067 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8068 Remove unused locals.
8069 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8070 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8071 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8074 * xterm.h (x_mouse_leave): New decl.
8076 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8077 Remove unused functions.
8078 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8079 (x_calc_absolute_position): Now static.
8080 (XTread_socket): Don't define label "out" unless it's used.
8081 Don't declare local "event" unless it's used.
8082 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8083 unless they are used.
8084 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8085 (x_fatal_error_signal): Remove; not used.
8086 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8087 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8088 (x_error_catcher, x_connection_closed, x_error_handler):
8089 (x_error_quitter, xembed_send_message, x_iconify_frame):
8090 (my_log_handler): Rename locals to avoid shadowing.
8091 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8092 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8094 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8095 Rename or move locals to avoid shadowing.
8096 (tty_defined_color, merge_face_heights): Now static.
8097 (free_realized_faces_for_fontset): Remove; not used.
8098 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8099 does not deduce is never used uninitialized.
8100 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8101 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8103 * terminal.c (store_terminal_param): Now static.
8105 * xmenu.c (menu_highlight_callback): Now static.
8106 (set_frame_menubar): Remove unused local.
8107 (xmenu_show): Rename parameter to avoid shadowing.
8108 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8109 since they might point to immutable storage.
8110 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8111 since it's unused otherwise.
8113 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8114 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8115 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8116 avoids a gcc -Wuninitialized diagnostic.
8117 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8118 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8119 does not deduce are never used uninitialized.
8121 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8123 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8124 * window.c (window_loop, size_window):
8125 (run_window_configuration_change_hook, enlarge_window): Likewise.
8127 * window.c (display_buffer): Now static.
8128 (size_window): Mark variables that gcc -Wuninitialized
8129 does not deduce are never used uninitialized.
8130 * window.h (check_all_windows): New decl, to forestall
8131 gcc -Wmissing-prototypes diagnostic.
8132 * dispextern.h (bidi_dump_cached_states): Likewise.
8134 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8136 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8138 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8139 and to avoid gcc -Wuninitialized warning.
8140 (load_charset_map): Mark variables that gcc -Wuninitialized
8141 does not deduce are never used uninitialized.
8142 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8144 * coding.c (coding_set_source, coding_set_destination):
8145 Use "else { /* comment */ }" rather than "else /* comment */;"
8146 for clarity, and to avoid gcc -Wempty-body warning.
8147 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8148 a block, when the outer 'i' will do.
8149 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8150 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8151 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8152 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8153 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8154 Rename locals to avoid shadowing.
8155 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8156 * coding.c (emacs_mule_char, encode_invocation_designation):
8157 Now static, since they're not used elsewhere.
8158 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8159 (decode_coding_object, encode_coding_object, detect_coding_system):
8160 (decode_coding_emacs_mule): Mark variables that gcc
8161 -Wuninitialized does not deduce are never used uninitialized.
8162 (detect_coding_iso_2022): Initialize a local variable that might
8163 be used uninitialized. Leave a FIXME because it's not clear that
8164 this initialization is needed. (Bug#8211)
8165 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8166 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8167 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8168 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8169 Remove unused macros.
8171 * category.c (hash_get_category_set): Remove unused local var.
8172 (copy_category_table): Now static, since it's not used elsewhere.
8173 * character.c (string_count_byte8): Likewise.
8175 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8176 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8178 * chartab.c (copy_sub_char_table): Now static, since it's not used
8180 (sub_char_table_ref_and_range, char_table_ref_and_range):
8181 Rename locals to avoid shadowing.
8182 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8184 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8185 (BIDI_BOB): Remove unused macro.
8187 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8188 deduce are never used uninitialized.
8189 * term.c (encode_terminal_code): Likewise.
8191 * term.c (encode_terminal_code): Now static. Remove unused local.
8193 * tparam.h: New file.
8194 * term.c, tparam.h: Include it.
8195 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8196 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8197 Move these decls to tparam.h, and make them agree with what
8198 is actually in tparam.c. The previous trick of using incompatible
8199 decls in different modules does not conform to the C standard.
8200 All callers of tparam changed to use tparam's actual API.
8201 * tparam.c (tparam1, tparam, tgoto):
8202 Use const pointers where appropriate.
8204 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8205 * cm.h (struct cm): Likewise.
8206 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8207 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8208 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8209 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8210 (turn_on_face, init_tty): Likewise.
8211 * termchar.h (struct tty_display_info): Likewise.
8213 * term.c (term_mouse_position): Rename local to avoid shadowing.
8215 * alloc.c (mark_ttys): Move decl from here ...
8216 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8218 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8220 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8222 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8224 * search.c (compile_pattern_1): Remove argument regp, unused since
8225 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8226 (compile_pattern): Don't pass it.
8228 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8230 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8231 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8233 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8235 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8237 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8238 gdk_window_get_screen, gdk_window_get_geometry,
8239 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8240 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8241 (xg_get_pixbuf_from_pixmap): New function.
8242 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8243 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8244 Call xg_get_pixbuf_from_pixmap instead of
8245 gdk_pixbuf_get_from_drawable.
8246 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8247 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8248 (xg_check_special_colors): Use GtkStyleContext and its functions
8250 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8251 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8252 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8253 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8254 Call gtk_widget_get_preferred_size.
8255 (xg_frame_resized): gdk_window_get_geometry only takes 5
8257 (xg_win_to_widget, xg_event_is_for_menubar):
8258 Call gdk_x11_window_lookup_for_display.
8259 (xg_set_widget_bg): New function.
8260 (delete_cb): New function.
8261 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8262 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8263 (xg_set_background_color): Call xg_set_widget_bg.
8264 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8265 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8266 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8267 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8269 (update_frame_tool_bar): Call gtk_widget_hide.
8270 (xg_initialize): Use GDK_KEY_g.
8272 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8274 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8276 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8277 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8278 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8280 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8282 * w32xfns.c (select_palette): Check success of RealizePalette against
8283 GDI_ERROR, not zero.
8285 See ChangeLog.11 for earlier changes.
8291 Copyright (C) 2011 Free Software Foundation, Inc.
8293 This file is part of GNU Emacs.
8295 GNU Emacs is free software: you can redistribute it and/or modify
8296 it under the terms of the GNU General Public License as published by
8297 the Free Software Foundation, either version 3 of the License, or
8298 (at your option) any later version.
8300 GNU Emacs is distributed in the hope that it will be useful,
8301 but WITHOUT ANY WARRANTY; without even the implied warranty of
8302 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8303 GNU General Public License for more details.
8305 You should have received a copy of the GNU General Public License
8306 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.