1 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3 * keymap.c (Fsingle_key_description): Use make_specified_string
4 instead of build_string to build string from push_key_description.
7 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10 This fixes a Y2038 bug on 64-bit hosts.
11 * buffer.c (reset_buffer):
12 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
13 (Fclear_buffer_auto_save_failure):
14 Use 0, not -1, to represent an unset failure time, since time_t
17 Remove dependency on glibc malloc internals.
18 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
19 Move back here from lisp.h, but with their new implementations.
20 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
21 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
22 * charset.c (charset_table_init): New static var.
23 (syms_of_charset): Use it instead of xmalloc. This removes a
24 dependency on glibc malloc internals. See Eli Zaretskii's comment in
25 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
26 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
28 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
29 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
31 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
33 * nsterm.m (windowDidResize): Call x_set_window_size only when
34 ns_in_resize is true. Otherwise set pixelwidth/height and
35 call change_frame_size (Bug#9628).
37 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
39 Port --enable-checking=all to Fedora 14 x86-64.
40 * charset.c (syms_of_charset): Also account for glibc malloc's
41 internal overhead when calculating the initial malloc maximum.
43 Port --enable-checking=all to Fedora 14 x86.
44 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
46 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
47 (overrun_check_realloc, overrun_check_free):
48 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
49 That way, xmalloc returns a properly-aligned pointer even if
50 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
51 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
52 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
53 into account when calculating the initial malloc maximum.
54 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
55 Move here from alloc.c, so that charset.c can use it too.
56 Properly align; the old code wasn't right for common 32-bit hosts
57 when configured with --enable-checking=all.
58 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
59 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
61 2011-09-29 Eli Zaretskii <eliz@gnu.org>
63 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
66 2011-09-28 Eli Zaretskii <eliz@gnu.org>
68 * xdisp.c (compute_display_string_end): If there's no display
69 string at CHARPOS, return -1.
71 * bidi.c (bidi_fetch_char): When compute_display_string_end
72 returns a negative value, treat the character as a normal
73 character not covered by a display string. (Bug#9624)
75 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
77 * lread.c (Fread_from_string): Fix typo in docstring.
79 2011-09-27 Eli Zaretskii <eliz@gnu.org>
81 * xdisp.c (handle_invisible_prop): If invisible text ends on a
82 newline, reseat the iterator instead of bidi-iterating there one
83 character at a time. (Bug#9610)
84 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
85 past TO_CHARPOS if the bidi iterator is at base embedding level.
87 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
89 * lread.c (readevalloop): Use correct code for NBSP.
90 (read1): Likewise. (Bug#9608)
92 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
94 * dbusbind.c (Fdbus_register_signal): When service is not
95 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
97 2011-09-25 Glenn Morris <rgm@gnu.org>
99 * buffer.c (truncate-lines): Doc fix.
101 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
103 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
104 (Fset_window_next_buffers): Doc fix.
106 2011-09-24 Glenn Morris <rgm@gnu.org>
108 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
110 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
112 Fix minor problems found by static checking.
113 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
114 * indent.c (Fvertical_motion): Fix == vs = typo.
116 2011-09-24 Eli Zaretskii <eliz@gnu.org>
118 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
119 value is now t. Doc fix.
121 * indent.c (Fvertical_motion): Compute and apply the overshoot
122 logic also when moving up, not only when moving down. Fix the
123 confusing name and values of the it_overshoot_expected variable;
124 logic changed accordingly. (Bug#9254) (Bug#9549)
126 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
127 CHARPOS is covered by a display string which includes newlines.
128 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
129 is covered by a display string with embedded newlines.
131 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
133 * dbusbind.c (Fdbus_register_signal): Add match rule to
134 Vdbus_registered_objects_table. (Bug#9581)
135 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
138 2011-09-24 Jim Meyering <meyering@redhat.com>
140 Do not ignore write error for any output size.
141 The previous change was incomplete.
142 While it makes emacs --batch detect the vast majority of stdout
143 write failures, errors were still ignored whenever the output size is
144 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
145 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
146 && echo FAIL: ignored write error
147 FAIL: ignored write error
148 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
149 && echo FAIL: ignored write error
150 FAIL: ignored write error
151 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
153 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
155 * emacs.c (Fkill_emacs): In noninteractive mode exit
156 non-successfully if a write error occurred on stdout. (Bug#9574)
158 2011-09-21 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
163 * dispextern.h (struct it): Update the comment documenting what
166 2011-09-20 Eli Zaretskii <eliz@gnu.org>
168 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
169 a display string, extend search for cursor position to end of row.
170 (find_row_edges): If the row ends in a newline from a display
171 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
172 Handle the case of a display string with multiple newlines.
173 (Fcurrent_bidi_paragraph_direction): Fix search for previous
174 non-empty line. Fixes confusing cursor motion with arrow keys at
175 the beginning of a line that starts with whitespace.
177 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
179 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
182 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
184 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
187 2011-09-18 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (display_line): Record maximum and minimum buffer
190 positions even if no glyphs were produced (e.g., by a zero-width
191 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
192 buffer positions that will be removed from the glyph row because
194 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
195 column is beyond frame width: don't subtract 1 "pixel" when
196 computing width of the stretch.
197 (reseat_at_next_visible_line_start): Undo the change made on
198 2011-09-17 that saved paragraph information and restored it after
199 the call to `reseat'. (Bug#9545)
201 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
203 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
204 and turn window cursor on if cleared (Bug#9415).
206 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
208 * search.c (boyer_moore): Take unibyte characters from pattern
209 literally. (Bug#9458)
211 2011-09-18 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
215 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
217 Fix minor problem found by static checking.
218 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
219 initialized, to pacify gcc -Wuninitialized.
221 * fileio.c: Report proper errno when syscall falls.
222 (Finsert_file_contents): Save and restore errno,
223 so that report_file_error outputs the correct diagnostic.
224 (Fwrite_region) [CLASH_DETECTION]: Likewise.
226 2011-09-18 Eli Zaretskii <eliz@gnu.org>
228 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
230 2011-09-17 Eli Zaretskii <eliz@gnu.org>
232 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
233 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
235 2011-09-17 Eli Zaretskii <eliz@gnu.org>
237 * xdisp.c (reseat_at_next_visible_line_start): Keep information
238 about the current paragraph and restore it after the call to
241 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
242 (bidi_find_paragraph_start): Search back for paragraph beginning
243 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
244 (bidi_move_to_visually_next): Only trigger paragraph-related
245 computations when the last character is a newline or at EOB, not
246 just any NEUTRAL_B. (Bug#9470)
248 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
249 truncated lines if point is covered by a display string. (Bug#9524)
251 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
253 * xselect.c: Relax test for outgoing X longs (Bug#9498).
254 (cons_to_x_long): New function.
255 (lisp_data_to_selection_data): Use it. Correct the test for
256 short-versus-long data; it was negated. Break out of vector
257 loop, for efficiency, when a long datum is discovered.
259 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
261 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
263 2011-09-16 Eli Zaretskii <eliz@gnu.org>
265 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
266 GCC PR/17406) by declaring this function with external scope.
268 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
270 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
271 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
273 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
275 * editfns.c (Fformat): Correctly handle text properties on "%%".
277 2011-09-15 Eli Zaretskii <eliz@gnu.org>
279 * xterm.c (x_draw_composite_glyph_string_foreground):
280 * w32term.c (x_draw_composite_glyph_string_foreground):
281 * term.c (encode_terminal_code):
282 * composite.c (composition_update_it, get_composition_id):
283 * xdisp.c (get_next_display_element)
284 (fill_composite_glyph_string): Add comments about special meaning
285 of TAB characters in a composition.
287 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
289 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
290 This occurs when processing a multibyte format.
291 Problem reported by Wolfgang Jenker.
293 2011-09-15 Johan Bockgård <bojohan@gnu.org>
295 * xdisp.c (try_cursor_movement): Only check for exact match if
296 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
298 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
300 Remove unused external symbols.
301 * dispextern.h (calc_pixel_width_or_height): Remove decl.
302 * xdisp.c (calc_pixel_width_or_height): Now static.
303 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
304 * indent.c (check_display_width):
305 * w32term.c: Fix comment to match code.
306 * xterm.c, xterm.h (x_catching_errors): Remove.
308 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
310 * xselect.c: Use signed conversions more consistently (Bug#9498).
311 (selection_data_to_lisp_data): Assume incoming selection data are
312 signed integers, not unsigned. This is to be consistent with
313 outgoing selection data, which was modified to use signed integers
314 in as part of the fix to Bug#9196 in response to Jan D.'s comment
315 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
316 expects long, not unsigned long.
318 2011-09-14 Eli Zaretskii <eliz@gnu.org>
320 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
321 computation of loop end. Reported by Johan Bockgård
324 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
326 * frame.c (Fother_visible_frames_p): Function deleted.
328 2011-09-12 Eli Zaretskii <eliz@gnu.org>
330 * indent.c (compute_motion): Process display vector front to back
331 rather than the other way around. (Bug#2496)
333 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
335 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
337 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
339 * minibuf.c (Fread_from_minibuffer): Doc fix.
341 2011-09-11 Eli Zaretskii <eliz@gnu.org>
343 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
344 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
346 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
348 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
349 value for non-existent files.
351 2011-09-11 Eli Zaretskii <eliz@gnu.org>
353 * fileio.c (Finsert_file_contents): If the file cannot be opened,
354 set its "size" to -1. This will set the modtime_size field of
355 the corresponding buffer to -1, which is what
356 verify-visited-file-modtime expects for files that do not exist.
359 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
361 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
363 * lisp.h: ... from here. push_key_description is no longer
364 defined in keyboard.c, so its declaration should not be in
365 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
366 logically belongs with push_key_description.
368 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
370 * buffer.h: Include <sys/types.h> instead of <time.h>.
371 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
372 Problem reported by Herbert J. Skuhra.
374 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
376 * xml.c (parse_region): Make the parsing work for
377 non-comment-starting XML files again (bug#9144).
379 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
381 * image.c (gif_load): Fix calculation of bottom and right corner.
384 2011-09-10 Eli Zaretskii <eliz@gnu.org>
386 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
387 redisplay in small windows.
389 2011-09-09 Eli Zaretskii <eliz@gnu.org>
391 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
393 2011-09-08 Martin Rudalics <rudalics@gmx.at>
395 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
396 Operate on live windows only.
398 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
400 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
402 2011-09-07 Eli Zaretskii <eliz@gnu.org>
404 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
405 only under bidi iteration.
407 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
409 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
411 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
413 isnan: Fix porting problem to Solaris 10 with bundled gcc.
414 Without this fix, the command to link temacs failed due to an
415 undefined symbol __builtin_isnan. This is because
416 /usr/include/iso/math_c99.h #defines isnan(x) to
417 __builtin_isnan(x), but the bundled gcc, which identifies itself
418 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
420 * floatfns.c (isnan): #undef, and then #define to a clone of
422 (Fisnan): Always define, since it's always available now.
423 (syms_of_floatfns): Always define isnan at the Lisp level.
425 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
427 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
429 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
431 * fileio.c: Fix bugs with large file offsets (Bug#9428).
432 The previous code assumed that file offsets (off_t values) fit in
433 EMACS_INT variables, which is not true on typical 32-bit hosts.
434 The code messed up by falsely reporting buffer overflow in cases
435 such as (insert-file-contents "big" nil 1 2) into an empty buffer
436 when "big" contains more than 2**29 bytes, even though this
437 inserts just one byte and does not overflow the buffer.
438 (Finsert_file_contents): Store file offsets as off_t
439 values, not as EMACS_INT values. Check for overflow when
440 converting between EMACS_INT and off_t. When checking for
441 buffer overflow or for overlap, take the offsets into account.
442 Don't use EMACS_INT for small values where int suffices.
443 When checking for overlap, fix a typo: ZV was used where
444 ZV_BYTE was intended.
445 (Fwrite_region): Don't assume off_t fits into 'long'.
446 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
448 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
450 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
452 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
454 sprintf-related integer and memory overflow issues (Bug#9412).
456 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
457 (esprintf, exprintf, evxprintf): New functions.
458 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
459 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
460 (modify_event_symbol): Do not assume that the length of
461 name_alist_or_stem is safe to alloca and fits in int.
462 (Fexecute_extended_command): Likewise for function name and binding.
463 (Frecursion_depth): Wrap around reliably on integer overflow.
464 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
465 since some callers pass EMACS_INT values.
466 (Fsingle_key_description): Don't crash if symbol name contains more
467 than MAX_ALLOCA bytes.
468 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
469 (get_minibuffer): Arg is now EMACS_INT, not int.
470 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
471 (esprintf, exprintf, evxprintf): New decls.
472 * window.h (command_loop_level, minibuf_level): Reflect API changes.
474 * dbusbind.c (signature_cat): New function.
475 (xd_signature, Fdbus_register_signal):
476 Do not overrun buffer; instead, report string overflow.
478 * dispnew.c (add_window_display_history): Don't overrun buffer.
479 Truncate instead; this is OK since it's just a log.
481 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
482 even if the time zone offset is outlandishly large.
483 Don't mishandle offset == INT_MIN.
485 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
486 when creating daemon; the previous buffer-overflow check was incorrect.
488 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
489 which has the guts of the old verror function.
491 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
492 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
494 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
495 (font_unparse_xlfd): Don't blindly alloca long strings.
496 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
497 fits in int, when using sprintf. Use single snprintf to count
498 length of string rather than counting it via multiple sprintfs;
499 that's simpler and more reliable.
500 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
501 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
502 sprintf, in case result does not fit in int.
504 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
505 (fontset_from_font): Print it.
507 * frame.c (tty_frame_count): Now printmax_t, not int.
508 (make_terminal_frame, set_term_frame_name): Print it.
509 (x_report_frame_params): In X, window IDs are unsigned long,
510 not signed long, so print them as unsigned.
511 (validate_x_resource_name): Check for implausibly long names,
512 and don't assume name length fits in 'int'.
513 (x_get_resource_string): Don't blindly alloca invocation name;
514 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
517 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
518 (xg_check_special_colors, xg_set_geometry):
519 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
521 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
522 Use esprintf, not sprintf, in case result does not fit in int.
524 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
525 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
526 it as a large positive number.
527 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
528 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
530 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
531 in case result does not fit in int.
533 * print.c (float_to_string): Detect width overflow more reliably.
534 (print_object): Make sprintf buffer a bit bigger, to avoid potential
535 buffer overrun. Don't assume list length fits in 'int'. Treat
536 print length of 0 as 0, not as infinity; to be consistent with other
537 uses of print length in this function. Don't overflow print length
538 index. Don't assume hash table size fits in 'long', or that
539 vectorlike size fits in 'unsigned long'.
541 * process.c (make_process): Use printmax_t, not int, to format
542 process-name gensyms.
544 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
546 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
547 to avoid potential buffer overrun.
549 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
550 if X resource line is longer than 512 bytes.
552 * xfns.c (x_window): Make sprintf buffer a bit bigger
553 to avoid potential buffer overrun.
555 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
557 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
559 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
561 Integer overflow fixes for scrolling, etc.
562 Without these, Emacs silently mishandles large integers sometimes.
563 For example, "C-u 4294967297 M-x recenter" was treated as if
564 it were "C-u 1 M-x recenter" on a typical 64-bit host.
566 * xdisp.c (try_window_id): Check Emacs fixnum range before
569 * window.c (window_scroll_line_based, Frecenter):
570 Check that an Emacs fixnum is in range before assigning it to 'int'.
571 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
572 values converted from Emacs fixnums.
573 (Frecenter): Don't wrap around a line count if it is out of 'int'
574 range; instead, treat it as an extreme value.
575 (Fset_window_configuration, compare_window_configurations):
576 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
578 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
579 that can exceed INT_MAX. Check that EMACS_INT value is in range
580 before assigning it to the (possibly-narrower) index.
581 (match_limit): Don't assume that a fixnum can fit in 'int'.
583 * print.c (print_object): Use ptrdiff_t, not int, for index that can
586 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
587 (Fvertical_motion): Don't wrap around LINES values that don't fit
588 in 'int'. Instead, treat them as extreme values. This is good
589 enough for windows, which can't have more than INT_MAX lines anyway.
591 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
593 * Require libxml/parser.h to avoid compilation warning.
595 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
597 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
598 since this reportedly can destroy thread storage.
600 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
602 * syntax.c (find_defun_start): Update all cache variables if
603 exiting early (Bug#9401).
605 2011-08-30 Eli Zaretskii <eliz@gnu.org>
607 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
609 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
610 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
611 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
613 * term.c (tty_append_glyph): New function.
614 (produce_stretch_glyph): Static function and its prototype deleted.
616 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
619 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
621 * image.c (parse_image_spec): Check for nonnegative, not for positive,
622 when checking :margin (Bug#9390).
623 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
624 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
625 so that the name doesn't mislead. All uses changed.
627 2011-08-28 Johan Bockgård <bojohan@gnu.org>
629 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
632 2011-08-27 Eli Zaretskii <eliz@gnu.org>
634 * xdisp.c (move_it_to): Don't bail out early when reaching
635 position beyond to_charpos, if we are scanning backwards.
636 (move_it_vertically_backward): When DY == 0, make sure we get to
637 the first character in the line after the newline.
639 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
641 * ccl.c: Improve and simplify overflow checking (Bug#9196).
642 (ccl_driver): Do not generate an out-of-range pointer.
643 (Fccl_execute_on_string): Remove unnecessary check for
644 integer overflow, noted by Stefan Monnier in
645 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
646 Remove a FIXME that didn't need fixing.
647 Simplify the newly-introduced buffer reallocation code.
649 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
651 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
653 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
655 Integer and memory overflow issues (Bug#9196).
657 * doc.c (get_doc_string): Rework so that
658 get_doc_string_buffer_size is the actual buffer size, rather than
659 being 1 less than the actual buffer size; this makes xpalloc more
662 * image.c (x_allocate_bitmap_record, cache_image):
663 * xselect.c (Fx_register_dnd_atom):
664 Simplify previous changes by using xpalloc.
666 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
667 since either will do and ptrdiff_t is convenient with xpalloc.
669 * charset.c (charset_table_size)
670 (struct charset_sort_data.priority): Now ptrdiff_t.
671 (charset_compare): Don't overflow if priorities differ greatly.
672 (Fsort_charsets): Don't assume list length fits in int.
673 Check for size-calculation overflow when allocating sort data.
674 (syms_of_charset): Allocate an initial charset table that is
675 just under 64 KiB, to avoid problems with glibc malloc and mmap.
677 * cmds.c (internal_self_insert): Check for size-calculation overflow.
679 * composite.h (struct composition.glyph_len): Now int, not unsigned.
680 The actual value is always <= INT_MAX, and leaving it unsigned made
681 overflow checking harder.
683 * dispextern.h (struct glyph_matrix.rows_allocated)
684 (struct face_cache.size): Now ptrdiff_t, for convenience in use
685 with xpalloc. The values are still always <= INT_MAX.
687 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
689 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
690 (SAFE_NALLOCA): New macro.
692 * region-cache.c (struct boundary.pos, find_cache_boundary)
693 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
694 (set_cache_region, invalidate_region_cache)
695 (revalidate_region_cache, know_region_cache, region_cache_forward)
696 (region_cache_backward, pp_cache):
697 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
698 so that ptrdiff_t * can be passed to xpalloc.
699 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
700 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
701 (pp_cache): Don't assume cache_len fits in int.
702 * region-cache.h: Adjust extern decls to match.
704 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
705 EMACS_INT, since either will do, for xpalloc.
707 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
708 (xnmalloc, xnrealloc, xpalloc): New functions.
710 * bidi.c (bidi_shelve_header_size): New constant.
711 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
712 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
714 * bidi.c (bidi_cache_shrink):
715 * buffer.c (overlays_at, overlays_in, record_overlay_string)
717 Don't update size of array until after memory allocation succeeds,
718 because xmalloc/xrealloc may not return.
719 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
720 now that we have proper integer overflow checking.
721 (record_overlay_string, overlay_strings): Catch overflows when
722 calculating size of overlay_str_buf.
724 * callproc.c (Fcall_process): Check for size overflow when
725 calculating size of args2.
726 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
727 Normally we prefer signed values, but sticking with ptrdiff_t would
728 require adding more-complicated checks.
730 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
731 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
732 Redo buffer-overflow calculations to avoid integer overflow.
733 Add a FIXME comment where memory seems to be over-allocated.
735 * character.c (Fstring): Check for size-calculation overflow.
737 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
738 unnecessary integer overflow. Check for size overflow.
739 (encode_coding_object): Don't update size until xmalloc succeeds.
741 * composite.c (get_composition_id): Check for overflow in glyph
744 Integer and memory overflow fixes for display code.
745 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
746 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
747 (scrolling_window): Check for overflow in size calculations.
748 (line_draw_cost, realloc_glyph_pool, add_row_entry):
749 Don't assume glyph table len fits in int.
750 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
751 (row_table_size): Now ptrdiff_t, not int.
752 (scrolling_window): Avoid overflow in size calculations.
753 Don't update size until allocation succeeds.
754 * fns.c (concat): Check for overflow in size calculations.
755 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
756 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
757 (NEXT_ALMOST_PRIME_LIMIT): New constant.
759 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
760 (get_doc_string): Check for size calculation overflow.
761 Don't update size until allocation succeeds.
762 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
763 EMACS_INT, where ptrdiff_t will do.
764 (Fsubstitute_command_keys): Check for string overflow.
766 * editfns.c (set_time_zone_rule): Don't assume environment length
768 (message_length): Now ptrdiff_t, not int.
769 (Fmessage_box): Don't update size until allocation succeeds.
770 Don't assume message length fits in int.
771 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
773 * emacs.c (main): Do not reallocate argv, since there is a null at
774 the end that can be overwritten, and this way there's no need to
775 worry about size-calculation overflow.
776 (sort_args): Check for size-calculation overflow.
778 * eval.c (init_eval_once, grow_specpdl): Don't update size until
780 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
782 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
783 (x_set_scroll_bar_width, x_figure_window_size):
784 Check for integer overflow.
785 (x_set_alpha): Do not assume XINT fits in int.
787 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
788 This is for the members text_lines, text_cols, total_lines, total_cols,
789 where the system imposes an 'int' limit.
791 * fringe.c (Fdefine_fringe_bitmap):
792 Don't update size until alloc works.
794 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
795 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
797 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
798 Check for size-calculation overflow.
799 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
800 do, as we prefer signed integers.
801 (id_to_widget.max_size, id_to_widget.used)
802 (xg_store_widget_in_map, xg_remove_widget_from_map)
803 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
804 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
805 Use and return ptrdiff_t, not int.
806 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
807 * gtkutil.h: Change prototypes to match the above.
809 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
810 are duplicate now that they've been promoted to lisp.h.
811 (x_allocate_bitmap_record, x_alloc_image_color)
812 (make_image_cache, cache_image, xpm_load):
813 Don't update size until alloc is done.
814 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
816 Check for size calculation overflow.
817 (ct_colors_allocated_max): New constant.
818 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
821 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
822 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
823 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
824 Use ptrdiff_t, not int, to count maps.
825 (read_char_minibuf_menu_prompt): Check for overflow in size
826 calculations. Don't update size until allocation succeeds. Redo
827 calculations to avoid overflow.
828 * keyboard.h: Change prototypes to match the above.
830 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
832 (current_minor_maps): Check for size calculation overflow.
833 * keymap.h: Change prototypes to match the above.
835 * lread.c (read1, init_obarray): Don't update size until alloc done.
837 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
838 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
840 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
841 Now ptrdiff_t, not int.
842 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
843 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
845 * process.c (Fnetwork_interface_list): Check for overflow
848 * region-cache.c (move_cache_gap): Check for size calculation overflow.
850 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
851 overflow. Don't bother calling xmalloc when xrealloc will do.
853 * search.c (Freplace_match): Check for size calculation overflow.
854 (Fset_match_data): Don't assume list lengths fit in 'int'.
856 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
857 for command line length. Do not attempt to address one before the
858 beginning of an array, as that's not portable.
860 * term.c (max_frame_lines): Remove; unused.
861 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
863 (encode_terminal_code, calculate_costs): Check for size
864 calculation overflow.
865 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
866 table lengths and related sizes. Don't update size until alloc
867 done. Redo calculations to avoid overflow.
868 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
870 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
871 subtracting pointers.
872 (gobble_line): Check for overflow more carefully. Don't update size
875 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
876 Don't update size until alloc done.
877 Redo size calculations to avoid overflow.
878 Check for size calculation overflow.
879 (main) [DEBUG]: Fix typo in invoking tparam1.
881 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
882 Use ptrdiff_t, not int, for sizes.
883 (store_mode_line_noprop_char): Don't update size until alloc done.
885 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
886 Use ptrdiff_t, not int, for sizes.
887 (Finternal_make_lisp_face, cache_face):
888 Check for size calculation overflow.
889 (cache_face): Treat size calculation overflows as if they were
890 memory exhaustion (the usual treatment), rather than aborting.
892 * xfns.c (x_encode_text, x_set_name_internal)
893 (Fx_change_window_property): Use ptrdiff_t, not int, to count
894 sizes, since they can exceed INT_MAX in size. Check for size
895 calculation overflow.
897 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
898 (xg_select): Check for size calculation overflow.
899 Don't update size until alloc done.
901 * xrdb.c (get_environ_db): Don't assume path length fits in int,
902 as sprintf is limited to int lengths.
904 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
905 (X_LONG_MIN): New macros.
906 Use them to make the following changes clearer.
907 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
908 This change doesn't affect the value now, but it may help remind
909 future maintainers not to raise the value too much later.
910 (SELECTION_QUANTUM): Remove, replacing with ...
911 (selection_quantum): ... new function, which avoids overflow.
913 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
914 assumption that selection length fits in 'int'.
915 (x_reply_selection_request, x_handle_selection_request)
916 (x_get_window_property, receive_incremental_selection)
917 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
918 (lisp_data_to_selection_data, clean_local_selection_data):
919 Use ptrdiff_t, not int, to record length of selection.
920 (x_reply_selection_request, x_get_window_property)
921 (receive_incremental_selection, x_property_data_to_lisp):
922 Redo calculations to avoid overflow.
923 (x_reply_selection_request): When sending hint, ceiling it at
924 X_LONG_MAX rather than relying on wraparound overflow to send
926 (x_get_window_property, receive_incremental_selection)
927 (lisp_data_to_selection_data, x_property_data_to_lisp):
928 Check for size-calculation overflow.
929 (x_get_window_property, receive_incremental_selection)
930 (lisp_data_to_selection_data, Fx_register_dnd_atom):
931 Don't store size until memory allocation succeeds.
932 (x_get_window_property): Plug memory leak on memory exhaustion.
933 Don't double-block input; malloc is safe here. Don't assume 2**34
934 - 4 fits in unsigned long. Add an xassert to check
935 XGetWindowProperty overflow. Be more careful about overflow
936 calculations, and distinguish size from memory overflow better.
937 (receive_incremental_selection): When tracing, don't assume
938 unsigned int is less than INT_MAX.
939 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
940 harmful) conversions of unsigned short to int.
941 (lisp_data_to_selection_data): Don't assume that integers
942 in the range -65535 through -1 fit in an X unsigned short.
943 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
944 result parameters unless successful. Rely on cons_to_unsigned
945 to report problems with elements; the old code wasn't right anyway.
946 (x_check_property_data): Check for int overflow; we cannot use
947 a wider type due to X limits.
948 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
950 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
952 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
953 (x_term_init): Check for size calculation overflow.
954 (x_color_cells): Don't store size until memory allocation succeeds.
955 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
956 Don't assume alloca size is less than MAX_ALLOCA.
957 (x_term_init): Don't assume length fits in int (sprintf is limited
960 Use ptrdiff_t for composition IDs.
961 * character.c (lisp_string_width):
962 * composite.c (composition_table_size, n_compositions)
963 (get_composition_id, composition_gstring_from_id):
964 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
965 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
966 * window.c (Frecenter):
967 Use ptrdiff_t, not int, for composition IDs.
968 * composite.c (get_composition_id): Check for integer overflow.
969 * composite.h: Adjust prototypes to match the above changes.
971 Use ptrdiff_t for hash table indexes.
972 * category.c (hash_get_category_set):
973 * ccl.c (ccl_driver):
974 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
975 * coding.c (coding_system_charset_list, detect_coding_system):
976 * coding.h (struct coding_system.id):
977 * composite.c (get_composition_id, gstring_lookup_cache):
978 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
979 * image.c (xpm_get_color_table_h):
980 * lisp.h (hash_lookup, hash_put):
981 * minibuf.c (Ftest_completion):
982 Use ptrdiff_t for hash table indexes, not int (which is too
983 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
984 32-bit --with-wide-int hosts).
986 * charset.c (Fdefine_charset_internal): Check for integer overflow.
987 Add a FIXME comment about memory leaks.
988 (syms_of_charset): Don't assume xmalloc returns.
990 Don't assume that stated character widths fit in int.
991 * character.c (Fchar_width, c_string_width, lisp_string_width):
992 * character.h (CHAR_WIDTH):
993 * indent.c (MULTIBYTE_BYTES_WIDTH):
994 Use sanitize_char_width to avoid undefined and/or bad behavior
995 with outlandish widths.
996 * character.h (sanitize_tab_width): Renamed from sanitize_width,
997 now that we have two such functions. All uses changed.
998 (sanitize_char_width): New inline function.
1000 Don't assume that tab-width fits in int.
1001 * character.h (sanitize_width): New inline function.
1002 (SANE_TAB_WIDTH): New macro.
1003 (ASCII_CHAR_WIDTH): Use it.
1004 * indent.c (sane_tab_width): Remove. All uses replaced by
1005 SANE_TAB_WIDTH (current_buffer).
1006 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1008 * fileio.c: Integer overflow issues with file modes.
1009 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1011 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1012 Remove unreachable code.
1013 (read_hex, load_charset_map_from_file): Check for integer overflow.
1015 * xterm.c: don't go over XClientMessageEvent limit
1016 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1017 (x_send_scroll_bar_event): Likewise. Check that the size does not
1018 exceed limits imposed by XClientMessageEvent, as well as the usual
1019 ptrdiff_t and size_t limits.
1021 * keyboard.c: Overflow, signedness and related fixes.
1022 (make_lispy_movement): Use same integer type in forward decl
1023 that is used in the definition.
1024 (read_key_sequence, keyremap_step):
1025 Change bufsize argument back to int, undoing my 2011-03-30 change.
1026 We prefer signed types, and int is wide enough here.
1027 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1028 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1029 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1030 length, not size_t. Use ptrdiff_t for index, not int.
1031 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1032 possibility of integer overflow.
1034 Overflow, signedness and related fixes for images.
1036 * dispextern.h (struct it.stack[0].u.image.image_id)
1037 (struct_it.image_id, struct image.id, struct image_cache.size)
1038 (struct image_cache.used, struct image_cache.ref_count):
1039 * gtkutil.c (update_frame_tool_bar):
1040 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1041 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1042 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1043 * nsmenu.m (update_frame_tool_bar):
1044 * xdisp.c (calc_pixel_width_or_height):
1045 * xfns.c (image_cache_refcount):
1046 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1047 on typical 64-bit hosts.
1049 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1050 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1051 Omit unnecessary casts to int.
1052 (parse_image_spec): Check that integers fall into 'int' range
1053 when the callers expect that.
1054 (image_ascent): Redo ascent calculation to avoid int overflow.
1055 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1056 (lookup_image): Remove unnecessary tests.
1057 (xbm_image_p): Locals are now of int, not EMACS_INT,
1058 since parse_image_check makes sure they fit into int.
1059 (png_load, gif_load, svg_load_image):
1060 Prefer int to unsigned where either will do.
1061 (tiff_handler): New function, combining the cores of the
1062 old tiff_error_handler and tiff_warning_handler. This
1063 function is rewritten to use vsnprintf and thereby avoid
1064 stack buffer overflows. It uses only the features of vsnprintf
1065 that are common to both POSIX and native Microsoft.
1066 (tiff_error_handler, tiff_warning_handler): Use it.
1067 (tiff_load, gif_load, imagemagick_load_image):
1068 Don't assume :index value fits in 'int'.
1069 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1070 (imagemagick_load_image): Check that crop parameters fit into
1071 the integer types that MagickCropImage accepts. Don't assume
1072 Vimagemagick_render_type has a nonnegative value. Don't assume
1073 size_t fits in 'long'.
1074 (gs_load): Use printmax_t to print the widest integers possible.
1075 Check for integer overflow when computing image height and width.
1077 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1079 * xdisp.c (redisplay_window): Don't force window start if point
1080 will be invisible in the resulting window. (Bug#9324)
1082 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1084 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1085 the display spec is of the form `(space ...)'.
1086 (handle_display_spec): Return the value returned by
1087 handle_single_display_spec, not just 1 or zero.
1088 (handle_single_display_spec): If the display spec is of the form
1089 `(space ...)', and specifies display in the text area, return 2
1091 (try_cursor_movement): Check for the need to scroll more
1092 accurately, and prefer exact match for point under bidi. Don't
1093 advance `row' beyond the last row of the window.
1095 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1096 into disp_prop; all users changed.
1098 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1099 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1100 for the text covered by the display property.
1102 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1104 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1105 Change return value to nil.
1106 (Frecord_buffer): Delete unused function.
1108 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1110 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1111 buffers, return left-to-right.
1112 (set_cursor_from_row): Consider candidate row a win if its glyph
1113 represents a newline and point is on that newline. Fixes cursor
1114 positioning on the newline at EOL of R2L text within L2R
1115 paragraph, and vice versa.
1116 (try_cursor_movement): Check continued rows, in addition to
1117 continuation rows. Fixes unwarranted scroll when point enters a
1118 continued line of R2L text within an L2R paragraph, or vice versa.
1119 (cursor_row_p): Consider the case of point being equal to
1120 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1121 from the end of a short line to the beginning of a continued line
1122 of R2L text within L2R paragraph.
1123 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1124 composed characters.
1126 * bidi.c (bidi_check_type): Use xassert.
1127 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1130 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1132 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1135 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1137 * nsfont.m (ns_otf_to_script): Fix typo.
1139 2011-08-22 Kenichi Handa <handa@m17n.org>
1141 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1142 extra slot even if the purpose is char-code-property-table.
1144 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1146 * xdisp.c (redisplay_window): When computing centering_position,
1147 account for the height of the header line. (Bug#8874)
1149 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1150 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1151 candidate is selected by the mouse, and that candidate has a
1152 composed character under the mouse.
1154 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1155 coordinates reported by pos-visible-in-window-p for a composed
1156 character in column zero.
1158 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1160 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1162 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1164 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1165 consider it a hit if to_charpos is anywhere in the range of the
1166 composed buffer positions.
1168 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1170 * image.c (gif_load): Don't assume that each subimage has the same
1171 dimensions as the base image. Handle disposal method that is
1172 "undefined" by the gif spec (Bug#9335).
1174 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1176 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1177 (Fcondition_case): Document `debug' symbol in error handler.
1179 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1181 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1182 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1183 from an Org mode buffer to a Speedbar frame.
1185 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1186 a composition, take its buffer position from IT->cmp_it.charpos.
1187 Fixes cursor positioning at the beginning of a line that begins
1188 with a composed character.
1190 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1192 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1193 character bidirectional type, use STRONG_L instead. Fixes crashes
1194 in a buffer produced by `describe-categories'.
1196 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1197 members before the level stack, so they would be saved and
1198 restored when copying iterator state. Fixes incorrect reordering
1199 around TABs covered by display properties.
1201 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1203 * process.c (Fnetwork_interface_list): Correctly determine buffer
1206 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1208 * eval.c (internal_condition_case, internal_condition_case_1)
1209 (internal_condition_case_2, internal_condition_case_n):
1210 Remove unnecessary aborts (Bug#9081).
1212 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1214 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1215 has no `load' handler, try opening the file locally. (Bug#9311)
1217 2011-08-16 Ken Brown <kbrown@cornell.edu>
1219 * gmalloc.c: Expand comment.
1221 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1224 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1226 2011-08-16 Ken Brown <kbrown@cornell.edu>
1228 Fix memory allocation problems in Cygwin build (Bug#9273).
1230 * unexcw.c ( __malloc_initialized): Declare external variable.
1231 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1233 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1235 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1237 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1239 [CYGWIN] (special_realloc): New function.
1240 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1241 requests to realloc storage in the static heap.
1243 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1245 * bidi.c (bidi_initialize): Remove unused local.
1247 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1249 * biditype.h: File removed.
1251 * bidimirror.h: File removed.
1253 * deps.mk (bidi.o): Remove biditype.h and
1256 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1259 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1261 * chartab.c: Improve commentary for the uniprop_table API.
1263 * bidi.c (bidi_paragraph_init): Support zero value of
1264 bidi_ignore_explicit_marks_for_paragraph_level.
1265 (bidi_initialize): Use uniprop_table instead of including
1266 biditype.h and bidimirror.h.
1268 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1269 coordinates of the iterator when restoring from ppos_it.
1272 2011-08-14 Kenichi Handa <handa@m17n.org>
1274 * process.c (create_process): Call setup_process_coding_systems
1275 after the pid of the process is set to -1 (Bug#8162).
1277 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1279 * xdisp.c (move_it_in_display_line_to): Don't invoke
1280 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1281 ppos_it. Fixes vertical cursor motion when line beginning is
1282 covered by an image. (Bug#9296)
1284 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1286 * nsterm.h (ns_run_ascript): Declare.
1287 (NSAPP_DATA2_RUNASSCRIPT): Define.
1289 * nsfns.m (as_script, as_result, as_status): New static variables.
1290 (ns_run_ascript): New function.
1291 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1292 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1293 the event loop. Get status from as_status (Bug#7276).
1295 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1296 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1297 the event loop (Bug#7276).
1299 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1301 * gnutls.c (QCgnutls_bootprop_priority)
1302 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1303 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1304 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1305 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1306 (QCgnutls_bootprop_verify_hostname_error)
1307 (QCgnutls_bootprop_callbacks_verify): Rename from
1308 Qgnutls_bootprop_..., all uses changed.
1310 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1313 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1315 * xfaces.c (Qframe_set_background_mode): Now static.
1316 * dispextern.h (Qframe_set_background_mode): Remove decl.
1318 * process.c (Fnetwork_interface_info): Declare local only if needed.
1320 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1322 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1323 (Fnetwork_interface_list): Allocate in increments of bytes instead
1324 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1325 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1327 (struct ifflag_def): notrailers is smart on OSX.
1328 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1329 Get hardware address with getifaddrs if available.
1331 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1333 * xdisp.c (iterate_out_of_display_property): xassert that
1334 IT->position is set to within IT->object's boundaries. Break from
1335 the loop as soon as EOB is reached; avoids infloops in redisplay
1336 when IT->position is set up wrongly due to some bug.
1337 Set IT->current to match the bidi iterator unconditionally.
1338 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1339 entry. Force push_it to save on the stack the current
1340 buffer/string position, to be restored by pop_it. Fix flags in
1341 the iterator structure wrt the object coming from a display
1342 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1343 properties. (Bug#9284)
1345 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1347 * fontset.c (fontset_get_font_group): Add proper type checks.
1350 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1352 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1353 and LC_VERSION_MIN_MACOSX.
1354 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1355 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1357 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1359 * xdisp.c (forward_to_next_line_start): Allow to use the
1360 no-display-properties-and-no-overlays under bidi display.
1361 Set disp_pos in the bidi iterator to avoid searches for display
1362 properties and overlays.
1364 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1366 * editfns.c (Fset_time_zone_rule): Document relationship with the
1369 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1370 the font entity extracted from the cache (Bug#8109).
1372 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1374 * composite.c (autocmp_chars): Don't reset point. That is done by
1375 restore_point_unwind (Bug#5984).
1377 2011-08-07 Juri Linkov <juri@jurta.org>
1379 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1380 to show the arg `TIME' instead of `TIMEVAL'.
1382 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1385 display property strides EOL and includes a newline, as in
1386 longlines-mode. (Bug#9254)
1387 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1388 word-wrap under bidirectional display. (Bug#9224)
1390 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1391 is non-zero, even if the data buffer is NULL. Fixes a crash in
1392 vertical-motion with longlines-mode. (Bug#9254)
1394 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1396 * bidi.c <bidi_cache_total_alloc>: Now static.
1397 (bidi_initialize): Initialize bidi_cache_total_alloc.
1399 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1402 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1403 amount allocated this far in `bidi_cache_total_alloc'.
1404 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1405 non-zero, only free the data buffer without restoring the cache
1406 contents. All callers changed.
1408 * dispextern.h (bidi_unshelve_cache): Update prototype.
1410 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1411 (move_it_in_display_line, move_it_to)
1412 (move_it_vertically_backward, move_it_by_lines): Replace the call
1413 to xfree to an equivalent call to bidi_unshelve_cache.
1414 (move_it_in_display_line_to): Fix logic of returning
1415 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1417 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1419 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1420 came from a string character with a `cursor' property. (Bug#9229)
1422 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1424 * Makefile.in (LIB_PTHREAD): New variable.
1425 (LIBES): Add LIB_PTHREAD (Bug#9216).
1427 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1428 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1430 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1432 * regex.c (re_iswctype): Remove some redundant boolean
1435 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1437 * xterm.c (x_find_topmost_parent): New function.
1438 (x_set_frame_alpha): Find topmost parent window with
1439 x_find_topmost_parent and set the property there also (bug#9181).
1440 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1442 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1444 * callproc.c (Fcall_process): Avoid vfork clobbering
1445 the local vars buffer, coding_systems, current_dir.
1447 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1449 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1451 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1453 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1454 so that it is not optimized away.
1456 * xdisp.c (compute_display_string_pos): Remove unused local.
1458 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1460 Fix slow cursor motion and scrolling in large buffers with
1461 selective display, like Org Mode buffers. (Bug#9218)
1463 * dispextern.h (struct bidi_it): New member disp_prop_p.
1465 * xdisp.c: Remove one-slot cache of display string positions.
1466 (compute_display_string_pos): Accept an additional argument
1467 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1468 for a display string or property. If found, set DISP_PROP_P
1471 * bidi.c (bidi_fetch_char): Accept an additional argument
1472 DISP_PROP_P, and pass it to compute_display_string_pos.
1473 Only handle text covered by a display string if DISP_PROP_P is returned
1474 non-zero. All callers of bidi_fetch_char changed.
1476 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1478 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1480 2010-12-03 Don March <don@ohspite.net>
1482 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1483 last character M-[char] is translated to ESC [char] (bug#7541).
1485 2011-08-02 Kenichi Handa <handa@m17n.org>
1487 * lisp.h (uniprop_table): Extern it.
1489 * chartab.c (uniprop_table): Make it non-static.
1491 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1493 * xdisp.c (forward_to_next_line_start): Accept additional argument
1494 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1496 (reseat_at_next_visible_line_start): Use the bidi iterator state
1497 returned by forward_to_next_line_start to restore the state of
1498 it->bidi_it after backing up to previous newline. (Bug#9212)
1500 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1502 * regex.c (re_comp): Protoize.
1503 (re_exec): Fix return type.
1504 (regexec): Fix type of `ret'. (Bug#9203)
1506 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1508 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1509 This is needed if max-image-size is a floating-point number.
1511 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1513 * print.c (print_object): Print empty symbol as ##.
1515 * lread.c (read1): Read ## as empty symbol.
1517 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1519 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1520 setting frame foreground color (Bug#9175).
1521 (x_set_background_color): Likewise.
1523 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1524 contents (Bug#9176).
1525 (EmacsTooltip -init): Remove bezels and add shadows to
1528 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1529 or scroll bar (Bug#8470).
1531 * nsfont.m (nsfont_open): Remove assignment to voffset and
1532 unnecessary vars hshink, expand, hd, full_height, min_height.
1533 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1535 * nsterm.h (nsfont_info): Remove voffset field.
1537 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1539 Implement strike-through and overline on NextStep (Bug#8863).
1541 * nsfont.m (nsfont_open): Use underline position provided by font,
1542 instead of hard-coded value of 2.
1543 (nsfont_draw): Call ns_draw_text_decoration instead.
1545 * nsterm.h: Add declaration for ns_draw_text_decoration.
1547 * nsterm.m (ns_draw_text_decoration): New function for drawing
1548 underline, overline, and strike-through.
1549 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1550 ns_draw_text_decoration. Change treatment of cursor drawing to
1551 accommodate underlining, etc.
1553 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1555 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1558 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1560 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1561 Without this fix, if a signal arrives just after memory fills up,
1562 'malloc' might be invoked reentrantly.
1564 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1565 In other words, assume that every image size is allowed, on non-X
1566 hosts. This assumption is probably wrong, but it lets Emacs compile.
1568 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1570 * regex.c (re_iswctype): Convert return values to boolean.
1572 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1574 * xdisp.c (compute_display_string_pos): Don't use cached display
1575 string position if the buffer had its restriction changed.
1578 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1582 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1584 Integer signedness and overflow and related fixes. (Bug#9079)
1586 * bidi.c: Integer size and overflow fixes.
1587 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1588 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1589 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1590 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1591 (bidi_find_other_level_edge):
1592 Use ptrdiff_t instead of EMACS_INT where either will do.
1593 This works better on 32-bit hosts configured --with-wide-int.
1594 (bidi_cache_ensure_space): Check for size-calculation overflow.
1595 Use % rather than repeated addition, for better worst-case speed.
1596 Don't set bidi_cache_size until after xrealloc returns, because it
1598 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1599 (bidi_cache_ensure_space): Also check that the bidi cache size
1600 does not exceed that of the largest Lisp string or buffer. See Eli
1601 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1603 * alloc.c (__malloc_size_t): Remove.
1604 All uses replaced by size_t. See Andreas Schwab's note
1605 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1607 * image.c: Improve checking for integer overflow.
1608 (check_image_size): Assume that f is nonnull, since
1609 it is always nonnull in practice. This is one less thing to
1610 worry about when checking for integer overflow later.
1611 (x_check_image_size): New function, which checks for integer
1612 overflow issues inside X.
1613 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1614 This removes the need for a memory_full check.
1615 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1616 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1617 (xbm_read_bitmap_data): Change locals back to 'int', since
1618 their values must fit in 'int'.
1619 (xpm_load_image, png_load, tiff_load):
1620 Invoke x_create_x_image_and_pixmap earlier,
1621 to avoid much needless work if the image is too large.
1622 (tiff_load): Treat overly large images as if
1623 x_create_x_image_and_pixmap failed, not as malloc failures.
1624 (gs_load): Use x_check_image_size.
1626 * gtkutil.c: Omit integer casts.
1627 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1628 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1630 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1632 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1633 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1634 would wrongly return t on a 64-bit host.
1636 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1637 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1638 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1639 and therefore cause GCC to emit a bogus diagnostic in some cases.
1641 * image.c: Integer signedness and overflow and related fixes.
1642 This is not an exhaustive set of fixes, but it's time to
1643 record what I've got.
1644 (lookup_pixel_color, check_image_size): Remove redundant decls.
1645 (check_image_size): Don't assume that arbitrary EMACS_INT values
1646 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1647 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1648 (tiff_load, imagemagick_load_image):
1649 Check for overflow in size calculations.
1650 (x_create_x_image_and_pixmap): Remove unnecessary test for
1651 xmalloc returning NULL; that can't happen.
1652 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1653 (xpm_color_bucket): Use better integer hashing function.
1654 (xpm_cache_color): Don't possibly over-allocate memory.
1655 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1656 (gif_memory_source):
1657 Use ptrdiff_t, not int or size_t, to record sizes.
1658 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1659 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1660 either works, as we prefer signed integers.
1661 (tiff_read_from_memory, tiff_write_from_memory):
1662 Return tsize_t, not size_t, since that's what the TIFF API wants.
1663 (tiff_read_from_memory): Don't fail simply because the read would
1664 go past EOF; instead, return a short read.
1665 (tiff_load): Omit no-longer-needed casts.
1666 (Fimagemagick_types): Don't assume size fits into 'int'.
1668 Improve hashing quality when configured --with-wide-int.
1669 * fns.c (hash_string): New function, taken from sxhash_string.
1670 Do not discard information about ASCII character case; this
1671 discarding is no longer needed.
1672 (sxhash-string): Use it. Change sig to match it. Caller changed.
1673 * lisp.h: Declare it.
1674 * lread.c (hash_string): Remove, since we now use fns.c's version.
1675 The fns.c version returns a wider integer if --with-wide-int is
1676 specified, so this should help the quality of the hashing a bit.
1678 * emacs.c: Integer overflow minor fix.
1679 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1680 Define only if GNU_LINUX.
1681 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1683 * dispnew.c: Integer signedness and overflow fixes.
1684 Remove unnecessary forward decls, that were a maintenance hassle.
1685 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1687 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1688 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1689 (prepare_desired_row, line_draw_cost):
1690 Use int, not unsigned, where either works.
1691 (save_current_matrix, restore_current_matrix):
1692 Use ptrdiff_t, not size_t, where either works.
1693 (init_display): Check for overflow more accurately, and without
1694 relying on undefined behavior.
1696 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1697 Remove, replacing with the new symbols in lisp.h. All uses changed.
1698 * fileio.c (make_temp_name):
1699 * filelock.c (lock_file_1, lock_file):
1700 * xdisp.c (message_dolog):
1701 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1702 Use pMd etc. instead.
1703 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1704 replacing the pWIDE etc. symbols removed from editfns.c.
1706 * keyboard.h (num_input_events): Now uintmax_t.
1707 This is (very slightly) less likely to mess up due to wraparound.
1710 * buffer.c: Integer signedness fixes.
1711 (alloc_buffer_text, enlarge_buffer_text):
1712 Use ptrdiff_t rather than size_t when either will do, as we prefer
1715 * alloc.c: Integer signedness and overflow fixes.
1716 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1717 (__malloc_size_t): Default to size_t, not to int.
1718 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1719 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1720 Prefer ptrdiff_t to size_t when either would do, as we prefer
1722 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1723 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1724 Now const. Initialize with values that are in range even if char
1726 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1727 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1728 These functions do the right thing with sizes > 2**32.
1729 (check_depth): Now ptrdiff_t, not int.
1730 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1731 Adjust to new way of storing sizes. Check for size overflow bugs
1733 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1734 slightly wrong anyway, as it missed one instance of
1735 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1736 (refill_memory_reserve): Omit needless cast to size_t.
1737 (mark_object_loop_halt): Mark as externally visible.
1739 * xselect.c: Integer signedness and overflow fixes.
1740 (Fx_register_dnd_atom, x_handle_dnd_message):
1741 Use ptrdiff_t, not size_t, since we prefer signed.
1742 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1743 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1744 x_dnd_atoms_size and x_dnd_atoms_length.
1746 * doprnt.c: Prefer signed to unsigned when either works.
1748 * doprnt.c (doprnt):
1750 * xdisp.c (vmessage):
1751 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1752 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1753 prefer signed arithmetic to avoid comparison confusion.
1754 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1755 but is a bit tricky.
1757 Assume freestanding C89 headers, string.h, stdlib.h.
1758 * data.c, doprnt.c, floatfns.c, print.c:
1759 Include float.h unconditionally.
1760 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1761 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1762 * regex.c: Likewise for stddef.h, string.h.
1763 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1764 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1765 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1766 (STDC_HEADERS): Remove obsolete defines.
1767 * sysdep.c: Include limits.h unconditionally.
1769 Assume support for memcmp, memcpy, memmove, memset.
1770 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1771 * regex.c (memcmp, memcpy):
1772 Remove; we assume C89 now.
1774 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1775 (__malloc_safe_bcopy): Remove; no longer needed.
1777 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1778 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1779 well either way, and we prefer signed to unsigned.
1781 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1783 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1784 closes the connection while we're reading (bug#9182).
1786 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1788 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1789 are specified (Bug#9168).
1791 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1793 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1794 Found by GCC static checking and --with-wide-int on a 32-bit host.
1796 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1798 * xdisp.c (compute_display_string_pos): Fix logic of caching
1799 previous display string position. Initialize cached_prev_pos to
1800 -1. Fixes slow-down at the beginning of a buffer.
1802 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1804 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1805 for attrs[LFACE_FONTSET_INDEX].
1807 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1809 * xml.c (parse_region): Remove unused local
1810 that was recently introduced.
1812 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1814 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1815 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1817 * xdisp.c (move_it_in_display_line_to): Record the best matching
1818 position for TO_CHARPOS while scanning the line, and restore it on
1819 exit if none of the characters scanned was an exact match.
1820 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1821 when exact match is impossible due to invisible text, and the
1822 lines are truncated.
1824 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1826 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1829 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1831 Fix a significant slow-down of cursor motion with C-n, C-p,
1832 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1833 auto-repeat under bidi redisplay in fontified buffers.
1834 * xdisp.c (compute_stop_pos_backwards): New function.
1835 (next_element_from_buffer): Call compute_stop_pos_backwards to
1836 find a suitable prev_stop when we find ourselves before
1838 (reseat): Don't look for prev_stop, as that could mean a very long
1840 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1841 <cached_disp_overlay_modiff>: Cache for last found display string
1843 (compute_display_string_pos): Return the cached position if asked
1844 about the same buffer in the same area of character positions, and
1845 the buffer wasn't changed since the time the display string
1846 position was cached.
1848 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1851 is an integer, which is important for empty lines. (Bug#9149)
1853 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1855 * frame.c (Fmodify_frame_parameters): In tty case, update the
1856 default face if necessary (Bug#4238).
1858 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1860 * editfns.c (Fstring_to_char): No need to explain what a character
1861 is in the docstring (Bug#6576).
1863 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1865 * xml.c (parse_region): Make sure we always return a tree.
1867 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1869 * xml.c (parse_region): If a document contains only comments,
1872 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1874 * xml.c (make_dom): Return comments, too.
1876 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1879 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1880 and the surrounding thread.
1881 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1882 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1883 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1885 * s/openbsd.h (BROKEN_SIGIO): Define.
1886 * unexelf.c (unexec) [__OpenBSD__]:
1887 Don't update the .mdebug section of the Alpha COFF symbol table.
1889 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1891 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1894 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1896 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1897 This fixes some race conditions on the permissions of any newly
1900 * alloc.c (valid_pointer_p): Use pipe, not open.
1901 This fixes some permissions issues when debugging.
1903 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1904 If fchown fails to set both uid and gid, try to set just gid,
1905 as that is sometimes allowed. Adjust the file's mode to eliminate
1906 setuid or setgid bits that are inappropriate if fchown fails.
1908 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1910 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1911 to compare Lisp_Objects.
1912 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1913 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1914 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1916 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1918 * lread.c (read_integer): Unread even EOF character.
1919 (read1): Likewise. Properly record start position of symbol.
1921 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1922 symbol character follows.
1924 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1926 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1927 This works around a problem with the previous change to Fcopy_file.
1928 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1929 and without this change, GCC might complain about discarding
1930 fchown's return value.
1932 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1934 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1936 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1938 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1940 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1942 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1943 it's used from the C level.
1945 * process.c: Use the same condition for POLL_FOR_INPUT in both
1946 keyboard.c and process.c (bug#1858).
1948 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1950 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1951 (Fgnutls_boot): Use it.
1953 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1955 * doc.c (Fsubstitute_command_keys): Revert last change.
1957 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1959 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1960 quotes the next character, and doesn't affect other longer
1961 sequences (bug#8935).
1963 * lread.c (syms_of_lread): Clarify that is isn't only
1964 `eval-buffer' and `eval-defun' that's affected by
1965 `lexical-binding' (bug#8460).
1967 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1969 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1970 bidi redisplay when a line includes both an image and is
1973 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1975 Fix minor problems found by static checking.
1976 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1977 (elsz): Now a signed constant, not a size_t var. We prefer signed
1978 types to unsigned, to avoid integer comparison confusion. Without
1979 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1980 "cannot optimize loop, the loop counter may overflow", a symptom
1982 * indent.c (Fvertical_motion): Mark locals as initialized.
1983 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1985 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1987 * search.c (Fre_search_backward): Mention `case-fold-search' in
1988 all the re_search_* functions (bug#8138).
1990 * keyboard.c (Fopen_dribble_file): Document when the file is
1993 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1995 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1998 Support bidi reordering of display and overlay strings.
1999 * xdisp.c (compute_display_string_pos)
2000 (compute_display_string_end): Accept additional argument STRING.
2001 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2002 (reseat_to_string): Initialize bidi_it->string.s and
2003 bidi_it->string.schars.
2004 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2005 NULL (avoids a crash in bidi_paragraph_init).
2006 Initialize itb.string.lstring.
2007 (init_iterator): Call bidi_init_it only of a valid
2008 buffer position was specified. Initialize paragraph_embedding to
2010 (reseat_to_string): Initialize the bidi iterator.
2011 (display_string): If we need to ignore text properties of
2012 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2013 original value of -1 will not work with bidi.)
2014 (compute_display_string_pos): First arg is now struct
2015 `text_pos *'; all callers changed. Support display properties on
2017 (compute_display_string_end): Support display properties on Lisp
2019 (init_iterator, reseat_1, reseat_to_string): Initialize the
2020 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2021 when iterating on a string not from display properties).
2022 (compute_display_string_pos, compute_display_string_end):
2023 Fix calculation of the object to scan. Fixes an error when using
2025 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2026 base_level_stop; instead, set base_level_stop to BEGV.
2027 Fixes crashes in vertical-motion.
2028 (next_element_from_buffer): Improve commentary for when
2029 the iterator is before prev_stop.
2030 (init_iterator): Initialize bidi_p from the default value of
2031 bidi-display-reordering, not from buffer-local value. Use the
2032 buffer-local value only if initializing for buffer iteration.
2033 (handle_invisible_prop): Support invisible properties on strings
2034 that are being bidi-reordered.
2035 (set_iterator_to_next): Support bidi reordering of C strings and
2037 (next_element_from_string): Support bidi reordering of Lisp
2039 (handle_stop_backwards): Support Lisp strings as well.
2040 (display_string): Support display of R2L glyph rows.
2041 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2042 (init_iterator): Don't initialize it->bidi_p for strings
2044 (reseat_to_string): Initialize it->bidi_p for strings here.
2045 (next_element_from_string, next_element_from_c_string)
2046 (next_element_from_buffer): Add xassert's for correspondence
2047 between IT's object being iterated and it->bidi_it.string
2049 (face_before_or_after_it_pos): Support bidi iteration.
2050 (next_element_from_c_string): Handle the case of the first string
2051 character that is not the first one in the visual order.
2052 (get_visually_first_element): New function, refactored from common
2053 parts of next_element_from_buffer, next_element_from_string, and
2054 next_element_from_c_string.
2055 (tool_bar_lines_needed, redisplay_tool_bar)
2056 (display_menu_bar): Force left-to-right direction. Add a FIXME
2057 comment for making that be controlled by a user option.
2058 (push_it, pop_it): Save and restore the state of the
2059 bidi iterator. Save and restore the bidi_p flag.
2060 (pop_it): Iterate out of display property for string iteration as
2062 (iterate_out_of_display_property): Support iteration over strings.
2063 (handle_single_display_spec): Set up it->bidi_it for iteration
2064 over a display string, and call bidi_init_it.
2065 (handle_single_display_spec, next_overlay_string)
2066 (get_overlay_strings_1, push_display_prop): Set up the bidi
2067 iterator for displaying display or overlay strings.
2068 (forward_to_next_line_start): Don't use the shortcut if
2070 (back_to_previous_visible_line_start): If handle_display_prop
2071 pushed the iterator stack, restore the internal state of the bidi
2072 iterator by calling bidi_pop_it same number of times.
2073 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2074 and we are bidi-iterating, don't decrement the iterator position;
2075 instead, set the first_elt flag in the bidi iterator, to produce
2077 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2078 (push_display_prop): xassert that we are iterating a buffer.
2079 (push_it, pop_it): Save and restore paragraph_embedding member.
2080 (handle_single_display_spec, next_overlay_string)
2081 (get_overlay_strings_1, reseat_1, reseat_to_string)
2082 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2083 correctly. Don't assume unibyte strings are not bidi-reordered.
2084 (compute_display_string_pos)
2085 (compute_display_string_end): Fix handling the case of C string.
2086 (push_it, pop_it): Save and restore from_disp_prop_p.
2087 (handle_single_display_spec, push_display_prop): Set the
2088 from_disp_prop_p flag.
2089 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2090 (pop_it): Call iterate_out_of_display_property only if we are
2091 popping after iteration over a string that came from a display
2092 property. Fix a typo in popping stretch info. Add an assertion
2093 for verifying that the iterator position is in sync with the bidi
2095 (handle_single_display_spec, get_overlay_strings_1)
2096 (push_display_prop): Fix initialization of paragraph direction for
2097 string when that of the parent object is not yet determined.
2098 (reseat_1): Call bidi_init_it to resync the bidi
2099 iterator with IT's position. (Bug#7616)
2100 (find_row_edges): If ROW->start.pos gives position
2101 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2102 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2103 Reset the from_disp_prop_p flag.
2104 (SAVE_IT, RESTORE_IT): New macros.
2105 (pos_visible_p, face_before_or_after_it_pos)
2106 (back_to_previous_visible_line_start)
2107 (move_it_in_display_line_to, move_it_in_display_line)
2108 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2109 (try_scrolling, redisplay_window, display_line): Use them when
2110 saving a temporary copy of the iterator and restoring it back.
2111 (back_to_previous_visible_line_start, reseat_1)
2112 (init_iterator): Empty the bidi cache "stack".
2113 (move_it_in_display_line_to): If iterator ended up at
2114 EOL, but we never saw any buffer positions smaller than
2115 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2116 motion in bidi-reordered lines.
2117 (move_it_in_display_line_to): Record prev_method and prev_pos
2118 immediately before the call to set_iterator_to_next. Fixes cursor
2119 motion in bidi-reordered lines with stretch glyphs and strings
2120 displayed in margins. (Bug#8133) (Bug#8867)
2121 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2123 (pos_visible_p): Support positions in bidi-reordered lines.
2124 Save and restore bidi cache.
2126 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2127 (bidi_paragraph_info): Delete unused struct.
2128 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2129 (bidi_cache_start): New variable.
2130 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2132 (bidi_cache_fetch_state, bidi_cache_search)
2133 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2134 (bidi_cache_find, bidi_peek_at_next_level)
2135 (bidi_level_of_next_char, bidi_find_other_level_edge)
2136 (bidi_move_to_visually_next): Compare cache index with
2137 bidi_cache_start rather than with zero.
2138 (bidi_fetch_char): Accept new argument STRING; all callers
2139 changed. Support iteration over a string. Support strings with
2140 display properties. Support unibyte strings. Fix the type of
2141 `len' according to what STRING_CHAR_AND_LENGTH expects.
2142 (bidi_paragraph_init, bidi_resolve_explicit_1)
2143 (bidi_resolve_explicit, bidi_resolve_weak)
2144 (bidi_level_of_next_char, bidi_move_to_visually_next):
2145 Support iteration over a string.
2146 (bidi_set_sor_type, bidi_resolve_explicit_1)
2147 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2148 can now be zero (for strings); special values 0 and -1 were
2149 changed to -1 and -2, respectively.
2150 (bidi_char_at_pos): New function.
2151 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2152 Call it instead of FETCH_MULTIBYTE_CHAR.
2153 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2154 initialized to valid values.
2155 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2157 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2158 the test for valid cached positions. Fix the logic for looking up
2159 the sentinel state in the cache. GCPRO the Lisp string we are
2161 (bidi_push_it, bidi_pop_it): New functions.
2162 (bidi_initialize): Initialize the bidi cache start stack pointer.
2163 (bidi_cache_ensure_space): New function, refactored from part of
2164 bidi_cache_iterator_state. Don't assume the required size is just
2165 one BIDI_CACHE_CHUNK away.
2166 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2167 (bidi_count_bytes, bidi_char_at_pos): New functions.
2168 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2169 always valid if bidi_cache_idx is valid.
2170 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2171 is valid if it's going to be used.
2172 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2173 (bidi_cache_fetch_state, bidi_cache_search)
2174 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2175 (bidi_cache_iterator_state, bidi_cache_find)
2176 (bidi_find_other_level_edge, bidi_cache_start_stack):
2177 All variables related to cache indices are now EMACS_INT.
2179 * dispextern.h (struct bidi_string_data): New structure.
2180 (struct bidi_it): New member `string'. Make flag members be 1-bit
2181 fields, and put them last in the struct.
2182 (compute_display_string_pos, compute_display_string_end):
2184 (bidi_push_it, bidi_pop_it): Add prototypes.
2185 (struct iterator_stack_entry): New members bidi_p,
2186 paragraph_embedding, and from_disp_prop_p.
2187 (struct it): Member bidi_p is now a bit field 1 bit wide.
2188 (bidi_shelve_cache, bidi_unshelve_cache):
2191 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2192 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2193 and vector-like objects.
2195 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2196 cache around display iteration.
2198 * window.c (Fwindow_end, window_scroll_pixel_based)
2199 (displayed_window_lines, Frecenter): Save and restore the bidi
2200 cache around display iteration.
2202 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2204 * editfns.c (Fdelete_region): Clarify the use of the named
2205 parameters (bug#6788).
2207 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2209 * indent.c (Fvertical_motion): Set and restore w->pointm when
2210 saving and restoring the window's buffer (Bug#9006).
2212 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2214 * editfns.c (Fstring_to_char): Clarify just what is returned
2215 (bug#6576). Text by Eli Zaretskii.
2217 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2219 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2221 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2223 * buffer.c (mmap_find): Fix a typo.
2225 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2227 Fix execution of x selection hooks.
2228 * xselect.c (Qx_lost_selection_functions)
2229 (Qx_sent_selection_functions): New vars.
2230 (syms_of_xselect): DEFSYM them.
2231 (x_handle_selection_request): Pass Qx_sent_selection_functions
2232 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2233 (x_handle_selection_clear,x_clear_frame_selections):
2234 Pass Qx_lost_selection_functions rather than
2235 Vx_lost_selection_functions to Frun_hook_with_args.
2237 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2239 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2240 The old code sometimes used this field without initializing it.
2242 * alloc.c (gc_sweep): Don't read past end of array.
2243 In theory, the old code could also have corrupted Emacs internals,
2244 though it'd be very unlikely.
2246 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2248 * character.c (Fcharacterp): Don't advertise optional ignored
2249 argument. (Bug#4026)
2251 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2253 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2256 * window.c (Fset_window_start): Doc fix (bug#4199).
2257 (Fset_window_hscroll): Ditto.
2259 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2261 Fix minor new problems caught by GCC 4.6.1.
2262 * term.c (init_tty): Remove unused local.
2263 * xsettings.c (store_monospaced_changed): Define this function only
2264 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2267 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2269 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2271 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2273 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2274 are the mini-buffer and the echo area (bug#3320).
2276 * term.c (init_tty): Remove support for supdup, c10 and perq
2277 terminals, which are no longer supported (bug#1482).
2279 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2281 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2283 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2285 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2286 for non-popups (Bug#3642).
2288 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2290 * alloc.c (reset_malloc_hooks): Protoize.
2291 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2292 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2293 * cm.c (losecursor): Likewise.
2294 * data.c (fmod): Likewise.
2295 * dispnew.c (swap_glyphs_in_rows): Likewise.
2296 * emacs.c (memory_warning_signal): Likewise.
2297 * floatfns.c (float_error): Likewise.
2298 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2299 (otf_open, font_otf_capability, generate_otf_features)
2300 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2302 * image.c (pbm_read_file): Likewise.
2303 * indent.c (string_display_width): Likewise.
2304 * intervals.c (check_for_interval, search_for_interval)
2305 (inc_interval_count, count_intervals, root_interval)
2306 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2307 * lread.c (defalias): Likewise.
2308 * ralloc.c (r_alloc_check): Likewise.
2309 * regex.c (set_image_of_range_1, set_image_of_range)
2310 (regex_grow_registers): Likewise.
2311 * sysdep.c (strerror): Likewise.
2312 * termcap.c (valid_filename_p, tprint, main): Likewise.
2313 * tparam.c (main): Likewise.
2314 * unexhp9k800.c (run_time_remap, save_data_space)
2315 (update_file_ptrs, read_header, write_header, calculate_checksum)
2316 (copy_file, copy_rest, display_header): Likewise.
2317 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2319 * xdisp.c (check_it): Likewise.
2320 * xfaces.c (register_color, unregister_color, unregister_colors):
2322 * xfns.c (print_fontset_result): Likewise.
2323 * xrdb.c (member, fatal, main): Likewise.
2325 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2327 Fix minor problems found by static checking (Bug#9031).
2328 * chartab.c (char_table_set_range, map_sub_char_table):
2329 Remove unused locals.
2330 (uniprop_table): Now static.
2331 * composite.c (_work_char): Remove unused static var.
2333 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2335 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2337 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2339 * gtkutil.c (qttip_cb): Remove code without function.
2341 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2343 * w32.c (pthread_sigmask): New stub.
2345 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2347 Use pthread_sigmask, not sigprocmask (Bug#9010).
2348 sigprocmask is portable only for single-threaded applications, and
2349 Emacs can be multi-threaded when it uses GTK.
2350 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2352 * callproc.c (Fcall_process):
2353 * process.c (create_process):
2354 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2355 Use pthread_sigmask, not sigprocmask.
2357 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2359 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2360 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2363 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2365 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2366 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2367 (xg_hide_tooltip): Fix comment.
2369 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2370 in registerServicesMenuSendTypes.
2371 (validRequestorForSendType): Don't check ns_return_types.
2373 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2376 2011-07-08 Jason Rumney <jasonr@gnu.org>
2378 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2379 frame struct members of non-existent frames (Bug#6284).
2381 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2383 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2384 variable firstTime not needed on OSX >= 10.6.
2385 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2386 >= 10.5. Use setKnobProportion, setDoubleValue.
2388 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2389 (MAC_OS_X_VERSION_10_5): Define if not defined.
2390 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2391 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2392 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2394 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2395 cString and lossyCString on OSX >= 10.4
2397 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2398 sizeToFit on OSX >= 10.2.
2400 * nsimage.m (allocInitFromFile): Don't use deprecated method
2401 bestRepresentationForDevice on OSX >= 10.6.
2403 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2406 * emacs.c: Declare unexec_init_emacs_zone.
2408 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2410 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2412 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2413 on svcsMenu (Bug#8842).
2415 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2417 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2419 * nsterm.m (QUTF8_STRING): Declare.
2420 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2421 (validRequestorForSendType): Return type is (id).
2422 Change indexOfObjectIdenticalTo to indexOfObject.
2423 Check if we have local selection before returning self (Bug#8842).
2424 (writeSelectionToPasteboard): Put local selection into paste board
2425 if we have a local selection (Bug#8842).
2426 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2428 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2429 (ns_get_local_selection): Declare.
2431 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2433 * keymap.c (describe_map_tree): Don't insert a double newline at
2434 the end of the buffer (bug#1169) and return whether we inserted
2437 * callint.c (Fcall_interactively): Change "reading args" to
2438 "providing args" to try to clarify what it does (bug#1010).
2440 2011-07-07 Kenichi Handa <handa@m17n.org>
2442 * composite.c (composition_compute_stop_pos): Ignore a static
2443 composition starting before CHARPOS (Bug#8915).
2445 * xdisp.c (handle_composition_prop): Likewise.
2447 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2449 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2452 2011-07-07 Kenichi Handa <handa@m17n.org>
2454 * character.h (unicode_category_t): New enum type.
2456 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2457 (Qchar_code_property_table): New variable.
2458 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2459 (UNIPROP_COMPRESSED_FORM_P): New macros.
2460 (char_table_ascii): Uncompress the compressed values.
2461 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2462 Uncompress the compressed values.
2463 (sub_char_table_ref_and_range): Likewise.
2464 (char_table_ref_and_range): Uncompress the compressed values.
2465 (sub_char_table_set): New arg is_uniprop. Callers changed.
2466 Uncompress the compressed values.
2467 (sub_char_table_set_range): Args changed. Callers changed.
2468 (char_table_set_range): Adjuted for the above change.
2469 (map_sub_char_table): Delete args default_val and parent. Add arg
2470 top. Give decoded values to a Lisp function.
2471 (map_char_table): Adjust for the above change. Give decoded
2472 values to a Lisp function. Gcpro more variables.
2473 (uniprop_table_uncompress)
2474 (uniprop_decode_value_run_length): New functions.
2475 (uniprop_decoder, uniprop_decoder_count): New variables.
2476 (uniprop_get_decoder, uniprop_encode_value_character)
2477 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2479 (uniprop_encoder, uniprop_encoder_count): New variables.
2480 (uniprop_get_encoder, uniprop_table)
2481 (Funicode_property_table_internal, Fget_unicode_property_internal)
2482 (Fput_unicode_property_internal): New functions.
2483 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2484 Sunicode_property_table_internal, Sget_unicode_property_internal,
2485 and Sput_unicode_property_internal. Defvar_lisp
2486 char-code-property-alist.
2488 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2489 Vunicode_category_table.
2491 * font.c (font_range): Adjust for the change of
2492 Vunicode_category_table.
2494 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2496 * m/iris4d.h: Remove file, move contents ...
2497 * s/irix6-5.h: ... here.
2499 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2501 Remove unportable assumption about struct layout (Bug#8884).
2502 * alloc.c (mark_buffer):
2503 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2504 (clone_per_buffer_values): Don't assume that
2505 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2506 This isn't true in general, and it's particularly not true
2507 if Emacs is configured with --with-wide-int.
2508 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2509 New macros, used in the buffer.c change.
2511 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2513 * xsettings.c: Use both GConf and GSettings if both are available.
2514 (store_config_changed_event): Add comment.
2515 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2516 (store_tool_bar_style_changed): New functions.
2517 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2518 (struct xsettings): Move font inside HAVE_XFT.
2519 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2520 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2521 Move inside HAVE_XFT.
2522 (something_changed_gsettingsCB): Rename from something_changedCB.
2523 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2525 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2526 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2527 (something_changed_gconfCB): Rename from something_changedCB.
2528 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2529 (parse_settings): Move check for font inside HAVE_XFT.
2530 (read_settings, apply_xft_settings): Add comment.
2531 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2532 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2533 call store_font_name_changed.
2534 (xft_settings_event): Add comment.
2535 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2536 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2537 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2538 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2539 (xsettings_initialize): Call init_gsettings last.
2540 (xsettings_get_system_font, xsettings_get_system_normal_font):
2543 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2545 Random fixes. E.g., (random) never returned negative values.
2546 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2547 subseconds part to the entropy, as that's a bit more random.
2548 Prefer signed to unsigned, since the signedness doesn't matter and
2549 in general we prefer signed. When given a limit, use a
2550 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2551 latter isn't right if USE_2_TAGS_FOR_INTS.
2552 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2553 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2555 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2557 * textprop.c (text_property_stickiness):
2558 Obey Vtext_property_default_nonsticky.
2559 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2560 * w32fns.c (syms_of_w32fns):
2561 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2563 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2565 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2566 This is more efficient than Ffile_directory_p and avoids a minor race.
2568 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2570 * buffer.c (Foverlay_put): Say what the return value is
2573 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2574 is a directory before asking whether to use the file name
2576 (barf_or_query_if_file_exists): Make the "File is a directory"
2577 error be more correct.
2579 * fns.c (Frequire): Remove the mention of the .gz files, since
2580 that's installation-specific, but keep the mention of
2581 `get-load-suffixes'.
2583 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2585 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2586 Report string overflow if the output is too long.
2588 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2590 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2591 (syms_of_gnutls): Remove duplicate DEFSYM for
2592 Qgnutls_bootprop_verify_hostname_error, an error for
2593 Qgnutls_bootprop_verify_error (which is no longer used).
2595 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2596 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2597 Also (re)move comments that are misplaced or no longer relevant.
2599 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2601 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2603 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2605 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2606 and background color parameters if they have been changed.
2608 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2610 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2612 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2614 * xsettings.c (SYSTEM_FONT): Define only when used.
2615 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2617 * keymap.c (access_keymap_1): Now static.
2619 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2621 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2622 leave any prefix arg for the up event (Bug#1586).
2624 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626 * lread.c (syms_of_lread): Mention single symbols defined by
2627 `defvar' or `defconst' (bug#7154).
2629 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2630 (Frequire): Mention get-load-suffixes.
2632 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2634 * window.h (window): Remove clone_number slot.
2635 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2637 (make_parent_window, make_window, saved_window)
2638 (Fset_window_configuration, save_window_save): Don't deal with
2640 * buffer.c (Qclone_number): Remove declaration.
2641 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2643 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2645 Add multiple inheritance to keymaps.
2646 * keymap.c (Fmake_composed_keymap): New function.
2647 (Fset_keymap_parent): Simplify.
2648 (fix_submap_inheritance): Remove.
2649 (access_keymap_1): New function extracted from access_keymap to handle
2650 embedded parents and handle lists of maps.
2651 (access_keymap): Use it.
2652 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2653 (Fcopy_keymap): Handle embedded parents.
2654 (Fcommand_remapping, define_as_prefix): Simplify.
2655 (Fkey_binding): Simplify.
2656 (syms_of_keymap): Move minibuffer-local-completion-map,
2657 minibuffer-local-filename-completion-map,
2658 minibuffer-local-must-match-map, and
2659 minibuffer-local-filename-must-match-map to Elisp.
2660 (syms_of_keymap): Defsubr make-composed-keymap.
2661 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2662 (parse_menu_item): Trivial simplification.
2664 2011-07-01 Glenn Morris <rgm@gnu.org>
2666 * Makefile.in (SETTINGS_LIBS): Fix typo.
2668 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2670 * coding.c (Fencode_coding_string): Record the last coding system
2671 used, as the function doc string says (bug#8738).
2673 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2675 * xsettings.c (store_monospaced_changed): Take new font as arg and
2676 check for change against current_mono_font.
2677 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2678 (emacs_settings_constructor, emacs_settings_get_property)
2679 (emacs_settings_set_property, emacs_settings_class_init)
2680 (emacs_settings_init, gsettings_obj): Remove.
2681 (something_changedCB): New function for HAVE_GSETTINGS.
2682 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2683 with value as argument.
2684 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2685 g_settings_new (Bug#8967). Do not create gsettings_obj.
2686 Remove calls to g_settings_bind. Connect something_changedCB to
2689 * xgselect.c: Add defined (HAVE_GSETTINGS).
2690 (xgselect_initialize): Ditto.
2692 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2693 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2696 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2698 * eval.c (struct backtrace): Simplify and port the data structure.
2699 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2700 signed bit field, as this assumption is not portable and it makes
2701 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2702 "char debug_on_exit : 1" as this is not portable either; instead,
2703 use the portable "unsigned int debug_on_exit : 1". Remove unused
2704 member evalargs. Remove obsolete comments about cc bombing out.
2706 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2708 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2709 Let HAVE_GSETTINGS override HAVE_GCONF.
2710 (store_monospaced_changed): New function.
2711 (EMACS_SETTINGS): A new type derived from GObject to handle
2712 GSettings notifications.
2713 (emacs_settings_constructor, emacs_settings_get_property)
2714 (emacs_settings_set_property, emacs_settings_class_init):
2716 (gsettings_client, gsettings_obj): New variables.
2717 (GSETTINGS_SCHEMA): New define.
2718 (something_changedCB): Call store_monospaced_changed.
2719 (init_gsettings): New function.
2720 (xsettings_initialize): Call init_gsettings.
2721 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2724 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2727 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2729 * window.c (resize_root_window, grow_mini_window)
2730 (shrink_mini_window): Rename Qresize_root_window to
2731 Qwindow_resize_root_window and Qresize_root_window_vertically to
2732 Qwindow_resize_root_window_vertically.
2734 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2736 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2738 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2740 * makefile.w32-in: Redesign dependencies so they reflect more
2741 clearly which files are directly included by each source file,
2742 and not through other includes.
2744 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2746 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2747 (sort_overlays, overlay_strings): When an overlay's clone number
2748 matches the window's clone number process the overlay even if
2749 the overlay's window property doesn't match the current window.
2751 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2752 (Fwindow_hchild): Rename to Fwindow_left_child.
2753 (Fwindow_next): Rename to Fwindow_next_sibling.
2754 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2755 (resize_window_check): Rename to window_resize_check.
2756 (resize_window_apply): Rename to window_resize_apply.
2757 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2758 (Fdelete_other_windows_internal, resize_frame_windows)
2759 (Fsplit_window_internal, Fdelete_window_internal)
2760 (grow_mini_window, shrink_mini_window)
2761 (Fresize_mini_window_internal): Fix callers accordingly.
2763 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2765 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2766 (emacs_fixed_set_min_size): Remove.
2767 (emacs_fixed_new): Take frame as argument.
2769 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2770 (_EmacsFixedPrivate): Remove minwidth/height.
2771 Add struct frame *f.
2772 (emacs_fixed_init): Initialize priv->f.
2773 (get_parent_class, emacs_fixed_set_min_size): Remove.
2774 (emacs_fixed_new): Set priv->f to argument.
2775 (emacs_fixed_get_preferred_width)
2776 (emacs_fixed_get_preferred_height): Use min_width/height from
2777 frames size_hint to set minimum and natural (Bug#8919).
2778 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2779 and use min_width/height from frames size_hint to set
2780 min_width/height (Bug#8919).
2782 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2783 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2786 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2788 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2789 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2792 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2794 * process.c (wait_reading_process_output): Bypass select if
2795 waiting for a cell while ignoring keyboard input, and input is
2796 pending. Suggested by Jan Djärv (Bug#8869).
2798 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2800 Use gnulib's dup2 module instead of rolling our own.
2801 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2803 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2805 * dispnew.c (scrolling_window): Before scrolling, turn off a
2806 mouse-highlight in the window being scrolled.
2808 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2810 Move DEFSYM to lisp.h and use everywhere.
2812 * character.h (DEFSYM): Move declaration...
2813 * lisp.h (DEFSYM): ...here.
2819 * w32select.c: Don't include character.h.
2821 * alloc.c (syms_of_alloc):
2822 * buffer.c (syms_of_buffer):
2823 * bytecode.c (syms_of_bytecode):
2824 * callint.c (syms_of_callint):
2825 * casefiddle.c (syms_of_casefiddle):
2826 * casetab.c (init_casetab_once):
2827 * category.c (init_category_once, syms_of_category):
2828 * ccl.c (syms_of_ccl):
2829 * cmds.c (syms_of_cmds):
2830 * composite.c (syms_of_composite):
2831 * dbusbind.c (syms_of_dbusbind):
2832 * dired.c (syms_of_dired):
2833 * dispnew.c (syms_of_display):
2834 * doc.c (syms_of_doc):
2835 * editfns.c (syms_of_editfns):
2836 * emacs.c (syms_of_emacs):
2837 * eval.c (syms_of_eval):
2838 * fileio.c (syms_of_fileio):
2839 * fns.c (syms_of_fns):
2840 * frame.c (syms_of_frame):
2841 * fringe.c (syms_of_fringe):
2842 * insdel.c (syms_of_insdel):
2843 * keymap.c (syms_of_keymap):
2844 * lread.c (init_obarray, syms_of_lread):
2845 * macros.c (syms_of_macros):
2846 * msdos.c (syms_of_msdos):
2847 * print.c (syms_of_print):
2848 * process.c (syms_of_process):
2849 * search.c (syms_of_search):
2850 * sound.c (syms_of_sound):
2851 * syntax.c (init_syntax_once, syms_of_syntax):
2852 * terminal.c (syms_of_terminal):
2853 * textprop.c (syms_of_textprop):
2854 * undo.c (syms_of_undo):
2855 * w32.c (globals_of_w32):
2856 * window.c (syms_of_window):
2857 * xdisp.c (syms_of_xdisp):
2858 * xfaces.c (syms_of_xfaces):
2859 * xfns.c (syms_of_xfns):
2860 * xmenu.c (syms_of_xmenu):
2861 * xsettings.c (syms_of_xsettings):
2862 * xterm.c (syms_of_xterm): Use DEFSYM.
2864 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2866 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2868 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2870 Integer and buffer overflow fixes (Bug#8873).
2872 * print.c (printchar, strout): Check for string overflow.
2873 (PRINTPREPARE, printchar, strout):
2874 Don't set size unless allocation succeeds.
2876 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2877 for sizes. Check for string overflow more accurately.
2878 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2880 * macros.c: Integer and buffer overflow fixes.
2881 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2882 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2883 Use ptrdiff_t, not int, for sizes.
2884 Don't increment bufsize until after realloc succeeds.
2885 Check for size-calculation overflow.
2886 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2888 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2890 * lread.c: Integer overflow fixes.
2891 (read_integer): Radix is now EMACS_INT, not int,
2892 to improve quality of diagnostics for out-of-range radices.
2893 Calculate buffer size correctly for out-of-range radices.
2894 (read1): Check for integer overflow in radices, and in
2895 read-circle numbers.
2896 (read_escape): Avoid int overflow.
2897 (Fload, openp, read_buffer_size, read1)
2898 (substitute_object_recurse, read_vector, read_list, map_obarray):
2899 Use ptrdiff_t, not int, for sizes.
2900 (read1): Use EMACS_INT, not int, for sizes.
2901 Check for size overflow.
2903 * image.c (cache_image): Check for size arithmetic overflow.
2905 * lread.c: Integer overflow issues.
2906 (saved_doc_string_size, saved_doc_string_length)
2907 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2908 Now ptrdiff_t, not int.
2909 (read1): Don't assume doc string length fits in int. Check for
2910 out-of-range doc string lengths.
2911 (read_list): Don't assume file position fits in int.
2912 (read_escape): Check for hex character overflow.
2914 2011-06-22 Leo Liu <sdl.web@gmail.com>
2916 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2917 Move to minibuffer.el.
2919 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2921 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2922 The following patches are for when GLYPH_DEBUG && !XASSERT.
2923 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2924 * dispnew.c (flush_stdout):
2925 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2926 Mark as externally visible.
2927 * dispnew.c (check_window_matrix_pointers): Now static.
2928 * dispnew.c (window_to_frame_vpos):
2929 * xfns.c (unwind_create_frame):
2930 * xterm.c (x_check_font): Remove unused local.
2931 * scroll.c (CHECK_BOUNDS):
2932 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2933 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2934 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2935 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2936 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2938 (debug_method_add): Use va_list and vsprintf rather than relying
2939 on undefined behavior with wrong number of arguments.
2940 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2941 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2942 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2943 since we're not interested in debugging glyphs with old libraries.
2944 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2945 GCC 4.6.0's static checking.
2947 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2949 Integer overflow and signedness fixes (Bug#8873).
2950 A few related buffer overrun fixes, too.
2952 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2954 * dispextern.h (struct face.stipple):
2955 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2956 (x_bitmap_mask, x_allocate_bitmap_record)
2957 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2958 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2959 (x_create_bitmap_from_xpm_data):
2960 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2961 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2963 * xfaces.c (load_pixmap):
2964 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2965 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2966 (.bitmaps_last, struct x_output.icon_bitmap):
2967 Use ptrdiff_t, not int, for bitmap indexes.
2968 (x_allocate_bitmap_record): Check for size overflow.
2969 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2971 Use ptrdiff_t, not int, for overlay counts.
2972 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2973 * editfns.c (overlays_around, get_pos_property):
2974 * textprop.c (get_char_property_and_overlay):
2975 * xdisp.c (next_overlay_change, note_mouse_highlight):
2976 * xfaces.c (face_at_buffer_position):
2977 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2978 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2979 (Fnext_overlay_change, Fprevious_overlay_change)
2980 (mouse_face_overlay_overlaps, Foverlays_in):
2981 Use ptrdiff_t, not int, for sizes.
2982 (overlays_at, overlays_in): Check for size-calculation overflow.
2984 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2986 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2987 (x_session_initialize): Do not assume string length fits in int.
2989 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2990 This is unlikely, but can occur if DPI is outlandish.
2992 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2993 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2995 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2996 * xrdb.c (magic_file_p, search_magic_path):
2997 Omit last arg SUFFIX; it was always 0. All callers changed.
2998 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3000 * xfont.c (xfont_match): Avoid need for strlen.
3002 * xfns.c: Don't assume strlen fits in int.
3003 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3005 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3006 not unsigned long, as we prefer signed integers. All callers changed.
3007 Detect integer overflow in repeat count.
3008 (message_dolog): Don't assume print length fits in 39 bytes.
3009 (display_mode_element): Don't assume strlen fits in int.
3011 * termcap.c: Don't assume sizes fit in int and never overflow.
3012 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3013 (gobble_line): Check for size-calculation overflow.
3015 * minibuf.c (Fread_buffer):
3016 * lread.c (intern, intern_c_string):
3017 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3018 Don't assume string length fits in int.
3020 * keyboard.c (parse_tool_bar_item):
3021 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3023 * font.c: Don't assume string length fits in int.
3024 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3025 Use ptrdiff_t, not int.
3026 (font_intern_prop): Don't assume string length fits in int.
3027 Don't assume integer property fits in fixnum.
3028 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3030 * filelock.c: Fix some buffer overrun and integer overflow issues.
3031 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3032 Reformulate so as not to need the command string.
3033 Invoke gzip -cd rather than gunzip, as it's more portable.
3034 (lock_info_type, lock_file_1, lock_file):
3035 Don't assume pid_t and time_t fit in unsigned long.
3036 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3037 (current_lock_owner): Prefer signed type for sizes.
3038 Use memcpy, not strncpy, where memcpy is what is really wanted.
3039 Don't assume (via atoi) that time_t and pid_t fit in int.
3040 Check for time_t and/or pid_t out of range, e.g., via a network share.
3041 Don't alloca where an auto var works fine.
3043 * fileio.c: Fix some integer overflow issues.
3044 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3045 Don't assume string length fits in int.
3046 (directory_file_name): Don't assume string length fits in long.
3047 (make_temp_name): Don't assume pid fits in int, or that its print
3048 length is less than 20.
3050 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3052 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3054 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3056 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3057 We prefer signed integers, even for size calculations.
3059 * emacs.c: Don't assume string length fits in 'int'.
3060 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3061 (main): Don't invoke strlen when not needed.
3063 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3064 (XD_DEBUG_MESSAGE): Don't waste a byte.
3066 * callproc.c (getenv_internal_1, getenv_internal)
3068 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3070 * lread.c (invalid_syntax): Omit length argument.
3071 All uses changed. This doesn't fix a bug, but it simplifies the
3072 code away from its former Hollerith-constant appearance, and it's
3073 one less 'int' to worry about when looking at integer-overflow issues.
3074 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3076 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3077 This didn't break anything, but it didn't help either.
3078 It's confusing to put a bogus integer in a place where the actual
3079 value does not matter.
3080 (LIST_END_P): Remove unused macro and its bogus comment.
3081 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3083 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3084 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3086 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3087 We prefer signed types, and the value cannot exceed the EMACS_INT
3088 range anyway (because otherwise the length would not be representable).
3089 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3090 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3091 This avoids a GCC warning when WIDE_EMACS_INT.
3093 * indent.c (sane_tab_width): New function.
3094 (current_column, scan_for_column, Findent_to, position_indentation)
3095 (compute_motion): Use it. This is just for clarity.
3096 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3098 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3100 * lisp.h (lint_assume): New macro.
3101 * composite.c (composition_gstring_put_cache):
3102 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3104 * editfns.c, insdel.c:
3105 Omit unnecessary forward decls, to simplify future changes.
3107 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3109 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3111 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3112 Use much-faster test for byte-length change.
3113 Don't assume string byte-length fits in 'int'.
3114 Check that character arg fits in 'int'.
3115 (mapcar1): Declare byte as byte, for clarity.
3117 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3119 * fns.c (concat): Catch string overflow earlier.
3120 Do not rely on integer wraparound.
3122 * dispextern.h (struct it.overlay_strings_charpos)
3123 (struct it.selective): Now EMACS_INT, not int.
3124 * xdisp.c (forward_to_next_line_start)
3125 (back_to_previous_visible_line_start)
3126 (reseat_at_next_visible_line_start, next_element_from_buffer):
3127 Don't arbitrarily truncate the value of 'selective' to int.
3129 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3131 * composite.c: Don't truncate sizes to 'int'.
3132 (composition_gstring_p, composition_reseat_it)
3133 (composition_adjust_point): Use EMACS_INT, not int.
3134 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3135 not EMACS_UINT, for indexes.
3137 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3139 * buffer.c: Include <verify.h>.
3140 (struct sortvec.priority, struct sortstr.priority):
3141 Now EMACS_INT, not int.
3142 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3143 (struct sortstr.size, record_overlay_string)
3144 (struct sortstrlist.size, struct sortlist.used):
3145 Don't truncate size to int.
3146 (record_overlay_string): Check for size-calculation overflow.
3147 (init_buffer_once): Check at compile-time, not run-time.
3149 2011-06-22 Jim Meyering <meyering@redhat.com>
3151 Don't leak an XBM-image-sized buffer
3152 * image.c (xbm_load): Free the image buffer after using it.
3154 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3157 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3158 that Sun C diagnosed.
3159 * fns.c (secure_hash): Fix pointer signedness issue.
3160 * intervals.c (static_offset_intervals): New function.
3161 (offset_intervals): Use it.
3163 2011-06-21 Leo Liu <sdl.web@gmail.com>
3166 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3169 * fns.c (secure_hash): Rename from crypto_hash_function and change
3170 the first arg to accept symbols.
3171 (Fsecure_hash): New primitive.
3172 (syms_of_fns): New symbols.
3174 2011-06-20 Deniz Dogan <deniz@dogan.se>
3176 * process.c (Fset_process_buffer): Clarify return value in
3179 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3181 * dispnew.c (add_window_display_history): Use BVAR.
3183 * xdisp.c (debug_method_add): Use BVAR.
3184 (check_window_end, dump_glyph_matrix, dump_glyph)
3185 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3187 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3190 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3191 check till after the cache is created in init_frame_faces.
3193 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3195 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3197 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3199 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3200 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3201 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3203 Improve buffer-overflow checking (Bug#8873).
3204 * fileio.c (Finsert_file_contents):
3205 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3206 Remove the old (too-loose) buffer overflow checks.
3207 They weren't needed, since make_gap checks for buffer overflow.
3208 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3209 The old code merely checked for Emacs fixnum overflow, and relied
3210 on undefined (wraparound) behavior. The new code avoids undefined
3211 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3213 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3214 Tune. Don't use wider integers than needed. Don't use alloca.
3215 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3217 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3219 * insdel.c, lisp.h (buffer_overflow): New function.
3220 (insert_from_buffer_1, replace_range, replace_range_2):
3221 * insdel.c (make_gap_larger):
3222 * editfns.c (Finsert_char):
3223 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3225 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3227 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3229 Integer overflow and signedness fixes (Bug#8873).
3231 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3232 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3234 * fileio.c: Don't assume EMACS_INT fits in off_t.
3235 (emacs_lseek): New static function.
3236 (Finsert_file_contents, Fwrite_region): Use it.
3237 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3239 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3241 * fns.c: Don't overflow int when computing a list length.
3242 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3243 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3244 truncation on 64-bit hosts. Check for QUIT every
3245 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3246 faster and is responsive enough.
3247 (Flength): Report an error instead of overflowing an integer.
3248 (Fsafe_length): Return a float if the value is not representable
3249 as a fixnum. This shouldn't happen except in contrived situations.
3250 (Fnthcdr, Fsort): Don't assume list length fits in int.
3251 (Fcopy_sequence): Don't assume vector length fits in int.
3253 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3254 (header_size, word_size): New constants.
3255 (allocate_vectorlike): Don't check size overflow here.
3256 (allocate_vector): Check it here instead, since this is the only
3257 caller of allocate_vectorlike that could cause overflow.
3258 Check that the new vector's length is representable as a fixnum.
3260 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3261 The previous code was bogus. For example, next_almost_prime (32)
3262 returned 39, which is undesirable as it is a multiple of 3; and
3263 next_almost_prime (24) returned 25, which is a multiple of 5 so
3264 why was the code bothering to check for multiples of 7?
3266 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3268 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3270 Variadic C functions now count arguments with ptrdiff_t.
3271 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3272 Back then I didn't know that the Emacs coding style prefers signed int.
3273 Also, in the meantime I found a few more instances where arguments
3274 were being counted with int, which may truncate counts on 64-bit
3275 machines, or EMACS_INT, which may be unnecessarily wide.
3276 * lisp.h (struct Lisp_Subr.function.aMANY)
3277 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3278 Arg counts are now ptrdiff_t, not size_t.
3279 All variadic functions and their callers changed accordingly.
3280 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3281 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3282 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3283 * callint.c (Fcall_interactively): Check arg count for overflow,
3284 to avoid potential buffer overrun. Use signed char, not 'int',
3285 for 'varies' array, so that we needn't bother to check its size
3286 calculation for overflow.
3287 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3288 * eval.c (apply_lambda):
3289 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3290 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3291 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3293 * callint.c (Fcall_interactively): Don't use index var as event count.
3295 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3296 * mem-limits.h (SIZE): Remove; no longer used.
3298 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3300 Remove unnecessary casts.
3301 * xterm.c (x_term_init):
3302 * xfns.c (x_set_border_pixel):
3303 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3304 These aren't needed now that we assume ANSI C.
3306 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3307 It's more likely to cause problems (due to unsigned overflow)
3310 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3312 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3314 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3316 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3318 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3320 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3322 GLYPH_CODE_FACE returns EMACS_INT, not int.
3323 * dispextern.h (merge_faces):
3324 * xfaces.c (merge_faces):
3325 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3326 Don't assume EMACS_INT fits in int.
3328 * character.h (CHAR_VALID_P): Remove unused parameter.
3329 * fontset.c, lisp.h, xdisp.c: All uses changed.
3331 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3333 * fns.c (concat): Minor tuning based on overflow analysis.
3334 This doesn't fix any bugs. Use int to hold character, instead
3335 of constantly refetching from Emacs object. Use XFASTINT, not
3336 XINT, for value known to be a character. Don't bother comparing
3337 a single byte to 0400, as it's always less.
3339 * floatfns.c (Fexpt):
3340 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3342 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3345 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3347 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3348 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3349 incorrectly succeed when S was a string, because 4294967386 was
3350 truncated before it was used.
3352 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3353 Otherwise, an out-of-range integer could cause undefined behavior
3356 * composite.c: Use int, not EMACS_INT, for characters.
3357 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3358 EMACS_INT, for values that are known to be in character range.
3359 This doesn't fix any bugs but is the usual style inside Emacs and
3360 may generate better code on 32-bit machines.
3362 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3363 This is for reasons similar to the recent CHAR_STRING fix.
3364 * charset.c (Fencode_char): Check that character arg is actually
3365 a character. Pass an int to ENCODE_CHAR.
3366 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3367 wider than 'int', as a compile-time check to prevent future regressions
3370 * character.c (char_string): Remove unnecessary casts.
3372 Make sure a 64-bit char is never passed to CHAR_STRING.
3373 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3374 by silently ignoring the top 32 bits, allowing some values
3375 that were far too large to be valid characters.
3376 * character.h: Include <verify.h>.
3377 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3378 arguments are no wider than unsigned, as a compile-time check
3379 to prevent future regressions in this area.
3381 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3382 (Fsubst_char_in_region):
3384 * xdisp.c (decode_mode_spec_coding):
3385 Adjust to CHAR_STRING's new requirement.
3386 * editfns.c (Finsert_char, Fsubst_char_in_region):
3387 * fns.c (concat): Check that character args are actually
3388 characters. Without this test, these functions did the wrong
3389 thing with wildly out-of-range values on 64-bit hosts.
3391 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3392 These casts should not be needed on 32-bit hosts, either.
3393 * keyboard.c (read_char):
3394 * lread.c (Fload): Remove casts to unsigned.
3396 * lisp.h (UNSIGNED_CMP): New macro.
3397 This fixes comparison bugs on 64-bit hosts.
3398 (ASCII_CHAR_P): Use it.
3399 * casefiddle.c (casify_object):
3400 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3401 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3402 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3403 * dispextern.h (FACE_FROM_ID):
3404 * keyboard.c (read_char): Use UNSIGNED_CMP.
3406 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3407 not to EMACS_INT, to avoid GCC warning.
3409 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3411 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3412 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3413 isn't needed on 32-bit machines.
3415 * buffer.c (Fgenerate_new_buffer_name):
3416 Use EMACS_INT for count, not int.
3417 (advance_to_char_boundary): Return EMACS_INT, not int.
3419 * data.c (Qcompiled_function): Now static.
3421 * window.c (window_body_lines): Now static.
3423 * image.c (gif_load): Rename local to avoid shadowing.
3425 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3426 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3427 * alloc.c (make_save_value): Integer argument is now of type
3429 (mark_object): Use ptrdiff_t, not int.
3430 * lisp.h (pD): New macro.
3431 * print.c (print_object): Use it.
3433 * alloc.c: Use EMACS_INT, not int, to count objects.
3434 (total_conses, total_markers, total_symbols, total_vector_size)
3435 (total_free_conses, total_free_markers, total_free_symbols)
3436 (total_free_floats, total_floats, total_free_intervals)
3437 (total_intervals, total_strings, total_free_strings):
3438 Now EMACS_INT, not int. All uses changed.
3439 (Fgarbage_collect): Compute overall total using a double, so that
3440 integer overflow is less likely to be a problem. Check for overflow
3441 when converting back to an integer.
3442 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3443 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3444 These were 'int' variables that could overflow on 64-bit hosts;
3445 they were never used, so remove them instead of repairing them.
3446 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3447 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3448 Previously, this ceilinged at INT_MAX, but that doesn't work on
3450 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3452 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3453 (allocate_vectorlike): Check for ptrdiff_t overflow.
3454 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3455 when a (possibly-narrower) signed value would do just as well.
3456 We prefer using signed arithmetic, to avoid comparison confusion.
3458 * alloc.c: Catch some string size overflows that we were missing.
3459 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3460 for convenience in STRING_BYTES_MAX.
3461 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3462 The definition here is exact; the one in lisp.h was approximate.
3463 (allocate_string_data): Check for string overflow. This catches
3464 some instances we weren't catching before. Also, it catches
3465 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3466 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3467 and ptrdiff_t and EMACS_INT are both 64 bits.
3469 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3470 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3471 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3473 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3475 * alloc.c (Fmake_string): Check for out-of-range init.
3477 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3479 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3481 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3483 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3484 xg_get_default_scrollbar_width.
3486 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3487 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3488 (style_changed_cb): Call update_theme_scrollbar_width and call
3489 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3490 all frames (Bug#8505).
3491 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3492 Call gtk_window_set_resizable if HAVE_GTK3.
3493 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3494 and height if HAVE_GTK3 (Bug#8505).
3495 (scroll_bar_width_for_theme): New variable.
3496 (update_theme_scrollbar_width): New function.
3497 (xg_get_default_scrollbar_width): Move code to
3498 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3499 (xg_initialize): Call update_theme_scrollbar_width.
3501 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3503 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3505 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3507 * frame.c (make_frame): Call other_buffer_safely instead of
3510 * window.c (temp_output_buffer_show): Call display_buffer with
3511 second argument Vtemp_buffer_show_specifiers and reset latter
3512 immediately after the call.
3513 (Vtemp_buffer_show_specifiers): New variable.
3514 (auto_window_vscroll_p, next_screen_context_lines)
3515 (Vscroll_preserve_screen_position): Remove leading asterisks from
3518 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3520 Fix minor problems found by GCC 4.6.0 static checking.
3521 * buffer.c (Qclone_number): Remove for now, as it's unused.
3522 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3523 (record_buffer): Remove unused local.
3524 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3525 (set_frame_buffer_list): Remove; unused.
3526 * frame.h (other_visible_frames): Remove decl.
3527 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3528 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3529 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3531 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3532 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3533 Define only if HAVE_GPM.
3534 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3535 (update_hints_inhibit): Remove; never set. All uses removed.
3536 * widgetprv.h (emacsFrameClassRec): Remove decl.
3537 * window.c (delete_deletable_window): Now returns void, since it
3538 wasn't returning anything.
3539 (compare_window_configurations): Remove unused locals.
3540 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3541 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3542 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3543 the same widths as pointers. This follows up on the 2011-05-06 patch.
3544 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3545 * xterm.h: Likewise.
3546 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3548 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3550 * makefile.w32-in: Update dependencies.
3551 (LISP_H): Add lib/intprops.h.
3553 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3555 * image.c (gif_load): Add animation frame delay to the metadata.
3556 (syms_of_image): Use DEFSYM. New symbol `delay'.
3558 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3560 * window.c (delete_deletable_window): Re-add.
3561 (Fset_window_configuration): Rewrite to handle dead buffers and
3562 consequently deletable windows.
3563 (window_tree, Fwindow_tree): Remove. Supply functionality in
3565 (compare_window_configurations): Simplify code.
3567 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3569 * image.c (imagemagick_load_image): Fix type mismatch.
3570 (Fimagemagick_types): Likewise.
3572 * window.h (replace_buffer_in_windows): Declare.
3574 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3576 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3577 Qclone_number. Remove external declaration of Qdelete_window.
3578 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3580 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3581 Run Qbuffer_list_update_hook if allowed.
3582 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3583 buffer list implementation.
3584 (other_buffer_safely): New function.
3585 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3586 calls to replace_buffer_in_windows and
3587 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3589 (record_buffer): Inhibit quitting and rewrite using quittable
3590 functions. Run Qbuffer_list_update_hook if allowed.
3591 (Frecord_buffer, Funrecord_buffer): New functions.
3592 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3593 Move switch-to-buffer to window.el.
3594 (bury-buffer): Move to window.el.
3595 (Vbuffer_list_update_hook): New variable.
3597 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3600 * window.h (resize_frame_windows): Move up in code.
3601 (Fwindow_frame): Remove EXFUN.
3602 (replace_buffer_in_all_windows): Remove prototype.
3603 (replace_buffer_in_windows_safely): Add prototype.
3605 * window.c: Declare Qdelete_window static again. Move down
3606 declaration of select_count.
3607 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3608 (Fother_window): Move to window.el.
3609 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3610 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3611 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3613 (replace_buffer_in_windows): Implement by calling
3614 Qreplace_buffer_in_windows.
3615 (replace_buffer_in_all_windows): Remove with some functionality
3616 moved into replace_buffer_in_windows_safely.
3617 (replace_buffer_in_windows_safely): New function.
3618 (select_window_norecord, select_frame_norecord): Move in front
3619 of run_window_configuration_change_hook. Remove now obsolete
3621 (Fset_window_buffer): Rewrite doc-string.
3622 Call Qrecord_window_buffer.
3623 (keys_of_window): Move binding for other-window to window.el.
3625 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3627 * dispextern.h (struct image): Replace data member, whose int_val
3628 and ptr_val fields were not used by anything, with a single
3631 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3632 (gif_clear_image, gif_load, imagemagick_load_image)
3633 (gs_clear_image, gs_load): Callers changed.
3635 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3637 * buffer.h: Include <time.h>, for time_t.
3638 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3640 Fix minor problems found by static checking.
3642 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3644 Make identifiers static if they are not used in other modules.
3645 * data.c (Qcompiled_function, Qframe, Qvector):
3646 * image.c (QimageMagick, Qsvg):
3647 * minibuf.c (Qmetadata):
3648 * window.c (resize_window_check, resize_root_window): Now static.
3649 * window.h (resize_window_check, resize_root_window): Remove decls.
3651 * window.c (window_deletion_count, delete_deletable_window):
3653 (window_body_lines): Now static.
3654 (Fdelete_other_windows_internal): Mark vars as initialized.
3655 Make sure 'resize_failed' is initialized.
3656 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3657 (resize_window_apply): Remove unused local.
3658 * window.h (delete_deletable_window): Remove decl.
3660 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3661 (imagemagick_load_image): Fix pointer signedness problem by changing
3662 last arg from unsigned char * to char *. All uses changed.
3663 Also, fix a local for similar reasons.
3664 Remove unused locals. Remove locals to avoid shadowing.
3665 (fn_rsvg_handle_free): Remove; unused.
3666 (svg_load, svg_load_image): Fix pointer signedness problem.
3667 (imagemagick_load_image): Don't use garbage pointer image_wand.
3669 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3671 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3673 * image.c (gif_load): Fix omitted cast error introduced by
3676 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3678 * window.h (resize_proportionally, orig_total_lines)
3679 (orig_top_line): Remove from window structure.
3680 (set_window_height, set_window_width, change_window_heights)
3681 (Fdelete_window): Remove prototypes.
3682 (resize_frame_windows): Remove duplicate declaration.
3684 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3686 * window.h (resize_frame_windows, resize_window_check)
3687 (delete_deletable_window, resize_root_window)
3688 (resize_frame_windows): Declare prototypes.
3690 * window.c (resize_window_apply): Make definition be "static" to
3691 match the prototype.
3693 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3695 * window.c: Remove declarations of Qwindow_size_fixed,
3696 window_min_size_1, window_min_size_2, window_min_size,
3697 size_window, window_fixed_size_p, enlarge_window, delete_window.
3698 Remove static from declaration of Qdelete_window, it's
3699 temporarily needed by Fbury_buffer.
3700 (replace_window): Don't assign orig_top_line and
3702 (Fdelete_window, delete_window): Remove. Window deletion is
3703 handled by window.el.
3704 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3705 Replace Fdelete_window calls with calls to Qdelete_window.
3706 (Fdelete_other_windows): Remove. Deleting other windows is
3707 handled by window.el.
3708 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3709 handled in window.el.
3710 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3711 Window minimum sizes are handled in window.el.
3712 (shrink_windows, size_window, set_window_height)
3713 (set_window_width, change_window_heights, window_height)
3714 (window_width, CURBEG, CURSIZE, enlarge_window)
3715 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3716 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3717 handled in window.el.
3718 (make_dummy_parent): Rename to make_parent_window and give it a
3719 second argument horflag.
3720 (make_window): Don't set resize_proportionally any more.
3721 (Fsplit_window): Remove. Windows are split in window.el.
3722 (save_restore_action, save_restore_orig_size)
3723 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3724 Resize mini windows in window.el.
3725 (grow_mini_window, shrink_mini_window): Implement by calling
3726 Qresize_root_window_vertically, resize_window_check and
3727 resize_window_apply.
3728 (saved_window, Fset_window_configuration, save_window_save):
3729 Do not handle orig_top_line, orig_total_lines, and
3730 resize_proportionally.
3731 (window_min_height, window_min_width): Move to window.el.
3732 (keys_of_window): Move bindings for delete-other-windows,
3733 split-window, delete-window and enlarge-window to window.el.
3735 * buffer.c: Temporarily extern Qdelete_window.
3736 (Fbury_buffer): Temporarily call Qdelete_window instead of
3737 Fdelete_window (Fbury_buffer will move to window.el soon).
3739 * frame.c (set_menu_bar_lines_1): Remove code handling
3740 orig_top_line and orig_total_lines.
3742 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3743 set_window_height but set heights directly.
3744 (change_frame_size_1): Use resize_frame_windows.
3746 * xdisp.c (init_xdisp): Don't use set_window_height but set
3749 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3750 Use resize_frame_windows instead of change_window_heights and run
3751 run_window_configuration_change_hook.
3753 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3754 instead of change_window_heights and run
3755 run_window_configuration_change_hook.
3757 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3759 * window.c (replace_window): Rename second argument REPLACEMENT to
3760 NEW. New third argument SETFLAG. Rewrite.
3761 (delete_window, make_dummy_parent): Call replace_window with
3763 (window_list_1): Move down in code.
3764 (run_window_configuration_change_hook): Move set_buffer part
3765 before select_frame_norecord part in order to unwind correctly.
3766 Rename count1 to count.
3767 (recombine_windows, delete_deletable_window, resize_root_window)
3768 (Fdelete_other_windows_internal)
3769 (Frun_window_configuration_change_hook, make_parent_window)
3770 (resize_window_check, resize_window_apply, Fresize_window_apply)
3771 (resize_frame_windows, Fsplit_window_internal)
3772 (Fdelete_window_internal, Fresize_mini_window_internal):
3774 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3776 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3778 * window.h (window): Add some new members to window structure -
3779 normal_lines, normal_cols, new_total, new_normal, clone_number,
3780 splits, nest, prev_buffers, next_buffers.
3781 (WINDOW_TOTAL_SIZE): Move here from window.c.
3782 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3784 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3786 (make_dummy_parent): Set new members of windows structure.
3787 (make_window): Move down in code. Handle new members of window
3789 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3790 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3791 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3792 (Fset_window_prev_buffers, Fwindow_next_buffers)
3793 (Fset_window_next_buffers, Fset_window_clone_number):
3795 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3796 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3798 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3799 Argument WINDOW can be now internal window too.
3800 (Fwindow_use_time): Move up in code.
3801 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3803 (Fset_window_configuration, saved_window)
3804 (Fcurrent_window_configuration, save_window_save): Handle new
3805 members of window structure.
3806 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3807 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3808 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3809 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3810 Qget_mru_window, Qresize_root_window,
3811 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3812 Qauto_buffer_name; staticpro them.
3814 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3816 * window.c (Fwindow_total_size, Fwindow_left_column)
3817 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3818 (Fwindow_list_1): New functions.
3819 (window_box_text_cols): Replace with window_body_cols.
3820 (Fwindow_width, Fscroll_left, Fscroll_right):
3821 Use window_body_cols instead of window_box_text_cols.
3822 (delete_window, Fset_window_configuration):
3823 Call delete_all_subwindows with window as argument.
3824 (delete_all_subwindows): Take a window as argument and not a
3826 (window_loop): Remove handling of GET_LRU_WINDOW and
3828 (Fget_lru_window, Fget_largest_window): Move to window.el.
3830 * window.h: Extern window_body_cols instead of
3831 window_box_text_cols. delete_all_subwindows now takes a
3832 Lisp_Object as argument.
3834 * indent.c (compute_motion, Fcompute_motion):
3835 Use window_body_cols instead of window_box_text_cols.
3837 * frame.c (delete_frame): Call delete_all_subwindows with root
3840 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3842 * fns.c (Fputhash): Document return value.
3844 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3846 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3848 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3850 Cons<->int and similar integer overflow fixes (Bug#8794).
3852 Check for overflow when converting integer to cons and back.
3853 * charset.c (Fdefine_charset_internal, Fdecode_char):
3854 Use cons_to_unsigned to catch overflow.
3855 (Fencode_char): Use INTEGER_TO_CONS.
3856 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3857 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3858 * data.c (long_to_cons, cons_to_long): Remove.
3859 (cons_to_unsigned, cons_to_signed): New functions.
3860 These signal an error for invalid or out-of-range values.
3861 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3862 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3863 * font.c (Ffont_variation_glyphs):
3864 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3865 * lisp.h: Include <intprops.h>.
3866 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3867 (cons_to_signed, cons_to_unsigned): New decls.
3868 (long_to_cons, cons_to_long): Remove decls.
3869 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3870 (Fprimitive_undo): Use CONS_TO_INTEGER.
3871 * xfns.c (Fx_window_property): Likewise.
3872 * xselect.c: Include <limits.h>.
3873 (x_own_selection, selection_data_to_lisp_data):
3874 Use INTEGER_TO_CONS.
3875 (x_handle_selection_request, x_handle_selection_clear)
3876 (x_get_foreign_selection, Fx_disown_selection_internal)
3877 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3878 (lisp_data_to_selection_data): Use cons_to_unsigned.
3879 (x_fill_property_data): Use cons_to_signed.
3880 Report values out of range.
3882 Check for buffer and string overflow more precisely.
3883 * buffer.h (BUF_BYTES_MAX): New macro.
3884 * lisp.h (STRING_BYTES_MAX): New macro.
3885 * alloc.c (Fmake_string):
3886 * character.c (string_escape_byte8):
3887 * coding.c (coding_alloc_by_realloc):
3888 * doprnt.c (doprnt):
3889 * editfns.c (Fformat):
3891 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3892 since they may not be the same number.
3893 * editfns.c (Finsert_char):
3894 * fileio.c (Finsert_file_contents):
3895 Likewise for BUF_BYTES_MAX.
3897 * image.c: Use ptrdiff_t, not int, for sizes.
3898 (slurp_file): Switch from int to ptrdiff_t.
3900 (slurp_file): Check that file size fits in both size_t (for
3901 malloc) and ptrdiff_t (for sanity and safety).
3903 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3904 if b->modtime has its maximal value.
3906 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3908 Don't assume time_t can fit into int.
3909 * buffer.h (struct buffer.modtime): Now time_t, not int.
3910 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3911 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3913 Minor fixes for signed vs unsigned integers.
3914 * character.h (MAYBE_UNIFY_CHAR):
3915 * charset.c (maybe_unify_char):
3916 * keyboard.c (read_char, reorder_modifiers):
3917 XINT -> XFASTINT, since the integer must be nonnegative.
3918 * ftfont.c (ftfont_spec_pattern):
3919 * keymap.c (access_keymap, silly_event_symbol_error):
3920 XUINT -> XFASTINT, since the integer must be nonnegative.
3921 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3922 since it makes no difference and we prefer signed.
3923 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3924 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3927 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3929 * window.h (Fwindow_frame): Declare.
3931 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3933 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3934 (SPARE_MEMORY): Always define.
3935 (LARGE_REQUEST): Remove.
3936 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3938 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3940 * lisp.h: Move EXFUNS for Fframe_root_window,
3941 Fframe_first_window and Fset_frame_selected_window to window.h.
3943 * window.h: Move EXFUNS for Fframe_root_window,
3944 Fframe_first_window and Fset_frame_selected_window here from
3947 * frame.c (Fwindow_frame, Fframe_first_window)
3948 (Fframe_root_window, Fframe_selected_window)
3949 (Fset_frame_selected_window): Move to window.c.
3950 (Factive_minibuffer_window): Move to minibuf.c.
3951 (Fother_visible_frames_p): New function.
3953 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3955 * window.c (decode_window, decode_any_window): Move up in code.
3956 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3957 (inhibit_frame_unsplittable): Remove unused variable.
3958 (Fwindow_buffer): Move up and rewrite doc-string.
3959 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3960 (Fwindow_prev): New functions.
3961 (Fwindow_frame): Move here from frame.c. Accept any window as
3963 (Fframe_root_window, Fframe_first_window)
3964 (Fframe_selected_window): Move here from frame.c. Accept frame
3965 or arbitrary window as argument. Update doc-strings.
3966 (Fminibuffer_window): Move up in code.
3967 (Fwindow_minibuffer_p): Move up in code and simplify.
3968 (Fset_frame_selected_window): Move here from frame.c.
3970 (Fselected_window, select_window, Fselect_window): Move up in
3971 code. Minor doc-string fixes.
3973 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3975 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3976 Do not assume that spare memory exists; that assumption is valid
3977 only if SYSTEM_MALLOC.
3978 (LARGE_REQUEST): New macro, so that the issue of large requests
3979 is separated from the issue of spare memory.
3981 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3983 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3986 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3988 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3991 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3993 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3995 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3997 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3998 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4000 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4002 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4004 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4006 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4007 (x_clipboard_manager_save): Add return value.
4008 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4010 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4011 Obey Vx_select_enable_clipboard_manager. Catch errors in
4012 x_clipboard_manager_save (Bug#8779).
4013 (Vx_select_enable_clipboard_manager): New variable.
4014 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4016 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4018 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4020 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4022 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4023 in the current matrix if keep_current_p is non-zero.
4025 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4027 * bidi.c (bidi_level_of_next_char): Fix last change.
4029 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4031 Support bidi reordering of text covered by display properties.
4033 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4034 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4035 (bidi_cache_search, bidi_cache_iterator_state)
4036 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4037 (bidi_level_of_next_char, bidi_move_to_visually_next):
4038 Support character positions inside a run of characters covered by a
4040 (bidi_paragraph_init, bidi_resolve_explicit_1)
4041 (bidi_level_of_next_char): Call bidi_fetch_char and
4042 bidi_fetch_char_advance instead of FETCH_CHAR and
4044 (bidi_init_it): Initialize new members.
4045 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4047 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4048 instead of using explicit *_CHAR codes.
4049 (bidi_resolve_explicit, bidi_resolve_weak):
4050 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4051 bidirectional text is supported only in multibyte buffers.
4052 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4053 it to initialize the frame_window_p member of struct bidi_it.
4054 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4055 (bidi_resolve_explicit, bidi_resolve_weak)
4056 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4057 bidi_it->nchars is non-positive.
4058 (bidi_level_of_next_char): Don't try to lookup the cache for the
4059 next/previous character if nothing is cached there yet, or if we
4060 were just reseat()'ed to a new position.
4062 * xdisp.c (set_cursor_from_row): Set start and stop points
4063 according to the row's direction when priming the loop that looks
4064 for the glyph on which to display cursor.
4065 (single_display_spec_intangible_p): Function deleted.
4066 (display_prop_intangible_p): Reimplement to call
4067 handle_display_spec instead of single_display_spec_intangible_p.
4068 Accept 3 additional arguments needed by handle_display_spec.
4069 This fixes incorrect cursor motion across display property with complex
4070 values: lists, `(when COND...)' forms, etc.
4071 (single_display_spec_string_p): Support property values that are
4072 lists with the argument STRING its top-level element.
4073 (display_prop_string_p): Fix the condition for processing a
4074 property that is a list to be consistent with handle_display_spec.
4075 (handle_display_spec): New function, refactored from the
4076 last portion of handle_display_prop.
4077 (compute_display_string_pos): Accept additional argument
4078 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4079 value of a `display' property is a "replacing spec".
4080 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4081 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4082 the display property, but just return a value indicating whether
4083 the display property will replace the characters it covers.
4084 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4085 frame_window_p members of struct bidi_it.
4086 (compute_display_string_pos, compute_display_string_end):
4088 (push_it): Accept second argument POSITION, where pop_it should
4089 jump to continue iteration.
4090 (reseat_1): Initialize bidi_it.disp_pos.
4092 * keyboard.c (adjust_point_for_property): Adjust the call to
4093 display_prop_intangible_p to its new signature.
4095 * dispextern.h (struct bidi_it): New member frame_window_p.
4096 (bidi_init_it): Update prototypes.
4097 (display_prop_intangible_p): Update prototype.
4098 (compute_display_string_pos, compute_display_string_end):
4100 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4103 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4105 Malloc failure behavior now depends on size of allocation.
4106 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4107 * lisp.h: Change signatures accordingly.
4108 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4109 All callers changed. (Bug#8762)
4111 * gnutls.c: Use Emacs's memory allocators.
4112 Without this change, the gnutls library would invoke malloc etc.
4113 directly, which causes problems on non-SYNC_INPUT hosts, and which
4114 runs afoul of improving memory_full behavior. (Bug#8761)
4115 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4116 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4117 xfree instead of the default malloc, realloc, free.
4118 (Fgnutls_boot): No need to check for memory allocation failure,
4119 since xmalloc does that for us.
4121 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4122 * category.c (hash_get_category_set):
4123 * ccl.c (ccl_driver):
4124 * charset.c (Fdefine_charset_internal):
4125 * charset.h (struct charset.hash_index):
4126 * composite.c (get_composition_id, gstring_lookup_cache)
4127 (composition_gstring_put_cache):
4128 * composite.h (struct composition.hash_index):
4129 * dispextern.h (struct image.hash):
4130 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4131 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4132 (hashfn_equal, hashfn_user_defined, make_hash_table)
4133 (maybe_resize_hash_table, hash_lookup, hash_put)
4134 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4135 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4136 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4137 * image.c (make_image, search_image_cache, lookup_image)
4138 (xpm_put_color_table_h):
4139 * lisp.h (struct Lisp_Hash_Table):
4140 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4141 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4142 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4143 * alloc.c (allocate_vectorlike):
4144 Check for overflow in vector size calculations.
4145 * ccl.c (ccl_driver):
4146 Check for overflow when converting EMACS_INT to int.
4147 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4148 need to be updated by these changes.
4149 * fns.c (make_hash_table, maybe_resize_hash_table):
4150 Check for integer overflow with large hash tables.
4151 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4152 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4153 (SXHASH_REDUCE): New macro.
4154 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4155 Use it instead of discarding useful hash info with large hash values.
4156 (sxhash_float): New function.
4157 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4158 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4159 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4160 Rewrite to use FIXNUM_BITS, as this simplifies things.
4161 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4162 Adjust signatures to match updated version of code.
4163 (consing_since_gc): Now EMACS_INT, since a single hash table can
4164 use more than INT_MAX bytes.
4166 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4168 Make it possible to build with GCC-4.6+ -O2 -flto.
4170 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4172 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4174 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4175 Call minibuffer-inactive-mode.
4177 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4179 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4180 Update dependencies.
4182 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4184 * data.c (init_data): Remove code for UTS, this system is not
4187 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4189 Don't force ./temacs to start in terminal mode.
4191 * frame.c (make_initial_frame): Initialize faces in all cases, not
4192 only when CANNOT_DUMP is defined.
4193 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4195 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4197 * dispnew.c (add_window_display_history): Use const for the string
4198 pointer. Remove declaration, not needed.
4200 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4202 Use 'inline', not 'INLINE'.
4203 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4204 * alloc.c, fontset.c (INLINE): Remove.
4205 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4206 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4207 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4208 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4209 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4211 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4213 Make it possible to run ./temacs.
4215 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4216 syms_of_callproc does the same thing. Remove test for
4217 "initialized", do it in the caller.
4218 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4220 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4222 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4223 (read_minibuf): Use get_minibuffer.
4224 (syms_of_minibuf): Use DEFSYM.
4225 (Qmetadata): New var.
4226 * data.c (Qbuffer): Don't make it static.
4227 (syms_of_data): Use DEFSYM.
4229 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4231 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4232 (CCL_CODE_MIN): New macro.
4234 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4236 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4238 * eval.c (Qdebug): Now static.
4239 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4240 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4241 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4243 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4245 * image.c: Various fixes to ImageMagick code comments.
4246 (Fimagemagick_types): Doc fix.
4248 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4250 Minor fixes prompted by GCC 4.6.0 warnings.
4252 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4254 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4255 (x_clipboard_manager_save_all): Move extern decl to ...
4256 * xterm.h: ... here, so that it can be checked for consistency.
4258 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4260 * xselect.c (x_clipboard_manager_save_frame)
4261 (x_clipboard_manager_save_all): New functions.
4262 (Fx_clipboard_manager_save): Lisp function deleted.
4264 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4265 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4267 * xterm.h: Update prototype.
4269 2011-05-28 William Xu <william.xwl@gmail.com>
4271 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4274 2011-05-28 Jim Meyering <meyering@redhat.com>
4276 Avoid a sign-extension bug in crypto_hash_function.
4277 * fns.c (to_uchar): Define.
4278 (crypto_hash_function): Use it to convert some newly-signed
4279 variables to unsigned, to avoid sign-extension bugs. For example,
4280 without this change, (md5 "truc") would evaluate to
4281 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4282 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4283 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4285 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4287 Integer overflow fixes.
4289 * dbusbind.c: Serial number integer overflow fixes.
4290 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4291 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4292 to hold a serial number that is too large for a fixnum.
4293 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4294 Check for serial numbers out of range. Decode any serial number
4295 that was so large that it became a float. (Bug#8722)
4297 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4298 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4299 Use XFASTINT rather than XUINT when numbers are nonnegative.
4300 (xd_append_arg, Fdbus_method_return_internal):
4301 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4302 arguments, check that Lisp number is nonnegative, rather than
4303 silently wrapping negative numbers around. (Bug#8722)
4304 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4307 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4309 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4311 ccl: add integer overflow checks
4312 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4313 (IN_INT_RANGE): New macros.
4314 (ccl_driver): Use them to check for integer overflow when
4315 decoding a CCL program. Many of the new checks are whether XINT (x)
4316 fits in int; it doesn't always, on 64-bit hosts. The new version
4317 doesn't catch all possible integer overflows, but it's an
4318 improvement. (Bug#8719)
4320 * alloc.c (make_event_array): Use XINT, not XUINT.
4321 There's no need for unsigned here.
4323 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4324 This follows up to the 2011-05-06 change that substituted uintptr_t
4325 for EMACS_INT. This case wasn't caught back then.
4327 Rework Fformat to avoid integer overflow issues.
4328 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4329 now (part of C89). Include <verify.h>.
4330 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4331 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4332 (Fformat): Avoid the prepass trying to compute sizes; it was only
4333 approximate and thus did not catch overflow reliably. Instead, walk
4334 through the format just once, formatting and computing sizes as we go,
4335 checking for integer overflow at every step, and allocating a larger
4336 buffer as needed. Keep track separately whether the format is
4337 multibyte. Keep only the most-recently calculated precision, rather
4338 than them all. Record whether each argument has been converted to
4339 string. Use EMACS_INT, not int, for byte and char and arg counts.
4340 Support field widths and precisions larger than INT_MAX. Avoid
4341 sprintf's undefined behavior with conversion specifications such as %#d
4342 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4343 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4344 formatting out-of-range floating point numbers with int
4347 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4349 * data.c: Avoid integer truncation in expressions involving floats.
4350 * data.c: Include <intprops.h>.
4351 (arith_driver): When there's an integer overflow in an expression
4352 involving floating point, convert the integers to floating point
4353 so that the resulting value does not suffer from catastrophic
4354 integer truncation. For example, on a 64-bit host (* 4
4355 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4356 Do not rely on undefined behavior after integer overflow.
4358 merge count_size_as_multibyte, parse_str_to_multibyte
4359 * character.c, character.h (count_size_as_multibyte):
4360 Rename from parse_str_to_multibyte; all uses changed.
4361 Check for integer overflow.
4362 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4363 since it's now a duplicate of the other. This is more of
4364 a character than a buffer op, so better that it's in character.c.
4365 * fns.c, print.c: Adjust to above changes.
4367 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4369 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4371 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4373 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4374 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4375 (x_clipboard_manager_save): Now static.
4376 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4378 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4379 (crypto_hash_function): Now static.
4380 Fix pointer signedness problems. Avoid unnecessary initializations.
4382 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4384 * termhooks.h (Vselection_alist): Make it terminal-local.
4386 * terminal.c (create_terminal): Initialize it.
4388 * xselect.c: Support for clipboard managers.
4389 (Vselection_alist): Move to termhooks.h as terminal-local var.
4390 (LOCAL_SELECTION): New macro.
4391 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4392 (symbol_to_x_atom): Remove gratuitous arg.
4393 (x_handle_selection_request, lisp_data_to_selection_data)
4394 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4395 (x_own_selection, x_get_local_selection, x_convert_selection):
4396 New arg, specifying work frame. Use terminal-local Vselection_alist.
4397 (some_frame_on_display): Delete unused function.
4398 (Fx_own_selection_internal, Fx_get_selection_internal)
4399 (Fx_disown_selection_internal, Fx_selection_owner_p)
4400 (Fx_selection_exists_p): New optional frame arg.
4401 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4402 (x_handle_selection_clear): Don't treat other terminals with the
4403 same keyboard specially. Use the terminal-local Vselection_alist.
4404 (x_clear_frame_selections): Use Frun_hook_with_args.
4406 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4408 * xterm.h: Add support for those atoms.
4410 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4412 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4413 (converted_selections, conversion_fail_tag): New global variables.
4414 (x_selection_request_lisp_error): Free the above.
4415 (x_get_local_selection): Remove unnecessary code.
4416 (x_reply_selection_request): Args changed; handle arbitrary array
4417 of converted selections stored in converted_selections.
4418 Separate the XChangeProperty and SelectionNotify steps.
4419 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4420 (x_convert_selection): New function.
4421 (x_handle_selection_event): Simplify.
4422 (x_get_foreign_selection): Don't ignore incoming requests while
4423 waiting for an answer; this will fail when we implement
4424 SAVE_TARGETS, and seems unnecessary anyway.
4425 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4426 (Vx_sent_selection_functions): Doc fix.
4428 2011-05-26 Leo Liu <sdl.web@gmail.com>
4430 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4432 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4434 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4436 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4437 for fringe update if it has periodic bitmap.
4438 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4439 and fringe_bitmap_periodic_p.
4441 * fringe.c (get_fringe_bitmap_data): New function.
4442 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4443 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4444 row. Mark glyph row for fringe update if periodicity changed.
4446 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4447 for fringe update unless it has periodic bitmap.
4449 2011-05-25 Kenichi Handa <handa@m17n.org>
4451 * xdisp.c (get_next_display_element): Set correct it->face_id for
4452 a static composition.
4454 2011-05-24 Leo Liu <sdl.web@gmail.com>
4457 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4459 * fns.c (crypto_hash_function, Fsha1): New function.
4460 (Fmd5): Use crypto_hash_function.
4461 (syms_of_fns): Add Ssha1.
4463 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4465 * gnutls.c: Remove unused macros.
4466 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4467 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4468 Remove macros that are defined and never used.
4469 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4471 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4473 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4474 (Fx_get_selection_internal): Minor cleanup.
4475 (Fx_own_selection_internal): Rename arguments for consistency with
4478 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4480 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4482 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4484 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4486 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4488 * dispnew.c (scrolling_window): Don't exclude the case that the
4489 last enabled row in the desired matrix touches the bottom boundary.
4491 2011-05-21 Glenn Morris <rgm@gnu.org>
4493 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4494 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4495 and add some more files.
4497 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4499 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4500 report_file_error introduced by the change from 2011-05-07.
4502 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4504 * systime.h (Time): Define only if emacs is defined.
4505 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4506 where the include path doesn't have X11/X.h by default. See
4507 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4509 2011-05-20 Kenichi Handa <handa@m17n.org>
4511 * composite.c (find_automatic_composition): Fix previous change.
4513 2011-05-20 Glenn Morris <rgm@gnu.org>
4515 * lisp.mk: New file, split from Makefile.in.
4516 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4517 (shortlisp): Remove.
4518 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4520 2011-05-19 Glenn Morris <rgm@gnu.org>
4522 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4523 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4524 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4525 (lisp): Set the order to that of loadup.el.
4526 (shortlisp): Make it a copy of $lisp.
4527 (SOME_MACHINE_LISP): Remove.
4528 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4529 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4531 2011-05-18 Kenichi Handa <handa@m17n.org>
4533 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4534 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4535 (find_automatic_composition): Mostly rewrite for efficiency.
4537 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4539 * makefile.w32-in: Update dependencies.
4541 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4543 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4544 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4546 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4548 Fix some integer overflow issues, such as string length overflow.
4550 * insdel.c (count_size_as_multibyte): Check for string overflow.
4552 * character.c (lisp_string_width): Check for string overflow.
4553 Use EMACS_INT, not int, for string indexes and lengths; in
4554 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4555 the resulting string length overflows an EMACS_INT; instead,
4556 report a string overflow if no precision given. When checking for
4557 precision exhaustion, use a check that cannot possibly have
4558 integer overflow. (Bug#8675)
4559 * character.h (lisp_string_width): Adjust to new signature.
4561 * alloc.c (string_overflow): New function.
4562 (Fmake_string): Use it. This doesn't change behavior, but saves
4563 a few bytes and will simplify future changes.
4564 * character.c (string_escape_byte8): Likewise.
4565 * lisp.h (string_overflow): New decl.
4567 Fixups, following up to the user-interface timestamp change.
4568 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4569 for UI timestamps, instead of unsigned long.
4570 * msdos.c (mouse_get_pos): Likewise.
4571 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4572 * w32gui.h (Time): Define by including "systime.h" rather than by
4573 declaring it ourselves. (Bug#8664)
4575 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4576 * image.c (clear_image_cache): Likewise.
4578 * term.c (term_mouse_position): Don't assume time_t wraparound.
4580 Be more systematic about user-interface timestamps.
4581 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4582 and sometimes 'EMACS_UINT', to represent these timestamps.
4583 This change causes it to use 'Time' uniformly, as that's what X uses.
4584 This makes the code easier to follow, and makes it easier to catch
4585 integer overflow bugs such as Bug#8664.
4586 * frame.c (Fmouse_position, Fmouse_pixel_position):
4587 Use Time, not unsigned long, for user-interface timestamps.
4588 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4589 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4590 * keyboard.h (last_event_timestamp): Likewise.
4591 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4592 * menu.h (xmenu_show): Likewise.
4593 * term.c (term_mouse_position): Likewise.
4594 * termhooks.h (struct input_event.timestamp): Likewise.
4595 (struct terminal.mouse_position_hook): Likewise.
4596 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4597 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4598 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4599 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4601 * menu.h, termhooks.h: Include "systime.h", for Time.
4603 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4604 Don't assume that the difference between two unsigned long values
4605 can fit into an integer. At this point, we know button_down_time
4606 <= event->timestamp, so the difference must be nonnegative, so
4607 there's no need to cast the result if double-click-time is
4608 nonnegative, as it should be; check that it's nonnegative, just in
4609 case. This bug is triggered when events are more than 2**31 ms
4610 apart (about 25 days). (Bug#8664)
4612 * xselect.c (last_event_timestamp): Remove duplicate decl.
4613 (x_own_selection): Remove needless cast to unsigned long.
4615 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4616 that always fit in int. Use a sentinel instead of a counter, to
4617 avoid a temp and to allay GCC's concerns about possible int overflow.
4618 * frame.h (struct frame): Use int for menu_bar_items_used
4619 instead of EMACS_INT, since it always fits in int.
4621 * menu.c (grow_menu_items): Check for int overflow.
4623 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4625 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4626 Before, the code was not consistent. These values cannot exceed
4627 2**31 - 1 so there's no need to make them unsigned.
4628 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4629 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4630 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4632 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4634 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4635 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4636 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4637 presumably because the widths might not match.
4639 * window.c (size_window): Avoid needless test at loop start.
4641 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4643 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4645 2011-05-12 Drew Adams <drew.adams@oracle.com>
4647 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4649 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4651 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4652 `width' to `bar_area_x' and `bar_area_width', respectively.
4653 (x_scroll_run): Take account of fringe background extension.
4655 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4656 Rename local vars `left' and `width' to `bar_area_x' and
4657 `bar_area_width', respectively.
4658 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4659 background extension.
4661 2011-05-10 Jim Meyering <meyering@redhat.com>
4663 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4665 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4667 * image.c (Finit_image_library): Return t for built-in image types,
4668 like pbm and xbm. (Bug#8640)
4670 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4672 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4674 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4676 * w32console.c (Fset_screen_color): Doc fix.
4677 (Fget_screen_color): New function.
4678 (syms_of_ntterm): Defsubr it.
4680 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4681 unlink the temporary file if Fcall_process didn't create it in the
4683 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4684 child process will be redirected to a file specified with `:file'.
4685 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4686 cue to call_process_cleanup not to close that handle.
4688 2011-05-07 Ben Key <bkey76@gmail.com>
4690 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4691 one of two shell specific rules, either bootstrap-temacs-CMD or
4692 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4693 to the previous implementation of the bootstrap-temacs rule.
4694 The bootstrap-temacs-CMD rule is similar to the previous
4695 implementation of the bootstrap-temacs rule except that it
4696 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4699 These changes, along with some changes to nt/configure.bat,
4700 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4701 earlier fix to add support for --cflags and --ldflags options
4702 that include quotes so that it works whether make uses cmd or
4705 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4707 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4708 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4710 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4711 a string. Handle both cases.
4712 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4713 (Fdbus_register_method): Use Qinvalid_function.
4715 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4717 * makefile.w32-in: Update dependencies.
4718 (LISP_H): Add inttypes.h and stdin.h.
4719 (PROCESS_H): Add unistd.h.
4721 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4723 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4724 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4726 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4728 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4730 * term.c (vfatal): Remove stray call to va_end.
4731 It's not needed and the C Standard doesn't allow it here anyway.
4733 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4734 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4736 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4739 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4743 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4745 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4747 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4749 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4750 * charset.c (Fdefine_charset_internal): Don't initialize
4751 charset.code_space[15]. The value was garbage, on hosts with
4752 32-bit int (Bug#8600).
4754 * lread.c (read_integer): Be more consistent with string-to-number.
4755 Use string_to_number to do the actual conversion; this avoids
4756 rounding errors and fixes some other screwups. Without this fix,
4757 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4758 (digit_to_number): Move earlier, for benefit of read_integer.
4759 Return -1 if the digit is out of range for the base, -2 if it is
4760 not a digit in any supported base. (Bug#8602)
4762 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4764 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4765 to match comment at start of function. This also removes a
4766 GCC warning about overflow in a 32+64-bit port.
4768 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4770 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4771 Reported by Stefan Monnier in
4772 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4774 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4776 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4777 (EMACS_UINTPTR): Likewise, with uintptr_t.
4779 * lisp.h: Prefer 64-bit EMACS_INT if available.
4780 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4781 on 32-bit hosts that have 64-bit int, so that they can access
4783 However, temporarily disable this change unless the temporary
4784 symbol WIDE_EMACS_INT is defined.
4786 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4788 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4789 This removes an assumption that EMACS_INT and long are the same
4790 width as pointers. The assumption is true for Emacs porting targets
4791 now, but we want to make other targets possible.
4792 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4793 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4794 In the rest of the code, change types of integers that hold casted
4795 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4796 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4797 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4798 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4799 No need to cast type when ORing.
4800 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4801 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4802 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4803 assume EMACS_INT is the same width as char *.
4804 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4805 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4806 Remove no-longer-needed casts.
4807 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4808 (xg_tool_bar_help_callback, xg_make_tool_item):
4809 Use EMACS_INTPTR to hold an integer
4810 that will be cast to void *; this can avoid a GCC warning
4811 if EMACS_INT is not the same width as void *.
4812 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4813 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4814 (current_message_1, set_message_1):
4815 Use a local to convert to proper width without a cast.
4816 * xmenu.c (dialog_selection_callback): Likewise.
4818 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4819 Also, don't assume VALBITS / RAND_BITS is less than 5,
4820 and don't rely on undefined behavior when shifting a 1 left into
4822 * lisp.h (get_random): Change signature to match.
4824 * lread.c (hash_string): Use size_t, not int, for hash computation.
4825 Normally we prefer signed values; but hashing is special, because
4826 it's better to use unsigned division on hash table sizes so that
4827 the remainder is nonnegative. Also, size_t is the natural width
4828 for hashing into memory. The previous code used 'int', which doesn't
4829 retain enough info to hash well into very large tables.
4830 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4832 * dbusbind.c: Don't possibly lose pointer info when converting.
4833 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4834 Use XPNTR rather than XHASH, so that the high-order bits of
4835 the pointer aren't lost when converting through void *.
4837 * eval.c (Fautoload): Don't double-shift a pointer.
4839 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4841 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4843 * gnutls.c (DEF_GNUTLS_FN):
4844 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4846 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4848 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4851 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4853 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4854 New version that can reserve upto 2GB of heap space.
4856 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4858 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4860 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4862 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4863 `gnutls_certificate_set_x509_key_file'.
4865 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4867 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4868 Update dependencies.
4870 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4872 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4873 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4874 Remove unused parameter `fildes'.
4875 * process.c (read_process_output, send_process): Don't pass it.
4877 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4879 Fix previous change: the library cache is defined in w32.c.
4880 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4881 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4883 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4885 Implement dynamic loading of GnuTLS on Windows.
4887 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4888 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4892 * gnutls.c (Qgnutls_dll): Define.
4893 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4894 (gnutls_*): Declare function pointers.
4895 (init_gnutls_functions): New function to initialize function pointers.
4896 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4897 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4898 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4899 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4900 (emacs_gnutls_write, emacs_gnutls_read)
4901 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4902 (Fgnutls_available_p): New function.
4903 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4904 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4905 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4907 * image.c: Include w32.h.
4908 (Vimage_type_cache): Delete.
4909 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4910 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4911 (w32_delayed_load): Move to w32.c.
4913 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4915 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4916 (w32_delayed_load): Move from image.c. When loading a library, record
4917 its filename in the :loaded-from property of the library id.
4918 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4919 Initialize and staticpro them.
4920 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4922 * process.c: Include lisp.h before w32.h, not after.
4923 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4924 instead of gnutls_record_check_pending.
4926 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4928 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4930 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4931 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4934 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4936 * xterm.c (x_set_frame_alpha): Do not set property on anything
4937 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4939 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4941 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4943 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4945 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4946 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4947 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4948 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4949 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4950 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4951 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4952 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4953 (Qgnutls_bootprop_callbacks_verify): Make static.
4955 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4957 * callproc.c: Indentation fixup.
4959 * sysdep.c (wait_for_termination_1): Make static.
4960 (wait_for_termination, interruptible_wait_for_termination):
4961 Move after wait_for_termination_1.
4963 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4965 * sysdep.c (interruptible_wait_for_termination): New function
4966 which is like wait_for_termination, but allows keyboard
4969 * callproc.c (Fcall_process): Add (:file "file") as an option for
4971 (Fcall_process_region): Ditto.
4973 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4975 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4976 rather than `XVECTOR (FOO)->size'.
4978 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4979 inttypes.h, as a gnulib replacement is used if it not available in
4982 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4984 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4985 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4986 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4988 * coding.c (coding_alloc_by_realloc): Error out if destination
4989 will grow beyond MOST_POSITIVE_FIXNUM.
4990 (decode_coding_emacs_mule): Abort if there isn't enough place in
4991 charbuf for the composition carryover bytes. Reserve an extra
4992 space for up to 2 characters produced in a loop.
4993 (decode_coding_iso_2022): Abort if there isn't enough place in
4994 charbuf for the composition carryover bytes.
4996 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4998 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4999 aborting when %lld or %lll format is passed.
5000 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5001 %llo or %llx format is passed. (Bug#8545)
5003 * window.c (window_scroll_line_based): Use a marker instead of
5004 simple variables to record original value of point. (Bug#7952)
5006 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5007 produced by %s or %c overflows available buffer space. (Bug#8545)
5009 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5011 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5012 (SIZE_MAX): Move defn after all includes, as they might #define it.
5014 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5016 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5018 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5020 * keyboard.c (Qdelayed_warnings_hook): Define.
5021 (command_loop_1): Run `delayed-warnings-hook'
5022 if Vdelayed_warnings_list is non-nil.
5023 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5024 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5026 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5028 * doprnt.c (doprnt): Don't return value smaller than the buffer
5029 size if the message was truncated. (Bug#8545).
5031 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5033 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5034 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5036 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5038 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5040 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5042 * makefile.w32-in: Update dependencies.
5044 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5046 Improve `doprnt' and its usage. (Bug#8545)
5047 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5048 `format_end'. Remove support for %l as a conversion specifier.
5049 Don't use xrealloc. Improve diagnostics when the %l size modifier
5050 is used. Update the commentary.
5052 * eval.c (verror): Simplify calculation of size_t.
5054 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5057 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5059 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5062 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5064 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5065 This makes this file independent of the recent pseudovector change.
5067 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5069 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5071 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5072 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5073 Remove unused local.
5074 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5076 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5077 GCC 4.6.0 optimizes based on type-based alias analysis.
5078 For example, if b is of type struct buffer * and v of type struct
5079 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5080 != &v->size, and therefore "v->size = 1; b->size = 2; return
5081 v->size;" must therefore return 1. This assumption is incorrect
5082 for Emacs, since it type-puns struct Lisp_Vector * with many other
5083 types. To fix this problem, this patch adds a new type struct
5084 vectorlike_header that documents the constraints on layout of vectors
5085 and pseudovectors, and helps optimizing compilers not get fooled
5086 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5087 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5088 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5090 (XSETPVECTYPE): Rewrite in terms of new macro.
5091 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5092 This is a bit clearer, and further avoids the possibility of
5093 undesirable aliasing.
5094 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5095 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5096 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5097 since Lisp_Subr is a special case (no "next" field).
5098 (ASIZE): Now uses header.size rather than size.
5099 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5100 to avoid the hassle of writing XVECTOR (foo)->header.size.
5101 (struct vectorlike_header): New type.
5102 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5103 object, to help avoid aliasing.
5104 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5105 (SUBRP): Likewise, since Lisp_Subr is a special case.
5106 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5107 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5108 (struct Lisp_Hash_Table): Combine first two members into a single
5109 struct vectorlike_header member. All uses of "size" and "next" members
5110 changed to be "header.size" and "header.next".
5111 * buffer.h (struct buffer): Likewise.
5112 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5113 * frame.h (struct frame): Likewise.
5114 * process.h (struct Lisp_Process): Likewise.
5115 * termhooks.h (struct terminal): Likewise.
5116 * window.c (struct save_window_data, struct saved_window): Likewise.
5117 * window.h (struct window): Likewise.
5118 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5119 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5120 * buffer.c (init_buffer_once): Likewise.
5121 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5123 * process.c (Fformat_network_address): Use local var for size,
5126 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5128 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5129 * data.c (atof): Remove decl; no longer used or needed.
5130 (digit_to_number): Move to lread.c.
5131 (Fstring_to_number): Use new string_to_number function, to be
5132 consistent with how the Lisp reader treats infinities and NaNs.
5133 Do not assume that floating-point numbers represent EMACS_INT
5134 without losing information; this is not true on most 64-bit hosts.
5135 Avoid double-rounding errors, by insisting on integers when
5136 parsing non-base-10 numbers, as the documentation specifies.
5137 * lisp.h (string_to_number): New decl, replacing ...
5138 (isfloat_string): Remove.
5139 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5140 (read1): Do not accept +. and -. as integers; this
5141 appears to have been a coding error. Similarly, do not accept
5142 strings like +-1e0 as floating point numbers. Do not report
5143 overflow for integer overflows unless the base is not 10 which
5144 means we have no simple and reliable way to continue.
5145 Break out the floating-point parsing into a new
5146 function string_to_number, so that Fstring_to_number parses
5147 floating point numbers consistently with the Lisp reader.
5148 (digit_to_number): Move here from data.c. Make it static inline.
5149 (E_CHAR, EXP_INT): Remove, replacing with ...
5150 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5151 (string_to_number): New function, replacing isfloat_string.
5152 This function checks for valid syntax and produces the resulting
5153 Lisp float number too. Rework it so that string-to-number
5154 no longer mishandles examples like "1.0e+". Use strtoumax,
5155 so that overflow for non-base-10 numbers is reported only when
5156 there's no portable and simple way to convert to floating point.
5158 * textprop.c (set_text_properties_1): Rewrite for clarity,
5159 and to avoid GCC warning about integer overflow.
5161 * intervals.h (struct interval): Use EMACS_INT for members
5162 where EMACS_UINT might cause problems. See
5163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5164 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5165 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5167 (offset_intervals): Tell GCC not to worry about length overflow
5168 when negating a negative length.
5170 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5171 (overrun_check_free): Likewise.
5173 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5174 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5177 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5178 (gnutls_make_error): Rename local to avoid shadowing.
5179 (gnutls_emacs_global_deinit): ifdef out; not used.
5180 (Fgnutls_boot): Use const for pointer to readonly storage.
5181 Comment out unused local. Fix pointer signedness problems.
5183 * lread.c (openp): Don't stuff size_t into an 'int'.
5184 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5185 about possible signed overflow.
5187 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5188 (GDK_KEY_g): Don't define if already defined.
5189 (xg_prepare_tooltip): Avoid pointer signedness problem.
5190 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5192 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5193 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5195 * xfns.c (Fx_window_property): Simplify a bit,
5196 to make a bit faster and to avoid GCC 4.6.0 warning.
5197 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5199 * fns.c (internal_equal): Don't assume size_t fits in int.
5201 * alloc.c (compact_small_strings): Tighten assertion a little.
5203 Replace pEd with more-general pI, and fix some printf arg casts.
5204 * lisp.h (pI): New macro, generalizing old pEd macro to other
5205 conversion specifiers. For example, use "...%"pI"d..." rather
5206 than "...%"pEd"...".
5207 (pEd): Remove. All uses replaced with similar uses of pI.
5208 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5209 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5210 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5211 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5212 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5213 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5214 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5216 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5217 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5218 * print.c (safe_debug_print, print_object): Likewise.
5219 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5221 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5222 avoiding the 0 flag, which is not portable.
5223 * process.c (Fmake_network_process): Use pI to avoid cast.
5224 * region-cache.c (pp_cache): Likewise.
5225 * xdisp.c (decode_mode_spec): Likewise.
5226 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5227 behavior on 64-bit hosts with printf arg.
5228 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5229 (x_stop_queuing_selection_requests): Likewise.
5230 (x_get_window_property): Don't truncate byte count to an 'int'
5233 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5234 here, since it parses constructs like leading '-' and spaces,
5235 which are not wanted; and it overflows with large numbers.
5236 Instead, simply match F[0-9]+, which is what is wanted anyway.
5238 * alloc.c: Remove unportable assumptions about struct layout.
5239 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5240 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5241 (allocate_vectorlike, make_pure_vector): Use the new macros,
5242 plus offsetof, to remove unportable assumptions about struct layout.
5243 These assumptions hold on all porting targets that I know of, but
5244 they are not guaranteed, they're easy to remove, and removing them
5245 makes further changes easier.
5247 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5248 This doesn't fix a bug but makes the code clearer.
5249 (string_overrun_cookie): Now const. Use initializers that
5250 don't formally overflow signed char, to avoid warnings.
5251 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5252 can cause Emacs to crash when string overrun checking is enabled.
5253 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5254 multiple of sizeof (EMACS_INT); it need not be, if
5255 alignof(EMACS_INT) < sizeof (EMACS_INT).
5256 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5258 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5260 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5262 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5264 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5265 supposed to be handshaking. (Bug#8556)
5266 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5268 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5270 * lisp.h (Qdebug): List symbol.
5271 * eval.c (Qdebug): Restore global linkage.
5272 * keyboard.c (debug-on-event): New variable.
5273 (handle_user_signal): Break into debugger when debug-on-event
5274 matches the current signal symbol.
5276 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5278 * alloc.c (check_sblock, check_string_bytes)
5279 (check_string_free_list): Convert to standard C.
5281 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5283 * w32.c (emacs_gnutls_push): Fix typo.
5285 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5287 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5288 "cast to pointer from integer of different size".
5290 Improve doprnt and its use in verror. (Bug#8545)
5291 * doprnt.c (doprnt): Document the set of format control sequences
5292 supported by the function. Use SAFE_ALLOCA instead of always
5295 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5296 is one byte too soon. Don't use xrealloc; instead xfree and
5299 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5301 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5304 * gnutls.c: Renamed global_initialized to
5305 gnutls_global_initialized. Added internals for the
5306 :verify-hostname-error, :verify-error, and :verify-flags
5307 parameters of `gnutls-boot' and documented those parameters in the
5308 docstring. Start callback support.
5309 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5310 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5311 on error. Return error code.
5312 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5313 (emacs_gnutls_read): Likewise.
5314 (Fgnutls_boot): Return handshake error code.
5315 (emacs_gnutls_handle_error): New function.
5316 (wsaerror_to_errno): Likewise.
5318 * w32.h (emacs_gnutls_pull): Add prototype.
5319 (emacs_gnutls_push): Likewise.
5321 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5322 (emacs_gnutls_push): Likewise.
5324 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5326 * process.c (wait_reading_process_output): Check if GnuTLS
5327 buffered some data internally if no FDs are set for TLS
5330 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5331 (LIBS): Link to USER_LIBS.
5332 ($(BLD)/gnutls.$(0)): New target.
5334 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5336 * xdisp.c (handle_single_display_spec): Rename the
5337 display_replaced_before_p argument into display_replaced_p, to
5338 make it consistent with the commentary. Fix typos in the
5341 * textprop.c (syms_of_textprop): Remove dead code.
5342 (copy_text_properties): Delete obsolete commentary about an
5343 interface that was deleted long ago. Fix typos in the description
5346 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5347 to changes in oldXMenu/XMenu.h from 2011-04-16.
5348 <menu_help_message, prev_menu_help_message>: Constify.
5349 (IT_menu_make_room): menu->help_text is now `const char **';
5352 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5353 to changes in oldXMenu/XMenu.h from 2011-04-16.
5354 (struct XMenu): Declare `help_text' `const char **'.
5356 * xfaces.c <Qunspecified>: Make extern again.
5358 * syntax.c: Include sys/types.h before including regex.h, as
5361 * doc.c (get_doc_string): Improve the format passed to `error'.
5363 * doprnt.c (doprnt): Improve commentary.
5365 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5367 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5370 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5371 changes in globals.h immediately force recompilation.
5372 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5373 $(CURDIR)/s/ms-w32.h.
5374 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5376 * character.c (Fchar_direction): Function deleted.
5377 (syms_of_character): Don't defsubr it.
5378 <char-direction-table>: Deleted.
5380 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5382 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5383 * doprnt.c: Include limits.h.
5384 (SIZE_MAX): New macro.
5385 (doprnt): Return a size_t value. 2nd arg is now size_t.
5386 Many local variables are now size_t instead of int or unsigned.
5387 Improve overflow protection. Support `l' modifier for integer
5388 conversions. Support %l conversion. Don't assume an EMACS_INT
5389 argument for integer conversions and for %c.
5391 * lisp.h (doprnt): Restore prototype.
5393 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5396 * Makefile.in (base_obj): Add back doprnt.o.
5398 * deps.mk (doprnt.o): Add back prerequisites.
5399 (callint.o): Depend on character.h.
5401 * eval.c (internal_lisp_condition_case): Include the handler
5402 representation in the error message.
5403 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5404 when breaking from the loop.
5406 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5408 * callint.c (Fcall_interactively): When displaying error message
5409 about invalid control letter, pass the character's codepoint, not
5410 a pointer to its multibyte form. Improve display of the character
5411 in octal and display also its hex code.
5413 * character.c (char_string): Use %x to display the (unsigned)
5414 codepoint of an invalid character, to avoid displaying a bogus
5417 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5418 `error', not SYMBOL_NAME itself.
5420 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5421 character arguments to `error'.
5423 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5424 to `error' in error message about FINAL_CHAR argument. Make sure
5425 FINAL_CHAR is a character, and use %c when it is passed as
5426 argument to `error'.
5428 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5430 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5432 * w32.c: Include <time.h>.
5433 (sys_localtime): New function.
5435 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5437 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5439 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5441 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5443 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5446 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5448 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5449 gl_state.e_property when gl_state.object is Qt.
5451 * insdel.c (make_gap_larger): Remove limitation of buffer size
5454 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5456 * xdisp.c (lookup_glyphless_char_display)
5457 (produce_glyphless_glyph): Handle cons cell entry in
5458 glyphless-char-display.
5459 (Vglyphless_char_display): Document it.
5461 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5462 glyphless-char-display.
5464 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5466 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5468 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5471 definition for no-X builds.
5473 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5475 Static checks with GCC 4.6.0 and non-default toolkits.
5477 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5479 * process.c (keyboard_bit_set): Define only if SIGIO.
5480 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5481 (send_process): Repair possible setjmp clobbering.
5483 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5485 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5487 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5489 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5490 Define only if needed.
5492 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5493 by pacifying GCC about it. Maybe it's time to retire it?
5494 * xfaces.c (USG, __TIMEVAL__): Likewise.
5496 * dispextern.h (struct redisplay_interface): Rename param
5498 * termhooks.h (struct terminal): Likewise.
5499 * xterm.c (xembed_send_message): Likewise.
5501 * insdel.c (make_gap_smaller): Define only if
5502 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5504 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5507 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5508 so that we aren't warned about unused symbols.
5510 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5512 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5514 * xfns.c (x_real_positions): Mark locals as initialized.
5516 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5518 * xterm.c: Fix problems found by static analysis with other toolkits.
5519 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5520 (x_dispatch_event): Declare static if USE_GTK, and
5521 define if USE_GTK || USE_X_TOOLKIT.
5522 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5523 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5524 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5525 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5527 * xmenu.c (menu_help_callback): Pointer type fixes.
5528 Use const pointers when pointing at readonly data. Avoid pointer
5530 (FALSE): Remove unused macro.
5531 (update_frame_menubar): Remove unused decl.
5533 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5535 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5536 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5537 (single_menu_item): Rename local to avoid shadowing.
5539 * keyboard.c (make_lispy_event): Remove unused local var.
5541 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5542 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5544 * bitmaps: Change bitmaps from unsigned char back to the X11
5545 compatible char. Avoid the old compiler warnings about
5546 out-of-range initializers by using, for example, '\xab' rather
5549 * xgselect.c (xgselect_initialize): Check vs interface
5550 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5552 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5554 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5555 to read-only memory.
5557 * fns.c (vector): Remove; this old hack is no longer needed.
5559 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5561 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5563 * xrdb.c (x_load_resources): Omit unused local.
5565 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5566 (x_window): Rename locals to avoid shadowing.
5567 (USG): Use the kludged USG macro, to pacify gcc.
5569 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5570 (x_term_init): Remove local to avoid shadowing.
5572 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5574 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5575 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5577 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5579 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5581 Fix regex.c, syntax.c and friends for buffers > 2GB.
5582 * syntax.h (struct gl_state_s): Declare character position members
5585 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5587 * textprop.c (verify_interval_modification, interval_of):
5588 Declare arguments EMACS_INT.
5590 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5593 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5595 * indent.c (Fvertical_motion): Local variable it_start is now
5598 * regex.c (re_match, re_match_2, re_match_2_internal)
5599 (bcmp_translate, regcomp, regexec, print_double_string)
5600 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5601 (re_compile_pattern, re_exec): Declare arguments and local
5602 variables `size_t' and `ssize_t' and return values `regoff_t', as
5604 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5605 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5606 <compile_stack_type>: `size' and `avail' are now `size_t'.
5608 * regex.h <regoff_t>: Use ssize_t, not int.
5609 (re_search, re_search_2, re_match, re_match_2): Arguments that
5610 specify buffer/string position and length are now ssize_t and
5611 size_t. Return type is regoff_t.
5613 2011-04-16 Ben Key <bkey76@gmail.com>
5615 * nsfont.m: Fixed bugs in ns_get_family and
5616 ns_descriptor_to_entity that were caused by using free to
5617 deallocate memory blocks that were allocated by xmalloc (via
5618 xstrdup). This caused Emacs to crash when compiled with
5619 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5620 --enable-checking=xmallocoverrun). xfree is now used to
5621 deallocate these memory blocks.
5623 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5625 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5627 emacs_write: Accept and return EMACS_INT for sizes.
5628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5630 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5631 Accept and return EMACS_INT.
5632 (emacs_gnutls_write): Return the number of bytes written on
5634 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5635 (emacs_read, emacs_write): Remove check for negative size, as the
5636 Emacs source code has been audited now.
5637 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5638 (emacs_read, emacs_write): Use it.
5639 * process.c (send_process): Adjust to the new signatures of
5640 emacs_write and emacs_gnutls_write. Do not attempt to store
5641 a byte offset into an 'int'; it might overflow.
5642 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5644 * sound.c: Don't assume sizes fit in 'int'.
5645 (struct sound_device.period_size, alsa_period_size):
5646 Return EMACS_INT, not int.
5647 (struct sound_device.write, vox_write, alsa_write):
5648 Accept EMACS_INT, not int.
5649 (wav_play, au_play): Use EMACS_INT to store sizes and to
5650 record read return values.
5652 2011-04-15 Ben Key <bkey76@gmail.com>
5654 * keyboard.c (Qundefined): Don't declare static since it is used
5656 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5657 static since they are used in nsfont.m.
5659 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5661 * process.c (Qprocessp): Don't declare static.
5662 * lisp.h (Qprocessp): Declare again.
5664 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5666 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5668 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5670 Improve C-level modularity by making more things 'static'.
5672 Don't publish debugger-only interfaces to other modules.
5673 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5674 (verify_bytepos, count_markers): Move decls to the only modules
5676 * region-cache.h (pp_cache): Likewise.
5677 * window.h (check_all_windows): Likewise.
5678 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5680 * sysdep.c (croak): Now static, if
5681 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5682 * syssignal.h (croak): Declare only if not static.
5684 * alloc.c (refill_memory_reserve): Now static if
5685 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5686 * lisp.h (refill_memory_reserve): Declare only if not static.
5688 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5689 Define only if USE_LUCID.
5691 * xrdb.c (x_customization_string, x_rm_string): Now static.
5693 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5694 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5696 * xdisp.c (draw_row_with_mouse_face): Now static.
5697 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5699 * window.h (check_all_windows): Mark externally visible.
5701 * window.c (window_deletion_count): Now static.
5703 * undo.c: Make symbols static if they're not exported.
5704 (last_undo_buffer, last_boundary_position, pending_boundary):
5707 * textprop.c (interval_insert_behind_hooks): Now static.
5708 (interval_insert_in_front_hooks): Likewise.
5710 * term.c: Make symbols static if they're not exported.
5711 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5712 (max_frame_lines, tty_set_terminal_modes):
5713 (tty_reset_terminal_modes, tty_turn_off_highlight):
5714 (get_tty_terminal): Now static.
5715 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5716 * termhooks.h (term_mouse_moveto): Do not declare if
5718 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5719 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5721 * sysdep.c: Make symbols static if they're not exported.
5722 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5724 (sigprocmask_set, full_mask): Remove; unused.
5725 (wait_debugging): Mark as visible.
5726 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5727 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5729 * syntax.c (syntax_temp): Define only if !__GNUC__.
5731 * sound.c (current_sound_device, current_sound): Now static.
5733 * search.c (searchbufs, searchbuf_head): Now static.
5735 * scroll.c (scroll_cost): Remove; unused.
5736 * dispextern.h (scroll_cost): Remove decl.
5738 * region-cache.h (pp_cache): Mark as externally visible.
5740 * process.c: Make symbols static if they're not exported.
5741 (process_tick, update_tick, create_process, chan_process):
5742 (Vprocess_alist, proc_buffered_char, datagram_access):
5743 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5744 (deactivate_process): Mark defn as static, as well as decl.
5745 * lisp.h (create_process): Remove decl.
5746 * process.h (chan_process, Vprocess_alist): Remove decls.
5748 * print.c: Make symbols static if they're not exported.
5749 (print_depth, new_backquote_output, being_printed, print_buffer):
5750 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5751 (print_interval, print_number_index, initial_stderr_stream):
5753 * lisp.h (Fprinc): Remove decl.
5754 (debug_output_compilation_hack): Mark as externally visible.
5756 * sysdep.c (croak): Move decl from here to syssignal.h.
5757 * syssignal.h (croak): Put it here, so the API can be checked when
5758 'croak' is called from dissociate_if_controlling_tty.
5760 * minibuf.c: Make symbols static if they're not exported.
5761 (minibuf_save_list, choose_minibuf_frame): Now static.
5762 * lisp.h (choose_minibuf_frame): Remove decl.
5764 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5766 * lread.c: Make symbols static if they're not exported.
5767 (read_objects, initial_obarray, oblookup_last_bucket_number):
5769 (make_symbol): Remove; unused.
5770 * lisp.h (initial_obarray, make_symbol): Remove decls.
5772 * keyboard.c: Make symbols static if they're not exported.
5773 (single_kboard, recent_keys_index, total_keys, recent_keys):
5774 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5775 (this_single_command_key_start, echoing, last_auto_save):
5776 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5777 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5778 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5779 (Vlispy_mouse_stem, double_click_count):
5781 (force_auto_save_soon): Define only if SIGDANGER.
5782 (ignore_mouse_drag_p): Now static if
5783 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5784 (print_help): Remove; unused.
5785 (stop_character, last_timer_event): Mark as externally visible.
5786 * keyboard.h (ignore_mouse_drag_p): Declare only if
5787 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5788 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5789 * lisp.h (echoing): Remove decl.
5790 (force_auto_save_soon): Declare only if SIGDANGER.
5791 * xdisp.c (redisplay_window): Simplify code, to make it more
5792 obvious that ignore_mouse_drag_p is not accessed if !defined
5793 USE_GTK && !defined HAVE_NS.
5795 * intervals.c: Make symbols static if they're not exported.
5796 (merge_properties_sticky, merge_interval_right, delete_interval):
5798 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5800 * insdel.c: Make symbols static if they're not exported.
5801 However, leave prepare_to_modify_buffer alone. It's never
5802 called from outside this function, but that appears to be a bug.
5803 (combine_after_change_list, combine_after_change_buffer):
5804 (adjust_after_replace, signal_before_change): Now static.
5805 (adjust_after_replace_noundo): Remove; unused.
5806 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5807 (signal_before_change): Remove decls.
5809 * indent.c (val_compute_motion, val_vmotion): Now static.
5811 * image.c: Make symbols static if they're not exported.
5812 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5814 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5815 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5817 * fringe.c (standard_bitmaps): Now static.
5818 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5820 * frame.c: Make symbols static if they're not exported.
5821 (x_report_frame_params, make_terminal_frame): Now static.
5822 (get_frame_param): Now static, unless HAVE_NS.
5823 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5824 (x_get_resource_string): Remove; not used.
5825 * frame.h (make_terminal_frame, x_report_frame_params):
5826 (x_get_resource_string); Remove decls.
5827 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5828 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5830 * font.c, fontset.c: Make symbols static if they're not exported.
5831 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5832 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5833 * font.c (font_close_object): Now static.
5834 * font.h (font_close_object): Remove.
5835 * fontset.c (FONTSET_OBJLIST): Remove.
5836 (free_realized_fontset) #if-0 the body, which does nothing.
5837 (face_suitable_for_char_p): #if-0, as it's never called.
5838 * fontset.h (face_suitable_for_char_p): Remove decl.
5839 * xfaces.c (face_at_string_position):
5840 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5841 since 0 is always ASCII.
5843 * fns.c (weak_hash_tables): Now static.
5845 * fileio.c: Make symbols static if they're not exported.
5846 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5847 (Vwrite_region_annotation_buffers): Now static.
5849 * eval.c: Make symbols static if they're not exported.
5850 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5851 * lisp.h (backtrace_list): Remove decl.
5853 * emacs.c: Make symbols static if they're not exported.
5854 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5855 (fatal_error_code, fatal_error_signal_hook, standard_args):
5857 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5858 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5859 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5860 * lisp.h (fatal_error_signal_hook): Remove decl.
5861 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5863 * editfns.c: Move a (normally-unused) function to its only use.
5864 * editfns.c, lisp.h (get_operating_system_release): Remove.
5865 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5866 worth the hassle of breaking this out.
5868 * xterm.c: Make symbols static if they're not exported.
5869 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5870 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5871 (x_destroy_window, x_delete_display):
5873 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5874 (x_mouse_leave): Remove; unused.
5875 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5876 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5877 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5879 (x_mouse_leave): Declare only if WINDOWSNT.
5880 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5881 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5884 * ftxfont.c: Make symbols static if they're not exported.
5885 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5887 * font.h (ftxfont_driver): Likewise.
5889 * xfns.c: Make symbols static if they're not exported.
5890 (x_last_font_name, x_display_info_for_name):
5891 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5892 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5893 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5894 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5895 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5896 (last_show_tip_args): Now static.
5897 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5898 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5899 (x_screen_planes): Remove; unused.
5900 * dispextern.h (x_screen_planes): Remove decl.
5902 * dispnew.c: Make symbols static if they're not exported.
5903 * dispextern.h (redraw_garbaged_frames, scrolling):
5904 (increment_row_positions): Remove.
5905 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5906 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5908 (redraw_garbaged_frames): Remove; unused.
5910 * xfaces.c: Make symbols static if they're not exported.
5911 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5913 * xterm.h (defined_color): Remove decls.
5914 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5915 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5916 (menu_face_changed_default, defined_color, free_realized_face):
5917 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5918 (ascii_face_of_lisp_face): Remove; unused.
5920 * xdisp.c: Make symbols static if they're not exported.
5921 * dispextern.h (scratch_glyph_row, window_box_edges):
5922 (glyph_to_pixel_coords, set_cursor_from_row):
5923 (get_next_display_element, set_iterator_to_next):
5924 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5925 (show_mouse_face): Remove decls
5926 * frame.h (message_buf_print): Likewise.
5927 * lisp.h (pop_message, set_message, check_point_in_composition):
5929 * xterm.h (set_vertical_scroll_bar): Likewise.
5930 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5931 (message_buf_print, scratch_glyph_row, displayed_buffer):
5932 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5933 (get_next_display_element, show_mouse_face, window_box_edges):
5934 (frame_to_window_pixel_xy, check_point_in_composition):
5935 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5936 (glyph_to_pixel_coords): Remove; unused.
5938 * dired.c (file_name_completion): Now static.
5940 * dbusbind.c (xd_in_read_queued_messages): Now static.
5942 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5943 * data.c (circular_list_error): Remove.
5945 * commands.h (last_point_position, last_point_position_buffer):
5946 (last_point_position_window): Remove decls.
5947 * keyboard.c: Make these variables static.
5949 * coding.h (coding, code_convert_region, encode_coding_gap):
5951 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5952 (iso_code_class, detect_coding, code_convert_region): Now static.
5953 (encode_coding_gap): Remove; unused.
5955 * chartab.c (chartab_chars, chartab_bits): Now static.
5957 * charset.h (charset_iso_8859_1): Remove decl.
5958 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5961 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5962 * ccl.c (Vccl_program_table): Now static.
5963 (check_ccl_update): Remove; unused.
5965 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5966 * category.h: ... from here.
5967 * category.c (check_category_table, set_category_set): Now static.
5969 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5970 * lisp.h: Remove these decls.
5972 * buffer.c (buffer_count): Remove unused var.
5974 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5975 so that it's not optimized away.
5976 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5977 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5978 exported only to the debugger.
5980 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5981 * atimer.h (run_all_atimers): Remove; not exported.
5983 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5984 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5985 was inaccessible from Lisp.
5986 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5987 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5989 alloc.c: Import and export fewer symbols, and remove unused items.
5990 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5992 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5993 it's not optimized away by whole-program optimization.
5994 (message_enable_multibyte, free_misc): Remove.
5995 (catchlist, handlerlist, mark_backtrace):
5996 Declare only if BYTE_MARK_STACK.
5997 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5998 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5999 (message_enable_multibyte): Remove decl.
6000 (free_misc, interval_free_list, float_block, float_block_index):
6001 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6002 (cons_free_list, last_marked_index):
6004 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6005 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6006 (mark_backtrace): Define only if BYTE_MARK_STACK.
6007 * xdisp.c (message_enable_multibyte): Now static.
6009 Declare Lisp_Object Q* variables to be 'static' if not exported.
6010 This makes it easier for human readers (and static analyzers)
6011 to see whether these variables are used from other modules.
6012 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6013 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6014 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6015 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6016 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6017 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6018 * xmenu.c, xselect.c:
6019 Declare Q* vars static if they are not used in other modules.
6020 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6021 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6022 Remove decls of unexported vars.
6023 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6025 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6027 Make Emacs functions such as Fatom 'static' by default.
6028 This makes it easier for human readers (and static analyzers)
6029 to see whether these functions can be called from other modules.
6030 DEFUN now defines a static function. To make the function external
6031 so that it can be used in other C modules, use the new macro DEFUE.
6032 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6033 (Finit_image_library):
6034 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6035 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6036 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6037 Remove decls, since these functions are now static.
6038 (Funintern, Fget_internal_run_time): New decls, since these functions
6039 were already external.
6041 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6042 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6043 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6044 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6045 * keyboard.c, keymap.c, lread.c:
6046 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6047 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6048 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6049 Mark functions with DEFUE instead of DEFUN,
6050 if they are used in other modules.
6051 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6052 decls for now-static functions.
6053 * buffer.h (Fdelete_overlay): Remove decl.
6054 * callproc.c (Fgetenv_internal): Mark as internal.
6055 * composite.c (Fremove_list_of_text_properties): Remove decl.
6056 (Fcomposition_get_gstring): New forward static decl.
6057 * composite.h (Fcomposite_get_gstring): Remove decl.
6058 * dired.c (Ffile_attributes): New forward static decl.
6059 * doc.c (Fdocumntation_property): New forward static decl.
6060 * eval.c (Ffetch_bytecode): New forward static decl.
6061 (Funintern): Remove extern decl; now in .h file where it belongs.
6062 * fileio.c (Fmake_symbolic_link): New forward static decl.
6063 * image.c (Finit_image_library): New forward static decl.
6064 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6065 * intervals.h (Fprevious_property_change):
6066 (Fremove_list_of_text_properties): Remove decls.
6067 * keyboard.c (Fthis_command_keys): Remove decl.
6068 (Fcommand_execute): New forward static decl.
6069 * keymap.c (Flookup_key): New forward static decl.
6070 (Fcopy_keymap): Now static.
6071 * keymap.h (Flookup_key): Remove decl.
6072 * process.c (Fget_process): New forward static decl.
6073 (Fprocess_datagram_address): Mark as internal.
6074 * syntax.c (Fsyntax_table_p): New forward static decl.
6075 (skip_chars): Remove duplicate decl.
6076 * textprop.c (Fprevious_property_change): New forward static decl.
6077 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6079 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6080 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6082 * editfns.c (Fformat): Remove unreachable code.
6084 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6086 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6089 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6091 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6092 when at ZV. (Bug#8487)
6094 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6096 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6098 * keyboard.c (parse_tool_bar_item): Likewise.
6099 * sound.c (sound_cleanup, alsa_close): Likewise.
6100 * termcap.c (tgetent): Likewise.
6101 * xfns.c (x_default_font_parameter): Likewise.
6102 * xsettings.c (read_and_apply_settings): Likewise.
6104 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6105 (overrun_check_free): Protoize.
6107 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6109 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6110 since callers should never pass a negative size.
6111 Change the signature to match that of plain 'read' and 'write'; see
6112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6113 * lisp.h: Update prototypes of emacs_write and emacs_read.
6115 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6117 * xdisp.c (redisplay_window): Don't try to determine the character
6118 position of the scroll margin if the window start point w->startp
6119 is outside the buffer's accessible region. (Bug#8468)
6121 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6123 Fix write-region and its subroutines for buffers > 2GB.
6124 * fileio.c (a_write, e_write): Modify declaration of arguments and
6125 local variables to support buffers larger than 2GB.
6126 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6128 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6129 argument, local variables, and return value.
6131 * lisp.h: Update prototypes of emacs_write and emacs_read.
6133 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6135 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6137 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6139 Fix more problems found by GCC 4.6.0's static checks.
6141 * xdisp.c (vmessage): Use a better test for character truncation.
6143 * charset.c (load_charset_map): <, not <=, for optimization,
6144 and to avoid potential problems with integer overflow.
6145 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6146 * casetab.c (set_identity, shuffle): Likewise.
6147 * editfns.c (Fformat): Likewise.
6148 * syntax.c (skip_chars): Likewise.
6150 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6151 This also lets GCC 4.6.0 generate slightly better loop code.
6153 * callint.c (Fcall_interactively): <, not <=, for optimization.
6154 (Fcall_interactively): Count the number of arguments produced,
6155 not the number of arguments given. This is simpler and lets GCC
6156 4.6.0 generate slightly better code.
6158 * ftfont.c: Distingish more carefully between FcChar8 and char.
6159 The previous code passed unsigned char * to a functions like
6160 strlen and xstrcasecmp that expect char *, which does not
6161 conform to the C standard.
6162 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6163 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6164 char * when the C standard requires it.
6166 * keyboard.c (read_char): Remove unused var.
6168 * eval.c: Port to Windows vsnprintf (Bug#8435).
6170 (SIZE_MAX): Define if the headers do not.
6171 (verror): Do not give up if vsnprintf returns a negative count.
6172 Instead, grow the buffer. This ports to Windows vsnprintf, which
6173 does not conform to C99. Problem reported by Eli Zaretskii.
6174 Also, simplify the allocation scheme, by avoiding the need for
6175 calling realloc, and removing the ALLOCATED variable.
6177 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6179 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6180 But keep the doprint source code for now, as we might revamp it
6181 and use it again (Bug#8435).
6182 * lisp.h (doprnt): Remove.
6183 * Makefile.in (base_obj): Remove doprnt.o.
6184 * deps.mk (doprnt.o): Remove.
6186 error: Print 32- and 64-bit integers portably (Bug#8435).
6187 Without this change, on typical 64-bit hosts error ("...%d...", N)
6188 was used to print both 32- and 64-bit integers N, which relied on
6190 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6192 * lisp.h (error, verror): Mark as printf-like functions.
6193 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6194 Report overflow in size calculations when allocating printf buffer.
6195 Do not truncate output string at its first null byte.
6196 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6197 Truncate the output at a character boundary, since vsnprintf does not
6199 * charset.c (check_iso_charset_parameter): Convert internal
6200 character to string before calling 'error', since %c now has the
6202 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6203 overflow when computing char to be passed to 'error'. Do not
6204 pass Lisp_Object to 'error'; pass the integer instead.
6205 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6206 formatted with plain %d.
6208 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6210 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6212 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6214 * xterm.c (x_catch_errors): Remove duplicate declaration.
6216 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6218 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6220 2011-04-10 Jim Meyering <meyering@redhat.com>
6222 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6223 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6224 return ssize_t not "int", and use size_t as the buffer length.
6225 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6226 * gnutls.h: Update declarations.
6227 * process.c (read_process_output): Use ssize_t, to match.
6228 (send_process): Likewise.
6230 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6232 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6234 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6236 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6237 Use unsigned char, to match FcChar8 type definition.
6239 * xterm.c (handle_one_xevent):
6240 * xmenu.c (create_and_show_popup_menu):
6241 * xselect.c (x_decline_selection_request)
6242 (x_reply_selection_request): Avoid type-punned deref of X events.
6244 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6246 Fix some uses of `int' instead of EMACS_INT.
6247 * search.c (string_match_1, fast_string_match)
6248 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6249 (scan_buffer, find_next_newline_no_quit)
6250 (find_before_next_newline, search_command, Freplace_match)
6251 (Fmatch_data): Make some `int' variables be EMACS_INT.
6253 * xdisp.c (display_count_lines): 3rd argument and return value now
6254 EMACS_INT. All callers changed.
6255 (pint2hrstr): Last argument is now EMACS_INT.
6257 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6258 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6259 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6260 (decode_coding_utf_16, decode_coding_emacs_mule)
6261 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6262 (decode_coding_ccl, decode_coding_charset)
6263 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6264 (decode_coding_iso_2022, decode_coding_emacs_mule)
6265 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6266 <char_offset, last_offset>: Declare EMACS_INT.
6267 (encode_coding_utf_8, encode_coding_utf_16)
6268 (encode_coding_emacs_mule, encode_invocation_designation)
6269 (encode_designation_at_bol, encode_coding_iso_2022)
6270 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6271 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6273 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6274 (encode_invocation_designation): Last argument P_NCHARS is now
6276 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6277 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6279 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6282 * ccl.c (Fccl_execute_on_string): Declare some variables
6285 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6287 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6289 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6291 * process.c (Fformat_network_address): Doc fix.
6293 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6295 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6297 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6299 * keyboard.c (read_char): Call Lisp function help-form-show,
6300 instead of using internal_with_output_to_temp_buffer.
6301 (Qhelp_form_show): New var.
6302 (syms_of_keyboard): Use DEFSYM macro.
6304 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6306 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6308 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6310 * process.c (Flist_processes): Remove to Lisp.
6311 (list_processes_1): Delete.
6313 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6315 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6317 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6319 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6321 Fix more problems found by GCC 4.6.0's static checks.
6323 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6325 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6327 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6329 * xdisp.c (vmessage): Mark as a printf-like function.
6331 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6333 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6335 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6336 printf-like functions.
6337 (tiff_load): Add casts to remove these marks before passing them
6338 to system-supplied API.
6340 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6342 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6343 This avoids several warnings with gcc -Wstrict-overflow.
6344 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6345 directly, rather than having caller test rule sign. This avoids
6346 some unnecessary tests.
6347 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6348 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6349 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6351 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6352 (xfont_open): Avoid unnecessary tests.
6354 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6356 * composite.h, composite.c (composition_gstring_put_cache):
6357 Use EMACS_INT, not int, for length.
6359 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6360 breaking out part of COMPOSITION_DECODE_RULE.
6361 (COMPOSITION_DECODE_RULE): Use it.
6362 * composite.c (get_composition_id): Remove unused local vars,
6363 by using the new macro.
6365 * textprop.c (set_text_properties_1): Change while to do-while,
6366 since the condition is always true at first.
6368 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6369 (interval_deletion_adjustment): Return unsigned value.
6372 * process.c (list_processes_1, create_pty, read_process_output):
6373 (exec_sentinel): Remove vars that were set but not used.
6374 (create_pty): Remove unnecessary "volatile"s.
6375 (Fnetwork_interface_info): Avoid possibility of int overflow.
6376 (read_process_output): Do adaptive read buffering even if carryover.
6377 (read_process_output): Simplify nbytes computation if buffered.
6379 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6381 * syntax.c (scan_words): Remove var that was set but not used.
6382 (update_syntax_table): Use unsigned instead of int.
6384 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6385 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6386 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6388 * print.c (print_error_message): Avoid int overflow.
6390 * font.c (font_list_entities): Redo for clarity,
6391 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6393 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6394 (font_score): Avoid potential overflow in diff calculation.
6396 * fns.c (substring_both): Remove var that is set but not used.
6397 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6399 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6401 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6402 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6403 can always succeed if overflow has undefined behavior.
6405 * search.c (boyer_moore, wordify): Remove vars set but not used.
6406 (wordify): Omit three unnecessary tests.
6408 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6409 All callers changed. This avoids the need for an unused var.
6411 * casefiddle.c (casify_region): Remove var that is set but not used.
6413 * dired.c (file_name_completion): Remove var that is set but not used.
6415 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6417 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6418 (Finsert_file_contents): Remove unnecessary code checking fd.
6420 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6421 Check for integer overflow on size calculations.
6423 * buffer.c (Fprevious_overlay_change): Remove var that is set
6426 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6427 Remove vars that are set but not used.
6428 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6429 (timer_check_2): Mark vars as initialized.
6431 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6433 * image.c (lookup_image): Remove var that is set but not used.
6434 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6436 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6437 that are set but not used.
6439 * xfns.c (make_invisible_cursor): Don't return garbage
6440 if XCreateBitmapFromData fails (Bug#8410).
6442 * xselect.c (x_get_local_selection, x_handle_property_notify):
6443 Remove vars that are set but not used.
6445 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6446 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6448 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6449 Remove var that is set but not used.
6450 (scroll_bar_windows_size): Now size_t, not int.
6451 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6454 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6455 (map_tty_color) [!defined MSDOS]: Likewise.
6457 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6459 * coding.c: Remove vars that are set but not used.
6460 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6461 All callers changed.
6462 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6463 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6464 (decode_coding_charset): Remove vars that are set but not used.
6466 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6467 that is set but not used.
6469 * print.c (print_object): Remove var that is set but not used.
6471 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6472 The gnulib version avoids calling malloc in the usual case,
6473 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6474 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6475 * filelock.c (current_lock_owner): Likewise.
6476 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6477 * sysdep.c: Include allocator.h, careadlinkat.h.
6478 (emacs_no_realloc_allocator): New static constant.
6479 (emacs_readlink): New function.
6480 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6481 ../lib/careadlinkat.h.
6483 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6485 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6486 first non-nil return value).
6488 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6490 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6491 if not defined (Bug#8403).
6493 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6495 * xdisp.c (display_count_lines): Remove parameter `start',
6496 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6497 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6498 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6499 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6500 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6501 and thereabouts. All callers changed.
6502 (get_per_char_metric): Remove parameter `f', unused since
6503 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6505 2011-04-02 Jim Meyering <meyering@redhat.com>
6507 do not dereference NULL upon failed strdup
6508 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6509 (ns_get_family): Likewise.
6511 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6513 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6515 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6517 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6520 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6522 Add lexical binding.
6524 * window.c (Ftemp_output_buffer_show): New fun.
6525 (Fsave_window_excursion):
6526 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6528 * lread.c (lisp_file_lexically_bound_p): New function.
6529 (Fload): Bind Qlexical_binding.
6530 (readevalloop): Remove `evalfun' arg.
6531 Bind Qinternal_interpreter_environment.
6532 (Feval_buffer): Bind Qlexical_binding.
6533 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6535 (syms_of_lread): Declare `lexical-binding'.
6537 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6539 * keyboard.c (eval_dyn): New fun.
6540 (menu_item_eval_property): Use it.
6542 * image.c (parse_image_spec): Use Ffunctionp.
6544 * fns.c (concat, mapcar1): Accept byte-code-functions.
6546 * eval.c (Fsetq): Handle lexical vars.
6547 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6548 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6549 (FletX, Flet): Obey lexical binding.
6550 (Fcommandp): Handle closures.
6551 (Feval): New `lexical' arg.
6552 (eval_sub): New function extracted from Feval. Use it almost
6553 everywhere where Feval was used. Look up vars in lexical env.
6555 (Ffunctionp): Move from subr.el.
6556 (Ffuncall): Handle closures.
6557 (apply_lambda): Remove `eval_flags'.
6558 (funcall_lambda): Handle closures and new byte-code-functions.
6559 (Fspecial_variable_p): New function.
6560 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6561 but without exporting it to Lisp.
6563 * doc.c (Fdocumentation, store_function_docstring):
6564 * data.c (Finteractive_form): Handle closures.
6566 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6569 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6571 (exec_byte_code): New function extracted from Fbyte_code to handle new
6572 calling convention for byte-code-functions. Add new byte-codes.
6574 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6576 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6578 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6580 * xdisp.c (redisplay_internal): Fix prototype.
6582 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6584 * xdisp.c (SCROLL_LIMIT): New macro.
6585 (try_scrolling): Use it when setting scroll_limit.
6586 Limit scrolling to 100 screen lines.
6587 (redisplay_window): Even when falling back on "recentering",
6588 position point in the window according to scroll-conservatively,
6589 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6591 (try_scrolling): When point is above the window, allow searching
6592 as far as scroll_max, or one screenful, to compute vertical
6593 distance from PT to the scroll margin position. This prevents
6594 try_scrolling from unnecessarily failing when
6595 scroll-conservatively is set to a value slightly larger than the
6596 window height. Clean up the case of PT below the margin at bottom
6597 of window: scroll_max can no longer be INT_MAX. When aggressive
6598 scrolling is in use, don't let point enter the opposite scroll
6599 margin as result of the scroll.
6600 (syms_of_xdisp) <scroll-conservatively>: Document the
6601 threshold of 100 lines for never-recentering scrolling.
6603 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6605 * dispextern.h (move_it_by_lines):
6606 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6607 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6608 (message_log_check_duplicate): Remove parameters `prev_bol' and
6609 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6610 (redisplay_internal): Remove parameter `preserve_echo_area',
6611 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6613 * indent.c (Fvertical_motion):
6614 * window.c (window_scroll_pixel_based, Frecenter):
6615 Don't pass `need_y_p' to `move_it_by_lines'.
6617 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6619 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6620 steal a few bits to be more compact.
6621 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6622 Remove unneeded casts.
6624 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6626 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6628 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6629 binding" message (bug#7967).
6631 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6633 Fix more problems found by GCC 4.6.0's static checks.
6635 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6636 Remove unused local var.
6638 * editfns.c (Fmessage_box): Remove unused local var.
6640 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6641 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6642 Omit unused local vars.
6643 * window.c (shrink_windows): Omit unused local var.
6644 * menu.c (digest_single_submenu): Omit unused local var.
6645 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6646 Omit unused local var.
6648 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6649 Don't assume string length fits in int.
6650 (keyremap_step, read_key_sequence): Use size_t for sizes.
6651 (read_key_sequence): Don't check last_real_key_start redundantly.
6653 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6654 instead of alloca (Bug#8344).
6656 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6657 (Fbacktrace_frame): Don't assume nframes fits in int.
6659 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6661 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6664 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6666 * cm.c (calccost): Turn while-do into do-while, for clarity.
6668 * keyboard.c (syms_of_keyboard): Use the same style as later
6669 in this function when indexing through an array. This also
6670 works around GCC bug 48267.
6672 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6674 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6676 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6677 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6679 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6680 This avoids undefined behavior on integer overflow, and is a bit
6681 more convenient anyway since it is compared to a size_t variable.
6683 Variadic C functions now count arguments with size_t, not int.
6684 This avoids an unnecessary limitation on 64-bit machines, which
6685 caused (substring ...) to crash on large vectors (Bug#8344).
6686 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6687 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6688 All variadic functions and their callers changed accordingly.
6689 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6690 * data.c (arith_driver, float_arith_driver): Likewise.
6691 * editfns.c (general_insert_function): Likewise.
6692 * eval.c (struct backtrace.nargs, interactive_p)
6693 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6694 (funcall_lambda, mark_backtrace): Likewise.
6695 * fns.c (concat): Likewise.
6696 * frame.c (x_set_frame_parameters): Likewise.
6697 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6698 0 if not found, not -1. All callers changed.
6700 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6701 (stack_copy_size): Now size_t, not int.
6702 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6704 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6706 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6707 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6708 All callers changed.
6710 * lisp.h (multibyte_char_to_unibyte):
6711 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6712 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6713 * character.h (CHAR_TO_BYTE8):
6714 * cmds.c (internal_self_insert):
6715 * editfns.c (general_insert_function):
6716 * keymap.c (push_key_description):
6717 * search.c (Freplace_match):
6718 * xdisp.c (message_dolog, set_message_1): All callers changed.
6720 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6722 * keyboard.c (safe_run_hook_funcall): New function.
6723 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6724 don't set the hook to nil, but remove the offending function instead.
6725 (Qcommand_hook_internal): Remove, unused.
6726 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6727 Vcommand_hook_internal.
6729 * eval.c (enum run_hooks_condition): Remove.
6730 (funcall_nil, funcall_not): New functions.
6731 (run_hook_with_args): Call each function through a `funcall' argument.
6732 Remove `cond' argument, now redundant.
6733 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6734 (Frun_hook_with_args_until_failure): Adjust accordingly.
6735 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6737 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6739 * dispextern.h (string_buffer_position): Remove declaration.
6741 * print.c (strout): Remove parameter `multibyte', unused since
6742 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6744 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6745 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6746 All callers changed.
6748 * w32.c (_wsa_errlist): Use braces for struct initializers.
6750 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6751 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6752 All callers changed.
6753 (string_buffer_position): Likewise. Also, make static (it's never
6754 used outside xdisp.c).
6755 (cursor_row_p): Remove parameter `w', unused since
6756 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6757 (decode_mode_spec): Remove parameter `precision', introduced during
6758 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6759 All callers changed.
6761 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6763 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6765 2011-03-27 Anders Lindgren <andlind@gmail.com>
6767 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6768 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6769 (ns_update_auto_hide_menu_bar): New functions.
6770 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6771 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6772 ns_constrain_all_frames.
6773 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6774 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6776 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6778 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6780 2011-03-27 Glenn Morris <rgm@gnu.org>
6782 * syssignal.h: Replace RETSIGTYPE with void.
6783 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6784 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6785 Replace SIGTYPE with void everywhere.
6786 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6787 * s/template.h (SIGTYPE): Remove commented out definition.
6789 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6791 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6792 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6794 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6796 * w32.c (read_unc_volume): Use parameter `henum', instead of
6797 global variable `wget_enum_handle'.
6799 * keymap.c (describe_vector): Remove parameters `indices' and
6800 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6801 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6803 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6805 * keyboard.c (timer_check): Remove parameter `do_it_now',
6806 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6807 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6808 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6810 * keyboard.c (read_char):
6811 * w32menu.c (w32_menu_display_help):
6812 * xmenu.c (show_help_event, menu_help_callback):
6813 Adjust calls to `show_help_echo'.
6815 * gtkutil.c (xg_maybe_add_timer):
6816 * keyboard.c (readable_events):
6817 * process.c (wait_reading_process_output):
6818 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6820 * insdel.c (adjust_markers_gap_motion):
6821 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6822 (gap_left, gap_right): Don't call it.
6824 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6826 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6827 incurred during fontification.
6829 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6831 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6832 (DEFVAR_PER_BUFFER): Don't pass it.
6834 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6835 (scrolling_window): Don't pass it.
6837 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6839 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6841 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6843 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6844 of variables specific to SELinux and computation of `encoded_absname'.
6846 * image.c (XPutPixel): Remove unused variable `height'.
6848 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6850 * unexw32.c (get_section_info): Remove unused variable `section'.
6852 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6853 (system_process_attributes): Remove unused variable `sess'.
6854 (sys_read): Remove unused variable `err'.
6856 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6857 (w32_wnd_proc): Remove unused variable `isdead'.
6858 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6859 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6860 (x_create_tip_frame): Remove unused variable `tem'.
6862 * w32inevt.c (w32_console_read_socket):
6863 Remove unused variable `no_events'.
6865 * w32term.c (x_draw_composite_glyph_string_foreground):
6866 Remove unused variable `width'.
6868 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6870 * w32term.c (x_set_glyph_string_clipping):
6871 Don't pass uninitialized region to CombineRgn.
6873 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6875 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6876 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6877 (Fx_close_connection): Remove unused variable `i'.
6879 * w32font.c (w32font_draw): Return number of glyphs.
6880 (w32font_open_internal): Remove unused variable `i'.
6881 (w32font_driver): Add missing initializer.
6883 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6884 (fill_in_menu): Remove unused variable `items_added'.
6886 * w32term.c (last_mouse_press_frame): Remove static global variable.
6887 (w32_clip_to_row): Remove unused variable `f'.
6888 (x_delete_terminal): Remove unused variable `i'.
6890 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6891 (NOTHING): Remove unused static global variable.
6892 (uniscribe_check_otf): Remove unused variable `table'.
6893 (uniscribe_font_driver): Add missing initializers.
6895 2011-03-23 Julien Danjou <julien@danjou.info>
6897 * term.c (Fsuspend_tty, Fresume_tty):
6898 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6899 * window.c (temp_output_buffer_show):
6900 * insdel.c (signal_before_change):
6901 * frame.c (Fhandle_switch_frame):
6902 * fileio.c (Fdo_auto_save):
6903 * emacs.c (Fkill_emacs):
6904 * editfns.c (save_excursion_restore):
6905 * cmds.c (internal_self_insert):
6906 * callint.c (Fcall_interactively):
6907 * buffer.c (Fkill_all_local_variables):
6908 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6910 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6911 unconditionnaly since it does the check itself.
6913 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6915 Fix more problems found by GCC 4.5.2's static checks.
6917 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6918 the first time through the loop, since we know p0 < p1 then.
6919 This also avoids a gcc -Wstrict-overflow warning.
6921 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6922 leading to a memory leak, possible in functions like
6923 load_charset_map_from_file that can allocate an unbounded number
6924 of objects (Bug#8318).
6926 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6927 that could (at least in theory) be that large.
6929 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6930 This is less likely to overflow, and avoids undefined behavior if
6931 overflow does occur. All callers changed. Use strtoul to scan
6932 for the unsigned long integer.
6933 (pint2hrstr): Simplify and tune code slightly.
6934 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6936 * scroll.c (do_scrolling): Work around GCC bug 48228.
6937 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6939 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6940 This also avoids a warning with gcc -Wstrict-overflow.
6941 (validate_x_resource_name): Simplify count usage.
6942 This also avoids a warning with gcc -Wstrict-overflow.
6944 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6947 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6949 * process.c (Fmake_network_process): Use socklen_t, not int,
6950 where POSIX says socklen_t is required in portable programs.
6951 This fixes a porting bug on hosts like 64-bit HP-UX, where
6952 socklen_t is wider than int (Bug#8277).
6953 (Fmake_network_process, server_accept_connection):
6954 (wait_reading_process_output, read_process_output):
6957 * process.c: Rename or move locals to avoid shadowing.
6958 (list_processes_1, Fmake_network_process):
6959 (read_process_output_error_handler, exec_sentinel_error_handler):
6960 Rename or move locals.
6961 (Fmake_network_process): Define label "retry_connect" only if needed.
6962 (Fnetwork_interface_info): Fix pointer signedness.
6963 (process_send_signal): Add cast to avoid pointer signedness problem.
6964 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6965 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6967 Make tparam.h and terminfo.c consistent.
6968 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6969 Include tparam.h instead, since it declares them.
6970 * cm.h (PC): Remove extern decl; tparam.h now does this.
6971 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6972 * terminfo.c: Include tparam.h, to check interfaces.
6973 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6974 (tparam): Adjust signature to match interface in tparam.h;
6975 this removes some undefined behavior. Check that outstring and len
6976 are zero, which they always are with Emacs.
6977 * tparam.h (PC, BC, UP): New extern decls.
6979 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6980 (xftfont_open): Rename locals to avoid shadowing.
6982 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6983 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6984 (OTF_TAG_SYM): Omit macro if not needed.
6985 (ftfont_list): Remove unused local.
6986 (get_adstyle_property, ftfont_pattern_entity):
6987 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6988 Rename locals to avoid shadowing.
6990 * xfont.c (xfont_list_family): Mark var as initialized.
6992 * xml.c (make_dom): Now static.
6994 * composite.c (composition_compute_stop_pos): Rename local to
6996 (composition_reseat_it): Remove unused locals.
6997 (find_automatic_composition, composition_adjust_point): Likewise.
6998 (composition_update_it): Mark var as initialized.
6999 (find_automatic_composition): Mark vars as initialized,
7000 with a FIXME (Bug#8290).
7002 character.h: Rename locals to avoid shadowing.
7003 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7004 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7005 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7006 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7009 * textprop.c (property_change_between_p): Remove; unused.
7011 * intervals.c (interval_start_pos): Now static.
7013 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7015 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7016 Rename locals to avoid shadowing.
7018 * sound.c (wav_play, au_play, Fplay_sound_internal):
7019 Fix pointer signedness.
7020 (alsa_choose_format): Remove unused local var.
7021 (wav_play): Initialize a variable to 0, to prevent undefined
7022 behavior (Bug#8278).
7024 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7026 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7028 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7029 clobbering (Bug#8298).
7030 * sysdep.c (sys_subshell): Likewise.
7031 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7033 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7034 This should get cleaned up, so that child_setup has the
7035 same signature on all platforms.
7037 * callproc.c (call_process_cleanup): Now static.
7038 (relocate_fd): Rename locals to avoid shadowing.
7040 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7042 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7043 not to be necessary, and produces flickering.
7045 2011-03-20 Glenn Morris <rgm@gnu.org>
7047 * config.in: Remove file.
7049 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7051 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7052 are now in src/globals.h.
7053 (syms_of_minibuf): Remove spurious & from previous change.
7055 2011-03-20 Leo <sdl.web@gmail.com>
7057 * minibuf.c (completing-read-function): New variable.
7058 (completing-read-default): Rename from completing-read.
7059 (completing-read): Call completing-read-function.
7061 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7063 * xfaces.c (Fx_load_color_file):
7064 Read color file from absolute filename (bug#8250).
7066 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7068 * makefile.w32-in: Update dependencies.
7070 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7072 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7074 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7076 Fix more problems found by GCC 4.5.2's static checks.
7078 * process.c (make_serial_process_unwind, send_process_trap):
7079 (sigchld_handler): Now static.
7081 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7082 That way, the code declares only the vars that it needs.
7083 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7084 * s/cygwin.h (PTY_ITERATION): Likewise.
7085 * s/darwin.h (PTY_ITERATION): Likewise.
7086 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7088 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7089 * process.c (allocate_pty): Don't declare stb unless it's needed.
7091 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7092 (CONSTANTLIM): Remove; unused.
7093 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7094 Define only if needed.
7096 * unexelf.c (unexec): Name an expression,
7097 to avoid gcc -Wbad-function-cast warning.
7098 Use a different way to cause a compilation error if anyone uses
7099 n rather than nn, a way that does not involve shadowing.
7100 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7102 * deps.mk (unexalpha.o): Remove; unused.
7104 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7105 * unexec.h: New file.
7106 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7107 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7109 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7110 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7111 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7112 Change as necessary to match prototype in unexec.h.
7114 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7116 (back_comment, skip_chars): Mark vars as initialized.
7118 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7119 Rename locals to avoid shadowing.
7121 * lread.c (read1): Rewrite so as not to use empty "else".
7122 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7124 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7126 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7127 warning when compiling print.c.
7129 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7130 instead of using an uninitialized var.
7131 (font_sort_entities): Mark var as initialized.
7133 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7135 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7136 pointers to constants.
7137 (font_parse_fcname): Remove unused vars.
7138 (font_delete_unmatched): Now static.
7139 (font_get_spec): Remove; unused.
7140 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7141 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7142 Rename or move locals to avoid shadowing.
7144 * fns.c (require_nesting_list, require_unwind): Now static.
7145 (Ffillarray): Rename locals to avoid shadowing.
7147 * floatfns.c (domain_error2): Define only if needed.
7148 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7150 * alloc.c (mark_backtrace): Move decl from here ...
7151 * lisp.h: ... to here, so that it can be checked.
7153 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7154 (Fdefvar): Rewrite so as not to use empty "else".
7155 (lisp_indirect_variable): Name an expression,
7156 to avoid gcc -Wbad-function-cast warning.
7157 (Fdefvar): Rename locals to avoid shadowing.
7159 * callint.c (quotify_arg, quotify_args): Now static.
7160 (Fcall_interactively): Rename locals to avoid shadowing.
7161 Use const pointer when appropriate.
7163 * lisp.h (get_system_name, get_operating_system_release):
7164 Move decls here, to check interfaces.
7165 * process.c (get_operating_system_release): Move decl to lisp.h.
7166 * xrdb.c (get_system_name): Likewise.
7167 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7168 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7169 some of which prompt warnings from gcc -Wbad-function-cast.
7170 (Fformat_time_string, Fencode_time, Finsert_char):
7171 (Ftranslate_region_internal, Fformat):
7172 Rename or remove local vars to avoid shadowing.
7173 (Ftranslate_region_internal): Mark var as initialized.
7175 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7178 * lisp.h (eassert): Check that the argument compiles, even if
7179 ENABLE_CHECKING is not defined.
7181 * data.c (Findirect_variable): Name an expression, to avoid
7182 gcc -Wbad-function-cast warning.
7183 (default_value, arithcompare, arith_driver, arith_error): Now static.
7184 (store_symval_forwarding): Rename local to avoid shadowing.
7185 (Fmake_variable_buffer_local, Fmake_local_variable):
7186 Mark variables as initialized.
7187 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7189 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7190 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7191 Rename locals to avoid shadowing.
7192 (mark_stack): Move local variables into the #ifdef region where
7194 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7195 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7197 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7198 (GC_STRING_CHARS): Remove; not used.
7199 (Fmemory_limit): Cast sbrk's returned value to char *.
7201 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7202 avoids undefined behavior in theory.
7204 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7206 Use functions, not macros, for up- and down-casing (Bug#8254).
7207 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7208 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7209 to use the following functions instead of these macros.
7210 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7211 EMACS_INT, since callers assume the returned value fits in int.
7212 (upcase1): Likewise, for UPCASE_TABLE.
7213 (uppercasep, lowercasep, upcase): New static inline functions.
7214 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7215 the race-condition problem in the old DOWNCASE.
7217 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7218 Rename locals to avoid shadowing.
7219 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7220 (regex_compile, re_search_2, re_match_2_internal):
7221 Remove unused local vars.
7222 (FREE_VAR): Rewrite so as not to use empty "else",
7223 which gcc can warn about.
7224 (regex_compile, re_match_2_internal): Mark locals as initialized.
7225 (RETALLOC_IF): Define only if needed.
7226 (WORDCHAR_P): Likewise. This one is never needed, but is used
7227 only in a comment talking about a compiler bug, so put inside
7228 the #if 0 of that comment.
7229 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7230 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7233 * search.c (boyer_moore): Rename locals to avoid shadowing.
7234 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7235 (PREV_CHAR_BOUNDARY): Likewise.
7237 * search.c (simple_search): Remove unused var.
7239 * dired.c (compile_pattern): Move decl from here ...
7240 * lisp.h: ... to here, so that it can be checked.
7241 (struct re_registers): New forward decl.
7243 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7245 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7247 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7248 Rename locals to avoid shadowing.
7249 (Fvertical_motion): Mark locals as initialized.
7251 * casefiddle.c (casify_object, casify_region): Now static.
7252 (casify_region): Mark local as initialized.
7254 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7256 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7257 New macros, so that the caller can use some names other than
7258 gcpro1, gcpro2, etc.
7259 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7261 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7262 argument, for consistency with GCPRO2_VAR, etc: it is now the
7263 prefix of the variable, not the variable itself. All uses
7265 * dired.c (directory_files_internal, file_name_completion):
7266 Rename locals to avoid shadowing.
7268 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7269 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7270 dired.c's scmp function, had undefined behavior.
7271 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7272 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7273 * buffer.h: ... to here, because these macros use current_buffer,
7274 and the new implementation with inline functions needs to have
7275 current_buffer in scope now, rather than later when the macros
7277 (downcase, upcase1): New static inline functions.
7278 (DOWNCASE, UPCASE1): Reimplement using these functions.
7279 This avoids undefined behavior in expressions like
7280 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7281 from race conditions in accessing the global variables
7282 case_temp1 and case_temp2.
7283 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7284 * lisp.h (case_temp1, case_temp2): Remove their decls.
7285 * character.h (ASCII_CHAR_P): Move from here ...
7286 * lisp.h: ... to here, so that the inline functions mentioned
7289 * dired.c (directory_files_internal_unwind): Now static.
7291 * fileio.c (file_name_as_directory, directory_file_name):
7292 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7294 (file_name_as_directory): Use const pointers when appropriate.
7295 (Fexpand_file_name): Likewise. In particular, newdir might
7296 point at constant storage, so make it a const pointer.
7297 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7298 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7300 (Fset_file_times, Finsert_file_contents, auto_save_error):
7301 Rename locals to avoid shadowing.
7303 * minibuf.c (choose_minibuf_frame_1): Now static.
7304 (Ftry_completion, Fall_completions): Rename or remove locals
7307 * marker.c (bytepos_to_charpos): Remove; unused.
7309 * lisp.h (verify_bytepos, count_markers): New decls,
7310 so that gcc does not warn that these functions aren't declared.
7312 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7313 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7314 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7315 (copy_text): Remove unused local var.
7317 * filelock.c (within_one_second): Now static.
7318 (lock_file_1): Rename local to avoid shadowing.
7320 * buffer.c (fix_overlays_before): Mark locals as initialized.
7321 (fix_start_end_in_overlays): Likewise. This function should be
7322 simplified by using pointers-to-pointers, but that's a different
7324 (switch_to_buffer_1): Now static.
7325 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7326 (report_overlay_modification): Rename locals to avoid shadowing.
7328 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7329 Fix pointer signedness issue.
7330 (sys_subshell): Mark local as volatile if checking for lint,
7331 to suppress a gcc -Wclobbered warning that does not seem to be right.
7332 (MAXPATHLEN): Define only if needed.
7334 * process.c (serial_open, serial_configure): Move decls from here ...
7335 * systty.h: ... to here, so that they can be checked.
7337 * fns.c (get_random, seed_random): Move extern decls from here ...
7338 * lisp.h: ... to here, so that they can be checked.
7340 * sysdep.c (reset_io): Now static.
7341 (wait_for_termination_signal): Remove; unused.
7343 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7344 (copy_keymap_item, append_key, push_text_char_description):
7346 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7347 (DENSE_TABLE_SIZE): Remove; unused.
7348 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7349 (describe_map_tree):
7350 Rename locals to avoid shadowing.
7352 * keyboard.c: Declare functions static if they are not used elsewhere.
7353 (echo_char, echo_dash, cmd_error, top_level_2):
7354 (poll_for_input, handle_async_input): Now static.
7355 (read_char, kbd_buffer_get_event, make_lispy_position):
7356 (make_lispy_event, make_lispy_movement, apply_modifiers):
7357 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7358 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7359 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7360 (read_key_sequence, read_char): Mark locals as initialized.
7361 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7363 * keyboard.h (make_ctrl_char): New decl.
7364 (mark_kboards): Move decl here ...
7365 * alloc.c (mark_kboards): ... from here.
7367 * lisp.h (force_auto_save_soon): New decl.
7369 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7370 (DEFINE_DUMMY_FUNCTION): New macro.
7371 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7373 (main): Add casts to avoid warnings
7374 if GCC considers string literals to be constants.
7376 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7378 * dbusbind.c: Pointer signedness fixes.
7379 (xd_signature, xd_append_arg, xd_initialize):
7380 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7381 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7382 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7383 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7385 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7386 if GCC considers string literals to be constants.
7387 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7389 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7391 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7392 (print_preprocess, print_object): New macro to fix last change.
7394 * print.c (print_preprocess): Don't forget font objects.
7396 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7398 * emacs.c (USAGE3): Doc fixes.
7400 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7402 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7405 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7407 * lisp.h (VWindow_system, Qfile_name_history):
7408 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7409 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7410 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7412 * w32select.c: Don't #include "keyboard.h".
7413 (run_protected): Add extern declaration for waiting_for_input.
7415 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7416 * w32console.c (detect_input_pending, read_input_pending)
7417 (encode_terminal_code):
7418 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7419 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7420 (w32_system_caret_y, Qfile_name_history):
7421 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7422 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7423 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7424 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7425 * w32proc.c (Qlocal, report_file_error):
7426 * w32term.c (Vwindow_system, updating_frame):
7427 * w32uniscribe.c (initialized, uniscribe_font_driver):
7428 Remove unneeded extern declarations.
7430 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7432 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7434 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7436 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7437 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7438 These macros can no longer be used for assignment.
7440 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7441 Assign struct members directly, instead of using BUF_BEGV etc.
7442 (record_buffer_markers, fetch_buffer_markers): New functions for
7443 recording and fetching special buffer markers.
7444 (set_buffer_internal_1, set_buffer_temp): Use them.
7446 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7448 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7450 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7451 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7453 * xdisp.c (hscroll_window_tree):
7454 (reconsider_clip_changes): Use PT instead of BUF_PT.
7456 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7458 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7459 $(EMACS_ROOT)/lib/intprops.h.
7461 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7463 Fix more problems found by GCC 4.5.2's static checks.
7465 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7466 to unsigned char * to avoid compiler diagnostic.
7467 (xg_free_frame_widgets): Make it clear that a local variable is
7468 needed only if USE_GTK_TOOLTIP.
7469 (gdk_window_get_screen): Make it clear that this macro is needed
7470 only if USE_GTK_TOOLTIP.
7471 (int_gtk_range_get_value): New function, which avoids a diagnostic
7472 from gcc -Wbad-function-cast.
7473 (xg_set_toolkit_scroll_bar_thumb): Use it.
7474 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7475 diagnostic from gcc -Wbad-function-cast.
7476 (get_utf8_string, xg_get_file_with_chooser):
7477 Rename locals to avoid shadowing.
7478 (create_dialog): Move locals to avoid shadowing.
7480 * xgselect.c (xg_select): Remove unused var.
7482 * image.c (four_corners_best): Mark locals as initialized.
7483 (gif_load): Initialize transparent_p to zero (Bug#8238).
7484 Mark another local as initialized.
7485 (my_png_error, my_error_exit): Mark with NO_RETURN.
7487 * image.c (clear_image_cache): Now static.
7488 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7489 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7490 (x_edge_detection): Remove unnecessary cast that
7491 gcc -Wbad-function-cast diagnoses.
7492 (gif_load): Fix pointer signedness.
7493 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7494 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7496 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7498 Improve quality of tests for time stamp overflow.
7499 For example, without this patch (encode-time 0 0 0 1 1
7500 1152921504606846976) returns the obviously-bogus value (-948597
7501 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7502 reports time overflow. See
7503 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7504 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7505 * editfns.c: Include limits.h and intprops.h.
7506 (TIME_T_MIN, TIME_T_MAX): New macros.
7507 (time_overflow): Move earlier, to before first use.
7508 (hi_time, lo_time): New functions, for an accurate test for
7510 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7511 (Fget_internal_run_time): Don't assume time_t fits in int.
7512 (make_time): Use list2 instead of Fcons twice.
7513 (Fdecode_time): More accurate test for out-of-range times.
7514 (check_tm_member): New function.
7515 (Fencode_time): Use it, to test for out-of-range times.
7516 (lisp_time_argument): Don't rely on undefined left-shift and
7517 right-shift behavior when checking for time stamp overflow.
7519 * editfns.c (time_overflow): New function, refactoring common code.
7520 (Fformat_time_string, Fdecode_time, Fencode_time):
7521 (Fcurrent_time_string): Use it.
7523 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7524 * dired.c (make_time): Move to ...
7525 * editfns.c (make_time): ... here.
7526 * systime.h: Note the move.
7528 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7530 * fringe.c (update_window_fringes): Remove unused variables.
7532 * unexmacosx.c (copy_data_segment): Also copy __got section.
7535 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7537 * termcap.c [MSDOS]: Include "msdos.h".
7538 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7539 Constify `char *' arguments and their references according to
7540 prototypes in tparam.h.
7542 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7544 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7545 Adapt all references accordingly.
7547 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7549 2011-03-11 Tom Tromey <tromey@redhat.com>
7551 * buffer.c (syms_of_buffer): Remove obsolete comment.
7553 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7555 * termhooks.h (encode_terminal_code): Declare prototype.
7557 * msdos.c (encode_terminal_code): Don't declare prototype.
7559 * term.c (encode_terminal_code): Now external again, used by
7560 w32console.c and msdos.c.
7562 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7563 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7565 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7567 Fix some minor problems found by GCC 4.5.2's static checks.
7569 * fringe.c (update_window_fringes): Mark locals as initialized
7571 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7573 * alloc.c (mark_fringe_data): Move decl from here ...
7574 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7575 to check its interface.
7576 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7578 * fontset.c (free_realized_fontset): Now static.
7579 (Fset_fontset_font): Rename local to avoid shadowing.
7580 (fontset_font): Mark local as initialized.
7581 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7583 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7585 * xselect.c (x_disown_buffer_selections): Remove; not used.
7586 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7587 (x_own_selection, Fx_disown_selection_internal): Rename locals
7589 (x_handle_dnd_message): Remove local to avoid shadowing.
7591 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7592 so that the caller can use some name other than gcpro1.
7593 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7594 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7595 (Fx_backspace_delete_keys_p):
7596 Use them to avoid shadowing, and rename vars to avoid shadowing.
7597 (x_decode_color, x_set_name, x_window): Now static.
7598 (Fx_create_frame): Add braces to silence GCC warning.
7599 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7600 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7601 Remove unused locals.
7602 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7603 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7604 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7607 * xterm.h (x_mouse_leave): New decl.
7609 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7610 Remove unused functions.
7611 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7612 (x_calc_absolute_position): Now static.
7613 (XTread_socket): Don't define label "out" unless it's used.
7614 Don't declare local "event" unless it's used.
7615 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7616 unless they are used.
7617 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7618 (x_fatal_error_signal): Remove; not used.
7619 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7620 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7621 (x_error_catcher, x_connection_closed, x_error_handler):
7622 (x_error_quitter, xembed_send_message, x_iconify_frame):
7623 (my_log_handler): Rename locals to avoid shadowing.
7624 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7625 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7627 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7628 Rename or move locals to avoid shadowing.
7629 (tty_defined_color, merge_face_heights): Now static.
7630 (free_realized_faces_for_fontset): Remove; not used.
7631 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7632 does not deduce is never used uninitialized.
7633 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7634 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7636 * terminal.c (store_terminal_param): Now static.
7638 * xmenu.c (menu_highlight_callback): Now static.
7639 (set_frame_menubar): Remove unused local.
7640 (xmenu_show): Rename parameter to avoid shadowing.
7641 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7642 since they might point to immutable storage.
7643 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7644 since it's unused otherwise.
7646 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7647 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7648 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7649 avoids a gcc -Wuninitialized diagnostic.
7650 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7651 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7652 does not deduce are never used uninitialized.
7654 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7656 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7657 * window.c (window_loop, size_window):
7658 (run_window_configuration_change_hook, enlarge_window): Likewise.
7660 * window.c (display_buffer): Now static.
7661 (size_window): Mark variables that gcc -Wuninitialized
7662 does not deduce are never used uninitialized.
7663 * window.h (check_all_windows): New decl, to forestall
7664 gcc -Wmissing-prototypes diagnostic.
7665 * dispextern.h (bidi_dump_cached_states): Likewise.
7667 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7669 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7671 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7672 and to avoid gcc -Wuninitialized warning.
7673 (load_charset_map): Mark variables that gcc -Wuninitialized
7674 does not deduce are never used uninitialized.
7675 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7677 * coding.c (coding_set_source, coding_set_destination):
7678 Use "else { /* comment */ }" rather than "else /* comment */;"
7679 for clarity, and to avoid gcc -Wempty-body warning.
7680 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7681 a block, when the outer 'i' will do.
7682 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7683 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7684 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7685 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7686 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7687 Rename locals to avoid shadowing.
7688 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7689 * coding.c (emacs_mule_char, encode_invocation_designation):
7690 Now static, since they're not used elsewhere.
7691 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7692 (decode_coding_object, encode_coding_object, detect_coding_system):
7693 (decode_coding_emacs_mule): Mark variables that gcc
7694 -Wuninitialized does not deduce are never used uninitialized.
7695 (detect_coding_iso_2022): Initialize a local variable that might
7696 be used uninitialized. Leave a FIXME because it's not clear that
7697 this initialization is needed. (Bug#8211)
7698 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7699 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7700 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7701 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7702 Remove unused macros.
7704 * category.c (hash_get_category_set): Remove unused local var.
7705 (copy_category_table): Now static, since it's not used elsewhere.
7706 * character.c (string_count_byte8): Likewise.
7708 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7709 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7711 * chartab.c (copy_sub_char_table): Now static, since it's not used
7713 (sub_char_table_ref_and_range, char_table_ref_and_range):
7714 Rename locals to avoid shadowing.
7715 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7717 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7718 (BIDI_BOB): Remove unused macro.
7720 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7721 deduce are never used uninitialized.
7722 * term.c (encode_terminal_code): Likewise.
7724 * term.c (encode_terminal_code): Now static. Remove unused local.
7726 * tparam.h: New file.
7727 * term.c, tparam.h: Include it.
7728 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7729 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7730 Move these decls to tparam.h, and make them agree with what
7731 is actually in tparam.c. The previous trick of using incompatible
7732 decls in different modules does not conform to the C standard.
7733 All callers of tparam changed to use tparam's actual API.
7734 * tparam.c (tparam1, tparam, tgoto):
7735 Use const pointers where appropriate.
7737 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7738 * cm.h (struct cm): Likewise.
7739 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7740 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7741 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7742 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7743 (turn_on_face, init_tty): Likewise.
7744 * termchar.h (struct tty_display_info): Likewise.
7746 * term.c (term_mouse_position): Rename local to avoid shadowing.
7748 * alloc.c (mark_ttys): Move decl from here ...
7749 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7751 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7753 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7755 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7757 * search.c (compile_pattern_1): Remove argument regp, unused since
7758 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7759 (compile_pattern): Don't pass it.
7761 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7763 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7764 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7766 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7768 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7770 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7771 gdk_window_get_screen, gdk_window_get_geometry,
7772 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7773 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7774 (xg_get_pixbuf_from_pixmap): New function.
7775 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7776 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7777 Call xg_get_pixbuf_from_pixmap instead of
7778 gdk_pixbuf_get_from_drawable.
7779 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7780 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7781 (xg_check_special_colors): Use GtkStyleContext and its functions
7783 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7784 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7785 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7786 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7787 Call gtk_widget_get_preferred_size.
7788 (xg_frame_resized): gdk_window_get_geometry only takes 5
7790 (xg_win_to_widget, xg_event_is_for_menubar):
7791 Call gdk_x11_window_lookup_for_display.
7792 (xg_set_widget_bg): New function.
7793 (delete_cb): New function.
7794 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7795 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7796 (xg_set_background_color): Call xg_set_widget_bg.
7797 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7798 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7799 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7800 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7802 (update_frame_tool_bar): Call gtk_widget_hide.
7803 (xg_initialize): Use GDK_KEY_g.
7805 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7807 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7809 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7810 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7811 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7813 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7815 * w32xfns.c (select_palette): Check success of RealizePalette against
7816 GDI_ERROR, not zero.
7818 See ChangeLog.11 for earlier changes.
7824 Copyright (C) 2011 Free Software Foundation, Inc.
7826 This file is part of GNU Emacs.
7828 GNU Emacs is free software: you can redistribute it and/or modify
7829 it under the terms of the GNU General Public License as published by
7830 the Free Software Foundation, either version 3 of the License, or
7831 (at your option) any later version.
7833 GNU Emacs is distributed in the hope that it will be useful,
7834 but WITHOUT ANY WARRANTY; without even the implied warranty of
7835 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7836 GNU General Public License for more details.
7838 You should have received a copy of the GNU General Public License
7839 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.