1 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3 * s/ms-w32.h (tzname): Include time.h before redirecting to
4 _tzname. Fixes the MSVC build. (Bug#9960)
6 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
11 * xterm.c (XTread_socket): Only modify handling_signal if
12 !SYNC_INPUT. (Bug#11080)
14 2012-03-23 Eli Zaretskii <eliz@gnu.org>
16 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
17 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
18 when fetching a multibyte character consumes more bytes than
19 CHAR_BYTES returns, due to unification of CJK characters in
20 string_char. (Bug#11073)
22 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
24 * process.c (wait_reading_process_output): Handle pty disconnect
25 by refraining from sending oneself a SIGCHLD (bug#10933).
27 2012-03-22 Chong Yidong <cyd@gnu.org>
29 * dispextern.h (struct it): New member string_from_prefix_prop_p.
31 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
32 Mark string as coming from a prefix property.
33 (handle_face_prop): Use default face for prefix strings (Bug#4281).
34 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
36 2012-03-21 Chong Yidong <cyd@gnu.org>
38 * xfaces.c (Vface_remapping_alist): Doc fix.
40 2012-03-20 Eli Zaretskii <eliz@gnu.org>
42 * w32proc.c (Fw32_set_console_codepage)
43 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
46 2012-03-20 Chong Yidong <cyd@gnu.org>
48 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
49 to reflect default non-nil value of redisplay-dont-pause.
51 2012-03-19 Kenichi Handa <handa@m17n.org>
53 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
54 it fit in a valid range (Bug#11003).
56 2012-03-18 Eli Zaretskii <eliz@gnu.org>
58 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
59 that is not from display property, accept the row as a "cursor
60 row" if one of the string's character has a non-nil `cursor'
61 property. Fixes cursor positioning when there are newlines in
62 overlay strings, e.g. in icomplete.el. (Bug#11035)
64 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
66 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
68 2012-03-12 Chong Yidong <cyd@gnu.org>
70 * eval.c (inhibit_lisp_code): Rename from
71 inhibit_window_configuration_change_hook; move from window.c.
73 * xfns.c (unwind_create_frame_1, Fx_create_frame):
74 * window.c (run_window_configuration_change_hook)
75 (syms_of_window): Callers changed.
77 2012-03-11 Chong Yidong <cyd@gnu.org>
79 * keymap.c (Fkey_description): Doc fix (Bug#9700).
81 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
83 2012-03-10 Chong Yidong <cyd@gnu.org>
85 * frame.c (other_visible_frames): Don't assume the selected frame
86 is visible (Bug#10955).
88 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
90 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
92 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
94 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
95 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
98 2012-03-03 Glenn Morris <rgm@gnu.org>
100 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
102 2012-03-02 Eli Zaretskii <eliz@gnu.org>
104 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
105 position past the first glyph_row that ends at ZV. (Bug#10902)
106 (redisplay_window, next_element_from_string): Fix typos in
108 (redisplay_window): Pass to move_it_vertically the margin in
109 pixels, not in screen lines.
111 2012-03-02 Glenn Morris <rgm@gnu.org>
113 * buffer.c (buffer-list-update-hook): Doc fix.
115 2012-02-29 Eli Zaretskii <eliz@gnu.org>
117 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
118 push_it before setting up the iterator for the first overlay
119 string, even if we have an empty string loaded.
120 (next_overlay_string): If there's an empty string on the iterator
121 stack, pop the stack. (Bug#10903)
123 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
125 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
126 Suggested by Stefan Monnier in
127 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
128 * alloc.c (widen_to_Lisp_Object): New static function.
129 (mark_memory): Also mark Lisp_Objects by fetching pointer words
130 and widening them to Lisp_Objects. This would work even if
131 USE_LSB_TAG is defined and wide integers are used, which might
132 happen in a future version of Emacs.
134 2012-02-25 Chong Yidong <cyd@gnu.org>
136 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
139 * xselect.c (Fx_selection_exists_p): Doc fix.
140 (x_clipboard_manager_save_all): Print an informative message
141 before saving to clipboard manager.
143 2012-02-24 Chong Yidong <cyd@gnu.org>
145 * keyboard.c (process_special_events): Handle all X selection
146 requests in kbd_buffer, not just the next one (Bug#8869).
148 2012-02-23 Chong Yidong <cyd@gnu.org>
150 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
151 call when setting menu-bar-lines and tool-bar-lines parameters.
152 (unwind_create_frame_1): New helper function.
154 * window.c (inhibit_window_configuration_change_hook): New var.
155 (run_window_configuration_change_hook): Obey it.
156 (syms_of_window): Initialize it.
158 2012-02-22 Chong Yidong <cyd@gnu.org>
160 * xterm.c (x_draw_image_relief): Add missing type check for
161 Vtool_bar_button_margin (Bug#10743).
163 2012-02-21 Chong Yidong <cyd@gnu.org>
165 * fileio.c (Vfile_name_handler_alist): Doc fix.
167 * buffer.c (Fget_file_buffer): Protect against invalid file
168 handler return value.
170 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
172 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
173 when computing $valmask.
175 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
176 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
177 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
178 It's useless in that case, and it can cause problems on hosts
179 that allocate halves of EMACS_INT values separately.
180 Reported by Dan Horák. Diagnosed by Andreas Schwab in
181 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
182 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
183 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
184 it avoids undefined behavior on hosts where shifting right by more
185 than the word width has undefined behavior.
187 2012-02-19 Chong Yidong <cyd@gnu.org>
189 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
190 (Funhandled_file_name_directory, Ffile_name_as_directory)
191 (Fdirectory_file_name, Fexpand_file_name)
192 (Fsubstitute_in_file_name): Protect against invalid file handler
193 return values (Bug#10845).
195 2012-02-18 Eli Zaretskii <eliz@gnu.org>
197 * .gdbinit (pitx): Fix incorrect references to fields of the
200 2012-02-17 Chong Yidong <cyd@gnu.org>
202 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
204 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
206 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
207 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
209 2012-02-15 Chong Yidong <cyd@gnu.org>
211 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
212 marked as special. Also, starting docstrings with * is obsolete.
214 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
216 * gnutls.c (emacs_gnutls_write): Fix last change.
218 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
220 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
223 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
225 * keymap.c (Fsingle_key_description): Handle char ranges.
227 2012-02-12 Chong Yidong <cyd@gnu.org>
229 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
230 as that creates a dangerous corner case.
232 * window.c (Fdelete_window_internal): Invalidate the mouse
233 highlight (Bug#9904).
235 2012-02-12 Glenn Morris <rgm@gnu.org>
237 * xselect.c (Fx_own_selection_internal)
238 (Fx_get_selection_internal, Fx_disown_selection_internal)
239 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
240 * nsselect.m (Fx_own_selection_internal)
241 (Fx_disown_selection_internal, Fx_selection_exists_p)
242 (Fx_selection_owner_p, Fx_get_selection_internal):
243 Sync docs and argument specs with the xselect.c versions.
245 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
247 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
249 2012-02-11 Eli Zaretskii <eliz@gnu.org>
251 * w32select.c (Fx_selection_exists_p): Sync doc string and
252 argument list with xselect.c. (Bug#10783)
254 * w16select.c (Fx_selection_exists_p): Sync doc string and
255 argument list with xselect.c. (Bug#10783)
257 2012-02-10 Glenn Morris <rgm@gnu.org>
259 * fns.c (Fsecure_hash): Doc fix.
261 2012-02-09 Kenichi Handa <handa@m17n.org>
263 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
265 2012-02-07 Chong Yidong <cyd@gnu.org>
267 * buffer.c (Fbuffer_local_variables)
268 (buffer_lisp_local_variables): Handle unbound vars correctly;
269 don't let Qunbound leak into Lisp.
271 2012-02-07 Glenn Morris <rgm@gnu.org>
273 * image.c (Fimagemagick_types): Doc fix.
275 * image.c (imagemagick-render-type): Change it from a lisp object
276 to an integer. Move the doc here from the lisp manual.
277 Treat all values not equal to 0 the same.
279 2012-02-06 Chong Yidong <cyd@gnu.org>
281 * doc.c (store_function_docstring): Avoid applying docstring of
282 alias to base function (Bug#2603).
284 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
286 * .gdbinit (pp1, pv1): Remove redundant defines.
289 2012-02-04 Chong Yidong <cyd@gnu.org>
291 * nsterm.m: Declare a global (Bug#10694).
293 2012-02-04 Eli Zaretskii <eliz@gnu.org>
295 * w32.c (get_emacs_configuration_options):
296 Include --enable-checking, if specified, in the return value.
298 2012-02-04 Martin Rudalics <rudalics@gmx.at>
300 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
301 after rounding frame sizes. (Bug#9723)
303 2012-02-04 Eli Zaretskii <eliz@gnu.org>
305 * keyboard.c (adjust_point_for_property): Don't position point
306 before BEGV. (Bug#10696)
308 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
310 Handle overflow when computing char display width (Bug#9496).
311 * character.c (char_width): Return EMACS_INT, not int.
312 (char_width, c_string_width): Check for overflow when
313 computing the width; this is possible now that individual
314 characters can have unbounded width. Problem introduced
315 by merge from Emacs 23 on 2012-01-19.
317 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
319 * dbusbind.c (Fdbus_register_method): Mention the return value
320 :ignore in the docstring.
322 2012-02-02 Glenn Morris <rgm@gnu.org>
324 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
326 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
327 Unconditionally set to t. (Bug#10673)
328 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
329 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
330 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
332 2012-02-02 Kenichi Handa <handa@m17n.org>
334 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
335 0, do not call append_composite_glyph.
337 2012-02-02 Kenichi Handa <handa@m17n.org>
339 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
341 (x_produce_glyphs): If the component of a composition is a null
342 string, set it->pixel_width to 1 to avoid zero-width glyph.
344 2012-02-01 Eli Zaretskii <eliz@gnu.org>
346 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
347 first 2 arguments are identical. This makes inserting large
348 output from a subprocess an order of magnitude faster on
349 MS-Windows, where all sbrk'ed memory is always contiguous.
351 2012-01-31 Glenn Morris <rgm@gnu.org>
353 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
354 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
355 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
357 2012-01-29 Glenn Morris <rgm@gnu.org>
359 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
361 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
363 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
365 2012-01-28 Chong Yidong <cyd@gnu.org>
367 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
369 2012-01-26 Chong Yidong <cyd@gnu.org>
371 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
373 * search.c (Fsearch_forward, Fsearch_backward): Document negative
374 repeat counts (Bug#10507).
376 2012-01-26 Glenn Morris <rgm@gnu.org>
378 * lread.c (syms_of_lread): Doc fix.
380 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
382 * coding.c (encode_designation_at_bol): Change return value to
385 2012-01-25 Chong Yidong <cyd@gnu.org>
387 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
389 2012-01-21 Chong Yidong <cyd@gnu.org>
391 * floatfns.c (Fcopysign): Make the second argument non-optional,
392 since nil is not allowed anyway.
394 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
396 * process.c (read_process_output): Use p instead of XPROCESS (proc).
397 (send_process): Likewise.
399 2012-01-19 Martin Rudalics <rudalics@gmx.at>
401 * window.c (save_window_save, Fcurrent_window_configuration)
402 (Vwindow_persistent_parameters): Do not use Qstate.
405 2012-01-19 Kenichi Handa <handa@m17n.org>
407 * character.c (char_width): New function.
408 (Fchar_width, c_string_width, lisp_string_width):
409 Use char_width (Bug#9496).
411 2012-01-16 Martin Rudalics <rudalics@gmx.at>
413 * window.c (Vwindow_persistent_parameters): New variable.
414 (Fset_window_configuration, save_window_save): Handle persistent
417 2012-01-14 Eli Zaretskii <eliz@gnu.org>
419 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
420 thrashing the stack of the thread. (Bug#9087)
422 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
424 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
426 2012-01-11 Eli Zaretskii <eliz@gnu.org>
428 * xdisp.c (rows_from_pos_range): Handle the case where the
429 highlight ends on a newline. (Bug#10464)
430 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
431 he end column for display of highlight that ends on a newline
434 2012-01-11 Glenn Morris <rgm@gnu.org>
436 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
437 from load-path also when installation-directory is nil. (Bug#10208)
439 2012-01-10 Glenn Morris <rgm@gnu.org>
441 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
443 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
444 Update template values to be closer to their typical values these days.
446 2012-01-09 Eli Zaretskii <eliz@gnu.org>
448 * xdisp.c (rows_from_pos_range): Accept additional argument
449 DISP_STRING, and accept any glyph in a row whose object is that
450 string as eligible for mouse highlight. Fixes mouse highlight of
451 display strings from overlays. (Bug#10464)
453 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
455 emacs: fix an auto-save permissions race condition (Bug#10400)
456 * fileio.c (auto_saving_dir_umask): New static var.
457 (Fmake_directory_internal): Use it.
458 (do_auto_save_make_dir): Set it, instead of invoking chmod after
459 creating the directory. The old code temporarily assigns
460 too-generous permissions to the directory.
461 (do_auto_save_eh): Clear it.
462 (Fdo_auto_save): Catch all errors, not just file errors, so
463 that the var is always cleared.
465 2012-01-07 Eli Zaretskii <eliz@gnu.org>
467 * search.c (scan_buffer): Pass character positions to
468 know_region_cache, not byte positions. (Bug#6540)
470 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
472 * w32.c (sys_rename): Report EXDEV when rename of a directory
473 fails because the target is on another logical disk. (Bug#10284)
475 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
477 * xterm.c (x_embed_request_focus): New function.
479 * xterm.h: Add prototype.
481 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
483 2012-01-05 Glenn Morris <rgm@gnu.org>
485 * emacs.c (emacs_copyright): Update short copyright year to 2012.
487 2012-01-01 Eli Zaretskii <eliz@gnu.org>
489 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
490 Load gnutls_transport_set_lowat only if GnuTLS version is below
492 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
493 GnuTLS versions below 2.11.1.
495 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
497 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
498 to the doc string advising against its use for altering the way
499 windows are scrolled.
501 2011-12-28 Kenichi Handa <handa@m17n.org>
503 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
504 coding-system ASCII compatible only when it does not produce BOM
505 on encoding (Bug#10383).
507 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
509 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
511 (create_and_show_popup_menu): Always use menu_position_func for
514 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
516 * callint.c (Fcall_interactively): Don't truncate prompt string.
518 2011-12-23 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
521 property that ends at ZV, so that the bidi iteration could be
522 resumed from there (after widening). (Bug#10360)
524 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
526 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
528 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
530 * nsterm.m (x_free_frame_resources):
531 Release f->output_data.ns->miniimage.
532 (ns_index_color): Fix indentation. Do not retain
533 color_table->colors[i].
535 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
538 * nsfns.m (x_set_background_color): Assign return value from
539 ns_index_color to face-background instead of NSColor*.
540 (ns_implicitly_set_icon_type): Fix indentation.
541 Change assignment in for loop to comparison.
543 * emacs.c (ns_pool): New variable.
544 (main): Assign ns_pool.
545 (Fkill_emacs): Call ns_release_autorelease_pool.
547 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
548 autorelease fdesc, release fdAttrs and tdict.
549 (ns_get_covering_families): Release charset.
550 (ns_findfonts): Release NSFontDescriptor created with new.
551 (ns_uni_to_glyphs): Fix indentation.
552 (setString): Release attrStr before assigning new value.
554 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
556 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
558 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
559 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
561 2011-12-18 David Reitter <reitter@cmu.edu>
563 * nsterm.m (ns_term_init): Subscribe for notifications
564 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
565 to method trackingNotification in EmacsMenu.
567 * nsmenu.m (trackingMenu): New variable.
568 (trackingNotification): New method (from Aquamacs).
569 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
570 from Aquamacs (Bug#7030).
572 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
574 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
575 (symbol_to_nsstring): Fix indentation.
576 (ns_symbol_to_pb): New function.
577 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
578 (Fns_rotate_cut_buffers_internal): Remove.
579 (Fns_store_selection_internal): Rename from
580 Fns_store_cut_buffer_internal.
581 (ns_get_foreign_selection, Fx_own_selection_internal)
582 (Fx_disown_selection_internal, Fx_selection_exists_p)
583 (Fns_get_selection_internal, Fns_store_selection_internal):
584 Use ns_symbol_to_pb and check if return value is nil.
585 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
586 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
587 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
588 renamed to Sns_store_selection_internal.
589 (ns_handle_selection_request): Move code to Fx_own_selection_internal
590 and remove this function.
591 (ns_handle_selection_clear): Remove, never used.
592 (Fx_own_selection_internal): Move code from ns_handle_selection_request
595 2011-12-17 Ken Brown <kbrown@cornell.edu>
597 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
598 GID is unknown (Bug#10257).
600 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
602 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
603 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
604 which caused a build failure on GNU/Linux IA-64. This problem was
605 introduced by my 2011-10-07 patch.
607 2011-12-15 Juri Linkov <juri@jurta.org>
609 * image.c (imagemagick_error): New function. (Bug#10112)
610 (imagemagick_load_image): Comment out `MagickSetResolution' call.
611 Use `imagemagick_error' where ImageMagick functions return
613 (Fimagemagick_types): Add `Fnreverse' to return the list in the
616 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
618 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
619 fill background (Bug#8992).
621 2011-12-13 Martin Rudalics <rudalics@gmx.at>
623 * window.c (Vwindow_combination_resize)
624 (Vwindow_combination_limit): Use t instead of non-nil in
626 (Vrecenter_redisplay): Add first sentence of doc-string on
628 (Frecenter): Fix doc-string typo.
630 2011-12-11 Kenichi Handa <handa@m17n.org>
632 * coding.c (Funencodable_char_position): Pay attention to the
633 buffer text relocation (Bug#9389).
635 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
637 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
638 gtk_init (Bug#10100).
640 2011-12-10 Eli Zaretskii <eliz@gnu.org>
642 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
643 IT->string is nil. (Bug#10263)
645 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
647 * nsterm.h (x_free_frame_resources): Declare.
649 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
650 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
652 * nsterm.h (ns_get_defaults_value): Declare.
654 * nsterm.m (ns_default): Call ns_get_defaults_value.
656 2011-12-09 Eli Zaretskii <eliz@gnu.org>
658 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
661 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
663 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
664 that where the value of an _OBJC_* symbol points to is in the .bss
667 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
669 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
670 after the loop to call ccl_driver at least once (Bug#8619).
672 2011-12-08 Kenichi Handa <handa@m17n.org>
674 * ftfont.c (get_adstyle_property): Fix previous change
677 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
679 * w32.c (init_environment): If no_site_lisp, remove site-lisp
680 dirs from the default value of EMACSLOADPATH (bug#10208).
682 2011-12-07 Glenn Morris <rgm@gnu.org>
684 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
685 installation and source directories as well. (Bug#10208)
687 2011-12-06 Chong Yidong <cyd@gnu.org>
689 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
691 2011-12-06 Glenn Morris <rgm@gnu.org>
693 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
694 as an error, not just -1. (Bug#10217)
696 2011-12-05 Chong Yidong <cyd@gnu.org>
698 * keyboard.c (process_special_events): New function.
699 (swallow_events, Finput_pending_p): Use it (Bug#10195).
701 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
703 * coding.c (encode_designation_at_bol): Don't use uninitialized
704 local variable (Bug#9318).
706 2011-12-05 Kenichi Handa <handa@m17n.org>
708 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
709 return Qnil (Bug#8046, Bug#10193).
711 2011-12-05 Kenichi Handa <handa@m17n.org>
713 * coding.c (encode_designation_at_bol): New args charbuf_end and
714 dst. Return the number of produced bytes. Callers changed.
715 (coding_set_source): Return how many bytes coding->source was
717 (coding_set_destination): Return how many bytes
718 coding->destination was relocated.
719 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
720 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
722 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
724 * coding.c (CODING_CHAR_CHARSET_P): New macro.
725 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
728 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
730 The following changes are to fix Bug#9318.
732 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
733 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
734 (encode_coding_iso_2022, encode_coding_sjis)
735 (encode_coding_big5, encode_coding_charset): Use the above macros.
737 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
739 * lisp.h (process_quit_flag): Fix external declaration.
741 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
743 Don't macro-inline non-performance-critical code.
744 * eval.c (process_quit_flag): New function.
745 * lisp.h (QUIT): Use it.
747 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
749 * nsfns.m (get_geometry_from_preferences): New function.
750 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
752 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
754 * emacs.c (Qkill_emacs): Define.
755 (syms_of_emacs): Initialize it.
756 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
757 Qquit_flag to `kill-emacs' instead.
758 (quit_throw_to_read_char): Add parameter `from_signal'.
759 All callers changed. Call Fkill_emacs if requested and safe.
760 * lisp.h (QUIT): Call Fkill_emacs if requested.
762 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
764 * widget.c (update_wm_hints): Return if wmshell is null.
765 (widget_update_wm_size_hints): New function.
767 * widget.h (widget_update_wm_size_hints): Declare.
769 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
770 widget_update_wm_size_hints (Bug#10104).
772 2011-12-03 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (handle_invisible_prop): If the invisible text ends just
775 before a newline, prepare the bidi iterator for consuming the
776 newline, and keep the current paragraph direction. (Bug#10183)
777 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
779 2011-12-02 Juri Linkov <juri@jurta.org>
781 * search.c (Fword_search_regexp): New Lisp function created from
782 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
783 (Fword_search_backward, Fword_search_forward)
784 (Fword_search_backward_lax, Fword_search_forward_lax):
785 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
786 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
788 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
790 * fileio.c (Finsert_file_contents): Move after-change-function call
791 to before the "handled:" label, since all "goto handled" appear in
792 cases where the *-change-functions have already been properly called
795 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
797 * keyboard.c (interrupt_signal): Don't call kill-emacs when
798 waiting for input. (Bug#10169)
800 2011-11-30 Eli Zaretskii <eliz@gnu.org>
802 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
803 verifies glyph row's hash code--we have just reallocated the
804 glyphs, so their contents can be complete garbage. (Bug#10164)
806 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
808 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
810 2011-11-30 Eli Zaretskii <eliz@gnu.org>
812 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
813 attributes are tested _before_ calling verify_row_hash, to protect
814 against GCC re-ordering of the tests. (Bug#10164)
816 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
818 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
820 * xterm.c (handle_one_xevent): Only set async_visible and friends
821 if net_wm_state_hidden_seen is non-zero (Bug#10002)
822 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
823 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
825 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
827 Remove GCPRO-related macros that exist only to avoid shadowing locals.
828 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
829 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
830 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
831 All uses changed to use GCPRO1 etc.
832 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
833 Revert to old implementation (i.e., before 2011-03-11).
835 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
837 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
838 of scroll runs so as to avoid assigning disabled bogus rows and
839 unnecessary graphics copy operations.
841 2011-11-27 Eli Zaretskii <eliz@gnu.org>
843 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
844 (snprintf) [_MSC_VER]: Redirect to _snprintf.
845 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
846 (malloc, free, realloc, calloc): Redirect to e_* only when
849 * lisp.h (GCTYPEBITS): Move before first use.
850 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
851 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
852 this macro definition.
854 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
857 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
859 * gtkutil.c (xg_create_frame_widgets):
860 Call gtk_window_set_has_resize_grip (FALSE) if that function is
861 present with Gtk+ 2.0.
863 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
865 * fileio.c (Finsert_file_contents): Undo previous change; see
866 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
868 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
870 Rename locals to avoid shadowing.
871 * fileio.c (Finsert_file_contents):
872 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
873 * process.c (wait_reading_process_output):
874 Rename inner 'proc' to 'p' to avoid shadowing.
875 Indent for consistency with usual Emacs style.
877 2011-11-25 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (redisplay_window): If cursor row is not fully visible
880 after recentering, and scroll-conservatively is set to a large
881 number, scroll window by a few more lines to make the cursor fully
882 visible and out of scroll-margin. (Bug#10105)
883 (start_display): Don't move to the next line if the display should
884 start at a newline that is part of a display vector or an overlay
887 2011-11-24 Juri Linkov <juri@jurta.org>
889 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
890 after the `MagickPingImage' call. (Bug#10112)
892 2011-11-23 Chong Yidong <cyd@gnu.org>
894 * window.c (Fcoordinates_in_window_p): Accept only live windows.
896 2011-11-23 Martin Rudalics <rudalics@gmx.at>
898 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
899 making another buffer current. (Bug#10114)
901 2011-11-23 Glenn Morris <rgm@gnu.org>
903 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
905 2011-11-23 Chong Yidong <cyd@gnu.org>
907 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
910 2011-11-22 Eli Zaretskii <eliz@gnu.org>
912 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
913 and header-lines, as they don't have one computed for them.
916 * .gdbinit (prow): Make displayed values more self-explaining.
919 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
921 * process.c (wait_reading_process_output): Fix asynchrounous
922 GnuTLS socket handling on some versions of the GnuTLS library.
923 (wait_reading_process_output): Add comment and URL.
925 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
927 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
929 2011-11-21 Chong Yidong <cyd@gnu.org>
931 * window.c (Fnext_window, Fprevious_window): Doc fix.
933 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
935 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
937 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
939 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
941 2011-11-20 Martin Rudalics <rudalics@gmx.at>
943 * window.c (Fset_window_combination_limit): Rename argument
945 (Vwindow_combination_limit): Remove "status" from doc-string.
947 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
949 * m/ibms390.h: Remove.
950 * m/ibms390x.h: Don't include "ibms390.h".
952 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
954 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
955 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
957 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
959 * casetab.c (Fset_case_table):
960 * charset.c (Fcharset_after): Fix typos.
962 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
964 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
965 Otherwise, valgrind does not work on some platforms.
966 Problem reported by Andreas Schwab in
967 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
968 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
969 is set, removing the need for VIRT_ADDRESS_VARIES.
970 (PURE_P): Use a more-efficient implementation that needs just one
971 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
972 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
973 to 4 (xorl, subq, cmpq, setbe).
974 * alloc.c (pure): Always extern now, since that's the
975 VIRT_ADDR_VARIES behavior.
976 (PURE_POINTER_P): Use a single comparison, not two, for
977 consistency with the new puresize.h.
978 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
979 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
980 Remove VIRT_ADDR_VARIES no longer needed.
982 2011-11-19 Eli Zaretskii <eliz@gnu.org>
984 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
985 (erase_phys_cursor, update_window_cursor, show_mouse_face)
986 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
987 behave as if the cursor position were at the window margin.
989 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
990 and the cursor position is out of bounds, behave as if the cursor
991 position were at the window margin. (Bug#10075)
993 2011-11-18 Chong Yidong <cyd@gnu.org>
995 * window.c (Fwindow_combination_limit): Make first argument
996 non-optional, since it is meaningless for live windows like the
999 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1001 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1003 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1005 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1006 (graft_intervals_into_buffer): Simplify.
1008 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1010 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1011 hash values of the two rows.
1012 (copy_row_except_pointers): Preserve the used[] arrays and the
1013 hash values of the two rows. (Bug#10035)
1014 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1016 * xdisp.c (row_hash): New function, body extracted from
1017 compute_line_metrics.
1018 (compute_line_metrics): Call row_hash, instead of computing the
1021 * dispnew.c (verify_row_hash): Call row_hash for computing the
1022 hash code of a row, instead of duplicating code from xdisp.c.
1024 * dispextern.h (row_hash): Add prototype.
1026 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1028 * frame.c (delete_frame): Don't delete the terminal when the last
1029 X frame is closed if emacs is built with GTK toolkit.
1031 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1033 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1035 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1037 * window.c (Vwindow_splits): Rename to
1038 Vwindow_combination_resize. Suggested by Juri Linkov.
1039 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1042 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1044 * nsfns.m (Fns_font_name):
1045 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1047 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1049 * window.h (window): Rename slot "nest" to "combination_limit".
1050 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1051 (Fset_window_nest): Rename to Fset_window_combination_limit.
1052 (Vwindow_nest): Rename to Vwindow_combination_limit.
1053 (recombine_windows, make_parent_window, make_window)
1054 (Fsplit_window_internal, saved_window)
1055 (Fset_window_configuration, save_window_save): Rename all
1056 occurrences of window_nest to window_combination_limit.
1058 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1060 * image.c (imagemagick_load_image): Fix typo.
1062 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1064 * xdisp.c (display_line): Move the call to
1065 highlight_trailing_whitespace before the call to
1066 compute_line_metrics, since the latter needs to see the final
1067 faces of all the glyphs to compute ROW's hash value.
1068 Fixes assertion violations in row_equal_p. (Bug#10035)
1070 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1072 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1073 just return (bug#10044).
1075 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1077 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1078 with user-defined heap size. Bump the default size of the temacs
1079 heap to 27MB, to avoid memory warning when running temacs.
1080 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1082 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1083 current_matrix and desired_matrix. (Bug#9990)
1084 (verify_row_hash) [XASSERTS]: New function.
1085 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1086 that the hash value of glyph rows is correct.
1088 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1090 * window.h (window): Remove splits slot.
1091 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1092 (Fdelete_other_windows_internal, make_parent_window)
1093 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1094 (Fset_window_configuration, save_window_save): Don't deal with
1095 split status of windows.
1096 (saved_window): Remove splits slot.
1097 (Vwindow_splits): Rewrite doc-string.
1099 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1101 * xfns.c (unwind_create_frame):
1102 * nsfns.m (unwind_create_frame):
1103 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1104 Vframe_list (Bug#9999).
1106 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1108 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1110 2011-11-11 Kenichi Handa <handa@m17n.org>
1112 * callproc.c (Fcall_process): Set the member dst_multibyte of
1115 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1117 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1118 avoid a crash (bug#9496).
1120 2011-11-09 Chong Yidong <cyd@gnu.org>
1122 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1123 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1125 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1127 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1129 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1131 Avoid some portability problems by eschewing 'extern inline' functions.
1132 The trivial performance wins aren't worth the portability hassles; see
1133 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1135 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1136 (window_box_width, window_box_left, window_box_left_offset)
1137 (window_box_right, window_box_right_offset): Undo previous change,
1138 by removing the "extern"s.
1139 * intervals.c (adjust_intervals_for_insertion)
1140 (adjust_intervals_for_deletion): Undo previous change,
1141 making these static again.
1142 (offset_intervals, temp_set_point_both, temp_set_point)
1143 (copy_intervals_to_string): No longer inline.
1144 * xdisp.c (window_text_bottom_y, window_box_width)
1145 (window_box_height, window_box_left_offset)
1146 (window_box_right_offset, window_box_left, window_box_right)
1147 (window_box): No longer inline.
1149 2011-11-08 Chong Yidong <cyd@gnu.org>
1151 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1152 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1153 Signal an error if not a live window.
1154 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1155 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1157 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1159 * lisp.h (syms_of_abbrev): Remove declaration.
1160 Reported by CHENG Gao <chenggao@royau.me>.
1162 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1164 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1165 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1166 of temacs in GUI mode.
1168 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1170 * window.h: Declare delete_all_child_windows instead of
1171 delete_all_subwindows.
1172 * window.c (Fwindow_nest, Fset_window_nest)
1173 (Fset_window_new_total, Fset_window_new_normal)
1174 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1175 (delete_all_subwindows): Rename to delete_all_child_windows.
1176 (Fdelete_other_windows_internal, Fset_window_configuration):
1177 Call delete_all_child_windows instead of delete_all_subwindows.
1178 * frame.c (delete_frame): Call delete_all_child_windows instead
1179 of delete_all_subwindows.
1181 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1183 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1184 This is also needed for porting to any host where GC_MARK_STACK is
1185 not GC_MAKE_GCPROS_NOOPS.
1186 (which_symbols): Use it.
1188 2011-11-07 Kenichi Handa <handa@m17n.org>
1190 * coding.c (coding_set_destination): Check coding->src_pos only
1191 when coding->src_object is a buffer (bug#9910).
1193 * process.c (send_process): Set the member src_multibyte of coding
1194 to 0 (bug#9911) when sending a unibyte text.
1196 * callproc.c (Fcall_process): Set the member src_multibyte of
1197 process_coding to 0 (bug#9912).
1199 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1201 * xmenu.c (cleanup_widget_value_tree): New function.
1202 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1203 calling free_menubar_widget_value_tree directly (Bug#9830).
1205 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1207 Fix some portability problems with 'inline'.
1208 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1209 (window_box_width, window_box_left, window_box_left_offset)
1210 (window_box_right, window_box_right_offset): Declare extern.
1211 Otherwise, these inline functions do not conform to C99 and
1212 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1213 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1214 * intervals.c (adjust_intervals_for_insertion)
1215 (adjust_intervals_for_deletion): Now extern, because otherwise the
1216 extern inline functions 'offset_intervals' couldn't refer to it.
1217 (static_offset_intervals): Remove.
1218 (offset_intervals): Rewrite using the old contents of
1219 static_offset_intervals. The old version didn't conform to C99
1220 because an extern inline function contained a reference to an
1221 identifier with static linkage.
1223 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1225 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1228 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1231 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1232 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1233 return Qleft_to_right.
1235 2011-11-06 Chong Yidong <cyd@gnu.org>
1237 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1238 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1239 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1240 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1241 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1242 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1243 (Fwindow_vscroll): Doc fix.
1244 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1245 argument, since it makes no sense to pass a live window and for
1246 consistency with window-child.
1248 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1250 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1253 2011-11-05 Jason Rumney <jasonr@gnu.org>
1255 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1256 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1258 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1259 bitwise arithmetic preventing use of unicode-sip and non-truetype
1262 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1264 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1267 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1268 initialization code to keep similarity to xfns.c after changes
1271 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1273 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1274 (unwind_create_frame): New function (Bug#9943).
1275 (Fx_create_frame): Restructure code to be more similar to the one in
1276 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1277 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1278 Move terminal->reference_count++ just before making the frame official
1281 * nsterm.m (x_free_frame_resources): New function.
1282 (x_destroy_window): Move code to x_free_frame_resources.
1284 * xfns.c (unwind_create_frame): Fix comment.
1285 (Fx_create_frame, x_create_tip_frame):
1286 Move terminal->reference_count++ just before making the frame
1287 official. Move initialization of image_cache_refcount and
1288 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1290 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1292 Support MSVC build with newer versions of Visual Studio.
1293 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1294 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1297 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1298 which are not supported by MSVC.
1299 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1300 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1302 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1304 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1306 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1308 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1310 Support MSVC build with newer versions of Visual Studio.
1311 * w32.c: Don't include w32api.h for MSVC.
1312 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1314 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1315 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1316 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1317 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1319 (alloca) [_MSC_VER]: Define to _alloca.
1321 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1323 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1325 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1327 * xdisp.c (note_mouse_highlight): If either of
1328 previous/next-single-property-change returns nil, treat that as
1329 the beginning or the end of the buffer. (Bug#9955)
1331 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1333 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1334 label is not null (Bug#9951).
1335 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1338 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1340 * window.c (Fwindow_body_size): Mention in the doc string that the
1341 return value is in frame's canonical units. (Bug#9949)
1343 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1345 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1347 * w32fns.c (unwind_create_frame): If needed, free the glyph
1348 matrices of the partially constructed frame. (Bug#9943)
1349 * xfns.c (unwind_create_frame): Likewise.
1351 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1353 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1354 Don't stop backward scan on the continuation glyph, even though
1355 its CHARPOS is positive.
1356 (mouse_face_from_buffer_pos, note_mouse_highlight):
1357 Rename cover_string to disp_string.
1359 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1361 * window.c (temp_output_buffer_show): Don't use
1362 Vtemp_buffer_show_specifiers.
1363 (Vtemp_buffer_show_specifiers): Remove unused variable.
1365 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1367 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1368 past the beginning of the current glyph matrix.
1370 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1372 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1373 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1374 HAVE_GTK3 (Bug#9869).
1376 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1377 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1379 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1381 * xterm.c: Declare x_handle_net_wm_state to return int.
1382 (handle_one_xevent): Check if we are iconified but don't have
1383 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1384 (get_current_wm_state): Return non-zero if not hidden,
1385 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1386 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1387 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1388 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1390 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1392 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1393 so that this new function doesn't get optimized away by a
1394 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1396 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1398 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1400 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1402 Fix the `xbytecode' command.
1403 * .gdbinit (xprintbytestr): New command.
1404 (xwhichsymbols): Rename from `which'; all callers changed.
1405 (xbytecode): Print the byte-code string as well.
1407 2011-10-29 Kim Storm <storm@cua.dk>
1409 * alloc.c (which_symbols): New function.
1411 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1413 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1416 2011-10-29 Glenn Morris <rgm@gnu.org>
1418 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1419 Not clear what it was for, and it causes various bugs. (Bug#9839)
1421 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1423 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1424 possible random value that matches one of those tested as
1425 condition to clear the mouse face.
1427 2011-10-28 Chong Yidong <cyd@gnu.org>
1429 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1431 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1433 * window.c (make_window): Initialize phys_cursor_on_p.
1435 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1437 * lisp.h (struct Lisp_Symbol): Update comments.
1439 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1441 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1443 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1445 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1446 <oslsachem@gmail.com> for helping to debug this.
1448 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1449 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1450 (g_b_init_get_glyph_outline_w): New static variables.
1451 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1452 (GetGlyphOutlineW_Proc): New typedefs.
1453 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1454 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1456 (w32font_open_internal, compute_metrics):
1457 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1458 instead of calling the "wide" APIs directly.
1460 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1462 * w32.h (syms_of_w32font): Add prototype.
1464 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1466 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1467 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1468 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1469 (Fmove_to_window_line): Doc fix.
1471 2011-10-27 Chong Yidong <cyd@gnu.org>
1473 * process.c (make_process): Set gnutls_state to NULL.
1475 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1476 non-NULL, regardless of GNUTLS_INITSTAGE.
1477 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1478 an error. Set process slots as soon as we allocate them.
1480 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1482 2011-10-27 Chong Yidong <cyd@gnu.org>
1484 * gnutls.c (emacs_gnutls_deinit): New function.
1485 Deallocate credentials structures as well as calling gnutls_deinit.
1486 (Fgnutls_deinit, Fgnutls_boot): Use it.
1488 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1489 (deactivate_process): Call emacs_gnutls_deinit.
1491 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1493 * image.c (x_create_x_image_and_pixmap):
1494 * w32.c (sys_rename, w32_delayed_load):
1495 * w32font.c (fill_in_logfont):
1496 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1498 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1500 * w32fns.c (w32_default_color_map): New function,
1501 extracted from Fw32_default_color_map.
1502 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1504 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1506 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1508 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1510 * keyboard.c (test_undefined): New function (bug#9751).
1511 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1513 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1515 * sysdep.c (init_sys_modes): Fix the check for the controlling
1516 terminal (Bug#6649).
1518 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1520 * dispextern.h (struct bidi_it): New member next_en_type.
1522 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1523 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1524 current character, check also for next_en_type being WEAK_EN.
1525 (bidi_resolve_weak): Don't enter the expensive loop if the current
1526 position is before next_en_pos. Record the bidi type of the first
1527 non-ET, non-BN character we find, in addition to its position.
1528 (bidi_level_of_next_char): Invalidate next_en_type when
1529 next_en_pos is over-stepped.
1531 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1533 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1534 * editfns.c: Rewrite current-time-zone so that it invokes
1535 the equivalent of (format-time-string "%Z") to get the time zone name.
1536 This fixes a bug when the time zone name contains characters that
1537 need converting from the system time locale to Emacs internal format.
1538 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1539 that patch fixed format-time-string to do the conversion, but
1540 I forgot to fix current-time-zone.
1541 (format_time_string): New function, containing most of
1542 what Fformat_time_string used to contain.
1543 (Fformat_time_string): Rewrite in terms of format_time_string.
1544 This doesn't change this function's behavior.
1545 (current-time-zone): Rewrite to use format_time_string.
1546 This fixes the bug reported by Michael Schierl in
1547 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1548 Jason Rumney's 2007-06-07 change worked around this bug, but
1550 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1552 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1554 * xdisp.c (start_display): If the character at POS is displayed
1555 via a display vector, reset IT->current.dpvec_index to zero.
1556 (try_window_reusing_current_matrix): If a line ends in a display
1557 vector or the next line starts in a display vector, continue
1558 redrawing the window even though the character position of
1559 start_row was reached.
1562 2011-10-18 Chong Yidong <cyd@gnu.org>
1564 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1565 with nobreak-char-display too.
1567 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1569 Fix part 3 of bug#9771.
1570 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1571 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1572 non-neutral characters if the current character is a paragraph
1573 separator (a.k.a. Newline). This avoids running the same
1574 expensive loop twice, once when we consume the preceding newline
1575 and the other time when the line actually needs to be displayed.
1576 Avoid the loop when we see neutrals on the base embedding level
1577 following a character whose directionality is the same as the
1578 paragraph's. This avoids running the expensive loop when a line
1579 ends in a long sequence of neutrals, like control characters.
1580 Add assertion against STRONG_AL type. Slightly rearrange code
1581 that determines the type of a neutral given the first non-neutral
1583 (bidi_level_of_next_char): Set next_en_pos to zero when
1584 invalidating its info.
1586 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1588 * xdisp.c (push_display_prop): Determine whether to record string
1589 or buffer position by IT->string, not by IT->method. Allow
1590 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1591 (move_it_vertically_backward): Don't look for character position
1592 immediately after the newline when in a continuation line.
1595 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1597 * window.c (coordinates_in_window): Rewrite and delabelize
1598 vertical border check. (Bug#5357) (Bug#9618)
1600 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1602 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1603 errors in XSetWindowBorder (bug#9310).
1605 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1607 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1608 avoid crash when xmalloc overrun checking is enabled.
1610 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1612 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1613 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1614 cursor motion with <left> and <right> arrow keys.
1616 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1617 some callers set that themselves.
1619 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1621 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1622 display string and the previous row comes from the same string and
1623 is empty. (Bug#9739) (Bug#9738)
1625 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1627 * doc.c (get_doc_string): Encode file name (bug#9735).
1629 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1631 * bidi.c (bidi_level_of_next_char):
1632 * xdisp.c (get_visually_first_element): Remove old incorrect
1633 comments regarding the Unicode Line Separator character.
1635 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1637 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1639 * alloc.c (Fgc_status): Do not access beyond zombies array
1640 boundary if nzombies > MAX_ZOMBIES.
1641 * alloc.c (dump_zombies): Add missing format specifier.
1643 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1645 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1646 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1648 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1649 Some packages use them to denote characters with modifiers.
1651 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1653 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1654 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1655 matching a pp-number. Rename parameter var to var1.
1657 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1659 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1661 2011-10-08 Glenn Morris <rgm@gnu.org>
1663 * callint.c (Fcall_interactively): Give a more explicit error for the
1664 'c' case with a non-character input. (Bug#8479)
1666 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1668 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1670 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1671 lines that are hscrolled on the left.
1673 * dispnew.c (buffer_posn_from_coords): Account for a possible
1674 presence of header-line. (Bug#4426)
1676 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1678 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1679 Don't advertise functionality which we discourage or doesn't work.
1681 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1683 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1684 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1685 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1686 this makes Emacs dump core during garbage collection on rare
1687 occasions. sizeof is obviously inferior to offsetof here, so
1688 stick with offsetof.
1689 (GC_POINTER_ALIGNMENT): New macro.
1690 (mark_memory): Omit 3rd (offset) arg; caller changed.
1691 Don't assume EMACS_INT alignment is the same as pointer alignment.
1693 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1695 * keyboard.c (read_key_sequence_remapped): New var.
1696 (read_key_sequence): Compute remapping in the right buffer.
1697 (command_loop_1): Use read_key_sequence's remapping directly.
1699 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1701 * dired.c (file_name_completion): Don't expand file name.
1702 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1703 before checking file name handler.
1705 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1706 they've been requested explicitly (bug#9591).
1708 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1710 * keymap.c (Fsingle_key_description): Use make_specified_string
1711 instead of build_string to build string from push_key_description.
1714 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1716 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1717 This fixes a Y2038 bug on 64-bit hosts.
1718 * buffer.c (reset_buffer):
1719 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1720 (Fclear_buffer_auto_save_failure):
1721 Use 0, not -1, to represent an unset failure time, since time_t
1722 might not be signed.
1724 Remove dependency on glibc malloc internals.
1725 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1726 Move back here from lisp.h, but with their new implementations.
1727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1728 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1729 * charset.c (charset_table_init): New static var.
1730 (syms_of_charset): Use it instead of xmalloc. This removes a
1731 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1732 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1733 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1734 Move back to alloc.c.
1735 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1736 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1738 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1740 * nsterm.m (windowDidResize): Call x_set_window_size only when
1741 ns_in_resize is true. Otherwise set pixelwidth/height and
1742 call change_frame_size (Bug#9628).
1744 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1746 Port --enable-checking=all to Fedora 14 x86-64.
1747 * charset.c (syms_of_charset): Also account for glibc malloc's
1748 internal overhead when calculating the initial malloc maximum.
1750 Port --enable-checking=all to Fedora 14 x86.
1751 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1753 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1754 (overrun_check_realloc, overrun_check_free):
1755 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1756 That way, xmalloc returns a properly-aligned pointer even if
1757 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1758 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1759 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1760 into account when calculating the initial malloc maximum.
1761 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1762 Move here from alloc.c, so that charset.c can use it too.
1763 Properly align; the old code wasn't right for common 32-bit hosts
1764 when configured with --enable-checking=all.
1765 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1766 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1768 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1770 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1773 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1775 * xdisp.c (compute_display_string_end): If there's no display
1776 string at CHARPOS, return -1.
1778 * bidi.c (bidi_fetch_char): When compute_display_string_end
1779 returns a negative value, treat the character as a normal
1780 character not covered by a display string. (Bug#9624)
1782 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1784 * lread.c (Fread_from_string): Fix typo in docstring.
1786 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1788 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1789 newline, reseat the iterator instead of bidi-iterating there one
1790 character at a time. (Bug#9610)
1791 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1792 TO_CHARPOS if the bidi iterator is at base embedding level.
1794 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1796 * lread.c (readevalloop): Use correct code for NBSP.
1797 (read1): Likewise. (Bug#9608)
1799 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1801 * dbusbind.c (Fdbus_register_signal): When service is not
1802 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1804 2011-09-25 Glenn Morris <rgm@gnu.org>
1806 * buffer.c (truncate-lines): Doc fix.
1808 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1810 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1811 (Fset_window_next_buffers): Doc fix.
1813 2011-09-24 Glenn Morris <rgm@gnu.org>
1815 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1817 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1819 Fix minor problems found by static checking.
1820 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1821 * indent.c (Fvertical_motion): Fix == vs = typo.
1823 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1825 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1826 Default value is now t. Doc fix.
1828 * indent.c (Fvertical_motion): Compute and apply the overshoot
1829 logic when moving up, not only when moving down. Fix the
1830 confusing name and values of the it_overshoot_expected variable;
1831 logic changes accordingly. (Bug#9254) (Bug#9549)
1833 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1834 CHARPOS is covered by a display string which includes newlines.
1835 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1836 is covered by a display string with embedded newlines.
1838 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1840 * dbusbind.c (Fdbus_register_signal): Add match rule to
1841 Vdbus_registered_objects_table. (Bug#9581)
1842 (Fdbus_register_method, Vdbus_registered_objects_table):
1845 2011-09-24 Jim Meyering <meyering@redhat.com>
1847 do not ignore write error for any output size
1848 The previous change was incomplete.
1849 While it makes emacs --batch detect the vast majority of stdout
1850 write failures, errors were still ignored whenever the output size is
1851 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1852 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1853 && echo FAIL: ignored write error
1854 FAIL: ignored write error
1855 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1856 && echo FAIL: ignored write error
1857 FAIL: ignored write error
1858 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1860 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1862 * emacs.c (Fkill_emacs): In noninteractive mode exit
1863 non-successfully if a write error occurred on stdout. (Bug#9574)
1865 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1870 * dispextern.h (struct it): Update the comment documenting what
1873 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1875 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1876 a display string, extend search for cursor position to end of row.
1877 (find_row_edges): If the row ends in a newline from a display
1878 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1879 Handle the case of a display string with multiple newlines.
1880 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1881 non-empty line. Fixes confusing cursor motion with arrow keys at
1882 the beginning of a line that starts with whitespace.
1884 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1886 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1889 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1891 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1894 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1896 * xdisp.c (display_line): Record maximum and minimum buffer
1897 positions even if no glyphs were produced (e.g., by a zero-width
1898 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1899 buffer positions that will be removed from the glyph row because
1901 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1902 column is beyond frame width: don't subtract 1 "pixel" when
1903 computing width of the stretch.
1904 (reseat_at_next_visible_line_start): Undo the change made on
1905 2011-09-17 that saved paragraph information and restored it after
1906 the call to `reseat'. (Bug#9545)
1908 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1910 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1911 and turn window cursor on if cleared (Bug#9415).
1913 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1915 * search.c (boyer_moore): Take unibyte characters from pattern
1916 literally. (Bug#9458)
1918 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1920 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1922 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1924 Fix minor problem found by static checking.
1925 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1926 initialized, to pacify gcc -Wuninitialized.
1928 * fileio.c: Report proper errno when syscall falls.
1929 (Finsert_file_contents): Save and restore errno,
1930 so that report_file_error outputs the correct diagnostic.
1931 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1933 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1935 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1937 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1939 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1940 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1942 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1945 about the current paragraph and restore it after the call to reseat.
1947 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1948 (bidi_find_paragraph_start): Search back for paragraph beginning
1949 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1950 (bidi_move_to_visually_next): Only trigger paragraph-related
1951 computations when the last character is a newline or at EOB, not
1952 just any NEUTRAL_B. (Bug#9470)
1954 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1955 truncated lines if point is covered by a display string. (Bug#9524)
1957 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1959 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1960 (cons_to_x_long): New function.
1961 (lisp_data_to_selection_data): Use it. Correct the test for
1962 short-versus-long data; it was negated. Break out of vector
1963 loop, for efficiency, when a long datum is discovered.
1965 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1967 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1969 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1971 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1972 GCC PR/17406) by declaring this function with external scope.
1974 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1976 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1977 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1979 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1981 * editfns.c (Fformat): Correctly handle text properties on "%%".
1983 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1985 * xterm.c (x_draw_composite_glyph_string_foreground):
1986 * w32term.c (x_draw_composite_glyph_string_foreground):
1987 * term.c (encode_terminal_code):
1988 * composite.c (composition_update_it, get_composition_id):
1989 * xdisp.c (get_next_display_element)
1990 (fill_composite_glyph_string): Add comments about special meaning
1991 of TAB characters in a composition.
1993 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1995 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1996 This occurs when processing a multibyte format.
1997 Problem reported by Wolfgang Jenker.
1999 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2001 * xdisp.c (try_cursor_movement): Only check for exact match if
2002 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2004 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2006 Remove unused external symbols.
2007 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2008 * xdisp.c (calc_pixel_width_or_height): Now static.
2009 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2010 * indent.c (check_display_width):
2011 * w32term.c: Fix comment to match code.
2012 * xterm.c, xterm.h (x_catching_errors): Remove.
2014 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2016 * xselect.c: Use signed conversions more consistently (Bug#9498).
2017 (selection_data_to_lisp_data): Assume incoming selection data are
2018 signed integers, not unsigned. This is to be consistent with
2019 outgoing selection data, which was modified to use signed integers
2020 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2021 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2022 expects long, not unsigned long.
2024 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2027 computation of loop end. Reported by Johan Bockgård
2030 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2032 * frame.c (Fother_visible_frames_p): Function deleted.
2034 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2036 * indent.c (compute_motion): Process display vector front to back
2037 rather than the other way around. (Bug#2496)
2039 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2041 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2043 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2045 * minibuf.c (Fread_from_minibuffer): Doc fix.
2047 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2049 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2050 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2052 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2054 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2055 value for non-existent files.
2057 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2059 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2060 set its "size" to -1. This will set the modtime_size field of
2061 the corresponding buffer to -1, which is what
2062 verify-visited-file-modtime expects for files that do not exist.
2065 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2067 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2069 * lisp.h: ... from here. push_key_description is no longer
2070 defined in keyboard.c, so its declaration should not be in
2071 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2072 logically belongs with push_key_description.
2074 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2076 * buffer.h: Include <sys/types.h> instead of <time.h>.
2077 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2078 Problem reported by Herbert J. Skuhra.
2080 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2082 * xml.c (parse_region): Make the parsing work for
2083 non-comment-starting XML files again (bug#9144).
2085 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2087 * image.c (gif_load): Fix calculation of bottom and right corner.
2090 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2092 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2093 redisplay in small windows.
2095 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2097 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2099 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2101 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2102 Operate on live windows only.
2104 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2106 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2108 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2110 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2111 only under bidi iteration.
2113 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2115 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2117 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2119 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2120 Without this fix, the command to link temacs failed due to an
2121 undefined symbol __builtin_isnan. This is because
2122 /usr/include/iso/math_c99.h #defines isnan(x) to
2123 __builtin_isnan(x), but the bundled gcc, which identifies itself
2124 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2126 * floatfns.c (isnan): #undef, and then #define to a clone of
2128 (Fisnan): Always define, since it's always available now.
2129 (syms_of_floatfns): Always define isnan at the Lisp level.
2131 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2133 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2135 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2137 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2138 The previous code assumed that file offsets (off_t values) fit in
2139 EMACS_INT variables, which is not true on typical 32-bit hosts.
2140 The code messed up by falsely reporting buffer overflow in cases
2141 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2142 when "big" contains more than 2**29 bytes, even though this
2143 inserts just one byte and does not overflow the buffer.
2144 (Finsert_file_contents): Store file offsets as off_t
2145 values, not as EMACS_INT values. Check for overflow when
2146 converting between EMACS_INT and off_t. When checking for
2147 buffer overflow or for overlap, take the offsets into account.
2148 Don't use EMACS_INT for small values where int suffices.
2149 When checking for overlap, fix a typo: ZV was used where
2150 ZV_BYTE was intended.
2151 (Fwrite_region): Don't assume off_t fits into 'long'.
2152 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2154 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2156 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2158 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2160 sprintf-related integer and memory overflow issues (Bug#9412).
2162 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2163 (esprintf, exprintf, evxprintf): New functions.
2164 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2165 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2166 (modify_event_symbol): Do not assume that the length of
2167 name_alist_or_stem is safe to alloca and fits in int.
2168 (Fexecute_extended_command): Likewise for function name and binding.
2169 (Frecursion_depth): Wrap around reliably on integer overflow.
2170 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2171 since some callers pass EMACS_INT values.
2172 (Fsingle_key_description): Don't crash if symbol name contains more
2173 than MAX_ALLOCA bytes.
2174 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2175 (get_minibuffer): Arg is now EMACS_INT, not int.
2176 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2177 (esprintf, exprintf, evxprintf): New decls.
2178 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2180 * dbusbind.c (signature_cat): New function.
2181 (xd_signature, Fdbus_register_signal):
2182 Do not overrun buffer; instead, report string overflow.
2184 * dispnew.c (add_window_display_history): Don't overrun buffer.
2185 Truncate instead; this is OK since it's just a log.
2187 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2188 even if the time zone offset is outlandishly large.
2189 Don't mishandle offset == INT_MIN.
2191 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2192 when creating daemon; the previous buffer-overflow check was incorrect.
2194 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2195 which has the guts of the old verror function.
2197 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2198 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2200 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2201 (font_unparse_xlfd): Don't blindly alloca long strings.
2202 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2203 fits in int, when using sprintf. Use single snprintf to count
2204 length of string rather than counting it via multiple sprintfs;
2205 that's simpler and more reliable.
2206 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2207 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2208 sprintf, in case result does not fit in int.
2210 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2211 (fontset_from_font): Print it.
2213 * frame.c (tty_frame_count): Now printmax_t, not int.
2214 (make_terminal_frame, set_term_frame_name): Print it.
2215 (x_report_frame_params): In X, window IDs are unsigned long,
2216 not signed long, so print them as unsigned.
2217 (validate_x_resource_name): Check for implausibly long names,
2218 and don't assume name length fits in 'int'.
2219 (x_get_resource_string): Don't blindly alloca invocation name;
2220 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2223 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2224 (xg_check_special_colors, xg_set_geometry):
2225 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2227 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2228 Use esprintf, not sprintf, in case result does not fit in int.
2230 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2231 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2232 it as a large positive number.
2233 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2234 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2236 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2237 in case result does not fit in int.
2239 * print.c (float_to_string): Detect width overflow more reliably.
2240 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2241 buffer overrun. Don't assume list length fits in 'int'. Treat
2242 print length of 0 as 0, not as infinity; to be consistent with other
2243 uses of print length in this function. Don't overflow print length
2244 index. Don't assume hash table size fits in 'long', or that
2245 vectorlike size fits in 'unsigned long'.
2247 * process.c (make_process): Use printmax_t, not int, to format
2248 process-name gensyms.
2250 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2252 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2253 to avoid potential buffer overrun.
2255 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2256 if X resource line is longer than 512 bytes.
2258 * xfns.c (x_window): Make sprintf buffer a bit bigger
2259 to avoid potential buffer overrun.
2261 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2263 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2265 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2267 Integer overflow fixes for scrolling, etc.
2268 Without these, Emacs silently mishandles large integers sometimes.
2269 For example, "C-u 4294967297 M-x recenter" was treated as if
2270 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2272 * xdisp.c (try_window_id): Check Emacs fixnum range before
2273 converting to 'int'.
2275 * window.c (window_scroll_line_based, Frecenter):
2276 Check that an Emacs fixnum is in range before assigning it to 'int'.
2277 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2278 values converted from Emacs fixnums.
2279 (Frecenter): Don't wrap around a line count if it is out of 'int'
2280 range; instead, treat it as an extreme value.
2281 (Fset_window_configuration, compare_window_configurations):
2282 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2284 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2285 that can exceed INT_MAX. Check that EMACS_INT value is in range
2286 before assigning it to the (possibly-narrower) index.
2287 (match_limit): Don't assume that a fixnum can fit in 'int'.
2289 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2292 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2293 (Fvertical_motion): Don't wrap around LINES values that don't fit
2294 in 'int'. Instead, treat them as extreme values. This is good
2295 enough for windows, which can't have more than INT_MAX lines anyway.
2297 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2299 * Require libxml/parser.h to avoid compilation warning.
2301 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2303 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2304 since this reportedly can destroy thread storage.
2306 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2308 * syntax.c (find_defun_start): Update all cache variables if
2309 exiting early (Bug#9401).
2311 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2313 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2315 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2316 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2317 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2319 * term.c (tty_append_glyph): New function.
2320 (produce_stretch_glyph): Static function and its prototype deleted.
2322 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2325 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2327 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2328 when checking :margin (Bug#9390).
2329 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2330 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2331 so that the name doesn't mislead. All uses changed.
2333 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2335 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2338 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2340 * xdisp.c (move_it_to): Don't bail out early when reaching
2341 position beyond to_charpos, if we are scanning backwards.
2342 (move_it_vertically_backward): When DY == 0, make sure we get to
2343 the first character in the line after the newline.
2345 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2347 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2348 (ccl_driver): Do not generate an out-of-range pointer.
2349 (Fccl_execute_on_string): Remove unnecessary check for
2350 integer overflow, noted by Stefan Monnier in
2351 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2352 Remove a FIXME that didn't need fixing.
2353 Simplify the newly-introduced buffer reallocation code.
2355 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2357 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2359 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2361 Integer and memory overflow issues (Bug#9196).
2363 * doc.c (get_doc_string): Rework so that
2364 get_doc_string_buffer_size is the actual buffer size, rather than
2365 being 1 less than the actual buffer size; this makes xpalloc more
2368 * image.c (x_allocate_bitmap_record, cache_image):
2369 * xselect.c (Fx_register_dnd_atom):
2370 Simplify previous changes by using xpalloc.
2372 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2373 since either will do and ptrdiff_t is convenient with xpalloc.
2375 * charset.c (charset_table_size)
2376 (struct charset_sort_data.priority): Now ptrdiff_t.
2377 (charset_compare): Don't overflow if priorities differ greatly.
2378 (Fsort_charsets): Don't assume list length fits in int.
2379 Check for size-calculation overflow when allocating sort data.
2380 (syms_of_charset): Allocate an initial charset table that is
2381 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2383 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2385 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2386 The actual value is always <= INT_MAX, and leaving it unsigned made
2387 overflow checking harder.
2389 * dispextern.h (struct glyph_matrix.rows_allocated)
2390 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2391 with xpalloc. The values are still always <= INT_MAX.
2393 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2395 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2396 (SAFE_NALLOCA): New macro.
2398 * region-cache.c (struct boundary.pos, find_cache_boundary)
2399 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2400 (set_cache_region, invalidate_region_cache)
2401 (revalidate_region_cache, know_region_cache, region_cache_forward)
2402 (region_cache_backward, pp_cache):
2403 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2404 so that ptrdiff_t * can be passed to xpalloc.
2405 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2406 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2407 (pp_cache): Don't assume cache_len fits in int.
2408 * region-cache.h: Adjust extern decls to match.
2410 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2411 EMACS_INT, since either will do, for xpalloc.
2413 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2414 (xnmalloc, xnrealloc, xpalloc): New functions.
2416 * bidi.c (bidi_shelve_header_size): New constant.
2417 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2418 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2420 * bidi.c (bidi_cache_shrink):
2421 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2423 Don't update size of array until after memory allocation succeeds,
2424 because xmalloc/xrealloc may not return.
2425 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2426 now that we have proper integer overflow checking.
2427 (record_overlay_string, overlay_strings): Catch overflows when
2428 calculating size of overlay_str_buf.
2430 * callproc.c (Fcall_process): Check for size overflow when
2431 calculating size of args2.
2432 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2433 Normally we prefer signed values, but sticking with ptrdiff_t would
2434 require adding more-complicated checks.
2436 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2437 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2438 Redo buffer-overflow calculations to avoid integer overflow.
2439 Add a FIXME comment where memory seems to be over-allocated.
2441 * character.c (Fstring): Check for size-calculation overflow.
2443 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2444 unnecessary integer overflow. Check for size overflow.
2445 (encode_coding_object): Don't update size until xmalloc succeeds.
2447 * composite.c (get_composition_id): Check for overflow in glyph
2448 length calculations.
2450 Integer and memory overflow fixes for display code.
2451 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2452 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2453 (scrolling_window): Check for overflow in size calculations.
2454 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2455 Don't assume glyph table len fits in int.
2456 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2457 (row_table_size): Now ptrdiff_t, not int.
2458 (scrolling_window): Avoid overflow in size calculations.
2459 Don't update size until allocation succeeds.
2460 * fns.c (concat): Check for overflow in size calculations.
2461 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2462 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2463 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2465 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2466 (get_doc_string): Check for size calculation overflow.
2467 Don't update size until allocation succeeds.
2468 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2469 EMACS_INT, where ptrdiff_t will do.
2470 (Fsubstitute_command_keys): Check for string overflow.
2472 * editfns.c (set_time_zone_rule): Don't assume environment length
2474 (message_length): Now ptrdiff_t, not int.
2475 (Fmessage_box): Don't update size until allocation succeeds.
2476 Don't assume message length fits in int.
2477 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2479 * emacs.c (main): Do not reallocate argv, since there is a null at
2480 the end that can be overwritten, and this way there's no need to
2481 worry about size-calculation overflow.
2482 (sort_args): Check for size-calculation overflow.
2484 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2486 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2488 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2489 (x_set_scroll_bar_width, x_figure_window_size):
2490 Check for integer overflow.
2491 (x_set_alpha): Do not assume XINT fits in int.
2493 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2494 This is for the members text_lines, text_cols, total_lines, total_cols,
2495 where the system imposes an 'int' limit.
2497 * fringe.c (Fdefine_fringe_bitmap):
2498 Don't update size until alloc works.
2500 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2501 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2503 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2504 Check for size-calculation overflow.
2505 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2506 do, as we prefer signed integers.
2507 (id_to_widget.max_size, id_to_widget.used)
2508 (xg_store_widget_in_map, xg_remove_widget_from_map)
2509 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2510 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2511 Use and return ptrdiff_t, not int.
2512 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2513 * gtkutil.h: Change prototypes to match the above.
2515 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2516 are duplicate now that they've been promoted to lisp.h.
2517 (x_allocate_bitmap_record, x_alloc_image_color)
2518 (make_image_cache, cache_image, xpm_load):
2519 Don't update size until alloc is done.
2520 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2522 Check for size calculation overflow.
2523 (ct_colors_allocated_max): New constant.
2524 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2527 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2528 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2529 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2530 Use ptrdiff_t, not int, to count maps.
2531 (read_char_minibuf_menu_prompt): Check for overflow in size
2532 calculations. Don't update size until allocation succeeds.
2533 Redo calculations to avoid overflow.
2534 * keyboard.h: Change prototypes to match the above.
2536 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2538 (current_minor_maps): Check for size calculation overflow.
2539 * keymap.h: Change prototypes to match the above.
2541 * lread.c (read1, init_obarray): Don't update size until alloc done.
2543 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2544 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2546 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2547 Now ptrdiff_t, not int.
2548 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2549 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2551 * process.c (Fnetwork_interface_list): Check for overflow
2552 in size calculation.
2554 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2556 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2557 overflow. Don't bother calling xmalloc when xrealloc will do.
2559 * search.c (Freplace_match): Check for size calculation overflow.
2560 (Fset_match_data): Don't assume list lengths fit in 'int'.
2562 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2563 for command line length. Do not attempt to address one before the
2564 beginning of an array, as that's not portable.
2566 * term.c (max_frame_lines): Remove; unused.
2567 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2569 (encode_terminal_code, calculate_costs): Check for size
2570 calculation overflow.
2571 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2572 table lengths and related sizes. Don't update size until alloc
2573 done. Redo calculations to avoid overflow.
2574 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2576 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2577 subtracting pointers.
2578 (gobble_line): Check for overflow more carefully. Don't update size
2581 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2582 Don't update size until alloc done.
2583 Redo size calculations to avoid overflow.
2584 Check for size calculation overflow.
2585 (main) [DEBUG]: Fix typo in invoking tparam1.
2587 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2588 Use ptrdiff_t, not int, for sizes.
2589 (store_mode_line_noprop_char): Don't update size until alloc done.
2591 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2592 Use ptrdiff_t, not int, for sizes.
2593 (Finternal_make_lisp_face, cache_face):
2594 Check for size calculation overflow.
2595 (cache_face): Treat size calculation overflows as if they were
2596 memory exhaustion (the usual treatment), rather than aborting.
2598 * xfns.c (x_encode_text, x_set_name_internal)
2599 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2600 sizes, since they can exceed INT_MAX in size. Check for size
2601 calculation overflow.
2603 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2604 (xg_select): Check for size calculation overflow.
2605 Don't update size until alloc done.
2607 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2608 as sprintf is limited to int lengths.
2610 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2611 (X_LONG_MIN): New macros.
2612 Use them to make the following changes clearer.
2613 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2614 This change doesn't affect the value now, but it may help remind
2615 future maintainers not to raise the value too much later.
2616 (SELECTION_QUANTUM): Remove, replacing with ...
2617 (selection_quantum): ... new function, which avoids overflow.
2619 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2620 assumption that selection length fits in 'int'.
2621 (x_reply_selection_request, x_handle_selection_request)
2622 (x_get_window_property, receive_incremental_selection)
2623 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2624 (lisp_data_to_selection_data, clean_local_selection_data):
2625 Use ptrdiff_t, not int, to record length of selection.
2626 (x_reply_selection_request, x_get_window_property)
2627 (receive_incremental_selection, x_property_data_to_lisp):
2628 Redo calculations to avoid overflow.
2629 (x_reply_selection_request): When sending hint, ceiling it at
2630 X_LONG_MAX rather than relying on wraparound overflow to send
2632 (x_get_window_property, receive_incremental_selection)
2633 (lisp_data_to_selection_data, x_property_data_to_lisp):
2634 Check for size-calculation overflow.
2635 (x_get_window_property, receive_incremental_selection)
2636 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2637 Don't store size until memory allocation succeeds.
2638 (x_get_window_property): Plug memory leak on memory exhaustion.
2639 Don't double-block input; malloc is safe here. Don't assume 2**34
2640 - 4 fits in unsigned long. Add an xassert to check
2641 XGetWindowProperty overflow. Be more careful about overflow
2642 calculations, and distinguish size from memory overflow better.
2643 (receive_incremental_selection): When tracing, don't assume
2644 unsigned int is less than INT_MAX.
2645 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2646 harmful) conversions of unsigned short to int.
2647 (lisp_data_to_selection_data): Don't assume that integers
2648 in the range -65535 through -1 fit in an X unsigned short.
2649 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2650 result parameters unless successful. Rely on cons_to_unsigned
2651 to report problems with elements; the old code wasn't right anyway.
2652 (x_check_property_data): Check for int overflow; we cannot use
2653 a wider type due to X limits.
2654 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2656 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2658 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2659 (x_term_init): Check for size calculation overflow.
2660 (x_color_cells): Don't store size until memory allocation succeeds.
2661 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2662 Don't assume alloca size is less than MAX_ALLOCA.
2663 (x_term_init): Don't assume length fits in int (sprintf is limited
2666 Use ptrdiff_t for composition IDs.
2667 * character.c (lisp_string_width):
2668 * composite.c (composition_table_size, n_compositions)
2669 (get_composition_id, composition_gstring_from_id):
2670 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2671 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2672 * window.c (Frecenter):
2673 Use ptrdiff_t, not int, for composition IDs.
2674 * composite.c (get_composition_id): Check for integer overflow.
2675 * composite.h: Adjust prototypes to match the above changes.
2677 Use ptrdiff_t for hash table indexes.
2678 * category.c (hash_get_category_set):
2679 * ccl.c (ccl_driver):
2680 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2681 * coding.c (coding_system_charset_list, detect_coding_system):
2682 * coding.h (struct coding_system.id):
2683 * composite.c (get_composition_id, gstring_lookup_cache):
2684 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2685 * image.c (xpm_get_color_table_h):
2686 * lisp.h (hash_lookup, hash_put):
2687 * minibuf.c (Ftest_completion):
2688 Use ptrdiff_t for hash table indexes, not int (which is too
2689 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2690 32-bit --with-wide-int hosts).
2692 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2693 Add a FIXME comment about memory leaks.
2694 (syms_of_charset): Don't assume xmalloc returns.
2696 Don't assume that stated character widths fit in int.
2697 * character.c (Fchar_width, c_string_width, lisp_string_width):
2698 * character.h (CHAR_WIDTH):
2699 * indent.c (MULTIBYTE_BYTES_WIDTH):
2700 Use sanitize_char_width to avoid undefined and/or bad behavior
2701 with outlandish widths.
2702 * character.h (sanitize_tab_width): Rename from sanitize_width,
2703 now that we have two such functions. All uses changed.
2704 (sanitize_char_width): New inline function.
2706 Don't assume that tab-width fits in int.
2707 * character.h (sanitize_width): New inline function.
2708 (SANE_TAB_WIDTH): New macro.
2709 (ASCII_CHAR_WIDTH): Use it.
2710 * indent.c (sane_tab_width): Remove. All uses replaced by
2711 SANE_TAB_WIDTH (current_buffer).
2712 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2714 * fileio.c: Integer overflow issues with file modes.
2715 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2717 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2718 Remove unreachable code.
2719 (read_hex, load_charset_map_from_file): Check for integer overflow.
2721 * xterm.c: Don't go over XClientMessageEvent limit.
2722 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2723 (x_send_scroll_bar_event): Likewise. Check that the size does not
2724 exceed limits imposed by XClientMessageEvent, as well as the usual
2725 ptrdiff_t and size_t limits.
2727 * keyboard.c: Overflow, signedness and related fixes.
2728 (make_lispy_movement): Use same integer type in forward decl
2729 that is used in the definition.
2730 (read_key_sequence, keyremap_step):
2731 Change bufsize argument back to int, undoing my 2011-03-30 change.
2732 We prefer signed types, and int is wide enough here.
2733 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2734 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2735 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2736 length, not size_t. Use ptrdiff_t for index, not int.
2737 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2738 possibility of integer overflow.
2740 Overflow, signedness and related fixes for images.
2742 * dispextern.h (struct it.stack[0].u.image.image_id)
2743 (struct_it.image_id, struct image.id, struct image_cache.size)
2744 (struct image_cache.used, struct image_cache.ref_count):
2745 * gtkutil.c (update_frame_tool_bar):
2746 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2747 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2748 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2749 * nsmenu.m (update_frame_tool_bar):
2750 * xdisp.c (calc_pixel_width_or_height):
2751 * xfns.c (image_cache_refcount):
2752 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2753 on typical 64-bit hosts.
2755 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2756 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2757 Omit unnecessary casts to int.
2758 (parse_image_spec): Check that integers fall into 'int' range
2759 when the callers expect that.
2760 (image_ascent): Redo ascent calculation to avoid int overflow.
2761 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2762 (lookup_image): Remove unnecessary tests.
2763 (xbm_image_p): Locals are now of int, not EMACS_INT,
2764 since parse_image_check makes sure they fit into int.
2765 (png_load, gif_load, svg_load_image):
2766 Prefer int to unsigned where either will do.
2767 (tiff_handler): New function, combining the cores of the
2768 old tiff_error_handler and tiff_warning_handler.
2769 This function is rewritten to use vsnprintf and thereby avoid
2770 stack buffer overflows. It uses only the features of vsnprintf
2771 that are common to both POSIX and native Microsoft.
2772 (tiff_error_handler, tiff_warning_handler): Use it.
2773 (tiff_load, gif_load, imagemagick_load_image):
2774 Don't assume :index value fits in 'int'.
2775 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2776 (imagemagick_load_image): Check that crop parameters fit into
2777 the integer types that MagickCropImage accepts. Don't assume
2778 Vimagemagick_render_type has a nonnegative value. Don't assume
2779 size_t fits in 'long'.
2780 (gs_load): Use printmax_t to print the widest integers possible.
2781 Check for integer overflow when computing image height and width.
2783 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2785 * xdisp.c (redisplay_window): Don't force window start if point
2786 will be invisible in the resulting window. (Bug#9324)
2788 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2791 the display spec is of the form `(space ...)'.
2792 (handle_display_spec): Return the value returned by
2793 handle_single_display_spec, not just 1 or zero.
2794 (handle_single_display_spec): If the display spec is of the form
2795 `(space ...)', and specifies display in the text area, return 2
2797 (try_cursor_movement): Check for the need to scroll more
2798 accurately, and prefer exact match for point under bidi.
2799 Don't advance `row' beyond the last row of the window.
2801 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2802 into disp_prop; all users changed.
2804 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2805 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2806 for the text covered by the display property.
2808 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2810 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2811 Change return value to nil.
2812 (Frecord_buffer): Delete unused function.
2814 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2816 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2817 buffers, return left-to-right.
2818 (set_cursor_from_row): Consider candidate row a win if its glyph
2819 represents a newline and point is on that newline. Fixes cursor
2820 positioning on the newline at EOL of R2L text within L2R
2821 paragraph, and vice versa.
2822 (try_cursor_movement): Check continued rows, in addition to
2823 continuation rows. Fixes unwarranted scroll when point enters a
2824 continued line of R2L text within an L2R paragraph, or vice versa.
2825 (cursor_row_p): Consider the case of point being equal to
2826 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2827 from the end of a short line to the beginning of a continued line
2828 of R2L text within L2R paragraph.
2829 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2830 composed characters.
2832 * bidi.c (bidi_check_type): Use xassert.
2833 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2836 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2838 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2841 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2843 * nsfont.m (ns_otf_to_script): Fix typo.
2845 2011-08-22 Kenichi Handa <handa@m17n.org>
2847 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2848 extra slot even if the purpose is char-code-property-table.
2850 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2852 * xdisp.c (redisplay_window): When computing centering_position,
2853 account for the height of the header line. (Bug#8874)
2855 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2856 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2857 candidate is selected by the mouse, and that candidate has a
2858 composed character under the mouse.
2860 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2861 coordinates reported by pos-visible-in-window-p for a composed
2862 character in column zero.
2864 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2866 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2868 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2870 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2871 consider it a hit if to_charpos is anywhere in the range of the
2872 composed buffer positions.
2874 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2876 * image.c (gif_load): Don't assume that each subimage has the same
2877 dimensions as the base image. Handle disposal method that is
2878 "undefined" by the gif spec (Bug#9335).
2880 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2882 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2883 (Fcondition_case): Document `debug' symbol in error handler.
2885 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2887 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2888 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2889 from an Org mode buffer to a Speedbar frame.
2891 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2892 a composition, take its buffer position from IT->cmp_it.charpos.
2893 Fixes cursor positioning at the beginning of a line that begins
2894 with a composed character.
2896 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2898 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2899 character bidirectional type, use STRONG_L instead. Fixes crashes
2900 in a buffer produced by `describe-categories'.
2902 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2903 members before the level stack, so they would be saved and
2904 restored when copying iterator state. Fixes incorrect reordering
2905 around TABs covered by display properties.
2907 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2909 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2911 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2913 * eval.c (internal_condition_case, internal_condition_case_1)
2914 (internal_condition_case_2, internal_condition_case_n):
2915 Remove unnecessary aborts (Bug#9081).
2917 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2919 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2920 has no `load' handler, try opening the file locally. (Bug#9311)
2922 2011-08-16 Ken Brown <kbrown@cornell.edu>
2924 * gmalloc.c: Expand comment.
2926 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2928 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2929 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2931 2011-08-16 Ken Brown <kbrown@cornell.edu>
2933 Fix memory allocation problems in Cygwin build (Bug#9273).
2935 * unexcw.c ( __malloc_initialized): Declare external variable.
2936 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2938 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2940 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2942 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2944 [CYGWIN] (special_realloc): New function.
2945 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2946 requests to realloc storage in the static heap.
2948 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2950 * bidi.c (bidi_initialize): Remove unused local.
2952 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2955 * biditype.h: Remove file.
2956 * makefile.w32-in ($(BLD)/bidi.$(O)):
2957 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2959 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2961 * chartab.c: Improve commentary for the uniprop_table API.
2963 * bidi.c (bidi_paragraph_init): Support zero value of
2964 bidi_ignore_explicit_marks_for_paragraph_level.
2965 (bidi_initialize): Use uniprop_table instead of including
2966 biditype.h and bidimirror.h.
2968 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2969 coordinates of the iterator when restoring from ppos_it.
2972 2011-08-14 Kenichi Handa <handa@m17n.org>
2974 * process.c (create_process): Call setup_process_coding_systems
2975 after the pid of the process is set to -1 (Bug#8162).
2977 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2979 * xdisp.c (move_it_in_display_line_to): Don't invoke
2980 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2981 ppos_it. Fixes vertical cursor motion when line beginning is
2982 covered by an image. (Bug#9296)
2984 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2986 * nsterm.h (ns_run_ascript): Declare.
2987 (NSAPP_DATA2_RUNASSCRIPT): Define.
2989 * nsfns.m (as_script, as_result, as_status): New static variables.
2990 (ns_run_ascript): New function.
2991 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2992 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2993 the event loop. Get status from as_status (Bug#7276).
2995 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2996 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2997 the event loop (Bug#7276).
2999 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3001 * gnutls.c (QCgnutls_bootprop_priority)
3002 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3003 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3004 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3005 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3006 (QCgnutls_bootprop_verify_hostname_error)
3007 (QCgnutls_bootprop_callbacks_verify): Rename from
3008 Qgnutls_bootprop_..., all uses changed.
3010 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3013 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3015 * xfaces.c (Qframe_set_background_mode): Now static.
3016 * dispextern.h (Qframe_set_background_mode): Remove decl.
3018 * process.c (Fnetwork_interface_info): Declare local only if needed.
3020 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3022 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3023 (Fnetwork_interface_list): Allocate in increments of bytes instead
3024 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3025 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3027 (struct ifflag_def): notrailers is smart on OSX.
3028 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3029 Get hardware address with getifaddrs if available.
3031 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3033 * xdisp.c (iterate_out_of_display_property): xassert that
3034 IT->position is set to within IT->object's boundaries. Break from
3035 the loop as soon as EOB is reached; avoids infloops in redisplay
3036 when IT->position is set up wrongly due to some bug.
3037 Set IT->current to match the bidi iterator unconditionally.
3038 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3039 entry. Force push_it to save on the stack the current
3040 buffer/string position, to be restored by pop_it. Fix flags in
3041 the iterator structure wrt the object coming from a display
3042 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3043 properties. (Bug#9284)
3045 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3047 * fontset.c (fontset_get_font_group): Add proper type checks.
3050 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3052 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3053 and LC_VERSION_MIN_MACOSX.
3054 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3055 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3057 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3059 * xdisp.c (forward_to_next_line_start): Allow to use the
3060 no-display-properties-and-no-overlays under bidi display.
3061 Set disp_pos in the bidi iterator to avoid searches for display
3062 properties and overlays.
3064 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3066 * editfns.c (Fset_time_zone_rule): Document relationship with the
3069 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3070 the font entity extracted from the cache (Bug#8109).
3072 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3074 * composite.c (autocmp_chars): Don't reset point. That is done by
3075 restore_point_unwind (Bug#5984).
3077 2011-08-07 Juri Linkov <juri@jurta.org>
3079 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3080 to show the arg `TIME' instead of `TIMEVAL'.
3082 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3084 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3085 display property strides EOL and includes a newline, as in
3086 longlines-mode. (Bug#9254)
3087 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3088 word-wrap under bidirectional display. (Bug#9224)
3090 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3091 is non-zero, even if the data buffer is NULL. Fixes a crash in
3092 vertical-motion with longlines-mode. (Bug#9254)
3094 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3096 * bidi.c <bidi_cache_total_alloc>: Now static.
3097 (bidi_initialize): Initialize bidi_cache_total_alloc.
3099 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3102 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3103 amount allocated this far in `bidi_cache_total_alloc'.
3104 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3105 non-zero, only free the data buffer without restoring the cache
3106 contents. All callers changed.
3108 * dispextern.h (bidi_unshelve_cache): Update prototype.
3110 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3111 (move_it_in_display_line, move_it_to)
3112 (move_it_vertically_backward, move_it_by_lines): Replace the call
3113 to xfree to an equivalent call to bidi_unshelve_cache.
3114 (move_it_in_display_line_to): Fix logic of returning
3115 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3117 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3119 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3120 came from a string character with a `cursor' property. (Bug#9229)
3122 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3124 * Makefile.in (LIB_PTHREAD): New variable.
3125 (LIBES): Add LIB_PTHREAD (Bug#9216).
3127 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3128 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3130 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3132 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3134 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3136 * xterm.c (x_find_topmost_parent): New function.
3137 (x_set_frame_alpha): Find topmost parent window with
3138 x_find_topmost_parent and set the property there also (bug#9181).
3139 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3141 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3143 * callproc.c (Fcall_process): Avoid vfork clobbering
3144 the local vars buffer, coding_systems, current_dir.
3146 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3148 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3150 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3152 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3153 so that it is not optimized away.
3155 * xdisp.c (compute_display_string_pos): Remove unused local.
3157 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3159 Fix slow cursor motion and scrolling in large buffers with
3160 selective display, like Org Mode buffers. (Bug#9218)
3162 * dispextern.h (struct bidi_it): New member disp_prop_p.
3164 * xdisp.c: Remove one-slot cache of display string positions.
3165 (compute_display_string_pos): Accept an additional argument
3166 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3167 for a display string or property. If found, set DISP_PROP_P
3170 * bidi.c (bidi_fetch_char): Accept an additional argument
3171 DISP_PROP_P, and pass it to compute_display_string_pos.
3172 Only handle text covered by a display string if DISP_PROP_P is returned
3173 non-zero. All callers of bidi_fetch_char changed.
3175 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3177 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3179 2010-12-03 Don March <don@ohspite.net>
3181 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3182 last character M-[char] is translated to ESC [char] (bug#7541).
3184 2011-08-02 Kenichi Handa <handa@m17n.org>
3186 * lisp.h (uniprop_table): Extern it.
3188 * chartab.c (uniprop_table): Make it non-static.
3190 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3192 * xdisp.c (forward_to_next_line_start): Accept additional argument
3193 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3195 (reseat_at_next_visible_line_start): Use the bidi iterator state
3196 returned by forward_to_next_line_start to restore the state of
3197 it->bidi_it after backing up to previous newline. (Bug#9212)
3199 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3201 * regex.c (re_comp): Protoize.
3202 (re_exec): Fix return type.
3203 (regexec): Fix type of `ret'. (Bug#9203)
3205 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3207 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3208 This is needed if max-image-size is a floating-point number.
3210 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3212 * print.c (print_object): Print empty symbol as ##.
3214 * lread.c (read1): Read ## as empty symbol.
3216 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3218 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3219 setting frame foreground color (Bug#9175).
3220 (x_set_background_color): Likewise.
3222 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3223 contents (Bug#9176).
3224 (EmacsTooltip -init): Remove bezels and add shadows to
3227 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3228 or scroll bar (Bug#8470).
3230 * nsfont.m (nsfont_open): Remove assignment to voffset and
3231 unnecessary vars hshink, expand, hd, full_height, min_height.
3232 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3234 * nsterm.h (nsfont_info): Remove voffset field.
3236 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3238 Implement strike-through and overline on NextStep (Bug#8863).
3240 * nsfont.m (nsfont_open): Use underline position provided by font,
3241 instead of hard-coded value of 2.
3242 (nsfont_draw): Call ns_draw_text_decoration instead.
3244 * nsterm.h: Add declaration for ns_draw_text_decoration.
3246 * nsterm.m (ns_draw_text_decoration): New function for drawing
3247 underline, overline, and strike-through.
3248 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3249 ns_draw_text_decoration. Change treatment of cursor drawing to
3250 accommodate underlining, etc.
3252 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3254 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3257 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3259 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3260 Without this fix, if a signal arrives just after memory fills up,
3261 'malloc' might be invoked reentrantly.
3263 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3264 In other words, assume that every image size is allowed, on non-X
3265 hosts. This assumption is probably wrong, but it lets Emacs compile.
3267 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3269 * regex.c (re_iswctype): Convert return values to boolean.
3271 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3273 * xdisp.c (compute_display_string_pos): Don't use cached display
3274 string position if the buffer had its restriction changed.
3277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3279 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3281 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3283 Integer signedness and overflow and related fixes. (Bug#9079)
3285 * bidi.c: Integer size and overflow fixes.
3286 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3287 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3288 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3289 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3290 (bidi_find_other_level_edge):
3291 Use ptrdiff_t instead of EMACS_INT where either will do.
3292 This works better on 32-bit hosts configured --with-wide-int.
3293 (bidi_cache_ensure_space): Check for size-calculation overflow.
3294 Use % rather than repeated addition, for better worst-case speed.
3295 Don't set bidi_cache_size until after xrealloc returns, because it
3297 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3298 (bidi_cache_ensure_space): Also check that the bidi cache size
3299 does not exceed that of the largest Lisp string or buffer. See Eli
3300 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3302 * alloc.c (__malloc_size_t): Remove.
3303 All uses replaced by size_t. See Andreas Schwab's note
3304 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3306 * image.c: Improve checking for integer overflow.
3307 (check_image_size): Assume that f is nonnull, since
3308 it is always nonnull in practice. This is one less thing to
3309 worry about when checking for integer overflow later.
3310 (x_check_image_size): New function, which checks for integer
3311 overflow issues inside X.
3312 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3313 This removes the need for a memory_full check.
3314 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3315 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3316 (xbm_read_bitmap_data): Change locals back to 'int', since
3317 their values must fit in 'int'.
3318 (xpm_load_image, png_load, tiff_load):
3319 Invoke x_create_x_image_and_pixmap earlier,
3320 to avoid much needless work if the image is too large.
3321 (tiff_load): Treat overly large images as if
3322 x_create_x_image_and_pixmap failed, not as malloc failures.
3323 (gs_load): Use x_check_image_size.
3325 * gtkutil.c: Omit integer casts.
3326 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3327 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3329 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3331 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3332 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3333 would wrongly return t on a 64-bit host.
3335 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3336 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3337 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3338 and therefore cause GCC to emit a bogus diagnostic in some cases.
3340 * image.c: Integer signedness and overflow and related fixes.
3341 This is not an exhaustive set of fixes, but it's time to
3342 record what I've got.
3343 (lookup_pixel_color, check_image_size): Remove redundant decls.
3344 (check_image_size): Don't assume that arbitrary EMACS_INT values
3345 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3346 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3347 (tiff_load, imagemagick_load_image):
3348 Check for overflow in size calculations.
3349 (x_create_x_image_and_pixmap): Remove unnecessary test for
3350 xmalloc returning NULL; that can't happen.
3351 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3352 (xpm_color_bucket): Use better integer hashing function.
3353 (xpm_cache_color): Don't possibly over-allocate memory.
3354 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3355 (gif_memory_source):
3356 Use ptrdiff_t, not int or size_t, to record sizes.
3357 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3358 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3359 either works, as we prefer signed integers.
3360 (tiff_read_from_memory, tiff_write_from_memory):
3361 Return tsize_t, not size_t, since that's what the TIFF API wants.
3362 (tiff_read_from_memory): Don't fail simply because the read would
3363 go past EOF; instead, return a short read.
3364 (tiff_load): Omit no-longer-needed casts.
3365 (Fimagemagick_types): Don't assume size fits into 'int'.
3367 Improve hashing quality when configured --with-wide-int.
3368 * fns.c (hash_string): New function, taken from sxhash_string.
3369 Do not discard information about ASCII character case; this
3370 discarding is no longer needed.
3371 (sxhash-string): Use it. Change sig to match it. Caller changed.
3372 * lisp.h: Declare it.
3373 * lread.c (hash_string): Remove, since we now use fns.c's version.
3374 The fns.c version returns a wider integer if --with-wide-int is
3375 specified, so this should help the quality of the hashing a bit.
3377 * emacs.c: Integer overflow minor fix.
3378 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3379 Define only if GNU_LINUX.
3380 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3382 * dispnew.c: Integer signedness and overflow fixes.
3383 Remove unnecessary forward decls, that were a maintenance hassle.
3384 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3386 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3387 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3388 (prepare_desired_row, line_draw_cost):
3389 Use int, not unsigned, where either works.
3390 (save_current_matrix, restore_current_matrix):
3391 Use ptrdiff_t, not size_t, where either works.
3392 (init_display): Check for overflow more accurately, and without
3393 relying on undefined behavior.
3395 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3396 Remove, replacing with the new symbols in lisp.h. All uses changed.
3397 * fileio.c (make_temp_name):
3398 * filelock.c (lock_file_1, lock_file):
3399 * xdisp.c (message_dolog):
3400 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3401 Use pMd etc. instead.
3402 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3403 replacing the pWIDE etc. symbols removed from editfns.c.
3405 * keyboard.h (num_input_events): Now uintmax_t.
3406 This is (very slightly) less likely to mess up due to wraparound.
3409 * buffer.c: Integer signedness fixes.
3410 (alloc_buffer_text, enlarge_buffer_text):
3411 Use ptrdiff_t rather than size_t when either will do, as we prefer
3414 * alloc.c: Integer signedness and overflow fixes.
3415 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3416 (__malloc_size_t): Default to size_t, not to int.
3417 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3418 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3419 Prefer ptrdiff_t to size_t when either would do, as we prefer
3421 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3422 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3423 Now const. Initialize with values that are in range even if char
3425 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3426 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3427 These functions do the right thing with sizes > 2**32.
3428 (check_depth): Now ptrdiff_t, not int.
3429 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3430 Adjust to new way of storing sizes. Check for size overflow bugs
3432 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3433 slightly wrong anyway, as it missed one instance of
3434 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3435 (refill_memory_reserve): Omit needless cast to size_t.
3436 (mark_object_loop_halt): Mark as externally visible.
3438 * xselect.c: Integer signedness and overflow fixes.
3439 (Fx_register_dnd_atom, x_handle_dnd_message):
3440 Use ptrdiff_t, not size_t, since we prefer signed.
3441 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3442 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3443 x_dnd_atoms_size and x_dnd_atoms_length.
3445 * doprnt.c: Prefer signed to unsigned when either works.
3447 * doprnt.c (doprnt):
3449 * xdisp.c (vmessage):
3450 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3451 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3452 prefer signed arithmetic to avoid comparison confusion.
3453 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3454 but is a bit tricky.
3456 Assume freestanding C89 headers, string.h, stdlib.h.
3457 * data.c, doprnt.c, floatfns.c, print.c:
3458 Include float.h unconditionally.
3459 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3460 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3461 * regex.c: Likewise for stddef.h, string.h.
3462 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3463 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3464 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3465 (STDC_HEADERS): Remove obsolete defines.
3466 * sysdep.c: Include limits.h unconditionally.
3468 Assume support for memcmp, memcpy, memmove, memset.
3469 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3470 * regex.c (memcmp, memcpy):
3471 Remove; we assume C89 now.
3473 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3474 (__malloc_safe_bcopy): Remove; no longer needed.
3476 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3477 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3478 well either way, and we prefer signed to unsigned.
3480 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3482 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3483 closes the connection while we're reading (bug#9182).
3485 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3487 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3488 are specified (Bug#9168).
3490 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3492 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3493 Found by GCC static checking and --with-wide-int on a 32-bit host.
3495 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3497 * xdisp.c (compute_display_string_pos): Fix logic of caching
3498 previous display string position. Initialize cached_prev_pos to
3499 -1. Fixes slow-down at the beginning of a buffer.
3501 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3503 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3504 for attrs[LFACE_FONTSET_INDEX].
3506 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3508 * xml.c (parse_region): Remove unused local
3509 that was recently introduced.
3511 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3513 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3514 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3516 * xdisp.c (move_it_in_display_line_to): Record the best matching
3517 position for TO_CHARPOS while scanning the line, and restore it on
3518 exit if none of the characters scanned was an exact match.
3519 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3520 when exact match is impossible due to invisible text, and the
3521 lines are truncated.
3523 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3525 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3528 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3530 Fix a significant slow-down of cursor motion with C-n, C-p,
3531 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3532 auto-repeat under bidi redisplay in fontified buffers.
3533 * xdisp.c (compute_stop_pos_backwards): New function.
3534 (next_element_from_buffer): Call compute_stop_pos_backwards to
3535 find a suitable prev_stop when we find ourselves before
3537 (reseat): Don't look for prev_stop, as that could mean a very long
3539 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3540 <cached_disp_overlay_modiff>: Cache for last found display string
3542 (compute_display_string_pos): Return the cached position if asked
3543 about the same buffer in the same area of character positions, and
3544 the buffer wasn't changed since the time the display string
3545 position was cached.
3547 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3549 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3550 is an integer, which is important for empty lines. (Bug#9149)
3552 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3554 * frame.c (Fmodify_frame_parameters): In tty case, update the
3555 default face if necessary (Bug#4238).
3557 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3559 * editfns.c (Fstring_to_char): No need to explain what a character
3560 is in the docstring (Bug#6576).
3562 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3564 * xml.c (parse_region): Make sure we always return a tree.
3566 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3568 * xml.c (parse_region): If a document contains only comments,
3571 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3573 * xml.c (make_dom): Return comments, too.
3575 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3578 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3579 and the surrounding thread.
3580 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3581 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3582 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3584 * s/openbsd.h (BROKEN_SIGIO): Define.
3585 * unexelf.c (unexec) [__OpenBSD__]:
3586 Don't update the .mdebug section of the Alpha COFF symbol table.
3588 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3590 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3593 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3595 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3596 This fixes some race conditions on the permissions of any newly
3599 * alloc.c (valid_pointer_p): Use pipe, not open.
3600 This fixes some permissions issues when debugging.
3602 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3603 If fchown fails to set both uid and gid, try to set just gid,
3604 as that is sometimes allowed. Adjust the file's mode to eliminate
3605 setuid or setgid bits that are inappropriate if fchown fails.
3607 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3609 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3610 to compare Lisp_Objects.
3611 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3612 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3613 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3615 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3617 * lread.c (read_integer): Unread even EOF character.
3618 (read1): Likewise. Properly record start position of symbol.
3620 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3621 symbol character follows.
3623 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3625 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3626 This works around a problem with the previous change to Fcopy_file.
3627 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3628 and without this change, GCC might complain about discarding
3629 fchown's return value.
3631 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3633 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3635 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3637 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3639 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3641 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3642 it's used from the C level.
3644 * process.c: Use the same condition for POLL_FOR_INPUT in both
3645 keyboard.c and process.c (bug#1858).
3647 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3649 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3650 (Fgnutls_boot): Use it.
3652 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3654 * doc.c (Fsubstitute_command_keys): Revert last change.
3656 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3658 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3659 quotes the next character, and doesn't affect other longer
3660 sequences (bug#8935).
3662 * lread.c (syms_of_lread): Clarify that is isn't only
3663 `eval-buffer' and `eval-defun' that's affected by
3664 `lexical-binding' (bug#8460).
3666 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3669 bidi redisplay when a line includes both an image and is truncated.
3671 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3673 Fix minor problems found by static checking.
3674 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3675 (elsz): Now a signed constant, not a size_t var. We prefer signed
3676 types to unsigned, to avoid integer comparison confusion. Without
3677 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3678 "cannot optimize loop, the loop counter may overflow", a symptom
3680 * indent.c (Fvertical_motion): Mark locals as initialized.
3681 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3683 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3685 * search.c (Fre_search_backward): Mention `case-fold-search' in
3686 all the re_search_* functions (bug#8138).
3688 * keyboard.c (Fopen_dribble_file): Document when the file is
3691 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3693 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3696 Support bidi reordering of display and overlay strings.
3697 * xdisp.c (compute_display_string_pos)
3698 (compute_display_string_end): Accept additional argument STRING.
3699 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3700 (reseat_to_string): Initialize bidi_it->string.s and
3701 bidi_it->string.schars.
3702 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3703 NULL (avoids a crash in bidi_paragraph_init).
3704 Initialize itb.string.lstring.
3705 (init_iterator): Call bidi_init_it only of a valid
3706 buffer position was specified. Initialize paragraph_embedding to
3708 (reseat_to_string): Initialize the bidi iterator.
3709 (display_string): If we need to ignore text properties of
3710 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3711 original value of -1 will not work with bidi.)
3712 (compute_display_string_pos): First arg is now struct
3713 `text_pos *'; all callers changed. Support display properties on
3715 (compute_display_string_end): Support display properties on Lisp
3717 (init_iterator, reseat_1, reseat_to_string): Initialize the
3718 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3719 when iterating on a string not from display properties).
3720 (compute_display_string_pos, compute_display_string_end):
3721 Fix calculation of the object to scan. Fixes an error when using
3723 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3724 base_level_stop; instead, set base_level_stop to BEGV.
3725 Fixes crashes in vertical-motion.
3726 (next_element_from_buffer): Improve commentary for when
3727 the iterator is before prev_stop.
3728 (init_iterator): Initialize bidi_p from the default value of
3729 bidi-display-reordering, not from buffer-local value. Use the
3730 buffer-local value only if initializing for buffer iteration.
3731 (handle_invisible_prop): Support invisible properties on strings
3732 that are being bidi-reordered.
3733 (set_iterator_to_next): Support bidi reordering of C strings and
3735 (next_element_from_string): Support bidi reordering of Lisp
3737 (handle_stop_backwards): Support Lisp strings as well.
3738 (display_string): Support display of R2L glyph rows.
3739 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3740 (init_iterator): Don't initialize it->bidi_p for strings
3742 (reseat_to_string): Initialize it->bidi_p for strings here.
3743 (next_element_from_string, next_element_from_c_string)
3744 (next_element_from_buffer): Add xassert's for correspondence
3745 between IT's object being iterated and it->bidi_it.string
3747 (face_before_or_after_it_pos): Support bidi iteration.
3748 (next_element_from_c_string): Handle the case of the first string
3749 character that is not the first one in the visual order.
3750 (get_visually_first_element): New function, refactored from common
3751 parts of next_element_from_buffer, next_element_from_string, and
3752 next_element_from_c_string.
3753 (tool_bar_lines_needed, redisplay_tool_bar)
3754 (display_menu_bar): Force left-to-right direction. Add a FIXME
3755 comment for making that be controlled by a user option.
3756 (push_it, pop_it): Save and restore the state of the
3757 bidi iterator. Save and restore the bidi_p flag.
3758 (pop_it): Iterate out of display property for string iteration as
3760 (iterate_out_of_display_property): Support iteration over strings.
3761 (handle_single_display_spec): Set up it->bidi_it for iteration
3762 over a display string, and call bidi_init_it.
3763 (handle_single_display_spec, next_overlay_string)
3764 (get_overlay_strings_1, push_display_prop): Set up the bidi
3765 iterator for displaying display or overlay strings.
3766 (forward_to_next_line_start): Don't use the shortcut if
3768 (back_to_previous_visible_line_start): If handle_display_prop
3769 pushed the iterator stack, restore the internal state of the bidi
3770 iterator by calling bidi_pop_it same number of times.
3771 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3772 and we are bidi-iterating, don't decrement the iterator position;
3773 instead, set the first_elt flag in the bidi iterator, to produce
3775 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3776 (push_display_prop): xassert that we are iterating a buffer.
3777 (push_it, pop_it): Save and restore paragraph_embedding member.
3778 (handle_single_display_spec, next_overlay_string)
3779 (get_overlay_strings_1, reseat_1, reseat_to_string)
3780 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3781 correctly. Don't assume unibyte strings are not bidi-reordered.
3782 (compute_display_string_pos)
3783 (compute_display_string_end): Fix handling the case of C string.
3784 (push_it, pop_it): Save and restore from_disp_prop_p.
3785 (handle_single_display_spec, push_display_prop): Set the
3786 from_disp_prop_p flag.
3787 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3788 (pop_it): Call iterate_out_of_display_property only if we are
3789 popping after iteration over a string that came from a display
3790 property. Fix a typo in popping stretch info. Add an assertion
3791 for verifying that the iterator position is in sync with the bidi
3793 (handle_single_display_spec, get_overlay_strings_1)
3794 (push_display_prop): Fix initialization of paragraph direction for
3795 string when that of the parent object is not yet determined.
3796 (reseat_1): Call bidi_init_it to resync the bidi
3797 iterator with IT's position. (Bug#7616)
3798 (find_row_edges): If ROW->start.pos gives position
3799 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3800 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3801 Reset the from_disp_prop_p flag.
3802 (SAVE_IT, RESTORE_IT): New macros.
3803 (pos_visible_p, face_before_or_after_it_pos)
3804 (back_to_previous_visible_line_start)
3805 (move_it_in_display_line_to, move_it_in_display_line)
3806 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3807 (try_scrolling, redisplay_window, display_line): Use them when
3808 saving a temporary copy of the iterator and restoring it back.
3809 (back_to_previous_visible_line_start, reseat_1)
3810 (init_iterator): Empty the bidi cache "stack".
3811 (move_it_in_display_line_to): If iterator ended up at
3812 EOL, but we never saw any buffer positions smaller than
3813 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3814 motion in bidi-reordered lines.
3815 (move_it_in_display_line_to): Record prev_method and prev_pos
3816 immediately before the call to set_iterator_to_next. Fixes cursor
3817 motion in bidi-reordered lines with stretch glyphs and strings
3818 displayed in margins. (Bug#8133) (Bug#8867)
3819 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3821 (pos_visible_p): Support positions in bidi-reordered lines.
3822 Save and restore bidi cache.
3824 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3825 (bidi_paragraph_info): Delete unused struct.
3826 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3827 (bidi_cache_start): New variable.
3828 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3830 (bidi_cache_fetch_state, bidi_cache_search)
3831 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3832 (bidi_cache_find, bidi_peek_at_next_level)
3833 (bidi_level_of_next_char, bidi_find_other_level_edge)
3834 (bidi_move_to_visually_next): Compare cache index with
3835 bidi_cache_start rather than with zero.
3836 (bidi_fetch_char): Accept new argument STRING; all callers
3837 changed. Support iteration over a string. Support strings with
3838 display properties. Support unibyte strings. Fix the type of
3839 `len' according to what STRING_CHAR_AND_LENGTH expects.
3840 (bidi_paragraph_init, bidi_resolve_explicit_1)
3841 (bidi_resolve_explicit, bidi_resolve_weak)
3842 (bidi_level_of_next_char, bidi_move_to_visually_next):
3843 Support iteration over a string.
3844 (bidi_set_sor_type, bidi_resolve_explicit_1)
3845 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3846 can now be zero (for strings); special values 0 and -1 were
3847 changed to -1 and -2, respectively.
3848 (bidi_char_at_pos): New function.
3849 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3850 Call it instead of FETCH_MULTIBYTE_CHAR.
3851 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3852 initialized to valid values.
3853 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3855 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3856 the test for valid cached positions. Fix the logic for looking up
3857 the sentinel state in the cache. GCPRO the Lisp string we are
3859 (bidi_push_it, bidi_pop_it): New functions.
3860 (bidi_initialize): Initialize the bidi cache start stack pointer.
3861 (bidi_cache_ensure_space): New function, refactored from part of
3862 bidi_cache_iterator_state. Don't assume the required size is just
3863 one BIDI_CACHE_CHUNK away.
3864 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3865 (bidi_count_bytes, bidi_char_at_pos): New functions.
3866 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3867 always valid if bidi_cache_idx is valid.
3868 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3869 is valid if it's going to be used.
3870 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3871 (bidi_cache_fetch_state, bidi_cache_search)
3872 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3873 (bidi_cache_iterator_state, bidi_cache_find)
3874 (bidi_find_other_level_edge, bidi_cache_start_stack):
3875 All variables related to cache indices are now EMACS_INT.
3877 * dispextern.h (struct bidi_string_data): New structure.
3878 (struct bidi_it): New member `string'. Make flag members be 1-bit
3879 fields, and put them last in the struct.
3880 (compute_display_string_pos, compute_display_string_end):
3882 (bidi_push_it, bidi_pop_it): Add prototypes.
3883 (struct iterator_stack_entry): New members bidi_p,
3884 paragraph_embedding, and from_disp_prop_p.
3885 (struct it): Member bidi_p is now a bit field 1 bit wide.
3886 (bidi_shelve_cache, bidi_unshelve_cache):
3889 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3890 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3891 and vector-like objects.
3893 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3894 cache around display iteration.
3896 * window.c (Fwindow_end, window_scroll_pixel_based)
3897 (displayed_window_lines, Frecenter): Save and restore the bidi
3898 cache around display iteration.
3900 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3902 * editfns.c (Fdelete_region): Clarify the use of the named
3903 parameters (bug#6788).
3905 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3907 * indent.c (Fvertical_motion): Set and restore w->pointm when
3908 saving and restoring the window's buffer (Bug#9006).
3910 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3912 * editfns.c (Fstring_to_char): Clarify just what is returned
3913 (bug#6576). Text by Eli Zaretskii.
3915 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3917 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3919 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3921 * buffer.c (mmap_find): Fix a typo.
3923 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3925 Fix execution of x selection hooks.
3926 * xselect.c (Qx_lost_selection_functions)
3927 (Qx_sent_selection_functions): New vars.
3928 (syms_of_xselect): DEFSYM them.
3929 (x_handle_selection_request): Pass Qx_sent_selection_functions
3930 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3931 (x_handle_selection_clear,x_clear_frame_selections):
3932 Pass Qx_lost_selection_functions rather than
3933 Vx_lost_selection_functions to Frun_hook_with_args.
3935 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3937 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3938 The old code sometimes used this field without initializing it.
3940 * alloc.c (gc_sweep): Don't read past end of array.
3941 In theory, the old code could also have corrupted Emacs internals,
3942 though it'd be very unlikely.
3944 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3946 * character.c (Fcharacterp): Don't advertise optional ignored
3947 argument. (Bug#4026)
3949 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3951 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3954 * window.c (Fset_window_start): Doc fix (bug#4199).
3955 (Fset_window_hscroll): Ditto.
3957 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3959 Fix minor new problems caught by GCC 4.6.1.
3960 * term.c (init_tty): Remove unused local.
3961 * xsettings.c (store_monospaced_changed): Define this function only
3962 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3965 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3967 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3969 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3972 are the mini-buffer and the echo area (bug#3320).
3974 * term.c (init_tty): Remove support for supdup, c10 and perq
3975 terminals, which are no longer supported (bug#1482).
3977 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3979 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3981 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3983 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3984 for non-popups (Bug#3642).
3986 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3988 * alloc.c (reset_malloc_hooks): Protoize.
3989 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3990 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3991 * cm.c (losecursor): Likewise.
3992 * data.c (fmod): Likewise.
3993 * dispnew.c (swap_glyphs_in_rows): Likewise.
3994 * emacs.c (memory_warning_signal): Likewise.
3995 * floatfns.c (float_error): Likewise.
3996 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3997 (otf_open, font_otf_capability, generate_otf_features)
3998 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4000 * image.c (pbm_read_file): Likewise.
4001 * indent.c (string_display_width): Likewise.
4002 * intervals.c (check_for_interval, search_for_interval)
4003 (inc_interval_count, count_intervals, root_interval)
4004 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4005 * lread.c (defalias): Likewise.
4006 * ralloc.c (r_alloc_check): Likewise.
4007 * regex.c (set_image_of_range_1, set_image_of_range)
4008 (regex_grow_registers): Likewise.
4009 * sysdep.c (strerror): Likewise.
4010 * termcap.c (valid_filename_p, tprint, main): Likewise.
4011 * tparam.c (main): Likewise.
4012 * unexhp9k800.c (run_time_remap, save_data_space)
4013 (update_file_ptrs, read_header, write_header, calculate_checksum)
4014 (copy_file, copy_rest, display_header): Likewise.
4015 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4017 * xdisp.c (check_it): Likewise.
4018 * xfaces.c (register_color, unregister_color, unregister_colors):
4020 * xfns.c (print_fontset_result): Likewise.
4021 * xrdb.c (member, fatal, main): Likewise.
4023 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4025 Fix minor problems found by static checking (Bug#9031).
4026 * chartab.c (char_table_set_range, map_sub_char_table):
4027 Remove unused locals.
4028 (uniprop_table): Now static.
4029 * composite.c (_work_char): Remove unused static var.
4031 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4033 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4035 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4037 * gtkutil.c (qttip_cb): Remove code without function.
4039 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4041 * w32.c (pthread_sigmask): New stub.
4043 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4045 Use pthread_sigmask, not sigprocmask (Bug#9010).
4046 sigprocmask is portable only for single-threaded applications, and
4047 Emacs can be multi-threaded when it uses GTK.
4048 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4050 * callproc.c (Fcall_process):
4051 * process.c (create_process):
4052 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4053 Use pthread_sigmask, not sigprocmask.
4055 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4057 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4058 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4061 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4063 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4064 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4065 (xg_hide_tooltip): Fix comment.
4067 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4068 in registerServicesMenuSendTypes.
4069 (validRequestorForSendType): Don't check ns_return_types.
4071 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4074 2011-07-08 Jason Rumney <jasonr@gnu.org>
4076 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4077 SH_SHOW for hidden windows (Bug#5482).
4079 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4080 frame struct members of non-existent frames (Bug#6284).
4082 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4084 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4085 variable firstTime not needed on OSX >= 10.6.
4086 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4087 >= 10.5. Use setKnobProportion, setDoubleValue.
4089 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4090 (MAC_OS_X_VERSION_10_5): Define if not defined.
4091 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4092 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4093 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4095 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4096 cString and lossyCString on OSX >= 10.4
4098 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4099 sizeToFit on OSX >= 10.2.
4101 * nsimage.m (allocInitFromFile): Don't use deprecated method
4102 bestRepresentationForDevice on OSX >= 10.6.
4104 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4107 * emacs.c: Declare unexec_init_emacs_zone.
4109 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4111 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4113 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4114 on svcsMenu (Bug#8842).
4116 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4118 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4120 * nsterm.m (QUTF8_STRING): Declare.
4121 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4122 (validRequestorForSendType): Return type is (id).
4123 Change indexOfObjectIdenticalTo to indexOfObject.
4124 Check if we have local selection before returning self (Bug#8842).
4125 (writeSelectionToPasteboard): Put local selection into paste board
4126 if we have a local selection (Bug#8842).
4127 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4129 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4130 (ns_get_local_selection): Declare.
4132 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4134 * keymap.c (describe_map_tree): Don't insert a double newline at
4135 the end of the buffer (bug#1169) and return whether we inserted
4138 * callint.c (Fcall_interactively): Change "reading args" to
4139 "providing args" to try to clarify what it does (bug#1010).
4141 2011-07-07 Kenichi Handa <handa@m17n.org>
4143 * composite.c (composition_compute_stop_pos): Ignore a static
4144 composition starting before CHARPOS (Bug#8915).
4146 * xdisp.c (handle_composition_prop): Likewise.
4148 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4150 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4153 2011-07-07 Kenichi Handa <handa@m17n.org>
4155 * character.h (unicode_category_t): New enum type.
4157 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4158 (Qchar_code_property_table): New variable.
4159 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4160 (UNIPROP_COMPRESSED_FORM_P): New macros.
4161 (char_table_ascii): Uncompress the compressed values.
4162 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4163 Uncompress the compressed values.
4164 (sub_char_table_ref_and_range): Likewise.
4165 (char_table_ref_and_range): Uncompress the compressed values.
4166 (sub_char_table_set): New arg is_uniprop. Callers changed.
4167 Uncompress the compressed values.
4168 (sub_char_table_set_range): Args changed. Callers changed.
4169 (char_table_set_range): Adjuted for the above change.
4170 (map_sub_char_table): Delete args default_val and parent. Add arg
4171 top. Give decoded values to a Lisp function.
4172 (map_char_table): Adjust for the above change. Give decoded
4173 values to a Lisp function. Gcpro more variables.
4174 (uniprop_table_uncompress)
4175 (uniprop_decode_value_run_length): New functions.
4176 (uniprop_decoder, uniprop_decoder_count): New variables.
4177 (uniprop_get_decoder, uniprop_encode_value_character)
4178 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4180 (uniprop_encoder, uniprop_encoder_count): New variables.
4181 (uniprop_get_encoder, uniprop_table)
4182 (Funicode_property_table_internal, Fget_unicode_property_internal)
4183 (Fput_unicode_property_internal): New functions.
4184 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4185 Sunicode_property_table_internal, Sget_unicode_property_internal,
4186 and Sput_unicode_property_internal. Defvar_lisp
4187 char-code-property-alist.
4189 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4190 Vunicode_category_table.
4192 * font.c (font_range): Adjust for the change of
4193 Vunicode_category_table.
4195 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4197 * m/iris4d.h: Remove file, move contents ...
4198 * s/irix6-5.h: ... here.
4200 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4202 Remove unportable assumption about struct layout (Bug#8884).
4203 * alloc.c (mark_buffer):
4204 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4205 (clone_per_buffer_values): Don't assume that
4206 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4207 This isn't true in general, and it's particularly not true
4208 if Emacs is configured with --with-wide-int.
4209 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4210 New macros, used in the buffer.c change.
4212 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4214 * xsettings.c: Use both GConf and GSettings if both are available.
4215 (store_config_changed_event): Add comment.
4216 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4217 (store_tool_bar_style_changed): New functions.
4218 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4219 (struct xsettings): Move font inside HAVE_XFT.
4220 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4221 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4222 Move inside HAVE_XFT.
4223 (something_changed_gsettingsCB): Rename from something_changedCB.
4224 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4226 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4227 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4228 (something_changed_gconfCB): Rename from something_changedCB.
4229 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4230 (parse_settings): Move check for font inside HAVE_XFT.
4231 (read_settings, apply_xft_settings): Add comment.
4232 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4233 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4234 call store_font_name_changed.
4235 (xft_settings_event): Add comment.
4236 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4237 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4238 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4239 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4240 (xsettings_initialize): Call init_gsettings last.
4241 (xsettings_get_system_font, xsettings_get_system_normal_font):
4244 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4246 Random fixes. E.g., (random) never returned negative values.
4247 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4248 subseconds part to the entropy, as that's a bit more random.
4249 Prefer signed to unsigned, since the signedness doesn't matter and
4250 in general we prefer signed. When given a limit, use a
4251 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4252 latter isn't right if USE_2_TAGS_FOR_INTS.
4253 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4254 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4256 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4258 * textprop.c (text_property_stickiness):
4259 Obey Vtext_property_default_nonsticky.
4260 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4261 * w32fns.c (syms_of_w32fns):
4262 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4264 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4266 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4267 This is more efficient than Ffile_directory_p and avoids a minor race.
4269 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4271 * buffer.c (Foverlay_put): Say what the return value is
4274 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4275 is a directory before asking whether to use the file name
4277 (barf_or_query_if_file_exists): Make the "File is a directory"
4278 error be more correct.
4280 * fns.c (Frequire): Remove the mention of the .gz files, since
4281 that's installation-specific, but keep the mention of
4282 `get-load-suffixes'.
4284 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4286 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4287 Report string overflow if the output is too long.
4289 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4291 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4292 (syms_of_gnutls): Remove duplicate DEFSYM for
4293 Qgnutls_bootprop_verify_hostname_error, an error for
4294 Qgnutls_bootprop_verify_error (which is no longer used).
4296 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4297 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4298 Also (re)move comments that are misplaced or no longer relevant.
4300 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4302 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4304 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4306 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4307 and background color parameters if they have been changed.
4309 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4311 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4313 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4315 * xsettings.c (SYSTEM_FONT): Define only when used.
4316 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4318 * keymap.c (access_keymap_1): Now static.
4320 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4322 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4323 leave any prefix arg for the up event (Bug#1586).
4325 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4327 * lread.c (syms_of_lread): Mention single symbols defined by
4328 `defvar' or `defconst' (bug#7154).
4330 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4331 (Frequire): Mention get-load-suffixes.
4333 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4335 * window.h (window): Remove clone_number slot.
4336 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4338 (make_parent_window, make_window, saved_window)
4339 (Fset_window_configuration, save_window_save): Don't deal with
4341 * buffer.c (Qclone_number): Remove declaration.
4342 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4344 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4346 Add multiple inheritance to keymaps.
4347 * keymap.c (Fmake_composed_keymap): New function.
4348 (Fset_keymap_parent): Simplify.
4349 (fix_submap_inheritance): Remove.
4350 (access_keymap_1): New function extracted from access_keymap to handle
4351 embedded parents and handle lists of maps.
4352 (access_keymap): Use it.
4353 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4354 (Fcopy_keymap): Handle embedded parents.
4355 (Fcommand_remapping, define_as_prefix): Simplify.
4356 (Fkey_binding): Simplify.
4357 (syms_of_keymap): Move minibuffer-local-completion-map,
4358 minibuffer-local-filename-completion-map,
4359 minibuffer-local-must-match-map, and
4360 minibuffer-local-filename-must-match-map to Elisp.
4361 (syms_of_keymap): Defsubr make-composed-keymap.
4362 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4363 (parse_menu_item): Trivial simplification.
4365 2011-07-01 Glenn Morris <rgm@gnu.org>
4367 * Makefile.in (SETTINGS_LIBS): Fix typo.
4369 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4371 * coding.c (Fencode_coding_string): Record the last coding system
4372 used, as the function doc string says (bug#8738).
4374 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4376 * xsettings.c (store_monospaced_changed): Take new font as arg and
4377 check for change against current_mono_font.
4378 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4379 (emacs_settings_constructor, emacs_settings_get_property)
4380 (emacs_settings_set_property, emacs_settings_class_init)
4381 (emacs_settings_init, gsettings_obj): Remove.
4382 (something_changedCB): New function for HAVE_GSETTINGS.
4383 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4384 with value as argument.
4385 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4386 g_settings_new (Bug#8967). Do not create gsettings_obj.
4387 Remove calls to g_settings_bind. Connect something_changedCB to
4390 * xgselect.c: Add defined (HAVE_GSETTINGS).
4391 (xgselect_initialize): Ditto.
4393 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4394 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4397 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4399 * eval.c (struct backtrace): Simplify and port the data structure.
4400 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4401 signed bit field, as this assumption is not portable and it makes
4402 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4403 "char debug_on_exit : 1" as this is not portable either; instead,
4404 use the portable "unsigned int debug_on_exit : 1". Remove unused
4405 member evalargs. Remove obsolete comments about cc bombing out.
4407 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4409 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4410 Let HAVE_GSETTINGS override HAVE_GCONF.
4411 (store_monospaced_changed): New function.
4412 (EMACS_SETTINGS): A new type derived from GObject to handle
4413 GSettings notifications.
4414 (emacs_settings_constructor, emacs_settings_get_property)
4415 (emacs_settings_set_property, emacs_settings_class_init):
4417 (gsettings_client, gsettings_obj): New variables.
4418 (GSETTINGS_SCHEMA): New define.
4419 (something_changedCB): Call store_monospaced_changed.
4420 (init_gsettings): New function.
4421 (xsettings_initialize): Call init_gsettings.
4422 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4425 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4428 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4430 * window.c (resize_root_window, grow_mini_window)
4431 (shrink_mini_window): Rename Qresize_root_window to
4432 Qwindow_resize_root_window and Qresize_root_window_vertically to
4433 Qwindow_resize_root_window_vertically.
4435 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4437 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4439 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4441 * makefile.w32-in: Redesign dependencies so they reflect more
4442 clearly which files are directly included by each source file,
4443 and not through other includes.
4445 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4447 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4448 (sort_overlays, overlay_strings): When an overlay's clone number
4449 matches the window's clone number process the overlay even if
4450 the overlay's window property doesn't match the current window.
4452 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4453 (Fwindow_hchild): Rename to Fwindow_left_child.
4454 (Fwindow_next): Rename to Fwindow_next_sibling.
4455 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4456 (resize_window_check): Rename to window_resize_check.
4457 (resize_window_apply): Rename to window_resize_apply.
4458 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4459 (Fdelete_other_windows_internal, resize_frame_windows)
4460 (Fsplit_window_internal, Fdelete_window_internal)
4461 (grow_mini_window, shrink_mini_window)
4462 (Fresize_mini_window_internal): Fix callers accordingly.
4464 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4466 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4467 (emacs_fixed_set_min_size): Remove.
4468 (emacs_fixed_new): Take frame as argument.
4470 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4471 (_EmacsFixedPrivate): Remove minwidth/height.
4472 Add struct frame *f.
4473 (emacs_fixed_init): Initialize priv->f.
4474 (get_parent_class, emacs_fixed_set_min_size): Remove.
4475 (emacs_fixed_new): Set priv->f to argument.
4476 (emacs_fixed_get_preferred_width)
4477 (emacs_fixed_get_preferred_height): Use min_width/height from
4478 frames size_hint to set minimum and natural (Bug#8919).
4479 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4480 and use min_width/height from frames size_hint to set
4481 min_width/height (Bug#8919).
4483 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4484 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4487 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4489 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4490 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4493 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4495 * process.c (wait_reading_process_output): Bypass select if
4496 waiting for a cell while ignoring keyboard input, and input is
4497 pending. Suggested by Jan Djärv (Bug#8869).
4499 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4501 Use gnulib's dup2 module instead of rolling our own.
4502 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4504 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4506 * dispnew.c (scrolling_window): Before scrolling, turn off a
4507 mouse-highlight in the window being scrolled.
4509 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4511 Move DEFSYM to lisp.h and use everywhere.
4513 * character.h (DEFSYM): Move declaration...
4514 * lisp.h (DEFSYM): ...here.
4520 * w32select.c: Don't include character.h.
4522 * alloc.c (syms_of_alloc):
4523 * buffer.c (syms_of_buffer):
4524 * bytecode.c (syms_of_bytecode):
4525 * callint.c (syms_of_callint):
4526 * casefiddle.c (syms_of_casefiddle):
4527 * casetab.c (init_casetab_once):
4528 * category.c (init_category_once, syms_of_category):
4529 * ccl.c (syms_of_ccl):
4530 * cmds.c (syms_of_cmds):
4531 * composite.c (syms_of_composite):
4532 * dbusbind.c (syms_of_dbusbind):
4533 * dired.c (syms_of_dired):
4534 * dispnew.c (syms_of_display):
4535 * doc.c (syms_of_doc):
4536 * editfns.c (syms_of_editfns):
4537 * emacs.c (syms_of_emacs):
4538 * eval.c (syms_of_eval):
4539 * fileio.c (syms_of_fileio):
4540 * fns.c (syms_of_fns):
4541 * frame.c (syms_of_frame):
4542 * fringe.c (syms_of_fringe):
4543 * insdel.c (syms_of_insdel):
4544 * keymap.c (syms_of_keymap):
4545 * lread.c (init_obarray, syms_of_lread):
4546 * macros.c (syms_of_macros):
4547 * msdos.c (syms_of_msdos):
4548 * print.c (syms_of_print):
4549 * process.c (syms_of_process):
4550 * search.c (syms_of_search):
4551 * sound.c (syms_of_sound):
4552 * syntax.c (init_syntax_once, syms_of_syntax):
4553 * terminal.c (syms_of_terminal):
4554 * textprop.c (syms_of_textprop):
4555 * undo.c (syms_of_undo):
4556 * w32.c (globals_of_w32):
4557 * window.c (syms_of_window):
4558 * xdisp.c (syms_of_xdisp):
4559 * xfaces.c (syms_of_xfaces):
4560 * xfns.c (syms_of_xfns):
4561 * xmenu.c (syms_of_xmenu):
4562 * xsettings.c (syms_of_xsettings):
4563 * xterm.c (syms_of_xterm): Use DEFSYM.
4565 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4567 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4569 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4571 Integer and buffer overflow fixes (Bug#8873).
4573 * print.c (printchar, strout): Check for string overflow.
4574 (PRINTPREPARE, printchar, strout):
4575 Don't set size unless allocation succeeds.
4577 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4578 for sizes. Check for string overflow more accurately.
4579 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4581 * macros.c: Integer and buffer overflow fixes.
4582 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4583 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4584 Use ptrdiff_t, not int, for sizes.
4585 Don't increment bufsize until after realloc succeeds.
4586 Check for size-calculation overflow.
4587 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4589 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4591 * lread.c: Integer overflow fixes.
4592 (read_integer): Radix is now EMACS_INT, not int,
4593 to improve quality of diagnostics for out-of-range radices.
4594 Calculate buffer size correctly for out-of-range radices.
4595 (read1): Check for integer overflow in radices, and in
4596 read-circle numbers.
4597 (read_escape): Avoid int overflow.
4598 (Fload, openp, read_buffer_size, read1)
4599 (substitute_object_recurse, read_vector, read_list, map_obarray):
4600 Use ptrdiff_t, not int, for sizes.
4601 (read1): Use EMACS_INT, not int, for sizes.
4602 Check for size overflow.
4604 * image.c (cache_image): Check for size arithmetic overflow.
4606 * lread.c: Integer overflow issues.
4607 (saved_doc_string_size, saved_doc_string_length)
4608 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4609 Now ptrdiff_t, not int.
4610 (read1): Don't assume doc string length fits in int. Check for
4611 out-of-range doc string lengths.
4612 (read_list): Don't assume file position fits in int.
4613 (read_escape): Check for hex character overflow.
4615 2011-06-22 Leo Liu <sdl.web@gmail.com>
4617 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4618 Move to minibuffer.el.
4620 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4622 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4623 The following patches are for when GLYPH_DEBUG && !XASSERT.
4624 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4625 * dispnew.c (flush_stdout):
4626 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4627 Mark as externally visible.
4628 * dispnew.c (check_window_matrix_pointers): Now static.
4629 * dispnew.c (window_to_frame_vpos):
4630 * xfns.c (unwind_create_frame):
4631 * xterm.c (x_check_font): Remove unused local.
4632 * scroll.c (CHECK_BOUNDS):
4633 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4634 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4635 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4636 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4637 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4639 (debug_method_add): Use va_list and vsprintf rather than relying
4640 on undefined behavior with wrong number of arguments.
4641 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4642 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4643 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4644 since we're not interested in debugging glyphs with old libraries.
4645 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4646 GCC 4.6.0's static checking.
4648 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4650 Integer overflow and signedness fixes (Bug#8873).
4651 A few related buffer overrun fixes, too.
4653 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4655 * dispextern.h (struct face.stipple):
4656 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4657 (x_bitmap_mask, x_allocate_bitmap_record)
4658 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4659 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4660 (x_create_bitmap_from_xpm_data):
4661 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4662 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4664 * xfaces.c (load_pixmap):
4665 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4666 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4667 (.bitmaps_last, struct x_output.icon_bitmap):
4668 Use ptrdiff_t, not int, for bitmap indexes.
4669 (x_allocate_bitmap_record): Check for size overflow.
4670 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4672 Use ptrdiff_t, not int, for overlay counts.
4673 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4674 * editfns.c (overlays_around, get_pos_property):
4675 * textprop.c (get_char_property_and_overlay):
4676 * xdisp.c (next_overlay_change, note_mouse_highlight):
4677 * xfaces.c (face_at_buffer_position):
4678 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4679 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4680 (Fnext_overlay_change, Fprevious_overlay_change)
4681 (mouse_face_overlay_overlaps, Foverlays_in):
4682 Use ptrdiff_t, not int, for sizes.
4683 (overlays_at, overlays_in): Check for size-calculation overflow.
4685 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4687 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4688 (x_session_initialize): Do not assume string length fits in int.
4690 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4691 This is unlikely, but can occur if DPI is outlandish.
4693 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4694 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4696 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4697 * xrdb.c (magic_file_p, search_magic_path):
4698 Omit last arg SUFFIX; it was always 0. All callers changed.
4699 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4701 * xfont.c (xfont_match): Avoid need for strlen.
4703 * xfns.c: Don't assume strlen fits in int.
4704 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4706 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4707 not unsigned long, as we prefer signed integers. All callers changed.
4708 Detect integer overflow in repeat count.
4709 (message_dolog): Don't assume print length fits in 39 bytes.
4710 (display_mode_element): Don't assume strlen fits in int.
4712 * termcap.c: Don't assume sizes fit in int and never overflow.
4713 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4714 (gobble_line): Check for size-calculation overflow.
4716 * minibuf.c (Fread_buffer):
4717 * lread.c (intern, intern_c_string):
4718 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4719 Don't assume string length fits in int.
4721 * keyboard.c (parse_tool_bar_item):
4722 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4724 * font.c: Don't assume string length fits in int.
4725 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4726 Use ptrdiff_t, not int.
4727 (font_intern_prop): Don't assume string length fits in int.
4728 Don't assume integer property fits in fixnum.
4729 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4731 * filelock.c: Fix some buffer overrun and integer overflow issues.
4732 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4733 Reformulate so as not to need the command string.
4734 Invoke gzip -cd rather than gunzip, as it's more portable.
4735 (lock_info_type, lock_file_1, lock_file):
4736 Don't assume pid_t and time_t fit in unsigned long.
4737 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4738 (current_lock_owner): Prefer signed type for sizes.
4739 Use memcpy, not strncpy, where memcpy is what is really wanted.
4740 Don't assume (via atoi) that time_t and pid_t fit in int.
4741 Check for time_t and/or pid_t out of range, e.g., via a network share.
4742 Don't alloca where an auto var works fine.
4744 * fileio.c: Fix some integer overflow issues.
4745 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4746 Don't assume string length fits in int.
4747 (directory_file_name): Don't assume string length fits in long.
4748 (make_temp_name): Don't assume pid fits in int, or that its print
4749 length is less than 20.
4751 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4753 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4755 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4757 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4758 We prefer signed integers, even for size calculations.
4760 * emacs.c: Don't assume string length fits in 'int'.
4761 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4762 (main): Don't invoke strlen when not needed.
4764 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4765 (XD_DEBUG_MESSAGE): Don't waste a byte.
4767 * callproc.c (getenv_internal_1, getenv_internal)
4769 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4771 * lread.c (invalid_syntax): Omit length argument.
4772 All uses changed. This doesn't fix a bug, but it simplifies the
4773 code away from its former Hollerith-constant appearance, and it's
4774 one less 'int' to worry about when looking at integer-overflow issues.
4775 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4777 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4778 This didn't break anything, but it didn't help either.
4779 It's confusing to put a bogus integer in a place where the actual
4780 value does not matter.
4781 (LIST_END_P): Remove unused macro and its bogus comment.
4782 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4784 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4785 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4787 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4788 We prefer signed types, and the value cannot exceed the EMACS_INT
4789 range anyway (because otherwise the length would not be representable).
4790 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4791 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4792 This avoids a GCC warning when WIDE_EMACS_INT.
4794 * indent.c (sane_tab_width): New function.
4795 (current_column, scan_for_column, Findent_to, position_indentation)
4796 (compute_motion): Use it. This is just for clarity.
4797 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4799 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4801 * lisp.h (lint_assume): New macro.
4802 * composite.c (composition_gstring_put_cache):
4803 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4805 * editfns.c, insdel.c:
4806 Omit unnecessary forward decls, to simplify future changes.
4808 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4810 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4812 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4813 Use much-faster test for byte-length change.
4814 Don't assume string byte-length fits in 'int'.
4815 Check that character arg fits in 'int'.
4816 (mapcar1): Declare byte as byte, for clarity.
4818 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4820 * fns.c (concat): Catch string overflow earlier.
4821 Do not rely on integer wraparound.
4823 * dispextern.h (struct it.overlay_strings_charpos)
4824 (struct it.selective): Now EMACS_INT, not int.
4825 * xdisp.c (forward_to_next_line_start)
4826 (back_to_previous_visible_line_start)
4827 (reseat_at_next_visible_line_start, next_element_from_buffer):
4828 Don't arbitrarily truncate the value of 'selective' to int.
4830 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4832 * composite.c: Don't truncate sizes to 'int'.
4833 (composition_gstring_p, composition_reseat_it)
4834 (composition_adjust_point): Use EMACS_INT, not int.
4835 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4836 not EMACS_UINT, for indexes.
4838 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4840 * buffer.c: Include <verify.h>.
4841 (struct sortvec.priority, struct sortstr.priority):
4842 Now EMACS_INT, not int.
4843 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4844 (struct sortstr.size, record_overlay_string)
4845 (struct sortstrlist.size, struct sortlist.used):
4846 Don't truncate size to int.
4847 (record_overlay_string): Check for size-calculation overflow.
4848 (init_buffer_once): Check at compile-time, not run-time.
4850 2011-06-22 Jim Meyering <meyering@redhat.com>
4852 Don't leak an XBM-image-sized buffer
4853 * image.c (xbm_load): Free the image buffer after using it.
4855 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4858 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4859 that Sun C diagnosed.
4860 * fns.c (secure_hash): Fix pointer signedness issue.
4861 * intervals.c (static_offset_intervals): New function.
4862 (offset_intervals): Use it.
4864 2011-06-21 Leo Liu <sdl.web@gmail.com>
4867 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4870 * fns.c (secure_hash): Rename from crypto_hash_function and change
4871 the first arg to accept symbols.
4872 (Fsecure_hash): New primitive.
4873 (syms_of_fns): New symbols.
4875 2011-06-20 Deniz Dogan <deniz@dogan.se>
4877 * process.c (Fset_process_buffer): Clarify return value in
4880 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4882 * dispnew.c (add_window_display_history): Use BVAR.
4884 * xdisp.c (debug_method_add): Use BVAR.
4885 (check_window_end, dump_glyph_matrix, dump_glyph)
4886 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4888 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4891 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4892 check till after the cache is created in init_frame_faces.
4894 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4896 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4898 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4900 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4901 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4902 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4904 Improve buffer-overflow checking (Bug#8873).
4905 * fileio.c (Finsert_file_contents):
4906 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4907 Remove the old (too-loose) buffer overflow checks.
4908 They weren't needed, since make_gap checks for buffer overflow.
4909 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4910 The old code merely checked for Emacs fixnum overflow, and relied
4911 on undefined (wraparound) behavior. The new code avoids undefined
4912 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4914 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4915 Tune. Don't use wider integers than needed. Don't use alloca.
4916 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4918 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4920 * insdel.c, lisp.h (buffer_overflow): New function.
4921 (insert_from_buffer_1, replace_range, replace_range_2):
4922 * insdel.c (make_gap_larger):
4923 * editfns.c (Finsert_char):
4924 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4926 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4928 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4930 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4932 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4933 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4935 * fileio.c: Don't assume EMACS_INT fits in off_t.
4936 (emacs_lseek): New static function.
4937 (Finsert_file_contents, Fwrite_region): Use it.
4938 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4940 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4942 * fns.c: Don't overflow int when computing a list length.
4943 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4944 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4945 truncation on 64-bit hosts. Check for QUIT every
4946 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4947 faster and is responsive enough.
4948 (Flength): Report an error instead of overflowing an integer.
4949 (Fsafe_length): Return a float if the value is not representable
4950 as a fixnum. This shouldn't happen except in contrived situations.
4951 (Fnthcdr, Fsort): Don't assume list length fits in int.
4952 (Fcopy_sequence): Don't assume vector length fits in int.
4954 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4955 (header_size, word_size): New constants.
4956 (allocate_vectorlike): Don't check size overflow here.
4957 (allocate_vector): Check it here instead, since this is the only
4958 caller of allocate_vectorlike that could cause overflow.
4959 Check that the new vector's length is representable as a fixnum.
4961 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4962 The previous code was bogus. For example, next_almost_prime (32)
4963 returned 39, which is undesirable as it is a multiple of 3; and
4964 next_almost_prime (24) returned 25, which is a multiple of 5 so
4965 why was the code bothering to check for multiples of 7?
4967 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4969 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4971 Variadic C functions now count arguments with ptrdiff_t.
4972 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4973 Back then I didn't know that the Emacs coding style prefers signed int.
4974 Also, in the meantime I found a few more instances where arguments
4975 were being counted with int, which may truncate counts on 64-bit
4976 machines, or EMACS_INT, which may be unnecessarily wide.
4977 * lisp.h (struct Lisp_Subr.function.aMANY)
4978 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4979 Arg counts are now ptrdiff_t, not size_t.
4980 All variadic functions and their callers changed accordingly.
4981 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4982 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4983 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4984 * callint.c (Fcall_interactively): Check arg count for overflow,
4985 to avoid potential buffer overrun. Use signed char, not 'int',
4986 for 'varies' array, so that we needn't bother to check its size
4987 calculation for overflow.
4988 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4989 * eval.c (apply_lambda):
4990 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4991 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4992 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4994 * callint.c (Fcall_interactively): Don't use index var as event count.
4996 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4997 * mem-limits.h (SIZE): Remove; no longer used.
4999 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5001 Remove unnecessary casts.
5002 * xterm.c (x_term_init):
5003 * xfns.c (x_set_border_pixel):
5004 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5005 These aren't needed now that we assume ANSI C.
5007 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5008 It's more likely to cause problems (due to unsigned overflow)
5011 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5013 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5015 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5017 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5019 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5021 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5023 GLYPH_CODE_FACE returns EMACS_INT, not int.
5024 * dispextern.h (merge_faces):
5025 * xfaces.c (merge_faces):
5026 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5027 Don't assume EMACS_INT fits in int.
5029 * character.h (CHAR_VALID_P): Remove unused parameter.
5030 * fontset.c, lisp.h, xdisp.c: All uses changed.
5032 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5034 * fns.c (concat): Minor tuning based on overflow analysis.
5035 This doesn't fix any bugs. Use int to hold character, instead
5036 of constantly refetching from Emacs object. Use XFASTINT, not
5037 XINT, for value known to be a character. Don't bother comparing
5038 a single byte to 0400, as it's always less.
5040 * floatfns.c (Fexpt):
5041 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5043 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5046 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5048 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5049 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5050 incorrectly succeed when S was a string, because 4294967386 was
5051 truncated before it was used.
5053 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5054 Otherwise, an out-of-range integer could cause undefined behavior
5057 * composite.c: Use int, not EMACS_INT, for characters.
5058 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5059 EMACS_INT, for values that are known to be in character range.
5060 This doesn't fix any bugs but is the usual style inside Emacs and
5061 may generate better code on 32-bit machines.
5063 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5064 This is for reasons similar to the recent CHAR_STRING fix.
5065 * charset.c (Fencode_char): Check that character arg is actually
5066 a character. Pass an int to ENCODE_CHAR.
5067 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5068 wider than 'int', as a compile-time check to prevent future regressions
5071 * character.c (char_string): Remove unnecessary casts.
5073 Make sure a 64-bit char is never passed to CHAR_STRING.
5074 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5075 by silently ignoring the top 32 bits, allowing some values
5076 that were far too large to be valid characters.
5077 * character.h: Include <verify.h>.
5078 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5079 arguments are no wider than unsigned, as a compile-time check
5080 to prevent future regressions in this area.
5082 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5083 (Fsubst_char_in_region):
5085 * xdisp.c (decode_mode_spec_coding):
5086 Adjust to CHAR_STRING's new requirement.
5087 * editfns.c (Finsert_char, Fsubst_char_in_region):
5088 * fns.c (concat): Check that character args are actually
5089 characters. Without this test, these functions did the wrong
5090 thing with wildly out-of-range values on 64-bit hosts.
5092 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5093 These casts should not be needed on 32-bit hosts, either.
5094 * keyboard.c (read_char):
5095 * lread.c (Fload): Remove casts to unsigned.
5097 * lisp.h (UNSIGNED_CMP): New macro.
5098 This fixes comparison bugs on 64-bit hosts.
5099 (ASCII_CHAR_P): Use it.
5100 * casefiddle.c (casify_object):
5101 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5102 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5103 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5104 * dispextern.h (FACE_FROM_ID):
5105 * keyboard.c (read_char): Use UNSIGNED_CMP.
5107 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5108 not to EMACS_INT, to avoid GCC warning.
5110 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5112 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5113 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5114 isn't needed on 32-bit machines.
5116 * buffer.c (Fgenerate_new_buffer_name):
5117 Use EMACS_INT for count, not int.
5118 (advance_to_char_boundary): Return EMACS_INT, not int.
5120 * data.c (Qcompiled_function): Now static.
5122 * window.c (window_body_lines): Now static.
5124 * image.c (gif_load): Rename local to avoid shadowing.
5126 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5127 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5128 * alloc.c (make_save_value): Integer argument is now of type
5130 (mark_object): Use ptrdiff_t, not int.
5131 * lisp.h (pD): New macro.
5132 * print.c (print_object): Use it.
5134 * alloc.c: Use EMACS_INT, not int, to count objects.
5135 (total_conses, total_markers, total_symbols, total_vector_size)
5136 (total_free_conses, total_free_markers, total_free_symbols)
5137 (total_free_floats, total_floats, total_free_intervals)
5138 (total_intervals, total_strings, total_free_strings):
5139 Now EMACS_INT, not int. All uses changed.
5140 (Fgarbage_collect): Compute overall total using a double, so that
5141 integer overflow is less likely to be a problem. Check for overflow
5142 when converting back to an integer.
5143 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5144 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5145 These were 'int' variables that could overflow on 64-bit hosts;
5146 they were never used, so remove them instead of repairing them.
5147 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5148 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5149 Previously, this ceilinged at INT_MAX, but that doesn't work on
5151 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5153 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5154 (allocate_vectorlike): Check for ptrdiff_t overflow.
5155 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5156 when a (possibly-narrower) signed value would do just as well.
5157 We prefer using signed arithmetic, to avoid comparison confusion.
5159 * alloc.c: Catch some string size overflows that we were missing.
5160 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5161 for convenience in STRING_BYTES_MAX.
5162 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5163 The definition here is exact; the one in lisp.h was approximate.
5164 (allocate_string_data): Check for string overflow. This catches
5165 some instances we weren't catching before. Also, it catches
5166 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5167 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5168 and ptrdiff_t and EMACS_INT are both 64 bits.
5170 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5171 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5172 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5174 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5176 * alloc.c (Fmake_string): Check for out-of-range init.
5178 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5180 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5182 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5184 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5185 xg_get_default_scrollbar_width.
5187 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5188 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5189 (style_changed_cb): Call update_theme_scrollbar_width and call
5190 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5191 all frames (Bug#8505).
5192 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5193 Call gtk_window_set_resizable if HAVE_GTK3.
5194 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5195 and height if HAVE_GTK3 (Bug#8505).
5196 (scroll_bar_width_for_theme): New variable.
5197 (update_theme_scrollbar_width): New function.
5198 (xg_get_default_scrollbar_width): Move code to
5199 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5200 (xg_initialize): Call update_theme_scrollbar_width.
5202 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5204 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5206 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5208 * frame.c (make_frame): Call other_buffer_safely instead of
5211 * window.c (temp_output_buffer_show): Call display_buffer with
5212 second argument Vtemp_buffer_show_specifiers and reset latter
5213 immediately after the call.
5214 (Vtemp_buffer_show_specifiers): New variable.
5215 (auto_window_vscroll_p, next_screen_context_lines)
5216 (Vscroll_preserve_screen_position): Remove leading asterisks from
5219 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5221 Fix minor problems found by GCC 4.6.0 static checking.
5222 * buffer.c (Qclone_number): Remove for now, as it's unused.
5223 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5224 (record_buffer): Remove unused local.
5225 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5226 (set_frame_buffer_list): Remove; unused.
5227 * frame.h (other_visible_frames): Remove decl.
5228 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5229 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5230 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5232 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5233 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5234 Define only if HAVE_GPM.
5235 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5236 (update_hints_inhibit): Remove; never set. All uses removed.
5237 * widgetprv.h (emacsFrameClassRec): Remove decl.
5238 * window.c (delete_deletable_window): Now returns void, since it
5239 wasn't returning anything.
5240 (compare_window_configurations): Remove unused locals.
5241 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5242 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5243 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5244 the same widths as pointers. This follows up on the 2011-05-06 patch.
5245 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5246 * xterm.h: Likewise.
5247 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5249 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5251 * makefile.w32-in: Update dependencies.
5252 (LISP_H): Add lib/intprops.h.
5254 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5256 * image.c (gif_load): Add animation frame delay to the metadata.
5257 (syms_of_image): Use DEFSYM. New symbol `delay'.
5259 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5261 * window.c (delete_deletable_window): Re-add.
5262 (Fset_window_configuration): Rewrite to handle dead buffers and
5263 consequently deletable windows.
5264 (window_tree, Fwindow_tree): Remove. Supply functionality in
5266 (compare_window_configurations): Simplify code.
5268 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5270 * image.c (imagemagick_load_image): Fix type mismatch.
5271 (Fimagemagick_types): Likewise.
5273 * window.h (replace_buffer_in_windows): Declare.
5275 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5277 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5278 Qclone_number. Remove external declaration of Qdelete_window.
5279 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5281 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5282 Run Qbuffer_list_update_hook if allowed.
5283 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5284 buffer list implementation.
5285 (other_buffer_safely): New function.
5286 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5287 calls to replace_buffer_in_windows and
5288 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5290 (record_buffer): Inhibit quitting and rewrite using quittable
5291 functions. Run Qbuffer_list_update_hook if allowed.
5292 (Frecord_buffer, Funrecord_buffer): New functions.
5293 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5294 Move switch-to-buffer to window.el.
5295 (bury-buffer): Move to window.el.
5296 (Vbuffer_list_update_hook): New variable.
5298 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5301 * window.h (resize_frame_windows): Move up in code.
5302 (Fwindow_frame): Remove EXFUN.
5303 (replace_buffer_in_all_windows): Remove prototype.
5304 (replace_buffer_in_windows_safely): Add prototype.
5306 * window.c: Declare Qdelete_window static again. Move down
5307 declaration of select_count.
5308 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5309 (Fother_window): Move to window.el.
5310 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5311 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5312 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5314 (replace_buffer_in_windows): Implement by calling
5315 Qreplace_buffer_in_windows.
5316 (replace_buffer_in_all_windows): Remove with some functionality
5317 moved into replace_buffer_in_windows_safely.
5318 (replace_buffer_in_windows_safely): New function.
5319 (select_window_norecord, select_frame_norecord): Move in front
5320 of run_window_configuration_change_hook. Remove now obsolete
5322 (Fset_window_buffer): Rewrite doc-string.
5323 Call Qrecord_window_buffer.
5324 (keys_of_window): Move binding for other-window to window.el.
5326 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5328 * dispextern.h (struct image): Replace data member, whose int_val
5329 and ptr_val fields were not used by anything, with a single
5332 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5333 (gif_clear_image, gif_load, imagemagick_load_image)
5334 (gs_clear_image, gs_load): Callers changed.
5336 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5338 * buffer.h: Include <time.h>, for time_t.
5339 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5341 Fix minor problems found by static checking.
5343 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5345 Make identifiers static if they are not used in other modules.
5346 * data.c (Qcompiled_function, Qframe, Qvector):
5347 * image.c (QimageMagick, Qsvg):
5348 * minibuf.c (Qmetadata):
5349 * window.c (resize_window_check, resize_root_window): Now static.
5350 * window.h (resize_window_check, resize_root_window): Remove decls.
5352 * window.c (window_deletion_count, delete_deletable_window):
5354 (window_body_lines): Now static.
5355 (Fdelete_other_windows_internal): Mark vars as initialized.
5356 Make sure 'resize_failed' is initialized.
5357 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5358 (resize_window_apply): Remove unused local.
5359 * window.h (delete_deletable_window): Remove decl.
5361 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5362 (imagemagick_load_image): Fix pointer signedness problem by changing
5363 last arg from unsigned char * to char *. All uses changed.
5364 Also, fix a local for similar reasons.
5365 Remove unused locals. Remove locals to avoid shadowing.
5366 (fn_rsvg_handle_free): Remove; unused.
5367 (svg_load, svg_load_image): Fix pointer signedness problem.
5368 (imagemagick_load_image): Don't use garbage pointer image_wand.
5370 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5372 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5374 * image.c (gif_load): Fix omitted cast error introduced by
5377 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5379 * window.h (resize_proportionally, orig_total_lines)
5380 (orig_top_line): Remove from window structure.
5381 (set_window_height, set_window_width, change_window_heights)
5382 (Fdelete_window): Remove prototypes.
5383 (resize_frame_windows): Remove duplicate declaration.
5385 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5387 * window.h (resize_frame_windows, resize_window_check)
5388 (delete_deletable_window, resize_root_window)
5389 (resize_frame_windows): Declare prototypes.
5391 * window.c (resize_window_apply): Make definition be "static" to
5392 match the prototype.
5394 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5396 * window.c: Remove declarations of Qwindow_size_fixed,
5397 window_min_size_1, window_min_size_2, window_min_size,
5398 size_window, window_fixed_size_p, enlarge_window, delete_window.
5399 Remove static from declaration of Qdelete_window, it's
5400 temporarily needed by Fbury_buffer.
5401 (replace_window): Don't assign orig_top_line and
5403 (Fdelete_window, delete_window): Remove. Window deletion is
5404 handled by window.el.
5405 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5406 Replace Fdelete_window calls with calls to Qdelete_window.
5407 (Fdelete_other_windows): Remove. Deleting other windows is
5408 handled by window.el.
5409 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5410 handled in window.el.
5411 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5412 Window minimum sizes are handled in window.el.
5413 (shrink_windows, size_window, set_window_height)
5414 (set_window_width, change_window_heights, window_height)
5415 (window_width, CURBEG, CURSIZE, enlarge_window)
5416 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5417 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5418 handled in window.el.
5419 (make_dummy_parent): Rename to make_parent_window and give it a
5420 second argument horflag.
5421 (make_window): Don't set resize_proportionally any more.
5422 (Fsplit_window): Remove. Windows are split in window.el.
5423 (save_restore_action, save_restore_orig_size)
5424 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5425 Resize mini windows in window.el.
5426 (grow_mini_window, shrink_mini_window): Implement by calling
5427 Qresize_root_window_vertically, resize_window_check and
5428 resize_window_apply.
5429 (saved_window, Fset_window_configuration, save_window_save):
5430 Do not handle orig_top_line, orig_total_lines, and
5431 resize_proportionally.
5432 (window_min_height, window_min_width): Move to window.el.
5433 (keys_of_window): Move bindings for delete-other-windows,
5434 split-window, delete-window and enlarge-window to window.el.
5436 * buffer.c: Temporarily extern Qdelete_window.
5437 (Fbury_buffer): Temporarily call Qdelete_window instead of
5438 Fdelete_window (Fbury_buffer will move to window.el soon).
5440 * frame.c (set_menu_bar_lines_1): Remove code handling
5441 orig_top_line and orig_total_lines.
5443 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5444 set_window_height but set heights directly.
5445 (change_frame_size_1): Use resize_frame_windows.
5447 * xdisp.c (init_xdisp): Don't use set_window_height but set
5450 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5451 Use resize_frame_windows instead of change_window_heights and run
5452 run_window_configuration_change_hook.
5454 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5455 instead of change_window_heights and run
5456 run_window_configuration_change_hook.
5458 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5460 * window.c (replace_window): Rename second argument REPLACEMENT to
5461 NEW. New third argument SETFLAG. Rewrite.
5462 (delete_window, make_dummy_parent): Call replace_window with
5464 (window_list_1): Move down in code.
5465 (run_window_configuration_change_hook): Move set_buffer part
5466 before select_frame_norecord part in order to unwind correctly.
5467 Rename count1 to count.
5468 (recombine_windows, delete_deletable_window, resize_root_window)
5469 (Fdelete_other_windows_internal)
5470 (Frun_window_configuration_change_hook, make_parent_window)
5471 (resize_window_check, resize_window_apply, Fresize_window_apply)
5472 (resize_frame_windows, Fsplit_window_internal)
5473 (Fdelete_window_internal, Fresize_mini_window_internal):
5475 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5477 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5479 * window.h (window): Add some new members to window structure -
5480 normal_lines, normal_cols, new_total, new_normal, clone_number,
5481 splits, nest, prev_buffers, next_buffers.
5482 (WINDOW_TOTAL_SIZE): Move here from window.c.
5483 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5485 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5487 (make_dummy_parent): Set new members of windows structure.
5488 (make_window): Move down in code. Handle new members of window
5490 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5491 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5492 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5493 (Fset_window_prev_buffers, Fwindow_next_buffers)
5494 (Fset_window_next_buffers, Fset_window_clone_number):
5496 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5497 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5499 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5500 Argument WINDOW can be now internal window too.
5501 (Fwindow_use_time): Move up in code.
5502 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5504 (Fset_window_configuration, saved_window)
5505 (Fcurrent_window_configuration, save_window_save): Handle new
5506 members of window structure.
5507 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5508 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5509 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5510 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5511 Qget_mru_window, Qresize_root_window,
5512 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5513 Qauto_buffer_name; staticpro them.
5515 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5517 * window.c (Fwindow_total_size, Fwindow_left_column)
5518 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5519 (Fwindow_list_1): New functions.
5520 (window_box_text_cols): Replace with window_body_cols.
5521 (Fwindow_width, Fscroll_left, Fscroll_right):
5522 Use window_body_cols instead of window_box_text_cols.
5523 (delete_window, Fset_window_configuration):
5524 Call delete_all_subwindows with window as argument.
5525 (delete_all_subwindows): Take a window as argument and not a
5527 (window_loop): Remove handling of GET_LRU_WINDOW and
5529 (Fget_lru_window, Fget_largest_window): Move to window.el.
5531 * window.h: Extern window_body_cols instead of
5532 window_box_text_cols. delete_all_subwindows now takes a
5533 Lisp_Object as argument.
5535 * indent.c (compute_motion, Fcompute_motion):
5536 Use window_body_cols instead of window_box_text_cols.
5538 * frame.c (delete_frame): Call delete_all_subwindows with root
5541 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5543 * fns.c (Fputhash): Document return value.
5545 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5547 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5549 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5551 Cons<->int and similar integer overflow fixes (Bug#8794).
5553 Check for overflow when converting integer to cons and back.
5554 * charset.c (Fdefine_charset_internal, Fdecode_char):
5555 Use cons_to_unsigned to catch overflow.
5556 (Fencode_char): Use INTEGER_TO_CONS.
5557 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5558 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5559 * data.c (long_to_cons, cons_to_long): Remove.
5560 (cons_to_unsigned, cons_to_signed): New functions.
5561 These signal an error for invalid or out-of-range values.
5562 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5563 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5564 * font.c (Ffont_variation_glyphs):
5565 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5566 * lisp.h: Include <intprops.h>.
5567 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5568 (cons_to_signed, cons_to_unsigned): New decls.
5569 (long_to_cons, cons_to_long): Remove decls.
5570 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5571 (Fprimitive_undo): Use CONS_TO_INTEGER.
5572 * xfns.c (Fx_window_property): Likewise.
5573 * xselect.c: Include <limits.h>.
5574 (x_own_selection, selection_data_to_lisp_data):
5575 Use INTEGER_TO_CONS.
5576 (x_handle_selection_request, x_handle_selection_clear)
5577 (x_get_foreign_selection, Fx_disown_selection_internal)
5578 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5579 (lisp_data_to_selection_data): Use cons_to_unsigned.
5580 (x_fill_property_data): Use cons_to_signed.
5581 Report values out of range.
5583 Check for buffer and string overflow more precisely.
5584 * buffer.h (BUF_BYTES_MAX): New macro.
5585 * lisp.h (STRING_BYTES_MAX): New macro.
5586 * alloc.c (Fmake_string):
5587 * character.c (string_escape_byte8):
5588 * coding.c (coding_alloc_by_realloc):
5589 * doprnt.c (doprnt):
5590 * editfns.c (Fformat):
5592 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5593 since they may not be the same number.
5594 * editfns.c (Finsert_char):
5595 * fileio.c (Finsert_file_contents):
5596 Likewise for BUF_BYTES_MAX.
5598 * image.c: Use ptrdiff_t, not int, for sizes.
5599 (slurp_file): Switch from int to ptrdiff_t.
5601 (slurp_file): Check that file size fits in both size_t (for
5602 malloc) and ptrdiff_t (for sanity and safety).
5604 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5605 if b->modtime has its maximal value.
5607 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5609 Don't assume time_t can fit into int.
5610 * buffer.h (struct buffer.modtime): Now time_t, not int.
5611 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5612 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5614 Minor fixes for signed vs unsigned integers.
5615 * character.h (MAYBE_UNIFY_CHAR):
5616 * charset.c (maybe_unify_char):
5617 * keyboard.c (read_char, reorder_modifiers):
5618 XINT -> XFASTINT, since the integer must be nonnegative.
5619 * ftfont.c (ftfont_spec_pattern):
5620 * keymap.c (access_keymap, silly_event_symbol_error):
5621 XUINT -> XFASTINT, since the integer must be nonnegative.
5622 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5623 since it makes no difference and we prefer signed.
5624 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5625 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5628 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5630 * window.h (Fwindow_frame): Declare.
5632 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5634 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5635 (SPARE_MEMORY): Always define.
5636 (LARGE_REQUEST): Remove.
5637 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5639 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5641 * lisp.h: Move EXFUNS for Fframe_root_window,
5642 Fframe_first_window and Fset_frame_selected_window to window.h.
5644 * window.h: Move EXFUNS for Fframe_root_window,
5645 Fframe_first_window and Fset_frame_selected_window here from
5648 * frame.c (Fwindow_frame, Fframe_first_window)
5649 (Fframe_root_window, Fframe_selected_window)
5650 (Fset_frame_selected_window): Move to window.c.
5651 (Factive_minibuffer_window): Move to minibuf.c.
5652 (Fother_visible_frames_p): New function.
5654 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5656 * window.c (decode_window, decode_any_window): Move up in code.
5657 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5658 (inhibit_frame_unsplittable): Remove unused variable.
5659 (Fwindow_buffer): Move up and rewrite doc-string.
5660 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5661 (Fwindow_prev): New functions.
5662 (Fwindow_frame): Move here from frame.c. Accept any window as
5664 (Fframe_root_window, Fframe_first_window)
5665 (Fframe_selected_window): Move here from frame.c. Accept frame
5666 or arbitrary window as argument. Update doc-strings.
5667 (Fminibuffer_window): Move up in code.
5668 (Fwindow_minibuffer_p): Move up in code and simplify.
5669 (Fset_frame_selected_window): Move here from frame.c.
5671 (Fselected_window, select_window, Fselect_window): Move up in
5672 code. Minor doc-string fixes.
5674 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5676 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5677 Do not assume that spare memory exists; that assumption is valid
5678 only if SYSTEM_MALLOC.
5679 (LARGE_REQUEST): New macro, so that the issue of large requests
5680 is separated from the issue of spare memory.
5682 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5684 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5687 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5689 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5692 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5694 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5696 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5698 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5699 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5701 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5703 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5705 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5707 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5708 (x_clipboard_manager_save): Add return value.
5709 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5711 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5712 Obey Vx_select_enable_clipboard_manager. Catch errors in
5713 x_clipboard_manager_save (Bug#8779).
5714 (Vx_select_enable_clipboard_manager): New variable.
5715 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5717 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5719 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5721 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5723 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5724 in the current matrix if keep_current_p is non-zero.
5726 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5728 * bidi.c (bidi_level_of_next_char): Fix last change.
5730 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5732 Support bidi reordering of text covered by display properties.
5734 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5735 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5736 (bidi_cache_search, bidi_cache_iterator_state)
5737 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5738 (bidi_level_of_next_char, bidi_move_to_visually_next):
5739 Support character positions inside a run of characters covered by a
5741 (bidi_paragraph_init, bidi_resolve_explicit_1)
5742 (bidi_level_of_next_char): Call bidi_fetch_char and
5743 bidi_fetch_char_advance instead of FETCH_CHAR and
5745 (bidi_init_it): Initialize new members.
5746 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5748 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5749 instead of using explicit *_CHAR codes.
5750 (bidi_resolve_explicit, bidi_resolve_weak):
5751 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5752 bidirectional text is supported only in multibyte buffers.
5753 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5754 it to initialize the frame_window_p member of struct bidi_it.
5755 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5756 (bidi_resolve_explicit, bidi_resolve_weak)
5757 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5758 bidi_it->nchars is non-positive.
5759 (bidi_level_of_next_char): Don't try to lookup the cache for the
5760 next/previous character if nothing is cached there yet, or if we
5761 were just reseat()'ed to a new position.
5763 * xdisp.c (set_cursor_from_row): Set start and stop points
5764 according to the row's direction when priming the loop that looks
5765 for the glyph on which to display cursor.
5766 (single_display_spec_intangible_p): Function deleted.
5767 (display_prop_intangible_p): Reimplement to call
5768 handle_display_spec instead of single_display_spec_intangible_p.
5769 Accept 3 additional arguments needed by handle_display_spec.
5770 This fixes incorrect cursor motion across display property with complex
5771 values: lists, `(when COND...)' forms, etc.
5772 (single_display_spec_string_p): Support property values that are
5773 lists with the argument STRING its top-level element.
5774 (display_prop_string_p): Fix the condition for processing a
5775 property that is a list to be consistent with handle_display_spec.
5776 (handle_display_spec): New function, refactored from the
5777 last portion of handle_display_prop.
5778 (compute_display_string_pos): Accept additional argument
5779 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5780 value of a `display' property is a "replacing spec".
5781 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5782 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5783 the display property, but just return a value indicating whether
5784 the display property will replace the characters it covers.
5785 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5786 frame_window_p members of struct bidi_it.
5787 (compute_display_string_pos, compute_display_string_end):
5789 (push_it): Accept second argument POSITION, where pop_it should
5790 jump to continue iteration.
5791 (reseat_1): Initialize bidi_it.disp_pos.
5793 * keyboard.c (adjust_point_for_property): Adjust the call to
5794 display_prop_intangible_p to its new signature.
5796 * dispextern.h (struct bidi_it): New member frame_window_p.
5797 (bidi_init_it): Update prototypes.
5798 (display_prop_intangible_p): Update prototype.
5799 (compute_display_string_pos, compute_display_string_end):
5801 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5804 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5806 Malloc failure behavior now depends on size of allocation.
5807 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5808 * lisp.h: Change signatures accordingly.
5809 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5810 All callers changed. (Bug#8762)
5812 * gnutls.c: Use Emacs's memory allocators.
5813 Without this change, the gnutls library would invoke malloc etc.
5814 directly, which causes problems on non-SYNC_INPUT hosts, and which
5815 runs afoul of improving memory_full behavior. (Bug#8761)
5816 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5817 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5818 xfree instead of the default malloc, realloc, free.
5819 (Fgnutls_boot): No need to check for memory allocation failure,
5820 since xmalloc does that for us.
5822 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5823 * category.c (hash_get_category_set):
5824 * ccl.c (ccl_driver):
5825 * charset.c (Fdefine_charset_internal):
5826 * charset.h (struct charset.hash_index):
5827 * composite.c (get_composition_id, gstring_lookup_cache)
5828 (composition_gstring_put_cache):
5829 * composite.h (struct composition.hash_index):
5830 * dispextern.h (struct image.hash):
5831 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5832 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5833 (hashfn_equal, hashfn_user_defined, make_hash_table)
5834 (maybe_resize_hash_table, hash_lookup, hash_put)
5835 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5836 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5837 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5838 * image.c (make_image, search_image_cache, lookup_image)
5839 (xpm_put_color_table_h):
5840 * lisp.h (struct Lisp_Hash_Table):
5841 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5842 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5843 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5844 * alloc.c (allocate_vectorlike):
5845 Check for overflow in vector size calculations.
5846 * ccl.c (ccl_driver):
5847 Check for overflow when converting EMACS_INT to int.
5848 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5849 need to be updated by these changes.
5850 * fns.c (make_hash_table, maybe_resize_hash_table):
5851 Check for integer overflow with large hash tables.
5852 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5853 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5854 (SXHASH_REDUCE): New macro.
5855 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5856 Use it instead of discarding useful hash info with large hash values.
5857 (sxhash_float): New function.
5858 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5859 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5860 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5861 Rewrite to use FIXNUM_BITS, as this simplifies things.
5862 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5863 Adjust signatures to match updated version of code.
5864 (consing_since_gc): Now EMACS_INT, since a single hash table can
5865 use more than INT_MAX bytes.
5867 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5869 Make it possible to build with GCC-4.6+ -O2 -flto.
5871 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5873 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5875 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5876 Call minibuffer-inactive-mode.
5878 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5880 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5881 Update dependencies.
5883 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5885 * data.c (init_data): Remove code for UTS, this system is not
5888 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5890 Don't force ./temacs to start in terminal mode.
5892 * frame.c (make_initial_frame): Initialize faces in all cases, not
5893 only when CANNOT_DUMP is defined.
5894 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5896 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5898 * dispnew.c (add_window_display_history): Use const for the string
5899 pointer. Remove declaration, not needed.
5901 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5903 Use 'inline', not 'INLINE'.
5904 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5905 * alloc.c, fontset.c (INLINE): Remove.
5906 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5907 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5908 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5909 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5910 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5914 Make it possible to run ./temacs.
5916 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5917 syms_of_callproc does the same thing. Remove test for
5918 "initialized", do it in the caller.
5919 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5921 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5923 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5924 (read_minibuf): Use get_minibuffer.
5925 (syms_of_minibuf): Use DEFSYM.
5926 (Qmetadata): New var.
5927 * data.c (Qbuffer): Don't make it static.
5928 (syms_of_data): Use DEFSYM.
5930 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5932 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5933 (CCL_CODE_MIN): New macro.
5935 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5937 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5939 * eval.c (Qdebug): Now static.
5940 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5941 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5942 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5944 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5946 * image.c: Various fixes to ImageMagick code comments.
5947 (Fimagemagick_types): Doc fix.
5949 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5951 Minor fixes prompted by GCC 4.6.0 warnings.
5953 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5955 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5956 (x_clipboard_manager_save_all): Move extern decl to ...
5957 * xterm.h: ... here, so that it can be checked for consistency.
5959 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5961 * xselect.c (x_clipboard_manager_save_frame)
5962 (x_clipboard_manager_save_all): New functions.
5963 (Fx_clipboard_manager_save): Lisp function deleted.
5965 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5966 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5968 * xterm.h: Update prototype.
5970 2011-05-28 William Xu <william.xwl@gmail.com>
5972 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5975 2011-05-28 Jim Meyering <meyering@redhat.com>
5977 Avoid a sign-extension bug in crypto_hash_function.
5978 * fns.c (to_uchar): Define.
5979 (crypto_hash_function): Use it to convert some newly-signed
5980 variables to unsigned, to avoid sign-extension bugs. For example,
5981 without this change, (md5 "truc") would evaluate to
5982 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5983 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5984 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5986 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5988 Integer overflow fixes.
5990 * dbusbind.c: Serial number integer overflow fixes.
5991 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5992 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5993 to hold a serial number that is too large for a fixnum.
5994 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5995 Check for serial numbers out of range. Decode any serial number
5996 that was so large that it became a float. (Bug#8722)
5998 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5999 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6000 Use XFASTINT rather than XUINT when numbers are nonnegative.
6001 (xd_append_arg, Fdbus_method_return_internal):
6002 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6003 arguments, check that Lisp number is nonnegative, rather than
6004 silently wrapping negative numbers around. (Bug#8722)
6005 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6008 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6010 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6012 ccl: Add integer overflow checks.
6013 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6014 (IN_INT_RANGE): New macros.
6015 (ccl_driver): Use them to check for integer overflow when
6016 decoding a CCL program. Many of the new checks are whether XINT (x)
6017 fits in int; it doesn't always, on 64-bit hosts. The new version
6018 doesn't catch all possible integer overflows, but it's an
6019 improvement. (Bug#8719)
6021 * alloc.c (make_event_array): Use XINT, not XUINT.
6022 There's no need for unsigned here.
6024 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6025 This follows up to the 2011-05-06 change that substituted uintptr_t
6026 for EMACS_INT. This case wasn't caught back then.
6028 Rework Fformat to avoid integer overflow issues.
6029 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6030 now (part of C89). Include <verify.h>.
6031 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6032 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6033 (Fformat): Avoid the prepass trying to compute sizes; it was only
6034 approximate and thus did not catch overflow reliably. Instead, walk
6035 through the format just once, formatting and computing sizes as we go,
6036 checking for integer overflow at every step, and allocating a larger
6037 buffer as needed. Keep track separately whether the format is
6038 multibyte. Keep only the most-recently calculated precision, rather
6039 than them all. Record whether each argument has been converted to
6040 string. Use EMACS_INT, not int, for byte and char and arg counts.
6041 Support field widths and precisions larger than INT_MAX. Avoid
6042 sprintf's undefined behavior with conversion specifications such as %#d
6043 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6044 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6045 formatting out-of-range floating point numbers with int
6048 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6050 * data.c: Avoid integer truncation in expressions involving floats.
6051 * data.c: Include <intprops.h>.
6052 (arith_driver): When there's an integer overflow in an expression
6053 involving floating point, convert the integers to floating point
6054 so that the resulting value does not suffer from catastrophic
6055 integer truncation. For example, on a 64-bit host (* 4
6056 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6057 Do not rely on undefined behavior after integer overflow.
6059 merge count_size_as_multibyte, parse_str_to_multibyte
6060 * character.c, character.h (count_size_as_multibyte):
6061 Rename from parse_str_to_multibyte; all uses changed.
6062 Check for integer overflow.
6063 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6064 since it's now a duplicate of the other. This is more of
6065 a character than a buffer op, so better that it's in character.c.
6066 * fns.c, print.c: Adjust to above changes.
6068 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6070 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6072 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6074 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6075 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6076 (x_clipboard_manager_save): Now static.
6077 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6079 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6080 (crypto_hash_function): Now static.
6081 Fix pointer signedness problems. Avoid unnecessary initializations.
6083 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6085 * termhooks.h (Vselection_alist): Make it terminal-local.
6087 * terminal.c (create_terminal): Initialize it.
6089 * xselect.c: Support for clipboard managers.
6090 (Vselection_alist): Move to termhooks.h as terminal-local var.
6091 (LOCAL_SELECTION): New macro.
6092 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6093 (symbol_to_x_atom): Remove gratuitous arg.
6094 (x_handle_selection_request, lisp_data_to_selection_data)
6095 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6096 (x_own_selection, x_get_local_selection, x_convert_selection):
6097 New arg, specifying work frame. Use terminal-local Vselection_alist.
6098 (some_frame_on_display): Delete unused function.
6099 (Fx_own_selection_internal, Fx_get_selection_internal)
6100 (Fx_disown_selection_internal, Fx_selection_owner_p)
6101 (Fx_selection_exists_p): New optional frame arg.
6102 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6103 (x_handle_selection_clear): Don't treat other terminals with the
6104 same keyboard specially. Use the terminal-local Vselection_alist.
6105 (x_clear_frame_selections): Use Frun_hook_with_args.
6107 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6109 * xterm.h: Add support for those atoms.
6111 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6113 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6114 (converted_selections, conversion_fail_tag): New global variables.
6115 (x_selection_request_lisp_error): Free the above.
6116 (x_get_local_selection): Remove unnecessary code.
6117 (x_reply_selection_request): Args changed; handle arbitrary array
6118 of converted selections stored in converted_selections.
6119 Separate the XChangeProperty and SelectionNotify steps.
6120 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6121 (x_convert_selection): New function.
6122 (x_handle_selection_event): Simplify.
6123 (x_get_foreign_selection): Don't ignore incoming requests while
6124 waiting for an answer; this will fail when we implement
6125 SAVE_TARGETS, and seems unnecessary anyway.
6126 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6127 (Vx_sent_selection_functions): Doc fix.
6129 2011-05-26 Leo Liu <sdl.web@gmail.com>
6131 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6133 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6135 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6137 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6138 for fringe update if it has periodic bitmap.
6139 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6140 and fringe_bitmap_periodic_p.
6142 * fringe.c (get_fringe_bitmap_data): New function.
6143 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6144 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6145 row. Mark glyph row for fringe update if periodicity changed.
6147 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6148 for fringe update unless it has periodic bitmap.
6150 2011-05-25 Kenichi Handa <handa@m17n.org>
6152 * xdisp.c (get_next_display_element): Set correct it->face_id for
6153 a static composition.
6155 2011-05-24 Leo Liu <sdl.web@gmail.com>
6158 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6160 * fns.c (crypto_hash_function, Fsha1): New function.
6161 (Fmd5): Use crypto_hash_function.
6162 (syms_of_fns): Add Ssha1.
6164 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6166 * gnutls.c: Remove unused macros.
6167 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6168 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6169 Remove macros that are defined and never used.
6170 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6172 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6174 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6175 (Fx_get_selection_internal): Minor cleanup.
6176 (Fx_own_selection_internal): Rename arguments for consistency with
6179 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6181 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6183 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6185 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6187 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6189 * dispnew.c (scrolling_window): Don't exclude the case that the
6190 last enabled row in the desired matrix touches the bottom boundary.
6192 2011-05-21 Glenn Morris <rgm@gnu.org>
6194 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6195 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6196 and add some more files.
6198 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6200 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6201 report_file_error introduced by the change from 2011-05-07.
6203 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6205 * systime.h (Time): Define only if emacs is defined.
6206 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6207 where the include path doesn't have X11/X.h by default. See
6208 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6210 2011-05-20 Kenichi Handa <handa@m17n.org>
6212 * composite.c (find_automatic_composition): Fix previous change.
6214 2011-05-20 Glenn Morris <rgm@gnu.org>
6216 * lisp.mk: New file, split from Makefile.in.
6217 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6218 (shortlisp): Remove.
6219 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6221 2011-05-19 Glenn Morris <rgm@gnu.org>
6223 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6224 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6225 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6226 (lisp): Set the order to that of loadup.el.
6227 (shortlisp): Make it a copy of $lisp.
6228 (SOME_MACHINE_LISP): Remove.
6229 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6230 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6232 2011-05-18 Kenichi Handa <handa@m17n.org>
6234 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6235 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6236 (find_automatic_composition): Mostly rewrite for efficiency.
6238 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6240 * makefile.w32-in: Update dependencies.
6242 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6244 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6245 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6247 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6249 Fix some integer overflow issues, such as string length overflow.
6251 * insdel.c (count_size_as_multibyte): Check for string overflow.
6253 * character.c (lisp_string_width): Check for string overflow.
6254 Use EMACS_INT, not int, for string indexes and lengths; in
6255 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6256 the resulting string length overflows an EMACS_INT; instead,
6257 report a string overflow if no precision given. When checking for
6258 precision exhaustion, use a check that cannot possibly have
6259 integer overflow. (Bug#8675)
6260 * character.h (lisp_string_width): Adjust to new signature.
6262 * alloc.c (string_overflow): New function.
6263 (Fmake_string): Use it. This doesn't change behavior, but saves
6264 a few bytes and will simplify future changes.
6265 * character.c (string_escape_byte8): Likewise.
6266 * lisp.h (string_overflow): New decl.
6268 Fixups, following up to the user-interface timestamp change.
6269 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6270 for UI timestamps, instead of unsigned long.
6271 * msdos.c (mouse_get_pos): Likewise.
6272 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6273 * w32gui.h (Time): Define by including "systime.h" rather than by
6274 declaring it ourselves. (Bug#8664)
6276 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6277 * image.c (clear_image_cache): Likewise.
6279 * term.c (term_mouse_position): Don't assume time_t wraparound.
6281 Be more systematic about user-interface timestamps.
6282 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6283 and sometimes 'EMACS_UINT', to represent these timestamps.
6284 This change causes it to use 'Time' uniformly, as that's what X uses.
6285 This makes the code easier to follow, and makes it easier to catch
6286 integer overflow bugs such as Bug#8664.
6287 * frame.c (Fmouse_position, Fmouse_pixel_position):
6288 Use Time, not unsigned long, for user-interface timestamps.
6289 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6290 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6291 * keyboard.h (last_event_timestamp): Likewise.
6292 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6293 * menu.h (xmenu_show): Likewise.
6294 * term.c (term_mouse_position): Likewise.
6295 * termhooks.h (struct input_event.timestamp): Likewise.
6296 (struct terminal.mouse_position_hook): Likewise.
6297 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6298 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6299 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6300 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6302 * menu.h, termhooks.h: Include "systime.h", for Time.
6304 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6305 Don't assume that the difference between two unsigned long values
6306 can fit into an integer. At this point, we know button_down_time
6307 <= event->timestamp, so the difference must be nonnegative, so
6308 there's no need to cast the result if double-click-time is
6309 nonnegative, as it should be; check that it's nonnegative, just in
6310 case. This bug is triggered when events are more than 2**31 ms
6311 apart (about 25 days). (Bug#8664)
6313 * xselect.c (last_event_timestamp): Remove duplicate decl.
6314 (x_own_selection): Remove needless cast to unsigned long.
6316 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6317 that always fit in int. Use a sentinel instead of a counter, to
6318 avoid a temp and to allay GCC's concerns about possible int overflow.
6319 * frame.h (struct frame): Use int for menu_bar_items_used
6320 instead of EMACS_INT, since it always fits in int.
6322 * menu.c (grow_menu_items): Check for int overflow.
6324 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6326 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6327 Before, the code was not consistent. These values cannot exceed
6328 2**31 - 1 so there's no need to make them unsigned.
6329 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6330 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6331 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6333 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6335 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6336 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6337 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6338 presumably because the widths might not match.
6340 * window.c (size_window): Avoid needless test at loop start.
6342 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6344 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6346 2011-05-12 Drew Adams <drew.adams@oracle.com>
6348 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6350 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6352 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6353 `width' to `bar_area_x' and `bar_area_width', respectively.
6354 (x_scroll_run): Take account of fringe background extension.
6356 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6357 Rename local vars `left' and `width' to `bar_area_x' and
6358 `bar_area_width', respectively.
6359 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6360 background extension.
6362 2011-05-10 Jim Meyering <meyering@redhat.com>
6364 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6366 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6368 * image.c (Finit_image_library): Return t for built-in image types,
6369 like pbm and xbm. (Bug#8640)
6371 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6373 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6375 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6377 * w32console.c (Fset_screen_color): Doc fix.
6378 (Fget_screen_color): New function.
6379 (syms_of_ntterm): Defsubr it.
6381 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6382 unlink the temporary file if Fcall_process didn't create it in the
6384 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6385 child process will be redirected to a file specified with `:file'.
6386 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6387 cue to call_process_cleanup not to close that handle.
6389 2011-05-07 Ben Key <bkey76@gmail.com>
6391 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6392 one of two shell specific rules, either bootstrap-temacs-CMD or
6393 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6394 to the previous implementation of the bootstrap-temacs rule.
6395 The bootstrap-temacs-CMD rule is similar to the previous
6396 implementation of the bootstrap-temacs rule except that it
6397 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6400 These changes, along with some changes to nt/configure.bat,
6401 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6402 earlier fix to add support for --cflags and --ldflags options
6403 that include quotes so that it works whether make uses cmd or
6406 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6408 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6409 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6411 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6412 a string. Handle both cases.
6413 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6414 (Fdbus_register_method): Use Qinvalid_function.
6416 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6418 * makefile.w32-in: Update dependencies.
6419 (LISP_H): Add inttypes.h and stdin.h.
6420 (PROCESS_H): Add unistd.h.
6422 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6424 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6425 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6427 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6429 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6431 * term.c (vfatal): Remove stray call to va_end.
6432 It's not needed and the C Standard doesn't allow it here anyway.
6434 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6435 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6437 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6440 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6442 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6444 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6446 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6448 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6450 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6451 * charset.c (Fdefine_charset_internal): Don't initialize
6452 charset.code_space[15]. The value was garbage, on hosts with
6453 32-bit int (Bug#8600).
6455 * lread.c (read_integer): Be more consistent with string-to-number.
6456 Use string_to_number to do the actual conversion; this avoids
6457 rounding errors and fixes some other screwups. Without this fix,
6458 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6459 (digit_to_number): Move earlier, for benefit of read_integer.
6460 Return -1 if the digit is out of range for the base, -2 if it is
6461 not a digit in any supported base. (Bug#8602)
6463 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6465 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6466 to match comment at start of function. This also removes a
6467 GCC warning about overflow in a 32+64-bit port.
6469 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6471 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6472 Reported by Stefan Monnier in
6473 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6474 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6475 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6477 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6478 (EMACS_UINTPTR): Likewise, with uintptr_t.
6480 * lisp.h: Prefer 64-bit EMACS_INT if available.
6481 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6482 on 32-bit hosts that have 64-bit int, so that they can access
6484 However, temporarily disable this change unless the temporary
6485 symbol WIDE_EMACS_INT is defined.
6487 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6489 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6490 This removes an assumption that EMACS_INT and long are the same
6491 width as pointers. The assumption is true for Emacs porting targets
6492 now, but we want to make other targets possible.
6493 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6494 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6495 In the rest of the code, change types of integers that hold casted
6496 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6497 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6498 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6499 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6500 No need to cast type when ORing.
6501 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6502 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6503 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6504 assume EMACS_INT is the same width as char *.
6505 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6506 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6507 Remove no-longer-needed casts.
6508 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6509 (xg_tool_bar_help_callback, xg_make_tool_item):
6510 Use EMACS_INTPTR to hold an integer
6511 that will be cast to void *; this can avoid a GCC warning
6512 if EMACS_INT is not the same width as void *.
6513 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6514 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6515 (current_message_1, set_message_1):
6516 Use a local to convert to proper width without a cast.
6517 * xmenu.c (dialog_selection_callback): Likewise.
6519 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6520 Also, don't assume VALBITS / RAND_BITS is less than 5,
6521 and don't rely on undefined behavior when shifting a 1 left into
6523 * lisp.h (get_random): Change signature to match.
6525 * lread.c (hash_string): Use size_t, not int, for hash computation.
6526 Normally we prefer signed values; but hashing is special, because
6527 it's better to use unsigned division on hash table sizes so that
6528 the remainder is nonnegative. Also, size_t is the natural width
6529 for hashing into memory. The previous code used 'int', which doesn't
6530 retain enough info to hash well into very large tables.
6531 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6533 * dbusbind.c: Don't possibly lose pointer info when converting.
6534 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6535 Use XPNTR rather than XHASH, so that the high-order bits of
6536 the pointer aren't lost when converting through void *.
6538 * eval.c (Fautoload): Don't double-shift a pointer.
6540 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6542 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6544 * gnutls.c (DEF_GNUTLS_FN):
6545 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6547 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6549 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6552 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6554 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6555 New version that can reserve upto 2GB of heap space.
6557 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6559 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6561 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6563 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6564 `gnutls_certificate_set_x509_key_file'.
6566 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6568 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6569 Update dependencies.
6571 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6573 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6574 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6575 Remove unused parameter `fildes'.
6576 * process.c (read_process_output, send_process): Don't pass it.
6578 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6580 Fix previous change: the library cache is defined in w32.c.
6581 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6582 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6584 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6586 Implement dynamic loading of GnuTLS on Windows.
6588 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6589 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6590 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6593 * gnutls.c (Qgnutls_dll): Define.
6594 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6595 (gnutls_*): Declare function pointers.
6596 (init_gnutls_functions): New function to initialize function pointers.
6597 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6598 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6599 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6600 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6601 (emacs_gnutls_write, emacs_gnutls_read)
6602 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6603 (Fgnutls_available_p): New function.
6604 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6605 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6606 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6608 * image.c: Include w32.h.
6609 (Vimage_type_cache): Delete.
6610 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6611 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6612 (w32_delayed_load): Move to w32.c.
6614 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6616 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6617 (w32_delayed_load): Move from image.c. When loading a library, record
6618 its filename in the :loaded-from property of the library id.
6619 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6620 Initialize and staticpro them.
6621 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6623 * process.c: Include lisp.h before w32.h, not after.
6624 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6625 instead of gnutls_record_check_pending.
6627 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6629 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6631 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6632 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6635 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6637 * xterm.c (x_set_frame_alpha): Do not set property on anything
6638 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6640 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6642 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6644 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6646 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6647 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6648 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6649 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6650 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6651 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6652 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6653 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6654 (Qgnutls_bootprop_callbacks_verify): Make static.
6656 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6658 * callproc.c: Indentation fixup.
6660 * sysdep.c (wait_for_termination_1): Make static.
6661 (wait_for_termination, interruptible_wait_for_termination):
6662 Move after wait_for_termination_1.
6664 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6666 * sysdep.c (interruptible_wait_for_termination): New function
6667 which is like wait_for_termination, but allows keyboard
6670 * callproc.c (Fcall_process): Add (:file "file") as an option for
6672 (Fcall_process_region): Ditto.
6674 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6676 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6677 rather than `XVECTOR (FOO)->size'.
6679 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6680 inttypes.h, as a gnulib replacement is used if it not available in
6683 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6685 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6686 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6687 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6689 * coding.c (coding_alloc_by_realloc): Error out if destination
6690 will grow beyond MOST_POSITIVE_FIXNUM.
6691 (decode_coding_emacs_mule): Abort if there isn't enough place in
6692 charbuf for the composition carryover bytes. Reserve an extra
6693 space for up to 2 characters produced in a loop.
6694 (decode_coding_iso_2022): Abort if there isn't enough place in
6695 charbuf for the composition carryover bytes.
6697 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6699 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6700 aborting when %lld or %lll format is passed.
6701 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6702 %llo or %llx format is passed. (Bug#8545)
6704 * window.c (window_scroll_line_based): Use a marker instead of
6705 simple variables to record original value of point. (Bug#7952)
6707 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6708 produced by %s or %c overflows available buffer space. (Bug#8545)
6710 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6712 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6713 (SIZE_MAX): Move defn after all includes, as they might #define it.
6715 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6717 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6719 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6721 * keyboard.c (Qdelayed_warnings_hook): Define.
6722 (command_loop_1): Run `delayed-warnings-hook'
6723 if Vdelayed_warnings_list is non-nil.
6724 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6725 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6727 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6729 * doprnt.c (doprnt): Don't return value smaller than the buffer
6730 size if the message was truncated. (Bug#8545).
6732 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6734 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6735 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6737 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6739 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6741 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6743 * makefile.w32-in: Update dependencies.
6745 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6747 Improve `doprnt' and its usage. (Bug#8545)
6748 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6749 `format_end'. Remove support for %l as a conversion specifier.
6750 Don't use xrealloc. Improve diagnostics when the %l size modifier
6751 is used. Update the commentary.
6753 * eval.c (verror): Simplify calculation of size_t.
6755 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6758 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6760 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6763 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6765 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6766 This makes this file independent of the recent pseudovector change.
6768 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6770 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6772 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6773 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6774 Remove unused local.
6775 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6777 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6778 GCC 4.6.0 optimizes based on type-based alias analysis.
6779 For example, if b is of type struct buffer * and v of type struct
6780 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6781 != &v->size, and therefore "v->size = 1; b->size = 2; return
6782 v->size;" must therefore return 1. This assumption is incorrect
6783 for Emacs, since it type-puns struct Lisp_Vector * with many other
6784 types. To fix this problem, this patch adds a new type struct
6785 vectorlike_header that documents the constraints on layout of vectors
6786 and pseudovectors, and helps optimizing compilers not get fooled
6787 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6788 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6789 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6791 (XSETPVECTYPE): Rewrite in terms of new macro.
6792 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6793 This is a bit clearer, and further avoids the possibility of
6794 undesirable aliasing.
6795 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6796 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6797 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6798 since Lisp_Subr is a special case (no "next" field).
6799 (ASIZE): Now uses header.size rather than size.
6800 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6801 to avoid the hassle of writing XVECTOR (foo)->header.size.
6802 (struct vectorlike_header): New type.
6803 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6804 object, to help avoid aliasing.
6805 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6806 (SUBRP): Likewise, since Lisp_Subr is a special case.
6807 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6808 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6809 (struct Lisp_Hash_Table): Combine first two members into a single
6810 struct vectorlike_header member. All uses of "size" and "next" members
6811 changed to be "header.size" and "header.next".
6812 * buffer.h (struct buffer): Likewise.
6813 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6814 * frame.h (struct frame): Likewise.
6815 * process.h (struct Lisp_Process): Likewise.
6816 * termhooks.h (struct terminal): Likewise.
6817 * window.c (struct save_window_data, struct saved_window): Likewise.
6818 * window.h (struct window): Likewise.
6819 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6820 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6821 * buffer.c (init_buffer_once): Likewise.
6822 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6824 * process.c (Fformat_network_address): Use local var for size,
6827 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6829 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6830 * data.c (atof): Remove decl; no longer used or needed.
6831 (digit_to_number): Move to lread.c.
6832 (Fstring_to_number): Use new string_to_number function, to be
6833 consistent with how the Lisp reader treats infinities and NaNs.
6834 Do not assume that floating-point numbers represent EMACS_INT
6835 without losing information; this is not true on most 64-bit hosts.
6836 Avoid double-rounding errors, by insisting on integers when
6837 parsing non-base-10 numbers, as the documentation specifies.
6838 * lisp.h (string_to_number): New decl, replacing ...
6839 (isfloat_string): Remove.
6840 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6841 (read1): Do not accept +. and -. as integers; this
6842 appears to have been a coding error. Similarly, do not accept
6843 strings like +-1e0 as floating point numbers. Do not report
6844 overflow for integer overflows unless the base is not 10 which
6845 means we have no simple and reliable way to continue.
6846 Break out the floating-point parsing into a new
6847 function string_to_number, so that Fstring_to_number parses
6848 floating point numbers consistently with the Lisp reader.
6849 (digit_to_number): Move here from data.c. Make it static inline.
6850 (E_CHAR, EXP_INT): Remove, replacing with ...
6851 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6852 (string_to_number): New function, replacing isfloat_string.
6853 This function checks for valid syntax and produces the resulting
6854 Lisp float number too. Rework it so that string-to-number
6855 no longer mishandles examples like "1.0e+". Use strtoumax,
6856 so that overflow for non-base-10 numbers is reported only when
6857 there's no portable and simple way to convert to floating point.
6859 * textprop.c (set_text_properties_1): Rewrite for clarity,
6860 and to avoid GCC warning about integer overflow.
6862 * intervals.h (struct interval): Use EMACS_INT for members
6863 where EMACS_UINT might cause problems. See
6864 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6865 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6866 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6868 (offset_intervals): Tell GCC not to worry about length overflow
6869 when negating a negative length.
6871 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6872 (overrun_check_free): Likewise.
6874 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6875 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6878 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6879 (gnutls_make_error): Rename local to avoid shadowing.
6880 (gnutls_emacs_global_deinit): ifdef out; not used.
6881 (Fgnutls_boot): Use const for pointer to readonly storage.
6882 Comment out unused local. Fix pointer signedness problems.
6884 * lread.c (openp): Don't stuff size_t into an 'int'.
6885 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6886 about possible signed overflow.
6888 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6889 (GDK_KEY_g): Don't define if already defined.
6890 (xg_prepare_tooltip): Avoid pointer signedness problem.
6891 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6893 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6894 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6896 * xfns.c (Fx_window_property): Simplify a bit,
6897 to make a bit faster and to avoid GCC 4.6.0 warning.
6898 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6900 * fns.c (internal_equal): Don't assume size_t fits in int.
6902 * alloc.c (compact_small_strings): Tighten assertion a little.
6904 Replace pEd with more-general pI, and fix some printf arg casts.
6905 * lisp.h (pI): New macro, generalizing old pEd macro to other
6906 conversion specifiers. For example, use "...%"pI"d..." rather
6907 than "...%"pEd"...".
6908 (pEd): Remove. All uses replaced with similar uses of pI.
6909 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6910 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6911 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6912 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6913 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6914 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6915 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6917 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6918 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6919 * print.c (safe_debug_print, print_object): Likewise.
6920 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6922 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6923 avoiding the 0 flag, which is not portable.
6924 * process.c (Fmake_network_process): Use pI to avoid cast.
6925 * region-cache.c (pp_cache): Likewise.
6926 * xdisp.c (decode_mode_spec): Likewise.
6927 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6928 behavior on 64-bit hosts with printf arg.
6929 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6930 (x_stop_queuing_selection_requests): Likewise.
6931 (x_get_window_property): Don't truncate byte count to an 'int'
6934 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6935 here, since it parses constructs like leading '-' and spaces,
6936 which are not wanted; and it overflows with large numbers.
6937 Instead, simply match F[0-9]+, which is what is wanted anyway.
6939 * alloc.c: Remove unportable assumptions about struct layout.
6940 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6941 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6942 (allocate_vectorlike, make_pure_vector): Use the new macros,
6943 plus offsetof, to remove unportable assumptions about struct layout.
6944 These assumptions hold on all porting targets that I know of, but
6945 they are not guaranteed, they're easy to remove, and removing them
6946 makes further changes easier.
6948 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6949 This doesn't fix a bug but makes the code clearer.
6950 (string_overrun_cookie): Now const. Use initializers that
6951 don't formally overflow signed char, to avoid warnings.
6952 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6953 can cause Emacs to crash when string overrun checking is enabled.
6954 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6955 multiple of sizeof (EMACS_INT); it need not be, if
6956 alignof(EMACS_INT) < sizeof (EMACS_INT).
6957 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6959 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6961 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6963 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6965 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6966 supposed to be handshaking. (Bug#8556)
6967 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6969 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6971 * lisp.h (Qdebug): List symbol.
6972 * eval.c (Qdebug): Restore global linkage.
6973 * keyboard.c (debug-on-event): New variable.
6974 (handle_user_signal): Break into debugger when debug-on-event
6975 matches the current signal symbol.
6977 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6979 * alloc.c (check_sblock, check_string_bytes)
6980 (check_string_free_list): Convert to standard C.
6982 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6984 * w32.c (emacs_gnutls_push): Fix typo.
6986 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6988 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6989 "cast to pointer from integer of different size".
6991 Improve doprnt and its use in verror. (Bug#8545)
6992 * doprnt.c (doprnt): Document the set of format control sequences
6993 supported by the function. Use SAFE_ALLOCA instead of always
6996 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6997 is one byte too soon. Don't use xrealloc; instead xfree and
7000 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7002 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7005 * gnutls.c: Renamed global_initialized to
7006 gnutls_global_initialized. Added internals for the
7007 :verify-hostname-error, :verify-error, and :verify-flags
7008 parameters of `gnutls-boot' and documented those parameters in the
7009 docstring. Start callback support.
7010 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7011 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7012 on error. Return error code.
7013 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7014 (emacs_gnutls_read): Likewise.
7015 (Fgnutls_boot): Return handshake error code.
7016 (emacs_gnutls_handle_error): New function.
7017 (wsaerror_to_errno): Likewise.
7019 * w32.h (emacs_gnutls_pull): Add prototype.
7020 (emacs_gnutls_push): Likewise.
7022 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7023 (emacs_gnutls_push): Likewise.
7025 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7027 * process.c (wait_reading_process_output): Check if GnuTLS
7028 buffered some data internally if no FDs are set for TLS
7031 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7032 (LIBS): Link to USER_LIBS.
7033 ($(BLD)/gnutls.$(0)): New target.
7035 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7037 * xdisp.c (handle_single_display_spec): Rename the
7038 display_replaced_before_p argument into display_replaced_p, to
7039 make it consistent with the commentary. Fix typos in the
7042 * textprop.c (syms_of_textprop): Remove dead code.
7043 (copy_text_properties): Delete obsolete commentary about an
7044 interface that was deleted long ago. Fix typos in the description
7047 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7048 to changes in oldXMenu/XMenu.h from 2011-04-16.
7049 <menu_help_message, prev_menu_help_message>: Constify.
7050 (IT_menu_make_room): menu->help_text is now `const char **';
7053 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7054 to changes in oldXMenu/XMenu.h from 2011-04-16.
7055 (struct XMenu): Declare `help_text' `const char **'.
7057 * xfaces.c <Qunspecified>: Make extern again.
7059 * syntax.c: Include sys/types.h before including regex.h, as
7062 * doc.c (get_doc_string): Improve the format passed to `error'.
7064 * doprnt.c (doprnt): Improve commentary.
7066 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7068 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7071 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7072 changes in globals.h immediately force recompilation.
7073 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7074 $(CURDIR)/s/ms-w32.h.
7075 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7077 * character.c (Fchar_direction): Function deleted.
7078 (syms_of_character): Don't defsubr it.
7079 <char-direction-table>: Deleted.
7081 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7083 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7084 * doprnt.c: Include limits.h.
7085 (SIZE_MAX): New macro.
7086 (doprnt): Return a size_t value. 2nd arg is now size_t.
7087 Many local variables are now size_t instead of int or unsigned.
7088 Improve overflow protection. Support `l' modifier for integer
7089 conversions. Support %l conversion. Don't assume an EMACS_INT
7090 argument for integer conversions and for %c.
7092 * lisp.h (doprnt): Restore prototype.
7094 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7097 * Makefile.in (base_obj): Add back doprnt.o.
7099 * deps.mk (doprnt.o): Add back prerequisites.
7100 (callint.o): Depend on character.h.
7102 * eval.c (internal_lisp_condition_case): Include the handler
7103 representation in the error message.
7104 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7105 when breaking from the loop.
7107 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7109 * callint.c (Fcall_interactively): When displaying error message
7110 about invalid control letter, pass the character's codepoint, not
7111 a pointer to its multibyte form. Improve display of the character
7112 in octal and display also its hex code.
7114 * character.c (char_string): Use %x to display the (unsigned)
7115 codepoint of an invalid character, to avoid displaying a bogus
7118 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7119 `error', not SYMBOL_NAME itself.
7121 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7122 character arguments to `error'.
7124 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7125 to `error' in error message about FINAL_CHAR argument. Make sure
7126 FINAL_CHAR is a character, and use %c when it is passed as
7127 argument to `error'.
7129 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7131 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7133 * w32.c: Include <time.h>.
7134 (sys_localtime): New function.
7136 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7138 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7140 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7142 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7144 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7147 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7149 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7150 gl_state.e_property when gl_state.object is Qt.
7152 * insdel.c (make_gap_larger): Remove limitation of buffer size
7155 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7157 * xdisp.c (lookup_glyphless_char_display)
7158 (produce_glyphless_glyph): Handle cons cell entry in
7159 glyphless-char-display.
7160 (Vglyphless_char_display): Document it.
7162 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7163 glyphless-char-display.
7165 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7167 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7169 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7171 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7172 definition for no-X builds.
7174 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7176 Static checks with GCC 4.6.0 and non-default toolkits.
7178 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7180 * process.c (keyboard_bit_set): Define only if SIGIO.
7181 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7182 (send_process): Repair possible setjmp clobbering.
7184 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7186 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7188 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7190 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7191 Define only if needed.
7193 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7194 by pacifying GCC about it. Maybe it's time to retire it?
7195 * xfaces.c (USG, __TIMEVAL__): Likewise.
7197 * dispextern.h (struct redisplay_interface): Rename param
7199 * termhooks.h (struct terminal): Likewise.
7200 * xterm.c (xembed_send_message): Likewise.
7202 * insdel.c (make_gap_smaller): Define only if
7203 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7205 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7208 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7209 so that we aren't warned about unused symbols.
7211 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7213 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7215 * xfns.c (x_real_positions): Mark locals as initialized.
7217 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7219 * xterm.c: Fix problems found by static analysis with other toolkits.
7220 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7221 (x_dispatch_event): Declare static if USE_GTK, and
7222 define if USE_GTK || USE_X_TOOLKIT.
7223 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7224 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7225 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7226 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7228 * xmenu.c (menu_help_callback): Pointer type fixes.
7229 Use const pointers when pointing at readonly data. Avoid pointer
7231 (FALSE): Remove unused macro.
7232 (update_frame_menubar): Remove unused decl.
7234 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7236 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7237 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7238 (single_menu_item): Rename local to avoid shadowing.
7240 * keyboard.c (make_lispy_event): Remove unused local var.
7242 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7243 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7245 * bitmaps: Change bitmaps from unsigned char back to the X11
7246 compatible char. Avoid the old compiler warnings about
7247 out-of-range initializers by using, for example, '\xab' rather
7250 * xgselect.c (xgselect_initialize): Check vs interface
7251 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7253 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7255 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7256 to read-only memory.
7258 * fns.c (vector): Remove; this old hack is no longer needed.
7260 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7262 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7264 * xrdb.c (x_load_resources): Omit unused local.
7266 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7267 (x_window): Rename locals to avoid shadowing.
7268 (USG): Use the kludged USG macro, to pacify gcc.
7270 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7271 (x_term_init): Remove local to avoid shadowing.
7273 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7275 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7276 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7278 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7280 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7282 Fix regex.c, syntax.c and friends for buffers > 2GB.
7283 * syntax.h (struct gl_state_s): Declare character position members
7286 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7288 * textprop.c (verify_interval_modification, interval_of):
7289 Declare arguments EMACS_INT.
7291 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7294 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7296 * indent.c (Fvertical_motion): Local variable it_start is now
7299 * regex.c (re_match, re_match_2, re_match_2_internal)
7300 (bcmp_translate, regcomp, regexec, print_double_string)
7301 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7302 (re_compile_pattern, re_exec): Declare arguments and local
7303 variables `size_t' and `ssize_t' and return values `regoff_t', as
7305 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7306 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7307 <compile_stack_type>: `size' and `avail' are now `size_t'.
7309 * regex.h <regoff_t>: Use ssize_t, not int.
7310 (re_search, re_search_2, re_match, re_match_2): Arguments that
7311 specify buffer/string position and length are now ssize_t and
7312 size_t. Return type is regoff_t.
7314 2011-04-16 Ben Key <bkey76@gmail.com>
7316 * nsfont.m: Fixed bugs in ns_get_family and
7317 ns_descriptor_to_entity that were caused by using free to
7318 deallocate memory blocks that were allocated by xmalloc (via
7319 xstrdup). This caused Emacs to crash when compiled with
7320 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7321 --enable-checking=xmallocoverrun). xfree is now used to
7322 deallocate these memory blocks.
7324 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7326 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7328 emacs_write: Accept and return EMACS_INT for sizes.
7329 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7331 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7332 Accept and return EMACS_INT.
7333 (emacs_gnutls_write): Return the number of bytes written on
7335 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7336 (emacs_read, emacs_write): Remove check for negative size, as the
7337 Emacs source code has been audited now.
7338 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7339 (emacs_read, emacs_write): Use it.
7340 * process.c (send_process): Adjust to the new signatures of
7341 emacs_write and emacs_gnutls_write. Do not attempt to store
7342 a byte offset into an 'int'; it might overflow.
7343 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7345 * sound.c: Don't assume sizes fit in 'int'.
7346 (struct sound_device.period_size, alsa_period_size):
7347 Return EMACS_INT, not int.
7348 (struct sound_device.write, vox_write, alsa_write):
7349 Accept EMACS_INT, not int.
7350 (wav_play, au_play): Use EMACS_INT to store sizes and to
7351 record read return values.
7353 2011-04-15 Ben Key <bkey76@gmail.com>
7355 * keyboard.c (Qundefined): Don't declare static since it is used
7357 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7358 static since they are used in nsfont.m.
7360 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7362 * process.c (Qprocessp): Don't declare static.
7363 * lisp.h (Qprocessp): Declare again.
7365 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7367 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7369 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7371 Improve C-level modularity by making more things 'static'.
7373 Don't publish debugger-only interfaces to other modules.
7374 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7375 (verify_bytepos, count_markers): Move decls to the only modules
7377 * region-cache.h (pp_cache): Likewise.
7378 * window.h (check_all_windows): Likewise.
7379 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7381 * sysdep.c (croak): Now static, if
7382 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7383 * syssignal.h (croak): Declare only if not static.
7385 * alloc.c (refill_memory_reserve): Now static if
7386 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7387 * lisp.h (refill_memory_reserve): Declare only if not static.
7389 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7390 Define only if USE_LUCID.
7392 * xrdb.c (x_customization_string, x_rm_string): Now static.
7394 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7395 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7397 * xdisp.c (draw_row_with_mouse_face): Now static.
7398 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7400 * window.h (check_all_windows): Mark externally visible.
7402 * window.c (window_deletion_count): Now static.
7404 * undo.c: Make symbols static if they're not exported.
7405 (last_undo_buffer, last_boundary_position, pending_boundary):
7408 * textprop.c (interval_insert_behind_hooks): Now static.
7409 (interval_insert_in_front_hooks): Likewise.
7411 * term.c: Make symbols static if they're not exported.
7412 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7413 (max_frame_lines, tty_set_terminal_modes):
7414 (tty_reset_terminal_modes, tty_turn_off_highlight):
7415 (get_tty_terminal): Now static.
7416 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7417 * termhooks.h (term_mouse_moveto): Do not declare if
7419 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7420 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7422 * sysdep.c: Make symbols static if they're not exported.
7423 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7425 (sigprocmask_set, full_mask): Remove; unused.
7426 (wait_debugging): Mark as visible.
7427 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7428 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7430 * syntax.c (syntax_temp): Define only if !__GNUC__.
7432 * sound.c (current_sound_device, current_sound): Now static.
7434 * search.c (searchbufs, searchbuf_head): Now static.
7436 * scroll.c (scroll_cost): Remove; unused.
7437 * dispextern.h (scroll_cost): Remove decl.
7439 * region-cache.h (pp_cache): Mark as externally visible.
7441 * process.c: Make symbols static if they're not exported.
7442 (process_tick, update_tick, create_process, chan_process):
7443 (Vprocess_alist, proc_buffered_char, datagram_access):
7444 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7445 (deactivate_process): Mark defn as static, as well as decl.
7446 * lisp.h (create_process): Remove decl.
7447 * process.h (chan_process, Vprocess_alist): Remove decls.
7449 * print.c: Make symbols static if they're not exported.
7450 (print_depth, new_backquote_output, being_printed, print_buffer):
7451 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7452 (print_interval, print_number_index, initial_stderr_stream):
7454 * lisp.h (Fprinc): Remove decl.
7455 (debug_output_compilation_hack): Mark as externally visible.
7457 * sysdep.c (croak): Move decl from here to syssignal.h.
7458 * syssignal.h (croak): Put it here, so the API can be checked when
7459 'croak' is called from dissociate_if_controlling_tty.
7461 * minibuf.c: Make symbols static if they're not exported.
7462 (minibuf_save_list, choose_minibuf_frame): Now static.
7463 * lisp.h (choose_minibuf_frame): Remove decl.
7465 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7467 * lread.c: Make symbols static if they're not exported.
7468 (read_objects, initial_obarray, oblookup_last_bucket_number):
7470 (make_symbol): Remove; unused.
7471 * lisp.h (initial_obarray, make_symbol): Remove decls.
7473 * keyboard.c: Make symbols static if they're not exported.
7474 (single_kboard, recent_keys_index, total_keys, recent_keys):
7475 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7476 (this_single_command_key_start, echoing, last_auto_save):
7477 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7478 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7479 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7480 (Vlispy_mouse_stem, double_click_count):
7482 (force_auto_save_soon): Define only if SIGDANGER.
7483 (ignore_mouse_drag_p): Now static if
7484 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7485 (print_help): Remove; unused.
7486 (stop_character, last_timer_event): Mark as externally visible.
7487 * keyboard.h (ignore_mouse_drag_p): Declare only if
7488 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7489 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7490 * lisp.h (echoing): Remove decl.
7491 (force_auto_save_soon): Declare only if SIGDANGER.
7492 * xdisp.c (redisplay_window): Simplify code, to make it more
7493 obvious that ignore_mouse_drag_p is not accessed if !defined
7494 USE_GTK && !defined HAVE_NS.
7496 * intervals.c: Make symbols static if they're not exported.
7497 (merge_properties_sticky, merge_interval_right, delete_interval):
7499 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7501 * insdel.c: Make symbols static if they're not exported.
7502 However, leave prepare_to_modify_buffer alone. It's never
7503 called from outside this function, but that appears to be a bug.
7504 (combine_after_change_list, combine_after_change_buffer):
7505 (adjust_after_replace, signal_before_change): Now static.
7506 (adjust_after_replace_noundo): Remove; unused.
7507 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7508 (signal_before_change): Remove decls.
7510 * indent.c (val_compute_motion, val_vmotion): Now static.
7512 * image.c: Make symbols static if they're not exported.
7513 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7515 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7516 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7518 * fringe.c (standard_bitmaps): Now static.
7519 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7521 * frame.c: Make symbols static if they're not exported.
7522 (x_report_frame_params, make_terminal_frame): Now static.
7523 (get_frame_param): Now static, unless HAVE_NS.
7524 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7525 (x_get_resource_string): Remove; not used.
7526 * frame.h (make_terminal_frame, x_report_frame_params):
7527 (x_get_resource_string); Remove decls.
7528 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7529 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7531 * font.c, fontset.c: Make symbols static if they're not exported.
7532 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7533 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7534 * font.c (font_close_object): Now static.
7535 * font.h (font_close_object): Remove.
7536 * fontset.c (FONTSET_OBJLIST): Remove.
7537 (free_realized_fontset) #if-0 the body, which does nothing.
7538 (face_suitable_for_char_p): #if-0, as it's never called.
7539 * fontset.h (face_suitable_for_char_p): Remove decl.
7540 * xfaces.c (face_at_string_position):
7541 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7542 since 0 is always ASCII.
7544 * fns.c (weak_hash_tables): Now static.
7546 * fileio.c: Make symbols static if they're not exported.
7547 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7548 (Vwrite_region_annotation_buffers): Now static.
7550 * eval.c: Make symbols static if they're not exported.
7551 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7552 * lisp.h (backtrace_list): Remove decl.
7554 * emacs.c: Make symbols static if they're not exported.
7555 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7556 (fatal_error_code, fatal_error_signal_hook, standard_args):
7558 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7559 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7560 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7561 * lisp.h (fatal_error_signal_hook): Remove decl.
7562 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7564 * editfns.c: Move a (normally-unused) function to its only use.
7565 * editfns.c, lisp.h (get_operating_system_release): Remove.
7566 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7567 worth the hassle of breaking this out.
7569 * xterm.c: Make symbols static if they're not exported.
7570 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7571 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7572 (x_destroy_window, x_delete_display):
7574 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7575 (x_mouse_leave): Remove; unused.
7576 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7577 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7578 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7580 (x_mouse_leave): Declare only if WINDOWSNT.
7581 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7582 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7585 * ftxfont.c: Make symbols static if they're not exported.
7586 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7588 * font.h (ftxfont_driver): Likewise.
7590 * xfns.c: Make symbols static if they're not exported.
7591 (x_last_font_name, x_display_info_for_name):
7592 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7593 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7594 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7595 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7596 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7597 (last_show_tip_args): Now static.
7598 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7599 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7600 (x_screen_planes): Remove; unused.
7601 * dispextern.h (x_screen_planes): Remove decl.
7603 * dispnew.c: Make symbols static if they're not exported.
7604 * dispextern.h (redraw_garbaged_frames, scrolling):
7605 (increment_row_positions): Remove.
7606 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7607 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7609 (redraw_garbaged_frames): Remove; unused.
7611 * xfaces.c: Make symbols static if they're not exported.
7612 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7614 * xterm.h (defined_color): Remove decls.
7615 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7616 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7617 (menu_face_changed_default, defined_color, free_realized_face):
7618 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7619 (ascii_face_of_lisp_face): Remove; unused.
7621 * xdisp.c: Make symbols static if they're not exported.
7622 * dispextern.h (scratch_glyph_row, window_box_edges):
7623 (glyph_to_pixel_coords, set_cursor_from_row):
7624 (get_next_display_element, set_iterator_to_next):
7625 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7626 (show_mouse_face): Remove decls
7627 * frame.h (message_buf_print): Likewise.
7628 * lisp.h (pop_message, set_message, check_point_in_composition):
7630 * xterm.h (set_vertical_scroll_bar): Likewise.
7631 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7632 (message_buf_print, scratch_glyph_row, displayed_buffer):
7633 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7634 (get_next_display_element, show_mouse_face, window_box_edges):
7635 (frame_to_window_pixel_xy, check_point_in_composition):
7636 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7637 (glyph_to_pixel_coords): Remove; unused.
7639 * dired.c (file_name_completion): Now static.
7641 * dbusbind.c (xd_in_read_queued_messages): Now static.
7643 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7644 * data.c (circular_list_error): Remove.
7646 * commands.h (last_point_position, last_point_position_buffer):
7647 (last_point_position_window): Remove decls.
7648 * keyboard.c: Make these variables static.
7650 * coding.h (coding, code_convert_region, encode_coding_gap):
7652 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7653 (iso_code_class, detect_coding, code_convert_region): Now static.
7654 (encode_coding_gap): Remove; unused.
7656 * chartab.c (chartab_chars, chartab_bits): Now static.
7658 * charset.h (charset_iso_8859_1): Remove decl.
7659 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7662 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7663 * ccl.c (Vccl_program_table): Now static.
7664 (check_ccl_update): Remove; unused.
7666 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7667 * category.h: ... from here.
7668 * category.c (check_category_table, set_category_set): Now static.
7670 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7671 * lisp.h: Remove these decls.
7673 * buffer.c (buffer_count): Remove unused var.
7675 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7676 so that it's not optimized away.
7677 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7678 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7679 exported only to the debugger.
7681 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7682 * atimer.h (run_all_atimers): Remove; not exported.
7684 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7685 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7686 was inaccessible from Lisp.
7687 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7688 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7690 alloc.c: Import and export fewer symbols, and remove unused items.
7691 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7693 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7694 it's not optimized away by whole-program optimization.
7695 (message_enable_multibyte, free_misc): Remove.
7696 (catchlist, handlerlist, mark_backtrace):
7697 Declare only if BYTE_MARK_STACK.
7698 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7699 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7700 (message_enable_multibyte): Remove decl.
7701 (free_misc, interval_free_list, float_block, float_block_index):
7702 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7703 (cons_free_list, last_marked_index):
7705 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7706 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7707 (mark_backtrace): Define only if BYTE_MARK_STACK.
7708 * xdisp.c (message_enable_multibyte): Now static.
7710 Declare Lisp_Object Q* variables to be 'static' if not exported.
7711 This makes it easier for human readers (and static analyzers)
7712 to see whether these variables are used from other modules.
7713 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7714 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7715 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7716 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7717 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7718 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7719 * xmenu.c, xselect.c:
7720 Declare Q* vars static if they are not used in other modules.
7721 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7722 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7723 Remove decls of unexported vars.
7724 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7726 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7728 Make Emacs functions such as Fatom 'static' by default.
7729 This makes it easier for human readers (and static analyzers)
7730 to see whether these functions can be called from other modules.
7731 DEFUN now defines a static function. To make the function external
7732 so that it can be used in other C modules, use the new macro DEFUE.
7733 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7734 (Finit_image_library):
7735 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7736 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7737 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7738 Remove decls, since these functions are now static.
7739 (Funintern, Fget_internal_run_time): New decls, since these functions
7740 were already external.
7742 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7743 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7744 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7745 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7746 * keyboard.c, keymap.c, lread.c:
7747 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7748 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7749 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7750 Mark functions with DEFUE instead of DEFUN,
7751 if they are used in other modules.
7752 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7753 decls for now-static functions.
7754 * buffer.h (Fdelete_overlay): Remove decl.
7755 * callproc.c (Fgetenv_internal): Mark as internal.
7756 * composite.c (Fremove_list_of_text_properties): Remove decl.
7757 (Fcomposition_get_gstring): New forward static decl.
7758 * composite.h (Fcomposite_get_gstring): Remove decl.
7759 * dired.c (Ffile_attributes): New forward static decl.
7760 * doc.c (Fdocumntation_property): New forward static decl.
7761 * eval.c (Ffetch_bytecode): New forward static decl.
7762 (Funintern): Remove extern decl; now in .h file where it belongs.
7763 * fileio.c (Fmake_symbolic_link): New forward static decl.
7764 * image.c (Finit_image_library): New forward static decl.
7765 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7766 * intervals.h (Fprevious_property_change):
7767 (Fremove_list_of_text_properties): Remove decls.
7768 * keyboard.c (Fthis_command_keys): Remove decl.
7769 (Fcommand_execute): New forward static decl.
7770 * keymap.c (Flookup_key): New forward static decl.
7771 (Fcopy_keymap): Now static.
7772 * keymap.h (Flookup_key): Remove decl.
7773 * process.c (Fget_process): New forward static decl.
7774 (Fprocess_datagram_address): Mark as internal.
7775 * syntax.c (Fsyntax_table_p): New forward static decl.
7776 (skip_chars): Remove duplicate decl.
7777 * textprop.c (Fprevious_property_change): New forward static decl.
7778 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7780 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7781 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7783 * editfns.c (Fformat): Remove unreachable code.
7785 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7787 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7790 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7792 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7793 when at ZV. (Bug#8487)
7795 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7797 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7799 * keyboard.c (parse_tool_bar_item): Likewise.
7800 * sound.c (sound_cleanup, alsa_close): Likewise.
7801 * termcap.c (tgetent): Likewise.
7802 * xfns.c (x_default_font_parameter): Likewise.
7803 * xsettings.c (read_and_apply_settings): Likewise.
7805 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7806 (overrun_check_free): Protoize.
7808 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7810 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7811 since callers should never pass a negative size.
7812 Change the signature to match that of plain 'read' and 'write'; see
7813 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7814 * lisp.h: Update prototypes of emacs_write and emacs_read.
7816 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7818 * xdisp.c (redisplay_window): Don't try to determine the character
7819 position of the scroll margin if the window start point w->startp
7820 is outside the buffer's accessible region. (Bug#8468)
7822 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7824 Fix write-region and its subroutines for buffers > 2GB.
7825 * fileio.c (a_write, e_write): Modify declaration of arguments and
7826 local variables to support buffers larger than 2GB.
7827 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7829 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7830 argument, local variables, and return value.
7832 * lisp.h: Update prototypes of emacs_write and emacs_read.
7834 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7836 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7838 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7840 Fix more problems found by GCC 4.6.0's static checks.
7842 * xdisp.c (vmessage): Use a better test for character truncation.
7844 * charset.c (load_charset_map): <, not <=, for optimization,
7845 and to avoid potential problems with integer overflow.
7846 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7847 * casetab.c (set_identity, shuffle): Likewise.
7848 * editfns.c (Fformat): Likewise.
7849 * syntax.c (skip_chars): Likewise.
7851 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7852 This also lets GCC 4.6.0 generate slightly better loop code.
7854 * callint.c (Fcall_interactively): <, not <=, for optimization.
7855 (Fcall_interactively): Count the number of arguments produced,
7856 not the number of arguments given. This is simpler and lets GCC
7857 4.6.0 generate slightly better code.
7859 * ftfont.c: Distingish more carefully between FcChar8 and char.
7860 The previous code passed unsigned char * to a functions like
7861 strlen and xstrcasecmp that expect char *, which does not
7862 conform to the C standard.
7863 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7864 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7865 char * when the C standard requires it.
7867 * keyboard.c (read_char): Remove unused var.
7869 * eval.c: Port to Windows vsnprintf (Bug#8435).
7871 (SIZE_MAX): Define if the headers do not.
7872 (verror): Do not give up if vsnprintf returns a negative count.
7873 Instead, grow the buffer. This ports to Windows vsnprintf, which
7874 does not conform to C99. Problem reported by Eli Zaretskii.
7875 Also, simplify the allocation scheme, by avoiding the need for
7876 calling realloc, and removing the ALLOCATED variable.
7878 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7880 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7881 But keep the doprint source code for now, as we might revamp it
7882 and use it again (Bug#8435).
7883 * lisp.h (doprnt): Remove.
7884 * Makefile.in (base_obj): Remove doprnt.o.
7885 * deps.mk (doprnt.o): Remove.
7887 error: Print 32- and 64-bit integers portably (Bug#8435).
7888 Without this change, on typical 64-bit hosts error ("...%d...", N)
7889 was used to print both 32- and 64-bit integers N, which relied on
7891 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7892 * lisp.h (error, verror): Mark as printf-like functions.
7893 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7894 Report overflow in size calculations when allocating printf buffer.
7895 Do not truncate output string at its first null byte.
7896 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7897 Truncate the output at a character boundary, since vsnprintf does not
7899 * charset.c (check_iso_charset_parameter): Convert internal
7900 character to string before calling 'error', since %c now has the
7902 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7903 overflow when computing char to be passed to 'error'. Do not
7904 pass Lisp_Object to 'error'; pass the integer instead.
7905 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7906 formatted with plain %d.
7908 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7910 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7912 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7914 * xterm.c (x_catch_errors): Remove duplicate declaration.
7916 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7918 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7920 2011-04-10 Jim Meyering <meyering@redhat.com>
7922 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7923 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7924 return ssize_t not "int", and use size_t as the buffer length.
7925 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7926 * gnutls.h: Update declarations.
7927 * process.c (read_process_output): Use ssize_t, to match.
7928 (send_process): Likewise.
7930 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7932 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7934 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7936 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7937 Use unsigned char, to match FcChar8 type definition.
7939 * xterm.c (handle_one_xevent):
7940 * xmenu.c (create_and_show_popup_menu):
7941 * xselect.c (x_decline_selection_request)
7942 (x_reply_selection_request): Avoid type-punned deref of X events.
7944 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7946 Fix some uses of `int' instead of EMACS_INT.
7947 * search.c (string_match_1, fast_string_match)
7948 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7949 (scan_buffer, find_next_newline_no_quit)
7950 (find_before_next_newline, search_command, Freplace_match)
7951 (Fmatch_data): Make some `int' variables be EMACS_INT.
7953 * xdisp.c (display_count_lines): 3rd argument and return value now
7954 EMACS_INT. All callers changed.
7955 (pint2hrstr): Last argument is now EMACS_INT.
7957 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7958 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7959 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7960 (decode_coding_utf_16, decode_coding_emacs_mule)
7961 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7962 (decode_coding_ccl, decode_coding_charset)
7963 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7964 (decode_coding_iso_2022, decode_coding_emacs_mule)
7965 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7966 <char_offset, last_offset>: Declare EMACS_INT.
7967 (encode_coding_utf_8, encode_coding_utf_16)
7968 (encode_coding_emacs_mule, encode_invocation_designation)
7969 (encode_designation_at_bol, encode_coding_iso_2022)
7970 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7971 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7973 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7974 (encode_invocation_designation): Last argument P_NCHARS is now
7976 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7977 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7979 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7982 * ccl.c (Fccl_execute_on_string): Declare some variables
7985 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7987 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7989 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7991 * process.c (Fformat_network_address): Doc fix.
7993 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7995 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7997 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7999 * keyboard.c (read_char): Call Lisp function help-form-show,
8000 instead of using internal_with_output_to_temp_buffer.
8001 (Qhelp_form_show): New var.
8002 (syms_of_keyboard): Use DEFSYM macro.
8004 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8006 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8008 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8010 * process.c (Flist_processes): Remove to Lisp.
8011 (list_processes_1): Delete.
8013 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8015 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8017 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8019 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8021 Fix more problems found by GCC 4.6.0's static checks.
8023 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8025 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8027 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8029 * xdisp.c (vmessage): Mark as a printf-like function.
8031 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8033 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8035 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8036 printf-like functions.
8037 (tiff_load): Add casts to remove these marks before passing them
8038 to system-supplied API.
8040 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8042 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8043 This avoids several warnings with gcc -Wstrict-overflow.
8044 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8045 directly, rather than having caller test rule sign. This avoids
8046 some unnecessary tests.
8047 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8048 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8049 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8051 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8052 (xfont_open): Avoid unnecessary tests.
8054 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8056 * composite.h, composite.c (composition_gstring_put_cache):
8057 Use EMACS_INT, not int, for length.
8059 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8060 breaking out part of COMPOSITION_DECODE_RULE.
8061 (COMPOSITION_DECODE_RULE): Use it.
8062 * composite.c (get_composition_id): Remove unused local vars,
8063 by using the new macro.
8065 * textprop.c (set_text_properties_1): Change while to do-while,
8066 since the condition is always true at first.
8068 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8069 (interval_deletion_adjustment): Return unsigned value.
8072 * process.c (list_processes_1, create_pty, read_process_output):
8073 (exec_sentinel): Remove vars that were set but not used.
8074 (create_pty): Remove unnecessary "volatile"s.
8075 (Fnetwork_interface_info): Avoid possibility of int overflow.
8076 (read_process_output): Do adaptive read buffering even if carryover.
8077 (read_process_output): Simplify nbytes computation if buffered.
8079 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8081 * syntax.c (scan_words): Remove var that was set but not used.
8082 (update_syntax_table): Use unsigned instead of int.
8084 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8085 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8086 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8088 * print.c (print_error_message): Avoid int overflow.
8090 * font.c (font_list_entities): Redo for clarity,
8091 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8093 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8094 (font_score): Avoid potential overflow in diff calculation.
8096 * fns.c (substring_both): Remove var that is set but not used.
8097 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8099 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8101 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8102 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8103 can always succeed if overflow has undefined behavior.
8105 * search.c (boyer_moore, wordify): Remove vars set but not used.
8106 (wordify): Omit three unnecessary tests.
8108 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8109 All callers changed. This avoids the need for an unused var.
8111 * casefiddle.c (casify_region): Remove var that is set but not used.
8113 * dired.c (file_name_completion): Remove var that is set but not used.
8115 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8117 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8118 (Finsert_file_contents): Remove unnecessary code checking fd.
8120 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8121 Check for integer overflow on size calculations.
8123 * buffer.c (Fprevious_overlay_change): Remove var that is set
8126 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8127 Remove vars that are set but not used.
8128 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8129 (timer_check_2): Mark vars as initialized.
8131 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8133 * image.c (lookup_image): Remove var that is set but not used.
8134 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8136 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8137 that are set but not used.
8139 * xfns.c (make_invisible_cursor): Don't return garbage
8140 if XCreateBitmapFromData fails (Bug#8410).
8142 * xselect.c (x_get_local_selection, x_handle_property_notify):
8143 Remove vars that are set but not used.
8145 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8146 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8148 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8149 Remove var that is set but not used.
8150 (scroll_bar_windows_size): Now size_t, not int.
8151 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8154 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8155 (map_tty_color) [!defined MSDOS]: Likewise.
8157 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8159 * coding.c: Remove vars that are set but not used.
8160 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8161 All callers changed.
8162 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8163 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8164 (decode_coding_charset): Remove vars that are set but not used.
8166 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8167 that is set but not used.
8169 * print.c (print_object): Remove var that is set but not used.
8171 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8172 The gnulib version avoids calling malloc in the usual case,
8173 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8174 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8175 * filelock.c (current_lock_owner): Likewise.
8176 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8177 * sysdep.c: Include allocator.h, careadlinkat.h.
8178 (emacs_no_realloc_allocator): New static constant.
8179 (emacs_readlink): New function.
8180 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8181 ../lib/careadlinkat.h.
8183 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8185 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8186 first non-nil return value).
8188 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8190 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8191 if not defined (Bug#8403).
8193 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8195 * xdisp.c (display_count_lines): Remove parameter `start',
8196 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8197 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8198 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8199 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8200 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8201 and thereabouts. All callers changed.
8202 (get_per_char_metric): Remove parameter `f', unused since
8203 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8205 2011-04-02 Jim Meyering <meyering@redhat.com>
8207 do not dereference NULL upon failed strdup
8208 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8209 (ns_get_family): Likewise.
8211 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8213 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8215 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8217 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8220 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8222 Add lexical binding.
8224 * window.c (Ftemp_output_buffer_show): New fun.
8225 (Fsave_window_excursion):
8226 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8228 * lread.c (lisp_file_lexically_bound_p): New function.
8229 (Fload): Bind Qlexical_binding.
8230 (readevalloop): Remove `evalfun' arg.
8231 Bind Qinternal_interpreter_environment.
8232 (Feval_buffer): Bind Qlexical_binding.
8233 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8235 (syms_of_lread): Declare `lexical-binding'.
8237 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8239 * keyboard.c (eval_dyn): New fun.
8240 (menu_item_eval_property): Use it.
8242 * image.c (parse_image_spec): Use Ffunctionp.
8244 * fns.c (concat, mapcar1): Accept byte-code-functions.
8246 * eval.c (Fsetq): Handle lexical vars.
8247 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8248 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8249 (FletX, Flet): Obey lexical binding.
8250 (Fcommandp): Handle closures.
8251 (Feval): New `lexical' arg.
8252 (eval_sub): New function extracted from Feval. Use it almost
8253 everywhere where Feval was used. Look up vars in lexical env.
8255 (Ffunctionp): Move from subr.el.
8256 (Ffuncall): Handle closures.
8257 (apply_lambda): Remove `eval_flags'.
8258 (funcall_lambda): Handle closures and new byte-code-functions.
8259 (Fspecial_variable_p): New function.
8260 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8261 but without exporting it to Lisp.
8263 * doc.c (Fdocumentation, store_function_docstring):
8264 * data.c (Finteractive_form): Handle closures.
8266 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8269 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8271 (exec_byte_code): New function extracted from Fbyte_code to handle new
8272 calling convention for byte-code-functions. Add new byte-codes.
8274 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8276 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8278 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8280 * xdisp.c (redisplay_internal): Fix prototype.
8282 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8284 * xdisp.c (SCROLL_LIMIT): New macro.
8285 (try_scrolling): Use it when setting scroll_limit.
8286 Limit scrolling to 100 screen lines.
8287 (redisplay_window): Even when falling back on "recentering",
8288 position point in the window according to scroll-conservatively,
8289 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8291 (try_scrolling): When point is above the window, allow searching
8292 as far as scroll_max, or one screenful, to compute vertical
8293 distance from PT to the scroll margin position. This prevents
8294 try_scrolling from unnecessarily failing when
8295 scroll-conservatively is set to a value slightly larger than the
8296 window height. Clean up the case of PT below the margin at bottom
8297 of window: scroll_max can no longer be INT_MAX. When aggressive
8298 scrolling is in use, don't let point enter the opposite scroll
8299 margin as result of the scroll.
8300 (syms_of_xdisp) <scroll-conservatively>: Document the
8301 threshold of 100 lines for never-recentering scrolling.
8303 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8305 * dispextern.h (move_it_by_lines):
8306 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8307 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8308 (message_log_check_duplicate): Remove parameters `prev_bol' and
8309 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8310 (redisplay_internal): Remove parameter `preserve_echo_area',
8311 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8313 * indent.c (Fvertical_motion):
8314 * window.c (window_scroll_pixel_based, Frecenter):
8315 Don't pass `need_y_p' to `move_it_by_lines'.
8317 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8319 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8320 steal a few bits to be more compact.
8321 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8322 Remove unneeded casts.
8324 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8326 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8328 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8329 binding" message (bug#7967).
8331 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8333 Fix more problems found by GCC 4.6.0's static checks.
8335 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8336 Remove unused local var.
8338 * editfns.c (Fmessage_box): Remove unused local var.
8340 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8341 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8342 Omit unused local vars.
8343 * window.c (shrink_windows): Omit unused local var.
8344 * menu.c (digest_single_submenu): Omit unused local var.
8345 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8346 Omit unused local var.
8348 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8349 Don't assume string length fits in int.
8350 (keyremap_step, read_key_sequence): Use size_t for sizes.
8351 (read_key_sequence): Don't check last_real_key_start redundantly.
8353 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8354 instead of alloca (Bug#8344).
8356 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8357 (Fbacktrace_frame): Don't assume nframes fits in int.
8359 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8361 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8364 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8366 * cm.c (calccost): Turn while-do into do-while, for clarity.
8368 * keyboard.c (syms_of_keyboard): Use the same style as later
8369 in this function when indexing through an array. This also
8370 works around GCC bug 48267.
8372 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8374 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8376 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8377 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8379 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8380 This avoids undefined behavior on integer overflow, and is a bit
8381 more convenient anyway since it is compared to a size_t variable.
8383 Variadic C functions now count arguments with size_t, not int.
8384 This avoids an unnecessary limitation on 64-bit machines, which
8385 caused (substring ...) to crash on large vectors (Bug#8344).
8386 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8387 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8388 All variadic functions and their callers changed accordingly.
8389 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8390 * data.c (arith_driver, float_arith_driver): Likewise.
8391 * editfns.c (general_insert_function): Likewise.
8392 * eval.c (struct backtrace.nargs, interactive_p)
8393 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8394 (funcall_lambda, mark_backtrace): Likewise.
8395 * fns.c (concat): Likewise.
8396 * frame.c (x_set_frame_parameters): Likewise.
8397 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8398 0 if not found, not -1. All callers changed.
8400 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8401 (stack_copy_size): Now size_t, not int.
8402 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8404 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8406 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8407 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8408 All callers changed.
8410 * lisp.h (multibyte_char_to_unibyte):
8411 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8412 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8413 * character.h (CHAR_TO_BYTE8):
8414 * cmds.c (internal_self_insert):
8415 * editfns.c (general_insert_function):
8416 * keymap.c (push_key_description):
8417 * search.c (Freplace_match):
8418 * xdisp.c (message_dolog, set_message_1): All callers changed.
8420 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8422 * keyboard.c (safe_run_hook_funcall): New function.
8423 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8424 don't set the hook to nil, but remove the offending function instead.
8425 (Qcommand_hook_internal): Remove, unused.
8426 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8427 Vcommand_hook_internal.
8429 * eval.c (enum run_hooks_condition): Remove.
8430 (funcall_nil, funcall_not): New functions.
8431 (run_hook_with_args): Call each function through a `funcall' argument.
8432 Remove `cond' argument, now redundant.
8433 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8434 (Frun_hook_with_args_until_failure): Adjust accordingly.
8435 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8439 * dispextern.h (string_buffer_position): Remove declaration.
8441 * print.c (strout): Remove parameter `multibyte', unused since
8442 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8444 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8445 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8446 All callers changed.
8448 * w32.c (_wsa_errlist): Use braces for struct initializers.
8450 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8451 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8452 All callers changed.
8453 (string_buffer_position): Likewise. Also, make static (it's never
8454 used outside xdisp.c).
8455 (cursor_row_p): Remove parameter `w', unused since
8456 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8457 (decode_mode_spec): Remove parameter `precision', introduced during
8458 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8459 All callers changed.
8461 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8463 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8465 2011-03-27 Anders Lindgren <andlind@gmail.com>
8467 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8468 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8469 (ns_update_auto_hide_menu_bar): New functions.
8470 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8471 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8472 ns_constrain_all_frames.
8473 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8474 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8476 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8478 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8480 2011-03-27 Glenn Morris <rgm@gnu.org>
8482 * syssignal.h: Replace RETSIGTYPE with void.
8483 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8484 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8485 Replace SIGTYPE with void everywhere.
8486 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8487 * s/template.h (SIGTYPE): Remove commented out definition.
8489 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8491 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8492 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8494 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8496 * w32.c (read_unc_volume): Use parameter `henum', instead of
8497 global variable `wget_enum_handle'.
8499 * keymap.c (describe_vector): Remove parameters `indices' and
8500 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8501 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8503 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8505 * keyboard.c (timer_check): Remove parameter `do_it_now',
8506 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8507 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8508 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8510 * keyboard.c (read_char):
8511 * w32menu.c (w32_menu_display_help):
8512 * xmenu.c (show_help_event, menu_help_callback):
8513 Adjust calls to `show_help_echo'.
8515 * gtkutil.c (xg_maybe_add_timer):
8516 * keyboard.c (readable_events):
8517 * process.c (wait_reading_process_output):
8518 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8520 * insdel.c (adjust_markers_gap_motion):
8521 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8522 (gap_left, gap_right): Don't call it.
8524 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8526 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8527 incurred during fontification.
8529 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8531 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8532 (DEFVAR_PER_BUFFER): Don't pass it.
8534 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8535 (scrolling_window): Don't pass it.
8537 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8539 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8541 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8543 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8544 of variables specific to SELinux and computation of `encoded_absname'.
8546 * image.c (XPutPixel): Remove unused variable `height'.
8548 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8550 * unexw32.c (get_section_info): Remove unused variable `section'.
8552 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8553 (system_process_attributes): Remove unused variable `sess'.
8554 (sys_read): Remove unused variable `err'.
8556 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8557 (w32_wnd_proc): Remove unused variable `isdead'.
8558 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8559 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8560 (x_create_tip_frame): Remove unused variable `tem'.
8562 * w32inevt.c (w32_console_read_socket):
8563 Remove unused variable `no_events'.
8565 * w32term.c (x_draw_composite_glyph_string_foreground):
8566 Remove unused variable `width'.
8568 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8570 * w32term.c (x_set_glyph_string_clipping):
8571 Don't pass uninitialized region to CombineRgn.
8573 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8575 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8576 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8577 (Fx_close_connection): Remove unused variable `i'.
8579 * w32font.c (w32font_draw): Return number of glyphs.
8580 (w32font_open_internal): Remove unused variable `i'.
8581 (w32font_driver): Add missing initializer.
8583 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8584 (fill_in_menu): Remove unused variable `items_added'.
8586 * w32term.c (last_mouse_press_frame): Remove static global variable.
8587 (w32_clip_to_row): Remove unused variable `f'.
8588 (x_delete_terminal): Remove unused variable `i'.
8590 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8591 (NOTHING): Remove unused static global variable.
8592 (uniscribe_check_otf): Remove unused variable `table'.
8593 (uniscribe_font_driver): Add missing initializers.
8595 2011-03-23 Julien Danjou <julien@danjou.info>
8597 * term.c (Fsuspend_tty, Fresume_tty):
8598 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8599 * window.c (temp_output_buffer_show):
8600 * insdel.c (signal_before_change):
8601 * frame.c (Fhandle_switch_frame):
8602 * fileio.c (Fdo_auto_save):
8603 * emacs.c (Fkill_emacs):
8604 * editfns.c (save_excursion_restore):
8605 * cmds.c (internal_self_insert):
8606 * callint.c (Fcall_interactively):
8607 * buffer.c (Fkill_all_local_variables):
8608 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8610 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8611 unconditionally since it does the check itself.
8613 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8615 Fix more problems found by GCC 4.5.2's static checks.
8617 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8618 the first time through the loop, since we know p0 < p1 then.
8619 This also avoids a gcc -Wstrict-overflow warning.
8621 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8622 leading to a memory leak, possible in functions like
8623 load_charset_map_from_file that can allocate an unbounded number
8624 of objects (Bug#8318).
8626 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8627 that could (at least in theory) be that large.
8629 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8630 This is less likely to overflow, and avoids undefined behavior if
8631 overflow does occur. All callers changed. Use strtoul to scan
8632 for the unsigned long integer.
8633 (pint2hrstr): Simplify and tune code slightly.
8634 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8636 * scroll.c (do_scrolling): Work around GCC bug 48228.
8637 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8639 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8640 This also avoids a warning with gcc -Wstrict-overflow.
8641 (validate_x_resource_name): Simplify count usage.
8642 This also avoids a warning with gcc -Wstrict-overflow.
8644 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8647 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8649 * process.c (Fmake_network_process): Use socklen_t, not int,
8650 where POSIX says socklen_t is required in portable programs.
8651 This fixes a porting bug on hosts like 64-bit HP-UX, where
8652 socklen_t is wider than int (Bug#8277).
8653 (Fmake_network_process, server_accept_connection):
8654 (wait_reading_process_output, read_process_output):
8657 * process.c: Rename or move locals to avoid shadowing.
8658 (list_processes_1, Fmake_network_process):
8659 (read_process_output_error_handler, exec_sentinel_error_handler):
8660 Rename or move locals.
8661 (Fmake_network_process): Define label "retry_connect" only if needed.
8662 (Fnetwork_interface_info): Fix pointer signedness.
8663 (process_send_signal): Add cast to avoid pointer signedness problem.
8664 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8665 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8667 Make tparam.h and terminfo.c consistent.
8668 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8669 Include tparam.h instead, since it declares them.
8670 * cm.h (PC): Remove extern decl; tparam.h now does this.
8671 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8672 * terminfo.c: Include tparam.h, to check interfaces.
8673 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8674 (tparam): Adjust signature to match interface in tparam.h;
8675 this removes some undefined behavior. Check that outstring and len
8676 are zero, which they always are with Emacs.
8677 * tparam.h (PC, BC, UP): New extern decls.
8679 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8680 (xftfont_open): Rename locals to avoid shadowing.
8682 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8683 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8684 (OTF_TAG_SYM): Omit macro if not needed.
8685 (ftfont_list): Remove unused local.
8686 (get_adstyle_property, ftfont_pattern_entity):
8687 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8688 Rename locals to avoid shadowing.
8690 * xfont.c (xfont_list_family): Mark var as initialized.
8692 * xml.c (make_dom): Now static.
8694 * composite.c (composition_compute_stop_pos): Rename local to
8696 (composition_reseat_it): Remove unused locals.
8697 (find_automatic_composition, composition_adjust_point): Likewise.
8698 (composition_update_it): Mark var as initialized.
8699 (find_automatic_composition): Mark vars as initialized,
8700 with a FIXME (Bug#8290).
8702 character.h: Rename locals to avoid shadowing.
8703 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8704 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8705 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8706 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8709 * textprop.c (property_change_between_p): Remove; unused.
8711 * intervals.c (interval_start_pos): Now static.
8713 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8715 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8716 Rename locals to avoid shadowing.
8718 * sound.c (wav_play, au_play, Fplay_sound_internal):
8719 Fix pointer signedness.
8720 (alsa_choose_format): Remove unused local var.
8721 (wav_play): Initialize a variable to 0, to prevent undefined
8722 behavior (Bug#8278).
8724 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8726 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8728 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8729 clobbering (Bug#8298).
8730 * sysdep.c (sys_subshell): Likewise.
8731 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8733 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8734 This should get cleaned up, so that child_setup has the
8735 same signature on all platforms.
8737 * callproc.c (call_process_cleanup): Now static.
8738 (relocate_fd): Rename locals to avoid shadowing.
8740 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8742 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8743 not to be necessary, and produces flickering.
8745 2011-03-20 Glenn Morris <rgm@gnu.org>
8747 * config.in: Remove file.
8749 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8751 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8752 are now in src/globals.h.
8753 (syms_of_minibuf): Remove spurious & from previous change.
8755 2011-03-20 Leo Liu <sdl.web@gmail.com>
8757 * minibuf.c (completing-read-function): New variable.
8758 (completing-read-default): Rename from completing-read.
8759 (completing-read): Call completing-read-function.
8761 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8763 * xfaces.c (Fx_load_color_file):
8764 Read color file from absolute filename (bug#8250).
8766 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8768 * makefile.w32-in: Update dependencies.
8770 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8772 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8774 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8776 Fix more problems found by GCC 4.5.2's static checks.
8778 * process.c (make_serial_process_unwind, send_process_trap):
8779 (sigchld_handler): Now static.
8781 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8782 That way, the code declares only the vars that it needs.
8783 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8784 * s/cygwin.h (PTY_ITERATION): Likewise.
8785 * s/darwin.h (PTY_ITERATION): Likewise.
8786 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8788 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8789 * process.c (allocate_pty): Don't declare stb unless it's needed.
8791 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8792 (CONSTANTLIM): Remove; unused.
8793 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8794 Define only if needed.
8796 * unexelf.c (unexec): Name an expression,
8797 to avoid gcc -Wbad-function-cast warning.
8798 Use a different way to cause a compilation error if anyone uses
8799 n rather than nn, a way that does not involve shadowing.
8800 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8802 * deps.mk (unexalpha.o): Remove; unused.
8804 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8805 * unexec.h: New file.
8806 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8807 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8809 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8810 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8811 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8812 Change as necessary to match prototype in unexec.h.
8814 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8816 (back_comment, skip_chars): Mark vars as initialized.
8818 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8819 Rename locals to avoid shadowing.
8821 * lread.c (read1): Rewrite so as not to use empty "else".
8822 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8824 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8826 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8827 warning when compiling print.c.
8829 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8830 instead of using an uninitialized var.
8831 (font_sort_entities): Mark var as initialized.
8833 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8835 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8836 pointers to constants.
8837 (font_parse_fcname): Remove unused vars.
8838 (font_delete_unmatched): Now static.
8839 (font_get_spec): Remove; unused.
8840 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8841 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8842 Rename or move locals to avoid shadowing.
8844 * fns.c (require_nesting_list, require_unwind): Now static.
8845 (Ffillarray): Rename locals to avoid shadowing.
8847 * floatfns.c (domain_error2): Define only if needed.
8848 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8850 * alloc.c (mark_backtrace): Move decl from here ...
8851 * lisp.h: ... to here, so that it can be checked.
8853 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8854 (Fdefvar): Rewrite so as not to use empty "else".
8855 (lisp_indirect_variable): Name an expression,
8856 to avoid gcc -Wbad-function-cast warning.
8857 (Fdefvar): Rename locals to avoid shadowing.
8859 * callint.c (quotify_arg, quotify_args): Now static.
8860 (Fcall_interactively): Rename locals to avoid shadowing.
8861 Use const pointer when appropriate.
8863 * lisp.h (get_system_name, get_operating_system_release):
8864 Move decls here, to check interfaces.
8865 * process.c (get_operating_system_release): Move decl to lisp.h.
8866 * xrdb.c (get_system_name): Likewise.
8867 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8868 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8869 some of which prompt warnings from gcc -Wbad-function-cast.
8870 (Fformat_time_string, Fencode_time, Finsert_char):
8871 (Ftranslate_region_internal, Fformat):
8872 Rename or remove local vars to avoid shadowing.
8873 (Ftranslate_region_internal): Mark var as initialized.
8875 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8878 * lisp.h (eassert): Check that the argument compiles, even if
8879 ENABLE_CHECKING is not defined.
8881 * data.c (Findirect_variable): Name an expression, to avoid
8882 gcc -Wbad-function-cast warning.
8883 (default_value, arithcompare, arith_driver, arith_error): Now static.
8884 (store_symval_forwarding): Rename local to avoid shadowing.
8885 (Fmake_variable_buffer_local, Fmake_local_variable):
8886 Mark variables as initialized.
8887 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8889 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8890 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8891 Rename locals to avoid shadowing.
8892 (mark_stack): Move local variables into the #ifdef region where
8894 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8895 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8897 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8898 (GC_STRING_CHARS): Remove; not used.
8899 (Fmemory_limit): Cast sbrk's returned value to char *.
8901 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8902 avoids undefined behavior in theory.
8904 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8906 Use functions, not macros, for up- and down-casing (Bug#8254).
8907 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8908 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8909 to use the following functions instead of these macros.
8910 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8911 EMACS_INT, since callers assume the returned value fits in int.
8912 (upcase1): Likewise, for UPCASE_TABLE.
8913 (uppercasep, lowercasep, upcase): New static inline functions.
8914 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8915 the race-condition problem in the old DOWNCASE.
8917 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8918 Rename locals to avoid shadowing.
8919 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8920 (regex_compile, re_search_2, re_match_2_internal):
8921 Remove unused local vars.
8922 (FREE_VAR): Rewrite so as not to use empty "else",
8923 which gcc can warn about.
8924 (regex_compile, re_match_2_internal): Mark locals as initialized.
8925 (RETALLOC_IF): Define only if needed.
8926 (WORDCHAR_P): Likewise. This one is never needed, but is used
8927 only in a comment talking about a compiler bug, so put inside
8928 the #if 0 of that comment.
8929 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8930 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8933 * search.c (boyer_moore): Rename locals to avoid shadowing.
8934 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8935 (PREV_CHAR_BOUNDARY): Likewise.
8937 * search.c (simple_search): Remove unused var.
8939 * dired.c (compile_pattern): Move decl from here ...
8940 * lisp.h: ... to here, so that it can be checked.
8941 (struct re_registers): New forward decl.
8943 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8945 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8947 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8948 Rename locals to avoid shadowing.
8949 (Fvertical_motion): Mark locals as initialized.
8951 * casefiddle.c (casify_object, casify_region): Now static.
8952 (casify_region): Mark local as initialized.
8954 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8956 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8957 New macros, so that the caller can use some names other than
8958 gcpro1, gcpro2, etc.
8959 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8961 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8962 argument, for consistency with GCPRO2_VAR, etc: it is now the
8963 prefix of the variable, not the variable itself. All uses
8965 * dired.c (directory_files_internal, file_name_completion):
8966 Rename locals to avoid shadowing.
8968 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8969 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8970 dired.c's scmp function, had undefined behavior.
8971 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8972 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8973 * buffer.h: ... to here, because these macros use current_buffer,
8974 and the new implementation with inline functions needs to have
8975 current_buffer in scope now, rather than later when the macros
8977 (downcase, upcase1): New static inline functions.
8978 (DOWNCASE, UPCASE1): Reimplement using these functions.
8979 This avoids undefined behavior in expressions like
8980 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8981 from race conditions in accessing the global variables
8982 case_temp1 and case_temp2.
8983 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8984 * lisp.h (case_temp1, case_temp2): Remove their decls.
8985 * character.h (ASCII_CHAR_P): Move from here ...
8986 * lisp.h: ... to here, so that the inline functions mentioned
8989 * dired.c (directory_files_internal_unwind): Now static.
8991 * fileio.c (file_name_as_directory, directory_file_name):
8992 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8994 (file_name_as_directory): Use const pointers when appropriate.
8995 (Fexpand_file_name): Likewise. In particular, newdir might
8996 point at constant storage, so make it a const pointer.
8997 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8998 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9000 (Fset_file_times, Finsert_file_contents, auto_save_error):
9001 Rename locals to avoid shadowing.
9003 * minibuf.c (choose_minibuf_frame_1): Now static.
9004 (Ftry_completion, Fall_completions): Rename or remove locals
9007 * marker.c (bytepos_to_charpos): Remove; unused.
9009 * lisp.h (verify_bytepos, count_markers): New decls,
9010 so that gcc does not warn that these functions aren't declared.
9012 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9013 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9014 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9015 (copy_text): Remove unused local var.
9017 * filelock.c (within_one_second): Now static.
9018 (lock_file_1): Rename local to avoid shadowing.
9020 * buffer.c (fix_overlays_before): Mark locals as initialized.
9021 (fix_start_end_in_overlays): Likewise. This function should be
9022 simplified by using pointers-to-pointers, but that's a different
9024 (switch_to_buffer_1): Now static.
9025 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9026 (report_overlay_modification): Rename locals to avoid shadowing.
9028 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9029 Fix pointer signedness issue.
9030 (sys_subshell): Mark local as volatile if checking for lint,
9031 to suppress a gcc -Wclobbered warning that does not seem to be right.
9032 (MAXPATHLEN): Define only if needed.
9034 * process.c (serial_open, serial_configure): Move decls from here ...
9035 * systty.h: ... to here, so that they can be checked.
9037 * fns.c (get_random, seed_random): Move extern decls from here ...
9038 * lisp.h: ... to here, so that they can be checked.
9040 * sysdep.c (reset_io): Now static.
9041 (wait_for_termination_signal): Remove; unused.
9043 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9044 (copy_keymap_item, append_key, push_text_char_description):
9046 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9047 (DENSE_TABLE_SIZE): Remove; unused.
9048 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9049 (describe_map_tree):
9050 Rename locals to avoid shadowing.
9052 * keyboard.c: Declare functions static if they are not used elsewhere.
9053 (echo_char, echo_dash, cmd_error, top_level_2):
9054 (poll_for_input, handle_async_input): Now static.
9055 (read_char, kbd_buffer_get_event, make_lispy_position):
9056 (make_lispy_event, make_lispy_movement, apply_modifiers):
9057 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9058 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9059 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9060 (read_key_sequence, read_char): Mark locals as initialized.
9061 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9063 * keyboard.h (make_ctrl_char): New decl.
9064 (mark_kboards): Move decl here ...
9065 * alloc.c (mark_kboards): ... from here.
9067 * lisp.h (force_auto_save_soon): New decl.
9069 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9070 (DEFINE_DUMMY_FUNCTION): New macro.
9071 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9073 (main): Add casts to avoid warnings
9074 if GCC considers string literals to be constants.
9076 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9078 * dbusbind.c: Pointer signedness fixes.
9079 (xd_signature, xd_append_arg, xd_initialize):
9080 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9081 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9082 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9083 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9085 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9086 if GCC considers string literals to be constants.
9087 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9089 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9091 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9092 (print_preprocess, print_object): New macro to fix last change.
9094 * print.c (print_preprocess): Don't forget font objects.
9096 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9098 * emacs.c (USAGE3): Doc fixes.
9100 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9102 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9105 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9107 * lisp.h (VWindow_system, Qfile_name_history):
9108 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9109 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9110 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9112 * w32select.c: Don't #include "keyboard.h".
9113 (run_protected): Add extern declaration for waiting_for_input.
9115 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9116 * w32console.c (detect_input_pending, read_input_pending)
9117 (encode_terminal_code):
9118 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9119 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9120 (w32_system_caret_y, Qfile_name_history):
9121 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9122 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9123 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9124 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9125 * w32proc.c (Qlocal, report_file_error):
9126 * w32term.c (Vwindow_system, updating_frame):
9127 * w32uniscribe.c (initialized, uniscribe_font_driver):
9128 Remove unneeded extern declarations.
9130 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9132 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9134 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9136 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9137 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9138 These macros can no longer be used for assignment.
9140 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9141 Assign struct members directly, instead of using BUF_BEGV etc.
9142 (record_buffer_markers, fetch_buffer_markers): New functions for
9143 recording and fetching special buffer markers.
9144 (set_buffer_internal_1, set_buffer_temp): Use them.
9146 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9148 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9150 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9151 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9153 * xdisp.c (hscroll_window_tree):
9154 (reconsider_clip_changes): Use PT instead of BUF_PT.
9156 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9158 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9159 $(EMACS_ROOT)/lib/intprops.h.
9161 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9163 Fix more problems found by GCC 4.5.2's static checks.
9165 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9166 to unsigned char * to avoid compiler diagnostic.
9167 (xg_free_frame_widgets): Make it clear that a local variable is
9168 needed only if USE_GTK_TOOLTIP.
9169 (gdk_window_get_screen): Make it clear that this macro is needed
9170 only if USE_GTK_TOOLTIP.
9171 (int_gtk_range_get_value): New function, which avoids a diagnostic
9172 from gcc -Wbad-function-cast.
9173 (xg_set_toolkit_scroll_bar_thumb): Use it.
9174 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9175 diagnostic from gcc -Wbad-function-cast.
9176 (get_utf8_string, xg_get_file_with_chooser):
9177 Rename locals to avoid shadowing.
9178 (create_dialog): Move locals to avoid shadowing.
9180 * xgselect.c (xg_select): Remove unused var.
9182 * image.c (four_corners_best): Mark locals as initialized.
9183 (gif_load): Initialize transparent_p to zero (Bug#8238).
9184 Mark another local as initialized.
9185 (my_png_error, my_error_exit): Mark with NO_RETURN.
9187 * image.c (clear_image_cache): Now static.
9188 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9189 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9190 (x_edge_detection): Remove unnecessary cast that
9191 gcc -Wbad-function-cast diagnoses.
9192 (gif_load): Fix pointer signedness.
9193 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9194 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9196 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9198 Improve quality of tests for time stamp overflow.
9199 For example, without this patch (encode-time 0 0 0 1 1
9200 1152921504606846976) returns the obviously-bogus value (-948597
9201 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9202 reports time overflow. See
9203 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9204 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9205 * editfns.c: Include limits.h and intprops.h.
9206 (TIME_T_MIN, TIME_T_MAX): New macros.
9207 (time_overflow): Move earlier, to before first use.
9208 (hi_time, lo_time): New functions, for an accurate test for
9210 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9211 (Fget_internal_run_time): Don't assume time_t fits in int.
9212 (make_time): Use list2 instead of Fcons twice.
9213 (Fdecode_time): More accurate test for out-of-range times.
9214 (check_tm_member): New function.
9215 (Fencode_time): Use it, to test for out-of-range times.
9216 (lisp_time_argument): Don't rely on undefined left-shift and
9217 right-shift behavior when checking for time stamp overflow.
9219 * editfns.c (time_overflow): New function, refactoring common code.
9220 (Fformat_time_string, Fdecode_time, Fencode_time):
9221 (Fcurrent_time_string): Use it.
9223 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9224 * dired.c (make_time): Move to ...
9225 * editfns.c (make_time): ... here.
9226 * systime.h: Note the move.
9228 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9230 * fringe.c (update_window_fringes): Remove unused variables.
9232 * unexmacosx.c (copy_data_segment): Also copy __got section.
9235 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9237 * termcap.c [MSDOS]: Include "msdos.h".
9238 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9239 Constify `char *' arguments and their references according to
9240 prototypes in tparam.h.
9242 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9244 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9245 Adapt all references accordingly.
9247 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9249 2011-03-11 Tom Tromey <tromey@redhat.com>
9251 * buffer.c (syms_of_buffer): Remove obsolete comment.
9253 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9255 * termhooks.h (encode_terminal_code): Declare prototype.
9257 * msdos.c (encode_terminal_code): Don't declare prototype.
9259 * term.c (encode_terminal_code): Now external again, used by
9260 w32console.c and msdos.c.
9262 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9263 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9265 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9267 Fix some minor problems found by GCC 4.5.2's static checks.
9269 * fringe.c (update_window_fringes): Mark locals as initialized
9271 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9273 * alloc.c (mark_fringe_data): Move decl from here ...
9274 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9275 to check its interface.
9276 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9278 * fontset.c (free_realized_fontset): Now static.
9279 (Fset_fontset_font): Rename local to avoid shadowing.
9280 (fontset_font): Mark local as initialized.
9281 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9283 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9285 * xselect.c (x_disown_buffer_selections): Remove; not used.
9286 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9287 (x_own_selection, Fx_disown_selection_internal): Rename locals
9289 (x_handle_dnd_message): Remove local to avoid shadowing.
9291 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9292 so that the caller can use some name other than gcpro1.
9293 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9294 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9295 (Fx_backspace_delete_keys_p):
9296 Use them to avoid shadowing, and rename vars to avoid shadowing.
9297 (x_decode_color, x_set_name, x_window): Now static.
9298 (Fx_create_frame): Add braces to silence GCC warning.
9299 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9300 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9301 Remove unused locals.
9302 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9303 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9304 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9307 * xterm.h (x_mouse_leave): New decl.
9309 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9310 Remove unused functions.
9311 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9312 (x_calc_absolute_position): Now static.
9313 (XTread_socket): Don't define label "out" unless it's used.
9314 Don't declare local "event" unless it's used.
9315 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9316 unless they are used.
9317 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9318 (x_fatal_error_signal): Remove; not used.
9319 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9320 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9321 (x_error_catcher, x_connection_closed, x_error_handler):
9322 (x_error_quitter, xembed_send_message, x_iconify_frame):
9323 (my_log_handler): Rename locals to avoid shadowing.
9324 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9325 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9327 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9328 Rename or move locals to avoid shadowing.
9329 (tty_defined_color, merge_face_heights): Now static.
9330 (free_realized_faces_for_fontset): Remove; not used.
9331 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9332 does not deduce is never used uninitialized.
9333 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9334 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9336 * terminal.c (store_terminal_param): Now static.
9338 * xmenu.c (menu_highlight_callback): Now static.
9339 (set_frame_menubar): Remove unused local.
9340 (xmenu_show): Rename parameter to avoid shadowing.
9341 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9342 since they might point to immutable storage.
9343 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9344 since it's unused otherwise.
9346 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9347 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9348 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9349 avoids a gcc -Wuninitialized diagnostic.
9350 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9351 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9352 does not deduce are never used uninitialized.
9354 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9356 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9357 * window.c (window_loop, size_window):
9358 (run_window_configuration_change_hook, enlarge_window): Likewise.
9360 * window.c (display_buffer): Now static.
9361 (size_window): Mark variables that gcc -Wuninitialized
9362 does not deduce are never used uninitialized.
9363 * window.h (check_all_windows): New decl, to forestall
9364 gcc -Wmissing-prototypes diagnostic.
9365 * dispextern.h (bidi_dump_cached_states): Likewise.
9367 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9369 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9371 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9372 and to avoid gcc -Wuninitialized warning.
9373 (load_charset_map): Mark variables that gcc -Wuninitialized
9374 does not deduce are never used uninitialized.
9375 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9377 * coding.c (coding_set_source, coding_set_destination):
9378 Use "else { /* comment */ }" rather than "else /* comment */;"
9379 for clarity, and to avoid gcc -Wempty-body warning.
9380 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9381 a block, when the outer 'i' will do.
9382 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9383 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9384 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9385 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9386 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9387 Rename locals to avoid shadowing.
9388 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9389 * coding.c (emacs_mule_char, encode_invocation_designation):
9390 Now static, since they're not used elsewhere.
9391 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9392 (decode_coding_object, encode_coding_object, detect_coding_system):
9393 (decode_coding_emacs_mule): Mark variables that gcc
9394 -Wuninitialized does not deduce are never used uninitialized.
9395 (detect_coding_iso_2022): Initialize a local variable that might
9396 be used uninitialized. Leave a FIXME because it's not clear that
9397 this initialization is needed. (Bug#8211)
9398 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9399 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9400 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9401 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9402 Remove unused macros.
9404 * category.c (hash_get_category_set): Remove unused local var.
9405 (copy_category_table): Now static, since it's not used elsewhere.
9406 * character.c (string_count_byte8): Likewise.
9408 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9409 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9411 * chartab.c (copy_sub_char_table): Now static, since it's not used
9413 (sub_char_table_ref_and_range, char_table_ref_and_range):
9414 Rename locals to avoid shadowing.
9415 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9417 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9418 (BIDI_BOB): Remove unused macro.
9420 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9421 deduce are never used uninitialized.
9422 * term.c (encode_terminal_code): Likewise.
9424 * term.c (encode_terminal_code): Now static. Remove unused local.
9426 * tparam.h: New file.
9427 * term.c, tparam.h: Include it.
9428 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9429 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9430 Move these decls to tparam.h, and make them agree with what
9431 is actually in tparam.c. The previous trick of using incompatible
9432 decls in different modules does not conform to the C standard.
9433 All callers of tparam changed to use tparam's actual API.
9434 * tparam.c (tparam1, tparam, tgoto):
9435 Use const pointers where appropriate.
9437 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9438 * cm.h (struct cm): Likewise.
9439 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9440 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9441 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9442 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9443 (turn_on_face, init_tty): Likewise.
9444 * termchar.h (struct tty_display_info): Likewise.
9446 * term.c (term_mouse_position): Rename local to avoid shadowing.
9448 * alloc.c (mark_ttys): Move decl from here ...
9449 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9451 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9453 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9455 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9457 * search.c (compile_pattern_1): Remove argument regp, unused since
9458 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9459 (compile_pattern): Don't pass it.
9461 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9463 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9464 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9466 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9468 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9470 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9471 gdk_window_get_screen, gdk_window_get_geometry,
9472 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9473 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9474 (xg_get_pixbuf_from_pixmap): New function.
9475 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9476 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9477 Call xg_get_pixbuf_from_pixmap instead of
9478 gdk_pixbuf_get_from_drawable.
9479 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9480 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9481 (xg_check_special_colors): Use GtkStyleContext and its functions
9483 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9484 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9485 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9486 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9487 Call gtk_widget_get_preferred_size.
9488 (xg_frame_resized): gdk_window_get_geometry only takes 5
9490 (xg_win_to_widget, xg_event_is_for_menubar):
9491 Call gdk_x11_window_lookup_for_display.
9492 (xg_set_widget_bg): New function.
9493 (delete_cb): New function.
9494 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9495 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9496 (xg_set_background_color): Call xg_set_widget_bg.
9497 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9498 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9499 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9500 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9502 (update_frame_tool_bar): Call gtk_widget_hide.
9503 (xg_initialize): Use GDK_KEY_g.
9505 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9507 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9509 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9510 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9511 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9513 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9515 * w32xfns.c (select_palette): Check success of RealizePalette against
9516 GDI_ERROR, not zero.
9518 See ChangeLog.11 for earlier changes.
9524 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9526 This file is part of GNU Emacs.
9528 GNU Emacs is free software: you can redistribute it and/or modify
9529 it under the terms of the GNU General Public License as published by
9530 the Free Software Foundation, either version 3 of the License, or
9531 (at your option) any later version.
9533 GNU Emacs is distributed in the hope that it will be useful,
9534 but WITHOUT ANY WARRANTY; without even the implied warranty of
9535 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9536 GNU General Public License for more details.
9538 You should have received a copy of the GNU General Public License
9539 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.