1 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3 * xfns.c (unwind_create_frame):
4 * nsfns.m (unwind_create_frame):
5 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6 Vframe_list (Bug#9999).
8 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
12 2011-11-11 Kenichi Handa <handa@m17n.org>
14 * callproc.c (Fcall_process): Set the member dst_multibyte of
17 2011-11-11 Johan Bockgård <bojohan@gnu.org>
19 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
20 avoid a crash (bug#9496).
22 2011-11-09 Chong Yidong <cyd@gnu.org>
24 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
25 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
27 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
29 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
31 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
33 Avoid some portability problems by eschewing 'extern inline' functions.
34 The trivial performance wins aren't worth the portability hassles; see
35 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
37 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
38 (window_box_width, window_box_left, window_box_left_offset)
39 (window_box_right, window_box_right_offset): Undo previous change,
40 by removing the "extern"s.
41 * intervals.c (adjust_intervals_for_insertion)
42 (adjust_intervals_for_deletion): Undo previous change,
43 making these static again.
44 (offset_intervals, temp_set_point_both, temp_set_point)
45 (copy_intervals_to_string): No longer inline.
46 * xdisp.c (window_text_bottom_y, window_box_width)
47 (window_box_height, window_box_left_offset)
48 (window_box_right_offset, window_box_left, window_box_right)
49 (window_box): No longer inline.
51 2011-11-08 Chong Yidong <cyd@gnu.org>
53 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
54 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
55 an error if not a live window.
56 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
57 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
59 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
61 * lisp.h (syms_of_abbrev): Remove declaration.
62 Reported by CHENG Gao <chenggao@royau.me>.
64 2011-11-07 Eli Zaretskii <eliz@gnu.org>
66 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
67 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
68 of temacs in GUI mode.
70 2011-11-07 Martin Rudalics <rudalics@gmx.at>
72 * window.h: Declare delete_all_child_windows instead of
73 delete_all_subwindows.
74 * window.c (Fwindow_nest, Fset_window_nest)
75 (Fset_window_new_total, Fset_window_new_normal)
76 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
77 (delete_all_subwindows): Rename to delete_all_child_windows.
78 (Fdelete_other_windows_internal, Fset_window_configuration):
79 Call delete_all_child_windows instead of delete_all_subwindows.
80 * frame.c (delete_frame): Call delete_all_child_windows instead
81 of delete_all_subwindows.
83 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
85 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
86 This is also needed for porting to any host where GC_MARK_STACK is
87 not GC_MAKE_GCPROS_NOOPS.
88 (which_symbols): Use it.
90 2011-11-07 Kenichi Handa <handa@m17n.org>
92 * coding.c (coding_set_destination): Check coding->src_pos only
93 when coding->src_object is a buffer (bug#9910).
95 * process.c (send_process): Set the member src_multibyte of coding
96 to 0 (bug#9911) when sending a unibyte text.
98 * callproc.c (Fcall_process): Set the member src_multibyte of
99 process_coding to 0 (bug#9912).
101 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
103 * xmenu.c (cleanup_widget_value_tree): New function.
104 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
105 calling free_menubar_widget_value_tree directly (Bug#9830).
107 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
109 Fix some portability problems with 'inline'.
110 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
111 (window_box_width, window_box_left, window_box_left_offset)
112 (window_box_right, window_box_right_offset): Declare extern.
113 Otherwise, these inline functions do not conform to C99 and
114 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
115 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
116 * intervals.c (adjust_intervals_for_insertion)
117 (adjust_intervals_for_deletion): Now extern, because otherwise the
118 extern inline functions 'offset_intervals' couldn't refer to it.
119 (static_offset_intervals): Remove.
120 (offset_intervals): Rewrite using the old contents of
121 static_offset_intervals. The old version didn't conform to C99
122 because an extern inline function contained a reference to an
123 identifier with static linkage.
125 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
127 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
130 2011-11-06 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (init_iterator, reseat_to_string): Don't set the
133 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
134 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
135 return Qleft_to_right.
137 2011-11-06 Chong Yidong <cyd@gnu.org>
139 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
140 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
141 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
142 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
143 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
144 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
145 (Fwindow_vscroll): Doc fix.
146 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
147 argument, since it makes no sense to pass a live window and for
148 consistency with window-child.
150 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
152 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
155 2011-11-05 Jason Rumney <jasonr@gnu.org>
157 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
158 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
160 (add_font_entity_to_list): Fix logic errors in mixed boolean and
161 bitwise arithmetic preventing use of unicode-sip and non-truetype
164 2011-11-05 Eli Zaretskii <eliz@gnu.org>
166 * s/ms-w32.h (fstat, stat, utime): Move redirections to
169 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
170 initialization code to keep similarity to xfns.c after changes
173 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
175 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
176 (unwind_create_frame): New function (Bug#9943).
177 (Fx_create_frame): Restructure code to be more similar to the one in
178 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
179 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
180 Move terminal->reference_count++ just before making the frame official
183 * nsterm.m (x_free_frame_resources): New function.
184 (x_destroy_window): Move code to x_free_frame_resources.
186 * xfns.c (unwind_create_frame): Fix comment.
187 (Fx_create_frame, x_create_tip_frame): Move
188 terminal->reference_count++ just before making the frame
189 official. Move initialization of image_cache_refcount and
190 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
192 2011-11-05 Eli Zaretskii <eliz@gnu.org>
194 Support MSVC build with newer versions of Visual Studio.
195 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
196 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
199 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
200 which are not supported by MSVC.
201 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
202 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
204 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
206 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
208 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
210 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
212 Support MSVC build with newer versions of Visual Studio.
213 * w32.c: Don't include w32api.h for MSVC.
214 (init_environment) [_MSC_VER]: Call sys_access, not _access.
216 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
217 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
218 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
219 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
221 (alloca) [_MSC_VER]: Define to _alloca.
223 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
225 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
227 2011-11-04 Eli Zaretskii <eliz@gnu.org>
229 * xdisp.c (note_mouse_highlight): If either of
230 previous/next-single-property-change returns nil, treat that as
231 the beginning or the end of the buffer. (Bug#9955)
233 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
235 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
236 label is not null (Bug#9951).
237 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
240 2011-11-04 Eli Zaretskii <eliz@gnu.org>
242 * window.c (Fwindow_body_size): Mention in the doc string that the
243 return value is in frame's canonical units. (Bug#9949)
245 2011-11-03 Eli Zaretskii <eliz@gnu.org>
247 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
249 * w32fns.c (unwind_create_frame): If needed, free the glyph
250 matrices of the partially constructed frame. (Bug#9943)
251 * xfns.c (unwind_create_frame): Likewise.
253 2011-11-01 Eli Zaretskii <eliz@gnu.org>
255 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
256 Don't stop backward scan on the continuation glyph, even though
257 its CHARPOS is positive.
258 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
259 cover_string to disp_string.
261 2011-11-01 Martin Rudalics <rudalics@gmx.at>
263 * window.c (temp_output_buffer_show): Don't use
264 Vtemp_buffer_show_specifiers.
265 (Vtemp_buffer_show_specifiers): Remove unused variable.
267 2011-10-30 Eli Zaretskii <eliz@gnu.org>
269 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
270 past the beginning of the current glyph matrix.
272 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
274 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
275 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
276 HAVE_GTK3 (Bug#9869).
278 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
279 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
281 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
283 * xterm.c: Declare x_handle_net_wm_state to return int.
284 (handle_one_xevent): Check if we are iconified but don't have
285 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
286 (get_current_wm_state): Return non-zero if not hidden,
287 check for _NET_WM_STATE_HIDDEN (Bug#9893).
288 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
289 (x_handle_net_wm_state): Return what get_current_wm_state returns.
290 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
292 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
294 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
295 so that this new function doesn't get optimized away by a
296 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
298 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
300 * frame.h (MOUSE_HL_INFO): Remove excess parens.
302 2011-10-29 Eli Zaretskii <eliz@gnu.org>
304 Fix the `xbytecode' command.
305 * .gdbinit (xprintbytestr): New command.
306 (xwhichsymbols): Renamed from `which'; all callers changed.
307 (xbytecode): Print the byte-code string as well.
309 2011-10-29 Kim Storm <storm@cua.dk>
311 * alloc.c (which_symbols): New function.
313 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
315 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
318 2011-10-29 Glenn Morris <rgm@gnu.org>
320 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
321 Not clear what it was for, and it causes various bugs. (Bug#9839)
323 2011-10-28 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
326 possible random value that matches one of those tested as
327 condition to clear the mouse face.
329 2011-10-28 Chong Yidong <cyd@gnu.org>
331 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
333 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
335 * window.c (make_window): Initialize phys_cursor_on_p.
337 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
339 * lisp.h (struct Lisp_Symbol): Update comments.
341 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
343 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
345 2011-10-28 Eli Zaretskii <eliz@gnu.org>
347 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
348 <oslsachem@gmail.com> for helping to debug this.
350 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
351 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
352 (g_b_init_get_glyph_outline_w): New static variables.
353 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
354 (GetGlyphOutlineW_Proc): New typedefs.
355 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
356 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
358 (w32font_open_internal, compute_metrics):
359 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
360 instead of calling the "wide" APIs directly.
362 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
364 * w32.h (syms_of_w32font): Add prototype.
366 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
368 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
369 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
370 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
371 (Fmove_to_window_line): Doc fix.
373 2011-10-27 Chong Yidong <cyd@gnu.org>
375 * process.c (make_process): Set gnutls_state to NULL.
377 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
378 non-NULL, regardless of GNUTLS_INITSTAGE.
379 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
380 an error. Set process slots as soon as we allocate them.
382 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
384 2011-10-27 Chong Yidong <cyd@gnu.org>
386 * gnutls.c (emacs_gnutls_deinit): New function.
387 Deallocate credentials structures as well as calling gnutls_deinit.
388 (Fgnutls_deinit, Fgnutls_boot): Use it.
390 * process.c (make_process): Initialize GnuTLS credentials to NULL.
391 (deactivate_process): Call emacs_gnutls_deinit.
393 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
395 * image.c (x_create_x_image_and_pixmap):
396 * w32.c (sys_rename, w32_delayed_load):
397 * w32font.c (fill_in_logfont):
398 * w32reg.c (x_get_string_resource): Silence compiler warnings.
400 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
402 * w32fns.c (w32_default_color_map): New function,
403 extracted from Fw32_default_color_map.
404 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
406 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
408 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
410 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
412 * keyboard.c (test_undefined): New function (bug#9751).
413 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
415 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
417 * sysdep.c (init_sys_modes): Fix the check for the controlling
420 2011-10-20 Eli Zaretskii <eliz@gnu.org>
422 * dispextern.h (struct bidi_it): New member next_en_type.
424 * bidi.c (bidi_line_init): Initialize the next_en_type member.
425 (bidi_resolve_explicit_1): When next_en_pos is valid for the
426 current character, check also for next_en_type being WEAK_EN.
427 (bidi_resolve_weak): Don't enter the expensive loop if the current
428 position is before next_en_pos. Record the bidi type of the first
429 non-ET, non-BN character we find, in addition to its position.
430 (bidi_level_of_next_char): Invalidate next_en_type when
431 next_en_pos is over-stepped.
433 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
435 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
436 * editfns.c: Rewrite current-time-zone so that it invokes
437 the equivalent of (format-time-string "%Z") to get the time zone name.
438 This fixes a bug when the time zone name contains characters that
439 need converting from the system time locale to Emacs internal format.
440 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
441 that patch fixed format-time-string to do the conversion, but
442 I forgot to fix current-time-zone.
443 (format_time_string): New function, containing most of
444 what Fformat_time_string used to contain.
445 (Fformat_time_string): Rewrite in terms of format_time_string.
446 This doesn't change this function's behavior.
447 (current-time-zone): Rewrite to use format_time_string.
448 This fixes the bug reported by Michael Schierl in
449 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
450 Jason Rumney's 2007-06-07 change worked around this bug, but
452 * systime.h (tzname, timezone): Remove no-longer-used declarations.
454 2011-10-19 Eli Zaretskii <eliz@gnu.org>
456 * xdisp.c (start_display): If the character at POS is displayed
457 via a display vector, reset IT->current.dpvec_index to zero.
458 (try_window_reusing_current_matrix): If a line ends in a display
459 vector or the next line starts in a display vector, continue
460 redrawing the window even though the character position of
461 start_row was reached.
464 2011-10-18 Chong Yidong <cyd@gnu.org>
466 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
467 with nobreak-char-display too.
469 2011-10-18 Eli Zaretskii <eliz@gnu.org>
471 Fix part 3 of bug#9771.
472 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
473 (bidi_resolve_neutral): Don't enter the expensive loop looking for
474 non-neutral characters if the current character is a paragraph
475 separator (a.k.a. Newline). This avoids running the same
476 expensive loop twice, once when we consume the preceding newline
477 and the other time when the line actually needs to be displayed.
478 Avoid the loop when we see neutrals on the base embedding level
479 following a character whose directionality is the same as the
480 paragraph's. This avoids running the expensive loop when a line
481 ends in a long sequence of neutrals, like control characters.
482 Add assertion against STRONG_AL type. Slightly rearrange code
483 that determines the type of a neutral given the first non-neutral
485 (bidi_level_of_next_char): Set next_en_pos to zero when
486 invalidating its info.
488 2011-10-17 Eli Zaretskii <eliz@gnu.org>
490 * xdisp.c (push_display_prop): Determine whether to record string
491 or buffer position by IT->string, not by IT->method. Allow
492 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
493 (move_it_vertically_backward): Don't look for character position
494 immediately after the newline when in a continuation line.
497 2011-10-15 Martin Rudalics <rudalics@gmx.at>
499 * window.c (coordinates_in_window): Rewrite and delabelize
500 vertical border check. (Bug#5357) (Bug#9618)
502 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
504 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
505 errors in XSetWindowBorder (bug#9310).
507 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
509 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
510 avoid crash when xmalloc overrun checking is enabled.
512 2011-10-13 Eli Zaretskii <eliz@gnu.org>
514 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
515 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
516 cursor motion with <left> and <right> arrow keys.
518 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
519 some callers set that themselves.
521 2011-10-12 Eli Zaretskii <eliz@gnu.org>
523 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
524 display string and the previous row comes from the same string and
525 is empty. (Bug#9739) (Bug#9738)
527 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
529 * doc.c (get_doc_string): Encode file name (bug#9735).
531 2011-10-12 Eli Zaretskii <eliz@gnu.org>
533 * bidi.c (bidi_level_of_next_char):
534 * xdisp.c (get_visually_first_element): Remove old incorrect
535 comments regarding the Unicode Line Separator character.
537 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
539 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
541 * alloc.c (Fgc_status): Do not access beyond zombies array
542 boundary if nzombies > MAX_ZOMBIES.
543 * alloc.c (dump_zombies): Add missing format specifier.
545 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
547 * xdisp.c (set_cursor_from_row): Simplify conditionals,
548 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
550 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
551 Some packages use them to denote characters with modifiers.
553 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
555 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
556 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
557 matching a pp-number. Rename parameter var to var1.
559 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
561 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
563 2011-10-08 Glenn Morris <rgm@gnu.org>
565 * callint.c (Fcall_interactively): Give a more explicit error for the
566 'c' case with a non-character input. (Bug#8479)
568 2011-10-08 Eli Zaretskii <eliz@gnu.org>
570 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
572 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
573 lines that are hscrolled on the left.
575 * dispnew.c (buffer_posn_from_coords): Account for a possible
576 presence of header-line. (Bug#4426)
578 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
580 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
581 Don't advertise functionality which we discourage or doesn't work.
583 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
585 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
586 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
587 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
588 this makes Emacs dump core during garbage collection on rare
589 occasions. sizeof is obviously inferior to offsetof here, so
591 (GC_POINTER_ALIGNMENT): New macro.
592 (mark_memory): Omit 3rd (offset) arg; caller changed.
593 Don't assume EMACS_INT alignment is the same as pointer alignment.
595 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
597 * keyboard.c (read_key_sequence_remapped): New var.
598 (read_key_sequence): Compute remapping in the right buffer.
599 (command_loop_1): Use read_key_sequence's remapping directly.
601 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
603 * dired.c (file_name_completion): Don't expand file name.
604 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
605 before checking file name handler.
607 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
608 they've been requested explicitly (bug#9591).
610 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
612 * keymap.c (Fsingle_key_description): Use make_specified_string
613 instead of build_string to build string from push_key_description.
616 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
618 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
619 This fixes a Y2038 bug on 64-bit hosts.
620 * buffer.c (reset_buffer):
621 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
622 (Fclear_buffer_auto_save_failure):
623 Use 0, not -1, to represent an unset failure time, since time_t
626 Remove dependency on glibc malloc internals.
627 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
628 Move back here from lisp.h, but with their new implementations.
629 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
630 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
631 * charset.c (charset_table_init): New static var.
632 (syms_of_charset): Use it instead of xmalloc. This removes a
633 dependency on glibc malloc internals. See Eli Zaretskii's comment in
634 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
635 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
636 Move back to alloc.c.
637 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
638 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
640 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
642 * nsterm.m (windowDidResize): Call x_set_window_size only when
643 ns_in_resize is true. Otherwise set pixelwidth/height and
644 call change_frame_size (Bug#9628).
646 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
648 Port --enable-checking=all to Fedora 14 x86-64.
649 * charset.c (syms_of_charset): Also account for glibc malloc's
650 internal overhead when calculating the initial malloc maximum.
652 Port --enable-checking=all to Fedora 14 x86.
653 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
655 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
656 (overrun_check_realloc, overrun_check_free):
657 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
658 That way, xmalloc returns a properly-aligned pointer even if
659 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
660 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
661 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
662 into account when calculating the initial malloc maximum.
663 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
664 Move here from alloc.c, so that charset.c can use it too.
665 Properly align; the old code wasn't right for common 32-bit hosts
666 when configured with --enable-checking=all.
667 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
668 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
670 2011-09-29 Eli Zaretskii <eliz@gnu.org>
672 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
675 2011-09-28 Eli Zaretskii <eliz@gnu.org>
677 * xdisp.c (compute_display_string_end): If there's no display
678 string at CHARPOS, return -1.
680 * bidi.c (bidi_fetch_char): When compute_display_string_end
681 returns a negative value, treat the character as a normal
682 character not covered by a display string. (Bug#9624)
684 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
686 * lread.c (Fread_from_string): Fix typo in docstring.
688 2011-09-27 Eli Zaretskii <eliz@gnu.org>
690 * xdisp.c (handle_invisible_prop): If invisible text ends on a
691 newline, reseat the iterator instead of bidi-iterating there one
692 character at a time. (Bug#9610)
693 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
694 TO_CHARPOS if the bidi iterator is at base embedding level.
696 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
698 * lread.c (readevalloop): Use correct code for NBSP.
699 (read1): Likewise. (Bug#9608)
701 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
703 * dbusbind.c (Fdbus_register_signal): When service is not
704 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
706 2011-09-25 Glenn Morris <rgm@gnu.org>
708 * buffer.c (truncate-lines): Doc fix.
710 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
712 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
713 (Fset_window_next_buffers): Doc fix.
715 2011-09-24 Glenn Morris <rgm@gnu.org>
717 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
719 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
721 Fix minor problems found by static checking.
722 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
723 * indent.c (Fvertical_motion): Fix == vs = typo.
725 2011-09-24 Eli Zaretskii <eliz@gnu.org>
727 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
728 Default value is now t. Doc fix.
730 * indent.c (Fvertical_motion): Compute and apply the overshoot
731 logic when moving up, not only when moving down. Fix the
732 confusing name and values of the it_overshoot_expected variable;
733 logic changes accordingly. (Bug#9254) (Bug#9549)
735 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
736 CHARPOS is covered by a display string which includes newlines.
737 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
738 is covered by a display string with embedded newlines.
740 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
742 * dbusbind.c (Fdbus_register_signal): Add match rule to
743 Vdbus_registered_objects_table. (Bug#9581)
744 (Fdbus_register_method, Vdbus_registered_objects_table):
747 2011-09-24 Jim Meyering <meyering@redhat.com>
749 do not ignore write error for any output size
750 The previous change was incomplete.
751 While it makes emacs --batch detect the vast majority of stdout
752 write failures, errors were still ignored whenever the output size is
753 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
754 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
755 && echo FAIL: ignored write error
756 FAIL: ignored write error
757 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
758 && echo FAIL: ignored write error
759 FAIL: ignored write error
760 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
762 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
764 * emacs.c (Fkill_emacs): In noninteractive mode exit
765 non-successfully if a write error occurred on stdout. (Bug#9574)
767 2011-09-21 Eli Zaretskii <eliz@gnu.org>
769 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
772 * dispextern.h (struct it): Update the comment documenting what
775 2011-09-20 Eli Zaretskii <eliz@gnu.org>
777 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
778 a display string, extend search for cursor position to end of row.
779 (find_row_edges): If the row ends in a newline from a display
780 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
781 Handle the case of a display string with multiple newlines.
782 (Fcurrent_bidi_paragraph_direction): Fix search for previous
783 non-empty line. Fixes confusing cursor motion with arrow keys at
784 the beginning of a line that starts with whitespace.
786 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
788 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
791 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
793 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
796 2011-09-18 Eli Zaretskii <eliz@gnu.org>
798 * xdisp.c (display_line): Record maximum and minimum buffer
799 positions even if no glyphs were produced (e.g., by a zero-width
800 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
801 buffer positions that will be removed from the glyph row because
803 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
804 column is beyond frame width: don't subtract 1 "pixel" when
805 computing width of the stretch.
806 (reseat_at_next_visible_line_start): Undo the change made on
807 2011-09-17 that saved paragraph information and restored it after
808 the call to `reseat'. (Bug#9545)
810 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
812 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
813 and turn window cursor on if cleared (Bug#9415).
815 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
817 * search.c (boyer_moore): Take unibyte characters from pattern
818 literally. (Bug#9458)
820 2011-09-18 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
824 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
826 Fix minor problem found by static checking.
827 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
828 initialized, to pacify gcc -Wuninitialized.
830 * fileio.c: Report proper errno when syscall falls.
831 (Finsert_file_contents): Save and restore errno,
832 so that report_file_error outputs the correct diagnostic.
833 (Fwrite_region) [CLASH_DETECTION]: Likewise.
835 2011-09-18 Eli Zaretskii <eliz@gnu.org>
837 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
839 2011-09-17 Eli Zaretskii <eliz@gnu.org>
841 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
842 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
844 2011-09-17 Eli Zaretskii <eliz@gnu.org>
846 * xdisp.c (reseat_at_next_visible_line_start): Keep information
847 about the current paragraph and restore it after the call to reseat.
849 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
850 (bidi_find_paragraph_start): Search back for paragraph beginning
851 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
852 (bidi_move_to_visually_next): Only trigger paragraph-related
853 computations when the last character is a newline or at EOB, not
854 just any NEUTRAL_B. (Bug#9470)
856 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
857 truncated lines if point is covered by a display string. (Bug#9524)
859 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
861 * xselect.c: Relax test for outgoing X longs (Bug#9498).
862 (cons_to_x_long): New function.
863 (lisp_data_to_selection_data): Use it. Correct the test for
864 short-versus-long data; it was negated. Break out of vector
865 loop, for efficiency, when a long datum is discovered.
867 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
869 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
871 2011-09-16 Eli Zaretskii <eliz@gnu.org>
873 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
874 GCC PR/17406) by declaring this function with external scope.
876 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
878 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
879 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
881 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
883 * editfns.c (Fformat): Correctly handle text properties on "%%".
885 2011-09-15 Eli Zaretskii <eliz@gnu.org>
887 * xterm.c (x_draw_composite_glyph_string_foreground):
888 * w32term.c (x_draw_composite_glyph_string_foreground):
889 * term.c (encode_terminal_code):
890 * composite.c (composition_update_it, get_composition_id):
891 * xdisp.c (get_next_display_element)
892 (fill_composite_glyph_string): Add comments about special meaning
893 of TAB characters in a composition.
895 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
897 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
898 This occurs when processing a multibyte format.
899 Problem reported by Wolfgang Jenker.
901 2011-09-15 Johan Bockgård <bojohan@gnu.org>
903 * xdisp.c (try_cursor_movement): Only check for exact match if
904 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
906 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
908 Remove unused external symbols.
909 * dispextern.h (calc_pixel_width_or_height): Remove decl.
910 * xdisp.c (calc_pixel_width_or_height): Now static.
911 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
912 * indent.c (check_display_width):
913 * w32term.c: Fix comment to match code.
914 * xterm.c, xterm.h (x_catching_errors): Remove.
916 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
918 * xselect.c: Use signed conversions more consistently (Bug#9498).
919 (selection_data_to_lisp_data): Assume incoming selection data are
920 signed integers, not unsigned. This is to be consistent with
921 outgoing selection data, which was modified to use signed integers
922 in as part of the fix to Bug#9196 in response to Jan D.'s comment
923 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
924 expects long, not unsigned long.
926 2011-09-14 Eli Zaretskii <eliz@gnu.org>
928 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
929 computation of loop end. Reported by Johan Bockgård
932 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
934 * frame.c (Fother_visible_frames_p): Function deleted.
936 2011-09-12 Eli Zaretskii <eliz@gnu.org>
938 * indent.c (compute_motion): Process display vector front to back
939 rather than the other way around. (Bug#2496)
941 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
943 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
945 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
947 * minibuf.c (Fread_from_minibuffer): Doc fix.
949 2011-09-11 Eli Zaretskii <eliz@gnu.org>
951 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
952 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
954 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
956 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
957 value for non-existent files.
959 2011-09-11 Eli Zaretskii <eliz@gnu.org>
961 * fileio.c (Finsert_file_contents): If the file cannot be opened,
962 set its "size" to -1. This will set the modtime_size field of
963 the corresponding buffer to -1, which is what
964 verify-visited-file-modtime expects for files that do not exist.
967 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
969 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
971 * lisp.h: ... from here. push_key_description is no longer
972 defined in keyboard.c, so its declaration should not be in
973 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
974 logically belongs with push_key_description.
976 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
978 * buffer.h: Include <sys/types.h> instead of <time.h>.
979 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
980 Problem reported by Herbert J. Skuhra.
982 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
984 * xml.c (parse_region): Make the parsing work for
985 non-comment-starting XML files again (bug#9144).
987 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
989 * image.c (gif_load): Fix calculation of bottom and right corner.
992 2011-09-10 Eli Zaretskii <eliz@gnu.org>
994 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
995 redisplay in small windows.
997 2011-09-09 Eli Zaretskii <eliz@gnu.org>
999 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1001 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1003 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1004 Operate on live windows only.
1006 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1008 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1010 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1012 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1013 only under bidi iteration.
1015 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1017 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1019 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1021 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1022 Without this fix, the command to link temacs failed due to an
1023 undefined symbol __builtin_isnan. This is because
1024 /usr/include/iso/math_c99.h #defines isnan(x) to
1025 __builtin_isnan(x), but the bundled gcc, which identifies itself
1026 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1028 * floatfns.c (isnan): #undef, and then #define to a clone of
1030 (Fisnan): Always define, since it's always available now.
1031 (syms_of_floatfns): Always define isnan at the Lisp level.
1033 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1035 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1037 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1039 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1040 The previous code assumed that file offsets (off_t values) fit in
1041 EMACS_INT variables, which is not true on typical 32-bit hosts.
1042 The code messed up by falsely reporting buffer overflow in cases
1043 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1044 when "big" contains more than 2**29 bytes, even though this
1045 inserts just one byte and does not overflow the buffer.
1046 (Finsert_file_contents): Store file offsets as off_t
1047 values, not as EMACS_INT values. Check for overflow when
1048 converting between EMACS_INT and off_t. When checking for
1049 buffer overflow or for overlap, take the offsets into account.
1050 Don't use EMACS_INT for small values where int suffices.
1051 When checking for overlap, fix a typo: ZV was used where
1052 ZV_BYTE was intended.
1053 (Fwrite_region): Don't assume off_t fits into 'long'.
1054 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1056 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1058 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1060 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1062 sprintf-related integer and memory overflow issues (Bug#9412).
1064 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1065 (esprintf, exprintf, evxprintf): New functions.
1066 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1067 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1068 (modify_event_symbol): Do not assume that the length of
1069 name_alist_or_stem is safe to alloca and fits in int.
1070 (Fexecute_extended_command): Likewise for function name and binding.
1071 (Frecursion_depth): Wrap around reliably on integer overflow.
1072 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1073 since some callers pass EMACS_INT values.
1074 (Fsingle_key_description): Don't crash if symbol name contains more
1075 than MAX_ALLOCA bytes.
1076 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1077 (get_minibuffer): Arg is now EMACS_INT, not int.
1078 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1079 (esprintf, exprintf, evxprintf): New decls.
1080 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1082 * dbusbind.c (signature_cat): New function.
1083 (xd_signature, Fdbus_register_signal):
1084 Do not overrun buffer; instead, report string overflow.
1086 * dispnew.c (add_window_display_history): Don't overrun buffer.
1087 Truncate instead; this is OK since it's just a log.
1089 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1090 even if the time zone offset is outlandishly large.
1091 Don't mishandle offset == INT_MIN.
1093 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1094 when creating daemon; the previous buffer-overflow check was incorrect.
1096 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1097 which has the guts of the old verror function.
1099 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1100 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1102 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1103 (font_unparse_xlfd): Don't blindly alloca long strings.
1104 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1105 fits in int, when using sprintf. Use single snprintf to count
1106 length of string rather than counting it via multiple sprintfs;
1107 that's simpler and more reliable.
1108 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1109 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1110 sprintf, in case result does not fit in int.
1112 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1113 (fontset_from_font): Print it.
1115 * frame.c (tty_frame_count): Now printmax_t, not int.
1116 (make_terminal_frame, set_term_frame_name): Print it.
1117 (x_report_frame_params): In X, window IDs are unsigned long,
1118 not signed long, so print them as unsigned.
1119 (validate_x_resource_name): Check for implausibly long names,
1120 and don't assume name length fits in 'int'.
1121 (x_get_resource_string): Don't blindly alloca invocation name;
1122 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1125 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1126 (xg_check_special_colors, xg_set_geometry):
1127 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1129 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1130 Use esprintf, not sprintf, in case result does not fit in int.
1132 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1133 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1134 it as a large positive number.
1135 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1136 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1138 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1139 in case result does not fit in int.
1141 * print.c (float_to_string): Detect width overflow more reliably.
1142 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1143 buffer overrun. Don't assume list length fits in 'int'. Treat
1144 print length of 0 as 0, not as infinity; to be consistent with other
1145 uses of print length in this function. Don't overflow print length
1146 index. Don't assume hash table size fits in 'long', or that
1147 vectorlike size fits in 'unsigned long'.
1149 * process.c (make_process): Use printmax_t, not int, to format
1150 process-name gensyms.
1152 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1154 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1155 to avoid potential buffer overrun.
1157 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1158 if X resource line is longer than 512 bytes.
1160 * xfns.c (x_window): Make sprintf buffer a bit bigger
1161 to avoid potential buffer overrun.
1163 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1165 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1167 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1169 Integer overflow fixes for scrolling, etc.
1170 Without these, Emacs silently mishandles large integers sometimes.
1171 For example, "C-u 4294967297 M-x recenter" was treated as if
1172 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1174 * xdisp.c (try_window_id): Check Emacs fixnum range before
1175 converting to 'int'.
1177 * window.c (window_scroll_line_based, Frecenter):
1178 Check that an Emacs fixnum is in range before assigning it to 'int'.
1179 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1180 values converted from Emacs fixnums.
1181 (Frecenter): Don't wrap around a line count if it is out of 'int'
1182 range; instead, treat it as an extreme value.
1183 (Fset_window_configuration, compare_window_configurations):
1184 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1186 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1187 that can exceed INT_MAX. Check that EMACS_INT value is in range
1188 before assigning it to the (possibly-narrower) index.
1189 (match_limit): Don't assume that a fixnum can fit in 'int'.
1191 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1194 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1195 (Fvertical_motion): Don't wrap around LINES values that don't fit
1196 in 'int'. Instead, treat them as extreme values. This is good
1197 enough for windows, which can't have more than INT_MAX lines anyway.
1199 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1201 * Require libxml/parser.h to avoid compilation warning.
1203 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1205 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1206 since this reportedly can destroy thread storage.
1208 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1210 * syntax.c (find_defun_start): Update all cache variables if
1211 exiting early (Bug#9401).
1213 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1215 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1217 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1218 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1219 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1221 * term.c (tty_append_glyph): New function.
1222 (produce_stretch_glyph): Static function and its prototype deleted.
1224 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1227 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1229 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1230 when checking :margin (Bug#9390).
1231 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1232 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1233 so that the name doesn't mislead. All uses changed.
1235 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1237 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1240 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1242 * xdisp.c (move_it_to): Don't bail out early when reaching
1243 position beyond to_charpos, if we are scanning backwards.
1244 (move_it_vertically_backward): When DY == 0, make sure we get to
1245 the first character in the line after the newline.
1247 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1249 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1250 (ccl_driver): Do not generate an out-of-range pointer.
1251 (Fccl_execute_on_string): Remove unnecessary check for
1252 integer overflow, noted by Stefan Monnier in
1253 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1254 Remove a FIXME that didn't need fixing.
1255 Simplify the newly-introduced buffer reallocation code.
1257 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1259 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1261 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1263 Integer and memory overflow issues (Bug#9196).
1265 * doc.c (get_doc_string): Rework so that
1266 get_doc_string_buffer_size is the actual buffer size, rather than
1267 being 1 less than the actual buffer size; this makes xpalloc more
1270 * image.c (x_allocate_bitmap_record, cache_image):
1271 * xselect.c (Fx_register_dnd_atom):
1272 Simplify previous changes by using xpalloc.
1274 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1275 since either will do and ptrdiff_t is convenient with xpalloc.
1277 * charset.c (charset_table_size)
1278 (struct charset_sort_data.priority): Now ptrdiff_t.
1279 (charset_compare): Don't overflow if priorities differ greatly.
1280 (Fsort_charsets): Don't assume list length fits in int.
1281 Check for size-calculation overflow when allocating sort data.
1282 (syms_of_charset): Allocate an initial charset table that is
1283 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1285 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1287 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1288 The actual value is always <= INT_MAX, and leaving it unsigned made
1289 overflow checking harder.
1291 * dispextern.h (struct glyph_matrix.rows_allocated)
1292 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1293 with xpalloc. The values are still always <= INT_MAX.
1295 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1297 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1298 (SAFE_NALLOCA): New macro.
1300 * region-cache.c (struct boundary.pos, find_cache_boundary)
1301 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1302 (set_cache_region, invalidate_region_cache)
1303 (revalidate_region_cache, know_region_cache, region_cache_forward)
1304 (region_cache_backward, pp_cache):
1305 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1306 so that ptrdiff_t * can be passed to xpalloc.
1307 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1308 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1309 (pp_cache): Don't assume cache_len fits in int.
1310 * region-cache.h: Adjust extern decls to match.
1312 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1313 EMACS_INT, since either will do, for xpalloc.
1315 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1316 (xnmalloc, xnrealloc, xpalloc): New functions.
1318 * bidi.c (bidi_shelve_header_size): New constant.
1319 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1320 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1322 * bidi.c (bidi_cache_shrink):
1323 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1325 Don't update size of array until after memory allocation succeeds,
1326 because xmalloc/xrealloc may not return.
1327 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1328 now that we have proper integer overflow checking.
1329 (record_overlay_string, overlay_strings): Catch overflows when
1330 calculating size of overlay_str_buf.
1332 * callproc.c (Fcall_process): Check for size overflow when
1333 calculating size of args2.
1334 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1335 Normally we prefer signed values, but sticking with ptrdiff_t would
1336 require adding more-complicated checks.
1338 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1339 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1340 Redo buffer-overflow calculations to avoid integer overflow.
1341 Add a FIXME comment where memory seems to be over-allocated.
1343 * character.c (Fstring): Check for size-calculation overflow.
1345 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1346 unnecessary integer overflow. Check for size overflow.
1347 (encode_coding_object): Don't update size until xmalloc succeeds.
1349 * composite.c (get_composition_id): Check for overflow in glyph
1350 length calculations.
1352 Integer and memory overflow fixes for display code.
1353 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1354 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1355 (scrolling_window): Check for overflow in size calculations.
1356 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1357 Don't assume glyph table len fits in int.
1358 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1359 (row_table_size): Now ptrdiff_t, not int.
1360 (scrolling_window): Avoid overflow in size calculations.
1361 Don't update size until allocation succeeds.
1362 * fns.c (concat): Check for overflow in size calculations.
1363 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1364 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1365 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1367 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1368 (get_doc_string): Check for size calculation overflow.
1369 Don't update size until allocation succeeds.
1370 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1371 EMACS_INT, where ptrdiff_t will do.
1372 (Fsubstitute_command_keys): Check for string overflow.
1374 * editfns.c (set_time_zone_rule): Don't assume environment length
1376 (message_length): Now ptrdiff_t, not int.
1377 (Fmessage_box): Don't update size until allocation succeeds.
1378 Don't assume message length fits in int.
1379 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1381 * emacs.c (main): Do not reallocate argv, since there is a null at
1382 the end that can be overwritten, and this way there's no need to
1383 worry about size-calculation overflow.
1384 (sort_args): Check for size-calculation overflow.
1386 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1388 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1390 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1391 (x_set_scroll_bar_width, x_figure_window_size):
1392 Check for integer overflow.
1393 (x_set_alpha): Do not assume XINT fits in int.
1395 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1396 This is for the members text_lines, text_cols, total_lines, total_cols,
1397 where the system imposes an 'int' limit.
1399 * fringe.c (Fdefine_fringe_bitmap):
1400 Don't update size until alloc works.
1402 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1403 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1405 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1406 Check for size-calculation overflow.
1407 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1408 do, as we prefer signed integers.
1409 (id_to_widget.max_size, id_to_widget.used)
1410 (xg_store_widget_in_map, xg_remove_widget_from_map)
1411 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1412 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1413 Use and return ptrdiff_t, not int.
1414 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1415 * gtkutil.h: Change prototypes to match the above.
1417 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1418 are duplicate now that they've been promoted to lisp.h.
1419 (x_allocate_bitmap_record, x_alloc_image_color)
1420 (make_image_cache, cache_image, xpm_load):
1421 Don't update size until alloc is done.
1422 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1424 Check for size calculation overflow.
1425 (ct_colors_allocated_max): New constant.
1426 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1429 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1430 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1431 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1432 Use ptrdiff_t, not int, to count maps.
1433 (read_char_minibuf_menu_prompt): Check for overflow in size
1434 calculations. Don't update size until allocation succeeds.
1435 Redo calculations to avoid overflow.
1436 * keyboard.h: Change prototypes to match the above.
1438 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1440 (current_minor_maps): Check for size calculation overflow.
1441 * keymap.h: Change prototypes to match the above.
1443 * lread.c (read1, init_obarray): Don't update size until alloc done.
1445 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1446 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1448 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1449 Now ptrdiff_t, not int.
1450 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1451 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1453 * process.c (Fnetwork_interface_list): Check for overflow
1454 in size calculation.
1456 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1458 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1459 overflow. Don't bother calling xmalloc when xrealloc will do.
1461 * search.c (Freplace_match): Check for size calculation overflow.
1462 (Fset_match_data): Don't assume list lengths fit in 'int'.
1464 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1465 for command line length. Do not attempt to address one before the
1466 beginning of an array, as that's not portable.
1468 * term.c (max_frame_lines): Remove; unused.
1469 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1471 (encode_terminal_code, calculate_costs): Check for size
1472 calculation overflow.
1473 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1474 table lengths and related sizes. Don't update size until alloc
1475 done. Redo calculations to avoid overflow.
1476 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1478 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1479 subtracting pointers.
1480 (gobble_line): Check for overflow more carefully. Don't update size
1483 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1484 Don't update size until alloc done.
1485 Redo size calculations to avoid overflow.
1486 Check for size calculation overflow.
1487 (main) [DEBUG]: Fix typo in invoking tparam1.
1489 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1490 Use ptrdiff_t, not int, for sizes.
1491 (store_mode_line_noprop_char): Don't update size until alloc done.
1493 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1494 Use ptrdiff_t, not int, for sizes.
1495 (Finternal_make_lisp_face, cache_face):
1496 Check for size calculation overflow.
1497 (cache_face): Treat size calculation overflows as if they were
1498 memory exhaustion (the usual treatment), rather than aborting.
1500 * xfns.c (x_encode_text, x_set_name_internal)
1501 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1502 sizes, since they can exceed INT_MAX in size. Check for size
1503 calculation overflow.
1505 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1506 (xg_select): Check for size calculation overflow.
1507 Don't update size until alloc done.
1509 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1510 as sprintf is limited to int lengths.
1512 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1513 (X_LONG_MIN): New macros.
1514 Use them to make the following changes clearer.
1515 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1516 This change doesn't affect the value now, but it may help remind
1517 future maintainers not to raise the value too much later.
1518 (SELECTION_QUANTUM): Remove, replacing with ...
1519 (selection_quantum): ... new function, which avoids overflow.
1521 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1522 assumption that selection length fits in 'int'.
1523 (x_reply_selection_request, x_handle_selection_request)
1524 (x_get_window_property, receive_incremental_selection)
1525 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1526 (lisp_data_to_selection_data, clean_local_selection_data):
1527 Use ptrdiff_t, not int, to record length of selection.
1528 (x_reply_selection_request, x_get_window_property)
1529 (receive_incremental_selection, x_property_data_to_lisp):
1530 Redo calculations to avoid overflow.
1531 (x_reply_selection_request): When sending hint, ceiling it at
1532 X_LONG_MAX rather than relying on wraparound overflow to send
1534 (x_get_window_property, receive_incremental_selection)
1535 (lisp_data_to_selection_data, x_property_data_to_lisp):
1536 Check for size-calculation overflow.
1537 (x_get_window_property, receive_incremental_selection)
1538 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1539 Don't store size until memory allocation succeeds.
1540 (x_get_window_property): Plug memory leak on memory exhaustion.
1541 Don't double-block input; malloc is safe here. Don't assume 2**34
1542 - 4 fits in unsigned long. Add an xassert to check
1543 XGetWindowProperty overflow. Be more careful about overflow
1544 calculations, and distinguish size from memory overflow better.
1545 (receive_incremental_selection): When tracing, don't assume
1546 unsigned int is less than INT_MAX.
1547 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1548 harmful) conversions of unsigned short to int.
1549 (lisp_data_to_selection_data): Don't assume that integers
1550 in the range -65535 through -1 fit in an X unsigned short.
1551 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1552 result parameters unless successful. Rely on cons_to_unsigned
1553 to report problems with elements; the old code wasn't right anyway.
1554 (x_check_property_data): Check for int overflow; we cannot use
1555 a wider type due to X limits.
1556 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1558 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1560 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1561 (x_term_init): Check for size calculation overflow.
1562 (x_color_cells): Don't store size until memory allocation succeeds.
1563 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1564 Don't assume alloca size is less than MAX_ALLOCA.
1565 (x_term_init): Don't assume length fits in int (sprintf is limited
1568 Use ptrdiff_t for composition IDs.
1569 * character.c (lisp_string_width):
1570 * composite.c (composition_table_size, n_compositions)
1571 (get_composition_id, composition_gstring_from_id):
1572 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1573 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1574 * window.c (Frecenter):
1575 Use ptrdiff_t, not int, for composition IDs.
1576 * composite.c (get_composition_id): Check for integer overflow.
1577 * composite.h: Adjust prototypes to match the above changes.
1579 Use ptrdiff_t for hash table indexes.
1580 * category.c (hash_get_category_set):
1581 * ccl.c (ccl_driver):
1582 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1583 * coding.c (coding_system_charset_list, detect_coding_system):
1584 * coding.h (struct coding_system.id):
1585 * composite.c (get_composition_id, gstring_lookup_cache):
1586 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1587 * image.c (xpm_get_color_table_h):
1588 * lisp.h (hash_lookup, hash_put):
1589 * minibuf.c (Ftest_completion):
1590 Use ptrdiff_t for hash table indexes, not int (which is too
1591 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1592 32-bit --with-wide-int hosts).
1594 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1595 Add a FIXME comment about memory leaks.
1596 (syms_of_charset): Don't assume xmalloc returns.
1598 Don't assume that stated character widths fit in int.
1599 * character.c (Fchar_width, c_string_width, lisp_string_width):
1600 * character.h (CHAR_WIDTH):
1601 * indent.c (MULTIBYTE_BYTES_WIDTH):
1602 Use sanitize_char_width to avoid undefined and/or bad behavior
1603 with outlandish widths.
1604 * character.h (sanitize_tab_width): Rename from sanitize_width,
1605 now that we have two such functions. All uses changed.
1606 (sanitize_char_width): New inline function.
1608 Don't assume that tab-width fits in int.
1609 * character.h (sanitize_width): New inline function.
1610 (SANE_TAB_WIDTH): New macro.
1611 (ASCII_CHAR_WIDTH): Use it.
1612 * indent.c (sane_tab_width): Remove. All uses replaced by
1613 SANE_TAB_WIDTH (current_buffer).
1614 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1616 * fileio.c: Integer overflow issues with file modes.
1617 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1619 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1620 Remove unreachable code.
1621 (read_hex, load_charset_map_from_file): Check for integer overflow.
1623 * xterm.c: don't go over XClientMessageEvent limit
1624 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1625 (x_send_scroll_bar_event): Likewise. Check that the size does not
1626 exceed limits imposed by XClientMessageEvent, as well as the usual
1627 ptrdiff_t and size_t limits.
1629 * keyboard.c: Overflow, signedness and related fixes.
1630 (make_lispy_movement): Use same integer type in forward decl
1631 that is used in the definition.
1632 (read_key_sequence, keyremap_step):
1633 Change bufsize argument back to int, undoing my 2011-03-30 change.
1634 We prefer signed types, and int is wide enough here.
1635 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1636 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1637 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1638 length, not size_t. Use ptrdiff_t for index, not int.
1639 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1640 possibility of integer overflow.
1642 Overflow, signedness and related fixes for images.
1644 * dispextern.h (struct it.stack[0].u.image.image_id)
1645 (struct_it.image_id, struct image.id, struct image_cache.size)
1646 (struct image_cache.used, struct image_cache.ref_count):
1647 * gtkutil.c (update_frame_tool_bar):
1648 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1649 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1650 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1651 * nsmenu.m (update_frame_tool_bar):
1652 * xdisp.c (calc_pixel_width_or_height):
1653 * xfns.c (image_cache_refcount):
1654 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1655 on typical 64-bit hosts.
1657 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1658 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1659 Omit unnecessary casts to int.
1660 (parse_image_spec): Check that integers fall into 'int' range
1661 when the callers expect that.
1662 (image_ascent): Redo ascent calculation to avoid int overflow.
1663 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1664 (lookup_image): Remove unnecessary tests.
1665 (xbm_image_p): Locals are now of int, not EMACS_INT,
1666 since parse_image_check makes sure they fit into int.
1667 (png_load, gif_load, svg_load_image):
1668 Prefer int to unsigned where either will do.
1669 (tiff_handler): New function, combining the cores of the
1670 old tiff_error_handler and tiff_warning_handler.
1671 This function is rewritten to use vsnprintf and thereby avoid
1672 stack buffer overflows. It uses only the features of vsnprintf
1673 that are common to both POSIX and native Microsoft.
1674 (tiff_error_handler, tiff_warning_handler): Use it.
1675 (tiff_load, gif_load, imagemagick_load_image):
1676 Don't assume :index value fits in 'int'.
1677 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1678 (imagemagick_load_image): Check that crop parameters fit into
1679 the integer types that MagickCropImage accepts. Don't assume
1680 Vimagemagick_render_type has a nonnegative value. Don't assume
1681 size_t fits in 'long'.
1682 (gs_load): Use printmax_t to print the widest integers possible.
1683 Check for integer overflow when computing image height and width.
1685 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1687 * xdisp.c (redisplay_window): Don't force window start if point
1688 will be invisible in the resulting window. (Bug#9324)
1690 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1692 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1693 the display spec is of the form `(space ...)'.
1694 (handle_display_spec): Return the value returned by
1695 handle_single_display_spec, not just 1 or zero.
1696 (handle_single_display_spec): If the display spec is of the form
1697 `(space ...)', and specifies display in the text area, return 2
1699 (try_cursor_movement): Check for the need to scroll more
1700 accurately, and prefer exact match for point under bidi.
1701 Don't advance `row' beyond the last row of the window.
1703 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1704 into disp_prop; all users changed.
1706 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1707 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1708 for the text covered by the display property.
1710 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1712 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1713 Change return value to nil.
1714 (Frecord_buffer): Delete unused function.
1716 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1718 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1719 buffers, return left-to-right.
1720 (set_cursor_from_row): Consider candidate row a win if its glyph
1721 represents a newline and point is on that newline. Fixes cursor
1722 positioning on the newline at EOL of R2L text within L2R
1723 paragraph, and vice versa.
1724 (try_cursor_movement): Check continued rows, in addition to
1725 continuation rows. Fixes unwarranted scroll when point enters a
1726 continued line of R2L text within an L2R paragraph, or vice versa.
1727 (cursor_row_p): Consider the case of point being equal to
1728 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1729 from the end of a short line to the beginning of a continued line
1730 of R2L text within L2R paragraph.
1731 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1732 composed characters.
1734 * bidi.c (bidi_check_type): Use xassert.
1735 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1738 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1740 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1743 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1745 * nsfont.m (ns_otf_to_script): Fix typo.
1747 2011-08-22 Kenichi Handa <handa@m17n.org>
1749 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1750 extra slot even if the purpose is char-code-property-table.
1752 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1754 * xdisp.c (redisplay_window): When computing centering_position,
1755 account for the height of the header line. (Bug#8874)
1757 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1758 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1759 candidate is selected by the mouse, and that candidate has a
1760 composed character under the mouse.
1762 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1763 coordinates reported by pos-visible-in-window-p for a composed
1764 character in column zero.
1766 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1768 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1770 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1772 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1773 consider it a hit if to_charpos is anywhere in the range of the
1774 composed buffer positions.
1776 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1778 * image.c (gif_load): Don't assume that each subimage has the same
1779 dimensions as the base image. Handle disposal method that is
1780 "undefined" by the gif spec (Bug#9335).
1782 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1784 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1785 (Fcondition_case): Document `debug' symbol in error handler.
1787 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1789 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1790 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1791 from an Org mode buffer to a Speedbar frame.
1793 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1794 a composition, take its buffer position from IT->cmp_it.charpos.
1795 Fixes cursor positioning at the beginning of a line that begins
1796 with a composed character.
1798 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1800 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1801 character bidirectional type, use STRONG_L instead. Fixes crashes
1802 in a buffer produced by `describe-categories'.
1804 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1805 members before the level stack, so they would be saved and
1806 restored when copying iterator state. Fixes incorrect reordering
1807 around TABs covered by display properties.
1809 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1811 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1813 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1815 * eval.c (internal_condition_case, internal_condition_case_1)
1816 (internal_condition_case_2, internal_condition_case_n):
1817 Remove unnecessary aborts (Bug#9081).
1819 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1821 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1822 has no `load' handler, try opening the file locally. (Bug#9311)
1824 2011-08-16 Ken Brown <kbrown@cornell.edu>
1826 * gmalloc.c: Expand comment.
1828 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1831 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1833 2011-08-16 Ken Brown <kbrown@cornell.edu>
1835 Fix memory allocation problems in Cygwin build (Bug#9273).
1837 * unexcw.c ( __malloc_initialized): Declare external variable.
1838 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1840 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1842 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1844 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1846 [CYGWIN] (special_realloc): New function.
1847 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1848 requests to realloc storage in the static heap.
1850 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1852 * bidi.c (bidi_initialize): Remove unused local.
1854 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1857 * biditype.h: Remove file.
1858 * makefile.w32-in ($(BLD)/bidi.$(O)):
1859 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1861 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1863 * chartab.c: Improve commentary for the uniprop_table API.
1865 * bidi.c (bidi_paragraph_init): Support zero value of
1866 bidi_ignore_explicit_marks_for_paragraph_level.
1867 (bidi_initialize): Use uniprop_table instead of including
1868 biditype.h and bidimirror.h.
1870 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1871 coordinates of the iterator when restoring from ppos_it.
1874 2011-08-14 Kenichi Handa <handa@m17n.org>
1876 * process.c (create_process): Call setup_process_coding_systems
1877 after the pid of the process is set to -1 (Bug#8162).
1879 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1881 * xdisp.c (move_it_in_display_line_to): Don't invoke
1882 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1883 ppos_it. Fixes vertical cursor motion when line beginning is
1884 covered by an image. (Bug#9296)
1886 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1888 * nsterm.h (ns_run_ascript): Declare.
1889 (NSAPP_DATA2_RUNASSCRIPT): Define.
1891 * nsfns.m (as_script, as_result, as_status): New static variables.
1892 (ns_run_ascript): New function.
1893 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1894 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1895 the event loop. Get status from as_status (Bug#7276).
1897 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1898 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1899 the event loop (Bug#7276).
1901 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1903 * gnutls.c (QCgnutls_bootprop_priority)
1904 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1905 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1906 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1907 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1908 (QCgnutls_bootprop_verify_hostname_error)
1909 (QCgnutls_bootprop_callbacks_verify): Rename from
1910 Qgnutls_bootprop_..., all uses changed.
1912 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1915 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1917 * xfaces.c (Qframe_set_background_mode): Now static.
1918 * dispextern.h (Qframe_set_background_mode): Remove decl.
1920 * process.c (Fnetwork_interface_info): Declare local only if needed.
1922 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1924 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1925 (Fnetwork_interface_list): Allocate in increments of bytes instead
1926 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1927 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1929 (struct ifflag_def): notrailers is smart on OSX.
1930 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1931 Get hardware address with getifaddrs if available.
1933 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1935 * xdisp.c (iterate_out_of_display_property): xassert that
1936 IT->position is set to within IT->object's boundaries. Break from
1937 the loop as soon as EOB is reached; avoids infloops in redisplay
1938 when IT->position is set up wrongly due to some bug.
1939 Set IT->current to match the bidi iterator unconditionally.
1940 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1941 entry. Force push_it to save on the stack the current
1942 buffer/string position, to be restored by pop_it. Fix flags in
1943 the iterator structure wrt the object coming from a display
1944 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1945 properties. (Bug#9284)
1947 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1949 * fontset.c (fontset_get_font_group): Add proper type checks.
1952 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1954 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1955 and LC_VERSION_MIN_MACOSX.
1956 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1957 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1959 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1961 * xdisp.c (forward_to_next_line_start): Allow to use the
1962 no-display-properties-and-no-overlays under bidi display.
1963 Set disp_pos in the bidi iterator to avoid searches for display
1964 properties and overlays.
1966 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1968 * editfns.c (Fset_time_zone_rule): Document relationship with the
1971 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1972 the font entity extracted from the cache (Bug#8109).
1974 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1976 * composite.c (autocmp_chars): Don't reset point. That is done by
1977 restore_point_unwind (Bug#5984).
1979 2011-08-07 Juri Linkov <juri@jurta.org>
1981 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1982 to show the arg `TIME' instead of `TIMEVAL'.
1984 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1986 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1987 display property strides EOL and includes a newline, as in
1988 longlines-mode. (Bug#9254)
1989 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1990 word-wrap under bidirectional display. (Bug#9224)
1992 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1993 is non-zero, even if the data buffer is NULL. Fixes a crash in
1994 vertical-motion with longlines-mode. (Bug#9254)
1996 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1998 * bidi.c <bidi_cache_total_alloc>: Now static.
1999 (bidi_initialize): Initialize bidi_cache_total_alloc.
2001 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2004 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2005 amount allocated this far in `bidi_cache_total_alloc'.
2006 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2007 non-zero, only free the data buffer without restoring the cache
2008 contents. All callers changed.
2010 * dispextern.h (bidi_unshelve_cache): Update prototype.
2012 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2013 (move_it_in_display_line, move_it_to)
2014 (move_it_vertically_backward, move_it_by_lines): Replace the call
2015 to xfree to an equivalent call to bidi_unshelve_cache.
2016 (move_it_in_display_line_to): Fix logic of returning
2017 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2019 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2021 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2022 came from a string character with a `cursor' property. (Bug#9229)
2024 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2026 * Makefile.in (LIB_PTHREAD): New variable.
2027 (LIBES): Add LIB_PTHREAD (Bug#9216).
2029 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2030 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2032 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2034 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2036 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2038 * xterm.c (x_find_topmost_parent): New function.
2039 (x_set_frame_alpha): Find topmost parent window with
2040 x_find_topmost_parent and set the property there also (bug#9181).
2041 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2043 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2045 * callproc.c (Fcall_process): Avoid vfork clobbering
2046 the local vars buffer, coding_systems, current_dir.
2048 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2050 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2052 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2054 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2055 so that it is not optimized away.
2057 * xdisp.c (compute_display_string_pos): Remove unused local.
2059 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2061 Fix slow cursor motion and scrolling in large buffers with
2062 selective display, like Org Mode buffers. (Bug#9218)
2064 * dispextern.h (struct bidi_it): New member disp_prop_p.
2066 * xdisp.c: Remove one-slot cache of display string positions.
2067 (compute_display_string_pos): Accept an additional argument
2068 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2069 for a display string or property. If found, set DISP_PROP_P
2072 * bidi.c (bidi_fetch_char): Accept an additional argument
2073 DISP_PROP_P, and pass it to compute_display_string_pos.
2074 Only handle text covered by a display string if DISP_PROP_P is returned
2075 non-zero. All callers of bidi_fetch_char changed.
2077 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2079 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2081 2010-12-03 Don March <don@ohspite.net>
2083 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2084 last character M-[char] is translated to ESC [char] (bug#7541).
2086 2011-08-02 Kenichi Handa <handa@m17n.org>
2088 * lisp.h (uniprop_table): Extern it.
2090 * chartab.c (uniprop_table): Make it non-static.
2092 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2094 * xdisp.c (forward_to_next_line_start): Accept additional argument
2095 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2097 (reseat_at_next_visible_line_start): Use the bidi iterator state
2098 returned by forward_to_next_line_start to restore the state of
2099 it->bidi_it after backing up to previous newline. (Bug#9212)
2101 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2103 * regex.c (re_comp): Protoize.
2104 (re_exec): Fix return type.
2105 (regexec): Fix type of `ret'. (Bug#9203)
2107 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2109 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2110 This is needed if max-image-size is a floating-point number.
2112 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2114 * print.c (print_object): Print empty symbol as ##.
2116 * lread.c (read1): Read ## as empty symbol.
2118 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2120 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2121 setting frame foreground color (Bug#9175).
2122 (x_set_background_color): Likewise.
2124 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2125 contents (Bug#9176).
2126 (EmacsTooltip -init): Remove bezels and add shadows to
2129 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2130 or scroll bar (Bug#8470).
2132 * nsfont.m (nsfont_open): Remove assignment to voffset and
2133 unnecessary vars hshink, expand, hd, full_height, min_height.
2134 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2136 * nsterm.h (nsfont_info): Remove voffset field.
2138 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2140 Implement strike-through and overline on NextStep (Bug#8863).
2142 * nsfont.m (nsfont_open): Use underline position provided by font,
2143 instead of hard-coded value of 2.
2144 (nsfont_draw): Call ns_draw_text_decoration instead.
2146 * nsterm.h: Add declaration for ns_draw_text_decoration.
2148 * nsterm.m (ns_draw_text_decoration): New function for drawing
2149 underline, overline, and strike-through.
2150 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2151 ns_draw_text_decoration. Change treatment of cursor drawing to
2152 accommodate underlining, etc.
2154 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2156 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2159 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2161 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2162 Without this fix, if a signal arrives just after memory fills up,
2163 'malloc' might be invoked reentrantly.
2165 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2166 In other words, assume that every image size is allowed, on non-X
2167 hosts. This assumption is probably wrong, but it lets Emacs compile.
2169 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2171 * regex.c (re_iswctype): Convert return values to boolean.
2173 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2175 * xdisp.c (compute_display_string_pos): Don't use cached display
2176 string position if the buffer had its restriction changed.
2179 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2181 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2183 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2185 Integer signedness and overflow and related fixes. (Bug#9079)
2187 * bidi.c: Integer size and overflow fixes.
2188 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2189 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2190 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2191 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2192 (bidi_find_other_level_edge):
2193 Use ptrdiff_t instead of EMACS_INT where either will do.
2194 This works better on 32-bit hosts configured --with-wide-int.
2195 (bidi_cache_ensure_space): Check for size-calculation overflow.
2196 Use % rather than repeated addition, for better worst-case speed.
2197 Don't set bidi_cache_size until after xrealloc returns, because it
2199 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2200 (bidi_cache_ensure_space): Also check that the bidi cache size
2201 does not exceed that of the largest Lisp string or buffer. See Eli
2202 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2204 * alloc.c (__malloc_size_t): Remove.
2205 All uses replaced by size_t. See Andreas Schwab's note
2206 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2208 * image.c: Improve checking for integer overflow.
2209 (check_image_size): Assume that f is nonnull, since
2210 it is always nonnull in practice. This is one less thing to
2211 worry about when checking for integer overflow later.
2212 (x_check_image_size): New function, which checks for integer
2213 overflow issues inside X.
2214 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2215 This removes the need for a memory_full check.
2216 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2217 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2218 (xbm_read_bitmap_data): Change locals back to 'int', since
2219 their values must fit in 'int'.
2220 (xpm_load_image, png_load, tiff_load):
2221 Invoke x_create_x_image_and_pixmap earlier,
2222 to avoid much needless work if the image is too large.
2223 (tiff_load): Treat overly large images as if
2224 x_create_x_image_and_pixmap failed, not as malloc failures.
2225 (gs_load): Use x_check_image_size.
2227 * gtkutil.c: Omit integer casts.
2228 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2229 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2231 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2233 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2234 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2235 would wrongly return t on a 64-bit host.
2237 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2238 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2239 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2240 and therefore cause GCC to emit a bogus diagnostic in some cases.
2242 * image.c: Integer signedness and overflow and related fixes.
2243 This is not an exhaustive set of fixes, but it's time to
2244 record what I've got.
2245 (lookup_pixel_color, check_image_size): Remove redundant decls.
2246 (check_image_size): Don't assume that arbitrary EMACS_INT values
2247 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2248 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2249 (tiff_load, imagemagick_load_image):
2250 Check for overflow in size calculations.
2251 (x_create_x_image_and_pixmap): Remove unnecessary test for
2252 xmalloc returning NULL; that can't happen.
2253 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2254 (xpm_color_bucket): Use better integer hashing function.
2255 (xpm_cache_color): Don't possibly over-allocate memory.
2256 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2257 (gif_memory_source):
2258 Use ptrdiff_t, not int or size_t, to record sizes.
2259 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2260 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2261 either works, as we prefer signed integers.
2262 (tiff_read_from_memory, tiff_write_from_memory):
2263 Return tsize_t, not size_t, since that's what the TIFF API wants.
2264 (tiff_read_from_memory): Don't fail simply because the read would
2265 go past EOF; instead, return a short read.
2266 (tiff_load): Omit no-longer-needed casts.
2267 (Fimagemagick_types): Don't assume size fits into 'int'.
2269 Improve hashing quality when configured --with-wide-int.
2270 * fns.c (hash_string): New function, taken from sxhash_string.
2271 Do not discard information about ASCII character case; this
2272 discarding is no longer needed.
2273 (sxhash-string): Use it. Change sig to match it. Caller changed.
2274 * lisp.h: Declare it.
2275 * lread.c (hash_string): Remove, since we now use fns.c's version.
2276 The fns.c version returns a wider integer if --with-wide-int is
2277 specified, so this should help the quality of the hashing a bit.
2279 * emacs.c: Integer overflow minor fix.
2280 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2281 Define only if GNU_LINUX.
2282 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2284 * dispnew.c: Integer signedness and overflow fixes.
2285 Remove unnecessary forward decls, that were a maintenance hassle.
2286 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2288 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2289 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2290 (prepare_desired_row, line_draw_cost):
2291 Use int, not unsigned, where either works.
2292 (save_current_matrix, restore_current_matrix):
2293 Use ptrdiff_t, not size_t, where either works.
2294 (init_display): Check for overflow more accurately, and without
2295 relying on undefined behavior.
2297 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2298 Remove, replacing with the new symbols in lisp.h. All uses changed.
2299 * fileio.c (make_temp_name):
2300 * filelock.c (lock_file_1, lock_file):
2301 * xdisp.c (message_dolog):
2302 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2303 Use pMd etc. instead.
2304 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2305 replacing the pWIDE etc. symbols removed from editfns.c.
2307 * keyboard.h (num_input_events): Now uintmax_t.
2308 This is (very slightly) less likely to mess up due to wraparound.
2311 * buffer.c: Integer signedness fixes.
2312 (alloc_buffer_text, enlarge_buffer_text):
2313 Use ptrdiff_t rather than size_t when either will do, as we prefer
2316 * alloc.c: Integer signedness and overflow fixes.
2317 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2318 (__malloc_size_t): Default to size_t, not to int.
2319 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2320 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2321 Prefer ptrdiff_t to size_t when either would do, as we prefer
2323 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2324 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2325 Now const. Initialize with values that are in range even if char
2327 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2328 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2329 These functions do the right thing with sizes > 2**32.
2330 (check_depth): Now ptrdiff_t, not int.
2331 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2332 Adjust to new way of storing sizes. Check for size overflow bugs
2334 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2335 slightly wrong anyway, as it missed one instance of
2336 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2337 (refill_memory_reserve): Omit needless cast to size_t.
2338 (mark_object_loop_halt): Mark as externally visible.
2340 * xselect.c: Integer signedness and overflow fixes.
2341 (Fx_register_dnd_atom, x_handle_dnd_message):
2342 Use ptrdiff_t, not size_t, since we prefer signed.
2343 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2344 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2345 x_dnd_atoms_size and x_dnd_atoms_length.
2347 * doprnt.c: Prefer signed to unsigned when either works.
2349 * doprnt.c (doprnt):
2351 * xdisp.c (vmessage):
2352 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2353 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2354 prefer signed arithmetic to avoid comparison confusion.
2355 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2356 but is a bit tricky.
2358 Assume freestanding C89 headers, string.h, stdlib.h.
2359 * data.c, doprnt.c, floatfns.c, print.c:
2360 Include float.h unconditionally.
2361 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2362 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2363 * regex.c: Likewise for stddef.h, string.h.
2364 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2365 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2366 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2367 (STDC_HEADERS): Remove obsolete defines.
2368 * sysdep.c: Include limits.h unconditionally.
2370 Assume support for memcmp, memcpy, memmove, memset.
2371 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2372 * regex.c (memcmp, memcpy):
2373 Remove; we assume C89 now.
2375 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2376 (__malloc_safe_bcopy): Remove; no longer needed.
2378 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2379 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2380 well either way, and we prefer signed to unsigned.
2382 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2384 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2385 closes the connection while we're reading (bug#9182).
2387 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2389 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2390 are specified (Bug#9168).
2392 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2394 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2395 Found by GCC static checking and --with-wide-int on a 32-bit host.
2397 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2399 * xdisp.c (compute_display_string_pos): Fix logic of caching
2400 previous display string position. Initialize cached_prev_pos to
2401 -1. Fixes slow-down at the beginning of a buffer.
2403 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2405 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2406 for attrs[LFACE_FONTSET_INDEX].
2408 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2410 * xml.c (parse_region): Remove unused local
2411 that was recently introduced.
2413 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2415 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2416 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2418 * xdisp.c (move_it_in_display_line_to): Record the best matching
2419 position for TO_CHARPOS while scanning the line, and restore it on
2420 exit if none of the characters scanned was an exact match.
2421 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2422 when exact match is impossible due to invisible text, and the
2423 lines are truncated.
2425 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2427 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2430 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2432 Fix a significant slow-down of cursor motion with C-n, C-p,
2433 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2434 auto-repeat under bidi redisplay in fontified buffers.
2435 * xdisp.c (compute_stop_pos_backwards): New function.
2436 (next_element_from_buffer): Call compute_stop_pos_backwards to
2437 find a suitable prev_stop when we find ourselves before
2439 (reseat): Don't look for prev_stop, as that could mean a very long
2441 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2442 <cached_disp_overlay_modiff>: Cache for last found display string
2444 (compute_display_string_pos): Return the cached position if asked
2445 about the same buffer in the same area of character positions, and
2446 the buffer wasn't changed since the time the display string
2447 position was cached.
2449 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2451 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2452 is an integer, which is important for empty lines. (Bug#9149)
2454 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2456 * frame.c (Fmodify_frame_parameters): In tty case, update the
2457 default face if necessary (Bug#4238).
2459 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2461 * editfns.c (Fstring_to_char): No need to explain what a character
2462 is in the docstring (Bug#6576).
2464 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2466 * xml.c (parse_region): Make sure we always return a tree.
2468 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2470 * xml.c (parse_region): If a document contains only comments,
2473 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2475 * xml.c (make_dom): Return comments, too.
2477 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2480 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2481 and the surrounding thread.
2482 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2483 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2484 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2486 * s/openbsd.h (BROKEN_SIGIO): Define.
2487 * unexelf.c (unexec) [__OpenBSD__]:
2488 Don't update the .mdebug section of the Alpha COFF symbol table.
2490 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2492 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2495 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2497 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2498 This fixes some race conditions on the permissions of any newly
2501 * alloc.c (valid_pointer_p): Use pipe, not open.
2502 This fixes some permissions issues when debugging.
2504 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2505 If fchown fails to set both uid and gid, try to set just gid,
2506 as that is sometimes allowed. Adjust the file's mode to eliminate
2507 setuid or setgid bits that are inappropriate if fchown fails.
2509 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2511 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2512 to compare Lisp_Objects.
2513 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2514 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2515 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2517 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2519 * lread.c (read_integer): Unread even EOF character.
2520 (read1): Likewise. Properly record start position of symbol.
2522 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2523 symbol character follows.
2525 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2527 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2528 This works around a problem with the previous change to Fcopy_file.
2529 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2530 and without this change, GCC might complain about discarding
2531 fchown's return value.
2533 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2535 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2537 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2539 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2541 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2543 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2544 it's used from the C level.
2546 * process.c: Use the same condition for POLL_FOR_INPUT in both
2547 keyboard.c and process.c (bug#1858).
2549 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2551 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2552 (Fgnutls_boot): Use it.
2554 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2556 * doc.c (Fsubstitute_command_keys): Revert last change.
2558 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2560 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2561 quotes the next character, and doesn't affect other longer
2562 sequences (bug#8935).
2564 * lread.c (syms_of_lread): Clarify that is isn't only
2565 `eval-buffer' and `eval-defun' that's affected by
2566 `lexical-binding' (bug#8460).
2568 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2570 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2571 bidi redisplay when a line includes both an image and is truncated.
2573 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2575 Fix minor problems found by static checking.
2576 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2577 (elsz): Now a signed constant, not a size_t var. We prefer signed
2578 types to unsigned, to avoid integer comparison confusion. Without
2579 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2580 "cannot optimize loop, the loop counter may overflow", a symptom
2582 * indent.c (Fvertical_motion): Mark locals as initialized.
2583 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2585 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2587 * search.c (Fre_search_backward): Mention `case-fold-search' in
2588 all the re_search_* functions (bug#8138).
2590 * keyboard.c (Fopen_dribble_file): Document when the file is
2593 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2595 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2598 Support bidi reordering of display and overlay strings.
2599 * xdisp.c (compute_display_string_pos)
2600 (compute_display_string_end): Accept additional argument STRING.
2601 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2602 (reseat_to_string): Initialize bidi_it->string.s and
2603 bidi_it->string.schars.
2604 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2605 NULL (avoids a crash in bidi_paragraph_init).
2606 Initialize itb.string.lstring.
2607 (init_iterator): Call bidi_init_it only of a valid
2608 buffer position was specified. Initialize paragraph_embedding to
2610 (reseat_to_string): Initialize the bidi iterator.
2611 (display_string): If we need to ignore text properties of
2612 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2613 original value of -1 will not work with bidi.)
2614 (compute_display_string_pos): First arg is now struct
2615 `text_pos *'; all callers changed. Support display properties on
2617 (compute_display_string_end): Support display properties on Lisp
2619 (init_iterator, reseat_1, reseat_to_string): Initialize the
2620 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2621 when iterating on a string not from display properties).
2622 (compute_display_string_pos, compute_display_string_end):
2623 Fix calculation of the object to scan. Fixes an error when using
2625 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2626 base_level_stop; instead, set base_level_stop to BEGV.
2627 Fixes crashes in vertical-motion.
2628 (next_element_from_buffer): Improve commentary for when
2629 the iterator is before prev_stop.
2630 (init_iterator): Initialize bidi_p from the default value of
2631 bidi-display-reordering, not from buffer-local value. Use the
2632 buffer-local value only if initializing for buffer iteration.
2633 (handle_invisible_prop): Support invisible properties on strings
2634 that are being bidi-reordered.
2635 (set_iterator_to_next): Support bidi reordering of C strings and
2637 (next_element_from_string): Support bidi reordering of Lisp
2639 (handle_stop_backwards): Support Lisp strings as well.
2640 (display_string): Support display of R2L glyph rows.
2641 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2642 (init_iterator): Don't initialize it->bidi_p for strings
2644 (reseat_to_string): Initialize it->bidi_p for strings here.
2645 (next_element_from_string, next_element_from_c_string)
2646 (next_element_from_buffer): Add xassert's for correspondence
2647 between IT's object being iterated and it->bidi_it.string
2649 (face_before_or_after_it_pos): Support bidi iteration.
2650 (next_element_from_c_string): Handle the case of the first string
2651 character that is not the first one in the visual order.
2652 (get_visually_first_element): New function, refactored from common
2653 parts of next_element_from_buffer, next_element_from_string, and
2654 next_element_from_c_string.
2655 (tool_bar_lines_needed, redisplay_tool_bar)
2656 (display_menu_bar): Force left-to-right direction. Add a FIXME
2657 comment for making that be controlled by a user option.
2658 (push_it, pop_it): Save and restore the state of the
2659 bidi iterator. Save and restore the bidi_p flag.
2660 (pop_it): Iterate out of display property for string iteration as
2662 (iterate_out_of_display_property): Support iteration over strings.
2663 (handle_single_display_spec): Set up it->bidi_it for iteration
2664 over a display string, and call bidi_init_it.
2665 (handle_single_display_spec, next_overlay_string)
2666 (get_overlay_strings_1, push_display_prop): Set up the bidi
2667 iterator for displaying display or overlay strings.
2668 (forward_to_next_line_start): Don't use the shortcut if
2670 (back_to_previous_visible_line_start): If handle_display_prop
2671 pushed the iterator stack, restore the internal state of the bidi
2672 iterator by calling bidi_pop_it same number of times.
2673 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2674 and we are bidi-iterating, don't decrement the iterator position;
2675 instead, set the first_elt flag in the bidi iterator, to produce
2677 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2678 (push_display_prop): xassert that we are iterating a buffer.
2679 (push_it, pop_it): Save and restore paragraph_embedding member.
2680 (handle_single_display_spec, next_overlay_string)
2681 (get_overlay_strings_1, reseat_1, reseat_to_string)
2682 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2683 correctly. Don't assume unibyte strings are not bidi-reordered.
2684 (compute_display_string_pos)
2685 (compute_display_string_end): Fix handling the case of C string.
2686 (push_it, pop_it): Save and restore from_disp_prop_p.
2687 (handle_single_display_spec, push_display_prop): Set the
2688 from_disp_prop_p flag.
2689 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2690 (pop_it): Call iterate_out_of_display_property only if we are
2691 popping after iteration over a string that came from a display
2692 property. Fix a typo in popping stretch info. Add an assertion
2693 for verifying that the iterator position is in sync with the bidi
2695 (handle_single_display_spec, get_overlay_strings_1)
2696 (push_display_prop): Fix initialization of paragraph direction for
2697 string when that of the parent object is not yet determined.
2698 (reseat_1): Call bidi_init_it to resync the bidi
2699 iterator with IT's position. (Bug#7616)
2700 (find_row_edges): If ROW->start.pos gives position
2701 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2702 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2703 Reset the from_disp_prop_p flag.
2704 (SAVE_IT, RESTORE_IT): New macros.
2705 (pos_visible_p, face_before_or_after_it_pos)
2706 (back_to_previous_visible_line_start)
2707 (move_it_in_display_line_to, move_it_in_display_line)
2708 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2709 (try_scrolling, redisplay_window, display_line): Use them when
2710 saving a temporary copy of the iterator and restoring it back.
2711 (back_to_previous_visible_line_start, reseat_1)
2712 (init_iterator): Empty the bidi cache "stack".
2713 (move_it_in_display_line_to): If iterator ended up at
2714 EOL, but we never saw any buffer positions smaller than
2715 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2716 motion in bidi-reordered lines.
2717 (move_it_in_display_line_to): Record prev_method and prev_pos
2718 immediately before the call to set_iterator_to_next. Fixes cursor
2719 motion in bidi-reordered lines with stretch glyphs and strings
2720 displayed in margins. (Bug#8133) (Bug#8867)
2721 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2723 (pos_visible_p): Support positions in bidi-reordered lines.
2724 Save and restore bidi cache.
2726 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2727 (bidi_paragraph_info): Delete unused struct.
2728 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2729 (bidi_cache_start): New variable.
2730 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2732 (bidi_cache_fetch_state, bidi_cache_search)
2733 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2734 (bidi_cache_find, bidi_peek_at_next_level)
2735 (bidi_level_of_next_char, bidi_find_other_level_edge)
2736 (bidi_move_to_visually_next): Compare cache index with
2737 bidi_cache_start rather than with zero.
2738 (bidi_fetch_char): Accept new argument STRING; all callers
2739 changed. Support iteration over a string. Support strings with
2740 display properties. Support unibyte strings. Fix the type of
2741 `len' according to what STRING_CHAR_AND_LENGTH expects.
2742 (bidi_paragraph_init, bidi_resolve_explicit_1)
2743 (bidi_resolve_explicit, bidi_resolve_weak)
2744 (bidi_level_of_next_char, bidi_move_to_visually_next):
2745 Support iteration over a string.
2746 (bidi_set_sor_type, bidi_resolve_explicit_1)
2747 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2748 can now be zero (for strings); special values 0 and -1 were
2749 changed to -1 and -2, respectively.
2750 (bidi_char_at_pos): New function.
2751 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2752 Call it instead of FETCH_MULTIBYTE_CHAR.
2753 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2754 initialized to valid values.
2755 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2757 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2758 the test for valid cached positions. Fix the logic for looking up
2759 the sentinel state in the cache. GCPRO the Lisp string we are
2761 (bidi_push_it, bidi_pop_it): New functions.
2762 (bidi_initialize): Initialize the bidi cache start stack pointer.
2763 (bidi_cache_ensure_space): New function, refactored from part of
2764 bidi_cache_iterator_state. Don't assume the required size is just
2765 one BIDI_CACHE_CHUNK away.
2766 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2767 (bidi_count_bytes, bidi_char_at_pos): New functions.
2768 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2769 always valid if bidi_cache_idx is valid.
2770 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2771 is valid if it's going to be used.
2772 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2773 (bidi_cache_fetch_state, bidi_cache_search)
2774 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2775 (bidi_cache_iterator_state, bidi_cache_find)
2776 (bidi_find_other_level_edge, bidi_cache_start_stack):
2777 All variables related to cache indices are now EMACS_INT.
2779 * dispextern.h (struct bidi_string_data): New structure.
2780 (struct bidi_it): New member `string'. Make flag members be 1-bit
2781 fields, and put them last in the struct.
2782 (compute_display_string_pos, compute_display_string_end):
2784 (bidi_push_it, bidi_pop_it): Add prototypes.
2785 (struct iterator_stack_entry): New members bidi_p,
2786 paragraph_embedding, and from_disp_prop_p.
2787 (struct it): Member bidi_p is now a bit field 1 bit wide.
2788 (bidi_shelve_cache, bidi_unshelve_cache):
2791 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2792 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2793 and vector-like objects.
2795 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2796 cache around display iteration.
2798 * window.c (Fwindow_end, window_scroll_pixel_based)
2799 (displayed_window_lines, Frecenter): Save and restore the bidi
2800 cache around display iteration.
2802 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2804 * editfns.c (Fdelete_region): Clarify the use of the named
2805 parameters (bug#6788).
2807 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2809 * indent.c (Fvertical_motion): Set and restore w->pointm when
2810 saving and restoring the window's buffer (Bug#9006).
2812 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2814 * editfns.c (Fstring_to_char): Clarify just what is returned
2815 (bug#6576). Text by Eli Zaretskii.
2817 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2819 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2821 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2823 * buffer.c (mmap_find): Fix a typo.
2825 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2827 Fix execution of x selection hooks.
2828 * xselect.c (Qx_lost_selection_functions)
2829 (Qx_sent_selection_functions): New vars.
2830 (syms_of_xselect): DEFSYM them.
2831 (x_handle_selection_request): Pass Qx_sent_selection_functions
2832 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2833 (x_handle_selection_clear,x_clear_frame_selections):
2834 Pass Qx_lost_selection_functions rather than
2835 Vx_lost_selection_functions to Frun_hook_with_args.
2837 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2839 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2840 The old code sometimes used this field without initializing it.
2842 * alloc.c (gc_sweep): Don't read past end of array.
2843 In theory, the old code could also have corrupted Emacs internals,
2844 though it'd be very unlikely.
2846 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2848 * character.c (Fcharacterp): Don't advertise optional ignored
2849 argument. (Bug#4026)
2851 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2853 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2856 * window.c (Fset_window_start): Doc fix (bug#4199).
2857 (Fset_window_hscroll): Ditto.
2859 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2861 Fix minor new problems caught by GCC 4.6.1.
2862 * term.c (init_tty): Remove unused local.
2863 * xsettings.c (store_monospaced_changed): Define this function only
2864 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2867 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2869 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2871 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2873 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2874 are the mini-buffer and the echo area (bug#3320).
2876 * term.c (init_tty): Remove support for supdup, c10 and perq
2877 terminals, which are no longer supported (bug#1482).
2879 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2881 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2883 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2885 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2886 for non-popups (Bug#3642).
2888 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2890 * alloc.c (reset_malloc_hooks): Protoize.
2891 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2892 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2893 * cm.c (losecursor): Likewise.
2894 * data.c (fmod): Likewise.
2895 * dispnew.c (swap_glyphs_in_rows): Likewise.
2896 * emacs.c (memory_warning_signal): Likewise.
2897 * floatfns.c (float_error): Likewise.
2898 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2899 (otf_open, font_otf_capability, generate_otf_features)
2900 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2902 * image.c (pbm_read_file): Likewise.
2903 * indent.c (string_display_width): Likewise.
2904 * intervals.c (check_for_interval, search_for_interval)
2905 (inc_interval_count, count_intervals, root_interval)
2906 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2907 * lread.c (defalias): Likewise.
2908 * ralloc.c (r_alloc_check): Likewise.
2909 * regex.c (set_image_of_range_1, set_image_of_range)
2910 (regex_grow_registers): Likewise.
2911 * sysdep.c (strerror): Likewise.
2912 * termcap.c (valid_filename_p, tprint, main): Likewise.
2913 * tparam.c (main): Likewise.
2914 * unexhp9k800.c (run_time_remap, save_data_space)
2915 (update_file_ptrs, read_header, write_header, calculate_checksum)
2916 (copy_file, copy_rest, display_header): Likewise.
2917 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2919 * xdisp.c (check_it): Likewise.
2920 * xfaces.c (register_color, unregister_color, unregister_colors):
2922 * xfns.c (print_fontset_result): Likewise.
2923 * xrdb.c (member, fatal, main): Likewise.
2925 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2927 Fix minor problems found by static checking (Bug#9031).
2928 * chartab.c (char_table_set_range, map_sub_char_table):
2929 Remove unused locals.
2930 (uniprop_table): Now static.
2931 * composite.c (_work_char): Remove unused static var.
2933 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2935 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2937 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2939 * gtkutil.c (qttip_cb): Remove code without function.
2941 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2943 * w32.c (pthread_sigmask): New stub.
2945 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2947 Use pthread_sigmask, not sigprocmask (Bug#9010).
2948 sigprocmask is portable only for single-threaded applications, and
2949 Emacs can be multi-threaded when it uses GTK.
2950 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2952 * callproc.c (Fcall_process):
2953 * process.c (create_process):
2954 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2955 Use pthread_sigmask, not sigprocmask.
2957 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2959 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2960 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2963 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2965 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2966 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2967 (xg_hide_tooltip): Fix comment.
2969 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2970 in registerServicesMenuSendTypes.
2971 (validRequestorForSendType): Don't check ns_return_types.
2973 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2976 2011-07-08 Jason Rumney <jasonr@gnu.org>
2978 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2979 SH_SHOW for hidden windows (Bug#5482).
2981 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2982 frame struct members of non-existent frames (Bug#6284).
2984 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2986 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2987 variable firstTime not needed on OSX >= 10.6.
2988 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2989 >= 10.5. Use setKnobProportion, setDoubleValue.
2991 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2992 (MAC_OS_X_VERSION_10_5): Define if not defined.
2993 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2994 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2995 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2997 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2998 cString and lossyCString on OSX >= 10.4
3000 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3001 sizeToFit on OSX >= 10.2.
3003 * nsimage.m (allocInitFromFile): Don't use deprecated method
3004 bestRepresentationForDevice on OSX >= 10.6.
3006 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3009 * emacs.c: Declare unexec_init_emacs_zone.
3011 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3013 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3015 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3016 on svcsMenu (Bug#8842).
3018 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3020 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3022 * nsterm.m (QUTF8_STRING): Declare.
3023 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3024 (validRequestorForSendType): Return type is (id).
3025 Change indexOfObjectIdenticalTo to indexOfObject.
3026 Check if we have local selection before returning self (Bug#8842).
3027 (writeSelectionToPasteboard): Put local selection into paste board
3028 if we have a local selection (Bug#8842).
3029 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3031 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3032 (ns_get_local_selection): Declare.
3034 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3036 * keymap.c (describe_map_tree): Don't insert a double newline at
3037 the end of the buffer (bug#1169) and return whether we inserted
3040 * callint.c (Fcall_interactively): Change "reading args" to
3041 "providing args" to try to clarify what it does (bug#1010).
3043 2011-07-07 Kenichi Handa <handa@m17n.org>
3045 * composite.c (composition_compute_stop_pos): Ignore a static
3046 composition starting before CHARPOS (Bug#8915).
3048 * xdisp.c (handle_composition_prop): Likewise.
3050 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3052 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3055 2011-07-07 Kenichi Handa <handa@m17n.org>
3057 * character.h (unicode_category_t): New enum type.
3059 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3060 (Qchar_code_property_table): New variable.
3061 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3062 (UNIPROP_COMPRESSED_FORM_P): New macros.
3063 (char_table_ascii): Uncompress the compressed values.
3064 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3065 Uncompress the compressed values.
3066 (sub_char_table_ref_and_range): Likewise.
3067 (char_table_ref_and_range): Uncompress the compressed values.
3068 (sub_char_table_set): New arg is_uniprop. Callers changed.
3069 Uncompress the compressed values.
3070 (sub_char_table_set_range): Args changed. Callers changed.
3071 (char_table_set_range): Adjuted for the above change.
3072 (map_sub_char_table): Delete args default_val and parent. Add arg
3073 top. Give decoded values to a Lisp function.
3074 (map_char_table): Adjust for the above change. Give decoded
3075 values to a Lisp function. Gcpro more variables.
3076 (uniprop_table_uncompress)
3077 (uniprop_decode_value_run_length): New functions.
3078 (uniprop_decoder, uniprop_decoder_count): New variables.
3079 (uniprop_get_decoder, uniprop_encode_value_character)
3080 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3082 (uniprop_encoder, uniprop_encoder_count): New variables.
3083 (uniprop_get_encoder, uniprop_table)
3084 (Funicode_property_table_internal, Fget_unicode_property_internal)
3085 (Fput_unicode_property_internal): New functions.
3086 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3087 Sunicode_property_table_internal, Sget_unicode_property_internal,
3088 and Sput_unicode_property_internal. Defvar_lisp
3089 char-code-property-alist.
3091 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3092 Vunicode_category_table.
3094 * font.c (font_range): Adjust for the change of
3095 Vunicode_category_table.
3097 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3099 * m/iris4d.h: Remove file, move contents ...
3100 * s/irix6-5.h: ... here.
3102 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3104 Remove unportable assumption about struct layout (Bug#8884).
3105 * alloc.c (mark_buffer):
3106 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3107 (clone_per_buffer_values): Don't assume that
3108 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3109 This isn't true in general, and it's particularly not true
3110 if Emacs is configured with --with-wide-int.
3111 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3112 New macros, used in the buffer.c change.
3114 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3116 * xsettings.c: Use both GConf and GSettings if both are available.
3117 (store_config_changed_event): Add comment.
3118 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3119 (store_tool_bar_style_changed): New functions.
3120 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3121 (struct xsettings): Move font inside HAVE_XFT.
3122 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3123 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3124 Move inside HAVE_XFT.
3125 (something_changed_gsettingsCB): Rename from something_changedCB.
3126 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3128 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3129 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3130 (something_changed_gconfCB): Rename from something_changedCB.
3131 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3132 (parse_settings): Move check for font inside HAVE_XFT.
3133 (read_settings, apply_xft_settings): Add comment.
3134 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3135 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3136 call store_font_name_changed.
3137 (xft_settings_event): Add comment.
3138 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3139 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3140 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3141 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3142 (xsettings_initialize): Call init_gsettings last.
3143 (xsettings_get_system_font, xsettings_get_system_normal_font):
3146 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3148 Random fixes. E.g., (random) never returned negative values.
3149 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3150 subseconds part to the entropy, as that's a bit more random.
3151 Prefer signed to unsigned, since the signedness doesn't matter and
3152 in general we prefer signed. When given a limit, use a
3153 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3154 latter isn't right if USE_2_TAGS_FOR_INTS.
3155 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3156 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3158 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3160 * textprop.c (text_property_stickiness):
3161 Obey Vtext_property_default_nonsticky.
3162 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3163 * w32fns.c (syms_of_w32fns):
3164 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3166 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3168 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3169 This is more efficient than Ffile_directory_p and avoids a minor race.
3171 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3173 * buffer.c (Foverlay_put): Say what the return value is
3176 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3177 is a directory before asking whether to use the file name
3179 (barf_or_query_if_file_exists): Make the "File is a directory"
3180 error be more correct.
3182 * fns.c (Frequire): Remove the mention of the .gz files, since
3183 that's installation-specific, but keep the mention of
3184 `get-load-suffixes'.
3186 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3188 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3189 Report string overflow if the output is too long.
3191 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3193 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3194 (syms_of_gnutls): Remove duplicate DEFSYM for
3195 Qgnutls_bootprop_verify_hostname_error, an error for
3196 Qgnutls_bootprop_verify_error (which is no longer used).
3198 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3199 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3200 Also (re)move comments that are misplaced or no longer relevant.
3202 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3204 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3206 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3208 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3209 and background color parameters if they have been changed.
3211 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3213 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3215 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3217 * xsettings.c (SYSTEM_FONT): Define only when used.
3218 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3220 * keymap.c (access_keymap_1): Now static.
3222 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3224 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3225 leave any prefix arg for the up event (Bug#1586).
3227 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3229 * lread.c (syms_of_lread): Mention single symbols defined by
3230 `defvar' or `defconst' (bug#7154).
3232 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3233 (Frequire): Mention get-load-suffixes.
3235 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3237 * window.h (window): Remove clone_number slot.
3238 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3240 (make_parent_window, make_window, saved_window)
3241 (Fset_window_configuration, save_window_save): Don't deal with
3243 * buffer.c (Qclone_number): Remove declaration.
3244 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3246 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3248 Add multiple inheritance to keymaps.
3249 * keymap.c (Fmake_composed_keymap): New function.
3250 (Fset_keymap_parent): Simplify.
3251 (fix_submap_inheritance): Remove.
3252 (access_keymap_1): New function extracted from access_keymap to handle
3253 embedded parents and handle lists of maps.
3254 (access_keymap): Use it.
3255 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3256 (Fcopy_keymap): Handle embedded parents.
3257 (Fcommand_remapping, define_as_prefix): Simplify.
3258 (Fkey_binding): Simplify.
3259 (syms_of_keymap): Move minibuffer-local-completion-map,
3260 minibuffer-local-filename-completion-map,
3261 minibuffer-local-must-match-map, and
3262 minibuffer-local-filename-must-match-map to Elisp.
3263 (syms_of_keymap): Defsubr make-composed-keymap.
3264 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3265 (parse_menu_item): Trivial simplification.
3267 2011-07-01 Glenn Morris <rgm@gnu.org>
3269 * Makefile.in (SETTINGS_LIBS): Fix typo.
3271 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3273 * coding.c (Fencode_coding_string): Record the last coding system
3274 used, as the function doc string says (bug#8738).
3276 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3278 * xsettings.c (store_monospaced_changed): Take new font as arg and
3279 check for change against current_mono_font.
3280 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3281 (emacs_settings_constructor, emacs_settings_get_property)
3282 (emacs_settings_set_property, emacs_settings_class_init)
3283 (emacs_settings_init, gsettings_obj): Remove.
3284 (something_changedCB): New function for HAVE_GSETTINGS.
3285 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3286 with value as argument.
3287 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3288 g_settings_new (Bug#8967). Do not create gsettings_obj.
3289 Remove calls to g_settings_bind. Connect something_changedCB to
3292 * xgselect.c: Add defined (HAVE_GSETTINGS).
3293 (xgselect_initialize): Ditto.
3295 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3296 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3299 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3301 * eval.c (struct backtrace): Simplify and port the data structure.
3302 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3303 signed bit field, as this assumption is not portable and it makes
3304 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3305 "char debug_on_exit : 1" as this is not portable either; instead,
3306 use the portable "unsigned int debug_on_exit : 1". Remove unused
3307 member evalargs. Remove obsolete comments about cc bombing out.
3309 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3311 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3312 Let HAVE_GSETTINGS override HAVE_GCONF.
3313 (store_monospaced_changed): New function.
3314 (EMACS_SETTINGS): A new type derived from GObject to handle
3315 GSettings notifications.
3316 (emacs_settings_constructor, emacs_settings_get_property)
3317 (emacs_settings_set_property, emacs_settings_class_init):
3319 (gsettings_client, gsettings_obj): New variables.
3320 (GSETTINGS_SCHEMA): New define.
3321 (something_changedCB): Call store_monospaced_changed.
3322 (init_gsettings): New function.
3323 (xsettings_initialize): Call init_gsettings.
3324 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3327 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3330 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3332 * window.c (resize_root_window, grow_mini_window)
3333 (shrink_mini_window): Rename Qresize_root_window to
3334 Qwindow_resize_root_window and Qresize_root_window_vertically to
3335 Qwindow_resize_root_window_vertically.
3337 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3339 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3341 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3343 * makefile.w32-in: Redesign dependencies so they reflect more
3344 clearly which files are directly included by each source file,
3345 and not through other includes.
3347 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3349 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3350 (sort_overlays, overlay_strings): When an overlay's clone number
3351 matches the window's clone number process the overlay even if
3352 the overlay's window property doesn't match the current window.
3354 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3355 (Fwindow_hchild): Rename to Fwindow_left_child.
3356 (Fwindow_next): Rename to Fwindow_next_sibling.
3357 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3358 (resize_window_check): Rename to window_resize_check.
3359 (resize_window_apply): Rename to window_resize_apply.
3360 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3361 (Fdelete_other_windows_internal, resize_frame_windows)
3362 (Fsplit_window_internal, Fdelete_window_internal)
3363 (grow_mini_window, shrink_mini_window)
3364 (Fresize_mini_window_internal): Fix callers accordingly.
3366 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3368 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3369 (emacs_fixed_set_min_size): Remove.
3370 (emacs_fixed_new): Take frame as argument.
3372 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3373 (_EmacsFixedPrivate): Remove minwidth/height.
3374 Add struct frame *f.
3375 (emacs_fixed_init): Initialize priv->f.
3376 (get_parent_class, emacs_fixed_set_min_size): Remove.
3377 (emacs_fixed_new): Set priv->f to argument.
3378 (emacs_fixed_get_preferred_width)
3379 (emacs_fixed_get_preferred_height): Use min_width/height from
3380 frames size_hint to set minimum and natural (Bug#8919).
3381 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3382 and use min_width/height from frames size_hint to set
3383 min_width/height (Bug#8919).
3385 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3386 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3389 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3391 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3392 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3395 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3397 * process.c (wait_reading_process_output): Bypass select if
3398 waiting for a cell while ignoring keyboard input, and input is
3399 pending. Suggested by Jan Djärv (Bug#8869).
3401 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3403 Use gnulib's dup2 module instead of rolling our own.
3404 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3406 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3408 * dispnew.c (scrolling_window): Before scrolling, turn off a
3409 mouse-highlight in the window being scrolled.
3411 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3413 Move DEFSYM to lisp.h and use everywhere.
3415 * character.h (DEFSYM): Move declaration...
3416 * lisp.h (DEFSYM): ...here.
3422 * w32select.c: Don't include character.h.
3424 * alloc.c (syms_of_alloc):
3425 * buffer.c (syms_of_buffer):
3426 * bytecode.c (syms_of_bytecode):
3427 * callint.c (syms_of_callint):
3428 * casefiddle.c (syms_of_casefiddle):
3429 * casetab.c (init_casetab_once):
3430 * category.c (init_category_once, syms_of_category):
3431 * ccl.c (syms_of_ccl):
3432 * cmds.c (syms_of_cmds):
3433 * composite.c (syms_of_composite):
3434 * dbusbind.c (syms_of_dbusbind):
3435 * dired.c (syms_of_dired):
3436 * dispnew.c (syms_of_display):
3437 * doc.c (syms_of_doc):
3438 * editfns.c (syms_of_editfns):
3439 * emacs.c (syms_of_emacs):
3440 * eval.c (syms_of_eval):
3441 * fileio.c (syms_of_fileio):
3442 * fns.c (syms_of_fns):
3443 * frame.c (syms_of_frame):
3444 * fringe.c (syms_of_fringe):
3445 * insdel.c (syms_of_insdel):
3446 * keymap.c (syms_of_keymap):
3447 * lread.c (init_obarray, syms_of_lread):
3448 * macros.c (syms_of_macros):
3449 * msdos.c (syms_of_msdos):
3450 * print.c (syms_of_print):
3451 * process.c (syms_of_process):
3452 * search.c (syms_of_search):
3453 * sound.c (syms_of_sound):
3454 * syntax.c (init_syntax_once, syms_of_syntax):
3455 * terminal.c (syms_of_terminal):
3456 * textprop.c (syms_of_textprop):
3457 * undo.c (syms_of_undo):
3458 * w32.c (globals_of_w32):
3459 * window.c (syms_of_window):
3460 * xdisp.c (syms_of_xdisp):
3461 * xfaces.c (syms_of_xfaces):
3462 * xfns.c (syms_of_xfns):
3463 * xmenu.c (syms_of_xmenu):
3464 * xsettings.c (syms_of_xsettings):
3465 * xterm.c (syms_of_xterm): Use DEFSYM.
3467 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3469 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3471 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3473 Integer and buffer overflow fixes (Bug#8873).
3475 * print.c (printchar, strout): Check for string overflow.
3476 (PRINTPREPARE, printchar, strout):
3477 Don't set size unless allocation succeeds.
3479 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3480 for sizes. Check for string overflow more accurately.
3481 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3483 * macros.c: Integer and buffer overflow fixes.
3484 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3485 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3486 Use ptrdiff_t, not int, for sizes.
3487 Don't increment bufsize until after realloc succeeds.
3488 Check for size-calculation overflow.
3489 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3491 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3493 * lread.c: Integer overflow fixes.
3494 (read_integer): Radix is now EMACS_INT, not int,
3495 to improve quality of diagnostics for out-of-range radices.
3496 Calculate buffer size correctly for out-of-range radices.
3497 (read1): Check for integer overflow in radices, and in
3498 read-circle numbers.
3499 (read_escape): Avoid int overflow.
3500 (Fload, openp, read_buffer_size, read1)
3501 (substitute_object_recurse, read_vector, read_list, map_obarray):
3502 Use ptrdiff_t, not int, for sizes.
3503 (read1): Use EMACS_INT, not int, for sizes.
3504 Check for size overflow.
3506 * image.c (cache_image): Check for size arithmetic overflow.
3508 * lread.c: Integer overflow issues.
3509 (saved_doc_string_size, saved_doc_string_length)
3510 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3511 Now ptrdiff_t, not int.
3512 (read1): Don't assume doc string length fits in int. Check for
3513 out-of-range doc string lengths.
3514 (read_list): Don't assume file position fits in int.
3515 (read_escape): Check for hex character overflow.
3517 2011-06-22 Leo Liu <sdl.web@gmail.com>
3519 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3520 Move to minibuffer.el.
3522 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3524 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3525 The following patches are for when GLYPH_DEBUG && !XASSERT.
3526 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3527 * dispnew.c (flush_stdout):
3528 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3529 Mark as externally visible.
3530 * dispnew.c (check_window_matrix_pointers): Now static.
3531 * dispnew.c (window_to_frame_vpos):
3532 * xfns.c (unwind_create_frame):
3533 * xterm.c (x_check_font): Remove unused local.
3534 * scroll.c (CHECK_BOUNDS):
3535 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3536 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3537 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3538 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3539 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3541 (debug_method_add): Use va_list and vsprintf rather than relying
3542 on undefined behavior with wrong number of arguments.
3543 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3544 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3545 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3546 since we're not interested in debugging glyphs with old libraries.
3547 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3548 GCC 4.6.0's static checking.
3550 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3552 Integer overflow and signedness fixes (Bug#8873).
3553 A few related buffer overrun fixes, too.
3555 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3557 * dispextern.h (struct face.stipple):
3558 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3559 (x_bitmap_mask, x_allocate_bitmap_record)
3560 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3561 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3562 (x_create_bitmap_from_xpm_data):
3563 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3564 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3566 * xfaces.c (load_pixmap):
3567 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3568 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3569 (.bitmaps_last, struct x_output.icon_bitmap):
3570 Use ptrdiff_t, not int, for bitmap indexes.
3571 (x_allocate_bitmap_record): Check for size overflow.
3572 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3574 Use ptrdiff_t, not int, for overlay counts.
3575 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3576 * editfns.c (overlays_around, get_pos_property):
3577 * textprop.c (get_char_property_and_overlay):
3578 * xdisp.c (next_overlay_change, note_mouse_highlight):
3579 * xfaces.c (face_at_buffer_position):
3580 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3581 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3582 (Fnext_overlay_change, Fprevious_overlay_change)
3583 (mouse_face_overlay_overlaps, Foverlays_in):
3584 Use ptrdiff_t, not int, for sizes.
3585 (overlays_at, overlays_in): Check for size-calculation overflow.
3587 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3589 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3590 (x_session_initialize): Do not assume string length fits in int.
3592 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3593 This is unlikely, but can occur if DPI is outlandish.
3595 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3596 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3598 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3599 * xrdb.c (magic_file_p, search_magic_path):
3600 Omit last arg SUFFIX; it was always 0. All callers changed.
3601 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3603 * xfont.c (xfont_match): Avoid need for strlen.
3605 * xfns.c: Don't assume strlen fits in int.
3606 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3608 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3609 not unsigned long, as we prefer signed integers. All callers changed.
3610 Detect integer overflow in repeat count.
3611 (message_dolog): Don't assume print length fits in 39 bytes.
3612 (display_mode_element): Don't assume strlen fits in int.
3614 * termcap.c: Don't assume sizes fit in int and never overflow.
3615 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3616 (gobble_line): Check for size-calculation overflow.
3618 * minibuf.c (Fread_buffer):
3619 * lread.c (intern, intern_c_string):
3620 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3621 Don't assume string length fits in int.
3623 * keyboard.c (parse_tool_bar_item):
3624 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3626 * font.c: Don't assume string length fits in int.
3627 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3628 Use ptrdiff_t, not int.
3629 (font_intern_prop): Don't assume string length fits in int.
3630 Don't assume integer property fits in fixnum.
3631 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3633 * filelock.c: Fix some buffer overrun and integer overflow issues.
3634 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3635 Reformulate so as not to need the command string.
3636 Invoke gzip -cd rather than gunzip, as it's more portable.
3637 (lock_info_type, lock_file_1, lock_file):
3638 Don't assume pid_t and time_t fit in unsigned long.
3639 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3640 (current_lock_owner): Prefer signed type for sizes.
3641 Use memcpy, not strncpy, where memcpy is what is really wanted.
3642 Don't assume (via atoi) that time_t and pid_t fit in int.
3643 Check for time_t and/or pid_t out of range, e.g., via a network share.
3644 Don't alloca where an auto var works fine.
3646 * fileio.c: Fix some integer overflow issues.
3647 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3648 Don't assume string length fits in int.
3649 (directory_file_name): Don't assume string length fits in long.
3650 (make_temp_name): Don't assume pid fits in int, or that its print
3651 length is less than 20.
3653 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3655 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3657 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3659 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3660 We prefer signed integers, even for size calculations.
3662 * emacs.c: Don't assume string length fits in 'int'.
3663 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3664 (main): Don't invoke strlen when not needed.
3666 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3667 (XD_DEBUG_MESSAGE): Don't waste a byte.
3669 * callproc.c (getenv_internal_1, getenv_internal)
3671 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3673 * lread.c (invalid_syntax): Omit length argument.
3674 All uses changed. This doesn't fix a bug, but it simplifies the
3675 code away from its former Hollerith-constant appearance, and it's
3676 one less 'int' to worry about when looking at integer-overflow issues.
3677 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3679 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3680 This didn't break anything, but it didn't help either.
3681 It's confusing to put a bogus integer in a place where the actual
3682 value does not matter.
3683 (LIST_END_P): Remove unused macro and its bogus comment.
3684 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3686 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3687 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3689 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3690 We prefer signed types, and the value cannot exceed the EMACS_INT
3691 range anyway (because otherwise the length would not be representable).
3692 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3693 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3694 This avoids a GCC warning when WIDE_EMACS_INT.
3696 * indent.c (sane_tab_width): New function.
3697 (current_column, scan_for_column, Findent_to, position_indentation)
3698 (compute_motion): Use it. This is just for clarity.
3699 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3701 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3703 * lisp.h (lint_assume): New macro.
3704 * composite.c (composition_gstring_put_cache):
3705 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3707 * editfns.c, insdel.c:
3708 Omit unnecessary forward decls, to simplify future changes.
3710 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3712 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3714 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3715 Use much-faster test for byte-length change.
3716 Don't assume string byte-length fits in 'int'.
3717 Check that character arg fits in 'int'.
3718 (mapcar1): Declare byte as byte, for clarity.
3720 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3722 * fns.c (concat): Catch string overflow earlier.
3723 Do not rely on integer wraparound.
3725 * dispextern.h (struct it.overlay_strings_charpos)
3726 (struct it.selective): Now EMACS_INT, not int.
3727 * xdisp.c (forward_to_next_line_start)
3728 (back_to_previous_visible_line_start)
3729 (reseat_at_next_visible_line_start, next_element_from_buffer):
3730 Don't arbitrarily truncate the value of 'selective' to int.
3732 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3734 * composite.c: Don't truncate sizes to 'int'.
3735 (composition_gstring_p, composition_reseat_it)
3736 (composition_adjust_point): Use EMACS_INT, not int.
3737 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3738 not EMACS_UINT, for indexes.
3740 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3742 * buffer.c: Include <verify.h>.
3743 (struct sortvec.priority, struct sortstr.priority):
3744 Now EMACS_INT, not int.
3745 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3746 (struct sortstr.size, record_overlay_string)
3747 (struct sortstrlist.size, struct sortlist.used):
3748 Don't truncate size to int.
3749 (record_overlay_string): Check for size-calculation overflow.
3750 (init_buffer_once): Check at compile-time, not run-time.
3752 2011-06-22 Jim Meyering <meyering@redhat.com>
3754 Don't leak an XBM-image-sized buffer
3755 * image.c (xbm_load): Free the image buffer after using it.
3757 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3760 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3761 that Sun C diagnosed.
3762 * fns.c (secure_hash): Fix pointer signedness issue.
3763 * intervals.c (static_offset_intervals): New function.
3764 (offset_intervals): Use it.
3766 2011-06-21 Leo Liu <sdl.web@gmail.com>
3769 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3772 * fns.c (secure_hash): Rename from crypto_hash_function and change
3773 the first arg to accept symbols.
3774 (Fsecure_hash): New primitive.
3775 (syms_of_fns): New symbols.
3777 2011-06-20 Deniz Dogan <deniz@dogan.se>
3779 * process.c (Fset_process_buffer): Clarify return value in
3782 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3784 * dispnew.c (add_window_display_history): Use BVAR.
3786 * xdisp.c (debug_method_add): Use BVAR.
3787 (check_window_end, dump_glyph_matrix, dump_glyph)
3788 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3790 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3793 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3794 check till after the cache is created in init_frame_faces.
3796 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3798 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3800 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3802 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3803 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3804 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3806 Improve buffer-overflow checking (Bug#8873).
3807 * fileio.c (Finsert_file_contents):
3808 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3809 Remove the old (too-loose) buffer overflow checks.
3810 They weren't needed, since make_gap checks for buffer overflow.
3811 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3812 The old code merely checked for Emacs fixnum overflow, and relied
3813 on undefined (wraparound) behavior. The new code avoids undefined
3814 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3816 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3817 Tune. Don't use wider integers than needed. Don't use alloca.
3818 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3820 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3822 * insdel.c, lisp.h (buffer_overflow): New function.
3823 (insert_from_buffer_1, replace_range, replace_range_2):
3824 * insdel.c (make_gap_larger):
3825 * editfns.c (Finsert_char):
3826 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3828 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3830 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3832 Integer overflow and signedness fixes (Bug#8873).
3834 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3835 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3837 * fileio.c: Don't assume EMACS_INT fits in off_t.
3838 (emacs_lseek): New static function.
3839 (Finsert_file_contents, Fwrite_region): Use it.
3840 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3842 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3844 * fns.c: Don't overflow int when computing a list length.
3845 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3846 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3847 truncation on 64-bit hosts. Check for QUIT every
3848 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3849 faster and is responsive enough.
3850 (Flength): Report an error instead of overflowing an integer.
3851 (Fsafe_length): Return a float if the value is not representable
3852 as a fixnum. This shouldn't happen except in contrived situations.
3853 (Fnthcdr, Fsort): Don't assume list length fits in int.
3854 (Fcopy_sequence): Don't assume vector length fits in int.
3856 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3857 (header_size, word_size): New constants.
3858 (allocate_vectorlike): Don't check size overflow here.
3859 (allocate_vector): Check it here instead, since this is the only
3860 caller of allocate_vectorlike that could cause overflow.
3861 Check that the new vector's length is representable as a fixnum.
3863 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3864 The previous code was bogus. For example, next_almost_prime (32)
3865 returned 39, which is undesirable as it is a multiple of 3; and
3866 next_almost_prime (24) returned 25, which is a multiple of 5 so
3867 why was the code bothering to check for multiples of 7?
3869 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3871 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3873 Variadic C functions now count arguments with ptrdiff_t.
3874 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3875 Back then I didn't know that the Emacs coding style prefers signed int.
3876 Also, in the meantime I found a few more instances where arguments
3877 were being counted with int, which may truncate counts on 64-bit
3878 machines, or EMACS_INT, which may be unnecessarily wide.
3879 * lisp.h (struct Lisp_Subr.function.aMANY)
3880 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3881 Arg counts are now ptrdiff_t, not size_t.
3882 All variadic functions and their callers changed accordingly.
3883 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3884 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3885 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3886 * callint.c (Fcall_interactively): Check arg count for overflow,
3887 to avoid potential buffer overrun. Use signed char, not 'int',
3888 for 'varies' array, so that we needn't bother to check its size
3889 calculation for overflow.
3890 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3891 * eval.c (apply_lambda):
3892 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3893 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3894 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3896 * callint.c (Fcall_interactively): Don't use index var as event count.
3898 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3899 * mem-limits.h (SIZE): Remove; no longer used.
3901 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3903 Remove unnecessary casts.
3904 * xterm.c (x_term_init):
3905 * xfns.c (x_set_border_pixel):
3906 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3907 These aren't needed now that we assume ANSI C.
3909 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3910 It's more likely to cause problems (due to unsigned overflow)
3913 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3915 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3917 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3919 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3921 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3923 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3925 GLYPH_CODE_FACE returns EMACS_INT, not int.
3926 * dispextern.h (merge_faces):
3927 * xfaces.c (merge_faces):
3928 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3929 Don't assume EMACS_INT fits in int.
3931 * character.h (CHAR_VALID_P): Remove unused parameter.
3932 * fontset.c, lisp.h, xdisp.c: All uses changed.
3934 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3936 * fns.c (concat): Minor tuning based on overflow analysis.
3937 This doesn't fix any bugs. Use int to hold character, instead
3938 of constantly refetching from Emacs object. Use XFASTINT, not
3939 XINT, for value known to be a character. Don't bother comparing
3940 a single byte to 0400, as it's always less.
3942 * floatfns.c (Fexpt):
3943 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3945 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3948 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3950 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3951 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3952 incorrectly succeed when S was a string, because 4294967386 was
3953 truncated before it was used.
3955 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3956 Otherwise, an out-of-range integer could cause undefined behavior
3959 * composite.c: Use int, not EMACS_INT, for characters.
3960 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3961 EMACS_INT, for values that are known to be in character range.
3962 This doesn't fix any bugs but is the usual style inside Emacs and
3963 may generate better code on 32-bit machines.
3965 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3966 This is for reasons similar to the recent CHAR_STRING fix.
3967 * charset.c (Fencode_char): Check that character arg is actually
3968 a character. Pass an int to ENCODE_CHAR.
3969 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3970 wider than 'int', as a compile-time check to prevent future regressions
3973 * character.c (char_string): Remove unnecessary casts.
3975 Make sure a 64-bit char is never passed to CHAR_STRING.
3976 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3977 by silently ignoring the top 32 bits, allowing some values
3978 that were far too large to be valid characters.
3979 * character.h: Include <verify.h>.
3980 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3981 arguments are no wider than unsigned, as a compile-time check
3982 to prevent future regressions in this area.
3984 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3985 (Fsubst_char_in_region):
3987 * xdisp.c (decode_mode_spec_coding):
3988 Adjust to CHAR_STRING's new requirement.
3989 * editfns.c (Finsert_char, Fsubst_char_in_region):
3990 * fns.c (concat): Check that character args are actually
3991 characters. Without this test, these functions did the wrong
3992 thing with wildly out-of-range values on 64-bit hosts.
3994 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3995 These casts should not be needed on 32-bit hosts, either.
3996 * keyboard.c (read_char):
3997 * lread.c (Fload): Remove casts to unsigned.
3999 * lisp.h (UNSIGNED_CMP): New macro.
4000 This fixes comparison bugs on 64-bit hosts.
4001 (ASCII_CHAR_P): Use it.
4002 * casefiddle.c (casify_object):
4003 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4004 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4005 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4006 * dispextern.h (FACE_FROM_ID):
4007 * keyboard.c (read_char): Use UNSIGNED_CMP.
4009 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4010 not to EMACS_INT, to avoid GCC warning.
4012 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4014 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4015 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4016 isn't needed on 32-bit machines.
4018 * buffer.c (Fgenerate_new_buffer_name):
4019 Use EMACS_INT for count, not int.
4020 (advance_to_char_boundary): Return EMACS_INT, not int.
4022 * data.c (Qcompiled_function): Now static.
4024 * window.c (window_body_lines): Now static.
4026 * image.c (gif_load): Rename local to avoid shadowing.
4028 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4029 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4030 * alloc.c (make_save_value): Integer argument is now of type
4032 (mark_object): Use ptrdiff_t, not int.
4033 * lisp.h (pD): New macro.
4034 * print.c (print_object): Use it.
4036 * alloc.c: Use EMACS_INT, not int, to count objects.
4037 (total_conses, total_markers, total_symbols, total_vector_size)
4038 (total_free_conses, total_free_markers, total_free_symbols)
4039 (total_free_floats, total_floats, total_free_intervals)
4040 (total_intervals, total_strings, total_free_strings):
4041 Now EMACS_INT, not int. All uses changed.
4042 (Fgarbage_collect): Compute overall total using a double, so that
4043 integer overflow is less likely to be a problem. Check for overflow
4044 when converting back to an integer.
4045 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4046 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4047 These were 'int' variables that could overflow on 64-bit hosts;
4048 they were never used, so remove them instead of repairing them.
4049 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4050 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4051 Previously, this ceilinged at INT_MAX, but that doesn't work on
4053 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4055 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4056 (allocate_vectorlike): Check for ptrdiff_t overflow.
4057 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4058 when a (possibly-narrower) signed value would do just as well.
4059 We prefer using signed arithmetic, to avoid comparison confusion.
4061 * alloc.c: Catch some string size overflows that we were missing.
4062 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4063 for convenience in STRING_BYTES_MAX.
4064 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4065 The definition here is exact; the one in lisp.h was approximate.
4066 (allocate_string_data): Check for string overflow. This catches
4067 some instances we weren't catching before. Also, it catches
4068 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4069 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4070 and ptrdiff_t and EMACS_INT are both 64 bits.
4072 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4073 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4074 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4076 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4078 * alloc.c (Fmake_string): Check for out-of-range init.
4080 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4082 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4084 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4086 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4087 xg_get_default_scrollbar_width.
4089 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4090 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4091 (style_changed_cb): Call update_theme_scrollbar_width and call
4092 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4093 all frames (Bug#8505).
4094 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4095 Call gtk_window_set_resizable if HAVE_GTK3.
4096 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4097 and height if HAVE_GTK3 (Bug#8505).
4098 (scroll_bar_width_for_theme): New variable.
4099 (update_theme_scrollbar_width): New function.
4100 (xg_get_default_scrollbar_width): Move code to
4101 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4102 (xg_initialize): Call update_theme_scrollbar_width.
4104 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4106 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4108 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4110 * frame.c (make_frame): Call other_buffer_safely instead of
4113 * window.c (temp_output_buffer_show): Call display_buffer with
4114 second argument Vtemp_buffer_show_specifiers and reset latter
4115 immediately after the call.
4116 (Vtemp_buffer_show_specifiers): New variable.
4117 (auto_window_vscroll_p, next_screen_context_lines)
4118 (Vscroll_preserve_screen_position): Remove leading asterisks from
4121 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4123 Fix minor problems found by GCC 4.6.0 static checking.
4124 * buffer.c (Qclone_number): Remove for now, as it's unused.
4125 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4126 (record_buffer): Remove unused local.
4127 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4128 (set_frame_buffer_list): Remove; unused.
4129 * frame.h (other_visible_frames): Remove decl.
4130 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4131 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4132 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4134 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4135 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4136 Define only if HAVE_GPM.
4137 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4138 (update_hints_inhibit): Remove; never set. All uses removed.
4139 * widgetprv.h (emacsFrameClassRec): Remove decl.
4140 * window.c (delete_deletable_window): Now returns void, since it
4141 wasn't returning anything.
4142 (compare_window_configurations): Remove unused locals.
4143 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4144 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4145 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4146 the same widths as pointers. This follows up on the 2011-05-06 patch.
4147 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4148 * xterm.h: Likewise.
4149 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4151 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4153 * makefile.w32-in: Update dependencies.
4154 (LISP_H): Add lib/intprops.h.
4156 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4158 * image.c (gif_load): Add animation frame delay to the metadata.
4159 (syms_of_image): Use DEFSYM. New symbol `delay'.
4161 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4163 * window.c (delete_deletable_window): Re-add.
4164 (Fset_window_configuration): Rewrite to handle dead buffers and
4165 consequently deletable windows.
4166 (window_tree, Fwindow_tree): Remove. Supply functionality in
4168 (compare_window_configurations): Simplify code.
4170 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4172 * image.c (imagemagick_load_image): Fix type mismatch.
4173 (Fimagemagick_types): Likewise.
4175 * window.h (replace_buffer_in_windows): Declare.
4177 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4179 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4180 Qclone_number. Remove external declaration of Qdelete_window.
4181 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4183 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4184 Run Qbuffer_list_update_hook if allowed.
4185 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4186 buffer list implementation.
4187 (other_buffer_safely): New function.
4188 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4189 calls to replace_buffer_in_windows and
4190 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4192 (record_buffer): Inhibit quitting and rewrite using quittable
4193 functions. Run Qbuffer_list_update_hook if allowed.
4194 (Frecord_buffer, Funrecord_buffer): New functions.
4195 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4196 Move switch-to-buffer to window.el.
4197 (bury-buffer): Move to window.el.
4198 (Vbuffer_list_update_hook): New variable.
4200 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4203 * window.h (resize_frame_windows): Move up in code.
4204 (Fwindow_frame): Remove EXFUN.
4205 (replace_buffer_in_all_windows): Remove prototype.
4206 (replace_buffer_in_windows_safely): Add prototype.
4208 * window.c: Declare Qdelete_window static again. Move down
4209 declaration of select_count.
4210 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4211 (Fother_window): Move to window.el.
4212 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4213 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4214 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4216 (replace_buffer_in_windows): Implement by calling
4217 Qreplace_buffer_in_windows.
4218 (replace_buffer_in_all_windows): Remove with some functionality
4219 moved into replace_buffer_in_windows_safely.
4220 (replace_buffer_in_windows_safely): New function.
4221 (select_window_norecord, select_frame_norecord): Move in front
4222 of run_window_configuration_change_hook. Remove now obsolete
4224 (Fset_window_buffer): Rewrite doc-string.
4225 Call Qrecord_window_buffer.
4226 (keys_of_window): Move binding for other-window to window.el.
4228 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4230 * dispextern.h (struct image): Replace data member, whose int_val
4231 and ptr_val fields were not used by anything, with a single
4234 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4235 (gif_clear_image, gif_load, imagemagick_load_image)
4236 (gs_clear_image, gs_load): Callers changed.
4238 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4240 * buffer.h: Include <time.h>, for time_t.
4241 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4243 Fix minor problems found by static checking.
4245 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4247 Make identifiers static if they are not used in other modules.
4248 * data.c (Qcompiled_function, Qframe, Qvector):
4249 * image.c (QimageMagick, Qsvg):
4250 * minibuf.c (Qmetadata):
4251 * window.c (resize_window_check, resize_root_window): Now static.
4252 * window.h (resize_window_check, resize_root_window): Remove decls.
4254 * window.c (window_deletion_count, delete_deletable_window):
4256 (window_body_lines): Now static.
4257 (Fdelete_other_windows_internal): Mark vars as initialized.
4258 Make sure 'resize_failed' is initialized.
4259 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4260 (resize_window_apply): Remove unused local.
4261 * window.h (delete_deletable_window): Remove decl.
4263 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4264 (imagemagick_load_image): Fix pointer signedness problem by changing
4265 last arg from unsigned char * to char *. All uses changed.
4266 Also, fix a local for similar reasons.
4267 Remove unused locals. Remove locals to avoid shadowing.
4268 (fn_rsvg_handle_free): Remove; unused.
4269 (svg_load, svg_load_image): Fix pointer signedness problem.
4270 (imagemagick_load_image): Don't use garbage pointer image_wand.
4272 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4274 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4276 * image.c (gif_load): Fix omitted cast error introduced by
4279 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4281 * window.h (resize_proportionally, orig_total_lines)
4282 (orig_top_line): Remove from window structure.
4283 (set_window_height, set_window_width, change_window_heights)
4284 (Fdelete_window): Remove prototypes.
4285 (resize_frame_windows): Remove duplicate declaration.
4287 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4289 * window.h (resize_frame_windows, resize_window_check)
4290 (delete_deletable_window, resize_root_window)
4291 (resize_frame_windows): Declare prototypes.
4293 * window.c (resize_window_apply): Make definition be "static" to
4294 match the prototype.
4296 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4298 * window.c: Remove declarations of Qwindow_size_fixed,
4299 window_min_size_1, window_min_size_2, window_min_size,
4300 size_window, window_fixed_size_p, enlarge_window, delete_window.
4301 Remove static from declaration of Qdelete_window, it's
4302 temporarily needed by Fbury_buffer.
4303 (replace_window): Don't assign orig_top_line and
4305 (Fdelete_window, delete_window): Remove. Window deletion is
4306 handled by window.el.
4307 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4308 Replace Fdelete_window calls with calls to Qdelete_window.
4309 (Fdelete_other_windows): Remove. Deleting other windows is
4310 handled by window.el.
4311 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4312 handled in window.el.
4313 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4314 Window minimum sizes are handled in window.el.
4315 (shrink_windows, size_window, set_window_height)
4316 (set_window_width, change_window_heights, window_height)
4317 (window_width, CURBEG, CURSIZE, enlarge_window)
4318 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4319 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4320 handled in window.el.
4321 (make_dummy_parent): Rename to make_parent_window and give it a
4322 second argument horflag.
4323 (make_window): Don't set resize_proportionally any more.
4324 (Fsplit_window): Remove. Windows are split in window.el.
4325 (save_restore_action, save_restore_orig_size)
4326 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4327 Resize mini windows in window.el.
4328 (grow_mini_window, shrink_mini_window): Implement by calling
4329 Qresize_root_window_vertically, resize_window_check and
4330 resize_window_apply.
4331 (saved_window, Fset_window_configuration, save_window_save):
4332 Do not handle orig_top_line, orig_total_lines, and
4333 resize_proportionally.
4334 (window_min_height, window_min_width): Move to window.el.
4335 (keys_of_window): Move bindings for delete-other-windows,
4336 split-window, delete-window and enlarge-window to window.el.
4338 * buffer.c: Temporarily extern Qdelete_window.
4339 (Fbury_buffer): Temporarily call Qdelete_window instead of
4340 Fdelete_window (Fbury_buffer will move to window.el soon).
4342 * frame.c (set_menu_bar_lines_1): Remove code handling
4343 orig_top_line and orig_total_lines.
4345 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4346 set_window_height but set heights directly.
4347 (change_frame_size_1): Use resize_frame_windows.
4349 * xdisp.c (init_xdisp): Don't use set_window_height but set
4352 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4353 Use resize_frame_windows instead of change_window_heights and run
4354 run_window_configuration_change_hook.
4356 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4357 instead of change_window_heights and run
4358 run_window_configuration_change_hook.
4360 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4362 * window.c (replace_window): Rename second argument REPLACEMENT to
4363 NEW. New third argument SETFLAG. Rewrite.
4364 (delete_window, make_dummy_parent): Call replace_window with
4366 (window_list_1): Move down in code.
4367 (run_window_configuration_change_hook): Move set_buffer part
4368 before select_frame_norecord part in order to unwind correctly.
4369 Rename count1 to count.
4370 (recombine_windows, delete_deletable_window, resize_root_window)
4371 (Fdelete_other_windows_internal)
4372 (Frun_window_configuration_change_hook, make_parent_window)
4373 (resize_window_check, resize_window_apply, Fresize_window_apply)
4374 (resize_frame_windows, Fsplit_window_internal)
4375 (Fdelete_window_internal, Fresize_mini_window_internal):
4377 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4379 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4381 * window.h (window): Add some new members to window structure -
4382 normal_lines, normal_cols, new_total, new_normal, clone_number,
4383 splits, nest, prev_buffers, next_buffers.
4384 (WINDOW_TOTAL_SIZE): Move here from window.c.
4385 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4387 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4389 (make_dummy_parent): Set new members of windows structure.
4390 (make_window): Move down in code. Handle new members of window
4392 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4393 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4394 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4395 (Fset_window_prev_buffers, Fwindow_next_buffers)
4396 (Fset_window_next_buffers, Fset_window_clone_number):
4398 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4399 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4401 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4402 Argument WINDOW can be now internal window too.
4403 (Fwindow_use_time): Move up in code.
4404 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4406 (Fset_window_configuration, saved_window)
4407 (Fcurrent_window_configuration, save_window_save): Handle new
4408 members of window structure.
4409 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4410 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4411 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4412 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4413 Qget_mru_window, Qresize_root_window,
4414 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4415 Qauto_buffer_name; staticpro them.
4417 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4419 * window.c (Fwindow_total_size, Fwindow_left_column)
4420 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4421 (Fwindow_list_1): New functions.
4422 (window_box_text_cols): Replace with window_body_cols.
4423 (Fwindow_width, Fscroll_left, Fscroll_right):
4424 Use window_body_cols instead of window_box_text_cols.
4425 (delete_window, Fset_window_configuration):
4426 Call delete_all_subwindows with window as argument.
4427 (delete_all_subwindows): Take a window as argument and not a
4429 (window_loop): Remove handling of GET_LRU_WINDOW and
4431 (Fget_lru_window, Fget_largest_window): Move to window.el.
4433 * window.h: Extern window_body_cols instead of
4434 window_box_text_cols. delete_all_subwindows now takes a
4435 Lisp_Object as argument.
4437 * indent.c (compute_motion, Fcompute_motion):
4438 Use window_body_cols instead of window_box_text_cols.
4440 * frame.c (delete_frame): Call delete_all_subwindows with root
4443 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4445 * fns.c (Fputhash): Document return value.
4447 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4449 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4451 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4453 Cons<->int and similar integer overflow fixes (Bug#8794).
4455 Check for overflow when converting integer to cons and back.
4456 * charset.c (Fdefine_charset_internal, Fdecode_char):
4457 Use cons_to_unsigned to catch overflow.
4458 (Fencode_char): Use INTEGER_TO_CONS.
4459 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4460 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4461 * data.c (long_to_cons, cons_to_long): Remove.
4462 (cons_to_unsigned, cons_to_signed): New functions.
4463 These signal an error for invalid or out-of-range values.
4464 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4465 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4466 * font.c (Ffont_variation_glyphs):
4467 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4468 * lisp.h: Include <intprops.h>.
4469 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4470 (cons_to_signed, cons_to_unsigned): New decls.
4471 (long_to_cons, cons_to_long): Remove decls.
4472 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4473 (Fprimitive_undo): Use CONS_TO_INTEGER.
4474 * xfns.c (Fx_window_property): Likewise.
4475 * xselect.c: Include <limits.h>.
4476 (x_own_selection, selection_data_to_lisp_data):
4477 Use INTEGER_TO_CONS.
4478 (x_handle_selection_request, x_handle_selection_clear)
4479 (x_get_foreign_selection, Fx_disown_selection_internal)
4480 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4481 (lisp_data_to_selection_data): Use cons_to_unsigned.
4482 (x_fill_property_data): Use cons_to_signed.
4483 Report values out of range.
4485 Check for buffer and string overflow more precisely.
4486 * buffer.h (BUF_BYTES_MAX): New macro.
4487 * lisp.h (STRING_BYTES_MAX): New macro.
4488 * alloc.c (Fmake_string):
4489 * character.c (string_escape_byte8):
4490 * coding.c (coding_alloc_by_realloc):
4491 * doprnt.c (doprnt):
4492 * editfns.c (Fformat):
4494 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4495 since they may not be the same number.
4496 * editfns.c (Finsert_char):
4497 * fileio.c (Finsert_file_contents):
4498 Likewise for BUF_BYTES_MAX.
4500 * image.c: Use ptrdiff_t, not int, for sizes.
4501 (slurp_file): Switch from int to ptrdiff_t.
4503 (slurp_file): Check that file size fits in both size_t (for
4504 malloc) and ptrdiff_t (for sanity and safety).
4506 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4507 if b->modtime has its maximal value.
4509 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4511 Don't assume time_t can fit into int.
4512 * buffer.h (struct buffer.modtime): Now time_t, not int.
4513 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4514 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4516 Minor fixes for signed vs unsigned integers.
4517 * character.h (MAYBE_UNIFY_CHAR):
4518 * charset.c (maybe_unify_char):
4519 * keyboard.c (read_char, reorder_modifiers):
4520 XINT -> XFASTINT, since the integer must be nonnegative.
4521 * ftfont.c (ftfont_spec_pattern):
4522 * keymap.c (access_keymap, silly_event_symbol_error):
4523 XUINT -> XFASTINT, since the integer must be nonnegative.
4524 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4525 since it makes no difference and we prefer signed.
4526 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4527 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4530 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4532 * window.h (Fwindow_frame): Declare.
4534 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4536 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4537 (SPARE_MEMORY): Always define.
4538 (LARGE_REQUEST): Remove.
4539 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4541 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4543 * lisp.h: Move EXFUNS for Fframe_root_window,
4544 Fframe_first_window and Fset_frame_selected_window to window.h.
4546 * window.h: Move EXFUNS for Fframe_root_window,
4547 Fframe_first_window and Fset_frame_selected_window here from
4550 * frame.c (Fwindow_frame, Fframe_first_window)
4551 (Fframe_root_window, Fframe_selected_window)
4552 (Fset_frame_selected_window): Move to window.c.
4553 (Factive_minibuffer_window): Move to minibuf.c.
4554 (Fother_visible_frames_p): New function.
4556 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4558 * window.c (decode_window, decode_any_window): Move up in code.
4559 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4560 (inhibit_frame_unsplittable): Remove unused variable.
4561 (Fwindow_buffer): Move up and rewrite doc-string.
4562 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4563 (Fwindow_prev): New functions.
4564 (Fwindow_frame): Move here from frame.c. Accept any window as
4566 (Fframe_root_window, Fframe_first_window)
4567 (Fframe_selected_window): Move here from frame.c. Accept frame
4568 or arbitrary window as argument. Update doc-strings.
4569 (Fminibuffer_window): Move up in code.
4570 (Fwindow_minibuffer_p): Move up in code and simplify.
4571 (Fset_frame_selected_window): Move here from frame.c.
4573 (Fselected_window, select_window, Fselect_window): Move up in
4574 code. Minor doc-string fixes.
4576 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4578 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4579 Do not assume that spare memory exists; that assumption is valid
4580 only if SYSTEM_MALLOC.
4581 (LARGE_REQUEST): New macro, so that the issue of large requests
4582 is separated from the issue of spare memory.
4584 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4586 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4589 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4591 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4594 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4596 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4598 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4600 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4601 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4603 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4605 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4607 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4609 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4610 (x_clipboard_manager_save): Add return value.
4611 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4613 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4614 Obey Vx_select_enable_clipboard_manager. Catch errors in
4615 x_clipboard_manager_save (Bug#8779).
4616 (Vx_select_enable_clipboard_manager): New variable.
4617 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4619 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4621 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4623 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4625 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4626 in the current matrix if keep_current_p is non-zero.
4628 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4630 * bidi.c (bidi_level_of_next_char): Fix last change.
4632 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4634 Support bidi reordering of text covered by display properties.
4636 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4637 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4638 (bidi_cache_search, bidi_cache_iterator_state)
4639 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4640 (bidi_level_of_next_char, bidi_move_to_visually_next):
4641 Support character positions inside a run of characters covered by a
4643 (bidi_paragraph_init, bidi_resolve_explicit_1)
4644 (bidi_level_of_next_char): Call bidi_fetch_char and
4645 bidi_fetch_char_advance instead of FETCH_CHAR and
4647 (bidi_init_it): Initialize new members.
4648 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4650 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4651 instead of using explicit *_CHAR codes.
4652 (bidi_resolve_explicit, bidi_resolve_weak):
4653 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4654 bidirectional text is supported only in multibyte buffers.
4655 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4656 it to initialize the frame_window_p member of struct bidi_it.
4657 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4658 (bidi_resolve_explicit, bidi_resolve_weak)
4659 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4660 bidi_it->nchars is non-positive.
4661 (bidi_level_of_next_char): Don't try to lookup the cache for the
4662 next/previous character if nothing is cached there yet, or if we
4663 were just reseat()'ed to a new position.
4665 * xdisp.c (set_cursor_from_row): Set start and stop points
4666 according to the row's direction when priming the loop that looks
4667 for the glyph on which to display cursor.
4668 (single_display_spec_intangible_p): Function deleted.
4669 (display_prop_intangible_p): Reimplement to call
4670 handle_display_spec instead of single_display_spec_intangible_p.
4671 Accept 3 additional arguments needed by handle_display_spec.
4672 This fixes incorrect cursor motion across display property with complex
4673 values: lists, `(when COND...)' forms, etc.
4674 (single_display_spec_string_p): Support property values that are
4675 lists with the argument STRING its top-level element.
4676 (display_prop_string_p): Fix the condition for processing a
4677 property that is a list to be consistent with handle_display_spec.
4678 (handle_display_spec): New function, refactored from the
4679 last portion of handle_display_prop.
4680 (compute_display_string_pos): Accept additional argument
4681 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4682 value of a `display' property is a "replacing spec".
4683 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4684 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4685 the display property, but just return a value indicating whether
4686 the display property will replace the characters it covers.
4687 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4688 frame_window_p members of struct bidi_it.
4689 (compute_display_string_pos, compute_display_string_end):
4691 (push_it): Accept second argument POSITION, where pop_it should
4692 jump to continue iteration.
4693 (reseat_1): Initialize bidi_it.disp_pos.
4695 * keyboard.c (adjust_point_for_property): Adjust the call to
4696 display_prop_intangible_p to its new signature.
4698 * dispextern.h (struct bidi_it): New member frame_window_p.
4699 (bidi_init_it): Update prototypes.
4700 (display_prop_intangible_p): Update prototype.
4701 (compute_display_string_pos, compute_display_string_end):
4703 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4706 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4708 Malloc failure behavior now depends on size of allocation.
4709 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4710 * lisp.h: Change signatures accordingly.
4711 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4712 All callers changed. (Bug#8762)
4714 * gnutls.c: Use Emacs's memory allocators.
4715 Without this change, the gnutls library would invoke malloc etc.
4716 directly, which causes problems on non-SYNC_INPUT hosts, and which
4717 runs afoul of improving memory_full behavior. (Bug#8761)
4718 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4719 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4720 xfree instead of the default malloc, realloc, free.
4721 (Fgnutls_boot): No need to check for memory allocation failure,
4722 since xmalloc does that for us.
4724 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4725 * category.c (hash_get_category_set):
4726 * ccl.c (ccl_driver):
4727 * charset.c (Fdefine_charset_internal):
4728 * charset.h (struct charset.hash_index):
4729 * composite.c (get_composition_id, gstring_lookup_cache)
4730 (composition_gstring_put_cache):
4731 * composite.h (struct composition.hash_index):
4732 * dispextern.h (struct image.hash):
4733 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4734 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4735 (hashfn_equal, hashfn_user_defined, make_hash_table)
4736 (maybe_resize_hash_table, hash_lookup, hash_put)
4737 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4738 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4739 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4740 * image.c (make_image, search_image_cache, lookup_image)
4741 (xpm_put_color_table_h):
4742 * lisp.h (struct Lisp_Hash_Table):
4743 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4744 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4745 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4746 * alloc.c (allocate_vectorlike):
4747 Check for overflow in vector size calculations.
4748 * ccl.c (ccl_driver):
4749 Check for overflow when converting EMACS_INT to int.
4750 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4751 need to be updated by these changes.
4752 * fns.c (make_hash_table, maybe_resize_hash_table):
4753 Check for integer overflow with large hash tables.
4754 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4755 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4756 (SXHASH_REDUCE): New macro.
4757 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4758 Use it instead of discarding useful hash info with large hash values.
4759 (sxhash_float): New function.
4760 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4761 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4762 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4763 Rewrite to use FIXNUM_BITS, as this simplifies things.
4764 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4765 Adjust signatures to match updated version of code.
4766 (consing_since_gc): Now EMACS_INT, since a single hash table can
4767 use more than INT_MAX bytes.
4769 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4771 Make it possible to build with GCC-4.6+ -O2 -flto.
4773 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4775 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4777 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4778 Call minibuffer-inactive-mode.
4780 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4782 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4783 Update dependencies.
4785 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4787 * data.c (init_data): Remove code for UTS, this system is not
4790 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4792 Don't force ./temacs to start in terminal mode.
4794 * frame.c (make_initial_frame): Initialize faces in all cases, not
4795 only when CANNOT_DUMP is defined.
4796 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4798 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4800 * dispnew.c (add_window_display_history): Use const for the string
4801 pointer. Remove declaration, not needed.
4803 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4805 Use 'inline', not 'INLINE'.
4806 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4807 * alloc.c, fontset.c (INLINE): Remove.
4808 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4809 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4810 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4811 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4812 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4814 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4816 Make it possible to run ./temacs.
4818 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4819 syms_of_callproc does the same thing. Remove test for
4820 "initialized", do it in the caller.
4821 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4823 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4825 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4826 (read_minibuf): Use get_minibuffer.
4827 (syms_of_minibuf): Use DEFSYM.
4828 (Qmetadata): New var.
4829 * data.c (Qbuffer): Don't make it static.
4830 (syms_of_data): Use DEFSYM.
4832 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4834 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4835 (CCL_CODE_MIN): New macro.
4837 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4839 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4841 * eval.c (Qdebug): Now static.
4842 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4843 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4844 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4846 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4848 * image.c: Various fixes to ImageMagick code comments.
4849 (Fimagemagick_types): Doc fix.
4851 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4853 Minor fixes prompted by GCC 4.6.0 warnings.
4855 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4857 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4858 (x_clipboard_manager_save_all): Move extern decl to ...
4859 * xterm.h: ... here, so that it can be checked for consistency.
4861 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4863 * xselect.c (x_clipboard_manager_save_frame)
4864 (x_clipboard_manager_save_all): New functions.
4865 (Fx_clipboard_manager_save): Lisp function deleted.
4867 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4868 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4870 * xterm.h: Update prototype.
4872 2011-05-28 William Xu <william.xwl@gmail.com>
4874 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4877 2011-05-28 Jim Meyering <meyering@redhat.com>
4879 Avoid a sign-extension bug in crypto_hash_function.
4880 * fns.c (to_uchar): Define.
4881 (crypto_hash_function): Use it to convert some newly-signed
4882 variables to unsigned, to avoid sign-extension bugs. For example,
4883 without this change, (md5 "truc") would evaluate to
4884 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4885 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4886 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4888 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4890 Integer overflow fixes.
4892 * dbusbind.c: Serial number integer overflow fixes.
4893 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4894 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4895 to hold a serial number that is too large for a fixnum.
4896 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4897 Check for serial numbers out of range. Decode any serial number
4898 that was so large that it became a float. (Bug#8722)
4900 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4901 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4902 Use XFASTINT rather than XUINT when numbers are nonnegative.
4903 (xd_append_arg, Fdbus_method_return_internal):
4904 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4905 arguments, check that Lisp number is nonnegative, rather than
4906 silently wrapping negative numbers around. (Bug#8722)
4907 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4910 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4912 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4914 ccl: add integer overflow checks
4915 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4916 (IN_INT_RANGE): New macros.
4917 (ccl_driver): Use them to check for integer overflow when
4918 decoding a CCL program. Many of the new checks are whether XINT (x)
4919 fits in int; it doesn't always, on 64-bit hosts. The new version
4920 doesn't catch all possible integer overflows, but it's an
4921 improvement. (Bug#8719)
4923 * alloc.c (make_event_array): Use XINT, not XUINT.
4924 There's no need for unsigned here.
4926 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4927 This follows up to the 2011-05-06 change that substituted uintptr_t
4928 for EMACS_INT. This case wasn't caught back then.
4930 Rework Fformat to avoid integer overflow issues.
4931 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4932 now (part of C89). Include <verify.h>.
4933 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4934 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4935 (Fformat): Avoid the prepass trying to compute sizes; it was only
4936 approximate and thus did not catch overflow reliably. Instead, walk
4937 through the format just once, formatting and computing sizes as we go,
4938 checking for integer overflow at every step, and allocating a larger
4939 buffer as needed. Keep track separately whether the format is
4940 multibyte. Keep only the most-recently calculated precision, rather
4941 than them all. Record whether each argument has been converted to
4942 string. Use EMACS_INT, not int, for byte and char and arg counts.
4943 Support field widths and precisions larger than INT_MAX. Avoid
4944 sprintf's undefined behavior with conversion specifications such as %#d
4945 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4946 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4947 formatting out-of-range floating point numbers with int
4950 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4952 * data.c: Avoid integer truncation in expressions involving floats.
4953 * data.c: Include <intprops.h>.
4954 (arith_driver): When there's an integer overflow in an expression
4955 involving floating point, convert the integers to floating point
4956 so that the resulting value does not suffer from catastrophic
4957 integer truncation. For example, on a 64-bit host (* 4
4958 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4959 Do not rely on undefined behavior after integer overflow.
4961 merge count_size_as_multibyte, parse_str_to_multibyte
4962 * character.c, character.h (count_size_as_multibyte):
4963 Rename from parse_str_to_multibyte; all uses changed.
4964 Check for integer overflow.
4965 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4966 since it's now a duplicate of the other. This is more of
4967 a character than a buffer op, so better that it's in character.c.
4968 * fns.c, print.c: Adjust to above changes.
4970 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4972 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4974 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4976 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4977 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4978 (x_clipboard_manager_save): Now static.
4979 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4981 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4982 (crypto_hash_function): Now static.
4983 Fix pointer signedness problems. Avoid unnecessary initializations.
4985 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4987 * termhooks.h (Vselection_alist): Make it terminal-local.
4989 * terminal.c (create_terminal): Initialize it.
4991 * xselect.c: Support for clipboard managers.
4992 (Vselection_alist): Move to termhooks.h as terminal-local var.
4993 (LOCAL_SELECTION): New macro.
4994 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4995 (symbol_to_x_atom): Remove gratuitous arg.
4996 (x_handle_selection_request, lisp_data_to_selection_data)
4997 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4998 (x_own_selection, x_get_local_selection, x_convert_selection):
4999 New arg, specifying work frame. Use terminal-local Vselection_alist.
5000 (some_frame_on_display): Delete unused function.
5001 (Fx_own_selection_internal, Fx_get_selection_internal)
5002 (Fx_disown_selection_internal, Fx_selection_owner_p)
5003 (Fx_selection_exists_p): New optional frame arg.
5004 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5005 (x_handle_selection_clear): Don't treat other terminals with the
5006 same keyboard specially. Use the terminal-local Vselection_alist.
5007 (x_clear_frame_selections): Use Frun_hook_with_args.
5009 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5011 * xterm.h: Add support for those atoms.
5013 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5015 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5016 (converted_selections, conversion_fail_tag): New global variables.
5017 (x_selection_request_lisp_error): Free the above.
5018 (x_get_local_selection): Remove unnecessary code.
5019 (x_reply_selection_request): Args changed; handle arbitrary array
5020 of converted selections stored in converted_selections.
5021 Separate the XChangeProperty and SelectionNotify steps.
5022 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5023 (x_convert_selection): New function.
5024 (x_handle_selection_event): Simplify.
5025 (x_get_foreign_selection): Don't ignore incoming requests while
5026 waiting for an answer; this will fail when we implement
5027 SAVE_TARGETS, and seems unnecessary anyway.
5028 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5029 (Vx_sent_selection_functions): Doc fix.
5031 2011-05-26 Leo Liu <sdl.web@gmail.com>
5033 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5035 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5037 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5039 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5040 for fringe update if it has periodic bitmap.
5041 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5042 and fringe_bitmap_periodic_p.
5044 * fringe.c (get_fringe_bitmap_data): New function.
5045 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5046 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5047 row. Mark glyph row for fringe update if periodicity changed.
5049 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5050 for fringe update unless it has periodic bitmap.
5052 2011-05-25 Kenichi Handa <handa@m17n.org>
5054 * xdisp.c (get_next_display_element): Set correct it->face_id for
5055 a static composition.
5057 2011-05-24 Leo Liu <sdl.web@gmail.com>
5060 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5062 * fns.c (crypto_hash_function, Fsha1): New function.
5063 (Fmd5): Use crypto_hash_function.
5064 (syms_of_fns): Add Ssha1.
5066 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5068 * gnutls.c: Remove unused macros.
5069 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5070 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5071 Remove macros that are defined and never used.
5072 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5074 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5076 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5077 (Fx_get_selection_internal): Minor cleanup.
5078 (Fx_own_selection_internal): Rename arguments for consistency with
5081 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5083 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5085 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5087 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5089 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5091 * dispnew.c (scrolling_window): Don't exclude the case that the
5092 last enabled row in the desired matrix touches the bottom boundary.
5094 2011-05-21 Glenn Morris <rgm@gnu.org>
5096 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5097 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5098 and add some more files.
5100 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5102 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5103 report_file_error introduced by the change from 2011-05-07.
5105 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5107 * systime.h (Time): Define only if emacs is defined.
5108 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5109 where the include path doesn't have X11/X.h by default. See
5110 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5112 2011-05-20 Kenichi Handa <handa@m17n.org>
5114 * composite.c (find_automatic_composition): Fix previous change.
5116 2011-05-20 Glenn Morris <rgm@gnu.org>
5118 * lisp.mk: New file, split from Makefile.in.
5119 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5120 (shortlisp): Remove.
5121 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5123 2011-05-19 Glenn Morris <rgm@gnu.org>
5125 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5126 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5127 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5128 (lisp): Set the order to that of loadup.el.
5129 (shortlisp): Make it a copy of $lisp.
5130 (SOME_MACHINE_LISP): Remove.
5131 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5132 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5134 2011-05-18 Kenichi Handa <handa@m17n.org>
5136 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5137 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5138 (find_automatic_composition): Mostly rewrite for efficiency.
5140 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5142 * makefile.w32-in: Update dependencies.
5144 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5146 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5147 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5149 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5151 Fix some integer overflow issues, such as string length overflow.
5153 * insdel.c (count_size_as_multibyte): Check for string overflow.
5155 * character.c (lisp_string_width): Check for string overflow.
5156 Use EMACS_INT, not int, for string indexes and lengths; in
5157 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5158 the resulting string length overflows an EMACS_INT; instead,
5159 report a string overflow if no precision given. When checking for
5160 precision exhaustion, use a check that cannot possibly have
5161 integer overflow. (Bug#8675)
5162 * character.h (lisp_string_width): Adjust to new signature.
5164 * alloc.c (string_overflow): New function.
5165 (Fmake_string): Use it. This doesn't change behavior, but saves
5166 a few bytes and will simplify future changes.
5167 * character.c (string_escape_byte8): Likewise.
5168 * lisp.h (string_overflow): New decl.
5170 Fixups, following up to the user-interface timestamp change.
5171 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5172 for UI timestamps, instead of unsigned long.
5173 * msdos.c (mouse_get_pos): Likewise.
5174 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5175 * w32gui.h (Time): Define by including "systime.h" rather than by
5176 declaring it ourselves. (Bug#8664)
5178 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5179 * image.c (clear_image_cache): Likewise.
5181 * term.c (term_mouse_position): Don't assume time_t wraparound.
5183 Be more systematic about user-interface timestamps.
5184 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5185 and sometimes 'EMACS_UINT', to represent these timestamps.
5186 This change causes it to use 'Time' uniformly, as that's what X uses.
5187 This makes the code easier to follow, and makes it easier to catch
5188 integer overflow bugs such as Bug#8664.
5189 * frame.c (Fmouse_position, Fmouse_pixel_position):
5190 Use Time, not unsigned long, for user-interface timestamps.
5191 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5192 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5193 * keyboard.h (last_event_timestamp): Likewise.
5194 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5195 * menu.h (xmenu_show): Likewise.
5196 * term.c (term_mouse_position): Likewise.
5197 * termhooks.h (struct input_event.timestamp): Likewise.
5198 (struct terminal.mouse_position_hook): Likewise.
5199 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5200 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5201 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5202 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5204 * menu.h, termhooks.h: Include "systime.h", for Time.
5206 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5207 Don't assume that the difference between two unsigned long values
5208 can fit into an integer. At this point, we know button_down_time
5209 <= event->timestamp, so the difference must be nonnegative, so
5210 there's no need to cast the result if double-click-time is
5211 nonnegative, as it should be; check that it's nonnegative, just in
5212 case. This bug is triggered when events are more than 2**31 ms
5213 apart (about 25 days). (Bug#8664)
5215 * xselect.c (last_event_timestamp): Remove duplicate decl.
5216 (x_own_selection): Remove needless cast to unsigned long.
5218 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5219 that always fit in int. Use a sentinel instead of a counter, to
5220 avoid a temp and to allay GCC's concerns about possible int overflow.
5221 * frame.h (struct frame): Use int for menu_bar_items_used
5222 instead of EMACS_INT, since it always fits in int.
5224 * menu.c (grow_menu_items): Check for int overflow.
5226 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5228 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5229 Before, the code was not consistent. These values cannot exceed
5230 2**31 - 1 so there's no need to make them unsigned.
5231 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5232 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5233 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5235 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5237 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5238 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5239 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5240 presumably because the widths might not match.
5242 * window.c (size_window): Avoid needless test at loop start.
5244 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5246 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5248 2011-05-12 Drew Adams <drew.adams@oracle.com>
5250 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5252 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5254 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5255 `width' to `bar_area_x' and `bar_area_width', respectively.
5256 (x_scroll_run): Take account of fringe background extension.
5258 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5259 Rename local vars `left' and `width' to `bar_area_x' and
5260 `bar_area_width', respectively.
5261 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5262 background extension.
5264 2011-05-10 Jim Meyering <meyering@redhat.com>
5266 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5268 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5270 * image.c (Finit_image_library): Return t for built-in image types,
5271 like pbm and xbm. (Bug#8640)
5273 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5275 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5277 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5279 * w32console.c (Fset_screen_color): Doc fix.
5280 (Fget_screen_color): New function.
5281 (syms_of_ntterm): Defsubr it.
5283 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5284 unlink the temporary file if Fcall_process didn't create it in the
5286 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5287 child process will be redirected to a file specified with `:file'.
5288 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5289 cue to call_process_cleanup not to close that handle.
5291 2011-05-07 Ben Key <bkey76@gmail.com>
5293 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5294 one of two shell specific rules, either bootstrap-temacs-CMD or
5295 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5296 to the previous implementation of the bootstrap-temacs rule.
5297 The bootstrap-temacs-CMD rule is similar to the previous
5298 implementation of the bootstrap-temacs rule except that it
5299 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5302 These changes, along with some changes to nt/configure.bat,
5303 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5304 earlier fix to add support for --cflags and --ldflags options
5305 that include quotes so that it works whether make uses cmd or
5308 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5310 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5311 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5313 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5314 a string. Handle both cases.
5315 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5316 (Fdbus_register_method): Use Qinvalid_function.
5318 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5320 * makefile.w32-in: Update dependencies.
5321 (LISP_H): Add inttypes.h and stdin.h.
5322 (PROCESS_H): Add unistd.h.
5324 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5326 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5327 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5329 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5331 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5333 * term.c (vfatal): Remove stray call to va_end.
5334 It's not needed and the C Standard doesn't allow it here anyway.
5336 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5337 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5339 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5342 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5344 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5346 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5348 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5350 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5352 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5353 * charset.c (Fdefine_charset_internal): Don't initialize
5354 charset.code_space[15]. The value was garbage, on hosts with
5355 32-bit int (Bug#8600).
5357 * lread.c (read_integer): Be more consistent with string-to-number.
5358 Use string_to_number to do the actual conversion; this avoids
5359 rounding errors and fixes some other screwups. Without this fix,
5360 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5361 (digit_to_number): Move earlier, for benefit of read_integer.
5362 Return -1 if the digit is out of range for the base, -2 if it is
5363 not a digit in any supported base. (Bug#8602)
5365 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5367 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5368 to match comment at start of function. This also removes a
5369 GCC warning about overflow in a 32+64-bit port.
5371 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5373 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5374 Reported by Stefan Monnier in
5375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5376 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5377 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5379 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5380 (EMACS_UINTPTR): Likewise, with uintptr_t.
5382 * lisp.h: Prefer 64-bit EMACS_INT if available.
5383 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5384 on 32-bit hosts that have 64-bit int, so that they can access
5386 However, temporarily disable this change unless the temporary
5387 symbol WIDE_EMACS_INT is defined.
5389 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5391 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5392 This removes an assumption that EMACS_INT and long are the same
5393 width as pointers. The assumption is true for Emacs porting targets
5394 now, but we want to make other targets possible.
5395 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5396 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5397 In the rest of the code, change types of integers that hold casted
5398 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5399 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5400 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5401 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5402 No need to cast type when ORing.
5403 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5404 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5405 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5406 assume EMACS_INT is the same width as char *.
5407 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5408 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5409 Remove no-longer-needed casts.
5410 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5411 (xg_tool_bar_help_callback, xg_make_tool_item):
5412 Use EMACS_INTPTR to hold an integer
5413 that will be cast to void *; this can avoid a GCC warning
5414 if EMACS_INT is not the same width as void *.
5415 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5416 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5417 (current_message_1, set_message_1):
5418 Use a local to convert to proper width without a cast.
5419 * xmenu.c (dialog_selection_callback): Likewise.
5421 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5422 Also, don't assume VALBITS / RAND_BITS is less than 5,
5423 and don't rely on undefined behavior when shifting a 1 left into
5425 * lisp.h (get_random): Change signature to match.
5427 * lread.c (hash_string): Use size_t, not int, for hash computation.
5428 Normally we prefer signed values; but hashing is special, because
5429 it's better to use unsigned division on hash table sizes so that
5430 the remainder is nonnegative. Also, size_t is the natural width
5431 for hashing into memory. The previous code used 'int', which doesn't
5432 retain enough info to hash well into very large tables.
5433 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5435 * dbusbind.c: Don't possibly lose pointer info when converting.
5436 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5437 Use XPNTR rather than XHASH, so that the high-order bits of
5438 the pointer aren't lost when converting through void *.
5440 * eval.c (Fautoload): Don't double-shift a pointer.
5442 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5444 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5446 * gnutls.c (DEF_GNUTLS_FN):
5447 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5449 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5451 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5454 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5456 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5457 New version that can reserve upto 2GB of heap space.
5459 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5461 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5463 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5465 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5466 `gnutls_certificate_set_x509_key_file'.
5468 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5470 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5471 Update dependencies.
5473 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5475 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5476 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5477 Remove unused parameter `fildes'.
5478 * process.c (read_process_output, send_process): Don't pass it.
5480 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5482 Fix previous change: the library cache is defined in w32.c.
5483 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5484 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5486 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5488 Implement dynamic loading of GnuTLS on Windows.
5490 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5491 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5492 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5495 * gnutls.c (Qgnutls_dll): Define.
5496 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5497 (gnutls_*): Declare function pointers.
5498 (init_gnutls_functions): New function to initialize function pointers.
5499 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5500 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5501 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5502 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5503 (emacs_gnutls_write, emacs_gnutls_read)
5504 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5505 (Fgnutls_available_p): New function.
5506 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5507 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5508 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5510 * image.c: Include w32.h.
5511 (Vimage_type_cache): Delete.
5512 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5513 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5514 (w32_delayed_load): Move to w32.c.
5516 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5518 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5519 (w32_delayed_load): Move from image.c. When loading a library, record
5520 its filename in the :loaded-from property of the library id.
5521 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5522 Initialize and staticpro them.
5523 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5525 * process.c: Include lisp.h before w32.h, not after.
5526 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5527 instead of gnutls_record_check_pending.
5529 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5531 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5533 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5534 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5537 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5539 * xterm.c (x_set_frame_alpha): Do not set property on anything
5540 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5542 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5544 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5546 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5548 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5549 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5550 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5551 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5552 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5553 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5554 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5555 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5556 (Qgnutls_bootprop_callbacks_verify): Make static.
5558 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5560 * callproc.c: Indentation fixup.
5562 * sysdep.c (wait_for_termination_1): Make static.
5563 (wait_for_termination, interruptible_wait_for_termination):
5564 Move after wait_for_termination_1.
5566 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5568 * sysdep.c (interruptible_wait_for_termination): New function
5569 which is like wait_for_termination, but allows keyboard
5572 * callproc.c (Fcall_process): Add (:file "file") as an option for
5574 (Fcall_process_region): Ditto.
5576 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5578 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5579 rather than `XVECTOR (FOO)->size'.
5581 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5582 inttypes.h, as a gnulib replacement is used if it not available in
5585 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5587 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5588 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5589 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5591 * coding.c (coding_alloc_by_realloc): Error out if destination
5592 will grow beyond MOST_POSITIVE_FIXNUM.
5593 (decode_coding_emacs_mule): Abort if there isn't enough place in
5594 charbuf for the composition carryover bytes. Reserve an extra
5595 space for up to 2 characters produced in a loop.
5596 (decode_coding_iso_2022): Abort if there isn't enough place in
5597 charbuf for the composition carryover bytes.
5599 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5601 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5602 aborting when %lld or %lll format is passed.
5603 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5604 %llo or %llx format is passed. (Bug#8545)
5606 * window.c (window_scroll_line_based): Use a marker instead of
5607 simple variables to record original value of point. (Bug#7952)
5609 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5610 produced by %s or %c overflows available buffer space. (Bug#8545)
5612 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5614 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5615 (SIZE_MAX): Move defn after all includes, as they might #define it.
5617 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5619 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5621 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5623 * keyboard.c (Qdelayed_warnings_hook): Define.
5624 (command_loop_1): Run `delayed-warnings-hook'
5625 if Vdelayed_warnings_list is non-nil.
5626 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5627 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5629 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5631 * doprnt.c (doprnt): Don't return value smaller than the buffer
5632 size if the message was truncated. (Bug#8545).
5634 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5636 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5637 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5639 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5641 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5643 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5645 * makefile.w32-in: Update dependencies.
5647 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5649 Improve `doprnt' and its usage. (Bug#8545)
5650 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5651 `format_end'. Remove support for %l as a conversion specifier.
5652 Don't use xrealloc. Improve diagnostics when the %l size modifier
5653 is used. Update the commentary.
5655 * eval.c (verror): Simplify calculation of size_t.
5657 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5660 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5662 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5665 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5667 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5668 This makes this file independent of the recent pseudovector change.
5670 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5672 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5674 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5675 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5676 Remove unused local.
5677 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5679 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5680 GCC 4.6.0 optimizes based on type-based alias analysis.
5681 For example, if b is of type struct buffer * and v of type struct
5682 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5683 != &v->size, and therefore "v->size = 1; b->size = 2; return
5684 v->size;" must therefore return 1. This assumption is incorrect
5685 for Emacs, since it type-puns struct Lisp_Vector * with many other
5686 types. To fix this problem, this patch adds a new type struct
5687 vectorlike_header that documents the constraints on layout of vectors
5688 and pseudovectors, and helps optimizing compilers not get fooled
5689 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5690 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5691 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5693 (XSETPVECTYPE): Rewrite in terms of new macro.
5694 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5695 This is a bit clearer, and further avoids the possibility of
5696 undesirable aliasing.
5697 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5698 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5699 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5700 since Lisp_Subr is a special case (no "next" field).
5701 (ASIZE): Now uses header.size rather than size.
5702 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5703 to avoid the hassle of writing XVECTOR (foo)->header.size.
5704 (struct vectorlike_header): New type.
5705 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5706 object, to help avoid aliasing.
5707 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5708 (SUBRP): Likewise, since Lisp_Subr is a special case.
5709 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5710 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5711 (struct Lisp_Hash_Table): Combine first two members into a single
5712 struct vectorlike_header member. All uses of "size" and "next" members
5713 changed to be "header.size" and "header.next".
5714 * buffer.h (struct buffer): Likewise.
5715 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5716 * frame.h (struct frame): Likewise.
5717 * process.h (struct Lisp_Process): Likewise.
5718 * termhooks.h (struct terminal): Likewise.
5719 * window.c (struct save_window_data, struct saved_window): Likewise.
5720 * window.h (struct window): Likewise.
5721 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5722 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5723 * buffer.c (init_buffer_once): Likewise.
5724 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5726 * process.c (Fformat_network_address): Use local var for size,
5729 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5731 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5732 * data.c (atof): Remove decl; no longer used or needed.
5733 (digit_to_number): Move to lread.c.
5734 (Fstring_to_number): Use new string_to_number function, to be
5735 consistent with how the Lisp reader treats infinities and NaNs.
5736 Do not assume that floating-point numbers represent EMACS_INT
5737 without losing information; this is not true on most 64-bit hosts.
5738 Avoid double-rounding errors, by insisting on integers when
5739 parsing non-base-10 numbers, as the documentation specifies.
5740 * lisp.h (string_to_number): New decl, replacing ...
5741 (isfloat_string): Remove.
5742 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5743 (read1): Do not accept +. and -. as integers; this
5744 appears to have been a coding error. Similarly, do not accept
5745 strings like +-1e0 as floating point numbers. Do not report
5746 overflow for integer overflows unless the base is not 10 which
5747 means we have no simple and reliable way to continue.
5748 Break out the floating-point parsing into a new
5749 function string_to_number, so that Fstring_to_number parses
5750 floating point numbers consistently with the Lisp reader.
5751 (digit_to_number): Move here from data.c. Make it static inline.
5752 (E_CHAR, EXP_INT): Remove, replacing with ...
5753 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5754 (string_to_number): New function, replacing isfloat_string.
5755 This function checks for valid syntax and produces the resulting
5756 Lisp float number too. Rework it so that string-to-number
5757 no longer mishandles examples like "1.0e+". Use strtoumax,
5758 so that overflow for non-base-10 numbers is reported only when
5759 there's no portable and simple way to convert to floating point.
5761 * textprop.c (set_text_properties_1): Rewrite for clarity,
5762 and to avoid GCC warning about integer overflow.
5764 * intervals.h (struct interval): Use EMACS_INT for members
5765 where EMACS_UINT might cause problems. See
5766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5767 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5768 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5770 (offset_intervals): Tell GCC not to worry about length overflow
5771 when negating a negative length.
5773 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5774 (overrun_check_free): Likewise.
5776 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5777 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5780 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5781 (gnutls_make_error): Rename local to avoid shadowing.
5782 (gnutls_emacs_global_deinit): ifdef out; not used.
5783 (Fgnutls_boot): Use const for pointer to readonly storage.
5784 Comment out unused local. Fix pointer signedness problems.
5786 * lread.c (openp): Don't stuff size_t into an 'int'.
5787 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5788 about possible signed overflow.
5790 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5791 (GDK_KEY_g): Don't define if already defined.
5792 (xg_prepare_tooltip): Avoid pointer signedness problem.
5793 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5795 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5796 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5798 * xfns.c (Fx_window_property): Simplify a bit,
5799 to make a bit faster and to avoid GCC 4.6.0 warning.
5800 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5802 * fns.c (internal_equal): Don't assume size_t fits in int.
5804 * alloc.c (compact_small_strings): Tighten assertion a little.
5806 Replace pEd with more-general pI, and fix some printf arg casts.
5807 * lisp.h (pI): New macro, generalizing old pEd macro to other
5808 conversion specifiers. For example, use "...%"pI"d..." rather
5809 than "...%"pEd"...".
5810 (pEd): Remove. All uses replaced with similar uses of pI.
5811 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5812 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5813 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5814 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5815 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5816 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5817 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5819 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5820 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5821 * print.c (safe_debug_print, print_object): Likewise.
5822 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5824 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5825 avoiding the 0 flag, which is not portable.
5826 * process.c (Fmake_network_process): Use pI to avoid cast.
5827 * region-cache.c (pp_cache): Likewise.
5828 * xdisp.c (decode_mode_spec): Likewise.
5829 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5830 behavior on 64-bit hosts with printf arg.
5831 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5832 (x_stop_queuing_selection_requests): Likewise.
5833 (x_get_window_property): Don't truncate byte count to an 'int'
5836 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5837 here, since it parses constructs like leading '-' and spaces,
5838 which are not wanted; and it overflows with large numbers.
5839 Instead, simply match F[0-9]+, which is what is wanted anyway.
5841 * alloc.c: Remove unportable assumptions about struct layout.
5842 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5843 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5844 (allocate_vectorlike, make_pure_vector): Use the new macros,
5845 plus offsetof, to remove unportable assumptions about struct layout.
5846 These assumptions hold on all porting targets that I know of, but
5847 they are not guaranteed, they're easy to remove, and removing them
5848 makes further changes easier.
5850 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5851 This doesn't fix a bug but makes the code clearer.
5852 (string_overrun_cookie): Now const. Use initializers that
5853 don't formally overflow signed char, to avoid warnings.
5854 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5855 can cause Emacs to crash when string overrun checking is enabled.
5856 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5857 multiple of sizeof (EMACS_INT); it need not be, if
5858 alignof(EMACS_INT) < sizeof (EMACS_INT).
5859 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5861 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5863 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5865 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5867 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5868 supposed to be handshaking. (Bug#8556)
5869 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5871 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5873 * lisp.h (Qdebug): List symbol.
5874 * eval.c (Qdebug): Restore global linkage.
5875 * keyboard.c (debug-on-event): New variable.
5876 (handle_user_signal): Break into debugger when debug-on-event
5877 matches the current signal symbol.
5879 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5881 * alloc.c (check_sblock, check_string_bytes)
5882 (check_string_free_list): Convert to standard C.
5884 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5886 * w32.c (emacs_gnutls_push): Fix typo.
5888 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5890 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5891 "cast to pointer from integer of different size".
5893 Improve doprnt and its use in verror. (Bug#8545)
5894 * doprnt.c (doprnt): Document the set of format control sequences
5895 supported by the function. Use SAFE_ALLOCA instead of always
5898 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5899 is one byte too soon. Don't use xrealloc; instead xfree and
5902 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5904 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5907 * gnutls.c: Renamed global_initialized to
5908 gnutls_global_initialized. Added internals for the
5909 :verify-hostname-error, :verify-error, and :verify-flags
5910 parameters of `gnutls-boot' and documented those parameters in the
5911 docstring. Start callback support.
5912 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5913 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5914 on error. Return error code.
5915 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5916 (emacs_gnutls_read): Likewise.
5917 (Fgnutls_boot): Return handshake error code.
5918 (emacs_gnutls_handle_error): New function.
5919 (wsaerror_to_errno): Likewise.
5921 * w32.h (emacs_gnutls_pull): Add prototype.
5922 (emacs_gnutls_push): Likewise.
5924 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5925 (emacs_gnutls_push): Likewise.
5927 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5929 * process.c (wait_reading_process_output): Check if GnuTLS
5930 buffered some data internally if no FDs are set for TLS
5933 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5934 (LIBS): Link to USER_LIBS.
5935 ($(BLD)/gnutls.$(0)): New target.
5937 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5939 * xdisp.c (handle_single_display_spec): Rename the
5940 display_replaced_before_p argument into display_replaced_p, to
5941 make it consistent with the commentary. Fix typos in the
5944 * textprop.c (syms_of_textprop): Remove dead code.
5945 (copy_text_properties): Delete obsolete commentary about an
5946 interface that was deleted long ago. Fix typos in the description
5949 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5950 to changes in oldXMenu/XMenu.h from 2011-04-16.
5951 <menu_help_message, prev_menu_help_message>: Constify.
5952 (IT_menu_make_room): menu->help_text is now `const char **';
5955 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5956 to changes in oldXMenu/XMenu.h from 2011-04-16.
5957 (struct XMenu): Declare `help_text' `const char **'.
5959 * xfaces.c <Qunspecified>: Make extern again.
5961 * syntax.c: Include sys/types.h before including regex.h, as
5964 * doc.c (get_doc_string): Improve the format passed to `error'.
5966 * doprnt.c (doprnt): Improve commentary.
5968 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5970 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5973 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5974 changes in globals.h immediately force recompilation.
5975 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5976 $(CURDIR)/s/ms-w32.h.
5977 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5979 * character.c (Fchar_direction): Function deleted.
5980 (syms_of_character): Don't defsubr it.
5981 <char-direction-table>: Deleted.
5983 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5985 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5986 * doprnt.c: Include limits.h.
5987 (SIZE_MAX): New macro.
5988 (doprnt): Return a size_t value. 2nd arg is now size_t.
5989 Many local variables are now size_t instead of int or unsigned.
5990 Improve overflow protection. Support `l' modifier for integer
5991 conversions. Support %l conversion. Don't assume an EMACS_INT
5992 argument for integer conversions and for %c.
5994 * lisp.h (doprnt): Restore prototype.
5996 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5999 * Makefile.in (base_obj): Add back doprnt.o.
6001 * deps.mk (doprnt.o): Add back prerequisites.
6002 (callint.o): Depend on character.h.
6004 * eval.c (internal_lisp_condition_case): Include the handler
6005 representation in the error message.
6006 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6007 when breaking from the loop.
6009 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6011 * callint.c (Fcall_interactively): When displaying error message
6012 about invalid control letter, pass the character's codepoint, not
6013 a pointer to its multibyte form. Improve display of the character
6014 in octal and display also its hex code.
6016 * character.c (char_string): Use %x to display the (unsigned)
6017 codepoint of an invalid character, to avoid displaying a bogus
6020 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6021 `error', not SYMBOL_NAME itself.
6023 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6024 character arguments to `error'.
6026 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6027 to `error' in error message about FINAL_CHAR argument. Make sure
6028 FINAL_CHAR is a character, and use %c when it is passed as
6029 argument to `error'.
6031 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6033 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6035 * w32.c: Include <time.h>.
6036 (sys_localtime): New function.
6038 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6040 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6042 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6044 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6046 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6049 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6051 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6052 gl_state.e_property when gl_state.object is Qt.
6054 * insdel.c (make_gap_larger): Remove limitation of buffer size
6057 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6059 * xdisp.c (lookup_glyphless_char_display)
6060 (produce_glyphless_glyph): Handle cons cell entry in
6061 glyphless-char-display.
6062 (Vglyphless_char_display): Document it.
6064 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6065 glyphless-char-display.
6067 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6069 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6071 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6073 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6074 definition for no-X builds.
6076 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6078 Static checks with GCC 4.6.0 and non-default toolkits.
6080 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6082 * process.c (keyboard_bit_set): Define only if SIGIO.
6083 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6084 (send_process): Repair possible setjmp clobbering.
6086 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6088 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6090 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6092 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6093 Define only if needed.
6095 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6096 by pacifying GCC about it. Maybe it's time to retire it?
6097 * xfaces.c (USG, __TIMEVAL__): Likewise.
6099 * dispextern.h (struct redisplay_interface): Rename param
6101 * termhooks.h (struct terminal): Likewise.
6102 * xterm.c (xembed_send_message): Likewise.
6104 * insdel.c (make_gap_smaller): Define only if
6105 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6107 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6110 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6111 so that we aren't warned about unused symbols.
6113 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6115 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6117 * xfns.c (x_real_positions): Mark locals as initialized.
6119 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6121 * xterm.c: Fix problems found by static analysis with other toolkits.
6122 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6123 (x_dispatch_event): Declare static if USE_GTK, and
6124 define if USE_GTK || USE_X_TOOLKIT.
6125 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6126 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6127 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6128 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6130 * xmenu.c (menu_help_callback): Pointer type fixes.
6131 Use const pointers when pointing at readonly data. Avoid pointer
6133 (FALSE): Remove unused macro.
6134 (update_frame_menubar): Remove unused decl.
6136 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6138 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6139 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6140 (single_menu_item): Rename local to avoid shadowing.
6142 * keyboard.c (make_lispy_event): Remove unused local var.
6144 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6145 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6147 * bitmaps: Change bitmaps from unsigned char back to the X11
6148 compatible char. Avoid the old compiler warnings about
6149 out-of-range initializers by using, for example, '\xab' rather
6152 * xgselect.c (xgselect_initialize): Check vs interface
6153 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6155 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6157 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6158 to read-only memory.
6160 * fns.c (vector): Remove; this old hack is no longer needed.
6162 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6164 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6166 * xrdb.c (x_load_resources): Omit unused local.
6168 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6169 (x_window): Rename locals to avoid shadowing.
6170 (USG): Use the kludged USG macro, to pacify gcc.
6172 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6173 (x_term_init): Remove local to avoid shadowing.
6175 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6177 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6178 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6180 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6182 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6184 Fix regex.c, syntax.c and friends for buffers > 2GB.
6185 * syntax.h (struct gl_state_s): Declare character position members
6188 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6190 * textprop.c (verify_interval_modification, interval_of):
6191 Declare arguments EMACS_INT.
6193 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6196 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6198 * indent.c (Fvertical_motion): Local variable it_start is now
6201 * regex.c (re_match, re_match_2, re_match_2_internal)
6202 (bcmp_translate, regcomp, regexec, print_double_string)
6203 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6204 (re_compile_pattern, re_exec): Declare arguments and local
6205 variables `size_t' and `ssize_t' and return values `regoff_t', as
6207 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6208 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6209 <compile_stack_type>: `size' and `avail' are now `size_t'.
6211 * regex.h <regoff_t>: Use ssize_t, not int.
6212 (re_search, re_search_2, re_match, re_match_2): Arguments that
6213 specify buffer/string position and length are now ssize_t and
6214 size_t. Return type is regoff_t.
6216 2011-04-16 Ben Key <bkey76@gmail.com>
6218 * nsfont.m: Fixed bugs in ns_get_family and
6219 ns_descriptor_to_entity that were caused by using free to
6220 deallocate memory blocks that were allocated by xmalloc (via
6221 xstrdup). This caused Emacs to crash when compiled with
6222 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6223 --enable-checking=xmallocoverrun). xfree is now used to
6224 deallocate these memory blocks.
6226 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6228 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6230 emacs_write: Accept and return EMACS_INT for sizes.
6231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6233 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6234 Accept and return EMACS_INT.
6235 (emacs_gnutls_write): Return the number of bytes written on
6237 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6238 (emacs_read, emacs_write): Remove check for negative size, as the
6239 Emacs source code has been audited now.
6240 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6241 (emacs_read, emacs_write): Use it.
6242 * process.c (send_process): Adjust to the new signatures of
6243 emacs_write and emacs_gnutls_write. Do not attempt to store
6244 a byte offset into an 'int'; it might overflow.
6245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6247 * sound.c: Don't assume sizes fit in 'int'.
6248 (struct sound_device.period_size, alsa_period_size):
6249 Return EMACS_INT, not int.
6250 (struct sound_device.write, vox_write, alsa_write):
6251 Accept EMACS_INT, not int.
6252 (wav_play, au_play): Use EMACS_INT to store sizes and to
6253 record read return values.
6255 2011-04-15 Ben Key <bkey76@gmail.com>
6257 * keyboard.c (Qundefined): Don't declare static since it is used
6259 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6260 static since they are used in nsfont.m.
6262 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6264 * process.c (Qprocessp): Don't declare static.
6265 * lisp.h (Qprocessp): Declare again.
6267 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6269 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6271 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6273 Improve C-level modularity by making more things 'static'.
6275 Don't publish debugger-only interfaces to other modules.
6276 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6277 (verify_bytepos, count_markers): Move decls to the only modules
6279 * region-cache.h (pp_cache): Likewise.
6280 * window.h (check_all_windows): Likewise.
6281 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6283 * sysdep.c (croak): Now static, if
6284 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6285 * syssignal.h (croak): Declare only if not static.
6287 * alloc.c (refill_memory_reserve): Now static if
6288 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6289 * lisp.h (refill_memory_reserve): Declare only if not static.
6291 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6292 Define only if USE_LUCID.
6294 * xrdb.c (x_customization_string, x_rm_string): Now static.
6296 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6297 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6299 * xdisp.c (draw_row_with_mouse_face): Now static.
6300 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6302 * window.h (check_all_windows): Mark externally visible.
6304 * window.c (window_deletion_count): Now static.
6306 * undo.c: Make symbols static if they're not exported.
6307 (last_undo_buffer, last_boundary_position, pending_boundary):
6310 * textprop.c (interval_insert_behind_hooks): Now static.
6311 (interval_insert_in_front_hooks): Likewise.
6313 * term.c: Make symbols static if they're not exported.
6314 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6315 (max_frame_lines, tty_set_terminal_modes):
6316 (tty_reset_terminal_modes, tty_turn_off_highlight):
6317 (get_tty_terminal): Now static.
6318 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6319 * termhooks.h (term_mouse_moveto): Do not declare if
6321 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6322 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6324 * sysdep.c: Make symbols static if they're not exported.
6325 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6327 (sigprocmask_set, full_mask): Remove; unused.
6328 (wait_debugging): Mark as visible.
6329 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6330 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6332 * syntax.c (syntax_temp): Define only if !__GNUC__.
6334 * sound.c (current_sound_device, current_sound): Now static.
6336 * search.c (searchbufs, searchbuf_head): Now static.
6338 * scroll.c (scroll_cost): Remove; unused.
6339 * dispextern.h (scroll_cost): Remove decl.
6341 * region-cache.h (pp_cache): Mark as externally visible.
6343 * process.c: Make symbols static if they're not exported.
6344 (process_tick, update_tick, create_process, chan_process):
6345 (Vprocess_alist, proc_buffered_char, datagram_access):
6346 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6347 (deactivate_process): Mark defn as static, as well as decl.
6348 * lisp.h (create_process): Remove decl.
6349 * process.h (chan_process, Vprocess_alist): Remove decls.
6351 * print.c: Make symbols static if they're not exported.
6352 (print_depth, new_backquote_output, being_printed, print_buffer):
6353 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6354 (print_interval, print_number_index, initial_stderr_stream):
6356 * lisp.h (Fprinc): Remove decl.
6357 (debug_output_compilation_hack): Mark as externally visible.
6359 * sysdep.c (croak): Move decl from here to syssignal.h.
6360 * syssignal.h (croak): Put it here, so the API can be checked when
6361 'croak' is called from dissociate_if_controlling_tty.
6363 * minibuf.c: Make symbols static if they're not exported.
6364 (minibuf_save_list, choose_minibuf_frame): Now static.
6365 * lisp.h (choose_minibuf_frame): Remove decl.
6367 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6369 * lread.c: Make symbols static if they're not exported.
6370 (read_objects, initial_obarray, oblookup_last_bucket_number):
6372 (make_symbol): Remove; unused.
6373 * lisp.h (initial_obarray, make_symbol): Remove decls.
6375 * keyboard.c: Make symbols static if they're not exported.
6376 (single_kboard, recent_keys_index, total_keys, recent_keys):
6377 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6378 (this_single_command_key_start, echoing, last_auto_save):
6379 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6380 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6381 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6382 (Vlispy_mouse_stem, double_click_count):
6384 (force_auto_save_soon): Define only if SIGDANGER.
6385 (ignore_mouse_drag_p): Now static if
6386 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6387 (print_help): Remove; unused.
6388 (stop_character, last_timer_event): Mark as externally visible.
6389 * keyboard.h (ignore_mouse_drag_p): Declare only if
6390 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6391 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6392 * lisp.h (echoing): Remove decl.
6393 (force_auto_save_soon): Declare only if SIGDANGER.
6394 * xdisp.c (redisplay_window): Simplify code, to make it more
6395 obvious that ignore_mouse_drag_p is not accessed if !defined
6396 USE_GTK && !defined HAVE_NS.
6398 * intervals.c: Make symbols static if they're not exported.
6399 (merge_properties_sticky, merge_interval_right, delete_interval):
6401 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6403 * insdel.c: Make symbols static if they're not exported.
6404 However, leave prepare_to_modify_buffer alone. It's never
6405 called from outside this function, but that appears to be a bug.
6406 (combine_after_change_list, combine_after_change_buffer):
6407 (adjust_after_replace, signal_before_change): Now static.
6408 (adjust_after_replace_noundo): Remove; unused.
6409 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6410 (signal_before_change): Remove decls.
6412 * indent.c (val_compute_motion, val_vmotion): Now static.
6414 * image.c: Make symbols static if they're not exported.
6415 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6417 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6418 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6420 * fringe.c (standard_bitmaps): Now static.
6421 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6423 * frame.c: Make symbols static if they're not exported.
6424 (x_report_frame_params, make_terminal_frame): Now static.
6425 (get_frame_param): Now static, unless HAVE_NS.
6426 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6427 (x_get_resource_string): Remove; not used.
6428 * frame.h (make_terminal_frame, x_report_frame_params):
6429 (x_get_resource_string); Remove decls.
6430 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6431 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6433 * font.c, fontset.c: Make symbols static if they're not exported.
6434 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6435 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6436 * font.c (font_close_object): Now static.
6437 * font.h (font_close_object): Remove.
6438 * fontset.c (FONTSET_OBJLIST): Remove.
6439 (free_realized_fontset) #if-0 the body, which does nothing.
6440 (face_suitable_for_char_p): #if-0, as it's never called.
6441 * fontset.h (face_suitable_for_char_p): Remove decl.
6442 * xfaces.c (face_at_string_position):
6443 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6444 since 0 is always ASCII.
6446 * fns.c (weak_hash_tables): Now static.
6448 * fileio.c: Make symbols static if they're not exported.
6449 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6450 (Vwrite_region_annotation_buffers): Now static.
6452 * eval.c: Make symbols static if they're not exported.
6453 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6454 * lisp.h (backtrace_list): Remove decl.
6456 * emacs.c: Make symbols static if they're not exported.
6457 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6458 (fatal_error_code, fatal_error_signal_hook, standard_args):
6460 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6461 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6462 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6463 * lisp.h (fatal_error_signal_hook): Remove decl.
6464 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6466 * editfns.c: Move a (normally-unused) function to its only use.
6467 * editfns.c, lisp.h (get_operating_system_release): Remove.
6468 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6469 worth the hassle of breaking this out.
6471 * xterm.c: Make symbols static if they're not exported.
6472 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6473 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6474 (x_destroy_window, x_delete_display):
6476 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6477 (x_mouse_leave): Remove; unused.
6478 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6479 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6480 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6482 (x_mouse_leave): Declare only if WINDOWSNT.
6483 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6484 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6487 * ftxfont.c: Make symbols static if they're not exported.
6488 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6490 * font.h (ftxfont_driver): Likewise.
6492 * xfns.c: Make symbols static if they're not exported.
6493 (x_last_font_name, x_display_info_for_name):
6494 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6495 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6496 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6497 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6498 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6499 (last_show_tip_args): Now static.
6500 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6501 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6502 (x_screen_planes): Remove; unused.
6503 * dispextern.h (x_screen_planes): Remove decl.
6505 * dispnew.c: Make symbols static if they're not exported.
6506 * dispextern.h (redraw_garbaged_frames, scrolling):
6507 (increment_row_positions): Remove.
6508 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6509 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6511 (redraw_garbaged_frames): Remove; unused.
6513 * xfaces.c: Make symbols static if they're not exported.
6514 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6516 * xterm.h (defined_color): Remove decls.
6517 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6518 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6519 (menu_face_changed_default, defined_color, free_realized_face):
6520 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6521 (ascii_face_of_lisp_face): Remove; unused.
6523 * xdisp.c: Make symbols static if they're not exported.
6524 * dispextern.h (scratch_glyph_row, window_box_edges):
6525 (glyph_to_pixel_coords, set_cursor_from_row):
6526 (get_next_display_element, set_iterator_to_next):
6527 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6528 (show_mouse_face): Remove decls
6529 * frame.h (message_buf_print): Likewise.
6530 * lisp.h (pop_message, set_message, check_point_in_composition):
6532 * xterm.h (set_vertical_scroll_bar): Likewise.
6533 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6534 (message_buf_print, scratch_glyph_row, displayed_buffer):
6535 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6536 (get_next_display_element, show_mouse_face, window_box_edges):
6537 (frame_to_window_pixel_xy, check_point_in_composition):
6538 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6539 (glyph_to_pixel_coords): Remove; unused.
6541 * dired.c (file_name_completion): Now static.
6543 * dbusbind.c (xd_in_read_queued_messages): Now static.
6545 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6546 * data.c (circular_list_error): Remove.
6548 * commands.h (last_point_position, last_point_position_buffer):
6549 (last_point_position_window): Remove decls.
6550 * keyboard.c: Make these variables static.
6552 * coding.h (coding, code_convert_region, encode_coding_gap):
6554 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6555 (iso_code_class, detect_coding, code_convert_region): Now static.
6556 (encode_coding_gap): Remove; unused.
6558 * chartab.c (chartab_chars, chartab_bits): Now static.
6560 * charset.h (charset_iso_8859_1): Remove decl.
6561 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6564 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6565 * ccl.c (Vccl_program_table): Now static.
6566 (check_ccl_update): Remove; unused.
6568 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6569 * category.h: ... from here.
6570 * category.c (check_category_table, set_category_set): Now static.
6572 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6573 * lisp.h: Remove these decls.
6575 * buffer.c (buffer_count): Remove unused var.
6577 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6578 so that it's not optimized away.
6579 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6580 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6581 exported only to the debugger.
6583 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6584 * atimer.h (run_all_atimers): Remove; not exported.
6586 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6587 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6588 was inaccessible from Lisp.
6589 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6590 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6592 alloc.c: Import and export fewer symbols, and remove unused items.
6593 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6595 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6596 it's not optimized away by whole-program optimization.
6597 (message_enable_multibyte, free_misc): Remove.
6598 (catchlist, handlerlist, mark_backtrace):
6599 Declare only if BYTE_MARK_STACK.
6600 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6601 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6602 (message_enable_multibyte): Remove decl.
6603 (free_misc, interval_free_list, float_block, float_block_index):
6604 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6605 (cons_free_list, last_marked_index):
6607 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6608 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6609 (mark_backtrace): Define only if BYTE_MARK_STACK.
6610 * xdisp.c (message_enable_multibyte): Now static.
6612 Declare Lisp_Object Q* variables to be 'static' if not exported.
6613 This makes it easier for human readers (and static analyzers)
6614 to see whether these variables are used from other modules.
6615 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6616 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6617 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6618 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6619 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6620 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6621 * xmenu.c, xselect.c:
6622 Declare Q* vars static if they are not used in other modules.
6623 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6624 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6625 Remove decls of unexported vars.
6626 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6628 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6630 Make Emacs functions such as Fatom 'static' by default.
6631 This makes it easier for human readers (and static analyzers)
6632 to see whether these functions can be called from other modules.
6633 DEFUN now defines a static function. To make the function external
6634 so that it can be used in other C modules, use the new macro DEFUE.
6635 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6636 (Finit_image_library):
6637 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6638 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6639 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6640 Remove decls, since these functions are now static.
6641 (Funintern, Fget_internal_run_time): New decls, since these functions
6642 were already external.
6644 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6645 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6646 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6647 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6648 * keyboard.c, keymap.c, lread.c:
6649 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6650 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6651 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6652 Mark functions with DEFUE instead of DEFUN,
6653 if they are used in other modules.
6654 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6655 decls for now-static functions.
6656 * buffer.h (Fdelete_overlay): Remove decl.
6657 * callproc.c (Fgetenv_internal): Mark as internal.
6658 * composite.c (Fremove_list_of_text_properties): Remove decl.
6659 (Fcomposition_get_gstring): New forward static decl.
6660 * composite.h (Fcomposite_get_gstring): Remove decl.
6661 * dired.c (Ffile_attributes): New forward static decl.
6662 * doc.c (Fdocumntation_property): New forward static decl.
6663 * eval.c (Ffetch_bytecode): New forward static decl.
6664 (Funintern): Remove extern decl; now in .h file where it belongs.
6665 * fileio.c (Fmake_symbolic_link): New forward static decl.
6666 * image.c (Finit_image_library): New forward static decl.
6667 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6668 * intervals.h (Fprevious_property_change):
6669 (Fremove_list_of_text_properties): Remove decls.
6670 * keyboard.c (Fthis_command_keys): Remove decl.
6671 (Fcommand_execute): New forward static decl.
6672 * keymap.c (Flookup_key): New forward static decl.
6673 (Fcopy_keymap): Now static.
6674 * keymap.h (Flookup_key): Remove decl.
6675 * process.c (Fget_process): New forward static decl.
6676 (Fprocess_datagram_address): Mark as internal.
6677 * syntax.c (Fsyntax_table_p): New forward static decl.
6678 (skip_chars): Remove duplicate decl.
6679 * textprop.c (Fprevious_property_change): New forward static decl.
6680 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6682 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6683 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6685 * editfns.c (Fformat): Remove unreachable code.
6687 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6689 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6692 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6694 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6695 when at ZV. (Bug#8487)
6697 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6699 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6701 * keyboard.c (parse_tool_bar_item): Likewise.
6702 * sound.c (sound_cleanup, alsa_close): Likewise.
6703 * termcap.c (tgetent): Likewise.
6704 * xfns.c (x_default_font_parameter): Likewise.
6705 * xsettings.c (read_and_apply_settings): Likewise.
6707 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6708 (overrun_check_free): Protoize.
6710 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6712 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6713 since callers should never pass a negative size.
6714 Change the signature to match that of plain 'read' and 'write'; see
6715 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6716 * lisp.h: Update prototypes of emacs_write and emacs_read.
6718 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6720 * xdisp.c (redisplay_window): Don't try to determine the character
6721 position of the scroll margin if the window start point w->startp
6722 is outside the buffer's accessible region. (Bug#8468)
6724 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6726 Fix write-region and its subroutines for buffers > 2GB.
6727 * fileio.c (a_write, e_write): Modify declaration of arguments and
6728 local variables to support buffers larger than 2GB.
6729 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6731 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6732 argument, local variables, and return value.
6734 * lisp.h: Update prototypes of emacs_write and emacs_read.
6736 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6738 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6740 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6742 Fix more problems found by GCC 4.6.0's static checks.
6744 * xdisp.c (vmessage): Use a better test for character truncation.
6746 * charset.c (load_charset_map): <, not <=, for optimization,
6747 and to avoid potential problems with integer overflow.
6748 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6749 * casetab.c (set_identity, shuffle): Likewise.
6750 * editfns.c (Fformat): Likewise.
6751 * syntax.c (skip_chars): Likewise.
6753 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6754 This also lets GCC 4.6.0 generate slightly better loop code.
6756 * callint.c (Fcall_interactively): <, not <=, for optimization.
6757 (Fcall_interactively): Count the number of arguments produced,
6758 not the number of arguments given. This is simpler and lets GCC
6759 4.6.0 generate slightly better code.
6761 * ftfont.c: Distingish more carefully between FcChar8 and char.
6762 The previous code passed unsigned char * to a functions like
6763 strlen and xstrcasecmp that expect char *, which does not
6764 conform to the C standard.
6765 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6766 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6767 char * when the C standard requires it.
6769 * keyboard.c (read_char): Remove unused var.
6771 * eval.c: Port to Windows vsnprintf (Bug#8435).
6773 (SIZE_MAX): Define if the headers do not.
6774 (verror): Do not give up if vsnprintf returns a negative count.
6775 Instead, grow the buffer. This ports to Windows vsnprintf, which
6776 does not conform to C99. Problem reported by Eli Zaretskii.
6777 Also, simplify the allocation scheme, by avoiding the need for
6778 calling realloc, and removing the ALLOCATED variable.
6780 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6782 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6783 But keep the doprint source code for now, as we might revamp it
6784 and use it again (Bug#8435).
6785 * lisp.h (doprnt): Remove.
6786 * Makefile.in (base_obj): Remove doprnt.o.
6787 * deps.mk (doprnt.o): Remove.
6789 error: Print 32- and 64-bit integers portably (Bug#8435).
6790 Without this change, on typical 64-bit hosts error ("...%d...", N)
6791 was used to print both 32- and 64-bit integers N, which relied on
6793 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6795 * lisp.h (error, verror): Mark as printf-like functions.
6796 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6797 Report overflow in size calculations when allocating printf buffer.
6798 Do not truncate output string at its first null byte.
6799 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6800 Truncate the output at a character boundary, since vsnprintf does not
6802 * charset.c (check_iso_charset_parameter): Convert internal
6803 character to string before calling 'error', since %c now has the
6805 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6806 overflow when computing char to be passed to 'error'. Do not
6807 pass Lisp_Object to 'error'; pass the integer instead.
6808 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6809 formatted with plain %d.
6811 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6813 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6815 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6817 * xterm.c (x_catch_errors): Remove duplicate declaration.
6819 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6821 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6823 2011-04-10 Jim Meyering <meyering@redhat.com>
6825 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6826 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6827 return ssize_t not "int", and use size_t as the buffer length.
6828 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6829 * gnutls.h: Update declarations.
6830 * process.c (read_process_output): Use ssize_t, to match.
6831 (send_process): Likewise.
6833 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6835 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6837 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6839 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6840 Use unsigned char, to match FcChar8 type definition.
6842 * xterm.c (handle_one_xevent):
6843 * xmenu.c (create_and_show_popup_menu):
6844 * xselect.c (x_decline_selection_request)
6845 (x_reply_selection_request): Avoid type-punned deref of X events.
6847 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6849 Fix some uses of `int' instead of EMACS_INT.
6850 * search.c (string_match_1, fast_string_match)
6851 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6852 (scan_buffer, find_next_newline_no_quit)
6853 (find_before_next_newline, search_command, Freplace_match)
6854 (Fmatch_data): Make some `int' variables be EMACS_INT.
6856 * xdisp.c (display_count_lines): 3rd argument and return value now
6857 EMACS_INT. All callers changed.
6858 (pint2hrstr): Last argument is now EMACS_INT.
6860 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6861 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6862 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6863 (decode_coding_utf_16, decode_coding_emacs_mule)
6864 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6865 (decode_coding_ccl, decode_coding_charset)
6866 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6867 (decode_coding_iso_2022, decode_coding_emacs_mule)
6868 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6869 <char_offset, last_offset>: Declare EMACS_INT.
6870 (encode_coding_utf_8, encode_coding_utf_16)
6871 (encode_coding_emacs_mule, encode_invocation_designation)
6872 (encode_designation_at_bol, encode_coding_iso_2022)
6873 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6874 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6876 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6877 (encode_invocation_designation): Last argument P_NCHARS is now
6879 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6880 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6882 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6885 * ccl.c (Fccl_execute_on_string): Declare some variables
6888 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6890 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6892 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6894 * process.c (Fformat_network_address): Doc fix.
6896 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6898 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6900 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6902 * keyboard.c (read_char): Call Lisp function help-form-show,
6903 instead of using internal_with_output_to_temp_buffer.
6904 (Qhelp_form_show): New var.
6905 (syms_of_keyboard): Use DEFSYM macro.
6907 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6909 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6911 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6913 * process.c (Flist_processes): Remove to Lisp.
6914 (list_processes_1): Delete.
6916 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6918 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6920 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6922 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6924 Fix more problems found by GCC 4.6.0's static checks.
6926 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6928 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6930 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6932 * xdisp.c (vmessage): Mark as a printf-like function.
6934 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6936 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6938 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6939 printf-like functions.
6940 (tiff_load): Add casts to remove these marks before passing them
6941 to system-supplied API.
6943 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6945 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6946 This avoids several warnings with gcc -Wstrict-overflow.
6947 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6948 directly, rather than having caller test rule sign. This avoids
6949 some unnecessary tests.
6950 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6951 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6952 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6954 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6955 (xfont_open): Avoid unnecessary tests.
6957 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6959 * composite.h, composite.c (composition_gstring_put_cache):
6960 Use EMACS_INT, not int, for length.
6962 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6963 breaking out part of COMPOSITION_DECODE_RULE.
6964 (COMPOSITION_DECODE_RULE): Use it.
6965 * composite.c (get_composition_id): Remove unused local vars,
6966 by using the new macro.
6968 * textprop.c (set_text_properties_1): Change while to do-while,
6969 since the condition is always true at first.
6971 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6972 (interval_deletion_adjustment): Return unsigned value.
6975 * process.c (list_processes_1, create_pty, read_process_output):
6976 (exec_sentinel): Remove vars that were set but not used.
6977 (create_pty): Remove unnecessary "volatile"s.
6978 (Fnetwork_interface_info): Avoid possibility of int overflow.
6979 (read_process_output): Do adaptive read buffering even if carryover.
6980 (read_process_output): Simplify nbytes computation if buffered.
6982 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6984 * syntax.c (scan_words): Remove var that was set but not used.
6985 (update_syntax_table): Use unsigned instead of int.
6987 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6988 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6989 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6991 * print.c (print_error_message): Avoid int overflow.
6993 * font.c (font_list_entities): Redo for clarity,
6994 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6996 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6997 (font_score): Avoid potential overflow in diff calculation.
6999 * fns.c (substring_both): Remove var that is set but not used.
7000 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7002 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7004 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7005 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7006 can always succeed if overflow has undefined behavior.
7008 * search.c (boyer_moore, wordify): Remove vars set but not used.
7009 (wordify): Omit three unnecessary tests.
7011 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7012 All callers changed. This avoids the need for an unused var.
7014 * casefiddle.c (casify_region): Remove var that is set but not used.
7016 * dired.c (file_name_completion): Remove var that is set but not used.
7018 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7020 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7021 (Finsert_file_contents): Remove unnecessary code checking fd.
7023 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7024 Check for integer overflow on size calculations.
7026 * buffer.c (Fprevious_overlay_change): Remove var that is set
7029 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7030 Remove vars that are set but not used.
7031 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7032 (timer_check_2): Mark vars as initialized.
7034 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7036 * image.c (lookup_image): Remove var that is set but not used.
7037 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7039 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7040 that are set but not used.
7042 * xfns.c (make_invisible_cursor): Don't return garbage
7043 if XCreateBitmapFromData fails (Bug#8410).
7045 * xselect.c (x_get_local_selection, x_handle_property_notify):
7046 Remove vars that are set but not used.
7048 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7049 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7051 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7052 Remove var that is set but not used.
7053 (scroll_bar_windows_size): Now size_t, not int.
7054 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7057 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7058 (map_tty_color) [!defined MSDOS]: Likewise.
7060 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7062 * coding.c: Remove vars that are set but not used.
7063 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7064 All callers changed.
7065 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7066 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7067 (decode_coding_charset): Remove vars that are set but not used.
7069 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7070 that is set but not used.
7072 * print.c (print_object): Remove var that is set but not used.
7074 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7075 The gnulib version avoids calling malloc in the usual case,
7076 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7077 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7078 * filelock.c (current_lock_owner): Likewise.
7079 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7080 * sysdep.c: Include allocator.h, careadlinkat.h.
7081 (emacs_no_realloc_allocator): New static constant.
7082 (emacs_readlink): New function.
7083 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7084 ../lib/careadlinkat.h.
7086 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7088 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7089 first non-nil return value).
7091 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7093 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7094 if not defined (Bug#8403).
7096 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7098 * xdisp.c (display_count_lines): Remove parameter `start',
7099 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7100 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7101 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7102 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7103 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7104 and thereabouts. All callers changed.
7105 (get_per_char_metric): Remove parameter `f', unused since
7106 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7108 2011-04-02 Jim Meyering <meyering@redhat.com>
7110 do not dereference NULL upon failed strdup
7111 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7112 (ns_get_family): Likewise.
7114 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7116 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7118 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7120 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7123 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7125 Add lexical binding.
7127 * window.c (Ftemp_output_buffer_show): New fun.
7128 (Fsave_window_excursion):
7129 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7131 * lread.c (lisp_file_lexically_bound_p): New function.
7132 (Fload): Bind Qlexical_binding.
7133 (readevalloop): Remove `evalfun' arg.
7134 Bind Qinternal_interpreter_environment.
7135 (Feval_buffer): Bind Qlexical_binding.
7136 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7138 (syms_of_lread): Declare `lexical-binding'.
7140 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7142 * keyboard.c (eval_dyn): New fun.
7143 (menu_item_eval_property): Use it.
7145 * image.c (parse_image_spec): Use Ffunctionp.
7147 * fns.c (concat, mapcar1): Accept byte-code-functions.
7149 * eval.c (Fsetq): Handle lexical vars.
7150 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7151 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7152 (FletX, Flet): Obey lexical binding.
7153 (Fcommandp): Handle closures.
7154 (Feval): New `lexical' arg.
7155 (eval_sub): New function extracted from Feval. Use it almost
7156 everywhere where Feval was used. Look up vars in lexical env.
7158 (Ffunctionp): Move from subr.el.
7159 (Ffuncall): Handle closures.
7160 (apply_lambda): Remove `eval_flags'.
7161 (funcall_lambda): Handle closures and new byte-code-functions.
7162 (Fspecial_variable_p): New function.
7163 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7164 but without exporting it to Lisp.
7166 * doc.c (Fdocumentation, store_function_docstring):
7167 * data.c (Finteractive_form): Handle closures.
7169 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7172 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7174 (exec_byte_code): New function extracted from Fbyte_code to handle new
7175 calling convention for byte-code-functions. Add new byte-codes.
7177 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7179 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7181 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7183 * xdisp.c (redisplay_internal): Fix prototype.
7185 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7187 * xdisp.c (SCROLL_LIMIT): New macro.
7188 (try_scrolling): Use it when setting scroll_limit.
7189 Limit scrolling to 100 screen lines.
7190 (redisplay_window): Even when falling back on "recentering",
7191 position point in the window according to scroll-conservatively,
7192 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7194 (try_scrolling): When point is above the window, allow searching
7195 as far as scroll_max, or one screenful, to compute vertical
7196 distance from PT to the scroll margin position. This prevents
7197 try_scrolling from unnecessarily failing when
7198 scroll-conservatively is set to a value slightly larger than the
7199 window height. Clean up the case of PT below the margin at bottom
7200 of window: scroll_max can no longer be INT_MAX. When aggressive
7201 scrolling is in use, don't let point enter the opposite scroll
7202 margin as result of the scroll.
7203 (syms_of_xdisp) <scroll-conservatively>: Document the
7204 threshold of 100 lines for never-recentering scrolling.
7206 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7208 * dispextern.h (move_it_by_lines):
7209 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7210 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7211 (message_log_check_duplicate): Remove parameters `prev_bol' and
7212 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7213 (redisplay_internal): Remove parameter `preserve_echo_area',
7214 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7216 * indent.c (Fvertical_motion):
7217 * window.c (window_scroll_pixel_based, Frecenter):
7218 Don't pass `need_y_p' to `move_it_by_lines'.
7220 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7222 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7223 steal a few bits to be more compact.
7224 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7225 Remove unneeded casts.
7227 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7229 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7231 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7232 binding" message (bug#7967).
7234 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7236 Fix more problems found by GCC 4.6.0's static checks.
7238 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7239 Remove unused local var.
7241 * editfns.c (Fmessage_box): Remove unused local var.
7243 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7244 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7245 Omit unused local vars.
7246 * window.c (shrink_windows): Omit unused local var.
7247 * menu.c (digest_single_submenu): Omit unused local var.
7248 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7249 Omit unused local var.
7251 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7252 Don't assume string length fits in int.
7253 (keyremap_step, read_key_sequence): Use size_t for sizes.
7254 (read_key_sequence): Don't check last_real_key_start redundantly.
7256 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7257 instead of alloca (Bug#8344).
7259 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7260 (Fbacktrace_frame): Don't assume nframes fits in int.
7262 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7264 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7267 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7269 * cm.c (calccost): Turn while-do into do-while, for clarity.
7271 * keyboard.c (syms_of_keyboard): Use the same style as later
7272 in this function when indexing through an array. This also
7273 works around GCC bug 48267.
7275 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7277 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7279 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7280 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7282 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7283 This avoids undefined behavior on integer overflow, and is a bit
7284 more convenient anyway since it is compared to a size_t variable.
7286 Variadic C functions now count arguments with size_t, not int.
7287 This avoids an unnecessary limitation on 64-bit machines, which
7288 caused (substring ...) to crash on large vectors (Bug#8344).
7289 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7290 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7291 All variadic functions and their callers changed accordingly.
7292 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7293 * data.c (arith_driver, float_arith_driver): Likewise.
7294 * editfns.c (general_insert_function): Likewise.
7295 * eval.c (struct backtrace.nargs, interactive_p)
7296 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7297 (funcall_lambda, mark_backtrace): Likewise.
7298 * fns.c (concat): Likewise.
7299 * frame.c (x_set_frame_parameters): Likewise.
7300 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7301 0 if not found, not -1. All callers changed.
7303 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7304 (stack_copy_size): Now size_t, not int.
7305 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7307 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7309 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7310 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7311 All callers changed.
7313 * lisp.h (multibyte_char_to_unibyte):
7314 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7315 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7316 * character.h (CHAR_TO_BYTE8):
7317 * cmds.c (internal_self_insert):
7318 * editfns.c (general_insert_function):
7319 * keymap.c (push_key_description):
7320 * search.c (Freplace_match):
7321 * xdisp.c (message_dolog, set_message_1): All callers changed.
7323 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7325 * keyboard.c (safe_run_hook_funcall): New function.
7326 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7327 don't set the hook to nil, but remove the offending function instead.
7328 (Qcommand_hook_internal): Remove, unused.
7329 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7330 Vcommand_hook_internal.
7332 * eval.c (enum run_hooks_condition): Remove.
7333 (funcall_nil, funcall_not): New functions.
7334 (run_hook_with_args): Call each function through a `funcall' argument.
7335 Remove `cond' argument, now redundant.
7336 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7337 (Frun_hook_with_args_until_failure): Adjust accordingly.
7338 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7340 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7342 * dispextern.h (string_buffer_position): Remove declaration.
7344 * print.c (strout): Remove parameter `multibyte', unused since
7345 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7347 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7348 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7349 All callers changed.
7351 * w32.c (_wsa_errlist): Use braces for struct initializers.
7353 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7354 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7355 All callers changed.
7356 (string_buffer_position): Likewise. Also, make static (it's never
7357 used outside xdisp.c).
7358 (cursor_row_p): Remove parameter `w', unused since
7359 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7360 (decode_mode_spec): Remove parameter `precision', introduced during
7361 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7362 All callers changed.
7364 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7366 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7368 2011-03-27 Anders Lindgren <andlind@gmail.com>
7370 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7371 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7372 (ns_update_auto_hide_menu_bar): New functions.
7373 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7374 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7375 ns_constrain_all_frames.
7376 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7377 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7379 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7381 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7383 2011-03-27 Glenn Morris <rgm@gnu.org>
7385 * syssignal.h: Replace RETSIGTYPE with void.
7386 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7387 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7388 Replace SIGTYPE with void everywhere.
7389 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7390 * s/template.h (SIGTYPE): Remove commented out definition.
7392 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7394 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7395 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7397 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7399 * w32.c (read_unc_volume): Use parameter `henum', instead of
7400 global variable `wget_enum_handle'.
7402 * keymap.c (describe_vector): Remove parameters `indices' and
7403 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7404 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7406 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7408 * keyboard.c (timer_check): Remove parameter `do_it_now',
7409 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7410 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7411 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7413 * keyboard.c (read_char):
7414 * w32menu.c (w32_menu_display_help):
7415 * xmenu.c (show_help_event, menu_help_callback):
7416 Adjust calls to `show_help_echo'.
7418 * gtkutil.c (xg_maybe_add_timer):
7419 * keyboard.c (readable_events):
7420 * process.c (wait_reading_process_output):
7421 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7423 * insdel.c (adjust_markers_gap_motion):
7424 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7425 (gap_left, gap_right): Don't call it.
7427 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7429 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7430 incurred during fontification.
7432 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7434 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7435 (DEFVAR_PER_BUFFER): Don't pass it.
7437 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7438 (scrolling_window): Don't pass it.
7440 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7442 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7444 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7446 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7447 of variables specific to SELinux and computation of `encoded_absname'.
7449 * image.c (XPutPixel): Remove unused variable `height'.
7451 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7453 * unexw32.c (get_section_info): Remove unused variable `section'.
7455 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7456 (system_process_attributes): Remove unused variable `sess'.
7457 (sys_read): Remove unused variable `err'.
7459 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7460 (w32_wnd_proc): Remove unused variable `isdead'.
7461 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7462 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7463 (x_create_tip_frame): Remove unused variable `tem'.
7465 * w32inevt.c (w32_console_read_socket):
7466 Remove unused variable `no_events'.
7468 * w32term.c (x_draw_composite_glyph_string_foreground):
7469 Remove unused variable `width'.
7471 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7473 * w32term.c (x_set_glyph_string_clipping):
7474 Don't pass uninitialized region to CombineRgn.
7476 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7478 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7479 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7480 (Fx_close_connection): Remove unused variable `i'.
7482 * w32font.c (w32font_draw): Return number of glyphs.
7483 (w32font_open_internal): Remove unused variable `i'.
7484 (w32font_driver): Add missing initializer.
7486 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7487 (fill_in_menu): Remove unused variable `items_added'.
7489 * w32term.c (last_mouse_press_frame): Remove static global variable.
7490 (w32_clip_to_row): Remove unused variable `f'.
7491 (x_delete_terminal): Remove unused variable `i'.
7493 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7494 (NOTHING): Remove unused static global variable.
7495 (uniscribe_check_otf): Remove unused variable `table'.
7496 (uniscribe_font_driver): Add missing initializers.
7498 2011-03-23 Julien Danjou <julien@danjou.info>
7500 * term.c (Fsuspend_tty, Fresume_tty):
7501 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7502 * window.c (temp_output_buffer_show):
7503 * insdel.c (signal_before_change):
7504 * frame.c (Fhandle_switch_frame):
7505 * fileio.c (Fdo_auto_save):
7506 * emacs.c (Fkill_emacs):
7507 * editfns.c (save_excursion_restore):
7508 * cmds.c (internal_self_insert):
7509 * callint.c (Fcall_interactively):
7510 * buffer.c (Fkill_all_local_variables):
7511 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7513 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7514 unconditionnaly since it does the check itself.
7516 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7518 Fix more problems found by GCC 4.5.2's static checks.
7520 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7521 the first time through the loop, since we know p0 < p1 then.
7522 This also avoids a gcc -Wstrict-overflow warning.
7524 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7525 leading to a memory leak, possible in functions like
7526 load_charset_map_from_file that can allocate an unbounded number
7527 of objects (Bug#8318).
7529 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7530 that could (at least in theory) be that large.
7532 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7533 This is less likely to overflow, and avoids undefined behavior if
7534 overflow does occur. All callers changed. Use strtoul to scan
7535 for the unsigned long integer.
7536 (pint2hrstr): Simplify and tune code slightly.
7537 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7539 * scroll.c (do_scrolling): Work around GCC bug 48228.
7540 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7542 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7543 This also avoids a warning with gcc -Wstrict-overflow.
7544 (validate_x_resource_name): Simplify count usage.
7545 This also avoids a warning with gcc -Wstrict-overflow.
7547 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7550 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7552 * process.c (Fmake_network_process): Use socklen_t, not int,
7553 where POSIX says socklen_t is required in portable programs.
7554 This fixes a porting bug on hosts like 64-bit HP-UX, where
7555 socklen_t is wider than int (Bug#8277).
7556 (Fmake_network_process, server_accept_connection):
7557 (wait_reading_process_output, read_process_output):
7560 * process.c: Rename or move locals to avoid shadowing.
7561 (list_processes_1, Fmake_network_process):
7562 (read_process_output_error_handler, exec_sentinel_error_handler):
7563 Rename or move locals.
7564 (Fmake_network_process): Define label "retry_connect" only if needed.
7565 (Fnetwork_interface_info): Fix pointer signedness.
7566 (process_send_signal): Add cast to avoid pointer signedness problem.
7567 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7568 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7570 Make tparam.h and terminfo.c consistent.
7571 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7572 Include tparam.h instead, since it declares them.
7573 * cm.h (PC): Remove extern decl; tparam.h now does this.
7574 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7575 * terminfo.c: Include tparam.h, to check interfaces.
7576 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7577 (tparam): Adjust signature to match interface in tparam.h;
7578 this removes some undefined behavior. Check that outstring and len
7579 are zero, which they always are with Emacs.
7580 * tparam.h (PC, BC, UP): New extern decls.
7582 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7583 (xftfont_open): Rename locals to avoid shadowing.
7585 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7586 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7587 (OTF_TAG_SYM): Omit macro if not needed.
7588 (ftfont_list): Remove unused local.
7589 (get_adstyle_property, ftfont_pattern_entity):
7590 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7591 Rename locals to avoid shadowing.
7593 * xfont.c (xfont_list_family): Mark var as initialized.
7595 * xml.c (make_dom): Now static.
7597 * composite.c (composition_compute_stop_pos): Rename local to
7599 (composition_reseat_it): Remove unused locals.
7600 (find_automatic_composition, composition_adjust_point): Likewise.
7601 (composition_update_it): Mark var as initialized.
7602 (find_automatic_composition): Mark vars as initialized,
7603 with a FIXME (Bug#8290).
7605 character.h: Rename locals to avoid shadowing.
7606 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7607 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7608 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7609 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7612 * textprop.c (property_change_between_p): Remove; unused.
7614 * intervals.c (interval_start_pos): Now static.
7616 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7618 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7619 Rename locals to avoid shadowing.
7621 * sound.c (wav_play, au_play, Fplay_sound_internal):
7622 Fix pointer signedness.
7623 (alsa_choose_format): Remove unused local var.
7624 (wav_play): Initialize a variable to 0, to prevent undefined
7625 behavior (Bug#8278).
7627 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7629 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7631 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7632 clobbering (Bug#8298).
7633 * sysdep.c (sys_subshell): Likewise.
7634 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7636 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7637 This should get cleaned up, so that child_setup has the
7638 same signature on all platforms.
7640 * callproc.c (call_process_cleanup): Now static.
7641 (relocate_fd): Rename locals to avoid shadowing.
7643 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7645 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7646 not to be necessary, and produces flickering.
7648 2011-03-20 Glenn Morris <rgm@gnu.org>
7650 * config.in: Remove file.
7652 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7654 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7655 are now in src/globals.h.
7656 (syms_of_minibuf): Remove spurious & from previous change.
7658 2011-03-20 Leo <sdl.web@gmail.com>
7660 * minibuf.c (completing-read-function): New variable.
7661 (completing-read-default): Rename from completing-read.
7662 (completing-read): Call completing-read-function.
7664 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7666 * xfaces.c (Fx_load_color_file):
7667 Read color file from absolute filename (bug#8250).
7669 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7671 * makefile.w32-in: Update dependencies.
7673 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7675 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7677 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7679 Fix more problems found by GCC 4.5.2's static checks.
7681 * process.c (make_serial_process_unwind, send_process_trap):
7682 (sigchld_handler): Now static.
7684 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7685 That way, the code declares only the vars that it needs.
7686 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7687 * s/cygwin.h (PTY_ITERATION): Likewise.
7688 * s/darwin.h (PTY_ITERATION): Likewise.
7689 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7691 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7692 * process.c (allocate_pty): Don't declare stb unless it's needed.
7694 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7695 (CONSTANTLIM): Remove; unused.
7696 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7697 Define only if needed.
7699 * unexelf.c (unexec): Name an expression,
7700 to avoid gcc -Wbad-function-cast warning.
7701 Use a different way to cause a compilation error if anyone uses
7702 n rather than nn, a way that does not involve shadowing.
7703 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7705 * deps.mk (unexalpha.o): Remove; unused.
7707 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7708 * unexec.h: New file.
7709 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7710 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7712 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7713 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7714 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7715 Change as necessary to match prototype in unexec.h.
7717 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7719 (back_comment, skip_chars): Mark vars as initialized.
7721 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7722 Rename locals to avoid shadowing.
7724 * lread.c (read1): Rewrite so as not to use empty "else".
7725 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7727 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7729 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7730 warning when compiling print.c.
7732 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7733 instead of using an uninitialized var.
7734 (font_sort_entities): Mark var as initialized.
7736 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7738 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7739 pointers to constants.
7740 (font_parse_fcname): Remove unused vars.
7741 (font_delete_unmatched): Now static.
7742 (font_get_spec): Remove; unused.
7743 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7744 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7745 Rename or move locals to avoid shadowing.
7747 * fns.c (require_nesting_list, require_unwind): Now static.
7748 (Ffillarray): Rename locals to avoid shadowing.
7750 * floatfns.c (domain_error2): Define only if needed.
7751 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7753 * alloc.c (mark_backtrace): Move decl from here ...
7754 * lisp.h: ... to here, so that it can be checked.
7756 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7757 (Fdefvar): Rewrite so as not to use empty "else".
7758 (lisp_indirect_variable): Name an expression,
7759 to avoid gcc -Wbad-function-cast warning.
7760 (Fdefvar): Rename locals to avoid shadowing.
7762 * callint.c (quotify_arg, quotify_args): Now static.
7763 (Fcall_interactively): Rename locals to avoid shadowing.
7764 Use const pointer when appropriate.
7766 * lisp.h (get_system_name, get_operating_system_release):
7767 Move decls here, to check interfaces.
7768 * process.c (get_operating_system_release): Move decl to lisp.h.
7769 * xrdb.c (get_system_name): Likewise.
7770 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7771 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7772 some of which prompt warnings from gcc -Wbad-function-cast.
7773 (Fformat_time_string, Fencode_time, Finsert_char):
7774 (Ftranslate_region_internal, Fformat):
7775 Rename or remove local vars to avoid shadowing.
7776 (Ftranslate_region_internal): Mark var as initialized.
7778 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7781 * lisp.h (eassert): Check that the argument compiles, even if
7782 ENABLE_CHECKING is not defined.
7784 * data.c (Findirect_variable): Name an expression, to avoid
7785 gcc -Wbad-function-cast warning.
7786 (default_value, arithcompare, arith_driver, arith_error): Now static.
7787 (store_symval_forwarding): Rename local to avoid shadowing.
7788 (Fmake_variable_buffer_local, Fmake_local_variable):
7789 Mark variables as initialized.
7790 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7792 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7793 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7794 Rename locals to avoid shadowing.
7795 (mark_stack): Move local variables into the #ifdef region where
7797 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7798 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7800 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7801 (GC_STRING_CHARS): Remove; not used.
7802 (Fmemory_limit): Cast sbrk's returned value to char *.
7804 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7805 avoids undefined behavior in theory.
7807 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7809 Use functions, not macros, for up- and down-casing (Bug#8254).
7810 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7811 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7812 to use the following functions instead of these macros.
7813 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7814 EMACS_INT, since callers assume the returned value fits in int.
7815 (upcase1): Likewise, for UPCASE_TABLE.
7816 (uppercasep, lowercasep, upcase): New static inline functions.
7817 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7818 the race-condition problem in the old DOWNCASE.
7820 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7821 Rename locals to avoid shadowing.
7822 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7823 (regex_compile, re_search_2, re_match_2_internal):
7824 Remove unused local vars.
7825 (FREE_VAR): Rewrite so as not to use empty "else",
7826 which gcc can warn about.
7827 (regex_compile, re_match_2_internal): Mark locals as initialized.
7828 (RETALLOC_IF): Define only if needed.
7829 (WORDCHAR_P): Likewise. This one is never needed, but is used
7830 only in a comment talking about a compiler bug, so put inside
7831 the #if 0 of that comment.
7832 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7833 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7836 * search.c (boyer_moore): Rename locals to avoid shadowing.
7837 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7838 (PREV_CHAR_BOUNDARY): Likewise.
7840 * search.c (simple_search): Remove unused var.
7842 * dired.c (compile_pattern): Move decl from here ...
7843 * lisp.h: ... to here, so that it can be checked.
7844 (struct re_registers): New forward decl.
7846 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7848 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7850 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7851 Rename locals to avoid shadowing.
7852 (Fvertical_motion): Mark locals as initialized.
7854 * casefiddle.c (casify_object, casify_region): Now static.
7855 (casify_region): Mark local as initialized.
7857 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7859 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7860 New macros, so that the caller can use some names other than
7861 gcpro1, gcpro2, etc.
7862 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7864 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7865 argument, for consistency with GCPRO2_VAR, etc: it is now the
7866 prefix of the variable, not the variable itself. All uses
7868 * dired.c (directory_files_internal, file_name_completion):
7869 Rename locals to avoid shadowing.
7871 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7872 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7873 dired.c's scmp function, had undefined behavior.
7874 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7875 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7876 * buffer.h: ... to here, because these macros use current_buffer,
7877 and the new implementation with inline functions needs to have
7878 current_buffer in scope now, rather than later when the macros
7880 (downcase, upcase1): New static inline functions.
7881 (DOWNCASE, UPCASE1): Reimplement using these functions.
7882 This avoids undefined behavior in expressions like
7883 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7884 from race conditions in accessing the global variables
7885 case_temp1 and case_temp2.
7886 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7887 * lisp.h (case_temp1, case_temp2): Remove their decls.
7888 * character.h (ASCII_CHAR_P): Move from here ...
7889 * lisp.h: ... to here, so that the inline functions mentioned
7892 * dired.c (directory_files_internal_unwind): Now static.
7894 * fileio.c (file_name_as_directory, directory_file_name):
7895 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7897 (file_name_as_directory): Use const pointers when appropriate.
7898 (Fexpand_file_name): Likewise. In particular, newdir might
7899 point at constant storage, so make it a const pointer.
7900 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7901 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7903 (Fset_file_times, Finsert_file_contents, auto_save_error):
7904 Rename locals to avoid shadowing.
7906 * minibuf.c (choose_minibuf_frame_1): Now static.
7907 (Ftry_completion, Fall_completions): Rename or remove locals
7910 * marker.c (bytepos_to_charpos): Remove; unused.
7912 * lisp.h (verify_bytepos, count_markers): New decls,
7913 so that gcc does not warn that these functions aren't declared.
7915 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7916 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7917 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7918 (copy_text): Remove unused local var.
7920 * filelock.c (within_one_second): Now static.
7921 (lock_file_1): Rename local to avoid shadowing.
7923 * buffer.c (fix_overlays_before): Mark locals as initialized.
7924 (fix_start_end_in_overlays): Likewise. This function should be
7925 simplified by using pointers-to-pointers, but that's a different
7927 (switch_to_buffer_1): Now static.
7928 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7929 (report_overlay_modification): Rename locals to avoid shadowing.
7931 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7932 Fix pointer signedness issue.
7933 (sys_subshell): Mark local as volatile if checking for lint,
7934 to suppress a gcc -Wclobbered warning that does not seem to be right.
7935 (MAXPATHLEN): Define only if needed.
7937 * process.c (serial_open, serial_configure): Move decls from here ...
7938 * systty.h: ... to here, so that they can be checked.
7940 * fns.c (get_random, seed_random): Move extern decls from here ...
7941 * lisp.h: ... to here, so that they can be checked.
7943 * sysdep.c (reset_io): Now static.
7944 (wait_for_termination_signal): Remove; unused.
7946 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7947 (copy_keymap_item, append_key, push_text_char_description):
7949 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7950 (DENSE_TABLE_SIZE): Remove; unused.
7951 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7952 (describe_map_tree):
7953 Rename locals to avoid shadowing.
7955 * keyboard.c: Declare functions static if they are not used elsewhere.
7956 (echo_char, echo_dash, cmd_error, top_level_2):
7957 (poll_for_input, handle_async_input): Now static.
7958 (read_char, kbd_buffer_get_event, make_lispy_position):
7959 (make_lispy_event, make_lispy_movement, apply_modifiers):
7960 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7961 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7962 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7963 (read_key_sequence, read_char): Mark locals as initialized.
7964 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7966 * keyboard.h (make_ctrl_char): New decl.
7967 (mark_kboards): Move decl here ...
7968 * alloc.c (mark_kboards): ... from here.
7970 * lisp.h (force_auto_save_soon): New decl.
7972 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7973 (DEFINE_DUMMY_FUNCTION): New macro.
7974 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7976 (main): Add casts to avoid warnings
7977 if GCC considers string literals to be constants.
7979 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7981 * dbusbind.c: Pointer signedness fixes.
7982 (xd_signature, xd_append_arg, xd_initialize):
7983 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7984 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7985 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7986 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7988 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7989 if GCC considers string literals to be constants.
7990 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7992 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7994 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7995 (print_preprocess, print_object): New macro to fix last change.
7997 * print.c (print_preprocess): Don't forget font objects.
7999 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8001 * emacs.c (USAGE3): Doc fixes.
8003 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8005 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8008 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8010 * lisp.h (VWindow_system, Qfile_name_history):
8011 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8012 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8013 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8015 * w32select.c: Don't #include "keyboard.h".
8016 (run_protected): Add extern declaration for waiting_for_input.
8018 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8019 * w32console.c (detect_input_pending, read_input_pending)
8020 (encode_terminal_code):
8021 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8022 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8023 (w32_system_caret_y, Qfile_name_history):
8024 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8025 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8026 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8027 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8028 * w32proc.c (Qlocal, report_file_error):
8029 * w32term.c (Vwindow_system, updating_frame):
8030 * w32uniscribe.c (initialized, uniscribe_font_driver):
8031 Remove unneeded extern declarations.
8033 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8035 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8037 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8039 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8040 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8041 These macros can no longer be used for assignment.
8043 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8044 Assign struct members directly, instead of using BUF_BEGV etc.
8045 (record_buffer_markers, fetch_buffer_markers): New functions for
8046 recording and fetching special buffer markers.
8047 (set_buffer_internal_1, set_buffer_temp): Use them.
8049 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8051 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8053 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8054 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8056 * xdisp.c (hscroll_window_tree):
8057 (reconsider_clip_changes): Use PT instead of BUF_PT.
8059 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8061 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8062 $(EMACS_ROOT)/lib/intprops.h.
8064 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8066 Fix more problems found by GCC 4.5.2's static checks.
8068 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8069 to unsigned char * to avoid compiler diagnostic.
8070 (xg_free_frame_widgets): Make it clear that a local variable is
8071 needed only if USE_GTK_TOOLTIP.
8072 (gdk_window_get_screen): Make it clear that this macro is needed
8073 only if USE_GTK_TOOLTIP.
8074 (int_gtk_range_get_value): New function, which avoids a diagnostic
8075 from gcc -Wbad-function-cast.
8076 (xg_set_toolkit_scroll_bar_thumb): Use it.
8077 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8078 diagnostic from gcc -Wbad-function-cast.
8079 (get_utf8_string, xg_get_file_with_chooser):
8080 Rename locals to avoid shadowing.
8081 (create_dialog): Move locals to avoid shadowing.
8083 * xgselect.c (xg_select): Remove unused var.
8085 * image.c (four_corners_best): Mark locals as initialized.
8086 (gif_load): Initialize transparent_p to zero (Bug#8238).
8087 Mark another local as initialized.
8088 (my_png_error, my_error_exit): Mark with NO_RETURN.
8090 * image.c (clear_image_cache): Now static.
8091 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8092 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8093 (x_edge_detection): Remove unnecessary cast that
8094 gcc -Wbad-function-cast diagnoses.
8095 (gif_load): Fix pointer signedness.
8096 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8097 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8099 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8101 Improve quality of tests for time stamp overflow.
8102 For example, without this patch (encode-time 0 0 0 1 1
8103 1152921504606846976) returns the obviously-bogus value (-948597
8104 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8105 reports time overflow. See
8106 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8107 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8108 * editfns.c: Include limits.h and intprops.h.
8109 (TIME_T_MIN, TIME_T_MAX): New macros.
8110 (time_overflow): Move earlier, to before first use.
8111 (hi_time, lo_time): New functions, for an accurate test for
8113 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8114 (Fget_internal_run_time): Don't assume time_t fits in int.
8115 (make_time): Use list2 instead of Fcons twice.
8116 (Fdecode_time): More accurate test for out-of-range times.
8117 (check_tm_member): New function.
8118 (Fencode_time): Use it, to test for out-of-range times.
8119 (lisp_time_argument): Don't rely on undefined left-shift and
8120 right-shift behavior when checking for time stamp overflow.
8122 * editfns.c (time_overflow): New function, refactoring common code.
8123 (Fformat_time_string, Fdecode_time, Fencode_time):
8124 (Fcurrent_time_string): Use it.
8126 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8127 * dired.c (make_time): Move to ...
8128 * editfns.c (make_time): ... here.
8129 * systime.h: Note the move.
8131 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8133 * fringe.c (update_window_fringes): Remove unused variables.
8135 * unexmacosx.c (copy_data_segment): Also copy __got section.
8138 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8140 * termcap.c [MSDOS]: Include "msdos.h".
8141 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8142 Constify `char *' arguments and their references according to
8143 prototypes in tparam.h.
8145 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8147 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8148 Adapt all references accordingly.
8150 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8152 2011-03-11 Tom Tromey <tromey@redhat.com>
8154 * buffer.c (syms_of_buffer): Remove obsolete comment.
8156 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8158 * termhooks.h (encode_terminal_code): Declare prototype.
8160 * msdos.c (encode_terminal_code): Don't declare prototype.
8162 * term.c (encode_terminal_code): Now external again, used by
8163 w32console.c and msdos.c.
8165 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8166 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8168 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8170 Fix some minor problems found by GCC 4.5.2's static checks.
8172 * fringe.c (update_window_fringes): Mark locals as initialized
8174 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8176 * alloc.c (mark_fringe_data): Move decl from here ...
8177 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8178 to check its interface.
8179 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8181 * fontset.c (free_realized_fontset): Now static.
8182 (Fset_fontset_font): Rename local to avoid shadowing.
8183 (fontset_font): Mark local as initialized.
8184 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8186 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8188 * xselect.c (x_disown_buffer_selections): Remove; not used.
8189 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8190 (x_own_selection, Fx_disown_selection_internal): Rename locals
8192 (x_handle_dnd_message): Remove local to avoid shadowing.
8194 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8195 so that the caller can use some name other than gcpro1.
8196 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8197 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8198 (Fx_backspace_delete_keys_p):
8199 Use them to avoid shadowing, and rename vars to avoid shadowing.
8200 (x_decode_color, x_set_name, x_window): Now static.
8201 (Fx_create_frame): Add braces to silence GCC warning.
8202 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8203 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8204 Remove unused locals.
8205 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8206 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8207 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8210 * xterm.h (x_mouse_leave): New decl.
8212 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8213 Remove unused functions.
8214 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8215 (x_calc_absolute_position): Now static.
8216 (XTread_socket): Don't define label "out" unless it's used.
8217 Don't declare local "event" unless it's used.
8218 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8219 unless they are used.
8220 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8221 (x_fatal_error_signal): Remove; not used.
8222 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8223 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8224 (x_error_catcher, x_connection_closed, x_error_handler):
8225 (x_error_quitter, xembed_send_message, x_iconify_frame):
8226 (my_log_handler): Rename locals to avoid shadowing.
8227 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8228 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8230 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8231 Rename or move locals to avoid shadowing.
8232 (tty_defined_color, merge_face_heights): Now static.
8233 (free_realized_faces_for_fontset): Remove; not used.
8234 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8235 does not deduce is never used uninitialized.
8236 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8237 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8239 * terminal.c (store_terminal_param): Now static.
8241 * xmenu.c (menu_highlight_callback): Now static.
8242 (set_frame_menubar): Remove unused local.
8243 (xmenu_show): Rename parameter to avoid shadowing.
8244 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8245 since they might point to immutable storage.
8246 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8247 since it's unused otherwise.
8249 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8250 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8251 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8252 avoids a gcc -Wuninitialized diagnostic.
8253 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8254 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8255 does not deduce are never used uninitialized.
8257 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8259 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8260 * window.c (window_loop, size_window):
8261 (run_window_configuration_change_hook, enlarge_window): Likewise.
8263 * window.c (display_buffer): Now static.
8264 (size_window): Mark variables that gcc -Wuninitialized
8265 does not deduce are never used uninitialized.
8266 * window.h (check_all_windows): New decl, to forestall
8267 gcc -Wmissing-prototypes diagnostic.
8268 * dispextern.h (bidi_dump_cached_states): Likewise.
8270 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8272 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8274 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8275 and to avoid gcc -Wuninitialized warning.
8276 (load_charset_map): Mark variables that gcc -Wuninitialized
8277 does not deduce are never used uninitialized.
8278 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8280 * coding.c (coding_set_source, coding_set_destination):
8281 Use "else { /* comment */ }" rather than "else /* comment */;"
8282 for clarity, and to avoid gcc -Wempty-body warning.
8283 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8284 a block, when the outer 'i' will do.
8285 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8286 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8287 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8288 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8289 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8290 Rename locals to avoid shadowing.
8291 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8292 * coding.c (emacs_mule_char, encode_invocation_designation):
8293 Now static, since they're not used elsewhere.
8294 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8295 (decode_coding_object, encode_coding_object, detect_coding_system):
8296 (decode_coding_emacs_mule): Mark variables that gcc
8297 -Wuninitialized does not deduce are never used uninitialized.
8298 (detect_coding_iso_2022): Initialize a local variable that might
8299 be used uninitialized. Leave a FIXME because it's not clear that
8300 this initialization is needed. (Bug#8211)
8301 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8302 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8303 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8304 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8305 Remove unused macros.
8307 * category.c (hash_get_category_set): Remove unused local var.
8308 (copy_category_table): Now static, since it's not used elsewhere.
8309 * character.c (string_count_byte8): Likewise.
8311 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8312 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8314 * chartab.c (copy_sub_char_table): Now static, since it's not used
8316 (sub_char_table_ref_and_range, char_table_ref_and_range):
8317 Rename locals to avoid shadowing.
8318 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8320 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8321 (BIDI_BOB): Remove unused macro.
8323 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8324 deduce are never used uninitialized.
8325 * term.c (encode_terminal_code): Likewise.
8327 * term.c (encode_terminal_code): Now static. Remove unused local.
8329 * tparam.h: New file.
8330 * term.c, tparam.h: Include it.
8331 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8332 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8333 Move these decls to tparam.h, and make them agree with what
8334 is actually in tparam.c. The previous trick of using incompatible
8335 decls in different modules does not conform to the C standard.
8336 All callers of tparam changed to use tparam's actual API.
8337 * tparam.c (tparam1, tparam, tgoto):
8338 Use const pointers where appropriate.
8340 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8341 * cm.h (struct cm): Likewise.
8342 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8343 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8344 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8345 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8346 (turn_on_face, init_tty): Likewise.
8347 * termchar.h (struct tty_display_info): Likewise.
8349 * term.c (term_mouse_position): Rename local to avoid shadowing.
8351 * alloc.c (mark_ttys): Move decl from here ...
8352 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8354 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8356 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8358 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8360 * search.c (compile_pattern_1): Remove argument regp, unused since
8361 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8362 (compile_pattern): Don't pass it.
8364 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8366 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8367 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8369 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8371 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8373 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8374 gdk_window_get_screen, gdk_window_get_geometry,
8375 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8376 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8377 (xg_get_pixbuf_from_pixmap): New function.
8378 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8379 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8380 Call xg_get_pixbuf_from_pixmap instead of
8381 gdk_pixbuf_get_from_drawable.
8382 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8383 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8384 (xg_check_special_colors): Use GtkStyleContext and its functions
8386 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8387 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8388 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8389 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8390 Call gtk_widget_get_preferred_size.
8391 (xg_frame_resized): gdk_window_get_geometry only takes 5
8393 (xg_win_to_widget, xg_event_is_for_menubar):
8394 Call gdk_x11_window_lookup_for_display.
8395 (xg_set_widget_bg): New function.
8396 (delete_cb): New function.
8397 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8398 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8399 (xg_set_background_color): Call xg_set_widget_bg.
8400 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8401 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8402 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8403 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8405 (update_frame_tool_bar): Call gtk_widget_hide.
8406 (xg_initialize): Use GDK_KEY_g.
8408 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8410 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8412 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8413 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8414 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8416 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8418 * w32xfns.c (select_palette): Check success of RealizePalette against
8419 GDI_ERROR, not zero.
8421 See ChangeLog.11 for earlier changes.
8427 Copyright (C) 2011 Free Software Foundation, Inc.
8429 This file is part of GNU Emacs.
8431 GNU Emacs is free software: you can redistribute it and/or modify
8432 it under the terms of the GNU General Public License as published by
8433 the Free Software Foundation, either version 3 of the License, or
8434 (at your option) any later version.
8436 GNU Emacs is distributed in the hope that it will be useful,
8437 but WITHOUT ANY WARRANTY; without even the implied warranty of
8438 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8439 GNU General Public License for more details.
8441 You should have received a copy of the GNU General Public License
8442 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.