1 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8 (x_clipboard_manager_save): Add return value.
9 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
11 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12 Obey Vx_select_enable_clipboard_manager. Catch errors in
13 x_clipboard_manager_save (Bug#8779).
14 (Vx_select_enable_clipboard_manager): New variable.
15 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
17 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
19 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
21 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
23 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
24 in the current matrix if keep_current_p is non-zero.
26 2011-06-04 Eli Zaretskii <eliz@gnu.org>
28 * bidi.c (bidi_level_of_next_char): Fix last change.
30 2011-06-03 Eli Zaretskii <eliz@gnu.org>
32 Support bidi reordering of text covered by display properties.
34 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
35 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
36 (bidi_cache_search, bidi_cache_iterator_state)
37 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
38 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
39 character positions inside a run of characters covered by a
41 (bidi_paragraph_init, bidi_resolve_explicit_1)
42 (bidi_level_of_next_char): Call bidi_fetch_char and
43 bidi_fetch_char_advance instead of FETCH_CHAR and
45 (bidi_init_it): Initialize new members.
46 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
48 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
49 instead of using explicit *_CHAR codes.
50 (bidi_resolve_explicit, bidi_resolve_weak): Use
51 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
52 bidirectional text is supported only in multibyte buffers.
53 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
54 it to initialize the frame_window_p member of struct bidi_it.
55 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
56 (bidi_resolve_explicit, bidi_resolve_weak)
57 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
58 bidi_it->nchars is non-positive.
59 (bidi_level_of_next_char): Don't try to lookup the cache for the
60 next/previous character if nothing is cached there yet, or if we
61 were just reseat()'ed to a new position.
63 * xdisp.c (set_cursor_from_row): Set start and stop points
64 according to the row's direction when priming the loop that looks
65 for the glyph on which to display cursor.
66 (single_display_spec_intangible_p): Function deleted.
67 (display_prop_intangible_p): Reimplement to call
68 handle_display_spec instead of single_display_spec_intangible_p.
69 Accept 3 additional arguments needed by handle_display_spec. This
70 fixes incorrect cursor motion across display property with complex
71 values: lists, `(when COND...)' forms, etc.
72 (single_display_spec_string_p): Support property values that are
73 lists with the argument STRING its top-level element.
74 (display_prop_string_p): Fix the condition for processing a
75 property that is a list to be consistent with handle_display_spec.
76 (handle_display_spec): New function, refactored from the
77 last portion of handle_display_prop.
78 (compute_display_string_pos): Accept additional argument
79 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
80 value of a `display' property is a "replacing spec".
81 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
82 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
83 the display property, but just return a value indicating whether
84 the display property will replace the characters it covers.
85 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
86 frame_window_p members of struct bidi_it.
87 (compute_display_string_pos, compute_display_string_end): New
89 (push_it): Accept second argument POSITION, where pop_it should
90 jump to continue iteration.
91 (reseat_1): Initialize bidi_it.disp_pos.
93 * keyboard.c (adjust_point_for_property): Adjust the call to
94 display_prop_intangible_p to its new signature.
96 * dispextern.h (struct bidi_it): New member frame_window_p.
97 (bidi_init_it): Update prototypes.
98 (display_prop_intangible_p): Update prototype.
99 (compute_display_string_pos, compute_display_string_end): Declare
101 (struct bidi_it): New members nchars and disp_pos. ch_len is now
104 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
106 Malloc failure behavior now depends on size of allocation.
107 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
108 * lisp.h: Change signatures accordingly.
109 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
110 All callers changed. (Bug#8762)
112 * gnutls.c: Use Emacs's memory allocators.
113 Without this change, the gnutls library would invoke malloc etc.
114 directly, which causes problems on non-SYNC_INPUT hosts, and which
115 runs afoul of improving memory_full behavior. (Bug#8761)
116 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
117 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
118 xfree instead of the default malloc, realloc, free.
119 (Fgnutls_boot): No need to check for memory allocation failure,
120 since xmalloc does that for us.
122 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
123 * category.c (hash_get_category_set):
124 * ccl.c (ccl_driver):
125 * charset.c (Fdefine_charset_internal):
126 * charset.h (struct charset.hash_index):
127 * composite.c (get_composition_id, gstring_lookup_cache)
128 (composition_gstring_put_cache):
129 * composite.h (struct composition.hash_index):
130 * dispextern.h (struct image.hash):
131 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
132 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
133 (hashfn_equal, hashfn_user_defined, make_hash_table)
134 (maybe_resize_hash_table, hash_lookup, hash_put)
135 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
136 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
137 (Fsxhash, Fgethash, Fputhash, Fmaphash):
138 * image.c (make_image, search_image_cache, lookup_image)
139 (xpm_put_color_table_h):
140 * lisp.h (struct Lisp_Hash_Table):
141 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
142 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
143 for hashes and hash indexes, instead of 'unsigned' and 'int'.
144 * alloc.c (allocate_vectorlike):
145 Check for overflow in vector size calculations.
146 * ccl.c (ccl_driver):
147 Check for overflow when converting EMACS_INT to int.
148 * fns.c, image.c: Remove unnecessary static decls that would otherwise
149 need to be updated by these changes.
150 * fns.c (make_hash_table, maybe_resize_hash_table):
151 Check for integer overflow with large hash tables.
152 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
153 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
154 (SXHASH_REDUCE): New macro.
155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
156 Use it instead of discarding useful hash info with large hash values.
157 (sxhash_float): New function.
158 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
159 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
160 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
161 Rewrite to use FIXNUM_BITS, as this simplifies things.
162 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
163 Adjust signatures to match updated version of code.
164 (consing_since_gc): Now EMACS_INT, since a single hash table can
165 use more than INT_MAX bytes.
167 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
169 Make it possible to build with GCC-4.6+ -O2 -flto.
171 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
173 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
175 * minibuf.c (get_minibuffer, read_minibuf_unwind):
176 Call minibuffer-inactive-mode.
178 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
180 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
183 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
185 * data.c (init_data): Remove code for UTS, this system is not
188 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
190 Don't force ./temacs to start in terminal mode.
192 * frame.c (make_initial_frame): Initialize faces in all cases, not
193 only when CANNOT_DUMP is defined.
194 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
196 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
198 * dispnew.c (add_window_display_history): Use const for the string
199 pointer. Remove declaration, not needed.
201 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
203 Use 'inline', not 'INLINE'.
204 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
205 * alloc.c, fontset.c (INLINE): Remove.
206 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
207 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
208 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
209 * gmalloc.c (register_heapinfo): Use inline unconditionally.
210 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
212 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
214 Make it possible to run ./temacs.
216 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
217 syms_of_callproc does the same thing. Remove test for
218 "initialized", do it in the caller.
219 * emacs.c (main): Avoid calling set_initial_environment when dumping.
221 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
223 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
224 (read_minibuf): Use get_minibuffer.
225 (syms_of_minibuf): Use DEFSYM.
226 (Qmetadata): New var.
227 * data.c (Qbuffer): Don't make it static.
228 (syms_of_data): Use DEFSYM.
230 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
232 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
233 (CCL_CODE_MIN): New macro.
235 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
237 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
239 * eval.c (Qdebug): Now static.
240 * lisp.h (Qdebug): Remove decl. This reverts a part of the
241 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
242 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
244 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
246 * image.c: Various fixes to ImageMagick code comments.
247 (Fimagemagick_types): Doc fix.
249 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
251 Minor fixes prompted by GCC 4.6.0 warnings.
253 * xselect.c (converted_selections, conversion_fail_tag): Now static.
255 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
256 (x_clipboard_manager_save_all): Move extern decl to ...
257 * xterm.h: ... here, so that it can be checked for consistency.
259 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
261 * xselect.c (x_clipboard_manager_save_frame)
262 (x_clipboard_manager_save_all): New functions.
263 (Fx_clipboard_manager_save): Lisp function deleted.
265 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
266 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
268 * xterm.h: Update prototype.
270 2011-05-28 William Xu <william.xwl@gmail.com>
272 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
275 2011-05-28 Jim Meyering <meyering@redhat.com>
277 Avoid a sign-extension bug in crypto_hash_function.
278 * fns.c (to_uchar): Define.
279 (crypto_hash_function): Use it to convert some newly-signed
280 variables to unsigned, to avoid sign-extension bugs. For example,
281 without this change, (md5 "truc") would evaluate to
282 45723a2aff78ff4fff7fff1114760e62 rather than the expected
283 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
284 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
286 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
288 Integer overflow fixes.
290 * dbusbind.c: Serial number integer overflow fixes.
291 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
292 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
293 to hold a serial number that is too large for a fixnum.
294 (Fdbus_method_return_internal, Fdbus_method_error_internal):
295 Check for serial numbers out of range. Decode any serial number
296 that was so large that it became a float. (Bug#8722)
298 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
300 Use XFASTINT rather than XUINT when numbers are nonnegative.
301 (xd_append_arg, Fdbus_method_return_internal):
302 (Fdbus_method_error_internal): Likewise. Also, for unsigned
303 arguments, check that Lisp number is nonnegative, rather than
304 silently wrapping negative numbers around. (Bug#8722)
305 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
308 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
310 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
312 ccl: add integer overflow checks
313 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
314 (IN_INT_RANGE): New macros.
315 (ccl_driver): Use them to check for integer overflow when
316 decoding a CCL program. Many of the new checks are whether XINT (x)
317 fits in int; it doesn't always, on 64-bit hosts. The new version
318 doesn't catch all possible integer overflows, but it's an
319 improvement. (Bug#8719)
321 * alloc.c (make_event_array): Use XINT, not XUINT.
322 There's no need for unsigned here.
324 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
325 This follows up to the 2011-05-06 change that substituted uintptr_t
326 for EMACS_INT. This case wasn't caught back then.
328 Rework Fformat to avoid integer overflow issues.
329 * editfns.c: Include <float.h> unconditionally, as it's everywhere
330 now (part of C89). Include <verify.h>.
331 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
332 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
333 (Fformat): Avoid the prepass trying to compute sizes; it was only
334 approximate and thus did not catch overflow reliably. Instead, walk
335 through the format just once, formatting and computing sizes as we go,
336 checking for integer overflow at every step, and allocating a larger
337 buffer as needed. Keep track separately whether the format is
338 multibyte. Keep only the most-recently calculated precision, rather
339 than them all. Record whether each argument has been converted to
340 string. Use EMACS_INT, not int, for byte and char and arg counts.
341 Support field widths and precisions larger than INT_MAX. Avoid
342 sprintf's undefined behavior with conversion specifications such as %#d
343 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
344 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
345 formatting out-of-range floating point numbers with int
348 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
350 * data.c: Avoid integer truncation in expressions involving floats.
351 * data.c: Include <intprops.h>.
352 (arith_driver): When there's an integer overflow in an expression
353 involving floating point, convert the integers to floating point
354 so that the resulting value does not suffer from catastrophic
355 integer truncation. For example, on a 64-bit host (* 4
356 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
357 Do not rely on undefined behavior after integer overflow.
359 merge count_size_as_multibyte, parse_str_to_multibyte
360 * character.c, character.h (count_size_as_multibyte):
361 Rename from parse_str_to_multibyte; all uses changed.
362 Check for integer overflow.
363 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
364 since it's now a duplicate of the other. This is more of
365 a character than a buffer op, so better that it's in character.c.
366 * fns.c, print.c: Adjust to above changes.
368 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
370 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
372 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
374 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
375 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
376 (x_clipboard_manager_save): Now static.
377 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
379 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
380 (crypto_hash_function): Now static.
381 Fix pointer signedness problems. Avoid unnecessary initializations.
383 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
385 * termhooks.h (Vselection_alist): Make it terminal-local.
387 * terminal.c (create_terminal): Initialize it.
389 * xselect.c: Support for clipboard managers.
390 (Vselection_alist): Move to termhooks.h as terminal-local var.
391 (LOCAL_SELECTION): New macro.
392 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
393 (symbol_to_x_atom): Remove gratuitous arg.
394 (x_handle_selection_request, lisp_data_to_selection_data)
395 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
396 (x_own_selection, x_get_local_selection, x_convert_selection):
397 New arg, specifying work frame. Use terminal-local Vselection_alist.
398 (some_frame_on_display): Delete unused function.
399 (Fx_own_selection_internal, Fx_get_selection_internal)
400 (Fx_disown_selection_internal, Fx_selection_owner_p)
401 (Fx_selection_exists_p): New optional frame arg.
402 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
403 (x_handle_selection_clear): Don't treat other terminals with the
404 same keyboard specially. Use the terminal-local Vselection_alist.
405 (x_clear_frame_selections): Use Frun_hook_with_args.
407 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
409 * xterm.h: Add support for those atoms.
411 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
413 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
414 (converted_selections, conversion_fail_tag): New global variables.
415 (x_selection_request_lisp_error): Free the above.
416 (x_get_local_selection): Remove unnecessary code.
417 (x_reply_selection_request): Args changed; handle arbitrary array
418 of converted selections stored in converted_selections.
419 Separate the XChangeProperty and SelectionNotify steps.
420 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
421 (x_convert_selection): New function.
422 (x_handle_selection_event): Simplify.
423 (x_get_foreign_selection): Don't ignore incoming requests while
424 waiting for an answer; this will fail when we implement
425 SAVE_TARGETS, and seems unnecessary anyway.
426 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
427 (Vx_sent_selection_functions): Doc fix.
429 2011-05-26 Leo Liu <sdl.web@gmail.com>
431 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
433 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
435 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
437 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
438 for fringe update if it has periodic bitmap.
439 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
440 and fringe_bitmap_periodic_p.
442 * fringe.c (get_fringe_bitmap_data): New function.
443 (draw_fringe_bitmap_1, update_window_fringes): Use it.
444 (update_window_fringes): Record periodicity of fringe bitmap in glyph
445 row. Mark glyph row for fringe update if periodicity changed.
447 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
448 for fringe update unless it has periodic bitmap.
450 2011-05-25 Kenichi Handa <handa@m17n.org>
452 * xdisp.c (get_next_display_element): Set correct it->face_id for
453 a static composition.
455 2011-05-24 Leo Liu <sdl.web@gmail.com>
458 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
460 * fns.c (crypto_hash_function, Fsha1): New function.
461 (Fmd5): Use crypto_hash_function.
462 (syms_of_fns): Add Ssha1.
464 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
466 * gnutls.c: Remove unused macros.
467 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
468 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
469 Remove macros that are defined and never used.
470 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
472 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
474 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
475 (Fx_get_selection_internal): Minor cleanup.
476 (Fx_own_selection_internal): Rename arguments for consistency with
479 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
481 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
483 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
485 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
487 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
489 * dispnew.c (scrolling_window): Don't exclude the case that the
490 last enabled row in the desired matrix touches the bottom boundary.
492 2011-05-21 Glenn Morris <rgm@gnu.org>
494 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
495 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
496 and add some more files.
498 2011-05-20 Eli Zaretskii <eliz@gnu.org>
500 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
501 report_file_error introduced by the change from 2011-05-07.
503 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
505 * systime.h (Time): Define only if emacs is defined.
506 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
507 where the include path doesn't have X11/X.h by default. See
508 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
510 2011-05-20 Kenichi Handa <handa@m17n.org>
512 * composite.c (find_automatic_composition): Fix previous change.
514 2011-05-20 Glenn Morris <rgm@gnu.org>
516 * lisp.mk: New file, split from Makefile.in.
517 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
519 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
521 2011-05-19 Glenn Morris <rgm@gnu.org>
523 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
524 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
525 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
526 (lisp): Set the order to that of loadup.el.
527 (shortlisp): Make it a copy of $lisp.
528 (SOME_MACHINE_LISP): Remove.
529 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
530 Use just $shortlisp, not $SOME_MACHINE_LISP too.
532 2011-05-18 Kenichi Handa <handa@m17n.org>
534 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
535 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
536 (find_automatic_composition): Mostly rewrite for efficiency.
538 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
540 * makefile.w32-in: Update dependencies.
542 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
544 * menu.c: Include limits.h (fixes the MS-Windows build broken by
547 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
549 Fix some integer overflow issues, such as string length overflow.
551 * insdel.c (count_size_as_multibyte): Check for string overflow.
553 * character.c (lisp_string_width): Check for string overflow.
554 Use EMACS_INT, not int, for string indexes and lengths; in
555 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
556 the resulting string length overflows an EMACS_INT; instead,
557 report a string overflow if no precision given. When checking for
558 precision exhaustion, use a check that cannot possibly have
559 integer overflow. (Bug#8675)
560 * character.h (lisp_string_width): Adjust to new signature.
562 * alloc.c (string_overflow): New function.
563 (Fmake_string): Use it. This doesn't change behavior, but saves
564 a few bytes and will simplify future changes.
565 * character.c (string_escape_byte8): Likewise.
566 * lisp.h (string_overflow): New decl.
568 Fixups, following up to the user-interface timestamp change.
569 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
570 for UI timestamps, instead of unsigned long.
571 * msdos.c (mouse_get_pos): Likewise.
572 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
573 * w32gui.h (Time): Define by including "systime.h" rather than by
574 declaring it ourselves. (Bug#8664)
576 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
577 * image.c (clear_image_cache): Likewise.
579 * term.c (term_mouse_position): Don't assume time_t wraparound.
581 Be more systematic about user-interface timestamps.
582 Before, the code sometimes used 'Time', sometimes 'unsigned long',
583 and sometimes 'EMACS_UINT', to represent these timestamps.
584 This change causes it to use 'Time' uniformly, as that's what X uses.
585 This makes the code easier to follow, and makes it easier to catch
586 integer overflow bugs such as Bug#8664.
587 * frame.c (Fmouse_position, Fmouse_pixel_position):
588 Use Time, not unsigned long, for user-interface timestamps.
589 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
590 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
591 * keyboard.h (last_event_timestamp): Likewise.
592 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
593 * menu.h (xmenu_show): Likewise.
594 * term.c (term_mouse_position): Likewise.
595 * termhooks.h (struct input_event.timestamp): Likewise.
596 (struct terminal.mouse_position_hook): Likewise.
597 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
598 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
599 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
600 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
602 * menu.h, termhooks.h: Include "systime.h", for Time.
604 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
605 Don't assume that the difference between two unsigned long values
606 can fit into an integer. At this point, we know button_down_time
607 <= event->timestamp, so the difference must be nonnegative, so
608 there's no need to cast the result if double-click-time is
609 nonnegative, as it should be; check that it's nonnegative, just in
610 case. This bug is triggered when events are more than 2**31 ms
611 apart (about 25 days). (Bug#8664)
613 * xselect.c (last_event_timestamp): Remove duplicate decl.
614 (x_own_selection): Remove needless cast to unsigned long.
616 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
617 that always fit in int. Use a sentinel instead of a counter, to
618 avoid a temp and to allay GCC's concerns about possible int overflow.
619 * frame.h (struct frame): Use int for menu_bar_items_used
620 instead of EMACS_INT, since it always fits in int.
622 * menu.c (grow_menu_items): Check for int overflow.
624 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
626 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
627 Before, the code was not consistent. These values cannot exceed
628 2**31 - 1 so there's no need to make them unsigned.
629 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
630 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
631 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
633 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
635 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
636 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
637 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
638 presumably because the widths might not match.
640 * window.c (size_window): Avoid needless test at loop start.
642 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
644 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
646 2011-05-12 Drew Adams <drew.adams@oracle.com>
648 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
650 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
652 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
653 `width' to `bar_area_x' and `bar_area_width', respectively.
654 (x_scroll_run): Take account of fringe background extension.
656 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
657 Rename local vars `left' and `width' to `bar_area_x' and
658 `bar_area_width', respectively.
659 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
660 background extension.
662 2011-05-10 Jim Meyering <meyering@redhat.com>
664 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
666 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
668 * image.c (Finit_image_library): Return t for built-in image types,
669 like pbm and xbm. (Bug#8640)
671 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
673 * w32menu.c (set_frame_menubar): Fix submenu allocation.
675 2011-05-07 Eli Zaretskii <eliz@gnu.org>
677 * w32console.c (Fset_screen_color): Doc fix.
678 (Fget_screen_color): New function.
679 (syms_of_ntterm): Defsubr it.
681 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
682 unlink the temporary file if Fcall_process didn't create it in the
684 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
685 child process will be redirected to a file specified with `:file'.
686 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
687 cue to call_process_cleanup not to close that handle.
689 2011-05-07 Ben Key <bkey76@gmail.com>
691 * makefile.w32-in: The bootstrap-temacs rule now makes use of
692 one of two shell specific rules, either bootstrap-temacs-CMD or
693 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
694 to the previous implementation of the bootstrap-temacs rule.
695 The bootstrap-temacs-CMD rule is similar to the previous
696 implementation of the bootstrap-temacs rule except that it
697 makes use of the ESC_CFLAGS variable instead of the CFLAGS
700 These changes, along with some changes to nt/configure.bat,
701 nt/gmake.defs, and nt/nmake.defs, are required to extend my
702 earlier fix to add support for --cflags and --ldflags options
703 that include quotes so that it works whether make uses cmd or
706 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
708 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
709 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
711 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
712 a string. Handle both cases.
713 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
714 (Fdbus_register_method): Use Qinvalid_function.
716 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
718 * makefile.w32-in: Update dependencies.
719 (LISP_H): Add inttypes.h and stdin.h.
720 (PROCESS_H): Add unistd.h.
722 2011-05-06 Eli Zaretskii <eliz@gnu.org>
724 * lread.c: Include limits.h (fixes the MS-Windows build broken by
725 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
727 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
729 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
731 * term.c (vfatal): Remove stray call to va_end.
732 It's not needed and the C Standard doesn't allow it here anyway.
734 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
735 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
737 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
740 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
742 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
744 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
746 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
748 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
750 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
751 * charset.c (Fdefine_charset_internal): Don't initialize
752 charset.code_space[15]. The value was garbage, on hosts with
753 32-bit int (Bug#8600).
755 * lread.c (read_integer): Be more consistent with string-to-number.
756 Use string_to_number to do the actual conversion; this avoids
757 rounding errors and fixes some other screwups. Without this fix,
758 for example, #x1fffffffffffffff was misread as -2305843009213693952.
759 (digit_to_number): Move earlier, for benefit of read_integer.
760 Return -1 if the digit is out of range for the base, -2 if it is
761 not a digit in any supported base. (Bug#8602)
763 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
765 * dispnew.c (scrolling_window): Return 1 if we scrolled,
766 to match comment at start of function. This also removes a
767 GCC warning about overflow in a 32+64-bit port.
769 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
771 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
772 Reported by Stefan Monnier in
773 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
774 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
775 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
777 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
778 (EMACS_UINTPTR): Likewise, with uintptr_t.
780 * lisp.h: Prefer 64-bit EMACS_INT if available.
781 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
782 on 32-bit hosts that have 64-bit int, so that they can access
784 However, temporarily disable this change unless the temporary
785 symbol WIDE_EMACS_INT is defined.
787 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
789 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
790 This removes an assumption that EMACS_INT and long are the same
791 width as pointers. The assumption is true for Emacs porting targets
792 now, but we want to make other targets possible.
793 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
794 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
795 In the rest of the code, change types of integers that hold casted
796 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
797 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
798 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
799 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
800 No need to cast type when ORing.
801 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
802 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
803 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
804 assume EMACS_INT is the same width as char *.
805 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
806 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
807 Remove no-longer-needed casts.
808 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
809 (xg_tool_bar_help_callback, xg_make_tool_item):
810 Use EMACS_INTPTR to hold an integer
811 that will be cast to void *; this can avoid a GCC warning
812 if EMACS_INT is not the same width as void *.
813 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
814 * xdisp.c (display_echo_area_1, resize_mini_window_1):
815 (current_message_1, set_message_1):
816 Use a local to convert to proper width without a cast.
817 * xmenu.c (dialog_selection_callback): Likewise.
819 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
820 Also, don't assume VALBITS / RAND_BITS is less than 5,
821 and don't rely on undefined behavior when shifting a 1 left into
823 * lisp.h (get_random): Change signature to match.
825 * lread.c (hash_string): Use size_t, not int, for hash computation.
826 Normally we prefer signed values; but hashing is special, because
827 it's better to use unsigned division on hash table sizes so that
828 the remainder is nonnegative. Also, size_t is the natural width
829 for hashing into memory. The previous code used 'int', which doesn't
830 retain enough info to hash well into very large tables.
831 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
833 * dbusbind.c: Don't possibly lose pointer info when converting.
834 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
835 Use XPNTR rather than XHASH, so that the high-order bits of
836 the pointer aren't lost when converting through void *.
838 * eval.c (Fautoload): Don't double-shift a pointer.
840 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
842 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
844 * gnutls.c (DEF_GNUTLS_FN):
845 * image.c (DEF_IMGLIB_FN): Make function pointers static.
847 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
849 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
852 2011-05-05 Eli Zaretskii <eliz@gnu.org>
854 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
855 New version that can reserve upto 2GB of heap space.
857 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
859 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
861 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
863 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
864 `gnutls_certificate_set_x509_key_file'.
866 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
868 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
871 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
873 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
874 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
875 Remove unused parameter `fildes'.
876 * process.c (read_process_output, send_process): Don't pass it.
878 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
880 Fix previous change: the library cache is defined in w32.c.
881 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
882 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
884 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
886 Implement dynamic loading of GnuTLS on Windows.
888 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
889 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
890 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
893 * gnutls.c (Qgnutls_dll): Define.
894 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
895 (gnutls_*): Declare function pointers.
896 (init_gnutls_functions): New function to initialize function pointers.
897 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
898 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
899 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
900 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
901 (emacs_gnutls_write, emacs_gnutls_read)
902 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
903 (Fgnutls_available_p): New function.
904 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
905 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
906 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
908 * image.c: Include w32.h.
909 (Vimage_type_cache): Delete.
910 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
911 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
912 (w32_delayed_load): Move to w32.c.
914 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
916 * w32.c (QCloaded_from, Vlibrary_cache): Define.
917 (w32_delayed_load): Move from image.c. When loading a library, record
918 its filename in the :loaded-from property of the library id.
919 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
920 Initialize and staticpro them.
921 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
923 * process.c: Include lisp.h before w32.h, not after.
924 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
925 instead of gnutls_record_check_pending.
927 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
929 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
931 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
932 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
935 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
937 * xterm.c (x_set_frame_alpha): Do not set property on anything
938 else than FRAME_X_OUTER_WINDOW (Bug#8608).
940 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
942 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
944 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
946 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
947 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
948 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
949 (gnutls_global_initialized, Qgnutls_bootprop_priority)
950 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
951 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
952 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
953 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
954 (Qgnutls_bootprop_callbacks_verify): Make static.
956 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
958 * callproc.c: Indentation fixup.
960 * sysdep.c (wait_for_termination_1): Make static.
961 (wait_for_termination, interruptible_wait_for_termination):
962 Move after wait_for_termination_1.
964 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
966 * sysdep.c (interruptible_wait_for_termination): New function
967 which is like wait_for_termination, but allows keyboard
970 * callproc.c (Fcall_process): Add (:file "file") as an option for
972 (Fcall_process_region): Ditto.
974 2011-04-30 Eli Zaretskii <eliz@gnu.org>
976 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
977 rather than `XVECTOR (FOO)->size'.
979 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
980 inttypes.h, as a gnulib replacement is used if it not available in
983 2011-04-21 Eli Zaretskii <eliz@gnu.org>
985 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
986 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
987 of MOST_POSITIVE_FIXNUM. (Bug#8528)
989 * coding.c (coding_alloc_by_realloc): Error out if destination
990 will grow beyond MOST_POSITIVE_FIXNUM.
991 (decode_coding_emacs_mule): Abort if there isn't enough place in
992 charbuf for the composition carryover bytes. Reserve an extra
993 space for up to 2 characters produced in a loop.
994 (decode_coding_iso_2022): Abort if there isn't enough place in
995 charbuf for the composition carryover bytes.
997 2011-04-21 Eli Zaretskii <eliz@gnu.org>
999 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1000 aborting when %lld or %lll format is passed.
1001 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1002 %llo or %llx format is passed. (Bug#8545)
1004 * window.c (window_scroll_line_based): Use a marker instead of
1005 simple variables to record original value of point. (Bug#7952)
1007 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1008 produced by %s or %c overflows available buffer space. (Bug#8545)
1010 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1012 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1013 (SIZE_MAX): Move defn after all includes, as they might #define it.
1015 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1017 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1019 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1021 * keyboard.c (Qdelayed_warnings_hook): Define.
1022 (command_loop_1): Run `delayed-warnings-hook'
1023 if Vdelayed_warnings_list is non-nil.
1024 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1025 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1027 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1029 * doprnt.c (doprnt): Don't return value smaller than the buffer
1030 size if the message was truncated. (Bug#8545).
1032 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1034 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1035 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1037 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1039 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1041 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1043 * makefile.w32-in: Update dependencies.
1045 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1047 Improve `doprnt' and its usage. (Bug#8545)
1048 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1049 `format_end'. Remove support for %l as a conversion specifier.
1050 Don't use xrealloc. Improve diagnostics when the %l size modifier
1051 is used. Update the commentary.
1053 * eval.c (verror): Simplify calculation of size_t.
1055 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1058 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1060 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1063 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1065 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1066 This makes this file independent of the recent pseudovector change.
1068 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1070 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1072 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1073 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1074 Remove unused local.
1075 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1077 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1078 GCC 4.6.0 optimizes based on type-based alias analysis.
1079 For example, if b is of type struct buffer * and v of type struct
1080 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1081 != &v->size, and therefore "v->size = 1; b->size = 2; return
1082 v->size;" must therefore return 1. This assumption is incorrect
1083 for Emacs, since it type-puns struct Lisp_Vector * with many other
1084 types. To fix this problem, this patch adds a new type struct
1085 vectorlike_header that documents the constraints on layout of vectors
1086 and pseudovectors, and helps optimizing compilers not get fooled
1087 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1088 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1089 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1091 (XSETPVECTYPE): Rewrite in terms of new macro.
1092 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1093 This is a bit clearer, and further avoids the possibility of
1094 undesirable aliasing.
1095 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1096 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1097 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1098 since Lisp_Subr is a special case (no "next" field).
1099 (ASIZE): Now uses header.size rather than size.
1100 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1101 to avoid the hassle of writing XVECTOR (foo)->header.size.
1102 (struct vectorlike_header): New type.
1103 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1104 object, to help avoid aliasing.
1105 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1106 (SUBRP): Likewise, since Lisp_Subr is a special case.
1107 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1108 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1109 (struct Lisp_Hash_Table): Combine first two members into a single
1110 struct vectorlike_header member. All uses of "size" and "next" members
1111 changed to be "header.size" and "header.next".
1112 * buffer.h (struct buffer): Likewise.
1113 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1114 * frame.h (struct frame): Likewise.
1115 * process.h (struct Lisp_Process): Likewise.
1116 * termhooks.h (struct terminal): Likewise.
1117 * window.c (struct save_window_data, struct saved_window): Likewise.
1118 * window.h (struct window): Likewise.
1119 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1120 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1121 * buffer.c (init_buffer_once): Likewise.
1122 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1124 * process.c (Fformat_network_address): Use local var for size,
1127 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1129 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1130 * data.c (atof): Remove decl; no longer used or needed.
1131 (digit_to_number): Move to lread.c.
1132 (Fstring_to_number): Use new string_to_number function, to be
1133 consistent with how the Lisp reader treats infinities and NaNs.
1134 Do not assume that floating-point numbers represent EMACS_INT
1135 without losing information; this is not true on most 64-bit hosts.
1136 Avoid double-rounding errors, by insisting on integers when
1137 parsing non-base-10 numbers, as the documentation specifies.
1138 * lisp.h (string_to_number): New decl, replacing ...
1139 (isfloat_string): Remove.
1140 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1141 (read1): Do not accept +. and -. as integers; this
1142 appears to have been a coding error. Similarly, do not accept
1143 strings like +-1e0 as floating point numbers. Do not report
1144 overflow for integer overflows unless the base is not 10 which
1145 means we have no simple and reliable way to continue.
1146 Break out the floating-point parsing into a new
1147 function string_to_number, so that Fstring_to_number parses
1148 floating point numbers consistently with the Lisp reader.
1149 (digit_to_number): Move here from data.c. Make it static inline.
1150 (E_CHAR, EXP_INT): Remove, replacing with ...
1151 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1152 (string_to_number): New function, replacing isfloat_string.
1153 This function checks for valid syntax and produces the resulting
1154 Lisp float number too. Rework it so that string-to-number
1155 no longer mishandles examples like "1.0e+". Use strtoumax,
1156 so that overflow for non-base-10 numbers is reported only when
1157 there's no portable and simple way to convert to floating point.
1159 * textprop.c (set_text_properties_1): Rewrite for clarity,
1160 and to avoid GCC warning about integer overflow.
1162 * intervals.h (struct interval): Use EMACS_INT for members
1163 where EMACS_UINT might cause problems. See
1164 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1165 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1166 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1168 (offset_intervals): Tell GCC not to worry about length overflow
1169 when negating a negative length.
1171 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1172 (overrun_check_free): Likewise.
1174 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1175 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1178 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1179 (gnutls_make_error): Rename local to avoid shadowing.
1180 (gnutls_emacs_global_deinit): ifdef out; not used.
1181 (Fgnutls_boot): Use const for pointer to readonly storage.
1182 Comment out unused local. Fix pointer signedness problems.
1184 * lread.c (openp): Don't stuff size_t into an 'int'.
1185 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1186 about possible signed overflow.
1188 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1189 (GDK_KEY_g): Don't define if already defined.
1190 (xg_prepare_tooltip): Avoid pointer signedness problem.
1191 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1193 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1194 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1196 * xfns.c (Fx_window_property): Simplify a bit,
1197 to make a bit faster and to avoid GCC 4.6.0 warning.
1198 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1200 * fns.c (internal_equal): Don't assume size_t fits in int.
1202 * alloc.c (compact_small_strings): Tighten assertion a little.
1204 Replace pEd with more-general pI, and fix some printf arg casts.
1205 * lisp.h (pI): New macro, generalizing old pEd macro to other
1206 conversion specifiers. For example, use "...%"pI"d..." rather
1207 than "...%"pEd"...".
1208 (pEd): Remove. All uses replaced with similar uses of pI.
1209 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1210 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1211 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1212 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1213 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1214 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1215 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1217 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1218 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1219 * print.c (safe_debug_print, print_object): Likewise.
1220 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1222 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1223 avoiding the 0 flag, which is not portable.
1224 * process.c (Fmake_network_process): Use pI to avoid cast.
1225 * region-cache.c (pp_cache): Likewise.
1226 * xdisp.c (decode_mode_spec): Likewise.
1227 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1228 behavior on 64-bit hosts with printf arg.
1229 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1230 (x_stop_queuing_selection_requests): Likewise.
1231 (x_get_window_property): Don't truncate byte count to an 'int'
1234 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1235 here, since it parses constructs like leading '-' and spaces,
1236 which are not wanted; and it overflows with large numbers.
1237 Instead, simply match F[0-9]+, which is what is wanted anyway.
1239 * alloc.c: Remove unportable assumptions about struct layout.
1240 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1241 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1242 (allocate_vectorlike, make_pure_vector): Use the new macros,
1243 plus offsetof, to remove unportable assumptions about struct layout.
1244 These assumptions hold on all porting targets that I know of, but
1245 they are not guaranteed, they're easy to remove, and removing them
1246 makes further changes easier.
1248 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1249 This doesn't fix a bug but makes the code clearer.
1250 (string_overrun_cookie): Now const. Use initializers that
1251 don't formally overflow signed char, to avoid warnings.
1252 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1253 can cause Emacs to crash when string overrun checking is enabled.
1254 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1255 multiple of sizeof (EMACS_INT); it need not be, if
1256 alignof(EMACS_INT) < sizeof (EMACS_INT).
1257 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1259 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1261 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1263 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1265 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1266 supposed to be handshaking. (Bug#8556)
1267 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1269 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1271 * lisp.h (Qdebug): List symbol.
1272 * eval.c (Qdebug): Restore global linkage.
1273 * keyboard.c (debug-on-event): New variable.
1274 (handle_user_signal): Break into debugger when debug-on-event
1275 matches the current signal symbol.
1277 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1279 * alloc.c (check_sblock, check_string_bytes)
1280 (check_string_free_list): Convert to standard C.
1282 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1284 * w32.c (emacs_gnutls_push): Fix typo.
1286 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1288 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1289 "cast to pointer from integer of different size".
1291 Improve doprnt and its use in verror. (Bug#8545)
1292 * doprnt.c (doprnt): Document the set of format control sequences
1293 supported by the function. Use SAFE_ALLOCA instead of always
1296 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1297 is one byte too soon. Don't use xrealloc; instead xfree and
1300 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1302 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1305 * gnutls.c: Renamed global_initialized to
1306 gnutls_global_initialized. Added internals for the
1307 :verify-hostname-error, :verify-error, and :verify-flags
1308 parameters of `gnutls-boot' and documented those parameters in the
1309 docstring. Start callback support.
1310 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1311 unless a fatal error occured. Call gnutls_alert_send_appropriate
1312 on error. Return error code.
1313 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1314 (emacs_gnutls_read): Likewise.
1315 (Fgnutls_boot): Return handshake error code.
1316 (emacs_gnutls_handle_error): New function.
1317 (wsaerror_to_errno): Likewise.
1319 * w32.h (emacs_gnutls_pull): Add prototype.
1320 (emacs_gnutls_push): Likewise.
1322 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1323 (emacs_gnutls_push): Likewise.
1325 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1327 * process.c (wait_reading_process_output): Check if GnuTLS
1328 buffered some data internally if no FDs are set for TLS
1331 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1332 (LIBS): Link to USER_LIBS.
1333 ($(BLD)/gnutls.$(0)): New target.
1335 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1337 * xdisp.c (handle_single_display_spec): Rename the
1338 display_replaced_before_p argument into display_replaced_p, to
1339 make it consistent with the commentary. Fix typos in the
1342 * textprop.c (syms_of_textprop): Remove dead code.
1343 (copy_text_properties): Delete obsolete commentary about an
1344 interface that was deleted long ago. Fix typos in the description
1347 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1348 to changes in oldXMenu/XMenu.h from 2011-04-16.
1349 <menu_help_message, prev_menu_help_message>: Constify.
1350 (IT_menu_make_room): menu->help_text is now `const char **';
1353 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1354 to changes in oldXMenu/XMenu.h from 2011-04-16.
1355 (struct XMenu): Declare `help_text' `const char **'.
1357 * xfaces.c <Qunspecified>: Make extern again.
1359 * syntax.c: Include sys/types.h before including regex.h, as
1362 * doc.c (get_doc_string): Improve the format passed to `error'.
1364 * doprnt.c (doprnt): Improve commentary.
1366 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1368 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1371 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1372 changes in globals.h immediately force recompilation.
1373 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1374 $(CURDIR)/s/ms-w32.h.
1375 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1377 * character.c (Fchar_direction): Function deleted.
1378 (syms_of_character): Don't defsubr it.
1379 <char-direction-table>: Deleted.
1381 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1383 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1384 * doprnt.c: Include limits.h.
1385 (SIZE_MAX): New macro.
1386 (doprnt): Return a size_t value. 2nd arg is now size_t.
1387 Many local variables are now size_t instead of int or unsigned.
1388 Improve overflow protection. Support `l' modifier for integer
1389 conversions. Support %l conversion. Don't assume an EMACS_INT
1390 argument for integer conversions and for %c.
1392 * lisp.h (doprnt): Restore prototype.
1394 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1397 * Makefile.in (base_obj): Add back doprnt.o.
1399 * deps.mk (doprnt.o): Add back prerequisites.
1400 (callint.o): Depend on character.h.
1402 * eval.c (internal_lisp_condition_case): Include the handler
1403 representation in the error message.
1404 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1405 when breaking from the loop.
1407 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1409 * callint.c (Fcall_interactively): When displaying error message
1410 about invalid control letter, pass the character's codepoint, not
1411 a pointer to its multibyte form. Improve display of the character
1412 in octal and display also its hex code.
1414 * character.c (char_string): Use %x to display the (unsigned)
1415 codepoint of an invalid character, to avoid displaying a bogus
1418 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1419 `error', not SYMBOL_NAME itself.
1421 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1422 character arguments to `error'.
1424 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1425 to `error' in error message about FINAL_CHAR argument. Make sure
1426 FINAL_CHAR is a character, and use %c when it is passed as
1427 argument to `error'.
1429 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1431 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1433 * w32.c: Include <time.h>.
1434 (sys_localtime): New function.
1436 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1438 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1440 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1442 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1444 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1447 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1449 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1450 gl_state.e_property when gl_state.object is Qt.
1452 * insdel.c (make_gap_larger): Remove limitation of buffer size
1455 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1457 * xdisp.c (lookup_glyphless_char_display)
1458 (produce_glyphless_glyph): Handle cons cell entry in
1459 glyphless-char-display.
1460 (Vglyphless_char_display): Document it.
1462 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1463 glyphless-char-display.
1465 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1467 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1469 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1471 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1472 definition for no-X builds.
1474 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1476 Static checks with GCC 4.6.0 and non-default toolkits.
1478 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1480 * process.c (keyboard_bit_set): Define only if SIGIO.
1481 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1482 (send_process): Repair possible setjmp clobbering.
1484 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1486 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1488 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1490 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1491 Define only if needed.
1493 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1494 by pacifying GCC about it. Maybe it's time to retire it?
1495 * xfaces.c (USG, __TIMEVAL__): Likewise.
1497 * dispextern.h (struct redisplay_interface): Rename param
1499 * termhooks.h (struct terminal): Likewise.
1500 * xterm.c (xembed_send_message): Likewise.
1502 * insdel.c (make_gap_smaller): Define only if
1503 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1505 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1508 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1509 so that we aren't warned about unused symbols.
1511 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1513 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1515 * xfns.c (x_real_positions): Mark locals as initialized.
1517 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1519 * xterm.c: Fix problems found by static analysis with other toolkits.
1520 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1521 (x_dispatch_event): Declare static if USE_GTK, and
1522 define if USE_GTK || USE_X_TOOLKIT.
1523 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1524 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1525 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1526 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1528 * xmenu.c (menu_help_callback): Pointer type fixes.
1529 Use const pointers when pointing at readonly data. Avoid pointer
1531 (FALSE): Remove unused macro.
1532 (update_frame_menubar): Remove unused decl.
1534 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1536 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1537 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1538 (single_menu_item): Rename local to avoid shadowing.
1540 * keyboard.c (make_lispy_event): Remove unused local var.
1542 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1543 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1545 * bitmaps: Change bitmaps from unsigned char back to the X11
1546 compatible char. Avoid the old compiler warnings about
1547 out-of-range initializers by using, for example, '\xab' rather
1550 * xgselect.c (xgselect_initialize): Check vs interface
1551 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1553 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1555 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1556 to read-only memory.
1558 * fns.c (vector): Remove; this old hack is no longer needed.
1560 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1562 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1564 * xrdb.c (x_load_resources): Omit unused local.
1566 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1567 (x_window): Rename locals to avoid shadowing.
1568 (USG): Use the kludged USG macro, to pacify gcc.
1570 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1571 (x_term_init): Remove local to avoid shadowing.
1573 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1575 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1576 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1578 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1580 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1582 Fix regex.c, syntax.c and friends for buffers > 2GB.
1583 * syntax.h (struct gl_state_s): Declare character position members
1586 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1588 * textprop.c (verify_interval_modification, interval_of):
1589 Declare arguments EMACS_INT.
1591 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1594 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1596 * indent.c (Fvertical_motion): Local variable it_start is now
1599 * regex.c (re_match, re_match_2, re_match_2_internal)
1600 (bcmp_translate, regcomp, regexec, print_double_string)
1601 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1602 (re_compile_pattern, re_exec): Declare arguments and local
1603 variables `size_t' and `ssize_t' and return values `regoff_t', as
1605 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1606 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1607 <compile_stack_type>: `size' and `avail' are now `size_t'.
1609 * regex.h <regoff_t>: Use ssize_t, not int.
1610 (re_search, re_search_2, re_match, re_match_2): Arguments that
1611 specify buffer/string position and length are now ssize_t and
1612 size_t. Return type is regoff_t.
1614 2011-04-16 Ben Key <bkey76@gmail.com>
1616 * nsfont.m: Fixed bugs in ns_get_family and
1617 ns_descriptor_to_entity that were caused by using free to
1618 deallocate memory blocks that were allocated by xmalloc (via
1619 xstrdup). This caused Emacs to crash when compiled with
1620 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1621 --enable-checking=xmallocoverrun). xfree is now used to
1622 deallocate these memory blocks.
1624 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1626 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1628 emacs_write: Accept and return EMACS_INT for sizes.
1629 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1631 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1632 Accept and return EMACS_INT.
1633 (emacs_gnutls_write): Return the number of bytes written on
1635 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1636 (emacs_read, emacs_write): Remove check for negative size, as the
1637 Emacs source code has been audited now.
1638 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1639 (emacs_read, emacs_write): Use it.
1640 * process.c (send_process): Adjust to the new signatures of
1641 emacs_write and emacs_gnutls_write. Do not attempt to store
1642 a byte offset into an 'int'; it might overflow.
1643 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1645 * sound.c: Don't assume sizes fit in 'int'.
1646 (struct sound_device.period_size, alsa_period_size):
1647 Return EMACS_INT, not int.
1648 (struct sound_device.write, vox_write, alsa_write):
1649 Accept EMACS_INT, not int.
1650 (wav_play, au_play): Use EMACS_INT to store sizes and to
1651 record read return values.
1653 2011-04-15 Ben Key <bkey76@gmail.com>
1655 * keyboard.c (Qundefined): Don't declare static since it is used
1657 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1658 static since they are used in nsfont.m.
1660 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1662 * process.c (Qprocessp): Don't declare static.
1663 * lisp.h (Qprocessp): Declare again.
1665 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1667 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1669 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1671 Improve C-level modularity by making more things 'static'.
1673 Don't publish debugger-only interfaces to other modules.
1674 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1675 (verify_bytepos, count_markers): Move decls to the only modules
1677 * region-cache.h (pp_cache): Likewise.
1678 * window.h (check_all_windows): Likewise.
1679 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1681 * sysdep.c (croak): Now static, if
1682 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1683 * syssignal.h (croak): Declare only if not static.
1685 * alloc.c (refill_memory_reserve): Now static if
1686 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1687 * lisp.h (refill_memory_reserve): Declare only if not static.
1689 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1690 Define only if USE_LUCID.
1692 * xrdb.c (x_customization_string, x_rm_string): Now static.
1694 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1695 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1697 * xdisp.c (draw_row_with_mouse_face): Now static.
1698 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1700 * window.h (check_all_windows): Mark externally visible.
1702 * window.c (window_deletion_count): Now static.
1704 * undo.c: Make symbols static if they're not exported.
1705 (last_undo_buffer, last_boundary_position, pending_boundary):
1708 * textprop.c (interval_insert_behind_hooks): Now static.
1709 (interval_insert_in_front_hooks): Likewise.
1711 * term.c: Make symbols static if they're not exported.
1712 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1713 (max_frame_lines, tty_set_terminal_modes):
1714 (tty_reset_terminal_modes, tty_turn_off_highlight):
1715 (get_tty_terminal): Now static.
1716 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1717 * termhooks.h (term_mouse_moveto): Do not declare if
1719 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1720 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1722 * sysdep.c: Make symbols static if they're not exported.
1723 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1725 (sigprocmask_set, full_mask): Remove; unused.
1726 (wait_debugging): Mark as visible.
1727 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1728 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1730 * syntax.c (syntax_temp): Define only if !__GNUC__.
1732 * sound.c (current_sound_device, current_sound): Now static.
1734 * search.c (searchbufs, searchbuf_head): Now static.
1736 * scroll.c (scroll_cost): Remove; unused.
1737 * dispextern.h (scroll_cost): Remove decl.
1739 * region-cache.h (pp_cache): Mark as externally visible.
1741 * process.c: Make symbols static if they're not exported.
1742 (process_tick, update_tick, create_process, chan_process):
1743 (Vprocess_alist, proc_buffered_char, datagram_access):
1744 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1745 (deactivate_process): Mark defn as static, as well as decl.
1746 * lisp.h (create_process): Remove decl.
1747 * process.h (chan_process, Vprocess_alist): Remove decls.
1749 * print.c: Make symbols static if they're not exported.
1750 (print_depth, new_backquote_output, being_printed, print_buffer):
1751 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1752 (print_interval, print_number_index, initial_stderr_stream):
1754 * lisp.h (Fprinc): Remove decl.
1755 (debug_output_compilation_hack): Mark as externally visible.
1757 * sysdep.c (croak): Move decl from here to syssignal.h.
1758 * syssignal.h (croak): Put it here, so the API can be checked when
1759 'croak' is called from dissociate_if_controlling_tty.
1761 * minibuf.c: Make symbols static if they're not exported.
1762 (minibuf_save_list, choose_minibuf_frame): Now static.
1763 * lisp.h (choose_minibuf_frame): Remove decl.
1765 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1767 * lread.c: Make symbols static if they're not exported.
1768 (read_objects, initial_obarray, oblookup_last_bucket_number):
1770 (make_symbol): Remove; unused.
1771 * lisp.h (initial_obarray, make_symbol): Remove decls.
1773 * keyboard.c: Make symbols static if they're not exported.
1774 (single_kboard, recent_keys_index, total_keys, recent_keys):
1775 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1776 (this_single_command_key_start, echoing, last_auto_save):
1777 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1778 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1779 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1780 (Vlispy_mouse_stem, double_click_count):
1782 (force_auto_save_soon): Define only if SIGDANGER.
1783 (ignore_mouse_drag_p): Now static if
1784 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1785 (print_help): Remove; unused.
1786 (stop_character, last_timer_event): Mark as externally visible.
1787 * keyboard.h (ignore_mouse_drag_p): Declare only if
1788 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1789 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1790 * lisp.h (echoing): Remove decl.
1791 (force_auto_save_soon): Declare only if SIGDANGER.
1792 * xdisp.c (redisplay_window): Simplify code, to make it more
1793 obvious that ignore_mouse_drag_p is not accessed if !defined
1794 USE_GTK && !defined HAVE_NS.
1796 * intervals.c: Make symbols static if they're not exported.
1797 (merge_properties_sticky, merge_interval_right, delete_interval):
1799 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1801 * insdel.c: Make symbols static if they're not exported.
1802 However, leave prepare_to_modify_buffer alone. It's never
1803 called from outside this function, but that appears to be a bug.
1804 (combine_after_change_list, combine_after_change_buffer):
1805 (adjust_after_replace, signal_before_change): Now static.
1806 (adjust_after_replace_noundo): Remove; unused.
1807 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1808 (signal_before_change): Remove decls.
1810 * indent.c (val_compute_motion, val_vmotion): Now static.
1812 * image.c: Make symbols static if they're not exported.
1813 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1815 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1816 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1818 * fringe.c (standard_bitmaps): Now static.
1819 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1821 * frame.c: Make symbols static if they're not exported.
1822 (x_report_frame_params, make_terminal_frame): Now static.
1823 (get_frame_param): Now static, unless HAVE_NS.
1824 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1825 (x_get_resource_string): Remove; not used.
1826 * frame.h (make_terminal_frame, x_report_frame_params):
1827 (x_get_resource_string); Remove decls.
1828 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1829 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1831 * font.c, fontset.c: Make symbols static if they're not exported.
1832 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1833 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1834 * font.c (font_close_object): Now static.
1835 * font.h (font_close_object): Remove.
1836 * fontset.c (FONTSET_OBJLIST): Remove.
1837 (free_realized_fontset) #if-0 the body, which does nothing.
1838 (face_suitable_for_char_p): #if-0, as it's never called.
1839 * fontset.h (face_suitable_for_char_p): Remove decl.
1840 * xfaces.c (face_at_string_position):
1841 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1842 since 0 is always ASCII.
1844 * fns.c (weak_hash_tables): Now static.
1846 * fileio.c: Make symbols static if they're not exported.
1847 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1848 (Vwrite_region_annotation_buffers): Now static.
1850 * eval.c: Make symbols static if they're not exported.
1851 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1852 * lisp.h (backtrace_list): Remove decl.
1854 * emacs.c: Make symbols static if they're not exported.
1855 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1856 (fatal_error_code, fatal_error_signal_hook, standard_args):
1858 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1859 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1860 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1861 * lisp.h (fatal_error_signal_hook): Remove decl.
1862 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1864 * editfns.c: Move a (normally-unused) function to its only use.
1865 * editfns.c, lisp.h (get_operating_system_release): Remove.
1866 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1867 worth the hassle of breaking this out.
1869 * xterm.c: Make symbols static if they're not exported.
1870 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1871 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1872 (x_destroy_window, x_delete_display):
1874 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1875 (x_mouse_leave): Remove; unused.
1876 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1877 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1878 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1880 (x_mouse_leave): Declare only if WINDOWSNT.
1881 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1882 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1885 * ftxfont.c: Make symbols static if they're not exported.
1886 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1888 * font.h (ftxfont_driver): Likewise.
1890 * xfns.c: Make symbols static if they're not exported.
1891 (x_last_font_name, x_display_info_for_name):
1892 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1893 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1894 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1895 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1896 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1897 (last_show_tip_args): Now static.
1898 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1899 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1900 (x_screen_planes): Remove; unused.
1901 * dispextern.h (x_screen_planes): Remove decl.
1903 * dispnew.c: Make symbols static if they're not exported.
1904 * dispextern.h (redraw_garbaged_frames, scrolling):
1905 (increment_row_positions): Remove.
1906 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1907 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1909 (redraw_garbaged_frames): Remove; unused.
1911 * xfaces.c: Make symbols static if they're not exported.
1912 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1914 * xterm.h (defined_color): Remove decls.
1915 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1916 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1917 (menu_face_changed_default, defined_color, free_realized_face):
1918 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1919 (ascii_face_of_lisp_face): Remove; unused.
1921 * xdisp.c: Make symbols static if they're not exported.
1922 * dispextern.h (scratch_glyph_row, window_box_edges):
1923 (glyph_to_pixel_coords, set_cursor_from_row):
1924 (get_next_display_element, set_iterator_to_next):
1925 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1926 (show_mouse_face): Remove decls
1927 * frame.h (message_buf_print): Likewise.
1928 * lisp.h (pop_message, set_message, check_point_in_composition):
1930 * xterm.h (set_vertical_scroll_bar): Likewise.
1931 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1932 (message_buf_print, scratch_glyph_row, displayed_buffer):
1933 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1934 (get_next_display_element, show_mouse_face, window_box_edges):
1935 (frame_to_window_pixel_xy, check_point_in_composition):
1936 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1937 (glyph_to_pixel_coords): Remove; unused.
1939 * dired.c (file_name_completion): Now static.
1941 * dbusbind.c (xd_in_read_queued_messages): Now static.
1943 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1944 * data.c (circular_list_error): Remove.
1946 * commands.h (last_point_position, last_point_position_buffer):
1947 (last_point_position_window): Remove decls.
1948 * keyboard.c: Make these variables static.
1950 * coding.h (coding, code_convert_region, encode_coding_gap):
1952 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1953 (iso_code_class, detect_coding, code_convert_region): Now static.
1954 (encode_coding_gap): Remove; unused.
1956 * chartab.c (chartab_chars, chartab_bits): Now static.
1958 * charset.h (charset_iso_8859_1): Remove decl.
1959 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1962 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1963 * ccl.c (Vccl_program_table): Now static.
1964 (check_ccl_update): Remove; unused.
1966 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1967 * category.h: ... from here.
1968 * category.c (check_category_table, set_category_set): Now static.
1970 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1971 * lisp.h: Remove these decls.
1973 * buffer.c (buffer_count): Remove unused var.
1975 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1976 so that it's not optimized away.
1977 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1978 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1979 exported only to the debugger.
1981 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1982 * atimer.h (run_all_atimers): Remove; not exported.
1984 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1985 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1986 was inaccessible from Lisp.
1987 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1988 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1990 alloc.c: Import and export fewer symbols, and remove unused items.
1991 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1993 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1994 it's not optimized away by whole-program optimization.
1995 (message_enable_multibyte, free_misc): Remove.
1996 (catchlist, handlerlist, mark_backtrace):
1997 Declare only if BYTE_MARK_STACK.
1998 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1999 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2000 (message_enable_multibyte): Remove decl.
2001 (free_misc, interval_free_list, float_block, float_block_index):
2002 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2003 (cons_free_list, last_marked_index):
2005 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2006 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2007 (mark_backtrace): Define only if BYTE_MARK_STACK.
2008 * xdisp.c (message_enable_multibyte): Now static.
2010 Declare Lisp_Object Q* variables to be 'static' if not exported.
2011 This makes it easier for human readers (and static analyzers)
2012 to see whether these variables are used from other modules.
2013 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2014 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2015 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2016 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2017 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2018 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2019 * xmenu.c, xselect.c:
2020 Declare Q* vars static if they are not used in other modules.
2021 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2022 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2023 Remove decls of unexported vars.
2024 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2026 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2028 Make Emacs functions such as Fatom 'static' by default.
2029 This makes it easier for human readers (and static analyzers)
2030 to see whether these functions can be called from other modules.
2031 DEFUN now defines a static function. To make the function external
2032 so that it can be used in other C modules, use the new macro DEFUE.
2033 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2034 (Finit_image_library):
2035 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2036 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2037 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2038 Remove decls, since these functions are now static.
2039 (Funintern, Fget_internal_run_time): New decls, since these functions
2040 were already external.
2042 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2043 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2044 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2045 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2046 * keyboard.c, keymap.c, lread.c:
2047 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2048 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2049 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2050 Mark functions with DEFUE instead of DEFUN,
2051 if they are used in other modules.
2052 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2053 decls for now-static functions.
2054 * buffer.h (Fdelete_overlay): Remove decl.
2055 * callproc.c (Fgetenv_internal): Mark as internal.
2056 * composite.c (Fremove_list_of_text_properties): Remove decl.
2057 (Fcomposition_get_gstring): New forward static decl.
2058 * composite.h (Fcomposite_get_gstring): Remove decl.
2059 * dired.c (Ffile_attributes): New forward static decl.
2060 * doc.c (Fdocumntation_property): New forward static decl.
2061 * eval.c (Ffetch_bytecode): New forward static decl.
2062 (Funintern): Remove extern decl; now in .h file where it belongs.
2063 * fileio.c (Fmake_symbolic_link): New forward static decl.
2064 * image.c (Finit_image_library): New forward static decl.
2065 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2066 * intervals.h (Fprevious_property_change):
2067 (Fremove_list_of_text_properties): Remove decls.
2068 * keyboard.c (Fthis_command_keys): Remove decl.
2069 (Fcommand_execute): New forward static decl.
2070 * keymap.c (Flookup_key): New forward static decl.
2071 (Fcopy_keymap): Now static.
2072 * keymap.h (Flookup_key): Remove decl.
2073 * process.c (Fget_process): New forward static decl.
2074 (Fprocess_datagram_address): Mark as internal.
2075 * syntax.c (Fsyntax_table_p): New forward static decl.
2076 (skip_chars): Remove duplicate decl.
2077 * textprop.c (Fprevious_property_change): New forward static decl.
2078 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2080 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2081 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2083 * editfns.c (Fformat): Remove unreachable code.
2085 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2087 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2090 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2092 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2093 when at ZV. (Bug#8487)
2095 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2097 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2099 * keyboard.c (parse_tool_bar_item): Likewise.
2100 * sound.c (sound_cleanup, alsa_close): Likewise.
2101 * termcap.c (tgetent): Likewise.
2102 * xfns.c (x_default_font_parameter): Likewise.
2103 * xsettings.c (read_and_apply_settings): Likewise.
2105 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2106 (overrun_check_free): Protoize.
2108 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2110 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2111 since callers should never pass a negative size.
2112 Change the signature to match that of plain 'read' and 'write'; see
2113 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2114 * lisp.h: Update prototypes of emacs_write and emacs_read.
2116 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2118 * xdisp.c (redisplay_window): Don't try to determine the character
2119 position of the scroll margin if the window start point w->startp
2120 is outside the buffer's accessible region. (Bug#8468)
2122 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2124 Fix write-region and its subroutines for buffers > 2GB.
2125 * fileio.c (a_write, e_write): Modify declaration of arguments and
2126 local variables to support buffers larger than 2GB.
2127 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2129 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2130 argument, local variables, and return value.
2132 * lisp.h: Update prototypes of emacs_write and emacs_read.
2134 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2136 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2138 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2140 Fix more problems found by GCC 4.6.0's static checks.
2142 * xdisp.c (vmessage): Use a better test for character truncation.
2144 * charset.c (load_charset_map): <, not <=, for optimization,
2145 and to avoid potential problems with integer overflow.
2146 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2147 * casetab.c (set_identity, shuffle): Likewise.
2148 * editfns.c (Fformat): Likewise.
2149 * syntax.c (skip_chars): Likewise.
2151 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2152 This also lets GCC 4.6.0 generate slightly better loop code.
2154 * callint.c (Fcall_interactively): <, not <=, for optimization.
2155 (Fcall_interactively): Count the number of arguments produced,
2156 not the number of arguments given. This is simpler and lets GCC
2157 4.6.0 generate slightly better code.
2159 * ftfont.c: Distingish more carefully between FcChar8 and char.
2160 The previous code passed unsigned char * to a functions like
2161 strlen and xstrcasecmp that expect char *, which does not
2162 conform to the C standard.
2163 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2164 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2165 char * when the C standard requires it.
2167 * keyboard.c (read_char): Remove unused var.
2169 * eval.c: Port to Windows vsnprintf (Bug#8435).
2171 (SIZE_MAX): Define if the headers do not.
2172 (verror): Do not give up if vsnprintf returns a negative count.
2173 Instead, grow the buffer. This ports to Windows vsnprintf, which
2174 does not conform to C99. Problem reported by Eli Zaretskii.
2175 Also, simplify the allocation scheme, by avoiding the need for
2176 calling realloc, and removing the ALLOCATED variable.
2178 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2180 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2181 But keep the doprint source code for now, as we might revamp it
2182 and use it again (Bug#8435).
2183 * lisp.h (doprnt): Remove.
2184 * Makefile.in (base_obj): Remove doprnt.o.
2185 * deps.mk (doprnt.o): Remove.
2187 error: Print 32- and 64-bit integers portably (Bug#8435).
2188 Without this change, on typical 64-bit hosts error ("...%d...", N)
2189 was used to print both 32- and 64-bit integers N, which relied on
2191 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2193 * lisp.h (error, verror): Mark as printf-like functions.
2194 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2195 Report overflow in size calculations when allocating printf buffer.
2196 Do not truncate output string at its first null byte.
2197 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2198 Truncate the output at a character boundary, since vsnprintf does not
2200 * charset.c (check_iso_charset_parameter): Convert internal
2201 character to string before calling 'error', since %c now has the
2203 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2204 overflow when computing char to be passed to 'error'. Do not
2205 pass Lisp_Object to 'error'; pass the integer instead.
2206 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2207 formatted with plain %d.
2209 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2211 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2213 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2215 * xterm.c (x_catch_errors): Remove duplicate declaration.
2217 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2219 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2221 2011-04-10 Jim Meyering <meyering@redhat.com>
2223 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2224 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2225 return ssize_t not "int", and use size_t as the buffer length.
2226 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2227 * gnutls.h: Update declarations.
2228 * process.c (read_process_output): Use ssize_t, to match.
2229 (send_process): Likewise.
2231 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2233 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2235 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2237 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2238 Use unsigned char, to match FcChar8 type definition.
2240 * xterm.c (handle_one_xevent):
2241 * xmenu.c (create_and_show_popup_menu):
2242 * xselect.c (x_decline_selection_request)
2243 (x_reply_selection_request): Avoid type-punned deref of X events.
2245 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2247 Fix some uses of `int' instead of EMACS_INT.
2248 * search.c (string_match_1, fast_string_match)
2249 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2250 (scan_buffer, find_next_newline_no_quit)
2251 (find_before_next_newline, search_command, Freplace_match)
2252 (Fmatch_data): Make some `int' variables be EMACS_INT.
2254 * xdisp.c (display_count_lines): 3rd argument and return value now
2255 EMACS_INT. All callers changed.
2256 (pint2hrstr): Last argument is now EMACS_INT.
2258 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2259 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2260 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2261 (decode_coding_utf_16, decode_coding_emacs_mule)
2262 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2263 (decode_coding_ccl, decode_coding_charset)
2264 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2265 (decode_coding_iso_2022, decode_coding_emacs_mule)
2266 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2267 <char_offset, last_offset>: Declare EMACS_INT.
2268 (encode_coding_utf_8, encode_coding_utf_16)
2269 (encode_coding_emacs_mule, encode_invocation_designation)
2270 (encode_designation_at_bol, encode_coding_iso_2022)
2271 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2272 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2274 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2275 (encode_invocation_designation): Last argument P_NCHARS is now
2277 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2278 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2280 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2283 * ccl.c (Fccl_execute_on_string): Declare some variables
2286 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2288 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2290 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2292 * process.c (Fformat_network_address): Doc fix.
2294 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2296 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2298 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2300 * keyboard.c (read_char): Call Lisp function help-form-show,
2301 instead of using internal_with_output_to_temp_buffer.
2302 (Qhelp_form_show): New var.
2303 (syms_of_keyboard): Use DEFSYM macro.
2305 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2307 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2309 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2311 * process.c (Flist_processes): Remove to Lisp.
2312 (list_processes_1): Delete.
2314 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2316 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2318 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2320 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2322 Fix more problems found by GCC 4.6.0's static checks.
2324 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2326 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2328 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2330 * xdisp.c (vmessage): Mark as a printf-like function.
2332 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2334 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2336 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2337 printf-like functions.
2338 (tiff_load): Add casts to remove these marks before passing them
2339 to system-supplied API.
2341 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2343 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2344 This avoids several warnings with gcc -Wstrict-overflow.
2345 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2346 directly, rather than having caller test rule sign. This avoids
2347 some unnecessary tests.
2348 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2349 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2350 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2352 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2353 (xfont_open): Avoid unnecessary tests.
2355 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2357 * composite.h, composite.c (composition_gstring_put_cache):
2358 Use EMACS_INT, not int, for length.
2360 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2361 breaking out part of COMPOSITION_DECODE_RULE.
2362 (COMPOSITION_DECODE_RULE): Use it.
2363 * composite.c (get_composition_id): Remove unused local vars,
2364 by using the new macro.
2366 * textprop.c (set_text_properties_1): Change while to do-while,
2367 since the condition is always true at first.
2369 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2370 (interval_deletion_adjustment): Return unsigned value.
2373 * process.c (list_processes_1, create_pty, read_process_output):
2374 (exec_sentinel): Remove vars that were set but not used.
2375 (create_pty): Remove unnecessary "volatile"s.
2376 (Fnetwork_interface_info): Avoid possibility of int overflow.
2377 (read_process_output): Do adaptive read buffering even if carryover.
2378 (read_process_output): Simplify nbytes computation if buffered.
2380 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2382 * syntax.c (scan_words): Remove var that was set but not used.
2383 (update_syntax_table): Use unsigned instead of int.
2385 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2386 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2387 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2389 * print.c (print_error_message): Avoid int overflow.
2391 * font.c (font_list_entities): Redo for clarity,
2392 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2394 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2395 (font_score): Avoid potential overflow in diff calculation.
2397 * fns.c (substring_both): Remove var that is set but not used.
2398 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2400 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2402 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2403 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2404 can always succeed if overflow has undefined behavior.
2406 * search.c (boyer_moore, wordify): Remove vars set but not used.
2407 (wordify): Omit three unnecessary tests.
2409 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2410 All callers changed. This avoids the need for an unused var.
2412 * casefiddle.c (casify_region): Remove var that is set but not used.
2414 * dired.c (file_name_completion): Remove var that is set but not used.
2416 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2418 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2419 (Finsert_file_contents): Remove unnecessary code checking fd.
2421 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2422 Check for integer overflow on size calculations.
2424 * buffer.c (Fprevious_overlay_change): Remove var that is set
2427 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2428 Remove vars that are set but not used.
2429 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2430 (timer_check_2): Mark vars as initialized.
2432 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2434 * image.c (lookup_image): Remove var that is set but not used.
2435 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2437 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2438 that are set but not used.
2440 * xfns.c (make_invisible_cursor): Don't return garbage
2441 if XCreateBitmapFromData fails (Bug#8410).
2443 * xselect.c (x_get_local_selection, x_handle_property_notify):
2444 Remove vars that are set but not used.
2446 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2447 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2449 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2450 Remove var that is set but not used.
2451 (scroll_bar_windows_size): Now size_t, not int.
2452 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2455 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2456 (map_tty_color) [!defined MSDOS]: Likewise.
2458 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2460 * coding.c: Remove vars that are set but not used.
2461 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2462 All callers changed.
2463 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2464 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2465 (decode_coding_charset): Remove vars that are set but not used.
2467 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2468 that is set but not used.
2470 * print.c (print_object): Remove var that is set but not used.
2472 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2473 The gnulib version avoids calling malloc in the usual case,
2474 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2475 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2476 * filelock.c (current_lock_owner): Likewise.
2477 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2478 * sysdep.c: Include allocator.h, careadlinkat.h.
2479 (emacs_no_realloc_allocator): New static constant.
2480 (emacs_readlink): New function.
2481 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2482 ../lib/careadlinkat.h.
2484 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2486 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2487 first non-nil return value).
2489 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2491 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2492 if not defined (Bug#8403).
2494 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2496 * xdisp.c (display_count_lines): Remove parameter `start',
2497 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2498 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2499 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2500 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2501 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2502 and thereabouts. All callers changed.
2503 (get_per_char_metric): Remove parameter `f', unused since
2504 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2506 2011-04-02 Jim Meyering <meyering@redhat.com>
2508 do not dereference NULL upon failed strdup
2509 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2510 (ns_get_family): Likewise.
2512 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2514 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2516 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2518 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2521 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2523 Add lexical binding.
2525 * window.c (Ftemp_output_buffer_show): New fun.
2526 (Fsave_window_excursion):
2527 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2529 * lread.c (lisp_file_lexically_bound_p): New function.
2530 (Fload): Bind Qlexical_binding.
2531 (readevalloop): Remove `evalfun' arg.
2532 Bind Qinternal_interpreter_environment.
2533 (Feval_buffer): Bind Qlexical_binding.
2534 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2536 (syms_of_lread): Declare `lexical-binding'.
2538 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2540 * keyboard.c (eval_dyn): New fun.
2541 (menu_item_eval_property): Use it.
2543 * image.c (parse_image_spec): Use Ffunctionp.
2545 * fns.c (concat, mapcar1): Accept byte-code-functions.
2547 * eval.c (Fsetq): Handle lexical vars.
2548 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2549 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2550 (FletX, Flet): Obey lexical binding.
2551 (Fcommandp): Handle closures.
2552 (Feval): New `lexical' arg.
2553 (eval_sub): New function extracted from Feval. Use it almost
2554 everywhere where Feval was used. Look up vars in lexical env.
2556 (Ffunctionp): Move from subr.el.
2557 (Ffuncall): Handle closures.
2558 (apply_lambda): Remove `eval_flags'.
2559 (funcall_lambda): Handle closures and new byte-code-functions.
2560 (Fspecial_variable_p): New function.
2561 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2562 but without exporting it to Lisp.
2564 * doc.c (Fdocumentation, store_function_docstring):
2565 * data.c (Finteractive_form): Handle closures.
2567 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2570 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2572 (exec_byte_code): New function extracted from Fbyte_code to handle new
2573 calling convention for byte-code-functions. Add new byte-codes.
2575 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2577 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2579 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2581 * xdisp.c (redisplay_internal): Fix prototype.
2583 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2585 * xdisp.c (SCROLL_LIMIT): New macro.
2586 (try_scrolling): Use it when setting scroll_limit.
2587 Limit scrolling to 100 screen lines.
2588 (redisplay_window): Even when falling back on "recentering",
2589 position point in the window according to scroll-conservatively,
2590 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2592 (try_scrolling): When point is above the window, allow searching
2593 as far as scroll_max, or one screenful, to compute vertical
2594 distance from PT to the scroll margin position. This prevents
2595 try_scrolling from unnecessarily failing when
2596 scroll-conservatively is set to a value slightly larger than the
2597 window height. Clean up the case of PT below the margin at bottom
2598 of window: scroll_max can no longer be INT_MAX. When aggressive
2599 scrolling is in use, don't let point enter the opposite scroll
2600 margin as result of the scroll.
2601 (syms_of_xdisp) <scroll-conservatively>: Document the
2602 threshold of 100 lines for never-recentering scrolling.
2604 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2606 * dispextern.h (move_it_by_lines):
2607 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2608 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2609 (message_log_check_duplicate): Remove parameters `prev_bol' and
2610 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2611 (redisplay_internal): Remove parameter `preserve_echo_area',
2612 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2614 * indent.c (Fvertical_motion):
2615 * window.c (window_scroll_pixel_based, Frecenter):
2616 Don't pass `need_y_p' to `move_it_by_lines'.
2618 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2620 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2621 steal a few bits to be more compact.
2622 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2623 Remove unneeded casts.
2625 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2627 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2629 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2630 binding" message (bug#7967).
2632 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2634 Fix more problems found by GCC 4.6.0's static checks.
2636 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2637 Remove unused local var.
2639 * editfns.c (Fmessage_box): Remove unused local var.
2641 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2642 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2643 Omit unused local vars.
2644 * window.c (shrink_windows): Omit unused local var.
2645 * menu.c (digest_single_submenu): Omit unused local var.
2646 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2647 Omit unused local var.
2649 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2650 Don't assume string length fits in int.
2651 (keyremap_step, read_key_sequence): Use size_t for sizes.
2652 (read_key_sequence): Don't check last_real_key_start redundantly.
2654 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2655 instead of alloca (Bug#8344).
2657 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2658 (Fbacktrace_frame): Don't assume nframes fits in int.
2660 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2662 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2665 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2667 * cm.c (calccost): Turn while-do into do-while, for clarity.
2669 * keyboard.c (syms_of_keyboard): Use the same style as later
2670 in this function when indexing through an array. This also
2671 works around GCC bug 48267.
2673 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2675 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2677 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2678 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2680 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2681 This avoids undefined behavior on integer overflow, and is a bit
2682 more convenient anyway since it is compared to a size_t variable.
2684 Variadic C functions now count arguments with size_t, not int.
2685 This avoids an unnecessary limitation on 64-bit machines, which
2686 caused (substring ...) to crash on large vectors (Bug#8344).
2687 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2688 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2689 All variadic functions and their callers changed accordingly.
2690 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2691 * data.c (arith_driver, float_arith_driver): Likewise.
2692 * editfns.c (general_insert_function): Likewise.
2693 * eval.c (struct backtrace.nargs, interactive_p)
2694 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2695 (funcall_lambda, mark_backtrace): Likewise.
2696 * fns.c (concat): Likewise.
2697 * frame.c (x_set_frame_parameters): Likewise.
2698 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2699 0 if not found, not -1. All callers changed.
2701 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2702 (stack_copy_size): Now size_t, not int.
2703 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2705 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2707 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2708 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2709 All callers changed.
2711 * lisp.h (multibyte_char_to_unibyte):
2712 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2713 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2714 * character.h (CHAR_TO_BYTE8):
2715 * cmds.c (internal_self_insert):
2716 * editfns.c (general_insert_function):
2717 * keymap.c (push_key_description):
2718 * search.c (Freplace_match):
2719 * xdisp.c (message_dolog, set_message_1): All callers changed.
2721 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2723 * keyboard.c (safe_run_hook_funcall): New function.
2724 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2725 don't set the hook to nil, but remove the offending function instead.
2726 (Qcommand_hook_internal): Remove, unused.
2727 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2728 Vcommand_hook_internal.
2730 * eval.c (enum run_hooks_condition): Remove.
2731 (funcall_nil, funcall_not): New functions.
2732 (run_hook_with_args): Call each function through a `funcall' argument.
2733 Remove `cond' argument, now redundant.
2734 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2735 (Frun_hook_with_args_until_failure): Adjust accordingly.
2736 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2738 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2740 * dispextern.h (string_buffer_position): Remove declaration.
2742 * print.c (strout): Remove parameter `multibyte', unused since
2743 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2745 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2746 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2747 All callers changed.
2749 * w32.c (_wsa_errlist): Use braces for struct initializers.
2751 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2752 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2753 All callers changed.
2754 (string_buffer_position): Likewise. Also, make static (it's never
2755 used outside xdisp.c).
2756 (cursor_row_p): Remove parameter `w', unused since
2757 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2758 (decode_mode_spec): Remove parameter `precision', introduced during
2759 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2760 All callers changed.
2762 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2764 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2766 2011-03-27 Anders Lindgren <andlind@gmail.com>
2768 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2769 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2770 (ns_update_auto_hide_menu_bar): New functions.
2771 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2772 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2773 ns_constrain_all_frames.
2774 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2775 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2777 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2779 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2781 2011-03-27 Glenn Morris <rgm@gnu.org>
2783 * syssignal.h: Replace RETSIGTYPE with void.
2784 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2785 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2786 Replace SIGTYPE with void everywhere.
2787 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2788 * s/template.h (SIGTYPE): Remove commented out definition.
2790 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2792 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2793 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2795 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2797 * w32.c (read_unc_volume): Use parameter `henum', instead of
2798 global variable `wget_enum_handle'.
2800 * keymap.c (describe_vector): Remove parameters `indices' and
2801 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2802 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2804 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2806 * keyboard.c (timer_check): Remove parameter `do_it_now',
2807 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2808 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2809 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2811 * keyboard.c (read_char):
2812 * w32menu.c (w32_menu_display_help):
2813 * xmenu.c (show_help_event, menu_help_callback):
2814 Adjust calls to `show_help_echo'.
2816 * gtkutil.c (xg_maybe_add_timer):
2817 * keyboard.c (readable_events):
2818 * process.c (wait_reading_process_output):
2819 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2821 * insdel.c (adjust_markers_gap_motion):
2822 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2823 (gap_left, gap_right): Don't call it.
2825 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2827 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2828 incurred during fontification.
2830 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2832 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2833 (DEFVAR_PER_BUFFER): Don't pass it.
2835 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2836 (scrolling_window): Don't pass it.
2838 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2840 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2842 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2844 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2845 of variables specific to SELinux and computation of `encoded_absname'.
2847 * image.c (XPutPixel): Remove unused variable `height'.
2849 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2851 * unexw32.c (get_section_info): Remove unused variable `section'.
2853 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2854 (system_process_attributes): Remove unused variable `sess'.
2855 (sys_read): Remove unused variable `err'.
2857 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2858 (w32_wnd_proc): Remove unused variable `isdead'.
2859 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2860 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2861 (x_create_tip_frame): Remove unused variable `tem'.
2863 * w32inevt.c (w32_console_read_socket):
2864 Remove unused variable `no_events'.
2866 * w32term.c (x_draw_composite_glyph_string_foreground):
2867 Remove unused variable `width'.
2869 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2871 * w32term.c (x_set_glyph_string_clipping):
2872 Don't pass uninitialized region to CombineRgn.
2874 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2876 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2877 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2878 (Fx_close_connection): Remove unused variable `i'.
2880 * w32font.c (w32font_draw): Return number of glyphs.
2881 (w32font_open_internal): Remove unused variable `i'.
2882 (w32font_driver): Add missing initializer.
2884 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2885 (fill_in_menu): Remove unused variable `items_added'.
2887 * w32term.c (last_mouse_press_frame): Remove static global variable.
2888 (w32_clip_to_row): Remove unused variable `f'.
2889 (x_delete_terminal): Remove unused variable `i'.
2891 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2892 (NOTHING): Remove unused static global variable.
2893 (uniscribe_check_otf): Remove unused variable `table'.
2894 (uniscribe_font_driver): Add missing initializers.
2896 2011-03-23 Julien Danjou <julien@danjou.info>
2898 * term.c (Fsuspend_tty, Fresume_tty):
2899 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2900 * window.c (temp_output_buffer_show):
2901 * insdel.c (signal_before_change):
2902 * frame.c (Fhandle_switch_frame):
2903 * fileio.c (Fdo_auto_save):
2904 * emacs.c (Fkill_emacs):
2905 * editfns.c (save_excursion_restore):
2906 * cmds.c (internal_self_insert):
2907 * callint.c (Fcall_interactively):
2908 * buffer.c (Fkill_all_local_variables):
2909 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2911 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2912 unconditionnaly since it does the check itself.
2914 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2916 Fix more problems found by GCC 4.5.2's static checks.
2918 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2919 the first time through the loop, since we know p0 < p1 then.
2920 This also avoids a gcc -Wstrict-overflow warning.
2922 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2923 leading to a memory leak, possible in functions like
2924 load_charset_map_from_file that can allocate an unbounded number
2925 of objects (Bug#8318).
2927 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2928 that could (at least in theory) be that large.
2930 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2931 This is less likely to overflow, and avoids undefined behavior if
2932 overflow does occur. All callers changed. Use strtoul to scan
2933 for the unsigned long integer.
2934 (pint2hrstr): Simplify and tune code slightly.
2935 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2937 * scroll.c (do_scrolling): Work around GCC bug 48228.
2938 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2940 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2941 This also avoids a warning with gcc -Wstrict-overflow.
2942 (validate_x_resource_name): Simplify count usage.
2943 This also avoids a warning with gcc -Wstrict-overflow.
2945 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2948 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2950 * process.c (Fmake_network_process): Use socklen_t, not int,
2951 where POSIX says socklen_t is required in portable programs.
2952 This fixes a porting bug on hosts like 64-bit HP-UX, where
2953 socklen_t is wider than int (Bug#8277).
2954 (Fmake_network_process, server_accept_connection):
2955 (wait_reading_process_output, read_process_output):
2958 * process.c: Rename or move locals to avoid shadowing.
2959 (list_processes_1, Fmake_network_process):
2960 (read_process_output_error_handler, exec_sentinel_error_handler):
2961 Rename or move locals.
2962 (Fmake_network_process): Define label "retry_connect" only if needed.
2963 (Fnetwork_interface_info): Fix pointer signedness.
2964 (process_send_signal): Add cast to avoid pointer signedness problem.
2965 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2966 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2968 Make tparam.h and terminfo.c consistent.
2969 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2970 Include tparam.h instead, since it declares them.
2971 * cm.h (PC): Remove extern decl; tparam.h now does this.
2972 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2973 * terminfo.c: Include tparam.h, to check interfaces.
2974 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2975 (tparam): Adjust signature to match interface in tparam.h;
2976 this removes some undefined behavior. Check that outstring and len
2977 are zero, which they always are with Emacs.
2978 * tparam.h (PC, BC, UP): New extern decls.
2980 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2981 (xftfont_open): Rename locals to avoid shadowing.
2983 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2984 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2985 (OTF_TAG_SYM): Omit macro if not needed.
2986 (ftfont_list): Remove unused local.
2987 (get_adstyle_property, ftfont_pattern_entity):
2988 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2989 Rename locals to avoid shadowing.
2991 * xfont.c (xfont_list_family): Mark var as initialized.
2993 * xml.c (make_dom): Now static.
2995 * composite.c (composition_compute_stop_pos): Rename local to
2997 (composition_reseat_it): Remove unused locals.
2998 (find_automatic_composition, composition_adjust_point): Likewise.
2999 (composition_update_it): Mark var as initialized.
3000 (find_automatic_composition): Mark vars as initialized,
3001 with a FIXME (Bug#8290).
3003 character.h: Rename locals to avoid shadowing.
3004 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3005 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3006 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3007 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3010 * textprop.c (property_change_between_p): Remove; unused.
3012 * intervals.c (interval_start_pos): Now static.
3014 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3016 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3017 Rename locals to avoid shadowing.
3019 * sound.c (wav_play, au_play, Fplay_sound_internal):
3020 Fix pointer signedness.
3021 (alsa_choose_format): Remove unused local var.
3022 (wav_play): Initialize a variable to 0, to prevent undefined
3023 behavior (Bug#8278).
3025 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3027 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3029 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3030 clobbering (Bug#8298).
3031 * sysdep.c (sys_subshell): Likewise.
3032 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3034 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3035 This should get cleaned up, so that child_setup has the
3036 same signature on all platforms.
3038 * callproc.c (call_process_cleanup): Now static.
3039 (relocate_fd): Rename locals to avoid shadowing.
3041 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3043 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3044 not to be necessary, and produces flickering.
3046 2011-03-20 Glenn Morris <rgm@gnu.org>
3048 * config.in: Remove file.
3050 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3052 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3053 are now in src/globals.h.
3054 (syms_of_minibuf): Remove spurious & from previous change.
3056 2011-03-20 Leo <sdl.web@gmail.com>
3058 * minibuf.c (completing-read-function): New variable.
3059 (completing-read-default): Rename from completing-read.
3060 (completing-read): Call completing-read-function.
3062 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3064 * xfaces.c (Fx_load_color_file):
3065 Read color file from absolute filename (bug#8250).
3067 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3069 * makefile.w32-in: Update dependencies.
3071 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3073 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3075 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3077 Fix more problems found by GCC 4.5.2's static checks.
3079 * process.c (make_serial_process_unwind, send_process_trap):
3080 (sigchld_handler): Now static.
3082 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3083 That way, the code declares only the vars that it needs.
3084 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3085 * s/cygwin.h (PTY_ITERATION): Likewise.
3086 * s/darwin.h (PTY_ITERATION): Likewise.
3087 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3089 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3090 * process.c (allocate_pty): Don't declare stb unless it's needed.
3092 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3093 (CONSTANTLIM): Remove; unused.
3094 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3095 Define only if needed.
3097 * unexelf.c (unexec): Name an expression,
3098 to avoid gcc -Wbad-function-cast warning.
3099 Use a different way to cause a compilation error if anyone uses
3100 n rather than nn, a way that does not involve shadowing.
3101 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3103 * deps.mk (unexalpha.o): Remove; unused.
3105 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3106 * unexec.h: New file.
3107 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3108 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3110 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3111 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3112 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3113 Change as necessary to match prototype in unexec.h.
3115 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3117 (back_comment, skip_chars): Mark vars as initialized.
3119 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3120 Rename locals to avoid shadowing.
3122 * lread.c (read1): Rewrite so as not to use empty "else".
3123 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3125 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3127 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3128 warning when compiling print.c.
3130 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3131 instead of using an uninitialized var.
3132 (font_sort_entities): Mark var as initialized.
3134 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3136 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3137 pointers to constants.
3138 (font_parse_fcname): Remove unused vars.
3139 (font_delete_unmatched): Now static.
3140 (font_get_spec): Remove; unused.
3141 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3142 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3143 Rename or move locals to avoid shadowing.
3145 * fns.c (require_nesting_list, require_unwind): Now static.
3146 (Ffillarray): Rename locals to avoid shadowing.
3148 * floatfns.c (domain_error2): Define only if needed.
3149 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3151 * alloc.c (mark_backtrace): Move decl from here ...
3152 * lisp.h: ... to here, so that it can be checked.
3154 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3155 (Fdefvar): Rewrite so as not to use empty "else".
3156 (lisp_indirect_variable): Name an expression,
3157 to avoid gcc -Wbad-function-cast warning.
3158 (Fdefvar): Rename locals to avoid shadowing.
3160 * callint.c (quotify_arg, quotify_args): Now static.
3161 (Fcall_interactively): Rename locals to avoid shadowing.
3162 Use const pointer when appropriate.
3164 * lisp.h (get_system_name, get_operating_system_release):
3165 Move decls here, to check interfaces.
3166 * process.c (get_operating_system_release): Move decl to lisp.h.
3167 * xrdb.c (get_system_name): Likewise.
3168 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3169 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3170 some of which prompt warnings from gcc -Wbad-function-cast.
3171 (Fformat_time_string, Fencode_time, Finsert_char):
3172 (Ftranslate_region_internal, Fformat):
3173 Rename or remove local vars to avoid shadowing.
3174 (Ftranslate_region_internal): Mark var as initialized.
3176 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3179 * lisp.h (eassert): Check that the argument compiles, even if
3180 ENABLE_CHECKING is not defined.
3182 * data.c (Findirect_variable): Name an expression, to avoid
3183 gcc -Wbad-function-cast warning.
3184 (default_value, arithcompare, arith_driver, arith_error): Now static.
3185 (store_symval_forwarding): Rename local to avoid shadowing.
3186 (Fmake_variable_buffer_local, Fmake_local_variable):
3187 Mark variables as initialized.
3188 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3190 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3191 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3192 Rename locals to avoid shadowing.
3193 (mark_stack): Move local variables into the #ifdef region where
3195 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3196 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3198 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3199 (GC_STRING_CHARS): Remove; not used.
3200 (Fmemory_limit): Cast sbrk's returned value to char *.
3202 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3203 avoids undefined behavior in theory.
3205 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3207 Use functions, not macros, for up- and down-casing (Bug#8254).
3208 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3209 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3210 to use the following functions instead of these macros.
3211 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3212 EMACS_INT, since callers assume the returned value fits in int.
3213 (upcase1): Likewise, for UPCASE_TABLE.
3214 (uppercasep, lowercasep, upcase): New static inline functions.
3215 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3216 the race-condition problem in the old DOWNCASE.
3218 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3219 Rename locals to avoid shadowing.
3220 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3221 (regex_compile, re_search_2, re_match_2_internal):
3222 Remove unused local vars.
3223 (FREE_VAR): Rewrite so as not to use empty "else",
3224 which gcc can warn about.
3225 (regex_compile, re_match_2_internal): Mark locals as initialized.
3226 (RETALLOC_IF): Define only if needed.
3227 (WORDCHAR_P): Likewise. This one is never needed, but is used
3228 only in a comment talking about a compiler bug, so put inside
3229 the #if 0 of that comment.
3230 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3231 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3234 * search.c (boyer_moore): Rename locals to avoid shadowing.
3235 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3236 (PREV_CHAR_BOUNDARY): Likewise.
3238 * search.c (simple_search): Remove unused var.
3240 * dired.c (compile_pattern): Move decl from here ...
3241 * lisp.h: ... to here, so that it can be checked.
3242 (struct re_registers): New forward decl.
3244 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3246 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3248 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3249 Rename locals to avoid shadowing.
3250 (Fvertical_motion): Mark locals as initialized.
3252 * casefiddle.c (casify_object, casify_region): Now static.
3253 (casify_region): Mark local as initialized.
3255 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3257 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3258 New macros, so that the caller can use some names other than
3259 gcpro1, gcpro2, etc.
3260 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3262 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3263 argument, for consistency with GCPRO2_VAR, etc: it is now the
3264 prefix of the variable, not the variable itself. All uses
3266 * dired.c (directory_files_internal, file_name_completion):
3267 Rename locals to avoid shadowing.
3269 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3270 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3271 dired.c's scmp function, had undefined behavior.
3272 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3273 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3274 * buffer.h: ... to here, because these macros use current_buffer,
3275 and the new implementation with inline functions needs to have
3276 current_buffer in scope now, rather than later when the macros
3278 (downcase, upcase1): New static inline functions.
3279 (DOWNCASE, UPCASE1): Reimplement using these functions.
3280 This avoids undefined behavior in expressions like
3281 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3282 from race conditions in accessing the global variables
3283 case_temp1 and case_temp2.
3284 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3285 * lisp.h (case_temp1, case_temp2): Remove their decls.
3286 * character.h (ASCII_CHAR_P): Move from here ...
3287 * lisp.h: ... to here, so that the inline functions mentioned
3290 * dired.c (directory_files_internal_unwind): Now static.
3292 * fileio.c (file_name_as_directory, directory_file_name):
3293 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3295 (file_name_as_directory): Use const pointers when appropriate.
3296 (Fexpand_file_name): Likewise. In particular, newdir might
3297 point at constant storage, so make it a const pointer.
3298 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3299 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3301 (Fset_file_times, Finsert_file_contents, auto_save_error):
3302 Rename locals to avoid shadowing.
3304 * minibuf.c (choose_minibuf_frame_1): Now static.
3305 (Ftry_completion, Fall_completions): Rename or remove locals
3308 * marker.c (bytepos_to_charpos): Remove; unused.
3310 * lisp.h (verify_bytepos, count_markers): New decls,
3311 so that gcc does not warn that these functions aren't declared.
3313 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3314 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3315 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3316 (copy_text): Remove unused local var.
3318 * filelock.c (within_one_second): Now static.
3319 (lock_file_1): Rename local to avoid shadowing.
3321 * buffer.c (fix_overlays_before): Mark locals as initialized.
3322 (fix_start_end_in_overlays): Likewise. This function should be
3323 simplified by using pointers-to-pointers, but that's a different
3325 (switch_to_buffer_1): Now static.
3326 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3327 (report_overlay_modification): Rename locals to avoid shadowing.
3329 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3330 Fix pointer signedness issue.
3331 (sys_subshell): Mark local as volatile if checking for lint,
3332 to suppress a gcc -Wclobbered warning that does not seem to be right.
3333 (MAXPATHLEN): Define only if needed.
3335 * process.c (serial_open, serial_configure): Move decls from here ...
3336 * systty.h: ... to here, so that they can be checked.
3338 * fns.c (get_random, seed_random): Move extern decls from here ...
3339 * lisp.h: ... to here, so that they can be checked.
3341 * sysdep.c (reset_io): Now static.
3342 (wait_for_termination_signal): Remove; unused.
3344 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3345 (copy_keymap_item, append_key, push_text_char_description):
3347 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3348 (DENSE_TABLE_SIZE): Remove; unused.
3349 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3350 (describe_map_tree):
3351 Rename locals to avoid shadowing.
3353 * keyboard.c: Declare functions static if they are not used elsewhere.
3354 (echo_char, echo_dash, cmd_error, top_level_2):
3355 (poll_for_input, handle_async_input): Now static.
3356 (read_char, kbd_buffer_get_event, make_lispy_position):
3357 (make_lispy_event, make_lispy_movement, apply_modifiers):
3358 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3359 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3360 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3361 (read_key_sequence, read_char): Mark locals as initialized.
3362 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3364 * keyboard.h (make_ctrl_char): New decl.
3365 (mark_kboards): Move decl here ...
3366 * alloc.c (mark_kboards): ... from here.
3368 * lisp.h (force_auto_save_soon): New decl.
3370 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3371 (DEFINE_DUMMY_FUNCTION): New macro.
3372 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3374 (main): Add casts to avoid warnings
3375 if GCC considers string literals to be constants.
3377 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3379 * dbusbind.c: Pointer signedness fixes.
3380 (xd_signature, xd_append_arg, xd_initialize):
3381 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3382 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3383 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3384 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3386 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3387 if GCC considers string literals to be constants.
3388 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3390 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3392 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3393 (print_preprocess, print_object): New macro to fix last change.
3395 * print.c (print_preprocess): Don't forget font objects.
3397 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3399 * emacs.c (USAGE3): Doc fixes.
3401 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3403 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3406 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3408 * lisp.h (VWindow_system, Qfile_name_history):
3409 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3410 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3411 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3413 * w32select.c: Don't #include "keyboard.h".
3414 (run_protected): Add extern declaration for waiting_for_input.
3416 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3417 * w32console.c (detect_input_pending, read_input_pending)
3418 (encode_terminal_code):
3419 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3420 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3421 (w32_system_caret_y, Qfile_name_history):
3422 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3423 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3424 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3425 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3426 * w32proc.c (Qlocal, report_file_error):
3427 * w32term.c (Vwindow_system, updating_frame):
3428 * w32uniscribe.c (initialized, uniscribe_font_driver):
3429 Remove unneeded extern declarations.
3431 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3433 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3435 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3437 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3438 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3439 These macros can no longer be used for assignment.
3441 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3442 Assign struct members directly, instead of using BUF_BEGV etc.
3443 (record_buffer_markers, fetch_buffer_markers): New functions for
3444 recording and fetching special buffer markers.
3445 (set_buffer_internal_1, set_buffer_temp): Use them.
3447 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3449 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3451 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3452 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3454 * xdisp.c (hscroll_window_tree):
3455 (reconsider_clip_changes): Use PT instead of BUF_PT.
3457 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3459 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3460 $(EMACS_ROOT)/lib/intprops.h.
3462 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3464 Fix more problems found by GCC 4.5.2's static checks.
3466 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3467 to unsigned char * to avoid compiler diagnostic.
3468 (xg_free_frame_widgets): Make it clear that a local variable is
3469 needed only if USE_GTK_TOOLTIP.
3470 (gdk_window_get_screen): Make it clear that this macro is needed
3471 only if USE_GTK_TOOLTIP.
3472 (int_gtk_range_get_value): New function, which avoids a diagnostic
3473 from gcc -Wbad-function-cast.
3474 (xg_set_toolkit_scroll_bar_thumb): Use it.
3475 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3476 diagnostic from gcc -Wbad-function-cast.
3477 (get_utf8_string, xg_get_file_with_chooser):
3478 Rename locals to avoid shadowing.
3479 (create_dialog): Move locals to avoid shadowing.
3481 * xgselect.c (xg_select): Remove unused var.
3483 * image.c (four_corners_best): Mark locals as initialized.
3484 (gif_load): Initialize transparent_p to zero (Bug#8238).
3485 Mark another local as initialized.
3486 (my_png_error, my_error_exit): Mark with NO_RETURN.
3488 * image.c (clear_image_cache): Now static.
3489 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3490 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3491 (x_edge_detection): Remove unnecessary cast that
3492 gcc -Wbad-function-cast diagnoses.
3493 (gif_load): Fix pointer signedness.
3494 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3495 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3497 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3499 Improve quality of tests for time stamp overflow.
3500 For example, without this patch (encode-time 0 0 0 1 1
3501 1152921504606846976) returns the obviously-bogus value (-948597
3502 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3503 reports time overflow. See
3504 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3505 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3506 * editfns.c: Include limits.h and intprops.h.
3507 (TIME_T_MIN, TIME_T_MAX): New macros.
3508 (time_overflow): Move earlier, to before first use.
3509 (hi_time, lo_time): New functions, for an accurate test for
3511 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3512 (Fget_internal_run_time): Don't assume time_t fits in int.
3513 (make_time): Use list2 instead of Fcons twice.
3514 (Fdecode_time): More accurate test for out-of-range times.
3515 (check_tm_member): New function.
3516 (Fencode_time): Use it, to test for out-of-range times.
3517 (lisp_time_argument): Don't rely on undefined left-shift and
3518 right-shift behavior when checking for time stamp overflow.
3520 * editfns.c (time_overflow): New function, refactoring common code.
3521 (Fformat_time_string, Fdecode_time, Fencode_time):
3522 (Fcurrent_time_string): Use it.
3524 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3525 * dired.c (make_time): Move to ...
3526 * editfns.c (make_time): ... here.
3527 * systime.h: Note the move.
3529 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3531 * fringe.c (update_window_fringes): Remove unused variables.
3533 * unexmacosx.c (copy_data_segment): Also copy __got section.
3536 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3538 * termcap.c [MSDOS]: Include "msdos.h".
3539 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3540 Constify `char *' arguments and their references according to
3541 prototypes in tparam.h.
3543 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3545 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3546 Adapt all references accordingly.
3548 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3550 2011-03-11 Tom Tromey <tromey@redhat.com>
3552 * buffer.c (syms_of_buffer): Remove obsolete comment.
3554 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3556 * termhooks.h (encode_terminal_code): Declare prototype.
3558 * msdos.c (encode_terminal_code): Don't declare prototype.
3560 * term.c (encode_terminal_code): Now external again, used by
3561 w32console.c and msdos.c.
3563 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3564 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3566 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3568 Fix some minor problems found by GCC 4.5.2's static checks.
3570 * fringe.c (update_window_fringes): Mark locals as initialized
3572 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3574 * alloc.c (mark_fringe_data): Move decl from here ...
3575 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3576 to check its interface.
3577 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3579 * fontset.c (free_realized_fontset): Now static.
3580 (Fset_fontset_font): Rename local to avoid shadowing.
3581 (fontset_font): Mark local as initialized.
3582 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3584 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3586 * xselect.c (x_disown_buffer_selections): Remove; not used.
3587 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3588 (x_own_selection, Fx_disown_selection_internal): Rename locals
3590 (x_handle_dnd_message): Remove local to avoid shadowing.
3592 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3593 so that the caller can use some name other than gcpro1.
3594 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3595 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3596 (Fx_backspace_delete_keys_p):
3597 Use them to avoid shadowing, and rename vars to avoid shadowing.
3598 (x_decode_color, x_set_name, x_window): Now static.
3599 (Fx_create_frame): Add braces to silence GCC warning.
3600 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3601 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3602 Remove unused locals.
3603 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3604 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3605 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3608 * xterm.h (x_mouse_leave): New decl.
3610 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3611 Remove unused functions.
3612 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3613 (x_calc_absolute_position): Now static.
3614 (XTread_socket): Don't define label "out" unless it's used.
3615 Don't declare local "event" unless it's used.
3616 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3617 unless they are used.
3618 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3619 (x_fatal_error_signal): Remove; not used.
3620 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3621 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3622 (x_error_catcher, x_connection_closed, x_error_handler):
3623 (x_error_quitter, xembed_send_message, x_iconify_frame):
3624 (my_log_handler): Rename locals to avoid shadowing.
3625 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3626 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3628 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3629 Rename or move locals to avoid shadowing.
3630 (tty_defined_color, merge_face_heights): Now static.
3631 (free_realized_faces_for_fontset): Remove; not used.
3632 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3633 does not deduce is never used uninitialized.
3634 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3635 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3637 * terminal.c (store_terminal_param): Now static.
3639 * xmenu.c (menu_highlight_callback): Now static.
3640 (set_frame_menubar): Remove unused local.
3641 (xmenu_show): Rename parameter to avoid shadowing.
3642 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3643 since they might point to immutable storage.
3644 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3645 since it's unused otherwise.
3647 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3648 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3649 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3650 avoids a gcc -Wuninitialized diagnostic.
3651 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3652 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3653 does not deduce are never used uninitialized.
3655 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3657 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3658 * window.c (window_loop, size_window):
3659 (run_window_configuration_change_hook, enlarge_window): Likewise.
3661 * window.c (display_buffer): Now static.
3662 (size_window): Mark variables that gcc -Wuninitialized
3663 does not deduce are never used uninitialized.
3664 * window.h (check_all_windows): New decl, to forestall
3665 gcc -Wmissing-prototypes diagnostic.
3666 * dispextern.h (bidi_dump_cached_states): Likewise.
3668 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3670 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3672 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3673 and to avoid gcc -Wuninitialized warning.
3674 (load_charset_map): Mark variables that gcc -Wuninitialized
3675 does not deduce are never used uninitialized.
3676 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3678 * coding.c (coding_set_source, coding_set_destination):
3679 Use "else { /* comment */ }" rather than "else /* comment */;"
3680 for clarity, and to avoid gcc -Wempty-body warning.
3681 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3682 a block, when the outer 'i' will do.
3683 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3684 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3685 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3686 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3687 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3688 Rename locals to avoid shadowing.
3689 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3690 * coding.c (emacs_mule_char, encode_invocation_designation):
3691 Now static, since they're not used elsewhere.
3692 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3693 (decode_coding_object, encode_coding_object, detect_coding_system):
3694 (decode_coding_emacs_mule): Mark variables that gcc
3695 -Wuninitialized does not deduce are never used uninitialized.
3696 (detect_coding_iso_2022): Initialize a local variable that might
3697 be used uninitialized. Leave a FIXME because it's not clear that
3698 this initialization is needed. (Bug#8211)
3699 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3700 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3701 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3702 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3703 Remove unused macros.
3705 * category.c (hash_get_category_set): Remove unused local var.
3706 (copy_category_table): Now static, since it's not used elsewhere.
3707 * character.c (string_count_byte8): Likewise.
3709 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3710 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3712 * chartab.c (copy_sub_char_table): Now static, since it's not used
3714 (sub_char_table_ref_and_range, char_table_ref_and_range):
3715 Rename locals to avoid shadowing.
3716 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3718 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3719 (BIDI_BOB): Remove unused macro.
3721 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3722 deduce are never used uninitialized.
3723 * term.c (encode_terminal_code): Likewise.
3725 * term.c (encode_terminal_code): Now static. Remove unused local.
3727 * tparam.h: New file.
3728 * term.c, tparam.h: Include it.
3729 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3730 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3731 Move these decls to tparam.h, and make them agree with what
3732 is actually in tparam.c. The previous trick of using incompatible
3733 decls in different modules does not conform to the C standard.
3734 All callers of tparam changed to use tparam's actual API.
3735 * tparam.c (tparam1, tparam, tgoto):
3736 Use const pointers where appropriate.
3738 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3739 * cm.h (struct cm): Likewise.
3740 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3741 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3742 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3743 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3744 (turn_on_face, init_tty): Likewise.
3745 * termchar.h (struct tty_display_info): Likewise.
3747 * term.c (term_mouse_position): Rename local to avoid shadowing.
3749 * alloc.c (mark_ttys): Move decl from here ...
3750 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3752 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3754 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3756 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3758 * search.c (compile_pattern_1): Remove argument regp, unused since
3759 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3760 (compile_pattern): Don't pass it.
3762 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3764 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3765 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3767 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3769 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3771 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3772 gdk_window_get_screen, gdk_window_get_geometry,
3773 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3774 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3775 (xg_get_pixbuf_from_pixmap): New function.
3776 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3777 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3778 Call xg_get_pixbuf_from_pixmap instead of
3779 gdk_pixbuf_get_from_drawable.
3780 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3781 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3782 (xg_check_special_colors): Use GtkStyleContext and its functions
3784 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3785 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3786 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3787 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3788 Call gtk_widget_get_preferred_size.
3789 (xg_frame_resized): gdk_window_get_geometry only takes 5
3791 (xg_win_to_widget, xg_event_is_for_menubar):
3792 Call gdk_x11_window_lookup_for_display.
3793 (xg_set_widget_bg): New function.
3794 (delete_cb): New function.
3795 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3796 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3797 (xg_set_background_color): Call xg_set_widget_bg.
3798 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3799 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3800 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3801 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3803 (update_frame_tool_bar): Call gtk_widget_hide.
3804 (xg_initialize): Use GDK_KEY_g.
3806 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3808 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3810 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3811 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3812 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3814 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3816 * w32xfns.c (select_palette): Check success of RealizePalette against
3817 GDI_ERROR, not zero.
3819 See ChangeLog.11 for earlier changes.
3825 Copyright (C) 2011 Free Software Foundation, Inc.
3827 This file is part of GNU Emacs.
3829 GNU Emacs is free software: you can redistribute it and/or modify
3830 it under the terms of the GNU General Public License as published by
3831 the Free Software Foundation, either version 3 of the License, or
3832 (at your option) any later version.
3834 GNU Emacs is distributed in the hope that it will be useful,
3835 but WITHOUT ANY WARRANTY; without even the implied warranty of
3836 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3837 GNU General Public License for more details.
3839 You should have received a copy of the GNU General Public License
3840 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.