1 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7 * insdel.c, lisp.h (buffer_overflow): New function.
8 (insert_from_buffer_1, replace_range, replace_range_2):
9 * insdel.c (make_gap_larger):
10 * editfns.c (Finsert_char):
11 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
15 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
17 Integer overflow and signedness fixes (Bug#8873).
19 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
20 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
22 * fileio.c: Don't assume EMACS_INT fits in off_t.
23 (emacs_lseek): New static function.
24 (Finsert_file_contents, Fwrite_region): Use it.
25 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
27 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
29 * fns.c: Don't overflow int when computing a list length.
30 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
31 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
32 truncation on 64-bit hosts. Check for QUIT every
33 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
34 faster and is responsive enough.
35 (Flength): Report an error instead of overflowing an integer.
36 (Fsafe_length): Return a float if the value is not representable
37 as a fixnum. This shouldn't happen except in contrived situations.
38 (Fnthcdr, Fsort): Don't assume list length fits in int.
39 (Fcopy_sequence): Don't assume vector length fits in int.
41 * alloc.c: Check that resized vectors' lengths fit in fixnums.
42 (header_size, word_size): New constants.
43 (allocate_vectorlike): Don't check size overflow here.
44 (allocate_vector): Check it here instead, since this is the only
45 caller of allocate_vectorlike that could cause overflow.
46 Check that the new vector's length is representable as a fixnum.
48 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
49 The previous code was bogus. For example, next_almost_prime (32)
50 returned 39, which is undesirable as it is a multiple of 3; and
51 next_almost_prime (24) returned 25, which is a multiple of 5 so
52 why was the code bothering to check for multiples of 7?
54 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
56 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
58 Variadic C functions now count arguments with ptrdiff_t.
59 This partly undoes my 2011-03-30 change, which replaced int with size_t.
60 Back then I didn't know that the Emacs coding style prefers signed int.
61 Also, in the meantime I found a few more instances where arguments
62 were being counted with int, which may truncate counts on 64-bit
63 machines, or EMACS_INT, which may be unnecessarily wide.
64 * lisp.h (struct Lisp_Subr.function.aMANY)
65 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
66 Arg counts are now ptrdiff_t, not size_t.
67 All variadic functions and their callers changed accordingly.
68 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
69 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
70 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
71 * callint.c (Fcall_interactively): Check arg count for overflow,
72 to avoid potential buffer overrun. Use signed char, not 'int',
73 for 'varies' array, so that we needn't bother to check its size
74 calculation for overflow.
75 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
76 * eval.c (apply_lambda):
77 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
78 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
79 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
81 * callint.c (Fcall_interactively): Don't use index var as event count.
83 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
84 * mem-limits.h (SIZE): Remove; no longer used.
86 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
88 Remove unnecessary casts.
89 * xterm.c (x_term_init):
90 * xfns.c (x_set_border_pixel):
91 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
92 These aren't needed now that we assume ANSI C.
94 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
95 It's more likely to cause problems (due to unsigned overflow)
98 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
100 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
102 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
104 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
106 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
108 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
110 GLYPH_CODE_FACE returns EMACS_INT, not int.
111 * dispextern.h (merge_faces):
112 * xfaces.c (merge_faces):
113 * xdisp.c (get_next_display_element, next_element_from_display_vector):
114 Don't assume EMACS_INT fits in int.
116 * character.h (CHAR_VALID_P): Remove unused parameter.
117 * fontset.c, lisp.h, xdisp.c: All uses changed.
119 * editfns.c (Ftranslate_region_internal): Omit redundant test.
121 * fns.c (concat): Minor tuning based on overflow analysis.
122 This doesn't fix any bugs. Use int to hold character, instead
123 of constantly refetching from Emacs object. Use XFASTINT, not
124 XINT, for value known to be a character. Don't bother comparing
125 a single byte to 0400, as it's always less.
127 * floatfns.c (Fexpt):
128 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
130 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
133 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
135 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
136 Without this fix, on a 64-bit host (aset S 0 4294967386) would
137 incorrectly succeed when S was a string, because 4294967386 was
138 truncated before it was used.
140 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
141 Otherwise, an out-of-range integer could cause undefined behavior
144 * composite.c: Use int, not EMACS_INT, for characters.
145 (fill_gstring_body, composition_compute_stop_pos): Use int, not
146 EMACS_INT, for values that are known to be in character range.
147 This doesn't fix any bugs but is the usual style inside Emacs and
148 may generate better code on 32-bit machines.
150 Make sure a 64-bit char is never passed to ENCODE_CHAR.
151 This is for reasons similar to the recent CHAR_STRING fix.
152 * charset.c (Fencode_char): Check that character arg is actually
153 a character. Pass an int to ENCODE_CHAR.
154 * charset.h (ENCODE_CHAR): Verify that the character argument is no
155 wider than 'int', as a compile-time check to prevent future regressions
158 * character.c (char_string): Remove unnecessary casts.
160 Make sure a 64-bit char is never passed to CHAR_STRING.
161 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
162 by silently ignoring the top 32 bits, allowing some values
163 that were far too large to be valid characters.
164 * character.h: Include <verify.h>.
165 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
166 arguments are no wider than unsigned, as a compile-time check
167 to prevent future regressions in this area.
169 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
170 (Fsubst_char_in_region):
172 * xdisp.c (decode_mode_spec_coding):
173 Adjust to CHAR_STRING's new requirement.
174 * editfns.c (Finsert_char, Fsubst_char_in_region):
175 * fns.c (concat): Check that character args are actually
176 characters. Without this test, these functions did the wrong
177 thing with wildly out-of-range values on 64-bit hosts.
179 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
180 These casts should not be needed on 32-bit hosts, either.
181 * keyboard.c (read_char):
182 * lread.c (Fload): Remove casts to unsigned.
184 * lisp.h (UNSIGNED_CMP): New macro.
185 This fixes comparison bugs on 64-bit hosts.
186 (ASCII_CHAR_P): Use it.
187 * casefiddle.c (casify_object):
188 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
189 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
190 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
191 * dispextern.h (FACE_FROM_ID):
192 * keyboard.c (read_char): Use UNSIGNED_CMP.
194 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
195 not to EMACS_INT, to avoid GCC warning.
197 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
199 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
200 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
201 isn't needed on 32-bit machines.
203 * buffer.c (Fgenerate_new_buffer_name):
204 Use EMACS_INT for count, not int.
205 (advance_to_char_boundary): Return EMACS_INT, not int.
207 * data.c (Qcompiled_function): Now static.
209 * window.c (window_body_lines): Now static.
211 * image.c (gif_load): Rename local to avoid shadowing.
213 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
214 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
215 * alloc.c (make_save_value): Integer argument is now of type
217 (mark_object): Use ptrdiff_t, not int.
218 * lisp.h (pD): New macro.
219 * print.c (print_object): Use it.
221 * alloc.c: Use EMACS_INT, not int, to count objects.
222 (total_conses, total_markers, total_symbols, total_vector_size)
223 (total_free_conses, total_free_markers, total_free_symbols)
224 (total_free_floats, total_floats, total_free_intervals)
225 (total_intervals, total_strings, total_free_strings):
226 Now EMACS_INT, not int. All uses changed.
227 (Fgarbage_collect): Compute overall total using a double, so that
228 integer overflow is less likely to be a problem. Check for overflow
229 when converting back to an integer.
230 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
231 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
232 These were 'int' variables that could overflow on 64-bit hosts;
233 they were never used, so remove them instead of repairing them.
234 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
235 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
236 Previously, this ceilinged at INT_MAX, but that doesn't work on
238 (allocate_pseudovector): Don't use EMACS_INT when int would do.
240 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
241 (allocate_vectorlike): Check for ptrdiff_t overflow.
242 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
243 when a (possibly-narrower) signed value would do just as well.
244 We prefer using signed arithmetic, to avoid comparison confusion.
246 * alloc.c: Catch some string size overflows that we were missing.
247 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
248 for convenience in STRING_BYTES_MAX.
249 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
250 The definition here is exact; the one in lisp.h was approximate.
251 (allocate_string_data): Check for string overflow. This catches
252 some instances we weren't catching before. Also, it catches
253 size_t overflow on (unusual) hosts where SIZE_MAX <= min
254 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
255 and ptrdiff_t and EMACS_INT are both 64 bits.
257 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
258 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
259 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
261 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
263 * alloc.c (Fmake_string): Check for out-of-range init.
265 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
267 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
269 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
271 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
272 xg_get_default_scrollbar_width.
274 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
275 (int_gtk_range_get_value): Move to the scroll bar part of the file.
276 (style_changed_cb): Call update_theme_scrollbar_width and call
277 x_set_scroll_bar_default_width and xg_frame_set_char_size for
278 all frames (Bug#8505).
279 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
280 Call gtk_window_set_resizable if HAVE_GTK3.
281 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
282 and height if HAVE_GTK3 (Bug#8505).
283 (scroll_bar_width_for_theme): New variable.
284 (update_theme_scrollbar_width): New function.
285 (xg_get_default_scrollbar_width): Move code to
286 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
287 (xg_initialize): Call update_theme_scrollbar_width.
289 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
291 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
293 2011-06-12 Martin Rudalics <rudalics@gmx.at>
295 * frame.c (make_frame): Call other_buffer_safely instead of
298 * window.c (temp_output_buffer_show): Call display_buffer with
299 second argument Vtemp_buffer_show_specifiers and reset latter
300 immediately after the call.
301 (Vtemp_buffer_show_specifiers): New variable.
302 (auto_window_vscroll_p, next_screen_context_lines)
303 (Vscroll_preserve_screen_position): Remove leading asterisks from
306 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
308 Fix minor problems found by GCC 4.6.0 static checking.
309 * buffer.c (Qclone_number): Remove for now, as it's unused.
310 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
311 (record_buffer): Remove unused local.
312 * frame.c (other_visible_frames, frame_buffer_list): Now static.
313 (set_frame_buffer_list): Remove; unused.
314 * frame.h (other_visible_frames): Remove decl.
315 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
316 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
317 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
319 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
320 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
321 Define only if HAVE_GPM.
322 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
323 (update_hints_inhibit): Remove; never set. All uses removed.
324 * widgetprv.h (emacsFrameClassRec): Remove decl.
325 * window.c (delete_deletable_window): Now returns void, since it
326 wasn't returning anything.
327 (compare_window_configurations): Remove unused locals.
328 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
329 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
330 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
331 the same widths as pointers. This follows up on the 2011-05-06 patch.
332 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
334 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
336 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
338 * makefile.w32-in: Update dependencies.
339 (LISP_H): Add lib/intprops.h.
341 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
343 * image.c (gif_load): Add animation frame delay to the metadata.
344 (syms_of_image): Use DEFSYM. New symbol `delay'.
346 2011-06-11 Martin Rudalics <rudalics@gmx.at>
348 * window.c (delete_deletable_window): Re-add.
349 (Fset_window_configuration): Rewrite to handle dead buffers and
350 consequently deletable windows.
351 (window_tree, Fwindow_tree): Remove. Supply functionality in
353 (compare_window_configurations): Simplify code.
355 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
357 * image.c (imagemagick_load_image): Fix type mismatch.
358 (Fimagemagick_types): Likewise.
360 * window.h (replace_buffer_in_windows): Declare.
362 2011-06-11 Martin Rudalics <rudalics@gmx.at>
364 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
365 Qclone_number. Remove external declaration of Qdelete_window.
366 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
368 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
369 Qbuffer_list_update_hook if allowed.
370 (Fother_buffer): Rewrite doc-string. Major rewrite for new
371 buffer list implementation.
372 (other_buffer_safely): New function.
373 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
374 calls to replace_buffer_in_windows and
375 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
377 (record_buffer): Inhibit quitting and rewrite using quittable
378 functions. Run Qbuffer_list_update_hook if allowed.
379 (Frecord_buffer, Funrecord_buffer): New functions.
380 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
381 switch-to-buffer to window.el.
382 (bury-buffer): Move to window.el.
383 (Vbuffer_list_update_hook): New variable.
385 * lisp.h (other_buffer_safely): Add prototype in buffer.c
388 * window.h (resize_frame_windows): Move up in code.
389 (Fwindow_frame): Remove EXFUN.
390 (replace_buffer_in_all_windows): Remove prototype.
391 (replace_buffer_in_windows_safely): Add prototype.
393 * window.c: Declare Qdelete_window static again. Move down
394 declaration of select_count.
395 (Fnext_window, Fprevious_window): Rewrite doc-strings.
396 (Fother_window): Move to window.el.
397 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
398 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
399 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
401 (replace_buffer_in_windows): Implement by calling
402 Qreplace_buffer_in_windows.
403 (replace_buffer_in_all_windows): Remove with some functionality
404 moved into replace_buffer_in_windows_safely.
405 (replace_buffer_in_windows_safely): New function.
406 (select_window_norecord, select_frame_norecord): Move in front
407 of run_window_configuration_change_hook. Remove now obsolete
409 (Fset_window_buffer): Rewrite doc-string. Call
410 Qrecord_window_buffer.
411 (keys_of_window): Move binding for other-window to window.el.
413 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
415 * dispextern.h (struct image): Replace data member, whose int_val
416 and ptr_val fields were not used by anything, with a single
419 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
420 (gif_clear_image, gif_load, imagemagick_load_image)
421 (gs_clear_image, gs_load): Callers changed.
423 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
425 * buffer.h: Include <time.h>, for time_t.
426 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
428 Fix minor problems found by static checking.
430 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
432 Make identifiers static if they are not used in other modules.
433 * data.c (Qcompiled_function, Qframe, Qvector):
434 * image.c (QimageMagick, Qsvg):
435 * minibuf.c (Qmetadata):
436 * window.c (resize_window_check, resize_root_window): Now static.
437 * window.h (resize_window_check, resize_root_window): Remove decls.
439 * window.c (window_deletion_count, delete_deletable_window):
441 (window_body_lines): Now static.
442 (Fdelete_other_windows_internal): Mark vars as initialized.
443 Make sure 'resize_failed' is initialized.
444 (run_window_configuration_change_hook): Rename local to avoid shadowing.
445 (resize_window_apply): Remove unused local.
446 * window.h (delete_deletable_window): Remove decl.
448 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
449 (imagemagick_load_image): Fix pointer signedness problem by changing
450 last arg from unsigned char * to char *. All uses changed.
451 Also, fix a local for similar reasons.
452 Remove unused locals. Remove locals to avoid shadowing.
453 (fn_rsvg_handle_free): Remove; unused.
454 (svg_load, svg_load_image): Fix pointer signedness problem.
455 (imagemagick_load_image): Don't use garbage pointer image_wand.
457 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
459 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
461 * image.c (gif_load): Fix omitted cast error introduced by
464 2011-06-10 Martin Rudalics <rudalics@gmx.at>
466 * window.h (resize_proportionally, orig_total_lines)
467 (orig_top_line): Remove from window structure.
468 (set_window_height, set_window_width, change_window_heights)
469 (Fdelete_window): Remove prototypes.
470 (resize_frame_windows): Remove duplicate declaration.
472 2011-06-10 Eli Zaretskii <eliz@gnu.org>
474 * window.h (resize_frame_windows, resize_window_check)
475 (delete_deletable_window, resize_root_window)
476 (resize_frame_windows): Declare prototypes.
478 * window.c (resize_window_apply): Make definition be "static" to
481 2011-06-10 Martin Rudalics <rudalics@gmx.at>
483 * window.c: Remove declarations of Qwindow_size_fixed,
484 window_min_size_1, window_min_size_2, window_min_size,
485 size_window, window_fixed_size_p, enlarge_window, delete_window.
486 Remove static from declaration of Qdelete_window, it's
487 temporarily needed by Fbury_buffer.
488 (replace_window): Don't assign orig_top_line and
490 (Fdelete_window, delete_window): Remove. Window deletion is
491 handled by window.el.
492 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
493 Fdelete_window calls with calls to Qdelete_window.
494 (Fdelete_other_windows): Remove. Deleting other windows is
495 handled by window.el.
496 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
497 handled in window.el.
498 (window_min_size_2, window_min_size_1, window_min_size): Remove.
499 Window minimum sizes are handled in window.el.
500 (shrink_windows, size_window, set_window_height)
501 (set_window_width, change_window_heights, window_height)
502 (window_width, CURBEG, CURSIZE, enlarge_window)
503 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
504 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
505 handled in window.el.
506 (make_dummy_parent): Rename to make_parent_window and give it a
507 second argument horflag.
508 (make_window): Don't set resize_proportionally any more.
509 (Fsplit_window): Remove. Windows are split in window.el.
510 (save_restore_action, save_restore_orig_size)
511 (shrink_window_lowest_first, save_restore_orig_size): Remove.
512 Resize mini windows in window.el.
513 (grow_mini_window, shrink_mini_window): Implement by calling
514 Qresize_root_window_vertically, resize_window_check and
516 (saved_window, Fset_window_configuration, save_window_save): Do
517 not handle orig_top_line, orig_total_lines, and
518 resize_proportionally.
519 (window_min_height, window_min_width): Move to window.el.
520 (keys_of_window): Move bindings for delete-other-windows,
521 split-window, delete-window and enlarge-window to window.el.
523 * buffer.c: Temporarily extern Qdelete_window.
524 (Fbury_buffer): Temporarily call Qdelete_window instead of
525 Fdelete_window (Fbury_buffer will move to window.el soon).
527 * frame.c (set_menu_bar_lines_1): Remove code handling
528 orig_top_line and orig_total_lines.
530 * dispnew.c (adjust_frame_glyphs_initially): Don't use
531 set_window_height but set heights directly.
532 (change_frame_size_1): Use resize_frame_windows.
534 * xdisp.c (init_xdisp): Don't use set_window_height but set
537 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
538 resize_frame_windows instead of change_window_heights and run
539 run_window_configuration_change_hook.
541 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
542 instead of change_window_heights and run
543 run_window_configuration_change_hook.
545 2011-06-09 Martin Rudalics <rudalics@gmx.at>
547 * window.c (replace_window): Rename second argument REPLACEMENT to
548 NEW. New third argument SETFLAG. Rewrite.
549 (delete_window, make_dummy_parent): Call replace_window with
551 (window_list_1): Move down in code.
552 (run_window_configuration_change_hook): Move set_buffer part
553 before select_frame_norecord part in order to unwind correctly.
554 Rename count1 to count.
555 (recombine_windows, delete_deletable_window, resize_root_window)
556 (Fdelete_other_windows_internal)
557 (Frun_window_configuration_change_hook, make_parent_window)
558 (resize_window_check, resize_window_apply, Fresize_window_apply)
559 (resize_frame_windows, Fsplit_window_internal)
560 (Fdelete_window_internal, Fresize_mini_window_internal): New
562 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
564 2011-06-08 Martin Rudalics <rudalics@gmx.at>
566 * window.h (window): Add some new members to window structure -
567 normal_lines, normal_cols, new_total, new_normal, clone_number,
568 splits, nest, prev_buffers, next_buffers.
569 (WINDOW_TOTAL_SIZE): Move here from window.c.
570 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
572 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
574 (make_dummy_parent): Set new members of windows structure.
575 (make_window): Move down in code. Handle new members of window
577 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
578 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
579 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
580 (Fset_window_prev_buffers, Fwindow_next_buffers)
581 (Fset_window_next_buffers, Fset_window_clone_number): New
583 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
584 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
586 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
587 Argument WINDOW can be now internal window too.
588 (Fwindow_use_time): Move up in code.
589 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
591 (Fset_window_configuration, saved_window)
592 (Fcurrent_window_configuration, save_window_save): Handle new
593 members of window structure.
594 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
595 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
596 (syms_of_window): New Lisp objects Qrecord_window_buffer,
597 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
598 Qget_mru_window, Qresize_root_window,
599 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
600 Qauto_buffer_name; staticpro them.
602 2011-06-07 Martin Rudalics <rudalics@gmx.at>
604 * window.c (Fwindow_total_size, Fwindow_left_column)
605 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
606 (Fwindow_list_1): New functions.
607 (window_box_text_cols): Replace with window_body_cols.
608 (Fwindow_width, Fscroll_left, Fscroll_right): Use
609 window_body_cols instead of window_box_text_cols.
610 (delete_window, Fset_window_configuration): Call
611 delete_all_subwindows with window as argument.
612 (delete_all_subwindows): Take a window as argument and not a
614 (window_loop): Remove handling of GET_LRU_WINDOW and
616 (Fget_lru_window, Fget_largest_window): Move to window.el.
618 * window.h: Extern window_body_cols instead of
619 window_box_text_cols. delete_all_subwindows now takes a
620 Lisp_Object as argument.
622 * indent.c (compute_motion, Fcompute_motion): Use
623 window_body_cols instead of window_box_text_cols.
625 * frame.c (delete_frame): Call delete_all_subwindows with root
628 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
630 * fns.c (Fputhash): Document return value.
632 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
634 * image.c (gif_load): Implement gif89a spec "no disposal" method.
636 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
638 Cons<->int and similar integer overflow fixes (Bug#8794).
640 Check for overflow when converting integer to cons and back.
641 * charset.c (Fdefine_charset_internal, Fdecode_char):
642 Use cons_to_unsigned to catch overflow.
643 (Fencode_char): Use INTEGER_TO_CONS.
644 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
645 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
646 * data.c (long_to_cons, cons_to_long): Remove.
647 (cons_to_unsigned, cons_to_signed): New functions.
648 These signal an error for invalid or out-of-range values.
649 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
650 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
651 * font.c (Ffont_variation_glyphs):
652 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
653 * lisp.h: Include <intprops.h>.
654 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
655 (cons_to_signed, cons_to_unsigned): New decls.
656 (long_to_cons, cons_to_long): Remove decls.
657 * undo.c (record_first_change): Use INTEGER_TO_CONS.
658 (Fprimitive_undo): Use CONS_TO_INTEGER.
659 * xfns.c (Fx_window_property): Likewise.
660 * xselect.c: Include <limits.h>.
661 (x_own_selection, selection_data_to_lisp_data):
663 (x_handle_selection_request, x_handle_selection_clear)
664 (x_get_foreign_selection, Fx_disown_selection_internal)
665 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
666 (lisp_data_to_selection_data): Use cons_to_unsigned.
667 (x_fill_property_data): Use cons_to_signed.
668 Report values out of range.
670 Check for buffer and string overflow more precisely.
671 * buffer.h (BUF_BYTES_MAX): New macro.
672 * lisp.h (STRING_BYTES_MAX): New macro.
673 * alloc.c (Fmake_string):
674 * character.c (string_escape_byte8):
675 * coding.c (coding_alloc_by_realloc):
677 * editfns.c (Fformat):
679 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
680 since they may not be the same number.
681 * editfns.c (Finsert_char):
682 * fileio.c (Finsert_file_contents):
683 Likewise for BUF_BYTES_MAX.
685 * image.c: Use ptrdiff_t, not int, for sizes.
686 (slurp_file): Switch from int to ptrdiff_t.
688 (slurp_file): Check that file size fits in both size_t (for
689 malloc) and ptrdiff_t (for sanity and safety).
691 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
692 if b->modtime has its maximal value.
694 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
696 Don't assume time_t can fit into int.
697 * buffer.h (struct buffer.modtime): Now time_t, not int.
698 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
699 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
701 Minor fixes for signed vs unsigned integers.
702 * character.h (MAYBE_UNIFY_CHAR):
703 * charset.c (maybe_unify_char):
704 * keyboard.c (read_char, reorder_modifiers):
705 XINT -> XFASTINT, since the integer must be nonnegative.
706 * ftfont.c (ftfont_spec_pattern):
707 * keymap.c (access_keymap, silly_event_symbol_error):
708 XUINT -> XFASTINT, since the integer must be nonnegative.
709 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
710 since it makes no difference and we prefer signed.
711 * keyboard.c (record_char): Use XUINT when all the neighbors do.
712 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
715 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
717 * window.h (Fwindow_frame): Declare.
719 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
721 * alloc.c: Simplify handling of large-request failures (Bug#8800).
722 (SPARE_MEMORY): Always define.
723 (LARGE_REQUEST): Remove.
724 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
726 2011-06-06 Martin Rudalics <rudalics@gmx.at>
728 * lisp.h: Move EXFUNS for Fframe_root_window,
729 Fframe_first_window and Fset_frame_selected_window to window.h.
731 * window.h: Move EXFUNS for Fframe_root_window,
732 Fframe_first_window and Fset_frame_selected_window here from
735 * frame.c (Fwindow_frame, Fframe_first_window)
736 (Fframe_root_window, Fframe_selected_window)
737 (Fset_frame_selected_window): Move to window.c.
738 (Factive_minibuffer_window): Move to minibuf.c.
739 (Fother_visible_frames_p): New function.
741 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
743 * window.c (decode_window, decode_any_window): Move up in code.
744 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
745 (inhibit_frame_unsplittable): Remove unused variable.
746 (Fwindow_buffer): Move up and rewrite doc-string.
747 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
748 (Fwindow_prev): New functions.
749 (Fwindow_frame): Move here from frame.c. Accept any window as
751 (Fframe_root_window, Fframe_first_window)
752 (Fframe_selected_window): Move here from frame.c. Accept frame
753 or arbitrary window as argument. Update doc-strings.
754 (Fminibuffer_window): Move up in code.
755 (Fwindow_minibuffer_p): Move up in code and simplify.
756 (Fset_frame_selected_window): Move here from frame.c.
758 (Fselected_window, select_window, Fselect_window): Move up in
759 code. Minor doc-string fixes.
761 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
763 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
764 Do not assume that spare memory exists; that assumption is valid
765 only if SYSTEM_MALLOC.
766 (LARGE_REQUEST): New macro, so that the issue of large requests
767 is separated from the issue of spare memory.
769 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
771 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
774 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
776 * xfns.c (x_set_scroll_bar_default_width): Move declarations
779 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
781 * gtkutil.c (xg_get_default_scrollbar_width): New function.
783 * gtkutil.h: Declare xg_get_default_scrollbar_width.
785 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
786 min width by calling x_set_scroll_bar_default_width (Bug#8505).
788 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
790 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
792 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
794 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
795 (x_clipboard_manager_save): Add return value.
796 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
798 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
799 Obey Vx_select_enable_clipboard_manager. Catch errors in
800 x_clipboard_manager_save (Bug#8779).
801 (Vx_select_enable_clipboard_manager): New variable.
802 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
804 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
806 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
808 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
810 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
811 in the current matrix if keep_current_p is non-zero.
813 2011-06-04 Eli Zaretskii <eliz@gnu.org>
815 * bidi.c (bidi_level_of_next_char): Fix last change.
817 2011-06-03 Eli Zaretskii <eliz@gnu.org>
819 Support bidi reordering of text covered by display properties.
821 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
822 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
823 (bidi_cache_search, bidi_cache_iterator_state)
824 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
825 (bidi_level_of_next_char, bidi_move_to_visually_next):
826 Support character positions inside a run of characters covered by a
828 (bidi_paragraph_init, bidi_resolve_explicit_1)
829 (bidi_level_of_next_char): Call bidi_fetch_char and
830 bidi_fetch_char_advance instead of FETCH_CHAR and
832 (bidi_init_it): Initialize new members.
833 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
835 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
836 instead of using explicit *_CHAR codes.
837 (bidi_resolve_explicit, bidi_resolve_weak):
838 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
839 bidirectional text is supported only in multibyte buffers.
840 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
841 it to initialize the frame_window_p member of struct bidi_it.
842 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
843 (bidi_resolve_explicit, bidi_resolve_weak)
844 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
845 bidi_it->nchars is non-positive.
846 (bidi_level_of_next_char): Don't try to lookup the cache for the
847 next/previous character if nothing is cached there yet, or if we
848 were just reseat()'ed to a new position.
850 * xdisp.c (set_cursor_from_row): Set start and stop points
851 according to the row's direction when priming the loop that looks
852 for the glyph on which to display cursor.
853 (single_display_spec_intangible_p): Function deleted.
854 (display_prop_intangible_p): Reimplement to call
855 handle_display_spec instead of single_display_spec_intangible_p.
856 Accept 3 additional arguments needed by handle_display_spec.
857 This fixes incorrect cursor motion across display property with complex
858 values: lists, `(when COND...)' forms, etc.
859 (single_display_spec_string_p): Support property values that are
860 lists with the argument STRING its top-level element.
861 (display_prop_string_p): Fix the condition for processing a
862 property that is a list to be consistent with handle_display_spec.
863 (handle_display_spec): New function, refactored from the
864 last portion of handle_display_prop.
865 (compute_display_string_pos): Accept additional argument
866 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
867 value of a `display' property is a "replacing spec".
868 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
869 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
870 the display property, but just return a value indicating whether
871 the display property will replace the characters it covers.
872 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
873 frame_window_p members of struct bidi_it.
874 (compute_display_string_pos, compute_display_string_end):
876 (push_it): Accept second argument POSITION, where pop_it should
877 jump to continue iteration.
878 (reseat_1): Initialize bidi_it.disp_pos.
880 * keyboard.c (adjust_point_for_property): Adjust the call to
881 display_prop_intangible_p to its new signature.
883 * dispextern.h (struct bidi_it): New member frame_window_p.
884 (bidi_init_it): Update prototypes.
885 (display_prop_intangible_p): Update prototype.
886 (compute_display_string_pos, compute_display_string_end):
888 (struct bidi_it): New members nchars and disp_pos. ch_len is now
891 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
893 Malloc failure behavior now depends on size of allocation.
894 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
895 * lisp.h: Change signatures accordingly.
896 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
897 All callers changed. (Bug#8762)
899 * gnutls.c: Use Emacs's memory allocators.
900 Without this change, the gnutls library would invoke malloc etc.
901 directly, which causes problems on non-SYNC_INPUT hosts, and which
902 runs afoul of improving memory_full behavior. (Bug#8761)
903 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
904 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
905 xfree instead of the default malloc, realloc, free.
906 (Fgnutls_boot): No need to check for memory allocation failure,
907 since xmalloc does that for us.
909 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
910 * category.c (hash_get_category_set):
911 * ccl.c (ccl_driver):
912 * charset.c (Fdefine_charset_internal):
913 * charset.h (struct charset.hash_index):
914 * composite.c (get_composition_id, gstring_lookup_cache)
915 (composition_gstring_put_cache):
916 * composite.h (struct composition.hash_index):
917 * dispextern.h (struct image.hash):
918 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
919 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
920 (hashfn_equal, hashfn_user_defined, make_hash_table)
921 (maybe_resize_hash_table, hash_lookup, hash_put)
922 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
923 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
924 (Fsxhash, Fgethash, Fputhash, Fmaphash):
925 * image.c (make_image, search_image_cache, lookup_image)
926 (xpm_put_color_table_h):
927 * lisp.h (struct Lisp_Hash_Table):
928 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
929 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
930 for hashes and hash indexes, instead of 'unsigned' and 'int'.
931 * alloc.c (allocate_vectorlike):
932 Check for overflow in vector size calculations.
933 * ccl.c (ccl_driver):
934 Check for overflow when converting EMACS_INT to int.
935 * fns.c, image.c: Remove unnecessary static decls that would otherwise
936 need to be updated by these changes.
937 * fns.c (make_hash_table, maybe_resize_hash_table):
938 Check for integer overflow with large hash tables.
939 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
940 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
941 (SXHASH_REDUCE): New macro.
942 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
943 Use it instead of discarding useful hash info with large hash values.
944 (sxhash_float): New function.
945 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
946 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
947 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
948 Rewrite to use FIXNUM_BITS, as this simplifies things.
949 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
950 Adjust signatures to match updated version of code.
951 (consing_since_gc): Now EMACS_INT, since a single hash table can
952 use more than INT_MAX bytes.
954 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
956 Make it possible to build with GCC-4.6+ -O2 -flto.
958 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
960 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
962 * minibuf.c (get_minibuffer, read_minibuf_unwind):
963 Call minibuffer-inactive-mode.
965 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
967 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
970 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
972 * data.c (init_data): Remove code for UTS, this system is not
975 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
977 Don't force ./temacs to start in terminal mode.
979 * frame.c (make_initial_frame): Initialize faces in all cases, not
980 only when CANNOT_DUMP is defined.
981 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
983 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
985 * dispnew.c (add_window_display_history): Use const for the string
986 pointer. Remove declaration, not needed.
988 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
990 Use 'inline', not 'INLINE'.
991 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
992 * alloc.c, fontset.c (INLINE): Remove.
993 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
994 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
995 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
996 * gmalloc.c (register_heapinfo): Use inline unconditionally.
997 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
999 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1001 Make it possible to run ./temacs.
1003 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1004 syms_of_callproc does the same thing. Remove test for
1005 "initialized", do it in the caller.
1006 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1008 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1010 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1011 (read_minibuf): Use get_minibuffer.
1012 (syms_of_minibuf): Use DEFSYM.
1013 (Qmetadata): New var.
1014 * data.c (Qbuffer): Don't make it static.
1015 (syms_of_data): Use DEFSYM.
1017 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1019 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1020 (CCL_CODE_MIN): New macro.
1022 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1024 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1026 * eval.c (Qdebug): Now static.
1027 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1028 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1029 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1031 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1033 * image.c: Various fixes to ImageMagick code comments.
1034 (Fimagemagick_types): Doc fix.
1036 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1038 Minor fixes prompted by GCC 4.6.0 warnings.
1040 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1042 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1043 (x_clipboard_manager_save_all): Move extern decl to ...
1044 * xterm.h: ... here, so that it can be checked for consistency.
1046 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1048 * xselect.c (x_clipboard_manager_save_frame)
1049 (x_clipboard_manager_save_all): New functions.
1050 (Fx_clipboard_manager_save): Lisp function deleted.
1052 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1053 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1055 * xterm.h: Update prototype.
1057 2011-05-28 William Xu <william.xwl@gmail.com>
1059 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1062 2011-05-28 Jim Meyering <meyering@redhat.com>
1064 Avoid a sign-extension bug in crypto_hash_function.
1065 * fns.c (to_uchar): Define.
1066 (crypto_hash_function): Use it to convert some newly-signed
1067 variables to unsigned, to avoid sign-extension bugs. For example,
1068 without this change, (md5 "truc") would evaluate to
1069 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1070 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1071 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1073 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1075 Integer overflow fixes.
1077 * dbusbind.c: Serial number integer overflow fixes.
1078 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1079 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1080 to hold a serial number that is too large for a fixnum.
1081 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1082 Check for serial numbers out of range. Decode any serial number
1083 that was so large that it became a float. (Bug#8722)
1085 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1086 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1087 Use XFASTINT rather than XUINT when numbers are nonnegative.
1088 (xd_append_arg, Fdbus_method_return_internal):
1089 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1090 arguments, check that Lisp number is nonnegative, rather than
1091 silently wrapping negative numbers around. (Bug#8722)
1092 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1095 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1097 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1099 ccl: add integer overflow checks
1100 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1101 (IN_INT_RANGE): New macros.
1102 (ccl_driver): Use them to check for integer overflow when
1103 decoding a CCL program. Many of the new checks are whether XINT (x)
1104 fits in int; it doesn't always, on 64-bit hosts. The new version
1105 doesn't catch all possible integer overflows, but it's an
1106 improvement. (Bug#8719)
1108 * alloc.c (make_event_array): Use XINT, not XUINT.
1109 There's no need for unsigned here.
1111 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1112 This follows up to the 2011-05-06 change that substituted uintptr_t
1113 for EMACS_INT. This case wasn't caught back then.
1115 Rework Fformat to avoid integer overflow issues.
1116 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1117 now (part of C89). Include <verify.h>.
1118 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1119 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1120 (Fformat): Avoid the prepass trying to compute sizes; it was only
1121 approximate and thus did not catch overflow reliably. Instead, walk
1122 through the format just once, formatting and computing sizes as we go,
1123 checking for integer overflow at every step, and allocating a larger
1124 buffer as needed. Keep track separately whether the format is
1125 multibyte. Keep only the most-recently calculated precision, rather
1126 than them all. Record whether each argument has been converted to
1127 string. Use EMACS_INT, not int, for byte and char and arg counts.
1128 Support field widths and precisions larger than INT_MAX. Avoid
1129 sprintf's undefined behavior with conversion specifications such as %#d
1130 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1131 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1132 formatting out-of-range floating point numbers with int
1135 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1137 * data.c: Avoid integer truncation in expressions involving floats.
1138 * data.c: Include <intprops.h>.
1139 (arith_driver): When there's an integer overflow in an expression
1140 involving floating point, convert the integers to floating point
1141 so that the resulting value does not suffer from catastrophic
1142 integer truncation. For example, on a 64-bit host (* 4
1143 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1144 Do not rely on undefined behavior after integer overflow.
1146 merge count_size_as_multibyte, parse_str_to_multibyte
1147 * character.c, character.h (count_size_as_multibyte):
1148 Rename from parse_str_to_multibyte; all uses changed.
1149 Check for integer overflow.
1150 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1151 since it's now a duplicate of the other. This is more of
1152 a character than a buffer op, so better that it's in character.c.
1153 * fns.c, print.c: Adjust to above changes.
1155 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1157 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1159 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1161 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1162 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1163 (x_clipboard_manager_save): Now static.
1164 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1166 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1167 (crypto_hash_function): Now static.
1168 Fix pointer signedness problems. Avoid unnecessary initializations.
1170 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1172 * termhooks.h (Vselection_alist): Make it terminal-local.
1174 * terminal.c (create_terminal): Initialize it.
1176 * xselect.c: Support for clipboard managers.
1177 (Vselection_alist): Move to termhooks.h as terminal-local var.
1178 (LOCAL_SELECTION): New macro.
1179 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1180 (symbol_to_x_atom): Remove gratuitous arg.
1181 (x_handle_selection_request, lisp_data_to_selection_data)
1182 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1183 (x_own_selection, x_get_local_selection, x_convert_selection):
1184 New arg, specifying work frame. Use terminal-local Vselection_alist.
1185 (some_frame_on_display): Delete unused function.
1186 (Fx_own_selection_internal, Fx_get_selection_internal)
1187 (Fx_disown_selection_internal, Fx_selection_owner_p)
1188 (Fx_selection_exists_p): New optional frame arg.
1189 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1190 (x_handle_selection_clear): Don't treat other terminals with the
1191 same keyboard specially. Use the terminal-local Vselection_alist.
1192 (x_clear_frame_selections): Use Frun_hook_with_args.
1194 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1196 * xterm.h: Add support for those atoms.
1198 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1200 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1201 (converted_selections, conversion_fail_tag): New global variables.
1202 (x_selection_request_lisp_error): Free the above.
1203 (x_get_local_selection): Remove unnecessary code.
1204 (x_reply_selection_request): Args changed; handle arbitrary array
1205 of converted selections stored in converted_selections.
1206 Separate the XChangeProperty and SelectionNotify steps.
1207 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1208 (x_convert_selection): New function.
1209 (x_handle_selection_event): Simplify.
1210 (x_get_foreign_selection): Don't ignore incoming requests while
1211 waiting for an answer; this will fail when we implement
1212 SAVE_TARGETS, and seems unnecessary anyway.
1213 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1214 (Vx_sent_selection_functions): Doc fix.
1216 2011-05-26 Leo Liu <sdl.web@gmail.com>
1218 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1220 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1222 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1224 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1225 for fringe update if it has periodic bitmap.
1226 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1227 and fringe_bitmap_periodic_p.
1229 * fringe.c (get_fringe_bitmap_data): New function.
1230 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1231 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1232 row. Mark glyph row for fringe update if periodicity changed.
1234 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1235 for fringe update unless it has periodic bitmap.
1237 2011-05-25 Kenichi Handa <handa@m17n.org>
1239 * xdisp.c (get_next_display_element): Set correct it->face_id for
1240 a static composition.
1242 2011-05-24 Leo Liu <sdl.web@gmail.com>
1245 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1247 * fns.c (crypto_hash_function, Fsha1): New function.
1248 (Fmd5): Use crypto_hash_function.
1249 (syms_of_fns): Add Ssha1.
1251 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1253 * gnutls.c: Remove unused macros.
1254 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1255 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1256 Remove macros that are defined and never used.
1257 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1259 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1261 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1262 (Fx_get_selection_internal): Minor cleanup.
1263 (Fx_own_selection_internal): Rename arguments for consistency with
1266 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1268 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1270 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1272 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1274 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1276 * dispnew.c (scrolling_window): Don't exclude the case that the
1277 last enabled row in the desired matrix touches the bottom boundary.
1279 2011-05-21 Glenn Morris <rgm@gnu.org>
1281 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1282 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1283 and add some more files.
1285 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1287 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1288 report_file_error introduced by the change from 2011-05-07.
1290 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1292 * systime.h (Time): Define only if emacs is defined.
1293 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1294 where the include path doesn't have X11/X.h by default. See
1295 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1297 2011-05-20 Kenichi Handa <handa@m17n.org>
1299 * composite.c (find_automatic_composition): Fix previous change.
1301 2011-05-20 Glenn Morris <rgm@gnu.org>
1303 * lisp.mk: New file, split from Makefile.in.
1304 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1305 (shortlisp): Remove.
1306 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1308 2011-05-19 Glenn Morris <rgm@gnu.org>
1310 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1311 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1312 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1313 (lisp): Set the order to that of loadup.el.
1314 (shortlisp): Make it a copy of $lisp.
1315 (SOME_MACHINE_LISP): Remove.
1316 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1317 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1319 2011-05-18 Kenichi Handa <handa@m17n.org>
1321 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1322 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1323 (find_automatic_composition): Mostly rewrite for efficiency.
1325 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1327 * makefile.w32-in: Update dependencies.
1329 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1331 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1334 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1336 Fix some integer overflow issues, such as string length overflow.
1338 * insdel.c (count_size_as_multibyte): Check for string overflow.
1340 * character.c (lisp_string_width): Check for string overflow.
1341 Use EMACS_INT, not int, for string indexes and lengths; in
1342 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1343 the resulting string length overflows an EMACS_INT; instead,
1344 report a string overflow if no precision given. When checking for
1345 precision exhaustion, use a check that cannot possibly have
1346 integer overflow. (Bug#8675)
1347 * character.h (lisp_string_width): Adjust to new signature.
1349 * alloc.c (string_overflow): New function.
1350 (Fmake_string): Use it. This doesn't change behavior, but saves
1351 a few bytes and will simplify future changes.
1352 * character.c (string_escape_byte8): Likewise.
1353 * lisp.h (string_overflow): New decl.
1355 Fixups, following up to the user-interface timestamp change.
1356 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1357 for UI timestamps, instead of unsigned long.
1358 * msdos.c (mouse_get_pos): Likewise.
1359 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1360 * w32gui.h (Time): Define by including "systime.h" rather than by
1361 declaring it ourselves. (Bug#8664)
1363 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1364 * image.c (clear_image_cache): Likewise.
1366 * term.c (term_mouse_position): Don't assume time_t wraparound.
1368 Be more systematic about user-interface timestamps.
1369 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1370 and sometimes 'EMACS_UINT', to represent these timestamps.
1371 This change causes it to use 'Time' uniformly, as that's what X uses.
1372 This makes the code easier to follow, and makes it easier to catch
1373 integer overflow bugs such as Bug#8664.
1374 * frame.c (Fmouse_position, Fmouse_pixel_position):
1375 Use Time, not unsigned long, for user-interface timestamps.
1376 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1377 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1378 * keyboard.h (last_event_timestamp): Likewise.
1379 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1380 * menu.h (xmenu_show): Likewise.
1381 * term.c (term_mouse_position): Likewise.
1382 * termhooks.h (struct input_event.timestamp): Likewise.
1383 (struct terminal.mouse_position_hook): Likewise.
1384 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1385 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1386 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1387 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1389 * menu.h, termhooks.h: Include "systime.h", for Time.
1391 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1392 Don't assume that the difference between two unsigned long values
1393 can fit into an integer. At this point, we know button_down_time
1394 <= event->timestamp, so the difference must be nonnegative, so
1395 there's no need to cast the result if double-click-time is
1396 nonnegative, as it should be; check that it's nonnegative, just in
1397 case. This bug is triggered when events are more than 2**31 ms
1398 apart (about 25 days). (Bug#8664)
1400 * xselect.c (last_event_timestamp): Remove duplicate decl.
1401 (x_own_selection): Remove needless cast to unsigned long.
1403 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1404 that always fit in int. Use a sentinel instead of a counter, to
1405 avoid a temp and to allay GCC's concerns about possible int overflow.
1406 * frame.h (struct frame): Use int for menu_bar_items_used
1407 instead of EMACS_INT, since it always fits in int.
1409 * menu.c (grow_menu_items): Check for int overflow.
1411 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1413 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1414 Before, the code was not consistent. These values cannot exceed
1415 2**31 - 1 so there's no need to make them unsigned.
1416 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1417 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1418 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1420 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1422 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1423 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1424 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1425 presumably because the widths might not match.
1427 * window.c (size_window): Avoid needless test at loop start.
1429 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1431 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1433 2011-05-12 Drew Adams <drew.adams@oracle.com>
1435 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1437 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1439 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1440 `width' to `bar_area_x' and `bar_area_width', respectively.
1441 (x_scroll_run): Take account of fringe background extension.
1443 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1444 Rename local vars `left' and `width' to `bar_area_x' and
1445 `bar_area_width', respectively.
1446 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1447 background extension.
1449 2011-05-10 Jim Meyering <meyering@redhat.com>
1451 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1453 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1455 * image.c (Finit_image_library): Return t for built-in image types,
1456 like pbm and xbm. (Bug#8640)
1458 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1460 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1462 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1464 * w32console.c (Fset_screen_color): Doc fix.
1465 (Fget_screen_color): New function.
1466 (syms_of_ntterm): Defsubr it.
1468 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1469 unlink the temporary file if Fcall_process didn't create it in the
1471 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1472 child process will be redirected to a file specified with `:file'.
1473 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1474 cue to call_process_cleanup not to close that handle.
1476 2011-05-07 Ben Key <bkey76@gmail.com>
1478 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1479 one of two shell specific rules, either bootstrap-temacs-CMD or
1480 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1481 to the previous implementation of the bootstrap-temacs rule.
1482 The bootstrap-temacs-CMD rule is similar to the previous
1483 implementation of the bootstrap-temacs rule except that it
1484 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1487 These changes, along with some changes to nt/configure.bat,
1488 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1489 earlier fix to add support for --cflags and --ldflags options
1490 that include quotes so that it works whether make uses cmd or
1493 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1495 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1496 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1498 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1499 a string. Handle both cases.
1500 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1501 (Fdbus_register_method): Use Qinvalid_function.
1503 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1505 * makefile.w32-in: Update dependencies.
1506 (LISP_H): Add inttypes.h and stdin.h.
1507 (PROCESS_H): Add unistd.h.
1509 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1511 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1512 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1514 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1516 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1518 * term.c (vfatal): Remove stray call to va_end.
1519 It's not needed and the C Standard doesn't allow it here anyway.
1521 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1522 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1524 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1527 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1529 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1531 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1533 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1535 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1537 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1538 * charset.c (Fdefine_charset_internal): Don't initialize
1539 charset.code_space[15]. The value was garbage, on hosts with
1540 32-bit int (Bug#8600).
1542 * lread.c (read_integer): Be more consistent with string-to-number.
1543 Use string_to_number to do the actual conversion; this avoids
1544 rounding errors and fixes some other screwups. Without this fix,
1545 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1546 (digit_to_number): Move earlier, for benefit of read_integer.
1547 Return -1 if the digit is out of range for the base, -2 if it is
1548 not a digit in any supported base. (Bug#8602)
1550 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1552 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1553 to match comment at start of function. This also removes a
1554 GCC warning about overflow in a 32+64-bit port.
1556 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1558 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1559 Reported by Stefan Monnier in
1560 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1561 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1562 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1564 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1565 (EMACS_UINTPTR): Likewise, with uintptr_t.
1567 * lisp.h: Prefer 64-bit EMACS_INT if available.
1568 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1569 on 32-bit hosts that have 64-bit int, so that they can access
1571 However, temporarily disable this change unless the temporary
1572 symbol WIDE_EMACS_INT is defined.
1574 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1576 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1577 This removes an assumption that EMACS_INT and long are the same
1578 width as pointers. The assumption is true for Emacs porting targets
1579 now, but we want to make other targets possible.
1580 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1581 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1582 In the rest of the code, change types of integers that hold casted
1583 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1584 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1585 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1586 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1587 No need to cast type when ORing.
1588 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1589 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1590 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1591 assume EMACS_INT is the same width as char *.
1592 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1593 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1594 Remove no-longer-needed casts.
1595 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1596 (xg_tool_bar_help_callback, xg_make_tool_item):
1597 Use EMACS_INTPTR to hold an integer
1598 that will be cast to void *; this can avoid a GCC warning
1599 if EMACS_INT is not the same width as void *.
1600 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1601 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1602 (current_message_1, set_message_1):
1603 Use a local to convert to proper width without a cast.
1604 * xmenu.c (dialog_selection_callback): Likewise.
1606 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1607 Also, don't assume VALBITS / RAND_BITS is less than 5,
1608 and don't rely on undefined behavior when shifting a 1 left into
1610 * lisp.h (get_random): Change signature to match.
1612 * lread.c (hash_string): Use size_t, not int, for hash computation.
1613 Normally we prefer signed values; but hashing is special, because
1614 it's better to use unsigned division on hash table sizes so that
1615 the remainder is nonnegative. Also, size_t is the natural width
1616 for hashing into memory. The previous code used 'int', which doesn't
1617 retain enough info to hash well into very large tables.
1618 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1620 * dbusbind.c: Don't possibly lose pointer info when converting.
1621 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1622 Use XPNTR rather than XHASH, so that the high-order bits of
1623 the pointer aren't lost when converting through void *.
1625 * eval.c (Fautoload): Don't double-shift a pointer.
1627 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1629 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1631 * gnutls.c (DEF_GNUTLS_FN):
1632 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1634 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1636 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1639 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1641 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1642 New version that can reserve upto 2GB of heap space.
1644 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1646 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1648 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1650 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1651 `gnutls_certificate_set_x509_key_file'.
1653 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1655 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1656 Update dependencies.
1658 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1660 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1661 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1662 Remove unused parameter `fildes'.
1663 * process.c (read_process_output, send_process): Don't pass it.
1665 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1667 Fix previous change: the library cache is defined in w32.c.
1668 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1669 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1671 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1673 Implement dynamic loading of GnuTLS on Windows.
1675 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1676 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1677 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1680 * gnutls.c (Qgnutls_dll): Define.
1681 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1682 (gnutls_*): Declare function pointers.
1683 (init_gnutls_functions): New function to initialize function pointers.
1684 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1685 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1686 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1687 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1688 (emacs_gnutls_write, emacs_gnutls_read)
1689 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1690 (Fgnutls_available_p): New function.
1691 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1692 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1693 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1695 * image.c: Include w32.h.
1696 (Vimage_type_cache): Delete.
1697 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1698 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1699 (w32_delayed_load): Move to w32.c.
1701 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1703 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1704 (w32_delayed_load): Move from image.c. When loading a library, record
1705 its filename in the :loaded-from property of the library id.
1706 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1707 Initialize and staticpro them.
1708 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1710 * process.c: Include lisp.h before w32.h, not after.
1711 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1712 instead of gnutls_record_check_pending.
1714 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1716 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1718 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1719 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1722 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1724 * xterm.c (x_set_frame_alpha): Do not set property on anything
1725 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1727 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1729 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1731 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1733 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1734 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1735 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1736 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1737 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1738 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1739 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1740 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1741 (Qgnutls_bootprop_callbacks_verify): Make static.
1743 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1745 * callproc.c: Indentation fixup.
1747 * sysdep.c (wait_for_termination_1): Make static.
1748 (wait_for_termination, interruptible_wait_for_termination):
1749 Move after wait_for_termination_1.
1751 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753 * sysdep.c (interruptible_wait_for_termination): New function
1754 which is like wait_for_termination, but allows keyboard
1757 * callproc.c (Fcall_process): Add (:file "file") as an option for
1759 (Fcall_process_region): Ditto.
1761 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1763 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1764 rather than `XVECTOR (FOO)->size'.
1766 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1767 inttypes.h, as a gnulib replacement is used if it not available in
1770 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1772 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1773 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1774 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1776 * coding.c (coding_alloc_by_realloc): Error out if destination
1777 will grow beyond MOST_POSITIVE_FIXNUM.
1778 (decode_coding_emacs_mule): Abort if there isn't enough place in
1779 charbuf for the composition carryover bytes. Reserve an extra
1780 space for up to 2 characters produced in a loop.
1781 (decode_coding_iso_2022): Abort if there isn't enough place in
1782 charbuf for the composition carryover bytes.
1784 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1786 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1787 aborting when %lld or %lll format is passed.
1788 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1789 %llo or %llx format is passed. (Bug#8545)
1791 * window.c (window_scroll_line_based): Use a marker instead of
1792 simple variables to record original value of point. (Bug#7952)
1794 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1795 produced by %s or %c overflows available buffer space. (Bug#8545)
1797 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1799 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1800 (SIZE_MAX): Move defn after all includes, as they might #define it.
1802 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1804 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1806 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1808 * keyboard.c (Qdelayed_warnings_hook): Define.
1809 (command_loop_1): Run `delayed-warnings-hook'
1810 if Vdelayed_warnings_list is non-nil.
1811 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1812 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1814 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1816 * doprnt.c (doprnt): Don't return value smaller than the buffer
1817 size if the message was truncated. (Bug#8545).
1819 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1821 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1822 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1824 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1826 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1828 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1830 * makefile.w32-in: Update dependencies.
1832 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1834 Improve `doprnt' and its usage. (Bug#8545)
1835 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1836 `format_end'. Remove support for %l as a conversion specifier.
1837 Don't use xrealloc. Improve diagnostics when the %l size modifier
1838 is used. Update the commentary.
1840 * eval.c (verror): Simplify calculation of size_t.
1842 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1845 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1847 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1850 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1852 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1853 This makes this file independent of the recent pseudovector change.
1855 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1857 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1859 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1860 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1861 Remove unused local.
1862 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1864 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1865 GCC 4.6.0 optimizes based on type-based alias analysis.
1866 For example, if b is of type struct buffer * and v of type struct
1867 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1868 != &v->size, and therefore "v->size = 1; b->size = 2; return
1869 v->size;" must therefore return 1. This assumption is incorrect
1870 for Emacs, since it type-puns struct Lisp_Vector * with many other
1871 types. To fix this problem, this patch adds a new type struct
1872 vectorlike_header that documents the constraints on layout of vectors
1873 and pseudovectors, and helps optimizing compilers not get fooled
1874 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1875 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1876 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1878 (XSETPVECTYPE): Rewrite in terms of new macro.
1879 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1880 This is a bit clearer, and further avoids the possibility of
1881 undesirable aliasing.
1882 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1883 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1884 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1885 since Lisp_Subr is a special case (no "next" field).
1886 (ASIZE): Now uses header.size rather than size.
1887 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1888 to avoid the hassle of writing XVECTOR (foo)->header.size.
1889 (struct vectorlike_header): New type.
1890 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1891 object, to help avoid aliasing.
1892 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1893 (SUBRP): Likewise, since Lisp_Subr is a special case.
1894 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1895 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1896 (struct Lisp_Hash_Table): Combine first two members into a single
1897 struct vectorlike_header member. All uses of "size" and "next" members
1898 changed to be "header.size" and "header.next".
1899 * buffer.h (struct buffer): Likewise.
1900 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1901 * frame.h (struct frame): Likewise.
1902 * process.h (struct Lisp_Process): Likewise.
1903 * termhooks.h (struct terminal): Likewise.
1904 * window.c (struct save_window_data, struct saved_window): Likewise.
1905 * window.h (struct window): Likewise.
1906 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1907 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1908 * buffer.c (init_buffer_once): Likewise.
1909 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1911 * process.c (Fformat_network_address): Use local var for size,
1914 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1916 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1917 * data.c (atof): Remove decl; no longer used or needed.
1918 (digit_to_number): Move to lread.c.
1919 (Fstring_to_number): Use new string_to_number function, to be
1920 consistent with how the Lisp reader treats infinities and NaNs.
1921 Do not assume that floating-point numbers represent EMACS_INT
1922 without losing information; this is not true on most 64-bit hosts.
1923 Avoid double-rounding errors, by insisting on integers when
1924 parsing non-base-10 numbers, as the documentation specifies.
1925 * lisp.h (string_to_number): New decl, replacing ...
1926 (isfloat_string): Remove.
1927 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1928 (read1): Do not accept +. and -. as integers; this
1929 appears to have been a coding error. Similarly, do not accept
1930 strings like +-1e0 as floating point numbers. Do not report
1931 overflow for integer overflows unless the base is not 10 which
1932 means we have no simple and reliable way to continue.
1933 Break out the floating-point parsing into a new
1934 function string_to_number, so that Fstring_to_number parses
1935 floating point numbers consistently with the Lisp reader.
1936 (digit_to_number): Move here from data.c. Make it static inline.
1937 (E_CHAR, EXP_INT): Remove, replacing with ...
1938 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1939 (string_to_number): New function, replacing isfloat_string.
1940 This function checks for valid syntax and produces the resulting
1941 Lisp float number too. Rework it so that string-to-number
1942 no longer mishandles examples like "1.0e+". Use strtoumax,
1943 so that overflow for non-base-10 numbers is reported only when
1944 there's no portable and simple way to convert to floating point.
1946 * textprop.c (set_text_properties_1): Rewrite for clarity,
1947 and to avoid GCC warning about integer overflow.
1949 * intervals.h (struct interval): Use EMACS_INT for members
1950 where EMACS_UINT might cause problems. See
1951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1952 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1953 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1955 (offset_intervals): Tell GCC not to worry about length overflow
1956 when negating a negative length.
1958 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1959 (overrun_check_free): Likewise.
1961 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1962 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1965 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1966 (gnutls_make_error): Rename local to avoid shadowing.
1967 (gnutls_emacs_global_deinit): ifdef out; not used.
1968 (Fgnutls_boot): Use const for pointer to readonly storage.
1969 Comment out unused local. Fix pointer signedness problems.
1971 * lread.c (openp): Don't stuff size_t into an 'int'.
1972 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1973 about possible signed overflow.
1975 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1976 (GDK_KEY_g): Don't define if already defined.
1977 (xg_prepare_tooltip): Avoid pointer signedness problem.
1978 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1980 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1981 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1983 * xfns.c (Fx_window_property): Simplify a bit,
1984 to make a bit faster and to avoid GCC 4.6.0 warning.
1985 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1987 * fns.c (internal_equal): Don't assume size_t fits in int.
1989 * alloc.c (compact_small_strings): Tighten assertion a little.
1991 Replace pEd with more-general pI, and fix some printf arg casts.
1992 * lisp.h (pI): New macro, generalizing old pEd macro to other
1993 conversion specifiers. For example, use "...%"pI"d..." rather
1994 than "...%"pEd"...".
1995 (pEd): Remove. All uses replaced with similar uses of pI.
1996 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1997 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1998 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1999 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2000 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2001 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2002 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2004 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2005 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2006 * print.c (safe_debug_print, print_object): Likewise.
2007 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2009 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2010 avoiding the 0 flag, which is not portable.
2011 * process.c (Fmake_network_process): Use pI to avoid cast.
2012 * region-cache.c (pp_cache): Likewise.
2013 * xdisp.c (decode_mode_spec): Likewise.
2014 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2015 behavior on 64-bit hosts with printf arg.
2016 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2017 (x_stop_queuing_selection_requests): Likewise.
2018 (x_get_window_property): Don't truncate byte count to an 'int'
2021 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2022 here, since it parses constructs like leading '-' and spaces,
2023 which are not wanted; and it overflows with large numbers.
2024 Instead, simply match F[0-9]+, which is what is wanted anyway.
2026 * alloc.c: Remove unportable assumptions about struct layout.
2027 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2028 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2029 (allocate_vectorlike, make_pure_vector): Use the new macros,
2030 plus offsetof, to remove unportable assumptions about struct layout.
2031 These assumptions hold on all porting targets that I know of, but
2032 they are not guaranteed, they're easy to remove, and removing them
2033 makes further changes easier.
2035 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2036 This doesn't fix a bug but makes the code clearer.
2037 (string_overrun_cookie): Now const. Use initializers that
2038 don't formally overflow signed char, to avoid warnings.
2039 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2040 can cause Emacs to crash when string overrun checking is enabled.
2041 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2042 multiple of sizeof (EMACS_INT); it need not be, if
2043 alignof(EMACS_INT) < sizeof (EMACS_INT).
2044 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2046 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2048 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2050 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2052 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2053 supposed to be handshaking. (Bug#8556)
2054 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2056 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2058 * lisp.h (Qdebug): List symbol.
2059 * eval.c (Qdebug): Restore global linkage.
2060 * keyboard.c (debug-on-event): New variable.
2061 (handle_user_signal): Break into debugger when debug-on-event
2062 matches the current signal symbol.
2064 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2066 * alloc.c (check_sblock, check_string_bytes)
2067 (check_string_free_list): Convert to standard C.
2069 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2071 * w32.c (emacs_gnutls_push): Fix typo.
2073 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2075 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2076 "cast to pointer from integer of different size".
2078 Improve doprnt and its use in verror. (Bug#8545)
2079 * doprnt.c (doprnt): Document the set of format control sequences
2080 supported by the function. Use SAFE_ALLOCA instead of always
2083 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2084 is one byte too soon. Don't use xrealloc; instead xfree and
2087 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2089 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2092 * gnutls.c: Renamed global_initialized to
2093 gnutls_global_initialized. Added internals for the
2094 :verify-hostname-error, :verify-error, and :verify-flags
2095 parameters of `gnutls-boot' and documented those parameters in the
2096 docstring. Start callback support.
2097 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2098 unless a fatal error occured. Call gnutls_alert_send_appropriate
2099 on error. Return error code.
2100 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2101 (emacs_gnutls_read): Likewise.
2102 (Fgnutls_boot): Return handshake error code.
2103 (emacs_gnutls_handle_error): New function.
2104 (wsaerror_to_errno): Likewise.
2106 * w32.h (emacs_gnutls_pull): Add prototype.
2107 (emacs_gnutls_push): Likewise.
2109 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2110 (emacs_gnutls_push): Likewise.
2112 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2114 * process.c (wait_reading_process_output): Check if GnuTLS
2115 buffered some data internally if no FDs are set for TLS
2118 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2119 (LIBS): Link to USER_LIBS.
2120 ($(BLD)/gnutls.$(0)): New target.
2122 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2124 * xdisp.c (handle_single_display_spec): Rename the
2125 display_replaced_before_p argument into display_replaced_p, to
2126 make it consistent with the commentary. Fix typos in the
2129 * textprop.c (syms_of_textprop): Remove dead code.
2130 (copy_text_properties): Delete obsolete commentary about an
2131 interface that was deleted long ago. Fix typos in the description
2134 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2135 to changes in oldXMenu/XMenu.h from 2011-04-16.
2136 <menu_help_message, prev_menu_help_message>: Constify.
2137 (IT_menu_make_room): menu->help_text is now `const char **';
2140 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2141 to changes in oldXMenu/XMenu.h from 2011-04-16.
2142 (struct XMenu): Declare `help_text' `const char **'.
2144 * xfaces.c <Qunspecified>: Make extern again.
2146 * syntax.c: Include sys/types.h before including regex.h, as
2149 * doc.c (get_doc_string): Improve the format passed to `error'.
2151 * doprnt.c (doprnt): Improve commentary.
2153 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2155 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2158 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2159 changes in globals.h immediately force recompilation.
2160 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2161 $(CURDIR)/s/ms-w32.h.
2162 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2164 * character.c (Fchar_direction): Function deleted.
2165 (syms_of_character): Don't defsubr it.
2166 <char-direction-table>: Deleted.
2168 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2170 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2171 * doprnt.c: Include limits.h.
2172 (SIZE_MAX): New macro.
2173 (doprnt): Return a size_t value. 2nd arg is now size_t.
2174 Many local variables are now size_t instead of int or unsigned.
2175 Improve overflow protection. Support `l' modifier for integer
2176 conversions. Support %l conversion. Don't assume an EMACS_INT
2177 argument for integer conversions and for %c.
2179 * lisp.h (doprnt): Restore prototype.
2181 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2184 * Makefile.in (base_obj): Add back doprnt.o.
2186 * deps.mk (doprnt.o): Add back prerequisites.
2187 (callint.o): Depend on character.h.
2189 * eval.c (internal_lisp_condition_case): Include the handler
2190 representation in the error message.
2191 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2192 when breaking from the loop.
2194 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2196 * callint.c (Fcall_interactively): When displaying error message
2197 about invalid control letter, pass the character's codepoint, not
2198 a pointer to its multibyte form. Improve display of the character
2199 in octal and display also its hex code.
2201 * character.c (char_string): Use %x to display the (unsigned)
2202 codepoint of an invalid character, to avoid displaying a bogus
2205 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2206 `error', not SYMBOL_NAME itself.
2208 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2209 character arguments to `error'.
2211 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2212 to `error' in error message about FINAL_CHAR argument. Make sure
2213 FINAL_CHAR is a character, and use %c when it is passed as
2214 argument to `error'.
2216 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2218 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2220 * w32.c: Include <time.h>.
2221 (sys_localtime): New function.
2223 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2225 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2227 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2229 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2231 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2234 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2236 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2237 gl_state.e_property when gl_state.object is Qt.
2239 * insdel.c (make_gap_larger): Remove limitation of buffer size
2242 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2244 * xdisp.c (lookup_glyphless_char_display)
2245 (produce_glyphless_glyph): Handle cons cell entry in
2246 glyphless-char-display.
2247 (Vglyphless_char_display): Document it.
2249 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2250 glyphless-char-display.
2252 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2254 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2256 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2258 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2259 definition for no-X builds.
2261 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2263 Static checks with GCC 4.6.0 and non-default toolkits.
2265 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2267 * process.c (keyboard_bit_set): Define only if SIGIO.
2268 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2269 (send_process): Repair possible setjmp clobbering.
2271 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2273 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2275 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2277 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2278 Define only if needed.
2280 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2281 by pacifying GCC about it. Maybe it's time to retire it?
2282 * xfaces.c (USG, __TIMEVAL__): Likewise.
2284 * dispextern.h (struct redisplay_interface): Rename param
2286 * termhooks.h (struct terminal): Likewise.
2287 * xterm.c (xembed_send_message): Likewise.
2289 * insdel.c (make_gap_smaller): Define only if
2290 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2292 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2295 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2296 so that we aren't warned about unused symbols.
2298 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2300 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2302 * xfns.c (x_real_positions): Mark locals as initialized.
2304 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2306 * xterm.c: Fix problems found by static analysis with other toolkits.
2307 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2308 (x_dispatch_event): Declare static if USE_GTK, and
2309 define if USE_GTK || USE_X_TOOLKIT.
2310 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2311 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2312 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2313 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2315 * xmenu.c (menu_help_callback): Pointer type fixes.
2316 Use const pointers when pointing at readonly data. Avoid pointer
2318 (FALSE): Remove unused macro.
2319 (update_frame_menubar): Remove unused decl.
2321 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2323 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2324 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2325 (single_menu_item): Rename local to avoid shadowing.
2327 * keyboard.c (make_lispy_event): Remove unused local var.
2329 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2330 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2332 * bitmaps: Change bitmaps from unsigned char back to the X11
2333 compatible char. Avoid the old compiler warnings about
2334 out-of-range initializers by using, for example, '\xab' rather
2337 * xgselect.c (xgselect_initialize): Check vs interface
2338 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2340 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2342 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2343 to read-only memory.
2345 * fns.c (vector): Remove; this old hack is no longer needed.
2347 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2349 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2351 * xrdb.c (x_load_resources): Omit unused local.
2353 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2354 (x_window): Rename locals to avoid shadowing.
2355 (USG): Use the kludged USG macro, to pacify gcc.
2357 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2358 (x_term_init): Remove local to avoid shadowing.
2360 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2362 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2363 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2365 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2367 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2369 Fix regex.c, syntax.c and friends for buffers > 2GB.
2370 * syntax.h (struct gl_state_s): Declare character position members
2373 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2375 * textprop.c (verify_interval_modification, interval_of):
2376 Declare arguments EMACS_INT.
2378 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2381 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2383 * indent.c (Fvertical_motion): Local variable it_start is now
2386 * regex.c (re_match, re_match_2, re_match_2_internal)
2387 (bcmp_translate, regcomp, regexec, print_double_string)
2388 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2389 (re_compile_pattern, re_exec): Declare arguments and local
2390 variables `size_t' and `ssize_t' and return values `regoff_t', as
2392 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2393 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2394 <compile_stack_type>: `size' and `avail' are now `size_t'.
2396 * regex.h <regoff_t>: Use ssize_t, not int.
2397 (re_search, re_search_2, re_match, re_match_2): Arguments that
2398 specify buffer/string position and length are now ssize_t and
2399 size_t. Return type is regoff_t.
2401 2011-04-16 Ben Key <bkey76@gmail.com>
2403 * nsfont.m: Fixed bugs in ns_get_family and
2404 ns_descriptor_to_entity that were caused by using free to
2405 deallocate memory blocks that were allocated by xmalloc (via
2406 xstrdup). This caused Emacs to crash when compiled with
2407 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2408 --enable-checking=xmallocoverrun). xfree is now used to
2409 deallocate these memory blocks.
2411 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2413 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2415 emacs_write: Accept and return EMACS_INT for sizes.
2416 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2418 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2419 Accept and return EMACS_INT.
2420 (emacs_gnutls_write): Return the number of bytes written on
2422 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2423 (emacs_read, emacs_write): Remove check for negative size, as the
2424 Emacs source code has been audited now.
2425 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2426 (emacs_read, emacs_write): Use it.
2427 * process.c (send_process): Adjust to the new signatures of
2428 emacs_write and emacs_gnutls_write. Do not attempt to store
2429 a byte offset into an 'int'; it might overflow.
2430 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2432 * sound.c: Don't assume sizes fit in 'int'.
2433 (struct sound_device.period_size, alsa_period_size):
2434 Return EMACS_INT, not int.
2435 (struct sound_device.write, vox_write, alsa_write):
2436 Accept EMACS_INT, not int.
2437 (wav_play, au_play): Use EMACS_INT to store sizes and to
2438 record read return values.
2440 2011-04-15 Ben Key <bkey76@gmail.com>
2442 * keyboard.c (Qundefined): Don't declare static since it is used
2444 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2445 static since they are used in nsfont.m.
2447 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2449 * process.c (Qprocessp): Don't declare static.
2450 * lisp.h (Qprocessp): Declare again.
2452 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2454 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2456 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2458 Improve C-level modularity by making more things 'static'.
2460 Don't publish debugger-only interfaces to other modules.
2461 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2462 (verify_bytepos, count_markers): Move decls to the only modules
2464 * region-cache.h (pp_cache): Likewise.
2465 * window.h (check_all_windows): Likewise.
2466 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2468 * sysdep.c (croak): Now static, if
2469 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2470 * syssignal.h (croak): Declare only if not static.
2472 * alloc.c (refill_memory_reserve): Now static if
2473 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2474 * lisp.h (refill_memory_reserve): Declare only if not static.
2476 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2477 Define only if USE_LUCID.
2479 * xrdb.c (x_customization_string, x_rm_string): Now static.
2481 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2482 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2484 * xdisp.c (draw_row_with_mouse_face): Now static.
2485 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2487 * window.h (check_all_windows): Mark externally visible.
2489 * window.c (window_deletion_count): Now static.
2491 * undo.c: Make symbols static if they're not exported.
2492 (last_undo_buffer, last_boundary_position, pending_boundary):
2495 * textprop.c (interval_insert_behind_hooks): Now static.
2496 (interval_insert_in_front_hooks): Likewise.
2498 * term.c: Make symbols static if they're not exported.
2499 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2500 (max_frame_lines, tty_set_terminal_modes):
2501 (tty_reset_terminal_modes, tty_turn_off_highlight):
2502 (get_tty_terminal): Now static.
2503 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2504 * termhooks.h (term_mouse_moveto): Do not declare if
2506 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2507 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2509 * sysdep.c: Make symbols static if they're not exported.
2510 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2512 (sigprocmask_set, full_mask): Remove; unused.
2513 (wait_debugging): Mark as visible.
2514 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2515 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2517 * syntax.c (syntax_temp): Define only if !__GNUC__.
2519 * sound.c (current_sound_device, current_sound): Now static.
2521 * search.c (searchbufs, searchbuf_head): Now static.
2523 * scroll.c (scroll_cost): Remove; unused.
2524 * dispextern.h (scroll_cost): Remove decl.
2526 * region-cache.h (pp_cache): Mark as externally visible.
2528 * process.c: Make symbols static if they're not exported.
2529 (process_tick, update_tick, create_process, chan_process):
2530 (Vprocess_alist, proc_buffered_char, datagram_access):
2531 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2532 (deactivate_process): Mark defn as static, as well as decl.
2533 * lisp.h (create_process): Remove decl.
2534 * process.h (chan_process, Vprocess_alist): Remove decls.
2536 * print.c: Make symbols static if they're not exported.
2537 (print_depth, new_backquote_output, being_printed, print_buffer):
2538 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2539 (print_interval, print_number_index, initial_stderr_stream):
2541 * lisp.h (Fprinc): Remove decl.
2542 (debug_output_compilation_hack): Mark as externally visible.
2544 * sysdep.c (croak): Move decl from here to syssignal.h.
2545 * syssignal.h (croak): Put it here, so the API can be checked when
2546 'croak' is called from dissociate_if_controlling_tty.
2548 * minibuf.c: Make symbols static if they're not exported.
2549 (minibuf_save_list, choose_minibuf_frame): Now static.
2550 * lisp.h (choose_minibuf_frame): Remove decl.
2552 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2554 * lread.c: Make symbols static if they're not exported.
2555 (read_objects, initial_obarray, oblookup_last_bucket_number):
2557 (make_symbol): Remove; unused.
2558 * lisp.h (initial_obarray, make_symbol): Remove decls.
2560 * keyboard.c: Make symbols static if they're not exported.
2561 (single_kboard, recent_keys_index, total_keys, recent_keys):
2562 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2563 (this_single_command_key_start, echoing, last_auto_save):
2564 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2565 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2566 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2567 (Vlispy_mouse_stem, double_click_count):
2569 (force_auto_save_soon): Define only if SIGDANGER.
2570 (ignore_mouse_drag_p): Now static if
2571 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2572 (print_help): Remove; unused.
2573 (stop_character, last_timer_event): Mark as externally visible.
2574 * keyboard.h (ignore_mouse_drag_p): Declare only if
2575 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2576 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2577 * lisp.h (echoing): Remove decl.
2578 (force_auto_save_soon): Declare only if SIGDANGER.
2579 * xdisp.c (redisplay_window): Simplify code, to make it more
2580 obvious that ignore_mouse_drag_p is not accessed if !defined
2581 USE_GTK && !defined HAVE_NS.
2583 * intervals.c: Make symbols static if they're not exported.
2584 (merge_properties_sticky, merge_interval_right, delete_interval):
2586 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2588 * insdel.c: Make symbols static if they're not exported.
2589 However, leave prepare_to_modify_buffer alone. It's never
2590 called from outside this function, but that appears to be a bug.
2591 (combine_after_change_list, combine_after_change_buffer):
2592 (adjust_after_replace, signal_before_change): Now static.
2593 (adjust_after_replace_noundo): Remove; unused.
2594 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2595 (signal_before_change): Remove decls.
2597 * indent.c (val_compute_motion, val_vmotion): Now static.
2599 * image.c: Make symbols static if they're not exported.
2600 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2602 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2603 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2605 * fringe.c (standard_bitmaps): Now static.
2606 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2608 * frame.c: Make symbols static if they're not exported.
2609 (x_report_frame_params, make_terminal_frame): Now static.
2610 (get_frame_param): Now static, unless HAVE_NS.
2611 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2612 (x_get_resource_string): Remove; not used.
2613 * frame.h (make_terminal_frame, x_report_frame_params):
2614 (x_get_resource_string); Remove decls.
2615 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2616 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2618 * font.c, fontset.c: Make symbols static if they're not exported.
2619 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2620 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2621 * font.c (font_close_object): Now static.
2622 * font.h (font_close_object): Remove.
2623 * fontset.c (FONTSET_OBJLIST): Remove.
2624 (free_realized_fontset) #if-0 the body, which does nothing.
2625 (face_suitable_for_char_p): #if-0, as it's never called.
2626 * fontset.h (face_suitable_for_char_p): Remove decl.
2627 * xfaces.c (face_at_string_position):
2628 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2629 since 0 is always ASCII.
2631 * fns.c (weak_hash_tables): Now static.
2633 * fileio.c: Make symbols static if they're not exported.
2634 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2635 (Vwrite_region_annotation_buffers): Now static.
2637 * eval.c: Make symbols static if they're not exported.
2638 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2639 * lisp.h (backtrace_list): Remove decl.
2641 * emacs.c: Make symbols static if they're not exported.
2642 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2643 (fatal_error_code, fatal_error_signal_hook, standard_args):
2645 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2646 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2647 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2648 * lisp.h (fatal_error_signal_hook): Remove decl.
2649 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2651 * editfns.c: Move a (normally-unused) function to its only use.
2652 * editfns.c, lisp.h (get_operating_system_release): Remove.
2653 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2654 worth the hassle of breaking this out.
2656 * xterm.c: Make symbols static if they're not exported.
2657 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2658 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2659 (x_destroy_window, x_delete_display):
2661 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2662 (x_mouse_leave): Remove; unused.
2663 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2664 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2665 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2667 (x_mouse_leave): Declare only if WINDOWSNT.
2668 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2669 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2672 * ftxfont.c: Make symbols static if they're not exported.
2673 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2675 * font.h (ftxfont_driver): Likewise.
2677 * xfns.c: Make symbols static if they're not exported.
2678 (x_last_font_name, x_display_info_for_name):
2679 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2680 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2681 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2682 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2683 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2684 (last_show_tip_args): Now static.
2685 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2686 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2687 (x_screen_planes): Remove; unused.
2688 * dispextern.h (x_screen_planes): Remove decl.
2690 * dispnew.c: Make symbols static if they're not exported.
2691 * dispextern.h (redraw_garbaged_frames, scrolling):
2692 (increment_row_positions): Remove.
2693 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2694 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2696 (redraw_garbaged_frames): Remove; unused.
2698 * xfaces.c: Make symbols static if they're not exported.
2699 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2701 * xterm.h (defined_color): Remove decls.
2702 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2703 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2704 (menu_face_changed_default, defined_color, free_realized_face):
2705 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2706 (ascii_face_of_lisp_face): Remove; unused.
2708 * xdisp.c: Make symbols static if they're not exported.
2709 * dispextern.h (scratch_glyph_row, window_box_edges):
2710 (glyph_to_pixel_coords, set_cursor_from_row):
2711 (get_next_display_element, set_iterator_to_next):
2712 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2713 (show_mouse_face): Remove decls
2714 * frame.h (message_buf_print): Likewise.
2715 * lisp.h (pop_message, set_message, check_point_in_composition):
2717 * xterm.h (set_vertical_scroll_bar): Likewise.
2718 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2719 (message_buf_print, scratch_glyph_row, displayed_buffer):
2720 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2721 (get_next_display_element, show_mouse_face, window_box_edges):
2722 (frame_to_window_pixel_xy, check_point_in_composition):
2723 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2724 (glyph_to_pixel_coords): Remove; unused.
2726 * dired.c (file_name_completion): Now static.
2728 * dbusbind.c (xd_in_read_queued_messages): Now static.
2730 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2731 * data.c (circular_list_error): Remove.
2733 * commands.h (last_point_position, last_point_position_buffer):
2734 (last_point_position_window): Remove decls.
2735 * keyboard.c: Make these variables static.
2737 * coding.h (coding, code_convert_region, encode_coding_gap):
2739 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2740 (iso_code_class, detect_coding, code_convert_region): Now static.
2741 (encode_coding_gap): Remove; unused.
2743 * chartab.c (chartab_chars, chartab_bits): Now static.
2745 * charset.h (charset_iso_8859_1): Remove decl.
2746 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2749 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2750 * ccl.c (Vccl_program_table): Now static.
2751 (check_ccl_update): Remove; unused.
2753 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2754 * category.h: ... from here.
2755 * category.c (check_category_table, set_category_set): Now static.
2757 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2758 * lisp.h: Remove these decls.
2760 * buffer.c (buffer_count): Remove unused var.
2762 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2763 so that it's not optimized away.
2764 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2765 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2766 exported only to the debugger.
2768 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2769 * atimer.h (run_all_atimers): Remove; not exported.
2771 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2772 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2773 was inaccessible from Lisp.
2774 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2775 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2777 alloc.c: Import and export fewer symbols, and remove unused items.
2778 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2780 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2781 it's not optimized away by whole-program optimization.
2782 (message_enable_multibyte, free_misc): Remove.
2783 (catchlist, handlerlist, mark_backtrace):
2784 Declare only if BYTE_MARK_STACK.
2785 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2786 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2787 (message_enable_multibyte): Remove decl.
2788 (free_misc, interval_free_list, float_block, float_block_index):
2789 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2790 (cons_free_list, last_marked_index):
2792 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2793 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2794 (mark_backtrace): Define only if BYTE_MARK_STACK.
2795 * xdisp.c (message_enable_multibyte): Now static.
2797 Declare Lisp_Object Q* variables to be 'static' if not exported.
2798 This makes it easier for human readers (and static analyzers)
2799 to see whether these variables are used from other modules.
2800 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2801 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2802 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2803 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2804 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2805 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2806 * xmenu.c, xselect.c:
2807 Declare Q* vars static if they are not used in other modules.
2808 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2809 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2810 Remove decls of unexported vars.
2811 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2813 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2815 Make Emacs functions such as Fatom 'static' by default.
2816 This makes it easier for human readers (and static analyzers)
2817 to see whether these functions can be called from other modules.
2818 DEFUN now defines a static function. To make the function external
2819 so that it can be used in other C modules, use the new macro DEFUE.
2820 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2821 (Finit_image_library):
2822 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2823 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2824 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2825 Remove decls, since these functions are now static.
2826 (Funintern, Fget_internal_run_time): New decls, since these functions
2827 were already external.
2829 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2830 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2831 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2832 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2833 * keyboard.c, keymap.c, lread.c:
2834 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2835 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2836 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2837 Mark functions with DEFUE instead of DEFUN,
2838 if they are used in other modules.
2839 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2840 decls for now-static functions.
2841 * buffer.h (Fdelete_overlay): Remove decl.
2842 * callproc.c (Fgetenv_internal): Mark as internal.
2843 * composite.c (Fremove_list_of_text_properties): Remove decl.
2844 (Fcomposition_get_gstring): New forward static decl.
2845 * composite.h (Fcomposite_get_gstring): Remove decl.
2846 * dired.c (Ffile_attributes): New forward static decl.
2847 * doc.c (Fdocumntation_property): New forward static decl.
2848 * eval.c (Ffetch_bytecode): New forward static decl.
2849 (Funintern): Remove extern decl; now in .h file where it belongs.
2850 * fileio.c (Fmake_symbolic_link): New forward static decl.
2851 * image.c (Finit_image_library): New forward static decl.
2852 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2853 * intervals.h (Fprevious_property_change):
2854 (Fremove_list_of_text_properties): Remove decls.
2855 * keyboard.c (Fthis_command_keys): Remove decl.
2856 (Fcommand_execute): New forward static decl.
2857 * keymap.c (Flookup_key): New forward static decl.
2858 (Fcopy_keymap): Now static.
2859 * keymap.h (Flookup_key): Remove decl.
2860 * process.c (Fget_process): New forward static decl.
2861 (Fprocess_datagram_address): Mark as internal.
2862 * syntax.c (Fsyntax_table_p): New forward static decl.
2863 (skip_chars): Remove duplicate decl.
2864 * textprop.c (Fprevious_property_change): New forward static decl.
2865 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2867 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2868 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2870 * editfns.c (Fformat): Remove unreachable code.
2872 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2874 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2877 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2879 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2880 when at ZV. (Bug#8487)
2882 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2884 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2886 * keyboard.c (parse_tool_bar_item): Likewise.
2887 * sound.c (sound_cleanup, alsa_close): Likewise.
2888 * termcap.c (tgetent): Likewise.
2889 * xfns.c (x_default_font_parameter): Likewise.
2890 * xsettings.c (read_and_apply_settings): Likewise.
2892 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2893 (overrun_check_free): Protoize.
2895 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2897 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2898 since callers should never pass a negative size.
2899 Change the signature to match that of plain 'read' and 'write'; see
2900 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2901 * lisp.h: Update prototypes of emacs_write and emacs_read.
2903 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2905 * xdisp.c (redisplay_window): Don't try to determine the character
2906 position of the scroll margin if the window start point w->startp
2907 is outside the buffer's accessible region. (Bug#8468)
2909 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2911 Fix write-region and its subroutines for buffers > 2GB.
2912 * fileio.c (a_write, e_write): Modify declaration of arguments and
2913 local variables to support buffers larger than 2GB.
2914 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2916 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2917 argument, local variables, and return value.
2919 * lisp.h: Update prototypes of emacs_write and emacs_read.
2921 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2923 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2925 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2927 Fix more problems found by GCC 4.6.0's static checks.
2929 * xdisp.c (vmessage): Use a better test for character truncation.
2931 * charset.c (load_charset_map): <, not <=, for optimization,
2932 and to avoid potential problems with integer overflow.
2933 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2934 * casetab.c (set_identity, shuffle): Likewise.
2935 * editfns.c (Fformat): Likewise.
2936 * syntax.c (skip_chars): Likewise.
2938 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2939 This also lets GCC 4.6.0 generate slightly better loop code.
2941 * callint.c (Fcall_interactively): <, not <=, for optimization.
2942 (Fcall_interactively): Count the number of arguments produced,
2943 not the number of arguments given. This is simpler and lets GCC
2944 4.6.0 generate slightly better code.
2946 * ftfont.c: Distingish more carefully between FcChar8 and char.
2947 The previous code passed unsigned char * to a functions like
2948 strlen and xstrcasecmp that expect char *, which does not
2949 conform to the C standard.
2950 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2951 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2952 char * when the C standard requires it.
2954 * keyboard.c (read_char): Remove unused var.
2956 * eval.c: Port to Windows vsnprintf (Bug#8435).
2958 (SIZE_MAX): Define if the headers do not.
2959 (verror): Do not give up if vsnprintf returns a negative count.
2960 Instead, grow the buffer. This ports to Windows vsnprintf, which
2961 does not conform to C99. Problem reported by Eli Zaretskii.
2962 Also, simplify the allocation scheme, by avoiding the need for
2963 calling realloc, and removing the ALLOCATED variable.
2965 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2967 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2968 But keep the doprint source code for now, as we might revamp it
2969 and use it again (Bug#8435).
2970 * lisp.h (doprnt): Remove.
2971 * Makefile.in (base_obj): Remove doprnt.o.
2972 * deps.mk (doprnt.o): Remove.
2974 error: Print 32- and 64-bit integers portably (Bug#8435).
2975 Without this change, on typical 64-bit hosts error ("...%d...", N)
2976 was used to print both 32- and 64-bit integers N, which relied on
2978 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2980 * lisp.h (error, verror): Mark as printf-like functions.
2981 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2982 Report overflow in size calculations when allocating printf buffer.
2983 Do not truncate output string at its first null byte.
2984 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2985 Truncate the output at a character boundary, since vsnprintf does not
2987 * charset.c (check_iso_charset_parameter): Convert internal
2988 character to string before calling 'error', since %c now has the
2990 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2991 overflow when computing char to be passed to 'error'. Do not
2992 pass Lisp_Object to 'error'; pass the integer instead.
2993 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2994 formatted with plain %d.
2996 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2998 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3000 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3002 * xterm.c (x_catch_errors): Remove duplicate declaration.
3004 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3006 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3008 2011-04-10 Jim Meyering <meyering@redhat.com>
3010 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3011 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3012 return ssize_t not "int", and use size_t as the buffer length.
3013 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3014 * gnutls.h: Update declarations.
3015 * process.c (read_process_output): Use ssize_t, to match.
3016 (send_process): Likewise.
3018 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3020 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3022 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3024 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3025 Use unsigned char, to match FcChar8 type definition.
3027 * xterm.c (handle_one_xevent):
3028 * xmenu.c (create_and_show_popup_menu):
3029 * xselect.c (x_decline_selection_request)
3030 (x_reply_selection_request): Avoid type-punned deref of X events.
3032 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3034 Fix some uses of `int' instead of EMACS_INT.
3035 * search.c (string_match_1, fast_string_match)
3036 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3037 (scan_buffer, find_next_newline_no_quit)
3038 (find_before_next_newline, search_command, Freplace_match)
3039 (Fmatch_data): Make some `int' variables be EMACS_INT.
3041 * xdisp.c (display_count_lines): 3rd argument and return value now
3042 EMACS_INT. All callers changed.
3043 (pint2hrstr): Last argument is now EMACS_INT.
3045 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3046 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3047 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3048 (decode_coding_utf_16, decode_coding_emacs_mule)
3049 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3050 (decode_coding_ccl, decode_coding_charset)
3051 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3052 (decode_coding_iso_2022, decode_coding_emacs_mule)
3053 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3054 <char_offset, last_offset>: Declare EMACS_INT.
3055 (encode_coding_utf_8, encode_coding_utf_16)
3056 (encode_coding_emacs_mule, encode_invocation_designation)
3057 (encode_designation_at_bol, encode_coding_iso_2022)
3058 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3059 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3061 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3062 (encode_invocation_designation): Last argument P_NCHARS is now
3064 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3065 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3067 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3070 * ccl.c (Fccl_execute_on_string): Declare some variables
3073 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3075 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3077 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3079 * process.c (Fformat_network_address): Doc fix.
3081 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3083 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3085 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3087 * keyboard.c (read_char): Call Lisp function help-form-show,
3088 instead of using internal_with_output_to_temp_buffer.
3089 (Qhelp_form_show): New var.
3090 (syms_of_keyboard): Use DEFSYM macro.
3092 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3094 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3096 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3098 * process.c (Flist_processes): Remove to Lisp.
3099 (list_processes_1): Delete.
3101 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3103 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3105 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3107 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3109 Fix more problems found by GCC 4.6.0's static checks.
3111 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3113 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3115 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3117 * xdisp.c (vmessage): Mark as a printf-like function.
3119 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3121 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3123 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3124 printf-like functions.
3125 (tiff_load): Add casts to remove these marks before passing them
3126 to system-supplied API.
3128 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3130 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3131 This avoids several warnings with gcc -Wstrict-overflow.
3132 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3133 directly, rather than having caller test rule sign. This avoids
3134 some unnecessary tests.
3135 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3136 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3137 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3139 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3140 (xfont_open): Avoid unnecessary tests.
3142 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3144 * composite.h, composite.c (composition_gstring_put_cache):
3145 Use EMACS_INT, not int, for length.
3147 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3148 breaking out part of COMPOSITION_DECODE_RULE.
3149 (COMPOSITION_DECODE_RULE): Use it.
3150 * composite.c (get_composition_id): Remove unused local vars,
3151 by using the new macro.
3153 * textprop.c (set_text_properties_1): Change while to do-while,
3154 since the condition is always true at first.
3156 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3157 (interval_deletion_adjustment): Return unsigned value.
3160 * process.c (list_processes_1, create_pty, read_process_output):
3161 (exec_sentinel): Remove vars that were set but not used.
3162 (create_pty): Remove unnecessary "volatile"s.
3163 (Fnetwork_interface_info): Avoid possibility of int overflow.
3164 (read_process_output): Do adaptive read buffering even if carryover.
3165 (read_process_output): Simplify nbytes computation if buffered.
3167 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3169 * syntax.c (scan_words): Remove var that was set but not used.
3170 (update_syntax_table): Use unsigned instead of int.
3172 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3173 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3174 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3176 * print.c (print_error_message): Avoid int overflow.
3178 * font.c (font_list_entities): Redo for clarity,
3179 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3181 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3182 (font_score): Avoid potential overflow in diff calculation.
3184 * fns.c (substring_both): Remove var that is set but not used.
3185 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3187 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3189 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3190 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3191 can always succeed if overflow has undefined behavior.
3193 * search.c (boyer_moore, wordify): Remove vars set but not used.
3194 (wordify): Omit three unnecessary tests.
3196 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3197 All callers changed. This avoids the need for an unused var.
3199 * casefiddle.c (casify_region): Remove var that is set but not used.
3201 * dired.c (file_name_completion): Remove var that is set but not used.
3203 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3205 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3206 (Finsert_file_contents): Remove unnecessary code checking fd.
3208 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3209 Check for integer overflow on size calculations.
3211 * buffer.c (Fprevious_overlay_change): Remove var that is set
3214 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3215 Remove vars that are set but not used.
3216 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3217 (timer_check_2): Mark vars as initialized.
3219 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3221 * image.c (lookup_image): Remove var that is set but not used.
3222 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3224 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3225 that are set but not used.
3227 * xfns.c (make_invisible_cursor): Don't return garbage
3228 if XCreateBitmapFromData fails (Bug#8410).
3230 * xselect.c (x_get_local_selection, x_handle_property_notify):
3231 Remove vars that are set but not used.
3233 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3234 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3236 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3237 Remove var that is set but not used.
3238 (scroll_bar_windows_size): Now size_t, not int.
3239 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3242 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3243 (map_tty_color) [!defined MSDOS]: Likewise.
3245 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3247 * coding.c: Remove vars that are set but not used.
3248 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3249 All callers changed.
3250 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3251 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3252 (decode_coding_charset): Remove vars that are set but not used.
3254 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3255 that is set but not used.
3257 * print.c (print_object): Remove var that is set but not used.
3259 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3260 The gnulib version avoids calling malloc in the usual case,
3261 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3262 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3263 * filelock.c (current_lock_owner): Likewise.
3264 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3265 * sysdep.c: Include allocator.h, careadlinkat.h.
3266 (emacs_no_realloc_allocator): New static constant.
3267 (emacs_readlink): New function.
3268 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3269 ../lib/careadlinkat.h.
3271 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3273 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3274 first non-nil return value).
3276 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3278 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3279 if not defined (Bug#8403).
3281 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3283 * xdisp.c (display_count_lines): Remove parameter `start',
3284 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3285 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3286 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3287 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3288 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3289 and thereabouts. All callers changed.
3290 (get_per_char_metric): Remove parameter `f', unused since
3291 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3293 2011-04-02 Jim Meyering <meyering@redhat.com>
3295 do not dereference NULL upon failed strdup
3296 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3297 (ns_get_family): Likewise.
3299 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3301 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3303 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3305 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3308 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3310 Add lexical binding.
3312 * window.c (Ftemp_output_buffer_show): New fun.
3313 (Fsave_window_excursion):
3314 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3316 * lread.c (lisp_file_lexically_bound_p): New function.
3317 (Fload): Bind Qlexical_binding.
3318 (readevalloop): Remove `evalfun' arg.
3319 Bind Qinternal_interpreter_environment.
3320 (Feval_buffer): Bind Qlexical_binding.
3321 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3323 (syms_of_lread): Declare `lexical-binding'.
3325 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3327 * keyboard.c (eval_dyn): New fun.
3328 (menu_item_eval_property): Use it.
3330 * image.c (parse_image_spec): Use Ffunctionp.
3332 * fns.c (concat, mapcar1): Accept byte-code-functions.
3334 * eval.c (Fsetq): Handle lexical vars.
3335 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3336 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3337 (FletX, Flet): Obey lexical binding.
3338 (Fcommandp): Handle closures.
3339 (Feval): New `lexical' arg.
3340 (eval_sub): New function extracted from Feval. Use it almost
3341 everywhere where Feval was used. Look up vars in lexical env.
3343 (Ffunctionp): Move from subr.el.
3344 (Ffuncall): Handle closures.
3345 (apply_lambda): Remove `eval_flags'.
3346 (funcall_lambda): Handle closures and new byte-code-functions.
3347 (Fspecial_variable_p): New function.
3348 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3349 but without exporting it to Lisp.
3351 * doc.c (Fdocumentation, store_function_docstring):
3352 * data.c (Finteractive_form): Handle closures.
3354 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3357 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3359 (exec_byte_code): New function extracted from Fbyte_code to handle new
3360 calling convention for byte-code-functions. Add new byte-codes.
3362 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3364 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3366 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3368 * xdisp.c (redisplay_internal): Fix prototype.
3370 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3372 * xdisp.c (SCROLL_LIMIT): New macro.
3373 (try_scrolling): Use it when setting scroll_limit.
3374 Limit scrolling to 100 screen lines.
3375 (redisplay_window): Even when falling back on "recentering",
3376 position point in the window according to scroll-conservatively,
3377 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3379 (try_scrolling): When point is above the window, allow searching
3380 as far as scroll_max, or one screenful, to compute vertical
3381 distance from PT to the scroll margin position. This prevents
3382 try_scrolling from unnecessarily failing when
3383 scroll-conservatively is set to a value slightly larger than the
3384 window height. Clean up the case of PT below the margin at bottom
3385 of window: scroll_max can no longer be INT_MAX. When aggressive
3386 scrolling is in use, don't let point enter the opposite scroll
3387 margin as result of the scroll.
3388 (syms_of_xdisp) <scroll-conservatively>: Document the
3389 threshold of 100 lines for never-recentering scrolling.
3391 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3393 * dispextern.h (move_it_by_lines):
3394 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3395 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3396 (message_log_check_duplicate): Remove parameters `prev_bol' and
3397 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3398 (redisplay_internal): Remove parameter `preserve_echo_area',
3399 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3401 * indent.c (Fvertical_motion):
3402 * window.c (window_scroll_pixel_based, Frecenter):
3403 Don't pass `need_y_p' to `move_it_by_lines'.
3405 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3407 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3408 steal a few bits to be more compact.
3409 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3410 Remove unneeded casts.
3412 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3414 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3416 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3417 binding" message (bug#7967).
3419 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3421 Fix more problems found by GCC 4.6.0's static checks.
3423 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3424 Remove unused local var.
3426 * editfns.c (Fmessage_box): Remove unused local var.
3428 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3429 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3430 Omit unused local vars.
3431 * window.c (shrink_windows): Omit unused local var.
3432 * menu.c (digest_single_submenu): Omit unused local var.
3433 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3434 Omit unused local var.
3436 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3437 Don't assume string length fits in int.
3438 (keyremap_step, read_key_sequence): Use size_t for sizes.
3439 (read_key_sequence): Don't check last_real_key_start redundantly.
3441 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3442 instead of alloca (Bug#8344).
3444 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3445 (Fbacktrace_frame): Don't assume nframes fits in int.
3447 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3449 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3452 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3454 * cm.c (calccost): Turn while-do into do-while, for clarity.
3456 * keyboard.c (syms_of_keyboard): Use the same style as later
3457 in this function when indexing through an array. This also
3458 works around GCC bug 48267.
3460 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3462 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3464 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3465 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3467 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3468 This avoids undefined behavior on integer overflow, and is a bit
3469 more convenient anyway since it is compared to a size_t variable.
3471 Variadic C functions now count arguments with size_t, not int.
3472 This avoids an unnecessary limitation on 64-bit machines, which
3473 caused (substring ...) to crash on large vectors (Bug#8344).
3474 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3475 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3476 All variadic functions and their callers changed accordingly.
3477 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3478 * data.c (arith_driver, float_arith_driver): Likewise.
3479 * editfns.c (general_insert_function): Likewise.
3480 * eval.c (struct backtrace.nargs, interactive_p)
3481 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3482 (funcall_lambda, mark_backtrace): Likewise.
3483 * fns.c (concat): Likewise.
3484 * frame.c (x_set_frame_parameters): Likewise.
3485 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3486 0 if not found, not -1. All callers changed.
3488 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3489 (stack_copy_size): Now size_t, not int.
3490 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3492 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3494 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3495 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3496 All callers changed.
3498 * lisp.h (multibyte_char_to_unibyte):
3499 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3500 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3501 * character.h (CHAR_TO_BYTE8):
3502 * cmds.c (internal_self_insert):
3503 * editfns.c (general_insert_function):
3504 * keymap.c (push_key_description):
3505 * search.c (Freplace_match):
3506 * xdisp.c (message_dolog, set_message_1): All callers changed.
3508 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3510 * keyboard.c (safe_run_hook_funcall): New function.
3511 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3512 don't set the hook to nil, but remove the offending function instead.
3513 (Qcommand_hook_internal): Remove, unused.
3514 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3515 Vcommand_hook_internal.
3517 * eval.c (enum run_hooks_condition): Remove.
3518 (funcall_nil, funcall_not): New functions.
3519 (run_hook_with_args): Call each function through a `funcall' argument.
3520 Remove `cond' argument, now redundant.
3521 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3522 (Frun_hook_with_args_until_failure): Adjust accordingly.
3523 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3525 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3527 * dispextern.h (string_buffer_position): Remove declaration.
3529 * print.c (strout): Remove parameter `multibyte', unused since
3530 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3532 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3533 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3534 All callers changed.
3536 * w32.c (_wsa_errlist): Use braces for struct initializers.
3538 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3539 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3540 All callers changed.
3541 (string_buffer_position): Likewise. Also, make static (it's never
3542 used outside xdisp.c).
3543 (cursor_row_p): Remove parameter `w', unused since
3544 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3545 (decode_mode_spec): Remove parameter `precision', introduced during
3546 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3547 All callers changed.
3549 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3551 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3553 2011-03-27 Anders Lindgren <andlind@gmail.com>
3555 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3556 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3557 (ns_update_auto_hide_menu_bar): New functions.
3558 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3559 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3560 ns_constrain_all_frames.
3561 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3562 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3564 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3566 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3568 2011-03-27 Glenn Morris <rgm@gnu.org>
3570 * syssignal.h: Replace RETSIGTYPE with void.
3571 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3572 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3573 Replace SIGTYPE with void everywhere.
3574 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3575 * s/template.h (SIGTYPE): Remove commented out definition.
3577 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3579 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3580 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3582 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3584 * w32.c (read_unc_volume): Use parameter `henum', instead of
3585 global variable `wget_enum_handle'.
3587 * keymap.c (describe_vector): Remove parameters `indices' and
3588 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3589 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3591 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3593 * keyboard.c (timer_check): Remove parameter `do_it_now',
3594 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3595 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3596 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3598 * keyboard.c (read_char):
3599 * w32menu.c (w32_menu_display_help):
3600 * xmenu.c (show_help_event, menu_help_callback):
3601 Adjust calls to `show_help_echo'.
3603 * gtkutil.c (xg_maybe_add_timer):
3604 * keyboard.c (readable_events):
3605 * process.c (wait_reading_process_output):
3606 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3608 * insdel.c (adjust_markers_gap_motion):
3609 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3610 (gap_left, gap_right): Don't call it.
3612 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3614 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3615 incurred during fontification.
3617 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3619 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3620 (DEFVAR_PER_BUFFER): Don't pass it.
3622 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3623 (scrolling_window): Don't pass it.
3625 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3627 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3629 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3631 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3632 of variables specific to SELinux and computation of `encoded_absname'.
3634 * image.c (XPutPixel): Remove unused variable `height'.
3636 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3638 * unexw32.c (get_section_info): Remove unused variable `section'.
3640 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3641 (system_process_attributes): Remove unused variable `sess'.
3642 (sys_read): Remove unused variable `err'.
3644 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3645 (w32_wnd_proc): Remove unused variable `isdead'.
3646 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3647 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3648 (x_create_tip_frame): Remove unused variable `tem'.
3650 * w32inevt.c (w32_console_read_socket):
3651 Remove unused variable `no_events'.
3653 * w32term.c (x_draw_composite_glyph_string_foreground):
3654 Remove unused variable `width'.
3656 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3658 * w32term.c (x_set_glyph_string_clipping):
3659 Don't pass uninitialized region to CombineRgn.
3661 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3663 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3664 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3665 (Fx_close_connection): Remove unused variable `i'.
3667 * w32font.c (w32font_draw): Return number of glyphs.
3668 (w32font_open_internal): Remove unused variable `i'.
3669 (w32font_driver): Add missing initializer.
3671 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3672 (fill_in_menu): Remove unused variable `items_added'.
3674 * w32term.c (last_mouse_press_frame): Remove static global variable.
3675 (w32_clip_to_row): Remove unused variable `f'.
3676 (x_delete_terminal): Remove unused variable `i'.
3678 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3679 (NOTHING): Remove unused static global variable.
3680 (uniscribe_check_otf): Remove unused variable `table'.
3681 (uniscribe_font_driver): Add missing initializers.
3683 2011-03-23 Julien Danjou <julien@danjou.info>
3685 * term.c (Fsuspend_tty, Fresume_tty):
3686 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3687 * window.c (temp_output_buffer_show):
3688 * insdel.c (signal_before_change):
3689 * frame.c (Fhandle_switch_frame):
3690 * fileio.c (Fdo_auto_save):
3691 * emacs.c (Fkill_emacs):
3692 * editfns.c (save_excursion_restore):
3693 * cmds.c (internal_self_insert):
3694 * callint.c (Fcall_interactively):
3695 * buffer.c (Fkill_all_local_variables):
3696 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3698 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3699 unconditionnaly since it does the check itself.
3701 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3703 Fix more problems found by GCC 4.5.2's static checks.
3705 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3706 the first time through the loop, since we know p0 < p1 then.
3707 This also avoids a gcc -Wstrict-overflow warning.
3709 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3710 leading to a memory leak, possible in functions like
3711 load_charset_map_from_file that can allocate an unbounded number
3712 of objects (Bug#8318).
3714 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3715 that could (at least in theory) be that large.
3717 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3718 This is less likely to overflow, and avoids undefined behavior if
3719 overflow does occur. All callers changed. Use strtoul to scan
3720 for the unsigned long integer.
3721 (pint2hrstr): Simplify and tune code slightly.
3722 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3724 * scroll.c (do_scrolling): Work around GCC bug 48228.
3725 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3727 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3728 This also avoids a warning with gcc -Wstrict-overflow.
3729 (validate_x_resource_name): Simplify count usage.
3730 This also avoids a warning with gcc -Wstrict-overflow.
3732 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3735 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3737 * process.c (Fmake_network_process): Use socklen_t, not int,
3738 where POSIX says socklen_t is required in portable programs.
3739 This fixes a porting bug on hosts like 64-bit HP-UX, where
3740 socklen_t is wider than int (Bug#8277).
3741 (Fmake_network_process, server_accept_connection):
3742 (wait_reading_process_output, read_process_output):
3745 * process.c: Rename or move locals to avoid shadowing.
3746 (list_processes_1, Fmake_network_process):
3747 (read_process_output_error_handler, exec_sentinel_error_handler):
3748 Rename or move locals.
3749 (Fmake_network_process): Define label "retry_connect" only if needed.
3750 (Fnetwork_interface_info): Fix pointer signedness.
3751 (process_send_signal): Add cast to avoid pointer signedness problem.
3752 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3753 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3755 Make tparam.h and terminfo.c consistent.
3756 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3757 Include tparam.h instead, since it declares them.
3758 * cm.h (PC): Remove extern decl; tparam.h now does this.
3759 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3760 * terminfo.c: Include tparam.h, to check interfaces.
3761 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3762 (tparam): Adjust signature to match interface in tparam.h;
3763 this removes some undefined behavior. Check that outstring and len
3764 are zero, which they always are with Emacs.
3765 * tparam.h (PC, BC, UP): New extern decls.
3767 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3768 (xftfont_open): Rename locals to avoid shadowing.
3770 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3771 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3772 (OTF_TAG_SYM): Omit macro if not needed.
3773 (ftfont_list): Remove unused local.
3774 (get_adstyle_property, ftfont_pattern_entity):
3775 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3776 Rename locals to avoid shadowing.
3778 * xfont.c (xfont_list_family): Mark var as initialized.
3780 * xml.c (make_dom): Now static.
3782 * composite.c (composition_compute_stop_pos): Rename local to
3784 (composition_reseat_it): Remove unused locals.
3785 (find_automatic_composition, composition_adjust_point): Likewise.
3786 (composition_update_it): Mark var as initialized.
3787 (find_automatic_composition): Mark vars as initialized,
3788 with a FIXME (Bug#8290).
3790 character.h: Rename locals to avoid shadowing.
3791 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3792 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3793 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3794 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3797 * textprop.c (property_change_between_p): Remove; unused.
3799 * intervals.c (interval_start_pos): Now static.
3801 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3803 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3804 Rename locals to avoid shadowing.
3806 * sound.c (wav_play, au_play, Fplay_sound_internal):
3807 Fix pointer signedness.
3808 (alsa_choose_format): Remove unused local var.
3809 (wav_play): Initialize a variable to 0, to prevent undefined
3810 behavior (Bug#8278).
3812 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3814 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3816 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3817 clobbering (Bug#8298).
3818 * sysdep.c (sys_subshell): Likewise.
3819 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3821 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3822 This should get cleaned up, so that child_setup has the
3823 same signature on all platforms.
3825 * callproc.c (call_process_cleanup): Now static.
3826 (relocate_fd): Rename locals to avoid shadowing.
3828 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3830 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3831 not to be necessary, and produces flickering.
3833 2011-03-20 Glenn Morris <rgm@gnu.org>
3835 * config.in: Remove file.
3837 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3839 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3840 are now in src/globals.h.
3841 (syms_of_minibuf): Remove spurious & from previous change.
3843 2011-03-20 Leo <sdl.web@gmail.com>
3845 * minibuf.c (completing-read-function): New variable.
3846 (completing-read-default): Rename from completing-read.
3847 (completing-read): Call completing-read-function.
3849 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3851 * xfaces.c (Fx_load_color_file):
3852 Read color file from absolute filename (bug#8250).
3854 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3856 * makefile.w32-in: Update dependencies.
3858 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3860 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3862 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3864 Fix more problems found by GCC 4.5.2's static checks.
3866 * process.c (make_serial_process_unwind, send_process_trap):
3867 (sigchld_handler): Now static.
3869 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3870 That way, the code declares only the vars that it needs.
3871 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3872 * s/cygwin.h (PTY_ITERATION): Likewise.
3873 * s/darwin.h (PTY_ITERATION): Likewise.
3874 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3876 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3877 * process.c (allocate_pty): Don't declare stb unless it's needed.
3879 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3880 (CONSTANTLIM): Remove; unused.
3881 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3882 Define only if needed.
3884 * unexelf.c (unexec): Name an expression,
3885 to avoid gcc -Wbad-function-cast warning.
3886 Use a different way to cause a compilation error if anyone uses
3887 n rather than nn, a way that does not involve shadowing.
3888 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3890 * deps.mk (unexalpha.o): Remove; unused.
3892 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3893 * unexec.h: New file.
3894 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3895 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3897 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3898 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3899 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3900 Change as necessary to match prototype in unexec.h.
3902 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3904 (back_comment, skip_chars): Mark vars as initialized.
3906 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3907 Rename locals to avoid shadowing.
3909 * lread.c (read1): Rewrite so as not to use empty "else".
3910 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3912 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3914 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3915 warning when compiling print.c.
3917 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3918 instead of using an uninitialized var.
3919 (font_sort_entities): Mark var as initialized.
3921 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3923 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3924 pointers to constants.
3925 (font_parse_fcname): Remove unused vars.
3926 (font_delete_unmatched): Now static.
3927 (font_get_spec): Remove; unused.
3928 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3929 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3930 Rename or move locals to avoid shadowing.
3932 * fns.c (require_nesting_list, require_unwind): Now static.
3933 (Ffillarray): Rename locals to avoid shadowing.
3935 * floatfns.c (domain_error2): Define only if needed.
3936 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3938 * alloc.c (mark_backtrace): Move decl from here ...
3939 * lisp.h: ... to here, so that it can be checked.
3941 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3942 (Fdefvar): Rewrite so as not to use empty "else".
3943 (lisp_indirect_variable): Name an expression,
3944 to avoid gcc -Wbad-function-cast warning.
3945 (Fdefvar): Rename locals to avoid shadowing.
3947 * callint.c (quotify_arg, quotify_args): Now static.
3948 (Fcall_interactively): Rename locals to avoid shadowing.
3949 Use const pointer when appropriate.
3951 * lisp.h (get_system_name, get_operating_system_release):
3952 Move decls here, to check interfaces.
3953 * process.c (get_operating_system_release): Move decl to lisp.h.
3954 * xrdb.c (get_system_name): Likewise.
3955 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3956 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3957 some of which prompt warnings from gcc -Wbad-function-cast.
3958 (Fformat_time_string, Fencode_time, Finsert_char):
3959 (Ftranslate_region_internal, Fformat):
3960 Rename or remove local vars to avoid shadowing.
3961 (Ftranslate_region_internal): Mark var as initialized.
3963 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3966 * lisp.h (eassert): Check that the argument compiles, even if
3967 ENABLE_CHECKING is not defined.
3969 * data.c (Findirect_variable): Name an expression, to avoid
3970 gcc -Wbad-function-cast warning.
3971 (default_value, arithcompare, arith_driver, arith_error): Now static.
3972 (store_symval_forwarding): Rename local to avoid shadowing.
3973 (Fmake_variable_buffer_local, Fmake_local_variable):
3974 Mark variables as initialized.
3975 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3977 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3978 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3979 Rename locals to avoid shadowing.
3980 (mark_stack): Move local variables into the #ifdef region where
3982 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3983 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3985 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3986 (GC_STRING_CHARS): Remove; not used.
3987 (Fmemory_limit): Cast sbrk's returned value to char *.
3989 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3990 avoids undefined behavior in theory.
3992 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3994 Use functions, not macros, for up- and down-casing (Bug#8254).
3995 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3996 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3997 to use the following functions instead of these macros.
3998 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3999 EMACS_INT, since callers assume the returned value fits in int.
4000 (upcase1): Likewise, for UPCASE_TABLE.
4001 (uppercasep, lowercasep, upcase): New static inline functions.
4002 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4003 the race-condition problem in the old DOWNCASE.
4005 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4006 Rename locals to avoid shadowing.
4007 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4008 (regex_compile, re_search_2, re_match_2_internal):
4009 Remove unused local vars.
4010 (FREE_VAR): Rewrite so as not to use empty "else",
4011 which gcc can warn about.
4012 (regex_compile, re_match_2_internal): Mark locals as initialized.
4013 (RETALLOC_IF): Define only if needed.
4014 (WORDCHAR_P): Likewise. This one is never needed, but is used
4015 only in a comment talking about a compiler bug, so put inside
4016 the #if 0 of that comment.
4017 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4018 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4021 * search.c (boyer_moore): Rename locals to avoid shadowing.
4022 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4023 (PREV_CHAR_BOUNDARY): Likewise.
4025 * search.c (simple_search): Remove unused var.
4027 * dired.c (compile_pattern): Move decl from here ...
4028 * lisp.h: ... to here, so that it can be checked.
4029 (struct re_registers): New forward decl.
4031 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4033 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4035 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4036 Rename locals to avoid shadowing.
4037 (Fvertical_motion): Mark locals as initialized.
4039 * casefiddle.c (casify_object, casify_region): Now static.
4040 (casify_region): Mark local as initialized.
4042 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4044 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4045 New macros, so that the caller can use some names other than
4046 gcpro1, gcpro2, etc.
4047 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4049 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4050 argument, for consistency with GCPRO2_VAR, etc: it is now the
4051 prefix of the variable, not the variable itself. All uses
4053 * dired.c (directory_files_internal, file_name_completion):
4054 Rename locals to avoid shadowing.
4056 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4057 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4058 dired.c's scmp function, had undefined behavior.
4059 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4060 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4061 * buffer.h: ... to here, because these macros use current_buffer,
4062 and the new implementation with inline functions needs to have
4063 current_buffer in scope now, rather than later when the macros
4065 (downcase, upcase1): New static inline functions.
4066 (DOWNCASE, UPCASE1): Reimplement using these functions.
4067 This avoids undefined behavior in expressions like
4068 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4069 from race conditions in accessing the global variables
4070 case_temp1 and case_temp2.
4071 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4072 * lisp.h (case_temp1, case_temp2): Remove their decls.
4073 * character.h (ASCII_CHAR_P): Move from here ...
4074 * lisp.h: ... to here, so that the inline functions mentioned
4077 * dired.c (directory_files_internal_unwind): Now static.
4079 * fileio.c (file_name_as_directory, directory_file_name):
4080 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4082 (file_name_as_directory): Use const pointers when appropriate.
4083 (Fexpand_file_name): Likewise. In particular, newdir might
4084 point at constant storage, so make it a const pointer.
4085 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4086 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4088 (Fset_file_times, Finsert_file_contents, auto_save_error):
4089 Rename locals to avoid shadowing.
4091 * minibuf.c (choose_minibuf_frame_1): Now static.
4092 (Ftry_completion, Fall_completions): Rename or remove locals
4095 * marker.c (bytepos_to_charpos): Remove; unused.
4097 * lisp.h (verify_bytepos, count_markers): New decls,
4098 so that gcc does not warn that these functions aren't declared.
4100 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4101 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4102 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4103 (copy_text): Remove unused local var.
4105 * filelock.c (within_one_second): Now static.
4106 (lock_file_1): Rename local to avoid shadowing.
4108 * buffer.c (fix_overlays_before): Mark locals as initialized.
4109 (fix_start_end_in_overlays): Likewise. This function should be
4110 simplified by using pointers-to-pointers, but that's a different
4112 (switch_to_buffer_1): Now static.
4113 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4114 (report_overlay_modification): Rename locals to avoid shadowing.
4116 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4117 Fix pointer signedness issue.
4118 (sys_subshell): Mark local as volatile if checking for lint,
4119 to suppress a gcc -Wclobbered warning that does not seem to be right.
4120 (MAXPATHLEN): Define only if needed.
4122 * process.c (serial_open, serial_configure): Move decls from here ...
4123 * systty.h: ... to here, so that they can be checked.
4125 * fns.c (get_random, seed_random): Move extern decls from here ...
4126 * lisp.h: ... to here, so that they can be checked.
4128 * sysdep.c (reset_io): Now static.
4129 (wait_for_termination_signal): Remove; unused.
4131 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4132 (copy_keymap_item, append_key, push_text_char_description):
4134 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4135 (DENSE_TABLE_SIZE): Remove; unused.
4136 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4137 (describe_map_tree):
4138 Rename locals to avoid shadowing.
4140 * keyboard.c: Declare functions static if they are not used elsewhere.
4141 (echo_char, echo_dash, cmd_error, top_level_2):
4142 (poll_for_input, handle_async_input): Now static.
4143 (read_char, kbd_buffer_get_event, make_lispy_position):
4144 (make_lispy_event, make_lispy_movement, apply_modifiers):
4145 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4146 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4147 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4148 (read_key_sequence, read_char): Mark locals as initialized.
4149 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4151 * keyboard.h (make_ctrl_char): New decl.
4152 (mark_kboards): Move decl here ...
4153 * alloc.c (mark_kboards): ... from here.
4155 * lisp.h (force_auto_save_soon): New decl.
4157 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4158 (DEFINE_DUMMY_FUNCTION): New macro.
4159 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4161 (main): Add casts to avoid warnings
4162 if GCC considers string literals to be constants.
4164 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4166 * dbusbind.c: Pointer signedness fixes.
4167 (xd_signature, xd_append_arg, xd_initialize):
4168 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4169 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4170 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4171 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4173 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4174 if GCC considers string literals to be constants.
4175 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4177 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4179 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4180 (print_preprocess, print_object): New macro to fix last change.
4182 * print.c (print_preprocess): Don't forget font objects.
4184 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4186 * emacs.c (USAGE3): Doc fixes.
4188 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4190 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4193 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4195 * lisp.h (VWindow_system, Qfile_name_history):
4196 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4197 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4198 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4200 * w32select.c: Don't #include "keyboard.h".
4201 (run_protected): Add extern declaration for waiting_for_input.
4203 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4204 * w32console.c (detect_input_pending, read_input_pending)
4205 (encode_terminal_code):
4206 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4207 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4208 (w32_system_caret_y, Qfile_name_history):
4209 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4210 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4211 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4212 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4213 * w32proc.c (Qlocal, report_file_error):
4214 * w32term.c (Vwindow_system, updating_frame):
4215 * w32uniscribe.c (initialized, uniscribe_font_driver):
4216 Remove unneeded extern declarations.
4218 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4220 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4222 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4224 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4225 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4226 These macros can no longer be used for assignment.
4228 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4229 Assign struct members directly, instead of using BUF_BEGV etc.
4230 (record_buffer_markers, fetch_buffer_markers): New functions for
4231 recording and fetching special buffer markers.
4232 (set_buffer_internal_1, set_buffer_temp): Use them.
4234 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4236 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4238 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4239 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4241 * xdisp.c (hscroll_window_tree):
4242 (reconsider_clip_changes): Use PT instead of BUF_PT.
4244 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4246 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4247 $(EMACS_ROOT)/lib/intprops.h.
4249 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4251 Fix more problems found by GCC 4.5.2's static checks.
4253 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4254 to unsigned char * to avoid compiler diagnostic.
4255 (xg_free_frame_widgets): Make it clear that a local variable is
4256 needed only if USE_GTK_TOOLTIP.
4257 (gdk_window_get_screen): Make it clear that this macro is needed
4258 only if USE_GTK_TOOLTIP.
4259 (int_gtk_range_get_value): New function, which avoids a diagnostic
4260 from gcc -Wbad-function-cast.
4261 (xg_set_toolkit_scroll_bar_thumb): Use it.
4262 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4263 diagnostic from gcc -Wbad-function-cast.
4264 (get_utf8_string, xg_get_file_with_chooser):
4265 Rename locals to avoid shadowing.
4266 (create_dialog): Move locals to avoid shadowing.
4268 * xgselect.c (xg_select): Remove unused var.
4270 * image.c (four_corners_best): Mark locals as initialized.
4271 (gif_load): Initialize transparent_p to zero (Bug#8238).
4272 Mark another local as initialized.
4273 (my_png_error, my_error_exit): Mark with NO_RETURN.
4275 * image.c (clear_image_cache): Now static.
4276 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4277 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4278 (x_edge_detection): Remove unnecessary cast that
4279 gcc -Wbad-function-cast diagnoses.
4280 (gif_load): Fix pointer signedness.
4281 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4282 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4284 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4286 Improve quality of tests for time stamp overflow.
4287 For example, without this patch (encode-time 0 0 0 1 1
4288 1152921504606846976) returns the obviously-bogus value (-948597
4289 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4290 reports time overflow. See
4291 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4292 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4293 * editfns.c: Include limits.h and intprops.h.
4294 (TIME_T_MIN, TIME_T_MAX): New macros.
4295 (time_overflow): Move earlier, to before first use.
4296 (hi_time, lo_time): New functions, for an accurate test for
4298 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4299 (Fget_internal_run_time): Don't assume time_t fits in int.
4300 (make_time): Use list2 instead of Fcons twice.
4301 (Fdecode_time): More accurate test for out-of-range times.
4302 (check_tm_member): New function.
4303 (Fencode_time): Use it, to test for out-of-range times.
4304 (lisp_time_argument): Don't rely on undefined left-shift and
4305 right-shift behavior when checking for time stamp overflow.
4307 * editfns.c (time_overflow): New function, refactoring common code.
4308 (Fformat_time_string, Fdecode_time, Fencode_time):
4309 (Fcurrent_time_string): Use it.
4311 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4312 * dired.c (make_time): Move to ...
4313 * editfns.c (make_time): ... here.
4314 * systime.h: Note the move.
4316 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4318 * fringe.c (update_window_fringes): Remove unused variables.
4320 * unexmacosx.c (copy_data_segment): Also copy __got section.
4323 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4325 * termcap.c [MSDOS]: Include "msdos.h".
4326 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4327 Constify `char *' arguments and their references according to
4328 prototypes in tparam.h.
4330 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4332 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4333 Adapt all references accordingly.
4335 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4337 2011-03-11 Tom Tromey <tromey@redhat.com>
4339 * buffer.c (syms_of_buffer): Remove obsolete comment.
4341 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4343 * termhooks.h (encode_terminal_code): Declare prototype.
4345 * msdos.c (encode_terminal_code): Don't declare prototype.
4347 * term.c (encode_terminal_code): Now external again, used by
4348 w32console.c and msdos.c.
4350 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4351 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4353 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4355 Fix some minor problems found by GCC 4.5.2's static checks.
4357 * fringe.c (update_window_fringes): Mark locals as initialized
4359 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4361 * alloc.c (mark_fringe_data): Move decl from here ...
4362 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4363 to check its interface.
4364 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4366 * fontset.c (free_realized_fontset): Now static.
4367 (Fset_fontset_font): Rename local to avoid shadowing.
4368 (fontset_font): Mark local as initialized.
4369 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4371 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4373 * xselect.c (x_disown_buffer_selections): Remove; not used.
4374 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4375 (x_own_selection, Fx_disown_selection_internal): Rename locals
4377 (x_handle_dnd_message): Remove local to avoid shadowing.
4379 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4380 so that the caller can use some name other than gcpro1.
4381 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4382 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4383 (Fx_backspace_delete_keys_p):
4384 Use them to avoid shadowing, and rename vars to avoid shadowing.
4385 (x_decode_color, x_set_name, x_window): Now static.
4386 (Fx_create_frame): Add braces to silence GCC warning.
4387 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4388 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4389 Remove unused locals.
4390 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4391 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4392 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4395 * xterm.h (x_mouse_leave): New decl.
4397 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4398 Remove unused functions.
4399 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4400 (x_calc_absolute_position): Now static.
4401 (XTread_socket): Don't define label "out" unless it's used.
4402 Don't declare local "event" unless it's used.
4403 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4404 unless they are used.
4405 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4406 (x_fatal_error_signal): Remove; not used.
4407 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4408 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4409 (x_error_catcher, x_connection_closed, x_error_handler):
4410 (x_error_quitter, xembed_send_message, x_iconify_frame):
4411 (my_log_handler): Rename locals to avoid shadowing.
4412 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4413 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4415 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4416 Rename or move locals to avoid shadowing.
4417 (tty_defined_color, merge_face_heights): Now static.
4418 (free_realized_faces_for_fontset): Remove; not used.
4419 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4420 does not deduce is never used uninitialized.
4421 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4422 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4424 * terminal.c (store_terminal_param): Now static.
4426 * xmenu.c (menu_highlight_callback): Now static.
4427 (set_frame_menubar): Remove unused local.
4428 (xmenu_show): Rename parameter to avoid shadowing.
4429 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4430 since they might point to immutable storage.
4431 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4432 since it's unused otherwise.
4434 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4435 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4436 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4437 avoids a gcc -Wuninitialized diagnostic.
4438 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4439 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4440 does not deduce are never used uninitialized.
4442 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4444 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4445 * window.c (window_loop, size_window):
4446 (run_window_configuration_change_hook, enlarge_window): Likewise.
4448 * window.c (display_buffer): Now static.
4449 (size_window): Mark variables that gcc -Wuninitialized
4450 does not deduce are never used uninitialized.
4451 * window.h (check_all_windows): New decl, to forestall
4452 gcc -Wmissing-prototypes diagnostic.
4453 * dispextern.h (bidi_dump_cached_states): Likewise.
4455 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4457 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4459 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4460 and to avoid gcc -Wuninitialized warning.
4461 (load_charset_map): Mark variables that gcc -Wuninitialized
4462 does not deduce are never used uninitialized.
4463 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4465 * coding.c (coding_set_source, coding_set_destination):
4466 Use "else { /* comment */ }" rather than "else /* comment */;"
4467 for clarity, and to avoid gcc -Wempty-body warning.
4468 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4469 a block, when the outer 'i' will do.
4470 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4471 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4472 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4473 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4474 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4475 Rename locals to avoid shadowing.
4476 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4477 * coding.c (emacs_mule_char, encode_invocation_designation):
4478 Now static, since they're not used elsewhere.
4479 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4480 (decode_coding_object, encode_coding_object, detect_coding_system):
4481 (decode_coding_emacs_mule): Mark variables that gcc
4482 -Wuninitialized does not deduce are never used uninitialized.
4483 (detect_coding_iso_2022): Initialize a local variable that might
4484 be used uninitialized. Leave a FIXME because it's not clear that
4485 this initialization is needed. (Bug#8211)
4486 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4487 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4488 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4489 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4490 Remove unused macros.
4492 * category.c (hash_get_category_set): Remove unused local var.
4493 (copy_category_table): Now static, since it's not used elsewhere.
4494 * character.c (string_count_byte8): Likewise.
4496 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4497 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4499 * chartab.c (copy_sub_char_table): Now static, since it's not used
4501 (sub_char_table_ref_and_range, char_table_ref_and_range):
4502 Rename locals to avoid shadowing.
4503 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4505 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4506 (BIDI_BOB): Remove unused macro.
4508 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4509 deduce are never used uninitialized.
4510 * term.c (encode_terminal_code): Likewise.
4512 * term.c (encode_terminal_code): Now static. Remove unused local.
4514 * tparam.h: New file.
4515 * term.c, tparam.h: Include it.
4516 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4517 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4518 Move these decls to tparam.h, and make them agree with what
4519 is actually in tparam.c. The previous trick of using incompatible
4520 decls in different modules does not conform to the C standard.
4521 All callers of tparam changed to use tparam's actual API.
4522 * tparam.c (tparam1, tparam, tgoto):
4523 Use const pointers where appropriate.
4525 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4526 * cm.h (struct cm): Likewise.
4527 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4528 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4529 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4530 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4531 (turn_on_face, init_tty): Likewise.
4532 * termchar.h (struct tty_display_info): Likewise.
4534 * term.c (term_mouse_position): Rename local to avoid shadowing.
4536 * alloc.c (mark_ttys): Move decl from here ...
4537 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4539 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4541 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4543 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4545 * search.c (compile_pattern_1): Remove argument regp, unused since
4546 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4547 (compile_pattern): Don't pass it.
4549 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4551 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4552 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4554 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4556 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4558 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4559 gdk_window_get_screen, gdk_window_get_geometry,
4560 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4561 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4562 (xg_get_pixbuf_from_pixmap): New function.
4563 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4564 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4565 Call xg_get_pixbuf_from_pixmap instead of
4566 gdk_pixbuf_get_from_drawable.
4567 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4568 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4569 (xg_check_special_colors): Use GtkStyleContext and its functions
4571 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4572 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4573 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4574 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4575 Call gtk_widget_get_preferred_size.
4576 (xg_frame_resized): gdk_window_get_geometry only takes 5
4578 (xg_win_to_widget, xg_event_is_for_menubar):
4579 Call gdk_x11_window_lookup_for_display.
4580 (xg_set_widget_bg): New function.
4581 (delete_cb): New function.
4582 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4583 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4584 (xg_set_background_color): Call xg_set_widget_bg.
4585 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4586 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4587 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4588 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4590 (update_frame_tool_bar): Call gtk_widget_hide.
4591 (xg_initialize): Use GDK_KEY_g.
4593 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4595 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4597 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4598 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4599 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4601 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4603 * w32xfns.c (select_palette): Check success of RealizePalette against
4604 GDI_ERROR, not zero.
4606 See ChangeLog.11 for earlier changes.
4612 Copyright (C) 2011 Free Software Foundation, Inc.
4614 This file is part of GNU Emacs.
4616 GNU Emacs is free software: you can redistribute it and/or modify
4617 it under the terms of the GNU General Public License as published by
4618 the Free Software Foundation, either version 3 of the License, or
4619 (at your option) any later version.
4621 GNU Emacs is distributed in the hope that it will be useful,
4622 but WITHOUT ANY WARRANTY; without even the implied warranty of
4623 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4624 GNU General Public License for more details.
4626 You should have received a copy of the GNU General Public License
4627 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.