1 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3 * coding.c (produce_chars): Use ptrdiff_t, not int.
5 * xterm.c (x_draw_underwave): Check for integer overflow.
6 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
8 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
10 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
11 referenced (Bug#11583).
13 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
15 Implement wave-style variant of underlining.
16 * dispextern.h (face_underline_type): New enum.
17 (face): Add field for underline type.
18 * nsterm.m (ns_draw_underwave): New function.
19 (ns_draw_text_decoration): Use it.
20 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
22 (x_draw_glyph_string): Use them.
23 * xfaces.c (Qline, Qwave): New Lisp objects.
24 (check_lface_attrs, merge_face_ref)
25 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
26 wave-style underline face attributes.
27 * xterm.c (x_draw_underwave): New function.
28 (x_draw_glyph_string): Use it.
30 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
32 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
33 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
34 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
35 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
36 ($(BLD)/w32select.$(O)): Update dependencies.
38 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
40 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
41 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
42 * character.c (_fetch_multibyte_char_p): Remove.
43 * alloc.c: Include "character.h" before "buffer.h".
46 * bytecode.c: Likewise.
47 * callint.c: Likewise.
48 * callproc.c: Likewise.
49 * casefiddle.c: Likewise.
50 * casetab.c: Likewise.
51 * category.c: Likewise.
54 * composite.c: Likewise.
56 * dispnew.c: Likewise.
59 * editfns.c: Likewise.
62 * filelock.c: Likewise.
64 * fontset.c: Likewise.
68 * intervals.c: Likewise.
69 * keyboard.c: Likewise.
74 * minibuf.c: Likewise.
78 * process.c: Likewise.
80 * region-cache.c: Likewise.
84 * textprop.c: Likewise.
86 * unexsol.c: Likewise.
87 * w16select.c: Likewise.
89 * w32menu.c: Likewise.
95 * xselect.c: Likewise.
97 2012-06-16 Eli Zaretskii <eliz@gnu.org>
99 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
100 all the glyphs of the glyph row came from strings, and we have no
101 cursor positioning clues, put the cursor on the first glyph of the
103 (handle_face_prop): Use chunk-relative overlay string index when
104 indexing into it->string_overlays array. (Bug#11653)
105 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
106 the rightmost. (Bug#11720)
108 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
110 * category.h (CHAR_HAS_CATEGORY): Define as inline.
111 (CATEGORY_MEMBER): Enforce 1/0 value.
112 * category.c (_temp_category_set): Remove.
114 2012-06-16 Eli Zaretskii <eliz@gnu.org>
116 * window.c (Fdelete_other_windows_internal)
117 (Fdelete_window_internal): Don't access frame's mouse highlight
118 info of the initial frame. (Bug#11677)
120 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
122 * .gdbinit (xgetint): Fix recently-introduced paren typo.
123 Assume USE_2_TAGS_FOR_INTS.
124 (xreload): Adjust $tagmask width to match recent lisp.h change.
126 Simplify lisp.h in minor ways that should not affect code.
127 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
128 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
129 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
130 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
131 (INTTYPEBITS): New macro, for clarity.
132 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
133 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
134 now that USE_LSB_TAG is always defined.
135 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
136 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
138 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
140 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
142 2012-06-13 Glenn Morris <rgm@gnu.org>
144 * s/bsd-common.h (BSD4_3):
145 * s/usg5-4-common.h (USG5_4): No longer define; unused.
147 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
149 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
152 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
154 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
155 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
156 * alloc.c (widen_to_Lisp_Object): Removed.
157 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
158 * frame.c (delete_frame): Remove outdated comment.
159 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
161 (Fw32_unregister_hot_key): Likewise.
162 (Fw32_toggle_lock_key): Likewise.
163 * w32menu.c (add_menu_item): Likewise.
164 (w32_menu_display_help): Use XIL instead of checking
166 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
167 (init_heap): Likewise.
168 * w32term.c (w32_read_socket): Update comment.
170 2012-06-13 Glenn Morris <rgm@gnu.org>
172 * s/usg5-4-common.h, src/s/unixware.h:
173 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
175 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
177 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
179 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
180 * alloc.c (make_number) [!defined make_number]:
181 Remove, as lisp.h always defines this now.
182 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
183 (roundup_size): Verify that it is a power of 2.
184 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
185 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
186 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
187 -DUSE_LSB_TAG=0, to override the automatically-selected default.
188 USE_LSB_TAG now is always defined to be either 0 or 1.
190 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
191 code works fine either way, and efficiency is not a concern here,
192 as the union type is for debugging, not for production.
193 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
194 Use an inline function on all platforms when using the union type,
195 since this is simpler and 'static inline' can be used portably
197 (LISP_INITIALLY_ZERO): New macro.
198 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
199 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
201 2012-06-12 Glenn Morris <rgm@gnu.org>
203 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
205 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
207 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
208 Move BROKEN_SIGIO to configure.
210 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
211 Move NO_TERMIO to configure.
213 2012-06-12 Chong Yidong <cyd@gnu.org>
215 * image.c (imagemagick_load_image): Use MagickFlattenImage if
216 MagickMergeImageLayers is undefined. Use pixel pusher loop if
217 MagickExportImagePixels is undefined.
219 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
221 * image.c (imagemagick_load_image): Remove unused label.
223 2012-06-11 Glenn Morris <rgm@gnu.org>
225 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
226 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
227 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
228 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
230 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
232 * alloc.c (make_byte_code): New function.
233 (Fmake_byte_code): Use it. Don't purify here.
234 * lread.c (read1): Use it as well to avoid extra allocation.
236 2012-06-11 Chong Yidong <cyd@gnu.org>
238 * image.c (imagemagick_load_image): Implement transparency.
240 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
242 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
243 account for preceding backslashes. (Bug#11663)
245 2012-06-09 Chong Yidong <cyd@gnu.org>
247 * term.c: Support italics in capable terminals (Bug#9652).
248 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
249 (turn_on_face): Output using TS_enter_italic_mode if available.
250 Don't handle unused blinking and alt-charset cases.
251 (turn_off_face): Handle italic case; discard unused tty_blinking_p
252 and tty_alt_charset_p cases.
253 (tty_capable_p, init_tty): Support italics.
255 * termchar.h (struct tty_display_info): Add field for italics.
256 Remove unused blink field.
258 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
261 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
262 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
263 tty_alt_charset_p. Add tty_italic_p.
265 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
267 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
268 dbus_type_is_basic if available.
269 (xd_extract_signed, xd_extract_unsigned): Rename from
270 extract_signed and extract_unsigned, respectively. Adapt callers.
272 2012-06-09 Chong Yidong <cyd@gnu.org>
274 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
276 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
279 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
281 * xdisp.c (vmessage): Treat frame message as multibyte.
282 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
283 would generate the diagnostic "Making \302\247 buffer-local while
286 2012-06-08 Eli Zaretskii <eliz@gnu.org>
288 * dispnew.c (showing_window_margins_p): Undo last change, which
289 was done due to an inadvertent commit.
290 (adjust_frame_glyphs_for_frame_redisplay): Do call
291 showing_window_margins_p.
293 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
295 * eval.c (Fmake_var_non_special): New primitive.
296 (syms_of_eval): Defsubr it.
297 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
299 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
301 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
302 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
304 2012-06-08 Eli Zaretskii <eliz@gnu.org>
306 * alloc.c (allocate_vectorlike): Fix last change.
308 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
310 Block-based vector allocation of small vectors.
311 * lisp.h (struct vectorlike_header): New field `nbytes',
312 adjust comment accordingly.
313 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
314 to denote vector blocks. Adjust users (live_vector_p,
315 mark_maybe_pointer, valid_lisp_object_p) accordingly.
316 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
317 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
318 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
319 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
320 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
321 (roundup_size): New constant.
322 (struct vector_block): New data type.
323 (vector_blocks, vector_free_lists, zero_vector): New variables.
324 (all_vectors): Rename to `large_vectors'.
325 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
326 (sweep_vectors): New functions.
327 (allocate_vectorlike): Return `zero_vector' as the only vector of
328 0 items. Allocate new vector from block if vector size is less than
329 or equal to VBLOCK_BYTES_MAX.
330 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
331 (init_alloc_once): Add call to init_vectors.
333 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
335 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
337 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
339 * doprnt.c (doprnt): Truncate multibyte char correctly.
340 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
341 would mishandle a string argument "Xc" if X was a multibyte
342 character of length 2: it would truncate after X's first byte
343 rather than including all of X.
345 2012-06-06 Chong Yidong <cyd@gnu.org>
347 * buffer.c (word_wrap): Doc fix.
349 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
351 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
353 2012-06-03 Glenn Morris <rgm@gnu.org>
355 * xdisp.c (tool-bar-style): Doc fix.
357 2012-06-03 Ulrich Müller <ulm@gentoo.org>
359 * Makefile.in (PAXCTL): Define.
360 (temacs$(EXEEXT)): Disable memory randomization for the temacs
361 binary via PaX flags if the paxctl utility is available.
362 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
363 Restore PaX flags to their default. (Bug#11398)
365 2012-06-03 Chong Yidong <cyd@gnu.org>
367 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
370 2012-06-03 Chong Yidong <cyd@gnu.org>
372 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
373 (note_mode_line_or_margin_highlight): If there is no help echo,
374 use mode-line-default-help-echo. Handle the case where the mouse
375 position is past the end of the mode line string.
377 * buffer.c (buffer_local_value_1): New function, split from
378 Fbuffer_local_value; can return Qunbound.
379 (Fbuffer_local_value): Use it.
380 (Vmode_line_format): Docstring tweaks.
382 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
384 * sysdep.c (system_process_attributes): Improve comment.
386 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
388 * keyboard.c: Export real-this-command to Elisp.
389 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
390 and DEFVAR it. Update all users.
392 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
394 * minibuf.c (Fassoc_string): Remove duplicate declaration.
396 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
397 Convert pctcpu and pctmem to Lisp float properly.
398 Let the compiler fold better, as 100.0/0x8000 is exact.
400 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
402 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
405 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
407 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
409 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
411 For a 'struct window', replace some Lisp_Object fields to
412 bitfields where appropriate, remove unused fields.
413 * window.h (struct window): Remove unused 'last_mark_x' and
414 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
415 change it's type from Lisp_Object to bitfield.
416 Change type of 'force_start', 'optional_new_start',
417 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
418 fields from Lisp_Object to bitfield. Adjust users accordingly.
420 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
422 Pacify gcc -Wdouble-precision when using Xaw.
423 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
424 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
425 Use 'float' consistently, rather than 'float' in most places
426 and 'double' in a couple of places.
428 2012-05-31 Eli Zaretskii <eliz@gnu.org>
430 * xdisp.c (handle_stop): Detect whether we have overlay strings
431 loaded by testing it->current.overlay_string_index to be
432 non-negative, instead of checking whether n_overlay_strings is
433 positive. (Bug#11587)
435 2012-05-31 Chong Yidong <cyd@gnu.org>
437 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
439 * doc.c (Fsubstitute_command_keys): Doc fix.
441 2012-05-31 Eli Zaretskii <eliz@gnu.org>
443 * search.c (search_buffer): Remove calls to
444 r_alloc_inhibit_buffer_relocation, as it is now called by
445 maybe_unify_char, which was the cause of relocation of buffer text
448 2012-05-31 Eli Zaretskii <eliz@gnu.org>
450 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
451 for the duration of call to load_charset, to avoid problems with
452 callers of maybe_unify_char that access buffer text through C
455 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
456 decrement the inhibition flag, instead of just setting or
459 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
461 Remove obsolete '#define static' cruft.
462 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
463 This #undef was "temporary" in 2000; it is no longer needed
464 now that '#define static' has gone away.
465 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
466 (gray_bitmap_bits): Remove; no longer needed.
467 All uses replaced with definiens.
468 * xterm.c: Include "bitmaps/gray.xbm".
470 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
472 Clean up __executable_start, monstartup when --enable-profiling.
473 The following changes affect the code only when profiling.
474 * dispnew.c (__executable_start): Rename from safe_bcopy.
475 Define only on platforms that need it.
476 * emacs.c: Include <sys/gmon.h> when profiling.
477 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
478 (__executable_start): Remove decl, since lisp.h does it now.
479 (safe_bcopy): Remove decl; no longer has that name.
480 (main): Coalesce #if into single bit of code, for simplicity.
481 Cast pointers to uintptr_t, since standard libraries want integers
483 * lisp.h (__executable_start): New decl.
485 2012-05-31 Glenn Morris <rgm@gnu.org>
487 * image.c (Fimagemagick_types): Doc fix.
489 2012-05-30 Jim Meyering <meyering@redhat.com>
491 * callproc.c (Fcall_process_region): Include directory component
492 in mkstemp error message (Bug#11586).
494 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
496 * alloc.c, lisp.h (make_pure_vector): Now static.
498 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
500 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
502 (Fautoload): Do the hash-doc more carefully.
503 * data.c (Fdefalias): Purify definition, except for keymaps.
504 (Qdefun): Move from eval.c.
505 * lisp.h (Qdefun): Remove.
506 * lread.c (read1): Tiny simplification.
508 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
510 Do not create empty overlays with the evaporate property (Bug#9642).
511 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
512 Bug#9642, but explicitly check that the buffer the overlay would
513 be moved to is live and rearrange lines to make sure that errors
514 will not put the overlay in an inconsistent state.
515 (Fdelete_overlay): Cosmetics.
517 2012-05-28 Eli Zaretskii <eliz@gnu.org>
519 * w32term.c (my_bring_window_to_top): New function.
520 (x_raise_frame): Use handle returned by DeferWindowPos, which
521 could be different from the original one.
522 Call my_bring_window_to_top instead of my_set_foreground_window.
525 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
526 by calling BringWindowToTop.
528 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
529 (WM_EMACS_END): Increase by one.
531 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
533 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
534 This avoids undefined behavior that might cause the eassert
535 to not catch an out-of-range value.
537 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
539 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
542 2012-05-27 Eli Zaretskii <eliz@gnu.org>
544 * bidi.c (bidi_mirror_char): Fix last change.
546 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
548 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
549 when referring to sectname field in printf format.
551 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
553 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
554 Only r_alloc_inhibit_buffer_relocation needed to be added;
555 the others were already declared.
557 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
558 before checking whether it's out of range. Put the check inside
560 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
562 2012-05-27 Ken Brown <kbrown@cornell.edu>
564 * callproc.c (Fcall_process): Restore a line that was accidentally
565 commented out in the 2011-02-13 change (bug#11547).
567 2012-05-27 Eli Zaretskii <eliz@gnu.org>
569 * lisp.h [REL_ALLOC]: Add prototypes for external functions
572 * buffer.c [REL_ALLOC]: Remove prototypes of
573 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
574 they are now on lisp.h.
576 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
578 * search.c (search_buffer): Use it to inhibit relocation of buffer
579 text while re_search_2 is doing its job, because re_search_2 is
580 passed C pointers to buffer text. (Bug#11519)
582 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
585 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
586 state after an additional call to move_it_in_display_line_to, keep
587 the values of it->max_ascent and it->max_descent found for the
589 (pos_visible_p): Revert the comparison against bottom_y to what it
590 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
593 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
595 Fix coding-related core dumps with gcc -ftrapv.
596 The code was computing A - B, where A and B are pointers, and B is
597 random garbage. This can lead to core dumps on platforms that
598 have special pointer registers, and it also leads to core dumps on
599 x86-64 when compiled with gcc -ftrapv. The fix is to compute
600 A - B only when B is initialized properly.
601 * coding.c (coding_set_source, coding_set_destination): Return void.
602 (coding_change_source, coding_change_destinations): New functions,
603 with the old behaviors of coding_set_source and coding_set_destination.
604 All callers that need an offset changed to use these new functions.
606 2012-05-26 Glenn Morris <rgm@gnu.org>
608 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
610 2012-05-26 Eli Zaretskii <eliz@gnu.org>
612 Extend mouse support on W32 text-mode console.
613 * xdisp.c (draw_row_with_mouse_face):
614 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
616 * w32console.c: Include window.h.
617 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
619 (initialize_w32_display): Initialize mouse-highlight data.
621 * w32inevt.c: Include termchar.h and window.h.
622 (do_mouse_event): Support mouse-autoselect-window. When the mouse
623 moves, call note_mouse_highlight. If help_echo changed, call
624 gen_help_event to produce help-echo message in the echo area.
625 Call clear_mouse_face if mouse_face_hidden is set in the mouse
628 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
630 * lread.c (read1): Simplify slightly to avoid an overflow warning
631 with GCC 4.7.0 on x86-64.
633 2012-05-26 Eli Zaretskii <eliz@gnu.org>
635 * bidi.c (bidi_mirror_char): Revert last change: an int is
636 definitely wide enough here.
638 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
640 Fix integer width and related bugs (Bug#9874).
641 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
642 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
643 (string_bytes, check_sblock, allocate_string_data):
644 (compact_small_strings, Fmake_bool_vector, make_string)
645 (make_unibyte_string, make_multibyte_string)
646 (make_string_from_bytes, make_specified_string)
647 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
648 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (allocate_pseudovector):
652 Use int, not EMACS_INT, where int is wide enough.
653 (inhibit_garbage_collection, Fgarbage_collect):
654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
655 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
656 int might not be wide enough.
657 (bidi_cache_search, bidi_cache_find, bidi_init_it)
658 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
659 (bidi_at_paragraph_end, bidi_find_paragraph_start)
660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
661 (bidi_level_of_next_char, bidi_move_to_visually_next):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
664 (Fkill_buffer, Fset_buffer_major_mode)
665 (advance_to_char_boundary, Fbuffer_swap_text)
666 (Fset_buffer_multibyte, overlays_at, overlays_in)
667 (overlay_touches_p, struct sortvec, record_overlay_string)
668 (overlay_strings, recenter_overlay_lists)
669 (adjust_overlays_for_insert, adjust_overlays_for_delete)
670 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
671 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
672 (Foverlay_recenter, last_overlay_modification_hooks_used)
673 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
675 (validate_region): Omit unnecessary test for b <= e,
676 since that's guaranteed by the previous test.
677 (adjust_overlays_for_delete): Avoid pos + length overflow.
678 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
679 (report_overlay_modification):
680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
681 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
682 Omit pointer cast, which isn't needed anyway, and doesn't work
683 after the EMACS_INT -> ptrdiff_t change.
684 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
685 * buffer.h: Adjust decls to match defn changes elsewhere.
686 (struct buffer_text, struct buffer):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 Use EMACS_INT, not int, where int might not be wide enough.
689 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
690 not int, to avoid needless 32-bit limit on 64-bit hosts.
691 (exec_byte_code): Use tighter memory-full test, one that checks
692 for alloca overflow. Don't compute the address of the object just
693 before an array, as that's not portable. Use EMACS_INT, not
694 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
695 * callint.c (Fcall_interactively):
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 * callproc.c (call_process_kill, Fcall_process):
698 Don't assume pid_t fits into an Emacs fixnum.
699 (call_process_cleanup, Fcall_process, child_setup):
700 Don't assume pid_t fits into int.
701 (call_process_cleanup, Fcall_process, delete_temp_file)
702 (Fcall_process_region):
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (Fcall_process): Simplify handling of volatile integers.
705 Use int, not EMACS_INT, where int will do.
706 * casefiddle.c (casify_object, casify_region, operate_on_word)
707 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (casify_object): Avoid integer overflow when overallocating buffer.
710 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
711 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
712 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
713 * category.h (CATEGORYP): Don't assume arg is nonnegative.
714 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
715 integers are now checked earlier. All uses replaced with XINT.
717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
718 For CCL_MapSingle, check that content and value are in int range.
719 (ccl_driver, Fregister_code_conversion_map):
720 Check that Vcode_version_map_vector is a vector.
721 (resolve_symbol_ccl_program): Check that vector header is in range.
722 Always copy the vector, so that we can check its contents reliably
723 now rather than having to recheck each instruction as it's being
724 executed. Check that vector words fit in 'int'.
725 (ccl_get_compiled_code, Fregister_ccl_program)
726 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
727 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
728 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
729 contents are in range.
730 (Fccl_execute_on_string): Check that status is in range.
731 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
732 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
733 Accept and return EMACS_INT, not int, because callers can pass values
735 (c_string_width, strwidth, lisp_string_width, chars_in_text)
736 (multibyte_chars_in_text, parse_str_as_multibyte)
737 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
738 (str_as_unibyte, str_to_unibyte, string_count_byte8)
739 (string_escape_byte8, Fget_byte):
740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
741 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
742 avoid mishandling large integers.
743 * character.h: Adjust decls to match defn changes elsewhere.
744 * charset.c (load_charset_map_from_file, find_charsets_in_text)
745 (Ffind_charset_region):
746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
748 (load_charset_map_from_vector, Fdefine_charset_internal):
749 Don't assume fixnum fits in int.
750 (load_charset_map_from_vector, Fmap_charset_chars):
751 Remove now-unnecessary CHECK_NATNUMs.
752 (Fdefine_charset_internal): Check ranges here, more carefully.
753 Don't rely on undefined behavior with signed left shift overflow.
754 Don't assume unsigned int fits into fixnum, or that fixnum fits
755 into unsigned int. Don't require max_code to be a valid fixnum;
756 that's not true for gb10830 4-byte on a 32-bit host. Allow
757 invalid_code to be a cons, for the same reason. Require code_offset
758 to be a character. Avoid int overflow if max_char is close
760 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
761 this is intended anyway and avoids some undefined behavior.
762 (load_charset_map): Pass unsigned, not int, as 2nd arg of
763 INDEX_TO_CODE_POINT, as that's what it expects.
764 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
765 * charset.h (DECODE_CHAR): Return int, not unsigned;
766 this is what was intended anyway, and it avoids undefined behavior.
767 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
768 integer-overflow issues.
769 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
770 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
771 where the argument is EMACS_INT, and this behavior is not intended.
772 * chartab.c (Fmake_char_table, Fset_char_table_range)
773 (uniprop_get_decoder, uniprop_get_encoder):
774 Don't assume fixnum fits in int.
775 * cmds.c (move_point): New function, that does the gist of
776 Fforward_char and Fbackward_char, but does so while checking
777 for integer overflow more accurately.
778 (Fforward_char, Fbackward_char): Use it.
779 (Fforward_line, Fend_of_line, internal_self_insert)
780 (internal_self_insert):
781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
782 Fix a FIXME, by checking for integer overflow when calculating
783 target_clm and actual_clm.
784 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
785 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
786 (ASSURE_DESTINATION, coding_alloc_by_realloc)
787 (coding_alloc_by_making_gap, alloc_destination)
788 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
789 (encode_coding_utf_16, detect_coding_emacs_mule)
790 (decode_coding_emacs_mule, encode_coding_emacs_mule)
791 (detect_coding_iso_2022, decode_coding_iso_2022)
792 (encode_invocation_designation, encode_designation_at_bol)
793 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
794 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
795 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
796 (encode_coding_ccl, encode_coding_raw_text)
797 (detect_coding_charset, decode_coding_charset)
798 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
799 (produce_composition, produce_charset, produce_annotation)
800 (decode_coding, handle_composition_annotation)
801 (handle_charset_annotation, consume_chars, decode_coding_gap)
802 (decode_coding_object, encode_coding_object, detect_coding_system)
803 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
804 (code_convert_region, code_convert_string)
805 (Fdefine_coding_system_internal)
806 (coding_set_source, coding_set_destination):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
809 (Fdefine_coding_system_internal):
810 Don't assume fixnums fit in int.
811 (decode_coding_gap, decode_coding_object, encode_coding_object)
812 (Fread_coding_system, Fdetect_coding_region)
813 (Funencodable_char_position, Fcheck_coding_systems_region)
814 (get_translation, handle_composition_annotation, consume_chars):
815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
816 (consume_chars): Rewrite to not calculate an address outside buffer.
817 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
818 Don't access memory outside of the args array.
819 (Fdefine_coding_system_internal): Check for charset-id overflow.
820 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
821 result of ENCODE_CHAR.
822 * coding.h: Adjust decls to match defn changes elsewhere.
823 (struct coding_system):
824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
825 * composite.c (get_composition_id, find_composition)
826 (run_composition_function, update_compositions)
827 (compose_text, composition_gstring_put_cache)
828 (composition_gstring_p, composition_gstring_width)
829 (fill_gstring_header, fill_gstring_body, autocmp_chars)
830 (composition_compute_stop_pos, composition_reseat_it)
831 (composition_update_it, struct position_record)
832 (find_automatic_composition, composition_adjust_point)
833 (Fcomposition_get_gstring, Ffind_composition_internal):
834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
835 (update_compositions):
836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
837 * composite.h: Adjust decls to match defn changes elsewhere.
838 (struct composition):
839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
840 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
841 Do not attempt to compute the address of the object just before a
842 buffer; this is not portable.
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 (Faset): Use int, not EMACS_INT, where int is wide enough.
846 (Fstring_to_number): Don't assume fixnums fit in int.
847 (Frem): Don't assume arg is nonnegative.
848 * dbusbind.c (xd_append_arg): Check for integers out of range.
849 (Fdbus_call_method): Don't overflow the timeout int.
850 (extract_signed, extract_unsigned): New functions.
851 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
852 (xd_get_connection_references): Return ptrdiff_t, not int.
854 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
856 Use int, not unsigned, where the dbus API uses int.
857 (Fdbus_message_internal): Don't overflow mtype.
858 (syms_of_dbusbind): Allocate right-sized buffer for integers.
859 * dired.c (directory_files_internal, file_name_completion, scmp)
860 (file_name_completion_stat):
861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
862 (file_name_completion): Don't overflow matchcount.
863 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
864 * dispextern.h: Adjust decls to match defn changes elsewhere.
865 (struct text_pos, struct glyph, struct bidi_saved_info)
866 (struct bidi_string_data, struct bidi_it, struct composition_it)
868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
869 (struct display_pos, struct composition_it, struct it):
870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
871 * dispnew.c (increment_matrix_positions)
872 (increment_row_positions, mode_line_string)
873 (marginal_area_string):
874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
875 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
877 (duration_to_sec_usec): New function, to check for overflow better.
878 (Fsleep_for, sit_for): Use it.
879 * doc.c (get_doc_string, store_function_docstring):
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
881 (get_doc_string, Fsnarf_documentation):
882 Use int, not EMACS_INT, where int is wide enough.
884 Use SAFE_ALLOCA, not alloca.
885 Check for overflow when converting EMACS_INT to off_t.
887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
888 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
889 Don't assume uid_t fits into fixnum.
890 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
891 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
892 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
893 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
894 (general_insert_function)
895 (Finsert_char, make_buffer_string, make_buffer_string_both)
896 (update_buffer_properties, Fbuffer_substring)
897 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
898 (Fsubst_char_in_region, check_translation)
899 (Ftranslate_region_internal, save_restriction_restore, Fformat)
900 (transpose_markers, Ftranspose_regions):
901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
902 (clip_to_bounds): Move to lisp.h as an inline function).
903 (Fconstrain_to_field): Don't assume integers are nonnegative.
904 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
905 (Fsubst_char_in_region, Fsave_restriction):
906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
907 (Femacs_pid): Don't assume pid_t fits into fixnum.
908 (lo_time): Use int, not EMACS_INT, when int suffices.
909 (lisp_time_argument): Check for usec out of range.
910 (Fencode_time): Don't assume fixnum fits in int.
911 (Fuser_login_name, Fuser_full_name): Signal an error
912 if a uid argument is out of range, rather than relying on
914 (Fformat_time_string): Remove now-unnecessary check.
915 lisp_time_argument checks for out-of-range usec now.
916 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
917 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
918 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
919 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
920 (init_cmdargs, Fdump_emacs):
921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
922 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
923 the bottom (typically) 32 bits of the fixnum.
924 * eval.c (specpdl_size, call_debugger):
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 (when_entered_debugger, Fbacktrace_debug):
927 Don't assume fixnum can fit in int.
928 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
929 the object just before a buffer; this is not portable.
930 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
931 (grow_specpdl, unbind_to):
932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
933 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
934 (grow_specpdl): Simplify allocation by using xpalloc.
935 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
936 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
937 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
939 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
942 (Fcopy_file, non_regular_nbytes, read_non_regular)
943 (Finsert_file_contents):
944 Use int, not EMACS_INT, where int is wide enough.
945 (READ_BUF_SIZE): Verify that it fits in int.
946 (Finsert_file_contents): Check that counts are in proper range,
947 rather than assuming fixnums fit into ptrdiff_t etc.
948 Don't assume fixnums fit into int.
949 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
950 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
951 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
952 (string_char_to_byte, string_byte_to_char)
953 (string_make_multibyte, string_to_multibyte)
954 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
955 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
956 (substring_both, Fdelete, internal_equal, Ffillarray)
957 (Fclear_string, mapcar1)
958 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
959 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
960 (larger_vector, make_hash_table, maybe_resize_hash_table)
961 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
962 (Fmaphash, secure_hash):
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 (concat): Check for string index and length overflow.
965 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
968 (larger_vector): New API (vec, incr_min, size_max) replaces old
969 one (vec, new_size, init). This catches size overflow.
970 INIT was removed because it was always Qnil.
972 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
973 the upper bound on a hash table index size.
974 (make_hash_table, maybe_resize_hash_table): Use it.
975 (secure_hash): Computer start_byte and end_byte only after
976 they're known to be in ptrdiff_t range.
977 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
978 (Ffont_get_glyphs, Ffont_at):
979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
980 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
981 (Flist_fonts, Fopen_font):
982 Don't assume fixnum can fit in int.
983 (check_gstring): Don't assume index can fit in int.
984 (font_match_p): Check that fixnum is a character, not a nonnegative
985 fixnum, since the later code needs to stuff it into an int.
986 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
987 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
988 conversion overflow issues.
989 (Fopen_font): Check for integer out of range.
990 (Ffont_get_glyphs): Don't assume index can fit in int.
991 * font.h: Adjust decls to match defn changes elsewhere.
992 * fontset.c (reorder_font_vector): Redo score calculation to avoid
994 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
995 printmax_t, where ptrdiff_t is wide enough.
996 (Finternal_char_font):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
999 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1000 (Fset_frame_position, x_set_frame_parameters)
1001 (x_set_line_spacing, x_set_border_width)
1002 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1003 Check that fixnums are in proper range for system types.
1004 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1006 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1007 Use SAFE_ALLOCA_LISP, not alloca.
1008 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1009 intptr_t is wide enough.
1010 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1011 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1012 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1013 Check for fixnum out of range.
1014 * ftfont.c (ftfont_list): Don't assume index fits in int.
1015 Check that fixnums are in proper range for system types.
1016 (ftfont_shape_by_flt):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1021 Check that fixnums are in proper range for system types.
1022 * gnutls.h: Adjust decls to match defn changes elsewhere.
1023 * gtkutil.c (xg_dialog_run):
1024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1025 (update_frame_tool_bar):
1026 Check that fixnums are in proper range for system types.
1027 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1028 (lookup_image): Check that fixnums are in range for system types.
1029 * indent.c (last_known_column, last_known_column_point):
1030 (current_column_bol_cache):
1031 (skip_invisible, current_column, check_display_width):
1032 (check_display_width, scan_for_column, current_column_1)
1033 (Findent_to, Fcurrent_indentation, position_indentation)
1034 (indented_beyond_p, Fmove_to_column, compute_motion):
1035 (Fcompute_motion, Fvertical_motion):
1036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1037 (last_known_column_modified): Use EMACS_INT, not int.
1038 (check_display_width):
1040 Check that fixnums and floats are in proper range for system types.
1041 (compute_motion): Don't assume index or fixnum fits in int.
1042 (compute_motion, Fcompute_motion):
1043 Use int, not EMACS_INT, when it is wide enough.
1044 (vmotion): Omit local var start_hpos that is always 0; that way
1045 we don't need to worry about overflow in expressions involving it.
1046 * indent.h: Adjust decls to match defn changes elsewhere.
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 Use int, not EMACS_INT, where int is wide enough.
1050 Remove unused members ovstring_chars_done and tab_offset;
1052 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1053 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1054 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1055 (make_gap, copy_text, insert, insert_and_inherit)
1056 (insert_before_markers, insert_before_markers_and_inherit)
1057 (insert_1, count_combining_before, count_combining_after)
1058 (insert_1_both, insert_from_string)
1059 (insert_from_string_before_markers, insert_from_string_1)
1060 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1061 (adjust_after_replace, adjust_after_insert, replace_range)
1062 (replace_range_2, del_range, del_range_1, del_range_byte)
1063 (del_range_both, del_range_2, modify_region)
1064 (prepare_to_modify_buffer, signal_before_change)
1065 (signal_after_change, Fcombine_after_change_execute):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1068 (balance_an_interval, split_interval_right, split_interval_left)
1069 (find_interval, next_interval, update_interval)
1070 (adjust_intervals_for_insertion, delete_node, delete_interval)
1071 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1072 (static_offset_intervals, offset_intervals)
1073 (merge_interval_right, merge_interval_left, make_new_interval)
1074 (graft_intervals_into_buffer, temp_set_point_both)
1075 (temp_set_point, set_point, adjust_for_invis_intang)
1076 (set_point_both, move_if_not_intangible, get_property_and_range)
1077 (get_local_map, copy_intervals, copy_intervals_to_string)
1078 (compare_string_intervals, set_intervals_multibyte_1):
1079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1080 * intervals.h: Adjust decls to match defn changes elsewhere.
1082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1083 * keyboard.c (this_command_key_count, this_single_command_key_start)
1084 (before_command_key_count, before_command_echo_length, echo_now)
1085 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1086 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1087 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1088 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1090 (last_non_minibuf_size, last_point_position, echo_truncate)
1091 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1092 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1093 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1094 (stuff_buffered_input):
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 (last_auto_save, command_loop_1, read_char):
1097 Use EMACS_INT, not int, to avoid integer overflow.
1098 (record_char): Avoid overflow in total_keys computation.
1099 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1100 * keyboard.h: Adjust decls to match defn changes elsewhere.
1101 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1102 (Fkey_description, Fdescribe_vector, Flookup_key):
1103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1104 (click_position): New function, to check that positions are in range.
1105 (Fcurrent_active_maps):
1107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1108 (Faccessible_keymaps, Fkey_description):
1109 (preferred_sequence_p):
1110 Don't assume fixnum can fit into int.
1111 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1112 Check for integer overflow in size calculations.
1113 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1114 avoid mishandling large integers.
1115 * lisp.h: Adjust decls to match defn changes elsewhere.
1116 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1117 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1118 (struct Lisp_Marker):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1121 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1122 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1123 All callers changed.
1124 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1125 Assume the arg has valid form, since it always does.
1126 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1127 unsigned integer system type.
1128 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1129 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1131 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1132 (duration_to_sec_usec): New decl.
1133 * lread.c (read_from_string_index, read_from_string_index_byte)
1134 (read_from_string_limit, readchar, unreadchar, openp)
1135 (read_internal_start, read1, oblookup):
1136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1137 (Fload, readevalloop, Feval_buffer, Feval_region):
1138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1139 (openp): Check for out-of-range argument to 'access'.
1140 (read1): Use int, not EMACS_INT, where int is wide enough.
1141 Don't assume fixnum fits into int.
1142 Fix off-by-one error that can read outside a buffer.
1143 (read_filtered_event): Use duration_to_sec_usec
1144 to do proper overflow checking on durations.
1145 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1146 in size calculation.
1147 (Fexecute_kbd_macro):
1148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1149 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1150 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1151 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1152 (set_marker_both, set_marker_restricted_both, marker_position)
1153 (marker_byte_position, Fbuffer_has_markers_at):
1154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1155 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1156 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1157 It now merely ensures that the menu is large enough, without
1158 necessarily growing it, as this avoids some integer overflow issues.
1159 All callers changed.
1160 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1163 Use SAFE_ALLOCA_LISP, not alloca.
1164 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1165 to EMACS_INT. Check that fixnums are in proper range for system types.
1166 * minibuf.c (minibuf_prompt_width, string_to_object)
1167 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1168 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 (get_minibuffer, read_minibuf_unwind):
1171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1172 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1173 this simplifies overflow checking. All callers changed.
1174 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1177 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1178 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1179 Check that fixnums are in proper range for system types.
1180 (Fx_create_frame, Fx_show_tip):
1181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1182 * nsfont.m (ns_findfonts, nsfont_list_family):
1183 Don't assume fixnum fits in long.
1184 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1186 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1188 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1191 (PRINTDECLARE, PRINTPREPARE):
1192 (strout, print_string):
1193 (print, print_preprocess, print_check_string_charset_prop)
1195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1199 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1200 (printchar, strout): Use xpalloc to catch size calculation overflow.
1201 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1202 (print_error_message): Use SAFE_ALLOCA, not alloca.
1203 (print_object): Use int, not EMACS_INT, where int is wide enough.
1204 (print_depth, new_backquote_output, print_number_index):
1205 Use ptrdiff_t, not int, where int might not be wide enough.
1206 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1207 (Fset_process_window_size, Fformat_network_address)
1208 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1210 Check that fixnums are in proper range for system types.
1211 (Fsignal_process): Simplify by avoiding a goto.
1212 Check for process-ids out of pid_t range rather than relying on
1214 (process_tick, update_tick): Use EMACS_INT, not int.
1215 (Fformat_network_address, read_process_output, send_process)
1216 (Fprocess_send_region, status_notify):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1219 (wait_reading_process_output, read_process_output, exec_sentinel):
1220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1221 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1222 (Faccept_process_output): Use duration_to_sec_usec to do proper
1223 overflow checking on durations.
1224 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1225 Don't assume pid_t fits in int.
1226 * process.h (struct Lisp_Process): Members tick and update_tick
1227 are now of type EMACS_INT, not int.
1228 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1229 configured --with-wide-int.
1230 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1231 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1232 * search.c (looking_at_1, string_match_1):
1233 (fast_string_match, fast_c_string_match_ignore_case)
1234 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1235 (scan_newline, find_before_next_newline, search_command)
1236 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1237 (set_search_regs, wordify):
1240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1241 (string_match_1, search_buffer, set_search_regs):
1243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1244 (wordify): Check for overflow in size calculation.
1245 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1246 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1247 Check that fixnums are in proper range for system types.
1248 * sound.c (struct sound_device)
1249 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1251 (Fplay_sound_internal):
1252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1253 * syntax.c (struct lisp_parse_state, find_start_modiff)
1254 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1255 (Fparse_partial_sexp):
1256 Don't assume fixnums can fit in int.
1257 (struct lisp_parse_state, find_start_pos, find_start_value)
1258 (find_start_value_byte, find_start_begv)
1259 (update_syntax_table, char_quoted, dec_bytepos)
1260 (find_defun_start, prev_char_comend_first, back_comment):
1261 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1262 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 (Finternal_describe_syntax_value): Check that match_lisp is a
1265 character, not an integer, since the code stuffs it into int.
1266 (scan_words, scan_sexps_forward):
1267 Check that fixnums are in proper range for system types.
1269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1270 (scan_sexps_forward):
1271 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1272 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1273 * syntax.h: Adjust decls to match defn changes elsewhere.
1274 (struct gl_state_s):
1275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1276 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1277 MOST_POSITIVE_FIXNUM.
1278 * sysdep.c (wait_for_termination_1, wait_for_termination)
1279 (interruptible_wait_for_termination, mkdir):
1280 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1281 (emacs_read, emacs_write):
1282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1283 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1284 and double all fit in int.
1285 * term.c (set_tty_color_mode):
1286 Check that fixnums are in proper range for system types.
1287 * termhooks.h (struct input_event):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 * textprop.c (validate_interval_range, interval_of)
1290 (Fadd_text_properties, set_text_properties_1)
1291 (Fremove_text_properties, Fremove_list_of_text_properties)
1292 (Ftext_property_any, Ftext_property_not_all)
1293 (copy_text_properties, text_property_list, extend_property_ranges)
1294 (verify_interval_modification):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1296 (Fnext_single_char_property_change)
1297 (Fprevious_single_char_property_change):
1298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1299 (copy_text_properties):
1300 Check for integer overflow in index calculation.
1301 * undo.c (last_boundary_position, record_point, record_insert)
1302 (record_delete, record_marker_adjustment, record_change)
1303 (record_property_change):
1304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1305 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1307 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1308 (Fx_hide_tip, Fx_file_dialog):
1309 * w32menu.c (set_frame_menubar):
1310 Use ptrdiff_t, not int, for consistency with rest of code.
1311 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1312 (select_window, Fdelete_other_windows_internal)
1313 (window_scroll_pixel_based, window_scroll_line_based)
1314 (Frecenter, Fset_window_configuration):
1315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1316 (Fset_window_hscroll, run_window_configuration_change_hook)
1317 (set_window_buffer, temp_output_buffer_show, scroll_command)
1318 (Fscroll_other_window, Frecenter):
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1321 Don't assume fixnum fits in int.
1322 (Fset_window_scroll_bars):
1323 Check that fixnums are in proper range for system types.
1324 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1325 (string_pos, c_string_pos, number_of_chars, init_iterator)
1326 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1327 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1328 (compute_display_string_end, handle_face_prop)
1329 (face_before_or_after_it_pos, handle_invisible_prop)
1330 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1331 (display_prop_intangible_p, string_buffer_position_lim)
1332 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1333 (get_overlay_strings_1, get_overlay_strings)
1334 (iterate_out_of_display_property, forward_to_next_line_start)
1335 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1336 (get_next_display_element, set_iterator_to_next)
1337 (get_visually_first_element, compute_stop_pos_backwards)
1338 (handle_stop_backwards, next_element_from_buffer)
1339 (move_it_in_display_line_to, move_it_in_display_line)
1340 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1341 (add_to_log, message_dolog, message_log_check_duplicate)
1342 (message2, message2_nolog, message3, message3_nolog
1343 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1344 (current_message_1, truncate_echo_area, truncate_message_1)
1345 (set_message, set_message_1, store_mode_line_noprop)
1346 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1347 (text_outside_line_unchanged_p, check_point_in_composition)
1348 (reconsider_clip_changes)
1349 (redisplay_internal, set_cursor_from_row, try_scrolling)
1350 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1351 (redisplay_window, find_last_unchanged_at_beg_row)
1352 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1353 (trailing_whitespace_p, find_row_edges, display_line)
1354 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1355 (display_mode_element, store_mode_line_string)
1356 (pint2str, pint2hrstr, decode_mode_spec)
1357 (display_count_lines, display_string, draw_glyphs)
1358 (x_produce_glyphs, x_insert_glyphs)
1359 (rows_from_pos_range, mouse_face_from_buffer_pos)
1360 (fast_find_string_pos, mouse_face_from_string_pos)
1361 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1363 (safe_call, init_from_display_pos, handle_fontified_prop)
1364 (handle_single_display_spec, load_overlay_strings)
1365 (with_echo_area_buffer, setup_echo_area_for_printing)
1366 (display_echo_area, echo_area_display)
1367 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1368 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1369 (redisplay_window, dump_glyph_row, display_mode_line)
1370 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1371 (handle_display_spec, display_prop_string_p):
1372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1373 (handle_single_display_spec, build_desired_tool_bar_string)
1374 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1375 (get_specified_cursor_type):
1376 Check that fixnums are in proper range for system types.
1377 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1378 (Flookup_image_map):
1379 Don't assume fixnums fit in int.
1380 (compare_overlay_entries):
1381 Avoid mishandling comparisons due to subtraction overflow.
1382 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1383 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1384 (handle_tool_bar_click):
1385 Use int, not unsigned, since we prefer signed and the signedness
1386 doesn't matter here.
1387 (get_next_display_element, next_element_from_display_vector):
1388 Use int, not EMACS_INT, when int is wide enough.
1389 (start_hourglass): Use duration_to_sec_usec to do proper
1390 overflow checking on durations.
1391 * xfaces.c (Fbitmap_spec_p):
1392 Check that fixnums are in proper range for system types.
1393 (compare_fonts_by_sort_order):
1394 Avoid mishandling comparisons due to subtraction overflow.
1395 (Fx_family_fonts, realize_basic_faces):
1396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1398 Don't assume fixnum fits in int.
1399 Use SAFE_ALLOCA_LISP, not alloca.
1400 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1401 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1402 (face_at_buffer_position, face_for_overlay_string)
1403 (face_at_string_position):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1406 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1408 Check that fixnums are in proper range for system types.
1409 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1410 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1412 (Fx_change_window_property): Don't assume fixnums fit in int.
1413 * xfont.c (xfont_chars_supported):
1414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1415 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1416 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1418 * xml.c (parse_region):
1419 * xrdb.c (magic_file_p):
1420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1421 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1422 (x_get_local_selection, x_reply_selection_request)
1423 (x_handle_selection_request, wait_for_property_change):
1424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1425 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1426 short is wide enough.
1427 (x_send_client_event): Don't assume fixnum fits in int.
1428 * xterm.c (x_x_to_emacs_modifiers):
1429 Don't assume EMACS_INT overflows nicely into int.
1430 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1432 (handle_one_xevent): NATNUMP can eval its arg twice.
1433 (x_connection_closed):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1435 * xterm.h: Adjust decls to match defn changes elsewhere.
1436 (struct scroll_bar): Use struct vectorlike_header
1437 rather than rolling our own approximation.
1438 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1440 2012-05-25 Glenn Morris <rgm@gnu.org>
1442 * lisp.mk (lisp): Update for more files being compiled now.
1444 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1446 * lread.c: Remove `read_pure' which makes no difference.
1447 (read_pure): Remove var.
1448 (unreadpure): Remove function.
1449 (readevalloop): Don't call read_list with -1 flag.
1450 (read1, read_vector): Don't test read_pure any more.
1451 (read_list): Simplify.
1453 * fileio.c, character.h: Minor style tweaks.
1455 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1457 * window.h (clip_changed): Remove useless declaration.
1459 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1461 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1462 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1464 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1467 This directory predates autoconf and is no longer needed nowadays.
1468 Move its few remaining bits of functionality to where they're needed.
1469 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1470 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1471 * m/template.h: Remove.
1472 * Makefile.in (M_FILE): Remove. All uses removed.
1473 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1474 * lisp.h (USE_LSB_TAG):
1475 * mem-limits.h (EXCEEDS_LISP_PTR):
1476 Use VAL_MAX, not VALBITS, in #if.
1477 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1478 (EMACS_UINT): Define unconditionally now.
1479 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1480 (BITS_PER_EMACS_INT): New constants, replacing
1481 what used to be in config.h, but not useful in #if.
1482 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1483 define them any more.
1484 (VAL_MAX): New macro.
1486 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1487 BITS_PER_EMACS_INT, in #if.
1488 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1489 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1490 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1491 * s/ms-w32.h (DATA_START):
1492 Move here from removed file m/intel386.h.
1493 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1494 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1496 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1498 Assume C89 or later.
1499 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1500 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1502 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1503 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1504 * textprop.c, tparam.c (NULL): Remove.
1505 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1506 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1507 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1508 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1509 * xterm.c (input_signal_count): Assume volatile works.
1511 2012-05-21 Ken Brown <kbrown@cornell.edu>
1513 * xgselect.c (xg_select): Fix first argument in call to 'select'
1516 2012-05-20 Ken Brown <kbrown@cornell.edu>
1518 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1519 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1521 2012-05-19 Ken Brown <kbrown@cornell.edu>
1523 * xfns.c (x_in_use): Remove `static' qualifier.
1524 * xterm.h (x_in_use): Declare.
1525 * xgselect.c: Include xterm.h.
1526 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1527 and `display_arg' (bug#9754).
1529 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1531 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1533 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1534 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1536 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1538 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1540 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1541 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1543 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1544 reference to image_cache->refcount.
1545 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1547 2012-05-17 Juri Linkov <juri@jurta.org>
1549 * search.c (Fword_search_regexp, Fword_search_backward)
1550 (Fword_search_forward, Fword_search_backward_lax)
1551 (Fword_search_forward_lax): Move functions to isearch.el
1552 (bug#10145, bug#11381).
1554 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1556 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1558 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1560 * lread.c (init_obarray): Declare Qt and Qnil as special.
1562 2012-05-14 Glenn Morris <rgm@gnu.org>
1564 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1565 Put "libexec" before "bin", for the sake of init_callproc_1.
1567 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1569 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1571 * unexaix.c: Port to more-recent AIX compilers.
1572 (report_error, report_error_1, make_hdr, copy_sym)
1573 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1574 Make arguments const char *, not char *, to avoid violations of C
1575 standard and to fix some AIX warnings reported by Gilles Pion.
1577 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1579 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1580 already have overlays loaded.
1581 (handle_single_display_spec): Before returning without displaying
1582 fringe bitmap, synchronize the bidi iterator with the main display
1583 iterator, by calling iterate_out_of_display_property.
1584 (iterate_out_of_display_property): Detect buffer iteration by
1585 testing that it->string is a Lisp string.
1586 (get_next_display_element): When the current object is exhausted,
1587 and there's something on it->stack, call set_iterator_to_next to
1588 proceed with what's on the stack, instead of returning zero.
1589 (set_iterator_to_next): If called at the end of a Lisp string,
1590 proceed to consider_string_end without incrementing string
1591 position. Don't increment display vector index past the end of
1592 the display vector. (Bug#11417)
1593 (pos_visible_p): Don't report a position visible when move_it_to
1594 stopped at the last line of window, which happens to be scanned
1595 backwards by the bidi iteration. (Bug#11464)
1597 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1599 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1600 and right-margin display specs even if the spec is invalid or we
1601 are on a TTY, and thus unable to display on the fringes.
1602 That's because the text with the property will not be displayed anyway,
1603 so we need to signal to the caller that this is a "replacing"
1604 display spec. This fixes display when the spec is invalid or we
1607 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1609 * unexaix.c (make_hdr): Fix typo in prototype.
1610 This bug broke the build on AIX. Problem reported by Gilles Pion.
1612 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1614 * keyboard.c (kbd_buffer_get_event): Read special events also in
1615 batch mode. (Bug#11415)
1617 2012-05-12 Glenn Morris <rgm@gnu.org>
1619 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1621 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1623 * lisp.mk (lisp): Add newcomment.elc.
1625 2012-05-12 Glenn Morris <rgm@gnu.org>
1627 * Makefile.in (MKDIR_P): New, set by configure.
1628 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1630 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1632 Remove unused function hourglass_started.
1633 * dispextern.h (hourglass_started):
1634 * w32fns.c (hourglass_started):
1635 * xdisp.c (hourglass_started): Remove.
1637 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1639 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1640 Update dependencies.
1642 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1644 * xgselect.c (xg_select): Put maxfds+1 into a var.
1645 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1647 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1649 2012-05-10 Dave Abrahams <dave@boostpro.com>
1651 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1652 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1654 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1656 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1657 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1658 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1659 Initialize xd_registered_buses.
1661 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1663 Untag more efficiently if USE_LSB_TAG.
1664 This is based on a proposal by YAMAMOTO Mitsuharu in
1665 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1666 For an admittedly artificial (nth 8000 longlist) benchmark on
1667 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1668 Emacs's overall text size by 1%.
1669 * lisp.h (XUNTAG): New macro.
1670 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1671 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1672 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1673 * eval.c (Fautoload):
1674 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1675 * frame.h (XFRAME): Use XUNTAG.
1677 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1678 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1679 Remove unportable assumptions about print widths of types like
1681 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1682 intptr_t when converting between pointer and integer, to avoid GCC
1683 warnings about wrong width.
1685 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1687 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1688 stack for each reader_thread, instead of defaulting to 8MB
1689 determined by the linker. This avoids failures in creating
1690 subprocesses on Windows 7, see the discussion in this thread:
1691 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1693 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1695 Fix up display of the *Minibuf-0* buffer in the mini window.
1696 * keyboard.c (read_char): Don't clear the echo area if there's no
1698 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1699 contents of *Minibuf-0*) if there's no message displayed in its stead.
1701 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1703 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1706 2012-05-06 Chong Yidong <cyd@gnu.org>
1708 * lisp.mk (lisp): Update.
1710 2012-05-05 Jim Meyering <meyering@redhat.com>
1712 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1714 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1716 * data.c (PUT_ERROR): New macro.
1717 (syms_of_data): Use it. Add new error type `user-error'.
1718 * undo.c (user_error): New function.
1719 (Fprimitive_undo): Use it.
1720 * print.c (print_error_message): Adjust print style for `user-error'.
1721 * keyboard.c (user_error): New function.
1722 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1724 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1726 Do not limit current-time-string to years 1000..9999.
1727 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1728 (Fcurrent_time_string): Support any year that is supported by the
1729 underlying localtime representation. Don't use asctime, as it
1730 has undefined behavior for years outside the range -999..9999.
1732 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1734 Fix race conditions involving setenv, gmtime, localtime, asctime.
1735 Without this fix, interrupts could mess up code that uses these
1736 nonreentrant functions, since setting TZ invalidates existing
1737 tm_zone or tzname values, and since most of these functions return
1738 pointers to static storage.
1739 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1740 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1741 Grow the critical sections to include not just invoking
1742 localtime/gmtime, but also accessing these functions' results
1743 including their tm_zone values if any, and any related TZ setting.
1744 (format_time_string): Last arg is now struct tm *, not struct tm **,
1745 so that the struct tm is saved in the critical section.
1746 All callers changed. Simplify allocation of initial buffer, partly
1747 motivated by the fact that memory allocation needs to be outside
1748 the critical section.
1750 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1752 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1753 with RESET_INTERVAL.
1755 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1756 Remove duplicated buffer name initialization.
1758 2012-05-02 Jim Meyering <jim@meyering.net>
1760 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1762 * xfns.c (x_window): Use xstrdup (Bug#11375).
1764 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1766 * xdisp.c (pos_visible_p): If already at a newline from the
1767 display string before the 'while' loop, don't walk back the glyphs
1768 from it3.glyph_row. Solves assertion violation when the display
1769 string begins with a newline (egg.el). (Bug#11367)
1771 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1776 2012-05-01 Glenn Morris <rgm@gnu.org>
1778 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1779 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1780 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1781 All were removed before 23.1.
1783 * dispnew.c: Remove HAVE_LIBNCURSES test;
1784 it is always true on relevant platforms.
1786 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1787 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1789 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1791 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1793 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1794 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1797 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1799 Do not avoid creating empty evaporating overlays (Bug#9642).
1800 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1801 That is, do not delete an evaporating overlay if it becomes
1802 empty after its bounds are adjusted to fit within its buffer.
1803 This fix caused other problems, and I'm reverting it until we get
1804 to the bottom of them.
1806 2012-04-27 Chong Yidong <cyd@gnu.org>
1808 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1810 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1812 * xdisp.c (pos_visible_p): If the window start position is beyond
1813 ZV, start the display from buffer beginning. Prevents assertion
1814 violation in init_iterator when the minibuffer window is scrolled
1817 * window.c (window_scroll_pixel_based): Likewise.
1819 2012-04-27 Chong Yidong <cyd@gnu.org>
1821 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1823 2012-04-27 Glenn Morris <rgm@gnu.org>
1825 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1826 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1828 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1830 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1831 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1833 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1835 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1836 display element, check also the underlying string or buffer
1837 character. (Bug#11341)
1839 * w32menu.c: Include w32heap.h.
1840 (add_menu_item): If the call to AppendMenuW (via
1841 unicode_append_menu) fails, disable Unicode menus only if we are
1842 running on Windows 9X/Me.
1844 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1846 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1847 (xgetint): Add missing shift for LSB tags.
1849 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1851 * keyboard.c (read_char): Don't wipe echo area for select window
1852 events: These might get delayed via `mouse-autoselect-window'
1855 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1857 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1858 manipulation of :loaded-from data.
1860 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1862 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1863 now a cons (bug#11311).
1865 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1867 Do not create empty overlays with the evaporate property (Bug#9642).
1868 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1869 if it becomes empty after its bounds are adjusted to fit within
1870 its buffer. Without this fix, in a nonempty buffer (let ((o
1871 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1872 yields an empty overlay that has the evaporate property, which is
1873 not supposed to happen.
1875 Fix minor GTK3 problems found by static checking.
1876 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1877 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1878 (struct _EmacsFixedClass, emacs_fixed_get_type):
1879 Move decls here from emacsgtkfixed.h, since they needn't be public.
1880 (emacs_fixed_get_type): Now static.
1881 (emacs_fixed_class_init): Omit unused local.
1882 (emacs_fixed_child_type): Remove; unused.
1883 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1884 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1885 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1886 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1887 (EMACS_FIXED_GET_CLASS): Remove; unused.
1888 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1890 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1891 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1893 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1895 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1896 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1897 (__malloc_size_t, __malloc_ptrdiff_t):
1898 Remove. All uses removed, replaced by the definiens if needed,
1899 since we can assume C89 or better now.
1900 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1901 (protect_malloc_state, align, get_contiguous_space)
1902 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1903 (malloc_atfork_handler_child, malloc_enable_thread)
1904 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1905 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1906 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1907 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1908 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1909 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1910 Define using prototypes, not old style.
1911 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1912 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1913 (align): Don't assume that signed integer overflow wraps around.
1914 Omit unused local var.
1915 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1916 (_free_internal_nolock, memalign, mallochook, reallochook):
1917 Omit no-longer-needed casts.
1918 (valloc): Use getpagesize, not __getpagesize.
1919 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1920 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1922 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1924 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1926 Move functions from C to Lisp. Make non-blocking method calls
1927 the default. Implement further D-Bus standard interfaces.
1929 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1930 (QCdbus_request_name_allow_replacement)
1931 (QCdbus_request_name_replace_existing)
1932 (QCdbus_request_name_do_not_queue)
1933 (QCdbus_request_name_reply_primary_owner)
1934 (QCdbus_request_name_reply_in_queue)
1935 (QCdbus_request_name_reply_exists)
1936 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1937 (QCdbus_registered_serial, QCdbus_registered_method)
1938 (QCdbus_registered_signal): New Lisp objects.
1939 (XD_DEBUG_MESSAGE): Use sizeof.
1940 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1941 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1942 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1943 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1944 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1945 (xd_signature, xd_append_arg): Allow float for integer types.
1946 (xd_get_connection_references): New function.
1947 (xd_get_connection_address): Rename from xd_initialize.
1948 Return cached address.
1949 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1950 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1952 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1953 Return number of refcounts.
1954 (Fdbus_get_unique_name): Make stronger parameter check.
1955 (Fdbus_message_internal): New defun.
1956 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1957 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1958 (Fdbus_send_signal, Fdbus_register_service)
1959 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1960 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1961 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1962 (Vdbus_compiled_version, Vdbus_runtime_version)
1963 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1964 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1965 (Vdbus_message_type_signal): New defvars.
1966 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1969 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1971 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1972 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1973 Do not assume ptrdiff_t is the same width as 'int'.
1975 * alloc.c: Handle unusual debugging option combinations.
1976 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1977 since the two debugging options are incompatible.
1978 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1980 (mem_init, mem_insert, mem_insert_fixup):
1981 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1982 (NEED_MEM_INSERT): Remove; no longer needed.
1984 2012-04-22 Leo Liu <sdl.web@gmail.com>
1986 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1988 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1990 * sysdep.c [__FreeBSD__]: Minor cleanups.
1991 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1992 Use Emacs indenting style more consistently. Avoid some casts.
1993 Use 'double' consistently rather than mixing 'float' and 'double'.
1995 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1997 * sysdep.c (list_system_processes, system_process_attributes):
1998 Add implementation for FreeBSD (Bug#5243).
2000 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2002 * lisp.mk (lisp): Update.
2004 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2006 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2007 It is never used otherwise.
2009 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2011 * print.c (print_preprocess): Only check print_depth if print-circle
2013 (print_object): Check for cycles even when print-circle is nil and
2014 print-gensym is t, but only check print_depth if print-circle is nil.
2016 2012-04-20 Chong Yidong <cyd@gnu.org>
2018 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2019 set the status to "failed" and ensure that sentinel is run.
2021 2012-04-20 Glenn Morris <rgm@gnu.org>
2023 * process.c (Fset_process_inherit_coding_system_flag)
2024 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2025 (Fmake_network_process, Fmake_serial_process): Doc fix.
2027 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2029 * xdisp.c (string_buffer_position_lim): Limit starting position to
2031 (set_cursor_from_row): If called for a mode-line or header-line
2032 row, return zero immediately.
2033 (try_cursor_movement): If inside continuation line, don't back up
2034 farther than the first row after the header line, if any.
2035 Don't consider the header-line row as "partially visible", even if
2036 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2038 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2040 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2043 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2044 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2046 configure: new option --enable-gcc-warnings (Bug#11207)
2047 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2048 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2049 (ALL_CFLAGS): Use new macros rather than old.
2050 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2051 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2052 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2053 -Wunused-result, -Wunused-variable. This should go away once
2054 the Emacs and Gnulib regex code is merged.
2055 (xmalloc, xrealloc): Now static.
2057 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2059 * dired.c (Fsystem_groups): Remove unused local.
2061 2012-04-17 Glenn Morris <rgm@gnu.org>
2063 * dired.c (Fsystem_users): Doc fix.
2065 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2067 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2068 (syms_of_dired): Add them.
2070 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2072 Fix minor alloc.c problems found by static checking.
2073 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2074 New extern decls, to avoid calling undeclared functions.
2075 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2076 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2077 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2078 (NEED_MEM_INSERT): New macro.
2079 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2080 Remove one incorrect comment and fix another.
2082 Fix minor ralloc.c problems found by static checking.
2083 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2084 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2085 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2086 (r_alloc_sbrk): Now static.
2088 Improve ralloc.c interface checking.
2089 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2090 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2091 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2092 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2093 [REL_ALLOC]: ... to here, to check interface.
2094 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2095 Remove decls. This fixes an "It stinks!".
2097 * alloc.c (which_symbols): Fix alignment issue / type clash.
2099 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2101 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2102 (struct Lisp_Misc_Any): Likewise.
2103 (struct Lisp_Free): Likewise.
2104 * alloc.c (union aligned_Lisp_Symbol): Define.
2105 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2106 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2107 (union aligned_Lisp_Misc): Define.
2108 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2109 aligned_Lisp_Misc instead of union Lisp_Misc.
2110 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2112 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2114 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2115 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2116 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2117 * s/netbsd.h, s/sol2-6.h:
2118 Remove definition of GC_MARK_STACK, since the default now works.
2119 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2120 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2121 no longer the default.
2122 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2124 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2126 * lread.c (lisp_file_lexically_bound_p):
2127 Fix hang at ";-*-\n" (bug#11238).
2129 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2131 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2132 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2134 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2136 * nsterm.m (constrainFrameRect): Always constrain when there is only
2137 one screen (Bug#10962).
2139 2012-04-13 Ken Brown <kbrown@cornell.edu>
2141 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2143 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2145 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2147 2012-04-11 Daniel Colascione <dancol@dancol.org>
2149 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2150 against is gone. It's better to use vfork now so that when Cygwin
2151 gains a new, working vfork, we use it automatically (bug#10398).
2153 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2155 * window.c (save_window_save): Obey window-point-insertion-type.
2157 2012-04-11 Glenn Morris <rgm@gnu.org>
2159 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2161 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2163 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2165 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2167 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2168 (force_quit_count): New var.
2169 (handle_interrupt): Use it.
2171 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2173 * w32.c (w32_delayed_load): Record the full path of the library
2174 being loaded (bug#10424).
2176 2012-04-09 Glenn Morris <rgm@gnu.org>
2178 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2179 not just in the obarray, before snarfing them. (Bug#11036)
2181 * Makefile.in ($(leimdir)/leim-list.el):
2182 Pass EMACS rather than BUILT_EMACS.
2184 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2186 * process.c (make_process):
2187 * process.h: Add integer `gnutls_handshakes_tried' member to
2190 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2191 Add convenience `GNUTLS_LOG2i' macro.
2193 * gnutls.c (gnutls_log_function2i): Convenience log function.
2194 (emacs_gnutls_read): Use new log functions,
2195 `gnutls_handshakes_tried' process member, and
2196 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2197 attempts per process (connection).
2199 2012-04-09 Chong Yidong <cyd@gnu.org>
2201 * eval.c (Fuser_variable_p, user_variable_p_eh)
2202 (lisp_indirect_variable): Functions deleted.
2203 (Fdefvar): Caller changed.
2205 * callint.c (Finteractive, Fcall_interactively):
2206 * minibuf.c (Fread_variable): Callers changed.
2208 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2210 * xdisp.c (set_cursor_from_row): If the display string appears in
2211 the buffer at position that is closer to point than the position
2212 after the display string, display the cursor on the first glyph of
2213 the display string. Fixes cursor display when a 'display' text
2214 property immediately follows invisible text. (Bug#11094)
2216 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2218 composite.c: use 'double' consistently
2219 * composite.c (get_composition_id): Use 'double' consistently
2220 instead of converting 'float' to 'double' and vice versa; this is
2221 easier to understand and avoids a GCC warning.
2223 2012-04-09 Glenn Morris <rgm@gnu.org>
2225 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2226 preparation for dumping it with emacs. (Bug#4789)
2227 (leimdir): New variable.
2228 ($(leimdir)/leim-list.el): New rule.
2229 (emacs$(EXEEXT)): Depend on leim-list.el.
2231 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2232 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2233 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2235 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2237 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2240 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2242 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2243 Remove unused local variable.
2245 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2247 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2248 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2249 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2250 objects, as mark_maybe_pointer will catch them otherwise.
2251 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2252 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2254 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2256 Fix typo that broke non-Windows builds.
2257 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2259 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2261 Support building on MS-Windows with libxml2.
2263 * makefile.w32-in (OBJ2): Add xml.$(O).
2264 (GLOBAL_SOURCES): Add xml.c.
2265 ($(BLD)/xml.$(O)): New dependency list.
2267 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2268 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2269 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2270 [!WINDOWSNT]: New macros.
2271 (init_libxml2_functions, libxml2_loaded_p): New functions.
2272 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2273 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2274 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2275 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2277 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2278 Call init_libxml2_functions before calling libxml2 functions.
2279 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2281 * emacs.c: Don't include libxml/parser.h.
2282 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2283 xmlCleanupParser directly.
2285 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2287 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2289 * indent.c (Fvertical_motion): If there is a display string at
2290 point, use it.vpos to compute how many lines to backtrack after
2291 move_it_to point. (Bug#11133)
2293 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2295 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2296 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2297 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2298 macros related to unification of CJK characters. For the details,
2299 see the discussion following the message here:
2300 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2302 2012-04-04 Chong Yidong <cyd@gnu.org>
2304 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2306 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2308 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2309 instead of alloca. (Bug#11138)
2311 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2313 * w32menu.c (is_simple_dialog): Properly check lisp types.
2316 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2318 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2319 position we get to after a call to move_it_to fails the
2320 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2321 only if we wind up in a string from display property. (Bug#11063)
2323 * window.c (Fdelete_other_windows_internal): Invalidate the row
2324 and column information about mouse highlight, so that redisplay
2325 restores it after reallocating the glyph matrices. (Bug#7464)
2327 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2328 string comes from a `display' text property, use the buffer
2329 position of that property as if we actually saw that position in
2331 (move_it_by_lines): Remove the assertion that
2332 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2333 violated when there's a before-string at the beginning of a line.
2336 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2338 * xdisp.c (append_space_for_newline): If the default face was
2339 remapped, use the remapped face for the appended newline.
2340 (extend_face_to_end_of_line): Use the remapped default face for
2341 extending the face to the end of the line.
2342 (display_line): Call extend_face_to_end_of_line when the default
2343 face was remapped. (Bug#11068)
2345 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2347 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2349 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2351 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2353 2012-03-27 Glenn Morris <rgm@gnu.org>
2355 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2358 2012-03-26 Kenichi Handa <handa@m17n.org>
2360 * dispextern.h (struct glyph): Fix previous change. Change the
2361 bit length of glyphless.ch to 25 (Bug#11082).
2363 2012-03-26 Chong Yidong <cyd@gnu.org>
2365 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2366 (command_loop_1): Use it; inhibit selection update for
2367 handle-select-window too (Bug#8996).
2369 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2371 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2373 2012-03-25 Kenichi Handa <handa@m17n.org>
2375 * dispextern.h (struct glyph): Change the bit length of
2376 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2378 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2380 * s/ms-w32.h (tzname): Include time.h before redirecting to
2381 _tzname. Fixes the MSVC build. (Bug#9960)
2383 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2385 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2388 * xterm.c (XTread_socket): Only modify handling_signal if
2389 !SYNC_INPUT. (Bug#11080)
2391 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2393 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2394 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2395 when fetching a multibyte character consumes more bytes than
2396 CHAR_BYTES returns, due to unification of CJK characters in
2397 string_char. (Bug#11073)
2399 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2401 * process.c (wait_reading_process_output): Handle pty disconnect
2402 by refraining from sending oneself a SIGCHLD (bug#10933).
2404 2012-03-22 Chong Yidong <cyd@gnu.org>
2406 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2408 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2409 Mark string as coming from a prefix property.
2410 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2411 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2413 2012-03-21 Chong Yidong <cyd@gnu.org>
2415 * xfaces.c (Vface_remapping_alist): Doc fix.
2417 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2419 * w32proc.c (Fw32_set_console_codepage)
2420 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2423 2012-03-20 Chong Yidong <cyd@gnu.org>
2425 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2426 to reflect default non-nil value of redisplay-dont-pause.
2428 2012-03-19 Kenichi Handa <handa@m17n.org>
2430 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2431 it fit in a valid range (Bug#11003).
2433 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2435 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2436 that is not from display property, accept the row as a "cursor
2437 row" if one of the string's character has a non-nil `cursor'
2438 property. Fixes cursor positioning when there are newlines in
2439 overlay strings, e.g. in icomplete.el. (Bug#11035)
2441 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2443 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2445 2012-03-12 Chong Yidong <cyd@gnu.org>
2447 * eval.c (inhibit_lisp_code): Rename from
2448 inhibit_window_configuration_change_hook; move from window.c.
2450 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2451 * window.c (run_window_configuration_change_hook)
2452 (syms_of_window): Callers changed.
2454 2012-03-11 Chong Yidong <cyd@gnu.org>
2456 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2458 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2460 2012-03-10 Chong Yidong <cyd@gnu.org>
2462 * frame.c (other_visible_frames): Don't assume the selected frame
2463 is visible (Bug#10955).
2465 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2467 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2469 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2471 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2472 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2475 2012-03-03 Glenn Morris <rgm@gnu.org>
2477 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2479 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2481 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2482 position past the first glyph_row that ends at ZV. (Bug#10902)
2483 (redisplay_window, next_element_from_string): Fix typos in
2485 (redisplay_window): Pass to move_it_vertically the margin in
2486 pixels, not in screen lines.
2488 2012-03-02 Glenn Morris <rgm@gnu.org>
2490 * buffer.c (buffer-list-update-hook): Doc fix.
2492 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2494 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2495 push_it before setting up the iterator for the first overlay
2496 string, even if we have an empty string loaded.
2497 (next_overlay_string): If there's an empty string on the iterator
2498 stack, pop the stack. (Bug#10903)
2500 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2502 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2503 Suggested by Stefan Monnier in
2504 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2505 * alloc.c (widen_to_Lisp_Object): New static function.
2506 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2507 and widening them to Lisp_Objects. This would work even if
2508 USE_LSB_TAG is defined and wide integers are used, which might
2509 happen in a future version of Emacs.
2511 2012-02-25 Chong Yidong <cyd@gnu.org>
2513 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2516 * xselect.c (Fx_selection_exists_p): Doc fix.
2517 (x_clipboard_manager_save_all): Print an informative message
2518 before saving to clipboard manager.
2520 2012-02-24 Chong Yidong <cyd@gnu.org>
2522 * keyboard.c (process_special_events): Handle all X selection
2523 requests in kbd_buffer, not just the next one (Bug#8869).
2525 2012-02-23 Chong Yidong <cyd@gnu.org>
2527 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2528 call when setting menu-bar-lines and tool-bar-lines parameters.
2529 (unwind_create_frame_1): New helper function.
2531 * window.c (inhibit_window_configuration_change_hook): New var.
2532 (run_window_configuration_change_hook): Obey it.
2533 (syms_of_window): Initialize it.
2535 2012-02-22 Chong Yidong <cyd@gnu.org>
2537 * xterm.c (x_draw_image_relief): Add missing type check for
2538 Vtool_bar_button_margin (Bug#10743).
2540 2012-02-21 Chong Yidong <cyd@gnu.org>
2542 * fileio.c (Vfile_name_handler_alist): Doc fix.
2544 * buffer.c (Fget_file_buffer): Protect against invalid file
2545 handler return value.
2547 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2549 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2550 when computing $valmask.
2552 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2553 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2554 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2555 It's useless in that case, and it can cause problems on hosts
2556 that allocate halves of EMACS_INT values separately.
2557 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2559 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2560 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2561 it avoids undefined behavior on hosts where shifting right by more
2562 than the word width has undefined behavior.
2564 2012-02-19 Chong Yidong <cyd@gnu.org>
2566 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2567 (Funhandled_file_name_directory, Ffile_name_as_directory)
2568 (Fdirectory_file_name, Fexpand_file_name)
2569 (Fsubstitute_in_file_name): Protect against invalid file handler
2570 return values (Bug#10845).
2572 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2574 * .gdbinit (pitx): Fix incorrect references to fields of the
2577 2012-02-17 Chong Yidong <cyd@gnu.org>
2579 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2581 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2583 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2584 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2586 2012-02-15 Chong Yidong <cyd@gnu.org>
2588 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2589 marked as special. Also, starting docstrings with * is obsolete.
2591 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2593 * gnutls.c (emacs_gnutls_write): Fix last change.
2595 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2597 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2600 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2602 * keymap.c (Fsingle_key_description): Handle char ranges.
2604 2012-02-12 Chong Yidong <cyd@gnu.org>
2606 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2607 as that creates a dangerous corner case.
2609 * window.c (Fdelete_window_internal): Invalidate the mouse
2610 highlight (Bug#9904).
2612 2012-02-12 Glenn Morris <rgm@gnu.org>
2614 * xselect.c (Fx_own_selection_internal)
2615 (Fx_get_selection_internal, Fx_disown_selection_internal)
2616 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2617 * nsselect.m (Fx_own_selection_internal)
2618 (Fx_disown_selection_internal, Fx_selection_exists_p)
2619 (Fx_selection_owner_p, Fx_get_selection_internal):
2620 Sync docs and argument specs with the xselect.c versions.
2622 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2624 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2626 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2628 * w32select.c (Fx_selection_exists_p): Sync doc string and
2629 argument list with xselect.c. (Bug#10783)
2631 * w16select.c (Fx_selection_exists_p): Sync doc string and
2632 argument list with xselect.c. (Bug#10783)
2634 2012-02-10 Glenn Morris <rgm@gnu.org>
2636 * fns.c (Fsecure_hash): Doc fix.
2638 2012-02-09 Kenichi Handa <handa@m17n.org>
2640 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2642 2012-02-07 Chong Yidong <cyd@gnu.org>
2644 * buffer.c (Fbuffer_local_variables)
2645 (buffer_lisp_local_variables): Handle unbound vars correctly;
2646 don't let Qunbound leak into Lisp.
2648 2012-02-07 Glenn Morris <rgm@gnu.org>
2650 * image.c (Fimagemagick_types): Doc fix.
2652 * image.c (imagemagick-render-type): Change it from a lisp object
2653 to an integer. Move the doc here from the lisp manual.
2654 Treat all values not equal to 0 the same.
2656 2012-02-06 Chong Yidong <cyd@gnu.org>
2658 * doc.c (store_function_docstring): Avoid applying docstring of
2659 alias to base function (Bug#2603).
2661 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2663 * .gdbinit (pp1, pv1): Remove redundant defines.
2666 2012-02-04 Chong Yidong <cyd@gnu.org>
2668 * nsterm.m: Declare a global (Bug#10694).
2670 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2672 * w32.c (get_emacs_configuration_options):
2673 Include --enable-checking, if specified, in the return value.
2675 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2677 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2678 after rounding frame sizes. (Bug#9723)
2680 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2682 * keyboard.c (adjust_point_for_property): Don't position point
2683 before BEGV. (Bug#10696)
2685 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2687 Handle overflow when computing char display width (Bug#9496).
2688 * character.c (char_width): Return EMACS_INT, not int.
2689 (char_width, c_string_width): Check for overflow when
2690 computing the width; this is possible now that individual
2691 characters can have unbounded width. Problem introduced
2692 by merge from Emacs 23 on 2012-01-19.
2694 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2696 * dbusbind.c (Fdbus_register_method): Mention the return value
2697 :ignore in the docstring.
2699 2012-02-02 Glenn Morris <rgm@gnu.org>
2701 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2704 Unconditionally set to t. (Bug#10673)
2705 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2706 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2707 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2709 2012-02-02 Kenichi Handa <handa@m17n.org>
2711 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2712 0, do not call append_composite_glyph.
2714 2012-02-02 Kenichi Handa <handa@m17n.org>
2716 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2718 (x_produce_glyphs): If the component of a composition is a null
2719 string, set it->pixel_width to 1 to avoid zero-width glyph.
2721 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2723 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2724 first 2 arguments are identical. This makes inserting large
2725 output from a subprocess an order of magnitude faster on
2726 MS-Windows, where all sbrk'ed memory is always contiguous.
2728 2012-01-31 Glenn Morris <rgm@gnu.org>
2730 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2731 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2732 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2734 2012-01-29 Glenn Morris <rgm@gnu.org>
2736 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2738 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2740 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2742 2012-01-28 Chong Yidong <cyd@gnu.org>
2744 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2746 2012-01-26 Chong Yidong <cyd@gnu.org>
2748 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2750 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2751 repeat counts (Bug#10507).
2753 2012-01-26 Glenn Morris <rgm@gnu.org>
2755 * lread.c (syms_of_lread): Doc fix.
2757 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2759 * coding.c (encode_designation_at_bol): Change return value to
2762 2012-01-25 Chong Yidong <cyd@gnu.org>
2764 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2766 2012-01-21 Chong Yidong <cyd@gnu.org>
2768 * floatfns.c (Fcopysign): Make the second argument non-optional,
2769 since nil is not allowed anyway.
2771 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2773 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2774 (send_process): Likewise.
2776 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2778 * window.c (save_window_save, Fcurrent_window_configuration)
2779 (Vwindow_persistent_parameters): Do not use Qstate.
2780 Rewrite doc-strings.
2782 2012-01-19 Kenichi Handa <handa@m17n.org>
2784 * character.c (char_width): New function.
2785 (Fchar_width, c_string_width, lisp_string_width):
2786 Use char_width (Bug#9496).
2788 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2790 * window.c (Vwindow_persistent_parameters): New variable.
2791 (Fset_window_configuration, save_window_save): Handle persistent
2794 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2796 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2797 thrashing the stack of the thread. (Bug#9087)
2799 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2801 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2803 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2805 * xdisp.c (rows_from_pos_range): Handle the case where the
2806 highlight ends on a newline. (Bug#10464)
2807 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2808 he end column for display of highlight that ends on a newline
2811 2012-01-11 Glenn Morris <rgm@gnu.org>
2813 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2814 from load-path also when installation-directory is nil. (Bug#10208)
2816 2012-01-10 Glenn Morris <rgm@gnu.org>
2818 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2820 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2821 Update template values to be closer to their typical values these days.
2823 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2825 * xdisp.c (rows_from_pos_range): Accept additional argument
2826 DISP_STRING, and accept any glyph in a row whose object is that
2827 string as eligible for mouse highlight. Fixes mouse highlight of
2828 display strings from overlays. (Bug#10464)
2830 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2832 emacs: fix an auto-save permissions race condition (Bug#10400)
2833 * fileio.c (auto_saving_dir_umask): New static var.
2834 (Fmake_directory_internal): Use it.
2835 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2836 creating the directory. The old code temporarily assigns
2837 too-generous permissions to the directory.
2838 (do_auto_save_eh): Clear it.
2839 (Fdo_auto_save): Catch all errors, not just file errors, so
2840 that the var is always cleared.
2842 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2844 * search.c (scan_buffer): Pass character positions to
2845 know_region_cache, not byte positions. (Bug#6540)
2847 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2849 * w32.c (sys_rename): Report EXDEV when rename of a directory
2850 fails because the target is on another logical disk. (Bug#10284)
2852 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2854 * xterm.c (x_embed_request_focus): New function.
2856 * xterm.h: Add prototype.
2858 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2860 2012-01-05 Glenn Morris <rgm@gnu.org>
2862 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2864 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2866 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2867 Load gnutls_transport_set_lowat only if GnuTLS version is below
2869 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2870 GnuTLS versions below 2.11.1.
2872 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2874 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2875 to the doc string advising against its use for altering the way
2876 windows are scrolled.
2878 2011-12-28 Kenichi Handa <handa@m17n.org>
2880 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2881 coding-system ASCII compatible only when it does not produce BOM
2882 on encoding (Bug#10383).
2884 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2886 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2888 (create_and_show_popup_menu): Always use menu_position_func for
2891 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2893 * callint.c (Fcall_interactively): Don't truncate prompt string.
2895 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2897 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2898 property that ends at ZV, so that the bidi iteration could be
2899 resumed from there (after widening). (Bug#10360)
2901 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2903 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2905 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2907 * nsterm.m (x_free_frame_resources):
2908 Release f->output_data.ns->miniimage.
2909 (ns_index_color): Fix indentation. Do not retain
2910 color_table->colors[i].
2912 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2915 * nsfns.m (x_set_background_color): Assign return value from
2916 ns_index_color to face-background instead of NSColor*.
2917 (ns_implicitly_set_icon_type): Fix indentation.
2918 Change assignment in for loop to comparison.
2920 * emacs.c (ns_pool): New variable.
2921 (main): Assign ns_pool.
2922 (Fkill_emacs): Call ns_release_autorelease_pool.
2924 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2925 autorelease fdesc, release fdAttrs and tdict.
2926 (ns_get_covering_families): Release charset.
2927 (ns_findfonts): Release NSFontDescriptor created with new.
2928 (ns_uni_to_glyphs): Fix indentation.
2929 (setString): Release attrStr before assigning new value.
2931 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2933 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2935 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2936 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2938 2011-12-18 David Reitter <reitter@cmu.edu>
2940 * nsterm.m (ns_term_init): Subscribe for notifications
2941 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2942 to method trackingNotification in EmacsMenu.
2944 * nsmenu.m (trackingMenu): New variable.
2945 (trackingNotification): New method (from Aquamacs).
2946 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2947 from Aquamacs (Bug#7030).
2949 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2951 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2952 (symbol_to_nsstring): Fix indentation.
2953 (ns_symbol_to_pb): New function.
2954 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2955 (Fns_rotate_cut_buffers_internal): Remove.
2956 (Fns_store_selection_internal): Rename from
2957 Fns_store_cut_buffer_internal.
2958 (ns_get_foreign_selection, Fx_own_selection_internal)
2959 (Fx_disown_selection_internal, Fx_selection_exists_p)
2960 (Fns_get_selection_internal, Fns_store_selection_internal):
2961 Use ns_symbol_to_pb and check if return value is nil.
2962 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2963 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2964 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2965 renamed to Sns_store_selection_internal.
2966 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2967 and remove this function.
2968 (ns_handle_selection_clear): Remove, never used.
2969 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2972 2011-12-17 Ken Brown <kbrown@cornell.edu>
2974 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2975 GID is unknown (Bug#10257).
2977 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2979 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2980 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2981 which caused a build failure on GNU/Linux IA-64. This problem was
2982 introduced by my 2011-10-07 patch.
2984 2011-12-15 Juri Linkov <juri@jurta.org>
2986 * image.c (imagemagick_error): New function. (Bug#10112)
2987 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2988 Use `imagemagick_error' where ImageMagick functions return
2990 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2993 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2995 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2996 fill background (Bug#8992).
2998 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3000 * window.c (Vwindow_combination_resize)
3001 (Vwindow_combination_limit): Use t instead of non-nil in
3003 (Vrecenter_redisplay): Add first sentence of doc-string on
3005 (Frecenter): Fix doc-string typo.
3007 2011-12-11 Kenichi Handa <handa@m17n.org>
3009 * coding.c (Funencodable_char_position): Pay attention to the
3010 buffer text relocation (Bug#9389).
3012 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3014 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3015 gtk_init (Bug#10100).
3017 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3019 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3020 IT->string is nil. (Bug#10263)
3022 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3024 * nsterm.h (x_free_frame_resources): Declare.
3026 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3027 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3029 * nsterm.h (ns_get_defaults_value): Declare.
3031 * nsterm.m (ns_default): Call ns_get_defaults_value.
3033 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3035 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3038 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3040 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3041 that where the value of an _OBJC_* symbol points to is in the .bss
3042 section (Bug#10240).
3044 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3046 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3047 after the loop to call ccl_driver at least once (Bug#8619).
3049 2011-12-08 Kenichi Handa <handa@m17n.org>
3051 * ftfont.c (get_adstyle_property): Fix previous change
3054 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3056 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3057 dirs from the default value of EMACSLOADPATH (bug#10208).
3059 2011-12-07 Glenn Morris <rgm@gnu.org>
3061 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3062 installation and source directories as well. (Bug#10208)
3064 2011-12-06 Chong Yidong <cyd@gnu.org>
3066 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3068 2011-12-06 Glenn Morris <rgm@gnu.org>
3070 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3071 as an error, not just -1. (Bug#10217)
3073 2011-12-05 Chong Yidong <cyd@gnu.org>
3075 * keyboard.c (process_special_events): New function.
3076 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3078 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3080 * coding.c (encode_designation_at_bol): Don't use uninitialized
3081 local variable (Bug#9318).
3083 2011-12-05 Kenichi Handa <handa@m17n.org>
3085 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3086 return Qnil (Bug#8046, Bug#10193).
3088 2011-12-05 Kenichi Handa <handa@m17n.org>
3090 * coding.c (encode_designation_at_bol): New args charbuf_end and
3091 dst. Return the number of produced bytes. Callers changed.
3092 (coding_set_source): Return how many bytes coding->source was
3094 (coding_set_destination): Return how many bytes
3095 coding->destination was relocated.
3096 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3097 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3099 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3101 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3102 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3105 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3107 The following changes are to fix Bug#9318.
3109 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3110 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3111 (encode_coding_iso_2022, encode_coding_sjis)
3112 (encode_coding_big5, encode_coding_charset): Use the above macros.
3114 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3116 * lisp.h (process_quit_flag): Fix external declaration.
3118 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3120 Don't macro-inline non-performance-critical code.
3121 * eval.c (process_quit_flag): New function.
3122 * lisp.h (QUIT): Use it.
3124 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3126 * nsfns.m (get_geometry_from_preferences): New function.
3127 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3129 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3131 * emacs.c (Qkill_emacs): Define.
3132 (syms_of_emacs): Initialize it.
3133 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3134 Qquit_flag to `kill-emacs' instead.
3135 (quit_throw_to_read_char): Add parameter `from_signal'.
3136 All callers changed. Call Fkill_emacs if requested and safe.
3137 * lisp.h (QUIT): Call Fkill_emacs if requested.
3139 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3141 * widget.c (update_wm_hints): Return if wmshell is null.
3142 (widget_update_wm_size_hints): New function.
3144 * widget.h (widget_update_wm_size_hints): Declare.
3146 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3147 widget_update_wm_size_hints (Bug#10104).
3149 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3152 before a newline, prepare the bidi iterator for consuming the
3153 newline, and keep the current paragraph direction. (Bug#10183)
3154 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3156 2011-12-02 Juri Linkov <juri@jurta.org>
3158 * search.c (Fword_search_regexp): New Lisp function created from
3159 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3160 (Fword_search_backward, Fword_search_forward)
3161 (Fword_search_backward_lax, Fword_search_forward_lax):
3162 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3163 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3165 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3167 * fileio.c (Finsert_file_contents): Move after-change-function call
3168 to before the "handled:" label, since all "goto handled" appear in
3169 cases where the *-change-functions have already been properly called
3172 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3174 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3175 waiting for input. (Bug#10169)
3177 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3179 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3180 verifies glyph row's hash code--we have just reallocated the
3181 glyphs, so their contents can be complete garbage. (Bug#10164)
3183 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3185 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3187 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3189 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3190 attributes are tested _before_ calling verify_row_hash, to protect
3191 against GCC re-ordering of the tests. (Bug#10164)
3193 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3195 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3197 * xterm.c (handle_one_xevent): Only set async_visible and friends
3198 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3199 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3200 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3202 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3204 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3205 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3206 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3207 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3208 All uses changed to use GCPRO1 etc.
3209 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3210 Revert to old implementation (i.e., before 2011-03-11).
3212 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3214 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3215 of scroll runs so as to avoid assigning disabled bogus rows and
3216 unnecessary graphics copy operations.
3218 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3220 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3221 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3222 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3223 (malloc, free, realloc, calloc): Redirect to e_* only when
3226 * lisp.h (GCTYPEBITS): Move before first use.
3227 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3228 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3229 this macro definition.
3231 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3234 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3236 * gtkutil.c (xg_create_frame_widgets):
3237 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3238 present with Gtk+ 2.0.
3240 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3242 * fileio.c (Finsert_file_contents): Undo previous change; see
3243 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3245 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3247 Rename locals to avoid shadowing.
3248 * fileio.c (Finsert_file_contents):
3249 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3250 * process.c (wait_reading_process_output):
3251 Rename inner 'proc' to 'p' to avoid shadowing.
3252 Indent for consistency with usual Emacs style.
3254 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3256 * xdisp.c (redisplay_window): If cursor row is not fully visible
3257 after recentering, and scroll-conservatively is set to a large
3258 number, scroll window by a few more lines to make the cursor fully
3259 visible and out of scroll-margin. (Bug#10105)
3260 (start_display): Don't move to the next line if the display should
3261 start at a newline that is part of a display vector or an overlay
3264 2011-11-24 Juri Linkov <juri@jurta.org>
3266 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3267 after the `MagickPingImage' call. (Bug#10112)
3269 2011-11-23 Chong Yidong <cyd@gnu.org>
3271 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3273 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3275 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3276 making another buffer current. (Bug#10114)
3278 2011-11-23 Glenn Morris <rgm@gnu.org>
3280 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3282 2011-11-23 Chong Yidong <cyd@gnu.org>
3284 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3285 using it (Bug#5984).
3287 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3289 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3290 and header-lines, as they don't have one computed for them.
3293 * .gdbinit (prow): Make displayed values more self-explaining.
3294 Add row's hash code.
3296 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3298 * process.c (wait_reading_process_output): Fix asynchrounous
3299 GnuTLS socket handling on some versions of the GnuTLS library.
3300 (wait_reading_process_output): Add comment and URL.
3302 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3304 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3306 2011-11-21 Chong Yidong <cyd@gnu.org>
3308 * window.c (Fnext_window, Fprevious_window): Doc fix.
3310 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3312 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3314 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3316 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3318 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3320 * window.c (Fset_window_combination_limit): Rename argument
3322 (Vwindow_combination_limit): Remove "status" from doc-string.
3324 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3326 * m/ibms390.h: Remove.
3327 * m/ibms390x.h: Don't include "ibms390.h".
3329 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3331 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3332 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3334 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3336 * casetab.c (Fset_case_table):
3337 * charset.c (Fcharset_after): Fix typos.
3339 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3341 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3342 Otherwise, valgrind does not work on some platforms.
3343 Problem reported by Andreas Schwab in
3344 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3345 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3346 is set, removing the need for VIRT_ADDRESS_VARIES.
3347 (PURE_P): Use a more-efficient implementation that needs just one
3348 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3349 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3350 to 4 (xorl, subq, cmpq, setbe).
3351 * alloc.c (pure): Always extern now, since that's the
3352 VIRT_ADDR_VARIES behavior.
3353 (PURE_POINTER_P): Use a single comparison, not two, for
3354 consistency with the new puresize.h.
3355 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3356 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3357 Remove VIRT_ADDR_VARIES no longer needed.
3359 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3361 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3362 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3363 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3364 behave as if the cursor position were at the window margin.
3366 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3367 and the cursor position is out of bounds, behave as if the cursor
3368 position were at the window margin. (Bug#10075)
3370 2011-11-18 Chong Yidong <cyd@gnu.org>
3372 * window.c (Fwindow_combination_limit): Make first argument
3373 non-optional, since it is meaningless for live windows like the
3376 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3378 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3380 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3382 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3383 (graft_intervals_into_buffer): Simplify.
3385 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3387 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3388 hash values of the two rows.
3389 (copy_row_except_pointers): Preserve the used[] arrays and the
3390 hash values of the two rows. (Bug#10035)
3391 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3393 * xdisp.c (row_hash): New function, body extracted from
3394 compute_line_metrics.
3395 (compute_line_metrics): Call row_hash, instead of computing the
3398 * dispnew.c (verify_row_hash): Call row_hash for computing the
3399 hash code of a row, instead of duplicating code from xdisp.c.
3401 * dispextern.h (row_hash): Add prototype.
3403 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3405 * frame.c (delete_frame): Don't delete the terminal when the last
3406 X frame is closed if emacs is built with GTK toolkit.
3408 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3410 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3412 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3414 * window.c (Vwindow_splits): Rename to
3415 Vwindow_combination_resize. Suggested by Juri Linkov.
3416 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3419 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3421 * nsfns.m (Fns_font_name):
3422 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3424 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3426 * window.h (window): Rename slot "nest" to "combination_limit".
3427 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3428 (Fset_window_nest): Rename to Fset_window_combination_limit.
3429 (Vwindow_nest): Rename to Vwindow_combination_limit.
3430 (recombine_windows, make_parent_window, make_window)
3431 (Fsplit_window_internal, saved_window)
3432 (Fset_window_configuration, save_window_save): Rename all
3433 occurrences of window_nest to window_combination_limit.
3435 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3437 * image.c (imagemagick_load_image): Fix typo.
3439 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3441 * xdisp.c (display_line): Move the call to
3442 highlight_trailing_whitespace before the call to
3443 compute_line_metrics, since the latter needs to see the final
3444 faces of all the glyphs to compute ROW's hash value.
3445 Fixes assertion violations in row_equal_p. (Bug#10035)
3447 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3449 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3450 just return (bug#10044).
3452 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3454 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3455 with user-defined heap size. Bump the default size of the temacs
3456 heap to 27MB, to avoid memory warning when running temacs.
3457 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3459 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3460 current_matrix and desired_matrix. (Bug#9990)
3461 (verify_row_hash) [XASSERTS]: New function.
3462 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3463 that the hash value of glyph rows is correct.
3465 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3467 * window.h (window): Remove splits slot.
3468 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3469 (Fdelete_other_windows_internal, make_parent_window)
3470 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3471 (Fset_window_configuration, save_window_save): Don't deal with
3472 split status of windows.
3473 (saved_window): Remove splits slot.
3474 (Vwindow_splits): Rewrite doc-string.
3476 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3478 * xfns.c (unwind_create_frame):
3479 * nsfns.m (unwind_create_frame):
3480 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3481 Vframe_list (Bug#9999).
3483 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3485 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3487 2011-11-11 Kenichi Handa <handa@m17n.org>
3489 * callproc.c (Fcall_process): Set the member dst_multibyte of
3492 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3494 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3495 avoid a crash (bug#9496).
3497 2011-11-09 Chong Yidong <cyd@gnu.org>
3499 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3500 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3502 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3504 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3506 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3508 Avoid some portability problems by eschewing 'extern inline' functions.
3509 The trivial performance wins aren't worth the portability hassles; see
3510 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3512 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3513 (window_box_width, window_box_left, window_box_left_offset)
3514 (window_box_right, window_box_right_offset): Undo previous change,
3515 by removing the "extern"s.
3516 * intervals.c (adjust_intervals_for_insertion)
3517 (adjust_intervals_for_deletion): Undo previous change,
3518 making these static again.
3519 (offset_intervals, temp_set_point_both, temp_set_point)
3520 (copy_intervals_to_string): No longer inline.
3521 * xdisp.c (window_text_bottom_y, window_box_width)
3522 (window_box_height, window_box_left_offset)
3523 (window_box_right_offset, window_box_left, window_box_right)
3524 (window_box): No longer inline.
3526 2011-11-08 Chong Yidong <cyd@gnu.org>
3528 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3529 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3530 Signal an error if not a live window.
3531 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3532 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3534 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3536 * lisp.h (syms_of_abbrev): Remove declaration.
3537 Reported by CHENG Gao <chenggao@royau.me>.
3539 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3541 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3542 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3543 of temacs in GUI mode.
3545 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3547 * window.h: Declare delete_all_child_windows instead of
3548 delete_all_subwindows.
3549 * window.c (Fwindow_nest, Fset_window_nest)
3550 (Fset_window_new_total, Fset_window_new_normal)
3551 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3552 (delete_all_subwindows): Rename to delete_all_child_windows.
3553 (Fdelete_other_windows_internal, Fset_window_configuration):
3554 Call delete_all_child_windows instead of delete_all_subwindows.
3555 * frame.c (delete_frame): Call delete_all_child_windows instead
3556 of delete_all_subwindows.
3558 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3560 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3561 This is also needed for porting to any host where GC_MARK_STACK is
3562 not GC_MAKE_GCPROS_NOOPS.
3563 (which_symbols): Use it.
3565 2011-11-07 Kenichi Handa <handa@m17n.org>
3567 * coding.c (coding_set_destination): Check coding->src_pos only
3568 when coding->src_object is a buffer (bug#9910).
3570 * process.c (send_process): Set the member src_multibyte of coding
3571 to 0 (bug#9911) when sending a unibyte text.
3573 * callproc.c (Fcall_process): Set the member src_multibyte of
3574 process_coding to 0 (bug#9912).
3576 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3578 * xmenu.c (cleanup_widget_value_tree): New function.
3579 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3580 calling free_menubar_widget_value_tree directly (Bug#9830).
3582 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3584 Fix some portability problems with 'inline'.
3585 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3586 (window_box_width, window_box_left, window_box_left_offset)
3587 (window_box_right, window_box_right_offset): Declare extern.
3588 Otherwise, these inline functions do not conform to C99 and
3589 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3590 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3591 * intervals.c (adjust_intervals_for_insertion)
3592 (adjust_intervals_for_deletion): Now extern, because otherwise the
3593 extern inline functions 'offset_intervals' couldn't refer to it.
3594 (static_offset_intervals): Remove.
3595 (offset_intervals): Rewrite using the old contents of
3596 static_offset_intervals. The old version didn't conform to C99
3597 because an extern inline function contained a reference to an
3598 identifier with static linkage.
3600 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3602 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3605 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3608 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3609 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3610 return Qleft_to_right.
3612 2011-11-06 Chong Yidong <cyd@gnu.org>
3614 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3615 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3616 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3617 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3618 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3619 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3620 (Fwindow_vscroll): Doc fix.
3621 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3622 argument, since it makes no sense to pass a live window and for
3623 consistency with window-child.
3625 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3627 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3630 2011-11-05 Jason Rumney <jasonr@gnu.org>
3632 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3633 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3635 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3636 bitwise arithmetic preventing use of unicode-sip and non-truetype
3639 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3641 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3644 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3645 initialization code to keep similarity to xfns.c after changes
3648 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3650 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3651 (unwind_create_frame): New function (Bug#9943).
3652 (Fx_create_frame): Restructure code to be more similar to the one in
3653 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3654 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3655 Move terminal->reference_count++ just before making the frame official
3658 * nsterm.m (x_free_frame_resources): New function.
3659 (x_destroy_window): Move code to x_free_frame_resources.
3661 * xfns.c (unwind_create_frame): Fix comment.
3662 (Fx_create_frame, x_create_tip_frame):
3663 Move terminal->reference_count++ just before making the frame
3664 official. Move initialization of image_cache_refcount and
3665 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3667 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3669 Support MSVC build with newer versions of Visual Studio.
3670 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3671 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3674 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3675 which are not supported by MSVC.
3676 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3677 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3679 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3681 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3683 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3685 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3687 Support MSVC build with newer versions of Visual Studio.
3688 * w32.c: Don't include w32api.h for MSVC.
3689 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3691 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3692 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3693 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3694 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3696 (alloca) [_MSC_VER]: Define to _alloca.
3698 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3700 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3702 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3704 * xdisp.c (note_mouse_highlight): If either of
3705 previous/next-single-property-change returns nil, treat that as
3706 the beginning or the end of the buffer. (Bug#9955)
3708 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3710 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3711 label is not null (Bug#9951).
3712 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3715 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3717 * window.c (Fwindow_body_size): Mention in the doc string that the
3718 return value is in frame's canonical units. (Bug#9949)
3720 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3722 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3724 * w32fns.c (unwind_create_frame): If needed, free the glyph
3725 matrices of the partially constructed frame. (Bug#9943)
3726 * xfns.c (unwind_create_frame): Likewise.
3728 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3730 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3731 Don't stop backward scan on the continuation glyph, even though
3732 its CHARPOS is positive.
3733 (mouse_face_from_buffer_pos, note_mouse_highlight):
3734 Rename cover_string to disp_string.
3736 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3738 * window.c (temp_output_buffer_show): Don't use
3739 Vtemp_buffer_show_specifiers.
3740 (Vtemp_buffer_show_specifiers): Remove unused variable.
3742 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3744 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3745 past the beginning of the current glyph matrix.
3747 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3749 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3750 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3751 HAVE_GTK3 (Bug#9869).
3753 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3754 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3756 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3758 * xterm.c: Declare x_handle_net_wm_state to return int.
3759 (handle_one_xevent): Check if we are iconified but don't have
3760 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3761 (get_current_wm_state): Return non-zero if not hidden,
3762 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3763 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3764 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3765 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3767 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3769 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3770 so that this new function doesn't get optimized away by a
3771 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3773 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3775 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3777 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3779 Fix the `xbytecode' command.
3780 * .gdbinit (xprintbytestr): New command.
3781 (xwhichsymbols): Rename from `which'; all callers changed.
3782 (xbytecode): Print the byte-code string as well.
3784 2011-10-29 Kim Storm <storm@cua.dk>
3786 * alloc.c (which_symbols): New function.
3788 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3790 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3793 2011-10-29 Glenn Morris <rgm@gnu.org>
3795 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3796 Not clear what it was for, and it causes various bugs. (Bug#9839)
3798 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3800 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3801 possible random value that matches one of those tested as
3802 condition to clear the mouse face.
3804 2011-10-28 Chong Yidong <cyd@gnu.org>
3806 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3808 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3810 * window.c (make_window): Initialize phys_cursor_on_p.
3812 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3814 * lisp.h (struct Lisp_Symbol): Update comments.
3816 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3818 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3820 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3822 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3823 <oslsachem@gmail.com> for helping to debug this.
3825 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3826 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3827 (g_b_init_get_glyph_outline_w): New static variables.
3828 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3829 (GetGlyphOutlineW_Proc): New typedefs.
3830 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3831 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3833 (w32font_open_internal, compute_metrics):
3834 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3835 instead of calling the "wide" APIs directly.
3837 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3839 * w32.h (syms_of_w32font): Add prototype.
3841 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3843 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3844 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3845 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3846 (Fmove_to_window_line): Doc fix.
3848 2011-10-27 Chong Yidong <cyd@gnu.org>
3850 * process.c (make_process): Set gnutls_state to NULL.
3852 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3853 non-NULL, regardless of GNUTLS_INITSTAGE.
3854 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3855 an error. Set process slots as soon as we allocate them.
3857 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3859 2011-10-27 Chong Yidong <cyd@gnu.org>
3861 * gnutls.c (emacs_gnutls_deinit): New function.
3862 Deallocate credentials structures as well as calling gnutls_deinit.
3863 (Fgnutls_deinit, Fgnutls_boot): Use it.
3865 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3866 (deactivate_process): Call emacs_gnutls_deinit.
3868 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3870 * image.c (x_create_x_image_and_pixmap):
3871 * w32.c (sys_rename, w32_delayed_load):
3872 * w32font.c (fill_in_logfont):
3873 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3875 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3877 * w32fns.c (w32_default_color_map): New function,
3878 extracted from Fw32_default_color_map.
3879 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3881 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3883 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3885 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3887 * keyboard.c (test_undefined): New function (bug#9751).
3888 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3890 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3892 * sysdep.c (init_sys_modes): Fix the check for the controlling
3893 terminal (Bug#6649).
3895 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3897 * dispextern.h (struct bidi_it): New member next_en_type.
3899 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3900 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3901 current character, check also for next_en_type being WEAK_EN.
3902 (bidi_resolve_weak): Don't enter the expensive loop if the current
3903 position is before next_en_pos. Record the bidi type of the first
3904 non-ET, non-BN character we find, in addition to its position.
3905 (bidi_level_of_next_char): Invalidate next_en_type when
3906 next_en_pos is over-stepped.
3908 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3910 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3911 * editfns.c: Rewrite current-time-zone so that it invokes
3912 the equivalent of (format-time-string "%Z") to get the time zone name.
3913 This fixes a bug when the time zone name contains characters that
3914 need converting from the system time locale to Emacs internal format.
3915 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3916 that patch fixed format-time-string to do the conversion, but
3917 I forgot to fix current-time-zone.
3918 (format_time_string): New function, containing most of
3919 what Fformat_time_string used to contain.
3920 (Fformat_time_string): Rewrite in terms of format_time_string.
3921 This doesn't change this function's behavior.
3922 (current-time-zone): Rewrite to use format_time_string.
3923 This fixes the bug reported by Michael Schierl in
3924 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3925 Jason Rumney's 2007-06-07 change worked around this bug, but
3927 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3929 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3931 * xdisp.c (start_display): If the character at POS is displayed
3932 via a display vector, reset IT->current.dpvec_index to zero.
3933 (try_window_reusing_current_matrix): If a line ends in a display
3934 vector or the next line starts in a display vector, continue
3935 redrawing the window even though the character position of
3936 start_row was reached.
3939 2011-10-18 Chong Yidong <cyd@gnu.org>
3941 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3942 with nobreak-char-display too.
3944 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3946 Fix part 3 of bug#9771.
3947 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3948 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3949 non-neutral characters if the current character is a paragraph
3950 separator (a.k.a. Newline). This avoids running the same
3951 expensive loop twice, once when we consume the preceding newline
3952 and the other time when the line actually needs to be displayed.
3953 Avoid the loop when we see neutrals on the base embedding level
3954 following a character whose directionality is the same as the
3955 paragraph's. This avoids running the expensive loop when a line
3956 ends in a long sequence of neutrals, like control characters.
3957 Add assertion against STRONG_AL type. Slightly rearrange code
3958 that determines the type of a neutral given the first non-neutral
3960 (bidi_level_of_next_char): Set next_en_pos to zero when
3961 invalidating its info.
3963 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3965 * xdisp.c (push_display_prop): Determine whether to record string
3966 or buffer position by IT->string, not by IT->method. Allow
3967 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3968 (move_it_vertically_backward): Don't look for character position
3969 immediately after the newline when in a continuation line.
3972 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3974 * window.c (coordinates_in_window): Rewrite and delabelize
3975 vertical border check. (Bug#5357) (Bug#9618)
3977 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3979 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3980 errors in XSetWindowBorder (bug#9310).
3982 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3984 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3985 avoid crash when xmalloc overrun checking is enabled.
3987 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3989 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3990 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3991 cursor motion with <left> and <right> arrow keys.
3993 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3994 some callers set that themselves.
3996 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3998 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3999 display string and the previous row comes from the same string and
4000 is empty. (Bug#9739) (Bug#9738)
4002 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4004 * doc.c (get_doc_string): Encode file name (bug#9735).
4006 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4008 * bidi.c (bidi_level_of_next_char):
4009 * xdisp.c (get_visually_first_element): Remove old incorrect
4010 comments regarding the Unicode Line Separator character.
4012 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4014 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4016 * alloc.c (Fgc_status): Do not access beyond zombies array
4017 boundary if nzombies > MAX_ZOMBIES.
4018 * alloc.c (dump_zombies): Add missing format specifier.
4020 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4022 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4023 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4025 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4026 Some packages use them to denote characters with modifiers.
4028 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4030 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4031 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4032 matching a pp-number. Rename parameter var to var1.
4034 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4036 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4038 2011-10-08 Glenn Morris <rgm@gnu.org>
4040 * callint.c (Fcall_interactively): Give a more explicit error for the
4041 'c' case with a non-character input. (Bug#8479)
4043 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4045 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4047 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4048 lines that are hscrolled on the left.
4050 * dispnew.c (buffer_posn_from_coords): Account for a possible
4051 presence of header-line. (Bug#4426)
4053 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4055 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4056 Don't advertise functionality which we discourage or doesn't work.
4058 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4060 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4061 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4062 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4063 this makes Emacs dump core during garbage collection on rare
4064 occasions. sizeof is obviously inferior to offsetof here, so
4065 stick with offsetof.
4066 (GC_POINTER_ALIGNMENT): New macro.
4067 (mark_memory): Omit 3rd (offset) arg; caller changed.
4068 Don't assume EMACS_INT alignment is the same as pointer alignment.
4070 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4072 * keyboard.c (read_key_sequence_remapped): New var.
4073 (read_key_sequence): Compute remapping in the right buffer.
4074 (command_loop_1): Use read_key_sequence's remapping directly.
4076 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4078 * dired.c (file_name_completion): Don't expand file name.
4079 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4080 before checking file name handler.
4082 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4083 they've been requested explicitly (bug#9591).
4085 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4087 * keymap.c (Fsingle_key_description): Use make_specified_string
4088 instead of build_string to build string from push_key_description.
4091 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4093 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4094 This fixes a Y2038 bug on 64-bit hosts.
4095 * buffer.c (reset_buffer):
4096 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4097 (Fclear_buffer_auto_save_failure):
4098 Use 0, not -1, to represent an unset failure time, since time_t
4099 might not be signed.
4101 Remove dependency on glibc malloc internals.
4102 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4103 Move back here from lisp.h, but with their new implementations.
4104 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4105 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4106 * charset.c (charset_table_init): New static var.
4107 (syms_of_charset): Use it instead of xmalloc. This removes a
4108 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4109 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4110 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4111 Move back to alloc.c.
4112 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4113 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4115 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4117 * nsterm.m (windowDidResize): Call x_set_window_size only when
4118 ns_in_resize is true. Otherwise set pixelwidth/height and
4119 call change_frame_size (Bug#9628).
4121 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4123 Port --enable-checking=all to Fedora 14 x86-64.
4124 * charset.c (syms_of_charset): Also account for glibc malloc's
4125 internal overhead when calculating the initial malloc maximum.
4127 Port --enable-checking=all to Fedora 14 x86.
4128 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4130 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4131 (overrun_check_realloc, overrun_check_free):
4132 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4133 That way, xmalloc returns a properly-aligned pointer even if
4134 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4135 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4136 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4137 into account when calculating the initial malloc maximum.
4138 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4139 Move here from alloc.c, so that charset.c can use it too.
4140 Properly align; the old code wasn't right for common 32-bit hosts
4141 when configured with --enable-checking=all.
4142 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4143 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4145 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4147 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4150 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4152 * xdisp.c (compute_display_string_end): If there's no display
4153 string at CHARPOS, return -1.
4155 * bidi.c (bidi_fetch_char): When compute_display_string_end
4156 returns a negative value, treat the character as a normal
4157 character not covered by a display string. (Bug#9624)
4159 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4161 * lread.c (Fread_from_string): Fix typo in docstring.
4163 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4165 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4166 newline, reseat the iterator instead of bidi-iterating there one
4167 character at a time. (Bug#9610)
4168 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4169 TO_CHARPOS if the bidi iterator is at base embedding level.
4171 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4173 * lread.c (readevalloop): Use correct code for NBSP.
4174 (read1): Likewise. (Bug#9608)
4176 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4178 * dbusbind.c (Fdbus_register_signal): When service is not
4179 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4181 2011-09-25 Glenn Morris <rgm@gnu.org>
4183 * buffer.c (truncate-lines): Doc fix.
4185 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4187 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4188 (Fset_window_next_buffers): Doc fix.
4190 2011-09-24 Glenn Morris <rgm@gnu.org>
4192 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4194 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4196 Fix minor problems found by static checking.
4197 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4198 * indent.c (Fvertical_motion): Fix == vs = typo.
4200 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4202 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4203 Default value is now t. Doc fix.
4205 * indent.c (Fvertical_motion): Compute and apply the overshoot
4206 logic when moving up, not only when moving down. Fix the
4207 confusing name and values of the it_overshoot_expected variable;
4208 logic changes accordingly. (Bug#9254) (Bug#9549)
4210 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4211 CHARPOS is covered by a display string which includes newlines.
4212 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4213 is covered by a display string with embedded newlines.
4215 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4217 * dbusbind.c (Fdbus_register_signal): Add match rule to
4218 Vdbus_registered_objects_table. (Bug#9581)
4219 (Fdbus_register_method, Vdbus_registered_objects_table):
4222 2011-09-24 Jim Meyering <meyering@redhat.com>
4224 do not ignore write error for any output size
4225 The previous change was incomplete.
4226 While it makes emacs --batch detect the vast majority of stdout
4227 write failures, errors were still ignored whenever the output size is
4228 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4229 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4230 && echo FAIL: ignored write error
4231 FAIL: ignored write error
4232 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4233 && echo FAIL: ignored write error
4234 FAIL: ignored write error
4235 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4237 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4239 * emacs.c (Fkill_emacs): In noninteractive mode exit
4240 non-successfully if a write error occurred on stdout. (Bug#9574)
4242 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4244 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4247 * dispextern.h (struct it): Update the comment documenting what
4250 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4252 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4253 a display string, extend search for cursor position to end of row.
4254 (find_row_edges): If the row ends in a newline from a display
4255 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4256 Handle the case of a display string with multiple newlines.
4257 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4258 non-empty line. Fixes confusing cursor motion with arrow keys at
4259 the beginning of a line that starts with whitespace.
4261 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4263 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4266 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4268 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4271 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4273 * xdisp.c (display_line): Record maximum and minimum buffer
4274 positions even if no glyphs were produced (e.g., by a zero-width
4275 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4276 buffer positions that will be removed from the glyph row because
4278 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4279 column is beyond frame width: don't subtract 1 "pixel" when
4280 computing width of the stretch.
4281 (reseat_at_next_visible_line_start): Undo the change made on
4282 2011-09-17 that saved paragraph information and restored it after
4283 the call to `reseat'. (Bug#9545)
4285 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4287 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4288 and turn window cursor on if cleared (Bug#9415).
4290 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4292 * search.c (boyer_moore): Take unibyte characters from pattern
4293 literally. (Bug#9458)
4295 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4297 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4299 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4301 Fix minor problem found by static checking.
4302 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4303 initialized, to pacify gcc -Wuninitialized.
4305 * fileio.c: Report proper errno when syscall falls.
4306 (Finsert_file_contents): Save and restore errno,
4307 so that report_file_error outputs the correct diagnostic.
4308 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4310 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4312 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4314 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4316 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4317 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4319 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4321 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4322 about the current paragraph and restore it after the call to reseat.
4324 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4325 (bidi_find_paragraph_start): Search back for paragraph beginning
4326 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4327 (bidi_move_to_visually_next): Only trigger paragraph-related
4328 computations when the last character is a newline or at EOB, not
4329 just any NEUTRAL_B. (Bug#9470)
4331 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4332 truncated lines if point is covered by a display string. (Bug#9524)
4334 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4336 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4337 (cons_to_x_long): New function.
4338 (lisp_data_to_selection_data): Use it. Correct the test for
4339 short-versus-long data; it was negated. Break out of vector
4340 loop, for efficiency, when a long datum is discovered.
4342 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4344 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4346 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4348 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4349 GCC PR/17406) by declaring this function with external scope.
4351 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4353 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4354 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4356 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4358 * editfns.c (Fformat): Correctly handle text properties on "%%".
4360 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4362 * xterm.c (x_draw_composite_glyph_string_foreground):
4363 * w32term.c (x_draw_composite_glyph_string_foreground):
4364 * term.c (encode_terminal_code):
4365 * composite.c (composition_update_it, get_composition_id):
4366 * xdisp.c (get_next_display_element)
4367 (fill_composite_glyph_string): Add comments about special meaning
4368 of TAB characters in a composition.
4370 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4372 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4373 This occurs when processing a multibyte format.
4374 Problem reported by Wolfgang Jenker.
4376 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4378 * xdisp.c (try_cursor_movement): Only check for exact match if
4379 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4381 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4383 Remove unused external symbols.
4384 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4385 * xdisp.c (calc_pixel_width_or_height): Now static.
4386 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4387 * indent.c (check_display_width):
4388 * w32term.c: Fix comment to match code.
4389 * xterm.c, xterm.h (x_catching_errors): Remove.
4391 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4393 * xselect.c: Use signed conversions more consistently (Bug#9498).
4394 (selection_data_to_lisp_data): Assume incoming selection data are
4395 signed integers, not unsigned. This is to be consistent with
4396 outgoing selection data, which was modified to use signed integers
4397 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4398 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4399 expects long, not unsigned long.
4401 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4403 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4404 computation of loop end. Reported by Johan Bockgård
4407 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4409 * frame.c (Fother_visible_frames_p): Function deleted.
4411 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4413 * indent.c (compute_motion): Process display vector front to back
4414 rather than the other way around. (Bug#2496)
4416 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4418 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4420 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4422 * minibuf.c (Fread_from_minibuffer): Doc fix.
4424 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4426 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4427 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4429 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4431 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4432 value for non-existent files.
4434 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4436 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4437 set its "size" to -1. This will set the modtime_size field of
4438 the corresponding buffer to -1, which is what
4439 verify-visited-file-modtime expects for files that do not exist.
4442 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4444 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4446 * lisp.h: ... from here. push_key_description is no longer
4447 defined in keyboard.c, so its declaration should not be in
4448 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4449 logically belongs with push_key_description.
4451 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4453 * buffer.h: Include <sys/types.h> instead of <time.h>.
4454 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4455 Problem reported by Herbert J. Skuhra.
4457 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4459 * xml.c (parse_region): Make the parsing work for
4460 non-comment-starting XML files again (bug#9144).
4462 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4464 * image.c (gif_load): Fix calculation of bottom and right corner.
4467 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4469 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4470 redisplay in small windows.
4472 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4474 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4476 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4478 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4479 Operate on live windows only.
4481 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4483 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4485 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4488 only under bidi iteration.
4490 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4492 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4494 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4496 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4497 Without this fix, the command to link temacs failed due to an
4498 undefined symbol __builtin_isnan. This is because
4499 /usr/include/iso/math_c99.h #defines isnan(x) to
4500 __builtin_isnan(x), but the bundled gcc, which identifies itself
4501 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4503 * floatfns.c (isnan): #undef, and then #define to a clone of
4505 (Fisnan): Always define, since it's always available now.
4506 (syms_of_floatfns): Always define isnan at the Lisp level.
4508 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4510 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4512 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4514 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4515 The previous code assumed that file offsets (off_t values) fit in
4516 EMACS_INT variables, which is not true on typical 32-bit hosts.
4517 The code messed up by falsely reporting buffer overflow in cases
4518 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4519 when "big" contains more than 2**29 bytes, even though this
4520 inserts just one byte and does not overflow the buffer.
4521 (Finsert_file_contents): Store file offsets as off_t
4522 values, not as EMACS_INT values. Check for overflow when
4523 converting between EMACS_INT and off_t. When checking for
4524 buffer overflow or for overlap, take the offsets into account.
4525 Don't use EMACS_INT for small values where int suffices.
4526 When checking for overlap, fix a typo: ZV was used where
4527 ZV_BYTE was intended.
4528 (Fwrite_region): Don't assume off_t fits into 'long'.
4529 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4531 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4533 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4535 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4537 sprintf-related integer and memory overflow issues (Bug#9412).
4539 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4540 (esprintf, exprintf, evxprintf): New functions.
4541 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4542 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4543 (modify_event_symbol): Do not assume that the length of
4544 name_alist_or_stem is safe to alloca and fits in int.
4545 (Fexecute_extended_command): Likewise for function name and binding.
4546 (Frecursion_depth): Wrap around reliably on integer overflow.
4547 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4548 since some callers pass EMACS_INT values.
4549 (Fsingle_key_description): Don't crash if symbol name contains more
4550 than MAX_ALLOCA bytes.
4551 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4552 (get_minibuffer): Arg is now EMACS_INT, not int.
4553 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4554 (esprintf, exprintf, evxprintf): New decls.
4555 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4557 * dbusbind.c (signature_cat): New function.
4558 (xd_signature, Fdbus_register_signal):
4559 Do not overrun buffer; instead, report string overflow.
4561 * dispnew.c (add_window_display_history): Don't overrun buffer.
4562 Truncate instead; this is OK since it's just a log.
4564 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4565 even if the time zone offset is outlandishly large.
4566 Don't mishandle offset == INT_MIN.
4568 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4569 when creating daemon; the previous buffer-overflow check was incorrect.
4571 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4572 which has the guts of the old verror function.
4574 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4575 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4577 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4578 (font_unparse_xlfd): Don't blindly alloca long strings.
4579 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4580 fits in int, when using sprintf. Use single snprintf to count
4581 length of string rather than counting it via multiple sprintfs;
4582 that's simpler and more reliable.
4583 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4584 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4585 sprintf, in case result does not fit in int.
4587 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4588 (fontset_from_font): Print it.
4590 * frame.c (tty_frame_count): Now printmax_t, not int.
4591 (make_terminal_frame, set_term_frame_name): Print it.
4592 (x_report_frame_params): In X, window IDs are unsigned long,
4593 not signed long, so print them as unsigned.
4594 (validate_x_resource_name): Check for implausibly long names,
4595 and don't assume name length fits in 'int'.
4596 (x_get_resource_string): Don't blindly alloca invocation name;
4597 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4600 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4601 (xg_check_special_colors, xg_set_geometry):
4602 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4604 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4605 Use esprintf, not sprintf, in case result does not fit in int.
4607 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4608 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4609 it as a large positive number.
4610 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4611 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4613 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4614 in case result does not fit in int.
4616 * print.c (float_to_string): Detect width overflow more reliably.
4617 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4618 buffer overrun. Don't assume list length fits in 'int'. Treat
4619 print length of 0 as 0, not as infinity; to be consistent with other
4620 uses of print length in this function. Don't overflow print length
4621 index. Don't assume hash table size fits in 'long', or that
4622 vectorlike size fits in 'unsigned long'.
4624 * process.c (make_process): Use printmax_t, not int, to format
4625 process-name gensyms.
4627 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4629 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4630 to avoid potential buffer overrun.
4632 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4633 if X resource line is longer than 512 bytes.
4635 * xfns.c (x_window): Make sprintf buffer a bit bigger
4636 to avoid potential buffer overrun.
4638 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4640 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4642 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4644 Integer overflow fixes for scrolling, etc.
4645 Without these, Emacs silently mishandles large integers sometimes.
4646 For example, "C-u 4294967297 M-x recenter" was treated as if
4647 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4649 * xdisp.c (try_window_id): Check Emacs fixnum range before
4650 converting to 'int'.
4652 * window.c (window_scroll_line_based, Frecenter):
4653 Check that an Emacs fixnum is in range before assigning it to 'int'.
4654 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4655 values converted from Emacs fixnums.
4656 (Frecenter): Don't wrap around a line count if it is out of 'int'
4657 range; instead, treat it as an extreme value.
4658 (Fset_window_configuration, compare_window_configurations):
4659 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4661 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4662 that can exceed INT_MAX. Check that EMACS_INT value is in range
4663 before assigning it to the (possibly-narrower) index.
4664 (match_limit): Don't assume that a fixnum can fit in 'int'.
4666 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4669 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4670 (Fvertical_motion): Don't wrap around LINES values that don't fit
4671 in 'int'. Instead, treat them as extreme values. This is good
4672 enough for windows, which can't have more than INT_MAX lines anyway.
4674 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4676 * Require libxml/parser.h to avoid compilation warning.
4678 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4680 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4681 since this reportedly can destroy thread storage.
4683 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4685 * syntax.c (find_defun_start): Update all cache variables if
4686 exiting early (Bug#9401).
4688 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4690 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4692 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4693 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4694 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4696 * term.c (tty_append_glyph): New function.
4697 (produce_stretch_glyph): Static function and its prototype deleted.
4699 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4702 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4704 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4705 when checking :margin (Bug#9390).
4706 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4707 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4708 so that the name doesn't mislead. All uses changed.
4710 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4712 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4715 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4717 * xdisp.c (move_it_to): Don't bail out early when reaching
4718 position beyond to_charpos, if we are scanning backwards.
4719 (move_it_vertically_backward): When DY == 0, make sure we get to
4720 the first character in the line after the newline.
4722 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4724 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4725 (ccl_driver): Do not generate an out-of-range pointer.
4726 (Fccl_execute_on_string): Remove unnecessary check for
4727 integer overflow, noted by Stefan Monnier in
4728 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4729 Remove a FIXME that didn't need fixing.
4730 Simplify the newly-introduced buffer reallocation code.
4732 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4734 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4736 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4738 Integer and memory overflow issues (Bug#9196).
4740 * doc.c (get_doc_string): Rework so that
4741 get_doc_string_buffer_size is the actual buffer size, rather than
4742 being 1 less than the actual buffer size; this makes xpalloc more
4745 * image.c (x_allocate_bitmap_record, cache_image):
4746 * xselect.c (Fx_register_dnd_atom):
4747 Simplify previous changes by using xpalloc.
4749 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4750 since either will do and ptrdiff_t is convenient with xpalloc.
4752 * charset.c (charset_table_size)
4753 (struct charset_sort_data.priority): Now ptrdiff_t.
4754 (charset_compare): Don't overflow if priorities differ greatly.
4755 (Fsort_charsets): Don't assume list length fits in int.
4756 Check for size-calculation overflow when allocating sort data.
4757 (syms_of_charset): Allocate an initial charset table that is
4758 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4760 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4762 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4763 The actual value is always <= INT_MAX, and leaving it unsigned made
4764 overflow checking harder.
4766 * dispextern.h (struct glyph_matrix.rows_allocated)
4767 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4768 with xpalloc. The values are still always <= INT_MAX.
4770 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4772 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4773 (SAFE_NALLOCA): New macro.
4775 * region-cache.c (struct boundary.pos, find_cache_boundary)
4776 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4777 (set_cache_region, invalidate_region_cache)
4778 (revalidate_region_cache, know_region_cache, region_cache_forward)
4779 (region_cache_backward, pp_cache):
4780 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4781 so that ptrdiff_t * can be passed to xpalloc.
4782 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4783 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4784 (pp_cache): Don't assume cache_len fits in int.
4785 * region-cache.h: Adjust extern decls to match.
4787 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4788 EMACS_INT, since either will do, for xpalloc.
4790 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4791 (xnmalloc, xnrealloc, xpalloc): New functions.
4793 * bidi.c (bidi_shelve_header_size): New constant.
4794 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4795 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4797 * bidi.c (bidi_cache_shrink):
4798 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4800 Don't update size of array until after memory allocation succeeds,
4801 because xmalloc/xrealloc may not return.
4802 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4803 now that we have proper integer overflow checking.
4804 (record_overlay_string, overlay_strings): Catch overflows when
4805 calculating size of overlay_str_buf.
4807 * callproc.c (Fcall_process): Check for size overflow when
4808 calculating size of args2.
4809 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4810 Normally we prefer signed values, but sticking with ptrdiff_t would
4811 require adding more-complicated checks.
4813 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4814 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4815 Redo buffer-overflow calculations to avoid integer overflow.
4816 Add a FIXME comment where memory seems to be over-allocated.
4818 * character.c (Fstring): Check for size-calculation overflow.
4820 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4821 unnecessary integer overflow. Check for size overflow.
4822 (encode_coding_object): Don't update size until xmalloc succeeds.
4824 * composite.c (get_composition_id): Check for overflow in glyph
4825 length calculations.
4827 Integer and memory overflow fixes for display code.
4828 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4829 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4830 (scrolling_window): Check for overflow in size calculations.
4831 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4832 Don't assume glyph table len fits in int.
4833 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4834 (row_table_size): Now ptrdiff_t, not int.
4835 (scrolling_window): Avoid overflow in size calculations.
4836 Don't update size until allocation succeeds.
4837 * fns.c (concat): Check for overflow in size calculations.
4838 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4839 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4840 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4842 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4843 (get_doc_string): Check for size calculation overflow.
4844 Don't update size until allocation succeeds.
4845 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4846 EMACS_INT, where ptrdiff_t will do.
4847 (Fsubstitute_command_keys): Check for string overflow.
4849 * editfns.c (set_time_zone_rule): Don't assume environment length
4851 (message_length): Now ptrdiff_t, not int.
4852 (Fmessage_box): Don't update size until allocation succeeds.
4853 Don't assume message length fits in int.
4854 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4856 * emacs.c (main): Do not reallocate argv, since there is a null at
4857 the end that can be overwritten, and this way there's no need to
4858 worry about size-calculation overflow.
4859 (sort_args): Check for size-calculation overflow.
4861 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4863 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4865 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4866 (x_set_scroll_bar_width, x_figure_window_size):
4867 Check for integer overflow.
4868 (x_set_alpha): Do not assume XINT fits in int.
4870 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4871 This is for the members text_lines, text_cols, total_lines, total_cols,
4872 where the system imposes an 'int' limit.
4874 * fringe.c (Fdefine_fringe_bitmap):
4875 Don't update size until alloc works.
4877 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4878 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4880 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4881 Check for size-calculation overflow.
4882 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4883 do, as we prefer signed integers.
4884 (id_to_widget.max_size, id_to_widget.used)
4885 (xg_store_widget_in_map, xg_remove_widget_from_map)
4886 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4887 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4888 Use and return ptrdiff_t, not int.
4889 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4890 * gtkutil.h: Change prototypes to match the above.
4892 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4893 are duplicate now that they've been promoted to lisp.h.
4894 (x_allocate_bitmap_record, x_alloc_image_color)
4895 (make_image_cache, cache_image, xpm_load):
4896 Don't update size until alloc is done.
4897 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4899 Check for size calculation overflow.
4900 (ct_colors_allocated_max): New constant.
4901 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4904 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4905 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4906 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4907 Use ptrdiff_t, not int, to count maps.
4908 (read_char_minibuf_menu_prompt): Check for overflow in size
4909 calculations. Don't update size until allocation succeeds.
4910 Redo calculations to avoid overflow.
4911 * keyboard.h: Change prototypes to match the above.
4913 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4915 (current_minor_maps): Check for size calculation overflow.
4916 * keymap.h: Change prototypes to match the above.
4918 * lread.c (read1, init_obarray): Don't update size until alloc done.
4920 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4921 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4923 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4924 Now ptrdiff_t, not int.
4925 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4926 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4928 * process.c (Fnetwork_interface_list): Check for overflow
4929 in size calculation.
4931 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4933 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4934 overflow. Don't bother calling xmalloc when xrealloc will do.
4936 * search.c (Freplace_match): Check for size calculation overflow.
4937 (Fset_match_data): Don't assume list lengths fit in 'int'.
4939 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4940 for command line length. Do not attempt to address one before the
4941 beginning of an array, as that's not portable.
4943 * term.c (max_frame_lines): Remove; unused.
4944 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4946 (encode_terminal_code, calculate_costs): Check for size
4947 calculation overflow.
4948 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4949 table lengths and related sizes. Don't update size until alloc
4950 done. Redo calculations to avoid overflow.
4951 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4953 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4954 subtracting pointers.
4955 (gobble_line): Check for overflow more carefully. Don't update size
4958 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4959 Don't update size until alloc done.
4960 Redo size calculations to avoid overflow.
4961 Check for size calculation overflow.
4962 (main) [DEBUG]: Fix typo in invoking tparam1.
4964 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4965 Use ptrdiff_t, not int, for sizes.
4966 (store_mode_line_noprop_char): Don't update size until alloc done.
4968 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4969 Use ptrdiff_t, not int, for sizes.
4970 (Finternal_make_lisp_face, cache_face):
4971 Check for size calculation overflow.
4972 (cache_face): Treat size calculation overflows as if they were
4973 memory exhaustion (the usual treatment), rather than aborting.
4975 * xfns.c (x_encode_text, x_set_name_internal)
4976 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4977 sizes, since they can exceed INT_MAX in size. Check for size
4978 calculation overflow.
4980 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4981 (xg_select): Check for size calculation overflow.
4982 Don't update size until alloc done.
4984 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4985 as sprintf is limited to int lengths.
4987 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4988 (X_LONG_MIN): New macros.
4989 Use them to make the following changes clearer.
4990 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4991 This change doesn't affect the value now, but it may help remind
4992 future maintainers not to raise the value too much later.
4993 (SELECTION_QUANTUM): Remove, replacing with ...
4994 (selection_quantum): ... new function, which avoids overflow.
4996 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4997 assumption that selection length fits in 'int'.
4998 (x_reply_selection_request, x_handle_selection_request)
4999 (x_get_window_property, receive_incremental_selection)
5000 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5001 (lisp_data_to_selection_data, clean_local_selection_data):
5002 Use ptrdiff_t, not int, to record length of selection.
5003 (x_reply_selection_request, x_get_window_property)
5004 (receive_incremental_selection, x_property_data_to_lisp):
5005 Redo calculations to avoid overflow.
5006 (x_reply_selection_request): When sending hint, ceiling it at
5007 X_LONG_MAX rather than relying on wraparound overflow to send
5009 (x_get_window_property, receive_incremental_selection)
5010 (lisp_data_to_selection_data, x_property_data_to_lisp):
5011 Check for size-calculation overflow.
5012 (x_get_window_property, receive_incremental_selection)
5013 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5014 Don't store size until memory allocation succeeds.
5015 (x_get_window_property): Plug memory leak on memory exhaustion.
5016 Don't double-block input; malloc is safe here. Don't assume 2**34
5017 - 4 fits in unsigned long. Add an xassert to check
5018 XGetWindowProperty overflow. Be more careful about overflow
5019 calculations, and distinguish size from memory overflow better.
5020 (receive_incremental_selection): When tracing, don't assume
5021 unsigned int is less than INT_MAX.
5022 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5023 harmful) conversions of unsigned short to int.
5024 (lisp_data_to_selection_data): Don't assume that integers
5025 in the range -65535 through -1 fit in an X unsigned short.
5026 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5027 result parameters unless successful. Rely on cons_to_unsigned
5028 to report problems with elements; the old code wasn't right anyway.
5029 (x_check_property_data): Check for int overflow; we cannot use
5030 a wider type due to X limits.
5031 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5033 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5035 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5036 (x_term_init): Check for size calculation overflow.
5037 (x_color_cells): Don't store size until memory allocation succeeds.
5038 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5039 Don't assume alloca size is less than MAX_ALLOCA.
5040 (x_term_init): Don't assume length fits in int (sprintf is limited
5043 Use ptrdiff_t for composition IDs.
5044 * character.c (lisp_string_width):
5045 * composite.c (composition_table_size, n_compositions)
5046 (get_composition_id, composition_gstring_from_id):
5047 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5048 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5049 * window.c (Frecenter):
5050 Use ptrdiff_t, not int, for composition IDs.
5051 * composite.c (get_composition_id): Check for integer overflow.
5052 * composite.h: Adjust prototypes to match the above changes.
5054 Use ptrdiff_t for hash table indexes.
5055 * category.c (hash_get_category_set):
5056 * ccl.c (ccl_driver):
5057 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5058 * coding.c (coding_system_charset_list, detect_coding_system):
5059 * coding.h (struct coding_system.id):
5060 * composite.c (get_composition_id, gstring_lookup_cache):
5061 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5062 * image.c (xpm_get_color_table_h):
5063 * lisp.h (hash_lookup, hash_put):
5064 * minibuf.c (Ftest_completion):
5065 Use ptrdiff_t for hash table indexes, not int (which is too
5066 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5067 32-bit --with-wide-int hosts).
5069 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5070 Add a FIXME comment about memory leaks.
5071 (syms_of_charset): Don't assume xmalloc returns.
5073 Don't assume that stated character widths fit in int.
5074 * character.c (Fchar_width, c_string_width, lisp_string_width):
5075 * character.h (CHAR_WIDTH):
5076 * indent.c (MULTIBYTE_BYTES_WIDTH):
5077 Use sanitize_char_width to avoid undefined and/or bad behavior
5078 with outlandish widths.
5079 * character.h (sanitize_tab_width): Rename from sanitize_width,
5080 now that we have two such functions. All uses changed.
5081 (sanitize_char_width): New inline function.
5083 Don't assume that tab-width fits in int.
5084 * character.h (sanitize_width): New inline function.
5085 (SANE_TAB_WIDTH): New macro.
5086 (ASCII_CHAR_WIDTH): Use it.
5087 * indent.c (sane_tab_width): Remove. All uses replaced by
5088 SANE_TAB_WIDTH (current_buffer).
5089 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5091 * fileio.c: Integer overflow issues with file modes.
5092 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5094 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5095 Remove unreachable code.
5096 (read_hex, load_charset_map_from_file): Check for integer overflow.
5098 * xterm.c: Don't go over XClientMessageEvent limit.
5099 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5100 (x_send_scroll_bar_event): Likewise. Check that the size does not
5101 exceed limits imposed by XClientMessageEvent, as well as the usual
5102 ptrdiff_t and size_t limits.
5104 * keyboard.c: Overflow, signedness and related fixes.
5105 (make_lispy_movement): Use same integer type in forward decl
5106 that is used in the definition.
5107 (read_key_sequence, keyremap_step):
5108 Change bufsize argument back to int, undoing my 2011-03-30 change.
5109 We prefer signed types, and int is wide enough here.
5110 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5111 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5112 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5113 length, not size_t. Use ptrdiff_t for index, not int.
5114 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5115 possibility of integer overflow.
5117 Overflow, signedness and related fixes for images.
5119 * dispextern.h (struct it.stack[0].u.image.image_id)
5120 (struct_it.image_id, struct image.id, struct image_cache.size)
5121 (struct image_cache.used, struct image_cache.ref_count):
5122 * gtkutil.c (update_frame_tool_bar):
5123 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5124 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5125 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5126 * nsmenu.m (update_frame_tool_bar):
5127 * xdisp.c (calc_pixel_width_or_height):
5128 * xfns.c (image_cache_refcount):
5129 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5130 on typical 64-bit hosts.
5132 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5133 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5134 Omit unnecessary casts to int.
5135 (parse_image_spec): Check that integers fall into 'int' range
5136 when the callers expect that.
5137 (image_ascent): Redo ascent calculation to avoid int overflow.
5138 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5139 (lookup_image): Remove unnecessary tests.
5140 (xbm_image_p): Locals are now of int, not EMACS_INT,
5141 since parse_image_check makes sure they fit into int.
5142 (png_load, gif_load, svg_load_image):
5143 Prefer int to unsigned where either will do.
5144 (tiff_handler): New function, combining the cores of the
5145 old tiff_error_handler and tiff_warning_handler.
5146 This function is rewritten to use vsnprintf and thereby avoid
5147 stack buffer overflows. It uses only the features of vsnprintf
5148 that are common to both POSIX and native Microsoft.
5149 (tiff_error_handler, tiff_warning_handler): Use it.
5150 (tiff_load, gif_load, imagemagick_load_image):
5151 Don't assume :index value fits in 'int'.
5152 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5153 (imagemagick_load_image): Check that crop parameters fit into
5154 the integer types that MagickCropImage accepts. Don't assume
5155 Vimagemagick_render_type has a nonnegative value. Don't assume
5156 size_t fits in 'long'.
5157 (gs_load): Use printmax_t to print the widest integers possible.
5158 Check for integer overflow when computing image height and width.
5160 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5162 * xdisp.c (redisplay_window): Don't force window start if point
5163 will be invisible in the resulting window. (Bug#9324)
5165 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5167 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5168 the display spec is of the form `(space ...)'.
5169 (handle_display_spec): Return the value returned by
5170 handle_single_display_spec, not just 1 or zero.
5171 (handle_single_display_spec): If the display spec is of the form
5172 `(space ...)', and specifies display in the text area, return 2
5174 (try_cursor_movement): Check for the need to scroll more
5175 accurately, and prefer exact match for point under bidi.
5176 Don't advance `row' beyond the last row of the window.
5178 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5179 into disp_prop; all users changed.
5181 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5182 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5183 for the text covered by the display property.
5185 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5187 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5188 Change return value to nil.
5189 (Frecord_buffer): Delete unused function.
5191 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5193 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5194 buffers, return left-to-right.
5195 (set_cursor_from_row): Consider candidate row a win if its glyph
5196 represents a newline and point is on that newline. Fixes cursor
5197 positioning on the newline at EOL of R2L text within L2R
5198 paragraph, and vice versa.
5199 (try_cursor_movement): Check continued rows, in addition to
5200 continuation rows. Fixes unwarranted scroll when point enters a
5201 continued line of R2L text within an L2R paragraph, or vice versa.
5202 (cursor_row_p): Consider the case of point being equal to
5203 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5204 from the end of a short line to the beginning of a continued line
5205 of R2L text within L2R paragraph.
5206 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5207 composed characters.
5209 * bidi.c (bidi_check_type): Use xassert.
5210 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5213 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5215 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5218 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5220 * nsfont.m (ns_otf_to_script): Fix typo.
5222 2011-08-22 Kenichi Handa <handa@m17n.org>
5224 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5225 extra slot even if the purpose is char-code-property-table.
5227 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5229 * xdisp.c (redisplay_window): When computing centering_position,
5230 account for the height of the header line. (Bug#8874)
5232 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5233 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5234 candidate is selected by the mouse, and that candidate has a
5235 composed character under the mouse.
5237 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5238 coordinates reported by pos-visible-in-window-p for a composed
5239 character in column zero.
5241 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5243 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5245 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5247 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5248 consider it a hit if to_charpos is anywhere in the range of the
5249 composed buffer positions.
5251 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5253 * image.c (gif_load): Don't assume that each subimage has the same
5254 dimensions as the base image. Handle disposal method that is
5255 "undefined" by the gif spec (Bug#9335).
5257 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5259 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5260 (Fcondition_case): Document `debug' symbol in error handler.
5262 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5264 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5265 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5266 from an Org mode buffer to a Speedbar frame.
5268 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5269 a composition, take its buffer position from IT->cmp_it.charpos.
5270 Fixes cursor positioning at the beginning of a line that begins
5271 with a composed character.
5273 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5275 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5276 character bidirectional type, use STRONG_L instead. Fixes crashes
5277 in a buffer produced by `describe-categories'.
5279 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5280 members before the level stack, so they would be saved and
5281 restored when copying iterator state. Fixes incorrect reordering
5282 around TABs covered by display properties.
5284 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5286 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5288 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5290 * eval.c (internal_condition_case, internal_condition_case_1)
5291 (internal_condition_case_2, internal_condition_case_n):
5292 Remove unnecessary aborts (Bug#9081).
5294 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5296 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5297 has no `load' handler, try opening the file locally. (Bug#9311)
5299 2011-08-16 Ken Brown <kbrown@cornell.edu>
5301 * gmalloc.c: Expand comment.
5303 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5305 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5306 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5308 2011-08-16 Ken Brown <kbrown@cornell.edu>
5310 Fix memory allocation problems in Cygwin build (Bug#9273).
5312 * unexcw.c ( __malloc_initialized): Declare external variable.
5313 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5315 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5317 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5319 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5321 [CYGWIN] (special_realloc): New function.
5322 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5323 requests to realloc storage in the static heap.
5325 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5327 * bidi.c (bidi_initialize): Remove unused local.
5329 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5332 * biditype.h: Remove file.
5333 * makefile.w32-in ($(BLD)/bidi.$(O)):
5334 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5336 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5338 * chartab.c: Improve commentary for the uniprop_table API.
5340 * bidi.c (bidi_paragraph_init): Support zero value of
5341 bidi_ignore_explicit_marks_for_paragraph_level.
5342 (bidi_initialize): Use uniprop_table instead of including
5343 biditype.h and bidimirror.h.
5345 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5346 coordinates of the iterator when restoring from ppos_it.
5349 2011-08-14 Kenichi Handa <handa@m17n.org>
5351 * process.c (create_process): Call setup_process_coding_systems
5352 after the pid of the process is set to -1 (Bug#8162).
5354 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5356 * xdisp.c (move_it_in_display_line_to): Don't invoke
5357 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5358 ppos_it. Fixes vertical cursor motion when line beginning is
5359 covered by an image. (Bug#9296)
5361 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5363 * nsterm.h (ns_run_ascript): Declare.
5364 (NSAPP_DATA2_RUNASSCRIPT): Define.
5366 * nsfns.m (as_script, as_result, as_status): New static variables.
5367 (ns_run_ascript): New function.
5368 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5369 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5370 the event loop. Get status from as_status (Bug#7276).
5372 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5373 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5374 the event loop (Bug#7276).
5376 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5378 * gnutls.c (QCgnutls_bootprop_priority)
5379 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5380 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5381 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5382 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5383 (QCgnutls_bootprop_verify_hostname_error)
5384 (QCgnutls_bootprop_callbacks_verify): Rename from
5385 Qgnutls_bootprop_..., all uses changed.
5387 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5390 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5392 * xfaces.c (Qframe_set_background_mode): Now static.
5393 * dispextern.h (Qframe_set_background_mode): Remove decl.
5395 * process.c (Fnetwork_interface_info): Declare local only if needed.
5397 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5399 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5400 (Fnetwork_interface_list): Allocate in increments of bytes instead
5401 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5402 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5404 (struct ifflag_def): notrailers is smart on OSX.
5405 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5406 Get hardware address with getifaddrs if available.
5408 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5410 * xdisp.c (iterate_out_of_display_property): xassert that
5411 IT->position is set to within IT->object's boundaries. Break from
5412 the loop as soon as EOB is reached; avoids infloops in redisplay
5413 when IT->position is set up wrongly due to some bug.
5414 Set IT->current to match the bidi iterator unconditionally.
5415 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5416 entry. Force push_it to save on the stack the current
5417 buffer/string position, to be restored by pop_it. Fix flags in
5418 the iterator structure wrt the object coming from a display
5419 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5420 properties. (Bug#9284)
5422 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5424 * fontset.c (fontset_get_font_group): Add proper type checks.
5427 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5429 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5430 and LC_VERSION_MIN_MACOSX.
5431 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5432 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5434 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5436 * xdisp.c (forward_to_next_line_start): Allow to use the
5437 no-display-properties-and-no-overlays under bidi display.
5438 Set disp_pos in the bidi iterator to avoid searches for display
5439 properties and overlays.
5441 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5443 * editfns.c (Fset_time_zone_rule): Document relationship with the
5446 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5447 the font entity extracted from the cache (Bug#8109).
5449 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5451 * composite.c (autocmp_chars): Don't reset point. That is done by
5452 restore_point_unwind (Bug#5984).
5454 2011-08-07 Juri Linkov <juri@jurta.org>
5456 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5457 to show the arg `TIME' instead of `TIMEVAL'.
5459 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5461 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5462 display property strides EOL and includes a newline, as in
5463 longlines-mode. (Bug#9254)
5464 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5465 word-wrap under bidirectional display. (Bug#9224)
5467 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5468 is non-zero, even if the data buffer is NULL. Fixes a crash in
5469 vertical-motion with longlines-mode. (Bug#9254)
5471 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5473 * bidi.c <bidi_cache_total_alloc>: Now static.
5474 (bidi_initialize): Initialize bidi_cache_total_alloc.
5476 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5479 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5480 amount allocated this far in `bidi_cache_total_alloc'.
5481 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5482 non-zero, only free the data buffer without restoring the cache
5483 contents. All callers changed.
5485 * dispextern.h (bidi_unshelve_cache): Update prototype.
5487 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5488 (move_it_in_display_line, move_it_to)
5489 (move_it_vertically_backward, move_it_by_lines): Replace the call
5490 to xfree to an equivalent call to bidi_unshelve_cache.
5491 (move_it_in_display_line_to): Fix logic of returning
5492 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5494 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5496 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5497 came from a string character with a `cursor' property. (Bug#9229)
5499 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5501 * Makefile.in (LIB_PTHREAD): New variable.
5502 (LIBES): Add LIB_PTHREAD (Bug#9216).
5504 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5505 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5507 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5509 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5511 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5513 * xterm.c (x_find_topmost_parent): New function.
5514 (x_set_frame_alpha): Find topmost parent window with
5515 x_find_topmost_parent and set the property there also (bug#9181).
5516 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5518 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5520 * callproc.c (Fcall_process): Avoid vfork clobbering
5521 the local vars buffer, coding_systems, current_dir.
5523 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5525 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5527 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5529 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5530 so that it is not optimized away.
5532 * xdisp.c (compute_display_string_pos): Remove unused local.
5534 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5536 Fix slow cursor motion and scrolling in large buffers with
5537 selective display, like Org Mode buffers. (Bug#9218)
5539 * dispextern.h (struct bidi_it): New member disp_prop_p.
5541 * xdisp.c: Remove one-slot cache of display string positions.
5542 (compute_display_string_pos): Accept an additional argument
5543 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5544 for a display string or property. If found, set DISP_PROP_P
5547 * bidi.c (bidi_fetch_char): Accept an additional argument
5548 DISP_PROP_P, and pass it to compute_display_string_pos.
5549 Only handle text covered by a display string if DISP_PROP_P is returned
5550 non-zero. All callers of bidi_fetch_char changed.
5552 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5554 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5556 2010-12-03 Don March <don@ohspite.net>
5558 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5559 last character M-[char] is translated to ESC [char] (bug#7541).
5561 2011-08-02 Kenichi Handa <handa@m17n.org>
5563 * lisp.h (uniprop_table): Extern it.
5565 * chartab.c (uniprop_table): Make it non-static.
5567 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5569 * xdisp.c (forward_to_next_line_start): Accept additional argument
5570 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5572 (reseat_at_next_visible_line_start): Use the bidi iterator state
5573 returned by forward_to_next_line_start to restore the state of
5574 it->bidi_it after backing up to previous newline. (Bug#9212)
5576 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5578 * regex.c (re_comp): Protoize.
5579 (re_exec): Fix return type.
5580 (regexec): Fix type of `ret'. (Bug#9203)
5582 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5584 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5585 This is needed if max-image-size is a floating-point number.
5587 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5589 * print.c (print_object): Print empty symbol as ##.
5591 * lread.c (read1): Read ## as empty symbol.
5593 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5595 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5596 setting frame foreground color (Bug#9175).
5597 (x_set_background_color): Likewise.
5599 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5600 contents (Bug#9176).
5601 (EmacsTooltip -init): Remove bezels and add shadows to
5604 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5605 or scroll bar (Bug#8470).
5607 * nsfont.m (nsfont_open): Remove assignment to voffset and
5608 unnecessary vars hshink, expand, hd, full_height, min_height.
5609 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5611 * nsterm.h (nsfont_info): Remove voffset field.
5613 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5615 Implement strike-through and overline on NextStep (Bug#8863).
5617 * nsfont.m (nsfont_open): Use underline position provided by font,
5618 instead of hard-coded value of 2.
5619 (nsfont_draw): Call ns_draw_text_decoration instead.
5621 * nsterm.h: Add declaration for ns_draw_text_decoration.
5623 * nsterm.m (ns_draw_text_decoration): New function for drawing
5624 underline, overline, and strike-through.
5625 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5626 ns_draw_text_decoration. Change treatment of cursor drawing to
5627 accommodate underlining, etc.
5629 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5631 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5634 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5636 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5637 Without this fix, if a signal arrives just after memory fills up,
5638 'malloc' might be invoked reentrantly.
5640 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5641 In other words, assume that every image size is allowed, on non-X
5642 hosts. This assumption is probably wrong, but it lets Emacs compile.
5644 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5646 * regex.c (re_iswctype): Convert return values to boolean.
5648 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5650 * xdisp.c (compute_display_string_pos): Don't use cached display
5651 string position if the buffer had its restriction changed.
5654 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5656 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5658 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5660 Integer signedness and overflow and related fixes. (Bug#9079)
5662 * bidi.c: Integer size and overflow fixes.
5663 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5664 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5665 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5666 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5667 (bidi_find_other_level_edge):
5668 Use ptrdiff_t instead of EMACS_INT where either will do.
5669 This works better on 32-bit hosts configured --with-wide-int.
5670 (bidi_cache_ensure_space): Check for size-calculation overflow.
5671 Use % rather than repeated addition, for better worst-case speed.
5672 Don't set bidi_cache_size until after xrealloc returns, because it
5674 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5675 (bidi_cache_ensure_space): Also check that the bidi cache size
5676 does not exceed that of the largest Lisp string or buffer. See Eli
5677 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5679 * alloc.c (__malloc_size_t): Remove.
5680 All uses replaced by size_t. See Andreas Schwab's note
5681 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5683 * image.c: Improve checking for integer overflow.
5684 (check_image_size): Assume that f is nonnull, since
5685 it is always nonnull in practice. This is one less thing to
5686 worry about when checking for integer overflow later.
5687 (x_check_image_size): New function, which checks for integer
5688 overflow issues inside X.
5689 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5690 This removes the need for a memory_full check.
5691 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5692 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5693 (xbm_read_bitmap_data): Change locals back to 'int', since
5694 their values must fit in 'int'.
5695 (xpm_load_image, png_load, tiff_load):
5696 Invoke x_create_x_image_and_pixmap earlier,
5697 to avoid much needless work if the image is too large.
5698 (tiff_load): Treat overly large images as if
5699 x_create_x_image_and_pixmap failed, not as malloc failures.
5700 (gs_load): Use x_check_image_size.
5702 * gtkutil.c: Omit integer casts.
5703 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5704 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5706 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5708 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5709 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5710 would wrongly return t on a 64-bit host.
5712 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5713 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5714 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5715 and therefore cause GCC to emit a bogus diagnostic in some cases.
5717 * image.c: Integer signedness and overflow and related fixes.
5718 This is not an exhaustive set of fixes, but it's time to
5719 record what I've got.
5720 (lookup_pixel_color, check_image_size): Remove redundant decls.
5721 (check_image_size): Don't assume that arbitrary EMACS_INT values
5722 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5723 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5724 (tiff_load, imagemagick_load_image):
5725 Check for overflow in size calculations.
5726 (x_create_x_image_and_pixmap): Remove unnecessary test for
5727 xmalloc returning NULL; that can't happen.
5728 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5729 (xpm_color_bucket): Use better integer hashing function.
5730 (xpm_cache_color): Don't possibly over-allocate memory.
5731 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5732 (gif_memory_source):
5733 Use ptrdiff_t, not int or size_t, to record sizes.
5734 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5735 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5736 either works, as we prefer signed integers.
5737 (tiff_read_from_memory, tiff_write_from_memory):
5738 Return tsize_t, not size_t, since that's what the TIFF API wants.
5739 (tiff_read_from_memory): Don't fail simply because the read would
5740 go past EOF; instead, return a short read.
5741 (tiff_load): Omit no-longer-needed casts.
5742 (Fimagemagick_types): Don't assume size fits into 'int'.
5744 Improve hashing quality when configured --with-wide-int.
5745 * fns.c (hash_string): New function, taken from sxhash_string.
5746 Do not discard information about ASCII character case; this
5747 discarding is no longer needed.
5748 (sxhash-string): Use it. Change sig to match it. Caller changed.
5749 * lisp.h: Declare it.
5750 * lread.c (hash_string): Remove, since we now use fns.c's version.
5751 The fns.c version returns a wider integer if --with-wide-int is
5752 specified, so this should help the quality of the hashing a bit.
5754 * emacs.c: Integer overflow minor fix.
5755 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5756 Define only if GNU_LINUX.
5757 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5759 * dispnew.c: Integer signedness and overflow fixes.
5760 Remove unnecessary forward decls, that were a maintenance hassle.
5761 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5763 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5764 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5765 (prepare_desired_row, line_draw_cost):
5766 Use int, not unsigned, where either works.
5767 (save_current_matrix, restore_current_matrix):
5768 Use ptrdiff_t, not size_t, where either works.
5769 (init_display): Check for overflow more accurately, and without
5770 relying on undefined behavior.
5772 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5773 Remove, replacing with the new symbols in lisp.h. All uses changed.
5774 * fileio.c (make_temp_name):
5775 * filelock.c (lock_file_1, lock_file):
5776 * xdisp.c (message_dolog):
5777 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5778 Use pMd etc. instead.
5779 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5780 replacing the pWIDE etc. symbols removed from editfns.c.
5782 * keyboard.h (num_input_events): Now uintmax_t.
5783 This is (very slightly) less likely to mess up due to wraparound.
5786 * buffer.c: Integer signedness fixes.
5787 (alloc_buffer_text, enlarge_buffer_text):
5788 Use ptrdiff_t rather than size_t when either will do, as we prefer
5791 * alloc.c: Integer signedness and overflow fixes.
5792 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5793 (__malloc_size_t): Default to size_t, not to int.
5794 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5795 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5796 Prefer ptrdiff_t to size_t when either would do, as we prefer
5798 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5799 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5800 Now const. Initialize with values that are in range even if char
5802 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5803 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5804 These functions do the right thing with sizes > 2**32.
5805 (check_depth): Now ptrdiff_t, not int.
5806 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5807 Adjust to new way of storing sizes. Check for size overflow bugs
5809 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5810 slightly wrong anyway, as it missed one instance of
5811 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5812 (refill_memory_reserve): Omit needless cast to size_t.
5813 (mark_object_loop_halt): Mark as externally visible.
5815 * xselect.c: Integer signedness and overflow fixes.
5816 (Fx_register_dnd_atom, x_handle_dnd_message):
5817 Use ptrdiff_t, not size_t, since we prefer signed.
5818 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5819 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5820 x_dnd_atoms_size and x_dnd_atoms_length.
5822 * doprnt.c: Prefer signed to unsigned when either works.
5824 * doprnt.c (doprnt):
5826 * xdisp.c (vmessage):
5827 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5828 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5829 prefer signed arithmetic to avoid comparison confusion.
5830 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5831 but is a bit tricky.
5833 Assume freestanding C89 headers, string.h, stdlib.h.
5834 * data.c, doprnt.c, floatfns.c, print.c:
5835 Include float.h unconditionally.
5836 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5837 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5838 * regex.c: Likewise for stddef.h, string.h.
5839 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5840 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5841 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5842 (STDC_HEADERS): Remove obsolete defines.
5843 * sysdep.c: Include limits.h unconditionally.
5845 Assume support for memcmp, memcpy, memmove, memset.
5846 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5847 * regex.c (memcmp, memcpy):
5848 Remove; we assume C89 now.
5850 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5851 (__malloc_safe_bcopy): Remove; no longer needed.
5853 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5854 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5855 well either way, and we prefer signed to unsigned.
5857 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5859 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5860 closes the connection while we're reading (bug#9182).
5862 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5864 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5865 are specified (Bug#9168).
5867 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5869 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5870 Found by GCC static checking and --with-wide-int on a 32-bit host.
5872 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5874 * xdisp.c (compute_display_string_pos): Fix logic of caching
5875 previous display string position. Initialize cached_prev_pos to
5876 -1. Fixes slow-down at the beginning of a buffer.
5878 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5880 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5881 for attrs[LFACE_FONTSET_INDEX].
5883 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5885 * xml.c (parse_region): Remove unused local
5886 that was recently introduced.
5888 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5890 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5891 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5893 * xdisp.c (move_it_in_display_line_to): Record the best matching
5894 position for TO_CHARPOS while scanning the line, and restore it on
5895 exit if none of the characters scanned was an exact match.
5896 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5897 when exact match is impossible due to invisible text, and the
5898 lines are truncated.
5900 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5902 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5905 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5907 Fix a significant slow-down of cursor motion with C-n, C-p,
5908 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5909 auto-repeat under bidi redisplay in fontified buffers.
5910 * xdisp.c (compute_stop_pos_backwards): New function.
5911 (next_element_from_buffer): Call compute_stop_pos_backwards to
5912 find a suitable prev_stop when we find ourselves before
5914 (reseat): Don't look for prev_stop, as that could mean a very long
5916 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5917 <cached_disp_overlay_modiff>: Cache for last found display string
5919 (compute_display_string_pos): Return the cached position if asked
5920 about the same buffer in the same area of character positions, and
5921 the buffer wasn't changed since the time the display string
5922 position was cached.
5924 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5926 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5927 is an integer, which is important for empty lines. (Bug#9149)
5929 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5931 * frame.c (Fmodify_frame_parameters): In tty case, update the
5932 default face if necessary (Bug#4238).
5934 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5936 * editfns.c (Fstring_to_char): No need to explain what a character
5937 is in the docstring (Bug#6576).
5939 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5941 * xml.c (parse_region): Make sure we always return a tree.
5943 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5945 * xml.c (parse_region): If a document contains only comments,
5948 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5950 * xml.c (make_dom): Return comments, too.
5952 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5955 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5956 and the surrounding thread.
5957 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5958 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5959 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5961 * s/openbsd.h (BROKEN_SIGIO): Define.
5962 * unexelf.c (unexec) [__OpenBSD__]:
5963 Don't update the .mdebug section of the Alpha COFF symbol table.
5965 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5967 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5970 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5972 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5973 This fixes some race conditions on the permissions of any newly
5976 * alloc.c (valid_pointer_p): Use pipe, not open.
5977 This fixes some permissions issues when debugging.
5979 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5980 If fchown fails to set both uid and gid, try to set just gid,
5981 as that is sometimes allowed. Adjust the file's mode to eliminate
5982 setuid or setgid bits that are inappropriate if fchown fails.
5984 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5986 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5987 to compare Lisp_Objects.
5988 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5989 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5990 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5992 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5994 * lread.c (read_integer): Unread even EOF character.
5995 (read1): Likewise. Properly record start position of symbol.
5997 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5998 symbol character follows.
6000 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6002 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6003 This works around a problem with the previous change to Fcopy_file.
6004 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6005 and without this change, GCC might complain about discarding
6006 fchown's return value.
6008 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6010 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6012 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6014 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6016 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6018 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6019 it's used from the C level.
6021 * process.c: Use the same condition for POLL_FOR_INPUT in both
6022 keyboard.c and process.c (bug#1858).
6024 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6026 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6027 (Fgnutls_boot): Use it.
6029 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6031 * doc.c (Fsubstitute_command_keys): Revert last change.
6033 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6035 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6036 quotes the next character, and doesn't affect other longer
6037 sequences (bug#8935).
6039 * lread.c (syms_of_lread): Clarify that is isn't only
6040 `eval-buffer' and `eval-defun' that's affected by
6041 `lexical-binding' (bug#8460).
6043 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6045 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6046 bidi redisplay when a line includes both an image and is truncated.
6048 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6050 Fix minor problems found by static checking.
6051 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6052 (elsz): Now a signed constant, not a size_t var. We prefer signed
6053 types to unsigned, to avoid integer comparison confusion. Without
6054 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6055 "cannot optimize loop, the loop counter may overflow", a symptom
6057 * indent.c (Fvertical_motion): Mark locals as initialized.
6058 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6060 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6062 * search.c (Fre_search_backward): Mention `case-fold-search' in
6063 all the re_search_* functions (bug#8138).
6065 * keyboard.c (Fopen_dribble_file): Document when the file is
6068 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6070 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6073 Support bidi reordering of display and overlay strings.
6074 * xdisp.c (compute_display_string_pos)
6075 (compute_display_string_end): Accept additional argument STRING.
6076 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6077 (reseat_to_string): Initialize bidi_it->string.s and
6078 bidi_it->string.schars.
6079 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6080 NULL (avoids a crash in bidi_paragraph_init).
6081 Initialize itb.string.lstring.
6082 (init_iterator): Call bidi_init_it only of a valid
6083 buffer position was specified. Initialize paragraph_embedding to
6085 (reseat_to_string): Initialize the bidi iterator.
6086 (display_string): If we need to ignore text properties of
6087 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6088 original value of -1 will not work with bidi.)
6089 (compute_display_string_pos): First arg is now struct
6090 `text_pos *'; all callers changed. Support display properties on
6092 (compute_display_string_end): Support display properties on Lisp
6094 (init_iterator, reseat_1, reseat_to_string): Initialize the
6095 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6096 when iterating on a string not from display properties).
6097 (compute_display_string_pos, compute_display_string_end):
6098 Fix calculation of the object to scan. Fixes an error when using
6100 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6101 base_level_stop; instead, set base_level_stop to BEGV.
6102 Fixes crashes in vertical-motion.
6103 (next_element_from_buffer): Improve commentary for when
6104 the iterator is before prev_stop.
6105 (init_iterator): Initialize bidi_p from the default value of
6106 bidi-display-reordering, not from buffer-local value. Use the
6107 buffer-local value only if initializing for buffer iteration.
6108 (handle_invisible_prop): Support invisible properties on strings
6109 that are being bidi-reordered.
6110 (set_iterator_to_next): Support bidi reordering of C strings and
6112 (next_element_from_string): Support bidi reordering of Lisp
6114 (handle_stop_backwards): Support Lisp strings as well.
6115 (display_string): Support display of R2L glyph rows.
6116 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6117 (init_iterator): Don't initialize it->bidi_p for strings
6119 (reseat_to_string): Initialize it->bidi_p for strings here.
6120 (next_element_from_string, next_element_from_c_string)
6121 (next_element_from_buffer): Add xassert's for correspondence
6122 between IT's object being iterated and it->bidi_it.string
6124 (face_before_or_after_it_pos): Support bidi iteration.
6125 (next_element_from_c_string): Handle the case of the first string
6126 character that is not the first one in the visual order.
6127 (get_visually_first_element): New function, refactored from common
6128 parts of next_element_from_buffer, next_element_from_string, and
6129 next_element_from_c_string.
6130 (tool_bar_lines_needed, redisplay_tool_bar)
6131 (display_menu_bar): Force left-to-right direction. Add a FIXME
6132 comment for making that be controlled by a user option.
6133 (push_it, pop_it): Save and restore the state of the
6134 bidi iterator. Save and restore the bidi_p flag.
6135 (pop_it): Iterate out of display property for string iteration as
6137 (iterate_out_of_display_property): Support iteration over strings.
6138 (handle_single_display_spec): Set up it->bidi_it for iteration
6139 over a display string, and call bidi_init_it.
6140 (handle_single_display_spec, next_overlay_string)
6141 (get_overlay_strings_1, push_display_prop): Set up the bidi
6142 iterator for displaying display or overlay strings.
6143 (forward_to_next_line_start): Don't use the shortcut if
6145 (back_to_previous_visible_line_start): If handle_display_prop
6146 pushed the iterator stack, restore the internal state of the bidi
6147 iterator by calling bidi_pop_it same number of times.
6148 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6149 and we are bidi-iterating, don't decrement the iterator position;
6150 instead, set the first_elt flag in the bidi iterator, to produce
6152 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6153 (push_display_prop): xassert that we are iterating a buffer.
6154 (push_it, pop_it): Save and restore paragraph_embedding member.
6155 (handle_single_display_spec, next_overlay_string)
6156 (get_overlay_strings_1, reseat_1, reseat_to_string)
6157 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6158 correctly. Don't assume unibyte strings are not bidi-reordered.
6159 (compute_display_string_pos)
6160 (compute_display_string_end): Fix handling the case of C string.
6161 (push_it, pop_it): Save and restore from_disp_prop_p.
6162 (handle_single_display_spec, push_display_prop): Set the
6163 from_disp_prop_p flag.
6164 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6165 (pop_it): Call iterate_out_of_display_property only if we are
6166 popping after iteration over a string that came from a display
6167 property. Fix a typo in popping stretch info. Add an assertion
6168 for verifying that the iterator position is in sync with the bidi
6170 (handle_single_display_spec, get_overlay_strings_1)
6171 (push_display_prop): Fix initialization of paragraph direction for
6172 string when that of the parent object is not yet determined.
6173 (reseat_1): Call bidi_init_it to resync the bidi
6174 iterator with IT's position. (Bug#7616)
6175 (find_row_edges): If ROW->start.pos gives position
6176 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6177 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6178 Reset the from_disp_prop_p flag.
6179 (SAVE_IT, RESTORE_IT): New macros.
6180 (pos_visible_p, face_before_or_after_it_pos)
6181 (back_to_previous_visible_line_start)
6182 (move_it_in_display_line_to, move_it_in_display_line)
6183 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6184 (try_scrolling, redisplay_window, display_line): Use them when
6185 saving a temporary copy of the iterator and restoring it back.
6186 (back_to_previous_visible_line_start, reseat_1)
6187 (init_iterator): Empty the bidi cache "stack".
6188 (move_it_in_display_line_to): If iterator ended up at
6189 EOL, but we never saw any buffer positions smaller than
6190 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6191 motion in bidi-reordered lines.
6192 (move_it_in_display_line_to): Record prev_method and prev_pos
6193 immediately before the call to set_iterator_to_next. Fixes cursor
6194 motion in bidi-reordered lines with stretch glyphs and strings
6195 displayed in margins. (Bug#8133) (Bug#8867)
6196 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6198 (pos_visible_p): Support positions in bidi-reordered lines.
6199 Save and restore bidi cache.
6201 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6202 (bidi_paragraph_info): Delete unused struct.
6203 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6204 (bidi_cache_start): New variable.
6205 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6207 (bidi_cache_fetch_state, bidi_cache_search)
6208 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6209 (bidi_cache_find, bidi_peek_at_next_level)
6210 (bidi_level_of_next_char, bidi_find_other_level_edge)
6211 (bidi_move_to_visually_next): Compare cache index with
6212 bidi_cache_start rather than with zero.
6213 (bidi_fetch_char): Accept new argument STRING; all callers
6214 changed. Support iteration over a string. Support strings with
6215 display properties. Support unibyte strings. Fix the type of
6216 `len' according to what STRING_CHAR_AND_LENGTH expects.
6217 (bidi_paragraph_init, bidi_resolve_explicit_1)
6218 (bidi_resolve_explicit, bidi_resolve_weak)
6219 (bidi_level_of_next_char, bidi_move_to_visually_next):
6220 Support iteration over a string.
6221 (bidi_set_sor_type, bidi_resolve_explicit_1)
6222 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6223 can now be zero (for strings); special values 0 and -1 were
6224 changed to -1 and -2, respectively.
6225 (bidi_char_at_pos): New function.
6226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6227 Call it instead of FETCH_MULTIBYTE_CHAR.
6228 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6229 initialized to valid values.
6230 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6232 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6233 the test for valid cached positions. Fix the logic for looking up
6234 the sentinel state in the cache. GCPRO the Lisp string we are
6236 (bidi_push_it, bidi_pop_it): New functions.
6237 (bidi_initialize): Initialize the bidi cache start stack pointer.
6238 (bidi_cache_ensure_space): New function, refactored from part of
6239 bidi_cache_iterator_state. Don't assume the required size is just
6240 one BIDI_CACHE_CHUNK away.
6241 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6242 (bidi_count_bytes, bidi_char_at_pos): New functions.
6243 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6244 always valid if bidi_cache_idx is valid.
6245 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6246 is valid if it's going to be used.
6247 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6248 (bidi_cache_fetch_state, bidi_cache_search)
6249 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6250 (bidi_cache_iterator_state, bidi_cache_find)
6251 (bidi_find_other_level_edge, bidi_cache_start_stack):
6252 All variables related to cache indices are now EMACS_INT.
6254 * dispextern.h (struct bidi_string_data): New structure.
6255 (struct bidi_it): New member `string'. Make flag members be 1-bit
6256 fields, and put them last in the struct.
6257 (compute_display_string_pos, compute_display_string_end):
6259 (bidi_push_it, bidi_pop_it): Add prototypes.
6260 (struct iterator_stack_entry): New members bidi_p,
6261 paragraph_embedding, and from_disp_prop_p.
6262 (struct it): Member bidi_p is now a bit field 1 bit wide.
6263 (bidi_shelve_cache, bidi_unshelve_cache):
6266 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6267 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6268 and vector-like objects.
6270 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6271 cache around display iteration.
6273 * window.c (Fwindow_end, window_scroll_pixel_based)
6274 (displayed_window_lines, Frecenter): Save and restore the bidi
6275 cache around display iteration.
6277 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6279 * editfns.c (Fdelete_region): Clarify the use of the named
6280 parameters (bug#6788).
6282 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6284 * indent.c (Fvertical_motion): Set and restore w->pointm when
6285 saving and restoring the window's buffer (Bug#9006).
6287 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6289 * editfns.c (Fstring_to_char): Clarify just what is returned
6290 (bug#6576). Text by Eli Zaretskii.
6292 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6294 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6296 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6298 * buffer.c (mmap_find): Fix a typo.
6300 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6302 Fix execution of x selection hooks.
6303 * xselect.c (Qx_lost_selection_functions)
6304 (Qx_sent_selection_functions): New vars.
6305 (syms_of_xselect): DEFSYM them.
6306 (x_handle_selection_request): Pass Qx_sent_selection_functions
6307 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6308 (x_handle_selection_clear,x_clear_frame_selections):
6309 Pass Qx_lost_selection_functions rather than
6310 Vx_lost_selection_functions to Frun_hook_with_args.
6312 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6314 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6315 The old code sometimes used this field without initializing it.
6317 * alloc.c (gc_sweep): Don't read past end of array.
6318 In theory, the old code could also have corrupted Emacs internals,
6319 though it'd be very unlikely.
6321 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6323 * character.c (Fcharacterp): Don't advertise optional ignored
6324 argument. (Bug#4026)
6326 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6328 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6331 * window.c (Fset_window_start): Doc fix (bug#4199).
6332 (Fset_window_hscroll): Ditto.
6334 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6336 Fix minor new problems caught by GCC 4.6.1.
6337 * term.c (init_tty): Remove unused local.
6338 * xsettings.c (store_monospaced_changed): Define this function only
6339 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6342 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6344 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6346 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6348 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6349 are the mini-buffer and the echo area (bug#3320).
6351 * term.c (init_tty): Remove support for supdup, c10 and perq
6352 terminals, which are no longer supported (bug#1482).
6354 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6356 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6358 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6360 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6361 for non-popups (Bug#3642).
6363 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6365 * alloc.c (reset_malloc_hooks): Protoize.
6366 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6367 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6368 * cm.c (losecursor): Likewise.
6369 * data.c (fmod): Likewise.
6370 * dispnew.c (swap_glyphs_in_rows): Likewise.
6371 * emacs.c (memory_warning_signal): Likewise.
6372 * floatfns.c (float_error): Likewise.
6373 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6374 (otf_open, font_otf_capability, generate_otf_features)
6375 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6377 * image.c (pbm_read_file): Likewise.
6378 * indent.c (string_display_width): Likewise.
6379 * intervals.c (check_for_interval, search_for_interval)
6380 (inc_interval_count, count_intervals, root_interval)
6381 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6382 * lread.c (defalias): Likewise.
6383 * ralloc.c (r_alloc_check): Likewise.
6384 * regex.c (set_image_of_range_1, set_image_of_range)
6385 (regex_grow_registers): Likewise.
6386 * sysdep.c (strerror): Likewise.
6387 * termcap.c (valid_filename_p, tprint, main): Likewise.
6388 * tparam.c (main): Likewise.
6389 * unexhp9k800.c (run_time_remap, save_data_space)
6390 (update_file_ptrs, read_header, write_header, calculate_checksum)
6391 (copy_file, copy_rest, display_header): Likewise.
6392 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6394 * xdisp.c (check_it): Likewise.
6395 * xfaces.c (register_color, unregister_color, unregister_colors):
6397 * xfns.c (print_fontset_result): Likewise.
6398 * xrdb.c (member, fatal, main): Likewise.
6400 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6402 Fix minor problems found by static checking (Bug#9031).
6403 * chartab.c (char_table_set_range, map_sub_char_table):
6404 Remove unused locals.
6405 (uniprop_table): Now static.
6406 * composite.c (_work_char): Remove unused static var.
6408 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6410 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6412 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6414 * gtkutil.c (qttip_cb): Remove code without function.
6416 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6418 * w32.c (pthread_sigmask): New stub.
6420 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6422 Use pthread_sigmask, not sigprocmask (Bug#9010).
6423 sigprocmask is portable only for single-threaded applications, and
6424 Emacs can be multi-threaded when it uses GTK.
6425 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6427 * callproc.c (Fcall_process):
6428 * process.c (create_process):
6429 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6430 Use pthread_sigmask, not sigprocmask.
6432 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6434 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6435 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6438 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6440 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6441 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6442 (xg_hide_tooltip): Fix comment.
6444 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6445 in registerServicesMenuSendTypes.
6446 (validRequestorForSendType): Don't check ns_return_types.
6448 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6451 2011-07-08 Jason Rumney <jasonr@gnu.org>
6453 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6454 SH_SHOW for hidden windows (Bug#5482).
6456 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6457 frame struct members of non-existent frames (Bug#6284).
6459 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6461 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6462 variable firstTime not needed on OSX >= 10.6.
6463 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6464 >= 10.5. Use setKnobProportion, setDoubleValue.
6466 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6467 (MAC_OS_X_VERSION_10_5): Define if not defined.
6468 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6469 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6470 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6472 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6473 cString and lossyCString on OSX >= 10.4
6475 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6476 sizeToFit on OSX >= 10.2.
6478 * nsimage.m (allocInitFromFile): Don't use deprecated method
6479 bestRepresentationForDevice on OSX >= 10.6.
6481 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6484 * emacs.c: Declare unexec_init_emacs_zone.
6486 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6488 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6490 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6491 on svcsMenu (Bug#8842).
6493 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6495 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6497 * nsterm.m (QUTF8_STRING): Declare.
6498 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6499 (validRequestorForSendType): Return type is (id).
6500 Change indexOfObjectIdenticalTo to indexOfObject.
6501 Check if we have local selection before returning self (Bug#8842).
6502 (writeSelectionToPasteboard): Put local selection into paste board
6503 if we have a local selection (Bug#8842).
6504 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6506 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6507 (ns_get_local_selection): Declare.
6509 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6511 * keymap.c (describe_map_tree): Don't insert a double newline at
6512 the end of the buffer (bug#1169) and return whether we inserted
6515 * callint.c (Fcall_interactively): Change "reading args" to
6516 "providing args" to try to clarify what it does (bug#1010).
6518 2011-07-07 Kenichi Handa <handa@m17n.org>
6520 * composite.c (composition_compute_stop_pos): Ignore a static
6521 composition starting before CHARPOS (Bug#8915).
6523 * xdisp.c (handle_composition_prop): Likewise.
6525 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6527 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6530 2011-07-07 Kenichi Handa <handa@m17n.org>
6532 * character.h (unicode_category_t): New enum type.
6534 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6535 (Qchar_code_property_table): New variable.
6536 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6537 (UNIPROP_COMPRESSED_FORM_P): New macros.
6538 (char_table_ascii): Uncompress the compressed values.
6539 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6540 Uncompress the compressed values.
6541 (sub_char_table_ref_and_range): Likewise.
6542 (char_table_ref_and_range): Uncompress the compressed values.
6543 (sub_char_table_set): New arg is_uniprop. Callers changed.
6544 Uncompress the compressed values.
6545 (sub_char_table_set_range): Args changed. Callers changed.
6546 (char_table_set_range): Adjuted for the above change.
6547 (map_sub_char_table): Delete args default_val and parent. Add arg
6548 top. Give decoded values to a Lisp function.
6549 (map_char_table): Adjust for the above change. Give decoded
6550 values to a Lisp function. Gcpro more variables.
6551 (uniprop_table_uncompress)
6552 (uniprop_decode_value_run_length): New functions.
6553 (uniprop_decoder, uniprop_decoder_count): New variables.
6554 (uniprop_get_decoder, uniprop_encode_value_character)
6555 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6557 (uniprop_encoder, uniprop_encoder_count): New variables.
6558 (uniprop_get_encoder, uniprop_table)
6559 (Funicode_property_table_internal, Fget_unicode_property_internal)
6560 (Fput_unicode_property_internal): New functions.
6561 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6562 Sunicode_property_table_internal, Sget_unicode_property_internal,
6563 and Sput_unicode_property_internal. Defvar_lisp
6564 char-code-property-alist.
6566 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6567 Vunicode_category_table.
6569 * font.c (font_range): Adjust for the change of
6570 Vunicode_category_table.
6572 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6574 * m/iris4d.h: Remove file, move contents ...
6575 * s/irix6-5.h: ... here.
6577 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6579 Remove unportable assumption about struct layout (Bug#8884).
6580 * alloc.c (mark_buffer):
6581 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6582 (clone_per_buffer_values): Don't assume that
6583 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6584 This isn't true in general, and it's particularly not true
6585 if Emacs is configured with --with-wide-int.
6586 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6587 New macros, used in the buffer.c change.
6589 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6591 * xsettings.c: Use both GConf and GSettings if both are available.
6592 (store_config_changed_event): Add comment.
6593 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6594 (store_tool_bar_style_changed): New functions.
6595 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6596 (struct xsettings): Move font inside HAVE_XFT.
6597 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6598 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6599 Move inside HAVE_XFT.
6600 (something_changed_gsettingsCB): Rename from something_changedCB.
6601 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6603 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6604 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6605 (something_changed_gconfCB): Rename from something_changedCB.
6606 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6607 (parse_settings): Move check for font inside HAVE_XFT.
6608 (read_settings, apply_xft_settings): Add comment.
6609 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6610 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6611 call store_font_name_changed.
6612 (xft_settings_event): Add comment.
6613 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6614 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6615 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6616 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6617 (xsettings_initialize): Call init_gsettings last.
6618 (xsettings_get_system_font, xsettings_get_system_normal_font):
6621 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6623 Random fixes. E.g., (random) never returned negative values.
6624 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6625 subseconds part to the entropy, as that's a bit more random.
6626 Prefer signed to unsigned, since the signedness doesn't matter and
6627 in general we prefer signed. When given a limit, use a
6628 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6629 latter isn't right if USE_2_TAGS_FOR_INTS.
6630 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6631 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6633 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6635 * textprop.c (text_property_stickiness):
6636 Obey Vtext_property_default_nonsticky.
6637 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6638 * w32fns.c (syms_of_w32fns):
6639 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6641 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6643 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6644 This is more efficient than Ffile_directory_p and avoids a minor race.
6646 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6648 * buffer.c (Foverlay_put): Say what the return value is
6651 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6652 is a directory before asking whether to use the file name
6654 (barf_or_query_if_file_exists): Make the "File is a directory"
6655 error be more correct.
6657 * fns.c (Frequire): Remove the mention of the .gz files, since
6658 that's installation-specific, but keep the mention of
6659 `get-load-suffixes'.
6661 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6663 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6664 Report string overflow if the output is too long.
6666 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6668 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6669 (syms_of_gnutls): Remove duplicate DEFSYM for
6670 Qgnutls_bootprop_verify_hostname_error, an error for
6671 Qgnutls_bootprop_verify_error (which is no longer used).
6673 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6674 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6675 Also (re)move comments that are misplaced or no longer relevant.
6677 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6679 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6681 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6683 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6684 and background color parameters if they have been changed.
6686 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6688 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6690 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6692 * xsettings.c (SYSTEM_FONT): Define only when used.
6693 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6695 * keymap.c (access_keymap_1): Now static.
6697 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6699 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6700 leave any prefix arg for the up event (Bug#1586).
6702 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6704 * lread.c (syms_of_lread): Mention single symbols defined by
6705 `defvar' or `defconst' (bug#7154).
6707 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6708 (Frequire): Mention get-load-suffixes.
6710 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6712 * window.h (window): Remove clone_number slot.
6713 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6715 (make_parent_window, make_window, saved_window)
6716 (Fset_window_configuration, save_window_save): Don't deal with
6718 * buffer.c (Qclone_number): Remove declaration.
6719 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6721 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6723 Add multiple inheritance to keymaps.
6724 * keymap.c (Fmake_composed_keymap): New function.
6725 (Fset_keymap_parent): Simplify.
6726 (fix_submap_inheritance): Remove.
6727 (access_keymap_1): New function extracted from access_keymap to handle
6728 embedded parents and handle lists of maps.
6729 (access_keymap): Use it.
6730 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6731 (Fcopy_keymap): Handle embedded parents.
6732 (Fcommand_remapping, define_as_prefix): Simplify.
6733 (Fkey_binding): Simplify.
6734 (syms_of_keymap): Move minibuffer-local-completion-map,
6735 minibuffer-local-filename-completion-map,
6736 minibuffer-local-must-match-map, and
6737 minibuffer-local-filename-must-match-map to Elisp.
6738 (syms_of_keymap): Defsubr make-composed-keymap.
6739 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6740 (parse_menu_item): Trivial simplification.
6742 2011-07-01 Glenn Morris <rgm@gnu.org>
6744 * Makefile.in (SETTINGS_LIBS): Fix typo.
6746 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6748 * coding.c (Fencode_coding_string): Record the last coding system
6749 used, as the function doc string says (bug#8738).
6751 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6753 * xsettings.c (store_monospaced_changed): Take new font as arg and
6754 check for change against current_mono_font.
6755 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6756 (emacs_settings_constructor, emacs_settings_get_property)
6757 (emacs_settings_set_property, emacs_settings_class_init)
6758 (emacs_settings_init, gsettings_obj): Remove.
6759 (something_changedCB): New function for HAVE_GSETTINGS.
6760 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6761 with value as argument.
6762 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6763 g_settings_new (Bug#8967). Do not create gsettings_obj.
6764 Remove calls to g_settings_bind. Connect something_changedCB to
6767 * xgselect.c: Add defined (HAVE_GSETTINGS).
6768 (xgselect_initialize): Ditto.
6770 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6771 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6774 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6776 * eval.c (struct backtrace): Simplify and port the data structure.
6777 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6778 signed bit field, as this assumption is not portable and it makes
6779 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6780 "char debug_on_exit : 1" as this is not portable either; instead,
6781 use the portable "unsigned int debug_on_exit : 1". Remove unused
6782 member evalargs. Remove obsolete comments about cc bombing out.
6784 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6786 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6787 Let HAVE_GSETTINGS override HAVE_GCONF.
6788 (store_monospaced_changed): New function.
6789 (EMACS_SETTINGS): A new type derived from GObject to handle
6790 GSettings notifications.
6791 (emacs_settings_constructor, emacs_settings_get_property)
6792 (emacs_settings_set_property, emacs_settings_class_init):
6794 (gsettings_client, gsettings_obj): New variables.
6795 (GSETTINGS_SCHEMA): New define.
6796 (something_changedCB): Call store_monospaced_changed.
6797 (init_gsettings): New function.
6798 (xsettings_initialize): Call init_gsettings.
6799 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6802 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6805 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6807 * window.c (resize_root_window, grow_mini_window)
6808 (shrink_mini_window): Rename Qresize_root_window to
6809 Qwindow_resize_root_window and Qresize_root_window_vertically to
6810 Qwindow_resize_root_window_vertically.
6812 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6814 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6816 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6818 * makefile.w32-in: Redesign dependencies so they reflect more
6819 clearly which files are directly included by each source file,
6820 and not through other includes.
6822 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6824 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6825 (sort_overlays, overlay_strings): When an overlay's clone number
6826 matches the window's clone number process the overlay even if
6827 the overlay's window property doesn't match the current window.
6829 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6830 (Fwindow_hchild): Rename to Fwindow_left_child.
6831 (Fwindow_next): Rename to Fwindow_next_sibling.
6832 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6833 (resize_window_check): Rename to window_resize_check.
6834 (resize_window_apply): Rename to window_resize_apply.
6835 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6836 (Fdelete_other_windows_internal, resize_frame_windows)
6837 (Fsplit_window_internal, Fdelete_window_internal)
6838 (grow_mini_window, shrink_mini_window)
6839 (Fresize_mini_window_internal): Fix callers accordingly.
6841 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6843 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6844 (emacs_fixed_set_min_size): Remove.
6845 (emacs_fixed_new): Take frame as argument.
6847 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6848 (_EmacsFixedPrivate): Remove minwidth/height.
6849 Add struct frame *f.
6850 (emacs_fixed_init): Initialize priv->f.
6851 (get_parent_class, emacs_fixed_set_min_size): Remove.
6852 (emacs_fixed_new): Set priv->f to argument.
6853 (emacs_fixed_get_preferred_width)
6854 (emacs_fixed_get_preferred_height): Use min_width/height from
6855 frames size_hint to set minimum and natural (Bug#8919).
6856 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6857 and use min_width/height from frames size_hint to set
6858 min_width/height (Bug#8919).
6860 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6861 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6864 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6866 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6867 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6870 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6872 * process.c (wait_reading_process_output): Bypass select if
6873 waiting for a cell while ignoring keyboard input, and input is
6874 pending. Suggested by Jan Djärv (Bug#8869).
6876 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6878 Use gnulib's dup2 module instead of rolling our own.
6879 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6881 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6883 * dispnew.c (scrolling_window): Before scrolling, turn off a
6884 mouse-highlight in the window being scrolled.
6886 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6888 Move DEFSYM to lisp.h and use everywhere.
6890 * character.h (DEFSYM): Move declaration...
6891 * lisp.h (DEFSYM): ...here.
6897 * w32select.c: Don't include character.h.
6899 * alloc.c (syms_of_alloc):
6900 * buffer.c (syms_of_buffer):
6901 * bytecode.c (syms_of_bytecode):
6902 * callint.c (syms_of_callint):
6903 * casefiddle.c (syms_of_casefiddle):
6904 * casetab.c (init_casetab_once):
6905 * category.c (init_category_once, syms_of_category):
6906 * ccl.c (syms_of_ccl):
6907 * cmds.c (syms_of_cmds):
6908 * composite.c (syms_of_composite):
6909 * dbusbind.c (syms_of_dbusbind):
6910 * dired.c (syms_of_dired):
6911 * dispnew.c (syms_of_display):
6912 * doc.c (syms_of_doc):
6913 * editfns.c (syms_of_editfns):
6914 * emacs.c (syms_of_emacs):
6915 * eval.c (syms_of_eval):
6916 * fileio.c (syms_of_fileio):
6917 * fns.c (syms_of_fns):
6918 * frame.c (syms_of_frame):
6919 * fringe.c (syms_of_fringe):
6920 * insdel.c (syms_of_insdel):
6921 * keymap.c (syms_of_keymap):
6922 * lread.c (init_obarray, syms_of_lread):
6923 * macros.c (syms_of_macros):
6924 * msdos.c (syms_of_msdos):
6925 * print.c (syms_of_print):
6926 * process.c (syms_of_process):
6927 * search.c (syms_of_search):
6928 * sound.c (syms_of_sound):
6929 * syntax.c (init_syntax_once, syms_of_syntax):
6930 * terminal.c (syms_of_terminal):
6931 * textprop.c (syms_of_textprop):
6932 * undo.c (syms_of_undo):
6933 * w32.c (globals_of_w32):
6934 * window.c (syms_of_window):
6935 * xdisp.c (syms_of_xdisp):
6936 * xfaces.c (syms_of_xfaces):
6937 * xfns.c (syms_of_xfns):
6938 * xmenu.c (syms_of_xmenu):
6939 * xsettings.c (syms_of_xsettings):
6940 * xterm.c (syms_of_xterm): Use DEFSYM.
6942 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6944 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6946 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6948 Integer and buffer overflow fixes (Bug#8873).
6950 * print.c (printchar, strout): Check for string overflow.
6951 (PRINTPREPARE, printchar, strout):
6952 Don't set size unless allocation succeeds.
6954 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6955 for sizes. Check for string overflow more accurately.
6956 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6958 * macros.c: Integer and buffer overflow fixes.
6959 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6960 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6961 Use ptrdiff_t, not int, for sizes.
6962 Don't increment bufsize until after realloc succeeds.
6963 Check for size-calculation overflow.
6964 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6966 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6968 * lread.c: Integer overflow fixes.
6969 (read_integer): Radix is now EMACS_INT, not int,
6970 to improve quality of diagnostics for out-of-range radices.
6971 Calculate buffer size correctly for out-of-range radices.
6972 (read1): Check for integer overflow in radices, and in
6973 read-circle numbers.
6974 (read_escape): Avoid int overflow.
6975 (Fload, openp, read_buffer_size, read1)
6976 (substitute_object_recurse, read_vector, read_list, map_obarray):
6977 Use ptrdiff_t, not int, for sizes.
6978 (read1): Use EMACS_INT, not int, for sizes.
6979 Check for size overflow.
6981 * image.c (cache_image): Check for size arithmetic overflow.
6983 * lread.c: Integer overflow issues.
6984 (saved_doc_string_size, saved_doc_string_length)
6985 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6986 Now ptrdiff_t, not int.
6987 (read1): Don't assume doc string length fits in int. Check for
6988 out-of-range doc string lengths.
6989 (read_list): Don't assume file position fits in int.
6990 (read_escape): Check for hex character overflow.
6992 2011-06-22 Leo Liu <sdl.web@gmail.com>
6994 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6995 Move to minibuffer.el.
6997 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6999 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7000 The following patches are for when GLYPH_DEBUG && !XASSERT.
7001 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7002 * dispnew.c (flush_stdout):
7003 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7004 Mark as externally visible.
7005 * dispnew.c (check_window_matrix_pointers): Now static.
7006 * dispnew.c (window_to_frame_vpos):
7007 * xfns.c (unwind_create_frame):
7008 * xterm.c (x_check_font): Remove unused local.
7009 * scroll.c (CHECK_BOUNDS):
7010 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7011 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7012 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7013 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7014 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7016 (debug_method_add): Use va_list and vsprintf rather than relying
7017 on undefined behavior with wrong number of arguments.
7018 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7019 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7020 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7021 since we're not interested in debugging glyphs with old libraries.
7022 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7023 GCC 4.6.0's static checking.
7025 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7027 Integer overflow and signedness fixes (Bug#8873).
7028 A few related buffer overrun fixes, too.
7030 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7032 * dispextern.h (struct face.stipple):
7033 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7034 (x_bitmap_mask, x_allocate_bitmap_record)
7035 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7036 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7037 (x_create_bitmap_from_xpm_data):
7038 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7039 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7041 * xfaces.c (load_pixmap):
7042 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7043 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7044 (.bitmaps_last, struct x_output.icon_bitmap):
7045 Use ptrdiff_t, not int, for bitmap indexes.
7046 (x_allocate_bitmap_record): Check for size overflow.
7047 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7049 Use ptrdiff_t, not int, for overlay counts.
7050 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7051 * editfns.c (overlays_around, get_pos_property):
7052 * textprop.c (get_char_property_and_overlay):
7053 * xdisp.c (next_overlay_change, note_mouse_highlight):
7054 * xfaces.c (face_at_buffer_position):
7055 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7056 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7057 (Fnext_overlay_change, Fprevious_overlay_change)
7058 (mouse_face_overlay_overlaps, Foverlays_in):
7059 Use ptrdiff_t, not int, for sizes.
7060 (overlays_at, overlays_in): Check for size-calculation overflow.
7062 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7064 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7065 (x_session_initialize): Do not assume string length fits in int.
7067 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7068 This is unlikely, but can occur if DPI is outlandish.
7070 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7071 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7073 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7074 * xrdb.c (magic_file_p, search_magic_path):
7075 Omit last arg SUFFIX; it was always 0. All callers changed.
7076 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7078 * xfont.c (xfont_match): Avoid need for strlen.
7080 * xfns.c: Don't assume strlen fits in int.
7081 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7083 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7084 not unsigned long, as we prefer signed integers. All callers changed.
7085 Detect integer overflow in repeat count.
7086 (message_dolog): Don't assume print length fits in 39 bytes.
7087 (display_mode_element): Don't assume strlen fits in int.
7089 * termcap.c: Don't assume sizes fit in int and never overflow.
7090 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7091 (gobble_line): Check for size-calculation overflow.
7093 * minibuf.c (Fread_buffer):
7094 * lread.c (intern, intern_c_string):
7095 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7096 Don't assume string length fits in int.
7098 * keyboard.c (parse_tool_bar_item):
7099 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7101 * font.c: Don't assume string length fits in int.
7102 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7103 Use ptrdiff_t, not int.
7104 (font_intern_prop): Don't assume string length fits in int.
7105 Don't assume integer property fits in fixnum.
7106 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7108 * filelock.c: Fix some buffer overrun and integer overflow issues.
7109 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7110 Reformulate so as not to need the command string.
7111 Invoke gzip -cd rather than gunzip, as it's more portable.
7112 (lock_info_type, lock_file_1, lock_file):
7113 Don't assume pid_t and time_t fit in unsigned long.
7114 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7115 (current_lock_owner): Prefer signed type for sizes.
7116 Use memcpy, not strncpy, where memcpy is what is really wanted.
7117 Don't assume (via atoi) that time_t and pid_t fit in int.
7118 Check for time_t and/or pid_t out of range, e.g., via a network share.
7119 Don't alloca where an auto var works fine.
7121 * fileio.c: Fix some integer overflow issues.
7122 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7123 Don't assume string length fits in int.
7124 (directory_file_name): Don't assume string length fits in long.
7125 (make_temp_name): Don't assume pid fits in int, or that its print
7126 length is less than 20.
7128 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7130 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7132 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7134 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7135 We prefer signed integers, even for size calculations.
7137 * emacs.c: Don't assume string length fits in 'int'.
7138 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7139 (main): Don't invoke strlen when not needed.
7141 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7142 (XD_DEBUG_MESSAGE): Don't waste a byte.
7144 * callproc.c (getenv_internal_1, getenv_internal)
7146 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7148 * lread.c (invalid_syntax): Omit length argument.
7149 All uses changed. This doesn't fix a bug, but it simplifies the
7150 code away from its former Hollerith-constant appearance, and it's
7151 one less 'int' to worry about when looking at integer-overflow issues.
7152 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7154 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7155 This didn't break anything, but it didn't help either.
7156 It's confusing to put a bogus integer in a place where the actual
7157 value does not matter.
7158 (LIST_END_P): Remove unused macro and its bogus comment.
7159 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7161 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7162 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7164 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7165 We prefer signed types, and the value cannot exceed the EMACS_INT
7166 range anyway (because otherwise the length would not be representable).
7167 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7168 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7169 This avoids a GCC warning when WIDE_EMACS_INT.
7171 * indent.c (sane_tab_width): New function.
7172 (current_column, scan_for_column, Findent_to, position_indentation)
7173 (compute_motion): Use it. This is just for clarity.
7174 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7176 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7178 * lisp.h (lint_assume): New macro.
7179 * composite.c (composition_gstring_put_cache):
7180 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7182 * editfns.c, insdel.c:
7183 Omit unnecessary forward decls, to simplify future changes.
7185 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7187 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7189 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7190 Use much-faster test for byte-length change.
7191 Don't assume string byte-length fits in 'int'.
7192 Check that character arg fits in 'int'.
7193 (mapcar1): Declare byte as byte, for clarity.
7195 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7197 * fns.c (concat): Catch string overflow earlier.
7198 Do not rely on integer wraparound.
7200 * dispextern.h (struct it.overlay_strings_charpos)
7201 (struct it.selective): Now EMACS_INT, not int.
7202 * xdisp.c (forward_to_next_line_start)
7203 (back_to_previous_visible_line_start)
7204 (reseat_at_next_visible_line_start, next_element_from_buffer):
7205 Don't arbitrarily truncate the value of 'selective' to int.
7207 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7209 * composite.c: Don't truncate sizes to 'int'.
7210 (composition_gstring_p, composition_reseat_it)
7211 (composition_adjust_point): Use EMACS_INT, not int.
7212 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7213 not EMACS_UINT, for indexes.
7215 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7217 * buffer.c: Include <verify.h>.
7218 (struct sortvec.priority, struct sortstr.priority):
7219 Now EMACS_INT, not int.
7220 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7221 (struct sortstr.size, record_overlay_string)
7222 (struct sortstrlist.size, struct sortlist.used):
7223 Don't truncate size to int.
7224 (record_overlay_string): Check for size-calculation overflow.
7225 (init_buffer_once): Check at compile-time, not run-time.
7227 2011-06-22 Jim Meyering <meyering@redhat.com>
7229 Don't leak an XBM-image-sized buffer
7230 * image.c (xbm_load): Free the image buffer after using it.
7232 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7235 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7236 that Sun C diagnosed.
7237 * fns.c (secure_hash): Fix pointer signedness issue.
7238 * intervals.c (static_offset_intervals): New function.
7239 (offset_intervals): Use it.
7241 2011-06-21 Leo Liu <sdl.web@gmail.com>
7244 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7247 * fns.c (secure_hash): Rename from crypto_hash_function and change
7248 the first arg to accept symbols.
7249 (Fsecure_hash): New primitive.
7250 (syms_of_fns): New symbols.
7252 2011-06-20 Deniz Dogan <deniz@dogan.se>
7254 * process.c (Fset_process_buffer): Clarify return value in
7257 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7259 * dispnew.c (add_window_display_history): Use BVAR.
7261 * xdisp.c (debug_method_add): Use BVAR.
7262 (check_window_end, dump_glyph_matrix, dump_glyph)
7263 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7265 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7268 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7269 check till after the cache is created in init_frame_faces.
7271 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7273 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7275 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7277 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7278 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7279 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7281 Improve buffer-overflow checking (Bug#8873).
7282 * fileio.c (Finsert_file_contents):
7283 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7284 Remove the old (too-loose) buffer overflow checks.
7285 They weren't needed, since make_gap checks for buffer overflow.
7286 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7287 The old code merely checked for Emacs fixnum overflow, and relied
7288 on undefined (wraparound) behavior. The new code avoids undefined
7289 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7291 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7292 Tune. Don't use wider integers than needed. Don't use alloca.
7293 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7295 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7297 * insdel.c, lisp.h (buffer_overflow): New function.
7298 (insert_from_buffer_1, replace_range, replace_range_2):
7299 * insdel.c (make_gap_larger):
7300 * editfns.c (Finsert_char):
7301 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7303 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7305 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7307 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7309 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7310 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7312 * fileio.c: Don't assume EMACS_INT fits in off_t.
7313 (emacs_lseek): New static function.
7314 (Finsert_file_contents, Fwrite_region): Use it.
7315 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7317 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7319 * fns.c: Don't overflow int when computing a list length.
7320 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7321 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7322 truncation on 64-bit hosts. Check for QUIT every
7323 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7324 faster and is responsive enough.
7325 (Flength): Report an error instead of overflowing an integer.
7326 (Fsafe_length): Return a float if the value is not representable
7327 as a fixnum. This shouldn't happen except in contrived situations.
7328 (Fnthcdr, Fsort): Don't assume list length fits in int.
7329 (Fcopy_sequence): Don't assume vector length fits in int.
7331 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7332 (header_size, word_size): New constants.
7333 (allocate_vectorlike): Don't check size overflow here.
7334 (allocate_vector): Check it here instead, since this is the only
7335 caller of allocate_vectorlike that could cause overflow.
7336 Check that the new vector's length is representable as a fixnum.
7338 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7339 The previous code was bogus. For example, next_almost_prime (32)
7340 returned 39, which is undesirable as it is a multiple of 3; and
7341 next_almost_prime (24) returned 25, which is a multiple of 5 so
7342 why was the code bothering to check for multiples of 7?
7344 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7346 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7348 Variadic C functions now count arguments with ptrdiff_t.
7349 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7350 Back then I didn't know that the Emacs coding style prefers signed int.
7351 Also, in the meantime I found a few more instances where arguments
7352 were being counted with int, which may truncate counts on 64-bit
7353 machines, or EMACS_INT, which may be unnecessarily wide.
7354 * lisp.h (struct Lisp_Subr.function.aMANY)
7355 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7356 Arg counts are now ptrdiff_t, not size_t.
7357 All variadic functions and their callers changed accordingly.
7358 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7359 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7360 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7361 * callint.c (Fcall_interactively): Check arg count for overflow,
7362 to avoid potential buffer overrun. Use signed char, not 'int',
7363 for 'varies' array, so that we needn't bother to check its size
7364 calculation for overflow.
7365 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7366 * eval.c (apply_lambda):
7367 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7368 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7369 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7371 * callint.c (Fcall_interactively): Don't use index var as event count.
7373 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7374 * mem-limits.h (SIZE): Remove; no longer used.
7376 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7378 Remove unnecessary casts.
7379 * xterm.c (x_term_init):
7380 * xfns.c (x_set_border_pixel):
7381 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7382 These aren't needed now that we assume ANSI C.
7384 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7385 It's more likely to cause problems (due to unsigned overflow)
7388 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7390 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7392 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7394 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7396 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7398 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7400 GLYPH_CODE_FACE returns EMACS_INT, not int.
7401 * dispextern.h (merge_faces):
7402 * xfaces.c (merge_faces):
7403 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7404 Don't assume EMACS_INT fits in int.
7406 * character.h (CHAR_VALID_P): Remove unused parameter.
7407 * fontset.c, lisp.h, xdisp.c: All uses changed.
7409 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7411 * fns.c (concat): Minor tuning based on overflow analysis.
7412 This doesn't fix any bugs. Use int to hold character, instead
7413 of constantly refetching from Emacs object. Use XFASTINT, not
7414 XINT, for value known to be a character. Don't bother comparing
7415 a single byte to 0400, as it's always less.
7417 * floatfns.c (Fexpt):
7418 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7420 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7423 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7425 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7426 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7427 incorrectly succeed when S was a string, because 4294967386 was
7428 truncated before it was used.
7430 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7431 Otherwise, an out-of-range integer could cause undefined behavior
7434 * composite.c: Use int, not EMACS_INT, for characters.
7435 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7436 EMACS_INT, for values that are known to be in character range.
7437 This doesn't fix any bugs but is the usual style inside Emacs and
7438 may generate better code on 32-bit machines.
7440 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7441 This is for reasons similar to the recent CHAR_STRING fix.
7442 * charset.c (Fencode_char): Check that character arg is actually
7443 a character. Pass an int to ENCODE_CHAR.
7444 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7445 wider than 'int', as a compile-time check to prevent future regressions
7448 * character.c (char_string): Remove unnecessary casts.
7450 Make sure a 64-bit char is never passed to CHAR_STRING.
7451 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7452 by silently ignoring the top 32 bits, allowing some values
7453 that were far too large to be valid characters.
7454 * character.h: Include <verify.h>.
7455 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7456 arguments are no wider than unsigned, as a compile-time check
7457 to prevent future regressions in this area.
7459 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7460 (Fsubst_char_in_region):
7462 * xdisp.c (decode_mode_spec_coding):
7463 Adjust to CHAR_STRING's new requirement.
7464 * editfns.c (Finsert_char, Fsubst_char_in_region):
7465 * fns.c (concat): Check that character args are actually
7466 characters. Without this test, these functions did the wrong
7467 thing with wildly out-of-range values on 64-bit hosts.
7469 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7470 These casts should not be needed on 32-bit hosts, either.
7471 * keyboard.c (read_char):
7472 * lread.c (Fload): Remove casts to unsigned.
7474 * lisp.h (UNSIGNED_CMP): New macro.
7475 This fixes comparison bugs on 64-bit hosts.
7476 (ASCII_CHAR_P): Use it.
7477 * casefiddle.c (casify_object):
7478 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7479 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7480 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7481 * dispextern.h (FACE_FROM_ID):
7482 * keyboard.c (read_char): Use UNSIGNED_CMP.
7484 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7485 not to EMACS_INT, to avoid GCC warning.
7487 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7489 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7490 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7491 isn't needed on 32-bit machines.
7493 * buffer.c (Fgenerate_new_buffer_name):
7494 Use EMACS_INT for count, not int.
7495 (advance_to_char_boundary): Return EMACS_INT, not int.
7497 * data.c (Qcompiled_function): Now static.
7499 * window.c (window_body_lines): Now static.
7501 * image.c (gif_load): Rename local to avoid shadowing.
7503 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7504 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7505 * alloc.c (make_save_value): Integer argument is now of type
7507 (mark_object): Use ptrdiff_t, not int.
7508 * lisp.h (pD): New macro.
7509 * print.c (print_object): Use it.
7511 * alloc.c: Use EMACS_INT, not int, to count objects.
7512 (total_conses, total_markers, total_symbols, total_vector_size)
7513 (total_free_conses, total_free_markers, total_free_symbols)
7514 (total_free_floats, total_floats, total_free_intervals)
7515 (total_intervals, total_strings, total_free_strings):
7516 Now EMACS_INT, not int. All uses changed.
7517 (Fgarbage_collect): Compute overall total using a double, so that
7518 integer overflow is less likely to be a problem. Check for overflow
7519 when converting back to an integer.
7520 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7521 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7522 These were 'int' variables that could overflow on 64-bit hosts;
7523 they were never used, so remove them instead of repairing them.
7524 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7525 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7526 Previously, this ceilinged at INT_MAX, but that doesn't work on
7528 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7530 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7531 (allocate_vectorlike): Check for ptrdiff_t overflow.
7532 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7533 when a (possibly-narrower) signed value would do just as well.
7534 We prefer using signed arithmetic, to avoid comparison confusion.
7536 * alloc.c: Catch some string size overflows that we were missing.
7537 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7538 for convenience in STRING_BYTES_MAX.
7539 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7540 The definition here is exact; the one in lisp.h was approximate.
7541 (allocate_string_data): Check for string overflow. This catches
7542 some instances we weren't catching before. Also, it catches
7543 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7544 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7545 and ptrdiff_t and EMACS_INT are both 64 bits.
7547 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7548 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7549 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7551 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7553 * alloc.c (Fmake_string): Check for out-of-range init.
7555 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7557 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7559 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7561 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7562 xg_get_default_scrollbar_width.
7564 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7565 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7566 (style_changed_cb): Call update_theme_scrollbar_width and call
7567 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7568 all frames (Bug#8505).
7569 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7570 Call gtk_window_set_resizable if HAVE_GTK3.
7571 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7572 and height if HAVE_GTK3 (Bug#8505).
7573 (scroll_bar_width_for_theme): New variable.
7574 (update_theme_scrollbar_width): New function.
7575 (xg_get_default_scrollbar_width): Move code to
7576 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7577 (xg_initialize): Call update_theme_scrollbar_width.
7579 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7581 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7583 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7585 * frame.c (make_frame): Call other_buffer_safely instead of
7588 * window.c (temp_output_buffer_show): Call display_buffer with
7589 second argument Vtemp_buffer_show_specifiers and reset latter
7590 immediately after the call.
7591 (Vtemp_buffer_show_specifiers): New variable.
7592 (auto_window_vscroll_p, next_screen_context_lines)
7593 (Vscroll_preserve_screen_position): Remove leading asterisks from
7596 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7598 Fix minor problems found by GCC 4.6.0 static checking.
7599 * buffer.c (Qclone_number): Remove for now, as it's unused.
7600 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7601 (record_buffer): Remove unused local.
7602 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7603 (set_frame_buffer_list): Remove; unused.
7604 * frame.h (other_visible_frames): Remove decl.
7605 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7606 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7607 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7609 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7610 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7611 Define only if HAVE_GPM.
7612 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7613 (update_hints_inhibit): Remove; never set. All uses removed.
7614 * widgetprv.h (emacsFrameClassRec): Remove decl.
7615 * window.c (delete_deletable_window): Now returns void, since it
7616 wasn't returning anything.
7617 (compare_window_configurations): Remove unused locals.
7618 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7619 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7620 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7621 the same widths as pointers. This follows up on the 2011-05-06 patch.
7622 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7623 * xterm.h: Likewise.
7624 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7626 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7628 * makefile.w32-in: Update dependencies.
7629 (LISP_H): Add lib/intprops.h.
7631 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7633 * image.c (gif_load): Add animation frame delay to the metadata.
7634 (syms_of_image): Use DEFSYM. New symbol `delay'.
7636 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7638 * window.c (delete_deletable_window): Re-add.
7639 (Fset_window_configuration): Rewrite to handle dead buffers and
7640 consequently deletable windows.
7641 (window_tree, Fwindow_tree): Remove. Supply functionality in
7643 (compare_window_configurations): Simplify code.
7645 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7647 * image.c (imagemagick_load_image): Fix type mismatch.
7648 (Fimagemagick_types): Likewise.
7650 * window.h (replace_buffer_in_windows): Declare.
7652 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7654 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7655 Qclone_number. Remove external declaration of Qdelete_window.
7656 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7658 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7659 Run Qbuffer_list_update_hook if allowed.
7660 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7661 buffer list implementation.
7662 (other_buffer_safely): New function.
7663 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7664 calls to replace_buffer_in_windows and
7665 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7667 (record_buffer): Inhibit quitting and rewrite using quittable
7668 functions. Run Qbuffer_list_update_hook if allowed.
7669 (Frecord_buffer, Funrecord_buffer): New functions.
7670 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7671 Move switch-to-buffer to window.el.
7672 (bury-buffer): Move to window.el.
7673 (Vbuffer_list_update_hook): New variable.
7675 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7678 * window.h (resize_frame_windows): Move up in code.
7679 (Fwindow_frame): Remove EXFUN.
7680 (replace_buffer_in_all_windows): Remove prototype.
7681 (replace_buffer_in_windows_safely): Add prototype.
7683 * window.c: Declare Qdelete_window static again. Move down
7684 declaration of select_count.
7685 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7686 (Fother_window): Move to window.el.
7687 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7688 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7689 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7691 (replace_buffer_in_windows): Implement by calling
7692 Qreplace_buffer_in_windows.
7693 (replace_buffer_in_all_windows): Remove with some functionality
7694 moved into replace_buffer_in_windows_safely.
7695 (replace_buffer_in_windows_safely): New function.
7696 (select_window_norecord, select_frame_norecord): Move in front
7697 of run_window_configuration_change_hook. Remove now obsolete
7699 (Fset_window_buffer): Rewrite doc-string.
7700 Call Qrecord_window_buffer.
7701 (keys_of_window): Move binding for other-window to window.el.
7703 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7705 * dispextern.h (struct image): Replace data member, whose int_val
7706 and ptr_val fields were not used by anything, with a single
7709 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7710 (gif_clear_image, gif_load, imagemagick_load_image)
7711 (gs_clear_image, gs_load): Callers changed.
7713 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7715 * buffer.h: Include <time.h>, for time_t.
7716 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7718 Fix minor problems found by static checking.
7720 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7722 Make identifiers static if they are not used in other modules.
7723 * data.c (Qcompiled_function, Qframe, Qvector):
7724 * image.c (QimageMagick, Qsvg):
7725 * minibuf.c (Qmetadata):
7726 * window.c (resize_window_check, resize_root_window): Now static.
7727 * window.h (resize_window_check, resize_root_window): Remove decls.
7729 * window.c (window_deletion_count, delete_deletable_window):
7731 (window_body_lines): Now static.
7732 (Fdelete_other_windows_internal): Mark vars as initialized.
7733 Make sure 'resize_failed' is initialized.
7734 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7735 (resize_window_apply): Remove unused local.
7736 * window.h (delete_deletable_window): Remove decl.
7738 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7739 (imagemagick_load_image): Fix pointer signedness problem by changing
7740 last arg from unsigned char * to char *. All uses changed.
7741 Also, fix a local for similar reasons.
7742 Remove unused locals. Remove locals to avoid shadowing.
7743 (fn_rsvg_handle_free): Remove; unused.
7744 (svg_load, svg_load_image): Fix pointer signedness problem.
7745 (imagemagick_load_image): Don't use garbage pointer image_wand.
7747 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7749 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7751 * image.c (gif_load): Fix omitted cast error introduced by
7754 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7756 * window.h (resize_proportionally, orig_total_lines)
7757 (orig_top_line): Remove from window structure.
7758 (set_window_height, set_window_width, change_window_heights)
7759 (Fdelete_window): Remove prototypes.
7760 (resize_frame_windows): Remove duplicate declaration.
7762 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7764 * window.h (resize_frame_windows, resize_window_check)
7765 (delete_deletable_window, resize_root_window)
7766 (resize_frame_windows): Declare prototypes.
7768 * window.c (resize_window_apply): Make definition be "static" to
7769 match the prototype.
7771 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7773 * window.c: Remove declarations of Qwindow_size_fixed,
7774 window_min_size_1, window_min_size_2, window_min_size,
7775 size_window, window_fixed_size_p, enlarge_window, delete_window.
7776 Remove static from declaration of Qdelete_window, it's
7777 temporarily needed by Fbury_buffer.
7778 (replace_window): Don't assign orig_top_line and
7780 (Fdelete_window, delete_window): Remove. Window deletion is
7781 handled by window.el.
7782 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7783 Replace Fdelete_window calls with calls to Qdelete_window.
7784 (Fdelete_other_windows): Remove. Deleting other windows is
7785 handled by window.el.
7786 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7787 handled in window.el.
7788 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7789 Window minimum sizes are handled in window.el.
7790 (shrink_windows, size_window, set_window_height)
7791 (set_window_width, change_window_heights, window_height)
7792 (window_width, CURBEG, CURSIZE, enlarge_window)
7793 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7794 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7795 handled in window.el.
7796 (make_dummy_parent): Rename to make_parent_window and give it a
7797 second argument horflag.
7798 (make_window): Don't set resize_proportionally any more.
7799 (Fsplit_window): Remove. Windows are split in window.el.
7800 (save_restore_action, save_restore_orig_size)
7801 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7802 Resize mini windows in window.el.
7803 (grow_mini_window, shrink_mini_window): Implement by calling
7804 Qresize_root_window_vertically, resize_window_check and
7805 resize_window_apply.
7806 (saved_window, Fset_window_configuration, save_window_save):
7807 Do not handle orig_top_line, orig_total_lines, and
7808 resize_proportionally.
7809 (window_min_height, window_min_width): Move to window.el.
7810 (keys_of_window): Move bindings for delete-other-windows,
7811 split-window, delete-window and enlarge-window to window.el.
7813 * buffer.c: Temporarily extern Qdelete_window.
7814 (Fbury_buffer): Temporarily call Qdelete_window instead of
7815 Fdelete_window (Fbury_buffer will move to window.el soon).
7817 * frame.c (set_menu_bar_lines_1): Remove code handling
7818 orig_top_line and orig_total_lines.
7820 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7821 set_window_height but set heights directly.
7822 (change_frame_size_1): Use resize_frame_windows.
7824 * xdisp.c (init_xdisp): Don't use set_window_height but set
7827 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7828 Use resize_frame_windows instead of change_window_heights and run
7829 run_window_configuration_change_hook.
7831 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7832 instead of change_window_heights and run
7833 run_window_configuration_change_hook.
7835 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7837 * window.c (replace_window): Rename second argument REPLACEMENT to
7838 NEW. New third argument SETFLAG. Rewrite.
7839 (delete_window, make_dummy_parent): Call replace_window with
7841 (window_list_1): Move down in code.
7842 (run_window_configuration_change_hook): Move set_buffer part
7843 before select_frame_norecord part in order to unwind correctly.
7844 Rename count1 to count.
7845 (recombine_windows, delete_deletable_window, resize_root_window)
7846 (Fdelete_other_windows_internal)
7847 (Frun_window_configuration_change_hook, make_parent_window)
7848 (resize_window_check, resize_window_apply, Fresize_window_apply)
7849 (resize_frame_windows, Fsplit_window_internal)
7850 (Fdelete_window_internal, Fresize_mini_window_internal):
7852 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7854 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7856 * window.h (window): Add some new members to window structure -
7857 normal_lines, normal_cols, new_total, new_normal, clone_number,
7858 splits, nest, prev_buffers, next_buffers.
7859 (WINDOW_TOTAL_SIZE): Move here from window.c.
7860 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7862 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7864 (make_dummy_parent): Set new members of windows structure.
7865 (make_window): Move down in code. Handle new members of window
7867 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7868 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7869 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7870 (Fset_window_prev_buffers, Fwindow_next_buffers)
7871 (Fset_window_next_buffers, Fset_window_clone_number):
7873 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7874 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7876 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7877 Argument WINDOW can be now internal window too.
7878 (Fwindow_use_time): Move up in code.
7879 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7881 (Fset_window_configuration, saved_window)
7882 (Fcurrent_window_configuration, save_window_save): Handle new
7883 members of window structure.
7884 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7885 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7886 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7887 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7888 Qget_mru_window, Qresize_root_window,
7889 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7890 Qauto_buffer_name; staticpro them.
7892 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7894 * window.c (Fwindow_total_size, Fwindow_left_column)
7895 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7896 (Fwindow_list_1): New functions.
7897 (window_box_text_cols): Replace with window_body_cols.
7898 (Fwindow_width, Fscroll_left, Fscroll_right):
7899 Use window_body_cols instead of window_box_text_cols.
7900 (delete_window, Fset_window_configuration):
7901 Call delete_all_subwindows with window as argument.
7902 (delete_all_subwindows): Take a window as argument and not a
7904 (window_loop): Remove handling of GET_LRU_WINDOW and
7906 (Fget_lru_window, Fget_largest_window): Move to window.el.
7908 * window.h: Extern window_body_cols instead of
7909 window_box_text_cols. delete_all_subwindows now takes a
7910 Lisp_Object as argument.
7912 * indent.c (compute_motion, Fcompute_motion):
7913 Use window_body_cols instead of window_box_text_cols.
7915 * frame.c (delete_frame): Call delete_all_subwindows with root
7918 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7920 * fns.c (Fputhash): Document return value.
7922 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7924 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7926 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7928 Cons<->int and similar integer overflow fixes (Bug#8794).
7930 Check for overflow when converting integer to cons and back.
7931 * charset.c (Fdefine_charset_internal, Fdecode_char):
7932 Use cons_to_unsigned to catch overflow.
7933 (Fencode_char): Use INTEGER_TO_CONS.
7934 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7935 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7936 * data.c (long_to_cons, cons_to_long): Remove.
7937 (cons_to_unsigned, cons_to_signed): New functions.
7938 These signal an error for invalid or out-of-range values.
7939 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7940 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7941 * font.c (Ffont_variation_glyphs):
7942 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7943 * lisp.h: Include <intprops.h>.
7944 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7945 (cons_to_signed, cons_to_unsigned): New decls.
7946 (long_to_cons, cons_to_long): Remove decls.
7947 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7948 (Fprimitive_undo): Use CONS_TO_INTEGER.
7949 * xfns.c (Fx_window_property): Likewise.
7950 * xselect.c: Include <limits.h>.
7951 (x_own_selection, selection_data_to_lisp_data):
7952 Use INTEGER_TO_CONS.
7953 (x_handle_selection_request, x_handle_selection_clear)
7954 (x_get_foreign_selection, Fx_disown_selection_internal)
7955 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7956 (lisp_data_to_selection_data): Use cons_to_unsigned.
7957 (x_fill_property_data): Use cons_to_signed.
7958 Report values out of range.
7960 Check for buffer and string overflow more precisely.
7961 * buffer.h (BUF_BYTES_MAX): New macro.
7962 * lisp.h (STRING_BYTES_MAX): New macro.
7963 * alloc.c (Fmake_string):
7964 * character.c (string_escape_byte8):
7965 * coding.c (coding_alloc_by_realloc):
7966 * doprnt.c (doprnt):
7967 * editfns.c (Fformat):
7969 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7970 since they may not be the same number.
7971 * editfns.c (Finsert_char):
7972 * fileio.c (Finsert_file_contents):
7973 Likewise for BUF_BYTES_MAX.
7975 * image.c: Use ptrdiff_t, not int, for sizes.
7976 (slurp_file): Switch from int to ptrdiff_t.
7978 (slurp_file): Check that file size fits in both size_t (for
7979 malloc) and ptrdiff_t (for sanity and safety).
7981 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7982 if b->modtime has its maximal value.
7984 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7986 Don't assume time_t can fit into int.
7987 * buffer.h (struct buffer.modtime): Now time_t, not int.
7988 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7989 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7991 Minor fixes for signed vs unsigned integers.
7992 * character.h (MAYBE_UNIFY_CHAR):
7993 * charset.c (maybe_unify_char):
7994 * keyboard.c (read_char, reorder_modifiers):
7995 XINT -> XFASTINT, since the integer must be nonnegative.
7996 * ftfont.c (ftfont_spec_pattern):
7997 * keymap.c (access_keymap, silly_event_symbol_error):
7998 XUINT -> XFASTINT, since the integer must be nonnegative.
7999 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8000 since it makes no difference and we prefer signed.
8001 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8002 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8005 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8007 * window.h (Fwindow_frame): Declare.
8009 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8011 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8012 (SPARE_MEMORY): Always define.
8013 (LARGE_REQUEST): Remove.
8014 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8016 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8018 * lisp.h: Move EXFUNS for Fframe_root_window,
8019 Fframe_first_window and Fset_frame_selected_window to window.h.
8021 * window.h: Move EXFUNS for Fframe_root_window,
8022 Fframe_first_window and Fset_frame_selected_window here from
8025 * frame.c (Fwindow_frame, Fframe_first_window)
8026 (Fframe_root_window, Fframe_selected_window)
8027 (Fset_frame_selected_window): Move to window.c.
8028 (Factive_minibuffer_window): Move to minibuf.c.
8029 (Fother_visible_frames_p): New function.
8031 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8033 * window.c (decode_window, decode_any_window): Move up in code.
8034 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8035 (inhibit_frame_unsplittable): Remove unused variable.
8036 (Fwindow_buffer): Move up and rewrite doc-string.
8037 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8038 (Fwindow_prev): New functions.
8039 (Fwindow_frame): Move here from frame.c. Accept any window as
8041 (Fframe_root_window, Fframe_first_window)
8042 (Fframe_selected_window): Move here from frame.c. Accept frame
8043 or arbitrary window as argument. Update doc-strings.
8044 (Fminibuffer_window): Move up in code.
8045 (Fwindow_minibuffer_p): Move up in code and simplify.
8046 (Fset_frame_selected_window): Move here from frame.c.
8048 (Fselected_window, select_window, Fselect_window): Move up in
8049 code. Minor doc-string fixes.
8051 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8053 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8054 Do not assume that spare memory exists; that assumption is valid
8055 only if SYSTEM_MALLOC.
8056 (LARGE_REQUEST): New macro, so that the issue of large requests
8057 is separated from the issue of spare memory.
8059 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8061 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8064 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8066 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8069 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8071 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8073 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8075 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8076 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8078 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8080 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8082 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8084 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8085 (x_clipboard_manager_save): Add return value.
8086 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8088 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8089 Obey Vx_select_enable_clipboard_manager. Catch errors in
8090 x_clipboard_manager_save (Bug#8779).
8091 (Vx_select_enable_clipboard_manager): New variable.
8092 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8094 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8096 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8098 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8100 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8101 in the current matrix if keep_current_p is non-zero.
8103 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8105 * bidi.c (bidi_level_of_next_char): Fix last change.
8107 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8109 Support bidi reordering of text covered by display properties.
8111 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8112 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8113 (bidi_cache_search, bidi_cache_iterator_state)
8114 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8115 (bidi_level_of_next_char, bidi_move_to_visually_next):
8116 Support character positions inside a run of characters covered by a
8118 (bidi_paragraph_init, bidi_resolve_explicit_1)
8119 (bidi_level_of_next_char): Call bidi_fetch_char and
8120 bidi_fetch_char_advance instead of FETCH_CHAR and
8122 (bidi_init_it): Initialize new members.
8123 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8125 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8126 instead of using explicit *_CHAR codes.
8127 (bidi_resolve_explicit, bidi_resolve_weak):
8128 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8129 bidirectional text is supported only in multibyte buffers.
8130 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8131 it to initialize the frame_window_p member of struct bidi_it.
8132 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8133 (bidi_resolve_explicit, bidi_resolve_weak)
8134 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8135 bidi_it->nchars is non-positive.
8136 (bidi_level_of_next_char): Don't try to lookup the cache for the
8137 next/previous character if nothing is cached there yet, or if we
8138 were just reseat()'ed to a new position.
8140 * xdisp.c (set_cursor_from_row): Set start and stop points
8141 according to the row's direction when priming the loop that looks
8142 for the glyph on which to display cursor.
8143 (single_display_spec_intangible_p): Function deleted.
8144 (display_prop_intangible_p): Reimplement to call
8145 handle_display_spec instead of single_display_spec_intangible_p.
8146 Accept 3 additional arguments needed by handle_display_spec.
8147 This fixes incorrect cursor motion across display property with complex
8148 values: lists, `(when COND...)' forms, etc.
8149 (single_display_spec_string_p): Support property values that are
8150 lists with the argument STRING its top-level element.
8151 (display_prop_string_p): Fix the condition for processing a
8152 property that is a list to be consistent with handle_display_spec.
8153 (handle_display_spec): New function, refactored from the
8154 last portion of handle_display_prop.
8155 (compute_display_string_pos): Accept additional argument
8156 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8157 value of a `display' property is a "replacing spec".
8158 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8159 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8160 the display property, but just return a value indicating whether
8161 the display property will replace the characters it covers.
8162 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8163 frame_window_p members of struct bidi_it.
8164 (compute_display_string_pos, compute_display_string_end):
8166 (push_it): Accept second argument POSITION, where pop_it should
8167 jump to continue iteration.
8168 (reseat_1): Initialize bidi_it.disp_pos.
8170 * keyboard.c (adjust_point_for_property): Adjust the call to
8171 display_prop_intangible_p to its new signature.
8173 * dispextern.h (struct bidi_it): New member frame_window_p.
8174 (bidi_init_it): Update prototypes.
8175 (display_prop_intangible_p): Update prototype.
8176 (compute_display_string_pos, compute_display_string_end):
8178 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8181 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8183 Malloc failure behavior now depends on size of allocation.
8184 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8185 * lisp.h: Change signatures accordingly.
8186 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8187 All callers changed. (Bug#8762)
8189 * gnutls.c: Use Emacs's memory allocators.
8190 Without this change, the gnutls library would invoke malloc etc.
8191 directly, which causes problems on non-SYNC_INPUT hosts, and which
8192 runs afoul of improving memory_full behavior. (Bug#8761)
8193 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8194 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8195 xfree instead of the default malloc, realloc, free.
8196 (Fgnutls_boot): No need to check for memory allocation failure,
8197 since xmalloc does that for us.
8199 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8200 * category.c (hash_get_category_set):
8201 * ccl.c (ccl_driver):
8202 * charset.c (Fdefine_charset_internal):
8203 * charset.h (struct charset.hash_index):
8204 * composite.c (get_composition_id, gstring_lookup_cache)
8205 (composition_gstring_put_cache):
8206 * composite.h (struct composition.hash_index):
8207 * dispextern.h (struct image.hash):
8208 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8209 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8210 (hashfn_equal, hashfn_user_defined, make_hash_table)
8211 (maybe_resize_hash_table, hash_lookup, hash_put)
8212 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8213 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8214 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8215 * image.c (make_image, search_image_cache, lookup_image)
8216 (xpm_put_color_table_h):
8217 * lisp.h (struct Lisp_Hash_Table):
8218 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8219 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8220 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8221 * alloc.c (allocate_vectorlike):
8222 Check for overflow in vector size calculations.
8223 * ccl.c (ccl_driver):
8224 Check for overflow when converting EMACS_INT to int.
8225 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8226 need to be updated by these changes.
8227 * fns.c (make_hash_table, maybe_resize_hash_table):
8228 Check for integer overflow with large hash tables.
8229 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8230 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8231 (SXHASH_REDUCE): New macro.
8232 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8233 Use it instead of discarding useful hash info with large hash values.
8234 (sxhash_float): New function.
8235 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8236 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8237 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8238 Rewrite to use FIXNUM_BITS, as this simplifies things.
8239 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8240 Adjust signatures to match updated version of code.
8241 (consing_since_gc): Now EMACS_INT, since a single hash table can
8242 use more than INT_MAX bytes.
8244 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8246 Make it possible to build with GCC-4.6+ -O2 -flto.
8248 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8250 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8252 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8253 Call minibuffer-inactive-mode.
8255 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8257 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8258 Update dependencies.
8260 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8262 * data.c (init_data): Remove code for UTS, this system is not
8265 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8267 Don't force ./temacs to start in terminal mode.
8269 * frame.c (make_initial_frame): Initialize faces in all cases, not
8270 only when CANNOT_DUMP is defined.
8271 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8273 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8275 * dispnew.c (add_window_display_history): Use const for the string
8276 pointer. Remove declaration, not needed.
8278 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8280 Use 'inline', not 'INLINE'.
8281 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8282 * alloc.c, fontset.c (INLINE): Remove.
8283 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8284 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8285 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8286 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8287 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8289 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8291 Make it possible to run ./temacs.
8293 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8294 syms_of_callproc does the same thing. Remove test for
8295 "initialized", do it in the caller.
8296 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8298 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8300 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8301 (read_minibuf): Use get_minibuffer.
8302 (syms_of_minibuf): Use DEFSYM.
8303 (Qmetadata): New var.
8304 * data.c (Qbuffer): Don't make it static.
8305 (syms_of_data): Use DEFSYM.
8307 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8309 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8310 (CCL_CODE_MIN): New macro.
8312 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8314 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8316 * eval.c (Qdebug): Now static.
8317 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8318 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8319 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8321 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8323 * image.c: Various fixes to ImageMagick code comments.
8324 (Fimagemagick_types): Doc fix.
8326 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8328 Minor fixes prompted by GCC 4.6.0 warnings.
8330 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8332 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8333 (x_clipboard_manager_save_all): Move extern decl to ...
8334 * xterm.h: ... here, so that it can be checked for consistency.
8336 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8338 * xselect.c (x_clipboard_manager_save_frame)
8339 (x_clipboard_manager_save_all): New functions.
8340 (Fx_clipboard_manager_save): Lisp function deleted.
8342 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8343 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8345 * xterm.h: Update prototype.
8347 2011-05-28 William Xu <william.xwl@gmail.com>
8349 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8352 2011-05-28 Jim Meyering <meyering@redhat.com>
8354 Avoid a sign-extension bug in crypto_hash_function.
8355 * fns.c (to_uchar): Define.
8356 (crypto_hash_function): Use it to convert some newly-signed
8357 variables to unsigned, to avoid sign-extension bugs. For example,
8358 without this change, (md5 "truc") would evaluate to
8359 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8360 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8361 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8363 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8365 Integer overflow fixes.
8367 * dbusbind.c: Serial number integer overflow fixes.
8368 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8369 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8370 to hold a serial number that is too large for a fixnum.
8371 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8372 Check for serial numbers out of range. Decode any serial number
8373 that was so large that it became a float. (Bug#8722)
8375 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8376 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8377 Use XFASTINT rather than XUINT when numbers are nonnegative.
8378 (xd_append_arg, Fdbus_method_return_internal):
8379 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8380 arguments, check that Lisp number is nonnegative, rather than
8381 silently wrapping negative numbers around. (Bug#8722)
8382 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8385 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8387 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8389 ccl: Add integer overflow checks.
8390 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8391 (IN_INT_RANGE): New macros.
8392 (ccl_driver): Use them to check for integer overflow when
8393 decoding a CCL program. Many of the new checks are whether XINT (x)
8394 fits in int; it doesn't always, on 64-bit hosts. The new version
8395 doesn't catch all possible integer overflows, but it's an
8396 improvement. (Bug#8719)
8398 * alloc.c (make_event_array): Use XINT, not XUINT.
8399 There's no need for unsigned here.
8401 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8402 This follows up to the 2011-05-06 change that substituted uintptr_t
8403 for EMACS_INT. This case wasn't caught back then.
8405 Rework Fformat to avoid integer overflow issues.
8406 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8407 now (part of C89). Include <verify.h>.
8408 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8409 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8410 (Fformat): Avoid the prepass trying to compute sizes; it was only
8411 approximate and thus did not catch overflow reliably. Instead, walk
8412 through the format just once, formatting and computing sizes as we go,
8413 checking for integer overflow at every step, and allocating a larger
8414 buffer as needed. Keep track separately whether the format is
8415 multibyte. Keep only the most-recently calculated precision, rather
8416 than them all. Record whether each argument has been converted to
8417 string. Use EMACS_INT, not int, for byte and char and arg counts.
8418 Support field widths and precisions larger than INT_MAX. Avoid
8419 sprintf's undefined behavior with conversion specifications such as %#d
8420 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8421 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8422 formatting out-of-range floating point numbers with int
8425 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8427 * data.c: Avoid integer truncation in expressions involving floats.
8428 * data.c: Include <intprops.h>.
8429 (arith_driver): When there's an integer overflow in an expression
8430 involving floating point, convert the integers to floating point
8431 so that the resulting value does not suffer from catastrophic
8432 integer truncation. For example, on a 64-bit host (* 4
8433 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8434 Do not rely on undefined behavior after integer overflow.
8436 merge count_size_as_multibyte, parse_str_to_multibyte
8437 * character.c, character.h (count_size_as_multibyte):
8438 Rename from parse_str_to_multibyte; all uses changed.
8439 Check for integer overflow.
8440 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8441 since it's now a duplicate of the other. This is more of
8442 a character than a buffer op, so better that it's in character.c.
8443 * fns.c, print.c: Adjust to above changes.
8445 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8447 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8449 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8451 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8452 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8453 (x_clipboard_manager_save): Now static.
8454 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8456 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8457 (crypto_hash_function): Now static.
8458 Fix pointer signedness problems. Avoid unnecessary initializations.
8460 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8462 * termhooks.h (Vselection_alist): Make it terminal-local.
8464 * terminal.c (create_terminal): Initialize it.
8466 * xselect.c: Support for clipboard managers.
8467 (Vselection_alist): Move to termhooks.h as terminal-local var.
8468 (LOCAL_SELECTION): New macro.
8469 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8470 (symbol_to_x_atom): Remove gratuitous arg.
8471 (x_handle_selection_request, lisp_data_to_selection_data)
8472 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8473 (x_own_selection, x_get_local_selection, x_convert_selection):
8474 New arg, specifying work frame. Use terminal-local Vselection_alist.
8475 (some_frame_on_display): Delete unused function.
8476 (Fx_own_selection_internal, Fx_get_selection_internal)
8477 (Fx_disown_selection_internal, Fx_selection_owner_p)
8478 (Fx_selection_exists_p): New optional frame arg.
8479 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8480 (x_handle_selection_clear): Don't treat other terminals with the
8481 same keyboard specially. Use the terminal-local Vselection_alist.
8482 (x_clear_frame_selections): Use Frun_hook_with_args.
8484 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8486 * xterm.h: Add support for those atoms.
8488 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8490 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8491 (converted_selections, conversion_fail_tag): New global variables.
8492 (x_selection_request_lisp_error): Free the above.
8493 (x_get_local_selection): Remove unnecessary code.
8494 (x_reply_selection_request): Args changed; handle arbitrary array
8495 of converted selections stored in converted_selections.
8496 Separate the XChangeProperty and SelectionNotify steps.
8497 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8498 (x_convert_selection): New function.
8499 (x_handle_selection_event): Simplify.
8500 (x_get_foreign_selection): Don't ignore incoming requests while
8501 waiting for an answer; this will fail when we implement
8502 SAVE_TARGETS, and seems unnecessary anyway.
8503 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8504 (Vx_sent_selection_functions): Doc fix.
8506 2011-05-26 Leo Liu <sdl.web@gmail.com>
8508 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8510 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8512 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8514 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8515 for fringe update if it has periodic bitmap.
8516 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8517 and fringe_bitmap_periodic_p.
8519 * fringe.c (get_fringe_bitmap_data): New function.
8520 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8521 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8522 row. Mark glyph row for fringe update if periodicity changed.
8524 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8525 for fringe update unless it has periodic bitmap.
8527 2011-05-25 Kenichi Handa <handa@m17n.org>
8529 * xdisp.c (get_next_display_element): Set correct it->face_id for
8530 a static composition.
8532 2011-05-24 Leo Liu <sdl.web@gmail.com>
8535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8537 * fns.c (crypto_hash_function, Fsha1): New function.
8538 (Fmd5): Use crypto_hash_function.
8539 (syms_of_fns): Add Ssha1.
8541 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8543 * gnutls.c: Remove unused macros.
8544 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8545 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8546 Remove macros that are defined and never used.
8547 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8549 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8551 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8552 (Fx_get_selection_internal): Minor cleanup.
8553 (Fx_own_selection_internal): Rename arguments for consistency with
8556 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8558 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8560 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8562 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8564 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8566 * dispnew.c (scrolling_window): Don't exclude the case that the
8567 last enabled row in the desired matrix touches the bottom boundary.
8569 2011-05-21 Glenn Morris <rgm@gnu.org>
8571 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8572 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8573 and add some more files.
8575 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8577 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8578 report_file_error introduced by the change from 2011-05-07.
8580 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8582 * systime.h (Time): Define only if emacs is defined.
8583 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8584 where the include path doesn't have X11/X.h by default. See
8585 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8587 2011-05-20 Kenichi Handa <handa@m17n.org>
8589 * composite.c (find_automatic_composition): Fix previous change.
8591 2011-05-20 Glenn Morris <rgm@gnu.org>
8593 * lisp.mk: New file, split from Makefile.in.
8594 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8595 (shortlisp): Remove.
8596 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8598 2011-05-19 Glenn Morris <rgm@gnu.org>
8600 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8601 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8602 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8603 (lisp): Set the order to that of loadup.el.
8604 (shortlisp): Make it a copy of $lisp.
8605 (SOME_MACHINE_LISP): Remove.
8606 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8607 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8609 2011-05-18 Kenichi Handa <handa@m17n.org>
8611 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8612 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8613 (find_automatic_composition): Mostly rewrite for efficiency.
8615 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8617 * makefile.w32-in: Update dependencies.
8619 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8621 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8622 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8624 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8626 Fix some integer overflow issues, such as string length overflow.
8628 * insdel.c (count_size_as_multibyte): Check for string overflow.
8630 * character.c (lisp_string_width): Check for string overflow.
8631 Use EMACS_INT, not int, for string indexes and lengths; in
8632 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8633 the resulting string length overflows an EMACS_INT; instead,
8634 report a string overflow if no precision given. When checking for
8635 precision exhaustion, use a check that cannot possibly have
8636 integer overflow. (Bug#8675)
8637 * character.h (lisp_string_width): Adjust to new signature.
8639 * alloc.c (string_overflow): New function.
8640 (Fmake_string): Use it. This doesn't change behavior, but saves
8641 a few bytes and will simplify future changes.
8642 * character.c (string_escape_byte8): Likewise.
8643 * lisp.h (string_overflow): New decl.
8645 Fixups, following up to the user-interface timestamp change.
8646 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8647 for UI timestamps, instead of unsigned long.
8648 * msdos.c (mouse_get_pos): Likewise.
8649 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8650 * w32gui.h (Time): Define by including "systime.h" rather than by
8651 declaring it ourselves. (Bug#8664)
8653 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8654 * image.c (clear_image_cache): Likewise.
8656 * term.c (term_mouse_position): Don't assume time_t wraparound.
8658 Be more systematic about user-interface timestamps.
8659 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8660 and sometimes 'EMACS_UINT', to represent these timestamps.
8661 This change causes it to use 'Time' uniformly, as that's what X uses.
8662 This makes the code easier to follow, and makes it easier to catch
8663 integer overflow bugs such as Bug#8664.
8664 * frame.c (Fmouse_position, Fmouse_pixel_position):
8665 Use Time, not unsigned long, for user-interface timestamps.
8666 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8667 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8668 * keyboard.h (last_event_timestamp): Likewise.
8669 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8670 * menu.h (xmenu_show): Likewise.
8671 * term.c (term_mouse_position): Likewise.
8672 * termhooks.h (struct input_event.timestamp): Likewise.
8673 (struct terminal.mouse_position_hook): Likewise.
8674 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8675 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8676 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8677 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8679 * menu.h, termhooks.h: Include "systime.h", for Time.
8681 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8682 Don't assume that the difference between two unsigned long values
8683 can fit into an integer. At this point, we know button_down_time
8684 <= event->timestamp, so the difference must be nonnegative, so
8685 there's no need to cast the result if double-click-time is
8686 nonnegative, as it should be; check that it's nonnegative, just in
8687 case. This bug is triggered when events are more than 2**31 ms
8688 apart (about 25 days). (Bug#8664)
8690 * xselect.c (last_event_timestamp): Remove duplicate decl.
8691 (x_own_selection): Remove needless cast to unsigned long.
8693 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8694 that always fit in int. Use a sentinel instead of a counter, to
8695 avoid a temp and to allay GCC's concerns about possible int overflow.
8696 * frame.h (struct frame): Use int for menu_bar_items_used
8697 instead of EMACS_INT, since it always fits in int.
8699 * menu.c (grow_menu_items): Check for int overflow.
8701 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8703 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8704 Before, the code was not consistent. These values cannot exceed
8705 2**31 - 1 so there's no need to make them unsigned.
8706 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8707 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8708 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8710 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8712 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8713 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8714 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8715 presumably because the widths might not match.
8717 * window.c (size_window): Avoid needless test at loop start.
8719 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8721 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8723 2011-05-12 Drew Adams <drew.adams@oracle.com>
8725 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8727 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8729 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8730 `width' to `bar_area_x' and `bar_area_width', respectively.
8731 (x_scroll_run): Take account of fringe background extension.
8733 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8734 Rename local vars `left' and `width' to `bar_area_x' and
8735 `bar_area_width', respectively.
8736 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8737 background extension.
8739 2011-05-10 Jim Meyering <meyering@redhat.com>
8741 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8743 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8745 * image.c (Finit_image_library): Return t for built-in image types,
8746 like pbm and xbm. (Bug#8640)
8748 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8750 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8752 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8754 * w32console.c (Fset_screen_color): Doc fix.
8755 (Fget_screen_color): New function.
8756 (syms_of_ntterm): Defsubr it.
8758 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8759 unlink the temporary file if Fcall_process didn't create it in the
8761 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8762 child process will be redirected to a file specified with `:file'.
8763 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8764 cue to call_process_cleanup not to close that handle.
8766 2011-05-07 Ben Key <bkey76@gmail.com>
8768 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8769 one of two shell specific rules, either bootstrap-temacs-CMD or
8770 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8771 to the previous implementation of the bootstrap-temacs rule.
8772 The bootstrap-temacs-CMD rule is similar to the previous
8773 implementation of the bootstrap-temacs rule except that it
8774 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8777 These changes, along with some changes to nt/configure.bat,
8778 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8779 earlier fix to add support for --cflags and --ldflags options
8780 that include quotes so that it works whether make uses cmd or
8783 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8785 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8786 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8788 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8789 a string. Handle both cases.
8790 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8791 (Fdbus_register_method): Use Qinvalid_function.
8793 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8795 * makefile.w32-in: Update dependencies.
8796 (LISP_H): Add inttypes.h and stdin.h.
8797 (PROCESS_H): Add unistd.h.
8799 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8801 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8802 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8804 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8806 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8808 * term.c (vfatal): Remove stray call to va_end.
8809 It's not needed and the C Standard doesn't allow it here anyway.
8811 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8812 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8814 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8817 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8819 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8821 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8823 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8825 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8827 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8828 * charset.c (Fdefine_charset_internal): Don't initialize
8829 charset.code_space[15]. The value was garbage, on hosts with
8830 32-bit int (Bug#8600).
8832 * lread.c (read_integer): Be more consistent with string-to-number.
8833 Use string_to_number to do the actual conversion; this avoids
8834 rounding errors and fixes some other screwups. Without this fix,
8835 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8836 (digit_to_number): Move earlier, for benefit of read_integer.
8837 Return -1 if the digit is out of range for the base, -2 if it is
8838 not a digit in any supported base. (Bug#8602)
8840 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8842 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8843 to match comment at start of function. This also removes a
8844 GCC warning about overflow in a 32+64-bit port.
8846 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8848 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8849 Reported by Stefan Monnier in
8850 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8851 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8852 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8854 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8855 (EMACS_UINTPTR): Likewise, with uintptr_t.
8857 * lisp.h: Prefer 64-bit EMACS_INT if available.
8858 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8859 on 32-bit hosts that have 64-bit int, so that they can access
8861 However, temporarily disable this change unless the temporary
8862 symbol WIDE_EMACS_INT is defined.
8864 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8866 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8867 This removes an assumption that EMACS_INT and long are the same
8868 width as pointers. The assumption is true for Emacs porting targets
8869 now, but we want to make other targets possible.
8870 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8871 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8872 In the rest of the code, change types of integers that hold casted
8873 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8874 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8875 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8876 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8877 No need to cast type when ORing.
8878 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8879 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8880 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8881 assume EMACS_INT is the same width as char *.
8882 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8883 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8884 Remove no-longer-needed casts.
8885 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8886 (xg_tool_bar_help_callback, xg_make_tool_item):
8887 Use EMACS_INTPTR to hold an integer
8888 that will be cast to void *; this can avoid a GCC warning
8889 if EMACS_INT is not the same width as void *.
8890 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8891 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8892 (current_message_1, set_message_1):
8893 Use a local to convert to proper width without a cast.
8894 * xmenu.c (dialog_selection_callback): Likewise.
8896 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8897 Also, don't assume VALBITS / RAND_BITS is less than 5,
8898 and don't rely on undefined behavior when shifting a 1 left into
8900 * lisp.h (get_random): Change signature to match.
8902 * lread.c (hash_string): Use size_t, not int, for hash computation.
8903 Normally we prefer signed values; but hashing is special, because
8904 it's better to use unsigned division on hash table sizes so that
8905 the remainder is nonnegative. Also, size_t is the natural width
8906 for hashing into memory. The previous code used 'int', which doesn't
8907 retain enough info to hash well into very large tables.
8908 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8910 * dbusbind.c: Don't possibly lose pointer info when converting.
8911 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8912 Use XPNTR rather than XHASH, so that the high-order bits of
8913 the pointer aren't lost when converting through void *.
8915 * eval.c (Fautoload): Don't double-shift a pointer.
8917 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8919 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8921 * gnutls.c (DEF_GNUTLS_FN):
8922 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8924 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8926 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8929 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8931 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8932 New version that can reserve upto 2GB of heap space.
8934 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8936 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8938 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8940 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8941 `gnutls_certificate_set_x509_key_file'.
8943 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8945 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8946 Update dependencies.
8948 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8950 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8951 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8952 Remove unused parameter `fildes'.
8953 * process.c (read_process_output, send_process): Don't pass it.
8955 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8957 Fix previous change: the library cache is defined in w32.c.
8958 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8959 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8961 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8963 Implement dynamic loading of GnuTLS on Windows.
8965 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8966 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8967 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8970 * gnutls.c (Qgnutls_dll): Define.
8971 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8972 (gnutls_*): Declare function pointers.
8973 (init_gnutls_functions): New function to initialize function pointers.
8974 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8975 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8976 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8977 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8978 (emacs_gnutls_write, emacs_gnutls_read)
8979 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8980 (Fgnutls_available_p): New function.
8981 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8982 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8983 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8985 * image.c: Include w32.h.
8986 (Vimage_type_cache): Delete.
8987 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8988 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8989 (w32_delayed_load): Move to w32.c.
8991 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8993 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8994 (w32_delayed_load): Move from image.c. When loading a library, record
8995 its filename in the :loaded-from property of the library id.
8996 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8997 Initialize and staticpro them.
8998 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9000 * process.c: Include lisp.h before w32.h, not after.
9001 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9002 instead of gnutls_record_check_pending.
9004 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9006 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9008 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9009 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9012 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9014 * xterm.c (x_set_frame_alpha): Do not set property on anything
9015 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9017 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9019 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9021 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9023 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9024 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9025 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9026 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9027 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9028 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9029 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9030 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9031 (Qgnutls_bootprop_callbacks_verify): Make static.
9033 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9035 * callproc.c: Indentation fixup.
9037 * sysdep.c (wait_for_termination_1): Make static.
9038 (wait_for_termination, interruptible_wait_for_termination):
9039 Move after wait_for_termination_1.
9041 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9043 * sysdep.c (interruptible_wait_for_termination): New function
9044 which is like wait_for_termination, but allows keyboard
9047 * callproc.c (Fcall_process): Add (:file "file") as an option for
9049 (Fcall_process_region): Ditto.
9051 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9053 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9054 rather than `XVECTOR (FOO)->size'.
9056 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9057 inttypes.h, as a gnulib replacement is used if it not available in
9060 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9062 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9063 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9064 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9066 * coding.c (coding_alloc_by_realloc): Error out if destination
9067 will grow beyond MOST_POSITIVE_FIXNUM.
9068 (decode_coding_emacs_mule): Abort if there isn't enough place in
9069 charbuf for the composition carryover bytes. Reserve an extra
9070 space for up to 2 characters produced in a loop.
9071 (decode_coding_iso_2022): Abort if there isn't enough place in
9072 charbuf for the composition carryover bytes.
9074 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9076 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9077 aborting when %lld or %lll format is passed.
9078 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9079 %llo or %llx format is passed. (Bug#8545)
9081 * window.c (window_scroll_line_based): Use a marker instead of
9082 simple variables to record original value of point. (Bug#7952)
9084 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9085 produced by %s or %c overflows available buffer space. (Bug#8545)
9087 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9089 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9090 (SIZE_MAX): Move defn after all includes, as they might #define it.
9092 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9094 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9096 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9098 * keyboard.c (Qdelayed_warnings_hook): Define.
9099 (command_loop_1): Run `delayed-warnings-hook'
9100 if Vdelayed_warnings_list is non-nil.
9101 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9102 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9104 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9106 * doprnt.c (doprnt): Don't return value smaller than the buffer
9107 size if the message was truncated. (Bug#8545).
9109 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9111 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9112 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9114 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9116 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9118 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9120 * makefile.w32-in: Update dependencies.
9122 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9124 Improve `doprnt' and its usage. (Bug#8545)
9125 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9126 `format_end'. Remove support for %l as a conversion specifier.
9127 Don't use xrealloc. Improve diagnostics when the %l size modifier
9128 is used. Update the commentary.
9130 * eval.c (verror): Simplify calculation of size_t.
9132 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9135 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9137 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9140 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9142 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9143 This makes this file independent of the recent pseudovector change.
9145 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9147 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9149 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9150 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9151 Remove unused local.
9152 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9154 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9155 GCC 4.6.0 optimizes based on type-based alias analysis.
9156 For example, if b is of type struct buffer * and v of type struct
9157 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9158 != &v->size, and therefore "v->size = 1; b->size = 2; return
9159 v->size;" must therefore return 1. This assumption is incorrect
9160 for Emacs, since it type-puns struct Lisp_Vector * with many other
9161 types. To fix this problem, this patch adds a new type struct
9162 vectorlike_header that documents the constraints on layout of vectors
9163 and pseudovectors, and helps optimizing compilers not get fooled
9164 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9165 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9166 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9168 (XSETPVECTYPE): Rewrite in terms of new macro.
9169 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9170 This is a bit clearer, and further avoids the possibility of
9171 undesirable aliasing.
9172 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9173 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9174 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9175 since Lisp_Subr is a special case (no "next" field).
9176 (ASIZE): Now uses header.size rather than size.
9177 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9178 to avoid the hassle of writing XVECTOR (foo)->header.size.
9179 (struct vectorlike_header): New type.
9180 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9181 object, to help avoid aliasing.
9182 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9183 (SUBRP): Likewise, since Lisp_Subr is a special case.
9184 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9185 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9186 (struct Lisp_Hash_Table): Combine first two members into a single
9187 struct vectorlike_header member. All uses of "size" and "next" members
9188 changed to be "header.size" and "header.next".
9189 * buffer.h (struct buffer): Likewise.
9190 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9191 * frame.h (struct frame): Likewise.
9192 * process.h (struct Lisp_Process): Likewise.
9193 * termhooks.h (struct terminal): Likewise.
9194 * window.c (struct save_window_data, struct saved_window): Likewise.
9195 * window.h (struct window): Likewise.
9196 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9197 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9198 * buffer.c (init_buffer_once): Likewise.
9199 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9201 * process.c (Fformat_network_address): Use local var for size,
9204 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9206 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9207 * data.c (atof): Remove decl; no longer used or needed.
9208 (digit_to_number): Move to lread.c.
9209 (Fstring_to_number): Use new string_to_number function, to be
9210 consistent with how the Lisp reader treats infinities and NaNs.
9211 Do not assume that floating-point numbers represent EMACS_INT
9212 without losing information; this is not true on most 64-bit hosts.
9213 Avoid double-rounding errors, by insisting on integers when
9214 parsing non-base-10 numbers, as the documentation specifies.
9215 * lisp.h (string_to_number): New decl, replacing ...
9216 (isfloat_string): Remove.
9217 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9218 (read1): Do not accept +. and -. as integers; this
9219 appears to have been a coding error. Similarly, do not accept
9220 strings like +-1e0 as floating point numbers. Do not report
9221 overflow for integer overflows unless the base is not 10 which
9222 means we have no simple and reliable way to continue.
9223 Break out the floating-point parsing into a new
9224 function string_to_number, so that Fstring_to_number parses
9225 floating point numbers consistently with the Lisp reader.
9226 (digit_to_number): Move here from data.c. Make it static inline.
9227 (E_CHAR, EXP_INT): Remove, replacing with ...
9228 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9229 (string_to_number): New function, replacing isfloat_string.
9230 This function checks for valid syntax and produces the resulting
9231 Lisp float number too. Rework it so that string-to-number
9232 no longer mishandles examples like "1.0e+". Use strtoumax,
9233 so that overflow for non-base-10 numbers is reported only when
9234 there's no portable and simple way to convert to floating point.
9236 * textprop.c (set_text_properties_1): Rewrite for clarity,
9237 and to avoid GCC warning about integer overflow.
9239 * intervals.h (struct interval): Use EMACS_INT for members
9240 where EMACS_UINT might cause problems. See
9241 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9242 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9243 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9245 (offset_intervals): Tell GCC not to worry about length overflow
9246 when negating a negative length.
9248 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9249 (overrun_check_free): Likewise.
9251 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9252 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9255 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9256 (gnutls_make_error): Rename local to avoid shadowing.
9257 (gnutls_emacs_global_deinit): ifdef out; not used.
9258 (Fgnutls_boot): Use const for pointer to readonly storage.
9259 Comment out unused local. Fix pointer signedness problems.
9261 * lread.c (openp): Don't stuff size_t into an 'int'.
9262 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9263 about possible signed overflow.
9265 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9266 (GDK_KEY_g): Don't define if already defined.
9267 (xg_prepare_tooltip): Avoid pointer signedness problem.
9268 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9270 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9271 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9273 * xfns.c (Fx_window_property): Simplify a bit,
9274 to make a bit faster and to avoid GCC 4.6.0 warning.
9275 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9277 * fns.c (internal_equal): Don't assume size_t fits in int.
9279 * alloc.c (compact_small_strings): Tighten assertion a little.
9281 Replace pEd with more-general pI, and fix some printf arg casts.
9282 * lisp.h (pI): New macro, generalizing old pEd macro to other
9283 conversion specifiers. For example, use "...%"pI"d..." rather
9284 than "...%"pEd"...".
9285 (pEd): Remove. All uses replaced with similar uses of pI.
9286 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9287 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9288 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9289 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9290 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9291 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9292 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9294 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9295 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9296 * print.c (safe_debug_print, print_object): Likewise.
9297 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9299 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9300 avoiding the 0 flag, which is not portable.
9301 * process.c (Fmake_network_process): Use pI to avoid cast.
9302 * region-cache.c (pp_cache): Likewise.
9303 * xdisp.c (decode_mode_spec): Likewise.
9304 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9305 behavior on 64-bit hosts with printf arg.
9306 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9307 (x_stop_queuing_selection_requests): Likewise.
9308 (x_get_window_property): Don't truncate byte count to an 'int'
9311 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9312 here, since it parses constructs like leading '-' and spaces,
9313 which are not wanted; and it overflows with large numbers.
9314 Instead, simply match F[0-9]+, which is what is wanted anyway.
9316 * alloc.c: Remove unportable assumptions about struct layout.
9317 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9318 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9319 (allocate_vectorlike, make_pure_vector): Use the new macros,
9320 plus offsetof, to remove unportable assumptions about struct layout.
9321 These assumptions hold on all porting targets that I know of, but
9322 they are not guaranteed, they're easy to remove, and removing them
9323 makes further changes easier.
9325 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9326 This doesn't fix a bug but makes the code clearer.
9327 (string_overrun_cookie): Now const. Use initializers that
9328 don't formally overflow signed char, to avoid warnings.
9329 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9330 can cause Emacs to crash when string overrun checking is enabled.
9331 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9332 multiple of sizeof (EMACS_INT); it need not be, if
9333 alignof(EMACS_INT) < sizeof (EMACS_INT).
9334 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9336 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9338 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9340 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9342 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9343 supposed to be handshaking. (Bug#8556)
9344 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9346 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9348 * lisp.h (Qdebug): List symbol.
9349 * eval.c (Qdebug): Restore global linkage.
9350 * keyboard.c (debug-on-event): New variable.
9351 (handle_user_signal): Break into debugger when debug-on-event
9352 matches the current signal symbol.
9354 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9356 * alloc.c (check_sblock, check_string_bytes)
9357 (check_string_free_list): Convert to standard C.
9359 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9361 * w32.c (emacs_gnutls_push): Fix typo.
9363 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9365 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9366 "cast to pointer from integer of different size".
9368 Improve doprnt and its use in verror. (Bug#8545)
9369 * doprnt.c (doprnt): Document the set of format control sequences
9370 supported by the function. Use SAFE_ALLOCA instead of always
9373 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9374 is one byte too soon. Don't use xrealloc; instead xfree and
9377 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9379 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9382 * gnutls.c: Renamed global_initialized to
9383 gnutls_global_initialized. Added internals for the
9384 :verify-hostname-error, :verify-error, and :verify-flags
9385 parameters of `gnutls-boot' and documented those parameters in the
9386 docstring. Start callback support.
9387 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9388 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9389 on error. Return error code.
9390 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9391 (emacs_gnutls_read): Likewise.
9392 (Fgnutls_boot): Return handshake error code.
9393 (emacs_gnutls_handle_error): New function.
9394 (wsaerror_to_errno): Likewise.
9396 * w32.h (emacs_gnutls_pull): Add prototype.
9397 (emacs_gnutls_push): Likewise.
9399 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9400 (emacs_gnutls_push): Likewise.
9402 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9404 * process.c (wait_reading_process_output): Check if GnuTLS
9405 buffered some data internally if no FDs are set for TLS
9408 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9409 (LIBS): Link to USER_LIBS.
9410 ($(BLD)/gnutls.$(0)): New target.
9412 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9414 * xdisp.c (handle_single_display_spec): Rename the
9415 display_replaced_before_p argument into display_replaced_p, to
9416 make it consistent with the commentary. Fix typos in the
9419 * textprop.c (syms_of_textprop): Remove dead code.
9420 (copy_text_properties): Delete obsolete commentary about an
9421 interface that was deleted long ago. Fix typos in the description
9424 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9425 to changes in oldXMenu/XMenu.h from 2011-04-16.
9426 <menu_help_message, prev_menu_help_message>: Constify.
9427 (IT_menu_make_room): menu->help_text is now `const char **';
9430 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9431 to changes in oldXMenu/XMenu.h from 2011-04-16.
9432 (struct XMenu): Declare `help_text' `const char **'.
9434 * xfaces.c <Qunspecified>: Make extern again.
9436 * syntax.c: Include sys/types.h before including regex.h, as
9439 * doc.c (get_doc_string): Improve the format passed to `error'.
9441 * doprnt.c (doprnt): Improve commentary.
9443 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9445 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9448 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9449 changes in globals.h immediately force recompilation.
9450 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9451 $(CURDIR)/s/ms-w32.h.
9452 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9454 * character.c (Fchar_direction): Function deleted.
9455 (syms_of_character): Don't defsubr it.
9456 <char-direction-table>: Deleted.
9458 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9460 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9461 * doprnt.c: Include limits.h.
9462 (SIZE_MAX): New macro.
9463 (doprnt): Return a size_t value. 2nd arg is now size_t.
9464 Many local variables are now size_t instead of int or unsigned.
9465 Improve overflow protection. Support `l' modifier for integer
9466 conversions. Support %l conversion. Don't assume an EMACS_INT
9467 argument for integer conversions and for %c.
9469 * lisp.h (doprnt): Restore prototype.
9471 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9474 * Makefile.in (base_obj): Add back doprnt.o.
9476 * deps.mk (doprnt.o): Add back prerequisites.
9477 (callint.o): Depend on character.h.
9479 * eval.c (internal_lisp_condition_case): Include the handler
9480 representation in the error message.
9481 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9482 when breaking from the loop.
9484 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9486 * callint.c (Fcall_interactively): When displaying error message
9487 about invalid control letter, pass the character's codepoint, not
9488 a pointer to its multibyte form. Improve display of the character
9489 in octal and display also its hex code.
9491 * character.c (char_string): Use %x to display the (unsigned)
9492 codepoint of an invalid character, to avoid displaying a bogus
9495 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9496 `error', not SYMBOL_NAME itself.
9498 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9499 character arguments to `error'.
9501 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9502 to `error' in error message about FINAL_CHAR argument. Make sure
9503 FINAL_CHAR is a character, and use %c when it is passed as
9504 argument to `error'.
9506 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9508 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9510 * w32.c: Include <time.h>.
9511 (sys_localtime): New function.
9513 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9515 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9517 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9519 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9521 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9524 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9526 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9527 gl_state.e_property when gl_state.object is Qt.
9529 * insdel.c (make_gap_larger): Remove limitation of buffer size
9532 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9534 * xdisp.c (lookup_glyphless_char_display)
9535 (produce_glyphless_glyph): Handle cons cell entry in
9536 glyphless-char-display.
9537 (Vglyphless_char_display): Document it.
9539 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9540 glyphless-char-display.
9542 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9544 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9546 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9549 definition for no-X builds.
9551 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9553 Static checks with GCC 4.6.0 and non-default toolkits.
9555 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9557 * process.c (keyboard_bit_set): Define only if SIGIO.
9558 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9559 (send_process): Repair possible setjmp clobbering.
9561 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9563 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9565 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9567 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9568 Define only if needed.
9570 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9571 by pacifying GCC about it. Maybe it's time to retire it?
9572 * xfaces.c (USG, __TIMEVAL__): Likewise.
9574 * dispextern.h (struct redisplay_interface): Rename param
9576 * termhooks.h (struct terminal): Likewise.
9577 * xterm.c (xembed_send_message): Likewise.
9579 * insdel.c (make_gap_smaller): Define only if
9580 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9582 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9585 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9586 so that we aren't warned about unused symbols.
9588 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9590 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9592 * xfns.c (x_real_positions): Mark locals as initialized.
9594 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9596 * xterm.c: Fix problems found by static analysis with other toolkits.
9597 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9598 (x_dispatch_event): Declare static if USE_GTK, and
9599 define if USE_GTK || USE_X_TOOLKIT.
9600 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9601 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9602 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9603 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9605 * xmenu.c (menu_help_callback): Pointer type fixes.
9606 Use const pointers when pointing at readonly data. Avoid pointer
9608 (FALSE): Remove unused macro.
9609 (update_frame_menubar): Remove unused decl.
9611 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9613 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9614 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9615 (single_menu_item): Rename local to avoid shadowing.
9617 * keyboard.c (make_lispy_event): Remove unused local var.
9619 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9620 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9622 * bitmaps: Change bitmaps from unsigned char back to the X11
9623 compatible char. Avoid the old compiler warnings about
9624 out-of-range initializers by using, for example, '\xab' rather
9627 * xgselect.c (xgselect_initialize): Check vs interface
9628 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9630 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9632 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9633 to read-only memory.
9635 * fns.c (vector): Remove; this old hack is no longer needed.
9637 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9639 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9641 * xrdb.c (x_load_resources): Omit unused local.
9643 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9644 (x_window): Rename locals to avoid shadowing.
9645 (USG): Use the kludged USG macro, to pacify gcc.
9647 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9648 (x_term_init): Remove local to avoid shadowing.
9650 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9652 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9653 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9655 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9657 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9659 Fix regex.c, syntax.c and friends for buffers > 2GB.
9660 * syntax.h (struct gl_state_s): Declare character position members
9663 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9665 * textprop.c (verify_interval_modification, interval_of):
9666 Declare arguments EMACS_INT.
9668 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9671 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9673 * indent.c (Fvertical_motion): Local variable it_start is now
9676 * regex.c (re_match, re_match_2, re_match_2_internal)
9677 (bcmp_translate, regcomp, regexec, print_double_string)
9678 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9679 (re_compile_pattern, re_exec): Declare arguments and local
9680 variables `size_t' and `ssize_t' and return values `regoff_t', as
9682 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9683 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9684 <compile_stack_type>: `size' and `avail' are now `size_t'.
9686 * regex.h <regoff_t>: Use ssize_t, not int.
9687 (re_search, re_search_2, re_match, re_match_2): Arguments that
9688 specify buffer/string position and length are now ssize_t and
9689 size_t. Return type is regoff_t.
9691 2011-04-16 Ben Key <bkey76@gmail.com>
9693 * nsfont.m: Fixed bugs in ns_get_family and
9694 ns_descriptor_to_entity that were caused by using free to
9695 deallocate memory blocks that were allocated by xmalloc (via
9696 xstrdup). This caused Emacs to crash when compiled with
9697 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9698 --enable-checking=xmallocoverrun). xfree is now used to
9699 deallocate these memory blocks.
9701 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9703 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9705 emacs_write: Accept and return EMACS_INT for sizes.
9706 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9708 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9709 Accept and return EMACS_INT.
9710 (emacs_gnutls_write): Return the number of bytes written on
9712 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9713 (emacs_read, emacs_write): Remove check for negative size, as the
9714 Emacs source code has been audited now.
9715 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9716 (emacs_read, emacs_write): Use it.
9717 * process.c (send_process): Adjust to the new signatures of
9718 emacs_write and emacs_gnutls_write. Do not attempt to store
9719 a byte offset into an 'int'; it might overflow.
9720 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9722 * sound.c: Don't assume sizes fit in 'int'.
9723 (struct sound_device.period_size, alsa_period_size):
9724 Return EMACS_INT, not int.
9725 (struct sound_device.write, vox_write, alsa_write):
9726 Accept EMACS_INT, not int.
9727 (wav_play, au_play): Use EMACS_INT to store sizes and to
9728 record read return values.
9730 2011-04-15 Ben Key <bkey76@gmail.com>
9732 * keyboard.c (Qundefined): Don't declare static since it is used
9734 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9735 static since they are used in nsfont.m.
9737 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9739 * process.c (Qprocessp): Don't declare static.
9740 * lisp.h (Qprocessp): Declare again.
9742 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9744 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9746 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9748 Improve C-level modularity by making more things 'static'.
9750 Don't publish debugger-only interfaces to other modules.
9751 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9752 (verify_bytepos, count_markers): Move decls to the only modules
9754 * region-cache.h (pp_cache): Likewise.
9755 * window.h (check_all_windows): Likewise.
9756 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9758 * sysdep.c (croak): Now static, if
9759 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9760 * syssignal.h (croak): Declare only if not static.
9762 * alloc.c (refill_memory_reserve): Now static if
9763 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9764 * lisp.h (refill_memory_reserve): Declare only if not static.
9766 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9767 Define only if USE_LUCID.
9769 * xrdb.c (x_customization_string, x_rm_string): Now static.
9771 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9772 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9774 * xdisp.c (draw_row_with_mouse_face): Now static.
9775 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9777 * window.h (check_all_windows): Mark externally visible.
9779 * window.c (window_deletion_count): Now static.
9781 * undo.c: Make symbols static if they're not exported.
9782 (last_undo_buffer, last_boundary_position, pending_boundary):
9785 * textprop.c (interval_insert_behind_hooks): Now static.
9786 (interval_insert_in_front_hooks): Likewise.
9788 * term.c: Make symbols static if they're not exported.
9789 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9790 (max_frame_lines, tty_set_terminal_modes):
9791 (tty_reset_terminal_modes, tty_turn_off_highlight):
9792 (get_tty_terminal): Now static.
9793 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9794 * termhooks.h (term_mouse_moveto): Do not declare if
9796 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9797 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9799 * sysdep.c: Make symbols static if they're not exported.
9800 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9802 (sigprocmask_set, full_mask): Remove; unused.
9803 (wait_debugging): Mark as visible.
9804 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9805 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9807 * syntax.c (syntax_temp): Define only if !__GNUC__.
9809 * sound.c (current_sound_device, current_sound): Now static.
9811 * search.c (searchbufs, searchbuf_head): Now static.
9813 * scroll.c (scroll_cost): Remove; unused.
9814 * dispextern.h (scroll_cost): Remove decl.
9816 * region-cache.h (pp_cache): Mark as externally visible.
9818 * process.c: Make symbols static if they're not exported.
9819 (process_tick, update_tick, create_process, chan_process):
9820 (Vprocess_alist, proc_buffered_char, datagram_access):
9821 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9822 (deactivate_process): Mark defn as static, as well as decl.
9823 * lisp.h (create_process): Remove decl.
9824 * process.h (chan_process, Vprocess_alist): Remove decls.
9826 * print.c: Make symbols static if they're not exported.
9827 (print_depth, new_backquote_output, being_printed, print_buffer):
9828 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9829 (print_interval, print_number_index, initial_stderr_stream):
9831 * lisp.h (Fprinc): Remove decl.
9832 (debug_output_compilation_hack): Mark as externally visible.
9834 * sysdep.c (croak): Move decl from here to syssignal.h.
9835 * syssignal.h (croak): Put it here, so the API can be checked when
9836 'croak' is called from dissociate_if_controlling_tty.
9838 * minibuf.c: Make symbols static if they're not exported.
9839 (minibuf_save_list, choose_minibuf_frame): Now static.
9840 * lisp.h (choose_minibuf_frame): Remove decl.
9842 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9844 * lread.c: Make symbols static if they're not exported.
9845 (read_objects, initial_obarray, oblookup_last_bucket_number):
9847 (make_symbol): Remove; unused.
9848 * lisp.h (initial_obarray, make_symbol): Remove decls.
9850 * keyboard.c: Make symbols static if they're not exported.
9851 (single_kboard, recent_keys_index, total_keys, recent_keys):
9852 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9853 (this_single_command_key_start, echoing, last_auto_save):
9854 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9855 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9856 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9857 (Vlispy_mouse_stem, double_click_count):
9859 (force_auto_save_soon): Define only if SIGDANGER.
9860 (ignore_mouse_drag_p): Now static if
9861 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9862 (print_help): Remove; unused.
9863 (stop_character, last_timer_event): Mark as externally visible.
9864 * keyboard.h (ignore_mouse_drag_p): Declare only if
9865 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9866 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9867 * lisp.h (echoing): Remove decl.
9868 (force_auto_save_soon): Declare only if SIGDANGER.
9869 * xdisp.c (redisplay_window): Simplify code, to make it more
9870 obvious that ignore_mouse_drag_p is not accessed if !defined
9871 USE_GTK && !defined HAVE_NS.
9873 * intervals.c: Make symbols static if they're not exported.
9874 (merge_properties_sticky, merge_interval_right, delete_interval):
9876 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9878 * insdel.c: Make symbols static if they're not exported.
9879 However, leave prepare_to_modify_buffer alone. It's never
9880 called from outside this function, but that appears to be a bug.
9881 (combine_after_change_list, combine_after_change_buffer):
9882 (adjust_after_replace, signal_before_change): Now static.
9883 (adjust_after_replace_noundo): Remove; unused.
9884 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9885 (signal_before_change): Remove decls.
9887 * indent.c (val_compute_motion, val_vmotion): Now static.
9889 * image.c: Make symbols static if they're not exported.
9890 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9892 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9893 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9895 * fringe.c (standard_bitmaps): Now static.
9896 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9898 * frame.c: Make symbols static if they're not exported.
9899 (x_report_frame_params, make_terminal_frame): Now static.
9900 (get_frame_param): Now static, unless HAVE_NS.
9901 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9902 (x_get_resource_string): Remove; not used.
9903 * frame.h (make_terminal_frame, x_report_frame_params):
9904 (x_get_resource_string); Remove decls.
9905 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9906 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9908 * font.c, fontset.c: Make symbols static if they're not exported.
9909 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9910 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9911 * font.c (font_close_object): Now static.
9912 * font.h (font_close_object): Remove.
9913 * fontset.c (FONTSET_OBJLIST): Remove.
9914 (free_realized_fontset) #if-0 the body, which does nothing.
9915 (face_suitable_for_char_p): #if-0, as it's never called.
9916 * fontset.h (face_suitable_for_char_p): Remove decl.
9917 * xfaces.c (face_at_string_position):
9918 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9919 since 0 is always ASCII.
9921 * fns.c (weak_hash_tables): Now static.
9923 * fileio.c: Make symbols static if they're not exported.
9924 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9925 (Vwrite_region_annotation_buffers): Now static.
9927 * eval.c: Make symbols static if they're not exported.
9928 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9929 * lisp.h (backtrace_list): Remove decl.
9931 * emacs.c: Make symbols static if they're not exported.
9932 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9933 (fatal_error_code, fatal_error_signal_hook, standard_args):
9935 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9936 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9937 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9938 * lisp.h (fatal_error_signal_hook): Remove decl.
9939 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9941 * editfns.c: Move a (normally-unused) function to its only use.
9942 * editfns.c, lisp.h (get_operating_system_release): Remove.
9943 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9944 worth the hassle of breaking this out.
9946 * xterm.c: Make symbols static if they're not exported.
9947 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9948 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9949 (x_destroy_window, x_delete_display):
9951 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9952 (x_mouse_leave): Remove; unused.
9953 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9954 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9955 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9957 (x_mouse_leave): Declare only if WINDOWSNT.
9958 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9959 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9962 * ftxfont.c: Make symbols static if they're not exported.
9963 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9965 * font.h (ftxfont_driver): Likewise.
9967 * xfns.c: Make symbols static if they're not exported.
9968 (x_last_font_name, x_display_info_for_name):
9969 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9970 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9971 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9972 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9973 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9974 (last_show_tip_args): Now static.
9975 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9976 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9977 (x_screen_planes): Remove; unused.
9978 * dispextern.h (x_screen_planes): Remove decl.
9980 * dispnew.c: Make symbols static if they're not exported.
9981 * dispextern.h (redraw_garbaged_frames, scrolling):
9982 (increment_row_positions): Remove.
9983 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9984 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9986 (redraw_garbaged_frames): Remove; unused.
9988 * xfaces.c: Make symbols static if they're not exported.
9989 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9991 * xterm.h (defined_color): Remove decls.
9992 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9993 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9994 (menu_face_changed_default, defined_color, free_realized_face):
9995 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9996 (ascii_face_of_lisp_face): Remove; unused.
9998 * xdisp.c: Make symbols static if they're not exported.
9999 * dispextern.h (scratch_glyph_row, window_box_edges):
10000 (glyph_to_pixel_coords, set_cursor_from_row):
10001 (get_next_display_element, set_iterator_to_next):
10002 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10003 (show_mouse_face): Remove decls
10004 * frame.h (message_buf_print): Likewise.
10005 * lisp.h (pop_message, set_message, check_point_in_composition):
10007 * xterm.h (set_vertical_scroll_bar): Likewise.
10008 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10009 (message_buf_print, scratch_glyph_row, displayed_buffer):
10010 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10011 (get_next_display_element, show_mouse_face, window_box_edges):
10012 (frame_to_window_pixel_xy, check_point_in_composition):
10013 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10014 (glyph_to_pixel_coords): Remove; unused.
10016 * dired.c (file_name_completion): Now static.
10018 * dbusbind.c (xd_in_read_queued_messages): Now static.
10020 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10021 * data.c (circular_list_error): Remove.
10023 * commands.h (last_point_position, last_point_position_buffer):
10024 (last_point_position_window): Remove decls.
10025 * keyboard.c: Make these variables static.
10027 * coding.h (coding, code_convert_region, encode_coding_gap):
10029 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10030 (iso_code_class, detect_coding, code_convert_region): Now static.
10031 (encode_coding_gap): Remove; unused.
10033 * chartab.c (chartab_chars, chartab_bits): Now static.
10035 * charset.h (charset_iso_8859_1): Remove decl.
10036 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10039 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10040 * ccl.c (Vccl_program_table): Now static.
10041 (check_ccl_update): Remove; unused.
10043 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10044 * category.h: ... from here.
10045 * category.c (check_category_table, set_category_set): Now static.
10047 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10048 * lisp.h: Remove these decls.
10050 * buffer.c (buffer_count): Remove unused var.
10052 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10053 so that it's not optimized away.
10054 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10055 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10056 exported only to the debugger.
10058 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10059 * atimer.h (run_all_atimers): Remove; not exported.
10061 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10062 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10063 was inaccessible from Lisp.
10064 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10065 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10067 alloc.c: Import and export fewer symbols, and remove unused items.
10068 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10070 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10071 it's not optimized away by whole-program optimization.
10072 (message_enable_multibyte, free_misc): Remove.
10073 (catchlist, handlerlist, mark_backtrace):
10074 Declare only if BYTE_MARK_STACK.
10075 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10076 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10077 (message_enable_multibyte): Remove decl.
10078 (free_misc, interval_free_list, float_block, float_block_index):
10079 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10080 (cons_free_list, last_marked_index):
10082 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10083 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10084 (mark_backtrace): Define only if BYTE_MARK_STACK.
10085 * xdisp.c (message_enable_multibyte): Now static.
10087 Declare Lisp_Object Q* variables to be 'static' if not exported.
10088 This makes it easier for human readers (and static analyzers)
10089 to see whether these variables are used from other modules.
10090 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10091 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10092 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10093 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10094 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10095 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10096 * xmenu.c, xselect.c:
10097 Declare Q* vars static if they are not used in other modules.
10098 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10099 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10100 Remove decls of unexported vars.
10101 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10103 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10105 Make Emacs functions such as Fatom 'static' by default.
10106 This makes it easier for human readers (and static analyzers)
10107 to see whether these functions can be called from other modules.
10108 DEFUN now defines a static function. To make the function external
10109 so that it can be used in other C modules, use the new macro DEFUE.
10110 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10111 (Finit_image_library):
10112 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10113 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10114 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10115 Remove decls, since these functions are now static.
10116 (Funintern, Fget_internal_run_time): New decls, since these functions
10117 were already external.
10119 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10120 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10121 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10122 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10123 * keyboard.c, keymap.c, lread.c:
10124 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10125 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10126 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10127 Mark functions with DEFUE instead of DEFUN,
10128 if they are used in other modules.
10129 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10130 decls for now-static functions.
10131 * buffer.h (Fdelete_overlay): Remove decl.
10132 * callproc.c (Fgetenv_internal): Mark as internal.
10133 * composite.c (Fremove_list_of_text_properties): Remove decl.
10134 (Fcomposition_get_gstring): New forward static decl.
10135 * composite.h (Fcomposite_get_gstring): Remove decl.
10136 * dired.c (Ffile_attributes): New forward static decl.
10137 * doc.c (Fdocumntation_property): New forward static decl.
10138 * eval.c (Ffetch_bytecode): New forward static decl.
10139 (Funintern): Remove extern decl; now in .h file where it belongs.
10140 * fileio.c (Fmake_symbolic_link): New forward static decl.
10141 * image.c (Finit_image_library): New forward static decl.
10142 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10143 * intervals.h (Fprevious_property_change):
10144 (Fremove_list_of_text_properties): Remove decls.
10145 * keyboard.c (Fthis_command_keys): Remove decl.
10146 (Fcommand_execute): New forward static decl.
10147 * keymap.c (Flookup_key): New forward static decl.
10148 (Fcopy_keymap): Now static.
10149 * keymap.h (Flookup_key): Remove decl.
10150 * process.c (Fget_process): New forward static decl.
10151 (Fprocess_datagram_address): Mark as internal.
10152 * syntax.c (Fsyntax_table_p): New forward static decl.
10153 (skip_chars): Remove duplicate decl.
10154 * textprop.c (Fprevious_property_change): New forward static decl.
10155 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10157 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10158 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10160 * editfns.c (Fformat): Remove unreachable code.
10162 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10164 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10167 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10169 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10170 when at ZV. (Bug#8487)
10172 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10174 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10176 * keyboard.c (parse_tool_bar_item): Likewise.
10177 * sound.c (sound_cleanup, alsa_close): Likewise.
10178 * termcap.c (tgetent): Likewise.
10179 * xfns.c (x_default_font_parameter): Likewise.
10180 * xsettings.c (read_and_apply_settings): Likewise.
10182 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10183 (overrun_check_free): Protoize.
10185 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10187 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10188 since callers should never pass a negative size.
10189 Change the signature to match that of plain 'read' and 'write'; see
10190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10191 * lisp.h: Update prototypes of emacs_write and emacs_read.
10193 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10195 * xdisp.c (redisplay_window): Don't try to determine the character
10196 position of the scroll margin if the window start point w->startp
10197 is outside the buffer's accessible region. (Bug#8468)
10199 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10201 Fix write-region and its subroutines for buffers > 2GB.
10202 * fileio.c (a_write, e_write): Modify declaration of arguments and
10203 local variables to support buffers larger than 2GB.
10204 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10206 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10207 argument, local variables, and return value.
10209 * lisp.h: Update prototypes of emacs_write and emacs_read.
10211 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10213 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10215 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10217 Fix more problems found by GCC 4.6.0's static checks.
10219 * xdisp.c (vmessage): Use a better test for character truncation.
10221 * charset.c (load_charset_map): <, not <=, for optimization,
10222 and to avoid potential problems with integer overflow.
10223 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10224 * casetab.c (set_identity, shuffle): Likewise.
10225 * editfns.c (Fformat): Likewise.
10226 * syntax.c (skip_chars): Likewise.
10228 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10229 This also lets GCC 4.6.0 generate slightly better loop code.
10231 * callint.c (Fcall_interactively): <, not <=, for optimization.
10232 (Fcall_interactively): Count the number of arguments produced,
10233 not the number of arguments given. This is simpler and lets GCC
10234 4.6.0 generate slightly better code.
10236 * ftfont.c: Distingish more carefully between FcChar8 and char.
10237 The previous code passed unsigned char * to a functions like
10238 strlen and xstrcasecmp that expect char *, which does not
10239 conform to the C standard.
10240 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10241 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10242 char * when the C standard requires it.
10244 * keyboard.c (read_char): Remove unused var.
10246 * eval.c: Port to Windows vsnprintf (Bug#8435).
10247 Include <limits.h>.
10248 (SIZE_MAX): Define if the headers do not.
10249 (verror): Do not give up if vsnprintf returns a negative count.
10250 Instead, grow the buffer. This ports to Windows vsnprintf, which
10251 does not conform to C99. Problem reported by Eli Zaretskii.
10252 Also, simplify the allocation scheme, by avoiding the need for
10253 calling realloc, and removing the ALLOCATED variable.
10255 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10257 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10258 But keep the doprint source code for now, as we might revamp it
10259 and use it again (Bug#8435).
10260 * lisp.h (doprnt): Remove.
10261 * Makefile.in (base_obj): Remove doprnt.o.
10262 * deps.mk (doprnt.o): Remove.
10264 error: Print 32- and 64-bit integers portably (Bug#8435).
10265 Without this change, on typical 64-bit hosts error ("...%d...", N)
10266 was used to print both 32- and 64-bit integers N, which relied on
10267 undefined behavior.
10268 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10269 * lisp.h (error, verror): Mark as printf-like functions.
10270 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10271 Report overflow in size calculations when allocating printf buffer.
10272 Do not truncate output string at its first null byte.
10273 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10274 Truncate the output at a character boundary, since vsnprintf does not
10276 * charset.c (check_iso_charset_parameter): Convert internal
10277 character to string before calling 'error', since %c now has the
10279 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10280 overflow when computing char to be passed to 'error'. Do not
10281 pass Lisp_Object to 'error'; pass the integer instead.
10282 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10283 formatted with plain %d.
10285 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10287 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10289 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10291 * xterm.c (x_catch_errors): Remove duplicate declaration.
10293 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10295 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10297 2011-04-10 Jim Meyering <meyering@redhat.com>
10299 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10300 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10301 return ssize_t not "int", and use size_t as the buffer length.
10302 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10303 * gnutls.h: Update declarations.
10304 * process.c (read_process_output): Use ssize_t, to match.
10305 (send_process): Likewise.
10307 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10309 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10311 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10313 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10314 Use unsigned char, to match FcChar8 type definition.
10316 * xterm.c (handle_one_xevent):
10317 * xmenu.c (create_and_show_popup_menu):
10318 * xselect.c (x_decline_selection_request)
10319 (x_reply_selection_request): Avoid type-punned deref of X events.
10321 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10323 Fix some uses of `int' instead of EMACS_INT.
10324 * search.c (string_match_1, fast_string_match)
10325 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10326 (scan_buffer, find_next_newline_no_quit)
10327 (find_before_next_newline, search_command, Freplace_match)
10328 (Fmatch_data): Make some `int' variables be EMACS_INT.
10330 * xdisp.c (display_count_lines): 3rd argument and return value now
10331 EMACS_INT. All callers changed.
10332 (pint2hrstr): Last argument is now EMACS_INT.
10334 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10335 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10336 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10337 (decode_coding_utf_16, decode_coding_emacs_mule)
10338 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10339 (decode_coding_ccl, decode_coding_charset)
10340 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10341 (decode_coding_iso_2022, decode_coding_emacs_mule)
10342 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10343 <char_offset, last_offset>: Declare EMACS_INT.
10344 (encode_coding_utf_8, encode_coding_utf_16)
10345 (encode_coding_emacs_mule, encode_invocation_designation)
10346 (encode_designation_at_bol, encode_coding_iso_2022)
10347 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10348 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10350 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10351 (encode_invocation_designation): Last argument P_NCHARS is now
10353 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10354 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10356 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10359 * ccl.c (Fccl_execute_on_string): Declare some variables
10362 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10364 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10366 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10368 * process.c (Fformat_network_address): Doc fix.
10370 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10372 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10374 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10376 * keyboard.c (read_char): Call Lisp function help-form-show,
10377 instead of using internal_with_output_to_temp_buffer.
10378 (Qhelp_form_show): New var.
10379 (syms_of_keyboard): Use DEFSYM macro.
10381 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10383 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10385 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10387 * process.c (Flist_processes): Remove to Lisp.
10388 (list_processes_1): Delete.
10390 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10392 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10394 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10396 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10398 Fix more problems found by GCC 4.6.0's static checks.
10400 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10402 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10404 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10406 * xdisp.c (vmessage): Mark as a printf-like function.
10408 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10410 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10412 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10413 printf-like functions.
10414 (tiff_load): Add casts to remove these marks before passing them
10415 to system-supplied API.
10417 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10419 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10420 This avoids several warnings with gcc -Wstrict-overflow.
10421 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10422 directly, rather than having caller test rule sign. This avoids
10423 some unnecessary tests.
10424 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10425 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10426 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10428 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10429 (xfont_open): Avoid unnecessary tests.
10431 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10433 * composite.h, composite.c (composition_gstring_put_cache):
10434 Use EMACS_INT, not int, for length.
10436 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10437 breaking out part of COMPOSITION_DECODE_RULE.
10438 (COMPOSITION_DECODE_RULE): Use it.
10439 * composite.c (get_composition_id): Remove unused local vars,
10440 by using the new macro.
10442 * textprop.c (set_text_properties_1): Change while to do-while,
10443 since the condition is always true at first.
10445 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10446 (interval_deletion_adjustment): Return unsigned value.
10449 * process.c (list_processes_1, create_pty, read_process_output):
10450 (exec_sentinel): Remove vars that were set but not used.
10451 (create_pty): Remove unnecessary "volatile"s.
10452 (Fnetwork_interface_info): Avoid possibility of int overflow.
10453 (read_process_output): Do adaptive read buffering even if carryover.
10454 (read_process_output): Simplify nbytes computation if buffered.
10456 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10458 * syntax.c (scan_words): Remove var that was set but not used.
10459 (update_syntax_table): Use unsigned instead of int.
10461 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10462 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10463 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10465 * print.c (print_error_message): Avoid int overflow.
10467 * font.c (font_list_entities): Redo for clarity,
10468 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10470 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10471 (font_score): Avoid potential overflow in diff calculation.
10473 * fns.c (substring_both): Remove var that is set but not used.
10474 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10476 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10478 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10479 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10480 can always succeed if overflow has undefined behavior.
10482 * search.c (boyer_moore, wordify): Remove vars set but not used.
10483 (wordify): Omit three unnecessary tests.
10485 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10486 All callers changed. This avoids the need for an unused var.
10488 * casefiddle.c (casify_region): Remove var that is set but not used.
10490 * dired.c (file_name_completion): Remove var that is set but not used.
10492 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10494 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10495 (Finsert_file_contents): Remove unnecessary code checking fd.
10497 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10498 Check for integer overflow on size calculations.
10500 * buffer.c (Fprevious_overlay_change): Remove var that is set
10503 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10504 Remove vars that are set but not used.
10505 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10506 (timer_check_2): Mark vars as initialized.
10508 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10510 * image.c (lookup_image): Remove var that is set but not used.
10511 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10513 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10514 that are set but not used.
10516 * xfns.c (make_invisible_cursor): Don't return garbage
10517 if XCreateBitmapFromData fails (Bug#8410).
10519 * xselect.c (x_get_local_selection, x_handle_property_notify):
10520 Remove vars that are set but not used.
10522 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10523 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10525 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10526 Remove var that is set but not used.
10527 (scroll_bar_windows_size): Now size_t, not int.
10528 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10529 Check for overflow.
10531 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10532 (map_tty_color) [!defined MSDOS]: Likewise.
10534 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10536 * coding.c: Remove vars that are set but not used.
10537 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10538 All callers changed.
10539 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10540 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10541 (decode_coding_charset): Remove vars that are set but not used.
10543 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10544 that is set but not used.
10546 * print.c (print_object): Remove var that is set but not used.
10548 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10549 The gnulib version avoids calling malloc in the usual case,
10550 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10551 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10552 * filelock.c (current_lock_owner): Likewise.
10553 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10554 * sysdep.c: Include allocator.h, careadlinkat.h.
10555 (emacs_no_realloc_allocator): New static constant.
10556 (emacs_readlink): New function.
10557 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10558 ../lib/careadlinkat.h.
10560 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10562 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10563 first non-nil return value).
10565 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10567 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10568 if not defined (Bug#8403).
10570 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10572 * xdisp.c (display_count_lines): Remove parameter `start',
10573 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10574 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10575 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10576 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10577 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10578 and thereabouts. All callers changed.
10579 (get_per_char_metric): Remove parameter `f', unused since
10580 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10582 2011-04-02 Jim Meyering <meyering@redhat.com>
10584 do not dereference NULL upon failed strdup
10585 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10586 (ns_get_family): Likewise.
10588 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10590 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10592 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10594 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10597 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10599 Add lexical binding.
10601 * window.c (Ftemp_output_buffer_show): New fun.
10602 (Fsave_window_excursion):
10603 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10605 * lread.c (lisp_file_lexically_bound_p): New function.
10606 (Fload): Bind Qlexical_binding.
10607 (readevalloop): Remove `evalfun' arg.
10608 Bind Qinternal_interpreter_environment.
10609 (Feval_buffer): Bind Qlexical_binding.
10610 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10612 (syms_of_lread): Declare `lexical-binding'.
10614 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10616 * keyboard.c (eval_dyn): New fun.
10617 (menu_item_eval_property): Use it.
10619 * image.c (parse_image_spec): Use Ffunctionp.
10621 * fns.c (concat, mapcar1): Accept byte-code-functions.
10623 * eval.c (Fsetq): Handle lexical vars.
10624 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10625 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10626 (FletX, Flet): Obey lexical binding.
10627 (Fcommandp): Handle closures.
10628 (Feval): New `lexical' arg.
10629 (eval_sub): New function extracted from Feval. Use it almost
10630 everywhere where Feval was used. Look up vars in lexical env.
10632 (Ffunctionp): Move from subr.el.
10633 (Ffuncall): Handle closures.
10634 (apply_lambda): Remove `eval_flags'.
10635 (funcall_lambda): Handle closures and new byte-code-functions.
10636 (Fspecial_variable_p): New function.
10637 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10638 but without exporting it to Lisp.
10640 * doc.c (Fdocumentation, store_function_docstring):
10641 * data.c (Finteractive_form): Handle closures.
10643 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10646 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10648 (exec_byte_code): New function extracted from Fbyte_code to handle new
10649 calling convention for byte-code-functions. Add new byte-codes.
10651 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10653 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10655 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10657 * xdisp.c (redisplay_internal): Fix prototype.
10659 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10661 * xdisp.c (SCROLL_LIMIT): New macro.
10662 (try_scrolling): Use it when setting scroll_limit.
10663 Limit scrolling to 100 screen lines.
10664 (redisplay_window): Even when falling back on "recentering",
10665 position point in the window according to scroll-conservatively,
10666 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10668 (try_scrolling): When point is above the window, allow searching
10669 as far as scroll_max, or one screenful, to compute vertical
10670 distance from PT to the scroll margin position. This prevents
10671 try_scrolling from unnecessarily failing when
10672 scroll-conservatively is set to a value slightly larger than the
10673 window height. Clean up the case of PT below the margin at bottom
10674 of window: scroll_max can no longer be INT_MAX. When aggressive
10675 scrolling is in use, don't let point enter the opposite scroll
10676 margin as result of the scroll.
10677 (syms_of_xdisp) <scroll-conservatively>: Document the
10678 threshold of 100 lines for never-recentering scrolling.
10680 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10682 * dispextern.h (move_it_by_lines):
10683 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10684 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10685 (message_log_check_duplicate): Remove parameters `prev_bol' and
10686 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10687 (redisplay_internal): Remove parameter `preserve_echo_area',
10688 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10690 * indent.c (Fvertical_motion):
10691 * window.c (window_scroll_pixel_based, Frecenter):
10692 Don't pass `need_y_p' to `move_it_by_lines'.
10694 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10696 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10697 steal a few bits to be more compact.
10698 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10699 Remove unneeded casts.
10701 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10703 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10705 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10706 binding" message (bug#7967).
10708 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10710 Fix more problems found by GCC 4.6.0's static checks.
10712 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10713 Remove unused local var.
10715 * editfns.c (Fmessage_box): Remove unused local var.
10717 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10718 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10719 Omit unused local vars.
10720 * window.c (shrink_windows): Omit unused local var.
10721 * menu.c (digest_single_submenu): Omit unused local var.
10722 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10723 Omit unused local var.
10725 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10726 Don't assume string length fits in int.
10727 (keyremap_step, read_key_sequence): Use size_t for sizes.
10728 (read_key_sequence): Don't check last_real_key_start redundantly.
10730 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10731 instead of alloca (Bug#8344).
10733 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10734 (Fbacktrace_frame): Don't assume nframes fits in int.
10736 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10738 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10741 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10743 * cm.c (calccost): Turn while-do into do-while, for clarity.
10745 * keyboard.c (syms_of_keyboard): Use the same style as later
10746 in this function when indexing through an array. This also
10747 works around GCC bug 48267.
10749 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10751 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10753 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10754 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10756 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10757 This avoids undefined behavior on integer overflow, and is a bit
10758 more convenient anyway since it is compared to a size_t variable.
10760 Variadic C functions now count arguments with size_t, not int.
10761 This avoids an unnecessary limitation on 64-bit machines, which
10762 caused (substring ...) to crash on large vectors (Bug#8344).
10763 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10764 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10765 All variadic functions and their callers changed accordingly.
10766 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10767 * data.c (arith_driver, float_arith_driver): Likewise.
10768 * editfns.c (general_insert_function): Likewise.
10769 * eval.c (struct backtrace.nargs, interactive_p)
10770 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10771 (funcall_lambda, mark_backtrace): Likewise.
10772 * fns.c (concat): Likewise.
10773 * frame.c (x_set_frame_parameters): Likewise.
10774 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10775 0 if not found, not -1. All callers changed.
10777 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10778 (stack_copy_size): Now size_t, not int.
10779 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10781 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10783 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10784 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10785 All callers changed.
10787 * lisp.h (multibyte_char_to_unibyte):
10788 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10789 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10790 * character.h (CHAR_TO_BYTE8):
10791 * cmds.c (internal_self_insert):
10792 * editfns.c (general_insert_function):
10793 * keymap.c (push_key_description):
10794 * search.c (Freplace_match):
10795 * xdisp.c (message_dolog, set_message_1): All callers changed.
10797 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10799 * keyboard.c (safe_run_hook_funcall): New function.
10800 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10801 don't set the hook to nil, but remove the offending function instead.
10802 (Qcommand_hook_internal): Remove, unused.
10803 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10804 Vcommand_hook_internal.
10806 * eval.c (enum run_hooks_condition): Remove.
10807 (funcall_nil, funcall_not): New functions.
10808 (run_hook_with_args): Call each function through a `funcall' argument.
10809 Remove `cond' argument, now redundant.
10810 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10811 (Frun_hook_with_args_until_failure): Adjust accordingly.
10812 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10814 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10816 * dispextern.h (string_buffer_position): Remove declaration.
10818 * print.c (strout): Remove parameter `multibyte', unused since
10819 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10821 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10822 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10823 All callers changed.
10825 * w32.c (_wsa_errlist): Use braces for struct initializers.
10827 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10828 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10829 All callers changed.
10830 (string_buffer_position): Likewise. Also, make static (it's never
10831 used outside xdisp.c).
10832 (cursor_row_p): Remove parameter `w', unused since
10833 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10834 (decode_mode_spec): Remove parameter `precision', introduced during
10835 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10836 All callers changed.
10838 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10840 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10842 2011-03-27 Anders Lindgren <andlind@gmail.com>
10844 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10845 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10846 (ns_update_auto_hide_menu_bar): New functions.
10847 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10848 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10849 ns_constrain_all_frames.
10850 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10851 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10853 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10855 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10857 2011-03-27 Glenn Morris <rgm@gnu.org>
10859 * syssignal.h: Replace RETSIGTYPE with void.
10860 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10861 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10862 Replace SIGTYPE with void everywhere.
10863 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10864 * s/template.h (SIGTYPE): Remove commented out definition.
10866 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10868 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10869 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10871 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10873 * w32.c (read_unc_volume): Use parameter `henum', instead of
10874 global variable `wget_enum_handle'.
10876 * keymap.c (describe_vector): Remove parameters `indices' and
10877 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10878 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10880 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10882 * keyboard.c (timer_check): Remove parameter `do_it_now',
10883 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10884 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10885 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10887 * keyboard.c (read_char):
10888 * w32menu.c (w32_menu_display_help):
10889 * xmenu.c (show_help_event, menu_help_callback):
10890 Adjust calls to `show_help_echo'.
10892 * gtkutil.c (xg_maybe_add_timer):
10893 * keyboard.c (readable_events):
10894 * process.c (wait_reading_process_output):
10895 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10897 * insdel.c (adjust_markers_gap_motion):
10898 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10899 (gap_left, gap_right): Don't call it.
10901 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10903 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10904 incurred during fontification.
10906 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10908 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10909 (DEFVAR_PER_BUFFER): Don't pass it.
10911 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10912 (scrolling_window): Don't pass it.
10914 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10916 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10918 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10920 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10921 of variables specific to SELinux and computation of `encoded_absname'.
10923 * image.c (XPutPixel): Remove unused variable `height'.
10925 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10927 * unexw32.c (get_section_info): Remove unused variable `section'.
10929 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10930 (system_process_attributes): Remove unused variable `sess'.
10931 (sys_read): Remove unused variable `err'.
10933 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10934 (w32_wnd_proc): Remove unused variable `isdead'.
10935 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10936 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10937 (x_create_tip_frame): Remove unused variable `tem'.
10939 * w32inevt.c (w32_console_read_socket):
10940 Remove unused variable `no_events'.
10942 * w32term.c (x_draw_composite_glyph_string_foreground):
10943 Remove unused variable `width'.
10945 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10947 * w32term.c (x_set_glyph_string_clipping):
10948 Don't pass uninitialized region to CombineRgn.
10950 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10952 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10953 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10954 (Fx_close_connection): Remove unused variable `i'.
10956 * w32font.c (w32font_draw): Return number of glyphs.
10957 (w32font_open_internal): Remove unused variable `i'.
10958 (w32font_driver): Add missing initializer.
10960 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10961 (fill_in_menu): Remove unused variable `items_added'.
10963 * w32term.c (last_mouse_press_frame): Remove static global variable.
10964 (w32_clip_to_row): Remove unused variable `f'.
10965 (x_delete_terminal): Remove unused variable `i'.
10967 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10968 (NOTHING): Remove unused static global variable.
10969 (uniscribe_check_otf): Remove unused variable `table'.
10970 (uniscribe_font_driver): Add missing initializers.
10972 2011-03-23 Julien Danjou <julien@danjou.info>
10974 * term.c (Fsuspend_tty, Fresume_tty):
10975 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10976 * window.c (temp_output_buffer_show):
10977 * insdel.c (signal_before_change):
10978 * frame.c (Fhandle_switch_frame):
10979 * fileio.c (Fdo_auto_save):
10980 * emacs.c (Fkill_emacs):
10981 * editfns.c (save_excursion_restore):
10982 * cmds.c (internal_self_insert):
10983 * callint.c (Fcall_interactively):
10984 * buffer.c (Fkill_all_local_variables):
10985 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10987 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10988 unconditionally since it does the check itself.
10990 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10992 Fix more problems found by GCC 4.5.2's static checks.
10994 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10995 the first time through the loop, since we know p0 < p1 then.
10996 This also avoids a gcc -Wstrict-overflow warning.
10998 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10999 leading to a memory leak, possible in functions like
11000 load_charset_map_from_file that can allocate an unbounded number
11001 of objects (Bug#8318).
11003 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11004 that could (at least in theory) be that large.
11006 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11007 This is less likely to overflow, and avoids undefined behavior if
11008 overflow does occur. All callers changed. Use strtoul to scan
11009 for the unsigned long integer.
11010 (pint2hrstr): Simplify and tune code slightly.
11011 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11013 * scroll.c (do_scrolling): Work around GCC bug 48228.
11014 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11016 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11017 This also avoids a warning with gcc -Wstrict-overflow.
11018 (validate_x_resource_name): Simplify count usage.
11019 This also avoids a warning with gcc -Wstrict-overflow.
11021 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11024 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11026 * process.c (Fmake_network_process): Use socklen_t, not int,
11027 where POSIX says socklen_t is required in portable programs.
11028 This fixes a porting bug on hosts like 64-bit HP-UX, where
11029 socklen_t is wider than int (Bug#8277).
11030 (Fmake_network_process, server_accept_connection):
11031 (wait_reading_process_output, read_process_output):
11034 * process.c: Rename or move locals to avoid shadowing.
11035 (list_processes_1, Fmake_network_process):
11036 (read_process_output_error_handler, exec_sentinel_error_handler):
11037 Rename or move locals.
11038 (Fmake_network_process): Define label "retry_connect" only if needed.
11039 (Fnetwork_interface_info): Fix pointer signedness.
11040 (process_send_signal): Add cast to avoid pointer signedness problem.
11041 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11042 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11044 Make tparam.h and terminfo.c consistent.
11045 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11046 Include tparam.h instead, since it declares them.
11047 * cm.h (PC): Remove extern decl; tparam.h now does this.
11048 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11049 * terminfo.c: Include tparam.h, to check interfaces.
11050 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11051 (tparam): Adjust signature to match interface in tparam.h;
11052 this removes some undefined behavior. Check that outstring and len
11053 are zero, which they always are with Emacs.
11054 * tparam.h (PC, BC, UP): New extern decls.
11056 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11057 (xftfont_open): Rename locals to avoid shadowing.
11059 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11060 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11061 (OTF_TAG_SYM): Omit macro if not needed.
11062 (ftfont_list): Remove unused local.
11063 (get_adstyle_property, ftfont_pattern_entity):
11064 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11065 Rename locals to avoid shadowing.
11067 * xfont.c (xfont_list_family): Mark var as initialized.
11069 * xml.c (make_dom): Now static.
11071 * composite.c (composition_compute_stop_pos): Rename local to
11073 (composition_reseat_it): Remove unused locals.
11074 (find_automatic_composition, composition_adjust_point): Likewise.
11075 (composition_update_it): Mark var as initialized.
11076 (find_automatic_composition): Mark vars as initialized,
11077 with a FIXME (Bug#8290).
11079 character.h: Rename locals to avoid shadowing.
11080 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11081 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11082 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11083 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11084 to avoid shadowing.
11086 * textprop.c (property_change_between_p): Remove; unused.
11088 * intervals.c (interval_start_pos): Now static.
11090 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11092 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11093 Rename locals to avoid shadowing.
11095 * sound.c (wav_play, au_play, Fplay_sound_internal):
11096 Fix pointer signedness.
11097 (alsa_choose_format): Remove unused local var.
11098 (wav_play): Initialize a variable to 0, to prevent undefined
11099 behavior (Bug#8278).
11101 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11103 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11105 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11106 clobbering (Bug#8298).
11107 * sysdep.c (sys_subshell): Likewise.
11108 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11110 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11111 This should get cleaned up, so that child_setup has the
11112 same signature on all platforms.
11114 * callproc.c (call_process_cleanup): Now static.
11115 (relocate_fd): Rename locals to avoid shadowing.
11117 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11119 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11120 not to be necessary, and produces flickering.
11122 2011-03-20 Glenn Morris <rgm@gnu.org>
11124 * config.in: Remove file.
11126 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11128 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11129 are now in src/globals.h.
11130 (syms_of_minibuf): Remove spurious & from previous change.
11132 2011-03-20 Leo Liu <sdl.web@gmail.com>
11134 * minibuf.c (completing-read-function): New variable.
11135 (completing-read-default): Rename from completing-read.
11136 (completing-read): Call completing-read-function.
11138 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11140 * xfaces.c (Fx_load_color_file):
11141 Read color file from absolute filename (bug#8250).
11143 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11145 * makefile.w32-in: Update dependencies.
11147 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11149 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11151 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11153 Fix more problems found by GCC 4.5.2's static checks.
11155 * process.c (make_serial_process_unwind, send_process_trap):
11156 (sigchld_handler): Now static.
11158 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11159 That way, the code declares only the vars that it needs.
11160 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11161 * s/cygwin.h (PTY_ITERATION): Likewise.
11162 * s/darwin.h (PTY_ITERATION): Likewise.
11163 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11165 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11166 * process.c (allocate_pty): Don't declare stb unless it's needed.
11168 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11169 (CONSTANTLIM): Remove; unused.
11170 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11171 Define only if needed.
11173 * unexelf.c (unexec): Name an expression,
11174 to avoid gcc -Wbad-function-cast warning.
11175 Use a different way to cause a compilation error if anyone uses
11176 n rather than nn, a way that does not involve shadowing.
11177 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11179 * deps.mk (unexalpha.o): Remove; unused.
11181 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11182 * unexec.h: New file.
11183 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11184 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11185 Depend on unexec.h.
11186 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11187 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11188 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11189 Change as necessary to match prototype in unexec.h.
11191 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11193 (back_comment, skip_chars): Mark vars as initialized.
11195 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11196 Rename locals to avoid shadowing.
11198 * lread.c (read1): Rewrite so as not to use empty "else".
11199 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11201 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11203 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11204 warning when compiling print.c.
11206 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11207 instead of using an uninitialized var.
11208 (font_sort_entities): Mark var as initialized.
11210 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11212 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11213 pointers to constants.
11214 (font_parse_fcname): Remove unused vars.
11215 (font_delete_unmatched): Now static.
11216 (font_get_spec): Remove; unused.
11217 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11218 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11219 Rename or move locals to avoid shadowing.
11221 * fns.c (require_nesting_list, require_unwind): Now static.
11222 (Ffillarray): Rename locals to avoid shadowing.
11224 * floatfns.c (domain_error2): Define only if needed.
11225 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11227 * alloc.c (mark_backtrace): Move decl from here ...
11228 * lisp.h: ... to here, so that it can be checked.
11230 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11231 (Fdefvar): Rewrite so as not to use empty "else".
11232 (lisp_indirect_variable): Name an expression,
11233 to avoid gcc -Wbad-function-cast warning.
11234 (Fdefvar): Rename locals to avoid shadowing.
11236 * callint.c (quotify_arg, quotify_args): Now static.
11237 (Fcall_interactively): Rename locals to avoid shadowing.
11238 Use const pointer when appropriate.
11240 * lisp.h (get_system_name, get_operating_system_release):
11241 Move decls here, to check interfaces.
11242 * process.c (get_operating_system_release): Move decl to lisp.h.
11243 * xrdb.c (get_system_name): Likewise.
11244 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11245 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11246 some of which prompt warnings from gcc -Wbad-function-cast.
11247 (Fformat_time_string, Fencode_time, Finsert_char):
11248 (Ftranslate_region_internal, Fformat):
11249 Rename or remove local vars to avoid shadowing.
11250 (Ftranslate_region_internal): Mark var as initialized.
11252 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11255 * lisp.h (eassert): Check that the argument compiles, even if
11256 ENABLE_CHECKING is not defined.
11258 * data.c (Findirect_variable): Name an expression, to avoid
11259 gcc -Wbad-function-cast warning.
11260 (default_value, arithcompare, arith_driver, arith_error): Now static.
11261 (store_symval_forwarding): Rename local to avoid shadowing.
11262 (Fmake_variable_buffer_local, Fmake_local_variable):
11263 Mark variables as initialized.
11264 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11266 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11267 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11268 Rename locals to avoid shadowing.
11269 (mark_stack): Move local variables into the #ifdef region where
11271 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11272 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11274 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11275 (GC_STRING_CHARS): Remove; not used.
11276 (Fmemory_limit): Cast sbrk's returned value to char *.
11278 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11279 avoids undefined behavior in theory.
11281 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11283 Use functions, not macros, for up- and down-casing (Bug#8254).
11284 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11285 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11286 to use the following functions instead of these macros.
11287 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11288 EMACS_INT, since callers assume the returned value fits in int.
11289 (upcase1): Likewise, for UPCASE_TABLE.
11290 (uppercasep, lowercasep, upcase): New static inline functions.
11291 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11292 the race-condition problem in the old DOWNCASE.
11294 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11295 Rename locals to avoid shadowing.
11296 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11297 (regex_compile, re_search_2, re_match_2_internal):
11298 Remove unused local vars.
11299 (FREE_VAR): Rewrite so as not to use empty "else",
11300 which gcc can warn about.
11301 (regex_compile, re_match_2_internal): Mark locals as initialized.
11302 (RETALLOC_IF): Define only if needed.
11303 (WORDCHAR_P): Likewise. This one is never needed, but is used
11304 only in a comment talking about a compiler bug, so put inside
11305 the #if 0 of that comment.
11306 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11307 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11310 * search.c (boyer_moore): Rename locals to avoid shadowing.
11311 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11312 (PREV_CHAR_BOUNDARY): Likewise.
11314 * search.c (simple_search): Remove unused var.
11316 * dired.c (compile_pattern): Move decl from here ...
11317 * lisp.h: ... to here, so that it can be checked.
11318 (struct re_registers): New forward decl.
11320 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11322 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11324 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11325 Rename locals to avoid shadowing.
11326 (Fvertical_motion): Mark locals as initialized.
11328 * casefiddle.c (casify_object, casify_region): Now static.
11329 (casify_region): Mark local as initialized.
11331 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11333 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11334 New macros, so that the caller can use some names other than
11335 gcpro1, gcpro2, etc.
11336 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11338 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11339 argument, for consistency with GCPRO2_VAR, etc: it is now the
11340 prefix of the variable, not the variable itself. All uses
11342 * dired.c (directory_files_internal, file_name_completion):
11343 Rename locals to avoid shadowing.
11345 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11346 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11347 dired.c's scmp function, had undefined behavior.
11348 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11349 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11350 * buffer.h: ... to here, because these macros use current_buffer,
11351 and the new implementation with inline functions needs to have
11352 current_buffer in scope now, rather than later when the macros
11354 (downcase, upcase1): New static inline functions.
11355 (DOWNCASE, UPCASE1): Reimplement using these functions.
11356 This avoids undefined behavior in expressions like
11357 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11358 from race conditions in accessing the global variables
11359 case_temp1 and case_temp2.
11360 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11361 * lisp.h (case_temp1, case_temp2): Remove their decls.
11362 * character.h (ASCII_CHAR_P): Move from here ...
11363 * lisp.h: ... to here, so that the inline functions mentioned
11364 above can use them.
11366 * dired.c (directory_files_internal_unwind): Now static.
11368 * fileio.c (file_name_as_directory, directory_file_name):
11369 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11371 (file_name_as_directory): Use const pointers when appropriate.
11372 (Fexpand_file_name): Likewise. In particular, newdir might
11373 point at constant storage, so make it a const pointer.
11374 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11375 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11377 (Fset_file_times, Finsert_file_contents, auto_save_error):
11378 Rename locals to avoid shadowing.
11380 * minibuf.c (choose_minibuf_frame_1): Now static.
11381 (Ftry_completion, Fall_completions): Rename or remove locals
11382 to avoid shadowing.
11384 * marker.c (bytepos_to_charpos): Remove; unused.
11386 * lisp.h (verify_bytepos, count_markers): New decls,
11387 so that gcc does not warn that these functions aren't declared.
11389 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11390 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11391 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11392 (copy_text): Remove unused local var.
11394 * filelock.c (within_one_second): Now static.
11395 (lock_file_1): Rename local to avoid shadowing.
11397 * buffer.c (fix_overlays_before): Mark locals as initialized.
11398 (fix_start_end_in_overlays): Likewise. This function should be
11399 simplified by using pointers-to-pointers, but that's a different
11401 (switch_to_buffer_1): Now static.
11402 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11403 (report_overlay_modification): Rename locals to avoid shadowing.
11405 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11406 Fix pointer signedness issue.
11407 (sys_subshell): Mark local as volatile if checking for lint,
11408 to suppress a gcc -Wclobbered warning that does not seem to be right.
11409 (MAXPATHLEN): Define only if needed.
11411 * process.c (serial_open, serial_configure): Move decls from here ...
11412 * systty.h: ... to here, so that they can be checked.
11414 * fns.c (get_random, seed_random): Move extern decls from here ...
11415 * lisp.h: ... to here, so that they can be checked.
11417 * sysdep.c (reset_io): Now static.
11418 (wait_for_termination_signal): Remove; unused.
11420 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11421 (copy_keymap_item, append_key, push_text_char_description):
11423 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11424 (DENSE_TABLE_SIZE): Remove; unused.
11425 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11426 (describe_map_tree):
11427 Rename locals to avoid shadowing.
11429 * keyboard.c: Declare functions static if they are not used elsewhere.
11430 (echo_char, echo_dash, cmd_error, top_level_2):
11431 (poll_for_input, handle_async_input): Now static.
11432 (read_char, kbd_buffer_get_event, make_lispy_position):
11433 (make_lispy_event, make_lispy_movement, apply_modifiers):
11434 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11435 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11436 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11437 (read_key_sequence, read_char): Mark locals as initialized.
11438 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11440 * keyboard.h (make_ctrl_char): New decl.
11441 (mark_kboards): Move decl here ...
11442 * alloc.c (mark_kboards): ... from here.
11444 * lisp.h (force_auto_save_soon): New decl.
11446 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11447 (DEFINE_DUMMY_FUNCTION): New macro.
11448 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11450 (main): Add casts to avoid warnings
11451 if GCC considers string literals to be constants.
11453 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11455 * dbusbind.c: Pointer signedness fixes.
11456 (xd_signature, xd_append_arg, xd_initialize):
11457 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11458 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11459 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11460 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11462 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11463 if GCC considers string literals to be constants.
11464 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11466 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11468 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11469 (print_preprocess, print_object): New macro to fix last change.
11471 * print.c (print_preprocess): Don't forget font objects.
11473 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11475 * emacs.c (USAGE3): Doc fixes.
11477 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11479 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11482 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11484 * lisp.h (VWindow_system, Qfile_name_history):
11485 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11486 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11487 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11489 * w32select.c: Don't #include "keyboard.h".
11490 (run_protected): Add extern declaration for waiting_for_input.
11492 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11493 * w32console.c (detect_input_pending, read_input_pending)
11494 (encode_terminal_code):
11495 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11496 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11497 (w32_system_caret_y, Qfile_name_history):
11498 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11499 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11500 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11501 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11502 * w32proc.c (Qlocal, report_file_error):
11503 * w32term.c (Vwindow_system, updating_frame):
11504 * w32uniscribe.c (initialized, uniscribe_font_driver):
11505 Remove unneeded extern declarations.
11507 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11509 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11511 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11513 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11514 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11515 These macros can no longer be used for assignment.
11517 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11518 Assign struct members directly, instead of using BUF_BEGV etc.
11519 (record_buffer_markers, fetch_buffer_markers): New functions for
11520 recording and fetching special buffer markers.
11521 (set_buffer_internal_1, set_buffer_temp): Use them.
11523 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11525 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11527 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11528 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11530 * xdisp.c (hscroll_window_tree):
11531 (reconsider_clip_changes): Use PT instead of BUF_PT.
11533 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11535 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11536 $(EMACS_ROOT)/lib/intprops.h.
11538 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11540 Fix more problems found by GCC 4.5.2's static checks.
11542 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11543 to unsigned char * to avoid compiler diagnostic.
11544 (xg_free_frame_widgets): Make it clear that a local variable is
11545 needed only if USE_GTK_TOOLTIP.
11546 (gdk_window_get_screen): Make it clear that this macro is needed
11547 only if USE_GTK_TOOLTIP.
11548 (int_gtk_range_get_value): New function, which avoids a diagnostic
11549 from gcc -Wbad-function-cast.
11550 (xg_set_toolkit_scroll_bar_thumb): Use it.
11551 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11552 diagnostic from gcc -Wbad-function-cast.
11553 (get_utf8_string, xg_get_file_with_chooser):
11554 Rename locals to avoid shadowing.
11555 (create_dialog): Move locals to avoid shadowing.
11557 * xgselect.c (xg_select): Remove unused var.
11559 * image.c (four_corners_best): Mark locals as initialized.
11560 (gif_load): Initialize transparent_p to zero (Bug#8238).
11561 Mark another local as initialized.
11562 (my_png_error, my_error_exit): Mark with NO_RETURN.
11564 * image.c (clear_image_cache): Now static.
11565 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11566 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11567 (x_edge_detection): Remove unnecessary cast that
11568 gcc -Wbad-function-cast diagnoses.
11569 (gif_load): Fix pointer signedness.
11570 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11571 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11573 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11575 Improve quality of tests for time stamp overflow.
11576 For example, without this patch (encode-time 0 0 0 1 1
11577 1152921504606846976) returns the obviously-bogus value (-948597
11578 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11579 reports time overflow. See
11580 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11581 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11582 * editfns.c: Include limits.h and intprops.h.
11583 (TIME_T_MIN, TIME_T_MAX): New macros.
11584 (time_overflow): Move earlier, to before first use.
11585 (hi_time, lo_time): New functions, for an accurate test for
11586 out-of-range times.
11587 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11588 (Fget_internal_run_time): Don't assume time_t fits in int.
11589 (make_time): Use list2 instead of Fcons twice.
11590 (Fdecode_time): More accurate test for out-of-range times.
11591 (check_tm_member): New function.
11592 (Fencode_time): Use it, to test for out-of-range times.
11593 (lisp_time_argument): Don't rely on undefined left-shift and
11594 right-shift behavior when checking for time stamp overflow.
11596 * editfns.c (time_overflow): New function, refactoring common code.
11597 (Fformat_time_string, Fdecode_time, Fencode_time):
11598 (Fcurrent_time_string): Use it.
11600 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11601 * dired.c (make_time): Move to ...
11602 * editfns.c (make_time): ... here.
11603 * systime.h: Note the move.
11605 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11607 * fringe.c (update_window_fringes): Remove unused variables.
11609 * unexmacosx.c (copy_data_segment): Also copy __got section.
11612 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11614 * termcap.c [MSDOS]: Include "msdos.h".
11615 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11616 Constify `char *' arguments and their references according to
11617 prototypes in tparam.h.
11619 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11621 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11622 Adapt all references accordingly.
11624 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11626 2011-03-11 Tom Tromey <tromey@redhat.com>
11628 * buffer.c (syms_of_buffer): Remove obsolete comment.
11630 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11632 * termhooks.h (encode_terminal_code): Declare prototype.
11634 * msdos.c (encode_terminal_code): Don't declare prototype.
11636 * term.c (encode_terminal_code): Now external again, used by
11637 w32console.c and msdos.c.
11639 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11640 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11642 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11644 Fix some minor problems found by GCC 4.5.2's static checks.
11646 * fringe.c (update_window_fringes): Mark locals as initialized
11648 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11650 * alloc.c (mark_fringe_data): Move decl from here ...
11651 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11652 to check its interface.
11653 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11655 * fontset.c (free_realized_fontset): Now static.
11656 (Fset_fontset_font): Rename local to avoid shadowing.
11657 (fontset_font): Mark local as initialized.
11658 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11660 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11662 * xselect.c (x_disown_buffer_selections): Remove; not used.
11663 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11664 (x_own_selection, Fx_disown_selection_internal): Rename locals
11665 to avoid shadowing.
11666 (x_handle_dnd_message): Remove local to avoid shadowing.
11668 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11669 so that the caller can use some name other than gcpro1.
11670 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11671 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11672 (Fx_backspace_delete_keys_p):
11673 Use them to avoid shadowing, and rename vars to avoid shadowing.
11674 (x_decode_color, x_set_name, x_window): Now static.
11675 (Fx_create_frame): Add braces to silence GCC warning.
11676 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11677 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11678 Remove unused locals.
11679 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11680 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11681 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11684 * xterm.h (x_mouse_leave): New decl.
11686 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11687 Remove unused functions.
11688 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11689 (x_calc_absolute_position): Now static.
11690 (XTread_socket): Don't define label "out" unless it's used.
11691 Don't declare local "event" unless it's used.
11692 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11693 unless they are used.
11694 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11695 (x_fatal_error_signal): Remove; not used.
11696 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11697 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11698 (x_error_catcher, x_connection_closed, x_error_handler):
11699 (x_error_quitter, xembed_send_message, x_iconify_frame):
11700 (my_log_handler): Rename locals to avoid shadowing.
11701 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11702 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11704 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11705 Rename or move locals to avoid shadowing.
11706 (tty_defined_color, merge_face_heights): Now static.
11707 (free_realized_faces_for_fontset): Remove; not used.
11708 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11709 does not deduce is never used uninitialized.
11710 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11711 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11713 * terminal.c (store_terminal_param): Now static.
11715 * xmenu.c (menu_highlight_callback): Now static.
11716 (set_frame_menubar): Remove unused local.
11717 (xmenu_show): Rename parameter to avoid shadowing.
11718 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11719 since they might point to immutable storage.
11720 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11721 since it's unused otherwise.
11723 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11724 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11725 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11726 avoids a gcc -Wuninitialized diagnostic.
11727 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11728 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11729 does not deduce are never used uninitialized.
11731 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11733 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11734 * window.c (window_loop, size_window):
11735 (run_window_configuration_change_hook, enlarge_window): Likewise.
11737 * window.c (display_buffer): Now static.
11738 (size_window): Mark variables that gcc -Wuninitialized
11739 does not deduce are never used uninitialized.
11740 * window.h (check_all_windows): New decl, to forestall
11741 gcc -Wmissing-prototypes diagnostic.
11742 * dispextern.h (bidi_dump_cached_states): Likewise.
11744 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11746 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11747 Include <limits.h>.
11748 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11749 and to avoid gcc -Wuninitialized warning.
11750 (load_charset_map): Mark variables that gcc -Wuninitialized
11751 does not deduce are never used uninitialized.
11752 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11754 * coding.c (coding_set_source, coding_set_destination):
11755 Use "else { /* comment */ }" rather than "else /* comment */;"
11756 for clarity, and to avoid gcc -Wempty-body warning.
11757 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11758 a block, when the outer 'i' will do.
11759 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11760 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11761 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11762 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11763 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11764 Rename locals to avoid shadowing.
11765 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11766 * coding.c (emacs_mule_char, encode_invocation_designation):
11767 Now static, since they're not used elsewhere.
11768 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11769 (decode_coding_object, encode_coding_object, detect_coding_system):
11770 (decode_coding_emacs_mule): Mark variables that gcc
11771 -Wuninitialized does not deduce are never used uninitialized.
11772 (detect_coding_iso_2022): Initialize a local variable that might
11773 be used uninitialized. Leave a FIXME because it's not clear that
11774 this initialization is needed. (Bug#8211)
11775 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11776 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11777 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11778 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11779 Remove unused macros.
11781 * category.c (hash_get_category_set): Remove unused local var.
11782 (copy_category_table): Now static, since it's not used elsewhere.
11783 * character.c (string_count_byte8): Likewise.
11785 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11786 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11788 * chartab.c (copy_sub_char_table): Now static, since it's not used
11790 (sub_char_table_ref_and_range, char_table_ref_and_range):
11791 Rename locals to avoid shadowing.
11792 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11794 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11795 (BIDI_BOB): Remove unused macro.
11797 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11798 deduce are never used uninitialized.
11799 * term.c (encode_terminal_code): Likewise.
11801 * term.c (encode_terminal_code): Now static. Remove unused local.
11803 * tparam.h: New file.
11804 * term.c, tparam.h: Include it.
11805 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11806 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11807 Move these decls to tparam.h, and make them agree with what
11808 is actually in tparam.c. The previous trick of using incompatible
11809 decls in different modules does not conform to the C standard.
11810 All callers of tparam changed to use tparam's actual API.
11811 * tparam.c (tparam1, tparam, tgoto):
11812 Use const pointers where appropriate.
11814 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11815 * cm.h (struct cm): Likewise.
11816 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11817 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11818 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11819 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11820 (turn_on_face, init_tty): Likewise.
11821 * termchar.h (struct tty_display_info): Likewise.
11823 * term.c (term_mouse_position): Rename local to avoid shadowing.
11825 * alloc.c (mark_ttys): Move decl from here ...
11826 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11828 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11830 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11832 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11834 * search.c (compile_pattern_1): Remove argument regp, unused since
11835 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11836 (compile_pattern): Don't pass it.
11838 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11840 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11841 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11843 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11845 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11847 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11848 gdk_window_get_screen, gdk_window_get_geometry,
11849 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11850 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11851 (xg_get_pixbuf_from_pixmap): New function.
11852 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11853 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11854 Call xg_get_pixbuf_from_pixmap instead of
11855 gdk_pixbuf_get_from_drawable.
11856 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11857 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11858 (xg_check_special_colors): Use GtkStyleContext and its functions
11860 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11861 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11862 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11863 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11864 Call gtk_widget_get_preferred_size.
11865 (xg_frame_resized): gdk_window_get_geometry only takes 5
11867 (xg_win_to_widget, xg_event_is_for_menubar):
11868 Call gdk_x11_window_lookup_for_display.
11869 (xg_set_widget_bg): New function.
11870 (delete_cb): New function.
11871 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11872 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11873 (xg_set_background_color): Call xg_set_widget_bg.
11874 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11875 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11876 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11877 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11879 (update_frame_tool_bar): Call gtk_widget_hide.
11880 (xg_initialize): Use GDK_KEY_g.
11882 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11884 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11886 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11887 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11888 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11890 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11892 * w32xfns.c (select_palette): Check success of RealizePalette against
11893 GDI_ERROR, not zero.
11895 See ChangeLog.11 for earlier changes.
11897 ;; Local Variables:
11901 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11903 This file is part of GNU Emacs.
11905 GNU Emacs is free software: you can redistribute it and/or modify
11906 it under the terms of the GNU General Public License as published by
11907 the Free Software Foundation, either version 3 of the License, or
11908 (at your option) any later version.
11910 GNU Emacs is distributed in the hope that it will be useful,
11911 but WITHOUT ANY WARRANTY; without even the implied warranty of
11912 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11913 GNU General Public License for more details.
11915 You should have received a copy of the GNU General Public License
11916 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.