1 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3 Cleanup overlays checking.
4 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
5 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
7 (sort_overlays): Change to use OVERLAYP.
9 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
11 * editfns.c (Finsert_char): Make it interactive, and make the
12 second arg optional. Copy interactive spec and docstring from
15 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
17 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
18 Unlike the other wrapped functions, fabs has an unspecified
21 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
23 * nsterm.m (keyDown): Interpret flags without left/right bits
24 as the left key (Bug#11670).
26 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
28 Remove empty and useless init functions.
29 * lisp.h (init_character_once, init_fns, init_image)
30 (init_filelock, init_sound): Remove prototype.
31 * character.c (init_character_once): Remove.
32 * filelock.c (init_filelock): Likewise.
33 * fns.c (init_fns): Likewise.
34 * image.c (init_image): Likewise.
35 * sound.c (init_sound): Likewise.
36 * emacs.c (main): Adjust accordingly.
38 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
40 * gtkutil.h: Tiny cleanups.
41 (use_old_gtk_file_dialog): Remove useless declaration.
42 (xg_uses_old_file_dialog): Add suggested const attribute.
44 2012-07-15 Eli Zaretskii <eliz@gnu.org>
46 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
47 (bidi_paragraph_init): Use it to limit search forward for a strong
48 directional character in abnormally large paragraphs full of
49 neutral or weak characters. (Bug#11943)
51 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
53 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
54 the toolbar (Bug#9451).
55 (xg_make_tool_item): Give the widget event box a transparent
58 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
60 Cleanup basic allocation variables and functions.
61 * alloc.c (ignore_warnings, init_intervals, init_float)
62 (init_cons, init_symbol, init_marker): Remove.
63 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
64 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
65 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
66 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
67 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
68 (staticidx, init_alloc_once, init_strings, free_ablock):
69 Remove redundant initialization.
70 * fns.c (init_weak_hash_tables): Remove.
71 * lisp.h (init_weak_hash_tables): Remove prototype.
73 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
75 Use zero_vector where appropriate.
76 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
78 * lisp.h (zero_vector): New declaration.
79 * font.c (null_vector): Remove.
80 (syms_of_font): Remove initialization and staticpro.
81 (font_list_entities, font_find_for_lface): Change to use zero_vector.
82 * keymap.c (Faccessible_keymaps): Likewise.
84 2012-07-15 Leo Liu <sdl.web@gmail.com>
86 * fringe.c: Fix typo in comments.
88 2012-07-14 Leo Liu <sdl.web@gmail.com>
90 * fringe.c: Add a new bitmap exclamation-mark.
92 2012-07-14 Eli Zaretskii <eliz@gnu.org>
94 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
96 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
97 (HAVE_MENUS): Don't define, defined by editing config.in with
99 (GMALLOC_INHIBIT_VALLOC): Don't define.
100 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
102 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
104 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
106 2012-07-14 Glenn Morris <rgm@gnu.org>
108 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
109 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
110 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
112 2012-07-13 Glenn Morris <rgm@gnu.org>
114 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
116 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
117 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
119 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
121 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
122 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
123 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
124 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
126 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
127 as boolean expression.
128 (x_set_window_size): Remove unused variable toolbar.
129 (ns_get_color_default, ns_mod_to_lisp): Remove.
130 (ns_mouse_position): Remove unused variables xchar and ychar.
131 (ns_compute_glyph_string_overhangs): Remove unused variable face.
132 (ns_set_vertical_scroll_bar): Remove unused variable count.
133 (ns_delete_terminal): Remove unused variable i.
134 (ns_term_init): Remove unused variables r, g and b.
135 (mouseDown): Remove unused variable window.
136 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
137 (initFrameFromEmacs): Remove unused variable vbextra.
138 (mouseEntered): Remove unused variables p and dpyinfo.
139 (mouseExited): Remove unused variables p and r.
140 (ns_define_frame_cursor, ns_clear_frame_area)
141 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
142 (menuDown): Assign [sender tag] to variable and cast the variable.
144 * nsterm.h (menuDown): Add id as type to argument sender.
145 (ns_display_info_for_name): Add Lisp_Object argument.
146 (ns_term_init): Add Lisp_Object argument.
147 (ns_map_event_to_object): Add void argument.
148 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
149 prototype with arguments and only declare if __OBJC__.
150 (nxatoms_of_nsselect): Add void argument.
151 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
152 (ns_alloc_autorelease_pool): Add void argument.
153 (ns_release_autorelease_pool): Add void* argument.
154 (ns_get_defaults_value): Add const char* argument.
156 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
157 (initFromContents): Use SSDATA where appropriate.
158 (ns_update_menubar): Add braces to ambigous if-else.
159 (initWithTitle): Put () around assignment in if statement.
160 (ns_menu_show): Remove unused variables window and keymap.
161 (update_frame_tool_bar): Remove unused variable selected_p.
162 (initWithContentRect): Remove unused variable this_cmd_name.
164 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
166 (setXBMColor): Remove unused variable len.
167 (setPixmapData): Put () around assignment in loop statement.
169 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
170 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
172 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
173 around assignment in loop statement.
174 (nsfont_open): Remove unused variable i.
175 (nsfont_open): Remove unused variable len.
176 (nsfont_draw): Remove unused variable cs.
178 * nsfns.m (x_set_icon_name, ns_set_name_internal)
179 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
180 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
181 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
182 (Fns_font_name, Fns_perform_service)
183 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
184 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
185 (ns_set_name): Remove unused variable view.
186 (x_set_menu_bar_lines): Remove unused variable olines.
187 (x_set_tool_bar_lines): Remove unused variable root_window.
188 (Fns_list_colors): Put () around assignment in while statement.
189 (Fns_perform_service): Remove unused variable len.
190 (Fns_display_usable_bounds): Remove unused variable top.
191 (syms_of_nsfns): Remove unused variable i.
193 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
196 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
198 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
199 and free it with DestroyExceptionInfo (Bug#11558).
201 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
203 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
204 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
205 Set here, not in nt/config.nt.
207 2012-07-13 Eli Zaretskii <eliz@gnu.org>
209 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
210 cursor overflow into the last glyph on display line when the right
211 fringe is off. (Bug#11832)
213 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
215 * xdisp.c (produce_special_glyphs): Now static.
216 * dispextern.h (produce_special_glyphs): Remove decl.
218 2012-07-13 Glenn Morris <rgm@gnu.org>
220 * s/bsd-common, s/cygwin.h: Remove empty files.
221 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
223 * s/usg5-4-common.h (USG, USG5):
224 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
225 * s/sol2-6.h (SOLARIS2):
226 * s/irix6-5.h (IRIX6_5):
227 * s/hpux10-20.h (USG, USG5, HPUX):
228 * s/gnu-linux.h (USG, GNU_LINUX):
229 * s/freebsd.h (BSD_SYSTEM):
230 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
231 * s/cygwin.h (CYGWIN):
232 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
233 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
235 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
237 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
239 2012-07-13 Glenn Morris <rgm@gnu.org>
241 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
243 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
245 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
246 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
248 2012-07-12 Glenn Morris <rgm@gnu.org>
250 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
252 * process.c (init_process_emacs): Rename from init_process.
253 The old name is also the name of a Mach system call.
254 * lisp.h, emacs.c: Update for this name change.
255 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
258 2012-07-12 Eli Zaretskii <eliz@gnu.org>
260 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
261 memmove call that removes glyphs covered by the left truncation
262 glyph. Improve commentary.
263 (display_line): Fix display of continuation glyphs on GUI frames
264 when the right fringe is turned off and variable-size fonts are
265 used in the window. Move the code that appends a stretch glyph to
266 produce_special_glyphs, so that it could be used for truncation
267 and continuation glyphs alike.
268 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
269 glyph of a suitably computed width, to align the special glyphs at
270 the window margin. Code moved from display_line. (Bug#11832)
272 2012-07-12 Glenn Morris <rgm@gnu.org>
274 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
276 * s/gnu-linux.h, s/hpux10-20.h:
277 Do not unconditionally define HAVE_XRMSETDATABASE.
279 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
281 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
283 Fix typos that broke OS X build.
284 Reported by Randal L. Schwartz in
285 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
286 * nsterm.m (ns_timeout): Add missing local decl.
287 (ns_get_color): snprintf -> sprintf, to fix typo.
289 2012-07-12 Glenn Morris <rgm@gnu.org>
291 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
292 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
293 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
294 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
296 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
297 Move PTY_OPEN to configure.
299 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
300 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
301 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
303 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
305 Use empty_unibyte_string where applicable.
306 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
307 * lread.c (read1): Likewise.
308 * xsettings.c (syms_of_xsettings): Likewise.
310 2012-07-12 Glenn Morris <rgm@gnu.org>
312 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
313 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
314 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
315 * s/hpux10-20.h (RUN_TIME_REMAP):
316 * s/bsd-common.h (TABDLY): Move to configure.
318 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
320 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
322 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
323 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
325 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
327 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
328 * s/template.h: Move NARROWPROTO to configure.
330 2012-07-11 Glenn Morris <rgm@gnu.org>
332 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
333 unused since 2011-01-17 change to systty.h.
335 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
336 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
337 Move HAVE_PTYS and HAVE_SOCKETS to configure.
339 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
341 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
343 2012-07-11 Glenn Morris <rgm@gnu.org>
345 * s/darwin.h, s/gnu-linux.h, s/template.h:
346 Move INTERRUPT_INPUT to configure.
348 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
350 Minor adjustments to interning code.
351 * lisp.h (intern, intern_c_string): Redefine as static inline
352 wrappers for intern_1 and intern_c_string_1, respectively.
353 (intern_1, intern_c_string_1): Rename prototypes.
354 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
356 * font.c (font_intern_prop): Likewise. Adjust comment.
357 * w32font.c (intern_font_name): Likewise.
359 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
361 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
363 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
364 of Fcar/Fcdr if possible.
365 * font.c (check_otf_features): Likewise.
366 * fontset.c (Fnew_fontset): Likewise.
367 * gnutls.c (Fgnutls_boot): Likewise.
368 * minibuf.c (read_minibuf): Likewise.
369 * msdos.c (IT_set_frame_parameters): Likewise.
370 * xmenu.c (Fx_popup_dialog): Likewise.
371 * w32menu.c (Fx_popup_dialog): Likewise.
373 2012-07-11 Glenn Morris <rgm@gnu.org>
375 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
376 since nothing has defined it on these platforms.
378 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
379 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
381 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
382 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
383 Move CLASH_DETECTION to configure.
385 * s/gnu.h: Remove file, which is now empty.
387 * s/gnu.h, s/gnu-linux.h:
388 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
390 2012-07-11 John Wiegley <johnw@newartisans.com>
392 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
393 function attribute, so we only use it if it exists in the
396 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
398 Avoid call to strlen in fast_c_string_match_ignore_case.
399 * search.c (fast_c_string_match_ignore_case): Change to use
400 length argument. Adjust users accordingly.
401 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
403 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
406 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
407 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
410 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
413 * s/hpux10-20.h (HAVE_PERROR): Remove.
414 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
415 Remove dummy definition, as this problem was obsolete long ago.
418 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
420 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
422 Avoid calls to strlen in font processing functions.
423 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
424 (font_open_by_name): Change to use length argument. Adjust
426 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
428 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
429 Change to return ptrdiff_t.
430 (xfont_list_pattern, xfont_match): Use length returned by
431 xfont_decode_coding_xlfd.
432 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
434 2012-07-11 Glenn Morris <rgm@gnu.org>
436 * s/darwin.h, s/freebsd.h, s/netbsd.h:
437 Move DONT_REOPEN_PTY to configure.
439 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
440 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
442 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
444 Remove "#define unix" that is no longer needed (Bug#11905).
445 * s/aix4-2.h (unix): Remove; no longer needed.
447 EMACS_TIME simplification (Bug#11875).
448 This replaces macros (which typically do not work in GDB)
449 with functions, typedefs and enums, making the code easier to debug.
450 The functional style also makes code easier to read and maintain.
451 * systime.h: Include <sys/time.h> on all hosts, not just if
452 WINDOWSNT, since 'struct timeval' is needed in general.
453 (EMACS_TIME): Now a typedef, not a macro.
454 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
456 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
457 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
458 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
459 (EMACS_TIME_LE): Now functions, not macros.
460 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
461 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
462 which are not functions. All uses rewritten to use:
463 (make_emacs_time): New function.
464 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
465 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
466 not functions. All uses rewritten to use the following, respectively:
467 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
468 (add_emacs_time, sub_emacs_time): New functions.
469 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
470 * fileio.c (Fcopy_file):
471 * xterm.c (XTflash): Get the current time closer to when it's used.
472 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
474 * bytecode.c (targets): Suppress -Woverride-init warnings.
476 Simplify by avoiding confusing use of strncpy etc.
477 * doc.c (Fsnarf_documentation):
478 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
479 * frame.c (Fmake_terminal_frame):
480 * gtkutil.c (get_utf8_string):
482 * nsmenu.m (ns_update_menubar):
483 * regex.c (regerror):
484 Prefer memcpy to strncpy and strncat when either will do.
485 * fileio.c (Fsubstitute_in_file_name):
486 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
487 (menu_separator_name_p):
488 * nsmenu.m (ns_update_menubar):
489 Prefer memcmp to strncmp when either will do.
490 * nsterm.m: Include <ftoastr.h>.
492 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
493 Prefer snprintf to strncpy.
494 * nsterm.m (ns_term_init):
495 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
496 * nsterm.m (ns_term_init):
497 Avoid the need for strncpy, by using build_string or
498 make_unibyte_string directly. Use dtoastr, not snprintf.
499 * process.c (Fmake_network_process): Diagnose service names that
500 are too long, rather than silently truncating them or creating
501 non-null-terminated names.
502 (Fnetwork_interface_info): Likewise, for interface names.
503 * sysdep.c (system_process_attributes) [GNU_LINUX]:
504 Prefer sprintf to strncat.
505 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
506 Prefer vsnprintf to vsprintf + strncpy.
508 2012-07-10 Glenn Morris <rgm@gnu.org>
510 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
511 Clarify fallback case.
513 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
515 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
516 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
517 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
518 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
519 where argument type is known to be a Lisp_Cons.
521 2012-07-10 Tom Tromey <tromey@redhat.com>
523 * bytecode.c (BYTE_CODE_THREADED): New macro.
524 (BYTE_CODES): New macro. Replaces all old byte-code defines.
525 (enum byte_code_op): New type.
526 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
527 (exec_byte_code): Use them. Use token threading when applicable.
529 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
531 Optimize pure C strings initialization.
532 * lisp.h (make_pure_string): Fix prototype.
533 (build_pure_c_string): New function, defined as static inline. This
534 provides a better opportunity to optimize away calls to strlen when
535 the function is called with compile-time constant argument.
536 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
537 argument, adjust users accordingly. Use build_pure_c_string where
539 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
540 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
541 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
543 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
545 Avoid calls to strlen in miscellaneous functions.
546 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
547 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
548 * lread.c (openp): Likewise.
550 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
552 Avoid calls to strlen in path processing functions.
553 * fileio.c (file_name_as_directory): Add comment. Change to add
554 srclen argument and return the length of result. Adjust users
556 (directory_file_name): Fix comment. Change to add srclen argument,
557 swap 1st and 2nd arguments to obey the common convention. Adjust
559 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
561 2012-07-10 Glenn Morris <rgm@gnu.org>
563 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
564 Move PENDING_OUTPUT_COUNT definition to configure.
566 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
567 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
568 * s/gnu.h (DATA_START): Move definitions to configure.
570 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
571 We include usg5-4-common.h, which defines them both.
573 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
574 O_RDONLY already includes it).
576 Stop ns builds setting the EMACSLOADPATH environment variable.
577 * nsterm.m (ns_load_path): Rename from ns_init_paths.
578 Now it does not set EMACSLOADPATH, just returns the load-path string.
579 * nsterm.h: Update accordingly.
580 * lread.c [HAVE_NS]: Include nsterm.h.
581 (init_lread) [HAVE_NS]: Use ns_load_path.
582 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
584 2012-07-09 Glenn Morris <rgm@gnu.org>
586 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
587 since the included bsd-common.h does so.
589 Stop ns builds setting the EMACSPATH environment variable.
590 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
591 (ns_init_paths): Do not set EMACSPATH.
592 * nsterm.h (ns_exec_path): Add it.
593 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
596 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
598 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
600 * process.c (wait_reading_process_output): 'waitchannels' was unset
601 when read_kbd || !NILP (wait_for_cell); fix this.
603 Add GCC-style 'const' attribute to functions that can use it.
604 * character.h (char_resolve_modifier_mask):
605 * keyboard.h (make_ctrl_char):
606 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
607 (init_character_once, next_almost_prime, init_fns, init_image)
608 (flush_pending_output, init_sound):
609 * mem-limits.h (start_of_data):
610 * menu.h (finish_menu_items):
612 * emacs.c (DEFINE_DUMMY_FUNCTION):
613 Declare the dummy function with ATTRIBUTE_CONST.
614 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
615 Add decls with ATTRIBUTE_CONST.
617 Minor improvements to make_formatted_string.
618 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
619 where int is good enough, as vsprintf returns an int.
620 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
622 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
624 Use make_formatted_string to avoid double length calculation.
625 * lisp.h (make_formatted_string): New prototype.
626 * alloc.c (make_formatted_string): New function.
627 * buffer.c (Fgenerate_new_buffer_name): Use it.
628 * dbus.c (syms_of_dbusbind): Likewise.
629 * editfns.c (Fcurrent_time_zone): Likewise.
630 * filelock.c (get_boot_time): Likewise.
631 * frame.c (make_terminal_frame, set_term_frame_name)
632 (x_report_frame_params): Likewise.
633 * image.c (gs_load): Likewise.
634 * minibuf.c (get_minibuffer): Likewise.
635 * msdos.c (dos_set_window_size): Likewise.
636 * process.c (make_process): Likewise.
637 * xdisp.c (ensure_echo_area_buffers): Likewise.
638 * xsettings.c (apply_xft_settings): Likewise.
640 2012-07-09 Glenn Morris <rgm@gnu.org>
642 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
643 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
644 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
645 * nsterm.h (ns_etc_directory): Add it.
646 * callproc.c [HAVE_NS]: Include nsterm.h.
647 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
649 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
651 Move marker debugging code under MARKER_DEBUG.
652 * marker.c (MARKER_DEBUG): Move marker debugging code under
653 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
654 for bootstrap with --enable-checking (~3x slowdown reported
655 by Juanma Barranquero <lekktu@gmail.com>).
656 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
658 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
660 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
661 See <http://bugs.gnu.org/11825#29>.
663 2012-07-08 Eli Zaretskii <eliz@gnu.org>
665 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
666 has no font, use the frame's font. (Bug#11813)
667 (display_line): Add commentary about displaying truncation glyphs
669 (produce_special_glyphs): Move here from term.c.
671 * term.c (produce_special_glyphs): Move to xdisp.c.
673 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
676 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
678 * xdisp.c (display_line): Avoid warning about implicit declaration
681 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
683 * lisp.h: Remove empty conditional.
685 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
687 * lread.c (load_path_check): Now static.
689 Fix some minor --with-ns problems found by static checking.
690 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
691 (x_set_font) [!HAVE_X_WINDOWS]:
692 * image.c (xpm_load_image) [HAVE_NS]:
693 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
694 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
696 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
697 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
698 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
699 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
700 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
701 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
702 Fix pointer signedness problem.
703 * xfaces.c (FRAME_X_FONT_TABLE):
704 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
706 2012-07-07 Glenn Morris <rgm@gnu.org>
708 * lread.c (load_path_check): New function, split from init_lread.
709 (init_lread): Reorganize. Motivation:
710 If EMACSLOADPATH is set, check/warn about that rather than the
711 defaults, which we are not going to use. Hence we can remove
712 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
713 Don't warn if site-lisp directories are missing.
714 If not installed, start from a blank load-path, since
715 PATH_LOADSEARCH refers to the eventual installation directories.
717 2012-07-07 Eli Zaretskii <eliz@gnu.org>
719 Support truncation and continuation glyphs on GUI frames, when
720 fringes are disabled. (Bug#11832)
721 * xdisp.c (init_iterator): Get dimensions of truncation and
722 continuation glyphs even if on GUI frames. Adjust
723 it->last_visible_x on GUI frames when the left or right fringes,
725 (start_display, move_it_in_display_line_to): Handle the case of a
726 GUI frame without a fringe to display continuation or truncation
728 (insert_left_trunc_glyphs): Support GUI frames: make sure
729 truncation glyphs overwrite enough glyphs from the current line to
730 have sufficient space in pixels.
731 (display_line): Support truncation and continuation glyphs on GUI
732 frames. If some spare pixels are left on the line after inserting
733 the truncation glyphs, fill that space with a stretch glyph of a
734 suitably computed width.
736 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
737 produce_glyphs, to support GUI sessions.
739 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
741 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
743 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
745 Do not require float-time's arg to fit in time_t (Bug#11825).
746 This works better on hosts where time_t is unsigned, and where
747 float-time is applied to the (negative) difference between two times.
748 * editfns.c (decode_time_components): Last arg is now double *,
749 not int *, and means to store all the result as a double, without
750 worrying about whether the seconds part fits in time_t.
752 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
754 (Ffloat_time): Do not fail merely because the specified time falls
755 outside of time_t range.
757 2012-07-07 Glenn Morris <rgm@gnu.org>
759 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
760 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
761 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
763 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
765 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
768 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
770 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
772 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
773 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
774 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
775 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
776 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
777 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
779 * xfont.c (compare_font_names): Redo to omit the need for casts.
781 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
783 * xfns.c (Fx_change_window_property): Doc fix.
784 * w32fns.c (Fx_change_window_property): Doc fix.
786 * w32fns.c (Fx_window_property): Accept the same arguments as the
787 X Windows version. Doc fix.
788 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
790 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
791 Eli Zaretskii <eliz@gnu.org>
793 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
794 Windows-specific code from nt/config.nt moved here.
795 Obsolete settings removed.
797 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
799 * process.c: Avoid unnecessary calls to gettime.
800 (wait_reading_process_output): Don't get the time of day
801 when gobbling data immediately and not waiting, as there's no need
802 for it in that case. This removes a FIXME.
804 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
806 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
807 is defined (Bug#11768).
809 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
811 Fix marker debugging code.
812 * marker.c (byte_char_debug_check): Do not perform the check
813 if buffer is not multibyte.
814 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
815 Call byte_char_debug_check with correct arguments.
817 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
819 Compile marker debugging code only if ENABLE_CHECKING is defined.
820 * marker.c (byte_char_debug_check, count_markers):
821 Use only if ENABLE_CHECKING is defined.
822 (byte_debug_flag): Remove.
823 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
824 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
826 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
828 Avoid code repetition in marker-related functions.
829 * marker.c (attach_marker): New function.
830 (Fset_marker, set_marker_restricted, set_marker_both)
831 (set_marker_restricted_both): Use it.
832 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
833 Consistently rename charno to charpos.
834 (marker_position): Add eassert.
835 (marker_byte_position): Convert to eassert.
837 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
839 Simplify list operations in unchain_overlay and unchain_marker.
840 * buffer.c (unchain_overlay): Simplify. Add comment.
841 * marker.c (unchain_marker): Simplify. Fix comments.
843 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
845 Introduce fast path for the widely used marker operation.
846 * alloc.c (build_marker): New function.
847 * lisp.h (build_marker): New prototype.
848 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
849 * composite.c (autocmp_chars): Likewise.
850 * editfns.c (buildmark): Remove.
851 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
852 (save_restriction_save): Use build_marker.
853 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
854 * window.c (save_window_save): Likewise.
856 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
858 Do not use Fdelete_overlay in delete_all_overlays
859 to avoid redundant calls to unchain_overlay.
860 * buffer.c (drop_overlay): New function.
861 (delete_all_overlays, Fdelete_overlay): Use it.
862 * minibuf.c (get_minibuffer): Fix comment.
864 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
866 Port to OpenBSD 5.1 amd64.
867 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
868 This is needed for OpenBSD, and should be harmless on all BSD systems.
869 Also, include <sys/sysctl.h>, as it should be available on all
870 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
871 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
872 use p_pid member, not kp_proc.pid.
874 2012-07-06 Glenn Morris <rgm@gnu.org>
876 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
878 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
880 More xmalloc and related cleanup.
881 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
882 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
883 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
884 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
885 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
886 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
887 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
888 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
889 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
891 Omit needless casts involving void * pointers and allocation.
892 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
893 as the former is more robust if P's type is changed.
894 Prefer xzalloc to xmalloc + memset 0.
895 Simplify malloc-or-realloc to realloc.
896 Don't worry about xmalloc returning a null pointer.
897 Prefer xstrdup to xmalloc + strcpy.
898 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
900 * keyboard.c (apply_modifiers_uncached): Prefer local array to
901 alloca of a constant.
903 2012-07-05 Eli Zaretskii <eliz@gnu.org>
905 * xdisp.c (display_line): Fix horizontal pixel coordinates when
906 hscroll is larger than the line width. Fixes long and futile
907 looping inside extend_face_to_end_of_line (on a TTY) producing
908 glyphs that are not needed and thrown away.
910 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
912 * marker.c (set_marker_restricted_both): Simplify by using
915 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
917 * editfns.c (region_limit): Simplify by using clip_to_bounds.
919 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
921 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
922 not defined (Bug#11768).
923 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
924 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
925 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
926 followed by gtk_box_set_homogeneous (Bug#11768).
927 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
928 (update_theme_scrollbar_width, xg_create_scroll_bar):
929 Use gtk_scrollbar_new (Bug#11768).
930 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
931 (is_box_type): New function (Bug#11768).
932 (xg_tool_item_stale_p): Call is_box_type.
933 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
934 with default display (Bug#11768).
936 2012-07-05 Eli Zaretskii <eliz@gnu.org>
938 * xdisp.c (window_hscroll_limited): New function.
939 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
940 coordinates when window's hscroll is set to insanely large
943 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
945 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
946 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
948 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
951 * lisp.h (xzalloc): New prototype. Omit needless casts.
952 * alloc.c (xzalloc): New function. Omit needless casts.
953 * charset.c: Omit needless casts. Convert all calls to
954 xmalloc with following memset to xzalloc.
955 * dispnew.c: Likewise.
956 * fringe.c: Likewise.
960 * w32fns.c: Likewise.
961 * w32font.c: Likewise.
962 * w32term.c: Likewise.
963 * xfaces.c: Likewise.
966 * atimer.c: Omit needless casts.
967 * buffer.c: Likewise.
968 * callproc.c: Likewise.
970 * coding.c: Likewise.
971 * composite.c: Likewise.
973 * doprnt.c: Likewise.
974 * editfns.c: Likewise.
977 * filelock.c: Likewise.
979 * gtkutil.c: Likewise.
980 * keyboard.c: Likewise.
983 * minibuf.c: Likewise.
986 * process.c: Likewise.
987 * region-cache.c: Likewise.
988 * search.c: Likewise.
989 * sysdep.c: Likewise.
990 * termcap.c: Likewise.
991 * terminal.c: Likewise.
992 * tparam.c: Likewise.
993 * w16select.c: Likewise.
995 * w32reg.c: Likewise.
996 * w32select.c: Likewise.
997 * w32uniscribe.c: Likewise.
998 * widget.c: Likewise.
1000 * xmenu.c: Likewise.
1002 * xselect.c: Likewise.
1004 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1006 * fileio.c (time_error_value): Check the right error number.
1007 Problem reported by Troels Nielsen in
1008 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1010 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1012 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1013 This should be fixed in a better way; see Eli Zaretskii in
1014 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1015 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1017 * fileio.c (time_error_value): Rename from special_mtime.
1018 The old name's problems were noted by Eli Zaretskii in
1019 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1021 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1022 This variable's comment says Emacs needs at least one GDB-visible
1023 symbol of type enum pvec_type, to work around GDB problems.
1024 The symbol's value doesn't matter.
1026 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1027 that causes compilation to fail on pre-C99 compilers.
1029 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1031 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1032 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1034 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1036 * buffer.c (init_buffer_once): Fix initialization of
1037 headers for buffer_defaults and buffer_local_symbols.
1038 Reported by Juanma Barranquero <lekktu@gmail.com>.
1040 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1042 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1043 * lisp.h (enum pvec_type): Use fewer bits.
1044 (PSEUDOVECTOR_SIZE_BITS): New constant.
1045 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1046 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1047 change in pvec_type.
1048 (PSEUDOVECTOR_TYPEP): New macro.
1049 (TYPED_PSEUDOVECTORP): Use it.
1050 * fns.c (internal_equal): Adapt code to extract pvectype.
1051 * emacs.c (gdb_pvec_type): Update type.
1052 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1053 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1054 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1055 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1056 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1057 abusing vector->header.next.nbytes.
1058 (live_vector_p): Use PVEC_TYPE.
1059 (mark_object): Adapt code to extract pvectype. Use switch.
1061 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1063 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1064 Tighten new eassert a bit.
1066 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1068 Fix compilation with --enable-gcc-warnings and -O1
1070 * doprnt.c (doprnt): Change type of tem to int, initialize
1071 to avoid compiler warning. Add eassert.
1072 * search.c (simple_search): Initialize match_byte to avoid
1073 compiler warning. Add eassert.
1075 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1077 Avoid weird behavior with large horizontal scrolls.
1078 Without this change, for example, large hscroll values would
1079 mess up Emacs's display on Fedora 15 x86, presumably due to
1080 overflows in int calculations in the display code.
1081 Also, if buffers had long lines, Emacs would freeze.
1082 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1083 (set_window_hscroll): New function, containing the old guts of
1084 Fset_window_hscroll. Return the clipped value.
1085 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1086 This avoids the need to check against PTRDIFF_MAX.
1088 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1090 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1092 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1094 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1096 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1097 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1098 since GCC 4.4.6 issues a bogus warning for them.
1100 Fix bugs in file timestamp newness comparisons.
1101 * fileio.c (Ffile_newer_than_file_p):
1102 * lread.c (Fload): Use full timestamp resolution of files,
1103 not just the 1-second resolution, so that files that are only
1104 slightly newer still count as newer.
1105 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1106 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1108 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1110 * fileio.c: Improve handling of file time marker. (Bug#11852)
1111 (special_mtime): New function.
1112 (Finsert_file_contents, Fverify_visited_file_modtime):
1113 Use it to set special mtime values consistently.
1115 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1117 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1118 marker for non-existing file. (Bug#11852)
1120 2012-07-03 Glenn Morris <rgm@gnu.org>
1122 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1123 and did not make it into globals.h).
1125 2012-07-03 Tom Tromey <tromey@redhat.com>
1127 * window.c (Fset_window_margins, Fset_window_fringes)
1128 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1129 * textprop.c (Fprevious_property_change): No longer static.
1130 * syntax.c (Fsyntax_table_p): No longer static.
1131 * process.c (Fget_process, Fprocess_datagram_address): No longer
1133 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1134 * keyboard.c (Fcommand_execute): No longer static.
1136 * insdel.c (Fcombine_after_change_execute): No longer static.
1137 * image.c (Finit_image_library): No longer static.
1138 * fileio.c (Fmake_symbolic_link): No longer static.
1139 * eval.c (Ffetch_bytecode): No longer static.
1140 * editfns.c (Fuser_full_name): No longer static.
1141 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1143 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1145 * dired.c (Ffile_attributes): No longer static.
1146 * composite.c (Fcomposition_get_gstring): No longer static.
1147 * callproc.c (Fgetenv_internal): No longer static.
1149 * ccl.h: Remove EXFUNs.
1150 * buffer.h: Remove EXFUNs.
1151 * dispextern.h: Remove EXFUNs.
1152 * intervals.h: Remove EXFUNs.
1153 * fontset.h: Remove EXFUN.
1154 * font.h: Remove EXFUNs.
1155 * dosfns.c (system_process_attributes): Remove EXFUN.
1156 * keymap.h: Remove EXFUNs.
1157 * lisp.h: Remove EXFUNs.
1158 * w32term.h: Remove EXFUNs.
1159 * window.h: Remove EXFUNs.
1160 * xsettings.h: Remove EXFUN.
1161 * xterm.h: Remove EXFUN.
1163 2012-07-03 Glenn Morris <rgm@gnu.org>
1165 * lisp.h (Frandom): Make it visible to C.
1166 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1167 buffer for invisible buffers. (Bug#1229)
1169 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1171 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1172 values which aren't power of 2.
1173 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1174 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1177 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1179 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1181 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1183 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1185 * alloc.c (allocate_vector_block): Remove redundant
1186 calls to mallopt if DOUG_LEA_MALLOC is defined.
1187 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1188 avoid calls to mallopt if zero_vector is returned.
1190 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1192 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1193 is enabled, avoid dereferencing NULL current_sblock if
1196 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1198 Cleanup basic buffer management.
1199 * buffer.h (struct buffer): Change layout to use generic vector
1200 marking code. Fix some comments. Change type of 'clip_changed'
1201 to bitfield. Remove unused #ifndef old.
1202 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1203 (GET_OVERLAYS_AT): Fix indentation.
1204 (for_each_per_buffer_object_at): New macro.
1205 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1206 (Fbuffer_local_variables): Use it.
1207 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1208 * alloc.c (allocate_buffer): Adjust to match new layout of
1209 struct buffer. Fix comment.
1210 (mark_overlay): New function.
1211 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1212 Lisp area of struct buffer.
1213 (mark_object): Use it. Adjust marking of misc objects
1214 and related comments.
1216 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1218 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1219 wrapper that is not needed because the wrapped code is a no-op (zero
1220 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1221 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1223 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1225 * alloc.c (mark_buffer): Simplify. Remove prototype.
1226 (mark_object): Add comment. Reorganize marking of vector-like
1227 objects. Use CHECK_LIVE for all vector-like objects except buffers
1228 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1229 redundant calls to mark_vectorlike for bool vectors.
1231 2012-06-30 Glenn Morris <rgm@gnu.org>
1233 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1235 * epaths.in (PATH_SITELOADSEARCH): New.
1236 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1237 This is rather than relying on --enable-locallisppath elements
1238 having "site-lisp" in their names. (Bug#10208#25, 11658)
1240 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1242 * w32proc.c (sys_select): Accept and ignore one more argument.
1244 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1246 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1247 (pselect) [!MS_DOS]: Redirect to sys_select.
1249 * sysdep.c: Don't include dos.h and dosfns.h.
1251 * process.c (sys_select):
1252 * msdos.c (sys_select): Accept one more argument and ignore it.
1254 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1255 adapt data types and code to that.
1258 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1259 which clashes with the gnulib function of the same name.
1261 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1263 * font.c (font_style_to_value, font_style_symbolic)
1264 (font_prop_validate_style): Add type checks for values in
1267 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1269 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1272 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1274 * xdisp.c (try_window_id): Undo last change.
1276 * w32.c (getwd): Adjust commentary about startup_dir.
1277 (init_environment): Always call sys_access, even in non-MSVC
1278 builds. Don't chdir to the directory of the Emacs executable.
1279 This undoes code from 1997 which was justified by the need to
1280 "avoid conflicts when removing and renaming directories". But its
1281 downside was that every relative file name was being interpreted
1282 relative to the directory of the Emacs executable, which can never
1283 be TRT. In particular, it broke sys_access when called with
1284 relative file names.
1285 (sys_access): Map GetLastError to errno.
1287 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1289 * window.h (struct window): Change type of 'fringes_outside_margins'
1290 to bitfield. Fix comment. Adjust users accordingly.
1291 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1293 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1296 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1298 * gnutls.c (emacs_gnutls_handshake):
1299 Add QUIT to make the loop interruptible.
1301 2012-06-29 Glenn Morris <rgm@gnu.org>
1303 * charset.c (init_charset): Make lack of etc/charsets fatal.
1305 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1307 * editfns.c (region_limit): Fix type mismatch.
1309 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1311 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1312 undefined. Convert from xassert to eassert.
1313 * nsmenu.m: Convert from xassert to eassert.
1314 * nsterm.m: Likewise.
1316 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1318 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1320 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1322 Avoid integer overflow on scroll-left and scroll-right.
1323 * window.c (HSCROLL_MAX): New macro.
1324 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1325 overflow when requested scroll falls outside ptrdiff_t range.
1327 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1329 * window.h (struct window): Change type of 'hscroll',
1330 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1331 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1332 Adjust users accordingly.
1333 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1334 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1335 from EMACS_INT to ptrdiff_t.
1336 (make_window): Omit redundant initialization.
1338 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1340 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1342 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1344 * window.h (struct window): Change type of 'use_time' and
1345 'sequence_number' from Lisp_Object to int.
1346 * frame.c (make_frame): Adjust users accordingly.
1347 * print.c (print_object): Likewise.
1348 * window.c (select_window, Fwindow_use_time, make_parent_window)
1349 (make_window): Likewise.
1351 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1353 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1354 enabled with --enable-checking=[all,glyphs] configure option.
1355 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1356 adjust comments accordingly.
1357 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1358 undefined, adjust comments accordingly.
1359 * image.c: Likewise.
1360 * scroll.c: Likewise.
1361 * w32fns.c: Likewise.
1362 * w32term.c: Likewise.
1363 * xdisp.c: Likewise.
1364 * xfaces.c: Likewise.
1366 * xterm.c: Likewise.
1368 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1370 Generalize run-time debugging checks.
1371 * dispextern.h (XASSERTS): Remove.
1372 * fontset.c (xassert): Remove.
1373 Convert from xassert to eassert.
1374 * alloc.c: Convert from xassert to eassert.
1376 * dispnew.c: Likewise.
1378 * fringe.c: Likewise.
1379 * ftfont.c: Likewise.
1380 * gtkutil.c: Likewise.
1381 * image.c: Likewise.
1382 * keyboard.c: Likewise.
1384 * process.c: Likewise.
1385 * scroll.c: Likewise.
1386 * sound.c: Likewise.
1388 * w32console.c: Likewise.
1389 * w32fns.c: Likewise.
1390 * w32term.c: Likewise.
1391 * window.c: Likewise.
1392 * xdisp.c: Likewise.
1393 * xfaces.c: Likewise.
1395 * xselect.c: Likewise.
1396 * xterm.c: Likewise.
1398 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1400 * fns.c (maybe_resize_hash_table): Output message when growing the
1403 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1405 * alloc.c (allocate_string_data): Remove dead code.
1406 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1407 avoid GCC warning about unused macro.
1409 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1411 * alloc.c (allocate_string): Omit intervals initialization.
1412 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1413 as in make_pure_string and make_pure_c_string.
1415 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1417 * alloc.c (allocate_string): Fix last change.
1419 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1421 * alloc.c (allocate_string): Remove two redundant calls
1422 to memset, add explicit initialization where appropriate.
1424 2012-06-27 Glenn Morris <rgm@gnu.org>
1426 * lisp.mk (lisp): Remove paths.elc.
1428 2012-06-27 Chong Yidong <cyd@gnu.org>
1430 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1432 2012-06-26 John Wiegley <johnw@newartisans.com>
1434 * unexmacosx.c (copy_data_segment): Add two section names used
1435 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1437 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1438 when building with Clang.
1440 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1442 * eval.c (Fapply): Allow calling it with a single argument.
1444 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1446 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1447 _stricmp and _strnicmp.
1448 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1450 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1452 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1454 (allocate_process): Likewise for new process.
1455 (allocate_terminal): Change to use offsetof.
1456 (allocate_frame): Likewise.
1457 * frame.c (make_frame): Omit redundant initialization.
1458 * window.c (make_parent_window): Use memset.
1459 (make_window): Omit redundant initialization.
1460 * process.c (make_process): Omit redundant initialization.
1461 * terminal.c (create_terminal): Likewise.
1463 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1465 * term.c (delete_tty): Remove redundant call to memset.
1467 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1469 * alloc.c: Remove build_string.
1470 * lisp.h: Define build_string as static inline. This provides
1471 a better opportunity to optimize away calls to strlen when the
1472 function is called with compile-time constant argument.
1473 * image.c (imagemagick_error): Convert to build_string.
1474 * w32proc.c (sys_spawnve): Likewise.
1475 * xterm.c (x_term_init): Likewise.
1477 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1479 Use sprintf return value instead of invoking strlen on result.
1480 In the old days this wasn't portable, since some sprintf
1481 implementations returned char *. But they died out years ago and
1482 Emacs already assumes sprintf returns int.
1483 Similarly for float_to_string.
1484 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1485 * ccl.c (ccl_driver):
1486 * character.c (string_escape_byte8):
1487 * data.c (Fnumber_to_string):
1488 * doprnt.c (doprnt):
1489 * print.c (print_object):
1490 * xdisp.c (message_dolog):
1491 * xfns.c (syms_of_xfns):
1492 Use sprintf or float_to_string result to avoid need to call strlen.
1493 * data.c (Fnumber_to_string):
1494 Use make_unibyte_string, since the string must be ASCII.
1495 * lisp.h, print.c (float_to_string): Now returns int length.
1496 * term.c (produce_glyphless_glyph):
1497 Use sprintf result rather than recomputing it.
1499 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1500 * Makefile.in (ALL_CFLAGS):
1501 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1502 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1504 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1506 * dispextern.h (xstrcasecmp): Define to library function
1507 strcasecmp if available.
1508 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1510 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1512 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1513 Avoid comma operator.
1514 * menu.c (push_submenu_start, push_submenu_end)
1515 (push_left_right_boundary, push_menu_pane): Likewise.
1516 * msdos.c (dos_rawgetc): Likewise.
1518 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1520 * xfns.c (xic_create_fontsetname): Remove redundant calls
1523 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1525 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1526 sprintf already null-terminates its output.
1528 * xfns.c (x_window): Remove redundant cast.
1530 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1532 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1533 `const char *' to `char *' to avoid compiler warning.
1535 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1537 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1538 instead of truncating it to 63 (admittedly a generous limit).
1540 * process.c: Fix spelling and caps in comments.
1542 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1544 * emacs.c (setpgrp): Remove definition, unused.
1545 * sysdep.c (setpgrp): Remove definition, not used in this file.
1547 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1549 * makefile.w32-in: Update dependencies.
1551 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1553 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1554 (SYSTIME_H): Add nt/inc/sys/time.h.
1556 * systime.h [WINDOWSNT]: Include sys/time.h.
1558 * s/ms-w32.h (struct timespec): Definition moved from
1559 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1561 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1563 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1564 * buffer.h (buffer_slot_type_mismatch):
1565 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1566 * eval.c (unwind_to_catch):
1567 * image.c (my_png_error, my_error_exit):
1568 * keyboard.c (quit_throw_to_read_char, user_error)
1569 (Fexit_recursive_edit, Fabort_recursive_edit):
1570 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1571 (wrong_type_argument, buffer_overflow, __executable_start)
1572 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1573 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1574 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1576 (child_setup) [!DOS_NT]:
1577 * lread.c (end_of_file_error, invalid_syntax):
1578 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1579 * puresize.h (pure_write_error):
1580 * search.c (matcher_overflow):
1581 * sound.c (sound_perror, alsa_sound_perror):
1582 * sysdep.c, syssignal.h (croak):
1583 * term.c (maybe_fatal, vfatal):
1584 * textprop.c (text_read_only):
1585 * undo.c (user_error):
1586 * unexmacosx.c (unexec_error):
1587 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1588 Use _Noreturn rather than NO_RETURN.
1589 No need for separate decl merely because of _Noreturn.
1590 * sound.c (sound_warning, parse_sound):
1591 Remove unnecessary forward decls.
1593 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1595 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1596 * lisp.h (WAIT_READING_MAX): New macro.
1597 * dispnew.c (Fsleep_for, sit_for):
1598 * keyboard.c (kbd_buffer_get_event):
1599 * process.c (Faccept_process_output):
1600 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1601 This improves on the previous patch, which introduced a bug
1602 when time_t is unsigned and as wide as intmax_t.
1603 See <http://bugs.gnu.org/9000#51>.
1605 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1607 * dispnew.c (sit_for, Fsleep_for):
1608 * keyboard.c (kbd_buffer_get_event):
1609 * process.c (Faccept_process_output): Avoid compiler warnings when
1610 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1612 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1614 * makefile.w32-in: Update dependencies.
1616 * w32.c (ltime): Add return type and declare static.
1617 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1619 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1621 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1622 Privately reported by Herbert J. Skuhra.
1623 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1625 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1626 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1628 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1630 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1631 last argument of make_unibyte_string.
1633 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1634 language ID in the event parameters.
1636 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1637 event.code, not the obscure "character set ID".
1639 2012-06-23 Chong Yidong <cyd@gnu.org>
1641 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1643 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1645 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1646 * w32.c (fdutimens): New function.
1648 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1650 * s/ms-w32.h (pselect): Redirect to sys_select.
1652 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1654 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1655 in the logic of incrementing and decrementing the value of
1656 use_relocatable_buffers.
1658 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1660 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1661 Privately reported by Herbert J. Skuhra.
1662 [__FreeBSD__]: Remove "*/" typo after "#include".
1663 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1664 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1665 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1666 Don't assume EMACS_TIME and struct timeval are the same type.
1668 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1670 Support higher-resolution time stamps (Bug#9000).
1671 The time stamps are only nanosecond-resolution at the C level,
1672 since that's the best that any real-world system supports now.
1673 But they are picosecond-resolution at the Lisp level, as that's
1674 easy, and leaves room for future OS improvements.
1676 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1679 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1680 Don't get current time unless it's needed.
1682 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1683 now provides it if it's absent.
1684 (start_atimer): Port to higher-res time stamps.
1685 Check for time stamp overflow. Don't get current time more
1686 often than is needed.
1688 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1689 Include systime.h, not time.h.
1690 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1692 * dired.c: Include stat-time.h.
1693 (Ffile-attributes): File times now have higher resolution.
1695 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1696 (struct image): Timestamp now has higher resolution.
1698 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1699 has at least microseconds now. All uses removed.
1700 (update_frame, update_single_window, update_window, update_frame_1)
1701 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1703 * editfns.c (time_overflow): Now extern.
1704 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1705 (float-time, Fformat_time_string, Fcurrent_time_string)
1706 (Fcurrent_time_zone): Accept and generate higher-resolution
1708 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1709 (decode_time_components, lisp_seconds_argument): New functions.
1710 (make_time): Now static.
1711 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1712 Report an error if the time is invalid, rather than having the caller
1715 * fileio.c: Include <stat-time.h>
1716 (Fcopy_file): Copy higher-resolution time stamps.
1717 Prefer to set the time stamp via a file descriptor if that works.
1718 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1719 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1720 (Fvisited_file_modtime, Fset_visited_file_modtime):
1721 Support higher-resolution time stamps.
1723 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1725 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1727 * image.c (prepare_image_for_display, clear_image_cache)
1728 (lookup_image): Port to higer-resolution time stamps.
1730 * keyboard.c (start_polling, bind_polling_period):
1731 Check for time stamp overflow.
1732 (read_char, kbd_buffer_get_event, timer_start_idle)
1733 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1734 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1735 Port to higher-resolution time stamps. Do not assume time_t is signed.
1736 (decode_timer): New function. Timers are now vectors of length 9,
1737 not 8, to accommodate the picosecond component.
1738 (timer_check_2): Use it.
1740 * nsterm.m (select_timeout, timeval_subtract): Remove.
1741 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1742 as they're a bit more accurate and handle overflow better.
1743 (ns_select): Change prototype to be compatible with pselect.
1744 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1745 * nsterm.h (ns_select): Adjust prototype.
1747 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1748 us-resolution time stamps.
1749 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1751 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1753 * lisp.h (time_overflow): New decl.
1754 (wait_reading_process_output): First arg is now intmax_t, not int,
1755 to accommodate larger waits.
1757 * process.h (struct Lisp_Process.read_output_delay):
1758 Now counts nanoseconds, not microseconds.
1759 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1761 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1762 (wait_reading_process_output):
1763 Port to ns-resolution time stamps.
1764 (Faccept_process_output, wait_reading_process_output):
1765 Check for time stamp overflow. Do not assume time_t is signed.
1766 (select_wrapper): Remove; we now use pselect.
1767 (Fprocess_attributes): Now generates ns-resolution time stamps.
1769 * sysdep.c: Include utimens.h. Don't include utime.h
1770 or worry about struct utimbuf; gnulib does that for us now.
1771 (gettimeofday): Remove; gnulib provides a substitute.
1772 (make_timeval): New function.
1773 (set_file_times): Now sets ns-resolution time stamps.
1774 New arg FD; all uses changed.
1775 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1776 (system_process_attributes):
1777 Now returns ns-resolution time stamp. All uses changed.
1778 Check for time stamp overflow.
1780 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1781 provides a substitute now.
1783 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1784 since it guarantees struct timespec.
1785 (EMACS_TIME): Now struct timespec, so that we can support
1786 ns-resolution time stamps.
1787 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1788 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1789 (EMACS_USECS): Remove.
1790 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1791 so multiply the arg by 1000 before storing it.
1792 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1794 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1795 Port to ns-resolution time stamps.
1796 (EMACS_TIME_NEG_P): Remove; replaced by....
1797 (EMACS_TIME_SIGN): New macro.
1798 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1799 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1800 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1801 (make_timeval, make_lisp_time, decode_time_components): New decls.
1802 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1803 that it mishandled time_t overflow. You can't compare by subtracting!
1804 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1805 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1807 * term.c: Include <sys/time.h>.
1808 (timeval_to_Time): New function, for proper overflow wraparound.
1809 (term_mouse_position, term_mouse_click): Use it.
1811 * undo.c (record_first_change): Support higher-resolution time stamps
1813 (Fprimitive_undo): Use them when restoring time stamps.
1815 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1816 (w32_get_internal_run_time):
1817 Port to higher-resolution Emacs time stamps.
1818 (ltime): Now accepts single 64-bit integer, as that's more convenient
1821 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1823 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1824 for compatibility with pselect. Support ns-resolution time stamps.
1826 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1828 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1829 Check for time stamp overflow, and support ns-resolution time stamps.
1831 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1832 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1833 (timeval_subtract): Remove; no longer needed.
1834 (XTflash, XTring_bell, x_wait_for_event):
1835 Port to ns-resolution time stamps. Don't assume time_t is signed.
1837 2012-06-22 Chong Yidong <cyd@gnu.org>
1839 * xdisp.c (x_consider_frame_title): Revert last change.
1841 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1843 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1844 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1845 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1846 staticidx goes up to 1597 out of 1600 = 0x640.)
1848 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1850 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1851 Otherwise, the umask might be mistakenly 0 while handling input signals.
1853 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1855 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1857 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1859 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1860 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1861 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1862 access to `contents' member of Lisp_Vector objects with AREF and ASET
1865 2012-06-19 Chong Yidong <cyd@gnu.org>
1867 * frame.c (delete_frame): When selecting a frame on a different
1868 text terminal, do not alter the terminal's top-frame.
1870 * xdisp.c (format_mode_line_unwind_data): Record the target
1871 frame's selected window and its terminal's top-frame.
1872 (unwind_format_mode_line): Restore them.
1873 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1875 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1876 since tty frames can be explicitly named.
1877 (prepare_menu_bars): Likewise.
1879 * term.c (Ftty_top_frame): New function.
1881 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1883 Port byte-code-meter to modern targets.
1884 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1885 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1886 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1887 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1888 (METER_1, METER_2): Simplify.
1890 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1892 * data.c (Fdefalias): Return `symbol' (bug#11686).
1894 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1896 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1897 gets killed during executing of this function (Bug#11665).
1898 Try to always return Qt when the buffer has been actually killed.
1899 (Vkill_buffer_query_functions): In doc-string say that functions
1900 run by this hook should not change the current buffer.
1902 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1904 Fix recently-introduced process.c problems found by static checking.
1905 * process.c (write_queue_push, write_queue_pop, send_process):
1906 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1907 (write_queue_pop): Fix pointer signedness problem.
1908 (send_process): Remove unused local.
1910 2012-06-17 Chong Yidong <cyd@gnu.org>
1912 * xdisp.c (redisplay_internal): No need to redisplay terminal
1913 frames that are not on top.
1915 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1917 * process.c (make_process): Initialize write_queue.
1918 (write_queue_push, write_queue_pop): New functions.
1919 (send_process): Use them to maintain correct ordering of process
1922 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1924 * lisp.h (eassert): Assume C89 or later.
1925 This removes the need for CHECK.
1926 (CHECK): Remove. Its comments about always evaluating its
1927 argument were confusing, as 'eassert' typically does not evaluate
1930 * coding.c (produce_chars): Use ptrdiff_t, not int.
1932 * xterm.c (x_draw_underwave): Check for integer overflow.
1933 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1935 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1937 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1938 referenced (Bug#11583).
1940 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1942 Implement wave-style variant of underlining.
1943 * dispextern.h (face_underline_type): New enum.
1944 (face): Add field for underline type.
1945 * nsterm.m (ns_draw_underwave): New function.
1946 (ns_draw_text_decoration): Use it.
1947 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1949 (x_draw_glyph_string): Use them.
1950 * xfaces.c (Qline, Qwave): New Lisp objects.
1951 (check_lface_attrs, merge_face_ref)
1952 (Finternal_set_lisp_face_attribute, realize_x_face):
1953 Handle wave-style underline face attributes.
1954 * xterm.c (x_draw_underwave): New function.
1955 (x_draw_glyph_string): Use it.
1957 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1959 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1960 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1961 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1962 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1963 ($(BLD)/w32select.$(O)): Update dependencies.
1965 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1967 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1968 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1969 * character.c (_fetch_multibyte_char_p): Remove.
1970 * alloc.c: Include "character.h" before "buffer.h".
1972 * buffer.c: Likewise.
1973 * bytecode.c: Likewise.
1974 * callint.c: Likewise.
1975 * callproc.c: Likewise.
1976 * casefiddle.c: Likewise.
1977 * casetab.c: Likewise.
1978 * category.c: Likewise.
1980 * coding.c: Likewise.
1981 * composite.c: Likewise.
1982 * dired.c: Likewise.
1983 * dispnew.c: Likewise.
1985 * dosfns.c: Likewise.
1986 * editfns.c: Likewise.
1987 * emacs.c: Likewise.
1988 * fileio.c: Likewise.
1989 * filelock.c: Likewise.
1991 * fontset.c: Likewise.
1992 * fringe.c: Likewise.
1993 * indent.c: Likewise.
1994 * insdel.c: Likewise.
1995 * intervals.c: Likewise.
1996 * keyboard.c: Likewise.
1997 * keymap.c: Likewise.
1998 * lread.c: Likewise.
1999 * macros.c: Likewise.
2000 * marker.c: Likewise.
2001 * minibuf.c: Likewise.
2002 * nsfns.m: Likewise.
2003 * nsmenu.m: Likewise.
2004 * print.c: Likewise.
2005 * process.c: Likewise.
2006 * regex.c: Likewise.
2007 * region-cache.c: Likewise.
2008 * search.c: Likewise.
2009 * syntax.c: Likewise.
2011 * textprop.c: Likewise.
2013 * unexsol.c: Likewise.
2014 * w16select.c: Likewise.
2015 * w32fns.c: Likewise.
2016 * w32menu.c: Likewise.
2017 * window.c: Likewise.
2018 * xdisp.c: Likewise.
2020 * xmenu.c: Likewise.
2022 * xselect.c: Likewise.
2024 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2027 If all the glyphs of the glyph row came from strings, and we have no
2028 cursor positioning clues, put the cursor on the first glyph of the
2030 (handle_face_prop): Use chunk-relative overlay string index when
2031 indexing into it->string_overlays array. (Bug#11653)
2032 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2033 the rightmost. (Bug#11720)
2035 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2037 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2038 (CATEGORY_MEMBER): Enforce 1/0 value.
2039 * category.c (_temp_category_set): Remove.
2041 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2043 * window.c (Fdelete_other_windows_internal)
2044 (Fdelete_window_internal): Don't access frame's mouse highlight
2045 info of the initial frame. (Bug#11677)
2047 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2049 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2050 Assume USE_2_TAGS_FOR_INTS.
2051 (xreload): Adjust $tagmask width to match recent lisp.h change.
2053 Simplify lisp.h in minor ways that should not affect code.
2054 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2055 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2056 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2057 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2058 (INTTYPEBITS): New macro, for clarity.
2059 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2060 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2061 Simplify now that USE_LSB_TAG is always defined.
2062 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2063 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2065 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2067 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2069 2012-06-13 Glenn Morris <rgm@gnu.org>
2071 * s/bsd-common.h (BSD4_3):
2072 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2074 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2076 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2079 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2081 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2082 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2083 * alloc.c (widen_to_Lisp_Object): Remove.
2084 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2085 * frame.c (delete_frame): Remove outdated comment.
2086 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2087 USE_LISP_UNION_TYPE.
2088 (Fw32_unregister_hot_key): Likewise.
2089 (Fw32_toggle_lock_key): Likewise.
2090 * w32menu.c (add_menu_item): Likewise.
2091 (w32_menu_display_help): Use XIL instead of checking
2092 USE_LISP_UNION_TYPE.
2093 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2094 (init_heap): Likewise.
2095 * w32term.c (w32_read_socket): Update comment.
2097 2012-06-13 Glenn Morris <rgm@gnu.org>
2099 * s/usg5-4-common.h, src/s/unixware.h:
2100 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2102 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2104 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2106 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2107 * alloc.c (make_number) [!defined make_number]:
2108 Remove, as lisp.h always defines this now.
2109 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2110 (roundup_size): Verify that it is a power of 2.
2111 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2112 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2113 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2114 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2115 USE_LSB_TAG now is always defined to be either 0 or 1.
2117 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2118 code works fine either way, and efficiency is not a concern here,
2119 as the union type is for debugging, not for production.
2120 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2121 Use an inline function on all platforms when using the union type,
2122 since this is simpler and 'static inline' can be used portably
2124 (LISP_INITIALLY_ZERO): New macro.
2125 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2126 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2128 2012-06-12 Glenn Morris <rgm@gnu.org>
2130 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2132 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2134 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2135 Move BROKEN_SIGIO to configure.
2137 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2138 Move NO_TERMIO to configure.
2140 2012-06-12 Chong Yidong <cyd@gnu.org>
2142 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2143 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2144 MagickExportImagePixels is undefined.
2146 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2148 * image.c (imagemagick_load_image): Remove unused label.
2150 2012-06-11 Glenn Morris <rgm@gnu.org>
2152 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2153 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2154 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2155 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2157 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2159 * alloc.c (make_byte_code): New function.
2160 (Fmake_byte_code): Use it. Don't purify here.
2161 * lread.c (read1): Use it as well to avoid extra allocation.
2163 2012-06-11 Chong Yidong <cyd@gnu.org>
2165 * image.c (imagemagick_load_image): Implement transparency.
2167 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2169 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2170 account for preceding backslashes. (Bug#11663)
2172 2012-06-09 Chong Yidong <cyd@gnu.org>
2174 * term.c: Support italics in capable terminals (Bug#9652).
2175 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2176 (turn_on_face): Output using TS_enter_italic_mode if available.
2177 Don't handle unused blinking and alt-charset cases.
2178 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2179 and tty_alt_charset_p cases.
2180 (tty_capable_p, init_tty): Support italics.
2182 * termchar.h (struct tty_display_info): Add field for italics.
2183 Remove unused blink field.
2185 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2188 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2189 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2190 tty_alt_charset_p. Add tty_italic_p.
2192 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2194 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2195 dbus_type_is_basic if available.
2196 (xd_extract_signed, xd_extract_unsigned): Rename from
2197 extract_signed and extract_unsigned, respectively. Adapt callers.
2199 2012-06-09 Chong Yidong <cyd@gnu.org>
2201 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2203 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2206 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2208 * xdisp.c (vmessage): Treat frame message as multibyte.
2209 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2210 would generate the diagnostic "Making \302\247 buffer-local while
2213 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2215 * dispnew.c (showing_window_margins_p): Undo last change, which
2216 was done due to an inadvertent commit.
2217 (adjust_frame_glyphs_for_frame_redisplay): Do call
2218 showing_window_margins_p.
2220 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2222 * eval.c (Fmake_var_non_special): New primitive.
2223 (syms_of_eval): Defsubr it.
2224 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2226 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2228 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2229 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2231 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2233 * alloc.c (allocate_vectorlike): Fix last change.
2235 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2237 Block-based vector allocation of small vectors.
2238 * lisp.h (struct vectorlike_header): New field `nbytes',
2239 adjust comment accordingly.
2240 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2241 to denote vector blocks. Adjust users (live_vector_p,
2242 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2243 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2244 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2245 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2246 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2247 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2248 (roundup_size): New constant.
2249 (struct vector_block): New data type.
2250 (vector_blocks, vector_free_lists, zero_vector): New variables.
2251 (all_vectors): Rename to `large_vectors'.
2252 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2253 (sweep_vectors): New functions.
2254 (allocate_vectorlike): Return `zero_vector' as the only vector of
2255 0 items. Allocate new vector from block if vector size is less than
2256 or equal to VBLOCK_BYTES_MAX.
2257 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2258 (init_alloc_once): Add call to init_vectors.
2260 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2262 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2264 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2266 * doprnt.c (doprnt): Truncate multibyte char correctly.
2267 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2268 would mishandle a string argument "Xc" if X was a multibyte
2269 character of length 2: it would truncate after X's first byte
2270 rather than including all of X.
2272 2012-06-06 Chong Yidong <cyd@gnu.org>
2274 * buffer.c (word_wrap): Doc fix.
2276 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2278 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2280 2012-06-03 Glenn Morris <rgm@gnu.org>
2282 * xdisp.c (tool-bar-style): Doc fix.
2284 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2286 * Makefile.in (PAXCTL): Define.
2287 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2288 binary via PaX flags if the paxctl utility is available.
2289 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2290 Restore PaX flags to their default. (Bug#11398)
2292 2012-06-03 Chong Yidong <cyd@gnu.org>
2294 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2297 2012-06-03 Chong Yidong <cyd@gnu.org>
2299 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2300 (note_mode_line_or_margin_highlight): If there is no help echo,
2301 use mode-line-default-help-echo. Handle the case where the mouse
2302 position is past the end of the mode line string.
2304 * buffer.c (buffer_local_value_1): New function, split from
2305 Fbuffer_local_value; can return Qunbound.
2306 (Fbuffer_local_value): Use it.
2307 (Vmode_line_format): Docstring tweaks.
2309 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2311 * sysdep.c (system_process_attributes): Improve comment.
2313 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2315 * keyboard.c: Export real-this-command to Elisp.
2316 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2317 and DEFVAR it. Update all users.
2319 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2321 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2323 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2324 Convert pctcpu and pctmem to Lisp float properly.
2325 Let the compiler fold better, as 100.0/0x8000 is exact.
2327 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2329 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2332 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2334 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2336 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2338 For a 'struct window', replace some Lisp_Object fields to
2339 bitfields where appropriate, remove unused fields.
2340 * window.h (struct window): Remove unused 'last_mark_x' and
2341 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2342 change it's type from Lisp_Object to bitfield.
2343 Change type of 'force_start', 'optional_new_start',
2344 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2345 fields from Lisp_Object to bitfield. Adjust users accordingly.
2347 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2349 Pacify gcc -Wdouble-precision when using Xaw.
2350 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2351 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2352 Use 'float' consistently, rather than 'float' in most places
2353 and 'double' in a couple of places.
2355 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2357 * xdisp.c (handle_stop): Detect whether we have overlay strings
2358 loaded by testing it->current.overlay_string_index to be
2359 non-negative, instead of checking whether n_overlay_strings is
2360 positive. (Bug#11587)
2362 2012-05-31 Chong Yidong <cyd@gnu.org>
2364 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2366 * doc.c (Fsubstitute_command_keys): Doc fix.
2368 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2370 * search.c (search_buffer): Remove calls to
2371 r_alloc_inhibit_buffer_relocation, as it is now called by
2372 maybe_unify_char, which was the cause of relocation of buffer text
2375 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2377 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2378 for the duration of call to load_charset, to avoid problems with
2379 callers of maybe_unify_char that access buffer text through C
2382 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2383 decrement the inhibition flag, instead of just setting or
2386 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2388 Remove obsolete '#define static' cruft.
2389 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2390 This #undef was "temporary" in 2000; it is no longer needed
2391 now that '#define static' has gone away.
2392 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2393 (gray_bitmap_bits): Remove; no longer needed.
2394 All uses replaced with definiens.
2395 * xterm.c: Include "bitmaps/gray.xbm".
2397 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2399 Clean up __executable_start, monstartup when --enable-profiling.
2400 The following changes affect the code only when profiling.
2401 * dispnew.c (__executable_start): Rename from safe_bcopy.
2402 Define only on platforms that need it.
2403 * emacs.c: Include <sys/gmon.h> when profiling.
2404 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2405 (__executable_start): Remove decl, since lisp.h does it now.
2406 (safe_bcopy): Remove decl; no longer has that name.
2407 (main): Coalesce #if into single bit of code, for simplicity.
2408 Cast pointers to uintptr_t, since standard libraries want integers
2410 * lisp.h (__executable_start): New decl.
2412 2012-05-31 Glenn Morris <rgm@gnu.org>
2414 * image.c (Fimagemagick_types): Doc fix.
2416 2012-05-30 Jim Meyering <meyering@redhat.com>
2418 * callproc.c (Fcall_process_region): Include directory component
2419 in mkstemp error message (Bug#11586).
2421 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2423 * alloc.c, lisp.h (make_pure_vector): Now static.
2425 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2427 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2428 Move to byte-run.el.
2429 (Fautoload): Do the hash-doc more carefully.
2430 * data.c (Fdefalias): Purify definition, except for keymaps.
2431 (Qdefun): Move from eval.c.
2432 * lisp.h (Qdefun): Remove.
2433 * lread.c (read1): Tiny simplification.
2435 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2437 Do not create empty overlays with the evaporate property (Bug#9642).
2438 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2439 Bug#9642, but explicitly check that the buffer the overlay would
2440 be moved to is live and rearrange lines to make sure that errors
2441 will not put the overlay in an inconsistent state.
2442 (Fdelete_overlay): Cosmetics.
2444 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2446 * w32term.c (my_bring_window_to_top): New function.
2447 (x_raise_frame): Use handle returned by DeferWindowPos, which
2448 could be different from the original one.
2449 Call my_bring_window_to_top instead of my_set_foreground_window.
2452 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2453 by calling BringWindowToTop.
2455 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2456 (WM_EMACS_END): Increase by one.
2458 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2460 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2461 This avoids undefined behavior that might cause the eassert
2462 to not catch an out-of-range value.
2464 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2466 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2467 Update dependencies.
2469 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2471 * bidi.c (bidi_mirror_char): Fix last change.
2473 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2475 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2476 when referring to sectname field in printf format.
2478 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2480 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2481 Only r_alloc_inhibit_buffer_relocation needed to be added;
2482 the others were already declared.
2484 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2485 before checking whether it's out of range. Put the check inside
2487 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2489 2012-05-27 Ken Brown <kbrown@cornell.edu>
2491 * callproc.c (Fcall_process): Restore a line that was accidentally
2492 commented out in the 2011-02-13 change (bug#11547).
2494 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2496 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2497 defined on ralloc.c.
2499 * buffer.c [REL_ALLOC]: Remove prototypes of
2500 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2501 they are now on lisp.h.
2503 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2505 * search.c (search_buffer): Use it to inhibit relocation of buffer
2506 text while re_search_2 is doing its job, because re_search_2 is
2507 passed C pointers to buffer text. (Bug#11519)
2509 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2512 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2513 state after an additional call to move_it_in_display_line_to, keep
2514 the values of it->max_ascent and it->max_descent found for the
2516 (pos_visible_p): Revert the comparison against bottom_y to what it
2517 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2520 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2522 Fix coding-related core dumps with gcc -ftrapv.
2523 The code was computing A - B, where A and B are pointers, and B is
2524 random garbage. This can lead to core dumps on platforms that
2525 have special pointer registers, and it also leads to core dumps on
2526 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2527 A - B only when B is initialized properly.
2528 * coding.c (coding_set_source, coding_set_destination): Return void.
2529 (coding_change_source, coding_change_destinations): New functions,
2530 with the old behaviors of coding_set_source and coding_set_destination.
2531 All callers that need an offset changed to use these new functions.
2533 2012-05-26 Glenn Morris <rgm@gnu.org>
2535 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2537 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2539 Extend mouse support on W32 text-mode console.
2540 * xdisp.c (draw_row_with_mouse_face):
2541 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2543 * w32console.c: Include window.h.
2544 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2546 (initialize_w32_display): Initialize mouse-highlight data.
2548 * w32inevt.c: Include termchar.h and window.h.
2549 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2550 moves, call note_mouse_highlight. If help_echo changed, call
2551 gen_help_event to produce help-echo message in the echo area.
2552 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2555 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2557 * lread.c (read1): Simplify slightly to avoid an overflow warning
2558 with GCC 4.7.0 on x86-64.
2560 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2562 * bidi.c (bidi_mirror_char): Revert last change: an int is
2563 definitely wide enough here.
2565 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2567 Fix integer width and related bugs (Bug#9874).
2568 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2569 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2570 (string_bytes, check_sblock, allocate_string_data):
2571 (compact_small_strings, Fmake_bool_vector, make_string)
2572 (make_unibyte_string, make_multibyte_string)
2573 (make_string_from_bytes, make_specified_string)
2574 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2575 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 (allocate_pseudovector):
2579 Use int, not EMACS_INT, where int is wide enough.
2580 (inhibit_garbage_collection, Fgarbage_collect):
2581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2582 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2583 int might not be wide enough.
2584 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2585 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2586 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2587 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2588 (bidi_level_of_next_char, bidi_move_to_visually_next):
2589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2590 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2591 (Fkill_buffer, Fset_buffer_major_mode)
2592 (advance_to_char_boundary, Fbuffer_swap_text)
2593 (Fset_buffer_multibyte, overlays_at, overlays_in)
2594 (overlay_touches_p, struct sortvec, record_overlay_string)
2595 (overlay_strings, recenter_overlay_lists)
2596 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2597 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2598 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2599 (Foverlay_recenter, last_overlay_modification_hooks_used)
2600 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (validate_region): Omit unnecessary test for b <= e,
2603 since that's guaranteed by the previous test.
2604 (adjust_overlays_for_delete): Avoid pos + length overflow.
2605 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2606 (report_overlay_modification):
2607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2608 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2609 Omit pointer cast, which isn't needed anyway, and doesn't work
2610 after the EMACS_INT -> ptrdiff_t change.
2611 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2612 * buffer.h: Adjust decls to match defn changes elsewhere.
2613 (struct buffer_text, struct buffer):
2614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2615 Use EMACS_INT, not int, where int might not be wide enough.
2616 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2617 not int, to avoid needless 32-bit limit on 64-bit hosts.
2618 (exec_byte_code): Use tighter memory-full test, one that checks
2619 for alloca overflow. Don't compute the address of the object just
2620 before an array, as that's not portable. Use EMACS_INT, not
2621 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2622 * callint.c (Fcall_interactively):
2623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2624 * callproc.c (call_process_kill, Fcall_process):
2625 Don't assume pid_t fits into an Emacs fixnum.
2626 (call_process_cleanup, Fcall_process, child_setup):
2627 Don't assume pid_t fits into int.
2628 (call_process_cleanup, Fcall_process, delete_temp_file)
2629 (Fcall_process_region):
2630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2631 (Fcall_process): Simplify handling of volatile integers.
2632 Use int, not EMACS_INT, where int will do.
2633 * casefiddle.c (casify_object, casify_region, operate_on_word)
2634 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (casify_object): Avoid integer overflow when overallocating buffer.
2637 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2638 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2639 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2640 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2641 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2642 integers are now checked earlier. All uses replaced with XINT.
2644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2645 For CCL_MapSingle, check that content and value are in int range.
2646 (ccl_driver, Fregister_code_conversion_map):
2647 Check that Vcode_version_map_vector is a vector.
2648 (resolve_symbol_ccl_program): Check that vector header is in range.
2649 Always copy the vector, so that we can check its contents reliably
2650 now rather than having to recheck each instruction as it's being
2651 executed. Check that vector words fit in 'int'.
2652 (ccl_get_compiled_code, Fregister_ccl_program)
2653 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2654 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2655 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2656 contents are in range.
2657 (Fccl_execute_on_string): Check that status is in range.
2658 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2659 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2660 Accept and return EMACS_INT, not int, because callers can pass values
2662 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2663 (multibyte_chars_in_text, parse_str_as_multibyte)
2664 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2665 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2666 (string_escape_byte8, Fget_byte):
2667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2668 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2669 avoid mishandling large integers.
2670 * character.h: Adjust decls to match defn changes elsewhere.
2671 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2672 (Ffind_charset_region):
2673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2674 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2675 (load_charset_map_from_vector, Fdefine_charset_internal):
2676 Don't assume fixnum fits in int.
2677 (load_charset_map_from_vector, Fmap_charset_chars):
2678 Remove now-unnecessary CHECK_NATNUMs.
2679 (Fdefine_charset_internal): Check ranges here, more carefully.
2680 Don't rely on undefined behavior with signed left shift overflow.
2681 Don't assume unsigned int fits into fixnum, or that fixnum fits
2682 into unsigned int. Don't require max_code to be a valid fixnum;
2683 that's not true for gb10830 4-byte on a 32-bit host. Allow
2684 invalid_code to be a cons, for the same reason. Require code_offset
2685 to be a character. Avoid int overflow if max_char is close
2687 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2688 this is intended anyway and avoids some undefined behavior.
2689 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2690 INDEX_TO_CODE_POINT, as that's what it expects.
2691 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2692 * charset.h (DECODE_CHAR): Return int, not unsigned;
2693 this is what was intended anyway, and it avoids undefined behavior.
2694 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2695 integer-overflow issues.
2696 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2697 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2698 where the argument is EMACS_INT, and this behavior is not intended.
2699 * chartab.c (Fmake_char_table, Fset_char_table_range)
2700 (uniprop_get_decoder, uniprop_get_encoder):
2701 Don't assume fixnum fits in int.
2702 * cmds.c (move_point): New function, that does the gist of
2703 Fforward_char and Fbackward_char, but does so while checking
2704 for integer overflow more accurately.
2705 (Fforward_char, Fbackward_char): Use it.
2706 (Fforward_line, Fend_of_line, internal_self_insert)
2707 (internal_self_insert):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 Fix a FIXME, by checking for integer overflow when calculating
2710 target_clm and actual_clm.
2711 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2712 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2713 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2714 (coding_alloc_by_making_gap, alloc_destination)
2715 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2716 (encode_coding_utf_16, detect_coding_emacs_mule)
2717 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2718 (detect_coding_iso_2022, decode_coding_iso_2022)
2719 (encode_invocation_designation, encode_designation_at_bol)
2720 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2721 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2722 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2723 (encode_coding_ccl, encode_coding_raw_text)
2724 (detect_coding_charset, decode_coding_charset)
2725 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2726 (produce_composition, produce_charset, produce_annotation)
2727 (decode_coding, handle_composition_annotation)
2728 (handle_charset_annotation, consume_chars, decode_coding_gap)
2729 (decode_coding_object, encode_coding_object, detect_coding_system)
2730 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2731 (code_convert_region, code_convert_string)
2732 (Fdefine_coding_system_internal)
2733 (coding_set_source, coding_set_destination):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2736 (Fdefine_coding_system_internal):
2737 Don't assume fixnums fit in int.
2738 (decode_coding_gap, decode_coding_object, encode_coding_object)
2739 (Fread_coding_system, Fdetect_coding_region)
2740 (Funencodable_char_position, Fcheck_coding_systems_region)
2741 (get_translation, handle_composition_annotation, consume_chars):
2742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2743 (consume_chars): Rewrite to not calculate an address outside buffer.
2744 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2745 Don't access memory outside of the args array.
2746 (Fdefine_coding_system_internal): Check for charset-id overflow.
2747 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2748 result of ENCODE_CHAR.
2749 * coding.h: Adjust decls to match defn changes elsewhere.
2750 (struct coding_system):
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 * composite.c (get_composition_id, find_composition)
2753 (run_composition_function, update_compositions)
2754 (compose_text, composition_gstring_put_cache)
2755 (composition_gstring_p, composition_gstring_width)
2756 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2757 (composition_compute_stop_pos, composition_reseat_it)
2758 (composition_update_it, struct position_record)
2759 (find_automatic_composition, composition_adjust_point)
2760 (Fcomposition_get_gstring, Ffind_composition_internal):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (update_compositions):
2763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2764 * composite.h: Adjust decls to match defn changes elsewhere.
2765 (struct composition):
2766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2767 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2768 Do not attempt to compute the address of the object just before a
2769 buffer; this is not portable.
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 (Faset): Use int, not EMACS_INT, where int is wide enough.
2773 (Fstring_to_number): Don't assume fixnums fit in int.
2774 (Frem): Don't assume arg is nonnegative.
2775 * dbusbind.c (xd_append_arg): Check for integers out of range.
2776 (Fdbus_call_method): Don't overflow the timeout int.
2777 (extract_signed, extract_unsigned): New functions.
2778 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2779 (xd_get_connection_references): Return ptrdiff_t, not int.
2781 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2782 (xd_read_message_1):
2783 Use int, not unsigned, where the dbus API uses int.
2784 (Fdbus_message_internal): Don't overflow mtype.
2785 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2786 * dired.c (directory_files_internal, file_name_completion, scmp)
2787 (file_name_completion_stat):
2788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2789 (file_name_completion): Don't overflow matchcount.
2790 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2791 * dispextern.h: Adjust decls to match defn changes elsewhere.
2792 (struct text_pos, struct glyph, struct bidi_saved_info)
2793 (struct bidi_string_data, struct bidi_it, struct composition_it)
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 (struct display_pos, struct composition_it, struct it):
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2798 * dispnew.c (increment_matrix_positions)
2799 (increment_row_positions, mode_line_string)
2800 (marginal_area_string):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2804 (duration_to_sec_usec): New function, to check for overflow better.
2805 (Fsleep_for, sit_for): Use it.
2806 * doc.c (get_doc_string, store_function_docstring):
2807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2808 (get_doc_string, Fsnarf_documentation):
2809 Use int, not EMACS_INT, where int is wide enough.
2811 Use SAFE_ALLOCA, not alloca.
2812 Check for overflow when converting EMACS_INT to off_t.
2813 * doprnt.c (doprnt):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2815 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2816 Don't assume uid_t fits into fixnum.
2817 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2818 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2819 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2820 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2821 (general_insert_function)
2822 (Finsert_char, make_buffer_string, make_buffer_string_both)
2823 (update_buffer_properties, Fbuffer_substring)
2824 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2825 (Fsubst_char_in_region, check_translation)
2826 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2827 (transpose_markers, Ftranspose_regions):
2828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2829 (clip_to_bounds): Move to lisp.h as an inline function).
2830 (Fconstrain_to_field): Don't assume integers are nonnegative.
2831 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2832 (Fsubst_char_in_region, Fsave_restriction):
2833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2834 (Femacs_pid): Don't assume pid_t fits into fixnum.
2835 (lo_time): Use int, not EMACS_INT, when int suffices.
2836 (lisp_time_argument): Check for usec out of range.
2837 (Fencode_time): Don't assume fixnum fits in int.
2838 (Fuser_login_name, Fuser_full_name): Signal an error
2839 if a uid argument is out of range, rather than relying on
2841 (Fformat_time_string): Remove now-unnecessary check.
2842 lisp_time_argument checks for out-of-range usec now.
2843 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2844 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2845 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2846 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2847 (init_cmdargs, Fdump_emacs):
2848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2849 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2850 the bottom (typically) 32 bits of the fixnum.
2851 * eval.c (specpdl_size, call_debugger):
2852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2853 (when_entered_debugger, Fbacktrace_debug):
2854 Don't assume fixnum can fit in int.
2855 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2856 the object just before a buffer; this is not portable.
2857 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2858 (grow_specpdl, unbind_to):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2861 (grow_specpdl): Simplify allocation by using xpalloc.
2862 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2863 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2864 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2866 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2869 (Fcopy_file, non_regular_nbytes, read_non_regular)
2870 (Finsert_file_contents):
2871 Use int, not EMACS_INT, where int is wide enough.
2872 (READ_BUF_SIZE): Verify that it fits in int.
2873 (Finsert_file_contents): Check that counts are in proper range,
2874 rather than assuming fixnums fit into ptrdiff_t etc.
2875 Don't assume fixnums fit into int.
2876 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2877 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2878 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2879 (string_char_to_byte, string_byte_to_char)
2880 (string_make_multibyte, string_to_multibyte)
2881 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2882 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2883 (substring_both, Fdelete, internal_equal, Ffillarray)
2884 (Fclear_string, mapcar1)
2885 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2886 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2887 (larger_vector, make_hash_table, maybe_resize_hash_table)
2888 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2889 (Fmaphash, secure_hash):
2890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2891 (concat): Check for string index and length overflow.
2892 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (larger_vector): New API (vec, incr_min, size_max) replaces old
2896 one (vec, new_size, init). This catches size overflow.
2897 INIT was removed because it was always Qnil.
2898 All callers changed.
2899 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2900 the upper bound on a hash table index size.
2901 (make_hash_table, maybe_resize_hash_table): Use it.
2902 (secure_hash): Computer start_byte and end_byte only after
2903 they're known to be in ptrdiff_t range.
2904 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2905 (Ffont_get_glyphs, Ffont_at):
2906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2907 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2908 (Flist_fonts, Fopen_font):
2909 Don't assume fixnum can fit in int.
2910 (check_gstring): Don't assume index can fit in int.
2911 (font_match_p): Check that fixnum is a character, not a nonnegative
2912 fixnum, since the later code needs to stuff it into an int.
2913 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2914 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2915 conversion overflow issues.
2916 (Fopen_font): Check for integer out of range.
2917 (Ffont_get_glyphs): Don't assume index can fit in int.
2918 * font.h: Adjust decls to match defn changes elsewhere.
2919 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2921 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2922 printmax_t, where ptrdiff_t is wide enough.
2923 (Finternal_char_font):
2924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2925 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2926 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2927 (Fset_frame_position, x_set_frame_parameters)
2928 (x_set_line_spacing, x_set_border_width)
2929 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2930 Check that fixnums are in proper range for system types.
2931 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2933 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2934 Use SAFE_ALLOCA_LISP, not alloca.
2935 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2936 intptr_t is wide enough.
2937 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2938 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2939 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2940 Check for fixnum out of range.
2941 * ftfont.c (ftfont_list): Don't assume index fits in int.
2942 Check that fixnums are in proper range for system types.
2943 (ftfont_shape_by_flt):
2944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2945 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2947 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2948 Check that fixnums are in proper range for system types.
2949 * gnutls.h: Adjust decls to match defn changes elsewhere.
2950 * gtkutil.c (xg_dialog_run):
2951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2952 (update_frame_tool_bar):
2953 Check that fixnums are in proper range for system types.
2954 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2955 (lookup_image): Check that fixnums are in range for system types.
2956 * indent.c (last_known_column, last_known_column_point):
2957 (current_column_bol_cache):
2958 (skip_invisible, current_column, check_display_width):
2959 (check_display_width, scan_for_column, current_column_1)
2960 (Findent_to, Fcurrent_indentation, position_indentation)
2961 (indented_beyond_p, Fmove_to_column, compute_motion):
2962 (Fcompute_motion, Fvertical_motion):
2963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2964 (last_known_column_modified): Use EMACS_INT, not int.
2965 (check_display_width):
2967 Check that fixnums and floats are in proper range for system types.
2968 (compute_motion): Don't assume index or fixnum fits in int.
2969 (compute_motion, Fcompute_motion):
2970 Use int, not EMACS_INT, when it is wide enough.
2971 (vmotion): Omit local var start_hpos that is always 0; that way
2972 we don't need to worry about overflow in expressions involving it.
2973 * indent.h: Adjust decls to match defn changes elsewhere.
2975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2976 Use int, not EMACS_INT, where int is wide enough.
2977 Remove unused members ovstring_chars_done and tab_offset;
2979 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2980 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2981 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2982 (make_gap, copy_text, insert, insert_and_inherit)
2983 (insert_before_markers, insert_before_markers_and_inherit)
2984 (insert_1, count_combining_before, count_combining_after)
2985 (insert_1_both, insert_from_string)
2986 (insert_from_string_before_markers, insert_from_string_1)
2987 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2988 (adjust_after_replace, adjust_after_insert, replace_range)
2989 (replace_range_2, del_range, del_range_1, del_range_byte)
2990 (del_range_both, del_range_2, modify_region)
2991 (prepare_to_modify_buffer, signal_before_change)
2992 (signal_after_change, Fcombine_after_change_execute):
2993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2994 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2995 (balance_an_interval, split_interval_right, split_interval_left)
2996 (find_interval, next_interval, update_interval)
2997 (adjust_intervals_for_insertion, delete_node, delete_interval)
2998 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2999 (static_offset_intervals, offset_intervals)
3000 (merge_interval_right, merge_interval_left, make_new_interval)
3001 (graft_intervals_into_buffer, temp_set_point_both)
3002 (temp_set_point, set_point, adjust_for_invis_intang)
3003 (set_point_both, move_if_not_intangible, get_property_and_range)
3004 (get_local_map, copy_intervals, copy_intervals_to_string)
3005 (compare_string_intervals, set_intervals_multibyte_1):
3006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3007 * intervals.h: Adjust decls to match defn changes elsewhere.
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 * keyboard.c (this_command_key_count, this_single_command_key_start)
3011 (before_command_key_count, before_command_echo_length, echo_now)
3012 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3013 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3014 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3015 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3017 (last_non_minibuf_size, last_point_position, echo_truncate)
3018 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3019 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3020 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3021 (stuff_buffered_input):
3022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3023 (last_auto_save, command_loop_1, read_char):
3024 Use EMACS_INT, not int, to avoid integer overflow.
3025 (record_char): Avoid overflow in total_keys computation.
3026 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3027 * keyboard.h: Adjust decls to match defn changes elsewhere.
3028 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3029 (Fkey_description, Fdescribe_vector, Flookup_key):
3030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3031 (click_position): New function, to check that positions are in range.
3032 (Fcurrent_active_maps):
3034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3035 (Faccessible_keymaps, Fkey_description):
3036 (preferred_sequence_p):
3037 Don't assume fixnum can fit into int.
3038 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3039 Check for integer overflow in size calculations.
3040 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3041 avoid mishandling large integers.
3042 * lisp.h: Adjust decls to match defn changes elsewhere.
3043 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3044 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3045 (struct Lisp_Marker):
3046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3047 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3048 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3049 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3050 All callers changed.
3051 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3052 Assume the arg has valid form, since it always does.
3053 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3054 unsigned integer system type.
3055 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3056 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3058 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3059 (duration_to_sec_usec): New decl.
3060 * lread.c (read_from_string_index, read_from_string_index_byte)
3061 (read_from_string_limit, readchar, unreadchar, openp)
3062 (read_internal_start, read1, oblookup):
3063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3064 (Fload, readevalloop, Feval_buffer, Feval_region):
3065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3066 (openp): Check for out-of-range argument to 'access'.
3067 (read1): Use int, not EMACS_INT, where int is wide enough.
3068 Don't assume fixnum fits into int.
3069 Fix off-by-one error that can read outside a buffer.
3070 (read_filtered_event): Use duration_to_sec_usec
3071 to do proper overflow checking on durations.
3072 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3073 in size calculation.
3074 (Fexecute_kbd_macro):
3075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3076 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3077 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3078 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3079 (set_marker_both, set_marker_restricted_both, marker_position)
3080 (marker_byte_position, Fbuffer_has_markers_at):
3081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3082 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3083 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3084 It now merely ensures that the menu is large enough, without
3085 necessarily growing it, as this avoids some integer overflow issues.
3086 All callers changed.
3087 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3089 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3090 Use SAFE_ALLOCA_LISP, not alloca.
3091 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3092 to EMACS_INT. Check that fixnums are in proper range for system types.
3093 * minibuf.c (minibuf_prompt_width, string_to_object)
3094 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3095 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3097 (get_minibuffer, read_minibuf_unwind):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3100 this simplifies overflow checking. All callers changed.
3101 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3104 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3105 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3106 Check that fixnums are in proper range for system types.
3107 (Fx_create_frame, Fx_show_tip):
3108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3109 * nsfont.m (ns_findfonts, nsfont_list_family):
3110 Don't assume fixnum fits in long.
3111 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3113 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3115 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3117 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3118 (PRINTDECLARE, PRINTPREPARE):
3119 (strout, print_string):
3120 (print, print_preprocess, print_check_string_charset_prop)
3122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3124 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3126 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3127 (printchar, strout): Use xpalloc to catch size calculation overflow.
3128 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3129 (print_error_message): Use SAFE_ALLOCA, not alloca.
3130 (print_object): Use int, not EMACS_INT, where int is wide enough.
3131 (print_depth, new_backquote_output, print_number_index):
3132 Use ptrdiff_t, not int, where int might not be wide enough.
3133 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3134 (Fset_process_window_size, Fformat_network_address)
3135 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3137 Check that fixnums are in proper range for system types.
3138 (Fsignal_process): Simplify by avoiding a goto.
3139 Check for process-ids out of pid_t range rather than relying on
3141 (process_tick, update_tick): Use EMACS_INT, not int.
3142 (Fformat_network_address, read_process_output, send_process)
3143 (Fprocess_send_region, status_notify):
3144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3145 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3146 (wait_reading_process_output, read_process_output, exec_sentinel):
3147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3148 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3149 (Faccept_process_output): Use duration_to_sec_usec to do proper
3150 overflow checking on durations.
3151 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3152 Don't assume pid_t fits in int.
3153 * process.h (struct Lisp_Process): Members tick and update_tick
3154 are now of type EMACS_INT, not int.
3155 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3156 configured --with-wide-int.
3157 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3158 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3159 * search.c (looking_at_1, string_match_1):
3160 (fast_string_match, fast_c_string_match_ignore_case)
3161 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3162 (scan_newline, find_before_next_newline, search_command)
3163 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3164 (set_search_regs, wordify):
3167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3168 (string_match_1, search_buffer, set_search_regs):
3170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3171 (wordify): Check for overflow in size calculation.
3172 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3173 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3174 Check that fixnums are in proper range for system types.
3175 * sound.c (struct sound_device)
3176 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3178 (Fplay_sound_internal):
3179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3180 * syntax.c (struct lisp_parse_state, find_start_modiff)
3181 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3182 (Fparse_partial_sexp):
3183 Don't assume fixnums can fit in int.
3184 (struct lisp_parse_state, find_start_pos, find_start_value)
3185 (find_start_value_byte, find_start_begv)
3186 (update_syntax_table, char_quoted, dec_bytepos)
3187 (find_defun_start, prev_char_comend_first, back_comment):
3188 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3189 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3191 (Finternal_describe_syntax_value): Check that match_lisp is a
3192 character, not an integer, since the code stuffs it into int.
3193 (scan_words, scan_sexps_forward):
3194 Check that fixnums are in proper range for system types.
3196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3197 (scan_sexps_forward):
3198 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3199 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3200 * syntax.h: Adjust decls to match defn changes elsewhere.
3201 (struct gl_state_s):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3204 MOST_POSITIVE_FIXNUM.
3205 * sysdep.c (wait_for_termination_1, wait_for_termination)
3206 (interruptible_wait_for_termination, mkdir):
3207 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3208 (emacs_read, emacs_write):
3209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3210 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3211 and double all fit in int.
3212 * term.c (set_tty_color_mode):
3213 Check that fixnums are in proper range for system types.
3214 * termhooks.h (struct input_event):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 * textprop.c (validate_interval_range, interval_of)
3217 (Fadd_text_properties, set_text_properties_1)
3218 (Fremove_text_properties, Fremove_list_of_text_properties)
3219 (Ftext_property_any, Ftext_property_not_all)
3220 (copy_text_properties, text_property_list, extend_property_ranges)
3221 (verify_interval_modification):
3222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3223 (Fnext_single_char_property_change)
3224 (Fprevious_single_char_property_change):
3225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3226 (copy_text_properties):
3227 Check for integer overflow in index calculation.
3228 * undo.c (last_boundary_position, record_point, record_insert)
3229 (record_delete, record_marker_adjustment, record_change)
3230 (record_property_change):
3231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3232 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3235 (Fx_hide_tip, Fx_file_dialog):
3236 * w32menu.c (set_frame_menubar):
3237 Use ptrdiff_t, not int, for consistency with rest of code.
3238 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3239 (select_window, Fdelete_other_windows_internal)
3240 (window_scroll_pixel_based, window_scroll_line_based)
3241 (Frecenter, Fset_window_configuration):
3242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3243 (Fset_window_hscroll, run_window_configuration_change_hook)
3244 (set_window_buffer, temp_output_buffer_show, scroll_command)
3245 (Fscroll_other_window, Frecenter):
3246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3247 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3248 Don't assume fixnum fits in int.
3249 (Fset_window_scroll_bars):
3250 Check that fixnums are in proper range for system types.
3251 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3252 (string_pos, c_string_pos, number_of_chars, init_iterator)
3253 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3254 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3255 (compute_display_string_end, handle_face_prop)
3256 (face_before_or_after_it_pos, handle_invisible_prop)
3257 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3258 (display_prop_intangible_p, string_buffer_position_lim)
3259 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3260 (get_overlay_strings_1, get_overlay_strings)
3261 (iterate_out_of_display_property, forward_to_next_line_start)
3262 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3263 (get_next_display_element, set_iterator_to_next)
3264 (get_visually_first_element, compute_stop_pos_backwards)
3265 (handle_stop_backwards, next_element_from_buffer)
3266 (move_it_in_display_line_to, move_it_in_display_line)
3267 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3268 (add_to_log, message_dolog, message_log_check_duplicate)
3269 (message2, message2_nolog, message3, message3_nolog
3270 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3271 (current_message_1, truncate_echo_area, truncate_message_1)
3272 (set_message, set_message_1, store_mode_line_noprop)
3273 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3274 (text_outside_line_unchanged_p, check_point_in_composition)
3275 (reconsider_clip_changes)
3276 (redisplay_internal, set_cursor_from_row, try_scrolling)
3277 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3278 (redisplay_window, find_last_unchanged_at_beg_row)
3279 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3280 (trailing_whitespace_p, find_row_edges, display_line)
3281 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3282 (display_mode_element, store_mode_line_string)
3283 (pint2str, pint2hrstr, decode_mode_spec)
3284 (display_count_lines, display_string, draw_glyphs)
3285 (x_produce_glyphs, x_insert_glyphs)
3286 (rows_from_pos_range, mouse_face_from_buffer_pos)
3287 (fast_find_string_pos, mouse_face_from_string_pos)
3288 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3290 (safe_call, init_from_display_pos, handle_fontified_prop)
3291 (handle_single_display_spec, load_overlay_strings)
3292 (with_echo_area_buffer, setup_echo_area_for_printing)
3293 (display_echo_area, echo_area_display)
3294 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3295 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3296 (redisplay_window, dump_glyph_row, display_mode_line)
3297 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3298 (handle_display_spec, display_prop_string_p):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 (handle_single_display_spec, build_desired_tool_bar_string)
3301 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3302 (get_specified_cursor_type):
3303 Check that fixnums are in proper range for system types.
3304 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3305 (Flookup_image_map):
3306 Don't assume fixnums fit in int.
3307 (compare_overlay_entries):
3308 Avoid mishandling comparisons due to subtraction overflow.
3309 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3310 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3311 (handle_tool_bar_click):
3312 Use int, not unsigned, since we prefer signed and the signedness
3313 doesn't matter here.
3314 (get_next_display_element, next_element_from_display_vector):
3315 Use int, not EMACS_INT, when int is wide enough.
3316 (start_hourglass): Use duration_to_sec_usec to do proper
3317 overflow checking on durations.
3318 * xfaces.c (Fbitmap_spec_p):
3319 Check that fixnums are in proper range for system types.
3320 (compare_fonts_by_sort_order):
3321 Avoid mishandling comparisons due to subtraction overflow.
3322 (Fx_family_fonts, realize_basic_faces):
3323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 Don't assume fixnum fits in int.
3326 Use SAFE_ALLOCA_LISP, not alloca.
3327 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3328 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3329 (face_at_buffer_position, face_for_overlay_string)
3330 (face_at_string_position):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3333 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3335 Check that fixnums are in proper range for system types.
3336 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3337 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3339 (Fx_change_window_property): Don't assume fixnums fit in int.
3340 * xfont.c (xfont_chars_supported):
3341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3342 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3343 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3345 * xml.c (parse_region):
3346 * xrdb.c (magic_file_p):
3347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3348 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3349 (x_get_local_selection, x_reply_selection_request)
3350 (x_handle_selection_request, wait_for_property_change):
3351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3352 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3353 short is wide enough.
3354 (x_send_client_event): Don't assume fixnum fits in int.
3355 * xterm.c (x_x_to_emacs_modifiers):
3356 Don't assume EMACS_INT overflows nicely into int.
3357 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3359 (handle_one_xevent): NATNUMP can eval its arg twice.
3360 (x_connection_closed):
3361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3362 * xterm.h: Adjust decls to match defn changes elsewhere.
3363 (struct scroll_bar): Use struct vectorlike_header
3364 rather than rolling our own approximation.
3365 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3367 2012-05-25 Glenn Morris <rgm@gnu.org>
3369 * lisp.mk (lisp): Update for more files being compiled now.
3371 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3373 * lread.c: Remove `read_pure' which makes no difference.
3374 (read_pure): Remove var.
3375 (unreadpure): Remove function.
3376 (readevalloop): Don't call read_list with -1 flag.
3377 (read1, read_vector): Don't test read_pure any more.
3378 (read_list): Simplify.
3380 * fileio.c, character.h: Minor style tweaks.
3382 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3384 * window.h (clip_changed): Remove useless declaration.
3386 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3388 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3389 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3391 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3394 This directory predates autoconf and is no longer needed nowadays.
3395 Move its few remaining bits of functionality to where they're needed.
3396 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3397 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3398 * m/template.h: Remove.
3399 * Makefile.in (M_FILE): Remove. All uses removed.
3400 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3401 * lisp.h (USE_LSB_TAG):
3402 * mem-limits.h (EXCEEDS_LISP_PTR):
3403 Use VAL_MAX, not VALBITS, in #if.
3404 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3405 (EMACS_UINT): Define unconditionally now.
3406 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3407 (BITS_PER_EMACS_INT): New constants, replacing
3408 what used to be in config.h, but not useful in #if.
3409 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3410 define them any more.
3411 (VAL_MAX): New macro.
3413 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3414 BITS_PER_EMACS_INT, in #if.
3415 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3416 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3417 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3418 * s/ms-w32.h (DATA_START):
3419 Move here from removed file m/intel386.h.
3420 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3421 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3423 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3425 Assume C89 or later.
3426 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3427 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3429 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3430 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3431 * textprop.c, tparam.c (NULL): Remove.
3432 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3433 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3434 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3435 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3436 * xterm.c (input_signal_count): Assume volatile works.
3438 2012-05-21 Ken Brown <kbrown@cornell.edu>
3440 * xgselect.c (xg_select): Fix first argument in call to 'select'
3443 2012-05-20 Ken Brown <kbrown@cornell.edu>
3445 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3446 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3448 2012-05-19 Ken Brown <kbrown@cornell.edu>
3450 * xfns.c (x_in_use): Remove `static' qualifier.
3451 * xterm.h (x_in_use): Declare.
3452 * xgselect.c: Include xterm.h.
3453 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3454 and `display_arg' (bug#9754).
3456 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3458 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3460 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3461 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3463 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3465 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3467 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3468 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3470 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3471 reference to image_cache->refcount.
3472 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3474 2012-05-17 Juri Linkov <juri@jurta.org>
3476 * search.c (Fword_search_regexp, Fword_search_backward)
3477 (Fword_search_forward, Fword_search_backward_lax)
3478 (Fword_search_forward_lax): Move functions to isearch.el
3479 (bug#10145, bug#11381).
3481 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3483 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3485 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3487 * lread.c (init_obarray): Declare Qt and Qnil as special.
3489 2012-05-14 Glenn Morris <rgm@gnu.org>
3491 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3492 Put "libexec" before "bin", for the sake of init_callproc_1.
3494 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3496 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3498 * unexaix.c: Port to more-recent AIX compilers.
3499 (report_error, report_error_1, make_hdr, copy_sym)
3500 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3501 Make arguments const char *, not char *, to avoid violations of C
3502 standard and to fix some AIX warnings reported by Gilles Pion.
3504 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3506 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3507 already have overlays loaded.
3508 (handle_single_display_spec): Before returning without displaying
3509 fringe bitmap, synchronize the bidi iterator with the main display
3510 iterator, by calling iterate_out_of_display_property.
3511 (iterate_out_of_display_property): Detect buffer iteration by
3512 testing that it->string is a Lisp string.
3513 (get_next_display_element): When the current object is exhausted,
3514 and there's something on it->stack, call set_iterator_to_next to
3515 proceed with what's on the stack, instead of returning zero.
3516 (set_iterator_to_next): If called at the end of a Lisp string,
3517 proceed to consider_string_end without incrementing string
3518 position. Don't increment display vector index past the end of
3519 the display vector. (Bug#11417)
3520 (pos_visible_p): Don't report a position visible when move_it_to
3521 stopped at the last line of window, which happens to be scanned
3522 backwards by the bidi iteration. (Bug#11464)
3524 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3526 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3527 and right-margin display specs even if the spec is invalid or we
3528 are on a TTY, and thus unable to display on the fringes.
3529 That's because the text with the property will not be displayed anyway,
3530 so we need to signal to the caller that this is a "replacing"
3531 display spec. This fixes display when the spec is invalid or we
3534 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3536 * unexaix.c (make_hdr): Fix typo in prototype.
3537 This bug broke the build on AIX. Problem reported by Gilles Pion.
3539 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3541 * keyboard.c (kbd_buffer_get_event): Read special events also in
3542 batch mode. (Bug#11415)
3544 2012-05-12 Glenn Morris <rgm@gnu.org>
3546 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3548 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3550 * lisp.mk (lisp): Add newcomment.elc.
3552 2012-05-12 Glenn Morris <rgm@gnu.org>
3554 * Makefile.in (MKDIR_P): New, set by configure.
3555 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3557 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3559 Remove unused function hourglass_started.
3560 * dispextern.h (hourglass_started):
3561 * w32fns.c (hourglass_started):
3562 * xdisp.c (hourglass_started): Remove.
3564 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3566 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3567 Update dependencies.
3569 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3571 * xgselect.c (xg_select): Put maxfds+1 into a var.
3572 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3574 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3576 2012-05-10 Dave Abrahams <dave@boostpro.com>
3578 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3579 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3581 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3583 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3584 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3585 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3586 Initialize xd_registered_buses.
3588 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3590 Untag more efficiently if USE_LSB_TAG.
3591 This is based on a proposal by YAMAMOTO Mitsuharu in
3592 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3593 For an admittedly artificial (nth 8000 longlist) benchmark on
3594 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3595 Emacs's overall text size by 1%.
3596 * lisp.h (XUNTAG): New macro.
3597 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3598 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3599 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3600 * eval.c (Fautoload):
3601 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3602 * frame.h (XFRAME): Use XUNTAG.
3604 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3605 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3606 Remove unportable assumptions about print widths of types like
3608 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3609 intptr_t when converting between pointer and integer, to avoid GCC
3610 warnings about wrong width.
3612 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3614 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3615 stack for each reader_thread, instead of defaulting to 8MB
3616 determined by the linker. This avoids failures in creating
3617 subprocesses on Windows 7, see the discussion in this thread:
3618 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3620 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3622 Fix up display of the *Minibuf-0* buffer in the mini window.
3623 * keyboard.c (read_char): Don't clear the echo area if there's no
3625 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3626 contents of *Minibuf-0*) if there's no message displayed in its stead.
3628 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3630 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3633 2012-05-06 Chong Yidong <cyd@gnu.org>
3635 * lisp.mk (lisp): Update.
3637 2012-05-05 Jim Meyering <meyering@redhat.com>
3639 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3641 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3643 * data.c (PUT_ERROR): New macro.
3644 (syms_of_data): Use it. Add new error type `user-error'.
3645 * undo.c (user_error): New function.
3646 (Fprimitive_undo): Use it.
3647 * print.c (print_error_message): Adjust print style for `user-error'.
3648 * keyboard.c (user_error): New function.
3649 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3651 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3653 Do not limit current-time-string to years 1000..9999.
3654 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3655 (Fcurrent_time_string): Support any year that is supported by the
3656 underlying localtime representation. Don't use asctime, as it
3657 has undefined behavior for years outside the range -999..9999.
3659 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3661 Fix race conditions involving setenv, gmtime, localtime, asctime.
3662 Without this fix, interrupts could mess up code that uses these
3663 nonreentrant functions, since setting TZ invalidates existing
3664 tm_zone or tzname values, and since most of these functions return
3665 pointers to static storage.
3666 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3667 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3668 Grow the critical sections to include not just invoking
3669 localtime/gmtime, but also accessing these functions' results
3670 including their tm_zone values if any, and any related TZ setting.
3671 (format_time_string): Last arg is now struct tm *, not struct tm **,
3672 so that the struct tm is saved in the critical section.
3673 All callers changed. Simplify allocation of initial buffer, partly
3674 motivated by the fact that memory allocation needs to be outside
3675 the critical section.
3677 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3679 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3680 with RESET_INTERVAL.
3682 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3683 Remove duplicated buffer name initialization.
3685 2012-05-02 Jim Meyering <jim@meyering.net>
3687 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3689 * xfns.c (x_window): Use xstrdup (Bug#11375).
3691 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3693 * xdisp.c (pos_visible_p): If already at a newline from the
3694 display string before the 'while' loop, don't walk back the glyphs
3695 from it3.glyph_row. Solves assertion violation when the display
3696 string begins with a newline (egg.el). (Bug#11367)
3698 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3700 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3703 2012-05-01 Glenn Morris <rgm@gnu.org>
3705 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3706 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3707 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3708 All were removed before 23.1.
3710 * dispnew.c: Remove HAVE_LIBNCURSES test;
3711 it is always true on relevant platforms.
3713 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3714 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3716 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3718 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3720 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3721 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3724 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3726 Do not avoid creating empty evaporating overlays (Bug#9642).
3727 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3728 That is, do not delete an evaporating overlay if it becomes
3729 empty after its bounds are adjusted to fit within its buffer.
3730 This fix caused other problems, and I'm reverting it until we get
3731 to the bottom of them.
3733 2012-04-27 Chong Yidong <cyd@gnu.org>
3735 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3737 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3739 * xdisp.c (pos_visible_p): If the window start position is beyond
3740 ZV, start the display from buffer beginning. Prevents assertion
3741 violation in init_iterator when the minibuffer window is scrolled
3744 * window.c (window_scroll_pixel_based): Likewise.
3746 2012-04-27 Chong Yidong <cyd@gnu.org>
3748 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3750 2012-04-27 Glenn Morris <rgm@gnu.org>
3752 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3753 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3755 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3757 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3758 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3760 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3762 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3763 display element, check also the underlying string or buffer
3764 character. (Bug#11341)
3766 * w32menu.c: Include w32heap.h.
3767 (add_menu_item): If the call to AppendMenuW (via
3768 unicode_append_menu) fails, disable Unicode menus only if we are
3769 running on Windows 9X/Me.
3771 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3773 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3774 (xgetint): Add missing shift for LSB tags.
3776 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3778 * keyboard.c (read_char): Don't wipe echo area for select window
3779 events: These might get delayed via `mouse-autoselect-window'
3782 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3784 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3785 manipulation of :loaded-from data.
3787 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3789 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3790 now a cons (bug#11311).
3792 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3794 Do not create empty overlays with the evaporate property (Bug#9642).
3795 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3796 if it becomes empty after its bounds are adjusted to fit within
3797 its buffer. Without this fix, in a nonempty buffer (let ((o
3798 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3799 yields an empty overlay that has the evaporate property, which is
3800 not supposed to happen.
3802 Fix minor GTK3 problems found by static checking.
3803 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3804 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3805 (struct _EmacsFixedClass, emacs_fixed_get_type):
3806 Move decls here from emacsgtkfixed.h, since they needn't be public.
3807 (emacs_fixed_get_type): Now static.
3808 (emacs_fixed_class_init): Omit unused local.
3809 (emacs_fixed_child_type): Remove; unused.
3810 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3811 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3812 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3813 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3814 (EMACS_FIXED_GET_CLASS): Remove; unused.
3815 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3817 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3818 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3820 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3822 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3823 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3824 (__malloc_size_t, __malloc_ptrdiff_t):
3825 Remove. All uses removed, replaced by the definiens if needed,
3826 since we can assume C89 or better now.
3827 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3828 (protect_malloc_state, align, get_contiguous_space)
3829 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3830 (malloc_atfork_handler_child, malloc_enable_thread)
3831 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3832 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3833 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3834 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3835 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3836 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3837 Define using prototypes, not old style.
3838 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3839 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3840 (align): Don't assume that signed integer overflow wraps around.
3841 Omit unused local var.
3842 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3843 (_free_internal_nolock, memalign, mallochook, reallochook):
3844 Omit no-longer-needed casts.
3845 (valloc): Use getpagesize, not __getpagesize.
3846 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3847 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3849 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3851 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3853 Move functions from C to Lisp. Make non-blocking method calls
3854 the default. Implement further D-Bus standard interfaces.
3856 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3857 (QCdbus_request_name_allow_replacement)
3858 (QCdbus_request_name_replace_existing)
3859 (QCdbus_request_name_do_not_queue)
3860 (QCdbus_request_name_reply_primary_owner)
3861 (QCdbus_request_name_reply_in_queue)
3862 (QCdbus_request_name_reply_exists)
3863 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3864 (QCdbus_registered_serial, QCdbus_registered_method)
3865 (QCdbus_registered_signal): New Lisp objects.
3866 (XD_DEBUG_MESSAGE): Use sizeof.
3867 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3868 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3869 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3870 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3871 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3872 (xd_signature, xd_append_arg): Allow float for integer types.
3873 (xd_get_connection_references): New function.
3874 (xd_get_connection_address): Rename from xd_initialize.
3875 Return cached address.
3876 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3877 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3879 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3880 Return number of refcounts.
3881 (Fdbus_get_unique_name): Make stronger parameter check.
3882 (Fdbus_message_internal): New defun.
3883 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3884 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3885 (Fdbus_send_signal, Fdbus_register_service)
3886 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3887 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3888 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3889 (Vdbus_compiled_version, Vdbus_runtime_version)
3890 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3891 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3892 (Vdbus_message_type_signal): New defvars.
3893 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3896 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3898 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3899 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3900 Do not assume ptrdiff_t is the same width as 'int'.
3902 * alloc.c: Handle unusual debugging option combinations.
3903 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3904 since the two debugging options are incompatible.
3905 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3907 (mem_init, mem_insert, mem_insert_fixup):
3908 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3909 (NEED_MEM_INSERT): Remove; no longer needed.
3911 2012-04-22 Leo Liu <sdl.web@gmail.com>
3913 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3915 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3917 * sysdep.c [__FreeBSD__]: Minor cleanups.
3918 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3919 Use Emacs indenting style more consistently. Avoid some casts.
3920 Use 'double' consistently rather than mixing 'float' and 'double'.
3922 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3924 * sysdep.c (list_system_processes, system_process_attributes):
3925 Add implementation for FreeBSD (Bug#5243).
3927 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3929 * lisp.mk (lisp): Update.
3931 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3933 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3934 It is never used otherwise.
3936 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3938 * print.c (print_preprocess): Only check print_depth if print-circle
3940 (print_object): Check for cycles even when print-circle is nil and
3941 print-gensym is t, but only check print_depth if print-circle is nil.
3943 2012-04-20 Chong Yidong <cyd@gnu.org>
3945 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3946 set the status to "failed" and ensure that sentinel is run.
3948 2012-04-20 Glenn Morris <rgm@gnu.org>
3950 * process.c (Fset_process_inherit_coding_system_flag)
3951 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3952 (Fmake_network_process, Fmake_serial_process): Doc fix.
3954 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3956 * xdisp.c (string_buffer_position_lim): Limit starting position to
3958 (set_cursor_from_row): If called for a mode-line or header-line
3959 row, return zero immediately.
3960 (try_cursor_movement): If inside continuation line, don't back up
3961 farther than the first row after the header line, if any.
3962 Don't consider the header-line row as "partially visible", even if
3963 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3965 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3967 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3970 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3971 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3973 configure: new option --enable-gcc-warnings (Bug#11207)
3974 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3975 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3976 (ALL_CFLAGS): Use new macros rather than old.
3977 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3978 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3979 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3980 -Wunused-result, -Wunused-variable. This should go away once
3981 the Emacs and Gnulib regex code is merged.
3982 (xmalloc, xrealloc): Now static.
3984 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3986 * dired.c (Fsystem_groups): Remove unused local.
3988 2012-04-17 Glenn Morris <rgm@gnu.org>
3990 * dired.c (Fsystem_users): Doc fix.
3992 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3994 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3995 (syms_of_dired): Add them.
3997 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3999 Fix minor alloc.c problems found by static checking.
4000 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4001 New extern decls, to avoid calling undeclared functions.
4002 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4003 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4004 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4005 (NEED_MEM_INSERT): New macro.
4006 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4007 Remove one incorrect comment and fix another.
4009 Fix minor ralloc.c problems found by static checking.
4010 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4011 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4012 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4013 (r_alloc_sbrk): Now static.
4015 Improve ralloc.c interface checking.
4016 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4017 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4018 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4019 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4020 [REL_ALLOC]: ... to here, to check interface.
4021 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4022 Remove decls. This fixes an "It stinks!".
4024 * alloc.c (which_symbols): Fix alignment issue / type clash.
4026 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4028 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4029 (struct Lisp_Misc_Any): Likewise.
4030 (struct Lisp_Free): Likewise.
4031 * alloc.c (union aligned_Lisp_Symbol): Define.
4032 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4033 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4034 (union aligned_Lisp_Misc): Define.
4035 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4036 aligned_Lisp_Misc instead of union Lisp_Misc.
4037 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4039 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4041 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4042 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4043 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4044 * s/netbsd.h, s/sol2-6.h:
4045 Remove definition of GC_MARK_STACK, since the default now works.
4046 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4047 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4048 no longer the default.
4049 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4051 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4053 * lread.c (lisp_file_lexically_bound_p):
4054 Fix hang at ";-*-\n" (bug#11238).
4056 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4058 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4059 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4061 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4063 * nsterm.m (constrainFrameRect): Always constrain when there is only
4064 one screen (Bug#10962).
4066 2012-04-13 Ken Brown <kbrown@cornell.edu>
4068 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4070 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4072 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4074 2012-04-11 Daniel Colascione <dancol@dancol.org>
4076 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4077 against is gone. It's better to use vfork now so that when Cygwin
4078 gains a new, working vfork, we use it automatically (bug#10398).
4080 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4082 * window.c (save_window_save): Obey window-point-insertion-type.
4084 2012-04-11 Glenn Morris <rgm@gnu.org>
4086 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4088 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4090 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4092 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4094 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4095 (force_quit_count): New var.
4096 (handle_interrupt): Use it.
4098 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4100 * w32.c (w32_delayed_load): Record the full path of the library
4101 being loaded (bug#10424).
4103 2012-04-09 Glenn Morris <rgm@gnu.org>
4105 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4106 not just in the obarray, before snarfing them. (Bug#11036)
4108 * Makefile.in ($(leimdir)/leim-list.el):
4109 Pass EMACS rather than BUILT_EMACS.
4111 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4113 * process.c (make_process):
4114 * process.h: Add integer `gnutls_handshakes_tried' member to
4117 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4118 Add convenience `GNUTLS_LOG2i' macro.
4120 * gnutls.c (gnutls_log_function2i): Convenience log function.
4121 (emacs_gnutls_read): Use new log functions,
4122 `gnutls_handshakes_tried' process member, and
4123 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4124 attempts per process (connection).
4126 2012-04-09 Chong Yidong <cyd@gnu.org>
4128 * eval.c (Fuser_variable_p, user_variable_p_eh)
4129 (lisp_indirect_variable): Functions deleted.
4130 (Fdefvar): Caller changed.
4132 * callint.c (Finteractive, Fcall_interactively):
4133 * minibuf.c (Fread_variable): Callers changed.
4135 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4137 * xdisp.c (set_cursor_from_row): If the display string appears in
4138 the buffer at position that is closer to point than the position
4139 after the display string, display the cursor on the first glyph of
4140 the display string. Fixes cursor display when a 'display' text
4141 property immediately follows invisible text. (Bug#11094)
4143 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4145 composite.c: use 'double' consistently
4146 * composite.c (get_composition_id): Use 'double' consistently
4147 instead of converting 'float' to 'double' and vice versa; this is
4148 easier to understand and avoids a GCC warning.
4150 2012-04-09 Glenn Morris <rgm@gnu.org>
4152 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4153 preparation for dumping it with emacs. (Bug#4789)
4154 (leimdir): New variable.
4155 ($(leimdir)/leim-list.el): New rule.
4156 (emacs$(EXEEXT)): Depend on leim-list.el.
4158 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4159 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4160 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4162 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4164 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4167 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4169 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4170 Remove unused local variable.
4172 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4174 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4175 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4176 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4177 objects, as mark_maybe_pointer will catch them otherwise.
4178 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4179 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4181 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4183 Fix typo that broke non-Windows builds.
4184 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4186 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4188 Support building on MS-Windows with libxml2.
4190 * makefile.w32-in (OBJ2): Add xml.$(O).
4191 (GLOBAL_SOURCES): Add xml.c.
4192 ($(BLD)/xml.$(O)): New dependency list.
4194 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4195 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4196 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4197 [!WINDOWSNT]: New macros.
4198 (init_libxml2_functions, libxml2_loaded_p): New functions.
4199 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4200 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4201 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4202 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4204 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4205 Call init_libxml2_functions before calling libxml2 functions.
4206 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4208 * emacs.c: Don't include libxml/parser.h.
4209 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4210 xmlCleanupParser directly.
4212 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4214 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4216 * indent.c (Fvertical_motion): If there is a display string at
4217 point, use it.vpos to compute how many lines to backtrack after
4218 move_it_to point. (Bug#11133)
4220 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4222 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4223 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4224 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4225 macros related to unification of CJK characters. For the details,
4226 see the discussion following the message here:
4227 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4229 2012-04-04 Chong Yidong <cyd@gnu.org>
4231 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4233 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4235 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4236 instead of alloca. (Bug#11138)
4238 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4240 * w32menu.c (is_simple_dialog): Properly check lisp types.
4243 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4245 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4246 position we get to after a call to move_it_to fails the
4247 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4248 only if we wind up in a string from display property. (Bug#11063)
4250 * window.c (Fdelete_other_windows_internal): Invalidate the row
4251 and column information about mouse highlight, so that redisplay
4252 restores it after reallocating the glyph matrices. (Bug#7464)
4254 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4255 string comes from a `display' text property, use the buffer
4256 position of that property as if we actually saw that position in
4258 (move_it_by_lines): Remove the assertion that
4259 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4260 violated when there's a before-string at the beginning of a line.
4263 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (append_space_for_newline): If the default face was
4266 remapped, use the remapped face for the appended newline.
4267 (extend_face_to_end_of_line): Use the remapped default face for
4268 extending the face to the end of the line.
4269 (display_line): Call extend_face_to_end_of_line when the default
4270 face was remapped. (Bug#11068)
4272 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4274 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4276 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4278 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4280 2012-03-27 Glenn Morris <rgm@gnu.org>
4282 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4285 2012-03-26 Kenichi Handa <handa@m17n.org>
4287 * dispextern.h (struct glyph): Fix previous change. Change the
4288 bit length of glyphless.ch to 25 (Bug#11082).
4290 2012-03-26 Chong Yidong <cyd@gnu.org>
4292 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4293 (command_loop_1): Use it; inhibit selection update for
4294 handle-select-window too (Bug#8996).
4296 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4298 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4300 2012-03-25 Kenichi Handa <handa@m17n.org>
4302 * dispextern.h (struct glyph): Change the bit length of
4303 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4305 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4307 * s/ms-w32.h (tzname): Include time.h before redirecting to
4308 _tzname. Fixes the MSVC build. (Bug#9960)
4310 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4312 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4315 * xterm.c (XTread_socket): Only modify handling_signal if
4316 !SYNC_INPUT. (Bug#11080)
4318 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4320 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4321 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4322 when fetching a multibyte character consumes more bytes than
4323 CHAR_BYTES returns, due to unification of CJK characters in
4324 string_char. (Bug#11073)
4326 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4328 * process.c (wait_reading_process_output): Handle pty disconnect
4329 by refraining from sending oneself a SIGCHLD (bug#10933).
4331 2012-03-22 Chong Yidong <cyd@gnu.org>
4333 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4335 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4336 Mark string as coming from a prefix property.
4337 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4338 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4340 2012-03-21 Chong Yidong <cyd@gnu.org>
4342 * xfaces.c (Vface_remapping_alist): Doc fix.
4344 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4346 * w32proc.c (Fw32_set_console_codepage)
4347 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4350 2012-03-20 Chong Yidong <cyd@gnu.org>
4352 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4353 to reflect default non-nil value of redisplay-dont-pause.
4355 2012-03-19 Kenichi Handa <handa@m17n.org>
4357 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4358 it fit in a valid range (Bug#11003).
4360 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4362 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4363 that is not from display property, accept the row as a "cursor
4364 row" if one of the string's character has a non-nil `cursor'
4365 property. Fixes cursor positioning when there are newlines in
4366 overlay strings, e.g. in icomplete.el. (Bug#11035)
4368 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4370 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4372 2012-03-12 Chong Yidong <cyd@gnu.org>
4374 * eval.c (inhibit_lisp_code): Rename from
4375 inhibit_window_configuration_change_hook; move from window.c.
4377 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4378 * window.c (run_window_configuration_change_hook)
4379 (syms_of_window): Callers changed.
4381 2012-03-11 Chong Yidong <cyd@gnu.org>
4383 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4385 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4387 2012-03-10 Chong Yidong <cyd@gnu.org>
4389 * frame.c (other_visible_frames): Don't assume the selected frame
4390 is visible (Bug#10955).
4392 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4394 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4396 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4398 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4399 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4402 2012-03-03 Glenn Morris <rgm@gnu.org>
4404 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4406 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4408 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4409 position past the first glyph_row that ends at ZV. (Bug#10902)
4410 (redisplay_window, next_element_from_string): Fix typos in
4412 (redisplay_window): Pass to move_it_vertically the margin in
4413 pixels, not in screen lines.
4415 2012-03-02 Glenn Morris <rgm@gnu.org>
4417 * buffer.c (buffer-list-update-hook): Doc fix.
4419 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4421 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4422 push_it before setting up the iterator for the first overlay
4423 string, even if we have an empty string loaded.
4424 (next_overlay_string): If there's an empty string on the iterator
4425 stack, pop the stack. (Bug#10903)
4427 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4429 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4430 Suggested by Stefan Monnier in
4431 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4432 * alloc.c (widen_to_Lisp_Object): New static function.
4433 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4434 and widening them to Lisp_Objects. This would work even if
4435 USE_LSB_TAG is defined and wide integers are used, which might
4436 happen in a future version of Emacs.
4438 2012-02-25 Chong Yidong <cyd@gnu.org>
4440 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4443 * xselect.c (Fx_selection_exists_p): Doc fix.
4444 (x_clipboard_manager_save_all): Print an informative message
4445 before saving to clipboard manager.
4447 2012-02-24 Chong Yidong <cyd@gnu.org>
4449 * keyboard.c (process_special_events): Handle all X selection
4450 requests in kbd_buffer, not just the next one (Bug#8869).
4452 2012-02-23 Chong Yidong <cyd@gnu.org>
4454 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4455 call when setting menu-bar-lines and tool-bar-lines parameters.
4456 (unwind_create_frame_1): New helper function.
4458 * window.c (inhibit_window_configuration_change_hook): New var.
4459 (run_window_configuration_change_hook): Obey it.
4460 (syms_of_window): Initialize it.
4462 2012-02-22 Chong Yidong <cyd@gnu.org>
4464 * xterm.c (x_draw_image_relief): Add missing type check for
4465 Vtool_bar_button_margin (Bug#10743).
4467 2012-02-21 Chong Yidong <cyd@gnu.org>
4469 * fileio.c (Vfile_name_handler_alist): Doc fix.
4471 * buffer.c (Fget_file_buffer): Protect against invalid file
4472 handler return value.
4474 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4476 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4477 when computing $valmask.
4479 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4480 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4481 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4482 It's useless in that case, and it can cause problems on hosts
4483 that allocate halves of EMACS_INT values separately.
4484 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4485 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4486 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4487 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4488 it avoids undefined behavior on hosts where shifting right by more
4489 than the word width has undefined behavior.
4491 2012-02-19 Chong Yidong <cyd@gnu.org>
4493 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4494 (Funhandled_file_name_directory, Ffile_name_as_directory)
4495 (Fdirectory_file_name, Fexpand_file_name)
4496 (Fsubstitute_in_file_name): Protect against invalid file handler
4497 return values (Bug#10845).
4499 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4501 * .gdbinit (pitx): Fix incorrect references to fields of the
4504 2012-02-17 Chong Yidong <cyd@gnu.org>
4506 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4508 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4510 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4511 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4513 2012-02-15 Chong Yidong <cyd@gnu.org>
4515 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4516 marked as special. Also, starting docstrings with * is obsolete.
4518 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4520 * gnutls.c (emacs_gnutls_write): Fix last change.
4522 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4524 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4527 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4529 * keymap.c (Fsingle_key_description): Handle char ranges.
4531 2012-02-12 Chong Yidong <cyd@gnu.org>
4533 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4534 as that creates a dangerous corner case.
4536 * window.c (Fdelete_window_internal): Invalidate the mouse
4537 highlight (Bug#9904).
4539 2012-02-12 Glenn Morris <rgm@gnu.org>
4541 * xselect.c (Fx_own_selection_internal)
4542 (Fx_get_selection_internal, Fx_disown_selection_internal)
4543 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4544 * nsselect.m (Fx_own_selection_internal)
4545 (Fx_disown_selection_internal, Fx_selection_exists_p)
4546 (Fx_selection_owner_p, Fx_get_selection_internal):
4547 Sync docs and argument specs with the xselect.c versions.
4549 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4551 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4553 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4555 * w32select.c (Fx_selection_exists_p): Sync doc string and
4556 argument list with xselect.c. (Bug#10783)
4558 * w16select.c (Fx_selection_exists_p): Sync doc string and
4559 argument list with xselect.c. (Bug#10783)
4561 2012-02-10 Glenn Morris <rgm@gnu.org>
4563 * fns.c (Fsecure_hash): Doc fix.
4565 2012-02-09 Kenichi Handa <handa@m17n.org>
4567 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4569 2012-02-07 Chong Yidong <cyd@gnu.org>
4571 * buffer.c (Fbuffer_local_variables)
4572 (buffer_lisp_local_variables): Handle unbound vars correctly;
4573 don't let Qunbound leak into Lisp.
4575 2012-02-07 Glenn Morris <rgm@gnu.org>
4577 * image.c (Fimagemagick_types): Doc fix.
4579 * image.c (imagemagick-render-type): Change it from a lisp object
4580 to an integer. Move the doc here from the lisp manual.
4581 Treat all values not equal to 0 the same.
4583 2012-02-06 Chong Yidong <cyd@gnu.org>
4585 * doc.c (store_function_docstring): Avoid applying docstring of
4586 alias to base function (Bug#2603).
4588 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4590 * .gdbinit (pp1, pv1): Remove redundant defines.
4593 2012-02-04 Chong Yidong <cyd@gnu.org>
4595 * nsterm.m: Declare a global (Bug#10694).
4597 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4599 * w32.c (get_emacs_configuration_options):
4600 Include --enable-checking, if specified, in the return value.
4602 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4604 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4605 after rounding frame sizes. (Bug#9723)
4607 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4609 * keyboard.c (adjust_point_for_property): Don't position point
4610 before BEGV. (Bug#10696)
4612 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4614 Handle overflow when computing char display width (Bug#9496).
4615 * character.c (char_width): Return EMACS_INT, not int.
4616 (char_width, c_string_width): Check for overflow when
4617 computing the width; this is possible now that individual
4618 characters can have unbounded width. Problem introduced
4619 by merge from Emacs 23 on 2012-01-19.
4621 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4623 * dbusbind.c (Fdbus_register_method): Mention the return value
4624 :ignore in the docstring.
4626 2012-02-02 Glenn Morris <rgm@gnu.org>
4628 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4630 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4631 Unconditionally set to t. (Bug#10673)
4632 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4633 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4634 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4636 2012-02-02 Kenichi Handa <handa@m17n.org>
4638 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4639 0, do not call append_composite_glyph.
4641 2012-02-02 Kenichi Handa <handa@m17n.org>
4643 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4645 (x_produce_glyphs): If the component of a composition is a null
4646 string, set it->pixel_width to 1 to avoid zero-width glyph.
4648 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4650 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4651 first 2 arguments are identical. This makes inserting large
4652 output from a subprocess an order of magnitude faster on
4653 MS-Windows, where all sbrk'ed memory is always contiguous.
4655 2012-01-31 Glenn Morris <rgm@gnu.org>
4657 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4658 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4659 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4661 2012-01-29 Glenn Morris <rgm@gnu.org>
4663 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4665 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4667 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4669 2012-01-28 Chong Yidong <cyd@gnu.org>
4671 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4673 2012-01-26 Chong Yidong <cyd@gnu.org>
4675 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4677 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4678 repeat counts (Bug#10507).
4680 2012-01-26 Glenn Morris <rgm@gnu.org>
4682 * lread.c (syms_of_lread): Doc fix.
4684 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4686 * coding.c (encode_designation_at_bol): Change return value to
4689 2012-01-25 Chong Yidong <cyd@gnu.org>
4691 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4693 2012-01-21 Chong Yidong <cyd@gnu.org>
4695 * floatfns.c (Fcopysign): Make the second argument non-optional,
4696 since nil is not allowed anyway.
4698 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4700 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4701 (send_process): Likewise.
4703 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4705 * window.c (save_window_save, Fcurrent_window_configuration)
4706 (Vwindow_persistent_parameters): Do not use Qstate.
4707 Rewrite doc-strings.
4709 2012-01-19 Kenichi Handa <handa@m17n.org>
4711 * character.c (char_width): New function.
4712 (Fchar_width, c_string_width, lisp_string_width):
4713 Use char_width (Bug#9496).
4715 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4717 * window.c (Vwindow_persistent_parameters): New variable.
4718 (Fset_window_configuration, save_window_save): Handle persistent
4721 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4723 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4724 thrashing the stack of the thread. (Bug#9087)
4726 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4728 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4730 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4732 * xdisp.c (rows_from_pos_range): Handle the case where the
4733 highlight ends on a newline. (Bug#10464)
4734 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4735 he end column for display of highlight that ends on a newline
4738 2012-01-11 Glenn Morris <rgm@gnu.org>
4740 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4741 from load-path also when installation-directory is nil. (Bug#10208)
4743 2012-01-10 Glenn Morris <rgm@gnu.org>
4745 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4747 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4748 Update template values to be closer to their typical values these days.
4750 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4752 * xdisp.c (rows_from_pos_range): Accept additional argument
4753 DISP_STRING, and accept any glyph in a row whose object is that
4754 string as eligible for mouse highlight. Fixes mouse highlight of
4755 display strings from overlays. (Bug#10464)
4757 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4759 emacs: fix an auto-save permissions race condition (Bug#10400)
4760 * fileio.c (auto_saving_dir_umask): New static var.
4761 (Fmake_directory_internal): Use it.
4762 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4763 creating the directory. The old code temporarily assigns
4764 too-generous permissions to the directory.
4765 (do_auto_save_eh): Clear it.
4766 (Fdo_auto_save): Catch all errors, not just file errors, so
4767 that the var is always cleared.
4769 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4771 * search.c (scan_buffer): Pass character positions to
4772 know_region_cache, not byte positions. (Bug#6540)
4774 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4776 * w32.c (sys_rename): Report EXDEV when rename of a directory
4777 fails because the target is on another logical disk. (Bug#10284)
4779 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4781 * xterm.c (x_embed_request_focus): New function.
4783 * xterm.h: Add prototype.
4785 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4787 2012-01-05 Glenn Morris <rgm@gnu.org>
4789 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4791 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4793 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4794 Load gnutls_transport_set_lowat only if GnuTLS version is below
4796 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4797 GnuTLS versions below 2.11.1.
4799 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4801 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4802 to the doc string advising against its use for altering the way
4803 windows are scrolled.
4805 2011-12-28 Kenichi Handa <handa@m17n.org>
4807 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4808 coding-system ASCII compatible only when it does not produce BOM
4809 on encoding (Bug#10383).
4811 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4813 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4815 (create_and_show_popup_menu): Always use menu_position_func for
4818 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4820 * callint.c (Fcall_interactively): Don't truncate prompt string.
4822 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4824 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4825 property that ends at ZV, so that the bidi iteration could be
4826 resumed from there (after widening). (Bug#10360)
4828 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4830 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4832 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4834 * nsterm.m (x_free_frame_resources):
4835 Release f->output_data.ns->miniimage.
4836 (ns_index_color): Fix indentation. Do not retain
4837 color_table->colors[i].
4839 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4842 * nsfns.m (x_set_background_color): Assign return value from
4843 ns_index_color to face-background instead of NSColor*.
4844 (ns_implicitly_set_icon_type): Fix indentation.
4845 Change assignment in for loop to comparison.
4847 * emacs.c (ns_pool): New variable.
4848 (main): Assign ns_pool.
4849 (Fkill_emacs): Call ns_release_autorelease_pool.
4851 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4852 autorelease fdesc, release fdAttrs and tdict.
4853 (ns_get_covering_families): Release charset.
4854 (ns_findfonts): Release NSFontDescriptor created with new.
4855 (ns_uni_to_glyphs): Fix indentation.
4856 (setString): Release attrStr before assigning new value.
4858 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4860 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4862 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4863 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4865 2011-12-18 David Reitter <reitter@cmu.edu>
4867 * nsterm.m (ns_term_init): Subscribe for notifications
4868 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4869 to method trackingNotification in EmacsMenu.
4871 * nsmenu.m (trackingMenu): New variable.
4872 (trackingNotification): New method (from Aquamacs).
4873 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4874 from Aquamacs (Bug#7030).
4876 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4878 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4879 (symbol_to_nsstring): Fix indentation.
4880 (ns_symbol_to_pb): New function.
4881 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4882 (Fns_rotate_cut_buffers_internal): Remove.
4883 (Fns_store_selection_internal): Rename from
4884 Fns_store_cut_buffer_internal.
4885 (ns_get_foreign_selection, Fx_own_selection_internal)
4886 (Fx_disown_selection_internal, Fx_selection_exists_p)
4887 (Fns_get_selection_internal, Fns_store_selection_internal):
4888 Use ns_symbol_to_pb and check if return value is nil.
4889 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4890 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4891 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4892 renamed to Sns_store_selection_internal.
4893 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4894 and remove this function.
4895 (ns_handle_selection_clear): Remove, never used.
4896 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4899 2011-12-17 Ken Brown <kbrown@cornell.edu>
4901 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4902 GID is unknown (Bug#10257).
4904 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4906 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4907 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4908 which caused a build failure on GNU/Linux IA-64. This problem was
4909 introduced by my 2011-10-07 patch.
4911 2011-12-15 Juri Linkov <juri@jurta.org>
4913 * image.c (imagemagick_error): New function. (Bug#10112)
4914 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4915 Use `imagemagick_error' where ImageMagick functions return
4917 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4920 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4922 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4923 fill background (Bug#8992).
4925 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4927 * window.c (Vwindow_combination_resize)
4928 (Vwindow_combination_limit): Use t instead of non-nil in
4930 (Vrecenter_redisplay): Add first sentence of doc-string on
4932 (Frecenter): Fix doc-string typo.
4934 2011-12-11 Kenichi Handa <handa@m17n.org>
4936 * coding.c (Funencodable_char_position): Pay attention to the
4937 buffer text relocation (Bug#9389).
4939 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4941 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4942 gtk_init (Bug#10100).
4944 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4946 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4947 IT->string is nil. (Bug#10263)
4949 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4951 * nsterm.h (x_free_frame_resources): Declare.
4953 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4954 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4956 * nsterm.h (ns_get_defaults_value): Declare.
4958 * nsterm.m (ns_default): Call ns_get_defaults_value.
4960 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4962 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4965 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4967 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4968 that where the value of an _OBJC_* symbol points to is in the .bss
4969 section (Bug#10240).
4971 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4973 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4974 after the loop to call ccl_driver at least once (Bug#8619).
4976 2011-12-08 Kenichi Handa <handa@m17n.org>
4978 * ftfont.c (get_adstyle_property): Fix previous change
4981 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4983 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4984 dirs from the default value of EMACSLOADPATH (bug#10208).
4986 2011-12-07 Glenn Morris <rgm@gnu.org>
4988 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4989 installation and source directories as well. (Bug#10208)
4991 2011-12-06 Chong Yidong <cyd@gnu.org>
4993 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4995 2011-12-06 Glenn Morris <rgm@gnu.org>
4997 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4998 as an error, not just -1. (Bug#10217)
5000 2011-12-05 Chong Yidong <cyd@gnu.org>
5002 * keyboard.c (process_special_events): New function.
5003 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5005 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5007 * coding.c (encode_designation_at_bol): Don't use uninitialized
5008 local variable (Bug#9318).
5010 2011-12-05 Kenichi Handa <handa@m17n.org>
5012 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5013 return Qnil (Bug#8046, Bug#10193).
5015 2011-12-05 Kenichi Handa <handa@m17n.org>
5017 * coding.c (encode_designation_at_bol): New args charbuf_end and
5018 dst. Return the number of produced bytes. Callers changed.
5019 (coding_set_source): Return how many bytes coding->source was
5021 (coding_set_destination): Return how many bytes
5022 coding->destination was relocated.
5023 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5024 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5026 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5028 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5029 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5032 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5034 The following changes are to fix Bug#9318.
5036 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5037 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5038 (encode_coding_iso_2022, encode_coding_sjis)
5039 (encode_coding_big5, encode_coding_charset): Use the above macros.
5041 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5043 * lisp.h (process_quit_flag): Fix external declaration.
5045 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5047 Don't macro-inline non-performance-critical code.
5048 * eval.c (process_quit_flag): New function.
5049 * lisp.h (QUIT): Use it.
5051 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5053 * nsfns.m (get_geometry_from_preferences): New function.
5054 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5056 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5058 * emacs.c (Qkill_emacs): Define.
5059 (syms_of_emacs): Initialize it.
5060 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5061 Qquit_flag to `kill-emacs' instead.
5062 (quit_throw_to_read_char): Add parameter `from_signal'.
5063 All callers changed. Call Fkill_emacs if requested and safe.
5064 * lisp.h (QUIT): Call Fkill_emacs if requested.
5066 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5068 * widget.c (update_wm_hints): Return if wmshell is null.
5069 (widget_update_wm_size_hints): New function.
5071 * widget.h (widget_update_wm_size_hints): Declare.
5073 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5074 widget_update_wm_size_hints (Bug#10104).
5076 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5078 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5079 before a newline, prepare the bidi iterator for consuming the
5080 newline, and keep the current paragraph direction. (Bug#10183)
5081 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5083 2011-12-02 Juri Linkov <juri@jurta.org>
5085 * search.c (Fword_search_regexp): New Lisp function created from
5086 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5087 (Fword_search_backward, Fword_search_forward)
5088 (Fword_search_backward_lax, Fword_search_forward_lax):
5089 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5090 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5092 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5094 * fileio.c (Finsert_file_contents): Move after-change-function call
5095 to before the "handled:" label, since all "goto handled" appear in
5096 cases where the *-change-functions have already been properly called
5099 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5101 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5102 waiting for input. (Bug#10169)
5104 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5106 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5107 verifies glyph row's hash code--we have just reallocated the
5108 glyphs, so their contents can be complete garbage. (Bug#10164)
5110 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5112 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5114 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5116 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5117 attributes are tested _before_ calling verify_row_hash, to protect
5118 against GCC re-ordering of the tests. (Bug#10164)
5120 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5122 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5124 * xterm.c (handle_one_xevent): Only set async_visible and friends
5125 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5126 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5127 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5129 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5131 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5132 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5133 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5134 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5135 All uses changed to use GCPRO1 etc.
5136 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5137 Revert to old implementation (i.e., before 2011-03-11).
5139 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5141 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5142 of scroll runs so as to avoid assigning disabled bogus rows and
5143 unnecessary graphics copy operations.
5145 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5147 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5148 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5149 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5150 (malloc, free, realloc, calloc): Redirect to e_* only when
5153 * lisp.h (GCTYPEBITS): Move before first use.
5154 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5155 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5156 this macro definition.
5158 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5161 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5163 * gtkutil.c (xg_create_frame_widgets):
5164 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5165 present with Gtk+ 2.0.
5167 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5169 * fileio.c (Finsert_file_contents): Undo previous change; see
5170 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5172 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5174 Rename locals to avoid shadowing.
5175 * fileio.c (Finsert_file_contents):
5176 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5177 * process.c (wait_reading_process_output):
5178 Rename inner 'proc' to 'p' to avoid shadowing.
5179 Indent for consistency with usual Emacs style.
5181 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5183 * xdisp.c (redisplay_window): If cursor row is not fully visible
5184 after recentering, and scroll-conservatively is set to a large
5185 number, scroll window by a few more lines to make the cursor fully
5186 visible and out of scroll-margin. (Bug#10105)
5187 (start_display): Don't move to the next line if the display should
5188 start at a newline that is part of a display vector or an overlay
5191 2011-11-24 Juri Linkov <juri@jurta.org>
5193 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5194 after the `MagickPingImage' call. (Bug#10112)
5196 2011-11-23 Chong Yidong <cyd@gnu.org>
5198 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5200 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5202 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5203 making another buffer current. (Bug#10114)
5205 2011-11-23 Glenn Morris <rgm@gnu.org>
5207 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5209 2011-11-23 Chong Yidong <cyd@gnu.org>
5211 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5212 using it (Bug#5984).
5214 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5216 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5217 and header-lines, as they don't have one computed for them.
5220 * .gdbinit (prow): Make displayed values more self-explaining.
5221 Add row's hash code.
5223 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5225 * process.c (wait_reading_process_output): Fix asynchrounous
5226 GnuTLS socket handling on some versions of the GnuTLS library.
5227 (wait_reading_process_output): Add comment and URL.
5229 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5231 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5233 2011-11-21 Chong Yidong <cyd@gnu.org>
5235 * window.c (Fnext_window, Fprevious_window): Doc fix.
5237 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5239 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5241 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5243 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5245 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5247 * window.c (Fset_window_combination_limit): Rename argument
5249 (Vwindow_combination_limit): Remove "status" from doc-string.
5251 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5253 * m/ibms390.h: Remove.
5254 * m/ibms390x.h: Don't include "ibms390.h".
5256 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5258 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5259 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5261 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5263 * casetab.c (Fset_case_table):
5264 * charset.c (Fcharset_after): Fix typos.
5266 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5268 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5269 Otherwise, valgrind does not work on some platforms.
5270 Problem reported by Andreas Schwab in
5271 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5272 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5273 is set, removing the need for VIRT_ADDRESS_VARIES.
5274 (PURE_P): Use a more-efficient implementation that needs just one
5275 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5276 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5277 to 4 (xorl, subq, cmpq, setbe).
5278 * alloc.c (pure): Always extern now, since that's the
5279 VIRT_ADDR_VARIES behavior.
5280 (PURE_POINTER_P): Use a single comparison, not two, for
5281 consistency with the new puresize.h.
5282 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5283 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5284 Remove VIRT_ADDR_VARIES no longer needed.
5286 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5288 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5289 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5290 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5291 behave as if the cursor position were at the window margin.
5293 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5294 and the cursor position is out of bounds, behave as if the cursor
5295 position were at the window margin. (Bug#10075)
5297 2011-11-18 Chong Yidong <cyd@gnu.org>
5299 * window.c (Fwindow_combination_limit): Make first argument
5300 non-optional, since it is meaningless for live windows like the
5303 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5305 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5307 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5309 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5310 (graft_intervals_into_buffer): Simplify.
5312 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5314 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5315 hash values of the two rows.
5316 (copy_row_except_pointers): Preserve the used[] arrays and the
5317 hash values of the two rows. (Bug#10035)
5318 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5320 * xdisp.c (row_hash): New function, body extracted from
5321 compute_line_metrics.
5322 (compute_line_metrics): Call row_hash, instead of computing the
5325 * dispnew.c (verify_row_hash): Call row_hash for computing the
5326 hash code of a row, instead of duplicating code from xdisp.c.
5328 * dispextern.h (row_hash): Add prototype.
5330 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5332 * frame.c (delete_frame): Don't delete the terminal when the last
5333 X frame is closed if emacs is built with GTK toolkit.
5335 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5337 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5339 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5341 * window.c (Vwindow_splits): Rename to
5342 Vwindow_combination_resize. Suggested by Juri Linkov.
5343 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5346 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5348 * nsfns.m (Fns_font_name):
5349 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5351 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5353 * window.h (window): Rename slot "nest" to "combination_limit".
5354 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5355 (Fset_window_nest): Rename to Fset_window_combination_limit.
5356 (Vwindow_nest): Rename to Vwindow_combination_limit.
5357 (recombine_windows, make_parent_window, make_window)
5358 (Fsplit_window_internal, saved_window)
5359 (Fset_window_configuration, save_window_save): Rename all
5360 occurrences of window_nest to window_combination_limit.
5362 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5364 * image.c (imagemagick_load_image): Fix typo.
5366 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5368 * xdisp.c (display_line): Move the call to
5369 highlight_trailing_whitespace before the call to
5370 compute_line_metrics, since the latter needs to see the final
5371 faces of all the glyphs to compute ROW's hash value.
5372 Fixes assertion violations in row_equal_p. (Bug#10035)
5374 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5376 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5377 just return (bug#10044).
5379 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5381 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5382 with user-defined heap size. Bump the default size of the temacs
5383 heap to 27MB, to avoid memory warning when running temacs.
5384 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5386 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5387 current_matrix and desired_matrix. (Bug#9990)
5388 (verify_row_hash) [XASSERTS]: New function.
5389 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5390 that the hash value of glyph rows is correct.
5392 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5394 * window.h (window): Remove splits slot.
5395 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5396 (Fdelete_other_windows_internal, make_parent_window)
5397 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5398 (Fset_window_configuration, save_window_save): Don't deal with
5399 split status of windows.
5400 (saved_window): Remove splits slot.
5401 (Vwindow_splits): Rewrite doc-string.
5403 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5405 * xfns.c (unwind_create_frame):
5406 * nsfns.m (unwind_create_frame):
5407 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5408 Vframe_list (Bug#9999).
5410 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5412 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5414 2011-11-11 Kenichi Handa <handa@m17n.org>
5416 * callproc.c (Fcall_process): Set the member dst_multibyte of
5419 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5421 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5422 avoid a crash (bug#9496).
5424 2011-11-09 Chong Yidong <cyd@gnu.org>
5426 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5427 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5429 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5431 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5433 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5435 Avoid some portability problems by eschewing 'extern inline' functions.
5436 The trivial performance wins aren't worth the portability hassles; see
5437 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5439 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5440 (window_box_width, window_box_left, window_box_left_offset)
5441 (window_box_right, window_box_right_offset): Undo previous change,
5442 by removing the "extern"s.
5443 * intervals.c (adjust_intervals_for_insertion)
5444 (adjust_intervals_for_deletion): Undo previous change,
5445 making these static again.
5446 (offset_intervals, temp_set_point_both, temp_set_point)
5447 (copy_intervals_to_string): No longer inline.
5448 * xdisp.c (window_text_bottom_y, window_box_width)
5449 (window_box_height, window_box_left_offset)
5450 (window_box_right_offset, window_box_left, window_box_right)
5451 (window_box): No longer inline.
5453 2011-11-08 Chong Yidong <cyd@gnu.org>
5455 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5456 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5457 Signal an error if not a live window.
5458 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5459 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5461 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5463 * lisp.h (syms_of_abbrev): Remove declaration.
5464 Reported by CHENG Gao <chenggao@royau.me>.
5466 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5468 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5469 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5470 of temacs in GUI mode.
5472 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5474 * window.h: Declare delete_all_child_windows instead of
5475 delete_all_subwindows.
5476 * window.c (Fwindow_nest, Fset_window_nest)
5477 (Fset_window_new_total, Fset_window_new_normal)
5478 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5479 (delete_all_subwindows): Rename to delete_all_child_windows.
5480 (Fdelete_other_windows_internal, Fset_window_configuration):
5481 Call delete_all_child_windows instead of delete_all_subwindows.
5482 * frame.c (delete_frame): Call delete_all_child_windows instead
5483 of delete_all_subwindows.
5485 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5487 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5488 This is also needed for porting to any host where GC_MARK_STACK is
5489 not GC_MAKE_GCPROS_NOOPS.
5490 (which_symbols): Use it.
5492 2011-11-07 Kenichi Handa <handa@m17n.org>
5494 * coding.c (coding_set_destination): Check coding->src_pos only
5495 when coding->src_object is a buffer (bug#9910).
5497 * process.c (send_process): Set the member src_multibyte of coding
5498 to 0 (bug#9911) when sending a unibyte text.
5500 * callproc.c (Fcall_process): Set the member src_multibyte of
5501 process_coding to 0 (bug#9912).
5503 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5505 * xmenu.c (cleanup_widget_value_tree): New function.
5506 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5507 calling free_menubar_widget_value_tree directly (Bug#9830).
5509 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5511 Fix some portability problems with 'inline'.
5512 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5513 (window_box_width, window_box_left, window_box_left_offset)
5514 (window_box_right, window_box_right_offset): Declare extern.
5515 Otherwise, these inline functions do not conform to C99 and
5516 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5517 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5518 * intervals.c (adjust_intervals_for_insertion)
5519 (adjust_intervals_for_deletion): Now extern, because otherwise the
5520 extern inline functions 'offset_intervals' couldn't refer to it.
5521 (static_offset_intervals): Remove.
5522 (offset_intervals): Rewrite using the old contents of
5523 static_offset_intervals. The old version didn't conform to C99
5524 because an extern inline function contained a reference to an
5525 identifier with static linkage.
5527 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5529 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5532 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5534 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5535 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5536 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5537 return Qleft_to_right.
5539 2011-11-06 Chong Yidong <cyd@gnu.org>
5541 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5542 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5543 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5544 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5545 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5546 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5547 (Fwindow_vscroll): Doc fix.
5548 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5549 argument, since it makes no sense to pass a live window and for
5550 consistency with window-child.
5552 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5554 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5557 2011-11-05 Jason Rumney <jasonr@gnu.org>
5559 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5560 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5562 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5563 bitwise arithmetic preventing use of unicode-sip and non-truetype
5566 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5568 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5571 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5572 initialization code to keep similarity to xfns.c after changes
5575 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5577 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5578 (unwind_create_frame): New function (Bug#9943).
5579 (Fx_create_frame): Restructure code to be more similar to the one in
5580 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5581 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5582 Move terminal->reference_count++ just before making the frame official
5585 * nsterm.m (x_free_frame_resources): New function.
5586 (x_destroy_window): Move code to x_free_frame_resources.
5588 * xfns.c (unwind_create_frame): Fix comment.
5589 (Fx_create_frame, x_create_tip_frame):
5590 Move terminal->reference_count++ just before making the frame
5591 official. Move initialization of image_cache_refcount and
5592 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5594 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5596 Support MSVC build with newer versions of Visual Studio.
5597 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5598 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5601 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5602 which are not supported by MSVC.
5603 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5604 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5606 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5608 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5610 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5612 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5614 Support MSVC build with newer versions of Visual Studio.
5615 * w32.c: Don't include w32api.h for MSVC.
5616 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5618 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5619 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5620 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5621 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5623 (alloca) [_MSC_VER]: Define to _alloca.
5625 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5627 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5629 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5631 * xdisp.c (note_mouse_highlight): If either of
5632 previous/next-single-property-change returns nil, treat that as
5633 the beginning or the end of the buffer. (Bug#9955)
5635 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5637 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5638 label is not null (Bug#9951).
5639 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5642 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5644 * window.c (Fwindow_body_size): Mention in the doc string that the
5645 return value is in frame's canonical units. (Bug#9949)
5647 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5649 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5651 * w32fns.c (unwind_create_frame): If needed, free the glyph
5652 matrices of the partially constructed frame. (Bug#9943)
5653 * xfns.c (unwind_create_frame): Likewise.
5655 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5658 Don't stop backward scan on the continuation glyph, even though
5659 its CHARPOS is positive.
5660 (mouse_face_from_buffer_pos, note_mouse_highlight):
5661 Rename cover_string to disp_string.
5663 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5665 * window.c (temp_output_buffer_show): Don't use
5666 Vtemp_buffer_show_specifiers.
5667 (Vtemp_buffer_show_specifiers): Remove unused variable.
5669 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5671 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5672 past the beginning of the current glyph matrix.
5674 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5676 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5677 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5678 HAVE_GTK3 (Bug#9869).
5680 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5681 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5683 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5685 * xterm.c: Declare x_handle_net_wm_state to return int.
5686 (handle_one_xevent): Check if we are iconified but don't have
5687 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5688 (get_current_wm_state): Return non-zero if not hidden,
5689 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5690 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5691 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5692 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5694 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5696 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5697 so that this new function doesn't get optimized away by a
5698 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5700 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5702 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5704 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5706 Fix the `xbytecode' command.
5707 * .gdbinit (xprintbytestr): New command.
5708 (xwhichsymbols): Rename from `which'; all callers changed.
5709 (xbytecode): Print the byte-code string as well.
5711 2011-10-29 Kim Storm <storm@cua.dk>
5713 * alloc.c (which_symbols): New function.
5715 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5717 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5720 2011-10-29 Glenn Morris <rgm@gnu.org>
5722 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5723 Not clear what it was for, and it causes various bugs. (Bug#9839)
5725 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5727 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5728 possible random value that matches one of those tested as
5729 condition to clear the mouse face.
5731 2011-10-28 Chong Yidong <cyd@gnu.org>
5733 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5735 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5737 * window.c (make_window): Initialize phys_cursor_on_p.
5739 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5741 * lisp.h (struct Lisp_Symbol): Update comments.
5743 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5745 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5747 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5749 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5750 <oslsachem@gmail.com> for helping to debug this.
5752 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5753 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5754 (g_b_init_get_glyph_outline_w): New static variables.
5755 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5756 (GetGlyphOutlineW_Proc): New typedefs.
5757 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5758 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5760 (w32font_open_internal, compute_metrics):
5761 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5762 instead of calling the "wide" APIs directly.
5764 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5766 * w32.h (syms_of_w32font): Add prototype.
5768 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5770 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5771 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5772 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5773 (Fmove_to_window_line): Doc fix.
5775 2011-10-27 Chong Yidong <cyd@gnu.org>
5777 * process.c (make_process): Set gnutls_state to NULL.
5779 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5780 non-NULL, regardless of GNUTLS_INITSTAGE.
5781 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5782 an error. Set process slots as soon as we allocate them.
5784 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5786 2011-10-27 Chong Yidong <cyd@gnu.org>
5788 * gnutls.c (emacs_gnutls_deinit): New function.
5789 Deallocate credentials structures as well as calling gnutls_deinit.
5790 (Fgnutls_deinit, Fgnutls_boot): Use it.
5792 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5793 (deactivate_process): Call emacs_gnutls_deinit.
5795 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5797 * image.c (x_create_x_image_and_pixmap):
5798 * w32.c (sys_rename, w32_delayed_load):
5799 * w32font.c (fill_in_logfont):
5800 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5802 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5804 * w32fns.c (w32_default_color_map): New function,
5805 extracted from Fw32_default_color_map.
5806 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5808 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5810 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5812 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5814 * keyboard.c (test_undefined): New function (bug#9751).
5815 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5817 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5819 * sysdep.c (init_sys_modes): Fix the check for the controlling
5820 terminal (Bug#6649).
5822 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5824 * dispextern.h (struct bidi_it): New member next_en_type.
5826 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5827 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5828 current character, check also for next_en_type being WEAK_EN.
5829 (bidi_resolve_weak): Don't enter the expensive loop if the current
5830 position is before next_en_pos. Record the bidi type of the first
5831 non-ET, non-BN character we find, in addition to its position.
5832 (bidi_level_of_next_char): Invalidate next_en_type when
5833 next_en_pos is over-stepped.
5835 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5837 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5838 * editfns.c: Rewrite current-time-zone so that it invokes
5839 the equivalent of (format-time-string "%Z") to get the time zone name.
5840 This fixes a bug when the time zone name contains characters that
5841 need converting from the system time locale to Emacs internal format.
5842 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5843 that patch fixed format-time-string to do the conversion, but
5844 I forgot to fix current-time-zone.
5845 (format_time_string): New function, containing most of
5846 what Fformat_time_string used to contain.
5847 (Fformat_time_string): Rewrite in terms of format_time_string.
5848 This doesn't change this function's behavior.
5849 (current-time-zone): Rewrite to use format_time_string.
5850 This fixes the bug reported by Michael Schierl in
5851 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5852 Jason Rumney's 2007-06-07 change worked around this bug, but
5854 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5856 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5858 * xdisp.c (start_display): If the character at POS is displayed
5859 via a display vector, reset IT->current.dpvec_index to zero.
5860 (try_window_reusing_current_matrix): If a line ends in a display
5861 vector or the next line starts in a display vector, continue
5862 redrawing the window even though the character position of
5863 start_row was reached.
5866 2011-10-18 Chong Yidong <cyd@gnu.org>
5868 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5869 with nobreak-char-display too.
5871 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5873 Fix part 3 of bug#9771.
5874 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5875 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5876 non-neutral characters if the current character is a paragraph
5877 separator (a.k.a. Newline). This avoids running the same
5878 expensive loop twice, once when we consume the preceding newline
5879 and the other time when the line actually needs to be displayed.
5880 Avoid the loop when we see neutrals on the base embedding level
5881 following a character whose directionality is the same as the
5882 paragraph's. This avoids running the expensive loop when a line
5883 ends in a long sequence of neutrals, like control characters.
5884 Add assertion against STRONG_AL type. Slightly rearrange code
5885 that determines the type of a neutral given the first non-neutral
5887 (bidi_level_of_next_char): Set next_en_pos to zero when
5888 invalidating its info.
5890 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5892 * xdisp.c (push_display_prop): Determine whether to record string
5893 or buffer position by IT->string, not by IT->method. Allow
5894 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5895 (move_it_vertically_backward): Don't look for character position
5896 immediately after the newline when in a continuation line.
5899 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5901 * window.c (coordinates_in_window): Rewrite and delabelize
5902 vertical border check. (Bug#5357) (Bug#9618)
5904 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5906 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5907 errors in XSetWindowBorder (bug#9310).
5909 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5911 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5912 avoid crash when xmalloc overrun checking is enabled.
5914 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5916 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5917 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5918 cursor motion with <left> and <right> arrow keys.
5920 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5921 some callers set that themselves.
5923 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5925 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5926 display string and the previous row comes from the same string and
5927 is empty. (Bug#9739) (Bug#9738)
5929 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5931 * doc.c (get_doc_string): Encode file name (bug#9735).
5933 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5935 * bidi.c (bidi_level_of_next_char):
5936 * xdisp.c (get_visually_first_element): Remove old incorrect
5937 comments regarding the Unicode Line Separator character.
5939 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5941 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5943 * alloc.c (Fgc_status): Do not access beyond zombies array
5944 boundary if nzombies > MAX_ZOMBIES.
5945 * alloc.c (dump_zombies): Add missing format specifier.
5947 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5949 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5950 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5952 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5953 Some packages use them to denote characters with modifiers.
5955 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5957 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5958 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5959 matching a pp-number. Rename parameter var to var1.
5961 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5963 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5965 2011-10-08 Glenn Morris <rgm@gnu.org>
5967 * callint.c (Fcall_interactively): Give a more explicit error for the
5968 'c' case with a non-character input. (Bug#8479)
5970 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5972 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5974 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5975 lines that are hscrolled on the left.
5977 * dispnew.c (buffer_posn_from_coords): Account for a possible
5978 presence of header-line. (Bug#4426)
5980 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5982 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5983 Don't advertise functionality which we discourage or doesn't work.
5985 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5987 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5988 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5989 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5990 this makes Emacs dump core during garbage collection on rare
5991 occasions. sizeof is obviously inferior to offsetof here, so
5992 stick with offsetof.
5993 (GC_POINTER_ALIGNMENT): New macro.
5994 (mark_memory): Omit 3rd (offset) arg; caller changed.
5995 Don't assume EMACS_INT alignment is the same as pointer alignment.
5997 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5999 * keyboard.c (read_key_sequence_remapped): New var.
6000 (read_key_sequence): Compute remapping in the right buffer.
6001 (command_loop_1): Use read_key_sequence's remapping directly.
6003 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6005 * dired.c (file_name_completion): Don't expand file name.
6006 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6007 before checking file name handler.
6009 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6010 they've been requested explicitly (bug#9591).
6012 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6014 * keymap.c (Fsingle_key_description): Use make_specified_string
6015 instead of build_string to build string from push_key_description.
6018 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6020 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6021 This fixes a Y2038 bug on 64-bit hosts.
6022 * buffer.c (reset_buffer):
6023 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6024 (Fclear_buffer_auto_save_failure):
6025 Use 0, not -1, to represent an unset failure time, since time_t
6026 might not be signed.
6028 Remove dependency on glibc malloc internals.
6029 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6030 Move back here from lisp.h, but with their new implementations.
6031 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6032 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6033 * charset.c (charset_table_init): New static var.
6034 (syms_of_charset): Use it instead of xmalloc. This removes a
6035 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6036 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6037 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6038 Move back to alloc.c.
6039 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6040 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6042 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6044 * nsterm.m (windowDidResize): Call x_set_window_size only when
6045 ns_in_resize is true. Otherwise set pixelwidth/height and
6046 call change_frame_size (Bug#9628).
6048 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6050 Port --enable-checking=all to Fedora 14 x86-64.
6051 * charset.c (syms_of_charset): Also account for glibc malloc's
6052 internal overhead when calculating the initial malloc maximum.
6054 Port --enable-checking=all to Fedora 14 x86.
6055 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6057 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6058 (overrun_check_realloc, overrun_check_free):
6059 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6060 That way, xmalloc returns a properly-aligned pointer even if
6061 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6062 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6063 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6064 into account when calculating the initial malloc maximum.
6065 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6066 Move here from alloc.c, so that charset.c can use it too.
6067 Properly align; the old code wasn't right for common 32-bit hosts
6068 when configured with --enable-checking=all.
6069 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6070 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6072 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6074 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6077 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6079 * xdisp.c (compute_display_string_end): If there's no display
6080 string at CHARPOS, return -1.
6082 * bidi.c (bidi_fetch_char): When compute_display_string_end
6083 returns a negative value, treat the character as a normal
6084 character not covered by a display string. (Bug#9624)
6086 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6088 * lread.c (Fread_from_string): Fix typo in docstring.
6090 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6092 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6093 newline, reseat the iterator instead of bidi-iterating there one
6094 character at a time. (Bug#9610)
6095 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6096 TO_CHARPOS if the bidi iterator is at base embedding level.
6098 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6100 * lread.c (readevalloop): Use correct code for NBSP.
6101 (read1): Likewise. (Bug#9608)
6103 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6105 * dbusbind.c (Fdbus_register_signal): When service is not
6106 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6108 2011-09-25 Glenn Morris <rgm@gnu.org>
6110 * buffer.c (truncate-lines): Doc fix.
6112 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6114 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6115 (Fset_window_next_buffers): Doc fix.
6117 2011-09-24 Glenn Morris <rgm@gnu.org>
6119 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6121 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6123 Fix minor problems found by static checking.
6124 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6125 * indent.c (Fvertical_motion): Fix == vs = typo.
6127 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6129 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6130 Default value is now t. Doc fix.
6132 * indent.c (Fvertical_motion): Compute and apply the overshoot
6133 logic when moving up, not only when moving down. Fix the
6134 confusing name and values of the it_overshoot_expected variable;
6135 logic changes accordingly. (Bug#9254) (Bug#9549)
6137 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6138 CHARPOS is covered by a display string which includes newlines.
6139 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6140 is covered by a display string with embedded newlines.
6142 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6144 * dbusbind.c (Fdbus_register_signal): Add match rule to
6145 Vdbus_registered_objects_table. (Bug#9581)
6146 (Fdbus_register_method, Vdbus_registered_objects_table):
6149 2011-09-24 Jim Meyering <meyering@redhat.com>
6151 do not ignore write error for any output size
6152 The previous change was incomplete.
6153 While it makes emacs --batch detect the vast majority of stdout
6154 write failures, errors were still ignored whenever the output size is
6155 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6156 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6157 && echo FAIL: ignored write error
6158 FAIL: ignored write error
6159 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6160 && echo FAIL: ignored write error
6161 FAIL: ignored write error
6162 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6164 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6166 * emacs.c (Fkill_emacs): In noninteractive mode exit
6167 non-successfully if a write error occurred on stdout. (Bug#9574)
6169 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6171 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6174 * dispextern.h (struct it): Update the comment documenting what
6177 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6179 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6180 a display string, extend search for cursor position to end of row.
6181 (find_row_edges): If the row ends in a newline from a display
6182 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6183 Handle the case of a display string with multiple newlines.
6184 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6185 non-empty line. Fixes confusing cursor motion with arrow keys at
6186 the beginning of a line that starts with whitespace.
6188 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6190 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6193 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6195 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6198 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6200 * xdisp.c (display_line): Record maximum and minimum buffer
6201 positions even if no glyphs were produced (e.g., by a zero-width
6202 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6203 buffer positions that will be removed from the glyph row because
6205 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6206 column is beyond frame width: don't subtract 1 "pixel" when
6207 computing width of the stretch.
6208 (reseat_at_next_visible_line_start): Undo the change made on
6209 2011-09-17 that saved paragraph information and restored it after
6210 the call to `reseat'. (Bug#9545)
6212 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6214 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6215 and turn window cursor on if cleared (Bug#9415).
6217 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6219 * search.c (boyer_moore): Take unibyte characters from pattern
6220 literally. (Bug#9458)
6222 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6224 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6226 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6228 Fix minor problem found by static checking.
6229 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6230 initialized, to pacify gcc -Wuninitialized.
6232 * fileio.c: Report proper errno when syscall falls.
6233 (Finsert_file_contents): Save and restore errno,
6234 so that report_file_error outputs the correct diagnostic.
6235 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6237 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6239 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6241 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6243 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6244 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6246 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6248 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6249 about the current paragraph and restore it after the call to reseat.
6251 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6252 (bidi_find_paragraph_start): Search back for paragraph beginning
6253 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6254 (bidi_move_to_visually_next): Only trigger paragraph-related
6255 computations when the last character is a newline or at EOB, not
6256 just any NEUTRAL_B. (Bug#9470)
6258 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6259 truncated lines if point is covered by a display string. (Bug#9524)
6261 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6263 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6264 (cons_to_x_long): New function.
6265 (lisp_data_to_selection_data): Use it. Correct the test for
6266 short-versus-long data; it was negated. Break out of vector
6267 loop, for efficiency, when a long datum is discovered.
6269 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6271 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6273 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6275 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6276 GCC PR/17406) by declaring this function with external scope.
6278 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6280 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6281 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6283 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6285 * editfns.c (Fformat): Correctly handle text properties on "%%".
6287 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6289 * xterm.c (x_draw_composite_glyph_string_foreground):
6290 * w32term.c (x_draw_composite_glyph_string_foreground):
6291 * term.c (encode_terminal_code):
6292 * composite.c (composition_update_it, get_composition_id):
6293 * xdisp.c (get_next_display_element)
6294 (fill_composite_glyph_string): Add comments about special meaning
6295 of TAB characters in a composition.
6297 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6299 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6300 This occurs when processing a multibyte format.
6301 Problem reported by Wolfgang Jenker.
6303 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6305 * xdisp.c (try_cursor_movement): Only check for exact match if
6306 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6308 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6310 Remove unused external symbols.
6311 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6312 * xdisp.c (calc_pixel_width_or_height): Now static.
6313 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6314 * indent.c (check_display_width):
6315 * w32term.c: Fix comment to match code.
6316 * xterm.c, xterm.h (x_catching_errors): Remove.
6318 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6320 * xselect.c: Use signed conversions more consistently (Bug#9498).
6321 (selection_data_to_lisp_data): Assume incoming selection data are
6322 signed integers, not unsigned. This is to be consistent with
6323 outgoing selection data, which was modified to use signed integers
6324 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6325 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6326 expects long, not unsigned long.
6328 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6330 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6331 computation of loop end. Reported by Johan Bockgård
6334 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6336 * frame.c (Fother_visible_frames_p): Function deleted.
6338 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6340 * indent.c (compute_motion): Process display vector front to back
6341 rather than the other way around. (Bug#2496)
6343 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6345 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6347 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6349 * minibuf.c (Fread_from_minibuffer): Doc fix.
6351 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6353 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6354 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6356 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6358 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6359 value for non-existent files.
6361 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6363 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6364 set its "size" to -1. This will set the modtime_size field of
6365 the corresponding buffer to -1, which is what
6366 verify-visited-file-modtime expects for files that do not exist.
6369 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6371 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6373 * lisp.h: ... from here. push_key_description is no longer
6374 defined in keyboard.c, so its declaration should not be in
6375 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6376 logically belongs with push_key_description.
6378 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6380 * buffer.h: Include <sys/types.h> instead of <time.h>.
6381 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6382 Problem reported by Herbert J. Skuhra.
6384 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6386 * xml.c (parse_region): Make the parsing work for
6387 non-comment-starting XML files again (bug#9144).
6389 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6391 * image.c (gif_load): Fix calculation of bottom and right corner.
6394 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6396 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6397 redisplay in small windows.
6399 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6401 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6403 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6405 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6406 Operate on live windows only.
6408 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6410 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6412 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6414 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6415 only under bidi iteration.
6417 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6419 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6421 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6423 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6424 Without this fix, the command to link temacs failed due to an
6425 undefined symbol __builtin_isnan. This is because
6426 /usr/include/iso/math_c99.h #defines isnan(x) to
6427 __builtin_isnan(x), but the bundled gcc, which identifies itself
6428 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6430 * floatfns.c (isnan): #undef, and then #define to a clone of
6432 (Fisnan): Always define, since it's always available now.
6433 (syms_of_floatfns): Always define isnan at the Lisp level.
6435 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6437 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6439 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6441 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6442 The previous code assumed that file offsets (off_t values) fit in
6443 EMACS_INT variables, which is not true on typical 32-bit hosts.
6444 The code messed up by falsely reporting buffer overflow in cases
6445 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6446 when "big" contains more than 2**29 bytes, even though this
6447 inserts just one byte and does not overflow the buffer.
6448 (Finsert_file_contents): Store file offsets as off_t
6449 values, not as EMACS_INT values. Check for overflow when
6450 converting between EMACS_INT and off_t. When checking for
6451 buffer overflow or for overlap, take the offsets into account.
6452 Don't use EMACS_INT for small values where int suffices.
6453 When checking for overlap, fix a typo: ZV was used where
6454 ZV_BYTE was intended.
6455 (Fwrite_region): Don't assume off_t fits into 'long'.
6456 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6458 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6460 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6462 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6464 sprintf-related integer and memory overflow issues (Bug#9412).
6466 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6467 (esprintf, exprintf, evxprintf): New functions.
6468 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6469 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6470 (modify_event_symbol): Do not assume that the length of
6471 name_alist_or_stem is safe to alloca and fits in int.
6472 (Fexecute_extended_command): Likewise for function name and binding.
6473 (Frecursion_depth): Wrap around reliably on integer overflow.
6474 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6475 since some callers pass EMACS_INT values.
6476 (Fsingle_key_description): Don't crash if symbol name contains more
6477 than MAX_ALLOCA bytes.
6478 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6479 (get_minibuffer): Arg is now EMACS_INT, not int.
6480 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6481 (esprintf, exprintf, evxprintf): New decls.
6482 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6484 * dbusbind.c (signature_cat): New function.
6485 (xd_signature, Fdbus_register_signal):
6486 Do not overrun buffer; instead, report string overflow.
6488 * dispnew.c (add_window_display_history): Don't overrun buffer.
6489 Truncate instead; this is OK since it's just a log.
6491 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6492 even if the time zone offset is outlandishly large.
6493 Don't mishandle offset == INT_MIN.
6495 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6496 when creating daemon; the previous buffer-overflow check was incorrect.
6498 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6499 which has the guts of the old verror function.
6501 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6502 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6504 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6505 (font_unparse_xlfd): Don't blindly alloca long strings.
6506 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6507 fits in int, when using sprintf. Use single snprintf to count
6508 length of string rather than counting it via multiple sprintfs;
6509 that's simpler and more reliable.
6510 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6511 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6512 sprintf, in case result does not fit in int.
6514 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6515 (fontset_from_font): Print it.
6517 * frame.c (tty_frame_count): Now printmax_t, not int.
6518 (make_terminal_frame, set_term_frame_name): Print it.
6519 (x_report_frame_params): In X, window IDs are unsigned long,
6520 not signed long, so print them as unsigned.
6521 (validate_x_resource_name): Check for implausibly long names,
6522 and don't assume name length fits in 'int'.
6523 (x_get_resource_string): Don't blindly alloca invocation name;
6524 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6527 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6528 (xg_check_special_colors, xg_set_geometry):
6529 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6531 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6532 Use esprintf, not sprintf, in case result does not fit in int.
6534 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6535 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6536 it as a large positive number.
6537 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6538 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6540 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6541 in case result does not fit in int.
6543 * print.c (float_to_string): Detect width overflow more reliably.
6544 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6545 buffer overrun. Don't assume list length fits in 'int'. Treat
6546 print length of 0 as 0, not as infinity; to be consistent with other
6547 uses of print length in this function. Don't overflow print length
6548 index. Don't assume hash table size fits in 'long', or that
6549 vectorlike size fits in 'unsigned long'.
6551 * process.c (make_process): Use printmax_t, not int, to format
6552 process-name gensyms.
6554 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6556 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6557 to avoid potential buffer overrun.
6559 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6560 if X resource line is longer than 512 bytes.
6562 * xfns.c (x_window): Make sprintf buffer a bit bigger
6563 to avoid potential buffer overrun.
6565 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6567 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6569 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6571 Integer overflow fixes for scrolling, etc.
6572 Without these, Emacs silently mishandles large integers sometimes.
6573 For example, "C-u 4294967297 M-x recenter" was treated as if
6574 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6576 * xdisp.c (try_window_id): Check Emacs fixnum range before
6577 converting to 'int'.
6579 * window.c (window_scroll_line_based, Frecenter):
6580 Check that an Emacs fixnum is in range before assigning it to 'int'.
6581 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6582 values converted from Emacs fixnums.
6583 (Frecenter): Don't wrap around a line count if it is out of 'int'
6584 range; instead, treat it as an extreme value.
6585 (Fset_window_configuration, compare_window_configurations):
6586 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6588 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6589 that can exceed INT_MAX. Check that EMACS_INT value is in range
6590 before assigning it to the (possibly-narrower) index.
6591 (match_limit): Don't assume that a fixnum can fit in 'int'.
6593 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6596 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6597 (Fvertical_motion): Don't wrap around LINES values that don't fit
6598 in 'int'. Instead, treat them as extreme values. This is good
6599 enough for windows, which can't have more than INT_MAX lines anyway.
6601 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603 * Require libxml/parser.h to avoid compilation warning.
6605 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6607 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6608 since this reportedly can destroy thread storage.
6610 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6612 * syntax.c (find_defun_start): Update all cache variables if
6613 exiting early (Bug#9401).
6615 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6617 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6619 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6620 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6621 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6623 * term.c (tty_append_glyph): New function.
6624 (produce_stretch_glyph): Static function and its prototype deleted.
6626 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6629 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6631 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6632 when checking :margin (Bug#9390).
6633 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6634 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6635 so that the name doesn't mislead. All uses changed.
6637 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6639 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6642 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6644 * xdisp.c (move_it_to): Don't bail out early when reaching
6645 position beyond to_charpos, if we are scanning backwards.
6646 (move_it_vertically_backward): When DY == 0, make sure we get to
6647 the first character in the line after the newline.
6649 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6651 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6652 (ccl_driver): Do not generate an out-of-range pointer.
6653 (Fccl_execute_on_string): Remove unnecessary check for
6654 integer overflow, noted by Stefan Monnier in
6655 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6656 Remove a FIXME that didn't need fixing.
6657 Simplify the newly-introduced buffer reallocation code.
6659 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6661 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6663 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6665 Integer and memory overflow issues (Bug#9196).
6667 * doc.c (get_doc_string): Rework so that
6668 get_doc_string_buffer_size is the actual buffer size, rather than
6669 being 1 less than the actual buffer size; this makes xpalloc more
6672 * image.c (x_allocate_bitmap_record, cache_image):
6673 * xselect.c (Fx_register_dnd_atom):
6674 Simplify previous changes by using xpalloc.
6676 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6677 since either will do and ptrdiff_t is convenient with xpalloc.
6679 * charset.c (charset_table_size)
6680 (struct charset_sort_data.priority): Now ptrdiff_t.
6681 (charset_compare): Don't overflow if priorities differ greatly.
6682 (Fsort_charsets): Don't assume list length fits in int.
6683 Check for size-calculation overflow when allocating sort data.
6684 (syms_of_charset): Allocate an initial charset table that is
6685 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6687 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6689 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6690 The actual value is always <= INT_MAX, and leaving it unsigned made
6691 overflow checking harder.
6693 * dispextern.h (struct glyph_matrix.rows_allocated)
6694 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6695 with xpalloc. The values are still always <= INT_MAX.
6697 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6699 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6700 (SAFE_NALLOCA): New macro.
6702 * region-cache.c (struct boundary.pos, find_cache_boundary)
6703 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6704 (set_cache_region, invalidate_region_cache)
6705 (revalidate_region_cache, know_region_cache, region_cache_forward)
6706 (region_cache_backward, pp_cache):
6707 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6708 so that ptrdiff_t * can be passed to xpalloc.
6709 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6710 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6711 (pp_cache): Don't assume cache_len fits in int.
6712 * region-cache.h: Adjust extern decls to match.
6714 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6715 EMACS_INT, since either will do, for xpalloc.
6717 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6718 (xnmalloc, xnrealloc, xpalloc): New functions.
6720 * bidi.c (bidi_shelve_header_size): New constant.
6721 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6722 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6724 * bidi.c (bidi_cache_shrink):
6725 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6727 Don't update size of array until after memory allocation succeeds,
6728 because xmalloc/xrealloc may not return.
6729 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6730 now that we have proper integer overflow checking.
6731 (record_overlay_string, overlay_strings): Catch overflows when
6732 calculating size of overlay_str_buf.
6734 * callproc.c (Fcall_process): Check for size overflow when
6735 calculating size of args2.
6736 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6737 Normally we prefer signed values, but sticking with ptrdiff_t would
6738 require adding more-complicated checks.
6740 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6741 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6742 Redo buffer-overflow calculations to avoid integer overflow.
6743 Add a FIXME comment where memory seems to be over-allocated.
6745 * character.c (Fstring): Check for size-calculation overflow.
6747 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6748 unnecessary integer overflow. Check for size overflow.
6749 (encode_coding_object): Don't update size until xmalloc succeeds.
6751 * composite.c (get_composition_id): Check for overflow in glyph
6752 length calculations.
6754 Integer and memory overflow fixes for display code.
6755 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6756 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6757 (scrolling_window): Check for overflow in size calculations.
6758 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6759 Don't assume glyph table len fits in int.
6760 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6761 (row_table_size): Now ptrdiff_t, not int.
6762 (scrolling_window): Avoid overflow in size calculations.
6763 Don't update size until allocation succeeds.
6764 * fns.c (concat): Check for overflow in size calculations.
6765 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6766 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6767 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6769 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6770 (get_doc_string): Check for size calculation overflow.
6771 Don't update size until allocation succeeds.
6772 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6773 EMACS_INT, where ptrdiff_t will do.
6774 (Fsubstitute_command_keys): Check for string overflow.
6776 * editfns.c (set_time_zone_rule): Don't assume environment length
6778 (message_length): Now ptrdiff_t, not int.
6779 (Fmessage_box): Don't update size until allocation succeeds.
6780 Don't assume message length fits in int.
6781 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6783 * emacs.c (main): Do not reallocate argv, since there is a null at
6784 the end that can be overwritten, and this way there's no need to
6785 worry about size-calculation overflow.
6786 (sort_args): Check for size-calculation overflow.
6788 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6790 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6792 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6793 (x_set_scroll_bar_width, x_figure_window_size):
6794 Check for integer overflow.
6795 (x_set_alpha): Do not assume XINT fits in int.
6797 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6798 This is for the members text_lines, text_cols, total_lines, total_cols,
6799 where the system imposes an 'int' limit.
6801 * fringe.c (Fdefine_fringe_bitmap):
6802 Don't update size until alloc works.
6804 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6805 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6807 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6808 Check for size-calculation overflow.
6809 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6810 do, as we prefer signed integers.
6811 (id_to_widget.max_size, id_to_widget.used)
6812 (xg_store_widget_in_map, xg_remove_widget_from_map)
6813 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6814 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6815 Use and return ptrdiff_t, not int.
6816 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6817 * gtkutil.h: Change prototypes to match the above.
6819 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6820 are duplicate now that they've been promoted to lisp.h.
6821 (x_allocate_bitmap_record, x_alloc_image_color)
6822 (make_image_cache, cache_image, xpm_load):
6823 Don't update size until alloc is done.
6824 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6826 Check for size calculation overflow.
6827 (ct_colors_allocated_max): New constant.
6828 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6831 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6832 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6833 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6834 Use ptrdiff_t, not int, to count maps.
6835 (read_char_minibuf_menu_prompt): Check for overflow in size
6836 calculations. Don't update size until allocation succeeds.
6837 Redo calculations to avoid overflow.
6838 * keyboard.h: Change prototypes to match the above.
6840 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6842 (current_minor_maps): Check for size calculation overflow.
6843 * keymap.h: Change prototypes to match the above.
6845 * lread.c (read1, init_obarray): Don't update size until alloc done.
6847 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6848 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6850 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6851 Now ptrdiff_t, not int.
6852 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6853 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6855 * process.c (Fnetwork_interface_list): Check for overflow
6856 in size calculation.
6858 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6860 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6861 overflow. Don't bother calling xmalloc when xrealloc will do.
6863 * search.c (Freplace_match): Check for size calculation overflow.
6864 (Fset_match_data): Don't assume list lengths fit in 'int'.
6866 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6867 for command line length. Do not attempt to address one before the
6868 beginning of an array, as that's not portable.
6870 * term.c (max_frame_lines): Remove; unused.
6871 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6873 (encode_terminal_code, calculate_costs): Check for size
6874 calculation overflow.
6875 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6876 table lengths and related sizes. Don't update size until alloc
6877 done. Redo calculations to avoid overflow.
6878 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6880 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6881 subtracting pointers.
6882 (gobble_line): Check for overflow more carefully. Don't update size
6885 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6886 Don't update size until alloc done.
6887 Redo size calculations to avoid overflow.
6888 Check for size calculation overflow.
6889 (main) [DEBUG]: Fix typo in invoking tparam1.
6891 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6892 Use ptrdiff_t, not int, for sizes.
6893 (store_mode_line_noprop_char): Don't update size until alloc done.
6895 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6896 Use ptrdiff_t, not int, for sizes.
6897 (Finternal_make_lisp_face, cache_face):
6898 Check for size calculation overflow.
6899 (cache_face): Treat size calculation overflows as if they were
6900 memory exhaustion (the usual treatment), rather than aborting.
6902 * xfns.c (x_encode_text, x_set_name_internal)
6903 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6904 sizes, since they can exceed INT_MAX in size. Check for size
6905 calculation overflow.
6907 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6908 (xg_select): Check for size calculation overflow.
6909 Don't update size until alloc done.
6911 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6912 as sprintf is limited to int lengths.
6914 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6915 (X_LONG_MIN): New macros.
6916 Use them to make the following changes clearer.
6917 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6918 This change doesn't affect the value now, but it may help remind
6919 future maintainers not to raise the value too much later.
6920 (SELECTION_QUANTUM): Remove, replacing with ...
6921 (selection_quantum): ... new function, which avoids overflow.
6923 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6924 assumption that selection length fits in 'int'.
6925 (x_reply_selection_request, x_handle_selection_request)
6926 (x_get_window_property, receive_incremental_selection)
6927 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6928 (lisp_data_to_selection_data, clean_local_selection_data):
6929 Use ptrdiff_t, not int, to record length of selection.
6930 (x_reply_selection_request, x_get_window_property)
6931 (receive_incremental_selection, x_property_data_to_lisp):
6932 Redo calculations to avoid overflow.
6933 (x_reply_selection_request): When sending hint, ceiling it at
6934 X_LONG_MAX rather than relying on wraparound overflow to send
6936 (x_get_window_property, receive_incremental_selection)
6937 (lisp_data_to_selection_data, x_property_data_to_lisp):
6938 Check for size-calculation overflow.
6939 (x_get_window_property, receive_incremental_selection)
6940 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6941 Don't store size until memory allocation succeeds.
6942 (x_get_window_property): Plug memory leak on memory exhaustion.
6943 Don't double-block input; malloc is safe here. Don't assume 2**34
6944 - 4 fits in unsigned long. Add an xassert to check
6945 XGetWindowProperty overflow. Be more careful about overflow
6946 calculations, and distinguish size from memory overflow better.
6947 (receive_incremental_selection): When tracing, don't assume
6948 unsigned int is less than INT_MAX.
6949 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6950 harmful) conversions of unsigned short to int.
6951 (lisp_data_to_selection_data): Don't assume that integers
6952 in the range -65535 through -1 fit in an X unsigned short.
6953 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6954 result parameters unless successful. Rely on cons_to_unsigned
6955 to report problems with elements; the old code wasn't right anyway.
6956 (x_check_property_data): Check for int overflow; we cannot use
6957 a wider type due to X limits.
6958 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6960 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6962 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6963 (x_term_init): Check for size calculation overflow.
6964 (x_color_cells): Don't store size until memory allocation succeeds.
6965 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6966 Don't assume alloca size is less than MAX_ALLOCA.
6967 (x_term_init): Don't assume length fits in int (sprintf is limited
6970 Use ptrdiff_t for composition IDs.
6971 * character.c (lisp_string_width):
6972 * composite.c (composition_table_size, n_compositions)
6973 (get_composition_id, composition_gstring_from_id):
6974 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6975 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6976 * window.c (Frecenter):
6977 Use ptrdiff_t, not int, for composition IDs.
6978 * composite.c (get_composition_id): Check for integer overflow.
6979 * composite.h: Adjust prototypes to match the above changes.
6981 Use ptrdiff_t for hash table indexes.
6982 * category.c (hash_get_category_set):
6983 * ccl.c (ccl_driver):
6984 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6985 * coding.c (coding_system_charset_list, detect_coding_system):
6986 * coding.h (struct coding_system.id):
6987 * composite.c (get_composition_id, gstring_lookup_cache):
6988 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6989 * image.c (xpm_get_color_table_h):
6990 * lisp.h (hash_lookup, hash_put):
6991 * minibuf.c (Ftest_completion):
6992 Use ptrdiff_t for hash table indexes, not int (which is too
6993 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6994 32-bit --with-wide-int hosts).
6996 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6997 Add a FIXME comment about memory leaks.
6998 (syms_of_charset): Don't assume xmalloc returns.
7000 Don't assume that stated character widths fit in int.
7001 * character.c (Fchar_width, c_string_width, lisp_string_width):
7002 * character.h (CHAR_WIDTH):
7003 * indent.c (MULTIBYTE_BYTES_WIDTH):
7004 Use sanitize_char_width to avoid undefined and/or bad behavior
7005 with outlandish widths.
7006 * character.h (sanitize_tab_width): Rename from sanitize_width,
7007 now that we have two such functions. All uses changed.
7008 (sanitize_char_width): New inline function.
7010 Don't assume that tab-width fits in int.
7011 * character.h (sanitize_width): New inline function.
7012 (SANE_TAB_WIDTH): New macro.
7013 (ASCII_CHAR_WIDTH): Use it.
7014 * indent.c (sane_tab_width): Remove. All uses replaced by
7015 SANE_TAB_WIDTH (current_buffer).
7016 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7018 * fileio.c: Integer overflow issues with file modes.
7019 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7021 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7022 Remove unreachable code.
7023 (read_hex, load_charset_map_from_file): Check for integer overflow.
7025 * xterm.c: Don't go over XClientMessageEvent limit.
7026 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7027 (x_send_scroll_bar_event): Likewise. Check that the size does not
7028 exceed limits imposed by XClientMessageEvent, as well as the usual
7029 ptrdiff_t and size_t limits.
7031 * keyboard.c: Overflow, signedness and related fixes.
7032 (make_lispy_movement): Use same integer type in forward decl
7033 that is used in the definition.
7034 (read_key_sequence, keyremap_step):
7035 Change bufsize argument back to int, undoing my 2011-03-30 change.
7036 We prefer signed types, and int is wide enough here.
7037 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7038 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7039 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7040 length, not size_t. Use ptrdiff_t for index, not int.
7041 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7042 possibility of integer overflow.
7044 Overflow, signedness and related fixes for images.
7046 * dispextern.h (struct it.stack[0].u.image.image_id)
7047 (struct_it.image_id, struct image.id, struct image_cache.size)
7048 (struct image_cache.used, struct image_cache.ref_count):
7049 * gtkutil.c (update_frame_tool_bar):
7050 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7051 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7052 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7053 * nsmenu.m (update_frame_tool_bar):
7054 * xdisp.c (calc_pixel_width_or_height):
7055 * xfns.c (image_cache_refcount):
7056 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7057 on typical 64-bit hosts.
7059 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7060 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7061 Omit unnecessary casts to int.
7062 (parse_image_spec): Check that integers fall into 'int' range
7063 when the callers expect that.
7064 (image_ascent): Redo ascent calculation to avoid int overflow.
7065 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7066 (lookup_image): Remove unnecessary tests.
7067 (xbm_image_p): Locals are now of int, not EMACS_INT,
7068 since parse_image_check makes sure they fit into int.
7069 (png_load, gif_load, svg_load_image):
7070 Prefer int to unsigned where either will do.
7071 (tiff_handler): New function, combining the cores of the
7072 old tiff_error_handler and tiff_warning_handler.
7073 This function is rewritten to use vsnprintf and thereby avoid
7074 stack buffer overflows. It uses only the features of vsnprintf
7075 that are common to both POSIX and native Microsoft.
7076 (tiff_error_handler, tiff_warning_handler): Use it.
7077 (tiff_load, gif_load, imagemagick_load_image):
7078 Don't assume :index value fits in 'int'.
7079 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7080 (imagemagick_load_image): Check that crop parameters fit into
7081 the integer types that MagickCropImage accepts. Don't assume
7082 Vimagemagick_render_type has a nonnegative value. Don't assume
7083 size_t fits in 'long'.
7084 (gs_load): Use printmax_t to print the widest integers possible.
7085 Check for integer overflow when computing image height and width.
7087 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7089 * xdisp.c (redisplay_window): Don't force window start if point
7090 will be invisible in the resulting window. (Bug#9324)
7092 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7094 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7095 the display spec is of the form `(space ...)'.
7096 (handle_display_spec): Return the value returned by
7097 handle_single_display_spec, not just 1 or zero.
7098 (handle_single_display_spec): If the display spec is of the form
7099 `(space ...)', and specifies display in the text area, return 2
7101 (try_cursor_movement): Check for the need to scroll more
7102 accurately, and prefer exact match for point under bidi.
7103 Don't advance `row' beyond the last row of the window.
7105 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7106 into disp_prop; all users changed.
7108 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7109 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7110 for the text covered by the display property.
7112 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7114 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7115 Change return value to nil.
7116 (Frecord_buffer): Delete unused function.
7118 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7120 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7121 buffers, return left-to-right.
7122 (set_cursor_from_row): Consider candidate row a win if its glyph
7123 represents a newline and point is on that newline. Fixes cursor
7124 positioning on the newline at EOL of R2L text within L2R
7125 paragraph, and vice versa.
7126 (try_cursor_movement): Check continued rows, in addition to
7127 continuation rows. Fixes unwarranted scroll when point enters a
7128 continued line of R2L text within an L2R paragraph, or vice versa.
7129 (cursor_row_p): Consider the case of point being equal to
7130 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7131 from the end of a short line to the beginning of a continued line
7132 of R2L text within L2R paragraph.
7133 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7134 composed characters.
7136 * bidi.c (bidi_check_type): Use xassert.
7137 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7140 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7142 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7145 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7147 * nsfont.m (ns_otf_to_script): Fix typo.
7149 2011-08-22 Kenichi Handa <handa@m17n.org>
7151 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7152 extra slot even if the purpose is char-code-property-table.
7154 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7156 * xdisp.c (redisplay_window): When computing centering_position,
7157 account for the height of the header line. (Bug#8874)
7159 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7160 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7161 candidate is selected by the mouse, and that candidate has a
7162 composed character under the mouse.
7164 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7165 coordinates reported by pos-visible-in-window-p for a composed
7166 character in column zero.
7168 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7170 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7172 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7174 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7175 consider it a hit if to_charpos is anywhere in the range of the
7176 composed buffer positions.
7178 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7180 * image.c (gif_load): Don't assume that each subimage has the same
7181 dimensions as the base image. Handle disposal method that is
7182 "undefined" by the gif spec (Bug#9335).
7184 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7186 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7187 (Fcondition_case): Document `debug' symbol in error handler.
7189 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7191 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7192 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7193 from an Org mode buffer to a Speedbar frame.
7195 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7196 a composition, take its buffer position from IT->cmp_it.charpos.
7197 Fixes cursor positioning at the beginning of a line that begins
7198 with a composed character.
7200 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7202 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7203 character bidirectional type, use STRONG_L instead. Fixes crashes
7204 in a buffer produced by `describe-categories'.
7206 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7207 members before the level stack, so they would be saved and
7208 restored when copying iterator state. Fixes incorrect reordering
7209 around TABs covered by display properties.
7211 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7213 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7215 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7217 * eval.c (internal_condition_case, internal_condition_case_1)
7218 (internal_condition_case_2, internal_condition_case_n):
7219 Remove unnecessary aborts (Bug#9081).
7221 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7223 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7224 has no `load' handler, try opening the file locally. (Bug#9311)
7226 2011-08-16 Ken Brown <kbrown@cornell.edu>
7228 * gmalloc.c: Expand comment.
7230 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7232 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7233 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7235 2011-08-16 Ken Brown <kbrown@cornell.edu>
7237 Fix memory allocation problems in Cygwin build (Bug#9273).
7239 * unexcw.c ( __malloc_initialized): Declare external variable.
7240 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7242 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7244 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7246 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7248 [CYGWIN] (special_realloc): New function.
7249 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7250 requests to realloc storage in the static heap.
7252 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7254 * bidi.c (bidi_initialize): Remove unused local.
7256 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7259 * biditype.h: Remove file.
7260 * makefile.w32-in ($(BLD)/bidi.$(O)):
7261 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7263 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7265 * chartab.c: Improve commentary for the uniprop_table API.
7267 * bidi.c (bidi_paragraph_init): Support zero value of
7268 bidi_ignore_explicit_marks_for_paragraph_level.
7269 (bidi_initialize): Use uniprop_table instead of including
7270 biditype.h and bidimirror.h.
7272 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7273 coordinates of the iterator when restoring from ppos_it.
7276 2011-08-14 Kenichi Handa <handa@m17n.org>
7278 * process.c (create_process): Call setup_process_coding_systems
7279 after the pid of the process is set to -1 (Bug#8162).
7281 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7283 * xdisp.c (move_it_in_display_line_to): Don't invoke
7284 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7285 ppos_it. Fixes vertical cursor motion when line beginning is
7286 covered by an image. (Bug#9296)
7288 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7290 * nsterm.h (ns_run_ascript): Declare.
7291 (NSAPP_DATA2_RUNASSCRIPT): Define.
7293 * nsfns.m (as_script, as_result, as_status): New static variables.
7294 (ns_run_ascript): New function.
7295 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7296 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7297 the event loop. Get status from as_status (Bug#7276).
7299 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7300 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7301 the event loop (Bug#7276).
7303 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7305 * gnutls.c (QCgnutls_bootprop_priority)
7306 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7307 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7308 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7309 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7310 (QCgnutls_bootprop_verify_hostname_error)
7311 (QCgnutls_bootprop_callbacks_verify): Rename from
7312 Qgnutls_bootprop_..., all uses changed.
7314 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7317 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7319 * xfaces.c (Qframe_set_background_mode): Now static.
7320 * dispextern.h (Qframe_set_background_mode): Remove decl.
7322 * process.c (Fnetwork_interface_info): Declare local only if needed.
7324 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7326 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7327 (Fnetwork_interface_list): Allocate in increments of bytes instead
7328 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7329 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7331 (struct ifflag_def): notrailers is smart on OSX.
7332 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7333 Get hardware address with getifaddrs if available.
7335 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7337 * xdisp.c (iterate_out_of_display_property): xassert that
7338 IT->position is set to within IT->object's boundaries. Break from
7339 the loop as soon as EOB is reached; avoids infloops in redisplay
7340 when IT->position is set up wrongly due to some bug.
7341 Set IT->current to match the bidi iterator unconditionally.
7342 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7343 entry. Force push_it to save on the stack the current
7344 buffer/string position, to be restored by pop_it. Fix flags in
7345 the iterator structure wrt the object coming from a display
7346 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7347 properties. (Bug#9284)
7349 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7351 * fontset.c (fontset_get_font_group): Add proper type checks.
7354 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7356 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7357 and LC_VERSION_MIN_MACOSX.
7358 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7359 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7361 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7363 * xdisp.c (forward_to_next_line_start): Allow to use the
7364 no-display-properties-and-no-overlays under bidi display.
7365 Set disp_pos in the bidi iterator to avoid searches for display
7366 properties and overlays.
7368 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7370 * editfns.c (Fset_time_zone_rule): Document relationship with the
7373 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7374 the font entity extracted from the cache (Bug#8109).
7376 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7378 * composite.c (autocmp_chars): Don't reset point. That is done by
7379 restore_point_unwind (Bug#5984).
7381 2011-08-07 Juri Linkov <juri@jurta.org>
7383 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7384 to show the arg `TIME' instead of `TIMEVAL'.
7386 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7388 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7389 display property strides EOL and includes a newline, as in
7390 longlines-mode. (Bug#9254)
7391 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7392 word-wrap under bidirectional display. (Bug#9224)
7394 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7395 is non-zero, even if the data buffer is NULL. Fixes a crash in
7396 vertical-motion with longlines-mode. (Bug#9254)
7398 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7400 * bidi.c <bidi_cache_total_alloc>: Now static.
7401 (bidi_initialize): Initialize bidi_cache_total_alloc.
7403 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7406 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7407 amount allocated this far in `bidi_cache_total_alloc'.
7408 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7409 non-zero, only free the data buffer without restoring the cache
7410 contents. All callers changed.
7412 * dispextern.h (bidi_unshelve_cache): Update prototype.
7414 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7415 (move_it_in_display_line, move_it_to)
7416 (move_it_vertically_backward, move_it_by_lines): Replace the call
7417 to xfree to an equivalent call to bidi_unshelve_cache.
7418 (move_it_in_display_line_to): Fix logic of returning
7419 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7421 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7423 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7424 came from a string character with a `cursor' property. (Bug#9229)
7426 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7428 * Makefile.in (LIB_PTHREAD): New variable.
7429 (LIBES): Add LIB_PTHREAD (Bug#9216).
7431 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7432 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7434 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7436 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7438 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7440 * xterm.c (x_find_topmost_parent): New function.
7441 (x_set_frame_alpha): Find topmost parent window with
7442 x_find_topmost_parent and set the property there also (bug#9181).
7443 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7445 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7447 * callproc.c (Fcall_process): Avoid vfork clobbering
7448 the local vars buffer, coding_systems, current_dir.
7450 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7452 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7454 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7456 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7457 so that it is not optimized away.
7459 * xdisp.c (compute_display_string_pos): Remove unused local.
7461 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7463 Fix slow cursor motion and scrolling in large buffers with
7464 selective display, like Org Mode buffers. (Bug#9218)
7466 * dispextern.h (struct bidi_it): New member disp_prop_p.
7468 * xdisp.c: Remove one-slot cache of display string positions.
7469 (compute_display_string_pos): Accept an additional argument
7470 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7471 for a display string or property. If found, set DISP_PROP_P
7474 * bidi.c (bidi_fetch_char): Accept an additional argument
7475 DISP_PROP_P, and pass it to compute_display_string_pos.
7476 Only handle text covered by a display string if DISP_PROP_P is returned
7477 non-zero. All callers of bidi_fetch_char changed.
7479 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7481 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7483 2010-12-03 Don March <don@ohspite.net>
7485 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7486 last character M-[char] is translated to ESC [char] (bug#7541).
7488 2011-08-02 Kenichi Handa <handa@m17n.org>
7490 * lisp.h (uniprop_table): Extern it.
7492 * chartab.c (uniprop_table): Make it non-static.
7494 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7496 * xdisp.c (forward_to_next_line_start): Accept additional argument
7497 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7499 (reseat_at_next_visible_line_start): Use the bidi iterator state
7500 returned by forward_to_next_line_start to restore the state of
7501 it->bidi_it after backing up to previous newline. (Bug#9212)
7503 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7505 * regex.c (re_comp): Protoize.
7506 (re_exec): Fix return type.
7507 (regexec): Fix type of `ret'. (Bug#9203)
7509 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7511 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7512 This is needed if max-image-size is a floating-point number.
7514 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7516 * print.c (print_object): Print empty symbol as ##.
7518 * lread.c (read1): Read ## as empty symbol.
7520 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7522 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7523 setting frame foreground color (Bug#9175).
7524 (x_set_background_color): Likewise.
7526 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7527 contents (Bug#9176).
7528 (EmacsTooltip -init): Remove bezels and add shadows to
7531 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7532 or scroll bar (Bug#8470).
7534 * nsfont.m (nsfont_open): Remove assignment to voffset and
7535 unnecessary vars hshink, expand, hd, full_height, min_height.
7536 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7538 * nsterm.h (nsfont_info): Remove voffset field.
7540 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7542 Implement strike-through and overline on NextStep (Bug#8863).
7544 * nsfont.m (nsfont_open): Use underline position provided by font,
7545 instead of hard-coded value of 2.
7546 (nsfont_draw): Call ns_draw_text_decoration instead.
7548 * nsterm.h: Add declaration for ns_draw_text_decoration.
7550 * nsterm.m (ns_draw_text_decoration): New function for drawing
7551 underline, overline, and strike-through.
7552 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7553 ns_draw_text_decoration. Change treatment of cursor drawing to
7554 accommodate underlining, etc.
7556 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7558 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7561 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7563 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7564 Without this fix, if a signal arrives just after memory fills up,
7565 'malloc' might be invoked reentrantly.
7567 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7568 In other words, assume that every image size is allowed, on non-X
7569 hosts. This assumption is probably wrong, but it lets Emacs compile.
7571 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7573 * regex.c (re_iswctype): Convert return values to boolean.
7575 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7577 * xdisp.c (compute_display_string_pos): Don't use cached display
7578 string position if the buffer had its restriction changed.
7581 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7583 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7585 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7587 Integer signedness and overflow and related fixes. (Bug#9079)
7589 * bidi.c: Integer size and overflow fixes.
7590 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7591 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7592 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7593 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7594 (bidi_find_other_level_edge):
7595 Use ptrdiff_t instead of EMACS_INT where either will do.
7596 This works better on 32-bit hosts configured --with-wide-int.
7597 (bidi_cache_ensure_space): Check for size-calculation overflow.
7598 Use % rather than repeated addition, for better worst-case speed.
7599 Don't set bidi_cache_size until after xrealloc returns, because it
7601 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7602 (bidi_cache_ensure_space): Also check that the bidi cache size
7603 does not exceed that of the largest Lisp string or buffer. See Eli
7604 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7606 * alloc.c (__malloc_size_t): Remove.
7607 All uses replaced by size_t. See Andreas Schwab's note
7608 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7610 * image.c: Improve checking for integer overflow.
7611 (check_image_size): Assume that f is nonnull, since
7612 it is always nonnull in practice. This is one less thing to
7613 worry about when checking for integer overflow later.
7614 (x_check_image_size): New function, which checks for integer
7615 overflow issues inside X.
7616 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7617 This removes the need for a memory_full check.
7618 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7619 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7620 (xbm_read_bitmap_data): Change locals back to 'int', since
7621 their values must fit in 'int'.
7622 (xpm_load_image, png_load, tiff_load):
7623 Invoke x_create_x_image_and_pixmap earlier,
7624 to avoid much needless work if the image is too large.
7625 (tiff_load): Treat overly large images as if
7626 x_create_x_image_and_pixmap failed, not as malloc failures.
7627 (gs_load): Use x_check_image_size.
7629 * gtkutil.c: Omit integer casts.
7630 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7631 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7633 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7635 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7636 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7637 would wrongly return t on a 64-bit host.
7639 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7640 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7641 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7642 and therefore cause GCC to emit a bogus diagnostic in some cases.
7644 * image.c: Integer signedness and overflow and related fixes.
7645 This is not an exhaustive set of fixes, but it's time to
7646 record what I've got.
7647 (lookup_pixel_color, check_image_size): Remove redundant decls.
7648 (check_image_size): Don't assume that arbitrary EMACS_INT values
7649 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7650 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7651 (tiff_load, imagemagick_load_image):
7652 Check for overflow in size calculations.
7653 (x_create_x_image_and_pixmap): Remove unnecessary test for
7654 xmalloc returning NULL; that can't happen.
7655 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7656 (xpm_color_bucket): Use better integer hashing function.
7657 (xpm_cache_color): Don't possibly over-allocate memory.
7658 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7659 (gif_memory_source):
7660 Use ptrdiff_t, not int or size_t, to record sizes.
7661 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7662 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7663 either works, as we prefer signed integers.
7664 (tiff_read_from_memory, tiff_write_from_memory):
7665 Return tsize_t, not size_t, since that's what the TIFF API wants.
7666 (tiff_read_from_memory): Don't fail simply because the read would
7667 go past EOF; instead, return a short read.
7668 (tiff_load): Omit no-longer-needed casts.
7669 (Fimagemagick_types): Don't assume size fits into 'int'.
7671 Improve hashing quality when configured --with-wide-int.
7672 * fns.c (hash_string): New function, taken from sxhash_string.
7673 Do not discard information about ASCII character case; this
7674 discarding is no longer needed.
7675 (sxhash-string): Use it. Change sig to match it. Caller changed.
7676 * lisp.h: Declare it.
7677 * lread.c (hash_string): Remove, since we now use fns.c's version.
7678 The fns.c version returns a wider integer if --with-wide-int is
7679 specified, so this should help the quality of the hashing a bit.
7681 * emacs.c: Integer overflow minor fix.
7682 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7683 Define only if GNU_LINUX.
7684 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7686 * dispnew.c: Integer signedness and overflow fixes.
7687 Remove unnecessary forward decls, that were a maintenance hassle.
7688 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7690 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7691 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7692 (prepare_desired_row, line_draw_cost):
7693 Use int, not unsigned, where either works.
7694 (save_current_matrix, restore_current_matrix):
7695 Use ptrdiff_t, not size_t, where either works.
7696 (init_display): Check for overflow more accurately, and without
7697 relying on undefined behavior.
7699 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7700 Remove, replacing with the new symbols in lisp.h. All uses changed.
7701 * fileio.c (make_temp_name):
7702 * filelock.c (lock_file_1, lock_file):
7703 * xdisp.c (message_dolog):
7704 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7705 Use pMd etc. instead.
7706 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7707 replacing the pWIDE etc. symbols removed from editfns.c.
7709 * keyboard.h (num_input_events): Now uintmax_t.
7710 This is (very slightly) less likely to mess up due to wraparound.
7713 * buffer.c: Integer signedness fixes.
7714 (alloc_buffer_text, enlarge_buffer_text):
7715 Use ptrdiff_t rather than size_t when either will do, as we prefer
7718 * alloc.c: Integer signedness and overflow fixes.
7719 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7720 (__malloc_size_t): Default to size_t, not to int.
7721 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7722 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7723 Prefer ptrdiff_t to size_t when either would do, as we prefer
7725 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7726 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7727 Now const. Initialize with values that are in range even if char
7729 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7730 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7731 These functions do the right thing with sizes > 2**32.
7732 (check_depth): Now ptrdiff_t, not int.
7733 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7734 Adjust to new way of storing sizes. Check for size overflow bugs
7736 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7737 slightly wrong anyway, as it missed one instance of
7738 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7739 (refill_memory_reserve): Omit needless cast to size_t.
7740 (mark_object_loop_halt): Mark as externally visible.
7742 * xselect.c: Integer signedness and overflow fixes.
7743 (Fx_register_dnd_atom, x_handle_dnd_message):
7744 Use ptrdiff_t, not size_t, since we prefer signed.
7745 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7746 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7747 x_dnd_atoms_size and x_dnd_atoms_length.
7749 * doprnt.c: Prefer signed to unsigned when either works.
7751 * doprnt.c (doprnt):
7753 * xdisp.c (vmessage):
7754 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7755 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7756 prefer signed arithmetic to avoid comparison confusion.
7757 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7758 but is a bit tricky.
7760 Assume freestanding C89 headers, string.h, stdlib.h.
7761 * data.c, doprnt.c, floatfns.c, print.c:
7762 Include float.h unconditionally.
7763 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7764 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7765 * regex.c: Likewise for stddef.h, string.h.
7766 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7767 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7768 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7769 (STDC_HEADERS): Remove obsolete defines.
7770 * sysdep.c: Include limits.h unconditionally.
7772 Assume support for memcmp, memcpy, memmove, memset.
7773 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7774 * regex.c (memcmp, memcpy):
7775 Remove; we assume C89 now.
7777 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7778 (__malloc_safe_bcopy): Remove; no longer needed.
7780 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7781 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7782 well either way, and we prefer signed to unsigned.
7784 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7786 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7787 closes the connection while we're reading (bug#9182).
7789 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7791 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7792 are specified (Bug#9168).
7794 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7796 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7797 Found by GCC static checking and --with-wide-int on a 32-bit host.
7799 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7801 * xdisp.c (compute_display_string_pos): Fix logic of caching
7802 previous display string position. Initialize cached_prev_pos to
7803 -1. Fixes slow-down at the beginning of a buffer.
7805 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7807 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7808 for attrs[LFACE_FONTSET_INDEX].
7810 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7812 * xml.c (parse_region): Remove unused local
7813 that was recently introduced.
7815 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7817 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7818 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7820 * xdisp.c (move_it_in_display_line_to): Record the best matching
7821 position for TO_CHARPOS while scanning the line, and restore it on
7822 exit if none of the characters scanned was an exact match.
7823 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7824 when exact match is impossible due to invisible text, and the
7825 lines are truncated.
7827 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7829 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7832 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7834 Fix a significant slow-down of cursor motion with C-n, C-p,
7835 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7836 auto-repeat under bidi redisplay in fontified buffers.
7837 * xdisp.c (compute_stop_pos_backwards): New function.
7838 (next_element_from_buffer): Call compute_stop_pos_backwards to
7839 find a suitable prev_stop when we find ourselves before
7841 (reseat): Don't look for prev_stop, as that could mean a very long
7843 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7844 <cached_disp_overlay_modiff>: Cache for last found display string
7846 (compute_display_string_pos): Return the cached position if asked
7847 about the same buffer in the same area of character positions, and
7848 the buffer wasn't changed since the time the display string
7849 position was cached.
7851 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7853 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7854 is an integer, which is important for empty lines. (Bug#9149)
7856 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7858 * frame.c (Fmodify_frame_parameters): In tty case, update the
7859 default face if necessary (Bug#4238).
7861 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7863 * editfns.c (Fstring_to_char): No need to explain what a character
7864 is in the docstring (Bug#6576).
7866 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7868 * xml.c (parse_region): Make sure we always return a tree.
7870 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7872 * xml.c (parse_region): If a document contains only comments,
7875 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7877 * xml.c (make_dom): Return comments, too.
7879 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7882 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7883 and the surrounding thread.
7884 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7885 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7886 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7888 * s/openbsd.h (BROKEN_SIGIO): Define.
7889 * unexelf.c (unexec) [__OpenBSD__]:
7890 Don't update the .mdebug section of the Alpha COFF symbol table.
7892 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7894 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7897 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7899 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7900 This fixes some race conditions on the permissions of any newly
7903 * alloc.c (valid_pointer_p): Use pipe, not open.
7904 This fixes some permissions issues when debugging.
7906 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7907 If fchown fails to set both uid and gid, try to set just gid,
7908 as that is sometimes allowed. Adjust the file's mode to eliminate
7909 setuid or setgid bits that are inappropriate if fchown fails.
7911 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7913 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7914 to compare Lisp_Objects.
7915 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7916 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7917 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7919 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7921 * lread.c (read_integer): Unread even EOF character.
7922 (read1): Likewise. Properly record start position of symbol.
7924 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7925 symbol character follows.
7927 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7929 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7930 This works around a problem with the previous change to Fcopy_file.
7931 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7932 and without this change, GCC might complain about discarding
7933 fchown's return value.
7935 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7937 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7939 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7941 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7943 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7945 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7946 it's used from the C level.
7948 * process.c: Use the same condition for POLL_FOR_INPUT in both
7949 keyboard.c and process.c (bug#1858).
7951 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7953 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7954 (Fgnutls_boot): Use it.
7956 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7958 * doc.c (Fsubstitute_command_keys): Revert last change.
7960 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7962 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7963 quotes the next character, and doesn't affect other longer
7964 sequences (bug#8935).
7966 * lread.c (syms_of_lread): Clarify that is isn't only
7967 `eval-buffer' and `eval-defun' that's affected by
7968 `lexical-binding' (bug#8460).
7970 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7972 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7973 bidi redisplay when a line includes both an image and is truncated.
7975 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7977 Fix minor problems found by static checking.
7978 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7979 (elsz): Now a signed constant, not a size_t var. We prefer signed
7980 types to unsigned, to avoid integer comparison confusion. Without
7981 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7982 "cannot optimize loop, the loop counter may overflow", a symptom
7984 * indent.c (Fvertical_motion): Mark locals as initialized.
7985 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7987 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7989 * search.c (Fre_search_backward): Mention `case-fold-search' in
7990 all the re_search_* functions (bug#8138).
7992 * keyboard.c (Fopen_dribble_file): Document when the file is
7995 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7997 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8000 Support bidi reordering of display and overlay strings.
8001 * xdisp.c (compute_display_string_pos)
8002 (compute_display_string_end): Accept additional argument STRING.
8003 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8004 (reseat_to_string): Initialize bidi_it->string.s and
8005 bidi_it->string.schars.
8006 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8007 NULL (avoids a crash in bidi_paragraph_init).
8008 Initialize itb.string.lstring.
8009 (init_iterator): Call bidi_init_it only of a valid
8010 buffer position was specified. Initialize paragraph_embedding to
8012 (reseat_to_string): Initialize the bidi iterator.
8013 (display_string): If we need to ignore text properties of
8014 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8015 original value of -1 will not work with bidi.)
8016 (compute_display_string_pos): First arg is now struct
8017 `text_pos *'; all callers changed. Support display properties on
8019 (compute_display_string_end): Support display properties on Lisp
8021 (init_iterator, reseat_1, reseat_to_string): Initialize the
8022 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8023 when iterating on a string not from display properties).
8024 (compute_display_string_pos, compute_display_string_end):
8025 Fix calculation of the object to scan. Fixes an error when using
8027 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8028 base_level_stop; instead, set base_level_stop to BEGV.
8029 Fixes crashes in vertical-motion.
8030 (next_element_from_buffer): Improve commentary for when
8031 the iterator is before prev_stop.
8032 (init_iterator): Initialize bidi_p from the default value of
8033 bidi-display-reordering, not from buffer-local value. Use the
8034 buffer-local value only if initializing for buffer iteration.
8035 (handle_invisible_prop): Support invisible properties on strings
8036 that are being bidi-reordered.
8037 (set_iterator_to_next): Support bidi reordering of C strings and
8039 (next_element_from_string): Support bidi reordering of Lisp
8041 (handle_stop_backwards): Support Lisp strings as well.
8042 (display_string): Support display of R2L glyph rows.
8043 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8044 (init_iterator): Don't initialize it->bidi_p for strings
8046 (reseat_to_string): Initialize it->bidi_p for strings here.
8047 (next_element_from_string, next_element_from_c_string)
8048 (next_element_from_buffer): Add xassert's for correspondence
8049 between IT's object being iterated and it->bidi_it.string
8051 (face_before_or_after_it_pos): Support bidi iteration.
8052 (next_element_from_c_string): Handle the case of the first string
8053 character that is not the first one in the visual order.
8054 (get_visually_first_element): New function, refactored from common
8055 parts of next_element_from_buffer, next_element_from_string, and
8056 next_element_from_c_string.
8057 (tool_bar_lines_needed, redisplay_tool_bar)
8058 (display_menu_bar): Force left-to-right direction. Add a FIXME
8059 comment for making that be controlled by a user option.
8060 (push_it, pop_it): Save and restore the state of the
8061 bidi iterator. Save and restore the bidi_p flag.
8062 (pop_it): Iterate out of display property for string iteration as
8064 (iterate_out_of_display_property): Support iteration over strings.
8065 (handle_single_display_spec): Set up it->bidi_it for iteration
8066 over a display string, and call bidi_init_it.
8067 (handle_single_display_spec, next_overlay_string)
8068 (get_overlay_strings_1, push_display_prop): Set up the bidi
8069 iterator for displaying display or overlay strings.
8070 (forward_to_next_line_start): Don't use the shortcut if
8072 (back_to_previous_visible_line_start): If handle_display_prop
8073 pushed the iterator stack, restore the internal state of the bidi
8074 iterator by calling bidi_pop_it same number of times.
8075 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8076 and we are bidi-iterating, don't decrement the iterator position;
8077 instead, set the first_elt flag in the bidi iterator, to produce
8079 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8080 (push_display_prop): xassert that we are iterating a buffer.
8081 (push_it, pop_it): Save and restore paragraph_embedding member.
8082 (handle_single_display_spec, next_overlay_string)
8083 (get_overlay_strings_1, reseat_1, reseat_to_string)
8084 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8085 correctly. Don't assume unibyte strings are not bidi-reordered.
8086 (compute_display_string_pos)
8087 (compute_display_string_end): Fix handling the case of C string.
8088 (push_it, pop_it): Save and restore from_disp_prop_p.
8089 (handle_single_display_spec, push_display_prop): Set the
8090 from_disp_prop_p flag.
8091 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8092 (pop_it): Call iterate_out_of_display_property only if we are
8093 popping after iteration over a string that came from a display
8094 property. Fix a typo in popping stretch info. Add an assertion
8095 for verifying that the iterator position is in sync with the bidi
8097 (handle_single_display_spec, get_overlay_strings_1)
8098 (push_display_prop): Fix initialization of paragraph direction for
8099 string when that of the parent object is not yet determined.
8100 (reseat_1): Call bidi_init_it to resync the bidi
8101 iterator with IT's position. (Bug#7616)
8102 (find_row_edges): If ROW->start.pos gives position
8103 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8104 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8105 Reset the from_disp_prop_p flag.
8106 (SAVE_IT, RESTORE_IT): New macros.
8107 (pos_visible_p, face_before_or_after_it_pos)
8108 (back_to_previous_visible_line_start)
8109 (move_it_in_display_line_to, move_it_in_display_line)
8110 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8111 (try_scrolling, redisplay_window, display_line): Use them when
8112 saving a temporary copy of the iterator and restoring it back.
8113 (back_to_previous_visible_line_start, reseat_1)
8114 (init_iterator): Empty the bidi cache "stack".
8115 (move_it_in_display_line_to): If iterator ended up at
8116 EOL, but we never saw any buffer positions smaller than
8117 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8118 motion in bidi-reordered lines.
8119 (move_it_in_display_line_to): Record prev_method and prev_pos
8120 immediately before the call to set_iterator_to_next. Fixes cursor
8121 motion in bidi-reordered lines with stretch glyphs and strings
8122 displayed in margins. (Bug#8133) (Bug#8867)
8123 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8125 (pos_visible_p): Support positions in bidi-reordered lines.
8126 Save and restore bidi cache.
8128 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8129 (bidi_paragraph_info): Delete unused struct.
8130 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8131 (bidi_cache_start): New variable.
8132 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8134 (bidi_cache_fetch_state, bidi_cache_search)
8135 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8136 (bidi_cache_find, bidi_peek_at_next_level)
8137 (bidi_level_of_next_char, bidi_find_other_level_edge)
8138 (bidi_move_to_visually_next): Compare cache index with
8139 bidi_cache_start rather than with zero.
8140 (bidi_fetch_char): Accept new argument STRING; all callers
8141 changed. Support iteration over a string. Support strings with
8142 display properties. Support unibyte strings. Fix the type of
8143 `len' according to what STRING_CHAR_AND_LENGTH expects.
8144 (bidi_paragraph_init, bidi_resolve_explicit_1)
8145 (bidi_resolve_explicit, bidi_resolve_weak)
8146 (bidi_level_of_next_char, bidi_move_to_visually_next):
8147 Support iteration over a string.
8148 (bidi_set_sor_type, bidi_resolve_explicit_1)
8149 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8150 can now be zero (for strings); special values 0 and -1 were
8151 changed to -1 and -2, respectively.
8152 (bidi_char_at_pos): New function.
8153 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8154 Call it instead of FETCH_MULTIBYTE_CHAR.
8155 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8156 initialized to valid values.
8157 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8159 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8160 the test for valid cached positions. Fix the logic for looking up
8161 the sentinel state in the cache. GCPRO the Lisp string we are
8163 (bidi_push_it, bidi_pop_it): New functions.
8164 (bidi_initialize): Initialize the bidi cache start stack pointer.
8165 (bidi_cache_ensure_space): New function, refactored from part of
8166 bidi_cache_iterator_state. Don't assume the required size is just
8167 one BIDI_CACHE_CHUNK away.
8168 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8169 (bidi_count_bytes, bidi_char_at_pos): New functions.
8170 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8171 always valid if bidi_cache_idx is valid.
8172 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8173 is valid if it's going to be used.
8174 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8175 (bidi_cache_fetch_state, bidi_cache_search)
8176 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8177 (bidi_cache_iterator_state, bidi_cache_find)
8178 (bidi_find_other_level_edge, bidi_cache_start_stack):
8179 All variables related to cache indices are now EMACS_INT.
8181 * dispextern.h (struct bidi_string_data): New structure.
8182 (struct bidi_it): New member `string'. Make flag members be 1-bit
8183 fields, and put them last in the struct.
8184 (compute_display_string_pos, compute_display_string_end):
8186 (bidi_push_it, bidi_pop_it): Add prototypes.
8187 (struct iterator_stack_entry): New members bidi_p,
8188 paragraph_embedding, and from_disp_prop_p.
8189 (struct it): Member bidi_p is now a bit field 1 bit wide.
8190 (bidi_shelve_cache, bidi_unshelve_cache):
8193 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8194 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8195 and vector-like objects.
8197 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8198 cache around display iteration.
8200 * window.c (Fwindow_end, window_scroll_pixel_based)
8201 (displayed_window_lines, Frecenter): Save and restore the bidi
8202 cache around display iteration.
8204 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8206 * editfns.c (Fdelete_region): Clarify the use of the named
8207 parameters (bug#6788).
8209 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8211 * indent.c (Fvertical_motion): Set and restore w->pointm when
8212 saving and restoring the window's buffer (Bug#9006).
8214 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8216 * editfns.c (Fstring_to_char): Clarify just what is returned
8217 (bug#6576). Text by Eli Zaretskii.
8219 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8221 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8223 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8225 * buffer.c (mmap_find): Fix a typo.
8227 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8229 Fix execution of x selection hooks.
8230 * xselect.c (Qx_lost_selection_functions)
8231 (Qx_sent_selection_functions): New vars.
8232 (syms_of_xselect): DEFSYM them.
8233 (x_handle_selection_request): Pass Qx_sent_selection_functions
8234 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8235 (x_handle_selection_clear,x_clear_frame_selections):
8236 Pass Qx_lost_selection_functions rather than
8237 Vx_lost_selection_functions to Frun_hook_with_args.
8239 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8241 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8242 The old code sometimes used this field without initializing it.
8244 * alloc.c (gc_sweep): Don't read past end of array.
8245 In theory, the old code could also have corrupted Emacs internals,
8246 though it'd be very unlikely.
8248 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8250 * character.c (Fcharacterp): Don't advertise optional ignored
8251 argument. (Bug#4026)
8253 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8255 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8258 * window.c (Fset_window_start): Doc fix (bug#4199).
8259 (Fset_window_hscroll): Ditto.
8261 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8263 Fix minor new problems caught by GCC 4.6.1.
8264 * term.c (init_tty): Remove unused local.
8265 * xsettings.c (store_monospaced_changed): Define this function only
8266 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8269 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8271 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8273 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8275 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8276 are the mini-buffer and the echo area (bug#3320).
8278 * term.c (init_tty): Remove support for supdup, c10 and perq
8279 terminals, which are no longer supported (bug#1482).
8281 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8283 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8285 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8287 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8288 for non-popups (Bug#3642).
8290 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8292 * alloc.c (reset_malloc_hooks): Protoize.
8293 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8294 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8295 * cm.c (losecursor): Likewise.
8296 * data.c (fmod): Likewise.
8297 * dispnew.c (swap_glyphs_in_rows): Likewise.
8298 * emacs.c (memory_warning_signal): Likewise.
8299 * floatfns.c (float_error): Likewise.
8300 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8301 (otf_open, font_otf_capability, generate_otf_features)
8302 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8304 * image.c (pbm_read_file): Likewise.
8305 * indent.c (string_display_width): Likewise.
8306 * intervals.c (check_for_interval, search_for_interval)
8307 (inc_interval_count, count_intervals, root_interval)
8308 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8309 * lread.c (defalias): Likewise.
8310 * ralloc.c (r_alloc_check): Likewise.
8311 * regex.c (set_image_of_range_1, set_image_of_range)
8312 (regex_grow_registers): Likewise.
8313 * sysdep.c (strerror): Likewise.
8314 * termcap.c (valid_filename_p, tprint, main): Likewise.
8315 * tparam.c (main): Likewise.
8316 * unexhp9k800.c (run_time_remap, save_data_space)
8317 (update_file_ptrs, read_header, write_header, calculate_checksum)
8318 (copy_file, copy_rest, display_header): Likewise.
8319 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8321 * xdisp.c (check_it): Likewise.
8322 * xfaces.c (register_color, unregister_color, unregister_colors):
8324 * xfns.c (print_fontset_result): Likewise.
8325 * xrdb.c (member, fatal, main): Likewise.
8327 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8329 Fix minor problems found by static checking (Bug#9031).
8330 * chartab.c (char_table_set_range, map_sub_char_table):
8331 Remove unused locals.
8332 (uniprop_table): Now static.
8333 * composite.c (_work_char): Remove unused static var.
8335 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8337 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8339 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8341 * gtkutil.c (qttip_cb): Remove code without function.
8343 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8345 * w32.c (pthread_sigmask): New stub.
8347 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8349 Use pthread_sigmask, not sigprocmask (Bug#9010).
8350 sigprocmask is portable only for single-threaded applications, and
8351 Emacs can be multi-threaded when it uses GTK.
8352 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8354 * callproc.c (Fcall_process):
8355 * process.c (create_process):
8356 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8357 Use pthread_sigmask, not sigprocmask.
8359 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8361 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8362 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8365 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8367 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8368 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8369 (xg_hide_tooltip): Fix comment.
8371 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8372 in registerServicesMenuSendTypes.
8373 (validRequestorForSendType): Don't check ns_return_types.
8375 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8378 2011-07-08 Jason Rumney <jasonr@gnu.org>
8380 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8381 SH_SHOW for hidden windows (Bug#5482).
8383 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8384 frame struct members of non-existent frames (Bug#6284).
8386 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8388 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8389 variable firstTime not needed on OSX >= 10.6.
8390 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8391 >= 10.5. Use setKnobProportion, setDoubleValue.
8393 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8394 (MAC_OS_X_VERSION_10_5): Define if not defined.
8395 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8396 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8397 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8399 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8400 cString and lossyCString on OSX >= 10.4.
8402 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8403 sizeToFit on OSX >= 10.2.
8405 * nsimage.m (allocInitFromFile): Don't use deprecated method
8406 bestRepresentationForDevice on OSX >= 10.6.
8408 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8411 * emacs.c: Declare unexec_init_emacs_zone.
8413 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8415 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8417 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8418 on svcsMenu (Bug#8842).
8420 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8422 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8424 * nsterm.m (QUTF8_STRING): Declare.
8425 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8426 (validRequestorForSendType): Return type is (id).
8427 Change indexOfObjectIdenticalTo to indexOfObject.
8428 Check if we have local selection before returning self (Bug#8842).
8429 (writeSelectionToPasteboard): Put local selection into paste board
8430 if we have a local selection (Bug#8842).
8431 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8433 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8434 (ns_get_local_selection): Declare.
8436 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8438 * keymap.c (describe_map_tree): Don't insert a double newline at
8439 the end of the buffer (bug#1169) and return whether we inserted
8442 * callint.c (Fcall_interactively): Change "reading args" to
8443 "providing args" to try to clarify what it does (bug#1010).
8445 2011-07-07 Kenichi Handa <handa@m17n.org>
8447 * composite.c (composition_compute_stop_pos): Ignore a static
8448 composition starting before CHARPOS (Bug#8915).
8450 * xdisp.c (handle_composition_prop): Likewise.
8452 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8454 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8457 2011-07-07 Kenichi Handa <handa@m17n.org>
8459 * character.h (unicode_category_t): New enum type.
8461 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8462 (Qchar_code_property_table): New variable.
8463 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8464 (UNIPROP_COMPRESSED_FORM_P): New macros.
8465 (char_table_ascii): Uncompress the compressed values.
8466 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8467 Uncompress the compressed values.
8468 (sub_char_table_ref_and_range): Likewise.
8469 (char_table_ref_and_range): Uncompress the compressed values.
8470 (sub_char_table_set): New arg is_uniprop. Callers changed.
8471 Uncompress the compressed values.
8472 (sub_char_table_set_range): Args changed. Callers changed.
8473 (char_table_set_range): Adjuted for the above change.
8474 (map_sub_char_table): Delete args default_val and parent. Add arg
8475 top. Give decoded values to a Lisp function.
8476 (map_char_table): Adjust for the above change. Give decoded
8477 values to a Lisp function. Gcpro more variables.
8478 (uniprop_table_uncompress)
8479 (uniprop_decode_value_run_length): New functions.
8480 (uniprop_decoder, uniprop_decoder_count): New variables.
8481 (uniprop_get_decoder, uniprop_encode_value_character)
8482 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8484 (uniprop_encoder, uniprop_encoder_count): New variables.
8485 (uniprop_get_encoder, uniprop_table)
8486 (Funicode_property_table_internal, Fget_unicode_property_internal)
8487 (Fput_unicode_property_internal): New functions.
8488 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8489 Sunicode_property_table_internal, Sget_unicode_property_internal,
8490 and Sput_unicode_property_internal. Defvar_lisp
8491 char-code-property-alist.
8493 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8494 Vunicode_category_table.
8496 * font.c (font_range): Adjust for the change of
8497 Vunicode_category_table.
8499 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8501 * m/iris4d.h: Remove file, move contents ...
8502 * s/irix6-5.h: ... here.
8504 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8506 Remove unportable assumption about struct layout (Bug#8884).
8507 * alloc.c (mark_buffer):
8508 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8509 (clone_per_buffer_values): Don't assume that
8510 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8511 This isn't true in general, and it's particularly not true
8512 if Emacs is configured with --with-wide-int.
8513 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8514 New macros, used in the buffer.c change.
8516 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8518 * xsettings.c: Use both GConf and GSettings if both are available.
8519 (store_config_changed_event): Add comment.
8520 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8521 (store_tool_bar_style_changed): New functions.
8522 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8523 (struct xsettings): Move font inside HAVE_XFT.
8524 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8525 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8526 Move inside HAVE_XFT.
8527 (something_changed_gsettingsCB): Rename from something_changedCB.
8528 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8530 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8531 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8532 (something_changed_gconfCB): Rename from something_changedCB.
8533 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8534 (parse_settings): Move check for font inside HAVE_XFT.
8535 (read_settings, apply_xft_settings): Add comment.
8536 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8537 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8538 call store_font_name_changed.
8539 (xft_settings_event): Add comment.
8540 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8541 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8542 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8543 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8544 (xsettings_initialize): Call init_gsettings last.
8545 (xsettings_get_system_font, xsettings_get_system_normal_font):
8548 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8550 Random fixes. E.g., (random) never returned negative values.
8551 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8552 subseconds part to the entropy, as that's a bit more random.
8553 Prefer signed to unsigned, since the signedness doesn't matter and
8554 in general we prefer signed. When given a limit, use a
8555 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8556 latter isn't right if USE_2_TAGS_FOR_INTS.
8557 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8558 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8560 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8562 * textprop.c (text_property_stickiness):
8563 Obey Vtext_property_default_nonsticky.
8564 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8565 * w32fns.c (syms_of_w32fns):
8566 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8568 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8570 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8571 This is more efficient than Ffile_directory_p and avoids a minor race.
8573 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8575 * buffer.c (Foverlay_put): Say what the return value is
8578 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8579 is a directory before asking whether to use the file name
8581 (barf_or_query_if_file_exists): Make the "File is a directory"
8582 error be more correct.
8584 * fns.c (Frequire): Remove the mention of the .gz files, since
8585 that's installation-specific, but keep the mention of
8586 `get-load-suffixes'.
8588 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8590 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8591 Report string overflow if the output is too long.
8593 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8595 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8596 (syms_of_gnutls): Remove duplicate DEFSYM for
8597 Qgnutls_bootprop_verify_hostname_error, an error for
8598 Qgnutls_bootprop_verify_error (which is no longer used).
8600 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8601 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8602 Also (re)move comments that are misplaced or no longer relevant.
8604 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8606 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8608 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8610 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8611 and background color parameters if they have been changed.
8613 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8615 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8617 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8619 * xsettings.c (SYSTEM_FONT): Define only when used.
8620 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8622 * keymap.c (access_keymap_1): Now static.
8624 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8626 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8627 leave any prefix arg for the up event (Bug#1586).
8629 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8631 * lread.c (syms_of_lread): Mention single symbols defined by
8632 `defvar' or `defconst' (bug#7154).
8634 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8635 (Frequire): Mention get-load-suffixes.
8637 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8639 * window.h (window): Remove clone_number slot.
8640 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8642 (make_parent_window, make_window, saved_window)
8643 (Fset_window_configuration, save_window_save): Don't deal with
8645 * buffer.c (Qclone_number): Remove declaration.
8646 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8648 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8650 Add multiple inheritance to keymaps.
8651 * keymap.c (Fmake_composed_keymap): New function.
8652 (Fset_keymap_parent): Simplify.
8653 (fix_submap_inheritance): Remove.
8654 (access_keymap_1): New function extracted from access_keymap to handle
8655 embedded parents and handle lists of maps.
8656 (access_keymap): Use it.
8657 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8658 (Fcopy_keymap): Handle embedded parents.
8659 (Fcommand_remapping, define_as_prefix): Simplify.
8660 (Fkey_binding): Simplify.
8661 (syms_of_keymap): Move minibuffer-local-completion-map,
8662 minibuffer-local-filename-completion-map,
8663 minibuffer-local-must-match-map, and
8664 minibuffer-local-filename-must-match-map to Elisp.
8665 (syms_of_keymap): Defsubr make-composed-keymap.
8666 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8667 (parse_menu_item): Trivial simplification.
8669 2011-07-01 Glenn Morris <rgm@gnu.org>
8671 * Makefile.in (SETTINGS_LIBS): Fix typo.
8673 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8675 * coding.c (Fencode_coding_string): Record the last coding system
8676 used, as the function doc string says (bug#8738).
8678 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8680 * xsettings.c (store_monospaced_changed): Take new font as arg and
8681 check for change against current_mono_font.
8682 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8683 (emacs_settings_constructor, emacs_settings_get_property)
8684 (emacs_settings_set_property, emacs_settings_class_init)
8685 (emacs_settings_init, gsettings_obj): Remove.
8686 (something_changedCB): New function for HAVE_GSETTINGS.
8687 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8688 with value as argument.
8689 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8690 g_settings_new (Bug#8967). Do not create gsettings_obj.
8691 Remove calls to g_settings_bind. Connect something_changedCB to
8694 * xgselect.c: Add defined (HAVE_GSETTINGS).
8695 (xgselect_initialize): Ditto.
8697 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8698 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8701 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8703 * eval.c (struct backtrace): Simplify and port the data structure.
8704 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8705 signed bit field, as this assumption is not portable and it makes
8706 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8707 "char debug_on_exit : 1" as this is not portable either; instead,
8708 use the portable "unsigned int debug_on_exit : 1". Remove unused
8709 member evalargs. Remove obsolete comments about cc bombing out.
8711 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8713 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8714 Let HAVE_GSETTINGS override HAVE_GCONF.
8715 (store_monospaced_changed): New function.
8716 (EMACS_SETTINGS): A new type derived from GObject to handle
8717 GSettings notifications.
8718 (emacs_settings_constructor, emacs_settings_get_property)
8719 (emacs_settings_set_property, emacs_settings_class_init):
8721 (gsettings_client, gsettings_obj): New variables.
8722 (GSETTINGS_SCHEMA): New define.
8723 (something_changedCB): Call store_monospaced_changed.
8724 (init_gsettings): New function.
8725 (xsettings_initialize): Call init_gsettings.
8726 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8729 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8732 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8734 * window.c (resize_root_window, grow_mini_window)
8735 (shrink_mini_window): Rename Qresize_root_window to
8736 Qwindow_resize_root_window and Qresize_root_window_vertically to
8737 Qwindow_resize_root_window_vertically.
8739 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8741 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8743 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8745 * makefile.w32-in: Redesign dependencies so they reflect more
8746 clearly which files are directly included by each source file,
8747 and not through other includes.
8749 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8751 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8752 (sort_overlays, overlay_strings): When an overlay's clone number
8753 matches the window's clone number process the overlay even if
8754 the overlay's window property doesn't match the current window.
8756 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8757 (Fwindow_hchild): Rename to Fwindow_left_child.
8758 (Fwindow_next): Rename to Fwindow_next_sibling.
8759 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8760 (resize_window_check): Rename to window_resize_check.
8761 (resize_window_apply): Rename to window_resize_apply.
8762 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8763 (Fdelete_other_windows_internal, resize_frame_windows)
8764 (Fsplit_window_internal, Fdelete_window_internal)
8765 (grow_mini_window, shrink_mini_window)
8766 (Fresize_mini_window_internal): Fix callers accordingly.
8768 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8770 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8771 (emacs_fixed_set_min_size): Remove.
8772 (emacs_fixed_new): Take frame as argument.
8774 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8775 (_EmacsFixedPrivate): Remove minwidth/height.
8776 Add struct frame *f.
8777 (emacs_fixed_init): Initialize priv->f.
8778 (get_parent_class, emacs_fixed_set_min_size): Remove.
8779 (emacs_fixed_new): Set priv->f to argument.
8780 (emacs_fixed_get_preferred_width)
8781 (emacs_fixed_get_preferred_height): Use min_width/height from
8782 frames size_hint to set minimum and natural (Bug#8919).
8783 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8784 and use min_width/height from frames size_hint to set
8785 min_width/height (Bug#8919).
8787 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8788 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8791 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8793 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8794 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8797 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8799 * process.c (wait_reading_process_output): Bypass select if
8800 waiting for a cell while ignoring keyboard input, and input is
8801 pending. Suggested by Jan Djärv (Bug#8869).
8803 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8805 Use gnulib's dup2 module instead of rolling our own.
8806 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8808 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8810 * dispnew.c (scrolling_window): Before scrolling, turn off a
8811 mouse-highlight in the window being scrolled.
8813 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8815 Move DEFSYM to lisp.h and use everywhere.
8817 * character.h (DEFSYM): Move declaration...
8818 * lisp.h (DEFSYM): ...here.
8824 * w32select.c: Don't include character.h.
8826 * alloc.c (syms_of_alloc):
8827 * buffer.c (syms_of_buffer):
8828 * bytecode.c (syms_of_bytecode):
8829 * callint.c (syms_of_callint):
8830 * casefiddle.c (syms_of_casefiddle):
8831 * casetab.c (init_casetab_once):
8832 * category.c (init_category_once, syms_of_category):
8833 * ccl.c (syms_of_ccl):
8834 * cmds.c (syms_of_cmds):
8835 * composite.c (syms_of_composite):
8836 * dbusbind.c (syms_of_dbusbind):
8837 * dired.c (syms_of_dired):
8838 * dispnew.c (syms_of_display):
8839 * doc.c (syms_of_doc):
8840 * editfns.c (syms_of_editfns):
8841 * emacs.c (syms_of_emacs):
8842 * eval.c (syms_of_eval):
8843 * fileio.c (syms_of_fileio):
8844 * fns.c (syms_of_fns):
8845 * frame.c (syms_of_frame):
8846 * fringe.c (syms_of_fringe):
8847 * insdel.c (syms_of_insdel):
8848 * keymap.c (syms_of_keymap):
8849 * lread.c (init_obarray, syms_of_lread):
8850 * macros.c (syms_of_macros):
8851 * msdos.c (syms_of_msdos):
8852 * print.c (syms_of_print):
8853 * process.c (syms_of_process):
8854 * search.c (syms_of_search):
8855 * sound.c (syms_of_sound):
8856 * syntax.c (init_syntax_once, syms_of_syntax):
8857 * terminal.c (syms_of_terminal):
8858 * textprop.c (syms_of_textprop):
8859 * undo.c (syms_of_undo):
8860 * w32.c (globals_of_w32):
8861 * window.c (syms_of_window):
8862 * xdisp.c (syms_of_xdisp):
8863 * xfaces.c (syms_of_xfaces):
8864 * xfns.c (syms_of_xfns):
8865 * xmenu.c (syms_of_xmenu):
8866 * xsettings.c (syms_of_xsettings):
8867 * xterm.c (syms_of_xterm): Use DEFSYM.
8869 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8871 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8873 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8875 Integer and buffer overflow fixes (Bug#8873).
8877 * print.c (printchar, strout): Check for string overflow.
8878 (PRINTPREPARE, printchar, strout):
8879 Don't set size unless allocation succeeds.
8881 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8882 for sizes. Check for string overflow more accurately.
8883 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8885 * macros.c: Integer and buffer overflow fixes.
8886 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8887 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8888 Use ptrdiff_t, not int, for sizes.
8889 Don't increment bufsize until after realloc succeeds.
8890 Check for size-calculation overflow.
8891 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8893 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8895 * lread.c: Integer overflow fixes.
8896 (read_integer): Radix is now EMACS_INT, not int,
8897 to improve quality of diagnostics for out-of-range radices.
8898 Calculate buffer size correctly for out-of-range radices.
8899 (read1): Check for integer overflow in radices, and in
8900 read-circle numbers.
8901 (read_escape): Avoid int overflow.
8902 (Fload, openp, read_buffer_size, read1)
8903 (substitute_object_recurse, read_vector, read_list, map_obarray):
8904 Use ptrdiff_t, not int, for sizes.
8905 (read1): Use EMACS_INT, not int, for sizes.
8906 Check for size overflow.
8908 * image.c (cache_image): Check for size arithmetic overflow.
8910 * lread.c: Integer overflow issues.
8911 (saved_doc_string_size, saved_doc_string_length)
8912 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8913 Now ptrdiff_t, not int.
8914 (read1): Don't assume doc string length fits in int. Check for
8915 out-of-range doc string lengths.
8916 (read_list): Don't assume file position fits in int.
8917 (read_escape): Check for hex character overflow.
8919 2011-06-22 Leo Liu <sdl.web@gmail.com>
8921 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8922 Move to minibuffer.el.
8924 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8926 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8927 The following patches are for when GLYPH_DEBUG && !XASSERT.
8928 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8929 * dispnew.c (flush_stdout):
8930 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8931 Mark as externally visible.
8932 * dispnew.c (check_window_matrix_pointers): Now static.
8933 * dispnew.c (window_to_frame_vpos):
8934 * xfns.c (unwind_create_frame):
8935 * xterm.c (x_check_font): Remove unused local.
8936 * scroll.c (CHECK_BOUNDS):
8937 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8938 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8939 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8940 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8941 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8943 (debug_method_add): Use va_list and vsprintf rather than relying
8944 on undefined behavior with wrong number of arguments.
8945 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8946 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8947 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8948 since we're not interested in debugging glyphs with old libraries.
8949 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8950 GCC 4.6.0's static checking.
8952 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8954 Integer overflow and signedness fixes (Bug#8873).
8955 A few related buffer overrun fixes, too.
8957 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8959 * dispextern.h (struct face.stipple):
8960 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8961 (x_bitmap_mask, x_allocate_bitmap_record)
8962 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8963 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8964 (x_create_bitmap_from_xpm_data):
8965 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8966 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8968 * xfaces.c (load_pixmap):
8969 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8970 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8971 (.bitmaps_last, struct x_output.icon_bitmap):
8972 Use ptrdiff_t, not int, for bitmap indexes.
8973 (x_allocate_bitmap_record): Check for size overflow.
8974 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8976 Use ptrdiff_t, not int, for overlay counts.
8977 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8978 * editfns.c (overlays_around, get_pos_property):
8979 * textprop.c (get_char_property_and_overlay):
8980 * xdisp.c (next_overlay_change, note_mouse_highlight):
8981 * xfaces.c (face_at_buffer_position):
8982 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8983 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8984 (Fnext_overlay_change, Fprevious_overlay_change)
8985 (mouse_face_overlay_overlaps, Foverlays_in):
8986 Use ptrdiff_t, not int, for sizes.
8987 (overlays_at, overlays_in): Check for size-calculation overflow.
8989 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8991 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8992 (x_session_initialize): Do not assume string length fits in int.
8994 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8995 This is unlikely, but can occur if DPI is outlandish.
8997 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8998 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9000 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9001 * xrdb.c (magic_file_p, search_magic_path):
9002 Omit last arg SUFFIX; it was always 0. All callers changed.
9003 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9005 * xfont.c (xfont_match): Avoid need for strlen.
9007 * xfns.c: Don't assume strlen fits in int.
9008 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9010 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9011 not unsigned long, as we prefer signed integers. All callers changed.
9012 Detect integer overflow in repeat count.
9013 (message_dolog): Don't assume print length fits in 39 bytes.
9014 (display_mode_element): Don't assume strlen fits in int.
9016 * termcap.c: Don't assume sizes fit in int and never overflow.
9017 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9018 (gobble_line): Check for size-calculation overflow.
9020 * minibuf.c (Fread_buffer):
9021 * lread.c (intern, intern_c_string):
9022 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9023 Don't assume string length fits in int.
9025 * keyboard.c (parse_tool_bar_item):
9026 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9028 * font.c: Don't assume string length fits in int.
9029 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9030 Use ptrdiff_t, not int.
9031 (font_intern_prop): Don't assume string length fits in int.
9032 Don't assume integer property fits in fixnum.
9033 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9035 * filelock.c: Fix some buffer overrun and integer overflow issues.
9036 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9037 Reformulate so as not to need the command string.
9038 Invoke gzip -cd rather than gunzip, as it's more portable.
9039 (lock_info_type, lock_file_1, lock_file):
9040 Don't assume pid_t and time_t fit in unsigned long.
9041 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9042 (current_lock_owner): Prefer signed type for sizes.
9043 Use memcpy, not strncpy, where memcpy is what is really wanted.
9044 Don't assume (via atoi) that time_t and pid_t fit in int.
9045 Check for time_t and/or pid_t out of range, e.g., via a network share.
9046 Don't alloca where an auto var works fine.
9048 * fileio.c: Fix some integer overflow issues.
9049 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9050 Don't assume string length fits in int.
9051 (directory_file_name): Don't assume string length fits in long.
9052 (make_temp_name): Don't assume pid fits in int, or that its print
9053 length is less than 20.
9055 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9057 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9059 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9061 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9062 We prefer signed integers, even for size calculations.
9064 * emacs.c: Don't assume string length fits in 'int'.
9065 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9066 (main): Don't invoke strlen when not needed.
9068 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9069 (XD_DEBUG_MESSAGE): Don't waste a byte.
9071 * callproc.c (getenv_internal_1, getenv_internal)
9073 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9075 * lread.c (invalid_syntax): Omit length argument.
9076 All uses changed. This doesn't fix a bug, but it simplifies the
9077 code away from its former Hollerith-constant appearance, and it's
9078 one less 'int' to worry about when looking at integer-overflow issues.
9079 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9081 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9082 This didn't break anything, but it didn't help either.
9083 It's confusing to put a bogus integer in a place where the actual
9084 value does not matter.
9085 (LIST_END_P): Remove unused macro and its bogus comment.
9086 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9088 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9089 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9091 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9092 We prefer signed types, and the value cannot exceed the EMACS_INT
9093 range anyway (because otherwise the length would not be representable).
9094 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9095 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9096 This avoids a GCC warning when WIDE_EMACS_INT.
9098 * indent.c (sane_tab_width): New function.
9099 (current_column, scan_for_column, Findent_to, position_indentation)
9100 (compute_motion): Use it. This is just for clarity.
9101 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9103 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9105 * lisp.h (lint_assume): New macro.
9106 * composite.c (composition_gstring_put_cache):
9107 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9109 * editfns.c, insdel.c:
9110 Omit unnecessary forward decls, to simplify future changes.
9112 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9114 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9116 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9117 Use much-faster test for byte-length change.
9118 Don't assume string byte-length fits in 'int'.
9119 Check that character arg fits in 'int'.
9120 (mapcar1): Declare byte as byte, for clarity.
9122 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9124 * fns.c (concat): Catch string overflow earlier.
9125 Do not rely on integer wraparound.
9127 * dispextern.h (struct it.overlay_strings_charpos)
9128 (struct it.selective): Now EMACS_INT, not int.
9129 * xdisp.c (forward_to_next_line_start)
9130 (back_to_previous_visible_line_start)
9131 (reseat_at_next_visible_line_start, next_element_from_buffer):
9132 Don't arbitrarily truncate the value of 'selective' to int.
9134 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9136 * composite.c: Don't truncate sizes to 'int'.
9137 (composition_gstring_p, composition_reseat_it)
9138 (composition_adjust_point): Use EMACS_INT, not int.
9139 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9140 not EMACS_UINT, for indexes.
9142 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9144 * buffer.c: Include <verify.h>.
9145 (struct sortvec.priority, struct sortstr.priority):
9146 Now EMACS_INT, not int.
9147 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9148 (struct sortstr.size, record_overlay_string)
9149 (struct sortstrlist.size, struct sortlist.used):
9150 Don't truncate size to int.
9151 (record_overlay_string): Check for size-calculation overflow.
9152 (init_buffer_once): Check at compile-time, not run-time.
9154 2011-06-22 Jim Meyering <meyering@redhat.com>
9156 Don't leak an XBM-image-sized buffer
9157 * image.c (xbm_load): Free the image buffer after using it.
9159 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9162 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9163 that Sun C diagnosed.
9164 * fns.c (secure_hash): Fix pointer signedness issue.
9165 * intervals.c (static_offset_intervals): New function.
9166 (offset_intervals): Use it.
9168 2011-06-21 Leo Liu <sdl.web@gmail.com>
9171 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9174 * fns.c (secure_hash): Rename from crypto_hash_function and change
9175 the first arg to accept symbols.
9176 (Fsecure_hash): New primitive.
9177 (syms_of_fns): New symbols.
9179 2011-06-20 Deniz Dogan <deniz@dogan.se>
9181 * process.c (Fset_process_buffer): Clarify return value in
9184 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9186 * dispnew.c (add_window_display_history): Use BVAR.
9188 * xdisp.c (debug_method_add): Use BVAR.
9189 (check_window_end, dump_glyph_matrix, dump_glyph)
9190 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9192 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9195 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9196 check till after the cache is created in init_frame_faces.
9198 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9200 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9202 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9204 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9205 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9206 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9208 Improve buffer-overflow checking (Bug#8873).
9209 * fileio.c (Finsert_file_contents):
9210 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9211 Remove the old (too-loose) buffer overflow checks.
9212 They weren't needed, since make_gap checks for buffer overflow.
9213 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9214 The old code merely checked for Emacs fixnum overflow, and relied
9215 on undefined (wraparound) behavior. The new code avoids undefined
9216 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9218 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9219 Tune. Don't use wider integers than needed. Don't use alloca.
9220 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9222 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9224 * insdel.c, lisp.h (buffer_overflow): New function.
9225 (insert_from_buffer_1, replace_range, replace_range_2):
9226 * insdel.c (make_gap_larger):
9227 * editfns.c (Finsert_char):
9228 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9230 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9232 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9234 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9236 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9237 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9239 * fileio.c: Don't assume EMACS_INT fits in off_t.
9240 (emacs_lseek): New static function.
9241 (Finsert_file_contents, Fwrite_region): Use it.
9242 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9244 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9246 * fns.c: Don't overflow int when computing a list length.
9247 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9248 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9249 truncation on 64-bit hosts. Check for QUIT every
9250 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9251 faster and is responsive enough.
9252 (Flength): Report an error instead of overflowing an integer.
9253 (Fsafe_length): Return a float if the value is not representable
9254 as a fixnum. This shouldn't happen except in contrived situations.
9255 (Fnthcdr, Fsort): Don't assume list length fits in int.
9256 (Fcopy_sequence): Don't assume vector length fits in int.
9258 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9259 (header_size, word_size): New constants.
9260 (allocate_vectorlike): Don't check size overflow here.
9261 (allocate_vector): Check it here instead, since this is the only
9262 caller of allocate_vectorlike that could cause overflow.
9263 Check that the new vector's length is representable as a fixnum.
9265 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9266 The previous code was bogus. For example, next_almost_prime (32)
9267 returned 39, which is undesirable as it is a multiple of 3; and
9268 next_almost_prime (24) returned 25, which is a multiple of 5 so
9269 why was the code bothering to check for multiples of 7?
9271 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9273 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9275 Variadic C functions now count arguments with ptrdiff_t.
9276 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9277 Back then I didn't know that the Emacs coding style prefers signed int.
9278 Also, in the meantime I found a few more instances where arguments
9279 were being counted with int, which may truncate counts on 64-bit
9280 machines, or EMACS_INT, which may be unnecessarily wide.
9281 * lisp.h (struct Lisp_Subr.function.aMANY)
9282 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9283 Arg counts are now ptrdiff_t, not size_t.
9284 All variadic functions and their callers changed accordingly.
9285 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9286 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9287 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9288 * callint.c (Fcall_interactively): Check arg count for overflow,
9289 to avoid potential buffer overrun. Use signed char, not 'int',
9290 for 'varies' array, so that we needn't bother to check its size
9291 calculation for overflow.
9292 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9293 * eval.c (apply_lambda):
9294 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9295 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9296 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9298 * callint.c (Fcall_interactively): Don't use index var as event count.
9300 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9301 * mem-limits.h (SIZE): Remove; no longer used.
9303 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9305 Remove unnecessary casts.
9306 * xterm.c (x_term_init):
9307 * xfns.c (x_set_border_pixel):
9308 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9309 These aren't needed now that we assume ANSI C.
9311 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9312 It's more likely to cause problems (due to unsigned overflow)
9315 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9317 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9319 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9321 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9323 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9325 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9327 GLYPH_CODE_FACE returns EMACS_INT, not int.
9328 * dispextern.h (merge_faces):
9329 * xfaces.c (merge_faces):
9330 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9331 Don't assume EMACS_INT fits in int.
9333 * character.h (CHAR_VALID_P): Remove unused parameter.
9334 * fontset.c, lisp.h, xdisp.c: All uses changed.
9336 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9338 * fns.c (concat): Minor tuning based on overflow analysis.
9339 This doesn't fix any bugs. Use int to hold character, instead
9340 of constantly refetching from Emacs object. Use XFASTINT, not
9341 XINT, for value known to be a character. Don't bother comparing
9342 a single byte to 0400, as it's always less.
9344 * floatfns.c (Fexpt):
9345 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9347 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9350 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9352 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9353 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9354 incorrectly succeed when S was a string, because 4294967386 was
9355 truncated before it was used.
9357 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9358 Otherwise, an out-of-range integer could cause undefined behavior
9361 * composite.c: Use int, not EMACS_INT, for characters.
9362 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9363 EMACS_INT, for values that are known to be in character range.
9364 This doesn't fix any bugs but is the usual style inside Emacs and
9365 may generate better code on 32-bit machines.
9367 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9368 This is for reasons similar to the recent CHAR_STRING fix.
9369 * charset.c (Fencode_char): Check that character arg is actually
9370 a character. Pass an int to ENCODE_CHAR.
9371 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9372 wider than 'int', as a compile-time check to prevent future regressions
9375 * character.c (char_string): Remove unnecessary casts.
9377 Make sure a 64-bit char is never passed to CHAR_STRING.
9378 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9379 by silently ignoring the top 32 bits, allowing some values
9380 that were far too large to be valid characters.
9381 * character.h: Include <verify.h>.
9382 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9383 arguments are no wider than unsigned, as a compile-time check
9384 to prevent future regressions in this area.
9386 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9387 (Fsubst_char_in_region):
9389 * xdisp.c (decode_mode_spec_coding):
9390 Adjust to CHAR_STRING's new requirement.
9391 * editfns.c (Finsert_char, Fsubst_char_in_region):
9392 * fns.c (concat): Check that character args are actually
9393 characters. Without this test, these functions did the wrong
9394 thing with wildly out-of-range values on 64-bit hosts.
9396 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9397 These casts should not be needed on 32-bit hosts, either.
9398 * keyboard.c (read_char):
9399 * lread.c (Fload): Remove casts to unsigned.
9401 * lisp.h (UNSIGNED_CMP): New macro.
9402 This fixes comparison bugs on 64-bit hosts.
9403 (ASCII_CHAR_P): Use it.
9404 * casefiddle.c (casify_object):
9405 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9406 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9407 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9408 * dispextern.h (FACE_FROM_ID):
9409 * keyboard.c (read_char): Use UNSIGNED_CMP.
9411 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9412 not to EMACS_INT, to avoid GCC warning.
9414 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9416 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9417 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9418 isn't needed on 32-bit machines.
9420 * buffer.c (Fgenerate_new_buffer_name):
9421 Use EMACS_INT for count, not int.
9422 (advance_to_char_boundary): Return EMACS_INT, not int.
9424 * data.c (Qcompiled_function): Now static.
9426 * window.c (window_body_lines): Now static.
9428 * image.c (gif_load): Rename local to avoid shadowing.
9430 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9431 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9432 * alloc.c (make_save_value): Integer argument is now of type
9434 (mark_object): Use ptrdiff_t, not int.
9435 * lisp.h (pD): New macro.
9436 * print.c (print_object): Use it.
9438 * alloc.c: Use EMACS_INT, not int, to count objects.
9439 (total_conses, total_markers, total_symbols, total_vector_size)
9440 (total_free_conses, total_free_markers, total_free_symbols)
9441 (total_free_floats, total_floats, total_free_intervals)
9442 (total_intervals, total_strings, total_free_strings):
9443 Now EMACS_INT, not int. All uses changed.
9444 (Fgarbage_collect): Compute overall total using a double, so that
9445 integer overflow is less likely to be a problem. Check for overflow
9446 when converting back to an integer.
9447 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9448 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9449 These were 'int' variables that could overflow on 64-bit hosts;
9450 they were never used, so remove them instead of repairing them.
9451 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9452 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9453 Previously, this ceilinged at INT_MAX, but that doesn't work on
9455 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9457 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9458 (allocate_vectorlike): Check for ptrdiff_t overflow.
9459 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9460 when a (possibly-narrower) signed value would do just as well.
9461 We prefer using signed arithmetic, to avoid comparison confusion.
9463 * alloc.c: Catch some string size overflows that we were missing.
9464 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9465 for convenience in STRING_BYTES_MAX.
9466 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9467 The definition here is exact; the one in lisp.h was approximate.
9468 (allocate_string_data): Check for string overflow. This catches
9469 some instances we weren't catching before. Also, it catches
9470 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9471 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9472 and ptrdiff_t and EMACS_INT are both 64 bits.
9474 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9475 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9476 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9478 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9480 * alloc.c (Fmake_string): Check for out-of-range init.
9482 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9484 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9486 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9488 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9489 xg_get_default_scrollbar_width.
9491 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9492 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9493 (style_changed_cb): Call update_theme_scrollbar_width and call
9494 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9495 all frames (Bug#8505).
9496 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9497 Call gtk_window_set_resizable if HAVE_GTK3.
9498 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9499 and height if HAVE_GTK3 (Bug#8505).
9500 (scroll_bar_width_for_theme): New variable.
9501 (update_theme_scrollbar_width): New function.
9502 (xg_get_default_scrollbar_width): Move code to
9503 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9504 (xg_initialize): Call update_theme_scrollbar_width.
9506 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9508 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9510 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9512 * frame.c (make_frame): Call other_buffer_safely instead of
9515 * window.c (temp_output_buffer_show): Call display_buffer with
9516 second argument Vtemp_buffer_show_specifiers and reset latter
9517 immediately after the call.
9518 (Vtemp_buffer_show_specifiers): New variable.
9519 (auto_window_vscroll_p, next_screen_context_lines)
9520 (Vscroll_preserve_screen_position): Remove leading asterisks from
9523 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9525 Fix minor problems found by GCC 4.6.0 static checking.
9526 * buffer.c (Qclone_number): Remove for now, as it's unused.
9527 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9528 (record_buffer): Remove unused local.
9529 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9530 (set_frame_buffer_list): Remove; unused.
9531 * frame.h (other_visible_frames): Remove decl.
9532 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9533 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9534 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9536 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9537 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9538 Define only if HAVE_GPM.
9539 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9540 (update_hints_inhibit): Remove; never set. All uses removed.
9541 * widgetprv.h (emacsFrameClassRec): Remove decl.
9542 * window.c (delete_deletable_window): Now returns void, since it
9543 wasn't returning anything.
9544 (compare_window_configurations): Remove unused locals.
9545 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9546 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9547 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9548 the same widths as pointers. This follows up on the 2011-05-06 patch.
9549 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9550 * xterm.h: Likewise.
9551 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9553 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9555 * makefile.w32-in: Update dependencies.
9556 (LISP_H): Add lib/intprops.h.
9558 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9560 * image.c (gif_load): Add animation frame delay to the metadata.
9561 (syms_of_image): Use DEFSYM. New symbol `delay'.
9563 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9565 * window.c (delete_deletable_window): Re-add.
9566 (Fset_window_configuration): Rewrite to handle dead buffers and
9567 consequently deletable windows.
9568 (window_tree, Fwindow_tree): Remove. Supply functionality in
9570 (compare_window_configurations): Simplify code.
9572 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9574 * image.c (imagemagick_load_image): Fix type mismatch.
9575 (Fimagemagick_types): Likewise.
9577 * window.h (replace_buffer_in_windows): Declare.
9579 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9581 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9582 Qclone_number. Remove external declaration of Qdelete_window.
9583 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9585 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9586 Run Qbuffer_list_update_hook if allowed.
9587 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9588 buffer list implementation.
9589 (other_buffer_safely): New function.
9590 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9591 calls to replace_buffer_in_windows and
9592 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9594 (record_buffer): Inhibit quitting and rewrite using quittable
9595 functions. Run Qbuffer_list_update_hook if allowed.
9596 (Frecord_buffer, Funrecord_buffer): New functions.
9597 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9598 Move switch-to-buffer to window.el.
9599 (bury-buffer): Move to window.el.
9600 (Vbuffer_list_update_hook): New variable.
9602 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9605 * window.h (resize_frame_windows): Move up in code.
9606 (Fwindow_frame): Remove EXFUN.
9607 (replace_buffer_in_all_windows): Remove prototype.
9608 (replace_buffer_in_windows_safely): Add prototype.
9610 * window.c: Declare Qdelete_window static again. Move down
9611 declaration of select_count.
9612 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9613 (Fother_window): Move to window.el.
9614 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9615 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9616 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9618 (replace_buffer_in_windows): Implement by calling
9619 Qreplace_buffer_in_windows.
9620 (replace_buffer_in_all_windows): Remove with some functionality
9621 moved into replace_buffer_in_windows_safely.
9622 (replace_buffer_in_windows_safely): New function.
9623 (select_window_norecord, select_frame_norecord): Move in front
9624 of run_window_configuration_change_hook. Remove now obsolete
9626 (Fset_window_buffer): Rewrite doc-string.
9627 Call Qrecord_window_buffer.
9628 (keys_of_window): Move binding for other-window to window.el.
9630 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9632 * dispextern.h (struct image): Replace data member, whose int_val
9633 and ptr_val fields were not used by anything, with a single
9636 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9637 (gif_clear_image, gif_load, imagemagick_load_image)
9638 (gs_clear_image, gs_load): Callers changed.
9640 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9642 * buffer.h: Include <time.h>, for time_t.
9643 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9645 Fix minor problems found by static checking.
9647 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9649 Make identifiers static if they are not used in other modules.
9650 * data.c (Qcompiled_function, Qframe, Qvector):
9651 * image.c (QimageMagick, Qsvg):
9652 * minibuf.c (Qmetadata):
9653 * window.c (resize_window_check, resize_root_window): Now static.
9654 * window.h (resize_window_check, resize_root_window): Remove decls.
9656 * window.c (window_deletion_count, delete_deletable_window):
9658 (window_body_lines): Now static.
9659 (Fdelete_other_windows_internal): Mark vars as initialized.
9660 Make sure 'resize_failed' is initialized.
9661 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9662 (resize_window_apply): Remove unused local.
9663 * window.h (delete_deletable_window): Remove decl.
9665 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9666 (imagemagick_load_image): Fix pointer signedness problem by changing
9667 last arg from unsigned char * to char *. All uses changed.
9668 Also, fix a local for similar reasons.
9669 Remove unused locals. Remove locals to avoid shadowing.
9670 (fn_rsvg_handle_free): Remove; unused.
9671 (svg_load, svg_load_image): Fix pointer signedness problem.
9672 (imagemagick_load_image): Don't use garbage pointer image_wand.
9674 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9676 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9678 * image.c (gif_load): Fix omitted cast error introduced by
9681 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9683 * window.h (resize_proportionally, orig_total_lines)
9684 (orig_top_line): Remove from window structure.
9685 (set_window_height, set_window_width, change_window_heights)
9686 (Fdelete_window): Remove prototypes.
9687 (resize_frame_windows): Remove duplicate declaration.
9689 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9691 * window.h (resize_frame_windows, resize_window_check)
9692 (delete_deletable_window, resize_root_window)
9693 (resize_frame_windows): Declare prototypes.
9695 * window.c (resize_window_apply): Make definition be "static" to
9696 match the prototype.
9698 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9700 * window.c: Remove declarations of Qwindow_size_fixed,
9701 window_min_size_1, window_min_size_2, window_min_size,
9702 size_window, window_fixed_size_p, enlarge_window, delete_window.
9703 Remove static from declaration of Qdelete_window, it's
9704 temporarily needed by Fbury_buffer.
9705 (replace_window): Don't assign orig_top_line and
9707 (Fdelete_window, delete_window): Remove. Window deletion is
9708 handled by window.el.
9709 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9710 Replace Fdelete_window calls with calls to Qdelete_window.
9711 (Fdelete_other_windows): Remove. Deleting other windows is
9712 handled by window.el.
9713 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9714 handled in window.el.
9715 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9716 Window minimum sizes are handled in window.el.
9717 (shrink_windows, size_window, set_window_height)
9718 (set_window_width, change_window_heights, window_height)
9719 (window_width, CURBEG, CURSIZE, enlarge_window)
9720 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9721 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9722 handled in window.el.
9723 (make_dummy_parent): Rename to make_parent_window and give it a
9724 second argument horflag.
9725 (make_window): Don't set resize_proportionally any more.
9726 (Fsplit_window): Remove. Windows are split in window.el.
9727 (save_restore_action, save_restore_orig_size)
9728 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9729 Resize mini windows in window.el.
9730 (grow_mini_window, shrink_mini_window): Implement by calling
9731 Qresize_root_window_vertically, resize_window_check and
9732 resize_window_apply.
9733 (saved_window, Fset_window_configuration, save_window_save):
9734 Do not handle orig_top_line, orig_total_lines, and
9735 resize_proportionally.
9736 (window_min_height, window_min_width): Move to window.el.
9737 (keys_of_window): Move bindings for delete-other-windows,
9738 split-window, delete-window and enlarge-window to window.el.
9740 * buffer.c: Temporarily extern Qdelete_window.
9741 (Fbury_buffer): Temporarily call Qdelete_window instead of
9742 Fdelete_window (Fbury_buffer will move to window.el soon).
9744 * frame.c (set_menu_bar_lines_1): Remove code handling
9745 orig_top_line and orig_total_lines.
9747 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9748 set_window_height but set heights directly.
9749 (change_frame_size_1): Use resize_frame_windows.
9751 * xdisp.c (init_xdisp): Don't use set_window_height but set
9754 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9755 Use resize_frame_windows instead of change_window_heights and run
9756 run_window_configuration_change_hook.
9758 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9759 instead of change_window_heights and run
9760 run_window_configuration_change_hook.
9762 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9764 * window.c (replace_window): Rename second argument REPLACEMENT to
9765 NEW. New third argument SETFLAG. Rewrite.
9766 (delete_window, make_dummy_parent): Call replace_window with
9768 (window_list_1): Move down in code.
9769 (run_window_configuration_change_hook): Move set_buffer part
9770 before select_frame_norecord part in order to unwind correctly.
9771 Rename count1 to count.
9772 (recombine_windows, delete_deletable_window, resize_root_window)
9773 (Fdelete_other_windows_internal)
9774 (Frun_window_configuration_change_hook, make_parent_window)
9775 (resize_window_check, resize_window_apply, Fresize_window_apply)
9776 (resize_frame_windows, Fsplit_window_internal)
9777 (Fdelete_window_internal, Fresize_mini_window_internal):
9779 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9781 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9783 * window.h (window): Add some new members to window structure -
9784 normal_lines, normal_cols, new_total, new_normal, clone_number,
9785 splits, nest, prev_buffers, next_buffers.
9786 (WINDOW_TOTAL_SIZE): Move here from window.c.
9787 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9789 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9791 (make_dummy_parent): Set new members of windows structure.
9792 (make_window): Move down in code. Handle new members of window
9794 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9795 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9796 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9797 (Fset_window_prev_buffers, Fwindow_next_buffers)
9798 (Fset_window_next_buffers, Fset_window_clone_number):
9800 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9801 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9803 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9804 Argument WINDOW can be now internal window too.
9805 (Fwindow_use_time): Move up in code.
9806 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9808 (Fset_window_configuration, saved_window)
9809 (Fcurrent_window_configuration, save_window_save): Handle new
9810 members of window structure.
9811 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9812 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9813 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9814 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9815 Qget_mru_window, Qresize_root_window,
9816 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9817 Qauto_buffer_name; staticpro them.
9819 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9821 * window.c (Fwindow_total_size, Fwindow_left_column)
9822 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9823 (Fwindow_list_1): New functions.
9824 (window_box_text_cols): Replace with window_body_cols.
9825 (Fwindow_width, Fscroll_left, Fscroll_right):
9826 Use window_body_cols instead of window_box_text_cols.
9827 (delete_window, Fset_window_configuration):
9828 Call delete_all_subwindows with window as argument.
9829 (delete_all_subwindows): Take a window as argument and not a
9831 (window_loop): Remove handling of GET_LRU_WINDOW and
9833 (Fget_lru_window, Fget_largest_window): Move to window.el.
9835 * window.h: Extern window_body_cols instead of
9836 window_box_text_cols. delete_all_subwindows now takes a
9837 Lisp_Object as argument.
9839 * indent.c (compute_motion, Fcompute_motion):
9840 Use window_body_cols instead of window_box_text_cols.
9842 * frame.c (delete_frame): Call delete_all_subwindows with root
9845 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9847 * fns.c (Fputhash): Document return value.
9849 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9851 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9853 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9855 Cons<->int and similar integer overflow fixes (Bug#8794).
9857 Check for overflow when converting integer to cons and back.
9858 * charset.c (Fdefine_charset_internal, Fdecode_char):
9859 Use cons_to_unsigned to catch overflow.
9860 (Fencode_char): Use INTEGER_TO_CONS.
9861 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9862 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9863 * data.c (long_to_cons, cons_to_long): Remove.
9864 (cons_to_unsigned, cons_to_signed): New functions.
9865 These signal an error for invalid or out-of-range values.
9866 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9867 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9868 * font.c (Ffont_variation_glyphs):
9869 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9870 * lisp.h: Include <intprops.h>.
9871 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9872 (cons_to_signed, cons_to_unsigned): New decls.
9873 (long_to_cons, cons_to_long): Remove decls.
9874 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9875 (Fprimitive_undo): Use CONS_TO_INTEGER.
9876 * xfns.c (Fx_window_property): Likewise.
9877 * xselect.c: Include <limits.h>.
9878 (x_own_selection, selection_data_to_lisp_data):
9879 Use INTEGER_TO_CONS.
9880 (x_handle_selection_request, x_handle_selection_clear)
9881 (x_get_foreign_selection, Fx_disown_selection_internal)
9882 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9883 (lisp_data_to_selection_data): Use cons_to_unsigned.
9884 (x_fill_property_data): Use cons_to_signed.
9885 Report values out of range.
9887 Check for buffer and string overflow more precisely.
9888 * buffer.h (BUF_BYTES_MAX): New macro.
9889 * lisp.h (STRING_BYTES_MAX): New macro.
9890 * alloc.c (Fmake_string):
9891 * character.c (string_escape_byte8):
9892 * coding.c (coding_alloc_by_realloc):
9893 * doprnt.c (doprnt):
9894 * editfns.c (Fformat):
9896 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9897 since they may not be the same number.
9898 * editfns.c (Finsert_char):
9899 * fileio.c (Finsert_file_contents):
9900 Likewise for BUF_BYTES_MAX.
9902 * image.c: Use ptrdiff_t, not int, for sizes.
9903 (slurp_file): Switch from int to ptrdiff_t.
9905 (slurp_file): Check that file size fits in both size_t (for
9906 malloc) and ptrdiff_t (for sanity and safety).
9908 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9909 if b->modtime has its maximal value.
9911 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9913 Don't assume time_t can fit into int.
9914 * buffer.h (struct buffer.modtime): Now time_t, not int.
9915 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9916 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9918 Minor fixes for signed vs unsigned integers.
9919 * character.h (MAYBE_UNIFY_CHAR):
9920 * charset.c (maybe_unify_char):
9921 * keyboard.c (read_char, reorder_modifiers):
9922 XINT -> XFASTINT, since the integer must be nonnegative.
9923 * ftfont.c (ftfont_spec_pattern):
9924 * keymap.c (access_keymap, silly_event_symbol_error):
9925 XUINT -> XFASTINT, since the integer must be nonnegative.
9926 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9927 since it makes no difference and we prefer signed.
9928 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9929 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9932 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9934 * window.h (Fwindow_frame): Declare.
9936 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9938 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9939 (SPARE_MEMORY): Always define.
9940 (LARGE_REQUEST): Remove.
9941 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9943 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9945 * lisp.h: Move EXFUNS for Fframe_root_window,
9946 Fframe_first_window and Fset_frame_selected_window to window.h.
9948 * window.h: Move EXFUNS for Fframe_root_window,
9949 Fframe_first_window and Fset_frame_selected_window here from
9952 * frame.c (Fwindow_frame, Fframe_first_window)
9953 (Fframe_root_window, Fframe_selected_window)
9954 (Fset_frame_selected_window): Move to window.c.
9955 (Factive_minibuffer_window): Move to minibuf.c.
9956 (Fother_visible_frames_p): New function.
9958 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9960 * window.c (decode_window, decode_any_window): Move up in code.
9961 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9962 (inhibit_frame_unsplittable): Remove unused variable.
9963 (Fwindow_buffer): Move up and rewrite doc-string.
9964 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9965 (Fwindow_prev): New functions.
9966 (Fwindow_frame): Move here from frame.c. Accept any window as
9968 (Fframe_root_window, Fframe_first_window)
9969 (Fframe_selected_window): Move here from frame.c. Accept frame
9970 or arbitrary window as argument. Update doc-strings.
9971 (Fminibuffer_window): Move up in code.
9972 (Fwindow_minibuffer_p): Move up in code and simplify.
9973 (Fset_frame_selected_window): Move here from frame.c.
9975 (Fselected_window, select_window, Fselect_window): Move up in
9976 code. Minor doc-string fixes.
9978 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9980 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9981 Do not assume that spare memory exists; that assumption is valid
9982 only if SYSTEM_MALLOC.
9983 (LARGE_REQUEST): New macro, so that the issue of large requests
9984 is separated from the issue of spare memory.
9986 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9988 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9991 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9993 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9996 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9998 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10000 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10002 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10003 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10005 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10007 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10009 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10011 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10012 (x_clipboard_manager_save): Add return value.
10013 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10014 New error handlers.
10015 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10016 Obey Vx_select_enable_clipboard_manager. Catch errors in
10017 x_clipboard_manager_save (Bug#8779).
10018 (Vx_select_enable_clipboard_manager): New variable.
10019 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10021 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10023 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10025 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10027 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10028 in the current matrix if keep_current_p is non-zero.
10030 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10032 * bidi.c (bidi_level_of_next_char): Fix last change.
10034 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10036 Support bidi reordering of text covered by display properties.
10038 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10039 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10040 (bidi_cache_search, bidi_cache_iterator_state)
10041 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10042 (bidi_level_of_next_char, bidi_move_to_visually_next):
10043 Support character positions inside a run of characters covered by a
10045 (bidi_paragraph_init, bidi_resolve_explicit_1)
10046 (bidi_level_of_next_char): Call bidi_fetch_char and
10047 bidi_fetch_char_advance instead of FETCH_CHAR and
10048 FETCH_CHAR_ADVANCE.
10049 (bidi_init_it): Initialize new members.
10050 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10052 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10053 instead of using explicit *_CHAR codes.
10054 (bidi_resolve_explicit, bidi_resolve_weak):
10055 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10056 bidirectional text is supported only in multibyte buffers.
10057 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10058 it to initialize the frame_window_p member of struct bidi_it.
10059 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10060 (bidi_resolve_explicit, bidi_resolve_weak)
10061 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10062 bidi_it->nchars is non-positive.
10063 (bidi_level_of_next_char): Don't try to lookup the cache for the
10064 next/previous character if nothing is cached there yet, or if we
10065 were just reseat()'ed to a new position.
10067 * xdisp.c (set_cursor_from_row): Set start and stop points
10068 according to the row's direction when priming the loop that looks
10069 for the glyph on which to display cursor.
10070 (single_display_spec_intangible_p): Function deleted.
10071 (display_prop_intangible_p): Reimplement to call
10072 handle_display_spec instead of single_display_spec_intangible_p.
10073 Accept 3 additional arguments needed by handle_display_spec.
10074 This fixes incorrect cursor motion across display property with complex
10075 values: lists, `(when COND...)' forms, etc.
10076 (single_display_spec_string_p): Support property values that are
10077 lists with the argument STRING its top-level element.
10078 (display_prop_string_p): Fix the condition for processing a
10079 property that is a list to be consistent with handle_display_spec.
10080 (handle_display_spec): New function, refactored from the
10081 last portion of handle_display_prop.
10082 (compute_display_string_pos): Accept additional argument
10083 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10084 value of a `display' property is a "replacing spec".
10085 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10086 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10087 the display property, but just return a value indicating whether
10088 the display property will replace the characters it covers.
10089 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10090 frame_window_p members of struct bidi_it.
10091 (compute_display_string_pos, compute_display_string_end):
10093 (push_it): Accept second argument POSITION, where pop_it should
10094 jump to continue iteration.
10095 (reseat_1): Initialize bidi_it.disp_pos.
10097 * keyboard.c (adjust_point_for_property): Adjust the call to
10098 display_prop_intangible_p to its new signature.
10100 * dispextern.h (struct bidi_it): New member frame_window_p.
10101 (bidi_init_it): Update prototypes.
10102 (display_prop_intangible_p): Update prototype.
10103 (compute_display_string_pos, compute_display_string_end):
10104 Declare prototypes.
10105 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10108 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10110 Malloc failure behavior now depends on size of allocation.
10111 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10112 * lisp.h: Change signatures accordingly.
10113 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10114 All callers changed. (Bug#8762)
10116 * gnutls.c: Use Emacs's memory allocators.
10117 Without this change, the gnutls library would invoke malloc etc.
10118 directly, which causes problems on non-SYNC_INPUT hosts, and which
10119 runs afoul of improving memory_full behavior. (Bug#8761)
10120 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10121 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10122 xfree instead of the default malloc, realloc, free.
10123 (Fgnutls_boot): No need to check for memory allocation failure,
10124 since xmalloc does that for us.
10126 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10127 * category.c (hash_get_category_set):
10128 * ccl.c (ccl_driver):
10129 * charset.c (Fdefine_charset_internal):
10130 * charset.h (struct charset.hash_index):
10131 * composite.c (get_composition_id, gstring_lookup_cache)
10132 (composition_gstring_put_cache):
10133 * composite.h (struct composition.hash_index):
10134 * dispextern.h (struct image.hash):
10135 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10136 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10137 (hashfn_equal, hashfn_user_defined, make_hash_table)
10138 (maybe_resize_hash_table, hash_lookup, hash_put)
10139 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10140 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10141 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10142 * image.c (make_image, search_image_cache, lookup_image)
10143 (xpm_put_color_table_h):
10144 * lisp.h (struct Lisp_Hash_Table):
10145 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10146 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10147 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10148 * alloc.c (allocate_vectorlike):
10149 Check for overflow in vector size calculations.
10150 * ccl.c (ccl_driver):
10151 Check for overflow when converting EMACS_INT to int.
10152 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10153 need to be updated by these changes.
10154 * fns.c (make_hash_table, maybe_resize_hash_table):
10155 Check for integer overflow with large hash tables.
10156 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10157 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10158 (SXHASH_REDUCE): New macro.
10159 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10160 Use it instead of discarding useful hash info with large hash values.
10161 (sxhash_float): New function.
10162 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10163 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10164 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10165 Rewrite to use FIXNUM_BITS, as this simplifies things.
10166 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10167 Adjust signatures to match updated version of code.
10168 (consing_since_gc): Now EMACS_INT, since a single hash table can
10169 use more than INT_MAX bytes.
10171 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10173 Make it possible to build with GCC-4.6+ -O2 -flto.
10175 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10177 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10179 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10180 Call minibuffer-inactive-mode.
10182 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10184 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10185 Update dependencies.
10187 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10189 * data.c (init_data): Remove code for UTS, this system is not
10192 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10194 Don't force ./temacs to start in terminal mode.
10196 * frame.c (make_initial_frame): Initialize faces in all cases, not
10197 only when CANNOT_DUMP is defined.
10198 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10200 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10202 * dispnew.c (add_window_display_history): Use const for the string
10203 pointer. Remove declaration, not needed.
10205 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10207 Use 'inline', not 'INLINE'.
10208 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10209 * alloc.c, fontset.c (INLINE): Remove.
10210 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10211 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10212 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10213 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10214 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10216 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10218 Make it possible to run ./temacs.
10220 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10221 syms_of_callproc does the same thing. Remove test for
10222 "initialized", do it in the caller.
10223 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10225 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10227 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10228 (read_minibuf): Use get_minibuffer.
10229 (syms_of_minibuf): Use DEFSYM.
10230 (Qmetadata): New var.
10231 * data.c (Qbuffer): Don't make it static.
10232 (syms_of_data): Use DEFSYM.
10234 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10236 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10237 (CCL_CODE_MIN): New macro.
10239 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10241 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10243 * eval.c (Qdebug): Now static.
10244 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10245 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10246 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10248 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10250 * image.c: Various fixes to ImageMagick code comments.
10251 (Fimagemagick_types): Doc fix.
10253 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10255 Minor fixes prompted by GCC 4.6.0 warnings.
10257 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10259 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10260 (x_clipboard_manager_save_all): Move extern decl to ...
10261 * xterm.h: ... here, so that it can be checked for consistency.
10263 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10265 * xselect.c (x_clipboard_manager_save_frame)
10266 (x_clipboard_manager_save_all): New functions.
10267 (Fx_clipboard_manager_save): Lisp function deleted.
10269 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10270 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10272 * xterm.h: Update prototype.
10274 2011-05-28 William Xu <william.xwl@gmail.com>
10276 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10277 exiting (Bug#8239).
10279 2011-05-28 Jim Meyering <meyering@redhat.com>
10281 Avoid a sign-extension bug in crypto_hash_function.
10282 * fns.c (to_uchar): Define.
10283 (crypto_hash_function): Use it to convert some newly-signed
10284 variables to unsigned, to avoid sign-extension bugs. For example,
10285 without this change, (md5 "truc") would evaluate to
10286 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10287 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10288 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10290 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10292 Integer overflow fixes.
10294 * dbusbind.c: Serial number integer overflow fixes.
10295 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10296 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10297 to hold a serial number that is too large for a fixnum.
10298 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10299 Check for serial numbers out of range. Decode any serial number
10300 that was so large that it became a float. (Bug#8722)
10302 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10303 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10304 Use XFASTINT rather than XUINT when numbers are nonnegative.
10305 (xd_append_arg, Fdbus_method_return_internal):
10306 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10307 arguments, check that Lisp number is nonnegative, rather than
10308 silently wrapping negative numbers around. (Bug#8722)
10309 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10312 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10314 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10316 ccl: Add integer overflow checks.
10317 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10318 (IN_INT_RANGE): New macros.
10319 (ccl_driver): Use them to check for integer overflow when
10320 decoding a CCL program. Many of the new checks are whether XINT (x)
10321 fits in int; it doesn't always, on 64-bit hosts. The new version
10322 doesn't catch all possible integer overflows, but it's an
10323 improvement. (Bug#8719)
10325 * alloc.c (make_event_array): Use XINT, not XUINT.
10326 There's no need for unsigned here.
10328 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10329 This follows up to the 2011-05-06 change that substituted uintptr_t
10330 for EMACS_INT. This case wasn't caught back then.
10332 Rework Fformat to avoid integer overflow issues.
10333 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10334 now (part of C89). Include <verify.h>.
10335 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10336 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10337 (Fformat): Avoid the prepass trying to compute sizes; it was only
10338 approximate and thus did not catch overflow reliably. Instead, walk
10339 through the format just once, formatting and computing sizes as we go,
10340 checking for integer overflow at every step, and allocating a larger
10341 buffer as needed. Keep track separately whether the format is
10342 multibyte. Keep only the most-recently calculated precision, rather
10343 than them all. Record whether each argument has been converted to
10344 string. Use EMACS_INT, not int, for byte and char and arg counts.
10345 Support field widths and precisions larger than INT_MAX. Avoid
10346 sprintf's undefined behavior with conversion specifications such as %#d
10347 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10348 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10349 formatting out-of-range floating point numbers with int
10350 formats. (Bug#8668)
10352 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10354 * data.c: Avoid integer truncation in expressions involving floats.
10355 * data.c: Include <intprops.h>.
10356 (arith_driver): When there's an integer overflow in an expression
10357 involving floating point, convert the integers to floating point
10358 so that the resulting value does not suffer from catastrophic
10359 integer truncation. For example, on a 64-bit host (* 4
10360 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10361 Do not rely on undefined behavior after integer overflow.
10363 merge count_size_as_multibyte, parse_str_to_multibyte
10364 * character.c, character.h (count_size_as_multibyte):
10365 Rename from parse_str_to_multibyte; all uses changed.
10366 Check for integer overflow.
10367 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10368 since it's now a duplicate of the other. This is more of
10369 a character than a buffer op, so better that it's in character.c.
10370 * fns.c, print.c: Adjust to above changes.
10372 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10374 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10376 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10378 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10379 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10380 (x_clipboard_manager_save): Now static.
10381 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10383 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10384 (crypto_hash_function): Now static.
10385 Fix pointer signedness problems. Avoid unnecessary initializations.
10387 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10389 * termhooks.h (Vselection_alist): Make it terminal-local.
10391 * terminal.c (create_terminal): Initialize it.
10393 * xselect.c: Support for clipboard managers.
10394 (Vselection_alist): Move to termhooks.h as terminal-local var.
10395 (LOCAL_SELECTION): New macro.
10396 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10397 (symbol_to_x_atom): Remove gratuitous arg.
10398 (x_handle_selection_request, lisp_data_to_selection_data)
10399 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10400 (x_own_selection, x_get_local_selection, x_convert_selection):
10401 New arg, specifying work frame. Use terminal-local Vselection_alist.
10402 (some_frame_on_display): Delete unused function.
10403 (Fx_own_selection_internal, Fx_get_selection_internal)
10404 (Fx_disown_selection_internal, Fx_selection_owner_p)
10405 (Fx_selection_exists_p): New optional frame arg.
10406 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10407 (x_handle_selection_clear): Don't treat other terminals with the
10408 same keyboard specially. Use the terminal-local Vselection_alist.
10409 (x_clear_frame_selections): Use Frun_hook_with_args.
10411 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10413 * xterm.h: Add support for those atoms.
10415 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10417 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10418 (converted_selections, conversion_fail_tag): New global variables.
10419 (x_selection_request_lisp_error): Free the above.
10420 (x_get_local_selection): Remove unnecessary code.
10421 (x_reply_selection_request): Args changed; handle arbitrary array
10422 of converted selections stored in converted_selections.
10423 Separate the XChangeProperty and SelectionNotify steps.
10424 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10425 (x_convert_selection): New function.
10426 (x_handle_selection_event): Simplify.
10427 (x_get_foreign_selection): Don't ignore incoming requests while
10428 waiting for an answer; this will fail when we implement
10429 SAVE_TARGETS, and seems unnecessary anyway.
10430 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10431 (Vx_sent_selection_functions): Doc fix.
10433 2011-05-26 Leo Liu <sdl.web@gmail.com>
10435 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10437 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10439 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10441 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10442 for fringe update if it has periodic bitmap.
10443 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10444 and fringe_bitmap_periodic_p.
10446 * fringe.c (get_fringe_bitmap_data): New function.
10447 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10448 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10449 row. Mark glyph row for fringe update if periodicity changed.
10451 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10452 for fringe update unless it has periodic bitmap.
10454 2011-05-25 Kenichi Handa <handa@m17n.org>
10456 * xdisp.c (get_next_display_element): Set correct it->face_id for
10457 a static composition.
10459 2011-05-24 Leo Liu <sdl.web@gmail.com>
10462 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10464 * fns.c (crypto_hash_function, Fsha1): New function.
10465 (Fmd5): Use crypto_hash_function.
10466 (syms_of_fns): Add Ssha1.
10468 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10470 * gnutls.c: Remove unused macros.
10471 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10472 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10473 Remove macros that are defined and never used.
10474 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10476 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10478 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10479 (Fx_get_selection_internal): Minor cleanup.
10480 (Fx_own_selection_internal): Rename arguments for consistency with
10483 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10485 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10487 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10489 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10491 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10493 * dispnew.c (scrolling_window): Don't exclude the case that the
10494 last enabled row in the desired matrix touches the bottom boundary.
10496 2011-05-21 Glenn Morris <rgm@gnu.org>
10498 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10499 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10500 and add some more files.
10502 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10504 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10505 report_file_error introduced by the change from 2011-05-07.
10507 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10509 * systime.h (Time): Define only if emacs is defined.
10510 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10511 where the include path doesn't have X11/X.h by default. See
10512 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10514 2011-05-20 Kenichi Handa <handa@m17n.org>
10516 * composite.c (find_automatic_composition): Fix previous change.
10518 2011-05-20 Glenn Morris <rgm@gnu.org>
10520 * lisp.mk: New file, split from Makefile.in.
10521 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10522 (shortlisp): Remove.
10523 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10525 2011-05-19 Glenn Morris <rgm@gnu.org>
10527 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10528 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10529 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10530 (lisp): Set the order to that of loadup.el.
10531 (shortlisp): Make it a copy of $lisp.
10532 (SOME_MACHINE_LISP): Remove.
10533 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10534 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10536 2011-05-18 Kenichi Handa <handa@m17n.org>
10538 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10539 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10540 (find_automatic_composition): Mostly rewrite for efficiency.
10542 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10544 * makefile.w32-in: Update dependencies.
10546 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10548 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10549 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10551 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10553 Fix some integer overflow issues, such as string length overflow.
10555 * insdel.c (count_size_as_multibyte): Check for string overflow.
10557 * character.c (lisp_string_width): Check for string overflow.
10558 Use EMACS_INT, not int, for string indexes and lengths; in
10559 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10560 the resulting string length overflows an EMACS_INT; instead,
10561 report a string overflow if no precision given. When checking for
10562 precision exhaustion, use a check that cannot possibly have
10563 integer overflow. (Bug#8675)
10564 * character.h (lisp_string_width): Adjust to new signature.
10566 * alloc.c (string_overflow): New function.
10567 (Fmake_string): Use it. This doesn't change behavior, but saves
10568 a few bytes and will simplify future changes.
10569 * character.c (string_escape_byte8): Likewise.
10570 * lisp.h (string_overflow): New decl.
10572 Fixups, following up to the user-interface timestamp change.
10573 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10574 for UI timestamps, instead of unsigned long.
10575 * msdos.c (mouse_get_pos): Likewise.
10576 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10577 * w32gui.h (Time): Define by including "systime.h" rather than by
10578 declaring it ourselves. (Bug#8664)
10580 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10581 * image.c (clear_image_cache): Likewise.
10583 * term.c (term_mouse_position): Don't assume time_t wraparound.
10585 Be more systematic about user-interface timestamps.
10586 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10587 and sometimes 'EMACS_UINT', to represent these timestamps.
10588 This change causes it to use 'Time' uniformly, as that's what X uses.
10589 This makes the code easier to follow, and makes it easier to catch
10590 integer overflow bugs such as Bug#8664.
10591 * frame.c (Fmouse_position, Fmouse_pixel_position):
10592 Use Time, not unsigned long, for user-interface timestamps.
10593 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10594 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10595 * keyboard.h (last_event_timestamp): Likewise.
10596 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10597 * menu.h (xmenu_show): Likewise.
10598 * term.c (term_mouse_position): Likewise.
10599 * termhooks.h (struct input_event.timestamp): Likewise.
10600 (struct terminal.mouse_position_hook): Likewise.
10601 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10602 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10603 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10604 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10605 what it was before.
10606 * menu.h, termhooks.h: Include "systime.h", for Time.
10608 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10609 Don't assume that the difference between two unsigned long values
10610 can fit into an integer. At this point, we know button_down_time
10611 <= event->timestamp, so the difference must be nonnegative, so
10612 there's no need to cast the result if double-click-time is
10613 nonnegative, as it should be; check that it's nonnegative, just in
10614 case. This bug is triggered when events are more than 2**31 ms
10615 apart (about 25 days). (Bug#8664)
10617 * xselect.c (last_event_timestamp): Remove duplicate decl.
10618 (x_own_selection): Remove needless cast to unsigned long.
10620 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10621 that always fit in int. Use a sentinel instead of a counter, to
10622 avoid a temp and to allay GCC's concerns about possible int overflow.
10623 * frame.h (struct frame): Use int for menu_bar_items_used
10624 instead of EMACS_INT, since it always fits in int.
10626 * menu.c (grow_menu_items): Check for int overflow.
10628 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10630 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10631 Before, the code was not consistent. These values cannot exceed
10632 2**31 - 1 so there's no need to make them unsigned.
10633 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10634 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10635 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10637 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10639 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10640 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10641 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10642 presumably because the widths might not match.
10644 * window.c (size_window): Avoid needless test at loop start.
10646 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10648 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10650 2011-05-12 Drew Adams <drew.adams@oracle.com>
10652 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10654 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10656 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10657 `width' to `bar_area_x' and `bar_area_width', respectively.
10658 (x_scroll_run): Take account of fringe background extension.
10660 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10661 Rename local vars `left' and `width' to `bar_area_x' and
10662 `bar_area_width', respectively.
10663 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10664 background extension.
10666 2011-05-10 Jim Meyering <meyering@redhat.com>
10668 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10670 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10672 * image.c (Finit_image_library): Return t for built-in image types,
10673 like pbm and xbm. (Bug#8640)
10675 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10677 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10679 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10681 * w32console.c (Fset_screen_color): Doc fix.
10682 (Fget_screen_color): New function.
10683 (syms_of_ntterm): Defsubr it.
10685 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10686 unlink the temporary file if Fcall_process didn't create it in the
10688 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10689 child process will be redirected to a file specified with `:file'.
10690 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10691 cue to call_process_cleanup not to close that handle.
10693 2011-05-07 Ben Key <bkey76@gmail.com>
10695 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10696 one of two shell specific rules, either bootstrap-temacs-CMD or
10697 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10698 to the previous implementation of the bootstrap-temacs rule.
10699 The bootstrap-temacs-CMD rule is similar to the previous
10700 implementation of the bootstrap-temacs rule except that it
10701 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10704 These changes, along with some changes to nt/configure.bat,
10705 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10706 earlier fix to add support for --cflags and --ldflags options
10707 that include quotes so that it works whether make uses cmd or
10710 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10712 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10713 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10715 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10716 a string. Handle both cases.
10717 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10718 (Fdbus_register_method): Use Qinvalid_function.
10720 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10722 * makefile.w32-in: Update dependencies.
10723 (LISP_H): Add inttypes.h and stdin.h.
10724 (PROCESS_H): Add unistd.h.
10726 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10728 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10729 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10731 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10733 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10735 * term.c (vfatal): Remove stray call to va_end.
10736 It's not needed and the C Standard doesn't allow it here anyway.
10738 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10739 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10741 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10744 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10746 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10748 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10750 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10752 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10754 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10755 * charset.c (Fdefine_charset_internal): Don't initialize
10756 charset.code_space[15]. The value was garbage, on hosts with
10757 32-bit int (Bug#8600).
10759 * lread.c (read_integer): Be more consistent with string-to-number.
10760 Use string_to_number to do the actual conversion; this avoids
10761 rounding errors and fixes some other screwups. Without this fix,
10762 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10763 (digit_to_number): Move earlier, for benefit of read_integer.
10764 Return -1 if the digit is out of range for the base, -2 if it is
10765 not a digit in any supported base. (Bug#8602)
10767 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10769 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10770 to match comment at start of function. This also removes a
10771 GCC warning about overflow in a 32+64-bit port.
10773 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10775 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10776 Reported by Stefan Monnier in
10777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10778 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10779 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10781 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10782 (EMACS_UINTPTR): Likewise, with uintptr_t.
10784 * lisp.h: Prefer 64-bit EMACS_INT if available.
10785 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10786 on 32-bit hosts that have 64-bit int, so that they can access
10788 However, temporarily disable this change unless the temporary
10789 symbol WIDE_EMACS_INT is defined.
10791 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10793 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10794 This removes an assumption that EMACS_INT and long are the same
10795 width as pointers. The assumption is true for Emacs porting targets
10796 now, but we want to make other targets possible.
10797 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10798 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10799 In the rest of the code, change types of integers that hold casted
10800 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10801 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10802 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10803 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10804 No need to cast type when ORing.
10805 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10806 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10807 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10808 assume EMACS_INT is the same width as char *.
10809 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10810 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10811 Remove no-longer-needed casts.
10812 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10813 (xg_tool_bar_help_callback, xg_make_tool_item):
10814 Use EMACS_INTPTR to hold an integer
10815 that will be cast to void *; this can avoid a GCC warning
10816 if EMACS_INT is not the same width as void *.
10817 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10818 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10819 (current_message_1, set_message_1):
10820 Use a local to convert to proper width without a cast.
10821 * xmenu.c (dialog_selection_callback): Likewise.
10823 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10824 Also, don't assume VALBITS / RAND_BITS is less than 5,
10825 and don't rely on undefined behavior when shifting a 1 left into
10827 * lisp.h (get_random): Change signature to match.
10829 * lread.c (hash_string): Use size_t, not int, for hash computation.
10830 Normally we prefer signed values; but hashing is special, because
10831 it's better to use unsigned division on hash table sizes so that
10832 the remainder is nonnegative. Also, size_t is the natural width
10833 for hashing into memory. The previous code used 'int', which doesn't
10834 retain enough info to hash well into very large tables.
10835 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10837 * dbusbind.c: Don't possibly lose pointer info when converting.
10838 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10839 Use XPNTR rather than XHASH, so that the high-order bits of
10840 the pointer aren't lost when converting through void *.
10842 * eval.c (Fautoload): Don't double-shift a pointer.
10844 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10846 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10848 * gnutls.c (DEF_GNUTLS_FN):
10849 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10851 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10853 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10856 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10858 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10859 New version that can reserve upto 2GB of heap space.
10861 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10863 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10865 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10867 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10868 `gnutls_certificate_set_x509_key_file'.
10870 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10872 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10873 Update dependencies.
10875 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10877 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10878 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10879 Remove unused parameter `fildes'.
10880 * process.c (read_process_output, send_process): Don't pass it.
10882 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10884 Fix previous change: the library cache is defined in w32.c.
10885 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10886 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10888 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10890 Implement dynamic loading of GnuTLS on Windows.
10892 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10893 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10894 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10897 * gnutls.c (Qgnutls_dll): Define.
10898 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10899 (gnutls_*): Declare function pointers.
10900 (init_gnutls_functions): New function to initialize function pointers.
10901 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10902 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10903 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10904 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10905 (emacs_gnutls_write, emacs_gnutls_read)
10906 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10907 (Fgnutls_available_p): New function.
10908 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10909 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10910 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10912 * image.c: Include w32.h.
10913 (Vimage_type_cache): Delete.
10914 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10915 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10916 (w32_delayed_load): Move to w32.c.
10918 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10920 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10921 (w32_delayed_load): Move from image.c. When loading a library, record
10922 its filename in the :loaded-from property of the library id.
10923 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10924 Initialize and staticpro them.
10925 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10927 * process.c: Include lisp.h before w32.h, not after.
10928 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10929 instead of gnutls_record_check_pending.
10931 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10933 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10935 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10936 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10939 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10941 * xterm.c (x_set_frame_alpha): Do not set property on anything
10942 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10944 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10946 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10948 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10950 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10951 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10952 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10953 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10954 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10955 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10956 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10957 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10958 (Qgnutls_bootprop_callbacks_verify): Make static.
10960 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10962 * callproc.c: Indentation fixup.
10964 * sysdep.c (wait_for_termination_1): Make static.
10965 (wait_for_termination, interruptible_wait_for_termination):
10966 Move after wait_for_termination_1.
10968 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10970 * sysdep.c (interruptible_wait_for_termination): New function
10971 which is like wait_for_termination, but allows keyboard
10974 * callproc.c (Fcall_process): Add (:file "file") as an option for
10976 (Fcall_process_region): Ditto.
10978 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10980 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10981 rather than `XVECTOR (FOO)->size'.
10983 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10984 inttypes.h, as a gnulib replacement is used if it not available in
10987 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10989 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10990 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10991 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10993 * coding.c (coding_alloc_by_realloc): Error out if destination
10994 will grow beyond MOST_POSITIVE_FIXNUM.
10995 (decode_coding_emacs_mule): Abort if there isn't enough place in
10996 charbuf for the composition carryover bytes. Reserve an extra
10997 space for up to 2 characters produced in a loop.
10998 (decode_coding_iso_2022): Abort if there isn't enough place in
10999 charbuf for the composition carryover bytes.
11001 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11003 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11004 aborting when %lld or %lll format is passed.
11005 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11006 %llo or %llx format is passed. (Bug#8545)
11008 * window.c (window_scroll_line_based): Use a marker instead of
11009 simple variables to record original value of point. (Bug#7952)
11011 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11012 produced by %s or %c overflows available buffer space. (Bug#8545)
11014 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11016 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11017 (SIZE_MAX): Move defn after all includes, as they might #define it.
11019 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11021 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11023 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11025 * keyboard.c (Qdelayed_warnings_hook): Define.
11026 (command_loop_1): Run `delayed-warnings-hook'
11027 if Vdelayed_warnings_list is non-nil.
11028 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11029 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11031 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11033 * doprnt.c (doprnt): Don't return value smaller than the buffer
11034 size if the message was truncated. (Bug#8545).
11036 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11038 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11039 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11041 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11043 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11045 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11047 * makefile.w32-in: Update dependencies.
11049 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11051 Improve `doprnt' and its usage. (Bug#8545)
11052 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11053 `format_end'. Remove support for %l as a conversion specifier.
11054 Don't use xrealloc. Improve diagnostics when the %l size modifier
11055 is used. Update the commentary.
11057 * eval.c (verror): Simplify calculation of size_t.
11059 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11062 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11064 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11067 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11069 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11070 This makes this file independent of the recent pseudovector change.
11072 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11074 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11076 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11077 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11078 Remove unused local.
11079 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11081 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11082 GCC 4.6.0 optimizes based on type-based alias analysis.
11083 For example, if b is of type struct buffer * and v of type struct
11084 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11085 != &v->size, and therefore "v->size = 1; b->size = 2; return
11086 v->size;" must therefore return 1. This assumption is incorrect
11087 for Emacs, since it type-puns struct Lisp_Vector * with many other
11088 types. To fix this problem, this patch adds a new type struct
11089 vectorlike_header that documents the constraints on layout of vectors
11090 and pseudovectors, and helps optimizing compilers not get fooled
11091 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11092 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11093 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11095 (XSETPVECTYPE): Rewrite in terms of new macro.
11096 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11097 This is a bit clearer, and further avoids the possibility of
11098 undesirable aliasing.
11099 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11100 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11101 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11102 since Lisp_Subr is a special case (no "next" field).
11103 (ASIZE): Now uses header.size rather than size.
11104 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11105 to avoid the hassle of writing XVECTOR (foo)->header.size.
11106 (struct vectorlike_header): New type.
11107 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11108 object, to help avoid aliasing.
11109 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11110 (SUBRP): Likewise, since Lisp_Subr is a special case.
11111 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11112 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11113 (struct Lisp_Hash_Table): Combine first two members into a single
11114 struct vectorlike_header member. All uses of "size" and "next" members
11115 changed to be "header.size" and "header.next".
11116 * buffer.h (struct buffer): Likewise.
11117 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11118 * frame.h (struct frame): Likewise.
11119 * process.h (struct Lisp_Process): Likewise.
11120 * termhooks.h (struct terminal): Likewise.
11121 * window.c (struct save_window_data, struct saved_window): Likewise.
11122 * window.h (struct window): Likewise.
11123 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11124 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11125 * buffer.c (init_buffer_once): Likewise.
11126 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11128 * process.c (Fformat_network_address): Use local var for size,
11131 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11133 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11134 * data.c (atof): Remove decl; no longer used or needed.
11135 (digit_to_number): Move to lread.c.
11136 (Fstring_to_number): Use new string_to_number function, to be
11137 consistent with how the Lisp reader treats infinities and NaNs.
11138 Do not assume that floating-point numbers represent EMACS_INT
11139 without losing information; this is not true on most 64-bit hosts.
11140 Avoid double-rounding errors, by insisting on integers when
11141 parsing non-base-10 numbers, as the documentation specifies.
11142 * lisp.h (string_to_number): New decl, replacing ...
11143 (isfloat_string): Remove.
11144 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11145 (read1): Do not accept +. and -. as integers; this
11146 appears to have been a coding error. Similarly, do not accept
11147 strings like +-1e0 as floating point numbers. Do not report
11148 overflow for integer overflows unless the base is not 10 which
11149 means we have no simple and reliable way to continue.
11150 Break out the floating-point parsing into a new
11151 function string_to_number, so that Fstring_to_number parses
11152 floating point numbers consistently with the Lisp reader.
11153 (digit_to_number): Move here from data.c. Make it static inline.
11154 (E_CHAR, EXP_INT): Remove, replacing with ...
11155 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11156 (string_to_number): New function, replacing isfloat_string.
11157 This function checks for valid syntax and produces the resulting
11158 Lisp float number too. Rework it so that string-to-number
11159 no longer mishandles examples like "1.0e+". Use strtoumax,
11160 so that overflow for non-base-10 numbers is reported only when
11161 there's no portable and simple way to convert to floating point.
11163 * textprop.c (set_text_properties_1): Rewrite for clarity,
11164 and to avoid GCC warning about integer overflow.
11166 * intervals.h (struct interval): Use EMACS_INT for members
11167 where EMACS_UINT might cause problems. See
11168 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11169 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11170 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11172 (offset_intervals): Tell GCC not to worry about length overflow
11173 when negating a negative length.
11175 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11176 (overrun_check_free): Likewise.
11178 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11179 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11182 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11183 (gnutls_make_error): Rename local to avoid shadowing.
11184 (gnutls_emacs_global_deinit): ifdef out; not used.
11185 (Fgnutls_boot): Use const for pointer to readonly storage.
11186 Comment out unused local. Fix pointer signedness problems.
11188 * lread.c (openp): Don't stuff size_t into an 'int'.
11189 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11190 about possible signed overflow.
11192 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11193 (GDK_KEY_g): Don't define if already defined.
11194 (xg_prepare_tooltip): Avoid pointer signedness problem.
11195 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11197 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11198 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11200 * xfns.c (Fx_window_property): Simplify a bit,
11201 to make a bit faster and to avoid GCC 4.6.0 warning.
11202 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11204 * fns.c (internal_equal): Don't assume size_t fits in int.
11206 * alloc.c (compact_small_strings): Tighten assertion a little.
11208 Replace pEd with more-general pI, and fix some printf arg casts.
11209 * lisp.h (pI): New macro, generalizing old pEd macro to other
11210 conversion specifiers. For example, use "...%"pI"d..." rather
11211 than "...%"pEd"...".
11212 (pEd): Remove. All uses replaced with similar uses of pI.
11213 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11214 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11215 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11216 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11217 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11218 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11219 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11221 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11222 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11223 * print.c (safe_debug_print, print_object): Likewise.
11224 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11226 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11227 avoiding the 0 flag, which is not portable.
11228 * process.c (Fmake_network_process): Use pI to avoid cast.
11229 * region-cache.c (pp_cache): Likewise.
11230 * xdisp.c (decode_mode_spec): Likewise.
11231 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11232 behavior on 64-bit hosts with printf arg.
11233 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11234 (x_stop_queuing_selection_requests): Likewise.
11235 (x_get_window_property): Don't truncate byte count to an 'int'
11238 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11239 here, since it parses constructs like leading '-' and spaces,
11240 which are not wanted; and it overflows with large numbers.
11241 Instead, simply match F[0-9]+, which is what is wanted anyway.
11243 * alloc.c: Remove unportable assumptions about struct layout.
11244 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11245 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11246 (allocate_vectorlike, make_pure_vector): Use the new macros,
11247 plus offsetof, to remove unportable assumptions about struct layout.
11248 These assumptions hold on all porting targets that I know of, but
11249 they are not guaranteed, they're easy to remove, and removing them
11250 makes further changes easier.
11252 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11253 This doesn't fix a bug but makes the code clearer.
11254 (string_overrun_cookie): Now const. Use initializers that
11255 don't formally overflow signed char, to avoid warnings.
11256 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11257 can cause Emacs to crash when string overrun checking is enabled.
11258 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11259 multiple of sizeof (EMACS_INT); it need not be, if
11260 alignof(EMACS_INT) < sizeof (EMACS_INT).
11261 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11263 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11265 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11267 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11269 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11270 supposed to be handshaking. (Bug#8556)
11271 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11273 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11275 * lisp.h (Qdebug): List symbol.
11276 * eval.c (Qdebug): Restore global linkage.
11277 * keyboard.c (debug-on-event): New variable.
11278 (handle_user_signal): Break into debugger when debug-on-event
11279 matches the current signal symbol.
11281 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11283 * alloc.c (check_sblock, check_string_bytes)
11284 (check_string_free_list): Convert to standard C.
11286 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11288 * w32.c (emacs_gnutls_push): Fix typo.
11290 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11292 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11293 "cast to pointer from integer of different size".
11295 Improve doprnt and its use in verror. (Bug#8545)
11296 * doprnt.c (doprnt): Document the set of format control sequences
11297 supported by the function. Use SAFE_ALLOCA instead of always
11300 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11301 is one byte too soon. Don't use xrealloc; instead xfree and
11304 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11306 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11309 * gnutls.c: Renamed global_initialized to
11310 gnutls_global_initialized. Added internals for the
11311 :verify-hostname-error, :verify-error, and :verify-flags
11312 parameters of `gnutls-boot' and documented those parameters in the
11313 docstring. Start callback support.
11314 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11315 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11316 on error. Return error code.
11317 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11318 (emacs_gnutls_read): Likewise.
11319 (Fgnutls_boot): Return handshake error code.
11320 (emacs_gnutls_handle_error): New function.
11321 (wsaerror_to_errno): Likewise.
11323 * w32.h (emacs_gnutls_pull): Add prototype.
11324 (emacs_gnutls_push): Likewise.
11326 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11327 (emacs_gnutls_push): Likewise.
11329 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11331 * process.c (wait_reading_process_output): Check if GnuTLS
11332 buffered some data internally if no FDs are set for TLS
11335 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11336 (LIBS): Link to USER_LIBS.
11337 ($(BLD)/gnutls.$(0)): New target.
11339 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11341 * xdisp.c (handle_single_display_spec): Rename the
11342 display_replaced_before_p argument into display_replaced_p, to
11343 make it consistent with the commentary. Fix typos in the
11346 * textprop.c (syms_of_textprop): Remove dead code.
11347 (copy_text_properties): Delete obsolete commentary about an
11348 interface that was deleted long ago. Fix typos in the description
11351 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11352 to changes in oldXMenu/XMenu.h from 2011-04-16.
11353 <menu_help_message, prev_menu_help_message>: Constify.
11354 (IT_menu_make_room): menu->help_text is now `const char **';
11357 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11358 to changes in oldXMenu/XMenu.h from 2011-04-16.
11359 (struct XMenu): Declare `help_text' `const char **'.
11361 * xfaces.c <Qunspecified>: Make extern again.
11363 * syntax.c: Include sys/types.h before including regex.h, as
11366 * doc.c (get_doc_string): Improve the format passed to `error'.
11368 * doprnt.c (doprnt): Improve commentary.
11370 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11372 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11375 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11376 changes in globals.h immediately force recompilation.
11377 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11378 $(CURDIR)/s/ms-w32.h.
11379 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11381 * character.c (Fchar_direction): Function deleted.
11382 (syms_of_character): Don't defsubr it.
11383 <char-direction-table>: Deleted.
11385 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11387 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11388 * doprnt.c: Include limits.h.
11389 (SIZE_MAX): New macro.
11390 (doprnt): Return a size_t value. 2nd arg is now size_t.
11391 Many local variables are now size_t instead of int or unsigned.
11392 Improve overflow protection. Support `l' modifier for integer
11393 conversions. Support %l conversion. Don't assume an EMACS_INT
11394 argument for integer conversions and for %c.
11396 * lisp.h (doprnt): Restore prototype.
11398 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11399 $(SRC)/character.h.
11401 * Makefile.in (base_obj): Add back doprnt.o.
11403 * deps.mk (doprnt.o): Add back prerequisites.
11404 (callint.o): Depend on character.h.
11406 * eval.c (internal_lisp_condition_case): Include the handler
11407 representation in the error message.
11408 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11409 when breaking from the loop.
11411 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11413 * callint.c (Fcall_interactively): When displaying error message
11414 about invalid control letter, pass the character's codepoint, not
11415 a pointer to its multibyte form. Improve display of the character
11416 in octal and display also its hex code.
11418 * character.c (char_string): Use %x to display the (unsigned)
11419 codepoint of an invalid character, to avoid displaying a bogus
11422 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11423 `error', not SYMBOL_NAME itself.
11425 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11426 character arguments to `error'.
11428 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11429 to `error' in error message about FINAL_CHAR argument. Make sure
11430 FINAL_CHAR is a character, and use %c when it is passed as
11431 argument to `error'.
11433 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11435 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11437 * w32.c: Include <time.h>.
11438 (sys_localtime): New function.
11440 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11442 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11444 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11446 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11448 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11449 zombies (Bug#8467).
11451 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11453 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11454 gl_state.e_property when gl_state.object is Qt.
11456 * insdel.c (make_gap_larger): Remove limitation of buffer size
11459 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11461 * xdisp.c (lookup_glyphless_char_display)
11462 (produce_glyphless_glyph): Handle cons cell entry in
11463 glyphless-char-display.
11464 (Vglyphless_char_display): Document it.
11466 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11467 glyphless-char-display.
11469 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11471 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11473 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11476 definition for no-X builds.
11478 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11480 Static checks with GCC 4.6.0 and non-default toolkits.
11482 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11484 * process.c (keyboard_bit_set): Define only if SIGIO.
11485 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11486 (send_process): Repair possible setjmp clobbering.
11488 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11490 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11492 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11494 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11495 Define only if needed.
11497 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11498 by pacifying GCC about it. Maybe it's time to retire it?
11499 * xfaces.c (USG, __TIMEVAL__): Likewise.
11501 * dispextern.h (struct redisplay_interface): Rename param
11502 to avoid shadowing.
11503 * termhooks.h (struct terminal): Likewise.
11504 * xterm.c (xembed_send_message): Likewise.
11506 * insdel.c (make_gap_smaller): Define only if
11507 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11509 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11512 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11513 so that we aren't warned about unused symbols.
11515 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11517 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11519 * xfns.c (x_real_positions): Mark locals as initialized.
11521 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11523 * xterm.c: Fix problems found by static analysis with other toolkits.
11524 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11525 (x_dispatch_event): Declare static if USE_GTK, and
11526 define if USE_GTK || USE_X_TOOLKIT.
11527 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11528 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11529 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11530 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11532 * xmenu.c (menu_help_callback): Pointer type fixes.
11533 Use const pointers when pointing at readonly data. Avoid pointer
11534 signedness clashes.
11535 (FALSE): Remove unused macro.
11536 (update_frame_menubar): Remove unused decl.
11538 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11540 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11541 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11542 (single_menu_item): Rename local to avoid shadowing.
11544 * keyboard.c (make_lispy_event): Remove unused local var.
11546 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11547 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11549 * bitmaps: Change bitmaps from unsigned char back to the X11
11550 compatible char. Avoid the old compiler warnings about
11551 out-of-range initializers by using, for example, '\xab' rather
11554 * xgselect.c (xgselect_initialize): Check vs interface
11555 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11557 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11559 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11560 to read-only memory.
11562 * fns.c (vector): Remove; this old hack is no longer needed.
11564 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11566 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11568 * xrdb.c (x_load_resources): Omit unused local.
11570 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11571 (x_window): Rename locals to avoid shadowing.
11572 (USG): Use the kludged USG macro, to pacify gcc.
11574 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11575 (x_term_init): Remove local to avoid shadowing.
11577 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11579 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11580 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11582 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11584 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11586 Fix regex.c, syntax.c and friends for buffers > 2GB.
11587 * syntax.h (struct gl_state_s): Declare character position members
11590 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11592 * textprop.c (verify_interval_modification, interval_of):
11593 Declare arguments EMACS_INT.
11595 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11598 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11600 * indent.c (Fvertical_motion): Local variable it_start is now
11603 * regex.c (re_match, re_match_2, re_match_2_internal)
11604 (bcmp_translate, regcomp, regexec, print_double_string)
11605 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11606 (re_compile_pattern, re_exec): Declare arguments and local
11607 variables `size_t' and `ssize_t' and return values `regoff_t', as
11609 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11610 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11611 <compile_stack_type>: `size' and `avail' are now `size_t'.
11613 * regex.h <regoff_t>: Use ssize_t, not int.
11614 (re_search, re_search_2, re_match, re_match_2): Arguments that
11615 specify buffer/string position and length are now ssize_t and
11616 size_t. Return type is regoff_t.
11618 2011-04-16 Ben Key <bkey76@gmail.com>
11620 * nsfont.m: Fixed bugs in ns_get_family and
11621 ns_descriptor_to_entity that were caused by using free to
11622 deallocate memory blocks that were allocated by xmalloc (via
11623 xstrdup). This caused Emacs to crash when compiled with
11624 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11625 --enable-checking=xmallocoverrun). xfree is now used to
11626 deallocate these memory blocks.
11628 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11630 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11632 emacs_write: Accept and return EMACS_INT for sizes.
11633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11635 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11636 Accept and return EMACS_INT.
11637 (emacs_gnutls_write): Return the number of bytes written on
11639 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11640 (emacs_read, emacs_write): Remove check for negative size, as the
11641 Emacs source code has been audited now.
11642 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11643 (emacs_read, emacs_write): Use it.
11644 * process.c (send_process): Adjust to the new signatures of
11645 emacs_write and emacs_gnutls_write. Do not attempt to store
11646 a byte offset into an 'int'; it might overflow.
11647 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11649 * sound.c: Don't assume sizes fit in 'int'.
11650 (struct sound_device.period_size, alsa_period_size):
11651 Return EMACS_INT, not int.
11652 (struct sound_device.write, vox_write, alsa_write):
11653 Accept EMACS_INT, not int.
11654 (wav_play, au_play): Use EMACS_INT to store sizes and to
11655 record read return values.
11657 2011-04-15 Ben Key <bkey76@gmail.com>
11659 * keyboard.c (Qundefined): Don't declare static since it is used
11661 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11662 static since they are used in nsfont.m.
11664 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11666 * process.c (Qprocessp): Don't declare static.
11667 * lisp.h (Qprocessp): Declare again.
11669 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11671 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11673 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11675 Improve C-level modularity by making more things 'static'.
11677 Don't publish debugger-only interfaces to other modules.
11678 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11679 (verify_bytepos, count_markers): Move decls to the only modules
11681 * region-cache.h (pp_cache): Likewise.
11682 * window.h (check_all_windows): Likewise.
11683 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11685 * sysdep.c (croak): Now static, if
11686 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11687 * syssignal.h (croak): Declare only if not static.
11689 * alloc.c (refill_memory_reserve): Now static if
11690 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11691 * lisp.h (refill_memory_reserve): Declare only if not static.
11693 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11694 Define only if USE_LUCID.
11696 * xrdb.c (x_customization_string, x_rm_string): Now static.
11698 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11699 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11701 * xdisp.c (draw_row_with_mouse_face): Now static.
11702 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11704 * window.h (check_all_windows): Mark externally visible.
11706 * window.c (window_deletion_count): Now static.
11708 * undo.c: Make symbols static if they're not exported.
11709 (last_undo_buffer, last_boundary_position, pending_boundary):
11712 * textprop.c (interval_insert_behind_hooks): Now static.
11713 (interval_insert_in_front_hooks): Likewise.
11715 * term.c: Make symbols static if they're not exported.
11716 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11717 (max_frame_lines, tty_set_terminal_modes):
11718 (tty_reset_terminal_modes, tty_turn_off_highlight):
11719 (get_tty_terminal): Now static.
11720 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11721 * termhooks.h (term_mouse_moveto): Do not declare if
11722 HAVE_WINDOW_SYSTEM.
11723 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11724 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11726 * sysdep.c: Make symbols static if they're not exported.
11727 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11729 (sigprocmask_set, full_mask): Remove; unused.
11730 (wait_debugging): Mark as visible.
11731 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11732 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11734 * syntax.c (syntax_temp): Define only if !__GNUC__.
11736 * sound.c (current_sound_device, current_sound): Now static.
11738 * search.c (searchbufs, searchbuf_head): Now static.
11740 * scroll.c (scroll_cost): Remove; unused.
11741 * dispextern.h (scroll_cost): Remove decl.
11743 * region-cache.h (pp_cache): Mark as externally visible.
11745 * process.c: Make symbols static if they're not exported.
11746 (process_tick, update_tick, create_process, chan_process):
11747 (Vprocess_alist, proc_buffered_char, datagram_access):
11748 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11749 (deactivate_process): Mark defn as static, as well as decl.
11750 * lisp.h (create_process): Remove decl.
11751 * process.h (chan_process, Vprocess_alist): Remove decls.
11753 * print.c: Make symbols static if they're not exported.
11754 (print_depth, new_backquote_output, being_printed, print_buffer):
11755 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11756 (print_interval, print_number_index, initial_stderr_stream):
11758 * lisp.h (Fprinc): Remove decl.
11759 (debug_output_compilation_hack): Mark as externally visible.
11761 * sysdep.c (croak): Move decl from here to syssignal.h.
11762 * syssignal.h (croak): Put it here, so the API can be checked when
11763 'croak' is called from dissociate_if_controlling_tty.
11765 * minibuf.c: Make symbols static if they're not exported.
11766 (minibuf_save_list, choose_minibuf_frame): Now static.
11767 * lisp.h (choose_minibuf_frame): Remove decl.
11769 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11771 * lread.c: Make symbols static if they're not exported.
11772 (read_objects, initial_obarray, oblookup_last_bucket_number):
11774 (make_symbol): Remove; unused.
11775 * lisp.h (initial_obarray, make_symbol): Remove decls.
11777 * keyboard.c: Make symbols static if they're not exported.
11778 (single_kboard, recent_keys_index, total_keys, recent_keys):
11779 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11780 (this_single_command_key_start, echoing, last_auto_save):
11781 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11782 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11783 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11784 (Vlispy_mouse_stem, double_click_count):
11786 (force_auto_save_soon): Define only if SIGDANGER.
11787 (ignore_mouse_drag_p): Now static if
11788 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11789 (print_help): Remove; unused.
11790 (stop_character, last_timer_event): Mark as externally visible.
11791 * keyboard.h (ignore_mouse_drag_p): Declare only if
11792 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11793 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11794 * lisp.h (echoing): Remove decl.
11795 (force_auto_save_soon): Declare only if SIGDANGER.
11796 * xdisp.c (redisplay_window): Simplify code, to make it more
11797 obvious that ignore_mouse_drag_p is not accessed if !defined
11798 USE_GTK && !defined HAVE_NS.
11800 * intervals.c: Make symbols static if they're not exported.
11801 (merge_properties_sticky, merge_interval_right, delete_interval):
11803 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11805 * insdel.c: Make symbols static if they're not exported.
11806 However, leave prepare_to_modify_buffer alone. It's never
11807 called from outside this function, but that appears to be a bug.
11808 (combine_after_change_list, combine_after_change_buffer):
11809 (adjust_after_replace, signal_before_change): Now static.
11810 (adjust_after_replace_noundo): Remove; unused.
11811 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11812 (signal_before_change): Remove decls.
11814 * indent.c (val_compute_motion, val_vmotion): Now static.
11816 * image.c: Make symbols static if they're not exported.
11817 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11819 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11820 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11822 * fringe.c (standard_bitmaps): Now static.
11823 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11825 * frame.c: Make symbols static if they're not exported.
11826 (x_report_frame_params, make_terminal_frame): Now static.
11827 (get_frame_param): Now static, unless HAVE_NS.
11828 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11829 (x_get_resource_string): Remove; not used.
11830 * frame.h (make_terminal_frame, x_report_frame_params):
11831 (x_get_resource_string); Remove decls.
11832 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11833 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11835 * font.c, fontset.c: Make symbols static if they're not exported.
11836 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11837 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11838 * font.c (font_close_object): Now static.
11839 * font.h (font_close_object): Remove.
11840 * fontset.c (FONTSET_OBJLIST): Remove.
11841 (free_realized_fontset) #if-0 the body, which does nothing.
11842 (face_suitable_for_char_p): #if-0, as it's never called.
11843 * fontset.h (face_suitable_for_char_p): Remove decl.
11844 * xfaces.c (face_at_string_position):
11845 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11846 since 0 is always ASCII.
11848 * fns.c (weak_hash_tables): Now static.
11850 * fileio.c: Make symbols static if they're not exported.
11851 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11852 (Vwrite_region_annotation_buffers): Now static.
11854 * eval.c: Make symbols static if they're not exported.
11855 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11856 * lisp.h (backtrace_list): Remove decl.
11858 * emacs.c: Make symbols static if they're not exported.
11859 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11860 (fatal_error_code, fatal_error_signal_hook, standard_args):
11862 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11863 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11864 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11865 * lisp.h (fatal_error_signal_hook): Remove decl.
11866 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11868 * editfns.c: Move a (normally-unused) function to its only use.
11869 * editfns.c, lisp.h (get_operating_system_release): Remove.
11870 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11871 worth the hassle of breaking this out.
11873 * xterm.c: Make symbols static if they're not exported.
11874 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11875 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11876 (x_destroy_window, x_delete_display):
11878 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11879 (x_mouse_leave): Remove; unused.
11880 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11881 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11882 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11884 (x_mouse_leave): Declare only if WINDOWSNT.
11885 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11886 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11889 * ftxfont.c: Make symbols static if they're not exported.
11890 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11892 * font.h (ftxfont_driver): Likewise.
11894 * xfns.c: Make symbols static if they're not exported.
11895 (x_last_font_name, x_display_info_for_name):
11896 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11897 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11898 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11899 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11900 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11901 (last_show_tip_args): Now static.
11902 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11903 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11904 (x_screen_planes): Remove; unused.
11905 * dispextern.h (x_screen_planes): Remove decl.
11907 * dispnew.c: Make symbols static if they're not exported.
11908 * dispextern.h (redraw_garbaged_frames, scrolling):
11909 (increment_row_positions): Remove.
11910 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11911 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11913 (redraw_garbaged_frames): Remove; unused.
11915 * xfaces.c: Make symbols static if they're not exported.
11916 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11918 * xterm.h (defined_color): Remove decls.
11919 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11920 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11921 (menu_face_changed_default, defined_color, free_realized_face):
11922 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11923 (ascii_face_of_lisp_face): Remove; unused.
11925 * xdisp.c: Make symbols static if they're not exported.
11926 * dispextern.h (scratch_glyph_row, window_box_edges):
11927 (glyph_to_pixel_coords, set_cursor_from_row):
11928 (get_next_display_element, set_iterator_to_next):
11929 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11930 (show_mouse_face): Remove decls
11931 * frame.h (message_buf_print): Likewise.
11932 * lisp.h (pop_message, set_message, check_point_in_composition):
11934 * xterm.h (set_vertical_scroll_bar): Likewise.
11935 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11936 (message_buf_print, scratch_glyph_row, displayed_buffer):
11937 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11938 (get_next_display_element, show_mouse_face, window_box_edges):
11939 (frame_to_window_pixel_xy, check_point_in_composition):
11940 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11941 (glyph_to_pixel_coords): Remove; unused.
11943 * dired.c (file_name_completion): Now static.
11945 * dbusbind.c (xd_in_read_queued_messages): Now static.
11947 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11948 * data.c (circular_list_error): Remove.
11950 * commands.h (last_point_position, last_point_position_buffer):
11951 (last_point_position_window): Remove decls.
11952 * keyboard.c: Make these variables static.
11954 * coding.h (coding, code_convert_region, encode_coding_gap):
11956 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11957 (iso_code_class, detect_coding, code_convert_region): Now static.
11958 (encode_coding_gap): Remove; unused.
11960 * chartab.c (chartab_chars, chartab_bits): Now static.
11962 * charset.h (charset_iso_8859_1): Remove decl.
11963 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11966 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11967 * ccl.c (Vccl_program_table): Now static.
11968 (check_ccl_update): Remove; unused.
11970 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11971 * category.h: ... from here.
11972 * category.c (check_category_table, set_category_set): Now static.
11974 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11975 * lisp.h: Remove these decls.
11977 * buffer.c (buffer_count): Remove unused var.
11979 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11980 so that it's not optimized away.
11981 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11982 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11983 exported only to the debugger.
11985 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11986 * atimer.h (run_all_atimers): Remove; not exported.
11988 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11989 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11990 was inaccessible from Lisp.
11991 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11992 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11994 alloc.c: Import and export fewer symbols, and remove unused items.
11995 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11997 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11998 it's not optimized away by whole-program optimization.
11999 (message_enable_multibyte, free_misc): Remove.
12000 (catchlist, handlerlist, mark_backtrace):
12001 Declare only if BYTE_MARK_STACK.
12002 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12003 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12004 (message_enable_multibyte): Remove decl.
12005 (free_misc, interval_free_list, float_block, float_block_index):
12006 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12007 (cons_free_list, last_marked_index):
12009 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12010 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12011 (mark_backtrace): Define only if BYTE_MARK_STACK.
12012 * xdisp.c (message_enable_multibyte): Now static.
12014 Declare Lisp_Object Q* variables to be 'static' if not exported.
12015 This makes it easier for human readers (and static analyzers)
12016 to see whether these variables are used from other modules.
12017 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12018 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12019 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12020 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12021 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12022 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12023 * xmenu.c, xselect.c:
12024 Declare Q* vars static if they are not used in other modules.
12025 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12026 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12027 Remove decls of unexported vars.
12028 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12030 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12032 Make Emacs functions such as Fatom 'static' by default.
12033 This makes it easier for human readers (and static analyzers)
12034 to see whether these functions can be called from other modules.
12035 DEFUN now defines a static function. To make the function external
12036 so that it can be used in other C modules, use the new macro DEFUE.
12037 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12038 (Finit_image_library):
12039 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12040 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12041 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12042 Remove decls, since these functions are now static.
12043 (Funintern, Fget_internal_run_time): New decls, since these functions
12044 were already external.
12046 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12047 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12048 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12049 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12050 * keyboard.c, keymap.c, lread.c:
12051 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12052 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12053 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12054 Mark functions with DEFUE instead of DEFUN,
12055 if they are used in other modules.
12056 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12057 decls for now-static functions.
12058 * buffer.h (Fdelete_overlay): Remove decl.
12059 * callproc.c (Fgetenv_internal): Mark as internal.
12060 * composite.c (Fremove_list_of_text_properties): Remove decl.
12061 (Fcomposition_get_gstring): New forward static decl.
12062 * composite.h (Fcomposite_get_gstring): Remove decl.
12063 * dired.c (Ffile_attributes): New forward static decl.
12064 * doc.c (Fdocumntation_property): New forward static decl.
12065 * eval.c (Ffetch_bytecode): New forward static decl.
12066 (Funintern): Remove extern decl; now in .h file where it belongs.
12067 * fileio.c (Fmake_symbolic_link): New forward static decl.
12068 * image.c (Finit_image_library): New forward static decl.
12069 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12070 * intervals.h (Fprevious_property_change):
12071 (Fremove_list_of_text_properties): Remove decls.
12072 * keyboard.c (Fthis_command_keys): Remove decl.
12073 (Fcommand_execute): New forward static decl.
12074 * keymap.c (Flookup_key): New forward static decl.
12075 (Fcopy_keymap): Now static.
12076 * keymap.h (Flookup_key): Remove decl.
12077 * process.c (Fget_process): New forward static decl.
12078 (Fprocess_datagram_address): Mark as internal.
12079 * syntax.c (Fsyntax_table_p): New forward static decl.
12080 (skip_chars): Remove duplicate decl.
12081 * textprop.c (Fprevious_property_change): New forward static decl.
12082 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12084 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12085 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12087 * editfns.c (Fformat): Remove unreachable code.
12089 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12091 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12094 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12096 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12097 when at ZV. (Bug#8487)
12099 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12101 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12103 * keyboard.c (parse_tool_bar_item): Likewise.
12104 * sound.c (sound_cleanup, alsa_close): Likewise.
12105 * termcap.c (tgetent): Likewise.
12106 * xfns.c (x_default_font_parameter): Likewise.
12107 * xsettings.c (read_and_apply_settings): Likewise.
12109 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12110 (overrun_check_free): Protoize.
12112 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12114 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12115 since callers should never pass a negative size.
12116 Change the signature to match that of plain 'read' and 'write'; see
12117 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12118 * lisp.h: Update prototypes of emacs_write and emacs_read.
12120 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12122 * xdisp.c (redisplay_window): Don't try to determine the character
12123 position of the scroll margin if the window start point w->startp
12124 is outside the buffer's accessible region. (Bug#8468)
12126 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12128 Fix write-region and its subroutines for buffers > 2GB.
12129 * fileio.c (a_write, e_write): Modify declaration of arguments and
12130 local variables to support buffers larger than 2GB.
12131 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12133 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12134 argument, local variables, and return value.
12136 * lisp.h: Update prototypes of emacs_write and emacs_read.
12138 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12140 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12142 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12144 Fix more problems found by GCC 4.6.0's static checks.
12146 * xdisp.c (vmessage): Use a better test for character truncation.
12148 * charset.c (load_charset_map): <, not <=, for optimization,
12149 and to avoid potential problems with integer overflow.
12150 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12151 * casetab.c (set_identity, shuffle): Likewise.
12152 * editfns.c (Fformat): Likewise.
12153 * syntax.c (skip_chars): Likewise.
12155 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12156 This also lets GCC 4.6.0 generate slightly better loop code.
12158 * callint.c (Fcall_interactively): <, not <=, for optimization.
12159 (Fcall_interactively): Count the number of arguments produced,
12160 not the number of arguments given. This is simpler and lets GCC
12161 4.6.0 generate slightly better code.
12163 * ftfont.c: Distingish more carefully between FcChar8 and char.
12164 The previous code passed unsigned char * to a functions like
12165 strlen and xstrcasecmp that expect char *, which does not
12166 conform to the C standard.
12167 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12168 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12169 char * when the C standard requires it.
12171 * keyboard.c (read_char): Remove unused var.
12173 * eval.c: Port to Windows vsnprintf (Bug#8435).
12174 Include <limits.h>.
12175 (SIZE_MAX): Define if the headers do not.
12176 (verror): Do not give up if vsnprintf returns a negative count.
12177 Instead, grow the buffer. This ports to Windows vsnprintf, which
12178 does not conform to C99. Problem reported by Eli Zaretskii.
12179 Also, simplify the allocation scheme, by avoiding the need for
12180 calling realloc, and removing the ALLOCATED variable.
12182 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12184 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12185 But keep the doprint source code for now, as we might revamp it
12186 and use it again (Bug#8435).
12187 * lisp.h (doprnt): Remove.
12188 * Makefile.in (base_obj): Remove doprnt.o.
12189 * deps.mk (doprnt.o): Remove.
12191 error: Print 32- and 64-bit integers portably (Bug#8435).
12192 Without this change, on typical 64-bit hosts error ("...%d...", N)
12193 was used to print both 32- and 64-bit integers N, which relied on
12194 undefined behavior.
12195 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12196 * lisp.h (error, verror): Mark as printf-like functions.
12197 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12198 Report overflow in size calculations when allocating printf buffer.
12199 Do not truncate output string at its first null byte.
12200 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12201 Truncate the output at a character boundary, since vsnprintf does not
12203 * charset.c (check_iso_charset_parameter): Convert internal
12204 character to string before calling 'error', since %c now has the
12206 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12207 overflow when computing char to be passed to 'error'. Do not
12208 pass Lisp_Object to 'error'; pass the integer instead.
12209 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12210 formatted with plain %d.
12212 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12214 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12216 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12218 * xterm.c (x_catch_errors): Remove duplicate declaration.
12220 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12222 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12224 2011-04-10 Jim Meyering <meyering@redhat.com>
12226 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12227 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12228 return ssize_t not "int", and use size_t as the buffer length.
12229 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12230 * gnutls.h: Update declarations.
12231 * process.c (read_process_output): Use ssize_t, to match.
12232 (send_process): Likewise.
12234 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12236 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12238 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12240 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12241 Use unsigned char, to match FcChar8 type definition.
12243 * xterm.c (handle_one_xevent):
12244 * xmenu.c (create_and_show_popup_menu):
12245 * xselect.c (x_decline_selection_request)
12246 (x_reply_selection_request): Avoid type-punned deref of X events.
12248 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12250 Fix some uses of `int' instead of EMACS_INT.
12251 * search.c (string_match_1, fast_string_match)
12252 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12253 (scan_buffer, find_next_newline_no_quit)
12254 (find_before_next_newline, search_command, Freplace_match)
12255 (Fmatch_data): Make some `int' variables be EMACS_INT.
12257 * xdisp.c (display_count_lines): 3rd argument and return value now
12258 EMACS_INT. All callers changed.
12259 (pint2hrstr): Last argument is now EMACS_INT.
12261 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12262 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12263 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12264 (decode_coding_utf_16, decode_coding_emacs_mule)
12265 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12266 (decode_coding_ccl, decode_coding_charset)
12267 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12268 (decode_coding_iso_2022, decode_coding_emacs_mule)
12269 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12270 <char_offset, last_offset>: Declare EMACS_INT.
12271 (encode_coding_utf_8, encode_coding_utf_16)
12272 (encode_coding_emacs_mule, encode_invocation_designation)
12273 (encode_designation_at_bol, encode_coding_iso_2022)
12274 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12275 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12277 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12278 (encode_invocation_designation): Last argument P_NCHARS is now
12280 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12281 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12283 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12286 * ccl.c (Fccl_execute_on_string): Declare some variables
12289 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12291 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12293 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12295 * process.c (Fformat_network_address): Doc fix.
12297 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12299 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12301 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12303 * keyboard.c (read_char): Call Lisp function help-form-show,
12304 instead of using internal_with_output_to_temp_buffer.
12305 (Qhelp_form_show): New var.
12306 (syms_of_keyboard): Use DEFSYM macro.
12308 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12310 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12312 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12314 * process.c (Flist_processes): Remove to Lisp.
12315 (list_processes_1): Delete.
12317 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12319 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12321 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12323 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12325 Fix more problems found by GCC 4.6.0's static checks.
12327 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12329 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12331 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12333 * xdisp.c (vmessage): Mark as a printf-like function.
12335 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12337 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12339 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12340 printf-like functions.
12341 (tiff_load): Add casts to remove these marks before passing them
12342 to system-supplied API.
12344 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12346 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12347 This avoids several warnings with gcc -Wstrict-overflow.
12348 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12349 directly, rather than having caller test rule sign. This avoids
12350 some unnecessary tests.
12351 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12352 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12353 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12355 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12356 (xfont_open): Avoid unnecessary tests.
12358 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12360 * composite.h, composite.c (composition_gstring_put_cache):
12361 Use EMACS_INT, not int, for length.
12363 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12364 breaking out part of COMPOSITION_DECODE_RULE.
12365 (COMPOSITION_DECODE_RULE): Use it.
12366 * composite.c (get_composition_id): Remove unused local vars,
12367 by using the new macro.
12369 * textprop.c (set_text_properties_1): Change while to do-while,
12370 since the condition is always true at first.
12372 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12373 (interval_deletion_adjustment): Return unsigned value.
12376 * process.c (list_processes_1, create_pty, read_process_output):
12377 (exec_sentinel): Remove vars that were set but not used.
12378 (create_pty): Remove unnecessary "volatile"s.
12379 (Fnetwork_interface_info): Avoid possibility of int overflow.
12380 (read_process_output): Do adaptive read buffering even if carryover.
12381 (read_process_output): Simplify nbytes computation if buffered.
12383 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12385 * syntax.c (scan_words): Remove var that was set but not used.
12386 (update_syntax_table): Use unsigned instead of int.
12388 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12389 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12390 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12392 * print.c (print_error_message): Avoid int overflow.
12394 * font.c (font_list_entities): Redo for clarity,
12395 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12397 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12398 (font_score): Avoid potential overflow in diff calculation.
12400 * fns.c (substring_both): Remove var that is set but not used.
12401 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12403 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12405 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12406 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12407 can always succeed if overflow has undefined behavior.
12409 * search.c (boyer_moore, wordify): Remove vars set but not used.
12410 (wordify): Omit three unnecessary tests.
12412 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12413 All callers changed. This avoids the need for an unused var.
12415 * casefiddle.c (casify_region): Remove var that is set but not used.
12417 * dired.c (file_name_completion): Remove var that is set but not used.
12419 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12421 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12422 (Finsert_file_contents): Remove unnecessary code checking fd.
12424 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12425 Check for integer overflow on size calculations.
12427 * buffer.c (Fprevious_overlay_change): Remove var that is set
12430 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12431 Remove vars that are set but not used.
12432 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12433 (timer_check_2): Mark vars as initialized.
12435 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12437 * image.c (lookup_image): Remove var that is set but not used.
12438 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12440 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12441 that are set but not used.
12443 * xfns.c (make_invisible_cursor): Don't return garbage
12444 if XCreateBitmapFromData fails (Bug#8410).
12446 * xselect.c (x_get_local_selection, x_handle_property_notify):
12447 Remove vars that are set but not used.
12449 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12450 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12452 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12453 Remove var that is set but not used.
12454 (scroll_bar_windows_size): Now size_t, not int.
12455 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12456 Check for overflow.
12458 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12459 (map_tty_color) [!defined MSDOS]: Likewise.
12461 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12463 * coding.c: Remove vars that are set but not used.
12464 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12465 All callers changed.
12466 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12467 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12468 (decode_coding_charset): Remove vars that are set but not used.
12470 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12471 that is set but not used.
12473 * print.c (print_object): Remove var that is set but not used.
12475 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12476 The gnulib version avoids calling malloc in the usual case,
12477 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12478 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12479 * filelock.c (current_lock_owner): Likewise.
12480 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12481 * sysdep.c: Include allocator.h, careadlinkat.h.
12482 (emacs_no_realloc_allocator): New static constant.
12483 (emacs_readlink): New function.
12484 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12485 ../lib/careadlinkat.h.
12487 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12489 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12490 first non-nil return value).
12492 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12494 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12495 if not defined (Bug#8403).
12497 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12499 * xdisp.c (display_count_lines): Remove parameter `start',
12500 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12501 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12502 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12503 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12504 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12505 and thereabouts. All callers changed.
12506 (get_per_char_metric): Remove parameter `f', unused since
12507 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12509 2011-04-02 Jim Meyering <meyering@redhat.com>
12511 do not dereference NULL upon failed strdup
12512 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12513 (ns_get_family): Likewise.
12515 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12517 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12519 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12521 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12524 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12526 Add lexical binding.
12528 * window.c (Ftemp_output_buffer_show): New fun.
12529 (Fsave_window_excursion):
12530 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12532 * lread.c (lisp_file_lexically_bound_p): New function.
12533 (Fload): Bind Qlexical_binding.
12534 (readevalloop): Remove `evalfun' arg.
12535 Bind Qinternal_interpreter_environment.
12536 (Feval_buffer): Bind Qlexical_binding.
12537 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12539 (syms_of_lread): Declare `lexical-binding'.
12541 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12543 * keyboard.c (eval_dyn): New fun.
12544 (menu_item_eval_property): Use it.
12546 * image.c (parse_image_spec): Use Ffunctionp.
12548 * fns.c (concat, mapcar1): Accept byte-code-functions.
12550 * eval.c (Fsetq): Handle lexical vars.
12551 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12552 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12553 (FletX, Flet): Obey lexical binding.
12554 (Fcommandp): Handle closures.
12555 (Feval): New `lexical' arg.
12556 (eval_sub): New function extracted from Feval. Use it almost
12557 everywhere where Feval was used. Look up vars in lexical env.
12559 (Ffunctionp): Move from subr.el.
12560 (Ffuncall): Handle closures.
12561 (apply_lambda): Remove `eval_flags'.
12562 (funcall_lambda): Handle closures and new byte-code-functions.
12563 (Fspecial_variable_p): New function.
12564 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12565 but without exporting it to Lisp.
12567 * doc.c (Fdocumentation, store_function_docstring):
12568 * data.c (Finteractive_form): Handle closures.
12570 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12573 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12575 (exec_byte_code): New function extracted from Fbyte_code to handle new
12576 calling convention for byte-code-functions. Add new byte-codes.
12578 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12580 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12582 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12584 * xdisp.c (redisplay_internal): Fix prototype.
12586 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12588 * xdisp.c (SCROLL_LIMIT): New macro.
12589 (try_scrolling): Use it when setting scroll_limit.
12590 Limit scrolling to 100 screen lines.
12591 (redisplay_window): Even when falling back on "recentering",
12592 position point in the window according to scroll-conservatively,
12593 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12595 (try_scrolling): When point is above the window, allow searching
12596 as far as scroll_max, or one screenful, to compute vertical
12597 distance from PT to the scroll margin position. This prevents
12598 try_scrolling from unnecessarily failing when
12599 scroll-conservatively is set to a value slightly larger than the
12600 window height. Clean up the case of PT below the margin at bottom
12601 of window: scroll_max can no longer be INT_MAX. When aggressive
12602 scrolling is in use, don't let point enter the opposite scroll
12603 margin as result of the scroll.
12604 (syms_of_xdisp) <scroll-conservatively>: Document the
12605 threshold of 100 lines for never-recentering scrolling.
12607 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12609 * dispextern.h (move_it_by_lines):
12610 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12611 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12612 (message_log_check_duplicate): Remove parameters `prev_bol' and
12613 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12614 (redisplay_internal): Remove parameter `preserve_echo_area',
12615 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12617 * indent.c (Fvertical_motion):
12618 * window.c (window_scroll_pixel_based, Frecenter):
12619 Don't pass `need_y_p' to `move_it_by_lines'.
12621 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12623 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12624 steal a few bits to be more compact.
12625 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12626 Remove unneeded casts.
12628 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12630 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12632 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12633 binding" message (bug#7967).
12635 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12637 Fix more problems found by GCC 4.6.0's static checks.
12639 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12640 Remove unused local var.
12642 * editfns.c (Fmessage_box): Remove unused local var.
12644 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12645 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12646 Omit unused local vars.
12647 * window.c (shrink_windows): Omit unused local var.
12648 * menu.c (digest_single_submenu): Omit unused local var.
12649 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12650 Omit unused local var.
12652 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12653 Don't assume string length fits in int.
12654 (keyremap_step, read_key_sequence): Use size_t for sizes.
12655 (read_key_sequence): Don't check last_real_key_start redundantly.
12657 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12658 instead of alloca (Bug#8344).
12660 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12661 (Fbacktrace_frame): Don't assume nframes fits in int.
12663 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12665 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12668 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12670 * cm.c (calccost): Turn while-do into do-while, for clarity.
12672 * keyboard.c (syms_of_keyboard): Use the same style as later
12673 in this function when indexing through an array. This also
12674 works around GCC bug 48267.
12676 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12678 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12680 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12681 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12683 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12684 This avoids undefined behavior on integer overflow, and is a bit
12685 more convenient anyway since it is compared to a size_t variable.
12687 Variadic C functions now count arguments with size_t, not int.
12688 This avoids an unnecessary limitation on 64-bit machines, which
12689 caused (substring ...) to crash on large vectors (Bug#8344).
12690 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12691 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12692 All variadic functions and their callers changed accordingly.
12693 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12694 * data.c (arith_driver, float_arith_driver): Likewise.
12695 * editfns.c (general_insert_function): Likewise.
12696 * eval.c (struct backtrace.nargs, interactive_p)
12697 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12698 (funcall_lambda, mark_backtrace): Likewise.
12699 * fns.c (concat): Likewise.
12700 * frame.c (x_set_frame_parameters): Likewise.
12701 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12702 0 if not found, not -1. All callers changed.
12704 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12705 (stack_copy_size): Now size_t, not int.
12706 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12708 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12710 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12711 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12712 All callers changed.
12714 * lisp.h (multibyte_char_to_unibyte):
12715 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12716 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12717 * character.h (CHAR_TO_BYTE8):
12718 * cmds.c (internal_self_insert):
12719 * editfns.c (general_insert_function):
12720 * keymap.c (push_key_description):
12721 * search.c (Freplace_match):
12722 * xdisp.c (message_dolog, set_message_1): All callers changed.
12724 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12726 * keyboard.c (safe_run_hook_funcall): New function.
12727 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12728 don't set the hook to nil, but remove the offending function instead.
12729 (Qcommand_hook_internal): Remove, unused.
12730 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12731 Vcommand_hook_internal.
12733 * eval.c (enum run_hooks_condition): Remove.
12734 (funcall_nil, funcall_not): New functions.
12735 (run_hook_with_args): Call each function through a `funcall' argument.
12736 Remove `cond' argument, now redundant.
12737 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12738 (Frun_hook_with_args_until_failure): Adjust accordingly.
12739 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12741 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12743 * dispextern.h (string_buffer_position): Remove declaration.
12745 * print.c (strout): Remove parameter `multibyte', unused since
12746 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12748 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12749 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12750 All callers changed.
12752 * w32.c (_wsa_errlist): Use braces for struct initializers.
12754 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12755 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12756 All callers changed.
12757 (string_buffer_position): Likewise. Also, make static (it's never
12758 used outside xdisp.c).
12759 (cursor_row_p): Remove parameter `w', unused since
12760 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12761 (decode_mode_spec): Remove parameter `precision', introduced during
12762 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12763 All callers changed.
12765 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12767 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12769 2011-03-27 Anders Lindgren <andlind@gmail.com>
12771 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12772 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12773 (ns_update_auto_hide_menu_bar): New functions.
12774 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12775 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12776 ns_constrain_all_frames.
12777 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12778 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12780 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12782 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12784 2011-03-27 Glenn Morris <rgm@gnu.org>
12786 * syssignal.h: Replace RETSIGTYPE with void.
12787 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12788 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12789 Replace SIGTYPE with void everywhere.
12790 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12791 * s/template.h (SIGTYPE): Remove commented out definition.
12793 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12795 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12796 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12798 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12800 * w32.c (read_unc_volume): Use parameter `henum', instead of
12801 global variable `wget_enum_handle'.
12803 * keymap.c (describe_vector): Remove parameters `indices' and
12804 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12805 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12807 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12809 * keyboard.c (timer_check): Remove parameter `do_it_now',
12810 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12811 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12812 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12814 * keyboard.c (read_char):
12815 * w32menu.c (w32_menu_display_help):
12816 * xmenu.c (show_help_event, menu_help_callback):
12817 Adjust calls to `show_help_echo'.
12819 * gtkutil.c (xg_maybe_add_timer):
12820 * keyboard.c (readable_events):
12821 * process.c (wait_reading_process_output):
12822 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12824 * insdel.c (adjust_markers_gap_motion):
12825 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12826 (gap_left, gap_right): Don't call it.
12828 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12830 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12831 incurred during fontification.
12833 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12835 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12836 (DEFVAR_PER_BUFFER): Don't pass it.
12838 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12839 (scrolling_window): Don't pass it.
12841 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12843 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12845 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12847 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12848 of variables specific to SELinux and computation of `encoded_absname'.
12850 * image.c (XPutPixel): Remove unused variable `height'.
12852 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12854 * unexw32.c (get_section_info): Remove unused variable `section'.
12856 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12857 (system_process_attributes): Remove unused variable `sess'.
12858 (sys_read): Remove unused variable `err'.
12860 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12861 (w32_wnd_proc): Remove unused variable `isdead'.
12862 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12863 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12864 (x_create_tip_frame): Remove unused variable `tem'.
12866 * w32inevt.c (w32_console_read_socket):
12867 Remove unused variable `no_events'.
12869 * w32term.c (x_draw_composite_glyph_string_foreground):
12870 Remove unused variable `width'.
12872 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12874 * w32term.c (x_set_glyph_string_clipping):
12875 Don't pass uninitialized region to CombineRgn.
12877 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12879 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12880 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12881 (Fx_close_connection): Remove unused variable `i'.
12883 * w32font.c (w32font_draw): Return number of glyphs.
12884 (w32font_open_internal): Remove unused variable `i'.
12885 (w32font_driver): Add missing initializer.
12887 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12888 (fill_in_menu): Remove unused variable `items_added'.
12890 * w32term.c (last_mouse_press_frame): Remove static global variable.
12891 (w32_clip_to_row): Remove unused variable `f'.
12892 (x_delete_terminal): Remove unused variable `i'.
12894 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12895 (NOTHING): Remove unused static global variable.
12896 (uniscribe_check_otf): Remove unused variable `table'.
12897 (uniscribe_font_driver): Add missing initializers.
12899 2011-03-23 Julien Danjou <julien@danjou.info>
12901 * term.c (Fsuspend_tty, Fresume_tty):
12902 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12903 * window.c (temp_output_buffer_show):
12904 * insdel.c (signal_before_change):
12905 * frame.c (Fhandle_switch_frame):
12906 * fileio.c (Fdo_auto_save):
12907 * emacs.c (Fkill_emacs):
12908 * editfns.c (save_excursion_restore):
12909 * cmds.c (internal_self_insert):
12910 * callint.c (Fcall_interactively):
12911 * buffer.c (Fkill_all_local_variables):
12912 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12914 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12915 unconditionally since it does the check itself.
12917 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12919 Fix more problems found by GCC 4.5.2's static checks.
12921 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12922 the first time through the loop, since we know p0 < p1 then.
12923 This also avoids a gcc -Wstrict-overflow warning.
12925 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12926 leading to a memory leak, possible in functions like
12927 load_charset_map_from_file that can allocate an unbounded number
12928 of objects (Bug#8318).
12930 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12931 that could (at least in theory) be that large.
12933 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12934 This is less likely to overflow, and avoids undefined behavior if
12935 overflow does occur. All callers changed. Use strtoul to scan
12936 for the unsigned long integer.
12937 (pint2hrstr): Simplify and tune code slightly.
12938 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12940 * scroll.c (do_scrolling): Work around GCC bug 48228.
12941 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12943 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12944 This also avoids a warning with gcc -Wstrict-overflow.
12945 (validate_x_resource_name): Simplify count usage.
12946 This also avoids a warning with gcc -Wstrict-overflow.
12948 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12951 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12953 * process.c (Fmake_network_process): Use socklen_t, not int,
12954 where POSIX says socklen_t is required in portable programs.
12955 This fixes a porting bug on hosts like 64-bit HP-UX, where
12956 socklen_t is wider than int (Bug#8277).
12957 (Fmake_network_process, server_accept_connection):
12958 (wait_reading_process_output, read_process_output):
12961 * process.c: Rename or move locals to avoid shadowing.
12962 (list_processes_1, Fmake_network_process):
12963 (read_process_output_error_handler, exec_sentinel_error_handler):
12964 Rename or move locals.
12965 (Fmake_network_process): Define label "retry_connect" only if needed.
12966 (Fnetwork_interface_info): Fix pointer signedness.
12967 (process_send_signal): Add cast to avoid pointer signedness problem.
12968 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12969 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12971 Make tparam.h and terminfo.c consistent.
12972 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12973 Include tparam.h instead, since it declares them.
12974 * cm.h (PC): Remove extern decl; tparam.h now does this.
12975 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12976 * terminfo.c: Include tparam.h, to check interfaces.
12977 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12978 (tparam): Adjust signature to match interface in tparam.h;
12979 this removes some undefined behavior. Check that outstring and len
12980 are zero, which they always are with Emacs.
12981 * tparam.h (PC, BC, UP): New extern decls.
12983 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12984 (xftfont_open): Rename locals to avoid shadowing.
12986 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12987 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12988 (OTF_TAG_SYM): Omit macro if not needed.
12989 (ftfont_list): Remove unused local.
12990 (get_adstyle_property, ftfont_pattern_entity):
12991 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12992 Rename locals to avoid shadowing.
12994 * xfont.c (xfont_list_family): Mark var as initialized.
12996 * xml.c (make_dom): Now static.
12998 * composite.c (composition_compute_stop_pos): Rename local to
13000 (composition_reseat_it): Remove unused locals.
13001 (find_automatic_composition, composition_adjust_point): Likewise.
13002 (composition_update_it): Mark var as initialized.
13003 (find_automatic_composition): Mark vars as initialized,
13004 with a FIXME (Bug#8290).
13006 character.h: Rename locals to avoid shadowing.
13007 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13008 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13009 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13010 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13011 to avoid shadowing.
13013 * textprop.c (property_change_between_p): Remove; unused.
13015 * intervals.c (interval_start_pos): Now static.
13017 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13019 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13020 Rename locals to avoid shadowing.
13022 * sound.c (wav_play, au_play, Fplay_sound_internal):
13023 Fix pointer signedness.
13024 (alsa_choose_format): Remove unused local var.
13025 (wav_play): Initialize a variable to 0, to prevent undefined
13026 behavior (Bug#8278).
13028 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13030 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13032 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13033 clobbering (Bug#8298).
13034 * sysdep.c (sys_subshell): Likewise.
13035 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13037 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13038 This should get cleaned up, so that child_setup has the
13039 same signature on all platforms.
13041 * callproc.c (call_process_cleanup): Now static.
13042 (relocate_fd): Rename locals to avoid shadowing.
13044 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13046 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13047 not to be necessary, and produces flickering.
13049 2011-03-20 Glenn Morris <rgm@gnu.org>
13051 * config.in: Remove file.
13053 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13055 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13056 are now in src/globals.h.
13057 (syms_of_minibuf): Remove spurious & from previous change.
13059 2011-03-20 Leo Liu <sdl.web@gmail.com>
13061 * minibuf.c (completing-read-function): New variable.
13062 (completing-read-default): Rename from completing-read.
13063 (completing-read): Call completing-read-function.
13065 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13067 * xfaces.c (Fx_load_color_file):
13068 Read color file from absolute filename (bug#8250).
13070 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13072 * makefile.w32-in: Update dependencies.
13074 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13076 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13078 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13080 Fix more problems found by GCC 4.5.2's static checks.
13082 * process.c (make_serial_process_unwind, send_process_trap):
13083 (sigchld_handler): Now static.
13085 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13086 That way, the code declares only the vars that it needs.
13087 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13088 * s/cygwin.h (PTY_ITERATION): Likewise.
13089 * s/darwin.h (PTY_ITERATION): Likewise.
13090 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13092 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13093 * process.c (allocate_pty): Don't declare stb unless it's needed.
13095 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13096 (CONSTANTLIM): Remove; unused.
13097 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13098 Define only if needed.
13100 * unexelf.c (unexec): Name an expression,
13101 to avoid gcc -Wbad-function-cast warning.
13102 Use a different way to cause a compilation error if anyone uses
13103 n rather than nn, a way that does not involve shadowing.
13104 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13106 * deps.mk (unexalpha.o): Remove; unused.
13108 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13109 * unexec.h: New file.
13110 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13111 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13112 Depend on unexec.h.
13113 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13114 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13115 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13116 Change as necessary to match prototype in unexec.h.
13118 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13120 (back_comment, skip_chars): Mark vars as initialized.
13122 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13123 Rename locals to avoid shadowing.
13125 * lread.c (read1): Rewrite so as not to use empty "else".
13126 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13128 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13130 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13131 warning when compiling print.c.
13133 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13134 instead of using an uninitialized var.
13135 (font_sort_entities): Mark var as initialized.
13137 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13139 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13140 pointers to constants.
13141 (font_parse_fcname): Remove unused vars.
13142 (font_delete_unmatched): Now static.
13143 (font_get_spec): Remove; unused.
13144 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13145 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13146 Rename or move locals to avoid shadowing.
13148 * fns.c (require_nesting_list, require_unwind): Now static.
13149 (Ffillarray): Rename locals to avoid shadowing.
13151 * floatfns.c (domain_error2): Define only if needed.
13152 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13154 * alloc.c (mark_backtrace): Move decl from here ...
13155 * lisp.h: ... to here, so that it can be checked.
13157 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13158 (Fdefvar): Rewrite so as not to use empty "else".
13159 (lisp_indirect_variable): Name an expression,
13160 to avoid gcc -Wbad-function-cast warning.
13161 (Fdefvar): Rename locals to avoid shadowing.
13163 * callint.c (quotify_arg, quotify_args): Now static.
13164 (Fcall_interactively): Rename locals to avoid shadowing.
13165 Use const pointer when appropriate.
13167 * lisp.h (get_system_name, get_operating_system_release):
13168 Move decls here, to check interfaces.
13169 * process.c (get_operating_system_release): Move decl to lisp.h.
13170 * xrdb.c (get_system_name): Likewise.
13171 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13172 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13173 some of which prompt warnings from gcc -Wbad-function-cast.
13174 (Fformat_time_string, Fencode_time, Finsert_char):
13175 (Ftranslate_region_internal, Fformat):
13176 Rename or remove local vars to avoid shadowing.
13177 (Ftranslate_region_internal): Mark var as initialized.
13179 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13182 * lisp.h (eassert): Check that the argument compiles, even if
13183 ENABLE_CHECKING is not defined.
13185 * data.c (Findirect_variable): Name an expression, to avoid
13186 gcc -Wbad-function-cast warning.
13187 (default_value, arithcompare, arith_driver, arith_error): Now static.
13188 (store_symval_forwarding): Rename local to avoid shadowing.
13189 (Fmake_variable_buffer_local, Fmake_local_variable):
13190 Mark variables as initialized.
13191 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13193 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13194 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13195 Rename locals to avoid shadowing.
13196 (mark_stack): Move local variables into the #ifdef region where
13198 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13199 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13201 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13202 (GC_STRING_CHARS): Remove; not used.
13203 (Fmemory_limit): Cast sbrk's returned value to char *.
13205 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13206 avoids undefined behavior in theory.
13208 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13210 Use functions, not macros, for up- and down-casing (Bug#8254).
13211 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13212 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13213 to use the following functions instead of these macros.
13214 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13215 EMACS_INT, since callers assume the returned value fits in int.
13216 (upcase1): Likewise, for UPCASE_TABLE.
13217 (uppercasep, lowercasep, upcase): New static inline functions.
13218 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13219 the race-condition problem in the old DOWNCASE.
13221 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13222 Rename locals to avoid shadowing.
13223 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13224 (regex_compile, re_search_2, re_match_2_internal):
13225 Remove unused local vars.
13226 (FREE_VAR): Rewrite so as not to use empty "else",
13227 which gcc can warn about.
13228 (regex_compile, re_match_2_internal): Mark locals as initialized.
13229 (RETALLOC_IF): Define only if needed.
13230 (WORDCHAR_P): Likewise. This one is never needed, but is used
13231 only in a comment talking about a compiler bug, so put inside
13232 the #if 0 of that comment.
13233 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13234 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13237 * search.c (boyer_moore): Rename locals to avoid shadowing.
13238 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13239 (PREV_CHAR_BOUNDARY): Likewise.
13241 * search.c (simple_search): Remove unused var.
13243 * dired.c (compile_pattern): Move decl from here ...
13244 * lisp.h: ... to here, so that it can be checked.
13245 (struct re_registers): New forward decl.
13247 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13249 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13251 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13252 Rename locals to avoid shadowing.
13253 (Fvertical_motion): Mark locals as initialized.
13255 * casefiddle.c (casify_object, casify_region): Now static.
13256 (casify_region): Mark local as initialized.
13258 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13260 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13261 New macros, so that the caller can use some names other than
13262 gcpro1, gcpro2, etc.
13263 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13265 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13266 argument, for consistency with GCPRO2_VAR, etc: it is now the
13267 prefix of the variable, not the variable itself. All uses
13269 * dired.c (directory_files_internal, file_name_completion):
13270 Rename locals to avoid shadowing.
13272 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13273 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13274 dired.c's scmp function, had undefined behavior.
13275 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13276 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13277 * buffer.h: ... to here, because these macros use current_buffer,
13278 and the new implementation with inline functions needs to have
13279 current_buffer in scope now, rather than later when the macros
13281 (downcase, upcase1): New static inline functions.
13282 (DOWNCASE, UPCASE1): Reimplement using these functions.
13283 This avoids undefined behavior in expressions like
13284 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13285 from race conditions in accessing the global variables
13286 case_temp1 and case_temp2.
13287 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13288 * lisp.h (case_temp1, case_temp2): Remove their decls.
13289 * character.h (ASCII_CHAR_P): Move from here ...
13290 * lisp.h: ... to here, so that the inline functions mentioned
13291 above can use them.
13293 * dired.c (directory_files_internal_unwind): Now static.
13295 * fileio.c (file_name_as_directory, directory_file_name):
13296 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13298 (file_name_as_directory): Use const pointers when appropriate.
13299 (Fexpand_file_name): Likewise. In particular, newdir might
13300 point at constant storage, so make it a const pointer.
13301 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13302 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13304 (Fset_file_times, Finsert_file_contents, auto_save_error):
13305 Rename locals to avoid shadowing.
13307 * minibuf.c (choose_minibuf_frame_1): Now static.
13308 (Ftry_completion, Fall_completions): Rename or remove locals
13309 to avoid shadowing.
13311 * marker.c (bytepos_to_charpos): Remove; unused.
13313 * lisp.h (verify_bytepos, count_markers): New decls,
13314 so that gcc does not warn that these functions aren't declared.
13316 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13317 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13318 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13319 (copy_text): Remove unused local var.
13321 * filelock.c (within_one_second): Now static.
13322 (lock_file_1): Rename local to avoid shadowing.
13324 * buffer.c (fix_overlays_before): Mark locals as initialized.
13325 (fix_start_end_in_overlays): Likewise. This function should be
13326 simplified by using pointers-to-pointers, but that's a different
13328 (switch_to_buffer_1): Now static.
13329 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13330 (report_overlay_modification): Rename locals to avoid shadowing.
13332 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13333 Fix pointer signedness issue.
13334 (sys_subshell): Mark local as volatile if checking for lint,
13335 to suppress a gcc -Wclobbered warning that does not seem to be right.
13336 (MAXPATHLEN): Define only if needed.
13338 * process.c (serial_open, serial_configure): Move decls from here ...
13339 * systty.h: ... to here, so that they can be checked.
13341 * fns.c (get_random, seed_random): Move extern decls from here ...
13342 * lisp.h: ... to here, so that they can be checked.
13344 * sysdep.c (reset_io): Now static.
13345 (wait_for_termination_signal): Remove; unused.
13347 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13348 (copy_keymap_item, append_key, push_text_char_description):
13350 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13351 (DENSE_TABLE_SIZE): Remove; unused.
13352 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13353 (describe_map_tree):
13354 Rename locals to avoid shadowing.
13356 * keyboard.c: Declare functions static if they are not used elsewhere.
13357 (echo_char, echo_dash, cmd_error, top_level_2):
13358 (poll_for_input, handle_async_input): Now static.
13359 (read_char, kbd_buffer_get_event, make_lispy_position):
13360 (make_lispy_event, make_lispy_movement, apply_modifiers):
13361 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13362 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13363 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13364 (read_key_sequence, read_char): Mark locals as initialized.
13365 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13367 * keyboard.h (make_ctrl_char): New decl.
13368 (mark_kboards): Move decl here ...
13369 * alloc.c (mark_kboards): ... from here.
13371 * lisp.h (force_auto_save_soon): New decl.
13373 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13374 (DEFINE_DUMMY_FUNCTION): New macro.
13375 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13377 (main): Add casts to avoid warnings
13378 if GCC considers string literals to be constants.
13380 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13382 * dbusbind.c: Pointer signedness fixes.
13383 (xd_signature, xd_append_arg, xd_initialize):
13384 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13385 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13386 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13387 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13389 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13390 if GCC considers string literals to be constants.
13391 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13393 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13395 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13396 (print_preprocess, print_object): New macro to fix last change.
13398 * print.c (print_preprocess): Don't forget font objects.
13400 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13402 * emacs.c (USAGE3): Doc fixes.
13404 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13406 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13409 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13411 * lisp.h (VWindow_system, Qfile_name_history):
13412 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13413 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13414 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13416 * w32select.c: Don't #include "keyboard.h".
13417 (run_protected): Add extern declaration for waiting_for_input.
13419 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13420 * w32console.c (detect_input_pending, read_input_pending)
13421 (encode_terminal_code):
13422 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13423 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13424 (w32_system_caret_y, Qfile_name_history):
13425 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13426 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13427 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13428 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13429 * w32proc.c (Qlocal, report_file_error):
13430 * w32term.c (Vwindow_system, updating_frame):
13431 * w32uniscribe.c (initialized, uniscribe_font_driver):
13432 Remove unneeded extern declarations.
13434 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13436 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13438 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13440 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13441 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13442 These macros can no longer be used for assignment.
13444 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13445 Assign struct members directly, instead of using BUF_BEGV etc.
13446 (record_buffer_markers, fetch_buffer_markers): New functions for
13447 recording and fetching special buffer markers.
13448 (set_buffer_internal_1, set_buffer_temp): Use them.
13450 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13452 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13454 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13455 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13457 * xdisp.c (hscroll_window_tree):
13458 (reconsider_clip_changes): Use PT instead of BUF_PT.
13460 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13462 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13463 $(EMACS_ROOT)/lib/intprops.h.
13465 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13467 Fix more problems found by GCC 4.5.2's static checks.
13469 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13470 to unsigned char * to avoid compiler diagnostic.
13471 (xg_free_frame_widgets): Make it clear that a local variable is
13472 needed only if USE_GTK_TOOLTIP.
13473 (gdk_window_get_screen): Make it clear that this macro is needed
13474 only if USE_GTK_TOOLTIP.
13475 (int_gtk_range_get_value): New function, which avoids a diagnostic
13476 from gcc -Wbad-function-cast.
13477 (xg_set_toolkit_scroll_bar_thumb): Use it.
13478 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13479 diagnostic from gcc -Wbad-function-cast.
13480 (get_utf8_string, xg_get_file_with_chooser):
13481 Rename locals to avoid shadowing.
13482 (create_dialog): Move locals to avoid shadowing.
13484 * xgselect.c (xg_select): Remove unused var.
13486 * image.c (four_corners_best): Mark locals as initialized.
13487 (gif_load): Initialize transparent_p to zero (Bug#8238).
13488 Mark another local as initialized.
13489 (my_png_error, my_error_exit): Mark with NO_RETURN.
13491 * image.c (clear_image_cache): Now static.
13492 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13493 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13494 (x_edge_detection): Remove unnecessary cast that
13495 gcc -Wbad-function-cast diagnoses.
13496 (gif_load): Fix pointer signedness.
13497 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13498 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13500 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13502 Improve quality of tests for time stamp overflow.
13503 For example, without this patch (encode-time 0 0 0 1 1
13504 1152921504606846976) returns the obviously-bogus value (-948597
13505 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13506 reports time overflow. See
13507 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13508 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13509 * editfns.c: Include limits.h and intprops.h.
13510 (TIME_T_MIN, TIME_T_MAX): New macros.
13511 (time_overflow): Move earlier, to before first use.
13512 (hi_time, lo_time): New functions, for an accurate test for
13513 out-of-range times.
13514 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13515 (Fget_internal_run_time): Don't assume time_t fits in int.
13516 (make_time): Use list2 instead of Fcons twice.
13517 (Fdecode_time): More accurate test for out-of-range times.
13518 (check_tm_member): New function.
13519 (Fencode_time): Use it, to test for out-of-range times.
13520 (lisp_time_argument): Don't rely on undefined left-shift and
13521 right-shift behavior when checking for time stamp overflow.
13523 * editfns.c (time_overflow): New function, refactoring common code.
13524 (Fformat_time_string, Fdecode_time, Fencode_time):
13525 (Fcurrent_time_string): Use it.
13527 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13528 * dired.c (make_time): Move to ...
13529 * editfns.c (make_time): ... here.
13530 * systime.h: Note the move.
13532 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13534 * fringe.c (update_window_fringes): Remove unused variables.
13536 * unexmacosx.c (copy_data_segment): Also copy __got section.
13539 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13541 * termcap.c [MSDOS]: Include "msdos.h".
13542 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13543 Constify `char *' arguments and their references according to
13544 prototypes in tparam.h.
13546 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13548 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13549 Adapt all references accordingly.
13551 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13553 2011-03-11 Tom Tromey <tromey@redhat.com>
13555 * buffer.c (syms_of_buffer): Remove obsolete comment.
13557 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13559 * termhooks.h (encode_terminal_code): Declare prototype.
13561 * msdos.c (encode_terminal_code): Don't declare prototype.
13563 * term.c (encode_terminal_code): Now external again, used by
13564 w32console.c and msdos.c.
13566 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13567 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13569 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13571 Fix some minor problems found by GCC 4.5.2's static checks.
13573 * fringe.c (update_window_fringes): Mark locals as initialized
13575 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13577 * alloc.c (mark_fringe_data): Move decl from here ...
13578 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13579 to check its interface.
13580 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13582 * fontset.c (free_realized_fontset): Now static.
13583 (Fset_fontset_font): Rename local to avoid shadowing.
13584 (fontset_font): Mark local as initialized.
13585 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13587 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13589 * xselect.c (x_disown_buffer_selections): Remove; not used.
13590 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13591 (x_own_selection, Fx_disown_selection_internal): Rename locals
13592 to avoid shadowing.
13593 (x_handle_dnd_message): Remove local to avoid shadowing.
13595 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13596 so that the caller can use some name other than gcpro1.
13597 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13598 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13599 (Fx_backspace_delete_keys_p):
13600 Use them to avoid shadowing, and rename vars to avoid shadowing.
13601 (x_decode_color, x_set_name, x_window): Now static.
13602 (Fx_create_frame): Add braces to silence GCC warning.
13603 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13604 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13605 Remove unused locals.
13606 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13607 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13608 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13611 * xterm.h (x_mouse_leave): New decl.
13613 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13614 Remove unused functions.
13615 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13616 (x_calc_absolute_position): Now static.
13617 (XTread_socket): Don't define label "out" unless it's used.
13618 Don't declare local "event" unless it's used.
13619 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13620 unless they are used.
13621 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13622 (x_fatal_error_signal): Remove; not used.
13623 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13624 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13625 (x_error_catcher, x_connection_closed, x_error_handler):
13626 (x_error_quitter, xembed_send_message, x_iconify_frame):
13627 (my_log_handler): Rename locals to avoid shadowing.
13628 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13629 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13631 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13632 Rename or move locals to avoid shadowing.
13633 (tty_defined_color, merge_face_heights): Now static.
13634 (free_realized_faces_for_fontset): Remove; not used.
13635 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13636 does not deduce is never used uninitialized.
13637 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13638 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13640 * terminal.c (store_terminal_param): Now static.
13642 * xmenu.c (menu_highlight_callback): Now static.
13643 (set_frame_menubar): Remove unused local.
13644 (xmenu_show): Rename parameter to avoid shadowing.
13645 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13646 since they might point to immutable storage.
13647 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13648 since it's unused otherwise.
13650 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13651 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13652 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13653 avoids a gcc -Wuninitialized diagnostic.
13654 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13655 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13656 does not deduce are never used uninitialized.
13658 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13660 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13661 * window.c (window_loop, size_window):
13662 (run_window_configuration_change_hook, enlarge_window): Likewise.
13664 * window.c (display_buffer): Now static.
13665 (size_window): Mark variables that gcc -Wuninitialized
13666 does not deduce are never used uninitialized.
13667 * window.h (check_all_windows): New decl, to forestall
13668 gcc -Wmissing-prototypes diagnostic.
13669 * dispextern.h (bidi_dump_cached_states): Likewise.
13671 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13673 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13674 Include <limits.h>.
13675 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13676 and to avoid gcc -Wuninitialized warning.
13677 (load_charset_map): Mark variables that gcc -Wuninitialized
13678 does not deduce are never used uninitialized.
13679 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13681 * coding.c (coding_set_source, coding_set_destination):
13682 Use "else { /* comment */ }" rather than "else /* comment */;"
13683 for clarity, and to avoid gcc -Wempty-body warning.
13684 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13685 a block, when the outer 'i' will do.
13686 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13687 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13688 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13689 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13690 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13691 Rename locals to avoid shadowing.
13692 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13693 * coding.c (emacs_mule_char, encode_invocation_designation):
13694 Now static, since they're not used elsewhere.
13695 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13696 (decode_coding_object, encode_coding_object, detect_coding_system):
13697 (decode_coding_emacs_mule): Mark variables that gcc
13698 -Wuninitialized does not deduce are never used uninitialized.
13699 (detect_coding_iso_2022): Initialize a local variable that might
13700 be used uninitialized. Leave a FIXME because it's not clear that
13701 this initialization is needed. (Bug#8211)
13702 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13703 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13704 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13705 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13706 Remove unused macros.
13708 * category.c (hash_get_category_set): Remove unused local var.
13709 (copy_category_table): Now static, since it's not used elsewhere.
13710 * character.c (string_count_byte8): Likewise.
13712 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13713 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13715 * chartab.c (copy_sub_char_table): Now static, since it's not used
13717 (sub_char_table_ref_and_range, char_table_ref_and_range):
13718 Rename locals to avoid shadowing.
13719 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13721 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13722 (BIDI_BOB): Remove unused macro.
13724 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13725 deduce are never used uninitialized.
13726 * term.c (encode_terminal_code): Likewise.
13728 * term.c (encode_terminal_code): Now static. Remove unused local.
13730 * tparam.h: New file.
13731 * term.c, tparam.h: Include it.
13732 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13733 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13734 Move these decls to tparam.h, and make them agree with what
13735 is actually in tparam.c. The previous trick of using incompatible
13736 decls in different modules does not conform to the C standard.
13737 All callers of tparam changed to use tparam's actual API.
13738 * tparam.c (tparam1, tparam, tgoto):
13739 Use const pointers where appropriate.
13741 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13742 * cm.h (struct cm): Likewise.
13743 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13744 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13745 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13746 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13747 (turn_on_face, init_tty): Likewise.
13748 * termchar.h (struct tty_display_info): Likewise.
13750 * term.c (term_mouse_position): Rename local to avoid shadowing.
13752 * alloc.c (mark_ttys): Move decl from here ...
13753 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13755 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13757 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13759 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13761 * search.c (compile_pattern_1): Remove argument regp, unused since
13762 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13763 (compile_pattern): Don't pass it.
13765 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13767 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13768 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13770 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13772 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13774 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13775 gdk_window_get_screen, gdk_window_get_geometry,
13776 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13777 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13778 (xg_get_pixbuf_from_pixmap): New function.
13779 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13780 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13781 Call xg_get_pixbuf_from_pixmap instead of
13782 gdk_pixbuf_get_from_drawable.
13783 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13784 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13785 (xg_check_special_colors): Use GtkStyleContext and its functions
13787 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13788 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13789 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13790 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13791 Call gtk_widget_get_preferred_size.
13792 (xg_frame_resized): gdk_window_get_geometry only takes 5
13794 (xg_win_to_widget, xg_event_is_for_menubar):
13795 Call gdk_x11_window_lookup_for_display.
13796 (xg_set_widget_bg): New function.
13797 (delete_cb): New function.
13798 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13799 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13800 (xg_set_background_color): Call xg_set_widget_bg.
13801 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13802 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13803 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13804 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13806 (update_frame_tool_bar): Call gtk_widget_hide.
13807 (xg_initialize): Use GDK_KEY_g.
13809 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13811 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13813 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13814 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13815 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13817 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13819 * w32xfns.c (select_palette): Check success of RealizePalette against
13820 GDI_ERROR, not zero.
13822 See ChangeLog.11 for earlier changes.
13824 ;; Local Variables:
13828 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13830 This file is part of GNU Emacs.
13832 GNU Emacs is free software: you can redistribute it and/or modify
13833 it under the terms of the GNU General Public License as published by
13834 the Free Software Foundation, either version 3 of the License, or
13835 (at your option) any later version.
13837 GNU Emacs is distributed in the hope that it will be useful,
13838 but WITHOUT ANY WARRANTY; without even the implied warranty of
13839 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13840 GNU General Public License for more details.
13842 You should have received a copy of the GNU General Public License
13843 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.