1 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * process.c (wait_reading_process_output): Fix asynchrounous
4 GnuTLS socket handling on some versions of the GnuTLS library.
5 (wait_reading_process_output): Add comment and URL.
7 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
11 2011-11-21 Chong Yidong <cyd@gnu.org>
13 * window.c (Fnext_window, Fprevious_window): Doc fix.
15 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
17 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
19 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
21 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
23 2011-11-20 Martin Rudalics <rudalics@gmx.at>
25 * window.c (Fset_window_combination_limit): Rename argument
27 (Vwindow_combination_limit): Remove "status" from doc-string.
29 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
31 * m/ibms390.h: Remove.
32 * m/ibms390x.h: Don't include "ibms390.h".
34 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
36 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
37 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
39 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
41 * casetab.c (Fset_case_table):
42 * charset.c (Fcharset_after): Fix typos.
44 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
46 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
47 Otherwise, valgrind does not work on some platforms.
48 Problem reported by Andreas Schwab in
49 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
50 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
51 is set, removing the need for VIRT_ADDRESS_VARIES.
52 (PURE_P): Use a more-efficient implementation that needs just one
53 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
54 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
55 to 4 (xorl, subq, cmpq, setbe).
56 * alloc.c (pure): Always extern now, since that's the
57 VIRT_ADDR_VARIES behavior.
58 (PURE_POINTER_P): Use a single comparison, not two, for
59 consistency with the new puresize.h.
60 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
61 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
62 Remove VIRT_ADDR_VARIES no longer needed.
64 2011-11-19 Eli Zaretskii <eliz@gnu.org>
66 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
67 (erase_phys_cursor, update_window_cursor, show_mouse_face)
68 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
69 behave as if the cursor position were at the window margin.
71 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
72 and the cursor position is out of bounds, behave as if the cursor
73 position were at the window margin. (Bug#10075)
75 2011-11-18 Chong Yidong <cyd@gnu.org>
77 * window.c (Fwindow_combination_limit): Make first argument
78 non-optional, since it is meaningless for live windows like the
81 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
83 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
85 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
87 * intervals.c: Fix grafting over the whole buffer (bug#10071).
88 (graft_intervals_into_buffer): Simplify.
90 2011-11-18 Eli Zaretskii <eliz@gnu.org>
92 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
93 hash values of the two rows.
94 (copy_row_except_pointers): Preserve the used[] arrays and the
95 hash values of the two rows. (Bug#10035)
96 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
98 * xdisp.c (row_hash): New function, body extracted from
100 (compute_line_metrics): Call row_hash, instead of computing the
103 * dispnew.c (verify_row_hash): Call row_hash for computing the
104 hash code of a row, instead of duplicating code from xdisp.c.
106 * dispextern.h (row_hash): Add prototype.
108 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
110 * frame.c (delete_frame): Don't delete the terminal when the last
111 X frame is closed if emacs is built with GTK toolkit.
113 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
115 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
117 2011-11-17 Martin Rudalics <rudalics@gmx.at>
119 * window.c (Vwindow_splits): Rename to
120 Vwindow_combination_resize. Suggested by Juri Linkov.
121 (Fsplit_window_internal): Use Vwindow_combination_resize instead
124 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
126 * nsfns.m (Fns_font_name):
127 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
129 2011-11-16 Martin Rudalics <rudalics@gmx.at>
131 * window.h (window): Rename slot "nest" to "combination_limit".
132 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
133 (Fset_window_nest): Rename to Fset_window_combination_limit.
134 (Vwindow_nest): Rename to Vwindow_combination_limit.
135 (recombine_windows, make_parent_window, make_window)
136 (Fsplit_window_internal, saved_window)
137 (Fset_window_configuration, save_window_save): Rename all
138 occurrences of window_nest to window_combination_limit.
140 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
142 * image.c (imagemagick_load_image): Fix typo.
144 2011-11-14 Eli Zaretskii <eliz@gnu.org>
146 * xdisp.c (display_line): Move the call to
147 highlight_trailing_whitespace before the call to
148 compute_line_metrics, since the latter needs to see the final
149 faces of all the glyphs to compute ROW's hash value. Fixes
150 assertion violations in row_equal_p. (Bug#10035)
152 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
154 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
155 just return (bug#10044).
157 2011-11-12 Eli Zaretskii <eliz@gnu.org>
159 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
160 with user-defined heap size. Bump the default size of the temacs
161 heap to 27MB, to avoid memory warning when running temacs.
162 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
164 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
165 current_matrix and desired_matrix. (Bug#9990)
166 (verify_row_hash) [XASSERTS]: New function.
167 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
168 that the hash value of glyph rows is correct.
170 2011-11-12 Martin Rudalics <rudalics@gmx.at>
172 * window.h (window): Remove splits slot.
173 * window.c (Fwindow_splits, Fset_window_splits): Remove.
174 (Fdelete_other_windows_internal, make_parent_window)
175 (make_window, Fsplit_window_internal, Fdelete_window_internal)
176 (Fset_window_configuration, save_window_save): Don't deal with
177 split status of windows.
178 (saved_window): Remove splits slot.
179 (Vwindow_splits): Rewrite doc-string.
181 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
183 * xfns.c (unwind_create_frame):
184 * nsfns.m (unwind_create_frame):
185 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
186 Vframe_list (Bug#9999).
188 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
190 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
192 2011-11-11 Kenichi Handa <handa@m17n.org>
194 * callproc.c (Fcall_process): Set the member dst_multibyte of
197 2011-11-11 Johan Bockgård <bojohan@gnu.org>
199 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
200 avoid a crash (bug#9496).
202 2011-11-09 Chong Yidong <cyd@gnu.org>
204 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
205 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
207 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
209 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
211 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
213 Avoid some portability problems by eschewing 'extern inline' functions.
214 The trivial performance wins aren't worth the portability hassles; see
215 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
217 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
218 (window_box_width, window_box_left, window_box_left_offset)
219 (window_box_right, window_box_right_offset): Undo previous change,
220 by removing the "extern"s.
221 * intervals.c (adjust_intervals_for_insertion)
222 (adjust_intervals_for_deletion): Undo previous change,
223 making these static again.
224 (offset_intervals, temp_set_point_both, temp_set_point)
225 (copy_intervals_to_string): No longer inline.
226 * xdisp.c (window_text_bottom_y, window_box_width)
227 (window_box_height, window_box_left_offset)
228 (window_box_right_offset, window_box_left, window_box_right)
229 (window_box): No longer inline.
231 2011-11-08 Chong Yidong <cyd@gnu.org>
233 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
234 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
235 an error if not a live window.
236 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
237 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
239 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
241 * lisp.h (syms_of_abbrev): Remove declaration.
242 Reported by CHENG Gao <chenggao@royau.me>.
244 2011-11-07 Eli Zaretskii <eliz@gnu.org>
246 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
247 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
248 of temacs in GUI mode.
250 2011-11-07 Martin Rudalics <rudalics@gmx.at>
252 * window.h: Declare delete_all_child_windows instead of
253 delete_all_subwindows.
254 * window.c (Fwindow_nest, Fset_window_nest)
255 (Fset_window_new_total, Fset_window_new_normal)
256 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
257 (delete_all_subwindows): Rename to delete_all_child_windows.
258 (Fdelete_other_windows_internal, Fset_window_configuration):
259 Call delete_all_child_windows instead of delete_all_subwindows.
260 * frame.c (delete_frame): Call delete_all_child_windows instead
261 of delete_all_subwindows.
263 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
265 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
266 This is also needed for porting to any host where GC_MARK_STACK is
267 not GC_MAKE_GCPROS_NOOPS.
268 (which_symbols): Use it.
270 2011-11-07 Kenichi Handa <handa@m17n.org>
272 * coding.c (coding_set_destination): Check coding->src_pos only
273 when coding->src_object is a buffer (bug#9910).
275 * process.c (send_process): Set the member src_multibyte of coding
276 to 0 (bug#9911) when sending a unibyte text.
278 * callproc.c (Fcall_process): Set the member src_multibyte of
279 process_coding to 0 (bug#9912).
281 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
283 * xmenu.c (cleanup_widget_value_tree): New function.
284 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
285 calling free_menubar_widget_value_tree directly (Bug#9830).
287 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
289 Fix some portability problems with 'inline'.
290 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
291 (window_box_width, window_box_left, window_box_left_offset)
292 (window_box_right, window_box_right_offset): Declare extern.
293 Otherwise, these inline functions do not conform to C99 and
294 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
295 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
296 * intervals.c (adjust_intervals_for_insertion)
297 (adjust_intervals_for_deletion): Now extern, because otherwise the
298 extern inline functions 'offset_intervals' couldn't refer to it.
299 (static_offset_intervals): Remove.
300 (offset_intervals): Rewrite using the old contents of
301 static_offset_intervals. The old version didn't conform to C99
302 because an extern inline function contained a reference to an
303 identifier with static linkage.
305 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
307 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
310 2011-11-06 Eli Zaretskii <eliz@gnu.org>
312 * xdisp.c (init_iterator, reseat_to_string): Don't set the
313 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
314 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
315 return Qleft_to_right.
317 2011-11-06 Chong Yidong <cyd@gnu.org>
319 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
320 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
321 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
322 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
323 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
324 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
325 (Fwindow_vscroll): Doc fix.
326 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
327 argument, since it makes no sense to pass a live window and for
328 consistency with window-child.
330 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
332 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
335 2011-11-05 Jason Rumney <jasonr@gnu.org>
337 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
338 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
340 (add_font_entity_to_list): Fix logic errors in mixed boolean and
341 bitwise arithmetic preventing use of unicode-sip and non-truetype
344 2011-11-05 Eli Zaretskii <eliz@gnu.org>
346 * s/ms-w32.h (fstat, stat, utime): Move redirections to
349 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
350 initialization code to keep similarity to xfns.c after changes
353 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
355 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
356 (unwind_create_frame): New function (Bug#9943).
357 (Fx_create_frame): Restructure code to be more similar to the one in
358 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
359 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
360 Move terminal->reference_count++ just before making the frame official
363 * nsterm.m (x_free_frame_resources): New function.
364 (x_destroy_window): Move code to x_free_frame_resources.
366 * xfns.c (unwind_create_frame): Fix comment.
367 (Fx_create_frame, x_create_tip_frame): Move
368 terminal->reference_count++ just before making the frame
369 official. Move initialization of image_cache_refcount and
370 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
372 2011-11-05 Eli Zaretskii <eliz@gnu.org>
374 Support MSVC build with newer versions of Visual Studio.
375 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
376 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
379 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
380 which are not supported by MSVC.
381 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
382 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
384 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
386 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
388 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
390 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
392 Support MSVC build with newer versions of Visual Studio.
393 * w32.c: Don't include w32api.h for MSVC.
394 (init_environment) [_MSC_VER]: Call sys_access, not _access.
396 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
397 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
398 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
399 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
401 (alloca) [_MSC_VER]: Define to _alloca.
403 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
405 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
407 2011-11-04 Eli Zaretskii <eliz@gnu.org>
409 * xdisp.c (note_mouse_highlight): If either of
410 previous/next-single-property-change returns nil, treat that as
411 the beginning or the end of the buffer. (Bug#9955)
413 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
415 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
416 label is not null (Bug#9951).
417 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
420 2011-11-04 Eli Zaretskii <eliz@gnu.org>
422 * window.c (Fwindow_body_size): Mention in the doc string that the
423 return value is in frame's canonical units. (Bug#9949)
425 2011-11-03 Eli Zaretskii <eliz@gnu.org>
427 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
429 * w32fns.c (unwind_create_frame): If needed, free the glyph
430 matrices of the partially constructed frame. (Bug#9943)
431 * xfns.c (unwind_create_frame): Likewise.
433 2011-11-01 Eli Zaretskii <eliz@gnu.org>
435 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
436 Don't stop backward scan on the continuation glyph, even though
437 its CHARPOS is positive.
438 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
439 cover_string to disp_string.
441 2011-11-01 Martin Rudalics <rudalics@gmx.at>
443 * window.c (temp_output_buffer_show): Don't use
444 Vtemp_buffer_show_specifiers.
445 (Vtemp_buffer_show_specifiers): Remove unused variable.
447 2011-10-30 Eli Zaretskii <eliz@gnu.org>
449 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
450 past the beginning of the current glyph matrix.
452 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
454 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
455 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
456 HAVE_GTK3 (Bug#9869).
458 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
459 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
461 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
463 * xterm.c: Declare x_handle_net_wm_state to return int.
464 (handle_one_xevent): Check if we are iconified but don't have
465 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
466 (get_current_wm_state): Return non-zero if not hidden,
467 check for _NET_WM_STATE_HIDDEN (Bug#9893).
468 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
469 (x_handle_net_wm_state): Return what get_current_wm_state returns.
470 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
472 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
474 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
475 so that this new function doesn't get optimized away by a
476 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
478 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
480 * frame.h (MOUSE_HL_INFO): Remove excess parens.
482 2011-10-29 Eli Zaretskii <eliz@gnu.org>
484 Fix the `xbytecode' command.
485 * .gdbinit (xprintbytestr): New command.
486 (xwhichsymbols): Rename from `which'; all callers changed.
487 (xbytecode): Print the byte-code string as well.
489 2011-10-29 Kim Storm <storm@cua.dk>
491 * alloc.c (which_symbols): New function.
493 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
495 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
498 2011-10-29 Glenn Morris <rgm@gnu.org>
500 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
501 Not clear what it was for, and it causes various bugs. (Bug#9839)
503 2011-10-28 Eli Zaretskii <eliz@gnu.org>
505 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
506 possible random value that matches one of those tested as
507 condition to clear the mouse face.
509 2011-10-28 Chong Yidong <cyd@gnu.org>
511 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
513 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
515 * window.c (make_window): Initialize phys_cursor_on_p.
517 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
519 * lisp.h (struct Lisp_Symbol): Update comments.
521 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
523 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
525 2011-10-28 Eli Zaretskii <eliz@gnu.org>
527 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
528 <oslsachem@gmail.com> for helping to debug this.
530 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
531 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
532 (g_b_init_get_glyph_outline_w): New static variables.
533 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
534 (GetGlyphOutlineW_Proc): New typedefs.
535 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
536 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
538 (w32font_open_internal, compute_metrics):
539 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
540 instead of calling the "wide" APIs directly.
542 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
544 * w32.h (syms_of_w32font): Add prototype.
546 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
548 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
549 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
550 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
551 (Fmove_to_window_line): Doc fix.
553 2011-10-27 Chong Yidong <cyd@gnu.org>
555 * process.c (make_process): Set gnutls_state to NULL.
557 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
558 non-NULL, regardless of GNUTLS_INITSTAGE.
559 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
560 an error. Set process slots as soon as we allocate them.
562 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
564 2011-10-27 Chong Yidong <cyd@gnu.org>
566 * gnutls.c (emacs_gnutls_deinit): New function.
567 Deallocate credentials structures as well as calling gnutls_deinit.
568 (Fgnutls_deinit, Fgnutls_boot): Use it.
570 * process.c (make_process): Initialize GnuTLS credentials to NULL.
571 (deactivate_process): Call emacs_gnutls_deinit.
573 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
575 * image.c (x_create_x_image_and_pixmap):
576 * w32.c (sys_rename, w32_delayed_load):
577 * w32font.c (fill_in_logfont):
578 * w32reg.c (x_get_string_resource): Silence compiler warnings.
580 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
582 * w32fns.c (w32_default_color_map): New function,
583 extracted from Fw32_default_color_map.
584 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
586 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
588 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
590 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
592 * keyboard.c (test_undefined): New function (bug#9751).
593 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
595 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
597 * sysdep.c (init_sys_modes): Fix the check for the controlling
600 2011-10-20 Eli Zaretskii <eliz@gnu.org>
602 * dispextern.h (struct bidi_it): New member next_en_type.
604 * bidi.c (bidi_line_init): Initialize the next_en_type member.
605 (bidi_resolve_explicit_1): When next_en_pos is valid for the
606 current character, check also for next_en_type being WEAK_EN.
607 (bidi_resolve_weak): Don't enter the expensive loop if the current
608 position is before next_en_pos. Record the bidi type of the first
609 non-ET, non-BN character we find, in addition to its position.
610 (bidi_level_of_next_char): Invalidate next_en_type when
611 next_en_pos is over-stepped.
613 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
615 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
616 * editfns.c: Rewrite current-time-zone so that it invokes
617 the equivalent of (format-time-string "%Z") to get the time zone name.
618 This fixes a bug when the time zone name contains characters that
619 need converting from the system time locale to Emacs internal format.
620 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
621 that patch fixed format-time-string to do the conversion, but
622 I forgot to fix current-time-zone.
623 (format_time_string): New function, containing most of
624 what Fformat_time_string used to contain.
625 (Fformat_time_string): Rewrite in terms of format_time_string.
626 This doesn't change this function's behavior.
627 (current-time-zone): Rewrite to use format_time_string.
628 This fixes the bug reported by Michael Schierl in
629 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
630 Jason Rumney's 2007-06-07 change worked around this bug, but
632 * systime.h (tzname, timezone): Remove no-longer-used declarations.
634 2011-10-19 Eli Zaretskii <eliz@gnu.org>
636 * xdisp.c (start_display): If the character at POS is displayed
637 via a display vector, reset IT->current.dpvec_index to zero.
638 (try_window_reusing_current_matrix): If a line ends in a display
639 vector or the next line starts in a display vector, continue
640 redrawing the window even though the character position of
641 start_row was reached.
644 2011-10-18 Chong Yidong <cyd@gnu.org>
646 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
647 with nobreak-char-display too.
649 2011-10-18 Eli Zaretskii <eliz@gnu.org>
651 Fix part 3 of bug#9771.
652 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
653 (bidi_resolve_neutral): Don't enter the expensive loop looking for
654 non-neutral characters if the current character is a paragraph
655 separator (a.k.a. Newline). This avoids running the same
656 expensive loop twice, once when we consume the preceding newline
657 and the other time when the line actually needs to be displayed.
658 Avoid the loop when we see neutrals on the base embedding level
659 following a character whose directionality is the same as the
660 paragraph's. This avoids running the expensive loop when a line
661 ends in a long sequence of neutrals, like control characters.
662 Add assertion against STRONG_AL type. Slightly rearrange code
663 that determines the type of a neutral given the first non-neutral
665 (bidi_level_of_next_char): Set next_en_pos to zero when
666 invalidating its info.
668 2011-10-17 Eli Zaretskii <eliz@gnu.org>
670 * xdisp.c (push_display_prop): Determine whether to record string
671 or buffer position by IT->string, not by IT->method. Allow
672 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
673 (move_it_vertically_backward): Don't look for character position
674 immediately after the newline when in a continuation line.
677 2011-10-15 Martin Rudalics <rudalics@gmx.at>
679 * window.c (coordinates_in_window): Rewrite and delabelize
680 vertical border check. (Bug#5357) (Bug#9618)
682 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
684 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
685 errors in XSetWindowBorder (bug#9310).
687 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
689 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
690 avoid crash when xmalloc overrun checking is enabled.
692 2011-10-13 Eli Zaretskii <eliz@gnu.org>
694 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
695 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
696 cursor motion with <left> and <right> arrow keys.
698 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
699 some callers set that themselves.
701 2011-10-12 Eli Zaretskii <eliz@gnu.org>
703 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
704 display string and the previous row comes from the same string and
705 is empty. (Bug#9739) (Bug#9738)
707 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
709 * doc.c (get_doc_string): Encode file name (bug#9735).
711 2011-10-12 Eli Zaretskii <eliz@gnu.org>
713 * bidi.c (bidi_level_of_next_char):
714 * xdisp.c (get_visually_first_element): Remove old incorrect
715 comments regarding the Unicode Line Separator character.
717 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
719 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
721 * alloc.c (Fgc_status): Do not access beyond zombies array
722 boundary if nzombies > MAX_ZOMBIES.
723 * alloc.c (dump_zombies): Add missing format specifier.
725 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
727 * xdisp.c (set_cursor_from_row): Simplify conditionals,
728 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
730 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
731 Some packages use them to denote characters with modifiers.
733 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
735 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
736 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
737 matching a pp-number. Rename parameter var to var1.
739 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
741 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
743 2011-10-08 Glenn Morris <rgm@gnu.org>
745 * callint.c (Fcall_interactively): Give a more explicit error for the
746 'c' case with a non-character input. (Bug#8479)
748 2011-10-08 Eli Zaretskii <eliz@gnu.org>
750 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
752 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
753 lines that are hscrolled on the left.
755 * dispnew.c (buffer_posn_from_coords): Account for a possible
756 presence of header-line. (Bug#4426)
758 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
760 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
761 Don't advertise functionality which we discourage or doesn't work.
763 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
765 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
766 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
767 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
768 this makes Emacs dump core during garbage collection on rare
769 occasions. sizeof is obviously inferior to offsetof here, so
771 (GC_POINTER_ALIGNMENT): New macro.
772 (mark_memory): Omit 3rd (offset) arg; caller changed.
773 Don't assume EMACS_INT alignment is the same as pointer alignment.
775 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
777 * keyboard.c (read_key_sequence_remapped): New var.
778 (read_key_sequence): Compute remapping in the right buffer.
779 (command_loop_1): Use read_key_sequence's remapping directly.
781 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
783 * dired.c (file_name_completion): Don't expand file name.
784 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
785 before checking file name handler.
787 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
788 they've been requested explicitly (bug#9591).
790 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
792 * keymap.c (Fsingle_key_description): Use make_specified_string
793 instead of build_string to build string from push_key_description.
796 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
798 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
799 This fixes a Y2038 bug on 64-bit hosts.
800 * buffer.c (reset_buffer):
801 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
802 (Fclear_buffer_auto_save_failure):
803 Use 0, not -1, to represent an unset failure time, since time_t
806 Remove dependency on glibc malloc internals.
807 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
808 Move back here from lisp.h, but with their new implementations.
809 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
810 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
811 * charset.c (charset_table_init): New static var.
812 (syms_of_charset): Use it instead of xmalloc. This removes a
813 dependency on glibc malloc internals. See Eli Zaretskii's comment in
814 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
815 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
816 Move back to alloc.c.
817 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
818 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
820 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
822 * nsterm.m (windowDidResize): Call x_set_window_size only when
823 ns_in_resize is true. Otherwise set pixelwidth/height and
824 call change_frame_size (Bug#9628).
826 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
828 Port --enable-checking=all to Fedora 14 x86-64.
829 * charset.c (syms_of_charset): Also account for glibc malloc's
830 internal overhead when calculating the initial malloc maximum.
832 Port --enable-checking=all to Fedora 14 x86.
833 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
835 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
836 (overrun_check_realloc, overrun_check_free):
837 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
838 That way, xmalloc returns a properly-aligned pointer even if
839 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
840 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
841 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
842 into account when calculating the initial malloc maximum.
843 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
844 Move here from alloc.c, so that charset.c can use it too.
845 Properly align; the old code wasn't right for common 32-bit hosts
846 when configured with --enable-checking=all.
847 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
848 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
850 2011-09-29 Eli Zaretskii <eliz@gnu.org>
852 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
855 2011-09-28 Eli Zaretskii <eliz@gnu.org>
857 * xdisp.c (compute_display_string_end): If there's no display
858 string at CHARPOS, return -1.
860 * bidi.c (bidi_fetch_char): When compute_display_string_end
861 returns a negative value, treat the character as a normal
862 character not covered by a display string. (Bug#9624)
864 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
866 * lread.c (Fread_from_string): Fix typo in docstring.
868 2011-09-27 Eli Zaretskii <eliz@gnu.org>
870 * xdisp.c (handle_invisible_prop): If invisible text ends on a
871 newline, reseat the iterator instead of bidi-iterating there one
872 character at a time. (Bug#9610)
873 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
874 TO_CHARPOS if the bidi iterator is at base embedding level.
876 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
878 * lread.c (readevalloop): Use correct code for NBSP.
879 (read1): Likewise. (Bug#9608)
881 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
883 * dbusbind.c (Fdbus_register_signal): When service is not
884 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
886 2011-09-25 Glenn Morris <rgm@gnu.org>
888 * buffer.c (truncate-lines): Doc fix.
890 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
892 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
893 (Fset_window_next_buffers): Doc fix.
895 2011-09-24 Glenn Morris <rgm@gnu.org>
897 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
899 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
901 Fix minor problems found by static checking.
902 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
903 * indent.c (Fvertical_motion): Fix == vs = typo.
905 2011-09-24 Eli Zaretskii <eliz@gnu.org>
907 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
908 Default value is now t. Doc fix.
910 * indent.c (Fvertical_motion): Compute and apply the overshoot
911 logic when moving up, not only when moving down. Fix the
912 confusing name and values of the it_overshoot_expected variable;
913 logic changes accordingly. (Bug#9254) (Bug#9549)
915 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
916 CHARPOS is covered by a display string which includes newlines.
917 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
918 is covered by a display string with embedded newlines.
920 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
922 * dbusbind.c (Fdbus_register_signal): Add match rule to
923 Vdbus_registered_objects_table. (Bug#9581)
924 (Fdbus_register_method, Vdbus_registered_objects_table):
927 2011-09-24 Jim Meyering <meyering@redhat.com>
929 do not ignore write error for any output size
930 The previous change was incomplete.
931 While it makes emacs --batch detect the vast majority of stdout
932 write failures, errors were still ignored whenever the output size is
933 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
934 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
935 && echo FAIL: ignored write error
936 FAIL: ignored write error
937 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
938 && echo FAIL: ignored write error
939 FAIL: ignored write error
940 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
942 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
944 * emacs.c (Fkill_emacs): In noninteractive mode exit
945 non-successfully if a write error occurred on stdout. (Bug#9574)
947 2011-09-21 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
952 * dispextern.h (struct it): Update the comment documenting what
955 2011-09-20 Eli Zaretskii <eliz@gnu.org>
957 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
958 a display string, extend search for cursor position to end of row.
959 (find_row_edges): If the row ends in a newline from a display
960 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
961 Handle the case of a display string with multiple newlines.
962 (Fcurrent_bidi_paragraph_direction): Fix search for previous
963 non-empty line. Fixes confusing cursor motion with arrow keys at
964 the beginning of a line that starts with whitespace.
966 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
968 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
971 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
973 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
976 2011-09-18 Eli Zaretskii <eliz@gnu.org>
978 * xdisp.c (display_line): Record maximum and minimum buffer
979 positions even if no glyphs were produced (e.g., by a zero-width
980 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
981 buffer positions that will be removed from the glyph row because
983 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
984 column is beyond frame width: don't subtract 1 "pixel" when
985 computing width of the stretch.
986 (reseat_at_next_visible_line_start): Undo the change made on
987 2011-09-17 that saved paragraph information and restored it after
988 the call to `reseat'. (Bug#9545)
990 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
992 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
993 and turn window cursor on if cleared (Bug#9415).
995 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
997 * search.c (boyer_moore): Take unibyte characters from pattern
998 literally. (Bug#9458)
1000 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1002 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1004 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1006 Fix minor problem found by static checking.
1007 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1008 initialized, to pacify gcc -Wuninitialized.
1010 * fileio.c: Report proper errno when syscall falls.
1011 (Finsert_file_contents): Save and restore errno,
1012 so that report_file_error outputs the correct diagnostic.
1013 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1015 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1017 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1019 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1021 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1022 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1024 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1026 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1027 about the current paragraph and restore it after the call to reseat.
1029 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1030 (bidi_find_paragraph_start): Search back for paragraph beginning
1031 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1032 (bidi_move_to_visually_next): Only trigger paragraph-related
1033 computations when the last character is a newline or at EOB, not
1034 just any NEUTRAL_B. (Bug#9470)
1036 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1037 truncated lines if point is covered by a display string. (Bug#9524)
1039 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1041 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1042 (cons_to_x_long): New function.
1043 (lisp_data_to_selection_data): Use it. Correct the test for
1044 short-versus-long data; it was negated. Break out of vector
1045 loop, for efficiency, when a long datum is discovered.
1047 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1049 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1051 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1053 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1054 GCC PR/17406) by declaring this function with external scope.
1056 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1058 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1059 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1061 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1063 * editfns.c (Fformat): Correctly handle text properties on "%%".
1065 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1067 * xterm.c (x_draw_composite_glyph_string_foreground):
1068 * w32term.c (x_draw_composite_glyph_string_foreground):
1069 * term.c (encode_terminal_code):
1070 * composite.c (composition_update_it, get_composition_id):
1071 * xdisp.c (get_next_display_element)
1072 (fill_composite_glyph_string): Add comments about special meaning
1073 of TAB characters in a composition.
1075 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1077 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1078 This occurs when processing a multibyte format.
1079 Problem reported by Wolfgang Jenker.
1081 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1083 * xdisp.c (try_cursor_movement): Only check for exact match if
1084 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1086 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1088 Remove unused external symbols.
1089 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1090 * xdisp.c (calc_pixel_width_or_height): Now static.
1091 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1092 * indent.c (check_display_width):
1093 * w32term.c: Fix comment to match code.
1094 * xterm.c, xterm.h (x_catching_errors): Remove.
1096 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1098 * xselect.c: Use signed conversions more consistently (Bug#9498).
1099 (selection_data_to_lisp_data): Assume incoming selection data are
1100 signed integers, not unsigned. This is to be consistent with
1101 outgoing selection data, which was modified to use signed integers
1102 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1103 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1104 expects long, not unsigned long.
1106 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1108 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1109 computation of loop end. Reported by Johan Bockgård
1112 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1114 * frame.c (Fother_visible_frames_p): Function deleted.
1116 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1118 * indent.c (compute_motion): Process display vector front to back
1119 rather than the other way around. (Bug#2496)
1121 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1125 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1127 * minibuf.c (Fread_from_minibuffer): Doc fix.
1129 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1131 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1132 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1134 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1136 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1137 value for non-existent files.
1139 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1141 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1142 set its "size" to -1. This will set the modtime_size field of
1143 the corresponding buffer to -1, which is what
1144 verify-visited-file-modtime expects for files that do not exist.
1147 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1149 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1151 * lisp.h: ... from here. push_key_description is no longer
1152 defined in keyboard.c, so its declaration should not be in
1153 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1154 logically belongs with push_key_description.
1156 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1158 * buffer.h: Include <sys/types.h> instead of <time.h>.
1159 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1160 Problem reported by Herbert J. Skuhra.
1162 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1164 * xml.c (parse_region): Make the parsing work for
1165 non-comment-starting XML files again (bug#9144).
1167 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1169 * image.c (gif_load): Fix calculation of bottom and right corner.
1172 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1175 redisplay in small windows.
1177 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1179 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1181 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1183 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1184 Operate on live windows only.
1186 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1188 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1190 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1192 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1193 only under bidi iteration.
1195 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1197 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1199 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1201 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1202 Without this fix, the command to link temacs failed due to an
1203 undefined symbol __builtin_isnan. This is because
1204 /usr/include/iso/math_c99.h #defines isnan(x) to
1205 __builtin_isnan(x), but the bundled gcc, which identifies itself
1206 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1208 * floatfns.c (isnan): #undef, and then #define to a clone of
1210 (Fisnan): Always define, since it's always available now.
1211 (syms_of_floatfns): Always define isnan at the Lisp level.
1213 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1215 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1217 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1219 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1220 The previous code assumed that file offsets (off_t values) fit in
1221 EMACS_INT variables, which is not true on typical 32-bit hosts.
1222 The code messed up by falsely reporting buffer overflow in cases
1223 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1224 when "big" contains more than 2**29 bytes, even though this
1225 inserts just one byte and does not overflow the buffer.
1226 (Finsert_file_contents): Store file offsets as off_t
1227 values, not as EMACS_INT values. Check for overflow when
1228 converting between EMACS_INT and off_t. When checking for
1229 buffer overflow or for overlap, take the offsets into account.
1230 Don't use EMACS_INT for small values where int suffices.
1231 When checking for overlap, fix a typo: ZV was used where
1232 ZV_BYTE was intended.
1233 (Fwrite_region): Don't assume off_t fits into 'long'.
1234 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1236 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1238 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1240 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1242 sprintf-related integer and memory overflow issues (Bug#9412).
1244 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1245 (esprintf, exprintf, evxprintf): New functions.
1246 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1247 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1248 (modify_event_symbol): Do not assume that the length of
1249 name_alist_or_stem is safe to alloca and fits in int.
1250 (Fexecute_extended_command): Likewise for function name and binding.
1251 (Frecursion_depth): Wrap around reliably on integer overflow.
1252 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1253 since some callers pass EMACS_INT values.
1254 (Fsingle_key_description): Don't crash if symbol name contains more
1255 than MAX_ALLOCA bytes.
1256 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1257 (get_minibuffer): Arg is now EMACS_INT, not int.
1258 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1259 (esprintf, exprintf, evxprintf): New decls.
1260 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1262 * dbusbind.c (signature_cat): New function.
1263 (xd_signature, Fdbus_register_signal):
1264 Do not overrun buffer; instead, report string overflow.
1266 * dispnew.c (add_window_display_history): Don't overrun buffer.
1267 Truncate instead; this is OK since it's just a log.
1269 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1270 even if the time zone offset is outlandishly large.
1271 Don't mishandle offset == INT_MIN.
1273 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1274 when creating daemon; the previous buffer-overflow check was incorrect.
1276 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1277 which has the guts of the old verror function.
1279 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1280 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1282 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1283 (font_unparse_xlfd): Don't blindly alloca long strings.
1284 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1285 fits in int, when using sprintf. Use single snprintf to count
1286 length of string rather than counting it via multiple sprintfs;
1287 that's simpler and more reliable.
1288 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1289 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1290 sprintf, in case result does not fit in int.
1292 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1293 (fontset_from_font): Print it.
1295 * frame.c (tty_frame_count): Now printmax_t, not int.
1296 (make_terminal_frame, set_term_frame_name): Print it.
1297 (x_report_frame_params): In X, window IDs are unsigned long,
1298 not signed long, so print them as unsigned.
1299 (validate_x_resource_name): Check for implausibly long names,
1300 and don't assume name length fits in 'int'.
1301 (x_get_resource_string): Don't blindly alloca invocation name;
1302 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1305 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1306 (xg_check_special_colors, xg_set_geometry):
1307 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1309 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1310 Use esprintf, not sprintf, in case result does not fit in int.
1312 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1313 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1314 it as a large positive number.
1315 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1316 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1318 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1319 in case result does not fit in int.
1321 * print.c (float_to_string): Detect width overflow more reliably.
1322 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1323 buffer overrun. Don't assume list length fits in 'int'. Treat
1324 print length of 0 as 0, not as infinity; to be consistent with other
1325 uses of print length in this function. Don't overflow print length
1326 index. Don't assume hash table size fits in 'long', or that
1327 vectorlike size fits in 'unsigned long'.
1329 * process.c (make_process): Use printmax_t, not int, to format
1330 process-name gensyms.
1332 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1334 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1335 to avoid potential buffer overrun.
1337 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1338 if X resource line is longer than 512 bytes.
1340 * xfns.c (x_window): Make sprintf buffer a bit bigger
1341 to avoid potential buffer overrun.
1343 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1345 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1347 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1349 Integer overflow fixes for scrolling, etc.
1350 Without these, Emacs silently mishandles large integers sometimes.
1351 For example, "C-u 4294967297 M-x recenter" was treated as if
1352 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1354 * xdisp.c (try_window_id): Check Emacs fixnum range before
1355 converting to 'int'.
1357 * window.c (window_scroll_line_based, Frecenter):
1358 Check that an Emacs fixnum is in range before assigning it to 'int'.
1359 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1360 values converted from Emacs fixnums.
1361 (Frecenter): Don't wrap around a line count if it is out of 'int'
1362 range; instead, treat it as an extreme value.
1363 (Fset_window_configuration, compare_window_configurations):
1364 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1366 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1367 that can exceed INT_MAX. Check that EMACS_INT value is in range
1368 before assigning it to the (possibly-narrower) index.
1369 (match_limit): Don't assume that a fixnum can fit in 'int'.
1371 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1374 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1375 (Fvertical_motion): Don't wrap around LINES values that don't fit
1376 in 'int'. Instead, treat them as extreme values. This is good
1377 enough for windows, which can't have more than INT_MAX lines anyway.
1379 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1381 * Require libxml/parser.h to avoid compilation warning.
1383 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1385 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1386 since this reportedly can destroy thread storage.
1388 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1390 * syntax.c (find_defun_start): Update all cache variables if
1391 exiting early (Bug#9401).
1393 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1395 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1397 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1398 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1399 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1401 * term.c (tty_append_glyph): New function.
1402 (produce_stretch_glyph): Static function and its prototype deleted.
1404 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1407 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1409 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1410 when checking :margin (Bug#9390).
1411 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1412 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1413 so that the name doesn't mislead. All uses changed.
1415 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1417 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1420 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1422 * xdisp.c (move_it_to): Don't bail out early when reaching
1423 position beyond to_charpos, if we are scanning backwards.
1424 (move_it_vertically_backward): When DY == 0, make sure we get to
1425 the first character in the line after the newline.
1427 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1429 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1430 (ccl_driver): Do not generate an out-of-range pointer.
1431 (Fccl_execute_on_string): Remove unnecessary check for
1432 integer overflow, noted by Stefan Monnier in
1433 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1434 Remove a FIXME that didn't need fixing.
1435 Simplify the newly-introduced buffer reallocation code.
1437 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1439 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1441 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1443 Integer and memory overflow issues (Bug#9196).
1445 * doc.c (get_doc_string): Rework so that
1446 get_doc_string_buffer_size is the actual buffer size, rather than
1447 being 1 less than the actual buffer size; this makes xpalloc more
1450 * image.c (x_allocate_bitmap_record, cache_image):
1451 * xselect.c (Fx_register_dnd_atom):
1452 Simplify previous changes by using xpalloc.
1454 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1455 since either will do and ptrdiff_t is convenient with xpalloc.
1457 * charset.c (charset_table_size)
1458 (struct charset_sort_data.priority): Now ptrdiff_t.
1459 (charset_compare): Don't overflow if priorities differ greatly.
1460 (Fsort_charsets): Don't assume list length fits in int.
1461 Check for size-calculation overflow when allocating sort data.
1462 (syms_of_charset): Allocate an initial charset table that is
1463 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1465 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1467 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1468 The actual value is always <= INT_MAX, and leaving it unsigned made
1469 overflow checking harder.
1471 * dispextern.h (struct glyph_matrix.rows_allocated)
1472 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1473 with xpalloc. The values are still always <= INT_MAX.
1475 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1477 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1478 (SAFE_NALLOCA): New macro.
1480 * region-cache.c (struct boundary.pos, find_cache_boundary)
1481 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1482 (set_cache_region, invalidate_region_cache)
1483 (revalidate_region_cache, know_region_cache, region_cache_forward)
1484 (region_cache_backward, pp_cache):
1485 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1486 so that ptrdiff_t * can be passed to xpalloc.
1487 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1488 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1489 (pp_cache): Don't assume cache_len fits in int.
1490 * region-cache.h: Adjust extern decls to match.
1492 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1493 EMACS_INT, since either will do, for xpalloc.
1495 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1496 (xnmalloc, xnrealloc, xpalloc): New functions.
1498 * bidi.c (bidi_shelve_header_size): New constant.
1499 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1500 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1502 * bidi.c (bidi_cache_shrink):
1503 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1505 Don't update size of array until after memory allocation succeeds,
1506 because xmalloc/xrealloc may not return.
1507 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1508 now that we have proper integer overflow checking.
1509 (record_overlay_string, overlay_strings): Catch overflows when
1510 calculating size of overlay_str_buf.
1512 * callproc.c (Fcall_process): Check for size overflow when
1513 calculating size of args2.
1514 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1515 Normally we prefer signed values, but sticking with ptrdiff_t would
1516 require adding more-complicated checks.
1518 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1519 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1520 Redo buffer-overflow calculations to avoid integer overflow.
1521 Add a FIXME comment where memory seems to be over-allocated.
1523 * character.c (Fstring): Check for size-calculation overflow.
1525 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1526 unnecessary integer overflow. Check for size overflow.
1527 (encode_coding_object): Don't update size until xmalloc succeeds.
1529 * composite.c (get_composition_id): Check for overflow in glyph
1530 length calculations.
1532 Integer and memory overflow fixes for display code.
1533 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1534 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1535 (scrolling_window): Check for overflow in size calculations.
1536 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1537 Don't assume glyph table len fits in int.
1538 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1539 (row_table_size): Now ptrdiff_t, not int.
1540 (scrolling_window): Avoid overflow in size calculations.
1541 Don't update size until allocation succeeds.
1542 * fns.c (concat): Check for overflow in size calculations.
1543 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1544 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1545 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1547 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1548 (get_doc_string): Check for size calculation overflow.
1549 Don't update size until allocation succeeds.
1550 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1551 EMACS_INT, where ptrdiff_t will do.
1552 (Fsubstitute_command_keys): Check for string overflow.
1554 * editfns.c (set_time_zone_rule): Don't assume environment length
1556 (message_length): Now ptrdiff_t, not int.
1557 (Fmessage_box): Don't update size until allocation succeeds.
1558 Don't assume message length fits in int.
1559 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1561 * emacs.c (main): Do not reallocate argv, since there is a null at
1562 the end that can be overwritten, and this way there's no need to
1563 worry about size-calculation overflow.
1564 (sort_args): Check for size-calculation overflow.
1566 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1568 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1570 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1571 (x_set_scroll_bar_width, x_figure_window_size):
1572 Check for integer overflow.
1573 (x_set_alpha): Do not assume XINT fits in int.
1575 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1576 This is for the members text_lines, text_cols, total_lines, total_cols,
1577 where the system imposes an 'int' limit.
1579 * fringe.c (Fdefine_fringe_bitmap):
1580 Don't update size until alloc works.
1582 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1583 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1585 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1586 Check for size-calculation overflow.
1587 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1588 do, as we prefer signed integers.
1589 (id_to_widget.max_size, id_to_widget.used)
1590 (xg_store_widget_in_map, xg_remove_widget_from_map)
1591 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1592 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1593 Use and return ptrdiff_t, not int.
1594 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1595 * gtkutil.h: Change prototypes to match the above.
1597 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1598 are duplicate now that they've been promoted to lisp.h.
1599 (x_allocate_bitmap_record, x_alloc_image_color)
1600 (make_image_cache, cache_image, xpm_load):
1601 Don't update size until alloc is done.
1602 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1604 Check for size calculation overflow.
1605 (ct_colors_allocated_max): New constant.
1606 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1609 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1610 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1611 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1612 Use ptrdiff_t, not int, to count maps.
1613 (read_char_minibuf_menu_prompt): Check for overflow in size
1614 calculations. Don't update size until allocation succeeds.
1615 Redo calculations to avoid overflow.
1616 * keyboard.h: Change prototypes to match the above.
1618 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1620 (current_minor_maps): Check for size calculation overflow.
1621 * keymap.h: Change prototypes to match the above.
1623 * lread.c (read1, init_obarray): Don't update size until alloc done.
1625 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1626 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1628 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1629 Now ptrdiff_t, not int.
1630 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1631 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1633 * process.c (Fnetwork_interface_list): Check for overflow
1634 in size calculation.
1636 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1638 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1639 overflow. Don't bother calling xmalloc when xrealloc will do.
1641 * search.c (Freplace_match): Check for size calculation overflow.
1642 (Fset_match_data): Don't assume list lengths fit in 'int'.
1644 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1645 for command line length. Do not attempt to address one before the
1646 beginning of an array, as that's not portable.
1648 * term.c (max_frame_lines): Remove; unused.
1649 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1651 (encode_terminal_code, calculate_costs): Check for size
1652 calculation overflow.
1653 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1654 table lengths and related sizes. Don't update size until alloc
1655 done. Redo calculations to avoid overflow.
1656 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1658 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1659 subtracting pointers.
1660 (gobble_line): Check for overflow more carefully. Don't update size
1663 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1664 Don't update size until alloc done.
1665 Redo size calculations to avoid overflow.
1666 Check for size calculation overflow.
1667 (main) [DEBUG]: Fix typo in invoking tparam1.
1669 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1670 Use ptrdiff_t, not int, for sizes.
1671 (store_mode_line_noprop_char): Don't update size until alloc done.
1673 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1674 Use ptrdiff_t, not int, for sizes.
1675 (Finternal_make_lisp_face, cache_face):
1676 Check for size calculation overflow.
1677 (cache_face): Treat size calculation overflows as if they were
1678 memory exhaustion (the usual treatment), rather than aborting.
1680 * xfns.c (x_encode_text, x_set_name_internal)
1681 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1682 sizes, since they can exceed INT_MAX in size. Check for size
1683 calculation overflow.
1685 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1686 (xg_select): Check for size calculation overflow.
1687 Don't update size until alloc done.
1689 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1690 as sprintf is limited to int lengths.
1692 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1693 (X_LONG_MIN): New macros.
1694 Use them to make the following changes clearer.
1695 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1696 This change doesn't affect the value now, but it may help remind
1697 future maintainers not to raise the value too much later.
1698 (SELECTION_QUANTUM): Remove, replacing with ...
1699 (selection_quantum): ... new function, which avoids overflow.
1701 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1702 assumption that selection length fits in 'int'.
1703 (x_reply_selection_request, x_handle_selection_request)
1704 (x_get_window_property, receive_incremental_selection)
1705 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1706 (lisp_data_to_selection_data, clean_local_selection_data):
1707 Use ptrdiff_t, not int, to record length of selection.
1708 (x_reply_selection_request, x_get_window_property)
1709 (receive_incremental_selection, x_property_data_to_lisp):
1710 Redo calculations to avoid overflow.
1711 (x_reply_selection_request): When sending hint, ceiling it at
1712 X_LONG_MAX rather than relying on wraparound overflow to send
1714 (x_get_window_property, receive_incremental_selection)
1715 (lisp_data_to_selection_data, x_property_data_to_lisp):
1716 Check for size-calculation overflow.
1717 (x_get_window_property, receive_incremental_selection)
1718 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1719 Don't store size until memory allocation succeeds.
1720 (x_get_window_property): Plug memory leak on memory exhaustion.
1721 Don't double-block input; malloc is safe here. Don't assume 2**34
1722 - 4 fits in unsigned long. Add an xassert to check
1723 XGetWindowProperty overflow. Be more careful about overflow
1724 calculations, and distinguish size from memory overflow better.
1725 (receive_incremental_selection): When tracing, don't assume
1726 unsigned int is less than INT_MAX.
1727 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1728 harmful) conversions of unsigned short to int.
1729 (lisp_data_to_selection_data): Don't assume that integers
1730 in the range -65535 through -1 fit in an X unsigned short.
1731 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1732 result parameters unless successful. Rely on cons_to_unsigned
1733 to report problems with elements; the old code wasn't right anyway.
1734 (x_check_property_data): Check for int overflow; we cannot use
1735 a wider type due to X limits.
1736 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1738 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1740 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1741 (x_term_init): Check for size calculation overflow.
1742 (x_color_cells): Don't store size until memory allocation succeeds.
1743 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1744 Don't assume alloca size is less than MAX_ALLOCA.
1745 (x_term_init): Don't assume length fits in int (sprintf is limited
1748 Use ptrdiff_t for composition IDs.
1749 * character.c (lisp_string_width):
1750 * composite.c (composition_table_size, n_compositions)
1751 (get_composition_id, composition_gstring_from_id):
1752 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1753 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1754 * window.c (Frecenter):
1755 Use ptrdiff_t, not int, for composition IDs.
1756 * composite.c (get_composition_id): Check for integer overflow.
1757 * composite.h: Adjust prototypes to match the above changes.
1759 Use ptrdiff_t for hash table indexes.
1760 * category.c (hash_get_category_set):
1761 * ccl.c (ccl_driver):
1762 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1763 * coding.c (coding_system_charset_list, detect_coding_system):
1764 * coding.h (struct coding_system.id):
1765 * composite.c (get_composition_id, gstring_lookup_cache):
1766 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1767 * image.c (xpm_get_color_table_h):
1768 * lisp.h (hash_lookup, hash_put):
1769 * minibuf.c (Ftest_completion):
1770 Use ptrdiff_t for hash table indexes, not int (which is too
1771 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1772 32-bit --with-wide-int hosts).
1774 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1775 Add a FIXME comment about memory leaks.
1776 (syms_of_charset): Don't assume xmalloc returns.
1778 Don't assume that stated character widths fit in int.
1779 * character.c (Fchar_width, c_string_width, lisp_string_width):
1780 * character.h (CHAR_WIDTH):
1781 * indent.c (MULTIBYTE_BYTES_WIDTH):
1782 Use sanitize_char_width to avoid undefined and/or bad behavior
1783 with outlandish widths.
1784 * character.h (sanitize_tab_width): Rename from sanitize_width,
1785 now that we have two such functions. All uses changed.
1786 (sanitize_char_width): New inline function.
1788 Don't assume that tab-width fits in int.
1789 * character.h (sanitize_width): New inline function.
1790 (SANE_TAB_WIDTH): New macro.
1791 (ASCII_CHAR_WIDTH): Use it.
1792 * indent.c (sane_tab_width): Remove. All uses replaced by
1793 SANE_TAB_WIDTH (current_buffer).
1794 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1796 * fileio.c: Integer overflow issues with file modes.
1797 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1799 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1800 Remove unreachable code.
1801 (read_hex, load_charset_map_from_file): Check for integer overflow.
1803 * xterm.c: don't go over XClientMessageEvent limit
1804 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1805 (x_send_scroll_bar_event): Likewise. Check that the size does not
1806 exceed limits imposed by XClientMessageEvent, as well as the usual
1807 ptrdiff_t and size_t limits.
1809 * keyboard.c: Overflow, signedness and related fixes.
1810 (make_lispy_movement): Use same integer type in forward decl
1811 that is used in the definition.
1812 (read_key_sequence, keyremap_step):
1813 Change bufsize argument back to int, undoing my 2011-03-30 change.
1814 We prefer signed types, and int is wide enough here.
1815 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1816 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1817 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1818 length, not size_t. Use ptrdiff_t for index, not int.
1819 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1820 possibility of integer overflow.
1822 Overflow, signedness and related fixes for images.
1824 * dispextern.h (struct it.stack[0].u.image.image_id)
1825 (struct_it.image_id, struct image.id, struct image_cache.size)
1826 (struct image_cache.used, struct image_cache.ref_count):
1827 * gtkutil.c (update_frame_tool_bar):
1828 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1829 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1830 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1831 * nsmenu.m (update_frame_tool_bar):
1832 * xdisp.c (calc_pixel_width_or_height):
1833 * xfns.c (image_cache_refcount):
1834 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1835 on typical 64-bit hosts.
1837 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1838 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1839 Omit unnecessary casts to int.
1840 (parse_image_spec): Check that integers fall into 'int' range
1841 when the callers expect that.
1842 (image_ascent): Redo ascent calculation to avoid int overflow.
1843 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1844 (lookup_image): Remove unnecessary tests.
1845 (xbm_image_p): Locals are now of int, not EMACS_INT,
1846 since parse_image_check makes sure they fit into int.
1847 (png_load, gif_load, svg_load_image):
1848 Prefer int to unsigned where either will do.
1849 (tiff_handler): New function, combining the cores of the
1850 old tiff_error_handler and tiff_warning_handler.
1851 This function is rewritten to use vsnprintf and thereby avoid
1852 stack buffer overflows. It uses only the features of vsnprintf
1853 that are common to both POSIX and native Microsoft.
1854 (tiff_error_handler, tiff_warning_handler): Use it.
1855 (tiff_load, gif_load, imagemagick_load_image):
1856 Don't assume :index value fits in 'int'.
1857 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1858 (imagemagick_load_image): Check that crop parameters fit into
1859 the integer types that MagickCropImage accepts. Don't assume
1860 Vimagemagick_render_type has a nonnegative value. Don't assume
1861 size_t fits in 'long'.
1862 (gs_load): Use printmax_t to print the widest integers possible.
1863 Check for integer overflow when computing image height and width.
1865 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1867 * xdisp.c (redisplay_window): Don't force window start if point
1868 will be invisible in the resulting window. (Bug#9324)
1870 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1873 the display spec is of the form `(space ...)'.
1874 (handle_display_spec): Return the value returned by
1875 handle_single_display_spec, not just 1 or zero.
1876 (handle_single_display_spec): If the display spec is of the form
1877 `(space ...)', and specifies display in the text area, return 2
1879 (try_cursor_movement): Check for the need to scroll more
1880 accurately, and prefer exact match for point under bidi.
1881 Don't advance `row' beyond the last row of the window.
1883 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1884 into disp_prop; all users changed.
1886 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1887 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1888 for the text covered by the display property.
1890 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1892 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1893 Change return value to nil.
1894 (Frecord_buffer): Delete unused function.
1896 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1898 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1899 buffers, return left-to-right.
1900 (set_cursor_from_row): Consider candidate row a win if its glyph
1901 represents a newline and point is on that newline. Fixes cursor
1902 positioning on the newline at EOL of R2L text within L2R
1903 paragraph, and vice versa.
1904 (try_cursor_movement): Check continued rows, in addition to
1905 continuation rows. Fixes unwarranted scroll when point enters a
1906 continued line of R2L text within an L2R paragraph, or vice versa.
1907 (cursor_row_p): Consider the case of point being equal to
1908 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1909 from the end of a short line to the beginning of a continued line
1910 of R2L text within L2R paragraph.
1911 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1912 composed characters.
1914 * bidi.c (bidi_check_type): Use xassert.
1915 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1918 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1920 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1923 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1925 * nsfont.m (ns_otf_to_script): Fix typo.
1927 2011-08-22 Kenichi Handa <handa@m17n.org>
1929 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1930 extra slot even if the purpose is char-code-property-table.
1932 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (redisplay_window): When computing centering_position,
1935 account for the height of the header line. (Bug#8874)
1937 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1938 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1939 candidate is selected by the mouse, and that candidate has a
1940 composed character under the mouse.
1942 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1943 coordinates reported by pos-visible-in-window-p for a composed
1944 character in column zero.
1946 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1948 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1950 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1952 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1953 consider it a hit if to_charpos is anywhere in the range of the
1954 composed buffer positions.
1956 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1958 * image.c (gif_load): Don't assume that each subimage has the same
1959 dimensions as the base image. Handle disposal method that is
1960 "undefined" by the gif spec (Bug#9335).
1962 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1964 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1965 (Fcondition_case): Document `debug' symbol in error handler.
1967 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1969 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1970 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1971 from an Org mode buffer to a Speedbar frame.
1973 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1974 a composition, take its buffer position from IT->cmp_it.charpos.
1975 Fixes cursor positioning at the beginning of a line that begins
1976 with a composed character.
1978 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1980 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1981 character bidirectional type, use STRONG_L instead. Fixes crashes
1982 in a buffer produced by `describe-categories'.
1984 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1985 members before the level stack, so they would be saved and
1986 restored when copying iterator state. Fixes incorrect reordering
1987 around TABs covered by display properties.
1989 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1991 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1993 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1995 * eval.c (internal_condition_case, internal_condition_case_1)
1996 (internal_condition_case_2, internal_condition_case_n):
1997 Remove unnecessary aborts (Bug#9081).
1999 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2001 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2002 has no `load' handler, try opening the file locally. (Bug#9311)
2004 2011-08-16 Ken Brown <kbrown@cornell.edu>
2006 * gmalloc.c: Expand comment.
2008 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2010 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2011 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2013 2011-08-16 Ken Brown <kbrown@cornell.edu>
2015 Fix memory allocation problems in Cygwin build (Bug#9273).
2017 * unexcw.c ( __malloc_initialized): Declare external variable.
2018 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2020 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2022 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2024 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2026 [CYGWIN] (special_realloc): New function.
2027 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2028 requests to realloc storage in the static heap.
2030 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2032 * bidi.c (bidi_initialize): Remove unused local.
2034 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2037 * biditype.h: Remove file.
2038 * makefile.w32-in ($(BLD)/bidi.$(O)):
2039 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2041 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2043 * chartab.c: Improve commentary for the uniprop_table API.
2045 * bidi.c (bidi_paragraph_init): Support zero value of
2046 bidi_ignore_explicit_marks_for_paragraph_level.
2047 (bidi_initialize): Use uniprop_table instead of including
2048 biditype.h and bidimirror.h.
2050 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2051 coordinates of the iterator when restoring from ppos_it.
2054 2011-08-14 Kenichi Handa <handa@m17n.org>
2056 * process.c (create_process): Call setup_process_coding_systems
2057 after the pid of the process is set to -1 (Bug#8162).
2059 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2061 * xdisp.c (move_it_in_display_line_to): Don't invoke
2062 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2063 ppos_it. Fixes vertical cursor motion when line beginning is
2064 covered by an image. (Bug#9296)
2066 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2068 * nsterm.h (ns_run_ascript): Declare.
2069 (NSAPP_DATA2_RUNASSCRIPT): Define.
2071 * nsfns.m (as_script, as_result, as_status): New static variables.
2072 (ns_run_ascript): New function.
2073 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2074 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2075 the event loop. Get status from as_status (Bug#7276).
2077 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2078 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2079 the event loop (Bug#7276).
2081 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2083 * gnutls.c (QCgnutls_bootprop_priority)
2084 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2085 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2086 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2087 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2088 (QCgnutls_bootprop_verify_hostname_error)
2089 (QCgnutls_bootprop_callbacks_verify): Rename from
2090 Qgnutls_bootprop_..., all uses changed.
2092 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2095 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2097 * xfaces.c (Qframe_set_background_mode): Now static.
2098 * dispextern.h (Qframe_set_background_mode): Remove decl.
2100 * process.c (Fnetwork_interface_info): Declare local only if needed.
2102 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2104 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2105 (Fnetwork_interface_list): Allocate in increments of bytes instead
2106 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2107 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2109 (struct ifflag_def): notrailers is smart on OSX.
2110 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2111 Get hardware address with getifaddrs if available.
2113 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2115 * xdisp.c (iterate_out_of_display_property): xassert that
2116 IT->position is set to within IT->object's boundaries. Break from
2117 the loop as soon as EOB is reached; avoids infloops in redisplay
2118 when IT->position is set up wrongly due to some bug.
2119 Set IT->current to match the bidi iterator unconditionally.
2120 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2121 entry. Force push_it to save on the stack the current
2122 buffer/string position, to be restored by pop_it. Fix flags in
2123 the iterator structure wrt the object coming from a display
2124 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2125 properties. (Bug#9284)
2127 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2129 * fontset.c (fontset_get_font_group): Add proper type checks.
2132 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2134 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2135 and LC_VERSION_MIN_MACOSX.
2136 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2137 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2139 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (forward_to_next_line_start): Allow to use the
2142 no-display-properties-and-no-overlays under bidi display.
2143 Set disp_pos in the bidi iterator to avoid searches for display
2144 properties and overlays.
2146 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2148 * editfns.c (Fset_time_zone_rule): Document relationship with the
2151 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2152 the font entity extracted from the cache (Bug#8109).
2154 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2156 * composite.c (autocmp_chars): Don't reset point. That is done by
2157 restore_point_unwind (Bug#5984).
2159 2011-08-07 Juri Linkov <juri@jurta.org>
2161 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2162 to show the arg `TIME' instead of `TIMEVAL'.
2164 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2166 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2167 display property strides EOL and includes a newline, as in
2168 longlines-mode. (Bug#9254)
2169 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2170 word-wrap under bidirectional display. (Bug#9224)
2172 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2173 is non-zero, even if the data buffer is NULL. Fixes a crash in
2174 vertical-motion with longlines-mode. (Bug#9254)
2176 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2178 * bidi.c <bidi_cache_total_alloc>: Now static.
2179 (bidi_initialize): Initialize bidi_cache_total_alloc.
2181 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2184 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2185 amount allocated this far in `bidi_cache_total_alloc'.
2186 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2187 non-zero, only free the data buffer without restoring the cache
2188 contents. All callers changed.
2190 * dispextern.h (bidi_unshelve_cache): Update prototype.
2192 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2193 (move_it_in_display_line, move_it_to)
2194 (move_it_vertically_backward, move_it_by_lines): Replace the call
2195 to xfree to an equivalent call to bidi_unshelve_cache.
2196 (move_it_in_display_line_to): Fix logic of returning
2197 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2199 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2201 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2202 came from a string character with a `cursor' property. (Bug#9229)
2204 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2206 * Makefile.in (LIB_PTHREAD): New variable.
2207 (LIBES): Add LIB_PTHREAD (Bug#9216).
2209 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2210 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2212 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2214 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2216 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2218 * xterm.c (x_find_topmost_parent): New function.
2219 (x_set_frame_alpha): Find topmost parent window with
2220 x_find_topmost_parent and set the property there also (bug#9181).
2221 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2223 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2225 * callproc.c (Fcall_process): Avoid vfork clobbering
2226 the local vars buffer, coding_systems, current_dir.
2228 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2230 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2232 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2234 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2235 so that it is not optimized away.
2237 * xdisp.c (compute_display_string_pos): Remove unused local.
2239 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2241 Fix slow cursor motion and scrolling in large buffers with
2242 selective display, like Org Mode buffers. (Bug#9218)
2244 * dispextern.h (struct bidi_it): New member disp_prop_p.
2246 * xdisp.c: Remove one-slot cache of display string positions.
2247 (compute_display_string_pos): Accept an additional argument
2248 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2249 for a display string or property. If found, set DISP_PROP_P
2252 * bidi.c (bidi_fetch_char): Accept an additional argument
2253 DISP_PROP_P, and pass it to compute_display_string_pos.
2254 Only handle text covered by a display string if DISP_PROP_P is returned
2255 non-zero. All callers of bidi_fetch_char changed.
2257 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2259 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2261 2010-12-03 Don March <don@ohspite.net>
2263 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2264 last character M-[char] is translated to ESC [char] (bug#7541).
2266 2011-08-02 Kenichi Handa <handa@m17n.org>
2268 * lisp.h (uniprop_table): Extern it.
2270 * chartab.c (uniprop_table): Make it non-static.
2272 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2274 * xdisp.c (forward_to_next_line_start): Accept additional argument
2275 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2277 (reseat_at_next_visible_line_start): Use the bidi iterator state
2278 returned by forward_to_next_line_start to restore the state of
2279 it->bidi_it after backing up to previous newline. (Bug#9212)
2281 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2283 * regex.c (re_comp): Protoize.
2284 (re_exec): Fix return type.
2285 (regexec): Fix type of `ret'. (Bug#9203)
2287 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2289 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2290 This is needed if max-image-size is a floating-point number.
2292 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2294 * print.c (print_object): Print empty symbol as ##.
2296 * lread.c (read1): Read ## as empty symbol.
2298 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2300 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2301 setting frame foreground color (Bug#9175).
2302 (x_set_background_color): Likewise.
2304 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2305 contents (Bug#9176).
2306 (EmacsTooltip -init): Remove bezels and add shadows to
2309 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2310 or scroll bar (Bug#8470).
2312 * nsfont.m (nsfont_open): Remove assignment to voffset and
2313 unnecessary vars hshink, expand, hd, full_height, min_height.
2314 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2316 * nsterm.h (nsfont_info): Remove voffset field.
2318 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2320 Implement strike-through and overline on NextStep (Bug#8863).
2322 * nsfont.m (nsfont_open): Use underline position provided by font,
2323 instead of hard-coded value of 2.
2324 (nsfont_draw): Call ns_draw_text_decoration instead.
2326 * nsterm.h: Add declaration for ns_draw_text_decoration.
2328 * nsterm.m (ns_draw_text_decoration): New function for drawing
2329 underline, overline, and strike-through.
2330 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2331 ns_draw_text_decoration. Change treatment of cursor drawing to
2332 accommodate underlining, etc.
2334 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2336 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2339 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2341 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2342 Without this fix, if a signal arrives just after memory fills up,
2343 'malloc' might be invoked reentrantly.
2345 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2346 In other words, assume that every image size is allowed, on non-X
2347 hosts. This assumption is probably wrong, but it lets Emacs compile.
2349 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2351 * regex.c (re_iswctype): Convert return values to boolean.
2353 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2355 * xdisp.c (compute_display_string_pos): Don't use cached display
2356 string position if the buffer had its restriction changed.
2359 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2363 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2365 Integer signedness and overflow and related fixes. (Bug#9079)
2367 * bidi.c: Integer size and overflow fixes.
2368 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2369 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2370 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2371 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2372 (bidi_find_other_level_edge):
2373 Use ptrdiff_t instead of EMACS_INT where either will do.
2374 This works better on 32-bit hosts configured --with-wide-int.
2375 (bidi_cache_ensure_space): Check for size-calculation overflow.
2376 Use % rather than repeated addition, for better worst-case speed.
2377 Don't set bidi_cache_size until after xrealloc returns, because it
2379 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2380 (bidi_cache_ensure_space): Also check that the bidi cache size
2381 does not exceed that of the largest Lisp string or buffer. See Eli
2382 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2384 * alloc.c (__malloc_size_t): Remove.
2385 All uses replaced by size_t. See Andreas Schwab's note
2386 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2388 * image.c: Improve checking for integer overflow.
2389 (check_image_size): Assume that f is nonnull, since
2390 it is always nonnull in practice. This is one less thing to
2391 worry about when checking for integer overflow later.
2392 (x_check_image_size): New function, which checks for integer
2393 overflow issues inside X.
2394 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2395 This removes the need for a memory_full check.
2396 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2397 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2398 (xbm_read_bitmap_data): Change locals back to 'int', since
2399 their values must fit in 'int'.
2400 (xpm_load_image, png_load, tiff_load):
2401 Invoke x_create_x_image_and_pixmap earlier,
2402 to avoid much needless work if the image is too large.
2403 (tiff_load): Treat overly large images as if
2404 x_create_x_image_and_pixmap failed, not as malloc failures.
2405 (gs_load): Use x_check_image_size.
2407 * gtkutil.c: Omit integer casts.
2408 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2409 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2411 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2413 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2414 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2415 would wrongly return t on a 64-bit host.
2417 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2418 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2419 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2420 and therefore cause GCC to emit a bogus diagnostic in some cases.
2422 * image.c: Integer signedness and overflow and related fixes.
2423 This is not an exhaustive set of fixes, but it's time to
2424 record what I've got.
2425 (lookup_pixel_color, check_image_size): Remove redundant decls.
2426 (check_image_size): Don't assume that arbitrary EMACS_INT values
2427 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2428 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2429 (tiff_load, imagemagick_load_image):
2430 Check for overflow in size calculations.
2431 (x_create_x_image_and_pixmap): Remove unnecessary test for
2432 xmalloc returning NULL; that can't happen.
2433 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2434 (xpm_color_bucket): Use better integer hashing function.
2435 (xpm_cache_color): Don't possibly over-allocate memory.
2436 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2437 (gif_memory_source):
2438 Use ptrdiff_t, not int or size_t, to record sizes.
2439 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2440 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2441 either works, as we prefer signed integers.
2442 (tiff_read_from_memory, tiff_write_from_memory):
2443 Return tsize_t, not size_t, since that's what the TIFF API wants.
2444 (tiff_read_from_memory): Don't fail simply because the read would
2445 go past EOF; instead, return a short read.
2446 (tiff_load): Omit no-longer-needed casts.
2447 (Fimagemagick_types): Don't assume size fits into 'int'.
2449 Improve hashing quality when configured --with-wide-int.
2450 * fns.c (hash_string): New function, taken from sxhash_string.
2451 Do not discard information about ASCII character case; this
2452 discarding is no longer needed.
2453 (sxhash-string): Use it. Change sig to match it. Caller changed.
2454 * lisp.h: Declare it.
2455 * lread.c (hash_string): Remove, since we now use fns.c's version.
2456 The fns.c version returns a wider integer if --with-wide-int is
2457 specified, so this should help the quality of the hashing a bit.
2459 * emacs.c: Integer overflow minor fix.
2460 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2461 Define only if GNU_LINUX.
2462 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2464 * dispnew.c: Integer signedness and overflow fixes.
2465 Remove unnecessary forward decls, that were a maintenance hassle.
2466 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2468 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2469 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2470 (prepare_desired_row, line_draw_cost):
2471 Use int, not unsigned, where either works.
2472 (save_current_matrix, restore_current_matrix):
2473 Use ptrdiff_t, not size_t, where either works.
2474 (init_display): Check for overflow more accurately, and without
2475 relying on undefined behavior.
2477 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2478 Remove, replacing with the new symbols in lisp.h. All uses changed.
2479 * fileio.c (make_temp_name):
2480 * filelock.c (lock_file_1, lock_file):
2481 * xdisp.c (message_dolog):
2482 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2483 Use pMd etc. instead.
2484 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2485 replacing the pWIDE etc. symbols removed from editfns.c.
2487 * keyboard.h (num_input_events): Now uintmax_t.
2488 This is (very slightly) less likely to mess up due to wraparound.
2491 * buffer.c: Integer signedness fixes.
2492 (alloc_buffer_text, enlarge_buffer_text):
2493 Use ptrdiff_t rather than size_t when either will do, as we prefer
2496 * alloc.c: Integer signedness and overflow fixes.
2497 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2498 (__malloc_size_t): Default to size_t, not to int.
2499 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2500 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2501 Prefer ptrdiff_t to size_t when either would do, as we prefer
2503 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2504 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2505 Now const. Initialize with values that are in range even if char
2507 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2508 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2509 These functions do the right thing with sizes > 2**32.
2510 (check_depth): Now ptrdiff_t, not int.
2511 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2512 Adjust to new way of storing sizes. Check for size overflow bugs
2514 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2515 slightly wrong anyway, as it missed one instance of
2516 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2517 (refill_memory_reserve): Omit needless cast to size_t.
2518 (mark_object_loop_halt): Mark as externally visible.
2520 * xselect.c: Integer signedness and overflow fixes.
2521 (Fx_register_dnd_atom, x_handle_dnd_message):
2522 Use ptrdiff_t, not size_t, since we prefer signed.
2523 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2524 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2525 x_dnd_atoms_size and x_dnd_atoms_length.
2527 * doprnt.c: Prefer signed to unsigned when either works.
2529 * doprnt.c (doprnt):
2531 * xdisp.c (vmessage):
2532 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2533 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2534 prefer signed arithmetic to avoid comparison confusion.
2535 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2536 but is a bit tricky.
2538 Assume freestanding C89 headers, string.h, stdlib.h.
2539 * data.c, doprnt.c, floatfns.c, print.c:
2540 Include float.h unconditionally.
2541 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2542 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2543 * regex.c: Likewise for stddef.h, string.h.
2544 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2545 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2546 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2547 (STDC_HEADERS): Remove obsolete defines.
2548 * sysdep.c: Include limits.h unconditionally.
2550 Assume support for memcmp, memcpy, memmove, memset.
2551 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2552 * regex.c (memcmp, memcpy):
2553 Remove; we assume C89 now.
2555 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2556 (__malloc_safe_bcopy): Remove; no longer needed.
2558 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2559 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2560 well either way, and we prefer signed to unsigned.
2562 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2564 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2565 closes the connection while we're reading (bug#9182).
2567 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2569 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2570 are specified (Bug#9168).
2572 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2574 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2575 Found by GCC static checking and --with-wide-int on a 32-bit host.
2577 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2579 * xdisp.c (compute_display_string_pos): Fix logic of caching
2580 previous display string position. Initialize cached_prev_pos to
2581 -1. Fixes slow-down at the beginning of a buffer.
2583 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2585 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2586 for attrs[LFACE_FONTSET_INDEX].
2588 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2590 * xml.c (parse_region): Remove unused local
2591 that was recently introduced.
2593 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2595 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2596 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2598 * xdisp.c (move_it_in_display_line_to): Record the best matching
2599 position for TO_CHARPOS while scanning the line, and restore it on
2600 exit if none of the characters scanned was an exact match.
2601 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2602 when exact match is impossible due to invisible text, and the
2603 lines are truncated.
2605 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2607 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2610 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2612 Fix a significant slow-down of cursor motion with C-n, C-p,
2613 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2614 auto-repeat under bidi redisplay in fontified buffers.
2615 * xdisp.c (compute_stop_pos_backwards): New function.
2616 (next_element_from_buffer): Call compute_stop_pos_backwards to
2617 find a suitable prev_stop when we find ourselves before
2619 (reseat): Don't look for prev_stop, as that could mean a very long
2621 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2622 <cached_disp_overlay_modiff>: Cache for last found display string
2624 (compute_display_string_pos): Return the cached position if asked
2625 about the same buffer in the same area of character positions, and
2626 the buffer wasn't changed since the time the display string
2627 position was cached.
2629 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2631 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2632 is an integer, which is important for empty lines. (Bug#9149)
2634 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2636 * frame.c (Fmodify_frame_parameters): In tty case, update the
2637 default face if necessary (Bug#4238).
2639 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2641 * editfns.c (Fstring_to_char): No need to explain what a character
2642 is in the docstring (Bug#6576).
2644 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2646 * xml.c (parse_region): Make sure we always return a tree.
2648 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2650 * xml.c (parse_region): If a document contains only comments,
2653 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2655 * xml.c (make_dom): Return comments, too.
2657 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2660 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2661 and the surrounding thread.
2662 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2663 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2664 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2666 * s/openbsd.h (BROKEN_SIGIO): Define.
2667 * unexelf.c (unexec) [__OpenBSD__]:
2668 Don't update the .mdebug section of the Alpha COFF symbol table.
2670 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2672 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2675 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2677 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2678 This fixes some race conditions on the permissions of any newly
2681 * alloc.c (valid_pointer_p): Use pipe, not open.
2682 This fixes some permissions issues when debugging.
2684 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2685 If fchown fails to set both uid and gid, try to set just gid,
2686 as that is sometimes allowed. Adjust the file's mode to eliminate
2687 setuid or setgid bits that are inappropriate if fchown fails.
2689 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2691 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2692 to compare Lisp_Objects.
2693 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2694 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2695 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2697 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2699 * lread.c (read_integer): Unread even EOF character.
2700 (read1): Likewise. Properly record start position of symbol.
2702 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2703 symbol character follows.
2705 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2707 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2708 This works around a problem with the previous change to Fcopy_file.
2709 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2710 and without this change, GCC might complain about discarding
2711 fchown's return value.
2713 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2715 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2717 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2719 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2721 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2724 it's used from the C level.
2726 * process.c: Use the same condition for POLL_FOR_INPUT in both
2727 keyboard.c and process.c (bug#1858).
2729 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2731 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2732 (Fgnutls_boot): Use it.
2734 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2736 * doc.c (Fsubstitute_command_keys): Revert last change.
2738 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2740 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2741 quotes the next character, and doesn't affect other longer
2742 sequences (bug#8935).
2744 * lread.c (syms_of_lread): Clarify that is isn't only
2745 `eval-buffer' and `eval-defun' that's affected by
2746 `lexical-binding' (bug#8460).
2748 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2750 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2751 bidi redisplay when a line includes both an image and is truncated.
2753 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2755 Fix minor problems found by static checking.
2756 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2757 (elsz): Now a signed constant, not a size_t var. We prefer signed
2758 types to unsigned, to avoid integer comparison confusion. Without
2759 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2760 "cannot optimize loop, the loop counter may overflow", a symptom
2762 * indent.c (Fvertical_motion): Mark locals as initialized.
2763 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2765 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767 * search.c (Fre_search_backward): Mention `case-fold-search' in
2768 all the re_search_* functions (bug#8138).
2770 * keyboard.c (Fopen_dribble_file): Document when the file is
2773 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2775 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2778 Support bidi reordering of display and overlay strings.
2779 * xdisp.c (compute_display_string_pos)
2780 (compute_display_string_end): Accept additional argument STRING.
2781 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2782 (reseat_to_string): Initialize bidi_it->string.s and
2783 bidi_it->string.schars.
2784 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2785 NULL (avoids a crash in bidi_paragraph_init).
2786 Initialize itb.string.lstring.
2787 (init_iterator): Call bidi_init_it only of a valid
2788 buffer position was specified. Initialize paragraph_embedding to
2790 (reseat_to_string): Initialize the bidi iterator.
2791 (display_string): If we need to ignore text properties of
2792 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2793 original value of -1 will not work with bidi.)
2794 (compute_display_string_pos): First arg is now struct
2795 `text_pos *'; all callers changed. Support display properties on
2797 (compute_display_string_end): Support display properties on Lisp
2799 (init_iterator, reseat_1, reseat_to_string): Initialize the
2800 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2801 when iterating on a string not from display properties).
2802 (compute_display_string_pos, compute_display_string_end):
2803 Fix calculation of the object to scan. Fixes an error when using
2805 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2806 base_level_stop; instead, set base_level_stop to BEGV.
2807 Fixes crashes in vertical-motion.
2808 (next_element_from_buffer): Improve commentary for when
2809 the iterator is before prev_stop.
2810 (init_iterator): Initialize bidi_p from the default value of
2811 bidi-display-reordering, not from buffer-local value. Use the
2812 buffer-local value only if initializing for buffer iteration.
2813 (handle_invisible_prop): Support invisible properties on strings
2814 that are being bidi-reordered.
2815 (set_iterator_to_next): Support bidi reordering of C strings and
2817 (next_element_from_string): Support bidi reordering of Lisp
2819 (handle_stop_backwards): Support Lisp strings as well.
2820 (display_string): Support display of R2L glyph rows.
2821 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2822 (init_iterator): Don't initialize it->bidi_p for strings
2824 (reseat_to_string): Initialize it->bidi_p for strings here.
2825 (next_element_from_string, next_element_from_c_string)
2826 (next_element_from_buffer): Add xassert's for correspondence
2827 between IT's object being iterated and it->bidi_it.string
2829 (face_before_or_after_it_pos): Support bidi iteration.
2830 (next_element_from_c_string): Handle the case of the first string
2831 character that is not the first one in the visual order.
2832 (get_visually_first_element): New function, refactored from common
2833 parts of next_element_from_buffer, next_element_from_string, and
2834 next_element_from_c_string.
2835 (tool_bar_lines_needed, redisplay_tool_bar)
2836 (display_menu_bar): Force left-to-right direction. Add a FIXME
2837 comment for making that be controlled by a user option.
2838 (push_it, pop_it): Save and restore the state of the
2839 bidi iterator. Save and restore the bidi_p flag.
2840 (pop_it): Iterate out of display property for string iteration as
2842 (iterate_out_of_display_property): Support iteration over strings.
2843 (handle_single_display_spec): Set up it->bidi_it for iteration
2844 over a display string, and call bidi_init_it.
2845 (handle_single_display_spec, next_overlay_string)
2846 (get_overlay_strings_1, push_display_prop): Set up the bidi
2847 iterator for displaying display or overlay strings.
2848 (forward_to_next_line_start): Don't use the shortcut if
2850 (back_to_previous_visible_line_start): If handle_display_prop
2851 pushed the iterator stack, restore the internal state of the bidi
2852 iterator by calling bidi_pop_it same number of times.
2853 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2854 and we are bidi-iterating, don't decrement the iterator position;
2855 instead, set the first_elt flag in the bidi iterator, to produce
2857 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2858 (push_display_prop): xassert that we are iterating a buffer.
2859 (push_it, pop_it): Save and restore paragraph_embedding member.
2860 (handle_single_display_spec, next_overlay_string)
2861 (get_overlay_strings_1, reseat_1, reseat_to_string)
2862 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2863 correctly. Don't assume unibyte strings are not bidi-reordered.
2864 (compute_display_string_pos)
2865 (compute_display_string_end): Fix handling the case of C string.
2866 (push_it, pop_it): Save and restore from_disp_prop_p.
2867 (handle_single_display_spec, push_display_prop): Set the
2868 from_disp_prop_p flag.
2869 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2870 (pop_it): Call iterate_out_of_display_property only if we are
2871 popping after iteration over a string that came from a display
2872 property. Fix a typo in popping stretch info. Add an assertion
2873 for verifying that the iterator position is in sync with the bidi
2875 (handle_single_display_spec, get_overlay_strings_1)
2876 (push_display_prop): Fix initialization of paragraph direction for
2877 string when that of the parent object is not yet determined.
2878 (reseat_1): Call bidi_init_it to resync the bidi
2879 iterator with IT's position. (Bug#7616)
2880 (find_row_edges): If ROW->start.pos gives position
2881 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2882 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2883 Reset the from_disp_prop_p flag.
2884 (SAVE_IT, RESTORE_IT): New macros.
2885 (pos_visible_p, face_before_or_after_it_pos)
2886 (back_to_previous_visible_line_start)
2887 (move_it_in_display_line_to, move_it_in_display_line)
2888 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2889 (try_scrolling, redisplay_window, display_line): Use them when
2890 saving a temporary copy of the iterator and restoring it back.
2891 (back_to_previous_visible_line_start, reseat_1)
2892 (init_iterator): Empty the bidi cache "stack".
2893 (move_it_in_display_line_to): If iterator ended up at
2894 EOL, but we never saw any buffer positions smaller than
2895 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2896 motion in bidi-reordered lines.
2897 (move_it_in_display_line_to): Record prev_method and prev_pos
2898 immediately before the call to set_iterator_to_next. Fixes cursor
2899 motion in bidi-reordered lines with stretch glyphs and strings
2900 displayed in margins. (Bug#8133) (Bug#8867)
2901 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2903 (pos_visible_p): Support positions in bidi-reordered lines.
2904 Save and restore bidi cache.
2906 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2907 (bidi_paragraph_info): Delete unused struct.
2908 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2909 (bidi_cache_start): New variable.
2910 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2912 (bidi_cache_fetch_state, bidi_cache_search)
2913 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2914 (bidi_cache_find, bidi_peek_at_next_level)
2915 (bidi_level_of_next_char, bidi_find_other_level_edge)
2916 (bidi_move_to_visually_next): Compare cache index with
2917 bidi_cache_start rather than with zero.
2918 (bidi_fetch_char): Accept new argument STRING; all callers
2919 changed. Support iteration over a string. Support strings with
2920 display properties. Support unibyte strings. Fix the type of
2921 `len' according to what STRING_CHAR_AND_LENGTH expects.
2922 (bidi_paragraph_init, bidi_resolve_explicit_1)
2923 (bidi_resolve_explicit, bidi_resolve_weak)
2924 (bidi_level_of_next_char, bidi_move_to_visually_next):
2925 Support iteration over a string.
2926 (bidi_set_sor_type, bidi_resolve_explicit_1)
2927 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2928 can now be zero (for strings); special values 0 and -1 were
2929 changed to -1 and -2, respectively.
2930 (bidi_char_at_pos): New function.
2931 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2932 Call it instead of FETCH_MULTIBYTE_CHAR.
2933 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2934 initialized to valid values.
2935 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2937 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2938 the test for valid cached positions. Fix the logic for looking up
2939 the sentinel state in the cache. GCPRO the Lisp string we are
2941 (bidi_push_it, bidi_pop_it): New functions.
2942 (bidi_initialize): Initialize the bidi cache start stack pointer.
2943 (bidi_cache_ensure_space): New function, refactored from part of
2944 bidi_cache_iterator_state. Don't assume the required size is just
2945 one BIDI_CACHE_CHUNK away.
2946 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2947 (bidi_count_bytes, bidi_char_at_pos): New functions.
2948 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2949 always valid if bidi_cache_idx is valid.
2950 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2951 is valid if it's going to be used.
2952 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2953 (bidi_cache_fetch_state, bidi_cache_search)
2954 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2955 (bidi_cache_iterator_state, bidi_cache_find)
2956 (bidi_find_other_level_edge, bidi_cache_start_stack):
2957 All variables related to cache indices are now EMACS_INT.
2959 * dispextern.h (struct bidi_string_data): New structure.
2960 (struct bidi_it): New member `string'. Make flag members be 1-bit
2961 fields, and put them last in the struct.
2962 (compute_display_string_pos, compute_display_string_end):
2964 (bidi_push_it, bidi_pop_it): Add prototypes.
2965 (struct iterator_stack_entry): New members bidi_p,
2966 paragraph_embedding, and from_disp_prop_p.
2967 (struct it): Member bidi_p is now a bit field 1 bit wide.
2968 (bidi_shelve_cache, bidi_unshelve_cache):
2971 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2972 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2973 and vector-like objects.
2975 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2976 cache around display iteration.
2978 * window.c (Fwindow_end, window_scroll_pixel_based)
2979 (displayed_window_lines, Frecenter): Save and restore the bidi
2980 cache around display iteration.
2982 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2984 * editfns.c (Fdelete_region): Clarify the use of the named
2985 parameters (bug#6788).
2987 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2989 * indent.c (Fvertical_motion): Set and restore w->pointm when
2990 saving and restoring the window's buffer (Bug#9006).
2992 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2994 * editfns.c (Fstring_to_char): Clarify just what is returned
2995 (bug#6576). Text by Eli Zaretskii.
2997 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2999 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3001 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3003 * buffer.c (mmap_find): Fix a typo.
3005 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3007 Fix execution of x selection hooks.
3008 * xselect.c (Qx_lost_selection_functions)
3009 (Qx_sent_selection_functions): New vars.
3010 (syms_of_xselect): DEFSYM them.
3011 (x_handle_selection_request): Pass Qx_sent_selection_functions
3012 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3013 (x_handle_selection_clear,x_clear_frame_selections):
3014 Pass Qx_lost_selection_functions rather than
3015 Vx_lost_selection_functions to Frun_hook_with_args.
3017 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3019 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3020 The old code sometimes used this field without initializing it.
3022 * alloc.c (gc_sweep): Don't read past end of array.
3023 In theory, the old code could also have corrupted Emacs internals,
3024 though it'd be very unlikely.
3026 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3028 * character.c (Fcharacterp): Don't advertise optional ignored
3029 argument. (Bug#4026)
3031 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3033 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3036 * window.c (Fset_window_start): Doc fix (bug#4199).
3037 (Fset_window_hscroll): Ditto.
3039 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3041 Fix minor new problems caught by GCC 4.6.1.
3042 * term.c (init_tty): Remove unused local.
3043 * xsettings.c (store_monospaced_changed): Define this function only
3044 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3047 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3049 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3051 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3053 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3054 are the mini-buffer and the echo area (bug#3320).
3056 * term.c (init_tty): Remove support for supdup, c10 and perq
3057 terminals, which are no longer supported (bug#1482).
3059 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3061 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3063 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3065 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3066 for non-popups (Bug#3642).
3068 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3070 * alloc.c (reset_malloc_hooks): Protoize.
3071 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3072 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3073 * cm.c (losecursor): Likewise.
3074 * data.c (fmod): Likewise.
3075 * dispnew.c (swap_glyphs_in_rows): Likewise.
3076 * emacs.c (memory_warning_signal): Likewise.
3077 * floatfns.c (float_error): Likewise.
3078 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3079 (otf_open, font_otf_capability, generate_otf_features)
3080 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3082 * image.c (pbm_read_file): Likewise.
3083 * indent.c (string_display_width): Likewise.
3084 * intervals.c (check_for_interval, search_for_interval)
3085 (inc_interval_count, count_intervals, root_interval)
3086 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3087 * lread.c (defalias): Likewise.
3088 * ralloc.c (r_alloc_check): Likewise.
3089 * regex.c (set_image_of_range_1, set_image_of_range)
3090 (regex_grow_registers): Likewise.
3091 * sysdep.c (strerror): Likewise.
3092 * termcap.c (valid_filename_p, tprint, main): Likewise.
3093 * tparam.c (main): Likewise.
3094 * unexhp9k800.c (run_time_remap, save_data_space)
3095 (update_file_ptrs, read_header, write_header, calculate_checksum)
3096 (copy_file, copy_rest, display_header): Likewise.
3097 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3099 * xdisp.c (check_it): Likewise.
3100 * xfaces.c (register_color, unregister_color, unregister_colors):
3102 * xfns.c (print_fontset_result): Likewise.
3103 * xrdb.c (member, fatal, main): Likewise.
3105 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3107 Fix minor problems found by static checking (Bug#9031).
3108 * chartab.c (char_table_set_range, map_sub_char_table):
3109 Remove unused locals.
3110 (uniprop_table): Now static.
3111 * composite.c (_work_char): Remove unused static var.
3113 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3115 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3117 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3119 * gtkutil.c (qttip_cb): Remove code without function.
3121 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3123 * w32.c (pthread_sigmask): New stub.
3125 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3127 Use pthread_sigmask, not sigprocmask (Bug#9010).
3128 sigprocmask is portable only for single-threaded applications, and
3129 Emacs can be multi-threaded when it uses GTK.
3130 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3132 * callproc.c (Fcall_process):
3133 * process.c (create_process):
3134 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3135 Use pthread_sigmask, not sigprocmask.
3137 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3139 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3140 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3143 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3145 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3146 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3147 (xg_hide_tooltip): Fix comment.
3149 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3150 in registerServicesMenuSendTypes.
3151 (validRequestorForSendType): Don't check ns_return_types.
3153 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3156 2011-07-08 Jason Rumney <jasonr@gnu.org>
3158 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3159 SH_SHOW for hidden windows (Bug#5482).
3161 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3162 frame struct members of non-existent frames (Bug#6284).
3164 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3166 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3167 variable firstTime not needed on OSX >= 10.6.
3168 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3169 >= 10.5. Use setKnobProportion, setDoubleValue.
3171 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3172 (MAC_OS_X_VERSION_10_5): Define if not defined.
3173 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3174 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3175 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3177 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3178 cString and lossyCString on OSX >= 10.4
3180 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3181 sizeToFit on OSX >= 10.2.
3183 * nsimage.m (allocInitFromFile): Don't use deprecated method
3184 bestRepresentationForDevice on OSX >= 10.6.
3186 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3189 * emacs.c: Declare unexec_init_emacs_zone.
3191 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3193 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3195 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3196 on svcsMenu (Bug#8842).
3198 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3200 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3202 * nsterm.m (QUTF8_STRING): Declare.
3203 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3204 (validRequestorForSendType): Return type is (id).
3205 Change indexOfObjectIdenticalTo to indexOfObject.
3206 Check if we have local selection before returning self (Bug#8842).
3207 (writeSelectionToPasteboard): Put local selection into paste board
3208 if we have a local selection (Bug#8842).
3209 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3211 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3212 (ns_get_local_selection): Declare.
3214 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3216 * keymap.c (describe_map_tree): Don't insert a double newline at
3217 the end of the buffer (bug#1169) and return whether we inserted
3220 * callint.c (Fcall_interactively): Change "reading args" to
3221 "providing args" to try to clarify what it does (bug#1010).
3223 2011-07-07 Kenichi Handa <handa@m17n.org>
3225 * composite.c (composition_compute_stop_pos): Ignore a static
3226 composition starting before CHARPOS (Bug#8915).
3228 * xdisp.c (handle_composition_prop): Likewise.
3230 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3232 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3235 2011-07-07 Kenichi Handa <handa@m17n.org>
3237 * character.h (unicode_category_t): New enum type.
3239 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3240 (Qchar_code_property_table): New variable.
3241 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3242 (UNIPROP_COMPRESSED_FORM_P): New macros.
3243 (char_table_ascii): Uncompress the compressed values.
3244 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3245 Uncompress the compressed values.
3246 (sub_char_table_ref_and_range): Likewise.
3247 (char_table_ref_and_range): Uncompress the compressed values.
3248 (sub_char_table_set): New arg is_uniprop. Callers changed.
3249 Uncompress the compressed values.
3250 (sub_char_table_set_range): Args changed. Callers changed.
3251 (char_table_set_range): Adjuted for the above change.
3252 (map_sub_char_table): Delete args default_val and parent. Add arg
3253 top. Give decoded values to a Lisp function.
3254 (map_char_table): Adjust for the above change. Give decoded
3255 values to a Lisp function. Gcpro more variables.
3256 (uniprop_table_uncompress)
3257 (uniprop_decode_value_run_length): New functions.
3258 (uniprop_decoder, uniprop_decoder_count): New variables.
3259 (uniprop_get_decoder, uniprop_encode_value_character)
3260 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3262 (uniprop_encoder, uniprop_encoder_count): New variables.
3263 (uniprop_get_encoder, uniprop_table)
3264 (Funicode_property_table_internal, Fget_unicode_property_internal)
3265 (Fput_unicode_property_internal): New functions.
3266 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3267 Sunicode_property_table_internal, Sget_unicode_property_internal,
3268 and Sput_unicode_property_internal. Defvar_lisp
3269 char-code-property-alist.
3271 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3272 Vunicode_category_table.
3274 * font.c (font_range): Adjust for the change of
3275 Vunicode_category_table.
3277 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3279 * m/iris4d.h: Remove file, move contents ...
3280 * s/irix6-5.h: ... here.
3282 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3284 Remove unportable assumption about struct layout (Bug#8884).
3285 * alloc.c (mark_buffer):
3286 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3287 (clone_per_buffer_values): Don't assume that
3288 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3289 This isn't true in general, and it's particularly not true
3290 if Emacs is configured with --with-wide-int.
3291 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3292 New macros, used in the buffer.c change.
3294 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3296 * xsettings.c: Use both GConf and GSettings if both are available.
3297 (store_config_changed_event): Add comment.
3298 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3299 (store_tool_bar_style_changed): New functions.
3300 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3301 (struct xsettings): Move font inside HAVE_XFT.
3302 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3303 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3304 Move inside HAVE_XFT.
3305 (something_changed_gsettingsCB): Rename from something_changedCB.
3306 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3308 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3309 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3310 (something_changed_gconfCB): Rename from something_changedCB.
3311 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3312 (parse_settings): Move check for font inside HAVE_XFT.
3313 (read_settings, apply_xft_settings): Add comment.
3314 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3315 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3316 call store_font_name_changed.
3317 (xft_settings_event): Add comment.
3318 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3319 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3320 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3321 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3322 (xsettings_initialize): Call init_gsettings last.
3323 (xsettings_get_system_font, xsettings_get_system_normal_font):
3326 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3328 Random fixes. E.g., (random) never returned negative values.
3329 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3330 subseconds part to the entropy, as that's a bit more random.
3331 Prefer signed to unsigned, since the signedness doesn't matter and
3332 in general we prefer signed. When given a limit, use a
3333 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3334 latter isn't right if USE_2_TAGS_FOR_INTS.
3335 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3336 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3338 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3340 * textprop.c (text_property_stickiness):
3341 Obey Vtext_property_default_nonsticky.
3342 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3343 * w32fns.c (syms_of_w32fns):
3344 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3346 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3348 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3349 This is more efficient than Ffile_directory_p and avoids a minor race.
3351 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3353 * buffer.c (Foverlay_put): Say what the return value is
3356 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3357 is a directory before asking whether to use the file name
3359 (barf_or_query_if_file_exists): Make the "File is a directory"
3360 error be more correct.
3362 * fns.c (Frequire): Remove the mention of the .gz files, since
3363 that's installation-specific, but keep the mention of
3364 `get-load-suffixes'.
3366 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3368 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3369 Report string overflow if the output is too long.
3371 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3373 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3374 (syms_of_gnutls): Remove duplicate DEFSYM for
3375 Qgnutls_bootprop_verify_hostname_error, an error for
3376 Qgnutls_bootprop_verify_error (which is no longer used).
3378 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3379 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3380 Also (re)move comments that are misplaced or no longer relevant.
3382 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3384 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3386 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3388 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3389 and background color parameters if they have been changed.
3391 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3393 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3395 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3397 * xsettings.c (SYSTEM_FONT): Define only when used.
3398 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3400 * keymap.c (access_keymap_1): Now static.
3402 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3404 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3405 leave any prefix arg for the up event (Bug#1586).
3407 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3409 * lread.c (syms_of_lread): Mention single symbols defined by
3410 `defvar' or `defconst' (bug#7154).
3412 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3413 (Frequire): Mention get-load-suffixes.
3415 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3417 * window.h (window): Remove clone_number slot.
3418 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3420 (make_parent_window, make_window, saved_window)
3421 (Fset_window_configuration, save_window_save): Don't deal with
3423 * buffer.c (Qclone_number): Remove declaration.
3424 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3426 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3428 Add multiple inheritance to keymaps.
3429 * keymap.c (Fmake_composed_keymap): New function.
3430 (Fset_keymap_parent): Simplify.
3431 (fix_submap_inheritance): Remove.
3432 (access_keymap_1): New function extracted from access_keymap to handle
3433 embedded parents and handle lists of maps.
3434 (access_keymap): Use it.
3435 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3436 (Fcopy_keymap): Handle embedded parents.
3437 (Fcommand_remapping, define_as_prefix): Simplify.
3438 (Fkey_binding): Simplify.
3439 (syms_of_keymap): Move minibuffer-local-completion-map,
3440 minibuffer-local-filename-completion-map,
3441 minibuffer-local-must-match-map, and
3442 minibuffer-local-filename-must-match-map to Elisp.
3443 (syms_of_keymap): Defsubr make-composed-keymap.
3444 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3445 (parse_menu_item): Trivial simplification.
3447 2011-07-01 Glenn Morris <rgm@gnu.org>
3449 * Makefile.in (SETTINGS_LIBS): Fix typo.
3451 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3453 * coding.c (Fencode_coding_string): Record the last coding system
3454 used, as the function doc string says (bug#8738).
3456 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3458 * xsettings.c (store_monospaced_changed): Take new font as arg and
3459 check for change against current_mono_font.
3460 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3461 (emacs_settings_constructor, emacs_settings_get_property)
3462 (emacs_settings_set_property, emacs_settings_class_init)
3463 (emacs_settings_init, gsettings_obj): Remove.
3464 (something_changedCB): New function for HAVE_GSETTINGS.
3465 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3466 with value as argument.
3467 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3468 g_settings_new (Bug#8967). Do not create gsettings_obj.
3469 Remove calls to g_settings_bind. Connect something_changedCB to
3472 * xgselect.c: Add defined (HAVE_GSETTINGS).
3473 (xgselect_initialize): Ditto.
3475 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3476 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3479 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3481 * eval.c (struct backtrace): Simplify and port the data structure.
3482 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3483 signed bit field, as this assumption is not portable and it makes
3484 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3485 "char debug_on_exit : 1" as this is not portable either; instead,
3486 use the portable "unsigned int debug_on_exit : 1". Remove unused
3487 member evalargs. Remove obsolete comments about cc bombing out.
3489 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3491 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3492 Let HAVE_GSETTINGS override HAVE_GCONF.
3493 (store_monospaced_changed): New function.
3494 (EMACS_SETTINGS): A new type derived from GObject to handle
3495 GSettings notifications.
3496 (emacs_settings_constructor, emacs_settings_get_property)
3497 (emacs_settings_set_property, emacs_settings_class_init):
3499 (gsettings_client, gsettings_obj): New variables.
3500 (GSETTINGS_SCHEMA): New define.
3501 (something_changedCB): Call store_monospaced_changed.
3502 (init_gsettings): New function.
3503 (xsettings_initialize): Call init_gsettings.
3504 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3507 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3510 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3512 * window.c (resize_root_window, grow_mini_window)
3513 (shrink_mini_window): Rename Qresize_root_window to
3514 Qwindow_resize_root_window and Qresize_root_window_vertically to
3515 Qwindow_resize_root_window_vertically.
3517 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3519 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3521 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3523 * makefile.w32-in: Redesign dependencies so they reflect more
3524 clearly which files are directly included by each source file,
3525 and not through other includes.
3527 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3529 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3530 (sort_overlays, overlay_strings): When an overlay's clone number
3531 matches the window's clone number process the overlay even if
3532 the overlay's window property doesn't match the current window.
3534 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3535 (Fwindow_hchild): Rename to Fwindow_left_child.
3536 (Fwindow_next): Rename to Fwindow_next_sibling.
3537 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3538 (resize_window_check): Rename to window_resize_check.
3539 (resize_window_apply): Rename to window_resize_apply.
3540 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3541 (Fdelete_other_windows_internal, resize_frame_windows)
3542 (Fsplit_window_internal, Fdelete_window_internal)
3543 (grow_mini_window, shrink_mini_window)
3544 (Fresize_mini_window_internal): Fix callers accordingly.
3546 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3548 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3549 (emacs_fixed_set_min_size): Remove.
3550 (emacs_fixed_new): Take frame as argument.
3552 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3553 (_EmacsFixedPrivate): Remove minwidth/height.
3554 Add struct frame *f.
3555 (emacs_fixed_init): Initialize priv->f.
3556 (get_parent_class, emacs_fixed_set_min_size): Remove.
3557 (emacs_fixed_new): Set priv->f to argument.
3558 (emacs_fixed_get_preferred_width)
3559 (emacs_fixed_get_preferred_height): Use min_width/height from
3560 frames size_hint to set minimum and natural (Bug#8919).
3561 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3562 and use min_width/height from frames size_hint to set
3563 min_width/height (Bug#8919).
3565 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3566 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3569 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3571 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3572 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3575 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3577 * process.c (wait_reading_process_output): Bypass select if
3578 waiting for a cell while ignoring keyboard input, and input is
3579 pending. Suggested by Jan Djärv (Bug#8869).
3581 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3583 Use gnulib's dup2 module instead of rolling our own.
3584 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3586 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3588 * dispnew.c (scrolling_window): Before scrolling, turn off a
3589 mouse-highlight in the window being scrolled.
3591 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3593 Move DEFSYM to lisp.h and use everywhere.
3595 * character.h (DEFSYM): Move declaration...
3596 * lisp.h (DEFSYM): ...here.
3602 * w32select.c: Don't include character.h.
3604 * alloc.c (syms_of_alloc):
3605 * buffer.c (syms_of_buffer):
3606 * bytecode.c (syms_of_bytecode):
3607 * callint.c (syms_of_callint):
3608 * casefiddle.c (syms_of_casefiddle):
3609 * casetab.c (init_casetab_once):
3610 * category.c (init_category_once, syms_of_category):
3611 * ccl.c (syms_of_ccl):
3612 * cmds.c (syms_of_cmds):
3613 * composite.c (syms_of_composite):
3614 * dbusbind.c (syms_of_dbusbind):
3615 * dired.c (syms_of_dired):
3616 * dispnew.c (syms_of_display):
3617 * doc.c (syms_of_doc):
3618 * editfns.c (syms_of_editfns):
3619 * emacs.c (syms_of_emacs):
3620 * eval.c (syms_of_eval):
3621 * fileio.c (syms_of_fileio):
3622 * fns.c (syms_of_fns):
3623 * frame.c (syms_of_frame):
3624 * fringe.c (syms_of_fringe):
3625 * insdel.c (syms_of_insdel):
3626 * keymap.c (syms_of_keymap):
3627 * lread.c (init_obarray, syms_of_lread):
3628 * macros.c (syms_of_macros):
3629 * msdos.c (syms_of_msdos):
3630 * print.c (syms_of_print):
3631 * process.c (syms_of_process):
3632 * search.c (syms_of_search):
3633 * sound.c (syms_of_sound):
3634 * syntax.c (init_syntax_once, syms_of_syntax):
3635 * terminal.c (syms_of_terminal):
3636 * textprop.c (syms_of_textprop):
3637 * undo.c (syms_of_undo):
3638 * w32.c (globals_of_w32):
3639 * window.c (syms_of_window):
3640 * xdisp.c (syms_of_xdisp):
3641 * xfaces.c (syms_of_xfaces):
3642 * xfns.c (syms_of_xfns):
3643 * xmenu.c (syms_of_xmenu):
3644 * xsettings.c (syms_of_xsettings):
3645 * xterm.c (syms_of_xterm): Use DEFSYM.
3647 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3649 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3651 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3653 Integer and buffer overflow fixes (Bug#8873).
3655 * print.c (printchar, strout): Check for string overflow.
3656 (PRINTPREPARE, printchar, strout):
3657 Don't set size unless allocation succeeds.
3659 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3660 for sizes. Check for string overflow more accurately.
3661 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3663 * macros.c: Integer and buffer overflow fixes.
3664 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3665 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3666 Use ptrdiff_t, not int, for sizes.
3667 Don't increment bufsize until after realloc succeeds.
3668 Check for size-calculation overflow.
3669 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3671 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3673 * lread.c: Integer overflow fixes.
3674 (read_integer): Radix is now EMACS_INT, not int,
3675 to improve quality of diagnostics for out-of-range radices.
3676 Calculate buffer size correctly for out-of-range radices.
3677 (read1): Check for integer overflow in radices, and in
3678 read-circle numbers.
3679 (read_escape): Avoid int overflow.
3680 (Fload, openp, read_buffer_size, read1)
3681 (substitute_object_recurse, read_vector, read_list, map_obarray):
3682 Use ptrdiff_t, not int, for sizes.
3683 (read1): Use EMACS_INT, not int, for sizes.
3684 Check for size overflow.
3686 * image.c (cache_image): Check for size arithmetic overflow.
3688 * lread.c: Integer overflow issues.
3689 (saved_doc_string_size, saved_doc_string_length)
3690 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3691 Now ptrdiff_t, not int.
3692 (read1): Don't assume doc string length fits in int. Check for
3693 out-of-range doc string lengths.
3694 (read_list): Don't assume file position fits in int.
3695 (read_escape): Check for hex character overflow.
3697 2011-06-22 Leo Liu <sdl.web@gmail.com>
3699 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3700 Move to minibuffer.el.
3702 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3704 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3705 The following patches are for when GLYPH_DEBUG && !XASSERT.
3706 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3707 * dispnew.c (flush_stdout):
3708 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3709 Mark as externally visible.
3710 * dispnew.c (check_window_matrix_pointers): Now static.
3711 * dispnew.c (window_to_frame_vpos):
3712 * xfns.c (unwind_create_frame):
3713 * xterm.c (x_check_font): Remove unused local.
3714 * scroll.c (CHECK_BOUNDS):
3715 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3716 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3717 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3718 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3719 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3721 (debug_method_add): Use va_list and vsprintf rather than relying
3722 on undefined behavior with wrong number of arguments.
3723 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3724 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3725 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3726 since we're not interested in debugging glyphs with old libraries.
3727 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3728 GCC 4.6.0's static checking.
3730 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3732 Integer overflow and signedness fixes (Bug#8873).
3733 A few related buffer overrun fixes, too.
3735 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3737 * dispextern.h (struct face.stipple):
3738 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3739 (x_bitmap_mask, x_allocate_bitmap_record)
3740 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3741 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3742 (x_create_bitmap_from_xpm_data):
3743 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3744 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3746 * xfaces.c (load_pixmap):
3747 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3748 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3749 (.bitmaps_last, struct x_output.icon_bitmap):
3750 Use ptrdiff_t, not int, for bitmap indexes.
3751 (x_allocate_bitmap_record): Check for size overflow.
3752 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3754 Use ptrdiff_t, not int, for overlay counts.
3755 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3756 * editfns.c (overlays_around, get_pos_property):
3757 * textprop.c (get_char_property_and_overlay):
3758 * xdisp.c (next_overlay_change, note_mouse_highlight):
3759 * xfaces.c (face_at_buffer_position):
3760 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3761 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3762 (Fnext_overlay_change, Fprevious_overlay_change)
3763 (mouse_face_overlay_overlaps, Foverlays_in):
3764 Use ptrdiff_t, not int, for sizes.
3765 (overlays_at, overlays_in): Check for size-calculation overflow.
3767 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3769 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3770 (x_session_initialize): Do not assume string length fits in int.
3772 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3773 This is unlikely, but can occur if DPI is outlandish.
3775 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3776 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3778 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3779 * xrdb.c (magic_file_p, search_magic_path):
3780 Omit last arg SUFFIX; it was always 0. All callers changed.
3781 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3783 * xfont.c (xfont_match): Avoid need for strlen.
3785 * xfns.c: Don't assume strlen fits in int.
3786 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3788 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3789 not unsigned long, as we prefer signed integers. All callers changed.
3790 Detect integer overflow in repeat count.
3791 (message_dolog): Don't assume print length fits in 39 bytes.
3792 (display_mode_element): Don't assume strlen fits in int.
3794 * termcap.c: Don't assume sizes fit in int and never overflow.
3795 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3796 (gobble_line): Check for size-calculation overflow.
3798 * minibuf.c (Fread_buffer):
3799 * lread.c (intern, intern_c_string):
3800 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3801 Don't assume string length fits in int.
3803 * keyboard.c (parse_tool_bar_item):
3804 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3806 * font.c: Don't assume string length fits in int.
3807 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3808 Use ptrdiff_t, not int.
3809 (font_intern_prop): Don't assume string length fits in int.
3810 Don't assume integer property fits in fixnum.
3811 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3813 * filelock.c: Fix some buffer overrun and integer overflow issues.
3814 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3815 Reformulate so as not to need the command string.
3816 Invoke gzip -cd rather than gunzip, as it's more portable.
3817 (lock_info_type, lock_file_1, lock_file):
3818 Don't assume pid_t and time_t fit in unsigned long.
3819 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3820 (current_lock_owner): Prefer signed type for sizes.
3821 Use memcpy, not strncpy, where memcpy is what is really wanted.
3822 Don't assume (via atoi) that time_t and pid_t fit in int.
3823 Check for time_t and/or pid_t out of range, e.g., via a network share.
3824 Don't alloca where an auto var works fine.
3826 * fileio.c: Fix some integer overflow issues.
3827 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3828 Don't assume string length fits in int.
3829 (directory_file_name): Don't assume string length fits in long.
3830 (make_temp_name): Don't assume pid fits in int, or that its print
3831 length is less than 20.
3833 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3835 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3837 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3839 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3840 We prefer signed integers, even for size calculations.
3842 * emacs.c: Don't assume string length fits in 'int'.
3843 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3844 (main): Don't invoke strlen when not needed.
3846 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3847 (XD_DEBUG_MESSAGE): Don't waste a byte.
3849 * callproc.c (getenv_internal_1, getenv_internal)
3851 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3853 * lread.c (invalid_syntax): Omit length argument.
3854 All uses changed. This doesn't fix a bug, but it simplifies the
3855 code away from its former Hollerith-constant appearance, and it's
3856 one less 'int' to worry about when looking at integer-overflow issues.
3857 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3859 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3860 This didn't break anything, but it didn't help either.
3861 It's confusing to put a bogus integer in a place where the actual
3862 value does not matter.
3863 (LIST_END_P): Remove unused macro and its bogus comment.
3864 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3866 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3867 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3869 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3870 We prefer signed types, and the value cannot exceed the EMACS_INT
3871 range anyway (because otherwise the length would not be representable).
3872 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3873 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3874 This avoids a GCC warning when WIDE_EMACS_INT.
3876 * indent.c (sane_tab_width): New function.
3877 (current_column, scan_for_column, Findent_to, position_indentation)
3878 (compute_motion): Use it. This is just for clarity.
3879 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3881 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3883 * lisp.h (lint_assume): New macro.
3884 * composite.c (composition_gstring_put_cache):
3885 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3887 * editfns.c, insdel.c:
3888 Omit unnecessary forward decls, to simplify future changes.
3890 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3892 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3894 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3895 Use much-faster test for byte-length change.
3896 Don't assume string byte-length fits in 'int'.
3897 Check that character arg fits in 'int'.
3898 (mapcar1): Declare byte as byte, for clarity.
3900 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3902 * fns.c (concat): Catch string overflow earlier.
3903 Do not rely on integer wraparound.
3905 * dispextern.h (struct it.overlay_strings_charpos)
3906 (struct it.selective): Now EMACS_INT, not int.
3907 * xdisp.c (forward_to_next_line_start)
3908 (back_to_previous_visible_line_start)
3909 (reseat_at_next_visible_line_start, next_element_from_buffer):
3910 Don't arbitrarily truncate the value of 'selective' to int.
3912 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3914 * composite.c: Don't truncate sizes to 'int'.
3915 (composition_gstring_p, composition_reseat_it)
3916 (composition_adjust_point): Use EMACS_INT, not int.
3917 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3918 not EMACS_UINT, for indexes.
3920 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3922 * buffer.c: Include <verify.h>.
3923 (struct sortvec.priority, struct sortstr.priority):
3924 Now EMACS_INT, not int.
3925 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3926 (struct sortstr.size, record_overlay_string)
3927 (struct sortstrlist.size, struct sortlist.used):
3928 Don't truncate size to int.
3929 (record_overlay_string): Check for size-calculation overflow.
3930 (init_buffer_once): Check at compile-time, not run-time.
3932 2011-06-22 Jim Meyering <meyering@redhat.com>
3934 Don't leak an XBM-image-sized buffer
3935 * image.c (xbm_load): Free the image buffer after using it.
3937 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3940 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3941 that Sun C diagnosed.
3942 * fns.c (secure_hash): Fix pointer signedness issue.
3943 * intervals.c (static_offset_intervals): New function.
3944 (offset_intervals): Use it.
3946 2011-06-21 Leo Liu <sdl.web@gmail.com>
3949 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3952 * fns.c (secure_hash): Rename from crypto_hash_function and change
3953 the first arg to accept symbols.
3954 (Fsecure_hash): New primitive.
3955 (syms_of_fns): New symbols.
3957 2011-06-20 Deniz Dogan <deniz@dogan.se>
3959 * process.c (Fset_process_buffer): Clarify return value in
3962 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3964 * dispnew.c (add_window_display_history): Use BVAR.
3966 * xdisp.c (debug_method_add): Use BVAR.
3967 (check_window_end, dump_glyph_matrix, dump_glyph)
3968 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3970 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3973 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3974 check till after the cache is created in init_frame_faces.
3976 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3978 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3980 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3982 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3983 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3984 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3986 Improve buffer-overflow checking (Bug#8873).
3987 * fileio.c (Finsert_file_contents):
3988 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3989 Remove the old (too-loose) buffer overflow checks.
3990 They weren't needed, since make_gap checks for buffer overflow.
3991 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3992 The old code merely checked for Emacs fixnum overflow, and relied
3993 on undefined (wraparound) behavior. The new code avoids undefined
3994 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3996 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3997 Tune. Don't use wider integers than needed. Don't use alloca.
3998 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4000 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4002 * insdel.c, lisp.h (buffer_overflow): New function.
4003 (insert_from_buffer_1, replace_range, replace_range_2):
4004 * insdel.c (make_gap_larger):
4005 * editfns.c (Finsert_char):
4006 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4008 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4010 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4012 Integer overflow and signedness fixes (Bug#8873).
4014 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4015 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4017 * fileio.c: Don't assume EMACS_INT fits in off_t.
4018 (emacs_lseek): New static function.
4019 (Finsert_file_contents, Fwrite_region): Use it.
4020 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4022 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4024 * fns.c: Don't overflow int when computing a list length.
4025 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4026 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4027 truncation on 64-bit hosts. Check for QUIT every
4028 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4029 faster and is responsive enough.
4030 (Flength): Report an error instead of overflowing an integer.
4031 (Fsafe_length): Return a float if the value is not representable
4032 as a fixnum. This shouldn't happen except in contrived situations.
4033 (Fnthcdr, Fsort): Don't assume list length fits in int.
4034 (Fcopy_sequence): Don't assume vector length fits in int.
4036 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4037 (header_size, word_size): New constants.
4038 (allocate_vectorlike): Don't check size overflow here.
4039 (allocate_vector): Check it here instead, since this is the only
4040 caller of allocate_vectorlike that could cause overflow.
4041 Check that the new vector's length is representable as a fixnum.
4043 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4044 The previous code was bogus. For example, next_almost_prime (32)
4045 returned 39, which is undesirable as it is a multiple of 3; and
4046 next_almost_prime (24) returned 25, which is a multiple of 5 so
4047 why was the code bothering to check for multiples of 7?
4049 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4051 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4053 Variadic C functions now count arguments with ptrdiff_t.
4054 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4055 Back then I didn't know that the Emacs coding style prefers signed int.
4056 Also, in the meantime I found a few more instances where arguments
4057 were being counted with int, which may truncate counts on 64-bit
4058 machines, or EMACS_INT, which may be unnecessarily wide.
4059 * lisp.h (struct Lisp_Subr.function.aMANY)
4060 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4061 Arg counts are now ptrdiff_t, not size_t.
4062 All variadic functions and their callers changed accordingly.
4063 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4064 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4065 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4066 * callint.c (Fcall_interactively): Check arg count for overflow,
4067 to avoid potential buffer overrun. Use signed char, not 'int',
4068 for 'varies' array, so that we needn't bother to check its size
4069 calculation for overflow.
4070 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4071 * eval.c (apply_lambda):
4072 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4073 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4074 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4076 * callint.c (Fcall_interactively): Don't use index var as event count.
4078 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4079 * mem-limits.h (SIZE): Remove; no longer used.
4081 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4083 Remove unnecessary casts.
4084 * xterm.c (x_term_init):
4085 * xfns.c (x_set_border_pixel):
4086 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4087 These aren't needed now that we assume ANSI C.
4089 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4090 It's more likely to cause problems (due to unsigned overflow)
4093 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4095 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4097 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4099 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4101 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4103 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4105 GLYPH_CODE_FACE returns EMACS_INT, not int.
4106 * dispextern.h (merge_faces):
4107 * xfaces.c (merge_faces):
4108 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4109 Don't assume EMACS_INT fits in int.
4111 * character.h (CHAR_VALID_P): Remove unused parameter.
4112 * fontset.c, lisp.h, xdisp.c: All uses changed.
4114 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4116 * fns.c (concat): Minor tuning based on overflow analysis.
4117 This doesn't fix any bugs. Use int to hold character, instead
4118 of constantly refetching from Emacs object. Use XFASTINT, not
4119 XINT, for value known to be a character. Don't bother comparing
4120 a single byte to 0400, as it's always less.
4122 * floatfns.c (Fexpt):
4123 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4125 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4128 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4130 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4131 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4132 incorrectly succeed when S was a string, because 4294967386 was
4133 truncated before it was used.
4135 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4136 Otherwise, an out-of-range integer could cause undefined behavior
4139 * composite.c: Use int, not EMACS_INT, for characters.
4140 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4141 EMACS_INT, for values that are known to be in character range.
4142 This doesn't fix any bugs but is the usual style inside Emacs and
4143 may generate better code on 32-bit machines.
4145 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4146 This is for reasons similar to the recent CHAR_STRING fix.
4147 * charset.c (Fencode_char): Check that character arg is actually
4148 a character. Pass an int to ENCODE_CHAR.
4149 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4150 wider than 'int', as a compile-time check to prevent future regressions
4153 * character.c (char_string): Remove unnecessary casts.
4155 Make sure a 64-bit char is never passed to CHAR_STRING.
4156 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4157 by silently ignoring the top 32 bits, allowing some values
4158 that were far too large to be valid characters.
4159 * character.h: Include <verify.h>.
4160 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4161 arguments are no wider than unsigned, as a compile-time check
4162 to prevent future regressions in this area.
4164 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4165 (Fsubst_char_in_region):
4167 * xdisp.c (decode_mode_spec_coding):
4168 Adjust to CHAR_STRING's new requirement.
4169 * editfns.c (Finsert_char, Fsubst_char_in_region):
4170 * fns.c (concat): Check that character args are actually
4171 characters. Without this test, these functions did the wrong
4172 thing with wildly out-of-range values on 64-bit hosts.
4174 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4175 These casts should not be needed on 32-bit hosts, either.
4176 * keyboard.c (read_char):
4177 * lread.c (Fload): Remove casts to unsigned.
4179 * lisp.h (UNSIGNED_CMP): New macro.
4180 This fixes comparison bugs on 64-bit hosts.
4181 (ASCII_CHAR_P): Use it.
4182 * casefiddle.c (casify_object):
4183 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4184 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4185 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4186 * dispextern.h (FACE_FROM_ID):
4187 * keyboard.c (read_char): Use UNSIGNED_CMP.
4189 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4190 not to EMACS_INT, to avoid GCC warning.
4192 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4194 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4195 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4196 isn't needed on 32-bit machines.
4198 * buffer.c (Fgenerate_new_buffer_name):
4199 Use EMACS_INT for count, not int.
4200 (advance_to_char_boundary): Return EMACS_INT, not int.
4202 * data.c (Qcompiled_function): Now static.
4204 * window.c (window_body_lines): Now static.
4206 * image.c (gif_load): Rename local to avoid shadowing.
4208 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4209 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4210 * alloc.c (make_save_value): Integer argument is now of type
4212 (mark_object): Use ptrdiff_t, not int.
4213 * lisp.h (pD): New macro.
4214 * print.c (print_object): Use it.
4216 * alloc.c: Use EMACS_INT, not int, to count objects.
4217 (total_conses, total_markers, total_symbols, total_vector_size)
4218 (total_free_conses, total_free_markers, total_free_symbols)
4219 (total_free_floats, total_floats, total_free_intervals)
4220 (total_intervals, total_strings, total_free_strings):
4221 Now EMACS_INT, not int. All uses changed.
4222 (Fgarbage_collect): Compute overall total using a double, so that
4223 integer overflow is less likely to be a problem. Check for overflow
4224 when converting back to an integer.
4225 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4226 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4227 These were 'int' variables that could overflow on 64-bit hosts;
4228 they were never used, so remove them instead of repairing them.
4229 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4230 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4231 Previously, this ceilinged at INT_MAX, but that doesn't work on
4233 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4235 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4236 (allocate_vectorlike): Check for ptrdiff_t overflow.
4237 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4238 when a (possibly-narrower) signed value would do just as well.
4239 We prefer using signed arithmetic, to avoid comparison confusion.
4241 * alloc.c: Catch some string size overflows that we were missing.
4242 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4243 for convenience in STRING_BYTES_MAX.
4244 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4245 The definition here is exact; the one in lisp.h was approximate.
4246 (allocate_string_data): Check for string overflow. This catches
4247 some instances we weren't catching before. Also, it catches
4248 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4249 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4250 and ptrdiff_t and EMACS_INT are both 64 bits.
4252 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4253 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4254 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4256 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4258 * alloc.c (Fmake_string): Check for out-of-range init.
4260 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4262 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4264 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4266 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4267 xg_get_default_scrollbar_width.
4269 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4270 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4271 (style_changed_cb): Call update_theme_scrollbar_width and call
4272 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4273 all frames (Bug#8505).
4274 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4275 Call gtk_window_set_resizable if HAVE_GTK3.
4276 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4277 and height if HAVE_GTK3 (Bug#8505).
4278 (scroll_bar_width_for_theme): New variable.
4279 (update_theme_scrollbar_width): New function.
4280 (xg_get_default_scrollbar_width): Move code to
4281 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4282 (xg_initialize): Call update_theme_scrollbar_width.
4284 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4286 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4288 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4290 * frame.c (make_frame): Call other_buffer_safely instead of
4293 * window.c (temp_output_buffer_show): Call display_buffer with
4294 second argument Vtemp_buffer_show_specifiers and reset latter
4295 immediately after the call.
4296 (Vtemp_buffer_show_specifiers): New variable.
4297 (auto_window_vscroll_p, next_screen_context_lines)
4298 (Vscroll_preserve_screen_position): Remove leading asterisks from
4301 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4303 Fix minor problems found by GCC 4.6.0 static checking.
4304 * buffer.c (Qclone_number): Remove for now, as it's unused.
4305 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4306 (record_buffer): Remove unused local.
4307 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4308 (set_frame_buffer_list): Remove; unused.
4309 * frame.h (other_visible_frames): Remove decl.
4310 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4311 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4312 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4314 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4315 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4316 Define only if HAVE_GPM.
4317 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4318 (update_hints_inhibit): Remove; never set. All uses removed.
4319 * widgetprv.h (emacsFrameClassRec): Remove decl.
4320 * window.c (delete_deletable_window): Now returns void, since it
4321 wasn't returning anything.
4322 (compare_window_configurations): Remove unused locals.
4323 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4324 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4325 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4326 the same widths as pointers. This follows up on the 2011-05-06 patch.
4327 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4328 * xterm.h: Likewise.
4329 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4331 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4333 * makefile.w32-in: Update dependencies.
4334 (LISP_H): Add lib/intprops.h.
4336 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4338 * image.c (gif_load): Add animation frame delay to the metadata.
4339 (syms_of_image): Use DEFSYM. New symbol `delay'.
4341 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4343 * window.c (delete_deletable_window): Re-add.
4344 (Fset_window_configuration): Rewrite to handle dead buffers and
4345 consequently deletable windows.
4346 (window_tree, Fwindow_tree): Remove. Supply functionality in
4348 (compare_window_configurations): Simplify code.
4350 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4352 * image.c (imagemagick_load_image): Fix type mismatch.
4353 (Fimagemagick_types): Likewise.
4355 * window.h (replace_buffer_in_windows): Declare.
4357 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4359 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4360 Qclone_number. Remove external declaration of Qdelete_window.
4361 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4363 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4364 Run Qbuffer_list_update_hook if allowed.
4365 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4366 buffer list implementation.
4367 (other_buffer_safely): New function.
4368 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4369 calls to replace_buffer_in_windows and
4370 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4372 (record_buffer): Inhibit quitting and rewrite using quittable
4373 functions. Run Qbuffer_list_update_hook if allowed.
4374 (Frecord_buffer, Funrecord_buffer): New functions.
4375 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4376 Move switch-to-buffer to window.el.
4377 (bury-buffer): Move to window.el.
4378 (Vbuffer_list_update_hook): New variable.
4380 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4383 * window.h (resize_frame_windows): Move up in code.
4384 (Fwindow_frame): Remove EXFUN.
4385 (replace_buffer_in_all_windows): Remove prototype.
4386 (replace_buffer_in_windows_safely): Add prototype.
4388 * window.c: Declare Qdelete_window static again. Move down
4389 declaration of select_count.
4390 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4391 (Fother_window): Move to window.el.
4392 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4393 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4394 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4396 (replace_buffer_in_windows): Implement by calling
4397 Qreplace_buffer_in_windows.
4398 (replace_buffer_in_all_windows): Remove with some functionality
4399 moved into replace_buffer_in_windows_safely.
4400 (replace_buffer_in_windows_safely): New function.
4401 (select_window_norecord, select_frame_norecord): Move in front
4402 of run_window_configuration_change_hook. Remove now obsolete
4404 (Fset_window_buffer): Rewrite doc-string.
4405 Call Qrecord_window_buffer.
4406 (keys_of_window): Move binding for other-window to window.el.
4408 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4410 * dispextern.h (struct image): Replace data member, whose int_val
4411 and ptr_val fields were not used by anything, with a single
4414 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4415 (gif_clear_image, gif_load, imagemagick_load_image)
4416 (gs_clear_image, gs_load): Callers changed.
4418 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4420 * buffer.h: Include <time.h>, for time_t.
4421 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4423 Fix minor problems found by static checking.
4425 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4427 Make identifiers static if they are not used in other modules.
4428 * data.c (Qcompiled_function, Qframe, Qvector):
4429 * image.c (QimageMagick, Qsvg):
4430 * minibuf.c (Qmetadata):
4431 * window.c (resize_window_check, resize_root_window): Now static.
4432 * window.h (resize_window_check, resize_root_window): Remove decls.
4434 * window.c (window_deletion_count, delete_deletable_window):
4436 (window_body_lines): Now static.
4437 (Fdelete_other_windows_internal): Mark vars as initialized.
4438 Make sure 'resize_failed' is initialized.
4439 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4440 (resize_window_apply): Remove unused local.
4441 * window.h (delete_deletable_window): Remove decl.
4443 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4444 (imagemagick_load_image): Fix pointer signedness problem by changing
4445 last arg from unsigned char * to char *. All uses changed.
4446 Also, fix a local for similar reasons.
4447 Remove unused locals. Remove locals to avoid shadowing.
4448 (fn_rsvg_handle_free): Remove; unused.
4449 (svg_load, svg_load_image): Fix pointer signedness problem.
4450 (imagemagick_load_image): Don't use garbage pointer image_wand.
4452 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4454 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4456 * image.c (gif_load): Fix omitted cast error introduced by
4459 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4461 * window.h (resize_proportionally, orig_total_lines)
4462 (orig_top_line): Remove from window structure.
4463 (set_window_height, set_window_width, change_window_heights)
4464 (Fdelete_window): Remove prototypes.
4465 (resize_frame_windows): Remove duplicate declaration.
4467 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4469 * window.h (resize_frame_windows, resize_window_check)
4470 (delete_deletable_window, resize_root_window)
4471 (resize_frame_windows): Declare prototypes.
4473 * window.c (resize_window_apply): Make definition be "static" to
4474 match the prototype.
4476 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4478 * window.c: Remove declarations of Qwindow_size_fixed,
4479 window_min_size_1, window_min_size_2, window_min_size,
4480 size_window, window_fixed_size_p, enlarge_window, delete_window.
4481 Remove static from declaration of Qdelete_window, it's
4482 temporarily needed by Fbury_buffer.
4483 (replace_window): Don't assign orig_top_line and
4485 (Fdelete_window, delete_window): Remove. Window deletion is
4486 handled by window.el.
4487 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4488 Replace Fdelete_window calls with calls to Qdelete_window.
4489 (Fdelete_other_windows): Remove. Deleting other windows is
4490 handled by window.el.
4491 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4492 handled in window.el.
4493 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4494 Window minimum sizes are handled in window.el.
4495 (shrink_windows, size_window, set_window_height)
4496 (set_window_width, change_window_heights, window_height)
4497 (window_width, CURBEG, CURSIZE, enlarge_window)
4498 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4499 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4500 handled in window.el.
4501 (make_dummy_parent): Rename to make_parent_window and give it a
4502 second argument horflag.
4503 (make_window): Don't set resize_proportionally any more.
4504 (Fsplit_window): Remove. Windows are split in window.el.
4505 (save_restore_action, save_restore_orig_size)
4506 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4507 Resize mini windows in window.el.
4508 (grow_mini_window, shrink_mini_window): Implement by calling
4509 Qresize_root_window_vertically, resize_window_check and
4510 resize_window_apply.
4511 (saved_window, Fset_window_configuration, save_window_save):
4512 Do not handle orig_top_line, orig_total_lines, and
4513 resize_proportionally.
4514 (window_min_height, window_min_width): Move to window.el.
4515 (keys_of_window): Move bindings for delete-other-windows,
4516 split-window, delete-window and enlarge-window to window.el.
4518 * buffer.c: Temporarily extern Qdelete_window.
4519 (Fbury_buffer): Temporarily call Qdelete_window instead of
4520 Fdelete_window (Fbury_buffer will move to window.el soon).
4522 * frame.c (set_menu_bar_lines_1): Remove code handling
4523 orig_top_line and orig_total_lines.
4525 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4526 set_window_height but set heights directly.
4527 (change_frame_size_1): Use resize_frame_windows.
4529 * xdisp.c (init_xdisp): Don't use set_window_height but set
4532 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4533 Use resize_frame_windows instead of change_window_heights and run
4534 run_window_configuration_change_hook.
4536 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4537 instead of change_window_heights and run
4538 run_window_configuration_change_hook.
4540 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4542 * window.c (replace_window): Rename second argument REPLACEMENT to
4543 NEW. New third argument SETFLAG. Rewrite.
4544 (delete_window, make_dummy_parent): Call replace_window with
4546 (window_list_1): Move down in code.
4547 (run_window_configuration_change_hook): Move set_buffer part
4548 before select_frame_norecord part in order to unwind correctly.
4549 Rename count1 to count.
4550 (recombine_windows, delete_deletable_window, resize_root_window)
4551 (Fdelete_other_windows_internal)
4552 (Frun_window_configuration_change_hook, make_parent_window)
4553 (resize_window_check, resize_window_apply, Fresize_window_apply)
4554 (resize_frame_windows, Fsplit_window_internal)
4555 (Fdelete_window_internal, Fresize_mini_window_internal):
4557 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4559 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4561 * window.h (window): Add some new members to window structure -
4562 normal_lines, normal_cols, new_total, new_normal, clone_number,
4563 splits, nest, prev_buffers, next_buffers.
4564 (WINDOW_TOTAL_SIZE): Move here from window.c.
4565 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4567 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4569 (make_dummy_parent): Set new members of windows structure.
4570 (make_window): Move down in code. Handle new members of window
4572 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4573 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4574 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4575 (Fset_window_prev_buffers, Fwindow_next_buffers)
4576 (Fset_window_next_buffers, Fset_window_clone_number):
4578 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4579 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4581 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4582 Argument WINDOW can be now internal window too.
4583 (Fwindow_use_time): Move up in code.
4584 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4586 (Fset_window_configuration, saved_window)
4587 (Fcurrent_window_configuration, save_window_save): Handle new
4588 members of window structure.
4589 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4590 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4591 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4592 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4593 Qget_mru_window, Qresize_root_window,
4594 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4595 Qauto_buffer_name; staticpro them.
4597 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4599 * window.c (Fwindow_total_size, Fwindow_left_column)
4600 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4601 (Fwindow_list_1): New functions.
4602 (window_box_text_cols): Replace with window_body_cols.
4603 (Fwindow_width, Fscroll_left, Fscroll_right):
4604 Use window_body_cols instead of window_box_text_cols.
4605 (delete_window, Fset_window_configuration):
4606 Call delete_all_subwindows with window as argument.
4607 (delete_all_subwindows): Take a window as argument and not a
4609 (window_loop): Remove handling of GET_LRU_WINDOW and
4611 (Fget_lru_window, Fget_largest_window): Move to window.el.
4613 * window.h: Extern window_body_cols instead of
4614 window_box_text_cols. delete_all_subwindows now takes a
4615 Lisp_Object as argument.
4617 * indent.c (compute_motion, Fcompute_motion):
4618 Use window_body_cols instead of window_box_text_cols.
4620 * frame.c (delete_frame): Call delete_all_subwindows with root
4623 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4625 * fns.c (Fputhash): Document return value.
4627 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4629 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4631 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4633 Cons<->int and similar integer overflow fixes (Bug#8794).
4635 Check for overflow when converting integer to cons and back.
4636 * charset.c (Fdefine_charset_internal, Fdecode_char):
4637 Use cons_to_unsigned to catch overflow.
4638 (Fencode_char): Use INTEGER_TO_CONS.
4639 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4640 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4641 * data.c (long_to_cons, cons_to_long): Remove.
4642 (cons_to_unsigned, cons_to_signed): New functions.
4643 These signal an error for invalid or out-of-range values.
4644 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4645 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4646 * font.c (Ffont_variation_glyphs):
4647 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4648 * lisp.h: Include <intprops.h>.
4649 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4650 (cons_to_signed, cons_to_unsigned): New decls.
4651 (long_to_cons, cons_to_long): Remove decls.
4652 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4653 (Fprimitive_undo): Use CONS_TO_INTEGER.
4654 * xfns.c (Fx_window_property): Likewise.
4655 * xselect.c: Include <limits.h>.
4656 (x_own_selection, selection_data_to_lisp_data):
4657 Use INTEGER_TO_CONS.
4658 (x_handle_selection_request, x_handle_selection_clear)
4659 (x_get_foreign_selection, Fx_disown_selection_internal)
4660 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4661 (lisp_data_to_selection_data): Use cons_to_unsigned.
4662 (x_fill_property_data): Use cons_to_signed.
4663 Report values out of range.
4665 Check for buffer and string overflow more precisely.
4666 * buffer.h (BUF_BYTES_MAX): New macro.
4667 * lisp.h (STRING_BYTES_MAX): New macro.
4668 * alloc.c (Fmake_string):
4669 * character.c (string_escape_byte8):
4670 * coding.c (coding_alloc_by_realloc):
4671 * doprnt.c (doprnt):
4672 * editfns.c (Fformat):
4674 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4675 since they may not be the same number.
4676 * editfns.c (Finsert_char):
4677 * fileio.c (Finsert_file_contents):
4678 Likewise for BUF_BYTES_MAX.
4680 * image.c: Use ptrdiff_t, not int, for sizes.
4681 (slurp_file): Switch from int to ptrdiff_t.
4683 (slurp_file): Check that file size fits in both size_t (for
4684 malloc) and ptrdiff_t (for sanity and safety).
4686 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4687 if b->modtime has its maximal value.
4689 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4691 Don't assume time_t can fit into int.
4692 * buffer.h (struct buffer.modtime): Now time_t, not int.
4693 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4694 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4696 Minor fixes for signed vs unsigned integers.
4697 * character.h (MAYBE_UNIFY_CHAR):
4698 * charset.c (maybe_unify_char):
4699 * keyboard.c (read_char, reorder_modifiers):
4700 XINT -> XFASTINT, since the integer must be nonnegative.
4701 * ftfont.c (ftfont_spec_pattern):
4702 * keymap.c (access_keymap, silly_event_symbol_error):
4703 XUINT -> XFASTINT, since the integer must be nonnegative.
4704 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4705 since it makes no difference and we prefer signed.
4706 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4707 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4710 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4712 * window.h (Fwindow_frame): Declare.
4714 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4716 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4717 (SPARE_MEMORY): Always define.
4718 (LARGE_REQUEST): Remove.
4719 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4721 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4723 * lisp.h: Move EXFUNS for Fframe_root_window,
4724 Fframe_first_window and Fset_frame_selected_window to window.h.
4726 * window.h: Move EXFUNS for Fframe_root_window,
4727 Fframe_first_window and Fset_frame_selected_window here from
4730 * frame.c (Fwindow_frame, Fframe_first_window)
4731 (Fframe_root_window, Fframe_selected_window)
4732 (Fset_frame_selected_window): Move to window.c.
4733 (Factive_minibuffer_window): Move to minibuf.c.
4734 (Fother_visible_frames_p): New function.
4736 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4738 * window.c (decode_window, decode_any_window): Move up in code.
4739 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4740 (inhibit_frame_unsplittable): Remove unused variable.
4741 (Fwindow_buffer): Move up and rewrite doc-string.
4742 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4743 (Fwindow_prev): New functions.
4744 (Fwindow_frame): Move here from frame.c. Accept any window as
4746 (Fframe_root_window, Fframe_first_window)
4747 (Fframe_selected_window): Move here from frame.c. Accept frame
4748 or arbitrary window as argument. Update doc-strings.
4749 (Fminibuffer_window): Move up in code.
4750 (Fwindow_minibuffer_p): Move up in code and simplify.
4751 (Fset_frame_selected_window): Move here from frame.c.
4753 (Fselected_window, select_window, Fselect_window): Move up in
4754 code. Minor doc-string fixes.
4756 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4758 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4759 Do not assume that spare memory exists; that assumption is valid
4760 only if SYSTEM_MALLOC.
4761 (LARGE_REQUEST): New macro, so that the issue of large requests
4762 is separated from the issue of spare memory.
4764 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4766 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4769 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4771 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4774 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4776 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4778 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4780 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4781 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4783 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4785 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4787 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4789 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4790 (x_clipboard_manager_save): Add return value.
4791 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4793 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4794 Obey Vx_select_enable_clipboard_manager. Catch errors in
4795 x_clipboard_manager_save (Bug#8779).
4796 (Vx_select_enable_clipboard_manager): New variable.
4797 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4799 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4801 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4803 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4805 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4806 in the current matrix if keep_current_p is non-zero.
4808 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4810 * bidi.c (bidi_level_of_next_char): Fix last change.
4812 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4814 Support bidi reordering of text covered by display properties.
4816 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4817 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4818 (bidi_cache_search, bidi_cache_iterator_state)
4819 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4820 (bidi_level_of_next_char, bidi_move_to_visually_next):
4821 Support character positions inside a run of characters covered by a
4823 (bidi_paragraph_init, bidi_resolve_explicit_1)
4824 (bidi_level_of_next_char): Call bidi_fetch_char and
4825 bidi_fetch_char_advance instead of FETCH_CHAR and
4827 (bidi_init_it): Initialize new members.
4828 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4830 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4831 instead of using explicit *_CHAR codes.
4832 (bidi_resolve_explicit, bidi_resolve_weak):
4833 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4834 bidirectional text is supported only in multibyte buffers.
4835 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4836 it to initialize the frame_window_p member of struct bidi_it.
4837 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4838 (bidi_resolve_explicit, bidi_resolve_weak)
4839 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4840 bidi_it->nchars is non-positive.
4841 (bidi_level_of_next_char): Don't try to lookup the cache for the
4842 next/previous character if nothing is cached there yet, or if we
4843 were just reseat()'ed to a new position.
4845 * xdisp.c (set_cursor_from_row): Set start and stop points
4846 according to the row's direction when priming the loop that looks
4847 for the glyph on which to display cursor.
4848 (single_display_spec_intangible_p): Function deleted.
4849 (display_prop_intangible_p): Reimplement to call
4850 handle_display_spec instead of single_display_spec_intangible_p.
4851 Accept 3 additional arguments needed by handle_display_spec.
4852 This fixes incorrect cursor motion across display property with complex
4853 values: lists, `(when COND...)' forms, etc.
4854 (single_display_spec_string_p): Support property values that are
4855 lists with the argument STRING its top-level element.
4856 (display_prop_string_p): Fix the condition for processing a
4857 property that is a list to be consistent with handle_display_spec.
4858 (handle_display_spec): New function, refactored from the
4859 last portion of handle_display_prop.
4860 (compute_display_string_pos): Accept additional argument
4861 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4862 value of a `display' property is a "replacing spec".
4863 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4864 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4865 the display property, but just return a value indicating whether
4866 the display property will replace the characters it covers.
4867 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4868 frame_window_p members of struct bidi_it.
4869 (compute_display_string_pos, compute_display_string_end):
4871 (push_it): Accept second argument POSITION, where pop_it should
4872 jump to continue iteration.
4873 (reseat_1): Initialize bidi_it.disp_pos.
4875 * keyboard.c (adjust_point_for_property): Adjust the call to
4876 display_prop_intangible_p to its new signature.
4878 * dispextern.h (struct bidi_it): New member frame_window_p.
4879 (bidi_init_it): Update prototypes.
4880 (display_prop_intangible_p): Update prototype.
4881 (compute_display_string_pos, compute_display_string_end):
4883 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4886 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4888 Malloc failure behavior now depends on size of allocation.
4889 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4890 * lisp.h: Change signatures accordingly.
4891 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4892 All callers changed. (Bug#8762)
4894 * gnutls.c: Use Emacs's memory allocators.
4895 Without this change, the gnutls library would invoke malloc etc.
4896 directly, which causes problems on non-SYNC_INPUT hosts, and which
4897 runs afoul of improving memory_full behavior. (Bug#8761)
4898 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4899 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4900 xfree instead of the default malloc, realloc, free.
4901 (Fgnutls_boot): No need to check for memory allocation failure,
4902 since xmalloc does that for us.
4904 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4905 * category.c (hash_get_category_set):
4906 * ccl.c (ccl_driver):
4907 * charset.c (Fdefine_charset_internal):
4908 * charset.h (struct charset.hash_index):
4909 * composite.c (get_composition_id, gstring_lookup_cache)
4910 (composition_gstring_put_cache):
4911 * composite.h (struct composition.hash_index):
4912 * dispextern.h (struct image.hash):
4913 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4914 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4915 (hashfn_equal, hashfn_user_defined, make_hash_table)
4916 (maybe_resize_hash_table, hash_lookup, hash_put)
4917 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4918 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4919 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4920 * image.c (make_image, search_image_cache, lookup_image)
4921 (xpm_put_color_table_h):
4922 * lisp.h (struct Lisp_Hash_Table):
4923 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4924 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4925 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4926 * alloc.c (allocate_vectorlike):
4927 Check for overflow in vector size calculations.
4928 * ccl.c (ccl_driver):
4929 Check for overflow when converting EMACS_INT to int.
4930 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4931 need to be updated by these changes.
4932 * fns.c (make_hash_table, maybe_resize_hash_table):
4933 Check for integer overflow with large hash tables.
4934 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4935 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4936 (SXHASH_REDUCE): New macro.
4937 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4938 Use it instead of discarding useful hash info with large hash values.
4939 (sxhash_float): New function.
4940 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4941 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4942 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4943 Rewrite to use FIXNUM_BITS, as this simplifies things.
4944 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4945 Adjust signatures to match updated version of code.
4946 (consing_since_gc): Now EMACS_INT, since a single hash table can
4947 use more than INT_MAX bytes.
4949 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4951 Make it possible to build with GCC-4.6+ -O2 -flto.
4953 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4955 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4957 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4958 Call minibuffer-inactive-mode.
4960 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4962 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4963 Update dependencies.
4965 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4967 * data.c (init_data): Remove code for UTS, this system is not
4970 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4972 Don't force ./temacs to start in terminal mode.
4974 * frame.c (make_initial_frame): Initialize faces in all cases, not
4975 only when CANNOT_DUMP is defined.
4976 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4978 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4980 * dispnew.c (add_window_display_history): Use const for the string
4981 pointer. Remove declaration, not needed.
4983 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4985 Use 'inline', not 'INLINE'.
4986 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4987 * alloc.c, fontset.c (INLINE): Remove.
4988 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4989 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4990 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4991 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4992 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4994 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4996 Make it possible to run ./temacs.
4998 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4999 syms_of_callproc does the same thing. Remove test for
5000 "initialized", do it in the caller.
5001 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5003 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5005 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5006 (read_minibuf): Use get_minibuffer.
5007 (syms_of_minibuf): Use DEFSYM.
5008 (Qmetadata): New var.
5009 * data.c (Qbuffer): Don't make it static.
5010 (syms_of_data): Use DEFSYM.
5012 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5014 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5015 (CCL_CODE_MIN): New macro.
5017 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5019 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5021 * eval.c (Qdebug): Now static.
5022 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5023 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5024 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5026 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5028 * image.c: Various fixes to ImageMagick code comments.
5029 (Fimagemagick_types): Doc fix.
5031 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5033 Minor fixes prompted by GCC 4.6.0 warnings.
5035 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5037 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5038 (x_clipboard_manager_save_all): Move extern decl to ...
5039 * xterm.h: ... here, so that it can be checked for consistency.
5041 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5043 * xselect.c (x_clipboard_manager_save_frame)
5044 (x_clipboard_manager_save_all): New functions.
5045 (Fx_clipboard_manager_save): Lisp function deleted.
5047 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5048 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5050 * xterm.h: Update prototype.
5052 2011-05-28 William Xu <william.xwl@gmail.com>
5054 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5057 2011-05-28 Jim Meyering <meyering@redhat.com>
5059 Avoid a sign-extension bug in crypto_hash_function.
5060 * fns.c (to_uchar): Define.
5061 (crypto_hash_function): Use it to convert some newly-signed
5062 variables to unsigned, to avoid sign-extension bugs. For example,
5063 without this change, (md5 "truc") would evaluate to
5064 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5065 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5066 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5068 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5070 Integer overflow fixes.
5072 * dbusbind.c: Serial number integer overflow fixes.
5073 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5074 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5075 to hold a serial number that is too large for a fixnum.
5076 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5077 Check for serial numbers out of range. Decode any serial number
5078 that was so large that it became a float. (Bug#8722)
5080 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5081 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5082 Use XFASTINT rather than XUINT when numbers are nonnegative.
5083 (xd_append_arg, Fdbus_method_return_internal):
5084 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5085 arguments, check that Lisp number is nonnegative, rather than
5086 silently wrapping negative numbers around. (Bug#8722)
5087 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5090 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5092 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5094 ccl: add integer overflow checks
5095 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5096 (IN_INT_RANGE): New macros.
5097 (ccl_driver): Use them to check for integer overflow when
5098 decoding a CCL program. Many of the new checks are whether XINT (x)
5099 fits in int; it doesn't always, on 64-bit hosts. The new version
5100 doesn't catch all possible integer overflows, but it's an
5101 improvement. (Bug#8719)
5103 * alloc.c (make_event_array): Use XINT, not XUINT.
5104 There's no need for unsigned here.
5106 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5107 This follows up to the 2011-05-06 change that substituted uintptr_t
5108 for EMACS_INT. This case wasn't caught back then.
5110 Rework Fformat to avoid integer overflow issues.
5111 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5112 now (part of C89). Include <verify.h>.
5113 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5114 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5115 (Fformat): Avoid the prepass trying to compute sizes; it was only
5116 approximate and thus did not catch overflow reliably. Instead, walk
5117 through the format just once, formatting and computing sizes as we go,
5118 checking for integer overflow at every step, and allocating a larger
5119 buffer as needed. Keep track separately whether the format is
5120 multibyte. Keep only the most-recently calculated precision, rather
5121 than them all. Record whether each argument has been converted to
5122 string. Use EMACS_INT, not int, for byte and char and arg counts.
5123 Support field widths and precisions larger than INT_MAX. Avoid
5124 sprintf's undefined behavior with conversion specifications such as %#d
5125 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5126 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5127 formatting out-of-range floating point numbers with int
5130 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5132 * data.c: Avoid integer truncation in expressions involving floats.
5133 * data.c: Include <intprops.h>.
5134 (arith_driver): When there's an integer overflow in an expression
5135 involving floating point, convert the integers to floating point
5136 so that the resulting value does not suffer from catastrophic
5137 integer truncation. For example, on a 64-bit host (* 4
5138 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5139 Do not rely on undefined behavior after integer overflow.
5141 merge count_size_as_multibyte, parse_str_to_multibyte
5142 * character.c, character.h (count_size_as_multibyte):
5143 Rename from parse_str_to_multibyte; all uses changed.
5144 Check for integer overflow.
5145 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5146 since it's now a duplicate of the other. This is more of
5147 a character than a buffer op, so better that it's in character.c.
5148 * fns.c, print.c: Adjust to above changes.
5150 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5152 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5154 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5156 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5157 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5158 (x_clipboard_manager_save): Now static.
5159 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5161 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5162 (crypto_hash_function): Now static.
5163 Fix pointer signedness problems. Avoid unnecessary initializations.
5165 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5167 * termhooks.h (Vselection_alist): Make it terminal-local.
5169 * terminal.c (create_terminal): Initialize it.
5171 * xselect.c: Support for clipboard managers.
5172 (Vselection_alist): Move to termhooks.h as terminal-local var.
5173 (LOCAL_SELECTION): New macro.
5174 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5175 (symbol_to_x_atom): Remove gratuitous arg.
5176 (x_handle_selection_request, lisp_data_to_selection_data)
5177 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5178 (x_own_selection, x_get_local_selection, x_convert_selection):
5179 New arg, specifying work frame. Use terminal-local Vselection_alist.
5180 (some_frame_on_display): Delete unused function.
5181 (Fx_own_selection_internal, Fx_get_selection_internal)
5182 (Fx_disown_selection_internal, Fx_selection_owner_p)
5183 (Fx_selection_exists_p): New optional frame arg.
5184 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5185 (x_handle_selection_clear): Don't treat other terminals with the
5186 same keyboard specially. Use the terminal-local Vselection_alist.
5187 (x_clear_frame_selections): Use Frun_hook_with_args.
5189 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5191 * xterm.h: Add support for those atoms.
5193 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5195 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5196 (converted_selections, conversion_fail_tag): New global variables.
5197 (x_selection_request_lisp_error): Free the above.
5198 (x_get_local_selection): Remove unnecessary code.
5199 (x_reply_selection_request): Args changed; handle arbitrary array
5200 of converted selections stored in converted_selections.
5201 Separate the XChangeProperty and SelectionNotify steps.
5202 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5203 (x_convert_selection): New function.
5204 (x_handle_selection_event): Simplify.
5205 (x_get_foreign_selection): Don't ignore incoming requests while
5206 waiting for an answer; this will fail when we implement
5207 SAVE_TARGETS, and seems unnecessary anyway.
5208 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5209 (Vx_sent_selection_functions): Doc fix.
5211 2011-05-26 Leo Liu <sdl.web@gmail.com>
5213 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5215 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5217 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5219 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5220 for fringe update if it has periodic bitmap.
5221 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5222 and fringe_bitmap_periodic_p.
5224 * fringe.c (get_fringe_bitmap_data): New function.
5225 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5226 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5227 row. Mark glyph row for fringe update if periodicity changed.
5229 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5230 for fringe update unless it has periodic bitmap.
5232 2011-05-25 Kenichi Handa <handa@m17n.org>
5234 * xdisp.c (get_next_display_element): Set correct it->face_id for
5235 a static composition.
5237 2011-05-24 Leo Liu <sdl.web@gmail.com>
5240 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5242 * fns.c (crypto_hash_function, Fsha1): New function.
5243 (Fmd5): Use crypto_hash_function.
5244 (syms_of_fns): Add Ssha1.
5246 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5248 * gnutls.c: Remove unused macros.
5249 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5250 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5251 Remove macros that are defined and never used.
5252 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5254 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5256 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5257 (Fx_get_selection_internal): Minor cleanup.
5258 (Fx_own_selection_internal): Rename arguments for consistency with
5261 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5263 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5265 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5267 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5269 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5271 * dispnew.c (scrolling_window): Don't exclude the case that the
5272 last enabled row in the desired matrix touches the bottom boundary.
5274 2011-05-21 Glenn Morris <rgm@gnu.org>
5276 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5277 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5278 and add some more files.
5280 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5282 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5283 report_file_error introduced by the change from 2011-05-07.
5285 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5287 * systime.h (Time): Define only if emacs is defined.
5288 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5289 where the include path doesn't have X11/X.h by default. See
5290 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5292 2011-05-20 Kenichi Handa <handa@m17n.org>
5294 * composite.c (find_automatic_composition): Fix previous change.
5296 2011-05-20 Glenn Morris <rgm@gnu.org>
5298 * lisp.mk: New file, split from Makefile.in.
5299 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5300 (shortlisp): Remove.
5301 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5303 2011-05-19 Glenn Morris <rgm@gnu.org>
5305 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5306 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5307 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5308 (lisp): Set the order to that of loadup.el.
5309 (shortlisp): Make it a copy of $lisp.
5310 (SOME_MACHINE_LISP): Remove.
5311 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5312 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5314 2011-05-18 Kenichi Handa <handa@m17n.org>
5316 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5317 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5318 (find_automatic_composition): Mostly rewrite for efficiency.
5320 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5322 * makefile.w32-in: Update dependencies.
5324 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5326 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5327 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5329 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5331 Fix some integer overflow issues, such as string length overflow.
5333 * insdel.c (count_size_as_multibyte): Check for string overflow.
5335 * character.c (lisp_string_width): Check for string overflow.
5336 Use EMACS_INT, not int, for string indexes and lengths; in
5337 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5338 the resulting string length overflows an EMACS_INT; instead,
5339 report a string overflow if no precision given. When checking for
5340 precision exhaustion, use a check that cannot possibly have
5341 integer overflow. (Bug#8675)
5342 * character.h (lisp_string_width): Adjust to new signature.
5344 * alloc.c (string_overflow): New function.
5345 (Fmake_string): Use it. This doesn't change behavior, but saves
5346 a few bytes and will simplify future changes.
5347 * character.c (string_escape_byte8): Likewise.
5348 * lisp.h (string_overflow): New decl.
5350 Fixups, following up to the user-interface timestamp change.
5351 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5352 for UI timestamps, instead of unsigned long.
5353 * msdos.c (mouse_get_pos): Likewise.
5354 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5355 * w32gui.h (Time): Define by including "systime.h" rather than by
5356 declaring it ourselves. (Bug#8664)
5358 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5359 * image.c (clear_image_cache): Likewise.
5361 * term.c (term_mouse_position): Don't assume time_t wraparound.
5363 Be more systematic about user-interface timestamps.
5364 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5365 and sometimes 'EMACS_UINT', to represent these timestamps.
5366 This change causes it to use 'Time' uniformly, as that's what X uses.
5367 This makes the code easier to follow, and makes it easier to catch
5368 integer overflow bugs such as Bug#8664.
5369 * frame.c (Fmouse_position, Fmouse_pixel_position):
5370 Use Time, not unsigned long, for user-interface timestamps.
5371 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5372 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5373 * keyboard.h (last_event_timestamp): Likewise.
5374 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5375 * menu.h (xmenu_show): Likewise.
5376 * term.c (term_mouse_position): Likewise.
5377 * termhooks.h (struct input_event.timestamp): Likewise.
5378 (struct terminal.mouse_position_hook): Likewise.
5379 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5380 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5381 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5382 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5384 * menu.h, termhooks.h: Include "systime.h", for Time.
5386 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5387 Don't assume that the difference between two unsigned long values
5388 can fit into an integer. At this point, we know button_down_time
5389 <= event->timestamp, so the difference must be nonnegative, so
5390 there's no need to cast the result if double-click-time is
5391 nonnegative, as it should be; check that it's nonnegative, just in
5392 case. This bug is triggered when events are more than 2**31 ms
5393 apart (about 25 days). (Bug#8664)
5395 * xselect.c (last_event_timestamp): Remove duplicate decl.
5396 (x_own_selection): Remove needless cast to unsigned long.
5398 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5399 that always fit in int. Use a sentinel instead of a counter, to
5400 avoid a temp and to allay GCC's concerns about possible int overflow.
5401 * frame.h (struct frame): Use int for menu_bar_items_used
5402 instead of EMACS_INT, since it always fits in int.
5404 * menu.c (grow_menu_items): Check for int overflow.
5406 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5408 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5409 Before, the code was not consistent. These values cannot exceed
5410 2**31 - 1 so there's no need to make them unsigned.
5411 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5412 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5413 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5415 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5417 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5418 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5419 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5420 presumably because the widths might not match.
5422 * window.c (size_window): Avoid needless test at loop start.
5424 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5426 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5428 2011-05-12 Drew Adams <drew.adams@oracle.com>
5430 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5432 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5434 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5435 `width' to `bar_area_x' and `bar_area_width', respectively.
5436 (x_scroll_run): Take account of fringe background extension.
5438 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5439 Rename local vars `left' and `width' to `bar_area_x' and
5440 `bar_area_width', respectively.
5441 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5442 background extension.
5444 2011-05-10 Jim Meyering <meyering@redhat.com>
5446 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5448 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5450 * image.c (Finit_image_library): Return t for built-in image types,
5451 like pbm and xbm. (Bug#8640)
5453 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5455 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5457 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5459 * w32console.c (Fset_screen_color): Doc fix.
5460 (Fget_screen_color): New function.
5461 (syms_of_ntterm): Defsubr it.
5463 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5464 unlink the temporary file if Fcall_process didn't create it in the
5466 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5467 child process will be redirected to a file specified with `:file'.
5468 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5469 cue to call_process_cleanup not to close that handle.
5471 2011-05-07 Ben Key <bkey76@gmail.com>
5473 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5474 one of two shell specific rules, either bootstrap-temacs-CMD or
5475 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5476 to the previous implementation of the bootstrap-temacs rule.
5477 The bootstrap-temacs-CMD rule is similar to the previous
5478 implementation of the bootstrap-temacs rule except that it
5479 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5482 These changes, along with some changes to nt/configure.bat,
5483 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5484 earlier fix to add support for --cflags and --ldflags options
5485 that include quotes so that it works whether make uses cmd or
5488 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5490 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5491 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5493 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5494 a string. Handle both cases.
5495 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5496 (Fdbus_register_method): Use Qinvalid_function.
5498 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5500 * makefile.w32-in: Update dependencies.
5501 (LISP_H): Add inttypes.h and stdin.h.
5502 (PROCESS_H): Add unistd.h.
5504 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5506 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5507 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5509 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5511 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5513 * term.c (vfatal): Remove stray call to va_end.
5514 It's not needed and the C Standard doesn't allow it here anyway.
5516 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5517 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5519 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5522 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5524 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5526 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5528 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5530 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5532 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5533 * charset.c (Fdefine_charset_internal): Don't initialize
5534 charset.code_space[15]. The value was garbage, on hosts with
5535 32-bit int (Bug#8600).
5537 * lread.c (read_integer): Be more consistent with string-to-number.
5538 Use string_to_number to do the actual conversion; this avoids
5539 rounding errors and fixes some other screwups. Without this fix,
5540 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5541 (digit_to_number): Move earlier, for benefit of read_integer.
5542 Return -1 if the digit is out of range for the base, -2 if it is
5543 not a digit in any supported base. (Bug#8602)
5545 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5547 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5548 to match comment at start of function. This also removes a
5549 GCC warning about overflow in a 32+64-bit port.
5551 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5553 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5554 Reported by Stefan Monnier in
5555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5556 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5557 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5559 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5560 (EMACS_UINTPTR): Likewise, with uintptr_t.
5562 * lisp.h: Prefer 64-bit EMACS_INT if available.
5563 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5564 on 32-bit hosts that have 64-bit int, so that they can access
5566 However, temporarily disable this change unless the temporary
5567 symbol WIDE_EMACS_INT is defined.
5569 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5571 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5572 This removes an assumption that EMACS_INT and long are the same
5573 width as pointers. The assumption is true for Emacs porting targets
5574 now, but we want to make other targets possible.
5575 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5576 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5577 In the rest of the code, change types of integers that hold casted
5578 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5579 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5580 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5581 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5582 No need to cast type when ORing.
5583 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5584 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5585 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5586 assume EMACS_INT is the same width as char *.
5587 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5588 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5589 Remove no-longer-needed casts.
5590 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5591 (xg_tool_bar_help_callback, xg_make_tool_item):
5592 Use EMACS_INTPTR to hold an integer
5593 that will be cast to void *; this can avoid a GCC warning
5594 if EMACS_INT is not the same width as void *.
5595 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5596 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5597 (current_message_1, set_message_1):
5598 Use a local to convert to proper width without a cast.
5599 * xmenu.c (dialog_selection_callback): Likewise.
5601 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5602 Also, don't assume VALBITS / RAND_BITS is less than 5,
5603 and don't rely on undefined behavior when shifting a 1 left into
5605 * lisp.h (get_random): Change signature to match.
5607 * lread.c (hash_string): Use size_t, not int, for hash computation.
5608 Normally we prefer signed values; but hashing is special, because
5609 it's better to use unsigned division on hash table sizes so that
5610 the remainder is nonnegative. Also, size_t is the natural width
5611 for hashing into memory. The previous code used 'int', which doesn't
5612 retain enough info to hash well into very large tables.
5613 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5615 * dbusbind.c: Don't possibly lose pointer info when converting.
5616 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5617 Use XPNTR rather than XHASH, so that the high-order bits of
5618 the pointer aren't lost when converting through void *.
5620 * eval.c (Fautoload): Don't double-shift a pointer.
5622 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5624 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5626 * gnutls.c (DEF_GNUTLS_FN):
5627 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5629 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5631 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5634 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5636 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5637 New version that can reserve upto 2GB of heap space.
5639 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5641 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5643 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5645 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5646 `gnutls_certificate_set_x509_key_file'.
5648 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5650 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5651 Update dependencies.
5653 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5655 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5656 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5657 Remove unused parameter `fildes'.
5658 * process.c (read_process_output, send_process): Don't pass it.
5660 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5662 Fix previous change: the library cache is defined in w32.c.
5663 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5664 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5666 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5668 Implement dynamic loading of GnuTLS on Windows.
5670 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5671 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5672 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5675 * gnutls.c (Qgnutls_dll): Define.
5676 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5677 (gnutls_*): Declare function pointers.
5678 (init_gnutls_functions): New function to initialize function pointers.
5679 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5680 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5681 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5682 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5683 (emacs_gnutls_write, emacs_gnutls_read)
5684 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5685 (Fgnutls_available_p): New function.
5686 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5687 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5688 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5690 * image.c: Include w32.h.
5691 (Vimage_type_cache): Delete.
5692 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5693 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5694 (w32_delayed_load): Move to w32.c.
5696 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5698 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5699 (w32_delayed_load): Move from image.c. When loading a library, record
5700 its filename in the :loaded-from property of the library id.
5701 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5702 Initialize and staticpro them.
5703 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5705 * process.c: Include lisp.h before w32.h, not after.
5706 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5707 instead of gnutls_record_check_pending.
5709 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5711 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5713 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5714 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5717 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5719 * xterm.c (x_set_frame_alpha): Do not set property on anything
5720 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5722 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5724 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5726 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5728 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5729 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5730 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5731 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5732 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5733 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5734 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5735 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5736 (Qgnutls_bootprop_callbacks_verify): Make static.
5738 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5740 * callproc.c: Indentation fixup.
5742 * sysdep.c (wait_for_termination_1): Make static.
5743 (wait_for_termination, interruptible_wait_for_termination):
5744 Move after wait_for_termination_1.
5746 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5748 * sysdep.c (interruptible_wait_for_termination): New function
5749 which is like wait_for_termination, but allows keyboard
5752 * callproc.c (Fcall_process): Add (:file "file") as an option for
5754 (Fcall_process_region): Ditto.
5756 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5758 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5759 rather than `XVECTOR (FOO)->size'.
5761 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5762 inttypes.h, as a gnulib replacement is used if it not available in
5765 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5767 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5768 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5769 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5771 * coding.c (coding_alloc_by_realloc): Error out if destination
5772 will grow beyond MOST_POSITIVE_FIXNUM.
5773 (decode_coding_emacs_mule): Abort if there isn't enough place in
5774 charbuf for the composition carryover bytes. Reserve an extra
5775 space for up to 2 characters produced in a loop.
5776 (decode_coding_iso_2022): Abort if there isn't enough place in
5777 charbuf for the composition carryover bytes.
5779 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5781 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5782 aborting when %lld or %lll format is passed.
5783 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5784 %llo or %llx format is passed. (Bug#8545)
5786 * window.c (window_scroll_line_based): Use a marker instead of
5787 simple variables to record original value of point. (Bug#7952)
5789 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5790 produced by %s or %c overflows available buffer space. (Bug#8545)
5792 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5794 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5795 (SIZE_MAX): Move defn after all includes, as they might #define it.
5797 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5799 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5801 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5803 * keyboard.c (Qdelayed_warnings_hook): Define.
5804 (command_loop_1): Run `delayed-warnings-hook'
5805 if Vdelayed_warnings_list is non-nil.
5806 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5807 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5809 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5811 * doprnt.c (doprnt): Don't return value smaller than the buffer
5812 size if the message was truncated. (Bug#8545).
5814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5816 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5817 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5819 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5821 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5823 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5825 * makefile.w32-in: Update dependencies.
5827 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5829 Improve `doprnt' and its usage. (Bug#8545)
5830 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5831 `format_end'. Remove support for %l as a conversion specifier.
5832 Don't use xrealloc. Improve diagnostics when the %l size modifier
5833 is used. Update the commentary.
5835 * eval.c (verror): Simplify calculation of size_t.
5837 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5840 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5842 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5845 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5847 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5848 This makes this file independent of the recent pseudovector change.
5850 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5852 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5854 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5855 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5856 Remove unused local.
5857 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5859 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5860 GCC 4.6.0 optimizes based on type-based alias analysis.
5861 For example, if b is of type struct buffer * and v of type struct
5862 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5863 != &v->size, and therefore "v->size = 1; b->size = 2; return
5864 v->size;" must therefore return 1. This assumption is incorrect
5865 for Emacs, since it type-puns struct Lisp_Vector * with many other
5866 types. To fix this problem, this patch adds a new type struct
5867 vectorlike_header that documents the constraints on layout of vectors
5868 and pseudovectors, and helps optimizing compilers not get fooled
5869 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5870 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5871 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5873 (XSETPVECTYPE): Rewrite in terms of new macro.
5874 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5875 This is a bit clearer, and further avoids the possibility of
5876 undesirable aliasing.
5877 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5878 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5879 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5880 since Lisp_Subr is a special case (no "next" field).
5881 (ASIZE): Now uses header.size rather than size.
5882 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5883 to avoid the hassle of writing XVECTOR (foo)->header.size.
5884 (struct vectorlike_header): New type.
5885 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5886 object, to help avoid aliasing.
5887 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5888 (SUBRP): Likewise, since Lisp_Subr is a special case.
5889 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5890 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5891 (struct Lisp_Hash_Table): Combine first two members into a single
5892 struct vectorlike_header member. All uses of "size" and "next" members
5893 changed to be "header.size" and "header.next".
5894 * buffer.h (struct buffer): Likewise.
5895 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5896 * frame.h (struct frame): Likewise.
5897 * process.h (struct Lisp_Process): Likewise.
5898 * termhooks.h (struct terminal): Likewise.
5899 * window.c (struct save_window_data, struct saved_window): Likewise.
5900 * window.h (struct window): Likewise.
5901 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5902 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5903 * buffer.c (init_buffer_once): Likewise.
5904 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5906 * process.c (Fformat_network_address): Use local var for size,
5909 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5911 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5912 * data.c (atof): Remove decl; no longer used or needed.
5913 (digit_to_number): Move to lread.c.
5914 (Fstring_to_number): Use new string_to_number function, to be
5915 consistent with how the Lisp reader treats infinities and NaNs.
5916 Do not assume that floating-point numbers represent EMACS_INT
5917 without losing information; this is not true on most 64-bit hosts.
5918 Avoid double-rounding errors, by insisting on integers when
5919 parsing non-base-10 numbers, as the documentation specifies.
5920 * lisp.h (string_to_number): New decl, replacing ...
5921 (isfloat_string): Remove.
5922 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5923 (read1): Do not accept +. and -. as integers; this
5924 appears to have been a coding error. Similarly, do not accept
5925 strings like +-1e0 as floating point numbers. Do not report
5926 overflow for integer overflows unless the base is not 10 which
5927 means we have no simple and reliable way to continue.
5928 Break out the floating-point parsing into a new
5929 function string_to_number, so that Fstring_to_number parses
5930 floating point numbers consistently with the Lisp reader.
5931 (digit_to_number): Move here from data.c. Make it static inline.
5932 (E_CHAR, EXP_INT): Remove, replacing with ...
5933 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5934 (string_to_number): New function, replacing isfloat_string.
5935 This function checks for valid syntax and produces the resulting
5936 Lisp float number too. Rework it so that string-to-number
5937 no longer mishandles examples like "1.0e+". Use strtoumax,
5938 so that overflow for non-base-10 numbers is reported only when
5939 there's no portable and simple way to convert to floating point.
5941 * textprop.c (set_text_properties_1): Rewrite for clarity,
5942 and to avoid GCC warning about integer overflow.
5944 * intervals.h (struct interval): Use EMACS_INT for members
5945 where EMACS_UINT might cause problems. See
5946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5947 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5948 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5950 (offset_intervals): Tell GCC not to worry about length overflow
5951 when negating a negative length.
5953 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5954 (overrun_check_free): Likewise.
5956 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5957 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5960 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5961 (gnutls_make_error): Rename local to avoid shadowing.
5962 (gnutls_emacs_global_deinit): ifdef out; not used.
5963 (Fgnutls_boot): Use const for pointer to readonly storage.
5964 Comment out unused local. Fix pointer signedness problems.
5966 * lread.c (openp): Don't stuff size_t into an 'int'.
5967 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5968 about possible signed overflow.
5970 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5971 (GDK_KEY_g): Don't define if already defined.
5972 (xg_prepare_tooltip): Avoid pointer signedness problem.
5973 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5975 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5976 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5978 * xfns.c (Fx_window_property): Simplify a bit,
5979 to make a bit faster and to avoid GCC 4.6.0 warning.
5980 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5982 * fns.c (internal_equal): Don't assume size_t fits in int.
5984 * alloc.c (compact_small_strings): Tighten assertion a little.
5986 Replace pEd with more-general pI, and fix some printf arg casts.
5987 * lisp.h (pI): New macro, generalizing old pEd macro to other
5988 conversion specifiers. For example, use "...%"pI"d..." rather
5989 than "...%"pEd"...".
5990 (pEd): Remove. All uses replaced with similar uses of pI.
5991 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5992 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5993 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5994 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5995 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5996 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5997 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5999 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6000 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6001 * print.c (safe_debug_print, print_object): Likewise.
6002 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6004 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6005 avoiding the 0 flag, which is not portable.
6006 * process.c (Fmake_network_process): Use pI to avoid cast.
6007 * region-cache.c (pp_cache): Likewise.
6008 * xdisp.c (decode_mode_spec): Likewise.
6009 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6010 behavior on 64-bit hosts with printf arg.
6011 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6012 (x_stop_queuing_selection_requests): Likewise.
6013 (x_get_window_property): Don't truncate byte count to an 'int'
6016 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6017 here, since it parses constructs like leading '-' and spaces,
6018 which are not wanted; and it overflows with large numbers.
6019 Instead, simply match F[0-9]+, which is what is wanted anyway.
6021 * alloc.c: Remove unportable assumptions about struct layout.
6022 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6023 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6024 (allocate_vectorlike, make_pure_vector): Use the new macros,
6025 plus offsetof, to remove unportable assumptions about struct layout.
6026 These assumptions hold on all porting targets that I know of, but
6027 they are not guaranteed, they're easy to remove, and removing them
6028 makes further changes easier.
6030 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6031 This doesn't fix a bug but makes the code clearer.
6032 (string_overrun_cookie): Now const. Use initializers that
6033 don't formally overflow signed char, to avoid warnings.
6034 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6035 can cause Emacs to crash when string overrun checking is enabled.
6036 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6037 multiple of sizeof (EMACS_INT); it need not be, if
6038 alignof(EMACS_INT) < sizeof (EMACS_INT).
6039 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6041 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6043 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6045 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6047 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6048 supposed to be handshaking. (Bug#8556)
6049 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6051 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6053 * lisp.h (Qdebug): List symbol.
6054 * eval.c (Qdebug): Restore global linkage.
6055 * keyboard.c (debug-on-event): New variable.
6056 (handle_user_signal): Break into debugger when debug-on-event
6057 matches the current signal symbol.
6059 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6061 * alloc.c (check_sblock, check_string_bytes)
6062 (check_string_free_list): Convert to standard C.
6064 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6066 * w32.c (emacs_gnutls_push): Fix typo.
6068 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6070 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6071 "cast to pointer from integer of different size".
6073 Improve doprnt and its use in verror. (Bug#8545)
6074 * doprnt.c (doprnt): Document the set of format control sequences
6075 supported by the function. Use SAFE_ALLOCA instead of always
6078 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6079 is one byte too soon. Don't use xrealloc; instead xfree and
6082 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6084 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6087 * gnutls.c: Renamed global_initialized to
6088 gnutls_global_initialized. Added internals for the
6089 :verify-hostname-error, :verify-error, and :verify-flags
6090 parameters of `gnutls-boot' and documented those parameters in the
6091 docstring. Start callback support.
6092 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6093 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6094 on error. Return error code.
6095 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6096 (emacs_gnutls_read): Likewise.
6097 (Fgnutls_boot): Return handshake error code.
6098 (emacs_gnutls_handle_error): New function.
6099 (wsaerror_to_errno): Likewise.
6101 * w32.h (emacs_gnutls_pull): Add prototype.
6102 (emacs_gnutls_push): Likewise.
6104 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6105 (emacs_gnutls_push): Likewise.
6107 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6109 * process.c (wait_reading_process_output): Check if GnuTLS
6110 buffered some data internally if no FDs are set for TLS
6113 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6114 (LIBS): Link to USER_LIBS.
6115 ($(BLD)/gnutls.$(0)): New target.
6117 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6119 * xdisp.c (handle_single_display_spec): Rename the
6120 display_replaced_before_p argument into display_replaced_p, to
6121 make it consistent with the commentary. Fix typos in the
6124 * textprop.c (syms_of_textprop): Remove dead code.
6125 (copy_text_properties): Delete obsolete commentary about an
6126 interface that was deleted long ago. Fix typos in the description
6129 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6130 to changes in oldXMenu/XMenu.h from 2011-04-16.
6131 <menu_help_message, prev_menu_help_message>: Constify.
6132 (IT_menu_make_room): menu->help_text is now `const char **';
6135 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6136 to changes in oldXMenu/XMenu.h from 2011-04-16.
6137 (struct XMenu): Declare `help_text' `const char **'.
6139 * xfaces.c <Qunspecified>: Make extern again.
6141 * syntax.c: Include sys/types.h before including regex.h, as
6144 * doc.c (get_doc_string): Improve the format passed to `error'.
6146 * doprnt.c (doprnt): Improve commentary.
6148 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6150 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6153 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6154 changes in globals.h immediately force recompilation.
6155 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6156 $(CURDIR)/s/ms-w32.h.
6157 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6159 * character.c (Fchar_direction): Function deleted.
6160 (syms_of_character): Don't defsubr it.
6161 <char-direction-table>: Deleted.
6163 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6165 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6166 * doprnt.c: Include limits.h.
6167 (SIZE_MAX): New macro.
6168 (doprnt): Return a size_t value. 2nd arg is now size_t.
6169 Many local variables are now size_t instead of int or unsigned.
6170 Improve overflow protection. Support `l' modifier for integer
6171 conversions. Support %l conversion. Don't assume an EMACS_INT
6172 argument for integer conversions and for %c.
6174 * lisp.h (doprnt): Restore prototype.
6176 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6179 * Makefile.in (base_obj): Add back doprnt.o.
6181 * deps.mk (doprnt.o): Add back prerequisites.
6182 (callint.o): Depend on character.h.
6184 * eval.c (internal_lisp_condition_case): Include the handler
6185 representation in the error message.
6186 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6187 when breaking from the loop.
6189 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6191 * callint.c (Fcall_interactively): When displaying error message
6192 about invalid control letter, pass the character's codepoint, not
6193 a pointer to its multibyte form. Improve display of the character
6194 in octal and display also its hex code.
6196 * character.c (char_string): Use %x to display the (unsigned)
6197 codepoint of an invalid character, to avoid displaying a bogus
6200 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6201 `error', not SYMBOL_NAME itself.
6203 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6204 character arguments to `error'.
6206 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6207 to `error' in error message about FINAL_CHAR argument. Make sure
6208 FINAL_CHAR is a character, and use %c when it is passed as
6209 argument to `error'.
6211 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6213 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6215 * w32.c: Include <time.h>.
6216 (sys_localtime): New function.
6218 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6220 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6222 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6224 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6226 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6229 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6231 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6232 gl_state.e_property when gl_state.object is Qt.
6234 * insdel.c (make_gap_larger): Remove limitation of buffer size
6237 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6239 * xdisp.c (lookup_glyphless_char_display)
6240 (produce_glyphless_glyph): Handle cons cell entry in
6241 glyphless-char-display.
6242 (Vglyphless_char_display): Document it.
6244 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6245 glyphless-char-display.
6247 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6249 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6251 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6253 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6254 definition for no-X builds.
6256 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6258 Static checks with GCC 4.6.0 and non-default toolkits.
6260 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6262 * process.c (keyboard_bit_set): Define only if SIGIO.
6263 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6264 (send_process): Repair possible setjmp clobbering.
6266 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6268 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6270 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6272 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6273 Define only if needed.
6275 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6276 by pacifying GCC about it. Maybe it's time to retire it?
6277 * xfaces.c (USG, __TIMEVAL__): Likewise.
6279 * dispextern.h (struct redisplay_interface): Rename param
6281 * termhooks.h (struct terminal): Likewise.
6282 * xterm.c (xembed_send_message): Likewise.
6284 * insdel.c (make_gap_smaller): Define only if
6285 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6287 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6290 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6291 so that we aren't warned about unused symbols.
6293 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6295 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6297 * xfns.c (x_real_positions): Mark locals as initialized.
6299 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6301 * xterm.c: Fix problems found by static analysis with other toolkits.
6302 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6303 (x_dispatch_event): Declare static if USE_GTK, and
6304 define if USE_GTK || USE_X_TOOLKIT.
6305 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6306 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6307 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6308 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6310 * xmenu.c (menu_help_callback): Pointer type fixes.
6311 Use const pointers when pointing at readonly data. Avoid pointer
6313 (FALSE): Remove unused macro.
6314 (update_frame_menubar): Remove unused decl.
6316 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6318 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6319 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6320 (single_menu_item): Rename local to avoid shadowing.
6322 * keyboard.c (make_lispy_event): Remove unused local var.
6324 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6325 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6327 * bitmaps: Change bitmaps from unsigned char back to the X11
6328 compatible char. Avoid the old compiler warnings about
6329 out-of-range initializers by using, for example, '\xab' rather
6332 * xgselect.c (xgselect_initialize): Check vs interface
6333 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6335 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6337 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6338 to read-only memory.
6340 * fns.c (vector): Remove; this old hack is no longer needed.
6342 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6344 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6346 * xrdb.c (x_load_resources): Omit unused local.
6348 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6349 (x_window): Rename locals to avoid shadowing.
6350 (USG): Use the kludged USG macro, to pacify gcc.
6352 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6353 (x_term_init): Remove local to avoid shadowing.
6355 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6357 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6358 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6360 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6362 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6364 Fix regex.c, syntax.c and friends for buffers > 2GB.
6365 * syntax.h (struct gl_state_s): Declare character position members
6368 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6370 * textprop.c (verify_interval_modification, interval_of):
6371 Declare arguments EMACS_INT.
6373 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6376 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6378 * indent.c (Fvertical_motion): Local variable it_start is now
6381 * regex.c (re_match, re_match_2, re_match_2_internal)
6382 (bcmp_translate, regcomp, regexec, print_double_string)
6383 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6384 (re_compile_pattern, re_exec): Declare arguments and local
6385 variables `size_t' and `ssize_t' and return values `regoff_t', as
6387 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6388 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6389 <compile_stack_type>: `size' and `avail' are now `size_t'.
6391 * regex.h <regoff_t>: Use ssize_t, not int.
6392 (re_search, re_search_2, re_match, re_match_2): Arguments that
6393 specify buffer/string position and length are now ssize_t and
6394 size_t. Return type is regoff_t.
6396 2011-04-16 Ben Key <bkey76@gmail.com>
6398 * nsfont.m: Fixed bugs in ns_get_family and
6399 ns_descriptor_to_entity that were caused by using free to
6400 deallocate memory blocks that were allocated by xmalloc (via
6401 xstrdup). This caused Emacs to crash when compiled with
6402 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6403 --enable-checking=xmallocoverrun). xfree is now used to
6404 deallocate these memory blocks.
6406 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6408 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6410 emacs_write: Accept and return EMACS_INT for sizes.
6411 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6413 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6414 Accept and return EMACS_INT.
6415 (emacs_gnutls_write): Return the number of bytes written on
6417 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6418 (emacs_read, emacs_write): Remove check for negative size, as the
6419 Emacs source code has been audited now.
6420 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6421 (emacs_read, emacs_write): Use it.
6422 * process.c (send_process): Adjust to the new signatures of
6423 emacs_write and emacs_gnutls_write. Do not attempt to store
6424 a byte offset into an 'int'; it might overflow.
6425 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6427 * sound.c: Don't assume sizes fit in 'int'.
6428 (struct sound_device.period_size, alsa_period_size):
6429 Return EMACS_INT, not int.
6430 (struct sound_device.write, vox_write, alsa_write):
6431 Accept EMACS_INT, not int.
6432 (wav_play, au_play): Use EMACS_INT to store sizes and to
6433 record read return values.
6435 2011-04-15 Ben Key <bkey76@gmail.com>
6437 * keyboard.c (Qundefined): Don't declare static since it is used
6439 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6440 static since they are used in nsfont.m.
6442 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6444 * process.c (Qprocessp): Don't declare static.
6445 * lisp.h (Qprocessp): Declare again.
6447 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6449 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6451 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6453 Improve C-level modularity by making more things 'static'.
6455 Don't publish debugger-only interfaces to other modules.
6456 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6457 (verify_bytepos, count_markers): Move decls to the only modules
6459 * region-cache.h (pp_cache): Likewise.
6460 * window.h (check_all_windows): Likewise.
6461 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6463 * sysdep.c (croak): Now static, if
6464 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6465 * syssignal.h (croak): Declare only if not static.
6467 * alloc.c (refill_memory_reserve): Now static if
6468 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6469 * lisp.h (refill_memory_reserve): Declare only if not static.
6471 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6472 Define only if USE_LUCID.
6474 * xrdb.c (x_customization_string, x_rm_string): Now static.
6476 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6477 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6479 * xdisp.c (draw_row_with_mouse_face): Now static.
6480 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6482 * window.h (check_all_windows): Mark externally visible.
6484 * window.c (window_deletion_count): Now static.
6486 * undo.c: Make symbols static if they're not exported.
6487 (last_undo_buffer, last_boundary_position, pending_boundary):
6490 * textprop.c (interval_insert_behind_hooks): Now static.
6491 (interval_insert_in_front_hooks): Likewise.
6493 * term.c: Make symbols static if they're not exported.
6494 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6495 (max_frame_lines, tty_set_terminal_modes):
6496 (tty_reset_terminal_modes, tty_turn_off_highlight):
6497 (get_tty_terminal): Now static.
6498 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6499 * termhooks.h (term_mouse_moveto): Do not declare if
6501 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6502 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6504 * sysdep.c: Make symbols static if they're not exported.
6505 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6507 (sigprocmask_set, full_mask): Remove; unused.
6508 (wait_debugging): Mark as visible.
6509 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6510 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6512 * syntax.c (syntax_temp): Define only if !__GNUC__.
6514 * sound.c (current_sound_device, current_sound): Now static.
6516 * search.c (searchbufs, searchbuf_head): Now static.
6518 * scroll.c (scroll_cost): Remove; unused.
6519 * dispextern.h (scroll_cost): Remove decl.
6521 * region-cache.h (pp_cache): Mark as externally visible.
6523 * process.c: Make symbols static if they're not exported.
6524 (process_tick, update_tick, create_process, chan_process):
6525 (Vprocess_alist, proc_buffered_char, datagram_access):
6526 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6527 (deactivate_process): Mark defn as static, as well as decl.
6528 * lisp.h (create_process): Remove decl.
6529 * process.h (chan_process, Vprocess_alist): Remove decls.
6531 * print.c: Make symbols static if they're not exported.
6532 (print_depth, new_backquote_output, being_printed, print_buffer):
6533 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6534 (print_interval, print_number_index, initial_stderr_stream):
6536 * lisp.h (Fprinc): Remove decl.
6537 (debug_output_compilation_hack): Mark as externally visible.
6539 * sysdep.c (croak): Move decl from here to syssignal.h.
6540 * syssignal.h (croak): Put it here, so the API can be checked when
6541 'croak' is called from dissociate_if_controlling_tty.
6543 * minibuf.c: Make symbols static if they're not exported.
6544 (minibuf_save_list, choose_minibuf_frame): Now static.
6545 * lisp.h (choose_minibuf_frame): Remove decl.
6547 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6549 * lread.c: Make symbols static if they're not exported.
6550 (read_objects, initial_obarray, oblookup_last_bucket_number):
6552 (make_symbol): Remove; unused.
6553 * lisp.h (initial_obarray, make_symbol): Remove decls.
6555 * keyboard.c: Make symbols static if they're not exported.
6556 (single_kboard, recent_keys_index, total_keys, recent_keys):
6557 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6558 (this_single_command_key_start, echoing, last_auto_save):
6559 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6560 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6561 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6562 (Vlispy_mouse_stem, double_click_count):
6564 (force_auto_save_soon): Define only if SIGDANGER.
6565 (ignore_mouse_drag_p): Now static if
6566 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6567 (print_help): Remove; unused.
6568 (stop_character, last_timer_event): Mark as externally visible.
6569 * keyboard.h (ignore_mouse_drag_p): Declare only if
6570 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6571 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6572 * lisp.h (echoing): Remove decl.
6573 (force_auto_save_soon): Declare only if SIGDANGER.
6574 * xdisp.c (redisplay_window): Simplify code, to make it more
6575 obvious that ignore_mouse_drag_p is not accessed if !defined
6576 USE_GTK && !defined HAVE_NS.
6578 * intervals.c: Make symbols static if they're not exported.
6579 (merge_properties_sticky, merge_interval_right, delete_interval):
6581 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6583 * insdel.c: Make symbols static if they're not exported.
6584 However, leave prepare_to_modify_buffer alone. It's never
6585 called from outside this function, but that appears to be a bug.
6586 (combine_after_change_list, combine_after_change_buffer):
6587 (adjust_after_replace, signal_before_change): Now static.
6588 (adjust_after_replace_noundo): Remove; unused.
6589 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6590 (signal_before_change): Remove decls.
6592 * indent.c (val_compute_motion, val_vmotion): Now static.
6594 * image.c: Make symbols static if they're not exported.
6595 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6597 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6598 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6600 * fringe.c (standard_bitmaps): Now static.
6601 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6603 * frame.c: Make symbols static if they're not exported.
6604 (x_report_frame_params, make_terminal_frame): Now static.
6605 (get_frame_param): Now static, unless HAVE_NS.
6606 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6607 (x_get_resource_string): Remove; not used.
6608 * frame.h (make_terminal_frame, x_report_frame_params):
6609 (x_get_resource_string); Remove decls.
6610 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6611 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6613 * font.c, fontset.c: Make symbols static if they're not exported.
6614 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6615 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6616 * font.c (font_close_object): Now static.
6617 * font.h (font_close_object): Remove.
6618 * fontset.c (FONTSET_OBJLIST): Remove.
6619 (free_realized_fontset) #if-0 the body, which does nothing.
6620 (face_suitable_for_char_p): #if-0, as it's never called.
6621 * fontset.h (face_suitable_for_char_p): Remove decl.
6622 * xfaces.c (face_at_string_position):
6623 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6624 since 0 is always ASCII.
6626 * fns.c (weak_hash_tables): Now static.
6628 * fileio.c: Make symbols static if they're not exported.
6629 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6630 (Vwrite_region_annotation_buffers): Now static.
6632 * eval.c: Make symbols static if they're not exported.
6633 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6634 * lisp.h (backtrace_list): Remove decl.
6636 * emacs.c: Make symbols static if they're not exported.
6637 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6638 (fatal_error_code, fatal_error_signal_hook, standard_args):
6640 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6641 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6642 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6643 * lisp.h (fatal_error_signal_hook): Remove decl.
6644 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6646 * editfns.c: Move a (normally-unused) function to its only use.
6647 * editfns.c, lisp.h (get_operating_system_release): Remove.
6648 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6649 worth the hassle of breaking this out.
6651 * xterm.c: Make symbols static if they're not exported.
6652 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6653 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6654 (x_destroy_window, x_delete_display):
6656 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6657 (x_mouse_leave): Remove; unused.
6658 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6659 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6660 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6662 (x_mouse_leave): Declare only if WINDOWSNT.
6663 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6664 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6667 * ftxfont.c: Make symbols static if they're not exported.
6668 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6670 * font.h (ftxfont_driver): Likewise.
6672 * xfns.c: Make symbols static if they're not exported.
6673 (x_last_font_name, x_display_info_for_name):
6674 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6675 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6676 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6677 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6678 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6679 (last_show_tip_args): Now static.
6680 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6681 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6682 (x_screen_planes): Remove; unused.
6683 * dispextern.h (x_screen_planes): Remove decl.
6685 * dispnew.c: Make symbols static if they're not exported.
6686 * dispextern.h (redraw_garbaged_frames, scrolling):
6687 (increment_row_positions): Remove.
6688 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6689 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6691 (redraw_garbaged_frames): Remove; unused.
6693 * xfaces.c: Make symbols static if they're not exported.
6694 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6696 * xterm.h (defined_color): Remove decls.
6697 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6698 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6699 (menu_face_changed_default, defined_color, free_realized_face):
6700 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6701 (ascii_face_of_lisp_face): Remove; unused.
6703 * xdisp.c: Make symbols static if they're not exported.
6704 * dispextern.h (scratch_glyph_row, window_box_edges):
6705 (glyph_to_pixel_coords, set_cursor_from_row):
6706 (get_next_display_element, set_iterator_to_next):
6707 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6708 (show_mouse_face): Remove decls
6709 * frame.h (message_buf_print): Likewise.
6710 * lisp.h (pop_message, set_message, check_point_in_composition):
6712 * xterm.h (set_vertical_scroll_bar): Likewise.
6713 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6714 (message_buf_print, scratch_glyph_row, displayed_buffer):
6715 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6716 (get_next_display_element, show_mouse_face, window_box_edges):
6717 (frame_to_window_pixel_xy, check_point_in_composition):
6718 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6719 (glyph_to_pixel_coords): Remove; unused.
6721 * dired.c (file_name_completion): Now static.
6723 * dbusbind.c (xd_in_read_queued_messages): Now static.
6725 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6726 * data.c (circular_list_error): Remove.
6728 * commands.h (last_point_position, last_point_position_buffer):
6729 (last_point_position_window): Remove decls.
6730 * keyboard.c: Make these variables static.
6732 * coding.h (coding, code_convert_region, encode_coding_gap):
6734 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6735 (iso_code_class, detect_coding, code_convert_region): Now static.
6736 (encode_coding_gap): Remove; unused.
6738 * chartab.c (chartab_chars, chartab_bits): Now static.
6740 * charset.h (charset_iso_8859_1): Remove decl.
6741 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6744 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6745 * ccl.c (Vccl_program_table): Now static.
6746 (check_ccl_update): Remove; unused.
6748 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6749 * category.h: ... from here.
6750 * category.c (check_category_table, set_category_set): Now static.
6752 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6753 * lisp.h: Remove these decls.
6755 * buffer.c (buffer_count): Remove unused var.
6757 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6758 so that it's not optimized away.
6759 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6760 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6761 exported only to the debugger.
6763 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6764 * atimer.h (run_all_atimers): Remove; not exported.
6766 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6767 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6768 was inaccessible from Lisp.
6769 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6770 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6772 alloc.c: Import and export fewer symbols, and remove unused items.
6773 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6775 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6776 it's not optimized away by whole-program optimization.
6777 (message_enable_multibyte, free_misc): Remove.
6778 (catchlist, handlerlist, mark_backtrace):
6779 Declare only if BYTE_MARK_STACK.
6780 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6781 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6782 (message_enable_multibyte): Remove decl.
6783 (free_misc, interval_free_list, float_block, float_block_index):
6784 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6785 (cons_free_list, last_marked_index):
6787 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6788 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6789 (mark_backtrace): Define only if BYTE_MARK_STACK.
6790 * xdisp.c (message_enable_multibyte): Now static.
6792 Declare Lisp_Object Q* variables to be 'static' if not exported.
6793 This makes it easier for human readers (and static analyzers)
6794 to see whether these variables are used from other modules.
6795 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6796 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6797 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6798 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6799 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6800 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6801 * xmenu.c, xselect.c:
6802 Declare Q* vars static if they are not used in other modules.
6803 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6804 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6805 Remove decls of unexported vars.
6806 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6808 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6810 Make Emacs functions such as Fatom 'static' by default.
6811 This makes it easier for human readers (and static analyzers)
6812 to see whether these functions can be called from other modules.
6813 DEFUN now defines a static function. To make the function external
6814 so that it can be used in other C modules, use the new macro DEFUE.
6815 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6816 (Finit_image_library):
6817 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6818 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6819 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6820 Remove decls, since these functions are now static.
6821 (Funintern, Fget_internal_run_time): New decls, since these functions
6822 were already external.
6824 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6825 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6826 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6827 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6828 * keyboard.c, keymap.c, lread.c:
6829 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6830 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6831 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6832 Mark functions with DEFUE instead of DEFUN,
6833 if they are used in other modules.
6834 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6835 decls for now-static functions.
6836 * buffer.h (Fdelete_overlay): Remove decl.
6837 * callproc.c (Fgetenv_internal): Mark as internal.
6838 * composite.c (Fremove_list_of_text_properties): Remove decl.
6839 (Fcomposition_get_gstring): New forward static decl.
6840 * composite.h (Fcomposite_get_gstring): Remove decl.
6841 * dired.c (Ffile_attributes): New forward static decl.
6842 * doc.c (Fdocumntation_property): New forward static decl.
6843 * eval.c (Ffetch_bytecode): New forward static decl.
6844 (Funintern): Remove extern decl; now in .h file where it belongs.
6845 * fileio.c (Fmake_symbolic_link): New forward static decl.
6846 * image.c (Finit_image_library): New forward static decl.
6847 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6848 * intervals.h (Fprevious_property_change):
6849 (Fremove_list_of_text_properties): Remove decls.
6850 * keyboard.c (Fthis_command_keys): Remove decl.
6851 (Fcommand_execute): New forward static decl.
6852 * keymap.c (Flookup_key): New forward static decl.
6853 (Fcopy_keymap): Now static.
6854 * keymap.h (Flookup_key): Remove decl.
6855 * process.c (Fget_process): New forward static decl.
6856 (Fprocess_datagram_address): Mark as internal.
6857 * syntax.c (Fsyntax_table_p): New forward static decl.
6858 (skip_chars): Remove duplicate decl.
6859 * textprop.c (Fprevious_property_change): New forward static decl.
6860 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6862 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6863 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6865 * editfns.c (Fformat): Remove unreachable code.
6867 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6869 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6872 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6874 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6875 when at ZV. (Bug#8487)
6877 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6879 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6881 * keyboard.c (parse_tool_bar_item): Likewise.
6882 * sound.c (sound_cleanup, alsa_close): Likewise.
6883 * termcap.c (tgetent): Likewise.
6884 * xfns.c (x_default_font_parameter): Likewise.
6885 * xsettings.c (read_and_apply_settings): Likewise.
6887 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6888 (overrun_check_free): Protoize.
6890 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6892 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6893 since callers should never pass a negative size.
6894 Change the signature to match that of plain 'read' and 'write'; see
6895 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6896 * lisp.h: Update prototypes of emacs_write and emacs_read.
6898 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6900 * xdisp.c (redisplay_window): Don't try to determine the character
6901 position of the scroll margin if the window start point w->startp
6902 is outside the buffer's accessible region. (Bug#8468)
6904 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6906 Fix write-region and its subroutines for buffers > 2GB.
6907 * fileio.c (a_write, e_write): Modify declaration of arguments and
6908 local variables to support buffers larger than 2GB.
6909 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6911 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6912 argument, local variables, and return value.
6914 * lisp.h: Update prototypes of emacs_write and emacs_read.
6916 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6918 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6920 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6922 Fix more problems found by GCC 4.6.0's static checks.
6924 * xdisp.c (vmessage): Use a better test for character truncation.
6926 * charset.c (load_charset_map): <, not <=, for optimization,
6927 and to avoid potential problems with integer overflow.
6928 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6929 * casetab.c (set_identity, shuffle): Likewise.
6930 * editfns.c (Fformat): Likewise.
6931 * syntax.c (skip_chars): Likewise.
6933 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6934 This also lets GCC 4.6.0 generate slightly better loop code.
6936 * callint.c (Fcall_interactively): <, not <=, for optimization.
6937 (Fcall_interactively): Count the number of arguments produced,
6938 not the number of arguments given. This is simpler and lets GCC
6939 4.6.0 generate slightly better code.
6941 * ftfont.c: Distingish more carefully between FcChar8 and char.
6942 The previous code passed unsigned char * to a functions like
6943 strlen and xstrcasecmp that expect char *, which does not
6944 conform to the C standard.
6945 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6946 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6947 char * when the C standard requires it.
6949 * keyboard.c (read_char): Remove unused var.
6951 * eval.c: Port to Windows vsnprintf (Bug#8435).
6953 (SIZE_MAX): Define if the headers do not.
6954 (verror): Do not give up if vsnprintf returns a negative count.
6955 Instead, grow the buffer. This ports to Windows vsnprintf, which
6956 does not conform to C99. Problem reported by Eli Zaretskii.
6957 Also, simplify the allocation scheme, by avoiding the need for
6958 calling realloc, and removing the ALLOCATED variable.
6960 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6962 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6963 But keep the doprint source code for now, as we might revamp it
6964 and use it again (Bug#8435).
6965 * lisp.h (doprnt): Remove.
6966 * Makefile.in (base_obj): Remove doprnt.o.
6967 * deps.mk (doprnt.o): Remove.
6969 error: Print 32- and 64-bit integers portably (Bug#8435).
6970 Without this change, on typical 64-bit hosts error ("...%d...", N)
6971 was used to print both 32- and 64-bit integers N, which relied on
6973 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6975 * lisp.h (error, verror): Mark as printf-like functions.
6976 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6977 Report overflow in size calculations when allocating printf buffer.
6978 Do not truncate output string at its first null byte.
6979 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6980 Truncate the output at a character boundary, since vsnprintf does not
6982 * charset.c (check_iso_charset_parameter): Convert internal
6983 character to string before calling 'error', since %c now has the
6985 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6986 overflow when computing char to be passed to 'error'. Do not
6987 pass Lisp_Object to 'error'; pass the integer instead.
6988 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6989 formatted with plain %d.
6991 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6993 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6995 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6997 * xterm.c (x_catch_errors): Remove duplicate declaration.
6999 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7001 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7003 2011-04-10 Jim Meyering <meyering@redhat.com>
7005 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7006 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7007 return ssize_t not "int", and use size_t as the buffer length.
7008 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7009 * gnutls.h: Update declarations.
7010 * process.c (read_process_output): Use ssize_t, to match.
7011 (send_process): Likewise.
7013 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7015 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7017 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7019 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7020 Use unsigned char, to match FcChar8 type definition.
7022 * xterm.c (handle_one_xevent):
7023 * xmenu.c (create_and_show_popup_menu):
7024 * xselect.c (x_decline_selection_request)
7025 (x_reply_selection_request): Avoid type-punned deref of X events.
7027 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7029 Fix some uses of `int' instead of EMACS_INT.
7030 * search.c (string_match_1, fast_string_match)
7031 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7032 (scan_buffer, find_next_newline_no_quit)
7033 (find_before_next_newline, search_command, Freplace_match)
7034 (Fmatch_data): Make some `int' variables be EMACS_INT.
7036 * xdisp.c (display_count_lines): 3rd argument and return value now
7037 EMACS_INT. All callers changed.
7038 (pint2hrstr): Last argument is now EMACS_INT.
7040 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7041 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7042 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7043 (decode_coding_utf_16, decode_coding_emacs_mule)
7044 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7045 (decode_coding_ccl, decode_coding_charset)
7046 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7047 (decode_coding_iso_2022, decode_coding_emacs_mule)
7048 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7049 <char_offset, last_offset>: Declare EMACS_INT.
7050 (encode_coding_utf_8, encode_coding_utf_16)
7051 (encode_coding_emacs_mule, encode_invocation_designation)
7052 (encode_designation_at_bol, encode_coding_iso_2022)
7053 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7054 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7056 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7057 (encode_invocation_designation): Last argument P_NCHARS is now
7059 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7060 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7062 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7065 * ccl.c (Fccl_execute_on_string): Declare some variables
7068 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7070 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7072 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7074 * process.c (Fformat_network_address): Doc fix.
7076 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7078 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7080 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7082 * keyboard.c (read_char): Call Lisp function help-form-show,
7083 instead of using internal_with_output_to_temp_buffer.
7084 (Qhelp_form_show): New var.
7085 (syms_of_keyboard): Use DEFSYM macro.
7087 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7089 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7091 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7093 * process.c (Flist_processes): Remove to Lisp.
7094 (list_processes_1): Delete.
7096 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7098 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7100 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7102 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7104 Fix more problems found by GCC 4.6.0's static checks.
7106 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7108 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7110 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7112 * xdisp.c (vmessage): Mark as a printf-like function.
7114 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7116 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7118 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7119 printf-like functions.
7120 (tiff_load): Add casts to remove these marks before passing them
7121 to system-supplied API.
7123 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7125 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7126 This avoids several warnings with gcc -Wstrict-overflow.
7127 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7128 directly, rather than having caller test rule sign. This avoids
7129 some unnecessary tests.
7130 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7131 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7132 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7134 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7135 (xfont_open): Avoid unnecessary tests.
7137 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7139 * composite.h, composite.c (composition_gstring_put_cache):
7140 Use EMACS_INT, not int, for length.
7142 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7143 breaking out part of COMPOSITION_DECODE_RULE.
7144 (COMPOSITION_DECODE_RULE): Use it.
7145 * composite.c (get_composition_id): Remove unused local vars,
7146 by using the new macro.
7148 * textprop.c (set_text_properties_1): Change while to do-while,
7149 since the condition is always true at first.
7151 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7152 (interval_deletion_adjustment): Return unsigned value.
7155 * process.c (list_processes_1, create_pty, read_process_output):
7156 (exec_sentinel): Remove vars that were set but not used.
7157 (create_pty): Remove unnecessary "volatile"s.
7158 (Fnetwork_interface_info): Avoid possibility of int overflow.
7159 (read_process_output): Do adaptive read buffering even if carryover.
7160 (read_process_output): Simplify nbytes computation if buffered.
7162 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7164 * syntax.c (scan_words): Remove var that was set but not used.
7165 (update_syntax_table): Use unsigned instead of int.
7167 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7168 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7169 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7171 * print.c (print_error_message): Avoid int overflow.
7173 * font.c (font_list_entities): Redo for clarity,
7174 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7176 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7177 (font_score): Avoid potential overflow in diff calculation.
7179 * fns.c (substring_both): Remove var that is set but not used.
7180 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7182 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7184 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7185 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7186 can always succeed if overflow has undefined behavior.
7188 * search.c (boyer_moore, wordify): Remove vars set but not used.
7189 (wordify): Omit three unnecessary tests.
7191 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7192 All callers changed. This avoids the need for an unused var.
7194 * casefiddle.c (casify_region): Remove var that is set but not used.
7196 * dired.c (file_name_completion): Remove var that is set but not used.
7198 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7200 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7201 (Finsert_file_contents): Remove unnecessary code checking fd.
7203 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7204 Check for integer overflow on size calculations.
7206 * buffer.c (Fprevious_overlay_change): Remove var that is set
7209 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7210 Remove vars that are set but not used.
7211 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7212 (timer_check_2): Mark vars as initialized.
7214 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7216 * image.c (lookup_image): Remove var that is set but not used.
7217 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7219 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7220 that are set but not used.
7222 * xfns.c (make_invisible_cursor): Don't return garbage
7223 if XCreateBitmapFromData fails (Bug#8410).
7225 * xselect.c (x_get_local_selection, x_handle_property_notify):
7226 Remove vars that are set but not used.
7228 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7229 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7231 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7232 Remove var that is set but not used.
7233 (scroll_bar_windows_size): Now size_t, not int.
7234 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7237 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7238 (map_tty_color) [!defined MSDOS]: Likewise.
7240 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7242 * coding.c: Remove vars that are set but not used.
7243 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7244 All callers changed.
7245 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7246 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7247 (decode_coding_charset): Remove vars that are set but not used.
7249 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7250 that is set but not used.
7252 * print.c (print_object): Remove var that is set but not used.
7254 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7255 The gnulib version avoids calling malloc in the usual case,
7256 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7257 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7258 * filelock.c (current_lock_owner): Likewise.
7259 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7260 * sysdep.c: Include allocator.h, careadlinkat.h.
7261 (emacs_no_realloc_allocator): New static constant.
7262 (emacs_readlink): New function.
7263 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7264 ../lib/careadlinkat.h.
7266 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7268 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7269 first non-nil return value).
7271 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7273 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7274 if not defined (Bug#8403).
7276 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7278 * xdisp.c (display_count_lines): Remove parameter `start',
7279 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7280 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7281 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7282 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7283 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7284 and thereabouts. All callers changed.
7285 (get_per_char_metric): Remove parameter `f', unused since
7286 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7288 2011-04-02 Jim Meyering <meyering@redhat.com>
7290 do not dereference NULL upon failed strdup
7291 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7292 (ns_get_family): Likewise.
7294 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7296 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7298 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7300 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7303 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7305 Add lexical binding.
7307 * window.c (Ftemp_output_buffer_show): New fun.
7308 (Fsave_window_excursion):
7309 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7311 * lread.c (lisp_file_lexically_bound_p): New function.
7312 (Fload): Bind Qlexical_binding.
7313 (readevalloop): Remove `evalfun' arg.
7314 Bind Qinternal_interpreter_environment.
7315 (Feval_buffer): Bind Qlexical_binding.
7316 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7318 (syms_of_lread): Declare `lexical-binding'.
7320 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7322 * keyboard.c (eval_dyn): New fun.
7323 (menu_item_eval_property): Use it.
7325 * image.c (parse_image_spec): Use Ffunctionp.
7327 * fns.c (concat, mapcar1): Accept byte-code-functions.
7329 * eval.c (Fsetq): Handle lexical vars.
7330 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7331 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7332 (FletX, Flet): Obey lexical binding.
7333 (Fcommandp): Handle closures.
7334 (Feval): New `lexical' arg.
7335 (eval_sub): New function extracted from Feval. Use it almost
7336 everywhere where Feval was used. Look up vars in lexical env.
7338 (Ffunctionp): Move from subr.el.
7339 (Ffuncall): Handle closures.
7340 (apply_lambda): Remove `eval_flags'.
7341 (funcall_lambda): Handle closures and new byte-code-functions.
7342 (Fspecial_variable_p): New function.
7343 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7344 but without exporting it to Lisp.
7346 * doc.c (Fdocumentation, store_function_docstring):
7347 * data.c (Finteractive_form): Handle closures.
7349 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7352 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7354 (exec_byte_code): New function extracted from Fbyte_code to handle new
7355 calling convention for byte-code-functions. Add new byte-codes.
7357 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7359 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7361 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7363 * xdisp.c (redisplay_internal): Fix prototype.
7365 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7367 * xdisp.c (SCROLL_LIMIT): New macro.
7368 (try_scrolling): Use it when setting scroll_limit.
7369 Limit scrolling to 100 screen lines.
7370 (redisplay_window): Even when falling back on "recentering",
7371 position point in the window according to scroll-conservatively,
7372 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7374 (try_scrolling): When point is above the window, allow searching
7375 as far as scroll_max, or one screenful, to compute vertical
7376 distance from PT to the scroll margin position. This prevents
7377 try_scrolling from unnecessarily failing when
7378 scroll-conservatively is set to a value slightly larger than the
7379 window height. Clean up the case of PT below the margin at bottom
7380 of window: scroll_max can no longer be INT_MAX. When aggressive
7381 scrolling is in use, don't let point enter the opposite scroll
7382 margin as result of the scroll.
7383 (syms_of_xdisp) <scroll-conservatively>: Document the
7384 threshold of 100 lines for never-recentering scrolling.
7386 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7388 * dispextern.h (move_it_by_lines):
7389 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7390 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7391 (message_log_check_duplicate): Remove parameters `prev_bol' and
7392 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7393 (redisplay_internal): Remove parameter `preserve_echo_area',
7394 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7396 * indent.c (Fvertical_motion):
7397 * window.c (window_scroll_pixel_based, Frecenter):
7398 Don't pass `need_y_p' to `move_it_by_lines'.
7400 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7402 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7403 steal a few bits to be more compact.
7404 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7405 Remove unneeded casts.
7407 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7409 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7411 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7412 binding" message (bug#7967).
7414 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7416 Fix more problems found by GCC 4.6.0's static checks.
7418 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7419 Remove unused local var.
7421 * editfns.c (Fmessage_box): Remove unused local var.
7423 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7424 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7425 Omit unused local vars.
7426 * window.c (shrink_windows): Omit unused local var.
7427 * menu.c (digest_single_submenu): Omit unused local var.
7428 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7429 Omit unused local var.
7431 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7432 Don't assume string length fits in int.
7433 (keyremap_step, read_key_sequence): Use size_t for sizes.
7434 (read_key_sequence): Don't check last_real_key_start redundantly.
7436 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7437 instead of alloca (Bug#8344).
7439 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7440 (Fbacktrace_frame): Don't assume nframes fits in int.
7442 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7444 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7447 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7449 * cm.c (calccost): Turn while-do into do-while, for clarity.
7451 * keyboard.c (syms_of_keyboard): Use the same style as later
7452 in this function when indexing through an array. This also
7453 works around GCC bug 48267.
7455 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7457 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7459 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7460 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7462 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7463 This avoids undefined behavior on integer overflow, and is a bit
7464 more convenient anyway since it is compared to a size_t variable.
7466 Variadic C functions now count arguments with size_t, not int.
7467 This avoids an unnecessary limitation on 64-bit machines, which
7468 caused (substring ...) to crash on large vectors (Bug#8344).
7469 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7470 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7471 All variadic functions and their callers changed accordingly.
7472 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7473 * data.c (arith_driver, float_arith_driver): Likewise.
7474 * editfns.c (general_insert_function): Likewise.
7475 * eval.c (struct backtrace.nargs, interactive_p)
7476 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7477 (funcall_lambda, mark_backtrace): Likewise.
7478 * fns.c (concat): Likewise.
7479 * frame.c (x_set_frame_parameters): Likewise.
7480 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7481 0 if not found, not -1. All callers changed.
7483 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7484 (stack_copy_size): Now size_t, not int.
7485 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7487 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7489 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7490 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7491 All callers changed.
7493 * lisp.h (multibyte_char_to_unibyte):
7494 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7495 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7496 * character.h (CHAR_TO_BYTE8):
7497 * cmds.c (internal_self_insert):
7498 * editfns.c (general_insert_function):
7499 * keymap.c (push_key_description):
7500 * search.c (Freplace_match):
7501 * xdisp.c (message_dolog, set_message_1): All callers changed.
7503 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7505 * keyboard.c (safe_run_hook_funcall): New function.
7506 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7507 don't set the hook to nil, but remove the offending function instead.
7508 (Qcommand_hook_internal): Remove, unused.
7509 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7510 Vcommand_hook_internal.
7512 * eval.c (enum run_hooks_condition): Remove.
7513 (funcall_nil, funcall_not): New functions.
7514 (run_hook_with_args): Call each function through a `funcall' argument.
7515 Remove `cond' argument, now redundant.
7516 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7517 (Frun_hook_with_args_until_failure): Adjust accordingly.
7518 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7520 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7522 * dispextern.h (string_buffer_position): Remove declaration.
7524 * print.c (strout): Remove parameter `multibyte', unused since
7525 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7527 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7528 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7529 All callers changed.
7531 * w32.c (_wsa_errlist): Use braces for struct initializers.
7533 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7534 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7535 All callers changed.
7536 (string_buffer_position): Likewise. Also, make static (it's never
7537 used outside xdisp.c).
7538 (cursor_row_p): Remove parameter `w', unused since
7539 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7540 (decode_mode_spec): Remove parameter `precision', introduced during
7541 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7542 All callers changed.
7544 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7546 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7548 2011-03-27 Anders Lindgren <andlind@gmail.com>
7550 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7551 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7552 (ns_update_auto_hide_menu_bar): New functions.
7553 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7554 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7555 ns_constrain_all_frames.
7556 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7557 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7559 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7561 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7563 2011-03-27 Glenn Morris <rgm@gnu.org>
7565 * syssignal.h: Replace RETSIGTYPE with void.
7566 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7567 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7568 Replace SIGTYPE with void everywhere.
7569 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7570 * s/template.h (SIGTYPE): Remove commented out definition.
7572 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7574 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7575 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7577 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7579 * w32.c (read_unc_volume): Use parameter `henum', instead of
7580 global variable `wget_enum_handle'.
7582 * keymap.c (describe_vector): Remove parameters `indices' and
7583 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7584 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7586 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7588 * keyboard.c (timer_check): Remove parameter `do_it_now',
7589 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7590 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7591 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7593 * keyboard.c (read_char):
7594 * w32menu.c (w32_menu_display_help):
7595 * xmenu.c (show_help_event, menu_help_callback):
7596 Adjust calls to `show_help_echo'.
7598 * gtkutil.c (xg_maybe_add_timer):
7599 * keyboard.c (readable_events):
7600 * process.c (wait_reading_process_output):
7601 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7603 * insdel.c (adjust_markers_gap_motion):
7604 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7605 (gap_left, gap_right): Don't call it.
7607 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7609 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7610 incurred during fontification.
7612 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7614 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7615 (DEFVAR_PER_BUFFER): Don't pass it.
7617 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7618 (scrolling_window): Don't pass it.
7620 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7622 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7624 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7626 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7627 of variables specific to SELinux and computation of `encoded_absname'.
7629 * image.c (XPutPixel): Remove unused variable `height'.
7631 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7633 * unexw32.c (get_section_info): Remove unused variable `section'.
7635 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7636 (system_process_attributes): Remove unused variable `sess'.
7637 (sys_read): Remove unused variable `err'.
7639 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7640 (w32_wnd_proc): Remove unused variable `isdead'.
7641 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7642 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7643 (x_create_tip_frame): Remove unused variable `tem'.
7645 * w32inevt.c (w32_console_read_socket):
7646 Remove unused variable `no_events'.
7648 * w32term.c (x_draw_composite_glyph_string_foreground):
7649 Remove unused variable `width'.
7651 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7653 * w32term.c (x_set_glyph_string_clipping):
7654 Don't pass uninitialized region to CombineRgn.
7656 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7658 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7659 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7660 (Fx_close_connection): Remove unused variable `i'.
7662 * w32font.c (w32font_draw): Return number of glyphs.
7663 (w32font_open_internal): Remove unused variable `i'.
7664 (w32font_driver): Add missing initializer.
7666 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7667 (fill_in_menu): Remove unused variable `items_added'.
7669 * w32term.c (last_mouse_press_frame): Remove static global variable.
7670 (w32_clip_to_row): Remove unused variable `f'.
7671 (x_delete_terminal): Remove unused variable `i'.
7673 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7674 (NOTHING): Remove unused static global variable.
7675 (uniscribe_check_otf): Remove unused variable `table'.
7676 (uniscribe_font_driver): Add missing initializers.
7678 2011-03-23 Julien Danjou <julien@danjou.info>
7680 * term.c (Fsuspend_tty, Fresume_tty):
7681 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7682 * window.c (temp_output_buffer_show):
7683 * insdel.c (signal_before_change):
7684 * frame.c (Fhandle_switch_frame):
7685 * fileio.c (Fdo_auto_save):
7686 * emacs.c (Fkill_emacs):
7687 * editfns.c (save_excursion_restore):
7688 * cmds.c (internal_self_insert):
7689 * callint.c (Fcall_interactively):
7690 * buffer.c (Fkill_all_local_variables):
7691 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7693 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7694 unconditionnaly since it does the check itself.
7696 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7698 Fix more problems found by GCC 4.5.2's static checks.
7700 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7701 the first time through the loop, since we know p0 < p1 then.
7702 This also avoids a gcc -Wstrict-overflow warning.
7704 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7705 leading to a memory leak, possible in functions like
7706 load_charset_map_from_file that can allocate an unbounded number
7707 of objects (Bug#8318).
7709 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7710 that could (at least in theory) be that large.
7712 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7713 This is less likely to overflow, and avoids undefined behavior if
7714 overflow does occur. All callers changed. Use strtoul to scan
7715 for the unsigned long integer.
7716 (pint2hrstr): Simplify and tune code slightly.
7717 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7719 * scroll.c (do_scrolling): Work around GCC bug 48228.
7720 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7722 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7723 This also avoids a warning with gcc -Wstrict-overflow.
7724 (validate_x_resource_name): Simplify count usage.
7725 This also avoids a warning with gcc -Wstrict-overflow.
7727 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7730 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7732 * process.c (Fmake_network_process): Use socklen_t, not int,
7733 where POSIX says socklen_t is required in portable programs.
7734 This fixes a porting bug on hosts like 64-bit HP-UX, where
7735 socklen_t is wider than int (Bug#8277).
7736 (Fmake_network_process, server_accept_connection):
7737 (wait_reading_process_output, read_process_output):
7740 * process.c: Rename or move locals to avoid shadowing.
7741 (list_processes_1, Fmake_network_process):
7742 (read_process_output_error_handler, exec_sentinel_error_handler):
7743 Rename or move locals.
7744 (Fmake_network_process): Define label "retry_connect" only if needed.
7745 (Fnetwork_interface_info): Fix pointer signedness.
7746 (process_send_signal): Add cast to avoid pointer signedness problem.
7747 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7748 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7750 Make tparam.h and terminfo.c consistent.
7751 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7752 Include tparam.h instead, since it declares them.
7753 * cm.h (PC): Remove extern decl; tparam.h now does this.
7754 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7755 * terminfo.c: Include tparam.h, to check interfaces.
7756 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7757 (tparam): Adjust signature to match interface in tparam.h;
7758 this removes some undefined behavior. Check that outstring and len
7759 are zero, which they always are with Emacs.
7760 * tparam.h (PC, BC, UP): New extern decls.
7762 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7763 (xftfont_open): Rename locals to avoid shadowing.
7765 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7766 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7767 (OTF_TAG_SYM): Omit macro if not needed.
7768 (ftfont_list): Remove unused local.
7769 (get_adstyle_property, ftfont_pattern_entity):
7770 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7771 Rename locals to avoid shadowing.
7773 * xfont.c (xfont_list_family): Mark var as initialized.
7775 * xml.c (make_dom): Now static.
7777 * composite.c (composition_compute_stop_pos): Rename local to
7779 (composition_reseat_it): Remove unused locals.
7780 (find_automatic_composition, composition_adjust_point): Likewise.
7781 (composition_update_it): Mark var as initialized.
7782 (find_automatic_composition): Mark vars as initialized,
7783 with a FIXME (Bug#8290).
7785 character.h: Rename locals to avoid shadowing.
7786 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7787 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7788 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7789 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7792 * textprop.c (property_change_between_p): Remove; unused.
7794 * intervals.c (interval_start_pos): Now static.
7796 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7798 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7799 Rename locals to avoid shadowing.
7801 * sound.c (wav_play, au_play, Fplay_sound_internal):
7802 Fix pointer signedness.
7803 (alsa_choose_format): Remove unused local var.
7804 (wav_play): Initialize a variable to 0, to prevent undefined
7805 behavior (Bug#8278).
7807 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7809 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7812 clobbering (Bug#8298).
7813 * sysdep.c (sys_subshell): Likewise.
7814 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7816 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7817 This should get cleaned up, so that child_setup has the
7818 same signature on all platforms.
7820 * callproc.c (call_process_cleanup): Now static.
7821 (relocate_fd): Rename locals to avoid shadowing.
7823 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7825 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7826 not to be necessary, and produces flickering.
7828 2011-03-20 Glenn Morris <rgm@gnu.org>
7830 * config.in: Remove file.
7832 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7834 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7835 are now in src/globals.h.
7836 (syms_of_minibuf): Remove spurious & from previous change.
7838 2011-03-20 Leo <sdl.web@gmail.com>
7840 * minibuf.c (completing-read-function): New variable.
7841 (completing-read-default): Rename from completing-read.
7842 (completing-read): Call completing-read-function.
7844 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7846 * xfaces.c (Fx_load_color_file):
7847 Read color file from absolute filename (bug#8250).
7849 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7851 * makefile.w32-in: Update dependencies.
7853 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7855 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7857 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7859 Fix more problems found by GCC 4.5.2's static checks.
7861 * process.c (make_serial_process_unwind, send_process_trap):
7862 (sigchld_handler): Now static.
7864 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7865 That way, the code declares only the vars that it needs.
7866 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7867 * s/cygwin.h (PTY_ITERATION): Likewise.
7868 * s/darwin.h (PTY_ITERATION): Likewise.
7869 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7871 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7872 * process.c (allocate_pty): Don't declare stb unless it's needed.
7874 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7875 (CONSTANTLIM): Remove; unused.
7876 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7877 Define only if needed.
7879 * unexelf.c (unexec): Name an expression,
7880 to avoid gcc -Wbad-function-cast warning.
7881 Use a different way to cause a compilation error if anyone uses
7882 n rather than nn, a way that does not involve shadowing.
7883 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7885 * deps.mk (unexalpha.o): Remove; unused.
7887 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7888 * unexec.h: New file.
7889 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7890 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7892 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7893 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7894 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7895 Change as necessary to match prototype in unexec.h.
7897 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7899 (back_comment, skip_chars): Mark vars as initialized.
7901 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7902 Rename locals to avoid shadowing.
7904 * lread.c (read1): Rewrite so as not to use empty "else".
7905 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7907 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7909 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7910 warning when compiling print.c.
7912 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7913 instead of using an uninitialized var.
7914 (font_sort_entities): Mark var as initialized.
7916 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7918 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7919 pointers to constants.
7920 (font_parse_fcname): Remove unused vars.
7921 (font_delete_unmatched): Now static.
7922 (font_get_spec): Remove; unused.
7923 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7924 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7925 Rename or move locals to avoid shadowing.
7927 * fns.c (require_nesting_list, require_unwind): Now static.
7928 (Ffillarray): Rename locals to avoid shadowing.
7930 * floatfns.c (domain_error2): Define only if needed.
7931 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7933 * alloc.c (mark_backtrace): Move decl from here ...
7934 * lisp.h: ... to here, so that it can be checked.
7936 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7937 (Fdefvar): Rewrite so as not to use empty "else".
7938 (lisp_indirect_variable): Name an expression,
7939 to avoid gcc -Wbad-function-cast warning.
7940 (Fdefvar): Rename locals to avoid shadowing.
7942 * callint.c (quotify_arg, quotify_args): Now static.
7943 (Fcall_interactively): Rename locals to avoid shadowing.
7944 Use const pointer when appropriate.
7946 * lisp.h (get_system_name, get_operating_system_release):
7947 Move decls here, to check interfaces.
7948 * process.c (get_operating_system_release): Move decl to lisp.h.
7949 * xrdb.c (get_system_name): Likewise.
7950 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7951 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7952 some of which prompt warnings from gcc -Wbad-function-cast.
7953 (Fformat_time_string, Fencode_time, Finsert_char):
7954 (Ftranslate_region_internal, Fformat):
7955 Rename or remove local vars to avoid shadowing.
7956 (Ftranslate_region_internal): Mark var as initialized.
7958 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7961 * lisp.h (eassert): Check that the argument compiles, even if
7962 ENABLE_CHECKING is not defined.
7964 * data.c (Findirect_variable): Name an expression, to avoid
7965 gcc -Wbad-function-cast warning.
7966 (default_value, arithcompare, arith_driver, arith_error): Now static.
7967 (store_symval_forwarding): Rename local to avoid shadowing.
7968 (Fmake_variable_buffer_local, Fmake_local_variable):
7969 Mark variables as initialized.
7970 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7972 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7973 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7974 Rename locals to avoid shadowing.
7975 (mark_stack): Move local variables into the #ifdef region where
7977 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7978 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7980 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7981 (GC_STRING_CHARS): Remove; not used.
7982 (Fmemory_limit): Cast sbrk's returned value to char *.
7984 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7985 avoids undefined behavior in theory.
7987 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7989 Use functions, not macros, for up- and down-casing (Bug#8254).
7990 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7991 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7992 to use the following functions instead of these macros.
7993 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7994 EMACS_INT, since callers assume the returned value fits in int.
7995 (upcase1): Likewise, for UPCASE_TABLE.
7996 (uppercasep, lowercasep, upcase): New static inline functions.
7997 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7998 the race-condition problem in the old DOWNCASE.
8000 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8001 Rename locals to avoid shadowing.
8002 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8003 (regex_compile, re_search_2, re_match_2_internal):
8004 Remove unused local vars.
8005 (FREE_VAR): Rewrite so as not to use empty "else",
8006 which gcc can warn about.
8007 (regex_compile, re_match_2_internal): Mark locals as initialized.
8008 (RETALLOC_IF): Define only if needed.
8009 (WORDCHAR_P): Likewise. This one is never needed, but is used
8010 only in a comment talking about a compiler bug, so put inside
8011 the #if 0 of that comment.
8012 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8013 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8016 * search.c (boyer_moore): Rename locals to avoid shadowing.
8017 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8018 (PREV_CHAR_BOUNDARY): Likewise.
8020 * search.c (simple_search): Remove unused var.
8022 * dired.c (compile_pattern): Move decl from here ...
8023 * lisp.h: ... to here, so that it can be checked.
8024 (struct re_registers): New forward decl.
8026 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8028 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8030 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8031 Rename locals to avoid shadowing.
8032 (Fvertical_motion): Mark locals as initialized.
8034 * casefiddle.c (casify_object, casify_region): Now static.
8035 (casify_region): Mark local as initialized.
8037 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8039 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8040 New macros, so that the caller can use some names other than
8041 gcpro1, gcpro2, etc.
8042 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8044 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8045 argument, for consistency with GCPRO2_VAR, etc: it is now the
8046 prefix of the variable, not the variable itself. All uses
8048 * dired.c (directory_files_internal, file_name_completion):
8049 Rename locals to avoid shadowing.
8051 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8052 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8053 dired.c's scmp function, had undefined behavior.
8054 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8055 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8056 * buffer.h: ... to here, because these macros use current_buffer,
8057 and the new implementation with inline functions needs to have
8058 current_buffer in scope now, rather than later when the macros
8060 (downcase, upcase1): New static inline functions.
8061 (DOWNCASE, UPCASE1): Reimplement using these functions.
8062 This avoids undefined behavior in expressions like
8063 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8064 from race conditions in accessing the global variables
8065 case_temp1 and case_temp2.
8066 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8067 * lisp.h (case_temp1, case_temp2): Remove their decls.
8068 * character.h (ASCII_CHAR_P): Move from here ...
8069 * lisp.h: ... to here, so that the inline functions mentioned
8072 * dired.c (directory_files_internal_unwind): Now static.
8074 * fileio.c (file_name_as_directory, directory_file_name):
8075 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8077 (file_name_as_directory): Use const pointers when appropriate.
8078 (Fexpand_file_name): Likewise. In particular, newdir might
8079 point at constant storage, so make it a const pointer.
8080 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8081 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8083 (Fset_file_times, Finsert_file_contents, auto_save_error):
8084 Rename locals to avoid shadowing.
8086 * minibuf.c (choose_minibuf_frame_1): Now static.
8087 (Ftry_completion, Fall_completions): Rename or remove locals
8090 * marker.c (bytepos_to_charpos): Remove; unused.
8092 * lisp.h (verify_bytepos, count_markers): New decls,
8093 so that gcc does not warn that these functions aren't declared.
8095 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8096 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8097 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8098 (copy_text): Remove unused local var.
8100 * filelock.c (within_one_second): Now static.
8101 (lock_file_1): Rename local to avoid shadowing.
8103 * buffer.c (fix_overlays_before): Mark locals as initialized.
8104 (fix_start_end_in_overlays): Likewise. This function should be
8105 simplified by using pointers-to-pointers, but that's a different
8107 (switch_to_buffer_1): Now static.
8108 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8109 (report_overlay_modification): Rename locals to avoid shadowing.
8111 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8112 Fix pointer signedness issue.
8113 (sys_subshell): Mark local as volatile if checking for lint,
8114 to suppress a gcc -Wclobbered warning that does not seem to be right.
8115 (MAXPATHLEN): Define only if needed.
8117 * process.c (serial_open, serial_configure): Move decls from here ...
8118 * systty.h: ... to here, so that they can be checked.
8120 * fns.c (get_random, seed_random): Move extern decls from here ...
8121 * lisp.h: ... to here, so that they can be checked.
8123 * sysdep.c (reset_io): Now static.
8124 (wait_for_termination_signal): Remove; unused.
8126 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8127 (copy_keymap_item, append_key, push_text_char_description):
8129 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8130 (DENSE_TABLE_SIZE): Remove; unused.
8131 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8132 (describe_map_tree):
8133 Rename locals to avoid shadowing.
8135 * keyboard.c: Declare functions static if they are not used elsewhere.
8136 (echo_char, echo_dash, cmd_error, top_level_2):
8137 (poll_for_input, handle_async_input): Now static.
8138 (read_char, kbd_buffer_get_event, make_lispy_position):
8139 (make_lispy_event, make_lispy_movement, apply_modifiers):
8140 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8141 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8142 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8143 (read_key_sequence, read_char): Mark locals as initialized.
8144 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8146 * keyboard.h (make_ctrl_char): New decl.
8147 (mark_kboards): Move decl here ...
8148 * alloc.c (mark_kboards): ... from here.
8150 * lisp.h (force_auto_save_soon): New decl.
8152 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8153 (DEFINE_DUMMY_FUNCTION): New macro.
8154 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8156 (main): Add casts to avoid warnings
8157 if GCC considers string literals to be constants.
8159 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8161 * dbusbind.c: Pointer signedness fixes.
8162 (xd_signature, xd_append_arg, xd_initialize):
8163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8164 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8165 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8166 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8168 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8169 if GCC considers string literals to be constants.
8170 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8172 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8174 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8175 (print_preprocess, print_object): New macro to fix last change.
8177 * print.c (print_preprocess): Don't forget font objects.
8179 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8181 * emacs.c (USAGE3): Doc fixes.
8183 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8185 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8188 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8190 * lisp.h (VWindow_system, Qfile_name_history):
8191 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8192 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8193 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8195 * w32select.c: Don't #include "keyboard.h".
8196 (run_protected): Add extern declaration for waiting_for_input.
8198 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8199 * w32console.c (detect_input_pending, read_input_pending)
8200 (encode_terminal_code):
8201 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8202 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8203 (w32_system_caret_y, Qfile_name_history):
8204 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8205 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8206 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8207 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8208 * w32proc.c (Qlocal, report_file_error):
8209 * w32term.c (Vwindow_system, updating_frame):
8210 * w32uniscribe.c (initialized, uniscribe_font_driver):
8211 Remove unneeded extern declarations.
8213 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8215 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8217 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8219 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8220 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8221 These macros can no longer be used for assignment.
8223 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8224 Assign struct members directly, instead of using BUF_BEGV etc.
8225 (record_buffer_markers, fetch_buffer_markers): New functions for
8226 recording and fetching special buffer markers.
8227 (set_buffer_internal_1, set_buffer_temp): Use them.
8229 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8231 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8233 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8234 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8236 * xdisp.c (hscroll_window_tree):
8237 (reconsider_clip_changes): Use PT instead of BUF_PT.
8239 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8241 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8242 $(EMACS_ROOT)/lib/intprops.h.
8244 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8246 Fix more problems found by GCC 4.5.2's static checks.
8248 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8249 to unsigned char * to avoid compiler diagnostic.
8250 (xg_free_frame_widgets): Make it clear that a local variable is
8251 needed only if USE_GTK_TOOLTIP.
8252 (gdk_window_get_screen): Make it clear that this macro is needed
8253 only if USE_GTK_TOOLTIP.
8254 (int_gtk_range_get_value): New function, which avoids a diagnostic
8255 from gcc -Wbad-function-cast.
8256 (xg_set_toolkit_scroll_bar_thumb): Use it.
8257 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8258 diagnostic from gcc -Wbad-function-cast.
8259 (get_utf8_string, xg_get_file_with_chooser):
8260 Rename locals to avoid shadowing.
8261 (create_dialog): Move locals to avoid shadowing.
8263 * xgselect.c (xg_select): Remove unused var.
8265 * image.c (four_corners_best): Mark locals as initialized.
8266 (gif_load): Initialize transparent_p to zero (Bug#8238).
8267 Mark another local as initialized.
8268 (my_png_error, my_error_exit): Mark with NO_RETURN.
8270 * image.c (clear_image_cache): Now static.
8271 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8272 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8273 (x_edge_detection): Remove unnecessary cast that
8274 gcc -Wbad-function-cast diagnoses.
8275 (gif_load): Fix pointer signedness.
8276 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8277 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8279 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8281 Improve quality of tests for time stamp overflow.
8282 For example, without this patch (encode-time 0 0 0 1 1
8283 1152921504606846976) returns the obviously-bogus value (-948597
8284 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8285 reports time overflow. See
8286 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8287 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8288 * editfns.c: Include limits.h and intprops.h.
8289 (TIME_T_MIN, TIME_T_MAX): New macros.
8290 (time_overflow): Move earlier, to before first use.
8291 (hi_time, lo_time): New functions, for an accurate test for
8293 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8294 (Fget_internal_run_time): Don't assume time_t fits in int.
8295 (make_time): Use list2 instead of Fcons twice.
8296 (Fdecode_time): More accurate test for out-of-range times.
8297 (check_tm_member): New function.
8298 (Fencode_time): Use it, to test for out-of-range times.
8299 (lisp_time_argument): Don't rely on undefined left-shift and
8300 right-shift behavior when checking for time stamp overflow.
8302 * editfns.c (time_overflow): New function, refactoring common code.
8303 (Fformat_time_string, Fdecode_time, Fencode_time):
8304 (Fcurrent_time_string): Use it.
8306 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8307 * dired.c (make_time): Move to ...
8308 * editfns.c (make_time): ... here.
8309 * systime.h: Note the move.
8311 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8313 * fringe.c (update_window_fringes): Remove unused variables.
8315 * unexmacosx.c (copy_data_segment): Also copy __got section.
8318 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8320 * termcap.c [MSDOS]: Include "msdos.h".
8321 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8322 Constify `char *' arguments and their references according to
8323 prototypes in tparam.h.
8325 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8327 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8328 Adapt all references accordingly.
8330 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8332 2011-03-11 Tom Tromey <tromey@redhat.com>
8334 * buffer.c (syms_of_buffer): Remove obsolete comment.
8336 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8338 * termhooks.h (encode_terminal_code): Declare prototype.
8340 * msdos.c (encode_terminal_code): Don't declare prototype.
8342 * term.c (encode_terminal_code): Now external again, used by
8343 w32console.c and msdos.c.
8345 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8346 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8348 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8350 Fix some minor problems found by GCC 4.5.2's static checks.
8352 * fringe.c (update_window_fringes): Mark locals as initialized
8354 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8356 * alloc.c (mark_fringe_data): Move decl from here ...
8357 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8358 to check its interface.
8359 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8361 * fontset.c (free_realized_fontset): Now static.
8362 (Fset_fontset_font): Rename local to avoid shadowing.
8363 (fontset_font): Mark local as initialized.
8364 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8366 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8368 * xselect.c (x_disown_buffer_selections): Remove; not used.
8369 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8370 (x_own_selection, Fx_disown_selection_internal): Rename locals
8372 (x_handle_dnd_message): Remove local to avoid shadowing.
8374 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8375 so that the caller can use some name other than gcpro1.
8376 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8377 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8378 (Fx_backspace_delete_keys_p):
8379 Use them to avoid shadowing, and rename vars to avoid shadowing.
8380 (x_decode_color, x_set_name, x_window): Now static.
8381 (Fx_create_frame): Add braces to silence GCC warning.
8382 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8383 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8384 Remove unused locals.
8385 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8386 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8387 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8390 * xterm.h (x_mouse_leave): New decl.
8392 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8393 Remove unused functions.
8394 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8395 (x_calc_absolute_position): Now static.
8396 (XTread_socket): Don't define label "out" unless it's used.
8397 Don't declare local "event" unless it's used.
8398 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8399 unless they are used.
8400 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8401 (x_fatal_error_signal): Remove; not used.
8402 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8403 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8404 (x_error_catcher, x_connection_closed, x_error_handler):
8405 (x_error_quitter, xembed_send_message, x_iconify_frame):
8406 (my_log_handler): Rename locals to avoid shadowing.
8407 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8408 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8410 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8411 Rename or move locals to avoid shadowing.
8412 (tty_defined_color, merge_face_heights): Now static.
8413 (free_realized_faces_for_fontset): Remove; not used.
8414 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8415 does not deduce is never used uninitialized.
8416 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8417 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8419 * terminal.c (store_terminal_param): Now static.
8421 * xmenu.c (menu_highlight_callback): Now static.
8422 (set_frame_menubar): Remove unused local.
8423 (xmenu_show): Rename parameter to avoid shadowing.
8424 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8425 since they might point to immutable storage.
8426 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8427 since it's unused otherwise.
8429 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8430 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8431 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8432 avoids a gcc -Wuninitialized diagnostic.
8433 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8434 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8435 does not deduce are never used uninitialized.
8437 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8439 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8440 * window.c (window_loop, size_window):
8441 (run_window_configuration_change_hook, enlarge_window): Likewise.
8443 * window.c (display_buffer): Now static.
8444 (size_window): Mark variables that gcc -Wuninitialized
8445 does not deduce are never used uninitialized.
8446 * window.h (check_all_windows): New decl, to forestall
8447 gcc -Wmissing-prototypes diagnostic.
8448 * dispextern.h (bidi_dump_cached_states): Likewise.
8450 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8452 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8454 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8455 and to avoid gcc -Wuninitialized warning.
8456 (load_charset_map): Mark variables that gcc -Wuninitialized
8457 does not deduce are never used uninitialized.
8458 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8460 * coding.c (coding_set_source, coding_set_destination):
8461 Use "else { /* comment */ }" rather than "else /* comment */;"
8462 for clarity, and to avoid gcc -Wempty-body warning.
8463 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8464 a block, when the outer 'i' will do.
8465 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8466 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8467 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8468 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8469 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8470 Rename locals to avoid shadowing.
8471 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8472 * coding.c (emacs_mule_char, encode_invocation_designation):
8473 Now static, since they're not used elsewhere.
8474 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8475 (decode_coding_object, encode_coding_object, detect_coding_system):
8476 (decode_coding_emacs_mule): Mark variables that gcc
8477 -Wuninitialized does not deduce are never used uninitialized.
8478 (detect_coding_iso_2022): Initialize a local variable that might
8479 be used uninitialized. Leave a FIXME because it's not clear that
8480 this initialization is needed. (Bug#8211)
8481 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8482 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8483 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8484 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8485 Remove unused macros.
8487 * category.c (hash_get_category_set): Remove unused local var.
8488 (copy_category_table): Now static, since it's not used elsewhere.
8489 * character.c (string_count_byte8): Likewise.
8491 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8492 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8494 * chartab.c (copy_sub_char_table): Now static, since it's not used
8496 (sub_char_table_ref_and_range, char_table_ref_and_range):
8497 Rename locals to avoid shadowing.
8498 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8500 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8501 (BIDI_BOB): Remove unused macro.
8503 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8504 deduce are never used uninitialized.
8505 * term.c (encode_terminal_code): Likewise.
8507 * term.c (encode_terminal_code): Now static. Remove unused local.
8509 * tparam.h: New file.
8510 * term.c, tparam.h: Include it.
8511 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8512 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8513 Move these decls to tparam.h, and make them agree with what
8514 is actually in tparam.c. The previous trick of using incompatible
8515 decls in different modules does not conform to the C standard.
8516 All callers of tparam changed to use tparam's actual API.
8517 * tparam.c (tparam1, tparam, tgoto):
8518 Use const pointers where appropriate.
8520 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8521 * cm.h (struct cm): Likewise.
8522 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8523 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8524 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8525 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8526 (turn_on_face, init_tty): Likewise.
8527 * termchar.h (struct tty_display_info): Likewise.
8529 * term.c (term_mouse_position): Rename local to avoid shadowing.
8531 * alloc.c (mark_ttys): Move decl from here ...
8532 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8534 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8536 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8538 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8540 * search.c (compile_pattern_1): Remove argument regp, unused since
8541 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8542 (compile_pattern): Don't pass it.
8544 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8546 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8547 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8549 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8551 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8553 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8554 gdk_window_get_screen, gdk_window_get_geometry,
8555 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8556 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8557 (xg_get_pixbuf_from_pixmap): New function.
8558 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8559 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8560 Call xg_get_pixbuf_from_pixmap instead of
8561 gdk_pixbuf_get_from_drawable.
8562 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8563 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8564 (xg_check_special_colors): Use GtkStyleContext and its functions
8566 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8567 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8568 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8569 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8570 Call gtk_widget_get_preferred_size.
8571 (xg_frame_resized): gdk_window_get_geometry only takes 5
8573 (xg_win_to_widget, xg_event_is_for_menubar):
8574 Call gdk_x11_window_lookup_for_display.
8575 (xg_set_widget_bg): New function.
8576 (delete_cb): New function.
8577 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8578 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8579 (xg_set_background_color): Call xg_set_widget_bg.
8580 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8581 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8582 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8583 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8585 (update_frame_tool_bar): Call gtk_widget_hide.
8586 (xg_initialize): Use GDK_KEY_g.
8588 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8590 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8592 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8593 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8594 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8596 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8598 * w32xfns.c (select_palette): Check success of RealizePalette against
8599 GDI_ERROR, not zero.
8601 See ChangeLog.11 for earlier changes.
8607 Copyright (C) 2011 Free Software Foundation, Inc.
8609 This file is part of GNU Emacs.
8611 GNU Emacs is free software: you can redistribute it and/or modify
8612 it under the terms of the GNU General Public License as published by
8613 the Free Software Foundation, either version 3 of the License, or
8614 (at your option) any later version.
8616 GNU Emacs is distributed in the hope that it will be useful,
8617 but WITHOUT ANY WARRANTY; without even the implied warranty of
8618 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8619 GNU General Public License for more details.
8621 You should have received a copy of the GNU General Public License
8622 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.