| blob | 7a9a33fc2ccc20149dedc368857285c6b454f18d |
1 ;;; checkdoc.el --- check documentation strings for style requirements
3 ;; Copyright (C) 1997-1998, 2001-2012 Free Software Foundation, Inc.
5 ;; Author: Eric M. Ludlam <zappo@gnu.org>
6 ;; Version: 0.6.2
7 ;; Keywords: docs, maint, lisp
9 ;; This file is part of GNU Emacs.
11 ;; GNU Emacs is free software: you can redistribute it and/or modify
12 ;; it under the terms of the GNU General Public License as published by
13 ;; the Free Software Foundation, either version 3 of the License, or
14 ;; (at your option) any later version.
16 ;; GNU Emacs is distributed in the hope that it will be useful,
17 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
18 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19 ;; GNU General Public License for more details.
21 ;; You should have received a copy of the GNU General Public License
22 ;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
24 ;;; Commentary:
25 ;;
26 ;; The Emacs Lisp manual has a nice chapter on how to write
27 ;; documentation strings. Many stylistic suggestions are fairly
28 ;; deterministic and easy to check for syntactically, but also easy
29 ;; to forget. The main checkdoc engine will perform the stylistic
30 ;; checks needed to make sure these styles are remembered.
31 ;;
32 ;; There are two ways to use checkdoc:
33 ;; 1) Periodically use `checkdoc' or `checkdoc-current-buffer'.
34 ;; `checkdoc' is a more interactive version of
35 ;; `checkdoc-current-buffer'
36 ;; 2) Use `checkdoc-minor-mode' to automatically check your
37 ;; documentation whenever you evaluate Lisp code with C-M-x
38 ;; or [menu-bar emacs-lisp eval-buffer]. Additional key-bindings
39 ;; are also provided under C-c ? KEY
40 ;; (require 'checkdoc)
41 ;; (add-hook 'emacs-lisp-mode-hook 'checkdoc-minor-mode)
42 ;;
43 ;; Using `checkdoc':
44 ;;
45 ;; The commands `checkdoc' and `checkdoc-ispell' are the top-level
46 ;; entry points to all of the different checks that are available. It
47 ;; breaks examination of your Lisp file into four sections (comments,
48 ;; documentation, messages, and spacing) and indicates its current
49 ;; state in a status buffer.
50 ;;
51 ;; The Comments check examines your headers, footers, and
52 ;; various tags (such as "Code:") to make sure that your code is ready
53 ;; for easy integration into existing systems.
54 ;;
55 ;; The Documentation check deals with documentation strings
56 ;; and their elements that help make Emacs easier to use.
57 ;;
58 ;; The Messages check ensures that the strings displayed in the
59 ;; minibuffer by some commands (such as `error' and `y-or-n-p')
60 ;; are consistent with the Emacs environment.
61 ;;
62 ;; The Spacing check cleans up white-space at the end of lines.
63 ;;
64 ;; The interface while working with documentation and messages is
65 ;; slightly different when being run in the interactive mode. The
66 ;; interface offers several options, including the ability to skip to
67 ;; the next error, or back up to previous errors. Auto-fixing is
68 ;; turned off at this stage, but you can use the `f' or `F' key to fix
69 ;; a given error (if the fix is available.)
70 ;;
71 ;; Auto-fixing:
72 ;;
73 ;; There are four classifications of style errors in terms of how
74 ;; easy they are to fix. They are simple, complex, really complex,
75 ;; and impossible. (Impossible really means that checkdoc does not
76 ;; have a fixing routine yet.) Typically white-space errors are
77 ;; classified as simple, and are auto-fixed by default. Typographic
78 ;; changes are considered complex, and the user is asked if they want
79 ;; the problem fixed before checkdoc makes the change. These changes
80 ;; can be done without asking if `checkdoc-autofix-flag' is properly
81 ;; set. Potentially redundant changes are considered really complex,
82 ;; and the user is always asked before a change is inserted. The
83 ;; variable `checkdoc-autofix-flag' controls how these types of errors
84 ;; are fixed.
85 ;;
86 ;; Spell checking text:
87 ;;
88 ;; The variable `checkdoc-spellcheck-documentation-flag' can be set
89 ;; to customize how spell checking is to be done. Since spell
90 ;; checking can be quite slow, you can optimize how best you want your
91 ;; checking done. The default is `defun', which spell checks each time
92 ;; `checkdoc-defun' or `checkdoc-eval-defun' is used. Setting to nil
93 ;; prevents spell checking during normal usage.
94 ;; Setting this variable to nil does not mean you cannot take
95 ;; advantage of the spell checking. You can instead use the
96 ;; interactive functions `checkdoc-ispell-*' to check the spelling of
97 ;; your documentation.
98 ;; There is a list of Lisp-specific words which checkdoc will
99 ;; install into Ispell on the fly, but only if Ispell is not already
100 ;; running. Use `ispell-kill-ispell' to make checkdoc restart it with
101 ;; these words enabled.
102 ;;
103 ;; Checking parameters:
104 ;;
105 ;; You might not always want a function to have its parameters listed
106 ;; in order. When this is the case, put the following comment just in
107 ;; front of the documentation string: "; checkdoc-order: nil" This
108 ;; overrides the value of `checkdoc-arguments-in-order-flag'.
109 ;;
110 ;; If you specifically wish to avoid mentioning a parameter of a
111 ;; function in the doc string (such as a hidden parameter, or a
112 ;; parameter which is very obvious like events), you can have checkdoc
113 ;; skip looking for it by putting the following comment just in front
114 ;; of the documentation string: "; checkdoc-params: (args go here)"
115 ;;
116 ;; Checking message strings:
117 ;;
118 ;; The text that follows the `error' and `y-or-n-p' commands is
119 ;; also checked. The documentation for `error' clearly states some
120 ;; simple style rules to follow which checkdoc will auto-fix for you.
121 ;; `y-or-n-p' also states that it should end in a space. I added that
122 ;; it should end in "? " since that is almost always used.
123 ;;
124 ;; Adding your own checks:
125 ;;
126 ;; You can experiment with adding your own checks by setting the
127 ;; hooks `checkdoc-style-hooks' and `checkdoc-comment-style-hooks'.
128 ;; Return a string which is the error you wish to report. The cursor
129 ;; position should be preserved.
130 ;;
131 ;; Error errors:
132 ;;
133 ;; Checkdoc does not always flag errors correctly. There are a
134 ;; couple ways you can coax your file into passing all of checkdoc's
135 ;; tests through buffer local variables.
136 ;;
137 ;; The variable `checkdoc-verb-check-experimental-flag' can be used
138 ;; to turn off the check for verb-voice in case you use words that are
139 ;; not semantically verbs, but are still in the incomplete list.
140 ;;
141 ;; The variable `checkdoc-symbol-words' can be a list of words that
142 ;; happen to also be symbols. This is not a problem for one-word
143 ;; symbols, but if you use a hyphenated word that is also a symbol,
144 ;; then you may need this.
145 ;;
146 ;; The symbol `checkdoc-force-docstrings-flag' can be set to nil if
147 ;; you have many undocumented functions you don't wish to document.
148 ;;
149 ;; See the above section "Checking Parameters" for details about
150 ;; parameter checking.
151 ;;
152 ;; Dependencies:
153 ;;
154 ;; This file requires lisp-mnt (Lisp maintenance routines) for the
155 ;; comment checkers.
156 ;;
157 ;; Requires custom for Emacs v20.
159 ;;; TO DO:
160 ;; Hook into the byte compiler on a defun/defvar level to generate
161 ;; warnings in the byte-compiler's warning/error buffer.
162 ;; Better ways to override more typical `eval' functions. Advice
163 ;; might be good but hard to turn on/off as a minor mode.
164 ;;
165 ;;; Maybe Do:
166 ;; Code sweep checks for "forbidden functions", proper use of hooks,
167 ;; proper keybindings, and other items from the manual that are
168 ;; not specifically docstring related. Would this even be useful?
170 ;;; Code:
181 "Support for doc string checking in Emacs Lisp."
187 "String to display in mode line when Checkdoc mode is enabled; nil for none."
193 "Non-nil means attempt auto-fixing of doc strings.
194 If this value is the symbol `query', then the user is queried before
195 any change is made. If the value is `automatic', then all changes are
196 made without asking unless the change is very-complex. If the value
197 is `semiautomatic' or any other value, then simple fixes are made
198 without asking, and complex changes are made by asking the user first.
199 The value `never' is the same as nil, never ask or change anything."
208 Setting this to nil will silently make fixes that require no user
209 interaction. See `checkdoc-autofix-flag' for auto-fixing details."
214 "Non-nil means that all checkable definitions should have documentation.
215 Style guide dictates that interactive functions MUST have documentation,
216 and that it's good but not required practice to make non user visible items
217 have doc strings."
220 ;;;###autoload(put 'checkdoc-force-docstrings-flag 'safe-local-variable 'booleanp)
223 "Non-nil means that files should have a History section or ChangeLog file.
224 This helps document the evolution of, and recent changes to, the package."
227 ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp)
230 "Non-nil means the first line of a docstring may end with a comma.
231 Ordinarily, a full sentence is required. This may be misleading when
232 there is a substantial caveat to the one-line description -- the comma
233 should be used when the first part could stand alone as a sentence, but
234 it indicates that a modifying clause follows."
237 ;;;###autoload(put 'checkdoc-permit-comma-termination-flag 'safe-local-variable 'booleanp)
240 "Non-nil means run Ispell on text based on value.
241 This is automatically set to nil if Ispell does not exist on your
242 system. Possible values are:
244 nil - Don't spell-check during basic style checks.
245 defun - Spell-check when style checking a single defun
246 buffer - Spell-check when style checking the whole buffer
247 interactive - Spell-check during any interactive check.
248 t - Always spell-check"
262 Any more than this and a warning is generated suggesting that the construct
268 "Non-nil means warn if arguments appear out of order.
269 Setting this to nil will mean only checking that all the arguments
270 appear in the proper form in the documentation, not that they are in
271 the same order as they appear in the argument list. No mention is
272 made in the style guide relating to order."
275 ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp)
278 "Hooks called after the standard style check is completed.
279 All hooks must return nil or a string representing the error found.
280 Useful for adding new user implemented commands.
282 Each hook is called with two parameters, (DEFUNINFO ENDPOINT).
283 DEFUNINFO is the return value of `checkdoc-defun-info'. ENDPOINT is the
287 "Hooks called after the standard comment style check is completed.
288 Must return nil if no errors are found, or a string describing the
297 "Regular expression used to identify a defun.
301 "Non-nil means to attempt to check the voice of the doc string.
302 This check keys off some words which are commonly misused. See the
303 variable `checkdoc-common-verbs-wrong-voice' if you wish to add your own."
308 "Non-nil means generate warnings in a buffer for browsing.
309 Do not set this by hand, use a function like `checkdoc-current-buffer'
313 "A list of symbol names (strings) which also happen to make good words.
314 These words are ignored when unquoted symbols are searched for.
315 This should be set in an Emacs Lisp file's local variables."
318 ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p)
320 ;;;###autoload
322 ;; this is a function so it might be shared by checkdoc-proper-noun-list
323 ;; and/or checkdoc-ispell-lisp-words in the future
332 ;; "[.!?]" is for noun at end of a sentence, since those chars
333 ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
334 ;; The \" allows it to be the last sentence in a docstring too.
423 )
424 "Alist of common words in the wrong voice and what should be used instead.
425 Set `checkdoc-verb-check-experimental-flag' to nil to avoid this costly
426 and experimental check. Do not modify this list without setting
427 the value of `checkdoc-common-verbs-regexp' to nil which cause it to
432 ;; When dealing with syntax in doc strings, make sure that - are
433 ;; encompassed in words so we can use cheap \\> to get the end of a symbol,
434 ;; not the end of a word in a conglomerate.
436 st)
439 ;;; Compatibility
440 ;;
456 ;;; User level commands
457 ;;
458 ;;;###autoload
460 "Interactively check the entire buffer for style errors.
461 The current status of the check will be displayed in a buffer which
462 the users will view as each check is completed."
468 ;; if the user set autofix to never, then that breaks the
469 ;; obviously requested asking implied by using this function.
470 ;; Set it to paranoia level.
473 'query
474 checkdoc-autofix-flag))
475 tmp)
477 ;; check the comments
485 ;; Check the documentation
492 ;; Check the message text
498 ;; Rogue spacing
507 "Display and update the status buffer for the current checkdoc mode.
508 CHECK is a list of four strings stating the current status of each
509 test; the nth string describes the status of the nth test."
522 ;;;###autoload
524 "Interactively check the current buffer for doc string errors.
525 Prefix argument START-HERE will start the checking from the current
526 point, otherwise the check starts at the beginning of the current
527 buffer. Allows navigation forward and backwards through document
528 errors. Does not check for comment or space warnings.
529 Optional argument SHOWSTATUS indicates that we should update the
530 checkdoc status window instead of the usual behavior."
536 ;; Due to a design flaw, this will never spell check
537 ;; docstrings.
540 ;; This is a workaround to perform spell checking.
543 ;;;###autoload
545 "Interactively check the current buffer for message string errors.
546 Prefix argument START-HERE will start the checking from the current
547 point, otherwise the check starts at the beginning of the current
548 buffer. Allows navigation forward and backwards through document
549 errors. Does not check for comment or space warnings.
550 Optional argument SHOWSTATUS indicates that we should update the
551 checkdoc status window instead of the usual behavior."
557 ;; Due to a design flaw, this will never spell check messages.
560 ;; This is a workaround to perform spell checking.
564 "Interactively loop over all errors that can be found by a given method.
566 If START-HERE is nil, searching starts at the beginning of the current
567 buffer, otherwise searching starts at START-HERE. SHOWSTATUS
568 expresses the verbosity of the search, and whether ending the search
569 will auto-exit this function.
571 FINDFUNC is a symbol representing a function that will position the
572 cursor, and return error message text to present to the user. It is
573 assumed that the cursor will stop just before a major sexp, which will
574 be highlighted to present the user with feedback as to the offending
575 style."
576 ;; Determine where to start the test
579 ;; Assign a flag to spellcheck flag
583 ;; Fetch the error list
587 c)
590 ;; Include whatever function point is in for good measure.
594 ;; The cursor should be just in front of the offending doc string
605 ;; Make sure the whole doc string is visible if possible.
629 ;; Exit condition
631 ;; Request an auto-fix
636 ;; `automatic-then-never' tells the autofix function
637 ;; to only allow one fix to be automatic. The autofix
638 ;; function will then set the flag to 'never, allowing
639 ;; the checker to return a different error.
661 ;; Move to the next error (if available)
667 err-list nil)
673 ;; Go backwards in the list of errors
682 ;; Edit the buffer recursively.
693 err-list nil)
697 ;; Quit checkdoc
700 err-list nil
702 ;; Goofy stuff
713 ""
715 "f, y - auto Fix this warning without asking (if\
718 )
730 returnme))
733 "Interactively spell check doc strings in the current buffer.
734 If START-HERE is nil, searching starts at the beginning of the current
735 buffer, otherwise searching starts at START-HERE."
738 ;; Move point to where we need to start.
740 ;; Include whatever function point is in for good measure.
743 ;; Loop over docstrings.
753 "Interactively spell check messages in the current buffer.
754 If START-HERE is nil, searching starts at the beginning of the current
755 buffer, otherwise searching starts at START-HERE."
758 ;; Move point to where we need to start.
760 ;; Include whatever function point is in for good measure.
763 ;; Loop over message strings.
774 "Find and return the next checkdoc error list, or nil.
775 Only documentation strings are checked.
776 An error list is of the form (WARNING . POSITION) where WARNING is the
777 warning text, and POSITION is the point in the buffer where the error
778 was found. We can use points and not markers because we promise not
779 to edit the buffer before point without re-executing this check.
780 Argument ENABLE-FIX will enable auto-fixing while looking for the next
781 error. This argument assumes that the cursor is already positioned to
782 perform the fix."
793 ;; Quit.. restore position, Other errors, leave alone
795 msg)))
798 "Find and return the next checkdoc message related error list, or nil.
799 Only text for error and `y-or-n-p' strings are checked. See
800 `checkdoc-next-error' for details on the return value.
801 Argument ENABLE-FIX turns on the auto-fix feature. This argument
802 assumes that the cursor is already positioned to perform the fix."
815 ;; Quit.. restore position, Other errors, leave alone
817 msg)))
820 "Enter recursive edit to permit a user to fix some error checkdoc has found.
821 MSG is the error that was found, which is displayed in a help buffer."
836 ;;;###autoload
838 "Evaluate and check documentation for the current buffer.
839 Evaluation is done first because good documentation for something that
840 doesn't work is just not useful. Comments, doc strings, and rogue
841 spacing are all verified."
846 ;;;###autoload
848 "Check current buffer for document, comment, error style, and rogue spaces.
849 With a prefix argument (in Lisp, the argument TAKE-NOTES),
850 store all errors found in a warnings buffer,
851 otherwise stop after the first error."
855 ;; Assign a flag to spellcheck flag
860 checkdoc-autofix-flag))
865 ;; every test is responsible for returning the cursor.
875 ;;;###autoload
877 "Start scanning the current buffer for documentation string style errors.
878 Only documentation strings are checked.
879 Use `checkdoc-continue' to continue checking if an error cannot be fixed.
880 Prefix argument TAKE-NOTES means to collect all the warning messages into
881 a separate buffer."
888 ;; Go back since we can't be here without success above.
890 nil))
892 ;;;###autoload
894 "Find the next doc string in the current buffer which has a style error.
895 Prefix argument TAKE-NOTES means to continue through the whole buffer and
896 save warnings in a separate buffer. Second optional argument START-POINT
897 is the starting location. If this is nil, `point-min' is used instead."
900 ;; Assign a flag to spellcheck flag
905 checkdoc-autofix-flag))
909 ;; If we are taking notes, encompass the whole buffer, otherwise
910 ;; the user is navigating down through the buffer.
912 ;; OK, let's look at the doc string.
925 "Move to the next doc string after point, and return t.
926 Return nil if there are no more doc strings."
928 nil
929 ;; search drops us after the identifier. The next sexp is either
930 ;; the argument list or the value of the variable. skip it.
933 t))
935 ;;;###autoload
937 "Find missing comment sections in the current Emacs Lisp file.
938 Prefix argument TAKE-NOTES non-nil means to save warnings in a
939 separate buffer. Otherwise print a message. This returns the error
940 if there is one."
954 e))
956 ;;;###autoload
958 "Find extra spaces at the end of lines in the current file.
959 Prefix argument TAKE-NOTES non-nil means to save warnings in a
960 separate buffer. Otherwise print a message. This returns the error
961 if there is one.
962 Optional argument INTERACT permits more interactive fixing."
970 e
976 ;;;###autoload
978 "Scan the buffer for occurrences of the error function, and verify text.
979 Optional argument TAKE-NOTES causes all errors to be logged."
988 e
996 ;;;###autoload
998 "Evaluate the current form with `eval-defun' and check its documentation.
999 Evaluation is done first so the form will be read before the
1000 documentation is checked. If there is a documentation error, then the display
1001 of what was evaluated will be overwritten by the diagnostic message."
1006 ;;;###autoload
1008 "Examine the doc string of the function or variable under point.
1009 Call `error' if the doc string has problems. If NO-ERROR is
1010 non-nil, then do not call error, but call `message' instead.
1011 If the doc string passes the test, then check the function for rogue white
1012 space at the end of each line."
1017 ;; I found this more annoying than useful.
1018 ;;(if (not no-error)
1019 ;; (message "Cannot check this sexp's doc string."))
1020 nil
1021 ;; search drops us after the identifier. The next sexp is either
1022 ;; the argument list or the value of the variable. skip it.
1046 ;;; Ispell interface for forcing a spell check
1047 ;;
1049 ;;;###autoload
1051 "Check the style and spelling of everything interactively.
1052 Calls `checkdoc' with spell-checking turned on.
1053 Prefix argument TAKE-NOTES is the same as for `checkdoc'"
1058 ;;;###autoload
1060 "Check the style and spelling of the current buffer.
1061 Calls `checkdoc-current-buffer' with spell-checking turned on.
1062 Prefix argument TAKE-NOTES is the same as for `checkdoc-current-buffer'"
1067 ;;;###autoload
1069 "Check the style and spelling of the current buffer interactively.
1070 Calls `checkdoc-interactive' with spell-checking turned on.
1071 Prefix argument TAKE-NOTES is the same as for `checkdoc-interactive'"
1076 ;;;###autoload
1078 "Check the style and spelling of message text interactively.
1079 Calls `checkdoc-message-interactive' with spell-checking turned on.
1080 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-interactive'"
1085 ;;;###autoload
1087 "Check the style and spelling of message text interactively.
1088 Calls `checkdoc-message-text' with spell-checking turned on.
1089 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-text'"
1094 ;;;###autoload
1096 "Check the style and spelling of the current buffer.
1097 Calls `checkdoc-start' with spell-checking turned on.
1098 Prefix argument TAKE-NOTES is the same as for `checkdoc-start'"
1103 ;;;###autoload
1105 "Check the style and spelling of the current buffer after point.
1106 Calls `checkdoc-continue' with spell-checking turned on.
1107 Prefix argument TAKE-NOTES is the same as for `checkdoc-continue'"
1112 ;;;###autoload
1114 "Check the style and spelling of the current buffer's comments.
1115 Calls `checkdoc-comments' with spell-checking turned on.
1116 Prefix argument TAKE-NOTES is the same as for `checkdoc-comments'"
1121 ;;;###autoload
1123 "Check the style and spelling of the current defun with Ispell.
1124 Calls `checkdoc-defun' with spell-checking turned on.
1125 Prefix argument TAKE-NOTES is the same as for `checkdoc-defun'"
1130 ;;; Error Management
1131 ;;
1132 ;; Errors returned from checkdoc functions can have various
1133 ;; features and behaviors, so we need some ways of specifying
1134 ;; them, and making them easier to use in the wacked-out interfaces
1135 ;; people are requesting
1137 "Used to create the return error text returned from all engines.
1138 TEXT is the descriptive text of the error. START and END define the region
1139 it is sensible to highlight when describing the problem.
1140 Optional argument UNFIXABLE means that the error has no auto-fix available.
1142 A list of the form (TEXT START END UNFIXABLE) is returned if we are not
1143 generating a buffered list of errors."
1146 nil)
1150 "Return the text specified in the checkdoc ERR."
1151 ;; string-p part is for backwards compatibility
1155 "Return the start point specified in the checkdoc ERR."
1156 ;; string-p part is for backwards compatibility
1160 "Return the end point specified in the checkdoc ERR."
1161 ;; string-p part is for backwards compatibility
1165 "Return the t if we cannot autofix the error specified in the checkdoc ERR."
1166 ;; string-p part is for backwards compatibility
1169 ;;; Minor Mode specification
1170 ;;
1175 ;; Override some bindings
1181 ;; Add some new bindings under C-c ?
1199 ;; bind our submap into map
1201 map)
1204 ;; Add in a menubar with easy-menu
1207 nil checkdoc-minor-mode-map "Checkdoc Minor Mode Menu"
1213 "---"
1222 checkdoc-ispell-message-interactive t]
1227 buffer-file-name]
1229 "---"
1234 ))
1235 ;; XEmacs requires some weird stuff to add this menu in a minor mode.
1236 ;; What is it?
1238 ;;;###autoload
1240 "Toggle automatic docstring checking (Checkdoc minor mode).
1241 With a prefix argument ARG, enable Checkdoc minor mode if ARG is
1242 positive, and disable it otherwise. If called from Lisp, enable
1243 the mode if ARG is omitted or nil.
1245 In Checkdoc minor mode, the usual bindings for `eval-defun' which is
1246 bound to \\<checkdoc-minor-mode-map>\\[checkdoc-eval-defun] and `checkdoc-eval-current-buffer' are overridden to include
1247 checking of documentation strings.
1250 nil checkdoc-minor-mode-string nil
1253 ;;; Subst utils
1254 ;;
1256 "Run hooks in HOOKVAR with ARGS."
1259 ;; This method was similar to above. We ignore the warning
1260 ;; since we will use the above for future Emacs versions
1264 "Rebuild the contents of `checkdoc-common-verbs-regexp'."
1272 ;; Profiler says this is not yet faster than just calling assoc
1273 ;;(defun checkdoc-word-in-alist-vector (word vector)
1274 ;; "Check to see if WORD is in the car of an element of VECTOR.
1275 ;;VECTOR must be sorted. The CDR should be a replacement. Since the
1276 ;;word list is getting bigger, it is time for a quick bisecting search."
1277 ;; (let ((max (length vector)) (min 0) i
1278 ;; (found nil) (fw nil))
1279 ;; (setq i (/ max 2))
1280 ;; (while (and (not found) (/= min max))
1281 ;; (setq fw (car (aref vector i)))
1282 ;; (cond ((string= word fw) (setq found (cdr (aref vector i))))
1283 ;; ((string< word fw) (setq max i))
1284 ;; (t (setq min i)))
1285 ;; (setq i (/ (+ max min) 2))
1286 ;; )
1287 ;; found))
1289 ;;; Checking engines
1290 ;;
1292 "Return a message string if the current doc string is invalid.
1293 Check for style only, such as the first line always being a complete
1294 sentence, whitespace restrictions, and making sure there are no
1295 hard-coded key-codes such as C-[char] or mouse-[number] in the comment.
1296 See the style guide in the Emacs Lisp manual for more details."
1298 ;; Jump over comments between the last object and the doc string
1307 err
1308 ;; * Every command, function, or variable intended for users to know
1309 ;; about should have a documentation string.
1310 ;;
1311 ;; * An internal variable or subroutine of a Lisp program might as well
1312 ;; have a documentation string. In earlier Emacs versions, you could
1313 ;; save space by using a comment instead of a documentation string,
1314 ;; but that is no longer the case.
1319 ;; Sometimes old code has comments where the documentation should
1320 ;; be. Let's see if we can find the comment, and offer to turn it
1321 ;; into documentation for them.
1337 ;; Our point is at the beginning of the comment!
1338 ;; Insert a quote, then remove the comment chars.
1357 ;; quote any double-quote characters in the comment.
1363 "You should convert this comment to documentation"
1367 "All interactive functions should have documentation"
1368 "All variables and subroutines might as well have a \
1374 err)))
1377 "Return an error list or string if the current doc string is invalid.
1378 Depends on `checkdoc-this-string-valid' to reset the syntax table so that
1379 regexp short cuts work. FP is the function defun information."
1381 ;; Use a marker so if an early check modifies the text,
1382 ;; we won't accidentally lose our place. This could cause
1383 ;; end-of doc string whitespace to also delete the " char.
1389 ;; * *Do not* indent subsequent lines of a documentation string so that
1390 ;; the text is lined up in the source code with the text of the first
1391 ;; line. This looks nice in the source code, but looks bizarre when
1392 ;; users view the documentation. Remember that the indentation
1393 ;; before the starting double-quote is not part of the string!
1401 "Remove this whitespace? "
1403 nil
1405 "Second line should not have indentation"
1408 ;; * Check for '(' in column 0.
1413 "Escape this '('? "
1415 nil
1417 "Open parenthesis in column 0 should be escaped"
1419 ;; * Do not start or end a documentation string with whitespace.
1432 nil
1434 "Documentation strings should not start or end with whitespace"
1435 start end))))
1436 ;; * The first line of the documentation string should consist of one
1437 ;; or two complete sentences that stand on their own as a summary.
1438 ;; `M-x apropos' displays just the first line, and if it doesn't
1439 ;; stand on its own, the result looks bad. In particular, start the
1440 ;; first line with a capital letter and end with a period.
1448 ;; A backslashed double quote at the end of a sentence
1450 ;; We might have to add a period in this case
1453 nil
1458 nil
1460 "First sentence should end with punctuation"
1463 ;; These are ok
1464 nil)
1466 nil)
1468 ;; If it is not a complete sentence, let's see if we can
1469 ;; predict a clever way to make it one.
1474 ;; Here we have found a complete sentence, but no break.
1477 "First line not a complete sentence. Add RET here? "
1488 ;; We can merge these lines! Replace this CR
1489 ;; with a space.
1492 ;; Let's see if there is enough room to draw the next
1493 ;; line's sentence up here. I often get hit w/
1494 ;; auto-fill moving my words around.
1504 "1st line not a complete sentence. Join these lines? "
1507 ;; They said yes. We have more fill work to do...
1516 ;; Continuation of above. Make sure our sentence is capitalized.
1523 t)
1524 nil
1526 "First line should be capitalized"
1528 nil))
1529 ;; * Don't write key sequences directly in documentation strings.
1530 ;; Instead, use the `\\[...]' construct to stand for them.
1535 ;; Find the first key sequence not in a sample
1545 ;; It is not practical to use `\\[...]' very many times, because
1546 ;; display of the documentation string will become slow. So use this
1547 ;; to describe the most important commands in your major mode, and
1548 ;; then use `\\{...}' to display the rest of the mode's keymap.
1556 ;; Ambiguous quoted symbol. When a symbol is both bound and fbound,
1557 ;; and is referred to in documentation, it should be prefixed with
1558 ;; something to disambiguate it. This check must be before the
1559 ;; 80 column check because it will probably break that.
1577 ;; We didn't actually replace anything. Here we find
1578 ;; out what special word form they wish to use as
1579 ;; a prefix.
1582 "Disambiguating Keyword (default variable): "
1594 nil)))
1595 ;; * Format the documentation string so that it fits in an
1596 ;; Emacs window on an 80-column screen. It is a good idea
1597 ;; for most lines to be no wider than 60 characters. The
1598 ;; first line can be wider if necessary to fit the
1599 ;; information that ought to be there.
1608 eol t))
1614 "Some lines are over 80 columns wide"
1616 ;; Here we deviate to tests based on a variable or function.
1617 ;; We must do this before checking for symbols in quotes because there
1618 ;; is a chance that just such a symbol might really be an argument.
1620 ;; This is if we are in a variable
1622 ;; * The documentation string for a variable that is a
1623 ;; yes-or-no flag should start with words such as Non-nil
1624 ;; means..., to make it clear that all non-`nil' values are
1625 ;; equivalent and indicate explicitly what `nil' and non-`nil'
1626 ;; mean.
1627 ;; * If a user option variable records a true-or-false
1628 ;; condition, give it a name that ends in `-flag'.
1630 ;; If the variable has -flag in the name, make sure
1634 "Flag variable doc strings should usually start: Non-nil means"
1636 ;; Don't rename variable to "foo-flag". This is unnecessary
1637 ;; and such names often end up inconvenient when the variable
1638 ;; is later expanded to non-boolean values. --Stef
1639 ;; If the doc string starts with "Non-nil means"
1640 ;; (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
1641 ;; (not (string-match "-flag$" (car fp))))
1642 ;; (let ((newname
1643 ;; (if (string-match "-p$" (car fp))
1644 ;; (concat (substring (car fp) 0 -2) "-flag")
1645 ;; (concat (car fp) "-flag"))))
1646 ;; (if (checkdoc-y-or-n-p
1647 ;; (format
1648 ;; "Rename to %s and Query-Replace all occurrences? "
1649 ;; newname))
1650 ;; (progn
1651 ;; (beginning-of-defun)
1652 ;; (query-replace-regexp
1653 ;; (concat "\\<" (regexp-quote (car fp)) "\\>")
1654 ;; newname))
1655 ;; (checkdoc-create-error
1656 ;; "Flag variable names should normally end in `-flag'" s
1657 ;; (marker-position e)))))
1658 ;; Done with variables
1659 ))
1661 ;; This if we are in a function definition
1663 ;; * When a function's documentation string mentions the value
1664 ;; of an argument of the function, use the argument name in
1665 ;; capital letters as if it were a name for that value. Thus,
1666 ;; the documentation string of the function `/' refers to its
1667 ;; second argument as `DIVISOR', because the actual argument
1668 ;; name is `divisor'.
1670 ;; Addendum: Make sure they appear in the doc in the same
1671 ;; order that they are found in the arg list.
1681 inopts t)
1686 ;; Require whitespace OR
1687 ;; ITEMth<space> OR
1688 ;; ITEMs<space>
1690 e t)))
1693 ;; If the symbol was not found, let's see if we
1694 ;; can find it with a different capitalization
1695 ;; and see if the user wants to capitalize it.
1699 ;; Require whitespace OR
1700 ;; ITEMth<space> OR
1701 ;; ITEMs<space>
1703 e t))
1707 "If this is the argument `%s', it should appear as %s. Fix? "
1713 ;; It wasn't found at all! Offer to attach this new symbol
1714 ;; to the end of the documentation string.
1717 "Add %s documentation to end of doc string? "
1719 ;; Now do some magic and invent a doc string.
1730 nil)
1733 "Argument `%s' should appear (as %s) in the doc string"
1740 "Arguments occur in the doc string out of order"
1742 ;; * For consistency, phrase the verb in the first sentence of a
1743 ;; documentation string for functions as an imperative.
1744 ;; For instance, use `Return the cons of A and
1745 ;; B.' in preference to `Returns the cons of A and B.'
1746 ;; Usually it looks good to do likewise for the rest of the
1747 ;; first paragraph. Subsequent paragraphs usually look better
1748 ;; if they have proper subjects.
1749 ;;
1750 ;; This is the least important of the above tests. Make sure
1751 ;; it occurs last.
1754 ;; Maybe rebuild the monster-regexp
1758 ;; check string-continuation
1765 checkdoc-common-verbs-regexp
1766 lim t))
1770 checkdoc-common-verbs-wrong-voice))
1780 replace t)
1783 ;; there was a match, but no replace
1787 original replace)
1789 ;; Done with functions
1790 )))
1791 ;;* When a documentation string refers to a Lisp symbol, write it as
1792 ;; it would be printed (which usually means in lower case), with
1793 ;; single-quotes around it. For example: `lambda'. There are two
1794 ;; exceptions: write t and nil without single-quotes. (In this
1795 ;; manual, we normally do use single-quotes for those symbols.)
1800 ;; Ignore manual page references like
1801 ;; git-config(1).
1803 e t))
1805 ;; A . is a \s_ char, so we must remove periods from
1806 ;; sentences more carefully.
1816 ms))
1824 ms))))))
1829 nil)))
1830 ;; t and nil case
1838 nil
1840 "Symbols t and nil should not appear in `...' quotes"
1842 ;; Here is some basic sentence formatting
1844 ;; Here are common proper nouns that should always appear capitalized.
1846 ;; Make sure the doc string has correctly spelled English words
1847 ;; in it. This function is extracted due to its complexity,
1848 ;; and reliance on the Ispell program.
1850 ;; User supplied checks
1852 ;; Done!
1853 )))
1856 "Return a list of details about the current sexp.
1857 It is a list of the form:
1858 (NAME VARIABLE INTERACTIVE NODOCPARAMS PARAMETERS ...)
1859 where NAME is the name, VARIABLE is t if this is a `defvar',
1860 INTERACTIVE is nil if this is not an interactive function, otherwise
1861 it is the position of the `interactive' call, and PARAMETERS is a
1862 string which is the name of each variable in the function's argument
1863 list. The NODOCPARAMS is a sublist of parameters specified by a checkdoc
1864 comment for a given defun. If the first element is not a string, then
1865 the token checkdoc-order: <TOKEN> exists, and TOKEN is a symbol read
1866 from the comment."
1882 ;; The variable spot
1884 ;; Interactive
1889 t)
1890 ret)))
1894 ;; Overload th main obarray so read doesn't intern the
1895 ;; local symbols of the function we are checking.
1896 ;; Without this we end up cluttering the symbol space w/
1897 ;; useless symbols.
1899 ;; Ok, check for checkdoc parameter comment here
1907 t)
1913 t)
1927 sl1)
1928 ret)))
1929 ;; Read the list of parameters, but do not put the symbols in
1930 ;; the standard obarray.
1932 ;; This is because read will intern nil if it doesn't into the
1933 ;; new obarray.
1942 "Return non-nil if the current point is in a code fragment.
1943 A code fragment is identified by an open parenthesis followed by a
1944 symbol which is a valid function or a word in all CAPS, or a parenthesis
1945 that is quoted with the ' character. Only the region from START to LIMIT
1946 is allowed while searching for the bounding parenthesis."
1957 ;; if this string is function bound, we are in
1958 ;; sample code. If it has a - or : character in
1959 ;; the name, then it is probably supposed to be bound
1960 ;; but isn't yet.
1969 The text checked is between START and LIMIT."
1980 "Check all text between BEGIN and END for lower case proper nouns.
1981 These are Emacs centric proper nouns which should be capitalized for
1982 consistency. Return an error list if any are not fixed, but
1983 internally skip over no answers.
1984 If the offending word is in a piece of quoted text, then it is skipped."
1998 ;; surrounded by /, as in a URL or filename: /emacs/
2002 ;; info or url links left alone
2004 help-xref-info-regexp))
2006 help-xref-url-regexp)))
2009 text)
2011 nil
2013 ;; If there is already an error, then generate
2014 ;; the warning output if applicable
2018 "Name %s should appear capitalized as %s"
2020 b e))
2023 "Name %s should appear capitalized as %s"
2025 bb b be e)))))))
2029 "Make sure all sentences have double spaces between BEGIN and END."
2046 ;; piece of an abbreviation
2047 ;; FIXME etc
2052 b e
2053 "There should be two spaces after a period. Fix? "
2055 nil
2057 ;; If there is already an error, then generate
2058 ;; the warning output if applicable
2061 "There should be two spaces after a period"
2062 b e))
2064 "There should be two spaces after a period"
2065 bb b be e)))))))
2068 ;;; Ispell engine
2069 ;;
2073 "Initialize Ispell process (default version) with Lisp words.
2074 The words used are from `checkdoc-ispell-lisp-words'. If `ispell'
2075 cannot be loaded, then set `checkdoc-spellcheck-documentation-flag' to
2076 nil."
2082 ;; This code copied in part from ispell.el Emacs 19.34
2086 ;; Silence byte compiler
2093 "Run the Ispell tools on the doc string between point and END.
2094 Since Ispell isn't Lisp-smart, we must pre-process the doc string
2095 before using the Ispell engine on it."
2097 ;; If the user wants no questions or fixing, then we must
2098 ;; disable spell checking as not useful.
2101 nil
2108 ;; Skip lists describing meta-syntax, or bound variables
2116 ;; This is probably repetitive in most cases, but not always.
2117 nil
2118 ;; Find out how we spell-check this word.
2120 ;; All caps w/ option th, or s tacked on the end
2121 ;; for pluralization or number.
2124 )
2125 nil
2134 ;; Nothing here.
2135 )))))
2137 err))))
2139 ;;; Rogue space checking engine
2140 ;;
2142 "Return a message list if there is a line with white space at the end.
2143 If `checkdoc-autofix-flag' permits, delete that whitespace instead.
2144 If optional arguments START and END are non-nil, bound the check to
2145 this region.
2146 Optional argument INTERACT may permit the user to fix problems on the fly."
2150 ;; If end is nil, it means end of buffer to search anyway
2152 ;; Check for an error if `? ' or `?\ ' is used at the end of a line.
2153 ;; (It's dangerous)
2158 "Don't use `? ' at the end of a line. \
2159 News agents may remove it"
2161 ;; If interactive is passed down, give them a chance to fix things.
2168 ;; Check for, and potentially remove whitespace appearing at the
2169 ;; end of different lines.
2172 ;; There is no documentation in the Emacs Lisp manual about this check,
2173 ;; it is intended to help clean up messy code and reduce the file size.
2175 ;; This is not a complex activity
2179 nil
2182 ;; Return an error and leave the cursor at that spot, or restore
2183 ;; the cursor.
2187 nil)))
2189 ;;; Comment checking engine
2190 ;;
2192 ;; We must load this to:
2193 ;; a) get symbols for compile and
2194 ;; b) determine if we have lm-history symbol which doesn't always exist
2200 "Return a message list if this file does not match the Emacs standard.
2201 This checks for style only, such as the first line, Commentary:,
2202 Code:, and others referenced in the style guide."
2204 nil
2206 ;; Old XEmacs don't have `lm-commentary-mark'
2215 ;; This file has been set up where ERR is a variable. Each check is
2216 ;; asked, and the function will make sure that if the user does not
2217 ;; auto-fix some error, that we still move on to the next auto-fix,
2218 ;; AND we remember the past errors.
2220 err
2221 ;; Lisp Maintenance checks first
2222 ;; Was: (lm-verify) -> not flexible enough for some people
2223 ;; * Summary at the beginning of the file:
2225 ;; This certifies as very complex so always ask unless
2226 ;; it's set to never
2235 nil))
2237 err
2239 ;; * Commentary Section
2246 nil t)
2259 nil nil t)))
2260 nil)
2261 err))
2263 err
2265 ;; * History section. Say nothing if there is a file ChangeLog
2271 nil
2277 nil t)
2289 err))
2291 err
2293 ;; * Code section
2296 pos)
2298 ;; match ";;;###autoload" cookie to keep it with the form
2305 nil t))
2313 nil)
2317 nil)
2318 err))
2320 err
2322 ;; * A footer. Not compartmentalized from lm-verify: too bad.
2323 ;; The following is partially clipped from lm-verify
2331 nil t))
2338 fn fn fe)
2340 err))
2341 ;; The below checks will not return errors if the user says NO
2343 ;; Let's spellcheck the commentary section. This is the only
2344 ;; section that is easy to pick out, and it is also the most
2345 ;; visible section (with the finder).
2351 ;; Since the comments talk about Lisp, use the
2352 ;; specialized spell-checker we also used for doc
2353 ;; strings.
2358 err
2360 ;; Generic Full-file checks (should be comment related)
2362 err))
2363 ;; Done with full file comment checks
2364 err)))
2367 "Return t if point is outside the bounds of a valid sexp."
2374 ;;; `error' and `message' text verifier.
2375 ;;
2377 "Search between BEG and END for a style error with message text.
2378 Optional arguments BEG and END represent the boundary of the check.
2379 The default boundary is the entire buffer."
2386 e))
2389 "Move cursor to the next checkable message string after point.
2390 Return the message classification.
2391 Argument END is the maximum bounds to search in."
2410 nil
2412 return))
2415 "Return or fix errors found in strings passed to a message display function.
2416 According to the documentation for the function `error', the error list
2417 should not end with a period, and should start with a capital letter.
2418 The function `y-or-n-p' has similar constraints.
2419 Argument TYPE specifies the type of question, such as `error or `y-or-n-p."
2420 ;; If type is nil, then attempt to derive it.
2432 ;; From the documentation of the symbol `error':
2433 ;; In Emacs, the convention is that error messages start with a capital
2434 ;; letter but *do not* end with a period. Please follow this convention
2435 ;; for the sake of consistency.
2440 "Capitalize your message text? "
2442 t)))
2444 "Messages should start with a capital letter"
2446 nil)
2447 ;; In general, sentences should have two spaces after the period.
2451 ;; Look for proper nouns in this region too.
2455 ;; Here are message type specific questions.
2462 "Remove period from error? "
2463 ""
2464 t)))
2466 "Error messages should *not* end with a period"
2468 nil)
2469 ;; `y-or-n-p' documentation explicitly says:
2470 ;; It should end in a space; `y-or-n-p' adds `(y or n) ' to it.
2471 ;; I added the ? requirement. Without it, it is unclear that we
2472 ;; ask a question and it appears to be an undocumented style.
2477 nil
2481 ;; If we see a ?, then replace with "? ".
2486 nil
2497 nil
2509 nil
2513 ;; Now, let's just run the spell checker on this guy.
2516 )))
2518 ;;; Auto-fix helper functions
2519 ;;
2521 "Like `y-or-n-p', but pays attention to `checkdoc-autofix-flag'.
2522 Argument QUESTION is the prompt passed to `y-or-n-p'."
2526 nil
2533 "Highlight between START and END and queries the user with QUESTION.
2534 If the user says yes, or if `checkdoc-autofix-flag' permits, replace
2535 the region marked by START and END with REPLACEWITH. If optional flag
2536 COMPLEX is non-nil, then we may ask the user a question. See the
2537 documentation for `checkdoc-autofix-flag' for details.
2539 If a section is auto-replaced without asking the user, this function
2540 will pause near the fixed code so the user will briefly see what
2541 happened.
2543 This function returns non-nil if the text was replaced.
2545 This function will not modify `match-data'."
2562 ;; On the off chance this is automatic, display
2563 ;; the question anyway so the user knows what's
2564 ;; going on.
2576 ret)))
2578 ;;; Warning management
2579 ;;
2593 "Set up the major mode for the buffer containing the list of errors."
2595 checkdoc-output-error-regex-alist)
2597 checkdoc-output-font-lock-keywords))
2600 "The name to use for a checkdoc buffer in the error list."
2606 "Initialize the checkdoc diagnostic buffer for a pass.
2607 Create the header so that the string CHECK-TYPE is displayed as the
2608 function called to create the messages."
2620 "Store POINT and MSG as errors in the checkdoc diagnostic buffer."
2632 "Display the checkdoc diagnostic buffer in a temporary window."
2643 nil)))
2655 ;;; checkdoc.el ends here