1 2012-05-06 Chong Yidong <cyd@gnu.org>
3 * lisp.mk (lisp): Update.
5 2012-05-05 Jim Meyering <meyering@redhat.com>
7 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
9 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
11 * data.c (PUT_ERROR): New macro.
12 (syms_of_data): Use it. Add new error type `user-error'.
13 * undo.c (user_error): New function.
14 (Fprimitive_undo): Use it.
15 * print.c (print_error_message): Adjust print style for `user-error'.
16 * keyboard.c (user_error): New function.
17 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
19 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
21 Do not limit current-time-string to years 1000..9999.
22 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
23 (Fcurrent_time_string): Support any year that is supported by the
24 underlying localtime representation. Don't use asctime, as it
25 has undefined behavior for years outside the range -999..9999.
27 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
29 Fix race conditions involving setenv, gmtime, localtime, asctime.
30 Without this fix, interrupts could mess up code that uses these
31 nonreentrant functions, since setting TZ invalidates existing
32 tm_zone or tzname values, and since most of these functions return
33 pointers to static storage.
34 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
35 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
36 Grow the critical sections to include not just invoking
37 localtime/gmtime, but also accessing these functions' results
38 including their tm_zone values if any, and any related TZ setting.
39 (format_time_string): Last arg is now struct tm *, not struct tm **,
40 so that the struct tm is saved in the critical section.
41 All callers changed. Simplify allocation of initial buffer, partly
42 motivated by the fact that memory allocation needs to be outside
45 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
47 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
50 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
51 Remove duplicated buffer name initialization.
53 2012-05-02 Jim Meyering <jim@meyering.net>
55 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
57 * xfns.c (x_window): Use xstrdup (Bug#11375).
59 2012-05-02 Eli Zaretskii <eliz@gnu.org>
61 * xdisp.c (pos_visible_p): If already at a newline from the
62 display string before the 'while' loop, don't walk back the glyphs
63 from it3.glyph_row. Solves assertion violation when the display
64 string begins with a newline (egg.el). (Bug#11367)
66 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
68 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
71 2012-05-01 Glenn Morris <rgm@gnu.org>
73 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
74 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
75 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
76 All were removed before 23.1.
78 * dispnew.c: Remove HAVE_LIBNCURSES test;
79 it is always true on relevant platforms.
81 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
82 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
84 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
86 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
88 * .gdbinit (xpr): Remove checks for no longer existing misc types.
89 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
92 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
94 Do not avoid creating empty evaporating overlays (Bug#9642).
95 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
96 That is, do not delete an evaporating overlay if it becomes
97 empty after its bounds are adjusted to fit within its buffer.
98 This fix caused other problems, and I'm reverting it until we get
99 to the bottom of them.
101 2012-04-27 Chong Yidong <cyd@gnu.org>
103 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
105 2012-04-27 Eli Zaretskii <eliz@gnu.org>
107 * xdisp.c (pos_visible_p): If the window start position is beyond
108 ZV, start the display from buffer beginning. Prevents assertion
109 violation in init_iterator when the minibuffer window is scrolled
112 * window.c (window_scroll_pixel_based): Likewise.
114 2012-04-27 Chong Yidong <cyd@gnu.org>
116 * keymap.c (where_is_internal): Doc fix (Bug#10872).
118 2012-04-27 Glenn Morris <rgm@gnu.org>
120 * fileio.c (Fcopy_file, Fset_file_selinux_context):
121 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
123 2012-04-27 Eli Zaretskii <eliz@gnu.org>
125 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
126 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
128 2012-04-26 Eli Zaretskii <eliz@gnu.org>
130 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
131 display element, check also the underlying string or buffer
132 character. (Bug#11341)
134 * w32menu.c: Include w32heap.h.
135 (add_menu_item): If the call to AppendMenuW (via
136 unicode_append_menu) fails, disable Unicode menus only if we are
137 running on Windows 9X/Me.
139 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
141 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
142 (xgetint): Add missing shift for LSB tags.
144 2012-04-24 Martin Rudalics <rudalics@gmx.at>
146 * keyboard.c (read_char): Don't wipe echo area for select window
147 events: These might get delayed via `mouse-autoselect-window'
150 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
152 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
153 manipulation of :loaded-from data.
155 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
157 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
158 now a cons (bug#11311).
160 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
162 Do not create empty overlays with the evaporate property (Bug#9642).
163 * buffer.c (Fmove_overlay): Delete an evaporating overlay
164 if it becomes empty after its bounds are adjusted to fit within
165 its buffer. Without this fix, in a nonempty buffer (let ((o
166 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
167 yields an empty overlay that has the evaporate property, which is
168 not supposed to happen.
170 Fix minor GTK3 problems found by static checking.
171 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
172 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
173 (struct _EmacsFixedClass, emacs_fixed_get_type):
174 Move decls here from emacsgtkfixed.h, since they needn't be public.
175 (emacs_fixed_get_type): Now static.
176 (emacs_fixed_class_init): Omit unused local.
177 (emacs_fixed_child_type): Remove; unused.
178 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
179 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
180 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
181 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
182 (EMACS_FIXED_GET_CLASS): Remove; unused.
183 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
185 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
186 Problem reported by Juanma Barranquero for Windows -Wunused-function.
188 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
190 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
191 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
192 (__malloc_size_t, __malloc_ptrdiff_t):
193 Remove. All uses removed, replaced by the definiens if needed,
194 since we can assume C89 or better now.
195 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
196 (protect_malloc_state, align, get_contiguous_space)
197 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
198 (malloc_atfork_handler_child, malloc_enable_thread)
199 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
200 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
201 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
202 (special_realloc, _realloc_internal_nolock, _realloc_internal)
203 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
204 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
205 Define using prototypes, not old style.
206 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
207 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
208 (align): Don't assume that signed integer overflow wraps around.
209 Omit unused local var.
210 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
211 (_free_internal_nolock, memalign, mallochook, reallochook):
212 Omit no-longer-needed casts.
213 (valloc): Use getpagesize, not __getpagesize.
214 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
215 (struct hdr): The 'magic' member is now size_t, not unsigned long.
217 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
219 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
221 Move functions from C to Lisp. Make non-blocking method calls
222 the default. Implement further D-Bus standard interfaces.
224 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
225 (QCdbus_request_name_allow_replacement)
226 (QCdbus_request_name_replace_existing)
227 (QCdbus_request_name_do_not_queue)
228 (QCdbus_request_name_reply_primary_owner)
229 (QCdbus_request_name_reply_in_queue)
230 (QCdbus_request_name_reply_exists)
231 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
232 (QCdbus_registered_serial, QCdbus_registered_method)
233 (QCdbus_registered_signal): New Lisp objects.
234 (XD_DEBUG_MESSAGE): Use sizeof.
235 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
236 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
237 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
238 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
239 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
240 (xd_signature, xd_append_arg): Allow float for integer types.
241 (xd_get_connection_references): New function.
242 (xd_get_connection_address): Rename from xd_initialize.
243 Return cached address.
244 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
245 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
247 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
248 Return number of recounts.
249 (Fdbus_get_unique_name): Make stronger parameter check.
250 (Fdbus_message_internal): New defun.
251 (Fdbus_call_method, Fdbus_call_method_asynchronously)
252 (Fdbus_method_return_internal, Fdbus_method_error_internal)
253 (Fdbus_send_signal, Fdbus_register_service)
254 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
255 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
256 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
257 (Vdbus_compiled_version, Vdbus_runtime_version)
258 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
259 (Vdbus_message_type_method_return, Vdbus_message_type_error)
260 (Vdbus_message_type_signal): New defvars.
261 (Vdbus_registered_buses, Vdbus_registered_objects_table):
264 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
266 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
267 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
268 Do not assume ptrdiff_t is the same width as 'int'.
270 * alloc.c: Handle unusual debugging option combinations.
271 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
272 since the two debugging options are incompatible.
273 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
275 (mem_init, mem_insert, mem_insert_fixup):
276 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
277 (NEED_MEM_INSERT): Remove; no longer needed.
279 2012-04-22 Leo Liu <sdl.web@gmail.com>
281 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
283 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
285 * sysdep.c [__FreeBSD__]: Minor cleanups.
286 (list_system_processes, system_process_attributes) [__FreeBSD__]:
287 Use Emacs indenting style more consistently. Avoid some casts.
288 Use 'double' consistently rather than mixing 'float' and 'double'.
290 2012-04-21 Eduard Wiebe <usenet@pusto.de>
292 * sysdep.c (list_system_processes, system_process_attributes):
293 Add implementation for FreeBSD (Bug#5243).
295 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
297 * lisp.mk (lisp): Update.
299 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
301 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
302 It is never used otherwise.
304 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
306 * print.c (print_preprocess): Only check print_depth if print-circle
308 (print_object): Check for cycles even when print-circle is nil and
309 print-gensym is t, but only check print_depth if print-circle is nil.
311 2012-04-20 Chong Yidong <cyd@gnu.org>
313 * process.c (wait_reading_process_output): If EIO occurs on a pty,
314 set the status to "failed" and ensure that sentinel is run.
316 2012-04-20 Glenn Morris <rgm@gnu.org>
318 * process.c (Fset_process_inherit_coding_system_flag)
319 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
320 (Fmake_network_process, Fmake_serial_process): Doc fix.
322 2012-04-20 Eli Zaretskii <eliz@gnu.org>
324 * xdisp.c (string_buffer_position_lim): Limit starting position to
326 (set_cursor_from_row): If called for a mode-line or header-line
327 row, return zero immediately.
328 (try_cursor_movement): If inside continuation line, don't back up
329 farther than the first row after the header line, if any.
330 Don't consider the header-line row as "partially visible", even if
331 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
333 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
335 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
338 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
339 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
341 configure: new option --enable-gcc-warnings (Bug#11207)
342 * Makefile.in (C_WARNINGS_SWITCH): Remove.
343 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
344 (ALL_CFLAGS): Use new macros rather than old.
345 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
346 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
347 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
348 -Wunused-result, -Wunused-variable. This should go away once
349 the Emacs and Gnulib regex code is merged.
350 (xmalloc, xrealloc): Now static.
352 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
354 * dired.c (Fsystem_groups): Remove unused local.
356 2012-04-17 Glenn Morris <rgm@gnu.org>
358 * dired.c (Fsystem_users): Doc fix.
360 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
362 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
363 (syms_of_dired): Add them.
365 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
367 Fix minor alloc.c problems found by static checking.
368 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
369 New extern decls, to avoid calling undeclared functions.
370 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
371 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
372 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
373 (NEED_MEM_INSERT): New macro.
374 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
375 Remove one incorrect comment and fix another.
377 Fix minor ralloc.c problems found by static checking.
378 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
379 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
380 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
381 (r_alloc_sbrk): Now static.
383 Improve ralloc.c interface checking.
384 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
385 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
386 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
387 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
388 [REL_ALLOC]: ... to here, to check interface.
389 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
390 Remove decls. This fixes an "It stinks!".
392 * alloc.c (which_symbols): Fix alignment issue / type clash.
394 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
396 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
397 (struct Lisp_Misc_Any): Likewise.
398 (struct Lisp_Free): Likewise.
399 * alloc.c (union aligned_Lisp_Symbol): Define.
400 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
401 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
402 (union aligned_Lisp_Misc): Define.
403 (MARKER_BLOCK_SIZE, struct marker_block): Use union
404 aligned_Lisp_Misc instead of union Lisp_Misc.
405 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
407 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
409 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
410 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
411 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
412 * s/netbsd.h, s/sol2-6.h:
413 Remove definition of GC_MARK_STACK, since the default now works.
414 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
415 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
416 no longer the default.
417 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
419 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
421 * lread.c (lisp_file_lexically_bound_p):
422 Fix hang at ";-*-\n" (bug#11238).
424 2012-04-14 Eli Zaretskii <eliz@gnu.org>
426 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
427 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
429 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
431 * nsterm.m (constrainFrameRect): Always constrain when there is only
432 one screen (Bug#10962).
434 2012-04-13 Ken Brown <kbrown@cornell.edu>
436 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
438 2012-04-13 Reuben Thomas <rrt@sc3d.org>
440 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
442 2012-04-11 Daniel Colascione <dancol@dancol.org>
444 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
445 against is gone. It's better to use vfork now so that when Cygwin
446 gains a new, working vfork, we use it automatically (bug#10398).
448 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
450 * window.c (save_window_save): Obey window-point-insertion-type.
452 2012-04-11 Glenn Morris <rgm@gnu.org>
454 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
456 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
458 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
460 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
462 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
463 (force_quit_count): New var.
464 (handle_interrupt): Use it.
466 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
468 * w32.c (w32_delayed_load): Record the full path of the library
469 being loaded (bug#10424).
471 2012-04-09 Glenn Morris <rgm@gnu.org>
473 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
474 not just in the obarray, before snarfing them. (Bug#11036)
476 * Makefile.in ($(leimdir)/leim-list.el):
477 Pass EMACS rather than BUILT_EMACS.
479 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
481 * process.c (make_process):
482 * process.h: Add integer `gnutls_handshakes_tried' member to
485 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
486 Add convenience `GNUTLS_LOG2i' macro.
488 * gnutls.c (gnutls_log_function2i): Convenience log function.
489 (emacs_gnutls_read): Use new log functions,
490 `gnutls_handshakes_tried' process member, and
491 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
492 attempts per process (connection).
494 2012-04-09 Chong Yidong <cyd@gnu.org>
496 * eval.c (Fuser_variable_p, user_variable_p_eh)
497 (lisp_indirect_variable): Functions deleted.
498 (Fdefvar): Caller changed.
500 * callint.c (Finteractive, Fcall_interactively):
501 * minibuf.c (Fread_variable): Callers changed.
503 2012-04-09 Eli Zaretskii <eliz@gnu.org>
505 * xdisp.c (set_cursor_from_row): If the display string appears in
506 the buffer at position that is closer to point than the position
507 after the display string, display the cursor on the first glyph of
508 the display string. Fixes cursor display when a 'display' text
509 property immediately follows invisible text. (Bug#11094)
511 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
513 composite.c: use 'double' consistently
514 * composite.c (get_composition_id): Use 'double' consistently
515 instead of converting 'float' to 'double' and vice versa; this is
516 easier to understand and avoids a GCC warning.
518 2012-04-09 Glenn Morris <rgm@gnu.org>
520 * Makefile.in: Generate leim-list with bootstrap-emacs, in
521 preparation for dumping it with emacs. (Bug#4789)
522 (leimdir): New variable.
523 ($(leimdir)/leim-list.el): New rule.
524 (emacs$(EXEEXT)): Depend on leim-list.el.
526 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
527 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
528 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
530 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
532 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
535 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
537 * xml.c (init_libxml2_functions) [WINDOWSNT]:
538 Remove unused local variable.
540 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
542 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
543 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
544 (mark_memory): Mark Lisp_Objects only if pointers might hide in
545 objects, as mark_maybe_pointer will catch them otherwise.
546 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
547 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
549 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
551 Fix typo that broke non-Windows builds.
552 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
554 2012-04-07 Eli Zaretskii <eliz@gnu.org>
556 Support building on MS-Windows with libxml2.
558 * makefile.w32-in (OBJ2): Add xml.$(O).
559 (GLOBAL_SOURCES): Add xml.c.
560 ($(BLD)/xml.$(O)): New dependency list.
562 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
563 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
564 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
565 [!WINDOWSNT]: New macros.
566 (init_libxml2_functions, libxml2_loaded_p): New functions.
567 (parse_region): Call fn_xmlCheckVersion instead of using the macro
568 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
569 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
570 Calls xmlCleanupParser only if libxml2 was loaded (or statically
572 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
573 Call init_libxml2_functions before calling libxml2 functions.
574 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
576 * emacs.c: Don't include libxml/parser.h.
577 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
578 xmlCleanupParser directly.
580 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
582 2012-04-07 Eli Zaretskii <eliz@gnu.org>
584 * indent.c (Fvertical_motion): If there is a display string at
585 point, use it.vpos to compute how many lines to backtrack after
586 move_it_to point. (Bug#11133)
588 2012-04-06 Eli Zaretskii <eliz@gnu.org>
590 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
591 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
592 about subtle differences between FETCH_CHAR* and STRING_CHAR*
593 macros related to unification of CJK characters. For the details,
594 see the discussion following the message here:
595 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
597 2012-04-04 Chong Yidong <cyd@gnu.org>
599 * keyboard.c (Vdelayed_warnings_list): Doc fix.
601 2012-04-01 Eli Zaretskii <eliz@gnu.org>
603 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
604 instead of alloca. (Bug#11138)
606 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
608 * w32menu.c (is_simple_dialog): Properly check lisp types.
611 2012-03-31 Eli Zaretskii <eliz@gnu.org>
613 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
614 position we get to after a call to move_it_to fails the
615 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
616 only if we wind up in a string from display property. (Bug#11063)
618 * window.c (Fdelete_other_windows_internal): Invalidate the row
619 and column information about mouse highlight, so that redisplay
620 restores it after reallocating the glyph matrices. (Bug#7464)
622 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
623 string comes from a `display' text property, use the buffer
624 position of that property as if we actually saw that position in
626 (move_it_by_lines): Remove the assertion that
627 "it->current_x == 0 && it->hpos == 0" which can be legitimately
628 violated when there's a before-string at the beginning of a line.
631 2012-03-30 Eli Zaretskii <eliz@gnu.org>
633 * xdisp.c (append_space_for_newline): If the default face was
634 remapped, use the remapped face for the appended newline.
635 (extend_face_to_end_of_line): Use the remapped default face for
636 extending the face to the end of the line.
637 (display_line): Call extend_face_to_end_of_line when the default
638 face was remapped. (Bug#11068)
640 2012-03-29 Eli Zaretskii <eliz@gnu.org>
642 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
644 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
646 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
648 2012-03-27 Glenn Morris <rgm@gnu.org>
650 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
653 2012-03-26 Kenichi Handa <handa@m17n.org>
655 * dispextern.h (struct glyph): Fix previous change. Change the
656 bit length of glyphless.ch to 25 (Bug#11082).
658 2012-03-26 Chong Yidong <cyd@gnu.org>
660 * keyboard.c (Vselection_inhibit_update_commands): New variable.
661 (command_loop_1): Use it; inhibit selection update for
662 handle-select-window too (Bug#8996).
664 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
666 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
668 2012-03-25 Kenichi Handa <handa@m17n.org>
670 * dispextern.h (struct glyph): Change the bit length of
671 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
673 2012-03-24 Eli Zaretskii <eliz@gnu.org>
675 * s/ms-w32.h (tzname): Include time.h before redirecting to
676 _tzname. Fixes the MSVC build. (Bug#9960)
678 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
680 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
683 * xterm.c (XTread_socket): Only modify handling_signal if
684 !SYNC_INPUT. (Bug#11080)
686 2012-03-23 Eli Zaretskii <eliz@gnu.org>
688 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
689 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
690 when fetching a multibyte character consumes more bytes than
691 CHAR_BYTES returns, due to unification of CJK characters in
692 string_char. (Bug#11073)
694 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
696 * process.c (wait_reading_process_output): Handle pty disconnect
697 by refraining from sending oneself a SIGCHLD (bug#10933).
699 2012-03-22 Chong Yidong <cyd@gnu.org>
701 * dispextern.h (struct it): New member string_from_prefix_prop_p.
703 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
704 Mark string as coming from a prefix property.
705 (handle_face_prop): Use default face for prefix strings (Bug#4281).
706 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
708 2012-03-21 Chong Yidong <cyd@gnu.org>
710 * xfaces.c (Vface_remapping_alist): Doc fix.
712 2012-03-20 Eli Zaretskii <eliz@gnu.org>
714 * w32proc.c (Fw32_set_console_codepage)
715 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
718 2012-03-20 Chong Yidong <cyd@gnu.org>
720 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
721 to reflect default non-nil value of redisplay-dont-pause.
723 2012-03-19 Kenichi Handa <handa@m17n.org>
725 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
726 it fit in a valid range (Bug#11003).
728 2012-03-18 Eli Zaretskii <eliz@gnu.org>
730 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
731 that is not from display property, accept the row as a "cursor
732 row" if one of the string's character has a non-nil `cursor'
733 property. Fixes cursor positioning when there are newlines in
734 overlay strings, e.g. in icomplete.el. (Bug#11035)
736 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
738 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
740 2012-03-12 Chong Yidong <cyd@gnu.org>
742 * eval.c (inhibit_lisp_code): Rename from
743 inhibit_window_configuration_change_hook; move from window.c.
745 * xfns.c (unwind_create_frame_1, Fx_create_frame):
746 * window.c (run_window_configuration_change_hook)
747 (syms_of_window): Callers changed.
749 2012-03-11 Chong Yidong <cyd@gnu.org>
751 * keymap.c (Fkey_description): Doc fix (Bug#9700).
753 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
755 2012-03-10 Chong Yidong <cyd@gnu.org>
757 * frame.c (other_visible_frames): Don't assume the selected frame
758 is visible (Bug#10955).
760 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
762 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
764 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
766 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
767 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
770 2012-03-03 Glenn Morris <rgm@gnu.org>
772 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
774 2012-03-02 Eli Zaretskii <eliz@gnu.org>
776 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
777 position past the first glyph_row that ends at ZV. (Bug#10902)
778 (redisplay_window, next_element_from_string): Fix typos in
780 (redisplay_window): Pass to move_it_vertically the margin in
781 pixels, not in screen lines.
783 2012-03-02 Glenn Morris <rgm@gnu.org>
785 * buffer.c (buffer-list-update-hook): Doc fix.
787 2012-02-29 Eli Zaretskii <eliz@gnu.org>
789 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
790 push_it before setting up the iterator for the first overlay
791 string, even if we have an empty string loaded.
792 (next_overlay_string): If there's an empty string on the iterator
793 stack, pop the stack. (Bug#10903)
795 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
797 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
798 Suggested by Stefan Monnier in
799 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
800 * alloc.c (widen_to_Lisp_Object): New static function.
801 (mark_memory): Also mark Lisp_Objects by fetching pointer words
802 and widening them to Lisp_Objects. This would work even if
803 USE_LSB_TAG is defined and wide integers are used, which might
804 happen in a future version of Emacs.
806 2012-02-25 Chong Yidong <cyd@gnu.org>
808 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
811 * xselect.c (Fx_selection_exists_p): Doc fix.
812 (x_clipboard_manager_save_all): Print an informative message
813 before saving to clipboard manager.
815 2012-02-24 Chong Yidong <cyd@gnu.org>
817 * keyboard.c (process_special_events): Handle all X selection
818 requests in kbd_buffer, not just the next one (Bug#8869).
820 2012-02-23 Chong Yidong <cyd@gnu.org>
822 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
823 call when setting menu-bar-lines and tool-bar-lines parameters.
824 (unwind_create_frame_1): New helper function.
826 * window.c (inhibit_window_configuration_change_hook): New var.
827 (run_window_configuration_change_hook): Obey it.
828 (syms_of_window): Initialize it.
830 2012-02-22 Chong Yidong <cyd@gnu.org>
832 * xterm.c (x_draw_image_relief): Add missing type check for
833 Vtool_bar_button_margin (Bug#10743).
835 2012-02-21 Chong Yidong <cyd@gnu.org>
837 * fileio.c (Vfile_name_handler_alist): Doc fix.
839 * buffer.c (Fget_file_buffer): Protect against invalid file
840 handler return value.
842 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
844 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
845 when computing $valmask.
847 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
848 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
849 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
850 It's useless in that case, and it can cause problems on hosts
851 that allocate halves of EMACS_INT values separately.
852 Reported by Dan Horák. Diagnosed by Andreas Schwab in
853 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
854 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
855 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
856 it avoids undefined behavior on hosts where shifting right by more
857 than the word width has undefined behavior.
859 2012-02-19 Chong Yidong <cyd@gnu.org>
861 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
862 (Funhandled_file_name_directory, Ffile_name_as_directory)
863 (Fdirectory_file_name, Fexpand_file_name)
864 (Fsubstitute_in_file_name): Protect against invalid file handler
865 return values (Bug#10845).
867 2012-02-18 Eli Zaretskii <eliz@gnu.org>
869 * .gdbinit (pitx): Fix incorrect references to fields of the
872 2012-02-17 Chong Yidong <cyd@gnu.org>
874 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
876 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
878 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
879 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
881 2012-02-15 Chong Yidong <cyd@gnu.org>
883 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
884 marked as special. Also, starting docstrings with * is obsolete.
886 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
888 * gnutls.c (emacs_gnutls_write): Fix last change.
890 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
892 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
895 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
897 * keymap.c (Fsingle_key_description): Handle char ranges.
899 2012-02-12 Chong Yidong <cyd@gnu.org>
901 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
902 as that creates a dangerous corner case.
904 * window.c (Fdelete_window_internal): Invalidate the mouse
905 highlight (Bug#9904).
907 2012-02-12 Glenn Morris <rgm@gnu.org>
909 * xselect.c (Fx_own_selection_internal)
910 (Fx_get_selection_internal, Fx_disown_selection_internal)
911 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
912 * nsselect.m (Fx_own_selection_internal)
913 (Fx_disown_selection_internal, Fx_selection_exists_p)
914 (Fx_selection_owner_p, Fx_get_selection_internal):
915 Sync docs and argument specs with the xselect.c versions.
917 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
919 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
921 2012-02-11 Eli Zaretskii <eliz@gnu.org>
923 * w32select.c (Fx_selection_exists_p): Sync doc string and
924 argument list with xselect.c. (Bug#10783)
926 * w16select.c (Fx_selection_exists_p): Sync doc string and
927 argument list with xselect.c. (Bug#10783)
929 2012-02-10 Glenn Morris <rgm@gnu.org>
931 * fns.c (Fsecure_hash): Doc fix.
933 2012-02-09 Kenichi Handa <handa@m17n.org>
935 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
937 2012-02-07 Chong Yidong <cyd@gnu.org>
939 * buffer.c (Fbuffer_local_variables)
940 (buffer_lisp_local_variables): Handle unbound vars correctly;
941 don't let Qunbound leak into Lisp.
943 2012-02-07 Glenn Morris <rgm@gnu.org>
945 * image.c (Fimagemagick_types): Doc fix.
947 * image.c (imagemagick-render-type): Change it from a lisp object
948 to an integer. Move the doc here from the lisp manual.
949 Treat all values not equal to 0 the same.
951 2012-02-06 Chong Yidong <cyd@gnu.org>
953 * doc.c (store_function_docstring): Avoid applying docstring of
954 alias to base function (Bug#2603).
956 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
958 * .gdbinit (pp1, pv1): Remove redundant defines.
961 2012-02-04 Chong Yidong <cyd@gnu.org>
963 * nsterm.m: Declare a global (Bug#10694).
965 2012-02-04 Eli Zaretskii <eliz@gnu.org>
967 * w32.c (get_emacs_configuration_options):
968 Include --enable-checking, if specified, in the return value.
970 2012-02-04 Martin Rudalics <rudalics@gmx.at>
972 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
973 after rounding frame sizes. (Bug#9723)
975 2012-02-04 Eli Zaretskii <eliz@gnu.org>
977 * keyboard.c (adjust_point_for_property): Don't position point
978 before BEGV. (Bug#10696)
980 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
982 Handle overflow when computing char display width (Bug#9496).
983 * character.c (char_width): Return EMACS_INT, not int.
984 (char_width, c_string_width): Check for overflow when
985 computing the width; this is possible now that individual
986 characters can have unbounded width. Problem introduced
987 by merge from Emacs 23 on 2012-01-19.
989 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
991 * dbusbind.c (Fdbus_register_method): Mention the return value
992 :ignore in the docstring.
994 2012-02-02 Glenn Morris <rgm@gnu.org>
996 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
998 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
999 Unconditionally set to t. (Bug#10673)
1000 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1001 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1002 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1004 2012-02-02 Kenichi Handa <handa@m17n.org>
1006 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1007 0, do not call append_composite_glyph.
1009 2012-02-02 Kenichi Handa <handa@m17n.org>
1011 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1013 (x_produce_glyphs): If the component of a composition is a null
1014 string, set it->pixel_width to 1 to avoid zero-width glyph.
1016 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1018 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1019 first 2 arguments are identical. This makes inserting large
1020 output from a subprocess an order of magnitude faster on
1021 MS-Windows, where all sbrk'ed memory is always contiguous.
1023 2012-01-31 Glenn Morris <rgm@gnu.org>
1025 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1026 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1027 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1029 2012-01-29 Glenn Morris <rgm@gnu.org>
1031 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1033 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1035 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1037 2012-01-28 Chong Yidong <cyd@gnu.org>
1039 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1041 2012-01-26 Chong Yidong <cyd@gnu.org>
1043 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1045 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1046 repeat counts (Bug#10507).
1048 2012-01-26 Glenn Morris <rgm@gnu.org>
1050 * lread.c (syms_of_lread): Doc fix.
1052 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1054 * coding.c (encode_designation_at_bol): Change return value to
1057 2012-01-25 Chong Yidong <cyd@gnu.org>
1059 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1061 2012-01-21 Chong Yidong <cyd@gnu.org>
1063 * floatfns.c (Fcopysign): Make the second argument non-optional,
1064 since nil is not allowed anyway.
1066 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1068 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1069 (send_process): Likewise.
1071 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1073 * window.c (save_window_save, Fcurrent_window_configuration)
1074 (Vwindow_persistent_parameters): Do not use Qstate.
1075 Rewrite doc-strings.
1077 2012-01-19 Kenichi Handa <handa@m17n.org>
1079 * character.c (char_width): New function.
1080 (Fchar_width, c_string_width, lisp_string_width):
1081 Use char_width (Bug#9496).
1083 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1085 * window.c (Vwindow_persistent_parameters): New variable.
1086 (Fset_window_configuration, save_window_save): Handle persistent
1089 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1091 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1092 thrashing the stack of the thread. (Bug#9087)
1094 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1096 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1098 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1100 * xdisp.c (rows_from_pos_range): Handle the case where the
1101 highlight ends on a newline. (Bug#10464)
1102 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1103 he end column for display of highlight that ends on a newline
1106 2012-01-11 Glenn Morris <rgm@gnu.org>
1108 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1109 from load-path also when installation-directory is nil. (Bug#10208)
1111 2012-01-10 Glenn Morris <rgm@gnu.org>
1113 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1115 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1116 Update template values to be closer to their typical values these days.
1118 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1120 * xdisp.c (rows_from_pos_range): Accept additional argument
1121 DISP_STRING, and accept any glyph in a row whose object is that
1122 string as eligible for mouse highlight. Fixes mouse highlight of
1123 display strings from overlays. (Bug#10464)
1125 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1127 emacs: fix an auto-save permissions race condition (Bug#10400)
1128 * fileio.c (auto_saving_dir_umask): New static var.
1129 (Fmake_directory_internal): Use it.
1130 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1131 creating the directory. The old code temporarily assigns
1132 too-generous permissions to the directory.
1133 (do_auto_save_eh): Clear it.
1134 (Fdo_auto_save): Catch all errors, not just file errors, so
1135 that the var is always cleared.
1137 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1139 * search.c (scan_buffer): Pass character positions to
1140 know_region_cache, not byte positions. (Bug#6540)
1142 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1144 * w32.c (sys_rename): Report EXDEV when rename of a directory
1145 fails because the target is on another logical disk. (Bug#10284)
1147 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1149 * xterm.c (x_embed_request_focus): New function.
1151 * xterm.h: Add prototype.
1153 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1155 2012-01-05 Glenn Morris <rgm@gnu.org>
1157 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1159 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1161 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1162 Load gnutls_transport_set_lowat only if GnuTLS version is below
1164 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1165 GnuTLS versions below 2.11.1.
1167 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1169 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1170 to the doc string advising against its use for altering the way
1171 windows are scrolled.
1173 2011-12-28 Kenichi Handa <handa@m17n.org>
1175 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1176 coding-system ASCII compatible only when it does not produce BOM
1177 on encoding (Bug#10383).
1179 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1181 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1183 (create_and_show_popup_menu): Always use menu_position_func for
1186 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1188 * callint.c (Fcall_interactively): Don't truncate prompt string.
1190 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1192 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1193 property that ends at ZV, so that the bidi iteration could be
1194 resumed from there (after widening). (Bug#10360)
1196 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1198 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1200 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1202 * nsterm.m (x_free_frame_resources):
1203 Release f->output_data.ns->miniimage.
1204 (ns_index_color): Fix indentation. Do not retain
1205 color_table->colors[i].
1207 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1210 * nsfns.m (x_set_background_color): Assign return value from
1211 ns_index_color to face-background instead of NSColor*.
1212 (ns_implicitly_set_icon_type): Fix indentation.
1213 Change assignment in for loop to comparison.
1215 * emacs.c (ns_pool): New variable.
1216 (main): Assign ns_pool.
1217 (Fkill_emacs): Call ns_release_autorelease_pool.
1219 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1220 autorelease fdesc, release fdAttrs and tdict.
1221 (ns_get_covering_families): Release charset.
1222 (ns_findfonts): Release NSFontDescriptor created with new.
1223 (ns_uni_to_glyphs): Fix indentation.
1224 (setString): Release attrStr before assigning new value.
1226 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1228 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1230 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1231 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1233 2011-12-18 David Reitter <reitter@cmu.edu>
1235 * nsterm.m (ns_term_init): Subscribe for notifications
1236 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1237 to method trackingNotification in EmacsMenu.
1239 * nsmenu.m (trackingMenu): New variable.
1240 (trackingNotification): New method (from Aquamacs).
1241 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1242 from Aquamacs (Bug#7030).
1244 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1246 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1247 (symbol_to_nsstring): Fix indentation.
1248 (ns_symbol_to_pb): New function.
1249 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1250 (Fns_rotate_cut_buffers_internal): Remove.
1251 (Fns_store_selection_internal): Rename from
1252 Fns_store_cut_buffer_internal.
1253 (ns_get_foreign_selection, Fx_own_selection_internal)
1254 (Fx_disown_selection_internal, Fx_selection_exists_p)
1255 (Fns_get_selection_internal, Fns_store_selection_internal):
1256 Use ns_symbol_to_pb and check if return value is nil.
1257 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1258 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1259 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1260 renamed to Sns_store_selection_internal.
1261 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1262 and remove this function.
1263 (ns_handle_selection_clear): Remove, never used.
1264 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1267 2011-12-17 Ken Brown <kbrown@cornell.edu>
1269 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1270 GID is unknown (Bug#10257).
1272 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1274 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1275 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1276 which caused a build failure on GNU/Linux IA-64. This problem was
1277 introduced by my 2011-10-07 patch.
1279 2011-12-15 Juri Linkov <juri@jurta.org>
1281 * image.c (imagemagick_error): New function. (Bug#10112)
1282 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1283 Use `imagemagick_error' where ImageMagick functions return
1285 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1288 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1290 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1291 fill background (Bug#8992).
1293 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1295 * window.c (Vwindow_combination_resize)
1296 (Vwindow_combination_limit): Use t instead of non-nil in
1298 (Vrecenter_redisplay): Add first sentence of doc-string on
1300 (Frecenter): Fix doc-string typo.
1302 2011-12-11 Kenichi Handa <handa@m17n.org>
1304 * coding.c (Funencodable_char_position): Pay attention to the
1305 buffer text relocation (Bug#9389).
1307 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1309 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1310 gtk_init (Bug#10100).
1312 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1314 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1315 IT->string is nil. (Bug#10263)
1317 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1319 * nsterm.h (x_free_frame_resources): Declare.
1321 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1322 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1324 * nsterm.h (ns_get_defaults_value): Declare.
1326 * nsterm.m (ns_default): Call ns_get_defaults_value.
1328 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1330 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1333 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1335 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1336 that where the value of an _OBJC_* symbol points to is in the .bss
1337 section (Bug#10240).
1339 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1341 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1342 after the loop to call ccl_driver at least once (Bug#8619).
1344 2011-12-08 Kenichi Handa <handa@m17n.org>
1346 * ftfont.c (get_adstyle_property): Fix previous change
1349 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1351 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1352 dirs from the default value of EMACSLOADPATH (bug#10208).
1354 2011-12-07 Glenn Morris <rgm@gnu.org>
1356 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1357 installation and source directories as well. (Bug#10208)
1359 2011-12-06 Chong Yidong <cyd@gnu.org>
1361 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1363 2011-12-06 Glenn Morris <rgm@gnu.org>
1365 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1366 as an error, not just -1. (Bug#10217)
1368 2011-12-05 Chong Yidong <cyd@gnu.org>
1370 * keyboard.c (process_special_events): New function.
1371 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1373 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1375 * coding.c (encode_designation_at_bol): Don't use uninitialized
1376 local variable (Bug#9318).
1378 2011-12-05 Kenichi Handa <handa@m17n.org>
1380 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1381 return Qnil (Bug#8046, Bug#10193).
1383 2011-12-05 Kenichi Handa <handa@m17n.org>
1385 * coding.c (encode_designation_at_bol): New args charbuf_end and
1386 dst. Return the number of produced bytes. Callers changed.
1387 (coding_set_source): Return how many bytes coding->source was
1389 (coding_set_destination): Return how many bytes
1390 coding->destination was relocated.
1391 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1392 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1394 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1396 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1397 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1400 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1402 The following changes are to fix Bug#9318.
1404 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1405 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1406 (encode_coding_iso_2022, encode_coding_sjis)
1407 (encode_coding_big5, encode_coding_charset): Use the above macros.
1409 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1411 * lisp.h (process_quit_flag): Fix external declaration.
1413 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1415 Don't macro-inline non-performance-critical code.
1416 * eval.c (process_quit_flag): New function.
1417 * lisp.h (QUIT): Use it.
1419 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1421 * nsfns.m (get_geometry_from_preferences): New function.
1422 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1424 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1426 * emacs.c (Qkill_emacs): Define.
1427 (syms_of_emacs): Initialize it.
1428 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1429 Qquit_flag to `kill-emacs' instead.
1430 (quit_throw_to_read_char): Add parameter `from_signal'.
1431 All callers changed. Call Fkill_emacs if requested and safe.
1432 * lisp.h (QUIT): Call Fkill_emacs if requested.
1434 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1436 * widget.c (update_wm_hints): Return if wmshell is null.
1437 (widget_update_wm_size_hints): New function.
1439 * widget.h (widget_update_wm_size_hints): Declare.
1441 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1442 widget_update_wm_size_hints (Bug#10104).
1444 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1447 before a newline, prepare the bidi iterator for consuming the
1448 newline, and keep the current paragraph direction. (Bug#10183)
1449 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1451 2011-12-02 Juri Linkov <juri@jurta.org>
1453 * search.c (Fword_search_regexp): New Lisp function created from
1454 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1455 (Fword_search_backward, Fword_search_forward)
1456 (Fword_search_backward_lax, Fword_search_forward_lax):
1457 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1458 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1460 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1462 * fileio.c (Finsert_file_contents): Move after-change-function call
1463 to before the "handled:" label, since all "goto handled" appear in
1464 cases where the *-change-functions have already been properly called
1467 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1469 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1470 waiting for input. (Bug#10169)
1472 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1474 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1475 verifies glyph row's hash code--we have just reallocated the
1476 glyphs, so their contents can be complete garbage. (Bug#10164)
1478 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1480 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1482 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1484 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1485 attributes are tested _before_ calling verify_row_hash, to protect
1486 against GCC re-ordering of the tests. (Bug#10164)
1488 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1490 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1492 * xterm.c (handle_one_xevent): Only set async_visible and friends
1493 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1494 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1495 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1497 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1499 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1500 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1501 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1502 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1503 All uses changed to use GCPRO1 etc.
1504 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1505 Revert to old implementation (i.e., before 2011-03-11).
1507 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1509 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1510 of scroll runs so as to avoid assigning disabled bogus rows and
1511 unnecessary graphics copy operations.
1513 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1515 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1516 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1517 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1518 (malloc, free, realloc, calloc): Redirect to e_* only when
1521 * lisp.h (GCTYPEBITS): Move before first use.
1522 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1523 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1524 this macro definition.
1526 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1529 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1531 * gtkutil.c (xg_create_frame_widgets):
1532 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1533 present with Gtk+ 2.0.
1535 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1537 * fileio.c (Finsert_file_contents): Undo previous change; see
1538 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1540 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1542 Rename locals to avoid shadowing.
1543 * fileio.c (Finsert_file_contents):
1544 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1545 * process.c (wait_reading_process_output):
1546 Rename inner 'proc' to 'p' to avoid shadowing.
1547 Indent for consistency with usual Emacs style.
1549 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1551 * xdisp.c (redisplay_window): If cursor row is not fully visible
1552 after recentering, and scroll-conservatively is set to a large
1553 number, scroll window by a few more lines to make the cursor fully
1554 visible and out of scroll-margin. (Bug#10105)
1555 (start_display): Don't move to the next line if the display should
1556 start at a newline that is part of a display vector or an overlay
1559 2011-11-24 Juri Linkov <juri@jurta.org>
1561 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1562 after the `MagickPingImage' call. (Bug#10112)
1564 2011-11-23 Chong Yidong <cyd@gnu.org>
1566 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1568 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1570 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1571 making another buffer current. (Bug#10114)
1573 2011-11-23 Glenn Morris <rgm@gnu.org>
1575 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1577 2011-11-23 Chong Yidong <cyd@gnu.org>
1579 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1580 using it (Bug#5984).
1582 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1584 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1585 and header-lines, as they don't have one computed for them.
1588 * .gdbinit (prow): Make displayed values more self-explaining.
1589 Add row's hash code.
1591 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1593 * process.c (wait_reading_process_output): Fix asynchrounous
1594 GnuTLS socket handling on some versions of the GnuTLS library.
1595 (wait_reading_process_output): Add comment and URL.
1597 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1599 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1601 2011-11-21 Chong Yidong <cyd@gnu.org>
1603 * window.c (Fnext_window, Fprevious_window): Doc fix.
1605 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1607 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1609 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1611 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1613 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1615 * window.c (Fset_window_combination_limit): Rename argument
1617 (Vwindow_combination_limit): Remove "status" from doc-string.
1619 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1621 * m/ibms390.h: Remove.
1622 * m/ibms390x.h: Don't include "ibms390.h".
1624 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1626 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1627 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1629 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1631 * casetab.c (Fset_case_table):
1632 * charset.c (Fcharset_after): Fix typos.
1634 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1636 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1637 Otherwise, valgrind does not work on some platforms.
1638 Problem reported by Andreas Schwab in
1639 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1640 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1641 is set, removing the need for VIRT_ADDRESS_VARIES.
1642 (PURE_P): Use a more-efficient implementation that needs just one
1643 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1644 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1645 to 4 (xorl, subq, cmpq, setbe).
1646 * alloc.c (pure): Always extern now, since that's the
1647 VIRT_ADDR_VARIES behavior.
1648 (PURE_POINTER_P): Use a single comparison, not two, for
1649 consistency with the new puresize.h.
1650 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1651 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1652 Remove VIRT_ADDR_VARIES no longer needed.
1654 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1656 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1657 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1658 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1659 behave as if the cursor position were at the window margin.
1661 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1662 and the cursor position is out of bounds, behave as if the cursor
1663 position were at the window margin. (Bug#10075)
1665 2011-11-18 Chong Yidong <cyd@gnu.org>
1667 * window.c (Fwindow_combination_limit): Make first argument
1668 non-optional, since it is meaningless for live windows like the
1671 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1673 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1675 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1677 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1678 (graft_intervals_into_buffer): Simplify.
1680 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1682 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1683 hash values of the two rows.
1684 (copy_row_except_pointers): Preserve the used[] arrays and the
1685 hash values of the two rows. (Bug#10035)
1686 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1688 * xdisp.c (row_hash): New function, body extracted from
1689 compute_line_metrics.
1690 (compute_line_metrics): Call row_hash, instead of computing the
1693 * dispnew.c (verify_row_hash): Call row_hash for computing the
1694 hash code of a row, instead of duplicating code from xdisp.c.
1696 * dispextern.h (row_hash): Add prototype.
1698 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1700 * frame.c (delete_frame): Don't delete the terminal when the last
1701 X frame is closed if emacs is built with GTK toolkit.
1703 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1705 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1707 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1709 * window.c (Vwindow_splits): Rename to
1710 Vwindow_combination_resize. Suggested by Juri Linkov.
1711 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1714 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1716 * nsfns.m (Fns_font_name):
1717 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1719 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1721 * window.h (window): Rename slot "nest" to "combination_limit".
1722 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1723 (Fset_window_nest): Rename to Fset_window_combination_limit.
1724 (Vwindow_nest): Rename to Vwindow_combination_limit.
1725 (recombine_windows, make_parent_window, make_window)
1726 (Fsplit_window_internal, saved_window)
1727 (Fset_window_configuration, save_window_save): Rename all
1728 occurrences of window_nest to window_combination_limit.
1730 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1732 * image.c (imagemagick_load_image): Fix typo.
1734 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1736 * xdisp.c (display_line): Move the call to
1737 highlight_trailing_whitespace before the call to
1738 compute_line_metrics, since the latter needs to see the final
1739 faces of all the glyphs to compute ROW's hash value.
1740 Fixes assertion violations in row_equal_p. (Bug#10035)
1742 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1744 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1745 just return (bug#10044).
1747 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1749 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1750 with user-defined heap size. Bump the default size of the temacs
1751 heap to 27MB, to avoid memory warning when running temacs.
1752 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1754 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1755 current_matrix and desired_matrix. (Bug#9990)
1756 (verify_row_hash) [XASSERTS]: New function.
1757 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1758 that the hash value of glyph rows is correct.
1760 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1762 * window.h (window): Remove splits slot.
1763 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1764 (Fdelete_other_windows_internal, make_parent_window)
1765 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1766 (Fset_window_configuration, save_window_save): Don't deal with
1767 split status of windows.
1768 (saved_window): Remove splits slot.
1769 (Vwindow_splits): Rewrite doc-string.
1771 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1773 * xfns.c (unwind_create_frame):
1774 * nsfns.m (unwind_create_frame):
1775 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1776 Vframe_list (Bug#9999).
1778 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1780 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1782 2011-11-11 Kenichi Handa <handa@m17n.org>
1784 * callproc.c (Fcall_process): Set the member dst_multibyte of
1787 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1789 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1790 avoid a crash (bug#9496).
1792 2011-11-09 Chong Yidong <cyd@gnu.org>
1794 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1795 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1797 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1799 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1801 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1803 Avoid some portability problems by eschewing 'extern inline' functions.
1804 The trivial performance wins aren't worth the portability hassles; see
1805 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1807 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1808 (window_box_width, window_box_left, window_box_left_offset)
1809 (window_box_right, window_box_right_offset): Undo previous change,
1810 by removing the "extern"s.
1811 * intervals.c (adjust_intervals_for_insertion)
1812 (adjust_intervals_for_deletion): Undo previous change,
1813 making these static again.
1814 (offset_intervals, temp_set_point_both, temp_set_point)
1815 (copy_intervals_to_string): No longer inline.
1816 * xdisp.c (window_text_bottom_y, window_box_width)
1817 (window_box_height, window_box_left_offset)
1818 (window_box_right_offset, window_box_left, window_box_right)
1819 (window_box): No longer inline.
1821 2011-11-08 Chong Yidong <cyd@gnu.org>
1823 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1824 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1825 Signal an error if not a live window.
1826 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1827 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1829 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1831 * lisp.h (syms_of_abbrev): Remove declaration.
1832 Reported by CHENG Gao <chenggao@royau.me>.
1834 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1836 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1837 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1838 of temacs in GUI mode.
1840 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1842 * window.h: Declare delete_all_child_windows instead of
1843 delete_all_subwindows.
1844 * window.c (Fwindow_nest, Fset_window_nest)
1845 (Fset_window_new_total, Fset_window_new_normal)
1846 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1847 (delete_all_subwindows): Rename to delete_all_child_windows.
1848 (Fdelete_other_windows_internal, Fset_window_configuration):
1849 Call delete_all_child_windows instead of delete_all_subwindows.
1850 * frame.c (delete_frame): Call delete_all_child_windows instead
1851 of delete_all_subwindows.
1853 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1855 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1856 This is also needed for porting to any host where GC_MARK_STACK is
1857 not GC_MAKE_GCPROS_NOOPS.
1858 (which_symbols): Use it.
1860 2011-11-07 Kenichi Handa <handa@m17n.org>
1862 * coding.c (coding_set_destination): Check coding->src_pos only
1863 when coding->src_object is a buffer (bug#9910).
1865 * process.c (send_process): Set the member src_multibyte of coding
1866 to 0 (bug#9911) when sending a unibyte text.
1868 * callproc.c (Fcall_process): Set the member src_multibyte of
1869 process_coding to 0 (bug#9912).
1871 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1873 * xmenu.c (cleanup_widget_value_tree): New function.
1874 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1875 calling free_menubar_widget_value_tree directly (Bug#9830).
1877 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1879 Fix some portability problems with 'inline'.
1880 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1881 (window_box_width, window_box_left, window_box_left_offset)
1882 (window_box_right, window_box_right_offset): Declare extern.
1883 Otherwise, these inline functions do not conform to C99 and
1884 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1886 * intervals.c (adjust_intervals_for_insertion)
1887 (adjust_intervals_for_deletion): Now extern, because otherwise the
1888 extern inline functions 'offset_intervals' couldn't refer to it.
1889 (static_offset_intervals): Remove.
1890 (offset_intervals): Rewrite using the old contents of
1891 static_offset_intervals. The old version didn't conform to C99
1892 because an extern inline function contained a reference to an
1893 identifier with static linkage.
1895 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1897 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1900 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1902 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1903 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1904 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1905 return Qleft_to_right.
1907 2011-11-06 Chong Yidong <cyd@gnu.org>
1909 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1910 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1911 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1912 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1913 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1914 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1915 (Fwindow_vscroll): Doc fix.
1916 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1917 argument, since it makes no sense to pass a live window and for
1918 consistency with window-child.
1920 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1922 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1925 2011-11-05 Jason Rumney <jasonr@gnu.org>
1927 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1928 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1930 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1931 bitwise arithmetic preventing use of unicode-sip and non-truetype
1934 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1936 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1939 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1940 initialization code to keep similarity to xfns.c after changes
1943 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1945 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1946 (unwind_create_frame): New function (Bug#9943).
1947 (Fx_create_frame): Restructure code to be more similar to the one in
1948 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1949 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1950 Move terminal->reference_count++ just before making the frame official
1953 * nsterm.m (x_free_frame_resources): New function.
1954 (x_destroy_window): Move code to x_free_frame_resources.
1956 * xfns.c (unwind_create_frame): Fix comment.
1957 (Fx_create_frame, x_create_tip_frame):
1958 Move terminal->reference_count++ just before making the frame
1959 official. Move initialization of image_cache_refcount and
1960 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1962 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1964 Support MSVC build with newer versions of Visual Studio.
1965 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1966 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1969 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1970 which are not supported by MSVC.
1971 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1972 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1974 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1976 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1978 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1980 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1982 Support MSVC build with newer versions of Visual Studio.
1983 * w32.c: Don't include w32api.h for MSVC.
1984 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1986 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1987 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1988 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1989 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1991 (alloca) [_MSC_VER]: Define to _alloca.
1993 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1995 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1997 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1999 * xdisp.c (note_mouse_highlight): If either of
2000 previous/next-single-property-change returns nil, treat that as
2001 the beginning or the end of the buffer. (Bug#9955)
2003 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2005 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2006 label is not null (Bug#9951).
2007 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2010 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2012 * window.c (Fwindow_body_size): Mention in the doc string that the
2013 return value is in frame's canonical units. (Bug#9949)
2015 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2017 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2019 * w32fns.c (unwind_create_frame): If needed, free the glyph
2020 matrices of the partially constructed frame. (Bug#9943)
2021 * xfns.c (unwind_create_frame): Likewise.
2023 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2025 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2026 Don't stop backward scan on the continuation glyph, even though
2027 its CHARPOS is positive.
2028 (mouse_face_from_buffer_pos, note_mouse_highlight):
2029 Rename cover_string to disp_string.
2031 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2033 * window.c (temp_output_buffer_show): Don't use
2034 Vtemp_buffer_show_specifiers.
2035 (Vtemp_buffer_show_specifiers): Remove unused variable.
2037 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2039 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2040 past the beginning of the current glyph matrix.
2042 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2044 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2045 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2046 HAVE_GTK3 (Bug#9869).
2048 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2049 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2051 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2053 * xterm.c: Declare x_handle_net_wm_state to return int.
2054 (handle_one_xevent): Check if we are iconified but don't have
2055 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2056 (get_current_wm_state): Return non-zero if not hidden,
2057 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2058 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2059 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2060 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2062 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2064 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2065 so that this new function doesn't get optimized away by a
2066 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2068 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2070 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2072 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2074 Fix the `xbytecode' command.
2075 * .gdbinit (xprintbytestr): New command.
2076 (xwhichsymbols): Rename from `which'; all callers changed.
2077 (xbytecode): Print the byte-code string as well.
2079 2011-10-29 Kim Storm <storm@cua.dk>
2081 * alloc.c (which_symbols): New function.
2083 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2085 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2088 2011-10-29 Glenn Morris <rgm@gnu.org>
2090 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2091 Not clear what it was for, and it causes various bugs. (Bug#9839)
2093 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2095 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2096 possible random value that matches one of those tested as
2097 condition to clear the mouse face.
2099 2011-10-28 Chong Yidong <cyd@gnu.org>
2101 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2103 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2105 * window.c (make_window): Initialize phys_cursor_on_p.
2107 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2109 * lisp.h (struct Lisp_Symbol): Update comments.
2111 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2113 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2115 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2117 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2118 <oslsachem@gmail.com> for helping to debug this.
2120 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2121 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2122 (g_b_init_get_glyph_outline_w): New static variables.
2123 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2124 (GetGlyphOutlineW_Proc): New typedefs.
2125 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2126 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2128 (w32font_open_internal, compute_metrics):
2129 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2130 instead of calling the "wide" APIs directly.
2132 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2134 * w32.h (syms_of_w32font): Add prototype.
2136 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2138 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2139 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2140 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2141 (Fmove_to_window_line): Doc fix.
2143 2011-10-27 Chong Yidong <cyd@gnu.org>
2145 * process.c (make_process): Set gnutls_state to NULL.
2147 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2148 non-NULL, regardless of GNUTLS_INITSTAGE.
2149 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2150 an error. Set process slots as soon as we allocate them.
2152 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2154 2011-10-27 Chong Yidong <cyd@gnu.org>
2156 * gnutls.c (emacs_gnutls_deinit): New function.
2157 Deallocate credentials structures as well as calling gnutls_deinit.
2158 (Fgnutls_deinit, Fgnutls_boot): Use it.
2160 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2161 (deactivate_process): Call emacs_gnutls_deinit.
2163 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2165 * image.c (x_create_x_image_and_pixmap):
2166 * w32.c (sys_rename, w32_delayed_load):
2167 * w32font.c (fill_in_logfont):
2168 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2170 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2172 * w32fns.c (w32_default_color_map): New function,
2173 extracted from Fw32_default_color_map.
2174 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2176 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2178 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2180 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2182 * keyboard.c (test_undefined): New function (bug#9751).
2183 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2185 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2187 * sysdep.c (init_sys_modes): Fix the check for the controlling
2188 terminal (Bug#6649).
2190 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2192 * dispextern.h (struct bidi_it): New member next_en_type.
2194 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2195 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2196 current character, check also for next_en_type being WEAK_EN.
2197 (bidi_resolve_weak): Don't enter the expensive loop if the current
2198 position is before next_en_pos. Record the bidi type of the first
2199 non-ET, non-BN character we find, in addition to its position.
2200 (bidi_level_of_next_char): Invalidate next_en_type when
2201 next_en_pos is over-stepped.
2203 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2205 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2206 * editfns.c: Rewrite current-time-zone so that it invokes
2207 the equivalent of (format-time-string "%Z") to get the time zone name.
2208 This fixes a bug when the time zone name contains characters that
2209 need converting from the system time locale to Emacs internal format.
2210 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2211 that patch fixed format-time-string to do the conversion, but
2212 I forgot to fix current-time-zone.
2213 (format_time_string): New function, containing most of
2214 what Fformat_time_string used to contain.
2215 (Fformat_time_string): Rewrite in terms of format_time_string.
2216 This doesn't change this function's behavior.
2217 (current-time-zone): Rewrite to use format_time_string.
2218 This fixes the bug reported by Michael Schierl in
2219 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2220 Jason Rumney's 2007-06-07 change worked around this bug, but
2222 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2224 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2226 * xdisp.c (start_display): If the character at POS is displayed
2227 via a display vector, reset IT->current.dpvec_index to zero.
2228 (try_window_reusing_current_matrix): If a line ends in a display
2229 vector or the next line starts in a display vector, continue
2230 redrawing the window even though the character position of
2231 start_row was reached.
2234 2011-10-18 Chong Yidong <cyd@gnu.org>
2236 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2237 with nobreak-char-display too.
2239 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2241 Fix part 3 of bug#9771.
2242 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2243 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2244 non-neutral characters if the current character is a paragraph
2245 separator (a.k.a. Newline). This avoids running the same
2246 expensive loop twice, once when we consume the preceding newline
2247 and the other time when the line actually needs to be displayed.
2248 Avoid the loop when we see neutrals on the base embedding level
2249 following a character whose directionality is the same as the
2250 paragraph's. This avoids running the expensive loop when a line
2251 ends in a long sequence of neutrals, like control characters.
2252 Add assertion against STRONG_AL type. Slightly rearrange code
2253 that determines the type of a neutral given the first non-neutral
2255 (bidi_level_of_next_char): Set next_en_pos to zero when
2256 invalidating its info.
2258 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (push_display_prop): Determine whether to record string
2261 or buffer position by IT->string, not by IT->method. Allow
2262 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2263 (move_it_vertically_backward): Don't look for character position
2264 immediately after the newline when in a continuation line.
2267 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2269 * window.c (coordinates_in_window): Rewrite and delabelize
2270 vertical border check. (Bug#5357) (Bug#9618)
2272 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2274 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2275 errors in XSetWindowBorder (bug#9310).
2277 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2279 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2280 avoid crash when xmalloc overrun checking is enabled.
2282 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2284 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2285 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2286 cursor motion with <left> and <right> arrow keys.
2288 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2289 some callers set that themselves.
2291 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2293 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2294 display string and the previous row comes from the same string and
2295 is empty. (Bug#9739) (Bug#9738)
2297 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2299 * doc.c (get_doc_string): Encode file name (bug#9735).
2301 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2303 * bidi.c (bidi_level_of_next_char):
2304 * xdisp.c (get_visually_first_element): Remove old incorrect
2305 comments regarding the Unicode Line Separator character.
2307 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2309 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2311 * alloc.c (Fgc_status): Do not access beyond zombies array
2312 boundary if nzombies > MAX_ZOMBIES.
2313 * alloc.c (dump_zombies): Add missing format specifier.
2315 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2317 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2318 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2320 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2321 Some packages use them to denote characters with modifiers.
2323 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2325 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2326 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2327 matching a pp-number. Rename parameter var to var1.
2329 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2331 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2333 2011-10-08 Glenn Morris <rgm@gnu.org>
2335 * callint.c (Fcall_interactively): Give a more explicit error for the
2336 'c' case with a non-character input. (Bug#8479)
2338 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2340 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2342 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2343 lines that are hscrolled on the left.
2345 * dispnew.c (buffer_posn_from_coords): Account for a possible
2346 presence of header-line. (Bug#4426)
2348 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2350 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2351 Don't advertise functionality which we discourage or doesn't work.
2353 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2355 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2356 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2357 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2358 this makes Emacs dump core during garbage collection on rare
2359 occasions. sizeof is obviously inferior to offsetof here, so
2360 stick with offsetof.
2361 (GC_POINTER_ALIGNMENT): New macro.
2362 (mark_memory): Omit 3rd (offset) arg; caller changed.
2363 Don't assume EMACS_INT alignment is the same as pointer alignment.
2365 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2367 * keyboard.c (read_key_sequence_remapped): New var.
2368 (read_key_sequence): Compute remapping in the right buffer.
2369 (command_loop_1): Use read_key_sequence's remapping directly.
2371 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2373 * dired.c (file_name_completion): Don't expand file name.
2374 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2375 before checking file name handler.
2377 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2378 they've been requested explicitly (bug#9591).
2380 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2382 * keymap.c (Fsingle_key_description): Use make_specified_string
2383 instead of build_string to build string from push_key_description.
2386 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2388 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2389 This fixes a Y2038 bug on 64-bit hosts.
2390 * buffer.c (reset_buffer):
2391 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2392 (Fclear_buffer_auto_save_failure):
2393 Use 0, not -1, to represent an unset failure time, since time_t
2394 might not be signed.
2396 Remove dependency on glibc malloc internals.
2397 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2398 Move back here from lisp.h, but with their new implementations.
2399 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2400 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2401 * charset.c (charset_table_init): New static var.
2402 (syms_of_charset): Use it instead of xmalloc. This removes a
2403 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2404 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2405 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2406 Move back to alloc.c.
2407 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2408 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2410 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2412 * nsterm.m (windowDidResize): Call x_set_window_size only when
2413 ns_in_resize is true. Otherwise set pixelwidth/height and
2414 call change_frame_size (Bug#9628).
2416 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2418 Port --enable-checking=all to Fedora 14 x86-64.
2419 * charset.c (syms_of_charset): Also account for glibc malloc's
2420 internal overhead when calculating the initial malloc maximum.
2422 Port --enable-checking=all to Fedora 14 x86.
2423 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2425 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2426 (overrun_check_realloc, overrun_check_free):
2427 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2428 That way, xmalloc returns a properly-aligned pointer even if
2429 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2430 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2431 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2432 into account when calculating the initial malloc maximum.
2433 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2434 Move here from alloc.c, so that charset.c can use it too.
2435 Properly align; the old code wasn't right for common 32-bit hosts
2436 when configured with --enable-checking=all.
2437 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2438 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2440 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2442 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2445 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2447 * xdisp.c (compute_display_string_end): If there's no display
2448 string at CHARPOS, return -1.
2450 * bidi.c (bidi_fetch_char): When compute_display_string_end
2451 returns a negative value, treat the character as a normal
2452 character not covered by a display string. (Bug#9624)
2454 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2456 * lread.c (Fread_from_string): Fix typo in docstring.
2458 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2460 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2461 newline, reseat the iterator instead of bidi-iterating there one
2462 character at a time. (Bug#9610)
2463 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2464 TO_CHARPOS if the bidi iterator is at base embedding level.
2466 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2468 * lread.c (readevalloop): Use correct code for NBSP.
2469 (read1): Likewise. (Bug#9608)
2471 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2473 * dbusbind.c (Fdbus_register_signal): When service is not
2474 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2476 2011-09-25 Glenn Morris <rgm@gnu.org>
2478 * buffer.c (truncate-lines): Doc fix.
2480 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2482 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2483 (Fset_window_next_buffers): Doc fix.
2485 2011-09-24 Glenn Morris <rgm@gnu.org>
2487 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2489 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2491 Fix minor problems found by static checking.
2492 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2493 * indent.c (Fvertical_motion): Fix == vs = typo.
2495 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2497 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2498 Default value is now t. Doc fix.
2500 * indent.c (Fvertical_motion): Compute and apply the overshoot
2501 logic when moving up, not only when moving down. Fix the
2502 confusing name and values of the it_overshoot_expected variable;
2503 logic changes accordingly. (Bug#9254) (Bug#9549)
2505 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2506 CHARPOS is covered by a display string which includes newlines.
2507 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2508 is covered by a display string with embedded newlines.
2510 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2512 * dbusbind.c (Fdbus_register_signal): Add match rule to
2513 Vdbus_registered_objects_table. (Bug#9581)
2514 (Fdbus_register_method, Vdbus_registered_objects_table):
2517 2011-09-24 Jim Meyering <meyering@redhat.com>
2519 do not ignore write error for any output size
2520 The previous change was incomplete.
2521 While it makes emacs --batch detect the vast majority of stdout
2522 write failures, errors were still ignored whenever the output size is
2523 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2524 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2525 && echo FAIL: ignored write error
2526 FAIL: ignored write error
2527 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2528 && echo FAIL: ignored write error
2529 FAIL: ignored write error
2530 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2532 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2534 * emacs.c (Fkill_emacs): In noninteractive mode exit
2535 non-successfully if a write error occurred on stdout. (Bug#9574)
2537 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2539 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2542 * dispextern.h (struct it): Update the comment documenting what
2545 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2547 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2548 a display string, extend search for cursor position to end of row.
2549 (find_row_edges): If the row ends in a newline from a display
2550 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2551 Handle the case of a display string with multiple newlines.
2552 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2553 non-empty line. Fixes confusing cursor motion with arrow keys at
2554 the beginning of a line that starts with whitespace.
2556 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2558 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2561 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2563 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2566 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2568 * xdisp.c (display_line): Record maximum and minimum buffer
2569 positions even if no glyphs were produced (e.g., by a zero-width
2570 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2571 buffer positions that will be removed from the glyph row because
2573 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2574 column is beyond frame width: don't subtract 1 "pixel" when
2575 computing width of the stretch.
2576 (reseat_at_next_visible_line_start): Undo the change made on
2577 2011-09-17 that saved paragraph information and restored it after
2578 the call to `reseat'. (Bug#9545)
2580 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2582 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2583 and turn window cursor on if cleared (Bug#9415).
2585 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2587 * search.c (boyer_moore): Take unibyte characters from pattern
2588 literally. (Bug#9458)
2590 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2592 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2594 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2596 Fix minor problem found by static checking.
2597 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2598 initialized, to pacify gcc -Wuninitialized.
2600 * fileio.c: Report proper errno when syscall falls.
2601 (Finsert_file_contents): Save and restore errno,
2602 so that report_file_error outputs the correct diagnostic.
2603 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2605 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2607 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2609 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2611 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2612 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2614 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2616 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2617 about the current paragraph and restore it after the call to reseat.
2619 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2620 (bidi_find_paragraph_start): Search back for paragraph beginning
2621 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2622 (bidi_move_to_visually_next): Only trigger paragraph-related
2623 computations when the last character is a newline or at EOB, not
2624 just any NEUTRAL_B. (Bug#9470)
2626 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2627 truncated lines if point is covered by a display string. (Bug#9524)
2629 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2631 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2632 (cons_to_x_long): New function.
2633 (lisp_data_to_selection_data): Use it. Correct the test for
2634 short-versus-long data; it was negated. Break out of vector
2635 loop, for efficiency, when a long datum is discovered.
2637 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2639 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2641 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2643 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2644 GCC PR/17406) by declaring this function with external scope.
2646 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2648 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2649 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2651 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2653 * editfns.c (Fformat): Correctly handle text properties on "%%".
2655 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2657 * xterm.c (x_draw_composite_glyph_string_foreground):
2658 * w32term.c (x_draw_composite_glyph_string_foreground):
2659 * term.c (encode_terminal_code):
2660 * composite.c (composition_update_it, get_composition_id):
2661 * xdisp.c (get_next_display_element)
2662 (fill_composite_glyph_string): Add comments about special meaning
2663 of TAB characters in a composition.
2665 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2667 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2668 This occurs when processing a multibyte format.
2669 Problem reported by Wolfgang Jenker.
2671 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2673 * xdisp.c (try_cursor_movement): Only check for exact match if
2674 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2676 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2678 Remove unused external symbols.
2679 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2680 * xdisp.c (calc_pixel_width_or_height): Now static.
2681 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2682 * indent.c (check_display_width):
2683 * w32term.c: Fix comment to match code.
2684 * xterm.c, xterm.h (x_catching_errors): Remove.
2686 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2688 * xselect.c: Use signed conversions more consistently (Bug#9498).
2689 (selection_data_to_lisp_data): Assume incoming selection data are
2690 signed integers, not unsigned. This is to be consistent with
2691 outgoing selection data, which was modified to use signed integers
2692 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2693 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2694 expects long, not unsigned long.
2696 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2699 computation of loop end. Reported by Johan Bockgård
2702 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2704 * frame.c (Fother_visible_frames_p): Function deleted.
2706 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2708 * indent.c (compute_motion): Process display vector front to back
2709 rather than the other way around. (Bug#2496)
2711 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2713 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2715 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2717 * minibuf.c (Fread_from_minibuffer): Doc fix.
2719 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2721 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2722 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2724 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2726 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2727 value for non-existent files.
2729 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2731 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2732 set its "size" to -1. This will set the modtime_size field of
2733 the corresponding buffer to -1, which is what
2734 verify-visited-file-modtime expects for files that do not exist.
2737 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2739 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2741 * lisp.h: ... from here. push_key_description is no longer
2742 defined in keyboard.c, so its declaration should not be in
2743 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2744 logically belongs with push_key_description.
2746 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2748 * buffer.h: Include <sys/types.h> instead of <time.h>.
2749 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2750 Problem reported by Herbert J. Skuhra.
2752 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2754 * xml.c (parse_region): Make the parsing work for
2755 non-comment-starting XML files again (bug#9144).
2757 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2759 * image.c (gif_load): Fix calculation of bottom and right corner.
2762 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2764 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2765 redisplay in small windows.
2767 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2769 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2771 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2773 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2774 Operate on live windows only.
2776 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2778 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2780 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2782 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2783 only under bidi iteration.
2785 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2787 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2789 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2791 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2792 Without this fix, the command to link temacs failed due to an
2793 undefined symbol __builtin_isnan. This is because
2794 /usr/include/iso/math_c99.h #defines isnan(x) to
2795 __builtin_isnan(x), but the bundled gcc, which identifies itself
2796 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2798 * floatfns.c (isnan): #undef, and then #define to a clone of
2800 (Fisnan): Always define, since it's always available now.
2801 (syms_of_floatfns): Always define isnan at the Lisp level.
2803 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2805 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2807 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2809 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2810 The previous code assumed that file offsets (off_t values) fit in
2811 EMACS_INT variables, which is not true on typical 32-bit hosts.
2812 The code messed up by falsely reporting buffer overflow in cases
2813 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2814 when "big" contains more than 2**29 bytes, even though this
2815 inserts just one byte and does not overflow the buffer.
2816 (Finsert_file_contents): Store file offsets as off_t
2817 values, not as EMACS_INT values. Check for overflow when
2818 converting between EMACS_INT and off_t. When checking for
2819 buffer overflow or for overlap, take the offsets into account.
2820 Don't use EMACS_INT for small values where int suffices.
2821 When checking for overlap, fix a typo: ZV was used where
2822 ZV_BYTE was intended.
2823 (Fwrite_region): Don't assume off_t fits into 'long'.
2824 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2826 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2828 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2830 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2832 sprintf-related integer and memory overflow issues (Bug#9412).
2834 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2835 (esprintf, exprintf, evxprintf): New functions.
2836 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2837 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2838 (modify_event_symbol): Do not assume that the length of
2839 name_alist_or_stem is safe to alloca and fits in int.
2840 (Fexecute_extended_command): Likewise for function name and binding.
2841 (Frecursion_depth): Wrap around reliably on integer overflow.
2842 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2843 since some callers pass EMACS_INT values.
2844 (Fsingle_key_description): Don't crash if symbol name contains more
2845 than MAX_ALLOCA bytes.
2846 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2847 (get_minibuffer): Arg is now EMACS_INT, not int.
2848 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2849 (esprintf, exprintf, evxprintf): New decls.
2850 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2852 * dbusbind.c (signature_cat): New function.
2853 (xd_signature, Fdbus_register_signal):
2854 Do not overrun buffer; instead, report string overflow.
2856 * dispnew.c (add_window_display_history): Don't overrun buffer.
2857 Truncate instead; this is OK since it's just a log.
2859 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2860 even if the time zone offset is outlandishly large.
2861 Don't mishandle offset == INT_MIN.
2863 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2864 when creating daemon; the previous buffer-overflow check was incorrect.
2866 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2867 which has the guts of the old verror function.
2869 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2870 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2872 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2873 (font_unparse_xlfd): Don't blindly alloca long strings.
2874 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2875 fits in int, when using sprintf. Use single snprintf to count
2876 length of string rather than counting it via multiple sprintfs;
2877 that's simpler and more reliable.
2878 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2879 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2880 sprintf, in case result does not fit in int.
2882 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2883 (fontset_from_font): Print it.
2885 * frame.c (tty_frame_count): Now printmax_t, not int.
2886 (make_terminal_frame, set_term_frame_name): Print it.
2887 (x_report_frame_params): In X, window IDs are unsigned long,
2888 not signed long, so print them as unsigned.
2889 (validate_x_resource_name): Check for implausibly long names,
2890 and don't assume name length fits in 'int'.
2891 (x_get_resource_string): Don't blindly alloca invocation name;
2892 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2895 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2896 (xg_check_special_colors, xg_set_geometry):
2897 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2899 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2900 Use esprintf, not sprintf, in case result does not fit in int.
2902 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2903 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2904 it as a large positive number.
2905 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2906 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2908 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2909 in case result does not fit in int.
2911 * print.c (float_to_string): Detect width overflow more reliably.
2912 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2913 buffer overrun. Don't assume list length fits in 'int'. Treat
2914 print length of 0 as 0, not as infinity; to be consistent with other
2915 uses of print length in this function. Don't overflow print length
2916 index. Don't assume hash table size fits in 'long', or that
2917 vectorlike size fits in 'unsigned long'.
2919 * process.c (make_process): Use printmax_t, not int, to format
2920 process-name gensyms.
2922 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2924 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2925 to avoid potential buffer overrun.
2927 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2928 if X resource line is longer than 512 bytes.
2930 * xfns.c (x_window): Make sprintf buffer a bit bigger
2931 to avoid potential buffer overrun.
2933 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2935 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2937 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2939 Integer overflow fixes for scrolling, etc.
2940 Without these, Emacs silently mishandles large integers sometimes.
2941 For example, "C-u 4294967297 M-x recenter" was treated as if
2942 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2944 * xdisp.c (try_window_id): Check Emacs fixnum range before
2945 converting to 'int'.
2947 * window.c (window_scroll_line_based, Frecenter):
2948 Check that an Emacs fixnum is in range before assigning it to 'int'.
2949 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2950 values converted from Emacs fixnums.
2951 (Frecenter): Don't wrap around a line count if it is out of 'int'
2952 range; instead, treat it as an extreme value.
2953 (Fset_window_configuration, compare_window_configurations):
2954 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2956 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2957 that can exceed INT_MAX. Check that EMACS_INT value is in range
2958 before assigning it to the (possibly-narrower) index.
2959 (match_limit): Don't assume that a fixnum can fit in 'int'.
2961 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2964 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2965 (Fvertical_motion): Don't wrap around LINES values that don't fit
2966 in 'int'. Instead, treat them as extreme values. This is good
2967 enough for windows, which can't have more than INT_MAX lines anyway.
2969 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2971 * Require libxml/parser.h to avoid compilation warning.
2973 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2975 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2976 since this reportedly can destroy thread storage.
2978 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2980 * syntax.c (find_defun_start): Update all cache variables if
2981 exiting early (Bug#9401).
2983 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2985 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2987 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2988 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2989 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2991 * term.c (tty_append_glyph): New function.
2992 (produce_stretch_glyph): Static function and its prototype deleted.
2994 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2997 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2999 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3000 when checking :margin (Bug#9390).
3001 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3002 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3003 so that the name doesn't mislead. All uses changed.
3005 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3007 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3010 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3012 * xdisp.c (move_it_to): Don't bail out early when reaching
3013 position beyond to_charpos, if we are scanning backwards.
3014 (move_it_vertically_backward): When DY == 0, make sure we get to
3015 the first character in the line after the newline.
3017 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3019 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3020 (ccl_driver): Do not generate an out-of-range pointer.
3021 (Fccl_execute_on_string): Remove unnecessary check for
3022 integer overflow, noted by Stefan Monnier in
3023 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3024 Remove a FIXME that didn't need fixing.
3025 Simplify the newly-introduced buffer reallocation code.
3027 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3029 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3031 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3033 Integer and memory overflow issues (Bug#9196).
3035 * doc.c (get_doc_string): Rework so that
3036 get_doc_string_buffer_size is the actual buffer size, rather than
3037 being 1 less than the actual buffer size; this makes xpalloc more
3040 * image.c (x_allocate_bitmap_record, cache_image):
3041 * xselect.c (Fx_register_dnd_atom):
3042 Simplify previous changes by using xpalloc.
3044 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3045 since either will do and ptrdiff_t is convenient with xpalloc.
3047 * charset.c (charset_table_size)
3048 (struct charset_sort_data.priority): Now ptrdiff_t.
3049 (charset_compare): Don't overflow if priorities differ greatly.
3050 (Fsort_charsets): Don't assume list length fits in int.
3051 Check for size-calculation overflow when allocating sort data.
3052 (syms_of_charset): Allocate an initial charset table that is
3053 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3055 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3057 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3058 The actual value is always <= INT_MAX, and leaving it unsigned made
3059 overflow checking harder.
3061 * dispextern.h (struct glyph_matrix.rows_allocated)
3062 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3063 with xpalloc. The values are still always <= INT_MAX.
3065 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3067 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3068 (SAFE_NALLOCA): New macro.
3070 * region-cache.c (struct boundary.pos, find_cache_boundary)
3071 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3072 (set_cache_region, invalidate_region_cache)
3073 (revalidate_region_cache, know_region_cache, region_cache_forward)
3074 (region_cache_backward, pp_cache):
3075 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3076 so that ptrdiff_t * can be passed to xpalloc.
3077 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3078 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3079 (pp_cache): Don't assume cache_len fits in int.
3080 * region-cache.h: Adjust extern decls to match.
3082 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3083 EMACS_INT, since either will do, for xpalloc.
3085 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3086 (xnmalloc, xnrealloc, xpalloc): New functions.
3088 * bidi.c (bidi_shelve_header_size): New constant.
3089 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3090 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3092 * bidi.c (bidi_cache_shrink):
3093 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3095 Don't update size of array until after memory allocation succeeds,
3096 because xmalloc/xrealloc may not return.
3097 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3098 now that we have proper integer overflow checking.
3099 (record_overlay_string, overlay_strings): Catch overflows when
3100 calculating size of overlay_str_buf.
3102 * callproc.c (Fcall_process): Check for size overflow when
3103 calculating size of args2.
3104 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3105 Normally we prefer signed values, but sticking with ptrdiff_t would
3106 require adding more-complicated checks.
3108 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3109 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3110 Redo buffer-overflow calculations to avoid integer overflow.
3111 Add a FIXME comment where memory seems to be over-allocated.
3113 * character.c (Fstring): Check for size-calculation overflow.
3115 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3116 unnecessary integer overflow. Check for size overflow.
3117 (encode_coding_object): Don't update size until xmalloc succeeds.
3119 * composite.c (get_composition_id): Check for overflow in glyph
3120 length calculations.
3122 Integer and memory overflow fixes for display code.
3123 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3124 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3125 (scrolling_window): Check for overflow in size calculations.
3126 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3127 Don't assume glyph table len fits in int.
3128 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3129 (row_table_size): Now ptrdiff_t, not int.
3130 (scrolling_window): Avoid overflow in size calculations.
3131 Don't update size until allocation succeeds.
3132 * fns.c (concat): Check for overflow in size calculations.
3133 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3134 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3135 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3137 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3138 (get_doc_string): Check for size calculation overflow.
3139 Don't update size until allocation succeeds.
3140 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3141 EMACS_INT, where ptrdiff_t will do.
3142 (Fsubstitute_command_keys): Check for string overflow.
3144 * editfns.c (set_time_zone_rule): Don't assume environment length
3146 (message_length): Now ptrdiff_t, not int.
3147 (Fmessage_box): Don't update size until allocation succeeds.
3148 Don't assume message length fits in int.
3149 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3151 * emacs.c (main): Do not reallocate argv, since there is a null at
3152 the end that can be overwritten, and this way there's no need to
3153 worry about size-calculation overflow.
3154 (sort_args): Check for size-calculation overflow.
3156 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3158 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3160 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3161 (x_set_scroll_bar_width, x_figure_window_size):
3162 Check for integer overflow.
3163 (x_set_alpha): Do not assume XINT fits in int.
3165 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3166 This is for the members text_lines, text_cols, total_lines, total_cols,
3167 where the system imposes an 'int' limit.
3169 * fringe.c (Fdefine_fringe_bitmap):
3170 Don't update size until alloc works.
3172 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3173 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3175 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3176 Check for size-calculation overflow.
3177 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3178 do, as we prefer signed integers.
3179 (id_to_widget.max_size, id_to_widget.used)
3180 (xg_store_widget_in_map, xg_remove_widget_from_map)
3181 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3182 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3183 Use and return ptrdiff_t, not int.
3184 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3185 * gtkutil.h: Change prototypes to match the above.
3187 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3188 are duplicate now that they've been promoted to lisp.h.
3189 (x_allocate_bitmap_record, x_alloc_image_color)
3190 (make_image_cache, cache_image, xpm_load):
3191 Don't update size until alloc is done.
3192 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3194 Check for size calculation overflow.
3195 (ct_colors_allocated_max): New constant.
3196 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3199 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3200 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3201 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3202 Use ptrdiff_t, not int, to count maps.
3203 (read_char_minibuf_menu_prompt): Check for overflow in size
3204 calculations. Don't update size until allocation succeeds.
3205 Redo calculations to avoid overflow.
3206 * keyboard.h: Change prototypes to match the above.
3208 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3210 (current_minor_maps): Check for size calculation overflow.
3211 * keymap.h: Change prototypes to match the above.
3213 * lread.c (read1, init_obarray): Don't update size until alloc done.
3215 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3216 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3218 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3219 Now ptrdiff_t, not int.
3220 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3221 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3223 * process.c (Fnetwork_interface_list): Check for overflow
3224 in size calculation.
3226 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3228 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3229 overflow. Don't bother calling xmalloc when xrealloc will do.
3231 * search.c (Freplace_match): Check for size calculation overflow.
3232 (Fset_match_data): Don't assume list lengths fit in 'int'.
3234 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3235 for command line length. Do not attempt to address one before the
3236 beginning of an array, as that's not portable.
3238 * term.c (max_frame_lines): Remove; unused.
3239 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3241 (encode_terminal_code, calculate_costs): Check for size
3242 calculation overflow.
3243 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3244 table lengths and related sizes. Don't update size until alloc
3245 done. Redo calculations to avoid overflow.
3246 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3248 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3249 subtracting pointers.
3250 (gobble_line): Check for overflow more carefully. Don't update size
3253 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3254 Don't update size until alloc done.
3255 Redo size calculations to avoid overflow.
3256 Check for size calculation overflow.
3257 (main) [DEBUG]: Fix typo in invoking tparam1.
3259 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3260 Use ptrdiff_t, not int, for sizes.
3261 (store_mode_line_noprop_char): Don't update size until alloc done.
3263 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3264 Use ptrdiff_t, not int, for sizes.
3265 (Finternal_make_lisp_face, cache_face):
3266 Check for size calculation overflow.
3267 (cache_face): Treat size calculation overflows as if they were
3268 memory exhaustion (the usual treatment), rather than aborting.
3270 * xfns.c (x_encode_text, x_set_name_internal)
3271 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3272 sizes, since they can exceed INT_MAX in size. Check for size
3273 calculation overflow.
3275 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3276 (xg_select): Check for size calculation overflow.
3277 Don't update size until alloc done.
3279 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3280 as sprintf is limited to int lengths.
3282 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3283 (X_LONG_MIN): New macros.
3284 Use them to make the following changes clearer.
3285 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3286 This change doesn't affect the value now, but it may help remind
3287 future maintainers not to raise the value too much later.
3288 (SELECTION_QUANTUM): Remove, replacing with ...
3289 (selection_quantum): ... new function, which avoids overflow.
3291 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3292 assumption that selection length fits in 'int'.
3293 (x_reply_selection_request, x_handle_selection_request)
3294 (x_get_window_property, receive_incremental_selection)
3295 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3296 (lisp_data_to_selection_data, clean_local_selection_data):
3297 Use ptrdiff_t, not int, to record length of selection.
3298 (x_reply_selection_request, x_get_window_property)
3299 (receive_incremental_selection, x_property_data_to_lisp):
3300 Redo calculations to avoid overflow.
3301 (x_reply_selection_request): When sending hint, ceiling it at
3302 X_LONG_MAX rather than relying on wraparound overflow to send
3304 (x_get_window_property, receive_incremental_selection)
3305 (lisp_data_to_selection_data, x_property_data_to_lisp):
3306 Check for size-calculation overflow.
3307 (x_get_window_property, receive_incremental_selection)
3308 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3309 Don't store size until memory allocation succeeds.
3310 (x_get_window_property): Plug memory leak on memory exhaustion.
3311 Don't double-block input; malloc is safe here. Don't assume 2**34
3312 - 4 fits in unsigned long. Add an xassert to check
3313 XGetWindowProperty overflow. Be more careful about overflow
3314 calculations, and distinguish size from memory overflow better.
3315 (receive_incremental_selection): When tracing, don't assume
3316 unsigned int is less than INT_MAX.
3317 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3318 harmful) conversions of unsigned short to int.
3319 (lisp_data_to_selection_data): Don't assume that integers
3320 in the range -65535 through -1 fit in an X unsigned short.
3321 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3322 result parameters unless successful. Rely on cons_to_unsigned
3323 to report problems with elements; the old code wasn't right anyway.
3324 (x_check_property_data): Check for int overflow; we cannot use
3325 a wider type due to X limits.
3326 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3328 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3330 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3331 (x_term_init): Check for size calculation overflow.
3332 (x_color_cells): Don't store size until memory allocation succeeds.
3333 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3334 Don't assume alloca size is less than MAX_ALLOCA.
3335 (x_term_init): Don't assume length fits in int (sprintf is limited
3338 Use ptrdiff_t for composition IDs.
3339 * character.c (lisp_string_width):
3340 * composite.c (composition_table_size, n_compositions)
3341 (get_composition_id, composition_gstring_from_id):
3342 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3343 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3344 * window.c (Frecenter):
3345 Use ptrdiff_t, not int, for composition IDs.
3346 * composite.c (get_composition_id): Check for integer overflow.
3347 * composite.h: Adjust prototypes to match the above changes.
3349 Use ptrdiff_t for hash table indexes.
3350 * category.c (hash_get_category_set):
3351 * ccl.c (ccl_driver):
3352 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3353 * coding.c (coding_system_charset_list, detect_coding_system):
3354 * coding.h (struct coding_system.id):
3355 * composite.c (get_composition_id, gstring_lookup_cache):
3356 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3357 * image.c (xpm_get_color_table_h):
3358 * lisp.h (hash_lookup, hash_put):
3359 * minibuf.c (Ftest_completion):
3360 Use ptrdiff_t for hash table indexes, not int (which is too
3361 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3362 32-bit --with-wide-int hosts).
3364 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3365 Add a FIXME comment about memory leaks.
3366 (syms_of_charset): Don't assume xmalloc returns.
3368 Don't assume that stated character widths fit in int.
3369 * character.c (Fchar_width, c_string_width, lisp_string_width):
3370 * character.h (CHAR_WIDTH):
3371 * indent.c (MULTIBYTE_BYTES_WIDTH):
3372 Use sanitize_char_width to avoid undefined and/or bad behavior
3373 with outlandish widths.
3374 * character.h (sanitize_tab_width): Rename from sanitize_width,
3375 now that we have two such functions. All uses changed.
3376 (sanitize_char_width): New inline function.
3378 Don't assume that tab-width fits in int.
3379 * character.h (sanitize_width): New inline function.
3380 (SANE_TAB_WIDTH): New macro.
3381 (ASCII_CHAR_WIDTH): Use it.
3382 * indent.c (sane_tab_width): Remove. All uses replaced by
3383 SANE_TAB_WIDTH (current_buffer).
3384 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3386 * fileio.c: Integer overflow issues with file modes.
3387 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3389 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3390 Remove unreachable code.
3391 (read_hex, load_charset_map_from_file): Check for integer overflow.
3393 * xterm.c: Don't go over XClientMessageEvent limit.
3394 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3395 (x_send_scroll_bar_event): Likewise. Check that the size does not
3396 exceed limits imposed by XClientMessageEvent, as well as the usual
3397 ptrdiff_t and size_t limits.
3399 * keyboard.c: Overflow, signedness and related fixes.
3400 (make_lispy_movement): Use same integer type in forward decl
3401 that is used in the definition.
3402 (read_key_sequence, keyremap_step):
3403 Change bufsize argument back to int, undoing my 2011-03-30 change.
3404 We prefer signed types, and int is wide enough here.
3405 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3406 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3407 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3408 length, not size_t. Use ptrdiff_t for index, not int.
3409 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3410 possibility of integer overflow.
3412 Overflow, signedness and related fixes for images.
3414 * dispextern.h (struct it.stack[0].u.image.image_id)
3415 (struct_it.image_id, struct image.id, struct image_cache.size)
3416 (struct image_cache.used, struct image_cache.ref_count):
3417 * gtkutil.c (update_frame_tool_bar):
3418 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3419 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3420 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3421 * nsmenu.m (update_frame_tool_bar):
3422 * xdisp.c (calc_pixel_width_or_height):
3423 * xfns.c (image_cache_refcount):
3424 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3425 on typical 64-bit hosts.
3427 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3428 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3429 Omit unnecessary casts to int.
3430 (parse_image_spec): Check that integers fall into 'int' range
3431 when the callers expect that.
3432 (image_ascent): Redo ascent calculation to avoid int overflow.
3433 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3434 (lookup_image): Remove unnecessary tests.
3435 (xbm_image_p): Locals are now of int, not EMACS_INT,
3436 since parse_image_check makes sure they fit into int.
3437 (png_load, gif_load, svg_load_image):
3438 Prefer int to unsigned where either will do.
3439 (tiff_handler): New function, combining the cores of the
3440 old tiff_error_handler and tiff_warning_handler.
3441 This function is rewritten to use vsnprintf and thereby avoid
3442 stack buffer overflows. It uses only the features of vsnprintf
3443 that are common to both POSIX and native Microsoft.
3444 (tiff_error_handler, tiff_warning_handler): Use it.
3445 (tiff_load, gif_load, imagemagick_load_image):
3446 Don't assume :index value fits in 'int'.
3447 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3448 (imagemagick_load_image): Check that crop parameters fit into
3449 the integer types that MagickCropImage accepts. Don't assume
3450 Vimagemagick_render_type has a nonnegative value. Don't assume
3451 size_t fits in 'long'.
3452 (gs_load): Use printmax_t to print the widest integers possible.
3453 Check for integer overflow when computing image height and width.
3455 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3457 * xdisp.c (redisplay_window): Don't force window start if point
3458 will be invisible in the resulting window. (Bug#9324)
3460 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3463 the display spec is of the form `(space ...)'.
3464 (handle_display_spec): Return the value returned by
3465 handle_single_display_spec, not just 1 or zero.
3466 (handle_single_display_spec): If the display spec is of the form
3467 `(space ...)', and specifies display in the text area, return 2
3469 (try_cursor_movement): Check for the need to scroll more
3470 accurately, and prefer exact match for point under bidi.
3471 Don't advance `row' beyond the last row of the window.
3473 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3474 into disp_prop; all users changed.
3476 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3477 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3478 for the text covered by the display property.
3480 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3482 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3483 Change return value to nil.
3484 (Frecord_buffer): Delete unused function.
3486 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3488 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3489 buffers, return left-to-right.
3490 (set_cursor_from_row): Consider candidate row a win if its glyph
3491 represents a newline and point is on that newline. Fixes cursor
3492 positioning on the newline at EOL of R2L text within L2R
3493 paragraph, and vice versa.
3494 (try_cursor_movement): Check continued rows, in addition to
3495 continuation rows. Fixes unwarranted scroll when point enters a
3496 continued line of R2L text within an L2R paragraph, or vice versa.
3497 (cursor_row_p): Consider the case of point being equal to
3498 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3499 from the end of a short line to the beginning of a continued line
3500 of R2L text within L2R paragraph.
3501 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3502 composed characters.
3504 * bidi.c (bidi_check_type): Use xassert.
3505 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3508 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3510 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3513 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3515 * nsfont.m (ns_otf_to_script): Fix typo.
3517 2011-08-22 Kenichi Handa <handa@m17n.org>
3519 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3520 extra slot even if the purpose is char-code-property-table.
3522 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3524 * xdisp.c (redisplay_window): When computing centering_position,
3525 account for the height of the header line. (Bug#8874)
3527 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3528 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3529 candidate is selected by the mouse, and that candidate has a
3530 composed character under the mouse.
3532 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3533 coordinates reported by pos-visible-in-window-p for a composed
3534 character in column zero.
3536 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3538 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3540 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3542 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3543 consider it a hit if to_charpos is anywhere in the range of the
3544 composed buffer positions.
3546 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3548 * image.c (gif_load): Don't assume that each subimage has the same
3549 dimensions as the base image. Handle disposal method that is
3550 "undefined" by the gif spec (Bug#9335).
3552 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3554 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3555 (Fcondition_case): Document `debug' symbol in error handler.
3557 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3559 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3560 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3561 from an Org mode buffer to a Speedbar frame.
3563 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3564 a composition, take its buffer position from IT->cmp_it.charpos.
3565 Fixes cursor positioning at the beginning of a line that begins
3566 with a composed character.
3568 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3570 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3571 character bidirectional type, use STRONG_L instead. Fixes crashes
3572 in a buffer produced by `describe-categories'.
3574 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3575 members before the level stack, so they would be saved and
3576 restored when copying iterator state. Fixes incorrect reordering
3577 around TABs covered by display properties.
3579 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3581 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3583 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3585 * eval.c (internal_condition_case, internal_condition_case_1)
3586 (internal_condition_case_2, internal_condition_case_n):
3587 Remove unnecessary aborts (Bug#9081).
3589 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3591 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3592 has no `load' handler, try opening the file locally. (Bug#9311)
3594 2011-08-16 Ken Brown <kbrown@cornell.edu>
3596 * gmalloc.c: Expand comment.
3598 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3600 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3601 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3603 2011-08-16 Ken Brown <kbrown@cornell.edu>
3605 Fix memory allocation problems in Cygwin build (Bug#9273).
3607 * unexcw.c ( __malloc_initialized): Declare external variable.
3608 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3610 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3612 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3614 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3616 [CYGWIN] (special_realloc): New function.
3617 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3618 requests to realloc storage in the static heap.
3620 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3622 * bidi.c (bidi_initialize): Remove unused local.
3624 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3627 * biditype.h: Remove file.
3628 * makefile.w32-in ($(BLD)/bidi.$(O)):
3629 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3631 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3633 * chartab.c: Improve commentary for the uniprop_table API.
3635 * bidi.c (bidi_paragraph_init): Support zero value of
3636 bidi_ignore_explicit_marks_for_paragraph_level.
3637 (bidi_initialize): Use uniprop_table instead of including
3638 biditype.h and bidimirror.h.
3640 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3641 coordinates of the iterator when restoring from ppos_it.
3644 2011-08-14 Kenichi Handa <handa@m17n.org>
3646 * process.c (create_process): Call setup_process_coding_systems
3647 after the pid of the process is set to -1 (Bug#8162).
3649 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3651 * xdisp.c (move_it_in_display_line_to): Don't invoke
3652 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3653 ppos_it. Fixes vertical cursor motion when line beginning is
3654 covered by an image. (Bug#9296)
3656 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3658 * nsterm.h (ns_run_ascript): Declare.
3659 (NSAPP_DATA2_RUNASSCRIPT): Define.
3661 * nsfns.m (as_script, as_result, as_status): New static variables.
3662 (ns_run_ascript): New function.
3663 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3664 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3665 the event loop. Get status from as_status (Bug#7276).
3667 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3668 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3669 the event loop (Bug#7276).
3671 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3673 * gnutls.c (QCgnutls_bootprop_priority)
3674 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3675 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3676 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3677 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3678 (QCgnutls_bootprop_verify_hostname_error)
3679 (QCgnutls_bootprop_callbacks_verify): Rename from
3680 Qgnutls_bootprop_..., all uses changed.
3682 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3685 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3687 * xfaces.c (Qframe_set_background_mode): Now static.
3688 * dispextern.h (Qframe_set_background_mode): Remove decl.
3690 * process.c (Fnetwork_interface_info): Declare local only if needed.
3692 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3694 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3695 (Fnetwork_interface_list): Allocate in increments of bytes instead
3696 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3697 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3699 (struct ifflag_def): notrailers is smart on OSX.
3700 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3701 Get hardware address with getifaddrs if available.
3703 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3705 * xdisp.c (iterate_out_of_display_property): xassert that
3706 IT->position is set to within IT->object's boundaries. Break from
3707 the loop as soon as EOB is reached; avoids infloops in redisplay
3708 when IT->position is set up wrongly due to some bug.
3709 Set IT->current to match the bidi iterator unconditionally.
3710 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3711 entry. Force push_it to save on the stack the current
3712 buffer/string position, to be restored by pop_it. Fix flags in
3713 the iterator structure wrt the object coming from a display
3714 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3715 properties. (Bug#9284)
3717 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3719 * fontset.c (fontset_get_font_group): Add proper type checks.
3722 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3724 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3725 and LC_VERSION_MIN_MACOSX.
3726 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3727 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3729 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3731 * xdisp.c (forward_to_next_line_start): Allow to use the
3732 no-display-properties-and-no-overlays under bidi display.
3733 Set disp_pos in the bidi iterator to avoid searches for display
3734 properties and overlays.
3736 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3738 * editfns.c (Fset_time_zone_rule): Document relationship with the
3741 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3742 the font entity extracted from the cache (Bug#8109).
3744 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3746 * composite.c (autocmp_chars): Don't reset point. That is done by
3747 restore_point_unwind (Bug#5984).
3749 2011-08-07 Juri Linkov <juri@jurta.org>
3751 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3752 to show the arg `TIME' instead of `TIMEVAL'.
3754 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3756 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3757 display property strides EOL and includes a newline, as in
3758 longlines-mode. (Bug#9254)
3759 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3760 word-wrap under bidirectional display. (Bug#9224)
3762 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3763 is non-zero, even if the data buffer is NULL. Fixes a crash in
3764 vertical-motion with longlines-mode. (Bug#9254)
3766 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3768 * bidi.c <bidi_cache_total_alloc>: Now static.
3769 (bidi_initialize): Initialize bidi_cache_total_alloc.
3771 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3774 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3775 amount allocated this far in `bidi_cache_total_alloc'.
3776 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3777 non-zero, only free the data buffer without restoring the cache
3778 contents. All callers changed.
3780 * dispextern.h (bidi_unshelve_cache): Update prototype.
3782 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3783 (move_it_in_display_line, move_it_to)
3784 (move_it_vertically_backward, move_it_by_lines): Replace the call
3785 to xfree to an equivalent call to bidi_unshelve_cache.
3786 (move_it_in_display_line_to): Fix logic of returning
3787 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3789 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3791 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3792 came from a string character with a `cursor' property. (Bug#9229)
3794 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3796 * Makefile.in (LIB_PTHREAD): New variable.
3797 (LIBES): Add LIB_PTHREAD (Bug#9216).
3799 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3800 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3802 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3804 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3806 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3808 * xterm.c (x_find_topmost_parent): New function.
3809 (x_set_frame_alpha): Find topmost parent window with
3810 x_find_topmost_parent and set the property there also (bug#9181).
3811 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3813 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3815 * callproc.c (Fcall_process): Avoid vfork clobbering
3816 the local vars buffer, coding_systems, current_dir.
3818 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3820 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3822 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3824 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3825 so that it is not optimized away.
3827 * xdisp.c (compute_display_string_pos): Remove unused local.
3829 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3831 Fix slow cursor motion and scrolling in large buffers with
3832 selective display, like Org Mode buffers. (Bug#9218)
3834 * dispextern.h (struct bidi_it): New member disp_prop_p.
3836 * xdisp.c: Remove one-slot cache of display string positions.
3837 (compute_display_string_pos): Accept an additional argument
3838 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3839 for a display string or property. If found, set DISP_PROP_P
3842 * bidi.c (bidi_fetch_char): Accept an additional argument
3843 DISP_PROP_P, and pass it to compute_display_string_pos.
3844 Only handle text covered by a display string if DISP_PROP_P is returned
3845 non-zero. All callers of bidi_fetch_char changed.
3847 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3849 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3851 2010-12-03 Don March <don@ohspite.net>
3853 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3854 last character M-[char] is translated to ESC [char] (bug#7541).
3856 2011-08-02 Kenichi Handa <handa@m17n.org>
3858 * lisp.h (uniprop_table): Extern it.
3860 * chartab.c (uniprop_table): Make it non-static.
3862 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3864 * xdisp.c (forward_to_next_line_start): Accept additional argument
3865 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3867 (reseat_at_next_visible_line_start): Use the bidi iterator state
3868 returned by forward_to_next_line_start to restore the state of
3869 it->bidi_it after backing up to previous newline. (Bug#9212)
3871 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3873 * regex.c (re_comp): Protoize.
3874 (re_exec): Fix return type.
3875 (regexec): Fix type of `ret'. (Bug#9203)
3877 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3879 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3880 This is needed if max-image-size is a floating-point number.
3882 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3884 * print.c (print_object): Print empty symbol as ##.
3886 * lread.c (read1): Read ## as empty symbol.
3888 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3890 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3891 setting frame foreground color (Bug#9175).
3892 (x_set_background_color): Likewise.
3894 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3895 contents (Bug#9176).
3896 (EmacsTooltip -init): Remove bezels and add shadows to
3899 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3900 or scroll bar (Bug#8470).
3902 * nsfont.m (nsfont_open): Remove assignment to voffset and
3903 unnecessary vars hshink, expand, hd, full_height, min_height.
3904 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3906 * nsterm.h (nsfont_info): Remove voffset field.
3908 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3910 Implement strike-through and overline on NextStep (Bug#8863).
3912 * nsfont.m (nsfont_open): Use underline position provided by font,
3913 instead of hard-coded value of 2.
3914 (nsfont_draw): Call ns_draw_text_decoration instead.
3916 * nsterm.h: Add declaration for ns_draw_text_decoration.
3918 * nsterm.m (ns_draw_text_decoration): New function for drawing
3919 underline, overline, and strike-through.
3920 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3921 ns_draw_text_decoration. Change treatment of cursor drawing to
3922 accommodate underlining, etc.
3924 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3926 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3929 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3931 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3932 Without this fix, if a signal arrives just after memory fills up,
3933 'malloc' might be invoked reentrantly.
3935 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3936 In other words, assume that every image size is allowed, on non-X
3937 hosts. This assumption is probably wrong, but it lets Emacs compile.
3939 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3941 * regex.c (re_iswctype): Convert return values to boolean.
3943 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3945 * xdisp.c (compute_display_string_pos): Don't use cached display
3946 string position if the buffer had its restriction changed.
3949 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3951 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3953 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3955 Integer signedness and overflow and related fixes. (Bug#9079)
3957 * bidi.c: Integer size and overflow fixes.
3958 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3959 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3960 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3961 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3962 (bidi_find_other_level_edge):
3963 Use ptrdiff_t instead of EMACS_INT where either will do.
3964 This works better on 32-bit hosts configured --with-wide-int.
3965 (bidi_cache_ensure_space): Check for size-calculation overflow.
3966 Use % rather than repeated addition, for better worst-case speed.
3967 Don't set bidi_cache_size until after xrealloc returns, because it
3969 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3970 (bidi_cache_ensure_space): Also check that the bidi cache size
3971 does not exceed that of the largest Lisp string or buffer. See Eli
3972 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3974 * alloc.c (__malloc_size_t): Remove.
3975 All uses replaced by size_t. See Andreas Schwab's note
3976 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3978 * image.c: Improve checking for integer overflow.
3979 (check_image_size): Assume that f is nonnull, since
3980 it is always nonnull in practice. This is one less thing to
3981 worry about when checking for integer overflow later.
3982 (x_check_image_size): New function, which checks for integer
3983 overflow issues inside X.
3984 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3985 This removes the need for a memory_full check.
3986 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3987 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3988 (xbm_read_bitmap_data): Change locals back to 'int', since
3989 their values must fit in 'int'.
3990 (xpm_load_image, png_load, tiff_load):
3991 Invoke x_create_x_image_and_pixmap earlier,
3992 to avoid much needless work if the image is too large.
3993 (tiff_load): Treat overly large images as if
3994 x_create_x_image_and_pixmap failed, not as malloc failures.
3995 (gs_load): Use x_check_image_size.
3997 * gtkutil.c: Omit integer casts.
3998 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3999 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4001 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4003 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4004 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4005 would wrongly return t on a 64-bit host.
4007 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4008 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4009 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4010 and therefore cause GCC to emit a bogus diagnostic in some cases.
4012 * image.c: Integer signedness and overflow and related fixes.
4013 This is not an exhaustive set of fixes, but it's time to
4014 record what I've got.
4015 (lookup_pixel_color, check_image_size): Remove redundant decls.
4016 (check_image_size): Don't assume that arbitrary EMACS_INT values
4017 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4018 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4019 (tiff_load, imagemagick_load_image):
4020 Check for overflow in size calculations.
4021 (x_create_x_image_and_pixmap): Remove unnecessary test for
4022 xmalloc returning NULL; that can't happen.
4023 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4024 (xpm_color_bucket): Use better integer hashing function.
4025 (xpm_cache_color): Don't possibly over-allocate memory.
4026 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4027 (gif_memory_source):
4028 Use ptrdiff_t, not int or size_t, to record sizes.
4029 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4030 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4031 either works, as we prefer signed integers.
4032 (tiff_read_from_memory, tiff_write_from_memory):
4033 Return tsize_t, not size_t, since that's what the TIFF API wants.
4034 (tiff_read_from_memory): Don't fail simply because the read would
4035 go past EOF; instead, return a short read.
4036 (tiff_load): Omit no-longer-needed casts.
4037 (Fimagemagick_types): Don't assume size fits into 'int'.
4039 Improve hashing quality when configured --with-wide-int.
4040 * fns.c (hash_string): New function, taken from sxhash_string.
4041 Do not discard information about ASCII character case; this
4042 discarding is no longer needed.
4043 (sxhash-string): Use it. Change sig to match it. Caller changed.
4044 * lisp.h: Declare it.
4045 * lread.c (hash_string): Remove, since we now use fns.c's version.
4046 The fns.c version returns a wider integer if --with-wide-int is
4047 specified, so this should help the quality of the hashing a bit.
4049 * emacs.c: Integer overflow minor fix.
4050 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4051 Define only if GNU_LINUX.
4052 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4054 * dispnew.c: Integer signedness and overflow fixes.
4055 Remove unnecessary forward decls, that were a maintenance hassle.
4056 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4058 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4059 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4060 (prepare_desired_row, line_draw_cost):
4061 Use int, not unsigned, where either works.
4062 (save_current_matrix, restore_current_matrix):
4063 Use ptrdiff_t, not size_t, where either works.
4064 (init_display): Check for overflow more accurately, and without
4065 relying on undefined behavior.
4067 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4068 Remove, replacing with the new symbols in lisp.h. All uses changed.
4069 * fileio.c (make_temp_name):
4070 * filelock.c (lock_file_1, lock_file):
4071 * xdisp.c (message_dolog):
4072 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4073 Use pMd etc. instead.
4074 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4075 replacing the pWIDE etc. symbols removed from editfns.c.
4077 * keyboard.h (num_input_events): Now uintmax_t.
4078 This is (very slightly) less likely to mess up due to wraparound.
4081 * buffer.c: Integer signedness fixes.
4082 (alloc_buffer_text, enlarge_buffer_text):
4083 Use ptrdiff_t rather than size_t when either will do, as we prefer
4086 * alloc.c: Integer signedness and overflow fixes.
4087 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4088 (__malloc_size_t): Default to size_t, not to int.
4089 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4090 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4091 Prefer ptrdiff_t to size_t when either would do, as we prefer
4093 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4094 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4095 Now const. Initialize with values that are in range even if char
4097 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4098 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4099 These functions do the right thing with sizes > 2**32.
4100 (check_depth): Now ptrdiff_t, not int.
4101 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4102 Adjust to new way of storing sizes. Check for size overflow bugs
4104 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4105 slightly wrong anyway, as it missed one instance of
4106 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4107 (refill_memory_reserve): Omit needless cast to size_t.
4108 (mark_object_loop_halt): Mark as externally visible.
4110 * xselect.c: Integer signedness and overflow fixes.
4111 (Fx_register_dnd_atom, x_handle_dnd_message):
4112 Use ptrdiff_t, not size_t, since we prefer signed.
4113 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4114 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4115 x_dnd_atoms_size and x_dnd_atoms_length.
4117 * doprnt.c: Prefer signed to unsigned when either works.
4119 * doprnt.c (doprnt):
4121 * xdisp.c (vmessage):
4122 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4123 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4124 prefer signed arithmetic to avoid comparison confusion.
4125 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4126 but is a bit tricky.
4128 Assume freestanding C89 headers, string.h, stdlib.h.
4129 * data.c, doprnt.c, floatfns.c, print.c:
4130 Include float.h unconditionally.
4131 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4132 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4133 * regex.c: Likewise for stddef.h, string.h.
4134 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4135 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4136 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4137 (STDC_HEADERS): Remove obsolete defines.
4138 * sysdep.c: Include limits.h unconditionally.
4140 Assume support for memcmp, memcpy, memmove, memset.
4141 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4142 * regex.c (memcmp, memcpy):
4143 Remove; we assume C89 now.
4145 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4146 (__malloc_safe_bcopy): Remove; no longer needed.
4148 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4149 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4150 well either way, and we prefer signed to unsigned.
4152 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4155 closes the connection while we're reading (bug#9182).
4157 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4159 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4160 are specified (Bug#9168).
4162 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4164 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4165 Found by GCC static checking and --with-wide-int on a 32-bit host.
4167 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4169 * xdisp.c (compute_display_string_pos): Fix logic of caching
4170 previous display string position. Initialize cached_prev_pos to
4171 -1. Fixes slow-down at the beginning of a buffer.
4173 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4175 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4176 for attrs[LFACE_FONTSET_INDEX].
4178 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4180 * xml.c (parse_region): Remove unused local
4181 that was recently introduced.
4183 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4185 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4186 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4188 * xdisp.c (move_it_in_display_line_to): Record the best matching
4189 position for TO_CHARPOS while scanning the line, and restore it on
4190 exit if none of the characters scanned was an exact match.
4191 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4192 when exact match is impossible due to invisible text, and the
4193 lines are truncated.
4195 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4197 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4200 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4202 Fix a significant slow-down of cursor motion with C-n, C-p,
4203 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4204 auto-repeat under bidi redisplay in fontified buffers.
4205 * xdisp.c (compute_stop_pos_backwards): New function.
4206 (next_element_from_buffer): Call compute_stop_pos_backwards to
4207 find a suitable prev_stop when we find ourselves before
4209 (reseat): Don't look for prev_stop, as that could mean a very long
4211 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4212 <cached_disp_overlay_modiff>: Cache for last found display string
4214 (compute_display_string_pos): Return the cached position if asked
4215 about the same buffer in the same area of character positions, and
4216 the buffer wasn't changed since the time the display string
4217 position was cached.
4219 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4221 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4222 is an integer, which is important for empty lines. (Bug#9149)
4224 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4226 * frame.c (Fmodify_frame_parameters): In tty case, update the
4227 default face if necessary (Bug#4238).
4229 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4231 * editfns.c (Fstring_to_char): No need to explain what a character
4232 is in the docstring (Bug#6576).
4234 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236 * xml.c (parse_region): Make sure we always return a tree.
4238 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4240 * xml.c (parse_region): If a document contains only comments,
4243 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4245 * xml.c (make_dom): Return comments, too.
4247 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4250 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4251 and the surrounding thread.
4252 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4253 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4254 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4256 * s/openbsd.h (BROKEN_SIGIO): Define.
4257 * unexelf.c (unexec) [__OpenBSD__]:
4258 Don't update the .mdebug section of the Alpha COFF symbol table.
4260 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4262 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4265 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4267 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4268 This fixes some race conditions on the permissions of any newly
4271 * alloc.c (valid_pointer_p): Use pipe, not open.
4272 This fixes some permissions issues when debugging.
4274 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4275 If fchown fails to set both uid and gid, try to set just gid,
4276 as that is sometimes allowed. Adjust the file's mode to eliminate
4277 setuid or setgid bits that are inappropriate if fchown fails.
4279 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4281 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4282 to compare Lisp_Objects.
4283 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4284 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4285 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4287 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4289 * lread.c (read_integer): Unread even EOF character.
4290 (read1): Likewise. Properly record start position of symbol.
4292 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4293 symbol character follows.
4295 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4297 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4298 This works around a problem with the previous change to Fcopy_file.
4299 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4300 and without this change, GCC might complain about discarding
4301 fchown's return value.
4303 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4305 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4307 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4309 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4311 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4313 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4314 it's used from the C level.
4316 * process.c: Use the same condition for POLL_FOR_INPUT in both
4317 keyboard.c and process.c (bug#1858).
4319 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4321 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4322 (Fgnutls_boot): Use it.
4324 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4326 * doc.c (Fsubstitute_command_keys): Revert last change.
4328 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4330 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4331 quotes the next character, and doesn't affect other longer
4332 sequences (bug#8935).
4334 * lread.c (syms_of_lread): Clarify that is isn't only
4335 `eval-buffer' and `eval-defun' that's affected by
4336 `lexical-binding' (bug#8460).
4338 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4340 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4341 bidi redisplay when a line includes both an image and is truncated.
4343 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4345 Fix minor problems found by static checking.
4346 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4347 (elsz): Now a signed constant, not a size_t var. We prefer signed
4348 types to unsigned, to avoid integer comparison confusion. Without
4349 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4350 "cannot optimize loop, the loop counter may overflow", a symptom
4352 * indent.c (Fvertical_motion): Mark locals as initialized.
4353 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4355 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4357 * search.c (Fre_search_backward): Mention `case-fold-search' in
4358 all the re_search_* functions (bug#8138).
4360 * keyboard.c (Fopen_dribble_file): Document when the file is
4363 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4365 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4368 Support bidi reordering of display and overlay strings.
4369 * xdisp.c (compute_display_string_pos)
4370 (compute_display_string_end): Accept additional argument STRING.
4371 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4372 (reseat_to_string): Initialize bidi_it->string.s and
4373 bidi_it->string.schars.
4374 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4375 NULL (avoids a crash in bidi_paragraph_init).
4376 Initialize itb.string.lstring.
4377 (init_iterator): Call bidi_init_it only of a valid
4378 buffer position was specified. Initialize paragraph_embedding to
4380 (reseat_to_string): Initialize the bidi iterator.
4381 (display_string): If we need to ignore text properties of
4382 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4383 original value of -1 will not work with bidi.)
4384 (compute_display_string_pos): First arg is now struct
4385 `text_pos *'; all callers changed. Support display properties on
4387 (compute_display_string_end): Support display properties on Lisp
4389 (init_iterator, reseat_1, reseat_to_string): Initialize the
4390 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4391 when iterating on a string not from display properties).
4392 (compute_display_string_pos, compute_display_string_end):
4393 Fix calculation of the object to scan. Fixes an error when using
4395 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4396 base_level_stop; instead, set base_level_stop to BEGV.
4397 Fixes crashes in vertical-motion.
4398 (next_element_from_buffer): Improve commentary for when
4399 the iterator is before prev_stop.
4400 (init_iterator): Initialize bidi_p from the default value of
4401 bidi-display-reordering, not from buffer-local value. Use the
4402 buffer-local value only if initializing for buffer iteration.
4403 (handle_invisible_prop): Support invisible properties on strings
4404 that are being bidi-reordered.
4405 (set_iterator_to_next): Support bidi reordering of C strings and
4407 (next_element_from_string): Support bidi reordering of Lisp
4409 (handle_stop_backwards): Support Lisp strings as well.
4410 (display_string): Support display of R2L glyph rows.
4411 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4412 (init_iterator): Don't initialize it->bidi_p for strings
4414 (reseat_to_string): Initialize it->bidi_p for strings here.
4415 (next_element_from_string, next_element_from_c_string)
4416 (next_element_from_buffer): Add xassert's for correspondence
4417 between IT's object being iterated and it->bidi_it.string
4419 (face_before_or_after_it_pos): Support bidi iteration.
4420 (next_element_from_c_string): Handle the case of the first string
4421 character that is not the first one in the visual order.
4422 (get_visually_first_element): New function, refactored from common
4423 parts of next_element_from_buffer, next_element_from_string, and
4424 next_element_from_c_string.
4425 (tool_bar_lines_needed, redisplay_tool_bar)
4426 (display_menu_bar): Force left-to-right direction. Add a FIXME
4427 comment for making that be controlled by a user option.
4428 (push_it, pop_it): Save and restore the state of the
4429 bidi iterator. Save and restore the bidi_p flag.
4430 (pop_it): Iterate out of display property for string iteration as
4432 (iterate_out_of_display_property): Support iteration over strings.
4433 (handle_single_display_spec): Set up it->bidi_it for iteration
4434 over a display string, and call bidi_init_it.
4435 (handle_single_display_spec, next_overlay_string)
4436 (get_overlay_strings_1, push_display_prop): Set up the bidi
4437 iterator for displaying display or overlay strings.
4438 (forward_to_next_line_start): Don't use the shortcut if
4440 (back_to_previous_visible_line_start): If handle_display_prop
4441 pushed the iterator stack, restore the internal state of the bidi
4442 iterator by calling bidi_pop_it same number of times.
4443 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4444 and we are bidi-iterating, don't decrement the iterator position;
4445 instead, set the first_elt flag in the bidi iterator, to produce
4447 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4448 (push_display_prop): xassert that we are iterating a buffer.
4449 (push_it, pop_it): Save and restore paragraph_embedding member.
4450 (handle_single_display_spec, next_overlay_string)
4451 (get_overlay_strings_1, reseat_1, reseat_to_string)
4452 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4453 correctly. Don't assume unibyte strings are not bidi-reordered.
4454 (compute_display_string_pos)
4455 (compute_display_string_end): Fix handling the case of C string.
4456 (push_it, pop_it): Save and restore from_disp_prop_p.
4457 (handle_single_display_spec, push_display_prop): Set the
4458 from_disp_prop_p flag.
4459 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4460 (pop_it): Call iterate_out_of_display_property only if we are
4461 popping after iteration over a string that came from a display
4462 property. Fix a typo in popping stretch info. Add an assertion
4463 for verifying that the iterator position is in sync with the bidi
4465 (handle_single_display_spec, get_overlay_strings_1)
4466 (push_display_prop): Fix initialization of paragraph direction for
4467 string when that of the parent object is not yet determined.
4468 (reseat_1): Call bidi_init_it to resync the bidi
4469 iterator with IT's position. (Bug#7616)
4470 (find_row_edges): If ROW->start.pos gives position
4471 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4472 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4473 Reset the from_disp_prop_p flag.
4474 (SAVE_IT, RESTORE_IT): New macros.
4475 (pos_visible_p, face_before_or_after_it_pos)
4476 (back_to_previous_visible_line_start)
4477 (move_it_in_display_line_to, move_it_in_display_line)
4478 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4479 (try_scrolling, redisplay_window, display_line): Use them when
4480 saving a temporary copy of the iterator and restoring it back.
4481 (back_to_previous_visible_line_start, reseat_1)
4482 (init_iterator): Empty the bidi cache "stack".
4483 (move_it_in_display_line_to): If iterator ended up at
4484 EOL, but we never saw any buffer positions smaller than
4485 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4486 motion in bidi-reordered lines.
4487 (move_it_in_display_line_to): Record prev_method and prev_pos
4488 immediately before the call to set_iterator_to_next. Fixes cursor
4489 motion in bidi-reordered lines with stretch glyphs and strings
4490 displayed in margins. (Bug#8133) (Bug#8867)
4491 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4493 (pos_visible_p): Support positions in bidi-reordered lines.
4494 Save and restore bidi cache.
4496 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4497 (bidi_paragraph_info): Delete unused struct.
4498 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4499 (bidi_cache_start): New variable.
4500 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4502 (bidi_cache_fetch_state, bidi_cache_search)
4503 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4504 (bidi_cache_find, bidi_peek_at_next_level)
4505 (bidi_level_of_next_char, bidi_find_other_level_edge)
4506 (bidi_move_to_visually_next): Compare cache index with
4507 bidi_cache_start rather than with zero.
4508 (bidi_fetch_char): Accept new argument STRING; all callers
4509 changed. Support iteration over a string. Support strings with
4510 display properties. Support unibyte strings. Fix the type of
4511 `len' according to what STRING_CHAR_AND_LENGTH expects.
4512 (bidi_paragraph_init, bidi_resolve_explicit_1)
4513 (bidi_resolve_explicit, bidi_resolve_weak)
4514 (bidi_level_of_next_char, bidi_move_to_visually_next):
4515 Support iteration over a string.
4516 (bidi_set_sor_type, bidi_resolve_explicit_1)
4517 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4518 can now be zero (for strings); special values 0 and -1 were
4519 changed to -1 and -2, respectively.
4520 (bidi_char_at_pos): New function.
4521 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4522 Call it instead of FETCH_MULTIBYTE_CHAR.
4523 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4524 initialized to valid values.
4525 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4527 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4528 the test for valid cached positions. Fix the logic for looking up
4529 the sentinel state in the cache. GCPRO the Lisp string we are
4531 (bidi_push_it, bidi_pop_it): New functions.
4532 (bidi_initialize): Initialize the bidi cache start stack pointer.
4533 (bidi_cache_ensure_space): New function, refactored from part of
4534 bidi_cache_iterator_state. Don't assume the required size is just
4535 one BIDI_CACHE_CHUNK away.
4536 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4537 (bidi_count_bytes, bidi_char_at_pos): New functions.
4538 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4539 always valid if bidi_cache_idx is valid.
4540 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4541 is valid if it's going to be used.
4542 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4543 (bidi_cache_fetch_state, bidi_cache_search)
4544 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4545 (bidi_cache_iterator_state, bidi_cache_find)
4546 (bidi_find_other_level_edge, bidi_cache_start_stack):
4547 All variables related to cache indices are now EMACS_INT.
4549 * dispextern.h (struct bidi_string_data): New structure.
4550 (struct bidi_it): New member `string'. Make flag members be 1-bit
4551 fields, and put them last in the struct.
4552 (compute_display_string_pos, compute_display_string_end):
4554 (bidi_push_it, bidi_pop_it): Add prototypes.
4555 (struct iterator_stack_entry): New members bidi_p,
4556 paragraph_embedding, and from_disp_prop_p.
4557 (struct it): Member bidi_p is now a bit field 1 bit wide.
4558 (bidi_shelve_cache, bidi_unshelve_cache):
4561 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4562 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4563 and vector-like objects.
4565 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4566 cache around display iteration.
4568 * window.c (Fwindow_end, window_scroll_pixel_based)
4569 (displayed_window_lines, Frecenter): Save and restore the bidi
4570 cache around display iteration.
4572 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4574 * editfns.c (Fdelete_region): Clarify the use of the named
4575 parameters (bug#6788).
4577 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4579 * indent.c (Fvertical_motion): Set and restore w->pointm when
4580 saving and restoring the window's buffer (Bug#9006).
4582 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4584 * editfns.c (Fstring_to_char): Clarify just what is returned
4585 (bug#6576). Text by Eli Zaretskii.
4587 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4589 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4591 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4593 * buffer.c (mmap_find): Fix a typo.
4595 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4597 Fix execution of x selection hooks.
4598 * xselect.c (Qx_lost_selection_functions)
4599 (Qx_sent_selection_functions): New vars.
4600 (syms_of_xselect): DEFSYM them.
4601 (x_handle_selection_request): Pass Qx_sent_selection_functions
4602 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4603 (x_handle_selection_clear,x_clear_frame_selections):
4604 Pass Qx_lost_selection_functions rather than
4605 Vx_lost_selection_functions to Frun_hook_with_args.
4607 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4609 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4610 The old code sometimes used this field without initializing it.
4612 * alloc.c (gc_sweep): Don't read past end of array.
4613 In theory, the old code could also have corrupted Emacs internals,
4614 though it'd be very unlikely.
4616 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4618 * character.c (Fcharacterp): Don't advertise optional ignored
4619 argument. (Bug#4026)
4621 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4623 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4626 * window.c (Fset_window_start): Doc fix (bug#4199).
4627 (Fset_window_hscroll): Ditto.
4629 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4631 Fix minor new problems caught by GCC 4.6.1.
4632 * term.c (init_tty): Remove unused local.
4633 * xsettings.c (store_monospaced_changed): Define this function only
4634 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4637 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4639 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4641 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4643 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4644 are the mini-buffer and the echo area (bug#3320).
4646 * term.c (init_tty): Remove support for supdup, c10 and perq
4647 terminals, which are no longer supported (bug#1482).
4649 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4651 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4653 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4655 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4656 for non-popups (Bug#3642).
4658 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4660 * alloc.c (reset_malloc_hooks): Protoize.
4661 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4662 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4663 * cm.c (losecursor): Likewise.
4664 * data.c (fmod): Likewise.
4665 * dispnew.c (swap_glyphs_in_rows): Likewise.
4666 * emacs.c (memory_warning_signal): Likewise.
4667 * floatfns.c (float_error): Likewise.
4668 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4669 (otf_open, font_otf_capability, generate_otf_features)
4670 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4672 * image.c (pbm_read_file): Likewise.
4673 * indent.c (string_display_width): Likewise.
4674 * intervals.c (check_for_interval, search_for_interval)
4675 (inc_interval_count, count_intervals, root_interval)
4676 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4677 * lread.c (defalias): Likewise.
4678 * ralloc.c (r_alloc_check): Likewise.
4679 * regex.c (set_image_of_range_1, set_image_of_range)
4680 (regex_grow_registers): Likewise.
4681 * sysdep.c (strerror): Likewise.
4682 * termcap.c (valid_filename_p, tprint, main): Likewise.
4683 * tparam.c (main): Likewise.
4684 * unexhp9k800.c (run_time_remap, save_data_space)
4685 (update_file_ptrs, read_header, write_header, calculate_checksum)
4686 (copy_file, copy_rest, display_header): Likewise.
4687 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4689 * xdisp.c (check_it): Likewise.
4690 * xfaces.c (register_color, unregister_color, unregister_colors):
4692 * xfns.c (print_fontset_result): Likewise.
4693 * xrdb.c (member, fatal, main): Likewise.
4695 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4697 Fix minor problems found by static checking (Bug#9031).
4698 * chartab.c (char_table_set_range, map_sub_char_table):
4699 Remove unused locals.
4700 (uniprop_table): Now static.
4701 * composite.c (_work_char): Remove unused static var.
4703 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4705 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4707 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4709 * gtkutil.c (qttip_cb): Remove code without function.
4711 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4713 * w32.c (pthread_sigmask): New stub.
4715 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4717 Use pthread_sigmask, not sigprocmask (Bug#9010).
4718 sigprocmask is portable only for single-threaded applications, and
4719 Emacs can be multi-threaded when it uses GTK.
4720 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4722 * callproc.c (Fcall_process):
4723 * process.c (create_process):
4724 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4725 Use pthread_sigmask, not sigprocmask.
4727 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4729 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4730 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4733 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4735 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4736 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4737 (xg_hide_tooltip): Fix comment.
4739 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4740 in registerServicesMenuSendTypes.
4741 (validRequestorForSendType): Don't check ns_return_types.
4743 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4746 2011-07-08 Jason Rumney <jasonr@gnu.org>
4748 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4749 SH_SHOW for hidden windows (Bug#5482).
4751 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4752 frame struct members of non-existent frames (Bug#6284).
4754 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4756 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4757 variable firstTime not needed on OSX >= 10.6.
4758 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4759 >= 10.5. Use setKnobProportion, setDoubleValue.
4761 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4762 (MAC_OS_X_VERSION_10_5): Define if not defined.
4763 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4764 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4765 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4767 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4768 cString and lossyCString on OSX >= 10.4
4770 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4771 sizeToFit on OSX >= 10.2.
4773 * nsimage.m (allocInitFromFile): Don't use deprecated method
4774 bestRepresentationForDevice on OSX >= 10.6.
4776 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4779 * emacs.c: Declare unexec_init_emacs_zone.
4781 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4783 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4785 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4786 on svcsMenu (Bug#8842).
4788 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4790 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4792 * nsterm.m (QUTF8_STRING): Declare.
4793 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4794 (validRequestorForSendType): Return type is (id).
4795 Change indexOfObjectIdenticalTo to indexOfObject.
4796 Check if we have local selection before returning self (Bug#8842).
4797 (writeSelectionToPasteboard): Put local selection into paste board
4798 if we have a local selection (Bug#8842).
4799 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4801 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4802 (ns_get_local_selection): Declare.
4804 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4806 * keymap.c (describe_map_tree): Don't insert a double newline at
4807 the end of the buffer (bug#1169) and return whether we inserted
4810 * callint.c (Fcall_interactively): Change "reading args" to
4811 "providing args" to try to clarify what it does (bug#1010).
4813 2011-07-07 Kenichi Handa <handa@m17n.org>
4815 * composite.c (composition_compute_stop_pos): Ignore a static
4816 composition starting before CHARPOS (Bug#8915).
4818 * xdisp.c (handle_composition_prop): Likewise.
4820 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4822 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4825 2011-07-07 Kenichi Handa <handa@m17n.org>
4827 * character.h (unicode_category_t): New enum type.
4829 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4830 (Qchar_code_property_table): New variable.
4831 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4832 (UNIPROP_COMPRESSED_FORM_P): New macros.
4833 (char_table_ascii): Uncompress the compressed values.
4834 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4835 Uncompress the compressed values.
4836 (sub_char_table_ref_and_range): Likewise.
4837 (char_table_ref_and_range): Uncompress the compressed values.
4838 (sub_char_table_set): New arg is_uniprop. Callers changed.
4839 Uncompress the compressed values.
4840 (sub_char_table_set_range): Args changed. Callers changed.
4841 (char_table_set_range): Adjuted for the above change.
4842 (map_sub_char_table): Delete args default_val and parent. Add arg
4843 top. Give decoded values to a Lisp function.
4844 (map_char_table): Adjust for the above change. Give decoded
4845 values to a Lisp function. Gcpro more variables.
4846 (uniprop_table_uncompress)
4847 (uniprop_decode_value_run_length): New functions.
4848 (uniprop_decoder, uniprop_decoder_count): New variables.
4849 (uniprop_get_decoder, uniprop_encode_value_character)
4850 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4852 (uniprop_encoder, uniprop_encoder_count): New variables.
4853 (uniprop_get_encoder, uniprop_table)
4854 (Funicode_property_table_internal, Fget_unicode_property_internal)
4855 (Fput_unicode_property_internal): New functions.
4856 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4857 Sunicode_property_table_internal, Sget_unicode_property_internal,
4858 and Sput_unicode_property_internal. Defvar_lisp
4859 char-code-property-alist.
4861 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4862 Vunicode_category_table.
4864 * font.c (font_range): Adjust for the change of
4865 Vunicode_category_table.
4867 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4869 * m/iris4d.h: Remove file, move contents ...
4870 * s/irix6-5.h: ... here.
4872 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4874 Remove unportable assumption about struct layout (Bug#8884).
4875 * alloc.c (mark_buffer):
4876 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4877 (clone_per_buffer_values): Don't assume that
4878 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4879 This isn't true in general, and it's particularly not true
4880 if Emacs is configured with --with-wide-int.
4881 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4882 New macros, used in the buffer.c change.
4884 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4886 * xsettings.c: Use both GConf and GSettings if both are available.
4887 (store_config_changed_event): Add comment.
4888 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4889 (store_tool_bar_style_changed): New functions.
4890 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4891 (struct xsettings): Move font inside HAVE_XFT.
4892 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4893 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4894 Move inside HAVE_XFT.
4895 (something_changed_gsettingsCB): Rename from something_changedCB.
4896 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4898 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4899 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4900 (something_changed_gconfCB): Rename from something_changedCB.
4901 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4902 (parse_settings): Move check for font inside HAVE_XFT.
4903 (read_settings, apply_xft_settings): Add comment.
4904 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4905 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4906 call store_font_name_changed.
4907 (xft_settings_event): Add comment.
4908 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4909 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4910 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4911 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4912 (xsettings_initialize): Call init_gsettings last.
4913 (xsettings_get_system_font, xsettings_get_system_normal_font):
4916 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4918 Random fixes. E.g., (random) never returned negative values.
4919 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4920 subseconds part to the entropy, as that's a bit more random.
4921 Prefer signed to unsigned, since the signedness doesn't matter and
4922 in general we prefer signed. When given a limit, use a
4923 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4924 latter isn't right if USE_2_TAGS_FOR_INTS.
4925 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4926 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4928 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4930 * textprop.c (text_property_stickiness):
4931 Obey Vtext_property_default_nonsticky.
4932 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4933 * w32fns.c (syms_of_w32fns):
4934 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4936 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4938 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4939 This is more efficient than Ffile_directory_p and avoids a minor race.
4941 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4943 * buffer.c (Foverlay_put): Say what the return value is
4946 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4947 is a directory before asking whether to use the file name
4949 (barf_or_query_if_file_exists): Make the "File is a directory"
4950 error be more correct.
4952 * fns.c (Frequire): Remove the mention of the .gz files, since
4953 that's installation-specific, but keep the mention of
4954 `get-load-suffixes'.
4956 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4958 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4959 Report string overflow if the output is too long.
4961 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4963 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4964 (syms_of_gnutls): Remove duplicate DEFSYM for
4965 Qgnutls_bootprop_verify_hostname_error, an error for
4966 Qgnutls_bootprop_verify_error (which is no longer used).
4968 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4969 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4970 Also (re)move comments that are misplaced or no longer relevant.
4972 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4974 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4976 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4978 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4979 and background color parameters if they have been changed.
4981 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4983 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4985 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4987 * xsettings.c (SYSTEM_FONT): Define only when used.
4988 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4990 * keymap.c (access_keymap_1): Now static.
4992 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4994 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4995 leave any prefix arg for the up event (Bug#1586).
4997 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4999 * lread.c (syms_of_lread): Mention single symbols defined by
5000 `defvar' or `defconst' (bug#7154).
5002 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5003 (Frequire): Mention get-load-suffixes.
5005 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5007 * window.h (window): Remove clone_number slot.
5008 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5010 (make_parent_window, make_window, saved_window)
5011 (Fset_window_configuration, save_window_save): Don't deal with
5013 * buffer.c (Qclone_number): Remove declaration.
5014 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5016 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5018 Add multiple inheritance to keymaps.
5019 * keymap.c (Fmake_composed_keymap): New function.
5020 (Fset_keymap_parent): Simplify.
5021 (fix_submap_inheritance): Remove.
5022 (access_keymap_1): New function extracted from access_keymap to handle
5023 embedded parents and handle lists of maps.
5024 (access_keymap): Use it.
5025 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5026 (Fcopy_keymap): Handle embedded parents.
5027 (Fcommand_remapping, define_as_prefix): Simplify.
5028 (Fkey_binding): Simplify.
5029 (syms_of_keymap): Move minibuffer-local-completion-map,
5030 minibuffer-local-filename-completion-map,
5031 minibuffer-local-must-match-map, and
5032 minibuffer-local-filename-must-match-map to Elisp.
5033 (syms_of_keymap): Defsubr make-composed-keymap.
5034 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5035 (parse_menu_item): Trivial simplification.
5037 2011-07-01 Glenn Morris <rgm@gnu.org>
5039 * Makefile.in (SETTINGS_LIBS): Fix typo.
5041 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5043 * coding.c (Fencode_coding_string): Record the last coding system
5044 used, as the function doc string says (bug#8738).
5046 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5048 * xsettings.c (store_monospaced_changed): Take new font as arg and
5049 check for change against current_mono_font.
5050 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5051 (emacs_settings_constructor, emacs_settings_get_property)
5052 (emacs_settings_set_property, emacs_settings_class_init)
5053 (emacs_settings_init, gsettings_obj): Remove.
5054 (something_changedCB): New function for HAVE_GSETTINGS.
5055 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5056 with value as argument.
5057 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5058 g_settings_new (Bug#8967). Do not create gsettings_obj.
5059 Remove calls to g_settings_bind. Connect something_changedCB to
5062 * xgselect.c: Add defined (HAVE_GSETTINGS).
5063 (xgselect_initialize): Ditto.
5065 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5066 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5069 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5071 * eval.c (struct backtrace): Simplify and port the data structure.
5072 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5073 signed bit field, as this assumption is not portable and it makes
5074 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5075 "char debug_on_exit : 1" as this is not portable either; instead,
5076 use the portable "unsigned int debug_on_exit : 1". Remove unused
5077 member evalargs. Remove obsolete comments about cc bombing out.
5079 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5081 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5082 Let HAVE_GSETTINGS override HAVE_GCONF.
5083 (store_monospaced_changed): New function.
5084 (EMACS_SETTINGS): A new type derived from GObject to handle
5085 GSettings notifications.
5086 (emacs_settings_constructor, emacs_settings_get_property)
5087 (emacs_settings_set_property, emacs_settings_class_init):
5089 (gsettings_client, gsettings_obj): New variables.
5090 (GSETTINGS_SCHEMA): New define.
5091 (something_changedCB): Call store_monospaced_changed.
5092 (init_gsettings): New function.
5093 (xsettings_initialize): Call init_gsettings.
5094 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5097 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5100 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5102 * window.c (resize_root_window, grow_mini_window)
5103 (shrink_mini_window): Rename Qresize_root_window to
5104 Qwindow_resize_root_window and Qresize_root_window_vertically to
5105 Qwindow_resize_root_window_vertically.
5107 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5109 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5111 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5113 * makefile.w32-in: Redesign dependencies so they reflect more
5114 clearly which files are directly included by each source file,
5115 and not through other includes.
5117 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5119 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5120 (sort_overlays, overlay_strings): When an overlay's clone number
5121 matches the window's clone number process the overlay even if
5122 the overlay's window property doesn't match the current window.
5124 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5125 (Fwindow_hchild): Rename to Fwindow_left_child.
5126 (Fwindow_next): Rename to Fwindow_next_sibling.
5127 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5128 (resize_window_check): Rename to window_resize_check.
5129 (resize_window_apply): Rename to window_resize_apply.
5130 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5131 (Fdelete_other_windows_internal, resize_frame_windows)
5132 (Fsplit_window_internal, Fdelete_window_internal)
5133 (grow_mini_window, shrink_mini_window)
5134 (Fresize_mini_window_internal): Fix callers accordingly.
5136 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5138 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5139 (emacs_fixed_set_min_size): Remove.
5140 (emacs_fixed_new): Take frame as argument.
5142 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5143 (_EmacsFixedPrivate): Remove minwidth/height.
5144 Add struct frame *f.
5145 (emacs_fixed_init): Initialize priv->f.
5146 (get_parent_class, emacs_fixed_set_min_size): Remove.
5147 (emacs_fixed_new): Set priv->f to argument.
5148 (emacs_fixed_get_preferred_width)
5149 (emacs_fixed_get_preferred_height): Use min_width/height from
5150 frames size_hint to set minimum and natural (Bug#8919).
5151 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5152 and use min_width/height from frames size_hint to set
5153 min_width/height (Bug#8919).
5155 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5156 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5159 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5161 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5162 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5165 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5167 * process.c (wait_reading_process_output): Bypass select if
5168 waiting for a cell while ignoring keyboard input, and input is
5169 pending. Suggested by Jan Djärv (Bug#8869).
5171 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5173 Use gnulib's dup2 module instead of rolling our own.
5174 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5176 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5178 * dispnew.c (scrolling_window): Before scrolling, turn off a
5179 mouse-highlight in the window being scrolled.
5181 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5183 Move DEFSYM to lisp.h and use everywhere.
5185 * character.h (DEFSYM): Move declaration...
5186 * lisp.h (DEFSYM): ...here.
5192 * w32select.c: Don't include character.h.
5194 * alloc.c (syms_of_alloc):
5195 * buffer.c (syms_of_buffer):
5196 * bytecode.c (syms_of_bytecode):
5197 * callint.c (syms_of_callint):
5198 * casefiddle.c (syms_of_casefiddle):
5199 * casetab.c (init_casetab_once):
5200 * category.c (init_category_once, syms_of_category):
5201 * ccl.c (syms_of_ccl):
5202 * cmds.c (syms_of_cmds):
5203 * composite.c (syms_of_composite):
5204 * dbusbind.c (syms_of_dbusbind):
5205 * dired.c (syms_of_dired):
5206 * dispnew.c (syms_of_display):
5207 * doc.c (syms_of_doc):
5208 * editfns.c (syms_of_editfns):
5209 * emacs.c (syms_of_emacs):
5210 * eval.c (syms_of_eval):
5211 * fileio.c (syms_of_fileio):
5212 * fns.c (syms_of_fns):
5213 * frame.c (syms_of_frame):
5214 * fringe.c (syms_of_fringe):
5215 * insdel.c (syms_of_insdel):
5216 * keymap.c (syms_of_keymap):
5217 * lread.c (init_obarray, syms_of_lread):
5218 * macros.c (syms_of_macros):
5219 * msdos.c (syms_of_msdos):
5220 * print.c (syms_of_print):
5221 * process.c (syms_of_process):
5222 * search.c (syms_of_search):
5223 * sound.c (syms_of_sound):
5224 * syntax.c (init_syntax_once, syms_of_syntax):
5225 * terminal.c (syms_of_terminal):
5226 * textprop.c (syms_of_textprop):
5227 * undo.c (syms_of_undo):
5228 * w32.c (globals_of_w32):
5229 * window.c (syms_of_window):
5230 * xdisp.c (syms_of_xdisp):
5231 * xfaces.c (syms_of_xfaces):
5232 * xfns.c (syms_of_xfns):
5233 * xmenu.c (syms_of_xmenu):
5234 * xsettings.c (syms_of_xsettings):
5235 * xterm.c (syms_of_xterm): Use DEFSYM.
5237 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5239 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5241 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5243 Integer and buffer overflow fixes (Bug#8873).
5245 * print.c (printchar, strout): Check for string overflow.
5246 (PRINTPREPARE, printchar, strout):
5247 Don't set size unless allocation succeeds.
5249 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5250 for sizes. Check for string overflow more accurately.
5251 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5253 * macros.c: Integer and buffer overflow fixes.
5254 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5255 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5256 Use ptrdiff_t, not int, for sizes.
5257 Don't increment bufsize until after realloc succeeds.
5258 Check for size-calculation overflow.
5259 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5261 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5263 * lread.c: Integer overflow fixes.
5264 (read_integer): Radix is now EMACS_INT, not int,
5265 to improve quality of diagnostics for out-of-range radices.
5266 Calculate buffer size correctly for out-of-range radices.
5267 (read1): Check for integer overflow in radices, and in
5268 read-circle numbers.
5269 (read_escape): Avoid int overflow.
5270 (Fload, openp, read_buffer_size, read1)
5271 (substitute_object_recurse, read_vector, read_list, map_obarray):
5272 Use ptrdiff_t, not int, for sizes.
5273 (read1): Use EMACS_INT, not int, for sizes.
5274 Check for size overflow.
5276 * image.c (cache_image): Check for size arithmetic overflow.
5278 * lread.c: Integer overflow issues.
5279 (saved_doc_string_size, saved_doc_string_length)
5280 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5281 Now ptrdiff_t, not int.
5282 (read1): Don't assume doc string length fits in int. Check for
5283 out-of-range doc string lengths.
5284 (read_list): Don't assume file position fits in int.
5285 (read_escape): Check for hex character overflow.
5287 2011-06-22 Leo Liu <sdl.web@gmail.com>
5289 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5290 Move to minibuffer.el.
5292 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5294 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5295 The following patches are for when GLYPH_DEBUG && !XASSERT.
5296 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5297 * dispnew.c (flush_stdout):
5298 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5299 Mark as externally visible.
5300 * dispnew.c (check_window_matrix_pointers): Now static.
5301 * dispnew.c (window_to_frame_vpos):
5302 * xfns.c (unwind_create_frame):
5303 * xterm.c (x_check_font): Remove unused local.
5304 * scroll.c (CHECK_BOUNDS):
5305 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5306 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5307 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5308 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5309 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5311 (debug_method_add): Use va_list and vsprintf rather than relying
5312 on undefined behavior with wrong number of arguments.
5313 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5314 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5315 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5316 since we're not interested in debugging glyphs with old libraries.
5317 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5318 GCC 4.6.0's static checking.
5320 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5322 Integer overflow and signedness fixes (Bug#8873).
5323 A few related buffer overrun fixes, too.
5325 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5327 * dispextern.h (struct face.stipple):
5328 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5329 (x_bitmap_mask, x_allocate_bitmap_record)
5330 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5331 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5332 (x_create_bitmap_from_xpm_data):
5333 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5334 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5336 * xfaces.c (load_pixmap):
5337 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5338 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5339 (.bitmaps_last, struct x_output.icon_bitmap):
5340 Use ptrdiff_t, not int, for bitmap indexes.
5341 (x_allocate_bitmap_record): Check for size overflow.
5342 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5344 Use ptrdiff_t, not int, for overlay counts.
5345 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5346 * editfns.c (overlays_around, get_pos_property):
5347 * textprop.c (get_char_property_and_overlay):
5348 * xdisp.c (next_overlay_change, note_mouse_highlight):
5349 * xfaces.c (face_at_buffer_position):
5350 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5351 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5352 (Fnext_overlay_change, Fprevious_overlay_change)
5353 (mouse_face_overlay_overlaps, Foverlays_in):
5354 Use ptrdiff_t, not int, for sizes.
5355 (overlays_at, overlays_in): Check for size-calculation overflow.
5357 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5359 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5360 (x_session_initialize): Do not assume string length fits in int.
5362 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5363 This is unlikely, but can occur if DPI is outlandish.
5365 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5366 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5368 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5369 * xrdb.c (magic_file_p, search_magic_path):
5370 Omit last arg SUFFIX; it was always 0. All callers changed.
5371 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5373 * xfont.c (xfont_match): Avoid need for strlen.
5375 * xfns.c: Don't assume strlen fits in int.
5376 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5378 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5379 not unsigned long, as we prefer signed integers. All callers changed.
5380 Detect integer overflow in repeat count.
5381 (message_dolog): Don't assume print length fits in 39 bytes.
5382 (display_mode_element): Don't assume strlen fits in int.
5384 * termcap.c: Don't assume sizes fit in int and never overflow.
5385 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5386 (gobble_line): Check for size-calculation overflow.
5388 * minibuf.c (Fread_buffer):
5389 * lread.c (intern, intern_c_string):
5390 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5391 Don't assume string length fits in int.
5393 * keyboard.c (parse_tool_bar_item):
5394 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5396 * font.c: Don't assume string length fits in int.
5397 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5398 Use ptrdiff_t, not int.
5399 (font_intern_prop): Don't assume string length fits in int.
5400 Don't assume integer property fits in fixnum.
5401 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5403 * filelock.c: Fix some buffer overrun and integer overflow issues.
5404 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5405 Reformulate so as not to need the command string.
5406 Invoke gzip -cd rather than gunzip, as it's more portable.
5407 (lock_info_type, lock_file_1, lock_file):
5408 Don't assume pid_t and time_t fit in unsigned long.
5409 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5410 (current_lock_owner): Prefer signed type for sizes.
5411 Use memcpy, not strncpy, where memcpy is what is really wanted.
5412 Don't assume (via atoi) that time_t and pid_t fit in int.
5413 Check for time_t and/or pid_t out of range, e.g., via a network share.
5414 Don't alloca where an auto var works fine.
5416 * fileio.c: Fix some integer overflow issues.
5417 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5418 Don't assume string length fits in int.
5419 (directory_file_name): Don't assume string length fits in long.
5420 (make_temp_name): Don't assume pid fits in int, or that its print
5421 length is less than 20.
5423 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5425 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5427 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5429 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5430 We prefer signed integers, even for size calculations.
5432 * emacs.c: Don't assume string length fits in 'int'.
5433 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5434 (main): Don't invoke strlen when not needed.
5436 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5437 (XD_DEBUG_MESSAGE): Don't waste a byte.
5439 * callproc.c (getenv_internal_1, getenv_internal)
5441 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5443 * lread.c (invalid_syntax): Omit length argument.
5444 All uses changed. This doesn't fix a bug, but it simplifies the
5445 code away from its former Hollerith-constant appearance, and it's
5446 one less 'int' to worry about when looking at integer-overflow issues.
5447 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5449 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5450 This didn't break anything, but it didn't help either.
5451 It's confusing to put a bogus integer in a place where the actual
5452 value does not matter.
5453 (LIST_END_P): Remove unused macro and its bogus comment.
5454 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5456 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5457 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5459 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5460 We prefer signed types, and the value cannot exceed the EMACS_INT
5461 range anyway (because otherwise the length would not be representable).
5462 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5463 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5464 This avoids a GCC warning when WIDE_EMACS_INT.
5466 * indent.c (sane_tab_width): New function.
5467 (current_column, scan_for_column, Findent_to, position_indentation)
5468 (compute_motion): Use it. This is just for clarity.
5469 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5471 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5473 * lisp.h (lint_assume): New macro.
5474 * composite.c (composition_gstring_put_cache):
5475 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5477 * editfns.c, insdel.c:
5478 Omit unnecessary forward decls, to simplify future changes.
5480 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5482 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5484 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5485 Use much-faster test for byte-length change.
5486 Don't assume string byte-length fits in 'int'.
5487 Check that character arg fits in 'int'.
5488 (mapcar1): Declare byte as byte, for clarity.
5490 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5492 * fns.c (concat): Catch string overflow earlier.
5493 Do not rely on integer wraparound.
5495 * dispextern.h (struct it.overlay_strings_charpos)
5496 (struct it.selective): Now EMACS_INT, not int.
5497 * xdisp.c (forward_to_next_line_start)
5498 (back_to_previous_visible_line_start)
5499 (reseat_at_next_visible_line_start, next_element_from_buffer):
5500 Don't arbitrarily truncate the value of 'selective' to int.
5502 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5504 * composite.c: Don't truncate sizes to 'int'.
5505 (composition_gstring_p, composition_reseat_it)
5506 (composition_adjust_point): Use EMACS_INT, not int.
5507 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5508 not EMACS_UINT, for indexes.
5510 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5512 * buffer.c: Include <verify.h>.
5513 (struct sortvec.priority, struct sortstr.priority):
5514 Now EMACS_INT, not int.
5515 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5516 (struct sortstr.size, record_overlay_string)
5517 (struct sortstrlist.size, struct sortlist.used):
5518 Don't truncate size to int.
5519 (record_overlay_string): Check for size-calculation overflow.
5520 (init_buffer_once): Check at compile-time, not run-time.
5522 2011-06-22 Jim Meyering <meyering@redhat.com>
5524 Don't leak an XBM-image-sized buffer
5525 * image.c (xbm_load): Free the image buffer after using it.
5527 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5530 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5531 that Sun C diagnosed.
5532 * fns.c (secure_hash): Fix pointer signedness issue.
5533 * intervals.c (static_offset_intervals): New function.
5534 (offset_intervals): Use it.
5536 2011-06-21 Leo Liu <sdl.web@gmail.com>
5539 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5542 * fns.c (secure_hash): Rename from crypto_hash_function and change
5543 the first arg to accept symbols.
5544 (Fsecure_hash): New primitive.
5545 (syms_of_fns): New symbols.
5547 2011-06-20 Deniz Dogan <deniz@dogan.se>
5549 * process.c (Fset_process_buffer): Clarify return value in
5552 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5554 * dispnew.c (add_window_display_history): Use BVAR.
5556 * xdisp.c (debug_method_add): Use BVAR.
5557 (check_window_end, dump_glyph_matrix, dump_glyph)
5558 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5560 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5563 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5564 check till after the cache is created in init_frame_faces.
5566 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5568 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5570 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5572 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5573 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5574 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5576 Improve buffer-overflow checking (Bug#8873).
5577 * fileio.c (Finsert_file_contents):
5578 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5579 Remove the old (too-loose) buffer overflow checks.
5580 They weren't needed, since make_gap checks for buffer overflow.
5581 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5582 The old code merely checked for Emacs fixnum overflow, and relied
5583 on undefined (wraparound) behavior. The new code avoids undefined
5584 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5586 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5587 Tune. Don't use wider integers than needed. Don't use alloca.
5588 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5590 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5592 * insdel.c, lisp.h (buffer_overflow): New function.
5593 (insert_from_buffer_1, replace_range, replace_range_2):
5594 * insdel.c (make_gap_larger):
5595 * editfns.c (Finsert_char):
5596 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5598 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5600 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5602 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5604 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5605 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5607 * fileio.c: Don't assume EMACS_INT fits in off_t.
5608 (emacs_lseek): New static function.
5609 (Finsert_file_contents, Fwrite_region): Use it.
5610 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5612 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5614 * fns.c: Don't overflow int when computing a list length.
5615 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5616 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5617 truncation on 64-bit hosts. Check for QUIT every
5618 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5619 faster and is responsive enough.
5620 (Flength): Report an error instead of overflowing an integer.
5621 (Fsafe_length): Return a float if the value is not representable
5622 as a fixnum. This shouldn't happen except in contrived situations.
5623 (Fnthcdr, Fsort): Don't assume list length fits in int.
5624 (Fcopy_sequence): Don't assume vector length fits in int.
5626 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5627 (header_size, word_size): New constants.
5628 (allocate_vectorlike): Don't check size overflow here.
5629 (allocate_vector): Check it here instead, since this is the only
5630 caller of allocate_vectorlike that could cause overflow.
5631 Check that the new vector's length is representable as a fixnum.
5633 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5634 The previous code was bogus. For example, next_almost_prime (32)
5635 returned 39, which is undesirable as it is a multiple of 3; and
5636 next_almost_prime (24) returned 25, which is a multiple of 5 so
5637 why was the code bothering to check for multiples of 7?
5639 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5641 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5643 Variadic C functions now count arguments with ptrdiff_t.
5644 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5645 Back then I didn't know that the Emacs coding style prefers signed int.
5646 Also, in the meantime I found a few more instances where arguments
5647 were being counted with int, which may truncate counts on 64-bit
5648 machines, or EMACS_INT, which may be unnecessarily wide.
5649 * lisp.h (struct Lisp_Subr.function.aMANY)
5650 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5651 Arg counts are now ptrdiff_t, not size_t.
5652 All variadic functions and their callers changed accordingly.
5653 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5654 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5655 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5656 * callint.c (Fcall_interactively): Check arg count for overflow,
5657 to avoid potential buffer overrun. Use signed char, not 'int',
5658 for 'varies' array, so that we needn't bother to check its size
5659 calculation for overflow.
5660 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5661 * eval.c (apply_lambda):
5662 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5663 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5664 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5666 * callint.c (Fcall_interactively): Don't use index var as event count.
5668 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5669 * mem-limits.h (SIZE): Remove; no longer used.
5671 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5673 Remove unnecessary casts.
5674 * xterm.c (x_term_init):
5675 * xfns.c (x_set_border_pixel):
5676 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5677 These aren't needed now that we assume ANSI C.
5679 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5680 It's more likely to cause problems (due to unsigned overflow)
5683 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5685 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5687 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5689 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5691 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5693 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5695 GLYPH_CODE_FACE returns EMACS_INT, not int.
5696 * dispextern.h (merge_faces):
5697 * xfaces.c (merge_faces):
5698 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5699 Don't assume EMACS_INT fits in int.
5701 * character.h (CHAR_VALID_P): Remove unused parameter.
5702 * fontset.c, lisp.h, xdisp.c: All uses changed.
5704 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5706 * fns.c (concat): Minor tuning based on overflow analysis.
5707 This doesn't fix any bugs. Use int to hold character, instead
5708 of constantly refetching from Emacs object. Use XFASTINT, not
5709 XINT, for value known to be a character. Don't bother comparing
5710 a single byte to 0400, as it's always less.
5712 * floatfns.c (Fexpt):
5713 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5715 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5718 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5720 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5721 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5722 incorrectly succeed when S was a string, because 4294967386 was
5723 truncated before it was used.
5725 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5726 Otherwise, an out-of-range integer could cause undefined behavior
5729 * composite.c: Use int, not EMACS_INT, for characters.
5730 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5731 EMACS_INT, for values that are known to be in character range.
5732 This doesn't fix any bugs but is the usual style inside Emacs and
5733 may generate better code on 32-bit machines.
5735 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5736 This is for reasons similar to the recent CHAR_STRING fix.
5737 * charset.c (Fencode_char): Check that character arg is actually
5738 a character. Pass an int to ENCODE_CHAR.
5739 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5740 wider than 'int', as a compile-time check to prevent future regressions
5743 * character.c (char_string): Remove unnecessary casts.
5745 Make sure a 64-bit char is never passed to CHAR_STRING.
5746 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5747 by silently ignoring the top 32 bits, allowing some values
5748 that were far too large to be valid characters.
5749 * character.h: Include <verify.h>.
5750 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5751 arguments are no wider than unsigned, as a compile-time check
5752 to prevent future regressions in this area.
5754 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5755 (Fsubst_char_in_region):
5757 * xdisp.c (decode_mode_spec_coding):
5758 Adjust to CHAR_STRING's new requirement.
5759 * editfns.c (Finsert_char, Fsubst_char_in_region):
5760 * fns.c (concat): Check that character args are actually
5761 characters. Without this test, these functions did the wrong
5762 thing with wildly out-of-range values on 64-bit hosts.
5764 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5765 These casts should not be needed on 32-bit hosts, either.
5766 * keyboard.c (read_char):
5767 * lread.c (Fload): Remove casts to unsigned.
5769 * lisp.h (UNSIGNED_CMP): New macro.
5770 This fixes comparison bugs on 64-bit hosts.
5771 (ASCII_CHAR_P): Use it.
5772 * casefiddle.c (casify_object):
5773 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5774 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5775 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5776 * dispextern.h (FACE_FROM_ID):
5777 * keyboard.c (read_char): Use UNSIGNED_CMP.
5779 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5780 not to EMACS_INT, to avoid GCC warning.
5782 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5784 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5785 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5786 isn't needed on 32-bit machines.
5788 * buffer.c (Fgenerate_new_buffer_name):
5789 Use EMACS_INT for count, not int.
5790 (advance_to_char_boundary): Return EMACS_INT, not int.
5792 * data.c (Qcompiled_function): Now static.
5794 * window.c (window_body_lines): Now static.
5796 * image.c (gif_load): Rename local to avoid shadowing.
5798 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5799 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5800 * alloc.c (make_save_value): Integer argument is now of type
5802 (mark_object): Use ptrdiff_t, not int.
5803 * lisp.h (pD): New macro.
5804 * print.c (print_object): Use it.
5806 * alloc.c: Use EMACS_INT, not int, to count objects.
5807 (total_conses, total_markers, total_symbols, total_vector_size)
5808 (total_free_conses, total_free_markers, total_free_symbols)
5809 (total_free_floats, total_floats, total_free_intervals)
5810 (total_intervals, total_strings, total_free_strings):
5811 Now EMACS_INT, not int. All uses changed.
5812 (Fgarbage_collect): Compute overall total using a double, so that
5813 integer overflow is less likely to be a problem. Check for overflow
5814 when converting back to an integer.
5815 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5816 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5817 These were 'int' variables that could overflow on 64-bit hosts;
5818 they were never used, so remove them instead of repairing them.
5819 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5820 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5821 Previously, this ceilinged at INT_MAX, but that doesn't work on
5823 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5825 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5826 (allocate_vectorlike): Check for ptrdiff_t overflow.
5827 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5828 when a (possibly-narrower) signed value would do just as well.
5829 We prefer using signed arithmetic, to avoid comparison confusion.
5831 * alloc.c: Catch some string size overflows that we were missing.
5832 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5833 for convenience in STRING_BYTES_MAX.
5834 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5835 The definition here is exact; the one in lisp.h was approximate.
5836 (allocate_string_data): Check for string overflow. This catches
5837 some instances we weren't catching before. Also, it catches
5838 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5839 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5840 and ptrdiff_t and EMACS_INT are both 64 bits.
5842 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5843 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5844 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5846 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5848 * alloc.c (Fmake_string): Check for out-of-range init.
5850 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5852 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5854 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5856 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5857 xg_get_default_scrollbar_width.
5859 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5860 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5861 (style_changed_cb): Call update_theme_scrollbar_width and call
5862 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5863 all frames (Bug#8505).
5864 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5865 Call gtk_window_set_resizable if HAVE_GTK3.
5866 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5867 and height if HAVE_GTK3 (Bug#8505).
5868 (scroll_bar_width_for_theme): New variable.
5869 (update_theme_scrollbar_width): New function.
5870 (xg_get_default_scrollbar_width): Move code to
5871 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5872 (xg_initialize): Call update_theme_scrollbar_width.
5874 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5876 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5878 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5880 * frame.c (make_frame): Call other_buffer_safely instead of
5883 * window.c (temp_output_buffer_show): Call display_buffer with
5884 second argument Vtemp_buffer_show_specifiers and reset latter
5885 immediately after the call.
5886 (Vtemp_buffer_show_specifiers): New variable.
5887 (auto_window_vscroll_p, next_screen_context_lines)
5888 (Vscroll_preserve_screen_position): Remove leading asterisks from
5891 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5893 Fix minor problems found by GCC 4.6.0 static checking.
5894 * buffer.c (Qclone_number): Remove for now, as it's unused.
5895 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5896 (record_buffer): Remove unused local.
5897 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5898 (set_frame_buffer_list): Remove; unused.
5899 * frame.h (other_visible_frames): Remove decl.
5900 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5901 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5902 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5904 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5905 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5906 Define only if HAVE_GPM.
5907 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5908 (update_hints_inhibit): Remove; never set. All uses removed.
5909 * widgetprv.h (emacsFrameClassRec): Remove decl.
5910 * window.c (delete_deletable_window): Now returns void, since it
5911 wasn't returning anything.
5912 (compare_window_configurations): Remove unused locals.
5913 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5914 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5915 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5916 the same widths as pointers. This follows up on the 2011-05-06 patch.
5917 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5918 * xterm.h: Likewise.
5919 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5921 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5923 * makefile.w32-in: Update dependencies.
5924 (LISP_H): Add lib/intprops.h.
5926 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5928 * image.c (gif_load): Add animation frame delay to the metadata.
5929 (syms_of_image): Use DEFSYM. New symbol `delay'.
5931 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5933 * window.c (delete_deletable_window): Re-add.
5934 (Fset_window_configuration): Rewrite to handle dead buffers and
5935 consequently deletable windows.
5936 (window_tree, Fwindow_tree): Remove. Supply functionality in
5938 (compare_window_configurations): Simplify code.
5940 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5942 * image.c (imagemagick_load_image): Fix type mismatch.
5943 (Fimagemagick_types): Likewise.
5945 * window.h (replace_buffer_in_windows): Declare.
5947 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5949 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5950 Qclone_number. Remove external declaration of Qdelete_window.
5951 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5953 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5954 Run Qbuffer_list_update_hook if allowed.
5955 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5956 buffer list implementation.
5957 (other_buffer_safely): New function.
5958 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5959 calls to replace_buffer_in_windows and
5960 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5962 (record_buffer): Inhibit quitting and rewrite using quittable
5963 functions. Run Qbuffer_list_update_hook if allowed.
5964 (Frecord_buffer, Funrecord_buffer): New functions.
5965 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5966 Move switch-to-buffer to window.el.
5967 (bury-buffer): Move to window.el.
5968 (Vbuffer_list_update_hook): New variable.
5970 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5973 * window.h (resize_frame_windows): Move up in code.
5974 (Fwindow_frame): Remove EXFUN.
5975 (replace_buffer_in_all_windows): Remove prototype.
5976 (replace_buffer_in_windows_safely): Add prototype.
5978 * window.c: Declare Qdelete_window static again. Move down
5979 declaration of select_count.
5980 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5981 (Fother_window): Move to window.el.
5982 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5983 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5984 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5986 (replace_buffer_in_windows): Implement by calling
5987 Qreplace_buffer_in_windows.
5988 (replace_buffer_in_all_windows): Remove with some functionality
5989 moved into replace_buffer_in_windows_safely.
5990 (replace_buffer_in_windows_safely): New function.
5991 (select_window_norecord, select_frame_norecord): Move in front
5992 of run_window_configuration_change_hook. Remove now obsolete
5994 (Fset_window_buffer): Rewrite doc-string.
5995 Call Qrecord_window_buffer.
5996 (keys_of_window): Move binding for other-window to window.el.
5998 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6000 * dispextern.h (struct image): Replace data member, whose int_val
6001 and ptr_val fields were not used by anything, with a single
6004 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6005 (gif_clear_image, gif_load, imagemagick_load_image)
6006 (gs_clear_image, gs_load): Callers changed.
6008 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6010 * buffer.h: Include <time.h>, for time_t.
6011 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6013 Fix minor problems found by static checking.
6015 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6017 Make identifiers static if they are not used in other modules.
6018 * data.c (Qcompiled_function, Qframe, Qvector):
6019 * image.c (QimageMagick, Qsvg):
6020 * minibuf.c (Qmetadata):
6021 * window.c (resize_window_check, resize_root_window): Now static.
6022 * window.h (resize_window_check, resize_root_window): Remove decls.
6024 * window.c (window_deletion_count, delete_deletable_window):
6026 (window_body_lines): Now static.
6027 (Fdelete_other_windows_internal): Mark vars as initialized.
6028 Make sure 'resize_failed' is initialized.
6029 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6030 (resize_window_apply): Remove unused local.
6031 * window.h (delete_deletable_window): Remove decl.
6033 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6034 (imagemagick_load_image): Fix pointer signedness problem by changing
6035 last arg from unsigned char * to char *. All uses changed.
6036 Also, fix a local for similar reasons.
6037 Remove unused locals. Remove locals to avoid shadowing.
6038 (fn_rsvg_handle_free): Remove; unused.
6039 (svg_load, svg_load_image): Fix pointer signedness problem.
6040 (imagemagick_load_image): Don't use garbage pointer image_wand.
6042 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6044 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6046 * image.c (gif_load): Fix omitted cast error introduced by
6049 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6051 * window.h (resize_proportionally, orig_total_lines)
6052 (orig_top_line): Remove from window structure.
6053 (set_window_height, set_window_width, change_window_heights)
6054 (Fdelete_window): Remove prototypes.
6055 (resize_frame_windows): Remove duplicate declaration.
6057 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6059 * window.h (resize_frame_windows, resize_window_check)
6060 (delete_deletable_window, resize_root_window)
6061 (resize_frame_windows): Declare prototypes.
6063 * window.c (resize_window_apply): Make definition be "static" to
6064 match the prototype.
6066 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6068 * window.c: Remove declarations of Qwindow_size_fixed,
6069 window_min_size_1, window_min_size_2, window_min_size,
6070 size_window, window_fixed_size_p, enlarge_window, delete_window.
6071 Remove static from declaration of Qdelete_window, it's
6072 temporarily needed by Fbury_buffer.
6073 (replace_window): Don't assign orig_top_line and
6075 (Fdelete_window, delete_window): Remove. Window deletion is
6076 handled by window.el.
6077 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6078 Replace Fdelete_window calls with calls to Qdelete_window.
6079 (Fdelete_other_windows): Remove. Deleting other windows is
6080 handled by window.el.
6081 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6082 handled in window.el.
6083 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6084 Window minimum sizes are handled in window.el.
6085 (shrink_windows, size_window, set_window_height)
6086 (set_window_width, change_window_heights, window_height)
6087 (window_width, CURBEG, CURSIZE, enlarge_window)
6088 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6089 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6090 handled in window.el.
6091 (make_dummy_parent): Rename to make_parent_window and give it a
6092 second argument horflag.
6093 (make_window): Don't set resize_proportionally any more.
6094 (Fsplit_window): Remove. Windows are split in window.el.
6095 (save_restore_action, save_restore_orig_size)
6096 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6097 Resize mini windows in window.el.
6098 (grow_mini_window, shrink_mini_window): Implement by calling
6099 Qresize_root_window_vertically, resize_window_check and
6100 resize_window_apply.
6101 (saved_window, Fset_window_configuration, save_window_save):
6102 Do not handle orig_top_line, orig_total_lines, and
6103 resize_proportionally.
6104 (window_min_height, window_min_width): Move to window.el.
6105 (keys_of_window): Move bindings for delete-other-windows,
6106 split-window, delete-window and enlarge-window to window.el.
6108 * buffer.c: Temporarily extern Qdelete_window.
6109 (Fbury_buffer): Temporarily call Qdelete_window instead of
6110 Fdelete_window (Fbury_buffer will move to window.el soon).
6112 * frame.c (set_menu_bar_lines_1): Remove code handling
6113 orig_top_line and orig_total_lines.
6115 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6116 set_window_height but set heights directly.
6117 (change_frame_size_1): Use resize_frame_windows.
6119 * xdisp.c (init_xdisp): Don't use set_window_height but set
6122 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6123 Use resize_frame_windows instead of change_window_heights and run
6124 run_window_configuration_change_hook.
6126 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6127 instead of change_window_heights and run
6128 run_window_configuration_change_hook.
6130 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6132 * window.c (replace_window): Rename second argument REPLACEMENT to
6133 NEW. New third argument SETFLAG. Rewrite.
6134 (delete_window, make_dummy_parent): Call replace_window with
6136 (window_list_1): Move down in code.
6137 (run_window_configuration_change_hook): Move set_buffer part
6138 before select_frame_norecord part in order to unwind correctly.
6139 Rename count1 to count.
6140 (recombine_windows, delete_deletable_window, resize_root_window)
6141 (Fdelete_other_windows_internal)
6142 (Frun_window_configuration_change_hook, make_parent_window)
6143 (resize_window_check, resize_window_apply, Fresize_window_apply)
6144 (resize_frame_windows, Fsplit_window_internal)
6145 (Fdelete_window_internal, Fresize_mini_window_internal):
6147 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6149 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6151 * window.h (window): Add some new members to window structure -
6152 normal_lines, normal_cols, new_total, new_normal, clone_number,
6153 splits, nest, prev_buffers, next_buffers.
6154 (WINDOW_TOTAL_SIZE): Move here from window.c.
6155 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6157 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6159 (make_dummy_parent): Set new members of windows structure.
6160 (make_window): Move down in code. Handle new members of window
6162 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6163 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6164 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6165 (Fset_window_prev_buffers, Fwindow_next_buffers)
6166 (Fset_window_next_buffers, Fset_window_clone_number):
6168 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6169 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6171 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6172 Argument WINDOW can be now internal window too.
6173 (Fwindow_use_time): Move up in code.
6174 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6176 (Fset_window_configuration, saved_window)
6177 (Fcurrent_window_configuration, save_window_save): Handle new
6178 members of window structure.
6179 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6180 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6181 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6182 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6183 Qget_mru_window, Qresize_root_window,
6184 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6185 Qauto_buffer_name; staticpro them.
6187 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6189 * window.c (Fwindow_total_size, Fwindow_left_column)
6190 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6191 (Fwindow_list_1): New functions.
6192 (window_box_text_cols): Replace with window_body_cols.
6193 (Fwindow_width, Fscroll_left, Fscroll_right):
6194 Use window_body_cols instead of window_box_text_cols.
6195 (delete_window, Fset_window_configuration):
6196 Call delete_all_subwindows with window as argument.
6197 (delete_all_subwindows): Take a window as argument and not a
6199 (window_loop): Remove handling of GET_LRU_WINDOW and
6201 (Fget_lru_window, Fget_largest_window): Move to window.el.
6203 * window.h: Extern window_body_cols instead of
6204 window_box_text_cols. delete_all_subwindows now takes a
6205 Lisp_Object as argument.
6207 * indent.c (compute_motion, Fcompute_motion):
6208 Use window_body_cols instead of window_box_text_cols.
6210 * frame.c (delete_frame): Call delete_all_subwindows with root
6213 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6215 * fns.c (Fputhash): Document return value.
6217 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6219 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6221 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6223 Cons<->int and similar integer overflow fixes (Bug#8794).
6225 Check for overflow when converting integer to cons and back.
6226 * charset.c (Fdefine_charset_internal, Fdecode_char):
6227 Use cons_to_unsigned to catch overflow.
6228 (Fencode_char): Use INTEGER_TO_CONS.
6229 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6230 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6231 * data.c (long_to_cons, cons_to_long): Remove.
6232 (cons_to_unsigned, cons_to_signed): New functions.
6233 These signal an error for invalid or out-of-range values.
6234 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6235 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6236 * font.c (Ffont_variation_glyphs):
6237 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6238 * lisp.h: Include <intprops.h>.
6239 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6240 (cons_to_signed, cons_to_unsigned): New decls.
6241 (long_to_cons, cons_to_long): Remove decls.
6242 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6243 (Fprimitive_undo): Use CONS_TO_INTEGER.
6244 * xfns.c (Fx_window_property): Likewise.
6245 * xselect.c: Include <limits.h>.
6246 (x_own_selection, selection_data_to_lisp_data):
6247 Use INTEGER_TO_CONS.
6248 (x_handle_selection_request, x_handle_selection_clear)
6249 (x_get_foreign_selection, Fx_disown_selection_internal)
6250 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6251 (lisp_data_to_selection_data): Use cons_to_unsigned.
6252 (x_fill_property_data): Use cons_to_signed.
6253 Report values out of range.
6255 Check for buffer and string overflow more precisely.
6256 * buffer.h (BUF_BYTES_MAX): New macro.
6257 * lisp.h (STRING_BYTES_MAX): New macro.
6258 * alloc.c (Fmake_string):
6259 * character.c (string_escape_byte8):
6260 * coding.c (coding_alloc_by_realloc):
6261 * doprnt.c (doprnt):
6262 * editfns.c (Fformat):
6264 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6265 since they may not be the same number.
6266 * editfns.c (Finsert_char):
6267 * fileio.c (Finsert_file_contents):
6268 Likewise for BUF_BYTES_MAX.
6270 * image.c: Use ptrdiff_t, not int, for sizes.
6271 (slurp_file): Switch from int to ptrdiff_t.
6273 (slurp_file): Check that file size fits in both size_t (for
6274 malloc) and ptrdiff_t (for sanity and safety).
6276 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6277 if b->modtime has its maximal value.
6279 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6281 Don't assume time_t can fit into int.
6282 * buffer.h (struct buffer.modtime): Now time_t, not int.
6283 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6284 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6286 Minor fixes for signed vs unsigned integers.
6287 * character.h (MAYBE_UNIFY_CHAR):
6288 * charset.c (maybe_unify_char):
6289 * keyboard.c (read_char, reorder_modifiers):
6290 XINT -> XFASTINT, since the integer must be nonnegative.
6291 * ftfont.c (ftfont_spec_pattern):
6292 * keymap.c (access_keymap, silly_event_symbol_error):
6293 XUINT -> XFASTINT, since the integer must be nonnegative.
6294 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6295 since it makes no difference and we prefer signed.
6296 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6297 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6300 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6302 * window.h (Fwindow_frame): Declare.
6304 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6306 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6307 (SPARE_MEMORY): Always define.
6308 (LARGE_REQUEST): Remove.
6309 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6311 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6313 * lisp.h: Move EXFUNS for Fframe_root_window,
6314 Fframe_first_window and Fset_frame_selected_window to window.h.
6316 * window.h: Move EXFUNS for Fframe_root_window,
6317 Fframe_first_window and Fset_frame_selected_window here from
6320 * frame.c (Fwindow_frame, Fframe_first_window)
6321 (Fframe_root_window, Fframe_selected_window)
6322 (Fset_frame_selected_window): Move to window.c.
6323 (Factive_minibuffer_window): Move to minibuf.c.
6324 (Fother_visible_frames_p): New function.
6326 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6328 * window.c (decode_window, decode_any_window): Move up in code.
6329 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6330 (inhibit_frame_unsplittable): Remove unused variable.
6331 (Fwindow_buffer): Move up and rewrite doc-string.
6332 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6333 (Fwindow_prev): New functions.
6334 (Fwindow_frame): Move here from frame.c. Accept any window as
6336 (Fframe_root_window, Fframe_first_window)
6337 (Fframe_selected_window): Move here from frame.c. Accept frame
6338 or arbitrary window as argument. Update doc-strings.
6339 (Fminibuffer_window): Move up in code.
6340 (Fwindow_minibuffer_p): Move up in code and simplify.
6341 (Fset_frame_selected_window): Move here from frame.c.
6343 (Fselected_window, select_window, Fselect_window): Move up in
6344 code. Minor doc-string fixes.
6346 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6348 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6349 Do not assume that spare memory exists; that assumption is valid
6350 only if SYSTEM_MALLOC.
6351 (LARGE_REQUEST): New macro, so that the issue of large requests
6352 is separated from the issue of spare memory.
6354 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6356 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6359 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6361 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6364 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6366 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6368 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6370 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6371 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6373 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6375 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6377 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6379 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6380 (x_clipboard_manager_save): Add return value.
6381 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6383 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6384 Obey Vx_select_enable_clipboard_manager. Catch errors in
6385 x_clipboard_manager_save (Bug#8779).
6386 (Vx_select_enable_clipboard_manager): New variable.
6387 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6389 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6391 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6393 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6395 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6396 in the current matrix if keep_current_p is non-zero.
6398 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6400 * bidi.c (bidi_level_of_next_char): Fix last change.
6402 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6404 Support bidi reordering of text covered by display properties.
6406 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6407 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6408 (bidi_cache_search, bidi_cache_iterator_state)
6409 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6410 (bidi_level_of_next_char, bidi_move_to_visually_next):
6411 Support character positions inside a run of characters covered by a
6413 (bidi_paragraph_init, bidi_resolve_explicit_1)
6414 (bidi_level_of_next_char): Call bidi_fetch_char and
6415 bidi_fetch_char_advance instead of FETCH_CHAR and
6417 (bidi_init_it): Initialize new members.
6418 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6420 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6421 instead of using explicit *_CHAR codes.
6422 (bidi_resolve_explicit, bidi_resolve_weak):
6423 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6424 bidirectional text is supported only in multibyte buffers.
6425 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6426 it to initialize the frame_window_p member of struct bidi_it.
6427 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6428 (bidi_resolve_explicit, bidi_resolve_weak)
6429 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6430 bidi_it->nchars is non-positive.
6431 (bidi_level_of_next_char): Don't try to lookup the cache for the
6432 next/previous character if nothing is cached there yet, or if we
6433 were just reseat()'ed to a new position.
6435 * xdisp.c (set_cursor_from_row): Set start and stop points
6436 according to the row's direction when priming the loop that looks
6437 for the glyph on which to display cursor.
6438 (single_display_spec_intangible_p): Function deleted.
6439 (display_prop_intangible_p): Reimplement to call
6440 handle_display_spec instead of single_display_spec_intangible_p.
6441 Accept 3 additional arguments needed by handle_display_spec.
6442 This fixes incorrect cursor motion across display property with complex
6443 values: lists, `(when COND...)' forms, etc.
6444 (single_display_spec_string_p): Support property values that are
6445 lists with the argument STRING its top-level element.
6446 (display_prop_string_p): Fix the condition for processing a
6447 property that is a list to be consistent with handle_display_spec.
6448 (handle_display_spec): New function, refactored from the
6449 last portion of handle_display_prop.
6450 (compute_display_string_pos): Accept additional argument
6451 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6452 value of a `display' property is a "replacing spec".
6453 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6454 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6455 the display property, but just return a value indicating whether
6456 the display property will replace the characters it covers.
6457 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6458 frame_window_p members of struct bidi_it.
6459 (compute_display_string_pos, compute_display_string_end):
6461 (push_it): Accept second argument POSITION, where pop_it should
6462 jump to continue iteration.
6463 (reseat_1): Initialize bidi_it.disp_pos.
6465 * keyboard.c (adjust_point_for_property): Adjust the call to
6466 display_prop_intangible_p to its new signature.
6468 * dispextern.h (struct bidi_it): New member frame_window_p.
6469 (bidi_init_it): Update prototypes.
6470 (display_prop_intangible_p): Update prototype.
6471 (compute_display_string_pos, compute_display_string_end):
6473 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6476 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6478 Malloc failure behavior now depends on size of allocation.
6479 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6480 * lisp.h: Change signatures accordingly.
6481 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6482 All callers changed. (Bug#8762)
6484 * gnutls.c: Use Emacs's memory allocators.
6485 Without this change, the gnutls library would invoke malloc etc.
6486 directly, which causes problems on non-SYNC_INPUT hosts, and which
6487 runs afoul of improving memory_full behavior. (Bug#8761)
6488 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6489 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6490 xfree instead of the default malloc, realloc, free.
6491 (Fgnutls_boot): No need to check for memory allocation failure,
6492 since xmalloc does that for us.
6494 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6495 * category.c (hash_get_category_set):
6496 * ccl.c (ccl_driver):
6497 * charset.c (Fdefine_charset_internal):
6498 * charset.h (struct charset.hash_index):
6499 * composite.c (get_composition_id, gstring_lookup_cache)
6500 (composition_gstring_put_cache):
6501 * composite.h (struct composition.hash_index):
6502 * dispextern.h (struct image.hash):
6503 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6504 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6505 (hashfn_equal, hashfn_user_defined, make_hash_table)
6506 (maybe_resize_hash_table, hash_lookup, hash_put)
6507 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6508 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6509 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6510 * image.c (make_image, search_image_cache, lookup_image)
6511 (xpm_put_color_table_h):
6512 * lisp.h (struct Lisp_Hash_Table):
6513 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6514 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6515 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6516 * alloc.c (allocate_vectorlike):
6517 Check for overflow in vector size calculations.
6518 * ccl.c (ccl_driver):
6519 Check for overflow when converting EMACS_INT to int.
6520 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6521 need to be updated by these changes.
6522 * fns.c (make_hash_table, maybe_resize_hash_table):
6523 Check for integer overflow with large hash tables.
6524 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6525 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6526 (SXHASH_REDUCE): New macro.
6527 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6528 Use it instead of discarding useful hash info with large hash values.
6529 (sxhash_float): New function.
6530 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6531 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6532 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6533 Rewrite to use FIXNUM_BITS, as this simplifies things.
6534 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6535 Adjust signatures to match updated version of code.
6536 (consing_since_gc): Now EMACS_INT, since a single hash table can
6537 use more than INT_MAX bytes.
6539 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6541 Make it possible to build with GCC-4.6+ -O2 -flto.
6543 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6545 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6547 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6548 Call minibuffer-inactive-mode.
6550 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6552 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6553 Update dependencies.
6555 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6557 * data.c (init_data): Remove code for UTS, this system is not
6560 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6562 Don't force ./temacs to start in terminal mode.
6564 * frame.c (make_initial_frame): Initialize faces in all cases, not
6565 only when CANNOT_DUMP is defined.
6566 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6570 * dispnew.c (add_window_display_history): Use const for the string
6571 pointer. Remove declaration, not needed.
6573 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6575 Use 'inline', not 'INLINE'.
6576 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6577 * alloc.c, fontset.c (INLINE): Remove.
6578 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6579 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6580 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6581 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6582 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6586 Make it possible to run ./temacs.
6588 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6589 syms_of_callproc does the same thing. Remove test for
6590 "initialized", do it in the caller.
6591 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6593 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6595 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6596 (read_minibuf): Use get_minibuffer.
6597 (syms_of_minibuf): Use DEFSYM.
6598 (Qmetadata): New var.
6599 * data.c (Qbuffer): Don't make it static.
6600 (syms_of_data): Use DEFSYM.
6602 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6604 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6605 (CCL_CODE_MIN): New macro.
6607 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6609 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6611 * eval.c (Qdebug): Now static.
6612 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6613 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6614 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6616 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6618 * image.c: Various fixes to ImageMagick code comments.
6619 (Fimagemagick_types): Doc fix.
6621 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6623 Minor fixes prompted by GCC 4.6.0 warnings.
6625 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6627 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6628 (x_clipboard_manager_save_all): Move extern decl to ...
6629 * xterm.h: ... here, so that it can be checked for consistency.
6631 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6633 * xselect.c (x_clipboard_manager_save_frame)
6634 (x_clipboard_manager_save_all): New functions.
6635 (Fx_clipboard_manager_save): Lisp function deleted.
6637 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6638 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6640 * xterm.h: Update prototype.
6642 2011-05-28 William Xu <william.xwl@gmail.com>
6644 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6647 2011-05-28 Jim Meyering <meyering@redhat.com>
6649 Avoid a sign-extension bug in crypto_hash_function.
6650 * fns.c (to_uchar): Define.
6651 (crypto_hash_function): Use it to convert some newly-signed
6652 variables to unsigned, to avoid sign-extension bugs. For example,
6653 without this change, (md5 "truc") would evaluate to
6654 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6655 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6656 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6658 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6660 Integer overflow fixes.
6662 * dbusbind.c: Serial number integer overflow fixes.
6663 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6664 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6665 to hold a serial number that is too large for a fixnum.
6666 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6667 Check for serial numbers out of range. Decode any serial number
6668 that was so large that it became a float. (Bug#8722)
6670 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6671 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6672 Use XFASTINT rather than XUINT when numbers are nonnegative.
6673 (xd_append_arg, Fdbus_method_return_internal):
6674 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6675 arguments, check that Lisp number is nonnegative, rather than
6676 silently wrapping negative numbers around. (Bug#8722)
6677 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6680 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6682 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6684 ccl: Add integer overflow checks.
6685 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6686 (IN_INT_RANGE): New macros.
6687 (ccl_driver): Use them to check for integer overflow when
6688 decoding a CCL program. Many of the new checks are whether XINT (x)
6689 fits in int; it doesn't always, on 64-bit hosts. The new version
6690 doesn't catch all possible integer overflows, but it's an
6691 improvement. (Bug#8719)
6693 * alloc.c (make_event_array): Use XINT, not XUINT.
6694 There's no need for unsigned here.
6696 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6697 This follows up to the 2011-05-06 change that substituted uintptr_t
6698 for EMACS_INT. This case wasn't caught back then.
6700 Rework Fformat to avoid integer overflow issues.
6701 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6702 now (part of C89). Include <verify.h>.
6703 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6704 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6705 (Fformat): Avoid the prepass trying to compute sizes; it was only
6706 approximate and thus did not catch overflow reliably. Instead, walk
6707 through the format just once, formatting and computing sizes as we go,
6708 checking for integer overflow at every step, and allocating a larger
6709 buffer as needed. Keep track separately whether the format is
6710 multibyte. Keep only the most-recently calculated precision, rather
6711 than them all. Record whether each argument has been converted to
6712 string. Use EMACS_INT, not int, for byte and char and arg counts.
6713 Support field widths and precisions larger than INT_MAX. Avoid
6714 sprintf's undefined behavior with conversion specifications such as %#d
6715 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6716 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6717 formatting out-of-range floating point numbers with int
6720 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6722 * data.c: Avoid integer truncation in expressions involving floats.
6723 * data.c: Include <intprops.h>.
6724 (arith_driver): When there's an integer overflow in an expression
6725 involving floating point, convert the integers to floating point
6726 so that the resulting value does not suffer from catastrophic
6727 integer truncation. For example, on a 64-bit host (* 4
6728 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6729 Do not rely on undefined behavior after integer overflow.
6731 merge count_size_as_multibyte, parse_str_to_multibyte
6732 * character.c, character.h (count_size_as_multibyte):
6733 Rename from parse_str_to_multibyte; all uses changed.
6734 Check for integer overflow.
6735 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6736 since it's now a duplicate of the other. This is more of
6737 a character than a buffer op, so better that it's in character.c.
6738 * fns.c, print.c: Adjust to above changes.
6740 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6742 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6744 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6746 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6747 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6748 (x_clipboard_manager_save): Now static.
6749 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6751 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6752 (crypto_hash_function): Now static.
6753 Fix pointer signedness problems. Avoid unnecessary initializations.
6755 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6757 * termhooks.h (Vselection_alist): Make it terminal-local.
6759 * terminal.c (create_terminal): Initialize it.
6761 * xselect.c: Support for clipboard managers.
6762 (Vselection_alist): Move to termhooks.h as terminal-local var.
6763 (LOCAL_SELECTION): New macro.
6764 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6765 (symbol_to_x_atom): Remove gratuitous arg.
6766 (x_handle_selection_request, lisp_data_to_selection_data)
6767 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6768 (x_own_selection, x_get_local_selection, x_convert_selection):
6769 New arg, specifying work frame. Use terminal-local Vselection_alist.
6770 (some_frame_on_display): Delete unused function.
6771 (Fx_own_selection_internal, Fx_get_selection_internal)
6772 (Fx_disown_selection_internal, Fx_selection_owner_p)
6773 (Fx_selection_exists_p): New optional frame arg.
6774 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6775 (x_handle_selection_clear): Don't treat other terminals with the
6776 same keyboard specially. Use the terminal-local Vselection_alist.
6777 (x_clear_frame_selections): Use Frun_hook_with_args.
6779 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6781 * xterm.h: Add support for those atoms.
6783 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6785 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6786 (converted_selections, conversion_fail_tag): New global variables.
6787 (x_selection_request_lisp_error): Free the above.
6788 (x_get_local_selection): Remove unnecessary code.
6789 (x_reply_selection_request): Args changed; handle arbitrary array
6790 of converted selections stored in converted_selections.
6791 Separate the XChangeProperty and SelectionNotify steps.
6792 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6793 (x_convert_selection): New function.
6794 (x_handle_selection_event): Simplify.
6795 (x_get_foreign_selection): Don't ignore incoming requests while
6796 waiting for an answer; this will fail when we implement
6797 SAVE_TARGETS, and seems unnecessary anyway.
6798 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6799 (Vx_sent_selection_functions): Doc fix.
6801 2011-05-26 Leo Liu <sdl.web@gmail.com>
6803 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6805 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6807 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6809 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6810 for fringe update if it has periodic bitmap.
6811 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6812 and fringe_bitmap_periodic_p.
6814 * fringe.c (get_fringe_bitmap_data): New function.
6815 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6816 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6817 row. Mark glyph row for fringe update if periodicity changed.
6819 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6820 for fringe update unless it has periodic bitmap.
6822 2011-05-25 Kenichi Handa <handa@m17n.org>
6824 * xdisp.c (get_next_display_element): Set correct it->face_id for
6825 a static composition.
6827 2011-05-24 Leo Liu <sdl.web@gmail.com>
6830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6832 * fns.c (crypto_hash_function, Fsha1): New function.
6833 (Fmd5): Use crypto_hash_function.
6834 (syms_of_fns): Add Ssha1.
6836 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6838 * gnutls.c: Remove unused macros.
6839 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6840 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6841 Remove macros that are defined and never used.
6842 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6844 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6846 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6847 (Fx_get_selection_internal): Minor cleanup.
6848 (Fx_own_selection_internal): Rename arguments for consistency with
6851 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6853 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6855 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6857 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6859 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6861 * dispnew.c (scrolling_window): Don't exclude the case that the
6862 last enabled row in the desired matrix touches the bottom boundary.
6864 2011-05-21 Glenn Morris <rgm@gnu.org>
6866 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6867 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6868 and add some more files.
6870 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6872 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6873 report_file_error introduced by the change from 2011-05-07.
6875 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6877 * systime.h (Time): Define only if emacs is defined.
6878 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6879 where the include path doesn't have X11/X.h by default. See
6880 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6882 2011-05-20 Kenichi Handa <handa@m17n.org>
6884 * composite.c (find_automatic_composition): Fix previous change.
6886 2011-05-20 Glenn Morris <rgm@gnu.org>
6888 * lisp.mk: New file, split from Makefile.in.
6889 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6890 (shortlisp): Remove.
6891 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6893 2011-05-19 Glenn Morris <rgm@gnu.org>
6895 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6896 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6897 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6898 (lisp): Set the order to that of loadup.el.
6899 (shortlisp): Make it a copy of $lisp.
6900 (SOME_MACHINE_LISP): Remove.
6901 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6902 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6904 2011-05-18 Kenichi Handa <handa@m17n.org>
6906 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6907 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6908 (find_automatic_composition): Mostly rewrite for efficiency.
6910 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6912 * makefile.w32-in: Update dependencies.
6914 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6916 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6917 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6919 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6921 Fix some integer overflow issues, such as string length overflow.
6923 * insdel.c (count_size_as_multibyte): Check for string overflow.
6925 * character.c (lisp_string_width): Check for string overflow.
6926 Use EMACS_INT, not int, for string indexes and lengths; in
6927 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6928 the resulting string length overflows an EMACS_INT; instead,
6929 report a string overflow if no precision given. When checking for
6930 precision exhaustion, use a check that cannot possibly have
6931 integer overflow. (Bug#8675)
6932 * character.h (lisp_string_width): Adjust to new signature.
6934 * alloc.c (string_overflow): New function.
6935 (Fmake_string): Use it. This doesn't change behavior, but saves
6936 a few bytes and will simplify future changes.
6937 * character.c (string_escape_byte8): Likewise.
6938 * lisp.h (string_overflow): New decl.
6940 Fixups, following up to the user-interface timestamp change.
6941 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6942 for UI timestamps, instead of unsigned long.
6943 * msdos.c (mouse_get_pos): Likewise.
6944 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6945 * w32gui.h (Time): Define by including "systime.h" rather than by
6946 declaring it ourselves. (Bug#8664)
6948 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6949 * image.c (clear_image_cache): Likewise.
6951 * term.c (term_mouse_position): Don't assume time_t wraparound.
6953 Be more systematic about user-interface timestamps.
6954 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6955 and sometimes 'EMACS_UINT', to represent these timestamps.
6956 This change causes it to use 'Time' uniformly, as that's what X uses.
6957 This makes the code easier to follow, and makes it easier to catch
6958 integer overflow bugs such as Bug#8664.
6959 * frame.c (Fmouse_position, Fmouse_pixel_position):
6960 Use Time, not unsigned long, for user-interface timestamps.
6961 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6962 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6963 * keyboard.h (last_event_timestamp): Likewise.
6964 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6965 * menu.h (xmenu_show): Likewise.
6966 * term.c (term_mouse_position): Likewise.
6967 * termhooks.h (struct input_event.timestamp): Likewise.
6968 (struct terminal.mouse_position_hook): Likewise.
6969 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6970 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6971 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6972 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6974 * menu.h, termhooks.h: Include "systime.h", for Time.
6976 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6977 Don't assume that the difference between two unsigned long values
6978 can fit into an integer. At this point, we know button_down_time
6979 <= event->timestamp, so the difference must be nonnegative, so
6980 there's no need to cast the result if double-click-time is
6981 nonnegative, as it should be; check that it's nonnegative, just in
6982 case. This bug is triggered when events are more than 2**31 ms
6983 apart (about 25 days). (Bug#8664)
6985 * xselect.c (last_event_timestamp): Remove duplicate decl.
6986 (x_own_selection): Remove needless cast to unsigned long.
6988 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6989 that always fit in int. Use a sentinel instead of a counter, to
6990 avoid a temp and to allay GCC's concerns about possible int overflow.
6991 * frame.h (struct frame): Use int for menu_bar_items_used
6992 instead of EMACS_INT, since it always fits in int.
6994 * menu.c (grow_menu_items): Check for int overflow.
6996 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6998 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6999 Before, the code was not consistent. These values cannot exceed
7000 2**31 - 1 so there's no need to make them unsigned.
7001 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7002 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7003 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7005 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7007 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7008 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7009 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7010 presumably because the widths might not match.
7012 * window.c (size_window): Avoid needless test at loop start.
7014 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7016 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7018 2011-05-12 Drew Adams <drew.adams@oracle.com>
7020 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7022 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7024 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7025 `width' to `bar_area_x' and `bar_area_width', respectively.
7026 (x_scroll_run): Take account of fringe background extension.
7028 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7029 Rename local vars `left' and `width' to `bar_area_x' and
7030 `bar_area_width', respectively.
7031 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7032 background extension.
7034 2011-05-10 Jim Meyering <meyering@redhat.com>
7036 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7038 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7040 * image.c (Finit_image_library): Return t for built-in image types,
7041 like pbm and xbm. (Bug#8640)
7043 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7045 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7047 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7049 * w32console.c (Fset_screen_color): Doc fix.
7050 (Fget_screen_color): New function.
7051 (syms_of_ntterm): Defsubr it.
7053 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7054 unlink the temporary file if Fcall_process didn't create it in the
7056 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7057 child process will be redirected to a file specified with `:file'.
7058 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7059 cue to call_process_cleanup not to close that handle.
7061 2011-05-07 Ben Key <bkey76@gmail.com>
7063 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7064 one of two shell specific rules, either bootstrap-temacs-CMD or
7065 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7066 to the previous implementation of the bootstrap-temacs rule.
7067 The bootstrap-temacs-CMD rule is similar to the previous
7068 implementation of the bootstrap-temacs rule except that it
7069 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7072 These changes, along with some changes to nt/configure.bat,
7073 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7074 earlier fix to add support for --cflags and --ldflags options
7075 that include quotes so that it works whether make uses cmd or
7078 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7080 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7081 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7083 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7084 a string. Handle both cases.
7085 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7086 (Fdbus_register_method): Use Qinvalid_function.
7088 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7090 * makefile.w32-in: Update dependencies.
7091 (LISP_H): Add inttypes.h and stdin.h.
7092 (PROCESS_H): Add unistd.h.
7094 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7096 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7097 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7099 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7101 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7103 * term.c (vfatal): Remove stray call to va_end.
7104 It's not needed and the C Standard doesn't allow it here anyway.
7106 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7107 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7109 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7112 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7114 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7116 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7118 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7120 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7122 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7123 * charset.c (Fdefine_charset_internal): Don't initialize
7124 charset.code_space[15]. The value was garbage, on hosts with
7125 32-bit int (Bug#8600).
7127 * lread.c (read_integer): Be more consistent with string-to-number.
7128 Use string_to_number to do the actual conversion; this avoids
7129 rounding errors and fixes some other screwups. Without this fix,
7130 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7131 (digit_to_number): Move earlier, for benefit of read_integer.
7132 Return -1 if the digit is out of range for the base, -2 if it is
7133 not a digit in any supported base. (Bug#8602)
7135 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7137 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7138 to match comment at start of function. This also removes a
7139 GCC warning about overflow in a 32+64-bit port.
7141 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7143 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7144 Reported by Stefan Monnier in
7145 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7146 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7147 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7149 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7150 (EMACS_UINTPTR): Likewise, with uintptr_t.
7152 * lisp.h: Prefer 64-bit EMACS_INT if available.
7153 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7154 on 32-bit hosts that have 64-bit int, so that they can access
7156 However, temporarily disable this change unless the temporary
7157 symbol WIDE_EMACS_INT is defined.
7159 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7161 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7162 This removes an assumption that EMACS_INT and long are the same
7163 width as pointers. The assumption is true for Emacs porting targets
7164 now, but we want to make other targets possible.
7165 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7166 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7167 In the rest of the code, change types of integers that hold casted
7168 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7169 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7170 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7171 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7172 No need to cast type when ORing.
7173 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7174 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7175 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7176 assume EMACS_INT is the same width as char *.
7177 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7178 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7179 Remove no-longer-needed casts.
7180 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7181 (xg_tool_bar_help_callback, xg_make_tool_item):
7182 Use EMACS_INTPTR to hold an integer
7183 that will be cast to void *; this can avoid a GCC warning
7184 if EMACS_INT is not the same width as void *.
7185 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7186 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7187 (current_message_1, set_message_1):
7188 Use a local to convert to proper width without a cast.
7189 * xmenu.c (dialog_selection_callback): Likewise.
7191 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7192 Also, don't assume VALBITS / RAND_BITS is less than 5,
7193 and don't rely on undefined behavior when shifting a 1 left into
7195 * lisp.h (get_random): Change signature to match.
7197 * lread.c (hash_string): Use size_t, not int, for hash computation.
7198 Normally we prefer signed values; but hashing is special, because
7199 it's better to use unsigned division on hash table sizes so that
7200 the remainder is nonnegative. Also, size_t is the natural width
7201 for hashing into memory. The previous code used 'int', which doesn't
7202 retain enough info to hash well into very large tables.
7203 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7205 * dbusbind.c: Don't possibly lose pointer info when converting.
7206 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7207 Use XPNTR rather than XHASH, so that the high-order bits of
7208 the pointer aren't lost when converting through void *.
7210 * eval.c (Fautoload): Don't double-shift a pointer.
7212 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7214 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7216 * gnutls.c (DEF_GNUTLS_FN):
7217 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7219 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7221 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7224 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7226 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7227 New version that can reserve upto 2GB of heap space.
7229 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7231 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7233 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7235 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7236 `gnutls_certificate_set_x509_key_file'.
7238 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7240 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7241 Update dependencies.
7243 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7245 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7246 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7247 Remove unused parameter `fildes'.
7248 * process.c (read_process_output, send_process): Don't pass it.
7250 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7252 Fix previous change: the library cache is defined in w32.c.
7253 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7254 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7256 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7258 Implement dynamic loading of GnuTLS on Windows.
7260 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7261 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7262 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7265 * gnutls.c (Qgnutls_dll): Define.
7266 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7267 (gnutls_*): Declare function pointers.
7268 (init_gnutls_functions): New function to initialize function pointers.
7269 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7270 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7271 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7272 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7273 (emacs_gnutls_write, emacs_gnutls_read)
7274 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7275 (Fgnutls_available_p): New function.
7276 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7277 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7278 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7280 * image.c: Include w32.h.
7281 (Vimage_type_cache): Delete.
7282 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7283 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7284 (w32_delayed_load): Move to w32.c.
7286 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7288 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7289 (w32_delayed_load): Move from image.c. When loading a library, record
7290 its filename in the :loaded-from property of the library id.
7291 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7292 Initialize and staticpro them.
7293 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7295 * process.c: Include lisp.h before w32.h, not after.
7296 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7297 instead of gnutls_record_check_pending.
7299 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7301 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7303 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7304 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7307 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7309 * xterm.c (x_set_frame_alpha): Do not set property on anything
7310 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7312 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7314 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7316 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7318 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7319 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7320 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7321 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7322 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7323 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7324 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7325 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7326 (Qgnutls_bootprop_callbacks_verify): Make static.
7328 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7330 * callproc.c: Indentation fixup.
7332 * sysdep.c (wait_for_termination_1): Make static.
7333 (wait_for_termination, interruptible_wait_for_termination):
7334 Move after wait_for_termination_1.
7336 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7338 * sysdep.c (interruptible_wait_for_termination): New function
7339 which is like wait_for_termination, but allows keyboard
7342 * callproc.c (Fcall_process): Add (:file "file") as an option for
7344 (Fcall_process_region): Ditto.
7346 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7348 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7349 rather than `XVECTOR (FOO)->size'.
7351 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7352 inttypes.h, as a gnulib replacement is used if it not available in
7355 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7357 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7358 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7359 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7361 * coding.c (coding_alloc_by_realloc): Error out if destination
7362 will grow beyond MOST_POSITIVE_FIXNUM.
7363 (decode_coding_emacs_mule): Abort if there isn't enough place in
7364 charbuf for the composition carryover bytes. Reserve an extra
7365 space for up to 2 characters produced in a loop.
7366 (decode_coding_iso_2022): Abort if there isn't enough place in
7367 charbuf for the composition carryover bytes.
7369 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7371 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7372 aborting when %lld or %lll format is passed.
7373 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7374 %llo or %llx format is passed. (Bug#8545)
7376 * window.c (window_scroll_line_based): Use a marker instead of
7377 simple variables to record original value of point. (Bug#7952)
7379 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7380 produced by %s or %c overflows available buffer space. (Bug#8545)
7382 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7384 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7385 (SIZE_MAX): Move defn after all includes, as they might #define it.
7387 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7389 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7391 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7393 * keyboard.c (Qdelayed_warnings_hook): Define.
7394 (command_loop_1): Run `delayed-warnings-hook'
7395 if Vdelayed_warnings_list is non-nil.
7396 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7397 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7399 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7401 * doprnt.c (doprnt): Don't return value smaller than the buffer
7402 size if the message was truncated. (Bug#8545).
7404 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7406 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7407 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7409 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7411 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7413 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7415 * makefile.w32-in: Update dependencies.
7417 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7419 Improve `doprnt' and its usage. (Bug#8545)
7420 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7421 `format_end'. Remove support for %l as a conversion specifier.
7422 Don't use xrealloc. Improve diagnostics when the %l size modifier
7423 is used. Update the commentary.
7425 * eval.c (verror): Simplify calculation of size_t.
7427 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7430 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7432 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7435 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7437 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7438 This makes this file independent of the recent pseudovector change.
7440 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7442 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7444 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7445 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7446 Remove unused local.
7447 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7449 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7450 GCC 4.6.0 optimizes based on type-based alias analysis.
7451 For example, if b is of type struct buffer * and v of type struct
7452 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7453 != &v->size, and therefore "v->size = 1; b->size = 2; return
7454 v->size;" must therefore return 1. This assumption is incorrect
7455 for Emacs, since it type-puns struct Lisp_Vector * with many other
7456 types. To fix this problem, this patch adds a new type struct
7457 vectorlike_header that documents the constraints on layout of vectors
7458 and pseudovectors, and helps optimizing compilers not get fooled
7459 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7460 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7461 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7463 (XSETPVECTYPE): Rewrite in terms of new macro.
7464 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7465 This is a bit clearer, and further avoids the possibility of
7466 undesirable aliasing.
7467 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7468 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7469 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7470 since Lisp_Subr is a special case (no "next" field).
7471 (ASIZE): Now uses header.size rather than size.
7472 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7473 to avoid the hassle of writing XVECTOR (foo)->header.size.
7474 (struct vectorlike_header): New type.
7475 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7476 object, to help avoid aliasing.
7477 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7478 (SUBRP): Likewise, since Lisp_Subr is a special case.
7479 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7480 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7481 (struct Lisp_Hash_Table): Combine first two members into a single
7482 struct vectorlike_header member. All uses of "size" and "next" members
7483 changed to be "header.size" and "header.next".
7484 * buffer.h (struct buffer): Likewise.
7485 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7486 * frame.h (struct frame): Likewise.
7487 * process.h (struct Lisp_Process): Likewise.
7488 * termhooks.h (struct terminal): Likewise.
7489 * window.c (struct save_window_data, struct saved_window): Likewise.
7490 * window.h (struct window): Likewise.
7491 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7492 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7493 * buffer.c (init_buffer_once): Likewise.
7494 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7496 * process.c (Fformat_network_address): Use local var for size,
7499 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7501 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7502 * data.c (atof): Remove decl; no longer used or needed.
7503 (digit_to_number): Move to lread.c.
7504 (Fstring_to_number): Use new string_to_number function, to be
7505 consistent with how the Lisp reader treats infinities and NaNs.
7506 Do not assume that floating-point numbers represent EMACS_INT
7507 without losing information; this is not true on most 64-bit hosts.
7508 Avoid double-rounding errors, by insisting on integers when
7509 parsing non-base-10 numbers, as the documentation specifies.
7510 * lisp.h (string_to_number): New decl, replacing ...
7511 (isfloat_string): Remove.
7512 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7513 (read1): Do not accept +. and -. as integers; this
7514 appears to have been a coding error. Similarly, do not accept
7515 strings like +-1e0 as floating point numbers. Do not report
7516 overflow for integer overflows unless the base is not 10 which
7517 means we have no simple and reliable way to continue.
7518 Break out the floating-point parsing into a new
7519 function string_to_number, so that Fstring_to_number parses
7520 floating point numbers consistently with the Lisp reader.
7521 (digit_to_number): Move here from data.c. Make it static inline.
7522 (E_CHAR, EXP_INT): Remove, replacing with ...
7523 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7524 (string_to_number): New function, replacing isfloat_string.
7525 This function checks for valid syntax and produces the resulting
7526 Lisp float number too. Rework it so that string-to-number
7527 no longer mishandles examples like "1.0e+". Use strtoumax,
7528 so that overflow for non-base-10 numbers is reported only when
7529 there's no portable and simple way to convert to floating point.
7531 * textprop.c (set_text_properties_1): Rewrite for clarity,
7532 and to avoid GCC warning about integer overflow.
7534 * intervals.h (struct interval): Use EMACS_INT for members
7535 where EMACS_UINT might cause problems. See
7536 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7537 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7538 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7540 (offset_intervals): Tell GCC not to worry about length overflow
7541 when negating a negative length.
7543 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7544 (overrun_check_free): Likewise.
7546 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7547 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7550 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7551 (gnutls_make_error): Rename local to avoid shadowing.
7552 (gnutls_emacs_global_deinit): ifdef out; not used.
7553 (Fgnutls_boot): Use const for pointer to readonly storage.
7554 Comment out unused local. Fix pointer signedness problems.
7556 * lread.c (openp): Don't stuff size_t into an 'int'.
7557 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7558 about possible signed overflow.
7560 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7561 (GDK_KEY_g): Don't define if already defined.
7562 (xg_prepare_tooltip): Avoid pointer signedness problem.
7563 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7565 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7566 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7568 * xfns.c (Fx_window_property): Simplify a bit,
7569 to make a bit faster and to avoid GCC 4.6.0 warning.
7570 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7572 * fns.c (internal_equal): Don't assume size_t fits in int.
7574 * alloc.c (compact_small_strings): Tighten assertion a little.
7576 Replace pEd with more-general pI, and fix some printf arg casts.
7577 * lisp.h (pI): New macro, generalizing old pEd macro to other
7578 conversion specifiers. For example, use "...%"pI"d..." rather
7579 than "...%"pEd"...".
7580 (pEd): Remove. All uses replaced with similar uses of pI.
7581 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7582 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7583 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7584 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7585 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7586 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7587 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7589 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7590 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7591 * print.c (safe_debug_print, print_object): Likewise.
7592 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7594 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7595 avoiding the 0 flag, which is not portable.
7596 * process.c (Fmake_network_process): Use pI to avoid cast.
7597 * region-cache.c (pp_cache): Likewise.
7598 * xdisp.c (decode_mode_spec): Likewise.
7599 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7600 behavior on 64-bit hosts with printf arg.
7601 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7602 (x_stop_queuing_selection_requests): Likewise.
7603 (x_get_window_property): Don't truncate byte count to an 'int'
7606 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7607 here, since it parses constructs like leading '-' and spaces,
7608 which are not wanted; and it overflows with large numbers.
7609 Instead, simply match F[0-9]+, which is what is wanted anyway.
7611 * alloc.c: Remove unportable assumptions about struct layout.
7612 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7613 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7614 (allocate_vectorlike, make_pure_vector): Use the new macros,
7615 plus offsetof, to remove unportable assumptions about struct layout.
7616 These assumptions hold on all porting targets that I know of, but
7617 they are not guaranteed, they're easy to remove, and removing them
7618 makes further changes easier.
7620 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7621 This doesn't fix a bug but makes the code clearer.
7622 (string_overrun_cookie): Now const. Use initializers that
7623 don't formally overflow signed char, to avoid warnings.
7624 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7625 can cause Emacs to crash when string overrun checking is enabled.
7626 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7627 multiple of sizeof (EMACS_INT); it need not be, if
7628 alignof(EMACS_INT) < sizeof (EMACS_INT).
7629 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7631 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7633 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7635 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7637 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7638 supposed to be handshaking. (Bug#8556)
7639 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7641 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7643 * lisp.h (Qdebug): List symbol.
7644 * eval.c (Qdebug): Restore global linkage.
7645 * keyboard.c (debug-on-event): New variable.
7646 (handle_user_signal): Break into debugger when debug-on-event
7647 matches the current signal symbol.
7649 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7651 * alloc.c (check_sblock, check_string_bytes)
7652 (check_string_free_list): Convert to standard C.
7654 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7656 * w32.c (emacs_gnutls_push): Fix typo.
7658 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7660 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7661 "cast to pointer from integer of different size".
7663 Improve doprnt and its use in verror. (Bug#8545)
7664 * doprnt.c (doprnt): Document the set of format control sequences
7665 supported by the function. Use SAFE_ALLOCA instead of always
7668 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7669 is one byte too soon. Don't use xrealloc; instead xfree and
7672 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7674 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7677 * gnutls.c: Renamed global_initialized to
7678 gnutls_global_initialized. Added internals for the
7679 :verify-hostname-error, :verify-error, and :verify-flags
7680 parameters of `gnutls-boot' and documented those parameters in the
7681 docstring. Start callback support.
7682 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7683 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7684 on error. Return error code.
7685 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7686 (emacs_gnutls_read): Likewise.
7687 (Fgnutls_boot): Return handshake error code.
7688 (emacs_gnutls_handle_error): New function.
7689 (wsaerror_to_errno): Likewise.
7691 * w32.h (emacs_gnutls_pull): Add prototype.
7692 (emacs_gnutls_push): Likewise.
7694 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7695 (emacs_gnutls_push): Likewise.
7697 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7699 * process.c (wait_reading_process_output): Check if GnuTLS
7700 buffered some data internally if no FDs are set for TLS
7703 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7704 (LIBS): Link to USER_LIBS.
7705 ($(BLD)/gnutls.$(0)): New target.
7707 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7709 * xdisp.c (handle_single_display_spec): Rename the
7710 display_replaced_before_p argument into display_replaced_p, to
7711 make it consistent with the commentary. Fix typos in the
7714 * textprop.c (syms_of_textprop): Remove dead code.
7715 (copy_text_properties): Delete obsolete commentary about an
7716 interface that was deleted long ago. Fix typos in the description
7719 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7720 to changes in oldXMenu/XMenu.h from 2011-04-16.
7721 <menu_help_message, prev_menu_help_message>: Constify.
7722 (IT_menu_make_room): menu->help_text is now `const char **';
7725 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7726 to changes in oldXMenu/XMenu.h from 2011-04-16.
7727 (struct XMenu): Declare `help_text' `const char **'.
7729 * xfaces.c <Qunspecified>: Make extern again.
7731 * syntax.c: Include sys/types.h before including regex.h, as
7734 * doc.c (get_doc_string): Improve the format passed to `error'.
7736 * doprnt.c (doprnt): Improve commentary.
7738 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7740 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7743 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7744 changes in globals.h immediately force recompilation.
7745 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7746 $(CURDIR)/s/ms-w32.h.
7747 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7749 * character.c (Fchar_direction): Function deleted.
7750 (syms_of_character): Don't defsubr it.
7751 <char-direction-table>: Deleted.
7753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7755 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7756 * doprnt.c: Include limits.h.
7757 (SIZE_MAX): New macro.
7758 (doprnt): Return a size_t value. 2nd arg is now size_t.
7759 Many local variables are now size_t instead of int or unsigned.
7760 Improve overflow protection. Support `l' modifier for integer
7761 conversions. Support %l conversion. Don't assume an EMACS_INT
7762 argument for integer conversions and for %c.
7764 * lisp.h (doprnt): Restore prototype.
7766 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7769 * Makefile.in (base_obj): Add back doprnt.o.
7771 * deps.mk (doprnt.o): Add back prerequisites.
7772 (callint.o): Depend on character.h.
7774 * eval.c (internal_lisp_condition_case): Include the handler
7775 representation in the error message.
7776 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7777 when breaking from the loop.
7779 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7781 * callint.c (Fcall_interactively): When displaying error message
7782 about invalid control letter, pass the character's codepoint, not
7783 a pointer to its multibyte form. Improve display of the character
7784 in octal and display also its hex code.
7786 * character.c (char_string): Use %x to display the (unsigned)
7787 codepoint of an invalid character, to avoid displaying a bogus
7790 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7791 `error', not SYMBOL_NAME itself.
7793 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7794 character arguments to `error'.
7796 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7797 to `error' in error message about FINAL_CHAR argument. Make sure
7798 FINAL_CHAR is a character, and use %c when it is passed as
7799 argument to `error'.
7801 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7803 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7805 * w32.c: Include <time.h>.
7806 (sys_localtime): New function.
7808 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7810 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7812 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7814 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7816 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7819 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7821 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7822 gl_state.e_property when gl_state.object is Qt.
7824 * insdel.c (make_gap_larger): Remove limitation of buffer size
7827 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7829 * xdisp.c (lookup_glyphless_char_display)
7830 (produce_glyphless_glyph): Handle cons cell entry in
7831 glyphless-char-display.
7832 (Vglyphless_char_display): Document it.
7834 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7835 glyphless-char-display.
7837 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7839 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7841 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7843 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7844 definition for no-X builds.
7846 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7848 Static checks with GCC 4.6.0 and non-default toolkits.
7850 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7852 * process.c (keyboard_bit_set): Define only if SIGIO.
7853 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7854 (send_process): Repair possible setjmp clobbering.
7856 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7858 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7860 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7862 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7863 Define only if needed.
7865 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7866 by pacifying GCC about it. Maybe it's time to retire it?
7867 * xfaces.c (USG, __TIMEVAL__): Likewise.
7869 * dispextern.h (struct redisplay_interface): Rename param
7871 * termhooks.h (struct terminal): Likewise.
7872 * xterm.c (xembed_send_message): Likewise.
7874 * insdel.c (make_gap_smaller): Define only if
7875 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7877 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7880 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7881 so that we aren't warned about unused symbols.
7883 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7885 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7887 * xfns.c (x_real_positions): Mark locals as initialized.
7889 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7891 * xterm.c: Fix problems found by static analysis with other toolkits.
7892 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7893 (x_dispatch_event): Declare static if USE_GTK, and
7894 define if USE_GTK || USE_X_TOOLKIT.
7895 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7896 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7897 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7898 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7900 * xmenu.c (menu_help_callback): Pointer type fixes.
7901 Use const pointers when pointing at readonly data. Avoid pointer
7903 (FALSE): Remove unused macro.
7904 (update_frame_menubar): Remove unused decl.
7906 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7908 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7909 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7910 (single_menu_item): Rename local to avoid shadowing.
7912 * keyboard.c (make_lispy_event): Remove unused local var.
7914 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7915 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7917 * bitmaps: Change bitmaps from unsigned char back to the X11
7918 compatible char. Avoid the old compiler warnings about
7919 out-of-range initializers by using, for example, '\xab' rather
7922 * xgselect.c (xgselect_initialize): Check vs interface
7923 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7925 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7927 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7928 to read-only memory.
7930 * fns.c (vector): Remove; this old hack is no longer needed.
7932 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7934 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7936 * xrdb.c (x_load_resources): Omit unused local.
7938 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7939 (x_window): Rename locals to avoid shadowing.
7940 (USG): Use the kludged USG macro, to pacify gcc.
7942 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7943 (x_term_init): Remove local to avoid shadowing.
7945 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7947 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7948 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7950 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7952 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7954 Fix regex.c, syntax.c and friends for buffers > 2GB.
7955 * syntax.h (struct gl_state_s): Declare character position members
7958 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7960 * textprop.c (verify_interval_modification, interval_of):
7961 Declare arguments EMACS_INT.
7963 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7966 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7968 * indent.c (Fvertical_motion): Local variable it_start is now
7971 * regex.c (re_match, re_match_2, re_match_2_internal)
7972 (bcmp_translate, regcomp, regexec, print_double_string)
7973 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7974 (re_compile_pattern, re_exec): Declare arguments and local
7975 variables `size_t' and `ssize_t' and return values `regoff_t', as
7977 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7978 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7979 <compile_stack_type>: `size' and `avail' are now `size_t'.
7981 * regex.h <regoff_t>: Use ssize_t, not int.
7982 (re_search, re_search_2, re_match, re_match_2): Arguments that
7983 specify buffer/string position and length are now ssize_t and
7984 size_t. Return type is regoff_t.
7986 2011-04-16 Ben Key <bkey76@gmail.com>
7988 * nsfont.m: Fixed bugs in ns_get_family and
7989 ns_descriptor_to_entity that were caused by using free to
7990 deallocate memory blocks that were allocated by xmalloc (via
7991 xstrdup). This caused Emacs to crash when compiled with
7992 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7993 --enable-checking=xmallocoverrun). xfree is now used to
7994 deallocate these memory blocks.
7996 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7998 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8000 emacs_write: Accept and return EMACS_INT for sizes.
8001 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8003 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8004 Accept and return EMACS_INT.
8005 (emacs_gnutls_write): Return the number of bytes written on
8007 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8008 (emacs_read, emacs_write): Remove check for negative size, as the
8009 Emacs source code has been audited now.
8010 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8011 (emacs_read, emacs_write): Use it.
8012 * process.c (send_process): Adjust to the new signatures of
8013 emacs_write and emacs_gnutls_write. Do not attempt to store
8014 a byte offset into an 'int'; it might overflow.
8015 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8017 * sound.c: Don't assume sizes fit in 'int'.
8018 (struct sound_device.period_size, alsa_period_size):
8019 Return EMACS_INT, not int.
8020 (struct sound_device.write, vox_write, alsa_write):
8021 Accept EMACS_INT, not int.
8022 (wav_play, au_play): Use EMACS_INT to store sizes and to
8023 record read return values.
8025 2011-04-15 Ben Key <bkey76@gmail.com>
8027 * keyboard.c (Qundefined): Don't declare static since it is used
8029 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8030 static since they are used in nsfont.m.
8032 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8034 * process.c (Qprocessp): Don't declare static.
8035 * lisp.h (Qprocessp): Declare again.
8037 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8039 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8041 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8043 Improve C-level modularity by making more things 'static'.
8045 Don't publish debugger-only interfaces to other modules.
8046 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8047 (verify_bytepos, count_markers): Move decls to the only modules
8049 * region-cache.h (pp_cache): Likewise.
8050 * window.h (check_all_windows): Likewise.
8051 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8053 * sysdep.c (croak): Now static, if
8054 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8055 * syssignal.h (croak): Declare only if not static.
8057 * alloc.c (refill_memory_reserve): Now static if
8058 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8059 * lisp.h (refill_memory_reserve): Declare only if not static.
8061 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8062 Define only if USE_LUCID.
8064 * xrdb.c (x_customization_string, x_rm_string): Now static.
8066 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8067 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8069 * xdisp.c (draw_row_with_mouse_face): Now static.
8070 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8072 * window.h (check_all_windows): Mark externally visible.
8074 * window.c (window_deletion_count): Now static.
8076 * undo.c: Make symbols static if they're not exported.
8077 (last_undo_buffer, last_boundary_position, pending_boundary):
8080 * textprop.c (interval_insert_behind_hooks): Now static.
8081 (interval_insert_in_front_hooks): Likewise.
8083 * term.c: Make symbols static if they're not exported.
8084 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8085 (max_frame_lines, tty_set_terminal_modes):
8086 (tty_reset_terminal_modes, tty_turn_off_highlight):
8087 (get_tty_terminal): Now static.
8088 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8089 * termhooks.h (term_mouse_moveto): Do not declare if
8091 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8092 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8094 * sysdep.c: Make symbols static if they're not exported.
8095 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8097 (sigprocmask_set, full_mask): Remove; unused.
8098 (wait_debugging): Mark as visible.
8099 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8100 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8102 * syntax.c (syntax_temp): Define only if !__GNUC__.
8104 * sound.c (current_sound_device, current_sound): Now static.
8106 * search.c (searchbufs, searchbuf_head): Now static.
8108 * scroll.c (scroll_cost): Remove; unused.
8109 * dispextern.h (scroll_cost): Remove decl.
8111 * region-cache.h (pp_cache): Mark as externally visible.
8113 * process.c: Make symbols static if they're not exported.
8114 (process_tick, update_tick, create_process, chan_process):
8115 (Vprocess_alist, proc_buffered_char, datagram_access):
8116 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8117 (deactivate_process): Mark defn as static, as well as decl.
8118 * lisp.h (create_process): Remove decl.
8119 * process.h (chan_process, Vprocess_alist): Remove decls.
8121 * print.c: Make symbols static if they're not exported.
8122 (print_depth, new_backquote_output, being_printed, print_buffer):
8123 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8124 (print_interval, print_number_index, initial_stderr_stream):
8126 * lisp.h (Fprinc): Remove decl.
8127 (debug_output_compilation_hack): Mark as externally visible.
8129 * sysdep.c (croak): Move decl from here to syssignal.h.
8130 * syssignal.h (croak): Put it here, so the API can be checked when
8131 'croak' is called from dissociate_if_controlling_tty.
8133 * minibuf.c: Make symbols static if they're not exported.
8134 (minibuf_save_list, choose_minibuf_frame): Now static.
8135 * lisp.h (choose_minibuf_frame): Remove decl.
8137 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8139 * lread.c: Make symbols static if they're not exported.
8140 (read_objects, initial_obarray, oblookup_last_bucket_number):
8142 (make_symbol): Remove; unused.
8143 * lisp.h (initial_obarray, make_symbol): Remove decls.
8145 * keyboard.c: Make symbols static if they're not exported.
8146 (single_kboard, recent_keys_index, total_keys, recent_keys):
8147 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8148 (this_single_command_key_start, echoing, last_auto_save):
8149 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8150 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8151 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8152 (Vlispy_mouse_stem, double_click_count):
8154 (force_auto_save_soon): Define only if SIGDANGER.
8155 (ignore_mouse_drag_p): Now static if
8156 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8157 (print_help): Remove; unused.
8158 (stop_character, last_timer_event): Mark as externally visible.
8159 * keyboard.h (ignore_mouse_drag_p): Declare only if
8160 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8161 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8162 * lisp.h (echoing): Remove decl.
8163 (force_auto_save_soon): Declare only if SIGDANGER.
8164 * xdisp.c (redisplay_window): Simplify code, to make it more
8165 obvious that ignore_mouse_drag_p is not accessed if !defined
8166 USE_GTK && !defined HAVE_NS.
8168 * intervals.c: Make symbols static if they're not exported.
8169 (merge_properties_sticky, merge_interval_right, delete_interval):
8171 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8173 * insdel.c: Make symbols static if they're not exported.
8174 However, leave prepare_to_modify_buffer alone. It's never
8175 called from outside this function, but that appears to be a bug.
8176 (combine_after_change_list, combine_after_change_buffer):
8177 (adjust_after_replace, signal_before_change): Now static.
8178 (adjust_after_replace_noundo): Remove; unused.
8179 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8180 (signal_before_change): Remove decls.
8182 * indent.c (val_compute_motion, val_vmotion): Now static.
8184 * image.c: Make symbols static if they're not exported.
8185 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8187 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8188 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8190 * fringe.c (standard_bitmaps): Now static.
8191 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8193 * frame.c: Make symbols static if they're not exported.
8194 (x_report_frame_params, make_terminal_frame): Now static.
8195 (get_frame_param): Now static, unless HAVE_NS.
8196 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8197 (x_get_resource_string): Remove; not used.
8198 * frame.h (make_terminal_frame, x_report_frame_params):
8199 (x_get_resource_string); Remove decls.
8200 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8201 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8203 * font.c, fontset.c: Make symbols static if they're not exported.
8204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8205 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8206 * font.c (font_close_object): Now static.
8207 * font.h (font_close_object): Remove.
8208 * fontset.c (FONTSET_OBJLIST): Remove.
8209 (free_realized_fontset) #if-0 the body, which does nothing.
8210 (face_suitable_for_char_p): #if-0, as it's never called.
8211 * fontset.h (face_suitable_for_char_p): Remove decl.
8212 * xfaces.c (face_at_string_position):
8213 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8214 since 0 is always ASCII.
8216 * fns.c (weak_hash_tables): Now static.
8218 * fileio.c: Make symbols static if they're not exported.
8219 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8220 (Vwrite_region_annotation_buffers): Now static.
8222 * eval.c: Make symbols static if they're not exported.
8223 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8224 * lisp.h (backtrace_list): Remove decl.
8226 * emacs.c: Make symbols static if they're not exported.
8227 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8228 (fatal_error_code, fatal_error_signal_hook, standard_args):
8230 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8231 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8232 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8233 * lisp.h (fatal_error_signal_hook): Remove decl.
8234 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8236 * editfns.c: Move a (normally-unused) function to its only use.
8237 * editfns.c, lisp.h (get_operating_system_release): Remove.
8238 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8239 worth the hassle of breaking this out.
8241 * xterm.c: Make symbols static if they're not exported.
8242 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8243 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8244 (x_destroy_window, x_delete_display):
8246 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8247 (x_mouse_leave): Remove; unused.
8248 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8249 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8250 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8252 (x_mouse_leave): Declare only if WINDOWSNT.
8253 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8254 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8257 * ftxfont.c: Make symbols static if they're not exported.
8258 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8260 * font.h (ftxfont_driver): Likewise.
8262 * xfns.c: Make symbols static if they're not exported.
8263 (x_last_font_name, x_display_info_for_name):
8264 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8265 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8266 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8267 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8268 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8269 (last_show_tip_args): Now static.
8270 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8271 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8272 (x_screen_planes): Remove; unused.
8273 * dispextern.h (x_screen_planes): Remove decl.
8275 * dispnew.c: Make symbols static if they're not exported.
8276 * dispextern.h (redraw_garbaged_frames, scrolling):
8277 (increment_row_positions): Remove.
8278 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8279 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8281 (redraw_garbaged_frames): Remove; unused.
8283 * xfaces.c: Make symbols static if they're not exported.
8284 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8286 * xterm.h (defined_color): Remove decls.
8287 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8288 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8289 (menu_face_changed_default, defined_color, free_realized_face):
8290 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8291 (ascii_face_of_lisp_face): Remove; unused.
8293 * xdisp.c: Make symbols static if they're not exported.
8294 * dispextern.h (scratch_glyph_row, window_box_edges):
8295 (glyph_to_pixel_coords, set_cursor_from_row):
8296 (get_next_display_element, set_iterator_to_next):
8297 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8298 (show_mouse_face): Remove decls
8299 * frame.h (message_buf_print): Likewise.
8300 * lisp.h (pop_message, set_message, check_point_in_composition):
8302 * xterm.h (set_vertical_scroll_bar): Likewise.
8303 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8304 (message_buf_print, scratch_glyph_row, displayed_buffer):
8305 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8306 (get_next_display_element, show_mouse_face, window_box_edges):
8307 (frame_to_window_pixel_xy, check_point_in_composition):
8308 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8309 (glyph_to_pixel_coords): Remove; unused.
8311 * dired.c (file_name_completion): Now static.
8313 * dbusbind.c (xd_in_read_queued_messages): Now static.
8315 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8316 * data.c (circular_list_error): Remove.
8318 * commands.h (last_point_position, last_point_position_buffer):
8319 (last_point_position_window): Remove decls.
8320 * keyboard.c: Make these variables static.
8322 * coding.h (coding, code_convert_region, encode_coding_gap):
8324 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8325 (iso_code_class, detect_coding, code_convert_region): Now static.
8326 (encode_coding_gap): Remove; unused.
8328 * chartab.c (chartab_chars, chartab_bits): Now static.
8330 * charset.h (charset_iso_8859_1): Remove decl.
8331 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8334 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8335 * ccl.c (Vccl_program_table): Now static.
8336 (check_ccl_update): Remove; unused.
8338 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8339 * category.h: ... from here.
8340 * category.c (check_category_table, set_category_set): Now static.
8342 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8343 * lisp.h: Remove these decls.
8345 * buffer.c (buffer_count): Remove unused var.
8347 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8348 so that it's not optimized away.
8349 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8350 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8351 exported only to the debugger.
8353 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8354 * atimer.h (run_all_atimers): Remove; not exported.
8356 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8357 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8358 was inaccessible from Lisp.
8359 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8360 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8362 alloc.c: Import and export fewer symbols, and remove unused items.
8363 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8365 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8366 it's not optimized away by whole-program optimization.
8367 (message_enable_multibyte, free_misc): Remove.
8368 (catchlist, handlerlist, mark_backtrace):
8369 Declare only if BYTE_MARK_STACK.
8370 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8371 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8372 (message_enable_multibyte): Remove decl.
8373 (free_misc, interval_free_list, float_block, float_block_index):
8374 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8375 (cons_free_list, last_marked_index):
8377 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8378 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8379 (mark_backtrace): Define only if BYTE_MARK_STACK.
8380 * xdisp.c (message_enable_multibyte): Now static.
8382 Declare Lisp_Object Q* variables to be 'static' if not exported.
8383 This makes it easier for human readers (and static analyzers)
8384 to see whether these variables are used from other modules.
8385 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8386 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8387 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8388 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8389 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8390 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8391 * xmenu.c, xselect.c:
8392 Declare Q* vars static if they are not used in other modules.
8393 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8394 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8395 Remove decls of unexported vars.
8396 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8398 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8400 Make Emacs functions such as Fatom 'static' by default.
8401 This makes it easier for human readers (and static analyzers)
8402 to see whether these functions can be called from other modules.
8403 DEFUN now defines a static function. To make the function external
8404 so that it can be used in other C modules, use the new macro DEFUE.
8405 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8406 (Finit_image_library):
8407 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8408 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8409 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8410 Remove decls, since these functions are now static.
8411 (Funintern, Fget_internal_run_time): New decls, since these functions
8412 were already external.
8414 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8415 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8416 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8417 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8418 * keyboard.c, keymap.c, lread.c:
8419 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8420 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8421 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8422 Mark functions with DEFUE instead of DEFUN,
8423 if they are used in other modules.
8424 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8425 decls for now-static functions.
8426 * buffer.h (Fdelete_overlay): Remove decl.
8427 * callproc.c (Fgetenv_internal): Mark as internal.
8428 * composite.c (Fremove_list_of_text_properties): Remove decl.
8429 (Fcomposition_get_gstring): New forward static decl.
8430 * composite.h (Fcomposite_get_gstring): Remove decl.
8431 * dired.c (Ffile_attributes): New forward static decl.
8432 * doc.c (Fdocumntation_property): New forward static decl.
8433 * eval.c (Ffetch_bytecode): New forward static decl.
8434 (Funintern): Remove extern decl; now in .h file where it belongs.
8435 * fileio.c (Fmake_symbolic_link): New forward static decl.
8436 * image.c (Finit_image_library): New forward static decl.
8437 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8438 * intervals.h (Fprevious_property_change):
8439 (Fremove_list_of_text_properties): Remove decls.
8440 * keyboard.c (Fthis_command_keys): Remove decl.
8441 (Fcommand_execute): New forward static decl.
8442 * keymap.c (Flookup_key): New forward static decl.
8443 (Fcopy_keymap): Now static.
8444 * keymap.h (Flookup_key): Remove decl.
8445 * process.c (Fget_process): New forward static decl.
8446 (Fprocess_datagram_address): Mark as internal.
8447 * syntax.c (Fsyntax_table_p): New forward static decl.
8448 (skip_chars): Remove duplicate decl.
8449 * textprop.c (Fprevious_property_change): New forward static decl.
8450 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8452 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8453 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8455 * editfns.c (Fformat): Remove unreachable code.
8457 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8459 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8462 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8464 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8465 when at ZV. (Bug#8487)
8467 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8469 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8471 * keyboard.c (parse_tool_bar_item): Likewise.
8472 * sound.c (sound_cleanup, alsa_close): Likewise.
8473 * termcap.c (tgetent): Likewise.
8474 * xfns.c (x_default_font_parameter): Likewise.
8475 * xsettings.c (read_and_apply_settings): Likewise.
8477 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8478 (overrun_check_free): Protoize.
8480 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8482 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8483 since callers should never pass a negative size.
8484 Change the signature to match that of plain 'read' and 'write'; see
8485 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8486 * lisp.h: Update prototypes of emacs_write and emacs_read.
8488 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8490 * xdisp.c (redisplay_window): Don't try to determine the character
8491 position of the scroll margin if the window start point w->startp
8492 is outside the buffer's accessible region. (Bug#8468)
8494 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8496 Fix write-region and its subroutines for buffers > 2GB.
8497 * fileio.c (a_write, e_write): Modify declaration of arguments and
8498 local variables to support buffers larger than 2GB.
8499 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8501 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8502 argument, local variables, and return value.
8504 * lisp.h: Update prototypes of emacs_write and emacs_read.
8506 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8508 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8510 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8512 Fix more problems found by GCC 4.6.0's static checks.
8514 * xdisp.c (vmessage): Use a better test for character truncation.
8516 * charset.c (load_charset_map): <, not <=, for optimization,
8517 and to avoid potential problems with integer overflow.
8518 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8519 * casetab.c (set_identity, shuffle): Likewise.
8520 * editfns.c (Fformat): Likewise.
8521 * syntax.c (skip_chars): Likewise.
8523 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8524 This also lets GCC 4.6.0 generate slightly better loop code.
8526 * callint.c (Fcall_interactively): <, not <=, for optimization.
8527 (Fcall_interactively): Count the number of arguments produced,
8528 not the number of arguments given. This is simpler and lets GCC
8529 4.6.0 generate slightly better code.
8531 * ftfont.c: Distingish more carefully between FcChar8 and char.
8532 The previous code passed unsigned char * to a functions like
8533 strlen and xstrcasecmp that expect char *, which does not
8534 conform to the C standard.
8535 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8536 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8537 char * when the C standard requires it.
8539 * keyboard.c (read_char): Remove unused var.
8541 * eval.c: Port to Windows vsnprintf (Bug#8435).
8543 (SIZE_MAX): Define if the headers do not.
8544 (verror): Do not give up if vsnprintf returns a negative count.
8545 Instead, grow the buffer. This ports to Windows vsnprintf, which
8546 does not conform to C99. Problem reported by Eli Zaretskii.
8547 Also, simplify the allocation scheme, by avoiding the need for
8548 calling realloc, and removing the ALLOCATED variable.
8550 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8552 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8553 But keep the doprint source code for now, as we might revamp it
8554 and use it again (Bug#8435).
8555 * lisp.h (doprnt): Remove.
8556 * Makefile.in (base_obj): Remove doprnt.o.
8557 * deps.mk (doprnt.o): Remove.
8559 error: Print 32- and 64-bit integers portably (Bug#8435).
8560 Without this change, on typical 64-bit hosts error ("...%d...", N)
8561 was used to print both 32- and 64-bit integers N, which relied on
8563 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8564 * lisp.h (error, verror): Mark as printf-like functions.
8565 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8566 Report overflow in size calculations when allocating printf buffer.
8567 Do not truncate output string at its first null byte.
8568 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8569 Truncate the output at a character boundary, since vsnprintf does not
8571 * charset.c (check_iso_charset_parameter): Convert internal
8572 character to string before calling 'error', since %c now has the
8574 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8575 overflow when computing char to be passed to 'error'. Do not
8576 pass Lisp_Object to 'error'; pass the integer instead.
8577 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8578 formatted with plain %d.
8580 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8582 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8584 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8586 * xterm.c (x_catch_errors): Remove duplicate declaration.
8588 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8590 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8592 2011-04-10 Jim Meyering <meyering@redhat.com>
8594 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8595 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8596 return ssize_t not "int", and use size_t as the buffer length.
8597 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8598 * gnutls.h: Update declarations.
8599 * process.c (read_process_output): Use ssize_t, to match.
8600 (send_process): Likewise.
8602 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8604 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8606 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8608 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8609 Use unsigned char, to match FcChar8 type definition.
8611 * xterm.c (handle_one_xevent):
8612 * xmenu.c (create_and_show_popup_menu):
8613 * xselect.c (x_decline_selection_request)
8614 (x_reply_selection_request): Avoid type-punned deref of X events.
8616 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8618 Fix some uses of `int' instead of EMACS_INT.
8619 * search.c (string_match_1, fast_string_match)
8620 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8621 (scan_buffer, find_next_newline_no_quit)
8622 (find_before_next_newline, search_command, Freplace_match)
8623 (Fmatch_data): Make some `int' variables be EMACS_INT.
8625 * xdisp.c (display_count_lines): 3rd argument and return value now
8626 EMACS_INT. All callers changed.
8627 (pint2hrstr): Last argument is now EMACS_INT.
8629 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8630 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8631 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8632 (decode_coding_utf_16, decode_coding_emacs_mule)
8633 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8634 (decode_coding_ccl, decode_coding_charset)
8635 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8636 (decode_coding_iso_2022, decode_coding_emacs_mule)
8637 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8638 <char_offset, last_offset>: Declare EMACS_INT.
8639 (encode_coding_utf_8, encode_coding_utf_16)
8640 (encode_coding_emacs_mule, encode_invocation_designation)
8641 (encode_designation_at_bol, encode_coding_iso_2022)
8642 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8643 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8645 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8646 (encode_invocation_designation): Last argument P_NCHARS is now
8648 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8649 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8651 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8654 * ccl.c (Fccl_execute_on_string): Declare some variables
8657 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8659 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8661 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8663 * process.c (Fformat_network_address): Doc fix.
8665 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8667 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8669 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8671 * keyboard.c (read_char): Call Lisp function help-form-show,
8672 instead of using internal_with_output_to_temp_buffer.
8673 (Qhelp_form_show): New var.
8674 (syms_of_keyboard): Use DEFSYM macro.
8676 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8678 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8680 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8682 * process.c (Flist_processes): Remove to Lisp.
8683 (list_processes_1): Delete.
8685 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8687 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8689 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8691 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8693 Fix more problems found by GCC 4.6.0's static checks.
8695 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8697 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8699 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8701 * xdisp.c (vmessage): Mark as a printf-like function.
8703 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8705 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8707 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8708 printf-like functions.
8709 (tiff_load): Add casts to remove these marks before passing them
8710 to system-supplied API.
8712 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8714 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8715 This avoids several warnings with gcc -Wstrict-overflow.
8716 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8717 directly, rather than having caller test rule sign. This avoids
8718 some unnecessary tests.
8719 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8720 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8721 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8723 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8724 (xfont_open): Avoid unnecessary tests.
8726 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8728 * composite.h, composite.c (composition_gstring_put_cache):
8729 Use EMACS_INT, not int, for length.
8731 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8732 breaking out part of COMPOSITION_DECODE_RULE.
8733 (COMPOSITION_DECODE_RULE): Use it.
8734 * composite.c (get_composition_id): Remove unused local vars,
8735 by using the new macro.
8737 * textprop.c (set_text_properties_1): Change while to do-while,
8738 since the condition is always true at first.
8740 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8741 (interval_deletion_adjustment): Return unsigned value.
8744 * process.c (list_processes_1, create_pty, read_process_output):
8745 (exec_sentinel): Remove vars that were set but not used.
8746 (create_pty): Remove unnecessary "volatile"s.
8747 (Fnetwork_interface_info): Avoid possibility of int overflow.
8748 (read_process_output): Do adaptive read buffering even if carryover.
8749 (read_process_output): Simplify nbytes computation if buffered.
8751 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8753 * syntax.c (scan_words): Remove var that was set but not used.
8754 (update_syntax_table): Use unsigned instead of int.
8756 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8757 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8758 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8760 * print.c (print_error_message): Avoid int overflow.
8762 * font.c (font_list_entities): Redo for clarity,
8763 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8765 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8766 (font_score): Avoid potential overflow in diff calculation.
8768 * fns.c (substring_both): Remove var that is set but not used.
8769 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8771 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8773 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8774 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8775 can always succeed if overflow has undefined behavior.
8777 * search.c (boyer_moore, wordify): Remove vars set but not used.
8778 (wordify): Omit three unnecessary tests.
8780 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8781 All callers changed. This avoids the need for an unused var.
8783 * casefiddle.c (casify_region): Remove var that is set but not used.
8785 * dired.c (file_name_completion): Remove var that is set but not used.
8787 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8789 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8790 (Finsert_file_contents): Remove unnecessary code checking fd.
8792 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8793 Check for integer overflow on size calculations.
8795 * buffer.c (Fprevious_overlay_change): Remove var that is set
8798 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8799 Remove vars that are set but not used.
8800 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8801 (timer_check_2): Mark vars as initialized.
8803 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8805 * image.c (lookup_image): Remove var that is set but not used.
8806 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8808 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8809 that are set but not used.
8811 * xfns.c (make_invisible_cursor): Don't return garbage
8812 if XCreateBitmapFromData fails (Bug#8410).
8814 * xselect.c (x_get_local_selection, x_handle_property_notify):
8815 Remove vars that are set but not used.
8817 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8818 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8820 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8821 Remove var that is set but not used.
8822 (scroll_bar_windows_size): Now size_t, not int.
8823 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8826 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8827 (map_tty_color) [!defined MSDOS]: Likewise.
8829 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8831 * coding.c: Remove vars that are set but not used.
8832 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8833 All callers changed.
8834 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8835 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8836 (decode_coding_charset): Remove vars that are set but not used.
8838 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8839 that is set but not used.
8841 * print.c (print_object): Remove var that is set but not used.
8843 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8844 The gnulib version avoids calling malloc in the usual case,
8845 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8846 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8847 * filelock.c (current_lock_owner): Likewise.
8848 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8849 * sysdep.c: Include allocator.h, careadlinkat.h.
8850 (emacs_no_realloc_allocator): New static constant.
8851 (emacs_readlink): New function.
8852 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8853 ../lib/careadlinkat.h.
8855 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8857 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8858 first non-nil return value).
8860 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8862 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8863 if not defined (Bug#8403).
8865 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8867 * xdisp.c (display_count_lines): Remove parameter `start',
8868 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8869 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8870 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8871 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8872 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8873 and thereabouts. All callers changed.
8874 (get_per_char_metric): Remove parameter `f', unused since
8875 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8877 2011-04-02 Jim Meyering <meyering@redhat.com>
8879 do not dereference NULL upon failed strdup
8880 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8881 (ns_get_family): Likewise.
8883 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8885 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8887 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8889 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8892 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8894 Add lexical binding.
8896 * window.c (Ftemp_output_buffer_show): New fun.
8897 (Fsave_window_excursion):
8898 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8900 * lread.c (lisp_file_lexically_bound_p): New function.
8901 (Fload): Bind Qlexical_binding.
8902 (readevalloop): Remove `evalfun' arg.
8903 Bind Qinternal_interpreter_environment.
8904 (Feval_buffer): Bind Qlexical_binding.
8905 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8907 (syms_of_lread): Declare `lexical-binding'.
8909 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8911 * keyboard.c (eval_dyn): New fun.
8912 (menu_item_eval_property): Use it.
8914 * image.c (parse_image_spec): Use Ffunctionp.
8916 * fns.c (concat, mapcar1): Accept byte-code-functions.
8918 * eval.c (Fsetq): Handle lexical vars.
8919 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8920 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8921 (FletX, Flet): Obey lexical binding.
8922 (Fcommandp): Handle closures.
8923 (Feval): New `lexical' arg.
8924 (eval_sub): New function extracted from Feval. Use it almost
8925 everywhere where Feval was used. Look up vars in lexical env.
8927 (Ffunctionp): Move from subr.el.
8928 (Ffuncall): Handle closures.
8929 (apply_lambda): Remove `eval_flags'.
8930 (funcall_lambda): Handle closures and new byte-code-functions.
8931 (Fspecial_variable_p): New function.
8932 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8933 but without exporting it to Lisp.
8935 * doc.c (Fdocumentation, store_function_docstring):
8936 * data.c (Finteractive_form): Handle closures.
8938 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8941 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8943 (exec_byte_code): New function extracted from Fbyte_code to handle new
8944 calling convention for byte-code-functions. Add new byte-codes.
8946 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8948 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8950 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8952 * xdisp.c (redisplay_internal): Fix prototype.
8954 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8956 * xdisp.c (SCROLL_LIMIT): New macro.
8957 (try_scrolling): Use it when setting scroll_limit.
8958 Limit scrolling to 100 screen lines.
8959 (redisplay_window): Even when falling back on "recentering",
8960 position point in the window according to scroll-conservatively,
8961 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8963 (try_scrolling): When point is above the window, allow searching
8964 as far as scroll_max, or one screenful, to compute vertical
8965 distance from PT to the scroll margin position. This prevents
8966 try_scrolling from unnecessarily failing when
8967 scroll-conservatively is set to a value slightly larger than the
8968 window height. Clean up the case of PT below the margin at bottom
8969 of window: scroll_max can no longer be INT_MAX. When aggressive
8970 scrolling is in use, don't let point enter the opposite scroll
8971 margin as result of the scroll.
8972 (syms_of_xdisp) <scroll-conservatively>: Document the
8973 threshold of 100 lines for never-recentering scrolling.
8975 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8977 * dispextern.h (move_it_by_lines):
8978 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8979 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8980 (message_log_check_duplicate): Remove parameters `prev_bol' and
8981 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8982 (redisplay_internal): Remove parameter `preserve_echo_area',
8983 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8985 * indent.c (Fvertical_motion):
8986 * window.c (window_scroll_pixel_based, Frecenter):
8987 Don't pass `need_y_p' to `move_it_by_lines'.
8989 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8991 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8992 steal a few bits to be more compact.
8993 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8994 Remove unneeded casts.
8996 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8998 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9000 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9001 binding" message (bug#7967).
9003 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9005 Fix more problems found by GCC 4.6.0's static checks.
9007 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9008 Remove unused local var.
9010 * editfns.c (Fmessage_box): Remove unused local var.
9012 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9013 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9014 Omit unused local vars.
9015 * window.c (shrink_windows): Omit unused local var.
9016 * menu.c (digest_single_submenu): Omit unused local var.
9017 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9018 Omit unused local var.
9020 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9021 Don't assume string length fits in int.
9022 (keyremap_step, read_key_sequence): Use size_t for sizes.
9023 (read_key_sequence): Don't check last_real_key_start redundantly.
9025 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9026 instead of alloca (Bug#8344).
9028 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9029 (Fbacktrace_frame): Don't assume nframes fits in int.
9031 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9033 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9036 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9038 * cm.c (calccost): Turn while-do into do-while, for clarity.
9040 * keyboard.c (syms_of_keyboard): Use the same style as later
9041 in this function when indexing through an array. This also
9042 works around GCC bug 48267.
9044 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9046 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9048 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9049 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9051 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9052 This avoids undefined behavior on integer overflow, and is a bit
9053 more convenient anyway since it is compared to a size_t variable.
9055 Variadic C functions now count arguments with size_t, not int.
9056 This avoids an unnecessary limitation on 64-bit machines, which
9057 caused (substring ...) to crash on large vectors (Bug#8344).
9058 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9059 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9060 All variadic functions and their callers changed accordingly.
9061 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9062 * data.c (arith_driver, float_arith_driver): Likewise.
9063 * editfns.c (general_insert_function): Likewise.
9064 * eval.c (struct backtrace.nargs, interactive_p)
9065 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9066 (funcall_lambda, mark_backtrace): Likewise.
9067 * fns.c (concat): Likewise.
9068 * frame.c (x_set_frame_parameters): Likewise.
9069 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9070 0 if not found, not -1. All callers changed.
9072 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9073 (stack_copy_size): Now size_t, not int.
9074 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9076 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9078 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9079 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9080 All callers changed.
9082 * lisp.h (multibyte_char_to_unibyte):
9083 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9084 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9085 * character.h (CHAR_TO_BYTE8):
9086 * cmds.c (internal_self_insert):
9087 * editfns.c (general_insert_function):
9088 * keymap.c (push_key_description):
9089 * search.c (Freplace_match):
9090 * xdisp.c (message_dolog, set_message_1): All callers changed.
9092 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9094 * keyboard.c (safe_run_hook_funcall): New function.
9095 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9096 don't set the hook to nil, but remove the offending function instead.
9097 (Qcommand_hook_internal): Remove, unused.
9098 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9099 Vcommand_hook_internal.
9101 * eval.c (enum run_hooks_condition): Remove.
9102 (funcall_nil, funcall_not): New functions.
9103 (run_hook_with_args): Call each function through a `funcall' argument.
9104 Remove `cond' argument, now redundant.
9105 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9106 (Frun_hook_with_args_until_failure): Adjust accordingly.
9107 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9109 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9111 * dispextern.h (string_buffer_position): Remove declaration.
9113 * print.c (strout): Remove parameter `multibyte', unused since
9114 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9116 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9117 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9118 All callers changed.
9120 * w32.c (_wsa_errlist): Use braces for struct initializers.
9122 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9123 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9124 All callers changed.
9125 (string_buffer_position): Likewise. Also, make static (it's never
9126 used outside xdisp.c).
9127 (cursor_row_p): Remove parameter `w', unused since
9128 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9129 (decode_mode_spec): Remove parameter `precision', introduced during
9130 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9131 All callers changed.
9133 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9135 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9137 2011-03-27 Anders Lindgren <andlind@gmail.com>
9139 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9140 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9141 (ns_update_auto_hide_menu_bar): New functions.
9142 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9143 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9144 ns_constrain_all_frames.
9145 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9146 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9148 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9150 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9152 2011-03-27 Glenn Morris <rgm@gnu.org>
9154 * syssignal.h: Replace RETSIGTYPE with void.
9155 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9156 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9157 Replace SIGTYPE with void everywhere.
9158 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9159 * s/template.h (SIGTYPE): Remove commented out definition.
9161 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9163 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9164 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9166 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9168 * w32.c (read_unc_volume): Use parameter `henum', instead of
9169 global variable `wget_enum_handle'.
9171 * keymap.c (describe_vector): Remove parameters `indices' and
9172 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9173 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9175 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9177 * keyboard.c (timer_check): Remove parameter `do_it_now',
9178 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9179 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9180 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9182 * keyboard.c (read_char):
9183 * w32menu.c (w32_menu_display_help):
9184 * xmenu.c (show_help_event, menu_help_callback):
9185 Adjust calls to `show_help_echo'.
9187 * gtkutil.c (xg_maybe_add_timer):
9188 * keyboard.c (readable_events):
9189 * process.c (wait_reading_process_output):
9190 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9192 * insdel.c (adjust_markers_gap_motion):
9193 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9194 (gap_left, gap_right): Don't call it.
9196 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9198 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9199 incurred during fontification.
9201 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9203 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9204 (DEFVAR_PER_BUFFER): Don't pass it.
9206 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9207 (scrolling_window): Don't pass it.
9209 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9211 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9213 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9215 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9216 of variables specific to SELinux and computation of `encoded_absname'.
9218 * image.c (XPutPixel): Remove unused variable `height'.
9220 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9222 * unexw32.c (get_section_info): Remove unused variable `section'.
9224 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9225 (system_process_attributes): Remove unused variable `sess'.
9226 (sys_read): Remove unused variable `err'.
9228 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9229 (w32_wnd_proc): Remove unused variable `isdead'.
9230 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9231 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9232 (x_create_tip_frame): Remove unused variable `tem'.
9234 * w32inevt.c (w32_console_read_socket):
9235 Remove unused variable `no_events'.
9237 * w32term.c (x_draw_composite_glyph_string_foreground):
9238 Remove unused variable `width'.
9240 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9242 * w32term.c (x_set_glyph_string_clipping):
9243 Don't pass uninitialized region to CombineRgn.
9245 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9247 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9248 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9249 (Fx_close_connection): Remove unused variable `i'.
9251 * w32font.c (w32font_draw): Return number of glyphs.
9252 (w32font_open_internal): Remove unused variable `i'.
9253 (w32font_driver): Add missing initializer.
9255 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9256 (fill_in_menu): Remove unused variable `items_added'.
9258 * w32term.c (last_mouse_press_frame): Remove static global variable.
9259 (w32_clip_to_row): Remove unused variable `f'.
9260 (x_delete_terminal): Remove unused variable `i'.
9262 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9263 (NOTHING): Remove unused static global variable.
9264 (uniscribe_check_otf): Remove unused variable `table'.
9265 (uniscribe_font_driver): Add missing initializers.
9267 2011-03-23 Julien Danjou <julien@danjou.info>
9269 * term.c (Fsuspend_tty, Fresume_tty):
9270 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9271 * window.c (temp_output_buffer_show):
9272 * insdel.c (signal_before_change):
9273 * frame.c (Fhandle_switch_frame):
9274 * fileio.c (Fdo_auto_save):
9275 * emacs.c (Fkill_emacs):
9276 * editfns.c (save_excursion_restore):
9277 * cmds.c (internal_self_insert):
9278 * callint.c (Fcall_interactively):
9279 * buffer.c (Fkill_all_local_variables):
9280 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9282 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9283 unconditionally since it does the check itself.
9285 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9287 Fix more problems found by GCC 4.5.2's static checks.
9289 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9290 the first time through the loop, since we know p0 < p1 then.
9291 This also avoids a gcc -Wstrict-overflow warning.
9293 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9294 leading to a memory leak, possible in functions like
9295 load_charset_map_from_file that can allocate an unbounded number
9296 of objects (Bug#8318).
9298 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9299 that could (at least in theory) be that large.
9301 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9302 This is less likely to overflow, and avoids undefined behavior if
9303 overflow does occur. All callers changed. Use strtoul to scan
9304 for the unsigned long integer.
9305 (pint2hrstr): Simplify and tune code slightly.
9306 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9308 * scroll.c (do_scrolling): Work around GCC bug 48228.
9309 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9311 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9312 This also avoids a warning with gcc -Wstrict-overflow.
9313 (validate_x_resource_name): Simplify count usage.
9314 This also avoids a warning with gcc -Wstrict-overflow.
9316 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9319 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9321 * process.c (Fmake_network_process): Use socklen_t, not int,
9322 where POSIX says socklen_t is required in portable programs.
9323 This fixes a porting bug on hosts like 64-bit HP-UX, where
9324 socklen_t is wider than int (Bug#8277).
9325 (Fmake_network_process, server_accept_connection):
9326 (wait_reading_process_output, read_process_output):
9329 * process.c: Rename or move locals to avoid shadowing.
9330 (list_processes_1, Fmake_network_process):
9331 (read_process_output_error_handler, exec_sentinel_error_handler):
9332 Rename or move locals.
9333 (Fmake_network_process): Define label "retry_connect" only if needed.
9334 (Fnetwork_interface_info): Fix pointer signedness.
9335 (process_send_signal): Add cast to avoid pointer signedness problem.
9336 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9337 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9339 Make tparam.h and terminfo.c consistent.
9340 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9341 Include tparam.h instead, since it declares them.
9342 * cm.h (PC): Remove extern decl; tparam.h now does this.
9343 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9344 * terminfo.c: Include tparam.h, to check interfaces.
9345 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9346 (tparam): Adjust signature to match interface in tparam.h;
9347 this removes some undefined behavior. Check that outstring and len
9348 are zero, which they always are with Emacs.
9349 * tparam.h (PC, BC, UP): New extern decls.
9351 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9352 (xftfont_open): Rename locals to avoid shadowing.
9354 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9355 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9356 (OTF_TAG_SYM): Omit macro if not needed.
9357 (ftfont_list): Remove unused local.
9358 (get_adstyle_property, ftfont_pattern_entity):
9359 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9360 Rename locals to avoid shadowing.
9362 * xfont.c (xfont_list_family): Mark var as initialized.
9364 * xml.c (make_dom): Now static.
9366 * composite.c (composition_compute_stop_pos): Rename local to
9368 (composition_reseat_it): Remove unused locals.
9369 (find_automatic_composition, composition_adjust_point): Likewise.
9370 (composition_update_it): Mark var as initialized.
9371 (find_automatic_composition): Mark vars as initialized,
9372 with a FIXME (Bug#8290).
9374 character.h: Rename locals to avoid shadowing.
9375 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9376 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9377 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9378 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9381 * textprop.c (property_change_between_p): Remove; unused.
9383 * intervals.c (interval_start_pos): Now static.
9385 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9387 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9388 Rename locals to avoid shadowing.
9390 * sound.c (wav_play, au_play, Fplay_sound_internal):
9391 Fix pointer signedness.
9392 (alsa_choose_format): Remove unused local var.
9393 (wav_play): Initialize a variable to 0, to prevent undefined
9394 behavior (Bug#8278).
9396 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9398 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9400 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9401 clobbering (Bug#8298).
9402 * sysdep.c (sys_subshell): Likewise.
9403 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9405 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9406 This should get cleaned up, so that child_setup has the
9407 same signature on all platforms.
9409 * callproc.c (call_process_cleanup): Now static.
9410 (relocate_fd): Rename locals to avoid shadowing.
9412 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9414 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9415 not to be necessary, and produces flickering.
9417 2011-03-20 Glenn Morris <rgm@gnu.org>
9419 * config.in: Remove file.
9421 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9423 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9424 are now in src/globals.h.
9425 (syms_of_minibuf): Remove spurious & from previous change.
9427 2011-03-20 Leo Liu <sdl.web@gmail.com>
9429 * minibuf.c (completing-read-function): New variable.
9430 (completing-read-default): Rename from completing-read.
9431 (completing-read): Call completing-read-function.
9433 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9435 * xfaces.c (Fx_load_color_file):
9436 Read color file from absolute filename (bug#8250).
9438 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9440 * makefile.w32-in: Update dependencies.
9442 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9444 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9446 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9448 Fix more problems found by GCC 4.5.2's static checks.
9450 * process.c (make_serial_process_unwind, send_process_trap):
9451 (sigchld_handler): Now static.
9453 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9454 That way, the code declares only the vars that it needs.
9455 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9456 * s/cygwin.h (PTY_ITERATION): Likewise.
9457 * s/darwin.h (PTY_ITERATION): Likewise.
9458 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9460 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9461 * process.c (allocate_pty): Don't declare stb unless it's needed.
9463 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9464 (CONSTANTLIM): Remove; unused.
9465 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9466 Define only if needed.
9468 * unexelf.c (unexec): Name an expression,
9469 to avoid gcc -Wbad-function-cast warning.
9470 Use a different way to cause a compilation error if anyone uses
9471 n rather than nn, a way that does not involve shadowing.
9472 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9474 * deps.mk (unexalpha.o): Remove; unused.
9476 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9477 * unexec.h: New file.
9478 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9479 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9481 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9482 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9483 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9484 Change as necessary to match prototype in unexec.h.
9486 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9488 (back_comment, skip_chars): Mark vars as initialized.
9490 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9491 Rename locals to avoid shadowing.
9493 * lread.c (read1): Rewrite so as not to use empty "else".
9494 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9496 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9498 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9499 warning when compiling print.c.
9501 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9502 instead of using an uninitialized var.
9503 (font_sort_entities): Mark var as initialized.
9505 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9507 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9508 pointers to constants.
9509 (font_parse_fcname): Remove unused vars.
9510 (font_delete_unmatched): Now static.
9511 (font_get_spec): Remove; unused.
9512 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9513 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9514 Rename or move locals to avoid shadowing.
9516 * fns.c (require_nesting_list, require_unwind): Now static.
9517 (Ffillarray): Rename locals to avoid shadowing.
9519 * floatfns.c (domain_error2): Define only if needed.
9520 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9522 * alloc.c (mark_backtrace): Move decl from here ...
9523 * lisp.h: ... to here, so that it can be checked.
9525 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9526 (Fdefvar): Rewrite so as not to use empty "else".
9527 (lisp_indirect_variable): Name an expression,
9528 to avoid gcc -Wbad-function-cast warning.
9529 (Fdefvar): Rename locals to avoid shadowing.
9531 * callint.c (quotify_arg, quotify_args): Now static.
9532 (Fcall_interactively): Rename locals to avoid shadowing.
9533 Use const pointer when appropriate.
9535 * lisp.h (get_system_name, get_operating_system_release):
9536 Move decls here, to check interfaces.
9537 * process.c (get_operating_system_release): Move decl to lisp.h.
9538 * xrdb.c (get_system_name): Likewise.
9539 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9540 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9541 some of which prompt warnings from gcc -Wbad-function-cast.
9542 (Fformat_time_string, Fencode_time, Finsert_char):
9543 (Ftranslate_region_internal, Fformat):
9544 Rename or remove local vars to avoid shadowing.
9545 (Ftranslate_region_internal): Mark var as initialized.
9547 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9550 * lisp.h (eassert): Check that the argument compiles, even if
9551 ENABLE_CHECKING is not defined.
9553 * data.c (Findirect_variable): Name an expression, to avoid
9554 gcc -Wbad-function-cast warning.
9555 (default_value, arithcompare, arith_driver, arith_error): Now static.
9556 (store_symval_forwarding): Rename local to avoid shadowing.
9557 (Fmake_variable_buffer_local, Fmake_local_variable):
9558 Mark variables as initialized.
9559 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9561 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9562 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9563 Rename locals to avoid shadowing.
9564 (mark_stack): Move local variables into the #ifdef region where
9566 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9567 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9569 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9570 (GC_STRING_CHARS): Remove; not used.
9571 (Fmemory_limit): Cast sbrk's returned value to char *.
9573 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9574 avoids undefined behavior in theory.
9576 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9578 Use functions, not macros, for up- and down-casing (Bug#8254).
9579 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9580 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9581 to use the following functions instead of these macros.
9582 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9583 EMACS_INT, since callers assume the returned value fits in int.
9584 (upcase1): Likewise, for UPCASE_TABLE.
9585 (uppercasep, lowercasep, upcase): New static inline functions.
9586 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9587 the race-condition problem in the old DOWNCASE.
9589 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9590 Rename locals to avoid shadowing.
9591 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9592 (regex_compile, re_search_2, re_match_2_internal):
9593 Remove unused local vars.
9594 (FREE_VAR): Rewrite so as not to use empty "else",
9595 which gcc can warn about.
9596 (regex_compile, re_match_2_internal): Mark locals as initialized.
9597 (RETALLOC_IF): Define only if needed.
9598 (WORDCHAR_P): Likewise. This one is never needed, but is used
9599 only in a comment talking about a compiler bug, so put inside
9600 the #if 0 of that comment.
9601 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9602 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9605 * search.c (boyer_moore): Rename locals to avoid shadowing.
9606 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9607 (PREV_CHAR_BOUNDARY): Likewise.
9609 * search.c (simple_search): Remove unused var.
9611 * dired.c (compile_pattern): Move decl from here ...
9612 * lisp.h: ... to here, so that it can be checked.
9613 (struct re_registers): New forward decl.
9615 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9617 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9619 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9620 Rename locals to avoid shadowing.
9621 (Fvertical_motion): Mark locals as initialized.
9623 * casefiddle.c (casify_object, casify_region): Now static.
9624 (casify_region): Mark local as initialized.
9626 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9628 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9629 New macros, so that the caller can use some names other than
9630 gcpro1, gcpro2, etc.
9631 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9633 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9634 argument, for consistency with GCPRO2_VAR, etc: it is now the
9635 prefix of the variable, not the variable itself. All uses
9637 * dired.c (directory_files_internal, file_name_completion):
9638 Rename locals to avoid shadowing.
9640 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9641 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9642 dired.c's scmp function, had undefined behavior.
9643 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9644 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9645 * buffer.h: ... to here, because these macros use current_buffer,
9646 and the new implementation with inline functions needs to have
9647 current_buffer in scope now, rather than later when the macros
9649 (downcase, upcase1): New static inline functions.
9650 (DOWNCASE, UPCASE1): Reimplement using these functions.
9651 This avoids undefined behavior in expressions like
9652 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9653 from race conditions in accessing the global variables
9654 case_temp1 and case_temp2.
9655 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9656 * lisp.h (case_temp1, case_temp2): Remove their decls.
9657 * character.h (ASCII_CHAR_P): Move from here ...
9658 * lisp.h: ... to here, so that the inline functions mentioned
9661 * dired.c (directory_files_internal_unwind): Now static.
9663 * fileio.c (file_name_as_directory, directory_file_name):
9664 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9666 (file_name_as_directory): Use const pointers when appropriate.
9667 (Fexpand_file_name): Likewise. In particular, newdir might
9668 point at constant storage, so make it a const pointer.
9669 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9670 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9672 (Fset_file_times, Finsert_file_contents, auto_save_error):
9673 Rename locals to avoid shadowing.
9675 * minibuf.c (choose_minibuf_frame_1): Now static.
9676 (Ftry_completion, Fall_completions): Rename or remove locals
9679 * marker.c (bytepos_to_charpos): Remove; unused.
9681 * lisp.h (verify_bytepos, count_markers): New decls,
9682 so that gcc does not warn that these functions aren't declared.
9684 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9685 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9686 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9687 (copy_text): Remove unused local var.
9689 * filelock.c (within_one_second): Now static.
9690 (lock_file_1): Rename local to avoid shadowing.
9692 * buffer.c (fix_overlays_before): Mark locals as initialized.
9693 (fix_start_end_in_overlays): Likewise. This function should be
9694 simplified by using pointers-to-pointers, but that's a different
9696 (switch_to_buffer_1): Now static.
9697 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9698 (report_overlay_modification): Rename locals to avoid shadowing.
9700 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9701 Fix pointer signedness issue.
9702 (sys_subshell): Mark local as volatile if checking for lint,
9703 to suppress a gcc -Wclobbered warning that does not seem to be right.
9704 (MAXPATHLEN): Define only if needed.
9706 * process.c (serial_open, serial_configure): Move decls from here ...
9707 * systty.h: ... to here, so that they can be checked.
9709 * fns.c (get_random, seed_random): Move extern decls from here ...
9710 * lisp.h: ... to here, so that they can be checked.
9712 * sysdep.c (reset_io): Now static.
9713 (wait_for_termination_signal): Remove; unused.
9715 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9716 (copy_keymap_item, append_key, push_text_char_description):
9718 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9719 (DENSE_TABLE_SIZE): Remove; unused.
9720 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9721 (describe_map_tree):
9722 Rename locals to avoid shadowing.
9724 * keyboard.c: Declare functions static if they are not used elsewhere.
9725 (echo_char, echo_dash, cmd_error, top_level_2):
9726 (poll_for_input, handle_async_input): Now static.
9727 (read_char, kbd_buffer_get_event, make_lispy_position):
9728 (make_lispy_event, make_lispy_movement, apply_modifiers):
9729 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9730 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9731 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9732 (read_key_sequence, read_char): Mark locals as initialized.
9733 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9735 * keyboard.h (make_ctrl_char): New decl.
9736 (mark_kboards): Move decl here ...
9737 * alloc.c (mark_kboards): ... from here.
9739 * lisp.h (force_auto_save_soon): New decl.
9741 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9742 (DEFINE_DUMMY_FUNCTION): New macro.
9743 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9745 (main): Add casts to avoid warnings
9746 if GCC considers string literals to be constants.
9748 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9750 * dbusbind.c: Pointer signedness fixes.
9751 (xd_signature, xd_append_arg, xd_initialize):
9752 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9753 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9754 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9755 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9757 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9758 if GCC considers string literals to be constants.
9759 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9761 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9763 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9764 (print_preprocess, print_object): New macro to fix last change.
9766 * print.c (print_preprocess): Don't forget font objects.
9768 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9770 * emacs.c (USAGE3): Doc fixes.
9772 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9774 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9777 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9779 * lisp.h (VWindow_system, Qfile_name_history):
9780 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9781 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9782 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9784 * w32select.c: Don't #include "keyboard.h".
9785 (run_protected): Add extern declaration for waiting_for_input.
9787 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9788 * w32console.c (detect_input_pending, read_input_pending)
9789 (encode_terminal_code):
9790 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9791 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9792 (w32_system_caret_y, Qfile_name_history):
9793 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9794 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9795 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9796 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9797 * w32proc.c (Qlocal, report_file_error):
9798 * w32term.c (Vwindow_system, updating_frame):
9799 * w32uniscribe.c (initialized, uniscribe_font_driver):
9800 Remove unneeded extern declarations.
9802 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9804 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9806 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9808 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9809 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9810 These macros can no longer be used for assignment.
9812 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9813 Assign struct members directly, instead of using BUF_BEGV etc.
9814 (record_buffer_markers, fetch_buffer_markers): New functions for
9815 recording and fetching special buffer markers.
9816 (set_buffer_internal_1, set_buffer_temp): Use them.
9818 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9820 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9822 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9823 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9825 * xdisp.c (hscroll_window_tree):
9826 (reconsider_clip_changes): Use PT instead of BUF_PT.
9828 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9830 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9831 $(EMACS_ROOT)/lib/intprops.h.
9833 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9835 Fix more problems found by GCC 4.5.2's static checks.
9837 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9838 to unsigned char * to avoid compiler diagnostic.
9839 (xg_free_frame_widgets): Make it clear that a local variable is
9840 needed only if USE_GTK_TOOLTIP.
9841 (gdk_window_get_screen): Make it clear that this macro is needed
9842 only if USE_GTK_TOOLTIP.
9843 (int_gtk_range_get_value): New function, which avoids a diagnostic
9844 from gcc -Wbad-function-cast.
9845 (xg_set_toolkit_scroll_bar_thumb): Use it.
9846 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9847 diagnostic from gcc -Wbad-function-cast.
9848 (get_utf8_string, xg_get_file_with_chooser):
9849 Rename locals to avoid shadowing.
9850 (create_dialog): Move locals to avoid shadowing.
9852 * xgselect.c (xg_select): Remove unused var.
9854 * image.c (four_corners_best): Mark locals as initialized.
9855 (gif_load): Initialize transparent_p to zero (Bug#8238).
9856 Mark another local as initialized.
9857 (my_png_error, my_error_exit): Mark with NO_RETURN.
9859 * image.c (clear_image_cache): Now static.
9860 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9861 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9862 (x_edge_detection): Remove unnecessary cast that
9863 gcc -Wbad-function-cast diagnoses.
9864 (gif_load): Fix pointer signedness.
9865 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9866 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9868 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9870 Improve quality of tests for time stamp overflow.
9871 For example, without this patch (encode-time 0 0 0 1 1
9872 1152921504606846976) returns the obviously-bogus value (-948597
9873 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9874 reports time overflow. See
9875 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9876 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9877 * editfns.c: Include limits.h and intprops.h.
9878 (TIME_T_MIN, TIME_T_MAX): New macros.
9879 (time_overflow): Move earlier, to before first use.
9880 (hi_time, lo_time): New functions, for an accurate test for
9882 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9883 (Fget_internal_run_time): Don't assume time_t fits in int.
9884 (make_time): Use list2 instead of Fcons twice.
9885 (Fdecode_time): More accurate test for out-of-range times.
9886 (check_tm_member): New function.
9887 (Fencode_time): Use it, to test for out-of-range times.
9888 (lisp_time_argument): Don't rely on undefined left-shift and
9889 right-shift behavior when checking for time stamp overflow.
9891 * editfns.c (time_overflow): New function, refactoring common code.
9892 (Fformat_time_string, Fdecode_time, Fencode_time):
9893 (Fcurrent_time_string): Use it.
9895 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9896 * dired.c (make_time): Move to ...
9897 * editfns.c (make_time): ... here.
9898 * systime.h: Note the move.
9900 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9902 * fringe.c (update_window_fringes): Remove unused variables.
9904 * unexmacosx.c (copy_data_segment): Also copy __got section.
9907 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9909 * termcap.c [MSDOS]: Include "msdos.h".
9910 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9911 Constify `char *' arguments and their references according to
9912 prototypes in tparam.h.
9914 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9916 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9917 Adapt all references accordingly.
9919 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9921 2011-03-11 Tom Tromey <tromey@redhat.com>
9923 * buffer.c (syms_of_buffer): Remove obsolete comment.
9925 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9927 * termhooks.h (encode_terminal_code): Declare prototype.
9929 * msdos.c (encode_terminal_code): Don't declare prototype.
9931 * term.c (encode_terminal_code): Now external again, used by
9932 w32console.c and msdos.c.
9934 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9935 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9937 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9939 Fix some minor problems found by GCC 4.5.2's static checks.
9941 * fringe.c (update_window_fringes): Mark locals as initialized
9943 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9945 * alloc.c (mark_fringe_data): Move decl from here ...
9946 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9947 to check its interface.
9948 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9950 * fontset.c (free_realized_fontset): Now static.
9951 (Fset_fontset_font): Rename local to avoid shadowing.
9952 (fontset_font): Mark local as initialized.
9953 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9955 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9957 * xselect.c (x_disown_buffer_selections): Remove; not used.
9958 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9959 (x_own_selection, Fx_disown_selection_internal): Rename locals
9961 (x_handle_dnd_message): Remove local to avoid shadowing.
9963 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9964 so that the caller can use some name other than gcpro1.
9965 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9966 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9967 (Fx_backspace_delete_keys_p):
9968 Use them to avoid shadowing, and rename vars to avoid shadowing.
9969 (x_decode_color, x_set_name, x_window): Now static.
9970 (Fx_create_frame): Add braces to silence GCC warning.
9971 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9972 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9973 Remove unused locals.
9974 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9975 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9976 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9979 * xterm.h (x_mouse_leave): New decl.
9981 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9982 Remove unused functions.
9983 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9984 (x_calc_absolute_position): Now static.
9985 (XTread_socket): Don't define label "out" unless it's used.
9986 Don't declare local "event" unless it's used.
9987 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9988 unless they are used.
9989 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9990 (x_fatal_error_signal): Remove; not used.
9991 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9992 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9993 (x_error_catcher, x_connection_closed, x_error_handler):
9994 (x_error_quitter, xembed_send_message, x_iconify_frame):
9995 (my_log_handler): Rename locals to avoid shadowing.
9996 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9997 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9999 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10000 Rename or move locals to avoid shadowing.
10001 (tty_defined_color, merge_face_heights): Now static.
10002 (free_realized_faces_for_fontset): Remove; not used.
10003 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10004 does not deduce is never used uninitialized.
10005 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10006 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10008 * terminal.c (store_terminal_param): Now static.
10010 * xmenu.c (menu_highlight_callback): Now static.
10011 (set_frame_menubar): Remove unused local.
10012 (xmenu_show): Rename parameter to avoid shadowing.
10013 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10014 since they might point to immutable storage.
10015 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10016 since it's unused otherwise.
10018 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10019 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10020 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10021 avoids a gcc -Wuninitialized diagnostic.
10022 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10023 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10024 does not deduce are never used uninitialized.
10026 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10028 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10029 * window.c (window_loop, size_window):
10030 (run_window_configuration_change_hook, enlarge_window): Likewise.
10032 * window.c (display_buffer): Now static.
10033 (size_window): Mark variables that gcc -Wuninitialized
10034 does not deduce are never used uninitialized.
10035 * window.h (check_all_windows): New decl, to forestall
10036 gcc -Wmissing-prototypes diagnostic.
10037 * dispextern.h (bidi_dump_cached_states): Likewise.
10039 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10041 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10042 Include <limits.h>.
10043 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10044 and to avoid gcc -Wuninitialized warning.
10045 (load_charset_map): Mark variables that gcc -Wuninitialized
10046 does not deduce are never used uninitialized.
10047 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10049 * coding.c (coding_set_source, coding_set_destination):
10050 Use "else { /* comment */ }" rather than "else /* comment */;"
10051 for clarity, and to avoid gcc -Wempty-body warning.
10052 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10053 a block, when the outer 'i' will do.
10054 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10055 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10056 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10057 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10058 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10059 Rename locals to avoid shadowing.
10060 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10061 * coding.c (emacs_mule_char, encode_invocation_designation):
10062 Now static, since they're not used elsewhere.
10063 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10064 (decode_coding_object, encode_coding_object, detect_coding_system):
10065 (decode_coding_emacs_mule): Mark variables that gcc
10066 -Wuninitialized does not deduce are never used uninitialized.
10067 (detect_coding_iso_2022): Initialize a local variable that might
10068 be used uninitialized. Leave a FIXME because it's not clear that
10069 this initialization is needed. (Bug#8211)
10070 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10071 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10072 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10073 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10074 Remove unused macros.
10076 * category.c (hash_get_category_set): Remove unused local var.
10077 (copy_category_table): Now static, since it's not used elsewhere.
10078 * character.c (string_count_byte8): Likewise.
10080 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10081 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10083 * chartab.c (copy_sub_char_table): Now static, since it's not used
10085 (sub_char_table_ref_and_range, char_table_ref_and_range):
10086 Rename locals to avoid shadowing.
10087 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10089 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10090 (BIDI_BOB): Remove unused macro.
10092 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10093 deduce are never used uninitialized.
10094 * term.c (encode_terminal_code): Likewise.
10096 * term.c (encode_terminal_code): Now static. Remove unused local.
10098 * tparam.h: New file.
10099 * term.c, tparam.h: Include it.
10100 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10101 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10102 Move these decls to tparam.h, and make them agree with what
10103 is actually in tparam.c. The previous trick of using incompatible
10104 decls in different modules does not conform to the C standard.
10105 All callers of tparam changed to use tparam's actual API.
10106 * tparam.c (tparam1, tparam, tgoto):
10107 Use const pointers where appropriate.
10109 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10110 * cm.h (struct cm): Likewise.
10111 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10112 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10113 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10114 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10115 (turn_on_face, init_tty): Likewise.
10116 * termchar.h (struct tty_display_info): Likewise.
10118 * term.c (term_mouse_position): Rename local to avoid shadowing.
10120 * alloc.c (mark_ttys): Move decl from here ...
10121 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10123 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10125 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10127 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10129 * search.c (compile_pattern_1): Remove argument regp, unused since
10130 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10131 (compile_pattern): Don't pass it.
10133 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10135 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10136 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10138 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10140 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10142 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10143 gdk_window_get_screen, gdk_window_get_geometry,
10144 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10145 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10146 (xg_get_pixbuf_from_pixmap): New function.
10147 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10148 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10149 Call xg_get_pixbuf_from_pixmap instead of
10150 gdk_pixbuf_get_from_drawable.
10151 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10152 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10153 (xg_check_special_colors): Use GtkStyleContext and its functions
10155 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10156 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10157 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10158 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10159 Call gtk_widget_get_preferred_size.
10160 (xg_frame_resized): gdk_window_get_geometry only takes 5
10162 (xg_win_to_widget, xg_event_is_for_menubar):
10163 Call gdk_x11_window_lookup_for_display.
10164 (xg_set_widget_bg): New function.
10165 (delete_cb): New function.
10166 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10167 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10168 (xg_set_background_color): Call xg_set_widget_bg.
10169 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10170 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10171 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10172 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10174 (update_frame_tool_bar): Call gtk_widget_hide.
10175 (xg_initialize): Use GDK_KEY_g.
10177 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10179 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10181 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10182 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10183 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10185 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10187 * w32xfns.c (select_palette): Check success of RealizePalette against
10188 GDI_ERROR, not zero.
10190 See ChangeLog.11 for earlier changes.
10192 ;; Local Variables:
10196 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10198 This file is part of GNU Emacs.
10200 GNU Emacs is free software: you can redistribute it and/or modify
10201 it under the terms of the GNU General Public License as published by
10202 the Free Software Foundation, either version 3 of the License, or
10203 (at your option) any later version.
10205 GNU Emacs is distributed in the hope that it will be useful,
10206 but WITHOUT ANY WARRANTY; without even the implied warranty of
10207 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10208 GNU General Public License for more details.
10210 You should have received a copy of the GNU General Public License
10211 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.