1 2011-05-05 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5 * term.c (vfatal): Remove stray call to va_end.
6 It's not needed and the C Standard doesn't allow it here anyway.
8 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
16 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
18 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
20 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
22 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
24 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
25 * charset.c (Fdefine_charset_internal): Don't initialize
26 charset.code_space[15]. The value was garbage, on hosts with
27 32-bit int (Bug#8600).
29 * lread.c (read_integer): Be more consistent with string-to-number.
30 Use string_to_number to do the actual conversion; this avoids
31 rounding errors and fixes some other screwups. Without this fix,
32 for example, #x1fffffffffffffff was misread as -2305843009213693952.
33 (digit_to_number): Move earlier, for benefit of read_integer.
34 Return -1 if the digit is out of range for the base, -2 if it is
35 not a digit in any supported base. (Bug#8602)
37 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
39 * dispnew.c (scrolling_window): Return 1 if we scrolled,
40 to match comment at start of function. This also removes a
41 GCC warning about overflow in a 32+64-bit port.
43 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
45 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
46 Reported by Stefan Monnier in
47 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
48 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
49 SYMBOLP-guarded XSYMBOL, not XPNTR.
51 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
52 (EMACS_UINTPTR): Likewise, with uintptr_t.
54 * lisp.h: Prefer 64-bit EMACS_INT if available.
55 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
56 on 32-bit hosts that have 64-bit int, so that they can access
58 However, temporarily disable this change unless the temporary
59 symbol WIDE_EMACS_INT is defined.
61 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
63 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
64 This removes an assumption that EMACS_INT and long are the same
65 width as pointers. The assumption is true for Emacs porting targets
66 now, but we want to make other targets possible.
67 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
68 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
69 In the rest of the code, change types of integers that hold casted
70 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
71 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
72 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
73 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
74 No need to cast type when ORing.
75 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
76 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
77 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
78 assume EMACS_INT is the same width as char *.
79 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
80 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
81 Remove no-longer-needed casts.
82 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
83 (xg_tool_bar_help_callback, xg_make_tool_item):
84 Use EMACS_INTPTR to hold an integer
85 that will be cast to void *; this can avoid a GCC warning
86 if EMACS_INT is not the same width as void *.
87 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
88 * xdisp.c (display_echo_area_1, resize_mini_window_1):
89 (current_message_1, set_message_1):
90 Use a local to convert to proper width without a cast.
91 * xmenu.c (dialog_selection_callback): Likewise.
93 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
94 Also, don't assume VALBITS / RAND_BITS is less than 5,
95 and don't rely on undefined behavior when shifting a 1 left into
97 * lisp.h (get_random): Change signature to match.
99 * lread.c (hash_string): Use size_t, not int, for hash computation.
100 Normally we prefer signed values; but hashing is special, because
101 it's better to use unsigned division on hash table sizes so that
102 the remainder is nonnegative. Also, size_t is the natural width
103 for hashing into memory. The previous code used 'int', which doesn't
104 retain enough info to hash well into very large tables.
105 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
107 * dbusbind.c: Don't possibly lose pointer info when converting.
108 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
109 Use XPNTR rather than XHASH, so that the high-order bits of
110 the pointer aren't lost when converting through void *.
112 * eval.c (Fautoload): Don't double-shift a pointer.
114 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
116 2011-05-05 Eli Zaretskii <eliz@gnu.org>
118 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
119 New version that can reserve upto 2GB of heap space.
121 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
123 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
125 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
127 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
128 `gnutls_certificate_set_x509_key_file'.
130 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
132 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
135 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
137 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
138 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
139 Remove unused parameter `fildes'.
140 * process.c (read_process_output, send_process): Don't pass it.
142 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
144 Fix previous change: the library cache is defined in w32.c.
145 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
146 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
148 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
150 Implement dynamic loading of GnuTLS on Windows.
152 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
153 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
154 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
157 * gnutls.c (Qgnutls_dll): Define.
158 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
159 (gnutls_*): Declare function pointers.
160 (init_gnutls_functions): New function to initialize function pointers.
161 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
162 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
163 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
164 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
165 (emacs_gnutls_write, emacs_gnutls_read)
166 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
167 (Fgnutls_available_p): New function.
168 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
169 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
170 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
172 * image.c: Include w32.h.
173 (Vimage_type_cache): Delete.
174 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
175 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
176 (w32_delayed_load): Move to w32.c.
178 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
180 * w32.c (QCloaded_from, Vlibrary_cache): Define.
181 (w32_delayed_load): Move from image.c. When loading a library, record
182 its filename in the :loaded-from property of the library id.
183 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
184 Initialize and staticpro them.
185 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
187 * process.c: Include lisp.h before w32.h, not after.
188 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
189 instead of gnutls_record_check_pending.
191 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
193 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
195 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
196 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
199 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
201 * xterm.c (x_set_frame_alpha): Do not set property on anything
202 else than FRAME_X_OUTER_WINDOW (Bug#8608).
204 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
206 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
208 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
210 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
211 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
212 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
213 (gnutls_global_initialized, Qgnutls_bootprop_priority)
214 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
215 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
216 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
217 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
218 (Qgnutls_bootprop_callbacks_verify): Make static.
220 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
222 * callproc.c: Indentation fixup.
224 * sysdep.c (wait_for_termination_1): Make static.
225 (wait_for_termination, interruptible_wait_for_termination): Move
226 after wait_for_termination_1.
228 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
230 * sysdep.c (interruptible_wait_for_termination): New function
231 which is like wait_for_termination, but allows keyboard
234 * callproc.c (Fcall_process): Add (:file "file") as an option for
236 (Fcall_process_region): Ditto.
238 2011-04-30 Eli Zaretskii <eliz@gnu.org>
240 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
241 rather than `XVECTOR (FOO)->size'.
243 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
244 inttypes.h, as a gnulib replacement is used if it not available in
247 2011-04-21 Eli Zaretskii <eliz@gnu.org>
249 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
250 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
251 of MOST_POSITIVE_FIXNUM. (Bug#8528)
253 * coding.c (coding_alloc_by_realloc): Error out if destination
254 will grow beyond MOST_POSITIVE_FIXNUM.
255 (decode_coding_emacs_mule): Abort if there isn't enough place in
256 charbuf for the composition carryover bytes. Reserve an extra
257 space for up to 2 characters produced in a loop.
258 (decode_coding_iso_2022): Abort if there isn't enough place in
259 charbuf for the composition carryover bytes.
261 2011-04-21 Eli Zaretskii <eliz@gnu.org>
263 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
264 aborting when %lld or %lll format is passed.
265 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
266 %llo or %llx format is passed. (Bug#8545)
268 * window.c (window_scroll_line_based): Use a marker instead of
269 simple variables to record original value of point. (Bug#7952)
271 * doprnt.c (doprnt): Fix the case where a multibyte sequence
272 produced by %s or %c overflows available buffer space. (Bug#8545)
274 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
276 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
277 (SIZE_MAX): Move defn after all includes, as they might #define it.
279 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
281 * w32.c (init_environment): Warn about defaulting HOME to C:\.
283 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
285 * keyboard.c (Qdelayed_warnings_hook): Define.
286 (command_loop_1): Run `delayed-warnings-hook'
287 if Vdelayed_warnings_list is non-nil.
288 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
289 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
291 2011-04-28 Eli Zaretskii <eliz@gnu.org>
293 * doprnt.c (doprnt): Don't return value smaller than the buffer
294 size if the message was truncated. (Bug#8545).
296 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
298 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
299 (Fx_window_property): #if-0 the whole functions, not just the bodies.
301 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
303 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
305 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
307 * makefile.w32-in: Update dependencies.
309 2011-04-27 Eli Zaretskii <eliz@gnu.org>
311 Improve `doprnt' and its usage. (Bug#8545)
312 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
313 `format_end'. Remove support for %l as a conversion specifier.
314 Don't use xrealloc. Improve diagnostics when the %l size modifier
315 is used. Update the commentary.
317 * eval.c (verror): Simplify calculation of size_t.
319 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
322 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
324 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
327 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
329 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
330 This makes this file independent of the recent pseudovector change.
332 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
334 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
336 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
337 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
339 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
341 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
342 GCC 4.6.0 optimizes based on type-based alias analysis. For
343 example, if b is of type struct buffer * and v of type struct
344 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
345 != &v->size, and therefore "v->size = 1; b->size = 2; return
346 v->size;" must therefore return 1. This assumption is incorrect
347 for Emacs, since it type-puns struct Lisp_Vector * with many other
348 types. To fix this problem, this patch adds a new type struct
349 vectorlike_header that documents the constraints on layout of vectors
350 and pseudovectors, and helps optimizing compilers not get fooled
351 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
352 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
353 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
355 (XSETPVECTYPE): Rewrite in terms of new macro.
356 (XSETPVECTYPESIZE): New macro, specifying both type and size.
357 This is a bit clearer, and further avoids the possibility of
358 undesirable aliasing.
359 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
360 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
361 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
362 since Lisp_Subr is a special case (no "next" field).
363 (ASIZE): Now uses header.size rather than size. All
364 previous uses of XVECTOR (foo)->size replaced to use this macro,
365 to avoid the hassle of writing XVECTOR (foo)->header.size.
366 (struct vectorlike_header): New type.
367 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
368 object, to help avoid aliasing.
369 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
370 (SUBRP): Likewise, since Lisp_Subr is a special case.
371 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
372 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
373 (struct Lisp_Hash_Table): Combine first two members into a single
374 struct vectorlike_header member. All uses of "size" and "next" members
375 changed to be "header.size" and "header.next".
376 * buffer.h (struct buffer): Likewise.
377 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
378 * frame.h (struct frame): Likewise.
379 * process.h (struct Lisp_Process): Likewise.
380 * termhooks.h (struct terminal): Likewise.
381 * window.c (struct save_window_data, struct saved_window): Likewise.
382 * window.h (struct window): Likewise.
383 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
384 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
385 * buffer.c (init_buffer_once): Likewise.
386 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
388 * process.c (Fformat_network_address): Use local var for size,
391 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
393 Make the Lisp reader and string-to-float more consistent (Bug#8525)
394 * data.c (atof): Remove decl; no longer used or needed.
395 (digit_to_number): Move to lread.c.
396 (Fstring_to_number): Use new string_to_number function, to be
397 consistent with how the Lisp reader treats infinities and NaNs.
398 Do not assume that floating-point numbers represent EMACS_INT
399 without losing information; this is not true on most 64-bit hosts.
400 Avoid double-rounding errors, by insisting on integers when
401 parsing non-base-10 numbers, as the documentation specifies.
402 * lisp.h (string_to_number): New decl, replacing ...
403 (isfloat_string): Remove.
404 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
405 (read1): Do not accept +. and -. as integers; this
406 appears to have been a coding error. Similarly, do not accept
407 strings like +-1e0 as floating point numbers. Do not report
408 overflow for integer overflows unless the base is not 10 which
409 means we have no simple and reliable way to continue.
410 Break out the floating-point parsing into a new
411 function string_to_number, so that Fstring_to_number parses
412 floating point numbers consistently with the Lisp reader.
413 (digit_to_number): Moved here from data.c. Make it static inline.
414 (E_CHAR, EXP_INT): Remove, replacing with ...
415 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
416 (string_to_number): New function, replacing isfloat_string.
417 This function checks for valid syntax and produces the resulting
418 Lisp float number too. Rework it so that string-to-number
419 no longer mishandles examples like "1.0e+". Use strtoumax,
420 so that overflow for non-base-10 numbers is reported only when
421 there's no portable and simple way to convert to floating point.
423 * textprop.c (set_text_properties_1): Rewrite for clarity,
424 and to avoid GCC warning about integer overflow.
426 * intervals.h (struct interval): Use EMACS_INT for members
427 where EMACS_UINT might cause problems. See
428 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
429 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
430 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
432 (offset_intervals): Tell GCC not to worry about length overflow
433 when negating a negative length.
435 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
436 (overrun_check_free): Likewise.
438 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
439 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
442 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
443 (gnutls_make_error): Rename local to avoid shadowing.
444 (gnutls_emacs_global_deinit): ifdef out; not used.
445 (Fgnutls_boot): Use const for pointer to readonly storage.
446 Comment out unused local. Fix pointer signedness problems.
448 * lread.c (openp): Don't stuff size_t into an 'int'.
449 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
450 about possible signed overflow.
452 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
453 (GDK_KEY_g): Don't define if already defined.
454 (xg_prepare_tooltip): Avoid pointer signedness problem.
455 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
457 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
458 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
460 * xfns.c (Fx_window_property): Simplify a bit,
461 to make a bit faster and to avoid GCC 4.6.0 warning.
462 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
464 * fns.c (internal_equal): Don't assume size_t fits in int.
466 * alloc.c (compact_small_strings): Tighten assertion a little.
468 Replace pEd with more-general pI, and fix some printf arg casts.
469 * lisp.h (pI): New macro, generalizing old pEd macro to other
470 conversion specifiers. For example, use "...%"pI"d..." rather
472 (pEd): Remove. All uses replaced with similar uses of pI.
473 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
474 * alloc.c (check_pure_size): Don't overflow by converting size to int.
475 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
476 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
477 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
478 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
479 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
481 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
482 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
483 * print.c (safe_debug_print, print_object): Likewise.
484 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
486 Use pI instead of if-then-else-abort. Use %p to avoid casts,
487 avoiding the 0 flag, which is not portable.
488 * process.c (Fmake_network_process): Use pI to avoid cast.
489 * region-cache.c (pp_cache): Likewise.
490 * xdisp.c (decode_mode_spec): Likewise.
491 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
492 behavior on 64-bit hosts with printf arg.
493 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
494 (x_stop_queuing_selection_requests): Likewise.
495 (x_get_window_property): Don't truncate byte count to an 'int'
498 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
499 here, since it parses constructs like leading '-' and spaces,
500 which are not wanted; and it overflows with large numbers.
501 Instead, simply match F[0-9]+, which is what is wanted anyway.
503 * alloc.c: Remove unportable assumptions about struct layout.
504 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
505 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
506 (allocate_vectorlike, make_pure_vector): Use the new macros,
507 plus offsetof, to remove unportable assumptions about struct layout.
508 These assumptions hold on all porting targets that I know of, but
509 they are not guaranteed, they're easy to remove, and removing them
510 makes further changes easier.
512 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
513 This doesn't fix a bug but makes the code clearer.
514 (string_overrun_cookie): Now const. Use initializers that
515 don't formally overflow signed char, to avoid warnings.
516 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
517 can cause Emacs to crash when string overrun checking is enabled.
518 (allocate_buffer): Don't assume sizeof (struct buffer) is a
519 multiple of sizeof (EMACS_INT); it need not be, if
520 alignof(EMACS_INT) < sizeof (EMACS_INT).
521 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
523 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
525 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
527 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
529 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
530 supposed to be handshaking. (Bug#8556)
531 Reported by Paul Eggert <eggert@cs.ucla.edu>.
533 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
535 * lisp.h (Qdebug): List symbol.
536 * eval.c (Qdebug): Restore global linkage.
537 * keyboard.c (debug-on-event): New variable.
538 (handle_user_signal): Break into debugger when debug-on-event
539 matches the current signal symbol.
541 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
543 * alloc.c (check_sblock, check_string_bytes)
544 (check_string_free_list): Convert to standard C.
546 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
548 * w32.c (emacs_gnutls_push): Fix typo.
550 2011-04-25 Eli Zaretskii <eliz@gnu.org>
552 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
553 "cast to pointer from integer of different size".
555 Improve doprnt and its use in verror. (Bug#8545)
556 * doprnt.c (doprnt): Document the set of format control sequences
557 supported by the function. Use SAFE_ALLOCA instead of always
560 * eval.c (verror): Don't limit the buffer size at size_max-1, that
561 is one byte too soon. Don't use xrealloc; instead xfree and
564 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
566 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
569 * gnutls.c: Renamed global_initialized to
570 gnutls_global_initialized. Added internals for the
571 :verify-hostname-error, :verify-error, and :verify-flags
572 parameters of `gnutls-boot' and documented those parameters in the
573 docstring. Start callback support.
574 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
575 unless a fatal error occured. Call gnutls_alert_send_appropriate
576 on error. Return error code.
577 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
578 (emacs_gnutls_read): Likewise.
579 (Fgnutls_boot): Return handshake error code.
580 (emacs_gnutls_handle_error): New function.
581 (wsaerror_to_errno): Likewise.
583 * w32.h (emacs_gnutls_pull): Add prototype.
584 (emacs_gnutls_push): Likewise.
586 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
587 (emacs_gnutls_push): Likewise.
589 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
591 * process.c (wait_reading_process_output): Check if GnuTLS
592 buffered some data internally if no FDs are set for TLS
595 * makefile.w32-in (OBJ2): Add gnutls.$(O).
596 (LIBS): Link to USER_LIBS.
597 ($(BLD)/gnutls.$(0)): New target.
599 2011-04-24 Eli Zaretskii <eliz@gnu.org>
601 * xdisp.c (handle_single_display_spec): Rename the
602 display_replaced_before_p argument into display_replaced_p, to
603 make it consistent with the commentary. Fix typos in the
606 * textprop.c (syms_of_textprop): Remove dead code.
607 (copy_text_properties): Delete obsolete commentary about an
608 interface that was deleted long ago. Fix typos in the description
611 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
612 to changes in oldXMenu/XMenu.h from 2011-04-16.
613 <menu_help_message, prev_menu_help_message>: Constify.
614 (IT_menu_make_room): menu->help_text is now `const char **';
617 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
618 to changes in oldXMenu/XMenu.h from 2011-04-16.
619 (struct XMenu): Declare `help_text' `const char **'.
621 * xfaces.c <Qunspecified>: Make extern again.
623 * syntax.c: Include sys/types.h before including regex.h, as
626 * doc.c (get_doc_string): Improve the format passed to `error'.
628 * doprnt.c (doprnt): Improve commentary.
630 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
632 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
635 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
636 changes in globals.h immediately force recompilation.
637 (TAGS): Depend on $(CURDIR)/m/intel386.h and
638 $(CURDIR)/s/ms-w32.h.
639 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
641 * character.c (Fchar_direction): Function deleted.
642 (syms_of_character): Don't defsubr it.
643 <char-direction-table>: Deleted.
645 2011-04-23 Eli Zaretskii <eliz@gnu.org>
647 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
648 * doprnt.c: Include limits.h.
649 (SIZE_MAX): New macro.
650 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
651 local variables are now size_t instead of int or unsigned.
652 Improve overflow protection. Support `l' modifier for integer
653 conversions. Support %l conversion. Don't assume an EMACS_INT
654 argument for integer conversions and for %c.
656 * lisp.h (doprnt): Restore prototype.
658 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
661 * Makefile.in (base_obj): Add back doprnt.o.
663 * deps.mk (doprnt.o): Add back prerequisites.
664 (callint.o): Depend on character.h.
666 * eval.c (internal_lisp_condition_case): Include the handler
667 representation in the error message.
668 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
669 when breaking from the loop.
671 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
673 * callint.c (Fcall_interactively): When displaying error message
674 about invalid control letter, pass the character's codepoint, not
675 a pointer to its multibyte form. Improve display of the character
676 in octal and display also its hex code.
678 * character.c (char_string): Use %x to display the (unsigned)
679 codepoint of an invalid character, to avoid displaying a bogus
682 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
683 `error', not SYMBOL_NAME itself.
685 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
686 character arguments to `error'.
688 * charset.c (check_iso_charset_parameter): Fix incorrect argument
689 to `error' in error message about FINAL_CHAR argument. Make sure
690 FINAL_CHAR is a character, and use %c when it is passed as
693 2011-04-23 Eli Zaretskii <eliz@gnu.org>
695 * s/ms-w32.h (localtime): Redirect to sys_localtime.
697 * w32.c: Include <time.h>.
698 (sys_localtime): New function.
700 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
702 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
704 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
706 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
708 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
711 2011-04-19 Eli Zaretskii <eliz@gnu.org>
713 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
714 gl_state.e_property when gl_state.object is Qt.
716 * insdel.c (make_gap_larger): Remove limitation of buffer size
719 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
721 * xdisp.c (lookup_glyphless_char_display)
722 (produce_glyphless_glyph): Handle cons cell entry in
723 glyphless-char-display.
724 (Vglyphless_char_display): Document it.
726 * term.c (produce_glyphless_glyph): Handle cons cell entry in
727 glyphless-char-display.
729 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
731 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
733 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
735 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
736 definition for no-X builds.
738 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
740 Static checks with GCC 4.6.0 and non-default toolkits.
742 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
744 * process.c (keyboard_bit_set): Define only if SIGIO.
745 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
746 (send_process): Repair possible setjmp clobbering.
748 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
750 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
752 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
754 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
755 Define only if needed.
757 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
758 by pacifying GCC about it. Maybe it's time to retire it?
759 * xfaces.c (USG, __TIMEVAL__): Likewise.
761 * dispextern.h (struct redisplay_interface): Rename param
763 * termhooks.h (struct terminal): Likewise.
764 * xterm.c (xembed_send_message): Likewise.
766 * insdel.c (make_gap_smaller): Define only if
767 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
769 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
772 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
773 so that we aren't warned about unused symbols.
775 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
777 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
779 * xfns.c (x_real_positions): Mark locals as initialized.
781 * xmenu.c (xmenu_show): Don't use uninitialized vars.
783 * xterm.c: Fix problems found by static analysis with other toolkits.
784 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
785 (x_dispatch_event): Declare static if USE_GTK, and
786 define if USE_GTK || USE_X_TOOLKIT.
787 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
788 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
789 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
790 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
792 * xmenu.c (menu_help_callback): Pointer type fixes.
793 Use const pointers when pointing at readonly data. Avoid pointer
795 (FALSE): Remove unused macro.
796 (update_frame_menubar): Remove unused decl.
798 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
800 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
801 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
802 (single_menu_item): Rename local to avoid shadowing.
804 * keyboard.c (make_lispy_event): Remove unused local var.
806 * frame.c, frame.h (x_get_resource_string): Bring this back, but
807 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
809 * bitmaps: Change bitmaps from unsigned char back to the X11
810 compatible char. Avoid the old compiler warnings about
811 out-of-range initializers by using, for example, '\xab' rather
814 * xgselect.c (xgselect_initialize): Check vs interface
815 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
817 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
819 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
822 * fns.c (vector): Remove; this old hack is no longer needed.
824 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
826 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
828 * xrdb.c (x_load_resources): Omit unused local.
830 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
831 (x_window): Rename locals to avoid shadowing.
832 (USG): Use the kludged USG macro, to pacify gcc.
834 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
835 (x_term_init): Remove local to avoid shadowing.
837 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
839 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
840 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
842 2011-04-16 Eli Zaretskii <eliz@gnu.org>
844 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
846 Fix regex.c, syntax.c and friends for buffers > 2GB.
847 * syntax.h (struct gl_state_s): Declare character position members
850 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
852 * textprop.c (verify_interval_modification, interval_of): Declare
855 * intervals.c (adjust_intervals_for_insertion): Declare arguments
858 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
860 * indent.c (Fvertical_motion): Local variable it_start is now
863 * regex.c (re_match, re_match_2, re_match_2_internal)
864 (bcmp_translate, regcomp, regexec, print_double_string)
865 (group_in_compile_stack, re_search, re_search_2, regex_compile)
866 (re_compile_pattern, re_exec): Declare arguments and local
867 variables `size_t' and `ssize_t' and return values `regoff_t', as
869 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
870 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
871 <compile_stack_type>: `size' and `avail' are now `size_t'.
873 * regex.h <regoff_t>: Use ssize_t, not int.
874 (re_search, re_search_2, re_match, re_match_2): Arguments that
875 specify buffer/string position and length are now ssize_t and
876 size_t. Return type is regoff_t.
878 2011-04-16 Ben Key <bkey76@gmail.com>
880 * nsfont.m: Fixed bugs in ns_get_family and
881 ns_descriptor_to_entity that were caused by using free to
882 deallocate memory blocks that were allocated by xmalloc (via
883 xstrdup). This caused Emacs to crash when compiled with
884 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
885 --enable-checking=xmallocoverrun). xfree is now used to
886 deallocate these memory blocks.
888 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
890 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
892 emacs_write: Accept and return EMACS_INT for sizes.
893 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
895 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
896 Accept and return EMACS_INT.
897 (emacs_gnutls_write): Return the number of bytes written on
899 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
900 (emacs_read, emacs_write): Remove check for negative size, as the
901 Emacs source code has been audited now.
902 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
903 (emacs_read, emacs_write): Use it.
904 * process.c (send_process): Adjust to the new signatures of
905 emacs_write and emacs_gnutls_write. Do not attempt to store
906 a byte offset into an 'int'; it might overflow.
907 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
909 * sound.c: Don't assume sizes fit in 'int'.
910 (struct sound_device.period_size, alsa_period_size):
911 Return EMACS_INT, not int.
912 (struct sound_device.write, vox_write, alsa_write):
913 Accept EMACS_INT, not int.
914 (wav_play, au_play): Use EMACS_INT to store sizes and to
915 record read return values.
917 2011-04-15 Ben Key <bkey76@gmail.com>
919 * keyboard.c (Qundefined): Don't declare static since it is used
921 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
922 static since they are used in nsfont.m.
924 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
926 * process.c (Qprocessp): Don't declare static.
927 * lisp.h (Qprocessp): Declare again.
929 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
931 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
933 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
935 Improve C-level modularity by making more things 'static'.
937 Don't publish debugger-only interfaces to other modules.
938 * lisp.h (safe_debug_print, debug_output_compilation_hack):
939 (verify_bytepos, count_markers): Move decls to the only modules
941 * region-cache.h (pp_cache): Likewise.
942 * window.h (check_all_windows): Likewise.
943 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
945 * sysdep.c (croak): Now static, if
946 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
947 * syssignal.h (croak): Declare only if not static.
949 * alloc.c (refill_memory_reserve): Now static if
950 !defined REL_ALLOC || defined SYSTEM_MALLOC.
951 * lisp.h (refill_memory_reserve): Declare only if not static.
953 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
954 Define only if USE_LUCID.
956 * xrdb.c (x_customization_string, x_rm_string): Now static.
958 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
959 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
961 * xdisp.c (draw_row_with_mouse_face): Now static.
962 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
964 * window.h (check_all_windows): Mark externally visible.
966 * window.c (window_deletion_count): Now static.
968 * undo.c: Make symbols static if they're not exported.
969 (last_undo_buffer, last_boundary_position, pending_boundary):
972 * textprop.c (interval_insert_behind_hooks): Now static.
973 (interval_insert_in_front_hooks): Likewise.
975 * term.c: Make symbols static if they're not exported.
976 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
977 (max_frame_lines, tty_set_terminal_modes):
978 (tty_reset_terminal_modes, tty_turn_off_highlight):
979 (get_tty_terminal): Now static.
980 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
981 * termhooks.h (term_mouse_moveto): Do not declare if
983 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
984 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
986 * sysdep.c: Make symbols static if they're not exported.
987 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
989 (sigprocmask_set, full_mask): Remove; unused.
990 (wait_debugging): Mark as visible.
991 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
992 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
994 * syntax.c (syntax_temp): Define only if !__GNUC__.
996 * sound.c (current_sound_device, current_sound): Now static.
998 * search.c (searchbufs, searchbuf_head): Now static.
1000 * scroll.c (scroll_cost): Remove; unused.
1001 * dispextern.h (scroll_cost): Remove decl.
1003 * region-cache.h (pp_cache): Mark as externally visible.
1005 * process.c: Make symbols static if they're not exported.
1006 (process_tick, update_tick, create_process, chan_process):
1007 (Vprocess_alist, proc_buffered_char, datagram_access):
1008 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1009 (deactivate_process): Mark defn as static, as well as decl.
1010 * lisp.h (create_process): Remove decl.
1011 * process.h (chan_process, Vprocess_alist): Remove decls.
1013 * print.c: Make symbols static if they're not exported.
1014 (print_depth, new_backquote_output, being_printed, print_buffer):
1015 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1016 (print_interval, print_number_index, initial_stderr_stream):
1018 * lisp.h (Fprinc): Remove decl.
1019 (debug_output_compilation_hack): Mark as externally visible.
1021 * sysdep.c (croak): Move decl from here to syssignal.h.
1022 * syssignal.h (croak): Put it here, so the API can be checked when
1023 'croak' is called from dissociate_if_controlling_tty.
1025 * minibuf.c: Make symbols static if they're not exported.
1026 (minibuf_save_list, choose_minibuf_frame): Now static.
1027 * lisp.h (choose_minibuf_frame): Remove decl.
1029 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1031 * lread.c: Make symbols static if they're not exported.
1032 (read_objects, initial_obarray, oblookup_last_bucket_number):
1034 (make_symbol): Remove; unused.
1035 * lisp.h (initial_obarray, make_symbol): Remove decls.
1037 * keyboard.c: Make symbols static if they're not exported.
1038 (single_kboard, recent_keys_index, total_keys, recent_keys):
1039 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1040 (this_single_command_key_start, echoing, last_auto_save):
1041 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1042 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1043 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1044 (Vlispy_mouse_stem, double_click_count):
1046 (force_auto_save_soon): Define only if SIGDANGER.
1047 (ignore_mouse_drag_p): Now static if
1048 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1049 (print_help): Remove; unused.
1050 (stop_character, last_timer_event): Mark as externally visible.
1051 * keyboard.h (ignore_mouse_drag_p): Declare only if
1052 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1053 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1054 * lisp.h (echoing): Remove decl.
1055 (force_auto_save_soon): Declare only if SIGDANGER.
1056 * xdisp.c (redisplay_window): Simplify code, to make it more
1057 obvious that ignore_mouse_drag_p is not accessed if !defined
1058 USE_GTK && !defined HAVE_NS.
1060 * intervals.c: Make symbols static if they're not exported.
1061 (merge_properties_sticky, merge_interval_right, delete_interval):
1063 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1065 * insdel.c: Make symbols static if they're not exported.
1066 However, leave prepare_to_modify_buffer alone. It's never
1067 called from outside this function, but that appears to be a bug.
1068 (combine_after_change_list, combine_after_change_buffer):
1069 (adjust_after_replace, signal_before_change): Now static.
1070 (adjust_after_replace_noundo): Remove; unused.
1071 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1072 (signal_before_change): Remove decls.
1074 * indent.c (val_compute_motion, val_vmotion): Now static.
1076 * image.c: Make symbols static if they're not exported.
1077 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1079 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1080 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1082 * fringe.c (standard_bitmaps): Now static.
1083 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1085 * frame.c: Make symbols static if they're not exported.
1086 (x_report_frame_params, make_terminal_frame): Now static.
1087 (get_frame_param): Now static, unless HAVE_NS.
1088 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1089 (x_get_resource_string): Remove; not used.
1090 * frame.h (make_terminal_frame, x_report_frame_params):
1091 (x_get_resource_string); Remove decls.
1092 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1093 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1095 * font.c, fontset.c: Make symbols static if they're not exported.
1096 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1097 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1098 * font.c (font_close_object): Now static.
1099 * font.h (font_close_object): Remove.
1100 * fontset.c (FONTSET_OBJLIST): Remove.
1101 (free_realized_fontset) #if-0 the body, which does nothing.
1102 (face_suitable_for_char_p): #if-0, as it's never called.
1103 * fontset.h (face_suitable_for_char_p): Remove decl.
1104 * xfaces.c (face_at_string_position): Use
1105 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1106 since 0 is always ASCII.
1108 * fns.c (weak_hash_tables): Now static.
1110 * fileio.c: Make symbols static if they're not exported.
1111 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1112 (Vwrite_region_annotation_buffers): Now static.
1114 * eval.c: Make symbols static if they're not exported.
1115 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1116 * lisp.h (backtrace_list): Remove decl.
1118 * emacs.c: Make symbols static if they're not exported.
1119 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1120 (fatal_error_code, fatal_error_signal_hook, standard_args):
1122 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1123 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1124 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1125 * lisp.h (fatal_error_signal_hook): Remove decl.
1126 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1128 * editfns.c: Move a (normally-unused) function to its only use.
1129 * editfns.c, lisp.h (get_operating_system_release): Remove.
1130 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1131 worth the hassle of breaking this out.
1133 * xterm.c: Make symbols static if they're not exported.
1134 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1135 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1136 (x_destroy_window, x_delete_display):
1138 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1139 (x_mouse_leave): Remove; unused.
1140 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1141 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1142 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1144 (x_mouse_leave): Declare only if WINDOWSNT.
1145 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1146 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1149 * ftxfont.c: Make symbols static if they're not exported.
1150 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1152 * font.h (ftxfont_driver): Likewise.
1154 * xfns.c: Make symbols static if they're not exported.
1155 (x_last_font_name, x_display_info_for_name):
1156 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1157 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1158 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1159 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1160 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1161 (last_show_tip_args): Now static.
1162 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1163 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1164 (x_screen_planes): Remove; unused.
1165 * dispextern.h (x_screen_planes): Remove decl.
1167 * dispnew.c: Make symbols static if they're not exported.
1168 * dispextern.h (redraw_garbaged_frames, scrolling):
1169 (increment_row_positions): Remove.
1170 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1171 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1173 (redraw_garbaged_frames): Remove; unused.
1175 * xfaces.c: Make symbols static if they're not exported.
1176 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1178 * xterm.h (defined_color): Remove decls.
1179 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1180 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1181 (menu_face_changed_default, defined_color, free_realized_face):
1182 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1183 (ascii_face_of_lisp_face): Remove; unused.
1185 * xdisp.c: Make symbols static if they're not exported.
1186 * dispextern.h (scratch_glyph_row, window_box_edges):
1187 (glyph_to_pixel_coords, set_cursor_from_row):
1188 (get_next_display_element, set_iterator_to_next):
1189 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1190 (show_mouse_face): Remove decls
1191 * frame.h (message_buf_print): Likewise.
1192 * lisp.h (pop_message, set_message, check_point_in_composition):
1194 * xterm.h (set_vertical_scroll_bar): Likewise.
1195 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1196 (message_buf_print, scratch_glyph_row, displayed_buffer):
1197 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1198 (get_next_display_element, show_mouse_face, window_box_edges):
1199 (frame_to_window_pixel_xy, check_point_in_composition):
1200 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1201 (glyph_to_pixel_coords): Remove; unused.
1203 * dired.c (file_name_completion): Now static.
1205 * dbusbind.c (xd_in_read_queued_messages): Now static.
1207 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1208 * data.c (circular_list_error): Remove.
1210 * commands.h (last_point_position, last_point_position_buffer):
1211 (last_point_position_window): Remove decls.
1212 * keyboard.c: Make these variables static.
1214 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1216 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1217 (iso_code_class, detect_coding, code_convert_region): Now static.
1218 (encode_coding_gap): Remove; unused.
1220 * chartab.c (chartab_chars, chartab_bits): Now static.
1222 * charset.h (charset_iso_8859_1): Remove decl.
1223 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1226 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1227 * ccl.c (Vccl_program_table): Now static.
1228 (check_ccl_update): Remove; unused.
1230 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1231 * category.h: ... from here.
1232 * category.c (check_category_table, set_category_set): Now static.
1234 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1235 * lisp.h: Remove these decls.
1237 * buffer.c (buffer_count): Remove unused var.
1239 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1240 so that it's not optimized away.
1241 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1242 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1243 exported only to the debugger.
1245 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1246 * atimer.h (run_all_atimers): Removed; not exported.
1248 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1249 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1250 was inaccessible from Lisp.
1251 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1252 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1254 alloc.c: Import and export fewer symbols, and remove unused items.
1255 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1257 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1258 it's not optimized away by whole-program optimization.
1259 (message_enable_multibyte, free_misc): Remove.
1260 (catchlist, handlerlist, mark_backtrace):
1261 Declare only if BYTE_MARK_STACK.
1262 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1263 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1264 (message_enable_multibyte): Remove decl.
1265 (free_misc, interval_free_list, float_block, float_block_index):
1266 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1267 (cons_free_list, last_marked_index):
1269 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1270 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1271 (mark_backtrace): Define only if BYTE_MARK_STACK.
1272 * xdisp.c (message_enable_multibyte): Now static.
1274 Declare Lisp_Object Q* variables to be 'static' if not exported.
1275 This makes it easier for human readers (and static analyzers)
1276 to see whether these variables are used from other modules.
1277 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1278 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1279 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1280 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1281 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1282 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1283 * xmenu.c, xselect.c:
1284 Declare Q* vars static if they are not used in other modules.
1285 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1286 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1287 Remove decls of unexported vars.
1288 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1290 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1292 Make Emacs functions such as Fatom 'static' by default.
1293 This makes it easier for human readers (and static analyzers)
1294 to see whether these functions can be called from other modules.
1295 DEFUN now defines a static function. To make the function external
1296 so that it can be used in other C modules, use the new macro DEFUE.
1297 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1298 (Finit_image_library):
1299 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1300 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1301 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1302 Remove decls, since these functions are now static.
1303 (Funintern, Fget_internal_run_time): New decls, since these functions
1304 were already external.
1306 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1307 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1308 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1309 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1310 * keyboard.c, keymap.c, lread.c:
1311 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1312 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1313 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1314 Mark functions with DEFUE instead of DEFUN,
1315 if they are used in other modules.
1316 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1317 decls for now-static functions.
1318 * buffer.h (Fdelete_overlay): Remove decl.
1319 * callproc.c (Fgetenv_internal): Mark as internal.
1320 * composite.c (Fremove_list_of_text_properties): Remove decl.
1321 (Fcomposition_get_gstring): New forward static decl.
1322 * composite.h (Fcomposite_get_gstring): Remove decl.
1323 * dired.c (Ffile_attributes): New forward static decl.
1324 * doc.c (Fdocumntation_property): New forward static decl.
1325 * eval.c (Ffetch_bytecode): New forward static decl.
1326 (Funintern): Remove extern decl; now in .h file where it belongs.
1327 * fileio.c (Fmake_symbolic_link): New forward static decl.
1328 * image.c (Finit_image_library): New forward static decl.
1329 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1330 * intervals.h (Fprevious_property_change):
1331 (Fremove_list_of_text_properties): Remove decls.
1332 * keyboard.c (Fthis_command_keys): Remove decl.
1333 (Fcommand_execute): New forward static decl.
1334 * keymap.c (Flookup_key): New forward static decl.
1335 (Fcopy_keymap): Now static.
1336 * keymap.h (Flookup_key): Remove decl.
1337 * process.c (Fget_process): New forward static decl.
1338 (Fprocess_datagram_address): Mark as internal.
1339 * syntax.c (Fsyntax_table_p): New forward static decl.
1340 (skip_chars): Remove duplicate decl.
1341 * textprop.c (Fprevious_property_change): New forward static decl.
1342 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1344 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1345 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1347 * editfns.c (Fformat): Remove unreachable code.
1349 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1351 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1354 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1356 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1357 when at ZV. (Bug#8487)
1359 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1361 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1363 * keyboard.c (parse_tool_bar_item): Likewise.
1364 * sound.c (sound_cleanup, alsa_close): Likewise.
1365 * termcap.c (tgetent): Likewise.
1366 * xfns.c (x_default_font_parameter): Likewise.
1367 * xsettings.c (read_and_apply_settings): Likewise.
1369 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1370 (overrun_check_free): Protoize.
1372 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1374 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1375 since callers should never pass a negative size.
1376 Change the signature to match that of plain 'read' and 'write'; see
1377 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1378 * lisp.h: Update prototypes of emacs_write and emacs_read.
1380 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1382 * xdisp.c (redisplay_window): Don't try to determine the character
1383 position of the scroll margin if the window start point w->startp
1384 is outside the buffer's accessible region. (Bug#8468)
1386 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1388 Fix write-region and its subroutines for buffers > 2GB.
1389 * fileio.c (a_write, e_write): Modify declaration of arguments and
1390 local variables to support buffers larger than 2GB.
1391 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1393 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1394 argument, local variables, and return value.
1396 * lisp.h: Update prototypes of emacs_write and emacs_read.
1398 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1400 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1402 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1404 Fix more problems found by GCC 4.6.0's static checks.
1406 * xdisp.c (vmessage): Use a better test for character truncation.
1408 * charset.c (load_charset_map): <, not <=, for optimization,
1409 and to avoid potential problems with integer overflow.
1410 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1411 * casetab.c (set_identity, shuffle): Likewise.
1412 * editfns.c (Fformat): Likewise.
1413 * syntax.c (skip_chars): Likewise.
1415 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1416 This also lets GCC 4.6.0 generate slightly better loop code.
1418 * callint.c (Fcall_interactively): <, not <=, for optimization.
1419 (Fcall_interactively): Count the number of arguments produced,
1420 not the number of arguments given. This is simpler and lets GCC
1421 4.6.0 generate slightly better code.
1423 * ftfont.c: Distingish more carefully between FcChar8 and char.
1424 The previous code passed unsigned char * to a functions like
1425 strlen and xstrcasecmp that expect char *, which does not
1426 conform to the C standard.
1427 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1428 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1429 char * when the C standard requires it.
1431 * keyboard.c (read_char): Remove unused var.
1433 * eval.c: Port to Windows vsnprintf (Bug#8435).
1435 (SIZE_MAX): Define if the headers do not.
1436 (verror): Do not give up if vsnprintf returns a negative count.
1437 Instead, grow the buffer. This ports to Windows vsnprintf, which
1438 does not conform to C99. Problem reported by Eli Zaretskii.
1439 Also, simplify the allocation scheme, by avoiding the need for
1440 calling realloc, and removing the ALLOCATED variable.
1442 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1444 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1445 But keep the doprint source code for now, as we might revamp it
1446 and use it again (Bug#8435).
1447 * lisp.h (doprnt): Remove.
1448 * Makefile.in (base_obj): Remove doprnt.o.
1449 * deps.mk (doprnt.o): Remove.
1451 error: Print 32- and 64-bit integers portably (Bug#8435).
1452 Without this change, on typical 64-bit hosts error ("...%d...", N)
1453 was used to print both 32- and 64-bit integers N, which relied on
1455 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1457 * lisp.h (error, verror): Mark as printf-like functions.
1458 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1459 Report overflow in size calculations when allocating printf buffer.
1460 Do not truncate output string at its first null byte.
1461 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1462 Truncate the output at a character boundary, since vsnprintf does not
1464 * charset.c (check_iso_charset_parameter): Convert internal
1465 character to string before calling 'error', since %c now has the
1467 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1468 overflow when computing char to be passed to 'error'. Do not
1469 pass Lisp_Object to 'error'; pass the integer instead.
1470 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1471 formatted with plain %d.
1473 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1475 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1477 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1479 * xterm.c (x_catch_errors): Remove duplicate declaration.
1481 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1483 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1485 2011-04-10 Jim Meyering <meyering@redhat.com>
1487 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1488 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1489 return ssize_t not "int", and use size_t as the buffer length.
1490 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1491 * gnutls.h: Update declarations.
1492 * process.c (read_process_output): Use ssize_t, to match.
1493 (send_process): Likewise.
1495 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1497 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1499 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1501 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1502 unsigned char, to match FcChar8 type definition.
1504 * xterm.c (handle_one_xevent):
1505 * xmenu.c (create_and_show_popup_menu):
1506 * xselect.c (x_decline_selection_request)
1507 (x_reply_selection_request): Avoid type-punned deref of X events.
1509 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1511 Fix some uses of `int' instead of EMACS_INT.
1512 * search.c (string_match_1, fast_string_match)
1513 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1514 (scan_buffer, find_next_newline_no_quit)
1515 (find_before_next_newline, search_command, Freplace_match)
1516 (Fmatch_data): Make some `int' variables be EMACS_INT.
1518 * xdisp.c (display_count_lines): 3rd argument and return value now
1519 EMACS_INT. All callers changed.
1520 (pint2hrstr): Last argument is now EMACS_INT.
1522 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1523 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1524 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1525 (decode_coding_utf_16, decode_coding_emacs_mule)
1526 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1527 (decode_coding_ccl, decode_coding_charset)
1528 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1529 (decode_coding_iso_2022, decode_coding_emacs_mule)
1530 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1531 <char_offset, last_offset>: Declare EMACS_INT.
1532 (encode_coding_utf_8, encode_coding_utf_16)
1533 (encode_coding_emacs_mule, encode_invocation_designation)
1534 (encode_designation_at_bol, encode_coding_iso_2022)
1535 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1536 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1538 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1539 (encode_invocation_designation): Last argument P_NCHARS is now
1541 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1542 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1544 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1547 * ccl.c (Fccl_execute_on_string): Declare some variables
1550 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1552 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1554 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1556 * process.c (Fformat_network_address): Doc fix.
1558 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1560 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1562 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1564 * keyboard.c (read_char): Call Lisp function help-form-show,
1565 instead of using internal_with_output_to_temp_buffer.
1566 (Qhelp_form_show): New var.
1567 (syms_of_keyboard): Use DEFSYM macro.
1569 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1571 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1573 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1575 * process.c (Flist_processes): Removed to Lisp.
1576 (list_processes_1): Deleted.
1578 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1580 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1582 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1584 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1586 Fix more problems found by GCC 4.6.0's static checks.
1588 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1590 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1592 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1594 * xdisp.c (vmessage): Mark as a printf-like function.
1596 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1598 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1600 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1601 printf-like functions.
1602 (tiff_load): Add casts to remove these marks before passing them
1603 to system-supplied API.
1605 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1607 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1608 This avoids several warnings with gcc -Wstrict-overflow.
1609 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1610 directly, rather than having caller test rule sign. This avoids
1611 some unnecessary tests.
1612 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1613 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1614 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1616 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1617 (xfont_open): Avoid unnecessary tests.
1619 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1621 * composite.h, composite.c (composition_gstring_put_cache):
1622 Use EMACS_INT, not int, for length.
1624 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1625 breaking out part of COMPOSITION_DECODE_RULE.
1626 (COMPOSITION_DECODE_RULE): Use it.
1627 * composite.c (get_composition_id): Remove unused local vars,
1628 by using the new macro.
1630 * textprop.c (set_text_properties_1): Change while to do-while,
1631 since the condition is always true at first.
1633 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1634 (interval_deletion_adjustment): Return unsigned value.
1637 * process.c (list_processes_1, create_pty, read_process_output):
1638 (exec_sentinel): Remove vars that were set but not used.
1639 (create_pty): Remove unnecessary "volatile"s.
1640 (Fnetwork_interface_info): Avoid possibility of int overflow.
1641 (read_process_output): Do adaptive read buffering even if carryover.
1642 (read_process_output): Simplify nbytes computation if buffered.
1644 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1646 * syntax.c (scan_words): Remove var that was set but not used.
1647 (update_syntax_table): Use unsigned instead of int.
1649 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1650 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1651 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1653 * print.c (print_error_message): Avoid int overflow.
1655 * font.c (font_list_entities): Redo for clarity,
1656 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1658 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1659 (font_score): Avoid potential overflow in diff calculation.
1661 * fns.c (substring_both): Remove var that is set but not used.
1662 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1664 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1666 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1667 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1668 can always succeed if overflow has undefined behavior.
1670 * search.c (boyer_moore, wordify): Remove vars set but not used.
1671 (wordify): Omit three unnecessary tests.
1673 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1674 All callers changed. This avoids the need for an unused var.
1676 * casefiddle.c (casify_region): Remove var that is set but not used.
1678 * dired.c (file_name_completion): Remove var that is set but not used.
1680 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1682 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1683 (Finsert_file_contents): Remove unnecessary code checking fd.
1685 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1686 Check for integer overflow on size calculations.
1688 * buffer.c (Fprevious_overlay_change): Remove var that is set
1691 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1692 Remove vars that are set but not used.
1693 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1694 (timer_check_2): Mark vars as initialized.
1696 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1698 * image.c (lookup_image): Remove var that is set but not used.
1699 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1701 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1702 that are set but not used.
1704 * xfns.c (make_invisible_cursor): Don't return garbage
1705 if XCreateBitmapFromData fails (Bug#8410).
1707 * xselect.c (x_get_local_selection, x_handle_property_notify):
1708 Remove vars that are set but not used.
1710 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1711 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1713 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1714 Remove var that is set but not used.
1715 (scroll_bar_windows_size): Now size_t, not int.
1716 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1719 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1720 (map_tty_color) [!defined MSDOS]: Likewise.
1722 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1724 * coding.c: Remove vars that are set but not used.
1725 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1726 All callers changed.
1727 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1728 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1729 (decode_coding_charset): Remove vars that are set but not used.
1731 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1732 that is set but not used.
1734 * print.c (print_object): Remove var that is set but not used.
1736 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1737 The gnulib version avoids calling malloc in the usual case,
1738 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1739 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1740 * filelock.c (current_lock_owner): Likewise.
1741 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1742 * sysdep.c: Include allocator.h, careadlinkat.h.
1743 (emacs_no_realloc_allocator): New static constant.
1744 (emacs_readlink): New function.
1745 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1746 ../lib/careadlinkat.h.
1748 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1750 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1751 first non-nil return value).
1753 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1755 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1756 if not defined (Bug#8403).
1758 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1760 * xdisp.c (display_count_lines): Remove parameter `start',
1761 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1762 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1763 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1764 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1765 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1766 and thereabouts. All callers changed.
1767 (get_per_char_metric): Remove parameter `f', unused since
1768 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1770 2011-04-02 Jim Meyering <meyering@redhat.com>
1772 do not dereference NULL upon failed strdup
1773 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1774 (ns_get_family): Likewise.
1776 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1778 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1780 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1782 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1785 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1787 Add lexical binding.
1789 * window.c (Ftemp_output_buffer_show): New fun.
1790 (Fsave_window_excursion):
1791 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1793 * lread.c (lisp_file_lexically_bound_p): New function.
1794 (Fload): Bind Qlexical_binding.
1795 (readevalloop): Remove `evalfun' arg.
1796 Bind Qinternal_interpreter_environment.
1797 (Feval_buffer): Bind Qlexical_binding.
1798 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1800 (syms_of_lread): Declare `lexical-binding'.
1802 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1804 * keyboard.c (eval_dyn): New fun.
1805 (menu_item_eval_property): Use it.
1807 * image.c (parse_image_spec): Use Ffunctionp.
1809 * fns.c (concat, mapcar1): Accept byte-code-functions.
1811 * eval.c (Fsetq): Handle lexical vars.
1812 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1813 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1814 (FletX, Flet): Obey lexical binding.
1815 (Fcommandp): Handle closures.
1816 (Feval): New `lexical' arg.
1817 (eval_sub): New function extracted from Feval. Use it almost
1818 everywhere where Feval was used. Look up vars in lexical env.
1820 (Ffunctionp): Move from subr.el.
1821 (Ffuncall): Handle closures.
1822 (apply_lambda): Remove `eval_flags'.
1823 (funcall_lambda): Handle closures and new byte-code-functions.
1824 (Fspecial_variable_p): New function.
1825 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1826 but without exporting it to Lisp.
1828 * doc.c (Fdocumentation, store_function_docstring):
1829 * data.c (Finteractive_form): Handle closures.
1831 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1834 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1836 (exec_byte_code): New function extracted from Fbyte_code to handle new
1837 calling convention for byte-code-functions. Add new byte-codes.
1839 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1841 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1843 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1845 * xdisp.c (redisplay_internal): Fix prototype.
1847 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1849 * xdisp.c (SCROLL_LIMIT): New macro.
1850 (try_scrolling): Use it when setting scroll_limit. Limit
1851 scrolling to 100 screen lines.
1852 (redisplay_window): Even when falling back on "recentering",
1853 position point in the window according to scroll-conservatively,
1854 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1856 (try_scrolling): When point is above the window, allow searching
1857 as far as scroll_max, or one screenful, to compute vertical
1858 distance from PT to the scroll margin position. This prevents
1859 try_scrolling from unnecessarily failing when
1860 scroll-conservatively is set to a value slightly larger than the
1861 window height. Clean up the case of PT below the margin at bottom
1862 of window: scroll_max can no longer be INT_MAX. When aggressive
1863 scrolling is in use, don't let point enter the opposite scroll
1864 margin as result of the scroll.
1865 (syms_of_xdisp) <scroll-conservatively>: Document the
1866 threshold of 100 lines for never-recentering scrolling.
1868 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1870 * dispextern.h (move_it_by_lines):
1871 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1872 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1873 (message_log_check_duplicate): Remove parameters `prev_bol' and
1874 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1875 (redisplay_internal): Remove parameter `preserve_echo_area',
1876 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1878 * indent.c (Fvertical_motion):
1879 * window.c (window_scroll_pixel_based, Frecenter):
1880 Don't pass `need_y_p' to `move_it_by_lines'.
1882 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1884 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1885 steal a few bits to be more compact.
1886 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1887 Remove unneeded casts.
1889 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1891 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1893 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1894 binding" message (bug#7967).
1896 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1898 Fix more problems found by GCC 4.6.0's static checks.
1900 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1901 Remove unused local var.
1903 * editfns.c (Fmessage_box): Remove unused local var.
1905 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1906 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1907 Omit unused local vars.
1908 * window.c (shrink_windows): Omit unused local var.
1909 * menu.c (digest_single_submenu): Omit unused local var.
1910 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1911 Omit unused local var.
1913 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1914 Don't assume string length fits in int.
1915 (keyremap_step, read_key_sequence): Use size_t for sizes.
1916 (read_key_sequence): Don't check last_real_key_start redundantly.
1918 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1919 instead of alloca (Bug#8344).
1921 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1922 (Fbacktrace_frame): Don't assume nframes fits in int.
1924 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1926 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1929 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1931 * cm.c (calccost): Turn while-do into do-while, for clarity.
1933 * keyboard.c (syms_of_keyboard): Use the same style as later
1934 in this function when indexing through an array. This also
1935 works around GCC bug 48267.
1937 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1939 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1941 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1942 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1944 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1945 This avoids undefined behavior on integer overflow, and is a bit
1946 more convenient anyway since it is compared to a size_t variable.
1948 Variadic C functions now count arguments with size_t, not int.
1949 This avoids an unnecessary limitation on 64-bit machines, which
1950 caused (substring ...) to crash on large vectors (Bug#8344).
1951 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1952 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1953 All variadic functions and their callers changed accordingly.
1954 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1955 * data.c (arith_driver, float_arith_driver): Likewise.
1956 * editfns.c (general_insert_function): Likewise.
1957 * eval.c (struct backtrace.nargs, interactive_p)
1958 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1959 (funcall_lambda, mark_backtrace): Likewise.
1960 * fns.c (concat): Likewise.
1961 * frame.c (x_set_frame_parameters): Likewise.
1962 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1963 0 if not found, not -1. All callers changed.
1965 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1966 (stack_copy_size): Now size_t, not int.
1967 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1969 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1971 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1972 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1973 All callers changed.
1975 * lisp.h (multibyte_char_to_unibyte):
1976 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1977 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1978 * character.h (CHAR_TO_BYTE8):
1979 * cmds.c (internal_self_insert):
1980 * editfns.c (general_insert_function):
1981 * keymap.c (push_key_description):
1982 * search.c (Freplace_match):
1983 * xdisp.c (message_dolog, set_message_1): All callers changed.
1985 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1987 * keyboard.c (safe_run_hook_funcall): New function.
1988 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1989 don't set the hook to nil, but remove the offending function instead.
1990 (Qcommand_hook_internal): Remove, unused.
1991 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1992 Vcommand_hook_internal.
1994 * eval.c (enum run_hooks_condition): Remove.
1995 (funcall_nil, funcall_not): New functions.
1996 (run_hook_with_args): Call each function through a `funcall' argument.
1997 Remove `cond' argument, now redundant.
1998 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1999 (Frun_hook_with_args_until_failure): Adjust accordingly.
2000 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2002 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2004 * dispextern.h (string_buffer_position): Remove declaration.
2006 * print.c (strout): Remove parameter `multibyte', unused since
2007 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2009 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2010 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2011 All callers changed.
2013 * w32.c (_wsa_errlist): Use braces for struct initializers.
2015 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2016 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2017 All callers changed.
2018 (string_buffer_position): Likewise. Also, make static (it's never
2019 used outside xdisp.c).
2020 (cursor_row_p): Remove parameter `w', unused since
2021 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2022 (decode_mode_spec): Remove parameter `precision', introduced during
2023 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2024 All callers changed.
2026 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2028 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2030 2011-03-27 Anders Lindgren <andlind@gmail.com>
2032 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2033 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2034 (ns_update_auto_hide_menu_bar): New functions.
2035 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2036 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2037 ns_constrain_all_frames.
2038 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2039 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2041 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2043 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2045 2011-03-27 Glenn Morris <rgm@gnu.org>
2047 * syssignal.h: Replace RETSIGTYPE with void.
2048 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2049 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2050 Replace SIGTYPE with void everywhere.
2051 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2052 * s/template.h (SIGTYPE): Remove commented out definition.
2054 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2056 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2057 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2059 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2061 * w32.c (read_unc_volume): Use parameter `henum', instead of
2062 global variable `wget_enum_handle'.
2064 * keymap.c (describe_vector): Remove parameters `indices' and
2065 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2066 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2068 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2070 * keyboard.c (timer_check): Remove parameter `do_it_now',
2071 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2072 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2073 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2075 * keyboard.c (read_char):
2076 * w32menu.c (w32_menu_display_help):
2077 * xmenu.c (show_help_event, menu_help_callback):
2078 Adjust calls to `show_help_echo'.
2080 * gtkutil.c (xg_maybe_add_timer):
2081 * keyboard.c (readable_events):
2082 * process.c (wait_reading_process_output):
2083 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2085 * insdel.c (adjust_markers_gap_motion):
2086 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2087 (gap_left, gap_right): Don't call it.
2089 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2091 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2092 incurred during fontification.
2094 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2096 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2097 (DEFVAR_PER_BUFFER): Don't pass it.
2099 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2100 (scrolling_window): Don't pass it.
2102 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2104 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2106 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2108 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2109 of variables specific to SELinux and computation of `encoded_absname'.
2111 * image.c (XPutPixel): Remove unused variable `height'.
2113 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2115 * unexw32.c (get_section_info): Remove unused variable `section'.
2117 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2118 (system_process_attributes): Remove unused variable `sess'.
2119 (sys_read): Remove unused variable `err'.
2121 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2122 (w32_wnd_proc): Remove unused variable `isdead'.
2123 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2124 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2125 (x_create_tip_frame): Remove unused variable `tem'.
2127 * w32inevt.c (w32_console_read_socket):
2128 Remove unused variable `no_events'.
2130 * w32term.c (x_draw_composite_glyph_string_foreground):
2131 Remove unused variable `width'.
2133 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2135 * w32term.c (x_set_glyph_string_clipping):
2136 Don't pass uninitialized region to CombineRgn.
2138 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2140 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2141 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2142 (Fx_close_connection): Remove unused variable `i'.
2144 * w32font.c (w32font_draw): Return number of glyphs.
2145 (w32font_open_internal): Remove unused variable `i'.
2146 (w32font_driver): Add missing initializer.
2148 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2149 (fill_in_menu): Remove unused variable `items_added'.
2151 * w32term.c (last_mouse_press_frame): Remove static global variable.
2152 (w32_clip_to_row): Remove unused variable `f'.
2153 (x_delete_terminal): Remove unused variable `i'.
2155 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2156 (NOTHING): Remove unused static global variable.
2157 (uniscribe_check_otf): Remove unused variable `table'.
2158 (uniscribe_font_driver): Add missing initializers.
2160 2011-03-23 Julien Danjou <julien@danjou.info>
2162 * term.c (Fsuspend_tty, Fresume_tty):
2163 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2164 * window.c (temp_output_buffer_show):
2165 * insdel.c (signal_before_change):
2166 * frame.c (Fhandle_switch_frame):
2167 * fileio.c (Fdo_auto_save):
2168 * emacs.c (Fkill_emacs):
2169 * editfns.c (save_excursion_restore):
2170 * cmds.c (internal_self_insert):
2171 * callint.c (Fcall_interactively):
2172 * buffer.c (Fkill_all_local_variables):
2173 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2175 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2176 unconditionnaly since it does the check itself.
2178 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2180 Fix more problems found by GCC 4.5.2's static checks.
2182 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2183 the first time through the loop, since we know p0 < p1 then.
2184 This also avoids a gcc -Wstrict-overflow warning.
2186 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2187 leading to a memory leak, possible in functions like
2188 load_charset_map_from_file that can allocate an unbounded number
2189 of objects (Bug#8318).
2191 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2192 that could (at least in theory) be that large.
2194 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2195 This is less likely to overflow, and avoids undefined behavior if
2196 overflow does occur. All callers changed. Use strtoul to scan
2197 for the unsigned long integer.
2198 (pint2hrstr): Simplify and tune code slightly.
2199 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2201 * scroll.c (do_scrolling): Work around GCC bug 48228.
2202 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2204 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2205 This also avoids a warning with gcc -Wstrict-overflow.
2206 (validate_x_resource_name): Simplify count usage.
2207 This also avoids a warning with gcc -Wstrict-overflow.
2209 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2212 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2214 * process.c (Fmake_network_process): Use socklen_t, not int,
2215 where POSIX says socklen_t is required in portable programs.
2216 This fixes a porting bug on hosts like 64-bit HP-UX, where
2217 socklen_t is wider than int (Bug#8277).
2218 (Fmake_network_process, server_accept_connection):
2219 (wait_reading_process_output, read_process_output):
2222 * process.c: Rename or move locals to avoid shadowing.
2223 (list_processes_1, Fmake_network_process):
2224 (read_process_output_error_handler, exec_sentinel_error_handler):
2225 Rename or move locals.
2226 (Fmake_network_process): Define label "retry_connect" only if needed.
2227 (Fnetwork_interface_info): Fix pointer signedness.
2228 (process_send_signal): Add cast to avoid pointer signedness problem.
2229 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2230 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2232 Make tparam.h and terminfo.c consistent.
2233 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2234 Include tparam.h instead, since it declares them.
2235 * cm.h (PC): Remove extern decl; tparam.h now does this.
2236 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2237 * terminfo.c: Include tparam.h, to check interfaces.
2238 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2239 (tparam): Adjust signature to match interface in tparam.h;
2240 this removes some undefined behavior. Check that outstring and len
2241 are zero, which they always are with Emacs.
2242 * tparam.h (PC, BC, UP): New extern decls.
2244 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2245 (xftfont_open): Rename locals to avoid shadowing.
2247 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2248 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2249 (OTF_TAG_SYM): Omit macro if not needed.
2250 (ftfont_list): Remove unused local.
2251 (get_adstyle_property, ftfont_pattern_entity):
2252 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2253 Rename locals to avoid shadowing.
2255 * xfont.c (xfont_list_family): Mark var as initialized.
2257 * xml.c (make_dom): Now static.
2259 * composite.c (composition_compute_stop_pos): Rename local to
2261 (composition_reseat_it): Remove unused locals.
2262 (find_automatic_composition, composition_adjust_point): Likewise.
2263 (composition_update_it): Mark var as initialized.
2264 (find_automatic_composition): Mark vars as initialized,
2265 with a FIXME (Bug#8290).
2267 character.h: Rename locals to avoid shadowing.
2268 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2269 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2270 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2271 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2274 * textprop.c (property_change_between_p): Remove; unused.
2276 * intervals.c (interval_start_pos): Now static.
2278 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2280 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2281 Rename locals to avoid shadowing.
2283 * sound.c (wav_play, au_play, Fplay_sound_internal):
2284 Fix pointer signedness.
2285 (alsa_choose_format): Remove unused local var.
2286 (wav_play): Initialize a variable to 0, to prevent undefined
2287 behavior (Bug#8278).
2289 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2291 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2293 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2294 clobbering (Bug#8298).
2295 * sysdep.c (sys_subshell): Likewise.
2296 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2298 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2299 This should get cleaned up, so that child_setup has the
2300 same signature on all platforms.
2302 * callproc.c (call_process_cleanup): Now static.
2303 (relocate_fd): Rename locals to avoid shadowing.
2305 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2307 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2308 not to be necessary, and produces flickering.
2310 2011-03-20 Glenn Morris <rgm@gnu.org>
2312 * config.in: Remove file.
2314 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2316 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2317 are now in src/globals.h.
2318 (syms_of_minibuf): Remove spurious & from previous change.
2320 2011-03-20 Leo <sdl.web@gmail.com>
2322 * minibuf.c (completing-read-function): New variable.
2323 (completing-read-default): Rename from completing-read.
2324 (completing-read): Call completing-read-function.
2326 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2328 * xfaces.c (Fx_load_color_file):
2329 Read color file from absolute filename (bug#8250).
2331 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2333 * makefile.w32-in: Update dependencies.
2335 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2337 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2339 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2341 Fix more problems found by GCC 4.5.2's static checks.
2343 * process.c (make_serial_process_unwind, send_process_trap):
2344 (sigchld_handler): Now static.
2346 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2347 That way, the code declares only the vars that it needs.
2348 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2349 * s/cygwin.h (PTY_ITERATION): Likewise.
2350 * s/darwin.h (PTY_ITERATION): Likewise.
2351 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2353 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2354 * process.c (allocate_pty): Don't declare stb unless it's needed.
2356 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2357 (CONSTANTLIM): Remove; unused.
2358 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2359 Define only if needed.
2361 * unexelf.c (unexec): Name an expression,
2362 to avoid gcc -Wbad-function-cast warning.
2363 Use a different way to cause a compilation error if anyone uses
2364 n rather than nn, a way that does not involve shadowing.
2365 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2367 * deps.mk (unexalpha.o): Remove; unused.
2369 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2370 * unexec.h: New file.
2371 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2372 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2374 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2375 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2376 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2377 Change as necessary to match prototype in unexec.h.
2379 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2381 (back_comment, skip_chars): Mark vars as initialized.
2383 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2384 Rename locals to avoid shadowing.
2386 * lread.c (read1): Rewrite so as not to use empty "else".
2387 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2389 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2391 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2392 warning when compiling print.c.
2394 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2395 instead of using an uninitialized var.
2396 (font_sort_entities): Mark var as initialized.
2398 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2400 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2401 pointers to constants.
2402 (font_parse_fcname): Remove unused vars.
2403 (font_delete_unmatched): Now static.
2404 (font_get_spec): Remove; unused.
2405 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2406 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2407 Rename or move locals to avoid shadowing.
2409 * fns.c (require_nesting_list, require_unwind): Now static.
2410 (Ffillarray): Rename locals to avoid shadowing.
2412 * floatfns.c (domain_error2): Define only if needed.
2413 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2415 * alloc.c (mark_backtrace): Move decl from here ...
2416 * lisp.h: ... to here, so that it can be checked.
2418 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2419 (Fdefvar): Rewrite so as not to use empty "else".
2420 (lisp_indirect_variable): Name an expression,
2421 to avoid gcc -Wbad-function-cast warning.
2422 (Fdefvar): Rename locals to avoid shadowing.
2424 * callint.c (quotify_arg, quotify_args): Now static.
2425 (Fcall_interactively): Rename locals to avoid shadowing.
2426 Use const pointer when appropriate.
2428 * lisp.h (get_system_name, get_operating_system_release):
2429 Move decls here, to check interfaces.
2430 * process.c (get_operating_system_release): Move decl to lisp.h.
2431 * xrdb.c (get_system_name): Likewise.
2432 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2433 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2434 some of which prompt warnings from gcc -Wbad-function-cast.
2435 (Fformat_time_string, Fencode_time, Finsert_char):
2436 (Ftranslate_region_internal, Fformat):
2437 Rename or remove local vars to avoid shadowing.
2438 (Ftranslate_region_internal): Mark var as initialized.
2440 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2443 * lisp.h (eassert): Check that the argument compiles, even if
2444 ENABLE_CHECKING is not defined.
2446 * data.c (Findirect_variable): Name an expression, to avoid
2447 gcc -Wbad-function-cast warning.
2448 (default_value, arithcompare, arith_driver, arith_error): Now static.
2449 (store_symval_forwarding): Rename local to avoid shadowing.
2450 (Fmake_variable_buffer_local, Fmake_local_variable):
2451 Mark variables as initialized.
2452 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2454 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2455 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2456 Rename locals to avoid shadowing.
2457 (mark_stack): Move local variables into the #ifdef region where
2459 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2460 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2462 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2463 (GC_STRING_CHARS): Remove; not used.
2464 (Fmemory_limit): Cast sbrk's returned value to char *.
2466 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2467 avoids undefined behavior in theory.
2469 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2471 Use functions, not macros, for up- and down-casing (Bug#8254).
2472 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2474 to use the following functions instead of these macros.
2475 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2476 EMACS_INT, since callers assume the returned value fits in int.
2477 (upcase1): Likewise, for UPCASE_TABLE.
2478 (uppercasep, lowercasep, upcase): New static inline functions.
2479 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2480 the race-condition problem in the old DOWNCASE.
2482 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2483 Rename locals to avoid shadowing.
2484 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2485 (regex_compile, re_search_2, re_match_2_internal):
2486 Remove unused local vars.
2487 (FREE_VAR): Rewrite so as not to use empty "else",
2488 which gcc can warn about.
2489 (regex_compile, re_match_2_internal): Mark locals as initialized.
2490 (RETALLOC_IF): Define only if needed.
2491 (WORDCHAR_P): Likewise. This one is never needed, but is used
2492 only in a comment talking about a compiler bug, so put inside
2493 the #if 0 of that comment.
2494 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2495 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2498 * search.c (boyer_moore): Rename locals to avoid shadowing.
2499 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2500 (PREV_CHAR_BOUNDARY): Likewise.
2502 * search.c (simple_search): Remove unused var.
2504 * dired.c (compile_pattern): Move decl from here ...
2505 * lisp.h: ... to here, so that it can be checked.
2506 (struct re_registers): New forward decl.
2508 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2510 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2512 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2513 Rename locals to avoid shadowing.
2514 (Fvertical_motion): Mark locals as initialized.
2516 * casefiddle.c (casify_object, casify_region): Now static.
2517 (casify_region): Mark local as initialized.
2519 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2521 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2522 New macros, so that the caller can use some names other than
2523 gcpro1, gcpro2, etc.
2524 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2526 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2527 argument, for consistency with GCPRO2_VAR, etc: it is now the
2528 prefix of the variable, not the variable itself. All uses
2530 * dired.c (directory_files_internal, file_name_completion):
2531 Rename locals to avoid shadowing.
2533 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2534 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2535 dired.c's scmp function, had undefined behavior.
2536 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2537 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2538 * buffer.h: ... to here, because these macros use current_buffer,
2539 and the new implementation with inline functions needs to have
2540 current_buffer in scope now, rather than later when the macros
2542 (downcase, upcase1): New static inline functions.
2543 (DOWNCASE, UPCASE1): Reimplement using these functions.
2544 This avoids undefined behavior in expressions like
2545 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2546 from race conditions in accessing the global variables
2547 case_temp1 and case_temp2.
2548 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2549 * lisp.h (case_temp1, case_temp2): Remove their decls.
2550 * character.h (ASCII_CHAR_P): Move from here ...
2551 * lisp.h: ... to here, so that the inline functions mentioned
2554 * dired.c (directory_files_internal_unwind): Now static.
2556 * fileio.c (file_name_as_directory, directory_file_name):
2557 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2559 (file_name_as_directory): Use const pointers when appropriate.
2560 (Fexpand_file_name): Likewise. In particular, newdir might
2561 point at constant storage, so make it a const pointer.
2562 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2563 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2565 (Fset_file_times, Finsert_file_contents, auto_save_error):
2566 Rename locals to avoid shadowing.
2568 * minibuf.c (choose_minibuf_frame_1): Now static.
2569 (Ftry_completion, Fall_completions): Rename or remove locals
2572 * marker.c (bytepos_to_charpos): Remove; unused.
2574 * lisp.h (verify_bytepos, count_markers): New decls,
2575 so that gcc does not warn that these functions aren't declared.
2577 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2578 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2579 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2580 (copy_text): Remove unused local var.
2582 * filelock.c (within_one_second): Now static.
2583 (lock_file_1): Rename local to avoid shadowing.
2585 * buffer.c (fix_overlays_before): Mark locals as initialized.
2586 (fix_start_end_in_overlays): Likewise. This function should be
2587 simplified by using pointers-to-pointers, but that's a different
2589 (switch_to_buffer_1): Now static.
2590 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2591 (report_overlay_modification): Rename locals to avoid shadowing.
2593 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2594 Fix pointer signedness issue.
2595 (sys_subshell): Mark local as volatile if checking for lint,
2596 to suppress a gcc -Wclobbered warning that does not seem to be right.
2597 (MAXPATHLEN): Define only if needed.
2599 * process.c (serial_open, serial_configure): Move decls from here ...
2600 * systty.h: ... to here, so that they can be checked.
2602 * fns.c (get_random, seed_random): Move extern decls from here ...
2603 * lisp.h: ... to here, so that they can be checked.
2605 * sysdep.c (reset_io): Now static.
2606 (wait_for_termination_signal): Remove; unused.
2608 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2609 (copy_keymap_item, append_key, push_text_char_description):
2611 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2612 (DENSE_TABLE_SIZE): Remove; unused.
2613 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2614 (describe_map_tree):
2615 Rename locals to avoid shadowing.
2617 * keyboard.c: Declare functions static if they are not used elsewhere.
2618 (echo_char, echo_dash, cmd_error, top_level_2):
2619 (poll_for_input, handle_async_input): Now static.
2620 (read_char, kbd_buffer_get_event, make_lispy_position):
2621 (make_lispy_event, make_lispy_movement, apply_modifiers):
2622 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2623 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2624 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2625 (read_key_sequence, read_char): Mark locals as initialized.
2626 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2628 * keyboard.h (make_ctrl_char): New decl.
2629 (mark_kboards): Move decl here ...
2630 * alloc.c (mark_kboards): ... from here.
2632 * lisp.h (force_auto_save_soon): New decl.
2634 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2635 (DEFINE_DUMMY_FUNCTION): New macro.
2636 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2638 (main): Add casts to avoid warnings
2639 if GCC considers string literals to be constants.
2641 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2643 * dbusbind.c: Pointer signedness fixes.
2644 (xd_signature, xd_append_arg, xd_initialize):
2645 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2646 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2647 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2648 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2650 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2651 if GCC considers string literals to be constants.
2652 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2654 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2656 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2657 (print_preprocess, print_object): New macro to fix last change.
2659 * print.c (print_preprocess): Don't forget font objects.
2661 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2663 * emacs.c (USAGE3): Doc fixes.
2665 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2667 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2670 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2672 * lisp.h (VWindow_system, Qfile_name_history):
2673 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2674 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2675 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2677 * w32select.c: Don't #include "keyboard.h".
2678 (run_protected): Add extern declaration for waiting_for_input.
2680 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2681 * w32console.c (detect_input_pending, read_input_pending)
2682 (encode_terminal_code):
2683 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2684 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2685 (w32_system_caret_y, Qfile_name_history):
2686 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2687 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2688 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2689 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2690 * w32proc.c (Qlocal, report_file_error):
2691 * w32term.c (Vwindow_system, updating_frame):
2692 * w32uniscribe.c (initialized, uniscribe_font_driver):
2693 Remove unneeded extern declarations.
2695 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2697 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2699 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2701 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2702 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2703 These macros can no longer be used for assignment.
2705 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2706 Assign struct members directly, instead of using BUF_BEGV etc.
2707 (record_buffer_markers, fetch_buffer_markers): New functions for
2708 recording and fetching special buffer markers.
2709 (set_buffer_internal_1, set_buffer_temp): Use them.
2711 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2713 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2715 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2716 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2718 * xdisp.c (hscroll_window_tree):
2719 (reconsider_clip_changes): Use PT instead of BUF_PT.
2721 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2723 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2724 $(EMACS_ROOT)/lib/intprops.h.
2726 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2728 Fix more problems found by GCC 4.5.2's static checks.
2730 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2731 to unsigned char * to avoid compiler diagnostic.
2732 (xg_free_frame_widgets): Make it clear that a local variable is
2733 needed only if USE_GTK_TOOLTIP.
2734 (gdk_window_get_screen): Make it clear that this macro is needed
2735 only if USE_GTK_TOOLTIP.
2736 (int_gtk_range_get_value): New function, which avoids a diagnostic
2737 from gcc -Wbad-function-cast.
2738 (xg_set_toolkit_scroll_bar_thumb): Use it.
2739 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2740 diagnostic from gcc -Wbad-function-cast.
2741 (get_utf8_string, xg_get_file_with_chooser):
2742 Rename locals to avoid shadowing.
2743 (create_dialog): Move locals to avoid shadowing.
2745 * xgselect.c (xg_select): Remove unused var.
2747 * image.c (four_corners_best): Mark locals as initialized.
2748 (gif_load): Initialize transparent_p to zero (Bug#8238).
2749 Mark another local as initialized.
2750 (my_png_error, my_error_exit): Mark with NO_RETURN.
2752 * image.c (clear_image_cache): Now static.
2753 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2754 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2755 (x_edge_detection): Remove unnecessary cast that
2756 gcc -Wbad-function-cast diagnoses.
2757 (gif_load): Fix pointer signedness.
2758 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2759 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2761 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2763 Improve quality of tests for time stamp overflow.
2764 For example, without this patch (encode-time 0 0 0 1 1
2765 1152921504606846976) returns the obviously-bogus value (-948597
2766 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2767 reports time overflow. See
2768 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2769 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2770 * editfns.c: Include limits.h and intprops.h.
2771 (TIME_T_MIN, TIME_T_MAX): New macros.
2772 (time_overflow): Move earlier, to before first use.
2773 (hi_time, lo_time): New functions, for an accurate test for
2775 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2776 (Fget_internal_run_time): Don't assume time_t fits in int.
2777 (make_time): Use list2 instead of Fcons twice.
2778 (Fdecode_time): More accurate test for out-of-range times.
2779 (check_tm_member): New function.
2780 (Fencode_time): Use it, to test for out-of-range times.
2781 (lisp_time_argument): Don't rely on undefined left-shift and
2782 right-shift behavior when checking for time stamp overflow.
2784 * editfns.c (time_overflow): New function, refactoring common code.
2785 (Fformat_time_string, Fdecode_time, Fencode_time):
2786 (Fcurrent_time_string): Use it.
2788 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2789 * dired.c (make_time): Move to ...
2790 * editfns.c (make_time): ... here.
2791 * systime.h: Note the move.
2793 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2795 * fringe.c (update_window_fringes): Remove unused variables.
2797 * unexmacosx.c (copy_data_segment): Also copy __got section.
2800 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2802 * termcap.c [MSDOS]: Include "msdos.h".
2803 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2804 Constify `char *' arguments and their references according to
2805 prototypes in tparam.h.
2807 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2809 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2810 Adapt all references accordingly.
2812 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2814 2011-03-11 Tom Tromey <tromey@redhat.com>
2816 * buffer.c (syms_of_buffer): Remove obsolete comment.
2818 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2820 * termhooks.h (encode_terminal_code): Declare prototype.
2822 * msdos.c (encode_terminal_code): Don't declare prototype.
2824 * term.c (encode_terminal_code): Now external again, used by
2825 w32console.c and msdos.c.
2827 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2828 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2830 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2832 Fix some minor problems found by GCC 4.5.2's static checks.
2834 * fringe.c (update_window_fringes): Mark locals as initialized
2836 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2838 * alloc.c (mark_fringe_data): Move decl from here ...
2839 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2840 to check its interface.
2841 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2843 * fontset.c (free_realized_fontset): Now static.
2844 (Fset_fontset_font): Rename local to avoid shadowing.
2845 (fontset_font): Mark local as initialized.
2846 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2848 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2850 * xselect.c (x_disown_buffer_selections): Remove; not used.
2851 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2852 (x_own_selection, Fx_disown_selection_internal): Rename locals
2854 (x_handle_dnd_message): Remove local to avoid shadowing.
2856 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2857 so that the caller can use some name other than gcpro1.
2858 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2859 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2860 (Fx_backspace_delete_keys_p):
2861 Use them to avoid shadowing, and rename vars to avoid shadowing.
2862 (x_decode_color, x_set_name, x_window): Now static.
2863 (Fx_create_frame): Add braces to silence GCC warning.
2864 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2865 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2866 Remove unused locals.
2867 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2868 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2869 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2872 * xterm.h (x_mouse_leave): New decl.
2874 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2875 Remove unused functions.
2876 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2877 (x_calc_absolute_position): Now static.
2878 (XTread_socket): Don't define label "out" unless it's used.
2879 Don't declare local "event" unless it's used.
2880 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2881 unless they are used.
2882 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2883 (x_fatal_error_signal): Remove; not used.
2884 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2885 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2886 (x_error_catcher, x_connection_closed, x_error_handler):
2887 (x_error_quitter, xembed_send_message, x_iconify_frame):
2888 (my_log_handler): Rename locals to avoid shadowing.
2889 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2890 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2892 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2893 Rename or move locals to avoid shadowing.
2894 (tty_defined_color, merge_face_heights): Now static.
2895 (free_realized_faces_for_fontset): Remove; not used.
2896 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2897 does not deduce is never used uninitialized.
2898 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2899 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2901 * terminal.c (store_terminal_param): Now static.
2903 * xmenu.c (menu_highlight_callback): Now static.
2904 (set_frame_menubar): Remove unused local.
2905 (xmenu_show): Rename parameter to avoid shadowing.
2906 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2907 since they might point to immutable storage.
2908 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2909 since it's unused otherwise.
2911 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2912 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2913 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2914 avoids a gcc -Wuninitialized diagnostic.
2915 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2916 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2917 does not deduce are never used uninitialized.
2919 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2921 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2922 * window.c (window_loop, size_window):
2923 (run_window_configuration_change_hook, enlarge_window): Likewise.
2925 * window.c (display_buffer): Now static.
2926 (size_window): Mark variables that gcc -Wuninitialized
2927 does not deduce are never used uninitialized.
2928 * window.h (check_all_windows): New decl, to forestall
2929 gcc -Wmissing-prototypes diagnostic.
2930 * dispextern.h (bidi_dump_cached_states): Likewise.
2932 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2934 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2936 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2937 and to avoid gcc -Wuninitialized warning.
2938 (load_charset_map): Mark variables that gcc -Wuninitialized
2939 does not deduce are never used uninitialized.
2940 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2942 * coding.c (coding_set_source, coding_set_destination):
2943 Use "else { /* comment */ }" rather than "else /* comment */;"
2944 for clarity, and to avoid gcc -Wempty-body warning.
2945 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2946 a block, when the outer 'i' will do.
2947 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2948 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2949 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2950 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2951 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2952 Rename locals to avoid shadowing.
2953 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2954 * coding.c (emacs_mule_char, encode_invocation_designation):
2955 Now static, since they're not used elsewhere.
2956 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2957 (decode_coding_object, encode_coding_object, detect_coding_system):
2958 (decode_coding_emacs_mule): Mark variables that gcc
2959 -Wuninitialized does not deduce are never used uninitialized.
2960 (detect_coding_iso_2022): Initialize a local variable that might
2961 be used uninitialized. Leave a FIXME because it's not clear that
2962 this initialization is needed. (Bug#8211)
2963 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2964 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2965 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2966 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2967 Remove unused macros.
2969 * category.c (hash_get_category_set): Remove unused local var.
2970 (copy_category_table): Now static, since it's not used elsewhere.
2971 * character.c (string_count_byte8): Likewise.
2973 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2974 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2976 * chartab.c (copy_sub_char_table): Now static, since it's not used
2978 (sub_char_table_ref_and_range, char_table_ref_and_range):
2979 Rename locals to avoid shadowing.
2980 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2982 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2983 (BIDI_BOB): Remove unused macro.
2985 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2986 deduce are never used uninitialized.
2987 * term.c (encode_terminal_code): Likewise.
2989 * term.c (encode_terminal_code): Now static. Remove unused local.
2991 * tparam.h: New file.
2992 * term.c, tparam.h: Include it.
2993 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2994 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2995 Move these decls to tparam.h, and make them agree with what
2996 is actually in tparam.c. The previous trick of using incompatible
2997 decls in different modules does not conform to the C standard.
2998 All callers of tparam changed to use tparam's actual API.
2999 * tparam.c (tparam1, tparam, tgoto):
3000 Use const pointers where appropriate.
3002 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3003 * cm.h (struct cm): Likewise.
3004 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3005 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3006 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3007 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3008 (turn_on_face, init_tty): Likewise.
3009 * termchar.h (struct tty_display_info): Likewise.
3011 * term.c (term_mouse_position): Rename local to avoid shadowing.
3013 * alloc.c (mark_ttys): Move decl from here ...
3014 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3016 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3018 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3020 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3022 * search.c (compile_pattern_1): Remove argument regp, unused since
3023 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3024 (compile_pattern): Don't pass it.
3026 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3028 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3029 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3031 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3033 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3035 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3036 gdk_window_get_screen, gdk_window_get_geometry,
3037 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3038 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3039 (xg_get_pixbuf_from_pixmap): New function.
3040 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3041 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3042 Call xg_get_pixbuf_from_pixmap instead of
3043 gdk_pixbuf_get_from_drawable.
3044 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3045 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3046 (xg_check_special_colors): Use GtkStyleContext and its functions
3048 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3049 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3050 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3051 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3052 Call gtk_widget_get_preferred_size.
3053 (xg_frame_resized): gdk_window_get_geometry only takes 5
3055 (xg_win_to_widget, xg_event_is_for_menubar):
3056 Call gdk_x11_window_lookup_for_display.
3057 (xg_set_widget_bg): New function.
3058 (delete_cb): New function.
3059 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3060 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3061 (xg_set_background_color): Call xg_set_widget_bg.
3062 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3063 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3064 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3065 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3067 (update_frame_tool_bar): Call gtk_widget_hide.
3068 (xg_initialize): Use GDK_KEY_g.
3070 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3072 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3074 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3075 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3076 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3078 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3080 * w32xfns.c (select_palette): Check success of RealizePalette against
3081 GDI_ERROR, not zero.
3083 See ChangeLog.11 for earlier changes.
3089 Copyright (C) 2011 Free Software Foundation, Inc.
3091 This file is part of GNU Emacs.
3093 GNU Emacs is free software: you can redistribute it and/or modify
3094 it under the terms of the GNU General Public License as published by
3095 the Free Software Foundation, either version 3 of the License, or
3096 (at your option) any later version.
3098 GNU Emacs is distributed in the hope that it will be useful,
3099 but WITHOUT ANY WARRANTY; without even the implied warranty of
3100 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3101 GNU General Public License for more details.
3103 You should have received a copy of the GNU General Public License
3104 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.