1 2011-04-24 Paul Eggert <eggert@cs.ucla.edu>
3 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5 2011-04-21 Paul Eggert <eggert@cs.ucla.edu>
7 Make the Lisp reader and string-to-float more consistent.
8 * data.c (atof): Remove decl; no longer used or needed.
9 (digit_to_number): Move to lread.c.
10 (Fstring_to_number): Use new string_to_number function, to be
11 consistent with how the Lisp reader treats infinities and NaNs.
12 Do not assume that floating-point numbers represent EMACS_INT
13 without losing information; this is not true on most 64-bit hosts.
14 Avoid double-rounding errors, by insisting on integers when
15 parsing non-base-10 numbers, as the documentation specifies.
16 * lisp.h (string_to_number): New decl, replacing ...
17 (isfloat_string): Remove.
18 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
19 (read1): Do not accept +. and -. as integers; this
20 appears to have been a coding error. Similarly, do not accept
21 strings like +-1e0 as floating point numbers. Do not report
22 overflow for integer overflows unless the base is not 10 which
23 means we have no simple and reliable way to continue.
24 Break out the floating-point parsing into a new
25 function string_to_number, so that Fstring_to_number parses
26 floating point numbers consistently with the Lisp reader.
27 (digit_to_number): Moved here from data.c. Make it static inline.
28 (E_CHAR, EXP_INT): Remove, replacing with ...
29 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
30 (string_to_number): New function, replacing isfloat_string.
31 This function checks for valid syntax and produces the resulting
32 Lisp float number too. Rework it so that string-to-number
33 no longer mishandles examples like "1.0e+". Use strtoumax,
34 so that overflow for non-base-10 numbers is reported only when
35 there's no portable and simple way to convert to floating point.
37 2011-04-20 Paul Eggert <eggert@cs.ucla.edu>
39 * textprop.c (set_text_properties_1): Rewrite for clarity,
40 and to avoid GCC warning about integer overflow.
42 * intervals.h (struct interval): Use EMACS_INT for members
43 where EMACS_UINT might cause problems. See
44 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
45 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
46 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
48 (offset_intervals): Tell GCC not to worry about length overflow
49 when negating a negative length.
51 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
52 (overrun_check_free): Likewise.
54 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
55 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
58 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
59 (gnutls_make_error): Rename local to avoid shadowing.
60 (gnutls_emacs_global_deinit): ifdef out; not used.
61 (Fgnutls_boot): Use const for pointer to readonly storage.
62 Comment out unused local. Fix pointer signedness problems.
64 * lread.c (openp): Don't stuff size_t into an 'int'.
65 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
66 about possible signed overflow.
68 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
69 (GDK_KEY_g): Don't define if already defined.
70 (xg_prepare_tooltip): Avoid pointer signedness problem.
71 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
73 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
74 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
76 * xfns.c (Fx_window_property): Simplify a bit,
77 to make a bit faster and to avoid GCC 4.6.0 warning.
78 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
80 * fns.c (internal_equal): Don't assume size_t fits in int.
82 * alloc.c (compact_small_strings): Tighten assertion a little.
84 Replace pEd with more-general pI, and fix some printf arg casts.
85 * lisp.h (pI): New macro, generalizing old pEd macro to other
86 conversion specifiers. For example, use "...%"pI"d..." rather
88 (pEd): Remove. All uses replaced with similar uses of pI.
89 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
90 * alloc.c (check_pure_size): Don't overflow by converting size to int.
91 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
92 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
93 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
94 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
95 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
97 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
98 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
99 * print.c (safe_debug_print, print_object): Likewise.
100 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
102 Use pI instead of if-then-else-abort. Use %p to avoid casts,
103 avoiding the 0 flag, which is not portable.
104 * process.c (Fmake_network_process): Use pI to avoid cast.
105 * region-cache.c (pp_cache): Likewise.
106 * xdisp.c (decode_mode_spec): Likewise.
107 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
108 behavior on 64-bit hosts with printf arg.
109 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
110 (x_stop_queuing_selection_requests): Likewise.
111 (x_get_window_property): Don't truncate byte count to an 'int'
114 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
115 here, since it parses constructs like leading '-' and spaces,
116 which are not wanted; and it overflows with large numbers.
117 Instead, simply match F[0-9]+, which is what is wanted anyway.
119 * alloc.c: Remove unportable assumptions about struct layout.
120 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
121 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
122 (allocate_vectorlike, make_pure_vector): Use the new macros,
123 plus offsetof, to remove unportable assumptions about struct layout.
124 These assumptions hold on all porting targets that I know of, but
125 they are not guaranteed, they're easy to remove, and removing them
126 makes further changes easier.
128 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
129 This doesn't fix a bug but makes the code clearer.
130 (string_overrun_cookie): Now const. Use initializers that
131 don't formally overflow signed char, to avoid warnings.
132 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
133 can cause Emacs to crash when string overrun checking is enabled.
134 (allocate_buffer): Don't assume sizeof (struct buffer) is a
135 multiple of sizeof (EMACS_INT); it need not be, if
136 alignof(EMACS_INT) < sizeof (EMACS_INT).
137 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
139 2011-04-19 Eli Zaretskii <eliz@gnu.org>
141 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
142 gl_state.e_property when gl_state.object is Qt.
144 * insdel.c (make_gap_larger): Remove limitation of buffer size
147 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
149 * xdisp.c (lookup_glyphless_char_display)
150 (produce_glyphless_glyph): Handle cons cell entry in
151 glyphless-char-display.
152 (Vglyphless_char_display): Document it.
154 * term.c (produce_glyphless_glyph): Handle cons cell entry in
155 glyphless-char-display.
157 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
159 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
161 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
163 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
164 definition for no-X builds.
166 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
168 Static checks with GCC 4.6.0 and non-default toolkits.
170 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
172 * process.c (keyboard_bit_set): Define only if SIGIO.
173 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
174 (send_process): Repair possible setjmp clobbering.
176 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
178 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
180 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
182 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
183 Define only if needed.
185 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
186 by pacifying GCC about it. Maybe it's time to retire it?
187 * xfaces.c (USG, __TIMEVAL__): Likewise.
189 * dispextern.h (struct redisplay_interface): Rename param
191 * termhooks.h (struct terminal): Likewise.
192 * xterm.c (xembed_send_message): Likewise.
194 * insdel.c (make_gap_smaller): Define only if
195 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
197 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
200 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
201 so that we aren't warned about unused symbols.
203 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
205 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
207 * xfns.c (x_real_positions): Mark locals as initialized.
209 * xmenu.c (xmenu_show): Don't use uninitialized vars.
211 * xterm.c: Fix problems found by static analysis with other toolkits.
212 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
213 (x_dispatch_event): Declare static if USE_GTK, and
214 define if USE_GTK || USE_X_TOOLKIT.
215 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
216 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
217 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
218 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
220 * xmenu.c (menu_help_callback): Pointer type fixes.
221 Use const pointers when pointing at readonly data. Avoid pointer
223 (FALSE): Remove unused macro.
224 (update_frame_menubar): Remove unused decl.
226 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
228 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
229 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
230 (single_menu_item): Rename local to avoid shadowing.
232 * keyboard.c (make_lispy_event): Remove unused local var.
234 * frame.c, frame.h (x_get_resource_string): Bring this back, but
235 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
237 * bitmaps: Change bitmaps from unsigned char back to the X11
238 compatible char. Avoid the old compiler warnings about
239 out-of-range initializers by using, for example, '\xab' rather
242 * xgselect.c (xgselect_initialize): Check vs interface
243 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
245 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
247 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
250 * fns.c (vector): Remove; this old hack is no longer needed.
252 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
254 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
256 * xrdb.c (x_load_resources): Omit unused local.
258 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
259 (x_window): Rename locals to avoid shadowing.
260 (USG): Use the kludged USG macro, to pacify gcc.
262 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
263 (x_term_init): Remove local to avoid shadowing.
265 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
267 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
268 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
270 2011-04-16 Eli Zaretskii <eliz@gnu.org>
272 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
274 Fix regex.c, syntax.c and friends for buffers > 2GB.
275 * syntax.h (struct gl_state_s): Declare character position members
278 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
280 * textprop.c (verify_interval_modification, interval_of): Declare
283 * intervals.c (adjust_intervals_for_insertion): Declare arguments
286 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
288 * indent.c (Fvertical_motion): Local variable it_start is now
291 * regex.c (re_match, re_match_2, re_match_2_internal)
292 (bcmp_translate, regcomp, regexec, print_double_string)
293 (group_in_compile_stack, re_search, re_search_2, regex_compile)
294 (re_compile_pattern, re_exec): Declare arguments and local
295 variables `size_t' and `ssize_t' and return values `regoff_t', as
297 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
298 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
299 <compile_stack_type>: `size' and `avail' are now `size_t'.
301 * regex.h <regoff_t>: Use ssize_t, not int.
302 (re_search, re_search_2, re_match, re_match_2): Arguments that
303 specify buffer/string position and length are now ssize_t and
304 size_t. Return type is regoff_t.
306 2011-04-16 Ben Key <bkey76@gmail.com>
308 * nsfont.m: Fixed bugs in ns_get_family and
309 ns_descriptor_to_entity that were caused by using free to
310 deallocate memory blocks that were allocated by xmalloc (via
311 xstrdup). This caused Emacs to crash when compiled with
312 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
313 --enable-checking=xmallocoverrun). xfree is now used to
314 deallocate these memory blocks.
316 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
318 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
320 emacs_write: Accept and return EMACS_INT for sizes.
321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
323 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
324 Accept and return EMACS_INT.
325 (emacs_gnutls_write): Return the number of bytes written on
327 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
328 (emacs_read, emacs_write): Remove check for negative size, as the
329 Emacs source code has been audited now.
330 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
331 (emacs_read, emacs_write): Use it.
332 * process.c (send_process): Adjust to the new signatures of
333 emacs_write and emacs_gnutls_write. Do not attempt to store
334 a byte offset into an 'int'; it might overflow.
335 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
337 * sound.c: Don't assume sizes fit in 'int'.
338 (struct sound_device.period_size, alsa_period_size):
339 Return EMACS_INT, not int.
340 (struct sound_device.write, vox_write, alsa_write):
341 Accept EMACS_INT, not int.
342 (wav_play, au_play): Use EMACS_INT to store sizes and to
343 record read return values.
345 2011-04-15 Ben Key <bkey76@gmail.com>
347 * keyboard.c (Qundefined): Don't declare static since it is used
349 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
350 static since they are used in nsfont.m.
352 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
354 * process.c (Qprocessp): Don't declare static.
355 * lisp.h (Qprocessp): Declare again.
357 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
359 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
361 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
363 Improve C-level modularity by making more things 'static'.
365 Don't publish debugger-only interfaces to other modules.
366 * lisp.h (safe_debug_print, debug_output_compilation_hack):
367 (verify_bytepos, count_markers): Move decls to the only modules
369 * region-cache.h (pp_cache): Likewise.
370 * window.h (check_all_windows): Likewise.
371 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
373 * sysdep.c (croak): Now static, if
374 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
375 * syssignal.h (croak): Declare only if not static.
377 * alloc.c (refill_memory_reserve): Now static if
378 !defined REL_ALLOC || defined SYSTEM_MALLOC.
379 * lisp.h (refill_memory_reserve): Declare only if not static.
381 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
382 Define only if USE_LUCID.
384 * xrdb.c (x_customization_string, x_rm_string): Now static.
386 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
387 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
389 * xdisp.c (draw_row_with_mouse_face): Now static.
390 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
392 * window.h (check_all_windows): Mark externally visible.
394 * window.c (window_deletion_count): Now static.
396 * undo.c: Make symbols static if they're not exported.
397 (last_undo_buffer, last_boundary_position, pending_boundary):
400 * textprop.c (interval_insert_behind_hooks): Now static.
401 (interval_insert_in_front_hooks): Likewise.
403 * term.c: Make symbols static if they're not exported.
404 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
405 (max_frame_lines, tty_set_terminal_modes):
406 (tty_reset_terminal_modes, tty_turn_off_highlight):
407 (get_tty_terminal): Now static.
408 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
409 * termhooks.h (term_mouse_moveto): Do not declare if
411 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
412 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
414 * sysdep.c: Make symbols static if they're not exported.
415 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
417 (sigprocmask_set, full_mask): Remove; unused.
418 (wait_debugging): Mark as visible.
419 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
420 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
422 * syntax.c (syntax_temp): Define only if !__GNUC__.
424 * sound.c (current_sound_device, current_sound): Now static.
426 * search.c (searchbufs, searchbuf_head): Now static.
428 * scroll.c (scroll_cost): Remove; unused.
429 * dispextern.h (scroll_cost): Remove decl.
431 * region-cache.h (pp_cache): Mark as externally visible.
433 * process.c: Make symbols static if they're not exported.
434 (process_tick, update_tick, create_process, chan_process):
435 (Vprocess_alist, proc_buffered_char, datagram_access):
436 (fd_callback_data, send_process_frame, process_sent_to): Now static.
437 (deactivate_process): Mark defn as static, as well as decl.
438 * lisp.h (create_process): Remove decl.
439 * process.h (chan_process, Vprocess_alist): Remove decls.
441 * print.c: Make symbols static if they're not exported.
442 (print_depth, new_backquote_output, being_printed, print_buffer):
443 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
444 (print_interval, print_number_index, initial_stderr_stream):
446 * lisp.h (Fprinc): Remove decl.
447 (debug_output_compilation_hack): Mark as externally visible.
449 * sysdep.c (croak): Move decl from here to syssignal.h.
450 * syssignal.h (croak): Put it here, so the API can be checked when
451 'croak' is called from dissociate_if_controlling_tty.
453 * minibuf.c: Make symbols static if they're not exported.
454 (minibuf_save_list, choose_minibuf_frame): Now static.
455 * lisp.h (choose_minibuf_frame): Remove decl.
457 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
459 * lread.c: Make symbols static if they're not exported.
460 (read_objects, initial_obarray, oblookup_last_bucket_number):
462 (make_symbol): Remove; unused.
463 * lisp.h (initial_obarray, make_symbol): Remove decls.
465 * keyboard.c: Make symbols static if they're not exported.
466 (single_kboard, recent_keys_index, total_keys, recent_keys):
467 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
468 (this_single_command_key_start, echoing, last_auto_save):
469 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
470 (command_loop, echo_now, keyboard_init_hook, help_char_p):
471 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
472 (Vlispy_mouse_stem, double_click_count):
474 (force_auto_save_soon): Define only if SIGDANGER.
475 (ignore_mouse_drag_p): Now static if
476 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
477 (print_help): Remove; unused.
478 (stop_character, last_timer_event): Mark as externally visible.
479 * keyboard.h (ignore_mouse_drag_p): Declare only if
480 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
481 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
482 * lisp.h (echoing): Remove decl.
483 (force_auto_save_soon): Declare only if SIGDANGER.
484 * xdisp.c (redisplay_window): Simplify code, to make it more
485 obvious that ignore_mouse_drag_p is not accessed if !defined
486 USE_GTK && !defined HAVE_NS.
488 * intervals.c: Make symbols static if they're not exported.
489 (merge_properties_sticky, merge_interval_right, delete_interval):
491 * intervals.h (merge_interval_right, delete_interval): Remove decls.
493 * insdel.c: Make symbols static if they're not exported.
494 However, leave prepare_to_modify_buffer alone. It's never
495 called from outside this function, but that appears to be a bug.
496 (combine_after_change_list, combine_after_change_buffer):
497 (adjust_after_replace, signal_before_change): Now static.
498 (adjust_after_replace_noundo): Remove; unused.
499 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
500 (signal_before_change): Remove decls.
502 * indent.c (val_compute_motion, val_vmotion): Now static.
504 * image.c: Make symbols static if they're not exported.
505 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
507 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
508 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
510 * fringe.c (standard_bitmaps): Now static.
511 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
513 * frame.c: Make symbols static if they're not exported.
514 (x_report_frame_params, make_terminal_frame): Now static.
515 (get_frame_param): Now static, unless HAVE_NS.
516 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
517 (x_get_resource_string): Remove; not used.
518 * frame.h (make_terminal_frame, x_report_frame_params):
519 (x_get_resource_string); Remove decls.
520 (x_fullscreen_adjust): Declare only if WINDOWSNT.
521 * lisp.h (get_frame_param): Declare only if HAVE_NS.
523 * font.c, fontset.c: Make symbols static if they're not exported.
524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
525 (FACE_SUITABLE_FOR_CHAR_P): Use it.
526 * font.c (font_close_object): Now static.
527 * font.h (font_close_object): Remove.
528 * fontset.c (FONTSET_OBJLIST): Remove.
529 (free_realized_fontset) #if-0 the body, which does nothing.
530 (face_suitable_for_char_p): #if-0, as it's never called.
531 * fontset.h (face_suitable_for_char_p): Remove decl.
532 * xfaces.c (face_at_string_position): Use
533 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
534 since 0 is always ASCII.
536 * fns.c (weak_hash_tables): Now static.
538 * fileio.c: Make symbols static if they're not exported.
539 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
540 (Vwrite_region_annotation_buffers): Now static.
542 * eval.c: Make symbols static if they're not exported.
543 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
544 * lisp.h (backtrace_list): Remove decl.
546 * emacs.c: Make symbols static if they're not exported.
547 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
548 (fatal_error_code, fatal_error_signal_hook, standard_args):
550 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
551 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
552 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
553 * lisp.h (fatal_error_signal_hook): Remove decl.
554 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
556 * editfns.c: Move a (normally-unused) function to its only use.
557 * editfns.c, lisp.h (get_operating_system_release): Remove.
558 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
559 worth the hassle of breaking this out.
561 * xterm.c: Make symbols static if they're not exported.
562 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
563 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
564 (x_destroy_window, x_delete_display):
566 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
567 (x_mouse_leave): Remove; unused.
568 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
569 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
570 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
572 (x_mouse_leave): Declare only if WINDOWSNT.
573 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
574 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
577 * ftxfont.c: Make symbols static if they're not exported.
578 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
580 * font.h (ftxfont_driver): Likewise.
582 * xfns.c: Make symbols static if they're not exported.
583 (x_last_font_name, x_display_info_for_name):
584 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
585 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
586 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
587 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
588 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
589 (last_show_tip_args): Now static.
590 (xic_defaut_fontset, xic_create_fontsetname): Define only if
591 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
592 (x_screen_planes): Remove; unused.
593 * dispextern.h (x_screen_planes): Remove decl.
595 * dispnew.c: Make symbols static if they're not exported.
596 * dispextern.h (redraw_garbaged_frames, scrolling):
597 (increment_row_positions): Remove.
598 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
599 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
601 (redraw_garbaged_frames): Remove; unused.
603 * xfaces.c: Make symbols static if they're not exported.
604 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
606 * xterm.h (defined_color): Remove decls.
607 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
608 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
609 (menu_face_changed_default, defined_color, free_realized_face):
610 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
611 (ascii_face_of_lisp_face): Remove; unused.
613 * xdisp.c: Make symbols static if they're not exported.
614 * dispextern.h (scratch_glyph_row, window_box_edges):
615 (glyph_to_pixel_coords, set_cursor_from_row):
616 (get_next_display_element, set_iterator_to_next):
617 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
618 (show_mouse_face): Remove decls
619 * frame.h (message_buf_print): Likewise.
620 * lisp.h (pop_message, set_message, check_point_in_composition):
622 * xterm.h (set_vertical_scroll_bar): Likewise.
623 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
624 (message_buf_print, scratch_glyph_row, displayed_buffer):
625 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
626 (get_next_display_element, show_mouse_face, window_box_edges):
627 (frame_to_window_pixel_xy, check_point_in_composition):
628 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
629 (glyph_to_pixel_coords): Remove; unused.
631 * dired.c (file_name_completion): Now static.
633 * dbusbind.c (xd_in_read_queued_messages): Now static.
635 * lisp.h (circular_list_error, FOREACH): Remove; unused.
636 * data.c (circular_list_error): Remove.
638 * commands.h (last_point_position, last_point_position_buffer):
639 (last_point_position_window): Remove decls.
640 * keyboard.c: Make these variables static.
642 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
644 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
645 (iso_code_class, detect_coding, code_convert_region): Now static.
646 (encode_coding_gap): Remove; unused.
648 * chartab.c (chartab_chars, chartab_bits): Now static.
650 * charset.h (charset_iso_8859_1): Remove decl.
651 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
654 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
655 * ccl.c (Vccl_program_table): Now static.
656 (check_ccl_update): Remove; unused.
658 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
659 * category.h: ... from here.
660 * category.c (check_category_table, set_category_set): Now static.
662 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
663 * lisp.h: Remove these decls.
665 * buffer.c (buffer_count): Remove unused var.
667 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
668 so that it's not optimized away.
669 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
670 * dispextern.h (bidi_dump_cached_states): Remove, since it's
671 exported only to the debugger.
673 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
674 * atimer.h (run_all_atimers): Removed; not exported.
676 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
677 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
678 was inaccessible from Lisp.
679 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
680 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
682 alloc.c: Import and export fewer symbols, and remove unused items.
683 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
685 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
686 it's not optimized away by whole-program optimization.
687 (message_enable_multibyte, free_misc): Remove.
688 (catchlist, handlerlist, mark_backtrace):
689 Declare only if BYTE_MARK_STACK.
690 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
691 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
692 (message_enable_multibyte): Remove decl.
693 (free_misc, interval_free_list, float_block, float_block_index):
694 (n_float_blocks, float_free_list, cons_block, cons_block_index):
695 (cons_free_list, last_marked_index):
697 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
698 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
699 (mark_backtrace): Define only if BYTE_MARK_STACK.
700 * xdisp.c (message_enable_multibyte): Now static.
702 Declare Lisp_Object Q* variables to be 'static' if not exported.
703 This makes it easier for human readers (and static analyzers)
704 to see whether these variables are used from other modules.
705 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
706 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
707 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
708 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
709 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
710 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
711 * xmenu.c, xselect.c:
712 Declare Q* vars static if they are not used in other modules.
713 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
714 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
715 Remove decls of unexported vars.
716 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
718 * lisp.h (DEFINE_FUNC): Make sname 'static'.
720 Make Emacs functions such as Fatom 'static' by default.
721 This makes it easier for human readers (and static analyzers)
722 to see whether these functions can be called from other modules.
723 DEFUN now defines a static function. To make the function external
724 so that it can be used in other C modules, use the new macro DEFUE.
725 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
726 (Finit_image_library):
727 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
728 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
729 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
730 Remove decls, since these functions are now static.
731 (Funintern, Fget_internal_run_time): New decls, since these functions
732 were already external.
734 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
735 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
736 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
737 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
738 * keyboard.c, keymap.c, lread.c:
739 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
740 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
741 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
742 Mark functions with DEFUE instead of DEFUN,
743 if they are used in other modules.
744 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
745 decls for now-static functions.
746 * buffer.h (Fdelete_overlay): Remove decl.
747 * callproc.c (Fgetenv_internal): Mark as internal.
748 * composite.c (Fremove_list_of_text_properties): Remove decl.
749 (Fcomposition_get_gstring): New forward static decl.
750 * composite.h (Fcomposite_get_gstring): Remove decl.
751 * dired.c (Ffile_attributes): New forward static decl.
752 * doc.c (Fdocumntation_property): New forward static decl.
753 * eval.c (Ffetch_bytecode): New forward static decl.
754 (Funintern): Remove extern decl; now in .h file where it belongs.
755 * fileio.c (Fmake_symbolic_link): New forward static decl.
756 * image.c (Finit_image_library): New forward static decl.
757 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
758 * intervals.h (Fprevious_property_change):
759 (Fremove_list_of_text_properties): Remove decls.
760 * keyboard.c (Fthis_command_keys): Remove decl.
761 (Fcommand_execute): New forward static decl.
762 * keymap.c (Flookup_key): New forward static decl.
763 (Fcopy_keymap): Now static.
764 * keymap.h (Flookup_key): Remove decl.
765 * process.c (Fget_process): New forward static decl.
766 (Fprocess_datagram_address): Mark as internal.
767 * syntax.c (Fsyntax_table_p): New forward static decl.
768 (skip_chars): Remove duplicate decl.
769 * textprop.c (Fprevious_property_change): New forward static decl.
770 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
772 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
773 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
775 * editfns.c (Fformat): Remove unreachable code.
777 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
779 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
782 2011-04-13 Eli Zaretskii <eliz@gnu.org>
784 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
785 when at ZV. (Bug#8487)
787 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
789 * charset.c (Fclear_charset_maps): Use xfree instead of free.
791 * keyboard.c (parse_tool_bar_item): Likewise.
792 * sound.c (sound_cleanup, alsa_close): Likewise.
793 * termcap.c (tgetent): Likewise.
794 * xfns.c (x_default_font_parameter): Likewise.
795 * xsettings.c (read_and_apply_settings): Likewise.
797 * alloc.c (overrun_check_malloc, overrun_check_realloc)
798 (overrun_check_free): Protoize.
800 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
802 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
803 since callers should never pass a negative size.
804 Change the signature to match that of plain 'read' and 'write'; see
805 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
806 * lisp.h: Update prototypes of emacs_write and emacs_read.
808 2011-04-11 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (redisplay_window): Don't try to determine the character
811 position of the scroll margin if the window start point w->startp
812 is outside the buffer's accessible region. (Bug#8468)
814 2011-04-10 Eli Zaretskii <eliz@gnu.org>
816 Fix write-region and its subroutines for buffers > 2GB.
817 * fileio.c (a_write, e_write): Modify declaration of arguments and
818 local variables to support buffers larger than 2GB.
819 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
821 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
822 argument, local variables, and return value.
824 * lisp.h: Update prototypes of emacs_write and emacs_read.
826 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
828 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
830 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
832 Fix more problems found by GCC 4.6.0's static checks.
834 * xdisp.c (vmessage): Use a better test for character truncation.
836 * charset.c (load_charset_map): <, not <=, for optimization,
837 and to avoid potential problems with integer overflow.
838 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
839 * casetab.c (set_identity, shuffle): Likewise.
840 * editfns.c (Fformat): Likewise.
841 * syntax.c (skip_chars): Likewise.
843 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
844 This also lets GCC 4.6.0 generate slightly better loop code.
846 * callint.c (Fcall_interactively): <, not <=, for optimization.
847 (Fcall_interactively): Count the number of arguments produced,
848 not the number of arguments given. This is simpler and lets GCC
849 4.6.0 generate slightly better code.
851 * ftfont.c: Distingish more carefully between FcChar8 and char.
852 The previous code passed unsigned char * to a functions like
853 strlen and xstrcasecmp that expect char *, which does not
854 conform to the C standard.
855 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
856 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
857 char * when the C standard requires it.
859 * keyboard.c (read_char): Remove unused var.
861 * eval.c: Port to Windows vsnprintf (Bug#8435).
863 (SIZE_MAX): Define if the headers do not.
864 (verror): Do not give up if vsnprintf returns a negative count.
865 Instead, grow the buffer. This ports to Windows vsnprintf, which
866 does not conform to C99. Problem reported by Eli Zaretskii.
867 Also, simplify the allocation scheme, by avoiding the need for
868 calling realloc, and removing the ALLOCATED variable.
870 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
872 Remove invocations of doprnt, as Emacs now uses vsnprintf.
873 But keep the doprint source code for now, as we might revamp it
874 and use it again (Bug#8435).
875 * lisp.h (doprnt): Remove.
876 * Makefile.in (base_obj): Remove doprnt.o.
877 * deps.mk (doprnt.o): Remove.
879 error: Print 32- and 64-bit integers portably (Bug#8435).
880 Without this change, on typical 64-bit hosts error ("...%d...", N)
881 was used to print both 32- and 64-bit integers N, which relied on
883 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
885 * lisp.h (error, verror): Mark as printf-like functions.
886 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
887 Report overflow in size calculations when allocating printf buffer.
888 Do not truncate output string at its first null byte.
889 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
890 Truncate the output at a character boundary, since vsnprintf does not
892 * charset.c (check_iso_charset_parameter): Convert internal
893 character to string before calling 'error', since %c now has the
895 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
896 overflow when computing char to be passed to 'error'. Do not
897 pass Lisp_Object to 'error'; pass the integer instead.
898 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
899 formatted with plain %d.
901 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
903 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
905 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
907 * xterm.c (x_catch_errors): Remove duplicate declaration.
909 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
911 * xdisp.c, lisp.h (message_nolog): Remove; unused.
913 2011-04-10 Jim Meyering <meyering@redhat.com>
915 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
916 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
917 return ssize_t not "int", and use size_t as the buffer length.
918 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
919 * gnutls.h: Update declarations.
920 * process.c (read_process_output): Use ssize_t, to match.
921 (send_process): Likewise.
923 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
925 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
927 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
929 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
930 unsigned char, to match FcChar8 type definition.
932 * xterm.c (handle_one_xevent):
933 * xmenu.c (create_and_show_popup_menu):
934 * xselect.c (x_decline_selection_request)
935 (x_reply_selection_request): Avoid type-punned deref of X events.
937 2011-04-09 Eli Zaretskii <eliz@gnu.org>
939 Fix some uses of `int' instead of EMACS_INT.
940 * search.c (string_match_1, fast_string_match)
941 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
942 (scan_buffer, find_next_newline_no_quit)
943 (find_before_next_newline, search_command, Freplace_match)
944 (Fmatch_data): Make some `int' variables be EMACS_INT.
946 * xdisp.c (display_count_lines): 3rd argument and return value now
947 EMACS_INT. All callers changed.
948 (pint2hrstr): Last argument is now EMACS_INT.
950 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
951 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
952 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
953 (decode_coding_utf_16, decode_coding_emacs_mule)
954 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
955 (decode_coding_ccl, decode_coding_charset)
956 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
957 (decode_coding_iso_2022, decode_coding_emacs_mule)
958 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
959 <char_offset, last_offset>: Declare EMACS_INT.
960 (encode_coding_utf_8, encode_coding_utf_16)
961 (encode_coding_emacs_mule, encode_invocation_designation)
962 (encode_designation_at_bol, encode_coding_iso_2022)
963 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
964 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
966 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
967 (encode_invocation_designation): Last argument P_NCHARS is now
969 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
970 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
972 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
975 * ccl.c (Fccl_execute_on_string): Declare some variables
978 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
980 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
982 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
984 * process.c (Fformat_network_address): Doc fix.
986 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
988 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
990 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
992 * keyboard.c (read_char): Call Lisp function help-form-show,
993 instead of using internal_with_output_to_temp_buffer.
994 (Qhelp_form_show): New var.
995 (syms_of_keyboard): Use DEFSYM macro.
997 * print.c (internal_with_output_to_temp_buffer): Function deleted.
999 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1001 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1003 * process.c (Flist_processes): Removed to Lisp.
1004 (list_processes_1): Deleted.
1006 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1008 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1010 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1012 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1014 Fix more problems found by GCC 4.6.0's static checks.
1016 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1018 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1020 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1022 * xdisp.c (vmessage): Mark as a printf-like function.
1024 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1026 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1028 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1029 printf-like functions.
1030 (tiff_load): Add casts to remove these marks before passing them
1031 to system-supplied API.
1033 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1035 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1036 This avoids several warnings with gcc -Wstrict-overflow.
1037 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1038 directly, rather than having caller test rule sign. This avoids
1039 some unnecessary tests.
1040 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1041 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1042 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1044 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1045 (xfont_open): Avoid unnecessary tests.
1047 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1049 * composite.h, composite.c (composition_gstring_put_cache):
1050 Use EMACS_INT, not int, for length.
1052 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1053 breaking out part of COMPOSITION_DECODE_RULE.
1054 (COMPOSITION_DECODE_RULE): Use it.
1055 * composite.c (get_composition_id): Remove unused local vars,
1056 by using the new macro.
1058 * textprop.c (set_text_properties_1): Change while to do-while,
1059 since the condition is always true at first.
1061 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1062 (interval_deletion_adjustment): Return unsigned value.
1065 * process.c (list_processes_1, create_pty, read_process_output):
1066 (exec_sentinel): Remove vars that were set but not used.
1067 (create_pty): Remove unnecessary "volatile"s.
1068 (Fnetwork_interface_info): Avoid possibility of int overflow.
1069 (read_process_output): Do adaptive read buffering even if carryover.
1070 (read_process_output): Simplify nbytes computation if buffered.
1072 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1074 * syntax.c (scan_words): Remove var that was set but not used.
1075 (update_syntax_table): Use unsigned instead of int.
1077 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1078 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1079 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1081 * print.c (print_error_message): Avoid int overflow.
1083 * font.c (font_list_entities): Redo for clarity,
1084 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1086 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1087 (font_score): Avoid potential overflow in diff calculation.
1089 * fns.c (substring_both): Remove var that is set but not used.
1090 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1092 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1094 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1095 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1096 can always succeed if overflow has undefined behavior.
1098 * search.c (boyer_moore, wordify): Remove vars set but not used.
1099 (wordify): Omit three unnecessary tests.
1101 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1102 All callers changed. This avoids the need for an unused var.
1104 * casefiddle.c (casify_region): Remove var that is set but not used.
1106 * dired.c (file_name_completion): Remove var that is set but not used.
1108 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1110 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1111 (Finsert_file_contents): Remove unnecessary code checking fd.
1113 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1114 Check for integer overflow on size calculations.
1116 * buffer.c (Fprevious_overlay_change): Remove var that is set
1119 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1120 Remove vars that are set but not used.
1121 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1122 (timer_check_2): Mark vars as initialized.
1124 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1126 * image.c (lookup_image): Remove var that is set but not used.
1127 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1129 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1130 that are set but not used.
1132 * xfns.c (make_invisible_cursor): Don't return garbage
1133 if XCreateBitmapFromData fails (Bug#8410).
1135 * xselect.c (x_get_local_selection, x_handle_property_notify):
1136 Remove vars that are set but not used.
1138 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1139 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1141 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1142 Remove var that is set but not used.
1143 (scroll_bar_windows_size): Now size_t, not int.
1144 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1147 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1148 (map_tty_color) [!defined MSDOS]: Likewise.
1150 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1152 * coding.c: Remove vars that are set but not used.
1153 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1154 All callers changed.
1155 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1156 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1157 (decode_coding_charset): Remove vars that are set but not used.
1159 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1160 that is set but not used.
1162 * print.c (print_object): Remove var that is set but not used.
1164 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1165 The gnulib version avoids calling malloc in the usual case,
1166 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1167 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1168 * filelock.c (current_lock_owner): Likewise.
1169 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1170 * sysdep.c: Include allocator.h, careadlinkat.h.
1171 (emacs_no_realloc_allocator): New static constant.
1172 (emacs_readlink): New function.
1173 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1174 ../lib/careadlinkat.h.
1176 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1178 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1179 first non-nil return value).
1181 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1183 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1184 if not defined (Bug#8403).
1186 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1188 * xdisp.c (display_count_lines): Remove parameter `start',
1189 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1190 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1191 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1192 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1193 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1194 and thereabouts. All callers changed.
1195 (get_per_char_metric): Remove parameter `f', unused since
1196 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1198 2011-04-02 Jim Meyering <meyering@redhat.com>
1200 do not dereference NULL upon failed strdup
1201 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1202 (ns_get_family): Likewise.
1204 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1206 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1208 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1210 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1213 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1215 Add lexical binding.
1217 * window.c (Ftemp_output_buffer_show): New fun.
1218 (Fsave_window_excursion):
1219 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1221 * lread.c (lisp_file_lexically_bound_p): New function.
1222 (Fload): Bind Qlexical_binding.
1223 (readevalloop): Remove `evalfun' arg.
1224 Bind Qinternal_interpreter_environment.
1225 (Feval_buffer): Bind Qlexical_binding.
1226 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1228 (syms_of_lread): Declare `lexical-binding'.
1230 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1232 * keyboard.c (eval_dyn): New fun.
1233 (menu_item_eval_property): Use it.
1235 * image.c (parse_image_spec): Use Ffunctionp.
1237 * fns.c (concat, mapcar1): Accept byte-code-functions.
1239 * eval.c (Fsetq): Handle lexical vars.
1240 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1241 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1242 (FletX, Flet): Obey lexical binding.
1243 (Fcommandp): Handle closures.
1244 (Feval): New `lexical' arg.
1245 (eval_sub): New function extracted from Feval. Use it almost
1246 everywhere where Feval was used. Look up vars in lexical env.
1248 (Ffunctionp): Move from subr.el.
1249 (Ffuncall): Handle closures.
1250 (apply_lambda): Remove `eval_flags'.
1251 (funcall_lambda): Handle closures and new byte-code-functions.
1252 (Fspecial_variable_p): New function.
1253 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1254 but without exporting it to Lisp.
1256 * doc.c (Fdocumentation, store_function_docstring):
1257 * data.c (Finteractive_form): Handle closures.
1259 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1262 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1264 (exec_byte_code): New function extracted from Fbyte_code to handle new
1265 calling convention for byte-code-functions. Add new byte-codes.
1267 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1269 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1271 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1273 * xdisp.c (redisplay_internal): Fix prototype.
1275 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1277 * xdisp.c (SCROLL_LIMIT): New macro.
1278 (try_scrolling): Use it when setting scroll_limit. Limit
1279 scrolling to 100 screen lines.
1280 (redisplay_window): Even when falling back on "recentering",
1281 position point in the window according to scroll-conservatively,
1282 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1284 (try_scrolling): When point is above the window, allow searching
1285 as far as scroll_max, or one screenful, to compute vertical
1286 distance from PT to the scroll margin position. This prevents
1287 try_scrolling from unnecessarily failing when
1288 scroll-conservatively is set to a value slightly larger than the
1289 window height. Clean up the case of PT below the margin at bottom
1290 of window: scroll_max can no longer be INT_MAX. When aggressive
1291 scrolling is in use, don't let point enter the opposite scroll
1292 margin as result of the scroll.
1293 (syms_of_xdisp) <scroll-conservatively>: Document the
1294 threshold of 100 lines for never-recentering scrolling.
1296 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1298 * dispextern.h (move_it_by_lines):
1299 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1300 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1301 (message_log_check_duplicate): Remove parameters `prev_bol' and
1302 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1303 (redisplay_internal): Remove parameter `preserve_echo_area',
1304 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1306 * indent.c (Fvertical_motion):
1307 * window.c (window_scroll_pixel_based, Frecenter):
1308 Don't pass `need_y_p' to `move_it_by_lines'.
1310 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1313 steal a few bits to be more compact.
1314 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1315 Remove unneeded casts.
1317 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1319 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1321 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1322 binding" message (bug#7967).
1324 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1326 Fix more problems found by GCC 4.6.0's static checks.
1328 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1329 Remove unused local var.
1331 * editfns.c (Fmessage_box): Remove unused local var.
1333 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1334 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1335 Omit unused local vars.
1336 * window.c (shrink_windows): Omit unused local var.
1337 * menu.c (digest_single_submenu): Omit unused local var.
1338 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1339 Omit unused local var.
1341 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1342 Don't assume string length fits in int.
1343 (keyremap_step, read_key_sequence): Use size_t for sizes.
1344 (read_key_sequence): Don't check last_real_key_start redundantly.
1346 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1347 instead of alloca (Bug#8344).
1349 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1350 (Fbacktrace_frame): Don't assume nframes fits in int.
1352 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1354 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1357 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1359 * cm.c (calccost): Turn while-do into do-while, for clarity.
1361 * keyboard.c (syms_of_keyboard): Use the same style as later
1362 in this function when indexing through an array. This also
1363 works around GCC bug 48267.
1365 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1367 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1369 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1370 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1372 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1373 This avoids undefined behavior on integer overflow, and is a bit
1374 more convenient anyway since it is compared to a size_t variable.
1376 Variadic C functions now count arguments with size_t, not int.
1377 This avoids an unnecessary limitation on 64-bit machines, which
1378 caused (substring ...) to crash on large vectors (Bug#8344).
1379 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1381 All variadic functions and their callers changed accordingly.
1382 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1383 * data.c (arith_driver, float_arith_driver): Likewise.
1384 * editfns.c (general_insert_function): Likewise.
1385 * eval.c (struct backtrace.nargs, interactive_p)
1386 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1387 (funcall_lambda, mark_backtrace): Likewise.
1388 * fns.c (concat): Likewise.
1389 * frame.c (x_set_frame_parameters): Likewise.
1390 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1391 0 if not found, not -1. All callers changed.
1393 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1394 (stack_copy_size): Now size_t, not int.
1395 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1397 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1399 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1400 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1401 All callers changed.
1403 * lisp.h (multibyte_char_to_unibyte):
1404 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1405 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1406 * character.h (CHAR_TO_BYTE8):
1407 * cmds.c (internal_self_insert):
1408 * editfns.c (general_insert_function):
1409 * keymap.c (push_key_description):
1410 * search.c (Freplace_match):
1411 * xdisp.c (message_dolog, set_message_1): All callers changed.
1413 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1415 * keyboard.c (safe_run_hook_funcall): New function.
1416 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1417 don't set the hook to nil, but remove the offending function instead.
1418 (Qcommand_hook_internal): Remove, unused.
1419 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1420 Vcommand_hook_internal.
1422 * eval.c (enum run_hooks_condition): Remove.
1423 (funcall_nil, funcall_not): New functions.
1424 (run_hook_with_args): Call each function through a `funcall' argument.
1425 Remove `cond' argument, now redundant.
1426 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1427 (Frun_hook_with_args_until_failure): Adjust accordingly.
1428 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1430 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1432 * dispextern.h (string_buffer_position): Remove declaration.
1434 * print.c (strout): Remove parameter `multibyte', unused since
1435 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1437 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1438 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1439 All callers changed.
1441 * w32.c (_wsa_errlist): Use braces for struct initializers.
1443 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1444 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1445 All callers changed.
1446 (string_buffer_position): Likewise. Also, make static (it's never
1447 used outside xdisp.c).
1448 (cursor_row_p): Remove parameter `w', unused since
1449 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1450 (decode_mode_spec): Remove parameter `precision', introduced during
1451 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1452 All callers changed.
1454 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1456 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1458 2011-03-27 Anders Lindgren <andlind@gmail.com>
1460 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1461 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1462 (ns_update_auto_hide_menu_bar): New functions.
1463 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1464 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1465 ns_constrain_all_frames.
1466 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1467 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1469 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1471 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1473 2011-03-27 Glenn Morris <rgm@gnu.org>
1475 * syssignal.h: Replace RETSIGTYPE with void.
1476 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1477 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1478 Replace SIGTYPE with void everywhere.
1479 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1480 * s/template.h (SIGTYPE): Remove commented out definition.
1482 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1484 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1485 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1487 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1489 * w32.c (read_unc_volume): Use parameter `henum', instead of
1490 global variable `wget_enum_handle'.
1492 * keymap.c (describe_vector): Remove parameters `indices' and
1493 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1494 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1496 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1498 * keyboard.c (timer_check): Remove parameter `do_it_now',
1499 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1500 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1501 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1503 * keyboard.c (read_char):
1504 * w32menu.c (w32_menu_display_help):
1505 * xmenu.c (show_help_event, menu_help_callback):
1506 Adjust calls to `show_help_echo'.
1508 * gtkutil.c (xg_maybe_add_timer):
1509 * keyboard.c (readable_events):
1510 * process.c (wait_reading_process_output):
1511 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1513 * insdel.c (adjust_markers_gap_motion):
1514 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1515 (gap_left, gap_right): Don't call it.
1517 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1519 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1520 incurred during fontification.
1522 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1524 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1525 (DEFVAR_PER_BUFFER): Don't pass it.
1527 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1528 (scrolling_window): Don't pass it.
1530 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1532 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1534 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1536 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1537 of variables specific to SELinux and computation of `encoded_absname'.
1539 * image.c (XPutPixel): Remove unused variable `height'.
1541 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1543 * unexw32.c (get_section_info): Remove unused variable `section'.
1545 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1546 (system_process_attributes): Remove unused variable `sess'.
1547 (sys_read): Remove unused variable `err'.
1549 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1550 (w32_wnd_proc): Remove unused variable `isdead'.
1551 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1552 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1553 (x_create_tip_frame): Remove unused variable `tem'.
1555 * w32inevt.c (w32_console_read_socket):
1556 Remove unused variable `no_events'.
1558 * w32term.c (x_draw_composite_glyph_string_foreground):
1559 Remove unused variable `width'.
1561 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1563 * w32term.c (x_set_glyph_string_clipping):
1564 Don't pass uninitialized region to CombineRgn.
1566 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1568 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1569 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1570 (Fx_close_connection): Remove unused variable `i'.
1572 * w32font.c (w32font_draw): Return number of glyphs.
1573 (w32font_open_internal): Remove unused variable `i'.
1574 (w32font_driver): Add missing initializer.
1576 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1577 (fill_in_menu): Remove unused variable `items_added'.
1579 * w32term.c (last_mouse_press_frame): Remove static global variable.
1580 (w32_clip_to_row): Remove unused variable `f'.
1581 (x_delete_terminal): Remove unused variable `i'.
1583 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1584 (NOTHING): Remove unused static global variable.
1585 (uniscribe_check_otf): Remove unused variable `table'.
1586 (uniscribe_font_driver): Add missing initializers.
1588 2011-03-23 Julien Danjou <julien@danjou.info>
1590 * term.c (Fsuspend_tty, Fresume_tty):
1591 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1592 * window.c (temp_output_buffer_show):
1593 * insdel.c (signal_before_change):
1594 * frame.c (Fhandle_switch_frame):
1595 * fileio.c (Fdo_auto_save):
1596 * emacs.c (Fkill_emacs):
1597 * editfns.c (save_excursion_restore):
1598 * cmds.c (internal_self_insert):
1599 * callint.c (Fcall_interactively):
1600 * buffer.c (Fkill_all_local_variables):
1601 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1603 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1604 unconditionnaly since it does the check itself.
1606 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1608 Fix more problems found by GCC 4.5.2's static checks.
1610 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1611 the first time through the loop, since we know p0 < p1 then.
1612 This also avoids a gcc -Wstrict-overflow warning.
1614 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1615 leading to a memory leak, possible in functions like
1616 load_charset_map_from_file that can allocate an unbounded number
1617 of objects (Bug#8318).
1619 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1620 that could (at least in theory) be that large.
1622 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1623 This is less likely to overflow, and avoids undefined behavior if
1624 overflow does occur. All callers changed. Use strtoul to scan
1625 for the unsigned long integer.
1626 (pint2hrstr): Simplify and tune code slightly.
1627 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1629 * scroll.c (do_scrolling): Work around GCC bug 48228.
1630 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1632 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1633 This also avoids a warning with gcc -Wstrict-overflow.
1634 (validate_x_resource_name): Simplify count usage.
1635 This also avoids a warning with gcc -Wstrict-overflow.
1637 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1640 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1642 * process.c (Fmake_network_process): Use socklen_t, not int,
1643 where POSIX says socklen_t is required in portable programs.
1644 This fixes a porting bug on hosts like 64-bit HP-UX, where
1645 socklen_t is wider than int (Bug#8277).
1646 (Fmake_network_process, server_accept_connection):
1647 (wait_reading_process_output, read_process_output):
1650 * process.c: Rename or move locals to avoid shadowing.
1651 (list_processes_1, Fmake_network_process):
1652 (read_process_output_error_handler, exec_sentinel_error_handler):
1653 Rename or move locals.
1654 (Fmake_network_process): Define label "retry_connect" only if needed.
1655 (Fnetwork_interface_info): Fix pointer signedness.
1656 (process_send_signal): Add cast to avoid pointer signedness problem.
1657 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1658 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1660 Make tparam.h and terminfo.c consistent.
1661 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1662 Include tparam.h instead, since it declares them.
1663 * cm.h (PC): Remove extern decl; tparam.h now does this.
1664 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1665 * terminfo.c: Include tparam.h, to check interfaces.
1666 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1667 (tparam): Adjust signature to match interface in tparam.h;
1668 this removes some undefined behavior. Check that outstring and len
1669 are zero, which they always are with Emacs.
1670 * tparam.h (PC, BC, UP): New extern decls.
1672 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1673 (xftfont_open): Rename locals to avoid shadowing.
1675 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1676 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1677 (OTF_TAG_SYM): Omit macro if not needed.
1678 (ftfont_list): Remove unused local.
1679 (get_adstyle_property, ftfont_pattern_entity):
1680 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1681 Rename locals to avoid shadowing.
1683 * xfont.c (xfont_list_family): Mark var as initialized.
1685 * xml.c (make_dom): Now static.
1687 * composite.c (composition_compute_stop_pos): Rename local to
1689 (composition_reseat_it): Remove unused locals.
1690 (find_automatic_composition, composition_adjust_point): Likewise.
1691 (composition_update_it): Mark var as initialized.
1692 (find_automatic_composition): Mark vars as initialized,
1693 with a FIXME (Bug#8290).
1695 character.h: Rename locals to avoid shadowing.
1696 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1697 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1698 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1699 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1702 * textprop.c (property_change_between_p): Remove; unused.
1704 * intervals.c (interval_start_pos): Now static.
1706 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1708 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1709 Rename locals to avoid shadowing.
1711 * sound.c (wav_play, au_play, Fplay_sound_internal):
1712 Fix pointer signedness.
1713 (alsa_choose_format): Remove unused local var.
1714 (wav_play): Initialize a variable to 0, to prevent undefined
1715 behavior (Bug#8278).
1717 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1719 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1722 clobbering (Bug#8298).
1723 * sysdep.c (sys_subshell): Likewise.
1724 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1726 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1727 This should get cleaned up, so that child_setup has the
1728 same signature on all platforms.
1730 * callproc.c (call_process_cleanup): Now static.
1731 (relocate_fd): Rename locals to avoid shadowing.
1733 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1735 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1736 not to be necessary, and produces flickering.
1738 2011-03-20 Glenn Morris <rgm@gnu.org>
1740 * config.in: Remove file.
1742 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1744 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1745 are now in src/globals.h.
1746 (syms_of_minibuf): Remove spurious & from previous change.
1748 2011-03-20 Leo <sdl.web@gmail.com>
1750 * minibuf.c (completing-read-function): New variable.
1751 (completing-read-default): Rename from completing-read.
1752 (completing-read): Call completing-read-function.
1754 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1756 * xfaces.c (Fx_load_color_file):
1757 Read color file from absolute filename (bug#8250).
1759 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1761 * makefile.w32-in: Update dependencies.
1763 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1765 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1767 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1769 Fix more problems found by GCC 4.5.2's static checks.
1771 * process.c (make_serial_process_unwind, send_process_trap):
1772 (sigchld_handler): Now static.
1774 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1775 That way, the code declares only the vars that it needs.
1776 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1777 * s/cygwin.h (PTY_ITERATION): Likewise.
1778 * s/darwin.h (PTY_ITERATION): Likewise.
1779 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1781 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1782 * process.c (allocate_pty): Don't declare stb unless it's needed.
1784 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1785 (CONSTANTLIM): Remove; unused.
1786 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1787 Define only if needed.
1789 * unexelf.c (unexec): Name an expression,
1790 to avoid gcc -Wbad-function-cast warning.
1791 Use a different way to cause a compilation error if anyone uses
1792 n rather than nn, a way that does not involve shadowing.
1793 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1795 * deps.mk (unexalpha.o): Remove; unused.
1797 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1798 * unexec.h: New file.
1799 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1800 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1802 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1803 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1804 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1805 Change as necessary to match prototype in unexec.h.
1807 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1809 (back_comment, skip_chars): Mark vars as initialized.
1811 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1812 Rename locals to avoid shadowing.
1814 * lread.c (read1): Rewrite so as not to use empty "else".
1815 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1817 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1819 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1820 warning when compiling print.c.
1822 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1823 instead of using an uninitialized var.
1824 (font_sort_entities): Mark var as initialized.
1826 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1828 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1829 pointers to constants.
1830 (font_parse_fcname): Remove unused vars.
1831 (font_delete_unmatched): Now static.
1832 (font_get_spec): Remove; unused.
1833 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1834 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1835 Rename or move locals to avoid shadowing.
1837 * fns.c (require_nesting_list, require_unwind): Now static.
1838 (Ffillarray): Rename locals to avoid shadowing.
1840 * floatfns.c (domain_error2): Define only if needed.
1841 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1843 * alloc.c (mark_backtrace): Move decl from here ...
1844 * lisp.h: ... to here, so that it can be checked.
1846 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1847 (Fdefvar): Rewrite so as not to use empty "else".
1848 (lisp_indirect_variable): Name an expression,
1849 to avoid gcc -Wbad-function-cast warning.
1850 (Fdefvar): Rename locals to avoid shadowing.
1852 * callint.c (quotify_arg, quotify_args): Now static.
1853 (Fcall_interactively): Rename locals to avoid shadowing.
1854 Use const pointer when appropriate.
1856 * lisp.h (get_system_name, get_operating_system_release):
1857 Move decls here, to check interfaces.
1858 * process.c (get_operating_system_release): Move decl to lisp.h.
1859 * xrdb.c (get_system_name): Likewise.
1860 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1861 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1862 some of which prompt warnings from gcc -Wbad-function-cast.
1863 (Fformat_time_string, Fencode_time, Finsert_char):
1864 (Ftranslate_region_internal, Fformat):
1865 Rename or remove local vars to avoid shadowing.
1866 (Ftranslate_region_internal): Mark var as initialized.
1868 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1871 * lisp.h (eassert): Check that the argument compiles, even if
1872 ENABLE_CHECKING is not defined.
1874 * data.c (Findirect_variable): Name an expression, to avoid
1875 gcc -Wbad-function-cast warning.
1876 (default_value, arithcompare, arith_driver, arith_error): Now static.
1877 (store_symval_forwarding): Rename local to avoid shadowing.
1878 (Fmake_variable_buffer_local, Fmake_local_variable):
1879 Mark variables as initialized.
1880 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1882 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1883 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1884 Rename locals to avoid shadowing.
1885 (mark_stack): Move local variables into the #ifdef region where
1887 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1888 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1890 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1891 (GC_STRING_CHARS): Remove; not used.
1892 (Fmemory_limit): Cast sbrk's returned value to char *.
1894 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1895 avoids undefined behavior in theory.
1897 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1899 Use functions, not macros, for up- and down-casing (Bug#8254).
1900 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1901 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1902 to use the following functions instead of these macros.
1903 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1904 EMACS_INT, since callers assume the returned value fits in int.
1905 (upcase1): Likewise, for UPCASE_TABLE.
1906 (uppercasep, lowercasep, upcase): New static inline functions.
1907 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1908 the race-condition problem in the old DOWNCASE.
1910 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1911 Rename locals to avoid shadowing.
1912 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1913 (regex_compile, re_search_2, re_match_2_internal):
1914 Remove unused local vars.
1915 (FREE_VAR): Rewrite so as not to use empty "else",
1916 which gcc can warn about.
1917 (regex_compile, re_match_2_internal): Mark locals as initialized.
1918 (RETALLOC_IF): Define only if needed.
1919 (WORDCHAR_P): Likewise. This one is never needed, but is used
1920 only in a comment talking about a compiler bug, so put inside
1921 the #if 0 of that comment.
1922 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1923 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1926 * search.c (boyer_moore): Rename locals to avoid shadowing.
1927 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1928 (PREV_CHAR_BOUNDARY): Likewise.
1930 * search.c (simple_search): Remove unused var.
1932 * dired.c (compile_pattern): Move decl from here ...
1933 * lisp.h: ... to here, so that it can be checked.
1934 (struct re_registers): New forward decl.
1936 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1938 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1940 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1941 Rename locals to avoid shadowing.
1942 (Fvertical_motion): Mark locals as initialized.
1944 * casefiddle.c (casify_object, casify_region): Now static.
1945 (casify_region): Mark local as initialized.
1947 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1949 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1950 New macros, so that the caller can use some names other than
1951 gcpro1, gcpro2, etc.
1952 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1954 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1955 argument, for consistency with GCPRO2_VAR, etc: it is now the
1956 prefix of the variable, not the variable itself. All uses
1958 * dired.c (directory_files_internal, file_name_completion):
1959 Rename locals to avoid shadowing.
1961 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1962 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1963 dired.c's scmp function, had undefined behavior.
1964 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1965 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1966 * buffer.h: ... to here, because these macros use current_buffer,
1967 and the new implementation with inline functions needs to have
1968 current_buffer in scope now, rather than later when the macros
1970 (downcase, upcase1): New static inline functions.
1971 (DOWNCASE, UPCASE1): Reimplement using these functions.
1972 This avoids undefined behavior in expressions like
1973 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1974 from race conditions in accessing the global variables
1975 case_temp1 and case_temp2.
1976 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1977 * lisp.h (case_temp1, case_temp2): Remove their decls.
1978 * character.h (ASCII_CHAR_P): Move from here ...
1979 * lisp.h: ... to here, so that the inline functions mentioned
1982 * dired.c (directory_files_internal_unwind): Now static.
1984 * fileio.c (file_name_as_directory, directory_file_name):
1985 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1987 (file_name_as_directory): Use const pointers when appropriate.
1988 (Fexpand_file_name): Likewise. In particular, newdir might
1989 point at constant storage, so make it a const pointer.
1990 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1991 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1993 (Fset_file_times, Finsert_file_contents, auto_save_error):
1994 Rename locals to avoid shadowing.
1996 * minibuf.c (choose_minibuf_frame_1): Now static.
1997 (Ftry_completion, Fall_completions): Rename or remove locals
2000 * marker.c (bytepos_to_charpos): Remove; unused.
2002 * lisp.h (verify_bytepos, count_markers): New decls,
2003 so that gcc does not warn that these functions aren't declared.
2005 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2006 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2007 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2008 (copy_text): Remove unused local var.
2010 * filelock.c (within_one_second): Now static.
2011 (lock_file_1): Rename local to avoid shadowing.
2013 * buffer.c (fix_overlays_before): Mark locals as initialized.
2014 (fix_start_end_in_overlays): Likewise. This function should be
2015 simplified by using pointers-to-pointers, but that's a different
2017 (switch_to_buffer_1): Now static.
2018 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2019 (report_overlay_modification): Rename locals to avoid shadowing.
2021 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2022 Fix pointer signedness issue.
2023 (sys_subshell): Mark local as volatile if checking for lint,
2024 to suppress a gcc -Wclobbered warning that does not seem to be right.
2025 (MAXPATHLEN): Define only if needed.
2027 * process.c (serial_open, serial_configure): Move decls from here ...
2028 * systty.h: ... to here, so that they can be checked.
2030 * fns.c (get_random, seed_random): Move extern decls from here ...
2031 * lisp.h: ... to here, so that they can be checked.
2033 * sysdep.c (reset_io): Now static.
2034 (wait_for_termination_signal): Remove; unused.
2036 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2037 (copy_keymap_item, append_key, push_text_char_description):
2039 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2040 (DENSE_TABLE_SIZE): Remove; unused.
2041 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2042 (describe_map_tree):
2043 Rename locals to avoid shadowing.
2045 * keyboard.c: Declare functions static if they are not used elsewhere.
2046 (echo_char, echo_dash, cmd_error, top_level_2):
2047 (poll_for_input, handle_async_input): Now static.
2048 (read_char, kbd_buffer_get_event, make_lispy_position):
2049 (make_lispy_event, make_lispy_movement, apply_modifiers):
2050 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2051 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2052 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2053 (read_key_sequence, read_char): Mark locals as initialized.
2054 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2056 * keyboard.h (make_ctrl_char): New decl.
2057 (mark_kboards): Move decl here ...
2058 * alloc.c (mark_kboards): ... from here.
2060 * lisp.h (force_auto_save_soon): New decl.
2062 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2063 (DEFINE_DUMMY_FUNCTION): New macro.
2064 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2066 (main): Add casts to avoid warnings
2067 if GCC considers string literals to be constants.
2069 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2071 * dbusbind.c: Pointer signedness fixes.
2072 (xd_signature, xd_append_arg, xd_initialize):
2073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2074 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2075 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2076 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2078 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2079 if GCC considers string literals to be constants.
2080 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2082 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2084 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2085 (print_preprocess, print_object): New macro to fix last change.
2087 * print.c (print_preprocess): Don't forget font objects.
2089 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2091 * emacs.c (USAGE3): Doc fixes.
2093 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2095 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2098 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2100 * lisp.h (VWindow_system, Qfile_name_history):
2101 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2102 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2103 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2105 * w32select.c: Don't #include "keyboard.h".
2106 (run_protected): Add extern declaration for waiting_for_input.
2108 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2109 * w32console.c (detect_input_pending, read_input_pending)
2110 (encode_terminal_code):
2111 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2112 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2113 (w32_system_caret_y, Qfile_name_history):
2114 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2115 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2116 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2117 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2118 * w32proc.c (Qlocal, report_file_error):
2119 * w32term.c (Vwindow_system, updating_frame):
2120 * w32uniscribe.c (initialized, uniscribe_font_driver):
2121 Remove unneeded extern declarations.
2123 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2125 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2127 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2129 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2130 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2131 These macros can no longer be used for assignment.
2133 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2134 Assign struct members directly, instead of using BUF_BEGV etc.
2135 (record_buffer_markers, fetch_buffer_markers): New functions for
2136 recording and fetching special buffer markers.
2137 (set_buffer_internal_1, set_buffer_temp): Use them.
2139 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2141 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2143 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2144 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2146 * xdisp.c (hscroll_window_tree):
2147 (reconsider_clip_changes): Use PT instead of BUF_PT.
2149 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2151 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2152 $(EMACS_ROOT)/lib/intprops.h.
2154 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2156 Fix more problems found by GCC 4.5.2's static checks.
2158 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2159 to unsigned char * to avoid compiler diagnostic.
2160 (xg_free_frame_widgets): Make it clear that a local variable is
2161 needed only if USE_GTK_TOOLTIP.
2162 (gdk_window_get_screen): Make it clear that this macro is needed
2163 only if USE_GTK_TOOLTIP.
2164 (int_gtk_range_get_value): New function, which avoids a diagnostic
2165 from gcc -Wbad-function-cast.
2166 (xg_set_toolkit_scroll_bar_thumb): Use it.
2167 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2168 diagnostic from gcc -Wbad-function-cast.
2169 (get_utf8_string, xg_get_file_with_chooser):
2170 Rename locals to avoid shadowing.
2171 (create_dialog): Move locals to avoid shadowing.
2173 * xgselect.c (xg_select): Remove unused var.
2175 * image.c (four_corners_best): Mark locals as initialized.
2176 (gif_load): Initialize transparent_p to zero (Bug#8238).
2177 Mark another local as initialized.
2178 (my_png_error, my_error_exit): Mark with NO_RETURN.
2180 * image.c (clear_image_cache): Now static.
2181 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2182 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2183 (x_edge_detection): Remove unnecessary cast that
2184 gcc -Wbad-function-cast diagnoses.
2185 (gif_load): Fix pointer signedness.
2186 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2187 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2189 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2191 Improve quality of tests for time stamp overflow.
2192 For example, without this patch (encode-time 0 0 0 1 1
2193 1152921504606846976) returns the obviously-bogus value (-948597
2194 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2195 reports time overflow. See
2196 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2197 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2198 * editfns.c: Include limits.h and intprops.h.
2199 (TIME_T_MIN, TIME_T_MAX): New macros.
2200 (time_overflow): Move earlier, to before first use.
2201 (hi_time, lo_time): New functions, for an accurate test for
2203 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2204 (Fget_internal_run_time): Don't assume time_t fits in int.
2205 (make_time): Use list2 instead of Fcons twice.
2206 (Fdecode_time): More accurate test for out-of-range times.
2207 (check_tm_member): New function.
2208 (Fencode_time): Use it, to test for out-of-range times.
2209 (lisp_time_argument): Don't rely on undefined left-shift and
2210 right-shift behavior when checking for time stamp overflow.
2212 * editfns.c (time_overflow): New function, refactoring common code.
2213 (Fformat_time_string, Fdecode_time, Fencode_time):
2214 (Fcurrent_time_string): Use it.
2216 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2217 * dired.c (make_time): Move to ...
2218 * editfns.c (make_time): ... here.
2219 * systime.h: Note the move.
2221 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2223 * fringe.c (update_window_fringes): Remove unused variables.
2225 * unexmacosx.c (copy_data_segment): Also copy __got section.
2228 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2230 * termcap.c [MSDOS]: Include "msdos.h".
2231 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2232 Constify `char *' arguments and their references according to
2233 prototypes in tparam.h.
2235 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2237 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2238 Adapt all references accordingly.
2240 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2242 2011-03-11 Tom Tromey <tromey@redhat.com>
2244 * buffer.c (syms_of_buffer): Remove obsolete comment.
2246 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2248 * termhooks.h (encode_terminal_code): Declare prototype.
2250 * msdos.c (encode_terminal_code): Don't declare prototype.
2252 * term.c (encode_terminal_code): Now external again, used by
2253 w32console.c and msdos.c.
2255 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2256 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2258 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2260 Fix some minor problems found by GCC 4.5.2's static checks.
2262 * fringe.c (update_window_fringes): Mark locals as initialized
2264 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2266 * alloc.c (mark_fringe_data): Move decl from here ...
2267 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2268 to check its interface.
2269 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2271 * fontset.c (free_realized_fontset): Now static.
2272 (Fset_fontset_font): Rename local to avoid shadowing.
2273 (fontset_font): Mark local as initialized.
2274 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2276 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2278 * xselect.c (x_disown_buffer_selections): Remove; not used.
2279 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2280 (x_own_selection, Fx_disown_selection_internal): Rename locals
2282 (x_handle_dnd_message): Remove local to avoid shadowing.
2284 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2285 so that the caller can use some name other than gcpro1.
2286 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2287 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2288 (Fx_backspace_delete_keys_p):
2289 Use them to avoid shadowing, and rename vars to avoid shadowing.
2290 (x_decode_color, x_set_name, x_window): Now static.
2291 (Fx_create_frame): Add braces to silence GCC warning.
2292 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2293 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2294 Remove unused locals.
2295 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2296 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2297 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2300 * xterm.h (x_mouse_leave): New decl.
2302 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2303 Remove unused functions.
2304 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2305 (x_calc_absolute_position): Now static.
2306 (XTread_socket): Don't define label "out" unless it's used.
2307 Don't declare local "event" unless it's used.
2308 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2309 unless they are used.
2310 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2311 (x_fatal_error_signal): Remove; not used.
2312 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2313 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2314 (x_error_catcher, x_connection_closed, x_error_handler):
2315 (x_error_quitter, xembed_send_message, x_iconify_frame):
2316 (my_log_handler): Rename locals to avoid shadowing.
2317 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2318 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2320 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2321 Rename or move locals to avoid shadowing.
2322 (tty_defined_color, merge_face_heights): Now static.
2323 (free_realized_faces_for_fontset): Remove; not used.
2324 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2325 does not deduce is never used uninitialized.
2326 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2327 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2329 * terminal.c (store_terminal_param): Now static.
2331 * xmenu.c (menu_highlight_callback): Now static.
2332 (set_frame_menubar): Remove unused local.
2333 (xmenu_show): Rename parameter to avoid shadowing.
2334 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2335 since they might point to immutable storage.
2336 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2337 since it's unused otherwise.
2339 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2340 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2341 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2342 avoids a gcc -Wuninitialized diagnostic.
2343 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2344 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2345 does not deduce are never used uninitialized.
2347 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2349 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2350 * window.c (window_loop, size_window):
2351 (run_window_configuration_change_hook, enlarge_window): Likewise.
2353 * window.c (display_buffer): Now static.
2354 (size_window): Mark variables that gcc -Wuninitialized
2355 does not deduce are never used uninitialized.
2356 * window.h (check_all_windows): New decl, to forestall
2357 gcc -Wmissing-prototypes diagnostic.
2358 * dispextern.h (bidi_dump_cached_states): Likewise.
2360 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2362 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2364 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2365 and to avoid gcc -Wuninitialized warning.
2366 (load_charset_map): Mark variables that gcc -Wuninitialized
2367 does not deduce are never used uninitialized.
2368 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2370 * coding.c (coding_set_source, coding_set_destination):
2371 Use "else { /* comment */ }" rather than "else /* comment */;"
2372 for clarity, and to avoid gcc -Wempty-body warning.
2373 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2374 a block, when the outer 'i' will do.
2375 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2376 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2377 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2378 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2379 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2380 Rename locals to avoid shadowing.
2381 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2382 * coding.c (emacs_mule_char, encode_invocation_designation):
2383 Now static, since they're not used elsewhere.
2384 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2385 (decode_coding_object, encode_coding_object, detect_coding_system):
2386 (decode_coding_emacs_mule): Mark variables that gcc
2387 -Wuninitialized does not deduce are never used uninitialized.
2388 (detect_coding_iso_2022): Initialize a local variable that might
2389 be used uninitialized. Leave a FIXME because it's not clear that
2390 this initialization is needed. (Bug#8211)
2391 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2392 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2393 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2394 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2395 Remove unused macros.
2397 * category.c (hash_get_category_set): Remove unused local var.
2398 (copy_category_table): Now static, since it's not used elsewhere.
2399 * character.c (string_count_byte8): Likewise.
2401 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2402 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2404 * chartab.c (copy_sub_char_table): Now static, since it's not used
2406 (sub_char_table_ref_and_range, char_table_ref_and_range):
2407 Rename locals to avoid shadowing.
2408 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2410 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2411 (BIDI_BOB): Remove unused macro.
2413 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2414 deduce are never used uninitialized.
2415 * term.c (encode_terminal_code): Likewise.
2417 * term.c (encode_terminal_code): Now static. Remove unused local.
2419 * tparam.h: New file.
2420 * term.c, tparam.h: Include it.
2421 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2422 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2423 Move these decls to tparam.h, and make them agree with what
2424 is actually in tparam.c. The previous trick of using incompatible
2425 decls in different modules does not conform to the C standard.
2426 All callers of tparam changed to use tparam's actual API.
2427 * tparam.c (tparam1, tparam, tgoto):
2428 Use const pointers where appropriate.
2430 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2431 * cm.h (struct cm): Likewise.
2432 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2433 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2434 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2435 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2436 (turn_on_face, init_tty): Likewise.
2437 * termchar.h (struct tty_display_info): Likewise.
2439 * term.c (term_mouse_position): Rename local to avoid shadowing.
2441 * alloc.c (mark_ttys): Move decl from here ...
2442 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2444 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2446 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2448 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2450 * search.c (compile_pattern_1): Remove argument regp, unused since
2451 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2452 (compile_pattern): Don't pass it.
2454 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2456 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2457 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2459 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2461 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2463 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2464 gdk_window_get_screen, gdk_window_get_geometry,
2465 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2466 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2467 (xg_get_pixbuf_from_pixmap): New function.
2468 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2469 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2470 Call xg_get_pixbuf_from_pixmap instead of
2471 gdk_pixbuf_get_from_drawable.
2472 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2473 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2474 (xg_check_special_colors): Use GtkStyleContext and its functions
2476 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2477 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2478 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2479 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2480 Call gtk_widget_get_preferred_size.
2481 (xg_frame_resized): gdk_window_get_geometry only takes 5
2483 (xg_win_to_widget, xg_event_is_for_menubar):
2484 Call gdk_x11_window_lookup_for_display.
2485 (xg_set_widget_bg): New function.
2486 (delete_cb): New function.
2487 (xg_create_frame_widgets): connect delete-event to delete_cb.
2488 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2489 (xg_set_background_color): Call xg_set_widget_bg.
2490 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2491 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2492 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2493 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2495 (update_frame_tool_bar): Call gtk_widget_hide.
2496 (xg_initialize): Use GDK_KEY_g.
2498 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2500 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2502 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2503 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2504 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2506 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2508 * w32xfns.c (select_palette): Check success of RealizePalette against
2509 GDI_ERROR, not zero.
2511 See ChangeLog.11 for earlier changes.
2517 Copyright (C) 2011 Free Software Foundation, Inc.
2519 This file is part of GNU Emacs.
2521 GNU Emacs is free software: you can redistribute it and/or modify
2522 it under the terms of the GNU General Public License as published by
2523 the Free Software Foundation, either version 3 of the License, or
2524 (at your option) any later version.
2526 GNU Emacs is distributed in the hope that it will be useful,
2527 but WITHOUT ANY WARRANTY; without even the implied warranty of
2528 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2529 GNU General Public License for more details.
2531 You should have received a copy of the GNU General Public License
2532 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.