1 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
5 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
6 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
8 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
10 (x_set_window_size): Remove unused variable toolbar.
11 (ns_get_color_default, ns_mod_to_lisp): Remove.
12 (ns_mouse_position): Remove unused variables xchar and ychar.
13 (ns_compute_glyph_string_overhangs): Remove unused variable face.
14 (ns_set_vertical_scroll_bar): Remove unused variable count.
15 (ns_delete_terminal): Remove unused variable i.
16 (ns_term_init): Remove unused variables r, g and b.
17 (mouseDown): Remove unused variable window.
18 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
19 (initFrameFromEmacs): Remove unused variable vbextra.
20 (mouseEntered): Remove unused variables p and dpyinfo.
21 (mouseExited): Remove unused variables p and r.
22 (ns_define_frame_cursor, ns_clear_frame_area)
23 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
24 (menuDown): Assign [sender tag] to variable and cast the variable.
26 * nsterm.h (menuDown): Add id as type to argument sender.
27 (ns_display_info_for_name): Add Lisp_Object argument.
28 (ns_term_init): Add Lisp_Object argument.
29 (ns_map_event_to_object): Add void argument.
30 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
31 prototype with arguments and only declare if __OBJC__.
32 (nxatoms_of_nsselect): Add void argument.
33 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
34 (ns_alloc_autorelease_pool): Add void argument.
35 (ns_release_autorelease_pool): Add void* argument.
36 (ns_get_defaults_value): Add const char* argument.
38 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
39 (initFromContents): Use SSDATA where appropriate.
40 (ns_update_menubar): Add braces to ambigous if-else.
41 (initWithTitle): Put () around assignment in if statement.
42 (ns_menu_show): Remove unused variables window and keymap.
43 (update_frame_tool_bar): Remove unused variable selected_p.
44 (initWithContentRect): Remove unused variable this_cmd_name.
46 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
48 (setXBMColor): Remove unused variable len.
49 (setPixmapData): Put () around assignment in loop statement.
51 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
52 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
54 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
55 around assignment in loop statement.
56 (nsfont_open): Remove unused variable i.
57 (nsfont_open): Remove unused variable len.
58 (nsfont_draw): Remove unused variable cs.
60 * nsfns.m (x_set_icon_name, ns_set_name_internal)
61 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
62 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
63 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
64 (Fns_font_name, Fns_perform_service)
65 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
66 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
67 (ns_set_name): Remove unused variable view.
68 (x_set_menu_bar_lines): Remove unused variable olines.
69 (x_set_tool_bar_lines): Remove unused variable root_window.
70 (Fns_list_colors): Put () around assignment in while statement.
71 (Fns_perform_service): Remove unused variable len.
72 (Fns_display_usable_bounds): Remove unused variable top.
73 (syms_of_nsfns): Remove unused variable i.
75 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
78 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
80 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
81 and free it with DestroyExceptionInfo (Bug#11558).
83 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
85 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
86 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
87 Set here, not in nt/config.nt.
89 2012-07-13 Eli Zaretskii <eliz@gnu.org>
91 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
92 cursor overflow into the last glyph on display line when the right
93 fringe is off. (Bug#11832)
95 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
97 * xdisp.c (produce_special_glyphs): Now static.
98 * dispextern.h (produce_special_glyphs): Remove decl.
100 2012-07-13 Glenn Morris <rgm@gnu.org>
102 * s/bsd-common, s/cygwin.h: Remove empty files.
103 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
105 * s/usg5-4-common.h (USG, USG5):
106 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
107 * s/sol2-6.h (SOLARIS2):
108 * s/irix6-5.h (IRIX6_5):
109 * s/hpux10-20.h (USG, USG5, HPUX):
110 * s/gnu-linux.h (USG, GNU_LINUX):
111 * s/freebsd.h (BSD_SYSTEM):
112 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
113 * s/cygwin.h (CYGWIN):
114 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
115 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
117 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
119 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
121 2012-07-13 Glenn Morris <rgm@gnu.org>
123 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
125 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
127 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
128 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
130 2012-07-12 Glenn Morris <rgm@gnu.org>
132 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
134 * process.c (init_process_emacs): Rename from init_process.
135 The old name is also the name of a Mach system call.
136 * lisp.h, emacs.c: Update for this name change.
137 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
140 2012-07-12 Eli Zaretskii <eliz@gnu.org>
142 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
143 memmove call that removes glyphs covered by the left truncation
144 glyph. Improve commentary.
145 (display_line): Fix display of continuation glyphs on GUI frames
146 when the right fringe is turned off and variable-size fonts are
147 used in the window. Move the code that appends a stretch glyph to
148 produce_special_glyphs, so that it could be used for truncation
149 and continuation glyphs alike.
150 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
151 glyph of a suitably computed width, to align the special glyphs at
152 the window margin. Code moved from display_line. (Bug#11832)
154 2012-07-12 Glenn Morris <rgm@gnu.org>
156 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
158 * s/gnu-linux.h, s/hpux10-20.h:
159 Do not unconditionally define HAVE_XRMSETDATABASE.
161 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
163 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
165 Fix typos that broke OS X build.
166 Reported by Randal L. Schwartz in
167 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
168 * nsterm.m (ns_timeout): Add missing local decl.
169 (ns_get_color): snprintf -> sprintf, to fix typo.
171 2012-07-12 Glenn Morris <rgm@gnu.org>
173 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
174 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
175 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
176 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
178 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
179 Move PTY_OPEN to configure.
181 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
182 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
183 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
185 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
187 Use empty_unibyte_string where applicable.
188 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
189 * lread.c (read1): Likewise.
190 * xsettings.c (syms_of_xsettings): Likewise.
192 2012-07-12 Glenn Morris <rgm@gnu.org>
194 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
195 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
196 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
197 * s/hpux10-20.h (RUN_TIME_REMAP):
198 * s/bsd-common.h (TABDLY): Move to configure.
200 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
202 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
204 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
205 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
207 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
209 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
210 * s/template.h: Move NARROWPROTO to configure.
212 2012-07-11 Glenn Morris <rgm@gnu.org>
214 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
215 unused since 2011-01-17 change to systty.h.
217 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
218 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
219 Move HAVE_PTYS and HAVE_SOCKETS to configure.
221 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
223 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
225 2012-07-11 Glenn Morris <rgm@gnu.org>
227 * s/darwin.h, s/gnu-linux.h, s/template.h:
228 Move INTERRUPT_INPUT to configure.
230 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
232 Minor adjustments to interning code.
233 * lisp.h (intern, intern_c_string): Redefine as static inline
234 wrappers for intern_1 and intern_c_string_1, respectively.
235 (intern_1, intern_c_string_1): Rename prototypes.
236 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
238 * font.c (font_intern_prop): Likewise. Adjust comment.
239 * w32font.c (intern_font_name): Likewise.
241 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
243 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
245 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
246 of Fcar/Fcdr if possible.
247 * font.c (check_otf_features): Likewise.
248 * fontset.c (Fnew_fontset): Likewise.
249 * gnutls.c (Fgnutls_boot): Likewise.
250 * minibuf.c (read_minibuf): Likewise.
251 * msdos.c (IT_set_frame_parameters): Likewise.
252 * xmenu.c (Fx_popup_dialog): Likewise.
253 * w32menu.c (Fx_popup_dialog): Likewise.
255 2012-07-11 Glenn Morris <rgm@gnu.org>
257 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
258 since nothing has defined it on these platforms.
260 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
261 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
263 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
264 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
265 Move CLASH_DETECTION to configure.
267 * s/gnu.h: Remove file, which is now empty.
269 * s/gnu.h, s/gnu-linux.h:
270 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
272 2012-07-11 John Wiegley <johnw@newartisans.com>
274 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
275 function attribute, so we only use it if it exists in the
278 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
280 Avoid call to strlen in fast_c_string_match_ignore_case.
281 * search.c (fast_c_string_match_ignore_case): Change to use
282 length argument. Adjust users accordingly.
283 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
285 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
288 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
289 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
292 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
295 * s/hpux10-20.h (HAVE_PERROR): Remove.
296 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
297 Remove dummy definition, as this problem was obsolete long ago.
300 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
302 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
304 Avoid calls to strlen in font processing functions.
305 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
306 (font_open_by_name): Change to use length argument. Adjust
308 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
310 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
311 Change to return ptrdiff_t.
312 (xfont_list_pattern, xfont_match): Use length returned by
313 xfont_decode_coding_xlfd.
314 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
316 2012-07-11 Glenn Morris <rgm@gnu.org>
318 * s/darwin.h, s/freebsd.h, s/netbsd.h:
319 Move DONT_REOPEN_PTY to configure.
321 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
322 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
324 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
326 Remove "#define unix" that is no longer needed (Bug#11905).
327 * s/aix4-2.h (unix): Remove; no longer needed.
329 EMACS_TIME simplification (Bug#11875).
330 This replaces macros (which typically do not work in GDB)
331 with functions, typedefs and enums, making the code easier to debug.
332 The functional style also makes code easier to read and maintain.
333 * systime.h: Include <sys/time.h> on all hosts, not just if
334 WINDOWSNT, since 'struct timeval' is needed in general.
335 (EMACS_TIME): Now a typedef, not a macro.
336 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
338 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
339 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
340 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
341 (EMACS_TIME_LE): Now functions, not macros.
342 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
343 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
344 which are not functions. All uses rewritten to use:
345 (make_emacs_time): New function.
346 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
347 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
348 not functions. All uses rewritten to use the following, respectively:
349 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
350 (add_emacs_time, sub_emacs_time): New functions.
351 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
352 * fileio.c (Fcopy_file):
353 * xterm.c (XTflash): Get the current time closer to when it's used.
354 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
356 * bytecode.c (targets): Suppress -Woverride-init warnings.
358 Simplify by avoiding confusing use of strncpy etc.
359 * doc.c (Fsnarf_documentation):
360 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
361 * frame.c (Fmake_terminal_frame):
362 * gtkutil.c (get_utf8_string):
364 * nsmenu.m (ns_update_menubar):
365 * regex.c (regerror):
366 Prefer memcpy to strncpy and strncat when either will do.
367 * fileio.c (Fsubstitute_in_file_name):
368 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
369 (menu_separator_name_p):
370 * nsmenu.m (ns_update_menubar):
371 Prefer memcmp to strncmp when either will do.
372 * nsterm.m: Include <ftoastr.h>.
374 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
375 Prefer snprintf to strncpy.
376 * nsterm.m (ns_term_init):
377 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
378 * nsterm.m (ns_term_init):
379 Avoid the need for strncpy, by using build_string or
380 make_unibyte_string directly. Use dtoastr, not snprintf.
381 * process.c (Fmake_network_process): Diagnose service names that
382 are too long, rather than silently truncating them or creating
383 non-null-terminated names.
384 (Fnetwork_interface_info): Likewise, for interface names.
385 * sysdep.c (system_process_attributes) [GNU_LINUX]:
386 Prefer sprintf to strncat.
387 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
388 Prefer vsnprintf to vsprintf + strncpy.
390 2012-07-10 Glenn Morris <rgm@gnu.org>
392 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
393 Clarify fallback case.
395 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
397 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
398 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
399 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
400 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
401 where argument type is known to be a Lisp_Cons.
403 2012-07-10 Tom Tromey <tromey@redhat.com>
405 * bytecode.c (BYTE_CODE_THREADED): New macro.
406 (BYTE_CODES): New macro. Replaces all old byte-code defines.
407 (enum byte_code_op): New type.
408 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
409 (exec_byte_code): Use them. Use token threading when applicable.
411 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
413 Optimize pure C strings initialization.
414 * lisp.h (make_pure_string): Fix prototype.
415 (build_pure_c_string): New function, defined as static inline. This
416 provides a better opportunity to optimize away calls to strlen when
417 the function is called with compile-time constant argument.
418 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
419 argument, adjust users accordingly. Use build_pure_c_string where
421 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
422 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
423 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
425 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
427 Avoid calls to strlen in miscellaneous functions.
428 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
429 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
430 * lread.c (openp): Likewise.
432 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
434 Avoid calls to strlen in path processing functions.
435 * fileio.c (file_name_as_directory): Add comment. Change to add
436 srclen argument and return the length of result. Adjust users
438 (directory_file_name): Fix comment. Change to add srclen argument,
439 swap 1st and 2nd arguments to obey the common convention. Adjust
441 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
443 2012-07-10 Glenn Morris <rgm@gnu.org>
445 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
446 Move PENDING_OUTPUT_COUNT definition to configure.
448 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
449 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
450 * s/gnu.h (DATA_START): Move definitions to configure.
452 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
453 We include usg5-4-common.h, which defines them both.
455 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
456 O_RDONLY already includes it).
458 Stop ns builds setting the EMACSLOADPATH environment variable.
459 * nsterm.m (ns_load_path): Rename from ns_init_paths.
460 Now it does not set EMACSLOADPATH, just returns the load-path string.
461 * nsterm.h: Update accordingly.
462 * lread.c [HAVE_NS]: Include nsterm.h.
463 (init_lread) [HAVE_NS]: Use ns_load_path.
464 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
466 2012-07-09 Glenn Morris <rgm@gnu.org>
468 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
469 since the included bsd-common.h does so.
471 Stop ns builds setting the EMACSPATH environment variable.
472 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
473 (ns_init_paths): Do not set EMACSPATH.
474 * nsterm.h (ns_exec_path): Add it.
475 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
478 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
480 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
482 * process.c (wait_reading_process_output): 'waitchannels' was unset
483 when read_kbd || !NILP (wait_for_cell); fix this.
485 Add GCC-style 'const' attribute to functions that can use it.
486 * character.h (char_resolve_modifier_mask):
487 * keyboard.h (make_ctrl_char):
488 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
489 (init_character_once, next_almost_prime, init_fns, init_image)
490 (flush_pending_output, init_sound):
491 * mem-limits.h (start_of_data):
492 * menu.h (finish_menu_items):
494 * emacs.c (DEFINE_DUMMY_FUNCTION):
495 Declare the dummy function with ATTRIBUTE_CONST.
496 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
497 Add decls with ATTRIBUTE_CONST.
499 Minor improvements to make_formatted_string.
500 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
501 where int is good enough, as vsprintf returns an int.
502 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
504 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
506 Use make_formatted_string to avoid double length calculation.
507 * lisp.h (make_formatted_string): New prototype.
508 * alloc.c (make_formatted_string): New function.
509 * buffer.c (Fgenerate_new_buffer_name): Use it.
510 * dbus.c (syms_of_dbusbind): Likewise.
511 * editfns.c (Fcurrent_time_zone): Likewise.
512 * filelock.c (get_boot_time): Likewise.
513 * frame.c (make_terminal_frame, set_term_frame_name)
514 (x_report_frame_params): Likewise.
515 * image.c (gs_load): Likewise.
516 * minibuf.c (get_minibuffer): Likewise.
517 * msdos.c (dos_set_window_size): Likewise.
518 * process.c (make_process): Likewise.
519 * xdisp.c (ensure_echo_area_buffers): Likewise.
520 * xsettings.c (apply_xft_settings): Likewise.
522 2012-07-09 Glenn Morris <rgm@gnu.org>
524 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
525 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
526 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
527 * nsterm.h (ns_etc_directory): Add it.
528 * callproc.c [HAVE_NS]: Include nsterm.h.
529 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
531 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
533 Move marker debugging code under MARKER_DEBUG.
534 * marker.c (MARKER_DEBUG): Move marker debugging code under
535 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
536 for bootstrap with --enable-checking (~3x slowdown reported
537 by Juanma Barranquero <lekktu@gmail.com>).
538 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
540 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
542 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
543 See <http://bugs.gnu.org/11825#29>.
545 2012-07-08 Eli Zaretskii <eliz@gnu.org>
547 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
548 has no font, use the frame's font. (Bug#11813)
549 (display_line): Add commentary about displaying truncation glyphs
551 (produce_special_glyphs): Move here from term.c.
553 * term.c (produce_special_glyphs): Move to xdisp.c.
555 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
558 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
560 * xdisp.c (display_line): Avoid warning about implicit declaration
563 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
565 * lisp.h: Remove empty conditional.
567 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
569 * lread.c (load_path_check): Now static.
571 Fix some minor --with-ns problems found by static checking.
572 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
573 (x_set_font) [!HAVE_X_WINDOWS]:
574 * image.c (xpm_load_image) [HAVE_NS]:
575 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
576 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
578 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
579 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
580 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
581 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
582 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
583 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
584 Fix pointer signedness problem.
585 * xfaces.c (FRAME_X_FONT_TABLE):
586 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
588 2012-07-07 Glenn Morris <rgm@gnu.org>
590 * lread.c (load_path_check): New function, split from init_lread.
591 (init_lread): Reorganize. Motivation:
592 If EMACSLOADPATH is set, check/warn about that rather than the
593 defaults, which we are not going to use. Hence we can remove
594 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
595 Don't warn if site-lisp directories are missing.
596 If not installed, start from a blank load-path, since
597 PATH_LOADSEARCH refers to the eventual installation directories.
599 2012-07-07 Eli Zaretskii <eliz@gnu.org>
601 Support truncation and continuation glyphs on GUI frames, when
602 fringes are disabled. (Bug#11832)
603 * xdisp.c (init_iterator): Get dimensions of truncation and
604 continuation glyphs even if on GUI frames. Adjust
605 it->last_visible_x on GUI frames when the left or right fringes,
607 (start_display, move_it_in_display_line_to): Handle the case of a
608 GUI frame without a fringe to display continuation or truncation
610 (insert_left_trunc_glyphs): Support GUI frames: make sure
611 truncation glyphs overwrite enough glyphs from the current line to
612 have sufficient space in pixels.
613 (display_line): Support truncation and continuation glyphs on GUI
614 frames. If some spare pixels are left on the line after inserting
615 the truncation glyphs, fill that space with a stretch glyph of a
616 suitably computed width.
618 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
619 produce_glyphs, to support GUI sessions.
621 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
623 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
625 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
627 Do not require float-time's arg to fit in time_t (Bug#11825).
628 This works better on hosts where time_t is unsigned, and where
629 float-time is applied to the (negative) difference between two times.
630 * editfns.c (decode_time_components): Last arg is now double *,
631 not int *, and means to store all the result as a double, without
632 worrying about whether the seconds part fits in time_t.
634 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
636 (Ffloat_time): Do not fail merely because the specified time falls
637 outside of time_t range.
639 2012-07-07 Glenn Morris <rgm@gnu.org>
641 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
642 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
643 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
645 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
647 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
650 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
652 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
654 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
655 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
656 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
657 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
658 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
659 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
661 * xfont.c (compare_font_names): Redo to omit the need for casts.
663 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
665 * xfns.c (Fx_change_window_property): Doc fix.
666 * w32fns.c (Fx_change_window_property): Doc fix.
668 * w32fns.c (Fx_window_property): Accept the same arguments as the
669 X Windows version. Doc fix.
670 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
672 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
673 Eli Zaretskii <eliz@gnu.org>
675 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
676 Windows-specific code from nt/config.nt moved here.
677 Obsolete settings removed.
679 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
681 * process.c: Avoid unnecessary calls to gettime.
682 (wait_reading_process_output): Don't get the time of day
683 when gobbling data immediately and not waiting, as there's no need
684 for it in that case. This removes a FIXME.
686 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
688 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
689 is defined (Bug#11768).
691 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
693 Fix marker debugging code.
694 * marker.c (byte_char_debug_check): Do not perform the check
695 if buffer is not multibyte.
696 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
697 Call byte_char_debug_check with correct arguments.
699 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
701 Compile marker debugging code only if ENABLE_CHECKING is defined.
702 * marker.c (byte_char_debug_check, count_markers):
703 Use only if ENABLE_CHECKING is defined.
704 (byte_debug_flag): Remove.
705 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
706 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
708 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
710 Avoid code repetition in marker-related functions.
711 * marker.c (attach_marker): New function.
712 (Fset_marker, set_marker_restricted, set_marker_both)
713 (set_marker_restricted_both): Use it.
714 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
715 Consistently rename charno to charpos.
716 (marker_position): Add eassert.
717 (marker_byte_position): Convert to eassert.
719 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
721 Simplify list operations in unchain_overlay and unchain_marker.
722 * buffer.c (unchain_overlay): Simplify. Add comment.
723 * marker.c (unchain_marker): Simplify. Fix comments.
725 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
727 Introduce fast path for the widely used marker operation.
728 * alloc.c (build_marker): New function.
729 * lisp.h (build_marker): New prototype.
730 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
731 * composite.c (autocmp_chars): Likewise.
732 * editfns.c (buildmark): Remove.
733 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
734 (save_restriction_save): Use build_marker.
735 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
736 * window.c (save_window_save): Likewise.
738 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
740 Do not use Fdelete_overlay in delete_all_overlays
741 to avoid redundant calls to unchain_overlay.
742 * buffer.c (drop_overlay): New function.
743 (delete_all_overlays, Fdelete_overlay): Use it.
744 * minibuf.c (get_minibuffer): Fix comment.
746 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
748 Port to OpenBSD 5.1 amd64.
749 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
750 This is needed for OpenBSD, and should be harmless on all BSD systems.
751 Also, include <sys/sysctl.h>, as it should be available on all
752 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
753 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
754 use p_pid member, not kp_proc.pid.
756 2012-07-06 Glenn Morris <rgm@gnu.org>
758 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
760 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
762 More xmalloc and related cleanup.
763 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
764 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
766 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
767 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
768 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
769 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
770 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
771 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
773 Omit needless casts involving void * pointers and allocation.
774 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
775 as the former is more robust if P's type is changed.
776 Prefer xzalloc to xmalloc + memset 0.
777 Simplify malloc-or-realloc to realloc.
778 Don't worry about xmalloc returning a null pointer.
779 Prefer xstrdup to xmalloc + strcpy.
780 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
782 * keyboard.c (apply_modifiers_uncached): Prefer local array to
783 alloca of a constant.
785 2012-07-05 Eli Zaretskii <eliz@gnu.org>
787 * xdisp.c (display_line): Fix horizontal pixel coordinates when
788 hscroll is larger than the line width. Fixes long and futile
789 looping inside extend_face_to_end_of_line (on a TTY) producing
790 glyphs that are not needed and thrown away.
792 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
794 * marker.c (set_marker_restricted_both): Simplify by using
797 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
799 * editfns.c (region_limit): Simplify by using clip_to_bounds.
801 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
803 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
804 not defined (Bug#11768).
805 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
806 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
807 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
808 followed by gtk_box_set_homogeneous (Bug#11768).
809 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
810 (update_theme_scrollbar_width, xg_create_scroll_bar):
811 Use gtk_scrollbar_new (Bug#11768).
812 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
813 (is_box_type): New function (Bug#11768).
814 (xg_tool_item_stale_p): Call is_box_type.
815 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
816 with default display (Bug#11768).
818 2012-07-05 Eli Zaretskii <eliz@gnu.org>
820 * xdisp.c (window_hscroll_limited): New function.
821 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
822 coordinates when window's hscroll is set to insanely large
825 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
827 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
828 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
830 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
833 * lisp.h (xzalloc): New prototype. Omit needless casts.
834 * alloc.c (xzalloc): New function. Omit needless casts.
835 * charset.c: Omit needless casts. Convert all calls to
836 xmalloc with following memset to xzalloc.
837 * dispnew.c: Likewise.
838 * fringe.c: Likewise.
842 * w32fns.c: Likewise.
843 * w32font.c: Likewise.
844 * w32term.c: Likewise.
845 * xfaces.c: Likewise.
848 * atimer.c: Omit needless casts.
849 * buffer.c: Likewise.
850 * callproc.c: Likewise.
852 * coding.c: Likewise.
853 * composite.c: Likewise.
855 * doprnt.c: Likewise.
856 * editfns.c: Likewise.
859 * filelock.c: Likewise.
861 * gtkutil.c: Likewise.
862 * keyboard.c: Likewise.
865 * minibuf.c: Likewise.
868 * process.c: Likewise.
869 * region-cache.c: Likewise.
870 * search.c: Likewise.
871 * sysdep.c: Likewise.
872 * termcap.c: Likewise.
873 * terminal.c: Likewise.
874 * tparam.c: Likewise.
875 * w16select.c: Likewise.
877 * w32reg.c: Likewise.
878 * w32select.c: Likewise.
879 * w32uniscribe.c: Likewise.
880 * widget.c: Likewise.
884 * xselect.c: Likewise.
886 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
888 * fileio.c (time_error_value): Check the right error number.
889 Problem reported by Troels Nielsen in
890 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
892 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
894 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
895 This should be fixed in a better way; see Eli Zaretskii in
896 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
897 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
899 * fileio.c (time_error_value): Rename from special_mtime.
900 The old name's problems were noted by Eli Zaretskii in
901 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
903 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
904 This variable's comment says Emacs needs at least one GDB-visible
905 symbol of type enum pvec_type, to work around GDB problems.
906 The symbol's value doesn't matter.
908 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
909 that causes compilation to fail on pre-C99 compilers.
911 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
913 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
914 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
916 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
918 * buffer.c (init_buffer_once): Fix initialization of
919 headers for buffer_defaults and buffer_local_symbols.
920 Reported by Juanma Barranquero <lekktu@gmail.com>.
922 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
924 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
925 * lisp.h (enum pvec_type): Use fewer bits.
926 (PSEUDOVECTOR_SIZE_BITS): New constant.
927 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
928 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
930 (PSEUDOVECTOR_TYPEP): New macro.
931 (TYPED_PSEUDOVECTORP): Use it.
932 * fns.c (internal_equal): Adapt code to extract pvectype.
933 * emacs.c (gdb_pvec_type): Update type.
934 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
935 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
936 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
937 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
938 (sweep_vectors): Use it. Use local var `total_bytes' instead of
939 abusing vector->header.next.nbytes.
940 (live_vector_p): Use PVEC_TYPE.
941 (mark_object): Adapt code to extract pvectype. Use switch.
943 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
945 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
946 Tighten new eassert a bit.
948 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
950 Fix compilation with --enable-gcc-warnings and -O1
952 * doprnt.c (doprnt): Change type of tem to int, initialize
953 to avoid compiler warning. Add eassert.
954 * search.c (simple_search): Initialize match_byte to avoid
955 compiler warning. Add eassert.
957 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
959 Avoid weird behavior with large horizontal scrolls.
960 Without this change, for example, large hscroll values would
961 mess up Emacs's display on Fedora 15 x86, presumably due to
962 overflows in int calculations in the display code.
963 Also, if buffers had long lines, Emacs would freeze.
964 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
965 (set_window_hscroll): New function, containing the old guts of
966 Fset_window_hscroll. Return the clipped value.
967 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
968 This avoids the need to check against PTRDIFF_MAX.
970 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
972 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
974 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
976 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
978 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
979 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
980 since GCC 4.4.6 issues a bogus warning for them.
982 Fix bugs in file timestamp newness comparisons.
983 * fileio.c (Ffile_newer_than_file_p):
984 * lread.c (Fload): Use full timestamp resolution of files,
985 not just the 1-second resolution, so that files that are only
986 slightly newer still count as newer.
987 * fileio.c (Ffile_newer_than_file_p): Don't assume file
988 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
990 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
992 * fileio.c: Improve handling of file time marker. (Bug#11852)
993 (special_mtime): New function.
994 (Finsert_file_contents, Fverify_visited_file_modtime):
995 Use it to set special mtime values consistently.
997 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
999 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1000 marker for non-existing file. (Bug#11852)
1002 2012-07-03 Glenn Morris <rgm@gnu.org>
1004 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1005 and did not make it into globals.h).
1007 2012-07-03 Tom Tromey <tromey@redhat.com>
1009 * window.c (Fset_window_margins, Fset_window_fringes)
1010 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1011 * textprop.c (Fprevious_property_change): No longer static.
1012 * syntax.c (Fsyntax_table_p): No longer static.
1013 * process.c (Fget_process, Fprocess_datagram_address): No longer
1015 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1016 * keyboard.c (Fcommand_execute): No longer static.
1018 * insdel.c (Fcombine_after_change_execute): No longer static.
1019 * image.c (Finit_image_library): No longer static.
1020 * fileio.c (Fmake_symbolic_link): No longer static.
1021 * eval.c (Ffetch_bytecode): No longer static.
1022 * editfns.c (Fuser_full_name): No longer static.
1023 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1025 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1027 * dired.c (Ffile_attributes): No longer static.
1028 * composite.c (Fcomposition_get_gstring): No longer static.
1029 * callproc.c (Fgetenv_internal): No longer static.
1031 * ccl.h: Remove EXFUNs.
1032 * buffer.h: Remove EXFUNs.
1033 * dispextern.h: Remove EXFUNs.
1034 * intervals.h: Remove EXFUNs.
1035 * fontset.h: Remove EXFUN.
1036 * font.h: Remove EXFUNs.
1037 * dosfns.c (system_process_attributes): Remove EXFUN.
1038 * keymap.h: Remove EXFUNs.
1039 * lisp.h: Remove EXFUNs.
1040 * w32term.h: Remove EXFUNs.
1041 * window.h: Remove EXFUNs.
1042 * xsettings.h: Remove EXFUN.
1043 * xterm.h: Remove EXFUN.
1045 2012-07-03 Glenn Morris <rgm@gnu.org>
1047 * lisp.h (Frandom): Make it visible to C.
1048 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1049 buffer for invisible buffers. (Bug#1229)
1051 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1053 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1054 values which aren't power of 2.
1055 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1056 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1059 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1061 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1063 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1065 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1067 * alloc.c (allocate_vector_block): Remove redundant
1068 calls to mallopt if DOUG_LEA_MALLOC is defined.
1069 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1070 avoid calls to mallopt if zero_vector is returned.
1072 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1074 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1075 is enabled, avoid dereferencing NULL current_sblock if
1078 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1080 Cleanup basic buffer management.
1081 * buffer.h (struct buffer): Change layout to use generic vector
1082 marking code. Fix some comments. Change type of 'clip_changed'
1083 to bitfield. Remove unused #ifndef old.
1084 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1085 (GET_OVERLAYS_AT): Fix indentation.
1086 (for_each_per_buffer_object_at): New macro.
1087 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1088 (Fbuffer_local_variables): Use it.
1089 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1090 * alloc.c (allocate_buffer): Adjust to match new layout of
1091 struct buffer. Fix comment.
1092 (mark_overlay): New function.
1093 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1094 Lisp area of struct buffer.
1095 (mark_object): Use it. Adjust marking of misc objects
1096 and related comments.
1098 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1100 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1101 wrapper that is not needed because the wrapped code is a no-op (zero
1102 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1103 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1105 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1107 * alloc.c (mark_buffer): Simplify. Remove prototype.
1108 (mark_object): Add comment. Reorganize marking of vector-like
1109 objects. Use CHECK_LIVE for all vector-like objects except buffers
1110 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1111 redundant calls to mark_vectorlike for bool vectors.
1113 2012-06-30 Glenn Morris <rgm@gnu.org>
1115 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1117 * epaths.in (PATH_SITELOADSEARCH): New.
1118 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1119 This is rather than relying on --enable-locallisppath elements
1120 having "site-lisp" in their names. (Bug#10208#25, 11658)
1122 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1124 * w32proc.c (sys_select): Accept and ignore one more argument.
1126 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1128 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1129 (pselect) [!MS_DOS]: Redirect to sys_select.
1131 * sysdep.c: Don't include dos.h and dosfns.h.
1133 * process.c (sys_select):
1134 * msdos.c (sys_select): Accept one more argument and ignore it.
1136 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1137 adapt data types and code to that.
1140 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1141 which clashes with the gnulib function of the same name.
1143 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1145 * font.c (font_style_to_value, font_style_symbolic)
1146 (font_prop_validate_style): Add type checks for values in
1149 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1151 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1154 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1156 * xdisp.c (try_window_id): Undo last change.
1158 * w32.c (getwd): Adjust commentary about startup_dir.
1159 (init_environment): Always call sys_access, even in non-MSVC
1160 builds. Don't chdir to the directory of the Emacs executable.
1161 This undoes code from 1997 which was justified by the need to
1162 "avoid conflicts when removing and renaming directories". But its
1163 downside was that every relative file name was being interpreted
1164 relative to the directory of the Emacs executable, which can never
1165 be TRT. In particular, it broke sys_access when called with
1166 relative file names.
1167 (sys_access): Map GetLastError to errno.
1169 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1171 * window.h (struct window): Change type of 'fringes_outside_margins'
1172 to bitfield. Fix comment. Adjust users accordingly.
1173 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1175 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1178 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1180 * gnutls.c (emacs_gnutls_handshake):
1181 Add QUIT to make the loop interruptible.
1183 2012-06-29 Glenn Morris <rgm@gnu.org>
1185 * charset.c (init_charset): Make lack of etc/charsets fatal.
1187 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1189 * editfns.c (region_limit): Fix type mismatch.
1191 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1193 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1194 undefined. Convert from xassert to eassert.
1195 * nsmenu.m: Convert from xassert to eassert.
1196 * nsterm.m: Likewise.
1198 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1200 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1202 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1204 Avoid integer overflow on scroll-left and scroll-right.
1205 * window.c (HSCROLL_MAX): New macro.
1206 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1207 overflow when requested scroll falls outside ptrdiff_t range.
1209 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1211 * window.h (struct window): Change type of 'hscroll',
1212 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1213 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1214 Adjust users accordingly.
1215 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1216 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1217 from EMACS_INT to ptrdiff_t.
1218 (make_window): Omit redundant initialization.
1220 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1222 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1224 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1226 * window.h (struct window): Change type of 'use_time' and
1227 'sequence_number' from Lisp_Object to int.
1228 * frame.c (make_frame): Adjust users accordingly.
1229 * print.c (print_object): Likewise.
1230 * window.c (select_window, Fwindow_use_time, make_parent_window)
1231 (make_window): Likewise.
1233 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1235 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1236 enabled with --enable-checking=[all,glyphs] configure option.
1237 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1238 adjust comments accordingly.
1239 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1240 undefined, adjust comments accordingly.
1241 * image.c: Likewise.
1242 * scroll.c: Likewise.
1243 * w32fns.c: Likewise.
1244 * w32term.c: Likewise.
1245 * xdisp.c: Likewise.
1246 * xfaces.c: Likewise.
1248 * xterm.c: Likewise.
1250 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1252 Generalize run-time debugging checks.
1253 * dispextern.h (XASSERTS): Remove.
1254 * fontset.c (xassert): Remove.
1255 Convert from xassert to eassert.
1256 * alloc.c: Convert from xassert to eassert.
1258 * dispnew.c: Likewise.
1260 * fringe.c: Likewise.
1261 * ftfont.c: Likewise.
1262 * gtkutil.c: Likewise.
1263 * image.c: Likewise.
1264 * keyboard.c: Likewise.
1266 * process.c: Likewise.
1267 * scroll.c: Likewise.
1268 * sound.c: Likewise.
1270 * w32console.c: Likewise.
1271 * w32fns.c: Likewise.
1272 * w32term.c: Likewise.
1273 * window.c: Likewise.
1274 * xdisp.c: Likewise.
1275 * xfaces.c: Likewise.
1277 * xselect.c: Likewise.
1278 * xterm.c: Likewise.
1280 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1282 * fns.c (maybe_resize_hash_table): Output message when growing the
1285 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1287 * alloc.c (allocate_string_data): Remove dead code.
1288 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1289 avoid GCC warning about unused macro.
1291 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1293 * alloc.c (allocate_string): Omit intervals initialization.
1294 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1295 as in make_pure_string and make_pure_c_string.
1297 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1299 * alloc.c (allocate_string): Fix last change.
1301 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1303 * alloc.c (allocate_string): Remove two redundant calls
1304 to memset, add explicit initialization where appropriate.
1306 2012-06-27 Glenn Morris <rgm@gnu.org>
1308 * lisp.mk (lisp): Remove paths.elc.
1310 2012-06-27 Chong Yidong <cyd@gnu.org>
1312 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1314 2012-06-26 John Wiegley <johnw@newartisans.com>
1316 * unexmacosx.c (copy_data_segment): Add two section names used
1317 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1319 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1320 when building with Clang.
1322 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1324 * eval.c (Fapply): Allow calling it with a single argument.
1326 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1328 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1329 _stricmp and _strnicmp.
1330 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1332 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1334 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1336 (allocate_process): Likewise for new process.
1337 (allocate_terminal): Change to use offsetof.
1338 (allocate_frame): Likewise.
1339 * frame.c (make_frame): Omit redundant initialization.
1340 * window.c (make_parent_window): Use memset.
1341 (make_window): Omit redundant initialization.
1342 * process.c (make_process): Omit redundant initialization.
1343 * terminal.c (create_terminal): Likewise.
1345 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1347 * term.c (delete_tty): Remove redundant call to memset.
1349 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1351 * alloc.c: Remove build_string.
1352 * lisp.h: Define build_string as static inline. This provides
1353 a better opportunity to optimize away calls to strlen when the
1354 function is called with compile-time constant argument.
1355 * image.c (imagemagick_error): Convert to build_string.
1356 * w32proc.c (sys_spawnve): Likewise.
1357 * xterm.c (x_term_init): Likewise.
1359 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1361 Use sprintf return value instead of invoking strlen on result.
1362 In the old days this wasn't portable, since some sprintf
1363 implementations returned char *. But they died out years ago and
1364 Emacs already assumes sprintf returns int.
1365 Similarly for float_to_string.
1366 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1367 * ccl.c (ccl_driver):
1368 * character.c (string_escape_byte8):
1369 * data.c (Fnumber_to_string):
1370 * doprnt.c (doprnt):
1371 * print.c (print_object):
1372 * xdisp.c (message_dolog):
1373 * xfns.c (syms_of_xfns):
1374 Use sprintf or float_to_string result to avoid need to call strlen.
1375 * data.c (Fnumber_to_string):
1376 Use make_unibyte_string, since the string must be ASCII.
1377 * lisp.h, print.c (float_to_string): Now returns int length.
1378 * term.c (produce_glyphless_glyph):
1379 Use sprintf result rather than recomputing it.
1381 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1382 * Makefile.in (ALL_CFLAGS):
1383 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1384 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1386 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1388 * dispextern.h (xstrcasecmp): Define to library function
1389 strcasecmp if available.
1390 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1392 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1394 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1395 Avoid comma operator.
1396 * menu.c (push_submenu_start, push_submenu_end)
1397 (push_left_right_boundary, push_menu_pane): Likewise.
1398 * msdos.c (dos_rawgetc): Likewise.
1400 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1402 * xfns.c (xic_create_fontsetname): Remove redundant calls
1405 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1407 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1408 sprintf already null-terminates its output.
1410 * xfns.c (x_window): Remove redundant cast.
1412 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1414 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1415 `const char *' to `char *' to avoid compiler warning.
1417 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1419 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1420 instead of truncating it to 63 (admittedly a generous limit).
1422 * process.c: Fix spelling and caps in comments.
1424 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1426 * emacs.c (setpgrp): Remove definition, unused.
1427 * sysdep.c (setpgrp): Remove definition, not used in this file.
1429 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1431 * makefile.w32-in: Update dependencies.
1433 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1435 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1436 (SYSTIME_H): Add nt/inc/sys/time.h.
1438 * systime.h [WINDOWSNT]: Include sys/time.h.
1440 * s/ms-w32.h (struct timespec): Definition moved from
1441 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1443 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1445 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1446 * buffer.h (buffer_slot_type_mismatch):
1447 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1448 * eval.c (unwind_to_catch):
1449 * image.c (my_png_error, my_error_exit):
1450 * keyboard.c (quit_throw_to_read_char, user_error)
1451 (Fexit_recursive_edit, Fabort_recursive_edit):
1452 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1453 (wrong_type_argument, buffer_overflow, __executable_start)
1454 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1455 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1456 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1458 (child_setup) [!DOS_NT]:
1459 * lread.c (end_of_file_error, invalid_syntax):
1460 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1461 * puresize.h (pure_write_error):
1462 * search.c (matcher_overflow):
1463 * sound.c (sound_perror, alsa_sound_perror):
1464 * sysdep.c, syssignal.h (croak):
1465 * term.c (maybe_fatal, vfatal):
1466 * textprop.c (text_read_only):
1467 * undo.c (user_error):
1468 * unexmacosx.c (unexec_error):
1469 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1470 Use _Noreturn rather than NO_RETURN.
1471 No need for separate decl merely because of _Noreturn.
1472 * sound.c (sound_warning, parse_sound):
1473 Remove unnecessary forward decls.
1475 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1477 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1478 * lisp.h (WAIT_READING_MAX): New macro.
1479 * dispnew.c (Fsleep_for, sit_for):
1480 * keyboard.c (kbd_buffer_get_event):
1481 * process.c (Faccept_process_output):
1482 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1483 This improves on the previous patch, which introduced a bug
1484 when time_t is unsigned and as wide as intmax_t.
1485 See <http://bugs.gnu.org/9000#51>.
1487 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1489 * dispnew.c (sit_for, Fsleep_for):
1490 * keyboard.c (kbd_buffer_get_event):
1491 * process.c (Faccept_process_output): Avoid compiler warnings when
1492 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1494 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1496 * makefile.w32-in: Update dependencies.
1498 * w32.c (ltime): Add return type and declare static.
1499 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1501 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1503 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1504 Privately reported by Herbert J. Skuhra.
1505 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1507 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1508 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1510 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1512 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1513 last argument of make_unibyte_string.
1515 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1516 language ID in the event parameters.
1518 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1519 event.code, not the obscure "character set ID".
1521 2012-06-23 Chong Yidong <cyd@gnu.org>
1523 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1525 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1527 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1528 * w32.c (fdutimens): New function.
1530 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1532 * s/ms-w32.h (pselect): Redirect to sys_select.
1534 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1536 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1537 in the logic of incrementing and decrementing the value of
1538 use_relocatable_buffers.
1540 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1542 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1543 Privately reported by Herbert J. Skuhra.
1544 [__FreeBSD__]: Remove "*/" typo after "#include".
1545 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1546 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1547 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1548 Don't assume EMACS_TIME and struct timeval are the same type.
1550 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1552 Support higher-resolution time stamps (Bug#9000).
1553 The time stamps are only nanosecond-resolution at the C level,
1554 since that's the best that any real-world system supports now.
1555 But they are picosecond-resolution at the Lisp level, as that's
1556 easy, and leaves room for future OS improvements.
1558 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1561 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1562 Don't get current time unless it's needed.
1564 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1565 now provides it if it's absent.
1566 (start_atimer): Port to higher-res time stamps.
1567 Check for time stamp overflow. Don't get current time more
1568 often than is needed.
1570 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1571 Include systime.h, not time.h.
1572 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1574 * dired.c: Include stat-time.h.
1575 (Ffile-attributes): File times now have higher resolution.
1577 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1578 (struct image): Timestamp now has higher resolution.
1580 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1581 has at least microseconds now. All uses removed.
1582 (update_frame, update_single_window, update_window, update_frame_1)
1583 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1585 * editfns.c (time_overflow): Now extern.
1586 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1587 (float-time, Fformat_time_string, Fcurrent_time_string)
1588 (Fcurrent_time_zone): Accept and generate higher-resolution
1590 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1591 (decode_time_components, lisp_seconds_argument): New functions.
1592 (make_time): Now static.
1593 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1594 Report an error if the time is invalid, rather than having the caller
1597 * fileio.c: Include <stat-time.h>
1598 (Fcopy_file): Copy higher-resolution time stamps.
1599 Prefer to set the time stamp via a file descriptor if that works.
1600 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1601 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1602 (Fvisited_file_modtime, Fset_visited_file_modtime):
1603 Support higher-resolution time stamps.
1605 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1607 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1609 * image.c (prepare_image_for_display, clear_image_cache)
1610 (lookup_image): Port to higer-resolution time stamps.
1612 * keyboard.c (start_polling, bind_polling_period):
1613 Check for time stamp overflow.
1614 (read_char, kbd_buffer_get_event, timer_start_idle)
1615 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1616 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1617 Port to higher-resolution time stamps. Do not assume time_t is signed.
1618 (decode_timer): New function. Timers are now vectors of length 9,
1619 not 8, to accommodate the picosecond component.
1620 (timer_check_2): Use it.
1622 * nsterm.m (select_timeout, timeval_subtract): Remove.
1623 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1624 as they're a bit more accurate and handle overflow better.
1625 (ns_select): Change prototype to be compatible with pselect.
1626 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1627 * nsterm.h (ns_select): Adjust prototype.
1629 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1630 us-resolution time stamps.
1631 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1633 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1635 * lisp.h (time_overflow): New decl.
1636 (wait_reading_process_output): First arg is now intmax_t, not int,
1637 to accommodate larger waits.
1639 * process.h (struct Lisp_Process.read_output_delay):
1640 Now counts nanoseconds, not microseconds.
1641 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1643 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1644 (wait_reading_process_output):
1645 Port to ns-resolution time stamps.
1646 (Faccept_process_output, wait_reading_process_output):
1647 Check for time stamp overflow. Do not assume time_t is signed.
1648 (select_wrapper): Remove; we now use pselect.
1649 (Fprocess_attributes): Now generates ns-resolution time stamps.
1651 * sysdep.c: Include utimens.h. Don't include utime.h
1652 or worry about struct utimbuf; gnulib does that for us now.
1653 (gettimeofday): Remove; gnulib provides a substitute.
1654 (make_timeval): New function.
1655 (set_file_times): Now sets ns-resolution time stamps.
1656 New arg FD; all uses changed.
1657 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1658 (system_process_attributes):
1659 Now returns ns-resolution time stamp. All uses changed.
1660 Check for time stamp overflow.
1662 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1663 provides a substitute now.
1665 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1666 since it guarantees struct timespec.
1667 (EMACS_TIME): Now struct timespec, so that we can support
1668 ns-resolution time stamps.
1669 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1670 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1671 (EMACS_USECS): Remove.
1672 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1673 so multiply the arg by 1000 before storing it.
1674 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1676 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1677 Port to ns-resolution time stamps.
1678 (EMACS_TIME_NEG_P): Remove; replaced by....
1679 (EMACS_TIME_SIGN): New macro.
1680 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1681 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1682 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1683 (make_timeval, make_lisp_time, decode_time_components): New decls.
1684 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1685 that it mishandled time_t overflow. You can't compare by subtracting!
1686 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1687 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1689 * term.c: Include <sys/time.h>.
1690 (timeval_to_Time): New function, for proper overflow wraparound.
1691 (term_mouse_position, term_mouse_click): Use it.
1693 * undo.c (record_first_change): Support higher-resolution time stamps
1695 (Fprimitive_undo): Use them when restoring time stamps.
1697 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1698 (w32_get_internal_run_time):
1699 Port to higher-resolution Emacs time stamps.
1700 (ltime): Now accepts single 64-bit integer, as that's more convenient
1703 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1705 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1706 for compatibility with pselect. Support ns-resolution time stamps.
1708 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1710 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1711 Check for time stamp overflow, and support ns-resolution time stamps.
1713 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1714 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1715 (timeval_subtract): Remove; no longer needed.
1716 (XTflash, XTring_bell, x_wait_for_event):
1717 Port to ns-resolution time stamps. Don't assume time_t is signed.
1719 2012-06-22 Chong Yidong <cyd@gnu.org>
1721 * xdisp.c (x_consider_frame_title): Revert last change.
1723 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1725 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1726 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1727 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1728 staticidx goes up to 1597 out of 1600 = 0x640.)
1730 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1732 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1733 Otherwise, the umask might be mistakenly 0 while handling input signals.
1735 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1737 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1739 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1741 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1742 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1743 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1744 access to `contents' member of Lisp_Vector objects with AREF and ASET
1747 2012-06-19 Chong Yidong <cyd@gnu.org>
1749 * frame.c (delete_frame): When selecting a frame on a different
1750 text terminal, do not alter the terminal's top-frame.
1752 * xdisp.c (format_mode_line_unwind_data): Record the target
1753 frame's selected window and its terminal's top-frame.
1754 (unwind_format_mode_line): Restore them.
1755 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1757 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1758 since tty frames can be explicitly named.
1759 (prepare_menu_bars): Likewise.
1761 * term.c (Ftty_top_frame): New function.
1763 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1765 Port byte-code-meter to modern targets.
1766 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1767 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1768 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1769 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1770 (METER_1, METER_2): Simplify.
1772 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1774 * data.c (Fdefalias): Return `symbol' (bug#11686).
1776 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1778 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1779 gets killed during executing of this function (Bug#11665).
1780 Try to always return Qt when the buffer has been actually killed.
1781 (Vkill_buffer_query_functions): In doc-string say that functions
1782 run by this hook should not change the current buffer.
1784 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1786 Fix recently-introduced process.c problems found by static checking.
1787 * process.c (write_queue_push, write_queue_pop, send_process):
1788 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1789 (write_queue_pop): Fix pointer signedness problem.
1790 (send_process): Remove unused local.
1792 2012-06-17 Chong Yidong <cyd@gnu.org>
1794 * xdisp.c (redisplay_internal): No need to redisplay terminal
1795 frames that are not on top.
1797 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1799 * process.c (make_process): Initialize write_queue.
1800 (write_queue_push, write_queue_pop): New functions.
1801 (send_process): Use them to maintain correct ordering of process
1804 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1806 * lisp.h (eassert): Assume C89 or later.
1807 This removes the need for CHECK.
1808 (CHECK): Remove. Its comments about always evaluating its
1809 argument were confusing, as 'eassert' typically does not evaluate
1812 * coding.c (produce_chars): Use ptrdiff_t, not int.
1814 * xterm.c (x_draw_underwave): Check for integer overflow.
1815 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1817 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1819 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1820 referenced (Bug#11583).
1822 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1824 Implement wave-style variant of underlining.
1825 * dispextern.h (face_underline_type): New enum.
1826 (face): Add field for underline type.
1827 * nsterm.m (ns_draw_underwave): New function.
1828 (ns_draw_text_decoration): Use it.
1829 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1831 (x_draw_glyph_string): Use them.
1832 * xfaces.c (Qline, Qwave): New Lisp objects.
1833 (check_lface_attrs, merge_face_ref)
1834 (Finternal_set_lisp_face_attribute, realize_x_face):
1835 Handle wave-style underline face attributes.
1836 * xterm.c (x_draw_underwave): New function.
1837 (x_draw_glyph_string): Use it.
1839 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1841 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1842 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1843 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1844 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1845 ($(BLD)/w32select.$(O)): Update dependencies.
1847 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1849 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1850 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1851 * character.c (_fetch_multibyte_char_p): Remove.
1852 * alloc.c: Include "character.h" before "buffer.h".
1854 * buffer.c: Likewise.
1855 * bytecode.c: Likewise.
1856 * callint.c: Likewise.
1857 * callproc.c: Likewise.
1858 * casefiddle.c: Likewise.
1859 * casetab.c: Likewise.
1860 * category.c: Likewise.
1862 * coding.c: Likewise.
1863 * composite.c: Likewise.
1864 * dired.c: Likewise.
1865 * dispnew.c: Likewise.
1867 * dosfns.c: Likewise.
1868 * editfns.c: Likewise.
1869 * emacs.c: Likewise.
1870 * fileio.c: Likewise.
1871 * filelock.c: Likewise.
1873 * fontset.c: Likewise.
1874 * fringe.c: Likewise.
1875 * indent.c: Likewise.
1876 * insdel.c: Likewise.
1877 * intervals.c: Likewise.
1878 * keyboard.c: Likewise.
1879 * keymap.c: Likewise.
1880 * lread.c: Likewise.
1881 * macros.c: Likewise.
1882 * marker.c: Likewise.
1883 * minibuf.c: Likewise.
1884 * nsfns.m: Likewise.
1885 * nsmenu.m: Likewise.
1886 * print.c: Likewise.
1887 * process.c: Likewise.
1888 * regex.c: Likewise.
1889 * region-cache.c: Likewise.
1890 * search.c: Likewise.
1891 * syntax.c: Likewise.
1893 * textprop.c: Likewise.
1895 * unexsol.c: Likewise.
1896 * w16select.c: Likewise.
1897 * w32fns.c: Likewise.
1898 * w32menu.c: Likewise.
1899 * window.c: Likewise.
1900 * xdisp.c: Likewise.
1902 * xmenu.c: Likewise.
1904 * xselect.c: Likewise.
1906 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1908 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1909 If all the glyphs of the glyph row came from strings, and we have no
1910 cursor positioning clues, put the cursor on the first glyph of the
1912 (handle_face_prop): Use chunk-relative overlay string index when
1913 indexing into it->string_overlays array. (Bug#11653)
1914 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1915 the rightmost. (Bug#11720)
1917 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1919 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1920 (CATEGORY_MEMBER): Enforce 1/0 value.
1921 * category.c (_temp_category_set): Remove.
1923 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1925 * window.c (Fdelete_other_windows_internal)
1926 (Fdelete_window_internal): Don't access frame's mouse highlight
1927 info of the initial frame. (Bug#11677)
1929 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1931 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1932 Assume USE_2_TAGS_FOR_INTS.
1933 (xreload): Adjust $tagmask width to match recent lisp.h change.
1935 Simplify lisp.h in minor ways that should not affect code.
1936 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1937 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1938 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1939 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1940 (INTTYPEBITS): New macro, for clarity.
1941 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1942 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1943 Simplify now that USE_LSB_TAG is always defined.
1944 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1945 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1947 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1949 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1951 2012-06-13 Glenn Morris <rgm@gnu.org>
1953 * s/bsd-common.h (BSD4_3):
1954 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1956 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1958 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1961 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1963 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1964 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1965 * alloc.c (widen_to_Lisp_Object): Remove.
1966 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1967 * frame.c (delete_frame): Remove outdated comment.
1968 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1969 USE_LISP_UNION_TYPE.
1970 (Fw32_unregister_hot_key): Likewise.
1971 (Fw32_toggle_lock_key): Likewise.
1972 * w32menu.c (add_menu_item): Likewise.
1973 (w32_menu_display_help): Use XIL instead of checking
1974 USE_LISP_UNION_TYPE.
1975 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1976 (init_heap): Likewise.
1977 * w32term.c (w32_read_socket): Update comment.
1979 2012-06-13 Glenn Morris <rgm@gnu.org>
1981 * s/usg5-4-common.h, src/s/unixware.h:
1982 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1984 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1986 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1988 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1989 * alloc.c (make_number) [!defined make_number]:
1990 Remove, as lisp.h always defines this now.
1991 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1992 (roundup_size): Verify that it is a power of 2.
1993 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1994 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1995 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1996 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1997 USE_LSB_TAG now is always defined to be either 0 or 1.
1999 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2000 code works fine either way, and efficiency is not a concern here,
2001 as the union type is for debugging, not for production.
2002 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2003 Use an inline function on all platforms when using the union type,
2004 since this is simpler and 'static inline' can be used portably
2006 (LISP_INITIALLY_ZERO): New macro.
2007 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2008 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2010 2012-06-12 Glenn Morris <rgm@gnu.org>
2012 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2014 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2016 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2017 Move BROKEN_SIGIO to configure.
2019 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2020 Move NO_TERMIO to configure.
2022 2012-06-12 Chong Yidong <cyd@gnu.org>
2024 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2025 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2026 MagickExportImagePixels is undefined.
2028 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2030 * image.c (imagemagick_load_image): Remove unused label.
2032 2012-06-11 Glenn Morris <rgm@gnu.org>
2034 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2035 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2036 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2037 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2039 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2041 * alloc.c (make_byte_code): New function.
2042 (Fmake_byte_code): Use it. Don't purify here.
2043 * lread.c (read1): Use it as well to avoid extra allocation.
2045 2012-06-11 Chong Yidong <cyd@gnu.org>
2047 * image.c (imagemagick_load_image): Implement transparency.
2049 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2051 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2052 account for preceding backslashes. (Bug#11663)
2054 2012-06-09 Chong Yidong <cyd@gnu.org>
2056 * term.c: Support italics in capable terminals (Bug#9652).
2057 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2058 (turn_on_face): Output using TS_enter_italic_mode if available.
2059 Don't handle unused blinking and alt-charset cases.
2060 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2061 and tty_alt_charset_p cases.
2062 (tty_capable_p, init_tty): Support italics.
2064 * termchar.h (struct tty_display_info): Add field for italics.
2065 Remove unused blink field.
2067 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2070 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2071 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2072 tty_alt_charset_p. Add tty_italic_p.
2074 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2076 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2077 dbus_type_is_basic if available.
2078 (xd_extract_signed, xd_extract_unsigned): Rename from
2079 extract_signed and extract_unsigned, respectively. Adapt callers.
2081 2012-06-09 Chong Yidong <cyd@gnu.org>
2083 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2085 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2088 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2090 * xdisp.c (vmessage): Treat frame message as multibyte.
2091 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2092 would generate the diagnostic "Making \302\247 buffer-local while
2095 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2097 * dispnew.c (showing_window_margins_p): Undo last change, which
2098 was done due to an inadvertent commit.
2099 (adjust_frame_glyphs_for_frame_redisplay): Do call
2100 showing_window_margins_p.
2102 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2104 * eval.c (Fmake_var_non_special): New primitive.
2105 (syms_of_eval): Defsubr it.
2106 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2108 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2110 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2111 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2113 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2115 * alloc.c (allocate_vectorlike): Fix last change.
2117 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2119 Block-based vector allocation of small vectors.
2120 * lisp.h (struct vectorlike_header): New field `nbytes',
2121 adjust comment accordingly.
2122 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2123 to denote vector blocks. Adjust users (live_vector_p,
2124 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2125 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2126 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2127 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2128 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2129 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2130 (roundup_size): New constant.
2131 (struct vector_block): New data type.
2132 (vector_blocks, vector_free_lists, zero_vector): New variables.
2133 (all_vectors): Rename to `large_vectors'.
2134 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2135 (sweep_vectors): New functions.
2136 (allocate_vectorlike): Return `zero_vector' as the only vector of
2137 0 items. Allocate new vector from block if vector size is less than
2138 or equal to VBLOCK_BYTES_MAX.
2139 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2140 (init_alloc_once): Add call to init_vectors.
2142 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2144 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2146 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2148 * doprnt.c (doprnt): Truncate multibyte char correctly.
2149 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2150 would mishandle a string argument "Xc" if X was a multibyte
2151 character of length 2: it would truncate after X's first byte
2152 rather than including all of X.
2154 2012-06-06 Chong Yidong <cyd@gnu.org>
2156 * buffer.c (word_wrap): Doc fix.
2158 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2160 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2162 2012-06-03 Glenn Morris <rgm@gnu.org>
2164 * xdisp.c (tool-bar-style): Doc fix.
2166 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2168 * Makefile.in (PAXCTL): Define.
2169 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2170 binary via PaX flags if the paxctl utility is available.
2171 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2172 Restore PaX flags to their default. (Bug#11398)
2174 2012-06-03 Chong Yidong <cyd@gnu.org>
2176 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2179 2012-06-03 Chong Yidong <cyd@gnu.org>
2181 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2182 (note_mode_line_or_margin_highlight): If there is no help echo,
2183 use mode-line-default-help-echo. Handle the case where the mouse
2184 position is past the end of the mode line string.
2186 * buffer.c (buffer_local_value_1): New function, split from
2187 Fbuffer_local_value; can return Qunbound.
2188 (Fbuffer_local_value): Use it.
2189 (Vmode_line_format): Docstring tweaks.
2191 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2193 * sysdep.c (system_process_attributes): Improve comment.
2195 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2197 * keyboard.c: Export real-this-command to Elisp.
2198 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2199 and DEFVAR it. Update all users.
2201 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2203 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2205 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2206 Convert pctcpu and pctmem to Lisp float properly.
2207 Let the compiler fold better, as 100.0/0x8000 is exact.
2209 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2211 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2214 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2216 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2218 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2220 For a 'struct window', replace some Lisp_Object fields to
2221 bitfields where appropriate, remove unused fields.
2222 * window.h (struct window): Remove unused 'last_mark_x' and
2223 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2224 change it's type from Lisp_Object to bitfield.
2225 Change type of 'force_start', 'optional_new_start',
2226 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2227 fields from Lisp_Object to bitfield. Adjust users accordingly.
2229 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2231 Pacify gcc -Wdouble-precision when using Xaw.
2232 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2233 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2234 Use 'float' consistently, rather than 'float' in most places
2235 and 'double' in a couple of places.
2237 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2239 * xdisp.c (handle_stop): Detect whether we have overlay strings
2240 loaded by testing it->current.overlay_string_index to be
2241 non-negative, instead of checking whether n_overlay_strings is
2242 positive. (Bug#11587)
2244 2012-05-31 Chong Yidong <cyd@gnu.org>
2246 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2248 * doc.c (Fsubstitute_command_keys): Doc fix.
2250 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2252 * search.c (search_buffer): Remove calls to
2253 r_alloc_inhibit_buffer_relocation, as it is now called by
2254 maybe_unify_char, which was the cause of relocation of buffer text
2257 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2259 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2260 for the duration of call to load_charset, to avoid problems with
2261 callers of maybe_unify_char that access buffer text through C
2264 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2265 decrement the inhibition flag, instead of just setting or
2268 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2270 Remove obsolete '#define static' cruft.
2271 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2272 This #undef was "temporary" in 2000; it is no longer needed
2273 now that '#define static' has gone away.
2274 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2275 (gray_bitmap_bits): Remove; no longer needed.
2276 All uses replaced with definiens.
2277 * xterm.c: Include "bitmaps/gray.xbm".
2279 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2281 Clean up __executable_start, monstartup when --enable-profiling.
2282 The following changes affect the code only when profiling.
2283 * dispnew.c (__executable_start): Rename from safe_bcopy.
2284 Define only on platforms that need it.
2285 * emacs.c: Include <sys/gmon.h> when profiling.
2286 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2287 (__executable_start): Remove decl, since lisp.h does it now.
2288 (safe_bcopy): Remove decl; no longer has that name.
2289 (main): Coalesce #if into single bit of code, for simplicity.
2290 Cast pointers to uintptr_t, since standard libraries want integers
2292 * lisp.h (__executable_start): New decl.
2294 2012-05-31 Glenn Morris <rgm@gnu.org>
2296 * image.c (Fimagemagick_types): Doc fix.
2298 2012-05-30 Jim Meyering <meyering@redhat.com>
2300 * callproc.c (Fcall_process_region): Include directory component
2301 in mkstemp error message (Bug#11586).
2303 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2305 * alloc.c, lisp.h (make_pure_vector): Now static.
2307 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2309 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2310 Move to byte-run.el.
2311 (Fautoload): Do the hash-doc more carefully.
2312 * data.c (Fdefalias): Purify definition, except for keymaps.
2313 (Qdefun): Move from eval.c.
2314 * lisp.h (Qdefun): Remove.
2315 * lread.c (read1): Tiny simplification.
2317 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2319 Do not create empty overlays with the evaporate property (Bug#9642).
2320 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2321 Bug#9642, but explicitly check that the buffer the overlay would
2322 be moved to is live and rearrange lines to make sure that errors
2323 will not put the overlay in an inconsistent state.
2324 (Fdelete_overlay): Cosmetics.
2326 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2328 * w32term.c (my_bring_window_to_top): New function.
2329 (x_raise_frame): Use handle returned by DeferWindowPos, which
2330 could be different from the original one.
2331 Call my_bring_window_to_top instead of my_set_foreground_window.
2334 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2335 by calling BringWindowToTop.
2337 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2338 (WM_EMACS_END): Increase by one.
2340 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2342 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2343 This avoids undefined behavior that might cause the eassert
2344 to not catch an out-of-range value.
2346 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2348 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2349 Update dependencies.
2351 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2353 * bidi.c (bidi_mirror_char): Fix last change.
2355 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2357 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2358 when referring to sectname field in printf format.
2360 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2362 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2363 Only r_alloc_inhibit_buffer_relocation needed to be added;
2364 the others were already declared.
2366 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2367 before checking whether it's out of range. Put the check inside
2369 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2371 2012-05-27 Ken Brown <kbrown@cornell.edu>
2373 * callproc.c (Fcall_process): Restore a line that was accidentally
2374 commented out in the 2011-02-13 change (bug#11547).
2376 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2378 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2379 defined on ralloc.c.
2381 * buffer.c [REL_ALLOC]: Remove prototypes of
2382 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2383 they are now on lisp.h.
2385 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2387 * search.c (search_buffer): Use it to inhibit relocation of buffer
2388 text while re_search_2 is doing its job, because re_search_2 is
2389 passed C pointers to buffer text. (Bug#11519)
2391 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2394 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2395 state after an additional call to move_it_in_display_line_to, keep
2396 the values of it->max_ascent and it->max_descent found for the
2398 (pos_visible_p): Revert the comparison against bottom_y to what it
2399 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2402 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2404 Fix coding-related core dumps with gcc -ftrapv.
2405 The code was computing A - B, where A and B are pointers, and B is
2406 random garbage. This can lead to core dumps on platforms that
2407 have special pointer registers, and it also leads to core dumps on
2408 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2409 A - B only when B is initialized properly.
2410 * coding.c (coding_set_source, coding_set_destination): Return void.
2411 (coding_change_source, coding_change_destinations): New functions,
2412 with the old behaviors of coding_set_source and coding_set_destination.
2413 All callers that need an offset changed to use these new functions.
2415 2012-05-26 Glenn Morris <rgm@gnu.org>
2417 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2419 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2421 Extend mouse support on W32 text-mode console.
2422 * xdisp.c (draw_row_with_mouse_face):
2423 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2425 * w32console.c: Include window.h.
2426 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2428 (initialize_w32_display): Initialize mouse-highlight data.
2430 * w32inevt.c: Include termchar.h and window.h.
2431 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2432 moves, call note_mouse_highlight. If help_echo changed, call
2433 gen_help_event to produce help-echo message in the echo area.
2434 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2437 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2439 * lread.c (read1): Simplify slightly to avoid an overflow warning
2440 with GCC 4.7.0 on x86-64.
2442 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2444 * bidi.c (bidi_mirror_char): Revert last change: an int is
2445 definitely wide enough here.
2447 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2449 Fix integer width and related bugs (Bug#9874).
2450 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2451 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2452 (string_bytes, check_sblock, allocate_string_data):
2453 (compact_small_strings, Fmake_bool_vector, make_string)
2454 (make_unibyte_string, make_multibyte_string)
2455 (make_string_from_bytes, make_specified_string)
2456 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2457 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (allocate_pseudovector):
2461 Use int, not EMACS_INT, where int is wide enough.
2462 (inhibit_garbage_collection, Fgarbage_collect):
2463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2464 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2465 int might not be wide enough.
2466 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2467 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2468 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2469 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2470 (bidi_level_of_next_char, bidi_move_to_visually_next):
2471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2472 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2473 (Fkill_buffer, Fset_buffer_major_mode)
2474 (advance_to_char_boundary, Fbuffer_swap_text)
2475 (Fset_buffer_multibyte, overlays_at, overlays_in)
2476 (overlay_touches_p, struct sortvec, record_overlay_string)
2477 (overlay_strings, recenter_overlay_lists)
2478 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2479 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2480 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2481 (Foverlay_recenter, last_overlay_modification_hooks_used)
2482 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2484 (validate_region): Omit unnecessary test for b <= e,
2485 since that's guaranteed by the previous test.
2486 (adjust_overlays_for_delete): Avoid pos + length overflow.
2487 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2488 (report_overlay_modification):
2489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2490 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2491 Omit pointer cast, which isn't needed anyway, and doesn't work
2492 after the EMACS_INT -> ptrdiff_t change.
2493 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2494 * buffer.h: Adjust decls to match defn changes elsewhere.
2495 (struct buffer_text, struct buffer):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 Use EMACS_INT, not int, where int might not be wide enough.
2498 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2499 not int, to avoid needless 32-bit limit on 64-bit hosts.
2500 (exec_byte_code): Use tighter memory-full test, one that checks
2501 for alloca overflow. Don't compute the address of the object just
2502 before an array, as that's not portable. Use EMACS_INT, not
2503 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2504 * callint.c (Fcall_interactively):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 * callproc.c (call_process_kill, Fcall_process):
2507 Don't assume pid_t fits into an Emacs fixnum.
2508 (call_process_cleanup, Fcall_process, child_setup):
2509 Don't assume pid_t fits into int.
2510 (call_process_cleanup, Fcall_process, delete_temp_file)
2511 (Fcall_process_region):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (Fcall_process): Simplify handling of volatile integers.
2514 Use int, not EMACS_INT, where int will do.
2515 * casefiddle.c (casify_object, casify_region, operate_on_word)
2516 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2518 (casify_object): Avoid integer overflow when overallocating buffer.
2519 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2520 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2521 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2522 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2523 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2524 integers are now checked earlier. All uses replaced with XINT.
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 For CCL_MapSingle, check that content and value are in int range.
2528 (ccl_driver, Fregister_code_conversion_map):
2529 Check that Vcode_version_map_vector is a vector.
2530 (resolve_symbol_ccl_program): Check that vector header is in range.
2531 Always copy the vector, so that we can check its contents reliably
2532 now rather than having to recheck each instruction as it's being
2533 executed. Check that vector words fit in 'int'.
2534 (ccl_get_compiled_code, Fregister_ccl_program)
2535 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2536 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2537 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2538 contents are in range.
2539 (Fccl_execute_on_string): Check that status is in range.
2540 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2541 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2542 Accept and return EMACS_INT, not int, because callers can pass values
2544 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2545 (multibyte_chars_in_text, parse_str_as_multibyte)
2546 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2547 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2548 (string_escape_byte8, Fget_byte):
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2550 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2551 avoid mishandling large integers.
2552 * character.h: Adjust decls to match defn changes elsewhere.
2553 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2554 (Ffind_charset_region):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2557 (load_charset_map_from_vector, Fdefine_charset_internal):
2558 Don't assume fixnum fits in int.
2559 (load_charset_map_from_vector, Fmap_charset_chars):
2560 Remove now-unnecessary CHECK_NATNUMs.
2561 (Fdefine_charset_internal): Check ranges here, more carefully.
2562 Don't rely on undefined behavior with signed left shift overflow.
2563 Don't assume unsigned int fits into fixnum, or that fixnum fits
2564 into unsigned int. Don't require max_code to be a valid fixnum;
2565 that's not true for gb10830 4-byte on a 32-bit host. Allow
2566 invalid_code to be a cons, for the same reason. Require code_offset
2567 to be a character. Avoid int overflow if max_char is close
2569 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2570 this is intended anyway and avoids some undefined behavior.
2571 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2572 INDEX_TO_CODE_POINT, as that's what it expects.
2573 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2574 * charset.h (DECODE_CHAR): Return int, not unsigned;
2575 this is what was intended anyway, and it avoids undefined behavior.
2576 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2577 integer-overflow issues.
2578 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2579 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2580 where the argument is EMACS_INT, and this behavior is not intended.
2581 * chartab.c (Fmake_char_table, Fset_char_table_range)
2582 (uniprop_get_decoder, uniprop_get_encoder):
2583 Don't assume fixnum fits in int.
2584 * cmds.c (move_point): New function, that does the gist of
2585 Fforward_char and Fbackward_char, but does so while checking
2586 for integer overflow more accurately.
2587 (Fforward_char, Fbackward_char): Use it.
2588 (Fforward_line, Fend_of_line, internal_self_insert)
2589 (internal_self_insert):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 Fix a FIXME, by checking for integer overflow when calculating
2592 target_clm and actual_clm.
2593 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2594 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2595 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2596 (coding_alloc_by_making_gap, alloc_destination)
2597 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2598 (encode_coding_utf_16, detect_coding_emacs_mule)
2599 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2600 (detect_coding_iso_2022, decode_coding_iso_2022)
2601 (encode_invocation_designation, encode_designation_at_bol)
2602 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2603 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2604 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2605 (encode_coding_ccl, encode_coding_raw_text)
2606 (detect_coding_charset, decode_coding_charset)
2607 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2608 (produce_composition, produce_charset, produce_annotation)
2609 (decode_coding, handle_composition_annotation)
2610 (handle_charset_annotation, consume_chars, decode_coding_gap)
2611 (decode_coding_object, encode_coding_object, detect_coding_system)
2612 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2613 (code_convert_region, code_convert_string)
2614 (Fdefine_coding_system_internal)
2615 (coding_set_source, coding_set_destination):
2616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2617 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2618 (Fdefine_coding_system_internal):
2619 Don't assume fixnums fit in int.
2620 (decode_coding_gap, decode_coding_object, encode_coding_object)
2621 (Fread_coding_system, Fdetect_coding_region)
2622 (Funencodable_char_position, Fcheck_coding_systems_region)
2623 (get_translation, handle_composition_annotation, consume_chars):
2624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2625 (consume_chars): Rewrite to not calculate an address outside buffer.
2626 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2627 Don't access memory outside of the args array.
2628 (Fdefine_coding_system_internal): Check for charset-id overflow.
2629 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2630 result of ENCODE_CHAR.
2631 * coding.h: Adjust decls to match defn changes elsewhere.
2632 (struct coding_system):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 * composite.c (get_composition_id, find_composition)
2635 (run_composition_function, update_compositions)
2636 (compose_text, composition_gstring_put_cache)
2637 (composition_gstring_p, composition_gstring_width)
2638 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2639 (composition_compute_stop_pos, composition_reseat_it)
2640 (composition_update_it, struct position_record)
2641 (find_automatic_composition, composition_adjust_point)
2642 (Fcomposition_get_gstring, Ffind_composition_internal):
2643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2644 (update_compositions):
2645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2646 * composite.h: Adjust decls to match defn changes elsewhere.
2647 (struct composition):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2650 Do not attempt to compute the address of the object just before a
2651 buffer; this is not portable.
2653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2654 (Faset): Use int, not EMACS_INT, where int is wide enough.
2655 (Fstring_to_number): Don't assume fixnums fit in int.
2656 (Frem): Don't assume arg is nonnegative.
2657 * dbusbind.c (xd_append_arg): Check for integers out of range.
2658 (Fdbus_call_method): Don't overflow the timeout int.
2659 (extract_signed, extract_unsigned): New functions.
2660 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2661 (xd_get_connection_references): Return ptrdiff_t, not int.
2663 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2664 (xd_read_message_1):
2665 Use int, not unsigned, where the dbus API uses int.
2666 (Fdbus_message_internal): Don't overflow mtype.
2667 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2668 * dired.c (directory_files_internal, file_name_completion, scmp)
2669 (file_name_completion_stat):
2670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2671 (file_name_completion): Don't overflow matchcount.
2672 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2673 * dispextern.h: Adjust decls to match defn changes elsewhere.
2674 (struct text_pos, struct glyph, struct bidi_saved_info)
2675 (struct bidi_string_data, struct bidi_it, struct composition_it)
2677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2678 (struct display_pos, struct composition_it, struct it):
2679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2680 * dispnew.c (increment_matrix_positions)
2681 (increment_row_positions, mode_line_string)
2682 (marginal_area_string):
2683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2684 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2686 (duration_to_sec_usec): New function, to check for overflow better.
2687 (Fsleep_for, sit_for): Use it.
2688 * doc.c (get_doc_string, store_function_docstring):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (get_doc_string, Fsnarf_documentation):
2691 Use int, not EMACS_INT, where int is wide enough.
2693 Use SAFE_ALLOCA, not alloca.
2694 Check for overflow when converting EMACS_INT to off_t.
2695 * doprnt.c (doprnt):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2697 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2698 Don't assume uid_t fits into fixnum.
2699 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2700 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2701 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2702 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2703 (general_insert_function)
2704 (Finsert_char, make_buffer_string, make_buffer_string_both)
2705 (update_buffer_properties, Fbuffer_substring)
2706 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2707 (Fsubst_char_in_region, check_translation)
2708 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2709 (transpose_markers, Ftranspose_regions):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2711 (clip_to_bounds): Move to lisp.h as an inline function).
2712 (Fconstrain_to_field): Don't assume integers are nonnegative.
2713 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2714 (Fsubst_char_in_region, Fsave_restriction):
2715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2716 (Femacs_pid): Don't assume pid_t fits into fixnum.
2717 (lo_time): Use int, not EMACS_INT, when int suffices.
2718 (lisp_time_argument): Check for usec out of range.
2719 (Fencode_time): Don't assume fixnum fits in int.
2720 (Fuser_login_name, Fuser_full_name): Signal an error
2721 if a uid argument is out of range, rather than relying on
2723 (Fformat_time_string): Remove now-unnecessary check.
2724 lisp_time_argument checks for out-of-range usec now.
2725 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2726 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2727 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2728 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2729 (init_cmdargs, Fdump_emacs):
2730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2731 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2732 the bottom (typically) 32 bits of the fixnum.
2733 * eval.c (specpdl_size, call_debugger):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (when_entered_debugger, Fbacktrace_debug):
2736 Don't assume fixnum can fit in int.
2737 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2738 the object just before a buffer; this is not portable.
2739 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2740 (grow_specpdl, unbind_to):
2741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2742 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2743 (grow_specpdl): Simplify allocation by using xpalloc.
2744 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2745 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2746 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2751 (Fcopy_file, non_regular_nbytes, read_non_regular)
2752 (Finsert_file_contents):
2753 Use int, not EMACS_INT, where int is wide enough.
2754 (READ_BUF_SIZE): Verify that it fits in int.
2755 (Finsert_file_contents): Check that counts are in proper range,
2756 rather than assuming fixnums fit into ptrdiff_t etc.
2757 Don't assume fixnums fit into int.
2758 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2759 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2760 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2761 (string_char_to_byte, string_byte_to_char)
2762 (string_make_multibyte, string_to_multibyte)
2763 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2764 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2765 (substring_both, Fdelete, internal_equal, Ffillarray)
2766 (Fclear_string, mapcar1)
2767 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2768 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2769 (larger_vector, make_hash_table, maybe_resize_hash_table)
2770 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2771 (Fmaphash, secure_hash):
2772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2773 (concat): Check for string index and length overflow.
2774 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (larger_vector): New API (vec, incr_min, size_max) replaces old
2778 one (vec, new_size, init). This catches size overflow.
2779 INIT was removed because it was always Qnil.
2780 All callers changed.
2781 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2782 the upper bound on a hash table index size.
2783 (make_hash_table, maybe_resize_hash_table): Use it.
2784 (secure_hash): Computer start_byte and end_byte only after
2785 they're known to be in ptrdiff_t range.
2786 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2787 (Ffont_get_glyphs, Ffont_at):
2788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2789 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2790 (Flist_fonts, Fopen_font):
2791 Don't assume fixnum can fit in int.
2792 (check_gstring): Don't assume index can fit in int.
2793 (font_match_p): Check that fixnum is a character, not a nonnegative
2794 fixnum, since the later code needs to stuff it into an int.
2795 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2796 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2797 conversion overflow issues.
2798 (Fopen_font): Check for integer out of range.
2799 (Ffont_get_glyphs): Don't assume index can fit in int.
2800 * font.h: Adjust decls to match defn changes elsewhere.
2801 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2803 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2804 printmax_t, where ptrdiff_t is wide enough.
2805 (Finternal_char_font):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2808 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2809 (Fset_frame_position, x_set_frame_parameters)
2810 (x_set_line_spacing, x_set_border_width)
2811 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2812 Check that fixnums are in proper range for system types.
2813 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2815 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2816 Use SAFE_ALLOCA_LISP, not alloca.
2817 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2818 intptr_t is wide enough.
2819 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2820 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2821 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2822 Check for fixnum out of range.
2823 * ftfont.c (ftfont_list): Don't assume index fits in int.
2824 Check that fixnums are in proper range for system types.
2825 (ftfont_shape_by_flt):
2826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2827 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2829 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2830 Check that fixnums are in proper range for system types.
2831 * gnutls.h: Adjust decls to match defn changes elsewhere.
2832 * gtkutil.c (xg_dialog_run):
2833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2834 (update_frame_tool_bar):
2835 Check that fixnums are in proper range for system types.
2836 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2837 (lookup_image): Check that fixnums are in range for system types.
2838 * indent.c (last_known_column, last_known_column_point):
2839 (current_column_bol_cache):
2840 (skip_invisible, current_column, check_display_width):
2841 (check_display_width, scan_for_column, current_column_1)
2842 (Findent_to, Fcurrent_indentation, position_indentation)
2843 (indented_beyond_p, Fmove_to_column, compute_motion):
2844 (Fcompute_motion, Fvertical_motion):
2845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2846 (last_known_column_modified): Use EMACS_INT, not int.
2847 (check_display_width):
2849 Check that fixnums and floats are in proper range for system types.
2850 (compute_motion): Don't assume index or fixnum fits in int.
2851 (compute_motion, Fcompute_motion):
2852 Use int, not EMACS_INT, when it is wide enough.
2853 (vmotion): Omit local var start_hpos that is always 0; that way
2854 we don't need to worry about overflow in expressions involving it.
2855 * indent.h: Adjust decls to match defn changes elsewhere.
2857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2858 Use int, not EMACS_INT, where int is wide enough.
2859 Remove unused members ovstring_chars_done and tab_offset;
2861 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2862 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2863 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2864 (make_gap, copy_text, insert, insert_and_inherit)
2865 (insert_before_markers, insert_before_markers_and_inherit)
2866 (insert_1, count_combining_before, count_combining_after)
2867 (insert_1_both, insert_from_string)
2868 (insert_from_string_before_markers, insert_from_string_1)
2869 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2870 (adjust_after_replace, adjust_after_insert, replace_range)
2871 (replace_range_2, del_range, del_range_1, del_range_byte)
2872 (del_range_both, del_range_2, modify_region)
2873 (prepare_to_modify_buffer, signal_before_change)
2874 (signal_after_change, Fcombine_after_change_execute):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2877 (balance_an_interval, split_interval_right, split_interval_left)
2878 (find_interval, next_interval, update_interval)
2879 (adjust_intervals_for_insertion, delete_node, delete_interval)
2880 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2881 (static_offset_intervals, offset_intervals)
2882 (merge_interval_right, merge_interval_left, make_new_interval)
2883 (graft_intervals_into_buffer, temp_set_point_both)
2884 (temp_set_point, set_point, adjust_for_invis_intang)
2885 (set_point_both, move_if_not_intangible, get_property_and_range)
2886 (get_local_map, copy_intervals, copy_intervals_to_string)
2887 (compare_string_intervals, set_intervals_multibyte_1):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2889 * intervals.h: Adjust decls to match defn changes elsewhere.
2891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2892 * keyboard.c (this_command_key_count, this_single_command_key_start)
2893 (before_command_key_count, before_command_echo_length, echo_now)
2894 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2895 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2896 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2897 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2899 (last_non_minibuf_size, last_point_position, echo_truncate)
2900 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2901 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2902 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2903 (stuff_buffered_input):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (last_auto_save, command_loop_1, read_char):
2906 Use EMACS_INT, not int, to avoid integer overflow.
2907 (record_char): Avoid overflow in total_keys computation.
2908 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2909 * keyboard.h: Adjust decls to match defn changes elsewhere.
2910 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2911 (Fkey_description, Fdescribe_vector, Flookup_key):
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 (click_position): New function, to check that positions are in range.
2914 (Fcurrent_active_maps):
2916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2917 (Faccessible_keymaps, Fkey_description):
2918 (preferred_sequence_p):
2919 Don't assume fixnum can fit into int.
2920 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2921 Check for integer overflow in size calculations.
2922 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2923 avoid mishandling large integers.
2924 * lisp.h: Adjust decls to match defn changes elsewhere.
2925 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2926 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2927 (struct Lisp_Marker):
2928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2929 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2930 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2931 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2932 All callers changed.
2933 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2934 Assume the arg has valid form, since it always does.
2935 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2936 unsigned integer system type.
2937 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2938 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2940 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2941 (duration_to_sec_usec): New decl.
2942 * lread.c (read_from_string_index, read_from_string_index_byte)
2943 (read_from_string_limit, readchar, unreadchar, openp)
2944 (read_internal_start, read1, oblookup):
2945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2946 (Fload, readevalloop, Feval_buffer, Feval_region):
2947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2948 (openp): Check for out-of-range argument to 'access'.
2949 (read1): Use int, not EMACS_INT, where int is wide enough.
2950 Don't assume fixnum fits into int.
2951 Fix off-by-one error that can read outside a buffer.
2952 (read_filtered_event): Use duration_to_sec_usec
2953 to do proper overflow checking on durations.
2954 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2955 in size calculation.
2956 (Fexecute_kbd_macro):
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2959 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2960 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2961 (set_marker_both, set_marker_restricted_both, marker_position)
2962 (marker_byte_position, Fbuffer_has_markers_at):
2963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2964 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2965 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2966 It now merely ensures that the menu is large enough, without
2967 necessarily growing it, as this avoids some integer overflow issues.
2968 All callers changed.
2969 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2971 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2972 Use SAFE_ALLOCA_LISP, not alloca.
2973 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2974 to EMACS_INT. Check that fixnums are in proper range for system types.
2975 * minibuf.c (minibuf_prompt_width, string_to_object)
2976 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2977 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2979 (get_minibuffer, read_minibuf_unwind):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2982 this simplifies overflow checking. All callers changed.
2983 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2986 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2987 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2988 Check that fixnums are in proper range for system types.
2989 (Fx_create_frame, Fx_show_tip):
2990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2991 * nsfont.m (ns_findfonts, nsfont_list_family):
2992 Don't assume fixnum fits in long.
2993 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2995 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2997 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2999 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3000 (PRINTDECLARE, PRINTPREPARE):
3001 (strout, print_string):
3002 (print, print_preprocess, print_check_string_charset_prop)
3004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3006 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3008 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3009 (printchar, strout): Use xpalloc to catch size calculation overflow.
3010 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3011 (print_error_message): Use SAFE_ALLOCA, not alloca.
3012 (print_object): Use int, not EMACS_INT, where int is wide enough.
3013 (print_depth, new_backquote_output, print_number_index):
3014 Use ptrdiff_t, not int, where int might not be wide enough.
3015 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3016 (Fset_process_window_size, Fformat_network_address)
3017 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3019 Check that fixnums are in proper range for system types.
3020 (Fsignal_process): Simplify by avoiding a goto.
3021 Check for process-ids out of pid_t range rather than relying on
3023 (process_tick, update_tick): Use EMACS_INT, not int.
3024 (Fformat_network_address, read_process_output, send_process)
3025 (Fprocess_send_region, status_notify):
3026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3027 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3028 (wait_reading_process_output, read_process_output, exec_sentinel):
3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3030 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3031 (Faccept_process_output): Use duration_to_sec_usec to do proper
3032 overflow checking on durations.
3033 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3034 Don't assume pid_t fits in int.
3035 * process.h (struct Lisp_Process): Members tick and update_tick
3036 are now of type EMACS_INT, not int.
3037 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3038 configured --with-wide-int.
3039 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3040 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3041 * search.c (looking_at_1, string_match_1):
3042 (fast_string_match, fast_c_string_match_ignore_case)
3043 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3044 (scan_newline, find_before_next_newline, search_command)
3045 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3046 (set_search_regs, wordify):
3049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3050 (string_match_1, search_buffer, set_search_regs):
3052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3053 (wordify): Check for overflow in size calculation.
3054 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3055 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3056 Check that fixnums are in proper range for system types.
3057 * sound.c (struct sound_device)
3058 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3060 (Fplay_sound_internal):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 * syntax.c (struct lisp_parse_state, find_start_modiff)
3063 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3064 (Fparse_partial_sexp):
3065 Don't assume fixnums can fit in int.
3066 (struct lisp_parse_state, find_start_pos, find_start_value)
3067 (find_start_value_byte, find_start_begv)
3068 (update_syntax_table, char_quoted, dec_bytepos)
3069 (find_defun_start, prev_char_comend_first, back_comment):
3070 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3071 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (Finternal_describe_syntax_value): Check that match_lisp is a
3074 character, not an integer, since the code stuffs it into int.
3075 (scan_words, scan_sexps_forward):
3076 Check that fixnums are in proper range for system types.
3078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3079 (scan_sexps_forward):
3080 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3081 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3082 * syntax.h: Adjust decls to match defn changes elsewhere.
3083 (struct gl_state_s):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3086 MOST_POSITIVE_FIXNUM.
3087 * sysdep.c (wait_for_termination_1, wait_for_termination)
3088 (interruptible_wait_for_termination, mkdir):
3089 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3090 (emacs_read, emacs_write):
3091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3092 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3093 and double all fit in int.
3094 * term.c (set_tty_color_mode):
3095 Check that fixnums are in proper range for system types.
3096 * termhooks.h (struct input_event):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3098 * textprop.c (validate_interval_range, interval_of)
3099 (Fadd_text_properties, set_text_properties_1)
3100 (Fremove_text_properties, Fremove_list_of_text_properties)
3101 (Ftext_property_any, Ftext_property_not_all)
3102 (copy_text_properties, text_property_list, extend_property_ranges)
3103 (verify_interval_modification):
3104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3105 (Fnext_single_char_property_change)
3106 (Fprevious_single_char_property_change):
3107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3108 (copy_text_properties):
3109 Check for integer overflow in index calculation.
3110 * undo.c (last_boundary_position, record_point, record_insert)
3111 (record_delete, record_marker_adjustment, record_change)
3112 (record_property_change):
3113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3114 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3116 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3117 (Fx_hide_tip, Fx_file_dialog):
3118 * w32menu.c (set_frame_menubar):
3119 Use ptrdiff_t, not int, for consistency with rest of code.
3120 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3121 (select_window, Fdelete_other_windows_internal)
3122 (window_scroll_pixel_based, window_scroll_line_based)
3123 (Frecenter, Fset_window_configuration):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 (Fset_window_hscroll, run_window_configuration_change_hook)
3126 (set_window_buffer, temp_output_buffer_show, scroll_command)
3127 (Fscroll_other_window, Frecenter):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3130 Don't assume fixnum fits in int.
3131 (Fset_window_scroll_bars):
3132 Check that fixnums are in proper range for system types.
3133 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3134 (string_pos, c_string_pos, number_of_chars, init_iterator)
3135 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3136 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3137 (compute_display_string_end, handle_face_prop)
3138 (face_before_or_after_it_pos, handle_invisible_prop)
3139 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3140 (display_prop_intangible_p, string_buffer_position_lim)
3141 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3142 (get_overlay_strings_1, get_overlay_strings)
3143 (iterate_out_of_display_property, forward_to_next_line_start)
3144 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3145 (get_next_display_element, set_iterator_to_next)
3146 (get_visually_first_element, compute_stop_pos_backwards)
3147 (handle_stop_backwards, next_element_from_buffer)
3148 (move_it_in_display_line_to, move_it_in_display_line)
3149 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3150 (add_to_log, message_dolog, message_log_check_duplicate)
3151 (message2, message2_nolog, message3, message3_nolog
3152 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3153 (current_message_1, truncate_echo_area, truncate_message_1)
3154 (set_message, set_message_1, store_mode_line_noprop)
3155 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3156 (text_outside_line_unchanged_p, check_point_in_composition)
3157 (reconsider_clip_changes)
3158 (redisplay_internal, set_cursor_from_row, try_scrolling)
3159 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3160 (redisplay_window, find_last_unchanged_at_beg_row)
3161 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3162 (trailing_whitespace_p, find_row_edges, display_line)
3163 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3164 (display_mode_element, store_mode_line_string)
3165 (pint2str, pint2hrstr, decode_mode_spec)
3166 (display_count_lines, display_string, draw_glyphs)
3167 (x_produce_glyphs, x_insert_glyphs)
3168 (rows_from_pos_range, mouse_face_from_buffer_pos)
3169 (fast_find_string_pos, mouse_face_from_string_pos)
3170 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3172 (safe_call, init_from_display_pos, handle_fontified_prop)
3173 (handle_single_display_spec, load_overlay_strings)
3174 (with_echo_area_buffer, setup_echo_area_for_printing)
3175 (display_echo_area, echo_area_display)
3176 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3177 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3178 (redisplay_window, dump_glyph_row, display_mode_line)
3179 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3180 (handle_display_spec, display_prop_string_p):
3181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3182 (handle_single_display_spec, build_desired_tool_bar_string)
3183 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3184 (get_specified_cursor_type):
3185 Check that fixnums are in proper range for system types.
3186 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3187 (Flookup_image_map):
3188 Don't assume fixnums fit in int.
3189 (compare_overlay_entries):
3190 Avoid mishandling comparisons due to subtraction overflow.
3191 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3192 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3193 (handle_tool_bar_click):
3194 Use int, not unsigned, since we prefer signed and the signedness
3195 doesn't matter here.
3196 (get_next_display_element, next_element_from_display_vector):
3197 Use int, not EMACS_INT, when int is wide enough.
3198 (start_hourglass): Use duration_to_sec_usec to do proper
3199 overflow checking on durations.
3200 * xfaces.c (Fbitmap_spec_p):
3201 Check that fixnums are in proper range for system types.
3202 (compare_fonts_by_sort_order):
3203 Avoid mishandling comparisons due to subtraction overflow.
3204 (Fx_family_fonts, realize_basic_faces):
3205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3207 Don't assume fixnum fits in int.
3208 Use SAFE_ALLOCA_LISP, not alloca.
3209 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3210 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3211 (face_at_buffer_position, face_for_overlay_string)
3212 (face_at_string_position):
3213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3214 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3215 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3217 Check that fixnums are in proper range for system types.
3218 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3219 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3221 (Fx_change_window_property): Don't assume fixnums fit in int.
3222 * xfont.c (xfont_chars_supported):
3223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3224 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3225 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3227 * xml.c (parse_region):
3228 * xrdb.c (magic_file_p):
3229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3230 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3231 (x_get_local_selection, x_reply_selection_request)
3232 (x_handle_selection_request, wait_for_property_change):
3233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3234 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3235 short is wide enough.
3236 (x_send_client_event): Don't assume fixnum fits in int.
3237 * xterm.c (x_x_to_emacs_modifiers):
3238 Don't assume EMACS_INT overflows nicely into int.
3239 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3241 (handle_one_xevent): NATNUMP can eval its arg twice.
3242 (x_connection_closed):
3243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3244 * xterm.h: Adjust decls to match defn changes elsewhere.
3245 (struct scroll_bar): Use struct vectorlike_header
3246 rather than rolling our own approximation.
3247 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3249 2012-05-25 Glenn Morris <rgm@gnu.org>
3251 * lisp.mk (lisp): Update for more files being compiled now.
3253 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3255 * lread.c: Remove `read_pure' which makes no difference.
3256 (read_pure): Remove var.
3257 (unreadpure): Remove function.
3258 (readevalloop): Don't call read_list with -1 flag.
3259 (read1, read_vector): Don't test read_pure any more.
3260 (read_list): Simplify.
3262 * fileio.c, character.h: Minor style tweaks.
3264 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3266 * window.h (clip_changed): Remove useless declaration.
3268 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3270 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3271 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3273 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3276 This directory predates autoconf and is no longer needed nowadays.
3277 Move its few remaining bits of functionality to where they're needed.
3278 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3279 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3280 * m/template.h: Remove.
3281 * Makefile.in (M_FILE): Remove. All uses removed.
3282 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3283 * lisp.h (USE_LSB_TAG):
3284 * mem-limits.h (EXCEEDS_LISP_PTR):
3285 Use VAL_MAX, not VALBITS, in #if.
3286 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3287 (EMACS_UINT): Define unconditionally now.
3288 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3289 (BITS_PER_EMACS_INT): New constants, replacing
3290 what used to be in config.h, but not useful in #if.
3291 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3292 define them any more.
3293 (VAL_MAX): New macro.
3295 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3296 BITS_PER_EMACS_INT, in #if.
3297 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3298 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3299 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3300 * s/ms-w32.h (DATA_START):
3301 Move here from removed file m/intel386.h.
3302 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3303 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3305 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3307 Assume C89 or later.
3308 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3309 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3311 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3312 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3313 * textprop.c, tparam.c (NULL): Remove.
3314 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3315 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3316 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3317 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3318 * xterm.c (input_signal_count): Assume volatile works.
3320 2012-05-21 Ken Brown <kbrown@cornell.edu>
3322 * xgselect.c (xg_select): Fix first argument in call to 'select'
3325 2012-05-20 Ken Brown <kbrown@cornell.edu>
3327 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3328 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3330 2012-05-19 Ken Brown <kbrown@cornell.edu>
3332 * xfns.c (x_in_use): Remove `static' qualifier.
3333 * xterm.h (x_in_use): Declare.
3334 * xgselect.c: Include xterm.h.
3335 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3336 and `display_arg' (bug#9754).
3338 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3340 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3342 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3343 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3345 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3347 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3349 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3350 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3352 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3353 reference to image_cache->refcount.
3354 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3356 2012-05-17 Juri Linkov <juri@jurta.org>
3358 * search.c (Fword_search_regexp, Fword_search_backward)
3359 (Fword_search_forward, Fword_search_backward_lax)
3360 (Fword_search_forward_lax): Move functions to isearch.el
3361 (bug#10145, bug#11381).
3363 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3365 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3367 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3369 * lread.c (init_obarray): Declare Qt and Qnil as special.
3371 2012-05-14 Glenn Morris <rgm@gnu.org>
3373 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3374 Put "libexec" before "bin", for the sake of init_callproc_1.
3376 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3378 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3380 * unexaix.c: Port to more-recent AIX compilers.
3381 (report_error, report_error_1, make_hdr, copy_sym)
3382 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3383 Make arguments const char *, not char *, to avoid violations of C
3384 standard and to fix some AIX warnings reported by Gilles Pion.
3386 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3388 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3389 already have overlays loaded.
3390 (handle_single_display_spec): Before returning without displaying
3391 fringe bitmap, synchronize the bidi iterator with the main display
3392 iterator, by calling iterate_out_of_display_property.
3393 (iterate_out_of_display_property): Detect buffer iteration by
3394 testing that it->string is a Lisp string.
3395 (get_next_display_element): When the current object is exhausted,
3396 and there's something on it->stack, call set_iterator_to_next to
3397 proceed with what's on the stack, instead of returning zero.
3398 (set_iterator_to_next): If called at the end of a Lisp string,
3399 proceed to consider_string_end without incrementing string
3400 position. Don't increment display vector index past the end of
3401 the display vector. (Bug#11417)
3402 (pos_visible_p): Don't report a position visible when move_it_to
3403 stopped at the last line of window, which happens to be scanned
3404 backwards by the bidi iteration. (Bug#11464)
3406 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3408 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3409 and right-margin display specs even if the spec is invalid or we
3410 are on a TTY, and thus unable to display on the fringes.
3411 That's because the text with the property will not be displayed anyway,
3412 so we need to signal to the caller that this is a "replacing"
3413 display spec. This fixes display when the spec is invalid or we
3416 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3418 * unexaix.c (make_hdr): Fix typo in prototype.
3419 This bug broke the build on AIX. Problem reported by Gilles Pion.
3421 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3423 * keyboard.c (kbd_buffer_get_event): Read special events also in
3424 batch mode. (Bug#11415)
3426 2012-05-12 Glenn Morris <rgm@gnu.org>
3428 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3430 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3432 * lisp.mk (lisp): Add newcomment.elc.
3434 2012-05-12 Glenn Morris <rgm@gnu.org>
3436 * Makefile.in (MKDIR_P): New, set by configure.
3437 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3439 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3441 Remove unused function hourglass_started.
3442 * dispextern.h (hourglass_started):
3443 * w32fns.c (hourglass_started):
3444 * xdisp.c (hourglass_started): Remove.
3446 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3448 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3449 Update dependencies.
3451 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3453 * xgselect.c (xg_select): Put maxfds+1 into a var.
3454 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3456 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3458 2012-05-10 Dave Abrahams <dave@boostpro.com>
3460 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3461 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3463 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3465 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3466 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3467 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3468 Initialize xd_registered_buses.
3470 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3472 Untag more efficiently if USE_LSB_TAG.
3473 This is based on a proposal by YAMAMOTO Mitsuharu in
3474 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3475 For an admittedly artificial (nth 8000 longlist) benchmark on
3476 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3477 Emacs's overall text size by 1%.
3478 * lisp.h (XUNTAG): New macro.
3479 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3480 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3481 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3482 * eval.c (Fautoload):
3483 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3484 * frame.h (XFRAME): Use XUNTAG.
3486 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3487 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3488 Remove unportable assumptions about print widths of types like
3490 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3491 intptr_t when converting between pointer and integer, to avoid GCC
3492 warnings about wrong width.
3494 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3496 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3497 stack for each reader_thread, instead of defaulting to 8MB
3498 determined by the linker. This avoids failures in creating
3499 subprocesses on Windows 7, see the discussion in this thread:
3500 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3502 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3504 Fix up display of the *Minibuf-0* buffer in the mini window.
3505 * keyboard.c (read_char): Don't clear the echo area if there's no
3507 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3508 contents of *Minibuf-0*) if there's no message displayed in its stead.
3510 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3512 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3515 2012-05-06 Chong Yidong <cyd@gnu.org>
3517 * lisp.mk (lisp): Update.
3519 2012-05-05 Jim Meyering <meyering@redhat.com>
3521 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3523 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3525 * data.c (PUT_ERROR): New macro.
3526 (syms_of_data): Use it. Add new error type `user-error'.
3527 * undo.c (user_error): New function.
3528 (Fprimitive_undo): Use it.
3529 * print.c (print_error_message): Adjust print style for `user-error'.
3530 * keyboard.c (user_error): New function.
3531 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3533 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3535 Do not limit current-time-string to years 1000..9999.
3536 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3537 (Fcurrent_time_string): Support any year that is supported by the
3538 underlying localtime representation. Don't use asctime, as it
3539 has undefined behavior for years outside the range -999..9999.
3541 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3543 Fix race conditions involving setenv, gmtime, localtime, asctime.
3544 Without this fix, interrupts could mess up code that uses these
3545 nonreentrant functions, since setting TZ invalidates existing
3546 tm_zone or tzname values, and since most of these functions return
3547 pointers to static storage.
3548 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3549 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3550 Grow the critical sections to include not just invoking
3551 localtime/gmtime, but also accessing these functions' results
3552 including their tm_zone values if any, and any related TZ setting.
3553 (format_time_string): Last arg is now struct tm *, not struct tm **,
3554 so that the struct tm is saved in the critical section.
3555 All callers changed. Simplify allocation of initial buffer, partly
3556 motivated by the fact that memory allocation needs to be outside
3557 the critical section.
3559 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3561 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3562 with RESET_INTERVAL.
3564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3565 Remove duplicated buffer name initialization.
3567 2012-05-02 Jim Meyering <jim@meyering.net>
3569 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3571 * xfns.c (x_window): Use xstrdup (Bug#11375).
3573 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3575 * xdisp.c (pos_visible_p): If already at a newline from the
3576 display string before the 'while' loop, don't walk back the glyphs
3577 from it3.glyph_row. Solves assertion violation when the display
3578 string begins with a newline (egg.el). (Bug#11367)
3580 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3582 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3585 2012-05-01 Glenn Morris <rgm@gnu.org>
3587 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3588 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3589 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3590 All were removed before 23.1.
3592 * dispnew.c: Remove HAVE_LIBNCURSES test;
3593 it is always true on relevant platforms.
3595 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3596 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3598 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3600 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3602 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3603 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3606 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3608 Do not avoid creating empty evaporating overlays (Bug#9642).
3609 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3610 That is, do not delete an evaporating overlay if it becomes
3611 empty after its bounds are adjusted to fit within its buffer.
3612 This fix caused other problems, and I'm reverting it until we get
3613 to the bottom of them.
3615 2012-04-27 Chong Yidong <cyd@gnu.org>
3617 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3619 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3621 * xdisp.c (pos_visible_p): If the window start position is beyond
3622 ZV, start the display from buffer beginning. Prevents assertion
3623 violation in init_iterator when the minibuffer window is scrolled
3626 * window.c (window_scroll_pixel_based): Likewise.
3628 2012-04-27 Chong Yidong <cyd@gnu.org>
3630 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3632 2012-04-27 Glenn Morris <rgm@gnu.org>
3634 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3635 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3637 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3639 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3640 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3642 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3644 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3645 display element, check also the underlying string or buffer
3646 character. (Bug#11341)
3648 * w32menu.c: Include w32heap.h.
3649 (add_menu_item): If the call to AppendMenuW (via
3650 unicode_append_menu) fails, disable Unicode menus only if we are
3651 running on Windows 9X/Me.
3653 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3655 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3656 (xgetint): Add missing shift for LSB tags.
3658 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3660 * keyboard.c (read_char): Don't wipe echo area for select window
3661 events: These might get delayed via `mouse-autoselect-window'
3664 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3666 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3667 manipulation of :loaded-from data.
3669 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3671 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3672 now a cons (bug#11311).
3674 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3676 Do not create empty overlays with the evaporate property (Bug#9642).
3677 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3678 if it becomes empty after its bounds are adjusted to fit within
3679 its buffer. Without this fix, in a nonempty buffer (let ((o
3680 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3681 yields an empty overlay that has the evaporate property, which is
3682 not supposed to happen.
3684 Fix minor GTK3 problems found by static checking.
3685 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3686 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3687 (struct _EmacsFixedClass, emacs_fixed_get_type):
3688 Move decls here from emacsgtkfixed.h, since they needn't be public.
3689 (emacs_fixed_get_type): Now static.
3690 (emacs_fixed_class_init): Omit unused local.
3691 (emacs_fixed_child_type): Remove; unused.
3692 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3693 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3694 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3695 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3696 (EMACS_FIXED_GET_CLASS): Remove; unused.
3697 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3699 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3700 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3702 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3704 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3705 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3706 (__malloc_size_t, __malloc_ptrdiff_t):
3707 Remove. All uses removed, replaced by the definiens if needed,
3708 since we can assume C89 or better now.
3709 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3710 (protect_malloc_state, align, get_contiguous_space)
3711 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3712 (malloc_atfork_handler_child, malloc_enable_thread)
3713 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3714 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3715 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3716 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3717 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3718 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3719 Define using prototypes, not old style.
3720 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3721 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3722 (align): Don't assume that signed integer overflow wraps around.
3723 Omit unused local var.
3724 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3725 (_free_internal_nolock, memalign, mallochook, reallochook):
3726 Omit no-longer-needed casts.
3727 (valloc): Use getpagesize, not __getpagesize.
3728 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3729 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3731 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3733 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3735 Move functions from C to Lisp. Make non-blocking method calls
3736 the default. Implement further D-Bus standard interfaces.
3738 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3739 (QCdbus_request_name_allow_replacement)
3740 (QCdbus_request_name_replace_existing)
3741 (QCdbus_request_name_do_not_queue)
3742 (QCdbus_request_name_reply_primary_owner)
3743 (QCdbus_request_name_reply_in_queue)
3744 (QCdbus_request_name_reply_exists)
3745 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3746 (QCdbus_registered_serial, QCdbus_registered_method)
3747 (QCdbus_registered_signal): New Lisp objects.
3748 (XD_DEBUG_MESSAGE): Use sizeof.
3749 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3750 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3751 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3752 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3753 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3754 (xd_signature, xd_append_arg): Allow float for integer types.
3755 (xd_get_connection_references): New function.
3756 (xd_get_connection_address): Rename from xd_initialize.
3757 Return cached address.
3758 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3759 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3761 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3762 Return number of refcounts.
3763 (Fdbus_get_unique_name): Make stronger parameter check.
3764 (Fdbus_message_internal): New defun.
3765 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3766 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3767 (Fdbus_send_signal, Fdbus_register_service)
3768 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3769 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3770 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3771 (Vdbus_compiled_version, Vdbus_runtime_version)
3772 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3773 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3774 (Vdbus_message_type_signal): New defvars.
3775 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3778 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3780 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3781 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3782 Do not assume ptrdiff_t is the same width as 'int'.
3784 * alloc.c: Handle unusual debugging option combinations.
3785 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3786 since the two debugging options are incompatible.
3787 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3789 (mem_init, mem_insert, mem_insert_fixup):
3790 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3791 (NEED_MEM_INSERT): Remove; no longer needed.
3793 2012-04-22 Leo Liu <sdl.web@gmail.com>
3795 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3797 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3799 * sysdep.c [__FreeBSD__]: Minor cleanups.
3800 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3801 Use Emacs indenting style more consistently. Avoid some casts.
3802 Use 'double' consistently rather than mixing 'float' and 'double'.
3804 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3806 * sysdep.c (list_system_processes, system_process_attributes):
3807 Add implementation for FreeBSD (Bug#5243).
3809 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3811 * lisp.mk (lisp): Update.
3813 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3815 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3816 It is never used otherwise.
3818 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3820 * print.c (print_preprocess): Only check print_depth if print-circle
3822 (print_object): Check for cycles even when print-circle is nil and
3823 print-gensym is t, but only check print_depth if print-circle is nil.
3825 2012-04-20 Chong Yidong <cyd@gnu.org>
3827 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3828 set the status to "failed" and ensure that sentinel is run.
3830 2012-04-20 Glenn Morris <rgm@gnu.org>
3832 * process.c (Fset_process_inherit_coding_system_flag)
3833 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3834 (Fmake_network_process, Fmake_serial_process): Doc fix.
3836 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3838 * xdisp.c (string_buffer_position_lim): Limit starting position to
3840 (set_cursor_from_row): If called for a mode-line or header-line
3841 row, return zero immediately.
3842 (try_cursor_movement): If inside continuation line, don't back up
3843 farther than the first row after the header line, if any.
3844 Don't consider the header-line row as "partially visible", even if
3845 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3847 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3849 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3852 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3853 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3855 configure: new option --enable-gcc-warnings (Bug#11207)
3856 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3857 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3858 (ALL_CFLAGS): Use new macros rather than old.
3859 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3860 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3861 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3862 -Wunused-result, -Wunused-variable. This should go away once
3863 the Emacs and Gnulib regex code is merged.
3864 (xmalloc, xrealloc): Now static.
3866 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3868 * dired.c (Fsystem_groups): Remove unused local.
3870 2012-04-17 Glenn Morris <rgm@gnu.org>
3872 * dired.c (Fsystem_users): Doc fix.
3874 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3876 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3877 (syms_of_dired): Add them.
3879 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3881 Fix minor alloc.c problems found by static checking.
3882 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3883 New extern decls, to avoid calling undeclared functions.
3884 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3885 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3886 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3887 (NEED_MEM_INSERT): New macro.
3888 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3889 Remove one incorrect comment and fix another.
3891 Fix minor ralloc.c problems found by static checking.
3892 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3893 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3894 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3895 (r_alloc_sbrk): Now static.
3897 Improve ralloc.c interface checking.
3898 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3899 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3900 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3901 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3902 [REL_ALLOC]: ... to here, to check interface.
3903 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3904 Remove decls. This fixes an "It stinks!".
3906 * alloc.c (which_symbols): Fix alignment issue / type clash.
3908 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3910 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3911 (struct Lisp_Misc_Any): Likewise.
3912 (struct Lisp_Free): Likewise.
3913 * alloc.c (union aligned_Lisp_Symbol): Define.
3914 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3915 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3916 (union aligned_Lisp_Misc): Define.
3917 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3918 aligned_Lisp_Misc instead of union Lisp_Misc.
3919 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3921 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3923 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3924 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3925 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3926 * s/netbsd.h, s/sol2-6.h:
3927 Remove definition of GC_MARK_STACK, since the default now works.
3928 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3929 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3930 no longer the default.
3931 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3933 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3935 * lread.c (lisp_file_lexically_bound_p):
3936 Fix hang at ";-*-\n" (bug#11238).
3938 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3940 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3941 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3943 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3945 * nsterm.m (constrainFrameRect): Always constrain when there is only
3946 one screen (Bug#10962).
3948 2012-04-13 Ken Brown <kbrown@cornell.edu>
3950 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3952 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3954 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3956 2012-04-11 Daniel Colascione <dancol@dancol.org>
3958 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3959 against is gone. It's better to use vfork now so that when Cygwin
3960 gains a new, working vfork, we use it automatically (bug#10398).
3962 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3964 * window.c (save_window_save): Obey window-point-insertion-type.
3966 2012-04-11 Glenn Morris <rgm@gnu.org>
3968 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3970 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3972 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3974 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3976 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3977 (force_quit_count): New var.
3978 (handle_interrupt): Use it.
3980 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3982 * w32.c (w32_delayed_load): Record the full path of the library
3983 being loaded (bug#10424).
3985 2012-04-09 Glenn Morris <rgm@gnu.org>
3987 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3988 not just in the obarray, before snarfing them. (Bug#11036)
3990 * Makefile.in ($(leimdir)/leim-list.el):
3991 Pass EMACS rather than BUILT_EMACS.
3993 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3995 * process.c (make_process):
3996 * process.h: Add integer `gnutls_handshakes_tried' member to
3999 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4000 Add convenience `GNUTLS_LOG2i' macro.
4002 * gnutls.c (gnutls_log_function2i): Convenience log function.
4003 (emacs_gnutls_read): Use new log functions,
4004 `gnutls_handshakes_tried' process member, and
4005 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4006 attempts per process (connection).
4008 2012-04-09 Chong Yidong <cyd@gnu.org>
4010 * eval.c (Fuser_variable_p, user_variable_p_eh)
4011 (lisp_indirect_variable): Functions deleted.
4012 (Fdefvar): Caller changed.
4014 * callint.c (Finteractive, Fcall_interactively):
4015 * minibuf.c (Fread_variable): Callers changed.
4017 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4019 * xdisp.c (set_cursor_from_row): If the display string appears in
4020 the buffer at position that is closer to point than the position
4021 after the display string, display the cursor on the first glyph of
4022 the display string. Fixes cursor display when a 'display' text
4023 property immediately follows invisible text. (Bug#11094)
4025 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4027 composite.c: use 'double' consistently
4028 * composite.c (get_composition_id): Use 'double' consistently
4029 instead of converting 'float' to 'double' and vice versa; this is
4030 easier to understand and avoids a GCC warning.
4032 2012-04-09 Glenn Morris <rgm@gnu.org>
4034 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4035 preparation for dumping it with emacs. (Bug#4789)
4036 (leimdir): New variable.
4037 ($(leimdir)/leim-list.el): New rule.
4038 (emacs$(EXEEXT)): Depend on leim-list.el.
4040 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4041 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4042 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4044 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4046 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4049 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4051 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4052 Remove unused local variable.
4054 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4056 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4057 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4058 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4059 objects, as mark_maybe_pointer will catch them otherwise.
4060 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4061 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4063 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4065 Fix typo that broke non-Windows builds.
4066 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4068 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4070 Support building on MS-Windows with libxml2.
4072 * makefile.w32-in (OBJ2): Add xml.$(O).
4073 (GLOBAL_SOURCES): Add xml.c.
4074 ($(BLD)/xml.$(O)): New dependency list.
4076 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4077 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4078 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4079 [!WINDOWSNT]: New macros.
4080 (init_libxml2_functions, libxml2_loaded_p): New functions.
4081 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4082 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4083 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4084 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4086 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4087 Call init_libxml2_functions before calling libxml2 functions.
4088 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4090 * emacs.c: Don't include libxml/parser.h.
4091 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4092 xmlCleanupParser directly.
4094 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4096 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4098 * indent.c (Fvertical_motion): If there is a display string at
4099 point, use it.vpos to compute how many lines to backtrack after
4100 move_it_to point. (Bug#11133)
4102 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4104 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4105 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4106 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4107 macros related to unification of CJK characters. For the details,
4108 see the discussion following the message here:
4109 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4111 2012-04-04 Chong Yidong <cyd@gnu.org>
4113 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4115 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4117 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4118 instead of alloca. (Bug#11138)
4120 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4122 * w32menu.c (is_simple_dialog): Properly check lisp types.
4125 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4127 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4128 position we get to after a call to move_it_to fails the
4129 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4130 only if we wind up in a string from display property. (Bug#11063)
4132 * window.c (Fdelete_other_windows_internal): Invalidate the row
4133 and column information about mouse highlight, so that redisplay
4134 restores it after reallocating the glyph matrices. (Bug#7464)
4136 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4137 string comes from a `display' text property, use the buffer
4138 position of that property as if we actually saw that position in
4140 (move_it_by_lines): Remove the assertion that
4141 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4142 violated when there's a before-string at the beginning of a line.
4145 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4147 * xdisp.c (append_space_for_newline): If the default face was
4148 remapped, use the remapped face for the appended newline.
4149 (extend_face_to_end_of_line): Use the remapped default face for
4150 extending the face to the end of the line.
4151 (display_line): Call extend_face_to_end_of_line when the default
4152 face was remapped. (Bug#11068)
4154 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4156 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4158 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4160 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4162 2012-03-27 Glenn Morris <rgm@gnu.org>
4164 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4167 2012-03-26 Kenichi Handa <handa@m17n.org>
4169 * dispextern.h (struct glyph): Fix previous change. Change the
4170 bit length of glyphless.ch to 25 (Bug#11082).
4172 2012-03-26 Chong Yidong <cyd@gnu.org>
4174 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4175 (command_loop_1): Use it; inhibit selection update for
4176 handle-select-window too (Bug#8996).
4178 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4180 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4182 2012-03-25 Kenichi Handa <handa@m17n.org>
4184 * dispextern.h (struct glyph): Change the bit length of
4185 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4187 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4189 * s/ms-w32.h (tzname): Include time.h before redirecting to
4190 _tzname. Fixes the MSVC build. (Bug#9960)
4192 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4194 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4197 * xterm.c (XTread_socket): Only modify handling_signal if
4198 !SYNC_INPUT. (Bug#11080)
4200 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4202 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4203 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4204 when fetching a multibyte character consumes more bytes than
4205 CHAR_BYTES returns, due to unification of CJK characters in
4206 string_char. (Bug#11073)
4208 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4210 * process.c (wait_reading_process_output): Handle pty disconnect
4211 by refraining from sending oneself a SIGCHLD (bug#10933).
4213 2012-03-22 Chong Yidong <cyd@gnu.org>
4215 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4217 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4218 Mark string as coming from a prefix property.
4219 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4220 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4222 2012-03-21 Chong Yidong <cyd@gnu.org>
4224 * xfaces.c (Vface_remapping_alist): Doc fix.
4226 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4228 * w32proc.c (Fw32_set_console_codepage)
4229 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4232 2012-03-20 Chong Yidong <cyd@gnu.org>
4234 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4235 to reflect default non-nil value of redisplay-dont-pause.
4237 2012-03-19 Kenichi Handa <handa@m17n.org>
4239 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4240 it fit in a valid range (Bug#11003).
4242 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4244 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4245 that is not from display property, accept the row as a "cursor
4246 row" if one of the string's character has a non-nil `cursor'
4247 property. Fixes cursor positioning when there are newlines in
4248 overlay strings, e.g. in icomplete.el. (Bug#11035)
4250 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4252 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4254 2012-03-12 Chong Yidong <cyd@gnu.org>
4256 * eval.c (inhibit_lisp_code): Rename from
4257 inhibit_window_configuration_change_hook; move from window.c.
4259 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4260 * window.c (run_window_configuration_change_hook)
4261 (syms_of_window): Callers changed.
4263 2012-03-11 Chong Yidong <cyd@gnu.org>
4265 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4267 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4269 2012-03-10 Chong Yidong <cyd@gnu.org>
4271 * frame.c (other_visible_frames): Don't assume the selected frame
4272 is visible (Bug#10955).
4274 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4276 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4278 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4280 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4281 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4284 2012-03-03 Glenn Morris <rgm@gnu.org>
4286 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4288 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4290 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4291 position past the first glyph_row that ends at ZV. (Bug#10902)
4292 (redisplay_window, next_element_from_string): Fix typos in
4294 (redisplay_window): Pass to move_it_vertically the margin in
4295 pixels, not in screen lines.
4297 2012-03-02 Glenn Morris <rgm@gnu.org>
4299 * buffer.c (buffer-list-update-hook): Doc fix.
4301 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4303 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4304 push_it before setting up the iterator for the first overlay
4305 string, even if we have an empty string loaded.
4306 (next_overlay_string): If there's an empty string on the iterator
4307 stack, pop the stack. (Bug#10903)
4309 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4311 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4312 Suggested by Stefan Monnier in
4313 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4314 * alloc.c (widen_to_Lisp_Object): New static function.
4315 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4316 and widening them to Lisp_Objects. This would work even if
4317 USE_LSB_TAG is defined and wide integers are used, which might
4318 happen in a future version of Emacs.
4320 2012-02-25 Chong Yidong <cyd@gnu.org>
4322 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4325 * xselect.c (Fx_selection_exists_p): Doc fix.
4326 (x_clipboard_manager_save_all): Print an informative message
4327 before saving to clipboard manager.
4329 2012-02-24 Chong Yidong <cyd@gnu.org>
4331 * keyboard.c (process_special_events): Handle all X selection
4332 requests in kbd_buffer, not just the next one (Bug#8869).
4334 2012-02-23 Chong Yidong <cyd@gnu.org>
4336 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4337 call when setting menu-bar-lines and tool-bar-lines parameters.
4338 (unwind_create_frame_1): New helper function.
4340 * window.c (inhibit_window_configuration_change_hook): New var.
4341 (run_window_configuration_change_hook): Obey it.
4342 (syms_of_window): Initialize it.
4344 2012-02-22 Chong Yidong <cyd@gnu.org>
4346 * xterm.c (x_draw_image_relief): Add missing type check for
4347 Vtool_bar_button_margin (Bug#10743).
4349 2012-02-21 Chong Yidong <cyd@gnu.org>
4351 * fileio.c (Vfile_name_handler_alist): Doc fix.
4353 * buffer.c (Fget_file_buffer): Protect against invalid file
4354 handler return value.
4356 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4358 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4359 when computing $valmask.
4361 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4362 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4363 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4364 It's useless in that case, and it can cause problems on hosts
4365 that allocate halves of EMACS_INT values separately.
4366 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4367 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4368 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4369 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4370 it avoids undefined behavior on hosts where shifting right by more
4371 than the word width has undefined behavior.
4373 2012-02-19 Chong Yidong <cyd@gnu.org>
4375 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4376 (Funhandled_file_name_directory, Ffile_name_as_directory)
4377 (Fdirectory_file_name, Fexpand_file_name)
4378 (Fsubstitute_in_file_name): Protect against invalid file handler
4379 return values (Bug#10845).
4381 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4383 * .gdbinit (pitx): Fix incorrect references to fields of the
4386 2012-02-17 Chong Yidong <cyd@gnu.org>
4388 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4390 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4392 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4393 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4395 2012-02-15 Chong Yidong <cyd@gnu.org>
4397 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4398 marked as special. Also, starting docstrings with * is obsolete.
4400 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4402 * gnutls.c (emacs_gnutls_write): Fix last change.
4404 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4406 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4409 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4411 * keymap.c (Fsingle_key_description): Handle char ranges.
4413 2012-02-12 Chong Yidong <cyd@gnu.org>
4415 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4416 as that creates a dangerous corner case.
4418 * window.c (Fdelete_window_internal): Invalidate the mouse
4419 highlight (Bug#9904).
4421 2012-02-12 Glenn Morris <rgm@gnu.org>
4423 * xselect.c (Fx_own_selection_internal)
4424 (Fx_get_selection_internal, Fx_disown_selection_internal)
4425 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4426 * nsselect.m (Fx_own_selection_internal)
4427 (Fx_disown_selection_internal, Fx_selection_exists_p)
4428 (Fx_selection_owner_p, Fx_get_selection_internal):
4429 Sync docs and argument specs with the xselect.c versions.
4431 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4433 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4435 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4437 * w32select.c (Fx_selection_exists_p): Sync doc string and
4438 argument list with xselect.c. (Bug#10783)
4440 * w16select.c (Fx_selection_exists_p): Sync doc string and
4441 argument list with xselect.c. (Bug#10783)
4443 2012-02-10 Glenn Morris <rgm@gnu.org>
4445 * fns.c (Fsecure_hash): Doc fix.
4447 2012-02-09 Kenichi Handa <handa@m17n.org>
4449 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4451 2012-02-07 Chong Yidong <cyd@gnu.org>
4453 * buffer.c (Fbuffer_local_variables)
4454 (buffer_lisp_local_variables): Handle unbound vars correctly;
4455 don't let Qunbound leak into Lisp.
4457 2012-02-07 Glenn Morris <rgm@gnu.org>
4459 * image.c (Fimagemagick_types): Doc fix.
4461 * image.c (imagemagick-render-type): Change it from a lisp object
4462 to an integer. Move the doc here from the lisp manual.
4463 Treat all values not equal to 0 the same.
4465 2012-02-06 Chong Yidong <cyd@gnu.org>
4467 * doc.c (store_function_docstring): Avoid applying docstring of
4468 alias to base function (Bug#2603).
4470 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4472 * .gdbinit (pp1, pv1): Remove redundant defines.
4475 2012-02-04 Chong Yidong <cyd@gnu.org>
4477 * nsterm.m: Declare a global (Bug#10694).
4479 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4481 * w32.c (get_emacs_configuration_options):
4482 Include --enable-checking, if specified, in the return value.
4484 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4486 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4487 after rounding frame sizes. (Bug#9723)
4489 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4491 * keyboard.c (adjust_point_for_property): Don't position point
4492 before BEGV. (Bug#10696)
4494 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4496 Handle overflow when computing char display width (Bug#9496).
4497 * character.c (char_width): Return EMACS_INT, not int.
4498 (char_width, c_string_width): Check for overflow when
4499 computing the width; this is possible now that individual
4500 characters can have unbounded width. Problem introduced
4501 by merge from Emacs 23 on 2012-01-19.
4503 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4505 * dbusbind.c (Fdbus_register_method): Mention the return value
4506 :ignore in the docstring.
4508 2012-02-02 Glenn Morris <rgm@gnu.org>
4510 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4513 Unconditionally set to t. (Bug#10673)
4514 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4515 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4516 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4518 2012-02-02 Kenichi Handa <handa@m17n.org>
4520 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4521 0, do not call append_composite_glyph.
4523 2012-02-02 Kenichi Handa <handa@m17n.org>
4525 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4527 (x_produce_glyphs): If the component of a composition is a null
4528 string, set it->pixel_width to 1 to avoid zero-width glyph.
4530 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4532 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4533 first 2 arguments are identical. This makes inserting large
4534 output from a subprocess an order of magnitude faster on
4535 MS-Windows, where all sbrk'ed memory is always contiguous.
4537 2012-01-31 Glenn Morris <rgm@gnu.org>
4539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4540 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4541 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4543 2012-01-29 Glenn Morris <rgm@gnu.org>
4545 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4547 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4549 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4551 2012-01-28 Chong Yidong <cyd@gnu.org>
4553 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4555 2012-01-26 Chong Yidong <cyd@gnu.org>
4557 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4559 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4560 repeat counts (Bug#10507).
4562 2012-01-26 Glenn Morris <rgm@gnu.org>
4564 * lread.c (syms_of_lread): Doc fix.
4566 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4568 * coding.c (encode_designation_at_bol): Change return value to
4571 2012-01-25 Chong Yidong <cyd@gnu.org>
4573 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4575 2012-01-21 Chong Yidong <cyd@gnu.org>
4577 * floatfns.c (Fcopysign): Make the second argument non-optional,
4578 since nil is not allowed anyway.
4580 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4582 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4583 (send_process): Likewise.
4585 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4587 * window.c (save_window_save, Fcurrent_window_configuration)
4588 (Vwindow_persistent_parameters): Do not use Qstate.
4589 Rewrite doc-strings.
4591 2012-01-19 Kenichi Handa <handa@m17n.org>
4593 * character.c (char_width): New function.
4594 (Fchar_width, c_string_width, lisp_string_width):
4595 Use char_width (Bug#9496).
4597 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4599 * window.c (Vwindow_persistent_parameters): New variable.
4600 (Fset_window_configuration, save_window_save): Handle persistent
4603 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4605 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4606 thrashing the stack of the thread. (Bug#9087)
4608 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4610 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4612 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4614 * xdisp.c (rows_from_pos_range): Handle the case where the
4615 highlight ends on a newline. (Bug#10464)
4616 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4617 he end column for display of highlight that ends on a newline
4620 2012-01-11 Glenn Morris <rgm@gnu.org>
4622 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4623 from load-path also when installation-directory is nil. (Bug#10208)
4625 2012-01-10 Glenn Morris <rgm@gnu.org>
4627 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4629 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4630 Update template values to be closer to their typical values these days.
4632 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4634 * xdisp.c (rows_from_pos_range): Accept additional argument
4635 DISP_STRING, and accept any glyph in a row whose object is that
4636 string as eligible for mouse highlight. Fixes mouse highlight of
4637 display strings from overlays. (Bug#10464)
4639 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4641 emacs: fix an auto-save permissions race condition (Bug#10400)
4642 * fileio.c (auto_saving_dir_umask): New static var.
4643 (Fmake_directory_internal): Use it.
4644 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4645 creating the directory. The old code temporarily assigns
4646 too-generous permissions to the directory.
4647 (do_auto_save_eh): Clear it.
4648 (Fdo_auto_save): Catch all errors, not just file errors, so
4649 that the var is always cleared.
4651 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4653 * search.c (scan_buffer): Pass character positions to
4654 know_region_cache, not byte positions. (Bug#6540)
4656 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4658 * w32.c (sys_rename): Report EXDEV when rename of a directory
4659 fails because the target is on another logical disk. (Bug#10284)
4661 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4663 * xterm.c (x_embed_request_focus): New function.
4665 * xterm.h: Add prototype.
4667 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4669 2012-01-05 Glenn Morris <rgm@gnu.org>
4671 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4673 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4675 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4676 Load gnutls_transport_set_lowat only if GnuTLS version is below
4678 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4679 GnuTLS versions below 2.11.1.
4681 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4683 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4684 to the doc string advising against its use for altering the way
4685 windows are scrolled.
4687 2011-12-28 Kenichi Handa <handa@m17n.org>
4689 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4690 coding-system ASCII compatible only when it does not produce BOM
4691 on encoding (Bug#10383).
4693 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4695 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4697 (create_and_show_popup_menu): Always use menu_position_func for
4700 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4702 * callint.c (Fcall_interactively): Don't truncate prompt string.
4704 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4706 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4707 property that ends at ZV, so that the bidi iteration could be
4708 resumed from there (after widening). (Bug#10360)
4710 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4712 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4714 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4716 * nsterm.m (x_free_frame_resources):
4717 Release f->output_data.ns->miniimage.
4718 (ns_index_color): Fix indentation. Do not retain
4719 color_table->colors[i].
4721 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4724 * nsfns.m (x_set_background_color): Assign return value from
4725 ns_index_color to face-background instead of NSColor*.
4726 (ns_implicitly_set_icon_type): Fix indentation.
4727 Change assignment in for loop to comparison.
4729 * emacs.c (ns_pool): New variable.
4730 (main): Assign ns_pool.
4731 (Fkill_emacs): Call ns_release_autorelease_pool.
4733 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4734 autorelease fdesc, release fdAttrs and tdict.
4735 (ns_get_covering_families): Release charset.
4736 (ns_findfonts): Release NSFontDescriptor created with new.
4737 (ns_uni_to_glyphs): Fix indentation.
4738 (setString): Release attrStr before assigning new value.
4740 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4742 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4744 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4745 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4747 2011-12-18 David Reitter <reitter@cmu.edu>
4749 * nsterm.m (ns_term_init): Subscribe for notifications
4750 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4751 to method trackingNotification in EmacsMenu.
4753 * nsmenu.m (trackingMenu): New variable.
4754 (trackingNotification): New method (from Aquamacs).
4755 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4756 from Aquamacs (Bug#7030).
4758 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4760 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4761 (symbol_to_nsstring): Fix indentation.
4762 (ns_symbol_to_pb): New function.
4763 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4764 (Fns_rotate_cut_buffers_internal): Remove.
4765 (Fns_store_selection_internal): Rename from
4766 Fns_store_cut_buffer_internal.
4767 (ns_get_foreign_selection, Fx_own_selection_internal)
4768 (Fx_disown_selection_internal, Fx_selection_exists_p)
4769 (Fns_get_selection_internal, Fns_store_selection_internal):
4770 Use ns_symbol_to_pb and check if return value is nil.
4771 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4772 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4773 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4774 renamed to Sns_store_selection_internal.
4775 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4776 and remove this function.
4777 (ns_handle_selection_clear): Remove, never used.
4778 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4781 2011-12-17 Ken Brown <kbrown@cornell.edu>
4783 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4784 GID is unknown (Bug#10257).
4786 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4788 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4789 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4790 which caused a build failure on GNU/Linux IA-64. This problem was
4791 introduced by my 2011-10-07 patch.
4793 2011-12-15 Juri Linkov <juri@jurta.org>
4795 * image.c (imagemagick_error): New function. (Bug#10112)
4796 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4797 Use `imagemagick_error' where ImageMagick functions return
4799 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4802 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4804 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4805 fill background (Bug#8992).
4807 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4809 * window.c (Vwindow_combination_resize)
4810 (Vwindow_combination_limit): Use t instead of non-nil in
4812 (Vrecenter_redisplay): Add first sentence of doc-string on
4814 (Frecenter): Fix doc-string typo.
4816 2011-12-11 Kenichi Handa <handa@m17n.org>
4818 * coding.c (Funencodable_char_position): Pay attention to the
4819 buffer text relocation (Bug#9389).
4821 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4823 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4824 gtk_init (Bug#10100).
4826 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4828 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4829 IT->string is nil. (Bug#10263)
4831 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4833 * nsterm.h (x_free_frame_resources): Declare.
4835 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4836 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4838 * nsterm.h (ns_get_defaults_value): Declare.
4840 * nsterm.m (ns_default): Call ns_get_defaults_value.
4842 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4844 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4847 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4849 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4850 that where the value of an _OBJC_* symbol points to is in the .bss
4851 section (Bug#10240).
4853 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4855 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4856 after the loop to call ccl_driver at least once (Bug#8619).
4858 2011-12-08 Kenichi Handa <handa@m17n.org>
4860 * ftfont.c (get_adstyle_property): Fix previous change
4863 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4865 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4866 dirs from the default value of EMACSLOADPATH (bug#10208).
4868 2011-12-07 Glenn Morris <rgm@gnu.org>
4870 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4871 installation and source directories as well. (Bug#10208)
4873 2011-12-06 Chong Yidong <cyd@gnu.org>
4875 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4877 2011-12-06 Glenn Morris <rgm@gnu.org>
4879 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4880 as an error, not just -1. (Bug#10217)
4882 2011-12-05 Chong Yidong <cyd@gnu.org>
4884 * keyboard.c (process_special_events): New function.
4885 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4887 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4889 * coding.c (encode_designation_at_bol): Don't use uninitialized
4890 local variable (Bug#9318).
4892 2011-12-05 Kenichi Handa <handa@m17n.org>
4894 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4895 return Qnil (Bug#8046, Bug#10193).
4897 2011-12-05 Kenichi Handa <handa@m17n.org>
4899 * coding.c (encode_designation_at_bol): New args charbuf_end and
4900 dst. Return the number of produced bytes. Callers changed.
4901 (coding_set_source): Return how many bytes coding->source was
4903 (coding_set_destination): Return how many bytes
4904 coding->destination was relocated.
4905 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4906 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4908 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4910 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4911 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4914 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4916 The following changes are to fix Bug#9318.
4918 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4919 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4920 (encode_coding_iso_2022, encode_coding_sjis)
4921 (encode_coding_big5, encode_coding_charset): Use the above macros.
4923 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4925 * lisp.h (process_quit_flag): Fix external declaration.
4927 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4929 Don't macro-inline non-performance-critical code.
4930 * eval.c (process_quit_flag): New function.
4931 * lisp.h (QUIT): Use it.
4933 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4935 * nsfns.m (get_geometry_from_preferences): New function.
4936 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4938 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4940 * emacs.c (Qkill_emacs): Define.
4941 (syms_of_emacs): Initialize it.
4942 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4943 Qquit_flag to `kill-emacs' instead.
4944 (quit_throw_to_read_char): Add parameter `from_signal'.
4945 All callers changed. Call Fkill_emacs if requested and safe.
4946 * lisp.h (QUIT): Call Fkill_emacs if requested.
4948 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4950 * widget.c (update_wm_hints): Return if wmshell is null.
4951 (widget_update_wm_size_hints): New function.
4953 * widget.h (widget_update_wm_size_hints): Declare.
4955 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4956 widget_update_wm_size_hints (Bug#10104).
4958 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4961 before a newline, prepare the bidi iterator for consuming the
4962 newline, and keep the current paragraph direction. (Bug#10183)
4963 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4965 2011-12-02 Juri Linkov <juri@jurta.org>
4967 * search.c (Fword_search_regexp): New Lisp function created from
4968 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4969 (Fword_search_backward, Fword_search_forward)
4970 (Fword_search_backward_lax, Fword_search_forward_lax):
4971 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4972 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4974 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4976 * fileio.c (Finsert_file_contents): Move after-change-function call
4977 to before the "handled:" label, since all "goto handled" appear in
4978 cases where the *-change-functions have already been properly called
4981 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4983 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4984 waiting for input. (Bug#10169)
4986 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4988 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4989 verifies glyph row's hash code--we have just reallocated the
4990 glyphs, so their contents can be complete garbage. (Bug#10164)
4992 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4994 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4996 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4998 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4999 attributes are tested _before_ calling verify_row_hash, to protect
5000 against GCC re-ordering of the tests. (Bug#10164)
5002 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5004 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5006 * xterm.c (handle_one_xevent): Only set async_visible and friends
5007 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5008 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5009 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5011 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5013 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5014 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5015 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5016 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5017 All uses changed to use GCPRO1 etc.
5018 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5019 Revert to old implementation (i.e., before 2011-03-11).
5021 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5023 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5024 of scroll runs so as to avoid assigning disabled bogus rows and
5025 unnecessary graphics copy operations.
5027 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5029 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5030 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5031 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5032 (malloc, free, realloc, calloc): Redirect to e_* only when
5035 * lisp.h (GCTYPEBITS): Move before first use.
5036 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5037 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5038 this macro definition.
5040 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5043 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5045 * gtkutil.c (xg_create_frame_widgets):
5046 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5047 present with Gtk+ 2.0.
5049 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5051 * fileio.c (Finsert_file_contents): Undo previous change; see
5052 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5054 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5056 Rename locals to avoid shadowing.
5057 * fileio.c (Finsert_file_contents):
5058 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5059 * process.c (wait_reading_process_output):
5060 Rename inner 'proc' to 'p' to avoid shadowing.
5061 Indent for consistency with usual Emacs style.
5063 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5065 * xdisp.c (redisplay_window): If cursor row is not fully visible
5066 after recentering, and scroll-conservatively is set to a large
5067 number, scroll window by a few more lines to make the cursor fully
5068 visible and out of scroll-margin. (Bug#10105)
5069 (start_display): Don't move to the next line if the display should
5070 start at a newline that is part of a display vector or an overlay
5073 2011-11-24 Juri Linkov <juri@jurta.org>
5075 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5076 after the `MagickPingImage' call. (Bug#10112)
5078 2011-11-23 Chong Yidong <cyd@gnu.org>
5080 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5082 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5084 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5085 making another buffer current. (Bug#10114)
5087 2011-11-23 Glenn Morris <rgm@gnu.org>
5089 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5091 2011-11-23 Chong Yidong <cyd@gnu.org>
5093 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5094 using it (Bug#5984).
5096 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5098 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5099 and header-lines, as they don't have one computed for them.
5102 * .gdbinit (prow): Make displayed values more self-explaining.
5103 Add row's hash code.
5105 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5107 * process.c (wait_reading_process_output): Fix asynchrounous
5108 GnuTLS socket handling on some versions of the GnuTLS library.
5109 (wait_reading_process_output): Add comment and URL.
5111 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5113 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5115 2011-11-21 Chong Yidong <cyd@gnu.org>
5117 * window.c (Fnext_window, Fprevious_window): Doc fix.
5119 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5121 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5123 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5125 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5127 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5129 * window.c (Fset_window_combination_limit): Rename argument
5131 (Vwindow_combination_limit): Remove "status" from doc-string.
5133 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5135 * m/ibms390.h: Remove.
5136 * m/ibms390x.h: Don't include "ibms390.h".
5138 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5140 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5141 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5143 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5145 * casetab.c (Fset_case_table):
5146 * charset.c (Fcharset_after): Fix typos.
5148 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5150 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5151 Otherwise, valgrind does not work on some platforms.
5152 Problem reported by Andreas Schwab in
5153 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5154 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5155 is set, removing the need for VIRT_ADDRESS_VARIES.
5156 (PURE_P): Use a more-efficient implementation that needs just one
5157 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5158 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5159 to 4 (xorl, subq, cmpq, setbe).
5160 * alloc.c (pure): Always extern now, since that's the
5161 VIRT_ADDR_VARIES behavior.
5162 (PURE_POINTER_P): Use a single comparison, not two, for
5163 consistency with the new puresize.h.
5164 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5165 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5166 Remove VIRT_ADDR_VARIES no longer needed.
5168 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5170 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5171 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5172 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5173 behave as if the cursor position were at the window margin.
5175 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5176 and the cursor position is out of bounds, behave as if the cursor
5177 position were at the window margin. (Bug#10075)
5179 2011-11-18 Chong Yidong <cyd@gnu.org>
5181 * window.c (Fwindow_combination_limit): Make first argument
5182 non-optional, since it is meaningless for live windows like the
5185 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5187 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5189 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5191 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5192 (graft_intervals_into_buffer): Simplify.
5194 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5196 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5197 hash values of the two rows.
5198 (copy_row_except_pointers): Preserve the used[] arrays and the
5199 hash values of the two rows. (Bug#10035)
5200 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5202 * xdisp.c (row_hash): New function, body extracted from
5203 compute_line_metrics.
5204 (compute_line_metrics): Call row_hash, instead of computing the
5207 * dispnew.c (verify_row_hash): Call row_hash for computing the
5208 hash code of a row, instead of duplicating code from xdisp.c.
5210 * dispextern.h (row_hash): Add prototype.
5212 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5214 * frame.c (delete_frame): Don't delete the terminal when the last
5215 X frame is closed if emacs is built with GTK toolkit.
5217 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5219 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5221 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5223 * window.c (Vwindow_splits): Rename to
5224 Vwindow_combination_resize. Suggested by Juri Linkov.
5225 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5228 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5230 * nsfns.m (Fns_font_name):
5231 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5233 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5235 * window.h (window): Rename slot "nest" to "combination_limit".
5236 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5237 (Fset_window_nest): Rename to Fset_window_combination_limit.
5238 (Vwindow_nest): Rename to Vwindow_combination_limit.
5239 (recombine_windows, make_parent_window, make_window)
5240 (Fsplit_window_internal, saved_window)
5241 (Fset_window_configuration, save_window_save): Rename all
5242 occurrences of window_nest to window_combination_limit.
5244 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5246 * image.c (imagemagick_load_image): Fix typo.
5248 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5250 * xdisp.c (display_line): Move the call to
5251 highlight_trailing_whitespace before the call to
5252 compute_line_metrics, since the latter needs to see the final
5253 faces of all the glyphs to compute ROW's hash value.
5254 Fixes assertion violations in row_equal_p. (Bug#10035)
5256 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5258 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5259 just return (bug#10044).
5261 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5263 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5264 with user-defined heap size. Bump the default size of the temacs
5265 heap to 27MB, to avoid memory warning when running temacs.
5266 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5268 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5269 current_matrix and desired_matrix. (Bug#9990)
5270 (verify_row_hash) [XASSERTS]: New function.
5271 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5272 that the hash value of glyph rows is correct.
5274 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5276 * window.h (window): Remove splits slot.
5277 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5278 (Fdelete_other_windows_internal, make_parent_window)
5279 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5280 (Fset_window_configuration, save_window_save): Don't deal with
5281 split status of windows.
5282 (saved_window): Remove splits slot.
5283 (Vwindow_splits): Rewrite doc-string.
5285 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5287 * xfns.c (unwind_create_frame):
5288 * nsfns.m (unwind_create_frame):
5289 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5290 Vframe_list (Bug#9999).
5292 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5294 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5296 2011-11-11 Kenichi Handa <handa@m17n.org>
5298 * callproc.c (Fcall_process): Set the member dst_multibyte of
5301 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5303 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5304 avoid a crash (bug#9496).
5306 2011-11-09 Chong Yidong <cyd@gnu.org>
5308 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5309 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5311 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5313 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5315 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5317 Avoid some portability problems by eschewing 'extern inline' functions.
5318 The trivial performance wins aren't worth the portability hassles; see
5319 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5321 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5322 (window_box_width, window_box_left, window_box_left_offset)
5323 (window_box_right, window_box_right_offset): Undo previous change,
5324 by removing the "extern"s.
5325 * intervals.c (adjust_intervals_for_insertion)
5326 (adjust_intervals_for_deletion): Undo previous change,
5327 making these static again.
5328 (offset_intervals, temp_set_point_both, temp_set_point)
5329 (copy_intervals_to_string): No longer inline.
5330 * xdisp.c (window_text_bottom_y, window_box_width)
5331 (window_box_height, window_box_left_offset)
5332 (window_box_right_offset, window_box_left, window_box_right)
5333 (window_box): No longer inline.
5335 2011-11-08 Chong Yidong <cyd@gnu.org>
5337 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5338 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5339 Signal an error if not a live window.
5340 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5341 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5343 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5345 * lisp.h (syms_of_abbrev): Remove declaration.
5346 Reported by CHENG Gao <chenggao@royau.me>.
5348 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5350 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5351 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5352 of temacs in GUI mode.
5354 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5356 * window.h: Declare delete_all_child_windows instead of
5357 delete_all_subwindows.
5358 * window.c (Fwindow_nest, Fset_window_nest)
5359 (Fset_window_new_total, Fset_window_new_normal)
5360 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5361 (delete_all_subwindows): Rename to delete_all_child_windows.
5362 (Fdelete_other_windows_internal, Fset_window_configuration):
5363 Call delete_all_child_windows instead of delete_all_subwindows.
5364 * frame.c (delete_frame): Call delete_all_child_windows instead
5365 of delete_all_subwindows.
5367 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5369 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5370 This is also needed for porting to any host where GC_MARK_STACK is
5371 not GC_MAKE_GCPROS_NOOPS.
5372 (which_symbols): Use it.
5374 2011-11-07 Kenichi Handa <handa@m17n.org>
5376 * coding.c (coding_set_destination): Check coding->src_pos only
5377 when coding->src_object is a buffer (bug#9910).
5379 * process.c (send_process): Set the member src_multibyte of coding
5380 to 0 (bug#9911) when sending a unibyte text.
5382 * callproc.c (Fcall_process): Set the member src_multibyte of
5383 process_coding to 0 (bug#9912).
5385 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5387 * xmenu.c (cleanup_widget_value_tree): New function.
5388 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5389 calling free_menubar_widget_value_tree directly (Bug#9830).
5391 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5393 Fix some portability problems with 'inline'.
5394 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5395 (window_box_width, window_box_left, window_box_left_offset)
5396 (window_box_right, window_box_right_offset): Declare extern.
5397 Otherwise, these inline functions do not conform to C99 and
5398 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5399 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5400 * intervals.c (adjust_intervals_for_insertion)
5401 (adjust_intervals_for_deletion): Now extern, because otherwise the
5402 extern inline functions 'offset_intervals' couldn't refer to it.
5403 (static_offset_intervals): Remove.
5404 (offset_intervals): Rewrite using the old contents of
5405 static_offset_intervals. The old version didn't conform to C99
5406 because an extern inline function contained a reference to an
5407 identifier with static linkage.
5409 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5411 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5414 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5416 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5417 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5418 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5419 return Qleft_to_right.
5421 2011-11-06 Chong Yidong <cyd@gnu.org>
5423 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5424 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5425 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5426 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5427 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5428 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5429 (Fwindow_vscroll): Doc fix.
5430 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5431 argument, since it makes no sense to pass a live window and for
5432 consistency with window-child.
5434 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5436 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5439 2011-11-05 Jason Rumney <jasonr@gnu.org>
5441 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5442 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5444 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5445 bitwise arithmetic preventing use of unicode-sip and non-truetype
5448 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5450 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5453 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5454 initialization code to keep similarity to xfns.c after changes
5457 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5459 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5460 (unwind_create_frame): New function (Bug#9943).
5461 (Fx_create_frame): Restructure code to be more similar to the one in
5462 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5463 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5464 Move terminal->reference_count++ just before making the frame official
5467 * nsterm.m (x_free_frame_resources): New function.
5468 (x_destroy_window): Move code to x_free_frame_resources.
5470 * xfns.c (unwind_create_frame): Fix comment.
5471 (Fx_create_frame, x_create_tip_frame):
5472 Move terminal->reference_count++ just before making the frame
5473 official. Move initialization of image_cache_refcount and
5474 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5476 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5478 Support MSVC build with newer versions of Visual Studio.
5479 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5480 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5483 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5484 which are not supported by MSVC.
5485 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5486 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5488 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5490 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5492 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5494 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5496 Support MSVC build with newer versions of Visual Studio.
5497 * w32.c: Don't include w32api.h for MSVC.
5498 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5500 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5501 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5502 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5503 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5505 (alloca) [_MSC_VER]: Define to _alloca.
5507 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5509 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5511 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5513 * xdisp.c (note_mouse_highlight): If either of
5514 previous/next-single-property-change returns nil, treat that as
5515 the beginning or the end of the buffer. (Bug#9955)
5517 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5519 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5520 label is not null (Bug#9951).
5521 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5524 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5526 * window.c (Fwindow_body_size): Mention in the doc string that the
5527 return value is in frame's canonical units. (Bug#9949)
5529 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5531 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5533 * w32fns.c (unwind_create_frame): If needed, free the glyph
5534 matrices of the partially constructed frame. (Bug#9943)
5535 * xfns.c (unwind_create_frame): Likewise.
5537 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5539 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5540 Don't stop backward scan on the continuation glyph, even though
5541 its CHARPOS is positive.
5542 (mouse_face_from_buffer_pos, note_mouse_highlight):
5543 Rename cover_string to disp_string.
5545 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5547 * window.c (temp_output_buffer_show): Don't use
5548 Vtemp_buffer_show_specifiers.
5549 (Vtemp_buffer_show_specifiers): Remove unused variable.
5551 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5553 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5554 past the beginning of the current glyph matrix.
5556 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5558 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5559 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5560 HAVE_GTK3 (Bug#9869).
5562 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5563 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5565 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5567 * xterm.c: Declare x_handle_net_wm_state to return int.
5568 (handle_one_xevent): Check if we are iconified but don't have
5569 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5570 (get_current_wm_state): Return non-zero if not hidden,
5571 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5572 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5573 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5574 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5576 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5578 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5579 so that this new function doesn't get optimized away by a
5580 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5582 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5584 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5586 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5588 Fix the `xbytecode' command.
5589 * .gdbinit (xprintbytestr): New command.
5590 (xwhichsymbols): Rename from `which'; all callers changed.
5591 (xbytecode): Print the byte-code string as well.
5593 2011-10-29 Kim Storm <storm@cua.dk>
5595 * alloc.c (which_symbols): New function.
5597 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5599 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5602 2011-10-29 Glenn Morris <rgm@gnu.org>
5604 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5605 Not clear what it was for, and it causes various bugs. (Bug#9839)
5607 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5609 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5610 possible random value that matches one of those tested as
5611 condition to clear the mouse face.
5613 2011-10-28 Chong Yidong <cyd@gnu.org>
5615 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5617 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5619 * window.c (make_window): Initialize phys_cursor_on_p.
5621 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5623 * lisp.h (struct Lisp_Symbol): Update comments.
5625 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5627 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5629 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5631 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5632 <oslsachem@gmail.com> for helping to debug this.
5634 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5635 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5636 (g_b_init_get_glyph_outline_w): New static variables.
5637 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5638 (GetGlyphOutlineW_Proc): New typedefs.
5639 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5640 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5642 (w32font_open_internal, compute_metrics):
5643 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5644 instead of calling the "wide" APIs directly.
5646 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5648 * w32.h (syms_of_w32font): Add prototype.
5650 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5652 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5653 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5654 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5655 (Fmove_to_window_line): Doc fix.
5657 2011-10-27 Chong Yidong <cyd@gnu.org>
5659 * process.c (make_process): Set gnutls_state to NULL.
5661 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5662 non-NULL, regardless of GNUTLS_INITSTAGE.
5663 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5664 an error. Set process slots as soon as we allocate them.
5666 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5668 2011-10-27 Chong Yidong <cyd@gnu.org>
5670 * gnutls.c (emacs_gnutls_deinit): New function.
5671 Deallocate credentials structures as well as calling gnutls_deinit.
5672 (Fgnutls_deinit, Fgnutls_boot): Use it.
5674 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5675 (deactivate_process): Call emacs_gnutls_deinit.
5677 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5679 * image.c (x_create_x_image_and_pixmap):
5680 * w32.c (sys_rename, w32_delayed_load):
5681 * w32font.c (fill_in_logfont):
5682 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5684 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5686 * w32fns.c (w32_default_color_map): New function,
5687 extracted from Fw32_default_color_map.
5688 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5690 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5692 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5694 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5696 * keyboard.c (test_undefined): New function (bug#9751).
5697 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5699 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5701 * sysdep.c (init_sys_modes): Fix the check for the controlling
5702 terminal (Bug#6649).
5704 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5706 * dispextern.h (struct bidi_it): New member next_en_type.
5708 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5709 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5710 current character, check also for next_en_type being WEAK_EN.
5711 (bidi_resolve_weak): Don't enter the expensive loop if the current
5712 position is before next_en_pos. Record the bidi type of the first
5713 non-ET, non-BN character we find, in addition to its position.
5714 (bidi_level_of_next_char): Invalidate next_en_type when
5715 next_en_pos is over-stepped.
5717 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5719 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5720 * editfns.c: Rewrite current-time-zone so that it invokes
5721 the equivalent of (format-time-string "%Z") to get the time zone name.
5722 This fixes a bug when the time zone name contains characters that
5723 need converting from the system time locale to Emacs internal format.
5724 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5725 that patch fixed format-time-string to do the conversion, but
5726 I forgot to fix current-time-zone.
5727 (format_time_string): New function, containing most of
5728 what Fformat_time_string used to contain.
5729 (Fformat_time_string): Rewrite in terms of format_time_string.
5730 This doesn't change this function's behavior.
5731 (current-time-zone): Rewrite to use format_time_string.
5732 This fixes the bug reported by Michael Schierl in
5733 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5734 Jason Rumney's 2007-06-07 change worked around this bug, but
5736 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5738 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5740 * xdisp.c (start_display): If the character at POS is displayed
5741 via a display vector, reset IT->current.dpvec_index to zero.
5742 (try_window_reusing_current_matrix): If a line ends in a display
5743 vector or the next line starts in a display vector, continue
5744 redrawing the window even though the character position of
5745 start_row was reached.
5748 2011-10-18 Chong Yidong <cyd@gnu.org>
5750 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5751 with nobreak-char-display too.
5753 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5755 Fix part 3 of bug#9771.
5756 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5757 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5758 non-neutral characters if the current character is a paragraph
5759 separator (a.k.a. Newline). This avoids running the same
5760 expensive loop twice, once when we consume the preceding newline
5761 and the other time when the line actually needs to be displayed.
5762 Avoid the loop when we see neutrals on the base embedding level
5763 following a character whose directionality is the same as the
5764 paragraph's. This avoids running the expensive loop when a line
5765 ends in a long sequence of neutrals, like control characters.
5766 Add assertion against STRONG_AL type. Slightly rearrange code
5767 that determines the type of a neutral given the first non-neutral
5769 (bidi_level_of_next_char): Set next_en_pos to zero when
5770 invalidating its info.
5772 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5774 * xdisp.c (push_display_prop): Determine whether to record string
5775 or buffer position by IT->string, not by IT->method. Allow
5776 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5777 (move_it_vertically_backward): Don't look for character position
5778 immediately after the newline when in a continuation line.
5781 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5783 * window.c (coordinates_in_window): Rewrite and delabelize
5784 vertical border check. (Bug#5357) (Bug#9618)
5786 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5788 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5789 errors in XSetWindowBorder (bug#9310).
5791 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5793 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5794 avoid crash when xmalloc overrun checking is enabled.
5796 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5798 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5799 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5800 cursor motion with <left> and <right> arrow keys.
5802 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5803 some callers set that themselves.
5805 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5807 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5808 display string and the previous row comes from the same string and
5809 is empty. (Bug#9739) (Bug#9738)
5811 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5813 * doc.c (get_doc_string): Encode file name (bug#9735).
5815 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5817 * bidi.c (bidi_level_of_next_char):
5818 * xdisp.c (get_visually_first_element): Remove old incorrect
5819 comments regarding the Unicode Line Separator character.
5821 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5823 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5825 * alloc.c (Fgc_status): Do not access beyond zombies array
5826 boundary if nzombies > MAX_ZOMBIES.
5827 * alloc.c (dump_zombies): Add missing format specifier.
5829 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5831 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5832 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5834 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5835 Some packages use them to denote characters with modifiers.
5837 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5839 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5840 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5841 matching a pp-number. Rename parameter var to var1.
5843 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5845 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5847 2011-10-08 Glenn Morris <rgm@gnu.org>
5849 * callint.c (Fcall_interactively): Give a more explicit error for the
5850 'c' case with a non-character input. (Bug#8479)
5852 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5854 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5856 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5857 lines that are hscrolled on the left.
5859 * dispnew.c (buffer_posn_from_coords): Account for a possible
5860 presence of header-line. (Bug#4426)
5862 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5864 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5865 Don't advertise functionality which we discourage or doesn't work.
5867 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5869 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5870 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5871 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5872 this makes Emacs dump core during garbage collection on rare
5873 occasions. sizeof is obviously inferior to offsetof here, so
5874 stick with offsetof.
5875 (GC_POINTER_ALIGNMENT): New macro.
5876 (mark_memory): Omit 3rd (offset) arg; caller changed.
5877 Don't assume EMACS_INT alignment is the same as pointer alignment.
5879 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5881 * keyboard.c (read_key_sequence_remapped): New var.
5882 (read_key_sequence): Compute remapping in the right buffer.
5883 (command_loop_1): Use read_key_sequence's remapping directly.
5885 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5887 * dired.c (file_name_completion): Don't expand file name.
5888 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5889 before checking file name handler.
5891 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5892 they've been requested explicitly (bug#9591).
5894 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5896 * keymap.c (Fsingle_key_description): Use make_specified_string
5897 instead of build_string to build string from push_key_description.
5900 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5902 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5903 This fixes a Y2038 bug on 64-bit hosts.
5904 * buffer.c (reset_buffer):
5905 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5906 (Fclear_buffer_auto_save_failure):
5907 Use 0, not -1, to represent an unset failure time, since time_t
5908 might not be signed.
5910 Remove dependency on glibc malloc internals.
5911 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5912 Move back here from lisp.h, but with their new implementations.
5913 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5914 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5915 * charset.c (charset_table_init): New static var.
5916 (syms_of_charset): Use it instead of xmalloc. This removes a
5917 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5918 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5919 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5920 Move back to alloc.c.
5921 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5922 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5924 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5926 * nsterm.m (windowDidResize): Call x_set_window_size only when
5927 ns_in_resize is true. Otherwise set pixelwidth/height and
5928 call change_frame_size (Bug#9628).
5930 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5932 Port --enable-checking=all to Fedora 14 x86-64.
5933 * charset.c (syms_of_charset): Also account for glibc malloc's
5934 internal overhead when calculating the initial malloc maximum.
5936 Port --enable-checking=all to Fedora 14 x86.
5937 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5939 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5940 (overrun_check_realloc, overrun_check_free):
5941 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5942 That way, xmalloc returns a properly-aligned pointer even if
5943 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5944 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5945 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5946 into account when calculating the initial malloc maximum.
5947 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5948 Move here from alloc.c, so that charset.c can use it too.
5949 Properly align; the old code wasn't right for common 32-bit hosts
5950 when configured with --enable-checking=all.
5951 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5952 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5954 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5956 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5959 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5961 * xdisp.c (compute_display_string_end): If there's no display
5962 string at CHARPOS, return -1.
5964 * bidi.c (bidi_fetch_char): When compute_display_string_end
5965 returns a negative value, treat the character as a normal
5966 character not covered by a display string. (Bug#9624)
5968 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5970 * lread.c (Fread_from_string): Fix typo in docstring.
5972 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5974 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5975 newline, reseat the iterator instead of bidi-iterating there one
5976 character at a time. (Bug#9610)
5977 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5978 TO_CHARPOS if the bidi iterator is at base embedding level.
5980 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5982 * lread.c (readevalloop): Use correct code for NBSP.
5983 (read1): Likewise. (Bug#9608)
5985 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5987 * dbusbind.c (Fdbus_register_signal): When service is not
5988 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5990 2011-09-25 Glenn Morris <rgm@gnu.org>
5992 * buffer.c (truncate-lines): Doc fix.
5994 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5996 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5997 (Fset_window_next_buffers): Doc fix.
5999 2011-09-24 Glenn Morris <rgm@gnu.org>
6001 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6003 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6005 Fix minor problems found by static checking.
6006 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6007 * indent.c (Fvertical_motion): Fix == vs = typo.
6009 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6011 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6012 Default value is now t. Doc fix.
6014 * indent.c (Fvertical_motion): Compute and apply the overshoot
6015 logic when moving up, not only when moving down. Fix the
6016 confusing name and values of the it_overshoot_expected variable;
6017 logic changes accordingly. (Bug#9254) (Bug#9549)
6019 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6020 CHARPOS is covered by a display string which includes newlines.
6021 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6022 is covered by a display string with embedded newlines.
6024 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6026 * dbusbind.c (Fdbus_register_signal): Add match rule to
6027 Vdbus_registered_objects_table. (Bug#9581)
6028 (Fdbus_register_method, Vdbus_registered_objects_table):
6031 2011-09-24 Jim Meyering <meyering@redhat.com>
6033 do not ignore write error for any output size
6034 The previous change was incomplete.
6035 While it makes emacs --batch detect the vast majority of stdout
6036 write failures, errors were still ignored whenever the output size is
6037 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6038 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6039 && echo FAIL: ignored write error
6040 FAIL: ignored write error
6041 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6042 && echo FAIL: ignored write error
6043 FAIL: ignored write error
6044 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6046 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6048 * emacs.c (Fkill_emacs): In noninteractive mode exit
6049 non-successfully if a write error occurred on stdout. (Bug#9574)
6051 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6053 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6056 * dispextern.h (struct it): Update the comment documenting what
6059 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6061 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6062 a display string, extend search for cursor position to end of row.
6063 (find_row_edges): If the row ends in a newline from a display
6064 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6065 Handle the case of a display string with multiple newlines.
6066 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6067 non-empty line. Fixes confusing cursor motion with arrow keys at
6068 the beginning of a line that starts with whitespace.
6070 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6072 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6075 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6077 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6080 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6082 * xdisp.c (display_line): Record maximum and minimum buffer
6083 positions even if no glyphs were produced (e.g., by a zero-width
6084 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6085 buffer positions that will be removed from the glyph row because
6087 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6088 column is beyond frame width: don't subtract 1 "pixel" when
6089 computing width of the stretch.
6090 (reseat_at_next_visible_line_start): Undo the change made on
6091 2011-09-17 that saved paragraph information and restored it after
6092 the call to `reseat'. (Bug#9545)
6094 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6096 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6097 and turn window cursor on if cleared (Bug#9415).
6099 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6101 * search.c (boyer_moore): Take unibyte characters from pattern
6102 literally. (Bug#9458)
6104 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6106 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6108 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6110 Fix minor problem found by static checking.
6111 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6112 initialized, to pacify gcc -Wuninitialized.
6114 * fileio.c: Report proper errno when syscall falls.
6115 (Finsert_file_contents): Save and restore errno,
6116 so that report_file_error outputs the correct diagnostic.
6117 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6119 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6121 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6123 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6125 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6126 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6128 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6130 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6131 about the current paragraph and restore it after the call to reseat.
6133 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6134 (bidi_find_paragraph_start): Search back for paragraph beginning
6135 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6136 (bidi_move_to_visually_next): Only trigger paragraph-related
6137 computations when the last character is a newline or at EOB, not
6138 just any NEUTRAL_B. (Bug#9470)
6140 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6141 truncated lines if point is covered by a display string. (Bug#9524)
6143 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6145 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6146 (cons_to_x_long): New function.
6147 (lisp_data_to_selection_data): Use it. Correct the test for
6148 short-versus-long data; it was negated. Break out of vector
6149 loop, for efficiency, when a long datum is discovered.
6151 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6153 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6155 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6157 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6158 GCC PR/17406) by declaring this function with external scope.
6160 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6162 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6163 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6165 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6167 * editfns.c (Fformat): Correctly handle text properties on "%%".
6169 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6171 * xterm.c (x_draw_composite_glyph_string_foreground):
6172 * w32term.c (x_draw_composite_glyph_string_foreground):
6173 * term.c (encode_terminal_code):
6174 * composite.c (composition_update_it, get_composition_id):
6175 * xdisp.c (get_next_display_element)
6176 (fill_composite_glyph_string): Add comments about special meaning
6177 of TAB characters in a composition.
6179 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6181 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6182 This occurs when processing a multibyte format.
6183 Problem reported by Wolfgang Jenker.
6185 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6187 * xdisp.c (try_cursor_movement): Only check for exact match if
6188 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6190 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6192 Remove unused external symbols.
6193 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6194 * xdisp.c (calc_pixel_width_or_height): Now static.
6195 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6196 * indent.c (check_display_width):
6197 * w32term.c: Fix comment to match code.
6198 * xterm.c, xterm.h (x_catching_errors): Remove.
6200 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6202 * xselect.c: Use signed conversions more consistently (Bug#9498).
6203 (selection_data_to_lisp_data): Assume incoming selection data are
6204 signed integers, not unsigned. This is to be consistent with
6205 outgoing selection data, which was modified to use signed integers
6206 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6207 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6208 expects long, not unsigned long.
6210 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6212 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6213 computation of loop end. Reported by Johan Bockgård
6216 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6218 * frame.c (Fother_visible_frames_p): Function deleted.
6220 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6222 * indent.c (compute_motion): Process display vector front to back
6223 rather than the other way around. (Bug#2496)
6225 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6227 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6229 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6231 * minibuf.c (Fread_from_minibuffer): Doc fix.
6233 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6235 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6236 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6238 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6240 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6241 value for non-existent files.
6243 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6245 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6246 set its "size" to -1. This will set the modtime_size field of
6247 the corresponding buffer to -1, which is what
6248 verify-visited-file-modtime expects for files that do not exist.
6251 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6253 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6255 * lisp.h: ... from here. push_key_description is no longer
6256 defined in keyboard.c, so its declaration should not be in
6257 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6258 logically belongs with push_key_description.
6260 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6262 * buffer.h: Include <sys/types.h> instead of <time.h>.
6263 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6264 Problem reported by Herbert J. Skuhra.
6266 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6268 * xml.c (parse_region): Make the parsing work for
6269 non-comment-starting XML files again (bug#9144).
6271 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6273 * image.c (gif_load): Fix calculation of bottom and right corner.
6276 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6278 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6279 redisplay in small windows.
6281 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6283 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6285 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6287 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6288 Operate on live windows only.
6290 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6292 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6294 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6296 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6297 only under bidi iteration.
6299 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6301 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6303 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6305 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6306 Without this fix, the command to link temacs failed due to an
6307 undefined symbol __builtin_isnan. This is because
6308 /usr/include/iso/math_c99.h #defines isnan(x) to
6309 __builtin_isnan(x), but the bundled gcc, which identifies itself
6310 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6312 * floatfns.c (isnan): #undef, and then #define to a clone of
6314 (Fisnan): Always define, since it's always available now.
6315 (syms_of_floatfns): Always define isnan at the Lisp level.
6317 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6319 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6321 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6323 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6324 The previous code assumed that file offsets (off_t values) fit in
6325 EMACS_INT variables, which is not true on typical 32-bit hosts.
6326 The code messed up by falsely reporting buffer overflow in cases
6327 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6328 when "big" contains more than 2**29 bytes, even though this
6329 inserts just one byte and does not overflow the buffer.
6330 (Finsert_file_contents): Store file offsets as off_t
6331 values, not as EMACS_INT values. Check for overflow when
6332 converting between EMACS_INT and off_t. When checking for
6333 buffer overflow or for overlap, take the offsets into account.
6334 Don't use EMACS_INT for small values where int suffices.
6335 When checking for overlap, fix a typo: ZV was used where
6336 ZV_BYTE was intended.
6337 (Fwrite_region): Don't assume off_t fits into 'long'.
6338 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6340 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6342 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6344 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6346 sprintf-related integer and memory overflow issues (Bug#9412).
6348 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6349 (esprintf, exprintf, evxprintf): New functions.
6350 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6351 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6352 (modify_event_symbol): Do not assume that the length of
6353 name_alist_or_stem is safe to alloca and fits in int.
6354 (Fexecute_extended_command): Likewise for function name and binding.
6355 (Frecursion_depth): Wrap around reliably on integer overflow.
6356 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6357 since some callers pass EMACS_INT values.
6358 (Fsingle_key_description): Don't crash if symbol name contains more
6359 than MAX_ALLOCA bytes.
6360 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6361 (get_minibuffer): Arg is now EMACS_INT, not int.
6362 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6363 (esprintf, exprintf, evxprintf): New decls.
6364 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6366 * dbusbind.c (signature_cat): New function.
6367 (xd_signature, Fdbus_register_signal):
6368 Do not overrun buffer; instead, report string overflow.
6370 * dispnew.c (add_window_display_history): Don't overrun buffer.
6371 Truncate instead; this is OK since it's just a log.
6373 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6374 even if the time zone offset is outlandishly large.
6375 Don't mishandle offset == INT_MIN.
6377 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6378 when creating daemon; the previous buffer-overflow check was incorrect.
6380 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6381 which has the guts of the old verror function.
6383 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6384 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6386 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6387 (font_unparse_xlfd): Don't blindly alloca long strings.
6388 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6389 fits in int, when using sprintf. Use single snprintf to count
6390 length of string rather than counting it via multiple sprintfs;
6391 that's simpler and more reliable.
6392 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6393 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6394 sprintf, in case result does not fit in int.
6396 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6397 (fontset_from_font): Print it.
6399 * frame.c (tty_frame_count): Now printmax_t, not int.
6400 (make_terminal_frame, set_term_frame_name): Print it.
6401 (x_report_frame_params): In X, window IDs are unsigned long,
6402 not signed long, so print them as unsigned.
6403 (validate_x_resource_name): Check for implausibly long names,
6404 and don't assume name length fits in 'int'.
6405 (x_get_resource_string): Don't blindly alloca invocation name;
6406 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6409 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6410 (xg_check_special_colors, xg_set_geometry):
6411 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6413 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6414 Use esprintf, not sprintf, in case result does not fit in int.
6416 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6417 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6418 it as a large positive number.
6419 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6420 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6422 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6423 in case result does not fit in int.
6425 * print.c (float_to_string): Detect width overflow more reliably.
6426 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6427 buffer overrun. Don't assume list length fits in 'int'. Treat
6428 print length of 0 as 0, not as infinity; to be consistent with other
6429 uses of print length in this function. Don't overflow print length
6430 index. Don't assume hash table size fits in 'long', or that
6431 vectorlike size fits in 'unsigned long'.
6433 * process.c (make_process): Use printmax_t, not int, to format
6434 process-name gensyms.
6436 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6438 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6439 to avoid potential buffer overrun.
6441 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6442 if X resource line is longer than 512 bytes.
6444 * xfns.c (x_window): Make sprintf buffer a bit bigger
6445 to avoid potential buffer overrun.
6447 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6449 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6451 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6453 Integer overflow fixes for scrolling, etc.
6454 Without these, Emacs silently mishandles large integers sometimes.
6455 For example, "C-u 4294967297 M-x recenter" was treated as if
6456 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6458 * xdisp.c (try_window_id): Check Emacs fixnum range before
6459 converting to 'int'.
6461 * window.c (window_scroll_line_based, Frecenter):
6462 Check that an Emacs fixnum is in range before assigning it to 'int'.
6463 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6464 values converted from Emacs fixnums.
6465 (Frecenter): Don't wrap around a line count if it is out of 'int'
6466 range; instead, treat it as an extreme value.
6467 (Fset_window_configuration, compare_window_configurations):
6468 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6470 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6471 that can exceed INT_MAX. Check that EMACS_INT value is in range
6472 before assigning it to the (possibly-narrower) index.
6473 (match_limit): Don't assume that a fixnum can fit in 'int'.
6475 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6478 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6479 (Fvertical_motion): Don't wrap around LINES values that don't fit
6480 in 'int'. Instead, treat them as extreme values. This is good
6481 enough for windows, which can't have more than INT_MAX lines anyway.
6483 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6485 * Require libxml/parser.h to avoid compilation warning.
6487 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6489 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6490 since this reportedly can destroy thread storage.
6492 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6494 * syntax.c (find_defun_start): Update all cache variables if
6495 exiting early (Bug#9401).
6497 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6499 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6501 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6502 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6503 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6505 * term.c (tty_append_glyph): New function.
6506 (produce_stretch_glyph): Static function and its prototype deleted.
6508 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6511 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6513 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6514 when checking :margin (Bug#9390).
6515 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6516 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6517 so that the name doesn't mislead. All uses changed.
6519 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6521 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6524 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6526 * xdisp.c (move_it_to): Don't bail out early when reaching
6527 position beyond to_charpos, if we are scanning backwards.
6528 (move_it_vertically_backward): When DY == 0, make sure we get to
6529 the first character in the line after the newline.
6531 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6533 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6534 (ccl_driver): Do not generate an out-of-range pointer.
6535 (Fccl_execute_on_string): Remove unnecessary check for
6536 integer overflow, noted by Stefan Monnier in
6537 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6538 Remove a FIXME that didn't need fixing.
6539 Simplify the newly-introduced buffer reallocation code.
6541 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6543 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6545 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6547 Integer and memory overflow issues (Bug#9196).
6549 * doc.c (get_doc_string): Rework so that
6550 get_doc_string_buffer_size is the actual buffer size, rather than
6551 being 1 less than the actual buffer size; this makes xpalloc more
6554 * image.c (x_allocate_bitmap_record, cache_image):
6555 * xselect.c (Fx_register_dnd_atom):
6556 Simplify previous changes by using xpalloc.
6558 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6559 since either will do and ptrdiff_t is convenient with xpalloc.
6561 * charset.c (charset_table_size)
6562 (struct charset_sort_data.priority): Now ptrdiff_t.
6563 (charset_compare): Don't overflow if priorities differ greatly.
6564 (Fsort_charsets): Don't assume list length fits in int.
6565 Check for size-calculation overflow when allocating sort data.
6566 (syms_of_charset): Allocate an initial charset table that is
6567 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6569 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6571 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6572 The actual value is always <= INT_MAX, and leaving it unsigned made
6573 overflow checking harder.
6575 * dispextern.h (struct glyph_matrix.rows_allocated)
6576 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6577 with xpalloc. The values are still always <= INT_MAX.
6579 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6581 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6582 (SAFE_NALLOCA): New macro.
6584 * region-cache.c (struct boundary.pos, find_cache_boundary)
6585 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6586 (set_cache_region, invalidate_region_cache)
6587 (revalidate_region_cache, know_region_cache, region_cache_forward)
6588 (region_cache_backward, pp_cache):
6589 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6590 so that ptrdiff_t * can be passed to xpalloc.
6591 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6592 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6593 (pp_cache): Don't assume cache_len fits in int.
6594 * region-cache.h: Adjust extern decls to match.
6596 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6597 EMACS_INT, since either will do, for xpalloc.
6599 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6600 (xnmalloc, xnrealloc, xpalloc): New functions.
6602 * bidi.c (bidi_shelve_header_size): New constant.
6603 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6604 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6606 * bidi.c (bidi_cache_shrink):
6607 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6609 Don't update size of array until after memory allocation succeeds,
6610 because xmalloc/xrealloc may not return.
6611 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6612 now that we have proper integer overflow checking.
6613 (record_overlay_string, overlay_strings): Catch overflows when
6614 calculating size of overlay_str_buf.
6616 * callproc.c (Fcall_process): Check for size overflow when
6617 calculating size of args2.
6618 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6619 Normally we prefer signed values, but sticking with ptrdiff_t would
6620 require adding more-complicated checks.
6622 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6623 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6624 Redo buffer-overflow calculations to avoid integer overflow.
6625 Add a FIXME comment where memory seems to be over-allocated.
6627 * character.c (Fstring): Check for size-calculation overflow.
6629 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6630 unnecessary integer overflow. Check for size overflow.
6631 (encode_coding_object): Don't update size until xmalloc succeeds.
6633 * composite.c (get_composition_id): Check for overflow in glyph
6634 length calculations.
6636 Integer and memory overflow fixes for display code.
6637 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6638 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6639 (scrolling_window): Check for overflow in size calculations.
6640 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6641 Don't assume glyph table len fits in int.
6642 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6643 (row_table_size): Now ptrdiff_t, not int.
6644 (scrolling_window): Avoid overflow in size calculations.
6645 Don't update size until allocation succeeds.
6646 * fns.c (concat): Check for overflow in size calculations.
6647 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6648 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6649 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6651 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6652 (get_doc_string): Check for size calculation overflow.
6653 Don't update size until allocation succeeds.
6654 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6655 EMACS_INT, where ptrdiff_t will do.
6656 (Fsubstitute_command_keys): Check for string overflow.
6658 * editfns.c (set_time_zone_rule): Don't assume environment length
6660 (message_length): Now ptrdiff_t, not int.
6661 (Fmessage_box): Don't update size until allocation succeeds.
6662 Don't assume message length fits in int.
6663 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6665 * emacs.c (main): Do not reallocate argv, since there is a null at
6666 the end that can be overwritten, and this way there's no need to
6667 worry about size-calculation overflow.
6668 (sort_args): Check for size-calculation overflow.
6670 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6672 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6674 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6675 (x_set_scroll_bar_width, x_figure_window_size):
6676 Check for integer overflow.
6677 (x_set_alpha): Do not assume XINT fits in int.
6679 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6680 This is for the members text_lines, text_cols, total_lines, total_cols,
6681 where the system imposes an 'int' limit.
6683 * fringe.c (Fdefine_fringe_bitmap):
6684 Don't update size until alloc works.
6686 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6687 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6689 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6690 Check for size-calculation overflow.
6691 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6692 do, as we prefer signed integers.
6693 (id_to_widget.max_size, id_to_widget.used)
6694 (xg_store_widget_in_map, xg_remove_widget_from_map)
6695 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6696 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6697 Use and return ptrdiff_t, not int.
6698 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6699 * gtkutil.h: Change prototypes to match the above.
6701 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6702 are duplicate now that they've been promoted to lisp.h.
6703 (x_allocate_bitmap_record, x_alloc_image_color)
6704 (make_image_cache, cache_image, xpm_load):
6705 Don't update size until alloc is done.
6706 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6708 Check for size calculation overflow.
6709 (ct_colors_allocated_max): New constant.
6710 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6713 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6714 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6715 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6716 Use ptrdiff_t, not int, to count maps.
6717 (read_char_minibuf_menu_prompt): Check for overflow in size
6718 calculations. Don't update size until allocation succeeds.
6719 Redo calculations to avoid overflow.
6720 * keyboard.h: Change prototypes to match the above.
6722 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6724 (current_minor_maps): Check for size calculation overflow.
6725 * keymap.h: Change prototypes to match the above.
6727 * lread.c (read1, init_obarray): Don't update size until alloc done.
6729 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6730 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6732 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6733 Now ptrdiff_t, not int.
6734 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6735 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6737 * process.c (Fnetwork_interface_list): Check for overflow
6738 in size calculation.
6740 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6742 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6743 overflow. Don't bother calling xmalloc when xrealloc will do.
6745 * search.c (Freplace_match): Check for size calculation overflow.
6746 (Fset_match_data): Don't assume list lengths fit in 'int'.
6748 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6749 for command line length. Do not attempt to address one before the
6750 beginning of an array, as that's not portable.
6752 * term.c (max_frame_lines): Remove; unused.
6753 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6755 (encode_terminal_code, calculate_costs): Check for size
6756 calculation overflow.
6757 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6758 table lengths and related sizes. Don't update size until alloc
6759 done. Redo calculations to avoid overflow.
6760 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6762 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6763 subtracting pointers.
6764 (gobble_line): Check for overflow more carefully. Don't update size
6767 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6768 Don't update size until alloc done.
6769 Redo size calculations to avoid overflow.
6770 Check for size calculation overflow.
6771 (main) [DEBUG]: Fix typo in invoking tparam1.
6773 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6774 Use ptrdiff_t, not int, for sizes.
6775 (store_mode_line_noprop_char): Don't update size until alloc done.
6777 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6778 Use ptrdiff_t, not int, for sizes.
6779 (Finternal_make_lisp_face, cache_face):
6780 Check for size calculation overflow.
6781 (cache_face): Treat size calculation overflows as if they were
6782 memory exhaustion (the usual treatment), rather than aborting.
6784 * xfns.c (x_encode_text, x_set_name_internal)
6785 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6786 sizes, since they can exceed INT_MAX in size. Check for size
6787 calculation overflow.
6789 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6790 (xg_select): Check for size calculation overflow.
6791 Don't update size until alloc done.
6793 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6794 as sprintf is limited to int lengths.
6796 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6797 (X_LONG_MIN): New macros.
6798 Use them to make the following changes clearer.
6799 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6800 This change doesn't affect the value now, but it may help remind
6801 future maintainers not to raise the value too much later.
6802 (SELECTION_QUANTUM): Remove, replacing with ...
6803 (selection_quantum): ... new function, which avoids overflow.
6805 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6806 assumption that selection length fits in 'int'.
6807 (x_reply_selection_request, x_handle_selection_request)
6808 (x_get_window_property, receive_incremental_selection)
6809 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6810 (lisp_data_to_selection_data, clean_local_selection_data):
6811 Use ptrdiff_t, not int, to record length of selection.
6812 (x_reply_selection_request, x_get_window_property)
6813 (receive_incremental_selection, x_property_data_to_lisp):
6814 Redo calculations to avoid overflow.
6815 (x_reply_selection_request): When sending hint, ceiling it at
6816 X_LONG_MAX rather than relying on wraparound overflow to send
6818 (x_get_window_property, receive_incremental_selection)
6819 (lisp_data_to_selection_data, x_property_data_to_lisp):
6820 Check for size-calculation overflow.
6821 (x_get_window_property, receive_incremental_selection)
6822 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6823 Don't store size until memory allocation succeeds.
6824 (x_get_window_property): Plug memory leak on memory exhaustion.
6825 Don't double-block input; malloc is safe here. Don't assume 2**34
6826 - 4 fits in unsigned long. Add an xassert to check
6827 XGetWindowProperty overflow. Be more careful about overflow
6828 calculations, and distinguish size from memory overflow better.
6829 (receive_incremental_selection): When tracing, don't assume
6830 unsigned int is less than INT_MAX.
6831 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6832 harmful) conversions of unsigned short to int.
6833 (lisp_data_to_selection_data): Don't assume that integers
6834 in the range -65535 through -1 fit in an X unsigned short.
6835 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6836 result parameters unless successful. Rely on cons_to_unsigned
6837 to report problems with elements; the old code wasn't right anyway.
6838 (x_check_property_data): Check for int overflow; we cannot use
6839 a wider type due to X limits.
6840 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6842 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6844 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6845 (x_term_init): Check for size calculation overflow.
6846 (x_color_cells): Don't store size until memory allocation succeeds.
6847 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6848 Don't assume alloca size is less than MAX_ALLOCA.
6849 (x_term_init): Don't assume length fits in int (sprintf is limited
6852 Use ptrdiff_t for composition IDs.
6853 * character.c (lisp_string_width):
6854 * composite.c (composition_table_size, n_compositions)
6855 (get_composition_id, composition_gstring_from_id):
6856 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6857 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6858 * window.c (Frecenter):
6859 Use ptrdiff_t, not int, for composition IDs.
6860 * composite.c (get_composition_id): Check for integer overflow.
6861 * composite.h: Adjust prototypes to match the above changes.
6863 Use ptrdiff_t for hash table indexes.
6864 * category.c (hash_get_category_set):
6865 * ccl.c (ccl_driver):
6866 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6867 * coding.c (coding_system_charset_list, detect_coding_system):
6868 * coding.h (struct coding_system.id):
6869 * composite.c (get_composition_id, gstring_lookup_cache):
6870 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6871 * image.c (xpm_get_color_table_h):
6872 * lisp.h (hash_lookup, hash_put):
6873 * minibuf.c (Ftest_completion):
6874 Use ptrdiff_t for hash table indexes, not int (which is too
6875 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6876 32-bit --with-wide-int hosts).
6878 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6879 Add a FIXME comment about memory leaks.
6880 (syms_of_charset): Don't assume xmalloc returns.
6882 Don't assume that stated character widths fit in int.
6883 * character.c (Fchar_width, c_string_width, lisp_string_width):
6884 * character.h (CHAR_WIDTH):
6885 * indent.c (MULTIBYTE_BYTES_WIDTH):
6886 Use sanitize_char_width to avoid undefined and/or bad behavior
6887 with outlandish widths.
6888 * character.h (sanitize_tab_width): Rename from sanitize_width,
6889 now that we have two such functions. All uses changed.
6890 (sanitize_char_width): New inline function.
6892 Don't assume that tab-width fits in int.
6893 * character.h (sanitize_width): New inline function.
6894 (SANE_TAB_WIDTH): New macro.
6895 (ASCII_CHAR_WIDTH): Use it.
6896 * indent.c (sane_tab_width): Remove. All uses replaced by
6897 SANE_TAB_WIDTH (current_buffer).
6898 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6900 * fileio.c: Integer overflow issues with file modes.
6901 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6903 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6904 Remove unreachable code.
6905 (read_hex, load_charset_map_from_file): Check for integer overflow.
6907 * xterm.c: Don't go over XClientMessageEvent limit.
6908 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6909 (x_send_scroll_bar_event): Likewise. Check that the size does not
6910 exceed limits imposed by XClientMessageEvent, as well as the usual
6911 ptrdiff_t and size_t limits.
6913 * keyboard.c: Overflow, signedness and related fixes.
6914 (make_lispy_movement): Use same integer type in forward decl
6915 that is used in the definition.
6916 (read_key_sequence, keyremap_step):
6917 Change bufsize argument back to int, undoing my 2011-03-30 change.
6918 We prefer signed types, and int is wide enough here.
6919 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6920 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6921 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6922 length, not size_t. Use ptrdiff_t for index, not int.
6923 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6924 possibility of integer overflow.
6926 Overflow, signedness and related fixes for images.
6928 * dispextern.h (struct it.stack[0].u.image.image_id)
6929 (struct_it.image_id, struct image.id, struct image_cache.size)
6930 (struct image_cache.used, struct image_cache.ref_count):
6931 * gtkutil.c (update_frame_tool_bar):
6932 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6933 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6934 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6935 * nsmenu.m (update_frame_tool_bar):
6936 * xdisp.c (calc_pixel_width_or_height):
6937 * xfns.c (image_cache_refcount):
6938 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6939 on typical 64-bit hosts.
6941 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6942 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6943 Omit unnecessary casts to int.
6944 (parse_image_spec): Check that integers fall into 'int' range
6945 when the callers expect that.
6946 (image_ascent): Redo ascent calculation to avoid int overflow.
6947 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6948 (lookup_image): Remove unnecessary tests.
6949 (xbm_image_p): Locals are now of int, not EMACS_INT,
6950 since parse_image_check makes sure they fit into int.
6951 (png_load, gif_load, svg_load_image):
6952 Prefer int to unsigned where either will do.
6953 (tiff_handler): New function, combining the cores of the
6954 old tiff_error_handler and tiff_warning_handler.
6955 This function is rewritten to use vsnprintf and thereby avoid
6956 stack buffer overflows. It uses only the features of vsnprintf
6957 that are common to both POSIX and native Microsoft.
6958 (tiff_error_handler, tiff_warning_handler): Use it.
6959 (tiff_load, gif_load, imagemagick_load_image):
6960 Don't assume :index value fits in 'int'.
6961 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6962 (imagemagick_load_image): Check that crop parameters fit into
6963 the integer types that MagickCropImage accepts. Don't assume
6964 Vimagemagick_render_type has a nonnegative value. Don't assume
6965 size_t fits in 'long'.
6966 (gs_load): Use printmax_t to print the widest integers possible.
6967 Check for integer overflow when computing image height and width.
6969 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6971 * xdisp.c (redisplay_window): Don't force window start if point
6972 will be invisible in the resulting window. (Bug#9324)
6974 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6976 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6977 the display spec is of the form `(space ...)'.
6978 (handle_display_spec): Return the value returned by
6979 handle_single_display_spec, not just 1 or zero.
6980 (handle_single_display_spec): If the display spec is of the form
6981 `(space ...)', and specifies display in the text area, return 2
6983 (try_cursor_movement): Check for the need to scroll more
6984 accurately, and prefer exact match for point under bidi.
6985 Don't advance `row' beyond the last row of the window.
6987 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6988 into disp_prop; all users changed.
6990 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6991 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6992 for the text covered by the display property.
6994 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6996 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6997 Change return value to nil.
6998 (Frecord_buffer): Delete unused function.
7000 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7002 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7003 buffers, return left-to-right.
7004 (set_cursor_from_row): Consider candidate row a win if its glyph
7005 represents a newline and point is on that newline. Fixes cursor
7006 positioning on the newline at EOL of R2L text within L2R
7007 paragraph, and vice versa.
7008 (try_cursor_movement): Check continued rows, in addition to
7009 continuation rows. Fixes unwarranted scroll when point enters a
7010 continued line of R2L text within an L2R paragraph, or vice versa.
7011 (cursor_row_p): Consider the case of point being equal to
7012 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7013 from the end of a short line to the beginning of a continued line
7014 of R2L text within L2R paragraph.
7015 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7016 composed characters.
7018 * bidi.c (bidi_check_type): Use xassert.
7019 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7022 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7024 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7027 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7029 * nsfont.m (ns_otf_to_script): Fix typo.
7031 2011-08-22 Kenichi Handa <handa@m17n.org>
7033 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7034 extra slot even if the purpose is char-code-property-table.
7036 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7038 * xdisp.c (redisplay_window): When computing centering_position,
7039 account for the height of the header line. (Bug#8874)
7041 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7042 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7043 candidate is selected by the mouse, and that candidate has a
7044 composed character under the mouse.
7046 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7047 coordinates reported by pos-visible-in-window-p for a composed
7048 character in column zero.
7050 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7052 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7054 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7056 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7057 consider it a hit if to_charpos is anywhere in the range of the
7058 composed buffer positions.
7060 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7062 * image.c (gif_load): Don't assume that each subimage has the same
7063 dimensions as the base image. Handle disposal method that is
7064 "undefined" by the gif spec (Bug#9335).
7066 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7068 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7069 (Fcondition_case): Document `debug' symbol in error handler.
7071 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7073 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7074 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7075 from an Org mode buffer to a Speedbar frame.
7077 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7078 a composition, take its buffer position from IT->cmp_it.charpos.
7079 Fixes cursor positioning at the beginning of a line that begins
7080 with a composed character.
7082 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7084 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7085 character bidirectional type, use STRONG_L instead. Fixes crashes
7086 in a buffer produced by `describe-categories'.
7088 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7089 members before the level stack, so they would be saved and
7090 restored when copying iterator state. Fixes incorrect reordering
7091 around TABs covered by display properties.
7093 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7095 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7097 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7099 * eval.c (internal_condition_case, internal_condition_case_1)
7100 (internal_condition_case_2, internal_condition_case_n):
7101 Remove unnecessary aborts (Bug#9081).
7103 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7105 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7106 has no `load' handler, try opening the file locally. (Bug#9311)
7108 2011-08-16 Ken Brown <kbrown@cornell.edu>
7110 * gmalloc.c: Expand comment.
7112 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7114 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7115 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7117 2011-08-16 Ken Brown <kbrown@cornell.edu>
7119 Fix memory allocation problems in Cygwin build (Bug#9273).
7121 * unexcw.c ( __malloc_initialized): Declare external variable.
7122 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7124 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7126 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7128 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7130 [CYGWIN] (special_realloc): New function.
7131 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7132 requests to realloc storage in the static heap.
7134 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7136 * bidi.c (bidi_initialize): Remove unused local.
7138 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7141 * biditype.h: Remove file.
7142 * makefile.w32-in ($(BLD)/bidi.$(O)):
7143 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7145 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7147 * chartab.c: Improve commentary for the uniprop_table API.
7149 * bidi.c (bidi_paragraph_init): Support zero value of
7150 bidi_ignore_explicit_marks_for_paragraph_level.
7151 (bidi_initialize): Use uniprop_table instead of including
7152 biditype.h and bidimirror.h.
7154 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7155 coordinates of the iterator when restoring from ppos_it.
7158 2011-08-14 Kenichi Handa <handa@m17n.org>
7160 * process.c (create_process): Call setup_process_coding_systems
7161 after the pid of the process is set to -1 (Bug#8162).
7163 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7165 * xdisp.c (move_it_in_display_line_to): Don't invoke
7166 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7167 ppos_it. Fixes vertical cursor motion when line beginning is
7168 covered by an image. (Bug#9296)
7170 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7172 * nsterm.h (ns_run_ascript): Declare.
7173 (NSAPP_DATA2_RUNASSCRIPT): Define.
7175 * nsfns.m (as_script, as_result, as_status): New static variables.
7176 (ns_run_ascript): New function.
7177 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7178 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7179 the event loop. Get status from as_status (Bug#7276).
7181 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7182 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7183 the event loop (Bug#7276).
7185 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7187 * gnutls.c (QCgnutls_bootprop_priority)
7188 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7189 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7190 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7191 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7192 (QCgnutls_bootprop_verify_hostname_error)
7193 (QCgnutls_bootprop_callbacks_verify): Rename from
7194 Qgnutls_bootprop_..., all uses changed.
7196 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7199 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7201 * xfaces.c (Qframe_set_background_mode): Now static.
7202 * dispextern.h (Qframe_set_background_mode): Remove decl.
7204 * process.c (Fnetwork_interface_info): Declare local only if needed.
7206 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7208 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7209 (Fnetwork_interface_list): Allocate in increments of bytes instead
7210 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7211 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7213 (struct ifflag_def): notrailers is smart on OSX.
7214 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7215 Get hardware address with getifaddrs if available.
7217 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7219 * xdisp.c (iterate_out_of_display_property): xassert that
7220 IT->position is set to within IT->object's boundaries. Break from
7221 the loop as soon as EOB is reached; avoids infloops in redisplay
7222 when IT->position is set up wrongly due to some bug.
7223 Set IT->current to match the bidi iterator unconditionally.
7224 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7225 entry. Force push_it to save on the stack the current
7226 buffer/string position, to be restored by pop_it. Fix flags in
7227 the iterator structure wrt the object coming from a display
7228 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7229 properties. (Bug#9284)
7231 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7233 * fontset.c (fontset_get_font_group): Add proper type checks.
7236 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7238 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7239 and LC_VERSION_MIN_MACOSX.
7240 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7241 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7243 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7245 * xdisp.c (forward_to_next_line_start): Allow to use the
7246 no-display-properties-and-no-overlays under bidi display.
7247 Set disp_pos in the bidi iterator to avoid searches for display
7248 properties and overlays.
7250 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7252 * editfns.c (Fset_time_zone_rule): Document relationship with the
7255 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7256 the font entity extracted from the cache (Bug#8109).
7258 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7260 * composite.c (autocmp_chars): Don't reset point. That is done by
7261 restore_point_unwind (Bug#5984).
7263 2011-08-07 Juri Linkov <juri@jurta.org>
7265 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7266 to show the arg `TIME' instead of `TIMEVAL'.
7268 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7270 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7271 display property strides EOL and includes a newline, as in
7272 longlines-mode. (Bug#9254)
7273 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7274 word-wrap under bidirectional display. (Bug#9224)
7276 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7277 is non-zero, even if the data buffer is NULL. Fixes a crash in
7278 vertical-motion with longlines-mode. (Bug#9254)
7280 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7282 * bidi.c <bidi_cache_total_alloc>: Now static.
7283 (bidi_initialize): Initialize bidi_cache_total_alloc.
7285 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7288 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7289 amount allocated this far in `bidi_cache_total_alloc'.
7290 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7291 non-zero, only free the data buffer without restoring the cache
7292 contents. All callers changed.
7294 * dispextern.h (bidi_unshelve_cache): Update prototype.
7296 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7297 (move_it_in_display_line, move_it_to)
7298 (move_it_vertically_backward, move_it_by_lines): Replace the call
7299 to xfree to an equivalent call to bidi_unshelve_cache.
7300 (move_it_in_display_line_to): Fix logic of returning
7301 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7303 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7305 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7306 came from a string character with a `cursor' property. (Bug#9229)
7308 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7310 * Makefile.in (LIB_PTHREAD): New variable.
7311 (LIBES): Add LIB_PTHREAD (Bug#9216).
7313 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7314 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7316 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7318 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7320 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7322 * xterm.c (x_find_topmost_parent): New function.
7323 (x_set_frame_alpha): Find topmost parent window with
7324 x_find_topmost_parent and set the property there also (bug#9181).
7325 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7327 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7329 * callproc.c (Fcall_process): Avoid vfork clobbering
7330 the local vars buffer, coding_systems, current_dir.
7332 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7334 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7336 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7338 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7339 so that it is not optimized away.
7341 * xdisp.c (compute_display_string_pos): Remove unused local.
7343 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7345 Fix slow cursor motion and scrolling in large buffers with
7346 selective display, like Org Mode buffers. (Bug#9218)
7348 * dispextern.h (struct bidi_it): New member disp_prop_p.
7350 * xdisp.c: Remove one-slot cache of display string positions.
7351 (compute_display_string_pos): Accept an additional argument
7352 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7353 for a display string or property. If found, set DISP_PROP_P
7356 * bidi.c (bidi_fetch_char): Accept an additional argument
7357 DISP_PROP_P, and pass it to compute_display_string_pos.
7358 Only handle text covered by a display string if DISP_PROP_P is returned
7359 non-zero. All callers of bidi_fetch_char changed.
7361 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7363 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7365 2010-12-03 Don March <don@ohspite.net>
7367 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7368 last character M-[char] is translated to ESC [char] (bug#7541).
7370 2011-08-02 Kenichi Handa <handa@m17n.org>
7372 * lisp.h (uniprop_table): Extern it.
7374 * chartab.c (uniprop_table): Make it non-static.
7376 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7378 * xdisp.c (forward_to_next_line_start): Accept additional argument
7379 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7381 (reseat_at_next_visible_line_start): Use the bidi iterator state
7382 returned by forward_to_next_line_start to restore the state of
7383 it->bidi_it after backing up to previous newline. (Bug#9212)
7385 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7387 * regex.c (re_comp): Protoize.
7388 (re_exec): Fix return type.
7389 (regexec): Fix type of `ret'. (Bug#9203)
7391 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7393 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7394 This is needed if max-image-size is a floating-point number.
7396 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7398 * print.c (print_object): Print empty symbol as ##.
7400 * lread.c (read1): Read ## as empty symbol.
7402 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7404 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7405 setting frame foreground color (Bug#9175).
7406 (x_set_background_color): Likewise.
7408 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7409 contents (Bug#9176).
7410 (EmacsTooltip -init): Remove bezels and add shadows to
7413 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7414 or scroll bar (Bug#8470).
7416 * nsfont.m (nsfont_open): Remove assignment to voffset and
7417 unnecessary vars hshink, expand, hd, full_height, min_height.
7418 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7420 * nsterm.h (nsfont_info): Remove voffset field.
7422 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7424 Implement strike-through and overline on NextStep (Bug#8863).
7426 * nsfont.m (nsfont_open): Use underline position provided by font,
7427 instead of hard-coded value of 2.
7428 (nsfont_draw): Call ns_draw_text_decoration instead.
7430 * nsterm.h: Add declaration for ns_draw_text_decoration.
7432 * nsterm.m (ns_draw_text_decoration): New function for drawing
7433 underline, overline, and strike-through.
7434 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7435 ns_draw_text_decoration. Change treatment of cursor drawing to
7436 accommodate underlining, etc.
7438 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7440 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7443 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7445 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7446 Without this fix, if a signal arrives just after memory fills up,
7447 'malloc' might be invoked reentrantly.
7449 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7450 In other words, assume that every image size is allowed, on non-X
7451 hosts. This assumption is probably wrong, but it lets Emacs compile.
7453 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7455 * regex.c (re_iswctype): Convert return values to boolean.
7457 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7459 * xdisp.c (compute_display_string_pos): Don't use cached display
7460 string position if the buffer had its restriction changed.
7463 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7467 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7469 Integer signedness and overflow and related fixes. (Bug#9079)
7471 * bidi.c: Integer size and overflow fixes.
7472 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7473 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7474 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7475 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7476 (bidi_find_other_level_edge):
7477 Use ptrdiff_t instead of EMACS_INT where either will do.
7478 This works better on 32-bit hosts configured --with-wide-int.
7479 (bidi_cache_ensure_space): Check for size-calculation overflow.
7480 Use % rather than repeated addition, for better worst-case speed.
7481 Don't set bidi_cache_size until after xrealloc returns, because it
7483 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7484 (bidi_cache_ensure_space): Also check that the bidi cache size
7485 does not exceed that of the largest Lisp string or buffer. See Eli
7486 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7488 * alloc.c (__malloc_size_t): Remove.
7489 All uses replaced by size_t. See Andreas Schwab's note
7490 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7492 * image.c: Improve checking for integer overflow.
7493 (check_image_size): Assume that f is nonnull, since
7494 it is always nonnull in practice. This is one less thing to
7495 worry about when checking for integer overflow later.
7496 (x_check_image_size): New function, which checks for integer
7497 overflow issues inside X.
7498 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7499 This removes the need for a memory_full check.
7500 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7501 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7502 (xbm_read_bitmap_data): Change locals back to 'int', since
7503 their values must fit in 'int'.
7504 (xpm_load_image, png_load, tiff_load):
7505 Invoke x_create_x_image_and_pixmap earlier,
7506 to avoid much needless work if the image is too large.
7507 (tiff_load): Treat overly large images as if
7508 x_create_x_image_and_pixmap failed, not as malloc failures.
7509 (gs_load): Use x_check_image_size.
7511 * gtkutil.c: Omit integer casts.
7512 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7513 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7515 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7517 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7518 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7519 would wrongly return t on a 64-bit host.
7521 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7522 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7523 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7524 and therefore cause GCC to emit a bogus diagnostic in some cases.
7526 * image.c: Integer signedness and overflow and related fixes.
7527 This is not an exhaustive set of fixes, but it's time to
7528 record what I've got.
7529 (lookup_pixel_color, check_image_size): Remove redundant decls.
7530 (check_image_size): Don't assume that arbitrary EMACS_INT values
7531 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7532 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7533 (tiff_load, imagemagick_load_image):
7534 Check for overflow in size calculations.
7535 (x_create_x_image_and_pixmap): Remove unnecessary test for
7536 xmalloc returning NULL; that can't happen.
7537 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7538 (xpm_color_bucket): Use better integer hashing function.
7539 (xpm_cache_color): Don't possibly over-allocate memory.
7540 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7541 (gif_memory_source):
7542 Use ptrdiff_t, not int or size_t, to record sizes.
7543 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7544 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7545 either works, as we prefer signed integers.
7546 (tiff_read_from_memory, tiff_write_from_memory):
7547 Return tsize_t, not size_t, since that's what the TIFF API wants.
7548 (tiff_read_from_memory): Don't fail simply because the read would
7549 go past EOF; instead, return a short read.
7550 (tiff_load): Omit no-longer-needed casts.
7551 (Fimagemagick_types): Don't assume size fits into 'int'.
7553 Improve hashing quality when configured --with-wide-int.
7554 * fns.c (hash_string): New function, taken from sxhash_string.
7555 Do not discard information about ASCII character case; this
7556 discarding is no longer needed.
7557 (sxhash-string): Use it. Change sig to match it. Caller changed.
7558 * lisp.h: Declare it.
7559 * lread.c (hash_string): Remove, since we now use fns.c's version.
7560 The fns.c version returns a wider integer if --with-wide-int is
7561 specified, so this should help the quality of the hashing a bit.
7563 * emacs.c: Integer overflow minor fix.
7564 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7565 Define only if GNU_LINUX.
7566 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7568 * dispnew.c: Integer signedness and overflow fixes.
7569 Remove unnecessary forward decls, that were a maintenance hassle.
7570 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7572 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7573 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7574 (prepare_desired_row, line_draw_cost):
7575 Use int, not unsigned, where either works.
7576 (save_current_matrix, restore_current_matrix):
7577 Use ptrdiff_t, not size_t, where either works.
7578 (init_display): Check for overflow more accurately, and without
7579 relying on undefined behavior.
7581 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7582 Remove, replacing with the new symbols in lisp.h. All uses changed.
7583 * fileio.c (make_temp_name):
7584 * filelock.c (lock_file_1, lock_file):
7585 * xdisp.c (message_dolog):
7586 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7587 Use pMd etc. instead.
7588 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7589 replacing the pWIDE etc. symbols removed from editfns.c.
7591 * keyboard.h (num_input_events): Now uintmax_t.
7592 This is (very slightly) less likely to mess up due to wraparound.
7595 * buffer.c: Integer signedness fixes.
7596 (alloc_buffer_text, enlarge_buffer_text):
7597 Use ptrdiff_t rather than size_t when either will do, as we prefer
7600 * alloc.c: Integer signedness and overflow fixes.
7601 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7602 (__malloc_size_t): Default to size_t, not to int.
7603 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7604 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7605 Prefer ptrdiff_t to size_t when either would do, as we prefer
7607 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7608 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7609 Now const. Initialize with values that are in range even if char
7611 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7612 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7613 These functions do the right thing with sizes > 2**32.
7614 (check_depth): Now ptrdiff_t, not int.
7615 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7616 Adjust to new way of storing sizes. Check for size overflow bugs
7618 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7619 slightly wrong anyway, as it missed one instance of
7620 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7621 (refill_memory_reserve): Omit needless cast to size_t.
7622 (mark_object_loop_halt): Mark as externally visible.
7624 * xselect.c: Integer signedness and overflow fixes.
7625 (Fx_register_dnd_atom, x_handle_dnd_message):
7626 Use ptrdiff_t, not size_t, since we prefer signed.
7627 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7628 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7629 x_dnd_atoms_size and x_dnd_atoms_length.
7631 * doprnt.c: Prefer signed to unsigned when either works.
7633 * doprnt.c (doprnt):
7635 * xdisp.c (vmessage):
7636 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7637 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7638 prefer signed arithmetic to avoid comparison confusion.
7639 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7640 but is a bit tricky.
7642 Assume freestanding C89 headers, string.h, stdlib.h.
7643 * data.c, doprnt.c, floatfns.c, print.c:
7644 Include float.h unconditionally.
7645 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7646 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7647 * regex.c: Likewise for stddef.h, string.h.
7648 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7649 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7650 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7651 (STDC_HEADERS): Remove obsolete defines.
7652 * sysdep.c: Include limits.h unconditionally.
7654 Assume support for memcmp, memcpy, memmove, memset.
7655 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7656 * regex.c (memcmp, memcpy):
7657 Remove; we assume C89 now.
7659 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7660 (__malloc_safe_bcopy): Remove; no longer needed.
7662 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7663 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7664 well either way, and we prefer signed to unsigned.
7666 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7668 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7669 closes the connection while we're reading (bug#9182).
7671 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7673 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7674 are specified (Bug#9168).
7676 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7678 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7679 Found by GCC static checking and --with-wide-int on a 32-bit host.
7681 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7683 * xdisp.c (compute_display_string_pos): Fix logic of caching
7684 previous display string position. Initialize cached_prev_pos to
7685 -1. Fixes slow-down at the beginning of a buffer.
7687 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7689 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7690 for attrs[LFACE_FONTSET_INDEX].
7692 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7694 * xml.c (parse_region): Remove unused local
7695 that was recently introduced.
7697 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7699 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7700 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7702 * xdisp.c (move_it_in_display_line_to): Record the best matching
7703 position for TO_CHARPOS while scanning the line, and restore it on
7704 exit if none of the characters scanned was an exact match.
7705 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7706 when exact match is impossible due to invisible text, and the
7707 lines are truncated.
7709 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7711 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7714 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7716 Fix a significant slow-down of cursor motion with C-n, C-p,
7717 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7718 auto-repeat under bidi redisplay in fontified buffers.
7719 * xdisp.c (compute_stop_pos_backwards): New function.
7720 (next_element_from_buffer): Call compute_stop_pos_backwards to
7721 find a suitable prev_stop when we find ourselves before
7723 (reseat): Don't look for prev_stop, as that could mean a very long
7725 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7726 <cached_disp_overlay_modiff>: Cache for last found display string
7728 (compute_display_string_pos): Return the cached position if asked
7729 about the same buffer in the same area of character positions, and
7730 the buffer wasn't changed since the time the display string
7731 position was cached.
7733 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7735 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7736 is an integer, which is important for empty lines. (Bug#9149)
7738 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7740 * frame.c (Fmodify_frame_parameters): In tty case, update the
7741 default face if necessary (Bug#4238).
7743 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7745 * editfns.c (Fstring_to_char): No need to explain what a character
7746 is in the docstring (Bug#6576).
7748 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7750 * xml.c (parse_region): Make sure we always return a tree.
7752 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7754 * xml.c (parse_region): If a document contains only comments,
7757 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7759 * xml.c (make_dom): Return comments, too.
7761 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7764 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7765 and the surrounding thread.
7766 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7767 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7768 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7770 * s/openbsd.h (BROKEN_SIGIO): Define.
7771 * unexelf.c (unexec) [__OpenBSD__]:
7772 Don't update the .mdebug section of the Alpha COFF symbol table.
7774 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7776 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7779 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7781 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7782 This fixes some race conditions on the permissions of any newly
7785 * alloc.c (valid_pointer_p): Use pipe, not open.
7786 This fixes some permissions issues when debugging.
7788 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7789 If fchown fails to set both uid and gid, try to set just gid,
7790 as that is sometimes allowed. Adjust the file's mode to eliminate
7791 setuid or setgid bits that are inappropriate if fchown fails.
7793 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7795 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7796 to compare Lisp_Objects.
7797 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7798 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7799 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7801 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7803 * lread.c (read_integer): Unread even EOF character.
7804 (read1): Likewise. Properly record start position of symbol.
7806 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7807 symbol character follows.
7809 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7811 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7812 This works around a problem with the previous change to Fcopy_file.
7813 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7814 and without this change, GCC might complain about discarding
7815 fchown's return value.
7817 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7819 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7821 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7823 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7825 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7827 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7828 it's used from the C level.
7830 * process.c: Use the same condition for POLL_FOR_INPUT in both
7831 keyboard.c and process.c (bug#1858).
7833 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7835 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7836 (Fgnutls_boot): Use it.
7838 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7840 * doc.c (Fsubstitute_command_keys): Revert last change.
7842 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7844 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7845 quotes the next character, and doesn't affect other longer
7846 sequences (bug#8935).
7848 * lread.c (syms_of_lread): Clarify that is isn't only
7849 `eval-buffer' and `eval-defun' that's affected by
7850 `lexical-binding' (bug#8460).
7852 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7854 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7855 bidi redisplay when a line includes both an image and is truncated.
7857 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7859 Fix minor problems found by static checking.
7860 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7861 (elsz): Now a signed constant, not a size_t var. We prefer signed
7862 types to unsigned, to avoid integer comparison confusion. Without
7863 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7864 "cannot optimize loop, the loop counter may overflow", a symptom
7866 * indent.c (Fvertical_motion): Mark locals as initialized.
7867 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7869 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7871 * search.c (Fre_search_backward): Mention `case-fold-search' in
7872 all the re_search_* functions (bug#8138).
7874 * keyboard.c (Fopen_dribble_file): Document when the file is
7877 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7879 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7882 Support bidi reordering of display and overlay strings.
7883 * xdisp.c (compute_display_string_pos)
7884 (compute_display_string_end): Accept additional argument STRING.
7885 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7886 (reseat_to_string): Initialize bidi_it->string.s and
7887 bidi_it->string.schars.
7888 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7889 NULL (avoids a crash in bidi_paragraph_init).
7890 Initialize itb.string.lstring.
7891 (init_iterator): Call bidi_init_it only of a valid
7892 buffer position was specified. Initialize paragraph_embedding to
7894 (reseat_to_string): Initialize the bidi iterator.
7895 (display_string): If we need to ignore text properties of
7896 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7897 original value of -1 will not work with bidi.)
7898 (compute_display_string_pos): First arg is now struct
7899 `text_pos *'; all callers changed. Support display properties on
7901 (compute_display_string_end): Support display properties on Lisp
7903 (init_iterator, reseat_1, reseat_to_string): Initialize the
7904 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7905 when iterating on a string not from display properties).
7906 (compute_display_string_pos, compute_display_string_end):
7907 Fix calculation of the object to scan. Fixes an error when using
7909 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7910 base_level_stop; instead, set base_level_stop to BEGV.
7911 Fixes crashes in vertical-motion.
7912 (next_element_from_buffer): Improve commentary for when
7913 the iterator is before prev_stop.
7914 (init_iterator): Initialize bidi_p from the default value of
7915 bidi-display-reordering, not from buffer-local value. Use the
7916 buffer-local value only if initializing for buffer iteration.
7917 (handle_invisible_prop): Support invisible properties on strings
7918 that are being bidi-reordered.
7919 (set_iterator_to_next): Support bidi reordering of C strings and
7921 (next_element_from_string): Support bidi reordering of Lisp
7923 (handle_stop_backwards): Support Lisp strings as well.
7924 (display_string): Support display of R2L glyph rows.
7925 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7926 (init_iterator): Don't initialize it->bidi_p for strings
7928 (reseat_to_string): Initialize it->bidi_p for strings here.
7929 (next_element_from_string, next_element_from_c_string)
7930 (next_element_from_buffer): Add xassert's for correspondence
7931 between IT's object being iterated and it->bidi_it.string
7933 (face_before_or_after_it_pos): Support bidi iteration.
7934 (next_element_from_c_string): Handle the case of the first string
7935 character that is not the first one in the visual order.
7936 (get_visually_first_element): New function, refactored from common
7937 parts of next_element_from_buffer, next_element_from_string, and
7938 next_element_from_c_string.
7939 (tool_bar_lines_needed, redisplay_tool_bar)
7940 (display_menu_bar): Force left-to-right direction. Add a FIXME
7941 comment for making that be controlled by a user option.
7942 (push_it, pop_it): Save and restore the state of the
7943 bidi iterator. Save and restore the bidi_p flag.
7944 (pop_it): Iterate out of display property for string iteration as
7946 (iterate_out_of_display_property): Support iteration over strings.
7947 (handle_single_display_spec): Set up it->bidi_it for iteration
7948 over a display string, and call bidi_init_it.
7949 (handle_single_display_spec, next_overlay_string)
7950 (get_overlay_strings_1, push_display_prop): Set up the bidi
7951 iterator for displaying display or overlay strings.
7952 (forward_to_next_line_start): Don't use the shortcut if
7954 (back_to_previous_visible_line_start): If handle_display_prop
7955 pushed the iterator stack, restore the internal state of the bidi
7956 iterator by calling bidi_pop_it same number of times.
7957 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7958 and we are bidi-iterating, don't decrement the iterator position;
7959 instead, set the first_elt flag in the bidi iterator, to produce
7961 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7962 (push_display_prop): xassert that we are iterating a buffer.
7963 (push_it, pop_it): Save and restore paragraph_embedding member.
7964 (handle_single_display_spec, next_overlay_string)
7965 (get_overlay_strings_1, reseat_1, reseat_to_string)
7966 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7967 correctly. Don't assume unibyte strings are not bidi-reordered.
7968 (compute_display_string_pos)
7969 (compute_display_string_end): Fix handling the case of C string.
7970 (push_it, pop_it): Save and restore from_disp_prop_p.
7971 (handle_single_display_spec, push_display_prop): Set the
7972 from_disp_prop_p flag.
7973 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7974 (pop_it): Call iterate_out_of_display_property only if we are
7975 popping after iteration over a string that came from a display
7976 property. Fix a typo in popping stretch info. Add an assertion
7977 for verifying that the iterator position is in sync with the bidi
7979 (handle_single_display_spec, get_overlay_strings_1)
7980 (push_display_prop): Fix initialization of paragraph direction for
7981 string when that of the parent object is not yet determined.
7982 (reseat_1): Call bidi_init_it to resync the bidi
7983 iterator with IT's position. (Bug#7616)
7984 (find_row_edges): If ROW->start.pos gives position
7985 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7986 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7987 Reset the from_disp_prop_p flag.
7988 (SAVE_IT, RESTORE_IT): New macros.
7989 (pos_visible_p, face_before_or_after_it_pos)
7990 (back_to_previous_visible_line_start)
7991 (move_it_in_display_line_to, move_it_in_display_line)
7992 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7993 (try_scrolling, redisplay_window, display_line): Use them when
7994 saving a temporary copy of the iterator and restoring it back.
7995 (back_to_previous_visible_line_start, reseat_1)
7996 (init_iterator): Empty the bidi cache "stack".
7997 (move_it_in_display_line_to): If iterator ended up at
7998 EOL, but we never saw any buffer positions smaller than
7999 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8000 motion in bidi-reordered lines.
8001 (move_it_in_display_line_to): Record prev_method and prev_pos
8002 immediately before the call to set_iterator_to_next. Fixes cursor
8003 motion in bidi-reordered lines with stretch glyphs and strings
8004 displayed in margins. (Bug#8133) (Bug#8867)
8005 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8007 (pos_visible_p): Support positions in bidi-reordered lines.
8008 Save and restore bidi cache.
8010 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8011 (bidi_paragraph_info): Delete unused struct.
8012 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8013 (bidi_cache_start): New variable.
8014 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8016 (bidi_cache_fetch_state, bidi_cache_search)
8017 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8018 (bidi_cache_find, bidi_peek_at_next_level)
8019 (bidi_level_of_next_char, bidi_find_other_level_edge)
8020 (bidi_move_to_visually_next): Compare cache index with
8021 bidi_cache_start rather than with zero.
8022 (bidi_fetch_char): Accept new argument STRING; all callers
8023 changed. Support iteration over a string. Support strings with
8024 display properties. Support unibyte strings. Fix the type of
8025 `len' according to what STRING_CHAR_AND_LENGTH expects.
8026 (bidi_paragraph_init, bidi_resolve_explicit_1)
8027 (bidi_resolve_explicit, bidi_resolve_weak)
8028 (bidi_level_of_next_char, bidi_move_to_visually_next):
8029 Support iteration over a string.
8030 (bidi_set_sor_type, bidi_resolve_explicit_1)
8031 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8032 can now be zero (for strings); special values 0 and -1 were
8033 changed to -1 and -2, respectively.
8034 (bidi_char_at_pos): New function.
8035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8036 Call it instead of FETCH_MULTIBYTE_CHAR.
8037 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8038 initialized to valid values.
8039 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8041 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8042 the test for valid cached positions. Fix the logic for looking up
8043 the sentinel state in the cache. GCPRO the Lisp string we are
8045 (bidi_push_it, bidi_pop_it): New functions.
8046 (bidi_initialize): Initialize the bidi cache start stack pointer.
8047 (bidi_cache_ensure_space): New function, refactored from part of
8048 bidi_cache_iterator_state. Don't assume the required size is just
8049 one BIDI_CACHE_CHUNK away.
8050 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8051 (bidi_count_bytes, bidi_char_at_pos): New functions.
8052 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8053 always valid if bidi_cache_idx is valid.
8054 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8055 is valid if it's going to be used.
8056 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8057 (bidi_cache_fetch_state, bidi_cache_search)
8058 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8059 (bidi_cache_iterator_state, bidi_cache_find)
8060 (bidi_find_other_level_edge, bidi_cache_start_stack):
8061 All variables related to cache indices are now EMACS_INT.
8063 * dispextern.h (struct bidi_string_data): New structure.
8064 (struct bidi_it): New member `string'. Make flag members be 1-bit
8065 fields, and put them last in the struct.
8066 (compute_display_string_pos, compute_display_string_end):
8068 (bidi_push_it, bidi_pop_it): Add prototypes.
8069 (struct iterator_stack_entry): New members bidi_p,
8070 paragraph_embedding, and from_disp_prop_p.
8071 (struct it): Member bidi_p is now a bit field 1 bit wide.
8072 (bidi_shelve_cache, bidi_unshelve_cache):
8075 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8076 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8077 and vector-like objects.
8079 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8080 cache around display iteration.
8082 * window.c (Fwindow_end, window_scroll_pixel_based)
8083 (displayed_window_lines, Frecenter): Save and restore the bidi
8084 cache around display iteration.
8086 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8088 * editfns.c (Fdelete_region): Clarify the use of the named
8089 parameters (bug#6788).
8091 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8093 * indent.c (Fvertical_motion): Set and restore w->pointm when
8094 saving and restoring the window's buffer (Bug#9006).
8096 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8098 * editfns.c (Fstring_to_char): Clarify just what is returned
8099 (bug#6576). Text by Eli Zaretskii.
8101 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8103 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8105 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8107 * buffer.c (mmap_find): Fix a typo.
8109 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8111 Fix execution of x selection hooks.
8112 * xselect.c (Qx_lost_selection_functions)
8113 (Qx_sent_selection_functions): New vars.
8114 (syms_of_xselect): DEFSYM them.
8115 (x_handle_selection_request): Pass Qx_sent_selection_functions
8116 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8117 (x_handle_selection_clear,x_clear_frame_selections):
8118 Pass Qx_lost_selection_functions rather than
8119 Vx_lost_selection_functions to Frun_hook_with_args.
8121 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8123 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8124 The old code sometimes used this field without initializing it.
8126 * alloc.c (gc_sweep): Don't read past end of array.
8127 In theory, the old code could also have corrupted Emacs internals,
8128 though it'd be very unlikely.
8130 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8132 * character.c (Fcharacterp): Don't advertise optional ignored
8133 argument. (Bug#4026)
8135 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8137 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8140 * window.c (Fset_window_start): Doc fix (bug#4199).
8141 (Fset_window_hscroll): Ditto.
8143 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8145 Fix minor new problems caught by GCC 4.6.1.
8146 * term.c (init_tty): Remove unused local.
8147 * xsettings.c (store_monospaced_changed): Define this function only
8148 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8151 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8153 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8155 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8157 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8158 are the mini-buffer and the echo area (bug#3320).
8160 * term.c (init_tty): Remove support for supdup, c10 and perq
8161 terminals, which are no longer supported (bug#1482).
8163 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8165 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8167 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8169 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8170 for non-popups (Bug#3642).
8172 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8174 * alloc.c (reset_malloc_hooks): Protoize.
8175 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8176 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8177 * cm.c (losecursor): Likewise.
8178 * data.c (fmod): Likewise.
8179 * dispnew.c (swap_glyphs_in_rows): Likewise.
8180 * emacs.c (memory_warning_signal): Likewise.
8181 * floatfns.c (float_error): Likewise.
8182 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8183 (otf_open, font_otf_capability, generate_otf_features)
8184 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8186 * image.c (pbm_read_file): Likewise.
8187 * indent.c (string_display_width): Likewise.
8188 * intervals.c (check_for_interval, search_for_interval)
8189 (inc_interval_count, count_intervals, root_interval)
8190 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8191 * lread.c (defalias): Likewise.
8192 * ralloc.c (r_alloc_check): Likewise.
8193 * regex.c (set_image_of_range_1, set_image_of_range)
8194 (regex_grow_registers): Likewise.
8195 * sysdep.c (strerror): Likewise.
8196 * termcap.c (valid_filename_p, tprint, main): Likewise.
8197 * tparam.c (main): Likewise.
8198 * unexhp9k800.c (run_time_remap, save_data_space)
8199 (update_file_ptrs, read_header, write_header, calculate_checksum)
8200 (copy_file, copy_rest, display_header): Likewise.
8201 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8203 * xdisp.c (check_it): Likewise.
8204 * xfaces.c (register_color, unregister_color, unregister_colors):
8206 * xfns.c (print_fontset_result): Likewise.
8207 * xrdb.c (member, fatal, main): Likewise.
8209 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8211 Fix minor problems found by static checking (Bug#9031).
8212 * chartab.c (char_table_set_range, map_sub_char_table):
8213 Remove unused locals.
8214 (uniprop_table): Now static.
8215 * composite.c (_work_char): Remove unused static var.
8217 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8219 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8221 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8223 * gtkutil.c (qttip_cb): Remove code without function.
8225 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8227 * w32.c (pthread_sigmask): New stub.
8229 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8231 Use pthread_sigmask, not sigprocmask (Bug#9010).
8232 sigprocmask is portable only for single-threaded applications, and
8233 Emacs can be multi-threaded when it uses GTK.
8234 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8236 * callproc.c (Fcall_process):
8237 * process.c (create_process):
8238 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8239 Use pthread_sigmask, not sigprocmask.
8241 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8243 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8244 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8247 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8249 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8250 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8251 (xg_hide_tooltip): Fix comment.
8253 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8254 in registerServicesMenuSendTypes.
8255 (validRequestorForSendType): Don't check ns_return_types.
8257 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8260 2011-07-08 Jason Rumney <jasonr@gnu.org>
8262 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8263 SH_SHOW for hidden windows (Bug#5482).
8265 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8266 frame struct members of non-existent frames (Bug#6284).
8268 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8270 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8271 variable firstTime not needed on OSX >= 10.6.
8272 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8273 >= 10.5. Use setKnobProportion, setDoubleValue.
8275 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8276 (MAC_OS_X_VERSION_10_5): Define if not defined.
8277 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8278 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8279 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8281 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8282 cString and lossyCString on OSX >= 10.4.
8284 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8285 sizeToFit on OSX >= 10.2.
8287 * nsimage.m (allocInitFromFile): Don't use deprecated method
8288 bestRepresentationForDevice on OSX >= 10.6.
8290 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8293 * emacs.c: Declare unexec_init_emacs_zone.
8295 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8297 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8299 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8300 on svcsMenu (Bug#8842).
8302 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8304 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8306 * nsterm.m (QUTF8_STRING): Declare.
8307 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8308 (validRequestorForSendType): Return type is (id).
8309 Change indexOfObjectIdenticalTo to indexOfObject.
8310 Check if we have local selection before returning self (Bug#8842).
8311 (writeSelectionToPasteboard): Put local selection into paste board
8312 if we have a local selection (Bug#8842).
8313 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8315 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8316 (ns_get_local_selection): Declare.
8318 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8320 * keymap.c (describe_map_tree): Don't insert a double newline at
8321 the end of the buffer (bug#1169) and return whether we inserted
8324 * callint.c (Fcall_interactively): Change "reading args" to
8325 "providing args" to try to clarify what it does (bug#1010).
8327 2011-07-07 Kenichi Handa <handa@m17n.org>
8329 * composite.c (composition_compute_stop_pos): Ignore a static
8330 composition starting before CHARPOS (Bug#8915).
8332 * xdisp.c (handle_composition_prop): Likewise.
8334 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8336 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8339 2011-07-07 Kenichi Handa <handa@m17n.org>
8341 * character.h (unicode_category_t): New enum type.
8343 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8344 (Qchar_code_property_table): New variable.
8345 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8346 (UNIPROP_COMPRESSED_FORM_P): New macros.
8347 (char_table_ascii): Uncompress the compressed values.
8348 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8349 Uncompress the compressed values.
8350 (sub_char_table_ref_and_range): Likewise.
8351 (char_table_ref_and_range): Uncompress the compressed values.
8352 (sub_char_table_set): New arg is_uniprop. Callers changed.
8353 Uncompress the compressed values.
8354 (sub_char_table_set_range): Args changed. Callers changed.
8355 (char_table_set_range): Adjuted for the above change.
8356 (map_sub_char_table): Delete args default_val and parent. Add arg
8357 top. Give decoded values to a Lisp function.
8358 (map_char_table): Adjust for the above change. Give decoded
8359 values to a Lisp function. Gcpro more variables.
8360 (uniprop_table_uncompress)
8361 (uniprop_decode_value_run_length): New functions.
8362 (uniprop_decoder, uniprop_decoder_count): New variables.
8363 (uniprop_get_decoder, uniprop_encode_value_character)
8364 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8366 (uniprop_encoder, uniprop_encoder_count): New variables.
8367 (uniprop_get_encoder, uniprop_table)
8368 (Funicode_property_table_internal, Fget_unicode_property_internal)
8369 (Fput_unicode_property_internal): New functions.
8370 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8371 Sunicode_property_table_internal, Sget_unicode_property_internal,
8372 and Sput_unicode_property_internal. Defvar_lisp
8373 char-code-property-alist.
8375 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8376 Vunicode_category_table.
8378 * font.c (font_range): Adjust for the change of
8379 Vunicode_category_table.
8381 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8383 * m/iris4d.h: Remove file, move contents ...
8384 * s/irix6-5.h: ... here.
8386 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8388 Remove unportable assumption about struct layout (Bug#8884).
8389 * alloc.c (mark_buffer):
8390 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8391 (clone_per_buffer_values): Don't assume that
8392 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8393 This isn't true in general, and it's particularly not true
8394 if Emacs is configured with --with-wide-int.
8395 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8396 New macros, used in the buffer.c change.
8398 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8400 * xsettings.c: Use both GConf and GSettings if both are available.
8401 (store_config_changed_event): Add comment.
8402 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8403 (store_tool_bar_style_changed): New functions.
8404 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8405 (struct xsettings): Move font inside HAVE_XFT.
8406 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8407 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8408 Move inside HAVE_XFT.
8409 (something_changed_gsettingsCB): Rename from something_changedCB.
8410 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8412 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8413 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8414 (something_changed_gconfCB): Rename from something_changedCB.
8415 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8416 (parse_settings): Move check for font inside HAVE_XFT.
8417 (read_settings, apply_xft_settings): Add comment.
8418 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8419 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8420 call store_font_name_changed.
8421 (xft_settings_event): Add comment.
8422 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8423 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8424 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8425 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8426 (xsettings_initialize): Call init_gsettings last.
8427 (xsettings_get_system_font, xsettings_get_system_normal_font):
8430 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8432 Random fixes. E.g., (random) never returned negative values.
8433 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8434 subseconds part to the entropy, as that's a bit more random.
8435 Prefer signed to unsigned, since the signedness doesn't matter and
8436 in general we prefer signed. When given a limit, use a
8437 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8438 latter isn't right if USE_2_TAGS_FOR_INTS.
8439 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8440 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8442 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8444 * textprop.c (text_property_stickiness):
8445 Obey Vtext_property_default_nonsticky.
8446 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8447 * w32fns.c (syms_of_w32fns):
8448 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8450 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8452 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8453 This is more efficient than Ffile_directory_p and avoids a minor race.
8455 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8457 * buffer.c (Foverlay_put): Say what the return value is
8460 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8461 is a directory before asking whether to use the file name
8463 (barf_or_query_if_file_exists): Make the "File is a directory"
8464 error be more correct.
8466 * fns.c (Frequire): Remove the mention of the .gz files, since
8467 that's installation-specific, but keep the mention of
8468 `get-load-suffixes'.
8470 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8472 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8473 Report string overflow if the output is too long.
8475 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8477 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8478 (syms_of_gnutls): Remove duplicate DEFSYM for
8479 Qgnutls_bootprop_verify_hostname_error, an error for
8480 Qgnutls_bootprop_verify_error (which is no longer used).
8482 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8483 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8484 Also (re)move comments that are misplaced or no longer relevant.
8486 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8488 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8490 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8492 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8493 and background color parameters if they have been changed.
8495 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8497 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8499 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8501 * xsettings.c (SYSTEM_FONT): Define only when used.
8502 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8504 * keymap.c (access_keymap_1): Now static.
8506 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8508 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8509 leave any prefix arg for the up event (Bug#1586).
8511 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8513 * lread.c (syms_of_lread): Mention single symbols defined by
8514 `defvar' or `defconst' (bug#7154).
8516 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8517 (Frequire): Mention get-load-suffixes.
8519 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8521 * window.h (window): Remove clone_number slot.
8522 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8524 (make_parent_window, make_window, saved_window)
8525 (Fset_window_configuration, save_window_save): Don't deal with
8527 * buffer.c (Qclone_number): Remove declaration.
8528 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8530 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8532 Add multiple inheritance to keymaps.
8533 * keymap.c (Fmake_composed_keymap): New function.
8534 (Fset_keymap_parent): Simplify.
8535 (fix_submap_inheritance): Remove.
8536 (access_keymap_1): New function extracted from access_keymap to handle
8537 embedded parents and handle lists of maps.
8538 (access_keymap): Use it.
8539 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8540 (Fcopy_keymap): Handle embedded parents.
8541 (Fcommand_remapping, define_as_prefix): Simplify.
8542 (Fkey_binding): Simplify.
8543 (syms_of_keymap): Move minibuffer-local-completion-map,
8544 minibuffer-local-filename-completion-map,
8545 minibuffer-local-must-match-map, and
8546 minibuffer-local-filename-must-match-map to Elisp.
8547 (syms_of_keymap): Defsubr make-composed-keymap.
8548 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8549 (parse_menu_item): Trivial simplification.
8551 2011-07-01 Glenn Morris <rgm@gnu.org>
8553 * Makefile.in (SETTINGS_LIBS): Fix typo.
8555 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8557 * coding.c (Fencode_coding_string): Record the last coding system
8558 used, as the function doc string says (bug#8738).
8560 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8562 * xsettings.c (store_monospaced_changed): Take new font as arg and
8563 check for change against current_mono_font.
8564 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8565 (emacs_settings_constructor, emacs_settings_get_property)
8566 (emacs_settings_set_property, emacs_settings_class_init)
8567 (emacs_settings_init, gsettings_obj): Remove.
8568 (something_changedCB): New function for HAVE_GSETTINGS.
8569 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8570 with value as argument.
8571 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8572 g_settings_new (Bug#8967). Do not create gsettings_obj.
8573 Remove calls to g_settings_bind. Connect something_changedCB to
8576 * xgselect.c: Add defined (HAVE_GSETTINGS).
8577 (xgselect_initialize): Ditto.
8579 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8580 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8583 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8585 * eval.c (struct backtrace): Simplify and port the data structure.
8586 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8587 signed bit field, as this assumption is not portable and it makes
8588 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8589 "char debug_on_exit : 1" as this is not portable either; instead,
8590 use the portable "unsigned int debug_on_exit : 1". Remove unused
8591 member evalargs. Remove obsolete comments about cc bombing out.
8593 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8595 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8596 Let HAVE_GSETTINGS override HAVE_GCONF.
8597 (store_monospaced_changed): New function.
8598 (EMACS_SETTINGS): A new type derived from GObject to handle
8599 GSettings notifications.
8600 (emacs_settings_constructor, emacs_settings_get_property)
8601 (emacs_settings_set_property, emacs_settings_class_init):
8603 (gsettings_client, gsettings_obj): New variables.
8604 (GSETTINGS_SCHEMA): New define.
8605 (something_changedCB): Call store_monospaced_changed.
8606 (init_gsettings): New function.
8607 (xsettings_initialize): Call init_gsettings.
8608 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8611 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8614 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8616 * window.c (resize_root_window, grow_mini_window)
8617 (shrink_mini_window): Rename Qresize_root_window to
8618 Qwindow_resize_root_window and Qresize_root_window_vertically to
8619 Qwindow_resize_root_window_vertically.
8621 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8623 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8625 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8627 * makefile.w32-in: Redesign dependencies so they reflect more
8628 clearly which files are directly included by each source file,
8629 and not through other includes.
8631 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8633 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8634 (sort_overlays, overlay_strings): When an overlay's clone number
8635 matches the window's clone number process the overlay even if
8636 the overlay's window property doesn't match the current window.
8638 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8639 (Fwindow_hchild): Rename to Fwindow_left_child.
8640 (Fwindow_next): Rename to Fwindow_next_sibling.
8641 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8642 (resize_window_check): Rename to window_resize_check.
8643 (resize_window_apply): Rename to window_resize_apply.
8644 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8645 (Fdelete_other_windows_internal, resize_frame_windows)
8646 (Fsplit_window_internal, Fdelete_window_internal)
8647 (grow_mini_window, shrink_mini_window)
8648 (Fresize_mini_window_internal): Fix callers accordingly.
8650 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8652 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8653 (emacs_fixed_set_min_size): Remove.
8654 (emacs_fixed_new): Take frame as argument.
8656 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8657 (_EmacsFixedPrivate): Remove minwidth/height.
8658 Add struct frame *f.
8659 (emacs_fixed_init): Initialize priv->f.
8660 (get_parent_class, emacs_fixed_set_min_size): Remove.
8661 (emacs_fixed_new): Set priv->f to argument.
8662 (emacs_fixed_get_preferred_width)
8663 (emacs_fixed_get_preferred_height): Use min_width/height from
8664 frames size_hint to set minimum and natural (Bug#8919).
8665 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8666 and use min_width/height from frames size_hint to set
8667 min_width/height (Bug#8919).
8669 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8670 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8673 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8675 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8676 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8679 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8681 * process.c (wait_reading_process_output): Bypass select if
8682 waiting for a cell while ignoring keyboard input, and input is
8683 pending. Suggested by Jan Djärv (Bug#8869).
8685 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8687 Use gnulib's dup2 module instead of rolling our own.
8688 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8690 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8692 * dispnew.c (scrolling_window): Before scrolling, turn off a
8693 mouse-highlight in the window being scrolled.
8695 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8697 Move DEFSYM to lisp.h and use everywhere.
8699 * character.h (DEFSYM): Move declaration...
8700 * lisp.h (DEFSYM): ...here.
8706 * w32select.c: Don't include character.h.
8708 * alloc.c (syms_of_alloc):
8709 * buffer.c (syms_of_buffer):
8710 * bytecode.c (syms_of_bytecode):
8711 * callint.c (syms_of_callint):
8712 * casefiddle.c (syms_of_casefiddle):
8713 * casetab.c (init_casetab_once):
8714 * category.c (init_category_once, syms_of_category):
8715 * ccl.c (syms_of_ccl):
8716 * cmds.c (syms_of_cmds):
8717 * composite.c (syms_of_composite):
8718 * dbusbind.c (syms_of_dbusbind):
8719 * dired.c (syms_of_dired):
8720 * dispnew.c (syms_of_display):
8721 * doc.c (syms_of_doc):
8722 * editfns.c (syms_of_editfns):
8723 * emacs.c (syms_of_emacs):
8724 * eval.c (syms_of_eval):
8725 * fileio.c (syms_of_fileio):
8726 * fns.c (syms_of_fns):
8727 * frame.c (syms_of_frame):
8728 * fringe.c (syms_of_fringe):
8729 * insdel.c (syms_of_insdel):
8730 * keymap.c (syms_of_keymap):
8731 * lread.c (init_obarray, syms_of_lread):
8732 * macros.c (syms_of_macros):
8733 * msdos.c (syms_of_msdos):
8734 * print.c (syms_of_print):
8735 * process.c (syms_of_process):
8736 * search.c (syms_of_search):
8737 * sound.c (syms_of_sound):
8738 * syntax.c (init_syntax_once, syms_of_syntax):
8739 * terminal.c (syms_of_terminal):
8740 * textprop.c (syms_of_textprop):
8741 * undo.c (syms_of_undo):
8742 * w32.c (globals_of_w32):
8743 * window.c (syms_of_window):
8744 * xdisp.c (syms_of_xdisp):
8745 * xfaces.c (syms_of_xfaces):
8746 * xfns.c (syms_of_xfns):
8747 * xmenu.c (syms_of_xmenu):
8748 * xsettings.c (syms_of_xsettings):
8749 * xterm.c (syms_of_xterm): Use DEFSYM.
8751 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8753 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8755 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8757 Integer and buffer overflow fixes (Bug#8873).
8759 * print.c (printchar, strout): Check for string overflow.
8760 (PRINTPREPARE, printchar, strout):
8761 Don't set size unless allocation succeeds.
8763 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8764 for sizes. Check for string overflow more accurately.
8765 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8767 * macros.c: Integer and buffer overflow fixes.
8768 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8769 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8770 Use ptrdiff_t, not int, for sizes.
8771 Don't increment bufsize until after realloc succeeds.
8772 Check for size-calculation overflow.
8773 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8775 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8777 * lread.c: Integer overflow fixes.
8778 (read_integer): Radix is now EMACS_INT, not int,
8779 to improve quality of diagnostics for out-of-range radices.
8780 Calculate buffer size correctly for out-of-range radices.
8781 (read1): Check for integer overflow in radices, and in
8782 read-circle numbers.
8783 (read_escape): Avoid int overflow.
8784 (Fload, openp, read_buffer_size, read1)
8785 (substitute_object_recurse, read_vector, read_list, map_obarray):
8786 Use ptrdiff_t, not int, for sizes.
8787 (read1): Use EMACS_INT, not int, for sizes.
8788 Check for size overflow.
8790 * image.c (cache_image): Check for size arithmetic overflow.
8792 * lread.c: Integer overflow issues.
8793 (saved_doc_string_size, saved_doc_string_length)
8794 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8795 Now ptrdiff_t, not int.
8796 (read1): Don't assume doc string length fits in int. Check for
8797 out-of-range doc string lengths.
8798 (read_list): Don't assume file position fits in int.
8799 (read_escape): Check for hex character overflow.
8801 2011-06-22 Leo Liu <sdl.web@gmail.com>
8803 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8804 Move to minibuffer.el.
8806 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8808 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8809 The following patches are for when GLYPH_DEBUG && !XASSERT.
8810 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8811 * dispnew.c (flush_stdout):
8812 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8813 Mark as externally visible.
8814 * dispnew.c (check_window_matrix_pointers): Now static.
8815 * dispnew.c (window_to_frame_vpos):
8816 * xfns.c (unwind_create_frame):
8817 * xterm.c (x_check_font): Remove unused local.
8818 * scroll.c (CHECK_BOUNDS):
8819 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8820 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8821 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8822 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8823 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8825 (debug_method_add): Use va_list and vsprintf rather than relying
8826 on undefined behavior with wrong number of arguments.
8827 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8828 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8829 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8830 since we're not interested in debugging glyphs with old libraries.
8831 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8832 GCC 4.6.0's static checking.
8834 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8836 Integer overflow and signedness fixes (Bug#8873).
8837 A few related buffer overrun fixes, too.
8839 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8841 * dispextern.h (struct face.stipple):
8842 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8843 (x_bitmap_mask, x_allocate_bitmap_record)
8844 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8845 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8846 (x_create_bitmap_from_xpm_data):
8847 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8848 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8850 * xfaces.c (load_pixmap):
8851 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8852 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8853 (.bitmaps_last, struct x_output.icon_bitmap):
8854 Use ptrdiff_t, not int, for bitmap indexes.
8855 (x_allocate_bitmap_record): Check for size overflow.
8856 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8858 Use ptrdiff_t, not int, for overlay counts.
8859 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8860 * editfns.c (overlays_around, get_pos_property):
8861 * textprop.c (get_char_property_and_overlay):
8862 * xdisp.c (next_overlay_change, note_mouse_highlight):
8863 * xfaces.c (face_at_buffer_position):
8864 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8865 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8866 (Fnext_overlay_change, Fprevious_overlay_change)
8867 (mouse_face_overlay_overlaps, Foverlays_in):
8868 Use ptrdiff_t, not int, for sizes.
8869 (overlays_at, overlays_in): Check for size-calculation overflow.
8871 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8873 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8874 (x_session_initialize): Do not assume string length fits in int.
8876 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8877 This is unlikely, but can occur if DPI is outlandish.
8879 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8880 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8882 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8883 * xrdb.c (magic_file_p, search_magic_path):
8884 Omit last arg SUFFIX; it was always 0. All callers changed.
8885 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8887 * xfont.c (xfont_match): Avoid need for strlen.
8889 * xfns.c: Don't assume strlen fits in int.
8890 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8892 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8893 not unsigned long, as we prefer signed integers. All callers changed.
8894 Detect integer overflow in repeat count.
8895 (message_dolog): Don't assume print length fits in 39 bytes.
8896 (display_mode_element): Don't assume strlen fits in int.
8898 * termcap.c: Don't assume sizes fit in int and never overflow.
8899 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8900 (gobble_line): Check for size-calculation overflow.
8902 * minibuf.c (Fread_buffer):
8903 * lread.c (intern, intern_c_string):
8904 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8905 Don't assume string length fits in int.
8907 * keyboard.c (parse_tool_bar_item):
8908 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8910 * font.c: Don't assume string length fits in int.
8911 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8912 Use ptrdiff_t, not int.
8913 (font_intern_prop): Don't assume string length fits in int.
8914 Don't assume integer property fits in fixnum.
8915 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8917 * filelock.c: Fix some buffer overrun and integer overflow issues.
8918 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8919 Reformulate so as not to need the command string.
8920 Invoke gzip -cd rather than gunzip, as it's more portable.
8921 (lock_info_type, lock_file_1, lock_file):
8922 Don't assume pid_t and time_t fit in unsigned long.
8923 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8924 (current_lock_owner): Prefer signed type for sizes.
8925 Use memcpy, not strncpy, where memcpy is what is really wanted.
8926 Don't assume (via atoi) that time_t and pid_t fit in int.
8927 Check for time_t and/or pid_t out of range, e.g., via a network share.
8928 Don't alloca where an auto var works fine.
8930 * fileio.c: Fix some integer overflow issues.
8931 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8932 Don't assume string length fits in int.
8933 (directory_file_name): Don't assume string length fits in long.
8934 (make_temp_name): Don't assume pid fits in int, or that its print
8935 length is less than 20.
8937 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8939 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8941 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8943 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8944 We prefer signed integers, even for size calculations.
8946 * emacs.c: Don't assume string length fits in 'int'.
8947 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8948 (main): Don't invoke strlen when not needed.
8950 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8951 (XD_DEBUG_MESSAGE): Don't waste a byte.
8953 * callproc.c (getenv_internal_1, getenv_internal)
8955 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8957 * lread.c (invalid_syntax): Omit length argument.
8958 All uses changed. This doesn't fix a bug, but it simplifies the
8959 code away from its former Hollerith-constant appearance, and it's
8960 one less 'int' to worry about when looking at integer-overflow issues.
8961 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8963 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8964 This didn't break anything, but it didn't help either.
8965 It's confusing to put a bogus integer in a place where the actual
8966 value does not matter.
8967 (LIST_END_P): Remove unused macro and its bogus comment.
8968 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8970 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8971 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8973 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8974 We prefer signed types, and the value cannot exceed the EMACS_INT
8975 range anyway (because otherwise the length would not be representable).
8976 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8977 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8978 This avoids a GCC warning when WIDE_EMACS_INT.
8980 * indent.c (sane_tab_width): New function.
8981 (current_column, scan_for_column, Findent_to, position_indentation)
8982 (compute_motion): Use it. This is just for clarity.
8983 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8985 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8987 * lisp.h (lint_assume): New macro.
8988 * composite.c (composition_gstring_put_cache):
8989 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8991 * editfns.c, insdel.c:
8992 Omit unnecessary forward decls, to simplify future changes.
8994 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8996 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8998 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8999 Use much-faster test for byte-length change.
9000 Don't assume string byte-length fits in 'int'.
9001 Check that character arg fits in 'int'.
9002 (mapcar1): Declare byte as byte, for clarity.
9004 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9006 * fns.c (concat): Catch string overflow earlier.
9007 Do not rely on integer wraparound.
9009 * dispextern.h (struct it.overlay_strings_charpos)
9010 (struct it.selective): Now EMACS_INT, not int.
9011 * xdisp.c (forward_to_next_line_start)
9012 (back_to_previous_visible_line_start)
9013 (reseat_at_next_visible_line_start, next_element_from_buffer):
9014 Don't arbitrarily truncate the value of 'selective' to int.
9016 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9018 * composite.c: Don't truncate sizes to 'int'.
9019 (composition_gstring_p, composition_reseat_it)
9020 (composition_adjust_point): Use EMACS_INT, not int.
9021 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9022 not EMACS_UINT, for indexes.
9024 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9026 * buffer.c: Include <verify.h>.
9027 (struct sortvec.priority, struct sortstr.priority):
9028 Now EMACS_INT, not int.
9029 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9030 (struct sortstr.size, record_overlay_string)
9031 (struct sortstrlist.size, struct sortlist.used):
9032 Don't truncate size to int.
9033 (record_overlay_string): Check for size-calculation overflow.
9034 (init_buffer_once): Check at compile-time, not run-time.
9036 2011-06-22 Jim Meyering <meyering@redhat.com>
9038 Don't leak an XBM-image-sized buffer
9039 * image.c (xbm_load): Free the image buffer after using it.
9041 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9044 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9045 that Sun C diagnosed.
9046 * fns.c (secure_hash): Fix pointer signedness issue.
9047 * intervals.c (static_offset_intervals): New function.
9048 (offset_intervals): Use it.
9050 2011-06-21 Leo Liu <sdl.web@gmail.com>
9053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9056 * fns.c (secure_hash): Rename from crypto_hash_function and change
9057 the first arg to accept symbols.
9058 (Fsecure_hash): New primitive.
9059 (syms_of_fns): New symbols.
9061 2011-06-20 Deniz Dogan <deniz@dogan.se>
9063 * process.c (Fset_process_buffer): Clarify return value in
9066 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9068 * dispnew.c (add_window_display_history): Use BVAR.
9070 * xdisp.c (debug_method_add): Use BVAR.
9071 (check_window_end, dump_glyph_matrix, dump_glyph)
9072 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9074 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9077 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9078 check till after the cache is created in init_frame_faces.
9080 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9082 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9084 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9086 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9087 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9088 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9090 Improve buffer-overflow checking (Bug#8873).
9091 * fileio.c (Finsert_file_contents):
9092 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9093 Remove the old (too-loose) buffer overflow checks.
9094 They weren't needed, since make_gap checks for buffer overflow.
9095 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9096 The old code merely checked for Emacs fixnum overflow, and relied
9097 on undefined (wraparound) behavior. The new code avoids undefined
9098 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9100 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9101 Tune. Don't use wider integers than needed. Don't use alloca.
9102 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9104 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9106 * insdel.c, lisp.h (buffer_overflow): New function.
9107 (insert_from_buffer_1, replace_range, replace_range_2):
9108 * insdel.c (make_gap_larger):
9109 * editfns.c (Finsert_char):
9110 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9112 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9114 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9116 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9118 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9119 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9121 * fileio.c: Don't assume EMACS_INT fits in off_t.
9122 (emacs_lseek): New static function.
9123 (Finsert_file_contents, Fwrite_region): Use it.
9124 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9126 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9128 * fns.c: Don't overflow int when computing a list length.
9129 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9130 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9131 truncation on 64-bit hosts. Check for QUIT every
9132 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9133 faster and is responsive enough.
9134 (Flength): Report an error instead of overflowing an integer.
9135 (Fsafe_length): Return a float if the value is not representable
9136 as a fixnum. This shouldn't happen except in contrived situations.
9137 (Fnthcdr, Fsort): Don't assume list length fits in int.
9138 (Fcopy_sequence): Don't assume vector length fits in int.
9140 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9141 (header_size, word_size): New constants.
9142 (allocate_vectorlike): Don't check size overflow here.
9143 (allocate_vector): Check it here instead, since this is the only
9144 caller of allocate_vectorlike that could cause overflow.
9145 Check that the new vector's length is representable as a fixnum.
9147 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9148 The previous code was bogus. For example, next_almost_prime (32)
9149 returned 39, which is undesirable as it is a multiple of 3; and
9150 next_almost_prime (24) returned 25, which is a multiple of 5 so
9151 why was the code bothering to check for multiples of 7?
9153 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9155 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9157 Variadic C functions now count arguments with ptrdiff_t.
9158 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9159 Back then I didn't know that the Emacs coding style prefers signed int.
9160 Also, in the meantime I found a few more instances where arguments
9161 were being counted with int, which may truncate counts on 64-bit
9162 machines, or EMACS_INT, which may be unnecessarily wide.
9163 * lisp.h (struct Lisp_Subr.function.aMANY)
9164 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9165 Arg counts are now ptrdiff_t, not size_t.
9166 All variadic functions and their callers changed accordingly.
9167 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9168 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9169 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9170 * callint.c (Fcall_interactively): Check arg count for overflow,
9171 to avoid potential buffer overrun. Use signed char, not 'int',
9172 for 'varies' array, so that we needn't bother to check its size
9173 calculation for overflow.
9174 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9175 * eval.c (apply_lambda):
9176 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9177 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9178 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9180 * callint.c (Fcall_interactively): Don't use index var as event count.
9182 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9183 * mem-limits.h (SIZE): Remove; no longer used.
9185 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9187 Remove unnecessary casts.
9188 * xterm.c (x_term_init):
9189 * xfns.c (x_set_border_pixel):
9190 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9191 These aren't needed now that we assume ANSI C.
9193 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9194 It's more likely to cause problems (due to unsigned overflow)
9197 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9199 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9201 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9203 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9205 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9207 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9209 GLYPH_CODE_FACE returns EMACS_INT, not int.
9210 * dispextern.h (merge_faces):
9211 * xfaces.c (merge_faces):
9212 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9213 Don't assume EMACS_INT fits in int.
9215 * character.h (CHAR_VALID_P): Remove unused parameter.
9216 * fontset.c, lisp.h, xdisp.c: All uses changed.
9218 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9220 * fns.c (concat): Minor tuning based on overflow analysis.
9221 This doesn't fix any bugs. Use int to hold character, instead
9222 of constantly refetching from Emacs object. Use XFASTINT, not
9223 XINT, for value known to be a character. Don't bother comparing
9224 a single byte to 0400, as it's always less.
9226 * floatfns.c (Fexpt):
9227 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9229 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9232 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9234 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9235 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9236 incorrectly succeed when S was a string, because 4294967386 was
9237 truncated before it was used.
9239 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9240 Otherwise, an out-of-range integer could cause undefined behavior
9243 * composite.c: Use int, not EMACS_INT, for characters.
9244 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9245 EMACS_INT, for values that are known to be in character range.
9246 This doesn't fix any bugs but is the usual style inside Emacs and
9247 may generate better code on 32-bit machines.
9249 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9250 This is for reasons similar to the recent CHAR_STRING fix.
9251 * charset.c (Fencode_char): Check that character arg is actually
9252 a character. Pass an int to ENCODE_CHAR.
9253 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9254 wider than 'int', as a compile-time check to prevent future regressions
9257 * character.c (char_string): Remove unnecessary casts.
9259 Make sure a 64-bit char is never passed to CHAR_STRING.
9260 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9261 by silently ignoring the top 32 bits, allowing some values
9262 that were far too large to be valid characters.
9263 * character.h: Include <verify.h>.
9264 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9265 arguments are no wider than unsigned, as a compile-time check
9266 to prevent future regressions in this area.
9268 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9269 (Fsubst_char_in_region):
9271 * xdisp.c (decode_mode_spec_coding):
9272 Adjust to CHAR_STRING's new requirement.
9273 * editfns.c (Finsert_char, Fsubst_char_in_region):
9274 * fns.c (concat): Check that character args are actually
9275 characters. Without this test, these functions did the wrong
9276 thing with wildly out-of-range values on 64-bit hosts.
9278 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9279 These casts should not be needed on 32-bit hosts, either.
9280 * keyboard.c (read_char):
9281 * lread.c (Fload): Remove casts to unsigned.
9283 * lisp.h (UNSIGNED_CMP): New macro.
9284 This fixes comparison bugs on 64-bit hosts.
9285 (ASCII_CHAR_P): Use it.
9286 * casefiddle.c (casify_object):
9287 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9288 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9289 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9290 * dispextern.h (FACE_FROM_ID):
9291 * keyboard.c (read_char): Use UNSIGNED_CMP.
9293 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9294 not to EMACS_INT, to avoid GCC warning.
9296 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9298 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9299 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9300 isn't needed on 32-bit machines.
9302 * buffer.c (Fgenerate_new_buffer_name):
9303 Use EMACS_INT for count, not int.
9304 (advance_to_char_boundary): Return EMACS_INT, not int.
9306 * data.c (Qcompiled_function): Now static.
9308 * window.c (window_body_lines): Now static.
9310 * image.c (gif_load): Rename local to avoid shadowing.
9312 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9313 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9314 * alloc.c (make_save_value): Integer argument is now of type
9316 (mark_object): Use ptrdiff_t, not int.
9317 * lisp.h (pD): New macro.
9318 * print.c (print_object): Use it.
9320 * alloc.c: Use EMACS_INT, not int, to count objects.
9321 (total_conses, total_markers, total_symbols, total_vector_size)
9322 (total_free_conses, total_free_markers, total_free_symbols)
9323 (total_free_floats, total_floats, total_free_intervals)
9324 (total_intervals, total_strings, total_free_strings):
9325 Now EMACS_INT, not int. All uses changed.
9326 (Fgarbage_collect): Compute overall total using a double, so that
9327 integer overflow is less likely to be a problem. Check for overflow
9328 when converting back to an integer.
9329 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9330 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9331 These were 'int' variables that could overflow on 64-bit hosts;
9332 they were never used, so remove them instead of repairing them.
9333 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9334 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9335 Previously, this ceilinged at INT_MAX, but that doesn't work on
9337 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9339 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9340 (allocate_vectorlike): Check for ptrdiff_t overflow.
9341 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9342 when a (possibly-narrower) signed value would do just as well.
9343 We prefer using signed arithmetic, to avoid comparison confusion.
9345 * alloc.c: Catch some string size overflows that we were missing.
9346 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9347 for convenience in STRING_BYTES_MAX.
9348 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9349 The definition here is exact; the one in lisp.h was approximate.
9350 (allocate_string_data): Check for string overflow. This catches
9351 some instances we weren't catching before. Also, it catches
9352 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9353 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9354 and ptrdiff_t and EMACS_INT are both 64 bits.
9356 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9357 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9358 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9360 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9362 * alloc.c (Fmake_string): Check for out-of-range init.
9364 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9366 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9368 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9370 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9371 xg_get_default_scrollbar_width.
9373 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9374 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9375 (style_changed_cb): Call update_theme_scrollbar_width and call
9376 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9377 all frames (Bug#8505).
9378 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9379 Call gtk_window_set_resizable if HAVE_GTK3.
9380 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9381 and height if HAVE_GTK3 (Bug#8505).
9382 (scroll_bar_width_for_theme): New variable.
9383 (update_theme_scrollbar_width): New function.
9384 (xg_get_default_scrollbar_width): Move code to
9385 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9386 (xg_initialize): Call update_theme_scrollbar_width.
9388 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9390 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9392 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9394 * frame.c (make_frame): Call other_buffer_safely instead of
9397 * window.c (temp_output_buffer_show): Call display_buffer with
9398 second argument Vtemp_buffer_show_specifiers and reset latter
9399 immediately after the call.
9400 (Vtemp_buffer_show_specifiers): New variable.
9401 (auto_window_vscroll_p, next_screen_context_lines)
9402 (Vscroll_preserve_screen_position): Remove leading asterisks from
9405 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9407 Fix minor problems found by GCC 4.6.0 static checking.
9408 * buffer.c (Qclone_number): Remove for now, as it's unused.
9409 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9410 (record_buffer): Remove unused local.
9411 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9412 (set_frame_buffer_list): Remove; unused.
9413 * frame.h (other_visible_frames): Remove decl.
9414 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9415 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9416 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9418 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9419 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9420 Define only if HAVE_GPM.
9421 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9422 (update_hints_inhibit): Remove; never set. All uses removed.
9423 * widgetprv.h (emacsFrameClassRec): Remove decl.
9424 * window.c (delete_deletable_window): Now returns void, since it
9425 wasn't returning anything.
9426 (compare_window_configurations): Remove unused locals.
9427 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9428 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9429 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9430 the same widths as pointers. This follows up on the 2011-05-06 patch.
9431 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9432 * xterm.h: Likewise.
9433 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9435 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9437 * makefile.w32-in: Update dependencies.
9438 (LISP_H): Add lib/intprops.h.
9440 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9442 * image.c (gif_load): Add animation frame delay to the metadata.
9443 (syms_of_image): Use DEFSYM. New symbol `delay'.
9445 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9447 * window.c (delete_deletable_window): Re-add.
9448 (Fset_window_configuration): Rewrite to handle dead buffers and
9449 consequently deletable windows.
9450 (window_tree, Fwindow_tree): Remove. Supply functionality in
9452 (compare_window_configurations): Simplify code.
9454 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9456 * image.c (imagemagick_load_image): Fix type mismatch.
9457 (Fimagemagick_types): Likewise.
9459 * window.h (replace_buffer_in_windows): Declare.
9461 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9463 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9464 Qclone_number. Remove external declaration of Qdelete_window.
9465 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9467 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9468 Run Qbuffer_list_update_hook if allowed.
9469 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9470 buffer list implementation.
9471 (other_buffer_safely): New function.
9472 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9473 calls to replace_buffer_in_windows and
9474 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9476 (record_buffer): Inhibit quitting and rewrite using quittable
9477 functions. Run Qbuffer_list_update_hook if allowed.
9478 (Frecord_buffer, Funrecord_buffer): New functions.
9479 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9480 Move switch-to-buffer to window.el.
9481 (bury-buffer): Move to window.el.
9482 (Vbuffer_list_update_hook): New variable.
9484 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9487 * window.h (resize_frame_windows): Move up in code.
9488 (Fwindow_frame): Remove EXFUN.
9489 (replace_buffer_in_all_windows): Remove prototype.
9490 (replace_buffer_in_windows_safely): Add prototype.
9492 * window.c: Declare Qdelete_window static again. Move down
9493 declaration of select_count.
9494 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9495 (Fother_window): Move to window.el.
9496 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9497 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9498 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9500 (replace_buffer_in_windows): Implement by calling
9501 Qreplace_buffer_in_windows.
9502 (replace_buffer_in_all_windows): Remove with some functionality
9503 moved into replace_buffer_in_windows_safely.
9504 (replace_buffer_in_windows_safely): New function.
9505 (select_window_norecord, select_frame_norecord): Move in front
9506 of run_window_configuration_change_hook. Remove now obsolete
9508 (Fset_window_buffer): Rewrite doc-string.
9509 Call Qrecord_window_buffer.
9510 (keys_of_window): Move binding for other-window to window.el.
9512 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9514 * dispextern.h (struct image): Replace data member, whose int_val
9515 and ptr_val fields were not used by anything, with a single
9518 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9519 (gif_clear_image, gif_load, imagemagick_load_image)
9520 (gs_clear_image, gs_load): Callers changed.
9522 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9524 * buffer.h: Include <time.h>, for time_t.
9525 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9527 Fix minor problems found by static checking.
9529 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9531 Make identifiers static if they are not used in other modules.
9532 * data.c (Qcompiled_function, Qframe, Qvector):
9533 * image.c (QimageMagick, Qsvg):
9534 * minibuf.c (Qmetadata):
9535 * window.c (resize_window_check, resize_root_window): Now static.
9536 * window.h (resize_window_check, resize_root_window): Remove decls.
9538 * window.c (window_deletion_count, delete_deletable_window):
9540 (window_body_lines): Now static.
9541 (Fdelete_other_windows_internal): Mark vars as initialized.
9542 Make sure 'resize_failed' is initialized.
9543 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9544 (resize_window_apply): Remove unused local.
9545 * window.h (delete_deletable_window): Remove decl.
9547 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9548 (imagemagick_load_image): Fix pointer signedness problem by changing
9549 last arg from unsigned char * to char *. All uses changed.
9550 Also, fix a local for similar reasons.
9551 Remove unused locals. Remove locals to avoid shadowing.
9552 (fn_rsvg_handle_free): Remove; unused.
9553 (svg_load, svg_load_image): Fix pointer signedness problem.
9554 (imagemagick_load_image): Don't use garbage pointer image_wand.
9556 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9558 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9560 * image.c (gif_load): Fix omitted cast error introduced by
9563 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9565 * window.h (resize_proportionally, orig_total_lines)
9566 (orig_top_line): Remove from window structure.
9567 (set_window_height, set_window_width, change_window_heights)
9568 (Fdelete_window): Remove prototypes.
9569 (resize_frame_windows): Remove duplicate declaration.
9571 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9573 * window.h (resize_frame_windows, resize_window_check)
9574 (delete_deletable_window, resize_root_window)
9575 (resize_frame_windows): Declare prototypes.
9577 * window.c (resize_window_apply): Make definition be "static" to
9578 match the prototype.
9580 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9582 * window.c: Remove declarations of Qwindow_size_fixed,
9583 window_min_size_1, window_min_size_2, window_min_size,
9584 size_window, window_fixed_size_p, enlarge_window, delete_window.
9585 Remove static from declaration of Qdelete_window, it's
9586 temporarily needed by Fbury_buffer.
9587 (replace_window): Don't assign orig_top_line and
9589 (Fdelete_window, delete_window): Remove. Window deletion is
9590 handled by window.el.
9591 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9592 Replace Fdelete_window calls with calls to Qdelete_window.
9593 (Fdelete_other_windows): Remove. Deleting other windows is
9594 handled by window.el.
9595 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9596 handled in window.el.
9597 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9598 Window minimum sizes are handled in window.el.
9599 (shrink_windows, size_window, set_window_height)
9600 (set_window_width, change_window_heights, window_height)
9601 (window_width, CURBEG, CURSIZE, enlarge_window)
9602 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9603 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9604 handled in window.el.
9605 (make_dummy_parent): Rename to make_parent_window and give it a
9606 second argument horflag.
9607 (make_window): Don't set resize_proportionally any more.
9608 (Fsplit_window): Remove. Windows are split in window.el.
9609 (save_restore_action, save_restore_orig_size)
9610 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9611 Resize mini windows in window.el.
9612 (grow_mini_window, shrink_mini_window): Implement by calling
9613 Qresize_root_window_vertically, resize_window_check and
9614 resize_window_apply.
9615 (saved_window, Fset_window_configuration, save_window_save):
9616 Do not handle orig_top_line, orig_total_lines, and
9617 resize_proportionally.
9618 (window_min_height, window_min_width): Move to window.el.
9619 (keys_of_window): Move bindings for delete-other-windows,
9620 split-window, delete-window and enlarge-window to window.el.
9622 * buffer.c: Temporarily extern Qdelete_window.
9623 (Fbury_buffer): Temporarily call Qdelete_window instead of
9624 Fdelete_window (Fbury_buffer will move to window.el soon).
9626 * frame.c (set_menu_bar_lines_1): Remove code handling
9627 orig_top_line and orig_total_lines.
9629 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9630 set_window_height but set heights directly.
9631 (change_frame_size_1): Use resize_frame_windows.
9633 * xdisp.c (init_xdisp): Don't use set_window_height but set
9636 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9637 Use resize_frame_windows instead of change_window_heights and run
9638 run_window_configuration_change_hook.
9640 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9641 instead of change_window_heights and run
9642 run_window_configuration_change_hook.
9644 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9646 * window.c (replace_window): Rename second argument REPLACEMENT to
9647 NEW. New third argument SETFLAG. Rewrite.
9648 (delete_window, make_dummy_parent): Call replace_window with
9650 (window_list_1): Move down in code.
9651 (run_window_configuration_change_hook): Move set_buffer part
9652 before select_frame_norecord part in order to unwind correctly.
9653 Rename count1 to count.
9654 (recombine_windows, delete_deletable_window, resize_root_window)
9655 (Fdelete_other_windows_internal)
9656 (Frun_window_configuration_change_hook, make_parent_window)
9657 (resize_window_check, resize_window_apply, Fresize_window_apply)
9658 (resize_frame_windows, Fsplit_window_internal)
9659 (Fdelete_window_internal, Fresize_mini_window_internal):
9661 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9663 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9665 * window.h (window): Add some new members to window structure -
9666 normal_lines, normal_cols, new_total, new_normal, clone_number,
9667 splits, nest, prev_buffers, next_buffers.
9668 (WINDOW_TOTAL_SIZE): Move here from window.c.
9669 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9671 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9673 (make_dummy_parent): Set new members of windows structure.
9674 (make_window): Move down in code. Handle new members of window
9676 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9677 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9678 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9679 (Fset_window_prev_buffers, Fwindow_next_buffers)
9680 (Fset_window_next_buffers, Fset_window_clone_number):
9682 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9683 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9685 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9686 Argument WINDOW can be now internal window too.
9687 (Fwindow_use_time): Move up in code.
9688 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9690 (Fset_window_configuration, saved_window)
9691 (Fcurrent_window_configuration, save_window_save): Handle new
9692 members of window structure.
9693 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9694 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9695 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9696 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9697 Qget_mru_window, Qresize_root_window,
9698 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9699 Qauto_buffer_name; staticpro them.
9701 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9703 * window.c (Fwindow_total_size, Fwindow_left_column)
9704 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9705 (Fwindow_list_1): New functions.
9706 (window_box_text_cols): Replace with window_body_cols.
9707 (Fwindow_width, Fscroll_left, Fscroll_right):
9708 Use window_body_cols instead of window_box_text_cols.
9709 (delete_window, Fset_window_configuration):
9710 Call delete_all_subwindows with window as argument.
9711 (delete_all_subwindows): Take a window as argument and not a
9713 (window_loop): Remove handling of GET_LRU_WINDOW and
9715 (Fget_lru_window, Fget_largest_window): Move to window.el.
9717 * window.h: Extern window_body_cols instead of
9718 window_box_text_cols. delete_all_subwindows now takes a
9719 Lisp_Object as argument.
9721 * indent.c (compute_motion, Fcompute_motion):
9722 Use window_body_cols instead of window_box_text_cols.
9724 * frame.c (delete_frame): Call delete_all_subwindows with root
9727 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9729 * fns.c (Fputhash): Document return value.
9731 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9733 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9735 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9737 Cons<->int and similar integer overflow fixes (Bug#8794).
9739 Check for overflow when converting integer to cons and back.
9740 * charset.c (Fdefine_charset_internal, Fdecode_char):
9741 Use cons_to_unsigned to catch overflow.
9742 (Fencode_char): Use INTEGER_TO_CONS.
9743 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9744 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9745 * data.c (long_to_cons, cons_to_long): Remove.
9746 (cons_to_unsigned, cons_to_signed): New functions.
9747 These signal an error for invalid or out-of-range values.
9748 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9749 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9750 * font.c (Ffont_variation_glyphs):
9751 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9752 * lisp.h: Include <intprops.h>.
9753 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9754 (cons_to_signed, cons_to_unsigned): New decls.
9755 (long_to_cons, cons_to_long): Remove decls.
9756 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9757 (Fprimitive_undo): Use CONS_TO_INTEGER.
9758 * xfns.c (Fx_window_property): Likewise.
9759 * xselect.c: Include <limits.h>.
9760 (x_own_selection, selection_data_to_lisp_data):
9761 Use INTEGER_TO_CONS.
9762 (x_handle_selection_request, x_handle_selection_clear)
9763 (x_get_foreign_selection, Fx_disown_selection_internal)
9764 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9765 (lisp_data_to_selection_data): Use cons_to_unsigned.
9766 (x_fill_property_data): Use cons_to_signed.
9767 Report values out of range.
9769 Check for buffer and string overflow more precisely.
9770 * buffer.h (BUF_BYTES_MAX): New macro.
9771 * lisp.h (STRING_BYTES_MAX): New macro.
9772 * alloc.c (Fmake_string):
9773 * character.c (string_escape_byte8):
9774 * coding.c (coding_alloc_by_realloc):
9775 * doprnt.c (doprnt):
9776 * editfns.c (Fformat):
9778 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9779 since they may not be the same number.
9780 * editfns.c (Finsert_char):
9781 * fileio.c (Finsert_file_contents):
9782 Likewise for BUF_BYTES_MAX.
9784 * image.c: Use ptrdiff_t, not int, for sizes.
9785 (slurp_file): Switch from int to ptrdiff_t.
9787 (slurp_file): Check that file size fits in both size_t (for
9788 malloc) and ptrdiff_t (for sanity and safety).
9790 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9791 if b->modtime has its maximal value.
9793 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9795 Don't assume time_t can fit into int.
9796 * buffer.h (struct buffer.modtime): Now time_t, not int.
9797 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9798 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9800 Minor fixes for signed vs unsigned integers.
9801 * character.h (MAYBE_UNIFY_CHAR):
9802 * charset.c (maybe_unify_char):
9803 * keyboard.c (read_char, reorder_modifiers):
9804 XINT -> XFASTINT, since the integer must be nonnegative.
9805 * ftfont.c (ftfont_spec_pattern):
9806 * keymap.c (access_keymap, silly_event_symbol_error):
9807 XUINT -> XFASTINT, since the integer must be nonnegative.
9808 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9809 since it makes no difference and we prefer signed.
9810 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9811 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9814 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9816 * window.h (Fwindow_frame): Declare.
9818 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9820 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9821 (SPARE_MEMORY): Always define.
9822 (LARGE_REQUEST): Remove.
9823 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9825 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9827 * lisp.h: Move EXFUNS for Fframe_root_window,
9828 Fframe_first_window and Fset_frame_selected_window to window.h.
9830 * window.h: Move EXFUNS for Fframe_root_window,
9831 Fframe_first_window and Fset_frame_selected_window here from
9834 * frame.c (Fwindow_frame, Fframe_first_window)
9835 (Fframe_root_window, Fframe_selected_window)
9836 (Fset_frame_selected_window): Move to window.c.
9837 (Factive_minibuffer_window): Move to minibuf.c.
9838 (Fother_visible_frames_p): New function.
9840 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9842 * window.c (decode_window, decode_any_window): Move up in code.
9843 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9844 (inhibit_frame_unsplittable): Remove unused variable.
9845 (Fwindow_buffer): Move up and rewrite doc-string.
9846 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9847 (Fwindow_prev): New functions.
9848 (Fwindow_frame): Move here from frame.c. Accept any window as
9850 (Fframe_root_window, Fframe_first_window)
9851 (Fframe_selected_window): Move here from frame.c. Accept frame
9852 or arbitrary window as argument. Update doc-strings.
9853 (Fminibuffer_window): Move up in code.
9854 (Fwindow_minibuffer_p): Move up in code and simplify.
9855 (Fset_frame_selected_window): Move here from frame.c.
9857 (Fselected_window, select_window, Fselect_window): Move up in
9858 code. Minor doc-string fixes.
9860 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9862 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9863 Do not assume that spare memory exists; that assumption is valid
9864 only if SYSTEM_MALLOC.
9865 (LARGE_REQUEST): New macro, so that the issue of large requests
9866 is separated from the issue of spare memory.
9868 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9870 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9873 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9875 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9878 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9880 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9882 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9884 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9885 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9887 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9889 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9891 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9893 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9894 (x_clipboard_manager_save): Add return value.
9895 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9897 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9898 Obey Vx_select_enable_clipboard_manager. Catch errors in
9899 x_clipboard_manager_save (Bug#8779).
9900 (Vx_select_enable_clipboard_manager): New variable.
9901 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9903 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9905 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9907 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9909 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9910 in the current matrix if keep_current_p is non-zero.
9912 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9914 * bidi.c (bidi_level_of_next_char): Fix last change.
9916 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9918 Support bidi reordering of text covered by display properties.
9920 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9921 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9922 (bidi_cache_search, bidi_cache_iterator_state)
9923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9924 (bidi_level_of_next_char, bidi_move_to_visually_next):
9925 Support character positions inside a run of characters covered by a
9927 (bidi_paragraph_init, bidi_resolve_explicit_1)
9928 (bidi_level_of_next_char): Call bidi_fetch_char and
9929 bidi_fetch_char_advance instead of FETCH_CHAR and
9931 (bidi_init_it): Initialize new members.
9932 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9934 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9935 instead of using explicit *_CHAR codes.
9936 (bidi_resolve_explicit, bidi_resolve_weak):
9937 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9938 bidirectional text is supported only in multibyte buffers.
9939 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9940 it to initialize the frame_window_p member of struct bidi_it.
9941 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9942 (bidi_resolve_explicit, bidi_resolve_weak)
9943 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9944 bidi_it->nchars is non-positive.
9945 (bidi_level_of_next_char): Don't try to lookup the cache for the
9946 next/previous character if nothing is cached there yet, or if we
9947 were just reseat()'ed to a new position.
9949 * xdisp.c (set_cursor_from_row): Set start and stop points
9950 according to the row's direction when priming the loop that looks
9951 for the glyph on which to display cursor.
9952 (single_display_spec_intangible_p): Function deleted.
9953 (display_prop_intangible_p): Reimplement to call
9954 handle_display_spec instead of single_display_spec_intangible_p.
9955 Accept 3 additional arguments needed by handle_display_spec.
9956 This fixes incorrect cursor motion across display property with complex
9957 values: lists, `(when COND...)' forms, etc.
9958 (single_display_spec_string_p): Support property values that are
9959 lists with the argument STRING its top-level element.
9960 (display_prop_string_p): Fix the condition for processing a
9961 property that is a list to be consistent with handle_display_spec.
9962 (handle_display_spec): New function, refactored from the
9963 last portion of handle_display_prop.
9964 (compute_display_string_pos): Accept additional argument
9965 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9966 value of a `display' property is a "replacing spec".
9967 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9968 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9969 the display property, but just return a value indicating whether
9970 the display property will replace the characters it covers.
9971 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9972 frame_window_p members of struct bidi_it.
9973 (compute_display_string_pos, compute_display_string_end):
9975 (push_it): Accept second argument POSITION, where pop_it should
9976 jump to continue iteration.
9977 (reseat_1): Initialize bidi_it.disp_pos.
9979 * keyboard.c (adjust_point_for_property): Adjust the call to
9980 display_prop_intangible_p to its new signature.
9982 * dispextern.h (struct bidi_it): New member frame_window_p.
9983 (bidi_init_it): Update prototypes.
9984 (display_prop_intangible_p): Update prototype.
9985 (compute_display_string_pos, compute_display_string_end):
9987 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9990 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9992 Malloc failure behavior now depends on size of allocation.
9993 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9994 * lisp.h: Change signatures accordingly.
9995 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9996 All callers changed. (Bug#8762)
9998 * gnutls.c: Use Emacs's memory allocators.
9999 Without this change, the gnutls library would invoke malloc etc.
10000 directly, which causes problems on non-SYNC_INPUT hosts, and which
10001 runs afoul of improving memory_full behavior. (Bug#8761)
10002 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10003 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10004 xfree instead of the default malloc, realloc, free.
10005 (Fgnutls_boot): No need to check for memory allocation failure,
10006 since xmalloc does that for us.
10008 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10009 * category.c (hash_get_category_set):
10010 * ccl.c (ccl_driver):
10011 * charset.c (Fdefine_charset_internal):
10012 * charset.h (struct charset.hash_index):
10013 * composite.c (get_composition_id, gstring_lookup_cache)
10014 (composition_gstring_put_cache):
10015 * composite.h (struct composition.hash_index):
10016 * dispextern.h (struct image.hash):
10017 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10018 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10019 (hashfn_equal, hashfn_user_defined, make_hash_table)
10020 (maybe_resize_hash_table, hash_lookup, hash_put)
10021 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10022 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10023 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10024 * image.c (make_image, search_image_cache, lookup_image)
10025 (xpm_put_color_table_h):
10026 * lisp.h (struct Lisp_Hash_Table):
10027 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10028 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10029 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10030 * alloc.c (allocate_vectorlike):
10031 Check for overflow in vector size calculations.
10032 * ccl.c (ccl_driver):
10033 Check for overflow when converting EMACS_INT to int.
10034 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10035 need to be updated by these changes.
10036 * fns.c (make_hash_table, maybe_resize_hash_table):
10037 Check for integer overflow with large hash tables.
10038 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10039 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10040 (SXHASH_REDUCE): New macro.
10041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10042 Use it instead of discarding useful hash info with large hash values.
10043 (sxhash_float): New function.
10044 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10045 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10046 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10047 Rewrite to use FIXNUM_BITS, as this simplifies things.
10048 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10049 Adjust signatures to match updated version of code.
10050 (consing_since_gc): Now EMACS_INT, since a single hash table can
10051 use more than INT_MAX bytes.
10053 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10055 Make it possible to build with GCC-4.6+ -O2 -flto.
10057 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10059 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10061 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10062 Call minibuffer-inactive-mode.
10064 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10066 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10067 Update dependencies.
10069 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10071 * data.c (init_data): Remove code for UTS, this system is not
10074 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10076 Don't force ./temacs to start in terminal mode.
10078 * frame.c (make_initial_frame): Initialize faces in all cases, not
10079 only when CANNOT_DUMP is defined.
10080 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10082 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10084 * dispnew.c (add_window_display_history): Use const for the string
10085 pointer. Remove declaration, not needed.
10087 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10089 Use 'inline', not 'INLINE'.
10090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10091 * alloc.c, fontset.c (INLINE): Remove.
10092 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10093 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10094 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10095 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10096 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10098 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10100 Make it possible to run ./temacs.
10102 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10103 syms_of_callproc does the same thing. Remove test for
10104 "initialized", do it in the caller.
10105 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10107 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10109 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10110 (read_minibuf): Use get_minibuffer.
10111 (syms_of_minibuf): Use DEFSYM.
10112 (Qmetadata): New var.
10113 * data.c (Qbuffer): Don't make it static.
10114 (syms_of_data): Use DEFSYM.
10116 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10118 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10119 (CCL_CODE_MIN): New macro.
10121 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10123 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10125 * eval.c (Qdebug): Now static.
10126 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10127 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10128 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10130 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10132 * image.c: Various fixes to ImageMagick code comments.
10133 (Fimagemagick_types): Doc fix.
10135 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10137 Minor fixes prompted by GCC 4.6.0 warnings.
10139 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10141 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10142 (x_clipboard_manager_save_all): Move extern decl to ...
10143 * xterm.h: ... here, so that it can be checked for consistency.
10145 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10147 * xselect.c (x_clipboard_manager_save_frame)
10148 (x_clipboard_manager_save_all): New functions.
10149 (Fx_clipboard_manager_save): Lisp function deleted.
10151 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10152 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10154 * xterm.h: Update prototype.
10156 2011-05-28 William Xu <william.xwl@gmail.com>
10158 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10159 exiting (Bug#8239).
10161 2011-05-28 Jim Meyering <meyering@redhat.com>
10163 Avoid a sign-extension bug in crypto_hash_function.
10164 * fns.c (to_uchar): Define.
10165 (crypto_hash_function): Use it to convert some newly-signed
10166 variables to unsigned, to avoid sign-extension bugs. For example,
10167 without this change, (md5 "truc") would evaluate to
10168 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10169 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10170 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10172 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10174 Integer overflow fixes.
10176 * dbusbind.c: Serial number integer overflow fixes.
10177 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10178 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10179 to hold a serial number that is too large for a fixnum.
10180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10181 Check for serial numbers out of range. Decode any serial number
10182 that was so large that it became a float. (Bug#8722)
10184 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10185 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10186 Use XFASTINT rather than XUINT when numbers are nonnegative.
10187 (xd_append_arg, Fdbus_method_return_internal):
10188 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10189 arguments, check that Lisp number is nonnegative, rather than
10190 silently wrapping negative numbers around. (Bug#8722)
10191 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10194 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10196 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10198 ccl: Add integer overflow checks.
10199 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10200 (IN_INT_RANGE): New macros.
10201 (ccl_driver): Use them to check for integer overflow when
10202 decoding a CCL program. Many of the new checks are whether XINT (x)
10203 fits in int; it doesn't always, on 64-bit hosts. The new version
10204 doesn't catch all possible integer overflows, but it's an
10205 improvement. (Bug#8719)
10207 * alloc.c (make_event_array): Use XINT, not XUINT.
10208 There's no need for unsigned here.
10210 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10211 This follows up to the 2011-05-06 change that substituted uintptr_t
10212 for EMACS_INT. This case wasn't caught back then.
10214 Rework Fformat to avoid integer overflow issues.
10215 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10216 now (part of C89). Include <verify.h>.
10217 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10218 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10219 (Fformat): Avoid the prepass trying to compute sizes; it was only
10220 approximate and thus did not catch overflow reliably. Instead, walk
10221 through the format just once, formatting and computing sizes as we go,
10222 checking for integer overflow at every step, and allocating a larger
10223 buffer as needed. Keep track separately whether the format is
10224 multibyte. Keep only the most-recently calculated precision, rather
10225 than them all. Record whether each argument has been converted to
10226 string. Use EMACS_INT, not int, for byte and char and arg counts.
10227 Support field widths and precisions larger than INT_MAX. Avoid
10228 sprintf's undefined behavior with conversion specifications such as %#d
10229 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10230 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10231 formatting out-of-range floating point numbers with int
10232 formats. (Bug#8668)
10234 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10236 * data.c: Avoid integer truncation in expressions involving floats.
10237 * data.c: Include <intprops.h>.
10238 (arith_driver): When there's an integer overflow in an expression
10239 involving floating point, convert the integers to floating point
10240 so that the resulting value does not suffer from catastrophic
10241 integer truncation. For example, on a 64-bit host (* 4
10242 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10243 Do not rely on undefined behavior after integer overflow.
10245 merge count_size_as_multibyte, parse_str_to_multibyte
10246 * character.c, character.h (count_size_as_multibyte):
10247 Rename from parse_str_to_multibyte; all uses changed.
10248 Check for integer overflow.
10249 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10250 since it's now a duplicate of the other. This is more of
10251 a character than a buffer op, so better that it's in character.c.
10252 * fns.c, print.c: Adjust to above changes.
10254 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10256 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10258 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10260 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10261 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10262 (x_clipboard_manager_save): Now static.
10263 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10265 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10266 (crypto_hash_function): Now static.
10267 Fix pointer signedness problems. Avoid unnecessary initializations.
10269 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10271 * termhooks.h (Vselection_alist): Make it terminal-local.
10273 * terminal.c (create_terminal): Initialize it.
10275 * xselect.c: Support for clipboard managers.
10276 (Vselection_alist): Move to termhooks.h as terminal-local var.
10277 (LOCAL_SELECTION): New macro.
10278 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10279 (symbol_to_x_atom): Remove gratuitous arg.
10280 (x_handle_selection_request, lisp_data_to_selection_data)
10281 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10282 (x_own_selection, x_get_local_selection, x_convert_selection):
10283 New arg, specifying work frame. Use terminal-local Vselection_alist.
10284 (some_frame_on_display): Delete unused function.
10285 (Fx_own_selection_internal, Fx_get_selection_internal)
10286 (Fx_disown_selection_internal, Fx_selection_owner_p)
10287 (Fx_selection_exists_p): New optional frame arg.
10288 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10289 (x_handle_selection_clear): Don't treat other terminals with the
10290 same keyboard specially. Use the terminal-local Vselection_alist.
10291 (x_clear_frame_selections): Use Frun_hook_with_args.
10293 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10295 * xterm.h: Add support for those atoms.
10297 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10299 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10300 (converted_selections, conversion_fail_tag): New global variables.
10301 (x_selection_request_lisp_error): Free the above.
10302 (x_get_local_selection): Remove unnecessary code.
10303 (x_reply_selection_request): Args changed; handle arbitrary array
10304 of converted selections stored in converted_selections.
10305 Separate the XChangeProperty and SelectionNotify steps.
10306 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10307 (x_convert_selection): New function.
10308 (x_handle_selection_event): Simplify.
10309 (x_get_foreign_selection): Don't ignore incoming requests while
10310 waiting for an answer; this will fail when we implement
10311 SAVE_TARGETS, and seems unnecessary anyway.
10312 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10313 (Vx_sent_selection_functions): Doc fix.
10315 2011-05-26 Leo Liu <sdl.web@gmail.com>
10317 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10319 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10321 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10323 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10324 for fringe update if it has periodic bitmap.
10325 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10326 and fringe_bitmap_periodic_p.
10328 * fringe.c (get_fringe_bitmap_data): New function.
10329 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10330 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10331 row. Mark glyph row for fringe update if periodicity changed.
10333 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10334 for fringe update unless it has periodic bitmap.
10336 2011-05-25 Kenichi Handa <handa@m17n.org>
10338 * xdisp.c (get_next_display_element): Set correct it->face_id for
10339 a static composition.
10341 2011-05-24 Leo Liu <sdl.web@gmail.com>
10344 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10346 * fns.c (crypto_hash_function, Fsha1): New function.
10347 (Fmd5): Use crypto_hash_function.
10348 (syms_of_fns): Add Ssha1.
10350 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10352 * gnutls.c: Remove unused macros.
10353 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10354 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10355 Remove macros that are defined and never used.
10356 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10358 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10360 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10361 (Fx_get_selection_internal): Minor cleanup.
10362 (Fx_own_selection_internal): Rename arguments for consistency with
10365 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10367 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10369 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10371 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10373 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10375 * dispnew.c (scrolling_window): Don't exclude the case that the
10376 last enabled row in the desired matrix touches the bottom boundary.
10378 2011-05-21 Glenn Morris <rgm@gnu.org>
10380 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10381 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10382 and add some more files.
10384 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10386 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10387 report_file_error introduced by the change from 2011-05-07.
10389 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10391 * systime.h (Time): Define only if emacs is defined.
10392 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10393 where the include path doesn't have X11/X.h by default. See
10394 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10396 2011-05-20 Kenichi Handa <handa@m17n.org>
10398 * composite.c (find_automatic_composition): Fix previous change.
10400 2011-05-20 Glenn Morris <rgm@gnu.org>
10402 * lisp.mk: New file, split from Makefile.in.
10403 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10404 (shortlisp): Remove.
10405 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10407 2011-05-19 Glenn Morris <rgm@gnu.org>
10409 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10410 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10411 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10412 (lisp): Set the order to that of loadup.el.
10413 (shortlisp): Make it a copy of $lisp.
10414 (SOME_MACHINE_LISP): Remove.
10415 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10416 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10418 2011-05-18 Kenichi Handa <handa@m17n.org>
10420 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10421 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10422 (find_automatic_composition): Mostly rewrite for efficiency.
10424 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10426 * makefile.w32-in: Update dependencies.
10428 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10430 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10431 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10433 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10435 Fix some integer overflow issues, such as string length overflow.
10437 * insdel.c (count_size_as_multibyte): Check for string overflow.
10439 * character.c (lisp_string_width): Check for string overflow.
10440 Use EMACS_INT, not int, for string indexes and lengths; in
10441 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10442 the resulting string length overflows an EMACS_INT; instead,
10443 report a string overflow if no precision given. When checking for
10444 precision exhaustion, use a check that cannot possibly have
10445 integer overflow. (Bug#8675)
10446 * character.h (lisp_string_width): Adjust to new signature.
10448 * alloc.c (string_overflow): New function.
10449 (Fmake_string): Use it. This doesn't change behavior, but saves
10450 a few bytes and will simplify future changes.
10451 * character.c (string_escape_byte8): Likewise.
10452 * lisp.h (string_overflow): New decl.
10454 Fixups, following up to the user-interface timestamp change.
10455 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10456 for UI timestamps, instead of unsigned long.
10457 * msdos.c (mouse_get_pos): Likewise.
10458 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10459 * w32gui.h (Time): Define by including "systime.h" rather than by
10460 declaring it ourselves. (Bug#8664)
10462 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10463 * image.c (clear_image_cache): Likewise.
10465 * term.c (term_mouse_position): Don't assume time_t wraparound.
10467 Be more systematic about user-interface timestamps.
10468 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10469 and sometimes 'EMACS_UINT', to represent these timestamps.
10470 This change causes it to use 'Time' uniformly, as that's what X uses.
10471 This makes the code easier to follow, and makes it easier to catch
10472 integer overflow bugs such as Bug#8664.
10473 * frame.c (Fmouse_position, Fmouse_pixel_position):
10474 Use Time, not unsigned long, for user-interface timestamps.
10475 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10476 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10477 * keyboard.h (last_event_timestamp): Likewise.
10478 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10479 * menu.h (xmenu_show): Likewise.
10480 * term.c (term_mouse_position): Likewise.
10481 * termhooks.h (struct input_event.timestamp): Likewise.
10482 (struct terminal.mouse_position_hook): Likewise.
10483 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10484 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10485 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10486 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10487 what it was before.
10488 * menu.h, termhooks.h: Include "systime.h", for Time.
10490 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10491 Don't assume that the difference between two unsigned long values
10492 can fit into an integer. At this point, we know button_down_time
10493 <= event->timestamp, so the difference must be nonnegative, so
10494 there's no need to cast the result if double-click-time is
10495 nonnegative, as it should be; check that it's nonnegative, just in
10496 case. This bug is triggered when events are more than 2**31 ms
10497 apart (about 25 days). (Bug#8664)
10499 * xselect.c (last_event_timestamp): Remove duplicate decl.
10500 (x_own_selection): Remove needless cast to unsigned long.
10502 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10503 that always fit in int. Use a sentinel instead of a counter, to
10504 avoid a temp and to allay GCC's concerns about possible int overflow.
10505 * frame.h (struct frame): Use int for menu_bar_items_used
10506 instead of EMACS_INT, since it always fits in int.
10508 * menu.c (grow_menu_items): Check for int overflow.
10510 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10512 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10513 Before, the code was not consistent. These values cannot exceed
10514 2**31 - 1 so there's no need to make them unsigned.
10515 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10516 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10517 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10519 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10521 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10522 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10523 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10524 presumably because the widths might not match.
10526 * window.c (size_window): Avoid needless test at loop start.
10528 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10530 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10532 2011-05-12 Drew Adams <drew.adams@oracle.com>
10534 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10536 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10538 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10539 `width' to `bar_area_x' and `bar_area_width', respectively.
10540 (x_scroll_run): Take account of fringe background extension.
10542 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10543 Rename local vars `left' and `width' to `bar_area_x' and
10544 `bar_area_width', respectively.
10545 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10546 background extension.
10548 2011-05-10 Jim Meyering <meyering@redhat.com>
10550 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10552 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10554 * image.c (Finit_image_library): Return t for built-in image types,
10555 like pbm and xbm. (Bug#8640)
10557 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10559 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10561 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10563 * w32console.c (Fset_screen_color): Doc fix.
10564 (Fget_screen_color): New function.
10565 (syms_of_ntterm): Defsubr it.
10567 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10568 unlink the temporary file if Fcall_process didn't create it in the
10570 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10571 child process will be redirected to a file specified with `:file'.
10572 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10573 cue to call_process_cleanup not to close that handle.
10575 2011-05-07 Ben Key <bkey76@gmail.com>
10577 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10578 one of two shell specific rules, either bootstrap-temacs-CMD or
10579 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10580 to the previous implementation of the bootstrap-temacs rule.
10581 The bootstrap-temacs-CMD rule is similar to the previous
10582 implementation of the bootstrap-temacs rule except that it
10583 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10586 These changes, along with some changes to nt/configure.bat,
10587 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10588 earlier fix to add support for --cflags and --ldflags options
10589 that include quotes so that it works whether make uses cmd or
10592 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10594 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10595 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10597 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10598 a string. Handle both cases.
10599 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10600 (Fdbus_register_method): Use Qinvalid_function.
10602 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10604 * makefile.w32-in: Update dependencies.
10605 (LISP_H): Add inttypes.h and stdin.h.
10606 (PROCESS_H): Add unistd.h.
10608 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10610 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10611 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10613 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10615 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10617 * term.c (vfatal): Remove stray call to va_end.
10618 It's not needed and the C Standard doesn't allow it here anyway.
10620 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10621 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10623 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10626 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10628 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10630 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10632 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10634 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10636 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10637 * charset.c (Fdefine_charset_internal): Don't initialize
10638 charset.code_space[15]. The value was garbage, on hosts with
10639 32-bit int (Bug#8600).
10641 * lread.c (read_integer): Be more consistent with string-to-number.
10642 Use string_to_number to do the actual conversion; this avoids
10643 rounding errors and fixes some other screwups. Without this fix,
10644 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10645 (digit_to_number): Move earlier, for benefit of read_integer.
10646 Return -1 if the digit is out of range for the base, -2 if it is
10647 not a digit in any supported base. (Bug#8602)
10649 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10651 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10652 to match comment at start of function. This also removes a
10653 GCC warning about overflow in a 32+64-bit port.
10655 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10657 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10658 Reported by Stefan Monnier in
10659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10661 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10663 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10664 (EMACS_UINTPTR): Likewise, with uintptr_t.
10666 * lisp.h: Prefer 64-bit EMACS_INT if available.
10667 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10668 on 32-bit hosts that have 64-bit int, so that they can access
10670 However, temporarily disable this change unless the temporary
10671 symbol WIDE_EMACS_INT is defined.
10673 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10675 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10676 This removes an assumption that EMACS_INT and long are the same
10677 width as pointers. The assumption is true for Emacs porting targets
10678 now, but we want to make other targets possible.
10679 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10680 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10681 In the rest of the code, change types of integers that hold casted
10682 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10683 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10684 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10685 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10686 No need to cast type when ORing.
10687 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10688 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10689 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10690 assume EMACS_INT is the same width as char *.
10691 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10692 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10693 Remove no-longer-needed casts.
10694 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10695 (xg_tool_bar_help_callback, xg_make_tool_item):
10696 Use EMACS_INTPTR to hold an integer
10697 that will be cast to void *; this can avoid a GCC warning
10698 if EMACS_INT is not the same width as void *.
10699 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10700 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10701 (current_message_1, set_message_1):
10702 Use a local to convert to proper width without a cast.
10703 * xmenu.c (dialog_selection_callback): Likewise.
10705 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10706 Also, don't assume VALBITS / RAND_BITS is less than 5,
10707 and don't rely on undefined behavior when shifting a 1 left into
10709 * lisp.h (get_random): Change signature to match.
10711 * lread.c (hash_string): Use size_t, not int, for hash computation.
10712 Normally we prefer signed values; but hashing is special, because
10713 it's better to use unsigned division on hash table sizes so that
10714 the remainder is nonnegative. Also, size_t is the natural width
10715 for hashing into memory. The previous code used 'int', which doesn't
10716 retain enough info to hash well into very large tables.
10717 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10719 * dbusbind.c: Don't possibly lose pointer info when converting.
10720 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10721 Use XPNTR rather than XHASH, so that the high-order bits of
10722 the pointer aren't lost when converting through void *.
10724 * eval.c (Fautoload): Don't double-shift a pointer.
10726 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10728 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10730 * gnutls.c (DEF_GNUTLS_FN):
10731 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10733 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10735 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10738 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10740 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10741 New version that can reserve upto 2GB of heap space.
10743 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10745 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10747 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10749 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10750 `gnutls_certificate_set_x509_key_file'.
10752 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10754 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10755 Update dependencies.
10757 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10759 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10760 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10761 Remove unused parameter `fildes'.
10762 * process.c (read_process_output, send_process): Don't pass it.
10764 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10766 Fix previous change: the library cache is defined in w32.c.
10767 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10768 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10770 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10772 Implement dynamic loading of GnuTLS on Windows.
10774 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10775 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10779 * gnutls.c (Qgnutls_dll): Define.
10780 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10781 (gnutls_*): Declare function pointers.
10782 (init_gnutls_functions): New function to initialize function pointers.
10783 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10784 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10785 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10786 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10787 (emacs_gnutls_write, emacs_gnutls_read)
10788 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10789 (Fgnutls_available_p): New function.
10790 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10791 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10792 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10794 * image.c: Include w32.h.
10795 (Vimage_type_cache): Delete.
10796 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10797 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10798 (w32_delayed_load): Move to w32.c.
10800 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10802 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10803 (w32_delayed_load): Move from image.c. When loading a library, record
10804 its filename in the :loaded-from property of the library id.
10805 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10806 Initialize and staticpro them.
10807 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10809 * process.c: Include lisp.h before w32.h, not after.
10810 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10811 instead of gnutls_record_check_pending.
10813 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10815 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10817 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10818 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10821 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10823 * xterm.c (x_set_frame_alpha): Do not set property on anything
10824 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10826 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10828 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10830 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10832 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10833 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10834 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10835 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10836 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10837 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10838 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10839 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10840 (Qgnutls_bootprop_callbacks_verify): Make static.
10842 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10844 * callproc.c: Indentation fixup.
10846 * sysdep.c (wait_for_termination_1): Make static.
10847 (wait_for_termination, interruptible_wait_for_termination):
10848 Move after wait_for_termination_1.
10850 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10852 * sysdep.c (interruptible_wait_for_termination): New function
10853 which is like wait_for_termination, but allows keyboard
10856 * callproc.c (Fcall_process): Add (:file "file") as an option for
10858 (Fcall_process_region): Ditto.
10860 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10862 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10863 rather than `XVECTOR (FOO)->size'.
10865 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10866 inttypes.h, as a gnulib replacement is used if it not available in
10869 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10871 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10872 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10873 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10875 * coding.c (coding_alloc_by_realloc): Error out if destination
10876 will grow beyond MOST_POSITIVE_FIXNUM.
10877 (decode_coding_emacs_mule): Abort if there isn't enough place in
10878 charbuf for the composition carryover bytes. Reserve an extra
10879 space for up to 2 characters produced in a loop.
10880 (decode_coding_iso_2022): Abort if there isn't enough place in
10881 charbuf for the composition carryover bytes.
10883 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10885 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10886 aborting when %lld or %lll format is passed.
10887 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10888 %llo or %llx format is passed. (Bug#8545)
10890 * window.c (window_scroll_line_based): Use a marker instead of
10891 simple variables to record original value of point. (Bug#7952)
10893 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10894 produced by %s or %c overflows available buffer space. (Bug#8545)
10896 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10898 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10899 (SIZE_MAX): Move defn after all includes, as they might #define it.
10901 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10903 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10905 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10907 * keyboard.c (Qdelayed_warnings_hook): Define.
10908 (command_loop_1): Run `delayed-warnings-hook'
10909 if Vdelayed_warnings_list is non-nil.
10910 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10911 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10913 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10915 * doprnt.c (doprnt): Don't return value smaller than the buffer
10916 size if the message was truncated. (Bug#8545).
10918 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10920 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10921 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10923 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10925 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10927 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10929 * makefile.w32-in: Update dependencies.
10931 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10933 Improve `doprnt' and its usage. (Bug#8545)
10934 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10935 `format_end'. Remove support for %l as a conversion specifier.
10936 Don't use xrealloc. Improve diagnostics when the %l size modifier
10937 is used. Update the commentary.
10939 * eval.c (verror): Simplify calculation of size_t.
10941 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10944 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10946 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10949 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10951 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10952 This makes this file independent of the recent pseudovector change.
10954 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10956 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10958 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10959 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10960 Remove unused local.
10961 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10963 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10964 GCC 4.6.0 optimizes based on type-based alias analysis.
10965 For example, if b is of type struct buffer * and v of type struct
10966 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10967 != &v->size, and therefore "v->size = 1; b->size = 2; return
10968 v->size;" must therefore return 1. This assumption is incorrect
10969 for Emacs, since it type-puns struct Lisp_Vector * with many other
10970 types. To fix this problem, this patch adds a new type struct
10971 vectorlike_header that documents the constraints on layout of vectors
10972 and pseudovectors, and helps optimizing compilers not get fooled
10973 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10974 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10975 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10977 (XSETPVECTYPE): Rewrite in terms of new macro.
10978 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10979 This is a bit clearer, and further avoids the possibility of
10980 undesirable aliasing.
10981 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10982 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10983 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10984 since Lisp_Subr is a special case (no "next" field).
10985 (ASIZE): Now uses header.size rather than size.
10986 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10987 to avoid the hassle of writing XVECTOR (foo)->header.size.
10988 (struct vectorlike_header): New type.
10989 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10990 object, to help avoid aliasing.
10991 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10992 (SUBRP): Likewise, since Lisp_Subr is a special case.
10993 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10994 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10995 (struct Lisp_Hash_Table): Combine first two members into a single
10996 struct vectorlike_header member. All uses of "size" and "next" members
10997 changed to be "header.size" and "header.next".
10998 * buffer.h (struct buffer): Likewise.
10999 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11000 * frame.h (struct frame): Likewise.
11001 * process.h (struct Lisp_Process): Likewise.
11002 * termhooks.h (struct terminal): Likewise.
11003 * window.c (struct save_window_data, struct saved_window): Likewise.
11004 * window.h (struct window): Likewise.
11005 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11006 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11007 * buffer.c (init_buffer_once): Likewise.
11008 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11010 * process.c (Fformat_network_address): Use local var for size,
11013 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11015 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11016 * data.c (atof): Remove decl; no longer used or needed.
11017 (digit_to_number): Move to lread.c.
11018 (Fstring_to_number): Use new string_to_number function, to be
11019 consistent with how the Lisp reader treats infinities and NaNs.
11020 Do not assume that floating-point numbers represent EMACS_INT
11021 without losing information; this is not true on most 64-bit hosts.
11022 Avoid double-rounding errors, by insisting on integers when
11023 parsing non-base-10 numbers, as the documentation specifies.
11024 * lisp.h (string_to_number): New decl, replacing ...
11025 (isfloat_string): Remove.
11026 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11027 (read1): Do not accept +. and -. as integers; this
11028 appears to have been a coding error. Similarly, do not accept
11029 strings like +-1e0 as floating point numbers. Do not report
11030 overflow for integer overflows unless the base is not 10 which
11031 means we have no simple and reliable way to continue.
11032 Break out the floating-point parsing into a new
11033 function string_to_number, so that Fstring_to_number parses
11034 floating point numbers consistently with the Lisp reader.
11035 (digit_to_number): Move here from data.c. Make it static inline.
11036 (E_CHAR, EXP_INT): Remove, replacing with ...
11037 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11038 (string_to_number): New function, replacing isfloat_string.
11039 This function checks for valid syntax and produces the resulting
11040 Lisp float number too. Rework it so that string-to-number
11041 no longer mishandles examples like "1.0e+". Use strtoumax,
11042 so that overflow for non-base-10 numbers is reported only when
11043 there's no portable and simple way to convert to floating point.
11045 * textprop.c (set_text_properties_1): Rewrite for clarity,
11046 and to avoid GCC warning about integer overflow.
11048 * intervals.h (struct interval): Use EMACS_INT for members
11049 where EMACS_UINT might cause problems. See
11050 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11051 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11052 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11054 (offset_intervals): Tell GCC not to worry about length overflow
11055 when negating a negative length.
11057 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11058 (overrun_check_free): Likewise.
11060 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11061 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11064 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11065 (gnutls_make_error): Rename local to avoid shadowing.
11066 (gnutls_emacs_global_deinit): ifdef out; not used.
11067 (Fgnutls_boot): Use const for pointer to readonly storage.
11068 Comment out unused local. Fix pointer signedness problems.
11070 * lread.c (openp): Don't stuff size_t into an 'int'.
11071 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11072 about possible signed overflow.
11074 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11075 (GDK_KEY_g): Don't define if already defined.
11076 (xg_prepare_tooltip): Avoid pointer signedness problem.
11077 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11079 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11080 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11082 * xfns.c (Fx_window_property): Simplify a bit,
11083 to make a bit faster and to avoid GCC 4.6.0 warning.
11084 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11086 * fns.c (internal_equal): Don't assume size_t fits in int.
11088 * alloc.c (compact_small_strings): Tighten assertion a little.
11090 Replace pEd with more-general pI, and fix some printf arg casts.
11091 * lisp.h (pI): New macro, generalizing old pEd macro to other
11092 conversion specifiers. For example, use "...%"pI"d..." rather
11093 than "...%"pEd"...".
11094 (pEd): Remove. All uses replaced with similar uses of pI.
11095 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11096 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11097 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11098 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11099 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11100 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11101 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11103 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11104 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11105 * print.c (safe_debug_print, print_object): Likewise.
11106 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11108 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11109 avoiding the 0 flag, which is not portable.
11110 * process.c (Fmake_network_process): Use pI to avoid cast.
11111 * region-cache.c (pp_cache): Likewise.
11112 * xdisp.c (decode_mode_spec): Likewise.
11113 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11114 behavior on 64-bit hosts with printf arg.
11115 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11116 (x_stop_queuing_selection_requests): Likewise.
11117 (x_get_window_property): Don't truncate byte count to an 'int'
11120 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11121 here, since it parses constructs like leading '-' and spaces,
11122 which are not wanted; and it overflows with large numbers.
11123 Instead, simply match F[0-9]+, which is what is wanted anyway.
11125 * alloc.c: Remove unportable assumptions about struct layout.
11126 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11127 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11128 (allocate_vectorlike, make_pure_vector): Use the new macros,
11129 plus offsetof, to remove unportable assumptions about struct layout.
11130 These assumptions hold on all porting targets that I know of, but
11131 they are not guaranteed, they're easy to remove, and removing them
11132 makes further changes easier.
11134 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11135 This doesn't fix a bug but makes the code clearer.
11136 (string_overrun_cookie): Now const. Use initializers that
11137 don't formally overflow signed char, to avoid warnings.
11138 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11139 can cause Emacs to crash when string overrun checking is enabled.
11140 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11141 multiple of sizeof (EMACS_INT); it need not be, if
11142 alignof(EMACS_INT) < sizeof (EMACS_INT).
11143 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11145 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11147 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11149 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11151 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11152 supposed to be handshaking. (Bug#8556)
11153 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11155 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11157 * lisp.h (Qdebug): List symbol.
11158 * eval.c (Qdebug): Restore global linkage.
11159 * keyboard.c (debug-on-event): New variable.
11160 (handle_user_signal): Break into debugger when debug-on-event
11161 matches the current signal symbol.
11163 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11165 * alloc.c (check_sblock, check_string_bytes)
11166 (check_string_free_list): Convert to standard C.
11168 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11170 * w32.c (emacs_gnutls_push): Fix typo.
11172 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11174 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11175 "cast to pointer from integer of different size".
11177 Improve doprnt and its use in verror. (Bug#8545)
11178 * doprnt.c (doprnt): Document the set of format control sequences
11179 supported by the function. Use SAFE_ALLOCA instead of always
11182 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11183 is one byte too soon. Don't use xrealloc; instead xfree and
11186 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11188 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11191 * gnutls.c: Renamed global_initialized to
11192 gnutls_global_initialized. Added internals for the
11193 :verify-hostname-error, :verify-error, and :verify-flags
11194 parameters of `gnutls-boot' and documented those parameters in the
11195 docstring. Start callback support.
11196 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11197 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11198 on error. Return error code.
11199 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11200 (emacs_gnutls_read): Likewise.
11201 (Fgnutls_boot): Return handshake error code.
11202 (emacs_gnutls_handle_error): New function.
11203 (wsaerror_to_errno): Likewise.
11205 * w32.h (emacs_gnutls_pull): Add prototype.
11206 (emacs_gnutls_push): Likewise.
11208 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11209 (emacs_gnutls_push): Likewise.
11211 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11213 * process.c (wait_reading_process_output): Check if GnuTLS
11214 buffered some data internally if no FDs are set for TLS
11217 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11218 (LIBS): Link to USER_LIBS.
11219 ($(BLD)/gnutls.$(0)): New target.
11221 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11223 * xdisp.c (handle_single_display_spec): Rename the
11224 display_replaced_before_p argument into display_replaced_p, to
11225 make it consistent with the commentary. Fix typos in the
11228 * textprop.c (syms_of_textprop): Remove dead code.
11229 (copy_text_properties): Delete obsolete commentary about an
11230 interface that was deleted long ago. Fix typos in the description
11233 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11234 to changes in oldXMenu/XMenu.h from 2011-04-16.
11235 <menu_help_message, prev_menu_help_message>: Constify.
11236 (IT_menu_make_room): menu->help_text is now `const char **';
11239 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11240 to changes in oldXMenu/XMenu.h from 2011-04-16.
11241 (struct XMenu): Declare `help_text' `const char **'.
11243 * xfaces.c <Qunspecified>: Make extern again.
11245 * syntax.c: Include sys/types.h before including regex.h, as
11248 * doc.c (get_doc_string): Improve the format passed to `error'.
11250 * doprnt.c (doprnt): Improve commentary.
11252 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11254 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11257 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11258 changes in globals.h immediately force recompilation.
11259 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11260 $(CURDIR)/s/ms-w32.h.
11261 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11263 * character.c (Fchar_direction): Function deleted.
11264 (syms_of_character): Don't defsubr it.
11265 <char-direction-table>: Deleted.
11267 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11269 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11270 * doprnt.c: Include limits.h.
11271 (SIZE_MAX): New macro.
11272 (doprnt): Return a size_t value. 2nd arg is now size_t.
11273 Many local variables are now size_t instead of int or unsigned.
11274 Improve overflow protection. Support `l' modifier for integer
11275 conversions. Support %l conversion. Don't assume an EMACS_INT
11276 argument for integer conversions and for %c.
11278 * lisp.h (doprnt): Restore prototype.
11280 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11281 $(SRC)/character.h.
11283 * Makefile.in (base_obj): Add back doprnt.o.
11285 * deps.mk (doprnt.o): Add back prerequisites.
11286 (callint.o): Depend on character.h.
11288 * eval.c (internal_lisp_condition_case): Include the handler
11289 representation in the error message.
11290 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11291 when breaking from the loop.
11293 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11295 * callint.c (Fcall_interactively): When displaying error message
11296 about invalid control letter, pass the character's codepoint, not
11297 a pointer to its multibyte form. Improve display of the character
11298 in octal and display also its hex code.
11300 * character.c (char_string): Use %x to display the (unsigned)
11301 codepoint of an invalid character, to avoid displaying a bogus
11304 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11305 `error', not SYMBOL_NAME itself.
11307 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11308 character arguments to `error'.
11310 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11311 to `error' in error message about FINAL_CHAR argument. Make sure
11312 FINAL_CHAR is a character, and use %c when it is passed as
11313 argument to `error'.
11315 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11317 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11319 * w32.c: Include <time.h>.
11320 (sys_localtime): New function.
11322 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11324 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11326 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11328 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11330 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11331 zombies (Bug#8467).
11333 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11335 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11336 gl_state.e_property when gl_state.object is Qt.
11338 * insdel.c (make_gap_larger): Remove limitation of buffer size
11341 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11343 * xdisp.c (lookup_glyphless_char_display)
11344 (produce_glyphless_glyph): Handle cons cell entry in
11345 glyphless-char-display.
11346 (Vglyphless_char_display): Document it.
11348 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11349 glyphless-char-display.
11351 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11353 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11355 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11358 definition for no-X builds.
11360 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11362 Static checks with GCC 4.6.0 and non-default toolkits.
11364 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11366 * process.c (keyboard_bit_set): Define only if SIGIO.
11367 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11368 (send_process): Repair possible setjmp clobbering.
11370 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11372 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11374 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11376 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11377 Define only if needed.
11379 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11380 by pacifying GCC about it. Maybe it's time to retire it?
11381 * xfaces.c (USG, __TIMEVAL__): Likewise.
11383 * dispextern.h (struct redisplay_interface): Rename param
11384 to avoid shadowing.
11385 * termhooks.h (struct terminal): Likewise.
11386 * xterm.c (xembed_send_message): Likewise.
11388 * insdel.c (make_gap_smaller): Define only if
11389 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11391 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11394 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11395 so that we aren't warned about unused symbols.
11397 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11399 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11401 * xfns.c (x_real_positions): Mark locals as initialized.
11403 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11405 * xterm.c: Fix problems found by static analysis with other toolkits.
11406 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11407 (x_dispatch_event): Declare static if USE_GTK, and
11408 define if USE_GTK || USE_X_TOOLKIT.
11409 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11410 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11411 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11412 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11414 * xmenu.c (menu_help_callback): Pointer type fixes.
11415 Use const pointers when pointing at readonly data. Avoid pointer
11416 signedness clashes.
11417 (FALSE): Remove unused macro.
11418 (update_frame_menubar): Remove unused decl.
11420 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11422 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11423 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11424 (single_menu_item): Rename local to avoid shadowing.
11426 * keyboard.c (make_lispy_event): Remove unused local var.
11428 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11429 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11431 * bitmaps: Change bitmaps from unsigned char back to the X11
11432 compatible char. Avoid the old compiler warnings about
11433 out-of-range initializers by using, for example, '\xab' rather
11436 * xgselect.c (xgselect_initialize): Check vs interface
11437 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11439 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11441 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11442 to read-only memory.
11444 * fns.c (vector): Remove; this old hack is no longer needed.
11446 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11448 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11450 * xrdb.c (x_load_resources): Omit unused local.
11452 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11453 (x_window): Rename locals to avoid shadowing.
11454 (USG): Use the kludged USG macro, to pacify gcc.
11456 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11457 (x_term_init): Remove local to avoid shadowing.
11459 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11461 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11462 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11464 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11466 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11468 Fix regex.c, syntax.c and friends for buffers > 2GB.
11469 * syntax.h (struct gl_state_s): Declare character position members
11472 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11474 * textprop.c (verify_interval_modification, interval_of):
11475 Declare arguments EMACS_INT.
11477 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11480 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11482 * indent.c (Fvertical_motion): Local variable it_start is now
11485 * regex.c (re_match, re_match_2, re_match_2_internal)
11486 (bcmp_translate, regcomp, regexec, print_double_string)
11487 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11488 (re_compile_pattern, re_exec): Declare arguments and local
11489 variables `size_t' and `ssize_t' and return values `regoff_t', as
11491 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11492 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11493 <compile_stack_type>: `size' and `avail' are now `size_t'.
11495 * regex.h <regoff_t>: Use ssize_t, not int.
11496 (re_search, re_search_2, re_match, re_match_2): Arguments that
11497 specify buffer/string position and length are now ssize_t and
11498 size_t. Return type is regoff_t.
11500 2011-04-16 Ben Key <bkey76@gmail.com>
11502 * nsfont.m: Fixed bugs in ns_get_family and
11503 ns_descriptor_to_entity that were caused by using free to
11504 deallocate memory blocks that were allocated by xmalloc (via
11505 xstrdup). This caused Emacs to crash when compiled with
11506 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11507 --enable-checking=xmallocoverrun). xfree is now used to
11508 deallocate these memory blocks.
11510 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11512 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11514 emacs_write: Accept and return EMACS_INT for sizes.
11515 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11517 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11518 Accept and return EMACS_INT.
11519 (emacs_gnutls_write): Return the number of bytes written on
11521 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11522 (emacs_read, emacs_write): Remove check for negative size, as the
11523 Emacs source code has been audited now.
11524 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11525 (emacs_read, emacs_write): Use it.
11526 * process.c (send_process): Adjust to the new signatures of
11527 emacs_write and emacs_gnutls_write. Do not attempt to store
11528 a byte offset into an 'int'; it might overflow.
11529 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11531 * sound.c: Don't assume sizes fit in 'int'.
11532 (struct sound_device.period_size, alsa_period_size):
11533 Return EMACS_INT, not int.
11534 (struct sound_device.write, vox_write, alsa_write):
11535 Accept EMACS_INT, not int.
11536 (wav_play, au_play): Use EMACS_INT to store sizes and to
11537 record read return values.
11539 2011-04-15 Ben Key <bkey76@gmail.com>
11541 * keyboard.c (Qundefined): Don't declare static since it is used
11543 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11544 static since they are used in nsfont.m.
11546 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11548 * process.c (Qprocessp): Don't declare static.
11549 * lisp.h (Qprocessp): Declare again.
11551 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11553 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11555 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11557 Improve C-level modularity by making more things 'static'.
11559 Don't publish debugger-only interfaces to other modules.
11560 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11561 (verify_bytepos, count_markers): Move decls to the only modules
11563 * region-cache.h (pp_cache): Likewise.
11564 * window.h (check_all_windows): Likewise.
11565 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11567 * sysdep.c (croak): Now static, if
11568 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11569 * syssignal.h (croak): Declare only if not static.
11571 * alloc.c (refill_memory_reserve): Now static if
11572 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11573 * lisp.h (refill_memory_reserve): Declare only if not static.
11575 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11576 Define only if USE_LUCID.
11578 * xrdb.c (x_customization_string, x_rm_string): Now static.
11580 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11581 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11583 * xdisp.c (draw_row_with_mouse_face): Now static.
11584 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11586 * window.h (check_all_windows): Mark externally visible.
11588 * window.c (window_deletion_count): Now static.
11590 * undo.c: Make symbols static if they're not exported.
11591 (last_undo_buffer, last_boundary_position, pending_boundary):
11594 * textprop.c (interval_insert_behind_hooks): Now static.
11595 (interval_insert_in_front_hooks): Likewise.
11597 * term.c: Make symbols static if they're not exported.
11598 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11599 (max_frame_lines, tty_set_terminal_modes):
11600 (tty_reset_terminal_modes, tty_turn_off_highlight):
11601 (get_tty_terminal): Now static.
11602 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11603 * termhooks.h (term_mouse_moveto): Do not declare if
11604 HAVE_WINDOW_SYSTEM.
11605 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11606 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11608 * sysdep.c: Make symbols static if they're not exported.
11609 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11611 (sigprocmask_set, full_mask): Remove; unused.
11612 (wait_debugging): Mark as visible.
11613 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11614 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11616 * syntax.c (syntax_temp): Define only if !__GNUC__.
11618 * sound.c (current_sound_device, current_sound): Now static.
11620 * search.c (searchbufs, searchbuf_head): Now static.
11622 * scroll.c (scroll_cost): Remove; unused.
11623 * dispextern.h (scroll_cost): Remove decl.
11625 * region-cache.h (pp_cache): Mark as externally visible.
11627 * process.c: Make symbols static if they're not exported.
11628 (process_tick, update_tick, create_process, chan_process):
11629 (Vprocess_alist, proc_buffered_char, datagram_access):
11630 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11631 (deactivate_process): Mark defn as static, as well as decl.
11632 * lisp.h (create_process): Remove decl.
11633 * process.h (chan_process, Vprocess_alist): Remove decls.
11635 * print.c: Make symbols static if they're not exported.
11636 (print_depth, new_backquote_output, being_printed, print_buffer):
11637 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11638 (print_interval, print_number_index, initial_stderr_stream):
11640 * lisp.h (Fprinc): Remove decl.
11641 (debug_output_compilation_hack): Mark as externally visible.
11643 * sysdep.c (croak): Move decl from here to syssignal.h.
11644 * syssignal.h (croak): Put it here, so the API can be checked when
11645 'croak' is called from dissociate_if_controlling_tty.
11647 * minibuf.c: Make symbols static if they're not exported.
11648 (minibuf_save_list, choose_minibuf_frame): Now static.
11649 * lisp.h (choose_minibuf_frame): Remove decl.
11651 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11653 * lread.c: Make symbols static if they're not exported.
11654 (read_objects, initial_obarray, oblookup_last_bucket_number):
11656 (make_symbol): Remove; unused.
11657 * lisp.h (initial_obarray, make_symbol): Remove decls.
11659 * keyboard.c: Make symbols static if they're not exported.
11660 (single_kboard, recent_keys_index, total_keys, recent_keys):
11661 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11662 (this_single_command_key_start, echoing, last_auto_save):
11663 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11664 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11665 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11666 (Vlispy_mouse_stem, double_click_count):
11668 (force_auto_save_soon): Define only if SIGDANGER.
11669 (ignore_mouse_drag_p): Now static if
11670 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11671 (print_help): Remove; unused.
11672 (stop_character, last_timer_event): Mark as externally visible.
11673 * keyboard.h (ignore_mouse_drag_p): Declare only if
11674 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11675 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11676 * lisp.h (echoing): Remove decl.
11677 (force_auto_save_soon): Declare only if SIGDANGER.
11678 * xdisp.c (redisplay_window): Simplify code, to make it more
11679 obvious that ignore_mouse_drag_p is not accessed if !defined
11680 USE_GTK && !defined HAVE_NS.
11682 * intervals.c: Make symbols static if they're not exported.
11683 (merge_properties_sticky, merge_interval_right, delete_interval):
11685 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11687 * insdel.c: Make symbols static if they're not exported.
11688 However, leave prepare_to_modify_buffer alone. It's never
11689 called from outside this function, but that appears to be a bug.
11690 (combine_after_change_list, combine_after_change_buffer):
11691 (adjust_after_replace, signal_before_change): Now static.
11692 (adjust_after_replace_noundo): Remove; unused.
11693 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11694 (signal_before_change): Remove decls.
11696 * indent.c (val_compute_motion, val_vmotion): Now static.
11698 * image.c: Make symbols static if they're not exported.
11699 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11701 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11702 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11704 * fringe.c (standard_bitmaps): Now static.
11705 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11707 * frame.c: Make symbols static if they're not exported.
11708 (x_report_frame_params, make_terminal_frame): Now static.
11709 (get_frame_param): Now static, unless HAVE_NS.
11710 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11711 (x_get_resource_string): Remove; not used.
11712 * frame.h (make_terminal_frame, x_report_frame_params):
11713 (x_get_resource_string); Remove decls.
11714 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11715 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11717 * font.c, fontset.c: Make symbols static if they're not exported.
11718 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11719 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11720 * font.c (font_close_object): Now static.
11721 * font.h (font_close_object): Remove.
11722 * fontset.c (FONTSET_OBJLIST): Remove.
11723 (free_realized_fontset) #if-0 the body, which does nothing.
11724 (face_suitable_for_char_p): #if-0, as it's never called.
11725 * fontset.h (face_suitable_for_char_p): Remove decl.
11726 * xfaces.c (face_at_string_position):
11727 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11728 since 0 is always ASCII.
11730 * fns.c (weak_hash_tables): Now static.
11732 * fileio.c: Make symbols static if they're not exported.
11733 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11734 (Vwrite_region_annotation_buffers): Now static.
11736 * eval.c: Make symbols static if they're not exported.
11737 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11738 * lisp.h (backtrace_list): Remove decl.
11740 * emacs.c: Make symbols static if they're not exported.
11741 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11742 (fatal_error_code, fatal_error_signal_hook, standard_args):
11744 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11745 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11746 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11747 * lisp.h (fatal_error_signal_hook): Remove decl.
11748 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11750 * editfns.c: Move a (normally-unused) function to its only use.
11751 * editfns.c, lisp.h (get_operating_system_release): Remove.
11752 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11753 worth the hassle of breaking this out.
11755 * xterm.c: Make symbols static if they're not exported.
11756 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11757 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11758 (x_destroy_window, x_delete_display):
11760 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11761 (x_mouse_leave): Remove; unused.
11762 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11763 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11764 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11766 (x_mouse_leave): Declare only if WINDOWSNT.
11767 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11768 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11771 * ftxfont.c: Make symbols static if they're not exported.
11772 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11774 * font.h (ftxfont_driver): Likewise.
11776 * xfns.c: Make symbols static if they're not exported.
11777 (x_last_font_name, x_display_info_for_name):
11778 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11779 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11780 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11781 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11782 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11783 (last_show_tip_args): Now static.
11784 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11785 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11786 (x_screen_planes): Remove; unused.
11787 * dispextern.h (x_screen_planes): Remove decl.
11789 * dispnew.c: Make symbols static if they're not exported.
11790 * dispextern.h (redraw_garbaged_frames, scrolling):
11791 (increment_row_positions): Remove.
11792 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11793 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11795 (redraw_garbaged_frames): Remove; unused.
11797 * xfaces.c: Make symbols static if they're not exported.
11798 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11800 * xterm.h (defined_color): Remove decls.
11801 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11802 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11803 (menu_face_changed_default, defined_color, free_realized_face):
11804 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11805 (ascii_face_of_lisp_face): Remove; unused.
11807 * xdisp.c: Make symbols static if they're not exported.
11808 * dispextern.h (scratch_glyph_row, window_box_edges):
11809 (glyph_to_pixel_coords, set_cursor_from_row):
11810 (get_next_display_element, set_iterator_to_next):
11811 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11812 (show_mouse_face): Remove decls
11813 * frame.h (message_buf_print): Likewise.
11814 * lisp.h (pop_message, set_message, check_point_in_composition):
11816 * xterm.h (set_vertical_scroll_bar): Likewise.
11817 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11818 (message_buf_print, scratch_glyph_row, displayed_buffer):
11819 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11820 (get_next_display_element, show_mouse_face, window_box_edges):
11821 (frame_to_window_pixel_xy, check_point_in_composition):
11822 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11823 (glyph_to_pixel_coords): Remove; unused.
11825 * dired.c (file_name_completion): Now static.
11827 * dbusbind.c (xd_in_read_queued_messages): Now static.
11829 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11830 * data.c (circular_list_error): Remove.
11832 * commands.h (last_point_position, last_point_position_buffer):
11833 (last_point_position_window): Remove decls.
11834 * keyboard.c: Make these variables static.
11836 * coding.h (coding, code_convert_region, encode_coding_gap):
11838 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11839 (iso_code_class, detect_coding, code_convert_region): Now static.
11840 (encode_coding_gap): Remove; unused.
11842 * chartab.c (chartab_chars, chartab_bits): Now static.
11844 * charset.h (charset_iso_8859_1): Remove decl.
11845 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11848 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11849 * ccl.c (Vccl_program_table): Now static.
11850 (check_ccl_update): Remove; unused.
11852 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11853 * category.h: ... from here.
11854 * category.c (check_category_table, set_category_set): Now static.
11856 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11857 * lisp.h: Remove these decls.
11859 * buffer.c (buffer_count): Remove unused var.
11861 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11862 so that it's not optimized away.
11863 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11864 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11865 exported only to the debugger.
11867 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11868 * atimer.h (run_all_atimers): Remove; not exported.
11870 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11871 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11872 was inaccessible from Lisp.
11873 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11874 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11876 alloc.c: Import and export fewer symbols, and remove unused items.
11877 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11879 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11880 it's not optimized away by whole-program optimization.
11881 (message_enable_multibyte, free_misc): Remove.
11882 (catchlist, handlerlist, mark_backtrace):
11883 Declare only if BYTE_MARK_STACK.
11884 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11885 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11886 (message_enable_multibyte): Remove decl.
11887 (free_misc, interval_free_list, float_block, float_block_index):
11888 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11889 (cons_free_list, last_marked_index):
11891 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11892 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11893 (mark_backtrace): Define only if BYTE_MARK_STACK.
11894 * xdisp.c (message_enable_multibyte): Now static.
11896 Declare Lisp_Object Q* variables to be 'static' if not exported.
11897 This makes it easier for human readers (and static analyzers)
11898 to see whether these variables are used from other modules.
11899 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11900 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11901 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11902 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11903 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11904 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11905 * xmenu.c, xselect.c:
11906 Declare Q* vars static if they are not used in other modules.
11907 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11908 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11909 Remove decls of unexported vars.
11910 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11912 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11914 Make Emacs functions such as Fatom 'static' by default.
11915 This makes it easier for human readers (and static analyzers)
11916 to see whether these functions can be called from other modules.
11917 DEFUN now defines a static function. To make the function external
11918 so that it can be used in other C modules, use the new macro DEFUE.
11919 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11920 (Finit_image_library):
11921 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11922 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11923 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11924 Remove decls, since these functions are now static.
11925 (Funintern, Fget_internal_run_time): New decls, since these functions
11926 were already external.
11928 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11929 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11930 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11931 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11932 * keyboard.c, keymap.c, lread.c:
11933 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11934 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11935 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11936 Mark functions with DEFUE instead of DEFUN,
11937 if they are used in other modules.
11938 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11939 decls for now-static functions.
11940 * buffer.h (Fdelete_overlay): Remove decl.
11941 * callproc.c (Fgetenv_internal): Mark as internal.
11942 * composite.c (Fremove_list_of_text_properties): Remove decl.
11943 (Fcomposition_get_gstring): New forward static decl.
11944 * composite.h (Fcomposite_get_gstring): Remove decl.
11945 * dired.c (Ffile_attributes): New forward static decl.
11946 * doc.c (Fdocumntation_property): New forward static decl.
11947 * eval.c (Ffetch_bytecode): New forward static decl.
11948 (Funintern): Remove extern decl; now in .h file where it belongs.
11949 * fileio.c (Fmake_symbolic_link): New forward static decl.
11950 * image.c (Finit_image_library): New forward static decl.
11951 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11952 * intervals.h (Fprevious_property_change):
11953 (Fremove_list_of_text_properties): Remove decls.
11954 * keyboard.c (Fthis_command_keys): Remove decl.
11955 (Fcommand_execute): New forward static decl.
11956 * keymap.c (Flookup_key): New forward static decl.
11957 (Fcopy_keymap): Now static.
11958 * keymap.h (Flookup_key): Remove decl.
11959 * process.c (Fget_process): New forward static decl.
11960 (Fprocess_datagram_address): Mark as internal.
11961 * syntax.c (Fsyntax_table_p): New forward static decl.
11962 (skip_chars): Remove duplicate decl.
11963 * textprop.c (Fprevious_property_change): New forward static decl.
11964 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11966 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11967 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11969 * editfns.c (Fformat): Remove unreachable code.
11971 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11973 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11976 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11978 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11979 when at ZV. (Bug#8487)
11981 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11983 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11985 * keyboard.c (parse_tool_bar_item): Likewise.
11986 * sound.c (sound_cleanup, alsa_close): Likewise.
11987 * termcap.c (tgetent): Likewise.
11988 * xfns.c (x_default_font_parameter): Likewise.
11989 * xsettings.c (read_and_apply_settings): Likewise.
11991 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11992 (overrun_check_free): Protoize.
11994 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11996 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11997 since callers should never pass a negative size.
11998 Change the signature to match that of plain 'read' and 'write'; see
11999 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12000 * lisp.h: Update prototypes of emacs_write and emacs_read.
12002 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12004 * xdisp.c (redisplay_window): Don't try to determine the character
12005 position of the scroll margin if the window start point w->startp
12006 is outside the buffer's accessible region. (Bug#8468)
12008 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12010 Fix write-region and its subroutines for buffers > 2GB.
12011 * fileio.c (a_write, e_write): Modify declaration of arguments and
12012 local variables to support buffers larger than 2GB.
12013 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12015 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12016 argument, local variables, and return value.
12018 * lisp.h: Update prototypes of emacs_write and emacs_read.
12020 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12022 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12024 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12026 Fix more problems found by GCC 4.6.0's static checks.
12028 * xdisp.c (vmessage): Use a better test for character truncation.
12030 * charset.c (load_charset_map): <, not <=, for optimization,
12031 and to avoid potential problems with integer overflow.
12032 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12033 * casetab.c (set_identity, shuffle): Likewise.
12034 * editfns.c (Fformat): Likewise.
12035 * syntax.c (skip_chars): Likewise.
12037 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12038 This also lets GCC 4.6.0 generate slightly better loop code.
12040 * callint.c (Fcall_interactively): <, not <=, for optimization.
12041 (Fcall_interactively): Count the number of arguments produced,
12042 not the number of arguments given. This is simpler and lets GCC
12043 4.6.0 generate slightly better code.
12045 * ftfont.c: Distingish more carefully between FcChar8 and char.
12046 The previous code passed unsigned char * to a functions like
12047 strlen and xstrcasecmp that expect char *, which does not
12048 conform to the C standard.
12049 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12050 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12051 char * when the C standard requires it.
12053 * keyboard.c (read_char): Remove unused var.
12055 * eval.c: Port to Windows vsnprintf (Bug#8435).
12056 Include <limits.h>.
12057 (SIZE_MAX): Define if the headers do not.
12058 (verror): Do not give up if vsnprintf returns a negative count.
12059 Instead, grow the buffer. This ports to Windows vsnprintf, which
12060 does not conform to C99. Problem reported by Eli Zaretskii.
12061 Also, simplify the allocation scheme, by avoiding the need for
12062 calling realloc, and removing the ALLOCATED variable.
12064 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12066 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12067 But keep the doprint source code for now, as we might revamp it
12068 and use it again (Bug#8435).
12069 * lisp.h (doprnt): Remove.
12070 * Makefile.in (base_obj): Remove doprnt.o.
12071 * deps.mk (doprnt.o): Remove.
12073 error: Print 32- and 64-bit integers portably (Bug#8435).
12074 Without this change, on typical 64-bit hosts error ("...%d...", N)
12075 was used to print both 32- and 64-bit integers N, which relied on
12076 undefined behavior.
12077 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12078 * lisp.h (error, verror): Mark as printf-like functions.
12079 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12080 Report overflow in size calculations when allocating printf buffer.
12081 Do not truncate output string at its first null byte.
12082 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12083 Truncate the output at a character boundary, since vsnprintf does not
12085 * charset.c (check_iso_charset_parameter): Convert internal
12086 character to string before calling 'error', since %c now has the
12088 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12089 overflow when computing char to be passed to 'error'. Do not
12090 pass Lisp_Object to 'error'; pass the integer instead.
12091 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12092 formatted with plain %d.
12094 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12096 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12098 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12100 * xterm.c (x_catch_errors): Remove duplicate declaration.
12102 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12104 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12106 2011-04-10 Jim Meyering <meyering@redhat.com>
12108 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12109 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12110 return ssize_t not "int", and use size_t as the buffer length.
12111 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12112 * gnutls.h: Update declarations.
12113 * process.c (read_process_output): Use ssize_t, to match.
12114 (send_process): Likewise.
12116 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12118 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12120 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12122 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12123 Use unsigned char, to match FcChar8 type definition.
12125 * xterm.c (handle_one_xevent):
12126 * xmenu.c (create_and_show_popup_menu):
12127 * xselect.c (x_decline_selection_request)
12128 (x_reply_selection_request): Avoid type-punned deref of X events.
12130 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12132 Fix some uses of `int' instead of EMACS_INT.
12133 * search.c (string_match_1, fast_string_match)
12134 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12135 (scan_buffer, find_next_newline_no_quit)
12136 (find_before_next_newline, search_command, Freplace_match)
12137 (Fmatch_data): Make some `int' variables be EMACS_INT.
12139 * xdisp.c (display_count_lines): 3rd argument and return value now
12140 EMACS_INT. All callers changed.
12141 (pint2hrstr): Last argument is now EMACS_INT.
12143 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12144 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12145 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12146 (decode_coding_utf_16, decode_coding_emacs_mule)
12147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12148 (decode_coding_ccl, decode_coding_charset)
12149 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12150 (decode_coding_iso_2022, decode_coding_emacs_mule)
12151 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12152 <char_offset, last_offset>: Declare EMACS_INT.
12153 (encode_coding_utf_8, encode_coding_utf_16)
12154 (encode_coding_emacs_mule, encode_invocation_designation)
12155 (encode_designation_at_bol, encode_coding_iso_2022)
12156 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12157 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12159 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12160 (encode_invocation_designation): Last argument P_NCHARS is now
12162 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12163 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12165 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12168 * ccl.c (Fccl_execute_on_string): Declare some variables
12171 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12173 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12175 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12177 * process.c (Fformat_network_address): Doc fix.
12179 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12181 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12183 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12185 * keyboard.c (read_char): Call Lisp function help-form-show,
12186 instead of using internal_with_output_to_temp_buffer.
12187 (Qhelp_form_show): New var.
12188 (syms_of_keyboard): Use DEFSYM macro.
12190 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12192 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12194 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12196 * process.c (Flist_processes): Remove to Lisp.
12197 (list_processes_1): Delete.
12199 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12201 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12203 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12205 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12207 Fix more problems found by GCC 4.6.0's static checks.
12209 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12211 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12213 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12215 * xdisp.c (vmessage): Mark as a printf-like function.
12217 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12219 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12221 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12222 printf-like functions.
12223 (tiff_load): Add casts to remove these marks before passing them
12224 to system-supplied API.
12226 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12228 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12229 This avoids several warnings with gcc -Wstrict-overflow.
12230 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12231 directly, rather than having caller test rule sign. This avoids
12232 some unnecessary tests.
12233 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12234 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12235 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12237 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12238 (xfont_open): Avoid unnecessary tests.
12240 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12242 * composite.h, composite.c (composition_gstring_put_cache):
12243 Use EMACS_INT, not int, for length.
12245 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12246 breaking out part of COMPOSITION_DECODE_RULE.
12247 (COMPOSITION_DECODE_RULE): Use it.
12248 * composite.c (get_composition_id): Remove unused local vars,
12249 by using the new macro.
12251 * textprop.c (set_text_properties_1): Change while to do-while,
12252 since the condition is always true at first.
12254 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12255 (interval_deletion_adjustment): Return unsigned value.
12258 * process.c (list_processes_1, create_pty, read_process_output):
12259 (exec_sentinel): Remove vars that were set but not used.
12260 (create_pty): Remove unnecessary "volatile"s.
12261 (Fnetwork_interface_info): Avoid possibility of int overflow.
12262 (read_process_output): Do adaptive read buffering even if carryover.
12263 (read_process_output): Simplify nbytes computation if buffered.
12265 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12267 * syntax.c (scan_words): Remove var that was set but not used.
12268 (update_syntax_table): Use unsigned instead of int.
12270 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12271 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12272 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12274 * print.c (print_error_message): Avoid int overflow.
12276 * font.c (font_list_entities): Redo for clarity,
12277 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12279 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12280 (font_score): Avoid potential overflow in diff calculation.
12282 * fns.c (substring_both): Remove var that is set but not used.
12283 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12285 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12287 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12288 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12289 can always succeed if overflow has undefined behavior.
12291 * search.c (boyer_moore, wordify): Remove vars set but not used.
12292 (wordify): Omit three unnecessary tests.
12294 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12295 All callers changed. This avoids the need for an unused var.
12297 * casefiddle.c (casify_region): Remove var that is set but not used.
12299 * dired.c (file_name_completion): Remove var that is set but not used.
12301 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12303 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12304 (Finsert_file_contents): Remove unnecessary code checking fd.
12306 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12307 Check for integer overflow on size calculations.
12309 * buffer.c (Fprevious_overlay_change): Remove var that is set
12312 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12313 Remove vars that are set but not used.
12314 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12315 (timer_check_2): Mark vars as initialized.
12317 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12319 * image.c (lookup_image): Remove var that is set but not used.
12320 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12322 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12323 that are set but not used.
12325 * xfns.c (make_invisible_cursor): Don't return garbage
12326 if XCreateBitmapFromData fails (Bug#8410).
12328 * xselect.c (x_get_local_selection, x_handle_property_notify):
12329 Remove vars that are set but not used.
12331 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12332 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12334 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12335 Remove var that is set but not used.
12336 (scroll_bar_windows_size): Now size_t, not int.
12337 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12338 Check for overflow.
12340 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12341 (map_tty_color) [!defined MSDOS]: Likewise.
12343 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12345 * coding.c: Remove vars that are set but not used.
12346 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12347 All callers changed.
12348 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12349 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12350 (decode_coding_charset): Remove vars that are set but not used.
12352 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12353 that is set but not used.
12355 * print.c (print_object): Remove var that is set but not used.
12357 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12358 The gnulib version avoids calling malloc in the usual case,
12359 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12360 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12361 * filelock.c (current_lock_owner): Likewise.
12362 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12363 * sysdep.c: Include allocator.h, careadlinkat.h.
12364 (emacs_no_realloc_allocator): New static constant.
12365 (emacs_readlink): New function.
12366 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12367 ../lib/careadlinkat.h.
12369 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12371 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12372 first non-nil return value).
12374 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12376 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12377 if not defined (Bug#8403).
12379 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12381 * xdisp.c (display_count_lines): Remove parameter `start',
12382 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12383 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12384 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12385 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12386 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12387 and thereabouts. All callers changed.
12388 (get_per_char_metric): Remove parameter `f', unused since
12389 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12391 2011-04-02 Jim Meyering <meyering@redhat.com>
12393 do not dereference NULL upon failed strdup
12394 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12395 (ns_get_family): Likewise.
12397 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12399 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12401 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12403 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12406 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12408 Add lexical binding.
12410 * window.c (Ftemp_output_buffer_show): New fun.
12411 (Fsave_window_excursion):
12412 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12414 * lread.c (lisp_file_lexically_bound_p): New function.
12415 (Fload): Bind Qlexical_binding.
12416 (readevalloop): Remove `evalfun' arg.
12417 Bind Qinternal_interpreter_environment.
12418 (Feval_buffer): Bind Qlexical_binding.
12419 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12421 (syms_of_lread): Declare `lexical-binding'.
12423 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12425 * keyboard.c (eval_dyn): New fun.
12426 (menu_item_eval_property): Use it.
12428 * image.c (parse_image_spec): Use Ffunctionp.
12430 * fns.c (concat, mapcar1): Accept byte-code-functions.
12432 * eval.c (Fsetq): Handle lexical vars.
12433 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12434 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12435 (FletX, Flet): Obey lexical binding.
12436 (Fcommandp): Handle closures.
12437 (Feval): New `lexical' arg.
12438 (eval_sub): New function extracted from Feval. Use it almost
12439 everywhere where Feval was used. Look up vars in lexical env.
12441 (Ffunctionp): Move from subr.el.
12442 (Ffuncall): Handle closures.
12443 (apply_lambda): Remove `eval_flags'.
12444 (funcall_lambda): Handle closures and new byte-code-functions.
12445 (Fspecial_variable_p): New function.
12446 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12447 but without exporting it to Lisp.
12449 * doc.c (Fdocumentation, store_function_docstring):
12450 * data.c (Finteractive_form): Handle closures.
12452 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12455 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12457 (exec_byte_code): New function extracted from Fbyte_code to handle new
12458 calling convention for byte-code-functions. Add new byte-codes.
12460 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12462 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12464 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12466 * xdisp.c (redisplay_internal): Fix prototype.
12468 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12470 * xdisp.c (SCROLL_LIMIT): New macro.
12471 (try_scrolling): Use it when setting scroll_limit.
12472 Limit scrolling to 100 screen lines.
12473 (redisplay_window): Even when falling back on "recentering",
12474 position point in the window according to scroll-conservatively,
12475 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12477 (try_scrolling): When point is above the window, allow searching
12478 as far as scroll_max, or one screenful, to compute vertical
12479 distance from PT to the scroll margin position. This prevents
12480 try_scrolling from unnecessarily failing when
12481 scroll-conservatively is set to a value slightly larger than the
12482 window height. Clean up the case of PT below the margin at bottom
12483 of window: scroll_max can no longer be INT_MAX. When aggressive
12484 scrolling is in use, don't let point enter the opposite scroll
12485 margin as result of the scroll.
12486 (syms_of_xdisp) <scroll-conservatively>: Document the
12487 threshold of 100 lines for never-recentering scrolling.
12489 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12491 * dispextern.h (move_it_by_lines):
12492 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12493 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12494 (message_log_check_duplicate): Remove parameters `prev_bol' and
12495 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12496 (redisplay_internal): Remove parameter `preserve_echo_area',
12497 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12499 * indent.c (Fvertical_motion):
12500 * window.c (window_scroll_pixel_based, Frecenter):
12501 Don't pass `need_y_p' to `move_it_by_lines'.
12503 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12505 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12506 steal a few bits to be more compact.
12507 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12508 Remove unneeded casts.
12510 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12512 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12514 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12515 binding" message (bug#7967).
12517 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12519 Fix more problems found by GCC 4.6.0's static checks.
12521 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12522 Remove unused local var.
12524 * editfns.c (Fmessage_box): Remove unused local var.
12526 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12527 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12528 Omit unused local vars.
12529 * window.c (shrink_windows): Omit unused local var.
12530 * menu.c (digest_single_submenu): Omit unused local var.
12531 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12532 Omit unused local var.
12534 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12535 Don't assume string length fits in int.
12536 (keyremap_step, read_key_sequence): Use size_t for sizes.
12537 (read_key_sequence): Don't check last_real_key_start redundantly.
12539 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12540 instead of alloca (Bug#8344).
12542 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12543 (Fbacktrace_frame): Don't assume nframes fits in int.
12545 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12547 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12550 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12552 * cm.c (calccost): Turn while-do into do-while, for clarity.
12554 * keyboard.c (syms_of_keyboard): Use the same style as later
12555 in this function when indexing through an array. This also
12556 works around GCC bug 48267.
12558 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12560 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12562 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12563 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12565 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12566 This avoids undefined behavior on integer overflow, and is a bit
12567 more convenient anyway since it is compared to a size_t variable.
12569 Variadic C functions now count arguments with size_t, not int.
12570 This avoids an unnecessary limitation on 64-bit machines, which
12571 caused (substring ...) to crash on large vectors (Bug#8344).
12572 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12573 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12574 All variadic functions and their callers changed accordingly.
12575 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12576 * data.c (arith_driver, float_arith_driver): Likewise.
12577 * editfns.c (general_insert_function): Likewise.
12578 * eval.c (struct backtrace.nargs, interactive_p)
12579 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12580 (funcall_lambda, mark_backtrace): Likewise.
12581 * fns.c (concat): Likewise.
12582 * frame.c (x_set_frame_parameters): Likewise.
12583 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12584 0 if not found, not -1. All callers changed.
12586 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12587 (stack_copy_size): Now size_t, not int.
12588 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12590 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12592 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12593 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12594 All callers changed.
12596 * lisp.h (multibyte_char_to_unibyte):
12597 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12598 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12599 * character.h (CHAR_TO_BYTE8):
12600 * cmds.c (internal_self_insert):
12601 * editfns.c (general_insert_function):
12602 * keymap.c (push_key_description):
12603 * search.c (Freplace_match):
12604 * xdisp.c (message_dolog, set_message_1): All callers changed.
12606 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12608 * keyboard.c (safe_run_hook_funcall): New function.
12609 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12610 don't set the hook to nil, but remove the offending function instead.
12611 (Qcommand_hook_internal): Remove, unused.
12612 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12613 Vcommand_hook_internal.
12615 * eval.c (enum run_hooks_condition): Remove.
12616 (funcall_nil, funcall_not): New functions.
12617 (run_hook_with_args): Call each function through a `funcall' argument.
12618 Remove `cond' argument, now redundant.
12619 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12620 (Frun_hook_with_args_until_failure): Adjust accordingly.
12621 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12623 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12625 * dispextern.h (string_buffer_position): Remove declaration.
12627 * print.c (strout): Remove parameter `multibyte', unused since
12628 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12630 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12631 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12632 All callers changed.
12634 * w32.c (_wsa_errlist): Use braces for struct initializers.
12636 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12637 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12638 All callers changed.
12639 (string_buffer_position): Likewise. Also, make static (it's never
12640 used outside xdisp.c).
12641 (cursor_row_p): Remove parameter `w', unused since
12642 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12643 (decode_mode_spec): Remove parameter `precision', introduced during
12644 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12645 All callers changed.
12647 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12649 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12651 2011-03-27 Anders Lindgren <andlind@gmail.com>
12653 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12654 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12655 (ns_update_auto_hide_menu_bar): New functions.
12656 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12657 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12658 ns_constrain_all_frames.
12659 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12660 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12662 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12664 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12666 2011-03-27 Glenn Morris <rgm@gnu.org>
12668 * syssignal.h: Replace RETSIGTYPE with void.
12669 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12670 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12671 Replace SIGTYPE with void everywhere.
12672 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12673 * s/template.h (SIGTYPE): Remove commented out definition.
12675 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12677 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12678 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12680 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12682 * w32.c (read_unc_volume): Use parameter `henum', instead of
12683 global variable `wget_enum_handle'.
12685 * keymap.c (describe_vector): Remove parameters `indices' and
12686 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12687 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12689 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12691 * keyboard.c (timer_check): Remove parameter `do_it_now',
12692 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12693 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12694 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12696 * keyboard.c (read_char):
12697 * w32menu.c (w32_menu_display_help):
12698 * xmenu.c (show_help_event, menu_help_callback):
12699 Adjust calls to `show_help_echo'.
12701 * gtkutil.c (xg_maybe_add_timer):
12702 * keyboard.c (readable_events):
12703 * process.c (wait_reading_process_output):
12704 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12706 * insdel.c (adjust_markers_gap_motion):
12707 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12708 (gap_left, gap_right): Don't call it.
12710 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12712 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12713 incurred during fontification.
12715 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12717 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12718 (DEFVAR_PER_BUFFER): Don't pass it.
12720 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12721 (scrolling_window): Don't pass it.
12723 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12725 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12727 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12729 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12730 of variables specific to SELinux and computation of `encoded_absname'.
12732 * image.c (XPutPixel): Remove unused variable `height'.
12734 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12736 * unexw32.c (get_section_info): Remove unused variable `section'.
12738 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12739 (system_process_attributes): Remove unused variable `sess'.
12740 (sys_read): Remove unused variable `err'.
12742 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12743 (w32_wnd_proc): Remove unused variable `isdead'.
12744 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12745 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12746 (x_create_tip_frame): Remove unused variable `tem'.
12748 * w32inevt.c (w32_console_read_socket):
12749 Remove unused variable `no_events'.
12751 * w32term.c (x_draw_composite_glyph_string_foreground):
12752 Remove unused variable `width'.
12754 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12756 * w32term.c (x_set_glyph_string_clipping):
12757 Don't pass uninitialized region to CombineRgn.
12759 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12761 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12762 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12763 (Fx_close_connection): Remove unused variable `i'.
12765 * w32font.c (w32font_draw): Return number of glyphs.
12766 (w32font_open_internal): Remove unused variable `i'.
12767 (w32font_driver): Add missing initializer.
12769 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12770 (fill_in_menu): Remove unused variable `items_added'.
12772 * w32term.c (last_mouse_press_frame): Remove static global variable.
12773 (w32_clip_to_row): Remove unused variable `f'.
12774 (x_delete_terminal): Remove unused variable `i'.
12776 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12777 (NOTHING): Remove unused static global variable.
12778 (uniscribe_check_otf): Remove unused variable `table'.
12779 (uniscribe_font_driver): Add missing initializers.
12781 2011-03-23 Julien Danjou <julien@danjou.info>
12783 * term.c (Fsuspend_tty, Fresume_tty):
12784 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12785 * window.c (temp_output_buffer_show):
12786 * insdel.c (signal_before_change):
12787 * frame.c (Fhandle_switch_frame):
12788 * fileio.c (Fdo_auto_save):
12789 * emacs.c (Fkill_emacs):
12790 * editfns.c (save_excursion_restore):
12791 * cmds.c (internal_self_insert):
12792 * callint.c (Fcall_interactively):
12793 * buffer.c (Fkill_all_local_variables):
12794 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12796 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12797 unconditionally since it does the check itself.
12799 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12801 Fix more problems found by GCC 4.5.2's static checks.
12803 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12804 the first time through the loop, since we know p0 < p1 then.
12805 This also avoids a gcc -Wstrict-overflow warning.
12807 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12808 leading to a memory leak, possible in functions like
12809 load_charset_map_from_file that can allocate an unbounded number
12810 of objects (Bug#8318).
12812 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12813 that could (at least in theory) be that large.
12815 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12816 This is less likely to overflow, and avoids undefined behavior if
12817 overflow does occur. All callers changed. Use strtoul to scan
12818 for the unsigned long integer.
12819 (pint2hrstr): Simplify and tune code slightly.
12820 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12822 * scroll.c (do_scrolling): Work around GCC bug 48228.
12823 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12825 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12826 This also avoids a warning with gcc -Wstrict-overflow.
12827 (validate_x_resource_name): Simplify count usage.
12828 This also avoids a warning with gcc -Wstrict-overflow.
12830 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12833 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12835 * process.c (Fmake_network_process): Use socklen_t, not int,
12836 where POSIX says socklen_t is required in portable programs.
12837 This fixes a porting bug on hosts like 64-bit HP-UX, where
12838 socklen_t is wider than int (Bug#8277).
12839 (Fmake_network_process, server_accept_connection):
12840 (wait_reading_process_output, read_process_output):
12843 * process.c: Rename or move locals to avoid shadowing.
12844 (list_processes_1, Fmake_network_process):
12845 (read_process_output_error_handler, exec_sentinel_error_handler):
12846 Rename or move locals.
12847 (Fmake_network_process): Define label "retry_connect" only if needed.
12848 (Fnetwork_interface_info): Fix pointer signedness.
12849 (process_send_signal): Add cast to avoid pointer signedness problem.
12850 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12851 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12853 Make tparam.h and terminfo.c consistent.
12854 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12855 Include tparam.h instead, since it declares them.
12856 * cm.h (PC): Remove extern decl; tparam.h now does this.
12857 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12858 * terminfo.c: Include tparam.h, to check interfaces.
12859 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12860 (tparam): Adjust signature to match interface in tparam.h;
12861 this removes some undefined behavior. Check that outstring and len
12862 are zero, which they always are with Emacs.
12863 * tparam.h (PC, BC, UP): New extern decls.
12865 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12866 (xftfont_open): Rename locals to avoid shadowing.
12868 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12869 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12870 (OTF_TAG_SYM): Omit macro if not needed.
12871 (ftfont_list): Remove unused local.
12872 (get_adstyle_property, ftfont_pattern_entity):
12873 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12874 Rename locals to avoid shadowing.
12876 * xfont.c (xfont_list_family): Mark var as initialized.
12878 * xml.c (make_dom): Now static.
12880 * composite.c (composition_compute_stop_pos): Rename local to
12882 (composition_reseat_it): Remove unused locals.
12883 (find_automatic_composition, composition_adjust_point): Likewise.
12884 (composition_update_it): Mark var as initialized.
12885 (find_automatic_composition): Mark vars as initialized,
12886 with a FIXME (Bug#8290).
12888 character.h: Rename locals to avoid shadowing.
12889 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12890 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12891 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12892 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12893 to avoid shadowing.
12895 * textprop.c (property_change_between_p): Remove; unused.
12897 * intervals.c (interval_start_pos): Now static.
12899 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12901 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12902 Rename locals to avoid shadowing.
12904 * sound.c (wav_play, au_play, Fplay_sound_internal):
12905 Fix pointer signedness.
12906 (alsa_choose_format): Remove unused local var.
12907 (wav_play): Initialize a variable to 0, to prevent undefined
12908 behavior (Bug#8278).
12910 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12912 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12914 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12915 clobbering (Bug#8298).
12916 * sysdep.c (sys_subshell): Likewise.
12917 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12919 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12920 This should get cleaned up, so that child_setup has the
12921 same signature on all platforms.
12923 * callproc.c (call_process_cleanup): Now static.
12924 (relocate_fd): Rename locals to avoid shadowing.
12926 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12928 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12929 not to be necessary, and produces flickering.
12931 2011-03-20 Glenn Morris <rgm@gnu.org>
12933 * config.in: Remove file.
12935 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12937 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12938 are now in src/globals.h.
12939 (syms_of_minibuf): Remove spurious & from previous change.
12941 2011-03-20 Leo Liu <sdl.web@gmail.com>
12943 * minibuf.c (completing-read-function): New variable.
12944 (completing-read-default): Rename from completing-read.
12945 (completing-read): Call completing-read-function.
12947 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12949 * xfaces.c (Fx_load_color_file):
12950 Read color file from absolute filename (bug#8250).
12952 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12954 * makefile.w32-in: Update dependencies.
12956 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12958 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12960 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12962 Fix more problems found by GCC 4.5.2's static checks.
12964 * process.c (make_serial_process_unwind, send_process_trap):
12965 (sigchld_handler): Now static.
12967 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12968 That way, the code declares only the vars that it needs.
12969 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12970 * s/cygwin.h (PTY_ITERATION): Likewise.
12971 * s/darwin.h (PTY_ITERATION): Likewise.
12972 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12974 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12975 * process.c (allocate_pty): Don't declare stb unless it's needed.
12977 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12978 (CONSTANTLIM): Remove; unused.
12979 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12980 Define only if needed.
12982 * unexelf.c (unexec): Name an expression,
12983 to avoid gcc -Wbad-function-cast warning.
12984 Use a different way to cause a compilation error if anyone uses
12985 n rather than nn, a way that does not involve shadowing.
12986 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12988 * deps.mk (unexalpha.o): Remove; unused.
12990 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12991 * unexec.h: New file.
12992 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12993 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12994 Depend on unexec.h.
12995 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12996 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12997 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12998 Change as necessary to match prototype in unexec.h.
13000 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13002 (back_comment, skip_chars): Mark vars as initialized.
13004 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13005 Rename locals to avoid shadowing.
13007 * lread.c (read1): Rewrite so as not to use empty "else".
13008 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13010 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13012 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13013 warning when compiling print.c.
13015 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13016 instead of using an uninitialized var.
13017 (font_sort_entities): Mark var as initialized.
13019 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13021 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13022 pointers to constants.
13023 (font_parse_fcname): Remove unused vars.
13024 (font_delete_unmatched): Now static.
13025 (font_get_spec): Remove; unused.
13026 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13027 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13028 Rename or move locals to avoid shadowing.
13030 * fns.c (require_nesting_list, require_unwind): Now static.
13031 (Ffillarray): Rename locals to avoid shadowing.
13033 * floatfns.c (domain_error2): Define only if needed.
13034 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13036 * alloc.c (mark_backtrace): Move decl from here ...
13037 * lisp.h: ... to here, so that it can be checked.
13039 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13040 (Fdefvar): Rewrite so as not to use empty "else".
13041 (lisp_indirect_variable): Name an expression,
13042 to avoid gcc -Wbad-function-cast warning.
13043 (Fdefvar): Rename locals to avoid shadowing.
13045 * callint.c (quotify_arg, quotify_args): Now static.
13046 (Fcall_interactively): Rename locals to avoid shadowing.
13047 Use const pointer when appropriate.
13049 * lisp.h (get_system_name, get_operating_system_release):
13050 Move decls here, to check interfaces.
13051 * process.c (get_operating_system_release): Move decl to lisp.h.
13052 * xrdb.c (get_system_name): Likewise.
13053 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13054 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13055 some of which prompt warnings from gcc -Wbad-function-cast.
13056 (Fformat_time_string, Fencode_time, Finsert_char):
13057 (Ftranslate_region_internal, Fformat):
13058 Rename or remove local vars to avoid shadowing.
13059 (Ftranslate_region_internal): Mark var as initialized.
13061 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13064 * lisp.h (eassert): Check that the argument compiles, even if
13065 ENABLE_CHECKING is not defined.
13067 * data.c (Findirect_variable): Name an expression, to avoid
13068 gcc -Wbad-function-cast warning.
13069 (default_value, arithcompare, arith_driver, arith_error): Now static.
13070 (store_symval_forwarding): Rename local to avoid shadowing.
13071 (Fmake_variable_buffer_local, Fmake_local_variable):
13072 Mark variables as initialized.
13073 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13075 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13076 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13077 Rename locals to avoid shadowing.
13078 (mark_stack): Move local variables into the #ifdef region where
13080 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13081 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13083 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13084 (GC_STRING_CHARS): Remove; not used.
13085 (Fmemory_limit): Cast sbrk's returned value to char *.
13087 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13088 avoids undefined behavior in theory.
13090 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13092 Use functions, not macros, for up- and down-casing (Bug#8254).
13093 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13095 to use the following functions instead of these macros.
13096 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13097 EMACS_INT, since callers assume the returned value fits in int.
13098 (upcase1): Likewise, for UPCASE_TABLE.
13099 (uppercasep, lowercasep, upcase): New static inline functions.
13100 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13101 the race-condition problem in the old DOWNCASE.
13103 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13104 Rename locals to avoid shadowing.
13105 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13106 (regex_compile, re_search_2, re_match_2_internal):
13107 Remove unused local vars.
13108 (FREE_VAR): Rewrite so as not to use empty "else",
13109 which gcc can warn about.
13110 (regex_compile, re_match_2_internal): Mark locals as initialized.
13111 (RETALLOC_IF): Define only if needed.
13112 (WORDCHAR_P): Likewise. This one is never needed, but is used
13113 only in a comment talking about a compiler bug, so put inside
13114 the #if 0 of that comment.
13115 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13116 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13119 * search.c (boyer_moore): Rename locals to avoid shadowing.
13120 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13121 (PREV_CHAR_BOUNDARY): Likewise.
13123 * search.c (simple_search): Remove unused var.
13125 * dired.c (compile_pattern): Move decl from here ...
13126 * lisp.h: ... to here, so that it can be checked.
13127 (struct re_registers): New forward decl.
13129 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13131 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13133 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13134 Rename locals to avoid shadowing.
13135 (Fvertical_motion): Mark locals as initialized.
13137 * casefiddle.c (casify_object, casify_region): Now static.
13138 (casify_region): Mark local as initialized.
13140 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13142 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13143 New macros, so that the caller can use some names other than
13144 gcpro1, gcpro2, etc.
13145 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13147 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13148 argument, for consistency with GCPRO2_VAR, etc: it is now the
13149 prefix of the variable, not the variable itself. All uses
13151 * dired.c (directory_files_internal, file_name_completion):
13152 Rename locals to avoid shadowing.
13154 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13155 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13156 dired.c's scmp function, had undefined behavior.
13157 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13159 * buffer.h: ... to here, because these macros use current_buffer,
13160 and the new implementation with inline functions needs to have
13161 current_buffer in scope now, rather than later when the macros
13163 (downcase, upcase1): New static inline functions.
13164 (DOWNCASE, UPCASE1): Reimplement using these functions.
13165 This avoids undefined behavior in expressions like
13166 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13167 from race conditions in accessing the global variables
13168 case_temp1 and case_temp2.
13169 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13170 * lisp.h (case_temp1, case_temp2): Remove their decls.
13171 * character.h (ASCII_CHAR_P): Move from here ...
13172 * lisp.h: ... to here, so that the inline functions mentioned
13173 above can use them.
13175 * dired.c (directory_files_internal_unwind): Now static.
13177 * fileio.c (file_name_as_directory, directory_file_name):
13178 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13180 (file_name_as_directory): Use const pointers when appropriate.
13181 (Fexpand_file_name): Likewise. In particular, newdir might
13182 point at constant storage, so make it a const pointer.
13183 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13184 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13186 (Fset_file_times, Finsert_file_contents, auto_save_error):
13187 Rename locals to avoid shadowing.
13189 * minibuf.c (choose_minibuf_frame_1): Now static.
13190 (Ftry_completion, Fall_completions): Rename or remove locals
13191 to avoid shadowing.
13193 * marker.c (bytepos_to_charpos): Remove; unused.
13195 * lisp.h (verify_bytepos, count_markers): New decls,
13196 so that gcc does not warn that these functions aren't declared.
13198 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13199 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13200 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13201 (copy_text): Remove unused local var.
13203 * filelock.c (within_one_second): Now static.
13204 (lock_file_1): Rename local to avoid shadowing.
13206 * buffer.c (fix_overlays_before): Mark locals as initialized.
13207 (fix_start_end_in_overlays): Likewise. This function should be
13208 simplified by using pointers-to-pointers, but that's a different
13210 (switch_to_buffer_1): Now static.
13211 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13212 (report_overlay_modification): Rename locals to avoid shadowing.
13214 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13215 Fix pointer signedness issue.
13216 (sys_subshell): Mark local as volatile if checking for lint,
13217 to suppress a gcc -Wclobbered warning that does not seem to be right.
13218 (MAXPATHLEN): Define only if needed.
13220 * process.c (serial_open, serial_configure): Move decls from here ...
13221 * systty.h: ... to here, so that they can be checked.
13223 * fns.c (get_random, seed_random): Move extern decls from here ...
13224 * lisp.h: ... to here, so that they can be checked.
13226 * sysdep.c (reset_io): Now static.
13227 (wait_for_termination_signal): Remove; unused.
13229 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13230 (copy_keymap_item, append_key, push_text_char_description):
13232 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13233 (DENSE_TABLE_SIZE): Remove; unused.
13234 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13235 (describe_map_tree):
13236 Rename locals to avoid shadowing.
13238 * keyboard.c: Declare functions static if they are not used elsewhere.
13239 (echo_char, echo_dash, cmd_error, top_level_2):
13240 (poll_for_input, handle_async_input): Now static.
13241 (read_char, kbd_buffer_get_event, make_lispy_position):
13242 (make_lispy_event, make_lispy_movement, apply_modifiers):
13243 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13244 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13245 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13246 (read_key_sequence, read_char): Mark locals as initialized.
13247 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13249 * keyboard.h (make_ctrl_char): New decl.
13250 (mark_kboards): Move decl here ...
13251 * alloc.c (mark_kboards): ... from here.
13253 * lisp.h (force_auto_save_soon): New decl.
13255 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13256 (DEFINE_DUMMY_FUNCTION): New macro.
13257 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13259 (main): Add casts to avoid warnings
13260 if GCC considers string literals to be constants.
13262 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13264 * dbusbind.c: Pointer signedness fixes.
13265 (xd_signature, xd_append_arg, xd_initialize):
13266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13267 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13268 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13269 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13271 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13272 if GCC considers string literals to be constants.
13273 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13275 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13277 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13278 (print_preprocess, print_object): New macro to fix last change.
13280 * print.c (print_preprocess): Don't forget font objects.
13282 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13284 * emacs.c (USAGE3): Doc fixes.
13286 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13288 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13291 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13293 * lisp.h (VWindow_system, Qfile_name_history):
13294 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13295 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13296 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13298 * w32select.c: Don't #include "keyboard.h".
13299 (run_protected): Add extern declaration for waiting_for_input.
13301 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13302 * w32console.c (detect_input_pending, read_input_pending)
13303 (encode_terminal_code):
13304 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13305 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13306 (w32_system_caret_y, Qfile_name_history):
13307 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13308 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13309 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13310 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13311 * w32proc.c (Qlocal, report_file_error):
13312 * w32term.c (Vwindow_system, updating_frame):
13313 * w32uniscribe.c (initialized, uniscribe_font_driver):
13314 Remove unneeded extern declarations.
13316 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13318 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13320 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13322 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13323 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13324 These macros can no longer be used for assignment.
13326 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13327 Assign struct members directly, instead of using BUF_BEGV etc.
13328 (record_buffer_markers, fetch_buffer_markers): New functions for
13329 recording and fetching special buffer markers.
13330 (set_buffer_internal_1, set_buffer_temp): Use them.
13332 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13334 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13336 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13337 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13339 * xdisp.c (hscroll_window_tree):
13340 (reconsider_clip_changes): Use PT instead of BUF_PT.
13342 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13344 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13345 $(EMACS_ROOT)/lib/intprops.h.
13347 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13349 Fix more problems found by GCC 4.5.2's static checks.
13351 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13352 to unsigned char * to avoid compiler diagnostic.
13353 (xg_free_frame_widgets): Make it clear that a local variable is
13354 needed only if USE_GTK_TOOLTIP.
13355 (gdk_window_get_screen): Make it clear that this macro is needed
13356 only if USE_GTK_TOOLTIP.
13357 (int_gtk_range_get_value): New function, which avoids a diagnostic
13358 from gcc -Wbad-function-cast.
13359 (xg_set_toolkit_scroll_bar_thumb): Use it.
13360 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13361 diagnostic from gcc -Wbad-function-cast.
13362 (get_utf8_string, xg_get_file_with_chooser):
13363 Rename locals to avoid shadowing.
13364 (create_dialog): Move locals to avoid shadowing.
13366 * xgselect.c (xg_select): Remove unused var.
13368 * image.c (four_corners_best): Mark locals as initialized.
13369 (gif_load): Initialize transparent_p to zero (Bug#8238).
13370 Mark another local as initialized.
13371 (my_png_error, my_error_exit): Mark with NO_RETURN.
13373 * image.c (clear_image_cache): Now static.
13374 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13375 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13376 (x_edge_detection): Remove unnecessary cast that
13377 gcc -Wbad-function-cast diagnoses.
13378 (gif_load): Fix pointer signedness.
13379 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13380 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13382 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13384 Improve quality of tests for time stamp overflow.
13385 For example, without this patch (encode-time 0 0 0 1 1
13386 1152921504606846976) returns the obviously-bogus value (-948597
13387 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13388 reports time overflow. See
13389 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13390 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13391 * editfns.c: Include limits.h and intprops.h.
13392 (TIME_T_MIN, TIME_T_MAX): New macros.
13393 (time_overflow): Move earlier, to before first use.
13394 (hi_time, lo_time): New functions, for an accurate test for
13395 out-of-range times.
13396 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13397 (Fget_internal_run_time): Don't assume time_t fits in int.
13398 (make_time): Use list2 instead of Fcons twice.
13399 (Fdecode_time): More accurate test for out-of-range times.
13400 (check_tm_member): New function.
13401 (Fencode_time): Use it, to test for out-of-range times.
13402 (lisp_time_argument): Don't rely on undefined left-shift and
13403 right-shift behavior when checking for time stamp overflow.
13405 * editfns.c (time_overflow): New function, refactoring common code.
13406 (Fformat_time_string, Fdecode_time, Fencode_time):
13407 (Fcurrent_time_string): Use it.
13409 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13410 * dired.c (make_time): Move to ...
13411 * editfns.c (make_time): ... here.
13412 * systime.h: Note the move.
13414 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13416 * fringe.c (update_window_fringes): Remove unused variables.
13418 * unexmacosx.c (copy_data_segment): Also copy __got section.
13421 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13423 * termcap.c [MSDOS]: Include "msdos.h".
13424 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13425 Constify `char *' arguments and their references according to
13426 prototypes in tparam.h.
13428 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13430 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13431 Adapt all references accordingly.
13433 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13435 2011-03-11 Tom Tromey <tromey@redhat.com>
13437 * buffer.c (syms_of_buffer): Remove obsolete comment.
13439 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13441 * termhooks.h (encode_terminal_code): Declare prototype.
13443 * msdos.c (encode_terminal_code): Don't declare prototype.
13445 * term.c (encode_terminal_code): Now external again, used by
13446 w32console.c and msdos.c.
13448 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13449 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13451 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13453 Fix some minor problems found by GCC 4.5.2's static checks.
13455 * fringe.c (update_window_fringes): Mark locals as initialized
13457 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13459 * alloc.c (mark_fringe_data): Move decl from here ...
13460 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13461 to check its interface.
13462 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13464 * fontset.c (free_realized_fontset): Now static.
13465 (Fset_fontset_font): Rename local to avoid shadowing.
13466 (fontset_font): Mark local as initialized.
13467 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13469 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13471 * xselect.c (x_disown_buffer_selections): Remove; not used.
13472 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13473 (x_own_selection, Fx_disown_selection_internal): Rename locals
13474 to avoid shadowing.
13475 (x_handle_dnd_message): Remove local to avoid shadowing.
13477 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13478 so that the caller can use some name other than gcpro1.
13479 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13480 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13481 (Fx_backspace_delete_keys_p):
13482 Use them to avoid shadowing, and rename vars to avoid shadowing.
13483 (x_decode_color, x_set_name, x_window): Now static.
13484 (Fx_create_frame): Add braces to silence GCC warning.
13485 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13486 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13487 Remove unused locals.
13488 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13489 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13490 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13493 * xterm.h (x_mouse_leave): New decl.
13495 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13496 Remove unused functions.
13497 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13498 (x_calc_absolute_position): Now static.
13499 (XTread_socket): Don't define label "out" unless it's used.
13500 Don't declare local "event" unless it's used.
13501 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13502 unless they are used.
13503 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13504 (x_fatal_error_signal): Remove; not used.
13505 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13506 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13507 (x_error_catcher, x_connection_closed, x_error_handler):
13508 (x_error_quitter, xembed_send_message, x_iconify_frame):
13509 (my_log_handler): Rename locals to avoid shadowing.
13510 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13511 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13513 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13514 Rename or move locals to avoid shadowing.
13515 (tty_defined_color, merge_face_heights): Now static.
13516 (free_realized_faces_for_fontset): Remove; not used.
13517 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13518 does not deduce is never used uninitialized.
13519 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13520 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13522 * terminal.c (store_terminal_param): Now static.
13524 * xmenu.c (menu_highlight_callback): Now static.
13525 (set_frame_menubar): Remove unused local.
13526 (xmenu_show): Rename parameter to avoid shadowing.
13527 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13528 since they might point to immutable storage.
13529 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13530 since it's unused otherwise.
13532 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13533 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13534 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13535 avoids a gcc -Wuninitialized diagnostic.
13536 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13537 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13538 does not deduce are never used uninitialized.
13540 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13542 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13543 * window.c (window_loop, size_window):
13544 (run_window_configuration_change_hook, enlarge_window): Likewise.
13546 * window.c (display_buffer): Now static.
13547 (size_window): Mark variables that gcc -Wuninitialized
13548 does not deduce are never used uninitialized.
13549 * window.h (check_all_windows): New decl, to forestall
13550 gcc -Wmissing-prototypes diagnostic.
13551 * dispextern.h (bidi_dump_cached_states): Likewise.
13553 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13555 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13556 Include <limits.h>.
13557 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13558 and to avoid gcc -Wuninitialized warning.
13559 (load_charset_map): Mark variables that gcc -Wuninitialized
13560 does not deduce are never used uninitialized.
13561 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13563 * coding.c (coding_set_source, coding_set_destination):
13564 Use "else { /* comment */ }" rather than "else /* comment */;"
13565 for clarity, and to avoid gcc -Wempty-body warning.
13566 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13567 a block, when the outer 'i' will do.
13568 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13569 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13571 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13572 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13573 Rename locals to avoid shadowing.
13574 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13575 * coding.c (emacs_mule_char, encode_invocation_designation):
13576 Now static, since they're not used elsewhere.
13577 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13578 (decode_coding_object, encode_coding_object, detect_coding_system):
13579 (decode_coding_emacs_mule): Mark variables that gcc
13580 -Wuninitialized does not deduce are never used uninitialized.
13581 (detect_coding_iso_2022): Initialize a local variable that might
13582 be used uninitialized. Leave a FIXME because it's not clear that
13583 this initialization is needed. (Bug#8211)
13584 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13585 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13586 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13587 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13588 Remove unused macros.
13590 * category.c (hash_get_category_set): Remove unused local var.
13591 (copy_category_table): Now static, since it's not used elsewhere.
13592 * character.c (string_count_byte8): Likewise.
13594 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13595 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13597 * chartab.c (copy_sub_char_table): Now static, since it's not used
13599 (sub_char_table_ref_and_range, char_table_ref_and_range):
13600 Rename locals to avoid shadowing.
13601 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13603 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13604 (BIDI_BOB): Remove unused macro.
13606 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13607 deduce are never used uninitialized.
13608 * term.c (encode_terminal_code): Likewise.
13610 * term.c (encode_terminal_code): Now static. Remove unused local.
13612 * tparam.h: New file.
13613 * term.c, tparam.h: Include it.
13614 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13615 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13616 Move these decls to tparam.h, and make them agree with what
13617 is actually in tparam.c. The previous trick of using incompatible
13618 decls in different modules does not conform to the C standard.
13619 All callers of tparam changed to use tparam's actual API.
13620 * tparam.c (tparam1, tparam, tgoto):
13621 Use const pointers where appropriate.
13623 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13624 * cm.h (struct cm): Likewise.
13625 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13626 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13627 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13628 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13629 (turn_on_face, init_tty): Likewise.
13630 * termchar.h (struct tty_display_info): Likewise.
13632 * term.c (term_mouse_position): Rename local to avoid shadowing.
13634 * alloc.c (mark_ttys): Move decl from here ...
13635 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13637 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13639 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13641 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13643 * search.c (compile_pattern_1): Remove argument regp, unused since
13644 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13645 (compile_pattern): Don't pass it.
13647 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13649 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13650 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13652 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13654 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13656 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13657 gdk_window_get_screen, gdk_window_get_geometry,
13658 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13659 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13660 (xg_get_pixbuf_from_pixmap): New function.
13661 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13662 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13663 Call xg_get_pixbuf_from_pixmap instead of
13664 gdk_pixbuf_get_from_drawable.
13665 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13666 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13667 (xg_check_special_colors): Use GtkStyleContext and its functions
13669 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13670 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13671 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13672 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13673 Call gtk_widget_get_preferred_size.
13674 (xg_frame_resized): gdk_window_get_geometry only takes 5
13676 (xg_win_to_widget, xg_event_is_for_menubar):
13677 Call gdk_x11_window_lookup_for_display.
13678 (xg_set_widget_bg): New function.
13679 (delete_cb): New function.
13680 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13681 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13682 (xg_set_background_color): Call xg_set_widget_bg.
13683 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13684 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13685 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13686 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13688 (update_frame_tool_bar): Call gtk_widget_hide.
13689 (xg_initialize): Use GDK_KEY_g.
13691 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13693 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13695 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13696 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13697 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13699 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13701 * w32xfns.c (select_palette): Check success of RealizePalette against
13702 GDI_ERROR, not zero.
13704 See ChangeLog.11 for earlier changes.
13706 ;; Local Variables:
13710 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13712 This file is part of GNU Emacs.
13714 GNU Emacs is free software: you can redistribute it and/or modify
13715 it under the terms of the GNU General Public License as published by
13716 the Free Software Foundation, either version 3 of the License, or
13717 (at your option) any later version.
13719 GNU Emacs is distributed in the hope that it will be useful,
13720 but WITHOUT ANY WARRANTY; without even the implied warranty of
13721 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13722 GNU General Public License for more details.
13724 You should have received a copy of the GNU General Public License
13725 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.