1 2011-06-09 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
4 (advance_to_char_boundary): Return EMACS_INT, not int.
6 * data.c (Qcompiled_function): Now static.
8 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
10 * window.c (window_body_lines): Now static.
12 * image.c (gif_load): Rename local to avoid shadowing.
14 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
15 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
16 * alloc.c (make_save_value): Integer argument is now of type
18 (mark_object): Use ptrdiff_t, not int.
19 * lisp.h (pD): New macro.
20 * print.c (print_object): Use it.
22 * alloc.c: Use EMACS_INT, not int, to count objects.
23 (total_conses, total_markers, total_symbols, total_vector_size)
24 (total_free_conses, total_free_markers, total_free_symbols)
25 (total_free_floats, total_floats, total_free_intervals, total_intervals)
26 (total_strings, total_free_strings):
27 Now EMACS_INT, not int. All uses changed.
28 (Fgarbage_collect): Compute overall total using a double, so that
29 integer overflow is less likely to be a problem. Check for overflow
30 when converting back to an integer.
31 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
32 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
33 These were 'int' variables that could overflow on 64-bit hosts;
34 they were never used, so remove them instead of repairing them.
35 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
36 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
37 Previously, this ceilinged at INT_MAX, but that doesn't work on
39 (allocate_pseudovector): Don't use EMACS_INT when int would do.
41 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
42 (allocate_vectorlike): Check for ptrdiff_t overflow.
43 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
44 when a (possibly-narrower) signed value would do just as well.
45 We prefer using signed arithmetic, to avoid comparison confusion.
47 * alloc.c: Catch some string size overflows that we were missing.
48 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
49 for convenience in STRING_BYTES_MAX.
50 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
51 The definition here is exact; the one in lisp.h was approximate.
52 (allocate_string_data): Check for string overflow. This catches
53 some instances we weren't catching before. Also, it catches
54 size_t overflow on (unusual) hosts where SIZE_MAX <= min
55 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
56 and ptrdiff_t and EMACS_INT are both 64 bits.
58 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
59 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
60 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
62 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
64 * alloc.c (Fmake_string): Check for out-of-range init.
66 2011-06-08 Martin Rudalics <rudalics@gmx.at>
68 * window.h (window): Add some new members to window structure -
69 normal_lines, normal_cols, new_total, new_normal, clone_number,
70 splits, nest, prev_buffers, next_buffers.
71 (WINDOW_TOTAL_SIZE): Move here from window.c.
72 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
74 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
76 (make_dummy_parent): Set new members of windows structure.
77 (make_window): Move down in code. Handle new members of window
79 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
80 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
81 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
82 (Fset_window_prev_buffers, Fwindow_next_buffers)
83 (Fset_window_next_buffers, Fset_window_clone_number): New
85 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
86 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
88 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
89 Argument WINDOW can be now internal window too.
90 (Fwindow_use_time): Move up in code.
91 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
93 (Fset_window_configuration, saved_window)
94 (Fcurrent_window_configuration, save_window_save): Handle new
95 members of window structure.
96 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
97 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
98 (syms_of_window): New Lisp objects Qrecord_window_buffer,
99 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
100 Qget_mru_window, Qresize_root_window,
101 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
102 Qauto_buffer_name; staticpro them.
104 2011-06-07 Martin Rudalics <rudalics@gmx.at>
106 * window.c (Fwindow_total_size, Fwindow_left_column)
107 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
108 (Fwindow_list_1): New functions.
109 (window_box_text_cols): Replace with window_body_cols.
110 (Fwindow_width, Fscroll_left, Fscroll_right): Use
111 window_body_cols instead of window_box_text_cols.
112 (delete_window, Fset_window_configuration): Call
113 delete_all_subwindows with window as argument.
114 (delete_all_subwindows): Take a window as argument and not a
116 (window_loop): Remove handling of GET_LRU_WINDOW and
118 (Fget_lru_window, Fget_largest_window): Move to window.el.
120 * window.h: Extern window_body_cols instead of
121 window_box_text_cols. delete_all_subwindows now takes a
122 Lisp_Object as argument.
124 * indent.c (compute_motion, Fcompute_motion): Use
125 window_body_cols instead of window_box_text_cols.
127 * frame.c (delete_frame): Call delete_all_subwindows with root
130 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
132 * fns.c (Fputhash): Document return value.
134 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
136 * image.c (gif_load): Implement gif89a spec "no disposal" method.
138 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
140 Cons<->int and similar integer overflow fixes (Bug#8794).
142 Check for overflow when converting integer to cons and back.
143 * charset.c (Fdefine_charset_internal, Fdecode_char):
144 Use cons_to_unsigned to catch overflow.
145 (Fencode_char): Use INTEGER_TO_CONS.
146 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
147 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
148 * data.c (long_to_cons, cons_to_long): Remove.
149 (cons_to_unsigned, cons_to_signed): New functions.
150 These signal an error for invalid or out-of-range values.
151 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
152 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
153 * font.c (Ffont_variation_glyphs):
154 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
155 * lisp.h: Include <intprops.h>.
156 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
157 (cons_to_signed, cons_to_unsigned): New decls.
158 (long_to_cons, cons_to_long): Remove decls.
159 * undo.c (record_first_change): Use INTEGER_TO_CONS.
160 (Fprimitive_undo): Use CONS_TO_INTEGER.
161 * xfns.c (Fx_window_property): Likewise.
162 * xselect.c: Include <limits.h>.
163 (x_own_selection, selection_data_to_lisp_data):
165 (x_handle_selection_request, x_handle_selection_clear)
166 (x_get_foreign_selection, Fx_disown_selection_internal)
167 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
168 (lisp_data_to_selection_data): Use cons_to_unsigned.
169 (x_fill_property_data): Use cons_to_signed.
170 Report values out of range.
172 Check for buffer and string overflow more precisely.
173 * buffer.h (BUF_BYTES_MAX): New macro.
174 * lisp.h (STRING_BYTES_MAX): New macro.
175 * alloc.c (Fmake_string):
176 * character.c (string_escape_byte8):
177 * coding.c (coding_alloc_by_realloc):
179 * editfns.c (Fformat):
181 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
182 since they may not be the same number.
183 * editfns.c (Finsert_char):
184 * fileio.c (Finsert_file_contents):
185 Likewise for BUF_BYTES_MAX.
187 * image.c: Use ptrdiff_t, not int, for sizes.
188 (slurp_file): Switch from int to ptrdiff_t.
190 (slurp_file): Check that file size fits in both size_t (for
191 malloc) and ptrdiff_t (for sanity and safety).
193 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
194 if b->modtime has its maximal value.
196 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
198 Don't assume time_t can fit into int.
199 * buffer.h (struct buffer.modtime): Now time_t, not int.
200 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
201 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
203 Minor fixes for signed vs unsigned integers.
204 * character.h (MAYBE_UNIFY_CHAR):
205 * charset.c (maybe_unify_char):
206 * keyboard.c (read_char, reorder_modifiers):
207 XINT -> XFASTINT, since the integer must be nonnegative.
208 * ftfont.c (ftfont_spec_pattern):
209 * keymap.c (access_keymap, silly_event_symbol_error):
210 XUINT -> XFASTINT, since the integer must be nonnegative.
211 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
212 since it makes no difference and we prefer signed.
213 * keyboard.c (record_char): Use XUINT when all the neighbors do.
214 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
217 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
219 * window.h (Fwindow_frame): Declare.
221 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
223 * alloc.c: Simplify handling of large-request failures (Bug#8800).
224 (SPARE_MEMORY): Always define.
225 (LARGE_REQUEST): Remove.
226 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
228 2011-06-06 Martin Rudalics <rudalics@gmx.at>
230 * lisp.h: Move EXFUNS for Fframe_root_window,
231 Fframe_first_window and Fset_frame_selected_window to window.h.
233 * window.h: Move EXFUNS for Fframe_root_window,
234 Fframe_first_window and Fset_frame_selected_window here from
237 * frame.c (Fwindow_frame, Fframe_first_window)
238 (Fframe_root_window, Fframe_selected_window)
239 (Fset_frame_selected_window): Move to window.c.
240 (Factive_minibuffer_window): Move to minibuf.c.
241 (Fother_visible_frames_p): New function.
243 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
245 * window.c (decode_window, decode_any_window): Move up in code.
246 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
247 (inhibit_frame_unsplittable): Remove unused variable.
248 (Fwindow_buffer): Move up and rewrite doc-string.
249 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
250 (Fwindow_prev): New functions.
251 (Fwindow_frame): Move here from frame.c. Accept any window as
253 (Fframe_root_window, Fframe_first_window)
254 (Fframe_selected_window): Move here from frame.c. Accept frame
255 or arbitrary window as argument. Update doc-strings.
256 (Fminibuffer_window): Move up in code.
257 (Fwindow_minibuffer_p): Move up in code and simplify.
258 (Fset_frame_selected_window): Move here from frame.c.
260 (Fselected_window, select_window, Fselect_window): Move up in
261 code. Minor doc-string fixes.
263 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
265 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
266 Do not assume that spare memory exists; that assumption is valid
267 only if SYSTEM_MALLOC.
268 (LARGE_REQUEST): New macro, so that the issue of large requests
269 is separated from the issue of spare memory.
271 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
273 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
276 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
278 * xfns.c (x_set_scroll_bar_default_width): Move declarations
281 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
283 * gtkutil.c (xg_get_default_scrollbar_width): New function.
285 * gtkutil.h: Declare xg_get_default_scrollbar_width.
287 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
288 min width by calling x_set_scroll_bar_default_width (Bug#8505).
290 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
292 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
294 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
296 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
297 (x_clipboard_manager_save): Add return value.
298 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
300 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
301 Obey Vx_select_enable_clipboard_manager. Catch errors in
302 x_clipboard_manager_save (Bug#8779).
303 (Vx_select_enable_clipboard_manager): New variable.
304 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
306 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
308 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
310 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
312 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
313 in the current matrix if keep_current_p is non-zero.
315 2011-06-04 Eli Zaretskii <eliz@gnu.org>
317 * bidi.c (bidi_level_of_next_char): Fix last change.
319 2011-06-03 Eli Zaretskii <eliz@gnu.org>
321 Support bidi reordering of text covered by display properties.
323 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
324 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
325 (bidi_cache_search, bidi_cache_iterator_state)
326 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
327 (bidi_level_of_next_char, bidi_move_to_visually_next):
328 Support character positions inside a run of characters covered by a
330 (bidi_paragraph_init, bidi_resolve_explicit_1)
331 (bidi_level_of_next_char): Call bidi_fetch_char and
332 bidi_fetch_char_advance instead of FETCH_CHAR and
334 (bidi_init_it): Initialize new members.
335 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
337 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
338 instead of using explicit *_CHAR codes.
339 (bidi_resolve_explicit, bidi_resolve_weak):
340 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
341 bidirectional text is supported only in multibyte buffers.
342 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
343 it to initialize the frame_window_p member of struct bidi_it.
344 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
345 (bidi_resolve_explicit, bidi_resolve_weak)
346 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
347 bidi_it->nchars is non-positive.
348 (bidi_level_of_next_char): Don't try to lookup the cache for the
349 next/previous character if nothing is cached there yet, or if we
350 were just reseat()'ed to a new position.
352 * xdisp.c (set_cursor_from_row): Set start and stop points
353 according to the row's direction when priming the loop that looks
354 for the glyph on which to display cursor.
355 (single_display_spec_intangible_p): Function deleted.
356 (display_prop_intangible_p): Reimplement to call
357 handle_display_spec instead of single_display_spec_intangible_p.
358 Accept 3 additional arguments needed by handle_display_spec.
359 This fixes incorrect cursor motion across display property with complex
360 values: lists, `(when COND...)' forms, etc.
361 (single_display_spec_string_p): Support property values that are
362 lists with the argument STRING its top-level element.
363 (display_prop_string_p): Fix the condition for processing a
364 property that is a list to be consistent with handle_display_spec.
365 (handle_display_spec): New function, refactored from the
366 last portion of handle_display_prop.
367 (compute_display_string_pos): Accept additional argument
368 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
369 value of a `display' property is a "replacing spec".
370 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
371 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
372 the display property, but just return a value indicating whether
373 the display property will replace the characters it covers.
374 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
375 frame_window_p members of struct bidi_it.
376 (compute_display_string_pos, compute_display_string_end):
378 (push_it): Accept second argument POSITION, where pop_it should
379 jump to continue iteration.
380 (reseat_1): Initialize bidi_it.disp_pos.
382 * keyboard.c (adjust_point_for_property): Adjust the call to
383 display_prop_intangible_p to its new signature.
385 * dispextern.h (struct bidi_it): New member frame_window_p.
386 (bidi_init_it): Update prototypes.
387 (display_prop_intangible_p): Update prototype.
388 (compute_display_string_pos, compute_display_string_end):
390 (struct bidi_it): New members nchars and disp_pos. ch_len is now
393 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
395 Malloc failure behavior now depends on size of allocation.
396 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
397 * lisp.h: Change signatures accordingly.
398 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
399 All callers changed. (Bug#8762)
401 * gnutls.c: Use Emacs's memory allocators.
402 Without this change, the gnutls library would invoke malloc etc.
403 directly, which causes problems on non-SYNC_INPUT hosts, and which
404 runs afoul of improving memory_full behavior. (Bug#8761)
405 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
406 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
407 xfree instead of the default malloc, realloc, free.
408 (Fgnutls_boot): No need to check for memory allocation failure,
409 since xmalloc does that for us.
411 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
412 * category.c (hash_get_category_set):
413 * ccl.c (ccl_driver):
414 * charset.c (Fdefine_charset_internal):
415 * charset.h (struct charset.hash_index):
416 * composite.c (get_composition_id, gstring_lookup_cache)
417 (composition_gstring_put_cache):
418 * composite.h (struct composition.hash_index):
419 * dispextern.h (struct image.hash):
420 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
421 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
422 (hashfn_equal, hashfn_user_defined, make_hash_table)
423 (maybe_resize_hash_table, hash_lookup, hash_put)
424 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
425 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
426 (Fsxhash, Fgethash, Fputhash, Fmaphash):
427 * image.c (make_image, search_image_cache, lookup_image)
428 (xpm_put_color_table_h):
429 * lisp.h (struct Lisp_Hash_Table):
430 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
431 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
432 for hashes and hash indexes, instead of 'unsigned' and 'int'.
433 * alloc.c (allocate_vectorlike):
434 Check for overflow in vector size calculations.
435 * ccl.c (ccl_driver):
436 Check for overflow when converting EMACS_INT to int.
437 * fns.c, image.c: Remove unnecessary static decls that would otherwise
438 need to be updated by these changes.
439 * fns.c (make_hash_table, maybe_resize_hash_table):
440 Check for integer overflow with large hash tables.
441 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
442 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
443 (SXHASH_REDUCE): New macro.
444 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
445 Use it instead of discarding useful hash info with large hash values.
446 (sxhash_float): New function.
447 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
448 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
449 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
450 Rewrite to use FIXNUM_BITS, as this simplifies things.
451 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
452 Adjust signatures to match updated version of code.
453 (consing_since_gc): Now EMACS_INT, since a single hash table can
454 use more than INT_MAX bytes.
456 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
458 Make it possible to build with GCC-4.6+ -O2 -flto.
460 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
462 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
464 * minibuf.c (get_minibuffer, read_minibuf_unwind):
465 Call minibuffer-inactive-mode.
467 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
469 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
472 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
474 * data.c (init_data): Remove code for UTS, this system is not
477 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
479 Don't force ./temacs to start in terminal mode.
481 * frame.c (make_initial_frame): Initialize faces in all cases, not
482 only when CANNOT_DUMP is defined.
483 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
485 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
487 * dispnew.c (add_window_display_history): Use const for the string
488 pointer. Remove declaration, not needed.
490 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
492 Use 'inline', not 'INLINE'.
493 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
494 * alloc.c, fontset.c (INLINE): Remove.
495 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
496 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
497 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
498 * gmalloc.c (register_heapinfo): Use inline unconditionally.
499 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
501 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
503 Make it possible to run ./temacs.
505 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
506 syms_of_callproc does the same thing. Remove test for
507 "initialized", do it in the caller.
508 * emacs.c (main): Avoid calling set_initial_environment when dumping.
510 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
512 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
513 (read_minibuf): Use get_minibuffer.
514 (syms_of_minibuf): Use DEFSYM.
515 (Qmetadata): New var.
516 * data.c (Qbuffer): Don't make it static.
517 (syms_of_data): Use DEFSYM.
519 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
521 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
522 (CCL_CODE_MIN): New macro.
524 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
526 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
528 * eval.c (Qdebug): Now static.
529 * lisp.h (Qdebug): Remove decl. This reverts a part of the
530 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
531 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
533 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
535 * image.c: Various fixes to ImageMagick code comments.
536 (Fimagemagick_types): Doc fix.
538 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
540 Minor fixes prompted by GCC 4.6.0 warnings.
542 * xselect.c (converted_selections, conversion_fail_tag): Now static.
544 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
545 (x_clipboard_manager_save_all): Move extern decl to ...
546 * xterm.h: ... here, so that it can be checked for consistency.
548 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
550 * xselect.c (x_clipboard_manager_save_frame)
551 (x_clipboard_manager_save_all): New functions.
552 (Fx_clipboard_manager_save): Lisp function deleted.
554 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
555 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
557 * xterm.h: Update prototype.
559 2011-05-28 William Xu <william.xwl@gmail.com>
561 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
564 2011-05-28 Jim Meyering <meyering@redhat.com>
566 Avoid a sign-extension bug in crypto_hash_function.
567 * fns.c (to_uchar): Define.
568 (crypto_hash_function): Use it to convert some newly-signed
569 variables to unsigned, to avoid sign-extension bugs. For example,
570 without this change, (md5 "truc") would evaluate to
571 45723a2aff78ff4fff7fff1114760e62 rather than the expected
572 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
573 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
575 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
577 Integer overflow fixes.
579 * dbusbind.c: Serial number integer overflow fixes.
580 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
581 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
582 to hold a serial number that is too large for a fixnum.
583 (Fdbus_method_return_internal, Fdbus_method_error_internal):
584 Check for serial numbers out of range. Decode any serial number
585 that was so large that it became a float. (Bug#8722)
587 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
588 (Fdbus_call_method, Fdbus_call_method_asynchronously):
589 Use XFASTINT rather than XUINT when numbers are nonnegative.
590 (xd_append_arg, Fdbus_method_return_internal):
591 (Fdbus_method_error_internal): Likewise. Also, for unsigned
592 arguments, check that Lisp number is nonnegative, rather than
593 silently wrapping negative numbers around. (Bug#8722)
594 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
597 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
599 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
601 ccl: add integer overflow checks
602 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
603 (IN_INT_RANGE): New macros.
604 (ccl_driver): Use them to check for integer overflow when
605 decoding a CCL program. Many of the new checks are whether XINT (x)
606 fits in int; it doesn't always, on 64-bit hosts. The new version
607 doesn't catch all possible integer overflows, but it's an
608 improvement. (Bug#8719)
610 * alloc.c (make_event_array): Use XINT, not XUINT.
611 There's no need for unsigned here.
613 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
614 This follows up to the 2011-05-06 change that substituted uintptr_t
615 for EMACS_INT. This case wasn't caught back then.
617 Rework Fformat to avoid integer overflow issues.
618 * editfns.c: Include <float.h> unconditionally, as it's everywhere
619 now (part of C89). Include <verify.h>.
620 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
621 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
622 (Fformat): Avoid the prepass trying to compute sizes; it was only
623 approximate and thus did not catch overflow reliably. Instead, walk
624 through the format just once, formatting and computing sizes as we go,
625 checking for integer overflow at every step, and allocating a larger
626 buffer as needed. Keep track separately whether the format is
627 multibyte. Keep only the most-recently calculated precision, rather
628 than them all. Record whether each argument has been converted to
629 string. Use EMACS_INT, not int, for byte and char and arg counts.
630 Support field widths and precisions larger than INT_MAX. Avoid
631 sprintf's undefined behavior with conversion specifications such as %#d
632 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
633 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
634 formatting out-of-range floating point numbers with int
637 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
639 * data.c: Avoid integer truncation in expressions involving floats.
640 * data.c: Include <intprops.h>.
641 (arith_driver): When there's an integer overflow in an expression
642 involving floating point, convert the integers to floating point
643 so that the resulting value does not suffer from catastrophic
644 integer truncation. For example, on a 64-bit host (* 4
645 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
646 Do not rely on undefined behavior after integer overflow.
648 merge count_size_as_multibyte, parse_str_to_multibyte
649 * character.c, character.h (count_size_as_multibyte):
650 Rename from parse_str_to_multibyte; all uses changed.
651 Check for integer overflow.
652 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
653 since it's now a duplicate of the other. This is more of
654 a character than a buffer op, so better that it's in character.c.
655 * fns.c, print.c: Adjust to above changes.
657 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
659 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
661 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
663 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
664 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
665 (x_clipboard_manager_save): Now static.
666 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
668 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
669 (crypto_hash_function): Now static.
670 Fix pointer signedness problems. Avoid unnecessary initializations.
672 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
674 * termhooks.h (Vselection_alist): Make it terminal-local.
676 * terminal.c (create_terminal): Initialize it.
678 * xselect.c: Support for clipboard managers.
679 (Vselection_alist): Move to termhooks.h as terminal-local var.
680 (LOCAL_SELECTION): New macro.
681 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
682 (symbol_to_x_atom): Remove gratuitous arg.
683 (x_handle_selection_request, lisp_data_to_selection_data)
684 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
685 (x_own_selection, x_get_local_selection, x_convert_selection):
686 New arg, specifying work frame. Use terminal-local Vselection_alist.
687 (some_frame_on_display): Delete unused function.
688 (Fx_own_selection_internal, Fx_get_selection_internal)
689 (Fx_disown_selection_internal, Fx_selection_owner_p)
690 (Fx_selection_exists_p): New optional frame arg.
691 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
692 (x_handle_selection_clear): Don't treat other terminals with the
693 same keyboard specially. Use the terminal-local Vselection_alist.
694 (x_clear_frame_selections): Use Frun_hook_with_args.
696 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
698 * xterm.h: Add support for those atoms.
700 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
702 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
703 (converted_selections, conversion_fail_tag): New global variables.
704 (x_selection_request_lisp_error): Free the above.
705 (x_get_local_selection): Remove unnecessary code.
706 (x_reply_selection_request): Args changed; handle arbitrary array
707 of converted selections stored in converted_selections.
708 Separate the XChangeProperty and SelectionNotify steps.
709 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
710 (x_convert_selection): New function.
711 (x_handle_selection_event): Simplify.
712 (x_get_foreign_selection): Don't ignore incoming requests while
713 waiting for an answer; this will fail when we implement
714 SAVE_TARGETS, and seems unnecessary anyway.
715 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
716 (Vx_sent_selection_functions): Doc fix.
718 2011-05-26 Leo Liu <sdl.web@gmail.com>
720 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
722 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
724 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
726 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
727 for fringe update if it has periodic bitmap.
728 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
729 and fringe_bitmap_periodic_p.
731 * fringe.c (get_fringe_bitmap_data): New function.
732 (draw_fringe_bitmap_1, update_window_fringes): Use it.
733 (update_window_fringes): Record periodicity of fringe bitmap in glyph
734 row. Mark glyph row for fringe update if periodicity changed.
736 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
737 for fringe update unless it has periodic bitmap.
739 2011-05-25 Kenichi Handa <handa@m17n.org>
741 * xdisp.c (get_next_display_element): Set correct it->face_id for
742 a static composition.
744 2011-05-24 Leo Liu <sdl.web@gmail.com>
747 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
749 * fns.c (crypto_hash_function, Fsha1): New function.
750 (Fmd5): Use crypto_hash_function.
751 (syms_of_fns): Add Ssha1.
753 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
755 * gnutls.c: Remove unused macros.
756 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
757 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
758 Remove macros that are defined and never used.
759 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
761 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
763 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
764 (Fx_get_selection_internal): Minor cleanup.
765 (Fx_own_selection_internal): Rename arguments for consistency with
768 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
770 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
772 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
774 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
776 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
778 * dispnew.c (scrolling_window): Don't exclude the case that the
779 last enabled row in the desired matrix touches the bottom boundary.
781 2011-05-21 Glenn Morris <rgm@gnu.org>
783 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
784 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
785 and add some more files.
787 2011-05-20 Eli Zaretskii <eliz@gnu.org>
789 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
790 report_file_error introduced by the change from 2011-05-07.
792 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
794 * systime.h (Time): Define only if emacs is defined.
795 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
796 where the include path doesn't have X11/X.h by default. See
797 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
799 2011-05-20 Kenichi Handa <handa@m17n.org>
801 * composite.c (find_automatic_composition): Fix previous change.
803 2011-05-20 Glenn Morris <rgm@gnu.org>
805 * lisp.mk: New file, split from Makefile.in.
806 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
808 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
810 2011-05-19 Glenn Morris <rgm@gnu.org>
812 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
813 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
814 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
815 (lisp): Set the order to that of loadup.el.
816 (shortlisp): Make it a copy of $lisp.
817 (SOME_MACHINE_LISP): Remove.
818 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
819 Use just $shortlisp, not $SOME_MACHINE_LISP too.
821 2011-05-18 Kenichi Handa <handa@m17n.org>
823 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
824 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
825 (find_automatic_composition): Mostly rewrite for efficiency.
827 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
829 * makefile.w32-in: Update dependencies.
831 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
833 * menu.c: Include limits.h (fixes the MS-Windows build broken by
836 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
838 Fix some integer overflow issues, such as string length overflow.
840 * insdel.c (count_size_as_multibyte): Check for string overflow.
842 * character.c (lisp_string_width): Check for string overflow.
843 Use EMACS_INT, not int, for string indexes and lengths; in
844 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
845 the resulting string length overflows an EMACS_INT; instead,
846 report a string overflow if no precision given. When checking for
847 precision exhaustion, use a check that cannot possibly have
848 integer overflow. (Bug#8675)
849 * character.h (lisp_string_width): Adjust to new signature.
851 * alloc.c (string_overflow): New function.
852 (Fmake_string): Use it. This doesn't change behavior, but saves
853 a few bytes and will simplify future changes.
854 * character.c (string_escape_byte8): Likewise.
855 * lisp.h (string_overflow): New decl.
857 Fixups, following up to the user-interface timestamp change.
858 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
859 for UI timestamps, instead of unsigned long.
860 * msdos.c (mouse_get_pos): Likewise.
861 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
862 * w32gui.h (Time): Define by including "systime.h" rather than by
863 declaring it ourselves. (Bug#8664)
865 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
866 * image.c (clear_image_cache): Likewise.
868 * term.c (term_mouse_position): Don't assume time_t wraparound.
870 Be more systematic about user-interface timestamps.
871 Before, the code sometimes used 'Time', sometimes 'unsigned long',
872 and sometimes 'EMACS_UINT', to represent these timestamps.
873 This change causes it to use 'Time' uniformly, as that's what X uses.
874 This makes the code easier to follow, and makes it easier to catch
875 integer overflow bugs such as Bug#8664.
876 * frame.c (Fmouse_position, Fmouse_pixel_position):
877 Use Time, not unsigned long, for user-interface timestamps.
878 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
879 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
880 * keyboard.h (last_event_timestamp): Likewise.
881 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
882 * menu.h (xmenu_show): Likewise.
883 * term.c (term_mouse_position): Likewise.
884 * termhooks.h (struct input_event.timestamp): Likewise.
885 (struct terminal.mouse_position_hook): Likewise.
886 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
887 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
888 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
889 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
891 * menu.h, termhooks.h: Include "systime.h", for Time.
893 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
894 Don't assume that the difference between two unsigned long values
895 can fit into an integer. At this point, we know button_down_time
896 <= event->timestamp, so the difference must be nonnegative, so
897 there's no need to cast the result if double-click-time is
898 nonnegative, as it should be; check that it's nonnegative, just in
899 case. This bug is triggered when events are more than 2**31 ms
900 apart (about 25 days). (Bug#8664)
902 * xselect.c (last_event_timestamp): Remove duplicate decl.
903 (x_own_selection): Remove needless cast to unsigned long.
905 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
906 that always fit in int. Use a sentinel instead of a counter, to
907 avoid a temp and to allay GCC's concerns about possible int overflow.
908 * frame.h (struct frame): Use int for menu_bar_items_used
909 instead of EMACS_INT, since it always fits in int.
911 * menu.c (grow_menu_items): Check for int overflow.
913 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
915 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
916 Before, the code was not consistent. These values cannot exceed
917 2**31 - 1 so there's no need to make them unsigned.
918 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
919 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
920 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
922 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
924 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
925 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
926 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
927 presumably because the widths might not match.
929 * window.c (size_window): Avoid needless test at loop start.
931 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
933 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
935 2011-05-12 Drew Adams <drew.adams@oracle.com>
937 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
939 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
941 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
942 `width' to `bar_area_x' and `bar_area_width', respectively.
943 (x_scroll_run): Take account of fringe background extension.
945 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
946 Rename local vars `left' and `width' to `bar_area_x' and
947 `bar_area_width', respectively.
948 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
949 background extension.
951 2011-05-10 Jim Meyering <meyering@redhat.com>
953 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
955 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
957 * image.c (Finit_image_library): Return t for built-in image types,
958 like pbm and xbm. (Bug#8640)
960 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
962 * w32menu.c (set_frame_menubar): Fix submenu allocation.
964 2011-05-07 Eli Zaretskii <eliz@gnu.org>
966 * w32console.c (Fset_screen_color): Doc fix.
967 (Fget_screen_color): New function.
968 (syms_of_ntterm): Defsubr it.
970 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
971 unlink the temporary file if Fcall_process didn't create it in the
973 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
974 child process will be redirected to a file specified with `:file'.
975 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
976 cue to call_process_cleanup not to close that handle.
978 2011-05-07 Ben Key <bkey76@gmail.com>
980 * makefile.w32-in: The bootstrap-temacs rule now makes use of
981 one of two shell specific rules, either bootstrap-temacs-CMD or
982 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
983 to the previous implementation of the bootstrap-temacs rule.
984 The bootstrap-temacs-CMD rule is similar to the previous
985 implementation of the bootstrap-temacs rule except that it
986 makes use of the ESC_CFLAGS variable instead of the CFLAGS
989 These changes, along with some changes to nt/configure.bat,
990 nt/gmake.defs, and nt/nmake.defs, are required to extend my
991 earlier fix to add support for --cflags and --ldflags options
992 that include quotes so that it works whether make uses cmd or
995 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
997 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
998 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1000 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1001 a string. Handle both cases.
1002 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1003 (Fdbus_register_method): Use Qinvalid_function.
1005 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1007 * makefile.w32-in: Update dependencies.
1008 (LISP_H): Add inttypes.h and stdin.h.
1009 (PROCESS_H): Add unistd.h.
1011 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1013 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1014 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1016 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1018 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1020 * term.c (vfatal): Remove stray call to va_end.
1021 It's not needed and the C Standard doesn't allow it here anyway.
1023 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1024 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1026 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1029 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1031 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1033 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1035 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1037 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1039 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1040 * charset.c (Fdefine_charset_internal): Don't initialize
1041 charset.code_space[15]. The value was garbage, on hosts with
1042 32-bit int (Bug#8600).
1044 * lread.c (read_integer): Be more consistent with string-to-number.
1045 Use string_to_number to do the actual conversion; this avoids
1046 rounding errors and fixes some other screwups. Without this fix,
1047 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1048 (digit_to_number): Move earlier, for benefit of read_integer.
1049 Return -1 if the digit is out of range for the base, -2 if it is
1050 not a digit in any supported base. (Bug#8602)
1052 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1054 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1055 to match comment at start of function. This also removes a
1056 GCC warning about overflow in a 32+64-bit port.
1058 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1060 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1061 Reported by Stefan Monnier in
1062 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1063 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1064 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1066 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1067 (EMACS_UINTPTR): Likewise, with uintptr_t.
1069 * lisp.h: Prefer 64-bit EMACS_INT if available.
1070 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1071 on 32-bit hosts that have 64-bit int, so that they can access
1073 However, temporarily disable this change unless the temporary
1074 symbol WIDE_EMACS_INT is defined.
1076 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1078 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1079 This removes an assumption that EMACS_INT and long are the same
1080 width as pointers. The assumption is true for Emacs porting targets
1081 now, but we want to make other targets possible.
1082 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1083 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1084 In the rest of the code, change types of integers that hold casted
1085 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1086 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1087 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1088 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1089 No need to cast type when ORing.
1090 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1091 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1092 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1093 assume EMACS_INT is the same width as char *.
1094 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1095 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1096 Remove no-longer-needed casts.
1097 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1098 (xg_tool_bar_help_callback, xg_make_tool_item):
1099 Use EMACS_INTPTR to hold an integer
1100 that will be cast to void *; this can avoid a GCC warning
1101 if EMACS_INT is not the same width as void *.
1102 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1103 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1104 (current_message_1, set_message_1):
1105 Use a local to convert to proper width without a cast.
1106 * xmenu.c (dialog_selection_callback): Likewise.
1108 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1109 Also, don't assume VALBITS / RAND_BITS is less than 5,
1110 and don't rely on undefined behavior when shifting a 1 left into
1112 * lisp.h (get_random): Change signature to match.
1114 * lread.c (hash_string): Use size_t, not int, for hash computation.
1115 Normally we prefer signed values; but hashing is special, because
1116 it's better to use unsigned division on hash table sizes so that
1117 the remainder is nonnegative. Also, size_t is the natural width
1118 for hashing into memory. The previous code used 'int', which doesn't
1119 retain enough info to hash well into very large tables.
1120 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1122 * dbusbind.c: Don't possibly lose pointer info when converting.
1123 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1124 Use XPNTR rather than XHASH, so that the high-order bits of
1125 the pointer aren't lost when converting through void *.
1127 * eval.c (Fautoload): Don't double-shift a pointer.
1129 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1131 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1133 * gnutls.c (DEF_GNUTLS_FN):
1134 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1136 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1138 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1141 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1143 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1144 New version that can reserve upto 2GB of heap space.
1146 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1148 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1150 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1152 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1153 `gnutls_certificate_set_x509_key_file'.
1155 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1157 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1158 Update dependencies.
1160 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1162 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1163 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1164 Remove unused parameter `fildes'.
1165 * process.c (read_process_output, send_process): Don't pass it.
1167 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1169 Fix previous change: the library cache is defined in w32.c.
1170 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1171 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1173 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1175 Implement dynamic loading of GnuTLS on Windows.
1177 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1178 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1179 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1182 * gnutls.c (Qgnutls_dll): Define.
1183 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1184 (gnutls_*): Declare function pointers.
1185 (init_gnutls_functions): New function to initialize function pointers.
1186 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1187 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1188 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1189 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1190 (emacs_gnutls_write, emacs_gnutls_read)
1191 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1192 (Fgnutls_available_p): New function.
1193 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1194 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1195 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1197 * image.c: Include w32.h.
1198 (Vimage_type_cache): Delete.
1199 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1200 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1201 (w32_delayed_load): Move to w32.c.
1203 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1205 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1206 (w32_delayed_load): Move from image.c. When loading a library, record
1207 its filename in the :loaded-from property of the library id.
1208 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1209 Initialize and staticpro them.
1210 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1212 * process.c: Include lisp.h before w32.h, not after.
1213 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1214 instead of gnutls_record_check_pending.
1216 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1218 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1220 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1221 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1224 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1226 * xterm.c (x_set_frame_alpha): Do not set property on anything
1227 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1229 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1231 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1233 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1235 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1236 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1237 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1238 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1239 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1240 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1241 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1242 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1243 (Qgnutls_bootprop_callbacks_verify): Make static.
1245 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1247 * callproc.c: Indentation fixup.
1249 * sysdep.c (wait_for_termination_1): Make static.
1250 (wait_for_termination, interruptible_wait_for_termination):
1251 Move after wait_for_termination_1.
1253 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1255 * sysdep.c (interruptible_wait_for_termination): New function
1256 which is like wait_for_termination, but allows keyboard
1259 * callproc.c (Fcall_process): Add (:file "file") as an option for
1261 (Fcall_process_region): Ditto.
1263 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1265 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1266 rather than `XVECTOR (FOO)->size'.
1268 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1269 inttypes.h, as a gnulib replacement is used if it not available in
1272 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1274 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1275 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1276 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1278 * coding.c (coding_alloc_by_realloc): Error out if destination
1279 will grow beyond MOST_POSITIVE_FIXNUM.
1280 (decode_coding_emacs_mule): Abort if there isn't enough place in
1281 charbuf for the composition carryover bytes. Reserve an extra
1282 space for up to 2 characters produced in a loop.
1283 (decode_coding_iso_2022): Abort if there isn't enough place in
1284 charbuf for the composition carryover bytes.
1286 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1288 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1289 aborting when %lld or %lll format is passed.
1290 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1291 %llo or %llx format is passed. (Bug#8545)
1293 * window.c (window_scroll_line_based): Use a marker instead of
1294 simple variables to record original value of point. (Bug#7952)
1296 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1297 produced by %s or %c overflows available buffer space. (Bug#8545)
1299 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1301 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1302 (SIZE_MAX): Move defn after all includes, as they might #define it.
1304 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1306 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1308 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1310 * keyboard.c (Qdelayed_warnings_hook): Define.
1311 (command_loop_1): Run `delayed-warnings-hook'
1312 if Vdelayed_warnings_list is non-nil.
1313 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1314 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1316 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1318 * doprnt.c (doprnt): Don't return value smaller than the buffer
1319 size if the message was truncated. (Bug#8545).
1321 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1323 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1324 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1326 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1328 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1330 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1332 * makefile.w32-in: Update dependencies.
1334 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1336 Improve `doprnt' and its usage. (Bug#8545)
1337 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1338 `format_end'. Remove support for %l as a conversion specifier.
1339 Don't use xrealloc. Improve diagnostics when the %l size modifier
1340 is used. Update the commentary.
1342 * eval.c (verror): Simplify calculation of size_t.
1344 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1347 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1349 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1352 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1354 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1355 This makes this file independent of the recent pseudovector change.
1357 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1359 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1361 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1362 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1363 Remove unused local.
1364 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1366 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1367 GCC 4.6.0 optimizes based on type-based alias analysis.
1368 For example, if b is of type struct buffer * and v of type struct
1369 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1370 != &v->size, and therefore "v->size = 1; b->size = 2; return
1371 v->size;" must therefore return 1. This assumption is incorrect
1372 for Emacs, since it type-puns struct Lisp_Vector * with many other
1373 types. To fix this problem, this patch adds a new type struct
1374 vectorlike_header that documents the constraints on layout of vectors
1375 and pseudovectors, and helps optimizing compilers not get fooled
1376 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1377 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1378 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1380 (XSETPVECTYPE): Rewrite in terms of new macro.
1381 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1382 This is a bit clearer, and further avoids the possibility of
1383 undesirable aliasing.
1384 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1385 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1386 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1387 since Lisp_Subr is a special case (no "next" field).
1388 (ASIZE): Now uses header.size rather than size.
1389 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1390 to avoid the hassle of writing XVECTOR (foo)->header.size.
1391 (struct vectorlike_header): New type.
1392 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1393 object, to help avoid aliasing.
1394 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1395 (SUBRP): Likewise, since Lisp_Subr is a special case.
1396 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1397 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1398 (struct Lisp_Hash_Table): Combine first two members into a single
1399 struct vectorlike_header member. All uses of "size" and "next" members
1400 changed to be "header.size" and "header.next".
1401 * buffer.h (struct buffer): Likewise.
1402 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1403 * frame.h (struct frame): Likewise.
1404 * process.h (struct Lisp_Process): Likewise.
1405 * termhooks.h (struct terminal): Likewise.
1406 * window.c (struct save_window_data, struct saved_window): Likewise.
1407 * window.h (struct window): Likewise.
1408 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1409 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1410 * buffer.c (init_buffer_once): Likewise.
1411 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1413 * process.c (Fformat_network_address): Use local var for size,
1416 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1418 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1419 * data.c (atof): Remove decl; no longer used or needed.
1420 (digit_to_number): Move to lread.c.
1421 (Fstring_to_number): Use new string_to_number function, to be
1422 consistent with how the Lisp reader treats infinities and NaNs.
1423 Do not assume that floating-point numbers represent EMACS_INT
1424 without losing information; this is not true on most 64-bit hosts.
1425 Avoid double-rounding errors, by insisting on integers when
1426 parsing non-base-10 numbers, as the documentation specifies.
1427 * lisp.h (string_to_number): New decl, replacing ...
1428 (isfloat_string): Remove.
1429 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1430 (read1): Do not accept +. and -. as integers; this
1431 appears to have been a coding error. Similarly, do not accept
1432 strings like +-1e0 as floating point numbers. Do not report
1433 overflow for integer overflows unless the base is not 10 which
1434 means we have no simple and reliable way to continue.
1435 Break out the floating-point parsing into a new
1436 function string_to_number, so that Fstring_to_number parses
1437 floating point numbers consistently with the Lisp reader.
1438 (digit_to_number): Move here from data.c. Make it static inline.
1439 (E_CHAR, EXP_INT): Remove, replacing with ...
1440 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1441 (string_to_number): New function, replacing isfloat_string.
1442 This function checks for valid syntax and produces the resulting
1443 Lisp float number too. Rework it so that string-to-number
1444 no longer mishandles examples like "1.0e+". Use strtoumax,
1445 so that overflow for non-base-10 numbers is reported only when
1446 there's no portable and simple way to convert to floating point.
1448 * textprop.c (set_text_properties_1): Rewrite for clarity,
1449 and to avoid GCC warning about integer overflow.
1451 * intervals.h (struct interval): Use EMACS_INT for members
1452 where EMACS_UINT might cause problems. See
1453 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1454 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1455 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1457 (offset_intervals): Tell GCC not to worry about length overflow
1458 when negating a negative length.
1460 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1461 (overrun_check_free): Likewise.
1463 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1464 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1467 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1468 (gnutls_make_error): Rename local to avoid shadowing.
1469 (gnutls_emacs_global_deinit): ifdef out; not used.
1470 (Fgnutls_boot): Use const for pointer to readonly storage.
1471 Comment out unused local. Fix pointer signedness problems.
1473 * lread.c (openp): Don't stuff size_t into an 'int'.
1474 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1475 about possible signed overflow.
1477 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1478 (GDK_KEY_g): Don't define if already defined.
1479 (xg_prepare_tooltip): Avoid pointer signedness problem.
1480 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1482 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1483 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1485 * xfns.c (Fx_window_property): Simplify a bit,
1486 to make a bit faster and to avoid GCC 4.6.0 warning.
1487 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1489 * fns.c (internal_equal): Don't assume size_t fits in int.
1491 * alloc.c (compact_small_strings): Tighten assertion a little.
1493 Replace pEd with more-general pI, and fix some printf arg casts.
1494 * lisp.h (pI): New macro, generalizing old pEd macro to other
1495 conversion specifiers. For example, use "...%"pI"d..." rather
1496 than "...%"pEd"...".
1497 (pEd): Remove. All uses replaced with similar uses of pI.
1498 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1499 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1500 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1501 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1502 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1503 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1504 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1506 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1507 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1508 * print.c (safe_debug_print, print_object): Likewise.
1509 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1511 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1512 avoiding the 0 flag, which is not portable.
1513 * process.c (Fmake_network_process): Use pI to avoid cast.
1514 * region-cache.c (pp_cache): Likewise.
1515 * xdisp.c (decode_mode_spec): Likewise.
1516 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1517 behavior on 64-bit hosts with printf arg.
1518 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1519 (x_stop_queuing_selection_requests): Likewise.
1520 (x_get_window_property): Don't truncate byte count to an 'int'
1523 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1524 here, since it parses constructs like leading '-' and spaces,
1525 which are not wanted; and it overflows with large numbers.
1526 Instead, simply match F[0-9]+, which is what is wanted anyway.
1528 * alloc.c: Remove unportable assumptions about struct layout.
1529 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1530 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1531 (allocate_vectorlike, make_pure_vector): Use the new macros,
1532 plus offsetof, to remove unportable assumptions about struct layout.
1533 These assumptions hold on all porting targets that I know of, but
1534 they are not guaranteed, they're easy to remove, and removing them
1535 makes further changes easier.
1537 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1538 This doesn't fix a bug but makes the code clearer.
1539 (string_overrun_cookie): Now const. Use initializers that
1540 don't formally overflow signed char, to avoid warnings.
1541 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1542 can cause Emacs to crash when string overrun checking is enabled.
1543 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1544 multiple of sizeof (EMACS_INT); it need not be, if
1545 alignof(EMACS_INT) < sizeof (EMACS_INT).
1546 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1548 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1550 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1552 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1554 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1555 supposed to be handshaking. (Bug#8556)
1556 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1558 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1560 * lisp.h (Qdebug): List symbol.
1561 * eval.c (Qdebug): Restore global linkage.
1562 * keyboard.c (debug-on-event): New variable.
1563 (handle_user_signal): Break into debugger when debug-on-event
1564 matches the current signal symbol.
1566 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1568 * alloc.c (check_sblock, check_string_bytes)
1569 (check_string_free_list): Convert to standard C.
1571 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1573 * w32.c (emacs_gnutls_push): Fix typo.
1575 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1577 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1578 "cast to pointer from integer of different size".
1580 Improve doprnt and its use in verror. (Bug#8545)
1581 * doprnt.c (doprnt): Document the set of format control sequences
1582 supported by the function. Use SAFE_ALLOCA instead of always
1585 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1586 is one byte too soon. Don't use xrealloc; instead xfree and
1589 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1591 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1594 * gnutls.c: Renamed global_initialized to
1595 gnutls_global_initialized. Added internals for the
1596 :verify-hostname-error, :verify-error, and :verify-flags
1597 parameters of `gnutls-boot' and documented those parameters in the
1598 docstring. Start callback support.
1599 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1600 unless a fatal error occured. Call gnutls_alert_send_appropriate
1601 on error. Return error code.
1602 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1603 (emacs_gnutls_read): Likewise.
1604 (Fgnutls_boot): Return handshake error code.
1605 (emacs_gnutls_handle_error): New function.
1606 (wsaerror_to_errno): Likewise.
1608 * w32.h (emacs_gnutls_pull): Add prototype.
1609 (emacs_gnutls_push): Likewise.
1611 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1612 (emacs_gnutls_push): Likewise.
1614 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1616 * process.c (wait_reading_process_output): Check if GnuTLS
1617 buffered some data internally if no FDs are set for TLS
1620 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1621 (LIBS): Link to USER_LIBS.
1622 ($(BLD)/gnutls.$(0)): New target.
1624 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1626 * xdisp.c (handle_single_display_spec): Rename the
1627 display_replaced_before_p argument into display_replaced_p, to
1628 make it consistent with the commentary. Fix typos in the
1631 * textprop.c (syms_of_textprop): Remove dead code.
1632 (copy_text_properties): Delete obsolete commentary about an
1633 interface that was deleted long ago. Fix typos in the description
1636 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1637 to changes in oldXMenu/XMenu.h from 2011-04-16.
1638 <menu_help_message, prev_menu_help_message>: Constify.
1639 (IT_menu_make_room): menu->help_text is now `const char **';
1642 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1643 to changes in oldXMenu/XMenu.h from 2011-04-16.
1644 (struct XMenu): Declare `help_text' `const char **'.
1646 * xfaces.c <Qunspecified>: Make extern again.
1648 * syntax.c: Include sys/types.h before including regex.h, as
1651 * doc.c (get_doc_string): Improve the format passed to `error'.
1653 * doprnt.c (doprnt): Improve commentary.
1655 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1657 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1660 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1661 changes in globals.h immediately force recompilation.
1662 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1663 $(CURDIR)/s/ms-w32.h.
1664 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1666 * character.c (Fchar_direction): Function deleted.
1667 (syms_of_character): Don't defsubr it.
1668 <char-direction-table>: Deleted.
1670 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1672 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1673 * doprnt.c: Include limits.h.
1674 (SIZE_MAX): New macro.
1675 (doprnt): Return a size_t value. 2nd arg is now size_t.
1676 Many local variables are now size_t instead of int or unsigned.
1677 Improve overflow protection. Support `l' modifier for integer
1678 conversions. Support %l conversion. Don't assume an EMACS_INT
1679 argument for integer conversions and for %c.
1681 * lisp.h (doprnt): Restore prototype.
1683 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1686 * Makefile.in (base_obj): Add back doprnt.o.
1688 * deps.mk (doprnt.o): Add back prerequisites.
1689 (callint.o): Depend on character.h.
1691 * eval.c (internal_lisp_condition_case): Include the handler
1692 representation in the error message.
1693 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1694 when breaking from the loop.
1696 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1698 * callint.c (Fcall_interactively): When displaying error message
1699 about invalid control letter, pass the character's codepoint, not
1700 a pointer to its multibyte form. Improve display of the character
1701 in octal and display also its hex code.
1703 * character.c (char_string): Use %x to display the (unsigned)
1704 codepoint of an invalid character, to avoid displaying a bogus
1707 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1708 `error', not SYMBOL_NAME itself.
1710 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1711 character arguments to `error'.
1713 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1714 to `error' in error message about FINAL_CHAR argument. Make sure
1715 FINAL_CHAR is a character, and use %c when it is passed as
1716 argument to `error'.
1718 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1720 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1722 * w32.c: Include <time.h>.
1723 (sys_localtime): New function.
1725 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1727 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1729 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1731 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1733 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1736 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1738 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1739 gl_state.e_property when gl_state.object is Qt.
1741 * insdel.c (make_gap_larger): Remove limitation of buffer size
1744 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1746 * xdisp.c (lookup_glyphless_char_display)
1747 (produce_glyphless_glyph): Handle cons cell entry in
1748 glyphless-char-display.
1749 (Vglyphless_char_display): Document it.
1751 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1752 glyphless-char-display.
1754 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1756 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1758 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1760 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1761 definition for no-X builds.
1763 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1765 Static checks with GCC 4.6.0 and non-default toolkits.
1767 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1769 * process.c (keyboard_bit_set): Define only if SIGIO.
1770 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1771 (send_process): Repair possible setjmp clobbering.
1773 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1775 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1777 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1779 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1780 Define only if needed.
1782 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1783 by pacifying GCC about it. Maybe it's time to retire it?
1784 * xfaces.c (USG, __TIMEVAL__): Likewise.
1786 * dispextern.h (struct redisplay_interface): Rename param
1788 * termhooks.h (struct terminal): Likewise.
1789 * xterm.c (xembed_send_message): Likewise.
1791 * insdel.c (make_gap_smaller): Define only if
1792 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1794 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1797 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1798 so that we aren't warned about unused symbols.
1800 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1802 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1804 * xfns.c (x_real_positions): Mark locals as initialized.
1806 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1808 * xterm.c: Fix problems found by static analysis with other toolkits.
1809 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1810 (x_dispatch_event): Declare static if USE_GTK, and
1811 define if USE_GTK || USE_X_TOOLKIT.
1812 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1813 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1814 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1815 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1817 * xmenu.c (menu_help_callback): Pointer type fixes.
1818 Use const pointers when pointing at readonly data. Avoid pointer
1820 (FALSE): Remove unused macro.
1821 (update_frame_menubar): Remove unused decl.
1823 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1825 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1826 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1827 (single_menu_item): Rename local to avoid shadowing.
1829 * keyboard.c (make_lispy_event): Remove unused local var.
1831 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1832 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1834 * bitmaps: Change bitmaps from unsigned char back to the X11
1835 compatible char. Avoid the old compiler warnings about
1836 out-of-range initializers by using, for example, '\xab' rather
1839 * xgselect.c (xgselect_initialize): Check vs interface
1840 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1842 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1844 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1845 to read-only memory.
1847 * fns.c (vector): Remove; this old hack is no longer needed.
1849 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1851 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1853 * xrdb.c (x_load_resources): Omit unused local.
1855 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1856 (x_window): Rename locals to avoid shadowing.
1857 (USG): Use the kludged USG macro, to pacify gcc.
1859 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1860 (x_term_init): Remove local to avoid shadowing.
1862 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1864 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1865 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1867 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1869 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1871 Fix regex.c, syntax.c and friends for buffers > 2GB.
1872 * syntax.h (struct gl_state_s): Declare character position members
1875 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1877 * textprop.c (verify_interval_modification, interval_of):
1878 Declare arguments EMACS_INT.
1880 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1883 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1885 * indent.c (Fvertical_motion): Local variable it_start is now
1888 * regex.c (re_match, re_match_2, re_match_2_internal)
1889 (bcmp_translate, regcomp, regexec, print_double_string)
1890 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1891 (re_compile_pattern, re_exec): Declare arguments and local
1892 variables `size_t' and `ssize_t' and return values `regoff_t', as
1894 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1895 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1896 <compile_stack_type>: `size' and `avail' are now `size_t'.
1898 * regex.h <regoff_t>: Use ssize_t, not int.
1899 (re_search, re_search_2, re_match, re_match_2): Arguments that
1900 specify buffer/string position and length are now ssize_t and
1901 size_t. Return type is regoff_t.
1903 2011-04-16 Ben Key <bkey76@gmail.com>
1905 * nsfont.m: Fixed bugs in ns_get_family and
1906 ns_descriptor_to_entity that were caused by using free to
1907 deallocate memory blocks that were allocated by xmalloc (via
1908 xstrdup). This caused Emacs to crash when compiled with
1909 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1910 --enable-checking=xmallocoverrun). xfree is now used to
1911 deallocate these memory blocks.
1913 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1915 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1917 emacs_write: Accept and return EMACS_INT for sizes.
1918 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1920 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1921 Accept and return EMACS_INT.
1922 (emacs_gnutls_write): Return the number of bytes written on
1924 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1925 (emacs_read, emacs_write): Remove check for negative size, as the
1926 Emacs source code has been audited now.
1927 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1928 (emacs_read, emacs_write): Use it.
1929 * process.c (send_process): Adjust to the new signatures of
1930 emacs_write and emacs_gnutls_write. Do not attempt to store
1931 a byte offset into an 'int'; it might overflow.
1932 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1934 * sound.c: Don't assume sizes fit in 'int'.
1935 (struct sound_device.period_size, alsa_period_size):
1936 Return EMACS_INT, not int.
1937 (struct sound_device.write, vox_write, alsa_write):
1938 Accept EMACS_INT, not int.
1939 (wav_play, au_play): Use EMACS_INT to store sizes and to
1940 record read return values.
1942 2011-04-15 Ben Key <bkey76@gmail.com>
1944 * keyboard.c (Qundefined): Don't declare static since it is used
1946 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1947 static since they are used in nsfont.m.
1949 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1951 * process.c (Qprocessp): Don't declare static.
1952 * lisp.h (Qprocessp): Declare again.
1954 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1956 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1958 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1960 Improve C-level modularity by making more things 'static'.
1962 Don't publish debugger-only interfaces to other modules.
1963 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1964 (verify_bytepos, count_markers): Move decls to the only modules
1966 * region-cache.h (pp_cache): Likewise.
1967 * window.h (check_all_windows): Likewise.
1968 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1970 * sysdep.c (croak): Now static, if
1971 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1972 * syssignal.h (croak): Declare only if not static.
1974 * alloc.c (refill_memory_reserve): Now static if
1975 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1976 * lisp.h (refill_memory_reserve): Declare only if not static.
1978 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1979 Define only if USE_LUCID.
1981 * xrdb.c (x_customization_string, x_rm_string): Now static.
1983 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1984 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1986 * xdisp.c (draw_row_with_mouse_face): Now static.
1987 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1989 * window.h (check_all_windows): Mark externally visible.
1991 * window.c (window_deletion_count): Now static.
1993 * undo.c: Make symbols static if they're not exported.
1994 (last_undo_buffer, last_boundary_position, pending_boundary):
1997 * textprop.c (interval_insert_behind_hooks): Now static.
1998 (interval_insert_in_front_hooks): Likewise.
2000 * term.c: Make symbols static if they're not exported.
2001 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2002 (max_frame_lines, tty_set_terminal_modes):
2003 (tty_reset_terminal_modes, tty_turn_off_highlight):
2004 (get_tty_terminal): Now static.
2005 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2006 * termhooks.h (term_mouse_moveto): Do not declare if
2008 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2009 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2011 * sysdep.c: Make symbols static if they're not exported.
2012 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2014 (sigprocmask_set, full_mask): Remove; unused.
2015 (wait_debugging): Mark as visible.
2016 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2017 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2019 * syntax.c (syntax_temp): Define only if !__GNUC__.
2021 * sound.c (current_sound_device, current_sound): Now static.
2023 * search.c (searchbufs, searchbuf_head): Now static.
2025 * scroll.c (scroll_cost): Remove; unused.
2026 * dispextern.h (scroll_cost): Remove decl.
2028 * region-cache.h (pp_cache): Mark as externally visible.
2030 * process.c: Make symbols static if they're not exported.
2031 (process_tick, update_tick, create_process, chan_process):
2032 (Vprocess_alist, proc_buffered_char, datagram_access):
2033 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2034 (deactivate_process): Mark defn as static, as well as decl.
2035 * lisp.h (create_process): Remove decl.
2036 * process.h (chan_process, Vprocess_alist): Remove decls.
2038 * print.c: Make symbols static if they're not exported.
2039 (print_depth, new_backquote_output, being_printed, print_buffer):
2040 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2041 (print_interval, print_number_index, initial_stderr_stream):
2043 * lisp.h (Fprinc): Remove decl.
2044 (debug_output_compilation_hack): Mark as externally visible.
2046 * sysdep.c (croak): Move decl from here to syssignal.h.
2047 * syssignal.h (croak): Put it here, so the API can be checked when
2048 'croak' is called from dissociate_if_controlling_tty.
2050 * minibuf.c: Make symbols static if they're not exported.
2051 (minibuf_save_list, choose_minibuf_frame): Now static.
2052 * lisp.h (choose_minibuf_frame): Remove decl.
2054 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2056 * lread.c: Make symbols static if they're not exported.
2057 (read_objects, initial_obarray, oblookup_last_bucket_number):
2059 (make_symbol): Remove; unused.
2060 * lisp.h (initial_obarray, make_symbol): Remove decls.
2062 * keyboard.c: Make symbols static if they're not exported.
2063 (single_kboard, recent_keys_index, total_keys, recent_keys):
2064 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2065 (this_single_command_key_start, echoing, last_auto_save):
2066 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2067 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2068 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2069 (Vlispy_mouse_stem, double_click_count):
2071 (force_auto_save_soon): Define only if SIGDANGER.
2072 (ignore_mouse_drag_p): Now static if
2073 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2074 (print_help): Remove; unused.
2075 (stop_character, last_timer_event): Mark as externally visible.
2076 * keyboard.h (ignore_mouse_drag_p): Declare only if
2077 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2078 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2079 * lisp.h (echoing): Remove decl.
2080 (force_auto_save_soon): Declare only if SIGDANGER.
2081 * xdisp.c (redisplay_window): Simplify code, to make it more
2082 obvious that ignore_mouse_drag_p is not accessed if !defined
2083 USE_GTK && !defined HAVE_NS.
2085 * intervals.c: Make symbols static if they're not exported.
2086 (merge_properties_sticky, merge_interval_right, delete_interval):
2088 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2090 * insdel.c: Make symbols static if they're not exported.
2091 However, leave prepare_to_modify_buffer alone. It's never
2092 called from outside this function, but that appears to be a bug.
2093 (combine_after_change_list, combine_after_change_buffer):
2094 (adjust_after_replace, signal_before_change): Now static.
2095 (adjust_after_replace_noundo): Remove; unused.
2096 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2097 (signal_before_change): Remove decls.
2099 * indent.c (val_compute_motion, val_vmotion): Now static.
2101 * image.c: Make symbols static if they're not exported.
2102 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2104 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2105 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2107 * fringe.c (standard_bitmaps): Now static.
2108 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2110 * frame.c: Make symbols static if they're not exported.
2111 (x_report_frame_params, make_terminal_frame): Now static.
2112 (get_frame_param): Now static, unless HAVE_NS.
2113 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2114 (x_get_resource_string): Remove; not used.
2115 * frame.h (make_terminal_frame, x_report_frame_params):
2116 (x_get_resource_string); Remove decls.
2117 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2118 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2120 * font.c, fontset.c: Make symbols static if they're not exported.
2121 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2122 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2123 * font.c (font_close_object): Now static.
2124 * font.h (font_close_object): Remove.
2125 * fontset.c (FONTSET_OBJLIST): Remove.
2126 (free_realized_fontset) #if-0 the body, which does nothing.
2127 (face_suitable_for_char_p): #if-0, as it's never called.
2128 * fontset.h (face_suitable_for_char_p): Remove decl.
2129 * xfaces.c (face_at_string_position):
2130 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2131 since 0 is always ASCII.
2133 * fns.c (weak_hash_tables): Now static.
2135 * fileio.c: Make symbols static if they're not exported.
2136 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2137 (Vwrite_region_annotation_buffers): Now static.
2139 * eval.c: Make symbols static if they're not exported.
2140 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2141 * lisp.h (backtrace_list): Remove decl.
2143 * emacs.c: Make symbols static if they're not exported.
2144 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2145 (fatal_error_code, fatal_error_signal_hook, standard_args):
2147 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2148 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2149 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2150 * lisp.h (fatal_error_signal_hook): Remove decl.
2151 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2153 * editfns.c: Move a (normally-unused) function to its only use.
2154 * editfns.c, lisp.h (get_operating_system_release): Remove.
2155 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2156 worth the hassle of breaking this out.
2158 * xterm.c: Make symbols static if they're not exported.
2159 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2160 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2161 (x_destroy_window, x_delete_display):
2163 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2164 (x_mouse_leave): Remove; unused.
2165 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2166 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2167 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2169 (x_mouse_leave): Declare only if WINDOWSNT.
2170 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2171 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2174 * ftxfont.c: Make symbols static if they're not exported.
2175 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2177 * font.h (ftxfont_driver): Likewise.
2179 * xfns.c: Make symbols static if they're not exported.
2180 (x_last_font_name, x_display_info_for_name):
2181 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2182 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2183 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2184 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2185 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2186 (last_show_tip_args): Now static.
2187 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2188 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2189 (x_screen_planes): Remove; unused.
2190 * dispextern.h (x_screen_planes): Remove decl.
2192 * dispnew.c: Make symbols static if they're not exported.
2193 * dispextern.h (redraw_garbaged_frames, scrolling):
2194 (increment_row_positions): Remove.
2195 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2196 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2198 (redraw_garbaged_frames): Remove; unused.
2200 * xfaces.c: Make symbols static if they're not exported.
2201 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2203 * xterm.h (defined_color): Remove decls.
2204 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2205 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2206 (menu_face_changed_default, defined_color, free_realized_face):
2207 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2208 (ascii_face_of_lisp_face): Remove; unused.
2210 * xdisp.c: Make symbols static if they're not exported.
2211 * dispextern.h (scratch_glyph_row, window_box_edges):
2212 (glyph_to_pixel_coords, set_cursor_from_row):
2213 (get_next_display_element, set_iterator_to_next):
2214 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2215 (show_mouse_face): Remove decls
2216 * frame.h (message_buf_print): Likewise.
2217 * lisp.h (pop_message, set_message, check_point_in_composition):
2219 * xterm.h (set_vertical_scroll_bar): Likewise.
2220 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2221 (message_buf_print, scratch_glyph_row, displayed_buffer):
2222 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2223 (get_next_display_element, show_mouse_face, window_box_edges):
2224 (frame_to_window_pixel_xy, check_point_in_composition):
2225 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2226 (glyph_to_pixel_coords): Remove; unused.
2228 * dired.c (file_name_completion): Now static.
2230 * dbusbind.c (xd_in_read_queued_messages): Now static.
2232 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2233 * data.c (circular_list_error): Remove.
2235 * commands.h (last_point_position, last_point_position_buffer):
2236 (last_point_position_window): Remove decls.
2237 * keyboard.c: Make these variables static.
2239 * coding.h (coding, code_convert_region, encode_coding_gap):
2241 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2242 (iso_code_class, detect_coding, code_convert_region): Now static.
2243 (encode_coding_gap): Remove; unused.
2245 * chartab.c (chartab_chars, chartab_bits): Now static.
2247 * charset.h (charset_iso_8859_1): Remove decl.
2248 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2251 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2252 * ccl.c (Vccl_program_table): Now static.
2253 (check_ccl_update): Remove; unused.
2255 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2256 * category.h: ... from here.
2257 * category.c (check_category_table, set_category_set): Now static.
2259 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2260 * lisp.h: Remove these decls.
2262 * buffer.c (buffer_count): Remove unused var.
2264 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2265 so that it's not optimized away.
2266 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2267 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2268 exported only to the debugger.
2270 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2271 * atimer.h (run_all_atimers): Remove; not exported.
2273 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2274 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2275 was inaccessible from Lisp.
2276 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2277 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2279 alloc.c: Import and export fewer symbols, and remove unused items.
2280 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2282 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2283 it's not optimized away by whole-program optimization.
2284 (message_enable_multibyte, free_misc): Remove.
2285 (catchlist, handlerlist, mark_backtrace):
2286 Declare only if BYTE_MARK_STACK.
2287 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2288 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2289 (message_enable_multibyte): Remove decl.
2290 (free_misc, interval_free_list, float_block, float_block_index):
2291 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2292 (cons_free_list, last_marked_index):
2294 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2295 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2296 (mark_backtrace): Define only if BYTE_MARK_STACK.
2297 * xdisp.c (message_enable_multibyte): Now static.
2299 Declare Lisp_Object Q* variables to be 'static' if not exported.
2300 This makes it easier for human readers (and static analyzers)
2301 to see whether these variables are used from other modules.
2302 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2303 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2304 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2305 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2306 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2307 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2308 * xmenu.c, xselect.c:
2309 Declare Q* vars static if they are not used in other modules.
2310 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2311 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2312 Remove decls of unexported vars.
2313 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2315 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2317 Make Emacs functions such as Fatom 'static' by default.
2318 This makes it easier for human readers (and static analyzers)
2319 to see whether these functions can be called from other modules.
2320 DEFUN now defines a static function. To make the function external
2321 so that it can be used in other C modules, use the new macro DEFUE.
2322 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2323 (Finit_image_library):
2324 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2325 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2326 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2327 Remove decls, since these functions are now static.
2328 (Funintern, Fget_internal_run_time): New decls, since these functions
2329 were already external.
2331 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2332 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2333 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2334 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2335 * keyboard.c, keymap.c, lread.c:
2336 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2337 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2338 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2339 Mark functions with DEFUE instead of DEFUN,
2340 if they are used in other modules.
2341 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2342 decls for now-static functions.
2343 * buffer.h (Fdelete_overlay): Remove decl.
2344 * callproc.c (Fgetenv_internal): Mark as internal.
2345 * composite.c (Fremove_list_of_text_properties): Remove decl.
2346 (Fcomposition_get_gstring): New forward static decl.
2347 * composite.h (Fcomposite_get_gstring): Remove decl.
2348 * dired.c (Ffile_attributes): New forward static decl.
2349 * doc.c (Fdocumntation_property): New forward static decl.
2350 * eval.c (Ffetch_bytecode): New forward static decl.
2351 (Funintern): Remove extern decl; now in .h file where it belongs.
2352 * fileio.c (Fmake_symbolic_link): New forward static decl.
2353 * image.c (Finit_image_library): New forward static decl.
2354 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2355 * intervals.h (Fprevious_property_change):
2356 (Fremove_list_of_text_properties): Remove decls.
2357 * keyboard.c (Fthis_command_keys): Remove decl.
2358 (Fcommand_execute): New forward static decl.
2359 * keymap.c (Flookup_key): New forward static decl.
2360 (Fcopy_keymap): Now static.
2361 * keymap.h (Flookup_key): Remove decl.
2362 * process.c (Fget_process): New forward static decl.
2363 (Fprocess_datagram_address): Mark as internal.
2364 * syntax.c (Fsyntax_table_p): New forward static decl.
2365 (skip_chars): Remove duplicate decl.
2366 * textprop.c (Fprevious_property_change): New forward static decl.
2367 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2369 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2370 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2372 * editfns.c (Fformat): Remove unreachable code.
2374 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2376 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2379 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2381 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2382 when at ZV. (Bug#8487)
2384 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2386 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2388 * keyboard.c (parse_tool_bar_item): Likewise.
2389 * sound.c (sound_cleanup, alsa_close): Likewise.
2390 * termcap.c (tgetent): Likewise.
2391 * xfns.c (x_default_font_parameter): Likewise.
2392 * xsettings.c (read_and_apply_settings): Likewise.
2394 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2395 (overrun_check_free): Protoize.
2397 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2399 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2400 since callers should never pass a negative size.
2401 Change the signature to match that of plain 'read' and 'write'; see
2402 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2403 * lisp.h: Update prototypes of emacs_write and emacs_read.
2405 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2407 * xdisp.c (redisplay_window): Don't try to determine the character
2408 position of the scroll margin if the window start point w->startp
2409 is outside the buffer's accessible region. (Bug#8468)
2411 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2413 Fix write-region and its subroutines for buffers > 2GB.
2414 * fileio.c (a_write, e_write): Modify declaration of arguments and
2415 local variables to support buffers larger than 2GB.
2416 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2418 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2419 argument, local variables, and return value.
2421 * lisp.h: Update prototypes of emacs_write and emacs_read.
2423 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2425 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2427 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2429 Fix more problems found by GCC 4.6.0's static checks.
2431 * xdisp.c (vmessage): Use a better test for character truncation.
2433 * charset.c (load_charset_map): <, not <=, for optimization,
2434 and to avoid potential problems with integer overflow.
2435 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2436 * casetab.c (set_identity, shuffle): Likewise.
2437 * editfns.c (Fformat): Likewise.
2438 * syntax.c (skip_chars): Likewise.
2440 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2441 This also lets GCC 4.6.0 generate slightly better loop code.
2443 * callint.c (Fcall_interactively): <, not <=, for optimization.
2444 (Fcall_interactively): Count the number of arguments produced,
2445 not the number of arguments given. This is simpler and lets GCC
2446 4.6.0 generate slightly better code.
2448 * ftfont.c: Distingish more carefully between FcChar8 and char.
2449 The previous code passed unsigned char * to a functions like
2450 strlen and xstrcasecmp that expect char *, which does not
2451 conform to the C standard.
2452 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2453 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2454 char * when the C standard requires it.
2456 * keyboard.c (read_char): Remove unused var.
2458 * eval.c: Port to Windows vsnprintf (Bug#8435).
2460 (SIZE_MAX): Define if the headers do not.
2461 (verror): Do not give up if vsnprintf returns a negative count.
2462 Instead, grow the buffer. This ports to Windows vsnprintf, which
2463 does not conform to C99. Problem reported by Eli Zaretskii.
2464 Also, simplify the allocation scheme, by avoiding the need for
2465 calling realloc, and removing the ALLOCATED variable.
2467 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2469 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2470 But keep the doprint source code for now, as we might revamp it
2471 and use it again (Bug#8435).
2472 * lisp.h (doprnt): Remove.
2473 * Makefile.in (base_obj): Remove doprnt.o.
2474 * deps.mk (doprnt.o): Remove.
2476 error: Print 32- and 64-bit integers portably (Bug#8435).
2477 Without this change, on typical 64-bit hosts error ("...%d...", N)
2478 was used to print both 32- and 64-bit integers N, which relied on
2480 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2482 * lisp.h (error, verror): Mark as printf-like functions.
2483 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2484 Report overflow in size calculations when allocating printf buffer.
2485 Do not truncate output string at its first null byte.
2486 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2487 Truncate the output at a character boundary, since vsnprintf does not
2489 * charset.c (check_iso_charset_parameter): Convert internal
2490 character to string before calling 'error', since %c now has the
2492 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2493 overflow when computing char to be passed to 'error'. Do not
2494 pass Lisp_Object to 'error'; pass the integer instead.
2495 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2496 formatted with plain %d.
2498 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2500 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2502 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2504 * xterm.c (x_catch_errors): Remove duplicate declaration.
2506 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2508 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2510 2011-04-10 Jim Meyering <meyering@redhat.com>
2512 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2513 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2514 return ssize_t not "int", and use size_t as the buffer length.
2515 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2516 * gnutls.h: Update declarations.
2517 * process.c (read_process_output): Use ssize_t, to match.
2518 (send_process): Likewise.
2520 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2522 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2524 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2526 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2527 Use unsigned char, to match FcChar8 type definition.
2529 * xterm.c (handle_one_xevent):
2530 * xmenu.c (create_and_show_popup_menu):
2531 * xselect.c (x_decline_selection_request)
2532 (x_reply_selection_request): Avoid type-punned deref of X events.
2534 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2536 Fix some uses of `int' instead of EMACS_INT.
2537 * search.c (string_match_1, fast_string_match)
2538 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2539 (scan_buffer, find_next_newline_no_quit)
2540 (find_before_next_newline, search_command, Freplace_match)
2541 (Fmatch_data): Make some `int' variables be EMACS_INT.
2543 * xdisp.c (display_count_lines): 3rd argument and return value now
2544 EMACS_INT. All callers changed.
2545 (pint2hrstr): Last argument is now EMACS_INT.
2547 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2548 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2549 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2550 (decode_coding_utf_16, decode_coding_emacs_mule)
2551 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2552 (decode_coding_ccl, decode_coding_charset)
2553 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2554 (decode_coding_iso_2022, decode_coding_emacs_mule)
2555 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2556 <char_offset, last_offset>: Declare EMACS_INT.
2557 (encode_coding_utf_8, encode_coding_utf_16)
2558 (encode_coding_emacs_mule, encode_invocation_designation)
2559 (encode_designation_at_bol, encode_coding_iso_2022)
2560 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2561 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2563 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2564 (encode_invocation_designation): Last argument P_NCHARS is now
2566 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2567 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2569 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2572 * ccl.c (Fccl_execute_on_string): Declare some variables
2575 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2577 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2579 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2581 * process.c (Fformat_network_address): Doc fix.
2583 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2585 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2587 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2589 * keyboard.c (read_char): Call Lisp function help-form-show,
2590 instead of using internal_with_output_to_temp_buffer.
2591 (Qhelp_form_show): New var.
2592 (syms_of_keyboard): Use DEFSYM macro.
2594 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2596 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2598 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2600 * process.c (Flist_processes): Remove to Lisp.
2601 (list_processes_1): Delete.
2603 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2605 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2607 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2609 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2611 Fix more problems found by GCC 4.6.0's static checks.
2613 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2615 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2617 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2619 * xdisp.c (vmessage): Mark as a printf-like function.
2621 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2623 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2625 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2626 printf-like functions.
2627 (tiff_load): Add casts to remove these marks before passing them
2628 to system-supplied API.
2630 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2632 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2633 This avoids several warnings with gcc -Wstrict-overflow.
2634 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2635 directly, rather than having caller test rule sign. This avoids
2636 some unnecessary tests.
2637 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2638 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2639 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2641 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2642 (xfont_open): Avoid unnecessary tests.
2644 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2646 * composite.h, composite.c (composition_gstring_put_cache):
2647 Use EMACS_INT, not int, for length.
2649 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2650 breaking out part of COMPOSITION_DECODE_RULE.
2651 (COMPOSITION_DECODE_RULE): Use it.
2652 * composite.c (get_composition_id): Remove unused local vars,
2653 by using the new macro.
2655 * textprop.c (set_text_properties_1): Change while to do-while,
2656 since the condition is always true at first.
2658 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2659 (interval_deletion_adjustment): Return unsigned value.
2662 * process.c (list_processes_1, create_pty, read_process_output):
2663 (exec_sentinel): Remove vars that were set but not used.
2664 (create_pty): Remove unnecessary "volatile"s.
2665 (Fnetwork_interface_info): Avoid possibility of int overflow.
2666 (read_process_output): Do adaptive read buffering even if carryover.
2667 (read_process_output): Simplify nbytes computation if buffered.
2669 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2671 * syntax.c (scan_words): Remove var that was set but not used.
2672 (update_syntax_table): Use unsigned instead of int.
2674 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2675 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2676 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2678 * print.c (print_error_message): Avoid int overflow.
2680 * font.c (font_list_entities): Redo for clarity,
2681 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2683 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2684 (font_score): Avoid potential overflow in diff calculation.
2686 * fns.c (substring_both): Remove var that is set but not used.
2687 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2689 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2691 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2692 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2693 can always succeed if overflow has undefined behavior.
2695 * search.c (boyer_moore, wordify): Remove vars set but not used.
2696 (wordify): Omit three unnecessary tests.
2698 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2699 All callers changed. This avoids the need for an unused var.
2701 * casefiddle.c (casify_region): Remove var that is set but not used.
2703 * dired.c (file_name_completion): Remove var that is set but not used.
2705 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2707 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2708 (Finsert_file_contents): Remove unnecessary code checking fd.
2710 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2711 Check for integer overflow on size calculations.
2713 * buffer.c (Fprevious_overlay_change): Remove var that is set
2716 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2717 Remove vars that are set but not used.
2718 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2719 (timer_check_2): Mark vars as initialized.
2721 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2723 * image.c (lookup_image): Remove var that is set but not used.
2724 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2726 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2727 that are set but not used.
2729 * xfns.c (make_invisible_cursor): Don't return garbage
2730 if XCreateBitmapFromData fails (Bug#8410).
2732 * xselect.c (x_get_local_selection, x_handle_property_notify):
2733 Remove vars that are set but not used.
2735 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2736 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2738 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2739 Remove var that is set but not used.
2740 (scroll_bar_windows_size): Now size_t, not int.
2741 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2744 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2745 (map_tty_color) [!defined MSDOS]: Likewise.
2747 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2749 * coding.c: Remove vars that are set but not used.
2750 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2751 All callers changed.
2752 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2753 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2754 (decode_coding_charset): Remove vars that are set but not used.
2756 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2757 that is set but not used.
2759 * print.c (print_object): Remove var that is set but not used.
2761 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2762 The gnulib version avoids calling malloc in the usual case,
2763 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2764 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2765 * filelock.c (current_lock_owner): Likewise.
2766 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2767 * sysdep.c: Include allocator.h, careadlinkat.h.
2768 (emacs_no_realloc_allocator): New static constant.
2769 (emacs_readlink): New function.
2770 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2771 ../lib/careadlinkat.h.
2773 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2775 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2776 first non-nil return value).
2778 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2780 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2781 if not defined (Bug#8403).
2783 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2785 * xdisp.c (display_count_lines): Remove parameter `start',
2786 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2787 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2788 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2789 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2790 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2791 and thereabouts. All callers changed.
2792 (get_per_char_metric): Remove parameter `f', unused since
2793 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2795 2011-04-02 Jim Meyering <meyering@redhat.com>
2797 do not dereference NULL upon failed strdup
2798 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2799 (ns_get_family): Likewise.
2801 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2803 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2805 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2807 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2810 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2812 Add lexical binding.
2814 * window.c (Ftemp_output_buffer_show): New fun.
2815 (Fsave_window_excursion):
2816 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2818 * lread.c (lisp_file_lexically_bound_p): New function.
2819 (Fload): Bind Qlexical_binding.
2820 (readevalloop): Remove `evalfun' arg.
2821 Bind Qinternal_interpreter_environment.
2822 (Feval_buffer): Bind Qlexical_binding.
2823 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2825 (syms_of_lread): Declare `lexical-binding'.
2827 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2829 * keyboard.c (eval_dyn): New fun.
2830 (menu_item_eval_property): Use it.
2832 * image.c (parse_image_spec): Use Ffunctionp.
2834 * fns.c (concat, mapcar1): Accept byte-code-functions.
2836 * eval.c (Fsetq): Handle lexical vars.
2837 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2838 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2839 (FletX, Flet): Obey lexical binding.
2840 (Fcommandp): Handle closures.
2841 (Feval): New `lexical' arg.
2842 (eval_sub): New function extracted from Feval. Use it almost
2843 everywhere where Feval was used. Look up vars in lexical env.
2845 (Ffunctionp): Move from subr.el.
2846 (Ffuncall): Handle closures.
2847 (apply_lambda): Remove `eval_flags'.
2848 (funcall_lambda): Handle closures and new byte-code-functions.
2849 (Fspecial_variable_p): New function.
2850 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2851 but without exporting it to Lisp.
2853 * doc.c (Fdocumentation, store_function_docstring):
2854 * data.c (Finteractive_form): Handle closures.
2856 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2859 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2861 (exec_byte_code): New function extracted from Fbyte_code to handle new
2862 calling convention for byte-code-functions. Add new byte-codes.
2864 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2866 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2868 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2870 * xdisp.c (redisplay_internal): Fix prototype.
2872 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2874 * xdisp.c (SCROLL_LIMIT): New macro.
2875 (try_scrolling): Use it when setting scroll_limit.
2876 Limit scrolling to 100 screen lines.
2877 (redisplay_window): Even when falling back on "recentering",
2878 position point in the window according to scroll-conservatively,
2879 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2881 (try_scrolling): When point is above the window, allow searching
2882 as far as scroll_max, or one screenful, to compute vertical
2883 distance from PT to the scroll margin position. This prevents
2884 try_scrolling from unnecessarily failing when
2885 scroll-conservatively is set to a value slightly larger than the
2886 window height. Clean up the case of PT below the margin at bottom
2887 of window: scroll_max can no longer be INT_MAX. When aggressive
2888 scrolling is in use, don't let point enter the opposite scroll
2889 margin as result of the scroll.
2890 (syms_of_xdisp) <scroll-conservatively>: Document the
2891 threshold of 100 lines for never-recentering scrolling.
2893 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2895 * dispextern.h (move_it_by_lines):
2896 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2897 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2898 (message_log_check_duplicate): Remove parameters `prev_bol' and
2899 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2900 (redisplay_internal): Remove parameter `preserve_echo_area',
2901 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2903 * indent.c (Fvertical_motion):
2904 * window.c (window_scroll_pixel_based, Frecenter):
2905 Don't pass `need_y_p' to `move_it_by_lines'.
2907 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2909 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2910 steal a few bits to be more compact.
2911 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2912 Remove unneeded casts.
2914 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2916 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2918 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2919 binding" message (bug#7967).
2921 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2923 Fix more problems found by GCC 4.6.0's static checks.
2925 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2926 Remove unused local var.
2928 * editfns.c (Fmessage_box): Remove unused local var.
2930 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2931 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2932 Omit unused local vars.
2933 * window.c (shrink_windows): Omit unused local var.
2934 * menu.c (digest_single_submenu): Omit unused local var.
2935 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2936 Omit unused local var.
2938 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2939 Don't assume string length fits in int.
2940 (keyremap_step, read_key_sequence): Use size_t for sizes.
2941 (read_key_sequence): Don't check last_real_key_start redundantly.
2943 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2944 instead of alloca (Bug#8344).
2946 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2947 (Fbacktrace_frame): Don't assume nframes fits in int.
2949 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2951 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2954 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2956 * cm.c (calccost): Turn while-do into do-while, for clarity.
2958 * keyboard.c (syms_of_keyboard): Use the same style as later
2959 in this function when indexing through an array. This also
2960 works around GCC bug 48267.
2962 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2964 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2966 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2967 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2969 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2970 This avoids undefined behavior on integer overflow, and is a bit
2971 more convenient anyway since it is compared to a size_t variable.
2973 Variadic C functions now count arguments with size_t, not int.
2974 This avoids an unnecessary limitation on 64-bit machines, which
2975 caused (substring ...) to crash on large vectors (Bug#8344).
2976 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2977 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2978 All variadic functions and their callers changed accordingly.
2979 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2980 * data.c (arith_driver, float_arith_driver): Likewise.
2981 * editfns.c (general_insert_function): Likewise.
2982 * eval.c (struct backtrace.nargs, interactive_p)
2983 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2984 (funcall_lambda, mark_backtrace): Likewise.
2985 * fns.c (concat): Likewise.
2986 * frame.c (x_set_frame_parameters): Likewise.
2987 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2988 0 if not found, not -1. All callers changed.
2990 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2991 (stack_copy_size): Now size_t, not int.
2992 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2994 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2996 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2997 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2998 All callers changed.
3000 * lisp.h (multibyte_char_to_unibyte):
3001 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3002 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3003 * character.h (CHAR_TO_BYTE8):
3004 * cmds.c (internal_self_insert):
3005 * editfns.c (general_insert_function):
3006 * keymap.c (push_key_description):
3007 * search.c (Freplace_match):
3008 * xdisp.c (message_dolog, set_message_1): All callers changed.
3010 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3012 * keyboard.c (safe_run_hook_funcall): New function.
3013 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3014 don't set the hook to nil, but remove the offending function instead.
3015 (Qcommand_hook_internal): Remove, unused.
3016 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3017 Vcommand_hook_internal.
3019 * eval.c (enum run_hooks_condition): Remove.
3020 (funcall_nil, funcall_not): New functions.
3021 (run_hook_with_args): Call each function through a `funcall' argument.
3022 Remove `cond' argument, now redundant.
3023 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3024 (Frun_hook_with_args_until_failure): Adjust accordingly.
3025 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3027 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3029 * dispextern.h (string_buffer_position): Remove declaration.
3031 * print.c (strout): Remove parameter `multibyte', unused since
3032 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3034 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3035 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3036 All callers changed.
3038 * w32.c (_wsa_errlist): Use braces for struct initializers.
3040 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3041 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3042 All callers changed.
3043 (string_buffer_position): Likewise. Also, make static (it's never
3044 used outside xdisp.c).
3045 (cursor_row_p): Remove parameter `w', unused since
3046 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3047 (decode_mode_spec): Remove parameter `precision', introduced during
3048 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3049 All callers changed.
3051 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3053 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3055 2011-03-27 Anders Lindgren <andlind@gmail.com>
3057 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3058 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3059 (ns_update_auto_hide_menu_bar): New functions.
3060 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3061 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3062 ns_constrain_all_frames.
3063 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3064 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3066 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3068 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3070 2011-03-27 Glenn Morris <rgm@gnu.org>
3072 * syssignal.h: Replace RETSIGTYPE with void.
3073 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3074 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3075 Replace SIGTYPE with void everywhere.
3076 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3077 * s/template.h (SIGTYPE): Remove commented out definition.
3079 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3081 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3082 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3084 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3086 * w32.c (read_unc_volume): Use parameter `henum', instead of
3087 global variable `wget_enum_handle'.
3089 * keymap.c (describe_vector): Remove parameters `indices' and
3090 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3091 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3093 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3095 * keyboard.c (timer_check): Remove parameter `do_it_now',
3096 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3097 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3098 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3100 * keyboard.c (read_char):
3101 * w32menu.c (w32_menu_display_help):
3102 * xmenu.c (show_help_event, menu_help_callback):
3103 Adjust calls to `show_help_echo'.
3105 * gtkutil.c (xg_maybe_add_timer):
3106 * keyboard.c (readable_events):
3107 * process.c (wait_reading_process_output):
3108 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3110 * insdel.c (adjust_markers_gap_motion):
3111 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3112 (gap_left, gap_right): Don't call it.
3114 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3116 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3117 incurred during fontification.
3119 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3121 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3122 (DEFVAR_PER_BUFFER): Don't pass it.
3124 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3125 (scrolling_window): Don't pass it.
3127 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3129 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3131 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3133 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3134 of variables specific to SELinux and computation of `encoded_absname'.
3136 * image.c (XPutPixel): Remove unused variable `height'.
3138 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3140 * unexw32.c (get_section_info): Remove unused variable `section'.
3142 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3143 (system_process_attributes): Remove unused variable `sess'.
3144 (sys_read): Remove unused variable `err'.
3146 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3147 (w32_wnd_proc): Remove unused variable `isdead'.
3148 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3149 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3150 (x_create_tip_frame): Remove unused variable `tem'.
3152 * w32inevt.c (w32_console_read_socket):
3153 Remove unused variable `no_events'.
3155 * w32term.c (x_draw_composite_glyph_string_foreground):
3156 Remove unused variable `width'.
3158 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3160 * w32term.c (x_set_glyph_string_clipping):
3161 Don't pass uninitialized region to CombineRgn.
3163 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3165 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3166 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3167 (Fx_close_connection): Remove unused variable `i'.
3169 * w32font.c (w32font_draw): Return number of glyphs.
3170 (w32font_open_internal): Remove unused variable `i'.
3171 (w32font_driver): Add missing initializer.
3173 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3174 (fill_in_menu): Remove unused variable `items_added'.
3176 * w32term.c (last_mouse_press_frame): Remove static global variable.
3177 (w32_clip_to_row): Remove unused variable `f'.
3178 (x_delete_terminal): Remove unused variable `i'.
3180 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3181 (NOTHING): Remove unused static global variable.
3182 (uniscribe_check_otf): Remove unused variable `table'.
3183 (uniscribe_font_driver): Add missing initializers.
3185 2011-03-23 Julien Danjou <julien@danjou.info>
3187 * term.c (Fsuspend_tty, Fresume_tty):
3188 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3189 * window.c (temp_output_buffer_show):
3190 * insdel.c (signal_before_change):
3191 * frame.c (Fhandle_switch_frame):
3192 * fileio.c (Fdo_auto_save):
3193 * emacs.c (Fkill_emacs):
3194 * editfns.c (save_excursion_restore):
3195 * cmds.c (internal_self_insert):
3196 * callint.c (Fcall_interactively):
3197 * buffer.c (Fkill_all_local_variables):
3198 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3200 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3201 unconditionnaly since it does the check itself.
3203 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3205 Fix more problems found by GCC 4.5.2's static checks.
3207 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3208 the first time through the loop, since we know p0 < p1 then.
3209 This also avoids a gcc -Wstrict-overflow warning.
3211 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3212 leading to a memory leak, possible in functions like
3213 load_charset_map_from_file that can allocate an unbounded number
3214 of objects (Bug#8318).
3216 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3217 that could (at least in theory) be that large.
3219 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3220 This is less likely to overflow, and avoids undefined behavior if
3221 overflow does occur. All callers changed. Use strtoul to scan
3222 for the unsigned long integer.
3223 (pint2hrstr): Simplify and tune code slightly.
3224 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3226 * scroll.c (do_scrolling): Work around GCC bug 48228.
3227 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3229 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3230 This also avoids a warning with gcc -Wstrict-overflow.
3231 (validate_x_resource_name): Simplify count usage.
3232 This also avoids a warning with gcc -Wstrict-overflow.
3234 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3237 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3239 * process.c (Fmake_network_process): Use socklen_t, not int,
3240 where POSIX says socklen_t is required in portable programs.
3241 This fixes a porting bug on hosts like 64-bit HP-UX, where
3242 socklen_t is wider than int (Bug#8277).
3243 (Fmake_network_process, server_accept_connection):
3244 (wait_reading_process_output, read_process_output):
3247 * process.c: Rename or move locals to avoid shadowing.
3248 (list_processes_1, Fmake_network_process):
3249 (read_process_output_error_handler, exec_sentinel_error_handler):
3250 Rename or move locals.
3251 (Fmake_network_process): Define label "retry_connect" only if needed.
3252 (Fnetwork_interface_info): Fix pointer signedness.
3253 (process_send_signal): Add cast to avoid pointer signedness problem.
3254 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3255 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3257 Make tparam.h and terminfo.c consistent.
3258 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3259 Include tparam.h instead, since it declares them.
3260 * cm.h (PC): Remove extern decl; tparam.h now does this.
3261 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3262 * terminfo.c: Include tparam.h, to check interfaces.
3263 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3264 (tparam): Adjust signature to match interface in tparam.h;
3265 this removes some undefined behavior. Check that outstring and len
3266 are zero, which they always are with Emacs.
3267 * tparam.h (PC, BC, UP): New extern decls.
3269 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3270 (xftfont_open): Rename locals to avoid shadowing.
3272 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3273 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3274 (OTF_TAG_SYM): Omit macro if not needed.
3275 (ftfont_list): Remove unused local.
3276 (get_adstyle_property, ftfont_pattern_entity):
3277 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3278 Rename locals to avoid shadowing.
3280 * xfont.c (xfont_list_family): Mark var as initialized.
3282 * xml.c (make_dom): Now static.
3284 * composite.c (composition_compute_stop_pos): Rename local to
3286 (composition_reseat_it): Remove unused locals.
3287 (find_automatic_composition, composition_adjust_point): Likewise.
3288 (composition_update_it): Mark var as initialized.
3289 (find_automatic_composition): Mark vars as initialized,
3290 with a FIXME (Bug#8290).
3292 character.h: Rename locals to avoid shadowing.
3293 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3294 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3295 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3296 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3299 * textprop.c (property_change_between_p): Remove; unused.
3301 * intervals.c (interval_start_pos): Now static.
3303 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3305 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3306 Rename locals to avoid shadowing.
3308 * sound.c (wav_play, au_play, Fplay_sound_internal):
3309 Fix pointer signedness.
3310 (alsa_choose_format): Remove unused local var.
3311 (wav_play): Initialize a variable to 0, to prevent undefined
3312 behavior (Bug#8278).
3314 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3316 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3318 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3319 clobbering (Bug#8298).
3320 * sysdep.c (sys_subshell): Likewise.
3321 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3323 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3324 This should get cleaned up, so that child_setup has the
3325 same signature on all platforms.
3327 * callproc.c (call_process_cleanup): Now static.
3328 (relocate_fd): Rename locals to avoid shadowing.
3330 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3332 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3333 not to be necessary, and produces flickering.
3335 2011-03-20 Glenn Morris <rgm@gnu.org>
3337 * config.in: Remove file.
3339 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3341 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3342 are now in src/globals.h.
3343 (syms_of_minibuf): Remove spurious & from previous change.
3345 2011-03-20 Leo <sdl.web@gmail.com>
3347 * minibuf.c (completing-read-function): New variable.
3348 (completing-read-default): Rename from completing-read.
3349 (completing-read): Call completing-read-function.
3351 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3353 * xfaces.c (Fx_load_color_file):
3354 Read color file from absolute filename (bug#8250).
3356 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3358 * makefile.w32-in: Update dependencies.
3360 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3362 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3364 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3366 Fix more problems found by GCC 4.5.2's static checks.
3368 * process.c (make_serial_process_unwind, send_process_trap):
3369 (sigchld_handler): Now static.
3371 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3372 That way, the code declares only the vars that it needs.
3373 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3374 * s/cygwin.h (PTY_ITERATION): Likewise.
3375 * s/darwin.h (PTY_ITERATION): Likewise.
3376 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3378 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3379 * process.c (allocate_pty): Don't declare stb unless it's needed.
3381 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3382 (CONSTANTLIM): Remove; unused.
3383 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3384 Define only if needed.
3386 * unexelf.c (unexec): Name an expression,
3387 to avoid gcc -Wbad-function-cast warning.
3388 Use a different way to cause a compilation error if anyone uses
3389 n rather than nn, a way that does not involve shadowing.
3390 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3392 * deps.mk (unexalpha.o): Remove; unused.
3394 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3395 * unexec.h: New file.
3396 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3397 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3399 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3400 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3401 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3402 Change as necessary to match prototype in unexec.h.
3404 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3406 (back_comment, skip_chars): Mark vars as initialized.
3408 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3409 Rename locals to avoid shadowing.
3411 * lread.c (read1): Rewrite so as not to use empty "else".
3412 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3414 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3416 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3417 warning when compiling print.c.
3419 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3420 instead of using an uninitialized var.
3421 (font_sort_entities): Mark var as initialized.
3423 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3425 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3426 pointers to constants.
3427 (font_parse_fcname): Remove unused vars.
3428 (font_delete_unmatched): Now static.
3429 (font_get_spec): Remove; unused.
3430 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3431 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3432 Rename or move locals to avoid shadowing.
3434 * fns.c (require_nesting_list, require_unwind): Now static.
3435 (Ffillarray): Rename locals to avoid shadowing.
3437 * floatfns.c (domain_error2): Define only if needed.
3438 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3440 * alloc.c (mark_backtrace): Move decl from here ...
3441 * lisp.h: ... to here, so that it can be checked.
3443 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3444 (Fdefvar): Rewrite so as not to use empty "else".
3445 (lisp_indirect_variable): Name an expression,
3446 to avoid gcc -Wbad-function-cast warning.
3447 (Fdefvar): Rename locals to avoid shadowing.
3449 * callint.c (quotify_arg, quotify_args): Now static.
3450 (Fcall_interactively): Rename locals to avoid shadowing.
3451 Use const pointer when appropriate.
3453 * lisp.h (get_system_name, get_operating_system_release):
3454 Move decls here, to check interfaces.
3455 * process.c (get_operating_system_release): Move decl to lisp.h.
3456 * xrdb.c (get_system_name): Likewise.
3457 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3458 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3459 some of which prompt warnings from gcc -Wbad-function-cast.
3460 (Fformat_time_string, Fencode_time, Finsert_char):
3461 (Ftranslate_region_internal, Fformat):
3462 Rename or remove local vars to avoid shadowing.
3463 (Ftranslate_region_internal): Mark var as initialized.
3465 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3468 * lisp.h (eassert): Check that the argument compiles, even if
3469 ENABLE_CHECKING is not defined.
3471 * data.c (Findirect_variable): Name an expression, to avoid
3472 gcc -Wbad-function-cast warning.
3473 (default_value, arithcompare, arith_driver, arith_error): Now static.
3474 (store_symval_forwarding): Rename local to avoid shadowing.
3475 (Fmake_variable_buffer_local, Fmake_local_variable):
3476 Mark variables as initialized.
3477 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3479 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3480 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3481 Rename locals to avoid shadowing.
3482 (mark_stack): Move local variables into the #ifdef region where
3484 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3485 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3487 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3488 (GC_STRING_CHARS): Remove; not used.
3489 (Fmemory_limit): Cast sbrk's returned value to char *.
3491 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3492 avoids undefined behavior in theory.
3494 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3496 Use functions, not macros, for up- and down-casing (Bug#8254).
3497 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3498 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3499 to use the following functions instead of these macros.
3500 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3501 EMACS_INT, since callers assume the returned value fits in int.
3502 (upcase1): Likewise, for UPCASE_TABLE.
3503 (uppercasep, lowercasep, upcase): New static inline functions.
3504 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3505 the race-condition problem in the old DOWNCASE.
3507 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3508 Rename locals to avoid shadowing.
3509 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3510 (regex_compile, re_search_2, re_match_2_internal):
3511 Remove unused local vars.
3512 (FREE_VAR): Rewrite so as not to use empty "else",
3513 which gcc can warn about.
3514 (regex_compile, re_match_2_internal): Mark locals as initialized.
3515 (RETALLOC_IF): Define only if needed.
3516 (WORDCHAR_P): Likewise. This one is never needed, but is used
3517 only in a comment talking about a compiler bug, so put inside
3518 the #if 0 of that comment.
3519 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3520 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3523 * search.c (boyer_moore): Rename locals to avoid shadowing.
3524 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3525 (PREV_CHAR_BOUNDARY): Likewise.
3527 * search.c (simple_search): Remove unused var.
3529 * dired.c (compile_pattern): Move decl from here ...
3530 * lisp.h: ... to here, so that it can be checked.
3531 (struct re_registers): New forward decl.
3533 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3535 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3537 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3538 Rename locals to avoid shadowing.
3539 (Fvertical_motion): Mark locals as initialized.
3541 * casefiddle.c (casify_object, casify_region): Now static.
3542 (casify_region): Mark local as initialized.
3544 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3546 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3547 New macros, so that the caller can use some names other than
3548 gcpro1, gcpro2, etc.
3549 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3551 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3552 argument, for consistency with GCPRO2_VAR, etc: it is now the
3553 prefix of the variable, not the variable itself. All uses
3555 * dired.c (directory_files_internal, file_name_completion):
3556 Rename locals to avoid shadowing.
3558 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3559 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3560 dired.c's scmp function, had undefined behavior.
3561 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3562 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3563 * buffer.h: ... to here, because these macros use current_buffer,
3564 and the new implementation with inline functions needs to have
3565 current_buffer in scope now, rather than later when the macros
3567 (downcase, upcase1): New static inline functions.
3568 (DOWNCASE, UPCASE1): Reimplement using these functions.
3569 This avoids undefined behavior in expressions like
3570 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3571 from race conditions in accessing the global variables
3572 case_temp1 and case_temp2.
3573 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3574 * lisp.h (case_temp1, case_temp2): Remove their decls.
3575 * character.h (ASCII_CHAR_P): Move from here ...
3576 * lisp.h: ... to here, so that the inline functions mentioned
3579 * dired.c (directory_files_internal_unwind): Now static.
3581 * fileio.c (file_name_as_directory, directory_file_name):
3582 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3584 (file_name_as_directory): Use const pointers when appropriate.
3585 (Fexpand_file_name): Likewise. In particular, newdir might
3586 point at constant storage, so make it a const pointer.
3587 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3588 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3590 (Fset_file_times, Finsert_file_contents, auto_save_error):
3591 Rename locals to avoid shadowing.
3593 * minibuf.c (choose_minibuf_frame_1): Now static.
3594 (Ftry_completion, Fall_completions): Rename or remove locals
3597 * marker.c (bytepos_to_charpos): Remove; unused.
3599 * lisp.h (verify_bytepos, count_markers): New decls,
3600 so that gcc does not warn that these functions aren't declared.
3602 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3603 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3604 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3605 (copy_text): Remove unused local var.
3607 * filelock.c (within_one_second): Now static.
3608 (lock_file_1): Rename local to avoid shadowing.
3610 * buffer.c (fix_overlays_before): Mark locals as initialized.
3611 (fix_start_end_in_overlays): Likewise. This function should be
3612 simplified by using pointers-to-pointers, but that's a different
3614 (switch_to_buffer_1): Now static.
3615 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3616 (report_overlay_modification): Rename locals to avoid shadowing.
3618 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3619 Fix pointer signedness issue.
3620 (sys_subshell): Mark local as volatile if checking for lint,
3621 to suppress a gcc -Wclobbered warning that does not seem to be right.
3622 (MAXPATHLEN): Define only if needed.
3624 * process.c (serial_open, serial_configure): Move decls from here ...
3625 * systty.h: ... to here, so that they can be checked.
3627 * fns.c (get_random, seed_random): Move extern decls from here ...
3628 * lisp.h: ... to here, so that they can be checked.
3630 * sysdep.c (reset_io): Now static.
3631 (wait_for_termination_signal): Remove; unused.
3633 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3634 (copy_keymap_item, append_key, push_text_char_description):
3636 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3637 (DENSE_TABLE_SIZE): Remove; unused.
3638 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3639 (describe_map_tree):
3640 Rename locals to avoid shadowing.
3642 * keyboard.c: Declare functions static if they are not used elsewhere.
3643 (echo_char, echo_dash, cmd_error, top_level_2):
3644 (poll_for_input, handle_async_input): Now static.
3645 (read_char, kbd_buffer_get_event, make_lispy_position):
3646 (make_lispy_event, make_lispy_movement, apply_modifiers):
3647 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3648 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3649 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3650 (read_key_sequence, read_char): Mark locals as initialized.
3651 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3653 * keyboard.h (make_ctrl_char): New decl.
3654 (mark_kboards): Move decl here ...
3655 * alloc.c (mark_kboards): ... from here.
3657 * lisp.h (force_auto_save_soon): New decl.
3659 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3660 (DEFINE_DUMMY_FUNCTION): New macro.
3661 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3663 (main): Add casts to avoid warnings
3664 if GCC considers string literals to be constants.
3666 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3668 * dbusbind.c: Pointer signedness fixes.
3669 (xd_signature, xd_append_arg, xd_initialize):
3670 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3671 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3672 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3673 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3675 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3676 if GCC considers string literals to be constants.
3677 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3679 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3682 (print_preprocess, print_object): New macro to fix last change.
3684 * print.c (print_preprocess): Don't forget font objects.
3686 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3688 * emacs.c (USAGE3): Doc fixes.
3690 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3692 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3695 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3697 * lisp.h (VWindow_system, Qfile_name_history):
3698 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3699 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3700 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3702 * w32select.c: Don't #include "keyboard.h".
3703 (run_protected): Add extern declaration for waiting_for_input.
3705 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3706 * w32console.c (detect_input_pending, read_input_pending)
3707 (encode_terminal_code):
3708 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3709 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3710 (w32_system_caret_y, Qfile_name_history):
3711 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3712 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3713 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3714 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3715 * w32proc.c (Qlocal, report_file_error):
3716 * w32term.c (Vwindow_system, updating_frame):
3717 * w32uniscribe.c (initialized, uniscribe_font_driver):
3718 Remove unneeded extern declarations.
3720 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3722 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3724 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3726 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3727 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3728 These macros can no longer be used for assignment.
3730 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3731 Assign struct members directly, instead of using BUF_BEGV etc.
3732 (record_buffer_markers, fetch_buffer_markers): New functions for
3733 recording and fetching special buffer markers.
3734 (set_buffer_internal_1, set_buffer_temp): Use them.
3736 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3738 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3740 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3741 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3743 * xdisp.c (hscroll_window_tree):
3744 (reconsider_clip_changes): Use PT instead of BUF_PT.
3746 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3748 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3749 $(EMACS_ROOT)/lib/intprops.h.
3751 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3753 Fix more problems found by GCC 4.5.2's static checks.
3755 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3756 to unsigned char * to avoid compiler diagnostic.
3757 (xg_free_frame_widgets): Make it clear that a local variable is
3758 needed only if USE_GTK_TOOLTIP.
3759 (gdk_window_get_screen): Make it clear that this macro is needed
3760 only if USE_GTK_TOOLTIP.
3761 (int_gtk_range_get_value): New function, which avoids a diagnostic
3762 from gcc -Wbad-function-cast.
3763 (xg_set_toolkit_scroll_bar_thumb): Use it.
3764 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3765 diagnostic from gcc -Wbad-function-cast.
3766 (get_utf8_string, xg_get_file_with_chooser):
3767 Rename locals to avoid shadowing.
3768 (create_dialog): Move locals to avoid shadowing.
3770 * xgselect.c (xg_select): Remove unused var.
3772 * image.c (four_corners_best): Mark locals as initialized.
3773 (gif_load): Initialize transparent_p to zero (Bug#8238).
3774 Mark another local as initialized.
3775 (my_png_error, my_error_exit): Mark with NO_RETURN.
3777 * image.c (clear_image_cache): Now static.
3778 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3779 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3780 (x_edge_detection): Remove unnecessary cast that
3781 gcc -Wbad-function-cast diagnoses.
3782 (gif_load): Fix pointer signedness.
3783 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3784 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3786 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3788 Improve quality of tests for time stamp overflow.
3789 For example, without this patch (encode-time 0 0 0 1 1
3790 1152921504606846976) returns the obviously-bogus value (-948597
3791 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3792 reports time overflow. See
3793 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3794 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3795 * editfns.c: Include limits.h and intprops.h.
3796 (TIME_T_MIN, TIME_T_MAX): New macros.
3797 (time_overflow): Move earlier, to before first use.
3798 (hi_time, lo_time): New functions, for an accurate test for
3800 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3801 (Fget_internal_run_time): Don't assume time_t fits in int.
3802 (make_time): Use list2 instead of Fcons twice.
3803 (Fdecode_time): More accurate test for out-of-range times.
3804 (check_tm_member): New function.
3805 (Fencode_time): Use it, to test for out-of-range times.
3806 (lisp_time_argument): Don't rely on undefined left-shift and
3807 right-shift behavior when checking for time stamp overflow.
3809 * editfns.c (time_overflow): New function, refactoring common code.
3810 (Fformat_time_string, Fdecode_time, Fencode_time):
3811 (Fcurrent_time_string): Use it.
3813 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3814 * dired.c (make_time): Move to ...
3815 * editfns.c (make_time): ... here.
3816 * systime.h: Note the move.
3818 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3820 * fringe.c (update_window_fringes): Remove unused variables.
3822 * unexmacosx.c (copy_data_segment): Also copy __got section.
3825 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3827 * termcap.c [MSDOS]: Include "msdos.h".
3828 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3829 Constify `char *' arguments and their references according to
3830 prototypes in tparam.h.
3832 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3834 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3835 Adapt all references accordingly.
3837 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3839 2011-03-11 Tom Tromey <tromey@redhat.com>
3841 * buffer.c (syms_of_buffer): Remove obsolete comment.
3843 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3845 * termhooks.h (encode_terminal_code): Declare prototype.
3847 * msdos.c (encode_terminal_code): Don't declare prototype.
3849 * term.c (encode_terminal_code): Now external again, used by
3850 w32console.c and msdos.c.
3852 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3853 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3855 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3857 Fix some minor problems found by GCC 4.5.2's static checks.
3859 * fringe.c (update_window_fringes): Mark locals as initialized
3861 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3863 * alloc.c (mark_fringe_data): Move decl from here ...
3864 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3865 to check its interface.
3866 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3868 * fontset.c (free_realized_fontset): Now static.
3869 (Fset_fontset_font): Rename local to avoid shadowing.
3870 (fontset_font): Mark local as initialized.
3871 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3873 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3875 * xselect.c (x_disown_buffer_selections): Remove; not used.
3876 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3877 (x_own_selection, Fx_disown_selection_internal): Rename locals
3879 (x_handle_dnd_message): Remove local to avoid shadowing.
3881 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3882 so that the caller can use some name other than gcpro1.
3883 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3884 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3885 (Fx_backspace_delete_keys_p):
3886 Use them to avoid shadowing, and rename vars to avoid shadowing.
3887 (x_decode_color, x_set_name, x_window): Now static.
3888 (Fx_create_frame): Add braces to silence GCC warning.
3889 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3890 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3891 Remove unused locals.
3892 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3893 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3894 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3897 * xterm.h (x_mouse_leave): New decl.
3899 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3900 Remove unused functions.
3901 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3902 (x_calc_absolute_position): Now static.
3903 (XTread_socket): Don't define label "out" unless it's used.
3904 Don't declare local "event" unless it's used.
3905 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3906 unless they are used.
3907 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3908 (x_fatal_error_signal): Remove; not used.
3909 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3910 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3911 (x_error_catcher, x_connection_closed, x_error_handler):
3912 (x_error_quitter, xembed_send_message, x_iconify_frame):
3913 (my_log_handler): Rename locals to avoid shadowing.
3914 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3915 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3917 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3918 Rename or move locals to avoid shadowing.
3919 (tty_defined_color, merge_face_heights): Now static.
3920 (free_realized_faces_for_fontset): Remove; not used.
3921 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3922 does not deduce is never used uninitialized.
3923 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3924 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3926 * terminal.c (store_terminal_param): Now static.
3928 * xmenu.c (menu_highlight_callback): Now static.
3929 (set_frame_menubar): Remove unused local.
3930 (xmenu_show): Rename parameter to avoid shadowing.
3931 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3932 since they might point to immutable storage.
3933 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3934 since it's unused otherwise.
3936 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3937 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3938 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3939 avoids a gcc -Wuninitialized diagnostic.
3940 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3941 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3942 does not deduce are never used uninitialized.
3944 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3946 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3947 * window.c (window_loop, size_window):
3948 (run_window_configuration_change_hook, enlarge_window): Likewise.
3950 * window.c (display_buffer): Now static.
3951 (size_window): Mark variables that gcc -Wuninitialized
3952 does not deduce are never used uninitialized.
3953 * window.h (check_all_windows): New decl, to forestall
3954 gcc -Wmissing-prototypes diagnostic.
3955 * dispextern.h (bidi_dump_cached_states): Likewise.
3957 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3959 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3961 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3962 and to avoid gcc -Wuninitialized warning.
3963 (load_charset_map): Mark variables that gcc -Wuninitialized
3964 does not deduce are never used uninitialized.
3965 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3967 * coding.c (coding_set_source, coding_set_destination):
3968 Use "else { /* comment */ }" rather than "else /* comment */;"
3969 for clarity, and to avoid gcc -Wempty-body warning.
3970 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3971 a block, when the outer 'i' will do.
3972 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3973 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3974 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3975 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3976 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3977 Rename locals to avoid shadowing.
3978 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3979 * coding.c (emacs_mule_char, encode_invocation_designation):
3980 Now static, since they're not used elsewhere.
3981 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3982 (decode_coding_object, encode_coding_object, detect_coding_system):
3983 (decode_coding_emacs_mule): Mark variables that gcc
3984 -Wuninitialized does not deduce are never used uninitialized.
3985 (detect_coding_iso_2022): Initialize a local variable that might
3986 be used uninitialized. Leave a FIXME because it's not clear that
3987 this initialization is needed. (Bug#8211)
3988 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3989 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3990 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3991 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3992 Remove unused macros.
3994 * category.c (hash_get_category_set): Remove unused local var.
3995 (copy_category_table): Now static, since it's not used elsewhere.
3996 * character.c (string_count_byte8): Likewise.
3998 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3999 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4001 * chartab.c (copy_sub_char_table): Now static, since it's not used
4003 (sub_char_table_ref_and_range, char_table_ref_and_range):
4004 Rename locals to avoid shadowing.
4005 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4007 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4008 (BIDI_BOB): Remove unused macro.
4010 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4011 deduce are never used uninitialized.
4012 * term.c (encode_terminal_code): Likewise.
4014 * term.c (encode_terminal_code): Now static. Remove unused local.
4016 * tparam.h: New file.
4017 * term.c, tparam.h: Include it.
4018 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4019 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4020 Move these decls to tparam.h, and make them agree with what
4021 is actually in tparam.c. The previous trick of using incompatible
4022 decls in different modules does not conform to the C standard.
4023 All callers of tparam changed to use tparam's actual API.
4024 * tparam.c (tparam1, tparam, tgoto):
4025 Use const pointers where appropriate.
4027 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4028 * cm.h (struct cm): Likewise.
4029 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4030 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4031 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4032 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4033 (turn_on_face, init_tty): Likewise.
4034 * termchar.h (struct tty_display_info): Likewise.
4036 * term.c (term_mouse_position): Rename local to avoid shadowing.
4038 * alloc.c (mark_ttys): Move decl from here ...
4039 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4041 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4043 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4045 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4047 * search.c (compile_pattern_1): Remove argument regp, unused since
4048 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4049 (compile_pattern): Don't pass it.
4051 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4053 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4054 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4056 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4058 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4060 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4061 gdk_window_get_screen, gdk_window_get_geometry,
4062 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4063 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4064 (xg_get_pixbuf_from_pixmap): New function.
4065 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4066 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4067 Call xg_get_pixbuf_from_pixmap instead of
4068 gdk_pixbuf_get_from_drawable.
4069 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4070 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4071 (xg_check_special_colors): Use GtkStyleContext and its functions
4073 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4074 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4075 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4076 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4077 Call gtk_widget_get_preferred_size.
4078 (xg_frame_resized): gdk_window_get_geometry only takes 5
4080 (xg_win_to_widget, xg_event_is_for_menubar):
4081 Call gdk_x11_window_lookup_for_display.
4082 (xg_set_widget_bg): New function.
4083 (delete_cb): New function.
4084 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4085 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4086 (xg_set_background_color): Call xg_set_widget_bg.
4087 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4088 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4089 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4090 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4092 (update_frame_tool_bar): Call gtk_widget_hide.
4093 (xg_initialize): Use GDK_KEY_g.
4095 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4097 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4099 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4100 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4101 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4103 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4105 * w32xfns.c (select_palette): Check success of RealizePalette against
4106 GDI_ERROR, not zero.
4108 See ChangeLog.11 for earlier changes.
4114 Copyright (C) 2011 Free Software Foundation, Inc.
4116 This file is part of GNU Emacs.
4118 GNU Emacs is free software: you can redistribute it and/or modify
4119 it under the terms of the GNU General Public License as published by
4120 the Free Software Foundation, either version 3 of the License, or
4121 (at your option) any later version.
4123 GNU Emacs is distributed in the hope that it will be useful,
4124 but WITHOUT ANY WARRANTY; without even the implied warranty of
4125 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4126 GNU General Public License for more details.
4128 You should have received a copy of the GNU General Public License
4129 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.