1 2011-06-25 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (handle_single_display_spec, next_overlay_string)
4 (get_overlay_strings_1, push_display_prop): Set up the bidi
5 iterator for displaying display or overlay strings.
6 (forward_to_next_line_start): Don't use the shortcut if
8 (back_to_previous_visible_line_start): If handle_display_prop
9 pushed the iterator stack, restore the internal state of the bidi
10 iterator by calling bidi_pop_it same number of times.
11 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12 and we are bidi-iterating, don't decrement the iterator position;
13 instead, set the first_elt flag in the bidi iterator, to produce
15 (reseat_1): Remove redundant setting of string_from_display_prop_p.
16 (push_display_prop): xassert that we are iterating a buffer.
18 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
20 2011-06-24 Eli Zaretskii <eliz@gnu.org>
22 * xdisp.c (push_it, pop_it): Save and restore the state of the
23 bidi iterator. Save and restore the bidi_p flag.
24 (pop_it): Iterate out of display property for string iteration as
26 (iterate_out_of_display_property): Support iteration over strings.
27 (handle_single_display_spec): Set up it->bidi_it for iteration
28 over a display string, and call bidi_init_it.
30 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
31 (struct it): Member bidi_p is now a bit field 1 bit wide.
33 2011-06-23 Eli Zaretskii <eliz@gnu.org>
35 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
37 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
38 (bidi_initialize): Initialize the bidi cache start stack pointer.
39 (bidi_cache_ensure_space): New function, refactored from part of
40 bidi_cache_iterator_state.
42 2011-06-18 Eli Zaretskii <eliz@gnu.org>
44 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
45 (display_menu_bar): Force left-to-right direction. Add a FIXME
46 comment for making that be controlled by a user option.
48 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
51 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
52 it->what accepted by the xassert. Fixes a gratuitous crash in an
53 Emacs built with -DXASSERTS.
55 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
56 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
57 and vector-like objects.
59 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
60 (next_element_from_c_string): Handle the case of the first string
61 character that is not the first one in the visual order.
62 (get_visually_first_element): New function, refactored from common
63 parts of next_element_from_buffer, next_element_from_string, and
64 next_element_from_c_string.
66 2011-06-16 Eli Zaretskii <eliz@gnu.org>
68 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
70 (reseat_to_string): Initialize it->bidi_p for strings here.
71 (next_element_from_string, next_element_from_c_string)
72 (next_element_from_buffer): Add xassert's for correspondence
73 between IT's object being iterated and it->bidi_it.string
76 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
77 the sentinel state in the cache.
79 2011-06-13 Eli Zaretskii <eliz@gnu.org>
81 * xdisp.c (compute_display_string_pos)
82 (compute_display_string_end, reseat_to_string): Don't assume
83 it->bidi_it.string.s always points to string.lstring's data.
85 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
86 (bidi_resolve_explicit_1, bidi_resolve_explicit)
87 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
88 string.s always points to string.lstring's data.
90 2011-06-11 Eli Zaretskii <eliz@gnu.org>
92 * xdisp.c (set_iterator_to_next): Advance string position
93 correctly when padding it with blanks.
95 2011-06-11 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (next_element_from_buffer): Improve commentary for when
98 the iterator is before prev_stop.
99 (init_iterator): Initialize bidi_p from the default value of
100 bidi-display-reordering, not from buffer-local value. Use the
101 buffer-local value only if initializing for buffer iteration.
102 (handle_invisible_prop): Support invisible properties on strings
103 that are being bidi-reordered.
104 (reseat_to_string): Enable bidi-related code.
105 (set_iterator_to_next): Support bidi reordering of C strings and
107 (next_element_from_string): Support bidi reordering of Lisp
109 (handle_stop_backwards): Support Lisp strings as well.
110 (display_mode_line, display_mode_element): Temporarily force L2R
112 (display_string): Support display of R2L glyph rows. Use
113 IT_STRING_CHARPOS when displaying from a Lisp string.
115 2011-06-10 Eli Zaretskii <eliz@gnu.org>
117 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
119 (compute_display_string_pos, compute_display_string_end):
120 Fix calculation of the object to scan. Fixes an error when using
122 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
123 base_level_stop; instead, set base_level_stop to BEGV. Fixes
124 crashes in vertical-motion.
126 2011-06-09 Eli Zaretskii <eliz@gnu.org>
128 * xdisp.c (compute_display_string_pos): First arg is now struct
129 `text_pos *'; all callers changed. Support display properties on
131 (compute_display_string_end): Support display properties on Lisp
133 (init_iterator, reseat_1, reseat_to_string): Initialize the
134 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
135 when iterating on a string not from display properties).
137 * bidi.c (bidi_fetch_char): Support strings with display
140 * dispextern.h (struct bidi_string_data): New member bufpos.
141 (compute_display_string_pos): Update prototype.
143 2011-06-09 Eli Zaretskii <eliz@gnu.org>
145 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
146 to pass the test for valid cached positions.
148 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
149 buffer position was specified. Initialize paragraph_embedding to
151 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
153 (display_string): If we need to ignore text properties of
154 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
155 original value of -1 will not work with bidi.)
157 * dispextern.h (struct bidi_string_data): New member lstring.
159 2011-06-09 Eli Zaretskii <eliz@gnu.org>
161 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
162 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
164 2011-06-08 Eli Zaretskii <eliz@gnu.org>
166 * bidi.c (bidi_paragraph_info): Delete unused struct.
167 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
168 (bidi_cache_start): New variable.
169 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
171 (bidi_cache_fetch_state, bidi_cache_search)
172 (bidi_cache_find_level_change, bidi_cache_iterator_state)
173 (bidi_cache_find, bidi_peek_at_next_level)
174 (bidi_level_of_next_char, bidi_find_other_level_edge)
175 (bidi_move_to_visually_next): Compare cache index with
176 bidi_cache_start rather than with zero.
177 (bidi_fetch_char): Accept new argument STRING; all callers
178 changed. Support iteration over a string.
179 (bidi_paragraph_init, bidi_resolve_explicit_1)
180 (bidi_resolve_explicit, bidi_resolve_weak)
181 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
182 iteration over a string.
183 (bidi_set_sor_type, bidi_resolve_explicit_1)
184 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
185 can now be zero (for strings); special values 0 and -1 were
186 changed to -1 and -2, respectively.
187 (bidi_char_at_pos): New function.
188 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
189 Call it instead of FETCH_MULTIBYTE_CHAR.
190 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
191 initialized to valid values.
192 (bidi_init_it): Don't initialize charpos and bytepos with invalid
195 * xdisp.c (compute_display_string_pos)
196 (compute_display_string_end): Accept additional argument STRING.
197 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
198 (reseat_to_string): Initialize bidi_it->string.s and
199 bidi_it->string.schars.
201 * dispextern.h (struct bidi_string_data): New structure.
202 (struct bidi_it): New member `string'. Make flag members be 1-bit
203 fields, and put them last in the struct.
204 (compute_display_string_pos, compute_display_string_end): Update
207 2011-06-04 Eli Zaretskii <eliz@gnu.org>
209 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
211 2011-06-03 Eli Zaretskii <eliz@gnu.org>
213 * bidi.c (bidi_fetch_char_advance): Remove unused and
214 unimplemented function.
216 2011-05-28 Eli Zaretskii <eliz@gnu.org>
218 * xdisp.c (set_cursor_from_row): Set start and stop points
219 according to the row's direction when priming the loop that looks
220 for the glyph on which to display cursor.
221 (single_display_spec_intangible_p): Function deleted.
222 (display_prop_intangible_p): Reimplement to call
223 handle_display_spec instead of single_display_spec_intangible_p.
224 Accept 3 additional arguments needed by handle_display_spec. This
225 fixes incorrect cursor motion across display property with complex
226 values: lists, `(when COND...)' forms, etc.
227 (single_display_spec_string_p): Support property values that are
228 lists with the argument STRING its top-level element.
229 (display_prop_string_p): Fix the condition for processing a
230 property that is a list to be consistent with handle_display_spec.
232 * keyboard.c (adjust_point_for_property): Adjust the call to
233 display_prop_intangible_p to its new signature.
235 * dispextern.h (display_prop_intangible_p): Adjust prototype.
237 2011-05-21 Eli Zaretskii <eliz@gnu.org>
239 * xdisp.c (handle_display_spec): New function, refactored from the
240 last portion of handle_display_prop.
241 (compute_display_string_pos): Accept additional argument
242 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
243 value of a `display' property is a "replacing spec".
244 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
245 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
246 the display property, but just return a value indicating whether
247 the display property will replace the characters it covers.
248 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
249 frame_window_p members of struct bidi_it.
251 * bidi.c (bidi_fetch_char): Accept additional argument
252 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
254 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
255 it to initialize the frame_window_p member of struct bidi_it.
257 * dispextern.h (struct bidi_it): New member frame_window_p.
258 (bidi_init_it, compute_display_string_pos): Update prototypes.
260 2011-05-14 Eli Zaretskii <eliz@gnu.org>
262 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
263 (compute_display_string_end): New function.
264 (push_it): Accept second argument POSITION, where pop_it should
265 jump to continue iteration.
267 * dispextern.h (compute_display_string_end): Declare prototype.
269 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
270 (bidi_fetch_char): Implement support for runs of characters
271 covered by display strings.
273 * bidi.c (bidi_fetch_char): Accept also character position
274 corresponding to BYTEPOS. DISP_POS is now a character position,
275 not a byte position. All callers changed.
276 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
277 (bidi_resolve_explicit, bidi_resolve_weak)
278 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
279 bidi_it->nchars is non-positive.
280 (bidi_level_of_next_char): Don't try to lookup the cache for the
281 next/previous character if nothing is cached there yet, or if we
282 were just reseat()'ed to a new position.
283 (bidi_paragraph_init, bidi_resolve_explicit_1)
284 (bidi_level_of_next_char): Fix arguments in the calls to
287 2011-05-10 Eli Zaretskii <eliz@gnu.org>
289 * xdisp.c (compute_display_string_pos): New function.
290 (reseat_1): Initialize bidi_it.disp_pos.
292 * bidi.c (bidi_copy_it): Use offsetof.
293 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
294 (bidi_cache_search, bidi_cache_iterator_state)
295 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
296 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
297 character positions inside a run of characters covered by a
299 (bidi_paragraph_init, bidi_resolve_explicit_1)
300 (bidi_level_of_next_char): Call bidi_fetch_char and
301 bidi_fetch_char_advance instead of FETCH_CHAR and
303 (bidi_init_it): Initialize new members.
304 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
306 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
307 instead of using explicit *_CHAR codes.
308 (bidi_resolve_explicit, bidi_resolve_weak): Use
309 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
310 bidirectional text is supported only in multibyte buffers.
312 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
313 ch_len is now EMACS_INT.
314 (compute_display_string_pos): Declare prototype.
316 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
318 * w32menu.c (set_frame_menubar): Fix submenu allocation.
320 2011-05-07 Eli Zaretskii <eliz@gnu.org>
322 * w32console.c (Fset_screen_color): Doc fix.
323 (Fget_screen_color): New function.
324 (syms_of_ntterm): Defsubr it.
326 * callproc.c (call_process_cleanup): Don't close and unlink the
327 temporary file if Fcall_process didn't create it in the first
329 (Fcall_process): Don't create tempfile if stdout of the child
330 process will be redirected to a file specified with `:file'.
331 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
332 cue to call_process_cleanup not to close that handle.
334 2011-05-07 Ben Key <bkey76@gmail.com>
336 * makefile.w32-in: The bootstrap-temacs rule now makes use of
337 one of two shell specific rules, either bootstrap-temacs-CMD or
338 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
339 to the previous implementation of the bootstrap-temacs rule.
340 The bootstrap-temacs-CMD rule is similar to the previous
341 implementation of the bootstrap-temacs rule except that it
342 makes use of the ESC_CFLAGS variable instead of the CFLAGS
345 These changes, along with some changes to nt/configure.bat,
346 nt/gmake.defs, and nt/nmake.defs, are required to extend my
347 earlier fix to add support for --cflags and --ldflags options
348 that include quotes so that it works whether make uses cmd or
351 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
353 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
354 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
356 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
357 a string. Handle both cases.
358 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
359 (Fdbus_register_method): Use Qinvalid_function.
361 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
363 * makefile.w32-in: Update dependencies.
364 (LISP_H): Add inttypes.h and stdin.h.
365 (PROCESS_H): Add unistd.h.
367 2011-05-06 Eli Zaretskii <eliz@gnu.org>
369 * lread.c: Include limits.h (fixes the MS-Windows build broken by
370 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
372 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
374 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
376 * term.c (vfatal): Remove stray call to va_end.
377 It's not needed and the C Standard doesn't allow it here anyway.
379 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
380 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
382 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
385 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
389 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
391 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
393 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
395 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
396 * charset.c (Fdefine_charset_internal): Don't initialize
397 charset.code_space[15]. The value was garbage, on hosts with
398 32-bit int (Bug#8600).
400 * lread.c (read_integer): Be more consistent with string-to-number.
401 Use string_to_number to do the actual conversion; this avoids
402 rounding errors and fixes some other screwups. Without this fix,
403 for example, #x1fffffffffffffff was misread as -2305843009213693952.
404 (digit_to_number): Move earlier, for benefit of read_integer.
405 Return -1 if the digit is out of range for the base, -2 if it is
406 not a digit in any supported base. (Bug#8602)
408 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
410 * dispnew.c (scrolling_window): Return 1 if we scrolled,
411 to match comment at start of function. This also removes a
412 GCC warning about overflow in a 32+64-bit port.
414 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
416 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
417 Reported by Stefan Monnier in
418 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
419 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
420 SYMBOLP-guarded XSYMBOL, not XPNTR.
422 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
423 (EMACS_UINTPTR): Likewise, with uintptr_t.
425 * lisp.h: Prefer 64-bit EMACS_INT if available.
426 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
427 on 32-bit hosts that have 64-bit int, so that they can access
429 However, temporarily disable this change unless the temporary
430 symbol WIDE_EMACS_INT is defined.
432 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
434 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
435 This removes an assumption that EMACS_INT and long are the same
436 width as pointers. The assumption is true for Emacs porting targets
437 now, but we want to make other targets possible.
438 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
439 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
440 In the rest of the code, change types of integers that hold casted
441 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
442 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
443 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
444 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
445 No need to cast type when ORing.
446 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
447 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
448 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
449 assume EMACS_INT is the same width as char *.
450 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
451 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
452 Remove no-longer-needed casts.
453 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
454 (xg_tool_bar_help_callback, xg_make_tool_item):
455 Use EMACS_INTPTR to hold an integer
456 that will be cast to void *; this can avoid a GCC warning
457 if EMACS_INT is not the same width as void *.
458 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
459 * xdisp.c (display_echo_area_1, resize_mini_window_1):
460 (current_message_1, set_message_1):
461 Use a local to convert to proper width without a cast.
462 * xmenu.c (dialog_selection_callback): Likewise.
464 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
465 Also, don't assume VALBITS / RAND_BITS is less than 5,
466 and don't rely on undefined behavior when shifting a 1 left into
468 * lisp.h (get_random): Change signature to match.
470 * lread.c (hash_string): Use size_t, not int, for hash computation.
471 Normally we prefer signed values; but hashing is special, because
472 it's better to use unsigned division on hash table sizes so that
473 the remainder is nonnegative. Also, size_t is the natural width
474 for hashing into memory. The previous code used 'int', which doesn't
475 retain enough info to hash well into very large tables.
476 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
478 * dbusbind.c: Don't possibly lose pointer info when converting.
479 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
480 Use XPNTR rather than XHASH, so that the high-order bits of
481 the pointer aren't lost when converting through void *.
483 * eval.c (Fautoload): Don't double-shift a pointer.
485 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
487 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
489 * gnutls.c (DEF_GNUTLS_FN):
490 * image.c (DEF_IMGLIB_FN): Make function pointers static.
492 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
494 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
497 2011-05-05 Eli Zaretskii <eliz@gnu.org>
499 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
500 New version that can reserve upto 2GB of heap space.
502 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
504 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
506 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
508 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
509 `gnutls_certificate_set_x509_key_file'.
511 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
513 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
516 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
518 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
519 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
520 Remove unused parameter `fildes'.
521 * process.c (read_process_output, send_process): Don't pass it.
523 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
525 Fix previous change: the library cache is defined in w32.c.
526 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
527 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
529 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
531 Implement dynamic loading of GnuTLS on Windows.
533 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
534 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
535 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
538 * gnutls.c (Qgnutls_dll): Define.
539 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
540 (gnutls_*): Declare function pointers.
541 (init_gnutls_functions): New function to initialize function pointers.
542 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
543 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
545 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
546 (emacs_gnutls_write, emacs_gnutls_read)
547 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
548 (Fgnutls_available_p): New function.
549 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
550 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
551 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
553 * image.c: Include w32.h.
554 (Vimage_type_cache): Delete.
555 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
556 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
557 (w32_delayed_load): Move to w32.c.
559 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
561 * w32.c (QCloaded_from, Vlibrary_cache): Define.
562 (w32_delayed_load): Move from image.c. When loading a library, record
563 its filename in the :loaded-from property of the library id.
564 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
565 Initialize and staticpro them.
566 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
568 * process.c: Include lisp.h before w32.h, not after.
569 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
570 instead of gnutls_record_check_pending.
572 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
574 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
576 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
577 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
580 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
582 * xterm.c (x_set_frame_alpha): Do not set property on anything
583 else than FRAME_X_OUTER_WINDOW (Bug#8608).
585 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
587 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
589 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
591 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
592 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
593 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
594 (gnutls_global_initialized, Qgnutls_bootprop_priority)
595 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
596 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
597 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
598 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
599 (Qgnutls_bootprop_callbacks_verify): Make static.
601 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
603 * callproc.c: Indentation fixup.
605 * sysdep.c (wait_for_termination_1): Make static.
606 (wait_for_termination, interruptible_wait_for_termination): Move
607 after wait_for_termination_1.
609 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
611 * sysdep.c (interruptible_wait_for_termination): New function
612 which is like wait_for_termination, but allows keyboard
615 * callproc.c (Fcall_process): Add (:file "file") as an option for
617 (Fcall_process_region): Ditto.
619 2011-04-30 Eli Zaretskii <eliz@gnu.org>
621 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
622 rather than `XVECTOR (FOO)->size'.
624 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
625 inttypes.h, as a gnulib replacement is used if it not available in
628 2011-04-21 Eli Zaretskii <eliz@gnu.org>
630 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
631 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
632 of MOST_POSITIVE_FIXNUM. (Bug#8528)
634 * coding.c (coding_alloc_by_realloc): Error out if destination
635 will grow beyond MOST_POSITIVE_FIXNUM.
636 (decode_coding_emacs_mule): Abort if there isn't enough place in
637 charbuf for the composition carryover bytes. Reserve an extra
638 space for up to 2 characters produced in a loop.
639 (decode_coding_iso_2022): Abort if there isn't enough place in
640 charbuf for the composition carryover bytes.
642 2011-04-21 Eli Zaretskii <eliz@gnu.org>
644 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
645 aborting when %lld or %lll format is passed.
646 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
647 %llo or %llx format is passed. (Bug#8545)
649 * window.c (window_scroll_line_based): Use a marker instead of
650 simple variables to record original value of point. (Bug#7952)
652 * doprnt.c (doprnt): Fix the case where a multibyte sequence
653 produced by %s or %c overflows available buffer space. (Bug#8545)
655 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
657 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
658 (SIZE_MAX): Move defn after all includes, as they might #define it.
660 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
662 * w32.c (init_environment): Warn about defaulting HOME to C:\.
664 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
666 * keyboard.c (Qdelayed_warnings_hook): Define.
667 (command_loop_1): Run `delayed-warnings-hook'
668 if Vdelayed_warnings_list is non-nil.
669 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
670 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
672 2011-04-28 Eli Zaretskii <eliz@gnu.org>
674 * doprnt.c (doprnt): Don't return value smaller than the buffer
675 size if the message was truncated. (Bug#8545).
677 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
679 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
680 (Fx_window_property): #if-0 the whole functions, not just the bodies.
682 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
684 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
686 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
688 * makefile.w32-in: Update dependencies.
690 2011-04-27 Eli Zaretskii <eliz@gnu.org>
692 Improve `doprnt' and its usage. (Bug#8545)
693 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
694 `format_end'. Remove support for %l as a conversion specifier.
695 Don't use xrealloc. Improve diagnostics when the %l size modifier
696 is used. Update the commentary.
698 * eval.c (verror): Simplify calculation of size_t.
700 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
703 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
705 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
708 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
710 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
711 This makes this file independent of the recent pseudovector change.
713 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
715 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
717 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
718 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
720 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
722 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
723 GCC 4.6.0 optimizes based on type-based alias analysis. For
724 example, if b is of type struct buffer * and v of type struct
725 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
726 != &v->size, and therefore "v->size = 1; b->size = 2; return
727 v->size;" must therefore return 1. This assumption is incorrect
728 for Emacs, since it type-puns struct Lisp_Vector * with many other
729 types. To fix this problem, this patch adds a new type struct
730 vectorlike_header that documents the constraints on layout of vectors
731 and pseudovectors, and helps optimizing compilers not get fooled
732 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
733 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
734 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
736 (XSETPVECTYPE): Rewrite in terms of new macro.
737 (XSETPVECTYPESIZE): New macro, specifying both type and size.
738 This is a bit clearer, and further avoids the possibility of
739 undesirable aliasing.
740 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
741 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
742 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
743 since Lisp_Subr is a special case (no "next" field).
744 (ASIZE): Now uses header.size rather than size. All
745 previous uses of XVECTOR (foo)->size replaced to use this macro,
746 to avoid the hassle of writing XVECTOR (foo)->header.size.
747 (struct vectorlike_header): New type.
748 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
749 object, to help avoid aliasing.
750 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
751 (SUBRP): Likewise, since Lisp_Subr is a special case.
752 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
753 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
754 (struct Lisp_Hash_Table): Combine first two members into a single
755 struct vectorlike_header member. All uses of "size" and "next" members
756 changed to be "header.size" and "header.next".
757 * buffer.h (struct buffer): Likewise.
758 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
759 * frame.h (struct frame): Likewise.
760 * process.h (struct Lisp_Process): Likewise.
761 * termhooks.h (struct terminal): Likewise.
762 * window.c (struct save_window_data, struct saved_window): Likewise.
763 * window.h (struct window): Likewise.
764 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
765 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
766 * buffer.c (init_buffer_once): Likewise.
767 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
769 * process.c (Fformat_network_address): Use local var for size,
772 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
774 Make the Lisp reader and string-to-float more consistent (Bug#8525)
775 * data.c (atof): Remove decl; no longer used or needed.
776 (digit_to_number): Move to lread.c.
777 (Fstring_to_number): Use new string_to_number function, to be
778 consistent with how the Lisp reader treats infinities and NaNs.
779 Do not assume that floating-point numbers represent EMACS_INT
780 without losing information; this is not true on most 64-bit hosts.
781 Avoid double-rounding errors, by insisting on integers when
782 parsing non-base-10 numbers, as the documentation specifies.
783 * lisp.h (string_to_number): New decl, replacing ...
784 (isfloat_string): Remove.
785 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
786 (read1): Do not accept +. and -. as integers; this
787 appears to have been a coding error. Similarly, do not accept
788 strings like +-1e0 as floating point numbers. Do not report
789 overflow for integer overflows unless the base is not 10 which
790 means we have no simple and reliable way to continue.
791 Break out the floating-point parsing into a new
792 function string_to_number, so that Fstring_to_number parses
793 floating point numbers consistently with the Lisp reader.
794 (digit_to_number): Moved here from data.c. Make it static inline.
795 (E_CHAR, EXP_INT): Remove, replacing with ...
796 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
797 (string_to_number): New function, replacing isfloat_string.
798 This function checks for valid syntax and produces the resulting
799 Lisp float number too. Rework it so that string-to-number
800 no longer mishandles examples like "1.0e+". Use strtoumax,
801 so that overflow for non-base-10 numbers is reported only when
802 there's no portable and simple way to convert to floating point.
804 * textprop.c (set_text_properties_1): Rewrite for clarity,
805 and to avoid GCC warning about integer overflow.
807 * intervals.h (struct interval): Use EMACS_INT for members
808 where EMACS_UINT might cause problems. See
809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
810 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
811 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
813 (offset_intervals): Tell GCC not to worry about length overflow
814 when negating a negative length.
816 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
817 (overrun_check_free): Likewise.
819 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
820 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
823 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
824 (gnutls_make_error): Rename local to avoid shadowing.
825 (gnutls_emacs_global_deinit): ifdef out; not used.
826 (Fgnutls_boot): Use const for pointer to readonly storage.
827 Comment out unused local. Fix pointer signedness problems.
829 * lread.c (openp): Don't stuff size_t into an 'int'.
830 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
831 about possible signed overflow.
833 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
834 (GDK_KEY_g): Don't define if already defined.
835 (xg_prepare_tooltip): Avoid pointer signedness problem.
836 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
838 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
839 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
841 * xfns.c (Fx_window_property): Simplify a bit,
842 to make a bit faster and to avoid GCC 4.6.0 warning.
843 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
845 * fns.c (internal_equal): Don't assume size_t fits in int.
847 * alloc.c (compact_small_strings): Tighten assertion a little.
849 Replace pEd with more-general pI, and fix some printf arg casts.
850 * lisp.h (pI): New macro, generalizing old pEd macro to other
851 conversion specifiers. For example, use "...%"pI"d..." rather
853 (pEd): Remove. All uses replaced with similar uses of pI.
854 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
855 * alloc.c (check_pure_size): Don't overflow by converting size to int.
856 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
857 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
858 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
859 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
860 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
862 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
863 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
864 * print.c (safe_debug_print, print_object): Likewise.
865 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
867 Use pI instead of if-then-else-abort. Use %p to avoid casts,
868 avoiding the 0 flag, which is not portable.
869 * process.c (Fmake_network_process): Use pI to avoid cast.
870 * region-cache.c (pp_cache): Likewise.
871 * xdisp.c (decode_mode_spec): Likewise.
872 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
873 behavior on 64-bit hosts with printf arg.
874 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
875 (x_stop_queuing_selection_requests): Likewise.
876 (x_get_window_property): Don't truncate byte count to an 'int'
879 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
880 here, since it parses constructs like leading '-' and spaces,
881 which are not wanted; and it overflows with large numbers.
882 Instead, simply match F[0-9]+, which is what is wanted anyway.
884 * alloc.c: Remove unportable assumptions about struct layout.
885 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
886 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
887 (allocate_vectorlike, make_pure_vector): Use the new macros,
888 plus offsetof, to remove unportable assumptions about struct layout.
889 These assumptions hold on all porting targets that I know of, but
890 they are not guaranteed, they're easy to remove, and removing them
891 makes further changes easier.
893 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
894 This doesn't fix a bug but makes the code clearer.
895 (string_overrun_cookie): Now const. Use initializers that
896 don't formally overflow signed char, to avoid warnings.
897 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
898 can cause Emacs to crash when string overrun checking is enabled.
899 (allocate_buffer): Don't assume sizeof (struct buffer) is a
900 multiple of sizeof (EMACS_INT); it need not be, if
901 alignof(EMACS_INT) < sizeof (EMACS_INT).
902 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
904 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
906 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
908 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
910 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
911 supposed to be handshaking. (Bug#8556)
912 Reported by Paul Eggert <eggert@cs.ucla.edu>.
914 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
916 * lisp.h (Qdebug): List symbol.
917 * eval.c (Qdebug): Restore global linkage.
918 * keyboard.c (debug-on-event): New variable.
919 (handle_user_signal): Break into debugger when debug-on-event
920 matches the current signal symbol.
922 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
924 * alloc.c (check_sblock, check_string_bytes)
925 (check_string_free_list): Convert to standard C.
927 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
929 * w32.c (emacs_gnutls_push): Fix typo.
931 2011-04-25 Eli Zaretskii <eliz@gnu.org>
933 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
934 "cast to pointer from integer of different size".
936 Improve doprnt and its use in verror. (Bug#8545)
937 * doprnt.c (doprnt): Document the set of format control sequences
938 supported by the function. Use SAFE_ALLOCA instead of always
941 * eval.c (verror): Don't limit the buffer size at size_max-1, that
942 is one byte too soon. Don't use xrealloc; instead xfree and
945 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
947 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
950 * gnutls.c: Renamed global_initialized to
951 gnutls_global_initialized. Added internals for the
952 :verify-hostname-error, :verify-error, and :verify-flags
953 parameters of `gnutls-boot' and documented those parameters in the
954 docstring. Start callback support.
955 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
956 unless a fatal error occured. Call gnutls_alert_send_appropriate
957 on error. Return error code.
958 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
959 (emacs_gnutls_read): Likewise.
960 (Fgnutls_boot): Return handshake error code.
961 (emacs_gnutls_handle_error): New function.
962 (wsaerror_to_errno): Likewise.
964 * w32.h (emacs_gnutls_pull): Add prototype.
965 (emacs_gnutls_push): Likewise.
967 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
968 (emacs_gnutls_push): Likewise.
970 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
972 * process.c (wait_reading_process_output): Check if GnuTLS
973 buffered some data internally if no FDs are set for TLS
976 * makefile.w32-in (OBJ2): Add gnutls.$(O).
977 (LIBS): Link to USER_LIBS.
978 ($(BLD)/gnutls.$(0)): New target.
980 2011-04-24 Eli Zaretskii <eliz@gnu.org>
982 * xdisp.c (handle_single_display_spec): Rename the
983 display_replaced_before_p argument into display_replaced_p, to
984 make it consistent with the commentary. Fix typos in the
987 * textprop.c (syms_of_textprop): Remove dead code.
988 (copy_text_properties): Delete obsolete commentary about an
989 interface that was deleted long ago. Fix typos in the description
992 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
993 to changes in oldXMenu/XMenu.h from 2011-04-16.
994 <menu_help_message, prev_menu_help_message>: Constify.
995 (IT_menu_make_room): menu->help_text is now `const char **';
998 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
999 to changes in oldXMenu/XMenu.h from 2011-04-16.
1000 (struct XMenu): Declare `help_text' `const char **'.
1002 * xfaces.c <Qunspecified>: Make extern again.
1004 * syntax.c: Include sys/types.h before including regex.h, as
1007 * doc.c (get_doc_string): Improve the format passed to `error'.
1009 * doprnt.c (doprnt): Improve commentary.
1011 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1013 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1016 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1017 changes in globals.h immediately force recompilation.
1018 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1019 $(CURDIR)/s/ms-w32.h.
1020 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1022 * character.c (Fchar_direction): Function deleted.
1023 (syms_of_character): Don't defsubr it.
1024 <char-direction-table>: Deleted.
1026 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1028 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1029 * doprnt.c: Include limits.h.
1030 (SIZE_MAX): New macro.
1031 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1032 local variables are now size_t instead of int or unsigned.
1033 Improve overflow protection. Support `l' modifier for integer
1034 conversions. Support %l conversion. Don't assume an EMACS_INT
1035 argument for integer conversions and for %c.
1037 * lisp.h (doprnt): Restore prototype.
1039 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1042 * Makefile.in (base_obj): Add back doprnt.o.
1044 * deps.mk (doprnt.o): Add back prerequisites.
1045 (callint.o): Depend on character.h.
1047 * eval.c (internal_lisp_condition_case): Include the handler
1048 representation in the error message.
1049 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1050 when breaking from the loop.
1052 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1054 * callint.c (Fcall_interactively): When displaying error message
1055 about invalid control letter, pass the character's codepoint, not
1056 a pointer to its multibyte form. Improve display of the character
1057 in octal and display also its hex code.
1059 * character.c (char_string): Use %x to display the (unsigned)
1060 codepoint of an invalid character, to avoid displaying a bogus
1063 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1064 `error', not SYMBOL_NAME itself.
1066 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1067 character arguments to `error'.
1069 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1070 to `error' in error message about FINAL_CHAR argument. Make sure
1071 FINAL_CHAR is a character, and use %c when it is passed as
1072 argument to `error'.
1074 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1076 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1078 * w32.c: Include <time.h>.
1079 (sys_localtime): New function.
1081 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1083 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1085 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1087 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1089 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1092 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1094 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1095 gl_state.e_property when gl_state.object is Qt.
1097 * insdel.c (make_gap_larger): Remove limitation of buffer size
1100 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1102 * xdisp.c (lookup_glyphless_char_display)
1103 (produce_glyphless_glyph): Handle cons cell entry in
1104 glyphless-char-display.
1105 (Vglyphless_char_display): Document it.
1107 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1108 glyphless-char-display.
1110 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1112 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1114 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1116 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1117 definition for no-X builds.
1119 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1121 Static checks with GCC 4.6.0 and non-default toolkits.
1123 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1125 * process.c (keyboard_bit_set): Define only if SIGIO.
1126 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1127 (send_process): Repair possible setjmp clobbering.
1129 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1131 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1133 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1135 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1136 Define only if needed.
1138 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1139 by pacifying GCC about it. Maybe it's time to retire it?
1140 * xfaces.c (USG, __TIMEVAL__): Likewise.
1142 * dispextern.h (struct redisplay_interface): Rename param
1144 * termhooks.h (struct terminal): Likewise.
1145 * xterm.c (xembed_send_message): Likewise.
1147 * insdel.c (make_gap_smaller): Define only if
1148 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1150 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1153 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1154 so that we aren't warned about unused symbols.
1156 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1158 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1160 * xfns.c (x_real_positions): Mark locals as initialized.
1162 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1164 * xterm.c: Fix problems found by static analysis with other toolkits.
1165 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1166 (x_dispatch_event): Declare static if USE_GTK, and
1167 define if USE_GTK || USE_X_TOOLKIT.
1168 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1169 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1170 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1171 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1173 * xmenu.c (menu_help_callback): Pointer type fixes.
1174 Use const pointers when pointing at readonly data. Avoid pointer
1176 (FALSE): Remove unused macro.
1177 (update_frame_menubar): Remove unused decl.
1179 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1181 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1182 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1183 (single_menu_item): Rename local to avoid shadowing.
1185 * keyboard.c (make_lispy_event): Remove unused local var.
1187 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1188 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1190 * bitmaps: Change bitmaps from unsigned char back to the X11
1191 compatible char. Avoid the old compiler warnings about
1192 out-of-range initializers by using, for example, '\xab' rather
1195 * xgselect.c (xgselect_initialize): Check vs interface
1196 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1198 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1200 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1201 to read-only memory.
1203 * fns.c (vector): Remove; this old hack is no longer needed.
1205 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1207 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1209 * xrdb.c (x_load_resources): Omit unused local.
1211 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1212 (x_window): Rename locals to avoid shadowing.
1213 (USG): Use the kludged USG macro, to pacify gcc.
1215 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1216 (x_term_init): Remove local to avoid shadowing.
1218 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1220 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1221 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1223 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1225 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1227 Fix regex.c, syntax.c and friends for buffers > 2GB.
1228 * syntax.h (struct gl_state_s): Declare character position members
1231 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1233 * textprop.c (verify_interval_modification, interval_of): Declare
1234 arguments EMACS_INT.
1236 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1239 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1241 * indent.c (Fvertical_motion): Local variable it_start is now
1244 * regex.c (re_match, re_match_2, re_match_2_internal)
1245 (bcmp_translate, regcomp, regexec, print_double_string)
1246 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1247 (re_compile_pattern, re_exec): Declare arguments and local
1248 variables `size_t' and `ssize_t' and return values `regoff_t', as
1250 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1251 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1252 <compile_stack_type>: `size' and `avail' are now `size_t'.
1254 * regex.h <regoff_t>: Use ssize_t, not int.
1255 (re_search, re_search_2, re_match, re_match_2): Arguments that
1256 specify buffer/string position and length are now ssize_t and
1257 size_t. Return type is regoff_t.
1259 2011-04-16 Ben Key <bkey76@gmail.com>
1261 * nsfont.m: Fixed bugs in ns_get_family and
1262 ns_descriptor_to_entity that were caused by using free to
1263 deallocate memory blocks that were allocated by xmalloc (via
1264 xstrdup). This caused Emacs to crash when compiled with
1265 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1266 --enable-checking=xmallocoverrun). xfree is now used to
1267 deallocate these memory blocks.
1269 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1271 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1273 emacs_write: Accept and return EMACS_INT for sizes.
1274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1276 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1277 Accept and return EMACS_INT.
1278 (emacs_gnutls_write): Return the number of bytes written on
1280 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1281 (emacs_read, emacs_write): Remove check for negative size, as the
1282 Emacs source code has been audited now.
1283 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1284 (emacs_read, emacs_write): Use it.
1285 * process.c (send_process): Adjust to the new signatures of
1286 emacs_write and emacs_gnutls_write. Do not attempt to store
1287 a byte offset into an 'int'; it might overflow.
1288 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1290 * sound.c: Don't assume sizes fit in 'int'.
1291 (struct sound_device.period_size, alsa_period_size):
1292 Return EMACS_INT, not int.
1293 (struct sound_device.write, vox_write, alsa_write):
1294 Accept EMACS_INT, not int.
1295 (wav_play, au_play): Use EMACS_INT to store sizes and to
1296 record read return values.
1298 2011-04-15 Ben Key <bkey76@gmail.com>
1300 * keyboard.c (Qundefined): Don't declare static since it is used
1302 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1303 static since they are used in nsfont.m.
1305 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1307 * process.c (Qprocessp): Don't declare static.
1308 * lisp.h (Qprocessp): Declare again.
1310 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1312 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1314 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1316 Improve C-level modularity by making more things 'static'.
1318 Don't publish debugger-only interfaces to other modules.
1319 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1320 (verify_bytepos, count_markers): Move decls to the only modules
1322 * region-cache.h (pp_cache): Likewise.
1323 * window.h (check_all_windows): Likewise.
1324 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1326 * sysdep.c (croak): Now static, if
1327 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1328 * syssignal.h (croak): Declare only if not static.
1330 * alloc.c (refill_memory_reserve): Now static if
1331 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1332 * lisp.h (refill_memory_reserve): Declare only if not static.
1334 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1335 Define only if USE_LUCID.
1337 * xrdb.c (x_customization_string, x_rm_string): Now static.
1339 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1340 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1342 * xdisp.c (draw_row_with_mouse_face): Now static.
1343 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1345 * window.h (check_all_windows): Mark externally visible.
1347 * window.c (window_deletion_count): Now static.
1349 * undo.c: Make symbols static if they're not exported.
1350 (last_undo_buffer, last_boundary_position, pending_boundary):
1353 * textprop.c (interval_insert_behind_hooks): Now static.
1354 (interval_insert_in_front_hooks): Likewise.
1356 * term.c: Make symbols static if they're not exported.
1357 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1358 (max_frame_lines, tty_set_terminal_modes):
1359 (tty_reset_terminal_modes, tty_turn_off_highlight):
1360 (get_tty_terminal): Now static.
1361 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1362 * termhooks.h (term_mouse_moveto): Do not declare if
1364 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1365 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1367 * sysdep.c: Make symbols static if they're not exported.
1368 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1370 (sigprocmask_set, full_mask): Remove; unused.
1371 (wait_debugging): Mark as visible.
1372 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1373 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1375 * syntax.c (syntax_temp): Define only if !__GNUC__.
1377 * sound.c (current_sound_device, current_sound): Now static.
1379 * search.c (searchbufs, searchbuf_head): Now static.
1381 * scroll.c (scroll_cost): Remove; unused.
1382 * dispextern.h (scroll_cost): Remove decl.
1384 * region-cache.h (pp_cache): Mark as externally visible.
1386 * process.c: Make symbols static if they're not exported.
1387 (process_tick, update_tick, create_process, chan_process):
1388 (Vprocess_alist, proc_buffered_char, datagram_access):
1389 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1390 (deactivate_process): Mark defn as static, as well as decl.
1391 * lisp.h (create_process): Remove decl.
1392 * process.h (chan_process, Vprocess_alist): Remove decls.
1394 * print.c: Make symbols static if they're not exported.
1395 (print_depth, new_backquote_output, being_printed, print_buffer):
1396 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1397 (print_interval, print_number_index, initial_stderr_stream):
1399 * lisp.h (Fprinc): Remove decl.
1400 (debug_output_compilation_hack): Mark as externally visible.
1402 * sysdep.c (croak): Move decl from here to syssignal.h.
1403 * syssignal.h (croak): Put it here, so the API can be checked when
1404 'croak' is called from dissociate_if_controlling_tty.
1406 * minibuf.c: Make symbols static if they're not exported.
1407 (minibuf_save_list, choose_minibuf_frame): Now static.
1408 * lisp.h (choose_minibuf_frame): Remove decl.
1410 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1412 * lread.c: Make symbols static if they're not exported.
1413 (read_objects, initial_obarray, oblookup_last_bucket_number):
1415 (make_symbol): Remove; unused.
1416 * lisp.h (initial_obarray, make_symbol): Remove decls.
1418 * keyboard.c: Make symbols static if they're not exported.
1419 (single_kboard, recent_keys_index, total_keys, recent_keys):
1420 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1421 (this_single_command_key_start, echoing, last_auto_save):
1422 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1423 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1424 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1425 (Vlispy_mouse_stem, double_click_count):
1427 (force_auto_save_soon): Define only if SIGDANGER.
1428 (ignore_mouse_drag_p): Now static if
1429 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1430 (print_help): Remove; unused.
1431 (stop_character, last_timer_event): Mark as externally visible.
1432 * keyboard.h (ignore_mouse_drag_p): Declare only if
1433 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1434 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1435 * lisp.h (echoing): Remove decl.
1436 (force_auto_save_soon): Declare only if SIGDANGER.
1437 * xdisp.c (redisplay_window): Simplify code, to make it more
1438 obvious that ignore_mouse_drag_p is not accessed if !defined
1439 USE_GTK && !defined HAVE_NS.
1441 * intervals.c: Make symbols static if they're not exported.
1442 (merge_properties_sticky, merge_interval_right, delete_interval):
1444 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1446 * insdel.c: Make symbols static if they're not exported.
1447 However, leave prepare_to_modify_buffer alone. It's never
1448 called from outside this function, but that appears to be a bug.
1449 (combine_after_change_list, combine_after_change_buffer):
1450 (adjust_after_replace, signal_before_change): Now static.
1451 (adjust_after_replace_noundo): Remove; unused.
1452 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1453 (signal_before_change): Remove decls.
1455 * indent.c (val_compute_motion, val_vmotion): Now static.
1457 * image.c: Make symbols static if they're not exported.
1458 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1460 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1461 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1463 * fringe.c (standard_bitmaps): Now static.
1464 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1466 * frame.c: Make symbols static if they're not exported.
1467 (x_report_frame_params, make_terminal_frame): Now static.
1468 (get_frame_param): Now static, unless HAVE_NS.
1469 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1470 (x_get_resource_string): Remove; not used.
1471 * frame.h (make_terminal_frame, x_report_frame_params):
1472 (x_get_resource_string); Remove decls.
1473 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1474 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1476 * font.c, fontset.c: Make symbols static if they're not exported.
1477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1478 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1479 * font.c (font_close_object): Now static.
1480 * font.h (font_close_object): Remove.
1481 * fontset.c (FONTSET_OBJLIST): Remove.
1482 (free_realized_fontset) #if-0 the body, which does nothing.
1483 (face_suitable_for_char_p): #if-0, as it's never called.
1484 * fontset.h (face_suitable_for_char_p): Remove decl.
1485 * xfaces.c (face_at_string_position): Use
1486 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1487 since 0 is always ASCII.
1489 * fns.c (weak_hash_tables): Now static.
1491 * fileio.c: Make symbols static if they're not exported.
1492 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1493 (Vwrite_region_annotation_buffers): Now static.
1495 * eval.c: Make symbols static if they're not exported.
1496 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1497 * lisp.h (backtrace_list): Remove decl.
1499 * emacs.c: Make symbols static if they're not exported.
1500 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1501 (fatal_error_code, fatal_error_signal_hook, standard_args):
1503 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1504 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1505 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1506 * lisp.h (fatal_error_signal_hook): Remove decl.
1507 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1509 * editfns.c: Move a (normally-unused) function to its only use.
1510 * editfns.c, lisp.h (get_operating_system_release): Remove.
1511 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1512 worth the hassle of breaking this out.
1514 * xterm.c: Make symbols static if they're not exported.
1515 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1516 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1517 (x_destroy_window, x_delete_display):
1519 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1520 (x_mouse_leave): Remove; unused.
1521 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1522 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1523 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1525 (x_mouse_leave): Declare only if WINDOWSNT.
1526 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1527 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1530 * ftxfont.c: Make symbols static if they're not exported.
1531 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1533 * font.h (ftxfont_driver): Likewise.
1535 * xfns.c: Make symbols static if they're not exported.
1536 (x_last_font_name, x_display_info_for_name):
1537 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1538 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1539 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1540 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1541 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1542 (last_show_tip_args): Now static.
1543 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1544 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1545 (x_screen_planes): Remove; unused.
1546 * dispextern.h (x_screen_planes): Remove decl.
1548 * dispnew.c: Make symbols static if they're not exported.
1549 * dispextern.h (redraw_garbaged_frames, scrolling):
1550 (increment_row_positions): Remove.
1551 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1552 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1554 (redraw_garbaged_frames): Remove; unused.
1556 * xfaces.c: Make symbols static if they're not exported.
1557 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1559 * xterm.h (defined_color): Remove decls.
1560 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1561 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1562 (menu_face_changed_default, defined_color, free_realized_face):
1563 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1564 (ascii_face_of_lisp_face): Remove; unused.
1566 * xdisp.c: Make symbols static if they're not exported.
1567 * dispextern.h (scratch_glyph_row, window_box_edges):
1568 (glyph_to_pixel_coords, set_cursor_from_row):
1569 (get_next_display_element, set_iterator_to_next):
1570 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1571 (show_mouse_face): Remove decls
1572 * frame.h (message_buf_print): Likewise.
1573 * lisp.h (pop_message, set_message, check_point_in_composition):
1575 * xterm.h (set_vertical_scroll_bar): Likewise.
1576 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1577 (message_buf_print, scratch_glyph_row, displayed_buffer):
1578 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1579 (get_next_display_element, show_mouse_face, window_box_edges):
1580 (frame_to_window_pixel_xy, check_point_in_composition):
1581 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1582 (glyph_to_pixel_coords): Remove; unused.
1584 * dired.c (file_name_completion): Now static.
1586 * dbusbind.c (xd_in_read_queued_messages): Now static.
1588 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1589 * data.c (circular_list_error): Remove.
1591 * commands.h (last_point_position, last_point_position_buffer):
1592 (last_point_position_window): Remove decls.
1593 * keyboard.c: Make these variables static.
1595 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1597 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1598 (iso_code_class, detect_coding, code_convert_region): Now static.
1599 (encode_coding_gap): Remove; unused.
1601 * chartab.c (chartab_chars, chartab_bits): Now static.
1603 * charset.h (charset_iso_8859_1): Remove decl.
1604 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1607 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1608 * ccl.c (Vccl_program_table): Now static.
1609 (check_ccl_update): Remove; unused.
1611 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1612 * category.h: ... from here.
1613 * category.c (check_category_table, set_category_set): Now static.
1615 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1616 * lisp.h: Remove these decls.
1618 * buffer.c (buffer_count): Remove unused var.
1620 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1621 so that it's not optimized away.
1622 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1623 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1624 exported only to the debugger.
1626 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1627 * atimer.h (run_all_atimers): Removed; not exported.
1629 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1630 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1631 was inaccessible from Lisp.
1632 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1633 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1635 alloc.c: Import and export fewer symbols, and remove unused items.
1636 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1638 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1639 it's not optimized away by whole-program optimization.
1640 (message_enable_multibyte, free_misc): Remove.
1641 (catchlist, handlerlist, mark_backtrace):
1642 Declare only if BYTE_MARK_STACK.
1643 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1644 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1645 (message_enable_multibyte): Remove decl.
1646 (free_misc, interval_free_list, float_block, float_block_index):
1647 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1648 (cons_free_list, last_marked_index):
1650 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1651 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1652 (mark_backtrace): Define only if BYTE_MARK_STACK.
1653 * xdisp.c (message_enable_multibyte): Now static.
1655 Declare Lisp_Object Q* variables to be 'static' if not exported.
1656 This makes it easier for human readers (and static analyzers)
1657 to see whether these variables are used from other modules.
1658 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1659 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1660 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1661 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1662 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1663 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1664 * xmenu.c, xselect.c:
1665 Declare Q* vars static if they are not used in other modules.
1666 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1667 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1668 Remove decls of unexported vars.
1669 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1671 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1673 Make Emacs functions such as Fatom 'static' by default.
1674 This makes it easier for human readers (and static analyzers)
1675 to see whether these functions can be called from other modules.
1676 DEFUN now defines a static function. To make the function external
1677 so that it can be used in other C modules, use the new macro DEFUE.
1678 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1679 (Finit_image_library):
1680 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1681 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1682 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1683 Remove decls, since these functions are now static.
1684 (Funintern, Fget_internal_run_time): New decls, since these functions
1685 were already external.
1687 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1688 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1689 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1690 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1691 * keyboard.c, keymap.c, lread.c:
1692 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1693 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1694 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1695 Mark functions with DEFUE instead of DEFUN,
1696 if they are used in other modules.
1697 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1698 decls for now-static functions.
1699 * buffer.h (Fdelete_overlay): Remove decl.
1700 * callproc.c (Fgetenv_internal): Mark as internal.
1701 * composite.c (Fremove_list_of_text_properties): Remove decl.
1702 (Fcomposition_get_gstring): New forward static decl.
1703 * composite.h (Fcomposite_get_gstring): Remove decl.
1704 * dired.c (Ffile_attributes): New forward static decl.
1705 * doc.c (Fdocumntation_property): New forward static decl.
1706 * eval.c (Ffetch_bytecode): New forward static decl.
1707 (Funintern): Remove extern decl; now in .h file where it belongs.
1708 * fileio.c (Fmake_symbolic_link): New forward static decl.
1709 * image.c (Finit_image_library): New forward static decl.
1710 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1711 * intervals.h (Fprevious_property_change):
1712 (Fremove_list_of_text_properties): Remove decls.
1713 * keyboard.c (Fthis_command_keys): Remove decl.
1714 (Fcommand_execute): New forward static decl.
1715 * keymap.c (Flookup_key): New forward static decl.
1716 (Fcopy_keymap): Now static.
1717 * keymap.h (Flookup_key): Remove decl.
1718 * process.c (Fget_process): New forward static decl.
1719 (Fprocess_datagram_address): Mark as internal.
1720 * syntax.c (Fsyntax_table_p): New forward static decl.
1721 (skip_chars): Remove duplicate decl.
1722 * textprop.c (Fprevious_property_change): New forward static decl.
1723 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1725 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1726 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1728 * editfns.c (Fformat): Remove unreachable code.
1730 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1732 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1735 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1737 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1738 when at ZV. (Bug#8487)
1740 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1742 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1744 * keyboard.c (parse_tool_bar_item): Likewise.
1745 * sound.c (sound_cleanup, alsa_close): Likewise.
1746 * termcap.c (tgetent): Likewise.
1747 * xfns.c (x_default_font_parameter): Likewise.
1748 * xsettings.c (read_and_apply_settings): Likewise.
1750 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1751 (overrun_check_free): Protoize.
1753 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1755 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1756 since callers should never pass a negative size.
1757 Change the signature to match that of plain 'read' and 'write'; see
1758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1759 * lisp.h: Update prototypes of emacs_write and emacs_read.
1761 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1763 * xdisp.c (redisplay_window): Don't try to determine the character
1764 position of the scroll margin if the window start point w->startp
1765 is outside the buffer's accessible region. (Bug#8468)
1767 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1769 Fix write-region and its subroutines for buffers > 2GB.
1770 * fileio.c (a_write, e_write): Modify declaration of arguments and
1771 local variables to support buffers larger than 2GB.
1772 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1774 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1775 argument, local variables, and return value.
1777 * lisp.h: Update prototypes of emacs_write and emacs_read.
1779 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1781 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1783 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1785 Fix more problems found by GCC 4.6.0's static checks.
1787 * xdisp.c (vmessage): Use a better test for character truncation.
1789 * charset.c (load_charset_map): <, not <=, for optimization,
1790 and to avoid potential problems with integer overflow.
1791 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1792 * casetab.c (set_identity, shuffle): Likewise.
1793 * editfns.c (Fformat): Likewise.
1794 * syntax.c (skip_chars): Likewise.
1796 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1797 This also lets GCC 4.6.0 generate slightly better loop code.
1799 * callint.c (Fcall_interactively): <, not <=, for optimization.
1800 (Fcall_interactively): Count the number of arguments produced,
1801 not the number of arguments given. This is simpler and lets GCC
1802 4.6.0 generate slightly better code.
1804 * ftfont.c: Distingish more carefully between FcChar8 and char.
1805 The previous code passed unsigned char * to a functions like
1806 strlen and xstrcasecmp that expect char *, which does not
1807 conform to the C standard.
1808 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1809 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1810 char * when the C standard requires it.
1812 * keyboard.c (read_char): Remove unused var.
1814 * eval.c: Port to Windows vsnprintf (Bug#8435).
1816 (SIZE_MAX): Define if the headers do not.
1817 (verror): Do not give up if vsnprintf returns a negative count.
1818 Instead, grow the buffer. This ports to Windows vsnprintf, which
1819 does not conform to C99. Problem reported by Eli Zaretskii.
1820 Also, simplify the allocation scheme, by avoiding the need for
1821 calling realloc, and removing the ALLOCATED variable.
1823 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1825 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1826 But keep the doprint source code for now, as we might revamp it
1827 and use it again (Bug#8435).
1828 * lisp.h (doprnt): Remove.
1829 * Makefile.in (base_obj): Remove doprnt.o.
1830 * deps.mk (doprnt.o): Remove.
1832 error: Print 32- and 64-bit integers portably (Bug#8435).
1833 Without this change, on typical 64-bit hosts error ("...%d...", N)
1834 was used to print both 32- and 64-bit integers N, which relied on
1836 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1838 * lisp.h (error, verror): Mark as printf-like functions.
1839 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1840 Report overflow in size calculations when allocating printf buffer.
1841 Do not truncate output string at its first null byte.
1842 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1843 Truncate the output at a character boundary, since vsnprintf does not
1845 * charset.c (check_iso_charset_parameter): Convert internal
1846 character to string before calling 'error', since %c now has the
1848 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1849 overflow when computing char to be passed to 'error'. Do not
1850 pass Lisp_Object to 'error'; pass the integer instead.
1851 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1852 formatted with plain %d.
1854 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1856 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1858 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1860 * xterm.c (x_catch_errors): Remove duplicate declaration.
1862 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1864 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1866 2011-04-10 Jim Meyering <meyering@redhat.com>
1868 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1869 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1870 return ssize_t not "int", and use size_t as the buffer length.
1871 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1872 * gnutls.h: Update declarations.
1873 * process.c (read_process_output): Use ssize_t, to match.
1874 (send_process): Likewise.
1876 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1878 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1880 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1882 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1883 unsigned char, to match FcChar8 type definition.
1885 * xterm.c (handle_one_xevent):
1886 * xmenu.c (create_and_show_popup_menu):
1887 * xselect.c (x_decline_selection_request)
1888 (x_reply_selection_request): Avoid type-punned deref of X events.
1890 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1892 Fix some uses of `int' instead of EMACS_INT.
1893 * search.c (string_match_1, fast_string_match)
1894 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1895 (scan_buffer, find_next_newline_no_quit)
1896 (find_before_next_newline, search_command, Freplace_match)
1897 (Fmatch_data): Make some `int' variables be EMACS_INT.
1899 * xdisp.c (display_count_lines): 3rd argument and return value now
1900 EMACS_INT. All callers changed.
1901 (pint2hrstr): Last argument is now EMACS_INT.
1903 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1904 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1905 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1906 (decode_coding_utf_16, decode_coding_emacs_mule)
1907 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1908 (decode_coding_ccl, decode_coding_charset)
1909 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1910 (decode_coding_iso_2022, decode_coding_emacs_mule)
1911 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1912 <char_offset, last_offset>: Declare EMACS_INT.
1913 (encode_coding_utf_8, encode_coding_utf_16)
1914 (encode_coding_emacs_mule, encode_invocation_designation)
1915 (encode_designation_at_bol, encode_coding_iso_2022)
1916 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1917 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1919 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1920 (encode_invocation_designation): Last argument P_NCHARS is now
1922 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1923 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1925 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1928 * ccl.c (Fccl_execute_on_string): Declare some variables
1931 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1933 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1935 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1937 * process.c (Fformat_network_address): Doc fix.
1939 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1941 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1943 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1945 * keyboard.c (read_char): Call Lisp function help-form-show,
1946 instead of using internal_with_output_to_temp_buffer.
1947 (Qhelp_form_show): New var.
1948 (syms_of_keyboard): Use DEFSYM macro.
1950 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1952 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1954 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1956 * process.c (Flist_processes): Removed to Lisp.
1957 (list_processes_1): Deleted.
1959 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1961 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1963 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1965 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1967 Fix more problems found by GCC 4.6.0's static checks.
1969 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1971 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1973 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1975 * xdisp.c (vmessage): Mark as a printf-like function.
1977 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1979 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1981 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1982 printf-like functions.
1983 (tiff_load): Add casts to remove these marks before passing them
1984 to system-supplied API.
1986 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1988 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1989 This avoids several warnings with gcc -Wstrict-overflow.
1990 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1991 directly, rather than having caller test rule sign. This avoids
1992 some unnecessary tests.
1993 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1994 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1995 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1997 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1998 (xfont_open): Avoid unnecessary tests.
2000 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2002 * composite.h, composite.c (composition_gstring_put_cache):
2003 Use EMACS_INT, not int, for length.
2005 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2006 breaking out part of COMPOSITION_DECODE_RULE.
2007 (COMPOSITION_DECODE_RULE): Use it.
2008 * composite.c (get_composition_id): Remove unused local vars,
2009 by using the new macro.
2011 * textprop.c (set_text_properties_1): Change while to do-while,
2012 since the condition is always true at first.
2014 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2015 (interval_deletion_adjustment): Return unsigned value.
2018 * process.c (list_processes_1, create_pty, read_process_output):
2019 (exec_sentinel): Remove vars that were set but not used.
2020 (create_pty): Remove unnecessary "volatile"s.
2021 (Fnetwork_interface_info): Avoid possibility of int overflow.
2022 (read_process_output): Do adaptive read buffering even if carryover.
2023 (read_process_output): Simplify nbytes computation if buffered.
2025 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2027 * syntax.c (scan_words): Remove var that was set but not used.
2028 (update_syntax_table): Use unsigned instead of int.
2030 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2031 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2032 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2034 * print.c (print_error_message): Avoid int overflow.
2036 * font.c (font_list_entities): Redo for clarity,
2037 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2039 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2040 (font_score): Avoid potential overflow in diff calculation.
2042 * fns.c (substring_both): Remove var that is set but not used.
2043 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2045 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2047 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2048 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2049 can always succeed if overflow has undefined behavior.
2051 * search.c (boyer_moore, wordify): Remove vars set but not used.
2052 (wordify): Omit three unnecessary tests.
2054 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2055 All callers changed. This avoids the need for an unused var.
2057 * casefiddle.c (casify_region): Remove var that is set but not used.
2059 * dired.c (file_name_completion): Remove var that is set but not used.
2061 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2063 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2064 (Finsert_file_contents): Remove unnecessary code checking fd.
2066 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2067 Check for integer overflow on size calculations.
2069 * buffer.c (Fprevious_overlay_change): Remove var that is set
2072 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2073 Remove vars that are set but not used.
2074 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2075 (timer_check_2): Mark vars as initialized.
2077 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2079 * image.c (lookup_image): Remove var that is set but not used.
2080 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2082 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2083 that are set but not used.
2085 * xfns.c (make_invisible_cursor): Don't return garbage
2086 if XCreateBitmapFromData fails (Bug#8410).
2088 * xselect.c (x_get_local_selection, x_handle_property_notify):
2089 Remove vars that are set but not used.
2091 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2092 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2094 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2095 Remove var that is set but not used.
2096 (scroll_bar_windows_size): Now size_t, not int.
2097 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2100 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2101 (map_tty_color) [!defined MSDOS]: Likewise.
2103 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2105 * coding.c: Remove vars that are set but not used.
2106 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2107 All callers changed.
2108 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2109 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2110 (decode_coding_charset): Remove vars that are set but not used.
2112 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2113 that is set but not used.
2115 * print.c (print_object): Remove var that is set but not used.
2117 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2118 The gnulib version avoids calling malloc in the usual case,
2119 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2120 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2121 * filelock.c (current_lock_owner): Likewise.
2122 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2123 * sysdep.c: Include allocator.h, careadlinkat.h.
2124 (emacs_no_realloc_allocator): New static constant.
2125 (emacs_readlink): New function.
2126 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2127 ../lib/careadlinkat.h.
2129 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2131 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2132 first non-nil return value).
2134 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2136 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2137 if not defined (Bug#8403).
2139 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2141 * xdisp.c (display_count_lines): Remove parameter `start',
2142 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2143 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2144 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2145 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2146 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2147 and thereabouts. All callers changed.
2148 (get_per_char_metric): Remove parameter `f', unused since
2149 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2151 2011-04-02 Jim Meyering <meyering@redhat.com>
2153 do not dereference NULL upon failed strdup
2154 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2155 (ns_get_family): Likewise.
2157 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2159 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2161 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2163 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2166 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2168 Add lexical binding.
2170 * window.c (Ftemp_output_buffer_show): New fun.
2171 (Fsave_window_excursion):
2172 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2174 * lread.c (lisp_file_lexically_bound_p): New function.
2175 (Fload): Bind Qlexical_binding.
2176 (readevalloop): Remove `evalfun' arg.
2177 Bind Qinternal_interpreter_environment.
2178 (Feval_buffer): Bind Qlexical_binding.
2179 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2181 (syms_of_lread): Declare `lexical-binding'.
2183 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2185 * keyboard.c (eval_dyn): New fun.
2186 (menu_item_eval_property): Use it.
2188 * image.c (parse_image_spec): Use Ffunctionp.
2190 * fns.c (concat, mapcar1): Accept byte-code-functions.
2192 * eval.c (Fsetq): Handle lexical vars.
2193 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2194 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2195 (FletX, Flet): Obey lexical binding.
2196 (Fcommandp): Handle closures.
2197 (Feval): New `lexical' arg.
2198 (eval_sub): New function extracted from Feval. Use it almost
2199 everywhere where Feval was used. Look up vars in lexical env.
2201 (Ffunctionp): Move from subr.el.
2202 (Ffuncall): Handle closures.
2203 (apply_lambda): Remove `eval_flags'.
2204 (funcall_lambda): Handle closures and new byte-code-functions.
2205 (Fspecial_variable_p): New function.
2206 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2207 but without exporting it to Lisp.
2209 * doc.c (Fdocumentation, store_function_docstring):
2210 * data.c (Finteractive_form): Handle closures.
2212 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2215 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2217 (exec_byte_code): New function extracted from Fbyte_code to handle new
2218 calling convention for byte-code-functions. Add new byte-codes.
2220 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2222 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2224 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2226 * xdisp.c (redisplay_internal): Fix prototype.
2228 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2230 * xdisp.c (SCROLL_LIMIT): New macro.
2231 (try_scrolling): Use it when setting scroll_limit. Limit
2232 scrolling to 100 screen lines.
2233 (redisplay_window): Even when falling back on "recentering",
2234 position point in the window according to scroll-conservatively,
2235 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2237 (try_scrolling): When point is above the window, allow searching
2238 as far as scroll_max, or one screenful, to compute vertical
2239 distance from PT to the scroll margin position. This prevents
2240 try_scrolling from unnecessarily failing when
2241 scroll-conservatively is set to a value slightly larger than the
2242 window height. Clean up the case of PT below the margin at bottom
2243 of window: scroll_max can no longer be INT_MAX. When aggressive
2244 scrolling is in use, don't let point enter the opposite scroll
2245 margin as result of the scroll.
2246 (syms_of_xdisp) <scroll-conservatively>: Document the
2247 threshold of 100 lines for never-recentering scrolling.
2249 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2251 * dispextern.h (move_it_by_lines):
2252 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2253 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2254 (message_log_check_duplicate): Remove parameters `prev_bol' and
2255 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2256 (redisplay_internal): Remove parameter `preserve_echo_area',
2257 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2259 * indent.c (Fvertical_motion):
2260 * window.c (window_scroll_pixel_based, Frecenter):
2261 Don't pass `need_y_p' to `move_it_by_lines'.
2263 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2265 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2266 steal a few bits to be more compact.
2267 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2268 Remove unneeded casts.
2270 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2272 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2274 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2275 binding" message (bug#7967).
2277 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2279 Fix more problems found by GCC 4.6.0's static checks.
2281 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2282 Remove unused local var.
2284 * editfns.c (Fmessage_box): Remove unused local var.
2286 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2287 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2288 Omit unused local vars.
2289 * window.c (shrink_windows): Omit unused local var.
2290 * menu.c (digest_single_submenu): Omit unused local var.
2291 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2292 Omit unused local var.
2294 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2295 Don't assume string length fits in int.
2296 (keyremap_step, read_key_sequence): Use size_t for sizes.
2297 (read_key_sequence): Don't check last_real_key_start redundantly.
2299 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2300 instead of alloca (Bug#8344).
2302 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2303 (Fbacktrace_frame): Don't assume nframes fits in int.
2305 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2307 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2310 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2312 * cm.c (calccost): Turn while-do into do-while, for clarity.
2314 * keyboard.c (syms_of_keyboard): Use the same style as later
2315 in this function when indexing through an array. This also
2316 works around GCC bug 48267.
2318 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2320 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2322 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2323 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2325 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2326 This avoids undefined behavior on integer overflow, and is a bit
2327 more convenient anyway since it is compared to a size_t variable.
2329 Variadic C functions now count arguments with size_t, not int.
2330 This avoids an unnecessary limitation on 64-bit machines, which
2331 caused (substring ...) to crash on large vectors (Bug#8344).
2332 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2333 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2334 All variadic functions and their callers changed accordingly.
2335 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2336 * data.c (arith_driver, float_arith_driver): Likewise.
2337 * editfns.c (general_insert_function): Likewise.
2338 * eval.c (struct backtrace.nargs, interactive_p)
2339 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2340 (funcall_lambda, mark_backtrace): Likewise.
2341 * fns.c (concat): Likewise.
2342 * frame.c (x_set_frame_parameters): Likewise.
2343 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2344 0 if not found, not -1. All callers changed.
2346 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2347 (stack_copy_size): Now size_t, not int.
2348 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2350 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2352 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2353 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2354 All callers changed.
2356 * lisp.h (multibyte_char_to_unibyte):
2357 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2358 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2359 * character.h (CHAR_TO_BYTE8):
2360 * cmds.c (internal_self_insert):
2361 * editfns.c (general_insert_function):
2362 * keymap.c (push_key_description):
2363 * search.c (Freplace_match):
2364 * xdisp.c (message_dolog, set_message_1): All callers changed.
2366 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2368 * keyboard.c (safe_run_hook_funcall): New function.
2369 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2370 don't set the hook to nil, but remove the offending function instead.
2371 (Qcommand_hook_internal): Remove, unused.
2372 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2373 Vcommand_hook_internal.
2375 * eval.c (enum run_hooks_condition): Remove.
2376 (funcall_nil, funcall_not): New functions.
2377 (run_hook_with_args): Call each function through a `funcall' argument.
2378 Remove `cond' argument, now redundant.
2379 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2380 (Frun_hook_with_args_until_failure): Adjust accordingly.
2381 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2383 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2385 * dispextern.h (string_buffer_position): Remove declaration.
2387 * print.c (strout): Remove parameter `multibyte', unused since
2388 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2390 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2391 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2392 All callers changed.
2394 * w32.c (_wsa_errlist): Use braces for struct initializers.
2396 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2397 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2398 All callers changed.
2399 (string_buffer_position): Likewise. Also, make static (it's never
2400 used outside xdisp.c).
2401 (cursor_row_p): Remove parameter `w', unused since
2402 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2403 (decode_mode_spec): Remove parameter `precision', introduced during
2404 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2405 All callers changed.
2407 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2409 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2411 2011-03-27 Anders Lindgren <andlind@gmail.com>
2413 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2414 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2415 (ns_update_auto_hide_menu_bar): New functions.
2416 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2417 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2418 ns_constrain_all_frames.
2419 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2420 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2422 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2424 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2426 2011-03-27 Glenn Morris <rgm@gnu.org>
2428 * syssignal.h: Replace RETSIGTYPE with void.
2429 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2430 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2431 Replace SIGTYPE with void everywhere.
2432 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2433 * s/template.h (SIGTYPE): Remove commented out definition.
2435 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2437 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2438 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2440 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2442 * w32.c (read_unc_volume): Use parameter `henum', instead of
2443 global variable `wget_enum_handle'.
2445 * keymap.c (describe_vector): Remove parameters `indices' and
2446 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2447 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2449 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2451 * keyboard.c (timer_check): Remove parameter `do_it_now',
2452 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2453 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2454 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2456 * keyboard.c (read_char):
2457 * w32menu.c (w32_menu_display_help):
2458 * xmenu.c (show_help_event, menu_help_callback):
2459 Adjust calls to `show_help_echo'.
2461 * gtkutil.c (xg_maybe_add_timer):
2462 * keyboard.c (readable_events):
2463 * process.c (wait_reading_process_output):
2464 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2466 * insdel.c (adjust_markers_gap_motion):
2467 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2468 (gap_left, gap_right): Don't call it.
2470 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2472 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2473 incurred during fontification.
2475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2477 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2478 (DEFVAR_PER_BUFFER): Don't pass it.
2480 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2481 (scrolling_window): Don't pass it.
2483 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2485 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2487 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2489 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2490 of variables specific to SELinux and computation of `encoded_absname'.
2492 * image.c (XPutPixel): Remove unused variable `height'.
2494 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2496 * unexw32.c (get_section_info): Remove unused variable `section'.
2498 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2499 (system_process_attributes): Remove unused variable `sess'.
2500 (sys_read): Remove unused variable `err'.
2502 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2503 (w32_wnd_proc): Remove unused variable `isdead'.
2504 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2505 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2506 (x_create_tip_frame): Remove unused variable `tem'.
2508 * w32inevt.c (w32_console_read_socket):
2509 Remove unused variable `no_events'.
2511 * w32term.c (x_draw_composite_glyph_string_foreground):
2512 Remove unused variable `width'.
2514 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2516 * w32term.c (x_set_glyph_string_clipping):
2517 Don't pass uninitialized region to CombineRgn.
2519 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2521 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2522 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2523 (Fx_close_connection): Remove unused variable `i'.
2525 * w32font.c (w32font_draw): Return number of glyphs.
2526 (w32font_open_internal): Remove unused variable `i'.
2527 (w32font_driver): Add missing initializer.
2529 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2530 (fill_in_menu): Remove unused variable `items_added'.
2532 * w32term.c (last_mouse_press_frame): Remove static global variable.
2533 (w32_clip_to_row): Remove unused variable `f'.
2534 (x_delete_terminal): Remove unused variable `i'.
2536 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2537 (NOTHING): Remove unused static global variable.
2538 (uniscribe_check_otf): Remove unused variable `table'.
2539 (uniscribe_font_driver): Add missing initializers.
2541 2011-03-23 Julien Danjou <julien@danjou.info>
2543 * term.c (Fsuspend_tty, Fresume_tty):
2544 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2545 * window.c (temp_output_buffer_show):
2546 * insdel.c (signal_before_change):
2547 * frame.c (Fhandle_switch_frame):
2548 * fileio.c (Fdo_auto_save):
2549 * emacs.c (Fkill_emacs):
2550 * editfns.c (save_excursion_restore):
2551 * cmds.c (internal_self_insert):
2552 * callint.c (Fcall_interactively):
2553 * buffer.c (Fkill_all_local_variables):
2554 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2556 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2557 unconditionnaly since it does the check itself.
2559 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2561 Fix more problems found by GCC 4.5.2's static checks.
2563 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2564 the first time through the loop, since we know p0 < p1 then.
2565 This also avoids a gcc -Wstrict-overflow warning.
2567 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2568 leading to a memory leak, possible in functions like
2569 load_charset_map_from_file that can allocate an unbounded number
2570 of objects (Bug#8318).
2572 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2573 that could (at least in theory) be that large.
2575 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2576 This is less likely to overflow, and avoids undefined behavior if
2577 overflow does occur. All callers changed. Use strtoul to scan
2578 for the unsigned long integer.
2579 (pint2hrstr): Simplify and tune code slightly.
2580 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2582 * scroll.c (do_scrolling): Work around GCC bug 48228.
2583 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2585 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2586 This also avoids a warning with gcc -Wstrict-overflow.
2587 (validate_x_resource_name): Simplify count usage.
2588 This also avoids a warning with gcc -Wstrict-overflow.
2590 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2593 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2595 * process.c (Fmake_network_process): Use socklen_t, not int,
2596 where POSIX says socklen_t is required in portable programs.
2597 This fixes a porting bug on hosts like 64-bit HP-UX, where
2598 socklen_t is wider than int (Bug#8277).
2599 (Fmake_network_process, server_accept_connection):
2600 (wait_reading_process_output, read_process_output):
2603 * process.c: Rename or move locals to avoid shadowing.
2604 (list_processes_1, Fmake_network_process):
2605 (read_process_output_error_handler, exec_sentinel_error_handler):
2606 Rename or move locals.
2607 (Fmake_network_process): Define label "retry_connect" only if needed.
2608 (Fnetwork_interface_info): Fix pointer signedness.
2609 (process_send_signal): Add cast to avoid pointer signedness problem.
2610 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2611 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2613 Make tparam.h and terminfo.c consistent.
2614 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2615 Include tparam.h instead, since it declares them.
2616 * cm.h (PC): Remove extern decl; tparam.h now does this.
2617 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2618 * terminfo.c: Include tparam.h, to check interfaces.
2619 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2620 (tparam): Adjust signature to match interface in tparam.h;
2621 this removes some undefined behavior. Check that outstring and len
2622 are zero, which they always are with Emacs.
2623 * tparam.h (PC, BC, UP): New extern decls.
2625 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2626 (xftfont_open): Rename locals to avoid shadowing.
2628 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2629 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2630 (OTF_TAG_SYM): Omit macro if not needed.
2631 (ftfont_list): Remove unused local.
2632 (get_adstyle_property, ftfont_pattern_entity):
2633 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2634 Rename locals to avoid shadowing.
2636 * xfont.c (xfont_list_family): Mark var as initialized.
2638 * xml.c (make_dom): Now static.
2640 * composite.c (composition_compute_stop_pos): Rename local to
2642 (composition_reseat_it): Remove unused locals.
2643 (find_automatic_composition, composition_adjust_point): Likewise.
2644 (composition_update_it): Mark var as initialized.
2645 (find_automatic_composition): Mark vars as initialized,
2646 with a FIXME (Bug#8290).
2648 character.h: Rename locals to avoid shadowing.
2649 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2650 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2651 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2652 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2655 * textprop.c (property_change_between_p): Remove; unused.
2657 * intervals.c (interval_start_pos): Now static.
2659 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2661 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2662 Rename locals to avoid shadowing.
2664 * sound.c (wav_play, au_play, Fplay_sound_internal):
2665 Fix pointer signedness.
2666 (alsa_choose_format): Remove unused local var.
2667 (wav_play): Initialize a variable to 0, to prevent undefined
2668 behavior (Bug#8278).
2670 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2672 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2674 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2675 clobbering (Bug#8298).
2676 * sysdep.c (sys_subshell): Likewise.
2677 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2679 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2680 This should get cleaned up, so that child_setup has the
2681 same signature on all platforms.
2683 * callproc.c (call_process_cleanup): Now static.
2684 (relocate_fd): Rename locals to avoid shadowing.
2686 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2688 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2689 not to be necessary, and produces flickering.
2691 2011-03-20 Glenn Morris <rgm@gnu.org>
2693 * config.in: Remove file.
2695 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2697 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2698 are now in src/globals.h.
2699 (syms_of_minibuf): Remove spurious & from previous change.
2701 2011-03-20 Leo <sdl.web@gmail.com>
2703 * minibuf.c (completing-read-function): New variable.
2704 (completing-read-default): Rename from completing-read.
2705 (completing-read): Call completing-read-function.
2707 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2709 * xfaces.c (Fx_load_color_file):
2710 Read color file from absolute filename (bug#8250).
2712 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2714 * makefile.w32-in: Update dependencies.
2716 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2718 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2720 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2722 Fix more problems found by GCC 4.5.2's static checks.
2724 * process.c (make_serial_process_unwind, send_process_trap):
2725 (sigchld_handler): Now static.
2727 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2728 That way, the code declares only the vars that it needs.
2729 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2730 * s/cygwin.h (PTY_ITERATION): Likewise.
2731 * s/darwin.h (PTY_ITERATION): Likewise.
2732 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2734 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2735 * process.c (allocate_pty): Don't declare stb unless it's needed.
2737 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2738 (CONSTANTLIM): Remove; unused.
2739 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2740 Define only if needed.
2742 * unexelf.c (unexec): Name an expression,
2743 to avoid gcc -Wbad-function-cast warning.
2744 Use a different way to cause a compilation error if anyone uses
2745 n rather than nn, a way that does not involve shadowing.
2746 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2748 * deps.mk (unexalpha.o): Remove; unused.
2750 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2751 * unexec.h: New file.
2752 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2753 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2755 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2756 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2757 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2758 Change as necessary to match prototype in unexec.h.
2760 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2762 (back_comment, skip_chars): Mark vars as initialized.
2764 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2765 Rename locals to avoid shadowing.
2767 * lread.c (read1): Rewrite so as not to use empty "else".
2768 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2770 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2772 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2773 warning when compiling print.c.
2775 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2776 instead of using an uninitialized var.
2777 (font_sort_entities): Mark var as initialized.
2779 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2781 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2782 pointers to constants.
2783 (font_parse_fcname): Remove unused vars.
2784 (font_delete_unmatched): Now static.
2785 (font_get_spec): Remove; unused.
2786 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2787 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2788 Rename or move locals to avoid shadowing.
2790 * fns.c (require_nesting_list, require_unwind): Now static.
2791 (Ffillarray): Rename locals to avoid shadowing.
2793 * floatfns.c (domain_error2): Define only if needed.
2794 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2796 * alloc.c (mark_backtrace): Move decl from here ...
2797 * lisp.h: ... to here, so that it can be checked.
2799 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2800 (Fdefvar): Rewrite so as not to use empty "else".
2801 (lisp_indirect_variable): Name an expression,
2802 to avoid gcc -Wbad-function-cast warning.
2803 (Fdefvar): Rename locals to avoid shadowing.
2805 * callint.c (quotify_arg, quotify_args): Now static.
2806 (Fcall_interactively): Rename locals to avoid shadowing.
2807 Use const pointer when appropriate.
2809 * lisp.h (get_system_name, get_operating_system_release):
2810 Move decls here, to check interfaces.
2811 * process.c (get_operating_system_release): Move decl to lisp.h.
2812 * xrdb.c (get_system_name): Likewise.
2813 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2814 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2815 some of which prompt warnings from gcc -Wbad-function-cast.
2816 (Fformat_time_string, Fencode_time, Finsert_char):
2817 (Ftranslate_region_internal, Fformat):
2818 Rename or remove local vars to avoid shadowing.
2819 (Ftranslate_region_internal): Mark var as initialized.
2821 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2824 * lisp.h (eassert): Check that the argument compiles, even if
2825 ENABLE_CHECKING is not defined.
2827 * data.c (Findirect_variable): Name an expression, to avoid
2828 gcc -Wbad-function-cast warning.
2829 (default_value, arithcompare, arith_driver, arith_error): Now static.
2830 (store_symval_forwarding): Rename local to avoid shadowing.
2831 (Fmake_variable_buffer_local, Fmake_local_variable):
2832 Mark variables as initialized.
2833 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2835 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2836 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2837 Rename locals to avoid shadowing.
2838 (mark_stack): Move local variables into the #ifdef region where
2840 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2841 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2843 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2844 (GC_STRING_CHARS): Remove; not used.
2845 (Fmemory_limit): Cast sbrk's returned value to char *.
2847 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2848 avoids undefined behavior in theory.
2850 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2852 Use functions, not macros, for up- and down-casing (Bug#8254).
2853 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2854 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2855 to use the following functions instead of these macros.
2856 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2857 EMACS_INT, since callers assume the returned value fits in int.
2858 (upcase1): Likewise, for UPCASE_TABLE.
2859 (uppercasep, lowercasep, upcase): New static inline functions.
2860 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2861 the race-condition problem in the old DOWNCASE.
2863 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2864 Rename locals to avoid shadowing.
2865 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2866 (regex_compile, re_search_2, re_match_2_internal):
2867 Remove unused local vars.
2868 (FREE_VAR): Rewrite so as not to use empty "else",
2869 which gcc can warn about.
2870 (regex_compile, re_match_2_internal): Mark locals as initialized.
2871 (RETALLOC_IF): Define only if needed.
2872 (WORDCHAR_P): Likewise. This one is never needed, but is used
2873 only in a comment talking about a compiler bug, so put inside
2874 the #if 0 of that comment.
2875 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2876 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2879 * search.c (boyer_moore): Rename locals to avoid shadowing.
2880 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2881 (PREV_CHAR_BOUNDARY): Likewise.
2883 * search.c (simple_search): Remove unused var.
2885 * dired.c (compile_pattern): Move decl from here ...
2886 * lisp.h: ... to here, so that it can be checked.
2887 (struct re_registers): New forward decl.
2889 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2891 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2893 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2894 Rename locals to avoid shadowing.
2895 (Fvertical_motion): Mark locals as initialized.
2897 * casefiddle.c (casify_object, casify_region): Now static.
2898 (casify_region): Mark local as initialized.
2900 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2902 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2903 New macros, so that the caller can use some names other than
2904 gcpro1, gcpro2, etc.
2905 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2907 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2908 argument, for consistency with GCPRO2_VAR, etc: it is now the
2909 prefix of the variable, not the variable itself. All uses
2911 * dired.c (directory_files_internal, file_name_completion):
2912 Rename locals to avoid shadowing.
2914 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2915 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2916 dired.c's scmp function, had undefined behavior.
2917 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2918 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2919 * buffer.h: ... to here, because these macros use current_buffer,
2920 and the new implementation with inline functions needs to have
2921 current_buffer in scope now, rather than later when the macros
2923 (downcase, upcase1): New static inline functions.
2924 (DOWNCASE, UPCASE1): Reimplement using these functions.
2925 This avoids undefined behavior in expressions like
2926 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2927 from race conditions in accessing the global variables
2928 case_temp1 and case_temp2.
2929 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2930 * lisp.h (case_temp1, case_temp2): Remove their decls.
2931 * character.h (ASCII_CHAR_P): Move from here ...
2932 * lisp.h: ... to here, so that the inline functions mentioned
2935 * dired.c (directory_files_internal_unwind): Now static.
2937 * fileio.c (file_name_as_directory, directory_file_name):
2938 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2940 (file_name_as_directory): Use const pointers when appropriate.
2941 (Fexpand_file_name): Likewise. In particular, newdir might
2942 point at constant storage, so make it a const pointer.
2943 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2944 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2946 (Fset_file_times, Finsert_file_contents, auto_save_error):
2947 Rename locals to avoid shadowing.
2949 * minibuf.c (choose_minibuf_frame_1): Now static.
2950 (Ftry_completion, Fall_completions): Rename or remove locals
2953 * marker.c (bytepos_to_charpos): Remove; unused.
2955 * lisp.h (verify_bytepos, count_markers): New decls,
2956 so that gcc does not warn that these functions aren't declared.
2958 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2959 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2960 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2961 (copy_text): Remove unused local var.
2963 * filelock.c (within_one_second): Now static.
2964 (lock_file_1): Rename local to avoid shadowing.
2966 * buffer.c (fix_overlays_before): Mark locals as initialized.
2967 (fix_start_end_in_overlays): Likewise. This function should be
2968 simplified by using pointers-to-pointers, but that's a different
2970 (switch_to_buffer_1): Now static.
2971 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2972 (report_overlay_modification): Rename locals to avoid shadowing.
2974 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2975 Fix pointer signedness issue.
2976 (sys_subshell): Mark local as volatile if checking for lint,
2977 to suppress a gcc -Wclobbered warning that does not seem to be right.
2978 (MAXPATHLEN): Define only if needed.
2980 * process.c (serial_open, serial_configure): Move decls from here ...
2981 * systty.h: ... to here, so that they can be checked.
2983 * fns.c (get_random, seed_random): Move extern decls from here ...
2984 * lisp.h: ... to here, so that they can be checked.
2986 * sysdep.c (reset_io): Now static.
2987 (wait_for_termination_signal): Remove; unused.
2989 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2990 (copy_keymap_item, append_key, push_text_char_description):
2992 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2993 (DENSE_TABLE_SIZE): Remove; unused.
2994 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2995 (describe_map_tree):
2996 Rename locals to avoid shadowing.
2998 * keyboard.c: Declare functions static if they are not used elsewhere.
2999 (echo_char, echo_dash, cmd_error, top_level_2):
3000 (poll_for_input, handle_async_input): Now static.
3001 (read_char, kbd_buffer_get_event, make_lispy_position):
3002 (make_lispy_event, make_lispy_movement, apply_modifiers):
3003 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3004 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3005 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3006 (read_key_sequence, read_char): Mark locals as initialized.
3007 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3009 * keyboard.h (make_ctrl_char): New decl.
3010 (mark_kboards): Move decl here ...
3011 * alloc.c (mark_kboards): ... from here.
3013 * lisp.h (force_auto_save_soon): New decl.
3015 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3016 (DEFINE_DUMMY_FUNCTION): New macro.
3017 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3019 (main): Add casts to avoid warnings
3020 if GCC considers string literals to be constants.
3022 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3024 * dbusbind.c: Pointer signedness fixes.
3025 (xd_signature, xd_append_arg, xd_initialize):
3026 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3028 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3029 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3031 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3032 if GCC considers string literals to be constants.
3033 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3035 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3037 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3038 (print_preprocess, print_object): New macro to fix last change.
3040 * print.c (print_preprocess): Don't forget font objects.
3042 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3044 * emacs.c (USAGE3): Doc fixes.
3046 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3048 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3051 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3053 * lisp.h (VWindow_system, Qfile_name_history):
3054 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3055 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3056 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3058 * w32select.c: Don't #include "keyboard.h".
3059 (run_protected): Add extern declaration for waiting_for_input.
3061 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3062 * w32console.c (detect_input_pending, read_input_pending)
3063 (encode_terminal_code):
3064 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3065 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3066 (w32_system_caret_y, Qfile_name_history):
3067 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3068 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3069 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3070 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3071 * w32proc.c (Qlocal, report_file_error):
3072 * w32term.c (Vwindow_system, updating_frame):
3073 * w32uniscribe.c (initialized, uniscribe_font_driver):
3074 Remove unneeded extern declarations.
3076 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3078 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3080 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3082 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3083 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3084 These macros can no longer be used for assignment.
3086 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3087 Assign struct members directly, instead of using BUF_BEGV etc.
3088 (record_buffer_markers, fetch_buffer_markers): New functions for
3089 recording and fetching special buffer markers.
3090 (set_buffer_internal_1, set_buffer_temp): Use them.
3092 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3094 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3096 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3097 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3099 * xdisp.c (hscroll_window_tree):
3100 (reconsider_clip_changes): Use PT instead of BUF_PT.
3102 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3104 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3105 $(EMACS_ROOT)/lib/intprops.h.
3107 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3109 Fix more problems found by GCC 4.5.2's static checks.
3111 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3112 to unsigned char * to avoid compiler diagnostic.
3113 (xg_free_frame_widgets): Make it clear that a local variable is
3114 needed only if USE_GTK_TOOLTIP.
3115 (gdk_window_get_screen): Make it clear that this macro is needed
3116 only if USE_GTK_TOOLTIP.
3117 (int_gtk_range_get_value): New function, which avoids a diagnostic
3118 from gcc -Wbad-function-cast.
3119 (xg_set_toolkit_scroll_bar_thumb): Use it.
3120 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3121 diagnostic from gcc -Wbad-function-cast.
3122 (get_utf8_string, xg_get_file_with_chooser):
3123 Rename locals to avoid shadowing.
3124 (create_dialog): Move locals to avoid shadowing.
3126 * xgselect.c (xg_select): Remove unused var.
3128 * image.c (four_corners_best): Mark locals as initialized.
3129 (gif_load): Initialize transparent_p to zero (Bug#8238).
3130 Mark another local as initialized.
3131 (my_png_error, my_error_exit): Mark with NO_RETURN.
3133 * image.c (clear_image_cache): Now static.
3134 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3135 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3136 (x_edge_detection): Remove unnecessary cast that
3137 gcc -Wbad-function-cast diagnoses.
3138 (gif_load): Fix pointer signedness.
3139 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3140 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3142 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3144 Improve quality of tests for time stamp overflow.
3145 For example, without this patch (encode-time 0 0 0 1 1
3146 1152921504606846976) returns the obviously-bogus value (-948597
3147 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3148 reports time overflow. See
3149 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3150 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3151 * editfns.c: Include limits.h and intprops.h.
3152 (TIME_T_MIN, TIME_T_MAX): New macros.
3153 (time_overflow): Move earlier, to before first use.
3154 (hi_time, lo_time): New functions, for an accurate test for
3156 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3157 (Fget_internal_run_time): Don't assume time_t fits in int.
3158 (make_time): Use list2 instead of Fcons twice.
3159 (Fdecode_time): More accurate test for out-of-range times.
3160 (check_tm_member): New function.
3161 (Fencode_time): Use it, to test for out-of-range times.
3162 (lisp_time_argument): Don't rely on undefined left-shift and
3163 right-shift behavior when checking for time stamp overflow.
3165 * editfns.c (time_overflow): New function, refactoring common code.
3166 (Fformat_time_string, Fdecode_time, Fencode_time):
3167 (Fcurrent_time_string): Use it.
3169 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3170 * dired.c (make_time): Move to ...
3171 * editfns.c (make_time): ... here.
3172 * systime.h: Note the move.
3174 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3176 * fringe.c (update_window_fringes): Remove unused variables.
3178 * unexmacosx.c (copy_data_segment): Also copy __got section.
3181 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3183 * termcap.c [MSDOS]: Include "msdos.h".
3184 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3185 Constify `char *' arguments and their references according to
3186 prototypes in tparam.h.
3188 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3190 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3191 Adapt all references accordingly.
3193 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3195 2011-03-11 Tom Tromey <tromey@redhat.com>
3197 * buffer.c (syms_of_buffer): Remove obsolete comment.
3199 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3201 * termhooks.h (encode_terminal_code): Declare prototype.
3203 * msdos.c (encode_terminal_code): Don't declare prototype.
3205 * term.c (encode_terminal_code): Now external again, used by
3206 w32console.c and msdos.c.
3208 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3209 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3211 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3213 Fix some minor problems found by GCC 4.5.2's static checks.
3215 * fringe.c (update_window_fringes): Mark locals as initialized
3217 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3219 * alloc.c (mark_fringe_data): Move decl from here ...
3220 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3221 to check its interface.
3222 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3224 * fontset.c (free_realized_fontset): Now static.
3225 (Fset_fontset_font): Rename local to avoid shadowing.
3226 (fontset_font): Mark local as initialized.
3227 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3229 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3231 * xselect.c (x_disown_buffer_selections): Remove; not used.
3232 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3233 (x_own_selection, Fx_disown_selection_internal): Rename locals
3235 (x_handle_dnd_message): Remove local to avoid shadowing.
3237 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3238 so that the caller can use some name other than gcpro1.
3239 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3240 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3241 (Fx_backspace_delete_keys_p):
3242 Use them to avoid shadowing, and rename vars to avoid shadowing.
3243 (x_decode_color, x_set_name, x_window): Now static.
3244 (Fx_create_frame): Add braces to silence GCC warning.
3245 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3246 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3247 Remove unused locals.
3248 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3249 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3250 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3253 * xterm.h (x_mouse_leave): New decl.
3255 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3256 Remove unused functions.
3257 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3258 (x_calc_absolute_position): Now static.
3259 (XTread_socket): Don't define label "out" unless it's used.
3260 Don't declare local "event" unless it's used.
3261 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3262 unless they are used.
3263 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3264 (x_fatal_error_signal): Remove; not used.
3265 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3266 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3267 (x_error_catcher, x_connection_closed, x_error_handler):
3268 (x_error_quitter, xembed_send_message, x_iconify_frame):
3269 (my_log_handler): Rename locals to avoid shadowing.
3270 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3271 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3273 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3274 Rename or move locals to avoid shadowing.
3275 (tty_defined_color, merge_face_heights): Now static.
3276 (free_realized_faces_for_fontset): Remove; not used.
3277 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3278 does not deduce is never used uninitialized.
3279 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3280 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3282 * terminal.c (store_terminal_param): Now static.
3284 * xmenu.c (menu_highlight_callback): Now static.
3285 (set_frame_menubar): Remove unused local.
3286 (xmenu_show): Rename parameter to avoid shadowing.
3287 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3288 since they might point to immutable storage.
3289 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3290 since it's unused otherwise.
3292 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3293 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3294 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3295 avoids a gcc -Wuninitialized diagnostic.
3296 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3297 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3298 does not deduce are never used uninitialized.
3300 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3302 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3303 * window.c (window_loop, size_window):
3304 (run_window_configuration_change_hook, enlarge_window): Likewise.
3306 * window.c (display_buffer): Now static.
3307 (size_window): Mark variables that gcc -Wuninitialized
3308 does not deduce are never used uninitialized.
3309 * window.h (check_all_windows): New decl, to forestall
3310 gcc -Wmissing-prototypes diagnostic.
3311 * dispextern.h (bidi_dump_cached_states): Likewise.
3313 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3315 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3317 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3318 and to avoid gcc -Wuninitialized warning.
3319 (load_charset_map): Mark variables that gcc -Wuninitialized
3320 does not deduce are never used uninitialized.
3321 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3323 * coding.c (coding_set_source, coding_set_destination):
3324 Use "else { /* comment */ }" rather than "else /* comment */;"
3325 for clarity, and to avoid gcc -Wempty-body warning.
3326 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3327 a block, when the outer 'i' will do.
3328 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3329 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3330 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3331 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3332 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3333 Rename locals to avoid shadowing.
3334 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3335 * coding.c (emacs_mule_char, encode_invocation_designation):
3336 Now static, since they're not used elsewhere.
3337 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3338 (decode_coding_object, encode_coding_object, detect_coding_system):
3339 (decode_coding_emacs_mule): Mark variables that gcc
3340 -Wuninitialized does not deduce are never used uninitialized.
3341 (detect_coding_iso_2022): Initialize a local variable that might
3342 be used uninitialized. Leave a FIXME because it's not clear that
3343 this initialization is needed. (Bug#8211)
3344 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3345 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3346 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3347 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3348 Remove unused macros.
3350 * category.c (hash_get_category_set): Remove unused local var.
3351 (copy_category_table): Now static, since it's not used elsewhere.
3352 * character.c (string_count_byte8): Likewise.
3354 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3355 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3357 * chartab.c (copy_sub_char_table): Now static, since it's not used
3359 (sub_char_table_ref_and_range, char_table_ref_and_range):
3360 Rename locals to avoid shadowing.
3361 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3363 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3364 (BIDI_BOB): Remove unused macro.
3366 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3367 deduce are never used uninitialized.
3368 * term.c (encode_terminal_code): Likewise.
3370 * term.c (encode_terminal_code): Now static. Remove unused local.
3372 * tparam.h: New file.
3373 * term.c, tparam.h: Include it.
3374 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3375 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3376 Move these decls to tparam.h, and make them agree with what
3377 is actually in tparam.c. The previous trick of using incompatible
3378 decls in different modules does not conform to the C standard.
3379 All callers of tparam changed to use tparam's actual API.
3380 * tparam.c (tparam1, tparam, tgoto):
3381 Use const pointers where appropriate.
3383 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3384 * cm.h (struct cm): Likewise.
3385 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3386 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3387 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3388 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3389 (turn_on_face, init_tty): Likewise.
3390 * termchar.h (struct tty_display_info): Likewise.
3392 * term.c (term_mouse_position): Rename local to avoid shadowing.
3394 * alloc.c (mark_ttys): Move decl from here ...
3395 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3397 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3399 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3401 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3403 * search.c (compile_pattern_1): Remove argument regp, unused since
3404 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3405 (compile_pattern): Don't pass it.
3407 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3409 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3410 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3412 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3414 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3416 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3417 gdk_window_get_screen, gdk_window_get_geometry,
3418 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3419 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3420 (xg_get_pixbuf_from_pixmap): New function.
3421 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3422 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3423 Call xg_get_pixbuf_from_pixmap instead of
3424 gdk_pixbuf_get_from_drawable.
3425 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3426 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3427 (xg_check_special_colors): Use GtkStyleContext and its functions
3429 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3430 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3431 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3432 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3433 Call gtk_widget_get_preferred_size.
3434 (xg_frame_resized): gdk_window_get_geometry only takes 5
3436 (xg_win_to_widget, xg_event_is_for_menubar):
3437 Call gdk_x11_window_lookup_for_display.
3438 (xg_set_widget_bg): New function.
3439 (delete_cb): New function.
3440 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3441 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3442 (xg_set_background_color): Call xg_set_widget_bg.
3443 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3444 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3445 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3446 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3448 (update_frame_tool_bar): Call gtk_widget_hide.
3449 (xg_initialize): Use GDK_KEY_g.
3451 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3453 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3455 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3456 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3457 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3459 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3461 * w32xfns.c (select_palette): Check success of RealizePalette against
3462 GDI_ERROR, not zero.
3464 See ChangeLog.11 for earlier changes.
3470 Copyright (C) 2011 Free Software Foundation, Inc.
3472 This file is part of GNU Emacs.
3474 GNU Emacs is free software: you can redistribute it and/or modify
3475 it under the terms of the GNU General Public License as published by
3476 the Free Software Foundation, either version 3 of the License, or
3477 (at your option) any later version.
3479 GNU Emacs is distributed in the hope that it will be useful,
3480 but WITHOUT ANY WARRANTY; without even the implied warranty of
3481 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3482 GNU General Public License for more details.
3484 You should have received a copy of the GNU General Public License
3485 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.