| blob | 472dcc13d144cbca2dec9605b13c5cf766e47f88 |
1 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3 * .gdbinit (pitx): Fix incorrect references to fields of the
4 iterator stack.
6 2012-02-17 Chong Yidong <cyd@gnu.org>
8 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
10 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
12 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
13 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
15 2012-02-15 Chong Yidong <cyd@gnu.org>
17 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
18 marked as special. Also, starting docstrings with * is obsolete.
20 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
22 * gnutls.c (emacs_gnutls_write): Fix last change.
24 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
26 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
27 send_process.
29 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
31 * keymap.c (Fsingle_key_description): Handle char ranges.
33 2012-02-12 Chong Yidong <cyd@gnu.org>
35 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
36 as that creates a dangerous corner case.
38 * window.c (Fdelete_window_internal): Invalidate the mouse
39 highlight (Bug#9904).
41 2012-02-12 Glenn Morris <rgm@gnu.org>
43 * xselect.c (Fx_own_selection_internal)
44 (Fx_get_selection_internal, Fx_disown_selection_internal)
45 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
46 * nsselect.m (Fx_own_selection_internal)
47 (Fx_disown_selection_internal, Fx_selection_exists_p)
48 (Fx_selection_owner_p, Fx_get_selection_internal):
49 Sync docs and argument specs with the xselect.c versions.
51 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
53 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
55 2012-02-11 Eli Zaretskii <eliz@gnu.org>
57 * w32select.c (Fx_selection_exists_p): Sync doc string and
58 argument list with xselect.c. (Bug#10783)
60 * w16select.c (Fx_selection_exists_p): Sync doc string and
61 argument list with xselect.c. (Bug#10783)
63 2012-02-10 Glenn Morris <rgm@gnu.org>
65 * fns.c (Fsecure_hash): Doc fix.
67 2012-02-09 Kenichi Handa <handa@m17n.org>
69 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
71 2012-02-07 Chong Yidong <cyd@gnu.org>
73 * buffer.c (Fbuffer_local_variables)
74 (buffer_lisp_local_variables): Handle unbound vars correctly;
75 don't let Qunbound leak into Lisp.
77 2012-02-07 Glenn Morris <rgm@gnu.org>
79 * image.c (Fimagemagick_types): Doc fix.
81 * image.c (imagemagick-render-type): Change it from a lisp object
82 to an integer. Move the doc here from the lisp manual.
83 Treat all values not equal to 0 the same.
85 2012-02-06 Chong Yidong <cyd@gnu.org>
87 * doc.c (store_function_docstring): Avoid applying docstring of
88 alias to base function (Bug#2603).
90 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
92 * .gdbinit (pp1, pv1): Remove redundant defines.
93 (pr): Use pp.
95 2012-02-04 Chong Yidong <cyd@gnu.org>
97 * nsterm.m: Declare a global (Bug#10694).
99 2012-02-04 Eli Zaretskii <eliz@gnu.org>
101 * w32.c (get_emacs_configuration_options): Include
102 --enable-checking, if specified, in the return value.
104 2012-02-04 Martin Rudalics <rudalics@gmx.at>
106 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
107 after rounding frame sizes. (Bug#9723)
109 2012-02-04 Eli Zaretskii <eliz@gnu.org>
111 * keyboard.c (adjust_point_for_property): Don't position point
112 before BEGV. (Bug#10696)
114 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
116 Handle overflow when computing char display width (Bug#9496).
117 * character.c (char_width): Return EMACS_INT, not int.
118 (char_width, c_string_width): Check for overflow when
119 computing the width; this is possible now that individual
120 characters can have unbounded width. Problem introduced
121 by merge from Emacs 23 on 2012-01-19.
123 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
125 * dbusbind.c (Fdbus_register_method): Mention the return value
126 :ignore in the docstring.
128 2012-02-02 Glenn Morris <rgm@gnu.org>
130 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
132 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
133 Unconditionally set to t. (Bug#10673)
134 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
135 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
136 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
138 2012-02-02 Kenichi Handa <handa@m17n.org>
140 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
141 0, do not call append_composite_glyph.
143 2012-02-02 Kenichi Handa <handa@m17n.org>
145 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
146 NULL (Bug#6988).
147 (x_produce_glyphs): If the component of a composition is a null
148 string, set it->pixel_width to 1 to avoid zero-width glyph.
150 2012-02-01 Eli Zaretskii <eliz@gnu.org>
152 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
153 first 2 arguments are identical. This makes inserting large
154 output from a subprocess an order of magnitude faster on
155 MS-Windows, where all sbrk'ed memory is always contiguous.
157 2012-01-31 Glenn Morris <rgm@gnu.org>
159 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
160 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
161 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
163 2012-01-29 Glenn Morris <rgm@gnu.org>
165 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
167 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
169 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
171 2012-01-28 Chong Yidong <cyd@gnu.org>
173 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
175 2012-01-26 Chong Yidong <cyd@gnu.org>
177 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
179 * search.c (Fsearch_forward, Fsearch_backward): Document negative
180 repeat counts (Bug#10507).
182 2012-01-26 Glenn Morris <rgm@gnu.org>
184 * lread.c (syms_of_lread): Doc fix.
186 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
188 * coding.c (encode_designation_at_bol): Change return value to
189 EMACS_INT.
191 2012-01-25 Chong Yidong <cyd@gnu.org>
193 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
195 2012-01-21 Chong Yidong <cyd@gnu.org>
197 * floatfns.c (Fcopysign): Make the second argument non-optional,
198 since nil is not allowed anyway.
200 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
202 * process.c (read_process_output): Use p instead of XPROCESS (proc).
203 (send_process): Likewise.
205 2012-01-19 Martin Rudalics <rudalics@gmx.at>
207 * window.c (save_window_save, Fcurrent_window_configuration)
208 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
209 doc-strings.
211 2012-01-19 Kenichi Handa <handa@m17n.org>
213 * character.c (char_width): New function.
214 (Fchar_width, c_string_width, lisp_string_width):
215 Use char_width (Bug#9496).
217 2012-01-16 Martin Rudalics <rudalics@gmx.at>
219 * window.c (Vwindow_persistent_parameters): New variable.
220 (Fset_window_configuration, save_window_save): Handle persistent
221 window parameters.
223 2012-01-14 Eli Zaretskii <eliz@gnu.org>
225 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
226 thrashing the stack of the thread. (Bug#9087)
228 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
230 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
232 2012-01-11 Eli Zaretskii <eliz@gnu.org>
234 * xdisp.c (rows_from_pos_range): Handle the case where the
235 highlight ends on a newline. (Bug#10464)
236 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
237 he end column for display of highlight that ends on a newline
238 before a R2L line.
240 2012-01-11 Glenn Morris <rgm@gnu.org>
242 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
243 from load-path also when installation-directory is nil. (Bug#10208)
245 2012-01-10 Glenn Morris <rgm@gnu.org>
247 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
249 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
250 Update template values to be closer to their typical values these days.
252 2012-01-09 Eli Zaretskii <eliz@gnu.org>
254 * xdisp.c (rows_from_pos_range): Accept additional argument
255 DISP_STRING, and accept any glyph in a row whose object is that
256 string as eligible for mouse highlight. Fixes mouse highlight of
257 display strings from overlays. (Bug#10464)
259 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
261 emacs: fix an auto-save permissions race condition (Bug#10400)
262 * fileio.c (auto_saving_dir_umask): New static var.
263 (Fmake_directory_internal): Use it.
264 (do_auto_save_make_dir): Set it, instead of invoking chmod after
265 creating the directory. The old code temporarily assigns
266 too-generous permissions to the directory.
267 (do_auto_save_eh): Clear it.
268 (Fdo_auto_save): Catch all errors, not just file errors, so
269 that the var is always cleared.
271 2012-01-07 Eli Zaretskii <eliz@gnu.org>
273 * search.c (scan_buffer): Pass character positions to
274 know_region_cache, not byte positions. (Bug#6540)
276 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
278 * w32.c (sys_rename): Report EXDEV when rename of a directory
279 fails because the target is on another logical disk. (Bug#10284)
281 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
283 * xterm.c (x_embed_request_focus): New function.
285 * xterm.h: Add prototype.
287 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
289 2012-01-05 Glenn Morris <rgm@gnu.org>
291 * emacs.c (emacs_copyright): Update short copyright year to 2012.
293 2012-01-01 Eli Zaretskii <eliz@gnu.org>
295 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
296 Load gnutls_transport_set_lowat only if GnuTLS version is below
297 2.11.1.
298 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
299 GnuTLS versions below 2.11.1.
301 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
303 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
304 to the doc string advising against its use for altering the way
305 windows are scrolled.
307 2011-12-28 Kenichi Handa <handa@m17n.org>
309 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
310 coding-system ASCII compatible only when it does not produce BOM
311 on encoding (Bug#10383).
313 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
315 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
316 can scroll.
317 (create_and_show_popup_menu): Always use menu_position_func for
318 Gtk3 (Bug#10361).
320 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
322 * callint.c (Fcall_interactively): Don't truncate prompt string.
324 2011-12-23 Eli Zaretskii <eliz@gnu.org>
326 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
327 property that ends at ZV, so that the bidi iteration could be
328 resumed from there (after widening). (Bug#10360)
330 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
332 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
334 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
336 * nsterm.m (x_free_frame_resources):
337 Release f->output_data.ns->miniimage.
338 (ns_index_color): Fix indentation. Do not retain
339 color_table->colors[i].
341 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
342 before returning.
344 * nsfns.m (x_set_background_color): Assign return value from
345 ns_index_color to face-background instead of NSColor*.
346 (ns_implicitly_set_icon_type): Fix indentation.
347 Change assignment in for loop to comparison.
349 * emacs.c (ns_pool): New variable.
350 (main): Assign ns_pool.
351 (Fkill_emacs): Call ns_release_autorelease_pool.
353 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
354 autorelease fdesc, release fdAttrs and tdict.
355 (ns_get_covering_families): Release charset.
356 (ns_findfonts): Release NSFontDescriptor created with new.
357 (ns_uni_to_glyphs): Fix indentation.
358 (setString): Release attrStr before assigning new value.
360 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
362 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
363 and NS_IMPL_COCOA.
364 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
365 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
367 2011-12-18 David Reitter <reitter@cmu.edu>
369 * nsterm.m (ns_term_init): Subscribe for notifications
370 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
371 to method trackingNotification in EmacsMenu.
373 * nsmenu.m (trackingMenu): New variable.
374 (trackingNotification): New method (from Aquamacs).
375 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
376 from Aquamacs (Bug#7030).
378 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
380 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
381 (symbol_to_nsstring): Fix indentation.
382 (ns_symbol_to_pb): New function.
383 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
384 (Fns_rotate_cut_buffers_internal): Removed.
385 (Fns_store_selection_internal): Renamed from
386 Fns_store_cut_buffer_internal.
387 (ns_get_foreign_selection, Fx_own_selection_internal)
388 (Fx_disown_selection_internal, Fx_selection_exists_p)
389 (Fns_get_selection_internal, Fns_store_selection_internal):
390 Use ns_symbol_to_pb and check if return value is nil.
391 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
392 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
393 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
394 renamed to Sns_store_selection_internal.
395 (ns_handle_selection_request): Move code to Fx_own_selection_internal
396 and remove this function.
397 (ns_handle_selection_clear): Remove, never used.
398 (Fx_own_selection_internal): Move code from ns_handle_selection_request
399 here.
401 2011-12-17 Ken Brown <kbrown@cornell.edu>
403 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
404 GID is unknown (Bug#10257).
406 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
408 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
409 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
410 which caused a build failure on GNU/Linux IA-64. This problem was
411 introduced by my 2011-10-07 patch.
413 2011-12-15 Juri Linkov <juri@jurta.org>
415 * image.c (imagemagick_error): New function. (Bug#10112)
416 (imagemagick_load_image): Comment out `MagickSetResolution' call.
417 Use `imagemagick_error' where ImageMagick functions return
418 `MagickFalse'.
419 (Fimagemagick_types): Add `Fnreverse' to return the list in the
420 proper order.
422 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
424 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
425 fill background (Bug#8992).
427 2011-12-13 Martin Rudalics <rudalics@gmx.at>
429 * window.c (Vwindow_combination_resize)
430 (Vwindow_combination_limit): Use t instead of non-nil in
431 doc-strings.
432 (Vrecenter_redisplay): Add first sentence of doc-string on
433 separate line.
434 (Frecenter): Fix doc-string typo.
436 2011-12-11 Kenichi Handa <handa@m17n.org>
438 * coding.c (Funencodable_char_position): Pay attention to the
439 buffer text relocation (Bug#9389).
441 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
443 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
444 gtk_init (Bug#10100).
446 2011-12-10 Eli Zaretskii <eliz@gnu.org>
448 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
449 IT->string is nil. (Bug#10263)
451 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
453 * nsterm.h (x_free_frame_resources): Declare.
455 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
456 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
458 * nsterm.h (ns_get_defaults_value): Declare.
460 * nsterm.m (ns_default): Call ns_get_defaults_value.
462 2011-12-09 Eli Zaretskii <eliz@gnu.org>
464 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
465 (Bug#10170)
467 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
469 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
470 that where the value of an _OBJC_* symbol points to is in the .bss
471 section (Bug#10240).
473 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
475 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
476 after the loop to call ccl_driver at least once (Bug#8619).
478 2011-12-08 Kenichi Handa <handa@m17n.org>
480 * ftfont.c (get_adstyle_property): Fix previous change
481 (Bug#10233).
483 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
485 * w32.c (init_environment): If no_site_lisp, remove site-lisp
486 dirs from the default value of EMACSLOADPATH (bug#10208).
488 2011-12-07 Glenn Morris <rgm@gnu.org>
490 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
491 installation and source directories as well. (Bug#10208)
493 2011-12-06 Chong Yidong <cyd@gnu.org>
495 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
497 2011-12-06 Glenn Morris <rgm@gnu.org>
499 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
500 as an error, not just -1. (Bug#10217)
502 2011-12-05 Chong Yidong <cyd@gnu.org>
504 * keyboard.c (process_special_events): New function.
505 (swallow_events, Finput_pending_p): Use it (Bug#10195).
507 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
509 * coding.c (encode_designation_at_bol): Don't use uninitialized
510 local variable (Bug#9318).
512 2011-12-05 Kenichi Handa <handa@m17n.org>
514 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
515 return Qnil (Bug#8046, Bug#10193).
517 2011-12-05 Kenichi Handa <handa@m17n.org>
519 * coding.c (encode_designation_at_bol): New args charbuf_end and
520 dst. Return the number of produced bytes. Callers changed.
521 (coding_set_source): Return how many bytes coding->source was
522 relocated.
523 (coding_set_destination): Return how many bytes
524 coding->destination was relocated.
525 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
526 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
528 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
530 * coding.c (CODING_CHAR_CHARSET_P): New macro.
531 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
532 macro (Bug#9318).
534 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
536 The following changes are to fix Bug#9318.
538 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
539 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
540 (encode_coding_iso_2022, encode_coding_sjis)
541 (encode_coding_big5, encode_coding_charset): Use the above macros.
543 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
545 * lisp.h (process_quit_flag): Fix external declaration.
547 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
549 Don't macro-inline non-performance-critical code.
550 * eval.c (process_quit_flag): New function.
551 * lisp.h (QUIT): Use it.
553 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
555 * nsfns.m (get_geometry_from_preferences): New function.
556 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
558 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
560 * emacs.c (Qkill_emacs): Define.
561 (syms_of_emacs): Initialize it.
562 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
563 Qquit_flag to `kill-emacs' instead.
564 (quit_throw_to_read_char): Add parameter `from_signal'.
565 All callers changed. Call Fkill_emacs if requested and safe.
566 * lisp.h (QUIT): Call Fkill_emacs if requested.
568 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
570 * widget.c (update_wm_hints): Return if wmshell is null.
571 (widget_update_wm_size_hints): New function.
573 * widget.h (widget_update_wm_size_hints): Declare.
575 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
576 widget_update_wm_size_hints (Bug#10104).
578 2011-12-03 Eli Zaretskii <eliz@gnu.org>
580 * xdisp.c (handle_invisible_prop): If the invisible text ends just
581 before a newline, prepare the bidi iterator for consuming the
582 newline, and keep the current paragraph direction. (Bug#10183)
583 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
585 2011-12-02 Juri Linkov <juri@jurta.org>
587 * search.c (Fword_search_regexp): New Lisp function created from
588 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
589 (Fword_search_backward, Fword_search_forward)
590 (Fword_search_backward_lax, Fword_search_forward_lax):
591 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
592 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
594 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
596 * fileio.c (Finsert_file_contents): Move after-change-function call
597 to before the "handled:" label, since all "goto handled" appear in
598 cases where the *-change-functions have already been properly called
599 (bug#10117).
601 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
603 * keyboard.c (interrupt_signal): Don't call kill-emacs when
604 waiting for input. (Bug#10169)
606 2011-11-30 Eli Zaretskii <eliz@gnu.org>
608 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
609 verifies glyph row's hash code--we have just reallocated the
610 glyphs, so their contents can be complete garbage. (Bug#10164)
612 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
614 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
616 2011-11-30 Eli Zaretskii <eliz@gnu.org>
618 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
619 attributes are tested _before_ calling verify_row_hash, to protect
620 against GCC re-ordering of the tests. (Bug#10164)
622 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
624 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
626 * xterm.c (handle_one_xevent): Only set async_visible and friends
627 if net_wm_state_hidden_seen is non-zero (Bug#10002)
628 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
629 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
631 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
633 Remove GCPRO-related macros that exist only to avoid shadowing locals.
634 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
635 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
636 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
637 All uses changed to use GCPRO1 etc.
638 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
639 Revert to old implementation (i.e., before 2011-03-11).
641 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
643 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
644 of scroll runs so as to avoid assigning disabled bogus rows and
645 unnecessary graphics copy operations.
647 2011-11-27 Eli Zaretskii <eliz@gnu.org>
649 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
650 (snprintf) [_MSC_VER]: Redirect to _snprintf.
651 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
652 (malloc, free, realloc, calloc): Redirect to e_* only when
653 compiling Emacs.
655 * lisp.h (GCTYPEBITS): Move before first use.
656 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
657 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
658 this macro definition.
660 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
661 _MSC_VER.
663 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
665 * gtkutil.c (xg_create_frame_widgets):
666 Call gtk_window_set_has_resize_grip (FALSE) if that function is
667 present with Gtk+ 2.0.
669 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
671 * fileio.c (Finsert_file_contents): Undo previous change; see
672 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
674 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
676 Rename locals to avoid shadowing.
677 * fileio.c (Finsert_file_contents):
678 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
679 * process.c (wait_reading_process_output):
680 Rename inner 'proc' to 'p' to avoid shadowing.
681 Indent for consistency with usual Emacs style.
683 2011-11-25 Eli Zaretskii <eliz@gnu.org>
685 * xdisp.c (redisplay_window): If cursor row is not fully visible
686 after recentering, and scroll-conservatively is set to a large
687 number, scroll window by a few more lines to make the cursor fully
688 visible and out of scroll-margin. (Bug#10105)
689 (start_display): Don't move to the next line if the display should
690 start at a newline that is part of a display vector or an overlay
691 string. (Bug#10119)
693 2011-11-24 Juri Linkov <juri@jurta.org>
695 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
696 after the `MagickPingImage' call. (Bug#10112)
698 2011-11-23 Chong Yidong <cyd@gnu.org>
700 * window.c (Fcoordinates_in_window_p): Accept only live windows.
702 2011-11-23 Martin Rudalics <rudalics@gmx.at>
704 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
705 making another buffer current. (Bug#10114)
707 2011-11-23 Glenn Morris <rgm@gnu.org>
709 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
711 2011-11-23 Chong Yidong <cyd@gnu.org>
713 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
714 using it (Bug#5984).
716 2011-11-22 Eli Zaretskii <eliz@gnu.org>
718 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
719 and header-lines, as they don't have one computed for them.
720 (Bug#10098)
722 * .gdbinit (prow): Make displayed values more self-explaining.
723 Add row's hash code.
725 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
727 * process.c (wait_reading_process_output): Fix asynchrounous
728 GnuTLS socket handling on some versions of the GnuTLS library.
729 (wait_reading_process_output): Add comment and URL.
731 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
733 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
735 2011-11-21 Chong Yidong <cyd@gnu.org>
737 * window.c (Fnext_window, Fprevious_window): Doc fix.
739 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
741 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
743 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
745 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
747 2011-11-20 Martin Rudalics <rudalics@gmx.at>
749 * window.c (Fset_window_combination_limit): Rename argument
750 STATUS to LIMIT.
751 (Vwindow_combination_limit): Remove "status" from doc-string.
753 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
755 * m/ibms390.h: Remove.
756 * m/ibms390x.h: Don't include "ibms390.h".
758 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
760 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
761 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
763 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
765 * casetab.c (Fset_case_table):
766 * charset.c (Fcharset_after): Fix typos.
768 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
770 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
771 Otherwise, valgrind does not work on some platforms.
772 Problem reported by Andreas Schwab in
773 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
774 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
775 is set, removing the need for VIRT_ADDRESS_VARIES.
776 (PURE_P): Use a more-efficient implementation that needs just one
777 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
778 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
779 to 4 (xorl, subq, cmpq, setbe).
780 * alloc.c (pure): Always extern now, since that's the
781 VIRT_ADDR_VARIES behavior.
782 (PURE_POINTER_P): Use a single comparison, not two, for
783 consistency with the new puresize.h.
784 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
785 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
786 Remove VIRT_ADDR_VARIES no longer needed.
788 2011-11-19 Eli Zaretskii <eliz@gnu.org>
790 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
791 (erase_phys_cursor, update_window_cursor, show_mouse_face)
792 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
793 behave as if the cursor position were at the window margin.
795 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
796 and the cursor position is out of bounds, behave as if the cursor
797 position were at the window margin. (Bug#10075)
799 2011-11-18 Chong Yidong <cyd@gnu.org>
801 * window.c (Fwindow_combination_limit): Make first argument
802 non-optional, since it is meaningless for live windows like the
803 selected window.
805 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
807 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
809 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
811 * intervals.c: Fix grafting over the whole buffer (bug#10071).
812 (graft_intervals_into_buffer): Simplify.
814 2011-11-18 Eli Zaretskii <eliz@gnu.org>
816 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
817 hash values of the two rows.
818 (copy_row_except_pointers): Preserve the used[] arrays and the
819 hash values of the two rows. (Bug#10035)
820 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
822 * xdisp.c (row_hash): New function, body extracted from
823 compute_line_metrics.
824 (compute_line_metrics): Call row_hash, instead of computing the
825 hash code inline.
827 * dispnew.c (verify_row_hash): Call row_hash for computing the
828 hash code of a row, instead of duplicating code from xdisp.c.
830 * dispextern.h (row_hash): Add prototype.
832 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
834 * frame.c (delete_frame): Don't delete the terminal when the last
835 X frame is closed if emacs is built with GTK toolkit.
837 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
839 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
841 2011-11-17 Martin Rudalics <rudalics@gmx.at>
843 * window.c (Vwindow_splits): Rename to
844 Vwindow_combination_resize. Suggested by Juri Linkov.
845 (Fsplit_window_internal): Use Vwindow_combination_resize instead
846 of Vwindow_splits.
848 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
850 * nsfns.m (Fns_font_name):
851 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
853 2011-11-16 Martin Rudalics <rudalics@gmx.at>
855 * window.h (window): Rename slot "nest" to "combination_limit".
856 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
857 (Fset_window_nest): Rename to Fset_window_combination_limit.
858 (Vwindow_nest): Rename to Vwindow_combination_limit.
859 (recombine_windows, make_parent_window, make_window)
860 (Fsplit_window_internal, saved_window)
861 (Fset_window_configuration, save_window_save): Rename all
862 occurrences of window_nest to window_combination_limit.
864 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
866 * image.c (imagemagick_load_image): Fix typo.
868 2011-11-14 Eli Zaretskii <eliz@gnu.org>
870 * xdisp.c (display_line): Move the call to
871 highlight_trailing_whitespace before the call to
872 compute_line_metrics, since the latter needs to see the final
873 faces of all the glyphs to compute ROW's hash value.
874 Fixes assertion violations in row_equal_p. (Bug#10035)
876 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
878 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
879 just return (bug#10044).
881 2011-11-12 Eli Zaretskii <eliz@gnu.org>
883 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
884 with user-defined heap size. Bump the default size of the temacs
885 heap to 27MB, to avoid memory warning when running temacs.
886 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
888 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
889 current_matrix and desired_matrix. (Bug#9990)
890 (verify_row_hash) [XASSERTS]: New function.
891 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
892 that the hash value of glyph rows is correct.
894 2011-11-12 Martin Rudalics <rudalics@gmx.at>
896 * window.h (window): Remove splits slot.
897 * window.c (Fwindow_splits, Fset_window_splits): Remove.
898 (Fdelete_other_windows_internal, make_parent_window)
899 (make_window, Fsplit_window_internal, Fdelete_window_internal)
900 (Fset_window_configuration, save_window_save): Don't deal with
901 split status of windows.
902 (saved_window): Remove splits slot.
903 (Vwindow_splits): Rewrite doc-string.
905 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
907 * xfns.c (unwind_create_frame):
908 * nsfns.m (unwind_create_frame):
909 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
910 Vframe_list (Bug#9999).
912 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
914 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
916 2011-11-11 Kenichi Handa <handa@m17n.org>
918 * callproc.c (Fcall_process): Set the member dst_multibyte of
919 process_coding.
921 2011-11-11 Johan Bockgård <bojohan@gnu.org>
923 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
924 avoid a crash (bug#9496).
926 2011-11-09 Chong Yidong <cyd@gnu.org>
928 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
929 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
931 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
933 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
935 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
937 Avoid some portability problems by eschewing 'extern inline' functions.
938 The trivial performance wins aren't worth the portability hassles; see
939 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
940 et seq.
941 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
942 (window_box_width, window_box_left, window_box_left_offset)
943 (window_box_right, window_box_right_offset): Undo previous change,
944 by removing the "extern"s.
945 * intervals.c (adjust_intervals_for_insertion)
946 (adjust_intervals_for_deletion): Undo previous change,
947 making these static again.
948 (offset_intervals, temp_set_point_both, temp_set_point)
949 (copy_intervals_to_string): No longer inline.
950 * xdisp.c (window_text_bottom_y, window_box_width)
951 (window_box_height, window_box_left_offset)
952 (window_box_right_offset, window_box_left, window_box_right)
953 (window_box): No longer inline.
955 2011-11-08 Chong Yidong <cyd@gnu.org>
957 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
958 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
959 Signal an error if not a live window.
960 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
961 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
963 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
965 * lisp.h (syms_of_abbrev): Remove declaration.
966 Reported by CHENG Gao <chenggao@royau.me>.
968 2011-11-07 Eli Zaretskii <eliz@gnu.org>
970 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
971 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
972 of temacs in GUI mode.
974 2011-11-07 Martin Rudalics <rudalics@gmx.at>
976 * window.h: Declare delete_all_child_windows instead of
977 delete_all_subwindows.
978 * window.c (Fwindow_nest, Fset_window_nest)
979 (Fset_window_new_total, Fset_window_new_normal)
980 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
981 (delete_all_subwindows): Rename to delete_all_child_windows.
982 (Fdelete_other_windows_internal, Fset_window_configuration):
983 Call delete_all_child_windows instead of delete_all_subwindows.
984 * frame.c (delete_frame): Call delete_all_child_windows instead
985 of delete_all_subwindows.
987 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
989 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
990 This is also needed for porting to any host where GC_MARK_STACK is
991 not GC_MAKE_GCPROS_NOOPS.
992 (which_symbols): Use it.
994 2011-11-07 Kenichi Handa <handa@m17n.org>
996 * coding.c (coding_set_destination): Check coding->src_pos only
997 when coding->src_object is a buffer (bug#9910).
999 * process.c (send_process): Set the member src_multibyte of coding
1000 to 0 (bug#9911) when sending a unibyte text.
1002 * callproc.c (Fcall_process): Set the member src_multibyte of
1003 process_coding to 0 (bug#9912).
1005 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1007 * xmenu.c (cleanup_widget_value_tree): New function.
1008 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1009 calling free_menubar_widget_value_tree directly (Bug#9830).
1011 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1013 Fix some portability problems with 'inline'.
1014 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1015 (window_box_width, window_box_left, window_box_left_offset)
1016 (window_box_right, window_box_right_offset): Declare extern.
1017 Otherwise, these inline functions do not conform to C99 and
1018 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1019 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1020 * intervals.c (adjust_intervals_for_insertion)
1021 (adjust_intervals_for_deletion): Now extern, because otherwise the
1022 extern inline functions 'offset_intervals' couldn't refer to it.
1023 (static_offset_intervals): Remove.
1024 (offset_intervals): Rewrite using the old contents of
1025 static_offset_intervals. The old version didn't conform to C99
1026 because an extern inline function contained a reference to an
1027 identifier with static linkage.
1029 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1031 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1032 GC.
1034 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1036 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1037 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1038 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1039 return Qleft_to_right.
1041 2011-11-06 Chong Yidong <cyd@gnu.org>
1043 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1044 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1045 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1046 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1047 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1048 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1049 (Fwindow_vscroll): Doc fix.
1050 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1051 argument, since it makes no sense to pass a live window and for
1052 consistency with window-child.
1054 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1056 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1057 support MSVC.
1059 2011-11-05 Jason Rumney <jasonr@gnu.org>
1061 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1062 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1063 fonts (Bug#6029).
1064 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1065 bitwise arithmetic preventing use of unicode-sip and non-truetype
1066 opentype fonts.
1068 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1070 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1071 "emacs"-only part.
1073 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1074 initialization code to keep similarity to xfns.c after changes
1075 from 2011-11-05.
1077 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1079 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1080 (unwind_create_frame): New function (Bug#9943).
1081 (Fx_create_frame): Restructure code to be more similar to the one in
1082 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1083 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1084 Move terminal->reference_count++ just before making the frame official
1085 (Bug#9943).
1087 * nsterm.m (x_free_frame_resources): New function.
1088 (x_destroy_window): Move code to x_free_frame_resources.
1090 * xfns.c (unwind_create_frame): Fix comment.
1091 (Fx_create_frame, x_create_tip_frame):
1092 Move terminal->reference_count++ just before making the frame
1093 official. Move initialization of image_cache_refcount and
1094 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1096 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1098 Support MSVC build with newer versions of Visual Studio.
1099 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1100 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1101 nt/gmake.defs.
1103 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1104 which are not supported by MSVC.
1105 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1106 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1107 bitfields.
1108 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1109 types in bitfields.
1110 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1112 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1114 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1116 Support MSVC build with newer versions of Visual Studio.
1117 * w32.c: Don't include w32api.h for MSVC.
1118 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1120 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1121 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1122 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1123 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1124 e_* cousins.
1125 (alloca) [_MSC_VER]: Define to _alloca.
1127 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1129 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1131 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (note_mouse_highlight): If either of
1134 previous/next-single-property-change returns nil, treat that as
1135 the beginning or the end of the buffer. (Bug#9955)
1137 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1139 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1140 label is not null (Bug#9951).
1141 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1142 may be NULL.
1144 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1146 * window.c (Fwindow_body_size): Mention in the doc string that the
1147 return value is in frame's canonical units. (Bug#9949)
1149 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1151 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1153 * w32fns.c (unwind_create_frame): If needed, free the glyph
1154 matrices of the partially constructed frame. (Bug#9943)
1155 * xfns.c (unwind_create_frame): Likewise.
1157 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1159 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1160 Don't stop backward scan on the continuation glyph, even though
1161 its CHARPOS is positive.
1162 (mouse_face_from_buffer_pos, note_mouse_highlight):
1163 Rename cover_string to disp_string.
1165 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1167 * window.c (temp_output_buffer_show): Don't use
1168 Vtemp_buffer_show_specifiers.
1169 (Vtemp_buffer_show_specifiers): Remove unused variable.
1171 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1173 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1174 past the beginning of the current glyph matrix.
1176 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1178 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1179 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1180 HAVE_GTK3 (Bug#9869).
1182 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1183 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1185 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1187 * xterm.c: Declare x_handle_net_wm_state to return int.
1188 (handle_one_xevent): Check if we are iconified but don't have
1189 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1190 (get_current_wm_state): Return non-zero if not hidden,
1191 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1192 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1193 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1194 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1196 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1198 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1199 so that this new function doesn't get optimized away by a
1200 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1202 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1204 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1206 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1208 Fix the `xbytecode' command.
1209 * .gdbinit (xprintbytestr): New command.
1210 (xwhichsymbols): Rename from `which'; all callers changed.
1211 (xbytecode): Print the byte-code string as well.
1213 2011-10-29 Kim Storm <storm@cua.dk>
1215 * alloc.c (which_symbols): New function.
1217 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1219 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1220 line. (Bug#9903)
1222 2011-10-29 Glenn Morris <rgm@gnu.org>
1224 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1225 Not clear what it was for, and it causes various bugs. (Bug#9839)
1227 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1229 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1230 possible random value that matches one of those tested as
1231 condition to clear the mouse face.
1233 2011-10-28 Chong Yidong <cyd@gnu.org>
1235 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1237 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1239 * window.c (make_window): Initialize phys_cursor_on_p.
1241 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1243 * lisp.h (struct Lisp_Symbol): Update comments.
1245 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1247 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1249 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1251 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1252 <oslsachem@gmail.com> for helping to debug this.
1254 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1255 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1256 (g_b_init_get_glyph_outline_w): New static variables.
1257 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1258 (GetGlyphOutlineW_Proc): New typedefs.
1259 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1260 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1261 New functions.
1262 (w32font_open_internal, compute_metrics):
1263 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1264 instead of calling the "wide" APIs directly.
1266 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1268 * w32.h (syms_of_w32font): Add prototype.
1270 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1272 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1273 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1274 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1275 (Fmove_to_window_line): Doc fix.
1277 2011-10-27 Chong Yidong <cyd@gnu.org>
1279 * process.c (make_process): Set gnutls_state to NULL.
1281 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1282 non-NULL, regardless of GNUTLS_INITSTAGE.
1283 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1284 an error. Set process slots as soon as we allocate them.
1286 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1288 2011-10-27 Chong Yidong <cyd@gnu.org>
1290 * gnutls.c (emacs_gnutls_deinit): New function.
1291 Deallocate credentials structures as well as calling gnutls_deinit.
1292 (Fgnutls_deinit, Fgnutls_boot): Use it.
1294 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1295 (deactivate_process): Call emacs_gnutls_deinit.
1297 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1299 * image.c (x_create_x_image_and_pixmap):
1300 * w32.c (sys_rename, w32_delayed_load):
1301 * w32font.c (fill_in_logfont):
1302 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1304 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1306 * w32fns.c (w32_default_color_map): New function,
1307 extracted from Fw32_default_color_map.
1308 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1310 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1312 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1314 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1316 * keyboard.c (test_undefined): New function (bug#9751).
1317 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1319 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1321 * sysdep.c (init_sys_modes): Fix the check for the controlling
1322 terminal (Bug#6649).
1324 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1326 * dispextern.h (struct bidi_it): New member next_en_type.
1328 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1329 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1330 current character, check also for next_en_type being WEAK_EN.
1331 (bidi_resolve_weak): Don't enter the expensive loop if the current
1332 position is before next_en_pos. Record the bidi type of the first
1333 non-ET, non-BN character we find, in addition to its position.
1334 (bidi_level_of_next_char): Invalidate next_en_type when
1335 next_en_pos is over-stepped.
1337 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1339 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1340 * editfns.c: Rewrite current-time-zone so that it invokes
1341 the equivalent of (format-time-string "%Z") to get the time zone name.
1342 This fixes a bug when the time zone name contains characters that
1343 need converting from the system time locale to Emacs internal format.
1344 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1345 that patch fixed format-time-string to do the conversion, but
1346 I forgot to fix current-time-zone.
1347 (format_time_string): New function, containing most of
1348 what Fformat_time_string used to contain.
1349 (Fformat_time_string): Rewrite in terms of format_time_string.
1350 This doesn't change this function's behavior.
1351 (current-time-zone): Rewrite to use format_time_string.
1352 This fixes the bug reported by Michael Schierl in
1353 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1354 Jason Rumney's 2007-06-07 change worked around this bug, but
1355 didn't fix it.
1356 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1358 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1360 * xdisp.c (start_display): If the character at POS is displayed
1361 via a display vector, reset IT->current.dpvec_index to zero.
1362 (try_window_reusing_current_matrix): If a line ends in a display
1363 vector or the next line starts in a display vector, continue
1364 redrawing the window even though the character position of
1365 start_row was reached.
1366 (Bug#9771, part 2)
1368 2011-10-18 Chong Yidong <cyd@gnu.org>
1370 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1371 with nobreak-char-display too.
1373 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1375 Fix part 3 of bug#9771.
1376 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1377 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1378 non-neutral characters if the current character is a paragraph
1379 separator (a.k.a. Newline). This avoids running the same
1380 expensive loop twice, once when we consume the preceding newline
1381 and the other time when the line actually needs to be displayed.
1382 Avoid the loop when we see neutrals on the base embedding level
1383 following a character whose directionality is the same as the
1384 paragraph's. This avoids running the expensive loop when a line
1385 ends in a long sequence of neutrals, like control characters.
1386 Add assertion against STRONG_AL type. Slightly rearrange code
1387 that determines the type of a neutral given the first non-neutral
1388 that follows it.
1389 (bidi_level_of_next_char): Set next_en_pos to zero when
1390 invalidating its info.
1392 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1394 * xdisp.c (push_display_prop): Determine whether to record string
1395 or buffer position by IT->string, not by IT->method. Allow
1396 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1397 (move_it_vertically_backward): Don't look for character position
1398 immediately after the newline when in a continuation line.
1399 (Bug#9771, part 1)
1401 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1403 * window.c (coordinates_in_window): Rewrite and delabelize
1404 vertical border check. (Bug#5357) (Bug#9618)
1406 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1408 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1409 errors in XSetWindowBorder (bug#9310).
1411 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1413 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1414 avoid crash when xmalloc overrun checking is enabled.
1416 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1418 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1419 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1420 cursor motion with <left> and <right> arrow keys.
1422 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1423 some callers set that themselves.
1425 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1428 display string and the previous row comes from the same string and
1429 is empty. (Bug#9739) (Bug#9738)
1431 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1433 * doc.c (get_doc_string): Encode file name (bug#9735).
1435 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1437 * bidi.c (bidi_level_of_next_char):
1438 * xdisp.c (get_visually_first_element): Remove old incorrect
1439 comments regarding the Unicode Line Separator character.
1441 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1443 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1445 * alloc.c (Fgc_status): Do not access beyond zombies array
1446 boundary if nzombies > MAX_ZOMBIES.
1447 * alloc.c (dump_zombies): Add missing format specifier.
1449 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1451 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1452 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1454 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1455 Some packages use them to denote characters with modifiers.
1457 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1459 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1460 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1461 matching a pp-number. Rename parameter var to var1.
1463 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1465 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1467 2011-10-08 Glenn Morris <rgm@gnu.org>
1469 * callint.c (Fcall_interactively): Give a more explicit error for the
1470 'c' case with a non-character input. (Bug#8479)
1472 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1474 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1475 lines.
1476 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1477 lines that are hscrolled on the left.
1479 * dispnew.c (buffer_posn_from_coords): Account for a possible
1480 presence of header-line. (Bug#4426)
1482 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1484 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1485 Don't advertise functionality which we discourage or doesn't work.
1487 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1489 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1490 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1491 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1492 this makes Emacs dump core during garbage collection on rare
1493 occasions. sizeof is obviously inferior to offsetof here, so
1494 stick with offsetof.
1495 (GC_POINTER_ALIGNMENT): New macro.
1496 (mark_memory): Omit 3rd (offset) arg; caller changed.
1497 Don't assume EMACS_INT alignment is the same as pointer alignment.
1499 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1501 * keyboard.c (read_key_sequence_remapped): New var.
1502 (read_key_sequence): Compute remapping in the right buffer.
1503 (command_loop_1): Use read_key_sequence's remapping directly.
1505 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1507 * dired.c (file_name_completion): Don't expand file name.
1508 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1509 before checking file name handler.
1511 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1512 they've been requested explicitly (bug#9591).
1514 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1516 * keymap.c (Fsingle_key_description): Use make_specified_string
1517 instead of build_string to build string from push_key_description.
1518 (Bug#5193)
1520 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1522 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1523 This fixes a Y2038 bug on 64-bit hosts.
1524 * buffer.c (reset_buffer):
1525 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1526 (Fclear_buffer_auto_save_failure):
1527 Use 0, not -1, to represent an unset failure time, since time_t
1528 might not be signed.
1530 Remove dependency on glibc malloc internals.
1531 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1532 Move back here from lisp.h, but with their new implementations.
1533 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1534 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1535 * charset.c (charset_table_init): New static var.
1536 (syms_of_charset): Use it instead of xmalloc. This removes a
1537 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1538 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1539 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1540 Move back to alloc.c.
1541 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1542 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1544 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1546 * nsterm.m (windowDidResize): Call x_set_window_size only when
1547 ns_in_resize is true. Otherwise set pixelwidth/height and
1548 call change_frame_size (Bug#9628).
1550 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1552 Port --enable-checking=all to Fedora 14 x86-64.
1553 * charset.c (syms_of_charset): Also account for glibc malloc's
1554 internal overhead when calculating the initial malloc maximum.
1556 Port --enable-checking=all to Fedora 14 x86.
1557 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1558 Move to lisp.h.
1559 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1560 (overrun_check_realloc, overrun_check_free):
1561 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1562 That way, xmalloc returns a properly-aligned pointer even if
1563 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1564 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1565 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1566 into account when calculating the initial malloc maximum.
1567 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1568 Move here from alloc.c, so that charset.c can use it too.
1569 Properly align; the old code wasn't right for common 32-bit hosts
1570 when configured with --enable-checking=all.
1571 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1572 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1574 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1576 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1577 use EDOM.
1579 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (compute_display_string_end): If there's no display
1582 string at CHARPOS, return -1.
1584 * bidi.c (bidi_fetch_char): When compute_display_string_end
1585 returns a negative value, treat the character as a normal
1586 character not covered by a display string. (Bug#9624)
1588 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1590 * lread.c (Fread_from_string): Fix typo in docstring.
1592 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1594 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1595 newline, reseat the iterator instead of bidi-iterating there one
1596 character at a time. (Bug#9610)
1597 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1598 TO_CHARPOS if the bidi iterator is at base embedding level.
1600 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1602 * lread.c (readevalloop): Use correct code for NBSP.
1603 (read1): Likewise. (Bug#9608)
1605 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1607 * dbusbind.c (Fdbus_register_signal): When service is not
1608 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1610 2011-09-25 Glenn Morris <rgm@gnu.org>
1612 * buffer.c (truncate-lines): Doc fix.
1614 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1616 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1617 (Fset_window_next_buffers): Doc fix.
1619 2011-09-24 Glenn Morris <rgm@gnu.org>
1621 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1623 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1625 Fix minor problems found by static checking.
1626 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1627 * indent.c (Fvertical_motion): Fix == vs = typo.
1629 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1631 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1632 Default value is now t. Doc fix.
1634 * indent.c (Fvertical_motion): Compute and apply the overshoot
1635 logic when moving up, not only when moving down. Fix the
1636 confusing name and values of the it_overshoot_expected variable;
1637 logic changes accordingly. (Bug#9254) (Bug#9549)
1639 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1640 CHARPOS is covered by a display string which includes newlines.
1641 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1642 is covered by a display string with embedded newlines.
1644 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1646 * dbusbind.c (Fdbus_register_signal): Add match rule to
1647 Vdbus_registered_objects_table. (Bug#9581)
1648 (Fdbus_register_method, Vdbus_registered_objects_table):
1649 Fix docstring.
1651 2011-09-24 Jim Meyering <meyering@redhat.com>
1653 do not ignore write error for any output size
1654 The previous change was incomplete.
1655 While it makes emacs --batch detect the vast majority of stdout
1656 write failures, errors were still ignored whenever the output size is
1657 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1658 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1659 && echo FAIL: ignored write error
1660 FAIL: ignored write error
1661 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1662 && echo FAIL: ignored write error
1663 FAIL: ignored write error
1664 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1666 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1668 * emacs.c (Fkill_emacs): In noninteractive mode exit
1669 non-successfully if a write error occurred on stdout. (Bug#9574)
1671 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1673 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1674 the xassert test.
1676 * dispextern.h (struct it): Update the comment documenting what
1677 can it->OBJECT be.
1679 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1681 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1682 a display string, extend search for cursor position to end of row.
1683 (find_row_edges): If the row ends in a newline from a display
1684 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1685 Handle the case of a display string with multiple newlines.
1686 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1687 non-empty line. Fixes confusing cursor motion with arrow keys at
1688 the beginning of a line that starts with whitespace.
1690 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1692 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1693 (bug#9493).
1695 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1697 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1698 boolean (Bug#9154).
1700 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1702 * xdisp.c (display_line): Record maximum and minimum buffer
1703 positions even if no glyphs were produced (e.g., by a zero-width
1704 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1705 buffer positions that will be removed from the glyph row because
1706 they don't fit.
1707 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1708 column is beyond frame width: don't subtract 1 "pixel" when
1709 computing width of the stretch.
1710 (reseat_at_next_visible_line_start): Undo the change made on
1711 2011-09-17 that saved paragraph information and restored it after
1712 the call to `reseat'. (Bug#9545)
1714 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1716 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1717 and turn window cursor on if cleared (Bug#9415).
1719 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1721 * search.c (boyer_moore): Take unibyte characters from pattern
1722 literally. (Bug#9458)
1724 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1726 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1728 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1730 Fix minor problem found by static checking.
1731 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1732 initialized, to pacify gcc -Wuninitialized.
1734 * fileio.c: Report proper errno when syscall falls.
1735 (Finsert_file_contents): Save and restore errno,
1736 so that report_file_error outputs the correct diagnostic.
1737 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1739 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1741 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1743 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1745 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1746 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1748 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1750 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1751 about the current paragraph and restore it after the call to reseat.
1753 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1754 (bidi_find_paragraph_start): Search back for paragraph beginning
1755 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1756 (bidi_move_to_visually_next): Only trigger paragraph-related
1757 computations when the last character is a newline or at EOB, not
1758 just any NEUTRAL_B. (Bug#9470)
1760 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1761 truncated lines if point is covered by a display string. (Bug#9524)
1763 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1765 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1766 (cons_to_x_long): New function.
1767 (lisp_data_to_selection_data): Use it. Correct the test for
1768 short-versus-long data; it was negated. Break out of vector
1769 loop, for efficiency, when a long datum is discovered.
1771 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1775 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1777 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1778 GCC PR/17406) by declaring this function with external scope.
1780 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1782 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1783 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1785 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1787 * editfns.c (Fformat): Correctly handle text properties on "%%".
1789 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1791 * xterm.c (x_draw_composite_glyph_string_foreground):
1792 * w32term.c (x_draw_composite_glyph_string_foreground):
1793 * term.c (encode_terminal_code):
1794 * composite.c (composition_update_it, get_composition_id):
1795 * xdisp.c (get_next_display_element)
1796 (fill_composite_glyph_string): Add comments about special meaning
1797 of TAB characters in a composition.
1799 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1801 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1802 This occurs when processing a multibyte format.
1803 Problem reported by Wolfgang Jenker.
1805 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1807 * xdisp.c (try_cursor_movement): Only check for exact match if
1808 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1810 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1812 Remove unused external symbols.
1813 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1814 * xdisp.c (calc_pixel_width_or_height): Now static.
1815 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1816 * indent.c (check_display_width):
1817 * w32term.c: Fix comment to match code.
1818 * xterm.c, xterm.h (x_catching_errors): Remove.
1820 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1822 * xselect.c: Use signed conversions more consistently (Bug#9498).
1823 (selection_data_to_lisp_data): Assume incoming selection data are
1824 signed integers, not unsigned. This is to be consistent with
1825 outgoing selection data, which was modified to use signed integers
1826 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1827 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1828 expects long, not unsigned long.
1830 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1833 computation of loop end. Reported by Johan Bockgård
1834 <bojohan@gnu.org>.
1836 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1838 * frame.c (Fother_visible_frames_p): Function deleted.
1840 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1842 * indent.c (compute_motion): Process display vector front to back
1843 rather than the other way around. (Bug#2496)
1845 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1847 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1849 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1851 * minibuf.c (Fread_from_minibuffer): Doc fix.
1853 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1855 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1856 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1858 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1860 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1861 value for non-existent files.
1863 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1865 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1866 set its "size" to -1. This will set the modtime_size field of
1867 the corresponding buffer to -1, which is what
1868 verify-visited-file-modtime expects for files that do not exist.
1869 (Bug#9139)
1871 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1873 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1874 here ...
1875 * lisp.h: ... from here. push_key_description is no longer
1876 defined in keyboard.c, so its declaration should not be in
1877 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1878 logically belongs with push_key_description.
1880 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1882 * buffer.h: Include <sys/types.h> instead of <time.h>.
1883 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1884 Problem reported by Herbert J. Skuhra.
1886 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1888 * xml.c (parse_region): Make the parsing work for
1889 non-comment-starting XML files again (bug#9144).
1891 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1893 * image.c (gif_load): Fix calculation of bottom and right corner.
1894 (Bug#9468)
1896 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1898 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1899 redisplay in small windows.
1901 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1903 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1905 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1907 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1908 Operate on live windows only.
1910 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1912 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1914 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1916 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1917 only under bidi iteration.
1919 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1921 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1923 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1925 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1926 Without this fix, the command to link temacs failed due to an
1927 undefined symbol __builtin_isnan. This is because
1928 /usr/include/iso/math_c99.h #defines isnan(x) to
1929 __builtin_isnan(x), but the bundled gcc, which identifies itself
1930 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1931 a __builtin_isnan.
1932 * floatfns.c (isnan): #undef, and then #define to a clone of
1933 what's in data.c.
1934 (Fisnan): Always define, since it's always available now.
1935 (syms_of_floatfns): Always define isnan at the Lisp level.
1937 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1939 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1941 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1943 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1944 The previous code assumed that file offsets (off_t values) fit in
1945 EMACS_INT variables, which is not true on typical 32-bit hosts.
1946 The code messed up by falsely reporting buffer overflow in cases
1947 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1948 when "big" contains more than 2**29 bytes, even though this
1949 inserts just one byte and does not overflow the buffer.
1950 (Finsert_file_contents): Store file offsets as off_t
1951 values, not as EMACS_INT values. Check for overflow when
1952 converting between EMACS_INT and off_t. When checking for
1953 buffer overflow or for overlap, take the offsets into account.
1954 Don't use EMACS_INT for small values where int suffices.
1955 When checking for overlap, fix a typo: ZV was used where
1956 ZV_BYTE was intended.
1957 (Fwrite_region): Don't assume off_t fits into 'long'.
1958 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1960 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1962 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1964 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1966 sprintf-related integer and memory overflow issues (Bug#9412).
1968 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1969 (esprintf, exprintf, evxprintf): New functions.
1970 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1971 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1972 (modify_event_symbol): Do not assume that the length of
1973 name_alist_or_stem is safe to alloca and fits in int.
1974 (Fexecute_extended_command): Likewise for function name and binding.
1975 (Frecursion_depth): Wrap around reliably on integer overflow.
1976 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1977 since some callers pass EMACS_INT values.
1978 (Fsingle_key_description): Don't crash if symbol name contains more
1979 than MAX_ALLOCA bytes.
1980 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1981 (get_minibuffer): Arg is now EMACS_INT, not int.
1982 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1983 (esprintf, exprintf, evxprintf): New decls.
1984 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1986 * dbusbind.c (signature_cat): New function.
1987 (xd_signature, Fdbus_register_signal):
1988 Do not overrun buffer; instead, report string overflow.
1990 * dispnew.c (add_window_display_history): Don't overrun buffer.
1991 Truncate instead; this is OK since it's just a log.
1993 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1994 even if the time zone offset is outlandishly large.
1995 Don't mishandle offset == INT_MIN.
1997 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1998 when creating daemon; the previous buffer-overflow check was incorrect.
2000 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2001 which has the guts of the old verror function.
2003 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2004 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2006 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2007 (font_unparse_xlfd): Don't blindly alloca long strings.
2008 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2009 fits in int, when using sprintf. Use single snprintf to count
2010 length of string rather than counting it via multiple sprintfs;
2011 that's simpler and more reliable.
2012 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2013 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2014 sprintf, in case result does not fit in int.
2016 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2017 (fontset_from_font): Print it.
2019 * frame.c (tty_frame_count): Now printmax_t, not int.
2020 (make_terminal_frame, set_term_frame_name): Print it.
2021 (x_report_frame_params): In X, window IDs are unsigned long,
2022 not signed long, so print them as unsigned.
2023 (validate_x_resource_name): Check for implausibly long names,
2024 and don't assume name length fits in 'int'.
2025 (x_get_resource_string): Don't blindly alloca invocation name;
2026 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2027 not fit in int.
2029 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2030 (xg_check_special_colors, xg_set_geometry):
2031 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2033 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2034 Use esprintf, not sprintf, in case result does not fit in int.
2036 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2037 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2038 it as a large positive number.
2039 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2040 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2042 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2043 in case result does not fit in int.
2045 * print.c (float_to_string): Detect width overflow more reliably.
2046 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2047 buffer overrun. Don't assume list length fits in 'int'. Treat
2048 print length of 0 as 0, not as infinity; to be consistent with other
2049 uses of print length in this function. Don't overflow print length
2050 index. Don't assume hash table size fits in 'long', or that
2051 vectorlike size fits in 'unsigned long'.
2053 * process.c (make_process): Use printmax_t, not int, to format
2054 process-name gensyms.
2056 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2058 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2059 to avoid potential buffer overrun.
2061 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2062 if X resource line is longer than 512 bytes.
2064 * xfns.c (x_window): Make sprintf buffer a bit bigger
2065 to avoid potential buffer overrun.
2067 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2069 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2071 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2073 Integer overflow fixes for scrolling, etc.
2074 Without these, Emacs silently mishandles large integers sometimes.
2075 For example, "C-u 4294967297 M-x recenter" was treated as if
2076 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2078 * xdisp.c (try_window_id): Check Emacs fixnum range before
2079 converting to 'int'.
2081 * window.c (window_scroll_line_based, Frecenter):
2082 Check that an Emacs fixnum is in range before assigning it to 'int'.
2083 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2084 values converted from Emacs fixnums.
2085 (Frecenter): Don't wrap around a line count if it is out of 'int'
2086 range; instead, treat it as an extreme value.
2087 (Fset_window_configuration, compare_window_configurations):
2088 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2090 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2091 that can exceed INT_MAX. Check that EMACS_INT value is in range
2092 before assigning it to the (possibly-narrower) index.
2093 (match_limit): Don't assume that a fixnum can fit in 'int'.
2095 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2096 exceed INT_MAX.
2098 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2099 (Fvertical_motion): Don't wrap around LINES values that don't fit
2100 in 'int'. Instead, treat them as extreme values. This is good
2101 enough for windows, which can't have more than INT_MAX lines anyway.
2103 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2105 * Require libxml/parser.h to avoid compilation warning.
2107 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2109 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2110 since this reportedly can destroy thread storage.
2112 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2114 * syntax.c (find_defun_start): Update all cache variables if
2115 exiting early (Bug#9401).
2117 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2119 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2121 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2122 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2123 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2125 * term.c (tty_append_glyph): New function.
2126 (produce_stretch_glyph): Static function and its prototype deleted.
2128 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2129 Add prototypes.
2131 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2133 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2134 when checking :margin (Bug#9390).
2135 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2136 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2137 so that the name doesn't mislead. All uses changed.
2139 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2141 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2142 set_tty_hooks.
2144 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (move_it_to): Don't bail out early when reaching
2147 position beyond to_charpos, if we are scanning backwards.
2148 (move_it_vertically_backward): When DY == 0, make sure we get to
2149 the first character in the line after the newline.
2151 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2153 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2154 (ccl_driver): Do not generate an out-of-range pointer.
2155 (Fccl_execute_on_string): Remove unnecessary check for
2156 integer overflow, noted by Stefan Monnier in
2157 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2158 Remove a FIXME that didn't need fixing.
2159 Simplify the newly-introduced buffer reallocation code.
2161 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2163 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2165 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2167 Integer and memory overflow issues (Bug#9196).
2169 * doc.c (get_doc_string): Rework so that
2170 get_doc_string_buffer_size is the actual buffer size, rather than
2171 being 1 less than the actual buffer size; this makes xpalloc more
2172 convenient.
2174 * image.c (x_allocate_bitmap_record, cache_image):
2175 * xselect.c (Fx_register_dnd_atom):
2176 Simplify previous changes by using xpalloc.
2178 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2179 since either will do and ptrdiff_t is convenient with xpalloc.
2181 * charset.c (charset_table_size)
2182 (struct charset_sort_data.priority): Now ptrdiff_t.
2183 (charset_compare): Don't overflow if priorities differ greatly.
2184 (Fsort_charsets): Don't assume list length fits in int.
2185 Check for size-calculation overflow when allocating sort data.
2186 (syms_of_charset): Allocate an initial charset table that is
2187 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2189 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2191 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2192 The actual value is always <= INT_MAX, and leaving it unsigned made
2193 overflow checking harder.
2195 * dispextern.h (struct glyph_matrix.rows_allocated)
2196 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2197 with xpalloc. The values are still always <= INT_MAX.
2199 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2201 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2202 (SAFE_NALLOCA): New macro.
2204 * region-cache.c (struct boundary.pos, find_cache_boundary)
2205 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2206 (set_cache_region, invalidate_region_cache)
2207 (revalidate_region_cache, know_region_cache, region_cache_forward)
2208 (region_cache_backward, pp_cache):
2209 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2210 so that ptrdiff_t * can be passed to xpalloc.
2211 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2212 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2213 (pp_cache): Don't assume cache_len fits in int.
2214 * region-cache.h: Adjust extern decls to match.
2216 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2217 EMACS_INT, since either will do, for xpalloc.
2219 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2220 (xnmalloc, xnrealloc, xpalloc): New functions.
2222 * bidi.c (bidi_shelve_header_size): New constant.
2223 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2224 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2226 * bidi.c (bidi_cache_shrink):
2227 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2228 (overlay_strings):
2229 Don't update size of array until after memory allocation succeeds,
2230 because xmalloc/xrealloc may not return.
2231 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2232 now that we have proper integer overflow checking.
2233 (record_overlay_string, overlay_strings): Catch overflows when
2234 calculating size of overlay_str_buf.
2236 * callproc.c (Fcall_process): Check for size overflow when
2237 calculating size of args2.
2238 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2239 Normally we prefer signed values, but sticking with ptrdiff_t would
2240 require adding more-complicated checks.
2242 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2243 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2244 Redo buffer-overflow calculations to avoid integer overflow.
2245 Add a FIXME comment where memory seems to be over-allocated.
2247 * character.c (Fstring): Check for size-calculation overflow.
2249 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2250 unnecessary integer overflow. Check for size overflow.
2251 (encode_coding_object): Don't update size until xmalloc succeeds.
2253 * composite.c (get_composition_id): Check for overflow in glyph
2254 length calculations.
2256 Integer and memory overflow fixes for display code.
2257 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2258 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2259 (scrolling_window): Check for overflow in size calculations.
2260 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2261 Don't assume glyph table len fits in int.
2262 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2263 (row_table_size): Now ptrdiff_t, not int.
2264 (scrolling_window): Avoid overflow in size calculations.
2265 Don't update size until allocation succeeds.
2266 * fns.c (concat): Check for overflow in size calculations.
2267 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2268 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2269 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2271 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2272 (get_doc_string): Check for size calculation overflow.
2273 Don't update size until allocation succeeds.
2274 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2275 EMACS_INT, where ptrdiff_t will do.
2276 (Fsubstitute_command_keys): Check for string overflow.
2278 * editfns.c (set_time_zone_rule): Don't assume environment length
2279 fits in int.
2280 (message_length): Now ptrdiff_t, not int.
2281 (Fmessage_box): Don't update size until allocation succeeds.
2282 Don't assume message length fits in int.
2283 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2285 * emacs.c (main): Do not reallocate argv, since there is a null at
2286 the end that can be overwritten, and this way there's no need to
2287 worry about size-calculation overflow.
2288 (sort_args): Check for size-calculation overflow.
2290 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2291 alloc succeeds.
2292 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2294 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2295 (x_set_scroll_bar_width, x_figure_window_size):
2296 Check for integer overflow.
2297 (x_set_alpha): Do not assume XINT fits in int.
2299 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2300 This is for the members text_lines, text_cols, total_lines, total_cols,
2301 where the system imposes an 'int' limit.
2303 * fringe.c (Fdefine_fringe_bitmap):
2304 Don't update size until alloc works.
2306 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2307 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2309 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2310 Check for size-calculation overflow.
2311 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2312 do, as we prefer signed integers.
2313 (id_to_widget.max_size, id_to_widget.used)
2314 (xg_store_widget_in_map, xg_remove_widget_from_map)
2315 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2316 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2317 Use and return ptrdiff_t, not int.
2318 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2319 * gtkutil.h: Change prototypes to match the above.
2321 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2322 are duplicate now that they've been promoted to lisp.h.
2323 (x_allocate_bitmap_record, x_alloc_image_color)
2324 (make_image_cache, cache_image, xpm_load):
2325 Don't update size until alloc is done.
2326 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2327 (x_detect_edges):
2328 Check for size calculation overflow.
2329 (ct_colors_allocated_max): New constant.
2330 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2331 overflow.
2333 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2334 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2335 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2336 Use ptrdiff_t, not int, to count maps.
2337 (read_char_minibuf_menu_prompt): Check for overflow in size
2338 calculations. Don't update size until allocation succeeds.
2339 Redo calculations to avoid overflow.
2340 * keyboard.h: Change prototypes to match the above.
2342 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2343 to count maps.
2344 (current_minor_maps): Check for size calculation overflow.
2345 * keymap.h: Change prototypes to match the above.
2347 * lread.c (read1, init_obarray): Don't update size until alloc done.
2349 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2350 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2352 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2353 Now ptrdiff_t, not int.
2354 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2355 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2357 * process.c (Fnetwork_interface_list): Check for overflow
2358 in size calculation.
2360 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2362 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2363 overflow. Don't bother calling xmalloc when xrealloc will do.
2365 * search.c (Freplace_match): Check for size calculation overflow.
2366 (Fset_match_data): Don't assume list lengths fit in 'int'.
2368 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2369 for command line length. Do not attempt to address one before the
2370 beginning of an array, as that's not portable.
2372 * term.c (max_frame_lines): Remove; unused.
2373 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2374 not int.
2375 (encode_terminal_code, calculate_costs): Check for size
2376 calculation overflow.
2377 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2378 table lengths and related sizes. Don't update size until alloc
2379 done. Redo calculations to avoid overflow.
2380 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2382 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2383 subtracting pointers.
2384 (gobble_line): Check for overflow more carefully. Don't update size
2385 until alloc done.
2387 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2388 Don't update size until alloc done.
2389 Redo size calculations to avoid overflow.
2390 Check for size calculation overflow.
2391 (main) [DEBUG]: Fix typo in invoking tparam1.
2393 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2394 Use ptrdiff_t, not int, for sizes.
2395 (store_mode_line_noprop_char): Don't update size until alloc done.
2397 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2398 Use ptrdiff_t, not int, for sizes.
2399 (Finternal_make_lisp_face, cache_face):
2400 Check for size calculation overflow.
2401 (cache_face): Treat size calculation overflows as if they were
2402 memory exhaustion (the usual treatment), rather than aborting.
2404 * xfns.c (x_encode_text, x_set_name_internal)
2405 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2406 sizes, since they can exceed INT_MAX in size. Check for size
2407 calculation overflow.
2409 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2410 (xg_select): Check for size calculation overflow.
2411 Don't update size until alloc done.
2413 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2414 as sprintf is limited to int lengths.
2416 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2417 (X_LONG_MIN): New macros.
2418 Use them to make the following changes clearer.
2419 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2420 This change doesn't affect the value now, but it may help remind
2421 future maintainers not to raise the value too much later.
2422 (SELECTION_QUANTUM): Remove, replacing with ...
2423 (selection_quantum): ... new function, which avoids overflow.
2424 All uses changed.
2425 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2426 assumption that selection length fits in 'int'.
2427 (x_reply_selection_request, x_handle_selection_request)
2428 (x_get_window_property, receive_incremental_selection)
2429 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2430 (lisp_data_to_selection_data, clean_local_selection_data):
2431 Use ptrdiff_t, not int, to record length of selection.
2432 (x_reply_selection_request, x_get_window_property)
2433 (receive_incremental_selection, x_property_data_to_lisp):
2434 Redo calculations to avoid overflow.
2435 (x_reply_selection_request): When sending hint, ceiling it at
2436 X_LONG_MAX rather than relying on wraparound overflow to send
2437 something.
2438 (x_get_window_property, receive_incremental_selection)
2439 (lisp_data_to_selection_data, x_property_data_to_lisp):
2440 Check for size-calculation overflow.
2441 (x_get_window_property, receive_incremental_selection)
2442 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2443 Don't store size until memory allocation succeeds.
2444 (x_get_window_property): Plug memory leak on memory exhaustion.
2445 Don't double-block input; malloc is safe here. Don't assume 2**34
2446 - 4 fits in unsigned long. Add an xassert to check
2447 XGetWindowProperty overflow. Be more careful about overflow
2448 calculations, and distinguish size from memory overflow better.
2449 (receive_incremental_selection): When tracing, don't assume
2450 unsigned int is less than INT_MAX.
2451 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2452 harmful) conversions of unsigned short to int.
2453 (lisp_data_to_selection_data): Don't assume that integers
2454 in the range -65535 through -1 fit in an X unsigned short.
2455 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2456 result parameters unless successful. Rely on cons_to_unsigned
2457 to report problems with elements; the old code wasn't right anyway.
2458 (x_check_property_data): Check for int overflow; we cannot use
2459 a wider type due to X limits.
2460 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2462 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2464 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2465 (x_term_init): Check for size calculation overflow.
2466 (x_color_cells): Don't store size until memory allocation succeeds.
2467 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2468 Don't assume alloca size is less than MAX_ALLOCA.
2469 (x_term_init): Don't assume length fits in int (sprintf is limited
2470 to int size).
2472 Use ptrdiff_t for composition IDs.
2473 * character.c (lisp_string_width):
2474 * composite.c (composition_table_size, n_compositions)
2475 (get_composition_id, composition_gstring_from_id):
2476 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2477 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2478 * window.c (Frecenter):
2479 Use ptrdiff_t, not int, for composition IDs.
2480 * composite.c (get_composition_id): Check for integer overflow.
2481 * composite.h: Adjust prototypes to match the above changes.
2483 Use ptrdiff_t for hash table indexes.
2484 * category.c (hash_get_category_set):
2485 * ccl.c (ccl_driver):
2486 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2487 * coding.c (coding_system_charset_list, detect_coding_system):
2488 * coding.h (struct coding_system.id):
2489 * composite.c (get_composition_id, gstring_lookup_cache):
2490 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2491 * image.c (xpm_get_color_table_h):
2492 * lisp.h (hash_lookup, hash_put):
2493 * minibuf.c (Ftest_completion):
2494 Use ptrdiff_t for hash table indexes, not int (which is too
2495 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2496 32-bit --with-wide-int hosts).
2498 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2499 Add a FIXME comment about memory leaks.
2500 (syms_of_charset): Don't assume xmalloc returns.
2502 Don't assume that stated character widths fit in int.
2503 * character.c (Fchar_width, c_string_width, lisp_string_width):
2504 * character.h (CHAR_WIDTH):
2505 * indent.c (MULTIBYTE_BYTES_WIDTH):
2506 Use sanitize_char_width to avoid undefined and/or bad behavior
2507 with outlandish widths.
2508 * character.h (sanitize_tab_width): Rename from sanitize_width,
2509 now that we have two such functions. All uses changed.
2510 (sanitize_char_width): New inline function.
2512 Don't assume that tab-width fits in int.
2513 * character.h (sanitize_width): New inline function.
2514 (SANE_TAB_WIDTH): New macro.
2515 (ASCII_CHAR_WIDTH): Use it.
2516 * indent.c (sane_tab_width): Remove. All uses replaced by
2517 SANE_TAB_WIDTH (current_buffer).
2518 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2520 * fileio.c: Integer overflow issues with file modes.
2521 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2523 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2524 Remove unreachable code.
2525 (read_hex, load_charset_map_from_file): Check for integer overflow.
2527 * xterm.c: Don't go over XClientMessageEvent limit.
2528 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2529 (x_send_scroll_bar_event): Likewise. Check that the size does not
2530 exceed limits imposed by XClientMessageEvent, as well as the usual
2531 ptrdiff_t and size_t limits.
2533 * keyboard.c: Overflow, signedness and related fixes.
2534 (make_lispy_movement): Use same integer type in forward decl
2535 that is used in the definition.
2536 (read_key_sequence, keyremap_step):
2537 Change bufsize argument back to int, undoing my 2011-03-30 change.
2538 We prefer signed types, and int is wide enough here.
2539 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2540 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2541 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2542 length, not size_t. Use ptrdiff_t for index, not int.
2543 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2544 possibility of integer overflow.
2546 Overflow, signedness and related fixes for images.
2548 * dispextern.h (struct it.stack[0].u.image.image_id)
2549 (struct_it.image_id, struct image.id, struct image_cache.size)
2550 (struct image_cache.used, struct image_cache.ref_count):
2551 * gtkutil.c (update_frame_tool_bar):
2552 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2553 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2554 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2555 * nsmenu.m (update_frame_tool_bar):
2556 * xdisp.c (calc_pixel_width_or_height):
2557 * xfns.c (image_cache_refcount):
2558 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2559 on typical 64-bit hosts.
2561 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2562 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2563 Omit unnecessary casts to int.
2564 (parse_image_spec): Check that integers fall into 'int' range
2565 when the callers expect that.
2566 (image_ascent): Redo ascent calculation to avoid int overflow.
2567 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2568 (lookup_image): Remove unnecessary tests.
2569 (xbm_image_p): Locals are now of int, not EMACS_INT,
2570 since parse_image_check makes sure they fit into int.
2571 (png_load, gif_load, svg_load_image):
2572 Prefer int to unsigned where either will do.
2573 (tiff_handler): New function, combining the cores of the
2574 old tiff_error_handler and tiff_warning_handler.
2575 This function is rewritten to use vsnprintf and thereby avoid
2576 stack buffer overflows. It uses only the features of vsnprintf
2577 that are common to both POSIX and native Microsoft.
2578 (tiff_error_handler, tiff_warning_handler): Use it.
2579 (tiff_load, gif_load, imagemagick_load_image):
2580 Don't assume :index value fits in 'int'.
2581 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2582 (imagemagick_load_image): Check that crop parameters fit into
2583 the integer types that MagickCropImage accepts. Don't assume
2584 Vimagemagick_render_type has a nonnegative value. Don't assume
2585 size_t fits in 'long'.
2586 (gs_load): Use printmax_t to print the widest integers possible.
2587 Check for integer overflow when computing image height and width.
2589 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2591 * xdisp.c (redisplay_window): Don't force window start if point
2592 will be invisible in the resulting window. (Bug#9324)
2594 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2596 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2597 the display spec is of the form `(space ...)'.
2598 (handle_display_spec): Return the value returned by
2599 handle_single_display_spec, not just 1 or zero.
2600 (handle_single_display_spec): If the display spec is of the form
2601 `(space ...)', and specifies display in the text area, return 2
2602 rather than 1.
2603 (try_cursor_movement): Check for the need to scroll more
2604 accurately, and prefer exact match for point under bidi.
2605 Don't advance `row' beyond the last row of the window.
2607 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2608 into disp_prop; all users changed.
2610 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2611 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2612 for the text covered by the display property.
2614 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2616 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2617 Change return value to nil.
2618 (Frecord_buffer): Delete unused function.
2620 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2622 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2623 buffers, return left-to-right.
2624 (set_cursor_from_row): Consider candidate row a win if its glyph
2625 represents a newline and point is on that newline. Fixes cursor
2626 positioning on the newline at EOL of R2L text within L2R
2627 paragraph, and vice versa.
2628 (try_cursor_movement): Check continued rows, in addition to
2629 continuation rows. Fixes unwarranted scroll when point enters a
2630 continued line of R2L text within an L2R paragraph, or vice versa.
2631 (cursor_row_p): Consider the case of point being equal to
2632 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2633 from the end of a short line to the beginning of a continued line
2634 of R2L text within L2R paragraph.
2635 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2636 composed characters.
2638 * bidi.c (bidi_check_type): Use xassert.
2639 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2640 members.
2642 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2644 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2645 a character.
2647 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2649 * nsfont.m (ns_otf_to_script): Fix typo.
2651 2011-08-22 Kenichi Handa <handa@m17n.org>
2653 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2654 extra slot even if the purpose is char-code-property-table.
2656 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2658 * xdisp.c (redisplay_window): When computing centering_position,
2659 account for the height of the header line. (Bug#8874)
2661 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2662 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2663 candidate is selected by the mouse, and that candidate has a
2664 composed character under the mouse.
2666 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2667 coordinates reported by pos-visible-in-window-p for a composed
2668 character in column zero.
2670 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2672 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2674 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2676 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2677 consider it a hit if to_charpos is anywhere in the range of the
2678 composed buffer positions.
2680 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2682 * image.c (gif_load): Don't assume that each subimage has the same
2683 dimensions as the base image. Handle disposal method that is
2684 "undefined" by the gif spec (Bug#9335).
2686 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2688 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2689 (Fcondition_case): Document `debug' symbol in error handler.
2691 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2693 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2694 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2695 from an Org mode buffer to a Speedbar frame.
2697 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2698 a composition, take its buffer position from IT->cmp_it.charpos.
2699 Fixes cursor positioning at the beginning of a line that begins
2700 with a composed character.
2702 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2704 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2705 character bidirectional type, use STRONG_L instead. Fixes crashes
2706 in a buffer produced by `describe-categories'.
2708 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2709 members before the level stack, so they would be saved and
2710 restored when copying iterator state. Fixes incorrect reordering
2711 around TABs covered by display properties.
2713 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2715 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2717 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2719 * eval.c (internal_condition_case, internal_condition_case_1)
2720 (internal_condition_case_2, internal_condition_case_n):
2721 Remove unnecessary aborts (Bug#9081).
2723 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2725 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2726 has no `load' handler, try opening the file locally. (Bug#9311)
2728 2011-08-16 Ken Brown <kbrown@cornell.edu>
2730 * gmalloc.c: Expand comment.
2732 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2734 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2735 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2737 2011-08-16 Ken Brown <kbrown@cornell.edu>
2739 Fix memory allocation problems in Cygwin build (Bug#9273).
2741 * unexcw.c ( __malloc_initialized): Declare external variable.
2742 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2744 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2745 New variables.
2746 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2747 dumped emacs.
2748 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2749 in the static heap.
2750 [CYGWIN] (special_realloc): New function.
2751 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2752 requests to realloc storage in the static heap.
2754 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2756 * bidi.c (bidi_initialize): Remove unused local.
2758 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2760 * bidimirror.h:
2761 * biditype.h: Remove file.
2762 * makefile.w32-in ($(BLD)/bidi.$(O)):
2763 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2765 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2767 * chartab.c: Improve commentary for the uniprop_table API.
2769 * bidi.c (bidi_paragraph_init): Support zero value of
2770 bidi_ignore_explicit_marks_for_paragraph_level.
2771 (bidi_initialize): Use uniprop_table instead of including
2772 biditype.h and bidimirror.h.
2774 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2775 coordinates of the iterator when restoring from ppos_it.
2776 (Bug#9296)
2778 2011-08-14 Kenichi Handa <handa@m17n.org>
2780 * process.c (create_process): Call setup_process_coding_systems
2781 after the pid of the process is set to -1 (Bug#8162).
2783 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2785 * xdisp.c (move_it_in_display_line_to): Don't invoke
2786 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2787 ppos_it. Fixes vertical cursor motion when line beginning is
2788 covered by an image. (Bug#9296)
2790 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2792 * nsterm.h (ns_run_ascript): Declare.
2793 (NSAPP_DATA2_RUNASSCRIPT): Define.
2795 * nsfns.m (as_script, as_result, as_status): New static variables.
2796 (ns_run_ascript): New function.
2797 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2798 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2799 the event loop. Get status from as_status (Bug#7276).
2801 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2802 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2803 the event loop (Bug#7276).
2805 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2807 * gnutls.c (QCgnutls_bootprop_priority)
2808 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2809 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2810 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2811 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2812 (QCgnutls_bootprop_verify_hostname_error)
2813 (QCgnutls_bootprop_callbacks_verify): Rename from
2814 Qgnutls_bootprop_..., all uses changed.
2816 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2817 uses changed.
2819 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2821 * xfaces.c (Qframe_set_background_mode): Now static.
2822 * dispextern.h (Qframe_set_background_mode): Remove decl.
2824 * process.c (Fnetwork_interface_info): Declare local only if needed.
2826 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2828 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2829 (Fnetwork_interface_list): Allocate in increments of bytes instead
2830 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2831 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2832 sockaddr.
2833 (struct ifflag_def): notrailers is smart on OSX.
2834 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2835 Get hardware address with getifaddrs if available.
2837 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2839 * xdisp.c (iterate_out_of_display_property): xassert that
2840 IT->position is set to within IT->object's boundaries. Break from
2841 the loop as soon as EOB is reached; avoids infloops in redisplay
2842 when IT->position is set up wrongly due to some bug.
2843 Set IT->current to match the bidi iterator unconditionally.
2844 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2845 entry. Force push_it to save on the stack the current
2846 buffer/string position, to be restored by pop_it. Fix flags in
2847 the iterator structure wrt the object coming from a display
2848 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2849 properties. (Bug#9284)
2851 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2853 * fontset.c (fontset_get_font_group): Add proper type checks.
2854 (Bug#9172)
2856 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2858 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2859 and LC_VERSION_MIN_MACOSX.
2860 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2861 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2863 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (forward_to_next_line_start): Allow to use the
2866 no-display-properties-and-no-overlays under bidi display.
2867 Set disp_pos in the bidi iterator to avoid searches for display
2868 properties and overlays.
2870 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2872 * editfns.c (Fset_time_zone_rule): Document relationship with the
2873 setenv function.
2875 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2876 the font entity extracted from the cache (Bug#8109).
2878 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2880 * composite.c (autocmp_chars): Don't reset point. That is done by
2881 restore_point_unwind (Bug#5984).
2883 2011-08-07 Juri Linkov <juri@jurta.org>
2885 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2886 to show the arg `TIME' instead of `TIMEVAL'.
2888 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2890 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2891 display property strides EOL and includes a newline, as in
2892 longlines-mode. (Bug#9254)
2893 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2894 word-wrap under bidirectional display. (Bug#9224)
2896 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2897 is non-zero, even if the data buffer is NULL. Fixes a crash in
2898 vertical-motion with longlines-mode. (Bug#9254)
2900 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2902 * bidi.c <bidi_cache_total_alloc>: Now static.
2903 (bidi_initialize): Initialize bidi_cache_total_alloc.
2905 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2906 cache. (Bug#9221)
2908 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2909 amount allocated this far in `bidi_cache_total_alloc'.
2910 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2911 non-zero, only free the data buffer without restoring the cache
2912 contents. All callers changed.
2914 * dispextern.h (bidi_unshelve_cache): Update prototype.
2916 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2917 (move_it_in_display_line, move_it_to)
2918 (move_it_vertically_backward, move_it_by_lines): Replace the call
2919 to xfree to an equivalent call to bidi_unshelve_cache.
2920 (move_it_in_display_line_to): Fix logic of returning
2921 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2923 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2925 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2926 came from a string character with a `cursor' property. (Bug#9229)
2928 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2930 * Makefile.in (LIB_PTHREAD): New variable.
2931 (LIBES): Add LIB_PTHREAD (Bug#9216).
2933 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2934 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2936 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2938 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2940 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2942 * xterm.c (x_find_topmost_parent): New function.
2943 (x_set_frame_alpha): Find topmost parent window with
2944 x_find_topmost_parent and set the property there also (bug#9181).
2945 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2947 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2949 * callproc.c (Fcall_process): Avoid vfork clobbering
2950 the local vars buffer, coding_systems, current_dir.
2952 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2954 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2956 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2958 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2959 so that it is not optimized away.
2961 * xdisp.c (compute_display_string_pos): Remove unused local.
2963 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2965 Fix slow cursor motion and scrolling in large buffers with
2966 selective display, like Org Mode buffers. (Bug#9218)
2968 * dispextern.h (struct bidi_it): New member disp_prop_p.
2970 * xdisp.c: Remove one-slot cache of display string positions.
2971 (compute_display_string_pos): Accept an additional argument
2972 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2973 for a display string or property. If found, set DISP_PROP_P
2974 non-zero.
2976 * bidi.c (bidi_fetch_char): Accept an additional argument
2977 DISP_PROP_P, and pass it to compute_display_string_pos.
2978 Only handle text covered by a display string if DISP_PROP_P is returned
2979 non-zero. All callers of bidi_fetch_char changed.
2981 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2983 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2985 2010-12-03 Don March <don@ohspite.net>
2987 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2988 last character M-[char] is translated to ESC [char] (bug#7541).
2990 2011-08-02 Kenichi Handa <handa@m17n.org>
2992 * lisp.h (uniprop_table): Extern it.
2994 * chartab.c (uniprop_table): Make it non-static.
2996 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2998 * xdisp.c (forward_to_next_line_start): Accept additional argument
2999 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3000 on the newline.
3001 (reseat_at_next_visible_line_start): Use the bidi iterator state
3002 returned by forward_to_next_line_start to restore the state of
3003 it->bidi_it after backing up to previous newline. (Bug#9212)
3005 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3007 * regex.c (re_comp): Protoize.
3008 (re_exec): Fix return type.
3009 (regexec): Fix type of `ret'. (Bug#9203)
3011 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3013 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3014 This is needed if max-image-size is a floating-point number.
3016 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3018 * print.c (print_object): Print empty symbol as ##.
3020 * lread.c (read1): Read ## as empty symbol.
3022 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3024 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3025 setting frame foreground color (Bug#9175).
3026 (x_set_background_color): Likewise.
3028 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3029 contents (Bug#9176).
3030 (EmacsTooltip -init): Remove bezels and add shadows to
3031 tooltip windows.
3033 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3034 or scroll bar (Bug#8470).
3036 * nsfont.m (nsfont_open): Remove assignment to voffset and
3037 unnecessary vars hshink, expand, hd, full_height, min_height.
3038 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3040 * nsterm.h (nsfont_info): Remove voffset field.
3042 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3044 Implement strike-through and overline on NextStep (Bug#8863).
3046 * nsfont.m (nsfont_open): Use underline position provided by font,
3047 instead of hard-coded value of 2.
3048 (nsfont_draw): Call ns_draw_text_decoration instead.
3050 * nsterm.h: Add declaration for ns_draw_text_decoration.
3052 * nsterm.m (ns_draw_text_decoration): New function for drawing
3053 underline, overline, and strike-through.
3054 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3055 ns_draw_text_decoration. Change treatment of cursor drawing to
3056 accommodate underlining, etc.
3058 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3060 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3061 default.
3063 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3065 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3066 Without this fix, if a signal arrives just after memory fills up,
3067 'malloc' might be invoked reentrantly.
3069 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3070 In other words, assume that every image size is allowed, on non-X
3071 hosts. This assumption is probably wrong, but it lets Emacs compile.
3073 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3075 * regex.c (re_iswctype): Convert return values to boolean.
3077 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3079 * xdisp.c (compute_display_string_pos): Don't use cached display
3080 string position if the buffer had its restriction changed.
3081 (Bug#9184)
3083 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3085 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3087 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3089 Integer signedness and overflow and related fixes. (Bug#9079)
3091 * bidi.c: Integer size and overflow fixes.
3092 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3093 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3094 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3095 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3096 (bidi_find_other_level_edge):
3097 Use ptrdiff_t instead of EMACS_INT where either will do.
3098 This works better on 32-bit hosts configured --with-wide-int.
3099 (bidi_cache_ensure_space): Check for size-calculation overflow.
3100 Use % rather than repeated addition, for better worst-case speed.
3101 Don't set bidi_cache_size until after xrealloc returns, because it
3102 might not return.
3103 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3104 (bidi_cache_ensure_space): Also check that the bidi cache size
3105 does not exceed that of the largest Lisp string or buffer. See Eli
3106 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3108 * alloc.c (__malloc_size_t): Remove.
3109 All uses replaced by size_t. See Andreas Schwab's note
3110 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3112 * image.c: Improve checking for integer overflow.
3113 (check_image_size): Assume that f is nonnull, since
3114 it is always nonnull in practice. This is one less thing to
3115 worry about when checking for integer overflow later.
3116 (x_check_image_size): New function, which checks for integer
3117 overflow issues inside X.
3118 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3119 This removes the need for a memory_full check.
3120 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3121 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3122 (xbm_read_bitmap_data): Change locals back to 'int', since
3123 their values must fit in 'int'.
3124 (xpm_load_image, png_load, tiff_load):
3125 Invoke x_create_x_image_and_pixmap earlier,
3126 to avoid much needless work if the image is too large.
3127 (tiff_load): Treat overly large images as if
3128 x_create_x_image_and_pixmap failed, not as malloc failures.
3129 (gs_load): Use x_check_image_size.
3131 * gtkutil.c: Omit integer casts.
3132 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3133 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3135 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3137 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3138 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3139 would wrongly return t on a 64-bit host.
3141 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3142 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3143 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3144 and therefore cause GCC to emit a bogus diagnostic in some cases.
3146 * image.c: Integer signedness and overflow and related fixes.
3147 This is not an exhaustive set of fixes, but it's time to
3148 record what I've got.
3149 (lookup_pixel_color, check_image_size): Remove redundant decls.
3150 (check_image_size): Don't assume that arbitrary EMACS_INT values
3151 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3152 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3153 (tiff_load, imagemagick_load_image):
3154 Check for overflow in size calculations.
3155 (x_create_x_image_and_pixmap): Remove unnecessary test for
3156 xmalloc returning NULL; that can't happen.
3157 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3158 (xpm_color_bucket): Use better integer hashing function.
3159 (xpm_cache_color): Don't possibly over-allocate memory.
3160 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3161 (gif_memory_source):
3162 Use ptrdiff_t, not int or size_t, to record sizes.
3163 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3164 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3165 either works, as we prefer signed integers.
3166 (tiff_read_from_memory, tiff_write_from_memory):
3167 Return tsize_t, not size_t, since that's what the TIFF API wants.
3168 (tiff_read_from_memory): Don't fail simply because the read would
3169 go past EOF; instead, return a short read.
3170 (tiff_load): Omit no-longer-needed casts.
3171 (Fimagemagick_types): Don't assume size fits into 'int'.
3173 Improve hashing quality when configured --with-wide-int.
3174 * fns.c (hash_string): New function, taken from sxhash_string.
3175 Do not discard information about ASCII character case; this
3176 discarding is no longer needed.
3177 (sxhash-string): Use it. Change sig to match it. Caller changed.
3178 * lisp.h: Declare it.
3179 * lread.c (hash_string): Remove, since we now use fns.c's version.
3180 The fns.c version returns a wider integer if --with-wide-int is
3181 specified, so this should help the quality of the hashing a bit.
3183 * emacs.c: Integer overflow minor fix.
3184 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3185 Define only if GNU_LINUX.
3186 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3188 * dispnew.c: Integer signedness and overflow fixes.
3189 Remove unnecessary forward decls, that were a maintenance hassle.
3190 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3191 All uses changed.
3192 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3193 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3194 (prepare_desired_row, line_draw_cost):
3195 Use int, not unsigned, where either works.
3196 (save_current_matrix, restore_current_matrix):
3197 Use ptrdiff_t, not size_t, where either works.
3198 (init_display): Check for overflow more accurately, and without
3199 relying on undefined behavior.
3201 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3202 Remove, replacing with the new symbols in lisp.h. All uses changed.
3203 * fileio.c (make_temp_name):
3204 * filelock.c (lock_file_1, lock_file):
3205 * xdisp.c (message_dolog):
3206 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3207 Use pMd etc. instead.
3208 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3209 replacing the pWIDE etc. symbols removed from editfns.c.
3211 * keyboard.h (num_input_events): Now uintmax_t.
3212 This is (very slightly) less likely to mess up due to wraparound.
3213 All uses changed.
3215 * buffer.c: Integer signedness fixes.
3216 (alloc_buffer_text, enlarge_buffer_text):
3217 Use ptrdiff_t rather than size_t when either will do, as we prefer
3218 signed integers.
3220 * alloc.c: Integer signedness and overflow fixes.
3221 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3222 (__malloc_size_t): Default to size_t, not to int.
3223 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3224 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3225 Prefer ptrdiff_t to size_t when either would do, as we prefer
3226 signed integers.
3227 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3228 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3229 Now const. Initialize with values that are in range even if char
3230 is signed.
3231 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3232 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3233 These functions do the right thing with sizes > 2**32.
3234 (check_depth): Now ptrdiff_t, not int.
3235 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3236 Adjust to new way of storing sizes. Check for size overflow bugs
3237 in rest of code.
3238 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3239 slightly wrong anyway, as it missed one instance of
3240 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3241 (refill_memory_reserve): Omit needless cast to size_t.
3242 (mark_object_loop_halt): Mark as externally visible.
3244 * xselect.c: Integer signedness and overflow fixes.
3245 (Fx_register_dnd_atom, x_handle_dnd_message):
3246 Use ptrdiff_t, not size_t, since we prefer signed.
3247 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3248 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3249 x_dnd_atoms_size and x_dnd_atoms_length.
3251 * doprnt.c: Prefer signed to unsigned when either works.
3252 * eval.c (verror):
3253 * doprnt.c (doprnt):
3254 * lisp.h (doprnt):
3255 * xdisp.c (vmessage):
3256 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3257 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3258 prefer signed arithmetic to avoid comparison confusion.
3259 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3260 but is a bit tricky.
3262 Assume freestanding C89 headers, string.h, stdlib.h.
3263 * data.c, doprnt.c, floatfns.c, print.c:
3264 Include float.h unconditionally.
3265 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3266 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3267 * regex.c: Likewise for stddef.h, string.h.
3268 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3269 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3270 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3271 (STDC_HEADERS): Remove obsolete defines.
3272 * sysdep.c: Include limits.h unconditionally.
3274 Assume support for memcmp, memcpy, memmove, memset.
3275 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3276 * regex.c (memcmp, memcpy):
3277 Remove; we assume C89 now.
3279 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3280 (__malloc_safe_bcopy): Remove; no longer needed.
3282 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3283 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3284 well either way, and we prefer signed to unsigned.
3286 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3288 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3289 closes the connection while we're reading (bug#9182).
3291 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3293 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3294 are specified (Bug#9168).
3296 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3298 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3299 Found by GCC static checking and --with-wide-int on a 32-bit host.
3301 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3303 * xdisp.c (compute_display_string_pos): Fix logic of caching
3304 previous display string position. Initialize cached_prev_pos to
3305 -1. Fixes slow-down at the beginning of a buffer.
3307 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3309 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3310 for attrs[LFACE_FONTSET_INDEX].
3312 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3314 * xml.c (parse_region): Remove unused local
3315 that was recently introduced.
3317 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3319 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3320 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3322 * xdisp.c (move_it_in_display_line_to): Record the best matching
3323 position for TO_CHARPOS while scanning the line, and restore it on
3324 exit if none of the characters scanned was an exact match.
3325 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3326 when exact match is impossible due to invisible text, and the
3327 lines are truncated.
3329 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3331 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3332 for OSX >= 10.7.
3334 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3336 Fix a significant slow-down of cursor motion with C-n, C-p,
3337 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3338 auto-repeat under bidi redisplay in fontified buffers.
3339 * xdisp.c (compute_stop_pos_backwards): New function.
3340 (next_element_from_buffer): Call compute_stop_pos_backwards to
3341 find a suitable prev_stop when we find ourselves before
3342 base_level_stop.
3343 (reseat): Don't look for prev_stop, as that could mean a very long
3344 run.
3345 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3346 <cached_disp_overlay_modiff>: Cache for last found display string
3347 position.
3348 (compute_display_string_pos): Return the cached position if asked
3349 about the same buffer in the same area of character positions, and
3350 the buffer wasn't changed since the time the display string
3351 position was cached.
3353 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3356 is an integer, which is important for empty lines. (Bug#9149)
3358 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3360 * frame.c (Fmodify_frame_parameters): In tty case, update the
3361 default face if necessary (Bug#4238).
3363 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3365 * editfns.c (Fstring_to_char): No need to explain what a character
3366 is in the docstring (Bug#6576).
3368 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3370 * xml.c (parse_region): Make sure we always return a tree.
3372 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3374 * xml.c (parse_region): If a document contains only comments,
3375 return that, too.
3377 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3379 * xml.c (make_dom): Return comments, too.
3381 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3383 Port to OpenBSD.
3384 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3385 and the surrounding thread.
3386 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3387 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3388 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3389 timer goes off.
3390 * s/openbsd.h (BROKEN_SIGIO): Define.
3391 * unexelf.c (unexec) [__OpenBSD__]:
3392 Don't update the .mdebug section of the Alpha COFF symbol table.
3394 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3396 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3397 (bug#8460).
3399 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3401 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3402 This fixes some race conditions on the permissions of any newly
3403 created file.
3405 * alloc.c (valid_pointer_p): Use pipe, not open.
3406 This fixes some permissions issues when debugging.
3408 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3409 If fchown fails to set both uid and gid, try to set just gid,
3410 as that is sometimes allowed. Adjust the file's mode to eliminate
3411 setuid or setgid bits that are inappropriate if fchown fails.
3413 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3415 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3416 to compare Lisp_Objects.
3417 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3418 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3419 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3421 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3423 * lread.c (read_integer): Unread even EOF character.
3424 (read1): Likewise. Properly record start position of symbol.
3426 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3427 symbol character follows.
3429 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3431 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3432 This works around a problem with the previous change to Fcopy_file.
3433 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3434 and without this change, GCC might complain about discarding
3435 fchown's return value.
3437 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3439 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3441 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3443 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3445 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3448 it's used from the C level.
3450 * process.c: Use the same condition for POLL_FOR_INPUT in both
3451 keyboard.c and process.c (bug#1858).
3453 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3455 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3456 (Fgnutls_boot): Use it.
3458 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3460 * doc.c (Fsubstitute_command_keys): Revert last change.
3462 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3464 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3465 quotes the next character, and doesn't affect other longer
3466 sequences (bug#8935).
3468 * lread.c (syms_of_lread): Clarify that is isn't only
3469 `eval-buffer' and `eval-defun' that's affected by
3470 `lexical-binding' (bug#8460).
3472 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3474 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3475 bidi redisplay when a line includes both an image and is truncated.
3477 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3479 Fix minor problems found by static checking.
3480 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3481 (elsz): Now a signed constant, not a size_t var. We prefer signed
3482 types to unsigned, to avoid integer comparison confusion. Without
3483 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3484 "cannot optimize loop, the loop counter may overflow", a symptom
3485 of the confusion.
3486 * indent.c (Fvertical_motion): Mark locals as initialized.
3487 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3489 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3491 * search.c (Fre_search_backward): Mention `case-fold-search' in
3492 all the re_search_* functions (bug#8138).
3494 * keyboard.c (Fopen_dribble_file): Document when the file is
3495 closed (bug#8056).
3497 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3499 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3500 bidi_cache_idx.
3502 Support bidi reordering of display and overlay strings.
3503 * xdisp.c (compute_display_string_pos)
3504 (compute_display_string_end): Accept additional argument STRING.
3505 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3506 (reseat_to_string): Initialize bidi_it->string.s and
3507 bidi_it->string.schars.
3508 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3509 NULL (avoids a crash in bidi_paragraph_init).
3510 Initialize itb.string.lstring.
3511 (init_iterator): Call bidi_init_it only of a valid
3512 buffer position was specified. Initialize paragraph_embedding to
3513 L2R.
3514 (reseat_to_string): Initialize the bidi iterator.
3515 (display_string): If we need to ignore text properties of
3516 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3517 original value of -1 will not work with bidi.)
3518 (compute_display_string_pos): First arg is now struct
3519 `text_pos *'; all callers changed. Support display properties on
3520 Lisp strings.
3521 (compute_display_string_end): Support display properties on Lisp
3522 strings.
3523 (init_iterator, reseat_1, reseat_to_string): Initialize the
3524 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3525 when iterating on a string not from display properties).
3526 (compute_display_string_pos, compute_display_string_end):
3527 Fix calculation of the object to scan. Fixes an error when using
3528 arrow keys.
3529 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3530 base_level_stop; instead, set base_level_stop to BEGV.
3531 Fixes crashes in vertical-motion.
3532 (next_element_from_buffer): Improve commentary for when
3533 the iterator is before prev_stop.
3534 (init_iterator): Initialize bidi_p from the default value of
3535 bidi-display-reordering, not from buffer-local value. Use the
3536 buffer-local value only if initializing for buffer iteration.
3537 (handle_invisible_prop): Support invisible properties on strings
3538 that are being bidi-reordered.
3539 (set_iterator_to_next): Support bidi reordering of C strings and
3540 Lisp strings.
3541 (next_element_from_string): Support bidi reordering of Lisp
3542 strings.
3543 (handle_stop_backwards): Support Lisp strings as well.
3544 (display_string): Support display of R2L glyph rows.
3545 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3546 (init_iterator): Don't initialize it->bidi_p for strings
3547 here.
3548 (reseat_to_string): Initialize it->bidi_p for strings here.
3549 (next_element_from_string, next_element_from_c_string)
3550 (next_element_from_buffer): Add xassert's for correspondence
3551 between IT's object being iterated and it->bidi_it.string
3552 structure.
3553 (face_before_or_after_it_pos): Support bidi iteration.
3554 (next_element_from_c_string): Handle the case of the first string
3555 character that is not the first one in the visual order.
3556 (get_visually_first_element): New function, refactored from common
3557 parts of next_element_from_buffer, next_element_from_string, and
3558 next_element_from_c_string.
3559 (tool_bar_lines_needed, redisplay_tool_bar)
3560 (display_menu_bar): Force left-to-right direction. Add a FIXME
3561 comment for making that be controlled by a user option.
3562 (push_it, pop_it): Save and restore the state of the
3563 bidi iterator. Save and restore the bidi_p flag.
3564 (pop_it): Iterate out of display property for string iteration as
3565 well.
3566 (iterate_out_of_display_property): Support iteration over strings.
3567 (handle_single_display_spec): Set up it->bidi_it for iteration
3568 over a display string, and call bidi_init_it.
3569 (handle_single_display_spec, next_overlay_string)
3570 (get_overlay_strings_1, push_display_prop): Set up the bidi
3571 iterator for displaying display or overlay strings.
3572 (forward_to_next_line_start): Don't use the shortcut if
3573 bidi-iterating.
3574 (back_to_previous_visible_line_start): If handle_display_prop
3575 pushed the iterator stack, restore the internal state of the bidi
3576 iterator by calling bidi_pop_it same number of times.
3577 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3578 and we are bidi-iterating, don't decrement the iterator position;
3579 instead, set the first_elt flag in the bidi iterator, to produce
3580 the same effect.
3581 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3582 (push_display_prop): xassert that we are iterating a buffer.
3583 (push_it, pop_it): Save and restore paragraph_embedding member.
3584 (handle_single_display_spec, next_overlay_string)
3585 (get_overlay_strings_1, reseat_1, reseat_to_string)
3586 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3587 correctly. Don't assume unibyte strings are not bidi-reordered.
3588 (compute_display_string_pos)
3589 (compute_display_string_end): Fix handling the case of C string.
3590 (push_it, pop_it): Save and restore from_disp_prop_p.
3591 (handle_single_display_spec, push_display_prop): Set the
3592 from_disp_prop_p flag.
3593 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3594 (pop_it): Call iterate_out_of_display_property only if we are
3595 popping after iteration over a string that came from a display
3596 property. Fix a typo in popping stretch info. Add an assertion
3597 for verifying that the iterator position is in sync with the bidi
3598 iterator.
3599 (handle_single_display_spec, get_overlay_strings_1)
3600 (push_display_prop): Fix initialization of paragraph direction for
3601 string when that of the parent object is not yet determined.
3602 (reseat_1): Call bidi_init_it to resync the bidi
3603 iterator with IT's position. (Bug#7616)
3604 (find_row_edges): If ROW->start.pos gives position
3605 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3606 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3607 Reset the from_disp_prop_p flag.
3608 (SAVE_IT, RESTORE_IT): New macros.
3609 (pos_visible_p, face_before_or_after_it_pos)
3610 (back_to_previous_visible_line_start)
3611 (move_it_in_display_line_to, move_it_in_display_line)
3612 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3613 (try_scrolling, redisplay_window, display_line): Use them when
3614 saving a temporary copy of the iterator and restoring it back.
3615 (back_to_previous_visible_line_start, reseat_1)
3616 (init_iterator): Empty the bidi cache "stack".
3617 (move_it_in_display_line_to): If iterator ended up at
3618 EOL, but we never saw any buffer positions smaller than
3619 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3620 motion in bidi-reordered lines.
3621 (move_it_in_display_line_to): Record prev_method and prev_pos
3622 immediately before the call to set_iterator_to_next. Fixes cursor
3623 motion in bidi-reordered lines with stretch glyphs and strings
3624 displayed in margins. (Bug#8133) (Bug#8867)
3625 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3626 TO_CHARPOS.
3627 (pos_visible_p): Support positions in bidi-reordered lines.
3628 Save and restore bidi cache.
3630 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3631 (bidi_paragraph_info): Delete unused struct.
3632 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3633 (bidi_cache_start): New variable.
3634 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3635 to zero.
3636 (bidi_cache_fetch_state, bidi_cache_search)
3637 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3638 (bidi_cache_find, bidi_peek_at_next_level)
3639 (bidi_level_of_next_char, bidi_find_other_level_edge)
3640 (bidi_move_to_visually_next): Compare cache index with
3641 bidi_cache_start rather than with zero.
3642 (bidi_fetch_char): Accept new argument STRING; all callers
3643 changed. Support iteration over a string. Support strings with
3644 display properties. Support unibyte strings. Fix the type of
3645 `len' according to what STRING_CHAR_AND_LENGTH expects.
3646 (bidi_paragraph_init, bidi_resolve_explicit_1)
3647 (bidi_resolve_explicit, bidi_resolve_weak)
3648 (bidi_level_of_next_char, bidi_move_to_visually_next):
3649 Support iteration over a string.
3650 (bidi_set_sor_type, bidi_resolve_explicit_1)
3651 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3652 can now be zero (for strings); special values 0 and -1 were
3653 changed to -1 and -2, respectively.
3654 (bidi_char_at_pos): New function.
3655 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3656 Call it instead of FETCH_MULTIBYTE_CHAR.
3657 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3658 initialized to valid values.
3659 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3660 values.
3661 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3662 the test for valid cached positions. Fix the logic for looking up
3663 the sentinel state in the cache. GCPRO the Lisp string we are
3664 iterating.
3665 (bidi_push_it, bidi_pop_it): New functions.
3666 (bidi_initialize): Initialize the bidi cache start stack pointer.
3667 (bidi_cache_ensure_space): New function, refactored from part of
3668 bidi_cache_iterator_state. Don't assume the required size is just
3669 one BIDI_CACHE_CHUNK away.
3670 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3671 (bidi_count_bytes, bidi_char_at_pos): New functions.
3672 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3673 always valid if bidi_cache_idx is valid.
3674 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3675 is valid if it's going to be used.
3676 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3677 (bidi_cache_fetch_state, bidi_cache_search)
3678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3679 (bidi_cache_iterator_state, bidi_cache_find)
3680 (bidi_find_other_level_edge, bidi_cache_start_stack):
3681 All variables related to cache indices are now EMACS_INT.
3683 * dispextern.h (struct bidi_string_data): New structure.
3684 (struct bidi_it): New member `string'. Make flag members be 1-bit
3685 fields, and put them last in the struct.
3686 (compute_display_string_pos, compute_display_string_end):
3687 Update prototypes.
3688 (bidi_push_it, bidi_pop_it): Add prototypes.
3689 (struct iterator_stack_entry): New members bidi_p,
3690 paragraph_embedding, and from_disp_prop_p.
3691 (struct it): Member bidi_p is now a bit field 1 bit wide.
3692 (bidi_shelve_cache, bidi_unshelve_cache):
3693 Declare prototypes.
3695 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3696 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3697 and vector-like objects.
3699 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3700 cache around display iteration.
3702 * window.c (Fwindow_end, window_scroll_pixel_based)
3703 (displayed_window_lines, Frecenter): Save and restore the bidi
3704 cache around display iteration.
3706 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3708 * editfns.c (Fdelete_region): Clarify the use of the named
3709 parameters (bug#6788).
3711 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3713 * indent.c (Fvertical_motion): Set and restore w->pointm when
3714 saving and restoring the window's buffer (Bug#9006).
3716 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3718 * editfns.c (Fstring_to_char): Clarify just what is returned
3719 (bug#6576). Text by Eli Zaretskii.
3721 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3723 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3725 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3727 * buffer.c (mmap_find): Fix a typo.
3729 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3731 Fix execution of x selection hooks.
3732 * xselect.c (Qx_lost_selection_functions)
3733 (Qx_sent_selection_functions): New vars.
3734 (syms_of_xselect): DEFSYM them.
3735 (x_handle_selection_request): Pass Qx_sent_selection_functions
3736 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3737 (x_handle_selection_clear,x_clear_frame_selections):
3738 Pass Qx_lost_selection_functions rather than
3739 Vx_lost_selection_functions to Frun_hook_with_args.
3741 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3743 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3744 The old code sometimes used this field without initializing it.
3746 * alloc.c (gc_sweep): Don't read past end of array.
3747 In theory, the old code could also have corrupted Emacs internals,
3748 though it'd be very unlikely.
3750 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3752 * character.c (Fcharacterp): Don't advertise optional ignored
3753 argument. (Bug#4026)
3755 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3758 key" (bug#4257).
3760 * window.c (Fset_window_start): Doc fix (bug#4199).
3761 (Fset_window_hscroll): Ditto.
3763 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3765 Fix minor new problems caught by GCC 4.6.1.
3766 * term.c (init_tty): Remove unused local.
3767 * xsettings.c (store_monospaced_changed): Define this function only
3768 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3769 not used otherwise.
3771 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3773 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3775 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3777 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3778 are the mini-buffer and the echo area (bug#3320).
3780 * term.c (init_tty): Remove support for supdup, c10 and perq
3781 terminals, which are no longer supported (bug#1482).
3783 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3785 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3787 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3789 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3790 for non-popups (Bug#3642).
3792 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3794 * alloc.c (reset_malloc_hooks): Protoize.
3795 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3796 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3797 * cm.c (losecursor): Likewise.
3798 * data.c (fmod): Likewise.
3799 * dispnew.c (swap_glyphs_in_rows): Likewise.
3800 * emacs.c (memory_warning_signal): Likewise.
3801 * floatfns.c (float_error): Likewise.
3802 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3803 (otf_open, font_otf_capability, generate_otf_features)
3804 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3805 Likewise.
3806 * image.c (pbm_read_file): Likewise.
3807 * indent.c (string_display_width): Likewise.
3808 * intervals.c (check_for_interval, search_for_interval)
3809 (inc_interval_count, count_intervals, root_interval)
3810 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3811 * lread.c (defalias): Likewise.
3812 * ralloc.c (r_alloc_check): Likewise.
3813 * regex.c (set_image_of_range_1, set_image_of_range)
3814 (regex_grow_registers): Likewise.
3815 * sysdep.c (strerror): Likewise.
3816 * termcap.c (valid_filename_p, tprint, main): Likewise.
3817 * tparam.c (main): Likewise.
3818 * unexhp9k800.c (run_time_remap, save_data_space)
3819 (update_file_ptrs, read_header, write_header, calculate_checksum)
3820 (copy_file, copy_rest, display_header): Likewise.
3821 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3822 Likewise.
3823 * xdisp.c (check_it): Likewise.
3824 * xfaces.c (register_color, unregister_color, unregister_colors):
3825 Likewise.
3826 * xfns.c (print_fontset_result): Likewise.
3827 * xrdb.c (member, fatal, main): Likewise.
3829 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3831 Fix minor problems found by static checking (Bug#9031).
3832 * chartab.c (char_table_set_range, map_sub_char_table):
3833 Remove unused locals.
3834 (uniprop_table): Now static.
3835 * composite.c (_work_char): Remove unused static var.
3837 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3839 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3841 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3843 * gtkutil.c (qttip_cb): Remove code without function.
3845 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3847 * w32.c (pthread_sigmask): New stub.
3849 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3851 Use pthread_sigmask, not sigprocmask (Bug#9010).
3852 sigprocmask is portable only for single-threaded applications, and
3853 Emacs can be multi-threaded when it uses GTK.
3854 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3855 (LIBES): Use it.
3856 * callproc.c (Fcall_process):
3857 * process.c (create_process):
3858 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3859 Use pthread_sigmask, not sigprocmask.
3861 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3863 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3864 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3865 wrong (Bug#8591).
3867 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3869 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3870 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3871 (xg_hide_tooltip): Fix comment.
3873 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3874 in registerServicesMenuSendTypes.
3875 (validRequestorForSendType): Don't check ns_return_types.
3877 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3878 ns_return_type.
3880 2011-07-08 Jason Rumney <jasonr@gnu.org>
3882 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3883 SH_SHOW for hidden windows (Bug#5482).
3885 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3886 frame struct members of non-existent frames (Bug#6284).
3888 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3890 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3891 variable firstTime not needed on OSX >= 10.6.
3892 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3893 >= 10.5. Use setKnobProportion, setDoubleValue.
3895 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3896 (MAC_OS_X_VERSION_10_5): Define if not defined.
3897 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3898 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3899 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3901 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3902 cString and lossyCString on OSX >= 10.4
3904 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3905 sizeToFit on OSX >= 10.2.
3907 * nsimage.m (allocInitFromFile): Don't use deprecated method
3908 bestRepresentationForDevice on OSX >= 10.6.
3910 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3911 to avoid warning.
3913 * emacs.c: Declare unexec_init_emacs_zone.
3915 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3917 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3919 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3920 on svcsMenu (Bug#8842).
3922 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3923 ns_return_types.
3924 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3926 * nsterm.m (QUTF8_STRING): Declare.
3927 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3928 (validRequestorForSendType): Return type is (id).
3929 Change indexOfObjectIdenticalTo to indexOfObject.
3930 Check if we have local selection before returning self (Bug#8842).
3931 (writeSelectionToPasteboard): Put local selection into paste board
3932 if we have a local selection (Bug#8842).
3933 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3935 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3936 (ns_get_local_selection): Declare.
3938 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3940 * keymap.c (describe_map_tree): Don't insert a double newline at
3941 the end of the buffer (bug#1169) and return whether we inserted
3942 something.
3944 * callint.c (Fcall_interactively): Change "reading args" to
3945 "providing args" to try to clarify what it does (bug#1010).
3947 2011-07-07 Kenichi Handa <handa@m17n.org>
3949 * composite.c (composition_compute_stop_pos): Ignore a static
3950 composition starting before CHARPOS (Bug#8915).
3952 * xdisp.c (handle_composition_prop): Likewise.
3954 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3956 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3957 (Bug#9015)
3959 2011-07-07 Kenichi Handa <handa@m17n.org>
3961 * character.h (unicode_category_t): New enum type.
3963 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3964 (Qchar_code_property_table): New variable.
3965 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3966 (UNIPROP_COMPRESSED_FORM_P): New macros.
3967 (char_table_ascii): Uncompress the compressed values.
3968 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3969 Uncompress the compressed values.
3970 (sub_char_table_ref_and_range): Likewise.
3971 (char_table_ref_and_range): Uncompress the compressed values.
3972 (sub_char_table_set): New arg is_uniprop. Callers changed.
3973 Uncompress the compressed values.
3974 (sub_char_table_set_range): Args changed. Callers changed.
3975 (char_table_set_range): Adjuted for the above change.
3976 (map_sub_char_table): Delete args default_val and parent. Add arg
3977 top. Give decoded values to a Lisp function.
3978 (map_char_table): Adjust for the above change. Give decoded
3979 values to a Lisp function. Gcpro more variables.
3980 (uniprop_table_uncompress)
3981 (uniprop_decode_value_run_length): New functions.
3982 (uniprop_decoder, uniprop_decoder_count): New variables.
3983 (uniprop_get_decoder, uniprop_encode_value_character)
3984 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3985 New functions.
3986 (uniprop_encoder, uniprop_encoder_count): New variables.
3987 (uniprop_get_encoder, uniprop_table)
3988 (Funicode_property_table_internal, Fget_unicode_property_internal)
3989 (Fput_unicode_property_internal): New functions.
3990 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3991 Sunicode_property_table_internal, Sget_unicode_property_internal,
3992 and Sput_unicode_property_internal. Defvar_lisp
3993 char-code-property-alist.
3995 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3996 Vunicode_category_table.
3998 * font.c (font_range): Adjust for the change of
3999 Vunicode_category_table.
4001 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4003 * m/iris4d.h: Remove file, move contents ...
4004 * s/irix6-5.h: ... here.
4006 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4008 Remove unportable assumption about struct layout (Bug#8884).
4009 * alloc.c (mark_buffer):
4010 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4011 (clone_per_buffer_values): Don't assume that
4012 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4013 This isn't true in general, and it's particularly not true
4014 if Emacs is configured with --with-wide-int.
4015 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4016 New macros, used in the buffer.c change.
4018 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4020 * xsettings.c: Use both GConf and GSettings if both are available.
4021 (store_config_changed_event): Add comment.
4022 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4023 (store_tool_bar_style_changed): New functions.
4024 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4025 (struct xsettings): Move font inside HAVE_XFT.
4026 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4027 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4028 Move inside HAVE_XFT.
4029 (something_changed_gsettingsCB): Rename from something_changedCB.
4030 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4031 also.
4032 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4033 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4034 (something_changed_gconfCB): Rename from something_changedCB.
4035 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4036 (parse_settings): Move check for font inside HAVE_XFT.
4037 (read_settings, apply_xft_settings): Add comment.
4038 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4039 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4040 call store_font_name_changed.
4041 (xft_settings_event): Add comment.
4042 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4043 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4044 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4045 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4046 (xsettings_initialize): Call init_gsettings last.
4047 (xsettings_get_system_font, xsettings_get_system_normal_font):
4048 Add comment.
4050 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4052 Random fixes. E.g., (random) never returned negative values.
4053 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4054 subseconds part to the entropy, as that's a bit more random.
4055 Prefer signed to unsigned, since the signedness doesn't matter and
4056 in general we prefer signed. When given a limit, use a
4057 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4058 latter isn't right if USE_2_TAGS_FOR_INTS.
4059 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4060 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4062 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4064 * textprop.c (text_property_stickiness):
4065 Obey Vtext_property_default_nonsticky.
4066 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4067 * w32fns.c (syms_of_w32fns):
4068 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4070 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4072 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4073 This is more efficient than Ffile_directory_p and avoids a minor race.
4075 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4077 * buffer.c (Foverlay_put): Say what the return value is
4078 (bug#7835).
4080 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4081 is a directory before asking whether to use the file name
4082 (bug#7564).
4083 (barf_or_query_if_file_exists): Make the "File is a directory"
4084 error be more correct.
4086 * fns.c (Frequire): Remove the mention of the .gz files, since
4087 that's installation-specific, but keep the mention of
4088 `get-load-suffixes'.
4090 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4092 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4093 Report string overflow if the output is too long.
4095 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4097 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4098 (syms_of_gnutls): Remove duplicate DEFSYM for
4099 Qgnutls_bootprop_verify_hostname_error, an error for
4100 Qgnutls_bootprop_verify_error (which is no longer used).
4102 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4103 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4104 Also (re)move comments that are misplaced or no longer relevant.
4106 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4108 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4110 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4112 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4113 and background color parameters if they have been changed.
4115 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4117 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4119 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4121 * xsettings.c (SYSTEM_FONT): Define only when used.
4122 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4124 * keymap.c (access_keymap_1): Now static.
4126 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4128 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4129 leave any prefix arg for the up event (Bug#1586).
4131 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133 * lread.c (syms_of_lread): Mention single symbols defined by
4134 `defvar' or `defconst' (bug#7154).
4136 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4137 (Frequire): Mention get-load-suffixes.
4139 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4141 * window.h (window): Remove clone_number slot.
4142 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4143 Remove.
4144 (make_parent_window, make_window, saved_window)
4145 (Fset_window_configuration, save_window_save): Don't deal with
4146 clone numbers.
4147 * buffer.c (Qclone_number): Remove declaration.
4148 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4150 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4152 Add multiple inheritance to keymaps.
4153 * keymap.c (Fmake_composed_keymap): New function.
4154 (Fset_keymap_parent): Simplify.
4155 (fix_submap_inheritance): Remove.
4156 (access_keymap_1): New function extracted from access_keymap to handle
4157 embedded parents and handle lists of maps.
4158 (access_keymap): Use it.
4159 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4160 (Fcopy_keymap): Handle embedded parents.
4161 (Fcommand_remapping, define_as_prefix): Simplify.
4162 (Fkey_binding): Simplify.
4163 (syms_of_keymap): Move minibuffer-local-completion-map,
4164 minibuffer-local-filename-completion-map,
4165 minibuffer-local-must-match-map, and
4166 minibuffer-local-filename-must-match-map to Elisp.
4167 (syms_of_keymap): Defsubr make-composed-keymap.
4168 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4169 (parse_menu_item): Trivial simplification.
4171 2011-07-01 Glenn Morris <rgm@gnu.org>
4173 * Makefile.in (SETTINGS_LIBS): Fix typo.
4175 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4177 * coding.c (Fencode_coding_string): Record the last coding system
4178 used, as the function doc string says (bug#8738).
4180 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4182 * xsettings.c (store_monospaced_changed): Take new font as arg and
4183 check for change against current_mono_font.
4184 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4185 (emacs_settings_constructor, emacs_settings_get_property)
4186 (emacs_settings_set_property, emacs_settings_class_init)
4187 (emacs_settings_init, gsettings_obj): Remove.
4188 (something_changedCB): New function for HAVE_GSETTINGS.
4189 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4190 with value as argument.
4191 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4192 g_settings_new (Bug#8967). Do not create gsettings_obj.
4193 Remove calls to g_settings_bind. Connect something_changedCB to
4194 "changed".
4196 * xgselect.c: Add defined (HAVE_GSETTINGS).
4197 (xgselect_initialize): Ditto.
4199 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4200 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4201 xg_select.
4203 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4205 * eval.c (struct backtrace): Simplify and port the data structure.
4206 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4207 signed bit field, as this assumption is not portable and it makes
4208 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4209 "char debug_on_exit : 1" as this is not portable either; instead,
4210 use the portable "unsigned int debug_on_exit : 1". Remove unused
4211 member evalargs. Remove obsolete comments about cc bombing out.
4213 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4215 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4216 Let HAVE_GSETTINGS override HAVE_GCONF.
4217 (store_monospaced_changed): New function.
4218 (EMACS_SETTINGS): A new type derived from GObject to handle
4219 GSettings notifications.
4220 (emacs_settings_constructor, emacs_settings_get_property)
4221 (emacs_settings_set_property, emacs_settings_class_init):
4222 New functions.
4223 (gsettings_client, gsettings_obj): New variables.
4224 (GSETTINGS_SCHEMA): New define.
4225 (something_changedCB): Call store_monospaced_changed.
4226 (init_gsettings): New function.
4227 (xsettings_initialize): Call init_gsettings.
4228 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4229 to NULL.
4231 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4232 GCONF_CFLAGS/LIBS.
4234 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4236 * window.c (resize_root_window, grow_mini_window)
4237 (shrink_mini_window): Rename Qresize_root_window to
4238 Qwindow_resize_root_window and Qresize_root_window_vertically to
4239 Qwindow_resize_root_window_vertically.
4241 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4243 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4245 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4247 * makefile.w32-in: Redesign dependencies so they reflect more
4248 clearly which files are directly included by each source file,
4249 and not through other includes.
4251 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4253 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4254 (sort_overlays, overlay_strings): When an overlay's clone number
4255 matches the window's clone number process the overlay even if
4256 the overlay's window property doesn't match the current window.
4258 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4259 (Fwindow_hchild): Rename to Fwindow_left_child.
4260 (Fwindow_next): Rename to Fwindow_next_sibling.
4261 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4262 (resize_window_check): Rename to window_resize_check.
4263 (resize_window_apply): Rename to window_resize_apply.
4264 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4265 (Fdelete_other_windows_internal, resize_frame_windows)
4266 (Fsplit_window_internal, Fdelete_window_internal)
4267 (grow_mini_window, shrink_mini_window)
4268 (Fresize_mini_window_internal): Fix callers accordingly.
4270 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4272 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4273 (emacs_fixed_set_min_size): Remove.
4274 (emacs_fixed_new): Take frame as argument.
4276 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4277 (_EmacsFixedPrivate): Remove minwidth/height.
4278 Add struct frame *f.
4279 (emacs_fixed_init): Initialize priv->f.
4280 (get_parent_class, emacs_fixed_set_min_size): Remove.
4281 (emacs_fixed_new): Set priv->f to argument.
4282 (emacs_fixed_get_preferred_width)
4283 (emacs_fixed_get_preferred_height): Use min_width/height from
4284 frames size_hint to set minimum and natural (Bug#8919).
4285 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4286 and use min_width/height from frames size_hint to set
4287 min_width/height (Bug#8919).
4289 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4290 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4291 Fix indentation.
4293 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4295 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4296 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4297 called at ZV.
4299 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4301 * process.c (wait_reading_process_output): Bypass select if
4302 waiting for a cell while ignoring keyboard input, and input is
4303 pending. Suggested by Jan Djärv (Bug#8869).
4305 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4307 Use gnulib's dup2 module instead of rolling our own.
4308 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4310 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4312 * dispnew.c (scrolling_window): Before scrolling, turn off a
4313 mouse-highlight in the window being scrolled.
4315 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4317 Move DEFSYM to lisp.h and use everywhere.
4319 * character.h (DEFSYM): Move declaration...
4320 * lisp.h (DEFSYM): ...here.
4322 * gnutls.c:
4323 * minibuf.c:
4324 * w32menu.c:
4325 * w32proc.c:
4326 * w32select.c: Don't include character.h.
4328 * alloc.c (syms_of_alloc):
4329 * buffer.c (syms_of_buffer):
4330 * bytecode.c (syms_of_bytecode):
4331 * callint.c (syms_of_callint):
4332 * casefiddle.c (syms_of_casefiddle):
4333 * casetab.c (init_casetab_once):
4334 * category.c (init_category_once, syms_of_category):
4335 * ccl.c (syms_of_ccl):
4336 * cmds.c (syms_of_cmds):
4337 * composite.c (syms_of_composite):
4338 * dbusbind.c (syms_of_dbusbind):
4339 * dired.c (syms_of_dired):
4340 * dispnew.c (syms_of_display):
4341 * doc.c (syms_of_doc):
4342 * editfns.c (syms_of_editfns):
4343 * emacs.c (syms_of_emacs):
4344 * eval.c (syms_of_eval):
4345 * fileio.c (syms_of_fileio):
4346 * fns.c (syms_of_fns):
4347 * frame.c (syms_of_frame):
4348 * fringe.c (syms_of_fringe):
4349 * insdel.c (syms_of_insdel):
4350 * keymap.c (syms_of_keymap):
4351 * lread.c (init_obarray, syms_of_lread):
4352 * macros.c (syms_of_macros):
4353 * msdos.c (syms_of_msdos):
4354 * print.c (syms_of_print):
4355 * process.c (syms_of_process):
4356 * search.c (syms_of_search):
4357 * sound.c (syms_of_sound):
4358 * syntax.c (init_syntax_once, syms_of_syntax):
4359 * terminal.c (syms_of_terminal):
4360 * textprop.c (syms_of_textprop):
4361 * undo.c (syms_of_undo):
4362 * w32.c (globals_of_w32):
4363 * window.c (syms_of_window):
4364 * xdisp.c (syms_of_xdisp):
4365 * xfaces.c (syms_of_xfaces):
4366 * xfns.c (syms_of_xfns):
4367 * xmenu.c (syms_of_xmenu):
4368 * xsettings.c (syms_of_xsettings):
4369 * xterm.c (syms_of_xterm): Use DEFSYM.
4371 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4373 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4375 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4377 Integer and buffer overflow fixes (Bug#8873).
4379 * print.c (printchar, strout): Check for string overflow.
4380 (PRINTPREPARE, printchar, strout):
4381 Don't set size unless allocation succeeds.
4383 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4384 for sizes. Check for string overflow more accurately.
4385 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4387 * macros.c: Integer and buffer overflow fixes.
4388 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4389 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4390 Use ptrdiff_t, not int, for sizes.
4391 Don't increment bufsize until after realloc succeeds.
4392 Check for size-calculation overflow.
4393 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4395 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4397 * lread.c: Integer overflow fixes.
4398 (read_integer): Radix is now EMACS_INT, not int,
4399 to improve quality of diagnostics for out-of-range radices.
4400 Calculate buffer size correctly for out-of-range radices.
4401 (read1): Check for integer overflow in radices, and in
4402 read-circle numbers.
4403 (read_escape): Avoid int overflow.
4404 (Fload, openp, read_buffer_size, read1)
4405 (substitute_object_recurse, read_vector, read_list, map_obarray):
4406 Use ptrdiff_t, not int, for sizes.
4407 (read1): Use EMACS_INT, not int, for sizes.
4408 Check for size overflow.
4410 * image.c (cache_image): Check for size arithmetic overflow.
4412 * lread.c: Integer overflow issues.
4413 (saved_doc_string_size, saved_doc_string_length)
4414 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4415 Now ptrdiff_t, not int.
4416 (read1): Don't assume doc string length fits in int. Check for
4417 out-of-range doc string lengths.
4418 (read_list): Don't assume file position fits in int.
4419 (read_escape): Check for hex character overflow.
4421 2011-06-22 Leo Liu <sdl.web@gmail.com>
4423 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4424 Move to minibuffer.el.
4426 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4428 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4429 The following patches are for when GLYPH_DEBUG && !XASSERT.
4430 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4431 * dispnew.c (flush_stdout):
4432 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4433 Mark as externally visible.
4434 * dispnew.c (check_window_matrix_pointers): Now static.
4435 * dispnew.c (window_to_frame_vpos):
4436 * xfns.c (unwind_create_frame):
4437 * xterm.c (x_check_font): Remove unused local.
4438 * scroll.c (CHECK_BOUNDS):
4439 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4440 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4441 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4442 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4443 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4444 Now static.
4445 (debug_method_add): Use va_list and vsprintf rather than relying
4446 on undefined behavior with wrong number of arguments.
4447 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4448 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4449 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4450 since we're not interested in debugging glyphs with old libraries.
4451 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4452 GCC 4.6.0's static checking.
4454 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4456 Integer overflow and signedness fixes (Bug#8873).
4457 A few related buffer overrun fixes, too.
4459 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4461 * dispextern.h (struct face.stipple):
4462 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4463 (x_bitmap_mask, x_allocate_bitmap_record)
4464 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4465 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4466 (x_create_bitmap_from_xpm_data):
4467 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4468 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4469 (.bitmaps_last):
4470 * xfaces.c (load_pixmap):
4471 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4472 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4473 (.bitmaps_last, struct x_output.icon_bitmap):
4474 Use ptrdiff_t, not int, for bitmap indexes.
4475 (x_allocate_bitmap_record): Check for size overflow.
4476 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4478 Use ptrdiff_t, not int, for overlay counts.
4479 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4480 * editfns.c (overlays_around, get_pos_property):
4481 * textprop.c (get_char_property_and_overlay):
4482 * xdisp.c (next_overlay_change, note_mouse_highlight):
4483 * xfaces.c (face_at_buffer_position):
4484 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4485 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4486 (Fnext_overlay_change, Fprevious_overlay_change)
4487 (mouse_face_overlay_overlaps, Foverlays_in):
4488 Use ptrdiff_t, not int, for sizes.
4489 (overlays_at, overlays_in): Check for size-calculation overflow.
4491 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4493 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4494 (x_session_initialize): Do not assume string length fits in int.
4496 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4497 This is unlikely, but can occur if DPI is outlandish.
4499 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4500 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4502 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4503 * xrdb.c (magic_file_p, search_magic_path):
4504 Omit last arg SUFFIX; it was always 0. All callers changed.
4505 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4507 * xfont.c (xfont_match): Avoid need for strlen.
4509 * xfns.c: Don't assume strlen fits in int.
4510 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4512 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4513 not unsigned long, as we prefer signed integers. All callers changed.
4514 Detect integer overflow in repeat count.
4515 (message_dolog): Don't assume print length fits in 39 bytes.
4516 (display_mode_element): Don't assume strlen fits in int.
4518 * termcap.c: Don't assume sizes fit in int and never overflow.
4519 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4520 (gobble_line): Check for size-calculation overflow.
4522 * minibuf.c (Fread_buffer):
4523 * lread.c (intern, intern_c_string):
4524 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4525 Don't assume string length fits in int.
4527 * keyboard.c (parse_tool_bar_item):
4528 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4530 * font.c: Don't assume string length fits in int.
4531 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4532 Use ptrdiff_t, not int.
4533 (font_intern_prop): Don't assume string length fits in int.
4534 Don't assume integer property fits in fixnum.
4535 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4537 * filelock.c: Fix some buffer overrun and integer overflow issues.
4538 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4539 Reformulate so as not to need the command string.
4540 Invoke gzip -cd rather than gunzip, as it's more portable.
4541 (lock_info_type, lock_file_1, lock_file):
4542 Don't assume pid_t and time_t fit in unsigned long.
4543 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4544 (current_lock_owner): Prefer signed type for sizes.
4545 Use memcpy, not strncpy, where memcpy is what is really wanted.
4546 Don't assume (via atoi) that time_t and pid_t fit in int.
4547 Check for time_t and/or pid_t out of range, e.g., via a network share.
4548 Don't alloca where an auto var works fine.
4550 * fileio.c: Fix some integer overflow issues.
4551 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4552 Don't assume string length fits in int.
4553 (directory_file_name): Don't assume string length fits in long.
4554 (make_temp_name): Don't assume pid fits in int, or that its print
4555 length is less than 20.
4557 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4559 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4561 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4563 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4564 We prefer signed integers, even for size calculations.
4566 * emacs.c: Don't assume string length fits in 'int'.
4567 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4568 (main): Don't invoke strlen when not needed.
4570 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4571 (XD_DEBUG_MESSAGE): Don't waste a byte.
4573 * callproc.c (getenv_internal_1, getenv_internal)
4574 (Fgetenv_internal):
4575 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4577 * lread.c (invalid_syntax): Omit length argument.
4578 All uses changed. This doesn't fix a bug, but it simplifies the
4579 code away from its former Hollerith-constant appearance, and it's
4580 one less 'int' to worry about when looking at integer-overflow issues.
4581 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4583 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4584 This didn't break anything, but it didn't help either.
4585 It's confusing to put a bogus integer in a place where the actual
4586 value does not matter.
4587 (LIST_END_P): Remove unused macro and its bogus comment.
4588 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4590 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4591 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4592 implementation.
4593 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4594 We prefer signed types, and the value cannot exceed the EMACS_INT
4595 range anyway (because otherwise the length would not be representable).
4596 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4597 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4598 This avoids a GCC warning when WIDE_EMACS_INT.
4600 * indent.c (sane_tab_width): New function.
4601 (current_column, scan_for_column, Findent_to, position_indentation)
4602 (compute_motion): Use it. This is just for clarity.
4603 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4605 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4607 * lisp.h (lint_assume): New macro.
4608 * composite.c (composition_gstring_put_cache):
4609 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4611 * editfns.c, insdel.c:
4612 Omit unnecessary forward decls, to simplify future changes.
4614 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4616 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4618 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4619 Use much-faster test for byte-length change.
4620 Don't assume string byte-length fits in 'int'.
4621 Check that character arg fits in 'int'.
4622 (mapcar1): Declare byte as byte, for clarity.
4624 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4626 * fns.c (concat): Catch string overflow earlier.
4627 Do not rely on integer wraparound.
4629 * dispextern.h (struct it.overlay_strings_charpos)
4630 (struct it.selective): Now EMACS_INT, not int.
4631 * xdisp.c (forward_to_next_line_start)
4632 (back_to_previous_visible_line_start)
4633 (reseat_at_next_visible_line_start, next_element_from_buffer):
4634 Don't arbitrarily truncate the value of 'selective' to int.
4636 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4638 * composite.c: Don't truncate sizes to 'int'.
4639 (composition_gstring_p, composition_reseat_it)
4640 (composition_adjust_point): Use EMACS_INT, not int.
4641 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4642 not EMACS_UINT, for indexes.
4644 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4646 * buffer.c: Include <verify.h>.
4647 (struct sortvec.priority, struct sortstr.priority):
4648 Now EMACS_INT, not int.
4649 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4650 (struct sortstr.size, record_overlay_string)
4651 (struct sortstrlist.size, struct sortlist.used):
4652 Don't truncate size to int.
4653 (record_overlay_string): Check for size-calculation overflow.
4654 (init_buffer_once): Check at compile-time, not run-time.
4656 2011-06-22 Jim Meyering <meyering@redhat.com>
4658 Don't leak an XBM-image-sized buffer
4659 * image.c (xbm_load): Free the image buffer after using it.
4661 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4663 Port to Sun C.
4664 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4665 that Sun C diagnosed.
4666 * fns.c (secure_hash): Fix pointer signedness issue.
4667 * intervals.c (static_offset_intervals): New function.
4668 (offset_intervals): Use it.
4670 2011-06-21 Leo Liu <sdl.web@gmail.com>
4672 * deps.mk (fns.o):
4673 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4674 sha512.h.
4676 * fns.c (secure_hash): Rename from crypto_hash_function and change
4677 the first arg to accept symbols.
4678 (Fsecure_hash): New primitive.
4679 (syms_of_fns): New symbols.
4681 2011-06-20 Deniz Dogan <deniz@dogan.se>
4683 * process.c (Fset_process_buffer): Clarify return value in
4684 docstring.
4686 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4688 * dispnew.c (add_window_display_history): Use BVAR.
4690 * xdisp.c (debug_method_add): Use BVAR.
4691 (check_window_end, dump_glyph_matrix, dump_glyph)
4692 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4694 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4695 Likewise.
4697 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4698 check till after the cache is created in init_frame_faces.
4700 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4702 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4704 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4706 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4707 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4708 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4710 Improve buffer-overflow checking (Bug#8873).
4711 * fileio.c (Finsert_file_contents):
4712 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4713 Remove the old (too-loose) buffer overflow checks.
4714 They weren't needed, since make_gap checks for buffer overflow.
4715 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4716 The old code merely checked for Emacs fixnum overflow, and relied
4717 on undefined (wraparound) behavior. The new code avoids undefined
4718 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4720 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4721 Tune. Don't use wider integers than needed. Don't use alloca.
4722 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4724 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4726 * insdel.c, lisp.h (buffer_overflow): New function.
4727 (insert_from_buffer_1, replace_range, replace_range_2):
4728 * insdel.c (make_gap_larger):
4729 * editfns.c (Finsert_char):
4730 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4732 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4734 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4736 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4738 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4739 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4741 * fileio.c: Don't assume EMACS_INT fits in off_t.
4742 (emacs_lseek): New static function.
4743 (Finsert_file_contents, Fwrite_region): Use it.
4744 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4746 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4748 * fns.c: Don't overflow int when computing a list length.
4749 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4750 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4751 truncation on 64-bit hosts. Check for QUIT every
4752 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4753 faster and is responsive enough.
4754 (Flength): Report an error instead of overflowing an integer.
4755 (Fsafe_length): Return a float if the value is not representable
4756 as a fixnum. This shouldn't happen except in contrived situations.
4757 (Fnthcdr, Fsort): Don't assume list length fits in int.
4758 (Fcopy_sequence): Don't assume vector length fits in int.
4760 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4761 (header_size, word_size): New constants.
4762 (allocate_vectorlike): Don't check size overflow here.
4763 (allocate_vector): Check it here instead, since this is the only
4764 caller of allocate_vectorlike that could cause overflow.
4765 Check that the new vector's length is representable as a fixnum.
4767 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4768 The previous code was bogus. For example, next_almost_prime (32)
4769 returned 39, which is undesirable as it is a multiple of 3; and
4770 next_almost_prime (24) returned 25, which is a multiple of 5 so
4771 why was the code bothering to check for multiples of 7?
4773 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4775 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4777 Variadic C functions now count arguments with ptrdiff_t.
4778 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4779 Back then I didn't know that the Emacs coding style prefers signed int.
4780 Also, in the meantime I found a few more instances where arguments
4781 were being counted with int, which may truncate counts on 64-bit
4782 machines, or EMACS_INT, which may be unnecessarily wide.
4783 * lisp.h (struct Lisp_Subr.function.aMANY)
4784 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4785 Arg counts are now ptrdiff_t, not size_t.
4786 All variadic functions and their callers changed accordingly.
4787 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4788 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4789 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4790 * callint.c (Fcall_interactively): Check arg count for overflow,
4791 to avoid potential buffer overrun. Use signed char, not 'int',
4792 for 'varies' array, so that we needn't bother to check its size
4793 calculation for overflow.
4794 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4795 * eval.c (apply_lambda):
4796 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4797 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4798 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4800 * callint.c (Fcall_interactively): Don't use index var as event count.
4802 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4803 * mem-limits.h (SIZE): Remove; no longer used.
4805 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4807 Remove unnecessary casts.
4808 * xterm.c (x_term_init):
4809 * xfns.c (x_set_border_pixel):
4810 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4811 These aren't needed now that we assume ANSI C.
4813 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4814 It's more likely to cause problems (due to unsigned overflow)
4815 than to cure them.
4817 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4819 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4821 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4823 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4825 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4827 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4829 GLYPH_CODE_FACE returns EMACS_INT, not int.
4830 * dispextern.h (merge_faces):
4831 * xfaces.c (merge_faces):
4832 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4833 Don't assume EMACS_INT fits in int.
4835 * character.h (CHAR_VALID_P): Remove unused parameter.
4836 * fontset.c, lisp.h, xdisp.c: All uses changed.
4838 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4840 * fns.c (concat): Minor tuning based on overflow analysis.
4841 This doesn't fix any bugs. Use int to hold character, instead
4842 of constantly refetching from Emacs object. Use XFASTINT, not
4843 XINT, for value known to be a character. Don't bother comparing
4844 a single byte to 0400, as it's always less.
4846 * floatfns.c (Fexpt):
4847 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4849 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4850 for characters.
4852 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4854 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4855 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4856 incorrectly succeed when S was a string, because 4294967386 was
4857 truncated before it was used.
4859 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4860 Otherwise, an out-of-range integer could cause undefined behavior
4861 on a 64-bit host.
4863 * composite.c: Use int, not EMACS_INT, for characters.
4864 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4865 EMACS_INT, for values that are known to be in character range.
4866 This doesn't fix any bugs but is the usual style inside Emacs and
4867 may generate better code on 32-bit machines.
4869 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4870 This is for reasons similar to the recent CHAR_STRING fix.
4871 * charset.c (Fencode_char): Check that character arg is actually
4872 a character. Pass an int to ENCODE_CHAR.
4873 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4874 wider than 'int', as a compile-time check to prevent future regressions
4875 in this area.
4877 * character.c (char_string): Remove unnecessary casts.
4879 Make sure a 64-bit char is never passed to CHAR_STRING.
4880 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4881 by silently ignoring the top 32 bits, allowing some values
4882 that were far too large to be valid characters.
4883 * character.h: Include <verify.h>.
4884 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4885 arguments are no wider than unsigned, as a compile-time check
4886 to prevent future regressions in this area.
4887 * data.c (Faset):
4888 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4889 (Fsubst_char_in_region):
4890 * fns.c (concat):
4891 * xdisp.c (decode_mode_spec_coding):
4892 Adjust to CHAR_STRING's new requirement.
4893 * editfns.c (Finsert_char, Fsubst_char_in_region):
4894 * fns.c (concat): Check that character args are actually
4895 characters. Without this test, these functions did the wrong
4896 thing with wildly out-of-range values on 64-bit hosts.
4898 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4899 These casts should not be needed on 32-bit hosts, either.
4900 * keyboard.c (read_char):
4901 * lread.c (Fload): Remove casts to unsigned.
4903 * lisp.h (UNSIGNED_CMP): New macro.
4904 This fixes comparison bugs on 64-bit hosts.
4905 (ASCII_CHAR_P): Use it.
4906 * casefiddle.c (casify_object):
4907 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4908 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4909 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4910 * dispextern.h (FACE_FROM_ID):
4911 * keyboard.c (read_char): Use UNSIGNED_CMP.
4913 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4914 not to EMACS_INT, to avoid GCC warning.
4916 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4918 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4919 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4920 isn't needed on 32-bit machines.
4922 * buffer.c (Fgenerate_new_buffer_name):
4923 Use EMACS_INT for count, not int.
4924 (advance_to_char_boundary): Return EMACS_INT, not int.
4926 * data.c (Qcompiled_function): Now static.
4928 * window.c (window_body_lines): Now static.
4930 * image.c (gif_load): Rename local to avoid shadowing.
4932 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4933 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4934 * alloc.c (make_save_value): Integer argument is now of type
4935 ptrdiff_t, not int.
4936 (mark_object): Use ptrdiff_t, not int.
4937 * lisp.h (pD): New macro.
4938 * print.c (print_object): Use it.
4940 * alloc.c: Use EMACS_INT, not int, to count objects.
4941 (total_conses, total_markers, total_symbols, total_vector_size)
4942 (total_free_conses, total_free_markers, total_free_symbols)
4943 (total_free_floats, total_floats, total_free_intervals)
4944 (total_intervals, total_strings, total_free_strings):
4945 Now EMACS_INT, not int. All uses changed.
4946 (Fgarbage_collect): Compute overall total using a double, so that
4947 integer overflow is less likely to be a problem. Check for overflow
4948 when converting back to an integer.
4949 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4950 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4951 These were 'int' variables that could overflow on 64-bit hosts;
4952 they were never used, so remove them instead of repairing them.
4953 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4954 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4955 Previously, this ceilinged at INT_MAX, but that doesn't work on
4956 64-bit machines.
4957 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4959 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4960 (allocate_vectorlike): Check for ptrdiff_t overflow.
4961 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4962 when a (possibly-narrower) signed value would do just as well.
4963 We prefer using signed arithmetic, to avoid comparison confusion.
4965 * alloc.c: Catch some string size overflows that we were missing.
4966 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4967 for convenience in STRING_BYTES_MAX.
4968 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4969 The definition here is exact; the one in lisp.h was approximate.
4970 (allocate_string_data): Check for string overflow. This catches
4971 some instances we weren't catching before. Also, it catches
4972 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4973 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4974 and ptrdiff_t and EMACS_INT are both 64 bits.
4976 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4977 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4978 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4980 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4982 * alloc.c (Fmake_string): Check for out-of-range init.
4984 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4986 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4988 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4990 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4991 xg_get_default_scrollbar_width.
4993 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4994 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4995 (style_changed_cb): Call update_theme_scrollbar_width and call
4996 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4997 all frames (Bug#8505).
4998 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4999 Call gtk_window_set_resizable if HAVE_GTK3.
5000 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5001 and height if HAVE_GTK3 (Bug#8505).
5002 (scroll_bar_width_for_theme): New variable.
5003 (update_theme_scrollbar_width): New function.
5004 (xg_get_default_scrollbar_width): Move code to
5005 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5006 (xg_initialize): Call update_theme_scrollbar_width.
5008 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5010 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5012 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5014 * frame.c (make_frame): Call other_buffer_safely instead of
5015 other_buffer.
5017 * window.c (temp_output_buffer_show): Call display_buffer with
5018 second argument Vtemp_buffer_show_specifiers and reset latter
5019 immediately after the call.
5020 (Vtemp_buffer_show_specifiers): New variable.
5021 (auto_window_vscroll_p, next_screen_context_lines)
5022 (Vscroll_preserve_screen_position): Remove leading asterisks from
5023 doc-strings.
5025 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5027 Fix minor problems found by GCC 4.6.0 static checking.
5028 * buffer.c (Qclone_number): Remove for now, as it's unused.
5029 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5030 (record_buffer): Remove unused local.
5031 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5032 (set_frame_buffer_list): Remove; unused.
5033 * frame.h (other_visible_frames): Remove decl.
5034 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5035 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5036 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5037 if HAVE_GPM.
5038 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5039 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5040 Define only if HAVE_GPM.
5041 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5042 (update_hints_inhibit): Remove; never set. All uses removed.
5043 * widgetprv.h (emacsFrameClassRec): Remove decl.
5044 * window.c (delete_deletable_window): Now returns void, since it
5045 wasn't returning anything.
5046 (compare_window_configurations): Remove unused locals.
5047 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5048 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5049 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5050 the same widths as pointers. This follows up on the 2011-05-06 patch.
5051 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5052 * xterm.h: Likewise.
5053 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5055 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5057 * makefile.w32-in: Update dependencies.
5058 (LISP_H): Add lib/intprops.h.
5060 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5062 * image.c (gif_load): Add animation frame delay to the metadata.
5063 (syms_of_image): Use DEFSYM. New symbol `delay'.
5065 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5067 * window.c (delete_deletable_window): Re-add.
5068 (Fset_window_configuration): Rewrite to handle dead buffers and
5069 consequently deletable windows.
5070 (window_tree, Fwindow_tree): Remove. Supply functionality in
5071 window.el.
5072 (compare_window_configurations): Simplify code.
5074 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5076 * image.c (imagemagick_load_image): Fix type mismatch.
5077 (Fimagemagick_types): Likewise.
5079 * window.h (replace_buffer_in_windows): Declare.
5081 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5083 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5084 Qclone_number. Remove external declaration of Qdelete_window.
5085 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5086 code.
5087 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5088 Run Qbuffer_list_update_hook if allowed.
5089 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5090 buffer list implementation.
5091 (other_buffer_safely): New function.
5092 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5093 calls to replace_buffer_in_windows and
5094 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5095 if allowed.
5096 (record_buffer): Inhibit quitting and rewrite using quittable
5097 functions. Run Qbuffer_list_update_hook if allowed.
5098 (Frecord_buffer, Funrecord_buffer): New functions.
5099 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5100 Move switch-to-buffer to window.el.
5101 (bury-buffer): Move to window.el.
5102 (Vbuffer_list_update_hook): New variable.
5104 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5105 section.
5107 * window.h (resize_frame_windows): Move up in code.
5108 (Fwindow_frame): Remove EXFUN.
5109 (replace_buffer_in_all_windows): Remove prototype.
5110 (replace_buffer_in_windows_safely): Add prototype.
5112 * window.c: Declare Qdelete_window static again. Move down
5113 declaration of select_count.
5114 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5115 (Fother_window): Move to window.el.
5116 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5117 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5118 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5119 window.el.
5120 (replace_buffer_in_windows): Implement by calling
5121 Qreplace_buffer_in_windows.
5122 (replace_buffer_in_all_windows): Remove with some functionality
5123 moved into replace_buffer_in_windows_safely.
5124 (replace_buffer_in_windows_safely): New function.
5125 (select_window_norecord, select_frame_norecord): Move in front
5126 of run_window_configuration_change_hook. Remove now obsolete
5127 declarations.
5128 (Fset_window_buffer): Rewrite doc-string.
5129 Call Qrecord_window_buffer.
5130 (keys_of_window): Move binding for other-window to window.el.
5132 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5134 * dispextern.h (struct image): Replace data member, whose int_val
5135 and ptr_val fields were not used by anything, with a single
5136 lisp_val object.
5138 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5139 (gif_clear_image, gif_load, imagemagick_load_image)
5140 (gs_clear_image, gs_load): Callers changed.
5142 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5144 * buffer.h: Include <time.h>, for time_t.
5145 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5147 Fix minor problems found by static checking.
5149 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5151 Make identifiers static if they are not used in other modules.
5152 * data.c (Qcompiled_function, Qframe, Qvector):
5153 * image.c (QimageMagick, Qsvg):
5154 * minibuf.c (Qmetadata):
5155 * window.c (resize_window_check, resize_root_window): Now static.
5156 * window.h (resize_window_check, resize_root_window): Remove decls.
5158 * window.c (window_deletion_count, delete_deletable_window):
5159 Remove; unused.
5160 (window_body_lines): Now static.
5161 (Fdelete_other_windows_internal): Mark vars as initialized.
5162 Make sure 'resize_failed' is initialized.
5163 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5164 (resize_window_apply): Remove unused local.
5165 * window.h (delete_deletable_window): Remove decl.
5167 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5168 (imagemagick_load_image): Fix pointer signedness problem by changing
5169 last arg from unsigned char * to char *. All uses changed.
5170 Also, fix a local for similar reasons.
5171 Remove unused locals. Remove locals to avoid shadowing.
5172 (fn_rsvg_handle_free): Remove; unused.
5173 (svg_load, svg_load_image): Fix pointer signedness problem.
5174 (imagemagick_load_image): Don't use garbage pointer image_wand.
5176 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5178 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5180 * image.c (gif_load): Fix omitted cast error introduced by
5181 2011-06-06 change.
5183 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5185 * window.h (resize_proportionally, orig_total_lines)
5186 (orig_top_line): Remove from window structure.
5187 (set_window_height, set_window_width, change_window_heights)
5188 (Fdelete_window): Remove prototypes.
5189 (resize_frame_windows): Remove duplicate declaration.
5191 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5193 * window.h (resize_frame_windows, resize_window_check)
5194 (delete_deletable_window, resize_root_window)
5195 (resize_frame_windows): Declare prototypes.
5197 * window.c (resize_window_apply): Make definition be "static" to
5198 match the prototype.
5200 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5202 * window.c: Remove declarations of Qwindow_size_fixed,
5203 window_min_size_1, window_min_size_2, window_min_size,
5204 size_window, window_fixed_size_p, enlarge_window, delete_window.
5205 Remove static from declaration of Qdelete_window, it's
5206 temporarily needed by Fbury_buffer.
5207 (replace_window): Don't assign orig_top_line and
5208 orig_total_lines.
5209 (Fdelete_window, delete_window): Remove. Window deletion is
5210 handled by window.el.
5211 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5212 Replace Fdelete_window calls with calls to Qdelete_window.
5213 (Fdelete_other_windows): Remove. Deleting other windows is
5214 handled by window.el.
5215 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5216 handled in window.el.
5217 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5218 Window minimum sizes are handled in window.el.
5219 (shrink_windows, size_window, set_window_height)
5220 (set_window_width, change_window_heights, window_height)
5221 (window_width, CURBEG, CURSIZE, enlarge_window)
5222 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5223 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5224 handled in window.el.
5225 (make_dummy_parent): Rename to make_parent_window and give it a
5226 second argument horflag.
5227 (make_window): Don't set resize_proportionally any more.
5228 (Fsplit_window): Remove. Windows are split in window.el.
5229 (save_restore_action, save_restore_orig_size)
5230 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5231 Resize mini windows in window.el.
5232 (grow_mini_window, shrink_mini_window): Implement by calling
5233 Qresize_root_window_vertically, resize_window_check and
5234 resize_window_apply.
5235 (saved_window, Fset_window_configuration, save_window_save):
5236 Do not handle orig_top_line, orig_total_lines, and
5237 resize_proportionally.
5238 (window_min_height, window_min_width): Move to window.el.
5239 (keys_of_window): Move bindings for delete-other-windows,
5240 split-window, delete-window and enlarge-window to window.el.
5242 * buffer.c: Temporarily extern Qdelete_window.
5243 (Fbury_buffer): Temporarily call Qdelete_window instead of
5244 Fdelete_window (Fbury_buffer will move to window.el soon).
5246 * frame.c (set_menu_bar_lines_1): Remove code handling
5247 orig_top_line and orig_total_lines.
5249 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5250 set_window_height but set heights directly.
5251 (change_frame_size_1): Use resize_frame_windows.
5253 * xdisp.c (init_xdisp): Don't use set_window_height but set
5254 heights directly.
5256 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5257 Use resize_frame_windows instead of change_window_heights and run
5258 run_window_configuration_change_hook.
5260 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5261 instead of change_window_heights and run
5262 run_window_configuration_change_hook.
5264 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5266 * window.c (replace_window): Rename second argument REPLACEMENT to
5267 NEW. New third argument SETFLAG. Rewrite.
5268 (delete_window, make_dummy_parent): Call replace_window with
5269 third argument 1.
5270 (window_list_1): Move down in code.
5271 (run_window_configuration_change_hook): Move set_buffer part
5272 before select_frame_norecord part in order to unwind correctly.
5273 Rename count1 to count.
5274 (recombine_windows, delete_deletable_window, resize_root_window)
5275 (Fdelete_other_windows_internal)
5276 (Frun_window_configuration_change_hook, make_parent_window)
5277 (resize_window_check, resize_window_apply, Fresize_window_apply)
5278 (resize_frame_windows, Fsplit_window_internal)
5279 (Fdelete_window_internal, Fresize_mini_window_internal):
5280 New functions.
5281 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5283 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5285 * window.h (window): Add some new members to window structure -
5286 normal_lines, normal_cols, new_total, new_normal, clone_number,
5287 splits, nest, prev_buffers, next_buffers.
5288 (WINDOW_TOTAL_SIZE): Move here from window.c.
5289 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5291 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5292 Remove.
5293 (make_dummy_parent): Set new members of windows structure.
5294 (make_window): Move down in code. Handle new members of window
5295 structure.
5296 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5297 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5298 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5299 (Fset_window_prev_buffers, Fwindow_next_buffers)
5300 (Fset_window_next_buffers, Fset_window_clone_number):
5301 New functions.
5302 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5303 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5304 Doc-string fixes.
5305 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5306 Argument WINDOW can be now internal window too.
5307 (Fwindow_use_time): Move up in code.
5308 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5309 Rewrite doc-string.
5310 (Fset_window_configuration, saved_window)
5311 (Fcurrent_window_configuration, save_window_save): Handle new
5312 members of window structure.
5313 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5314 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5315 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5316 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5317 Qget_mru_window, Qresize_root_window,
5318 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5319 Qauto_buffer_name; staticpro them.
5321 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5323 * window.c (Fwindow_total_size, Fwindow_left_column)
5324 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5325 (Fwindow_list_1): New functions.
5326 (window_box_text_cols): Replace with window_body_cols.
5327 (Fwindow_width, Fscroll_left, Fscroll_right):
5328 Use window_body_cols instead of window_box_text_cols.
5329 (delete_window, Fset_window_configuration):
5330 Call delete_all_subwindows with window as argument.
5331 (delete_all_subwindows): Take a window as argument and not a
5332 structure. Rewrite.
5333 (window_loop): Remove handling of GET_LRU_WINDOW and
5334 GET_LARGEST_WINDOW.
5335 (Fget_lru_window, Fget_largest_window): Move to window.el.
5337 * window.h: Extern window_body_cols instead of
5338 window_box_text_cols. delete_all_subwindows now takes a
5339 Lisp_Object as argument.
5341 * indent.c (compute_motion, Fcompute_motion):
5342 Use window_body_cols instead of window_box_text_cols.
5344 * frame.c (delete_frame): Call delete_all_subwindows with root
5345 window as argument.
5347 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5349 * fns.c (Fputhash): Document return value.
5351 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5353 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5355 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5357 Cons<->int and similar integer overflow fixes (Bug#8794).
5359 Check for overflow when converting integer to cons and back.
5360 * charset.c (Fdefine_charset_internal, Fdecode_char):
5361 Use cons_to_unsigned to catch overflow.
5362 (Fencode_char): Use INTEGER_TO_CONS.
5363 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5364 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5365 * data.c (long_to_cons, cons_to_long): Remove.
5366 (cons_to_unsigned, cons_to_signed): New functions.
5367 These signal an error for invalid or out-of-range values.
5368 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5369 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5370 * font.c (Ffont_variation_glyphs):
5371 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5372 * lisp.h: Include <intprops.h>.
5373 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5374 (cons_to_signed, cons_to_unsigned): New decls.
5375 (long_to_cons, cons_to_long): Remove decls.
5376 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5377 (Fprimitive_undo): Use CONS_TO_INTEGER.
5378 * xfns.c (Fx_window_property): Likewise.
5379 * xselect.c: Include <limits.h>.
5380 (x_own_selection, selection_data_to_lisp_data):
5381 Use INTEGER_TO_CONS.
5382 (x_handle_selection_request, x_handle_selection_clear)
5383 (x_get_foreign_selection, Fx_disown_selection_internal)
5384 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5385 (lisp_data_to_selection_data): Use cons_to_unsigned.
5386 (x_fill_property_data): Use cons_to_signed.
5387 Report values out of range.
5389 Check for buffer and string overflow more precisely.
5390 * buffer.h (BUF_BYTES_MAX): New macro.
5391 * lisp.h (STRING_BYTES_MAX): New macro.
5392 * alloc.c (Fmake_string):
5393 * character.c (string_escape_byte8):
5394 * coding.c (coding_alloc_by_realloc):
5395 * doprnt.c (doprnt):
5396 * editfns.c (Fformat):
5397 * eval.c (verror):
5398 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5399 since they may not be the same number.
5400 * editfns.c (Finsert_char):
5401 * fileio.c (Finsert_file_contents):
5402 Likewise for BUF_BYTES_MAX.
5404 * image.c: Use ptrdiff_t, not int, for sizes.
5405 (slurp_file): Switch from int to ptrdiff_t.
5406 All uses changed.
5407 (slurp_file): Check that file size fits in both size_t (for
5408 malloc) and ptrdiff_t (for sanity and safety).
5410 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5411 if b->modtime has its maximal value.
5413 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5415 Don't assume time_t can fit into int.
5416 * buffer.h (struct buffer.modtime): Now time_t, not int.
5417 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5418 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5420 Minor fixes for signed vs unsigned integers.
5421 * character.h (MAYBE_UNIFY_CHAR):
5422 * charset.c (maybe_unify_char):
5423 * keyboard.c (read_char, reorder_modifiers):
5424 XINT -> XFASTINT, since the integer must be nonnegative.
5425 * ftfont.c (ftfont_spec_pattern):
5426 * keymap.c (access_keymap, silly_event_symbol_error):
5427 XUINT -> XFASTINT, since the integer must be nonnegative.
5428 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5429 since it makes no difference and we prefer signed.
5430 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5431 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5432 nonnegative.
5434 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5436 * window.h (Fwindow_frame): Declare.
5438 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5440 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5441 (SPARE_MEMORY): Always define.
5442 (LARGE_REQUEST): Remove.
5443 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5445 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5447 * lisp.h: Move EXFUNS for Fframe_root_window,
5448 Fframe_first_window and Fset_frame_selected_window to window.h.
5450 * window.h: Move EXFUNS for Fframe_root_window,
5451 Fframe_first_window and Fset_frame_selected_window here from
5452 lisp.h.
5454 * frame.c (Fwindow_frame, Fframe_first_window)
5455 (Fframe_root_window, Fframe_selected_window)
5456 (Fset_frame_selected_window): Move to window.c.
5457 (Factive_minibuffer_window): Move to minibuf.c.
5458 (Fother_visible_frames_p): New function.
5460 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5462 * window.c (decode_window, decode_any_window): Move up in code.
5463 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5464 (inhibit_frame_unsplittable): Remove unused variable.
5465 (Fwindow_buffer): Move up and rewrite doc-string.
5466 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5467 (Fwindow_prev): New functions.
5468 (Fwindow_frame): Move here from frame.c. Accept any window as
5469 argument.
5470 (Fframe_root_window, Fframe_first_window)
5471 (Fframe_selected_window): Move here from frame.c. Accept frame
5472 or arbitrary window as argument. Update doc-strings.
5473 (Fminibuffer_window): Move up in code.
5474 (Fwindow_minibuffer_p): Move up in code and simplify.
5475 (Fset_frame_selected_window): Move here from frame.c.
5476 Marginal rewrite.
5477 (Fselected_window, select_window, Fselect_window): Move up in
5478 code. Minor doc-string fixes.
5480 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5482 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5483 Do not assume that spare memory exists; that assumption is valid
5484 only if SYSTEM_MALLOC.
5485 (LARGE_REQUEST): New macro, so that the issue of large requests
5486 is separated from the issue of spare memory.
5488 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5490 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5491 format. (Bug#8806)
5493 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5495 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5496 before statements.
5498 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5500 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5502 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5504 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5505 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5507 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5509 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5511 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5513 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5514 (x_clipboard_manager_save): Add return value.
5515 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5516 New error handlers.
5517 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5518 Obey Vx_select_enable_clipboard_manager. Catch errors in
5519 x_clipboard_manager_save (Bug#8779).
5520 (Vx_select_enable_clipboard_manager): New variable.
5521 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5523 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5525 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5527 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5529 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5530 in the current matrix if keep_current_p is non-zero.
5532 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5534 * bidi.c (bidi_level_of_next_char): Fix last change.
5536 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5538 Support bidi reordering of text covered by display properties.
5540 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5541 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5542 (bidi_cache_search, bidi_cache_iterator_state)
5543 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5544 (bidi_level_of_next_char, bidi_move_to_visually_next):
5545 Support character positions inside a run of characters covered by a
5546 display string.
5547 (bidi_paragraph_init, bidi_resolve_explicit_1)
5548 (bidi_level_of_next_char): Call bidi_fetch_char and
5549 bidi_fetch_char_advance instead of FETCH_CHAR and
5550 FETCH_CHAR_ADVANCE.
5551 (bidi_init_it): Initialize new members.
5552 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5553 definitions.
5554 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5555 instead of using explicit *_CHAR codes.
5556 (bidi_resolve_explicit, bidi_resolve_weak):
5557 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5558 bidirectional text is supported only in multibyte buffers.
5559 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5560 it to initialize the frame_window_p member of struct bidi_it.
5561 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5562 (bidi_resolve_explicit, bidi_resolve_weak)
5563 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5564 bidi_it->nchars is non-positive.
5565 (bidi_level_of_next_char): Don't try to lookup the cache for the
5566 next/previous character if nothing is cached there yet, or if we
5567 were just reseat()'ed to a new position.
5569 * xdisp.c (set_cursor_from_row): Set start and stop points
5570 according to the row's direction when priming the loop that looks
5571 for the glyph on which to display cursor.
5572 (single_display_spec_intangible_p): Function deleted.
5573 (display_prop_intangible_p): Reimplement to call
5574 handle_display_spec instead of single_display_spec_intangible_p.
5575 Accept 3 additional arguments needed by handle_display_spec.
5576 This fixes incorrect cursor motion across display property with complex
5577 values: lists, `(when COND...)' forms, etc.
5578 (single_display_spec_string_p): Support property values that are
5579 lists with the argument STRING its top-level element.
5580 (display_prop_string_p): Fix the condition for processing a
5581 property that is a list to be consistent with handle_display_spec.
5582 (handle_display_spec): New function, refactored from the
5583 last portion of handle_display_prop.
5584 (compute_display_string_pos): Accept additional argument
5585 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5586 value of a `display' property is a "replacing spec".
5587 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5588 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5589 the display property, but just return a value indicating whether
5590 the display property will replace the characters it covers.
5591 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5592 frame_window_p members of struct bidi_it.
5593 (compute_display_string_pos, compute_display_string_end):
5594 New functions.
5595 (push_it): Accept second argument POSITION, where pop_it should
5596 jump to continue iteration.
5597 (reseat_1): Initialize bidi_it.disp_pos.
5599 * keyboard.c (adjust_point_for_property): Adjust the call to
5600 display_prop_intangible_p to its new signature.
5602 * dispextern.h (struct bidi_it): New member frame_window_p.
5603 (bidi_init_it): Update prototypes.
5604 (display_prop_intangible_p): Update prototype.
5605 (compute_display_string_pos, compute_display_string_end):
5606 Declare prototypes.
5607 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5608 EMACS_INT.
5610 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5612 Malloc failure behavior now depends on size of allocation.
5613 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5614 * lisp.h: Change signatures accordingly.
5615 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5616 All callers changed. (Bug#8762)
5618 * gnutls.c: Use Emacs's memory allocators.
5619 Without this change, the gnutls library would invoke malloc etc.
5620 directly, which causes problems on non-SYNC_INPUT hosts, and which
5621 runs afoul of improving memory_full behavior. (Bug#8761)
5622 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5623 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5624 xfree instead of the default malloc, realloc, free.
5625 (Fgnutls_boot): No need to check for memory allocation failure,
5626 since xmalloc does that for us.
5628 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5629 * category.c (hash_get_category_set):
5630 * ccl.c (ccl_driver):
5631 * charset.c (Fdefine_charset_internal):
5632 * charset.h (struct charset.hash_index):
5633 * composite.c (get_composition_id, gstring_lookup_cache)
5634 (composition_gstring_put_cache):
5635 * composite.h (struct composition.hash_index):
5636 * dispextern.h (struct image.hash):
5637 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5638 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5639 (hashfn_equal, hashfn_user_defined, make_hash_table)
5640 (maybe_resize_hash_table, hash_lookup, hash_put)
5641 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5642 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5643 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5644 * image.c (make_image, search_image_cache, lookup_image)
5645 (xpm_put_color_table_h):
5646 * lisp.h (struct Lisp_Hash_Table):
5647 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5648 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5649 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5650 * alloc.c (allocate_vectorlike):
5651 Check for overflow in vector size calculations.
5652 * ccl.c (ccl_driver):
5653 Check for overflow when converting EMACS_INT to int.
5654 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5655 need to be updated by these changes.
5656 * fns.c (make_hash_table, maybe_resize_hash_table):
5657 Check for integer overflow with large hash tables.
5658 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5659 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5660 (SXHASH_REDUCE): New macro.
5661 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5662 Use it instead of discarding useful hash info with large hash values.
5663 (sxhash_float): New function.
5664 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5665 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5666 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5667 Rewrite to use FIXNUM_BITS, as this simplifies things.
5668 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5669 Adjust signatures to match updated version of code.
5670 (consing_since_gc): Now EMACS_INT, since a single hash table can
5671 use more than INT_MAX bytes.
5673 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5675 Make it possible to build with GCC-4.6+ -O2 -flto.
5677 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5679 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5681 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5682 Call minibuffer-inactive-mode.
5684 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5686 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5687 Update dependencies.
5689 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5691 * data.c (init_data): Remove code for UTS, this system is not
5692 supported anymore.
5694 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5696 Don't force ./temacs to start in terminal mode.
5698 * frame.c (make_initial_frame): Initialize faces in all cases, not
5699 only when CANNOT_DUMP is defined.
5700 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5702 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5704 * dispnew.c (add_window_display_history): Use const for the string
5705 pointer. Remove declaration, not needed.
5707 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5709 Use 'inline', not 'INLINE'.
5710 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5711 * alloc.c, fontset.c (INLINE): Remove.
5712 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5713 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5714 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5715 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5716 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5718 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5720 Make it possible to run ./temacs.
5722 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5723 syms_of_callproc does the same thing. Remove test for
5724 "initialized", do it in the caller.
5725 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5727 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5729 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5730 (read_minibuf): Use get_minibuffer.
5731 (syms_of_minibuf): Use DEFSYM.
5732 (Qmetadata): New var.
5733 * data.c (Qbuffer): Don't make it static.
5734 (syms_of_data): Use DEFSYM.
5736 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5738 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5739 (CCL_CODE_MIN): New macro.
5741 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5743 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5745 * eval.c (Qdebug): Now static.
5746 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5747 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5748 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5750 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5752 * image.c: Various fixes to ImageMagick code comments.
5753 (Fimagemagick_types): Doc fix.
5755 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5757 Minor fixes prompted by GCC 4.6.0 warnings.
5759 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5761 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5762 (x_clipboard_manager_save_all): Move extern decl to ...
5763 * xterm.h: ... here, so that it can be checked for consistency.
5765 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5767 * xselect.c (x_clipboard_manager_save_frame)
5768 (x_clipboard_manager_save_all): New functions.
5769 (Fx_clipboard_manager_save): Lisp function deleted.
5771 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5772 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5774 * xterm.h: Update prototype.
5776 2011-05-28 William Xu <william.xwl@gmail.com>
5778 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5779 exiting (Bug#8239).
5781 2011-05-28 Jim Meyering <meyering@redhat.com>
5783 Avoid a sign-extension bug in crypto_hash_function.
5784 * fns.c (to_uchar): Define.
5785 (crypto_hash_function): Use it to convert some newly-signed
5786 variables to unsigned, to avoid sign-extension bugs. For example,
5787 without this change, (md5 "truc") would evaluate to
5788 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5789 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5790 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5792 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5794 Integer overflow fixes.
5796 * dbusbind.c: Serial number integer overflow fixes.
5797 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5798 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5799 to hold a serial number that is too large for a fixnum.
5800 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5801 Check for serial numbers out of range. Decode any serial number
5802 that was so large that it became a float. (Bug#8722)
5804 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5805 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5806 Use XFASTINT rather than XUINT when numbers are nonnegative.
5807 (xd_append_arg, Fdbus_method_return_internal):
5808 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5809 arguments, check that Lisp number is nonnegative, rather than
5810 silently wrapping negative numbers around. (Bug#8722)
5811 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5812 (Bug#8722)
5814 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5816 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5818 ccl: Add integer overflow checks.
5819 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5820 (IN_INT_RANGE): New macros.
5821 (ccl_driver): Use them to check for integer overflow when
5822 decoding a CCL program. Many of the new checks are whether XINT (x)
5823 fits in int; it doesn't always, on 64-bit hosts. The new version
5824 doesn't catch all possible integer overflows, but it's an
5825 improvement. (Bug#8719)
5827 * alloc.c (make_event_array): Use XINT, not XUINT.
5828 There's no need for unsigned here.
5830 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5831 This follows up to the 2011-05-06 change that substituted uintptr_t
5832 for EMACS_INT. This case wasn't caught back then.
5834 Rework Fformat to avoid integer overflow issues.
5835 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5836 now (part of C89). Include <verify.h>.
5837 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5838 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5839 (Fformat): Avoid the prepass trying to compute sizes; it was only
5840 approximate and thus did not catch overflow reliably. Instead, walk
5841 through the format just once, formatting and computing sizes as we go,
5842 checking for integer overflow at every step, and allocating a larger
5843 buffer as needed. Keep track separately whether the format is
5844 multibyte. Keep only the most-recently calculated precision, rather
5845 than them all. Record whether each argument has been converted to
5846 string. Use EMACS_INT, not int, for byte and char and arg counts.
5847 Support field widths and precisions larger than INT_MAX. Avoid
5848 sprintf's undefined behavior with conversion specifications such as %#d
5849 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5850 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5851 formatting out-of-range floating point numbers with int
5852 formats. (Bug#8668)
5854 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5856 * data.c: Avoid integer truncation in expressions involving floats.
5857 * data.c: Include <intprops.h>.
5858 (arith_driver): When there's an integer overflow in an expression
5859 involving floating point, convert the integers to floating point
5860 so that the resulting value does not suffer from catastrophic
5861 integer truncation. For example, on a 64-bit host (* 4
5862 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5863 Do not rely on undefined behavior after integer overflow.
5865 merge count_size_as_multibyte, parse_str_to_multibyte
5866 * character.c, character.h (count_size_as_multibyte):
5867 Rename from parse_str_to_multibyte; all uses changed.
5868 Check for integer overflow.
5869 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5870 since it's now a duplicate of the other. This is more of
5871 a character than a buffer op, so better that it's in character.c.
5872 * fns.c, print.c: Adjust to above changes.
5874 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5876 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5878 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5880 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5881 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5882 (x_clipboard_manager_save): Now static.
5883 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5885 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5886 (crypto_hash_function): Now static.
5887 Fix pointer signedness problems. Avoid unnecessary initializations.
5889 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5891 * termhooks.h (Vselection_alist): Make it terminal-local.
5893 * terminal.c (create_terminal): Initialize it.
5895 * xselect.c: Support for clipboard managers.
5896 (Vselection_alist): Move to termhooks.h as terminal-local var.
5897 (LOCAL_SELECTION): New macro.
5898 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5899 (symbol_to_x_atom): Remove gratuitous arg.
5900 (x_handle_selection_request, lisp_data_to_selection_data)
5901 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5902 (x_own_selection, x_get_local_selection, x_convert_selection):
5903 New arg, specifying work frame. Use terminal-local Vselection_alist.
5904 (some_frame_on_display): Delete unused function.
5905 (Fx_own_selection_internal, Fx_get_selection_internal)
5906 (Fx_disown_selection_internal, Fx_selection_owner_p)
5907 (Fx_selection_exists_p): New optional frame arg.
5908 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5909 (x_handle_selection_clear): Don't treat other terminals with the
5910 same keyboard specially. Use the terminal-local Vselection_alist.
5911 (x_clear_frame_selections): Use Frun_hook_with_args.
5913 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5915 * xterm.h: Add support for those atoms.
5917 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5919 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5920 (converted_selections, conversion_fail_tag): New global variables.
5921 (x_selection_request_lisp_error): Free the above.
5922 (x_get_local_selection): Remove unnecessary code.
5923 (x_reply_selection_request): Args changed; handle arbitrary array
5924 of converted selections stored in converted_selections.
5925 Separate the XChangeProperty and SelectionNotify steps.
5926 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5927 (x_convert_selection): New function.
5928 (x_handle_selection_event): Simplify.
5929 (x_get_foreign_selection): Don't ignore incoming requests while
5930 waiting for an answer; this will fail when we implement
5931 SAVE_TARGETS, and seems unnecessary anyway.
5932 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5933 (Vx_sent_selection_functions): Doc fix.
5935 2011-05-26 Leo Liu <sdl.web@gmail.com>
5937 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5939 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5941 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5943 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5944 for fringe update if it has periodic bitmap.
5945 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5946 and fringe_bitmap_periodic_p.
5948 * fringe.c (get_fringe_bitmap_data): New function.
5949 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5950 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5951 row. Mark glyph row for fringe update if periodicity changed.
5953 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5954 for fringe update unless it has periodic bitmap.
5956 2011-05-25 Kenichi Handa <handa@m17n.org>
5958 * xdisp.c (get_next_display_element): Set correct it->face_id for
5959 a static composition.
5961 2011-05-24 Leo Liu <sdl.web@gmail.com>
5963 * deps.mk (fns.o):
5964 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5966 * fns.c (crypto_hash_function, Fsha1): New function.
5967 (Fmd5): Use crypto_hash_function.
5968 (syms_of_fns): Add Ssha1.
5970 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5972 * gnutls.c: Remove unused macros.
5973 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5974 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5975 Remove macros that are defined and never used.
5976 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5978 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5980 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5981 (Fx_get_selection_internal): Minor cleanup.
5982 (Fx_own_selection_internal): Rename arguments for consistency with
5983 select.el.
5985 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5987 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5989 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5991 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5993 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5995 * dispnew.c (scrolling_window): Don't exclude the case that the
5996 last enabled row in the desired matrix touches the bottom boundary.
5998 2011-05-21 Glenn Morris <rgm@gnu.org>
6000 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6001 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6002 and add some more files.
6004 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6006 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6007 report_file_error introduced by the change from 2011-05-07.
6009 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6011 * systime.h (Time): Define only if emacs is defined.
6012 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6013 where the include path doesn't have X11/X.h by default. See
6014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6016 2011-05-20 Kenichi Handa <handa@m17n.org>
6018 * composite.c (find_automatic_composition): Fix previous change.
6020 2011-05-20 Glenn Morris <rgm@gnu.org>
6022 * lisp.mk: New file, split from Makefile.in.
6023 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6024 (shortlisp): Remove.
6025 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6027 2011-05-19 Glenn Morris <rgm@gnu.org>
6029 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6030 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6031 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6032 (lisp): Set the order to that of loadup.el.
6033 (shortlisp): Make it a copy of $lisp.
6034 (SOME_MACHINE_LISP): Remove.
6035 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6036 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6038 2011-05-18 Kenichi Handa <handa@m17n.org>
6040 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6041 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6042 (find_automatic_composition): Mostly rewrite for efficiency.
6044 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6046 * makefile.w32-in: Update dependencies.
6048 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6050 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6051 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6053 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6055 Fix some integer overflow issues, such as string length overflow.
6057 * insdel.c (count_size_as_multibyte): Check for string overflow.
6059 * character.c (lisp_string_width): Check for string overflow.
6060 Use EMACS_INT, not int, for string indexes and lengths; in
6061 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6062 the resulting string length overflows an EMACS_INT; instead,
6063 report a string overflow if no precision given. When checking for
6064 precision exhaustion, use a check that cannot possibly have
6065 integer overflow. (Bug#8675)
6066 * character.h (lisp_string_width): Adjust to new signature.
6068 * alloc.c (string_overflow): New function.
6069 (Fmake_string): Use it. This doesn't change behavior, but saves
6070 a few bytes and will simplify future changes.
6071 * character.c (string_escape_byte8): Likewise.
6072 * lisp.h (string_overflow): New decl.
6074 Fixups, following up to the user-interface timestamp change.
6075 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6076 for UI timestamps, instead of unsigned long.
6077 * msdos.c (mouse_get_pos): Likewise.
6078 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6079 * w32gui.h (Time): Define by including "systime.h" rather than by
6080 declaring it ourselves. (Bug#8664)
6082 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6083 * image.c (clear_image_cache): Likewise.
6085 * term.c (term_mouse_position): Don't assume time_t wraparound.
6087 Be more systematic about user-interface timestamps.
6088 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6089 and sometimes 'EMACS_UINT', to represent these timestamps.
6090 This change causes it to use 'Time' uniformly, as that's what X uses.
6091 This makes the code easier to follow, and makes it easier to catch
6092 integer overflow bugs such as Bug#8664.
6093 * frame.c (Fmouse_position, Fmouse_pixel_position):
6094 Use Time, not unsigned long, for user-interface timestamps.
6095 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6096 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6097 * keyboard.h (last_event_timestamp): Likewise.
6098 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6099 * menu.h (xmenu_show): Likewise.
6100 * term.c (term_mouse_position): Likewise.
6101 * termhooks.h (struct input_event.timestamp): Likewise.
6102 (struct terminal.mouse_position_hook): Likewise.
6103 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6104 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6105 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6106 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6107 what it was before.
6108 * menu.h, termhooks.h: Include "systime.h", for Time.
6110 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6111 Don't assume that the difference between two unsigned long values
6112 can fit into an integer. At this point, we know button_down_time
6113 <= event->timestamp, so the difference must be nonnegative, so
6114 there's no need to cast the result if double-click-time is
6115 nonnegative, as it should be; check that it's nonnegative, just in
6116 case. This bug is triggered when events are more than 2**31 ms
6117 apart (about 25 days). (Bug#8664)
6119 * xselect.c (last_event_timestamp): Remove duplicate decl.
6120 (x_own_selection): Remove needless cast to unsigned long.
6122 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6123 that always fit in int. Use a sentinel instead of a counter, to
6124 avoid a temp and to allay GCC's concerns about possible int overflow.
6125 * frame.h (struct frame): Use int for menu_bar_items_used
6126 instead of EMACS_INT, since it always fits in int.
6128 * menu.c (grow_menu_items): Check for int overflow.
6130 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6132 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6133 Before, the code was not consistent. These values cannot exceed
6134 2**31 - 1 so there's no need to make them unsigned.
6135 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6136 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6137 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6138 as modifiers.
6139 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6141 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6142 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6143 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6144 presumably because the widths might not match.
6146 * window.c (size_window): Avoid needless test at loop start.
6148 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6150 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6152 2011-05-12 Drew Adams <drew.adams@oracle.com>
6154 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6156 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6158 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6159 `width' to `bar_area_x' and `bar_area_width', respectively.
6160 (x_scroll_run): Take account of fringe background extension.
6162 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6163 Rename local vars `left' and `width' to `bar_area_x' and
6164 `bar_area_width', respectively.
6165 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6166 background extension.
6168 2011-05-10 Jim Meyering <meyering@redhat.com>
6170 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6172 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6174 * image.c (Finit_image_library): Return t for built-in image types,
6175 like pbm and xbm. (Bug#8640)
6177 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6179 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6181 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6183 * w32console.c (Fset_screen_color): Doc fix.
6184 (Fget_screen_color): New function.
6185 (syms_of_ntterm): Defsubr it.
6187 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6188 unlink the temporary file if Fcall_process didn't create it in the
6189 first place.
6190 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6191 child process will be redirected to a file specified with `:file'.
6192 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6193 cue to call_process_cleanup not to close that handle.
6195 2011-05-07 Ben Key <bkey76@gmail.com>
6197 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6198 one of two shell specific rules, either bootstrap-temacs-CMD or
6199 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6200 to the previous implementation of the bootstrap-temacs rule.
6201 The bootstrap-temacs-CMD rule is similar to the previous
6202 implementation of the bootstrap-temacs rule except that it
6203 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6204 variable.
6206 These changes, along with some changes to nt/configure.bat,
6207 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6208 earlier fix to add support for --cflags and --ldflags options
6209 that include quotes so that it works whether make uses cmd or
6210 sh as the shell.
6212 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6214 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6215 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6216 is a constant.
6217 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6218 a string. Handle both cases.
6219 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6220 (Fdbus_register_method): Use Qinvalid_function.
6222 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6224 * makefile.w32-in: Update dependencies.
6225 (LISP_H): Add inttypes.h and stdin.h.
6226 (PROCESS_H): Add unistd.h.
6228 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6230 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6231 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6233 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6235 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6237 * term.c (vfatal): Remove stray call to va_end.
6238 It's not needed and the C Standard doesn't allow it here anyway.
6240 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6241 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6243 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6244 bytes.
6246 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6248 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6250 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6252 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6254 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6256 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6257 * charset.c (Fdefine_charset_internal): Don't initialize
6258 charset.code_space[15]. The value was garbage, on hosts with
6259 32-bit int (Bug#8600).
6261 * lread.c (read_integer): Be more consistent with string-to-number.
6262 Use string_to_number to do the actual conversion; this avoids
6263 rounding errors and fixes some other screwups. Without this fix,
6264 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6265 (digit_to_number): Move earlier, for benefit of read_integer.
6266 Return -1 if the digit is out of range for the base, -2 if it is
6267 not a digit in any supported base. (Bug#8602)
6269 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6271 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6272 to match comment at start of function. This also removes a
6273 GCC warning about overflow in a 32+64-bit port.
6275 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6277 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6278 Reported by Stefan Monnier in
6279 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6280 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6281 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6283 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6284 (EMACS_UINTPTR): Likewise, with uintptr_t.
6286 * lisp.h: Prefer 64-bit EMACS_INT if available.
6287 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6288 on 32-bit hosts that have 64-bit int, so that they can access
6289 large files.
6290 However, temporarily disable this change unless the temporary
6291 symbol WIDE_EMACS_INT is defined.
6293 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6295 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6296 This removes an assumption that EMACS_INT and long are the same
6297 width as pointers. The assumption is true for Emacs porting targets
6298 now, but we want to make other targets possible.
6299 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6300 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6301 In the rest of the code, change types of integers that hold casted
6302 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6303 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6304 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6305 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6306 No need to cast type when ORing.
6307 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6308 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6309 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6310 assume EMACS_INT is the same width as char *.
6311 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6312 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6313 Remove no-longer-needed casts.
6314 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6315 (xg_tool_bar_help_callback, xg_make_tool_item):
6316 Use EMACS_INTPTR to hold an integer
6317 that will be cast to void *; this can avoid a GCC warning
6318 if EMACS_INT is not the same width as void *.
6319 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6320 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6321 (current_message_1, set_message_1):
6322 Use a local to convert to proper width without a cast.
6323 * xmenu.c (dialog_selection_callback): Likewise.
6325 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6326 Also, don't assume VALBITS / RAND_BITS is less than 5,
6327 and don't rely on undefined behavior when shifting a 1 left into
6328 the sign bit.
6329 * lisp.h (get_random): Change signature to match.
6331 * lread.c (hash_string): Use size_t, not int, for hash computation.
6332 Normally we prefer signed values; but hashing is special, because
6333 it's better to use unsigned division on hash table sizes so that
6334 the remainder is nonnegative. Also, size_t is the natural width
6335 for hashing into memory. The previous code used 'int', which doesn't
6336 retain enough info to hash well into very large tables.
6337 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6339 * dbusbind.c: Don't possibly lose pointer info when converting.
6340 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6341 Use XPNTR rather than XHASH, so that the high-order bits of
6342 the pointer aren't lost when converting through void *.
6344 * eval.c (Fautoload): Don't double-shift a pointer.
6346 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6348 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6350 * gnutls.c (DEF_GNUTLS_FN):
6351 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6353 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6355 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6356 marker. (Bug#8610)
6358 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6360 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6361 New version that can reserve upto 2GB of heap space.
6363 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6365 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6367 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6369 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6370 `gnutls_certificate_set_x509_key_file'.
6372 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6374 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6375 Update dependencies.
6377 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6379 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6380 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6381 Remove unused parameter `fildes'.
6382 * process.c (read_process_output, send_process): Don't pass it.
6384 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6386 Fix previous change: the library cache is defined in w32.c.
6387 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6388 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6390 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6392 Implement dynamic loading of GnuTLS on Windows.
6394 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6395 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6396 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6397 Declare.
6399 * gnutls.c (Qgnutls_dll): Define.
6400 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6401 (gnutls_*): Declare function pointers.
6402 (init_gnutls_functions): New function to initialize function pointers.
6403 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6404 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6405 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6406 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6407 (emacs_gnutls_write, emacs_gnutls_read)
6408 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6409 (Fgnutls_available_p): New function.
6410 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6411 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6412 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6414 * image.c: Include w32.h.
6415 (Vimage_type_cache): Delete.
6416 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6417 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6418 (w32_delayed_load): Move to w32.c.
6420 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6422 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6423 (w32_delayed_load): Move from image.c. When loading a library, record
6424 its filename in the :loaded-from property of the library id.
6425 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6426 Initialize and staticpro them.
6427 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6429 * process.c: Include lisp.h before w32.h, not after.
6430 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6431 instead of gnutls_record_check_pending.
6433 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6435 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6437 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6438 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6439 as passed in.
6441 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6443 * xterm.c (x_set_frame_alpha): Do not set property on anything
6444 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6446 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6448 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6450 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6452 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6453 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6454 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6455 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6456 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6457 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6458 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6459 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6460 (Qgnutls_bootprop_callbacks_verify): Make static.
6462 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6464 * callproc.c: Indentation fixup.
6466 * sysdep.c (wait_for_termination_1): Make static.
6467 (wait_for_termination, interruptible_wait_for_termination):
6468 Move after wait_for_termination_1.
6470 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6472 * sysdep.c (interruptible_wait_for_termination): New function
6473 which is like wait_for_termination, but allows keyboard
6474 interruptions.
6476 * callproc.c (Fcall_process): Add (:file "file") as an option for
6477 the STDOUT buffer.
6478 (Fcall_process_region): Ditto.
6480 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6482 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6483 rather than `XVECTOR (FOO)->size'.
6485 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6486 inttypes.h, as a gnulib replacement is used if it not available in
6487 system headers.
6489 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6491 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6492 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6493 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6495 * coding.c (coding_alloc_by_realloc): Error out if destination
6496 will grow beyond MOST_POSITIVE_FIXNUM.
6497 (decode_coding_emacs_mule): Abort if there isn't enough place in
6498 charbuf for the composition carryover bytes. Reserve an extra
6499 space for up to 2 characters produced in a loop.
6500 (decode_coding_iso_2022): Abort if there isn't enough place in
6501 charbuf for the composition carryover bytes.
6503 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6505 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6506 aborting when %lld or %lll format is passed.
6507 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6508 %llo or %llx format is passed. (Bug#8545)
6510 * window.c (window_scroll_line_based): Use a marker instead of
6511 simple variables to record original value of point. (Bug#7952)
6513 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6514 produced by %s or %c overflows available buffer space. (Bug#8545)
6516 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6518 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6519 (SIZE_MAX): Move defn after all includes, as they might #define it.
6521 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6523 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6525 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6527 * keyboard.c (Qdelayed_warnings_hook): Define.
6528 (command_loop_1): Run `delayed-warnings-hook'
6529 if Vdelayed_warnings_list is non-nil.
6530 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6531 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6533 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6535 * doprnt.c (doprnt): Don't return value smaller than the buffer
6536 size if the message was truncated. (Bug#8545).
6538 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6540 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6541 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6543 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6545 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6547 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6549 * makefile.w32-in: Update dependencies.
6551 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6553 Improve `doprnt' and its usage. (Bug#8545)
6554 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6555 `format_end'. Remove support for %l as a conversion specifier.
6556 Don't use xrealloc. Improve diagnostics when the %l size modifier
6557 is used. Update the commentary.
6559 * eval.c (verror): Simplify calculation of size_t.
6561 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6562 messages.
6564 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6566 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6567 change.
6569 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6571 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6572 This makes this file independent of the recent pseudovector change.
6574 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6576 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6578 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6579 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6580 Remove unused local.
6581 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6583 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6584 GCC 4.6.0 optimizes based on type-based alias analysis.
6585 For example, if b is of type struct buffer * and v of type struct
6586 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6587 != &v->size, and therefore "v->size = 1; b->size = 2; return
6588 v->size;" must therefore return 1. This assumption is incorrect
6589 for Emacs, since it type-puns struct Lisp_Vector * with many other
6590 types. To fix this problem, this patch adds a new type struct
6591 vectorlike_header that documents the constraints on layout of vectors
6592 and pseudovectors, and helps optimizing compilers not get fooled
6593 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6594 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6595 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6596 the size member.
6597 (XSETPVECTYPE): Rewrite in terms of new macro.
6598 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6599 This is a bit clearer, and further avoids the possibility of
6600 undesirable aliasing.
6601 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6602 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6603 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6604 since Lisp_Subr is a special case (no "next" field).
6605 (ASIZE): Now uses header.size rather than size.
6606 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6607 to avoid the hassle of writing XVECTOR (foo)->header.size.
6608 (struct vectorlike_header): New type.
6609 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6610 object, to help avoid aliasing.
6611 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6612 (SUBRP): Likewise, since Lisp_Subr is a special case.
6613 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6614 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6615 (struct Lisp_Hash_Table): Combine first two members into a single
6616 struct vectorlike_header member. All uses of "size" and "next" members
6617 changed to be "header.size" and "header.next".
6618 * buffer.h (struct buffer): Likewise.
6619 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6620 * frame.h (struct frame): Likewise.
6621 * process.h (struct Lisp_Process): Likewise.
6622 * termhooks.h (struct terminal): Likewise.
6623 * window.c (struct save_window_data, struct saved_window): Likewise.
6624 * window.h (struct window): Likewise.
6625 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6626 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6627 * buffer.c (init_buffer_once): Likewise.
6628 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6629 special case.
6630 * process.c (Fformat_network_address): Use local var for size,
6631 for brevity.
6633 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6635 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6636 * data.c (atof): Remove decl; no longer used or needed.
6637 (digit_to_number): Move to lread.c.
6638 (Fstring_to_number): Use new string_to_number function, to be
6639 consistent with how the Lisp reader treats infinities and NaNs.
6640 Do not assume that floating-point numbers represent EMACS_INT
6641 without losing information; this is not true on most 64-bit hosts.
6642 Avoid double-rounding errors, by insisting on integers when
6643 parsing non-base-10 numbers, as the documentation specifies.
6644 * lisp.h (string_to_number): New decl, replacing ...
6645 (isfloat_string): Remove.
6646 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6647 (read1): Do not accept +. and -. as integers; this
6648 appears to have been a coding error. Similarly, do not accept
6649 strings like +-1e0 as floating point numbers. Do not report
6650 overflow for integer overflows unless the base is not 10 which
6651 means we have no simple and reliable way to continue.
6652 Break out the floating-point parsing into a new
6653 function string_to_number, so that Fstring_to_number parses
6654 floating point numbers consistently with the Lisp reader.
6655 (digit_to_number): Move here from data.c. Make it static inline.
6656 (E_CHAR, EXP_INT): Remove, replacing with ...
6657 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6658 (string_to_number): New function, replacing isfloat_string.
6659 This function checks for valid syntax and produces the resulting
6660 Lisp float number too. Rework it so that string-to-number
6661 no longer mishandles examples like "1.0e+". Use strtoumax,
6662 so that overflow for non-base-10 numbers is reported only when
6663 there's no portable and simple way to convert to floating point.
6665 * textprop.c (set_text_properties_1): Rewrite for clarity,
6666 and to avoid GCC warning about integer overflow.
6668 * intervals.h (struct interval): Use EMACS_INT for members
6669 where EMACS_UINT might cause problems. See
6670 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6671 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6672 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6673 All uses changed.
6674 (offset_intervals): Tell GCC not to worry about length overflow
6675 when negating a negative length.
6677 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6678 (overrun_check_free): Likewise.
6680 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6681 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6682 word size.
6684 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6685 (gnutls_make_error): Rename local to avoid shadowing.
6686 (gnutls_emacs_global_deinit): ifdef out; not used.
6687 (Fgnutls_boot): Use const for pointer to readonly storage.
6688 Comment out unused local. Fix pointer signedness problems.
6690 * lread.c (openp): Don't stuff size_t into an 'int'.
6691 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6692 about possible signed overflow.
6694 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6695 (GDK_KEY_g): Don't define if already defined.
6696 (xg_prepare_tooltip): Avoid pointer signedness problem.
6697 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6699 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6700 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6702 * xfns.c (Fx_window_property): Simplify a bit,
6703 to make a bit faster and to avoid GCC 4.6.0 warning.
6704 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6706 * fns.c (internal_equal): Don't assume size_t fits in int.
6708 * alloc.c (compact_small_strings): Tighten assertion a little.
6710 Replace pEd with more-general pI, and fix some printf arg casts.
6711 * lisp.h (pI): New macro, generalizing old pEd macro to other
6712 conversion specifiers. For example, use "...%"pI"d..." rather
6713 than "...%"pEd"...".
6714 (pEd): Remove. All uses replaced with similar uses of pI.
6715 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6716 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6717 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6718 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6719 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6720 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6721 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6722 64-bit hosts.
6723 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6724 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6725 * print.c (safe_debug_print, print_object): Likewise.
6726 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6727 to int.
6728 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6729 avoiding the 0 flag, which is not portable.
6730 * process.c (Fmake_network_process): Use pI to avoid cast.
6731 * region-cache.c (pp_cache): Likewise.
6732 * xdisp.c (decode_mode_spec): Likewise.
6733 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6734 behavior on 64-bit hosts with printf arg.
6735 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6736 (x_stop_queuing_selection_requests): Likewise.
6737 (x_get_window_property): Don't truncate byte count to an 'int'
6738 when tracing.
6740 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6741 here, since it parses constructs like leading '-' and spaces,
6742 which are not wanted; and it overflows with large numbers.
6743 Instead, simply match F[0-9]+, which is what is wanted anyway.
6745 * alloc.c: Remove unportable assumptions about struct layout.
6746 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6747 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6748 (allocate_vectorlike, make_pure_vector): Use the new macros,
6749 plus offsetof, to remove unportable assumptions about struct layout.
6750 These assumptions hold on all porting targets that I know of, but
6751 they are not guaranteed, they're easy to remove, and removing them
6752 makes further changes easier.
6754 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6755 This doesn't fix a bug but makes the code clearer.
6756 (string_overrun_cookie): Now const. Use initializers that
6757 don't formally overflow signed char, to avoid warnings.
6758 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6759 can cause Emacs to crash when string overrun checking is enabled.
6760 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6761 multiple of sizeof (EMACS_INT); it need not be, if
6762 alignof(EMACS_INT) < sizeof (EMACS_INT).
6763 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6765 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6767 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6769 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6771 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6772 supposed to be handshaking. (Bug#8556)
6773 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6775 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6777 * lisp.h (Qdebug): List symbol.
6778 * eval.c (Qdebug): Restore global linkage.
6779 * keyboard.c (debug-on-event): New variable.
6780 (handle_user_signal): Break into debugger when debug-on-event
6781 matches the current signal symbol.
6783 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6785 * alloc.c (check_sblock, check_string_bytes)
6786 (check_string_free_list): Convert to standard C.
6788 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6790 * w32.c (emacs_gnutls_push): Fix typo.
6792 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6794 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6795 "cast to pointer from integer of different size".
6797 Improve doprnt and its use in verror. (Bug#8545)
6798 * doprnt.c (doprnt): Document the set of format control sequences
6799 supported by the function. Use SAFE_ALLOCA instead of always
6800 using `alloca'.
6802 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6803 is one byte too soon. Don't use xrealloc; instead xfree and
6804 xmalloc anew.
6806 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6808 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6809 callbacks stage.
6811 * gnutls.c: Renamed global_initialized to
6812 gnutls_global_initialized. Added internals for the
6813 :verify-hostname-error, :verify-error, and :verify-flags
6814 parameters of `gnutls-boot' and documented those parameters in the
6815 docstring. Start callback support.
6816 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6817 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6818 on error. Return error code.
6819 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6820 (emacs_gnutls_read): Likewise.
6821 (Fgnutls_boot): Return handshake error code.
6822 (emacs_gnutls_handle_error): New function.
6823 (wsaerror_to_errno): Likewise.
6825 * w32.h (emacs_gnutls_pull): Add prototype.
6826 (emacs_gnutls_push): Likewise.
6828 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6829 (emacs_gnutls_push): Likewise.
6831 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6833 * process.c (wait_reading_process_output): Check if GnuTLS
6834 buffered some data internally if no FDs are set for TLS
6835 connections.
6837 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6838 (LIBS): Link to USER_LIBS.
6839 ($(BLD)/gnutls.$(0)): New target.
6841 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6843 * xdisp.c (handle_single_display_spec): Rename the
6844 display_replaced_before_p argument into display_replaced_p, to
6845 make it consistent with the commentary. Fix typos in the
6846 commentary.
6848 * textprop.c (syms_of_textprop): Remove dead code.
6849 (copy_text_properties): Delete obsolete commentary about an
6850 interface that was deleted long ago. Fix typos in the description
6851 of arguments.
6853 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6854 to changes in oldXMenu/XMenu.h from 2011-04-16.
6855 <menu_help_message, prev_menu_help_message>: Constify.
6856 (IT_menu_make_room): menu->help_text is now `const char **';
6857 adjust.
6859 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6860 to changes in oldXMenu/XMenu.h from 2011-04-16.
6861 (struct XMenu): Declare `help_text' `const char **'.
6863 * xfaces.c <Qunspecified>: Make extern again.
6865 * syntax.c: Include sys/types.h before including regex.h, as
6866 required by Posix.
6868 * doc.c (get_doc_string): Improve the format passed to `error'.
6870 * doprnt.c (doprnt): Improve commentary.
6872 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6874 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6875 them with etags.
6877 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6878 changes in globals.h immediately force recompilation.
6879 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6880 $(CURDIR)/s/ms-w32.h.
6881 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6883 * character.c (Fchar_direction): Function deleted.
6884 (syms_of_character): Don't defsubr it.
6885 <char-direction-table>: Deleted.
6887 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6889 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6890 * doprnt.c: Include limits.h.
6891 (SIZE_MAX): New macro.
6892 (doprnt): Return a size_t value. 2nd arg is now size_t.
6893 Many local variables are now size_t instead of int or unsigned.
6894 Improve overflow protection. Support `l' modifier for integer
6895 conversions. Support %l conversion. Don't assume an EMACS_INT
6896 argument for integer conversions and for %c.
6898 * lisp.h (doprnt): Restore prototype.
6900 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6901 $(SRC)/character.h.
6903 * Makefile.in (base_obj): Add back doprnt.o.
6905 * deps.mk (doprnt.o): Add back prerequisites.
6906 (callint.o): Depend on character.h.
6908 * eval.c (internal_lisp_condition_case): Include the handler
6909 representation in the error message.
6910 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6911 when breaking from the loop.
6913 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6915 * callint.c (Fcall_interactively): When displaying error message
6916 about invalid control letter, pass the character's codepoint, not
6917 a pointer to its multibyte form. Improve display of the character
6918 in octal and display also its hex code.
6920 * character.c (char_string): Use %x to display the (unsigned)
6921 codepoint of an invalid character, to avoid displaying a bogus
6922 negative value.
6924 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6925 `error', not SYMBOL_NAME itself.
6927 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6928 character arguments to `error'.
6930 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6931 to `error' in error message about FINAL_CHAR argument. Make sure
6932 FINAL_CHAR is a character, and use %c when it is passed as
6933 argument to `error'.
6935 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6937 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6939 * w32.c: Include <time.h>.
6940 (sys_localtime): New function.
6942 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6944 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6946 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6948 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6950 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6951 zombies (Bug#8467).
6953 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6955 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6956 gl_state.e_property when gl_state.object is Qt.
6958 * insdel.c (make_gap_larger): Remove limitation of buffer size
6959 to <= INT_MAX.
6961 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6963 * xdisp.c (lookup_glyphless_char_display)
6964 (produce_glyphless_glyph): Handle cons cell entry in
6965 glyphless-char-display.
6966 (Vglyphless_char_display): Document it.
6968 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6969 glyphless-char-display.
6971 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6973 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6975 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6977 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6978 definition for no-X builds.
6980 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6982 Static checks with GCC 4.6.0 and non-default toolkits.
6984 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6986 * process.c (keyboard_bit_set): Define only if SIGIO.
6987 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6988 (send_process): Repair possible setjmp clobbering.
6990 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6992 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6994 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6996 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6997 Define only if needed.
6999 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7000 by pacifying GCC about it. Maybe it's time to retire it?
7001 * xfaces.c (USG, __TIMEVAL__): Likewise.
7003 * dispextern.h (struct redisplay_interface): Rename param
7004 to avoid shadowing.
7005 * termhooks.h (struct terminal): Likewise.
7006 * xterm.c (xembed_send_message): Likewise.
7008 * insdel.c (make_gap_smaller): Define only if
7009 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7011 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7012 it.
7014 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7015 so that we aren't warned about unused symbols.
7017 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7019 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7021 * xfns.c (x_real_positions): Mark locals as initialized.
7023 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7025 * xterm.c: Fix problems found by static analysis with other toolkits.
7026 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7027 (x_dispatch_event): Declare static if USE_GTK, and
7028 define if USE_GTK || USE_X_TOOLKIT.
7029 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7030 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7031 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7032 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7034 * xmenu.c (menu_help_callback): Pointer type fixes.
7035 Use const pointers when pointing at readonly data. Avoid pointer
7036 signedness clashes.
7037 (FALSE): Remove unused macro.
7038 (update_frame_menubar): Remove unused decl.
7040 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7042 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7043 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7044 (single_menu_item): Rename local to avoid shadowing.
7046 * keyboard.c (make_lispy_event): Remove unused local var.
7048 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7049 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7051 * bitmaps: Change bitmaps from unsigned char back to the X11
7052 compatible char. Avoid the old compiler warnings about
7053 out-of-range initializers by using, for example, '\xab' rather
7054 than 0xab.
7056 * xgselect.c (xgselect_initialize): Check vs interface
7057 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7059 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7061 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7062 to read-only memory.
7064 * fns.c (vector): Remove; this old hack is no longer needed.
7066 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7067 Remove unused var.
7068 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7070 * xrdb.c (x_load_resources): Omit unused local.
7072 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7073 (x_window): Rename locals to avoid shadowing.
7074 (USG): Use the kludged USG macro, to pacify gcc.
7076 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7077 (x_term_init): Remove local to avoid shadowing.
7079 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7081 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7082 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7084 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7086 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7088 Fix regex.c, syntax.c and friends for buffers > 2GB.
7089 * syntax.h (struct gl_state_s): Declare character position members
7090 EMACS_INT.
7092 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7094 * textprop.c (verify_interval_modification, interval_of):
7095 Declare arguments EMACS_INT.
7097 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7098 EMACS_INT.
7100 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7102 * indent.c (Fvertical_motion): Local variable it_start is now
7103 EMACS_INT.
7105 * regex.c (re_match, re_match_2, re_match_2_internal)
7106 (bcmp_translate, regcomp, regexec, print_double_string)
7107 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7108 (re_compile_pattern, re_exec): Declare arguments and local
7109 variables `size_t' and `ssize_t' and return values `regoff_t', as
7110 appropriate.
7111 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7112 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7113 <compile_stack_type>: `size' and `avail' are now `size_t'.
7115 * regex.h <regoff_t>: Use ssize_t, not int.
7116 (re_search, re_search_2, re_match, re_match_2): Arguments that
7117 specify buffer/string position and length are now ssize_t and
7118 size_t. Return type is regoff_t.
7120 2011-04-16 Ben Key <bkey76@gmail.com>
7122 * nsfont.m: Fixed bugs in ns_get_family and
7123 ns_descriptor_to_entity that were caused by using free to
7124 deallocate memory blocks that were allocated by xmalloc (via
7125 xstrdup). This caused Emacs to crash when compiled with
7126 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7127 --enable-checking=xmallocoverrun). xfree is now used to
7128 deallocate these memory blocks.
7130 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7132 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7134 emacs_write: Accept and return EMACS_INT for sizes.
7135 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7136 et seq.
7137 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7138 Accept and return EMACS_INT.
7139 (emacs_gnutls_write): Return the number of bytes written on
7140 partial writes.
7141 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7142 (emacs_read, emacs_write): Remove check for negative size, as the
7143 Emacs source code has been audited now.
7144 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7145 (emacs_read, emacs_write): Use it.
7146 * process.c (send_process): Adjust to the new signatures of
7147 emacs_write and emacs_gnutls_write. Do not attempt to store
7148 a byte offset into an 'int'; it might overflow.
7149 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7151 * sound.c: Don't assume sizes fit in 'int'.
7152 (struct sound_device.period_size, alsa_period_size):
7153 Return EMACS_INT, not int.
7154 (struct sound_device.write, vox_write, alsa_write):
7155 Accept EMACS_INT, not int.
7156 (wav_play, au_play): Use EMACS_INT to store sizes and to
7157 record read return values.
7159 2011-04-15 Ben Key <bkey76@gmail.com>
7161 * keyboard.c (Qundefined): Don't declare static since it is used
7162 in nsfns.m.
7163 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7164 static since they are used in nsfont.m.
7166 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7168 * process.c (Qprocessp): Don't declare static.
7169 * lisp.h (Qprocessp): Declare again.
7171 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7173 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7175 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7177 Improve C-level modularity by making more things 'static'.
7179 Don't publish debugger-only interfaces to other modules.
7180 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7181 (verify_bytepos, count_markers): Move decls to the only modules
7182 that need them.
7183 * region-cache.h (pp_cache): Likewise.
7184 * window.h (check_all_windows): Likewise.
7185 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7187 * sysdep.c (croak): Now static, if
7188 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7189 * syssignal.h (croak): Declare only if not static.
7191 * alloc.c (refill_memory_reserve): Now static if
7192 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7193 * lisp.h (refill_memory_reserve): Declare only if not static.
7195 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7196 Define only if USE_LUCID.
7198 * xrdb.c (x_customization_string, x_rm_string): Now static.
7200 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7201 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7203 * xdisp.c (draw_row_with_mouse_face): Now static.
7204 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7206 * window.h (check_all_windows): Mark externally visible.
7208 * window.c (window_deletion_count): Now static.
7210 * undo.c: Make symbols static if they're not exported.
7211 (last_undo_buffer, last_boundary_position, pending_boundary):
7212 Now static.
7214 * textprop.c (interval_insert_behind_hooks): Now static.
7215 (interval_insert_in_front_hooks): Likewise.
7217 * term.c: Make symbols static if they're not exported.
7218 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7219 (max_frame_lines, tty_set_terminal_modes):
7220 (tty_reset_terminal_modes, tty_turn_off_highlight):
7221 (get_tty_terminal): Now static.
7222 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7223 * termhooks.h (term_mouse_moveto): Do not declare if
7224 HAVE_WINDOW_SYSTEM.
7225 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7226 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7228 * sysdep.c: Make symbols static if they're not exported.
7229 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7230 Now static.
7231 (sigprocmask_set, full_mask): Remove; unused.
7232 (wait_debugging): Mark as visible.
7233 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7234 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7236 * syntax.c (syntax_temp): Define only if !__GNUC__.
7238 * sound.c (current_sound_device, current_sound): Now static.
7240 * search.c (searchbufs, searchbuf_head): Now static.
7242 * scroll.c (scroll_cost): Remove; unused.
7243 * dispextern.h (scroll_cost): Remove decl.
7245 * region-cache.h (pp_cache): Mark as externally visible.
7247 * process.c: Make symbols static if they're not exported.
7248 (process_tick, update_tick, create_process, chan_process):
7249 (Vprocess_alist, proc_buffered_char, datagram_access):
7250 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7251 (deactivate_process): Mark defn as static, as well as decl.
7252 * lisp.h (create_process): Remove decl.
7253 * process.h (chan_process, Vprocess_alist): Remove decls.
7255 * print.c: Make symbols static if they're not exported.
7256 (print_depth, new_backquote_output, being_printed, print_buffer):
7257 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7258 (print_interval, print_number_index, initial_stderr_stream):
7259 Now static.
7260 * lisp.h (Fprinc): Remove decl.
7261 (debug_output_compilation_hack): Mark as externally visible.
7263 * sysdep.c (croak): Move decl from here to syssignal.h.
7264 * syssignal.h (croak): Put it here, so the API can be checked when
7265 'croak' is called from dissociate_if_controlling_tty.
7267 * minibuf.c: Make symbols static if they're not exported.
7268 (minibuf_save_list, choose_minibuf_frame): Now static.
7269 * lisp.h (choose_minibuf_frame): Remove decl.
7271 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7273 * lread.c: Make symbols static if they're not exported.
7274 (read_objects, initial_obarray, oblookup_last_bucket_number):
7275 Now static.
7276 (make_symbol): Remove; unused.
7277 * lisp.h (initial_obarray, make_symbol): Remove decls.
7279 * keyboard.c: Make symbols static if they're not exported.
7280 (single_kboard, recent_keys_index, total_keys, recent_keys):
7281 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7282 (this_single_command_key_start, echoing, last_auto_save):
7283 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7284 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7285 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7286 (Vlispy_mouse_stem, double_click_count):
7287 Now static.
7288 (force_auto_save_soon): Define only if SIGDANGER.
7289 (ignore_mouse_drag_p): Now static if
7290 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7291 (print_help): Remove; unused.
7292 (stop_character, last_timer_event): Mark as externally visible.
7293 * keyboard.h (ignore_mouse_drag_p): Declare only if
7294 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7295 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7296 * lisp.h (echoing): Remove decl.
7297 (force_auto_save_soon): Declare only if SIGDANGER.
7298 * xdisp.c (redisplay_window): Simplify code, to make it more
7299 obvious that ignore_mouse_drag_p is not accessed if !defined
7300 USE_GTK && !defined HAVE_NS.
7302 * intervals.c: Make symbols static if they're not exported.
7303 (merge_properties_sticky, merge_interval_right, delete_interval):
7304 Now static.
7305 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7307 * insdel.c: Make symbols static if they're not exported.
7308 However, leave prepare_to_modify_buffer alone. It's never
7309 called from outside this function, but that appears to be a bug.
7310 (combine_after_change_list, combine_after_change_buffer):
7311 (adjust_after_replace, signal_before_change): Now static.
7312 (adjust_after_replace_noundo): Remove; unused.
7313 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7314 (signal_before_change): Remove decls.
7316 * indent.c (val_compute_motion, val_vmotion): Now static.
7318 * image.c: Make symbols static if they're not exported.
7319 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7320 if USE_GTK.
7321 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7322 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7324 * fringe.c (standard_bitmaps): Now static.
7325 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7327 * frame.c: Make symbols static if they're not exported.
7328 (x_report_frame_params, make_terminal_frame): Now static.
7329 (get_frame_param): Now static, unless HAVE_NS.
7330 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7331 (x_get_resource_string): Remove; not used.
7332 * frame.h (make_terminal_frame, x_report_frame_params):
7333 (x_get_resource_string); Remove decls.
7334 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7335 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7337 * font.c, fontset.c: Make symbols static if they're not exported.
7338 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7339 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7340 * font.c (font_close_object): Now static.
7341 * font.h (font_close_object): Remove.
7342 * fontset.c (FONTSET_OBJLIST): Remove.
7343 (free_realized_fontset) #if-0 the body, which does nothing.
7344 (face_suitable_for_char_p): #if-0, as it's never called.
7345 * fontset.h (face_suitable_for_char_p): Remove decl.
7346 * xfaces.c (face_at_string_position):
7347 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7348 since 0 is always ASCII.
7350 * fns.c (weak_hash_tables): Now static.
7352 * fileio.c: Make symbols static if they're not exported.
7353 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7354 (Vwrite_region_annotation_buffers): Now static.
7356 * eval.c: Make symbols static if they're not exported.
7357 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7358 * lisp.h (backtrace_list): Remove decl.
7360 * emacs.c: Make symbols static if they're not exported.
7361 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7362 (fatal_error_code, fatal_error_signal_hook, standard_args):
7363 Now static.
7364 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7365 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7366 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7367 * lisp.h (fatal_error_signal_hook): Remove decl.
7368 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7370 * editfns.c: Move a (normally-unused) function to its only use.
7371 * editfns.c, lisp.h (get_operating_system_release): Remove.
7372 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7373 worth the hassle of breaking this out.
7375 * xterm.c: Make symbols static if they're not exported.
7376 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7377 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7378 (x_destroy_window, x_delete_display):
7379 Now static.
7380 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7381 (x_mouse_leave): Remove; unused.
7382 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7383 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7384 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7385 Remove decls.
7386 (x_mouse_leave): Declare only if WINDOWSNT.
7387 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7388 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7389 USE_X_TOOLKIT.
7391 * ftxfont.c: Make symbols static if they're not exported.
7392 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7393 HAVE_FREETYPE.
7394 * font.h (ftxfont_driver): Likewise.
7396 * xfns.c: Make symbols static if they're not exported.
7397 (x_last_font_name, x_display_info_for_name):
7398 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7399 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7400 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7401 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7402 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7403 (last_show_tip_args): Now static.
7404 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7405 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7406 (x_screen_planes): Remove; unused.
7407 * dispextern.h (x_screen_planes): Remove decl.
7409 * dispnew.c: Make symbols static if they're not exported.
7410 * dispextern.h (redraw_garbaged_frames, scrolling):
7411 (increment_row_positions): Remove.
7412 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7413 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7414 Now static.
7415 (redraw_garbaged_frames): Remove; unused.
7417 * xfaces.c: Make symbols static if they're not exported.
7418 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7419 Remove decls.
7420 * xterm.h (defined_color): Remove decls.
7421 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7422 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7423 (menu_face_changed_default, defined_color, free_realized_face):
7424 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7425 (ascii_face_of_lisp_face): Remove; unused.
7427 * xdisp.c: Make symbols static if they're not exported.
7428 * dispextern.h (scratch_glyph_row, window_box_edges):
7429 (glyph_to_pixel_coords, set_cursor_from_row):
7430 (get_next_display_element, set_iterator_to_next):
7431 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7432 (show_mouse_face): Remove decls
7433 * frame.h (message_buf_print): Likewise.
7434 * lisp.h (pop_message, set_message, check_point_in_composition):
7435 Likewise.
7436 * xterm.h (set_vertical_scroll_bar): Likewise.
7437 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7438 (message_buf_print, scratch_glyph_row, displayed_buffer):
7439 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7440 (get_next_display_element, show_mouse_face, window_box_edges):
7441 (frame_to_window_pixel_xy, check_point_in_composition):
7442 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7443 (glyph_to_pixel_coords): Remove; unused.
7445 * dired.c (file_name_completion): Now static.
7447 * dbusbind.c (xd_in_read_queued_messages): Now static.
7449 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7450 * data.c (circular_list_error): Remove.
7452 * commands.h (last_point_position, last_point_position_buffer):
7453 (last_point_position_window): Remove decls.
7454 * keyboard.c: Make these variables static.
7456 * coding.h (coding, code_convert_region, encode_coding_gap):
7457 Remove decls.
7458 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7459 (iso_code_class, detect_coding, code_convert_region): Now static.
7460 (encode_coding_gap): Remove; unused.
7462 * chartab.c (chartab_chars, chartab_bits): Now static.
7464 * charset.h (charset_iso_8859_1): Remove decl.
7465 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7466 Now static.
7468 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7469 * ccl.c (Vccl_program_table): Now static.
7470 (check_ccl_update): Remove; unused.
7472 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7473 * category.h: ... from here.
7474 * category.c (check_category_table, set_category_set): Now static.
7476 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7477 * lisp.h: Remove these decls.
7479 * buffer.c (buffer_count): Remove unused var.
7481 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7482 so that it's not optimized away.
7483 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7484 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7485 exported only to the debugger.
7487 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7488 * atimer.h (run_all_atimers): Remove; not exported.
7490 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7491 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7492 was inaccessible from Lisp.
7493 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7494 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7496 alloc.c: Import and export fewer symbols, and remove unused items.
7497 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7498 is defined.
7499 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7500 it's not optimized away by whole-program optimization.
7501 (message_enable_multibyte, free_misc): Remove.
7502 (catchlist, handlerlist, mark_backtrace):
7503 Declare only if BYTE_MARK_STACK.
7504 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7505 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7506 (message_enable_multibyte): Remove decl.
7507 (free_misc, interval_free_list, float_block, float_block_index):
7508 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7509 (cons_free_list, last_marked_index):
7510 Now static.
7511 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7512 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7513 (mark_backtrace): Define only if BYTE_MARK_STACK.
7514 * xdisp.c (message_enable_multibyte): Now static.
7516 Declare Lisp_Object Q* variables to be 'static' if not exported.
7517 This makes it easier for human readers (and static analyzers)
7518 to see whether these variables are used from other modules.
7519 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7520 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7521 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7522 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7523 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7524 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7525 * xmenu.c, xselect.c:
7526 Declare Q* vars static if they are not used in other modules.
7527 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7528 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7529 Remove decls of unexported vars.
7530 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7532 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7534 Make Emacs functions such as Fatom 'static' by default.
7535 This makes it easier for human readers (and static analyzers)
7536 to see whether these functions can be called from other modules.
7537 DEFUN now defines a static function. To make the function external
7538 so that it can be used in other C modules, use the new macro DEFUE.
7539 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7540 (Finit_image_library):
7541 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7542 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7543 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7544 Remove decls, since these functions are now static.
7545 (Funintern, Fget_internal_run_time): New decls, since these functions
7546 were already external.
7548 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7549 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7550 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7551 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7552 * keyboard.c, keymap.c, lread.c:
7553 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7554 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7555 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7556 Mark functions with DEFUE instead of DEFUN,
7557 if they are used in other modules.
7558 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7559 decls for now-static functions.
7560 * buffer.h (Fdelete_overlay): Remove decl.
7561 * callproc.c (Fgetenv_internal): Mark as internal.
7562 * composite.c (Fremove_list_of_text_properties): Remove decl.
7563 (Fcomposition_get_gstring): New forward static decl.
7564 * composite.h (Fcomposite_get_gstring): Remove decl.
7565 * dired.c (Ffile_attributes): New forward static decl.
7566 * doc.c (Fdocumntation_property): New forward static decl.
7567 * eval.c (Ffetch_bytecode): New forward static decl.
7568 (Funintern): Remove extern decl; now in .h file where it belongs.
7569 * fileio.c (Fmake_symbolic_link): New forward static decl.
7570 * image.c (Finit_image_library): New forward static decl.
7571 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7572 * intervals.h (Fprevious_property_change):
7573 (Fremove_list_of_text_properties): Remove decls.
7574 * keyboard.c (Fthis_command_keys): Remove decl.
7575 (Fcommand_execute): New forward static decl.
7576 * keymap.c (Flookup_key): New forward static decl.
7577 (Fcopy_keymap): Now static.
7578 * keymap.h (Flookup_key): Remove decl.
7579 * process.c (Fget_process): New forward static decl.
7580 (Fprocess_datagram_address): Mark as internal.
7581 * syntax.c (Fsyntax_table_p): New forward static decl.
7582 (skip_chars): Remove duplicate decl.
7583 * textprop.c (Fprevious_property_change): New forward static decl.
7584 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7585 Now internal.
7586 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7587 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7589 * editfns.c (Fformat): Remove unreachable code.
7591 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7593 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7594 change. (Bug#8496)
7596 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7598 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7599 when at ZV. (Bug#8487)
7601 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7603 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7604 (Bug#8437)
7605 * keyboard.c (parse_tool_bar_item): Likewise.
7606 * sound.c (sound_cleanup, alsa_close): Likewise.
7607 * termcap.c (tgetent): Likewise.
7608 * xfns.c (x_default_font_parameter): Likewise.
7609 * xsettings.c (read_and_apply_settings): Likewise.
7611 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7612 (overrun_check_free): Protoize.
7614 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7616 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7617 since callers should never pass a negative size.
7618 Change the signature to match that of plain 'read' and 'write'; see
7619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7620 * lisp.h: Update prototypes of emacs_write and emacs_read.
7622 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7624 * xdisp.c (redisplay_window): Don't try to determine the character
7625 position of the scroll margin if the window start point w->startp
7626 is outside the buffer's accessible region. (Bug#8468)
7628 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7630 Fix write-region and its subroutines for buffers > 2GB.
7631 * fileio.c (a_write, e_write): Modify declaration of arguments and
7632 local variables to support buffers larger than 2GB.
7633 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7635 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7636 argument, local variables, and return value.
7638 * lisp.h: Update prototypes of emacs_write and emacs_read.
7640 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7642 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7644 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7646 Fix more problems found by GCC 4.6.0's static checks.
7648 * xdisp.c (vmessage): Use a better test for character truncation.
7650 * charset.c (load_charset_map): <, not <=, for optimization,
7651 and to avoid potential problems with integer overflow.
7652 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7653 * casetab.c (set_identity, shuffle): Likewise.
7654 * editfns.c (Fformat): Likewise.
7655 * syntax.c (skip_chars): Likewise.
7657 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7658 This also lets GCC 4.6.0 generate slightly better loop code.
7660 * callint.c (Fcall_interactively): <, not <=, for optimization.
7661 (Fcall_interactively): Count the number of arguments produced,
7662 not the number of arguments given. This is simpler and lets GCC
7663 4.6.0 generate slightly better code.
7665 * ftfont.c: Distingish more carefully between FcChar8 and char.
7666 The previous code passed unsigned char * to a functions like
7667 strlen and xstrcasecmp that expect char *, which does not
7668 conform to the C standard.
7669 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7670 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7671 char * when the C standard requires it.
7673 * keyboard.c (read_char): Remove unused var.
7675 * eval.c: Port to Windows vsnprintf (Bug#8435).
7676 Include <limits.h>.
7677 (SIZE_MAX): Define if the headers do not.
7678 (verror): Do not give up if vsnprintf returns a negative count.
7679 Instead, grow the buffer. This ports to Windows vsnprintf, which
7680 does not conform to C99. Problem reported by Eli Zaretskii.
7681 Also, simplify the allocation scheme, by avoiding the need for
7682 calling realloc, and removing the ALLOCATED variable.
7684 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7686 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7687 But keep the doprint source code for now, as we might revamp it
7688 and use it again (Bug#8435).
7689 * lisp.h (doprnt): Remove.
7690 * Makefile.in (base_obj): Remove doprnt.o.
7691 * deps.mk (doprnt.o): Remove.
7693 error: Print 32- and 64-bit integers portably (Bug#8435).
7694 Without this change, on typical 64-bit hosts error ("...%d...", N)
7695 was used to print both 32- and 64-bit integers N, which relied on
7696 undefined behavior.
7697 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7698 New macro.
7699 * lisp.h (error, verror): Mark as printf-like functions.
7700 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7701 Report overflow in size calculations when allocating printf buffer.
7702 Do not truncate output string at its first null byte.
7703 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7704 Truncate the output at a character boundary, since vsnprintf does not
7705 do that.
7706 * charset.c (check_iso_charset_parameter): Convert internal
7707 character to string before calling 'error', since %c now has the
7708 printf meaning.
7709 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7710 overflow when computing char to be passed to 'error'. Do not
7711 pass Lisp_Object to 'error'; pass the integer instead.
7712 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7713 formatted with plain %d.
7715 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7717 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7719 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7721 * xterm.c (x_catch_errors): Remove duplicate declaration.
7723 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7725 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7727 2011-04-10 Jim Meyering <meyering@redhat.com>
7729 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7730 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7731 return ssize_t not "int", and use size_t as the buffer length.
7732 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7733 * gnutls.h: Update declarations.
7734 * process.c (read_process_output): Use ssize_t, to match.
7735 (send_process): Likewise.
7737 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7739 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7741 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7743 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7744 Use unsigned char, to match FcChar8 type definition.
7746 * xterm.c (handle_one_xevent):
7747 * xmenu.c (create_and_show_popup_menu):
7748 * xselect.c (x_decline_selection_request)
7749 (x_reply_selection_request): Avoid type-punned deref of X events.
7751 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7753 Fix some uses of `int' instead of EMACS_INT.
7754 * search.c (string_match_1, fast_string_match)
7755 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7756 (scan_buffer, find_next_newline_no_quit)
7757 (find_before_next_newline, search_command, Freplace_match)
7758 (Fmatch_data): Make some `int' variables be EMACS_INT.
7760 * xdisp.c (display_count_lines): 3rd argument and return value now
7761 EMACS_INT. All callers changed.
7762 (pint2hrstr): Last argument is now EMACS_INT.
7764 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7765 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7766 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7767 (decode_coding_utf_16, decode_coding_emacs_mule)
7768 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7769 (decode_coding_ccl, decode_coding_charset)
7770 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7771 (decode_coding_iso_2022, decode_coding_emacs_mule)
7772 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7773 <char_offset, last_offset>: Declare EMACS_INT.
7774 (encode_coding_utf_8, encode_coding_utf_16)
7775 (encode_coding_emacs_mule, encode_invocation_designation)
7776 (encode_designation_at_bol, encode_coding_iso_2022)
7777 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7778 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7779 Declare EMACS_INT.
7780 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7781 (encode_invocation_designation): Last argument P_NCHARS is now
7782 EMACS_INT.
7783 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7784 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7786 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7787 All users changed.
7789 * ccl.c (Fccl_execute_on_string): Declare some variables
7790 EMACS_INT.
7792 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7794 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7796 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7798 * process.c (Fformat_network_address): Doc fix.
7800 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7802 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7804 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7806 * keyboard.c (read_char): Call Lisp function help-form-show,
7807 instead of using internal_with_output_to_temp_buffer.
7808 (Qhelp_form_show): New var.
7809 (syms_of_keyboard): Use DEFSYM macro.
7811 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7813 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7815 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7817 * process.c (Flist_processes): Remove to Lisp.
7818 (list_processes_1): Delete.
7820 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7822 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7824 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7826 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7828 Fix more problems found by GCC 4.6.0's static checks.
7830 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7832 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7834 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7836 * xdisp.c (vmessage): Mark as a printf-like function.
7838 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7840 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7842 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7843 printf-like functions.
7844 (tiff_load): Add casts to remove these marks before passing them
7845 to system-supplied API.
7847 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7849 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7850 This avoids several warnings with gcc -Wstrict-overflow.
7851 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7852 directly, rather than having caller test rule sign. This avoids
7853 some unnecessary tests.
7854 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7855 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7856 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7858 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7859 (xfont_open): Avoid unnecessary tests.
7861 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7863 * composite.h, composite.c (composition_gstring_put_cache):
7864 Use EMACS_INT, not int, for length.
7866 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7867 breaking out part of COMPOSITION_DECODE_RULE.
7868 (COMPOSITION_DECODE_RULE): Use it.
7869 * composite.c (get_composition_id): Remove unused local vars,
7870 by using the new macro.
7872 * textprop.c (set_text_properties_1): Change while to do-while,
7873 since the condition is always true at first.
7875 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7876 (interval_deletion_adjustment): Return unsigned value.
7877 All uses changed.
7879 * process.c (list_processes_1, create_pty, read_process_output):
7880 (exec_sentinel): Remove vars that were set but not used.
7881 (create_pty): Remove unnecessary "volatile"s.
7882 (Fnetwork_interface_info): Avoid possibility of int overflow.
7883 (read_process_output): Do adaptive read buffering even if carryover.
7884 (read_process_output): Simplify nbytes computation if buffered.
7886 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7888 * syntax.c (scan_words): Remove var that was set but not used.
7889 (update_syntax_table): Use unsigned instead of int.
7891 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7892 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7893 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7895 * print.c (print_error_message): Avoid int overflow.
7897 * font.c (font_list_entities): Redo for clarity,
7898 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7900 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7901 (font_score): Avoid potential overflow in diff calculation.
7903 * fns.c (substring_both): Remove var that is set but not used.
7904 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7906 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7908 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7909 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7910 can always succeed if overflow has undefined behavior.
7912 * search.c (boyer_moore, wordify): Remove vars set but not used.
7913 (wordify): Omit three unnecessary tests.
7915 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7916 All callers changed. This avoids the need for an unused var.
7918 * casefiddle.c (casify_region): Remove var that is set but not used.
7920 * dired.c (file_name_completion): Remove var that is set but not used.
7922 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7924 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7925 (Finsert_file_contents): Remove unnecessary code checking fd.
7927 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7928 Check for integer overflow on size calculations.
7930 * buffer.c (Fprevious_overlay_change): Remove var that is set
7931 but not used.
7933 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7934 Remove vars that are set but not used.
7935 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7936 (timer_check_2): Mark vars as initialized.
7938 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7940 * image.c (lookup_image): Remove var that is set but not used.
7941 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7943 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7944 that are set but not used.
7946 * xfns.c (make_invisible_cursor): Don't return garbage
7947 if XCreateBitmapFromData fails (Bug#8410).
7949 * xselect.c (x_get_local_selection, x_handle_property_notify):
7950 Remove vars that are set but not used.
7952 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7953 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7955 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7956 Remove var that is set but not used.
7957 (scroll_bar_windows_size): Now size_t, not int.
7958 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7959 Check for overflow.
7961 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7962 (map_tty_color) [!defined MSDOS]: Likewise.
7964 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7966 * coding.c: Remove vars that are set but not used.
7967 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7968 All callers changed.
7969 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7970 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7971 (decode_coding_charset): Remove vars that are set but not used.
7973 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7974 that is set but not used.
7976 * print.c (print_object): Remove var that is set but not used.
7978 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7979 The gnulib version avoids calling malloc in the usual case,
7980 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7981 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7982 * filelock.c (current_lock_owner): Likewise.
7983 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7984 * sysdep.c: Include allocator.h, careadlinkat.h.
7985 (emacs_no_realloc_allocator): New static constant.
7986 (emacs_readlink): New function.
7987 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7988 ../lib/careadlinkat.h.
7990 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7992 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7993 first non-nil return value).
7995 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7997 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7998 if not defined (Bug#8403).
8000 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8002 * xdisp.c (display_count_lines): Remove parameter `start',
8003 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8004 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8005 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8006 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8007 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8008 and thereabouts. All callers changed.
8009 (get_per_char_metric): Remove parameter `f', unused since
8010 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8012 2011-04-02 Jim Meyering <meyering@redhat.com>
8014 do not dereference NULL upon failed strdup
8015 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8016 (ns_get_family): Likewise.
8018 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8020 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8022 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8024 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8025 later (Bug#8403).
8027 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8029 Add lexical binding.
8031 * window.c (Ftemp_output_buffer_show): New fun.
8032 (Fsave_window_excursion):
8033 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8035 * lread.c (lisp_file_lexically_bound_p): New function.
8036 (Fload): Bind Qlexical_binding.
8037 (readevalloop): Remove `evalfun' arg.
8038 Bind Qinternal_interpreter_environment.
8039 (Feval_buffer): Bind Qlexical_binding.
8040 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8041 Mark as dynamic.
8042 (syms_of_lread): Declare `lexical-binding'.
8044 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8046 * keyboard.c (eval_dyn): New fun.
8047 (menu_item_eval_property): Use it.
8049 * image.c (parse_image_spec): Use Ffunctionp.
8051 * fns.c (concat, mapcar1): Accept byte-code-functions.
8053 * eval.c (Fsetq): Handle lexical vars.
8054 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8055 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8056 (FletX, Flet): Obey lexical binding.
8057 (Fcommandp): Handle closures.
8058 (Feval): New `lexical' arg.
8059 (eval_sub): New function extracted from Feval. Use it almost
8060 everywhere where Feval was used. Look up vars in lexical env.
8061 Handle closures.
8062 (Ffunctionp): Move from subr.el.
8063 (Ffuncall): Handle closures.
8064 (apply_lambda): Remove `eval_flags'.
8065 (funcall_lambda): Handle closures and new byte-code-functions.
8066 (Fspecial_variable_p): New function.
8067 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8068 but without exporting it to Lisp.
8070 * doc.c (Fdocumentation, store_function_docstring):
8071 * data.c (Finteractive_form): Handle closures.
8073 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8074 interactive spec.
8076 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8077 New byte-codes.
8078 (exec_byte_code): New function extracted from Fbyte_code to handle new
8079 calling convention for byte-code-functions. Add new byte-codes.
8081 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8083 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8085 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8087 * xdisp.c (redisplay_internal): Fix prototype.
8089 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8091 * xdisp.c (SCROLL_LIMIT): New macro.
8092 (try_scrolling): Use it when setting scroll_limit.
8093 Limit scrolling to 100 screen lines.
8094 (redisplay_window): Even when falling back on "recentering",
8095 position point in the window according to scroll-conservatively,
8096 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8098 (try_scrolling): When point is above the window, allow searching
8099 as far as scroll_max, or one screenful, to compute vertical
8100 distance from PT to the scroll margin position. This prevents
8101 try_scrolling from unnecessarily failing when
8102 scroll-conservatively is set to a value slightly larger than the
8103 window height. Clean up the case of PT below the margin at bottom
8104 of window: scroll_max can no longer be INT_MAX. When aggressive
8105 scrolling is in use, don't let point enter the opposite scroll
8106 margin as result of the scroll.
8107 (syms_of_xdisp) <scroll-conservatively>: Document the
8108 threshold of 100 lines for never-recentering scrolling.
8110 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8112 * dispextern.h (move_it_by_lines):
8113 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8114 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8115 (message_log_check_duplicate): Remove parameters `prev_bol' and
8116 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8117 (redisplay_internal): Remove parameter `preserve_echo_area',
8118 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8120 * indent.c (Fvertical_motion):
8121 * window.c (window_scroll_pixel_based, Frecenter):
8122 Don't pass `need_y_p' to `move_it_by_lines'.
8124 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8126 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8127 steal a few bits to be more compact.
8128 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8129 Remove unneeded casts.
8131 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8133 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8135 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8136 binding" message (bug#7967).
8138 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8140 Fix more problems found by GCC 4.6.0's static checks.
8142 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8143 Remove unused local var.
8145 * editfns.c (Fmessage_box): Remove unused local var.
8147 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8148 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8149 Omit unused local vars.
8150 * window.c (shrink_windows): Omit unused local var.
8151 * menu.c (digest_single_submenu): Omit unused local var.
8152 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8153 Omit unused local var.
8155 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8156 Don't assume string length fits in int.
8157 (keyremap_step, read_key_sequence): Use size_t for sizes.
8158 (read_key_sequence): Don't check last_real_key_start redundantly.
8160 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8161 instead of alloca (Bug#8344).
8163 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8164 (Fbacktrace_frame): Don't assume nframes fits in int.
8166 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8168 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8169 concerns.
8171 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8173 * cm.c (calccost): Turn while-do into do-while, for clarity.
8175 * keyboard.c (syms_of_keyboard): Use the same style as later
8176 in this function when indexing through an array. This also
8177 works around GCC bug 48267.
8179 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8181 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8183 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8184 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8186 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8187 This avoids undefined behavior on integer overflow, and is a bit
8188 more convenient anyway since it is compared to a size_t variable.
8190 Variadic C functions now count arguments with size_t, not int.
8191 This avoids an unnecessary limitation on 64-bit machines, which
8192 caused (substring ...) to crash on large vectors (Bug#8344).
8193 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8194 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8195 All variadic functions and their callers changed accordingly.
8196 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8197 * data.c (arith_driver, float_arith_driver): Likewise.
8198 * editfns.c (general_insert_function): Likewise.
8199 * eval.c (struct backtrace.nargs, interactive_p)
8200 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8201 (funcall_lambda, mark_backtrace): Likewise.
8202 * fns.c (concat): Likewise.
8203 * frame.c (x_set_frame_parameters): Likewise.
8204 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8205 0 if not found, not -1. All callers changed.
8207 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8208 (stack_copy_size): Now size_t, not int.
8209 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8211 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8213 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8214 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8215 All callers changed.
8217 * lisp.h (multibyte_char_to_unibyte):
8218 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8219 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8220 * character.h (CHAR_TO_BYTE8):
8221 * cmds.c (internal_self_insert):
8222 * editfns.c (general_insert_function):
8223 * keymap.c (push_key_description):
8224 * search.c (Freplace_match):
8225 * xdisp.c (message_dolog, set_message_1): All callers changed.
8227 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8229 * keyboard.c (safe_run_hook_funcall): New function.
8230 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8231 don't set the hook to nil, but remove the offending function instead.
8232 (Qcommand_hook_internal): Remove, unused.
8233 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8234 Vcommand_hook_internal.
8236 * eval.c (enum run_hooks_condition): Remove.
8237 (funcall_nil, funcall_not): New functions.
8238 (run_hook_with_args): Call each function through a `funcall' argument.
8239 Remove `cond' argument, now redundant.
8240 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8241 (Frun_hook_with_args_until_failure): Adjust accordingly.
8242 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8244 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8246 * dispextern.h (string_buffer_position): Remove declaration.
8248 * print.c (strout): Remove parameter `multibyte', unused since
8249 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8251 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8252 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8253 All callers changed.
8255 * w32.c (_wsa_errlist): Use braces for struct initializers.
8257 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8258 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8259 All callers changed.
8260 (string_buffer_position): Likewise. Also, make static (it's never
8261 used outside xdisp.c).
8262 (cursor_row_p): Remove parameter `w', unused since
8263 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8264 (decode_mode_spec): Remove parameter `precision', introduced during
8265 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8266 All callers changed.
8268 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8270 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8272 2011-03-27 Anders Lindgren <andlind@gmail.com>
8274 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8275 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8276 (ns_update_auto_hide_menu_bar): New functions.
8277 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8278 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8279 ns_constrain_all_frames.
8280 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8281 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8283 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8285 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8287 2011-03-27 Glenn Morris <rgm@gnu.org>
8289 * syssignal.h: Replace RETSIGTYPE with void.
8290 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8291 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8292 Replace SIGTYPE with void everywhere.
8293 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8294 * s/template.h (SIGTYPE): Remove commented out definition.
8296 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8298 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8299 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8301 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8303 * w32.c (read_unc_volume): Use parameter `henum', instead of
8304 global variable `wget_enum_handle'.
8306 * keymap.c (describe_vector): Remove parameters `indices' and
8307 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8308 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8310 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8312 * keyboard.c (timer_check): Remove parameter `do_it_now',
8313 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8314 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8315 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8317 * keyboard.c (read_char):
8318 * w32menu.c (w32_menu_display_help):
8319 * xmenu.c (show_help_event, menu_help_callback):
8320 Adjust calls to `show_help_echo'.
8322 * gtkutil.c (xg_maybe_add_timer):
8323 * keyboard.c (readable_events):
8324 * process.c (wait_reading_process_output):
8325 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8327 * insdel.c (adjust_markers_gap_motion):
8328 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8329 (gap_left, gap_right): Don't call it.
8331 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8333 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8334 incurred during fontification.
8336 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8338 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8339 (DEFVAR_PER_BUFFER): Don't pass it.
8341 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8342 (scrolling_window): Don't pass it.
8344 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8346 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8348 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8349 and `suffix'.
8350 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8351 of variables specific to SELinux and computation of `encoded_absname'.
8353 * image.c (XPutPixel): Remove unused variable `height'.
8355 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8357 * unexw32.c (get_section_info): Remove unused variable `section'.
8359 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8360 (system_process_attributes): Remove unused variable `sess'.
8361 (sys_read): Remove unused variable `err'.
8363 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8364 (w32_wnd_proc): Remove unused variable `isdead'.
8365 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8366 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8367 (x_create_tip_frame): Remove unused variable `tem'.
8369 * w32inevt.c (w32_console_read_socket):
8370 Remove unused variable `no_events'.
8372 * w32term.c (x_draw_composite_glyph_string_foreground):
8373 Remove unused variable `width'.
8375 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8377 * w32term.c (x_set_glyph_string_clipping):
8378 Don't pass uninitialized region to CombineRgn.
8380 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8382 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8383 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8384 (Fx_close_connection): Remove unused variable `i'.
8386 * w32font.c (w32font_draw): Return number of glyphs.
8387 (w32font_open_internal): Remove unused variable `i'.
8388 (w32font_driver): Add missing initializer.
8390 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8391 (fill_in_menu): Remove unused variable `items_added'.
8393 * w32term.c (last_mouse_press_frame): Remove static global variable.
8394 (w32_clip_to_row): Remove unused variable `f'.
8395 (x_delete_terminal): Remove unused variable `i'.
8397 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8398 (NOTHING): Remove unused static global variable.
8399 (uniscribe_check_otf): Remove unused variable `table'.
8400 (uniscribe_font_driver): Add missing initializers.
8402 2011-03-23 Julien Danjou <julien@danjou.info>
8404 * term.c (Fsuspend_tty, Fresume_tty):
8405 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8406 * window.c (temp_output_buffer_show):
8407 * insdel.c (signal_before_change):
8408 * frame.c (Fhandle_switch_frame):
8409 * fileio.c (Fdo_auto_save):
8410 * emacs.c (Fkill_emacs):
8411 * editfns.c (save_excursion_restore):
8412 * cmds.c (internal_self_insert):
8413 * callint.c (Fcall_interactively):
8414 * buffer.c (Fkill_all_local_variables):
8415 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8416 Use Frun_hooks.
8417 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8418 unconditionally since it does the check itself.
8420 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8422 Fix more problems found by GCC 4.5.2's static checks.
8424 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8425 the first time through the loop, since we know p0 < p1 then.
8426 This also avoids a gcc -Wstrict-overflow warning.
8428 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8429 leading to a memory leak, possible in functions like
8430 load_charset_map_from_file that can allocate an unbounded number
8431 of objects (Bug#8318).
8433 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8434 that could (at least in theory) be that large.
8436 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8437 This is less likely to overflow, and avoids undefined behavior if
8438 overflow does occur. All callers changed. Use strtoul to scan
8439 for the unsigned long integer.
8440 (pint2hrstr): Simplify and tune code slightly.
8441 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8443 * scroll.c (do_scrolling): Work around GCC bug 48228.
8444 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8446 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8447 This also avoids a warning with gcc -Wstrict-overflow.
8448 (validate_x_resource_name): Simplify count usage.
8449 This also avoids a warning with gcc -Wstrict-overflow.
8451 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8452 fail (Bug#8306).
8454 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8456 * process.c (Fmake_network_process): Use socklen_t, not int,
8457 where POSIX says socklen_t is required in portable programs.
8458 This fixes a porting bug on hosts like 64-bit HP-UX, where
8459 socklen_t is wider than int (Bug#8277).
8460 (Fmake_network_process, server_accept_connection):
8461 (wait_reading_process_output, read_process_output):
8462 Likewise.
8464 * process.c: Rename or move locals to avoid shadowing.
8465 (list_processes_1, Fmake_network_process):
8466 (read_process_output_error_handler, exec_sentinel_error_handler):
8467 Rename or move locals.
8468 (Fmake_network_process): Define label "retry_connect" only if needed.
8469 (Fnetwork_interface_info): Fix pointer signedness.
8470 (process_send_signal): Add cast to avoid pointer signedness problem.
8471 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8472 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8474 Make tparam.h and terminfo.c consistent.
8475 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8476 Include tparam.h instead, since it declares them.
8477 * cm.h (PC): Remove extern decl; tparam.h now does this.
8478 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8479 * terminfo.c: Include tparam.h, to check interfaces.
8480 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8481 (tparam): Adjust signature to match interface in tparam.h;
8482 this removes some undefined behavior. Check that outstring and len
8483 are zero, which they always are with Emacs.
8484 * tparam.h (PC, BC, UP): New extern decls.
8486 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8487 (xftfont_open): Rename locals to avoid shadowing.
8489 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8490 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8491 (OTF_TAG_SYM): Omit macro if not needed.
8492 (ftfont_list): Remove unused local.
8493 (get_adstyle_property, ftfont_pattern_entity):
8494 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8495 Rename locals to avoid shadowing.
8497 * xfont.c (xfont_list_family): Mark var as initialized.
8499 * xml.c (make_dom): Now static.
8501 * composite.c (composition_compute_stop_pos): Rename local to
8502 avoid shadowing.
8503 (composition_reseat_it): Remove unused locals.
8504 (find_automatic_composition, composition_adjust_point): Likewise.
8505 (composition_update_it): Mark var as initialized.
8506 (find_automatic_composition): Mark vars as initialized,
8507 with a FIXME (Bug#8290).
8509 character.h: Rename locals to avoid shadowing.
8510 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8511 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8512 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8513 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8514 to avoid shadowing.
8516 * textprop.c (property_change_between_p): Remove; unused.
8518 * intervals.c (interval_start_pos): Now static.
8520 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8522 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8523 Rename locals to avoid shadowing.
8525 * sound.c (wav_play, au_play, Fplay_sound_internal):
8526 Fix pointer signedness.
8527 (alsa_choose_format): Remove unused local var.
8528 (wav_play): Initialize a variable to 0, to prevent undefined
8529 behavior (Bug#8278).
8531 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8533 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8536 clobbering (Bug#8298).
8537 * sysdep.c (sys_subshell): Likewise.
8538 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8540 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8541 This should get cleaned up, so that child_setup has the
8542 same signature on all platforms.
8544 * callproc.c (call_process_cleanup): Now static.
8545 (relocate_fd): Rename locals to avoid shadowing.
8547 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8549 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8550 not to be necessary, and produces flickering.
8552 2011-03-20 Glenn Morris <rgm@gnu.org>
8554 * config.in: Remove file.
8556 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8558 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8559 are now in src/globals.h.
8560 (syms_of_minibuf): Remove spurious & from previous change.
8562 2011-03-20 Leo Liu <sdl.web@gmail.com>
8564 * minibuf.c (completing-read-function): New variable.
8565 (completing-read-default): Rename from completing-read.
8566 (completing-read): Call completing-read-function.
8568 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8570 * xfaces.c (Fx_load_color_file):
8571 Read color file from absolute filename (bug#8250).
8573 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8575 * makefile.w32-in: Update dependencies.
8577 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8579 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8581 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8583 Fix more problems found by GCC 4.5.2's static checks.
8585 * process.c (make_serial_process_unwind, send_process_trap):
8586 (sigchld_handler): Now static.
8588 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8589 That way, the code declares only the vars that it needs.
8590 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8591 * s/cygwin.h (PTY_ITERATION): Likewise.
8592 * s/darwin.h (PTY_ITERATION): Likewise.
8593 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8595 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8596 * process.c (allocate_pty): Don't declare stb unless it's needed.
8598 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8599 (CONSTANTLIM): Remove; unused.
8600 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8601 Define only if needed.
8603 * unexelf.c (unexec): Name an expression,
8604 to avoid gcc -Wbad-function-cast warning.
8605 Use a different way to cause a compilation error if anyone uses
8606 n rather than nn, a way that does not involve shadowing.
8607 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8609 * deps.mk (unexalpha.o): Remove; unused.
8611 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8612 * unexec.h: New file.
8613 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8614 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8615 Depend on unexec.h.
8616 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8617 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8618 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8619 Change as necessary to match prototype in unexec.h.
8621 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8622 shadowing.
8623 (back_comment, skip_chars): Mark vars as initialized.
8625 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8626 Rename locals to avoid shadowing.
8628 * lread.c (read1): Rewrite so as not to use empty "else".
8629 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8631 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8633 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8634 warning when compiling print.c.
8636 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8637 instead of using an uninitialized var.
8638 (font_sort_entities): Mark var as initialized.
8640 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8642 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8643 pointers to constants.
8644 (font_parse_fcname): Remove unused vars.
8645 (font_delete_unmatched): Now static.
8646 (font_get_spec): Remove; unused.
8647 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8648 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8649 Rename or move locals to avoid shadowing.
8651 * fns.c (require_nesting_list, require_unwind): Now static.
8652 (Ffillarray): Rename locals to avoid shadowing.
8654 * floatfns.c (domain_error2): Define only if needed.
8655 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8657 * alloc.c (mark_backtrace): Move decl from here ...
8658 * lisp.h: ... to here, so that it can be checked.
8660 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8661 (Fdefvar): Rewrite so as not to use empty "else".
8662 (lisp_indirect_variable): Name an expression,
8663 to avoid gcc -Wbad-function-cast warning.
8664 (Fdefvar): Rename locals to avoid shadowing.
8666 * callint.c (quotify_arg, quotify_args): Now static.
8667 (Fcall_interactively): Rename locals to avoid shadowing.
8668 Use const pointer when appropriate.
8670 * lisp.h (get_system_name, get_operating_system_release):
8671 Move decls here, to check interfaces.
8672 * process.c (get_operating_system_release): Move decl to lisp.h.
8673 * xrdb.c (get_system_name): Likewise.
8674 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8675 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8676 some of which prompt warnings from gcc -Wbad-function-cast.
8677 (Fformat_time_string, Fencode_time, Finsert_char):
8678 (Ftranslate_region_internal, Fformat):
8679 Rename or remove local vars to avoid shadowing.
8680 (Ftranslate_region_internal): Mark var as initialized.
8682 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8683 avoid shadowing.
8685 * lisp.h (eassert): Check that the argument compiles, even if
8686 ENABLE_CHECKING is not defined.
8688 * data.c (Findirect_variable): Name an expression, to avoid
8689 gcc -Wbad-function-cast warning.
8690 (default_value, arithcompare, arith_driver, arith_error): Now static.
8691 (store_symval_forwarding): Rename local to avoid shadowing.
8692 (Fmake_variable_buffer_local, Fmake_local_variable):
8693 Mark variables as initialized.
8694 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8696 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8697 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8698 Rename locals to avoid shadowing.
8699 (mark_stack): Move local variables into the #ifdef region where
8700 they're used.
8701 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8702 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8703 needed otherwise.
8704 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8705 (GC_STRING_CHARS): Remove; not used.
8706 (Fmemory_limit): Cast sbrk's returned value to char *.
8708 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8709 avoids undefined behavior in theory.
8711 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8713 Use functions, not macros, for up- and down-casing (Bug#8254).
8714 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8716 to use the following functions instead of these macros.
8717 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8718 EMACS_INT, since callers assume the returned value fits in int.
8719 (upcase1): Likewise, for UPCASE_TABLE.
8720 (uppercasep, lowercasep, upcase): New static inline functions.
8721 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8722 the race-condition problem in the old DOWNCASE.
8724 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8725 Rename locals to avoid shadowing.
8726 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8727 (regex_compile, re_search_2, re_match_2_internal):
8728 Remove unused local vars.
8729 (FREE_VAR): Rewrite so as not to use empty "else",
8730 which gcc can warn about.
8731 (regex_compile, re_match_2_internal): Mark locals as initialized.
8732 (RETALLOC_IF): Define only if needed.
8733 (WORDCHAR_P): Likewise. This one is never needed, but is used
8734 only in a comment talking about a compiler bug, so put inside
8735 the #if 0 of that comment.
8736 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8737 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8738 Remove; unused.
8740 * search.c (boyer_moore): Rename locals to avoid shadowing.
8741 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8742 (PREV_CHAR_BOUNDARY): Likewise.
8744 * search.c (simple_search): Remove unused var.
8746 * dired.c (compile_pattern): Move decl from here ...
8747 * lisp.h: ... to here, so that it can be checked.
8748 (struct re_registers): New forward decl.
8750 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8752 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8753 All uses changed.
8754 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8755 Rename locals to avoid shadowing.
8756 (Fvertical_motion): Mark locals as initialized.
8758 * casefiddle.c (casify_object, casify_region): Now static.
8759 (casify_region): Mark local as initialized.
8761 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8763 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8764 New macros, so that the caller can use some names other than
8765 gcpro1, gcpro2, etc.
8766 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8767 of the new macros.
8768 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8769 argument, for consistency with GCPRO2_VAR, etc: it is now the
8770 prefix of the variable, not the variable itself. All uses
8771 changed.
8772 * dired.c (directory_files_internal, file_name_completion):
8773 Rename locals to avoid shadowing.
8775 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8776 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8777 dired.c's scmp function, had undefined behavior.
8778 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8779 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8780 * buffer.h: ... to here, because these macros use current_buffer,
8781 and the new implementation with inline functions needs to have
8782 current_buffer in scope now, rather than later when the macros
8783 are used.
8784 (downcase, upcase1): New static inline functions.
8785 (DOWNCASE, UPCASE1): Reimplement using these functions.
8786 This avoids undefined behavior in expressions like
8787 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8788 from race conditions in accessing the global variables
8789 case_temp1 and case_temp2.
8790 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8791 * lisp.h (case_temp1, case_temp2): Remove their decls.
8792 * character.h (ASCII_CHAR_P): Move from here ...
8793 * lisp.h: ... to here, so that the inline functions mentioned
8794 above can use them.
8796 * dired.c (directory_files_internal_unwind): Now static.
8798 * fileio.c (file_name_as_directory, directory_file_name):
8799 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8800 Now static.
8801 (file_name_as_directory): Use const pointers when appropriate.
8802 (Fexpand_file_name): Likewise. In particular, newdir might
8803 point at constant storage, so make it a const pointer.
8804 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8805 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8806 signedness issues.
8807 (Fset_file_times, Finsert_file_contents, auto_save_error):
8808 Rename locals to avoid shadowing.
8810 * minibuf.c (choose_minibuf_frame_1): Now static.
8811 (Ftry_completion, Fall_completions): Rename or remove locals
8812 to avoid shadowing.
8814 * marker.c (bytepos_to_charpos): Remove; unused.
8816 * lisp.h (verify_bytepos, count_markers): New decls,
8817 so that gcc does not warn that these functions aren't declared.
8819 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8820 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8821 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8822 (copy_text): Remove unused local var.
8824 * filelock.c (within_one_second): Now static.
8825 (lock_file_1): Rename local to avoid shadowing.
8827 * buffer.c (fix_overlays_before): Mark locals as initialized.
8828 (fix_start_end_in_overlays): Likewise. This function should be
8829 simplified by using pointers-to-pointers, but that's a different
8830 matter.
8831 (switch_to_buffer_1): Now static.
8832 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8833 (report_overlay_modification): Rename locals to avoid shadowing.
8835 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8836 Fix pointer signedness issue.
8837 (sys_subshell): Mark local as volatile if checking for lint,
8838 to suppress a gcc -Wclobbered warning that does not seem to be right.
8839 (MAXPATHLEN): Define only if needed.
8841 * process.c (serial_open, serial_configure): Move decls from here ...
8842 * systty.h: ... to here, so that they can be checked.
8844 * fns.c (get_random, seed_random): Move extern decls from here ...
8845 * lisp.h: ... to here, so that they can be checked.
8847 * sysdep.c (reset_io): Now static.
8848 (wait_for_termination_signal): Remove; unused.
8850 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8851 (copy_keymap_item, append_key, push_text_char_description):
8852 Now static.
8853 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8854 (DENSE_TABLE_SIZE): Remove; unused.
8855 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8856 (describe_map_tree):
8857 Rename locals to avoid shadowing.
8859 * keyboard.c: Declare functions static if they are not used elsewhere.
8860 (echo_char, echo_dash, cmd_error, top_level_2):
8861 (poll_for_input, handle_async_input): Now static.
8862 (read_char, kbd_buffer_get_event, make_lispy_position):
8863 (make_lispy_event, make_lispy_movement, apply_modifiers):
8864 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8865 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8866 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8867 (read_key_sequence, read_char): Mark locals as initialized.
8868 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8870 * keyboard.h (make_ctrl_char): New decl.
8871 (mark_kboards): Move decl here ...
8872 * alloc.c (mark_kboards): ... from here.
8874 * lisp.h (force_auto_save_soon): New decl.
8876 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8877 (DEFINE_DUMMY_FUNCTION): New macro.
8878 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8879 Use it.
8880 (main): Add casts to avoid warnings
8881 if GCC considers string literals to be constants.
8883 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8885 * dbusbind.c: Pointer signedness fixes.
8886 (xd_signature, xd_append_arg, xd_initialize):
8887 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8888 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8889 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8890 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8892 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8893 if GCC considers string literals to be constants.
8894 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8896 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8898 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8899 (print_preprocess, print_object): New macro to fix last change.
8901 * print.c (print_preprocess): Don't forget font objects.
8903 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8905 * emacs.c (USAGE3): Doc fixes.
8907 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8909 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8910 structure.
8912 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8914 * lisp.h (VWindow_system, Qfile_name_history):
8915 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8916 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8917 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8919 * w32select.c: Don't #include "keyboard.h".
8920 (run_protected): Add extern declaration for waiting_for_input.
8922 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8923 * w32console.c (detect_input_pending, read_input_pending)
8924 (encode_terminal_code):
8925 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8926 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8927 (w32_system_caret_y, Qfile_name_history):
8928 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8929 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8930 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8931 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8932 * w32proc.c (Qlocal, report_file_error):
8933 * w32term.c (Vwindow_system, updating_frame):
8934 * w32uniscribe.c (initialized, uniscribe_font_driver):
8935 Remove unneeded extern declarations.
8937 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8939 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8941 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8943 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8944 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8945 These macros can no longer be used for assignment.
8947 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8948 Assign struct members directly, instead of using BUF_BEGV etc.
8949 (record_buffer_markers, fetch_buffer_markers): New functions for
8950 recording and fetching special buffer markers.
8951 (set_buffer_internal_1, set_buffer_temp): Use them.
8953 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8955 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8957 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8958 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8960 * xdisp.c (hscroll_window_tree):
8961 (reconsider_clip_changes): Use PT instead of BUF_PT.
8963 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8965 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8966 $(EMACS_ROOT)/lib/intprops.h.
8968 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8970 Fix more problems found by GCC 4.5.2's static checks.
8972 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8973 to unsigned char * to avoid compiler diagnostic.
8974 (xg_free_frame_widgets): Make it clear that a local variable is
8975 needed only if USE_GTK_TOOLTIP.
8976 (gdk_window_get_screen): Make it clear that this macro is needed
8977 only if USE_GTK_TOOLTIP.
8978 (int_gtk_range_get_value): New function, which avoids a diagnostic
8979 from gcc -Wbad-function-cast.
8980 (xg_set_toolkit_scroll_bar_thumb): Use it.
8981 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8982 diagnostic from gcc -Wbad-function-cast.
8983 (get_utf8_string, xg_get_file_with_chooser):
8984 Rename locals to avoid shadowing.
8985 (create_dialog): Move locals to avoid shadowing.
8987 * xgselect.c (xg_select): Remove unused var.
8989 * image.c (four_corners_best): Mark locals as initialized.
8990 (gif_load): Initialize transparent_p to zero (Bug#8238).
8991 Mark another local as initialized.
8992 (my_png_error, my_error_exit): Mark with NO_RETURN.
8994 * image.c (clear_image_cache): Now static.
8995 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8996 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8997 (x_edge_detection): Remove unnecessary cast that
8998 gcc -Wbad-function-cast diagnoses.
8999 (gif_load): Fix pointer signedness.
9000 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9001 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9003 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9005 Improve quality of tests for time stamp overflow.
9006 For example, without this patch (encode-time 0 0 0 1 1
9007 1152921504606846976) returns the obviously-bogus value (-948597
9008 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9009 reports time overflow. See
9010 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9011 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9012 * editfns.c: Include limits.h and intprops.h.
9013 (TIME_T_MIN, TIME_T_MAX): New macros.
9014 (time_overflow): Move earlier, to before first use.
9015 (hi_time, lo_time): New functions, for an accurate test for
9016 out-of-range times.
9017 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9018 (Fget_internal_run_time): Don't assume time_t fits in int.
9019 (make_time): Use list2 instead of Fcons twice.
9020 (Fdecode_time): More accurate test for out-of-range times.
9021 (check_tm_member): New function.
9022 (Fencode_time): Use it, to test for out-of-range times.
9023 (lisp_time_argument): Don't rely on undefined left-shift and
9024 right-shift behavior when checking for time stamp overflow.
9026 * editfns.c (time_overflow): New function, refactoring common code.
9027 (Fformat_time_string, Fdecode_time, Fencode_time):
9028 (Fcurrent_time_string): Use it.
9030 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9031 * dired.c (make_time): Move to ...
9032 * editfns.c (make_time): ... here.
9033 * systime.h: Note the move.
9035 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9037 * fringe.c (update_window_fringes): Remove unused variables.
9039 * unexmacosx.c (copy_data_segment): Also copy __got section.
9040 (Bug#8223)
9042 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9044 * termcap.c [MSDOS]: Include "msdos.h".
9045 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9046 Constify `char *' arguments and their references according to
9047 prototypes in tparam.h.
9049 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9051 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9052 Adapt all references accordingly.
9054 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9056 2011-03-11 Tom Tromey <tromey@redhat.com>
9058 * buffer.c (syms_of_buffer): Remove obsolete comment.
9060 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9062 * termhooks.h (encode_terminal_code): Declare prototype.
9064 * msdos.c (encode_terminal_code): Don't declare prototype.
9066 * term.c (encode_terminal_code): Now external again, used by
9067 w32console.c and msdos.c.
9069 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9070 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9072 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9074 Fix some minor problems found by GCC 4.5.2's static checks.
9076 * fringe.c (update_window_fringes): Mark locals as initialized
9077 (Bug#8227).
9078 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9080 * alloc.c (mark_fringe_data): Move decl from here ...
9081 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9082 to check its interface.
9083 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9085 * fontset.c (free_realized_fontset): Now static.
9086 (Fset_fontset_font): Rename local to avoid shadowing.
9087 (fontset_font): Mark local as initialized.
9088 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9090 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9092 * xselect.c (x_disown_buffer_selections): Remove; not used.
9093 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9094 (x_own_selection, Fx_disown_selection_internal): Rename locals
9095 to avoid shadowing.
9096 (x_handle_dnd_message): Remove local to avoid shadowing.
9098 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9099 so that the caller can use some name other than gcpro1.
9100 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9101 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9102 (Fx_backspace_delete_keys_p):
9103 Use them to avoid shadowing, and rename vars to avoid shadowing.
9104 (x_decode_color, x_set_name, x_window): Now static.
9105 (Fx_create_frame): Add braces to silence GCC warning.
9106 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9107 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9108 Remove unused locals.
9109 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9110 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9111 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9112 macros.
9114 * xterm.h (x_mouse_leave): New decl.
9116 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9117 Remove unused functions.
9118 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9119 (x_calc_absolute_position): Now static.
9120 (XTread_socket): Don't define label "out" unless it's used.
9121 Don't declare local "event" unless it's used.
9122 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9123 unless they are used.
9124 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9125 (x_fatal_error_signal): Remove; not used.
9126 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9127 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9128 (x_error_catcher, x_connection_closed, x_error_handler):
9129 (x_error_quitter, xembed_send_message, x_iconify_frame):
9130 (my_log_handler): Rename locals to avoid shadowing.
9131 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9132 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9134 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9135 Rename or move locals to avoid shadowing.
9136 (tty_defined_color, merge_face_heights): Now static.
9137 (free_realized_faces_for_fontset): Remove; not used.
9138 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9139 does not deduce is never used uninitialized.
9140 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9141 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9143 * terminal.c (store_terminal_param): Now static.
9145 * xmenu.c (menu_highlight_callback): Now static.
9146 (set_frame_menubar): Remove unused local.
9147 (xmenu_show): Rename parameter to avoid shadowing.
9148 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9149 since they might point to immutable storage.
9150 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9151 since it's unused otherwise.
9153 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9154 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9155 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9156 avoids a gcc -Wuninitialized diagnostic.
9157 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9158 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9159 does not deduce are never used uninitialized.
9161 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9163 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9164 * window.c (window_loop, size_window):
9165 (run_window_configuration_change_hook, enlarge_window): Likewise.
9167 * window.c (display_buffer): Now static.
9168 (size_window): Mark variables that gcc -Wuninitialized
9169 does not deduce are never used uninitialized.
9170 * window.h (check_all_windows): New decl, to forestall
9171 gcc -Wmissing-prototypes diagnostic.
9172 * dispextern.h (bidi_dump_cached_states): Likewise.
9174 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9175 shadowing.
9176 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9177 Include <limits.h>.
9178 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9179 and to avoid gcc -Wuninitialized warning.
9180 (load_charset_map): Mark variables that gcc -Wuninitialized
9181 does not deduce are never used uninitialized.
9182 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9184 * coding.c (coding_set_source, coding_set_destination):
9185 Use "else { /* comment */ }" rather than "else /* comment */;"
9186 for clarity, and to avoid gcc -Wempty-body warning.
9187 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9188 a block, when the outer 'i' will do.
9189 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9190 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9191 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9192 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9193 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9194 Rename locals to avoid shadowing.
9195 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9196 * coding.c (emacs_mule_char, encode_invocation_designation):
9197 Now static, since they're not used elsewhere.
9198 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9199 (decode_coding_object, encode_coding_object, detect_coding_system):
9200 (decode_coding_emacs_mule): Mark variables that gcc
9201 -Wuninitialized does not deduce are never used uninitialized.
9202 (detect_coding_iso_2022): Initialize a local variable that might
9203 be used uninitialized. Leave a FIXME because it's not clear that
9204 this initialization is needed. (Bug#8211)
9205 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9206 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9207 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9208 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9209 Remove unused macros.
9211 * category.c (hash_get_category_set): Remove unused local var.
9212 (copy_category_table): Now static, since it's not used elsewhere.
9213 * character.c (string_count_byte8): Likewise.
9215 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9216 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9218 * chartab.c (copy_sub_char_table): Now static, since it's not used
9219 elsewhere.
9220 (sub_char_table_ref_and_range, char_table_ref_and_range):
9221 Rename locals to avoid shadowing.
9222 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9224 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9225 (BIDI_BOB): Remove unused macro.
9227 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9228 deduce are never used uninitialized.
9229 * term.c (encode_terminal_code): Likewise.
9231 * term.c (encode_terminal_code): Now static. Remove unused local.
9233 * tparam.h: New file.
9234 * term.c, tparam.h: Include it.
9235 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9236 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9237 Move these decls to tparam.h, and make them agree with what
9238 is actually in tparam.c. The previous trick of using incompatible
9239 decls in different modules does not conform to the C standard.
9240 All callers of tparam changed to use tparam's actual API.
9241 * tparam.c (tparam1, tparam, tgoto):
9242 Use const pointers where appropriate.
9244 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9245 * cm.h (struct cm): Likewise.
9246 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9247 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9248 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9249 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9250 (turn_on_face, init_tty): Likewise.
9251 * termchar.h (struct tty_display_info): Likewise.
9253 * term.c (term_mouse_position): Rename local to avoid shadowing.
9255 * alloc.c (mark_ttys): Move decl from here ...
9256 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9258 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9260 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9262 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9264 * search.c (compile_pattern_1): Remove argument regp, unused since
9265 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9266 (compile_pattern): Don't pass it.
9268 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9270 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9271 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9272 for ! HAVE_GTK3.
9273 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9275 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9277 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9278 gdk_window_get_screen, gdk_window_get_geometry,
9279 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9280 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9281 (xg_get_pixbuf_from_pixmap): New function.
9282 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9283 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9284 Call xg_get_pixbuf_from_pixmap instead of
9285 gdk_pixbuf_get_from_drawable.
9286 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9287 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9288 (xg_check_special_colors): Use GtkStyleContext and its functions
9289 for HAVE_GTK3.
9290 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9291 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9292 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9293 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9294 Call gtk_widget_get_preferred_size.
9295 (xg_frame_resized): gdk_window_get_geometry only takes 5
9296 parameters.
9297 (xg_win_to_widget, xg_event_is_for_menubar):
9298 Call gdk_x11_window_lookup_for_display.
9299 (xg_set_widget_bg): New function.
9300 (delete_cb): New function.
9301 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9302 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9303 (xg_set_background_color): Call xg_set_widget_bg.
9304 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9305 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9306 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9307 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9308 if ! HAVE_GTK3.
9309 (update_frame_tool_bar): Call gtk_widget_hide.
9310 (xg_initialize): Use GDK_KEY_g.
9312 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9313 if ! HAVE_GTK3
9314 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9316 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9317 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9318 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9320 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9322 * w32xfns.c (select_palette): Check success of RealizePalette against
9323 GDI_ERROR, not zero.
9325 See ChangeLog.11 for earlier changes.
9327 ;; Local Variables:
9328 ;; coding: utf-8
9329 ;; End:
9331 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9333 This file is part of GNU Emacs.
9335 GNU Emacs is free software: you can redistribute it and/or modify
9336 it under the terms of the GNU General Public License as published by
9337 the Free Software Foundation, either version 3 of the License, or
9338 (at your option) any later version.
9340 GNU Emacs is distributed in the hope that it will be useful,
9341 but WITHOUT ANY WARRANTY; without even the implied warranty of
9342 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9343 GNU General Public License for more details.
9345 You should have received a copy of the GNU General Public License
9346 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.