1 2012-04-20 Glenn Morris <rgm@gnu.org>
3 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6 2012-04-20 Eli Zaretskii <eliz@gnu.org>
8 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
9 overrun array limits of glyph row's used[] array. (Bug#11288)
11 2012-04-20 Chong Yidong <cyd@gnu.org>
13 * process.c (wait_reading_process_output): If EIO occurs on a pty,
14 set the status to "failed" and ensure that sentinel is run.
16 2012-04-18 Glenn Morris <rgm@gnu.org>
18 * process.c (Fset_process_inherit_coding_system_flag)
19 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
20 (Fmake_network_process, Fmake_serial_process): Doc fix.
22 2012-04-17 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (string_buffer_position_lim): Limit starting position to
26 (set_cursor_from_row): If called for a mode-line or header-line
27 row, return zero immediately.
28 (try_cursor_movement): If inside continuation line, don't back up
29 farther than the first row after the header line, if any. Don't
30 consider the header-line row as "partially visible", even if
31 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
33 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
35 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
37 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
39 * process.c (make_process):
40 * process.h: Add integer `gnutls_handshakes_tried' member to
43 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
44 Add convenience `GNUTLS_LOG2i' macro.
46 * gnutls.c (gnutls_log_function2i): Convenience log function.
47 (emacs_gnutls_read): Use new log functions,
48 `gnutls_handshakes_tried' process member, and
49 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
50 attempts per process (connection).
52 2012-04-09 Eli Zaretskii <eliz@gnu.org>
54 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
55 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
57 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
59 * nsterm.m (constrainFrameRect): Always constrain when there is only
60 one screen (Bug#10962).
62 2012-04-06 Eli Zaretskii <eliz@gnu.org>
64 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
65 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
66 about subtle differences between FETCH_CHAR* and STRING_CHAR*
67 macros related to unification of CJK characters. For the details,
68 see the discussion following the message here:
69 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
71 2012-04-04 Chong Yidong <cyd@gnu.org>
73 * keyboard.c (Vdelayed_warnings_list): Doc fix.
75 2012-04-01 Eli Zaretskii <eliz@gnu.org>
77 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
78 instead of alloca. (Bug#11138)
80 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
82 * w32menu.c (is_simple_dialog): Properly check lisp types.
85 2012-03-31 Eli Zaretskii <eliz@gnu.org>
87 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
88 position we get to after a call to move_it_to fails the
89 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
90 only if we wind up in a string from display property. (Bug#11063)
92 * window.c (Fdelete_other_windows_internal): Invalidate the row
93 and column information about mouse highlight, so that redisplay
94 restores it after reallocating the glyph matrices. (Bug#7464)
96 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
97 string comes from a `display' text property, use the buffer
98 position of that property as if we actually saw that position in
100 (move_it_by_lines): Remove the assertion that
101 "it->current_x == 0 && it->hpos == 0" which can be legitimately
102 violated when there's a before-string at the beginning of a line.
105 2012-03-30 Eli Zaretskii <eliz@gnu.org>
107 * xdisp.c (append_space_for_newline): If the default face was
108 remapped, use the remapped face for the appended newline.
109 (extend_face_to_end_of_line): Use the remapped default face for
110 extending the face to the end of the line.
111 (display_line): Call extend_face_to_end_of_line when the default
112 face was remapped. (Bug#11068)
114 2012-03-29 Eli Zaretskii <eliz@gnu.org>
116 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
118 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
120 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
122 2012-03-27 Glenn Morris <rgm@gnu.org>
124 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
127 2012-03-26 Kenichi Handa <handa@m17n.org>
129 * dispextern.h (struct glyph): Fix previous change. Change the
130 bit length of glyphless.ch to 25 (Bug#11082).
132 2012-03-26 Chong Yidong <cyd@gnu.org>
134 * keyboard.c (Vselection_inhibit_update_commands): New variable.
135 (command_loop_1): Use it; inhibit selection update for
136 handle-select-window too (Bug#8996).
138 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
140 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
142 2012-03-25 Kenichi Handa <handa@m17n.org>
144 * dispextern.h (struct glyph): Change the bit length of
145 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
147 2012-03-24 Eli Zaretskii <eliz@gnu.org>
149 * s/ms-w32.h (tzname): Include time.h before redirecting to
150 _tzname. Fixes the MSVC build. (Bug#9960)
152 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
154 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
157 * xterm.c (XTread_socket): Only modify handling_signal if
158 !SYNC_INPUT. (Bug#11080)
160 2012-03-23 Eli Zaretskii <eliz@gnu.org>
162 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
163 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
164 when fetching a multibyte character consumes more bytes than
165 CHAR_BYTES returns, due to unification of CJK characters in
166 string_char. (Bug#11073)
168 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
170 * process.c (wait_reading_process_output): Handle pty disconnect
171 by refraining from sending oneself a SIGCHLD (bug#10933).
173 2012-03-22 Chong Yidong <cyd@gnu.org>
175 * dispextern.h (struct it): New member string_from_prefix_prop_p.
177 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
178 Mark string as coming from a prefix property.
179 (handle_face_prop): Use default face for prefix strings (Bug#4281).
180 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
182 2012-03-21 Chong Yidong <cyd@gnu.org>
184 * xfaces.c (Vface_remapping_alist): Doc fix.
186 2012-03-20 Eli Zaretskii <eliz@gnu.org>
188 * w32proc.c (Fw32_set_console_codepage)
189 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
192 2012-03-20 Chong Yidong <cyd@gnu.org>
194 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
195 to reflect default non-nil value of redisplay-dont-pause.
197 2012-03-19 Kenichi Handa <handa@m17n.org>
199 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
200 it fit in a valid range (Bug#11003).
202 2012-03-18 Eli Zaretskii <eliz@gnu.org>
204 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
205 that is not from display property, accept the row as a "cursor
206 row" if one of the string's character has a non-nil `cursor'
207 property. Fixes cursor positioning when there are newlines in
208 overlay strings, e.g. in icomplete.el. (Bug#11035)
210 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
212 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
214 2012-03-12 Chong Yidong <cyd@gnu.org>
216 * eval.c (inhibit_lisp_code): Rename from
217 inhibit_window_configuration_change_hook; move from window.c.
219 * xfns.c (unwind_create_frame_1, Fx_create_frame):
220 * window.c (run_window_configuration_change_hook)
221 (syms_of_window): Callers changed.
223 2012-03-11 Chong Yidong <cyd@gnu.org>
225 * keymap.c (Fkey_description): Doc fix (Bug#9700).
227 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
229 2012-03-10 Chong Yidong <cyd@gnu.org>
231 * frame.c (other_visible_frames): Don't assume the selected frame
232 is visible (Bug#10955).
234 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
236 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
238 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
240 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
241 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
244 2012-03-03 Glenn Morris <rgm@gnu.org>
246 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
248 2012-03-02 Eli Zaretskii <eliz@gnu.org>
250 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
251 position past the first glyph_row that ends at ZV. (Bug#10902)
252 (redisplay_window, next_element_from_string): Fix typos in
254 (redisplay_window): Pass to move_it_vertically the margin in
255 pixels, not in screen lines.
257 2012-03-02 Glenn Morris <rgm@gnu.org>
259 * buffer.c (buffer-list-update-hook): Doc fix.
261 2012-02-29 Eli Zaretskii <eliz@gnu.org>
263 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
264 push_it before setting up the iterator for the first overlay
265 string, even if we have an empty string loaded.
266 (next_overlay_string): If there's an empty string on the iterator
267 stack, pop the stack. (Bug#10903)
269 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
271 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
272 Suggested by Stefan Monnier in
273 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
274 * alloc.c (widen_to_Lisp_Object): New static function.
275 (mark_memory): Also mark Lisp_Objects by fetching pointer words
276 and widening them to Lisp_Objects. This would work even if
277 USE_LSB_TAG is defined and wide integers are used, which might
278 happen in a future version of Emacs.
280 2012-02-25 Chong Yidong <cyd@gnu.org>
282 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
285 * xselect.c (Fx_selection_exists_p): Doc fix.
286 (x_clipboard_manager_save_all): Print an informative message
287 before saving to clipboard manager.
289 2012-02-24 Chong Yidong <cyd@gnu.org>
291 * keyboard.c (process_special_events): Handle all X selection
292 requests in kbd_buffer, not just the next one (Bug#8869).
294 2012-02-23 Chong Yidong <cyd@gnu.org>
296 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
297 call when setting menu-bar-lines and tool-bar-lines parameters.
298 (unwind_create_frame_1): New helper function.
300 * window.c (inhibit_window_configuration_change_hook): New var.
301 (run_window_configuration_change_hook): Obey it.
302 (syms_of_window): Initialize it.
304 2012-02-22 Chong Yidong <cyd@gnu.org>
306 * xterm.c (x_draw_image_relief): Add missing type check for
307 Vtool_bar_button_margin (Bug#10743).
309 2012-02-21 Chong Yidong <cyd@gnu.org>
311 * fileio.c (Vfile_name_handler_alist): Doc fix.
313 * buffer.c (Fget_file_buffer): Protect against invalid file
314 handler return value.
316 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
318 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
319 when computing $valmask.
321 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
322 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
323 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
324 It's useless in that case, and it can cause problems on hosts
325 that allocate halves of EMACS_INT values separately.
326 Reported by Dan Horák. Diagnosed by Andreas Schwab in
327 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
328 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
329 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
330 it avoids undefined behavior on hosts where shifting right by more
331 than the word width has undefined behavior.
333 2012-02-19 Chong Yidong <cyd@gnu.org>
335 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
336 (Funhandled_file_name_directory, Ffile_name_as_directory)
337 (Fdirectory_file_name, Fexpand_file_name)
338 (Fsubstitute_in_file_name): Protect against invalid file handler
339 return values (Bug#10845).
341 2012-02-18 Eli Zaretskii <eliz@gnu.org>
343 * .gdbinit (pitx): Fix incorrect references to fields of the
346 2012-02-17 Chong Yidong <cyd@gnu.org>
348 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
350 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
352 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
353 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
355 2012-02-15 Chong Yidong <cyd@gnu.org>
357 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
358 marked as special. Also, starting docstrings with * is obsolete.
360 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
362 * gnutls.c (emacs_gnutls_write): Fix last change.
364 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
366 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
369 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
371 * keymap.c (Fsingle_key_description): Handle char ranges.
373 2012-02-12 Chong Yidong <cyd@gnu.org>
375 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
376 as that creates a dangerous corner case.
378 * window.c (Fdelete_window_internal): Invalidate the mouse
379 highlight (Bug#9904).
381 2012-02-12 Glenn Morris <rgm@gnu.org>
383 * xselect.c (Fx_own_selection_internal)
384 (Fx_get_selection_internal, Fx_disown_selection_internal)
385 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
386 * nsselect.m (Fx_own_selection_internal)
387 (Fx_disown_selection_internal, Fx_selection_exists_p)
388 (Fx_selection_owner_p, Fx_get_selection_internal):
389 Sync docs and argument specs with the xselect.c versions.
391 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
393 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
395 2012-02-11 Eli Zaretskii <eliz@gnu.org>
397 * w32select.c (Fx_selection_exists_p): Sync doc string and
398 argument list with xselect.c. (Bug#10783)
400 * w16select.c (Fx_selection_exists_p): Sync doc string and
401 argument list with xselect.c. (Bug#10783)
403 2012-02-10 Glenn Morris <rgm@gnu.org>
405 * fns.c (Fsecure_hash): Doc fix.
407 2012-02-09 Kenichi Handa <handa@m17n.org>
409 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
411 2012-02-07 Chong Yidong <cyd@gnu.org>
413 * buffer.c (Fbuffer_local_variables)
414 (buffer_lisp_local_variables): Handle unbound vars correctly;
415 don't let Qunbound leak into Lisp.
417 2012-02-07 Glenn Morris <rgm@gnu.org>
419 * image.c (Fimagemagick_types): Doc fix.
421 * image.c (imagemagick-render-type): Change it from a lisp object
422 to an integer. Move the doc here from the lisp manual.
423 Treat all values not equal to 0 the same.
425 2012-02-06 Chong Yidong <cyd@gnu.org>
427 * doc.c (store_function_docstring): Avoid applying docstring of
428 alias to base function (Bug#2603).
430 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
432 * .gdbinit (pp1, pv1): Remove redundant defines.
435 2012-02-04 Chong Yidong <cyd@gnu.org>
437 * nsterm.m: Declare a global (Bug#10694).
439 2012-02-04 Eli Zaretskii <eliz@gnu.org>
441 * w32.c (get_emacs_configuration_options):
442 Include --enable-checking, if specified, in the return value.
444 2012-02-04 Martin Rudalics <rudalics@gmx.at>
446 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
447 after rounding frame sizes. (Bug#9723)
449 2012-02-04 Eli Zaretskii <eliz@gnu.org>
451 * keyboard.c (adjust_point_for_property): Don't position point
452 before BEGV. (Bug#10696)
454 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
456 Handle overflow when computing char display width (Bug#9496).
457 * character.c (char_width): Return EMACS_INT, not int.
458 (char_width, c_string_width): Check for overflow when
459 computing the width; this is possible now that individual
460 characters can have unbounded width. Problem introduced
461 by merge from Emacs 23 on 2012-01-19.
463 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
465 * dbusbind.c (Fdbus_register_method): Mention the return value
466 :ignore in the docstring.
468 2012-02-02 Glenn Morris <rgm@gnu.org>
470 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
472 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
473 Unconditionally set to t. (Bug#10673)
474 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
475 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
476 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
478 2012-02-02 Kenichi Handa <handa@m17n.org>
480 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
481 0, do not call append_composite_glyph.
483 2012-02-02 Kenichi Handa <handa@m17n.org>
485 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
487 (x_produce_glyphs): If the component of a composition is a null
488 string, set it->pixel_width to 1 to avoid zero-width glyph.
490 2012-02-01 Eli Zaretskii <eliz@gnu.org>
492 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
493 first 2 arguments are identical. This makes inserting large
494 output from a subprocess an order of magnitude faster on
495 MS-Windows, where all sbrk'ed memory is always contiguous.
497 2012-01-31 Glenn Morris <rgm@gnu.org>
499 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
500 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
501 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
503 2012-01-29 Glenn Morris <rgm@gnu.org>
505 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
507 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
509 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
511 2012-01-28 Chong Yidong <cyd@gnu.org>
513 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
515 2012-01-26 Chong Yidong <cyd@gnu.org>
517 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
519 * search.c (Fsearch_forward, Fsearch_backward): Document negative
520 repeat counts (Bug#10507).
522 2012-01-26 Glenn Morris <rgm@gnu.org>
524 * lread.c (syms_of_lread): Doc fix.
526 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
528 * coding.c (encode_designation_at_bol): Change return value to
531 2012-01-25 Chong Yidong <cyd@gnu.org>
533 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
535 2012-01-21 Chong Yidong <cyd@gnu.org>
537 * floatfns.c (Fcopysign): Make the second argument non-optional,
538 since nil is not allowed anyway.
540 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
542 * process.c (read_process_output): Use p instead of XPROCESS (proc).
543 (send_process): Likewise.
545 2012-01-19 Martin Rudalics <rudalics@gmx.at>
547 * window.c (save_window_save, Fcurrent_window_configuration)
548 (Vwindow_persistent_parameters): Do not use Qstate.
551 2012-01-19 Kenichi Handa <handa@m17n.org>
553 * character.c (char_width): New function.
554 (Fchar_width, c_string_width, lisp_string_width):
555 Use char_width (Bug#9496).
557 2012-01-16 Martin Rudalics <rudalics@gmx.at>
559 * window.c (Vwindow_persistent_parameters): New variable.
560 (Fset_window_configuration, save_window_save): Handle persistent
563 2012-01-14 Eli Zaretskii <eliz@gnu.org>
565 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
566 thrashing the stack of the thread. (Bug#9087)
568 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
570 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
572 2012-01-11 Eli Zaretskii <eliz@gnu.org>
574 * xdisp.c (rows_from_pos_range): Handle the case where the
575 highlight ends on a newline. (Bug#10464)
576 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
577 he end column for display of highlight that ends on a newline
580 2012-01-11 Glenn Morris <rgm@gnu.org>
582 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
583 from load-path also when installation-directory is nil. (Bug#10208)
585 2012-01-10 Glenn Morris <rgm@gnu.org>
587 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
589 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
590 Update template values to be closer to their typical values these days.
592 2012-01-09 Eli Zaretskii <eliz@gnu.org>
594 * xdisp.c (rows_from_pos_range): Accept additional argument
595 DISP_STRING, and accept any glyph in a row whose object is that
596 string as eligible for mouse highlight. Fixes mouse highlight of
597 display strings from overlays. (Bug#10464)
599 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
601 emacs: fix an auto-save permissions race condition (Bug#10400)
602 * fileio.c (auto_saving_dir_umask): New static var.
603 (Fmake_directory_internal): Use it.
604 (do_auto_save_make_dir): Set it, instead of invoking chmod after
605 creating the directory. The old code temporarily assigns
606 too-generous permissions to the directory.
607 (do_auto_save_eh): Clear it.
608 (Fdo_auto_save): Catch all errors, not just file errors, so
609 that the var is always cleared.
611 2012-01-07 Eli Zaretskii <eliz@gnu.org>
613 * search.c (scan_buffer): Pass character positions to
614 know_region_cache, not byte positions. (Bug#6540)
616 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
618 * w32.c (sys_rename): Report EXDEV when rename of a directory
619 fails because the target is on another logical disk. (Bug#10284)
621 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
623 * xterm.c (x_embed_request_focus): New function.
625 * xterm.h: Add prototype.
627 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
629 2012-01-05 Glenn Morris <rgm@gnu.org>
631 * emacs.c (emacs_copyright): Update short copyright year to 2012.
633 2012-01-01 Eli Zaretskii <eliz@gnu.org>
635 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
636 Load gnutls_transport_set_lowat only if GnuTLS version is below
638 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
639 GnuTLS versions below 2.11.1.
641 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
643 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
644 to the doc string advising against its use for altering the way
645 windows are scrolled.
647 2011-12-28 Kenichi Handa <handa@m17n.org>
649 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
650 coding-system ASCII compatible only when it does not produce BOM
651 on encoding (Bug#10383).
653 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
655 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
657 (create_and_show_popup_menu): Always use menu_position_func for
660 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
662 * callint.c (Fcall_interactively): Don't truncate prompt string.
664 2011-12-23 Eli Zaretskii <eliz@gnu.org>
666 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
667 property that ends at ZV, so that the bidi iteration could be
668 resumed from there (after widening). (Bug#10360)
670 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
672 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
674 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
676 * nsterm.m (x_free_frame_resources):
677 Release f->output_data.ns->miniimage.
678 (ns_index_color): Fix indentation. Do not retain
679 color_table->colors[i].
681 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
684 * nsfns.m (x_set_background_color): Assign return value from
685 ns_index_color to face-background instead of NSColor*.
686 (ns_implicitly_set_icon_type): Fix indentation.
687 Change assignment in for loop to comparison.
689 * emacs.c (ns_pool): New variable.
690 (main): Assign ns_pool.
691 (Fkill_emacs): Call ns_release_autorelease_pool.
693 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
694 autorelease fdesc, release fdAttrs and tdict.
695 (ns_get_covering_families): Release charset.
696 (ns_findfonts): Release NSFontDescriptor created with new.
697 (ns_uni_to_glyphs): Fix indentation.
698 (setString): Release attrStr before assigning new value.
700 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
702 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
704 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
705 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
707 2011-12-18 David Reitter <reitter@cmu.edu>
709 * nsterm.m (ns_term_init): Subscribe for notifications
710 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
711 to method trackingNotification in EmacsMenu.
713 * nsmenu.m (trackingMenu): New variable.
714 (trackingNotification): New method (from Aquamacs).
715 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
716 from Aquamacs (Bug#7030).
718 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
720 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
721 (symbol_to_nsstring): Fix indentation.
722 (ns_symbol_to_pb): New function.
723 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
724 (Fns_rotate_cut_buffers_internal): Remove.
725 (Fns_store_selection_internal): Rename from
726 Fns_store_cut_buffer_internal.
727 (ns_get_foreign_selection, Fx_own_selection_internal)
728 (Fx_disown_selection_internal, Fx_selection_exists_p)
729 (Fns_get_selection_internal, Fns_store_selection_internal):
730 Use ns_symbol_to_pb and check if return value is nil.
731 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
732 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
733 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
734 renamed to Sns_store_selection_internal.
735 (ns_handle_selection_request): Move code to Fx_own_selection_internal
736 and remove this function.
737 (ns_handle_selection_clear): Remove, never used.
738 (Fx_own_selection_internal): Move code from ns_handle_selection_request
741 2011-12-17 Ken Brown <kbrown@cornell.edu>
743 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
744 GID is unknown (Bug#10257).
746 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
748 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
749 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
750 which caused a build failure on GNU/Linux IA-64. This problem was
751 introduced by my 2011-10-07 patch.
753 2011-12-15 Juri Linkov <juri@jurta.org>
755 * image.c (imagemagick_error): New function. (Bug#10112)
756 (imagemagick_load_image): Comment out `MagickSetResolution' call.
757 Use `imagemagick_error' where ImageMagick functions return
759 (Fimagemagick_types): Add `Fnreverse' to return the list in the
762 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
764 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
765 fill background (Bug#8992).
767 2011-12-13 Martin Rudalics <rudalics@gmx.at>
769 * window.c (Vwindow_combination_resize)
770 (Vwindow_combination_limit): Use t instead of non-nil in
772 (Vrecenter_redisplay): Add first sentence of doc-string on
774 (Frecenter): Fix doc-string typo.
776 2011-12-11 Kenichi Handa <handa@m17n.org>
778 * coding.c (Funencodable_char_position): Pay attention to the
779 buffer text relocation (Bug#9389).
781 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
783 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
784 gtk_init (Bug#10100).
786 2011-12-10 Eli Zaretskii <eliz@gnu.org>
788 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
789 IT->string is nil. (Bug#10263)
791 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
793 * nsterm.h (x_free_frame_resources): Declare.
795 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
796 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
798 * nsterm.h (ns_get_defaults_value): Declare.
800 * nsterm.m (ns_default): Call ns_get_defaults_value.
802 2011-12-09 Eli Zaretskii <eliz@gnu.org>
804 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
807 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
809 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
810 that where the value of an _OBJC_* symbol points to is in the .bss
813 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
815 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
816 after the loop to call ccl_driver at least once (Bug#8619).
818 2011-12-08 Kenichi Handa <handa@m17n.org>
820 * ftfont.c (get_adstyle_property): Fix previous change
823 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
825 * w32.c (init_environment): If no_site_lisp, remove site-lisp
826 dirs from the default value of EMACSLOADPATH (bug#10208).
828 2011-12-07 Glenn Morris <rgm@gnu.org>
830 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
831 installation and source directories as well. (Bug#10208)
833 2011-12-06 Chong Yidong <cyd@gnu.org>
835 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
837 2011-12-06 Glenn Morris <rgm@gnu.org>
839 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
840 as an error, not just -1. (Bug#10217)
842 2011-12-05 Chong Yidong <cyd@gnu.org>
844 * keyboard.c (process_special_events): New function.
845 (swallow_events, Finput_pending_p): Use it (Bug#10195).
847 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
849 * coding.c (encode_designation_at_bol): Don't use uninitialized
850 local variable (Bug#9318).
852 2011-12-05 Kenichi Handa <handa@m17n.org>
854 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
855 return Qnil (Bug#8046, Bug#10193).
857 2011-12-05 Kenichi Handa <handa@m17n.org>
859 * coding.c (encode_designation_at_bol): New args charbuf_end and
860 dst. Return the number of produced bytes. Callers changed.
861 (coding_set_source): Return how many bytes coding->source was
863 (coding_set_destination): Return how many bytes
864 coding->destination was relocated.
865 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
866 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
868 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
870 * coding.c (CODING_CHAR_CHARSET_P): New macro.
871 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
874 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
876 The following changes are to fix Bug#9318.
878 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
879 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
880 (encode_coding_iso_2022, encode_coding_sjis)
881 (encode_coding_big5, encode_coding_charset): Use the above macros.
883 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
885 * lisp.h (process_quit_flag): Fix external declaration.
887 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
889 Don't macro-inline non-performance-critical code.
890 * eval.c (process_quit_flag): New function.
891 * lisp.h (QUIT): Use it.
893 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
895 * nsfns.m (get_geometry_from_preferences): New function.
896 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
898 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
900 * emacs.c (Qkill_emacs): Define.
901 (syms_of_emacs): Initialize it.
902 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
903 Qquit_flag to `kill-emacs' instead.
904 (quit_throw_to_read_char): Add parameter `from_signal'.
905 All callers changed. Call Fkill_emacs if requested and safe.
906 * lisp.h (QUIT): Call Fkill_emacs if requested.
908 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
910 * widget.c (update_wm_hints): Return if wmshell is null.
911 (widget_update_wm_size_hints): New function.
913 * widget.h (widget_update_wm_size_hints): Declare.
915 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
916 widget_update_wm_size_hints (Bug#10104).
918 2011-12-03 Eli Zaretskii <eliz@gnu.org>
920 * xdisp.c (handle_invisible_prop): If the invisible text ends just
921 before a newline, prepare the bidi iterator for consuming the
922 newline, and keep the current paragraph direction. (Bug#10183)
923 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
925 2011-12-02 Juri Linkov <juri@jurta.org>
927 * search.c (Fword_search_regexp): New Lisp function created from
928 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
929 (Fword_search_backward, Fword_search_forward)
930 (Fword_search_backward_lax, Fword_search_forward_lax):
931 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
932 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
934 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
936 * fileio.c (Finsert_file_contents): Move after-change-function call
937 to before the "handled:" label, since all "goto handled" appear in
938 cases where the *-change-functions have already been properly called
941 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
943 * keyboard.c (interrupt_signal): Don't call kill-emacs when
944 waiting for input. (Bug#10169)
946 2011-11-30 Eli Zaretskii <eliz@gnu.org>
948 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
949 verifies glyph row's hash code--we have just reallocated the
950 glyphs, so their contents can be complete garbage. (Bug#10164)
952 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
954 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
956 2011-11-30 Eli Zaretskii <eliz@gnu.org>
958 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
959 attributes are tested _before_ calling verify_row_hash, to protect
960 against GCC re-ordering of the tests. (Bug#10164)
962 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
964 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
966 * xterm.c (handle_one_xevent): Only set async_visible and friends
967 if net_wm_state_hidden_seen is non-zero (Bug#10002)
968 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
969 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
971 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
973 Remove GCPRO-related macros that exist only to avoid shadowing locals.
974 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
975 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
976 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
977 All uses changed to use GCPRO1 etc.
978 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
979 Revert to old implementation (i.e., before 2011-03-11).
981 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
983 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
984 of scroll runs so as to avoid assigning disabled bogus rows and
985 unnecessary graphics copy operations.
987 2011-11-27 Eli Zaretskii <eliz@gnu.org>
989 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
990 (snprintf) [_MSC_VER]: Redirect to _snprintf.
991 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
992 (malloc, free, realloc, calloc): Redirect to e_* only when
995 * lisp.h (GCTYPEBITS): Move before first use.
996 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
997 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
998 this macro definition.
1000 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1003 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1005 * gtkutil.c (xg_create_frame_widgets):
1006 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1007 present with Gtk+ 2.0.
1009 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1011 * fileio.c (Finsert_file_contents): Undo previous change; see
1012 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1014 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1016 Rename locals to avoid shadowing.
1017 * fileio.c (Finsert_file_contents):
1018 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1019 * process.c (wait_reading_process_output):
1020 Rename inner 'proc' to 'p' to avoid shadowing.
1021 Indent for consistency with usual Emacs style.
1023 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (redisplay_window): If cursor row is not fully visible
1026 after recentering, and scroll-conservatively is set to a large
1027 number, scroll window by a few more lines to make the cursor fully
1028 visible and out of scroll-margin. (Bug#10105)
1029 (start_display): Don't move to the next line if the display should
1030 start at a newline that is part of a display vector or an overlay
1033 2011-11-24 Juri Linkov <juri@jurta.org>
1035 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1036 after the `MagickPingImage' call. (Bug#10112)
1038 2011-11-23 Chong Yidong <cyd@gnu.org>
1040 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1042 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1044 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1045 making another buffer current. (Bug#10114)
1047 2011-11-23 Glenn Morris <rgm@gnu.org>
1049 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1051 2011-11-23 Chong Yidong <cyd@gnu.org>
1053 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1054 using it (Bug#5984).
1056 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1058 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1059 and header-lines, as they don't have one computed for them.
1062 * .gdbinit (prow): Make displayed values more self-explaining.
1063 Add row's hash code.
1065 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1067 * process.c (wait_reading_process_output): Fix asynchrounous
1068 GnuTLS socket handling on some versions of the GnuTLS library.
1069 (wait_reading_process_output): Add comment and URL.
1071 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1073 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1075 2011-11-21 Chong Yidong <cyd@gnu.org>
1077 * window.c (Fnext_window, Fprevious_window): Doc fix.
1079 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1081 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1083 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1085 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1087 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1089 * window.c (Fset_window_combination_limit): Rename argument
1091 (Vwindow_combination_limit): Remove "status" from doc-string.
1093 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1095 * m/ibms390.h: Remove.
1096 * m/ibms390x.h: Don't include "ibms390.h".
1098 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1100 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1101 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1103 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1105 * casetab.c (Fset_case_table):
1106 * charset.c (Fcharset_after): Fix typos.
1108 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1110 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1111 Otherwise, valgrind does not work on some platforms.
1112 Problem reported by Andreas Schwab in
1113 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1114 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1115 is set, removing the need for VIRT_ADDRESS_VARIES.
1116 (PURE_P): Use a more-efficient implementation that needs just one
1117 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1118 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1119 to 4 (xorl, subq, cmpq, setbe).
1120 * alloc.c (pure): Always extern now, since that's the
1121 VIRT_ADDR_VARIES behavior.
1122 (PURE_POINTER_P): Use a single comparison, not two, for
1123 consistency with the new puresize.h.
1124 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1125 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1126 Remove VIRT_ADDR_VARIES no longer needed.
1128 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1130 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1131 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1132 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1133 behave as if the cursor position were at the window margin.
1135 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1136 and the cursor position is out of bounds, behave as if the cursor
1137 position were at the window margin. (Bug#10075)
1139 2011-11-18 Chong Yidong <cyd@gnu.org>
1141 * window.c (Fwindow_combination_limit): Make first argument
1142 non-optional, since it is meaningless for live windows like the
1145 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1147 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1149 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1151 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1152 (graft_intervals_into_buffer): Simplify.
1154 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1156 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1157 hash values of the two rows.
1158 (copy_row_except_pointers): Preserve the used[] arrays and the
1159 hash values of the two rows. (Bug#10035)
1160 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1162 * xdisp.c (row_hash): New function, body extracted from
1163 compute_line_metrics.
1164 (compute_line_metrics): Call row_hash, instead of computing the
1167 * dispnew.c (verify_row_hash): Call row_hash for computing the
1168 hash code of a row, instead of duplicating code from xdisp.c.
1170 * dispextern.h (row_hash): Add prototype.
1172 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1174 * frame.c (delete_frame): Don't delete the terminal when the last
1175 X frame is closed if emacs is built with GTK toolkit.
1177 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1179 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1181 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1183 * window.c (Vwindow_splits): Rename to
1184 Vwindow_combination_resize. Suggested by Juri Linkov.
1185 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1188 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1190 * nsfns.m (Fns_font_name):
1191 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1193 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1195 * window.h (window): Rename slot "nest" to "combination_limit".
1196 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1197 (Fset_window_nest): Rename to Fset_window_combination_limit.
1198 (Vwindow_nest): Rename to Vwindow_combination_limit.
1199 (recombine_windows, make_parent_window, make_window)
1200 (Fsplit_window_internal, saved_window)
1201 (Fset_window_configuration, save_window_save): Rename all
1202 occurrences of window_nest to window_combination_limit.
1204 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1206 * image.c (imagemagick_load_image): Fix typo.
1208 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1210 * xdisp.c (display_line): Move the call to
1211 highlight_trailing_whitespace before the call to
1212 compute_line_metrics, since the latter needs to see the final
1213 faces of all the glyphs to compute ROW's hash value.
1214 Fixes assertion violations in row_equal_p. (Bug#10035)
1216 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1218 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1219 just return (bug#10044).
1221 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1223 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1224 with user-defined heap size. Bump the default size of the temacs
1225 heap to 27MB, to avoid memory warning when running temacs.
1226 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1228 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1229 current_matrix and desired_matrix. (Bug#9990)
1230 (verify_row_hash) [XASSERTS]: New function.
1231 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1232 that the hash value of glyph rows is correct.
1234 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1236 * window.h (window): Remove splits slot.
1237 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1238 (Fdelete_other_windows_internal, make_parent_window)
1239 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1240 (Fset_window_configuration, save_window_save): Don't deal with
1241 split status of windows.
1242 (saved_window): Remove splits slot.
1243 (Vwindow_splits): Rewrite doc-string.
1245 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1247 * xfns.c (unwind_create_frame):
1248 * nsfns.m (unwind_create_frame):
1249 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1250 Vframe_list (Bug#9999).
1252 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1254 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1256 2011-11-11 Kenichi Handa <handa@m17n.org>
1258 * callproc.c (Fcall_process): Set the member dst_multibyte of
1261 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1263 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1264 avoid a crash (bug#9496).
1266 2011-11-09 Chong Yidong <cyd@gnu.org>
1268 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1269 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1271 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1273 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1275 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1277 Avoid some portability problems by eschewing 'extern inline' functions.
1278 The trivial performance wins aren't worth the portability hassles; see
1279 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1281 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1282 (window_box_width, window_box_left, window_box_left_offset)
1283 (window_box_right, window_box_right_offset): Undo previous change,
1284 by removing the "extern"s.
1285 * intervals.c (adjust_intervals_for_insertion)
1286 (adjust_intervals_for_deletion): Undo previous change,
1287 making these static again.
1288 (offset_intervals, temp_set_point_both, temp_set_point)
1289 (copy_intervals_to_string): No longer inline.
1290 * xdisp.c (window_text_bottom_y, window_box_width)
1291 (window_box_height, window_box_left_offset)
1292 (window_box_right_offset, window_box_left, window_box_right)
1293 (window_box): No longer inline.
1295 2011-11-08 Chong Yidong <cyd@gnu.org>
1297 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1298 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1299 Signal an error if not a live window.
1300 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1301 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1303 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1305 * lisp.h (syms_of_abbrev): Remove declaration.
1306 Reported by CHENG Gao <chenggao@royau.me>.
1308 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1310 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1311 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1312 of temacs in GUI mode.
1314 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1316 * window.h: Declare delete_all_child_windows instead of
1317 delete_all_subwindows.
1318 * window.c (Fwindow_nest, Fset_window_nest)
1319 (Fset_window_new_total, Fset_window_new_normal)
1320 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1321 (delete_all_subwindows): Rename to delete_all_child_windows.
1322 (Fdelete_other_windows_internal, Fset_window_configuration):
1323 Call delete_all_child_windows instead of delete_all_subwindows.
1324 * frame.c (delete_frame): Call delete_all_child_windows instead
1325 of delete_all_subwindows.
1327 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1329 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1330 This is also needed for porting to any host where GC_MARK_STACK is
1331 not GC_MAKE_GCPROS_NOOPS.
1332 (which_symbols): Use it.
1334 2011-11-07 Kenichi Handa <handa@m17n.org>
1336 * coding.c (coding_set_destination): Check coding->src_pos only
1337 when coding->src_object is a buffer (bug#9910).
1339 * process.c (send_process): Set the member src_multibyte of coding
1340 to 0 (bug#9911) when sending a unibyte text.
1342 * callproc.c (Fcall_process): Set the member src_multibyte of
1343 process_coding to 0 (bug#9912).
1345 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1347 * xmenu.c (cleanup_widget_value_tree): New function.
1348 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1349 calling free_menubar_widget_value_tree directly (Bug#9830).
1351 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1353 Fix some portability problems with 'inline'.
1354 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1355 (window_box_width, window_box_left, window_box_left_offset)
1356 (window_box_right, window_box_right_offset): Declare extern.
1357 Otherwise, these inline functions do not conform to C99 and
1358 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1359 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1360 * intervals.c (adjust_intervals_for_insertion)
1361 (adjust_intervals_for_deletion): Now extern, because otherwise the
1362 extern inline functions 'offset_intervals' couldn't refer to it.
1363 (static_offset_intervals): Remove.
1364 (offset_intervals): Rewrite using the old contents of
1365 static_offset_intervals. The old version didn't conform to C99
1366 because an extern inline function contained a reference to an
1367 identifier with static linkage.
1369 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1371 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1374 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1376 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1377 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1378 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1379 return Qleft_to_right.
1381 2011-11-06 Chong Yidong <cyd@gnu.org>
1383 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1384 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1385 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1386 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1387 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1388 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1389 (Fwindow_vscroll): Doc fix.
1390 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1391 argument, since it makes no sense to pass a live window and for
1392 consistency with window-child.
1394 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1396 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1399 2011-11-05 Jason Rumney <jasonr@gnu.org>
1401 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1402 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1404 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1405 bitwise arithmetic preventing use of unicode-sip and non-truetype
1408 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1410 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1413 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1414 initialization code to keep similarity to xfns.c after changes
1417 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1419 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1420 (unwind_create_frame): New function (Bug#9943).
1421 (Fx_create_frame): Restructure code to be more similar to the one in
1422 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1423 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1424 Move terminal->reference_count++ just before making the frame official
1427 * nsterm.m (x_free_frame_resources): New function.
1428 (x_destroy_window): Move code to x_free_frame_resources.
1430 * xfns.c (unwind_create_frame): Fix comment.
1431 (Fx_create_frame, x_create_tip_frame):
1432 Move terminal->reference_count++ just before making the frame
1433 official. Move initialization of image_cache_refcount and
1434 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1436 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1438 Support MSVC build with newer versions of Visual Studio.
1439 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1440 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1443 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1444 which are not supported by MSVC.
1445 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1446 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1448 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1450 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1452 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1454 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1456 Support MSVC build with newer versions of Visual Studio.
1457 * w32.c: Don't include w32api.h for MSVC.
1458 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1460 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1461 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1462 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1463 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1465 (alloca) [_MSC_VER]: Define to _alloca.
1467 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1469 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1471 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1473 * xdisp.c (note_mouse_highlight): If either of
1474 previous/next-single-property-change returns nil, treat that as
1475 the beginning or the end of the buffer. (Bug#9955)
1477 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1479 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1480 label is not null (Bug#9951).
1481 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1484 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1486 * window.c (Fwindow_body_size): Mention in the doc string that the
1487 return value is in frame's canonical units. (Bug#9949)
1489 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1491 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1493 * w32fns.c (unwind_create_frame): If needed, free the glyph
1494 matrices of the partially constructed frame. (Bug#9943)
1495 * xfns.c (unwind_create_frame): Likewise.
1497 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1499 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1500 Don't stop backward scan on the continuation glyph, even though
1501 its CHARPOS is positive.
1502 (mouse_face_from_buffer_pos, note_mouse_highlight):
1503 Rename cover_string to disp_string.
1505 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1507 * window.c (temp_output_buffer_show): Don't use
1508 Vtemp_buffer_show_specifiers.
1509 (Vtemp_buffer_show_specifiers): Remove unused variable.
1511 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1513 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1514 past the beginning of the current glyph matrix.
1516 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1518 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1519 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1520 HAVE_GTK3 (Bug#9869).
1522 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1523 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1525 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1527 * xterm.c: Declare x_handle_net_wm_state to return int.
1528 (handle_one_xevent): Check if we are iconified but don't have
1529 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1530 (get_current_wm_state): Return non-zero if not hidden,
1531 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1532 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1533 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1534 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1536 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1538 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1539 so that this new function doesn't get optimized away by a
1540 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1542 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1544 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1546 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1548 Fix the `xbytecode' command.
1549 * .gdbinit (xprintbytestr): New command.
1550 (xwhichsymbols): Rename from `which'; all callers changed.
1551 (xbytecode): Print the byte-code string as well.
1553 2011-10-29 Kim Storm <storm@cua.dk>
1555 * alloc.c (which_symbols): New function.
1557 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1559 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1562 2011-10-29 Glenn Morris <rgm@gnu.org>
1564 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1565 Not clear what it was for, and it causes various bugs. (Bug#9839)
1567 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1569 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1570 possible random value that matches one of those tested as
1571 condition to clear the mouse face.
1573 2011-10-28 Chong Yidong <cyd@gnu.org>
1575 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1577 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1579 * window.c (make_window): Initialize phys_cursor_on_p.
1581 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1583 * lisp.h (struct Lisp_Symbol): Update comments.
1585 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1587 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1589 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1591 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1592 <oslsachem@gmail.com> for helping to debug this.
1594 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1595 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1596 (g_b_init_get_glyph_outline_w): New static variables.
1597 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1598 (GetGlyphOutlineW_Proc): New typedefs.
1599 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1600 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1602 (w32font_open_internal, compute_metrics):
1603 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1604 instead of calling the "wide" APIs directly.
1606 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1608 * w32.h (syms_of_w32font): Add prototype.
1610 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1612 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1613 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1614 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1615 (Fmove_to_window_line): Doc fix.
1617 2011-10-27 Chong Yidong <cyd@gnu.org>
1619 * process.c (make_process): Set gnutls_state to NULL.
1621 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1622 non-NULL, regardless of GNUTLS_INITSTAGE.
1623 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1624 an error. Set process slots as soon as we allocate them.
1626 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1628 2011-10-27 Chong Yidong <cyd@gnu.org>
1630 * gnutls.c (emacs_gnutls_deinit): New function.
1631 Deallocate credentials structures as well as calling gnutls_deinit.
1632 (Fgnutls_deinit, Fgnutls_boot): Use it.
1634 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1635 (deactivate_process): Call emacs_gnutls_deinit.
1637 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1639 * image.c (x_create_x_image_and_pixmap):
1640 * w32.c (sys_rename, w32_delayed_load):
1641 * w32font.c (fill_in_logfont):
1642 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1644 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1646 * w32fns.c (w32_default_color_map): New function,
1647 extracted from Fw32_default_color_map.
1648 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1650 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1652 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1654 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1656 * keyboard.c (test_undefined): New function (bug#9751).
1657 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1659 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1661 * sysdep.c (init_sys_modes): Fix the check for the controlling
1662 terminal (Bug#6649).
1664 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1666 * dispextern.h (struct bidi_it): New member next_en_type.
1668 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1669 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1670 current character, check also for next_en_type being WEAK_EN.
1671 (bidi_resolve_weak): Don't enter the expensive loop if the current
1672 position is before next_en_pos. Record the bidi type of the first
1673 non-ET, non-BN character we find, in addition to its position.
1674 (bidi_level_of_next_char): Invalidate next_en_type when
1675 next_en_pos is over-stepped.
1677 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1679 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1680 * editfns.c: Rewrite current-time-zone so that it invokes
1681 the equivalent of (format-time-string "%Z") to get the time zone name.
1682 This fixes a bug when the time zone name contains characters that
1683 need converting from the system time locale to Emacs internal format.
1684 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1685 that patch fixed format-time-string to do the conversion, but
1686 I forgot to fix current-time-zone.
1687 (format_time_string): New function, containing most of
1688 what Fformat_time_string used to contain.
1689 (Fformat_time_string): Rewrite in terms of format_time_string.
1690 This doesn't change this function's behavior.
1691 (current-time-zone): Rewrite to use format_time_string.
1692 This fixes the bug reported by Michael Schierl in
1693 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1694 Jason Rumney's 2007-06-07 change worked around this bug, but
1696 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1698 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1700 * xdisp.c (start_display): If the character at POS is displayed
1701 via a display vector, reset IT->current.dpvec_index to zero.
1702 (try_window_reusing_current_matrix): If a line ends in a display
1703 vector or the next line starts in a display vector, continue
1704 redrawing the window even though the character position of
1705 start_row was reached.
1708 2011-10-18 Chong Yidong <cyd@gnu.org>
1710 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1711 with nobreak-char-display too.
1713 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1715 Fix part 3 of bug#9771.
1716 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1717 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1718 non-neutral characters if the current character is a paragraph
1719 separator (a.k.a. Newline). This avoids running the same
1720 expensive loop twice, once when we consume the preceding newline
1721 and the other time when the line actually needs to be displayed.
1722 Avoid the loop when we see neutrals on the base embedding level
1723 following a character whose directionality is the same as the
1724 paragraph's. This avoids running the expensive loop when a line
1725 ends in a long sequence of neutrals, like control characters.
1726 Add assertion against STRONG_AL type. Slightly rearrange code
1727 that determines the type of a neutral given the first non-neutral
1729 (bidi_level_of_next_char): Set next_en_pos to zero when
1730 invalidating its info.
1732 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1734 * xdisp.c (push_display_prop): Determine whether to record string
1735 or buffer position by IT->string, not by IT->method. Allow
1736 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1737 (move_it_vertically_backward): Don't look for character position
1738 immediately after the newline when in a continuation line.
1741 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1743 * window.c (coordinates_in_window): Rewrite and delabelize
1744 vertical border check. (Bug#5357) (Bug#9618)
1746 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1748 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1749 errors in XSetWindowBorder (bug#9310).
1751 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1753 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1754 avoid crash when xmalloc overrun checking is enabled.
1756 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1758 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1759 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1760 cursor motion with <left> and <right> arrow keys.
1762 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1763 some callers set that themselves.
1765 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1767 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1768 display string and the previous row comes from the same string and
1769 is empty. (Bug#9739) (Bug#9738)
1771 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * doc.c (get_doc_string): Encode file name (bug#9735).
1775 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1777 * bidi.c (bidi_level_of_next_char):
1778 * xdisp.c (get_visually_first_element): Remove old incorrect
1779 comments regarding the Unicode Line Separator character.
1781 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1783 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1785 * alloc.c (Fgc_status): Do not access beyond zombies array
1786 boundary if nzombies > MAX_ZOMBIES.
1787 * alloc.c (dump_zombies): Add missing format specifier.
1789 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1791 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1792 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1794 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1795 Some packages use them to denote characters with modifiers.
1797 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1799 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1800 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1801 matching a pp-number. Rename parameter var to var1.
1803 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1805 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1807 2011-10-08 Glenn Morris <rgm@gnu.org>
1809 * callint.c (Fcall_interactively): Give a more explicit error for the
1810 'c' case with a non-character input. (Bug#8479)
1812 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1816 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1817 lines that are hscrolled on the left.
1819 * dispnew.c (buffer_posn_from_coords): Account for a possible
1820 presence of header-line. (Bug#4426)
1822 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1824 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1825 Don't advertise functionality which we discourage or doesn't work.
1827 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1829 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1830 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1831 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1832 this makes Emacs dump core during garbage collection on rare
1833 occasions. sizeof is obviously inferior to offsetof here, so
1834 stick with offsetof.
1835 (GC_POINTER_ALIGNMENT): New macro.
1836 (mark_memory): Omit 3rd (offset) arg; caller changed.
1837 Don't assume EMACS_INT alignment is the same as pointer alignment.
1839 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1841 * keyboard.c (read_key_sequence_remapped): New var.
1842 (read_key_sequence): Compute remapping in the right buffer.
1843 (command_loop_1): Use read_key_sequence's remapping directly.
1845 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1847 * dired.c (file_name_completion): Don't expand file name.
1848 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1849 before checking file name handler.
1851 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1852 they've been requested explicitly (bug#9591).
1854 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1856 * keymap.c (Fsingle_key_description): Use make_specified_string
1857 instead of build_string to build string from push_key_description.
1860 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1862 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1863 This fixes a Y2038 bug on 64-bit hosts.
1864 * buffer.c (reset_buffer):
1865 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1866 (Fclear_buffer_auto_save_failure):
1867 Use 0, not -1, to represent an unset failure time, since time_t
1868 might not be signed.
1870 Remove dependency on glibc malloc internals.
1871 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1872 Move back here from lisp.h, but with their new implementations.
1873 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1874 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1875 * charset.c (charset_table_init): New static var.
1876 (syms_of_charset): Use it instead of xmalloc. This removes a
1877 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1878 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1879 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1880 Move back to alloc.c.
1881 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1882 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1884 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1886 * nsterm.m (windowDidResize): Call x_set_window_size only when
1887 ns_in_resize is true. Otherwise set pixelwidth/height and
1888 call change_frame_size (Bug#9628).
1890 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1892 Port --enable-checking=all to Fedora 14 x86-64.
1893 * charset.c (syms_of_charset): Also account for glibc malloc's
1894 internal overhead when calculating the initial malloc maximum.
1896 Port --enable-checking=all to Fedora 14 x86.
1897 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1899 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1900 (overrun_check_realloc, overrun_check_free):
1901 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1902 That way, xmalloc returns a properly-aligned pointer even if
1903 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1904 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1905 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1906 into account when calculating the initial malloc maximum.
1907 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1908 Move here from alloc.c, so that charset.c can use it too.
1909 Properly align; the old code wasn't right for common 32-bit hosts
1910 when configured with --enable-checking=all.
1911 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1912 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1914 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1916 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1919 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1921 * xdisp.c (compute_display_string_end): If there's no display
1922 string at CHARPOS, return -1.
1924 * bidi.c (bidi_fetch_char): When compute_display_string_end
1925 returns a negative value, treat the character as a normal
1926 character not covered by a display string. (Bug#9624)
1928 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1930 * lread.c (Fread_from_string): Fix typo in docstring.
1932 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1935 newline, reseat the iterator instead of bidi-iterating there one
1936 character at a time. (Bug#9610)
1937 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1938 TO_CHARPOS if the bidi iterator is at base embedding level.
1940 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1942 * lread.c (readevalloop): Use correct code for NBSP.
1943 (read1): Likewise. (Bug#9608)
1945 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1947 * dbusbind.c (Fdbus_register_signal): When service is not
1948 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1950 2011-09-25 Glenn Morris <rgm@gnu.org>
1952 * buffer.c (truncate-lines): Doc fix.
1954 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1956 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1957 (Fset_window_next_buffers): Doc fix.
1959 2011-09-24 Glenn Morris <rgm@gnu.org>
1961 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1963 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1965 Fix minor problems found by static checking.
1966 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1967 * indent.c (Fvertical_motion): Fix == vs = typo.
1969 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1971 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1972 Default value is now t. Doc fix.
1974 * indent.c (Fvertical_motion): Compute and apply the overshoot
1975 logic when moving up, not only when moving down. Fix the
1976 confusing name and values of the it_overshoot_expected variable;
1977 logic changes accordingly. (Bug#9254) (Bug#9549)
1979 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1980 CHARPOS is covered by a display string which includes newlines.
1981 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1982 is covered by a display string with embedded newlines.
1984 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1986 * dbusbind.c (Fdbus_register_signal): Add match rule to
1987 Vdbus_registered_objects_table. (Bug#9581)
1988 (Fdbus_register_method, Vdbus_registered_objects_table):
1991 2011-09-24 Jim Meyering <meyering@redhat.com>
1993 do not ignore write error for any output size
1994 The previous change was incomplete.
1995 While it makes emacs --batch detect the vast majority of stdout
1996 write failures, errors were still ignored whenever the output size is
1997 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1998 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1999 && echo FAIL: ignored write error
2000 FAIL: ignored write error
2001 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2002 && echo FAIL: ignored write error
2003 FAIL: ignored write error
2004 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2006 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2008 * emacs.c (Fkill_emacs): In noninteractive mode exit
2009 non-successfully if a write error occurred on stdout. (Bug#9574)
2011 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2013 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2016 * dispextern.h (struct it): Update the comment documenting what
2019 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2021 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2022 a display string, extend search for cursor position to end of row.
2023 (find_row_edges): If the row ends in a newline from a display
2024 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2025 Handle the case of a display string with multiple newlines.
2026 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2027 non-empty line. Fixes confusing cursor motion with arrow keys at
2028 the beginning of a line that starts with whitespace.
2030 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2032 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2035 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2037 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2040 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (display_line): Record maximum and minimum buffer
2043 positions even if no glyphs were produced (e.g., by a zero-width
2044 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2045 buffer positions that will be removed from the glyph row because
2047 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2048 column is beyond frame width: don't subtract 1 "pixel" when
2049 computing width of the stretch.
2050 (reseat_at_next_visible_line_start): Undo the change made on
2051 2011-09-17 that saved paragraph information and restored it after
2052 the call to `reseat'. (Bug#9545)
2054 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2056 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2057 and turn window cursor on if cleared (Bug#9415).
2059 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2061 * search.c (boyer_moore): Take unibyte characters from pattern
2062 literally. (Bug#9458)
2064 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2066 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2068 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2070 Fix minor problem found by static checking.
2071 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2072 initialized, to pacify gcc -Wuninitialized.
2074 * fileio.c: Report proper errno when syscall falls.
2075 (Finsert_file_contents): Save and restore errno,
2076 so that report_file_error outputs the correct diagnostic.
2077 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2079 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2081 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2083 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2085 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2086 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2088 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2090 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2091 about the current paragraph and restore it after the call to reseat.
2093 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2094 (bidi_find_paragraph_start): Search back for paragraph beginning
2095 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2096 (bidi_move_to_visually_next): Only trigger paragraph-related
2097 computations when the last character is a newline or at EOB, not
2098 just any NEUTRAL_B. (Bug#9470)
2100 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2101 truncated lines if point is covered by a display string. (Bug#9524)
2103 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2105 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2106 (cons_to_x_long): New function.
2107 (lisp_data_to_selection_data): Use it. Correct the test for
2108 short-versus-long data; it was negated. Break out of vector
2109 loop, for efficiency, when a long datum is discovered.
2111 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2113 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2115 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2117 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2118 GCC PR/17406) by declaring this function with external scope.
2120 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2122 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2123 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2125 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2127 * editfns.c (Fformat): Correctly handle text properties on "%%".
2129 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2131 * xterm.c (x_draw_composite_glyph_string_foreground):
2132 * w32term.c (x_draw_composite_glyph_string_foreground):
2133 * term.c (encode_terminal_code):
2134 * composite.c (composition_update_it, get_composition_id):
2135 * xdisp.c (get_next_display_element)
2136 (fill_composite_glyph_string): Add comments about special meaning
2137 of TAB characters in a composition.
2139 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2141 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2142 This occurs when processing a multibyte format.
2143 Problem reported by Wolfgang Jenker.
2145 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2147 * xdisp.c (try_cursor_movement): Only check for exact match if
2148 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2150 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2152 Remove unused external symbols.
2153 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2154 * xdisp.c (calc_pixel_width_or_height): Now static.
2155 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2156 * indent.c (check_display_width):
2157 * w32term.c: Fix comment to match code.
2158 * xterm.c, xterm.h (x_catching_errors): Remove.
2160 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2162 * xselect.c: Use signed conversions more consistently (Bug#9498).
2163 (selection_data_to_lisp_data): Assume incoming selection data are
2164 signed integers, not unsigned. This is to be consistent with
2165 outgoing selection data, which was modified to use signed integers
2166 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2167 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2168 expects long, not unsigned long.
2170 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2172 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2173 computation of loop end. Reported by Johan Bockgård
2176 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2178 * frame.c (Fother_visible_frames_p): Function deleted.
2180 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2182 * indent.c (compute_motion): Process display vector front to back
2183 rather than the other way around. (Bug#2496)
2185 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2187 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2189 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2191 * minibuf.c (Fread_from_minibuffer): Doc fix.
2193 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2195 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2196 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2198 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2201 value for non-existent files.
2203 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2205 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2206 set its "size" to -1. This will set the modtime_size field of
2207 the corresponding buffer to -1, which is what
2208 verify-visited-file-modtime expects for files that do not exist.
2211 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2213 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2215 * lisp.h: ... from here. push_key_description is no longer
2216 defined in keyboard.c, so its declaration should not be in
2217 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2218 logically belongs with push_key_description.
2220 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2222 * buffer.h: Include <sys/types.h> instead of <time.h>.
2223 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2224 Problem reported by Herbert J. Skuhra.
2226 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2228 * xml.c (parse_region): Make the parsing work for
2229 non-comment-starting XML files again (bug#9144).
2231 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2233 * image.c (gif_load): Fix calculation of bottom and right corner.
2236 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2238 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2239 redisplay in small windows.
2241 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2243 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2245 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2247 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2248 Operate on live windows only.
2250 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2252 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2254 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2256 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2257 only under bidi iteration.
2259 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2261 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2263 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2265 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2266 Without this fix, the command to link temacs failed due to an
2267 undefined symbol __builtin_isnan. This is because
2268 /usr/include/iso/math_c99.h #defines isnan(x) to
2269 __builtin_isnan(x), but the bundled gcc, which identifies itself
2270 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2272 * floatfns.c (isnan): #undef, and then #define to a clone of
2274 (Fisnan): Always define, since it's always available now.
2275 (syms_of_floatfns): Always define isnan at the Lisp level.
2277 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2279 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2281 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2283 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2284 The previous code assumed that file offsets (off_t values) fit in
2285 EMACS_INT variables, which is not true on typical 32-bit hosts.
2286 The code messed up by falsely reporting buffer overflow in cases
2287 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2288 when "big" contains more than 2**29 bytes, even though this
2289 inserts just one byte and does not overflow the buffer.
2290 (Finsert_file_contents): Store file offsets as off_t
2291 values, not as EMACS_INT values. Check for overflow when
2292 converting between EMACS_INT and off_t. When checking for
2293 buffer overflow or for overlap, take the offsets into account.
2294 Don't use EMACS_INT for small values where int suffices.
2295 When checking for overlap, fix a typo: ZV was used where
2296 ZV_BYTE was intended.
2297 (Fwrite_region): Don't assume off_t fits into 'long'.
2298 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2300 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2302 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2304 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2306 sprintf-related integer and memory overflow issues (Bug#9412).
2308 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2309 (esprintf, exprintf, evxprintf): New functions.
2310 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2311 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2312 (modify_event_symbol): Do not assume that the length of
2313 name_alist_or_stem is safe to alloca and fits in int.
2314 (Fexecute_extended_command): Likewise for function name and binding.
2315 (Frecursion_depth): Wrap around reliably on integer overflow.
2316 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2317 since some callers pass EMACS_INT values.
2318 (Fsingle_key_description): Don't crash if symbol name contains more
2319 than MAX_ALLOCA bytes.
2320 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2321 (get_minibuffer): Arg is now EMACS_INT, not int.
2322 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2323 (esprintf, exprintf, evxprintf): New decls.
2324 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2326 * dbusbind.c (signature_cat): New function.
2327 (xd_signature, Fdbus_register_signal):
2328 Do not overrun buffer; instead, report string overflow.
2330 * dispnew.c (add_window_display_history): Don't overrun buffer.
2331 Truncate instead; this is OK since it's just a log.
2333 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2334 even if the time zone offset is outlandishly large.
2335 Don't mishandle offset == INT_MIN.
2337 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2338 when creating daemon; the previous buffer-overflow check was incorrect.
2340 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2341 which has the guts of the old verror function.
2343 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2344 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2346 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2347 (font_unparse_xlfd): Don't blindly alloca long strings.
2348 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2349 fits in int, when using sprintf. Use single snprintf to count
2350 length of string rather than counting it via multiple sprintfs;
2351 that's simpler and more reliable.
2352 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2353 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2354 sprintf, in case result does not fit in int.
2356 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2357 (fontset_from_font): Print it.
2359 * frame.c (tty_frame_count): Now printmax_t, not int.
2360 (make_terminal_frame, set_term_frame_name): Print it.
2361 (x_report_frame_params): In X, window IDs are unsigned long,
2362 not signed long, so print them as unsigned.
2363 (validate_x_resource_name): Check for implausibly long names,
2364 and don't assume name length fits in 'int'.
2365 (x_get_resource_string): Don't blindly alloca invocation name;
2366 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2369 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2370 (xg_check_special_colors, xg_set_geometry):
2371 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2373 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2374 Use esprintf, not sprintf, in case result does not fit in int.
2376 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2377 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2378 it as a large positive number.
2379 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2380 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2382 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2383 in case result does not fit in int.
2385 * print.c (float_to_string): Detect width overflow more reliably.
2386 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2387 buffer overrun. Don't assume list length fits in 'int'. Treat
2388 print length of 0 as 0, not as infinity; to be consistent with other
2389 uses of print length in this function. Don't overflow print length
2390 index. Don't assume hash table size fits in 'long', or that
2391 vectorlike size fits in 'unsigned long'.
2393 * process.c (make_process): Use printmax_t, not int, to format
2394 process-name gensyms.
2396 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2398 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2399 to avoid potential buffer overrun.
2401 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2402 if X resource line is longer than 512 bytes.
2404 * xfns.c (x_window): Make sprintf buffer a bit bigger
2405 to avoid potential buffer overrun.
2407 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2409 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2411 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2413 Integer overflow fixes for scrolling, etc.
2414 Without these, Emacs silently mishandles large integers sometimes.
2415 For example, "C-u 4294967297 M-x recenter" was treated as if
2416 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2418 * xdisp.c (try_window_id): Check Emacs fixnum range before
2419 converting to 'int'.
2421 * window.c (window_scroll_line_based, Frecenter):
2422 Check that an Emacs fixnum is in range before assigning it to 'int'.
2423 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2424 values converted from Emacs fixnums.
2425 (Frecenter): Don't wrap around a line count if it is out of 'int'
2426 range; instead, treat it as an extreme value.
2427 (Fset_window_configuration, compare_window_configurations):
2428 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2430 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2431 that can exceed INT_MAX. Check that EMACS_INT value is in range
2432 before assigning it to the (possibly-narrower) index.
2433 (match_limit): Don't assume that a fixnum can fit in 'int'.
2435 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2438 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2439 (Fvertical_motion): Don't wrap around LINES values that don't fit
2440 in 'int'. Instead, treat them as extreme values. This is good
2441 enough for windows, which can't have more than INT_MAX lines anyway.
2443 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2445 * Require libxml/parser.h to avoid compilation warning.
2447 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2449 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2450 since this reportedly can destroy thread storage.
2452 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2454 * syntax.c (find_defun_start): Update all cache variables if
2455 exiting early (Bug#9401).
2457 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2459 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2461 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2462 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2463 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2465 * term.c (tty_append_glyph): New function.
2466 (produce_stretch_glyph): Static function and its prototype deleted.
2468 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2471 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2473 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2474 when checking :margin (Bug#9390).
2475 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2476 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2477 so that the name doesn't mislead. All uses changed.
2479 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2481 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2484 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2486 * xdisp.c (move_it_to): Don't bail out early when reaching
2487 position beyond to_charpos, if we are scanning backwards.
2488 (move_it_vertically_backward): When DY == 0, make sure we get to
2489 the first character in the line after the newline.
2491 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2493 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2494 (ccl_driver): Do not generate an out-of-range pointer.
2495 (Fccl_execute_on_string): Remove unnecessary check for
2496 integer overflow, noted by Stefan Monnier in
2497 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2498 Remove a FIXME that didn't need fixing.
2499 Simplify the newly-introduced buffer reallocation code.
2501 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2503 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2505 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2507 Integer and memory overflow issues (Bug#9196).
2509 * doc.c (get_doc_string): Rework so that
2510 get_doc_string_buffer_size is the actual buffer size, rather than
2511 being 1 less than the actual buffer size; this makes xpalloc more
2514 * image.c (x_allocate_bitmap_record, cache_image):
2515 * xselect.c (Fx_register_dnd_atom):
2516 Simplify previous changes by using xpalloc.
2518 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2519 since either will do and ptrdiff_t is convenient with xpalloc.
2521 * charset.c (charset_table_size)
2522 (struct charset_sort_data.priority): Now ptrdiff_t.
2523 (charset_compare): Don't overflow if priorities differ greatly.
2524 (Fsort_charsets): Don't assume list length fits in int.
2525 Check for size-calculation overflow when allocating sort data.
2526 (syms_of_charset): Allocate an initial charset table that is
2527 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2529 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2531 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2532 The actual value is always <= INT_MAX, and leaving it unsigned made
2533 overflow checking harder.
2535 * dispextern.h (struct glyph_matrix.rows_allocated)
2536 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2537 with xpalloc. The values are still always <= INT_MAX.
2539 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2541 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2542 (SAFE_NALLOCA): New macro.
2544 * region-cache.c (struct boundary.pos, find_cache_boundary)
2545 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2546 (set_cache_region, invalidate_region_cache)
2547 (revalidate_region_cache, know_region_cache, region_cache_forward)
2548 (region_cache_backward, pp_cache):
2549 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2550 so that ptrdiff_t * can be passed to xpalloc.
2551 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2552 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2553 (pp_cache): Don't assume cache_len fits in int.
2554 * region-cache.h: Adjust extern decls to match.
2556 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2557 EMACS_INT, since either will do, for xpalloc.
2559 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2560 (xnmalloc, xnrealloc, xpalloc): New functions.
2562 * bidi.c (bidi_shelve_header_size): New constant.
2563 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2564 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2566 * bidi.c (bidi_cache_shrink):
2567 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2569 Don't update size of array until after memory allocation succeeds,
2570 because xmalloc/xrealloc may not return.
2571 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2572 now that we have proper integer overflow checking.
2573 (record_overlay_string, overlay_strings): Catch overflows when
2574 calculating size of overlay_str_buf.
2576 * callproc.c (Fcall_process): Check for size overflow when
2577 calculating size of args2.
2578 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2579 Normally we prefer signed values, but sticking with ptrdiff_t would
2580 require adding more-complicated checks.
2582 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2583 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2584 Redo buffer-overflow calculations to avoid integer overflow.
2585 Add a FIXME comment where memory seems to be over-allocated.
2587 * character.c (Fstring): Check for size-calculation overflow.
2589 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2590 unnecessary integer overflow. Check for size overflow.
2591 (encode_coding_object): Don't update size until xmalloc succeeds.
2593 * composite.c (get_composition_id): Check for overflow in glyph
2594 length calculations.
2596 Integer and memory overflow fixes for display code.
2597 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2598 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2599 (scrolling_window): Check for overflow in size calculations.
2600 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2601 Don't assume glyph table len fits in int.
2602 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2603 (row_table_size): Now ptrdiff_t, not int.
2604 (scrolling_window): Avoid overflow in size calculations.
2605 Don't update size until allocation succeeds.
2606 * fns.c (concat): Check for overflow in size calculations.
2607 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2608 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2609 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2611 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2612 (get_doc_string): Check for size calculation overflow.
2613 Don't update size until allocation succeeds.
2614 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2615 EMACS_INT, where ptrdiff_t will do.
2616 (Fsubstitute_command_keys): Check for string overflow.
2618 * editfns.c (set_time_zone_rule): Don't assume environment length
2620 (message_length): Now ptrdiff_t, not int.
2621 (Fmessage_box): Don't update size until allocation succeeds.
2622 Don't assume message length fits in int.
2623 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2625 * emacs.c (main): Do not reallocate argv, since there is a null at
2626 the end that can be overwritten, and this way there's no need to
2627 worry about size-calculation overflow.
2628 (sort_args): Check for size-calculation overflow.
2630 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2632 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2634 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2635 (x_set_scroll_bar_width, x_figure_window_size):
2636 Check for integer overflow.
2637 (x_set_alpha): Do not assume XINT fits in int.
2639 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2640 This is for the members text_lines, text_cols, total_lines, total_cols,
2641 where the system imposes an 'int' limit.
2643 * fringe.c (Fdefine_fringe_bitmap):
2644 Don't update size until alloc works.
2646 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2647 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2649 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2650 Check for size-calculation overflow.
2651 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2652 do, as we prefer signed integers.
2653 (id_to_widget.max_size, id_to_widget.used)
2654 (xg_store_widget_in_map, xg_remove_widget_from_map)
2655 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2656 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2657 Use and return ptrdiff_t, not int.
2658 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2659 * gtkutil.h: Change prototypes to match the above.
2661 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2662 are duplicate now that they've been promoted to lisp.h.
2663 (x_allocate_bitmap_record, x_alloc_image_color)
2664 (make_image_cache, cache_image, xpm_load):
2665 Don't update size until alloc is done.
2666 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2668 Check for size calculation overflow.
2669 (ct_colors_allocated_max): New constant.
2670 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2673 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2674 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2675 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2676 Use ptrdiff_t, not int, to count maps.
2677 (read_char_minibuf_menu_prompt): Check for overflow in size
2678 calculations. Don't update size until allocation succeeds.
2679 Redo calculations to avoid overflow.
2680 * keyboard.h: Change prototypes to match the above.
2682 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2684 (current_minor_maps): Check for size calculation overflow.
2685 * keymap.h: Change prototypes to match the above.
2687 * lread.c (read1, init_obarray): Don't update size until alloc done.
2689 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2690 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2692 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2693 Now ptrdiff_t, not int.
2694 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2695 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2697 * process.c (Fnetwork_interface_list): Check for overflow
2698 in size calculation.
2700 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2702 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2703 overflow. Don't bother calling xmalloc when xrealloc will do.
2705 * search.c (Freplace_match): Check for size calculation overflow.
2706 (Fset_match_data): Don't assume list lengths fit in 'int'.
2708 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2709 for command line length. Do not attempt to address one before the
2710 beginning of an array, as that's not portable.
2712 * term.c (max_frame_lines): Remove; unused.
2713 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2715 (encode_terminal_code, calculate_costs): Check for size
2716 calculation overflow.
2717 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2718 table lengths and related sizes. Don't update size until alloc
2719 done. Redo calculations to avoid overflow.
2720 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2722 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2723 subtracting pointers.
2724 (gobble_line): Check for overflow more carefully. Don't update size
2727 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2728 Don't update size until alloc done.
2729 Redo size calculations to avoid overflow.
2730 Check for size calculation overflow.
2731 (main) [DEBUG]: Fix typo in invoking tparam1.
2733 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2734 Use ptrdiff_t, not int, for sizes.
2735 (store_mode_line_noprop_char): Don't update size until alloc done.
2737 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2738 Use ptrdiff_t, not int, for sizes.
2739 (Finternal_make_lisp_face, cache_face):
2740 Check for size calculation overflow.
2741 (cache_face): Treat size calculation overflows as if they were
2742 memory exhaustion (the usual treatment), rather than aborting.
2744 * xfns.c (x_encode_text, x_set_name_internal)
2745 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2746 sizes, since they can exceed INT_MAX in size. Check for size
2747 calculation overflow.
2749 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2750 (xg_select): Check for size calculation overflow.
2751 Don't update size until alloc done.
2753 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2754 as sprintf is limited to int lengths.
2756 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2757 (X_LONG_MIN): New macros.
2758 Use them to make the following changes clearer.
2759 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2760 This change doesn't affect the value now, but it may help remind
2761 future maintainers not to raise the value too much later.
2762 (SELECTION_QUANTUM): Remove, replacing with ...
2763 (selection_quantum): ... new function, which avoids overflow.
2765 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2766 assumption that selection length fits in 'int'.
2767 (x_reply_selection_request, x_handle_selection_request)
2768 (x_get_window_property, receive_incremental_selection)
2769 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2770 (lisp_data_to_selection_data, clean_local_selection_data):
2771 Use ptrdiff_t, not int, to record length of selection.
2772 (x_reply_selection_request, x_get_window_property)
2773 (receive_incremental_selection, x_property_data_to_lisp):
2774 Redo calculations to avoid overflow.
2775 (x_reply_selection_request): When sending hint, ceiling it at
2776 X_LONG_MAX rather than relying on wraparound overflow to send
2778 (x_get_window_property, receive_incremental_selection)
2779 (lisp_data_to_selection_data, x_property_data_to_lisp):
2780 Check for size-calculation overflow.
2781 (x_get_window_property, receive_incremental_selection)
2782 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2783 Don't store size until memory allocation succeeds.
2784 (x_get_window_property): Plug memory leak on memory exhaustion.
2785 Don't double-block input; malloc is safe here. Don't assume 2**34
2786 - 4 fits in unsigned long. Add an xassert to check
2787 XGetWindowProperty overflow. Be more careful about overflow
2788 calculations, and distinguish size from memory overflow better.
2789 (receive_incremental_selection): When tracing, don't assume
2790 unsigned int is less than INT_MAX.
2791 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2792 harmful) conversions of unsigned short to int.
2793 (lisp_data_to_selection_data): Don't assume that integers
2794 in the range -65535 through -1 fit in an X unsigned short.
2795 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2796 result parameters unless successful. Rely on cons_to_unsigned
2797 to report problems with elements; the old code wasn't right anyway.
2798 (x_check_property_data): Check for int overflow; we cannot use
2799 a wider type due to X limits.
2800 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2802 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2804 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2805 (x_term_init): Check for size calculation overflow.
2806 (x_color_cells): Don't store size until memory allocation succeeds.
2807 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2808 Don't assume alloca size is less than MAX_ALLOCA.
2809 (x_term_init): Don't assume length fits in int (sprintf is limited
2812 Use ptrdiff_t for composition IDs.
2813 * character.c (lisp_string_width):
2814 * composite.c (composition_table_size, n_compositions)
2815 (get_composition_id, composition_gstring_from_id):
2816 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2817 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2818 * window.c (Frecenter):
2819 Use ptrdiff_t, not int, for composition IDs.
2820 * composite.c (get_composition_id): Check for integer overflow.
2821 * composite.h: Adjust prototypes to match the above changes.
2823 Use ptrdiff_t for hash table indexes.
2824 * category.c (hash_get_category_set):
2825 * ccl.c (ccl_driver):
2826 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2827 * coding.c (coding_system_charset_list, detect_coding_system):
2828 * coding.h (struct coding_system.id):
2829 * composite.c (get_composition_id, gstring_lookup_cache):
2830 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2831 * image.c (xpm_get_color_table_h):
2832 * lisp.h (hash_lookup, hash_put):
2833 * minibuf.c (Ftest_completion):
2834 Use ptrdiff_t for hash table indexes, not int (which is too
2835 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2836 32-bit --with-wide-int hosts).
2838 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2839 Add a FIXME comment about memory leaks.
2840 (syms_of_charset): Don't assume xmalloc returns.
2842 Don't assume that stated character widths fit in int.
2843 * character.c (Fchar_width, c_string_width, lisp_string_width):
2844 * character.h (CHAR_WIDTH):
2845 * indent.c (MULTIBYTE_BYTES_WIDTH):
2846 Use sanitize_char_width to avoid undefined and/or bad behavior
2847 with outlandish widths.
2848 * character.h (sanitize_tab_width): Rename from sanitize_width,
2849 now that we have two such functions. All uses changed.
2850 (sanitize_char_width): New inline function.
2852 Don't assume that tab-width fits in int.
2853 * character.h (sanitize_width): New inline function.
2854 (SANE_TAB_WIDTH): New macro.
2855 (ASCII_CHAR_WIDTH): Use it.
2856 * indent.c (sane_tab_width): Remove. All uses replaced by
2857 SANE_TAB_WIDTH (current_buffer).
2858 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2860 * fileio.c: Integer overflow issues with file modes.
2861 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2863 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2864 Remove unreachable code.
2865 (read_hex, load_charset_map_from_file): Check for integer overflow.
2867 * xterm.c: Don't go over XClientMessageEvent limit.
2868 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2869 (x_send_scroll_bar_event): Likewise. Check that the size does not
2870 exceed limits imposed by XClientMessageEvent, as well as the usual
2871 ptrdiff_t and size_t limits.
2873 * keyboard.c: Overflow, signedness and related fixes.
2874 (make_lispy_movement): Use same integer type in forward decl
2875 that is used in the definition.
2876 (read_key_sequence, keyremap_step):
2877 Change bufsize argument back to int, undoing my 2011-03-30 change.
2878 We prefer signed types, and int is wide enough here.
2879 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2880 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2881 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2882 length, not size_t. Use ptrdiff_t for index, not int.
2883 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2884 possibility of integer overflow.
2886 Overflow, signedness and related fixes for images.
2888 * dispextern.h (struct it.stack[0].u.image.image_id)
2889 (struct_it.image_id, struct image.id, struct image_cache.size)
2890 (struct image_cache.used, struct image_cache.ref_count):
2891 * gtkutil.c (update_frame_tool_bar):
2892 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2893 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2894 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2895 * nsmenu.m (update_frame_tool_bar):
2896 * xdisp.c (calc_pixel_width_or_height):
2897 * xfns.c (image_cache_refcount):
2898 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2899 on typical 64-bit hosts.
2901 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2902 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2903 Omit unnecessary casts to int.
2904 (parse_image_spec): Check that integers fall into 'int' range
2905 when the callers expect that.
2906 (image_ascent): Redo ascent calculation to avoid int overflow.
2907 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2908 (lookup_image): Remove unnecessary tests.
2909 (xbm_image_p): Locals are now of int, not EMACS_INT,
2910 since parse_image_check makes sure they fit into int.
2911 (png_load, gif_load, svg_load_image):
2912 Prefer int to unsigned where either will do.
2913 (tiff_handler): New function, combining the cores of the
2914 old tiff_error_handler and tiff_warning_handler.
2915 This function is rewritten to use vsnprintf and thereby avoid
2916 stack buffer overflows. It uses only the features of vsnprintf
2917 that are common to both POSIX and native Microsoft.
2918 (tiff_error_handler, tiff_warning_handler): Use it.
2919 (tiff_load, gif_load, imagemagick_load_image):
2920 Don't assume :index value fits in 'int'.
2921 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2922 (imagemagick_load_image): Check that crop parameters fit into
2923 the integer types that MagickCropImage accepts. Don't assume
2924 Vimagemagick_render_type has a nonnegative value. Don't assume
2925 size_t fits in 'long'.
2926 (gs_load): Use printmax_t to print the widest integers possible.
2927 Check for integer overflow when computing image height and width.
2929 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2931 * xdisp.c (redisplay_window): Don't force window start if point
2932 will be invisible in the resulting window. (Bug#9324)
2934 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2936 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2937 the display spec is of the form `(space ...)'.
2938 (handle_display_spec): Return the value returned by
2939 handle_single_display_spec, not just 1 or zero.
2940 (handle_single_display_spec): If the display spec is of the form
2941 `(space ...)', and specifies display in the text area, return 2
2943 (try_cursor_movement): Check for the need to scroll more
2944 accurately, and prefer exact match for point under bidi.
2945 Don't advance `row' beyond the last row of the window.
2947 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2948 into disp_prop; all users changed.
2950 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2951 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2952 for the text covered by the display property.
2954 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2956 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2957 Change return value to nil.
2958 (Frecord_buffer): Delete unused function.
2960 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2962 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2963 buffers, return left-to-right.
2964 (set_cursor_from_row): Consider candidate row a win if its glyph
2965 represents a newline and point is on that newline. Fixes cursor
2966 positioning on the newline at EOL of R2L text within L2R
2967 paragraph, and vice versa.
2968 (try_cursor_movement): Check continued rows, in addition to
2969 continuation rows. Fixes unwarranted scroll when point enters a
2970 continued line of R2L text within an L2R paragraph, or vice versa.
2971 (cursor_row_p): Consider the case of point being equal to
2972 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2973 from the end of a short line to the beginning of a continued line
2974 of R2L text within L2R paragraph.
2975 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2976 composed characters.
2978 * bidi.c (bidi_check_type): Use xassert.
2979 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2982 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2984 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2987 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2989 * nsfont.m (ns_otf_to_script): Fix typo.
2991 2011-08-22 Kenichi Handa <handa@m17n.org>
2993 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2994 extra slot even if the purpose is char-code-property-table.
2996 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2998 * xdisp.c (redisplay_window): When computing centering_position,
2999 account for the height of the header line. (Bug#8874)
3001 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3002 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3003 candidate is selected by the mouse, and that candidate has a
3004 composed character under the mouse.
3006 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3007 coordinates reported by pos-visible-in-window-p for a composed
3008 character in column zero.
3010 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3012 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3014 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3016 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3017 consider it a hit if to_charpos is anywhere in the range of the
3018 composed buffer positions.
3020 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3022 * image.c (gif_load): Don't assume that each subimage has the same
3023 dimensions as the base image. Handle disposal method that is
3024 "undefined" by the gif spec (Bug#9335).
3026 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3028 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3029 (Fcondition_case): Document `debug' symbol in error handler.
3031 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3033 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3034 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3035 from an Org mode buffer to a Speedbar frame.
3037 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3038 a composition, take its buffer position from IT->cmp_it.charpos.
3039 Fixes cursor positioning at the beginning of a line that begins
3040 with a composed character.
3042 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3044 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3045 character bidirectional type, use STRONG_L instead. Fixes crashes
3046 in a buffer produced by `describe-categories'.
3048 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3049 members before the level stack, so they would be saved and
3050 restored when copying iterator state. Fixes incorrect reordering
3051 around TABs covered by display properties.
3053 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3055 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3057 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3059 * eval.c (internal_condition_case, internal_condition_case_1)
3060 (internal_condition_case_2, internal_condition_case_n):
3061 Remove unnecessary aborts (Bug#9081).
3063 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3065 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3066 has no `load' handler, try opening the file locally. (Bug#9311)
3068 2011-08-16 Ken Brown <kbrown@cornell.edu>
3070 * gmalloc.c: Expand comment.
3072 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3074 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3075 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3077 2011-08-16 Ken Brown <kbrown@cornell.edu>
3079 Fix memory allocation problems in Cygwin build (Bug#9273).
3081 * unexcw.c ( __malloc_initialized): Declare external variable.
3082 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3084 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3086 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3088 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3090 [CYGWIN] (special_realloc): New function.
3091 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3092 requests to realloc storage in the static heap.
3094 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3096 * bidi.c (bidi_initialize): Remove unused local.
3098 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3101 * biditype.h: Remove file.
3102 * makefile.w32-in ($(BLD)/bidi.$(O)):
3103 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3105 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3107 * chartab.c: Improve commentary for the uniprop_table API.
3109 * bidi.c (bidi_paragraph_init): Support zero value of
3110 bidi_ignore_explicit_marks_for_paragraph_level.
3111 (bidi_initialize): Use uniprop_table instead of including
3112 biditype.h and bidimirror.h.
3114 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3115 coordinates of the iterator when restoring from ppos_it.
3118 2011-08-14 Kenichi Handa <handa@m17n.org>
3120 * process.c (create_process): Call setup_process_coding_systems
3121 after the pid of the process is set to -1 (Bug#8162).
3123 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3125 * xdisp.c (move_it_in_display_line_to): Don't invoke
3126 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3127 ppos_it. Fixes vertical cursor motion when line beginning is
3128 covered by an image. (Bug#9296)
3130 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3132 * nsterm.h (ns_run_ascript): Declare.
3133 (NSAPP_DATA2_RUNASSCRIPT): Define.
3135 * nsfns.m (as_script, as_result, as_status): New static variables.
3136 (ns_run_ascript): New function.
3137 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3138 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3139 the event loop. Get status from as_status (Bug#7276).
3141 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3142 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3143 the event loop (Bug#7276).
3145 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3147 * gnutls.c (QCgnutls_bootprop_priority)
3148 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3149 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3150 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3151 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3152 (QCgnutls_bootprop_verify_hostname_error)
3153 (QCgnutls_bootprop_callbacks_verify): Rename from
3154 Qgnutls_bootprop_..., all uses changed.
3156 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3159 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3161 * xfaces.c (Qframe_set_background_mode): Now static.
3162 * dispextern.h (Qframe_set_background_mode): Remove decl.
3164 * process.c (Fnetwork_interface_info): Declare local only if needed.
3166 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3168 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3169 (Fnetwork_interface_list): Allocate in increments of bytes instead
3170 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3171 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3173 (struct ifflag_def): notrailers is smart on OSX.
3174 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3175 Get hardware address with getifaddrs if available.
3177 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3179 * xdisp.c (iterate_out_of_display_property): xassert that
3180 IT->position is set to within IT->object's boundaries. Break from
3181 the loop as soon as EOB is reached; avoids infloops in redisplay
3182 when IT->position is set up wrongly due to some bug.
3183 Set IT->current to match the bidi iterator unconditionally.
3184 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3185 entry. Force push_it to save on the stack the current
3186 buffer/string position, to be restored by pop_it. Fix flags in
3187 the iterator structure wrt the object coming from a display
3188 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3189 properties. (Bug#9284)
3191 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3193 * fontset.c (fontset_get_font_group): Add proper type checks.
3196 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3198 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3199 and LC_VERSION_MIN_MACOSX.
3200 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3201 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3203 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3205 * xdisp.c (forward_to_next_line_start): Allow to use the
3206 no-display-properties-and-no-overlays under bidi display.
3207 Set disp_pos in the bidi iterator to avoid searches for display
3208 properties and overlays.
3210 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3212 * editfns.c (Fset_time_zone_rule): Document relationship with the
3215 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3216 the font entity extracted from the cache (Bug#8109).
3218 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3220 * composite.c (autocmp_chars): Don't reset point. That is done by
3221 restore_point_unwind (Bug#5984).
3223 2011-08-07 Juri Linkov <juri@jurta.org>
3225 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3226 to show the arg `TIME' instead of `TIMEVAL'.
3228 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3230 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3231 display property strides EOL and includes a newline, as in
3232 longlines-mode. (Bug#9254)
3233 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3234 word-wrap under bidirectional display. (Bug#9224)
3236 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3237 is non-zero, even if the data buffer is NULL. Fixes a crash in
3238 vertical-motion with longlines-mode. (Bug#9254)
3240 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3242 * bidi.c <bidi_cache_total_alloc>: Now static.
3243 (bidi_initialize): Initialize bidi_cache_total_alloc.
3245 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3248 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3249 amount allocated this far in `bidi_cache_total_alloc'.
3250 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3251 non-zero, only free the data buffer without restoring the cache
3252 contents. All callers changed.
3254 * dispextern.h (bidi_unshelve_cache): Update prototype.
3256 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3257 (move_it_in_display_line, move_it_to)
3258 (move_it_vertically_backward, move_it_by_lines): Replace the call
3259 to xfree to an equivalent call to bidi_unshelve_cache.
3260 (move_it_in_display_line_to): Fix logic of returning
3261 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3263 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3265 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3266 came from a string character with a `cursor' property. (Bug#9229)
3268 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3270 * Makefile.in (LIB_PTHREAD): New variable.
3271 (LIBES): Add LIB_PTHREAD (Bug#9216).
3273 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3274 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3276 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3278 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3280 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3282 * xterm.c (x_find_topmost_parent): New function.
3283 (x_set_frame_alpha): Find topmost parent window with
3284 x_find_topmost_parent and set the property there also (bug#9181).
3285 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3287 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3289 * callproc.c (Fcall_process): Avoid vfork clobbering
3290 the local vars buffer, coding_systems, current_dir.
3292 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3294 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3296 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3298 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3299 so that it is not optimized away.
3301 * xdisp.c (compute_display_string_pos): Remove unused local.
3303 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3305 Fix slow cursor motion and scrolling in large buffers with
3306 selective display, like Org Mode buffers. (Bug#9218)
3308 * dispextern.h (struct bidi_it): New member disp_prop_p.
3310 * xdisp.c: Remove one-slot cache of display string positions.
3311 (compute_display_string_pos): Accept an additional argument
3312 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3313 for a display string or property. If found, set DISP_PROP_P
3316 * bidi.c (bidi_fetch_char): Accept an additional argument
3317 DISP_PROP_P, and pass it to compute_display_string_pos.
3318 Only handle text covered by a display string if DISP_PROP_P is returned
3319 non-zero. All callers of bidi_fetch_char changed.
3321 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3323 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3325 2010-12-03 Don March <don@ohspite.net>
3327 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3328 last character M-[char] is translated to ESC [char] (bug#7541).
3330 2011-08-02 Kenichi Handa <handa@m17n.org>
3332 * lisp.h (uniprop_table): Extern it.
3334 * chartab.c (uniprop_table): Make it non-static.
3336 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3338 * xdisp.c (forward_to_next_line_start): Accept additional argument
3339 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3341 (reseat_at_next_visible_line_start): Use the bidi iterator state
3342 returned by forward_to_next_line_start to restore the state of
3343 it->bidi_it after backing up to previous newline. (Bug#9212)
3345 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3347 * regex.c (re_comp): Protoize.
3348 (re_exec): Fix return type.
3349 (regexec): Fix type of `ret'. (Bug#9203)
3351 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3353 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3354 This is needed if max-image-size is a floating-point number.
3356 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3358 * print.c (print_object): Print empty symbol as ##.
3360 * lread.c (read1): Read ## as empty symbol.
3362 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3364 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3365 setting frame foreground color (Bug#9175).
3366 (x_set_background_color): Likewise.
3368 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3369 contents (Bug#9176).
3370 (EmacsTooltip -init): Remove bezels and add shadows to
3373 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3374 or scroll bar (Bug#8470).
3376 * nsfont.m (nsfont_open): Remove assignment to voffset and
3377 unnecessary vars hshink, expand, hd, full_height, min_height.
3378 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3380 * nsterm.h (nsfont_info): Remove voffset field.
3382 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3384 Implement strike-through and overline on NextStep (Bug#8863).
3386 * nsfont.m (nsfont_open): Use underline position provided by font,
3387 instead of hard-coded value of 2.
3388 (nsfont_draw): Call ns_draw_text_decoration instead.
3390 * nsterm.h: Add declaration for ns_draw_text_decoration.
3392 * nsterm.m (ns_draw_text_decoration): New function for drawing
3393 underline, overline, and strike-through.
3394 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3395 ns_draw_text_decoration. Change treatment of cursor drawing to
3396 accommodate underlining, etc.
3398 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3400 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3403 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3405 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3406 Without this fix, if a signal arrives just after memory fills up,
3407 'malloc' might be invoked reentrantly.
3409 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3410 In other words, assume that every image size is allowed, on non-X
3411 hosts. This assumption is probably wrong, but it lets Emacs compile.
3413 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3415 * regex.c (re_iswctype): Convert return values to boolean.
3417 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3419 * xdisp.c (compute_display_string_pos): Don't use cached display
3420 string position if the buffer had its restriction changed.
3423 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3425 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3427 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3429 Integer signedness and overflow and related fixes. (Bug#9079)
3431 * bidi.c: Integer size and overflow fixes.
3432 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3433 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3434 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3435 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3436 (bidi_find_other_level_edge):
3437 Use ptrdiff_t instead of EMACS_INT where either will do.
3438 This works better on 32-bit hosts configured --with-wide-int.
3439 (bidi_cache_ensure_space): Check for size-calculation overflow.
3440 Use % rather than repeated addition, for better worst-case speed.
3441 Don't set bidi_cache_size until after xrealloc returns, because it
3443 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3444 (bidi_cache_ensure_space): Also check that the bidi cache size
3445 does not exceed that of the largest Lisp string or buffer. See Eli
3446 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3448 * alloc.c (__malloc_size_t): Remove.
3449 All uses replaced by size_t. See Andreas Schwab's note
3450 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3452 * image.c: Improve checking for integer overflow.
3453 (check_image_size): Assume that f is nonnull, since
3454 it is always nonnull in practice. This is one less thing to
3455 worry about when checking for integer overflow later.
3456 (x_check_image_size): New function, which checks for integer
3457 overflow issues inside X.
3458 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3459 This removes the need for a memory_full check.
3460 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3461 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3462 (xbm_read_bitmap_data): Change locals back to 'int', since
3463 their values must fit in 'int'.
3464 (xpm_load_image, png_load, tiff_load):
3465 Invoke x_create_x_image_and_pixmap earlier,
3466 to avoid much needless work if the image is too large.
3467 (tiff_load): Treat overly large images as if
3468 x_create_x_image_and_pixmap failed, not as malloc failures.
3469 (gs_load): Use x_check_image_size.
3471 * gtkutil.c: Omit integer casts.
3472 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3473 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3475 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3477 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3478 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3479 would wrongly return t on a 64-bit host.
3481 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3482 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3483 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3484 and therefore cause GCC to emit a bogus diagnostic in some cases.
3486 * image.c: Integer signedness and overflow and related fixes.
3487 This is not an exhaustive set of fixes, but it's time to
3488 record what I've got.
3489 (lookup_pixel_color, check_image_size): Remove redundant decls.
3490 (check_image_size): Don't assume that arbitrary EMACS_INT values
3491 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3492 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3493 (tiff_load, imagemagick_load_image):
3494 Check for overflow in size calculations.
3495 (x_create_x_image_and_pixmap): Remove unnecessary test for
3496 xmalloc returning NULL; that can't happen.
3497 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3498 (xpm_color_bucket): Use better integer hashing function.
3499 (xpm_cache_color): Don't possibly over-allocate memory.
3500 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3501 (gif_memory_source):
3502 Use ptrdiff_t, not int or size_t, to record sizes.
3503 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3504 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3505 either works, as we prefer signed integers.
3506 (tiff_read_from_memory, tiff_write_from_memory):
3507 Return tsize_t, not size_t, since that's what the TIFF API wants.
3508 (tiff_read_from_memory): Don't fail simply because the read would
3509 go past EOF; instead, return a short read.
3510 (tiff_load): Omit no-longer-needed casts.
3511 (Fimagemagick_types): Don't assume size fits into 'int'.
3513 Improve hashing quality when configured --with-wide-int.
3514 * fns.c (hash_string): New function, taken from sxhash_string.
3515 Do not discard information about ASCII character case; this
3516 discarding is no longer needed.
3517 (sxhash-string): Use it. Change sig to match it. Caller changed.
3518 * lisp.h: Declare it.
3519 * lread.c (hash_string): Remove, since we now use fns.c's version.
3520 The fns.c version returns a wider integer if --with-wide-int is
3521 specified, so this should help the quality of the hashing a bit.
3523 * emacs.c: Integer overflow minor fix.
3524 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3525 Define only if GNU_LINUX.
3526 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3528 * dispnew.c: Integer signedness and overflow fixes.
3529 Remove unnecessary forward decls, that were a maintenance hassle.
3530 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3532 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3533 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3534 (prepare_desired_row, line_draw_cost):
3535 Use int, not unsigned, where either works.
3536 (save_current_matrix, restore_current_matrix):
3537 Use ptrdiff_t, not size_t, where either works.
3538 (init_display): Check for overflow more accurately, and without
3539 relying on undefined behavior.
3541 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3542 Remove, replacing with the new symbols in lisp.h. All uses changed.
3543 * fileio.c (make_temp_name):
3544 * filelock.c (lock_file_1, lock_file):
3545 * xdisp.c (message_dolog):
3546 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3547 Use pMd etc. instead.
3548 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3549 replacing the pWIDE etc. symbols removed from editfns.c.
3551 * keyboard.h (num_input_events): Now uintmax_t.
3552 This is (very slightly) less likely to mess up due to wraparound.
3555 * buffer.c: Integer signedness fixes.
3556 (alloc_buffer_text, enlarge_buffer_text):
3557 Use ptrdiff_t rather than size_t when either will do, as we prefer
3560 * alloc.c: Integer signedness and overflow fixes.
3561 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3562 (__malloc_size_t): Default to size_t, not to int.
3563 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3564 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3565 Prefer ptrdiff_t to size_t when either would do, as we prefer
3567 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3568 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3569 Now const. Initialize with values that are in range even if char
3571 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3572 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3573 These functions do the right thing with sizes > 2**32.
3574 (check_depth): Now ptrdiff_t, not int.
3575 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3576 Adjust to new way of storing sizes. Check for size overflow bugs
3578 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3579 slightly wrong anyway, as it missed one instance of
3580 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3581 (refill_memory_reserve): Omit needless cast to size_t.
3582 (mark_object_loop_halt): Mark as externally visible.
3584 * xselect.c: Integer signedness and overflow fixes.
3585 (Fx_register_dnd_atom, x_handle_dnd_message):
3586 Use ptrdiff_t, not size_t, since we prefer signed.
3587 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3588 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3589 x_dnd_atoms_size and x_dnd_atoms_length.
3591 * doprnt.c: Prefer signed to unsigned when either works.
3593 * doprnt.c (doprnt):
3595 * xdisp.c (vmessage):
3596 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3597 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3598 prefer signed arithmetic to avoid comparison confusion.
3599 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3600 but is a bit tricky.
3602 Assume freestanding C89 headers, string.h, stdlib.h.
3603 * data.c, doprnt.c, floatfns.c, print.c:
3604 Include float.h unconditionally.
3605 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3606 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3607 * regex.c: Likewise for stddef.h, string.h.
3608 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3609 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3610 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3611 (STDC_HEADERS): Remove obsolete defines.
3612 * sysdep.c: Include limits.h unconditionally.
3614 Assume support for memcmp, memcpy, memmove, memset.
3615 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3616 * regex.c (memcmp, memcpy):
3617 Remove; we assume C89 now.
3619 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3620 (__malloc_safe_bcopy): Remove; no longer needed.
3622 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3623 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3624 well either way, and we prefer signed to unsigned.
3626 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3628 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3629 closes the connection while we're reading (bug#9182).
3631 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3633 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3634 are specified (Bug#9168).
3636 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3638 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3639 Found by GCC static checking and --with-wide-int on a 32-bit host.
3641 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3643 * xdisp.c (compute_display_string_pos): Fix logic of caching
3644 previous display string position. Initialize cached_prev_pos to
3645 -1. Fixes slow-down at the beginning of a buffer.
3647 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3649 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3650 for attrs[LFACE_FONTSET_INDEX].
3652 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3654 * xml.c (parse_region): Remove unused local
3655 that was recently introduced.
3657 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3659 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3660 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3662 * xdisp.c (move_it_in_display_line_to): Record the best matching
3663 position for TO_CHARPOS while scanning the line, and restore it on
3664 exit if none of the characters scanned was an exact match.
3665 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3666 when exact match is impossible due to invisible text, and the
3667 lines are truncated.
3669 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3671 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3674 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3676 Fix a significant slow-down of cursor motion with C-n, C-p,
3677 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3678 auto-repeat under bidi redisplay in fontified buffers.
3679 * xdisp.c (compute_stop_pos_backwards): New function.
3680 (next_element_from_buffer): Call compute_stop_pos_backwards to
3681 find a suitable prev_stop when we find ourselves before
3683 (reseat): Don't look for prev_stop, as that could mean a very long
3685 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3686 <cached_disp_overlay_modiff>: Cache for last found display string
3688 (compute_display_string_pos): Return the cached position if asked
3689 about the same buffer in the same area of character positions, and
3690 the buffer wasn't changed since the time the display string
3691 position was cached.
3693 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3695 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3696 is an integer, which is important for empty lines. (Bug#9149)
3698 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3700 * frame.c (Fmodify_frame_parameters): In tty case, update the
3701 default face if necessary (Bug#4238).
3703 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3705 * editfns.c (Fstring_to_char): No need to explain what a character
3706 is in the docstring (Bug#6576).
3708 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3710 * xml.c (parse_region): Make sure we always return a tree.
3712 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3714 * xml.c (parse_region): If a document contains only comments,
3717 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3719 * xml.c (make_dom): Return comments, too.
3721 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3724 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3725 and the surrounding thread.
3726 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3727 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3728 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3730 * s/openbsd.h (BROKEN_SIGIO): Define.
3731 * unexelf.c (unexec) [__OpenBSD__]:
3732 Don't update the .mdebug section of the Alpha COFF symbol table.
3734 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3736 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3739 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3741 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3742 This fixes some race conditions on the permissions of any newly
3745 * alloc.c (valid_pointer_p): Use pipe, not open.
3746 This fixes some permissions issues when debugging.
3748 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3749 If fchown fails to set both uid and gid, try to set just gid,
3750 as that is sometimes allowed. Adjust the file's mode to eliminate
3751 setuid or setgid bits that are inappropriate if fchown fails.
3753 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3755 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3756 to compare Lisp_Objects.
3757 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3758 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3759 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3761 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3763 * lread.c (read_integer): Unread even EOF character.
3764 (read1): Likewise. Properly record start position of symbol.
3766 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3767 symbol character follows.
3769 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3771 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3772 This works around a problem with the previous change to Fcopy_file.
3773 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3774 and without this change, GCC might complain about discarding
3775 fchown's return value.
3777 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3779 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3781 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3783 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3785 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3788 it's used from the C level.
3790 * process.c: Use the same condition for POLL_FOR_INPUT in both
3791 keyboard.c and process.c (bug#1858).
3793 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3795 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3796 (Fgnutls_boot): Use it.
3798 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3800 * doc.c (Fsubstitute_command_keys): Revert last change.
3802 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3804 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3805 quotes the next character, and doesn't affect other longer
3806 sequences (bug#8935).
3808 * lread.c (syms_of_lread): Clarify that is isn't only
3809 `eval-buffer' and `eval-defun' that's affected by
3810 `lexical-binding' (bug#8460).
3812 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3814 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3815 bidi redisplay when a line includes both an image and is truncated.
3817 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3819 Fix minor problems found by static checking.
3820 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3821 (elsz): Now a signed constant, not a size_t var. We prefer signed
3822 types to unsigned, to avoid integer comparison confusion. Without
3823 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3824 "cannot optimize loop, the loop counter may overflow", a symptom
3826 * indent.c (Fvertical_motion): Mark locals as initialized.
3827 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3829 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3831 * search.c (Fre_search_backward): Mention `case-fold-search' in
3832 all the re_search_* functions (bug#8138).
3834 * keyboard.c (Fopen_dribble_file): Document when the file is
3837 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3839 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3842 Support bidi reordering of display and overlay strings.
3843 * xdisp.c (compute_display_string_pos)
3844 (compute_display_string_end): Accept additional argument STRING.
3845 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3846 (reseat_to_string): Initialize bidi_it->string.s and
3847 bidi_it->string.schars.
3848 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3849 NULL (avoids a crash in bidi_paragraph_init).
3850 Initialize itb.string.lstring.
3851 (init_iterator): Call bidi_init_it only of a valid
3852 buffer position was specified. Initialize paragraph_embedding to
3854 (reseat_to_string): Initialize the bidi iterator.
3855 (display_string): If we need to ignore text properties of
3856 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3857 original value of -1 will not work with bidi.)
3858 (compute_display_string_pos): First arg is now struct
3859 `text_pos *'; all callers changed. Support display properties on
3861 (compute_display_string_end): Support display properties on Lisp
3863 (init_iterator, reseat_1, reseat_to_string): Initialize the
3864 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3865 when iterating on a string not from display properties).
3866 (compute_display_string_pos, compute_display_string_end):
3867 Fix calculation of the object to scan. Fixes an error when using
3869 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3870 base_level_stop; instead, set base_level_stop to BEGV.
3871 Fixes crashes in vertical-motion.
3872 (next_element_from_buffer): Improve commentary for when
3873 the iterator is before prev_stop.
3874 (init_iterator): Initialize bidi_p from the default value of
3875 bidi-display-reordering, not from buffer-local value. Use the
3876 buffer-local value only if initializing for buffer iteration.
3877 (handle_invisible_prop): Support invisible properties on strings
3878 that are being bidi-reordered.
3879 (set_iterator_to_next): Support bidi reordering of C strings and
3881 (next_element_from_string): Support bidi reordering of Lisp
3883 (handle_stop_backwards): Support Lisp strings as well.
3884 (display_string): Support display of R2L glyph rows.
3885 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3886 (init_iterator): Don't initialize it->bidi_p for strings
3888 (reseat_to_string): Initialize it->bidi_p for strings here.
3889 (next_element_from_string, next_element_from_c_string)
3890 (next_element_from_buffer): Add xassert's for correspondence
3891 between IT's object being iterated and it->bidi_it.string
3893 (face_before_or_after_it_pos): Support bidi iteration.
3894 (next_element_from_c_string): Handle the case of the first string
3895 character that is not the first one in the visual order.
3896 (get_visually_first_element): New function, refactored from common
3897 parts of next_element_from_buffer, next_element_from_string, and
3898 next_element_from_c_string.
3899 (tool_bar_lines_needed, redisplay_tool_bar)
3900 (display_menu_bar): Force left-to-right direction. Add a FIXME
3901 comment for making that be controlled by a user option.
3902 (push_it, pop_it): Save and restore the state of the
3903 bidi iterator. Save and restore the bidi_p flag.
3904 (pop_it): Iterate out of display property for string iteration as
3906 (iterate_out_of_display_property): Support iteration over strings.
3907 (handle_single_display_spec): Set up it->bidi_it for iteration
3908 over a display string, and call bidi_init_it.
3909 (handle_single_display_spec, next_overlay_string)
3910 (get_overlay_strings_1, push_display_prop): Set up the bidi
3911 iterator for displaying display or overlay strings.
3912 (forward_to_next_line_start): Don't use the shortcut if
3914 (back_to_previous_visible_line_start): If handle_display_prop
3915 pushed the iterator stack, restore the internal state of the bidi
3916 iterator by calling bidi_pop_it same number of times.
3917 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3918 and we are bidi-iterating, don't decrement the iterator position;
3919 instead, set the first_elt flag in the bidi iterator, to produce
3921 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3922 (push_display_prop): xassert that we are iterating a buffer.
3923 (push_it, pop_it): Save and restore paragraph_embedding member.
3924 (handle_single_display_spec, next_overlay_string)
3925 (get_overlay_strings_1, reseat_1, reseat_to_string)
3926 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3927 correctly. Don't assume unibyte strings are not bidi-reordered.
3928 (compute_display_string_pos)
3929 (compute_display_string_end): Fix handling the case of C string.
3930 (push_it, pop_it): Save and restore from_disp_prop_p.
3931 (handle_single_display_spec, push_display_prop): Set the
3932 from_disp_prop_p flag.
3933 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3934 (pop_it): Call iterate_out_of_display_property only if we are
3935 popping after iteration over a string that came from a display
3936 property. Fix a typo in popping stretch info. Add an assertion
3937 for verifying that the iterator position is in sync with the bidi
3939 (handle_single_display_spec, get_overlay_strings_1)
3940 (push_display_prop): Fix initialization of paragraph direction for
3941 string when that of the parent object is not yet determined.
3942 (reseat_1): Call bidi_init_it to resync the bidi
3943 iterator with IT's position. (Bug#7616)
3944 (find_row_edges): If ROW->start.pos gives position
3945 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3946 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3947 Reset the from_disp_prop_p flag.
3948 (SAVE_IT, RESTORE_IT): New macros.
3949 (pos_visible_p, face_before_or_after_it_pos)
3950 (back_to_previous_visible_line_start)
3951 (move_it_in_display_line_to, move_it_in_display_line)
3952 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3953 (try_scrolling, redisplay_window, display_line): Use them when
3954 saving a temporary copy of the iterator and restoring it back.
3955 (back_to_previous_visible_line_start, reseat_1)
3956 (init_iterator): Empty the bidi cache "stack".
3957 (move_it_in_display_line_to): If iterator ended up at
3958 EOL, but we never saw any buffer positions smaller than
3959 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3960 motion in bidi-reordered lines.
3961 (move_it_in_display_line_to): Record prev_method and prev_pos
3962 immediately before the call to set_iterator_to_next. Fixes cursor
3963 motion in bidi-reordered lines with stretch glyphs and strings
3964 displayed in margins. (Bug#8133) (Bug#8867)
3965 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3967 (pos_visible_p): Support positions in bidi-reordered lines.
3968 Save and restore bidi cache.
3970 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3971 (bidi_paragraph_info): Delete unused struct.
3972 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3973 (bidi_cache_start): New variable.
3974 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3976 (bidi_cache_fetch_state, bidi_cache_search)
3977 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3978 (bidi_cache_find, bidi_peek_at_next_level)
3979 (bidi_level_of_next_char, bidi_find_other_level_edge)
3980 (bidi_move_to_visually_next): Compare cache index with
3981 bidi_cache_start rather than with zero.
3982 (bidi_fetch_char): Accept new argument STRING; all callers
3983 changed. Support iteration over a string. Support strings with
3984 display properties. Support unibyte strings. Fix the type of
3985 `len' according to what STRING_CHAR_AND_LENGTH expects.
3986 (bidi_paragraph_init, bidi_resolve_explicit_1)
3987 (bidi_resolve_explicit, bidi_resolve_weak)
3988 (bidi_level_of_next_char, bidi_move_to_visually_next):
3989 Support iteration over a string.
3990 (bidi_set_sor_type, bidi_resolve_explicit_1)
3991 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3992 can now be zero (for strings); special values 0 and -1 were
3993 changed to -1 and -2, respectively.
3994 (bidi_char_at_pos): New function.
3995 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3996 Call it instead of FETCH_MULTIBYTE_CHAR.
3997 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3998 initialized to valid values.
3999 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4001 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4002 the test for valid cached positions. Fix the logic for looking up
4003 the sentinel state in the cache. GCPRO the Lisp string we are
4005 (bidi_push_it, bidi_pop_it): New functions.
4006 (bidi_initialize): Initialize the bidi cache start stack pointer.
4007 (bidi_cache_ensure_space): New function, refactored from part of
4008 bidi_cache_iterator_state. Don't assume the required size is just
4009 one BIDI_CACHE_CHUNK away.
4010 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4011 (bidi_count_bytes, bidi_char_at_pos): New functions.
4012 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4013 always valid if bidi_cache_idx is valid.
4014 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4015 is valid if it's going to be used.
4016 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4017 (bidi_cache_fetch_state, bidi_cache_search)
4018 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4019 (bidi_cache_iterator_state, bidi_cache_find)
4020 (bidi_find_other_level_edge, bidi_cache_start_stack):
4021 All variables related to cache indices are now EMACS_INT.
4023 * dispextern.h (struct bidi_string_data): New structure.
4024 (struct bidi_it): New member `string'. Make flag members be 1-bit
4025 fields, and put them last in the struct.
4026 (compute_display_string_pos, compute_display_string_end):
4028 (bidi_push_it, bidi_pop_it): Add prototypes.
4029 (struct iterator_stack_entry): New members bidi_p,
4030 paragraph_embedding, and from_disp_prop_p.
4031 (struct it): Member bidi_p is now a bit field 1 bit wide.
4032 (bidi_shelve_cache, bidi_unshelve_cache):
4035 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4036 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4037 and vector-like objects.
4039 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4040 cache around display iteration.
4042 * window.c (Fwindow_end, window_scroll_pixel_based)
4043 (displayed_window_lines, Frecenter): Save and restore the bidi
4044 cache around display iteration.
4046 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048 * editfns.c (Fdelete_region): Clarify the use of the named
4049 parameters (bug#6788).
4051 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4053 * indent.c (Fvertical_motion): Set and restore w->pointm when
4054 saving and restoring the window's buffer (Bug#9006).
4056 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4058 * editfns.c (Fstring_to_char): Clarify just what is returned
4059 (bug#6576). Text by Eli Zaretskii.
4061 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4063 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4065 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4067 * buffer.c (mmap_find): Fix a typo.
4069 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4071 Fix execution of x selection hooks.
4072 * xselect.c (Qx_lost_selection_functions)
4073 (Qx_sent_selection_functions): New vars.
4074 (syms_of_xselect): DEFSYM them.
4075 (x_handle_selection_request): Pass Qx_sent_selection_functions
4076 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4077 (x_handle_selection_clear,x_clear_frame_selections):
4078 Pass Qx_lost_selection_functions rather than
4079 Vx_lost_selection_functions to Frun_hook_with_args.
4081 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4083 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4084 The old code sometimes used this field without initializing it.
4086 * alloc.c (gc_sweep): Don't read past end of array.
4087 In theory, the old code could also have corrupted Emacs internals,
4088 though it'd be very unlikely.
4090 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4092 * character.c (Fcharacterp): Don't advertise optional ignored
4093 argument. (Bug#4026)
4095 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4097 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4100 * window.c (Fset_window_start): Doc fix (bug#4199).
4101 (Fset_window_hscroll): Ditto.
4103 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4105 Fix minor new problems caught by GCC 4.6.1.
4106 * term.c (init_tty): Remove unused local.
4107 * xsettings.c (store_monospaced_changed): Define this function only
4108 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4111 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4113 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4115 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4117 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4118 are the mini-buffer and the echo area (bug#3320).
4120 * term.c (init_tty): Remove support for supdup, c10 and perq
4121 terminals, which are no longer supported (bug#1482).
4123 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4125 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4127 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4129 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4130 for non-popups (Bug#3642).
4132 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4134 * alloc.c (reset_malloc_hooks): Protoize.
4135 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4136 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4137 * cm.c (losecursor): Likewise.
4138 * data.c (fmod): Likewise.
4139 * dispnew.c (swap_glyphs_in_rows): Likewise.
4140 * emacs.c (memory_warning_signal): Likewise.
4141 * floatfns.c (float_error): Likewise.
4142 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4143 (otf_open, font_otf_capability, generate_otf_features)
4144 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4146 * image.c (pbm_read_file): Likewise.
4147 * indent.c (string_display_width): Likewise.
4148 * intervals.c (check_for_interval, search_for_interval)
4149 (inc_interval_count, count_intervals, root_interval)
4150 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4151 * lread.c (defalias): Likewise.
4152 * ralloc.c (r_alloc_check): Likewise.
4153 * regex.c (set_image_of_range_1, set_image_of_range)
4154 (regex_grow_registers): Likewise.
4155 * sysdep.c (strerror): Likewise.
4156 * termcap.c (valid_filename_p, tprint, main): Likewise.
4157 * tparam.c (main): Likewise.
4158 * unexhp9k800.c (run_time_remap, save_data_space)
4159 (update_file_ptrs, read_header, write_header, calculate_checksum)
4160 (copy_file, copy_rest, display_header): Likewise.
4161 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4163 * xdisp.c (check_it): Likewise.
4164 * xfaces.c (register_color, unregister_color, unregister_colors):
4166 * xfns.c (print_fontset_result): Likewise.
4167 * xrdb.c (member, fatal, main): Likewise.
4169 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4171 Fix minor problems found by static checking (Bug#9031).
4172 * chartab.c (char_table_set_range, map_sub_char_table):
4173 Remove unused locals.
4174 (uniprop_table): Now static.
4175 * composite.c (_work_char): Remove unused static var.
4177 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4179 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4181 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4183 * gtkutil.c (qttip_cb): Remove code without function.
4185 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4187 * w32.c (pthread_sigmask): New stub.
4189 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4191 Use pthread_sigmask, not sigprocmask (Bug#9010).
4192 sigprocmask is portable only for single-threaded applications, and
4193 Emacs can be multi-threaded when it uses GTK.
4194 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4196 * callproc.c (Fcall_process):
4197 * process.c (create_process):
4198 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4199 Use pthread_sigmask, not sigprocmask.
4201 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4203 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4204 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4207 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4209 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4210 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4211 (xg_hide_tooltip): Fix comment.
4213 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4214 in registerServicesMenuSendTypes.
4215 (validRequestorForSendType): Don't check ns_return_types.
4217 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4220 2011-07-08 Jason Rumney <jasonr@gnu.org>
4222 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4223 SH_SHOW for hidden windows (Bug#5482).
4225 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4226 frame struct members of non-existent frames (Bug#6284).
4228 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4230 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4231 variable firstTime not needed on OSX >= 10.6.
4232 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4233 >= 10.5. Use setKnobProportion, setDoubleValue.
4235 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4236 (MAC_OS_X_VERSION_10_5): Define if not defined.
4237 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4238 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4239 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4241 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4242 cString and lossyCString on OSX >= 10.4
4244 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4245 sizeToFit on OSX >= 10.2.
4247 * nsimage.m (allocInitFromFile): Don't use deprecated method
4248 bestRepresentationForDevice on OSX >= 10.6.
4250 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4253 * emacs.c: Declare unexec_init_emacs_zone.
4255 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4257 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4259 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4260 on svcsMenu (Bug#8842).
4262 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4264 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4266 * nsterm.m (QUTF8_STRING): Declare.
4267 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4268 (validRequestorForSendType): Return type is (id).
4269 Change indexOfObjectIdenticalTo to indexOfObject.
4270 Check if we have local selection before returning self (Bug#8842).
4271 (writeSelectionToPasteboard): Put local selection into paste board
4272 if we have a local selection (Bug#8842).
4273 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4275 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4276 (ns_get_local_selection): Declare.
4278 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4280 * keymap.c (describe_map_tree): Don't insert a double newline at
4281 the end of the buffer (bug#1169) and return whether we inserted
4284 * callint.c (Fcall_interactively): Change "reading args" to
4285 "providing args" to try to clarify what it does (bug#1010).
4287 2011-07-07 Kenichi Handa <handa@m17n.org>
4289 * composite.c (composition_compute_stop_pos): Ignore a static
4290 composition starting before CHARPOS (Bug#8915).
4292 * xdisp.c (handle_composition_prop): Likewise.
4294 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4296 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4299 2011-07-07 Kenichi Handa <handa@m17n.org>
4301 * character.h (unicode_category_t): New enum type.
4303 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4304 (Qchar_code_property_table): New variable.
4305 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4306 (UNIPROP_COMPRESSED_FORM_P): New macros.
4307 (char_table_ascii): Uncompress the compressed values.
4308 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4309 Uncompress the compressed values.
4310 (sub_char_table_ref_and_range): Likewise.
4311 (char_table_ref_and_range): Uncompress the compressed values.
4312 (sub_char_table_set): New arg is_uniprop. Callers changed.
4313 Uncompress the compressed values.
4314 (sub_char_table_set_range): Args changed. Callers changed.
4315 (char_table_set_range): Adjuted for the above change.
4316 (map_sub_char_table): Delete args default_val and parent. Add arg
4317 top. Give decoded values to a Lisp function.
4318 (map_char_table): Adjust for the above change. Give decoded
4319 values to a Lisp function. Gcpro more variables.
4320 (uniprop_table_uncompress)
4321 (uniprop_decode_value_run_length): New functions.
4322 (uniprop_decoder, uniprop_decoder_count): New variables.
4323 (uniprop_get_decoder, uniprop_encode_value_character)
4324 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4326 (uniprop_encoder, uniprop_encoder_count): New variables.
4327 (uniprop_get_encoder, uniprop_table)
4328 (Funicode_property_table_internal, Fget_unicode_property_internal)
4329 (Fput_unicode_property_internal): New functions.
4330 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4331 Sunicode_property_table_internal, Sget_unicode_property_internal,
4332 and Sput_unicode_property_internal. Defvar_lisp
4333 char-code-property-alist.
4335 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4336 Vunicode_category_table.
4338 * font.c (font_range): Adjust for the change of
4339 Vunicode_category_table.
4341 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4343 * m/iris4d.h: Remove file, move contents ...
4344 * s/irix6-5.h: ... here.
4346 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4348 Remove unportable assumption about struct layout (Bug#8884).
4349 * alloc.c (mark_buffer):
4350 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4351 (clone_per_buffer_values): Don't assume that
4352 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4353 This isn't true in general, and it's particularly not true
4354 if Emacs is configured with --with-wide-int.
4355 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4356 New macros, used in the buffer.c change.
4358 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4360 * xsettings.c: Use both GConf and GSettings if both are available.
4361 (store_config_changed_event): Add comment.
4362 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4363 (store_tool_bar_style_changed): New functions.
4364 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4365 (struct xsettings): Move font inside HAVE_XFT.
4366 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4367 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4368 Move inside HAVE_XFT.
4369 (something_changed_gsettingsCB): Rename from something_changedCB.
4370 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4372 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4373 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4374 (something_changed_gconfCB): Rename from something_changedCB.
4375 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4376 (parse_settings): Move check for font inside HAVE_XFT.
4377 (read_settings, apply_xft_settings): Add comment.
4378 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4379 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4380 call store_font_name_changed.
4381 (xft_settings_event): Add comment.
4382 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4383 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4384 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4385 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4386 (xsettings_initialize): Call init_gsettings last.
4387 (xsettings_get_system_font, xsettings_get_system_normal_font):
4390 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4392 Random fixes. E.g., (random) never returned negative values.
4393 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4394 subseconds part to the entropy, as that's a bit more random.
4395 Prefer signed to unsigned, since the signedness doesn't matter and
4396 in general we prefer signed. When given a limit, use a
4397 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4398 latter isn't right if USE_2_TAGS_FOR_INTS.
4399 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4400 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4402 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4404 * textprop.c (text_property_stickiness):
4405 Obey Vtext_property_default_nonsticky.
4406 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4407 * w32fns.c (syms_of_w32fns):
4408 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4410 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4412 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4413 This is more efficient than Ffile_directory_p and avoids a minor race.
4415 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4417 * buffer.c (Foverlay_put): Say what the return value is
4420 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4421 is a directory before asking whether to use the file name
4423 (barf_or_query_if_file_exists): Make the "File is a directory"
4424 error be more correct.
4426 * fns.c (Frequire): Remove the mention of the .gz files, since
4427 that's installation-specific, but keep the mention of
4428 `get-load-suffixes'.
4430 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4432 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4433 Report string overflow if the output is too long.
4435 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4437 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4438 (syms_of_gnutls): Remove duplicate DEFSYM for
4439 Qgnutls_bootprop_verify_hostname_error, an error for
4440 Qgnutls_bootprop_verify_error (which is no longer used).
4442 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4443 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4444 Also (re)move comments that are misplaced or no longer relevant.
4446 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4448 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4450 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4452 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4453 and background color parameters if they have been changed.
4455 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4459 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4461 * xsettings.c (SYSTEM_FONT): Define only when used.
4462 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4464 * keymap.c (access_keymap_1): Now static.
4466 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4468 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4469 leave any prefix arg for the up event (Bug#1586).
4471 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473 * lread.c (syms_of_lread): Mention single symbols defined by
4474 `defvar' or `defconst' (bug#7154).
4476 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4477 (Frequire): Mention get-load-suffixes.
4479 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4481 * window.h (window): Remove clone_number slot.
4482 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4484 (make_parent_window, make_window, saved_window)
4485 (Fset_window_configuration, save_window_save): Don't deal with
4487 * buffer.c (Qclone_number): Remove declaration.
4488 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4490 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4492 Add multiple inheritance to keymaps.
4493 * keymap.c (Fmake_composed_keymap): New function.
4494 (Fset_keymap_parent): Simplify.
4495 (fix_submap_inheritance): Remove.
4496 (access_keymap_1): New function extracted from access_keymap to handle
4497 embedded parents and handle lists of maps.
4498 (access_keymap): Use it.
4499 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4500 (Fcopy_keymap): Handle embedded parents.
4501 (Fcommand_remapping, define_as_prefix): Simplify.
4502 (Fkey_binding): Simplify.
4503 (syms_of_keymap): Move minibuffer-local-completion-map,
4504 minibuffer-local-filename-completion-map,
4505 minibuffer-local-must-match-map, and
4506 minibuffer-local-filename-must-match-map to Elisp.
4507 (syms_of_keymap): Defsubr make-composed-keymap.
4508 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4509 (parse_menu_item): Trivial simplification.
4511 2011-07-01 Glenn Morris <rgm@gnu.org>
4513 * Makefile.in (SETTINGS_LIBS): Fix typo.
4515 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4517 * coding.c (Fencode_coding_string): Record the last coding system
4518 used, as the function doc string says (bug#8738).
4520 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4522 * xsettings.c (store_monospaced_changed): Take new font as arg and
4523 check for change against current_mono_font.
4524 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4525 (emacs_settings_constructor, emacs_settings_get_property)
4526 (emacs_settings_set_property, emacs_settings_class_init)
4527 (emacs_settings_init, gsettings_obj): Remove.
4528 (something_changedCB): New function for HAVE_GSETTINGS.
4529 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4530 with value as argument.
4531 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4532 g_settings_new (Bug#8967). Do not create gsettings_obj.
4533 Remove calls to g_settings_bind. Connect something_changedCB to
4536 * xgselect.c: Add defined (HAVE_GSETTINGS).
4537 (xgselect_initialize): Ditto.
4539 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4540 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4543 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4545 * eval.c (struct backtrace): Simplify and port the data structure.
4546 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4547 signed bit field, as this assumption is not portable and it makes
4548 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4549 "char debug_on_exit : 1" as this is not portable either; instead,
4550 use the portable "unsigned int debug_on_exit : 1". Remove unused
4551 member evalargs. Remove obsolete comments about cc bombing out.
4553 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4555 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4556 Let HAVE_GSETTINGS override HAVE_GCONF.
4557 (store_monospaced_changed): New function.
4558 (EMACS_SETTINGS): A new type derived from GObject to handle
4559 GSettings notifications.
4560 (emacs_settings_constructor, emacs_settings_get_property)
4561 (emacs_settings_set_property, emacs_settings_class_init):
4563 (gsettings_client, gsettings_obj): New variables.
4564 (GSETTINGS_SCHEMA): New define.
4565 (something_changedCB): Call store_monospaced_changed.
4566 (init_gsettings): New function.
4567 (xsettings_initialize): Call init_gsettings.
4568 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4571 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4574 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4576 * window.c (resize_root_window, grow_mini_window)
4577 (shrink_mini_window): Rename Qresize_root_window to
4578 Qwindow_resize_root_window and Qresize_root_window_vertically to
4579 Qwindow_resize_root_window_vertically.
4581 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4583 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4585 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4587 * makefile.w32-in: Redesign dependencies so they reflect more
4588 clearly which files are directly included by each source file,
4589 and not through other includes.
4591 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4593 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4594 (sort_overlays, overlay_strings): When an overlay's clone number
4595 matches the window's clone number process the overlay even if
4596 the overlay's window property doesn't match the current window.
4598 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4599 (Fwindow_hchild): Rename to Fwindow_left_child.
4600 (Fwindow_next): Rename to Fwindow_next_sibling.
4601 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4602 (resize_window_check): Rename to window_resize_check.
4603 (resize_window_apply): Rename to window_resize_apply.
4604 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4605 (Fdelete_other_windows_internal, resize_frame_windows)
4606 (Fsplit_window_internal, Fdelete_window_internal)
4607 (grow_mini_window, shrink_mini_window)
4608 (Fresize_mini_window_internal): Fix callers accordingly.
4610 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4612 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4613 (emacs_fixed_set_min_size): Remove.
4614 (emacs_fixed_new): Take frame as argument.
4616 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4617 (_EmacsFixedPrivate): Remove minwidth/height.
4618 Add struct frame *f.
4619 (emacs_fixed_init): Initialize priv->f.
4620 (get_parent_class, emacs_fixed_set_min_size): Remove.
4621 (emacs_fixed_new): Set priv->f to argument.
4622 (emacs_fixed_get_preferred_width)
4623 (emacs_fixed_get_preferred_height): Use min_width/height from
4624 frames size_hint to set minimum and natural (Bug#8919).
4625 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4626 and use min_width/height from frames size_hint to set
4627 min_width/height (Bug#8919).
4629 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4630 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4633 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4635 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4636 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4639 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4641 * process.c (wait_reading_process_output): Bypass select if
4642 waiting for a cell while ignoring keyboard input, and input is
4643 pending. Suggested by Jan Djärv (Bug#8869).
4645 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4647 Use gnulib's dup2 module instead of rolling our own.
4648 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4650 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4652 * dispnew.c (scrolling_window): Before scrolling, turn off a
4653 mouse-highlight in the window being scrolled.
4655 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4657 Move DEFSYM to lisp.h and use everywhere.
4659 * character.h (DEFSYM): Move declaration...
4660 * lisp.h (DEFSYM): ...here.
4666 * w32select.c: Don't include character.h.
4668 * alloc.c (syms_of_alloc):
4669 * buffer.c (syms_of_buffer):
4670 * bytecode.c (syms_of_bytecode):
4671 * callint.c (syms_of_callint):
4672 * casefiddle.c (syms_of_casefiddle):
4673 * casetab.c (init_casetab_once):
4674 * category.c (init_category_once, syms_of_category):
4675 * ccl.c (syms_of_ccl):
4676 * cmds.c (syms_of_cmds):
4677 * composite.c (syms_of_composite):
4678 * dbusbind.c (syms_of_dbusbind):
4679 * dired.c (syms_of_dired):
4680 * dispnew.c (syms_of_display):
4681 * doc.c (syms_of_doc):
4682 * editfns.c (syms_of_editfns):
4683 * emacs.c (syms_of_emacs):
4684 * eval.c (syms_of_eval):
4685 * fileio.c (syms_of_fileio):
4686 * fns.c (syms_of_fns):
4687 * frame.c (syms_of_frame):
4688 * fringe.c (syms_of_fringe):
4689 * insdel.c (syms_of_insdel):
4690 * keymap.c (syms_of_keymap):
4691 * lread.c (init_obarray, syms_of_lread):
4692 * macros.c (syms_of_macros):
4693 * msdos.c (syms_of_msdos):
4694 * print.c (syms_of_print):
4695 * process.c (syms_of_process):
4696 * search.c (syms_of_search):
4697 * sound.c (syms_of_sound):
4698 * syntax.c (init_syntax_once, syms_of_syntax):
4699 * terminal.c (syms_of_terminal):
4700 * textprop.c (syms_of_textprop):
4701 * undo.c (syms_of_undo):
4702 * w32.c (globals_of_w32):
4703 * window.c (syms_of_window):
4704 * xdisp.c (syms_of_xdisp):
4705 * xfaces.c (syms_of_xfaces):
4706 * xfns.c (syms_of_xfns):
4707 * xmenu.c (syms_of_xmenu):
4708 * xsettings.c (syms_of_xsettings):
4709 * xterm.c (syms_of_xterm): Use DEFSYM.
4711 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4713 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4715 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4717 Integer and buffer overflow fixes (Bug#8873).
4719 * print.c (printchar, strout): Check for string overflow.
4720 (PRINTPREPARE, printchar, strout):
4721 Don't set size unless allocation succeeds.
4723 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4724 for sizes. Check for string overflow more accurately.
4725 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4727 * macros.c: Integer and buffer overflow fixes.
4728 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4729 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4730 Use ptrdiff_t, not int, for sizes.
4731 Don't increment bufsize until after realloc succeeds.
4732 Check for size-calculation overflow.
4733 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4735 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4737 * lread.c: Integer overflow fixes.
4738 (read_integer): Radix is now EMACS_INT, not int,
4739 to improve quality of diagnostics for out-of-range radices.
4740 Calculate buffer size correctly for out-of-range radices.
4741 (read1): Check for integer overflow in radices, and in
4742 read-circle numbers.
4743 (read_escape): Avoid int overflow.
4744 (Fload, openp, read_buffer_size, read1)
4745 (substitute_object_recurse, read_vector, read_list, map_obarray):
4746 Use ptrdiff_t, not int, for sizes.
4747 (read1): Use EMACS_INT, not int, for sizes.
4748 Check for size overflow.
4750 * image.c (cache_image): Check for size arithmetic overflow.
4752 * lread.c: Integer overflow issues.
4753 (saved_doc_string_size, saved_doc_string_length)
4754 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4755 Now ptrdiff_t, not int.
4756 (read1): Don't assume doc string length fits in int. Check for
4757 out-of-range doc string lengths.
4758 (read_list): Don't assume file position fits in int.
4759 (read_escape): Check for hex character overflow.
4761 2011-06-22 Leo Liu <sdl.web@gmail.com>
4763 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4764 Move to minibuffer.el.
4766 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4768 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4769 The following patches are for when GLYPH_DEBUG && !XASSERT.
4770 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4771 * dispnew.c (flush_stdout):
4772 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4773 Mark as externally visible.
4774 * dispnew.c (check_window_matrix_pointers): Now static.
4775 * dispnew.c (window_to_frame_vpos):
4776 * xfns.c (unwind_create_frame):
4777 * xterm.c (x_check_font): Remove unused local.
4778 * scroll.c (CHECK_BOUNDS):
4779 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4780 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4781 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4782 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4783 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4785 (debug_method_add): Use va_list and vsprintf rather than relying
4786 on undefined behavior with wrong number of arguments.
4787 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4788 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4789 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4790 since we're not interested in debugging glyphs with old libraries.
4791 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4792 GCC 4.6.0's static checking.
4794 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4796 Integer overflow and signedness fixes (Bug#8873).
4797 A few related buffer overrun fixes, too.
4799 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4801 * dispextern.h (struct face.stipple):
4802 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4803 (x_bitmap_mask, x_allocate_bitmap_record)
4804 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4805 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4806 (x_create_bitmap_from_xpm_data):
4807 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4808 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4810 * xfaces.c (load_pixmap):
4811 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4812 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4813 (.bitmaps_last, struct x_output.icon_bitmap):
4814 Use ptrdiff_t, not int, for bitmap indexes.
4815 (x_allocate_bitmap_record): Check for size overflow.
4816 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4818 Use ptrdiff_t, not int, for overlay counts.
4819 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4820 * editfns.c (overlays_around, get_pos_property):
4821 * textprop.c (get_char_property_and_overlay):
4822 * xdisp.c (next_overlay_change, note_mouse_highlight):
4823 * xfaces.c (face_at_buffer_position):
4824 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4825 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4826 (Fnext_overlay_change, Fprevious_overlay_change)
4827 (mouse_face_overlay_overlaps, Foverlays_in):
4828 Use ptrdiff_t, not int, for sizes.
4829 (overlays_at, overlays_in): Check for size-calculation overflow.
4831 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4833 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4834 (x_session_initialize): Do not assume string length fits in int.
4836 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4837 This is unlikely, but can occur if DPI is outlandish.
4839 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4840 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4842 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4843 * xrdb.c (magic_file_p, search_magic_path):
4844 Omit last arg SUFFIX; it was always 0. All callers changed.
4845 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4847 * xfont.c (xfont_match): Avoid need for strlen.
4849 * xfns.c: Don't assume strlen fits in int.
4850 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4852 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4853 not unsigned long, as we prefer signed integers. All callers changed.
4854 Detect integer overflow in repeat count.
4855 (message_dolog): Don't assume print length fits in 39 bytes.
4856 (display_mode_element): Don't assume strlen fits in int.
4858 * termcap.c: Don't assume sizes fit in int and never overflow.
4859 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4860 (gobble_line): Check for size-calculation overflow.
4862 * minibuf.c (Fread_buffer):
4863 * lread.c (intern, intern_c_string):
4864 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4865 Don't assume string length fits in int.
4867 * keyboard.c (parse_tool_bar_item):
4868 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4870 * font.c: Don't assume string length fits in int.
4871 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4872 Use ptrdiff_t, not int.
4873 (font_intern_prop): Don't assume string length fits in int.
4874 Don't assume integer property fits in fixnum.
4875 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4877 * filelock.c: Fix some buffer overrun and integer overflow issues.
4878 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4879 Reformulate so as not to need the command string.
4880 Invoke gzip -cd rather than gunzip, as it's more portable.
4881 (lock_info_type, lock_file_1, lock_file):
4882 Don't assume pid_t and time_t fit in unsigned long.
4883 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4884 (current_lock_owner): Prefer signed type for sizes.
4885 Use memcpy, not strncpy, where memcpy is what is really wanted.
4886 Don't assume (via atoi) that time_t and pid_t fit in int.
4887 Check for time_t and/or pid_t out of range, e.g., via a network share.
4888 Don't alloca where an auto var works fine.
4890 * fileio.c: Fix some integer overflow issues.
4891 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4892 Don't assume string length fits in int.
4893 (directory_file_name): Don't assume string length fits in long.
4894 (make_temp_name): Don't assume pid fits in int, or that its print
4895 length is less than 20.
4897 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4899 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4901 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4903 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4904 We prefer signed integers, even for size calculations.
4906 * emacs.c: Don't assume string length fits in 'int'.
4907 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4908 (main): Don't invoke strlen when not needed.
4910 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4911 (XD_DEBUG_MESSAGE): Don't waste a byte.
4913 * callproc.c (getenv_internal_1, getenv_internal)
4915 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4917 * lread.c (invalid_syntax): Omit length argument.
4918 All uses changed. This doesn't fix a bug, but it simplifies the
4919 code away from its former Hollerith-constant appearance, and it's
4920 one less 'int' to worry about when looking at integer-overflow issues.
4921 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4923 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4924 This didn't break anything, but it didn't help either.
4925 It's confusing to put a bogus integer in a place where the actual
4926 value does not matter.
4927 (LIST_END_P): Remove unused macro and its bogus comment.
4928 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4930 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4931 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4933 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4934 We prefer signed types, and the value cannot exceed the EMACS_INT
4935 range anyway (because otherwise the length would not be representable).
4936 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4937 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4938 This avoids a GCC warning when WIDE_EMACS_INT.
4940 * indent.c (sane_tab_width): New function.
4941 (current_column, scan_for_column, Findent_to, position_indentation)
4942 (compute_motion): Use it. This is just for clarity.
4943 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4945 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4947 * lisp.h (lint_assume): New macro.
4948 * composite.c (composition_gstring_put_cache):
4949 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4951 * editfns.c, insdel.c:
4952 Omit unnecessary forward decls, to simplify future changes.
4954 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4956 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4958 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4959 Use much-faster test for byte-length change.
4960 Don't assume string byte-length fits in 'int'.
4961 Check that character arg fits in 'int'.
4962 (mapcar1): Declare byte as byte, for clarity.
4964 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4966 * fns.c (concat): Catch string overflow earlier.
4967 Do not rely on integer wraparound.
4969 * dispextern.h (struct it.overlay_strings_charpos)
4970 (struct it.selective): Now EMACS_INT, not int.
4971 * xdisp.c (forward_to_next_line_start)
4972 (back_to_previous_visible_line_start)
4973 (reseat_at_next_visible_line_start, next_element_from_buffer):
4974 Don't arbitrarily truncate the value of 'selective' to int.
4976 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4978 * composite.c: Don't truncate sizes to 'int'.
4979 (composition_gstring_p, composition_reseat_it)
4980 (composition_adjust_point): Use EMACS_INT, not int.
4981 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4982 not EMACS_UINT, for indexes.
4984 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4986 * buffer.c: Include <verify.h>.
4987 (struct sortvec.priority, struct sortstr.priority):
4988 Now EMACS_INT, not int.
4989 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4990 (struct sortstr.size, record_overlay_string)
4991 (struct sortstrlist.size, struct sortlist.used):
4992 Don't truncate size to int.
4993 (record_overlay_string): Check for size-calculation overflow.
4994 (init_buffer_once): Check at compile-time, not run-time.
4996 2011-06-22 Jim Meyering <meyering@redhat.com>
4998 Don't leak an XBM-image-sized buffer
4999 * image.c (xbm_load): Free the image buffer after using it.
5001 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5004 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5005 that Sun C diagnosed.
5006 * fns.c (secure_hash): Fix pointer signedness issue.
5007 * intervals.c (static_offset_intervals): New function.
5008 (offset_intervals): Use it.
5010 2011-06-21 Leo Liu <sdl.web@gmail.com>
5013 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5016 * fns.c (secure_hash): Rename from crypto_hash_function and change
5017 the first arg to accept symbols.
5018 (Fsecure_hash): New primitive.
5019 (syms_of_fns): New symbols.
5021 2011-06-20 Deniz Dogan <deniz@dogan.se>
5023 * process.c (Fset_process_buffer): Clarify return value in
5026 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5028 * dispnew.c (add_window_display_history): Use BVAR.
5030 * xdisp.c (debug_method_add): Use BVAR.
5031 (check_window_end, dump_glyph_matrix, dump_glyph)
5032 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5034 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5037 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5038 check till after the cache is created in init_frame_faces.
5040 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5042 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5044 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5046 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5047 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5048 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5050 Improve buffer-overflow checking (Bug#8873).
5051 * fileio.c (Finsert_file_contents):
5052 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5053 Remove the old (too-loose) buffer overflow checks.
5054 They weren't needed, since make_gap checks for buffer overflow.
5055 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5056 The old code merely checked for Emacs fixnum overflow, and relied
5057 on undefined (wraparound) behavior. The new code avoids undefined
5058 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5060 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5061 Tune. Don't use wider integers than needed. Don't use alloca.
5062 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5064 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5066 * insdel.c, lisp.h (buffer_overflow): New function.
5067 (insert_from_buffer_1, replace_range, replace_range_2):
5068 * insdel.c (make_gap_larger):
5069 * editfns.c (Finsert_char):
5070 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5072 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5074 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5076 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5078 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5079 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5081 * fileio.c: Don't assume EMACS_INT fits in off_t.
5082 (emacs_lseek): New static function.
5083 (Finsert_file_contents, Fwrite_region): Use it.
5084 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5086 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5088 * fns.c: Don't overflow int when computing a list length.
5089 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5090 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5091 truncation on 64-bit hosts. Check for QUIT every
5092 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5093 faster and is responsive enough.
5094 (Flength): Report an error instead of overflowing an integer.
5095 (Fsafe_length): Return a float if the value is not representable
5096 as a fixnum. This shouldn't happen except in contrived situations.
5097 (Fnthcdr, Fsort): Don't assume list length fits in int.
5098 (Fcopy_sequence): Don't assume vector length fits in int.
5100 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5101 (header_size, word_size): New constants.
5102 (allocate_vectorlike): Don't check size overflow here.
5103 (allocate_vector): Check it here instead, since this is the only
5104 caller of allocate_vectorlike that could cause overflow.
5105 Check that the new vector's length is representable as a fixnum.
5107 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5108 The previous code was bogus. For example, next_almost_prime (32)
5109 returned 39, which is undesirable as it is a multiple of 3; and
5110 next_almost_prime (24) returned 25, which is a multiple of 5 so
5111 why was the code bothering to check for multiples of 7?
5113 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5115 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5117 Variadic C functions now count arguments with ptrdiff_t.
5118 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5119 Back then I didn't know that the Emacs coding style prefers signed int.
5120 Also, in the meantime I found a few more instances where arguments
5121 were being counted with int, which may truncate counts on 64-bit
5122 machines, or EMACS_INT, which may be unnecessarily wide.
5123 * lisp.h (struct Lisp_Subr.function.aMANY)
5124 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5125 Arg counts are now ptrdiff_t, not size_t.
5126 All variadic functions and their callers changed accordingly.
5127 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5128 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5129 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5130 * callint.c (Fcall_interactively): Check arg count for overflow,
5131 to avoid potential buffer overrun. Use signed char, not 'int',
5132 for 'varies' array, so that we needn't bother to check its size
5133 calculation for overflow.
5134 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5135 * eval.c (apply_lambda):
5136 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5137 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5138 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5140 * callint.c (Fcall_interactively): Don't use index var as event count.
5142 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5143 * mem-limits.h (SIZE): Remove; no longer used.
5145 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5147 Remove unnecessary casts.
5148 * xterm.c (x_term_init):
5149 * xfns.c (x_set_border_pixel):
5150 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5151 These aren't needed now that we assume ANSI C.
5153 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5154 It's more likely to cause problems (due to unsigned overflow)
5157 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5159 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5161 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5163 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5165 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5167 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5169 GLYPH_CODE_FACE returns EMACS_INT, not int.
5170 * dispextern.h (merge_faces):
5171 * xfaces.c (merge_faces):
5172 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5173 Don't assume EMACS_INT fits in int.
5175 * character.h (CHAR_VALID_P): Remove unused parameter.
5176 * fontset.c, lisp.h, xdisp.c: All uses changed.
5178 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5180 * fns.c (concat): Minor tuning based on overflow analysis.
5181 This doesn't fix any bugs. Use int to hold character, instead
5182 of constantly refetching from Emacs object. Use XFASTINT, not
5183 XINT, for value known to be a character. Don't bother comparing
5184 a single byte to 0400, as it's always less.
5186 * floatfns.c (Fexpt):
5187 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5189 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5192 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5194 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5195 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5196 incorrectly succeed when S was a string, because 4294967386 was
5197 truncated before it was used.
5199 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5200 Otherwise, an out-of-range integer could cause undefined behavior
5203 * composite.c: Use int, not EMACS_INT, for characters.
5204 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5205 EMACS_INT, for values that are known to be in character range.
5206 This doesn't fix any bugs but is the usual style inside Emacs and
5207 may generate better code on 32-bit machines.
5209 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5210 This is for reasons similar to the recent CHAR_STRING fix.
5211 * charset.c (Fencode_char): Check that character arg is actually
5212 a character. Pass an int to ENCODE_CHAR.
5213 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5214 wider than 'int', as a compile-time check to prevent future regressions
5217 * character.c (char_string): Remove unnecessary casts.
5219 Make sure a 64-bit char is never passed to CHAR_STRING.
5220 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5221 by silently ignoring the top 32 bits, allowing some values
5222 that were far too large to be valid characters.
5223 * character.h: Include <verify.h>.
5224 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5225 arguments are no wider than unsigned, as a compile-time check
5226 to prevent future regressions in this area.
5228 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5229 (Fsubst_char_in_region):
5231 * xdisp.c (decode_mode_spec_coding):
5232 Adjust to CHAR_STRING's new requirement.
5233 * editfns.c (Finsert_char, Fsubst_char_in_region):
5234 * fns.c (concat): Check that character args are actually
5235 characters. Without this test, these functions did the wrong
5236 thing with wildly out-of-range values on 64-bit hosts.
5238 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5239 These casts should not be needed on 32-bit hosts, either.
5240 * keyboard.c (read_char):
5241 * lread.c (Fload): Remove casts to unsigned.
5243 * lisp.h (UNSIGNED_CMP): New macro.
5244 This fixes comparison bugs on 64-bit hosts.
5245 (ASCII_CHAR_P): Use it.
5246 * casefiddle.c (casify_object):
5247 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5248 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5249 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5250 * dispextern.h (FACE_FROM_ID):
5251 * keyboard.c (read_char): Use UNSIGNED_CMP.
5253 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5254 not to EMACS_INT, to avoid GCC warning.
5256 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5258 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5259 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5260 isn't needed on 32-bit machines.
5262 * buffer.c (Fgenerate_new_buffer_name):
5263 Use EMACS_INT for count, not int.
5264 (advance_to_char_boundary): Return EMACS_INT, not int.
5266 * data.c (Qcompiled_function): Now static.
5268 * window.c (window_body_lines): Now static.
5270 * image.c (gif_load): Rename local to avoid shadowing.
5272 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5273 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5274 * alloc.c (make_save_value): Integer argument is now of type
5276 (mark_object): Use ptrdiff_t, not int.
5277 * lisp.h (pD): New macro.
5278 * print.c (print_object): Use it.
5280 * alloc.c: Use EMACS_INT, not int, to count objects.
5281 (total_conses, total_markers, total_symbols, total_vector_size)
5282 (total_free_conses, total_free_markers, total_free_symbols)
5283 (total_free_floats, total_floats, total_free_intervals)
5284 (total_intervals, total_strings, total_free_strings):
5285 Now EMACS_INT, not int. All uses changed.
5286 (Fgarbage_collect): Compute overall total using a double, so that
5287 integer overflow is less likely to be a problem. Check for overflow
5288 when converting back to an integer.
5289 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5290 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5291 These were 'int' variables that could overflow on 64-bit hosts;
5292 they were never used, so remove them instead of repairing them.
5293 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5294 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5295 Previously, this ceilinged at INT_MAX, but that doesn't work on
5297 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5299 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5300 (allocate_vectorlike): Check for ptrdiff_t overflow.
5301 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5302 when a (possibly-narrower) signed value would do just as well.
5303 We prefer using signed arithmetic, to avoid comparison confusion.
5305 * alloc.c: Catch some string size overflows that we were missing.
5306 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5307 for convenience in STRING_BYTES_MAX.
5308 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5309 The definition here is exact; the one in lisp.h was approximate.
5310 (allocate_string_data): Check for string overflow. This catches
5311 some instances we weren't catching before. Also, it catches
5312 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5313 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5314 and ptrdiff_t and EMACS_INT are both 64 bits.
5316 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5317 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5318 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5320 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5322 * alloc.c (Fmake_string): Check for out-of-range init.
5324 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5326 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5328 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5330 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5331 xg_get_default_scrollbar_width.
5333 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5334 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5335 (style_changed_cb): Call update_theme_scrollbar_width and call
5336 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5337 all frames (Bug#8505).
5338 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5339 Call gtk_window_set_resizable if HAVE_GTK3.
5340 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5341 and height if HAVE_GTK3 (Bug#8505).
5342 (scroll_bar_width_for_theme): New variable.
5343 (update_theme_scrollbar_width): New function.
5344 (xg_get_default_scrollbar_width): Move code to
5345 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5346 (xg_initialize): Call update_theme_scrollbar_width.
5348 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5350 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5352 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5354 * frame.c (make_frame): Call other_buffer_safely instead of
5357 * window.c (temp_output_buffer_show): Call display_buffer with
5358 second argument Vtemp_buffer_show_specifiers and reset latter
5359 immediately after the call.
5360 (Vtemp_buffer_show_specifiers): New variable.
5361 (auto_window_vscroll_p, next_screen_context_lines)
5362 (Vscroll_preserve_screen_position): Remove leading asterisks from
5365 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5367 Fix minor problems found by GCC 4.6.0 static checking.
5368 * buffer.c (Qclone_number): Remove for now, as it's unused.
5369 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5370 (record_buffer): Remove unused local.
5371 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5372 (set_frame_buffer_list): Remove; unused.
5373 * frame.h (other_visible_frames): Remove decl.
5374 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5375 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5376 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5378 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5379 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5380 Define only if HAVE_GPM.
5381 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5382 (update_hints_inhibit): Remove; never set. All uses removed.
5383 * widgetprv.h (emacsFrameClassRec): Remove decl.
5384 * window.c (delete_deletable_window): Now returns void, since it
5385 wasn't returning anything.
5386 (compare_window_configurations): Remove unused locals.
5387 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5388 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5389 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5390 the same widths as pointers. This follows up on the 2011-05-06 patch.
5391 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5392 * xterm.h: Likewise.
5393 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5395 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5397 * makefile.w32-in: Update dependencies.
5398 (LISP_H): Add lib/intprops.h.
5400 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5402 * image.c (gif_load): Add animation frame delay to the metadata.
5403 (syms_of_image): Use DEFSYM. New symbol `delay'.
5405 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5407 * window.c (delete_deletable_window): Re-add.
5408 (Fset_window_configuration): Rewrite to handle dead buffers and
5409 consequently deletable windows.
5410 (window_tree, Fwindow_tree): Remove. Supply functionality in
5412 (compare_window_configurations): Simplify code.
5414 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5416 * image.c (imagemagick_load_image): Fix type mismatch.
5417 (Fimagemagick_types): Likewise.
5419 * window.h (replace_buffer_in_windows): Declare.
5421 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5423 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5424 Qclone_number. Remove external declaration of Qdelete_window.
5425 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5427 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5428 Run Qbuffer_list_update_hook if allowed.
5429 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5430 buffer list implementation.
5431 (other_buffer_safely): New function.
5432 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5433 calls to replace_buffer_in_windows and
5434 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5436 (record_buffer): Inhibit quitting and rewrite using quittable
5437 functions. Run Qbuffer_list_update_hook if allowed.
5438 (Frecord_buffer, Funrecord_buffer): New functions.
5439 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5440 Move switch-to-buffer to window.el.
5441 (bury-buffer): Move to window.el.
5442 (Vbuffer_list_update_hook): New variable.
5444 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5447 * window.h (resize_frame_windows): Move up in code.
5448 (Fwindow_frame): Remove EXFUN.
5449 (replace_buffer_in_all_windows): Remove prototype.
5450 (replace_buffer_in_windows_safely): Add prototype.
5452 * window.c: Declare Qdelete_window static again. Move down
5453 declaration of select_count.
5454 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5455 (Fother_window): Move to window.el.
5456 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5457 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5458 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5460 (replace_buffer_in_windows): Implement by calling
5461 Qreplace_buffer_in_windows.
5462 (replace_buffer_in_all_windows): Remove with some functionality
5463 moved into replace_buffer_in_windows_safely.
5464 (replace_buffer_in_windows_safely): New function.
5465 (select_window_norecord, select_frame_norecord): Move in front
5466 of run_window_configuration_change_hook. Remove now obsolete
5468 (Fset_window_buffer): Rewrite doc-string.
5469 Call Qrecord_window_buffer.
5470 (keys_of_window): Move binding for other-window to window.el.
5472 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5474 * dispextern.h (struct image): Replace data member, whose int_val
5475 and ptr_val fields were not used by anything, with a single
5478 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5479 (gif_clear_image, gif_load, imagemagick_load_image)
5480 (gs_clear_image, gs_load): Callers changed.
5482 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5484 * buffer.h: Include <time.h>, for time_t.
5485 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5487 Fix minor problems found by static checking.
5489 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5491 Make identifiers static if they are not used in other modules.
5492 * data.c (Qcompiled_function, Qframe, Qvector):
5493 * image.c (QimageMagick, Qsvg):
5494 * minibuf.c (Qmetadata):
5495 * window.c (resize_window_check, resize_root_window): Now static.
5496 * window.h (resize_window_check, resize_root_window): Remove decls.
5498 * window.c (window_deletion_count, delete_deletable_window):
5500 (window_body_lines): Now static.
5501 (Fdelete_other_windows_internal): Mark vars as initialized.
5502 Make sure 'resize_failed' is initialized.
5503 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5504 (resize_window_apply): Remove unused local.
5505 * window.h (delete_deletable_window): Remove decl.
5507 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5508 (imagemagick_load_image): Fix pointer signedness problem by changing
5509 last arg from unsigned char * to char *. All uses changed.
5510 Also, fix a local for similar reasons.
5511 Remove unused locals. Remove locals to avoid shadowing.
5512 (fn_rsvg_handle_free): Remove; unused.
5513 (svg_load, svg_load_image): Fix pointer signedness problem.
5514 (imagemagick_load_image): Don't use garbage pointer image_wand.
5516 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5518 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5520 * image.c (gif_load): Fix omitted cast error introduced by
5523 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5525 * window.h (resize_proportionally, orig_total_lines)
5526 (orig_top_line): Remove from window structure.
5527 (set_window_height, set_window_width, change_window_heights)
5528 (Fdelete_window): Remove prototypes.
5529 (resize_frame_windows): Remove duplicate declaration.
5531 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5533 * window.h (resize_frame_windows, resize_window_check)
5534 (delete_deletable_window, resize_root_window)
5535 (resize_frame_windows): Declare prototypes.
5537 * window.c (resize_window_apply): Make definition be "static" to
5538 match the prototype.
5540 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5542 * window.c: Remove declarations of Qwindow_size_fixed,
5543 window_min_size_1, window_min_size_2, window_min_size,
5544 size_window, window_fixed_size_p, enlarge_window, delete_window.
5545 Remove static from declaration of Qdelete_window, it's
5546 temporarily needed by Fbury_buffer.
5547 (replace_window): Don't assign orig_top_line and
5549 (Fdelete_window, delete_window): Remove. Window deletion is
5550 handled by window.el.
5551 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5552 Replace Fdelete_window calls with calls to Qdelete_window.
5553 (Fdelete_other_windows): Remove. Deleting other windows is
5554 handled by window.el.
5555 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5556 handled in window.el.
5557 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5558 Window minimum sizes are handled in window.el.
5559 (shrink_windows, size_window, set_window_height)
5560 (set_window_width, change_window_heights, window_height)
5561 (window_width, CURBEG, CURSIZE, enlarge_window)
5562 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5563 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5564 handled in window.el.
5565 (make_dummy_parent): Rename to make_parent_window and give it a
5566 second argument horflag.
5567 (make_window): Don't set resize_proportionally any more.
5568 (Fsplit_window): Remove. Windows are split in window.el.
5569 (save_restore_action, save_restore_orig_size)
5570 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5571 Resize mini windows in window.el.
5572 (grow_mini_window, shrink_mini_window): Implement by calling
5573 Qresize_root_window_vertically, resize_window_check and
5574 resize_window_apply.
5575 (saved_window, Fset_window_configuration, save_window_save):
5576 Do not handle orig_top_line, orig_total_lines, and
5577 resize_proportionally.
5578 (window_min_height, window_min_width): Move to window.el.
5579 (keys_of_window): Move bindings for delete-other-windows,
5580 split-window, delete-window and enlarge-window to window.el.
5582 * buffer.c: Temporarily extern Qdelete_window.
5583 (Fbury_buffer): Temporarily call Qdelete_window instead of
5584 Fdelete_window (Fbury_buffer will move to window.el soon).
5586 * frame.c (set_menu_bar_lines_1): Remove code handling
5587 orig_top_line and orig_total_lines.
5589 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5590 set_window_height but set heights directly.
5591 (change_frame_size_1): Use resize_frame_windows.
5593 * xdisp.c (init_xdisp): Don't use set_window_height but set
5596 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5597 Use resize_frame_windows instead of change_window_heights and run
5598 run_window_configuration_change_hook.
5600 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5601 instead of change_window_heights and run
5602 run_window_configuration_change_hook.
5604 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5606 * window.c (replace_window): Rename second argument REPLACEMENT to
5607 NEW. New third argument SETFLAG. Rewrite.
5608 (delete_window, make_dummy_parent): Call replace_window with
5610 (window_list_1): Move down in code.
5611 (run_window_configuration_change_hook): Move set_buffer part
5612 before select_frame_norecord part in order to unwind correctly.
5613 Rename count1 to count.
5614 (recombine_windows, delete_deletable_window, resize_root_window)
5615 (Fdelete_other_windows_internal)
5616 (Frun_window_configuration_change_hook, make_parent_window)
5617 (resize_window_check, resize_window_apply, Fresize_window_apply)
5618 (resize_frame_windows, Fsplit_window_internal)
5619 (Fdelete_window_internal, Fresize_mini_window_internal):
5621 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5623 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5625 * window.h (window): Add some new members to window structure -
5626 normal_lines, normal_cols, new_total, new_normal, clone_number,
5627 splits, nest, prev_buffers, next_buffers.
5628 (WINDOW_TOTAL_SIZE): Move here from window.c.
5629 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5631 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5633 (make_dummy_parent): Set new members of windows structure.
5634 (make_window): Move down in code. Handle new members of window
5636 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5637 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5638 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5639 (Fset_window_prev_buffers, Fwindow_next_buffers)
5640 (Fset_window_next_buffers, Fset_window_clone_number):
5642 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5643 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5645 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5646 Argument WINDOW can be now internal window too.
5647 (Fwindow_use_time): Move up in code.
5648 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5650 (Fset_window_configuration, saved_window)
5651 (Fcurrent_window_configuration, save_window_save): Handle new
5652 members of window structure.
5653 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5654 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5655 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5656 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5657 Qget_mru_window, Qresize_root_window,
5658 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5659 Qauto_buffer_name; staticpro them.
5661 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5663 * window.c (Fwindow_total_size, Fwindow_left_column)
5664 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5665 (Fwindow_list_1): New functions.
5666 (window_box_text_cols): Replace with window_body_cols.
5667 (Fwindow_width, Fscroll_left, Fscroll_right):
5668 Use window_body_cols instead of window_box_text_cols.
5669 (delete_window, Fset_window_configuration):
5670 Call delete_all_subwindows with window as argument.
5671 (delete_all_subwindows): Take a window as argument and not a
5673 (window_loop): Remove handling of GET_LRU_WINDOW and
5675 (Fget_lru_window, Fget_largest_window): Move to window.el.
5677 * window.h: Extern window_body_cols instead of
5678 window_box_text_cols. delete_all_subwindows now takes a
5679 Lisp_Object as argument.
5681 * indent.c (compute_motion, Fcompute_motion):
5682 Use window_body_cols instead of window_box_text_cols.
5684 * frame.c (delete_frame): Call delete_all_subwindows with root
5687 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5689 * fns.c (Fputhash): Document return value.
5691 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5693 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5695 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5697 Cons<->int and similar integer overflow fixes (Bug#8794).
5699 Check for overflow when converting integer to cons and back.
5700 * charset.c (Fdefine_charset_internal, Fdecode_char):
5701 Use cons_to_unsigned to catch overflow.
5702 (Fencode_char): Use INTEGER_TO_CONS.
5703 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5704 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5705 * data.c (long_to_cons, cons_to_long): Remove.
5706 (cons_to_unsigned, cons_to_signed): New functions.
5707 These signal an error for invalid or out-of-range values.
5708 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5709 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5710 * font.c (Ffont_variation_glyphs):
5711 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5712 * lisp.h: Include <intprops.h>.
5713 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5714 (cons_to_signed, cons_to_unsigned): New decls.
5715 (long_to_cons, cons_to_long): Remove decls.
5716 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5717 (Fprimitive_undo): Use CONS_TO_INTEGER.
5718 * xfns.c (Fx_window_property): Likewise.
5719 * xselect.c: Include <limits.h>.
5720 (x_own_selection, selection_data_to_lisp_data):
5721 Use INTEGER_TO_CONS.
5722 (x_handle_selection_request, x_handle_selection_clear)
5723 (x_get_foreign_selection, Fx_disown_selection_internal)
5724 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5725 (lisp_data_to_selection_data): Use cons_to_unsigned.
5726 (x_fill_property_data): Use cons_to_signed.
5727 Report values out of range.
5729 Check for buffer and string overflow more precisely.
5730 * buffer.h (BUF_BYTES_MAX): New macro.
5731 * lisp.h (STRING_BYTES_MAX): New macro.
5732 * alloc.c (Fmake_string):
5733 * character.c (string_escape_byte8):
5734 * coding.c (coding_alloc_by_realloc):
5735 * doprnt.c (doprnt):
5736 * editfns.c (Fformat):
5738 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5739 since they may not be the same number.
5740 * editfns.c (Finsert_char):
5741 * fileio.c (Finsert_file_contents):
5742 Likewise for BUF_BYTES_MAX.
5744 * image.c: Use ptrdiff_t, not int, for sizes.
5745 (slurp_file): Switch from int to ptrdiff_t.
5747 (slurp_file): Check that file size fits in both size_t (for
5748 malloc) and ptrdiff_t (for sanity and safety).
5750 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5751 if b->modtime has its maximal value.
5753 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5755 Don't assume time_t can fit into int.
5756 * buffer.h (struct buffer.modtime): Now time_t, not int.
5757 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5758 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5760 Minor fixes for signed vs unsigned integers.
5761 * character.h (MAYBE_UNIFY_CHAR):
5762 * charset.c (maybe_unify_char):
5763 * keyboard.c (read_char, reorder_modifiers):
5764 XINT -> XFASTINT, since the integer must be nonnegative.
5765 * ftfont.c (ftfont_spec_pattern):
5766 * keymap.c (access_keymap, silly_event_symbol_error):
5767 XUINT -> XFASTINT, since the integer must be nonnegative.
5768 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5769 since it makes no difference and we prefer signed.
5770 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5771 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5774 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5776 * window.h (Fwindow_frame): Declare.
5778 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5780 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5781 (SPARE_MEMORY): Always define.
5782 (LARGE_REQUEST): Remove.
5783 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5785 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5787 * lisp.h: Move EXFUNS for Fframe_root_window,
5788 Fframe_first_window and Fset_frame_selected_window to window.h.
5790 * window.h: Move EXFUNS for Fframe_root_window,
5791 Fframe_first_window and Fset_frame_selected_window here from
5794 * frame.c (Fwindow_frame, Fframe_first_window)
5795 (Fframe_root_window, Fframe_selected_window)
5796 (Fset_frame_selected_window): Move to window.c.
5797 (Factive_minibuffer_window): Move to minibuf.c.
5798 (Fother_visible_frames_p): New function.
5800 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5802 * window.c (decode_window, decode_any_window): Move up in code.
5803 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5804 (inhibit_frame_unsplittable): Remove unused variable.
5805 (Fwindow_buffer): Move up and rewrite doc-string.
5806 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5807 (Fwindow_prev): New functions.
5808 (Fwindow_frame): Move here from frame.c. Accept any window as
5810 (Fframe_root_window, Fframe_first_window)
5811 (Fframe_selected_window): Move here from frame.c. Accept frame
5812 or arbitrary window as argument. Update doc-strings.
5813 (Fminibuffer_window): Move up in code.
5814 (Fwindow_minibuffer_p): Move up in code and simplify.
5815 (Fset_frame_selected_window): Move here from frame.c.
5817 (Fselected_window, select_window, Fselect_window): Move up in
5818 code. Minor doc-string fixes.
5820 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5822 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5823 Do not assume that spare memory exists; that assumption is valid
5824 only if SYSTEM_MALLOC.
5825 (LARGE_REQUEST): New macro, so that the issue of large requests
5826 is separated from the issue of spare memory.
5828 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5830 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5833 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5835 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5838 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5840 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5842 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5844 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5845 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5847 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5849 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5851 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5853 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5854 (x_clipboard_manager_save): Add return value.
5855 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5857 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5858 Obey Vx_select_enable_clipboard_manager. Catch errors in
5859 x_clipboard_manager_save (Bug#8779).
5860 (Vx_select_enable_clipboard_manager): New variable.
5861 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5863 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5865 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5867 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5869 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5870 in the current matrix if keep_current_p is non-zero.
5872 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5874 * bidi.c (bidi_level_of_next_char): Fix last change.
5876 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5878 Support bidi reordering of text covered by display properties.
5880 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5881 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5882 (bidi_cache_search, bidi_cache_iterator_state)
5883 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5884 (bidi_level_of_next_char, bidi_move_to_visually_next):
5885 Support character positions inside a run of characters covered by a
5887 (bidi_paragraph_init, bidi_resolve_explicit_1)
5888 (bidi_level_of_next_char): Call bidi_fetch_char and
5889 bidi_fetch_char_advance instead of FETCH_CHAR and
5891 (bidi_init_it): Initialize new members.
5892 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5894 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5895 instead of using explicit *_CHAR codes.
5896 (bidi_resolve_explicit, bidi_resolve_weak):
5897 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5898 bidirectional text is supported only in multibyte buffers.
5899 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5900 it to initialize the frame_window_p member of struct bidi_it.
5901 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5902 (bidi_resolve_explicit, bidi_resolve_weak)
5903 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5904 bidi_it->nchars is non-positive.
5905 (bidi_level_of_next_char): Don't try to lookup the cache for the
5906 next/previous character if nothing is cached there yet, or if we
5907 were just reseat()'ed to a new position.
5909 * xdisp.c (set_cursor_from_row): Set start and stop points
5910 according to the row's direction when priming the loop that looks
5911 for the glyph on which to display cursor.
5912 (single_display_spec_intangible_p): Function deleted.
5913 (display_prop_intangible_p): Reimplement to call
5914 handle_display_spec instead of single_display_spec_intangible_p.
5915 Accept 3 additional arguments needed by handle_display_spec.
5916 This fixes incorrect cursor motion across display property with complex
5917 values: lists, `(when COND...)' forms, etc.
5918 (single_display_spec_string_p): Support property values that are
5919 lists with the argument STRING its top-level element.
5920 (display_prop_string_p): Fix the condition for processing a
5921 property that is a list to be consistent with handle_display_spec.
5922 (handle_display_spec): New function, refactored from the
5923 last portion of handle_display_prop.
5924 (compute_display_string_pos): Accept additional argument
5925 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5926 value of a `display' property is a "replacing spec".
5927 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5928 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5929 the display property, but just return a value indicating whether
5930 the display property will replace the characters it covers.
5931 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5932 frame_window_p members of struct bidi_it.
5933 (compute_display_string_pos, compute_display_string_end):
5935 (push_it): Accept second argument POSITION, where pop_it should
5936 jump to continue iteration.
5937 (reseat_1): Initialize bidi_it.disp_pos.
5939 * keyboard.c (adjust_point_for_property): Adjust the call to
5940 display_prop_intangible_p to its new signature.
5942 * dispextern.h (struct bidi_it): New member frame_window_p.
5943 (bidi_init_it): Update prototypes.
5944 (display_prop_intangible_p): Update prototype.
5945 (compute_display_string_pos, compute_display_string_end):
5947 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5950 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5952 Malloc failure behavior now depends on size of allocation.
5953 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5954 * lisp.h: Change signatures accordingly.
5955 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5956 All callers changed. (Bug#8762)
5958 * gnutls.c: Use Emacs's memory allocators.
5959 Without this change, the gnutls library would invoke malloc etc.
5960 directly, which causes problems on non-SYNC_INPUT hosts, and which
5961 runs afoul of improving memory_full behavior. (Bug#8761)
5962 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5963 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5964 xfree instead of the default malloc, realloc, free.
5965 (Fgnutls_boot): No need to check for memory allocation failure,
5966 since xmalloc does that for us.
5968 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5969 * category.c (hash_get_category_set):
5970 * ccl.c (ccl_driver):
5971 * charset.c (Fdefine_charset_internal):
5972 * charset.h (struct charset.hash_index):
5973 * composite.c (get_composition_id, gstring_lookup_cache)
5974 (composition_gstring_put_cache):
5975 * composite.h (struct composition.hash_index):
5976 * dispextern.h (struct image.hash):
5977 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5978 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5979 (hashfn_equal, hashfn_user_defined, make_hash_table)
5980 (maybe_resize_hash_table, hash_lookup, hash_put)
5981 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5982 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5983 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5984 * image.c (make_image, search_image_cache, lookup_image)
5985 (xpm_put_color_table_h):
5986 * lisp.h (struct Lisp_Hash_Table):
5987 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5988 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5989 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5990 * alloc.c (allocate_vectorlike):
5991 Check for overflow in vector size calculations.
5992 * ccl.c (ccl_driver):
5993 Check for overflow when converting EMACS_INT to int.
5994 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5995 need to be updated by these changes.
5996 * fns.c (make_hash_table, maybe_resize_hash_table):
5997 Check for integer overflow with large hash tables.
5998 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5999 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6000 (SXHASH_REDUCE): New macro.
6001 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6002 Use it instead of discarding useful hash info with large hash values.
6003 (sxhash_float): New function.
6004 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6005 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6006 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6007 Rewrite to use FIXNUM_BITS, as this simplifies things.
6008 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6009 Adjust signatures to match updated version of code.
6010 (consing_since_gc): Now EMACS_INT, since a single hash table can
6011 use more than INT_MAX bytes.
6013 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6015 Make it possible to build with GCC-4.6+ -O2 -flto.
6017 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6019 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6021 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6022 Call minibuffer-inactive-mode.
6024 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6026 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6027 Update dependencies.
6029 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6031 * data.c (init_data): Remove code for UTS, this system is not
6034 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6036 Don't force ./temacs to start in terminal mode.
6038 * frame.c (make_initial_frame): Initialize faces in all cases, not
6039 only when CANNOT_DUMP is defined.
6040 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6042 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6044 * dispnew.c (add_window_display_history): Use const for the string
6045 pointer. Remove declaration, not needed.
6047 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6049 Use 'inline', not 'INLINE'.
6050 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6051 * alloc.c, fontset.c (INLINE): Remove.
6052 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6053 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6054 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6055 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6056 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6058 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6060 Make it possible to run ./temacs.
6062 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6063 syms_of_callproc does the same thing. Remove test for
6064 "initialized", do it in the caller.
6065 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6067 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6069 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6070 (read_minibuf): Use get_minibuffer.
6071 (syms_of_minibuf): Use DEFSYM.
6072 (Qmetadata): New var.
6073 * data.c (Qbuffer): Don't make it static.
6074 (syms_of_data): Use DEFSYM.
6076 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6078 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6079 (CCL_CODE_MIN): New macro.
6081 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6083 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6085 * eval.c (Qdebug): Now static.
6086 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6087 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6088 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6090 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6092 * image.c: Various fixes to ImageMagick code comments.
6093 (Fimagemagick_types): Doc fix.
6095 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6097 Minor fixes prompted by GCC 4.6.0 warnings.
6099 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6101 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6102 (x_clipboard_manager_save_all): Move extern decl to ...
6103 * xterm.h: ... here, so that it can be checked for consistency.
6105 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6107 * xselect.c (x_clipboard_manager_save_frame)
6108 (x_clipboard_manager_save_all): New functions.
6109 (Fx_clipboard_manager_save): Lisp function deleted.
6111 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6112 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6114 * xterm.h: Update prototype.
6116 2011-05-28 William Xu <william.xwl@gmail.com>
6118 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6121 2011-05-28 Jim Meyering <meyering@redhat.com>
6123 Avoid a sign-extension bug in crypto_hash_function.
6124 * fns.c (to_uchar): Define.
6125 (crypto_hash_function): Use it to convert some newly-signed
6126 variables to unsigned, to avoid sign-extension bugs. For example,
6127 without this change, (md5 "truc") would evaluate to
6128 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6129 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6130 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6132 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6134 Integer overflow fixes.
6136 * dbusbind.c: Serial number integer overflow fixes.
6137 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6138 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6139 to hold a serial number that is too large for a fixnum.
6140 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6141 Check for serial numbers out of range. Decode any serial number
6142 that was so large that it became a float. (Bug#8722)
6144 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6145 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6146 Use XFASTINT rather than XUINT when numbers are nonnegative.
6147 (xd_append_arg, Fdbus_method_return_internal):
6148 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6149 arguments, check that Lisp number is nonnegative, rather than
6150 silently wrapping negative numbers around. (Bug#8722)
6151 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6154 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6156 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6158 ccl: Add integer overflow checks.
6159 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6160 (IN_INT_RANGE): New macros.
6161 (ccl_driver): Use them to check for integer overflow when
6162 decoding a CCL program. Many of the new checks are whether XINT (x)
6163 fits in int; it doesn't always, on 64-bit hosts. The new version
6164 doesn't catch all possible integer overflows, but it's an
6165 improvement. (Bug#8719)
6167 * alloc.c (make_event_array): Use XINT, not XUINT.
6168 There's no need for unsigned here.
6170 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6171 This follows up to the 2011-05-06 change that substituted uintptr_t
6172 for EMACS_INT. This case wasn't caught back then.
6174 Rework Fformat to avoid integer overflow issues.
6175 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6176 now (part of C89). Include <verify.h>.
6177 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6178 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6179 (Fformat): Avoid the prepass trying to compute sizes; it was only
6180 approximate and thus did not catch overflow reliably. Instead, walk
6181 through the format just once, formatting and computing sizes as we go,
6182 checking for integer overflow at every step, and allocating a larger
6183 buffer as needed. Keep track separately whether the format is
6184 multibyte. Keep only the most-recently calculated precision, rather
6185 than them all. Record whether each argument has been converted to
6186 string. Use EMACS_INT, not int, for byte and char and arg counts.
6187 Support field widths and precisions larger than INT_MAX. Avoid
6188 sprintf's undefined behavior with conversion specifications such as %#d
6189 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6190 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6191 formatting out-of-range floating point numbers with int
6194 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6196 * data.c: Avoid integer truncation in expressions involving floats.
6197 * data.c: Include <intprops.h>.
6198 (arith_driver): When there's an integer overflow in an expression
6199 involving floating point, convert the integers to floating point
6200 so that the resulting value does not suffer from catastrophic
6201 integer truncation. For example, on a 64-bit host (* 4
6202 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6203 Do not rely on undefined behavior after integer overflow.
6205 merge count_size_as_multibyte, parse_str_to_multibyte
6206 * character.c, character.h (count_size_as_multibyte):
6207 Rename from parse_str_to_multibyte; all uses changed.
6208 Check for integer overflow.
6209 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6210 since it's now a duplicate of the other. This is more of
6211 a character than a buffer op, so better that it's in character.c.
6212 * fns.c, print.c: Adjust to above changes.
6214 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6216 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6218 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6220 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6221 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6222 (x_clipboard_manager_save): Now static.
6223 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6225 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6226 (crypto_hash_function): Now static.
6227 Fix pointer signedness problems. Avoid unnecessary initializations.
6229 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6231 * termhooks.h (Vselection_alist): Make it terminal-local.
6233 * terminal.c (create_terminal): Initialize it.
6235 * xselect.c: Support for clipboard managers.
6236 (Vselection_alist): Move to termhooks.h as terminal-local var.
6237 (LOCAL_SELECTION): New macro.
6238 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6239 (symbol_to_x_atom): Remove gratuitous arg.
6240 (x_handle_selection_request, lisp_data_to_selection_data)
6241 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6242 (x_own_selection, x_get_local_selection, x_convert_selection):
6243 New arg, specifying work frame. Use terminal-local Vselection_alist.
6244 (some_frame_on_display): Delete unused function.
6245 (Fx_own_selection_internal, Fx_get_selection_internal)
6246 (Fx_disown_selection_internal, Fx_selection_owner_p)
6247 (Fx_selection_exists_p): New optional frame arg.
6248 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6249 (x_handle_selection_clear): Don't treat other terminals with the
6250 same keyboard specially. Use the terminal-local Vselection_alist.
6251 (x_clear_frame_selections): Use Frun_hook_with_args.
6253 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6255 * xterm.h: Add support for those atoms.
6257 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6259 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6260 (converted_selections, conversion_fail_tag): New global variables.
6261 (x_selection_request_lisp_error): Free the above.
6262 (x_get_local_selection): Remove unnecessary code.
6263 (x_reply_selection_request): Args changed; handle arbitrary array
6264 of converted selections stored in converted_selections.
6265 Separate the XChangeProperty and SelectionNotify steps.
6266 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6267 (x_convert_selection): New function.
6268 (x_handle_selection_event): Simplify.
6269 (x_get_foreign_selection): Don't ignore incoming requests while
6270 waiting for an answer; this will fail when we implement
6271 SAVE_TARGETS, and seems unnecessary anyway.
6272 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6273 (Vx_sent_selection_functions): Doc fix.
6275 2011-05-26 Leo Liu <sdl.web@gmail.com>
6277 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6279 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6281 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6283 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6284 for fringe update if it has periodic bitmap.
6285 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6286 and fringe_bitmap_periodic_p.
6288 * fringe.c (get_fringe_bitmap_data): New function.
6289 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6290 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6291 row. Mark glyph row for fringe update if periodicity changed.
6293 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6294 for fringe update unless it has periodic bitmap.
6296 2011-05-25 Kenichi Handa <handa@m17n.org>
6298 * xdisp.c (get_next_display_element): Set correct it->face_id for
6299 a static composition.
6301 2011-05-24 Leo Liu <sdl.web@gmail.com>
6304 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6306 * fns.c (crypto_hash_function, Fsha1): New function.
6307 (Fmd5): Use crypto_hash_function.
6308 (syms_of_fns): Add Ssha1.
6310 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6312 * gnutls.c: Remove unused macros.
6313 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6314 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6315 Remove macros that are defined and never used.
6316 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6318 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6320 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6321 (Fx_get_selection_internal): Minor cleanup.
6322 (Fx_own_selection_internal): Rename arguments for consistency with
6325 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6327 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6329 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6331 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6333 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6335 * dispnew.c (scrolling_window): Don't exclude the case that the
6336 last enabled row in the desired matrix touches the bottom boundary.
6338 2011-05-21 Glenn Morris <rgm@gnu.org>
6340 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6341 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6342 and add some more files.
6344 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6346 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6347 report_file_error introduced by the change from 2011-05-07.
6349 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6351 * systime.h (Time): Define only if emacs is defined.
6352 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6353 where the include path doesn't have X11/X.h by default. See
6354 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6356 2011-05-20 Kenichi Handa <handa@m17n.org>
6358 * composite.c (find_automatic_composition): Fix previous change.
6360 2011-05-20 Glenn Morris <rgm@gnu.org>
6362 * lisp.mk: New file, split from Makefile.in.
6363 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6364 (shortlisp): Remove.
6365 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6367 2011-05-19 Glenn Morris <rgm@gnu.org>
6369 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6370 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6371 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6372 (lisp): Set the order to that of loadup.el.
6373 (shortlisp): Make it a copy of $lisp.
6374 (SOME_MACHINE_LISP): Remove.
6375 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6376 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6378 2011-05-18 Kenichi Handa <handa@m17n.org>
6380 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6381 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6382 (find_automatic_composition): Mostly rewrite for efficiency.
6384 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6386 * makefile.w32-in: Update dependencies.
6388 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6390 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6391 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6393 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6395 Fix some integer overflow issues, such as string length overflow.
6397 * insdel.c (count_size_as_multibyte): Check for string overflow.
6399 * character.c (lisp_string_width): Check for string overflow.
6400 Use EMACS_INT, not int, for string indexes and lengths; in
6401 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6402 the resulting string length overflows an EMACS_INT; instead,
6403 report a string overflow if no precision given. When checking for
6404 precision exhaustion, use a check that cannot possibly have
6405 integer overflow. (Bug#8675)
6406 * character.h (lisp_string_width): Adjust to new signature.
6408 * alloc.c (string_overflow): New function.
6409 (Fmake_string): Use it. This doesn't change behavior, but saves
6410 a few bytes and will simplify future changes.
6411 * character.c (string_escape_byte8): Likewise.
6412 * lisp.h (string_overflow): New decl.
6414 Fixups, following up to the user-interface timestamp change.
6415 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6416 for UI timestamps, instead of unsigned long.
6417 * msdos.c (mouse_get_pos): Likewise.
6418 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6419 * w32gui.h (Time): Define by including "systime.h" rather than by
6420 declaring it ourselves. (Bug#8664)
6422 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6423 * image.c (clear_image_cache): Likewise.
6425 * term.c (term_mouse_position): Don't assume time_t wraparound.
6427 Be more systematic about user-interface timestamps.
6428 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6429 and sometimes 'EMACS_UINT', to represent these timestamps.
6430 This change causes it to use 'Time' uniformly, as that's what X uses.
6431 This makes the code easier to follow, and makes it easier to catch
6432 integer overflow bugs such as Bug#8664.
6433 * frame.c (Fmouse_position, Fmouse_pixel_position):
6434 Use Time, not unsigned long, for user-interface timestamps.
6435 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6436 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6437 * keyboard.h (last_event_timestamp): Likewise.
6438 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6439 * menu.h (xmenu_show): Likewise.
6440 * term.c (term_mouse_position): Likewise.
6441 * termhooks.h (struct input_event.timestamp): Likewise.
6442 (struct terminal.mouse_position_hook): Likewise.
6443 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6444 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6445 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6446 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6448 * menu.h, termhooks.h: Include "systime.h", for Time.
6450 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6451 Don't assume that the difference between two unsigned long values
6452 can fit into an integer. At this point, we know button_down_time
6453 <= event->timestamp, so the difference must be nonnegative, so
6454 there's no need to cast the result if double-click-time is
6455 nonnegative, as it should be; check that it's nonnegative, just in
6456 case. This bug is triggered when events are more than 2**31 ms
6457 apart (about 25 days). (Bug#8664)
6459 * xselect.c (last_event_timestamp): Remove duplicate decl.
6460 (x_own_selection): Remove needless cast to unsigned long.
6462 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6463 that always fit in int. Use a sentinel instead of a counter, to
6464 avoid a temp and to allay GCC's concerns about possible int overflow.
6465 * frame.h (struct frame): Use int for menu_bar_items_used
6466 instead of EMACS_INT, since it always fits in int.
6468 * menu.c (grow_menu_items): Check for int overflow.
6470 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6472 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6473 Before, the code was not consistent. These values cannot exceed
6474 2**31 - 1 so there's no need to make them unsigned.
6475 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6476 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6477 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6479 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6481 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6482 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6483 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6484 presumably because the widths might not match.
6486 * window.c (size_window): Avoid needless test at loop start.
6488 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6490 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6492 2011-05-12 Drew Adams <drew.adams@oracle.com>
6494 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6496 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6498 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6499 `width' to `bar_area_x' and `bar_area_width', respectively.
6500 (x_scroll_run): Take account of fringe background extension.
6502 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6503 Rename local vars `left' and `width' to `bar_area_x' and
6504 `bar_area_width', respectively.
6505 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6506 background extension.
6508 2011-05-10 Jim Meyering <meyering@redhat.com>
6510 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6512 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6514 * image.c (Finit_image_library): Return t for built-in image types,
6515 like pbm and xbm. (Bug#8640)
6517 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6519 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6521 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6523 * w32console.c (Fset_screen_color): Doc fix.
6524 (Fget_screen_color): New function.
6525 (syms_of_ntterm): Defsubr it.
6527 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6528 unlink the temporary file if Fcall_process didn't create it in the
6530 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6531 child process will be redirected to a file specified with `:file'.
6532 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6533 cue to call_process_cleanup not to close that handle.
6535 2011-05-07 Ben Key <bkey76@gmail.com>
6537 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6538 one of two shell specific rules, either bootstrap-temacs-CMD or
6539 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6540 to the previous implementation of the bootstrap-temacs rule.
6541 The bootstrap-temacs-CMD rule is similar to the previous
6542 implementation of the bootstrap-temacs rule except that it
6543 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6546 These changes, along with some changes to nt/configure.bat,
6547 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6548 earlier fix to add support for --cflags and --ldflags options
6549 that include quotes so that it works whether make uses cmd or
6552 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6554 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6555 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6557 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6558 a string. Handle both cases.
6559 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6560 (Fdbus_register_method): Use Qinvalid_function.
6562 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6564 * makefile.w32-in: Update dependencies.
6565 (LISP_H): Add inttypes.h and stdin.h.
6566 (PROCESS_H): Add unistd.h.
6568 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6570 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6571 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6573 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6575 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6577 * term.c (vfatal): Remove stray call to va_end.
6578 It's not needed and the C Standard doesn't allow it here anyway.
6580 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6581 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6583 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6586 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6588 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6590 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6592 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6594 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6596 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6597 * charset.c (Fdefine_charset_internal): Don't initialize
6598 charset.code_space[15]. The value was garbage, on hosts with
6599 32-bit int (Bug#8600).
6601 * lread.c (read_integer): Be more consistent with string-to-number.
6602 Use string_to_number to do the actual conversion; this avoids
6603 rounding errors and fixes some other screwups. Without this fix,
6604 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6605 (digit_to_number): Move earlier, for benefit of read_integer.
6606 Return -1 if the digit is out of range for the base, -2 if it is
6607 not a digit in any supported base. (Bug#8602)
6609 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6611 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6612 to match comment at start of function. This also removes a
6613 GCC warning about overflow in a 32+64-bit port.
6615 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6617 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6618 Reported by Stefan Monnier in
6619 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6620 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6621 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6623 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6624 (EMACS_UINTPTR): Likewise, with uintptr_t.
6626 * lisp.h: Prefer 64-bit EMACS_INT if available.
6627 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6628 on 32-bit hosts that have 64-bit int, so that they can access
6630 However, temporarily disable this change unless the temporary
6631 symbol WIDE_EMACS_INT is defined.
6633 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6635 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6636 This removes an assumption that EMACS_INT and long are the same
6637 width as pointers. The assumption is true for Emacs porting targets
6638 now, but we want to make other targets possible.
6639 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6640 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6641 In the rest of the code, change types of integers that hold casted
6642 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6643 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6644 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6645 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6646 No need to cast type when ORing.
6647 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6648 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6649 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6650 assume EMACS_INT is the same width as char *.
6651 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6652 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6653 Remove no-longer-needed casts.
6654 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6655 (xg_tool_bar_help_callback, xg_make_tool_item):
6656 Use EMACS_INTPTR to hold an integer
6657 that will be cast to void *; this can avoid a GCC warning
6658 if EMACS_INT is not the same width as void *.
6659 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6660 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6661 (current_message_1, set_message_1):
6662 Use a local to convert to proper width without a cast.
6663 * xmenu.c (dialog_selection_callback): Likewise.
6665 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6666 Also, don't assume VALBITS / RAND_BITS is less than 5,
6667 and don't rely on undefined behavior when shifting a 1 left into
6669 * lisp.h (get_random): Change signature to match.
6671 * lread.c (hash_string): Use size_t, not int, for hash computation.
6672 Normally we prefer signed values; but hashing is special, because
6673 it's better to use unsigned division on hash table sizes so that
6674 the remainder is nonnegative. Also, size_t is the natural width
6675 for hashing into memory. The previous code used 'int', which doesn't
6676 retain enough info to hash well into very large tables.
6677 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6679 * dbusbind.c: Don't possibly lose pointer info when converting.
6680 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6681 Use XPNTR rather than XHASH, so that the high-order bits of
6682 the pointer aren't lost when converting through void *.
6684 * eval.c (Fautoload): Don't double-shift a pointer.
6686 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6688 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6690 * gnutls.c (DEF_GNUTLS_FN):
6691 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6693 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6695 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6698 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6700 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6701 New version that can reserve upto 2GB of heap space.
6703 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6705 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6707 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6709 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6710 `gnutls_certificate_set_x509_key_file'.
6712 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6714 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6715 Update dependencies.
6717 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6719 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6720 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6721 Remove unused parameter `fildes'.
6722 * process.c (read_process_output, send_process): Don't pass it.
6724 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6726 Fix previous change: the library cache is defined in w32.c.
6727 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6728 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6730 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6732 Implement dynamic loading of GnuTLS on Windows.
6734 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6735 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6736 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6739 * gnutls.c (Qgnutls_dll): Define.
6740 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6741 (gnutls_*): Declare function pointers.
6742 (init_gnutls_functions): New function to initialize function pointers.
6743 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6744 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6745 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6746 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6747 (emacs_gnutls_write, emacs_gnutls_read)
6748 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6749 (Fgnutls_available_p): New function.
6750 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6751 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6752 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6754 * image.c: Include w32.h.
6755 (Vimage_type_cache): Delete.
6756 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6757 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6758 (w32_delayed_load): Move to w32.c.
6760 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6762 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6763 (w32_delayed_load): Move from image.c. When loading a library, record
6764 its filename in the :loaded-from property of the library id.
6765 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6766 Initialize and staticpro them.
6767 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6769 * process.c: Include lisp.h before w32.h, not after.
6770 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6771 instead of gnutls_record_check_pending.
6773 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6775 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6777 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6778 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6781 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6783 * xterm.c (x_set_frame_alpha): Do not set property on anything
6784 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6786 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6788 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6790 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6792 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6793 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6794 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6795 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6796 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6797 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6798 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6799 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6800 (Qgnutls_bootprop_callbacks_verify): Make static.
6802 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6804 * callproc.c: Indentation fixup.
6806 * sysdep.c (wait_for_termination_1): Make static.
6807 (wait_for_termination, interruptible_wait_for_termination):
6808 Move after wait_for_termination_1.
6810 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6812 * sysdep.c (interruptible_wait_for_termination): New function
6813 which is like wait_for_termination, but allows keyboard
6816 * callproc.c (Fcall_process): Add (:file "file") as an option for
6818 (Fcall_process_region): Ditto.
6820 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6822 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6823 rather than `XVECTOR (FOO)->size'.
6825 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6826 inttypes.h, as a gnulib replacement is used if it not available in
6829 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6831 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6832 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6833 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6835 * coding.c (coding_alloc_by_realloc): Error out if destination
6836 will grow beyond MOST_POSITIVE_FIXNUM.
6837 (decode_coding_emacs_mule): Abort if there isn't enough place in
6838 charbuf for the composition carryover bytes. Reserve an extra
6839 space for up to 2 characters produced in a loop.
6840 (decode_coding_iso_2022): Abort if there isn't enough place in
6841 charbuf for the composition carryover bytes.
6843 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6845 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6846 aborting when %lld or %lll format is passed.
6847 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6848 %llo or %llx format is passed. (Bug#8545)
6850 * window.c (window_scroll_line_based): Use a marker instead of
6851 simple variables to record original value of point. (Bug#7952)
6853 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6854 produced by %s or %c overflows available buffer space. (Bug#8545)
6856 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6858 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6859 (SIZE_MAX): Move defn after all includes, as they might #define it.
6861 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6863 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6865 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6867 * keyboard.c (Qdelayed_warnings_hook): Define.
6868 (command_loop_1): Run `delayed-warnings-hook'
6869 if Vdelayed_warnings_list is non-nil.
6870 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6871 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6873 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6875 * doprnt.c (doprnt): Don't return value smaller than the buffer
6876 size if the message was truncated. (Bug#8545).
6878 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6880 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6881 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6883 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6885 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6887 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6889 * makefile.w32-in: Update dependencies.
6891 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6893 Improve `doprnt' and its usage. (Bug#8545)
6894 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6895 `format_end'. Remove support for %l as a conversion specifier.
6896 Don't use xrealloc. Improve diagnostics when the %l size modifier
6897 is used. Update the commentary.
6899 * eval.c (verror): Simplify calculation of size_t.
6901 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6904 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6906 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6909 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6911 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6912 This makes this file independent of the recent pseudovector change.
6914 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6916 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6918 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6919 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6920 Remove unused local.
6921 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6923 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6924 GCC 4.6.0 optimizes based on type-based alias analysis.
6925 For example, if b is of type struct buffer * and v of type struct
6926 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6927 != &v->size, and therefore "v->size = 1; b->size = 2; return
6928 v->size;" must therefore return 1. This assumption is incorrect
6929 for Emacs, since it type-puns struct Lisp_Vector * with many other
6930 types. To fix this problem, this patch adds a new type struct
6931 vectorlike_header that documents the constraints on layout of vectors
6932 and pseudovectors, and helps optimizing compilers not get fooled
6933 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6934 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6935 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6937 (XSETPVECTYPE): Rewrite in terms of new macro.
6938 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6939 This is a bit clearer, and further avoids the possibility of
6940 undesirable aliasing.
6941 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6942 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6943 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6944 since Lisp_Subr is a special case (no "next" field).
6945 (ASIZE): Now uses header.size rather than size.
6946 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6947 to avoid the hassle of writing XVECTOR (foo)->header.size.
6948 (struct vectorlike_header): New type.
6949 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6950 object, to help avoid aliasing.
6951 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6952 (SUBRP): Likewise, since Lisp_Subr is a special case.
6953 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6954 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6955 (struct Lisp_Hash_Table): Combine first two members into a single
6956 struct vectorlike_header member. All uses of "size" and "next" members
6957 changed to be "header.size" and "header.next".
6958 * buffer.h (struct buffer): Likewise.
6959 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6960 * frame.h (struct frame): Likewise.
6961 * process.h (struct Lisp_Process): Likewise.
6962 * termhooks.h (struct terminal): Likewise.
6963 * window.c (struct save_window_data, struct saved_window): Likewise.
6964 * window.h (struct window): Likewise.
6965 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6966 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6967 * buffer.c (init_buffer_once): Likewise.
6968 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6970 * process.c (Fformat_network_address): Use local var for size,
6973 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6975 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6976 * data.c (atof): Remove decl; no longer used or needed.
6977 (digit_to_number): Move to lread.c.
6978 (Fstring_to_number): Use new string_to_number function, to be
6979 consistent with how the Lisp reader treats infinities and NaNs.
6980 Do not assume that floating-point numbers represent EMACS_INT
6981 without losing information; this is not true on most 64-bit hosts.
6982 Avoid double-rounding errors, by insisting on integers when
6983 parsing non-base-10 numbers, as the documentation specifies.
6984 * lisp.h (string_to_number): New decl, replacing ...
6985 (isfloat_string): Remove.
6986 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6987 (read1): Do not accept +. and -. as integers; this
6988 appears to have been a coding error. Similarly, do not accept
6989 strings like +-1e0 as floating point numbers. Do not report
6990 overflow for integer overflows unless the base is not 10 which
6991 means we have no simple and reliable way to continue.
6992 Break out the floating-point parsing into a new
6993 function string_to_number, so that Fstring_to_number parses
6994 floating point numbers consistently with the Lisp reader.
6995 (digit_to_number): Move here from data.c. Make it static inline.
6996 (E_CHAR, EXP_INT): Remove, replacing with ...
6997 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6998 (string_to_number): New function, replacing isfloat_string.
6999 This function checks for valid syntax and produces the resulting
7000 Lisp float number too. Rework it so that string-to-number
7001 no longer mishandles examples like "1.0e+". Use strtoumax,
7002 so that overflow for non-base-10 numbers is reported only when
7003 there's no portable and simple way to convert to floating point.
7005 * textprop.c (set_text_properties_1): Rewrite for clarity,
7006 and to avoid GCC warning about integer overflow.
7008 * intervals.h (struct interval): Use EMACS_INT for members
7009 where EMACS_UINT might cause problems. See
7010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7011 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7012 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7014 (offset_intervals): Tell GCC not to worry about length overflow
7015 when negating a negative length.
7017 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7018 (overrun_check_free): Likewise.
7020 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7021 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7024 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7025 (gnutls_make_error): Rename local to avoid shadowing.
7026 (gnutls_emacs_global_deinit): ifdef out; not used.
7027 (Fgnutls_boot): Use const for pointer to readonly storage.
7028 Comment out unused local. Fix pointer signedness problems.
7030 * lread.c (openp): Don't stuff size_t into an 'int'.
7031 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7032 about possible signed overflow.
7034 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7035 (GDK_KEY_g): Don't define if already defined.
7036 (xg_prepare_tooltip): Avoid pointer signedness problem.
7037 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7039 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7040 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7042 * xfns.c (Fx_window_property): Simplify a bit,
7043 to make a bit faster and to avoid GCC 4.6.0 warning.
7044 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7046 * fns.c (internal_equal): Don't assume size_t fits in int.
7048 * alloc.c (compact_small_strings): Tighten assertion a little.
7050 Replace pEd with more-general pI, and fix some printf arg casts.
7051 * lisp.h (pI): New macro, generalizing old pEd macro to other
7052 conversion specifiers. For example, use "...%"pI"d..." rather
7053 than "...%"pEd"...".
7054 (pEd): Remove. All uses replaced with similar uses of pI.
7055 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7056 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7057 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7058 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7059 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7060 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7061 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7063 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7064 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7065 * print.c (safe_debug_print, print_object): Likewise.
7066 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7068 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7069 avoiding the 0 flag, which is not portable.
7070 * process.c (Fmake_network_process): Use pI to avoid cast.
7071 * region-cache.c (pp_cache): Likewise.
7072 * xdisp.c (decode_mode_spec): Likewise.
7073 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7074 behavior on 64-bit hosts with printf arg.
7075 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7076 (x_stop_queuing_selection_requests): Likewise.
7077 (x_get_window_property): Don't truncate byte count to an 'int'
7080 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7081 here, since it parses constructs like leading '-' and spaces,
7082 which are not wanted; and it overflows with large numbers.
7083 Instead, simply match F[0-9]+, which is what is wanted anyway.
7085 * alloc.c: Remove unportable assumptions about struct layout.
7086 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7087 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7088 (allocate_vectorlike, make_pure_vector): Use the new macros,
7089 plus offsetof, to remove unportable assumptions about struct layout.
7090 These assumptions hold on all porting targets that I know of, but
7091 they are not guaranteed, they're easy to remove, and removing them
7092 makes further changes easier.
7094 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7095 This doesn't fix a bug but makes the code clearer.
7096 (string_overrun_cookie): Now const. Use initializers that
7097 don't formally overflow signed char, to avoid warnings.
7098 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7099 can cause Emacs to crash when string overrun checking is enabled.
7100 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7101 multiple of sizeof (EMACS_INT); it need not be, if
7102 alignof(EMACS_INT) < sizeof (EMACS_INT).
7103 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7105 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7107 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7109 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7111 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7112 supposed to be handshaking. (Bug#8556)
7113 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7115 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7117 * lisp.h (Qdebug): List symbol.
7118 * eval.c (Qdebug): Restore global linkage.
7119 * keyboard.c (debug-on-event): New variable.
7120 (handle_user_signal): Break into debugger when debug-on-event
7121 matches the current signal symbol.
7123 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7125 * alloc.c (check_sblock, check_string_bytes)
7126 (check_string_free_list): Convert to standard C.
7128 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7130 * w32.c (emacs_gnutls_push): Fix typo.
7132 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7134 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7135 "cast to pointer from integer of different size".
7137 Improve doprnt and its use in verror. (Bug#8545)
7138 * doprnt.c (doprnt): Document the set of format control sequences
7139 supported by the function. Use SAFE_ALLOCA instead of always
7142 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7143 is one byte too soon. Don't use xrealloc; instead xfree and
7146 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7148 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7151 * gnutls.c: Renamed global_initialized to
7152 gnutls_global_initialized. Added internals for the
7153 :verify-hostname-error, :verify-error, and :verify-flags
7154 parameters of `gnutls-boot' and documented those parameters in the
7155 docstring. Start callback support.
7156 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7157 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7158 on error. Return error code.
7159 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7160 (emacs_gnutls_read): Likewise.
7161 (Fgnutls_boot): Return handshake error code.
7162 (emacs_gnutls_handle_error): New function.
7163 (wsaerror_to_errno): Likewise.
7165 * w32.h (emacs_gnutls_pull): Add prototype.
7166 (emacs_gnutls_push): Likewise.
7168 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7169 (emacs_gnutls_push): Likewise.
7171 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7173 * process.c (wait_reading_process_output): Check if GnuTLS
7174 buffered some data internally if no FDs are set for TLS
7177 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7178 (LIBS): Link to USER_LIBS.
7179 ($(BLD)/gnutls.$(0)): New target.
7181 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7183 * xdisp.c (handle_single_display_spec): Rename the
7184 display_replaced_before_p argument into display_replaced_p, to
7185 make it consistent with the commentary. Fix typos in the
7188 * textprop.c (syms_of_textprop): Remove dead code.
7189 (copy_text_properties): Delete obsolete commentary about an
7190 interface that was deleted long ago. Fix typos in the description
7193 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7194 to changes in oldXMenu/XMenu.h from 2011-04-16.
7195 <menu_help_message, prev_menu_help_message>: Constify.
7196 (IT_menu_make_room): menu->help_text is now `const char **';
7199 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7200 to changes in oldXMenu/XMenu.h from 2011-04-16.
7201 (struct XMenu): Declare `help_text' `const char **'.
7203 * xfaces.c <Qunspecified>: Make extern again.
7205 * syntax.c: Include sys/types.h before including regex.h, as
7208 * doc.c (get_doc_string): Improve the format passed to `error'.
7210 * doprnt.c (doprnt): Improve commentary.
7212 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7214 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7217 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7218 changes in globals.h immediately force recompilation.
7219 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7220 $(CURDIR)/s/ms-w32.h.
7221 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7223 * character.c (Fchar_direction): Function deleted.
7224 (syms_of_character): Don't defsubr it.
7225 <char-direction-table>: Deleted.
7227 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7229 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7230 * doprnt.c: Include limits.h.
7231 (SIZE_MAX): New macro.
7232 (doprnt): Return a size_t value. 2nd arg is now size_t.
7233 Many local variables are now size_t instead of int or unsigned.
7234 Improve overflow protection. Support `l' modifier for integer
7235 conversions. Support %l conversion. Don't assume an EMACS_INT
7236 argument for integer conversions and for %c.
7238 * lisp.h (doprnt): Restore prototype.
7240 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7243 * Makefile.in (base_obj): Add back doprnt.o.
7245 * deps.mk (doprnt.o): Add back prerequisites.
7246 (callint.o): Depend on character.h.
7248 * eval.c (internal_lisp_condition_case): Include the handler
7249 representation in the error message.
7250 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7251 when breaking from the loop.
7253 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7255 * callint.c (Fcall_interactively): When displaying error message
7256 about invalid control letter, pass the character's codepoint, not
7257 a pointer to its multibyte form. Improve display of the character
7258 in octal and display also its hex code.
7260 * character.c (char_string): Use %x to display the (unsigned)
7261 codepoint of an invalid character, to avoid displaying a bogus
7264 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7265 `error', not SYMBOL_NAME itself.
7267 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7268 character arguments to `error'.
7270 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7271 to `error' in error message about FINAL_CHAR argument. Make sure
7272 FINAL_CHAR is a character, and use %c when it is passed as
7273 argument to `error'.
7275 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7277 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7279 * w32.c: Include <time.h>.
7280 (sys_localtime): New function.
7282 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7284 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7286 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7288 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7290 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7293 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7295 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7296 gl_state.e_property when gl_state.object is Qt.
7298 * insdel.c (make_gap_larger): Remove limitation of buffer size
7301 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7303 * xdisp.c (lookup_glyphless_char_display)
7304 (produce_glyphless_glyph): Handle cons cell entry in
7305 glyphless-char-display.
7306 (Vglyphless_char_display): Document it.
7308 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7309 glyphless-char-display.
7311 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7313 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7315 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7317 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7318 definition for no-X builds.
7320 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7322 Static checks with GCC 4.6.0 and non-default toolkits.
7324 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7326 * process.c (keyboard_bit_set): Define only if SIGIO.
7327 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7328 (send_process): Repair possible setjmp clobbering.
7330 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7332 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7334 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7336 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7337 Define only if needed.
7339 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7340 by pacifying GCC about it. Maybe it's time to retire it?
7341 * xfaces.c (USG, __TIMEVAL__): Likewise.
7343 * dispextern.h (struct redisplay_interface): Rename param
7345 * termhooks.h (struct terminal): Likewise.
7346 * xterm.c (xembed_send_message): Likewise.
7348 * insdel.c (make_gap_smaller): Define only if
7349 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7351 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7354 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7355 so that we aren't warned about unused symbols.
7357 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7359 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7361 * xfns.c (x_real_positions): Mark locals as initialized.
7363 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7365 * xterm.c: Fix problems found by static analysis with other toolkits.
7366 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7367 (x_dispatch_event): Declare static if USE_GTK, and
7368 define if USE_GTK || USE_X_TOOLKIT.
7369 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7370 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7371 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7372 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7374 * xmenu.c (menu_help_callback): Pointer type fixes.
7375 Use const pointers when pointing at readonly data. Avoid pointer
7377 (FALSE): Remove unused macro.
7378 (update_frame_menubar): Remove unused decl.
7380 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7382 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7383 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7384 (single_menu_item): Rename local to avoid shadowing.
7386 * keyboard.c (make_lispy_event): Remove unused local var.
7388 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7389 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7391 * bitmaps: Change bitmaps from unsigned char back to the X11
7392 compatible char. Avoid the old compiler warnings about
7393 out-of-range initializers by using, for example, '\xab' rather
7396 * xgselect.c (xgselect_initialize): Check vs interface
7397 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7399 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7401 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7402 to read-only memory.
7404 * fns.c (vector): Remove; this old hack is no longer needed.
7406 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7408 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7410 * xrdb.c (x_load_resources): Omit unused local.
7412 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7413 (x_window): Rename locals to avoid shadowing.
7414 (USG): Use the kludged USG macro, to pacify gcc.
7416 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7417 (x_term_init): Remove local to avoid shadowing.
7419 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7421 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7422 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7424 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7426 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7428 Fix regex.c, syntax.c and friends for buffers > 2GB.
7429 * syntax.h (struct gl_state_s): Declare character position members
7432 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7434 * textprop.c (verify_interval_modification, interval_of):
7435 Declare arguments EMACS_INT.
7437 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7440 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7442 * indent.c (Fvertical_motion): Local variable it_start is now
7445 * regex.c (re_match, re_match_2, re_match_2_internal)
7446 (bcmp_translate, regcomp, regexec, print_double_string)
7447 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7448 (re_compile_pattern, re_exec): Declare arguments and local
7449 variables `size_t' and `ssize_t' and return values `regoff_t', as
7451 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7452 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7453 <compile_stack_type>: `size' and `avail' are now `size_t'.
7455 * regex.h <regoff_t>: Use ssize_t, not int.
7456 (re_search, re_search_2, re_match, re_match_2): Arguments that
7457 specify buffer/string position and length are now ssize_t and
7458 size_t. Return type is regoff_t.
7460 2011-04-16 Ben Key <bkey76@gmail.com>
7462 * nsfont.m: Fixed bugs in ns_get_family and
7463 ns_descriptor_to_entity that were caused by using free to
7464 deallocate memory blocks that were allocated by xmalloc (via
7465 xstrdup). This caused Emacs to crash when compiled with
7466 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7467 --enable-checking=xmallocoverrun). xfree is now used to
7468 deallocate these memory blocks.
7470 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7472 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7474 emacs_write: Accept and return EMACS_INT for sizes.
7475 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7477 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7478 Accept and return EMACS_INT.
7479 (emacs_gnutls_write): Return the number of bytes written on
7481 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7482 (emacs_read, emacs_write): Remove check for negative size, as the
7483 Emacs source code has been audited now.
7484 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7485 (emacs_read, emacs_write): Use it.
7486 * process.c (send_process): Adjust to the new signatures of
7487 emacs_write and emacs_gnutls_write. Do not attempt to store
7488 a byte offset into an 'int'; it might overflow.
7489 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7491 * sound.c: Don't assume sizes fit in 'int'.
7492 (struct sound_device.period_size, alsa_period_size):
7493 Return EMACS_INT, not int.
7494 (struct sound_device.write, vox_write, alsa_write):
7495 Accept EMACS_INT, not int.
7496 (wav_play, au_play): Use EMACS_INT to store sizes and to
7497 record read return values.
7499 2011-04-15 Ben Key <bkey76@gmail.com>
7501 * keyboard.c (Qundefined): Don't declare static since it is used
7503 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7504 static since they are used in nsfont.m.
7506 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7508 * process.c (Qprocessp): Don't declare static.
7509 * lisp.h (Qprocessp): Declare again.
7511 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7513 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7515 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7517 Improve C-level modularity by making more things 'static'.
7519 Don't publish debugger-only interfaces to other modules.
7520 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7521 (verify_bytepos, count_markers): Move decls to the only modules
7523 * region-cache.h (pp_cache): Likewise.
7524 * window.h (check_all_windows): Likewise.
7525 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7527 * sysdep.c (croak): Now static, if
7528 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7529 * syssignal.h (croak): Declare only if not static.
7531 * alloc.c (refill_memory_reserve): Now static if
7532 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7533 * lisp.h (refill_memory_reserve): Declare only if not static.
7535 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7536 Define only if USE_LUCID.
7538 * xrdb.c (x_customization_string, x_rm_string): Now static.
7540 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7541 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7543 * xdisp.c (draw_row_with_mouse_face): Now static.
7544 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7546 * window.h (check_all_windows): Mark externally visible.
7548 * window.c (window_deletion_count): Now static.
7550 * undo.c: Make symbols static if they're not exported.
7551 (last_undo_buffer, last_boundary_position, pending_boundary):
7554 * textprop.c (interval_insert_behind_hooks): Now static.
7555 (interval_insert_in_front_hooks): Likewise.
7557 * term.c: Make symbols static if they're not exported.
7558 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7559 (max_frame_lines, tty_set_terminal_modes):
7560 (tty_reset_terminal_modes, tty_turn_off_highlight):
7561 (get_tty_terminal): Now static.
7562 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7563 * termhooks.h (term_mouse_moveto): Do not declare if
7565 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7566 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7568 * sysdep.c: Make symbols static if they're not exported.
7569 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7571 (sigprocmask_set, full_mask): Remove; unused.
7572 (wait_debugging): Mark as visible.
7573 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7574 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7576 * syntax.c (syntax_temp): Define only if !__GNUC__.
7578 * sound.c (current_sound_device, current_sound): Now static.
7580 * search.c (searchbufs, searchbuf_head): Now static.
7582 * scroll.c (scroll_cost): Remove; unused.
7583 * dispextern.h (scroll_cost): Remove decl.
7585 * region-cache.h (pp_cache): Mark as externally visible.
7587 * process.c: Make symbols static if they're not exported.
7588 (process_tick, update_tick, create_process, chan_process):
7589 (Vprocess_alist, proc_buffered_char, datagram_access):
7590 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7591 (deactivate_process): Mark defn as static, as well as decl.
7592 * lisp.h (create_process): Remove decl.
7593 * process.h (chan_process, Vprocess_alist): Remove decls.
7595 * print.c: Make symbols static if they're not exported.
7596 (print_depth, new_backquote_output, being_printed, print_buffer):
7597 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7598 (print_interval, print_number_index, initial_stderr_stream):
7600 * lisp.h (Fprinc): Remove decl.
7601 (debug_output_compilation_hack): Mark as externally visible.
7603 * sysdep.c (croak): Move decl from here to syssignal.h.
7604 * syssignal.h (croak): Put it here, so the API can be checked when
7605 'croak' is called from dissociate_if_controlling_tty.
7607 * minibuf.c: Make symbols static if they're not exported.
7608 (minibuf_save_list, choose_minibuf_frame): Now static.
7609 * lisp.h (choose_minibuf_frame): Remove decl.
7611 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7613 * lread.c: Make symbols static if they're not exported.
7614 (read_objects, initial_obarray, oblookup_last_bucket_number):
7616 (make_symbol): Remove; unused.
7617 * lisp.h (initial_obarray, make_symbol): Remove decls.
7619 * keyboard.c: Make symbols static if they're not exported.
7620 (single_kboard, recent_keys_index, total_keys, recent_keys):
7621 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7622 (this_single_command_key_start, echoing, last_auto_save):
7623 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7624 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7625 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7626 (Vlispy_mouse_stem, double_click_count):
7628 (force_auto_save_soon): Define only if SIGDANGER.
7629 (ignore_mouse_drag_p): Now static if
7630 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7631 (print_help): Remove; unused.
7632 (stop_character, last_timer_event): Mark as externally visible.
7633 * keyboard.h (ignore_mouse_drag_p): Declare only if
7634 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7635 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7636 * lisp.h (echoing): Remove decl.
7637 (force_auto_save_soon): Declare only if SIGDANGER.
7638 * xdisp.c (redisplay_window): Simplify code, to make it more
7639 obvious that ignore_mouse_drag_p is not accessed if !defined
7640 USE_GTK && !defined HAVE_NS.
7642 * intervals.c: Make symbols static if they're not exported.
7643 (merge_properties_sticky, merge_interval_right, delete_interval):
7645 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7647 * insdel.c: Make symbols static if they're not exported.
7648 However, leave prepare_to_modify_buffer alone. It's never
7649 called from outside this function, but that appears to be a bug.
7650 (combine_after_change_list, combine_after_change_buffer):
7651 (adjust_after_replace, signal_before_change): Now static.
7652 (adjust_after_replace_noundo): Remove; unused.
7653 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7654 (signal_before_change): Remove decls.
7656 * indent.c (val_compute_motion, val_vmotion): Now static.
7658 * image.c: Make symbols static if they're not exported.
7659 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7661 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7662 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7664 * fringe.c (standard_bitmaps): Now static.
7665 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7667 * frame.c: Make symbols static if they're not exported.
7668 (x_report_frame_params, make_terminal_frame): Now static.
7669 (get_frame_param): Now static, unless HAVE_NS.
7670 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7671 (x_get_resource_string): Remove; not used.
7672 * frame.h (make_terminal_frame, x_report_frame_params):
7673 (x_get_resource_string); Remove decls.
7674 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7675 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7677 * font.c, fontset.c: Make symbols static if they're not exported.
7678 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7679 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7680 * font.c (font_close_object): Now static.
7681 * font.h (font_close_object): Remove.
7682 * fontset.c (FONTSET_OBJLIST): Remove.
7683 (free_realized_fontset) #if-0 the body, which does nothing.
7684 (face_suitable_for_char_p): #if-0, as it's never called.
7685 * fontset.h (face_suitable_for_char_p): Remove decl.
7686 * xfaces.c (face_at_string_position):
7687 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7688 since 0 is always ASCII.
7690 * fns.c (weak_hash_tables): Now static.
7692 * fileio.c: Make symbols static if they're not exported.
7693 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7694 (Vwrite_region_annotation_buffers): Now static.
7696 * eval.c: Make symbols static if they're not exported.
7697 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7698 * lisp.h (backtrace_list): Remove decl.
7700 * emacs.c: Make symbols static if they're not exported.
7701 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7702 (fatal_error_code, fatal_error_signal_hook, standard_args):
7704 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7705 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7706 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7707 * lisp.h (fatal_error_signal_hook): Remove decl.
7708 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7710 * editfns.c: Move a (normally-unused) function to its only use.
7711 * editfns.c, lisp.h (get_operating_system_release): Remove.
7712 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7713 worth the hassle of breaking this out.
7715 * xterm.c: Make symbols static if they're not exported.
7716 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7717 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7718 (x_destroy_window, x_delete_display):
7720 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7721 (x_mouse_leave): Remove; unused.
7722 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7723 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7724 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7726 (x_mouse_leave): Declare only if WINDOWSNT.
7727 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7728 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7731 * ftxfont.c: Make symbols static if they're not exported.
7732 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7734 * font.h (ftxfont_driver): Likewise.
7736 * xfns.c: Make symbols static if they're not exported.
7737 (x_last_font_name, x_display_info_for_name):
7738 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7739 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7740 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7741 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7742 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7743 (last_show_tip_args): Now static.
7744 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7745 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7746 (x_screen_planes): Remove; unused.
7747 * dispextern.h (x_screen_planes): Remove decl.
7749 * dispnew.c: Make symbols static if they're not exported.
7750 * dispextern.h (redraw_garbaged_frames, scrolling):
7751 (increment_row_positions): Remove.
7752 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7753 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7755 (redraw_garbaged_frames): Remove; unused.
7757 * xfaces.c: Make symbols static if they're not exported.
7758 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7760 * xterm.h (defined_color): Remove decls.
7761 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7762 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7763 (menu_face_changed_default, defined_color, free_realized_face):
7764 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7765 (ascii_face_of_lisp_face): Remove; unused.
7767 * xdisp.c: Make symbols static if they're not exported.
7768 * dispextern.h (scratch_glyph_row, window_box_edges):
7769 (glyph_to_pixel_coords, set_cursor_from_row):
7770 (get_next_display_element, set_iterator_to_next):
7771 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7772 (show_mouse_face): Remove decls
7773 * frame.h (message_buf_print): Likewise.
7774 * lisp.h (pop_message, set_message, check_point_in_composition):
7776 * xterm.h (set_vertical_scroll_bar): Likewise.
7777 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7778 (message_buf_print, scratch_glyph_row, displayed_buffer):
7779 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7780 (get_next_display_element, show_mouse_face, window_box_edges):
7781 (frame_to_window_pixel_xy, check_point_in_composition):
7782 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7783 (glyph_to_pixel_coords): Remove; unused.
7785 * dired.c (file_name_completion): Now static.
7787 * dbusbind.c (xd_in_read_queued_messages): Now static.
7789 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7790 * data.c (circular_list_error): Remove.
7792 * commands.h (last_point_position, last_point_position_buffer):
7793 (last_point_position_window): Remove decls.
7794 * keyboard.c: Make these variables static.
7796 * coding.h (coding, code_convert_region, encode_coding_gap):
7798 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7799 (iso_code_class, detect_coding, code_convert_region): Now static.
7800 (encode_coding_gap): Remove; unused.
7802 * chartab.c (chartab_chars, chartab_bits): Now static.
7804 * charset.h (charset_iso_8859_1): Remove decl.
7805 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7808 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7809 * ccl.c (Vccl_program_table): Now static.
7810 (check_ccl_update): Remove; unused.
7812 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7813 * category.h: ... from here.
7814 * category.c (check_category_table, set_category_set): Now static.
7816 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7817 * lisp.h: Remove these decls.
7819 * buffer.c (buffer_count): Remove unused var.
7821 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7822 so that it's not optimized away.
7823 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7824 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7825 exported only to the debugger.
7827 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7828 * atimer.h (run_all_atimers): Remove; not exported.
7830 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7831 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7832 was inaccessible from Lisp.
7833 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7834 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7836 alloc.c: Import and export fewer symbols, and remove unused items.
7837 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7839 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7840 it's not optimized away by whole-program optimization.
7841 (message_enable_multibyte, free_misc): Remove.
7842 (catchlist, handlerlist, mark_backtrace):
7843 Declare only if BYTE_MARK_STACK.
7844 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7845 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7846 (message_enable_multibyte): Remove decl.
7847 (free_misc, interval_free_list, float_block, float_block_index):
7848 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7849 (cons_free_list, last_marked_index):
7851 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7852 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7853 (mark_backtrace): Define only if BYTE_MARK_STACK.
7854 * xdisp.c (message_enable_multibyte): Now static.
7856 Declare Lisp_Object Q* variables to be 'static' if not exported.
7857 This makes it easier for human readers (and static analyzers)
7858 to see whether these variables are used from other modules.
7859 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7860 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7861 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7862 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7863 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7864 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7865 * xmenu.c, xselect.c:
7866 Declare Q* vars static if they are not used in other modules.
7867 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7868 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7869 Remove decls of unexported vars.
7870 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7872 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7874 Make Emacs functions such as Fatom 'static' by default.
7875 This makes it easier for human readers (and static analyzers)
7876 to see whether these functions can be called from other modules.
7877 DEFUN now defines a static function. To make the function external
7878 so that it can be used in other C modules, use the new macro DEFUE.
7879 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7880 (Finit_image_library):
7881 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7882 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7883 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7884 Remove decls, since these functions are now static.
7885 (Funintern, Fget_internal_run_time): New decls, since these functions
7886 were already external.
7888 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7889 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7890 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7891 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7892 * keyboard.c, keymap.c, lread.c:
7893 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7894 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7895 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7896 Mark functions with DEFUE instead of DEFUN,
7897 if they are used in other modules.
7898 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7899 decls for now-static functions.
7900 * buffer.h (Fdelete_overlay): Remove decl.
7901 * callproc.c (Fgetenv_internal): Mark as internal.
7902 * composite.c (Fremove_list_of_text_properties): Remove decl.
7903 (Fcomposition_get_gstring): New forward static decl.
7904 * composite.h (Fcomposite_get_gstring): Remove decl.
7905 * dired.c (Ffile_attributes): New forward static decl.
7906 * doc.c (Fdocumntation_property): New forward static decl.
7907 * eval.c (Ffetch_bytecode): New forward static decl.
7908 (Funintern): Remove extern decl; now in .h file where it belongs.
7909 * fileio.c (Fmake_symbolic_link): New forward static decl.
7910 * image.c (Finit_image_library): New forward static decl.
7911 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7912 * intervals.h (Fprevious_property_change):
7913 (Fremove_list_of_text_properties): Remove decls.
7914 * keyboard.c (Fthis_command_keys): Remove decl.
7915 (Fcommand_execute): New forward static decl.
7916 * keymap.c (Flookup_key): New forward static decl.
7917 (Fcopy_keymap): Now static.
7918 * keymap.h (Flookup_key): Remove decl.
7919 * process.c (Fget_process): New forward static decl.
7920 (Fprocess_datagram_address): Mark as internal.
7921 * syntax.c (Fsyntax_table_p): New forward static decl.
7922 (skip_chars): Remove duplicate decl.
7923 * textprop.c (Fprevious_property_change): New forward static decl.
7924 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7926 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7927 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7929 * editfns.c (Fformat): Remove unreachable code.
7931 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7933 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7936 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7938 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7939 when at ZV. (Bug#8487)
7941 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7943 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7945 * keyboard.c (parse_tool_bar_item): Likewise.
7946 * sound.c (sound_cleanup, alsa_close): Likewise.
7947 * termcap.c (tgetent): Likewise.
7948 * xfns.c (x_default_font_parameter): Likewise.
7949 * xsettings.c (read_and_apply_settings): Likewise.
7951 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7952 (overrun_check_free): Protoize.
7954 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7956 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7957 since callers should never pass a negative size.
7958 Change the signature to match that of plain 'read' and 'write'; see
7959 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7960 * lisp.h: Update prototypes of emacs_write and emacs_read.
7962 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7964 * xdisp.c (redisplay_window): Don't try to determine the character
7965 position of the scroll margin if the window start point w->startp
7966 is outside the buffer's accessible region. (Bug#8468)
7968 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7970 Fix write-region and its subroutines for buffers > 2GB.
7971 * fileio.c (a_write, e_write): Modify declaration of arguments and
7972 local variables to support buffers larger than 2GB.
7973 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7975 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7976 argument, local variables, and return value.
7978 * lisp.h: Update prototypes of emacs_write and emacs_read.
7980 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7982 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7984 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7986 Fix more problems found by GCC 4.6.0's static checks.
7988 * xdisp.c (vmessage): Use a better test for character truncation.
7990 * charset.c (load_charset_map): <, not <=, for optimization,
7991 and to avoid potential problems with integer overflow.
7992 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7993 * casetab.c (set_identity, shuffle): Likewise.
7994 * editfns.c (Fformat): Likewise.
7995 * syntax.c (skip_chars): Likewise.
7997 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7998 This also lets GCC 4.6.0 generate slightly better loop code.
8000 * callint.c (Fcall_interactively): <, not <=, for optimization.
8001 (Fcall_interactively): Count the number of arguments produced,
8002 not the number of arguments given. This is simpler and lets GCC
8003 4.6.0 generate slightly better code.
8005 * ftfont.c: Distingish more carefully between FcChar8 and char.
8006 The previous code passed unsigned char * to a functions like
8007 strlen and xstrcasecmp that expect char *, which does not
8008 conform to the C standard.
8009 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8010 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8011 char * when the C standard requires it.
8013 * keyboard.c (read_char): Remove unused var.
8015 * eval.c: Port to Windows vsnprintf (Bug#8435).
8017 (SIZE_MAX): Define if the headers do not.
8018 (verror): Do not give up if vsnprintf returns a negative count.
8019 Instead, grow the buffer. This ports to Windows vsnprintf, which
8020 does not conform to C99. Problem reported by Eli Zaretskii.
8021 Also, simplify the allocation scheme, by avoiding the need for
8022 calling realloc, and removing the ALLOCATED variable.
8024 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8026 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8027 But keep the doprint source code for now, as we might revamp it
8028 and use it again (Bug#8435).
8029 * lisp.h (doprnt): Remove.
8030 * Makefile.in (base_obj): Remove doprnt.o.
8031 * deps.mk (doprnt.o): Remove.
8033 error: Print 32- and 64-bit integers portably (Bug#8435).
8034 Without this change, on typical 64-bit hosts error ("...%d...", N)
8035 was used to print both 32- and 64-bit integers N, which relied on
8037 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8038 * lisp.h (error, verror): Mark as printf-like functions.
8039 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8040 Report overflow in size calculations when allocating printf buffer.
8041 Do not truncate output string at its first null byte.
8042 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8043 Truncate the output at a character boundary, since vsnprintf does not
8045 * charset.c (check_iso_charset_parameter): Convert internal
8046 character to string before calling 'error', since %c now has the
8048 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8049 overflow when computing char to be passed to 'error'. Do not
8050 pass Lisp_Object to 'error'; pass the integer instead.
8051 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8052 formatted with plain %d.
8054 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8056 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8058 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8060 * xterm.c (x_catch_errors): Remove duplicate declaration.
8062 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8064 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8066 2011-04-10 Jim Meyering <meyering@redhat.com>
8068 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8069 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8070 return ssize_t not "int", and use size_t as the buffer length.
8071 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8072 * gnutls.h: Update declarations.
8073 * process.c (read_process_output): Use ssize_t, to match.
8074 (send_process): Likewise.
8076 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8078 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8080 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8082 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8083 Use unsigned char, to match FcChar8 type definition.
8085 * xterm.c (handle_one_xevent):
8086 * xmenu.c (create_and_show_popup_menu):
8087 * xselect.c (x_decline_selection_request)
8088 (x_reply_selection_request): Avoid type-punned deref of X events.
8090 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8092 Fix some uses of `int' instead of EMACS_INT.
8093 * search.c (string_match_1, fast_string_match)
8094 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8095 (scan_buffer, find_next_newline_no_quit)
8096 (find_before_next_newline, search_command, Freplace_match)
8097 (Fmatch_data): Make some `int' variables be EMACS_INT.
8099 * xdisp.c (display_count_lines): 3rd argument and return value now
8100 EMACS_INT. All callers changed.
8101 (pint2hrstr): Last argument is now EMACS_INT.
8103 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8104 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8105 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8106 (decode_coding_utf_16, decode_coding_emacs_mule)
8107 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8108 (decode_coding_ccl, decode_coding_charset)
8109 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8110 (decode_coding_iso_2022, decode_coding_emacs_mule)
8111 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8112 <char_offset, last_offset>: Declare EMACS_INT.
8113 (encode_coding_utf_8, encode_coding_utf_16)
8114 (encode_coding_emacs_mule, encode_invocation_designation)
8115 (encode_designation_at_bol, encode_coding_iso_2022)
8116 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8117 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8119 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8120 (encode_invocation_designation): Last argument P_NCHARS is now
8122 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8123 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8125 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8128 * ccl.c (Fccl_execute_on_string): Declare some variables
8131 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8133 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8135 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8137 * process.c (Fformat_network_address): Doc fix.
8139 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8141 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8143 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8145 * keyboard.c (read_char): Call Lisp function help-form-show,
8146 instead of using internal_with_output_to_temp_buffer.
8147 (Qhelp_form_show): New var.
8148 (syms_of_keyboard): Use DEFSYM macro.
8150 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8152 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8154 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8156 * process.c (Flist_processes): Remove to Lisp.
8157 (list_processes_1): Delete.
8159 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8161 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8163 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8165 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8167 Fix more problems found by GCC 4.6.0's static checks.
8169 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8171 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8173 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8175 * xdisp.c (vmessage): Mark as a printf-like function.
8177 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8179 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8181 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8182 printf-like functions.
8183 (tiff_load): Add casts to remove these marks before passing them
8184 to system-supplied API.
8186 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8188 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8189 This avoids several warnings with gcc -Wstrict-overflow.
8190 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8191 directly, rather than having caller test rule sign. This avoids
8192 some unnecessary tests.
8193 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8194 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8195 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8197 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8198 (xfont_open): Avoid unnecessary tests.
8200 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8202 * composite.h, composite.c (composition_gstring_put_cache):
8203 Use EMACS_INT, not int, for length.
8205 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8206 breaking out part of COMPOSITION_DECODE_RULE.
8207 (COMPOSITION_DECODE_RULE): Use it.
8208 * composite.c (get_composition_id): Remove unused local vars,
8209 by using the new macro.
8211 * textprop.c (set_text_properties_1): Change while to do-while,
8212 since the condition is always true at first.
8214 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8215 (interval_deletion_adjustment): Return unsigned value.
8218 * process.c (list_processes_1, create_pty, read_process_output):
8219 (exec_sentinel): Remove vars that were set but not used.
8220 (create_pty): Remove unnecessary "volatile"s.
8221 (Fnetwork_interface_info): Avoid possibility of int overflow.
8222 (read_process_output): Do adaptive read buffering even if carryover.
8223 (read_process_output): Simplify nbytes computation if buffered.
8225 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8227 * syntax.c (scan_words): Remove var that was set but not used.
8228 (update_syntax_table): Use unsigned instead of int.
8230 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8231 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8232 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8234 * print.c (print_error_message): Avoid int overflow.
8236 * font.c (font_list_entities): Redo for clarity,
8237 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8239 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8240 (font_score): Avoid potential overflow in diff calculation.
8242 * fns.c (substring_both): Remove var that is set but not used.
8243 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8245 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8247 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8248 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8249 can always succeed if overflow has undefined behavior.
8251 * search.c (boyer_moore, wordify): Remove vars set but not used.
8252 (wordify): Omit three unnecessary tests.
8254 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8255 All callers changed. This avoids the need for an unused var.
8257 * casefiddle.c (casify_region): Remove var that is set but not used.
8259 * dired.c (file_name_completion): Remove var that is set but not used.
8261 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8263 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8264 (Finsert_file_contents): Remove unnecessary code checking fd.
8266 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8267 Check for integer overflow on size calculations.
8269 * buffer.c (Fprevious_overlay_change): Remove var that is set
8272 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8273 Remove vars that are set but not used.
8274 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8275 (timer_check_2): Mark vars as initialized.
8277 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8279 * image.c (lookup_image): Remove var that is set but not used.
8280 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8282 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8283 that are set but not used.
8285 * xfns.c (make_invisible_cursor): Don't return garbage
8286 if XCreateBitmapFromData fails (Bug#8410).
8288 * xselect.c (x_get_local_selection, x_handle_property_notify):
8289 Remove vars that are set but not used.
8291 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8292 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8294 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8295 Remove var that is set but not used.
8296 (scroll_bar_windows_size): Now size_t, not int.
8297 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8300 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8301 (map_tty_color) [!defined MSDOS]: Likewise.
8303 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8305 * coding.c: Remove vars that are set but not used.
8306 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8307 All callers changed.
8308 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8309 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8310 (decode_coding_charset): Remove vars that are set but not used.
8312 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8313 that is set but not used.
8315 * print.c (print_object): Remove var that is set but not used.
8317 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8318 The gnulib version avoids calling malloc in the usual case,
8319 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8320 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8321 * filelock.c (current_lock_owner): Likewise.
8322 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8323 * sysdep.c: Include allocator.h, careadlinkat.h.
8324 (emacs_no_realloc_allocator): New static constant.
8325 (emacs_readlink): New function.
8326 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8327 ../lib/careadlinkat.h.
8329 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8331 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8332 first non-nil return value).
8334 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8336 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8337 if not defined (Bug#8403).
8339 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8341 * xdisp.c (display_count_lines): Remove parameter `start',
8342 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8343 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8344 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8345 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8346 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8347 and thereabouts. All callers changed.
8348 (get_per_char_metric): Remove parameter `f', unused since
8349 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8351 2011-04-02 Jim Meyering <meyering@redhat.com>
8353 do not dereference NULL upon failed strdup
8354 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8355 (ns_get_family): Likewise.
8357 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8359 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8361 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8363 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8366 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8368 Add lexical binding.
8370 * window.c (Ftemp_output_buffer_show): New fun.
8371 (Fsave_window_excursion):
8372 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8374 * lread.c (lisp_file_lexically_bound_p): New function.
8375 (Fload): Bind Qlexical_binding.
8376 (readevalloop): Remove `evalfun' arg.
8377 Bind Qinternal_interpreter_environment.
8378 (Feval_buffer): Bind Qlexical_binding.
8379 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8381 (syms_of_lread): Declare `lexical-binding'.
8383 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8385 * keyboard.c (eval_dyn): New fun.
8386 (menu_item_eval_property): Use it.
8388 * image.c (parse_image_spec): Use Ffunctionp.
8390 * fns.c (concat, mapcar1): Accept byte-code-functions.
8392 * eval.c (Fsetq): Handle lexical vars.
8393 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8394 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8395 (FletX, Flet): Obey lexical binding.
8396 (Fcommandp): Handle closures.
8397 (Feval): New `lexical' arg.
8398 (eval_sub): New function extracted from Feval. Use it almost
8399 everywhere where Feval was used. Look up vars in lexical env.
8401 (Ffunctionp): Move from subr.el.
8402 (Ffuncall): Handle closures.
8403 (apply_lambda): Remove `eval_flags'.
8404 (funcall_lambda): Handle closures and new byte-code-functions.
8405 (Fspecial_variable_p): New function.
8406 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8407 but without exporting it to Lisp.
8409 * doc.c (Fdocumentation, store_function_docstring):
8410 * data.c (Finteractive_form): Handle closures.
8412 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8415 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8417 (exec_byte_code): New function extracted from Fbyte_code to handle new
8418 calling convention for byte-code-functions. Add new byte-codes.
8420 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8422 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8424 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8426 * xdisp.c (redisplay_internal): Fix prototype.
8428 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8430 * xdisp.c (SCROLL_LIMIT): New macro.
8431 (try_scrolling): Use it when setting scroll_limit.
8432 Limit scrolling to 100 screen lines.
8433 (redisplay_window): Even when falling back on "recentering",
8434 position point in the window according to scroll-conservatively,
8435 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8437 (try_scrolling): When point is above the window, allow searching
8438 as far as scroll_max, or one screenful, to compute vertical
8439 distance from PT to the scroll margin position. This prevents
8440 try_scrolling from unnecessarily failing when
8441 scroll-conservatively is set to a value slightly larger than the
8442 window height. Clean up the case of PT below the margin at bottom
8443 of window: scroll_max can no longer be INT_MAX. When aggressive
8444 scrolling is in use, don't let point enter the opposite scroll
8445 margin as result of the scroll.
8446 (syms_of_xdisp) <scroll-conservatively>: Document the
8447 threshold of 100 lines for never-recentering scrolling.
8449 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8451 * dispextern.h (move_it_by_lines):
8452 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8453 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8454 (message_log_check_duplicate): Remove parameters `prev_bol' and
8455 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8456 (redisplay_internal): Remove parameter `preserve_echo_area',
8457 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8459 * indent.c (Fvertical_motion):
8460 * window.c (window_scroll_pixel_based, Frecenter):
8461 Don't pass `need_y_p' to `move_it_by_lines'.
8463 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8465 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8466 steal a few bits to be more compact.
8467 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8468 Remove unneeded casts.
8470 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8472 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8474 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8475 binding" message (bug#7967).
8477 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8479 Fix more problems found by GCC 4.6.0's static checks.
8481 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8482 Remove unused local var.
8484 * editfns.c (Fmessage_box): Remove unused local var.
8486 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8487 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8488 Omit unused local vars.
8489 * window.c (shrink_windows): Omit unused local var.
8490 * menu.c (digest_single_submenu): Omit unused local var.
8491 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8492 Omit unused local var.
8494 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8495 Don't assume string length fits in int.
8496 (keyremap_step, read_key_sequence): Use size_t for sizes.
8497 (read_key_sequence): Don't check last_real_key_start redundantly.
8499 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8500 instead of alloca (Bug#8344).
8502 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8503 (Fbacktrace_frame): Don't assume nframes fits in int.
8505 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8507 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8510 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8512 * cm.c (calccost): Turn while-do into do-while, for clarity.
8514 * keyboard.c (syms_of_keyboard): Use the same style as later
8515 in this function when indexing through an array. This also
8516 works around GCC bug 48267.
8518 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8520 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8522 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8523 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8525 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8526 This avoids undefined behavior on integer overflow, and is a bit
8527 more convenient anyway since it is compared to a size_t variable.
8529 Variadic C functions now count arguments with size_t, not int.
8530 This avoids an unnecessary limitation on 64-bit machines, which
8531 caused (substring ...) to crash on large vectors (Bug#8344).
8532 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8533 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8534 All variadic functions and their callers changed accordingly.
8535 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8536 * data.c (arith_driver, float_arith_driver): Likewise.
8537 * editfns.c (general_insert_function): Likewise.
8538 * eval.c (struct backtrace.nargs, interactive_p)
8539 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8540 (funcall_lambda, mark_backtrace): Likewise.
8541 * fns.c (concat): Likewise.
8542 * frame.c (x_set_frame_parameters): Likewise.
8543 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8544 0 if not found, not -1. All callers changed.
8546 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8547 (stack_copy_size): Now size_t, not int.
8548 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8550 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8552 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8553 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8554 All callers changed.
8556 * lisp.h (multibyte_char_to_unibyte):
8557 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8558 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8559 * character.h (CHAR_TO_BYTE8):
8560 * cmds.c (internal_self_insert):
8561 * editfns.c (general_insert_function):
8562 * keymap.c (push_key_description):
8563 * search.c (Freplace_match):
8564 * xdisp.c (message_dolog, set_message_1): All callers changed.
8566 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8568 * keyboard.c (safe_run_hook_funcall): New function.
8569 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8570 don't set the hook to nil, but remove the offending function instead.
8571 (Qcommand_hook_internal): Remove, unused.
8572 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8573 Vcommand_hook_internal.
8575 * eval.c (enum run_hooks_condition): Remove.
8576 (funcall_nil, funcall_not): New functions.
8577 (run_hook_with_args): Call each function through a `funcall' argument.
8578 Remove `cond' argument, now redundant.
8579 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8580 (Frun_hook_with_args_until_failure): Adjust accordingly.
8581 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8583 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8585 * dispextern.h (string_buffer_position): Remove declaration.
8587 * print.c (strout): Remove parameter `multibyte', unused since
8588 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8590 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8591 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8592 All callers changed.
8594 * w32.c (_wsa_errlist): Use braces for struct initializers.
8596 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8597 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8598 All callers changed.
8599 (string_buffer_position): Likewise. Also, make static (it's never
8600 used outside xdisp.c).
8601 (cursor_row_p): Remove parameter `w', unused since
8602 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8603 (decode_mode_spec): Remove parameter `precision', introduced during
8604 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8605 All callers changed.
8607 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8609 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8611 2011-03-27 Anders Lindgren <andlind@gmail.com>
8613 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8614 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8615 (ns_update_auto_hide_menu_bar): New functions.
8616 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8617 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8618 ns_constrain_all_frames.
8619 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8620 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8622 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8624 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8626 2011-03-27 Glenn Morris <rgm@gnu.org>
8628 * syssignal.h: Replace RETSIGTYPE with void.
8629 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8630 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8631 Replace SIGTYPE with void everywhere.
8632 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8633 * s/template.h (SIGTYPE): Remove commented out definition.
8635 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8637 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8638 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8640 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8642 * w32.c (read_unc_volume): Use parameter `henum', instead of
8643 global variable `wget_enum_handle'.
8645 * keymap.c (describe_vector): Remove parameters `indices' and
8646 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8647 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8649 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8651 * keyboard.c (timer_check): Remove parameter `do_it_now',
8652 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8653 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8654 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8656 * keyboard.c (read_char):
8657 * w32menu.c (w32_menu_display_help):
8658 * xmenu.c (show_help_event, menu_help_callback):
8659 Adjust calls to `show_help_echo'.
8661 * gtkutil.c (xg_maybe_add_timer):
8662 * keyboard.c (readable_events):
8663 * process.c (wait_reading_process_output):
8664 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8666 * insdel.c (adjust_markers_gap_motion):
8667 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8668 (gap_left, gap_right): Don't call it.
8670 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8672 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8673 incurred during fontification.
8675 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8677 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8678 (DEFVAR_PER_BUFFER): Don't pass it.
8680 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8681 (scrolling_window): Don't pass it.
8683 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8685 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8687 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8689 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8690 of variables specific to SELinux and computation of `encoded_absname'.
8692 * image.c (XPutPixel): Remove unused variable `height'.
8694 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8696 * unexw32.c (get_section_info): Remove unused variable `section'.
8698 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8699 (system_process_attributes): Remove unused variable `sess'.
8700 (sys_read): Remove unused variable `err'.
8702 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8703 (w32_wnd_proc): Remove unused variable `isdead'.
8704 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8705 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8706 (x_create_tip_frame): Remove unused variable `tem'.
8708 * w32inevt.c (w32_console_read_socket):
8709 Remove unused variable `no_events'.
8711 * w32term.c (x_draw_composite_glyph_string_foreground):
8712 Remove unused variable `width'.
8714 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8716 * w32term.c (x_set_glyph_string_clipping):
8717 Don't pass uninitialized region to CombineRgn.
8719 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8721 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8722 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8723 (Fx_close_connection): Remove unused variable `i'.
8725 * w32font.c (w32font_draw): Return number of glyphs.
8726 (w32font_open_internal): Remove unused variable `i'.
8727 (w32font_driver): Add missing initializer.
8729 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8730 (fill_in_menu): Remove unused variable `items_added'.
8732 * w32term.c (last_mouse_press_frame): Remove static global variable.
8733 (w32_clip_to_row): Remove unused variable `f'.
8734 (x_delete_terminal): Remove unused variable `i'.
8736 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8737 (NOTHING): Remove unused static global variable.
8738 (uniscribe_check_otf): Remove unused variable `table'.
8739 (uniscribe_font_driver): Add missing initializers.
8741 2011-03-23 Julien Danjou <julien@danjou.info>
8743 * term.c (Fsuspend_tty, Fresume_tty):
8744 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8745 * window.c (temp_output_buffer_show):
8746 * insdel.c (signal_before_change):
8747 * frame.c (Fhandle_switch_frame):
8748 * fileio.c (Fdo_auto_save):
8749 * emacs.c (Fkill_emacs):
8750 * editfns.c (save_excursion_restore):
8751 * cmds.c (internal_self_insert):
8752 * callint.c (Fcall_interactively):
8753 * buffer.c (Fkill_all_local_variables):
8754 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8756 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8757 unconditionally since it does the check itself.
8759 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8761 Fix more problems found by GCC 4.5.2's static checks.
8763 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8764 the first time through the loop, since we know p0 < p1 then.
8765 This also avoids a gcc -Wstrict-overflow warning.
8767 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8768 leading to a memory leak, possible in functions like
8769 load_charset_map_from_file that can allocate an unbounded number
8770 of objects (Bug#8318).
8772 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8773 that could (at least in theory) be that large.
8775 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8776 This is less likely to overflow, and avoids undefined behavior if
8777 overflow does occur. All callers changed. Use strtoul to scan
8778 for the unsigned long integer.
8779 (pint2hrstr): Simplify and tune code slightly.
8780 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8782 * scroll.c (do_scrolling): Work around GCC bug 48228.
8783 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8785 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8786 This also avoids a warning with gcc -Wstrict-overflow.
8787 (validate_x_resource_name): Simplify count usage.
8788 This also avoids a warning with gcc -Wstrict-overflow.
8790 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8793 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8795 * process.c (Fmake_network_process): Use socklen_t, not int,
8796 where POSIX says socklen_t is required in portable programs.
8797 This fixes a porting bug on hosts like 64-bit HP-UX, where
8798 socklen_t is wider than int (Bug#8277).
8799 (Fmake_network_process, server_accept_connection):
8800 (wait_reading_process_output, read_process_output):
8803 * process.c: Rename or move locals to avoid shadowing.
8804 (list_processes_1, Fmake_network_process):
8805 (read_process_output_error_handler, exec_sentinel_error_handler):
8806 Rename or move locals.
8807 (Fmake_network_process): Define label "retry_connect" only if needed.
8808 (Fnetwork_interface_info): Fix pointer signedness.
8809 (process_send_signal): Add cast to avoid pointer signedness problem.
8810 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8811 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8813 Make tparam.h and terminfo.c consistent.
8814 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8815 Include tparam.h instead, since it declares them.
8816 * cm.h (PC): Remove extern decl; tparam.h now does this.
8817 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8818 * terminfo.c: Include tparam.h, to check interfaces.
8819 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8820 (tparam): Adjust signature to match interface in tparam.h;
8821 this removes some undefined behavior. Check that outstring and len
8822 are zero, which they always are with Emacs.
8823 * tparam.h (PC, BC, UP): New extern decls.
8825 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8826 (xftfont_open): Rename locals to avoid shadowing.
8828 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8829 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8830 (OTF_TAG_SYM): Omit macro if not needed.
8831 (ftfont_list): Remove unused local.
8832 (get_adstyle_property, ftfont_pattern_entity):
8833 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8834 Rename locals to avoid shadowing.
8836 * xfont.c (xfont_list_family): Mark var as initialized.
8838 * xml.c (make_dom): Now static.
8840 * composite.c (composition_compute_stop_pos): Rename local to
8842 (composition_reseat_it): Remove unused locals.
8843 (find_automatic_composition, composition_adjust_point): Likewise.
8844 (composition_update_it): Mark var as initialized.
8845 (find_automatic_composition): Mark vars as initialized,
8846 with a FIXME (Bug#8290).
8848 character.h: Rename locals to avoid shadowing.
8849 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8850 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8851 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8852 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8855 * textprop.c (property_change_between_p): Remove; unused.
8857 * intervals.c (interval_start_pos): Now static.
8859 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8861 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8862 Rename locals to avoid shadowing.
8864 * sound.c (wav_play, au_play, Fplay_sound_internal):
8865 Fix pointer signedness.
8866 (alsa_choose_format): Remove unused local var.
8867 (wav_play): Initialize a variable to 0, to prevent undefined
8868 behavior (Bug#8278).
8870 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8872 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8874 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8875 clobbering (Bug#8298).
8876 * sysdep.c (sys_subshell): Likewise.
8877 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8879 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8880 This should get cleaned up, so that child_setup has the
8881 same signature on all platforms.
8883 * callproc.c (call_process_cleanup): Now static.
8884 (relocate_fd): Rename locals to avoid shadowing.
8886 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8888 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8889 not to be necessary, and produces flickering.
8891 2011-03-20 Glenn Morris <rgm@gnu.org>
8893 * config.in: Remove file.
8895 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8897 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8898 are now in src/globals.h.
8899 (syms_of_minibuf): Remove spurious & from previous change.
8901 2011-03-20 Leo Liu <sdl.web@gmail.com>
8903 * minibuf.c (completing-read-function): New variable.
8904 (completing-read-default): Rename from completing-read.
8905 (completing-read): Call completing-read-function.
8907 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8909 * xfaces.c (Fx_load_color_file):
8910 Read color file from absolute filename (bug#8250).
8912 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8914 * makefile.w32-in: Update dependencies.
8916 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8918 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8920 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8922 Fix more problems found by GCC 4.5.2's static checks.
8924 * process.c (make_serial_process_unwind, send_process_trap):
8925 (sigchld_handler): Now static.
8927 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8928 That way, the code declares only the vars that it needs.
8929 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8930 * s/cygwin.h (PTY_ITERATION): Likewise.
8931 * s/darwin.h (PTY_ITERATION): Likewise.
8932 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8934 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8935 * process.c (allocate_pty): Don't declare stb unless it's needed.
8937 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8938 (CONSTANTLIM): Remove; unused.
8939 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8940 Define only if needed.
8942 * unexelf.c (unexec): Name an expression,
8943 to avoid gcc -Wbad-function-cast warning.
8944 Use a different way to cause a compilation error if anyone uses
8945 n rather than nn, a way that does not involve shadowing.
8946 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8948 * deps.mk (unexalpha.o): Remove; unused.
8950 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8951 * unexec.h: New file.
8952 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8953 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8955 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8956 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8957 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8958 Change as necessary to match prototype in unexec.h.
8960 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8962 (back_comment, skip_chars): Mark vars as initialized.
8964 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8965 Rename locals to avoid shadowing.
8967 * lread.c (read1): Rewrite so as not to use empty "else".
8968 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8970 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8972 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8973 warning when compiling print.c.
8975 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8976 instead of using an uninitialized var.
8977 (font_sort_entities): Mark var as initialized.
8979 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8981 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8982 pointers to constants.
8983 (font_parse_fcname): Remove unused vars.
8984 (font_delete_unmatched): Now static.
8985 (font_get_spec): Remove; unused.
8986 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8987 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8988 Rename or move locals to avoid shadowing.
8990 * fns.c (require_nesting_list, require_unwind): Now static.
8991 (Ffillarray): Rename locals to avoid shadowing.
8993 * floatfns.c (domain_error2): Define only if needed.
8994 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8996 * alloc.c (mark_backtrace): Move decl from here ...
8997 * lisp.h: ... to here, so that it can be checked.
8999 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9000 (Fdefvar): Rewrite so as not to use empty "else".
9001 (lisp_indirect_variable): Name an expression,
9002 to avoid gcc -Wbad-function-cast warning.
9003 (Fdefvar): Rename locals to avoid shadowing.
9005 * callint.c (quotify_arg, quotify_args): Now static.
9006 (Fcall_interactively): Rename locals to avoid shadowing.
9007 Use const pointer when appropriate.
9009 * lisp.h (get_system_name, get_operating_system_release):
9010 Move decls here, to check interfaces.
9011 * process.c (get_operating_system_release): Move decl to lisp.h.
9012 * xrdb.c (get_system_name): Likewise.
9013 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9014 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9015 some of which prompt warnings from gcc -Wbad-function-cast.
9016 (Fformat_time_string, Fencode_time, Finsert_char):
9017 (Ftranslate_region_internal, Fformat):
9018 Rename or remove local vars to avoid shadowing.
9019 (Ftranslate_region_internal): Mark var as initialized.
9021 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9024 * lisp.h (eassert): Check that the argument compiles, even if
9025 ENABLE_CHECKING is not defined.
9027 * data.c (Findirect_variable): Name an expression, to avoid
9028 gcc -Wbad-function-cast warning.
9029 (default_value, arithcompare, arith_driver, arith_error): Now static.
9030 (store_symval_forwarding): Rename local to avoid shadowing.
9031 (Fmake_variable_buffer_local, Fmake_local_variable):
9032 Mark variables as initialized.
9033 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9035 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9036 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9037 Rename locals to avoid shadowing.
9038 (mark_stack): Move local variables into the #ifdef region where
9040 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9041 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9043 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9044 (GC_STRING_CHARS): Remove; not used.
9045 (Fmemory_limit): Cast sbrk's returned value to char *.
9047 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9048 avoids undefined behavior in theory.
9050 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9052 Use functions, not macros, for up- and down-casing (Bug#8254).
9053 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9054 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9055 to use the following functions instead of these macros.
9056 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9057 EMACS_INT, since callers assume the returned value fits in int.
9058 (upcase1): Likewise, for UPCASE_TABLE.
9059 (uppercasep, lowercasep, upcase): New static inline functions.
9060 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9061 the race-condition problem in the old DOWNCASE.
9063 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9064 Rename locals to avoid shadowing.
9065 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9066 (regex_compile, re_search_2, re_match_2_internal):
9067 Remove unused local vars.
9068 (FREE_VAR): Rewrite so as not to use empty "else",
9069 which gcc can warn about.
9070 (regex_compile, re_match_2_internal): Mark locals as initialized.
9071 (RETALLOC_IF): Define only if needed.
9072 (WORDCHAR_P): Likewise. This one is never needed, but is used
9073 only in a comment talking about a compiler bug, so put inside
9074 the #if 0 of that comment.
9075 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9076 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9079 * search.c (boyer_moore): Rename locals to avoid shadowing.
9080 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9081 (PREV_CHAR_BOUNDARY): Likewise.
9083 * search.c (simple_search): Remove unused var.
9085 * dired.c (compile_pattern): Move decl from here ...
9086 * lisp.h: ... to here, so that it can be checked.
9087 (struct re_registers): New forward decl.
9089 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9091 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9093 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9094 Rename locals to avoid shadowing.
9095 (Fvertical_motion): Mark locals as initialized.
9097 * casefiddle.c (casify_object, casify_region): Now static.
9098 (casify_region): Mark local as initialized.
9100 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9102 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9103 New macros, so that the caller can use some names other than
9104 gcpro1, gcpro2, etc.
9105 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9107 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9108 argument, for consistency with GCPRO2_VAR, etc: it is now the
9109 prefix of the variable, not the variable itself. All uses
9111 * dired.c (directory_files_internal, file_name_completion):
9112 Rename locals to avoid shadowing.
9114 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9115 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9116 dired.c's scmp function, had undefined behavior.
9117 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9118 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9119 * buffer.h: ... to here, because these macros use current_buffer,
9120 and the new implementation with inline functions needs to have
9121 current_buffer in scope now, rather than later when the macros
9123 (downcase, upcase1): New static inline functions.
9124 (DOWNCASE, UPCASE1): Reimplement using these functions.
9125 This avoids undefined behavior in expressions like
9126 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9127 from race conditions in accessing the global variables
9128 case_temp1 and case_temp2.
9129 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9130 * lisp.h (case_temp1, case_temp2): Remove their decls.
9131 * character.h (ASCII_CHAR_P): Move from here ...
9132 * lisp.h: ... to here, so that the inline functions mentioned
9135 * dired.c (directory_files_internal_unwind): Now static.
9137 * fileio.c (file_name_as_directory, directory_file_name):
9138 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9140 (file_name_as_directory): Use const pointers when appropriate.
9141 (Fexpand_file_name): Likewise. In particular, newdir might
9142 point at constant storage, so make it a const pointer.
9143 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9144 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9146 (Fset_file_times, Finsert_file_contents, auto_save_error):
9147 Rename locals to avoid shadowing.
9149 * minibuf.c (choose_minibuf_frame_1): Now static.
9150 (Ftry_completion, Fall_completions): Rename or remove locals
9153 * marker.c (bytepos_to_charpos): Remove; unused.
9155 * lisp.h (verify_bytepos, count_markers): New decls,
9156 so that gcc does not warn that these functions aren't declared.
9158 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9159 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9160 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9161 (copy_text): Remove unused local var.
9163 * filelock.c (within_one_second): Now static.
9164 (lock_file_1): Rename local to avoid shadowing.
9166 * buffer.c (fix_overlays_before): Mark locals as initialized.
9167 (fix_start_end_in_overlays): Likewise. This function should be
9168 simplified by using pointers-to-pointers, but that's a different
9170 (switch_to_buffer_1): Now static.
9171 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9172 (report_overlay_modification): Rename locals to avoid shadowing.
9174 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9175 Fix pointer signedness issue.
9176 (sys_subshell): Mark local as volatile if checking for lint,
9177 to suppress a gcc -Wclobbered warning that does not seem to be right.
9178 (MAXPATHLEN): Define only if needed.
9180 * process.c (serial_open, serial_configure): Move decls from here ...
9181 * systty.h: ... to here, so that they can be checked.
9183 * fns.c (get_random, seed_random): Move extern decls from here ...
9184 * lisp.h: ... to here, so that they can be checked.
9186 * sysdep.c (reset_io): Now static.
9187 (wait_for_termination_signal): Remove; unused.
9189 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9190 (copy_keymap_item, append_key, push_text_char_description):
9192 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9193 (DENSE_TABLE_SIZE): Remove; unused.
9194 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9195 (describe_map_tree):
9196 Rename locals to avoid shadowing.
9198 * keyboard.c: Declare functions static if they are not used elsewhere.
9199 (echo_char, echo_dash, cmd_error, top_level_2):
9200 (poll_for_input, handle_async_input): Now static.
9201 (read_char, kbd_buffer_get_event, make_lispy_position):
9202 (make_lispy_event, make_lispy_movement, apply_modifiers):
9203 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9204 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9205 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9206 (read_key_sequence, read_char): Mark locals as initialized.
9207 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9209 * keyboard.h (make_ctrl_char): New decl.
9210 (mark_kboards): Move decl here ...
9211 * alloc.c (mark_kboards): ... from here.
9213 * lisp.h (force_auto_save_soon): New decl.
9215 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9216 (DEFINE_DUMMY_FUNCTION): New macro.
9217 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9219 (main): Add casts to avoid warnings
9220 if GCC considers string literals to be constants.
9222 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9224 * dbusbind.c: Pointer signedness fixes.
9225 (xd_signature, xd_append_arg, xd_initialize):
9226 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9227 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9228 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9229 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9231 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9232 if GCC considers string literals to be constants.
9233 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9235 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9237 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9238 (print_preprocess, print_object): New macro to fix last change.
9240 * print.c (print_preprocess): Don't forget font objects.
9242 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9244 * emacs.c (USAGE3): Doc fixes.
9246 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9248 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9251 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9253 * lisp.h (VWindow_system, Qfile_name_history):
9254 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9255 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9256 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9258 * w32select.c: Don't #include "keyboard.h".
9259 (run_protected): Add extern declaration for waiting_for_input.
9261 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9262 * w32console.c (detect_input_pending, read_input_pending)
9263 (encode_terminal_code):
9264 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9265 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9266 (w32_system_caret_y, Qfile_name_history):
9267 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9268 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9269 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9270 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9271 * w32proc.c (Qlocal, report_file_error):
9272 * w32term.c (Vwindow_system, updating_frame):
9273 * w32uniscribe.c (initialized, uniscribe_font_driver):
9274 Remove unneeded extern declarations.
9276 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9278 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9280 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9282 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9283 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9284 These macros can no longer be used for assignment.
9286 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9287 Assign struct members directly, instead of using BUF_BEGV etc.
9288 (record_buffer_markers, fetch_buffer_markers): New functions for
9289 recording and fetching special buffer markers.
9290 (set_buffer_internal_1, set_buffer_temp): Use them.
9292 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9294 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9296 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9297 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9299 * xdisp.c (hscroll_window_tree):
9300 (reconsider_clip_changes): Use PT instead of BUF_PT.
9302 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9304 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9305 $(EMACS_ROOT)/lib/intprops.h.
9307 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9309 Fix more problems found by GCC 4.5.2's static checks.
9311 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9312 to unsigned char * to avoid compiler diagnostic.
9313 (xg_free_frame_widgets): Make it clear that a local variable is
9314 needed only if USE_GTK_TOOLTIP.
9315 (gdk_window_get_screen): Make it clear that this macro is needed
9316 only if USE_GTK_TOOLTIP.
9317 (int_gtk_range_get_value): New function, which avoids a diagnostic
9318 from gcc -Wbad-function-cast.
9319 (xg_set_toolkit_scroll_bar_thumb): Use it.
9320 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9321 diagnostic from gcc -Wbad-function-cast.
9322 (get_utf8_string, xg_get_file_with_chooser):
9323 Rename locals to avoid shadowing.
9324 (create_dialog): Move locals to avoid shadowing.
9326 * xgselect.c (xg_select): Remove unused var.
9328 * image.c (four_corners_best): Mark locals as initialized.
9329 (gif_load): Initialize transparent_p to zero (Bug#8238).
9330 Mark another local as initialized.
9331 (my_png_error, my_error_exit): Mark with NO_RETURN.
9333 * image.c (clear_image_cache): Now static.
9334 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9335 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9336 (x_edge_detection): Remove unnecessary cast that
9337 gcc -Wbad-function-cast diagnoses.
9338 (gif_load): Fix pointer signedness.
9339 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9340 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9342 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9344 Improve quality of tests for time stamp overflow.
9345 For example, without this patch (encode-time 0 0 0 1 1
9346 1152921504606846976) returns the obviously-bogus value (-948597
9347 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9348 reports time overflow. See
9349 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9350 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9351 * editfns.c: Include limits.h and intprops.h.
9352 (TIME_T_MIN, TIME_T_MAX): New macros.
9353 (time_overflow): Move earlier, to before first use.
9354 (hi_time, lo_time): New functions, for an accurate test for
9356 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9357 (Fget_internal_run_time): Don't assume time_t fits in int.
9358 (make_time): Use list2 instead of Fcons twice.
9359 (Fdecode_time): More accurate test for out-of-range times.
9360 (check_tm_member): New function.
9361 (Fencode_time): Use it, to test for out-of-range times.
9362 (lisp_time_argument): Don't rely on undefined left-shift and
9363 right-shift behavior when checking for time stamp overflow.
9365 * editfns.c (time_overflow): New function, refactoring common code.
9366 (Fformat_time_string, Fdecode_time, Fencode_time):
9367 (Fcurrent_time_string): Use it.
9369 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9370 * dired.c (make_time): Move to ...
9371 * editfns.c (make_time): ... here.
9372 * systime.h: Note the move.
9374 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9376 * fringe.c (update_window_fringes): Remove unused variables.
9378 * unexmacosx.c (copy_data_segment): Also copy __got section.
9381 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9383 * termcap.c [MSDOS]: Include "msdos.h".
9384 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9385 Constify `char *' arguments and their references according to
9386 prototypes in tparam.h.
9388 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9390 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9391 Adapt all references accordingly.
9393 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9395 2011-03-11 Tom Tromey <tromey@redhat.com>
9397 * buffer.c (syms_of_buffer): Remove obsolete comment.
9399 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9401 * termhooks.h (encode_terminal_code): Declare prototype.
9403 * msdos.c (encode_terminal_code): Don't declare prototype.
9405 * term.c (encode_terminal_code): Now external again, used by
9406 w32console.c and msdos.c.
9408 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9409 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9411 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9413 Fix some minor problems found by GCC 4.5.2's static checks.
9415 * fringe.c (update_window_fringes): Mark locals as initialized
9417 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9419 * alloc.c (mark_fringe_data): Move decl from here ...
9420 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9421 to check its interface.
9422 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9424 * fontset.c (free_realized_fontset): Now static.
9425 (Fset_fontset_font): Rename local to avoid shadowing.
9426 (fontset_font): Mark local as initialized.
9427 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9429 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9431 * xselect.c (x_disown_buffer_selections): Remove; not used.
9432 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9433 (x_own_selection, Fx_disown_selection_internal): Rename locals
9435 (x_handle_dnd_message): Remove local to avoid shadowing.
9437 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9438 so that the caller can use some name other than gcpro1.
9439 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9440 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9441 (Fx_backspace_delete_keys_p):
9442 Use them to avoid shadowing, and rename vars to avoid shadowing.
9443 (x_decode_color, x_set_name, x_window): Now static.
9444 (Fx_create_frame): Add braces to silence GCC warning.
9445 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9446 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9447 Remove unused locals.
9448 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9449 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9450 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9453 * xterm.h (x_mouse_leave): New decl.
9455 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9456 Remove unused functions.
9457 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9458 (x_calc_absolute_position): Now static.
9459 (XTread_socket): Don't define label "out" unless it's used.
9460 Don't declare local "event" unless it's used.
9461 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9462 unless they are used.
9463 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9464 (x_fatal_error_signal): Remove; not used.
9465 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9466 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9467 (x_error_catcher, x_connection_closed, x_error_handler):
9468 (x_error_quitter, xembed_send_message, x_iconify_frame):
9469 (my_log_handler): Rename locals to avoid shadowing.
9470 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9471 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9473 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9474 Rename or move locals to avoid shadowing.
9475 (tty_defined_color, merge_face_heights): Now static.
9476 (free_realized_faces_for_fontset): Remove; not used.
9477 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9478 does not deduce is never used uninitialized.
9479 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9480 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9482 * terminal.c (store_terminal_param): Now static.
9484 * xmenu.c (menu_highlight_callback): Now static.
9485 (set_frame_menubar): Remove unused local.
9486 (xmenu_show): Rename parameter to avoid shadowing.
9487 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9488 since they might point to immutable storage.
9489 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9490 since it's unused otherwise.
9492 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9493 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9494 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9495 avoids a gcc -Wuninitialized diagnostic.
9496 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9497 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9498 does not deduce are never used uninitialized.
9500 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9502 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9503 * window.c (window_loop, size_window):
9504 (run_window_configuration_change_hook, enlarge_window): Likewise.
9506 * window.c (display_buffer): Now static.
9507 (size_window): Mark variables that gcc -Wuninitialized
9508 does not deduce are never used uninitialized.
9509 * window.h (check_all_windows): New decl, to forestall
9510 gcc -Wmissing-prototypes diagnostic.
9511 * dispextern.h (bidi_dump_cached_states): Likewise.
9513 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9515 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9517 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9518 and to avoid gcc -Wuninitialized warning.
9519 (load_charset_map): Mark variables that gcc -Wuninitialized
9520 does not deduce are never used uninitialized.
9521 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9523 * coding.c (coding_set_source, coding_set_destination):
9524 Use "else { /* comment */ }" rather than "else /* comment */;"
9525 for clarity, and to avoid gcc -Wempty-body warning.
9526 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9527 a block, when the outer 'i' will do.
9528 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9529 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9530 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9531 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9532 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9533 Rename locals to avoid shadowing.
9534 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9535 * coding.c (emacs_mule_char, encode_invocation_designation):
9536 Now static, since they're not used elsewhere.
9537 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9538 (decode_coding_object, encode_coding_object, detect_coding_system):
9539 (decode_coding_emacs_mule): Mark variables that gcc
9540 -Wuninitialized does not deduce are never used uninitialized.
9541 (detect_coding_iso_2022): Initialize a local variable that might
9542 be used uninitialized. Leave a FIXME because it's not clear that
9543 this initialization is needed. (Bug#8211)
9544 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9545 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9546 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9547 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9548 Remove unused macros.
9550 * category.c (hash_get_category_set): Remove unused local var.
9551 (copy_category_table): Now static, since it's not used elsewhere.
9552 * character.c (string_count_byte8): Likewise.
9554 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9555 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9557 * chartab.c (copy_sub_char_table): Now static, since it's not used
9559 (sub_char_table_ref_and_range, char_table_ref_and_range):
9560 Rename locals to avoid shadowing.
9561 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9563 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9564 (BIDI_BOB): Remove unused macro.
9566 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9567 deduce are never used uninitialized.
9568 * term.c (encode_terminal_code): Likewise.
9570 * term.c (encode_terminal_code): Now static. Remove unused local.
9572 * tparam.h: New file.
9573 * term.c, tparam.h: Include it.
9574 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9575 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9576 Move these decls to tparam.h, and make them agree with what
9577 is actually in tparam.c. The previous trick of using incompatible
9578 decls in different modules does not conform to the C standard.
9579 All callers of tparam changed to use tparam's actual API.
9580 * tparam.c (tparam1, tparam, tgoto):
9581 Use const pointers where appropriate.
9583 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9584 * cm.h (struct cm): Likewise.
9585 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9586 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9587 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9588 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9589 (turn_on_face, init_tty): Likewise.
9590 * termchar.h (struct tty_display_info): Likewise.
9592 * term.c (term_mouse_position): Rename local to avoid shadowing.
9594 * alloc.c (mark_ttys): Move decl from here ...
9595 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9597 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9599 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9601 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9603 * search.c (compile_pattern_1): Remove argument regp, unused since
9604 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9605 (compile_pattern): Don't pass it.
9607 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9609 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9610 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9612 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9614 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9616 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9617 gdk_window_get_screen, gdk_window_get_geometry,
9618 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9619 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9620 (xg_get_pixbuf_from_pixmap): New function.
9621 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9622 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9623 Call xg_get_pixbuf_from_pixmap instead of
9624 gdk_pixbuf_get_from_drawable.
9625 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9626 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9627 (xg_check_special_colors): Use GtkStyleContext and its functions
9629 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9630 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9631 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9632 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9633 Call gtk_widget_get_preferred_size.
9634 (xg_frame_resized): gdk_window_get_geometry only takes 5
9636 (xg_win_to_widget, xg_event_is_for_menubar):
9637 Call gdk_x11_window_lookup_for_display.
9638 (xg_set_widget_bg): New function.
9639 (delete_cb): New function.
9640 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9641 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9642 (xg_set_background_color): Call xg_set_widget_bg.
9643 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9644 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9645 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9646 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9648 (update_frame_tool_bar): Call gtk_widget_hide.
9649 (xg_initialize): Use GDK_KEY_g.
9651 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9653 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9655 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9656 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9657 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9659 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9661 * w32xfns.c (select_palette): Check success of RealizePalette against
9662 GDI_ERROR, not zero.
9664 See ChangeLog.11 for earlier changes.
9670 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9672 This file is part of GNU Emacs.
9674 GNU Emacs is free software: you can redistribute it and/or modify
9675 it under the terms of the GNU General Public License as published by
9676 the Free Software Foundation, either version 3 of the License, or
9677 (at your option) any later version.
9679 GNU Emacs is distributed in the hope that it will be useful,
9680 but WITHOUT ANY WARRANTY; without even the implied warranty of
9681 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9682 GNU General Public License for more details.
9684 You should have received a copy of the GNU General Public License
9685 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.