1 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3 * w32.c (sys_rename): Report EXDEV when rename of a directory
4 fails because the target is on another logical disk. (Bug#10284)
6 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8 * xterm.c (x_embed_request_focus): New function.
10 * xterm.h: Add prototype.
12 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
14 2012-01-05 Glenn Morris <rgm@gnu.org>
16 * emacs.c (emacs_copyright): Update short copyright year to 2012.
18 2012-01-01 Eli Zaretskii <eliz@gnu.org>
20 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
21 Load gnutls_transport_set_lowat only if GnuTLS version is below
23 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
24 GnuTLS versions below 2.11.1.
26 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
28 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
29 to the doc string advising against its use for altering the way
32 2011-12-28 Kenichi Handa <handa@m17n.org>
34 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
35 coding-system ASCII compatible only when it does not produce BOM
36 on encoding (Bug#10383).
38 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
40 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
42 (create_and_show_popup_menu): Always use menu_position_func for
45 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
47 * callint.c (Fcall_interactively): Don't truncate prompt string.
49 2011-12-23 Eli Zaretskii <eliz@gnu.org>
51 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
52 property that ends at ZV, so that the bidi iteration could be
53 resumed from there (after widening). (Bug#10360)
55 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
57 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
59 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
61 * nsterm.m (x_free_frame_resources):
62 Release f->output_data.ns->miniimage.
63 (ns_index_color): Fix indentation. Do not retain
64 color_table->colors[i].
66 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
69 * nsfns.m (x_set_background_color): Assign return value from
70 ns_index_color to face-background instead of NSColor*.
71 (ns_implicitly_set_icon_type): Fix indentation.
72 Change assignment in for loop to comparison.
74 * emacs.c (ns_pool): New variable.
75 (main): Assign ns_pool.
76 (Fkill_emacs): Call ns_release_autorelease_pool.
78 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
79 autorelease fdesc, release fdAttrs and tdict.
80 (ns_get_covering_families): Release charset.
81 (ns_findfonts): Release NSFontDescriptor created with new.
82 (ns_uni_to_glyphs): Fix indentation.
83 (setString): Release attrStr before assigning new value.
85 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
87 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
89 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
90 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
92 2011-12-18 David Reitter <reitter@cmu.edu>
94 * nsterm.m (ns_term_init): Subscribe for notifications
95 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
96 to method trackingNotification in EmacsMenu.
98 * nsmenu.m (trackingMenu): New variable.
99 (trackingNotification): New method (from Aquamacs).
100 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
101 from Aquamacs (Bug#7030).
103 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
105 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
106 (symbol_to_nsstring): Fix indentation.
107 (ns_symbol_to_pb): New function.
108 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
109 (Fns_rotate_cut_buffers_internal): Removed.
110 (Fns_store_selection_internal): Renamed from
111 Fns_store_cut_buffer_internal.
112 (ns_get_foreign_selection, Fx_own_selection_internal)
113 (Fx_disown_selection_internal, Fx_selection_exists_p)
114 (Fns_get_selection_internal, Fns_store_selection_internal):
115 Use ns_symbol_to_pb and check if return value is nil.
116 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
117 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
118 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
119 renamed to Sns_store_selection_internal.
120 (ns_handle_selection_request): Move code to Fx_own_selection_internal
121 and remove this function.
122 (ns_handle_selection_clear): Remove, never used.
123 (Fx_own_selection_internal): Move code from ns_handle_selection_request
126 2011-12-17 Ken Brown <kbrown@cornell.edu>
128 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
129 GID is unknown (Bug#10257).
131 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
133 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
134 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
135 which caused a build failure on GNU/Linux IA-64. This problem was
136 introduced by my 2011-10-07 patch.
138 2011-12-15 Juri Linkov <juri@jurta.org>
140 * image.c (imagemagick_error): New function. (Bug#10112)
141 (imagemagick_load_image): Comment out `MagickSetResolution' call.
142 Use `imagemagick_error' where ImageMagick functions return
144 (Fimagemagick_types): Add `Fnreverse' to return the list in the
147 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
149 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
150 fill background (Bug#8992).
152 2011-12-13 Martin Rudalics <rudalics@gmx.at>
154 * window.c (Vwindow_combination_resize)
155 (Vwindow_combination_limit): Use t instead of non-nil in
157 (Vrecenter_redisplay): Add first sentence of doc-string on
159 (Frecenter): Fix doc-string typo.
161 2011-12-11 Kenichi Handa <handa@m17n.org>
163 * coding.c (Funencodable_char_position): Pay attention to the
164 buffer text relocation (Bug#9389).
166 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
168 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
169 gtk_init (Bug#10100).
171 2011-12-10 Eli Zaretskii <eliz@gnu.org>
173 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
174 IT->string is nil. (Bug#10263)
176 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
178 * nsterm.h (x_free_frame_resources): Declare.
180 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
181 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
183 * nsterm.h (ns_get_defaults_value): Declare.
185 * nsterm.m (ns_default): Call ns_get_defaults_value.
187 2011-12-09 Eli Zaretskii <eliz@gnu.org>
189 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
192 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
194 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
195 that where the value of an _OBJC_* symbol points to is in the .bss
198 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
200 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
201 after the loop to call ccl_driver at least once (Bug#8619).
203 2011-12-08 Kenichi Handa <handa@m17n.org>
205 * ftfont.c (get_adstyle_property): Fix previous change
208 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
210 * w32.c (init_environment): If no_site_lisp, remove site-lisp
211 dirs from the default value of EMACSLOADPATH (bug#10208).
213 2011-12-07 Glenn Morris <rgm@gnu.org>
215 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
216 installation and source directories as well. (Bug#10208)
218 2011-12-06 Chong Yidong <cyd@gnu.org>
220 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
222 2011-12-06 Glenn Morris <rgm@gnu.org>
224 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
225 as an error, not just -1. (Bug#10217)
227 2011-12-05 Chong Yidong <cyd@gnu.org>
229 * keyboard.c (process_special_events): New function.
230 (swallow_events, Finput_pending_p): Use it (Bug#10195).
232 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
234 * coding.c (encode_designation_at_bol): Don't use uninitialized
235 local variable (Bug#9318).
237 2011-12-05 Kenichi Handa <handa@m17n.org>
239 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
240 return Qnil (Bug#8046, Bug#10193).
242 2011-12-05 Kenichi Handa <handa@m17n.org>
244 * coding.c (encode_designation_at_bol): New args charbuf_end and
245 dst. Return the number of produced bytes. Callers changed.
246 (coding_set_source): Return how many bytes coding->source was
248 (coding_set_destination): Return how many bytes
249 coding->destination was relocated.
250 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
251 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
253 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
255 * coding.c (CODING_CHAR_CHARSET_P): New macro.
256 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
259 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
261 The following changes are to fix Bug#9318.
263 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
264 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
265 (encode_coding_iso_2022, encode_coding_sjis)
266 (encode_coding_big5, encode_coding_charset): Use the above macros.
268 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
270 * lisp.h (process_quit_flag): Fix external declaration.
272 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
274 Don't macro-inline non-performance-critical code.
275 * eval.c (process_quit_flag): New function.
276 * lisp.h (QUIT): Use it.
278 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
280 * nsfns.m (get_geometry_from_preferences): New function.
281 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
283 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
285 * emacs.c (Qkill_emacs): Define.
286 (syms_of_emacs): Initialize it.
287 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
288 Qquit_flag to `kill-emacs' instead.
289 (quit_throw_to_read_char): Add parameter `from_signal'.
290 All callers changed. Call Fkill_emacs if requested and safe.
291 * lisp.h (QUIT): Call Fkill_emacs if requested.
293 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
295 * widget.c (update_wm_hints): Return if wmshell is null.
296 (widget_update_wm_size_hints): New function.
298 * widget.h (widget_update_wm_size_hints): Declare.
300 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
301 widget_update_wm_size_hints (Bug#10104).
303 2011-12-03 Eli Zaretskii <eliz@gnu.org>
305 * xdisp.c (handle_invisible_prop): If the invisible text ends just
306 before a newline, prepare the bidi iterator for consuming the
307 newline, and keep the current paragraph direction. (Bug#10183)
308 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
310 2011-12-02 Juri Linkov <juri@jurta.org>
312 * search.c (Fword_search_regexp): New Lisp function created from
313 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
314 (Fword_search_backward, Fword_search_forward)
315 (Fword_search_backward_lax, Fword_search_forward_lax):
316 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
317 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
319 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
321 * fileio.c (Finsert_file_contents): Move after-change-function call
322 to before the "handled:" label, since all "goto handled" appear in
323 cases where the *-change-functions have already been properly called
326 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
328 * keyboard.c (interrupt_signal): Don't call kill-emacs when
329 waiting for input. (Bug#10169)
331 2011-11-30 Eli Zaretskii <eliz@gnu.org>
333 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
334 verifies glyph row's hash code--we have just reallocated the
335 glyphs, so their contents can be complete garbage. (Bug#10164)
337 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
339 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
341 2011-11-30 Eli Zaretskii <eliz@gnu.org>
343 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
344 attributes are tested _before_ calling verify_row_hash, to protect
345 against GCC re-ordering of the tests. (Bug#10164)
347 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
349 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
351 * xterm.c (handle_one_xevent): Only set async_visible and friends
352 if net_wm_state_hidden_seen is non-zero (Bug#10002)
353 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
354 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
356 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
358 Remove GCPRO-related macros that exist only to avoid shadowing locals.
359 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
360 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
361 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
362 All uses changed to use GCPRO1 etc.
363 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
364 Revert to old implementation (i.e., before 2011-03-11).
366 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
368 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
369 of scroll runs so as to avoid assigning disabled bogus rows and
370 unnecessary graphics copy operations.
372 2011-11-27 Eli Zaretskii <eliz@gnu.org>
374 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
375 (snprintf) [_MSC_VER]: Redirect to _snprintf.
376 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
377 (malloc, free, realloc, calloc): Redirect to e_* only when
380 * lisp.h (GCTYPEBITS): Move before first use.
381 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
382 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
383 this macro definition.
385 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
388 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
390 * gtkutil.c (xg_create_frame_widgets):
391 Call gtk_window_set_has_resize_grip (FALSE) if that function is
392 present with Gtk+ 2.0.
394 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
396 * fileio.c (Finsert_file_contents): Undo previous change; see
397 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
399 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
401 Rename locals to avoid shadowing.
402 * fileio.c (Finsert_file_contents):
403 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
404 * process.c (wait_reading_process_output):
405 Rename inner 'proc' to 'p' to avoid shadowing.
406 Indent for consistency with usual Emacs style.
408 2011-11-25 Eli Zaretskii <eliz@gnu.org>
410 * xdisp.c (redisplay_window): If cursor row is not fully visible
411 after recentering, and scroll-conservatively is set to a large
412 number, scroll window by a few more lines to make the cursor fully
413 visible and out of scroll-margin. (Bug#10105)
414 (start_display): Don't move to the next line if the display should
415 start at a newline that is part of a display vector or an overlay
418 2011-11-24 Juri Linkov <juri@jurta.org>
420 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
421 after the `MagickPingImage' call. (Bug#10112)
423 2011-11-23 Chong Yidong <cyd@gnu.org>
425 * window.c (Fcoordinates_in_window_p): Accept only live windows.
427 2011-11-23 Martin Rudalics <rudalics@gmx.at>
429 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
430 making another buffer current. (Bug#10114)
432 2011-11-23 Glenn Morris <rgm@gnu.org>
434 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
436 2011-11-23 Chong Yidong <cyd@gnu.org>
438 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
441 2011-11-22 Eli Zaretskii <eliz@gnu.org>
443 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
444 and header-lines, as they don't have one computed for them.
447 * .gdbinit (prow): Make displayed values more self-explaining.
450 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
452 * process.c (wait_reading_process_output): Fix asynchrounous
453 GnuTLS socket handling on some versions of the GnuTLS library.
454 (wait_reading_process_output): Add comment and URL.
456 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
458 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
460 2011-11-21 Chong Yidong <cyd@gnu.org>
462 * window.c (Fnext_window, Fprevious_window): Doc fix.
464 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
466 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
468 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
470 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
472 2011-11-20 Martin Rudalics <rudalics@gmx.at>
474 * window.c (Fset_window_combination_limit): Rename argument
476 (Vwindow_combination_limit): Remove "status" from doc-string.
478 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
480 * m/ibms390.h: Remove.
481 * m/ibms390x.h: Don't include "ibms390.h".
483 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
485 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
486 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
488 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
490 * casetab.c (Fset_case_table):
491 * charset.c (Fcharset_after): Fix typos.
493 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
495 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
496 Otherwise, valgrind does not work on some platforms.
497 Problem reported by Andreas Schwab in
498 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
499 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
500 is set, removing the need for VIRT_ADDRESS_VARIES.
501 (PURE_P): Use a more-efficient implementation that needs just one
502 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
503 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
504 to 4 (xorl, subq, cmpq, setbe).
505 * alloc.c (pure): Always extern now, since that's the
506 VIRT_ADDR_VARIES behavior.
507 (PURE_POINTER_P): Use a single comparison, not two, for
508 consistency with the new puresize.h.
509 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
510 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
511 Remove VIRT_ADDR_VARIES no longer needed.
513 2011-11-19 Eli Zaretskii <eliz@gnu.org>
515 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
516 (erase_phys_cursor, update_window_cursor, show_mouse_face)
517 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
518 behave as if the cursor position were at the window margin.
520 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
521 and the cursor position is out of bounds, behave as if the cursor
522 position were at the window margin. (Bug#10075)
524 2011-11-18 Chong Yidong <cyd@gnu.org>
526 * window.c (Fwindow_combination_limit): Make first argument
527 non-optional, since it is meaningless for live windows like the
530 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
532 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
534 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
536 * intervals.c: Fix grafting over the whole buffer (bug#10071).
537 (graft_intervals_into_buffer): Simplify.
539 2011-11-18 Eli Zaretskii <eliz@gnu.org>
541 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
542 hash values of the two rows.
543 (copy_row_except_pointers): Preserve the used[] arrays and the
544 hash values of the two rows. (Bug#10035)
545 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
547 * xdisp.c (row_hash): New function, body extracted from
548 compute_line_metrics.
549 (compute_line_metrics): Call row_hash, instead of computing the
552 * dispnew.c (verify_row_hash): Call row_hash for computing the
553 hash code of a row, instead of duplicating code from xdisp.c.
555 * dispextern.h (row_hash): Add prototype.
557 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
559 * frame.c (delete_frame): Don't delete the terminal when the last
560 X frame is closed if emacs is built with GTK toolkit.
562 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
564 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
566 2011-11-17 Martin Rudalics <rudalics@gmx.at>
568 * window.c (Vwindow_splits): Rename to
569 Vwindow_combination_resize. Suggested by Juri Linkov.
570 (Fsplit_window_internal): Use Vwindow_combination_resize instead
573 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
575 * nsfns.m (Fns_font_name):
576 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
578 2011-11-16 Martin Rudalics <rudalics@gmx.at>
580 * window.h (window): Rename slot "nest" to "combination_limit".
581 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
582 (Fset_window_nest): Rename to Fset_window_combination_limit.
583 (Vwindow_nest): Rename to Vwindow_combination_limit.
584 (recombine_windows, make_parent_window, make_window)
585 (Fsplit_window_internal, saved_window)
586 (Fset_window_configuration, save_window_save): Rename all
587 occurrences of window_nest to window_combination_limit.
589 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
591 * image.c (imagemagick_load_image): Fix typo.
593 2011-11-14 Eli Zaretskii <eliz@gnu.org>
595 * xdisp.c (display_line): Move the call to
596 highlight_trailing_whitespace before the call to
597 compute_line_metrics, since the latter needs to see the final
598 faces of all the glyphs to compute ROW's hash value.
599 Fixes assertion violations in row_equal_p. (Bug#10035)
601 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
603 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
604 just return (bug#10044).
606 2011-11-12 Eli Zaretskii <eliz@gnu.org>
608 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
609 with user-defined heap size. Bump the default size of the temacs
610 heap to 27MB, to avoid memory warning when running temacs.
611 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
613 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
614 current_matrix and desired_matrix. (Bug#9990)
615 (verify_row_hash) [XASSERTS]: New function.
616 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
617 that the hash value of glyph rows is correct.
619 2011-11-12 Martin Rudalics <rudalics@gmx.at>
621 * window.h (window): Remove splits slot.
622 * window.c (Fwindow_splits, Fset_window_splits): Remove.
623 (Fdelete_other_windows_internal, make_parent_window)
624 (make_window, Fsplit_window_internal, Fdelete_window_internal)
625 (Fset_window_configuration, save_window_save): Don't deal with
626 split status of windows.
627 (saved_window): Remove splits slot.
628 (Vwindow_splits): Rewrite doc-string.
630 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
632 * xfns.c (unwind_create_frame):
633 * nsfns.m (unwind_create_frame):
634 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
635 Vframe_list (Bug#9999).
637 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
639 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
641 2011-11-11 Kenichi Handa <handa@m17n.org>
643 * callproc.c (Fcall_process): Set the member dst_multibyte of
646 2011-11-11 Johan Bockgård <bojohan@gnu.org>
648 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
649 avoid a crash (bug#9496).
651 2011-11-09 Chong Yidong <cyd@gnu.org>
653 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
654 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
656 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
658 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
660 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
662 Avoid some portability problems by eschewing 'extern inline' functions.
663 The trivial performance wins aren't worth the portability hassles; see
664 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
666 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
667 (window_box_width, window_box_left, window_box_left_offset)
668 (window_box_right, window_box_right_offset): Undo previous change,
669 by removing the "extern"s.
670 * intervals.c (adjust_intervals_for_insertion)
671 (adjust_intervals_for_deletion): Undo previous change,
672 making these static again.
673 (offset_intervals, temp_set_point_both, temp_set_point)
674 (copy_intervals_to_string): No longer inline.
675 * xdisp.c (window_text_bottom_y, window_box_width)
676 (window_box_height, window_box_left_offset)
677 (window_box_right_offset, window_box_left, window_box_right)
678 (window_box): No longer inline.
680 2011-11-08 Chong Yidong <cyd@gnu.org>
682 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
683 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
684 Signal an error if not a live window.
685 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
686 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
688 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
690 * lisp.h (syms_of_abbrev): Remove declaration.
691 Reported by CHENG Gao <chenggao@royau.me>.
693 2011-11-07 Eli Zaretskii <eliz@gnu.org>
695 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
696 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
697 of temacs in GUI mode.
699 2011-11-07 Martin Rudalics <rudalics@gmx.at>
701 * window.h: Declare delete_all_child_windows instead of
702 delete_all_subwindows.
703 * window.c (Fwindow_nest, Fset_window_nest)
704 (Fset_window_new_total, Fset_window_new_normal)
705 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
706 (delete_all_subwindows): Rename to delete_all_child_windows.
707 (Fdelete_other_windows_internal, Fset_window_configuration):
708 Call delete_all_child_windows instead of delete_all_subwindows.
709 * frame.c (delete_frame): Call delete_all_child_windows instead
710 of delete_all_subwindows.
712 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
714 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
715 This is also needed for porting to any host where GC_MARK_STACK is
716 not GC_MAKE_GCPROS_NOOPS.
717 (which_symbols): Use it.
719 2011-11-07 Kenichi Handa <handa@m17n.org>
721 * coding.c (coding_set_destination): Check coding->src_pos only
722 when coding->src_object is a buffer (bug#9910).
724 * process.c (send_process): Set the member src_multibyte of coding
725 to 0 (bug#9911) when sending a unibyte text.
727 * callproc.c (Fcall_process): Set the member src_multibyte of
728 process_coding to 0 (bug#9912).
730 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
732 * xmenu.c (cleanup_widget_value_tree): New function.
733 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
734 calling free_menubar_widget_value_tree directly (Bug#9830).
736 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
738 Fix some portability problems with 'inline'.
739 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
740 (window_box_width, window_box_left, window_box_left_offset)
741 (window_box_right, window_box_right_offset): Declare extern.
742 Otherwise, these inline functions do not conform to C99 and
743 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
744 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
745 * intervals.c (adjust_intervals_for_insertion)
746 (adjust_intervals_for_deletion): Now extern, because otherwise the
747 extern inline functions 'offset_intervals' couldn't refer to it.
748 (static_offset_intervals): Remove.
749 (offset_intervals): Rewrite using the old contents of
750 static_offset_intervals. The old version didn't conform to C99
751 because an extern inline function contained a reference to an
752 identifier with static linkage.
754 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
756 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
759 2011-11-06 Eli Zaretskii <eliz@gnu.org>
761 * xdisp.c (init_iterator, reseat_to_string): Don't set the
762 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
763 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
764 return Qleft_to_right.
766 2011-11-06 Chong Yidong <cyd@gnu.org>
768 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
769 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
770 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
771 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
772 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
773 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
774 (Fwindow_vscroll): Doc fix.
775 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
776 argument, since it makes no sense to pass a live window and for
777 consistency with window-child.
779 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
781 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
784 2011-11-05 Jason Rumney <jasonr@gnu.org>
786 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
787 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
789 (add_font_entity_to_list): Fix logic errors in mixed boolean and
790 bitwise arithmetic preventing use of unicode-sip and non-truetype
793 2011-11-05 Eli Zaretskii <eliz@gnu.org>
795 * s/ms-w32.h (fstat, stat, utime): Move redirections to
798 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
799 initialization code to keep similarity to xfns.c after changes
802 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
804 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
805 (unwind_create_frame): New function (Bug#9943).
806 (Fx_create_frame): Restructure code to be more similar to the one in
807 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
808 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
809 Move terminal->reference_count++ just before making the frame official
812 * nsterm.m (x_free_frame_resources): New function.
813 (x_destroy_window): Move code to x_free_frame_resources.
815 * xfns.c (unwind_create_frame): Fix comment.
816 (Fx_create_frame, x_create_tip_frame):
817 Move terminal->reference_count++ just before making the frame
818 official. Move initialization of image_cache_refcount and
819 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
821 2011-11-05 Eli Zaretskii <eliz@gnu.org>
823 Support MSVC build with newer versions of Visual Studio.
824 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
825 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
828 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
829 which are not supported by MSVC.
830 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
831 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
833 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
835 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
837 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
839 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
841 Support MSVC build with newer versions of Visual Studio.
842 * w32.c: Don't include w32api.h for MSVC.
843 (init_environment) [_MSC_VER]: Call sys_access, not _access.
845 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
846 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
847 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
848 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
850 (alloca) [_MSC_VER]: Define to _alloca.
852 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
854 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
856 2011-11-04 Eli Zaretskii <eliz@gnu.org>
858 * xdisp.c (note_mouse_highlight): If either of
859 previous/next-single-property-change returns nil, treat that as
860 the beginning or the end of the buffer. (Bug#9955)
862 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
864 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
865 label is not null (Bug#9951).
866 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
869 2011-11-04 Eli Zaretskii <eliz@gnu.org>
871 * window.c (Fwindow_body_size): Mention in the doc string that the
872 return value is in frame's canonical units. (Bug#9949)
874 2011-11-03 Eli Zaretskii <eliz@gnu.org>
876 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
878 * w32fns.c (unwind_create_frame): If needed, free the glyph
879 matrices of the partially constructed frame. (Bug#9943)
880 * xfns.c (unwind_create_frame): Likewise.
882 2011-11-01 Eli Zaretskii <eliz@gnu.org>
884 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
885 Don't stop backward scan on the continuation glyph, even though
886 its CHARPOS is positive.
887 (mouse_face_from_buffer_pos, note_mouse_highlight):
888 Rename cover_string to disp_string.
890 2011-11-01 Martin Rudalics <rudalics@gmx.at>
892 * window.c (temp_output_buffer_show): Don't use
893 Vtemp_buffer_show_specifiers.
894 (Vtemp_buffer_show_specifiers): Remove unused variable.
896 2011-10-30 Eli Zaretskii <eliz@gnu.org>
898 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
899 past the beginning of the current glyph matrix.
901 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
903 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
904 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
905 HAVE_GTK3 (Bug#9869).
907 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
908 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
910 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
912 * xterm.c: Declare x_handle_net_wm_state to return int.
913 (handle_one_xevent): Check if we are iconified but don't have
914 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
915 (get_current_wm_state): Return non-zero if not hidden,
916 check for _NET_WM_STATE_HIDDEN (Bug#9893).
917 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
918 (x_handle_net_wm_state): Return what get_current_wm_state returns.
919 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
921 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
923 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
924 so that this new function doesn't get optimized away by a
925 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
927 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
929 * frame.h (MOUSE_HL_INFO): Remove excess parens.
931 2011-10-29 Eli Zaretskii <eliz@gnu.org>
933 Fix the `xbytecode' command.
934 * .gdbinit (xprintbytestr): New command.
935 (xwhichsymbols): Rename from `which'; all callers changed.
936 (xbytecode): Print the byte-code string as well.
938 2011-10-29 Kim Storm <storm@cua.dk>
940 * alloc.c (which_symbols): New function.
942 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
944 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
947 2011-10-29 Glenn Morris <rgm@gnu.org>
949 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
950 Not clear what it was for, and it causes various bugs. (Bug#9839)
952 2011-10-28 Eli Zaretskii <eliz@gnu.org>
954 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
955 possible random value that matches one of those tested as
956 condition to clear the mouse face.
958 2011-10-28 Chong Yidong <cyd@gnu.org>
960 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
962 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
964 * window.c (make_window): Initialize phys_cursor_on_p.
966 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
968 * lisp.h (struct Lisp_Symbol): Update comments.
970 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
972 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
974 2011-10-28 Eli Zaretskii <eliz@gnu.org>
976 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
977 <oslsachem@gmail.com> for helping to debug this.
979 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
980 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
981 (g_b_init_get_glyph_outline_w): New static variables.
982 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
983 (GetGlyphOutlineW_Proc): New typedefs.
984 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
985 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
987 (w32font_open_internal, compute_metrics):
988 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
989 instead of calling the "wide" APIs directly.
991 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
993 * w32.h (syms_of_w32font): Add prototype.
995 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
997 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
998 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
999 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1000 (Fmove_to_window_line): Doc fix.
1002 2011-10-27 Chong Yidong <cyd@gnu.org>
1004 * process.c (make_process): Set gnutls_state to NULL.
1006 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1007 non-NULL, regardless of GNUTLS_INITSTAGE.
1008 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1009 an error. Set process slots as soon as we allocate them.
1011 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1013 2011-10-27 Chong Yidong <cyd@gnu.org>
1015 * gnutls.c (emacs_gnutls_deinit): New function.
1016 Deallocate credentials structures as well as calling gnutls_deinit.
1017 (Fgnutls_deinit, Fgnutls_boot): Use it.
1019 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1020 (deactivate_process): Call emacs_gnutls_deinit.
1022 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1024 * image.c (x_create_x_image_and_pixmap):
1025 * w32.c (sys_rename, w32_delayed_load):
1026 * w32font.c (fill_in_logfont):
1027 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1029 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1031 * w32fns.c (w32_default_color_map): New function,
1032 extracted from Fw32_default_color_map.
1033 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1035 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1037 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1039 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1041 * keyboard.c (test_undefined): New function (bug#9751).
1042 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1044 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1046 * sysdep.c (init_sys_modes): Fix the check for the controlling
1047 terminal (Bug#6649).
1049 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1051 * dispextern.h (struct bidi_it): New member next_en_type.
1053 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1054 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1055 current character, check also for next_en_type being WEAK_EN.
1056 (bidi_resolve_weak): Don't enter the expensive loop if the current
1057 position is before next_en_pos. Record the bidi type of the first
1058 non-ET, non-BN character we find, in addition to its position.
1059 (bidi_level_of_next_char): Invalidate next_en_type when
1060 next_en_pos is over-stepped.
1062 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1064 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1065 * editfns.c: Rewrite current-time-zone so that it invokes
1066 the equivalent of (format-time-string "%Z") to get the time zone name.
1067 This fixes a bug when the time zone name contains characters that
1068 need converting from the system time locale to Emacs internal format.
1069 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1070 that patch fixed format-time-string to do the conversion, but
1071 I forgot to fix current-time-zone.
1072 (format_time_string): New function, containing most of
1073 what Fformat_time_string used to contain.
1074 (Fformat_time_string): Rewrite in terms of format_time_string.
1075 This doesn't change this function's behavior.
1076 (current-time-zone): Rewrite to use format_time_string.
1077 This fixes the bug reported by Michael Schierl in
1078 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1079 Jason Rumney's 2007-06-07 change worked around this bug, but
1081 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1083 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1085 * xdisp.c (start_display): If the character at POS is displayed
1086 via a display vector, reset IT->current.dpvec_index to zero.
1087 (try_window_reusing_current_matrix): If a line ends in a display
1088 vector or the next line starts in a display vector, continue
1089 redrawing the window even though the character position of
1090 start_row was reached.
1093 2011-10-18 Chong Yidong <cyd@gnu.org>
1095 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1096 with nobreak-char-display too.
1098 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1100 Fix part 3 of bug#9771.
1101 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1102 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1103 non-neutral characters if the current character is a paragraph
1104 separator (a.k.a. Newline). This avoids running the same
1105 expensive loop twice, once when we consume the preceding newline
1106 and the other time when the line actually needs to be displayed.
1107 Avoid the loop when we see neutrals on the base embedding level
1108 following a character whose directionality is the same as the
1109 paragraph's. This avoids running the expensive loop when a line
1110 ends in a long sequence of neutrals, like control characters.
1111 Add assertion against STRONG_AL type. Slightly rearrange code
1112 that determines the type of a neutral given the first non-neutral
1114 (bidi_level_of_next_char): Set next_en_pos to zero when
1115 invalidating its info.
1117 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1119 * xdisp.c (push_display_prop): Determine whether to record string
1120 or buffer position by IT->string, not by IT->method. Allow
1121 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1122 (move_it_vertically_backward): Don't look for character position
1123 immediately after the newline when in a continuation line.
1126 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1128 * window.c (coordinates_in_window): Rewrite and delabelize
1129 vertical border check. (Bug#5357) (Bug#9618)
1131 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1133 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1134 errors in XSetWindowBorder (bug#9310).
1136 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1138 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1139 avoid crash when xmalloc overrun checking is enabled.
1141 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1143 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1144 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1145 cursor motion with <left> and <right> arrow keys.
1147 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1148 some callers set that themselves.
1150 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1153 display string and the previous row comes from the same string and
1154 is empty. (Bug#9739) (Bug#9738)
1156 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1158 * doc.c (get_doc_string): Encode file name (bug#9735).
1160 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1162 * bidi.c (bidi_level_of_next_char):
1163 * xdisp.c (get_visually_first_element): Remove old incorrect
1164 comments regarding the Unicode Line Separator character.
1166 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1168 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1170 * alloc.c (Fgc_status): Do not access beyond zombies array
1171 boundary if nzombies > MAX_ZOMBIES.
1172 * alloc.c (dump_zombies): Add missing format specifier.
1174 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1176 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1177 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1179 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1180 Some packages use them to denote characters with modifiers.
1182 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1184 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1185 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1186 matching a pp-number. Rename parameter var to var1.
1188 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1190 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1192 2011-10-08 Glenn Morris <rgm@gnu.org>
1194 * callint.c (Fcall_interactively): Give a more explicit error for the
1195 'c' case with a non-character input. (Bug#8479)
1197 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1199 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1201 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1202 lines that are hscrolled on the left.
1204 * dispnew.c (buffer_posn_from_coords): Account for a possible
1205 presence of header-line. (Bug#4426)
1207 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1209 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1210 Don't advertise functionality which we discourage or doesn't work.
1212 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1214 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1215 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1216 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1217 this makes Emacs dump core during garbage collection on rare
1218 occasions. sizeof is obviously inferior to offsetof here, so
1219 stick with offsetof.
1220 (GC_POINTER_ALIGNMENT): New macro.
1221 (mark_memory): Omit 3rd (offset) arg; caller changed.
1222 Don't assume EMACS_INT alignment is the same as pointer alignment.
1224 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1226 * keyboard.c (read_key_sequence_remapped): New var.
1227 (read_key_sequence): Compute remapping in the right buffer.
1228 (command_loop_1): Use read_key_sequence's remapping directly.
1230 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1232 * dired.c (file_name_completion): Don't expand file name.
1233 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1234 before checking file name handler.
1236 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1237 they've been requested explicitly (bug#9591).
1239 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1241 * keymap.c (Fsingle_key_description): Use make_specified_string
1242 instead of build_string to build string from push_key_description.
1245 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1247 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1248 This fixes a Y2038 bug on 64-bit hosts.
1249 * buffer.c (reset_buffer):
1250 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1251 (Fclear_buffer_auto_save_failure):
1252 Use 0, not -1, to represent an unset failure time, since time_t
1253 might not be signed.
1255 Remove dependency on glibc malloc internals.
1256 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1257 Move back here from lisp.h, but with their new implementations.
1258 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1259 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1260 * charset.c (charset_table_init): New static var.
1261 (syms_of_charset): Use it instead of xmalloc. This removes a
1262 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1263 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1264 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1265 Move back to alloc.c.
1266 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1267 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1269 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1271 * nsterm.m (windowDidResize): Call x_set_window_size only when
1272 ns_in_resize is true. Otherwise set pixelwidth/height and
1273 call change_frame_size (Bug#9628).
1275 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1277 Port --enable-checking=all to Fedora 14 x86-64.
1278 * charset.c (syms_of_charset): Also account for glibc malloc's
1279 internal overhead when calculating the initial malloc maximum.
1281 Port --enable-checking=all to Fedora 14 x86.
1282 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1284 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1285 (overrun_check_realloc, overrun_check_free):
1286 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1287 That way, xmalloc returns a properly-aligned pointer even if
1288 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1289 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1290 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1291 into account when calculating the initial malloc maximum.
1292 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1293 Move here from alloc.c, so that charset.c can use it too.
1294 Properly align; the old code wasn't right for common 32-bit hosts
1295 when configured with --enable-checking=all.
1296 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1297 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1299 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1301 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1304 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1306 * xdisp.c (compute_display_string_end): If there's no display
1307 string at CHARPOS, return -1.
1309 * bidi.c (bidi_fetch_char): When compute_display_string_end
1310 returns a negative value, treat the character as a normal
1311 character not covered by a display string. (Bug#9624)
1313 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1315 * lread.c (Fread_from_string): Fix typo in docstring.
1317 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1320 newline, reseat the iterator instead of bidi-iterating there one
1321 character at a time. (Bug#9610)
1322 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1323 TO_CHARPOS if the bidi iterator is at base embedding level.
1325 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1327 * lread.c (readevalloop): Use correct code for NBSP.
1328 (read1): Likewise. (Bug#9608)
1330 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1332 * dbusbind.c (Fdbus_register_signal): When service is not
1333 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1335 2011-09-25 Glenn Morris <rgm@gnu.org>
1337 * buffer.c (truncate-lines): Doc fix.
1339 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1341 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1342 (Fset_window_next_buffers): Doc fix.
1344 2011-09-24 Glenn Morris <rgm@gnu.org>
1346 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1348 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1350 Fix minor problems found by static checking.
1351 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1352 * indent.c (Fvertical_motion): Fix == vs = typo.
1354 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1356 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1357 Default value is now t. Doc fix.
1359 * indent.c (Fvertical_motion): Compute and apply the overshoot
1360 logic when moving up, not only when moving down. Fix the
1361 confusing name and values of the it_overshoot_expected variable;
1362 logic changes accordingly. (Bug#9254) (Bug#9549)
1364 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1365 CHARPOS is covered by a display string which includes newlines.
1366 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1367 is covered by a display string with embedded newlines.
1369 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1371 * dbusbind.c (Fdbus_register_signal): Add match rule to
1372 Vdbus_registered_objects_table. (Bug#9581)
1373 (Fdbus_register_method, Vdbus_registered_objects_table):
1376 2011-09-24 Jim Meyering <meyering@redhat.com>
1378 do not ignore write error for any output size
1379 The previous change was incomplete.
1380 While it makes emacs --batch detect the vast majority of stdout
1381 write failures, errors were still ignored whenever the output size is
1382 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1383 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1384 && echo FAIL: ignored write error
1385 FAIL: ignored write error
1386 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1387 && echo FAIL: ignored write error
1388 FAIL: ignored write error
1389 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1391 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1393 * emacs.c (Fkill_emacs): In noninteractive mode exit
1394 non-successfully if a write error occurred on stdout. (Bug#9574)
1396 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1398 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1401 * dispextern.h (struct it): Update the comment documenting what
1404 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1406 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1407 a display string, extend search for cursor position to end of row.
1408 (find_row_edges): If the row ends in a newline from a display
1409 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1410 Handle the case of a display string with multiple newlines.
1411 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1412 non-empty line. Fixes confusing cursor motion with arrow keys at
1413 the beginning of a line that starts with whitespace.
1415 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1417 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1420 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1422 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1425 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (display_line): Record maximum and minimum buffer
1428 positions even if no glyphs were produced (e.g., by a zero-width
1429 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1430 buffer positions that will be removed from the glyph row because
1432 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1433 column is beyond frame width: don't subtract 1 "pixel" when
1434 computing width of the stretch.
1435 (reseat_at_next_visible_line_start): Undo the change made on
1436 2011-09-17 that saved paragraph information and restored it after
1437 the call to `reseat'. (Bug#9545)
1439 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1441 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1442 and turn window cursor on if cleared (Bug#9415).
1444 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1446 * search.c (boyer_moore): Take unibyte characters from pattern
1447 literally. (Bug#9458)
1449 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1451 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1453 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1455 Fix minor problem found by static checking.
1456 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1457 initialized, to pacify gcc -Wuninitialized.
1459 * fileio.c: Report proper errno when syscall falls.
1460 (Finsert_file_contents): Save and restore errno,
1461 so that report_file_error outputs the correct diagnostic.
1462 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1464 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1466 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1468 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1470 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1471 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1473 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1475 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1476 about the current paragraph and restore it after the call to reseat.
1478 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1479 (bidi_find_paragraph_start): Search back for paragraph beginning
1480 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1481 (bidi_move_to_visually_next): Only trigger paragraph-related
1482 computations when the last character is a newline or at EOB, not
1483 just any NEUTRAL_B. (Bug#9470)
1485 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1486 truncated lines if point is covered by a display string. (Bug#9524)
1488 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1490 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1491 (cons_to_x_long): New function.
1492 (lisp_data_to_selection_data): Use it. Correct the test for
1493 short-versus-long data; it was negated. Break out of vector
1494 loop, for efficiency, when a long datum is discovered.
1496 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1498 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1500 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1502 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1503 GCC PR/17406) by declaring this function with external scope.
1505 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1507 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1508 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1510 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1512 * editfns.c (Fformat): Correctly handle text properties on "%%".
1514 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1516 * xterm.c (x_draw_composite_glyph_string_foreground):
1517 * w32term.c (x_draw_composite_glyph_string_foreground):
1518 * term.c (encode_terminal_code):
1519 * composite.c (composition_update_it, get_composition_id):
1520 * xdisp.c (get_next_display_element)
1521 (fill_composite_glyph_string): Add comments about special meaning
1522 of TAB characters in a composition.
1524 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1526 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1527 This occurs when processing a multibyte format.
1528 Problem reported by Wolfgang Jenker.
1530 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1532 * xdisp.c (try_cursor_movement): Only check for exact match if
1533 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1535 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1537 Remove unused external symbols.
1538 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1539 * xdisp.c (calc_pixel_width_or_height): Now static.
1540 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1541 * indent.c (check_display_width):
1542 * w32term.c: Fix comment to match code.
1543 * xterm.c, xterm.h (x_catching_errors): Remove.
1545 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1547 * xselect.c: Use signed conversions more consistently (Bug#9498).
1548 (selection_data_to_lisp_data): Assume incoming selection data are
1549 signed integers, not unsigned. This is to be consistent with
1550 outgoing selection data, which was modified to use signed integers
1551 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1552 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1553 expects long, not unsigned long.
1555 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1557 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1558 computation of loop end. Reported by Johan Bockgård
1561 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1563 * frame.c (Fother_visible_frames_p): Function deleted.
1565 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1567 * indent.c (compute_motion): Process display vector front to back
1568 rather than the other way around. (Bug#2496)
1570 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1572 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1574 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1576 * minibuf.c (Fread_from_minibuffer): Doc fix.
1578 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1580 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1581 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1583 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1585 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1586 value for non-existent files.
1588 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1590 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1591 set its "size" to -1. This will set the modtime_size field of
1592 the corresponding buffer to -1, which is what
1593 verify-visited-file-modtime expects for files that do not exist.
1596 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1598 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1600 * lisp.h: ... from here. push_key_description is no longer
1601 defined in keyboard.c, so its declaration should not be in
1602 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1603 logically belongs with push_key_description.
1605 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1607 * buffer.h: Include <sys/types.h> instead of <time.h>.
1608 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1609 Problem reported by Herbert J. Skuhra.
1611 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1613 * xml.c (parse_region): Make the parsing work for
1614 non-comment-starting XML files again (bug#9144).
1616 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1618 * image.c (gif_load): Fix calculation of bottom and right corner.
1621 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1623 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1624 redisplay in small windows.
1626 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1628 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1630 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1632 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1633 Operate on live windows only.
1635 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1637 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1639 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1641 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1642 only under bidi iteration.
1644 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1646 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1648 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1650 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1651 Without this fix, the command to link temacs failed due to an
1652 undefined symbol __builtin_isnan. This is because
1653 /usr/include/iso/math_c99.h #defines isnan(x) to
1654 __builtin_isnan(x), but the bundled gcc, which identifies itself
1655 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1657 * floatfns.c (isnan): #undef, and then #define to a clone of
1659 (Fisnan): Always define, since it's always available now.
1660 (syms_of_floatfns): Always define isnan at the Lisp level.
1662 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1664 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1666 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1668 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1669 The previous code assumed that file offsets (off_t values) fit in
1670 EMACS_INT variables, which is not true on typical 32-bit hosts.
1671 The code messed up by falsely reporting buffer overflow in cases
1672 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1673 when "big" contains more than 2**29 bytes, even though this
1674 inserts just one byte and does not overflow the buffer.
1675 (Finsert_file_contents): Store file offsets as off_t
1676 values, not as EMACS_INT values. Check for overflow when
1677 converting between EMACS_INT and off_t. When checking for
1678 buffer overflow or for overlap, take the offsets into account.
1679 Don't use EMACS_INT for small values where int suffices.
1680 When checking for overlap, fix a typo: ZV was used where
1681 ZV_BYTE was intended.
1682 (Fwrite_region): Don't assume off_t fits into 'long'.
1683 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1685 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1687 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1689 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1691 sprintf-related integer and memory overflow issues (Bug#9412).
1693 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1694 (esprintf, exprintf, evxprintf): New functions.
1695 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1696 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1697 (modify_event_symbol): Do not assume that the length of
1698 name_alist_or_stem is safe to alloca and fits in int.
1699 (Fexecute_extended_command): Likewise for function name and binding.
1700 (Frecursion_depth): Wrap around reliably on integer overflow.
1701 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1702 since some callers pass EMACS_INT values.
1703 (Fsingle_key_description): Don't crash if symbol name contains more
1704 than MAX_ALLOCA bytes.
1705 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1706 (get_minibuffer): Arg is now EMACS_INT, not int.
1707 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1708 (esprintf, exprintf, evxprintf): New decls.
1709 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1711 * dbusbind.c (signature_cat): New function.
1712 (xd_signature, Fdbus_register_signal):
1713 Do not overrun buffer; instead, report string overflow.
1715 * dispnew.c (add_window_display_history): Don't overrun buffer.
1716 Truncate instead; this is OK since it's just a log.
1718 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1719 even if the time zone offset is outlandishly large.
1720 Don't mishandle offset == INT_MIN.
1722 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1723 when creating daemon; the previous buffer-overflow check was incorrect.
1725 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1726 which has the guts of the old verror function.
1728 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1729 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1731 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1732 (font_unparse_xlfd): Don't blindly alloca long strings.
1733 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1734 fits in int, when using sprintf. Use single snprintf to count
1735 length of string rather than counting it via multiple sprintfs;
1736 that's simpler and more reliable.
1737 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1738 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1739 sprintf, in case result does not fit in int.
1741 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1742 (fontset_from_font): Print it.
1744 * frame.c (tty_frame_count): Now printmax_t, not int.
1745 (make_terminal_frame, set_term_frame_name): Print it.
1746 (x_report_frame_params): In X, window IDs are unsigned long,
1747 not signed long, so print them as unsigned.
1748 (validate_x_resource_name): Check for implausibly long names,
1749 and don't assume name length fits in 'int'.
1750 (x_get_resource_string): Don't blindly alloca invocation name;
1751 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1754 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1755 (xg_check_special_colors, xg_set_geometry):
1756 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1758 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1759 Use esprintf, not sprintf, in case result does not fit in int.
1761 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1762 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1763 it as a large positive number.
1764 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1765 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1767 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1768 in case result does not fit in int.
1770 * print.c (float_to_string): Detect width overflow more reliably.
1771 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1772 buffer overrun. Don't assume list length fits in 'int'. Treat
1773 print length of 0 as 0, not as infinity; to be consistent with other
1774 uses of print length in this function. Don't overflow print length
1775 index. Don't assume hash table size fits in 'long', or that
1776 vectorlike size fits in 'unsigned long'.
1778 * process.c (make_process): Use printmax_t, not int, to format
1779 process-name gensyms.
1781 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1783 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1784 to avoid potential buffer overrun.
1786 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1787 if X resource line is longer than 512 bytes.
1789 * xfns.c (x_window): Make sprintf buffer a bit bigger
1790 to avoid potential buffer overrun.
1792 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1794 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1796 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1798 Integer overflow fixes for scrolling, etc.
1799 Without these, Emacs silently mishandles large integers sometimes.
1800 For example, "C-u 4294967297 M-x recenter" was treated as if
1801 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1803 * xdisp.c (try_window_id): Check Emacs fixnum range before
1804 converting to 'int'.
1806 * window.c (window_scroll_line_based, Frecenter):
1807 Check that an Emacs fixnum is in range before assigning it to 'int'.
1808 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1809 values converted from Emacs fixnums.
1810 (Frecenter): Don't wrap around a line count if it is out of 'int'
1811 range; instead, treat it as an extreme value.
1812 (Fset_window_configuration, compare_window_configurations):
1813 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1815 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1816 that can exceed INT_MAX. Check that EMACS_INT value is in range
1817 before assigning it to the (possibly-narrower) index.
1818 (match_limit): Don't assume that a fixnum can fit in 'int'.
1820 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1823 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1824 (Fvertical_motion): Don't wrap around LINES values that don't fit
1825 in 'int'. Instead, treat them as extreme values. This is good
1826 enough for windows, which can't have more than INT_MAX lines anyway.
1828 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1830 * Require libxml/parser.h to avoid compilation warning.
1832 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1834 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1835 since this reportedly can destroy thread storage.
1837 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1839 * syntax.c (find_defun_start): Update all cache variables if
1840 exiting early (Bug#9401).
1842 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1844 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1846 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1847 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1848 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1850 * term.c (tty_append_glyph): New function.
1851 (produce_stretch_glyph): Static function and its prototype deleted.
1853 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1856 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1858 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1859 when checking :margin (Bug#9390).
1860 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1861 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1862 so that the name doesn't mislead. All uses changed.
1864 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1866 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1869 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1871 * xdisp.c (move_it_to): Don't bail out early when reaching
1872 position beyond to_charpos, if we are scanning backwards.
1873 (move_it_vertically_backward): When DY == 0, make sure we get to
1874 the first character in the line after the newline.
1876 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1878 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1879 (ccl_driver): Do not generate an out-of-range pointer.
1880 (Fccl_execute_on_string): Remove unnecessary check for
1881 integer overflow, noted by Stefan Monnier in
1882 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1883 Remove a FIXME that didn't need fixing.
1884 Simplify the newly-introduced buffer reallocation code.
1886 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1888 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1890 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1892 Integer and memory overflow issues (Bug#9196).
1894 * doc.c (get_doc_string): Rework so that
1895 get_doc_string_buffer_size is the actual buffer size, rather than
1896 being 1 less than the actual buffer size; this makes xpalloc more
1899 * image.c (x_allocate_bitmap_record, cache_image):
1900 * xselect.c (Fx_register_dnd_atom):
1901 Simplify previous changes by using xpalloc.
1903 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1904 since either will do and ptrdiff_t is convenient with xpalloc.
1906 * charset.c (charset_table_size)
1907 (struct charset_sort_data.priority): Now ptrdiff_t.
1908 (charset_compare): Don't overflow if priorities differ greatly.
1909 (Fsort_charsets): Don't assume list length fits in int.
1910 Check for size-calculation overflow when allocating sort data.
1911 (syms_of_charset): Allocate an initial charset table that is
1912 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1914 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1916 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1917 The actual value is always <= INT_MAX, and leaving it unsigned made
1918 overflow checking harder.
1920 * dispextern.h (struct glyph_matrix.rows_allocated)
1921 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1922 with xpalloc. The values are still always <= INT_MAX.
1924 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1926 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1927 (SAFE_NALLOCA): New macro.
1929 * region-cache.c (struct boundary.pos, find_cache_boundary)
1930 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1931 (set_cache_region, invalidate_region_cache)
1932 (revalidate_region_cache, know_region_cache, region_cache_forward)
1933 (region_cache_backward, pp_cache):
1934 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1935 so that ptrdiff_t * can be passed to xpalloc.
1936 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1937 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1938 (pp_cache): Don't assume cache_len fits in int.
1939 * region-cache.h: Adjust extern decls to match.
1941 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1942 EMACS_INT, since either will do, for xpalloc.
1944 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1945 (xnmalloc, xnrealloc, xpalloc): New functions.
1947 * bidi.c (bidi_shelve_header_size): New constant.
1948 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1949 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1951 * bidi.c (bidi_cache_shrink):
1952 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1954 Don't update size of array until after memory allocation succeeds,
1955 because xmalloc/xrealloc may not return.
1956 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1957 now that we have proper integer overflow checking.
1958 (record_overlay_string, overlay_strings): Catch overflows when
1959 calculating size of overlay_str_buf.
1961 * callproc.c (Fcall_process): Check for size overflow when
1962 calculating size of args2.
1963 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1964 Normally we prefer signed values, but sticking with ptrdiff_t would
1965 require adding more-complicated checks.
1967 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1968 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1969 Redo buffer-overflow calculations to avoid integer overflow.
1970 Add a FIXME comment where memory seems to be over-allocated.
1972 * character.c (Fstring): Check for size-calculation overflow.
1974 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1975 unnecessary integer overflow. Check for size overflow.
1976 (encode_coding_object): Don't update size until xmalloc succeeds.
1978 * composite.c (get_composition_id): Check for overflow in glyph
1979 length calculations.
1981 Integer and memory overflow fixes for display code.
1982 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1983 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1984 (scrolling_window): Check for overflow in size calculations.
1985 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1986 Don't assume glyph table len fits in int.
1987 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1988 (row_table_size): Now ptrdiff_t, not int.
1989 (scrolling_window): Avoid overflow in size calculations.
1990 Don't update size until allocation succeeds.
1991 * fns.c (concat): Check for overflow in size calculations.
1992 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1993 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1994 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1996 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1997 (get_doc_string): Check for size calculation overflow.
1998 Don't update size until allocation succeeds.
1999 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2000 EMACS_INT, where ptrdiff_t will do.
2001 (Fsubstitute_command_keys): Check for string overflow.
2003 * editfns.c (set_time_zone_rule): Don't assume environment length
2005 (message_length): Now ptrdiff_t, not int.
2006 (Fmessage_box): Don't update size until allocation succeeds.
2007 Don't assume message length fits in int.
2008 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2010 * emacs.c (main): Do not reallocate argv, since there is a null at
2011 the end that can be overwritten, and this way there's no need to
2012 worry about size-calculation overflow.
2013 (sort_args): Check for size-calculation overflow.
2015 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2017 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2019 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2020 (x_set_scroll_bar_width, x_figure_window_size):
2021 Check for integer overflow.
2022 (x_set_alpha): Do not assume XINT fits in int.
2024 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2025 This is for the members text_lines, text_cols, total_lines, total_cols,
2026 where the system imposes an 'int' limit.
2028 * fringe.c (Fdefine_fringe_bitmap):
2029 Don't update size until alloc works.
2031 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2032 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2034 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2035 Check for size-calculation overflow.
2036 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2037 do, as we prefer signed integers.
2038 (id_to_widget.max_size, id_to_widget.used)
2039 (xg_store_widget_in_map, xg_remove_widget_from_map)
2040 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2041 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2042 Use and return ptrdiff_t, not int.
2043 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2044 * gtkutil.h: Change prototypes to match the above.
2046 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2047 are duplicate now that they've been promoted to lisp.h.
2048 (x_allocate_bitmap_record, x_alloc_image_color)
2049 (make_image_cache, cache_image, xpm_load):
2050 Don't update size until alloc is done.
2051 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2053 Check for size calculation overflow.
2054 (ct_colors_allocated_max): New constant.
2055 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2058 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2059 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2060 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2061 Use ptrdiff_t, not int, to count maps.
2062 (read_char_minibuf_menu_prompt): Check for overflow in size
2063 calculations. Don't update size until allocation succeeds.
2064 Redo calculations to avoid overflow.
2065 * keyboard.h: Change prototypes to match the above.
2067 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2069 (current_minor_maps): Check for size calculation overflow.
2070 * keymap.h: Change prototypes to match the above.
2072 * lread.c (read1, init_obarray): Don't update size until alloc done.
2074 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2075 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2077 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2078 Now ptrdiff_t, not int.
2079 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2080 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2082 * process.c (Fnetwork_interface_list): Check for overflow
2083 in size calculation.
2085 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2087 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2088 overflow. Don't bother calling xmalloc when xrealloc will do.
2090 * search.c (Freplace_match): Check for size calculation overflow.
2091 (Fset_match_data): Don't assume list lengths fit in 'int'.
2093 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2094 for command line length. Do not attempt to address one before the
2095 beginning of an array, as that's not portable.
2097 * term.c (max_frame_lines): Remove; unused.
2098 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2100 (encode_terminal_code, calculate_costs): Check for size
2101 calculation overflow.
2102 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2103 table lengths and related sizes. Don't update size until alloc
2104 done. Redo calculations to avoid overflow.
2105 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2107 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2108 subtracting pointers.
2109 (gobble_line): Check for overflow more carefully. Don't update size
2112 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2113 Don't update size until alloc done.
2114 Redo size calculations to avoid overflow.
2115 Check for size calculation overflow.
2116 (main) [DEBUG]: Fix typo in invoking tparam1.
2118 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2119 Use ptrdiff_t, not int, for sizes.
2120 (store_mode_line_noprop_char): Don't update size until alloc done.
2122 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2123 Use ptrdiff_t, not int, for sizes.
2124 (Finternal_make_lisp_face, cache_face):
2125 Check for size calculation overflow.
2126 (cache_face): Treat size calculation overflows as if they were
2127 memory exhaustion (the usual treatment), rather than aborting.
2129 * xfns.c (x_encode_text, x_set_name_internal)
2130 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2131 sizes, since they can exceed INT_MAX in size. Check for size
2132 calculation overflow.
2134 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2135 (xg_select): Check for size calculation overflow.
2136 Don't update size until alloc done.
2138 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2139 as sprintf is limited to int lengths.
2141 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2142 (X_LONG_MIN): New macros.
2143 Use them to make the following changes clearer.
2144 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2145 This change doesn't affect the value now, but it may help remind
2146 future maintainers not to raise the value too much later.
2147 (SELECTION_QUANTUM): Remove, replacing with ...
2148 (selection_quantum): ... new function, which avoids overflow.
2150 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2151 assumption that selection length fits in 'int'.
2152 (x_reply_selection_request, x_handle_selection_request)
2153 (x_get_window_property, receive_incremental_selection)
2154 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2155 (lisp_data_to_selection_data, clean_local_selection_data):
2156 Use ptrdiff_t, not int, to record length of selection.
2157 (x_reply_selection_request, x_get_window_property)
2158 (receive_incremental_selection, x_property_data_to_lisp):
2159 Redo calculations to avoid overflow.
2160 (x_reply_selection_request): When sending hint, ceiling it at
2161 X_LONG_MAX rather than relying on wraparound overflow to send
2163 (x_get_window_property, receive_incremental_selection)
2164 (lisp_data_to_selection_data, x_property_data_to_lisp):
2165 Check for size-calculation overflow.
2166 (x_get_window_property, receive_incremental_selection)
2167 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2168 Don't store size until memory allocation succeeds.
2169 (x_get_window_property): Plug memory leak on memory exhaustion.
2170 Don't double-block input; malloc is safe here. Don't assume 2**34
2171 - 4 fits in unsigned long. Add an xassert to check
2172 XGetWindowProperty overflow. Be more careful about overflow
2173 calculations, and distinguish size from memory overflow better.
2174 (receive_incremental_selection): When tracing, don't assume
2175 unsigned int is less than INT_MAX.
2176 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2177 harmful) conversions of unsigned short to int.
2178 (lisp_data_to_selection_data): Don't assume that integers
2179 in the range -65535 through -1 fit in an X unsigned short.
2180 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2181 result parameters unless successful. Rely on cons_to_unsigned
2182 to report problems with elements; the old code wasn't right anyway.
2183 (x_check_property_data): Check for int overflow; we cannot use
2184 a wider type due to X limits.
2185 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2187 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2189 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2190 (x_term_init): Check for size calculation overflow.
2191 (x_color_cells): Don't store size until memory allocation succeeds.
2192 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2193 Don't assume alloca size is less than MAX_ALLOCA.
2194 (x_term_init): Don't assume length fits in int (sprintf is limited
2197 Use ptrdiff_t for composition IDs.
2198 * character.c (lisp_string_width):
2199 * composite.c (composition_table_size, n_compositions)
2200 (get_composition_id, composition_gstring_from_id):
2201 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2202 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2203 * window.c (Frecenter):
2204 Use ptrdiff_t, not int, for composition IDs.
2205 * composite.c (get_composition_id): Check for integer overflow.
2206 * composite.h: Adjust prototypes to match the above changes.
2208 Use ptrdiff_t for hash table indexes.
2209 * category.c (hash_get_category_set):
2210 * ccl.c (ccl_driver):
2211 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2212 * coding.c (coding_system_charset_list, detect_coding_system):
2213 * coding.h (struct coding_system.id):
2214 * composite.c (get_composition_id, gstring_lookup_cache):
2215 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2216 * image.c (xpm_get_color_table_h):
2217 * lisp.h (hash_lookup, hash_put):
2218 * minibuf.c (Ftest_completion):
2219 Use ptrdiff_t for hash table indexes, not int (which is too
2220 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2221 32-bit --with-wide-int hosts).
2223 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2224 Add a FIXME comment about memory leaks.
2225 (syms_of_charset): Don't assume xmalloc returns.
2227 Don't assume that stated character widths fit in int.
2228 * character.c (Fchar_width, c_string_width, lisp_string_width):
2229 * character.h (CHAR_WIDTH):
2230 * indent.c (MULTIBYTE_BYTES_WIDTH):
2231 Use sanitize_char_width to avoid undefined and/or bad behavior
2232 with outlandish widths.
2233 * character.h (sanitize_tab_width): Rename from sanitize_width,
2234 now that we have two such functions. All uses changed.
2235 (sanitize_char_width): New inline function.
2237 Don't assume that tab-width fits in int.
2238 * character.h (sanitize_width): New inline function.
2239 (SANE_TAB_WIDTH): New macro.
2240 (ASCII_CHAR_WIDTH): Use it.
2241 * indent.c (sane_tab_width): Remove. All uses replaced by
2242 SANE_TAB_WIDTH (current_buffer).
2243 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2245 * fileio.c: Integer overflow issues with file modes.
2246 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2248 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2249 Remove unreachable code.
2250 (read_hex, load_charset_map_from_file): Check for integer overflow.
2252 * xterm.c: don't go over XClientMessageEvent limit
2253 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2254 (x_send_scroll_bar_event): Likewise. Check that the size does not
2255 exceed limits imposed by XClientMessageEvent, as well as the usual
2256 ptrdiff_t and size_t limits.
2258 * keyboard.c: Overflow, signedness and related fixes.
2259 (make_lispy_movement): Use same integer type in forward decl
2260 that is used in the definition.
2261 (read_key_sequence, keyremap_step):
2262 Change bufsize argument back to int, undoing my 2011-03-30 change.
2263 We prefer signed types, and int is wide enough here.
2264 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2265 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2266 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2267 length, not size_t. Use ptrdiff_t for index, not int.
2268 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2269 possibility of integer overflow.
2271 Overflow, signedness and related fixes for images.
2273 * dispextern.h (struct it.stack[0].u.image.image_id)
2274 (struct_it.image_id, struct image.id, struct image_cache.size)
2275 (struct image_cache.used, struct image_cache.ref_count):
2276 * gtkutil.c (update_frame_tool_bar):
2277 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2278 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2279 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2280 * nsmenu.m (update_frame_tool_bar):
2281 * xdisp.c (calc_pixel_width_or_height):
2282 * xfns.c (image_cache_refcount):
2283 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2284 on typical 64-bit hosts.
2286 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2287 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2288 Omit unnecessary casts to int.
2289 (parse_image_spec): Check that integers fall into 'int' range
2290 when the callers expect that.
2291 (image_ascent): Redo ascent calculation to avoid int overflow.
2292 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2293 (lookup_image): Remove unnecessary tests.
2294 (xbm_image_p): Locals are now of int, not EMACS_INT,
2295 since parse_image_check makes sure they fit into int.
2296 (png_load, gif_load, svg_load_image):
2297 Prefer int to unsigned where either will do.
2298 (tiff_handler): New function, combining the cores of the
2299 old tiff_error_handler and tiff_warning_handler.
2300 This function is rewritten to use vsnprintf and thereby avoid
2301 stack buffer overflows. It uses only the features of vsnprintf
2302 that are common to both POSIX and native Microsoft.
2303 (tiff_error_handler, tiff_warning_handler): Use it.
2304 (tiff_load, gif_load, imagemagick_load_image):
2305 Don't assume :index value fits in 'int'.
2306 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2307 (imagemagick_load_image): Check that crop parameters fit into
2308 the integer types that MagickCropImage accepts. Don't assume
2309 Vimagemagick_render_type has a nonnegative value. Don't assume
2310 size_t fits in 'long'.
2311 (gs_load): Use printmax_t to print the widest integers possible.
2312 Check for integer overflow when computing image height and width.
2314 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2316 * xdisp.c (redisplay_window): Don't force window start if point
2317 will be invisible in the resulting window. (Bug#9324)
2319 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2321 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2322 the display spec is of the form `(space ...)'.
2323 (handle_display_spec): Return the value returned by
2324 handle_single_display_spec, not just 1 or zero.
2325 (handle_single_display_spec): If the display spec is of the form
2326 `(space ...)', and specifies display in the text area, return 2
2328 (try_cursor_movement): Check for the need to scroll more
2329 accurately, and prefer exact match for point under bidi.
2330 Don't advance `row' beyond the last row of the window.
2332 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2333 into disp_prop; all users changed.
2335 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2336 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2337 for the text covered by the display property.
2339 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2341 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2342 Change return value to nil.
2343 (Frecord_buffer): Delete unused function.
2345 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2347 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2348 buffers, return left-to-right.
2349 (set_cursor_from_row): Consider candidate row a win if its glyph
2350 represents a newline and point is on that newline. Fixes cursor
2351 positioning on the newline at EOL of R2L text within L2R
2352 paragraph, and vice versa.
2353 (try_cursor_movement): Check continued rows, in addition to
2354 continuation rows. Fixes unwarranted scroll when point enters a
2355 continued line of R2L text within an L2R paragraph, or vice versa.
2356 (cursor_row_p): Consider the case of point being equal to
2357 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2358 from the end of a short line to the beginning of a continued line
2359 of R2L text within L2R paragraph.
2360 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2361 composed characters.
2363 * bidi.c (bidi_check_type): Use xassert.
2364 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2367 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2369 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2372 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2374 * nsfont.m (ns_otf_to_script): Fix typo.
2376 2011-08-22 Kenichi Handa <handa@m17n.org>
2378 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2379 extra slot even if the purpose is char-code-property-table.
2381 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2383 * xdisp.c (redisplay_window): When computing centering_position,
2384 account for the height of the header line. (Bug#8874)
2386 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2387 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2388 candidate is selected by the mouse, and that candidate has a
2389 composed character under the mouse.
2391 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2392 coordinates reported by pos-visible-in-window-p for a composed
2393 character in column zero.
2395 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2397 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2399 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2402 consider it a hit if to_charpos is anywhere in the range of the
2403 composed buffer positions.
2405 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2407 * image.c (gif_load): Don't assume that each subimage has the same
2408 dimensions as the base image. Handle disposal method that is
2409 "undefined" by the gif spec (Bug#9335).
2411 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2413 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2414 (Fcondition_case): Document `debug' symbol in error handler.
2416 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2418 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2419 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2420 from an Org mode buffer to a Speedbar frame.
2422 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2423 a composition, take its buffer position from IT->cmp_it.charpos.
2424 Fixes cursor positioning at the beginning of a line that begins
2425 with a composed character.
2427 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2429 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2430 character bidirectional type, use STRONG_L instead. Fixes crashes
2431 in a buffer produced by `describe-categories'.
2433 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2434 members before the level stack, so they would be saved and
2435 restored when copying iterator state. Fixes incorrect reordering
2436 around TABs covered by display properties.
2438 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2440 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2442 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2444 * eval.c (internal_condition_case, internal_condition_case_1)
2445 (internal_condition_case_2, internal_condition_case_n):
2446 Remove unnecessary aborts (Bug#9081).
2448 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2450 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2451 has no `load' handler, try opening the file locally. (Bug#9311)
2453 2011-08-16 Ken Brown <kbrown@cornell.edu>
2455 * gmalloc.c: Expand comment.
2457 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2459 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2460 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2462 2011-08-16 Ken Brown <kbrown@cornell.edu>
2464 Fix memory allocation problems in Cygwin build (Bug#9273).
2466 * unexcw.c ( __malloc_initialized): Declare external variable.
2467 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2469 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2471 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2473 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2475 [CYGWIN] (special_realloc): New function.
2476 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2477 requests to realloc storage in the static heap.
2479 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2481 * bidi.c (bidi_initialize): Remove unused local.
2483 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2486 * biditype.h: Remove file.
2487 * makefile.w32-in ($(BLD)/bidi.$(O)):
2488 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2490 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2492 * chartab.c: Improve commentary for the uniprop_table API.
2494 * bidi.c (bidi_paragraph_init): Support zero value of
2495 bidi_ignore_explicit_marks_for_paragraph_level.
2496 (bidi_initialize): Use uniprop_table instead of including
2497 biditype.h and bidimirror.h.
2499 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2500 coordinates of the iterator when restoring from ppos_it.
2503 2011-08-14 Kenichi Handa <handa@m17n.org>
2505 * process.c (create_process): Call setup_process_coding_systems
2506 after the pid of the process is set to -1 (Bug#8162).
2508 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2510 * xdisp.c (move_it_in_display_line_to): Don't invoke
2511 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2512 ppos_it. Fixes vertical cursor motion when line beginning is
2513 covered by an image. (Bug#9296)
2515 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2517 * nsterm.h (ns_run_ascript): Declare.
2518 (NSAPP_DATA2_RUNASSCRIPT): Define.
2520 * nsfns.m (as_script, as_result, as_status): New static variables.
2521 (ns_run_ascript): New function.
2522 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2523 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2524 the event loop. Get status from as_status (Bug#7276).
2526 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2527 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2528 the event loop (Bug#7276).
2530 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2532 * gnutls.c (QCgnutls_bootprop_priority)
2533 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2534 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2535 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2536 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2537 (QCgnutls_bootprop_verify_hostname_error)
2538 (QCgnutls_bootprop_callbacks_verify): Rename from
2539 Qgnutls_bootprop_..., all uses changed.
2541 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2544 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2546 * xfaces.c (Qframe_set_background_mode): Now static.
2547 * dispextern.h (Qframe_set_background_mode): Remove decl.
2549 * process.c (Fnetwork_interface_info): Declare local only if needed.
2551 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2553 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2554 (Fnetwork_interface_list): Allocate in increments of bytes instead
2555 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2556 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2558 (struct ifflag_def): notrailers is smart on OSX.
2559 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2560 Get hardware address with getifaddrs if available.
2562 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2564 * xdisp.c (iterate_out_of_display_property): xassert that
2565 IT->position is set to within IT->object's boundaries. Break from
2566 the loop as soon as EOB is reached; avoids infloops in redisplay
2567 when IT->position is set up wrongly due to some bug.
2568 Set IT->current to match the bidi iterator unconditionally.
2569 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2570 entry. Force push_it to save on the stack the current
2571 buffer/string position, to be restored by pop_it. Fix flags in
2572 the iterator structure wrt the object coming from a display
2573 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2574 properties. (Bug#9284)
2576 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2578 * fontset.c (fontset_get_font_group): Add proper type checks.
2581 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2583 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2584 and LC_VERSION_MIN_MACOSX.
2585 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2586 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2588 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2590 * xdisp.c (forward_to_next_line_start): Allow to use the
2591 no-display-properties-and-no-overlays under bidi display.
2592 Set disp_pos in the bidi iterator to avoid searches for display
2593 properties and overlays.
2595 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2597 * editfns.c (Fset_time_zone_rule): Document relationship with the
2600 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2601 the font entity extracted from the cache (Bug#8109).
2603 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2605 * composite.c (autocmp_chars): Don't reset point. That is done by
2606 restore_point_unwind (Bug#5984).
2608 2011-08-07 Juri Linkov <juri@jurta.org>
2610 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2611 to show the arg `TIME' instead of `TIMEVAL'.
2613 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2615 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2616 display property strides EOL and includes a newline, as in
2617 longlines-mode. (Bug#9254)
2618 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2619 word-wrap under bidirectional display. (Bug#9224)
2621 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2622 is non-zero, even if the data buffer is NULL. Fixes a crash in
2623 vertical-motion with longlines-mode. (Bug#9254)
2625 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2627 * bidi.c <bidi_cache_total_alloc>: Now static.
2628 (bidi_initialize): Initialize bidi_cache_total_alloc.
2630 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2633 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2634 amount allocated this far in `bidi_cache_total_alloc'.
2635 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2636 non-zero, only free the data buffer without restoring the cache
2637 contents. All callers changed.
2639 * dispextern.h (bidi_unshelve_cache): Update prototype.
2641 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2642 (move_it_in_display_line, move_it_to)
2643 (move_it_vertically_backward, move_it_by_lines): Replace the call
2644 to xfree to an equivalent call to bidi_unshelve_cache.
2645 (move_it_in_display_line_to): Fix logic of returning
2646 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2648 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2650 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2651 came from a string character with a `cursor' property. (Bug#9229)
2653 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2655 * Makefile.in (LIB_PTHREAD): New variable.
2656 (LIBES): Add LIB_PTHREAD (Bug#9216).
2658 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2659 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2661 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2663 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2665 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2667 * xterm.c (x_find_topmost_parent): New function.
2668 (x_set_frame_alpha): Find topmost parent window with
2669 x_find_topmost_parent and set the property there also (bug#9181).
2670 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2672 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2674 * callproc.c (Fcall_process): Avoid vfork clobbering
2675 the local vars buffer, coding_systems, current_dir.
2677 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2679 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2681 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2683 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2684 so that it is not optimized away.
2686 * xdisp.c (compute_display_string_pos): Remove unused local.
2688 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2690 Fix slow cursor motion and scrolling in large buffers with
2691 selective display, like Org Mode buffers. (Bug#9218)
2693 * dispextern.h (struct bidi_it): New member disp_prop_p.
2695 * xdisp.c: Remove one-slot cache of display string positions.
2696 (compute_display_string_pos): Accept an additional argument
2697 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2698 for a display string or property. If found, set DISP_PROP_P
2701 * bidi.c (bidi_fetch_char): Accept an additional argument
2702 DISP_PROP_P, and pass it to compute_display_string_pos.
2703 Only handle text covered by a display string if DISP_PROP_P is returned
2704 non-zero. All callers of bidi_fetch_char changed.
2706 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2708 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2710 2010-12-03 Don March <don@ohspite.net>
2712 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2713 last character M-[char] is translated to ESC [char] (bug#7541).
2715 2011-08-02 Kenichi Handa <handa@m17n.org>
2717 * lisp.h (uniprop_table): Extern it.
2719 * chartab.c (uniprop_table): Make it non-static.
2721 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2723 * xdisp.c (forward_to_next_line_start): Accept additional argument
2724 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2726 (reseat_at_next_visible_line_start): Use the bidi iterator state
2727 returned by forward_to_next_line_start to restore the state of
2728 it->bidi_it after backing up to previous newline. (Bug#9212)
2730 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2732 * regex.c (re_comp): Protoize.
2733 (re_exec): Fix return type.
2734 (regexec): Fix type of `ret'. (Bug#9203)
2736 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2738 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2739 This is needed if max-image-size is a floating-point number.
2741 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2743 * print.c (print_object): Print empty symbol as ##.
2745 * lread.c (read1): Read ## as empty symbol.
2747 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2749 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2750 setting frame foreground color (Bug#9175).
2751 (x_set_background_color): Likewise.
2753 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2754 contents (Bug#9176).
2755 (EmacsTooltip -init): Remove bezels and add shadows to
2758 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2759 or scroll bar (Bug#8470).
2761 * nsfont.m (nsfont_open): Remove assignment to voffset and
2762 unnecessary vars hshink, expand, hd, full_height, min_height.
2763 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2765 * nsterm.h (nsfont_info): Remove voffset field.
2767 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2769 Implement strike-through and overline on NextStep (Bug#8863).
2771 * nsfont.m (nsfont_open): Use underline position provided by font,
2772 instead of hard-coded value of 2.
2773 (nsfont_draw): Call ns_draw_text_decoration instead.
2775 * nsterm.h: Add declaration for ns_draw_text_decoration.
2777 * nsterm.m (ns_draw_text_decoration): New function for drawing
2778 underline, overline, and strike-through.
2779 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2780 ns_draw_text_decoration. Change treatment of cursor drawing to
2781 accommodate underlining, etc.
2783 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2785 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2788 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2790 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2791 Without this fix, if a signal arrives just after memory fills up,
2792 'malloc' might be invoked reentrantly.
2794 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2795 In other words, assume that every image size is allowed, on non-X
2796 hosts. This assumption is probably wrong, but it lets Emacs compile.
2798 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2800 * regex.c (re_iswctype): Convert return values to boolean.
2802 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2804 * xdisp.c (compute_display_string_pos): Don't use cached display
2805 string position if the buffer had its restriction changed.
2808 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2810 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2812 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2814 Integer signedness and overflow and related fixes. (Bug#9079)
2816 * bidi.c: Integer size and overflow fixes.
2817 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2818 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2819 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2820 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2821 (bidi_find_other_level_edge):
2822 Use ptrdiff_t instead of EMACS_INT where either will do.
2823 This works better on 32-bit hosts configured --with-wide-int.
2824 (bidi_cache_ensure_space): Check for size-calculation overflow.
2825 Use % rather than repeated addition, for better worst-case speed.
2826 Don't set bidi_cache_size until after xrealloc returns, because it
2828 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2829 (bidi_cache_ensure_space): Also check that the bidi cache size
2830 does not exceed that of the largest Lisp string or buffer. See Eli
2831 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2833 * alloc.c (__malloc_size_t): Remove.
2834 All uses replaced by size_t. See Andreas Schwab's note
2835 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2837 * image.c: Improve checking for integer overflow.
2838 (check_image_size): Assume that f is nonnull, since
2839 it is always nonnull in practice. This is one less thing to
2840 worry about when checking for integer overflow later.
2841 (x_check_image_size): New function, which checks for integer
2842 overflow issues inside X.
2843 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2844 This removes the need for a memory_full check.
2845 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2846 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2847 (xbm_read_bitmap_data): Change locals back to 'int', since
2848 their values must fit in 'int'.
2849 (xpm_load_image, png_load, tiff_load):
2850 Invoke x_create_x_image_and_pixmap earlier,
2851 to avoid much needless work if the image is too large.
2852 (tiff_load): Treat overly large images as if
2853 x_create_x_image_and_pixmap failed, not as malloc failures.
2854 (gs_load): Use x_check_image_size.
2856 * gtkutil.c: Omit integer casts.
2857 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2858 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2860 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2862 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2863 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2864 would wrongly return t on a 64-bit host.
2866 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2867 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2868 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2869 and therefore cause GCC to emit a bogus diagnostic in some cases.
2871 * image.c: Integer signedness and overflow and related fixes.
2872 This is not an exhaustive set of fixes, but it's time to
2873 record what I've got.
2874 (lookup_pixel_color, check_image_size): Remove redundant decls.
2875 (check_image_size): Don't assume that arbitrary EMACS_INT values
2876 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2877 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2878 (tiff_load, imagemagick_load_image):
2879 Check for overflow in size calculations.
2880 (x_create_x_image_and_pixmap): Remove unnecessary test for
2881 xmalloc returning NULL; that can't happen.
2882 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2883 (xpm_color_bucket): Use better integer hashing function.
2884 (xpm_cache_color): Don't possibly over-allocate memory.
2885 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2886 (gif_memory_source):
2887 Use ptrdiff_t, not int or size_t, to record sizes.
2888 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2889 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2890 either works, as we prefer signed integers.
2891 (tiff_read_from_memory, tiff_write_from_memory):
2892 Return tsize_t, not size_t, since that's what the TIFF API wants.
2893 (tiff_read_from_memory): Don't fail simply because the read would
2894 go past EOF; instead, return a short read.
2895 (tiff_load): Omit no-longer-needed casts.
2896 (Fimagemagick_types): Don't assume size fits into 'int'.
2898 Improve hashing quality when configured --with-wide-int.
2899 * fns.c (hash_string): New function, taken from sxhash_string.
2900 Do not discard information about ASCII character case; this
2901 discarding is no longer needed.
2902 (sxhash-string): Use it. Change sig to match it. Caller changed.
2903 * lisp.h: Declare it.
2904 * lread.c (hash_string): Remove, since we now use fns.c's version.
2905 The fns.c version returns a wider integer if --with-wide-int is
2906 specified, so this should help the quality of the hashing a bit.
2908 * emacs.c: Integer overflow minor fix.
2909 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2910 Define only if GNU_LINUX.
2911 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2913 * dispnew.c: Integer signedness and overflow fixes.
2914 Remove unnecessary forward decls, that were a maintenance hassle.
2915 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2917 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2918 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2919 (prepare_desired_row, line_draw_cost):
2920 Use int, not unsigned, where either works.
2921 (save_current_matrix, restore_current_matrix):
2922 Use ptrdiff_t, not size_t, where either works.
2923 (init_display): Check for overflow more accurately, and without
2924 relying on undefined behavior.
2926 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2927 Remove, replacing with the new symbols in lisp.h. All uses changed.
2928 * fileio.c (make_temp_name):
2929 * filelock.c (lock_file_1, lock_file):
2930 * xdisp.c (message_dolog):
2931 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2932 Use pMd etc. instead.
2933 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2934 replacing the pWIDE etc. symbols removed from editfns.c.
2936 * keyboard.h (num_input_events): Now uintmax_t.
2937 This is (very slightly) less likely to mess up due to wraparound.
2940 * buffer.c: Integer signedness fixes.
2941 (alloc_buffer_text, enlarge_buffer_text):
2942 Use ptrdiff_t rather than size_t when either will do, as we prefer
2945 * alloc.c: Integer signedness and overflow fixes.
2946 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2947 (__malloc_size_t): Default to size_t, not to int.
2948 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2949 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2950 Prefer ptrdiff_t to size_t when either would do, as we prefer
2952 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2953 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2954 Now const. Initialize with values that are in range even if char
2956 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2957 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2958 These functions do the right thing with sizes > 2**32.
2959 (check_depth): Now ptrdiff_t, not int.
2960 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2961 Adjust to new way of storing sizes. Check for size overflow bugs
2963 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2964 slightly wrong anyway, as it missed one instance of
2965 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2966 (refill_memory_reserve): Omit needless cast to size_t.
2967 (mark_object_loop_halt): Mark as externally visible.
2969 * xselect.c: Integer signedness and overflow fixes.
2970 (Fx_register_dnd_atom, x_handle_dnd_message):
2971 Use ptrdiff_t, not size_t, since we prefer signed.
2972 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2973 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2974 x_dnd_atoms_size and x_dnd_atoms_length.
2976 * doprnt.c: Prefer signed to unsigned when either works.
2978 * doprnt.c (doprnt):
2980 * xdisp.c (vmessage):
2981 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2982 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2983 prefer signed arithmetic to avoid comparison confusion.
2984 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2985 but is a bit tricky.
2987 Assume freestanding C89 headers, string.h, stdlib.h.
2988 * data.c, doprnt.c, floatfns.c, print.c:
2989 Include float.h unconditionally.
2990 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2991 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2992 * regex.c: Likewise for stddef.h, string.h.
2993 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2994 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2995 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2996 (STDC_HEADERS): Remove obsolete defines.
2997 * sysdep.c: Include limits.h unconditionally.
2999 Assume support for memcmp, memcpy, memmove, memset.
3000 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3001 * regex.c (memcmp, memcpy):
3002 Remove; we assume C89 now.
3004 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3005 (__malloc_safe_bcopy): Remove; no longer needed.
3007 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3008 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3009 well either way, and we prefer signed to unsigned.
3011 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3013 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3014 closes the connection while we're reading (bug#9182).
3016 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3018 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3019 are specified (Bug#9168).
3021 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3023 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3024 Found by GCC static checking and --with-wide-int on a 32-bit host.
3026 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (compute_display_string_pos): Fix logic of caching
3029 previous display string position. Initialize cached_prev_pos to
3030 -1. Fixes slow-down at the beginning of a buffer.
3032 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3034 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3035 for attrs[LFACE_FONTSET_INDEX].
3037 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3039 * xml.c (parse_region): Remove unused local
3040 that was recently introduced.
3042 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3044 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3045 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3047 * xdisp.c (move_it_in_display_line_to): Record the best matching
3048 position for TO_CHARPOS while scanning the line, and restore it on
3049 exit if none of the characters scanned was an exact match.
3050 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3051 when exact match is impossible due to invisible text, and the
3052 lines are truncated.
3054 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3056 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3059 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3061 Fix a significant slow-down of cursor motion with C-n, C-p,
3062 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3063 auto-repeat under bidi redisplay in fontified buffers.
3064 * xdisp.c (compute_stop_pos_backwards): New function.
3065 (next_element_from_buffer): Call compute_stop_pos_backwards to
3066 find a suitable prev_stop when we find ourselves before
3068 (reseat): Don't look for prev_stop, as that could mean a very long
3070 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3071 <cached_disp_overlay_modiff>: Cache for last found display string
3073 (compute_display_string_pos): Return the cached position if asked
3074 about the same buffer in the same area of character positions, and
3075 the buffer wasn't changed since the time the display string
3076 position was cached.
3078 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3080 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3081 is an integer, which is important for empty lines. (Bug#9149)
3083 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3085 * frame.c (Fmodify_frame_parameters): In tty case, update the
3086 default face if necessary (Bug#4238).
3088 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3090 * editfns.c (Fstring_to_char): No need to explain what a character
3091 is in the docstring (Bug#6576).
3093 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3095 * xml.c (parse_region): Make sure we always return a tree.
3097 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3099 * xml.c (parse_region): If a document contains only comments,
3102 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3104 * xml.c (make_dom): Return comments, too.
3106 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3109 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3110 and the surrounding thread.
3111 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3112 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3113 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3115 * s/openbsd.h (BROKEN_SIGIO): Define.
3116 * unexelf.c (unexec) [__OpenBSD__]:
3117 Don't update the .mdebug section of the Alpha COFF symbol table.
3119 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3121 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3124 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3126 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3127 This fixes some race conditions on the permissions of any newly
3130 * alloc.c (valid_pointer_p): Use pipe, not open.
3131 This fixes some permissions issues when debugging.
3133 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3134 If fchown fails to set both uid and gid, try to set just gid,
3135 as that is sometimes allowed. Adjust the file's mode to eliminate
3136 setuid or setgid bits that are inappropriate if fchown fails.
3138 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3140 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3141 to compare Lisp_Objects.
3142 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3143 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3144 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3146 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3148 * lread.c (read_integer): Unread even EOF character.
3149 (read1): Likewise. Properly record start position of symbol.
3151 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3152 symbol character follows.
3154 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3156 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3157 This works around a problem with the previous change to Fcopy_file.
3158 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3159 and without this change, GCC might complain about discarding
3160 fchown's return value.
3162 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3164 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3166 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3168 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3170 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3172 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3173 it's used from the C level.
3175 * process.c: Use the same condition for POLL_FOR_INPUT in both
3176 keyboard.c and process.c (bug#1858).
3178 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3180 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3181 (Fgnutls_boot): Use it.
3183 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3185 * doc.c (Fsubstitute_command_keys): Revert last change.
3187 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3189 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3190 quotes the next character, and doesn't affect other longer
3191 sequences (bug#8935).
3193 * lread.c (syms_of_lread): Clarify that is isn't only
3194 `eval-buffer' and `eval-defun' that's affected by
3195 `lexical-binding' (bug#8460).
3197 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3199 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3200 bidi redisplay when a line includes both an image and is truncated.
3202 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3204 Fix minor problems found by static checking.
3205 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3206 (elsz): Now a signed constant, not a size_t var. We prefer signed
3207 types to unsigned, to avoid integer comparison confusion. Without
3208 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3209 "cannot optimize loop, the loop counter may overflow", a symptom
3211 * indent.c (Fvertical_motion): Mark locals as initialized.
3212 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3214 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3216 * search.c (Fre_search_backward): Mention `case-fold-search' in
3217 all the re_search_* functions (bug#8138).
3219 * keyboard.c (Fopen_dribble_file): Document when the file is
3222 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3224 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3227 Support bidi reordering of display and overlay strings.
3228 * xdisp.c (compute_display_string_pos)
3229 (compute_display_string_end): Accept additional argument STRING.
3230 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3231 (reseat_to_string): Initialize bidi_it->string.s and
3232 bidi_it->string.schars.
3233 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3234 NULL (avoids a crash in bidi_paragraph_init).
3235 Initialize itb.string.lstring.
3236 (init_iterator): Call bidi_init_it only of a valid
3237 buffer position was specified. Initialize paragraph_embedding to
3239 (reseat_to_string): Initialize the bidi iterator.
3240 (display_string): If we need to ignore text properties of
3241 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3242 original value of -1 will not work with bidi.)
3243 (compute_display_string_pos): First arg is now struct
3244 `text_pos *'; all callers changed. Support display properties on
3246 (compute_display_string_end): Support display properties on Lisp
3248 (init_iterator, reseat_1, reseat_to_string): Initialize the
3249 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3250 when iterating on a string not from display properties).
3251 (compute_display_string_pos, compute_display_string_end):
3252 Fix calculation of the object to scan. Fixes an error when using
3254 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3255 base_level_stop; instead, set base_level_stop to BEGV.
3256 Fixes crashes in vertical-motion.
3257 (next_element_from_buffer): Improve commentary for when
3258 the iterator is before prev_stop.
3259 (init_iterator): Initialize bidi_p from the default value of
3260 bidi-display-reordering, not from buffer-local value. Use the
3261 buffer-local value only if initializing for buffer iteration.
3262 (handle_invisible_prop): Support invisible properties on strings
3263 that are being bidi-reordered.
3264 (set_iterator_to_next): Support bidi reordering of C strings and
3266 (next_element_from_string): Support bidi reordering of Lisp
3268 (handle_stop_backwards): Support Lisp strings as well.
3269 (display_string): Support display of R2L glyph rows.
3270 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3271 (init_iterator): Don't initialize it->bidi_p for strings
3273 (reseat_to_string): Initialize it->bidi_p for strings here.
3274 (next_element_from_string, next_element_from_c_string)
3275 (next_element_from_buffer): Add xassert's for correspondence
3276 between IT's object being iterated and it->bidi_it.string
3278 (face_before_or_after_it_pos): Support bidi iteration.
3279 (next_element_from_c_string): Handle the case of the first string
3280 character that is not the first one in the visual order.
3281 (get_visually_first_element): New function, refactored from common
3282 parts of next_element_from_buffer, next_element_from_string, and
3283 next_element_from_c_string.
3284 (tool_bar_lines_needed, redisplay_tool_bar)
3285 (display_menu_bar): Force left-to-right direction. Add a FIXME
3286 comment for making that be controlled by a user option.
3287 (push_it, pop_it): Save and restore the state of the
3288 bidi iterator. Save and restore the bidi_p flag.
3289 (pop_it): Iterate out of display property for string iteration as
3291 (iterate_out_of_display_property): Support iteration over strings.
3292 (handle_single_display_spec): Set up it->bidi_it for iteration
3293 over a display string, and call bidi_init_it.
3294 (handle_single_display_spec, next_overlay_string)
3295 (get_overlay_strings_1, push_display_prop): Set up the bidi
3296 iterator for displaying display or overlay strings.
3297 (forward_to_next_line_start): Don't use the shortcut if
3299 (back_to_previous_visible_line_start): If handle_display_prop
3300 pushed the iterator stack, restore the internal state of the bidi
3301 iterator by calling bidi_pop_it same number of times.
3302 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3303 and we are bidi-iterating, don't decrement the iterator position;
3304 instead, set the first_elt flag in the bidi iterator, to produce
3306 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3307 (push_display_prop): xassert that we are iterating a buffer.
3308 (push_it, pop_it): Save and restore paragraph_embedding member.
3309 (handle_single_display_spec, next_overlay_string)
3310 (get_overlay_strings_1, reseat_1, reseat_to_string)
3311 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3312 correctly. Don't assume unibyte strings are not bidi-reordered.
3313 (compute_display_string_pos)
3314 (compute_display_string_end): Fix handling the case of C string.
3315 (push_it, pop_it): Save and restore from_disp_prop_p.
3316 (handle_single_display_spec, push_display_prop): Set the
3317 from_disp_prop_p flag.
3318 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3319 (pop_it): Call iterate_out_of_display_property only if we are
3320 popping after iteration over a string that came from a display
3321 property. Fix a typo in popping stretch info. Add an assertion
3322 for verifying that the iterator position is in sync with the bidi
3324 (handle_single_display_spec, get_overlay_strings_1)
3325 (push_display_prop): Fix initialization of paragraph direction for
3326 string when that of the parent object is not yet determined.
3327 (reseat_1): Call bidi_init_it to resync the bidi
3328 iterator with IT's position. (Bug#7616)
3329 (find_row_edges): If ROW->start.pos gives position
3330 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3331 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3332 Reset the from_disp_prop_p flag.
3333 (SAVE_IT, RESTORE_IT): New macros.
3334 (pos_visible_p, face_before_or_after_it_pos)
3335 (back_to_previous_visible_line_start)
3336 (move_it_in_display_line_to, move_it_in_display_line)
3337 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3338 (try_scrolling, redisplay_window, display_line): Use them when
3339 saving a temporary copy of the iterator and restoring it back.
3340 (back_to_previous_visible_line_start, reseat_1)
3341 (init_iterator): Empty the bidi cache "stack".
3342 (move_it_in_display_line_to): If iterator ended up at
3343 EOL, but we never saw any buffer positions smaller than
3344 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3345 motion in bidi-reordered lines.
3346 (move_it_in_display_line_to): Record prev_method and prev_pos
3347 immediately before the call to set_iterator_to_next. Fixes cursor
3348 motion in bidi-reordered lines with stretch glyphs and strings
3349 displayed in margins. (Bug#8133) (Bug#8867)
3350 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3352 (pos_visible_p): Support positions in bidi-reordered lines.
3353 Save and restore bidi cache.
3355 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3356 (bidi_paragraph_info): Delete unused struct.
3357 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3358 (bidi_cache_start): New variable.
3359 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3361 (bidi_cache_fetch_state, bidi_cache_search)
3362 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3363 (bidi_cache_find, bidi_peek_at_next_level)
3364 (bidi_level_of_next_char, bidi_find_other_level_edge)
3365 (bidi_move_to_visually_next): Compare cache index with
3366 bidi_cache_start rather than with zero.
3367 (bidi_fetch_char): Accept new argument STRING; all callers
3368 changed. Support iteration over a string. Support strings with
3369 display properties. Support unibyte strings. Fix the type of
3370 `len' according to what STRING_CHAR_AND_LENGTH expects.
3371 (bidi_paragraph_init, bidi_resolve_explicit_1)
3372 (bidi_resolve_explicit, bidi_resolve_weak)
3373 (bidi_level_of_next_char, bidi_move_to_visually_next):
3374 Support iteration over a string.
3375 (bidi_set_sor_type, bidi_resolve_explicit_1)
3376 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3377 can now be zero (for strings); special values 0 and -1 were
3378 changed to -1 and -2, respectively.
3379 (bidi_char_at_pos): New function.
3380 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3381 Call it instead of FETCH_MULTIBYTE_CHAR.
3382 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3383 initialized to valid values.
3384 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3386 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3387 the test for valid cached positions. Fix the logic for looking up
3388 the sentinel state in the cache. GCPRO the Lisp string we are
3390 (bidi_push_it, bidi_pop_it): New functions.
3391 (bidi_initialize): Initialize the bidi cache start stack pointer.
3392 (bidi_cache_ensure_space): New function, refactored from part of
3393 bidi_cache_iterator_state. Don't assume the required size is just
3394 one BIDI_CACHE_CHUNK away.
3395 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3396 (bidi_count_bytes, bidi_char_at_pos): New functions.
3397 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3398 always valid if bidi_cache_idx is valid.
3399 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3400 is valid if it's going to be used.
3401 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3402 (bidi_cache_fetch_state, bidi_cache_search)
3403 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3404 (bidi_cache_iterator_state, bidi_cache_find)
3405 (bidi_find_other_level_edge, bidi_cache_start_stack):
3406 All variables related to cache indices are now EMACS_INT.
3408 * dispextern.h (struct bidi_string_data): New structure.
3409 (struct bidi_it): New member `string'. Make flag members be 1-bit
3410 fields, and put them last in the struct.
3411 (compute_display_string_pos, compute_display_string_end):
3413 (bidi_push_it, bidi_pop_it): Add prototypes.
3414 (struct iterator_stack_entry): New members bidi_p,
3415 paragraph_embedding, and from_disp_prop_p.
3416 (struct it): Member bidi_p is now a bit field 1 bit wide.
3417 (bidi_shelve_cache, bidi_unshelve_cache):
3420 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3421 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3422 and vector-like objects.
3424 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3425 cache around display iteration.
3427 * window.c (Fwindow_end, window_scroll_pixel_based)
3428 (displayed_window_lines, Frecenter): Save and restore the bidi
3429 cache around display iteration.
3431 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3433 * editfns.c (Fdelete_region): Clarify the use of the named
3434 parameters (bug#6788).
3436 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3438 * indent.c (Fvertical_motion): Set and restore w->pointm when
3439 saving and restoring the window's buffer (Bug#9006).
3441 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3443 * editfns.c (Fstring_to_char): Clarify just what is returned
3444 (bug#6576). Text by Eli Zaretskii.
3446 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3448 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3450 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3452 * buffer.c (mmap_find): Fix a typo.
3454 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3456 Fix execution of x selection hooks.
3457 * xselect.c (Qx_lost_selection_functions)
3458 (Qx_sent_selection_functions): New vars.
3459 (syms_of_xselect): DEFSYM them.
3460 (x_handle_selection_request): Pass Qx_sent_selection_functions
3461 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3462 (x_handle_selection_clear,x_clear_frame_selections):
3463 Pass Qx_lost_selection_functions rather than
3464 Vx_lost_selection_functions to Frun_hook_with_args.
3466 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3468 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3469 The old code sometimes used this field without initializing it.
3471 * alloc.c (gc_sweep): Don't read past end of array.
3472 In theory, the old code could also have corrupted Emacs internals,
3473 though it'd be very unlikely.
3475 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3477 * character.c (Fcharacterp): Don't advertise optional ignored
3478 argument. (Bug#4026)
3480 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3482 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3485 * window.c (Fset_window_start): Doc fix (bug#4199).
3486 (Fset_window_hscroll): Ditto.
3488 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3490 Fix minor new problems caught by GCC 4.6.1.
3491 * term.c (init_tty): Remove unused local.
3492 * xsettings.c (store_monospaced_changed): Define this function only
3493 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3496 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3498 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3500 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3502 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3503 are the mini-buffer and the echo area (bug#3320).
3505 * term.c (init_tty): Remove support for supdup, c10 and perq
3506 terminals, which are no longer supported (bug#1482).
3508 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3510 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3512 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3514 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3515 for non-popups (Bug#3642).
3517 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3519 * alloc.c (reset_malloc_hooks): Protoize.
3520 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3521 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3522 * cm.c (losecursor): Likewise.
3523 * data.c (fmod): Likewise.
3524 * dispnew.c (swap_glyphs_in_rows): Likewise.
3525 * emacs.c (memory_warning_signal): Likewise.
3526 * floatfns.c (float_error): Likewise.
3527 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3528 (otf_open, font_otf_capability, generate_otf_features)
3529 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3531 * image.c (pbm_read_file): Likewise.
3532 * indent.c (string_display_width): Likewise.
3533 * intervals.c (check_for_interval, search_for_interval)
3534 (inc_interval_count, count_intervals, root_interval)
3535 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3536 * lread.c (defalias): Likewise.
3537 * ralloc.c (r_alloc_check): Likewise.
3538 * regex.c (set_image_of_range_1, set_image_of_range)
3539 (regex_grow_registers): Likewise.
3540 * sysdep.c (strerror): Likewise.
3541 * termcap.c (valid_filename_p, tprint, main): Likewise.
3542 * tparam.c (main): Likewise.
3543 * unexhp9k800.c (run_time_remap, save_data_space)
3544 (update_file_ptrs, read_header, write_header, calculate_checksum)
3545 (copy_file, copy_rest, display_header): Likewise.
3546 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3548 * xdisp.c (check_it): Likewise.
3549 * xfaces.c (register_color, unregister_color, unregister_colors):
3551 * xfns.c (print_fontset_result): Likewise.
3552 * xrdb.c (member, fatal, main): Likewise.
3554 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3556 Fix minor problems found by static checking (Bug#9031).
3557 * chartab.c (char_table_set_range, map_sub_char_table):
3558 Remove unused locals.
3559 (uniprop_table): Now static.
3560 * composite.c (_work_char): Remove unused static var.
3562 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3564 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3566 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3568 * gtkutil.c (qttip_cb): Remove code without function.
3570 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3572 * w32.c (pthread_sigmask): New stub.
3574 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3576 Use pthread_sigmask, not sigprocmask (Bug#9010).
3577 sigprocmask is portable only for single-threaded applications, and
3578 Emacs can be multi-threaded when it uses GTK.
3579 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3581 * callproc.c (Fcall_process):
3582 * process.c (create_process):
3583 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3584 Use pthread_sigmask, not sigprocmask.
3586 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3588 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3589 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3592 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3594 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3595 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3596 (xg_hide_tooltip): Fix comment.
3598 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3599 in registerServicesMenuSendTypes.
3600 (validRequestorForSendType): Don't check ns_return_types.
3602 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3605 2011-07-08 Jason Rumney <jasonr@gnu.org>
3607 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3608 SH_SHOW for hidden windows (Bug#5482).
3610 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3611 frame struct members of non-existent frames (Bug#6284).
3613 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3615 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3616 variable firstTime not needed on OSX >= 10.6.
3617 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3618 >= 10.5. Use setKnobProportion, setDoubleValue.
3620 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3621 (MAC_OS_X_VERSION_10_5): Define if not defined.
3622 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3623 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3624 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3626 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3627 cString and lossyCString on OSX >= 10.4
3629 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3630 sizeToFit on OSX >= 10.2.
3632 * nsimage.m (allocInitFromFile): Don't use deprecated method
3633 bestRepresentationForDevice on OSX >= 10.6.
3635 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3638 * emacs.c: Declare unexec_init_emacs_zone.
3640 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3642 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3644 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3645 on svcsMenu (Bug#8842).
3647 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3649 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3651 * nsterm.m (QUTF8_STRING): Declare.
3652 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3653 (validRequestorForSendType): Return type is (id).
3654 Change indexOfObjectIdenticalTo to indexOfObject.
3655 Check if we have local selection before returning self (Bug#8842).
3656 (writeSelectionToPasteboard): Put local selection into paste board
3657 if we have a local selection (Bug#8842).
3658 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3660 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3661 (ns_get_local_selection): Declare.
3663 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3665 * keymap.c (describe_map_tree): Don't insert a double newline at
3666 the end of the buffer (bug#1169) and return whether we inserted
3669 * callint.c (Fcall_interactively): Change "reading args" to
3670 "providing args" to try to clarify what it does (bug#1010).
3672 2011-07-07 Kenichi Handa <handa@m17n.org>
3674 * composite.c (composition_compute_stop_pos): Ignore a static
3675 composition starting before CHARPOS (Bug#8915).
3677 * xdisp.c (handle_composition_prop): Likewise.
3679 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3681 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3684 2011-07-07 Kenichi Handa <handa@m17n.org>
3686 * character.h (unicode_category_t): New enum type.
3688 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3689 (Qchar_code_property_table): New variable.
3690 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3691 (UNIPROP_COMPRESSED_FORM_P): New macros.
3692 (char_table_ascii): Uncompress the compressed values.
3693 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3694 Uncompress the compressed values.
3695 (sub_char_table_ref_and_range): Likewise.
3696 (char_table_ref_and_range): Uncompress the compressed values.
3697 (sub_char_table_set): New arg is_uniprop. Callers changed.
3698 Uncompress the compressed values.
3699 (sub_char_table_set_range): Args changed. Callers changed.
3700 (char_table_set_range): Adjuted for the above change.
3701 (map_sub_char_table): Delete args default_val and parent. Add arg
3702 top. Give decoded values to a Lisp function.
3703 (map_char_table): Adjust for the above change. Give decoded
3704 values to a Lisp function. Gcpro more variables.
3705 (uniprop_table_uncompress)
3706 (uniprop_decode_value_run_length): New functions.
3707 (uniprop_decoder, uniprop_decoder_count): New variables.
3708 (uniprop_get_decoder, uniprop_encode_value_character)
3709 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3711 (uniprop_encoder, uniprop_encoder_count): New variables.
3712 (uniprop_get_encoder, uniprop_table)
3713 (Funicode_property_table_internal, Fget_unicode_property_internal)
3714 (Fput_unicode_property_internal): New functions.
3715 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3716 Sunicode_property_table_internal, Sget_unicode_property_internal,
3717 and Sput_unicode_property_internal. Defvar_lisp
3718 char-code-property-alist.
3720 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3721 Vunicode_category_table.
3723 * font.c (font_range): Adjust for the change of
3724 Vunicode_category_table.
3726 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3728 * m/iris4d.h: Remove file, move contents ...
3729 * s/irix6-5.h: ... here.
3731 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3733 Remove unportable assumption about struct layout (Bug#8884).
3734 * alloc.c (mark_buffer):
3735 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3736 (clone_per_buffer_values): Don't assume that
3737 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3738 This isn't true in general, and it's particularly not true
3739 if Emacs is configured with --with-wide-int.
3740 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3741 New macros, used in the buffer.c change.
3743 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3745 * xsettings.c: Use both GConf and GSettings if both are available.
3746 (store_config_changed_event): Add comment.
3747 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3748 (store_tool_bar_style_changed): New functions.
3749 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3750 (struct xsettings): Move font inside HAVE_XFT.
3751 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3752 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3753 Move inside HAVE_XFT.
3754 (something_changed_gsettingsCB): Rename from something_changedCB.
3755 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3757 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3758 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3759 (something_changed_gconfCB): Rename from something_changedCB.
3760 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3761 (parse_settings): Move check for font inside HAVE_XFT.
3762 (read_settings, apply_xft_settings): Add comment.
3763 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3764 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3765 call store_font_name_changed.
3766 (xft_settings_event): Add comment.
3767 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3768 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3769 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3770 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3771 (xsettings_initialize): Call init_gsettings last.
3772 (xsettings_get_system_font, xsettings_get_system_normal_font):
3775 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3777 Random fixes. E.g., (random) never returned negative values.
3778 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3779 subseconds part to the entropy, as that's a bit more random.
3780 Prefer signed to unsigned, since the signedness doesn't matter and
3781 in general we prefer signed. When given a limit, use a
3782 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3783 latter isn't right if USE_2_TAGS_FOR_INTS.
3784 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3785 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3787 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3789 * textprop.c (text_property_stickiness):
3790 Obey Vtext_property_default_nonsticky.
3791 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3792 * w32fns.c (syms_of_w32fns):
3793 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3795 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3797 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3798 This is more efficient than Ffile_directory_p and avoids a minor race.
3800 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3802 * buffer.c (Foverlay_put): Say what the return value is
3805 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3806 is a directory before asking whether to use the file name
3808 (barf_or_query_if_file_exists): Make the "File is a directory"
3809 error be more correct.
3811 * fns.c (Frequire): Remove the mention of the .gz files, since
3812 that's installation-specific, but keep the mention of
3813 `get-load-suffixes'.
3815 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3817 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3818 Report string overflow if the output is too long.
3820 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3822 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3823 (syms_of_gnutls): Remove duplicate DEFSYM for
3824 Qgnutls_bootprop_verify_hostname_error, an error for
3825 Qgnutls_bootprop_verify_error (which is no longer used).
3827 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3828 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3829 Also (re)move comments that are misplaced or no longer relevant.
3831 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3833 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3835 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3837 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3838 and background color parameters if they have been changed.
3840 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3842 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3844 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3846 * xsettings.c (SYSTEM_FONT): Define only when used.
3847 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3849 * keymap.c (access_keymap_1): Now static.
3851 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3853 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3854 leave any prefix arg for the up event (Bug#1586).
3856 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3858 * lread.c (syms_of_lread): Mention single symbols defined by
3859 `defvar' or `defconst' (bug#7154).
3861 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3862 (Frequire): Mention get-load-suffixes.
3864 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3866 * window.h (window): Remove clone_number slot.
3867 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3869 (make_parent_window, make_window, saved_window)
3870 (Fset_window_configuration, save_window_save): Don't deal with
3872 * buffer.c (Qclone_number): Remove declaration.
3873 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3875 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3877 Add multiple inheritance to keymaps.
3878 * keymap.c (Fmake_composed_keymap): New function.
3879 (Fset_keymap_parent): Simplify.
3880 (fix_submap_inheritance): Remove.
3881 (access_keymap_1): New function extracted from access_keymap to handle
3882 embedded parents and handle lists of maps.
3883 (access_keymap): Use it.
3884 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3885 (Fcopy_keymap): Handle embedded parents.
3886 (Fcommand_remapping, define_as_prefix): Simplify.
3887 (Fkey_binding): Simplify.
3888 (syms_of_keymap): Move minibuffer-local-completion-map,
3889 minibuffer-local-filename-completion-map,
3890 minibuffer-local-must-match-map, and
3891 minibuffer-local-filename-must-match-map to Elisp.
3892 (syms_of_keymap): Defsubr make-composed-keymap.
3893 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3894 (parse_menu_item): Trivial simplification.
3896 2011-07-01 Glenn Morris <rgm@gnu.org>
3898 * Makefile.in (SETTINGS_LIBS): Fix typo.
3900 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3902 * coding.c (Fencode_coding_string): Record the last coding system
3903 used, as the function doc string says (bug#8738).
3905 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3907 * xsettings.c (store_monospaced_changed): Take new font as arg and
3908 check for change against current_mono_font.
3909 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3910 (emacs_settings_constructor, emacs_settings_get_property)
3911 (emacs_settings_set_property, emacs_settings_class_init)
3912 (emacs_settings_init, gsettings_obj): Remove.
3913 (something_changedCB): New function for HAVE_GSETTINGS.
3914 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3915 with value as argument.
3916 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3917 g_settings_new (Bug#8967). Do not create gsettings_obj.
3918 Remove calls to g_settings_bind. Connect something_changedCB to
3921 * xgselect.c: Add defined (HAVE_GSETTINGS).
3922 (xgselect_initialize): Ditto.
3924 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3925 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3928 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3930 * eval.c (struct backtrace): Simplify and port the data structure.
3931 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3932 signed bit field, as this assumption is not portable and it makes
3933 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3934 "char debug_on_exit : 1" as this is not portable either; instead,
3935 use the portable "unsigned int debug_on_exit : 1". Remove unused
3936 member evalargs. Remove obsolete comments about cc bombing out.
3938 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3940 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3941 Let HAVE_GSETTINGS override HAVE_GCONF.
3942 (store_monospaced_changed): New function.
3943 (EMACS_SETTINGS): A new type derived from GObject to handle
3944 GSettings notifications.
3945 (emacs_settings_constructor, emacs_settings_get_property)
3946 (emacs_settings_set_property, emacs_settings_class_init):
3948 (gsettings_client, gsettings_obj): New variables.
3949 (GSETTINGS_SCHEMA): New define.
3950 (something_changedCB): Call store_monospaced_changed.
3951 (init_gsettings): New function.
3952 (xsettings_initialize): Call init_gsettings.
3953 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3956 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3959 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3961 * window.c (resize_root_window, grow_mini_window)
3962 (shrink_mini_window): Rename Qresize_root_window to
3963 Qwindow_resize_root_window and Qresize_root_window_vertically to
3964 Qwindow_resize_root_window_vertically.
3966 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3968 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3970 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3972 * makefile.w32-in: Redesign dependencies so they reflect more
3973 clearly which files are directly included by each source file,
3974 and not through other includes.
3976 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3978 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3979 (sort_overlays, overlay_strings): When an overlay's clone number
3980 matches the window's clone number process the overlay even if
3981 the overlay's window property doesn't match the current window.
3983 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3984 (Fwindow_hchild): Rename to Fwindow_left_child.
3985 (Fwindow_next): Rename to Fwindow_next_sibling.
3986 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3987 (resize_window_check): Rename to window_resize_check.
3988 (resize_window_apply): Rename to window_resize_apply.
3989 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3990 (Fdelete_other_windows_internal, resize_frame_windows)
3991 (Fsplit_window_internal, Fdelete_window_internal)
3992 (grow_mini_window, shrink_mini_window)
3993 (Fresize_mini_window_internal): Fix callers accordingly.
3995 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3997 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3998 (emacs_fixed_set_min_size): Remove.
3999 (emacs_fixed_new): Take frame as argument.
4001 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4002 (_EmacsFixedPrivate): Remove minwidth/height.
4003 Add struct frame *f.
4004 (emacs_fixed_init): Initialize priv->f.
4005 (get_parent_class, emacs_fixed_set_min_size): Remove.
4006 (emacs_fixed_new): Set priv->f to argument.
4007 (emacs_fixed_get_preferred_width)
4008 (emacs_fixed_get_preferred_height): Use min_width/height from
4009 frames size_hint to set minimum and natural (Bug#8919).
4010 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4011 and use min_width/height from frames size_hint to set
4012 min_width/height (Bug#8919).
4014 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4015 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4018 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4020 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4021 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4024 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4026 * process.c (wait_reading_process_output): Bypass select if
4027 waiting for a cell while ignoring keyboard input, and input is
4028 pending. Suggested by Jan Djärv (Bug#8869).
4030 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4032 Use gnulib's dup2 module instead of rolling our own.
4033 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4035 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4037 * dispnew.c (scrolling_window): Before scrolling, turn off a
4038 mouse-highlight in the window being scrolled.
4040 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4042 Move DEFSYM to lisp.h and use everywhere.
4044 * character.h (DEFSYM): Move declaration...
4045 * lisp.h (DEFSYM): ...here.
4051 * w32select.c: Don't include character.h.
4053 * alloc.c (syms_of_alloc):
4054 * buffer.c (syms_of_buffer):
4055 * bytecode.c (syms_of_bytecode):
4056 * callint.c (syms_of_callint):
4057 * casefiddle.c (syms_of_casefiddle):
4058 * casetab.c (init_casetab_once):
4059 * category.c (init_category_once, syms_of_category):
4060 * ccl.c (syms_of_ccl):
4061 * cmds.c (syms_of_cmds):
4062 * composite.c (syms_of_composite):
4063 * dbusbind.c (syms_of_dbusbind):
4064 * dired.c (syms_of_dired):
4065 * dispnew.c (syms_of_display):
4066 * doc.c (syms_of_doc):
4067 * editfns.c (syms_of_editfns):
4068 * emacs.c (syms_of_emacs):
4069 * eval.c (syms_of_eval):
4070 * fileio.c (syms_of_fileio):
4071 * fns.c (syms_of_fns):
4072 * frame.c (syms_of_frame):
4073 * fringe.c (syms_of_fringe):
4074 * insdel.c (syms_of_insdel):
4075 * keymap.c (syms_of_keymap):
4076 * lread.c (init_obarray, syms_of_lread):
4077 * macros.c (syms_of_macros):
4078 * msdos.c (syms_of_msdos):
4079 * print.c (syms_of_print):
4080 * process.c (syms_of_process):
4081 * search.c (syms_of_search):
4082 * sound.c (syms_of_sound):
4083 * syntax.c (init_syntax_once, syms_of_syntax):
4084 * terminal.c (syms_of_terminal):
4085 * textprop.c (syms_of_textprop):
4086 * undo.c (syms_of_undo):
4087 * w32.c (globals_of_w32):
4088 * window.c (syms_of_window):
4089 * xdisp.c (syms_of_xdisp):
4090 * xfaces.c (syms_of_xfaces):
4091 * xfns.c (syms_of_xfns):
4092 * xmenu.c (syms_of_xmenu):
4093 * xsettings.c (syms_of_xsettings):
4094 * xterm.c (syms_of_xterm): Use DEFSYM.
4096 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4098 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4100 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4102 Integer and buffer overflow fixes (Bug#8873).
4104 * print.c (printchar, strout): Check for string overflow.
4105 (PRINTPREPARE, printchar, strout):
4106 Don't set size unless allocation succeeds.
4108 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4109 for sizes. Check for string overflow more accurately.
4110 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4112 * macros.c: Integer and buffer overflow fixes.
4113 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4114 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4115 Use ptrdiff_t, not int, for sizes.
4116 Don't increment bufsize until after realloc succeeds.
4117 Check for size-calculation overflow.
4118 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4120 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4122 * lread.c: Integer overflow fixes.
4123 (read_integer): Radix is now EMACS_INT, not int,
4124 to improve quality of diagnostics for out-of-range radices.
4125 Calculate buffer size correctly for out-of-range radices.
4126 (read1): Check for integer overflow in radices, and in
4127 read-circle numbers.
4128 (read_escape): Avoid int overflow.
4129 (Fload, openp, read_buffer_size, read1)
4130 (substitute_object_recurse, read_vector, read_list, map_obarray):
4131 Use ptrdiff_t, not int, for sizes.
4132 (read1): Use EMACS_INT, not int, for sizes.
4133 Check for size overflow.
4135 * image.c (cache_image): Check for size arithmetic overflow.
4137 * lread.c: Integer overflow issues.
4138 (saved_doc_string_size, saved_doc_string_length)
4139 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4140 Now ptrdiff_t, not int.
4141 (read1): Don't assume doc string length fits in int. Check for
4142 out-of-range doc string lengths.
4143 (read_list): Don't assume file position fits in int.
4144 (read_escape): Check for hex character overflow.
4146 2011-06-22 Leo Liu <sdl.web@gmail.com>
4148 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4149 Move to minibuffer.el.
4151 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4153 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4154 The following patches are for when GLYPH_DEBUG && !XASSERT.
4155 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4156 * dispnew.c (flush_stdout):
4157 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4158 Mark as externally visible.
4159 * dispnew.c (check_window_matrix_pointers): Now static.
4160 * dispnew.c (window_to_frame_vpos):
4161 * xfns.c (unwind_create_frame):
4162 * xterm.c (x_check_font): Remove unused local.
4163 * scroll.c (CHECK_BOUNDS):
4164 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4165 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4166 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4167 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4168 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4170 (debug_method_add): Use va_list and vsprintf rather than relying
4171 on undefined behavior with wrong number of arguments.
4172 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4173 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4174 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4175 since we're not interested in debugging glyphs with old libraries.
4176 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4177 GCC 4.6.0's static checking.
4179 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4181 Integer overflow and signedness fixes (Bug#8873).
4182 A few related buffer overrun fixes, too.
4184 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4186 * dispextern.h (struct face.stipple):
4187 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4188 (x_bitmap_mask, x_allocate_bitmap_record)
4189 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4190 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4191 (x_create_bitmap_from_xpm_data):
4192 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4193 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4195 * xfaces.c (load_pixmap):
4196 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4197 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4198 (.bitmaps_last, struct x_output.icon_bitmap):
4199 Use ptrdiff_t, not int, for bitmap indexes.
4200 (x_allocate_bitmap_record): Check for size overflow.
4201 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4203 Use ptrdiff_t, not int, for overlay counts.
4204 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4205 * editfns.c (overlays_around, get_pos_property):
4206 * textprop.c (get_char_property_and_overlay):
4207 * xdisp.c (next_overlay_change, note_mouse_highlight):
4208 * xfaces.c (face_at_buffer_position):
4209 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4210 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4211 (Fnext_overlay_change, Fprevious_overlay_change)
4212 (mouse_face_overlay_overlaps, Foverlays_in):
4213 Use ptrdiff_t, not int, for sizes.
4214 (overlays_at, overlays_in): Check for size-calculation overflow.
4216 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4218 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4219 (x_session_initialize): Do not assume string length fits in int.
4221 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4222 This is unlikely, but can occur if DPI is outlandish.
4224 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4225 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4227 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4228 * xrdb.c (magic_file_p, search_magic_path):
4229 Omit last arg SUFFIX; it was always 0. All callers changed.
4230 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4232 * xfont.c (xfont_match): Avoid need for strlen.
4234 * xfns.c: Don't assume strlen fits in int.
4235 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4237 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4238 not unsigned long, as we prefer signed integers. All callers changed.
4239 Detect integer overflow in repeat count.
4240 (message_dolog): Don't assume print length fits in 39 bytes.
4241 (display_mode_element): Don't assume strlen fits in int.
4243 * termcap.c: Don't assume sizes fit in int and never overflow.
4244 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4245 (gobble_line): Check for size-calculation overflow.
4247 * minibuf.c (Fread_buffer):
4248 * lread.c (intern, intern_c_string):
4249 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4250 Don't assume string length fits in int.
4252 * keyboard.c (parse_tool_bar_item):
4253 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4255 * font.c: Don't assume string length fits in int.
4256 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4257 Use ptrdiff_t, not int.
4258 (font_intern_prop): Don't assume string length fits in int.
4259 Don't assume integer property fits in fixnum.
4260 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4262 * filelock.c: Fix some buffer overrun and integer overflow issues.
4263 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4264 Reformulate so as not to need the command string.
4265 Invoke gzip -cd rather than gunzip, as it's more portable.
4266 (lock_info_type, lock_file_1, lock_file):
4267 Don't assume pid_t and time_t fit in unsigned long.
4268 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4269 (current_lock_owner): Prefer signed type for sizes.
4270 Use memcpy, not strncpy, where memcpy is what is really wanted.
4271 Don't assume (via atoi) that time_t and pid_t fit in int.
4272 Check for time_t and/or pid_t out of range, e.g., via a network share.
4273 Don't alloca where an auto var works fine.
4275 * fileio.c: Fix some integer overflow issues.
4276 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4277 Don't assume string length fits in int.
4278 (directory_file_name): Don't assume string length fits in long.
4279 (make_temp_name): Don't assume pid fits in int, or that its print
4280 length is less than 20.
4282 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4284 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4286 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4288 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4289 We prefer signed integers, even for size calculations.
4291 * emacs.c: Don't assume string length fits in 'int'.
4292 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4293 (main): Don't invoke strlen when not needed.
4295 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4296 (XD_DEBUG_MESSAGE): Don't waste a byte.
4298 * callproc.c (getenv_internal_1, getenv_internal)
4300 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4302 * lread.c (invalid_syntax): Omit length argument.
4303 All uses changed. This doesn't fix a bug, but it simplifies the
4304 code away from its former Hollerith-constant appearance, and it's
4305 one less 'int' to worry about when looking at integer-overflow issues.
4306 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4308 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4309 This didn't break anything, but it didn't help either.
4310 It's confusing to put a bogus integer in a place where the actual
4311 value does not matter.
4312 (LIST_END_P): Remove unused macro and its bogus comment.
4313 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4315 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4316 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4318 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4319 We prefer signed types, and the value cannot exceed the EMACS_INT
4320 range anyway (because otherwise the length would not be representable).
4321 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4322 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4323 This avoids a GCC warning when WIDE_EMACS_INT.
4325 * indent.c (sane_tab_width): New function.
4326 (current_column, scan_for_column, Findent_to, position_indentation)
4327 (compute_motion): Use it. This is just for clarity.
4328 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4330 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4332 * lisp.h (lint_assume): New macro.
4333 * composite.c (composition_gstring_put_cache):
4334 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4336 * editfns.c, insdel.c:
4337 Omit unnecessary forward decls, to simplify future changes.
4339 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4341 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4343 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4344 Use much-faster test for byte-length change.
4345 Don't assume string byte-length fits in 'int'.
4346 Check that character arg fits in 'int'.
4347 (mapcar1): Declare byte as byte, for clarity.
4349 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4351 * fns.c (concat): Catch string overflow earlier.
4352 Do not rely on integer wraparound.
4354 * dispextern.h (struct it.overlay_strings_charpos)
4355 (struct it.selective): Now EMACS_INT, not int.
4356 * xdisp.c (forward_to_next_line_start)
4357 (back_to_previous_visible_line_start)
4358 (reseat_at_next_visible_line_start, next_element_from_buffer):
4359 Don't arbitrarily truncate the value of 'selective' to int.
4361 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4363 * composite.c: Don't truncate sizes to 'int'.
4364 (composition_gstring_p, composition_reseat_it)
4365 (composition_adjust_point): Use EMACS_INT, not int.
4366 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4367 not EMACS_UINT, for indexes.
4369 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4371 * buffer.c: Include <verify.h>.
4372 (struct sortvec.priority, struct sortstr.priority):
4373 Now EMACS_INT, not int.
4374 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4375 (struct sortstr.size, record_overlay_string)
4376 (struct sortstrlist.size, struct sortlist.used):
4377 Don't truncate size to int.
4378 (record_overlay_string): Check for size-calculation overflow.
4379 (init_buffer_once): Check at compile-time, not run-time.
4381 2011-06-22 Jim Meyering <meyering@redhat.com>
4383 Don't leak an XBM-image-sized buffer
4384 * image.c (xbm_load): Free the image buffer after using it.
4386 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4389 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4390 that Sun C diagnosed.
4391 * fns.c (secure_hash): Fix pointer signedness issue.
4392 * intervals.c (static_offset_intervals): New function.
4393 (offset_intervals): Use it.
4395 2011-06-21 Leo Liu <sdl.web@gmail.com>
4398 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4401 * fns.c (secure_hash): Rename from crypto_hash_function and change
4402 the first arg to accept symbols.
4403 (Fsecure_hash): New primitive.
4404 (syms_of_fns): New symbols.
4406 2011-06-20 Deniz Dogan <deniz@dogan.se>
4408 * process.c (Fset_process_buffer): Clarify return value in
4411 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4413 * dispnew.c (add_window_display_history): Use BVAR.
4415 * xdisp.c (debug_method_add): Use BVAR.
4416 (check_window_end, dump_glyph_matrix, dump_glyph)
4417 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4419 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4422 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4423 check till after the cache is created in init_frame_faces.
4425 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4427 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4429 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4431 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4432 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4433 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4435 Improve buffer-overflow checking (Bug#8873).
4436 * fileio.c (Finsert_file_contents):
4437 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4438 Remove the old (too-loose) buffer overflow checks.
4439 They weren't needed, since make_gap checks for buffer overflow.
4440 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4441 The old code merely checked for Emacs fixnum overflow, and relied
4442 on undefined (wraparound) behavior. The new code avoids undefined
4443 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4445 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4446 Tune. Don't use wider integers than needed. Don't use alloca.
4447 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4449 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4451 * insdel.c, lisp.h (buffer_overflow): New function.
4452 (insert_from_buffer_1, replace_range, replace_range_2):
4453 * insdel.c (make_gap_larger):
4454 * editfns.c (Finsert_char):
4455 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4457 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4459 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4461 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4463 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4464 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4466 * fileio.c: Don't assume EMACS_INT fits in off_t.
4467 (emacs_lseek): New static function.
4468 (Finsert_file_contents, Fwrite_region): Use it.
4469 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4471 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4473 * fns.c: Don't overflow int when computing a list length.
4474 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4475 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4476 truncation on 64-bit hosts. Check for QUIT every
4477 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4478 faster and is responsive enough.
4479 (Flength): Report an error instead of overflowing an integer.
4480 (Fsafe_length): Return a float if the value is not representable
4481 as a fixnum. This shouldn't happen except in contrived situations.
4482 (Fnthcdr, Fsort): Don't assume list length fits in int.
4483 (Fcopy_sequence): Don't assume vector length fits in int.
4485 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4486 (header_size, word_size): New constants.
4487 (allocate_vectorlike): Don't check size overflow here.
4488 (allocate_vector): Check it here instead, since this is the only
4489 caller of allocate_vectorlike that could cause overflow.
4490 Check that the new vector's length is representable as a fixnum.
4492 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4493 The previous code was bogus. For example, next_almost_prime (32)
4494 returned 39, which is undesirable as it is a multiple of 3; and
4495 next_almost_prime (24) returned 25, which is a multiple of 5 so
4496 why was the code bothering to check for multiples of 7?
4498 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4500 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4502 Variadic C functions now count arguments with ptrdiff_t.
4503 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4504 Back then I didn't know that the Emacs coding style prefers signed int.
4505 Also, in the meantime I found a few more instances where arguments
4506 were being counted with int, which may truncate counts on 64-bit
4507 machines, or EMACS_INT, which may be unnecessarily wide.
4508 * lisp.h (struct Lisp_Subr.function.aMANY)
4509 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4510 Arg counts are now ptrdiff_t, not size_t.
4511 All variadic functions and their callers changed accordingly.
4512 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4513 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4514 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4515 * callint.c (Fcall_interactively): Check arg count for overflow,
4516 to avoid potential buffer overrun. Use signed char, not 'int',
4517 for 'varies' array, so that we needn't bother to check its size
4518 calculation for overflow.
4519 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4520 * eval.c (apply_lambda):
4521 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4522 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4523 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4525 * callint.c (Fcall_interactively): Don't use index var as event count.
4527 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4528 * mem-limits.h (SIZE): Remove; no longer used.
4530 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4532 Remove unnecessary casts.
4533 * xterm.c (x_term_init):
4534 * xfns.c (x_set_border_pixel):
4535 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4536 These aren't needed now that we assume ANSI C.
4538 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4539 It's more likely to cause problems (due to unsigned overflow)
4542 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4544 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4546 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4548 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4550 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4552 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4554 GLYPH_CODE_FACE returns EMACS_INT, not int.
4555 * dispextern.h (merge_faces):
4556 * xfaces.c (merge_faces):
4557 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4558 Don't assume EMACS_INT fits in int.
4560 * character.h (CHAR_VALID_P): Remove unused parameter.
4561 * fontset.c, lisp.h, xdisp.c: All uses changed.
4563 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4565 * fns.c (concat): Minor tuning based on overflow analysis.
4566 This doesn't fix any bugs. Use int to hold character, instead
4567 of constantly refetching from Emacs object. Use XFASTINT, not
4568 XINT, for value known to be a character. Don't bother comparing
4569 a single byte to 0400, as it's always less.
4571 * floatfns.c (Fexpt):
4572 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4574 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4577 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4579 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4580 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4581 incorrectly succeed when S was a string, because 4294967386 was
4582 truncated before it was used.
4584 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4585 Otherwise, an out-of-range integer could cause undefined behavior
4588 * composite.c: Use int, not EMACS_INT, for characters.
4589 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4590 EMACS_INT, for values that are known to be in character range.
4591 This doesn't fix any bugs but is the usual style inside Emacs and
4592 may generate better code on 32-bit machines.
4594 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4595 This is for reasons similar to the recent CHAR_STRING fix.
4596 * charset.c (Fencode_char): Check that character arg is actually
4597 a character. Pass an int to ENCODE_CHAR.
4598 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4599 wider than 'int', as a compile-time check to prevent future regressions
4602 * character.c (char_string): Remove unnecessary casts.
4604 Make sure a 64-bit char is never passed to CHAR_STRING.
4605 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4606 by silently ignoring the top 32 bits, allowing some values
4607 that were far too large to be valid characters.
4608 * character.h: Include <verify.h>.
4609 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4610 arguments are no wider than unsigned, as a compile-time check
4611 to prevent future regressions in this area.
4613 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4614 (Fsubst_char_in_region):
4616 * xdisp.c (decode_mode_spec_coding):
4617 Adjust to CHAR_STRING's new requirement.
4618 * editfns.c (Finsert_char, Fsubst_char_in_region):
4619 * fns.c (concat): Check that character args are actually
4620 characters. Without this test, these functions did the wrong
4621 thing with wildly out-of-range values on 64-bit hosts.
4623 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4624 These casts should not be needed on 32-bit hosts, either.
4625 * keyboard.c (read_char):
4626 * lread.c (Fload): Remove casts to unsigned.
4628 * lisp.h (UNSIGNED_CMP): New macro.
4629 This fixes comparison bugs on 64-bit hosts.
4630 (ASCII_CHAR_P): Use it.
4631 * casefiddle.c (casify_object):
4632 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4633 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4634 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4635 * dispextern.h (FACE_FROM_ID):
4636 * keyboard.c (read_char): Use UNSIGNED_CMP.
4638 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4639 not to EMACS_INT, to avoid GCC warning.
4641 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4643 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4644 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4645 isn't needed on 32-bit machines.
4647 * buffer.c (Fgenerate_new_buffer_name):
4648 Use EMACS_INT for count, not int.
4649 (advance_to_char_boundary): Return EMACS_INT, not int.
4651 * data.c (Qcompiled_function): Now static.
4653 * window.c (window_body_lines): Now static.
4655 * image.c (gif_load): Rename local to avoid shadowing.
4657 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4658 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4659 * alloc.c (make_save_value): Integer argument is now of type
4661 (mark_object): Use ptrdiff_t, not int.
4662 * lisp.h (pD): New macro.
4663 * print.c (print_object): Use it.
4665 * alloc.c: Use EMACS_INT, not int, to count objects.
4666 (total_conses, total_markers, total_symbols, total_vector_size)
4667 (total_free_conses, total_free_markers, total_free_symbols)
4668 (total_free_floats, total_floats, total_free_intervals)
4669 (total_intervals, total_strings, total_free_strings):
4670 Now EMACS_INT, not int. All uses changed.
4671 (Fgarbage_collect): Compute overall total using a double, so that
4672 integer overflow is less likely to be a problem. Check for overflow
4673 when converting back to an integer.
4674 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4675 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4676 These were 'int' variables that could overflow on 64-bit hosts;
4677 they were never used, so remove them instead of repairing them.
4678 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4679 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4680 Previously, this ceilinged at INT_MAX, but that doesn't work on
4682 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4684 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4685 (allocate_vectorlike): Check for ptrdiff_t overflow.
4686 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4687 when a (possibly-narrower) signed value would do just as well.
4688 We prefer using signed arithmetic, to avoid comparison confusion.
4690 * alloc.c: Catch some string size overflows that we were missing.
4691 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4692 for convenience in STRING_BYTES_MAX.
4693 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4694 The definition here is exact; the one in lisp.h was approximate.
4695 (allocate_string_data): Check for string overflow. This catches
4696 some instances we weren't catching before. Also, it catches
4697 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4698 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4699 and ptrdiff_t and EMACS_INT are both 64 bits.
4701 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4702 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4703 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4705 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4707 * alloc.c (Fmake_string): Check for out-of-range init.
4709 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4711 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4713 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4715 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4716 xg_get_default_scrollbar_width.
4718 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4719 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4720 (style_changed_cb): Call update_theme_scrollbar_width and call
4721 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4722 all frames (Bug#8505).
4723 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4724 Call gtk_window_set_resizable if HAVE_GTK3.
4725 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4726 and height if HAVE_GTK3 (Bug#8505).
4727 (scroll_bar_width_for_theme): New variable.
4728 (update_theme_scrollbar_width): New function.
4729 (xg_get_default_scrollbar_width): Move code to
4730 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4731 (xg_initialize): Call update_theme_scrollbar_width.
4733 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4735 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4737 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4739 * frame.c (make_frame): Call other_buffer_safely instead of
4742 * window.c (temp_output_buffer_show): Call display_buffer with
4743 second argument Vtemp_buffer_show_specifiers and reset latter
4744 immediately after the call.
4745 (Vtemp_buffer_show_specifiers): New variable.
4746 (auto_window_vscroll_p, next_screen_context_lines)
4747 (Vscroll_preserve_screen_position): Remove leading asterisks from
4750 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4752 Fix minor problems found by GCC 4.6.0 static checking.
4753 * buffer.c (Qclone_number): Remove for now, as it's unused.
4754 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4755 (record_buffer): Remove unused local.
4756 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4757 (set_frame_buffer_list): Remove; unused.
4758 * frame.h (other_visible_frames): Remove decl.
4759 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4760 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4761 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4763 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4764 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4765 Define only if HAVE_GPM.
4766 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4767 (update_hints_inhibit): Remove; never set. All uses removed.
4768 * widgetprv.h (emacsFrameClassRec): Remove decl.
4769 * window.c (delete_deletable_window): Now returns void, since it
4770 wasn't returning anything.
4771 (compare_window_configurations): Remove unused locals.
4772 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4773 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4774 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4775 the same widths as pointers. This follows up on the 2011-05-06 patch.
4776 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4777 * xterm.h: Likewise.
4778 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4780 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4782 * makefile.w32-in: Update dependencies.
4783 (LISP_H): Add lib/intprops.h.
4785 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4787 * image.c (gif_load): Add animation frame delay to the metadata.
4788 (syms_of_image): Use DEFSYM. New symbol `delay'.
4790 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4792 * window.c (delete_deletable_window): Re-add.
4793 (Fset_window_configuration): Rewrite to handle dead buffers and
4794 consequently deletable windows.
4795 (window_tree, Fwindow_tree): Remove. Supply functionality in
4797 (compare_window_configurations): Simplify code.
4799 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4801 * image.c (imagemagick_load_image): Fix type mismatch.
4802 (Fimagemagick_types): Likewise.
4804 * window.h (replace_buffer_in_windows): Declare.
4806 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4808 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4809 Qclone_number. Remove external declaration of Qdelete_window.
4810 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4812 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4813 Run Qbuffer_list_update_hook if allowed.
4814 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4815 buffer list implementation.
4816 (other_buffer_safely): New function.
4817 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4818 calls to replace_buffer_in_windows and
4819 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4821 (record_buffer): Inhibit quitting and rewrite using quittable
4822 functions. Run Qbuffer_list_update_hook if allowed.
4823 (Frecord_buffer, Funrecord_buffer): New functions.
4824 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4825 Move switch-to-buffer to window.el.
4826 (bury-buffer): Move to window.el.
4827 (Vbuffer_list_update_hook): New variable.
4829 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4832 * window.h (resize_frame_windows): Move up in code.
4833 (Fwindow_frame): Remove EXFUN.
4834 (replace_buffer_in_all_windows): Remove prototype.
4835 (replace_buffer_in_windows_safely): Add prototype.
4837 * window.c: Declare Qdelete_window static again. Move down
4838 declaration of select_count.
4839 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4840 (Fother_window): Move to window.el.
4841 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4842 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4843 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4845 (replace_buffer_in_windows): Implement by calling
4846 Qreplace_buffer_in_windows.
4847 (replace_buffer_in_all_windows): Remove with some functionality
4848 moved into replace_buffer_in_windows_safely.
4849 (replace_buffer_in_windows_safely): New function.
4850 (select_window_norecord, select_frame_norecord): Move in front
4851 of run_window_configuration_change_hook. Remove now obsolete
4853 (Fset_window_buffer): Rewrite doc-string.
4854 Call Qrecord_window_buffer.
4855 (keys_of_window): Move binding for other-window to window.el.
4857 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4859 * dispextern.h (struct image): Replace data member, whose int_val
4860 and ptr_val fields were not used by anything, with a single
4863 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4864 (gif_clear_image, gif_load, imagemagick_load_image)
4865 (gs_clear_image, gs_load): Callers changed.
4867 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4869 * buffer.h: Include <time.h>, for time_t.
4870 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4872 Fix minor problems found by static checking.
4874 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4876 Make identifiers static if they are not used in other modules.
4877 * data.c (Qcompiled_function, Qframe, Qvector):
4878 * image.c (QimageMagick, Qsvg):
4879 * minibuf.c (Qmetadata):
4880 * window.c (resize_window_check, resize_root_window): Now static.
4881 * window.h (resize_window_check, resize_root_window): Remove decls.
4883 * window.c (window_deletion_count, delete_deletable_window):
4885 (window_body_lines): Now static.
4886 (Fdelete_other_windows_internal): Mark vars as initialized.
4887 Make sure 'resize_failed' is initialized.
4888 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4889 (resize_window_apply): Remove unused local.
4890 * window.h (delete_deletable_window): Remove decl.
4892 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4893 (imagemagick_load_image): Fix pointer signedness problem by changing
4894 last arg from unsigned char * to char *. All uses changed.
4895 Also, fix a local for similar reasons.
4896 Remove unused locals. Remove locals to avoid shadowing.
4897 (fn_rsvg_handle_free): Remove; unused.
4898 (svg_load, svg_load_image): Fix pointer signedness problem.
4899 (imagemagick_load_image): Don't use garbage pointer image_wand.
4901 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4903 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4905 * image.c (gif_load): Fix omitted cast error introduced by
4908 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4910 * window.h (resize_proportionally, orig_total_lines)
4911 (orig_top_line): Remove from window structure.
4912 (set_window_height, set_window_width, change_window_heights)
4913 (Fdelete_window): Remove prototypes.
4914 (resize_frame_windows): Remove duplicate declaration.
4916 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4918 * window.h (resize_frame_windows, resize_window_check)
4919 (delete_deletable_window, resize_root_window)
4920 (resize_frame_windows): Declare prototypes.
4922 * window.c (resize_window_apply): Make definition be "static" to
4923 match the prototype.
4925 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4927 * window.c: Remove declarations of Qwindow_size_fixed,
4928 window_min_size_1, window_min_size_2, window_min_size,
4929 size_window, window_fixed_size_p, enlarge_window, delete_window.
4930 Remove static from declaration of Qdelete_window, it's
4931 temporarily needed by Fbury_buffer.
4932 (replace_window): Don't assign orig_top_line and
4934 (Fdelete_window, delete_window): Remove. Window deletion is
4935 handled by window.el.
4936 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4937 Replace Fdelete_window calls with calls to Qdelete_window.
4938 (Fdelete_other_windows): Remove. Deleting other windows is
4939 handled by window.el.
4940 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4941 handled in window.el.
4942 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4943 Window minimum sizes are handled in window.el.
4944 (shrink_windows, size_window, set_window_height)
4945 (set_window_width, change_window_heights, window_height)
4946 (window_width, CURBEG, CURSIZE, enlarge_window)
4947 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4948 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4949 handled in window.el.
4950 (make_dummy_parent): Rename to make_parent_window and give it a
4951 second argument horflag.
4952 (make_window): Don't set resize_proportionally any more.
4953 (Fsplit_window): Remove. Windows are split in window.el.
4954 (save_restore_action, save_restore_orig_size)
4955 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4956 Resize mini windows in window.el.
4957 (grow_mini_window, shrink_mini_window): Implement by calling
4958 Qresize_root_window_vertically, resize_window_check and
4959 resize_window_apply.
4960 (saved_window, Fset_window_configuration, save_window_save):
4961 Do not handle orig_top_line, orig_total_lines, and
4962 resize_proportionally.
4963 (window_min_height, window_min_width): Move to window.el.
4964 (keys_of_window): Move bindings for delete-other-windows,
4965 split-window, delete-window and enlarge-window to window.el.
4967 * buffer.c: Temporarily extern Qdelete_window.
4968 (Fbury_buffer): Temporarily call Qdelete_window instead of
4969 Fdelete_window (Fbury_buffer will move to window.el soon).
4971 * frame.c (set_menu_bar_lines_1): Remove code handling
4972 orig_top_line and orig_total_lines.
4974 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4975 set_window_height but set heights directly.
4976 (change_frame_size_1): Use resize_frame_windows.
4978 * xdisp.c (init_xdisp): Don't use set_window_height but set
4981 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4982 Use resize_frame_windows instead of change_window_heights and run
4983 run_window_configuration_change_hook.
4985 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4986 instead of change_window_heights and run
4987 run_window_configuration_change_hook.
4989 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4991 * window.c (replace_window): Rename second argument REPLACEMENT to
4992 NEW. New third argument SETFLAG. Rewrite.
4993 (delete_window, make_dummy_parent): Call replace_window with
4995 (window_list_1): Move down in code.
4996 (run_window_configuration_change_hook): Move set_buffer part
4997 before select_frame_norecord part in order to unwind correctly.
4998 Rename count1 to count.
4999 (recombine_windows, delete_deletable_window, resize_root_window)
5000 (Fdelete_other_windows_internal)
5001 (Frun_window_configuration_change_hook, make_parent_window)
5002 (resize_window_check, resize_window_apply, Fresize_window_apply)
5003 (resize_frame_windows, Fsplit_window_internal)
5004 (Fdelete_window_internal, Fresize_mini_window_internal):
5006 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5008 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5010 * window.h (window): Add some new members to window structure -
5011 normal_lines, normal_cols, new_total, new_normal, clone_number,
5012 splits, nest, prev_buffers, next_buffers.
5013 (WINDOW_TOTAL_SIZE): Move here from window.c.
5014 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5016 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5018 (make_dummy_parent): Set new members of windows structure.
5019 (make_window): Move down in code. Handle new members of window
5021 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5022 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5023 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5024 (Fset_window_prev_buffers, Fwindow_next_buffers)
5025 (Fset_window_next_buffers, Fset_window_clone_number):
5027 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5028 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5030 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5031 Argument WINDOW can be now internal window too.
5032 (Fwindow_use_time): Move up in code.
5033 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5035 (Fset_window_configuration, saved_window)
5036 (Fcurrent_window_configuration, save_window_save): Handle new
5037 members of window structure.
5038 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5039 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5040 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5041 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5042 Qget_mru_window, Qresize_root_window,
5043 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5044 Qauto_buffer_name; staticpro them.
5046 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5048 * window.c (Fwindow_total_size, Fwindow_left_column)
5049 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5050 (Fwindow_list_1): New functions.
5051 (window_box_text_cols): Replace with window_body_cols.
5052 (Fwindow_width, Fscroll_left, Fscroll_right):
5053 Use window_body_cols instead of window_box_text_cols.
5054 (delete_window, Fset_window_configuration):
5055 Call delete_all_subwindows with window as argument.
5056 (delete_all_subwindows): Take a window as argument and not a
5058 (window_loop): Remove handling of GET_LRU_WINDOW and
5060 (Fget_lru_window, Fget_largest_window): Move to window.el.
5062 * window.h: Extern window_body_cols instead of
5063 window_box_text_cols. delete_all_subwindows now takes a
5064 Lisp_Object as argument.
5066 * indent.c (compute_motion, Fcompute_motion):
5067 Use window_body_cols instead of window_box_text_cols.
5069 * frame.c (delete_frame): Call delete_all_subwindows with root
5072 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5074 * fns.c (Fputhash): Document return value.
5076 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5078 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5080 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5082 Cons<->int and similar integer overflow fixes (Bug#8794).
5084 Check for overflow when converting integer to cons and back.
5085 * charset.c (Fdefine_charset_internal, Fdecode_char):
5086 Use cons_to_unsigned to catch overflow.
5087 (Fencode_char): Use INTEGER_TO_CONS.
5088 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5089 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5090 * data.c (long_to_cons, cons_to_long): Remove.
5091 (cons_to_unsigned, cons_to_signed): New functions.
5092 These signal an error for invalid or out-of-range values.
5093 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5094 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5095 * font.c (Ffont_variation_glyphs):
5096 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5097 * lisp.h: Include <intprops.h>.
5098 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5099 (cons_to_signed, cons_to_unsigned): New decls.
5100 (long_to_cons, cons_to_long): Remove decls.
5101 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5102 (Fprimitive_undo): Use CONS_TO_INTEGER.
5103 * xfns.c (Fx_window_property): Likewise.
5104 * xselect.c: Include <limits.h>.
5105 (x_own_selection, selection_data_to_lisp_data):
5106 Use INTEGER_TO_CONS.
5107 (x_handle_selection_request, x_handle_selection_clear)
5108 (x_get_foreign_selection, Fx_disown_selection_internal)
5109 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5110 (lisp_data_to_selection_data): Use cons_to_unsigned.
5111 (x_fill_property_data): Use cons_to_signed.
5112 Report values out of range.
5114 Check for buffer and string overflow more precisely.
5115 * buffer.h (BUF_BYTES_MAX): New macro.
5116 * lisp.h (STRING_BYTES_MAX): New macro.
5117 * alloc.c (Fmake_string):
5118 * character.c (string_escape_byte8):
5119 * coding.c (coding_alloc_by_realloc):
5120 * doprnt.c (doprnt):
5121 * editfns.c (Fformat):
5123 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5124 since they may not be the same number.
5125 * editfns.c (Finsert_char):
5126 * fileio.c (Finsert_file_contents):
5127 Likewise for BUF_BYTES_MAX.
5129 * image.c: Use ptrdiff_t, not int, for sizes.
5130 (slurp_file): Switch from int to ptrdiff_t.
5132 (slurp_file): Check that file size fits in both size_t (for
5133 malloc) and ptrdiff_t (for sanity and safety).
5135 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5136 if b->modtime has its maximal value.
5138 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5140 Don't assume time_t can fit into int.
5141 * buffer.h (struct buffer.modtime): Now time_t, not int.
5142 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5143 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5145 Minor fixes for signed vs unsigned integers.
5146 * character.h (MAYBE_UNIFY_CHAR):
5147 * charset.c (maybe_unify_char):
5148 * keyboard.c (read_char, reorder_modifiers):
5149 XINT -> XFASTINT, since the integer must be nonnegative.
5150 * ftfont.c (ftfont_spec_pattern):
5151 * keymap.c (access_keymap, silly_event_symbol_error):
5152 XUINT -> XFASTINT, since the integer must be nonnegative.
5153 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5154 since it makes no difference and we prefer signed.
5155 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5156 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5159 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5161 * window.h (Fwindow_frame): Declare.
5163 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5165 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5166 (SPARE_MEMORY): Always define.
5167 (LARGE_REQUEST): Remove.
5168 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5170 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5172 * lisp.h: Move EXFUNS for Fframe_root_window,
5173 Fframe_first_window and Fset_frame_selected_window to window.h.
5175 * window.h: Move EXFUNS for Fframe_root_window,
5176 Fframe_first_window and Fset_frame_selected_window here from
5179 * frame.c (Fwindow_frame, Fframe_first_window)
5180 (Fframe_root_window, Fframe_selected_window)
5181 (Fset_frame_selected_window): Move to window.c.
5182 (Factive_minibuffer_window): Move to minibuf.c.
5183 (Fother_visible_frames_p): New function.
5185 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5187 * window.c (decode_window, decode_any_window): Move up in code.
5188 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5189 (inhibit_frame_unsplittable): Remove unused variable.
5190 (Fwindow_buffer): Move up and rewrite doc-string.
5191 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5192 (Fwindow_prev): New functions.
5193 (Fwindow_frame): Move here from frame.c. Accept any window as
5195 (Fframe_root_window, Fframe_first_window)
5196 (Fframe_selected_window): Move here from frame.c. Accept frame
5197 or arbitrary window as argument. Update doc-strings.
5198 (Fminibuffer_window): Move up in code.
5199 (Fwindow_minibuffer_p): Move up in code and simplify.
5200 (Fset_frame_selected_window): Move here from frame.c.
5202 (Fselected_window, select_window, Fselect_window): Move up in
5203 code. Minor doc-string fixes.
5205 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5207 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5208 Do not assume that spare memory exists; that assumption is valid
5209 only if SYSTEM_MALLOC.
5210 (LARGE_REQUEST): New macro, so that the issue of large requests
5211 is separated from the issue of spare memory.
5213 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5215 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5218 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5220 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5223 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5225 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5227 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5229 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5230 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5232 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5234 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5236 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5238 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5239 (x_clipboard_manager_save): Add return value.
5240 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5242 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5243 Obey Vx_select_enable_clipboard_manager. Catch errors in
5244 x_clipboard_manager_save (Bug#8779).
5245 (Vx_select_enable_clipboard_manager): New variable.
5246 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5248 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5250 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5252 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5254 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5255 in the current matrix if keep_current_p is non-zero.
5257 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5259 * bidi.c (bidi_level_of_next_char): Fix last change.
5261 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5263 Support bidi reordering of text covered by display properties.
5265 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5266 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5267 (bidi_cache_search, bidi_cache_iterator_state)
5268 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5269 (bidi_level_of_next_char, bidi_move_to_visually_next):
5270 Support character positions inside a run of characters covered by a
5272 (bidi_paragraph_init, bidi_resolve_explicit_1)
5273 (bidi_level_of_next_char): Call bidi_fetch_char and
5274 bidi_fetch_char_advance instead of FETCH_CHAR and
5276 (bidi_init_it): Initialize new members.
5277 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5279 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5280 instead of using explicit *_CHAR codes.
5281 (bidi_resolve_explicit, bidi_resolve_weak):
5282 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5283 bidirectional text is supported only in multibyte buffers.
5284 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5285 it to initialize the frame_window_p member of struct bidi_it.
5286 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5287 (bidi_resolve_explicit, bidi_resolve_weak)
5288 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5289 bidi_it->nchars is non-positive.
5290 (bidi_level_of_next_char): Don't try to lookup the cache for the
5291 next/previous character if nothing is cached there yet, or if we
5292 were just reseat()'ed to a new position.
5294 * xdisp.c (set_cursor_from_row): Set start and stop points
5295 according to the row's direction when priming the loop that looks
5296 for the glyph on which to display cursor.
5297 (single_display_spec_intangible_p): Function deleted.
5298 (display_prop_intangible_p): Reimplement to call
5299 handle_display_spec instead of single_display_spec_intangible_p.
5300 Accept 3 additional arguments needed by handle_display_spec.
5301 This fixes incorrect cursor motion across display property with complex
5302 values: lists, `(when COND...)' forms, etc.
5303 (single_display_spec_string_p): Support property values that are
5304 lists with the argument STRING its top-level element.
5305 (display_prop_string_p): Fix the condition for processing a
5306 property that is a list to be consistent with handle_display_spec.
5307 (handle_display_spec): New function, refactored from the
5308 last portion of handle_display_prop.
5309 (compute_display_string_pos): Accept additional argument
5310 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5311 value of a `display' property is a "replacing spec".
5312 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5313 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5314 the display property, but just return a value indicating whether
5315 the display property will replace the characters it covers.
5316 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5317 frame_window_p members of struct bidi_it.
5318 (compute_display_string_pos, compute_display_string_end):
5320 (push_it): Accept second argument POSITION, where pop_it should
5321 jump to continue iteration.
5322 (reseat_1): Initialize bidi_it.disp_pos.
5324 * keyboard.c (adjust_point_for_property): Adjust the call to
5325 display_prop_intangible_p to its new signature.
5327 * dispextern.h (struct bidi_it): New member frame_window_p.
5328 (bidi_init_it): Update prototypes.
5329 (display_prop_intangible_p): Update prototype.
5330 (compute_display_string_pos, compute_display_string_end):
5332 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5335 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5337 Malloc failure behavior now depends on size of allocation.
5338 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5339 * lisp.h: Change signatures accordingly.
5340 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5341 All callers changed. (Bug#8762)
5343 * gnutls.c: Use Emacs's memory allocators.
5344 Without this change, the gnutls library would invoke malloc etc.
5345 directly, which causes problems on non-SYNC_INPUT hosts, and which
5346 runs afoul of improving memory_full behavior. (Bug#8761)
5347 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5348 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5349 xfree instead of the default malloc, realloc, free.
5350 (Fgnutls_boot): No need to check for memory allocation failure,
5351 since xmalloc does that for us.
5353 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5354 * category.c (hash_get_category_set):
5355 * ccl.c (ccl_driver):
5356 * charset.c (Fdefine_charset_internal):
5357 * charset.h (struct charset.hash_index):
5358 * composite.c (get_composition_id, gstring_lookup_cache)
5359 (composition_gstring_put_cache):
5360 * composite.h (struct composition.hash_index):
5361 * dispextern.h (struct image.hash):
5362 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5363 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5364 (hashfn_equal, hashfn_user_defined, make_hash_table)
5365 (maybe_resize_hash_table, hash_lookup, hash_put)
5366 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5367 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5368 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5369 * image.c (make_image, search_image_cache, lookup_image)
5370 (xpm_put_color_table_h):
5371 * lisp.h (struct Lisp_Hash_Table):
5372 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5373 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5374 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5375 * alloc.c (allocate_vectorlike):
5376 Check for overflow in vector size calculations.
5377 * ccl.c (ccl_driver):
5378 Check for overflow when converting EMACS_INT to int.
5379 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5380 need to be updated by these changes.
5381 * fns.c (make_hash_table, maybe_resize_hash_table):
5382 Check for integer overflow with large hash tables.
5383 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5384 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5385 (SXHASH_REDUCE): New macro.
5386 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5387 Use it instead of discarding useful hash info with large hash values.
5388 (sxhash_float): New function.
5389 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5390 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5391 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5392 Rewrite to use FIXNUM_BITS, as this simplifies things.
5393 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5394 Adjust signatures to match updated version of code.
5395 (consing_since_gc): Now EMACS_INT, since a single hash table can
5396 use more than INT_MAX bytes.
5398 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5400 Make it possible to build with GCC-4.6+ -O2 -flto.
5402 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5404 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5406 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5407 Call minibuffer-inactive-mode.
5409 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5411 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5412 Update dependencies.
5414 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5416 * data.c (init_data): Remove code for UTS, this system is not
5419 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5421 Don't force ./temacs to start in terminal mode.
5423 * frame.c (make_initial_frame): Initialize faces in all cases, not
5424 only when CANNOT_DUMP is defined.
5425 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5427 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5429 * dispnew.c (add_window_display_history): Use const for the string
5430 pointer. Remove declaration, not needed.
5432 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5434 Use 'inline', not 'INLINE'.
5435 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5436 * alloc.c, fontset.c (INLINE): Remove.
5437 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5438 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5439 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5440 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5441 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5443 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5445 Make it possible to run ./temacs.
5447 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5448 syms_of_callproc does the same thing. Remove test for
5449 "initialized", do it in the caller.
5450 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5452 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5454 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5455 (read_minibuf): Use get_minibuffer.
5456 (syms_of_minibuf): Use DEFSYM.
5457 (Qmetadata): New var.
5458 * data.c (Qbuffer): Don't make it static.
5459 (syms_of_data): Use DEFSYM.
5461 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5463 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5464 (CCL_CODE_MIN): New macro.
5466 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5468 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5470 * eval.c (Qdebug): Now static.
5471 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5472 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5473 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5475 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5477 * image.c: Various fixes to ImageMagick code comments.
5478 (Fimagemagick_types): Doc fix.
5480 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5482 Minor fixes prompted by GCC 4.6.0 warnings.
5484 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5486 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5487 (x_clipboard_manager_save_all): Move extern decl to ...
5488 * xterm.h: ... here, so that it can be checked for consistency.
5490 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5492 * xselect.c (x_clipboard_manager_save_frame)
5493 (x_clipboard_manager_save_all): New functions.
5494 (Fx_clipboard_manager_save): Lisp function deleted.
5496 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5497 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5499 * xterm.h: Update prototype.
5501 2011-05-28 William Xu <william.xwl@gmail.com>
5503 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5506 2011-05-28 Jim Meyering <meyering@redhat.com>
5508 Avoid a sign-extension bug in crypto_hash_function.
5509 * fns.c (to_uchar): Define.
5510 (crypto_hash_function): Use it to convert some newly-signed
5511 variables to unsigned, to avoid sign-extension bugs. For example,
5512 without this change, (md5 "truc") would evaluate to
5513 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5514 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5515 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5517 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5519 Integer overflow fixes.
5521 * dbusbind.c: Serial number integer overflow fixes.
5522 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5523 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5524 to hold a serial number that is too large for a fixnum.
5525 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5526 Check for serial numbers out of range. Decode any serial number
5527 that was so large that it became a float. (Bug#8722)
5529 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5530 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5531 Use XFASTINT rather than XUINT when numbers are nonnegative.
5532 (xd_append_arg, Fdbus_method_return_internal):
5533 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5534 arguments, check that Lisp number is nonnegative, rather than
5535 silently wrapping negative numbers around. (Bug#8722)
5536 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5539 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5541 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5543 ccl: add integer overflow checks
5544 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5545 (IN_INT_RANGE): New macros.
5546 (ccl_driver): Use them to check for integer overflow when
5547 decoding a CCL program. Many of the new checks are whether XINT (x)
5548 fits in int; it doesn't always, on 64-bit hosts. The new version
5549 doesn't catch all possible integer overflows, but it's an
5550 improvement. (Bug#8719)
5552 * alloc.c (make_event_array): Use XINT, not XUINT.
5553 There's no need for unsigned here.
5555 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5556 This follows up to the 2011-05-06 change that substituted uintptr_t
5557 for EMACS_INT. This case wasn't caught back then.
5559 Rework Fformat to avoid integer overflow issues.
5560 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5561 now (part of C89). Include <verify.h>.
5562 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5563 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5564 (Fformat): Avoid the prepass trying to compute sizes; it was only
5565 approximate and thus did not catch overflow reliably. Instead, walk
5566 through the format just once, formatting and computing sizes as we go,
5567 checking for integer overflow at every step, and allocating a larger
5568 buffer as needed. Keep track separately whether the format is
5569 multibyte. Keep only the most-recently calculated precision, rather
5570 than them all. Record whether each argument has been converted to
5571 string. Use EMACS_INT, not int, for byte and char and arg counts.
5572 Support field widths and precisions larger than INT_MAX. Avoid
5573 sprintf's undefined behavior with conversion specifications such as %#d
5574 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5575 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5576 formatting out-of-range floating point numbers with int
5579 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5581 * data.c: Avoid integer truncation in expressions involving floats.
5582 * data.c: Include <intprops.h>.
5583 (arith_driver): When there's an integer overflow in an expression
5584 involving floating point, convert the integers to floating point
5585 so that the resulting value does not suffer from catastrophic
5586 integer truncation. For example, on a 64-bit host (* 4
5587 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5588 Do not rely on undefined behavior after integer overflow.
5590 merge count_size_as_multibyte, parse_str_to_multibyte
5591 * character.c, character.h (count_size_as_multibyte):
5592 Rename from parse_str_to_multibyte; all uses changed.
5593 Check for integer overflow.
5594 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5595 since it's now a duplicate of the other. This is more of
5596 a character than a buffer op, so better that it's in character.c.
5597 * fns.c, print.c: Adjust to above changes.
5599 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5601 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5603 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5605 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5606 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5607 (x_clipboard_manager_save): Now static.
5608 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5610 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5611 (crypto_hash_function): Now static.
5612 Fix pointer signedness problems. Avoid unnecessary initializations.
5614 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5616 * termhooks.h (Vselection_alist): Make it terminal-local.
5618 * terminal.c (create_terminal): Initialize it.
5620 * xselect.c: Support for clipboard managers.
5621 (Vselection_alist): Move to termhooks.h as terminal-local var.
5622 (LOCAL_SELECTION): New macro.
5623 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5624 (symbol_to_x_atom): Remove gratuitous arg.
5625 (x_handle_selection_request, lisp_data_to_selection_data)
5626 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5627 (x_own_selection, x_get_local_selection, x_convert_selection):
5628 New arg, specifying work frame. Use terminal-local Vselection_alist.
5629 (some_frame_on_display): Delete unused function.
5630 (Fx_own_selection_internal, Fx_get_selection_internal)
5631 (Fx_disown_selection_internal, Fx_selection_owner_p)
5632 (Fx_selection_exists_p): New optional frame arg.
5633 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5634 (x_handle_selection_clear): Don't treat other terminals with the
5635 same keyboard specially. Use the terminal-local Vselection_alist.
5636 (x_clear_frame_selections): Use Frun_hook_with_args.
5638 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5640 * xterm.h: Add support for those atoms.
5642 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5644 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5645 (converted_selections, conversion_fail_tag): New global variables.
5646 (x_selection_request_lisp_error): Free the above.
5647 (x_get_local_selection): Remove unnecessary code.
5648 (x_reply_selection_request): Args changed; handle arbitrary array
5649 of converted selections stored in converted_selections.
5650 Separate the XChangeProperty and SelectionNotify steps.
5651 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5652 (x_convert_selection): New function.
5653 (x_handle_selection_event): Simplify.
5654 (x_get_foreign_selection): Don't ignore incoming requests while
5655 waiting for an answer; this will fail when we implement
5656 SAVE_TARGETS, and seems unnecessary anyway.
5657 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5658 (Vx_sent_selection_functions): Doc fix.
5660 2011-05-26 Leo Liu <sdl.web@gmail.com>
5662 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5664 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5666 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5668 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5669 for fringe update if it has periodic bitmap.
5670 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5671 and fringe_bitmap_periodic_p.
5673 * fringe.c (get_fringe_bitmap_data): New function.
5674 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5675 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5676 row. Mark glyph row for fringe update if periodicity changed.
5678 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5679 for fringe update unless it has periodic bitmap.
5681 2011-05-25 Kenichi Handa <handa@m17n.org>
5683 * xdisp.c (get_next_display_element): Set correct it->face_id for
5684 a static composition.
5686 2011-05-24 Leo Liu <sdl.web@gmail.com>
5689 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5691 * fns.c (crypto_hash_function, Fsha1): New function.
5692 (Fmd5): Use crypto_hash_function.
5693 (syms_of_fns): Add Ssha1.
5695 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5697 * gnutls.c: Remove unused macros.
5698 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5699 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5700 Remove macros that are defined and never used.
5701 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5703 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5705 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5706 (Fx_get_selection_internal): Minor cleanup.
5707 (Fx_own_selection_internal): Rename arguments for consistency with
5710 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5712 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5714 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5716 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5718 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5720 * dispnew.c (scrolling_window): Don't exclude the case that the
5721 last enabled row in the desired matrix touches the bottom boundary.
5723 2011-05-21 Glenn Morris <rgm@gnu.org>
5725 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5726 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5727 and add some more files.
5729 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5731 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5732 report_file_error introduced by the change from 2011-05-07.
5734 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5736 * systime.h (Time): Define only if emacs is defined.
5737 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5738 where the include path doesn't have X11/X.h by default. See
5739 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5741 2011-05-20 Kenichi Handa <handa@m17n.org>
5743 * composite.c (find_automatic_composition): Fix previous change.
5745 2011-05-20 Glenn Morris <rgm@gnu.org>
5747 * lisp.mk: New file, split from Makefile.in.
5748 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5749 (shortlisp): Remove.
5750 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5752 2011-05-19 Glenn Morris <rgm@gnu.org>
5754 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5755 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5756 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5757 (lisp): Set the order to that of loadup.el.
5758 (shortlisp): Make it a copy of $lisp.
5759 (SOME_MACHINE_LISP): Remove.
5760 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5761 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5763 2011-05-18 Kenichi Handa <handa@m17n.org>
5765 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5766 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5767 (find_automatic_composition): Mostly rewrite for efficiency.
5769 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5771 * makefile.w32-in: Update dependencies.
5773 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5775 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5776 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5778 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5780 Fix some integer overflow issues, such as string length overflow.
5782 * insdel.c (count_size_as_multibyte): Check for string overflow.
5784 * character.c (lisp_string_width): Check for string overflow.
5785 Use EMACS_INT, not int, for string indexes and lengths; in
5786 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5787 the resulting string length overflows an EMACS_INT; instead,
5788 report a string overflow if no precision given. When checking for
5789 precision exhaustion, use a check that cannot possibly have
5790 integer overflow. (Bug#8675)
5791 * character.h (lisp_string_width): Adjust to new signature.
5793 * alloc.c (string_overflow): New function.
5794 (Fmake_string): Use it. This doesn't change behavior, but saves
5795 a few bytes and will simplify future changes.
5796 * character.c (string_escape_byte8): Likewise.
5797 * lisp.h (string_overflow): New decl.
5799 Fixups, following up to the user-interface timestamp change.
5800 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5801 for UI timestamps, instead of unsigned long.
5802 * msdos.c (mouse_get_pos): Likewise.
5803 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5804 * w32gui.h (Time): Define by including "systime.h" rather than by
5805 declaring it ourselves. (Bug#8664)
5807 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5808 * image.c (clear_image_cache): Likewise.
5810 * term.c (term_mouse_position): Don't assume time_t wraparound.
5812 Be more systematic about user-interface timestamps.
5813 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5814 and sometimes 'EMACS_UINT', to represent these timestamps.
5815 This change causes it to use 'Time' uniformly, as that's what X uses.
5816 This makes the code easier to follow, and makes it easier to catch
5817 integer overflow bugs such as Bug#8664.
5818 * frame.c (Fmouse_position, Fmouse_pixel_position):
5819 Use Time, not unsigned long, for user-interface timestamps.
5820 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5821 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5822 * keyboard.h (last_event_timestamp): Likewise.
5823 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5824 * menu.h (xmenu_show): Likewise.
5825 * term.c (term_mouse_position): Likewise.
5826 * termhooks.h (struct input_event.timestamp): Likewise.
5827 (struct terminal.mouse_position_hook): Likewise.
5828 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5829 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5830 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5831 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5833 * menu.h, termhooks.h: Include "systime.h", for Time.
5835 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5836 Don't assume that the difference between two unsigned long values
5837 can fit into an integer. At this point, we know button_down_time
5838 <= event->timestamp, so the difference must be nonnegative, so
5839 there's no need to cast the result if double-click-time is
5840 nonnegative, as it should be; check that it's nonnegative, just in
5841 case. This bug is triggered when events are more than 2**31 ms
5842 apart (about 25 days). (Bug#8664)
5844 * xselect.c (last_event_timestamp): Remove duplicate decl.
5845 (x_own_selection): Remove needless cast to unsigned long.
5847 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5848 that always fit in int. Use a sentinel instead of a counter, to
5849 avoid a temp and to allay GCC's concerns about possible int overflow.
5850 * frame.h (struct frame): Use int for menu_bar_items_used
5851 instead of EMACS_INT, since it always fits in int.
5853 * menu.c (grow_menu_items): Check for int overflow.
5855 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5857 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5858 Before, the code was not consistent. These values cannot exceed
5859 2**31 - 1 so there's no need to make them unsigned.
5860 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5861 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5862 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5864 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5866 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5867 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5868 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5869 presumably because the widths might not match.
5871 * window.c (size_window): Avoid needless test at loop start.
5873 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5875 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5877 2011-05-12 Drew Adams <drew.adams@oracle.com>
5879 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5881 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5883 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5884 `width' to `bar_area_x' and `bar_area_width', respectively.
5885 (x_scroll_run): Take account of fringe background extension.
5887 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5888 Rename local vars `left' and `width' to `bar_area_x' and
5889 `bar_area_width', respectively.
5890 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5891 background extension.
5893 2011-05-10 Jim Meyering <meyering@redhat.com>
5895 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5897 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5899 * image.c (Finit_image_library): Return t for built-in image types,
5900 like pbm and xbm. (Bug#8640)
5902 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5904 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5906 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5908 * w32console.c (Fset_screen_color): Doc fix.
5909 (Fget_screen_color): New function.
5910 (syms_of_ntterm): Defsubr it.
5912 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5913 unlink the temporary file if Fcall_process didn't create it in the
5915 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5916 child process will be redirected to a file specified with `:file'.
5917 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5918 cue to call_process_cleanup not to close that handle.
5920 2011-05-07 Ben Key <bkey76@gmail.com>
5922 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5923 one of two shell specific rules, either bootstrap-temacs-CMD or
5924 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5925 to the previous implementation of the bootstrap-temacs rule.
5926 The bootstrap-temacs-CMD rule is similar to the previous
5927 implementation of the bootstrap-temacs rule except that it
5928 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5931 These changes, along with some changes to nt/configure.bat,
5932 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5933 earlier fix to add support for --cflags and --ldflags options
5934 that include quotes so that it works whether make uses cmd or
5937 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5939 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5940 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5942 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5943 a string. Handle both cases.
5944 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5945 (Fdbus_register_method): Use Qinvalid_function.
5947 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5949 * makefile.w32-in: Update dependencies.
5950 (LISP_H): Add inttypes.h and stdin.h.
5951 (PROCESS_H): Add unistd.h.
5953 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5955 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5956 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5958 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5960 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5962 * term.c (vfatal): Remove stray call to va_end.
5963 It's not needed and the C Standard doesn't allow it here anyway.
5965 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5966 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5968 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5971 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5973 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5975 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5977 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5979 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5981 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5982 * charset.c (Fdefine_charset_internal): Don't initialize
5983 charset.code_space[15]. The value was garbage, on hosts with
5984 32-bit int (Bug#8600).
5986 * lread.c (read_integer): Be more consistent with string-to-number.
5987 Use string_to_number to do the actual conversion; this avoids
5988 rounding errors and fixes some other screwups. Without this fix,
5989 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5990 (digit_to_number): Move earlier, for benefit of read_integer.
5991 Return -1 if the digit is out of range for the base, -2 if it is
5992 not a digit in any supported base. (Bug#8602)
5994 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5996 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5997 to match comment at start of function. This also removes a
5998 GCC warning about overflow in a 32+64-bit port.
6000 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6002 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6003 Reported by Stefan Monnier in
6004 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6005 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6006 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6008 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6009 (EMACS_UINTPTR): Likewise, with uintptr_t.
6011 * lisp.h: Prefer 64-bit EMACS_INT if available.
6012 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6013 on 32-bit hosts that have 64-bit int, so that they can access
6015 However, temporarily disable this change unless the temporary
6016 symbol WIDE_EMACS_INT is defined.
6018 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6020 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6021 This removes an assumption that EMACS_INT and long are the same
6022 width as pointers. The assumption is true for Emacs porting targets
6023 now, but we want to make other targets possible.
6024 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6025 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6026 In the rest of the code, change types of integers that hold casted
6027 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6028 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6029 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6030 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6031 No need to cast type when ORing.
6032 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6033 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6034 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6035 assume EMACS_INT is the same width as char *.
6036 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6037 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6038 Remove no-longer-needed casts.
6039 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6040 (xg_tool_bar_help_callback, xg_make_tool_item):
6041 Use EMACS_INTPTR to hold an integer
6042 that will be cast to void *; this can avoid a GCC warning
6043 if EMACS_INT is not the same width as void *.
6044 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6045 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6046 (current_message_1, set_message_1):
6047 Use a local to convert to proper width without a cast.
6048 * xmenu.c (dialog_selection_callback): Likewise.
6050 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6051 Also, don't assume VALBITS / RAND_BITS is less than 5,
6052 and don't rely on undefined behavior when shifting a 1 left into
6054 * lisp.h (get_random): Change signature to match.
6056 * lread.c (hash_string): Use size_t, not int, for hash computation.
6057 Normally we prefer signed values; but hashing is special, because
6058 it's better to use unsigned division on hash table sizes so that
6059 the remainder is nonnegative. Also, size_t is the natural width
6060 for hashing into memory. The previous code used 'int', which doesn't
6061 retain enough info to hash well into very large tables.
6062 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6064 * dbusbind.c: Don't possibly lose pointer info when converting.
6065 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6066 Use XPNTR rather than XHASH, so that the high-order bits of
6067 the pointer aren't lost when converting through void *.
6069 * eval.c (Fautoload): Don't double-shift a pointer.
6071 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6073 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6075 * gnutls.c (DEF_GNUTLS_FN):
6076 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6078 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6080 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6083 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6085 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6086 New version that can reserve upto 2GB of heap space.
6088 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6090 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6092 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6094 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6095 `gnutls_certificate_set_x509_key_file'.
6097 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6099 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6100 Update dependencies.
6102 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6104 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6105 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6106 Remove unused parameter `fildes'.
6107 * process.c (read_process_output, send_process): Don't pass it.
6109 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6111 Fix previous change: the library cache is defined in w32.c.
6112 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6113 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6115 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6117 Implement dynamic loading of GnuTLS on Windows.
6119 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6120 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6121 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6124 * gnutls.c (Qgnutls_dll): Define.
6125 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6126 (gnutls_*): Declare function pointers.
6127 (init_gnutls_functions): New function to initialize function pointers.
6128 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6129 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6130 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6131 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6132 (emacs_gnutls_write, emacs_gnutls_read)
6133 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6134 (Fgnutls_available_p): New function.
6135 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6136 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6137 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6139 * image.c: Include w32.h.
6140 (Vimage_type_cache): Delete.
6141 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6142 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6143 (w32_delayed_load): Move to w32.c.
6145 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6147 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6148 (w32_delayed_load): Move from image.c. When loading a library, record
6149 its filename in the :loaded-from property of the library id.
6150 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6151 Initialize and staticpro them.
6152 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6154 * process.c: Include lisp.h before w32.h, not after.
6155 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6156 instead of gnutls_record_check_pending.
6158 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6160 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6162 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6163 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6166 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6168 * xterm.c (x_set_frame_alpha): Do not set property on anything
6169 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6171 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6173 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6175 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6177 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6178 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6179 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6180 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6181 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6182 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6183 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6184 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6185 (Qgnutls_bootprop_callbacks_verify): Make static.
6187 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6189 * callproc.c: Indentation fixup.
6191 * sysdep.c (wait_for_termination_1): Make static.
6192 (wait_for_termination, interruptible_wait_for_termination):
6193 Move after wait_for_termination_1.
6195 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6197 * sysdep.c (interruptible_wait_for_termination): New function
6198 which is like wait_for_termination, but allows keyboard
6201 * callproc.c (Fcall_process): Add (:file "file") as an option for
6203 (Fcall_process_region): Ditto.
6205 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6207 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6208 rather than `XVECTOR (FOO)->size'.
6210 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6211 inttypes.h, as a gnulib replacement is used if it not available in
6214 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6216 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6217 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6218 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6220 * coding.c (coding_alloc_by_realloc): Error out if destination
6221 will grow beyond MOST_POSITIVE_FIXNUM.
6222 (decode_coding_emacs_mule): Abort if there isn't enough place in
6223 charbuf for the composition carryover bytes. Reserve an extra
6224 space for up to 2 characters produced in a loop.
6225 (decode_coding_iso_2022): Abort if there isn't enough place in
6226 charbuf for the composition carryover bytes.
6228 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6230 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6231 aborting when %lld or %lll format is passed.
6232 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6233 %llo or %llx format is passed. (Bug#8545)
6235 * window.c (window_scroll_line_based): Use a marker instead of
6236 simple variables to record original value of point. (Bug#7952)
6238 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6239 produced by %s or %c overflows available buffer space. (Bug#8545)
6241 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6243 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6244 (SIZE_MAX): Move defn after all includes, as they might #define it.
6246 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6248 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6250 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6252 * keyboard.c (Qdelayed_warnings_hook): Define.
6253 (command_loop_1): Run `delayed-warnings-hook'
6254 if Vdelayed_warnings_list is non-nil.
6255 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6256 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6258 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6260 * doprnt.c (doprnt): Don't return value smaller than the buffer
6261 size if the message was truncated. (Bug#8545).
6263 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6265 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6266 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6268 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6270 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6272 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6274 * makefile.w32-in: Update dependencies.
6276 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6278 Improve `doprnt' and its usage. (Bug#8545)
6279 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6280 `format_end'. Remove support for %l as a conversion specifier.
6281 Don't use xrealloc. Improve diagnostics when the %l size modifier
6282 is used. Update the commentary.
6284 * eval.c (verror): Simplify calculation of size_t.
6286 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6289 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6291 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6294 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6296 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6297 This makes this file independent of the recent pseudovector change.
6299 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6301 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6303 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6304 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6305 Remove unused local.
6306 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6308 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6309 GCC 4.6.0 optimizes based on type-based alias analysis.
6310 For example, if b is of type struct buffer * and v of type struct
6311 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6312 != &v->size, and therefore "v->size = 1; b->size = 2; return
6313 v->size;" must therefore return 1. This assumption is incorrect
6314 for Emacs, since it type-puns struct Lisp_Vector * with many other
6315 types. To fix this problem, this patch adds a new type struct
6316 vectorlike_header that documents the constraints on layout of vectors
6317 and pseudovectors, and helps optimizing compilers not get fooled
6318 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6319 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6320 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6322 (XSETPVECTYPE): Rewrite in terms of new macro.
6323 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6324 This is a bit clearer, and further avoids the possibility of
6325 undesirable aliasing.
6326 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6327 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6328 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6329 since Lisp_Subr is a special case (no "next" field).
6330 (ASIZE): Now uses header.size rather than size.
6331 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6332 to avoid the hassle of writing XVECTOR (foo)->header.size.
6333 (struct vectorlike_header): New type.
6334 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6335 object, to help avoid aliasing.
6336 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6337 (SUBRP): Likewise, since Lisp_Subr is a special case.
6338 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6339 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6340 (struct Lisp_Hash_Table): Combine first two members into a single
6341 struct vectorlike_header member. All uses of "size" and "next" members
6342 changed to be "header.size" and "header.next".
6343 * buffer.h (struct buffer): Likewise.
6344 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6345 * frame.h (struct frame): Likewise.
6346 * process.h (struct Lisp_Process): Likewise.
6347 * termhooks.h (struct terminal): Likewise.
6348 * window.c (struct save_window_data, struct saved_window): Likewise.
6349 * window.h (struct window): Likewise.
6350 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6351 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6352 * buffer.c (init_buffer_once): Likewise.
6353 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6355 * process.c (Fformat_network_address): Use local var for size,
6358 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6360 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6361 * data.c (atof): Remove decl; no longer used or needed.
6362 (digit_to_number): Move to lread.c.
6363 (Fstring_to_number): Use new string_to_number function, to be
6364 consistent with how the Lisp reader treats infinities and NaNs.
6365 Do not assume that floating-point numbers represent EMACS_INT
6366 without losing information; this is not true on most 64-bit hosts.
6367 Avoid double-rounding errors, by insisting on integers when
6368 parsing non-base-10 numbers, as the documentation specifies.
6369 * lisp.h (string_to_number): New decl, replacing ...
6370 (isfloat_string): Remove.
6371 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6372 (read1): Do not accept +. and -. as integers; this
6373 appears to have been a coding error. Similarly, do not accept
6374 strings like +-1e0 as floating point numbers. Do not report
6375 overflow for integer overflows unless the base is not 10 which
6376 means we have no simple and reliable way to continue.
6377 Break out the floating-point parsing into a new
6378 function string_to_number, so that Fstring_to_number parses
6379 floating point numbers consistently with the Lisp reader.
6380 (digit_to_number): Move here from data.c. Make it static inline.
6381 (E_CHAR, EXP_INT): Remove, replacing with ...
6382 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6383 (string_to_number): New function, replacing isfloat_string.
6384 This function checks for valid syntax and produces the resulting
6385 Lisp float number too. Rework it so that string-to-number
6386 no longer mishandles examples like "1.0e+". Use strtoumax,
6387 so that overflow for non-base-10 numbers is reported only when
6388 there's no portable and simple way to convert to floating point.
6390 * textprop.c (set_text_properties_1): Rewrite for clarity,
6391 and to avoid GCC warning about integer overflow.
6393 * intervals.h (struct interval): Use EMACS_INT for members
6394 where EMACS_UINT might cause problems. See
6395 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6396 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6397 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6399 (offset_intervals): Tell GCC not to worry about length overflow
6400 when negating a negative length.
6402 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6403 (overrun_check_free): Likewise.
6405 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6406 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6409 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6410 (gnutls_make_error): Rename local to avoid shadowing.
6411 (gnutls_emacs_global_deinit): ifdef out; not used.
6412 (Fgnutls_boot): Use const for pointer to readonly storage.
6413 Comment out unused local. Fix pointer signedness problems.
6415 * lread.c (openp): Don't stuff size_t into an 'int'.
6416 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6417 about possible signed overflow.
6419 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6420 (GDK_KEY_g): Don't define if already defined.
6421 (xg_prepare_tooltip): Avoid pointer signedness problem.
6422 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6424 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6425 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6427 * xfns.c (Fx_window_property): Simplify a bit,
6428 to make a bit faster and to avoid GCC 4.6.0 warning.
6429 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6431 * fns.c (internal_equal): Don't assume size_t fits in int.
6433 * alloc.c (compact_small_strings): Tighten assertion a little.
6435 Replace pEd with more-general pI, and fix some printf arg casts.
6436 * lisp.h (pI): New macro, generalizing old pEd macro to other
6437 conversion specifiers. For example, use "...%"pI"d..." rather
6438 than "...%"pEd"...".
6439 (pEd): Remove. All uses replaced with similar uses of pI.
6440 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6441 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6442 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6443 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6444 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6445 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6446 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6448 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6449 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6450 * print.c (safe_debug_print, print_object): Likewise.
6451 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6453 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6454 avoiding the 0 flag, which is not portable.
6455 * process.c (Fmake_network_process): Use pI to avoid cast.
6456 * region-cache.c (pp_cache): Likewise.
6457 * xdisp.c (decode_mode_spec): Likewise.
6458 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6459 behavior on 64-bit hosts with printf arg.
6460 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6461 (x_stop_queuing_selection_requests): Likewise.
6462 (x_get_window_property): Don't truncate byte count to an 'int'
6465 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6466 here, since it parses constructs like leading '-' and spaces,
6467 which are not wanted; and it overflows with large numbers.
6468 Instead, simply match F[0-9]+, which is what is wanted anyway.
6470 * alloc.c: Remove unportable assumptions about struct layout.
6471 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6472 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6473 (allocate_vectorlike, make_pure_vector): Use the new macros,
6474 plus offsetof, to remove unportable assumptions about struct layout.
6475 These assumptions hold on all porting targets that I know of, but
6476 they are not guaranteed, they're easy to remove, and removing them
6477 makes further changes easier.
6479 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6480 This doesn't fix a bug but makes the code clearer.
6481 (string_overrun_cookie): Now const. Use initializers that
6482 don't formally overflow signed char, to avoid warnings.
6483 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6484 can cause Emacs to crash when string overrun checking is enabled.
6485 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6486 multiple of sizeof (EMACS_INT); it need not be, if
6487 alignof(EMACS_INT) < sizeof (EMACS_INT).
6488 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6490 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6492 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6494 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6496 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6497 supposed to be handshaking. (Bug#8556)
6498 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6500 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6502 * lisp.h (Qdebug): List symbol.
6503 * eval.c (Qdebug): Restore global linkage.
6504 * keyboard.c (debug-on-event): New variable.
6505 (handle_user_signal): Break into debugger when debug-on-event
6506 matches the current signal symbol.
6508 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6510 * alloc.c (check_sblock, check_string_bytes)
6511 (check_string_free_list): Convert to standard C.
6513 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6515 * w32.c (emacs_gnutls_push): Fix typo.
6517 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6519 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6520 "cast to pointer from integer of different size".
6522 Improve doprnt and its use in verror. (Bug#8545)
6523 * doprnt.c (doprnt): Document the set of format control sequences
6524 supported by the function. Use SAFE_ALLOCA instead of always
6527 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6528 is one byte too soon. Don't use xrealloc; instead xfree and
6531 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6533 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6536 * gnutls.c: Renamed global_initialized to
6537 gnutls_global_initialized. Added internals for the
6538 :verify-hostname-error, :verify-error, and :verify-flags
6539 parameters of `gnutls-boot' and documented those parameters in the
6540 docstring. Start callback support.
6541 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6542 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6543 on error. Return error code.
6544 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6545 (emacs_gnutls_read): Likewise.
6546 (Fgnutls_boot): Return handshake error code.
6547 (emacs_gnutls_handle_error): New function.
6548 (wsaerror_to_errno): Likewise.
6550 * w32.h (emacs_gnutls_pull): Add prototype.
6551 (emacs_gnutls_push): Likewise.
6553 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6554 (emacs_gnutls_push): Likewise.
6556 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6558 * process.c (wait_reading_process_output): Check if GnuTLS
6559 buffered some data internally if no FDs are set for TLS
6562 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6563 (LIBS): Link to USER_LIBS.
6564 ($(BLD)/gnutls.$(0)): New target.
6566 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6568 * xdisp.c (handle_single_display_spec): Rename the
6569 display_replaced_before_p argument into display_replaced_p, to
6570 make it consistent with the commentary. Fix typos in the
6573 * textprop.c (syms_of_textprop): Remove dead code.
6574 (copy_text_properties): Delete obsolete commentary about an
6575 interface that was deleted long ago. Fix typos in the description
6578 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6579 to changes in oldXMenu/XMenu.h from 2011-04-16.
6580 <menu_help_message, prev_menu_help_message>: Constify.
6581 (IT_menu_make_room): menu->help_text is now `const char **';
6584 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6585 to changes in oldXMenu/XMenu.h from 2011-04-16.
6586 (struct XMenu): Declare `help_text' `const char **'.
6588 * xfaces.c <Qunspecified>: Make extern again.
6590 * syntax.c: Include sys/types.h before including regex.h, as
6593 * doc.c (get_doc_string): Improve the format passed to `error'.
6595 * doprnt.c (doprnt): Improve commentary.
6597 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6599 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6602 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6603 changes in globals.h immediately force recompilation.
6604 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6605 $(CURDIR)/s/ms-w32.h.
6606 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6608 * character.c (Fchar_direction): Function deleted.
6609 (syms_of_character): Don't defsubr it.
6610 <char-direction-table>: Deleted.
6612 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6614 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6615 * doprnt.c: Include limits.h.
6616 (SIZE_MAX): New macro.
6617 (doprnt): Return a size_t value. 2nd arg is now size_t.
6618 Many local variables are now size_t instead of int or unsigned.
6619 Improve overflow protection. Support `l' modifier for integer
6620 conversions. Support %l conversion. Don't assume an EMACS_INT
6621 argument for integer conversions and for %c.
6623 * lisp.h (doprnt): Restore prototype.
6625 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6628 * Makefile.in (base_obj): Add back doprnt.o.
6630 * deps.mk (doprnt.o): Add back prerequisites.
6631 (callint.o): Depend on character.h.
6633 * eval.c (internal_lisp_condition_case): Include the handler
6634 representation in the error message.
6635 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6636 when breaking from the loop.
6638 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6640 * callint.c (Fcall_interactively): When displaying error message
6641 about invalid control letter, pass the character's codepoint, not
6642 a pointer to its multibyte form. Improve display of the character
6643 in octal and display also its hex code.
6645 * character.c (char_string): Use %x to display the (unsigned)
6646 codepoint of an invalid character, to avoid displaying a bogus
6649 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6650 `error', not SYMBOL_NAME itself.
6652 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6653 character arguments to `error'.
6655 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6656 to `error' in error message about FINAL_CHAR argument. Make sure
6657 FINAL_CHAR is a character, and use %c when it is passed as
6658 argument to `error'.
6660 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6662 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6664 * w32.c: Include <time.h>.
6665 (sys_localtime): New function.
6667 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6669 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6671 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6673 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6675 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6678 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6680 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6681 gl_state.e_property when gl_state.object is Qt.
6683 * insdel.c (make_gap_larger): Remove limitation of buffer size
6686 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6688 * xdisp.c (lookup_glyphless_char_display)
6689 (produce_glyphless_glyph): Handle cons cell entry in
6690 glyphless-char-display.
6691 (Vglyphless_char_display): Document it.
6693 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6694 glyphless-char-display.
6696 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6698 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6700 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6702 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6703 definition for no-X builds.
6705 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6707 Static checks with GCC 4.6.0 and non-default toolkits.
6709 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6711 * process.c (keyboard_bit_set): Define only if SIGIO.
6712 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6713 (send_process): Repair possible setjmp clobbering.
6715 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6717 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6719 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6721 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6722 Define only if needed.
6724 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6725 by pacifying GCC about it. Maybe it's time to retire it?
6726 * xfaces.c (USG, __TIMEVAL__): Likewise.
6728 * dispextern.h (struct redisplay_interface): Rename param
6730 * termhooks.h (struct terminal): Likewise.
6731 * xterm.c (xembed_send_message): Likewise.
6733 * insdel.c (make_gap_smaller): Define only if
6734 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6736 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6739 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6740 so that we aren't warned about unused symbols.
6742 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6744 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6746 * xfns.c (x_real_positions): Mark locals as initialized.
6748 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6750 * xterm.c: Fix problems found by static analysis with other toolkits.
6751 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6752 (x_dispatch_event): Declare static if USE_GTK, and
6753 define if USE_GTK || USE_X_TOOLKIT.
6754 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6755 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6756 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6757 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6759 * xmenu.c (menu_help_callback): Pointer type fixes.
6760 Use const pointers when pointing at readonly data. Avoid pointer
6762 (FALSE): Remove unused macro.
6763 (update_frame_menubar): Remove unused decl.
6765 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6767 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6768 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6769 (single_menu_item): Rename local to avoid shadowing.
6771 * keyboard.c (make_lispy_event): Remove unused local var.
6773 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6774 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6776 * bitmaps: Change bitmaps from unsigned char back to the X11
6777 compatible char. Avoid the old compiler warnings about
6778 out-of-range initializers by using, for example, '\xab' rather
6781 * xgselect.c (xgselect_initialize): Check vs interface
6782 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6784 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6786 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6787 to read-only memory.
6789 * fns.c (vector): Remove; this old hack is no longer needed.
6791 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6793 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6795 * xrdb.c (x_load_resources): Omit unused local.
6797 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6798 (x_window): Rename locals to avoid shadowing.
6799 (USG): Use the kludged USG macro, to pacify gcc.
6801 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6802 (x_term_init): Remove local to avoid shadowing.
6804 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6806 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6807 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6809 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6811 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6813 Fix regex.c, syntax.c and friends for buffers > 2GB.
6814 * syntax.h (struct gl_state_s): Declare character position members
6817 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6819 * textprop.c (verify_interval_modification, interval_of):
6820 Declare arguments EMACS_INT.
6822 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6825 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6827 * indent.c (Fvertical_motion): Local variable it_start is now
6830 * regex.c (re_match, re_match_2, re_match_2_internal)
6831 (bcmp_translate, regcomp, regexec, print_double_string)
6832 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6833 (re_compile_pattern, re_exec): Declare arguments and local
6834 variables `size_t' and `ssize_t' and return values `regoff_t', as
6836 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6837 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6838 <compile_stack_type>: `size' and `avail' are now `size_t'.
6840 * regex.h <regoff_t>: Use ssize_t, not int.
6841 (re_search, re_search_2, re_match, re_match_2): Arguments that
6842 specify buffer/string position and length are now ssize_t and
6843 size_t. Return type is regoff_t.
6845 2011-04-16 Ben Key <bkey76@gmail.com>
6847 * nsfont.m: Fixed bugs in ns_get_family and
6848 ns_descriptor_to_entity that were caused by using free to
6849 deallocate memory blocks that were allocated by xmalloc (via
6850 xstrdup). This caused Emacs to crash when compiled with
6851 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6852 --enable-checking=xmallocoverrun). xfree is now used to
6853 deallocate these memory blocks.
6855 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6857 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6859 emacs_write: Accept and return EMACS_INT for sizes.
6860 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6862 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6863 Accept and return EMACS_INT.
6864 (emacs_gnutls_write): Return the number of bytes written on
6866 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6867 (emacs_read, emacs_write): Remove check for negative size, as the
6868 Emacs source code has been audited now.
6869 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6870 (emacs_read, emacs_write): Use it.
6871 * process.c (send_process): Adjust to the new signatures of
6872 emacs_write and emacs_gnutls_write. Do not attempt to store
6873 a byte offset into an 'int'; it might overflow.
6874 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6876 * sound.c: Don't assume sizes fit in 'int'.
6877 (struct sound_device.period_size, alsa_period_size):
6878 Return EMACS_INT, not int.
6879 (struct sound_device.write, vox_write, alsa_write):
6880 Accept EMACS_INT, not int.
6881 (wav_play, au_play): Use EMACS_INT to store sizes and to
6882 record read return values.
6884 2011-04-15 Ben Key <bkey76@gmail.com>
6886 * keyboard.c (Qundefined): Don't declare static since it is used
6888 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6889 static since they are used in nsfont.m.
6891 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6893 * process.c (Qprocessp): Don't declare static.
6894 * lisp.h (Qprocessp): Declare again.
6896 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6898 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6900 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6902 Improve C-level modularity by making more things 'static'.
6904 Don't publish debugger-only interfaces to other modules.
6905 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6906 (verify_bytepos, count_markers): Move decls to the only modules
6908 * region-cache.h (pp_cache): Likewise.
6909 * window.h (check_all_windows): Likewise.
6910 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6912 * sysdep.c (croak): Now static, if
6913 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6914 * syssignal.h (croak): Declare only if not static.
6916 * alloc.c (refill_memory_reserve): Now static if
6917 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6918 * lisp.h (refill_memory_reserve): Declare only if not static.
6920 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6921 Define only if USE_LUCID.
6923 * xrdb.c (x_customization_string, x_rm_string): Now static.
6925 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6926 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6928 * xdisp.c (draw_row_with_mouse_face): Now static.
6929 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6931 * window.h (check_all_windows): Mark externally visible.
6933 * window.c (window_deletion_count): Now static.
6935 * undo.c: Make symbols static if they're not exported.
6936 (last_undo_buffer, last_boundary_position, pending_boundary):
6939 * textprop.c (interval_insert_behind_hooks): Now static.
6940 (interval_insert_in_front_hooks): Likewise.
6942 * term.c: Make symbols static if they're not exported.
6943 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6944 (max_frame_lines, tty_set_terminal_modes):
6945 (tty_reset_terminal_modes, tty_turn_off_highlight):
6946 (get_tty_terminal): Now static.
6947 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6948 * termhooks.h (term_mouse_moveto): Do not declare if
6950 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6951 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6953 * sysdep.c: Make symbols static if they're not exported.
6954 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6956 (sigprocmask_set, full_mask): Remove; unused.
6957 (wait_debugging): Mark as visible.
6958 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6959 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6961 * syntax.c (syntax_temp): Define only if !__GNUC__.
6963 * sound.c (current_sound_device, current_sound): Now static.
6965 * search.c (searchbufs, searchbuf_head): Now static.
6967 * scroll.c (scroll_cost): Remove; unused.
6968 * dispextern.h (scroll_cost): Remove decl.
6970 * region-cache.h (pp_cache): Mark as externally visible.
6972 * process.c: Make symbols static if they're not exported.
6973 (process_tick, update_tick, create_process, chan_process):
6974 (Vprocess_alist, proc_buffered_char, datagram_access):
6975 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6976 (deactivate_process): Mark defn as static, as well as decl.
6977 * lisp.h (create_process): Remove decl.
6978 * process.h (chan_process, Vprocess_alist): Remove decls.
6980 * print.c: Make symbols static if they're not exported.
6981 (print_depth, new_backquote_output, being_printed, print_buffer):
6982 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6983 (print_interval, print_number_index, initial_stderr_stream):
6985 * lisp.h (Fprinc): Remove decl.
6986 (debug_output_compilation_hack): Mark as externally visible.
6988 * sysdep.c (croak): Move decl from here to syssignal.h.
6989 * syssignal.h (croak): Put it here, so the API can be checked when
6990 'croak' is called from dissociate_if_controlling_tty.
6992 * minibuf.c: Make symbols static if they're not exported.
6993 (minibuf_save_list, choose_minibuf_frame): Now static.
6994 * lisp.h (choose_minibuf_frame): Remove decl.
6996 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6998 * lread.c: Make symbols static if they're not exported.
6999 (read_objects, initial_obarray, oblookup_last_bucket_number):
7001 (make_symbol): Remove; unused.
7002 * lisp.h (initial_obarray, make_symbol): Remove decls.
7004 * keyboard.c: Make symbols static if they're not exported.
7005 (single_kboard, recent_keys_index, total_keys, recent_keys):
7006 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7007 (this_single_command_key_start, echoing, last_auto_save):
7008 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7009 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7010 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7011 (Vlispy_mouse_stem, double_click_count):
7013 (force_auto_save_soon): Define only if SIGDANGER.
7014 (ignore_mouse_drag_p): Now static if
7015 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7016 (print_help): Remove; unused.
7017 (stop_character, last_timer_event): Mark as externally visible.
7018 * keyboard.h (ignore_mouse_drag_p): Declare only if
7019 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7020 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7021 * lisp.h (echoing): Remove decl.
7022 (force_auto_save_soon): Declare only if SIGDANGER.
7023 * xdisp.c (redisplay_window): Simplify code, to make it more
7024 obvious that ignore_mouse_drag_p is not accessed if !defined
7025 USE_GTK && !defined HAVE_NS.
7027 * intervals.c: Make symbols static if they're not exported.
7028 (merge_properties_sticky, merge_interval_right, delete_interval):
7030 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7032 * insdel.c: Make symbols static if they're not exported.
7033 However, leave prepare_to_modify_buffer alone. It's never
7034 called from outside this function, but that appears to be a bug.
7035 (combine_after_change_list, combine_after_change_buffer):
7036 (adjust_after_replace, signal_before_change): Now static.
7037 (adjust_after_replace_noundo): Remove; unused.
7038 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7039 (signal_before_change): Remove decls.
7041 * indent.c (val_compute_motion, val_vmotion): Now static.
7043 * image.c: Make symbols static if they're not exported.
7044 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7046 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7047 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7049 * fringe.c (standard_bitmaps): Now static.
7050 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7052 * frame.c: Make symbols static if they're not exported.
7053 (x_report_frame_params, make_terminal_frame): Now static.
7054 (get_frame_param): Now static, unless HAVE_NS.
7055 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7056 (x_get_resource_string): Remove; not used.
7057 * frame.h (make_terminal_frame, x_report_frame_params):
7058 (x_get_resource_string); Remove decls.
7059 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7060 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7062 * font.c, fontset.c: Make symbols static if they're not exported.
7063 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7064 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7065 * font.c (font_close_object): Now static.
7066 * font.h (font_close_object): Remove.
7067 * fontset.c (FONTSET_OBJLIST): Remove.
7068 (free_realized_fontset) #if-0 the body, which does nothing.
7069 (face_suitable_for_char_p): #if-0, as it's never called.
7070 * fontset.h (face_suitable_for_char_p): Remove decl.
7071 * xfaces.c (face_at_string_position):
7072 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7073 since 0 is always ASCII.
7075 * fns.c (weak_hash_tables): Now static.
7077 * fileio.c: Make symbols static if they're not exported.
7078 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7079 (Vwrite_region_annotation_buffers): Now static.
7081 * eval.c: Make symbols static if they're not exported.
7082 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7083 * lisp.h (backtrace_list): Remove decl.
7085 * emacs.c: Make symbols static if they're not exported.
7086 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7087 (fatal_error_code, fatal_error_signal_hook, standard_args):
7089 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7090 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7091 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7092 * lisp.h (fatal_error_signal_hook): Remove decl.
7093 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7095 * editfns.c: Move a (normally-unused) function to its only use.
7096 * editfns.c, lisp.h (get_operating_system_release): Remove.
7097 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7098 worth the hassle of breaking this out.
7100 * xterm.c: Make symbols static if they're not exported.
7101 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7102 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7103 (x_destroy_window, x_delete_display):
7105 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7106 (x_mouse_leave): Remove; unused.
7107 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7108 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7109 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7111 (x_mouse_leave): Declare only if WINDOWSNT.
7112 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7113 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7116 * ftxfont.c: Make symbols static if they're not exported.
7117 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7119 * font.h (ftxfont_driver): Likewise.
7121 * xfns.c: Make symbols static if they're not exported.
7122 (x_last_font_name, x_display_info_for_name):
7123 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7124 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7125 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7126 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7127 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7128 (last_show_tip_args): Now static.
7129 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7130 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7131 (x_screen_planes): Remove; unused.
7132 * dispextern.h (x_screen_planes): Remove decl.
7134 * dispnew.c: Make symbols static if they're not exported.
7135 * dispextern.h (redraw_garbaged_frames, scrolling):
7136 (increment_row_positions): Remove.
7137 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7138 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7140 (redraw_garbaged_frames): Remove; unused.
7142 * xfaces.c: Make symbols static if they're not exported.
7143 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7145 * xterm.h (defined_color): Remove decls.
7146 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7147 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7148 (menu_face_changed_default, defined_color, free_realized_face):
7149 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7150 (ascii_face_of_lisp_face): Remove; unused.
7152 * xdisp.c: Make symbols static if they're not exported.
7153 * dispextern.h (scratch_glyph_row, window_box_edges):
7154 (glyph_to_pixel_coords, set_cursor_from_row):
7155 (get_next_display_element, set_iterator_to_next):
7156 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7157 (show_mouse_face): Remove decls
7158 * frame.h (message_buf_print): Likewise.
7159 * lisp.h (pop_message, set_message, check_point_in_composition):
7161 * xterm.h (set_vertical_scroll_bar): Likewise.
7162 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7163 (message_buf_print, scratch_glyph_row, displayed_buffer):
7164 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7165 (get_next_display_element, show_mouse_face, window_box_edges):
7166 (frame_to_window_pixel_xy, check_point_in_composition):
7167 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7168 (glyph_to_pixel_coords): Remove; unused.
7170 * dired.c (file_name_completion): Now static.
7172 * dbusbind.c (xd_in_read_queued_messages): Now static.
7174 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7175 * data.c (circular_list_error): Remove.
7177 * commands.h (last_point_position, last_point_position_buffer):
7178 (last_point_position_window): Remove decls.
7179 * keyboard.c: Make these variables static.
7181 * coding.h (coding, code_convert_region, encode_coding_gap):
7183 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7184 (iso_code_class, detect_coding, code_convert_region): Now static.
7185 (encode_coding_gap): Remove; unused.
7187 * chartab.c (chartab_chars, chartab_bits): Now static.
7189 * charset.h (charset_iso_8859_1): Remove decl.
7190 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7193 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7194 * ccl.c (Vccl_program_table): Now static.
7195 (check_ccl_update): Remove; unused.
7197 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7198 * category.h: ... from here.
7199 * category.c (check_category_table, set_category_set): Now static.
7201 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7202 * lisp.h: Remove these decls.
7204 * buffer.c (buffer_count): Remove unused var.
7206 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7207 so that it's not optimized away.
7208 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7209 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7210 exported only to the debugger.
7212 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7213 * atimer.h (run_all_atimers): Remove; not exported.
7215 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7216 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7217 was inaccessible from Lisp.
7218 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7219 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7221 alloc.c: Import and export fewer symbols, and remove unused items.
7222 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7224 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7225 it's not optimized away by whole-program optimization.
7226 (message_enable_multibyte, free_misc): Remove.
7227 (catchlist, handlerlist, mark_backtrace):
7228 Declare only if BYTE_MARK_STACK.
7229 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7230 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7231 (message_enable_multibyte): Remove decl.
7232 (free_misc, interval_free_list, float_block, float_block_index):
7233 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7234 (cons_free_list, last_marked_index):
7236 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7237 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7238 (mark_backtrace): Define only if BYTE_MARK_STACK.
7239 * xdisp.c (message_enable_multibyte): Now static.
7241 Declare Lisp_Object Q* variables to be 'static' if not exported.
7242 This makes it easier for human readers (and static analyzers)
7243 to see whether these variables are used from other modules.
7244 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7245 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7246 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7247 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7248 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7249 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7250 * xmenu.c, xselect.c:
7251 Declare Q* vars static if they are not used in other modules.
7252 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7253 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7254 Remove decls of unexported vars.
7255 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7257 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7259 Make Emacs functions such as Fatom 'static' by default.
7260 This makes it easier for human readers (and static analyzers)
7261 to see whether these functions can be called from other modules.
7262 DEFUN now defines a static function. To make the function external
7263 so that it can be used in other C modules, use the new macro DEFUE.
7264 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7265 (Finit_image_library):
7266 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7267 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7268 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7269 Remove decls, since these functions are now static.
7270 (Funintern, Fget_internal_run_time): New decls, since these functions
7271 were already external.
7273 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7274 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7275 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7276 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7277 * keyboard.c, keymap.c, lread.c:
7278 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7279 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7280 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7281 Mark functions with DEFUE instead of DEFUN,
7282 if they are used in other modules.
7283 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7284 decls for now-static functions.
7285 * buffer.h (Fdelete_overlay): Remove decl.
7286 * callproc.c (Fgetenv_internal): Mark as internal.
7287 * composite.c (Fremove_list_of_text_properties): Remove decl.
7288 (Fcomposition_get_gstring): New forward static decl.
7289 * composite.h (Fcomposite_get_gstring): Remove decl.
7290 * dired.c (Ffile_attributes): New forward static decl.
7291 * doc.c (Fdocumntation_property): New forward static decl.
7292 * eval.c (Ffetch_bytecode): New forward static decl.
7293 (Funintern): Remove extern decl; now in .h file where it belongs.
7294 * fileio.c (Fmake_symbolic_link): New forward static decl.
7295 * image.c (Finit_image_library): New forward static decl.
7296 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7297 * intervals.h (Fprevious_property_change):
7298 (Fremove_list_of_text_properties): Remove decls.
7299 * keyboard.c (Fthis_command_keys): Remove decl.
7300 (Fcommand_execute): New forward static decl.
7301 * keymap.c (Flookup_key): New forward static decl.
7302 (Fcopy_keymap): Now static.
7303 * keymap.h (Flookup_key): Remove decl.
7304 * process.c (Fget_process): New forward static decl.
7305 (Fprocess_datagram_address): Mark as internal.
7306 * syntax.c (Fsyntax_table_p): New forward static decl.
7307 (skip_chars): Remove duplicate decl.
7308 * textprop.c (Fprevious_property_change): New forward static decl.
7309 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7311 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7312 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7314 * editfns.c (Fformat): Remove unreachable code.
7316 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7318 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7321 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7323 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7324 when at ZV. (Bug#8487)
7326 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7328 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7330 * keyboard.c (parse_tool_bar_item): Likewise.
7331 * sound.c (sound_cleanup, alsa_close): Likewise.
7332 * termcap.c (tgetent): Likewise.
7333 * xfns.c (x_default_font_parameter): Likewise.
7334 * xsettings.c (read_and_apply_settings): Likewise.
7336 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7337 (overrun_check_free): Protoize.
7339 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7341 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7342 since callers should never pass a negative size.
7343 Change the signature to match that of plain 'read' and 'write'; see
7344 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7345 * lisp.h: Update prototypes of emacs_write and emacs_read.
7347 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7349 * xdisp.c (redisplay_window): Don't try to determine the character
7350 position of the scroll margin if the window start point w->startp
7351 is outside the buffer's accessible region. (Bug#8468)
7353 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7355 Fix write-region and its subroutines for buffers > 2GB.
7356 * fileio.c (a_write, e_write): Modify declaration of arguments and
7357 local variables to support buffers larger than 2GB.
7358 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7360 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7361 argument, local variables, and return value.
7363 * lisp.h: Update prototypes of emacs_write and emacs_read.
7365 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7367 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7369 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7371 Fix more problems found by GCC 4.6.0's static checks.
7373 * xdisp.c (vmessage): Use a better test for character truncation.
7375 * charset.c (load_charset_map): <, not <=, for optimization,
7376 and to avoid potential problems with integer overflow.
7377 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7378 * casetab.c (set_identity, shuffle): Likewise.
7379 * editfns.c (Fformat): Likewise.
7380 * syntax.c (skip_chars): Likewise.
7382 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7383 This also lets GCC 4.6.0 generate slightly better loop code.
7385 * callint.c (Fcall_interactively): <, not <=, for optimization.
7386 (Fcall_interactively): Count the number of arguments produced,
7387 not the number of arguments given. This is simpler and lets GCC
7388 4.6.0 generate slightly better code.
7390 * ftfont.c: Distingish more carefully between FcChar8 and char.
7391 The previous code passed unsigned char * to a functions like
7392 strlen and xstrcasecmp that expect char *, which does not
7393 conform to the C standard.
7394 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7395 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7396 char * when the C standard requires it.
7398 * keyboard.c (read_char): Remove unused var.
7400 * eval.c: Port to Windows vsnprintf (Bug#8435).
7402 (SIZE_MAX): Define if the headers do not.
7403 (verror): Do not give up if vsnprintf returns a negative count.
7404 Instead, grow the buffer. This ports to Windows vsnprintf, which
7405 does not conform to C99. Problem reported by Eli Zaretskii.
7406 Also, simplify the allocation scheme, by avoiding the need for
7407 calling realloc, and removing the ALLOCATED variable.
7409 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7411 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7412 But keep the doprint source code for now, as we might revamp it
7413 and use it again (Bug#8435).
7414 * lisp.h (doprnt): Remove.
7415 * Makefile.in (base_obj): Remove doprnt.o.
7416 * deps.mk (doprnt.o): Remove.
7418 error: Print 32- and 64-bit integers portably (Bug#8435).
7419 Without this change, on typical 64-bit hosts error ("...%d...", N)
7420 was used to print both 32- and 64-bit integers N, which relied on
7422 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7424 * lisp.h (error, verror): Mark as printf-like functions.
7425 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7426 Report overflow in size calculations when allocating printf buffer.
7427 Do not truncate output string at its first null byte.
7428 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7429 Truncate the output at a character boundary, since vsnprintf does not
7431 * charset.c (check_iso_charset_parameter): Convert internal
7432 character to string before calling 'error', since %c now has the
7434 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7435 overflow when computing char to be passed to 'error'. Do not
7436 pass Lisp_Object to 'error'; pass the integer instead.
7437 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7438 formatted with plain %d.
7440 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7442 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7444 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7446 * xterm.c (x_catch_errors): Remove duplicate declaration.
7448 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7450 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7452 2011-04-10 Jim Meyering <meyering@redhat.com>
7454 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7455 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7456 return ssize_t not "int", and use size_t as the buffer length.
7457 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7458 * gnutls.h: Update declarations.
7459 * process.c (read_process_output): Use ssize_t, to match.
7460 (send_process): Likewise.
7462 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7464 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7466 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7468 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7469 Use unsigned char, to match FcChar8 type definition.
7471 * xterm.c (handle_one_xevent):
7472 * xmenu.c (create_and_show_popup_menu):
7473 * xselect.c (x_decline_selection_request)
7474 (x_reply_selection_request): Avoid type-punned deref of X events.
7476 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7478 Fix some uses of `int' instead of EMACS_INT.
7479 * search.c (string_match_1, fast_string_match)
7480 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7481 (scan_buffer, find_next_newline_no_quit)
7482 (find_before_next_newline, search_command, Freplace_match)
7483 (Fmatch_data): Make some `int' variables be EMACS_INT.
7485 * xdisp.c (display_count_lines): 3rd argument and return value now
7486 EMACS_INT. All callers changed.
7487 (pint2hrstr): Last argument is now EMACS_INT.
7489 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7490 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7491 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7492 (decode_coding_utf_16, decode_coding_emacs_mule)
7493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7494 (decode_coding_ccl, decode_coding_charset)
7495 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7496 (decode_coding_iso_2022, decode_coding_emacs_mule)
7497 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7498 <char_offset, last_offset>: Declare EMACS_INT.
7499 (encode_coding_utf_8, encode_coding_utf_16)
7500 (encode_coding_emacs_mule, encode_invocation_designation)
7501 (encode_designation_at_bol, encode_coding_iso_2022)
7502 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7503 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7505 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7506 (encode_invocation_designation): Last argument P_NCHARS is now
7508 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7509 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7511 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7514 * ccl.c (Fccl_execute_on_string): Declare some variables
7517 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7519 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7521 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7523 * process.c (Fformat_network_address): Doc fix.
7525 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7527 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7529 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7531 * keyboard.c (read_char): Call Lisp function help-form-show,
7532 instead of using internal_with_output_to_temp_buffer.
7533 (Qhelp_form_show): New var.
7534 (syms_of_keyboard): Use DEFSYM macro.
7536 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7538 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7540 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7542 * process.c (Flist_processes): Remove to Lisp.
7543 (list_processes_1): Delete.
7545 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7547 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7549 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7551 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7553 Fix more problems found by GCC 4.6.0's static checks.
7555 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7557 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7559 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7561 * xdisp.c (vmessage): Mark as a printf-like function.
7563 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7565 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7567 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7568 printf-like functions.
7569 (tiff_load): Add casts to remove these marks before passing them
7570 to system-supplied API.
7572 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7574 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7575 This avoids several warnings with gcc -Wstrict-overflow.
7576 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7577 directly, rather than having caller test rule sign. This avoids
7578 some unnecessary tests.
7579 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7580 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7581 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7583 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7584 (xfont_open): Avoid unnecessary tests.
7586 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7588 * composite.h, composite.c (composition_gstring_put_cache):
7589 Use EMACS_INT, not int, for length.
7591 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7592 breaking out part of COMPOSITION_DECODE_RULE.
7593 (COMPOSITION_DECODE_RULE): Use it.
7594 * composite.c (get_composition_id): Remove unused local vars,
7595 by using the new macro.
7597 * textprop.c (set_text_properties_1): Change while to do-while,
7598 since the condition is always true at first.
7600 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7601 (interval_deletion_adjustment): Return unsigned value.
7604 * process.c (list_processes_1, create_pty, read_process_output):
7605 (exec_sentinel): Remove vars that were set but not used.
7606 (create_pty): Remove unnecessary "volatile"s.
7607 (Fnetwork_interface_info): Avoid possibility of int overflow.
7608 (read_process_output): Do adaptive read buffering even if carryover.
7609 (read_process_output): Simplify nbytes computation if buffered.
7611 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7613 * syntax.c (scan_words): Remove var that was set but not used.
7614 (update_syntax_table): Use unsigned instead of int.
7616 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7617 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7618 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7620 * print.c (print_error_message): Avoid int overflow.
7622 * font.c (font_list_entities): Redo for clarity,
7623 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7625 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7626 (font_score): Avoid potential overflow in diff calculation.
7628 * fns.c (substring_both): Remove var that is set but not used.
7629 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7631 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7633 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7634 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7635 can always succeed if overflow has undefined behavior.
7637 * search.c (boyer_moore, wordify): Remove vars set but not used.
7638 (wordify): Omit three unnecessary tests.
7640 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7641 All callers changed. This avoids the need for an unused var.
7643 * casefiddle.c (casify_region): Remove var that is set but not used.
7645 * dired.c (file_name_completion): Remove var that is set but not used.
7647 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7649 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7650 (Finsert_file_contents): Remove unnecessary code checking fd.
7652 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7653 Check for integer overflow on size calculations.
7655 * buffer.c (Fprevious_overlay_change): Remove var that is set
7658 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7659 Remove vars that are set but not used.
7660 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7661 (timer_check_2): Mark vars as initialized.
7663 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7665 * image.c (lookup_image): Remove var that is set but not used.
7666 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7668 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7669 that are set but not used.
7671 * xfns.c (make_invisible_cursor): Don't return garbage
7672 if XCreateBitmapFromData fails (Bug#8410).
7674 * xselect.c (x_get_local_selection, x_handle_property_notify):
7675 Remove vars that are set but not used.
7677 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7678 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7680 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7681 Remove var that is set but not used.
7682 (scroll_bar_windows_size): Now size_t, not int.
7683 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7686 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7687 (map_tty_color) [!defined MSDOS]: Likewise.
7689 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7691 * coding.c: Remove vars that are set but not used.
7692 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7693 All callers changed.
7694 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7695 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7696 (decode_coding_charset): Remove vars that are set but not used.
7698 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7699 that is set but not used.
7701 * print.c (print_object): Remove var that is set but not used.
7703 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7704 The gnulib version avoids calling malloc in the usual case,
7705 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7706 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7707 * filelock.c (current_lock_owner): Likewise.
7708 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7709 * sysdep.c: Include allocator.h, careadlinkat.h.
7710 (emacs_no_realloc_allocator): New static constant.
7711 (emacs_readlink): New function.
7712 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7713 ../lib/careadlinkat.h.
7715 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7717 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7718 first non-nil return value).
7720 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7722 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7723 if not defined (Bug#8403).
7725 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7727 * xdisp.c (display_count_lines): Remove parameter `start',
7728 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7729 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7730 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7731 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7732 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7733 and thereabouts. All callers changed.
7734 (get_per_char_metric): Remove parameter `f', unused since
7735 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7737 2011-04-02 Jim Meyering <meyering@redhat.com>
7739 do not dereference NULL upon failed strdup
7740 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7741 (ns_get_family): Likewise.
7743 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7745 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7747 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7749 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7752 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7754 Add lexical binding.
7756 * window.c (Ftemp_output_buffer_show): New fun.
7757 (Fsave_window_excursion):
7758 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7760 * lread.c (lisp_file_lexically_bound_p): New function.
7761 (Fload): Bind Qlexical_binding.
7762 (readevalloop): Remove `evalfun' arg.
7763 Bind Qinternal_interpreter_environment.
7764 (Feval_buffer): Bind Qlexical_binding.
7765 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7767 (syms_of_lread): Declare `lexical-binding'.
7769 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7771 * keyboard.c (eval_dyn): New fun.
7772 (menu_item_eval_property): Use it.
7774 * image.c (parse_image_spec): Use Ffunctionp.
7776 * fns.c (concat, mapcar1): Accept byte-code-functions.
7778 * eval.c (Fsetq): Handle lexical vars.
7779 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7780 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7781 (FletX, Flet): Obey lexical binding.
7782 (Fcommandp): Handle closures.
7783 (Feval): New `lexical' arg.
7784 (eval_sub): New function extracted from Feval. Use it almost
7785 everywhere where Feval was used. Look up vars in lexical env.
7787 (Ffunctionp): Move from subr.el.
7788 (Ffuncall): Handle closures.
7789 (apply_lambda): Remove `eval_flags'.
7790 (funcall_lambda): Handle closures and new byte-code-functions.
7791 (Fspecial_variable_p): New function.
7792 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7793 but without exporting it to Lisp.
7795 * doc.c (Fdocumentation, store_function_docstring):
7796 * data.c (Finteractive_form): Handle closures.
7798 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7801 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7803 (exec_byte_code): New function extracted from Fbyte_code to handle new
7804 calling convention for byte-code-functions. Add new byte-codes.
7806 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7808 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7810 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7812 * xdisp.c (redisplay_internal): Fix prototype.
7814 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7816 * xdisp.c (SCROLL_LIMIT): New macro.
7817 (try_scrolling): Use it when setting scroll_limit.
7818 Limit scrolling to 100 screen lines.
7819 (redisplay_window): Even when falling back on "recentering",
7820 position point in the window according to scroll-conservatively,
7821 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7823 (try_scrolling): When point is above the window, allow searching
7824 as far as scroll_max, or one screenful, to compute vertical
7825 distance from PT to the scroll margin position. This prevents
7826 try_scrolling from unnecessarily failing when
7827 scroll-conservatively is set to a value slightly larger than the
7828 window height. Clean up the case of PT below the margin at bottom
7829 of window: scroll_max can no longer be INT_MAX. When aggressive
7830 scrolling is in use, don't let point enter the opposite scroll
7831 margin as result of the scroll.
7832 (syms_of_xdisp) <scroll-conservatively>: Document the
7833 threshold of 100 lines for never-recentering scrolling.
7835 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7837 * dispextern.h (move_it_by_lines):
7838 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7839 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7840 (message_log_check_duplicate): Remove parameters `prev_bol' and
7841 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7842 (redisplay_internal): Remove parameter `preserve_echo_area',
7843 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7845 * indent.c (Fvertical_motion):
7846 * window.c (window_scroll_pixel_based, Frecenter):
7847 Don't pass `need_y_p' to `move_it_by_lines'.
7849 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7851 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7852 steal a few bits to be more compact.
7853 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7854 Remove unneeded casts.
7856 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7858 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7860 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7861 binding" message (bug#7967).
7863 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7865 Fix more problems found by GCC 4.6.0's static checks.
7867 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7868 Remove unused local var.
7870 * editfns.c (Fmessage_box): Remove unused local var.
7872 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7873 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7874 Omit unused local vars.
7875 * window.c (shrink_windows): Omit unused local var.
7876 * menu.c (digest_single_submenu): Omit unused local var.
7877 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7878 Omit unused local var.
7880 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7881 Don't assume string length fits in int.
7882 (keyremap_step, read_key_sequence): Use size_t for sizes.
7883 (read_key_sequence): Don't check last_real_key_start redundantly.
7885 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7886 instead of alloca (Bug#8344).
7888 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7889 (Fbacktrace_frame): Don't assume nframes fits in int.
7891 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7893 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7896 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7898 * cm.c (calccost): Turn while-do into do-while, for clarity.
7900 * keyboard.c (syms_of_keyboard): Use the same style as later
7901 in this function when indexing through an array. This also
7902 works around GCC bug 48267.
7904 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7906 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7908 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7909 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7911 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7912 This avoids undefined behavior on integer overflow, and is a bit
7913 more convenient anyway since it is compared to a size_t variable.
7915 Variadic C functions now count arguments with size_t, not int.
7916 This avoids an unnecessary limitation on 64-bit machines, which
7917 caused (substring ...) to crash on large vectors (Bug#8344).
7918 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7919 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7920 All variadic functions and their callers changed accordingly.
7921 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7922 * data.c (arith_driver, float_arith_driver): Likewise.
7923 * editfns.c (general_insert_function): Likewise.
7924 * eval.c (struct backtrace.nargs, interactive_p)
7925 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7926 (funcall_lambda, mark_backtrace): Likewise.
7927 * fns.c (concat): Likewise.
7928 * frame.c (x_set_frame_parameters): Likewise.
7929 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7930 0 if not found, not -1. All callers changed.
7932 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7933 (stack_copy_size): Now size_t, not int.
7934 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7936 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7938 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7939 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7940 All callers changed.
7942 * lisp.h (multibyte_char_to_unibyte):
7943 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7944 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7945 * character.h (CHAR_TO_BYTE8):
7946 * cmds.c (internal_self_insert):
7947 * editfns.c (general_insert_function):
7948 * keymap.c (push_key_description):
7949 * search.c (Freplace_match):
7950 * xdisp.c (message_dolog, set_message_1): All callers changed.
7952 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7954 * keyboard.c (safe_run_hook_funcall): New function.
7955 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7956 don't set the hook to nil, but remove the offending function instead.
7957 (Qcommand_hook_internal): Remove, unused.
7958 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7959 Vcommand_hook_internal.
7961 * eval.c (enum run_hooks_condition): Remove.
7962 (funcall_nil, funcall_not): New functions.
7963 (run_hook_with_args): Call each function through a `funcall' argument.
7964 Remove `cond' argument, now redundant.
7965 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7966 (Frun_hook_with_args_until_failure): Adjust accordingly.
7967 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7969 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7971 * dispextern.h (string_buffer_position): Remove declaration.
7973 * print.c (strout): Remove parameter `multibyte', unused since
7974 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7976 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7977 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7978 All callers changed.
7980 * w32.c (_wsa_errlist): Use braces for struct initializers.
7982 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7983 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7984 All callers changed.
7985 (string_buffer_position): Likewise. Also, make static (it's never
7986 used outside xdisp.c).
7987 (cursor_row_p): Remove parameter `w', unused since
7988 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7989 (decode_mode_spec): Remove parameter `precision', introduced during
7990 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7991 All callers changed.
7993 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7995 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7997 2011-03-27 Anders Lindgren <andlind@gmail.com>
7999 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8000 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8001 (ns_update_auto_hide_menu_bar): New functions.
8002 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8003 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8004 ns_constrain_all_frames.
8005 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8006 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8008 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8010 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8012 2011-03-27 Glenn Morris <rgm@gnu.org>
8014 * syssignal.h: Replace RETSIGTYPE with void.
8015 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8016 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8017 Replace SIGTYPE with void everywhere.
8018 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8019 * s/template.h (SIGTYPE): Remove commented out definition.
8021 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8023 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8024 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8026 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8028 * w32.c (read_unc_volume): Use parameter `henum', instead of
8029 global variable `wget_enum_handle'.
8031 * keymap.c (describe_vector): Remove parameters `indices' and
8032 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8033 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8035 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8037 * keyboard.c (timer_check): Remove parameter `do_it_now',
8038 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8039 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8040 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8042 * keyboard.c (read_char):
8043 * w32menu.c (w32_menu_display_help):
8044 * xmenu.c (show_help_event, menu_help_callback):
8045 Adjust calls to `show_help_echo'.
8047 * gtkutil.c (xg_maybe_add_timer):
8048 * keyboard.c (readable_events):
8049 * process.c (wait_reading_process_output):
8050 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8052 * insdel.c (adjust_markers_gap_motion):
8053 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8054 (gap_left, gap_right): Don't call it.
8056 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8058 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8059 incurred during fontification.
8061 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8063 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8064 (DEFVAR_PER_BUFFER): Don't pass it.
8066 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8067 (scrolling_window): Don't pass it.
8069 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8071 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8073 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8075 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8076 of variables specific to SELinux and computation of `encoded_absname'.
8078 * image.c (XPutPixel): Remove unused variable `height'.
8080 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8082 * unexw32.c (get_section_info): Remove unused variable `section'.
8084 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8085 (system_process_attributes): Remove unused variable `sess'.
8086 (sys_read): Remove unused variable `err'.
8088 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8089 (w32_wnd_proc): Remove unused variable `isdead'.
8090 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8091 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8092 (x_create_tip_frame): Remove unused variable `tem'.
8094 * w32inevt.c (w32_console_read_socket):
8095 Remove unused variable `no_events'.
8097 * w32term.c (x_draw_composite_glyph_string_foreground):
8098 Remove unused variable `width'.
8100 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8102 * w32term.c (x_set_glyph_string_clipping):
8103 Don't pass uninitialized region to CombineRgn.
8105 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8107 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8108 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8109 (Fx_close_connection): Remove unused variable `i'.
8111 * w32font.c (w32font_draw): Return number of glyphs.
8112 (w32font_open_internal): Remove unused variable `i'.
8113 (w32font_driver): Add missing initializer.
8115 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8116 (fill_in_menu): Remove unused variable `items_added'.
8118 * w32term.c (last_mouse_press_frame): Remove static global variable.
8119 (w32_clip_to_row): Remove unused variable `f'.
8120 (x_delete_terminal): Remove unused variable `i'.
8122 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8123 (NOTHING): Remove unused static global variable.
8124 (uniscribe_check_otf): Remove unused variable `table'.
8125 (uniscribe_font_driver): Add missing initializers.
8127 2011-03-23 Julien Danjou <julien@danjou.info>
8129 * term.c (Fsuspend_tty, Fresume_tty):
8130 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8131 * window.c (temp_output_buffer_show):
8132 * insdel.c (signal_before_change):
8133 * frame.c (Fhandle_switch_frame):
8134 * fileio.c (Fdo_auto_save):
8135 * emacs.c (Fkill_emacs):
8136 * editfns.c (save_excursion_restore):
8137 * cmds.c (internal_self_insert):
8138 * callint.c (Fcall_interactively):
8139 * buffer.c (Fkill_all_local_variables):
8140 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8142 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8143 unconditionally since it does the check itself.
8145 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8147 Fix more problems found by GCC 4.5.2's static checks.
8149 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8150 the first time through the loop, since we know p0 < p1 then.
8151 This also avoids a gcc -Wstrict-overflow warning.
8153 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8154 leading to a memory leak, possible in functions like
8155 load_charset_map_from_file that can allocate an unbounded number
8156 of objects (Bug#8318).
8158 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8159 that could (at least in theory) be that large.
8161 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8162 This is less likely to overflow, and avoids undefined behavior if
8163 overflow does occur. All callers changed. Use strtoul to scan
8164 for the unsigned long integer.
8165 (pint2hrstr): Simplify and tune code slightly.
8166 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8168 * scroll.c (do_scrolling): Work around GCC bug 48228.
8169 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8171 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8172 This also avoids a warning with gcc -Wstrict-overflow.
8173 (validate_x_resource_name): Simplify count usage.
8174 This also avoids a warning with gcc -Wstrict-overflow.
8176 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8179 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8181 * process.c (Fmake_network_process): Use socklen_t, not int,
8182 where POSIX says socklen_t is required in portable programs.
8183 This fixes a porting bug on hosts like 64-bit HP-UX, where
8184 socklen_t is wider than int (Bug#8277).
8185 (Fmake_network_process, server_accept_connection):
8186 (wait_reading_process_output, read_process_output):
8189 * process.c: Rename or move locals to avoid shadowing.
8190 (list_processes_1, Fmake_network_process):
8191 (read_process_output_error_handler, exec_sentinel_error_handler):
8192 Rename or move locals.
8193 (Fmake_network_process): Define label "retry_connect" only if needed.
8194 (Fnetwork_interface_info): Fix pointer signedness.
8195 (process_send_signal): Add cast to avoid pointer signedness problem.
8196 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8197 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8199 Make tparam.h and terminfo.c consistent.
8200 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8201 Include tparam.h instead, since it declares them.
8202 * cm.h (PC): Remove extern decl; tparam.h now does this.
8203 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8204 * terminfo.c: Include tparam.h, to check interfaces.
8205 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8206 (tparam): Adjust signature to match interface in tparam.h;
8207 this removes some undefined behavior. Check that outstring and len
8208 are zero, which they always are with Emacs.
8209 * tparam.h (PC, BC, UP): New extern decls.
8211 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8212 (xftfont_open): Rename locals to avoid shadowing.
8214 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8215 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8216 (OTF_TAG_SYM): Omit macro if not needed.
8217 (ftfont_list): Remove unused local.
8218 (get_adstyle_property, ftfont_pattern_entity):
8219 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8220 Rename locals to avoid shadowing.
8222 * xfont.c (xfont_list_family): Mark var as initialized.
8224 * xml.c (make_dom): Now static.
8226 * composite.c (composition_compute_stop_pos): Rename local to
8228 (composition_reseat_it): Remove unused locals.
8229 (find_automatic_composition, composition_adjust_point): Likewise.
8230 (composition_update_it): Mark var as initialized.
8231 (find_automatic_composition): Mark vars as initialized,
8232 with a FIXME (Bug#8290).
8234 character.h: Rename locals to avoid shadowing.
8235 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8236 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8237 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8238 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8241 * textprop.c (property_change_between_p): Remove; unused.
8243 * intervals.c (interval_start_pos): Now static.
8245 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8247 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8248 Rename locals to avoid shadowing.
8250 * sound.c (wav_play, au_play, Fplay_sound_internal):
8251 Fix pointer signedness.
8252 (alsa_choose_format): Remove unused local var.
8253 (wav_play): Initialize a variable to 0, to prevent undefined
8254 behavior (Bug#8278).
8256 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8258 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8260 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8261 clobbering (Bug#8298).
8262 * sysdep.c (sys_subshell): Likewise.
8263 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8265 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8266 This should get cleaned up, so that child_setup has the
8267 same signature on all platforms.
8269 * callproc.c (call_process_cleanup): Now static.
8270 (relocate_fd): Rename locals to avoid shadowing.
8272 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8274 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8275 not to be necessary, and produces flickering.
8277 2011-03-20 Glenn Morris <rgm@gnu.org>
8279 * config.in: Remove file.
8281 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8283 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8284 are now in src/globals.h.
8285 (syms_of_minibuf): Remove spurious & from previous change.
8287 2011-03-20 Leo <sdl.web@gmail.com>
8289 * minibuf.c (completing-read-function): New variable.
8290 (completing-read-default): Rename from completing-read.
8291 (completing-read): Call completing-read-function.
8293 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8295 * xfaces.c (Fx_load_color_file):
8296 Read color file from absolute filename (bug#8250).
8298 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8300 * makefile.w32-in: Update dependencies.
8302 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8304 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8306 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8308 Fix more problems found by GCC 4.5.2's static checks.
8310 * process.c (make_serial_process_unwind, send_process_trap):
8311 (sigchld_handler): Now static.
8313 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8314 That way, the code declares only the vars that it needs.
8315 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8316 * s/cygwin.h (PTY_ITERATION): Likewise.
8317 * s/darwin.h (PTY_ITERATION): Likewise.
8318 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8320 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8321 * process.c (allocate_pty): Don't declare stb unless it's needed.
8323 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8324 (CONSTANTLIM): Remove; unused.
8325 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8326 Define only if needed.
8328 * unexelf.c (unexec): Name an expression,
8329 to avoid gcc -Wbad-function-cast warning.
8330 Use a different way to cause a compilation error if anyone uses
8331 n rather than nn, a way that does not involve shadowing.
8332 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8334 * deps.mk (unexalpha.o): Remove; unused.
8336 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8337 * unexec.h: New file.
8338 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8339 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8341 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8342 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8343 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8344 Change as necessary to match prototype in unexec.h.
8346 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8348 (back_comment, skip_chars): Mark vars as initialized.
8350 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8351 Rename locals to avoid shadowing.
8353 * lread.c (read1): Rewrite so as not to use empty "else".
8354 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8356 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8358 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8359 warning when compiling print.c.
8361 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8362 instead of using an uninitialized var.
8363 (font_sort_entities): Mark var as initialized.
8365 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8367 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8368 pointers to constants.
8369 (font_parse_fcname): Remove unused vars.
8370 (font_delete_unmatched): Now static.
8371 (font_get_spec): Remove; unused.
8372 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8373 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8374 Rename or move locals to avoid shadowing.
8376 * fns.c (require_nesting_list, require_unwind): Now static.
8377 (Ffillarray): Rename locals to avoid shadowing.
8379 * floatfns.c (domain_error2): Define only if needed.
8380 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8382 * alloc.c (mark_backtrace): Move decl from here ...
8383 * lisp.h: ... to here, so that it can be checked.
8385 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8386 (Fdefvar): Rewrite so as not to use empty "else".
8387 (lisp_indirect_variable): Name an expression,
8388 to avoid gcc -Wbad-function-cast warning.
8389 (Fdefvar): Rename locals to avoid shadowing.
8391 * callint.c (quotify_arg, quotify_args): Now static.
8392 (Fcall_interactively): Rename locals to avoid shadowing.
8393 Use const pointer when appropriate.
8395 * lisp.h (get_system_name, get_operating_system_release):
8396 Move decls here, to check interfaces.
8397 * process.c (get_operating_system_release): Move decl to lisp.h.
8398 * xrdb.c (get_system_name): Likewise.
8399 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8400 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8401 some of which prompt warnings from gcc -Wbad-function-cast.
8402 (Fformat_time_string, Fencode_time, Finsert_char):
8403 (Ftranslate_region_internal, Fformat):
8404 Rename or remove local vars to avoid shadowing.
8405 (Ftranslate_region_internal): Mark var as initialized.
8407 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8410 * lisp.h (eassert): Check that the argument compiles, even if
8411 ENABLE_CHECKING is not defined.
8413 * data.c (Findirect_variable): Name an expression, to avoid
8414 gcc -Wbad-function-cast warning.
8415 (default_value, arithcompare, arith_driver, arith_error): Now static.
8416 (store_symval_forwarding): Rename local to avoid shadowing.
8417 (Fmake_variable_buffer_local, Fmake_local_variable):
8418 Mark variables as initialized.
8419 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8421 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8422 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8423 Rename locals to avoid shadowing.
8424 (mark_stack): Move local variables into the #ifdef region where
8426 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8427 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8429 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8430 (GC_STRING_CHARS): Remove; not used.
8431 (Fmemory_limit): Cast sbrk's returned value to char *.
8433 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8434 avoids undefined behavior in theory.
8436 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8438 Use functions, not macros, for up- and down-casing (Bug#8254).
8439 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8440 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8441 to use the following functions instead of these macros.
8442 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8443 EMACS_INT, since callers assume the returned value fits in int.
8444 (upcase1): Likewise, for UPCASE_TABLE.
8445 (uppercasep, lowercasep, upcase): New static inline functions.
8446 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8447 the race-condition problem in the old DOWNCASE.
8449 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8450 Rename locals to avoid shadowing.
8451 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8452 (regex_compile, re_search_2, re_match_2_internal):
8453 Remove unused local vars.
8454 (FREE_VAR): Rewrite so as not to use empty "else",
8455 which gcc can warn about.
8456 (regex_compile, re_match_2_internal): Mark locals as initialized.
8457 (RETALLOC_IF): Define only if needed.
8458 (WORDCHAR_P): Likewise. This one is never needed, but is used
8459 only in a comment talking about a compiler bug, so put inside
8460 the #if 0 of that comment.
8461 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8462 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8465 * search.c (boyer_moore): Rename locals to avoid shadowing.
8466 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8467 (PREV_CHAR_BOUNDARY): Likewise.
8469 * search.c (simple_search): Remove unused var.
8471 * dired.c (compile_pattern): Move decl from here ...
8472 * lisp.h: ... to here, so that it can be checked.
8473 (struct re_registers): New forward decl.
8475 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8477 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8479 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8480 Rename locals to avoid shadowing.
8481 (Fvertical_motion): Mark locals as initialized.
8483 * casefiddle.c (casify_object, casify_region): Now static.
8484 (casify_region): Mark local as initialized.
8486 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8488 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8489 New macros, so that the caller can use some names other than
8490 gcpro1, gcpro2, etc.
8491 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8493 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8494 argument, for consistency with GCPRO2_VAR, etc: it is now the
8495 prefix of the variable, not the variable itself. All uses
8497 * dired.c (directory_files_internal, file_name_completion):
8498 Rename locals to avoid shadowing.
8500 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8501 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8502 dired.c's scmp function, had undefined behavior.
8503 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8504 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8505 * buffer.h: ... to here, because these macros use current_buffer,
8506 and the new implementation with inline functions needs to have
8507 current_buffer in scope now, rather than later when the macros
8509 (downcase, upcase1): New static inline functions.
8510 (DOWNCASE, UPCASE1): Reimplement using these functions.
8511 This avoids undefined behavior in expressions like
8512 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8513 from race conditions in accessing the global variables
8514 case_temp1 and case_temp2.
8515 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8516 * lisp.h (case_temp1, case_temp2): Remove their decls.
8517 * character.h (ASCII_CHAR_P): Move from here ...
8518 * lisp.h: ... to here, so that the inline functions mentioned
8521 * dired.c (directory_files_internal_unwind): Now static.
8523 * fileio.c (file_name_as_directory, directory_file_name):
8524 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8526 (file_name_as_directory): Use const pointers when appropriate.
8527 (Fexpand_file_name): Likewise. In particular, newdir might
8528 point at constant storage, so make it a const pointer.
8529 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8530 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8532 (Fset_file_times, Finsert_file_contents, auto_save_error):
8533 Rename locals to avoid shadowing.
8535 * minibuf.c (choose_minibuf_frame_1): Now static.
8536 (Ftry_completion, Fall_completions): Rename or remove locals
8539 * marker.c (bytepos_to_charpos): Remove; unused.
8541 * lisp.h (verify_bytepos, count_markers): New decls,
8542 so that gcc does not warn that these functions aren't declared.
8544 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8545 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8546 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8547 (copy_text): Remove unused local var.
8549 * filelock.c (within_one_second): Now static.
8550 (lock_file_1): Rename local to avoid shadowing.
8552 * buffer.c (fix_overlays_before): Mark locals as initialized.
8553 (fix_start_end_in_overlays): Likewise. This function should be
8554 simplified by using pointers-to-pointers, but that's a different
8556 (switch_to_buffer_1): Now static.
8557 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8558 (report_overlay_modification): Rename locals to avoid shadowing.
8560 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8561 Fix pointer signedness issue.
8562 (sys_subshell): Mark local as volatile if checking for lint,
8563 to suppress a gcc -Wclobbered warning that does not seem to be right.
8564 (MAXPATHLEN): Define only if needed.
8566 * process.c (serial_open, serial_configure): Move decls from here ...
8567 * systty.h: ... to here, so that they can be checked.
8569 * fns.c (get_random, seed_random): Move extern decls from here ...
8570 * lisp.h: ... to here, so that they can be checked.
8572 * sysdep.c (reset_io): Now static.
8573 (wait_for_termination_signal): Remove; unused.
8575 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8576 (copy_keymap_item, append_key, push_text_char_description):
8578 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8579 (DENSE_TABLE_SIZE): Remove; unused.
8580 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8581 (describe_map_tree):
8582 Rename locals to avoid shadowing.
8584 * keyboard.c: Declare functions static if they are not used elsewhere.
8585 (echo_char, echo_dash, cmd_error, top_level_2):
8586 (poll_for_input, handle_async_input): Now static.
8587 (read_char, kbd_buffer_get_event, make_lispy_position):
8588 (make_lispy_event, make_lispy_movement, apply_modifiers):
8589 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8590 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8591 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8592 (read_key_sequence, read_char): Mark locals as initialized.
8593 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8595 * keyboard.h (make_ctrl_char): New decl.
8596 (mark_kboards): Move decl here ...
8597 * alloc.c (mark_kboards): ... from here.
8599 * lisp.h (force_auto_save_soon): New decl.
8601 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8602 (DEFINE_DUMMY_FUNCTION): New macro.
8603 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8605 (main): Add casts to avoid warnings
8606 if GCC considers string literals to be constants.
8608 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8610 * dbusbind.c: Pointer signedness fixes.
8611 (xd_signature, xd_append_arg, xd_initialize):
8612 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8613 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8614 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8615 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8617 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8618 if GCC considers string literals to be constants.
8619 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8621 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8623 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8624 (print_preprocess, print_object): New macro to fix last change.
8626 * print.c (print_preprocess): Don't forget font objects.
8628 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8630 * emacs.c (USAGE3): Doc fixes.
8632 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8634 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8637 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8639 * lisp.h (VWindow_system, Qfile_name_history):
8640 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8641 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8642 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8644 * w32select.c: Don't #include "keyboard.h".
8645 (run_protected): Add extern declaration for waiting_for_input.
8647 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8648 * w32console.c (detect_input_pending, read_input_pending)
8649 (encode_terminal_code):
8650 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8651 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8652 (w32_system_caret_y, Qfile_name_history):
8653 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8654 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8655 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8656 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8657 * w32proc.c (Qlocal, report_file_error):
8658 * w32term.c (Vwindow_system, updating_frame):
8659 * w32uniscribe.c (initialized, uniscribe_font_driver):
8660 Remove unneeded extern declarations.
8662 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8664 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8666 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8668 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8669 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8670 These macros can no longer be used for assignment.
8672 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8673 Assign struct members directly, instead of using BUF_BEGV etc.
8674 (record_buffer_markers, fetch_buffer_markers): New functions for
8675 recording and fetching special buffer markers.
8676 (set_buffer_internal_1, set_buffer_temp): Use them.
8678 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8680 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8682 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8683 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8685 * xdisp.c (hscroll_window_tree):
8686 (reconsider_clip_changes): Use PT instead of BUF_PT.
8688 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8690 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8691 $(EMACS_ROOT)/lib/intprops.h.
8693 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8695 Fix more problems found by GCC 4.5.2's static checks.
8697 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8698 to unsigned char * to avoid compiler diagnostic.
8699 (xg_free_frame_widgets): Make it clear that a local variable is
8700 needed only if USE_GTK_TOOLTIP.
8701 (gdk_window_get_screen): Make it clear that this macro is needed
8702 only if USE_GTK_TOOLTIP.
8703 (int_gtk_range_get_value): New function, which avoids a diagnostic
8704 from gcc -Wbad-function-cast.
8705 (xg_set_toolkit_scroll_bar_thumb): Use it.
8706 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8707 diagnostic from gcc -Wbad-function-cast.
8708 (get_utf8_string, xg_get_file_with_chooser):
8709 Rename locals to avoid shadowing.
8710 (create_dialog): Move locals to avoid shadowing.
8712 * xgselect.c (xg_select): Remove unused var.
8714 * image.c (four_corners_best): Mark locals as initialized.
8715 (gif_load): Initialize transparent_p to zero (Bug#8238).
8716 Mark another local as initialized.
8717 (my_png_error, my_error_exit): Mark with NO_RETURN.
8719 * image.c (clear_image_cache): Now static.
8720 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8721 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8722 (x_edge_detection): Remove unnecessary cast that
8723 gcc -Wbad-function-cast diagnoses.
8724 (gif_load): Fix pointer signedness.
8725 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8726 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8728 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8730 Improve quality of tests for time stamp overflow.
8731 For example, without this patch (encode-time 0 0 0 1 1
8732 1152921504606846976) returns the obviously-bogus value (-948597
8733 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8734 reports time overflow. See
8735 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8736 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8737 * editfns.c: Include limits.h and intprops.h.
8738 (TIME_T_MIN, TIME_T_MAX): New macros.
8739 (time_overflow): Move earlier, to before first use.
8740 (hi_time, lo_time): New functions, for an accurate test for
8742 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8743 (Fget_internal_run_time): Don't assume time_t fits in int.
8744 (make_time): Use list2 instead of Fcons twice.
8745 (Fdecode_time): More accurate test for out-of-range times.
8746 (check_tm_member): New function.
8747 (Fencode_time): Use it, to test for out-of-range times.
8748 (lisp_time_argument): Don't rely on undefined left-shift and
8749 right-shift behavior when checking for time stamp overflow.
8751 * editfns.c (time_overflow): New function, refactoring common code.
8752 (Fformat_time_string, Fdecode_time, Fencode_time):
8753 (Fcurrent_time_string): Use it.
8755 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8756 * dired.c (make_time): Move to ...
8757 * editfns.c (make_time): ... here.
8758 * systime.h: Note the move.
8760 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8762 * fringe.c (update_window_fringes): Remove unused variables.
8764 * unexmacosx.c (copy_data_segment): Also copy __got section.
8767 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8769 * termcap.c [MSDOS]: Include "msdos.h".
8770 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8771 Constify `char *' arguments and their references according to
8772 prototypes in tparam.h.
8774 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8776 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8777 Adapt all references accordingly.
8779 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8781 2011-03-11 Tom Tromey <tromey@redhat.com>
8783 * buffer.c (syms_of_buffer): Remove obsolete comment.
8785 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8787 * termhooks.h (encode_terminal_code): Declare prototype.
8789 * msdos.c (encode_terminal_code): Don't declare prototype.
8791 * term.c (encode_terminal_code): Now external again, used by
8792 w32console.c and msdos.c.
8794 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8795 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8797 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8799 Fix some minor problems found by GCC 4.5.2's static checks.
8801 * fringe.c (update_window_fringes): Mark locals as initialized
8803 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8805 * alloc.c (mark_fringe_data): Move decl from here ...
8806 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8807 to check its interface.
8808 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8810 * fontset.c (free_realized_fontset): Now static.
8811 (Fset_fontset_font): Rename local to avoid shadowing.
8812 (fontset_font): Mark local as initialized.
8813 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8815 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8817 * xselect.c (x_disown_buffer_selections): Remove; not used.
8818 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8819 (x_own_selection, Fx_disown_selection_internal): Rename locals
8821 (x_handle_dnd_message): Remove local to avoid shadowing.
8823 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8824 so that the caller can use some name other than gcpro1.
8825 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8826 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8827 (Fx_backspace_delete_keys_p):
8828 Use them to avoid shadowing, and rename vars to avoid shadowing.
8829 (x_decode_color, x_set_name, x_window): Now static.
8830 (Fx_create_frame): Add braces to silence GCC warning.
8831 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8832 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8833 Remove unused locals.
8834 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8835 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8836 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8839 * xterm.h (x_mouse_leave): New decl.
8841 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8842 Remove unused functions.
8843 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8844 (x_calc_absolute_position): Now static.
8845 (XTread_socket): Don't define label "out" unless it's used.
8846 Don't declare local "event" unless it's used.
8847 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8848 unless they are used.
8849 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8850 (x_fatal_error_signal): Remove; not used.
8851 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8852 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8853 (x_error_catcher, x_connection_closed, x_error_handler):
8854 (x_error_quitter, xembed_send_message, x_iconify_frame):
8855 (my_log_handler): Rename locals to avoid shadowing.
8856 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8857 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8859 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8860 Rename or move locals to avoid shadowing.
8861 (tty_defined_color, merge_face_heights): Now static.
8862 (free_realized_faces_for_fontset): Remove; not used.
8863 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8864 does not deduce is never used uninitialized.
8865 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8866 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8868 * terminal.c (store_terminal_param): Now static.
8870 * xmenu.c (menu_highlight_callback): Now static.
8871 (set_frame_menubar): Remove unused local.
8872 (xmenu_show): Rename parameter to avoid shadowing.
8873 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8874 since they might point to immutable storage.
8875 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8876 since it's unused otherwise.
8878 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8879 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8880 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8881 avoids a gcc -Wuninitialized diagnostic.
8882 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8883 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8884 does not deduce are never used uninitialized.
8886 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8888 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8889 * window.c (window_loop, size_window):
8890 (run_window_configuration_change_hook, enlarge_window): Likewise.
8892 * window.c (display_buffer): Now static.
8893 (size_window): Mark variables that gcc -Wuninitialized
8894 does not deduce are never used uninitialized.
8895 * window.h (check_all_windows): New decl, to forestall
8896 gcc -Wmissing-prototypes diagnostic.
8897 * dispextern.h (bidi_dump_cached_states): Likewise.
8899 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8901 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8903 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8904 and to avoid gcc -Wuninitialized warning.
8905 (load_charset_map): Mark variables that gcc -Wuninitialized
8906 does not deduce are never used uninitialized.
8907 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8909 * coding.c (coding_set_source, coding_set_destination):
8910 Use "else { /* comment */ }" rather than "else /* comment */;"
8911 for clarity, and to avoid gcc -Wempty-body warning.
8912 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8913 a block, when the outer 'i' will do.
8914 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8915 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8916 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8917 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8918 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8919 Rename locals to avoid shadowing.
8920 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8921 * coding.c (emacs_mule_char, encode_invocation_designation):
8922 Now static, since they're not used elsewhere.
8923 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8924 (decode_coding_object, encode_coding_object, detect_coding_system):
8925 (decode_coding_emacs_mule): Mark variables that gcc
8926 -Wuninitialized does not deduce are never used uninitialized.
8927 (detect_coding_iso_2022): Initialize a local variable that might
8928 be used uninitialized. Leave a FIXME because it's not clear that
8929 this initialization is needed. (Bug#8211)
8930 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8931 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8932 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8933 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8934 Remove unused macros.
8936 * category.c (hash_get_category_set): Remove unused local var.
8937 (copy_category_table): Now static, since it's not used elsewhere.
8938 * character.c (string_count_byte8): Likewise.
8940 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8941 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8943 * chartab.c (copy_sub_char_table): Now static, since it's not used
8945 (sub_char_table_ref_and_range, char_table_ref_and_range):
8946 Rename locals to avoid shadowing.
8947 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8949 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8950 (BIDI_BOB): Remove unused macro.
8952 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8953 deduce are never used uninitialized.
8954 * term.c (encode_terminal_code): Likewise.
8956 * term.c (encode_terminal_code): Now static. Remove unused local.
8958 * tparam.h: New file.
8959 * term.c, tparam.h: Include it.
8960 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8961 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8962 Move these decls to tparam.h, and make them agree with what
8963 is actually in tparam.c. The previous trick of using incompatible
8964 decls in different modules does not conform to the C standard.
8965 All callers of tparam changed to use tparam's actual API.
8966 * tparam.c (tparam1, tparam, tgoto):
8967 Use const pointers where appropriate.
8969 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8970 * cm.h (struct cm): Likewise.
8971 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8972 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8973 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8974 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8975 (turn_on_face, init_tty): Likewise.
8976 * termchar.h (struct tty_display_info): Likewise.
8978 * term.c (term_mouse_position): Rename local to avoid shadowing.
8980 * alloc.c (mark_ttys): Move decl from here ...
8981 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8983 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8985 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8987 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8989 * search.c (compile_pattern_1): Remove argument regp, unused since
8990 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8991 (compile_pattern): Don't pass it.
8993 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8995 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8996 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8998 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9000 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9002 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9003 gdk_window_get_screen, gdk_window_get_geometry,
9004 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9005 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9006 (xg_get_pixbuf_from_pixmap): New function.
9007 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9008 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9009 Call xg_get_pixbuf_from_pixmap instead of
9010 gdk_pixbuf_get_from_drawable.
9011 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9012 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9013 (xg_check_special_colors): Use GtkStyleContext and its functions
9015 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9016 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9017 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9018 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9019 Call gtk_widget_get_preferred_size.
9020 (xg_frame_resized): gdk_window_get_geometry only takes 5
9022 (xg_win_to_widget, xg_event_is_for_menubar):
9023 Call gdk_x11_window_lookup_for_display.
9024 (xg_set_widget_bg): New function.
9025 (delete_cb): New function.
9026 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9027 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9028 (xg_set_background_color): Call xg_set_widget_bg.
9029 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9030 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9031 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9032 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9034 (update_frame_tool_bar): Call gtk_widget_hide.
9035 (xg_initialize): Use GDK_KEY_g.
9037 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9039 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9041 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9042 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9043 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9045 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9047 * w32xfns.c (select_palette): Check success of RealizePalette against
9048 GDI_ERROR, not zero.
9050 See ChangeLog.11 for earlier changes.
9056 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9058 This file is part of GNU Emacs.
9060 GNU Emacs is free software: you can redistribute it and/or modify
9061 it under the terms of the GNU General Public License as published by
9062 the Free Software Foundation, either version 3 of the License, or
9063 (at your option) any later version.
9065 GNU Emacs is distributed in the hope that it will be useful,
9066 but WITHOUT ANY WARRANTY; without even the implied warranty of
9067 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9068 GNU General Public License for more details.
9070 You should have received a copy of the GNU General Public License
9071 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.