1 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3 * lisp.h (Qdebug): List symbol.
4 * eval.c (Qdebug): restore global linkage.
5 * keyboard.c (debug-on-event): New variable.
6 (handle_user_signal): Break into debugger when debug-on-event
7 matches the current signal symbol.
9 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11 * alloc.c (check_sblock, check_string_bytes)
12 (check_string_free_list): Convert to standard C.
14 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
16 * w32.c (emacs_gnutls_push): Fix typo.
18 2011-04-25 Eli Zaretskii <eliz@gnu.org>
20 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
21 "cast to pointer from integer of different size".
23 Improve doprnt and its use in verror. (Bug#8545)
24 * doprnt.c (doprnt): Document the set of format control sequences
25 supported by the function. Use SAFE_ALLOCA instead of always
28 * eval.c (verror): Don't limit the buffer size at size_max-1, that
29 is one byte too soon. Don't use xrealloc; instead xfree and
32 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
34 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
37 * gnutls.c: Renamed global_initialized to
38 gnutls_global_initialized. Added internals for the
39 :verify-hostname-error, :verify-error, and :verify-flags
40 parameters of `gnutls-boot' and documented those parameters in the
41 docstring. Start callback support.
42 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
43 unless a fatal error occured. Call gnutls_alert_send_appropriate
44 on error. Return error code.
45 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
46 (emacs_gnutls_read): Likewise.
47 (Fgnutls_boot): Return handshake error code.
48 (emacs_gnutls_handle_error): New function.
49 (wsaerror_to_errno): Likewise.
51 * w32.h (emacs_gnutls_pull): Add prototype.
52 (emacs_gnutls_push): Likewise.
54 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
55 (emacs_gnutls_push): Likewise.
57 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
59 * process.c (wait_reading_process_output): Check if GnuTLS
60 buffered some data internally if no FDs are set for TLS
63 * makefile.w32-in (OBJ2): Add gnutls.$(O).
64 (LIBS): Link to USER_LIBS.
65 ($(BLD)/gnutls.$(0)): New target.
67 2011-04-24 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (handle_single_display_spec): Rename the
70 display_replaced_before_p argument into display_replaced_p, to
71 make it consistent with the commentary. Fix typos in the
74 * textprop.c (syms_of_textprop): Remove dead code.
75 (copy_text_properties): Delete obsolete commentary about an
76 interface that was deleted long ago. Fix typos in the description
79 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
80 to changes in oldXMenu/XMenu.h from 2011-04-16.
81 <menu_help_message, prev_menu_help_message>: Constify.
82 (IT_menu_make_room): menu->help_text is now `const char **';
85 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
86 to changes in oldXMenu/XMenu.h from 2011-04-16.
87 (struct XMenu): Declare `help_text' `const char **'.
89 * xfaces.c <Qunspecified>: Make extern again.
91 * syntax.c: Include sys/types.h before including regex.h, as
94 * doc.c (get_doc_string): Improve the format passed to `error'.
96 * doprnt.c (doprnt): Improve commentary.
98 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
100 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
103 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
104 changes in globals.h immediately force recompilation.
105 (TAGS): Depend on $(CURDIR)/m/intel386.h and
106 $(CURDIR)/s/ms-w32.h.
107 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
109 * character.c (Fchar_direction): Function deleted.
110 (syms_of_character): Don't defsubr it.
111 <char-direction-table>: Deleted.
113 2011-04-23 Eli Zaretskii <eliz@gnu.org>
115 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
116 * doprnt.c: Include limits.h.
117 (SIZE_MAX): New macro.
118 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
119 local variables are now size_t instead of int or unsigned.
120 Improve overflow protection. Support `l' modifier for integer
121 conversions. Support %l conversion. Don't assume an EMACS_INT
122 argument for integer conversions and for %c.
124 * lisp.h (doprnt): Restore prototype.
126 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
129 * Makefile.in (base_obj): Add back doprnt.o.
131 * deps.mk (doprnt.o): Add back prerequisites.
132 (callint.o): Depend on character.h.
134 * eval.c (internal_lisp_condition_case): Include the handler
135 representation in the error message.
136 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
137 when breaking from the loop.
139 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
141 * callint.c (Fcall_interactively): When displaying error message
142 about invalid control letter, pass the character's codepoint, not
143 a pointer to its multibyte form. Improve display of the character
144 in octal and display also its hex code.
146 * character.c (char_string): Use %x to display the (unsigned)
147 codepoint of an invalid character, to avoid displaying a bogus
150 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
151 `error', not SYMBOL_NAME itself.
153 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
154 character arguments to `error'.
156 * charset.c (check_iso_charset_parameter): Fix incorrect argument
157 to `error' in error message about FINAL_CHAR argument. Make sure
158 FINAL_CHAR is a character, and use %c when it is passed as
161 2011-04-23 Eli Zaretskii <eliz@gnu.org>
163 * s/ms-w32.h (localtime): Redirect to sys_localtime.
165 * w32.c: Include <time.h>.
166 (sys_localtime): New function.
168 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
170 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
172 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
174 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
176 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
179 2011-04-19 Eli Zaretskii <eliz@gnu.org>
181 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
182 gl_state.e_property when gl_state.object is Qt.
184 * insdel.c (make_gap_larger): Remove limitation of buffer size
187 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
189 * xdisp.c (lookup_glyphless_char_display)
190 (produce_glyphless_glyph): Handle cons cell entry in
191 glyphless-char-display.
192 (Vglyphless_char_display): Document it.
194 * term.c (produce_glyphless_glyph): Handle cons cell entry in
195 glyphless-char-display.
197 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
199 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
201 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
203 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
204 definition for no-X builds.
206 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
208 Static checks with GCC 4.6.0 and non-default toolkits.
210 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
212 * process.c (keyboard_bit_set): Define only if SIGIO.
213 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
214 (send_process): Repair possible setjmp clobbering.
216 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
218 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
220 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
222 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
223 Define only if needed.
225 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
226 by pacifying GCC about it. Maybe it's time to retire it?
227 * xfaces.c (USG, __TIMEVAL__): Likewise.
229 * dispextern.h (struct redisplay_interface): Rename param
231 * termhooks.h (struct terminal): Likewise.
232 * xterm.c (xembed_send_message): Likewise.
234 * insdel.c (make_gap_smaller): Define only if
235 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
237 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
240 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
241 so that we aren't warned about unused symbols.
243 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
245 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
247 * xfns.c (x_real_positions): Mark locals as initialized.
249 * xmenu.c (xmenu_show): Don't use uninitialized vars.
251 * xterm.c: Fix problems found by static analysis with other toolkits.
252 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
253 (x_dispatch_event): Declare static if USE_GTK, and
254 define if USE_GTK || USE_X_TOOLKIT.
255 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
256 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
257 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
258 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
260 * xmenu.c (menu_help_callback): Pointer type fixes.
261 Use const pointers when pointing at readonly data. Avoid pointer
263 (FALSE): Remove unused macro.
264 (update_frame_menubar): Remove unused decl.
266 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
268 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
269 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
270 (single_menu_item): Rename local to avoid shadowing.
272 * keyboard.c (make_lispy_event): Remove unused local var.
274 * frame.c, frame.h (x_get_resource_string): Bring this back, but
275 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
277 * bitmaps: Change bitmaps from unsigned char back to the X11
278 compatible char. Avoid the old compiler warnings about
279 out-of-range initializers by using, for example, '\xab' rather
282 * xgselect.c (xgselect_initialize): Check vs interface
283 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
285 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
287 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
290 * fns.c (vector): Remove; this old hack is no longer needed.
292 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
294 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
296 * xrdb.c (x_load_resources): Omit unused local.
298 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
299 (x_window): Rename locals to avoid shadowing.
300 (USG): Use the kludged USG macro, to pacify gcc.
302 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
303 (x_term_init): Remove local to avoid shadowing.
305 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
307 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
308 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
310 2011-04-16 Eli Zaretskii <eliz@gnu.org>
312 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
314 Fix regex.c, syntax.c and friends for buffers > 2GB.
315 * syntax.h (struct gl_state_s): Declare character position members
318 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
320 * textprop.c (verify_interval_modification, interval_of): Declare
323 * intervals.c (adjust_intervals_for_insertion): Declare arguments
326 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
328 * indent.c (Fvertical_motion): Local variable it_start is now
331 * regex.c (re_match, re_match_2, re_match_2_internal)
332 (bcmp_translate, regcomp, regexec, print_double_string)
333 (group_in_compile_stack, re_search, re_search_2, regex_compile)
334 (re_compile_pattern, re_exec): Declare arguments and local
335 variables `size_t' and `ssize_t' and return values `regoff_t', as
337 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
338 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
339 <compile_stack_type>: `size' and `avail' are now `size_t'.
341 * regex.h <regoff_t>: Use ssize_t, not int.
342 (re_search, re_search_2, re_match, re_match_2): Arguments that
343 specify buffer/string position and length are now ssize_t and
344 size_t. Return type is regoff_t.
346 2011-04-16 Ben Key <bkey76@gmail.com>
348 * nsfont.m: Fixed bugs in ns_get_family and
349 ns_descriptor_to_entity that were caused by using free to
350 deallocate memory blocks that were allocated by xmalloc (via
351 xstrdup). This caused Emacs to crash when compiled with
352 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
353 --enable-checking=xmallocoverrun). xfree is now used to
354 deallocate these memory blocks.
356 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
358 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
360 emacs_write: Accept and return EMACS_INT for sizes.
361 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
363 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
364 Accept and return EMACS_INT.
365 (emacs_gnutls_write): Return the number of bytes written on
367 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
368 (emacs_read, emacs_write): Remove check for negative size, as the
369 Emacs source code has been audited now.
370 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
371 (emacs_read, emacs_write): Use it.
372 * process.c (send_process): Adjust to the new signatures of
373 emacs_write and emacs_gnutls_write. Do not attempt to store
374 a byte offset into an 'int'; it might overflow.
375 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
377 * sound.c: Don't assume sizes fit in 'int'.
378 (struct sound_device.period_size, alsa_period_size):
379 Return EMACS_INT, not int.
380 (struct sound_device.write, vox_write, alsa_write):
381 Accept EMACS_INT, not int.
382 (wav_play, au_play): Use EMACS_INT to store sizes and to
383 record read return values.
385 2011-04-15 Ben Key <bkey76@gmail.com>
387 * keyboard.c (Qundefined): Don't declare static since it is used
389 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
390 static since they are used in nsfont.m.
392 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
394 * process.c (Qprocessp): Don't declare static.
395 * lisp.h (Qprocessp): Declare again.
397 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
399 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
401 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
403 Improve C-level modularity by making more things 'static'.
405 Don't publish debugger-only interfaces to other modules.
406 * lisp.h (safe_debug_print, debug_output_compilation_hack):
407 (verify_bytepos, count_markers): Move decls to the only modules
409 * region-cache.h (pp_cache): Likewise.
410 * window.h (check_all_windows): Likewise.
411 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
413 * sysdep.c (croak): Now static, if
414 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
415 * syssignal.h (croak): Declare only if not static.
417 * alloc.c (refill_memory_reserve): Now static if
418 !defined REL_ALLOC || defined SYSTEM_MALLOC.
419 * lisp.h (refill_memory_reserve): Declare only if not static.
421 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
422 Define only if USE_LUCID.
424 * xrdb.c (x_customization_string, x_rm_string): Now static.
426 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
427 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
429 * xdisp.c (draw_row_with_mouse_face): Now static.
430 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
432 * window.h (check_all_windows): Mark externally visible.
434 * window.c (window_deletion_count): Now static.
436 * undo.c: Make symbols static if they're not exported.
437 (last_undo_buffer, last_boundary_position, pending_boundary):
440 * textprop.c (interval_insert_behind_hooks): Now static.
441 (interval_insert_in_front_hooks): Likewise.
443 * term.c: Make symbols static if they're not exported.
444 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
445 (max_frame_lines, tty_set_terminal_modes):
446 (tty_reset_terminal_modes, tty_turn_off_highlight):
447 (get_tty_terminal): Now static.
448 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
449 * termhooks.h (term_mouse_moveto): Do not declare if
451 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
452 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
454 * sysdep.c: Make symbols static if they're not exported.
455 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
457 (sigprocmask_set, full_mask): Remove; unused.
458 (wait_debugging): Mark as visible.
459 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
460 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
462 * syntax.c (syntax_temp): Define only if !__GNUC__.
464 * sound.c (current_sound_device, current_sound): Now static.
466 * search.c (searchbufs, searchbuf_head): Now static.
468 * scroll.c (scroll_cost): Remove; unused.
469 * dispextern.h (scroll_cost): Remove decl.
471 * region-cache.h (pp_cache): Mark as externally visible.
473 * process.c: Make symbols static if they're not exported.
474 (process_tick, update_tick, create_process, chan_process):
475 (Vprocess_alist, proc_buffered_char, datagram_access):
476 (fd_callback_data, send_process_frame, process_sent_to): Now static.
477 (deactivate_process): Mark defn as static, as well as decl.
478 * lisp.h (create_process): Remove decl.
479 * process.h (chan_process, Vprocess_alist): Remove decls.
481 * print.c: Make symbols static if they're not exported.
482 (print_depth, new_backquote_output, being_printed, print_buffer):
483 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
484 (print_interval, print_number_index, initial_stderr_stream):
486 * lisp.h (Fprinc): Remove decl.
487 (debug_output_compilation_hack): Mark as externally visible.
489 * sysdep.c (croak): Move decl from here to syssignal.h.
490 * syssignal.h (croak): Put it here, so the API can be checked when
491 'croak' is called from dissociate_if_controlling_tty.
493 * minibuf.c: Make symbols static if they're not exported.
494 (minibuf_save_list, choose_minibuf_frame): Now static.
495 * lisp.h (choose_minibuf_frame): Remove decl.
497 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
499 * lread.c: Make symbols static if they're not exported.
500 (read_objects, initial_obarray, oblookup_last_bucket_number):
502 (make_symbol): Remove; unused.
503 * lisp.h (initial_obarray, make_symbol): Remove decls.
505 * keyboard.c: Make symbols static if they're not exported.
506 (single_kboard, recent_keys_index, total_keys, recent_keys):
507 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
508 (this_single_command_key_start, echoing, last_auto_save):
509 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
510 (command_loop, echo_now, keyboard_init_hook, help_char_p):
511 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
512 (Vlispy_mouse_stem, double_click_count):
514 (force_auto_save_soon): Define only if SIGDANGER.
515 (ignore_mouse_drag_p): Now static if
516 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
517 (print_help): Remove; unused.
518 (stop_character, last_timer_event): Mark as externally visible.
519 * keyboard.h (ignore_mouse_drag_p): Declare only if
520 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
521 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
522 * lisp.h (echoing): Remove decl.
523 (force_auto_save_soon): Declare only if SIGDANGER.
524 * xdisp.c (redisplay_window): Simplify code, to make it more
525 obvious that ignore_mouse_drag_p is not accessed if !defined
526 USE_GTK && !defined HAVE_NS.
528 * intervals.c: Make symbols static if they're not exported.
529 (merge_properties_sticky, merge_interval_right, delete_interval):
531 * intervals.h (merge_interval_right, delete_interval): Remove decls.
533 * insdel.c: Make symbols static if they're not exported.
534 However, leave prepare_to_modify_buffer alone. It's never
535 called from outside this function, but that appears to be a bug.
536 (combine_after_change_list, combine_after_change_buffer):
537 (adjust_after_replace, signal_before_change): Now static.
538 (adjust_after_replace_noundo): Remove; unused.
539 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
540 (signal_before_change): Remove decls.
542 * indent.c (val_compute_motion, val_vmotion): Now static.
544 * image.c: Make symbols static if they're not exported.
545 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
547 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
548 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
550 * fringe.c (standard_bitmaps): Now static.
551 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
553 * frame.c: Make symbols static if they're not exported.
554 (x_report_frame_params, make_terminal_frame): Now static.
555 (get_frame_param): Now static, unless HAVE_NS.
556 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
557 (x_get_resource_string): Remove; not used.
558 * frame.h (make_terminal_frame, x_report_frame_params):
559 (x_get_resource_string); Remove decls.
560 (x_fullscreen_adjust): Declare only if WINDOWSNT.
561 * lisp.h (get_frame_param): Declare only if HAVE_NS.
563 * font.c, fontset.c: Make symbols static if they're not exported.
564 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
565 (FACE_SUITABLE_FOR_CHAR_P): Use it.
566 * font.c (font_close_object): Now static.
567 * font.h (font_close_object): Remove.
568 * fontset.c (FONTSET_OBJLIST): Remove.
569 (free_realized_fontset) #if-0 the body, which does nothing.
570 (face_suitable_for_char_p): #if-0, as it's never called.
571 * fontset.h (face_suitable_for_char_p): Remove decl.
572 * xfaces.c (face_at_string_position): Use
573 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
574 since 0 is always ASCII.
576 * fns.c (weak_hash_tables): Now static.
578 * fileio.c: Make symbols static if they're not exported.
579 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
580 (Vwrite_region_annotation_buffers): Now static.
582 * eval.c: Make symbols static if they're not exported.
583 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
584 * lisp.h (backtrace_list): Remove decl.
586 * emacs.c: Make symbols static if they're not exported.
587 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
588 (fatal_error_code, fatal_error_signal_hook, standard_args):
590 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
591 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
592 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
593 * lisp.h (fatal_error_signal_hook): Remove decl.
594 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
596 * editfns.c: Move a (normally-unused) function to its only use.
597 * editfns.c, lisp.h (get_operating_system_release): Remove.
598 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
599 worth the hassle of breaking this out.
601 * xterm.c: Make symbols static if they're not exported.
602 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
603 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
604 (x_destroy_window, x_delete_display):
606 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
607 (x_mouse_leave): Remove; unused.
608 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
609 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
610 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
612 (x_mouse_leave): Declare only if WINDOWSNT.
613 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
614 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
617 * ftxfont.c: Make symbols static if they're not exported.
618 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
620 * font.h (ftxfont_driver): Likewise.
622 * xfns.c: Make symbols static if they're not exported.
623 (x_last_font_name, x_display_info_for_name):
624 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
625 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
626 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
627 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
628 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
629 (last_show_tip_args): Now static.
630 (xic_defaut_fontset, xic_create_fontsetname): Define only if
631 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
632 (x_screen_planes): Remove; unused.
633 * dispextern.h (x_screen_planes): Remove decl.
635 * dispnew.c: Make symbols static if they're not exported.
636 * dispextern.h (redraw_garbaged_frames, scrolling):
637 (increment_row_positions): Remove.
638 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
639 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
641 (redraw_garbaged_frames): Remove; unused.
643 * xfaces.c: Make symbols static if they're not exported.
644 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
646 * xterm.h (defined_color): Remove decls.
647 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
648 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
649 (menu_face_changed_default, defined_color, free_realized_face):
650 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
651 (ascii_face_of_lisp_face): Remove; unused.
653 * xdisp.c: Make symbols static if they're not exported.
654 * dispextern.h (scratch_glyph_row, window_box_edges):
655 (glyph_to_pixel_coords, set_cursor_from_row):
656 (get_next_display_element, set_iterator_to_next):
657 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
658 (show_mouse_face): Remove decls
659 * frame.h (message_buf_print): Likewise.
660 * lisp.h (pop_message, set_message, check_point_in_composition):
662 * xterm.h (set_vertical_scroll_bar): Likewise.
663 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
664 (message_buf_print, scratch_glyph_row, displayed_buffer):
665 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
666 (get_next_display_element, show_mouse_face, window_box_edges):
667 (frame_to_window_pixel_xy, check_point_in_composition):
668 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
669 (glyph_to_pixel_coords): Remove; unused.
671 * dired.c (file_name_completion): Now static.
673 * dbusbind.c (xd_in_read_queued_messages): Now static.
675 * lisp.h (circular_list_error, FOREACH): Remove; unused.
676 * data.c (circular_list_error): Remove.
678 * commands.h (last_point_position, last_point_position_buffer):
679 (last_point_position_window): Remove decls.
680 * keyboard.c: Make these variables static.
682 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
684 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
685 (iso_code_class, detect_coding, code_convert_region): Now static.
686 (encode_coding_gap): Remove; unused.
688 * chartab.c (chartab_chars, chartab_bits): Now static.
690 * charset.h (charset_iso_8859_1): Remove decl.
691 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
694 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
695 * ccl.c (Vccl_program_table): Now static.
696 (check_ccl_update): Remove; unused.
698 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
699 * category.h: ... from here.
700 * category.c (check_category_table, set_category_set): Now static.
702 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
703 * lisp.h: Remove these decls.
705 * buffer.c (buffer_count): Remove unused var.
707 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
708 so that it's not optimized away.
709 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
710 * dispextern.h (bidi_dump_cached_states): Remove, since it's
711 exported only to the debugger.
713 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
714 * atimer.h (run_all_atimers): Removed; not exported.
716 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
717 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
718 was inaccessible from Lisp.
719 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
720 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
722 alloc.c: Import and export fewer symbols, and remove unused items.
723 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
725 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
726 it's not optimized away by whole-program optimization.
727 (message_enable_multibyte, free_misc): Remove.
728 (catchlist, handlerlist, mark_backtrace):
729 Declare only if BYTE_MARK_STACK.
730 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
731 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
732 (message_enable_multibyte): Remove decl.
733 (free_misc, interval_free_list, float_block, float_block_index):
734 (n_float_blocks, float_free_list, cons_block, cons_block_index):
735 (cons_free_list, last_marked_index):
737 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
738 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
739 (mark_backtrace): Define only if BYTE_MARK_STACK.
740 * xdisp.c (message_enable_multibyte): Now static.
742 Declare Lisp_Object Q* variables to be 'static' if not exported.
743 This makes it easier for human readers (and static analyzers)
744 to see whether these variables are used from other modules.
745 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
746 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
747 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
748 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
749 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
750 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
751 * xmenu.c, xselect.c:
752 Declare Q* vars static if they are not used in other modules.
753 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
754 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
755 Remove decls of unexported vars.
756 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
758 * lisp.h (DEFINE_FUNC): Make sname 'static'.
760 Make Emacs functions such as Fatom 'static' by default.
761 This makes it easier for human readers (and static analyzers)
762 to see whether these functions can be called from other modules.
763 DEFUN now defines a static function. To make the function external
764 so that it can be used in other C modules, use the new macro DEFUE.
765 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
766 (Finit_image_library):
767 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
768 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
769 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
770 Remove decls, since these functions are now static.
771 (Funintern, Fget_internal_run_time): New decls, since these functions
772 were already external.
774 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
775 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
776 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
777 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
778 * keyboard.c, keymap.c, lread.c:
779 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
780 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
781 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
782 Mark functions with DEFUE instead of DEFUN,
783 if they are used in other modules.
784 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
785 decls for now-static functions.
786 * buffer.h (Fdelete_overlay): Remove decl.
787 * callproc.c (Fgetenv_internal): Mark as internal.
788 * composite.c (Fremove_list_of_text_properties): Remove decl.
789 (Fcomposition_get_gstring): New forward static decl.
790 * composite.h (Fcomposite_get_gstring): Remove decl.
791 * dired.c (Ffile_attributes): New forward static decl.
792 * doc.c (Fdocumntation_property): New forward static decl.
793 * eval.c (Ffetch_bytecode): New forward static decl.
794 (Funintern): Remove extern decl; now in .h file where it belongs.
795 * fileio.c (Fmake_symbolic_link): New forward static decl.
796 * image.c (Finit_image_library): New forward static decl.
797 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
798 * intervals.h (Fprevious_property_change):
799 (Fremove_list_of_text_properties): Remove decls.
800 * keyboard.c (Fthis_command_keys): Remove decl.
801 (Fcommand_execute): New forward static decl.
802 * keymap.c (Flookup_key): New forward static decl.
803 (Fcopy_keymap): Now static.
804 * keymap.h (Flookup_key): Remove decl.
805 * process.c (Fget_process): New forward static decl.
806 (Fprocess_datagram_address): Mark as internal.
807 * syntax.c (Fsyntax_table_p): New forward static decl.
808 (skip_chars): Remove duplicate decl.
809 * textprop.c (Fprevious_property_change): New forward static decl.
810 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
812 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
813 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
815 * editfns.c (Fformat): Remove unreachable code.
817 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
819 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
822 2011-04-13 Eli Zaretskii <eliz@gnu.org>
824 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
825 when at ZV. (Bug#8487)
827 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
829 * charset.c (Fclear_charset_maps): Use xfree instead of free.
831 * keyboard.c (parse_tool_bar_item): Likewise.
832 * sound.c (sound_cleanup, alsa_close): Likewise.
833 * termcap.c (tgetent): Likewise.
834 * xfns.c (x_default_font_parameter): Likewise.
835 * xsettings.c (read_and_apply_settings): Likewise.
837 * alloc.c (overrun_check_malloc, overrun_check_realloc)
838 (overrun_check_free): Protoize.
840 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
842 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
843 since callers should never pass a negative size.
844 Change the signature to match that of plain 'read' and 'write'; see
845 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
846 * lisp.h: Update prototypes of emacs_write and emacs_read.
848 2011-04-11 Eli Zaretskii <eliz@gnu.org>
850 * xdisp.c (redisplay_window): Don't try to determine the character
851 position of the scroll margin if the window start point w->startp
852 is outside the buffer's accessible region. (Bug#8468)
854 2011-04-10 Eli Zaretskii <eliz@gnu.org>
856 Fix write-region and its subroutines for buffers > 2GB.
857 * fileio.c (a_write, e_write): Modify declaration of arguments and
858 local variables to support buffers larger than 2GB.
859 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
861 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
862 argument, local variables, and return value.
864 * lisp.h: Update prototypes of emacs_write and emacs_read.
866 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
868 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
870 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
872 Fix more problems found by GCC 4.6.0's static checks.
874 * xdisp.c (vmessage): Use a better test for character truncation.
876 * charset.c (load_charset_map): <, not <=, for optimization,
877 and to avoid potential problems with integer overflow.
878 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
879 * casetab.c (set_identity, shuffle): Likewise.
880 * editfns.c (Fformat): Likewise.
881 * syntax.c (skip_chars): Likewise.
883 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
884 This also lets GCC 4.6.0 generate slightly better loop code.
886 * callint.c (Fcall_interactively): <, not <=, for optimization.
887 (Fcall_interactively): Count the number of arguments produced,
888 not the number of arguments given. This is simpler and lets GCC
889 4.6.0 generate slightly better code.
891 * ftfont.c: Distingish more carefully between FcChar8 and char.
892 The previous code passed unsigned char * to a functions like
893 strlen and xstrcasecmp that expect char *, which does not
894 conform to the C standard.
895 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
896 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
897 char * when the C standard requires it.
899 * keyboard.c (read_char): Remove unused var.
901 * eval.c: Port to Windows vsnprintf (Bug#8435).
903 (SIZE_MAX): Define if the headers do not.
904 (verror): Do not give up if vsnprintf returns a negative count.
905 Instead, grow the buffer. This ports to Windows vsnprintf, which
906 does not conform to C99. Problem reported by Eli Zaretskii.
907 Also, simplify the allocation scheme, by avoiding the need for
908 calling realloc, and removing the ALLOCATED variable.
910 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
912 Remove invocations of doprnt, as Emacs now uses vsnprintf.
913 But keep the doprint source code for now, as we might revamp it
914 and use it again (Bug#8435).
915 * lisp.h (doprnt): Remove.
916 * Makefile.in (base_obj): Remove doprnt.o.
917 * deps.mk (doprnt.o): Remove.
919 error: Print 32- and 64-bit integers portably (Bug#8435).
920 Without this change, on typical 64-bit hosts error ("...%d...", N)
921 was used to print both 32- and 64-bit integers N, which relied on
923 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
925 * lisp.h (error, verror): Mark as printf-like functions.
926 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
927 Report overflow in size calculations when allocating printf buffer.
928 Do not truncate output string at its first null byte.
929 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
930 Truncate the output at a character boundary, since vsnprintf does not
932 * charset.c (check_iso_charset_parameter): Convert internal
933 character to string before calling 'error', since %c now has the
935 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
936 overflow when computing char to be passed to 'error'. Do not
937 pass Lisp_Object to 'error'; pass the integer instead.
938 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
939 formatted with plain %d.
941 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
943 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
945 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
947 * xterm.c (x_catch_errors): Remove duplicate declaration.
949 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
951 * xdisp.c, lisp.h (message_nolog): Remove; unused.
953 2011-04-10 Jim Meyering <meyering@redhat.com>
955 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
956 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
957 return ssize_t not "int", and use size_t as the buffer length.
958 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
959 * gnutls.h: Update declarations.
960 * process.c (read_process_output): Use ssize_t, to match.
961 (send_process): Likewise.
963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
965 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
967 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
969 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
970 unsigned char, to match FcChar8 type definition.
972 * xterm.c (handle_one_xevent):
973 * xmenu.c (create_and_show_popup_menu):
974 * xselect.c (x_decline_selection_request)
975 (x_reply_selection_request): Avoid type-punned deref of X events.
977 2011-04-09 Eli Zaretskii <eliz@gnu.org>
979 Fix some uses of `int' instead of EMACS_INT.
980 * search.c (string_match_1, fast_string_match)
981 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
982 (scan_buffer, find_next_newline_no_quit)
983 (find_before_next_newline, search_command, Freplace_match)
984 (Fmatch_data): Make some `int' variables be EMACS_INT.
986 * xdisp.c (display_count_lines): 3rd argument and return value now
987 EMACS_INT. All callers changed.
988 (pint2hrstr): Last argument is now EMACS_INT.
990 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
991 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
992 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
993 (decode_coding_utf_16, decode_coding_emacs_mule)
994 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
995 (decode_coding_ccl, decode_coding_charset)
996 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
997 (decode_coding_iso_2022, decode_coding_emacs_mule)
998 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
999 <char_offset, last_offset>: Declare EMACS_INT.
1000 (encode_coding_utf_8, encode_coding_utf_16)
1001 (encode_coding_emacs_mule, encode_invocation_designation)
1002 (encode_designation_at_bol, encode_coding_iso_2022)
1003 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1004 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1006 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1007 (encode_invocation_designation): Last argument P_NCHARS is now
1009 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1010 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1012 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1015 * ccl.c (Fccl_execute_on_string): Declare some variables
1018 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1020 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1022 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1024 * process.c (Fformat_network_address): Doc fix.
1026 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1028 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1030 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1032 * keyboard.c (read_char): Call Lisp function help-form-show,
1033 instead of using internal_with_output_to_temp_buffer.
1034 (Qhelp_form_show): New var.
1035 (syms_of_keyboard): Use DEFSYM macro.
1037 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1039 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1041 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1043 * process.c (Flist_processes): Removed to Lisp.
1044 (list_processes_1): Deleted.
1046 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1048 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1050 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1052 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1054 Fix more problems found by GCC 4.6.0's static checks.
1056 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1058 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1060 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1062 * xdisp.c (vmessage): Mark as a printf-like function.
1064 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1066 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1068 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1069 printf-like functions.
1070 (tiff_load): Add casts to remove these marks before passing them
1071 to system-supplied API.
1073 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1075 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1076 This avoids several warnings with gcc -Wstrict-overflow.
1077 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1078 directly, rather than having caller test rule sign. This avoids
1079 some unnecessary tests.
1080 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1081 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1082 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1084 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1085 (xfont_open): Avoid unnecessary tests.
1087 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1089 * composite.h, composite.c (composition_gstring_put_cache):
1090 Use EMACS_INT, not int, for length.
1092 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1093 breaking out part of COMPOSITION_DECODE_RULE.
1094 (COMPOSITION_DECODE_RULE): Use it.
1095 * composite.c (get_composition_id): Remove unused local vars,
1096 by using the new macro.
1098 * textprop.c (set_text_properties_1): Change while to do-while,
1099 since the condition is always true at first.
1101 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1102 (interval_deletion_adjustment): Return unsigned value.
1105 * process.c (list_processes_1, create_pty, read_process_output):
1106 (exec_sentinel): Remove vars that were set but not used.
1107 (create_pty): Remove unnecessary "volatile"s.
1108 (Fnetwork_interface_info): Avoid possibility of int overflow.
1109 (read_process_output): Do adaptive read buffering even if carryover.
1110 (read_process_output): Simplify nbytes computation if buffered.
1112 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1114 * syntax.c (scan_words): Remove var that was set but not used.
1115 (update_syntax_table): Use unsigned instead of int.
1117 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1118 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1119 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1121 * print.c (print_error_message): Avoid int overflow.
1123 * font.c (font_list_entities): Redo for clarity,
1124 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1126 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1127 (font_score): Avoid potential overflow in diff calculation.
1129 * fns.c (substring_both): Remove var that is set but not used.
1130 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1132 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1134 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1135 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1136 can always succeed if overflow has undefined behavior.
1138 * search.c (boyer_moore, wordify): Remove vars set but not used.
1139 (wordify): Omit three unnecessary tests.
1141 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1142 All callers changed. This avoids the need for an unused var.
1144 * casefiddle.c (casify_region): Remove var that is set but not used.
1146 * dired.c (file_name_completion): Remove var that is set but not used.
1148 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1150 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1151 (Finsert_file_contents): Remove unnecessary code checking fd.
1153 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1154 Check for integer overflow on size calculations.
1156 * buffer.c (Fprevious_overlay_change): Remove var that is set
1159 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1160 Remove vars that are set but not used.
1161 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1162 (timer_check_2): Mark vars as initialized.
1164 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1166 * image.c (lookup_image): Remove var that is set but not used.
1167 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1169 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1170 that are set but not used.
1172 * xfns.c (make_invisible_cursor): Don't return garbage
1173 if XCreateBitmapFromData fails (Bug#8410).
1175 * xselect.c (x_get_local_selection, x_handle_property_notify):
1176 Remove vars that are set but not used.
1178 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1179 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1181 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1182 Remove var that is set but not used.
1183 (scroll_bar_windows_size): Now size_t, not int.
1184 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1187 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1188 (map_tty_color) [!defined MSDOS]: Likewise.
1190 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1192 * coding.c: Remove vars that are set but not used.
1193 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1194 All callers changed.
1195 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1196 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1197 (decode_coding_charset): Remove vars that are set but not used.
1199 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1200 that is set but not used.
1202 * print.c (print_object): Remove var that is set but not used.
1204 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1205 The gnulib version avoids calling malloc in the usual case,
1206 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1207 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1208 * filelock.c (current_lock_owner): Likewise.
1209 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1210 * sysdep.c: Include allocator.h, careadlinkat.h.
1211 (emacs_no_realloc_allocator): New static constant.
1212 (emacs_readlink): New function.
1213 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1214 ../lib/careadlinkat.h.
1216 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1218 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1219 first non-nil return value).
1221 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1223 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1224 if not defined (Bug#8403).
1226 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1228 * xdisp.c (display_count_lines): Remove parameter `start',
1229 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1230 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1231 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1232 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1233 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1234 and thereabouts. All callers changed.
1235 (get_per_char_metric): Remove parameter `f', unused since
1236 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1238 2011-04-02 Jim Meyering <meyering@redhat.com>
1240 do not dereference NULL upon failed strdup
1241 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1242 (ns_get_family): Likewise.
1244 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1246 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1248 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1250 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1253 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1255 Add lexical binding.
1257 * window.c (Ftemp_output_buffer_show): New fun.
1258 (Fsave_window_excursion):
1259 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1261 * lread.c (lisp_file_lexically_bound_p): New function.
1262 (Fload): Bind Qlexical_binding.
1263 (readevalloop): Remove `evalfun' arg.
1264 Bind Qinternal_interpreter_environment.
1265 (Feval_buffer): Bind Qlexical_binding.
1266 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1268 (syms_of_lread): Declare `lexical-binding'.
1270 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1272 * keyboard.c (eval_dyn): New fun.
1273 (menu_item_eval_property): Use it.
1275 * image.c (parse_image_spec): Use Ffunctionp.
1277 * fns.c (concat, mapcar1): Accept byte-code-functions.
1279 * eval.c (Fsetq): Handle lexical vars.
1280 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1281 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1282 (FletX, Flet): Obey lexical binding.
1283 (Fcommandp): Handle closures.
1284 (Feval): New `lexical' arg.
1285 (eval_sub): New function extracted from Feval. Use it almost
1286 everywhere where Feval was used. Look up vars in lexical env.
1288 (Ffunctionp): Move from subr.el.
1289 (Ffuncall): Handle closures.
1290 (apply_lambda): Remove `eval_flags'.
1291 (funcall_lambda): Handle closures and new byte-code-functions.
1292 (Fspecial_variable_p): New function.
1293 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1294 but without exporting it to Lisp.
1296 * doc.c (Fdocumentation, store_function_docstring):
1297 * data.c (Finteractive_form): Handle closures.
1299 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1302 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1304 (exec_byte_code): New function extracted from Fbyte_code to handle new
1305 calling convention for byte-code-functions. Add new byte-codes.
1307 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1309 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1313 * xdisp.c (redisplay_internal): Fix prototype.
1315 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1317 * xdisp.c (SCROLL_LIMIT): New macro.
1318 (try_scrolling): Use it when setting scroll_limit. Limit
1319 scrolling to 100 screen lines.
1320 (redisplay_window): Even when falling back on "recentering",
1321 position point in the window according to scroll-conservatively,
1322 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1324 (try_scrolling): When point is above the window, allow searching
1325 as far as scroll_max, or one screenful, to compute vertical
1326 distance from PT to the scroll margin position. This prevents
1327 try_scrolling from unnecessarily failing when
1328 scroll-conservatively is set to a value slightly larger than the
1329 window height. Clean up the case of PT below the margin at bottom
1330 of window: scroll_max can no longer be INT_MAX. When aggressive
1331 scrolling is in use, don't let point enter the opposite scroll
1332 margin as result of the scroll.
1333 (syms_of_xdisp) <scroll-conservatively>: Document the
1334 threshold of 100 lines for never-recentering scrolling.
1336 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1338 * dispextern.h (move_it_by_lines):
1339 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1340 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1341 (message_log_check_duplicate): Remove parameters `prev_bol' and
1342 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1343 (redisplay_internal): Remove parameter `preserve_echo_area',
1344 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1346 * indent.c (Fvertical_motion):
1347 * window.c (window_scroll_pixel_based, Frecenter):
1348 Don't pass `need_y_p' to `move_it_by_lines'.
1350 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1352 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1353 steal a few bits to be more compact.
1354 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1355 Remove unneeded casts.
1357 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1359 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1361 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1362 binding" message (bug#7967).
1364 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1366 Fix more problems found by GCC 4.6.0's static checks.
1368 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1369 Remove unused local var.
1371 * editfns.c (Fmessage_box): Remove unused local var.
1373 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1375 Omit unused local vars.
1376 * window.c (shrink_windows): Omit unused local var.
1377 * menu.c (digest_single_submenu): Omit unused local var.
1378 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1379 Omit unused local var.
1381 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1382 Don't assume string length fits in int.
1383 (keyremap_step, read_key_sequence): Use size_t for sizes.
1384 (read_key_sequence): Don't check last_real_key_start redundantly.
1386 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1387 instead of alloca (Bug#8344).
1389 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1390 (Fbacktrace_frame): Don't assume nframes fits in int.
1392 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1394 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1397 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1399 * cm.c (calccost): Turn while-do into do-while, for clarity.
1401 * keyboard.c (syms_of_keyboard): Use the same style as later
1402 in this function when indexing through an array. This also
1403 works around GCC bug 48267.
1405 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1407 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1409 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1410 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1412 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1413 This avoids undefined behavior on integer overflow, and is a bit
1414 more convenient anyway since it is compared to a size_t variable.
1416 Variadic C functions now count arguments with size_t, not int.
1417 This avoids an unnecessary limitation on 64-bit machines, which
1418 caused (substring ...) to crash on large vectors (Bug#8344).
1419 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1420 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1421 All variadic functions and their callers changed accordingly.
1422 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1423 * data.c (arith_driver, float_arith_driver): Likewise.
1424 * editfns.c (general_insert_function): Likewise.
1425 * eval.c (struct backtrace.nargs, interactive_p)
1426 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1427 (funcall_lambda, mark_backtrace): Likewise.
1428 * fns.c (concat): Likewise.
1429 * frame.c (x_set_frame_parameters): Likewise.
1430 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1431 0 if not found, not -1. All callers changed.
1433 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1434 (stack_copy_size): Now size_t, not int.
1435 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1439 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1440 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1441 All callers changed.
1443 * lisp.h (multibyte_char_to_unibyte):
1444 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1445 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1446 * character.h (CHAR_TO_BYTE8):
1447 * cmds.c (internal_self_insert):
1448 * editfns.c (general_insert_function):
1449 * keymap.c (push_key_description):
1450 * search.c (Freplace_match):
1451 * xdisp.c (message_dolog, set_message_1): All callers changed.
1453 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1455 * keyboard.c (safe_run_hook_funcall): New function.
1456 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1457 don't set the hook to nil, but remove the offending function instead.
1458 (Qcommand_hook_internal): Remove, unused.
1459 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1460 Vcommand_hook_internal.
1462 * eval.c (enum run_hooks_condition): Remove.
1463 (funcall_nil, funcall_not): New functions.
1464 (run_hook_with_args): Call each function through a `funcall' argument.
1465 Remove `cond' argument, now redundant.
1466 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1467 (Frun_hook_with_args_until_failure): Adjust accordingly.
1468 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1470 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1472 * dispextern.h (string_buffer_position): Remove declaration.
1474 * print.c (strout): Remove parameter `multibyte', unused since
1475 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1477 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1478 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1479 All callers changed.
1481 * w32.c (_wsa_errlist): Use braces for struct initializers.
1483 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1484 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1485 All callers changed.
1486 (string_buffer_position): Likewise. Also, make static (it's never
1487 used outside xdisp.c).
1488 (cursor_row_p): Remove parameter `w', unused since
1489 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1490 (decode_mode_spec): Remove parameter `precision', introduced during
1491 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1492 All callers changed.
1494 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1496 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1498 2011-03-27 Anders Lindgren <andlind@gmail.com>
1500 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1501 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1502 (ns_update_auto_hide_menu_bar): New functions.
1503 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1504 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1505 ns_constrain_all_frames.
1506 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1507 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1509 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1511 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1513 2011-03-27 Glenn Morris <rgm@gnu.org>
1515 * syssignal.h: Replace RETSIGTYPE with void.
1516 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1517 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1518 Replace SIGTYPE with void everywhere.
1519 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1520 * s/template.h (SIGTYPE): Remove commented out definition.
1522 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1524 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1525 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1527 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1529 * w32.c (read_unc_volume): Use parameter `henum', instead of
1530 global variable `wget_enum_handle'.
1532 * keymap.c (describe_vector): Remove parameters `indices' and
1533 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1534 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1536 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1538 * keyboard.c (timer_check): Remove parameter `do_it_now',
1539 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1540 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1541 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1543 * keyboard.c (read_char):
1544 * w32menu.c (w32_menu_display_help):
1545 * xmenu.c (show_help_event, menu_help_callback):
1546 Adjust calls to `show_help_echo'.
1548 * gtkutil.c (xg_maybe_add_timer):
1549 * keyboard.c (readable_events):
1550 * process.c (wait_reading_process_output):
1551 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1553 * insdel.c (adjust_markers_gap_motion):
1554 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1555 (gap_left, gap_right): Don't call it.
1557 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1559 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1560 incurred during fontification.
1562 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1564 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1565 (DEFVAR_PER_BUFFER): Don't pass it.
1567 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1568 (scrolling_window): Don't pass it.
1570 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1572 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1574 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1576 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1577 of variables specific to SELinux and computation of `encoded_absname'.
1579 * image.c (XPutPixel): Remove unused variable `height'.
1581 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1583 * unexw32.c (get_section_info): Remove unused variable `section'.
1585 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1586 (system_process_attributes): Remove unused variable `sess'.
1587 (sys_read): Remove unused variable `err'.
1589 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1590 (w32_wnd_proc): Remove unused variable `isdead'.
1591 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1592 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1593 (x_create_tip_frame): Remove unused variable `tem'.
1595 * w32inevt.c (w32_console_read_socket):
1596 Remove unused variable `no_events'.
1598 * w32term.c (x_draw_composite_glyph_string_foreground):
1599 Remove unused variable `width'.
1601 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1603 * w32term.c (x_set_glyph_string_clipping):
1604 Don't pass uninitialized region to CombineRgn.
1606 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1608 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1609 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1610 (Fx_close_connection): Remove unused variable `i'.
1612 * w32font.c (w32font_draw): Return number of glyphs.
1613 (w32font_open_internal): Remove unused variable `i'.
1614 (w32font_driver): Add missing initializer.
1616 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1617 (fill_in_menu): Remove unused variable `items_added'.
1619 * w32term.c (last_mouse_press_frame): Remove static global variable.
1620 (w32_clip_to_row): Remove unused variable `f'.
1621 (x_delete_terminal): Remove unused variable `i'.
1623 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1624 (NOTHING): Remove unused static global variable.
1625 (uniscribe_check_otf): Remove unused variable `table'.
1626 (uniscribe_font_driver): Add missing initializers.
1628 2011-03-23 Julien Danjou <julien@danjou.info>
1630 * term.c (Fsuspend_tty, Fresume_tty):
1631 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1632 * window.c (temp_output_buffer_show):
1633 * insdel.c (signal_before_change):
1634 * frame.c (Fhandle_switch_frame):
1635 * fileio.c (Fdo_auto_save):
1636 * emacs.c (Fkill_emacs):
1637 * editfns.c (save_excursion_restore):
1638 * cmds.c (internal_self_insert):
1639 * callint.c (Fcall_interactively):
1640 * buffer.c (Fkill_all_local_variables):
1641 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1643 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1644 unconditionnaly since it does the check itself.
1646 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1648 Fix more problems found by GCC 4.5.2's static checks.
1650 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1651 the first time through the loop, since we know p0 < p1 then.
1652 This also avoids a gcc -Wstrict-overflow warning.
1654 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1655 leading to a memory leak, possible in functions like
1656 load_charset_map_from_file that can allocate an unbounded number
1657 of objects (Bug#8318).
1659 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1660 that could (at least in theory) be that large.
1662 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1663 This is less likely to overflow, and avoids undefined behavior if
1664 overflow does occur. All callers changed. Use strtoul to scan
1665 for the unsigned long integer.
1666 (pint2hrstr): Simplify and tune code slightly.
1667 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1669 * scroll.c (do_scrolling): Work around GCC bug 48228.
1670 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1672 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1673 This also avoids a warning with gcc -Wstrict-overflow.
1674 (validate_x_resource_name): Simplify count usage.
1675 This also avoids a warning with gcc -Wstrict-overflow.
1677 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1680 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1682 * process.c (Fmake_network_process): Use socklen_t, not int,
1683 where POSIX says socklen_t is required in portable programs.
1684 This fixes a porting bug on hosts like 64-bit HP-UX, where
1685 socklen_t is wider than int (Bug#8277).
1686 (Fmake_network_process, server_accept_connection):
1687 (wait_reading_process_output, read_process_output):
1690 * process.c: Rename or move locals to avoid shadowing.
1691 (list_processes_1, Fmake_network_process):
1692 (read_process_output_error_handler, exec_sentinel_error_handler):
1693 Rename or move locals.
1694 (Fmake_network_process): Define label "retry_connect" only if needed.
1695 (Fnetwork_interface_info): Fix pointer signedness.
1696 (process_send_signal): Add cast to avoid pointer signedness problem.
1697 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1698 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1700 Make tparam.h and terminfo.c consistent.
1701 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1702 Include tparam.h instead, since it declares them.
1703 * cm.h (PC): Remove extern decl; tparam.h now does this.
1704 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1705 * terminfo.c: Include tparam.h, to check interfaces.
1706 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1707 (tparam): Adjust signature to match interface in tparam.h;
1708 this removes some undefined behavior. Check that outstring and len
1709 are zero, which they always are with Emacs.
1710 * tparam.h (PC, BC, UP): New extern decls.
1712 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1713 (xftfont_open): Rename locals to avoid shadowing.
1715 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1716 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1717 (OTF_TAG_SYM): Omit macro if not needed.
1718 (ftfont_list): Remove unused local.
1719 (get_adstyle_property, ftfont_pattern_entity):
1720 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1721 Rename locals to avoid shadowing.
1723 * xfont.c (xfont_list_family): Mark var as initialized.
1725 * xml.c (make_dom): Now static.
1727 * composite.c (composition_compute_stop_pos): Rename local to
1729 (composition_reseat_it): Remove unused locals.
1730 (find_automatic_composition, composition_adjust_point): Likewise.
1731 (composition_update_it): Mark var as initialized.
1732 (find_automatic_composition): Mark vars as initialized,
1733 with a FIXME (Bug#8290).
1735 character.h: Rename locals to avoid shadowing.
1736 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1737 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1738 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1739 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1742 * textprop.c (property_change_between_p): Remove; unused.
1744 * intervals.c (interval_start_pos): Now static.
1746 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1748 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1749 Rename locals to avoid shadowing.
1751 * sound.c (wav_play, au_play, Fplay_sound_internal):
1752 Fix pointer signedness.
1753 (alsa_choose_format): Remove unused local var.
1754 (wav_play): Initialize a variable to 0, to prevent undefined
1755 behavior (Bug#8278).
1757 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1759 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1762 clobbering (Bug#8298).
1763 * sysdep.c (sys_subshell): Likewise.
1764 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1766 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1767 This should get cleaned up, so that child_setup has the
1768 same signature on all platforms.
1770 * callproc.c (call_process_cleanup): Now static.
1771 (relocate_fd): Rename locals to avoid shadowing.
1773 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1775 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1776 not to be necessary, and produces flickering.
1778 2011-03-20 Glenn Morris <rgm@gnu.org>
1780 * config.in: Remove file.
1782 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1784 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1785 are now in src/globals.h.
1786 (syms_of_minibuf): Remove spurious & from previous change.
1788 2011-03-20 Leo <sdl.web@gmail.com>
1790 * minibuf.c (completing-read-function): New variable.
1791 (completing-read-default): Rename from completing-read.
1792 (completing-read): Call completing-read-function.
1794 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1796 * xfaces.c (Fx_load_color_file):
1797 Read color file from absolute filename (bug#8250).
1799 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1801 * makefile.w32-in: Update dependencies.
1803 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1805 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1807 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1809 Fix more problems found by GCC 4.5.2's static checks.
1811 * process.c (make_serial_process_unwind, send_process_trap):
1812 (sigchld_handler): Now static.
1814 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1815 That way, the code declares only the vars that it needs.
1816 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1817 * s/cygwin.h (PTY_ITERATION): Likewise.
1818 * s/darwin.h (PTY_ITERATION): Likewise.
1819 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1821 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1822 * process.c (allocate_pty): Don't declare stb unless it's needed.
1824 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1825 (CONSTANTLIM): Remove; unused.
1826 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1827 Define only if needed.
1829 * unexelf.c (unexec): Name an expression,
1830 to avoid gcc -Wbad-function-cast warning.
1831 Use a different way to cause a compilation error if anyone uses
1832 n rather than nn, a way that does not involve shadowing.
1833 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1835 * deps.mk (unexalpha.o): Remove; unused.
1837 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1838 * unexec.h: New file.
1839 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1840 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1842 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1843 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1844 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1845 Change as necessary to match prototype in unexec.h.
1847 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1849 (back_comment, skip_chars): Mark vars as initialized.
1851 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1852 Rename locals to avoid shadowing.
1854 * lread.c (read1): Rewrite so as not to use empty "else".
1855 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1857 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1859 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1860 warning when compiling print.c.
1862 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1863 instead of using an uninitialized var.
1864 (font_sort_entities): Mark var as initialized.
1866 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1868 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1869 pointers to constants.
1870 (font_parse_fcname): Remove unused vars.
1871 (font_delete_unmatched): Now static.
1872 (font_get_spec): Remove; unused.
1873 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1874 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1875 Rename or move locals to avoid shadowing.
1877 * fns.c (require_nesting_list, require_unwind): Now static.
1878 (Ffillarray): Rename locals to avoid shadowing.
1880 * floatfns.c (domain_error2): Define only if needed.
1881 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1883 * alloc.c (mark_backtrace): Move decl from here ...
1884 * lisp.h: ... to here, so that it can be checked.
1886 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1887 (Fdefvar): Rewrite so as not to use empty "else".
1888 (lisp_indirect_variable): Name an expression,
1889 to avoid gcc -Wbad-function-cast warning.
1890 (Fdefvar): Rename locals to avoid shadowing.
1892 * callint.c (quotify_arg, quotify_args): Now static.
1893 (Fcall_interactively): Rename locals to avoid shadowing.
1894 Use const pointer when appropriate.
1896 * lisp.h (get_system_name, get_operating_system_release):
1897 Move decls here, to check interfaces.
1898 * process.c (get_operating_system_release): Move decl to lisp.h.
1899 * xrdb.c (get_system_name): Likewise.
1900 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1901 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1902 some of which prompt warnings from gcc -Wbad-function-cast.
1903 (Fformat_time_string, Fencode_time, Finsert_char):
1904 (Ftranslate_region_internal, Fformat):
1905 Rename or remove local vars to avoid shadowing.
1906 (Ftranslate_region_internal): Mark var as initialized.
1908 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1911 * lisp.h (eassert): Check that the argument compiles, even if
1912 ENABLE_CHECKING is not defined.
1914 * data.c (Findirect_variable): Name an expression, to avoid
1915 gcc -Wbad-function-cast warning.
1916 (default_value, arithcompare, arith_driver, arith_error): Now static.
1917 (store_symval_forwarding): Rename local to avoid shadowing.
1918 (Fmake_variable_buffer_local, Fmake_local_variable):
1919 Mark variables as initialized.
1920 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1922 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1923 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1924 Rename locals to avoid shadowing.
1925 (mark_stack): Move local variables into the #ifdef region where
1927 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1928 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1930 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1931 (GC_STRING_CHARS): Remove; not used.
1932 (Fmemory_limit): Cast sbrk's returned value to char *.
1934 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1935 avoids undefined behavior in theory.
1937 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1939 Use functions, not macros, for up- and down-casing (Bug#8254).
1940 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1941 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1942 to use the following functions instead of these macros.
1943 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1944 EMACS_INT, since callers assume the returned value fits in int.
1945 (upcase1): Likewise, for UPCASE_TABLE.
1946 (uppercasep, lowercasep, upcase): New static inline functions.
1947 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1948 the race-condition problem in the old DOWNCASE.
1950 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1951 Rename locals to avoid shadowing.
1952 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1953 (regex_compile, re_search_2, re_match_2_internal):
1954 Remove unused local vars.
1955 (FREE_VAR): Rewrite so as not to use empty "else",
1956 which gcc can warn about.
1957 (regex_compile, re_match_2_internal): Mark locals as initialized.
1958 (RETALLOC_IF): Define only if needed.
1959 (WORDCHAR_P): Likewise. This one is never needed, but is used
1960 only in a comment talking about a compiler bug, so put inside
1961 the #if 0 of that comment.
1962 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1963 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1966 * search.c (boyer_moore): Rename locals to avoid shadowing.
1967 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1968 (PREV_CHAR_BOUNDARY): Likewise.
1970 * search.c (simple_search): Remove unused var.
1972 * dired.c (compile_pattern): Move decl from here ...
1973 * lisp.h: ... to here, so that it can be checked.
1974 (struct re_registers): New forward decl.
1976 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1978 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1980 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1981 Rename locals to avoid shadowing.
1982 (Fvertical_motion): Mark locals as initialized.
1984 * casefiddle.c (casify_object, casify_region): Now static.
1985 (casify_region): Mark local as initialized.
1987 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1989 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1990 New macros, so that the caller can use some names other than
1991 gcpro1, gcpro2, etc.
1992 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1994 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1995 argument, for consistency with GCPRO2_VAR, etc: it is now the
1996 prefix of the variable, not the variable itself. All uses
1998 * dired.c (directory_files_internal, file_name_completion):
1999 Rename locals to avoid shadowing.
2001 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2002 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2003 dired.c's scmp function, had undefined behavior.
2004 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2006 * buffer.h: ... to here, because these macros use current_buffer,
2007 and the new implementation with inline functions needs to have
2008 current_buffer in scope now, rather than later when the macros
2010 (downcase, upcase1): New static inline functions.
2011 (DOWNCASE, UPCASE1): Reimplement using these functions.
2012 This avoids undefined behavior in expressions like
2013 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2014 from race conditions in accessing the global variables
2015 case_temp1 and case_temp2.
2016 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2017 * lisp.h (case_temp1, case_temp2): Remove their decls.
2018 * character.h (ASCII_CHAR_P): Move from here ...
2019 * lisp.h: ... to here, so that the inline functions mentioned
2022 * dired.c (directory_files_internal_unwind): Now static.
2024 * fileio.c (file_name_as_directory, directory_file_name):
2025 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2027 (file_name_as_directory): Use const pointers when appropriate.
2028 (Fexpand_file_name): Likewise. In particular, newdir might
2029 point at constant storage, so make it a const pointer.
2030 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2031 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2033 (Fset_file_times, Finsert_file_contents, auto_save_error):
2034 Rename locals to avoid shadowing.
2036 * minibuf.c (choose_minibuf_frame_1): Now static.
2037 (Ftry_completion, Fall_completions): Rename or remove locals
2040 * marker.c (bytepos_to_charpos): Remove; unused.
2042 * lisp.h (verify_bytepos, count_markers): New decls,
2043 so that gcc does not warn that these functions aren't declared.
2045 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2046 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2047 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2048 (copy_text): Remove unused local var.
2050 * filelock.c (within_one_second): Now static.
2051 (lock_file_1): Rename local to avoid shadowing.
2053 * buffer.c (fix_overlays_before): Mark locals as initialized.
2054 (fix_start_end_in_overlays): Likewise. This function should be
2055 simplified by using pointers-to-pointers, but that's a different
2057 (switch_to_buffer_1): Now static.
2058 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2059 (report_overlay_modification): Rename locals to avoid shadowing.
2061 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2062 Fix pointer signedness issue.
2063 (sys_subshell): Mark local as volatile if checking for lint,
2064 to suppress a gcc -Wclobbered warning that does not seem to be right.
2065 (MAXPATHLEN): Define only if needed.
2067 * process.c (serial_open, serial_configure): Move decls from here ...
2068 * systty.h: ... to here, so that they can be checked.
2070 * fns.c (get_random, seed_random): Move extern decls from here ...
2071 * lisp.h: ... to here, so that they can be checked.
2073 * sysdep.c (reset_io): Now static.
2074 (wait_for_termination_signal): Remove; unused.
2076 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2077 (copy_keymap_item, append_key, push_text_char_description):
2079 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2080 (DENSE_TABLE_SIZE): Remove; unused.
2081 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2082 (describe_map_tree):
2083 Rename locals to avoid shadowing.
2085 * keyboard.c: Declare functions static if they are not used elsewhere.
2086 (echo_char, echo_dash, cmd_error, top_level_2):
2087 (poll_for_input, handle_async_input): Now static.
2088 (read_char, kbd_buffer_get_event, make_lispy_position):
2089 (make_lispy_event, make_lispy_movement, apply_modifiers):
2090 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2091 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2092 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2093 (read_key_sequence, read_char): Mark locals as initialized.
2094 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2096 * keyboard.h (make_ctrl_char): New decl.
2097 (mark_kboards): Move decl here ...
2098 * alloc.c (mark_kboards): ... from here.
2100 * lisp.h (force_auto_save_soon): New decl.
2102 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2103 (DEFINE_DUMMY_FUNCTION): New macro.
2104 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2106 (main): Add casts to avoid warnings
2107 if GCC considers string literals to be constants.
2109 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2111 * dbusbind.c: Pointer signedness fixes.
2112 (xd_signature, xd_append_arg, xd_initialize):
2113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2114 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2115 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2116 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2118 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2119 if GCC considers string literals to be constants.
2120 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2122 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2124 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2125 (print_preprocess, print_object): New macro to fix last change.
2127 * print.c (print_preprocess): Don't forget font objects.
2129 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2131 * emacs.c (USAGE3): Doc fixes.
2133 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2135 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2138 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2140 * lisp.h (VWindow_system, Qfile_name_history):
2141 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2142 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2143 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2145 * w32select.c: Don't #include "keyboard.h".
2146 (run_protected): Add extern declaration for waiting_for_input.
2148 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2149 * w32console.c (detect_input_pending, read_input_pending)
2150 (encode_terminal_code):
2151 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2152 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2153 (w32_system_caret_y, Qfile_name_history):
2154 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2155 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2156 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2157 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2158 * w32proc.c (Qlocal, report_file_error):
2159 * w32term.c (Vwindow_system, updating_frame):
2160 * w32uniscribe.c (initialized, uniscribe_font_driver):
2161 Remove unneeded extern declarations.
2163 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2165 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2167 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2169 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2170 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2171 These macros can no longer be used for assignment.
2173 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2174 Assign struct members directly, instead of using BUF_BEGV etc.
2175 (record_buffer_markers, fetch_buffer_markers): New functions for
2176 recording and fetching special buffer markers.
2177 (set_buffer_internal_1, set_buffer_temp): Use them.
2179 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2181 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2183 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2184 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2186 * xdisp.c (hscroll_window_tree):
2187 (reconsider_clip_changes): Use PT instead of BUF_PT.
2189 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2191 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2192 $(EMACS_ROOT)/lib/intprops.h.
2194 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2196 Fix more problems found by GCC 4.5.2's static checks.
2198 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2199 to unsigned char * to avoid compiler diagnostic.
2200 (xg_free_frame_widgets): Make it clear that a local variable is
2201 needed only if USE_GTK_TOOLTIP.
2202 (gdk_window_get_screen): Make it clear that this macro is needed
2203 only if USE_GTK_TOOLTIP.
2204 (int_gtk_range_get_value): New function, which avoids a diagnostic
2205 from gcc -Wbad-function-cast.
2206 (xg_set_toolkit_scroll_bar_thumb): Use it.
2207 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2208 diagnostic from gcc -Wbad-function-cast.
2209 (get_utf8_string, xg_get_file_with_chooser):
2210 Rename locals to avoid shadowing.
2211 (create_dialog): Move locals to avoid shadowing.
2213 * xgselect.c (xg_select): Remove unused var.
2215 * image.c (four_corners_best): Mark locals as initialized.
2216 (gif_load): Initialize transparent_p to zero (Bug#8238).
2217 Mark another local as initialized.
2218 (my_png_error, my_error_exit): Mark with NO_RETURN.
2220 * image.c (clear_image_cache): Now static.
2221 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2222 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2223 (x_edge_detection): Remove unnecessary cast that
2224 gcc -Wbad-function-cast diagnoses.
2225 (gif_load): Fix pointer signedness.
2226 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2227 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2229 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2231 Improve quality of tests for time stamp overflow.
2232 For example, without this patch (encode-time 0 0 0 1 1
2233 1152921504606846976) returns the obviously-bogus value (-948597
2234 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2235 reports time overflow. See
2236 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2237 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2238 * editfns.c: Include limits.h and intprops.h.
2239 (TIME_T_MIN, TIME_T_MAX): New macros.
2240 (time_overflow): Move earlier, to before first use.
2241 (hi_time, lo_time): New functions, for an accurate test for
2243 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2244 (Fget_internal_run_time): Don't assume time_t fits in int.
2245 (make_time): Use list2 instead of Fcons twice.
2246 (Fdecode_time): More accurate test for out-of-range times.
2247 (check_tm_member): New function.
2248 (Fencode_time): Use it, to test for out-of-range times.
2249 (lisp_time_argument): Don't rely on undefined left-shift and
2250 right-shift behavior when checking for time stamp overflow.
2252 * editfns.c (time_overflow): New function, refactoring common code.
2253 (Fformat_time_string, Fdecode_time, Fencode_time):
2254 (Fcurrent_time_string): Use it.
2256 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2257 * dired.c (make_time): Move to ...
2258 * editfns.c (make_time): ... here.
2259 * systime.h: Note the move.
2261 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2263 * fringe.c (update_window_fringes): Remove unused variables.
2265 * unexmacosx.c (copy_data_segment): Also copy __got section.
2268 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2270 * termcap.c [MSDOS]: Include "msdos.h".
2271 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2272 Constify `char *' arguments and their references according to
2273 prototypes in tparam.h.
2275 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2277 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2278 Adapt all references accordingly.
2280 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2282 2011-03-11 Tom Tromey <tromey@redhat.com>
2284 * buffer.c (syms_of_buffer): Remove obsolete comment.
2286 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2288 * termhooks.h (encode_terminal_code): Declare prototype.
2290 * msdos.c (encode_terminal_code): Don't declare prototype.
2292 * term.c (encode_terminal_code): Now external again, used by
2293 w32console.c and msdos.c.
2295 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2296 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2298 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2300 Fix some minor problems found by GCC 4.5.2's static checks.
2302 * fringe.c (update_window_fringes): Mark locals as initialized
2304 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2306 * alloc.c (mark_fringe_data): Move decl from here ...
2307 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2308 to check its interface.
2309 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2311 * fontset.c (free_realized_fontset): Now static.
2312 (Fset_fontset_font): Rename local to avoid shadowing.
2313 (fontset_font): Mark local as initialized.
2314 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2316 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2318 * xselect.c (x_disown_buffer_selections): Remove; not used.
2319 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2320 (x_own_selection, Fx_disown_selection_internal): Rename locals
2322 (x_handle_dnd_message): Remove local to avoid shadowing.
2324 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2325 so that the caller can use some name other than gcpro1.
2326 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2327 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2328 (Fx_backspace_delete_keys_p):
2329 Use them to avoid shadowing, and rename vars to avoid shadowing.
2330 (x_decode_color, x_set_name, x_window): Now static.
2331 (Fx_create_frame): Add braces to silence GCC warning.
2332 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2333 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2334 Remove unused locals.
2335 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2336 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2337 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2340 * xterm.h (x_mouse_leave): New decl.
2342 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2343 Remove unused functions.
2344 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2345 (x_calc_absolute_position): Now static.
2346 (XTread_socket): Don't define label "out" unless it's used.
2347 Don't declare local "event" unless it's used.
2348 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2349 unless they are used.
2350 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2351 (x_fatal_error_signal): Remove; not used.
2352 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2353 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2354 (x_error_catcher, x_connection_closed, x_error_handler):
2355 (x_error_quitter, xembed_send_message, x_iconify_frame):
2356 (my_log_handler): Rename locals to avoid shadowing.
2357 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2358 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2360 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2361 Rename or move locals to avoid shadowing.
2362 (tty_defined_color, merge_face_heights): Now static.
2363 (free_realized_faces_for_fontset): Remove; not used.
2364 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2365 does not deduce is never used uninitialized.
2366 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2367 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2369 * terminal.c (store_terminal_param): Now static.
2371 * xmenu.c (menu_highlight_callback): Now static.
2372 (set_frame_menubar): Remove unused local.
2373 (xmenu_show): Rename parameter to avoid shadowing.
2374 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2375 since they might point to immutable storage.
2376 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2377 since it's unused otherwise.
2379 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2380 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2381 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2382 avoids a gcc -Wuninitialized diagnostic.
2383 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2384 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2385 does not deduce are never used uninitialized.
2387 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2389 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2390 * window.c (window_loop, size_window):
2391 (run_window_configuration_change_hook, enlarge_window): Likewise.
2393 * window.c (display_buffer): Now static.
2394 (size_window): Mark variables that gcc -Wuninitialized
2395 does not deduce are never used uninitialized.
2396 * window.h (check_all_windows): New decl, to forestall
2397 gcc -Wmissing-prototypes diagnostic.
2398 * dispextern.h (bidi_dump_cached_states): Likewise.
2400 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2402 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2404 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2405 and to avoid gcc -Wuninitialized warning.
2406 (load_charset_map): Mark variables that gcc -Wuninitialized
2407 does not deduce are never used uninitialized.
2408 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2410 * coding.c (coding_set_source, coding_set_destination):
2411 Use "else { /* comment */ }" rather than "else /* comment */;"
2412 for clarity, and to avoid gcc -Wempty-body warning.
2413 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2414 a block, when the outer 'i' will do.
2415 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2416 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2417 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2418 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2419 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2420 Rename locals to avoid shadowing.
2421 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2422 * coding.c (emacs_mule_char, encode_invocation_designation):
2423 Now static, since they're not used elsewhere.
2424 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2425 (decode_coding_object, encode_coding_object, detect_coding_system):
2426 (decode_coding_emacs_mule): Mark variables that gcc
2427 -Wuninitialized does not deduce are never used uninitialized.
2428 (detect_coding_iso_2022): Initialize a local variable that might
2429 be used uninitialized. Leave a FIXME because it's not clear that
2430 this initialization is needed. (Bug#8211)
2431 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2432 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2433 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2434 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2435 Remove unused macros.
2437 * category.c (hash_get_category_set): Remove unused local var.
2438 (copy_category_table): Now static, since it's not used elsewhere.
2439 * character.c (string_count_byte8): Likewise.
2441 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2442 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2444 * chartab.c (copy_sub_char_table): Now static, since it's not used
2446 (sub_char_table_ref_and_range, char_table_ref_and_range):
2447 Rename locals to avoid shadowing.
2448 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2450 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2451 (BIDI_BOB): Remove unused macro.
2453 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2454 deduce are never used uninitialized.
2455 * term.c (encode_terminal_code): Likewise.
2457 * term.c (encode_terminal_code): Now static. Remove unused local.
2459 * tparam.h: New file.
2460 * term.c, tparam.h: Include it.
2461 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2462 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2463 Move these decls to tparam.h, and make them agree with what
2464 is actually in tparam.c. The previous trick of using incompatible
2465 decls in different modules does not conform to the C standard.
2466 All callers of tparam changed to use tparam's actual API.
2467 * tparam.c (tparam1, tparam, tgoto):
2468 Use const pointers where appropriate.
2470 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2471 * cm.h (struct cm): Likewise.
2472 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2473 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2474 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2475 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2476 (turn_on_face, init_tty): Likewise.
2477 * termchar.h (struct tty_display_info): Likewise.
2479 * term.c (term_mouse_position): Rename local to avoid shadowing.
2481 * alloc.c (mark_ttys): Move decl from here ...
2482 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2484 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2486 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2488 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2490 * search.c (compile_pattern_1): Remove argument regp, unused since
2491 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2492 (compile_pattern): Don't pass it.
2494 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2496 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2497 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2499 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2501 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2503 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2504 gdk_window_get_screen, gdk_window_get_geometry,
2505 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2506 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2507 (xg_get_pixbuf_from_pixmap): New function.
2508 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2509 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2510 Call xg_get_pixbuf_from_pixmap instead of
2511 gdk_pixbuf_get_from_drawable.
2512 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2513 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2514 (xg_check_special_colors): Use GtkStyleContext and its functions
2516 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2517 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2518 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2519 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2520 Call gtk_widget_get_preferred_size.
2521 (xg_frame_resized): gdk_window_get_geometry only takes 5
2523 (xg_win_to_widget, xg_event_is_for_menubar):
2524 Call gdk_x11_window_lookup_for_display.
2525 (xg_set_widget_bg): New function.
2526 (delete_cb): New function.
2527 (xg_create_frame_widgets): connect delete-event to delete_cb.
2528 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2529 (xg_set_background_color): Call xg_set_widget_bg.
2530 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2531 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2532 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2533 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2535 (update_frame_tool_bar): Call gtk_widget_hide.
2536 (xg_initialize): Use GDK_KEY_g.
2538 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2540 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2542 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2543 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2544 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2546 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2548 * w32xfns.c (select_palette): Check success of RealizePalette against
2549 GDI_ERROR, not zero.
2551 See ChangeLog.11 for earlier changes.
2557 Copyright (C) 2011 Free Software Foundation, Inc.
2559 This file is part of GNU Emacs.
2561 GNU Emacs is free software: you can redistribute it and/or modify
2562 it under the terms of the GNU General Public License as published by
2563 the Free Software Foundation, either version 3 of the License, or
2564 (at your option) any later version.
2566 GNU Emacs is distributed in the hope that it will be useful,
2567 but WITHOUT ANY WARRANTY; without even the implied warranty of
2568 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2569 GNU General Public License for more details.
2571 You should have received a copy of the GNU General Public License
2572 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.