| commit | 871a1befad3d9c37c59f228154d12fe37f594703 | |
| author | Kalle Olavi Niemitalo <kon@iki.fi> | |
| Sun, 24 Jun 2007 15:46:22 +0000 (24 18:46 +0300) | ||
| committer | Kalle Olavi Niemitalo <Kalle@Astalo.kon.iki.fi> | |
| Sun, 24 Jun 2007 15:46:22 +0000 (24 18:46 +0300) | ||
| tree | 2ee955d2209ed996ed22a6e646963d2919a7908b | treesnapshot (tar.gz zip) |
| parent | f0ab7774ea65a63565eab965ac37753b2bab7e63 | commitdiff |
Bug 755: Save the form_state index in a reserved slot, not as private data.
The previous code cast the integer (long actually) to void * and gave
that to JS_SetPrivate. This did not work because JS_SetPrivate
expects pointers to be aligned and replaces the least significant bit
with a tag. By using JS_SetReservedSlot instead, we get control of
the jsval conversions and can store the integer properly.
The previous code cast the integer (long actually) to void * and gave
that to JS_SetPrivate. This did not work because JS_SetPrivate
expects pointers to be aligned and replaces the least significant bit
with a tag. By using JS_SetReservedSlot instead, we get control of
the jsval conversions and can store the integer properly.
| src/ecmascript/spidermonkey/form.c | diffblobblamehistory |