| commit | fc1c0299c364fda0d1ef6a6964dd858ad89c48ad | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Sun, 22 Jun 2008 01:36:40 +0000 (21 21:36 -0400) | ||
| committer | Robin Rosenberg <robin.rosenberg@dewire.com> | |
| Sun, 22 Jun 2008 17:50:46 +0000 (22 19:50 +0200) | ||
| tree | bbc5b16b8521b44fe267c7d831b29d83d3eeca4f | treesnapshot (tar.gz zip) |
| parent | cc32305d9177ccc48c689fabd556f8f11de8fd3d | commitdiff |
Paper bag fix quoting for SSH transport commands
Not all Git-over-SSH servers run a Bourne shell on the remote side
to evaluate the command we are sending. Some servers run git-shell,
which will fail to execute git-upload-pack if we feed it a quoted
string for the name git-upload-pack.
Testing concludes that git-shell requires the command name to never
be quoted, and the argument name to always be single quoted. As
this is a long-standing behavior in the wild jgit needs to conform,
as git-shell and all git-shell work-a-likes such as gitosis may be
following the same convention.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Not all Git-over-SSH servers run a Bourne shell on the remote side
to evaluate the command we are sending. Some servers run git-shell,
which will fail to execute git-upload-pack if we feed it a quoted
string for the name git-upload-pack.
Testing concludes that git-shell requires the command name to never
be quoted, and the argument name to always be single quoted. As
this is a long-standing behavior in the wild jgit needs to conform,
as git-shell and all git-shell work-a-likes such as gitosis may be
following the same convention.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
| org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java | diffblobblamehistory |