| commit | cc32305d9177ccc48c689fabd556f8f11de8fd3d | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 12 Jun 2008 03:25:04 +0000 (11 23:25 -0400) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 12 Jun 2008 03:25:04 +0000 (11 23:25 -0400) | ||
| tree | 1110a0488191b5bf82656e169248ce4001707f70 | treesnapshot (tar.gz zip) |
| parent | 93542938156ab130b81d5e73450ad2a6c9eca6e9 | commitdiff |
Add TODO marker about SWTWalk not disposing in HistoryPage
We shouldn't need to dispose of the SWTWalk here. The walker has
a bug and is not properly resetting itself when HEAD is reset to
HEAD^1 or some other value. Robin has worked around the issue by
forcing a reset for any change in HEAD as part of d5a698391f17,
but that is only a workaround as it removes any caching that the
SWTWalk might be able to perform.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
We shouldn't need to dispose of the SWTWalk here. The walker has
a bug and is not properly resetting itself when HEAD is reset to
HEAD^1 or some other value. Robin has worked around the issue by
forcing a reset for any change in HEAD as part of d5a698391f17,
but that is only a workaround as it removes any caching that the
SWTWalk might be able to perform.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java | diffblobblamehistory |