patches/gtk2/modules-other-gail-gailtreeview.c-Incorporate-review-sugg.patch

   1 From: Brady Minardi <bradyminardi@fake-box.com>
   2 Date: Sat, 14 Jul 2018 14:45:28 +0000
   3 Subject: modules/other/gail/gailtreeview.c: Incorporate review suggestions
   4
   5 Incorporate review suggestions by Emmanuele Bassi.
   6
   7 Origin: upstream, 2.24.33, commit:8f8336cd9410c39ac53da40de69907a0844024d5
   8 ---
   9  modules/other/gail/gailtreeview.c | 15 ++++++++++-----
  10  1 file changed, 10 insertions(+), 5 deletions(-)
  11
  12 diff --git a/modules/other/gail/gailtreeview.c b/modules/other/gail/gailtreeview.c
  13 index ee8fa00..23923c5 100644
  14 --- a/modules/other/gail/gailtreeview.c
  15 +++ b/modules/other/gail/gailtreeview.c
  16 @@ -223,7 +223,7 @@ static void             adjustment_changed              (GtkAdjustment
  17
  18  /* Misc */
  19
  20 -static void             set_iter_nth_row                (GtkTreeView            *tree_view,
  21 +static gboolean         set_iter_nth_row                (GtkTreeView            *tree_view,
  22                                                           GtkTreeIter            *iter,
  23                                                           gint                   row);
  24  static gint             get_row_from_tree_path          (GtkTreeView            *tree_view,
  25 @@ -1466,8 +1466,10 @@ gail_tree_view_add_row_selection (AtkTable *table,
  26          }
  27        else
  28          {
  29 -          set_iter_nth_row (tree_view, &iter_to_row, row);
  30 -          gtk_tree_selection_select_iter (selection, &iter_to_row);
  31 +          if (set_iter_nth_row (tree_view, &iter_to_row, row))
  32 +            gtk_tree_selection_select_iter (selection, &iter_to_row);
  33 +          else
  34 +            return FALSE;
  35          }
  36      }
  37
  38 @@ -3236,7 +3238,7 @@ update_cell_value (GailRendererCell *renderer_cell,
  39    return gail_renderer_cell_update_cache (renderer_cell, emit_change_signal);
  40  }
  41
  42 -static void
  43 +static gboolean
  44  set_iter_nth_row (GtkTreeView *tree_view,
  45                    GtkTreeIter *iter,
  46                    gint        row)
  47 @@ -3245,7 +3247,10 @@ set_iter_nth_row (GtkTreeView *tree_view,
  48
  49    tree_model = gtk_tree_view_get_model (tree_view);
  50    gtk_tree_model_get_iter_first (tree_model, iter);
  51 -  iter = return_iter_nth_row (tree_view, tree_model, iter, 0 , row);
  52 +  if (return_iter_nth_row (tree_view, tree_model, iter, 0 , row) != NULL)
  53 +    return TRUE;
  54 +
  55 +  return FALSE;
  56  }
  57
  58  static gint