?  search:
summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
blame | history | raw | HEAD
lastcomm(1): Sync with FreeBSD's RELENG_6.
[dragonfly.git] / usr.bin / xlint / lint2 / chk.c
blobfd0186a200bb400166b26dfad760b02d95c64614
1 /* $NetBSD: chk.c,v 1.2 1995/07/03 21:24:42 cgd Exp $ */
2
3 /*
4 * Copyright (c) 1994, 1995 Jochen Pohl
5 * All Rights Reserved.
6 *
7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions
9 * are met:
10 * 1. Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
12 * 2. Redistributions in binary form must reproduce the above copyright
13 * notice, this list of conditions and the following disclaimer in the
14 * documentation and/or other materials provided with the distribution.
15 * 3. All advertising materials mentioning features or use of this software
16 * must display the following acknowledgement:
17 * This product includes software developed by Jochen Pohl for
18 * The NetBSD Project.
19 * 4. The name of the author may not be used to endorse or promote products
20 * derived from this software without specific prior written permission.
21 *
22 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
23 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
24 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
25 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
26 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
27 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
28 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
29 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
30 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
31 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
32 *
33 * $NetBSD: chk.c,v 1.2 1995/07/03 21:24:42 cgd Exp $
34 * $DragonFly: src/usr.bin/xlint/lint2/chk.c,v 1.7 2004/07/07 12:24:01 asmodai Exp $
35 */
36
37 #include <stdlib.h>
38 #include <ctype.h>
39 #include <limits.h>
40 #include <err.h>
41
42 #include "lint2.h"
43
44 /* various type information */
45 ttab_t ttab[NTSPEC];
46
47
48 static void chkund(hte_t *);
49 static void chkdnu(hte_t *);
50 static void chkdnud(hte_t *);
51 static void chkmd(hte_t *);
52 static void chkvtui(hte_t *, sym_t *, sym_t *);
53 static void chkvtdi(hte_t *, sym_t *, sym_t *);
54 static void chkfaui(hte_t *, sym_t *, sym_t *);
55 static void chkau(hte_t *, int, sym_t *, sym_t *, pos_t *,
56 fcall_t *, fcall_t *, type_t *, type_t *);
57 static void chkrvu(hte_t *, sym_t *);
58 static void chkadecl(hte_t *, sym_t *, sym_t *);
59 static void printflike(hte_t *,fcall_t *, int,
60 const char *, type_t **);
61 static void scanflike(hte_t *, fcall_t *, int,
62 const char *, type_t **);
63 static void badfmt(hte_t *, fcall_t *);
64 static void inconarg(hte_t *, fcall_t *, int);
65 static void tofewarg(hte_t *, fcall_t *);
66 static void tomanyarg(hte_t *, fcall_t *);
67 static int eqtype(type_t *, type_t *, int, int, int, int *);
68 static int eqargs(type_t *, type_t *, int *);
69 static int mnoarg(type_t *, int *);
70
71
72 void
73 inittyp(void)
74 {
75 int i;
76 static struct {
77 tspec_t it_tspec;
78 ttab_t it_ttab;
79 } ittab[] = {
80 { SIGNED, { 0, 0,
81 SIGNED, UNSIGN,
82 0, 0, 0, 0, 0, "signed" } },
83 { UNSIGN, { 0, 0,
84 SIGNED, UNSIGN,
85 0, 0, 0, 0, 0, "unsigned" } },
86 { CHAR, { CHAR_BIT, CHAR_BIT,
87 SCHAR, UCHAR,
88 1, 0, 0, 1, 1, "char" } },
89 { SCHAR, { CHAR_BIT, CHAR_BIT,
90 SCHAR, UCHAR,
91 1, 0, 0, 1, 1, "signed char" } },
92 { UCHAR, { CHAR_BIT, CHAR_BIT,
93 SCHAR, UCHAR,
94 1, 1, 0, 1, 1, "unsigned char" } },
95 { SHORT, { sizeof (short) * CHAR_BIT, 2 * CHAR_BIT,
96 SHORT, USHORT,
97 1, 0, 0, 1, 1, "short" } },
98 { USHORT, { sizeof (u_short) * CHAR_BIT, 2 * CHAR_BIT,
99 SHORT, USHORT,
100 1, 1, 0, 1, 1, "unsigned short" } },
101 { INT, { sizeof (int) * CHAR_BIT, 3 * CHAR_BIT,
102 INT, UINT,
103 1, 0, 0, 1, 1, "int" } },
104 { UINT, { sizeof (u_int) * CHAR_BIT, 3 * CHAR_BIT,
105 INT, UINT,
106 1, 1, 0, 1, 1, "unsigned int" } },
107 { LONG, { sizeof (long) * CHAR_BIT, 4 * CHAR_BIT,
108 LONG, ULONG,
109 1, 0, 0, 1, 1, "long" } },
110 { ULONG, { sizeof (u_long) * CHAR_BIT, 4 * CHAR_BIT,
111 LONG, ULONG,
112 1, 1, 0, 1, 1, "unsigned long" } },
113 { QUAD, { sizeof (quad_t) * CHAR_BIT, 8 * CHAR_BIT,
114 QUAD, UQUAD,
115 1, 0, 0, 1, 1, "long long" } },
116 { UQUAD, { sizeof (u_quad_t) * CHAR_BIT, 8 * CHAR_BIT,
117 QUAD, UQUAD,
118 1, 1, 0, 1, 1, "unsigned long long" } },
119 { FLOAT, { sizeof (float) * CHAR_BIT, 4 * CHAR_BIT,
120 FLOAT, FLOAT,
121 0, 0, 1, 1, 1, "float" } },
122 { DOUBLE, { sizeof (double) * CHAR_BIT, 8 * CHAR_BIT,
123 DOUBLE, DOUBLE,
124 0, 0, 1, 1, 1, "double" } },
125 { LDOUBLE, { sizeof (ldbl_t) * CHAR_BIT, 10 * CHAR_BIT,
126 LDOUBLE, LDOUBLE,
127 0, 0, 1, 1, 1, "long double" } },
128 { VOID, { -1, -1,
129 VOID, VOID,
130 0, 0, 0, 0, 0, "void" } },
131 { STRUCT, { -1, -1,
132 STRUCT, STRUCT,
133 0, 0, 0, 0, 0, "struct" } },
134 { UNION, { -1, -1,
135 UNION, UNION,
136 0, 0, 0, 0, 0, "union" } },
137 { ENUM, { sizeof (int) * CHAR_BIT, 3 * CHAR_BIT,
138 ENUM, ENUM,
139 1, 0, 0, 1, 1, "enum" } },
140 { PTR, { sizeof (void *) * CHAR_BIT, 4 * CHAR_BIT,
141 PTR, PTR,
142 0, 1, 0, 0, 1, "pointer" } },
143 { ARRAY, { -1, -1,
144 ARRAY, ARRAY,
145 0, 0, 0, 0, 0, "array" } },
146 { FUNC, { -1, -1,
147 FUNC, FUNC,
148 0, 0, 0, 0, 0, "function" } },
149 };
150
151 for (i = 0; i < sizeof (ittab) / sizeof (ittab[0]); i++)
152 STRUCT_ASSIGN(ttab[ittab[i].it_tspec], ittab[i].it_ttab);
153 if (!pflag) {
154 for (i = 0; i < NTSPEC; i++)
155 ttab[i].tt_psz = ttab[i].tt_sz;
156 }
157 }
158
159
160 /*
161 * If there is a symbol named "main", mark it as used.
162 */
163 void
164 mainused(void)
165 {
166 hte_t *hte;
167
168 if ((hte = hsearch("main", 0)) != NULL)
169 hte->h_used = 1;
170 }
171
172 /*
173 * Performs all tests for a single name
174 */
175 void
176 chkname(hte_t *hte)
177 {
178 sym_t *sym, *def, *pdecl, *decl;
179
180 if (uflag) {
181 chkund(hte);
182 chkdnu(hte);
183 if (xflag)
184 chkdnud(hte);
185 }
186 chkmd(hte);
187
188 /* Get definition, prototype declaration and declaration */
189 def = pdecl = decl = NULL;
190 for (sym = hte->h_syms; sym != NULL; sym = sym->s_nxt) {
191 if (def == NULL && (sym->s_def == DEF || sym->s_def == TDEF))
192 def = sym;
193 if (pdecl == NULL && sym->s_def == DECL &&
194 TP(sym->s_type)->t_tspec == FUNC &&
195 TP(sym->s_type)->t_proto) {
196 pdecl = sym;
197 }
198 if (decl == NULL && sym->s_def == DECL)
199 decl = sym;
200 }
201
202 /* A prototype is better than an old style declaration. */
203 if (pdecl != NULL)
204 decl = pdecl;
205
206 chkvtui(hte, def, decl);
207
208 chkvtdi(hte, def, decl);
209
210 chkfaui(hte, def, decl);
211
212 chkrvu(hte, def);
213
214 chkadecl(hte, def, decl);
215 }
216
217 /*
218 * Print a warning if the name has been used, but not defined.
219 */
220 static void
221 chkund(hte_t *hte)
222 {
223 fcall_t *fcall;
224 usym_t *usym;
225
226 if (!hte->h_used || hte->h_def)
227 return;
228
229 if ((fcall = hte->h_calls) != NULL) {
230 /* %s used( %s ), but not defined */
231 msg(0, hte->h_name, mkpos(&fcall->f_pos));
232 } else if ((usym = hte->h_usyms) != NULL) {
233 /* %s used( %s ), but not defined */
234 msg(0, hte->h_name, mkpos(&usym->u_pos));
235 }
236 }
237
238 /*
239 * Print a warning if the name has been defined, but never used.
240 */
241 static void
242 chkdnu(hte_t *hte)
243 {
244 sym_t *sym;
245
246 if (!hte->h_def || hte->h_used)
247 return;
248
249 for (sym = hte->h_syms; sym != NULL; sym = sym->s_nxt) {
250 if (sym->s_def == DEF || sym->s_def == TDEF) {
251 /* %s defined( %s ), but never used */
252 msg(1, hte->h_name, mkpos(&sym->s_pos));
253 break;
254 }
255 }
256 }
257
258 /*
259 * Print a warning if the name has been declared, but is not used
260 * or defined.
261 */
262 static void
263 chkdnud(hte_t *hte)
264 {
265 sym_t *sym;
266
267 if (hte->h_syms == NULL || hte->h_used || hte->h_def)
268 return;
269
270 if ((sym = hte->h_syms) != NULL) {
271 if (sym->s_def != DECL)
272 errx(1, "internal error: chkdnud() 1");
273 /* %s declared( %s ), but never used or defined */
274 msg(2, hte->h_name, mkpos(&sym->s_pos));
275 }
276 }
277
278 /*
279 * Print a warning if there is more then one definition for
280 * this name.
281 */
282 static void
283 chkmd(hte_t *hte)
284 {
285 sym_t *sym, *def1;
286 char *pos1;
287
288 if (!hte->h_def)
289 return;
290
291 def1 = NULL;
292 for (sym = hte->h_syms; sym != NULL; sym = sym->s_nxt) {
293 /*
294 * ANSI C allows tentative definitions of the same name in
295 * only one compilation unit.
296 */
297 if (sym->s_def != DEF && (!sflag || sym->s_def != TDEF))
298 continue;
299 if (def1 == NULL) {
300 def1 = sym;
301 continue;
302 }
303 pos1 = xstrdup(mkpos(&def1->s_pos));
304 /* %s multiply defined\t%s :: %s */
305 msg(3, hte->h_name, pos1, mkpos(&sym->s_pos));
306 free(pos1);
307 }
308 }
309
310 /*
311 * Print a warning if the return value assumed for a function call
312 * differs from the return value of the function definition or
313 * function declaration.
314 *
315 * If no definition/declaration can be found, the assumed return values
316 * are always int. So there is no need to compare with another function
317 * call as it's done for function arguments.
318 */
319 static void
320 chkvtui(hte_t *hte, sym_t *def, sym_t *decl)
321 {
322 fcall_t *call;
323 char *pos1;
324 type_t *tp1, *tp2;
325 /* LINTED (automatic hides external declaration: warn) */
326 int warn, eq;
327 tspec_t t1;
328
329 if (hte->h_calls == NULL)
330 return;
331
332 if (def == NULL)
333 def = decl;
334 if (def == NULL)
335 return;
336
337 t1 = (tp1 = TP(def->s_type)->t_subt)->t_tspec;
338 for (call = hte->h_calls; call != NULL; call = call->f_nxt) {
339 tp2 = TP(call->f_type)->t_subt;
340 eq = eqtype(tp1, tp2, 1, 0, 0, (warn = 0, &warn));
341 if (!call->f_rused) {
342 /* no return value used */
343 if ((t1 == STRUCT || t1 == UNION) && !eq) {
344 /*
345 * If a function returns a struct or union it
346 * must be declared to return a struct or
347 * union, also if the return value is ignored.
348 * This is necessary because the caller must
349 * allocate stack space for the return value.
350 * If it does not, the return value would over-
351 * write other data.
352 * XXX Following massage may be confusing
353 * because it appears also if the return value
354 * was declared inconsistently. But this
355 * behaviour matches pcc based lint, so it is
356 * accepted for now.
357 */
358 pos1 = xstrdup(mkpos(&def->s_pos));
359 /* %s value must be decl. before use %s :: %s */
360 msg(17, hte->h_name,
361 pos1, mkpos(&call->f_pos));
362 free(pos1);
363 }
364 continue;
365 }
366 if (!eq || (sflag && warn)) {
367 pos1 = xstrdup(mkpos(&def->s_pos));
368 /* %s value used inconsistenty\t%s :: %s */
369 msg(4, hte->h_name, pos1, mkpos(&call->f_pos));
370 free(pos1);
371 }
372 }
373 }
374
375 /*
376 * Print a warning if a definition/declaration does not match another
377 * definition/declaration of the same name. For functions, only the
378 * types of return values are tested.
379 */
380 static void
381 chkvtdi(hte_t *hte, sym_t *def, sym_t *decl)
382 {
383 sym_t *sym;
384 type_t *tp1, *tp2;
385 /* LINTED (automatic hides external declaration: warn) */
386 int eq, warn;
387 char *pos1;
388
389 if (def == NULL)
390 def = decl;
391 if (def == NULL)
392 return;
393
394 tp1 = TP(def->s_type);
395 for (sym = hte->h_syms; sym != NULL; sym = sym->s_nxt) {
396 if (sym == def)
397 continue;
398 tp2 = TP(sym->s_type);
399 warn = 0;
400 if (tp1->t_tspec == FUNC && tp2->t_tspec == FUNC) {
401 eq = eqtype(tp1->t_subt, tp2->t_subt, 1, 0, 0, &warn);
402 } else {
403 eq = eqtype(tp1, tp2, 0, 0, 0, &warn);
404 }
405 if (!eq || (sflag && warn)) {
406 pos1 = xstrdup(mkpos(&def->s_pos));
407 /* %s value declared inconsistently\t%s :: %s */
408 msg(5, hte->h_name, pos1, mkpos(&sym->s_pos));
409 free(pos1);
410 }
411 }
412 }
413
414 /*
415 * Print a warning if a function is called with arguments which does
416 * not match the function definition, declaration or another call
417 * of the same function.
418 */
419 static void
420 chkfaui(hte_t *hte, sym_t *def, sym_t *decl)
421 {
422 type_t *tp1, *tp2, **ap1, **ap2;
423 pos_t *pos1p;
424 fcall_t *calls, *call, *call1;
425 int n, as;
426 char *pos1;
427 arginf_t *ai;
428
429 if ((calls = hte->h_calls) == NULL)
430 return;
431
432 /*
433 * If we find a function definition, we use this for comparision,
434 * otherwise the first prototype we can find. If there is no
435 * definition or prototype declaration, the first function call
436 * is used.
437 */
438 tp1 = NULL;
439 call1 = NULL;
440 if (def != NULL) {
441 if ((tp1 = TP(def->s_type))->t_tspec != FUNC)
442 return;
443 pos1p = &def->s_pos;
444 } else if (decl != NULL && TP(decl->s_type)->t_proto) {
445 if ((tp1 = TP(decl->s_type))->t_tspec != FUNC)
446 return;
447 pos1p = &decl->s_pos;
448 }
449 if (tp1 == NULL) {
450 call1 = calls;
451 calls = calls->f_nxt;
452 if ((tp1 = TP(call1->f_type))->t_tspec != FUNC)
453 return;
454 pos1p = &call1->f_pos;
455 }
456
457 n = 1;
458 for (call = calls; call != NULL; call = call->f_nxt) {
459 if ((tp2 = TP(call->f_type))->t_tspec != FUNC)
460 continue;
461 ap1 = tp1->t_args;
462 ap2 = tp2->t_args;
463 n = 0;
464 while (*ap1 != NULL && *ap2 != NULL) {
465 if (def != NULL && def->s_va && n >= def->s_nva)
466 break;
467 n++;
468 chkau(hte, n, def, decl, pos1p, call1, call,
469 *ap1, *ap2);
470 ap1++;
471 ap2++;
472 }
473 if (*ap1 == *ap2) {
474 /* equal # of arguments */
475 } else if (def != NULL && def->s_va && n >= def->s_nva) {
476 /*
477 * function definition with VARARGS; The # of
478 * arguments of the call must be at least as large
479 * as the parameter of VARARGS.
480 */
481 } else if (*ap2 != NULL && tp1->t_proto && tp1->t_vararg) {
482 /*
483 * prototype with ... and function call with
484 * at least the same # of arguments as declared
485 * in the prototype.
486 */
487 } else {
488 pos1 = xstrdup(mkpos(pos1p));
489 /* %s: variable # of args\t%s :: %s */
490 msg(7, hte->h_name, pos1, mkpos(&call->f_pos));
491 free(pos1);
492 continue;
493 }
494
495 /* perform SCANFLIKE/PRINTFLIKE tests */
496 if (def == NULL || (!def->s_prfl && !def->s_scfl))
497 continue;
498 as = def->s_prfl ? def->s_nprfl : def->s_nscfl;
499 for (ai = call->f_args; ai != NULL; ai = ai->a_nxt) {
500 if (ai->a_num == as)
501 break;
502 }
503 if (ai == NULL || !ai->a_fmt)
504 continue;
505 if (def->s_prfl) {
506 printflike(hte, call, n, ai->a_fstrg, ap2);
507 } else {
508 scanflike(hte, call, n, ai->a_fstrg, ap2);
509 }
510 }
511 }
512
513 /*
514 * Check a single argument in a function call.
515 *
516 * hte a pointer to the hash table entry of the function
517 * n the number of the argument (1..)
518 * def the function definition or NULL
519 * decl prototype declaration, old style declaration or NULL
520 * pos1p position of definition, declaration of first call
521 * call1 first call, if both def and decl are old style def/decl
522 * call checked call
523 * arg1 currently checked argument of def/decl/call1
524 * arg2 currently checked argument of call
525 *
526 */
527 static void
528 chkau(hte_t *hte, int n, sym_t *def, sym_t *decl, pos_t *pos1p,
529 fcall_t *call1, fcall_t *call, type_t *arg1, type_t *arg2)
530 {
531 /* LINTED (automatic hides external declaration: warn) */
532 int promote, asgn, warn;
533 tspec_t t1, t2;
534 arginf_t *ai, *ai1;
535 char *pos1;
536
537 /*
538 * If a function definition is available (def != NULL), we compair the
539 * function call (call) with the definition. Otherwise, if a function
540 * definition is available and it is not an old style definition
541 * (decl != NULL && TP(decl->s_type)->t_proto), we compair the call
542 * with this declaration. Otherwise we compair it with the first
543 * call we have found (call1).
544 */
545
546 /* arg1 must be promoted if it stems from an old style definition */
547 promote = def != NULL && def->s_osdef;
548
549 /*
550 * If we compair with a definition or declaration, we must perform
551 * the same checks for qualifiers in indirected types as in
552 * assignments.
553 */
554 asgn = def != NULL || (decl != NULL && TP(decl->s_type)->t_proto);
555
556 warn = 0;
557 if (eqtype(arg1, arg2, 1, promote, asgn, &warn) && (!sflag || !warn))
558 return;
559
560 /*
561 * Other lint implementations print warnings as soon as the type
562 * of an argument does not match exactly the expected type. The
563 * result are lots of warnings which are really not neccessary.
564 * We print a warning only if
565 * (0) at least one type is not an interger type and types differ
566 * (1) hflag is set and types differ
567 * (2) types differ, except in signedness
568 * If the argument is an integer constant whose msb is not set,
569 * signedness is ignored (e.g. 0 matches both signed and unsigned
570 * int). This is with and without hflag.
571 * If the argument is an integer constant with value 0 and the
572 * expected argument is of type pointer and the width of the
573 * interger constant is the same as the width of the pointer,
574 * no warning is printed.
575 */
576 t1 = arg1->t_tspec;
577 t2 = arg2->t_tspec;
578 if (isityp(t1) && isityp(t2) && !arg1->t_isenum && !arg2->t_isenum) {
579 if (promote) {
580 /*
581 * XXX Here is a problem: Althrough it is possible to
582 * pass an int where a char/short it expected, there
583 * may be loss in significant digits. We should first
584 * check for const arguments if they can be converted
585 * into the original parameter type.
586 */
587 if (t1 == FLOAT) {
588 t1 = DOUBLE;
589 } else if (t1 == CHAR || t1 == SCHAR) {
590 t1 = INT;
591 } else if (t1 == UCHAR) {
592 t1 = tflag ? UINT : INT;
593 } else if (t1 == SHORT) {
594 t1 = INT;
595 } else if (t1 == USHORT) {
596 /* CONSTCOND */
597 t1 = INT_MAX < USHRT_MAX || tflag ? UINT : INT;
598 }
599 }
600
601 if (styp(t1) == styp(t2)) {
602
603 /*
604 * types differ only in signedness; get information
605 * about arguments
606 */
607
608 /*
609 * treat a definition like a call with variable
610 * arguments
611 */
612 ai1 = call1 != NULL ? call1->f_args : NULL;
613
614 /*
615 * if two calls are compared, ai1 is set to the
616 * information for the n-th argument, if this was
617 * a constant, otherwise to NULL
618 */
619 for ( ; ai1 != NULL; ai1 = ai1->a_nxt) {
620 if (ai1->a_num == n)
621 break;
622 }
623 /*
624 * ai is set to the information of the n-th arg
625 * of the (second) call, if this was a constant,
626 * otherwise to NULL
627 */
628 for (ai = call->f_args; ai != NULL; ai = ai->a_nxt) {
629 if (ai->a_num == n)
630 break;
631 }
632
633 if (ai1 == NULL && ai == NULL) {
634 /* no constant at all */
635 if (!hflag)
636 return;
637 } else if (ai1 == NULL || ai == NULL) {
638 /* one constant */
639 if (ai == NULL)
640 ai = ai1;
641 if (ai->a_zero || ai->a_pcon)
642 /* same value in signed and unsigned */
643 return;
644 /* value (not representation) differently */
645 } else {
646 /*
647 * two constants, one signed, one unsigned;
648 * if the msb of one of the constants is set,
649 * the argument is used inconsistently.
650 */
651 if (!ai1->a_ncon && !ai->a_ncon)
652 return;
653 }
654 }
655
656 } else if (t1 == PTR && isityp(t2) && psize(t1) == psize(t2)) {
657 for (ai = call->f_args; ai != NULL; ai = ai->a_nxt) {
658 if (ai->a_num == n)
659 break;
660 }
661 if (ai != NULL && ai->a_zero)
662 return;
663 }
664
665 pos1 = xstrdup(mkpos(pos1p));
666 /* %s, arg %d used inconsistently\t%s :: %s */
667 msg(6, hte->h_name, n, pos1, mkpos(&call->f_pos));
668 free(pos1);
669 }
670
671 /*
672 * Compare the types in the NULL-terminated array ap with the format
673 * string fmt.
674 */
675 static void
676 printflike(hte_t *hte, fcall_t *call, int n, const char *fmt, type_t **ap)
677 {
678 const char *fp;
679 int fc;
680 int fwidth, prec, left, sign, space, alt, zero;
681 tspec_t sz, t1, t2;
682 type_t *tp;
683
684 fp = fmt;
685 fc = *fp++;
686
687 for ( ; ; ) {
688 if (fc == '\0') {
689 if (*ap != NULL)
690 tomanyarg(hte, call);
691 break;
692 }
693 if (fc != '%') {
694 badfmt(hte, call);
695 break;
696 }
697 fc = *fp++;
698 fwidth = prec = left = sign = space = alt = zero = 0;
699 sz = NOTSPEC;
700
701 /* Flags */
702 for ( ; ; ) {
703 if (fc == '-') {
704 if (left)
705 break;
706 left = 1;
707 } else if (fc == '+') {
708 if (sign)
709 break;
710 sign = 1;
711 } else if (fc == ' ') {
712 if (space)
713 break;
714 space = 1;
715 } else if (fc == '#') {
716 if (alt)
717 break;
718 alt = 1;
719 } else if (fc == '0') {
720 if (zero)
721 break;
722 zero = 1;
723 } else {
724 break;
725 }
726 fc = *fp++;
727 }
728
729 /* field width */
730 if (isdigit(fc)) {
731 fwidth = 1;
732 do { fc = *fp++; } while (isdigit(fc)) ;
733 } else if (fc == '*') {
734 fwidth = 1;
735 fc = *fp++;
736 if ((tp = *ap++) == NULL) {
737 tofewarg(hte, call);
738 break;
739 }
740 n++;
741 if ((t1 = tp->t_tspec) != INT && (hflag || t1 != UINT))
742 inconarg(hte, call, n);
743 }
744
745 /* precision */
746 if (fc == '.') {
747 fc = *fp++;
748 prec = 1;
749 if (isdigit(fc)) {
750 do { fc = *fp++; } while (isdigit(fc));
751 } else if (fc == '*') {
752 fc = *fp++;
753 if ((tp = *ap++) == NULL) {
754 tofewarg(hte, call);
755 break;
756 }
757 n++;
758 if (tp->t_tspec != INT)
759 inconarg(hte, call, n);
760 } else {
761 badfmt(hte, call);
762 break;
763 }
764 }
765
766 if (fc == 'h') {
767 sz = SHORT;
768 } else if (fc == 'l') {
769 sz = LONG;
770 } else if (fc == 'q') {
771 sz = QUAD;
772 } else if (fc == 'L') {
773 sz = LDOUBLE;
774 }
775 if (sz != NOTSPEC)
776 fc = *fp++;
777
778 if (fc == '%') {
779 if (sz != NOTSPEC || left || sign || space ||
780 alt || zero || prec || fwidth) {
781 badfmt(hte, call);
782 }
783 fc = *fp++;
784 continue;
785 }
786
787 if (fc == '\0') {
788 badfmt(hte, call);
789 break;
790 }
791
792 if ((tp = *ap++) == NULL) {
793 tofewarg(hte, call);
794 break;
795 }
796 n++;
797 if ((t1 = tp->t_tspec) == PTR)
798 t2 = tp->t_subt->t_tspec;
799
800 if (fc == 'd' || fc == 'i') {
801 if (alt || sz == LDOUBLE) {
802 badfmt(hte, call);
803 break;
804 }
805 int_conv:
806 if (sz == LONG) {
807 if (t1 != LONG && (hflag || t1 != ULONG))
808 inconarg(hte, call, n);
809 } else if (sz == QUAD) {
810 if (t1 != QUAD && (hflag || t1 != UQUAD))
811 inconarg(hte, call, n);
812 } else {
813 /*
814 * SHORT is always promoted to INT, USHORT
815 * to INT or UINT.
816 */
817 if (t1 != INT && (hflag || t1 != UINT))
818 inconarg(hte, call, n);
819 }
820 } else if (fc == 'o' || fc == 'u' || fc == 'x' || fc == 'X') {
821 if ((alt && fc == 'u') || sz == LDOUBLE)
822 badfmt(hte, call);
823 uint_conv:
824 if (sz == LONG) {
825 if (t1 != ULONG && (hflag || t1 != LONG))
826 inconarg(hte, call, n);
827 } else if (sz == QUAD) {
828 if (t1 != UQUAD && (hflag || t1 != QUAD))
829 inconarg(hte, call, n);
830 } else if (sz == SHORT) {
831 /* USHORT was promoted to INT or UINT */
832 if (t1 != UINT && t1 != INT)
833 inconarg(hte, call, n);
834 } else {
835 if (t1 != UINT && (hflag || t1 != INT))
836 inconarg(hte, call, n);
837 }
838 } else if (fc == 'D' || fc == 'O' || fc == 'U') {
839 if ((alt && fc != 'O') || sz != NOTSPEC || !tflag)
840 badfmt(hte, call);
841 sz = LONG;
842 if (fc == 'D') {
843 goto int_conv;
844 } else {
845 goto uint_conv;
846 }
847 } else if (fc == 'f' || fc == 'e' || fc == 'E' ||
848 fc == 'g' || fc == 'G') {
849 if (sz == NOTSPEC)
850 sz = DOUBLE;
851 if (sz != DOUBLE && sz != LDOUBLE)
852 badfmt(hte, call);
853 if (t1 != sz)
854 inconarg(hte, call, n);
855 } else if (fc == 'c') {
856 if (sz != NOTSPEC || alt || zero)
857 badfmt(hte, call);
858 if (t1 != INT)
859 inconarg(hte, call, n);
860 } else if (fc == 's') {
861 if (sz != NOTSPEC || alt || zero)
862 badfmt(hte, call);
863 if (t1 != PTR ||
864 (t2 != CHAR && t2 != UCHAR && t2 != SCHAR)) {
865 inconarg(hte, call, n);
866 }
867 } else if (fc == 'p') {
868 if (fwidth || prec || sz != NOTSPEC || alt || zero)
869 badfmt(hte, call);
870 if (t1 != PTR || (hflag && t2 != VOID))
871 inconarg(hte, call, n);
872 } else if (fc == 'n') {
873 if (fwidth || prec || alt || zero || sz == LDOUBLE)
874 badfmt(hte, call);
875 if (t1 != PTR) {
876 inconarg(hte, call, n);
877 } else if (sz == LONG) {
878 if (t2 != LONG && t2 != ULONG)
879 inconarg(hte, call, n);
880 } else if (sz == SHORT) {
881 if (t2 != SHORT && t2 != USHORT)
882 inconarg(hte, call, n);
883 } else {
884 if (t2 != INT && t2 != UINT)
885 inconarg(hte, call, n);
886 }
887 } else {
888 badfmt(hte, call);
889 break;
890 }
891
892 fc = *fp++;
893 }
894 }
895
896 /*
897 * Compare the types in the NULL-terminated array ap with the format
898 * string fmt.
899 */
900 static void
901 scanflike(hte_t *hte, fcall_t *call, int n, const char *fmt, type_t **ap)
902 {
903 const char *fp;
904 int fc;
905 int noasgn, fwidth;
906 tspec_t sz, t1, t2;
907 type_t *tp;
908
909 fp = fmt;
910 fc = *fp++;
911
912 for ( ; ; ) {
913 if (fc == '\0') {
914 if (*ap != NULL)
915 tomanyarg(hte, call);
916 break;
917 }
918 if (fc != '%') {
919 badfmt(hte, call);
920 break;
921 }
922 fc = *fp++;
923
924 noasgn = fwidth = 0;
925 sz = NOTSPEC;
926
927 if (fc == '*') {
928 noasgn = 1;
929 fc = *fp++;
930 }
931
932 if (isdigit(fc)) {
933 fwidth = 1;
934 do { fc = *fp++; } while (isdigit(fc));
935 }
936
937 if (fc == 'h') {
938 sz = SHORT;
939 } else if (fc == 'l') {
940 sz = LONG;
941 } else if (fc == 'q') {
942 sz = QUAD;
943 } else if (fc == 'L') {
944 sz = LDOUBLE;
945 }
946 if (sz != NOTSPEC)
947 fc = *fp++;
948
949 if (fc == '%') {
950 if (sz != NOTSPEC || noasgn || fwidth)
951 badfmt(hte, call);
952 fc = *fp++;
953 continue;
954 }
955
956 if (!noasgn) {
957 if ((tp = *ap++) == NULL) {
958 tofewarg(hte, call);
959 break;
960 }
961 n++;
962 if ((t1 = tp->t_tspec) == PTR)
963 t2 = tp->t_subt->t_tspec;
964 }
965
966 if (fc == 'd' || fc == 'i' || fc == 'n') {
967 if (sz == LDOUBLE)
968 badfmt(hte, call);
969 if (sz != SHORT && sz != LONG && sz != QUAD)
970 sz = INT;
971 conv:
972 if (!noasgn) {
973 if (t1 != PTR) {
974 inconarg(hte, call, n);
975 } else if (t2 != styp(sz)) {
976 inconarg(hte, call, n);
977 } else if (hflag && t2 != sz) {
978 inconarg(hte, call, n);
979 } else if (tp->t_subt->t_const) {
980 inconarg(hte, call, n);
981 }
982 }
983 } else if (fc == 'o' || fc == 'u' || fc == 'x') {
984 if (sz == LDOUBLE)
985 badfmt(hte, call);
986 if (sz == SHORT) {
987 sz = USHORT;
988 } else if (sz == LONG) {
989 sz = ULONG;
990 } else if (sz == QUAD) {
991 sz = UQUAD;
992 } else {
993 sz = UINT;
994 }
995 goto conv;
996 } else if (fc == 'D') {
997 if (sz != NOTSPEC || !tflag)
998 badfmt(hte, call);
999 sz = LONG;
1000 goto conv;
1001 } else if (fc == 'O') {
1002 if (sz != NOTSPEC || !tflag)
1003 badfmt(hte, call);
1004 sz = ULONG;
1005 goto conv;
1006 } else if (fc == 'X') {
1007 /*
1008 * XXX valid in ANSI C, but in NetBSD's libc imple-
1009 * mented as "lx". Thats why it should be avoided.
1010 */
1011 if (sz != NOTSPEC || !tflag)
1012 badfmt(hte, call);
1013 sz = ULONG;
1014 goto conv;
1015 } else if (fc == 'E') {
1016 /*
1017 * XXX valid in ANSI C, but in NetBSD's libc imple-
1018 * mented as "lf". Thats why it should be avoided.
1019 */
1020 if (sz != NOTSPEC || !tflag)
1021 badfmt(hte, call);
1022 sz = DOUBLE;
1023 goto conv;
1024 } else if (fc == 'F') {
1025 /* XXX only for backward compatibility */
1026 if (sz != NOTSPEC || !tflag)
1027 badfmt(hte, call);
1028 sz = DOUBLE;
1029 goto conv;
1030 } else if (fc == 'G') {
1031 /*
1032 * XXX valid in ANSI C, but in NetBSD's libc not
1033 * implemented
1034 */
1035 if (sz != NOTSPEC && sz != LONG && sz != LDOUBLE)
1036 badfmt(hte, call);
1037 goto fconv;
1038 } else if (fc == 'e' || fc == 'f' || fc == 'g') {
1039 fconv:
1040 if (sz == NOTSPEC) {
1041 sz = FLOAT;
1042 } else if (sz == LONG) {
1043 sz = DOUBLE;
1044 } else if (sz != LDOUBLE) {
1045 badfmt(hte, call);
1046 sz = FLOAT;
1047 }
1048 goto conv;
1049 } else if (fc == 's' || fc == '[' || fc == 'c') {
1050 if (sz != NOTSPEC)
1051 badfmt(hte, call);
1052 if (fc == '[') {
1053 if ((fc = *fp++) == '-') {
1054 badfmt(hte, call);
1055 fc = *fp++;
1056 }
1057 if (fc != ']') {
1058 badfmt(hte, call);
1059 if (fc == '\0')
1060 break;
1061 }
1062 }
1063 if (!noasgn) {
1064 if (t1 != PTR) {
1065 inconarg(hte, call, n);
1066 } else if (t2 != CHAR && t2 != UCHAR &&
1067 t2 != SCHAR) {
1068 inconarg(hte, call, n);
1069 }
1070 }
1071 } else if (fc == 'p') {
1072 if (sz != NOTSPEC)
1073 badfmt(hte, call);
1074 if (!noasgn) {
1075 if (t1 != PTR || t2 != PTR) {
1076 inconarg(hte, call, n);
1077 } else if (tp->t_subt->t_subt->t_tspec!=VOID) {
1078 if (hflag)
1079 inconarg(hte, call, n);
1080 }
1081 }
1082 } else {
1083 badfmt(hte, call);
1084 break;
1085 }
1086
1087 fc = *fp++;
1088 }
1089 }
1090
1091 static void
1092 badfmt(hte_t *hte, fcall_t *call)
1093 {
1094 /* %s: malformed format string\t%s */
1095 msg(13, hte->h_name, mkpos(&call->f_pos));
1096 }
1097
1098 static void
1099 inconarg(hte_t *hte, fcall_t *call, int n)
1100 {
1101 /* %s, arg %d inconsistent with format\t%s(%d) */
1102 msg(14, hte->h_name, n, mkpos(&call->f_pos));
1103 }
1104
1105 static void
1106 tofewarg(hte_t *hte, fcall_t *call)
1107 {
1108 /* %s: too few args for format \t%s */
1109 msg(15, hte->h_name, mkpos(&call->f_pos));
1110 }
1111
1112 static void
1113 tomanyarg(hte_t *hte, fcall_t *call)
1114 {
1115 /* %s: too many args for format \t%s */
1116 msg(16, hte->h_name, mkpos(&call->f_pos));
1117 }
1118
1119
1120 /*
1121 * Print warnings for return values which are used, but not returned,
1122 * or return values which are always or sometimes ignored.
1123 */
1124 static void
1125 chkrvu(hte_t *hte, sym_t *def)
1126 {
1127 fcall_t *call;
1128 int used, ignored;
1129
1130 if (def == NULL)
1131 /* don't know wheter or not the functions returns a value */
1132 return;
1133
1134 if (hte->h_calls == NULL)
1135 return;
1136
1137 if (def->s_rval) {
1138 /* function has return value */
1139 used = ignored = 0;
1140 for (call = hte->h_calls; call != NULL; call = call->f_nxt) {
1141 used |= call->f_rused;
1142 ignored |= !call->f_rused && !call->f_rdisc;
1143 }
1144 /*
1145 * XXX as soon as we are able to disable single warnings
1146 * the following dependencies from hflag should be removed.
1147 * but for now I do'nt want to be botherd by this warnings
1148 * which are almost always useless.
1149 */
1150 if (!used && ignored) {
1151 if (hflag)
1152 /* %s returns value which is always ignored */
1153 msg(8, hte->h_name);
1154 } else if (used && ignored) {
1155 if (hflag)
1156 /* %s returns value which is sometimes ign. */
1157 msg(9, hte->h_name);
1158 }
1159 } else {
1160 /* function has no return value */
1161 for (call = hte->h_calls; call != NULL; call = call->f_nxt) {
1162 if (call->f_rused)
1163 /* %s value is used( %s ), but none ret. */
1164 msg(10, hte->h_name, mkpos(&call->f_pos));
1165 }
1166 }
1167 }
1168
1169 /*
1170 * Print warnings for inconsistent argument declarations.
1171 */
1172 static void
1173 chkadecl(hte_t *hte, sym_t *def, sym_t *decl)
1174 {
1175 /* LINTED (automatic hides external declaration: warn) */
1176 int osdef, eq, warn, n;
1177 sym_t *sym1, *sym;
1178 type_t **ap1, **ap2, *tp1, *tp2;
1179 char *pos1;
1180 const char *pos2;
1181
1182 osdef = 0;
1183 if (def != NULL) {
1184 osdef = def->s_osdef;
1185 sym1 = def;
1186 } else if (decl != NULL && TP(decl->s_type)->t_proto) {
1187 sym1 = decl;
1188 } else {
1189 return;
1190 }
1191 if (TP(sym1->s_type)->t_tspec != FUNC)
1192 return;
1193
1194 /*
1195 * XXX Prototypes should also be compared with old style function
1196 * declarations.
1197 */
1198
1199 for (sym = hte->h_syms; sym != NULL; sym = sym->s_nxt) {
1200 if (sym == sym1 || !TP(sym->s_type)->t_proto)
1201 continue;
1202 ap1 = TP(sym1->s_type)->t_args;
1203 ap2 = TP(sym->s_type)->t_args;
1204 n = 0;
1205 while (*ap1 != NULL && *ap2 != NULL) {
1206 warn = 0;
1207 eq = eqtype(*ap1, *ap2, 1, osdef, 0, &warn);
1208 if (!eq || warn) {
1209 pos1 = xstrdup(mkpos(&sym1->s_pos));
1210 pos2 = mkpos(&sym->s_pos);
1211 /* %s, arg %d declared inconsistently ... */
1212 msg(11, hte->h_name, n + 1, pos1, pos2);
1213 free(pos1);
1214 }
1215 n++;
1216 ap1++;
1217 ap2++;
1218 }
1219 if (*ap1 == *ap2) {
1220 tp1 = TP(sym1->s_type);
1221 tp2 = TP(sym->s_type);
1222 if (tp1->t_vararg == tp2->t_vararg)
1223 continue;
1224 if (tp2->t_vararg &&
1225 sym1->s_va && sym1->s_nva == n && !sflag) {
1226 continue;
1227 }
1228 }
1229 /* %s: variable # of args declared\t%s :: %s */
1230 pos1 = xstrdup(mkpos(&sym1->s_pos));
1231 msg(12, hte->h_name, pos1, mkpos(&sym->s_pos));
1232 free(pos1);
1233 }
1234 }
1235
1236
1237 /*
1238 * Check compatibility of two types. Returns 1 if types are compatible,
1239 * otherwise 0.
1240 *
1241 * ignqual if set, ignore qualifiers of outhermost type; used for
1242 * function arguments
1243 * promote if set, promote left type before comparision; used for
1244 * comparisions of arguments with parameters of old style
1245 * definitions
1246 * asgn left indirected type must have at least the same qualifiers
1247 * like right indirected type (for assignments and function
1248 * arguments)
1249 * *warn set to 1 if an old style declaration was compared with
1250 * an incompatible prototype declaration
1251 */
1252 static int
1253 eqtype(type_t *tp1, type_t *tp2, int ignqual, int promot, int asgn, int *warn)
1254 {
1255 tspec_t t, to;
1256 int indir;
1257
1258 to = NOTSPEC;
1259 indir = 0;
1260
1261 while (tp1 != NULL && tp2 != NULL) {
1262
1263 t = tp1->t_tspec;
1264 if (promot) {
1265 if (t == FLOAT) {
1266 t = DOUBLE;
1267 } else if (t == CHAR || t == SCHAR) {
1268 t = INT;
1269 } else if (t == UCHAR) {
1270 t = tflag ? UINT : INT;
1271 } else if (t == SHORT) {
1272 t = INT;
1273 } else if (t == USHORT) {
1274 /* CONSTCOND */
1275 t = INT_MAX < USHRT_MAX || tflag ? UINT : INT;
1276 }
1277 }
1278
1279 if (asgn && to == PTR) {
1280 if (indir == 1 && (t == VOID || tp2->t_tspec == VOID))
1281 return (1);
1282 }
1283
1284 if (t != tp2->t_tspec) {
1285 /*
1286 * Give pointer to types which differ only in
1287 * signedness a chance if not sflag and not hflag.
1288 */
1289 if (sflag || hflag || to != PTR)
1290 return (0);
1291 if (styp(t) != styp(tp2->t_tspec))
1292 return (0);
1293 }
1294
1295 if (tp1->t_isenum && tp2->t_isenum) {
1296 if (tp1->t_istag && tp2->t_istag) {
1297 return (tp1->t_tag == tp2->t_tag);
1298 } else if (tp1->t_istynam && tp2->t_istynam) {
1299 return (tp1->t_tynam == tp2->t_tynam);
1300 } else {
1301 return (0);
1302 }
1303 }
1304
1305 /*
1306 * XXX Handle combinations of enum and int if eflag is set.
1307 * But note: enum and 0 should be allowed.
1308 */
1309
1310 if (asgn && indir == 1) {
1311 if (!tp1->t_const && tp2->t_const)
1312 return (0);
1313 if (!tp1->t_volatile && tp2->t_volatile)
1314 return (0);
1315 } else if (!ignqual && !tflag) {
1316 if (tp1->t_const != tp2->t_const)
1317 return (0);
1318 if (tp1->t_const != tp2->t_const)
1319 return (0);
1320 }
1321
1322 if (t == STRUCT || t == UNION) {
1323 if (tp1->t_istag && tp2->t_istag) {
1324 return (tp1->t_tag == tp2->t_tag);
1325 } else if (tp1->t_istynam && tp2->t_istynam) {
1326 return (tp1->t_tynam == tp2->t_tynam);
1327 } else {
1328 return (0);
1329 }
1330 }
1331
1332 if (t == ARRAY && tp1->t_dim != tp2->t_dim) {
1333 if (tp1->t_dim != 0 && tp2->t_dim != 0)
1334 return (0);
1335 }
1336
1337 if (t == FUNC) {
1338 if (tp1->t_proto && tp2->t_proto) {
1339 if (!eqargs(tp1, tp2, warn))
1340 return (0);
1341 } else if (tp1->t_proto) {
1342 if (!mnoarg(tp1, warn))
1343 return (0);
1344 } else if (tp2->t_proto) {
1345 if (!mnoarg(tp2, warn))
1346 return (0);
1347 }
1348 }
1349
1350 tp1 = tp1->t_subt;
1351 tp2 = tp2->t_subt;
1352 ignqual = promot = 0;
1353 to = t;
1354 indir++;
1355
1356 }
1357
1358 return (tp1 == tp2);
1359 }
1360
1361 /*
1362 * Compares arguments of two prototypes
1363 */
1364 static int
1365 eqargs(type_t *tp1, type_t *tp2, int *warn)
1366 {
1367 type_t **a1, **a2;
1368
1369 if (tp1->t_vararg != tp2->t_vararg)
1370 return (0);
1371
1372 a1 = tp1->t_args;
1373 a2 = tp2->t_args;
1374
1375 while (*a1 != NULL && *a2 != NULL) {
1376
1377 if (eqtype(*a1, *a2, 1, 0, 0, warn) == 0)
1378 return (0);
1379
1380 a1++;
1381 a2++;
1382
1383 }
1384
1385 return (*a1 == *a2);
1386 }
1387
1388 /*
1389 * mnoarg() (matches functions with no argument type information)
1390 * returns 1 if all parameters of a prototype are compatible with
1391 * and old style function declaration.
1392 * This is the case if following conditions are met:
1393 * 1. the prototype must have a fixed number of parameters
1394 * 2. no parameter is of type float
1395 * 3. no parameter is converted to another type if integer promotion
1396 * is applied on it
1397 */
1398 static int
1399 mnoarg(type_t *tp, int *warn)
1400 {
1401 type_t **arg;
1402 tspec_t t;
1403
1404 if (tp->t_vararg && warn != NULL)
1405 *warn = 1;
1406 for (arg = tp->t_args; *arg != NULL; arg++) {
1407 if ((t = (*arg)->t_tspec) == FLOAT)
1408 return (0);
1409 if (t == CHAR || t == SCHAR || t == UCHAR)
1410 return (0);
1411 if (t == SHORT || t == USHORT)
1412 return (0);
1413 }
1414 return (1);
1415 }
DragonFly BSD