Make AddMouseRegion's index unsignedmaster
commit1bbb32008ecb58acaec9ea70e00b4ea1735408fc
authorMichael Tautschnig <tautschn@amazon.com>
Tue, 10 Oct 2023 15:09:06 +0000 (10 15:09 +0000)
committerCarlos R. Mafra <crmafra@gmail.com>
Wed, 11 Oct 2023 18:15:15 +0000 (11 19:15 +0100)
treed8965a7486bad8ed33c3d0fcc791cc5385704915
parent1f59081cd9df74aa890b7cab701afd643481e6a1
Make AddMouseRegion's index unsigned

This was previously already done for wmbiff/wmgeneral: the index
argument is used as an index into an array, and is always only tested to
be below the upper bound. Passing in a negative value would pass that
test, and would result in an out-of-bounds access. All dockapps appear
to get that right, but libdockapp could see this violated by a (future)
user.
34 files changed:
libdockapp/src/wmgeneral.c
libdockapp/src/wmgeneral.h
wmCalClock/Src/xutils.h
wmMatrix/xutils.h
wmcalclockkbd/src/xutils.h
wmcube/wmgeneral/wmgeneral.c
wmcube/wmgeneral/wmgeneral.h
wmdonkeymon/wmgeneral/wmgeneral.c
wmdonkeymon/wmgeneral/wmgeneral.h
wmglobe/src/wmglobe.h
wmglobe/src/wmgutil.c
wmgrabimage/wmgeneral/wmgeneral.c
wmgrabimage/wmgeneral/wmgeneral.h
wmifinfo/xutils.h
wmjiface/src/xutils/xutils.h
wmjmail/src/xutils/xutils.h
wmmoonclock/src/xutils.h
wmmp3/wmgeneral.c
wmmp3/wmgeneral.h
wmpower/src/dockapp/dockapp.c
wmpower/src/dockapp/dockapp.h
wmthemech/src/wmgeneral.c
wmthemech/src/wmgeneral.h
wmthrottle/src/mouse_regions.c
wmthrottle/src/mouse_regions.h
wmtunlo/docklib.c
wmtunlo/docklib.h
wmtv/src/wmgeneral/wmgeneral.c
wmtv/src/wmgeneral/wmgeneral.h
wmwork/src/wmgeneral.c
wmwork/src/wmgeneral.h
wmxss/Src/xutils.h
yawmppp/src/dockapp/wmgeneral.c
yawmppp/src/dockapp/wmgeneral.h