doc: reference shuf(1) from the sort (-R) man page
[coreutils.git] / cfg.mk
blobbc5a1e8579fb3d7937e4882beba48725f7fb8c6d
1 # Customize maint.mk -*- makefile -*-
2 # Copyright (C) 2003-2015 Free Software Foundation, Inc.
4 # This program is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License as published by
6 # the Free Software Foundation, either version 3 of the License, or
7 # (at your option) any later version.
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
14 # You should have received a copy of the GNU General Public License
15 # along with this program. If not, see <http://www.gnu.org/licenses/>.
17 # Used in maint.mk's web-manual rule
18 manual_title = Core GNU utilities
20 # Use the direct link. This is guaranteed to work immediately, while
21 # it can take a while for the faster mirror links to become usable.
22 url_dir_list = http://ftp.gnu.org/gnu/$(PACKAGE)
24 # Tests not to run as part of "make distcheck".
25 local-checks-to-skip = \
26 sc_proper_name_utf8_requires_ICONV
28 # Tools used to bootstrap this package, used for "announcement".
29 bootstrap-tools = autoconf,automake,gnulib,bison
31 # Now that we have better tests, make this the default.
32 export VERBOSE = yes
34 # Comparing tarball sizes compressed using different xz presets, we see that
35 # an -8e-compressed tarball is only 9KiB larger than the -9e-compressed one.
36 # Using -8e is preferred, since that lets the decompression process use half
37 # the memory (32MiB rather than 64MiB).
38 # $ for i in {7,8,9}{e,}; do \
39 # (n=$(xz -$i < coreutils-8.15*.tar|wc -c);echo $n $i) & done |sort -nr
40 # 5129388 7
41 # 5036524 7e
42 # 5017476 8
43 # 5010604 9
44 # 4923016 8e
45 # 4914152 9e
46 export XZ_OPT = -8e
48 old_NEWS_hash = 5c64c69e6303deaceecacc4b498a61fd
50 # Add an exemption for sc_makefile_at_at_check.
51 _makefile_at_at_check_exceptions = ' && !/^cu_install_prog/ && !/dynamic-dep/'
53 # Our help-version script is in a slightly different location.
54 _hv_file ?= $(srcdir)/tests/misc/help-version
56 # Ensure that the list of O_ symbols used to compute O_FULLBLOCK is complete.
57 dd = $(srcdir)/src/dd.c
58 sc_dd_O_FLAGS:
59 @rm -f $@.1 $@.2
60 @{ echo O_FULLBLOCK; echo O_NOCACHE; \
61 perl -nle '/^ +\| (O_\w*)$$/ and print $$1' $(dd); } | sort > $@.1
62 @{ echo O_NOFOLLOW; perl -nle '/{"[a-z]+",\s*(O_\w+)},/ and print $$1' \
63 $(dd); } | sort > $@.2
64 @diff -u $@.1 $@.2; diff=$$?; \
65 rm -f $@.1 $@.2; \
66 test "$$diff" = 0 \
67 || { echo '$(ME): $(dd) has inconsistent O_ flag lists'>&2; \
68 exit 1; }
70 # Ensure that dd's definition of LONGEST_SYMBOL stays in sync
71 # with the strings from the two affected variables.
72 dd_c = $(srcdir)/src/dd.c
73 sc_dd_max_sym_length:
74 ifneq ($(wildcard $(dd_c)),)
75 @len=$$( (sed -n '/conversions\[\] =$$/,/^};/p' $(dd_c);\
76 sed -n '/flags\[\] =$$/,/^};/p' $(dd_c) ) \
77 |sed -n '/"/s/^[^"]*"\([^"]*\)".*/\1/p'| wc -L);\
78 max=$$(sed -n '/^#define LONGEST_SYMBOL /s///p' $(dd_c) \
79 |tr -d '"' | wc -L); \
80 if test "$$len" = "$$max"; then :; else \
81 echo 'dd.c: LONGEST_SYMBOL is not longest' 1>&2; \
82 exit 1; \
84 endif
86 # Many m4 macros names once began with 'jm_'.
87 # On 2004-04-13, they were all changed to start with gl_ instead.
88 # Make sure that none are inadvertently reintroduced.
89 sc_prohibit_jm_in_m4:
90 @grep -nE 'jm_[A-Z]' \
91 $$($(VC_LIST) m4 |grep '\.m4$$'; echo /dev/null) && \
92 { echo '$(ME): do not use jm_ in m4 macro names' \
93 1>&2; exit 1; } || :
95 # Ensure that each root-requiring test is run via the "check-root" rule.
96 sc_root_tests:
97 @t1=sc-root.expected; t2=sc-root.actual; \
98 grep -nl '^ *require_root_$$' `$(VC_LIST) tests` | \
99 sed 's|.*/tests/|tests/|' | sort > $$t1; \
100 for t in $(all_root_tests); do echo $$t; done | sort > $$t2; \
101 st=0; diff -u $$t1 $$t2 || st=1; \
102 rm -f $$t1 $$t2; \
103 exit $$st
105 # Ensure that all version-controlled test cases are listed in $(all_tests).
106 sc_tests_list_consistency:
107 @bs="\\"; \
108 test_extensions_rx=`echo $(TEST_EXTENSIONS) \
109 | sed -e "s/ /|/g" -e "s/$$bs./$$bs$$bs./g"`; \
111 for t in $(all_tests); do echo $$t; done; \
112 cd $(top_srcdir); \
113 $(SHELL) build-aux/vc-list-files tests \
114 | grep -Ev '^tests/(factor/(run|create-test)|init)\.sh$$' \
115 | $(EGREP) "$$test_extensions_rx\$$"; \
116 } | sort | uniq -u | grep . && exit 1; :
118 # Ensure that all version-controlled test scripts are executable.
119 sc_tests_executable:
120 @set -o noglob 2>/dev/null || set -f; \
121 find_ext="-name '' "`printf -- "-o -name *%s " $(TEST_EXTENSIONS)`;\
122 find $(srcdir)/tests/ \( $$find_ext \) \! -perm -u+x -print \
123 | { sed "s|^$(srcdir)/||"; git ls-files $(srcdir)/tests/; } \
124 | sort | uniq -d \
125 | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
126 && exit 1; :
128 # Ensure all gnulib patches apply cleanly
129 sc_ensure_gl_diffs_apply_cleanly:
130 @find $(srcdir)/gl/ -name '*.diff' | while read p; do \
131 patch --fuzz=0 -f -s -d $(srcdir)/gnulib/ -p1 --dry-run < "$$p" >&2 \
132 || { echo "$$p" >&2; echo 'To refresh all gl patches run:' \
133 'make refresh-gnulib-patches' >&2; exit 1; } \
134 done
136 # Avoid :>file which doesn't propagate errors
137 sc_prohibit_colon_redirection:
138 @cd $(srcdir)/tests && GIT_PAGER= git grep -n ': *>.*||' \
139 && { echo '$(ME): '"The leading colon in :> will hide errors" 1>&2; \
140 exit 1; } \
141 || :
143 # Create a list of regular expressions matching the names
144 # of files included from system.h. Exclude a couple.
145 .re-list:
146 @sed -n '/^# *include /s///p' $(srcdir)/src/system.h \
147 | grep -Ev 'sys/(param|file)\.h' \
148 | sed 's/ .*//;;s/^["<]/^# *include [<"]/;s/\.h[">]$$/\\.h[">]/' \
149 > $@-t
150 @mv $@-t $@
152 define gl_trap_
153 Exit () { set +e; (exit $$1); exit $$1; }; \
154 for sig in 1 2 3 13 15; do \
155 eval "trap 'Exit $$(expr $$sig + 128)' $$sig"; \
156 done
157 endef
159 # Files in src/ should not include directly any of
160 # the headers already included via system.h.
161 sc_system_h_headers: .re-list
162 @if test -f $(srcdir)/src/system.h; then \
163 trap 'rc=$$?; rm -f .re-list; exit $$rc' 0; \
164 $(gl_trap_); \
165 grep -nE -f .re-list \
166 $$($(VC_LIST_EXCEPT) | grep '^\($(srcdir)/\)\?src/') \
167 && { echo '$(ME): the above are already included via system.h'\
168 1>&2; exit 1; } || :; \
171 # Files in src/ should not use '%s' notation in format strings,
172 # i.e., single quotes around %s (or similar) should be avoided.
173 sc_prohibit_quotes_notation:
174 @cd $(srcdir)/src && GIT_PAGER= git grep -n "\".*[\`']%s'.*\"" *.c \
175 && { echo '$(ME): '"Use quote() to avoid quoted '%s' notation" 1>&2; \
176 exit 1; } \
177 || :
179 sc_sun_os_names:
180 @grep -nEi \
181 'solaris[^[:alnum:]]*2\.(7|8|9|[1-9][0-9])|sunos[^[:alnum:]][6-9]' \
182 $$($(VC_LIST_EXCEPT)) && \
183 { echo '$(ME): found misuse of Sun OS version numbers' 1>&2; \
184 exit 1; } || :
186 # Ensure that the list of programs and author names is accurate.
187 # We need a UTF8 locale. If a lack of locale support or a missing
188 # translation inhibits printing of UTF-8 names, just skip this test.
189 au_dotdot = authors-dotdot
190 au_actual = authors-actual
191 sc_check-AUTHORS: $(all_programs)
192 @locale=en_US.UTF-8; \
193 LC_ALL=$$locale ./src/cat --version \
194 | grep ' Torbjorn ' > /dev/null \
195 && { echo "$@: skipping this check"; exit 0; }; \
196 rm -f $(au_actual) $(au_dotdot); \
197 for i in `ls $(all_programs) \
198 | sed -e 's,^src/,,' -e 's,$(EXEEXT)$$,,' \
199 | sed /libstdbuf/d \
200 | $(ASSORT) -u`; do \
201 test "$$i" = '[' && continue; \
202 exe=$$i; \
203 if test "$$i" = install; then \
204 exe=ginstall; \
205 elif test "$$i" = test; then \
206 exe='['; \
207 fi; \
208 LC_ALL=$$locale ./src/$$exe --version \
209 | perl -0 -p -e 's/,\n/, /gm' \
210 | sed -n -e '/Written by /{ s//'"$$i"': /;' \
211 -e 's/,* and /, /; s/\.$$//; p; }'; \
212 done > $(au_actual) && \
213 sed -n '/^[^ ][^ ]*:/p' $(srcdir)/AUTHORS > $(au_dotdot) \
214 && diff $(au_actual) $(au_dotdot) \
215 && rm -f $(au_actual) $(au_dotdot)
217 # Each program with a non-ASCII author name must link with LIBICONV.
218 sc_check-I18N-AUTHORS:
219 @cd $(srcdir)/src && \
220 for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
221 grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
222 > /dev/null \
223 || { echo "$(ME): link rules for $$i do not include" \
224 '$$(LIBICONV)' 1>&2; exit 1; }; \
225 done
227 # Disallow the C99 printf size specifiers %z and %j as they're not portable.
228 # The gnulib printf replacement does support them, however the printf
229 # replacement is not currently explicitly depended on by the gnulib error()
230 # module for example. Also we use fprintf() in a few places to output simple
231 # formats but don't use the gnulib module as it is seen as overkill at present.
232 # We'd have to adjust the above gnulib items before disabling this.
233 sc_prohibit-c99-printf-format:
234 @cd $(srcdir)/src && GIT_PAGER= git grep -n '%[0*]*[jz][udx]' *.c \
235 && { echo '$(ME): Use PRI*MAX instead of %j or %z' 1>&2; exit 1; } \
236 || :
238 # Ensure the alternative __attribute (keyword) form isn't used as
239 # that form is not elided where required. Also ensure that we don't
240 # directly use attributes already defined by gnulib.
241 # TODO: move the check for _GL... attributes to gnulib.
242 sc_prohibit-gl-attributes:
243 @prohibit='__attribute |__(unused|pure|const)__' \
244 in_vc_files='\.[ch]$$' \
245 halt='Use _GL... attribute macros' \
246 $(_sc_search_regexp)
248 # Look for lines longer than 80 characters, except omit:
249 # - program-generated long lines in diff headers,
250 # - the help2man script copied from upstream,
251 # - tests involving long checksum lines, and
252 # - the 'pr' test cases.
253 FILTER_LONG_LINES = \
254 \|^[^:]*man/help2man:| d; \
255 \|^[^:]*tests/misc/sha[0-9]*sum.*\.pl[-:]| d; \
256 \|^[^:]*tests/pr/|{ \|^[^:]*tests/pr/pr-tests:| !d; };
257 sc_long_lines:
258 @wc -L /dev/null >/dev/null 2>/dev/null \
259 || { echo "$@: skipping: wc -L not supported"; exit 0; }; \
260 sed -r 1q /dev/null 2>/dev/null \
261 || { echo "$@: skipping: sed -r not supported"; exit 0; }; \
262 files=$$($(VC_LIST_EXCEPT) | xargs wc -L | sed -rn '/ total$$/d;\
263 s/^ *(8[1-9]|9[0-9]|[0-9]\{3,\}) //p'); \
264 halt='line(s) with more than 80 characters; reindent'; \
265 for file in $$files; do \
266 expand $$file | grep -nE '^.{80}.' | \
267 sed -e "s|^|$$file:|" -e '$(FILTER_LONG_LINES)'; \
268 done | grep . && { msg="$$halt" $(_sc_say_and_exit) } || :
270 # Option descriptions should not start with a capital letter.
271 # One could grep source directly as follows:
272 # grep -E " {2,6}-.*[^.] [A-Z][a-z]" $$($(VC_LIST_EXCEPT) | grep '\.c$$')
273 # but that would miss descriptions not on the same line as the -option.
274 sc_option_desc_uppercase: $(ALL_MANS)
275 @grep '^\\fB\\-' -A1 man/*.1 | LC_ALL=C grep '\.1.[A-Z][a-z]' \
276 && { echo 1>&2 '$@: found initial capitals in --help'; exit 1; } || :
278 # Ensure all man/*.[1x] files are present.
279 sc_man_file_correlation: check-x-vs-1 check-programs-vs-x
281 # Ensure that for each .x file in the 'man/' subdirectory, there is a
282 # corresponding .1 file in the definition of $(EXTRA_MANS).
283 # But since that expansion usually lacks programs like arch and hostname,
284 # add them here manually.
285 .PHONY: check-x-vs-1
286 check-x-vs-1:
287 @PATH=./src$(PATH_SEPARATOR)$$PATH; export PATH; \
288 t=$@-t; \
289 (cd $(srcdir)/man && ls -1 *.x) \
290 | sed 's/\.x$$//' | $(ASSORT) > $$t; \
291 (echo $(patsubst man/%,%,$(ALL_MANS)) \
292 | tr -s ' ' '\n' | sed 's/\.1$$//') \
293 | $(ASSORT) -u | diff - $$t || { rm $$t; exit 1; }; \
294 rm $$t
296 # Ensure that non-trivial .x files in the 'man/' subdirectory,
297 # i.e., files exceeding a line count of 20 or a byte count of 1000,
298 # contain a Copyright notice.
299 .PHONY: sc_man_check_x_copyright
300 sc_man_check_x_copyright:
301 @status=0; \
302 cd $(srcdir) && wc -cl man/*.x | head -n-1 \
303 | awk '$$1 >= 20 || $$2 >= 1000 {print $$3}' \
304 | xargs grep -L 'Copyright .* Free Software Foundation' \
305 | grep . \
306 && { echo 1>&2 '$@: exceeding file size/line count limit' \
307 '- please add a copyright note'; status=1; }; \
308 exit $$status
310 # Writing a portable rule to generate a manpage like '[.1' would be
311 # a nightmare, so filter that out.
312 all-progs-but-lbracket = $(filter-out [,$(patsubst src/%,%,$(all_programs)))
314 # Ensure that for each coreutils program there is a corresponding
315 # '.x' file in the 'man/' subdirectory.
316 .PHONY: check-programs-vs-x
317 check-programs-vs-x:
318 @status=0; \
319 for p in dummy $(all-progs-but-lbracket); do \
320 case $$p in *.so) continue;; esac; \
321 test $$p = dummy && continue; \
322 test $$p = ginstall && p=install || : ; \
323 test -f $(srcdir)/man/$$p.x \
324 || { echo missing $$p.x 1>&2; status=1; }; \
325 done; \
326 exit $$status
328 # Ensure we can check out on case insensitive file systems
329 sc_case_insensitive_file_names: src/uniq
330 @git ls-files | sort -f | src/uniq -Di | grep . && \
331 { echo "$(ME): the above file(s) conflict on case insensitive" \
332 " file systems" 1>&2; exit 1; } || :
334 # Ensure that the end of each release's section is marked by two empty lines.
335 sc_NEWS_two_empty_lines:
336 @sed -n 4,/Noteworthy/p $(srcdir)/NEWS \
337 | perl -n0e '/(^|\n)\n\n\* Noteworthy/ or exit 1' \
338 || { echo '$(ME): use two empty lines to separate NEWS sections' \
339 1>&2; exit 1; } || :
341 # With split lines, don't leave an operator at end of line.
342 # Instead, put it on the following line, where it is more apparent.
343 # Don't bother checking for "*" at end of line, since it provokes
344 # far too many false positives, matching constructs like "TYPE *".
345 # Similarly, omit "=" (initializers).
346 binop_re_ ?= [-/+^!<>]|[-/+*^!<>=]=|&&?|\|\|?|<<=?|>>=?
347 sc_prohibit_operator_at_end_of_line:
348 @prohibit='. ($(binop_re_))$$' \
349 in_vc_files='\.[chly]$$' \
350 halt='found operator at end of line' \
351 $(_sc_search_regexp)
353 # Don't use "readlink" or "readlinkat" directly
354 sc_prohibit_readlink:
355 @prohibit='\<readlink(at)? \(' \
356 halt='do not use readlink(at); use via xreadlink or areadlink*' \
357 $(_sc_search_regexp)
359 # Don't use address of "stat" or "lstat" functions
360 sc_prohibit_stat_macro_address:
361 @prohibit='\<l?stat '':|&l?stat\>' \
362 halt='stat() and lstat() may be function-like macros' \
363 $(_sc_search_regexp)
365 # Ensure that date's --help output stays in sync with the info
366 # documentation for GNU strftime. The only exception is %N,
367 # which date accepts but GNU strftime does not.
368 extract_char = sed 's/^[^%][^%]*%\(.\).*/\1/'
369 sc_strftime_check:
370 @if test -f $(srcdir)/src/date.c; then \
371 grep '^ %. ' $(srcdir)/src/date.c | sort \
372 | $(extract_char) > $@-src; \
373 { echo N; \
374 info libc date calendar format 2>/dev/null \
375 | grep "^ *['\`]%.'$$"| $(extract_char); }| sort >$@-info;\
376 if test $$(stat --format %s $@-info) != 2; then \
377 diff -u $@-src $@-info || exit 1; \
378 else \
379 echo '$(ME): skipping $@: libc info not installed' 1>&2; \
380 fi; \
381 rm -f $@-src $@-info; \
384 # Indent only with spaces.
385 sc_prohibit_tab_based_indentation:
386 @prohibit='^ * ' \
387 halt='TAB in indentation; use only spaces' \
388 $(_sc_search_regexp)
390 # Enforce lowercase 'e' in "I.e.".
391 sc_prohibit_uppercase_id_est:
392 @prohibit='I\.E\.' \
393 halt='Uppercase "Id Est" abbreviation; use "I.e.," instead' \
394 $(_sc_search_regexp)
396 # Enforce double-space before "I.e." at the beginning of a sentence.
397 sc_ensure_dblspace_after_dot_before_id_est:
398 @prohibit='\. I\.e\.' \
399 halt='Single space after dot before "i.e."; use ". i.e." instead' \
400 $(_sc_search_regexp)
402 # Enforce comma after "i.e." (at least before a blank or at EOL).
403 sc_ensure_comma_after_id_est:
404 @prohibit='[Ii]\.e\.( |$$)' \
405 halt='Missing comma after "i.e."; use "i.e.," instead' \
406 $(_sc_search_regexp)
408 # The SEE ALSO section of a man page should not be terminated with
409 # a period. Check the first line after each "SEE ALSO" line in man/*.x:
410 sc_prohibit_man_see_also_period:
411 @grep -nB1 '\.$$' $$($(VC_LIST_EXCEPT) | grep 'man/.*\.x$$') \
412 | grep -A1 -e '-\[SEE ALSO\]' | grep '\.$$' && \
413 { echo '$(ME): do not end "SEE ALSO" section with a period' \
414 1>&2; exit 1; } || :
416 # Don't use "indent-tabs-mode: nil" anymore. No longer needed.
417 sc_prohibit_emacs__indent_tabs_mode__setting:
418 @prohibit='^( *[*#] *)?indent-tabs-mode:' \
419 halt='use of emacs indent-tabs-mode: setting' \
420 $(_sc_search_regexp)
422 # Ensure that tests don't include a redundant fail=0.
423 sc_prohibit_fail_0:
424 @prohibit='\<fail=0\>' \
425 halt='fail=0 initialization' \
426 $(_sc_search_regexp)
428 # Ensure that tests don't use `cmd ... && fail=1` as that hides crashes.
429 # The "exclude" expression allows common idioms like `test ... && fail=1`
430 # and the 2>... portion allows commands that redirect stderr and so probably
431 # independently check its contents and thus detect any crash messages.
432 sc_prohibit_and_fail_1:
433 @prohibit='&& fail=1' \
434 exclude='(stat|kill|test |EGREP|grep|env|compare|2> *[^/])' \
435 halt='&& fail=1 detected. Please use: returns_ 1 ... || fail=1' \
436 in_vc_files='^tests/' \
437 $(_sc_search_regexp)
439 # The mode part of a setfacl -m option argument must be three bytes long.
440 # I.e., an argument of user:bin:rw or user:bin:r will make Solaris 10's
441 # setfacl reject it with: "Unrecognized character found in mode field".
442 # Use hyphens to give it a length of 3: "...:rw-" or "...:r--".
443 sc_prohibit_short_facl_mode_spec:
444 @prohibit='\<setfacl .*-m.*:.*:[rwx-]{1,2} ' \
445 halt='setfacl mode string length < 3; extend with hyphen(s)' \
446 $(_sc_search_regexp)
448 # Ensure that "stdio--.h" is used where appropriate.
449 sc_require_stdio_safer:
450 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
451 files=$$(grep -l '\bfreopen \?(' $$($(VC_LIST_EXCEPT) \
452 | grep '\.[ch]$$')); \
453 test -n "$$files" && grep -LE 'include "stdio--.h"' $$files \
454 | grep . && \
455 { echo '$(ME): the above files should use "stdio--.h"' \
456 1>&2; exit 1; } || :; \
457 else :; \
460 sc_prohibit_perl_hash_quotes:
461 @prohibit="\{'[A-Z_]+' *[=}]" \
462 halt="in Perl code, write \$$hash{KEY}, not \$$hash{'K''EY'}" \
463 $(_sc_search_regexp)
465 # Prefer xnanosleep over other less-precise sleep methods
466 sc_prohibit_sleep:
467 @prohibit='\<(nano|u)?sleep \(' \
468 halt='prefer xnanosleep over other sleep interfaces' \
469 $(_sc_search_regexp)
471 # Use print_ver_ (from init.cfg), not open-coded $VERBOSE check.
472 sc_prohibit_verbose_version:
473 @prohibit='test "\$$VERBOSE" = yes && .* --version' \
474 halt='use the print_ver_ function instead...' \
475 $(_sc_search_regexp)
477 # Use framework_failure_, not the old name without the trailing underscore.
478 sc_prohibit_framework_failure:
479 @prohibit='\<framework_''failure\>' \
480 halt='use framework_failure_ instead' \
481 $(_sc_search_regexp)
483 # Prohibit the use of `...` in tests/. Use $(...) instead.
484 sc_prohibit_test_backticks:
485 @prohibit='`' in_vc_files='^tests/' \
486 halt='use $$(...), not `...` in tests/' \
487 $(_sc_search_regexp)
489 # Ensure that compare is used to check empty files
490 # so that the unexpected contents are displayed
491 sc_prohibit_test_empty:
492 @prohibit='test -s.*&&' in_vc_files='^tests/' \
493 halt='use `compare /dev/null ...`, not `test -s ...` in tests/' \
494 $(_sc_search_regexp)
496 # Programs like sort, ls, expr use PROG_FAILURE in place of EXIT_FAILURE.
497 # Others, use the EXIT_CANCELED, EXIT_ENOENT, etc. macros defined in system.h.
498 # In those programs, ensure that EXIT_FAILURE is not used by mistake.
499 sc_some_programs_must_avoid_exit_failure:
500 @grep -nw EXIT_FAILURE \
501 $$(git grep -El '[^T]_FAILURE|EXIT_CANCELED' $(srcdir)/src) \
502 | grep -vE '= EXIT_FAILURE|return .* \?' | grep . \
503 && { echo '$(ME): do not use EXIT_FAILURE in the above' \
504 1>&2; exit 1; } || :
506 # Ensure that tests call the get_min_ulimit_v_ function if using ulimit -v
507 sc_prohibit_test_ulimit_without_require_:
508 @(git grep -l get_min_ulimit_v_ $(srcdir)/tests; \
509 git grep -l 'ulimit -v' $(srcdir)/tests) \
510 | sort | uniq -u | grep . && { echo "$(ME): the above test(s)"\
511 " should match get_min_ulimit_v_ with ulimit -v" 1>&2; exit 1; } || :
513 # Ensure that tests call the cleanup_ function if using background processes
514 sc_prohibit_test_background_without_cleanup_:
515 @(git grep -El '( &$$|&[^&]*=\$$!)' $(srcdir)/tests; \
516 git grep -l 'cleanup_()' $(srcdir)/tests | sed p) \
517 | sort | uniq -u | grep . && { echo "$(ME): the above test(s)"\
518 " should use cleanup_ for background processes" 1>&2; exit 1; } || :
520 # Ensure that tests call the print_ver_ function for programs which are
521 # actually used in that test.
522 sc_prohibit_test_calls_print_ver_with_irrelevant_argument:
523 @git grep -w print_ver_ $(srcdir)/tests \
524 | sed 's#:print_ver_##' \
525 | { fail=0; \
526 while read file name; do \
527 for i in $$name; do \
528 case "$$i" in install) i=ginstall;; esac; \
529 grep -w "$$i" $$file|grep -vw print_ver_|grep -q . \
530 || { fail=1; \
531 echo "*** Test: $$file, offending: $$i." 1>&2; };\
532 done; \
533 done; \
534 test $$fail = 0 || exit 1; \
535 } || { echo "$(ME): the above test(s) call print_ver_ for" \
536 "program(s) they don't use" 1>&2; exit 1; }
538 # Exempt the contents of any usage function from the following.
539 _continued_string_col_1 = \
540 s/^usage .*?\n}//ms;/\\\n\w/ and print ("$$ARGV\n"),$$e=1;END{$$e||=0;exit $$e}
541 # Ding any source file that has a continued string with an alphabetic in the
542 # first column of the following line. We prohibit them because they usually
543 # trigger false positives in tools that try to map an arbitrary line number
544 # to the enclosing function name. Of course, very many strings do precisely
545 # this, *when they are part of the usage function*. That is why we exempt
546 # the contents of any function named "usage".
547 sc_prohibit_continued_string_alpha_in_column_1:
548 @perl -0777 -ne '$(_continued_string_col_1)' \
549 $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$') \
550 || { echo '$(ME): continued string with word in first column' \
551 1>&2; exit 1; } || :
552 # Use this to list offending lines:
553 # git ls-files |grep '\.[ch]$' | xargs \
554 # perl -n -0777 -e 's/^usage.*?\n}//ms;/\\\n\w/ and print "$ARGV\n"' \
555 # | xargs grep -A1 '\\$'|grep '\.[ch][:-][_a-zA-Z]'
558 ###########################################################
559 _p0 = \([^"'/]\|"\([^\"]\|[\].\)*"\|'\([^\']\|[\].\)*'
560 _pre = $(_p0)\|[/][^"'/*]\|[/]"\([^\"]\|[\].\)*"\|[/]'\([^\']\|[\].\)*'\)*
561 _pre_anchored = ^\($(_pre)\)
562 _comment_and_close = [^*]\|[*][^/*]\)*[*][*]*/
563 # help font-lock mode: '
565 # A sed expression that removes ANSI C and ISO C99 comments.
566 # Derived from the one in GNU gettext's 'moopp' preprocessor.
567 _sed_remove_comments = \
568 /[/][/*]/{ \
569 ta; \
570 :a; \
571 s,$(_pre_anchored)//.*,\1,; \
572 te; \
573 s,$(_pre_anchored)/[*]\($(_comment_and_close),\1 ,; \
574 ta; \
575 /^$(_pre)[/][*]/{ \
576 s,$(_pre_anchored)/[*].*,\1 ,; \
577 tu; \
578 :u; \
579 n; \
580 s,^\($(_comment_and_close),,; \
581 tv; \
582 s,^.*$$,,; \
583 bu; \
584 :v; \
585 }; \
586 :e; \
588 # Quote all single quotes.
589 _sed_rm_comments_q = $(subst ','\'',$(_sed_remove_comments))
590 # help font-lock mode: '
592 _space_before_paren_exempt =? \\n\\$$
593 _space_before_paren_exempt = \
594 (^ *\#|\\n\\$$|%s\(to %s|(date|group|character)\(s\))
595 # Ensure that there is a space before each open parenthesis in C code.
596 sc_space_before_open_paren:
597 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
598 fail=0; \
599 for c in $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); do \
600 sed '$(_sed_rm_comments_q)' $$c 2>/dev/null \
601 | grep -i '[[:alnum:]](' \
602 | grep -vE '$(_space_before_paren_exempt)' \
603 | grep . && { fail=1; echo "*** $$c"; }; \
604 done; \
605 test $$fail = 1 && \
606 { echo '$(ME): the above files lack a space-before-open-paren' \
607 1>&2; exit 1; } || :; \
608 else :; \
611 # Similar to the gnulib maint.mk rule for sc_prohibit_strcmp
612 # Use STREQ_LEN or STRPREFIX rather than comparing strncmp == 0, or != 0.
613 sc_prohibit_strncmp:
614 @prohibit='^[^#].*str''ncmp *\(' \
615 halt='use STREQ_LEN or STRPREFIX instead of str''ncmp' \
616 $(_sc_search_regexp)
618 # Enforce recommended preprocessor indentation style.
619 sc_preprocessor_indentation:
620 @if cppi --version >/dev/null 2>&1; then \
621 $(VC_LIST_EXCEPT) | grep '\.[ch]$$' | xargs cppi -a -c \
622 || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
623 exit 1; }; \
624 else \
625 echo '$(ME): skipping test $@: cppi not installed' 1>&2; \
628 # THANKS.in is a list of name/email pairs for people who are mentioned in
629 # commit logs (and generated ChangeLog), but who are not also listed as an
630 # author of a commit. Name/email pairs of commit authors are automatically
631 # extracted from the repository. As a very minor factorization, when
632 # someone who was initially listed only in THANKS.in later authors a commit,
633 # this rule detects that their pair may now be removed from THANKS.in.
634 sc_THANKS_in_duplicates:
635 @{ git log --pretty=format:%aN | sort -u; \
636 cut -b-36 $(srcdir)/THANKS.in \
637 | sed '/^$$/,/^$$/!d;/^$$/d;s/ *$$//'; } \
638 | sort | uniq -d | grep . \
639 && { echo '$(ME): remove the above names from THANKS.in' \
640 1>&2; exit 1; } || :
642 # Ensure the contributor list stays sorted. Use our sort as other
643 # implementations may result in a different order.
644 sc_THANKS_in_sorted: src/sort
645 @sed '/^$$/,/^$$/!d;/^$$/d' $(srcdir)/THANKS.in > $@.1; \
646 LC_ALL=en_US.UTF-8 src/sort -f -k1,1 $@.1 > $@.2
647 @diff -u $@.1 $@.2; diff=$$?; \
648 rm -f $@.1 $@.2; \
649 test "$$diff" = 0 \
650 || { echo '$(ME): THANKS.in is unsorted' 1>&2; exit 1; }
652 # Look for developer diagnostics that are marked for translation.
653 # This won't find any for which devmsg's format string is on a separate line.
654 sc_marked_devdiagnostics:
655 @prohibit='\<devmsg *\(.*_\(' \
656 halt='found marked developer diagnostic(s)' \
657 $(_sc_search_regexp)
659 # Ensure we keep hex constants as 4 or 8 bytes for consistency
660 # and so that make src/fs-magic-compare works consistently
661 sc_fs-magic-compare:
662 @sed -n 's|.*/\* \(0x[0-9A-Fa-f]\{1,\}\) .*\*/|\1|p' \
663 $(srcdir)/src/stat.c | grep -Ev '^0x([0-9A-F]{4}){1,2}$$' \
664 && { echo '$(ME): Constants in src/stat.c should be 4 or 8' \
665 'upper-case chars' 1>&2; exit 1; } || :
667 # Ensure gnulib generated files are ignored
668 # TODO: Perhaps augment gnulib-tool to do this in lib/.gitignore?
669 sc_gitignore_missing:
670 @{ sed -n '/^\/lib\/.*\.h$$/{p;p}' .gitignore; \
671 find lib -name '*.in*' ! -name '*~' ! -name 'sys_*' | \
672 sed 's|^|/|; s|_\(.*in\.h\)|/\1|; s/\.in//'; } | \
673 sort | uniq -u | grep . && { echo '$(ME): Add above' \
674 'entries to .gitignore' >&2; exit 1; } || :
676 # Flag redundant entries in .gitignore
677 sc_gitignore_redundant:
678 @{ grep ^/lib .gitignore; sed 's|^|/lib|' lib/.gitignore; } | \
679 sort | uniq -d | grep . && { echo '$(ME): Remove above' \
680 'entries from .gitignore' >&2; exit 1; } || :
682 # Override the default Cc: used in generating an announcement.
683 announcement_Cc_ = $(translation_project_), \
684 coreutils@gnu.org, coreutils-announce@gnu.org
686 -include $(srcdir)/dist-check.mk
688 update-copyright-env = \
689 UPDATE_COPYRIGHT_FORCE=1 \
690 UPDATE_COPYRIGHT_USE_INTERVALS=2 \
691 UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79
693 # List syntax-check exemptions.
694 exclude_file_name_regexp--sc_space_tab = \
695 ^(tests/pr/|tests/misc/nl\.sh$$|gl/.*\.diff$$|man/help2man$$)
696 exclude_file_name_regexp--sc_bindtextdomain = \
697 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list)\.c$$
698 exclude_file_name_regexp--sc_trailing_blank = \
699 ^(tests/pr/|gl/.*\.diff$$|man/help2man)
700 exclude_file_name_regexp--sc_system_h_headers = \
701 ^src/((system|copy)\.h|make-prime-list\.c)$$
703 _src = (false|lbracket|ls-(dir|ls|vdir)|tac-pipe|uname-(arch|uname))
704 exclude_file_name_regexp--sc_require_config_h_first = \
705 (^lib/buffer-lcm\.c|gl/lib/xdecto.max\.c|src/$(_src)\.c)$$
706 exclude_file_name_regexp--sc_require_config_h = \
707 $(exclude_file_name_regexp--sc_require_config_h_first)
709 exclude_file_name_regexp--sc_po_check = ^(gl/|man/help2man)
710 exclude_file_name_regexp--sc_prohibit_always-defined_macros = \
711 ^src/(seq|remove)\.c$$
712 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^tests/pr/
713 exclude_file_name_regexp--sc_program_name = \
714 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list)\.c$$
715 exclude_file_name_regexp--sc_file_system = \
716 NEWS|^(init\.cfg|src/df\.c|tests/df/df-P\.sh|tests/df/df-output\.sh)$$
717 exclude_file_name_regexp--sc_prohibit_always_true_header_tests = \
718 ^m4/stat-prog\.m4$$
719 exclude_file_name_regexp--sc_prohibit_fail_0 = \
720 (^.*/git-hooks/commit-msg|^tests/init\.sh|Makefile\.am|\.mk|.*\.texi)$$
721 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^lib/euidaccess-stat\.c$$
723 # longlong.h is maintained elsewhere.
724 _ll = ^src/longlong\.h$$
725 exclude_file_name_regexp--sc_useless_cpp_parens = $(_ll)
726 exclude_file_name_regexp--sc_space_before_open_paren = $(_ll)
728 tbi_1 = ^tests/pr/|(^gl/lib/reg.*\.c\.diff|\.mk|^man/help2man)$$
729 tbi_2 = ^scripts/git-hooks/(pre-commit|pre-applypatch|applypatch-msg)$$
730 tbi_3 = (GNU)?[Mm]akefile(\.am)?$$|$(_ll)
731 exclude_file_name_regexp--sc_prohibit_tab_based_indentation = \
732 $(tbi_1)|$(tbi_2)|$(tbi_3)
734 exclude_file_name_regexp--sc_preprocessor_indentation = \
735 ^(gl/lib/rand-isaac\.[ch]|gl/tests/test-rand-isaac\.c)$$|$(_ll)
736 exclude_file_name_regexp--sc_prohibit_stat_st_blocks = \
737 ^(src/system\.h|tests/du/2g\.sh)$$
739 exclude_file_name_regexp--sc_prohibit_continued_string_alpha_in_column_1 = \
740 ^src/(system\.h|od\.c|printf\.c|getlimits\.c)$$
742 exclude_file_name_regexp--sc_prohibit_test_backticks = \
743 ^tests/(local\.mk|(init|misc/stdbuf|factor/create-test)\.sh)$$
745 # Exempt test.c, since it's nominally shared, and relatively static.
746 exclude_file_name_regexp--sc_prohibit_operator_at_end_of_line = \
747 ^src/(ptx|test|head)\.c$$
749 exclude_file_name_regexp--sc_error_message_uppercase = ^src/factor\.c$$
750 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^src/make-prime-list\.c$$
752 # Exception here as we don't want __attribute elided on non GCC
753 exclude_file_name_regexp--sc_prohibit-gl-attributes = ^src/libstdbuf\.c$$
755 exclude_file_name_regexp--sc_prohibit_uppercase_id_est = \.diff$$
756 exclude_file_name_regexp--sc_ensure_dblspace_after_dot_before_id_est = \.diff$$
757 exclude_file_name_regexp--sc_ensure_comma_after_id_est = \.diff|$(_ll)$$
758 exclude_file_name_regexp--sc_long_lines = \.diff$$|$(_ll)
760 # Augment AM_CFLAGS to include our per-directory options:
761 AM_CFLAGS += $($(@D)_CFLAGS)
763 src_CFLAGS = $(WARN_CFLAGS)
764 lib_CFLAGS = $(GNULIB_WARN_CFLAGS)
765 gnulib-tests_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS)
767 # Configuration to make the tight-scope syntax-check rule work with
768 # non-recursive make.
769 export _gl_TS_headers = $(srcdir)/cfg.mk
770 _gl_TS_dir = .
771 _gl_TS_obj_files = src/*.$(OBJEXT)
772 _gl_TS_other_headers = $(srcdir)/src/*.h src/*.h
774 # Tell the tight_scope rule about an exceptional "extern" variable.
775 # Normally, the rule would detect its declaration, but that uses a
776 # different name, __clz_tab.
777 _gl_TS_unmarked_extern_vars = factor_clz_tab