ls: fix possible incorrect exit status when recursing directories
[coreutils.git] / cfg.mk
bloba4f36ff5ff03f779ad30026a05168fffa0685d0c
1 # Customize maint.mk -*- makefile -*-
2 # Copyright (C) 2003-2013 Free Software Foundation, Inc.
4 # This program is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License as published by
6 # the Free Software Foundation, either version 3 of the License, or
7 # (at your option) any later version.
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
14 # You should have received a copy of the GNU General Public License
15 # along with this program. If not, see <http://www.gnu.org/licenses/>.
17 # Used in maint.mk's web-manual rule
18 manual_title = Core GNU utilities
20 # Use the direct link. This is guaranteed to work immediately, while
21 # it can take a while for the faster mirror links to become usable.
22 url_dir_list = http://ftp.gnu.org/gnu/$(PACKAGE)
24 # Tests not to run as part of "make distcheck".
25 local-checks-to-skip = \
26 sc_proper_name_utf8_requires_ICONV
28 # Tools used to bootstrap this package, used for "announcement".
29 bootstrap-tools = autoconf,automake,gnulib,bison
31 # Now that we have better tests, make this the default.
32 export VERBOSE = yes
34 # Comparing tarball sizes compressed using different xz presets, we see that
35 # an -8e-compressed tarball is only 9KiB larger than the -9e-compressed one.
36 # Using -8e is preferred, since that lets the decompression process use half
37 # the memory (32MiB rather than 64MiB).
38 # $ for i in {7,8,9}{e,}; do \
39 # (n=$(xz -$i < coreutils-8.15*.tar|wc -c);echo $n $i) & done |sort -nr
40 # 5129388 7
41 # 5036524 7e
42 # 5017476 8
43 # 5010604 9
44 # 4923016 8e
45 # 4914152 9e
46 export XZ_OPT = -8e
48 old_NEWS_hash = 6ae04dc3907ea1290f12e6b1507cc42c
50 # Add an exemption for sc_makefile_at_at_check.
51 _makefile_at_at_check_exceptions = ' && !/^cu_install_program =/'
53 # Our help-version script is in a slightly different location.
54 _hv_file ?= $(srcdir)/tests/misc/help-version
56 # Ensure that the list of O_ symbols used to compute O_FULLBLOCK is complete.
57 dd = $(srcdir)/src/dd.c
58 sc_dd_O_FLAGS:
59 @rm -f $@.1 $@.2
60 @{ echo O_FULLBLOCK; echo O_NOCACHE; \
61 perl -nle '/^ +\| (O_\w*)$$/ and print $$1' $(dd); } | sort > $@.1
62 @{ echo O_NOFOLLOW; perl -nle '/{"[a-z]+",\s*(O_\w+)},/ and print $$1' \
63 $(dd); } | sort > $@.2
64 @diff -u $@.1 $@.2 || diff=1 || diff=; \
65 rm -f $@.1 $@.2; \
66 test "$$diff" \
67 && { echo '$(ME): $(dd) has inconsistent O_ flag lists'>&2; \
68 exit 1; } || :
70 # Ensure that dd's definition of LONGEST_SYMBOL stays in sync
71 # with the strings from the two affected variables.
72 dd_c = $(srcdir)/src/dd.c
73 sc_dd_max_sym_length:
74 ifneq ($(wildcard $(dd_c)),)
75 @len=$$( (sed -n '/conversions\[\] =$$/,/^};/p' $(dd_c);\
76 sed -n '/flags\[\] =$$/,/^};/p' $(dd_c) ) \
77 |sed -n '/"/s/^[^"]*"\([^"]*\)".*/\1/p' \
78 | wc --max-line-length); \
79 max=$$(sed -n '/^#define LONGEST_SYMBOL /s///p' $(dd_c) \
80 |tr -d '"' | wc --max-line-length); \
81 if test "$$len" = "$$max"; then :; else \
82 echo 'dd.c: LONGEST_SYMBOL is not longest' 1>&2; \
83 exit 1; \
85 endif
87 # Many m4 macros names once began with 'jm_'.
88 # On 2004-04-13, they were all changed to start with gl_ instead.
89 # Make sure that none are inadvertently reintroduced.
90 sc_prohibit_jm_in_m4:
91 @grep -nE 'jm_[A-Z]' \
92 $$($(VC_LIST) m4 |grep '\.m4$$'; echo /dev/null) && \
93 { echo '$(ME): do not use jm_ in m4 macro names' \
94 1>&2; exit 1; } || :
96 # Ensure that each root-requiring test is run via the "check-root" rule.
97 sc_root_tests:
98 @t1=sc-root.expected; t2=sc-root.actual; \
99 grep -nl '^ *require_root_$$' `$(VC_LIST) tests` | sort > $$t1; \
100 for t in $(all_root_tests); do echo $$t; done | sort > $$t2; \
101 st=0; diff -u $$t1 $$t2 || st=1; \
102 rm -f $$t1 $$t2; \
103 exit $$st
105 # Ensure that all version-controlled test cases are listed in $(all_tests).
106 sc_tests_list_consistency:
107 @bs="\\"; \
108 test_extensions_rx=`echo $(TEST_EXTENSIONS) \
109 | sed -e "s/ /|/g" -e "s/$$bs./$$bs$$bs./g"`; \
111 for t in $(all_tests); do echo $$t; done; \
112 cd $(top_srcdir); \
113 $(SHELL) build-aux/vc-list-files tests \
114 | grep -Ev '^tests/(factor/(run|create-test)|init)\.sh$$' \
115 | $(EGREP) "$$test_extensions_rx\$$"; \
116 } | sort | uniq -u | grep . && exit 1; :
118 # Ensure that all version-controlled test scripts are executable.
119 sc_tests_executable:
120 @test_extensions_rx=`echo $(TEST_EXTENSIONS) \
121 | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
122 find tests/ \( $$test_extensions_rx \) \! -perm -111 -print \
123 | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
124 && exit 1; :
126 # Create a list of regular expressions matching the names
127 # of files included from system.h. Exclude a couple.
128 .re-list:
129 @sed -n '/^# *include /s///p' $(srcdir)/src/system.h \
130 | grep -Ev 'sys/(param|file)\.h' \
131 | sed 's/ .*//;;s/^["<]/^# *include [<"]/;s/\.h[">]$$/\\.h[">]/' \
132 > $@-t
133 @mv $@-t $@
135 define gl_trap_
136 Exit () { set +e; (exit $$1); exit $$1; }; \
137 for sig in 1 2 3 13 15; do \
138 eval "trap 'Exit $$(expr $$sig + 128)' $$sig"; \
139 done
140 endef
142 # Files in src/ should not include directly any of
143 # the headers already included via system.h.
144 sc_system_h_headers: .re-list
145 @if test -f $(srcdir)/src/system.h; then \
146 trap 'rc=$$?; rm -f .re-list; exit $$rc' 0; \
147 $(gl_trap_); \
148 grep -nE -f .re-list \
149 $$($(VC_LIST_EXCEPT) | grep '^\($(srcdir)/\)\?src/') \
150 && { echo '$(ME): the above are already included via system.h'\
151 1>&2; exit 1; } || :; \
154 sc_sun_os_names:
155 @grep -nEi \
156 'solaris[^[:alnum:]]*2\.(7|8|9|[1-9][0-9])|sunos[^[:alnum:]][6-9]' \
157 $$($(VC_LIST_EXCEPT)) && \
158 { echo '$(ME): found misuse of Sun OS version numbers' 1>&2; \
159 exit 1; } || :
161 # Ensure that the list of programs and author names is accurate.
162 # We need a UTF8 locale. If a lack of locale support or a missing
163 # translation inhibits printing of UTF-8 names, just skip this test.
164 au_dotdot = authors-dotdot
165 au_actual = authors-actual
166 sc_check-AUTHORS: $(all_programs)
167 @locale=en_US.UTF-8; \
168 LC_ALL=$$locale ./src/cat --version \
169 | grep ' Torbjorn ' > /dev/null \
170 && { echo "$@: skipping this check"; exit 0; }; \
171 rm -f $(au_actual) $(au_dotdot); \
172 for i in `ls $(all_programs) \
173 | sed -e 's,^src/,,' -e 's,$(EXEEXT)$$,,' \
174 | sed /libstdbuf/d \
175 | $(ASSORT) -u`; do \
176 test "$$i" = '[' && continue; \
177 exe=$$i; \
178 if test "$$i" = install; then \
179 exe=ginstall; \
180 elif test "$$i" = test; then \
181 exe='['; \
182 fi; \
183 LC_ALL=$$locale ./src/$$exe --version \
184 | perl -0 -pi -e 's/,\n/, /gm' \
185 | sed -n -e '/Written by /{ s//'"$$i"': /;' \
186 -e 's/,* and /, /; s/\.$$//; p; }'; \
187 done > $(au_actual) && \
188 sed -n '/^[^ ][^ ]*:/p' $(srcdir)/AUTHORS > $(au_dotdot) \
189 && diff $(au_actual) $(au_dotdot) \
190 && rm -f $(au_actual) $(au_dotdot)
192 # Each program with a non-ASCII author name must link with LIBICONV.
193 sc_check-I18N-AUTHORS:
194 @cd $(srcdir)/src && \
195 for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
196 grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
197 > /dev/null \
198 || { echo "$(ME): link rules for $$i do not include" \
199 '$$(LIBICONV)' 1>&2; exit 1; }; \
200 done
202 # Ensure %j is not used for intmax_t as it's not universally supported.
203 # There are issues on HPUX for example. But note that %ju was used between
204 # coreutils 8.13 (2011-10) and 8.20 (2012-10) without any reported issue,
205 # and the particular issue this check is associated with was for %*jx.
206 # So we may be able to relax this restriction soon.
207 sc_prohibit-j-printf-format:
208 @cd $(srcdir)/src && GIT_PAGER= git grep -n '%[0*]*j[udx]' *.c \
209 && { echo '$(ME): Use PRI*MAX instead of %j' 1>&2; exit 1; } \
210 || :
212 # Ensure the alternative __attribute (keyword) form isn't used as
213 # that form is not elided where required. Also ensure that we don't
214 # directly use attributes already defined by gnulib.
215 # TODO: move the check for _GL... attributes to gnulib.
216 sc_prohibit-gl-attributes:
217 @cd $(srcdir) && GIT_PAGER= git grep -En \
218 "__attribute |__(unused|pure|const)__" src gl/lib/*.[ch] \
219 && { echo '$(ME): Use _GL... attribute macros' 1>&2; exit 1; } \
220 || :
222 # Look for lines longer than 80 characters, except omit:
223 # - program-generated long lines in diff headers,
224 # - tests involving long checksum lines, and
225 # - the 'pr' test cases.
226 LINE_LEN_MAX = 80
227 FILTER_LONG_LINES = \
228 /^[^:]*\.diff:[^:]*:@@ / d; \
229 \|^[^:]*tests/misc/sha[0-9]*sum.*\.pl[-:]| d; \
230 \|^[^:]*tests/pr/|{ \|^[^:]*tests/pr/pr-tests:| !d; };
231 sc_long_lines:
232 @files=$$($(VC_LIST_EXCEPT)) \
233 halt='line(s) with more than $(LINE_LEN_MAX) characters; reindent'; \
234 for file in $$files; do \
235 expand $$file | grep -nE '^.{$(LINE_LEN_MAX)}.' | \
236 sed -e "s|^|$$file:|" -e '$(FILTER_LONG_LINES)'; \
237 done | grep . && { msg="$$halt" $(_sc_say_and_exit) } || :
239 # Option descriptions should not start with a capital letter.
240 # One could grep source directly as follows:
241 # grep -E " {2,6}-.*[^.] [A-Z][a-z]" $$($(VC_LIST_EXCEPT) | grep '\.c$$')
242 # but that would miss descriptions not on the same line as the -option.
243 sc_option_desc_uppercase: $(ALL_MANS)
244 @grep '^\\fB\\-' -A1 man/*.1 | LC_ALL=C grep '\.1.[A-Z][a-z]' \
245 && { echo 1>&2 '$@: found initial capitals in --help'; exit 1; } || :
247 # Ensure all man/*.[1x] files are present.
248 sc_man_file_correlation: check-x-vs-1 check-programs-vs-x
250 # Ensure that for each .x file in the 'man/' subdirectory, there is a
251 # corresponding .1 file in the definition of $(EXTRA_MANS).
252 # But since that expansion usually lacks programs like arch and hostname,
253 # add them here manually.
254 .PHONY: check-x-vs-1
255 check-x-vs-1:
256 @PATH=./src$(PATH_SEPARATOR)$$PATH; export PATH; \
257 t=$@-t; \
258 (cd $(srcdir)/man && ls -1 *.x) \
259 | sed 's/\.x$$//' | $(ASSORT) > $$t; \
260 (echo $(patsubst man/%,%,$(ALL_MANS)) \
261 | tr -s ' ' '\n' | sed 's/\.1$$//') \
262 | $(ASSORT) -u | diff - $$t || { rm $$t; exit 1; }; \
263 rm $$t
265 # Writing a portable rule to generate a manpage like '[.1' would be
266 # a nightmare, so filter that out.
267 all-progs-but-lbracket = $(filter-out [,$(patsubst src/%,%,$(all_programs)))
269 # Ensure that for each coreutils program there is a corresponding
270 # '.x' file in the 'man/' subdirectory.
271 .PHONY: check-programs-vs-x
272 check-programs-vs-x:
273 @status=0; \
274 for p in dummy $(all-progs-but-lbracket); do \
275 case $$p in *.so) continue;; esac; \
276 test $$p = dummy && continue; \
277 test $$p = ginstall && p=install || : ; \
278 test -f $(srcdir)/man/$$p.x \
279 || { echo missing $$p.x 1>&2; status=1; }; \
280 done; \
281 exit $$status
283 # Ensure that the end of each release's section is marked by two empty lines.
284 sc_NEWS_two_empty_lines:
285 @sed -n 4,/Noteworthy/p $(srcdir)/NEWS \
286 | perl -n0e '/(^|\n)\n\n\* Noteworthy/ or exit 1' \
287 || { echo '$(ME): use two empty lines to separate NEWS sections' \
288 1>&2; exit 1; } || :
290 # With split lines, don't leave an operator at end of line.
291 # Instead, put it on the following line, where it is more apparent.
292 # Don't bother checking for "*" at end of line, since it provokes
293 # far too many false positives, matching constructs like "TYPE *".
294 # Similarly, omit "=" (initializers).
295 binop_re_ ?= [-/+^!<>]|[-/+*^!<>=]=|&&?|\|\|?|<<=?|>>=?
296 sc_prohibit_operator_at_end_of_line:
297 @prohibit='. ($(binop_re_))$$' \
298 in_vc_files='\.[chly]$$' \
299 halt='found operator at end of line' \
300 $(_sc_search_regexp)
302 # Don't use "readlink" or "readlinkat" directly
303 sc_prohibit_readlink:
304 @prohibit='\<readlink(at)? \(' \
305 halt='do not use readlink(at); use via xreadlink or areadlink*' \
306 $(_sc_search_regexp)
308 # Don't use address of "stat" or "lstat" functions
309 sc_prohibit_stat_macro_address:
310 @prohibit='\<l?stat '':|&l?stat\>' \
311 halt='stat() and lstat() may be function-like macros' \
312 $(_sc_search_regexp)
314 # Ensure that date's --help output stays in sync with the info
315 # documentation for GNU strftime. The only exception is %N,
316 # which date accepts but GNU strftime does not.
317 extract_char = sed 's/^[^%][^%]*%\(.\).*/\1/'
318 sc_strftime_check:
319 @if test -f $(srcdir)/src/date.c; then \
320 grep '^ %. ' $(srcdir)/src/date.c | sort \
321 | $(extract_char) > $@-src; \
322 { echo N; \
323 info libc date calendar format 2>/dev/null|grep '^ `%.'\'\
324 | $(extract_char); } | sort > $@-info; \
325 if test $$(stat --format %s $@-info) != 2; then \
326 diff -u $@-src $@-info || exit 1; \
327 else \
328 echo '$(ME): skipping $@: libc info not installed' 1>&2; \
329 fi; \
330 rm -f $@-src $@-info; \
333 # Indent only with spaces.
334 sc_prohibit_tab_based_indentation:
335 @prohibit='^ * ' \
336 halt='TAB in indentation; use only spaces' \
337 $(_sc_search_regexp)
339 # The SEE ALSO section of a man page should not be terminated with
340 # a period. Check the first line after each "SEE ALSO" line in man/*.x:
341 sc_prohibit_man_see_also_period:
342 @grep -nB1 '\.$$' $$($(VC_LIST_EXCEPT) | grep 'man/.*\.x$$') \
343 | grep -A1 -e '-\[SEE ALSO\]' | grep '\.$$' && \
344 { echo '$(ME): do not end "SEE ALSO" section with a period' \
345 1>&2; exit 1; } || :
347 # Don't use "indent-tabs-mode: nil" anymore. No longer needed.
348 sc_prohibit_emacs__indent_tabs_mode__setting:
349 @prohibit='^( *[*#] *)?indent-tabs-mode:' \
350 halt='use of emacs indent-tabs-mode: setting' \
351 $(_sc_search_regexp)
353 # Ensure that tests don't include a redundant fail=0.
354 sc_prohibit_fail_0:
355 @prohibit='\<fail=0\>' \
356 halt='fail=0 initialization' \
357 $(_sc_search_regexp)
359 # The mode part of a setfacl -m option argument must be three bytes long.
360 # I.e., an argument of user:bin:rw or user:bin:r will make Solaris 10's
361 # setfacl reject it with: "Unrecognized character found in mode field".
362 # Use hyphens to give it a length of 3: "...:rw-" or "...:r--".
363 sc_prohibit_short_facl_mode_spec:
364 @prohibit='\<setfacl .*-m.*:.*:[rwx-]{1,2} ' \
365 halt='setfacl mode string length < 3; extend with hyphen(s)' \
366 $(_sc_search_regexp)
368 # Ensure that "stdio--.h" is used where appropriate.
369 sc_require_stdio_safer:
370 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
371 files=$$(grep -l '\bfreopen \?(' $$($(VC_LIST_EXCEPT) \
372 | grep '\.[ch]$$')); \
373 test -n "$$files" && grep -LE 'include "stdio--.h"' $$files \
374 | grep . && \
375 { echo '$(ME): the above files should use "stdio--.h"' \
376 1>&2; exit 1; } || :; \
377 else :; \
380 sc_prohibit_perl_hash_quotes:
381 @prohibit="\{'[A-Z_]+' *[=}]" \
382 halt="in Perl code, write \$$hash{KEY}, not \$$hash{'K''EY'}" \
383 $(_sc_search_regexp)
385 # Prefer xnanosleep over other less-precise sleep methods
386 sc_prohibit_sleep:
387 @prohibit='\<(nano|u)?sleep \(' \
388 halt='prefer xnanosleep over other sleep interfaces' \
389 $(_sc_search_regexp)
391 # Use print_ver_ (from init.cfg), not open-coded $VERBOSE check.
392 sc_prohibit_verbose_version:
393 @prohibit='test "\$$VERBOSE" = yes && .* --version' \
394 halt='use the print_ver_ function instead...' \
395 $(_sc_search_regexp)
397 # Use framework_failure_, not the old name without the trailing underscore.
398 sc_prohibit_framework_failure:
399 @prohibit='\<framework_''failure\>' \
400 halt='use framework_failure_ instead' \
401 $(_sc_search_regexp)
403 # Prohibit the use of `...` in tests/. Use $(...) instead.
404 sc_prohibit_test_backticks:
405 @prohibit='`' in_vc_files='^tests/' \
406 halt='use $$(...), not `...` in tests/' \
407 $(_sc_search_regexp)
409 # Programs like sort, ls, expr use PROG_FAILURE in place of EXIT_FAILURE.
410 # Others, use the EXIT_CANCELED, EXIT_ENOENT, etc. macros defined in system.h.
411 # In those programs, ensure that EXIT_FAILURE is not used by mistake.
412 sc_some_programs_must_avoid_exit_failure:
413 @grep -nw EXIT_FAILURE \
414 $$(git grep -El '[^T]_FAILURE|EXIT_CANCELED' src) \
415 | grep -vE '= EXIT_FAILURE|exit \(.* \?' | grep . \
416 && { echo '$(ME): do not use EXIT_FAILURE in the above' \
417 1>&2; exit 1; } || :
419 # Ensure that tests call the require_ulimit_v_ function if using ulimit -v
420 sc_prohibit_test_ulimit_without_require_:
421 @(git grep -l require_ulimit_v_ tests; \
422 git grep -l 'ulimit -v' tests) \
423 | sort | uniq -u | grep . && { echo "$(ME): the above test(s)"\
424 " should match require_ulimit_v_ with ulimit -v" 1>&2; exit 1; } || :
426 # Ensure that tests call the print_ver_ function for programs which are
427 # actually used in that test.
428 sc_prohibit_test_calls_print_ver_with_irrelevant_argument:
429 @git grep -w print_ver_ tests \
430 | sed 's#:print_ver_##' \
431 | { fail=0; \
432 while read file name; do \
433 for i in $$name; do \
434 case "$$i" in install) i=ginstall;; esac; \
435 grep -w "$$i" $$file|grep -vw print_ver_|grep -q . \
436 || { fail=1; \
437 echo "*** Test: $$file, offending: $$i." 1>&2; };\
438 done; \
439 done; \
440 test $$fail = 0 || exit 1; \
441 } || { echo "$(ME): the above test(s) call print_ver_ for" \
442 "program(s) they don't use" 1>&2; exit 1; }
444 # Exempt the contents of any usage function from the following.
445 _continued_string_col_1 = \
446 s/^usage .*?\n}//ms;/\\\n\w/ and print ("$$ARGV\n"),$$e=1;END{$$e||=0;exit $$e}
447 # Ding any source file that has a continued string with an alphabetic in the
448 # first column of the following line. We prohibit them because they usually
449 # trigger false positives in tools that try to map an arbitrary line number
450 # to the enclosing function name. Of course, very many strings do precisely
451 # this, *when they are part of the usage function*. That is why we exempt
452 # the contents of any function named "usage".
453 sc_prohibit_continued_string_alpha_in_column_1:
454 @perl -0777 -ne '$(_continued_string_col_1)' \
455 $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$') \
456 || { echo '$(ME): continued string with word in first column' \
457 1>&2; exit 1; } || :
458 # Use this to list offending lines:
459 # git ls-files |grep '\.[ch]$' | xargs \
460 # perl -n -0777 -e 's/^usage.*?\n}//ms;/\\\n\w/ and print "$ARGV\n"' \
461 # | xargs grep -A1 '\\$'|grep '\.[ch][:-][_a-zA-Z]'
464 ###########################################################
465 _p0 = \([^"'/]\|"\([^\"]\|[\].\)*"\|'\([^\']\|[\].\)*'
466 _pre = $(_p0)\|[/][^"'/*]\|[/]"\([^\"]\|[\].\)*"\|[/]'\([^\']\|[\].\)*'\)*
467 _pre_anchored = ^\($(_pre)\)
468 _comment_and_close = [^*]\|[*][^/*]\)*[*][*]*/
469 # help font-lock mode: '
471 # A sed expression that removes ANSI C and ISO C99 comments.
472 # Derived from the one in GNU gettext's 'moopp' preprocessor.
473 _sed_remove_comments = \
474 /[/][/*]/{ \
475 ta; \
476 :a; \
477 s,$(_pre_anchored)//.*,\1,; \
478 te; \
479 s,$(_pre_anchored)/[*]\($(_comment_and_close),\1 ,; \
480 ta; \
481 /^$(_pre)[/][*]/{ \
482 s,$(_pre_anchored)/[*].*,\1 ,; \
483 tu; \
484 :u; \
485 n; \
486 s,^\($(_comment_and_close),,; \
487 tv; \
488 s,^.*$$,,; \
489 bu; \
490 :v; \
491 }; \
492 :e; \
494 # Quote all single quotes.
495 _sed_rm_comments_q = $(subst ','\'',$(_sed_remove_comments))
496 # help font-lock mode: '
498 _space_before_paren_exempt =? \\n\\$$
499 _space_before_paren_exempt = \
500 (^ *\#|\\n\\$$|%s\(to %s|(date|group|character)\(s\))
501 # Ensure that there is a space before each open parenthesis in C code.
502 sc_space_before_open_paren:
503 @if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then \
504 fail=0; \
505 for c in $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); do \
506 sed '$(_sed_rm_comments_q)' $$c 2>/dev/null \
507 | grep -i '[[:alnum:]](' \
508 | grep -vE '$(_space_before_paren_exempt)' \
509 | grep . && { fail=1; echo "*** $$c"; }; \
510 done; \
511 test $$fail = 1 && \
512 { echo '$(ME): the above files lack a space-before-open-paren' \
513 1>&2; exit 1; } || :; \
514 else :; \
517 # Similar to the gnulib maint.mk rule for sc_prohibit_strcmp
518 # Use STREQ_LEN or STRPREFIX rather than comparing strncmp == 0, or != 0.
519 sc_prohibit_strncmp:
520 @grep -nE '! *str''ncmp *\(|\<str''ncmp *\(.+\) *[!=]=' \
521 $$($(VC_LIST_EXCEPT)) \
522 | grep -vE ':# *define STR(N?EQ_LEN|PREFIX)\(' && \
523 { echo '$(ME): use STREQ_LEN or STRPREFIX instead of str''ncmp' \
524 1>&2; exit 1; } || :
526 # Enforce recommended preprocessor indentation style.
527 sc_preprocessor_indentation:
528 @if cppi --version >/dev/null 2>&1; then \
529 $(VC_LIST_EXCEPT) | grep '\.[ch]$$' | xargs cppi -a -c \
530 || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
531 exit 1; }; \
532 else \
533 echo '$(ME): skipping test $@: cppi not installed' 1>&2; \
536 # THANKS.in is a list of name/email pairs for people who are mentioned in
537 # commit logs (and generated ChangeLog), but who are not also listed as an
538 # author of a commit. Name/email pairs of commit authors are automatically
539 # extracted from the repository. As a very minor factorization, when
540 # someone who was initially listed only in THANKS.in later authors a commit,
541 # this rule detects that their pair may now be removed from THANKS.in.
542 sc_THANKS_in_duplicates:
543 @{ git log --pretty=format:%aN | sort -u; \
544 cut -b-36 THANKS.in | sed '/^$$/d;s/ *$$//'; } \
545 | sort | uniq -d | grep . \
546 && { echo '$(ME): remove the above names from THANKS.in' \
547 1>&2; exit 1; } || :
549 # Look for developer diagnostics that are marked for translation.
550 # This won't find any for which devmsg's format string is on a separate line.
551 sc_marked_devdiagnostics:
552 @prohibit='\<devmsg *\(.*_\(' \
553 halt='found marked developer diagnostic(s)' \
554 $(_sc_search_regexp)
556 # Override the default Cc: used in generating an announcement.
557 announcement_Cc_ = $(translation_project_), \
558 coreutils@gnu.org, coreutils-announce@gnu.org
560 -include $(srcdir)/dist-check.mk
562 update-copyright-env = \
563 UPDATE_COPYRIGHT_FORCE=1 \
564 UPDATE_COPYRIGHT_USE_INTERVALS=2 \
565 UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79
567 # List syntax-check exemptions.
568 exclude_file_name_regexp--sc_space_tab = \
569 ^(tests/pr/|tests/misc/nl\.sh$$|gl/.*\.diff$$)
570 exclude_file_name_regexp--sc_bindtextdomain = \
571 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list)\.c$$
572 exclude_file_name_regexp--sc_trailing_blank = ^tests/pr/
573 exclude_file_name_regexp--sc_system_h_headers = \
574 ^src/((system|copy)\.h|libstdbuf\.c|make-prime-list\.c)$$
576 _src = (false|lbracket|ls-(dir|ls|vdir)|tac-pipe|uname-(arch|uname))
577 exclude_file_name_regexp--sc_require_config_h_first = \
578 (^lib/buffer-lcm\.c|src/$(_src)\.c)$$
579 exclude_file_name_regexp--sc_require_config_h = \
580 $(exclude_file_name_regexp--sc_require_config_h_first)
582 exclude_file_name_regexp--sc_po_check = ^gl/
583 exclude_file_name_regexp--sc_prohibit_always-defined_macros = \
584 ^src/(seq|remove)\.c$$
585 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = ^tests/pr/
586 exclude_file_name_regexp--sc_program_name = \
587 ^(gl/.*|lib/euidaccess-stat|src/make-prime-list)\.c$$
588 exclude_file_name_regexp--sc_file_system = \
589 NEWS|^(init\.cfg|src/df\.c|tests/df/df-P\.sh|tests/df/df-output\.sh)$$
590 exclude_file_name_regexp--sc_prohibit_always_true_header_tests = \
591 ^m4/stat-prog\.m4$$
592 exclude_file_name_regexp--sc_prohibit_fail_0 = \
593 (^.*/git-hooks/commit-msg|^tests/init\.sh|Makefile\.am|\.mk|.*\.texi)$$
594 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^lib/euidaccess-stat\.c$$
596 # longlong.h is maintained elsewhere.
597 _ll = ^src/longlong\.h$$
598 exclude_file_name_regexp--sc_useless_cpp_parens = $(_ll)
599 exclude_file_name_regexp--sc_long_lines = $(_ll)
600 exclude_file_name_regexp--sc_space_before_open_paren = $(_ll)
602 tbi_1 = ^tests/pr/|(^gl/lib/reg.*\.c\.diff|\.mk|^man/help2man)$$
603 tbi_2 = ^scripts/git-hooks/(pre-commit|pre-applypatch|applypatch-msg)$$
604 tbi_3 = (GNU)?[Mm]akefile(\.am)?$$|$(_ll)
605 exclude_file_name_regexp--sc_prohibit_tab_based_indentation = \
606 $(tbi_1)|$(tbi_2)|$(tbi_3)
608 exclude_file_name_regexp--sc_preprocessor_indentation = \
609 ^(gl/lib/rand-isaac\.[ch]|gl/tests/test-rand-isaac\.c)$$|$(_ll)
610 exclude_file_name_regexp--sc_prohibit_stat_st_blocks = \
611 ^(src/system\.h|tests/du/2g\.sh)$$
613 exclude_file_name_regexp--sc_prohibit_continued_string_alpha_in_column_1 = \
614 ^src/(system\.h|od\.c|printf\.c|getlimits\.c)$$
616 exclude_file_name_regexp--sc_prohibit_test_backticks = \
617 ^tests/(local\.mk|(init|misc/stdbuf|factor/create-test)\.sh)$$
619 # Exempt test.c, since it's nominally shared, and relatively static.
620 exclude_file_name_regexp--sc_prohibit_operator_at_end_of_line = \
621 ^src/(ptx|test|head)\.c$$
623 exclude_file_name_regexp--sc_error_message_uppercase = ^src/factor\.c$$
624 exclude_file_name_regexp--sc_prohibit_atoi_atof = ^src/make-prime-list\.c$$
626 # Augment AM_CFLAGS to include our per-directory options:
627 AM_CFLAGS += $($(@D)_CFLAGS)
629 src_CFLAGS = $(WARN_CFLAGS)
630 lib_CFLAGS = $(GNULIB_WARN_CFLAGS)
631 gnulib-tests_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS)
633 # Configuration to make the tight-scope syntax-check rule work with
634 # non-recursive make.
635 export _gl_TS_headers = $(srcdir)/cfg.mk
636 _gl_TS_dir = .
637 _gl_TS_obj_files = src/*.$(OBJEXT)
638 _gl_TS_other_headers = src/*.h
640 # Tell the tight_scope rule about an exceptional "extern" variable.
641 # Normally, the rule would detect its declaration, but that uses a
642 # different name, __clz_tab.
643 _gl_TS_unmarked_extern_vars = factor_clz_tab