maint.mk

   1 # -*-Makefile-*-
   2 # This Makefile fragment tries to be general-purpose enough to be
   3 # used by at least coreutils, idutils, CPPI, Bison, and Autoconf.
   4
   5 ## Copyright (C) 2001-2009 Free Software Foundation, Inc.
   6 ##
   7 ## This program is free software: you can redistribute it and/or modify
   8 ## it under the terms of the GNU General Public License as published by
   9 ## the Free Software Foundation, either version 3 of the License, or
  10 ## (at your option) any later version.
  11 ##
  12 ## This program is distributed in the hope that it will be useful,
  13 ## but WITHOUT ANY WARRANTY; without even the implied warranty of
  14 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  15 ## GNU General Public License for more details.
  16 ##
  17 ## You should have received a copy of the GNU General Public License
  18 ## along with this program.  If not, see <http://www.gnu.org/licenses/>.
  19
  20 # This is reported not to work with make-3.79.1
  21 # ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
  22 ME := maint.mk
  23
  24 # Do not save the original name or timestamp in the .tar.gz file.
  25 # Use --rsyncable if available.
  26 gzip_rsyncable := \
  27   $(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo --rsyncable)
  28 GZIP_ENV = '--no-name --best $(gzip_rsyncable)'
  29
  30 GIT = git
  31 VC = $(GIT)
  32 VC-tag = git tag -s -m '$(VERSION)'
  33
  34 VC_LIST = $(srcdir)/build-aux/vc-list-files
  35
  36 VC_LIST_EXCEPT = \
  37   $(VC_LIST) | if test -f .x-$@; then grep -vEf .x-$@; else grep -v ChangeLog; fi
  38
  39 ifeq ($(origin prev_version_file), undefined)
  40   prev_version_file = $(srcdir)/.prev-version
  41 endif
  42
  43 PREV_VERSION := $(shell cat $(prev_version_file))
  44 VERSION_REGEXP = $(subst .,\.,$(VERSION))
  45 PREV_VERSION_REGEXP = $(subst .,\.,$(PREV_VERSION))
  46
  47 ifeq ($(VC),$(GIT))
  48 this-vc-tag = v$(VERSION)
  49 this-vc-tag-regexp = v$(VERSION_REGEXP)
  50 else
  51 tag-package = $(shell echo "$(PACKAGE)" | tr '[:lower:]' '[:upper:]')
  52 tag-this-version = $(subst .,_,$(VERSION))
  53 this-vc-tag = $(tag-package)-$(tag-this-version)
  54 this-vc-tag-regexp = $(this-vc-tag)
  55 endif
  56 my_distdir = $(PACKAGE)-$(VERSION)
  57
  58 # Old releases are stored here.
  59 release_archive_dir ?= ../release
  60
  61 # Prevent programs like 'sort' from considering distinct strings to be equal.
  62 # Doing it here saves us from having to set LC_ALL elsewhere in this file.
  63 export LC_ALL = C
  64
  65 ## --------------- ##
  66 ## Sanity checks.  ##
  67 ## --------------- ##
  68
  69 # Collect the names of rules starting with `sc_'.
  70 syntax-check-rules := $(shell sed -n 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \
  71                         $(srcdir)/$(ME) $(srcdir)/cfg.mk)
  72 .PHONY: $(syntax-check-rules)
  73
  74 local-checks-available = \
  75   patch-check $(syntax-check-rules) \
  76   makefile-check check-AUTHORS
  77 .PHONY: $(local-checks-available)
  78
  79 # Arrange to print the name of each syntax-checking rule just before running it.
  80 $(syntax-check-rules): %: %.m
  81 $(patsubst %, %.m, $(syntax-check-rules)):
  82         @echo $(patsubst sc_%.m, %, $@)
  83
  84 local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available))
  85
  86 syntax-check: $(local-check)
  87 #       @grep -nE '#  *include <(limits|std(def|arg|bool))\.h>'         \
  88 #           $$(find -type f -name '*.[chly]') &&                        \
  89 #         { echo '$(ME): found conditional include' 1>&2;               \
  90 #           exit 1; } || :
  91
  92 #       grep -nE '^#  *include <(string|stdlib)\.h>'                    \
  93 #           $(srcdir)/{lib,src}/*.[chy] &&                              \
  94 #         { echo '$(ME): FIXME' 1>&2;                                   \
  95 #           exit 1; } || :
  96 # FIXME: don't allow `#include .strings\.h' anywhere
  97
  98 # By default, _prohibit_regexp does not ignore case.
  99 export ignore_case =
 100 _ignore_case = $$(test -n "$$ignore_case" && echo -i || :)
 101
 102 # There are many rules below that prohibit constructs in this package.
 103 # If the offending construct can be matched with a grep-E-style regexp,
 104 # use this macro.  The shell variables "re" and "msg" must be defined.
 105 define _prohibit_regexp
 106   dummy=; : so we do not need a semicolon before each use;              \
 107   test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; };  \
 108   test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\
 109   grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) &&              \
 110     { echo '$(ME): '"$$msg" 1>&2; exit 1; } || :
 111 endef
 112
 113 sc_avoid_if_before_free:
 114         @$(srcdir)/build-aux/useless-if-before-free                     \
 115                 $(useless_free_options)                                 \
 116             $$($(VC_LIST_EXCEPT)) &&                                    \
 117           { echo '$(ME): found useless "if" before "free" above' 1>&2;  \
 118             exit 1; } || :
 119
 120 sc_cast_of_argument_to_free:
 121         @re='\<free *\( *\(' msg='don'\''t cast free argument'          \
 122           $(_prohibit_regexp)
 123
 124 sc_cast_of_x_alloc_return_value:
 125         @re='\*\) *x(m|c|re)alloc\>'                                    \
 126         msg='don'\''t cast x*alloc return value'                        \
 127           $(_prohibit_regexp)
 128
 129 sc_cast_of_alloca_return_value:
 130         @re='\*\) *alloca\>' msg='don'\''t cast alloca return value'    \
 131           $(_prohibit_regexp)
 132
 133 sc_space_tab:
 134         @re='[ ]        ' msg='found SPACE-TAB sequence; remove the SPACE' \
 135           $(_prohibit_regexp)
 136
 137 # Don't use *scanf or the old ato* functions in `real' code.
 138 # They provide no error checking mechanism.
 139 # Instead, use strto* functions.
 140 sc_prohibit_atoi_atof:
 141         @re='\<([fs]?scanf|ato([filq]|ll)) *\('                         \
 142         msg='do not use *scan''f, ato''f, ato''i, ato''l, ato''ll or ato''q' \
 143           $(_prohibit_regexp)
 144
 145 # Use STREQ rather than comparing strcmp == 0, or != 0.
 146 sc_prohibit_strcmp:
 147         @grep -nE '! *str''cmp *\(|\<str''cmp *\([^)]+\) *=='           \
 148             $$($(VC_LIST_EXCEPT))                                       \
 149           | grep -vE ':# *define STREQ\(' &&                            \
 150           { echo '$(ME): use STREQ in place of the above uses of str''cmp' \
 151                 1>&2; exit 1; } || :
 152
 153 # Using EXIT_SUCCESS as the first argument to error is misleading,
 154 # since when that parameter is 0, error does not exit.  Use `0' instead.
 155 sc_error_exit_success:
 156         @grep -nE 'error \(EXIT_SUCCESS,'                               \
 157             $$($(VC_LIST_EXCEPT) | grep -E '\.[chly]$$') &&             \
 158           { echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1; } || :
 159
 160 # `FATAL:' should be fully upper-cased in error messages
 161 # `WARNING:' should be fully upper-cased, or fully lower-cased
 162 sc_error_message_warn_fatal:
 163         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 164             | grep -E '"Warning|"Fatal|"fatal' &&                       \
 165           { echo '$(ME): use FATAL, WARNING or warning' 1>&2;           \
 166             exit 1; } || :
 167
 168 # Error messages should not start with a capital letter
 169 sc_error_message_uppercase:
 170         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 171             | grep -E '"[A-Z]'                                          \
 172             | grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' &&           \
 173           { echo '$(ME): found capitalized error message' 1>&2;         \
 174             exit 1; } || :
 175
 176 # Error messages should not end with a period
 177 sc_error_message_period:
 178         @grep -nEA2 '[^rp]error \(' $$($(VC_LIST_EXCEPT))               \
 179             | grep -E '[^."]\."' &&                                     \
 180           { echo '$(ME): found error message ending in period' 1>&2;    \
 181             exit 1; } || :
 182
 183 sc_file_system:
 184         @re=file''system ignore_case=1                                  \
 185         msg='found use of "file''system"; spell it "file system"'       \
 186           $(_prohibit_regexp)
 187
 188 # Don't use cpp tests of this symbol.  All code assumes config.h is included.
 189 sc_prohibit_have_config_h:
 190         @grep -n '^# *if.*HAVE''_CONFIG_H' $$($(VC_LIST_EXCEPT)) &&     \
 191           { echo '$(ME): found use of HAVE''_CONFIG_H; remove'          \
 192                 1>&2; exit 1; } || :
 193
 194 # Nearly all .c files must include <config.h>.
 195 sc_require_config_h:
 196         @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then               \
 197           grep -L '^# *include <config\.h>'                             \
 198                 $$($(VC_LIST_EXCEPT) | grep '\.c$$')                    \
 199               | grep . &&                                               \
 200           { echo '$(ME): the above files do not include <config.h>'     \
 201                 1>&2; exit 1; } || :;                                   \
 202         else :;                                                         \
 203         fi
 204
 205 # You must include <config.h> before including any other header file.
 206 sc_require_config_h_first:
 207         @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then       \
 208           fail=0;                                                       \
 209           for i in $$($(VC_LIST_EXCEPT) | grep '\.c$$'); do             \
 210             grep '^# *include\>' $$i | sed 1q                           \
 211                 | grep '^# *include <config\.h>' > /dev/null            \
 212               || { echo $$i; fail=1; };                                 \
 213           done;                                                         \
 214           test $$fail = 1 &&                                            \
 215             { echo '$(ME): the above files include some other header'   \
 216                 'before <config.h>' 1>&2; exit 1; } || :;               \
 217         else :;                                                         \
 218         fi
 219
 220 sc_prohibit_HAVE_MBRTOWC:
 221         @re='\bHAVE_MBRTOWC\b' msg="do not use $$re; it is always defined" \
 222           $(_prohibit_regexp)
 223
 224 # To use this "command" macro, you must first define two shell variables:
 225 # h: the header, enclosed in <> or ""
 226 # re: a regular expression that matches IFF something provided by $h is used.
 227 define _header_without_use
 228   h_esc=`echo "$$h"|sed 's/\./\\./g'`;                                  \
 229   if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then              \
 230     files=$$(grep -l '^# *include '"$$h_esc"                            \
 231              $$($(VC_LIST_EXCEPT) | grep '\.c$$')) &&                   \
 232     grep -LE "$$re" $$files | grep . &&                                 \
 233       { echo "$(ME): the above files include $$h but don't use it"      \
 234         1>&2; exit 1; } || :;                                           \
 235   else :;                                                               \
 236   fi
 237 endef
 238
 239 # Prohibit the inclusion of assert.h without an actual use of assert.
 240 sc_prohibit_assert_without_use:
 241         @h='<assert.h>' re='\<assert *\(' $(_header_without_use)
 242
 243 # Prohibit the inclusion of getopt.h without an actual use.
 244 sc_prohibit_getopt_without_use:
 245         @h='<getopt.h>' re='\<getopt(_long)? *\(' $(_header_without_use)
 246
 247 # Don't include quotearg.h unless you use one of its functions.
 248 sc_prohibit_quotearg_without_use:
 249         @h='"quotearg.h"' re='\<quotearg(_[^ ]+)? *\(' $(_header_without_use)
 250
 251 # Don't include quote.h unless you use one of its functions.
 252 sc_prohibit_quote_without_use:
 253         @h='"quote.h"' re='\<quote(_n)? *\(' $(_header_without_use)
 254
 255 # Don't include this header unless you use one of its functions.
 256 sc_prohibit_long_options_without_use:
 257         @h='"long-options.h"' re='\<parse_long_options *\(' \
 258           $(_header_without_use)
 259
 260 # Don't include this header unless you use one of its functions.
 261 sc_prohibit_inttostr_without_use:
 262         @h='"inttostr.h"' re='\<(off|[iu]max|uint)tostr *\(' \
 263           $(_header_without_use)
 264
 265 # Don't include this header unless you use one of its functions.
 266 sc_prohibit_error_without_use:
 267         @h='"error.h"' \
 268         re='\<error(_at_line|_print_progname|_one_per_line|_message_count)? *\('\
 269           $(_header_without_use)
 270
 271 sc_prohibit_safe_read_without_use:
 272         @h='"safe-read.h"' re='(\<SAFE_READ_ERROR\>|\<safe_read *\()' \
 273           $(_header_without_use)
 274
 275 sc_prohibit_argmatch_without_use:
 276         @h='"argmatch.h"' \
 277         re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid) *\()' \
 278           $(_header_without_use)
 279
 280 sc_prohibit_root_dev_ino_without_use:
 281         @h='"root-dev-ino.h"' \
 282         re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \
 283           $(_header_without_use)
 284
 285 # Prohibit the inclusion of c-ctype.h without an actual use.
 286 ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
 287 |isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
 288 sc_prohibit_c_ctype_without_use:
 289         @h='[<"]c-ctype.h[">]' re='\<c_($(ctype_re)) *\(' $(_header_without_use)
 290
 291 _empty =
 292 _sp = $(_empty) $(_empty)
 293 # The following list was generated by running:
 294 # man signal.h|col -b|perl -ne '/bsd_signal.*;/.../sigwaitinfo.*;/ and print' \
 295 #   | perl -lne '/^\s+(?:int|void).*?(\w+).*/ and print $1' | fmt
 296 _sig_functions = \
 297   bsd_signal kill killpg pthread_kill pthread_sigmask raise sigaction \
 298   sigaddset sigaltstack sigdelset sigemptyset sigfillset sighold sigignore \
 299   siginterrupt sigismember signal sigpause sigpending sigprocmask sigqueue \
 300   sigrelse sigset sigsuspend sigtimedwait sigwait sigwaitinfo
 301 _sig_function_re = $(subst $(_sp),|,$(strip $(_sig_functions)))
 302 # The following were extracted from "man signal.h" manually.
 303 _sig_types_and_consts =                                                 \
 304   MINSIGSTKSZ SA_NOCLDSTOP SA_NOCLDWAIT SA_NODEFER SA_ONSTACK           \
 305   SA_RESETHAND SA_RESTART SA_SIGINFO SIGEV_NONE SIGEV_SIGNAL            \
 306   SIGEV_THREAD SIGSTKSZ SIG_BLOCK SIG_SETMASK SIG_UNBLOCK SS_DISABLE    \
 307   SS_ONSTACK mcontext_t pid_t sig_atomic_t sigevent siginfo_t sigset_t  \
 308   sigstack sigval stack_t ucontext_t
 309 # generated via this:
 310 # perl -lne '/^#ifdef (SIG\w+)/ and print $1' lib/sig2str.c|sort -u|fmt -70
 311 _sig_names =                                                            \
 312   SIGABRT SIGALRM SIGALRM1 SIGBUS SIGCANCEL SIGCHLD SIGCLD SIGCONT      \
 313   SIGDANGER SIGDIL SIGEMT SIGFPE SIGFREEZE SIGGRANT SIGHUP SIGILL       \
 314   SIGINFO SIGINT SIGIO SIGIOT SIGKAP SIGKILL SIGKILLTHR SIGLOST SIGLWP  \
 315   SIGMIGRATE SIGMSG SIGPHONE SIGPIPE SIGPOLL SIGPRE SIGPROF SIGPWR      \
 316   SIGQUIT SIGRETRACT SIGSAK SIGSEGV SIGSOUND SIGSTKFLT SIGSTOP SIGSYS   \
 317   SIGTERM SIGTHAW SIGTRAP SIGTSTP SIGTTIN SIGTTOU SIGURG SIGUSR1        \
 318   SIGUSR2 SIGVIRT SIGVTALRM SIGWAITING SIGWINCH SIGWIND SIGWINDOW       \
 319   SIGXCPU SIGXFSZ
 320 _sig_syms_re = $(subst $(_sp),|,$(strip $(_sig_names) $(_sig_types_and_consts)))
 321
 322 # Prohibit the inclusion of signal.h without an actual use.
 323 sc_prohibit_signal_without_use:
 324         @h='<signal.h>'                                                 \
 325         re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>'          \
 326           $(_header_without_use)
 327
 328 sc_obsolete_symbols:
 329         @re='\<(HAVE''_FCNTL_H|O''_NDELAY)\>'                           \
 330         msg='do not use HAVE''_FCNTL_H or O'_NDELAY                     \
 331           $(_prohibit_regexp)
 332
 333 # FIXME: warn about definitions of EXIT_FAILURE, EXIT_SUCCESS, STREQ
 334
 335 # Each nonempty ChangeLog line must start with a year number, or a TAB.
 336 sc_changelog:
 337         @if $(VC_LIST_EXCEPT) | grep -l '^ChangeLog$$' >/dev/null; then \
 338           grep -n '^[^12        ]'                                      \
 339             $$($(VC_LIST_EXCEPT) | grep '^ChangeLog$$') &&              \
 340           { echo '$(ME): found unexpected prefix in a ChangeLog' 1>&2;  \
 341             exit 1; } || :;                                             \
 342         fi
 343
 344 # Ensure that each .c file containing a "main" function also
 345 # calls set_program_name.
 346 sc_program_name:
 347         @if $(VC_LIST_EXCEPT) | grep -l '\.c$$' > /dev/null; then       \
 348           files=$$(grep -l '^main *(' $$($(VC_LIST_EXCEPT) | grep '\.c$$')); \
 349           grep -LE 'set_program_name *\(m?argv\[0\]\);' $$files         \
 350               | grep . &&                                               \
 351           { echo '$(ME): the above files do not call set_program_name'  \
 352                 1>&2; exit 1; } || :;                                   \
 353         else :;                                                         \
 354         fi
 355
 356 # Require that the final line of each test-lib.sh-using test be this one:
 357 # Exit $fail
 358 # Note: this test requires GNU grep's --label= option.
 359 sc_require_test_exit_idiom:
 360         @if test -f $(srcdir)/tests/test-lib.sh; then                   \
 361           die=0;                                                        \
 362           for i in $$(grep -l -F /../test-lib.sh $$($(VC_LIST) tests)); do \
 363             tail -n1 $$i | grep '^Exit \$$fail$$' > /dev/null           \
 364               && : || { die=1; echo $$i; }                              \
 365           done;                                                         \
 366           test $$die = 1 &&                                             \
 367             { echo 1>&2 '$(ME): the final line in each of the above is not:'; \
 368               echo 1>&2 'Exit $$fail';                                  \
 369               exit 1; } || :;                                           \
 370         fi
 371
 372 sc_the_the:
 373         @re='\<the ''the\>'                                             \
 374         ignore_case=1 msg='found use of "the ''the";'                   \
 375           $(_prohibit_regexp)
 376
 377 sc_trailing_blank:
 378         @re='[   ]$$'                                                   \
 379         msg='found trailing blank(s)'                                   \
 380           $(_prohibit_regexp)
 381
 382 # Match lines like the following, but where there is only one space
 383 # between the options and the description:
 384 #   -D, --all-repeated[=delimit-method]  print all duplicate lines\n
 385 longopt_re = --[a-z][0-9A-Za-z-]*(\[?=[0-9A-Za-z-]*\]?)?
 386 sc_two_space_separator_in_usage:
 387         @grep -nE '^   *(-[A-Za-z],)? $(longopt_re) [^ ].*\\$$'         \
 388             $$($(VC_LIST_EXCEPT)) &&                                    \
 389           { echo "$(ME): help2man requires at least two spaces between"; \
 390             echo "$(ME): an option and its description";                \
 391                 1>&2; exit 1; } || :
 392
 393 # Look for diagnostics that aren't marked for translation.
 394 # This won't find any for which error's format string is on a separate line.
 395 sc_unmarked_diagnostics:
 396         @grep -nE                                                       \
 397             '\<error \([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT))       \
 398           | grep -v '_''(' &&                                           \
 399           { echo '$(ME): found unmarked diagnostic(s)' 1>&2;            \
 400             exit 1; } || :
 401
 402 # Avoid useless parentheses like those in this example:
 403 # #if defined (SYMBOL) || defined (SYM2)
 404 sc_useless_cpp_parens:
 405         @grep -n '^# *if .*defined *(' $$($(VC_LIST_EXCEPT)) &&         \
 406           { echo '$(ME): found useless parentheses in cpp directive'    \
 407                 1>&2; exit 1; } || :
 408
 409 # Require the latest GPL.
 410 sc_GPL_version:
 411         @re='either ''version [^3]' msg='GPL vN, N!=3'                  \
 412           $(_prohibit_regexp)
 413
 414 cvs_keywords = \
 415   Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
 416
 417 sc_prohibit_cvs_keyword:
 418         @re='\$$($(cvs_keywords))\$$'                                   \
 419             msg='do not use CVS keyword expansion'                      \
 420           $(_prohibit_regexp)
 421
 422 # Make sure we don't use st_blocks.  Use ST_NBLOCKS instead.
 423 # This is a bit of a kludge, since it prevents use of the string
 424 # even in comments, but for now it does the job with no false positives.
 425 sc_prohibit_stat_st_blocks:
 426         @re='[.>]st_blocks' msg='do not use st_blocks; use ST_NBLOCKS'  \
 427           $(_prohibit_regexp)
 428
 429 # Make sure we don't define any S_IS* macros in src/*.c files.
 430 # They're already defined via gnulib's sys/stat.h replacement.
 431 sc_prohibit_S_IS_definition:
 432         @re='^ *# *define  *S_IS'                                       \
 433         msg='do not define S_IS* macros; include <sys/stat.h>'          \
 434           $(_prohibit_regexp)
 435
 436 # Each program that uses proper_name_utf8 must link with
 437 # one of the ICONV libraries.
 438 sc_proper_name_utf8_requires_ICONV:
 439         @progs=$$(grep -l 'proper_name_utf8 ''("' $$($(VC_LIST_EXCEPT)));\
 440         if test "x$$progs" != x; then                                   \
 441           fail=0;                                                       \
 442           for p in $$progs; do                                          \
 443             dir=$$(dirname "$$p");                                      \
 444             base=$$(basename "$$p" .c);                                 \
 445             grep "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \
 446               || { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \
 447           done;                                                         \
 448           test $$fail = 1 &&                                            \
 449             { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \
 450               exit 1; } || :;                                           \
 451         fi
 452
 453 # Warn about "c0nst struct Foo const foo[]",
 454 # but not about "char const *const foo" or "#define const const".
 455 sc_redundant_const:
 456         @re='\bconst\b[[:space:][:alnum:]]{2,}\bconst\b'                \
 457         msg='redundant "const" in declarations'                         \
 458           $(_prohibit_regexp)
 459
 460 sc_const_long_option:
 461         @grep '^ *static.*struct option ' $$($(VC_LIST_EXCEPT))         \
 462           | grep -Ev 'const struct option|struct option const' && {     \
 463               echo 1>&2 '$(ME): add "const" to the above declarations'; \
 464               exit 1; } || :
 465
 466 NEWS_hash =                                                             \
 467   $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p'              \
 468        $(srcdir)/NEWS                                                   \
 469      | grep -v '^Copyright .*Free Software'                             \
 470      | md5sum -                                                         \
 471      | sed 's/ .*//')
 472
 473 # Ensure that we don't accidentally insert an entry into an old NEWS block.
 474 sc_immutable_NEWS:
 475         @if test -f $(srcdir)/NEWS; then                                \
 476           test "$(NEWS_hash)" = '$(old_NEWS_hash)' && : ||              \
 477             { echo '$(ME): you have modified old NEWS' 1>&2; exit 1; }; \
 478         fi
 479
 480 # Update the hash stored above.  Do this after each release and
 481 # for any corrections to old entries.
 482 update-NEWS-hash: NEWS
 483         perl -pi -e 's/^(old_NEWS_hash = ).*/$${1}'"$(NEWS_hash)/" \
 484           $(srcdir)/cfg.mk
 485
 486 epoch_date = 1970-01-01 00:00:00.000000000 +0000
 487 # Ensure that the c99-to-c89 patch applies cleanly.
 488 patch-check:
 489         rm -rf src-c89 $@.1 $@.2
 490         cp -a $(srcdir)/src src-c89
 491         if test "x$(srcdir)" != x.; then \
 492           cp -a src/* src-c89; \
 493           dotfiles=`ls src/.[!.]* 2>/dev/null`; \
 494           test -z "$$dotfiles" || cp -a src/.[!.]* src-c89; \
 495         fi
 496         (cd src-c89; patch -p1 -V never --fuzz=0) < $(srcdir)/src/c99-to-c89.diff \
 497           > $@.1 2>&1
 498         if test "$(REGEN_PATCH)" = yes; then                    \
 499           diff -upr $(srcdir)/src src-c89 | sed 's,$(srcdir)/src-c89/,src/,'    \
 500             | grep -vE '^(Only in|File )'                       \
 501             | perl -pe 's/^((?:\+\+\+|---) \S+\t).*/$${1}$(epoch_date)/;' \
 502                -e 's/^ $$//'                                    \
 503             > new-diff || : ; fi
 504         grep -v '^patching file ' $@.1 > $@.2 || :
 505         msg=ok; test -s $@.2 && msg='fuzzy patch' || : ;        \
 506         rm -f src-c89/*.o || msg='rm failed';                   \
 507         $(MAKE) -C src-c89 CFLAGS='-Wdeclaration-after-statement -Werror' \
 508           || msg='compile failure with extra options';          \
 509         test "$$msg" = ok && rm -rf src-c89 $@.1 $@.2 || echo "$$msg" 1>&2; \
 510         test "$$msg" = ok
 511
 512 check-AUTHORS:
 513         $(MAKE) -C src $@
 514
 515 # Ensure that we use only the standard $(VAR) notation,
 516 # not @...@ in Makefile.am, now that we can rely on automake
 517 # to emit a definition for each substituted variable.
 518 # We use perl rather than "grep -nE ..." to exempt a single
 519 # use of an @...@-delimited variable name in src/Makefile.am.
 520 makefile-check:
 521         @perl -ne '/\@[A-Z_0-9]+\@/ && !/^cu_install_program =/'        \
 522           -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}'    \
 523             $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$')       \
 524           && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || :
 525
 526 news-date-check: NEWS
 527         today=`date +%Y-%m-%d`;                                         \
 528         if head NEWS | grep '^\*.* $(VERSION_REGEXP) ('$$today')'       \
 529             >/dev/null; then                                            \
 530           :;                                                            \
 531         else                                                            \
 532           echo "version or today's date is not in NEWS" 1>&2;           \
 533           exit 1;                                                       \
 534         fi
 535
 536 changelog-check:
 537         if head ChangeLog | grep 'Version $(VERSION_REGEXP)\.$$'        \
 538             >/dev/null; then                                            \
 539           :;                                                            \
 540         else                                                            \
 541           echo "$(VERSION) not in ChangeLog" 1>&2;                      \
 542           exit 1;                                                       \
 543         fi
 544
 545 sc_makefile_TAB_only_indentation:
 546         @grep -nE '^    [ ]{8}'                                         \
 547             $$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$')            \
 548           && { echo '$(ME): found TAB-8-space indentation' 1>&2;        \
 549                exit 1; } || :
 550
 551 sc_m4_quote_check:
 552         @grep -nE '(AC_DEFINE(_UNQUOTED)?|AC_DEFUN)\([^[]'              \
 553             $$($(VC_LIST_EXCEPT) | grep -E '(^configure\.ac|\.m4)$$')   \
 554           && { echo '$(ME): quote the first arg to AC_DEF*' 1>&2;       \
 555                exit 1; } || :
 556
 557 fix_po_file_diag = \
 558 'you have changed the set of files with translatable diagnostics;\n\
 559 apply the above patch\n'
 560
 561 # Verify that all source files using _() are listed in po/POTFILES.in.
 562 po_file = po/POTFILES.in
 563 sc_po_check:
 564         @if test -f $(po_file); then                                    \
 565           grep -E -v '^(#|$$)' $(po_file)                               \
 566             | grep -v '^src/false\.c$$' | sort > $@-1;                  \
 567           files=;                                                       \
 568           for file in $$($(VC_LIST_EXCEPT)) lib/*.[ch]; do              \
 569             test -r $$file || continue;                                 \
 570             case $$file in                                              \
 571               *.?|*.??) ;;                                              \
 572               *) continue;;                                             \
 573             esac;                                                       \
 574             case $$file in                                              \
 575             *.[ch])                                                     \
 576               base=`expr " $$file" : ' \(.*\)\..'`;                     \
 577               { test -f $$base.l || test -f $$base.y; } && continue;;   \
 578             esac;                                                       \
 579             files="$$files $$file";                                     \
 580           done;                                                         \
 581           grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files          \
 582             | sort -u > $@-2;                                           \
 583           diff -u -L $(po_file) -L $(po_file) $@-1 $@-2                 \
 584             || { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; };   \
 585           rm -f $@-1 $@-2;                                              \
 586         fi
 587
 588 # Sometimes it is useful to change the PATH environment variable
 589 # in Makefiles.  When doing so, it's better not to use the Unix-centric
 590 # path separator of `:', but rather the automake-provided `$(PATH_SEPARATOR)'.
 591 msg = '$(ME): Do not use `:'\'' above; use $$(PATH_SEPARATOR) instead'
 592 sc_makefile_path_separator_check:
 593         @grep -nE 'PATH[=].*:'                                          \
 594             $$($(VC_LIST_EXCEPT) | grep -E 'akefile|\.mk$$')            \
 595           && { echo $(msg) 1>&2; exit 1; } || :
 596
 597 # Check that `make alpha' will not fail at the end of the process.
 598 writable-files:
 599         if test -d $(release_archive_dir); then :; else                 \
 600           for file in $(distdir).tar.gz                                 \
 601                       $(release_archive_dir)/$(distdir).tar.gz; do      \
 602             test -e $$file || continue;                                 \
 603             test -w $$file                                              \
 604               || { echo ERROR: $$file is not writable; fail=1; };       \
 605           done;                                                         \
 606           test "$$fail" && exit 1 || : ;                                \
 607         fi
 608
 609 v_etc_file = lib/version-etc.c
 610 sample-test = tests/sample-test
 611 texi = doc/$(PACKAGE).texi
 612 # Make sure that the copyright date in $(v_etc_file) is up to date.
 613 # Do the same for the $(sample-test) and the main doc/.texi file.
 614 sc_copyright_check:
 615         @if test -f $(v_etc_file); then                                 \
 616           grep 'enum { COPYRIGHT_YEAR = '$$(date +%Y)' };' $(v_etc_file) \
 617             >/dev/null                                                  \
 618           || { echo 'out of date copyright in $(v_etc_file); update it' 1>&2; \
 619                exit 1; };                                               \
 620         fi
 621         @if test -f $(sample-test); then                                \
 622           grep '# Copyright (C) '$$(date +%Y)' Free' $(sample-test)     \
 623             >/dev/null                                                  \
 624           || { echo 'out of date copyright in $(sample-test); update it' 1>&2; \
 625                exit 1; };                                               \
 626         fi
 627         @if test -f $(texi); then                                       \
 628           grep 'Copyright @copyright{} .*'$$(date +%Y)' Free' $(texi)   \
 629             >/dev/null                                                  \
 630           || { echo 'out of date copyright in $(texi); update it' 1>&2; \
 631                exit 1; };                                               \
 632         fi
 633
 634 vc-diff-check:
 635         $(VC) diff > vc-diffs || :
 636         if test -s vc-diffs; then                               \
 637           cat vc-diffs;                                         \
 638           echo "Some files are locally modified:" 1>&2;         \
 639           exit 1;                                               \
 640         else                                                    \
 641           rm vc-diffs;                                          \
 642         fi
 643
 644 cvs-check: vc-diff-check
 645
 646 maintainer-distcheck:
 647         $(MAKE) distcheck
 648         $(MAKE) taint-distcheck
 649         $(MAKE) my-distcheck
 650
 651
 652 # Don't make a distribution if checks fail.
 653 # Also, make sure the NEWS file is up-to-date.
 654 vc-dist: $(local-check) cvs-check maintainer-distcheck
 655         XZ_OPT=-9ev $(MAKE) dist
 656
 657 # Use this to make sure we don't run these programs when building
 658 # from a virgin tgz file, below.
 659 null_AM_MAKEFLAGS = \
 660   ACLOCAL=false \
 661   AUTOCONF=false \
 662   AUTOMAKE=false \
 663   AUTOHEADER=false \
 664   MAKEINFO=false
 665
 666 built_programs = $$(cd src && MAKEFLAGS= $(MAKE) -s built_programs.list)
 667
 668 warn_cflags = -Dlint -O -Werror -Wall -Wformat -Wshadow -Wpointer-arith
 669 bin=bin-$$$$
 670
 671 write_loser = printf '\#!%s\necho $$0: bad path 1>&2; exit 1\n' '$(SHELL)'
 672
 673 TMPDIR ?= /tmp
 674 t=$(TMPDIR)/$(PACKAGE)/test
 675 pfx=$(t)/i
 676
 677 # More than once, tainted build and source directory names would
 678 # have caused at least one "make check" test to apply "chmod 700"
 679 # to all directories under $HOME.  Make sure it doesn't happen again.
 680 tp := $(shell echo "$(TMPDIR)/$(PACKAGE)-$$$$")
 681 t_prefix = $(tp)/a
 682 t_taint = '$(t_prefix) b'
 683 fake_home = $(tp)/home
 684
 685 # Ensure that tests run from tainted build and src dir names work,
 686 # and don't affect anything in $HOME.  Create witness files in $HOME,
 687 # record their attributes, and build/test.  Then ensure that the
 688 # witnesses were not affected.
 689 taint-distcheck: $(DIST_ARCHIVES)
 690         test -d $(t_taint) && chmod -R 700 $(t_taint) || :
 691         -rm -rf $(t_taint) $(fake_home)
 692         mkdir -p $(t_prefix) $(t_taint) $(fake_home)
 693         GZIP=$(GZIP_ENV) $(AMTAR) -C $(t_taint) -zxf $(distdir).tar.gz
 694         mkfifo $(fake_home)/fifo
 695         touch $(fake_home)/f
 696         mkdir -p $(fake_home)/d/e
 697         ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-before
 698         cd $(t_taint)/$(distdir)                        \
 699           && ./configure                                \
 700           && $(MAKE)                                    \
 701           && HOME=$(fake_home) $(MAKE) check            \
 702           && ls -lR $(fake_home) $(t_prefix) > $(tp)/.ls-after \
 703           && diff $(tp)/.ls-before $(tp)/.ls-after      \
 704           && test -d $(t_prefix)
 705         rm -rf $(tp)
 706
 707 # Verify that a twisted use of --program-transform-name=PROGRAM works.
 708 define install-transform-check
 709   echo running install-transform-check                  \
 710     && rm -rf $(pfx)                                    \
 711     && $(MAKE) program_transform_name='s/.*/zyx/'       \
 712       prefix=$(pfx) install                             \
 713     && test "$$(echo $(pfx)/bin/*)" = "$(pfx)/bin/zyx"  \
 714     && test "$$(find $(pfx)/share/man -type f|sed 's,.*/,,;s,\..*,,')" = "zyx"
 715 endef
 716
 717 # Install, then verify that all binaries and man pages are in place.
 718 # Note that neither the binary, ginstall, nor the ].1 man page is installed.
 719 define my-instcheck
 720   $(MAKE) prefix=$(pfx) install                         \
 721     && test ! -f $(pfx)/bin/ginstall                    \
 722     && { fail=0;                                        \
 723       for i in $(built_programs); do                    \
 724         test "$$i" = ginstall && i=install;             \
 725         for j in "$(pfx)/bin/$$i"                       \
 726                  "$(pfx)/share/man/man1/$$i.1"; do      \
 727           case $$j in *'[.1') continue;; esac;          \
 728           test -f "$$j" && :                            \
 729             || { echo "$$j not installed"; fail=1; };   \
 730         done;                                           \
 731       done;                                             \
 732       test $$fail = 1 && exit 1 || :;                   \
 733     }
 734 endef
 735
 736 define coreutils-path-check
 737   {                                                     \
 738     if test -f $(srcdir)/src/true.c; then               \
 739       fail=1;                                           \
 740       mkdir $(bin)                                      \
 741         && ($(write_loser)) > $(bin)/loser              \
 742         && chmod a+x $(bin)/loser                       \
 743         && for i in $(built_programs); do               \
 744                case $$i in                              \
 745                  rm|expr|basename|echo|sort|ls|tr);;    \
 746                  cat|dirname|mv|wc);;                   \
 747                  *) ln $(bin)/loser $(bin)/$$i;;        \
 748                esac;                                    \
 749              done                                       \
 750           && ln -sf ../src/true $(bin)/false            \
 751           && PATH=`pwd`/$(bin)$(PATH_SEPARATOR)$$PATH   \
 752                 $(MAKE) -C tests check                  \
 753           && { test -d gnulib-tests                     \
 754                  && $(MAKE) -C gnulib-tests check       \
 755                  || :; }                                \
 756           && rm -rf $(bin)                              \
 757           && fail=0;                                    \
 758     else                                                \
 759       fail=0;                                           \
 760     fi;                                                 \
 761     test $$fail = 1 && exit 1 || :;                     \
 762   }
 763 endef
 764
 765 # Use -Wformat -Werror to detect format-string/arg-list mismatches.
 766 # Also, check for shadowing problems with -Wshadow, and for pointer
 767 # arithmetic problems with -Wpointer-arith.
 768 # These CFLAGS are pretty strict.  If you build this target, you probably
 769 # have to have a recent version of gcc and glibc headers.
 770 # The hard-linking for-loop below ensures that there is a bin/ directory
 771 # full of all of the programs under test (except the ones that are required
 772 # for basic Makefile rules), all symlinked to the just-built "false" program.
 773 # This is to ensure that if ever a test neglects to make PATH include
 774 # the build srcdir, these always-failing programs will run.
 775 # Otherwise, it is too easy to test the wrong programs.
 776 # Note that "false" itself is a symlink to true, so it too will malfunction.
 777 my-distcheck: $(DIST_ARCHIVES) $(local-check)
 778         $(MAKE) syntax-check
 779         $(MAKE) check
 780         -rm -rf $(t)
 781         mkdir -p $(t)
 782         GZIP=$(GZIP_ENV) $(AMTAR) -C $(t) -zxf $(distdir).tar.gz
 783         cd $(t)/$(distdir)                              \
 784           && ./configure --disable-nls                  \
 785           && $(MAKE) CFLAGS='$(warn_cflags)'            \
 786               AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)'       \
 787           && $(MAKE) dvi                                \
 788           && $(install-transform-check)                 \
 789           && $(my-instcheck)                            \
 790           && $(coreutils-path-check)                    \
 791           && $(MAKE) distclean
 792         (cd $(t) && mv $(distdir) $(distdir).old        \
 793           && $(AMTAR) -zxf - ) < $(distdir).tar.gz
 794         diff -ur $(t)/$(distdir).old $(t)/$(distdir)
 795         -rm -rf $(t)
 796         @echo "========================"; \
 797         echo "$(distdir).tar.gz is ready for distribution"; \
 798         echo "========================"
 799
 800 WGET = wget
 801 WGETFLAGS = -C off
 802
 803 rel-check:
 804         tarz=/tmp/rel-check-tarz-$$$$; \
 805         md5_tmp=/tmp/rel-check-md5-$$$$; \
 806         set -e; \
 807         trap 'status=$$?; rm -f $$tarz $$md5_tmp; exit $$status' 0 1 2 3 15; \
 808         $(WGET) $(WGETFLAGS) -q --output-document=$$tarz $(url); \
 809         echo "$(md5)  -" > $$md5_tmp; \
 810         md5sum -c $$md5_tmp < $$tarz
 811
 812 rel-files = $(DIST_ARCHIVES)
 813
 814 gnulib-version = $$(cd $(gnulib_dir) && git describe)
 815
 816 announcement: NEWS ChangeLog $(rel-files)
 817         @./build-aux/announce-gen                                       \
 818             --release-type=$(RELEASE_TYPE)                              \
 819             --package=$(PACKAGE)                                        \
 820             --prev=$(PREV_VERSION)                                      \
 821             --curr=$(VERSION)                                           \
 822             --gpg-key-id=$(gpg_key_ID)                                  \
 823             --news=NEWS                                                 \
 824             --bootstrap-tools=autoconf,automake,bison,gnulib            \
 825             --gnulib-version=$(gnulib-version)                          \
 826             --no-print-checksums                                        \
 827             $(addprefix --url-dir=, $(url_dir_list))
 828
 829 ## ---------------- ##
 830 ## Updating files.  ##
 831 ## ---------------- ##
 832
 833 ftp-gnu = ftp://ftp.gnu.org/gnu
 834 www-gnu = http://www.gnu.org
 835
 836 # Use mv, if you don't have/want move-if-change.
 837 move_if_change ?= move-if-change
 838
 839 emit_upload_commands:
 840         @echo =====================================
 841         @echo =====================================
 842         @echo "$(srcdir)/build-aux/gnupload $(GNUPLOADFLAGS) \\"
 843         @echo "    --to $(gnu_rel_host):$(PACKAGE) \\"
 844         @echo "  $(rel-files)"
 845         @echo '# send the /tmp/announcement e-mail'
 846         @echo =====================================
 847         @echo =====================================
 848
 849 noteworthy = * Noteworthy changes in release ?.? (????-??-??) [?]
 850 define emit-commit-log
 851   printf '%s\n' 'post-release administrivia' '' \
 852     '* NEWS: Add header line for next release.' \
 853     '* .prev-version: Record previous version.' \
 854     '* cfg.mk (old_NEWS_hash): Auto-update.'
 855 endef
 856
 857 .PHONY: alpha beta major
 858 alpha beta major: $(local-check) writable-files
 859         test $@ = major                                         \
 860           && { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \
 861                || { echo "invalid version string: $(VERSION)" 1>&2; exit 1;};}\
 862           || :
 863         $(MAKE) vc-dist
 864         $(MAKE) news-date-check
 865         $(MAKE) -s announcement RELEASE_TYPE=$@ > /tmp/announce-$(my_distdir)
 866         if test -d $(release_archive_dir); then                 \
 867           ln $(rel-files) $(release_archive_dir);               \
 868           chmod a-w $(rel-files);                               \
 869         fi
 870         $(MAKE) -s emit_upload_commands RELEASE_TYPE=$@
 871         echo $(VERSION) > $(prev_version_file)
 872         $(MAKE) update-NEWS-hash
 873         perl -pi -e '$$. == 3 and print "$(noteworthy)\n\n\n"' NEWS
 874         $(emit-commit-log) > .ci-msg
 875         $(VC) commit -F .ci-msg -a
 876
 877 .PHONY: web-manual
 878 web-manual:
 879         @test -z "$(manual_title)" \
 880           && { echo define manual_title in cfg.mk 1>&2; exit 1; } || :
 881         @cd '$(srcdir)/doc'; \
 882           $(SHELL) ../build-aux/gendocs.sh -o '$(abs_builddir)/doc/manual' \
 883              --email $(PACKAGE_BUGREPORT) $(PACKAGE) \
 884             "$(PACKAGE_NAME) - $(manual_title)"
 885         @echo " *** Upload the doc/manual directory to web-cvs."