ACPI: Work around IASL warning reading/writing same register
commitf77516cb6dcc4671938475926d2ee55952cd2eec
authorMartin Roth <martinroth@google.com>
Tue, 8 Dec 2015 21:00:07 +0000 (8 14:00 -0700)
committerMartin Roth <martinroth@google.com>
Thu, 10 Dec 2015 15:32:21 +0000 (10 16:32 +0100)
tree67dd2c2237ed9c55da4166d332817f90e28a08e4
parent91d9cbc2fbc62ede85e4eae07c52c43ffe7a4eb3
ACPI: Work around IASL warning reading/writing same register

The newer versions of IASL are unhappy when an operator
has the same object as both source and destination.

The warning can be completely disabled with a command
line argument, but in general, I'd really rather not
just disable warnings.

The bits in this register are write 1 to clear, so reading and
writing the same register is what we want to do.  Instead, store
it in a temporary register then write it in a second operation.

Fixes warning:
dsdt.aml   1396:  Store(PWST, PWST)
Warning  3023 -                 ^ Duplicate value in list
(Source is the same as Target)

Change-Id: I52d73d4431db237be83016d67cd397f31b53d9c6
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12691
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
36 files changed:
src/mainboard/advansus/a785e-i/dsdt.asl
src/mainboard/amd/bimini_fam10/dsdt.asl
src/mainboard/amd/dbm690t/dsdt.asl
src/mainboard/amd/inagua/acpi/sleep.asl
src/mainboard/amd/mahogany/dsdt.asl
src/mainboard/amd/mahogany_fam10/dsdt.asl
src/mainboard/amd/persimmon/acpi/sleep.asl
src/mainboard/amd/pistachio/dsdt.asl
src/mainboard/amd/south_station/acpi/sleep.asl
src/mainboard/amd/tilapia_fam10/dsdt.asl
src/mainboard/amd/union_station/acpi/sleep.asl
src/mainboard/asrock/e350m1/acpi/sleep.asl
src/mainboard/asus/kgpe-d16/acpi/pm_ctrl.asl
src/mainboard/asus/m4a78-em/dsdt.asl
src/mainboard/asus/m4a785-m/dsdt.asl
src/mainboard/asus/m4a785t-m/dsdt.asl
src/mainboard/asus/m5a88-v/dsdt.asl
src/mainboard/avalue/eax-785e/dsdt.asl
src/mainboard/gigabyte/ma785gm/dsdt.asl
src/mainboard/gigabyte/ma785gmt/dsdt.asl
src/mainboard/gigabyte/ma78gm/dsdt.asl
src/mainboard/gizmosphere/gizmo/acpi/sleep.asl
src/mainboard/iei/kino-780am2-fam10/dsdt.asl
src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl
src/mainboard/jetway/pa78vm5/dsdt.asl
src/mainboard/kontron/kt690/dsdt.asl
src/mainboard/lippert/frontrunner-af/dsdt.asl
src/mainboard/lippert/toucan-af/dsdt.asl
src/mainboard/pcengines/apu1/acpi/sleep.asl
src/mainboard/siemens/sitemp_g1p1/acpi/event.asl
src/mainboard/supermicro/h8qgi/dsdt.asl
src/mainboard/supermicro/h8scm/dsdt.asl
src/mainboard/supermicro/h8scm_fam10/dsdt.asl
src/mainboard/technexion/tim5690/dsdt.asl
src/mainboard/technexion/tim8690/dsdt.asl
src/mainboard/tyan/s8226/dsdt.asl