soc/amd/picasso: initialize ACP device at init() time
commita6e3b5ac093a4d9781fc83b75a14d1c47b92b6ef
authorAaron Durbin <adurbin@chromium.org>
Tue, 9 Jun 2020 13:56:43 +0000 (9 07:56 -0600)
committerAaron Durbin <adurbin@chromium.org>
Wed, 10 Jun 2020 16:23:16 +0000 (10 16:23 +0000)
tree9d98d5be8f200f05a712fdbfc0f685c6cc8eb0d3
parentcfc3c358b2686bebd936219c5fb3642b834780b2
soc/amd/picasso: initialize ACP device at init() time

The ACP device sits behind a bridge. Despite the logs indicating
the bridge is likely hooked up, there's some unusual behavior of
writes not sticking. Aside from the speculation of what's causing
the issues the initialization of the device should occur at init()
because of these potential dependencies.

BUG=b:155882600

Change-Id: I8fa83d7d1d4f356c56971d4175a2ae6497a92fb8
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42231
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
src/soc/amd/picasso/acp.c