device/pci_ops: Move questionable pci_locate() variants
commit8a41f4b71e883ec66be511cb592ee19dfa6708c5
authorKyösti Mälkki <kyosti.malkki@gmail.com>
Fri, 8 Feb 2019 16:14:34 +0000 (8 18:14 +0200)
committerKyösti Mälkki <kyosti.malkki@gmail.com>
Mon, 11 Feb 2019 11:34:37 +0000 (11 11:34 +0000)
treed0f7d8e47ed1dbe3b27038a0232f89aaff8d261d
parent5b14116a04b4b96d25f825bef8f34caf4bd51466
device/pci_ops: Move questionable pci_locate() variants

These are defined for __SIMPLE_DEVICE__ when PCI
enumeration has not happened yet. These should not
really try to probe devices other than those on bus 0.

It's hard to track but there maybe cases of southbridge
being located on bus 2 and available for configuration, so
I rather leave the code unchanged. Just move these out of
arch/io.h because they cause build failures if one attempts
to include <arch/pci_ops.h> before <arch/io.h>.

There are two direct copies for ROMCC bootblocks to
avoid inlining them elsewhere.

Change-Id: Ida2919a5d83fe5ea89284ffbd8ead382e4312524
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/31304
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
12 files changed:
src/arch/x86/include/arch/io.h
src/device/pci_early.c
src/include/device/pci.h
src/southbridge/amd/amd8111/bootblock.c
src/southbridge/amd/amd8111/reset.c
src/southbridge/amd/sb700/early_setup.c
src/southbridge/broadcom/bcm5785/bootblock.c
src/southbridge/intel/i82371eb/bootblock.c
src/southbridge/intel/i82371eb/early_pm.c
src/southbridge/intel/i82371eb/early_smbus.c
src/southbridge/nvidia/ck804/early_smbus.c
src/southbridge/nvidia/mcp55/early_smbus.c