| commit | 133fcb6469e37e2cc240cf1e7060922317a6c209 | |
| author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 13 Aug 2014 20:05:00 +0000 (13 20:05 +0000) | ||
| committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 13 Aug 2014 20:07:07 +0000 (13 20:07 +0000) | ||
| tree | 0e121eac6d59d2a180524823621c94d223c2f04c | treesnapshot (tar.gz zip) |
| parent | d245d35f9c694771f8c618e51999f64baa419628 | commitdiff |
Revert 289111 "Revert 288954 "[Sync] Don't synchronously stop da..."
> Revert 288954 "[Sync] Don't synchronously stop datatypes that en..."
>
> Reason for revert: see crbug.com/403098
>
> > [Sync] Don't synchronously stop datatypes that encounter errors
> >
> > The datatype logic may be operating unders assumptions that break when
> > the type is stopped from under it, possibly triggering crashes.
> >
> > BUG=402595,403098
> >
> > Review URL: https://codereview.chromium.org/462863002
>
> TBR=zea@chromium.org
>
> Review URL: https://codereview.chromium.org/467923002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/471683002
Cr-Commit-Position: refs/heads/master@{#289357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289357 0039d316-1c4b-4281-b951-d872f2087c98
> Revert 288954 "[Sync] Don't synchronously stop datatypes that en..."
>
> Reason for revert: see crbug.com/403098
>
> > [Sync] Don't synchronously stop datatypes that encounter errors
> >
> > The datatype logic may be operating unders assumptions that break when
> > the type is stopped from under it, possibly triggering crashes.
> >
> > BUG=402595,403098
> >
> > Review URL: https://codereview.chromium.org/462863002
>
> TBR=zea@chromium.org
>
> Review URL: https://codereview.chromium.org/467923002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/471683002
Cr-Commit-Position: refs/heads/master@{#289357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289357 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/sync/glue/frontend_data_type_controller.cc | diffblobblamehistory | |
| components/sync_driver/ui_data_type_controller.cc | diffblobblamehistory |