| commit | d245d35f9c694771f8c618e51999f64baa419628 | |
| author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 13 Aug 2014 20:02:39 +0000 (13 20:02 +0000) | ||
| committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 13 Aug 2014 20:03:51 +0000 (13 20:03 +0000) | ||
| tree | d1664ed81001f885b0f1402e70615288530b30aa | treesnapshot (tar.gz zip) |
| parent | 83ace11a5dc437373b64922eba77df845c0a8910 | commitdiff |
Revert 289113 "Revert 288557 "[Sync] Use OnSingleDataTypeUnrecov..."
> Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..."
>
> Reason for revert: see crbug.com/403098
>
> > [Sync] Use OnSingleDataTypeUnrecoverableError for all errors
> >
> > This removes the disable callback from all datatype controllers as well
> > as the DisableDataType method from the PSS, in favor of
> > OnSingleDataTypeUnrecoverable error (which now accepts a SyncError).
> >
> > BUG=368834,403098
> > TBR=bauerb@chromium.org
> >
> > Review URL: https://codereview.chromium.org/436733002
>
> TBR=zea@chromium.org
>
> Review URL: https://codereview.chromium.org/465113002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/469073002
Cr-Commit-Position: refs/heads/master@{#289356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289356 0039d316-1c4b-4281-b951-d872f2087c98
> Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..."
>
> Reason for revert: see crbug.com/403098
>
> > [Sync] Use OnSingleDataTypeUnrecoverableError for all errors
> >
> > This removes the disable callback from all datatype controllers as well
> > as the DisableDataType method from the PSS, in favor of
> > OnSingleDataTypeUnrecoverable error (which now accepts a SyncError).
> >
> > BUG=368834,403098
> > TBR=bauerb@chromium.org
> >
> > Review URL: https://codereview.chromium.org/436733002
>
> TBR=zea@chromium.org
>
> Review URL: https://codereview.chromium.org/465113002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/469073002
Cr-Commit-Position: refs/heads/master@{#289356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289356 0039d316-1c4b-4281-b951-d872f2087c98
60 files changed: