courgette/disassembler_win32_x64.cc

   1 // Copyright 2013 The Chromium Authors. All rights reserved.
   2 // Use of this source code is governed by a BSD-style license that can be
   3 // found in the LICENSE file.
   4
   5 #include "courgette/disassembler_win32_x64.h"
   6
   7 #include <algorithm>
   8 #include <string>
   9 #include <vector>
  10
  11 #include "base/basictypes.h"
  12 #include "base/logging.h"
  13 #include "base/numerics/safe_conversions.h"
  14
  15 #include "courgette/assembly_program.h"
  16 #include "courgette/courgette.h"
  17 #include "courgette/encoded_program.h"
  18
  19 namespace courgette {
  20
  21 DisassemblerWin32X64::DisassemblerWin32X64(const void* start, size_t length)
  22   : Disassembler(start, length),
  23     incomplete_disassembly_(false),
  24     is_PE32_plus_(false),
  25     optional_header_(NULL),
  26     size_of_optional_header_(0),
  27     offset_of_data_directories_(0),
  28     machine_type_(0),
  29     number_of_sections_(0),
  30     sections_(NULL),
  31     has_text_section_(false),
  32     size_of_code_(0),
  33     size_of_initialized_data_(0),
  34     size_of_uninitialized_data_(0),
  35     base_of_code_(0),
  36     base_of_data_(0),
  37     image_base_(0),
  38     size_of_image_(0),
  39     number_of_data_directories_(0) {
  40 }
  41
  42 // ParseHeader attempts to match up the buffer with the Windows data
  43 // structures that exist within a Windows 'Portable Executable' format file.
  44 // Returns 'true' if the buffer matches, and 'false' if the data looks
  45 // suspicious.  Rather than try to 'map' the buffer to the numerous windows
  46 // structures, we extract the information we need into the courgette::PEInfo
  47 // structure.
  48 //
  49 bool DisassemblerWin32X64::ParseHeader() {
  50   if (length() < kOffsetOfFileAddressOfNewExeHeader + 4 /*size*/)
  51     return Bad("Too small");
  52
  53   // Have 'MZ' magic for a DOS header?
  54   if (start()[0] != 'M' || start()[1] != 'Z')
  55     return Bad("Not MZ");
  56
  57   // offset from DOS header to PE header is stored in DOS header.
  58   uint32 offset = ReadU32(start(),
  59                           kOffsetOfFileAddressOfNewExeHeader);
  60
  61   if (offset >= length())
  62     return Bad("Bad offset to PE header");
  63
  64   const uint8* const pe_header = OffsetToPointer(offset);
  65   const size_t kMinPEHeaderSize = 4 /*signature*/ + kSizeOfCoffHeader;
  66   if (pe_header <= start() ||
  67       pe_header >= end() - kMinPEHeaderSize)
  68     return Bad("Bad offset to PE header");
  69
  70   if (offset % 8 != 0)
  71     return Bad("Misaligned PE header");
  72
  73   // The 'PE' header is an IMAGE_NT_HEADERS structure as defined in WINNT.H.
  74   // See http://msdn.microsoft.com/en-us/library/ms680336(VS.85).aspx
  75   //
  76   // The first field of the IMAGE_NT_HEADERS is the signature.
  77   if (!(pe_header[0] == 'P' &&
  78         pe_header[1] == 'E' &&
  79         pe_header[2] == 0 &&
  80         pe_header[3] == 0))
  81     return Bad("no PE signature");
  82
  83   // The second field of the IMAGE_NT_HEADERS is the COFF header.
  84   // The COFF header is also called an IMAGE_FILE_HEADER
  85   //   http://msdn.microsoft.com/en-us/library/ms680313(VS.85).aspx
  86   const uint8* const coff_header = pe_header + 4;
  87   machine_type_       = ReadU16(coff_header, 0);
  88   number_of_sections_ = ReadU16(coff_header, 2);
  89   size_of_optional_header_ = ReadU16(coff_header, 16);
  90
  91   // The rest of the IMAGE_NT_HEADERS is the IMAGE_OPTIONAL_HEADER(32|64)
  92   const uint8* const optional_header = coff_header + kSizeOfCoffHeader;
  93   optional_header_ = optional_header;
  94
  95   if (optional_header + size_of_optional_header_ >= end())
  96     return Bad("optional header past end of file");
  97
  98   // Check we can read the magic.
  99   if (size_of_optional_header_ < 2)
 100     return Bad("optional header no magic");
 101
 102   uint16 magic = ReadU16(optional_header, 0);
 103
 104   if (magic == kImageNtOptionalHdr32Magic) {
 105     is_PE32_plus_ = false;
 106     offset_of_data_directories_ =
 107       kOffsetOfDataDirectoryFromImageOptionalHeader32;
 108   } else if (magic == kImageNtOptionalHdr64Magic) {
 109     is_PE32_plus_ = true;
 110     offset_of_data_directories_ =
 111       kOffsetOfDataDirectoryFromImageOptionalHeader64;
 112   } else {
 113     return Bad("unrecognized magic");
 114   }
 115
 116   // Check that we can read the rest of the the fixed fields.  Data directories
 117   // directly follow the fixed fields of the IMAGE_OPTIONAL_HEADER.
 118   if (size_of_optional_header_ < offset_of_data_directories_)
 119     return Bad("optional header too short");
 120
 121   // The optional header is either an IMAGE_OPTIONAL_HEADER32 or
 122   // IMAGE_OPTIONAL_HEADER64
 123   // http://msdn.microsoft.com/en-us/library/ms680339(VS.85).aspx
 124   //
 125   // Copy the fields we care about.
 126   size_of_code_               = ReadU32(optional_header, 4);
 127   size_of_initialized_data_   = ReadU32(optional_header, 8);
 128   size_of_uninitialized_data_ = ReadU32(optional_header, 12);
 129   base_of_code_               = ReadU32(optional_header, 20);
 130   if (is_PE32_plus_) {
 131     base_of_data_ = 0;
 132     image_base_  = ReadU64(optional_header, 24);
 133   } else {
 134     base_of_data_ = ReadU32(optional_header, 24);
 135     image_base_   = ReadU32(optional_header, 28);
 136   }
 137   size_of_image_ = ReadU32(optional_header, 56);
 138   number_of_data_directories_ =
 139     ReadU32(optional_header, (is_PE32_plus_ ? 108 : 92));
 140
 141   if (size_of_code_ >= length() ||
 142       size_of_initialized_data_ >= length() ||
 143       size_of_code_ + size_of_initialized_data_ >= length()) {
 144     // This validation fires on some perfectly fine executables.
 145     //  return Bad("code or initialized data too big");
 146   }
 147
 148   // TODO(sra): we can probably get rid of most of the data directories.
 149   bool b = true;
 150   // 'b &= ...' could be short circuit 'b = b && ...' but it is not necessary
 151   // for correctness and it compiles smaller this way.
 152   b &= ReadDataDirectory(0, &export_table_);
 153   b &= ReadDataDirectory(1, &import_table_);
 154   b &= ReadDataDirectory(2, &resource_table_);
 155   b &= ReadDataDirectory(3, &exception_table_);
 156   b &= ReadDataDirectory(5, &base_relocation_table_);
 157   b &= ReadDataDirectory(11, &bound_import_table_);
 158   b &= ReadDataDirectory(12, &import_address_table_);
 159   b &= ReadDataDirectory(13, &delay_import_descriptor_);
 160   b &= ReadDataDirectory(14, &clr_runtime_header_);
 161   if (!b) {
 162     return Bad("malformed data directory");
 163   }
 164
 165   // Sections follow the optional header.
 166   sections_ =
 167       reinterpret_cast<const Section*>(optional_header +
 168                                        size_of_optional_header_);
 169   size_t detected_length = 0;
 170
 171   for (int i = 0;  i < number_of_sections_;  ++i) {
 172     const Section* section = &sections_[i];
 173
 174     // TODO(sra): consider using the 'characteristics' field of the section
 175     // header to see if the section contains instructions.
 176     if (memcmp(section->name, ".text", 6) == 0)
 177       has_text_section_ = true;
 178
 179     uint32 section_end =
 180         section->file_offset_of_raw_data + section->size_of_raw_data;
 181     if (section_end > detected_length)
 182       detected_length = section_end;
 183   }
 184
 185   // Pretend our in-memory copy is only as long as our detected length.
 186   ReduceLength(detected_length);
 187
 188   if (is_32bit()) {
 189     return Bad("32 bit executables are not supported by this disassembler");
 190   }
 191
 192   if (!has_text_section()) {
 193     return Bad("Resource-only executables are not yet supported");
 194   }
 195
 196   return Good();
 197 }
 198
 199 bool DisassemblerWin32X64::Disassemble(AssemblyProgram* target) {
 200   if (!ok())
 201     return false;
 202
 203   target->set_image_base(image_base());
 204
 205   if (!ParseAbs32Relocs())
 206     return false;
 207
 208   ParseRel32RelocsFromSections();
 209
 210   if (!ParseFile(target))
 211     return false;
 212
 213   target->DefaultAssignIndexes();
 214
 215   return true;
 216 }
 217
 218 ////////////////////////////////////////////////////////////////////////////////
 219
 220 bool DisassemblerWin32X64::ParseRelocs(std::vector<RVA> *relocs) {
 221   relocs->clear();
 222
 223   size_t relocs_size = base_relocation_table_.size_;
 224   if (relocs_size == 0)
 225     return true;
 226
 227   // The format of the base relocation table is a sequence of variable sized
 228   // IMAGE_BASE_RELOCATION blocks.  Search for
 229   //   "The format of the base relocation data is somewhat quirky"
 230   // at http://msdn.microsoft.com/en-us/library/ms809762.aspx
 231
 232   const uint8* relocs_start = RVAToPointer(base_relocation_table_.address_);
 233   const uint8* relocs_end = relocs_start + relocs_size;
 234
 235   // Make sure entire base relocation table is within the buffer.
 236   if (relocs_start < start() ||
 237       relocs_start >= end() ||
 238       relocs_end <= start() ||
 239       relocs_end > end()) {
 240     return Bad(".relocs outside image");
 241   }
 242
 243   const uint8* block = relocs_start;
 244
 245   // Walk the variable sized blocks.
 246   while (block + 8 < relocs_end) {
 247     RVA page_rva = ReadU32(block, 0);
 248     uint32 size = ReadU32(block, 4);
 249     if (size < 8 ||        // Size includes header ...
 250         size % 4  !=  0)   // ... and is word aligned.
 251       return Bad("unreasonable relocs block");
 252
 253     const uint8* end_entries = block + size;
 254
 255     if (end_entries <= block ||
 256         end_entries <= start() ||
 257         end_entries > end())
 258       return Bad(".relocs block outside image");
 259
 260     // Walk through the two-byte entries.
 261     for (const uint8* p = block + 8;  p < end_entries;  p += 2) {
 262       uint16 entry = ReadU16(p, 0);
 263       int type = entry >> 12;
 264       int offset = entry & 0xFFF;
 265
 266       RVA rva = page_rva + offset;
 267       // TODO(sebmarchand): Skip the relocs that live outside of the image. See
 268       //   the version of this function in disassembler_win32_x86.cc.
 269       if (type == 10) {         // IMAGE_REL_BASED_DIR64
 270         relocs->push_back(rva);
 271       } else if (type == 0) {  // IMAGE_REL_BASED_ABSOLUTE
 272         // Ignore, used as padding.
 273       } else {
 274         // Does not occur in Windows x64 executables.
 275         return Bad("unknown type of reloc");
 276       }
 277     }
 278
 279     block += size;
 280   }
 281
 282   std::sort(relocs->begin(), relocs->end());
 283
 284   return true;
 285 }
 286
 287 const Section* DisassemblerWin32X64::RVAToSection(RVA rva) const {
 288   for (int i = 0; i < number_of_sections_; i++) {
 289     const Section* section = &sections_[i];
 290     uint32 offset = rva - section->virtual_address;
 291     if (offset < section->virtual_size) {
 292       return section;
 293     }
 294   }
 295   return NULL;
 296 }
 297
 298 int DisassemblerWin32X64::RVAToFileOffset(RVA rva) const {
 299   const Section* section = RVAToSection(rva);
 300   if (section) {
 301     uint32 offset = rva - section->virtual_address;
 302     if (offset < section->size_of_raw_data) {
 303       return section->file_offset_of_raw_data + offset;
 304     } else {
 305       return kNoOffset;  // In section but not in file (e.g. uninit data).
 306     }
 307   }
 308
 309   // Small RVA values point into the file header in the loaded image.
 310   // RVA 0 is the module load address which Windows uses as the module handle.
 311   // RVA 2 sometimes occurs, I'm not sure what it is, but it would map into the
 312   // DOS header.
 313   if (rva == 0 || rva == 2)
 314     return rva;
 315
 316   NOTREACHED();
 317   return kNoOffset;
 318 }
 319
 320 const uint8* DisassemblerWin32X64::RVAToPointer(RVA rva) const {
 321   int file_offset = RVAToFileOffset(rva);
 322   if (file_offset == kNoOffset)
 323     return NULL;
 324   else
 325     return OffsetToPointer(file_offset);
 326 }
 327
 328 std::string DisassemblerWin32X64::SectionName(const Section* section) {
 329   if (section == NULL)
 330     return "<none>";
 331   char name[9];
 332   memcpy(name, section->name, 8);
 333   name[8] = '\0';  // Ensure termination.
 334   return name;
 335 }
 336
 337 CheckBool DisassemblerWin32X64::ParseFile(AssemblyProgram* program) {
 338   // Walk all the bytes in the file, whether or not in a section.
 339   uint32 file_offset = 0;
 340   while (file_offset < length()) {
 341     const Section* section = FindNextSection(file_offset);
 342     if (section == NULL) {
 343       // No more sections.  There should not be extra stuff following last
 344       // section.
 345       //   ParseNonSectionFileRegion(file_offset, pe_info().length(), program);
 346       break;
 347     }
 348     if (file_offset < section->file_offset_of_raw_data) {
 349       uint32 section_start_offset = section->file_offset_of_raw_data;
 350       if(!ParseNonSectionFileRegion(file_offset, section_start_offset,
 351                                     program))
 352         return false;
 353
 354       file_offset = section_start_offset;
 355     }
 356     uint32 end = file_offset + section->size_of_raw_data;
 357     if (!ParseFileRegion(section, file_offset, end, program))
 358       return false;
 359     file_offset = end;
 360   }
 361
 362 #if COURGETTE_HISTOGRAM_TARGETS
 363   HistogramTargets("abs32 relocs", abs32_target_rvas_);
 364   HistogramTargets("rel32 relocs", rel32_target_rvas_);
 365 #endif
 366
 367   return true;
 368 }
 369
 370 bool DisassemblerWin32X64::ParseAbs32Relocs() {
 371   abs32_locations_.clear();
 372   if (!ParseRelocs(&abs32_locations_))
 373     return false;
 374
 375   std::sort(abs32_locations_.begin(), abs32_locations_.end());
 376
 377 #if COURGETTE_HISTOGRAM_TARGETS
 378   for (size_t i = 0;  i < abs32_locations_.size(); ++i) {
 379     RVA rva = abs32_locations_[i];
 380     // The 4 bytes at the relocation are a reference to some address.
 381     uint32 target_address = Read32LittleEndian(RVAToPointer(rva));
 382     ++abs32_target_rvas_[target_address - image_base()];
 383   }
 384 #endif
 385   return true;
 386 }
 387
 388 void DisassemblerWin32X64::ParseRel32RelocsFromSections() {
 389   uint32 file_offset = 0;
 390   while (file_offset < length()) {
 391     const Section* section = FindNextSection(file_offset);
 392     if (section == NULL)
 393       break;
 394     if (file_offset < section->file_offset_of_raw_data)
 395       file_offset = section->file_offset_of_raw_data;
 396     ParseRel32RelocsFromSection(section);
 397     file_offset += section->size_of_raw_data;
 398   }
 399   std::sort(rel32_locations_.begin(), rel32_locations_.end());
 400
 401 #if COURGETTE_HISTOGRAM_TARGETS
 402   VLOG(1) << "abs32_locations_ " << abs32_locations_.size()
 403           << "\nrel32_locations_ " << rel32_locations_.size()
 404           << "\nabs32_target_rvas_ " << abs32_target_rvas_.size()
 405           << "\nrel32_target_rvas_ " << rel32_target_rvas_.size();
 406
 407   int common = 0;
 408   std::map<RVA, int>::iterator abs32_iter = abs32_target_rvas_.begin();
 409   std::map<RVA, int>::iterator rel32_iter = rel32_target_rvas_.begin();
 410   while (abs32_iter != abs32_target_rvas_.end() &&
 411          rel32_iter != rel32_target_rvas_.end()) {
 412     if (abs32_iter->first < rel32_iter->first)
 413       ++abs32_iter;
 414     else if (rel32_iter->first < abs32_iter->first)
 415       ++rel32_iter;
 416     else {
 417       ++common;
 418       ++abs32_iter;
 419       ++rel32_iter;
 420     }
 421   }
 422   VLOG(1) << "common " << common;
 423 #endif
 424 }
 425
 426 void DisassemblerWin32X64::ParseRel32RelocsFromSection(const Section* section) {
 427   // TODO(sra): use characteristic.
 428   bool isCode = strcmp(section->name, ".text") == 0;
 429   if (!isCode)
 430     return;
 431
 432   uint32 start_file_offset = section->file_offset_of_raw_data;
 433   uint32 end_file_offset = start_file_offset + section->size_of_raw_data;
 434   RVA relocs_start_rva = base_relocation_table().address_;
 435
 436   const uint8* start_pointer = OffsetToPointer(start_file_offset);
 437   const uint8* end_pointer = OffsetToPointer(end_file_offset);
 438
 439   RVA start_rva = FileOffsetToRVA(start_file_offset);
 440   RVA end_rva = start_rva + section->virtual_size;
 441
 442   // Quick way to convert from Pointer to RVA within a single Section is to
 443   // subtract 'pointer_to_rva'.
 444   const uint8* const adjust_pointer_to_rva = start_pointer - start_rva;
 445
 446   std::vector<RVA>::iterator abs32_pos = abs32_locations_.begin();
 447
 448   // Find the rel32 relocations.
 449   const uint8* p = start_pointer;
 450   while (p < end_pointer) {
 451     RVA current_rva = static_cast<RVA>(p - adjust_pointer_to_rva);
 452     if (current_rva == relocs_start_rva) {
 453       uint32 relocs_size = base_relocation_table().size_;
 454       if (relocs_size) {
 455         p += relocs_size;
 456         continue;
 457       }
 458     }
 459
 460     //while (abs32_pos != abs32_locations_.end() && *abs32_pos < current_rva)
 461     //  ++abs32_pos;
 462
 463     // Heuristic discovery of rel32 locations in instruction stream: are the
 464     // next few bytes the start of an instruction containing a rel32
 465     // addressing mode?
 466     const uint8* rel32 = NULL;
 467     bool is_rip_relative = false;
 468
 469     if (p + 5 <= end_pointer) {
 470       if (*p == 0xE8 || *p == 0xE9)  // jmp rel32 and call rel32
 471         rel32 = p + 1;
 472     }
 473     if (p + 6 <= end_pointer) {
 474       if (*p == 0x0F && (*(p + 1) & 0xF0) == 0x80) {  // Jcc long form
 475         if (p[1] != 0x8A && p[1] != 0x8B)  // JPE/JPO unlikely
 476           rel32 = p + 2;
 477       } else if (*p == 0xFF && (*(p + 1) == 0x15 || *(p + 1) == 0x25)) {
 478         // rip relative call/jmp
 479         rel32 = p + 2;
 480         is_rip_relative = true;
 481       }
 482     }
 483     if (p + 7 <= end_pointer) {
 484       if ((*p & 0xFB) == 0x48 && *(p + 1) == 0x8D &&
 485           (*(p + 2) & 0xC7) == 0x05) {
 486         // rip relative lea
 487         rel32 = p + 3;
 488         is_rip_relative = true;
 489       } else if ((*p & 0xFB) == 0x48 && *(p + 1) == 0x8B &&
 490                  (*(p + 2) & 0xC7) == 0x05) {
 491         // rip relative mov
 492         rel32 = p + 3;
 493         is_rip_relative = true;
 494       }
 495     }
 496
 497     if (rel32) {
 498       RVA rel32_rva = static_cast<RVA>(rel32 - adjust_pointer_to_rva);
 499
 500       // Is there an abs32 reloc overlapping the candidate?
 501       while (abs32_pos != abs32_locations_.end() && *abs32_pos < rel32_rva - 3)
 502         ++abs32_pos;
 503       // Now: (*abs32_pos > rel32_rva - 4) i.e. the lowest addressed 4-byte
 504       // region that could overlap rel32_rva.
 505       if (abs32_pos != abs32_locations_.end()) {
 506         if (*abs32_pos < rel32_rva + 4) {
 507           // Beginning of abs32 reloc is before end of rel32 reloc so they
 508           // overlap.  Skip four bytes past the abs32 reloc.
 509           p += (*abs32_pos + 4) - current_rva;
 510           continue;
 511         }
 512       }
 513
 514       RVA target_rva = rel32_rva + 4 + Read32LittleEndian(rel32);
 515       // To be valid, rel32 target must be within image, and within this
 516       // section.
 517       if (IsValidRVA(target_rva) &&
 518           (is_rip_relative ||
 519            (start_rva <= target_rva && target_rva < end_rva))) {
 520         rel32_locations_.push_back(rel32_rva);
 521 #if COURGETTE_HISTOGRAM_TARGETS
 522         ++rel32_target_rvas_[target_rva];
 523 #endif
 524         p = rel32 + 4;
 525         continue;
 526       }
 527     }
 528     p += 1;
 529   }
 530 }
 531
 532 CheckBool DisassemblerWin32X64::ParseNonSectionFileRegion(
 533     uint32 start_file_offset,
 534     uint32 end_file_offset,
 535     AssemblyProgram* program) {
 536   if (incomplete_disassembly_)
 537     return true;
 538
 539   if (end_file_offset > start_file_offset) {
 540     if (!program->EmitBytesInstruction(OffsetToPointer(start_file_offset),
 541                                        end_file_offset - start_file_offset)) {
 542       return false;
 543     }
 544   }
 545
 546   return true;
 547 }
 548
 549 CheckBool DisassemblerWin32X64::ParseFileRegion(
 550     const Section* section,
 551     uint32 start_file_offset, uint32 end_file_offset,
 552     AssemblyProgram* program) {
 553   RVA relocs_start_rva = base_relocation_table().address_;
 554
 555   const uint8* start_pointer = OffsetToPointer(start_file_offset);
 556   const uint8* end_pointer = OffsetToPointer(end_file_offset);
 557
 558   RVA start_rva = FileOffsetToRVA(start_file_offset);
 559   RVA end_rva = start_rva + section->virtual_size;
 560
 561   // Quick way to convert from Pointer to RVA within a single Section is to
 562   // subtract 'pointer_to_rva'.
 563   const uint8* const adjust_pointer_to_rva = start_pointer - start_rva;
 564
 565   std::vector<RVA>::iterator rel32_pos = rel32_locations_.begin();
 566   std::vector<RVA>::iterator abs32_pos = abs32_locations_.begin();
 567
 568   if (!program->EmitOriginInstruction(start_rva))
 569     return false;
 570
 571   const uint8* p = start_pointer;
 572
 573   while (p < end_pointer) {
 574     RVA current_rva = static_cast<RVA>(p - adjust_pointer_to_rva);
 575
 576     // The base relocation table is usually in the .relocs section, but it could
 577     // actually be anywhere.  Make sure we skip it because we will regenerate it
 578     // during assembly.
 579     if (current_rva == relocs_start_rva) {
 580       if (!program->EmitPeRelocsInstruction())
 581         return false;
 582       uint32 relocs_size = base_relocation_table().size_;
 583       if (relocs_size) {
 584         p += relocs_size;
 585         continue;
 586       }
 587     }
 588
 589     while (abs32_pos != abs32_locations_.end() && *abs32_pos < current_rva)
 590       ++abs32_pos;
 591
 592     if (abs32_pos != abs32_locations_.end() && *abs32_pos == current_rva) {
 593       uint64 target_address = Read64LittleEndian(p);
 594       RVA target_rva = base::checked_cast<RVA>(target_address - image_base());
 595       // TODO(sra): target could be Label+offset.  It is not clear how to guess
 596       // which it might be.  We assume offset==0.
 597       if (!program->EmitAbs64(program->FindOrMakeAbs32Label(target_rva)))
 598         return false;
 599       p += 8;
 600       continue;
 601     }
 602
 603     while (rel32_pos != rel32_locations_.end() && *rel32_pos < current_rva)
 604       ++rel32_pos;
 605
 606     if (rel32_pos != rel32_locations_.end() && *rel32_pos == current_rva) {
 607       RVA target_rva = current_rva + 4 + Read32LittleEndian(p);
 608       if (!program->EmitRel32(program->FindOrMakeRel32Label(target_rva)))
 609         return false;
 610       p += 4;
 611       continue;
 612     }
 613
 614     if (incomplete_disassembly_) {
 615       if ((abs32_pos == abs32_locations_.end() || end_rva <= *abs32_pos) &&
 616           (rel32_pos == rel32_locations_.end() || end_rva <= *rel32_pos) &&
 617           (end_rva <= relocs_start_rva || current_rva >= relocs_start_rva)) {
 618         // No more relocs in this section, don't bother encoding bytes.
 619         break;
 620       }
 621     }
 622
 623     if (!program->EmitByteInstruction(*p))
 624       return false;
 625     p += 1;
 626   }
 627
 628   return true;
 629 }
 630
 631 #if COURGETTE_HISTOGRAM_TARGETS
 632 // Histogram is printed to std::cout.  It is purely for debugging the algorithm
 633 // and is only enabled manually in 'exploration' builds.  I don't want to add
 634 // command-line configuration for this feature because this code has to be
 635 // small, which means compiled-out.
 636 void DisassemblerWin32X64::HistogramTargets(const char* kind,
 637                                             const std::map<RVA, int>& map) {
 638   int total = 0;
 639   std::map<int, std::vector<RVA> > h;
 640   for (std::map<RVA, int>::const_iterator p = map.begin();
 641        p != map.end();
 642        ++p) {
 643     h[p->second].push_back(p->first);
 644     total += p->second;
 645   }
 646
 647   std::cout << total << " " << kind << " to "
 648             << map.size() << " unique targets" << std::endl;
 649
 650   std::cout << "indegree: #targets-with-indegree (example)" << std::endl;
 651   const int kFirstN = 15;
 652   bool someSkipped = false;
 653   int index = 0;
 654   for (std::map<int, std::vector<RVA> >::reverse_iterator p = h.rbegin();
 655        p != h.rend();
 656        ++p) {
 657     ++index;
 658     if (index <= kFirstN || p->first <= 3) {
 659       if (someSkipped) {
 660         std::cout << "..." << std::endl;
 661       }
 662       size_t count = p->second.size();
 663       std::cout << std::dec << p->first << ": " << count;
 664       if (count <= 2) {
 665         for (size_t i = 0;  i < count;  ++i)
 666           std::cout << "  " << DescribeRVA(p->second[i]);
 667       }
 668       std::cout << std::endl;
 669       someSkipped = false;
 670     } else {
 671       someSkipped = true;
 672     }
 673   }
 674 }
 675 #endif  // COURGETTE_HISTOGRAM_TARGETS
 676
 677
 678 // DescribeRVA is for debugging only.  I would put it under #ifdef DEBUG except
 679 // that during development I'm finding I need to call it when compiled in
 680 // Release mode.  Hence:
 681 // TODO(sra): make this compile only for debug mode.
 682 std::string DisassemblerWin32X64::DescribeRVA(RVA rva) const {
 683   const Section* section = RVAToSection(rva);
 684   std::ostringstream s;
 685   s << std::hex << rva;
 686   if (section) {
 687     s << " (";
 688     s << SectionName(section) << "+"
 689       << std::hex << (rva - section->virtual_address)
 690       << ")";
 691   }
 692   return s.str();
 693 }
 694
 695 const Section* DisassemblerWin32X64::FindNextSection(uint32 fileOffset) const {
 696   const Section* best = 0;
 697   for (int i = 0; i < number_of_sections_; i++) {
 698     const Section* section = &sections_[i];
 699     if (section->size_of_raw_data > 0) {  // i.e. has data in file.
 700       if (fileOffset <= section->file_offset_of_raw_data) {
 701         if (best == 0 ||
 702             section->file_offset_of_raw_data < best->file_offset_of_raw_data) {
 703           best = section;
 704         }
 705       }
 706     }
 707   }
 708   return best;
 709 }
 710
 711 RVA DisassemblerWin32X64::FileOffsetToRVA(uint32 file_offset) const {
 712   for (int i = 0; i < number_of_sections_; i++) {
 713     const Section* section = &sections_[i];
 714     uint32 offset = file_offset - section->file_offset_of_raw_data;
 715     if (offset < section->size_of_raw_data) {
 716       return section->virtual_address + offset;
 717     }
 718   }
 719   return 0;
 720 }
 721
 722 bool DisassemblerWin32X64::ReadDataDirectory(
 723     int index,
 724     ImageDataDirectory* directory) {
 725
 726   if (index < number_of_data_directories_) {
 727     size_t offset = index * 8 + offset_of_data_directories_;
 728     if (offset >= size_of_optional_header_)
 729       return Bad("number of data directories inconsistent");
 730     const uint8* data_directory = optional_header_ + offset;
 731     if (data_directory < start() ||
 732         data_directory + 8 >= end())
 733       return Bad("data directory outside image");
 734     RVA rva = ReadU32(data_directory, 0);
 735     size_t size  = ReadU32(data_directory, 4);
 736     if (size > size_of_image_)
 737       return Bad("data directory size too big");
 738
 739     // TODO(sra): validate RVA.
 740     directory->address_ = rva;
 741     directory->size_ = static_cast<uint32>(size);
 742     return true;
 743   } else {
 744     directory->address_ = 0;
 745     directory->size_ = 0;
 746     return true;
 747   }
 748 }
 749
 750 }  // namespace courgette