1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
5 """Top-level presubmit script for isolate.
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl.
12 def CommonChecks(input_api
, output_api
):
15 'F0401', # Unable to import module
16 'R0401', # Cyclic import
17 'W0613', # Unused argument
18 'E1103', # subprocess.communicate() generates these :(
19 'R0201', # method could be function (doesn't reference self)
22 r
'src[\\\/]build_tools[\\\/]tests[\\\/].*',
23 r
'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*',
25 canned
= input_api
.canned_checks
26 output
.extend(canned
.RunPylint(input_api
, output_api
, black_list
=black_list
,
27 disabled_warnings
=disabled_warnings
))
31 def CheckChangeOnUpload(input_api
, output_api
):
32 return CommonChecks(input_api
, output_api
)
35 def CheckChangeOnCommit(input_api
, output_api
):
36 return CommonChecks(input_api
, output_api
)
39 def GetPreferredTrySlaves(project
, change
):
40 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk']