1 2007-02-06 Brian Warner <warner@lothar.com>
3 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
4 see any Builders that don't have Schedulers to drive them
6 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
7 attributes this uses went away
9 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
10 dialog, to allow you to reset the buildmaster and force
11 connect/disconnect. Correctly handle losing the buildmaster
12 connection (by switching the display to the hexnut, at which point
13 you can use the 'Connect' menu item to reconnect).
15 * buildbot/steps/source.py (Source.start): if we're using a patch,
16 add it as a LogFile to the checkout/update step. This will turn
17 into a link on the waterfall page.
19 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
20 option, to take the patch from a pre-made file rather than
21 generating it from the local tree. Thanks to Robert Helmer for the
22 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
23 * buildbot/scripts/runner.py (TryOptions): add --diff,
24 --patchlevel, and --baserev options
25 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
26 as None, meaning HEAD.
27 * buildbot/sourcestamp.py (SourceStamp): update docstring to
28 indicate that baserev=None means HEAD
29 * docs/buildbot.texinfo (try --diff): document it
31 * buildbot/test/test_steps.py (BuildStep): remove use of
32 reactor.iterate(), although the technique I replaced it with is a
33 gross polling hack that must be cleaned up properly some day. This
34 was the last use of reactor.iterate in the entire tree, yay.
36 2007-02-05 Brian Warner <warner@lothar.com>
38 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
39 is one of the three known values, otherwise we emit some confusing
40 messages later on. Thanks to Grig Gheorghiu for the catch.
42 2007-01-30 Brian Warner <warner@lothar.com>
44 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
45 Hearsum contributed a patch to let BonsaiPoller work with results
46 that contain non-ascii characters. Closes SF#1632641.
48 2007-01-27 Brian Warner <warner@lothar.com>
50 * Makefile (release): produce both .tar.gz and .zip source bundles.
53 2007-01-23 Brian Warner <warner@lothar.com>
55 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
56 * buildbot/changes/monotone.py: same
58 * buildbot/changes/maildir.py: combine several files into one,
59 clean up maildir.py to use Services properly.
60 * buildbot/changes/maildirtwisted.py: remove
61 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
63 * buildbot/changes/mail.py: match the change
64 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
65 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
67 * buildbot/slave/commands.py (command_version): bump to "2.3" to
68 indicate that the buildslave knows about the 'bzr' command
70 2007-01-22 Brian Warner <warner@lothar.com>
72 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
73 'with', it will become a reserved work in python2.6 .
75 * contrib/bb_applet.py: add a simple gnome-panel applet, to
76 display a terse summary of buildbot status.
77 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
78 some icons, small versions of the Blender object that lives in
79 docs/images/icon.blend
81 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
82 * buildbot/slave/commands.py (Bzr): same
83 * buildbot/scripts/tryclient.py (BzrExtractor): same
84 (SourceStampExtractor.dovc): modify this to allow non-zero exit
85 status, since 'bzr diff' does that
86 * buildbot/test/test_vc.py (Bzr): same
87 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
91 2007-01-20 Brian Warner <warner@lothar.com>
93 * contrib/darcs_buildbot.py: tidy up the progress messages
95 2007-01-17 Brian Warner <warner@lothar.com>
97 * contrib/darcs_buildbot.py: enhance to handle multiple patches
98 being pushed at a time. This keeps state in the repository in a
99 small file named .darcs_buildbot-lastchange, but that shouldn't
100 interfere with normal repository operations. Fixes SF#1534049.
101 * buildbot/clients/sendchange.py (Sender): make a single Sender
102 capable of sending Changes with different usernames.
104 2006-12-11 Brian Warner <warner@lothar.com>
106 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
107 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
108 buildbot.changes.mail a long time ago, but I forgot to add the
109 DeprecationWarning until now.
111 * buildbot/process/maxq.py: remove this, the functionality now
112 lives in buildbot.steps.maxq
114 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
115 * buildbot/clients/gtkPanes.py: remove unused import
117 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
118 that was meant to provide a special Reporter to run inside trial
119 and give the buildslave lots of machine-readable status. We never
120 finished this project.
122 * buildbot/changes/bonsaipoller.py: remove unused imports
123 * buildbot/changes/svnpoller.py: same
124 * buildbot/process/builder.py: same
125 * buildbot/process/buildstep.py: same
126 * buildbot/slave/bot.py: hush pyflakes warning
127 * buildbot/status/tests.py: remove unused imports
128 * buildbot/status/tinderbox.py: same
129 * buildbot/steps/python_twisted.py: same
131 * buildbot/process/step.py: remove this file, these names were
132 deprecated in 0.7.5 and are now being removed.
133 * buildbot/process/step_twisted.py: same
134 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
136 * buildbot/twcompat.py: remove the empty file, yay it is gone
138 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
139 tw-2.0.0 and newer have the method we need.
140 (getProcessOutputAndValue): same
141 (which): remove this method, tw-2.0.0 t.p.procutils has it
143 * buildbot/twcompat.py (implements): remove this method
144 * buildbot/*: import implements() from zope.interface directly
146 * buildbot/status/mail.py: stop falling back to importing
147 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
150 * buildbot/twcompat.py (Interface): remove this import
151 * buildbot/*: import Interface from zope.interface directly
153 * buildbot/twcompat.py (providedBy): remove this method
154 * buildbot/*: turn all uses of providedBy(obj, iface) into
155 iface.providedBy(obj)
157 * buildbot/twcompat.py (maybeWait): remove this method, now that
158 we no longer maintain compatibility with Twisted<=1.3.0 .
159 Twisted-2.0.0 and later allow trial methods to return Deferreds
161 * buildbot/test/*: remove all uses of maybeWait
163 * buildbot/__init__.py (version): bump to 0.7.5+ while between
165 * docs/buildbot.texinfo: same
167 2006-12-10 Brian Warner <warner@lothar.com>
169 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
170 * docs/buildbot.texinfo: set version to match
172 2006-12-10 Brian Warner <warner@lothar.com>
174 * README (REQUIREMENTS): update for release
175 * NEWS: update for release
176 * buildbot/slave/commands.py (command_version): mention that this
177 version (2.2) was released with buildbot-0.7.5
179 * buildbot/test/test_config.py (StartService.testStartService):
180 inhibit the usual read-config-on-startup behavior, since otherwise
181 the log.err that gets recorded causes the test to fail
183 * buildbot/status/builder.py (LogFile.finish): forget about all
184 subscribers once the log has finished, since after that point
185 we're never going to use them again. This might help free up some
188 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
189 than the old/deprecated gtk.mainquit()
191 2006-12-09 Brian Warner <warner@lothar.com>
193 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
194 better when we can't open the masterdst file
196 * buildbot/scripts/startup.py (Follower._failure): add missing
197 import statement for BuildSlaveDetectedError
199 * buildbot/steps/transfer.py (FileUpload): cleanup
200 (FileDownload): same. Add tests for slave version, add mode=.
201 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
202 (SlaveFileDownloadCommand): same
203 * buildbot/test/test_transfer.py: enhance tests
204 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
207 2006-12-08 Brian Warner <warner@lothar.com>
209 * buildbot/scripts/runner.py (sendchange): halt the reactor on
210 both success *and* failure. Without this, the 'buildbot
211 sendchange' command would hang if it could not contact the
212 buildmaster or deliver the Change, which would generally cause the
213 user's commit/record/checkin command to hang too. Thanks to
214 Christian Unger for the catch.
216 2006-12-06 Brian Warner <warner@lothar.com>
218 * NEWS: update with items for the next release
220 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
221 whimsical example pulled from a punch-drunk email I sent out late
223 (Transferring Files): document some of the other parameters
224 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
225 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
226 * buildbot/test/test_svnpoller.py: same
227 * buildbot/changes/svnpoller.py (SVNPoller): same
229 2006-11-26 Brian Warner <warner@lothar.com>
231 * docs/buildbot.texinfo (Build Properties): remind users that
232 WithProperties must appear in a command= list, not as a top-level
234 * buildbot/steps/shell.py (ShellCommand.start): and assert that
235 we're sending a list or a single string to the RemoteShellCommand
237 * buildbot/scheduler.py (Nightly): Improve docs slightly.
239 * buildbot/scripts/startup.py (start): skip the whole
240 watch-the-logfile thing under windows, since it needs os.fork()
242 * buildbot/scripts/runner.py (restart): remove the old message
243 that got printed after the buildbot was restarted.. it most cases
244 it didn't get printed at the right time anyways
246 2006-11-25 Brian Warner <warner@lothar.com>
248 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
249 follow twistd.log and print lines until the process has started
250 started properly. For the buildmaster, this means until the config
251 file has been parsed and accepted. For the buildslave, this means
252 until we've connected to the master. We give up after 5 seconds in
253 any case. Helpful error messages and troubleshooting suggestions
254 are printed when we don't see a successful startup. This closes the
255 remainder of SF#1517975.
256 * buildbot/scripts/startup.py: moved app startup code to here
257 * buildbot/scripts/logwatcher.py: utility class to follow log
258 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
259 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
260 so the LogWatcher can tell the difference between a buildmaster
263 2006-11-24 Brian Warner <warner@lothar.com>
265 * docs/examples/twisted_master.cfg: update to match the version
266 in use on twistedmatrix.com
267 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
268 was using before stopped working, but 'irc.freenode.net' works
271 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
274 * buildbot/clients/base.py (TextClient.not_connected): upon
275 UnauthorizedLogin failures, remind the user to connect to the
276 PBListener port instead of the slaveport.
277 (TextClient.disconnected): shut down more quietly
278 * docs/buildbot.texinfo (statuslog): add another reminder
280 * buildbot/scripts/runner.py (Options.subCommands): rename
281 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
282 'sighup' as an alias.
283 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
284 reconfig command to follow twistd.log and print all of the lines
285 from the start of the config-file reload to its completion. This
286 should make it a lot easier to discover bugs in the config file.
287 Use --quiet to disable this behavior. This addresses half of
288 SF#1517975, the other half will be to add this same utility to
289 'buildbot start' and 'buildbot restart'.
290 * docs/buildbot.texinfo (Loading the Config File): same
293 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
294 method, it has been deprecated for a long time. Use
295 IBuilderControl.requestBuild instead.
296 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
297 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
298 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
299 * buildbot/test/test_control.py (Force.testForce): same
300 * buildbot/test/test_run.py: use requestBuild instead
302 * buildbot/clients/debug.py: replace 'Force Build' button with
303 'Request Build' (which just adds one to the queue), add Ping
304 Builder, add branch/revision fields to Request Build.
305 * buildbot/clients/debug.glade: same
306 * buildbot/master.py: update interface to match. This creates an
307 incompatibility between new debugclients and old buildmasters.
309 * buildbot/process/builder.py (Builder._attached): delay the call
310 to maybeStartBuild for a reactor turn, to avoid starting a build
311 in the middle of a reconfig (say, if the new Builder uses a new
312 slave which is already connected).
314 2006-11-23 Brian Warner <warner@lothar.com>
316 * buildbot/test/test_transfer.py: appease pyflakes
317 * buildbot/test/test_steps.py: same
319 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
320 keeps pyflakes from finding undefined names
322 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
323 Builder no longer induces a disconnect/reconnect cycle. This means
324 that any builds currently in progress will not be interrupted, and
325 any builds which are queued in the Builder will not be lost. This
326 is implemented by having the new Builder extract the state (i.e.
327 all pending Builds and any desired SlaveBuilders) from the old
329 (BotPerspective): refactor. The BotPerspective no longer keeps
330 track of all the Builders that want to use this slave; instead, it
331 asks the BotMaster each time it needs this list. This removes
332 addBuilder and removeBuilder. Clean up attached() to acquire all
333 the slave's information in a more atomic fashion. updateSlave() is
334 now the way to make sure the slave is using the right set of
335 Builders: just call it after everything else has been
337 (BotMaster): refactor, removing addBuilder/removeBuilder and
338 replacing them with an all-at-once setBuilders() call.
340 * buildbot/test/test_slaves.py (Reconfig): new test case to
341 exercise this functionality
342 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
343 * buildbot/slave/commands.py (WaitCommand): same
345 * docs/buildbot.texinfo (Loading the Config File): document the
348 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
349 SlaveBuilder to have its parent Builder changed.
350 (SlaveBuilder.isAvailable): new method to give access to state,
351 which is now a private attribute
352 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
353 the SlaveBuilder about how it is being used. These methods update
354 its internal state. buildFinished() is now the place that invokes
355 maybeStartBuild() on its parent Builder.
356 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
357 new Builder to take over for an old one, transferring state from
359 (Buider): refactor the way that SlaveBuilders are used to match,
360 giving them a bit more autonomy.
361 (Builder.buildFinished): this no longer calls maybeStartBuild():
362 instead the SlaveBuilder calls it on whoever its parent Builder is
363 at the time. This way, when an old Builder is replaced by a new
364 one, and there was a build in progress during the transition, when
365 that build finishes, it will be the new Builder that is told about
366 the newly available slave so it can start a new build.
368 * buildbot/process/base.py (Build.startBuild._release_slave): when
369 the Build finishes, tell the SlaveBuilder that they've been
372 * buildbot/status/builder.py (SlaveStatus): add some new setter
373 methods for use by BotPerspective, to keep some attributes more
376 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
377 called by the buildmaster.
378 (Bot.setBuilderList): instead, we locally announce any leftover
379 directories based upon which Builders we were told about. The
380 master doesn't really care; it's the local admin who may or may not
384 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
385 to allow use of python2.4 or whatever. This tool still requires
388 2006-11-19 Brian Warner <warner@lothar.com>
390 * NEWS (IStatusLog.readlines): more news items
392 2006-11-18 Brian Warner <warner@lothar.com>
394 * NEWS: start collecting items for the next release.
396 2006-11-04 Brian Warner <warner@lothar.com>
398 * buildbot/changes/bonsaipoller.py: apply updates from Ben
399 Hearsum. Closes SF#1590310.
400 * buildbot/test/test_bonsaipoller.py: and tests
402 * buildbot/status/tinderbox.py
403 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
404 status when the build results in WARNINGS. Patch from Dave
405 Liebreich. Closes SF#1587352.
407 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
408 linux-vs-osx behavior difference w.r.t. reading from files that
409 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
410 to Mark Rowe for the patch.
412 2006-10-15 Brian Warner <warner@lothar.com>
414 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
415 method name was misspelled in the interface definition. Thanks to
416 Roy Rapoport for the catch.
418 2006-10-13 Brian Warner <warner@lothar.com>
420 * docs/buildbot.texinfo (Adding LogObservers): update sample code
421 to match the great Steps renaming
423 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
424 Maybe I should run my own unit tests before recording a big
425 change. Good thing I've got a buildbot to remind me.
427 2006-10-12 Brian Warner <warner@lothar.com>
429 * buildbot/steps/transfer.py: rework __init__ and args setup
430 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
432 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
433 when opening the target file, only catch IOError (to report via
434 stderr/rc!=0), let the others be reported as normal exceptions
436 2006-10-08 Brian Warner <warner@lothar.com>
438 * contrib/svn_watcher.py: fix security holes by using proper argv
439 arrays and subprocess.Popen() rather than commands.getoutput().
440 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
441 is deprecated in favor of buildbot/changes/svnpoller.py, and will
442 probably be removed by the next release.
445 2006-10-04 Brian Warner <warner@lothar.com>
447 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
448 initial lines that weren't emitted by pyflakes. When the pyflakes
449 command is run under a Makefile, 'make' will echo the command it
450 runs to stdio, and that was getting logged as a "misc" warning.
451 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
452 * buildbot/test/test_steps.py (testPyFlakes3): another test
454 2006-10-01 Brian Warner <warner@lothar.com>
456 * buildbot/status/html.py (HtmlResource.render): if we get a
457 unicode object from our content() method, encode it into utf-8
458 like we've been claiming to all along. This allows the comments
459 and author names from svnpoller.py to be delivered properly.
461 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
462 de-unicodify filenames before creating the Change, because the
463 rest of buildbot is unlikely to handle them well. Leave the 'who'
464 field as a unicode object.. I don't think there's anything that
465 will break very soon, and it will probably nudge us towards
466 accepting unicode everywhere sooner or later. Stop using the
467 "date" field that comes out of SVN, since it is using the
468 repository's clock (and timezone) and what we care about is the
469 buildmaster's (otherwise Changes from the future show up later
470 than the builds they triggered).
471 * buildbot/test/test_svnpoller.py (Everything.test1): match the
474 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
475 Suvbersion repository polling ChangeSource. I've hacked it up
476 considerably: any bugs are entirely my own fault. Thank you
478 * buildbot/test/test_svnpoller.py: tests for it
479 * docs/buildbot.texinfo (SvnSource): document it
481 2006-09-30 Brian Warner <warner@lothar.com>
483 * buildbot/scheduler.py (Periodic): submit a reason= to the
484 BuildSet to indicate which Scheduler triggered the build. Thanks
485 to Mateusz Loskot for the suggestion.
487 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
489 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
490 changes: set self.loop in __init__, remove unused volatile=
492 * docs/buildbot.texinfo (.buildbot config directory): add more
493 docs on the .buildbot/options keys used by "buildbot try"
494 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
495 (Try.deliverJob): same
497 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
501 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
502 close the filehandle when we stop watching the file. Before, the
503 filehandle was only closed when the LogFileWatcher was
504 garbage-collected, which could be quite a while in the future. If
505 it was still open by the time the next build started, windows will
506 refuse to let the new build delete the old build/ directory. Fixes
507 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
508 #twisted for the catch.
510 2006-09-29 Brian Warner <warner@lothar.com>
512 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
515 2006-09-25 Brian Warner <warner@lothar.com>
517 * setup.py: the new buildbot.steps module wasn't being installed.
518 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
519 (testmsgs): add the extra stuff from buildbot/test/* so you can
520 run unit tests on an installed copy of buildbot, not just from
523 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
524 columns of 'svnlook changed' output contain status information, so
525 strip [:4] instead of [:6]. Depending upon what the status flags
526 were, this would sometimes lead to mangled filenames. Thanks to
527 Riccardo Magliocchetti for the patch. Closes SF#1545146.
529 * buildbot/steps/source.py (Monotone): initial Monotone support,
530 contributed by Nathaniel Smith. Still needs docs and tests, but
531 this code has been in use on the Monotone buildbot for a long
533 * buildbot/slave/commands.py (Monotone): slave-side support
534 * buildbot/changes/monotone.py (MonotoneSource): polling change
537 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
538 contributed a Change Source that polls a Bonsai server (a
539 kind of web-based viewcvs CGI script).
541 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
542 Hearsum contributed a status plugin which sends email in the same
543 format that Tinderbox does: this allows a number of tinderbox
544 tools to be driven by Buildbot instead. Thanks Ben!
546 2006-09-24 Brian Warner <warner@lothar.com>
548 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
549 Thanks to Robert Helmer for the patch.
551 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
552 BuildStatus about the buildslave name at the *beginning* of the
553 build, rather than at the end. Thanks to Alexander Lorenz for the
555 * buildbot/status/html.py (StatusResourceBuild.body): always
556 include the slavename in the build page, not just when the build
558 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
559 slavename in the email message
561 2006-09-21 Brian Warner <warner@lothar.com>
563 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
565 * docs/examples/glib_master.cfg: same
566 * docs/examples/hello.cfg: same
567 * docs/examples/twisted_master.cfg: same, update to current usage
569 2006-09-19 Brian Warner <warner@lothar.com>
571 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
572 (PyFlakes.createSummary): make it compatible with python-2.2
574 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
575 for at least the output-parsing parts of PyFlakes
577 2006-09-18 Brian Warner <warner@lothar.com>
579 * buildbot/steps/python.py: oops, fix import of StringIO
581 2006-09-17 Brian Warner <warner@lothar.com>
583 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
584 turns out that SVN-1.4.0 doesn't fail to update once you've
585 replaced a file with a directory, unlike older versions of SVN and
586 pretty much every other VC tool we support. Since what we really
587 care about is that the update succeeds anyway, stop checking that
588 the tree got clobbered and just assert that the build succeeded.
589 (VCBase.printLogs): add a utility function for debugging
591 * buildbot/process/step.py: oops, added extra imports by mistake
593 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
594 rstrip() on the first line coming out of the 'p4 describe'
595 process, to remove the stray ^M that Wade Brainerd reports seeing
596 in the 'when' field. Fixes SF#1555985.
598 * buildbot/master.py (BuildMaster.loadConfig): improve the error
599 message logged when c['schedulers'] is not right
600 * buildbot/scheduler.py (Scheduler.__init__): improve error
601 message when a Scheduler() is created with the wrong arguments
602 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
603 verify that these error messages are emitted
605 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
606 The idea is that all the base classes (like BuildStep and
607 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
608 will be a leftover backwards-compatibility file that only contains
609 aliases for the steps that were moved out to buildbot.steps.*
610 * lots: change imports to match
611 * buildbot/process/step.py: add a DeprecationWarning if it ever
614 2006-09-12 Brian Warner <warner@lothar.com>
616 * buildbot/scheduler.py (Scheduler.__init__): make sure that
617 builderNames= is actually a sequence, since if you happen to give
618 it a single builder-specification dictionary instead, it won't get
619 caught by the existing assert. Thanks to Brett Neely for the
622 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
624 * docs/buildbot.texinfo (Python BuildSteps): document them
625 (sendchange): include a link to PBChangeSource, since you need one
627 * buildbot/steps/shell.py: clean up test-case-name line, remove some
629 * buildbot/steps/dummy.py: same
631 2006-09-08 Brian Warner <warner@lothar.com>
633 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
634 BuildStep which lets you transfer files from the master to the
635 slave or vice versa. Thanks to Albert Hofkamp for the original
636 patch. Fixes SF#1504631.
637 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
639 (SlaveFileDownloadCommand): same
640 * docs/buildbot.texinfo (Transferring Files): document it
641 * buildbot/test/test_transfer.py: test it
642 * buildbot/test/runutils.py (StepTester): new utility class for
643 testing BuildSteps and RemoteCommands without Builds or Bots or PB
644 * buildbot/test/test_steps.py (CheckStepTester): validate that the
647 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
648 walk through StatusLogs one line at a time, mostly for the benefit
649 of ShellCommand.createSummary methods. You can either walk through
650 STDOUT or STDERR, but the default is STDOUT.
652 * buildbot/status/builder.py (LogFile.readlines): implement it.
653 Note that this is not yet memory-efficient, it just pulls the
654 whole file into RAM and then splits it up with a StringIO.
655 Eventually this should be a generator that only pulls chunks from
657 * buildbot/test/test_status.py (Log.testReadlines): test it
659 * docs/buildbot.texinfo: update to match changes
660 * buildbot/process/factory.py: stop using old definitions
661 * buildbot/process/process_twisted.py: same
662 * buildbot/test/test_*.py: same
664 * buildbot/process/step_twisted.py: move definition to..
665 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
666 relative-import mechanisms prevent this from being named 'twisted'
667 or 'python/twisted' as I would have preferred.
669 * buildbot/process/maxq.py: move definition to..
670 * buildbot/steps/maxq.py: .. here, leave a compatibility import
672 * buildbot/process/step.py: split the user-visible BuildSteps into
673 separate files, all under buildbot/steps/
674 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
675 * buildbot/steps/shell.py: this holds ShellCommand and friends
676 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
678 2006-09-05 Brian Warner <warner@lothar.com>
680 * lots: run pyflakes, removed a lot of unused imports, changed the
681 form of some conditional imports to remove false pyflakes
682 warnings. There are still a number of warnings left, mostly from
683 imports that are done for their side-effects.
684 * buildbot/test/test_vc.py: import twisted.python.failure, since it
687 2006-08-26 Brian Warner <warner@lothar.com>
689 * buildbot/test/test_locks.py (Unit.testLater): make the tests
690 compatible with twisted-1.3.0, for some reason I just can't seem
691 to let go of the past.
693 2006-08-25 Brian Warner <warner@lothar.com>
695 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
697 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
698 all logfiles= in startCommand(), rather than in start() . This
699 makes it easier to have the 'stdio' log come before any secondary
700 logfiles, which I feel makes the waterfall display more
702 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
703 from ShellCommand up into LoggingBuildStep
704 (LoggingBuildStep.__init__): move the handling of logfiles= from
705 ShellCommand up to LoggingBuildStep, because startCommand is
706 provided by LoggingBuildStep, whereas start() was specific to
707 subclasses like ShellCommand and Source. This removes code
708 duplication in those subclasses.
709 (ShellCommand.__init__): same
710 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
711 for a slave that's too old to understand logfiles= into a separate
712 method, so it can live in ShellCommand. The rest of
713 setupLogfiles() can live in LoggingBuildStep.
715 2006-08-24 Brian Warner <warner@lothar.com>
717 * buildbot/locks.py (BaseLock): you can now configure Locks to
718 allow multiple simultaneous owners. They still default to
719 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
721 * docs/buildbot.texinfo (Interlocks): document the new options
722 * buildbot/test/test_locks.py: add a bunch of new unit tests
723 * buildbot/process/base.py (Build.acquireLocks): locks now offer
724 waitUntilMaybeAvailable, not waitUntilAvailable
725 * buildbot/process/step.py (BuildStep.acquireLocks): same
726 * buildbot/master.py (BotMaster.getLockByID): real locks now use
727 the whole lockid in their constructor, not just the name. Also,
728 keep track of which real locks we've handed out by the full
729 lockid, not just class+name, otherwise changing just the maxCount=
730 in the master.cfg file would not actually cause a behavioral
733 2006-08-23 Brian Warner <warner@lothar.com>
735 * buildbot/__init__.py (version): bump to 0.7.4+ while between
737 * docs/buildbot.texinfo: same
739 2006-08-23 Brian Warner <warner@lothar.com>
741 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
742 * docs/buildbot.texinfo: set version to match
743 * NEWS: update for 0.7.4
744 * buildbot/slave/commands.py (command_version): mention that this
745 version (2.1) was released with buildbot-0.7.4
747 2006-08-22 Brian Warner <warner@lothar.com>
751 * CREDITS: new file, list of people who have helped. Thanks!
752 * MANIFEST.in: ship it
754 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
755 new diagrams, the user's manual is more informative than it was.
756 Start shipping the .html user's manual (and generated .png
758 * Makefile: update 'release' target to match
760 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
761 test.. I think the web-parts effort will render it pointless well
762 before it ever actually starts to work.
764 2006-08-20 Brian Warner <warner@lothar.com>
766 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
767 meaning of the prefix= argument. It is now just a string which is
768 stripped from the beginning of the filename. If prefix= is set but
769 not found on any given filename, that filename is ignored. If all
770 filenames in a Change are ignored, the Change is dropped. This is
771 much simpler than the previous sep= nonsense, and I should have
772 implemented it this way from the beginning. Effectively resolves
773 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
774 Gedminas for the catch and suggested fixes.
775 (ChangePerspective.perspective_addChange): implement the actual
777 * buildbot/test/test_changes.py (TestChangePerspective): test it
778 * docs/buildbot.texinfo (PBChangeSource): document it, explain
779 how to properly use prefix=
780 * docs/examples/twisted_master.cfg (source): update prefix= by
781 adding the trailing slash
784 * docs/examples/twisted_master.cfg: update to actual practice
786 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
787 update test case to match new link text.. the HREF has both a
788 class= setting and an enclosing [] pair that I didn't match in the
791 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
792 list of strings is preferred over a single string with embedded
794 (ShellCommand.description=): explain that either single strings or
795 a list of strings is acceptable, and why you might prefer one over
796 the other. Add an example. Fixes SF#1524659, thanks to Paul
797 Winkler for the catch.
798 (Build Steps): update to use f.addStep() rather than using s()
799 and the constructor list
801 * buildbot/process/step.py (ShellCommand): accept either a single
802 string or a list of strings in both description= and
804 * buildbot/test/test_steps.py (Steps.test_description): test it
805 * buildbot/test/runutils.py (makeBuildStep): support for that test
807 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
808 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
809 collecting the files and creating the patch.
811 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
812 per-step URLs that will be displayed on the waterfall display,
813 for things like the HTML output of code-coverage tools, when
814 the results are hosted elsewhere.
815 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
816 way to retrieve these URLs
817 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
818 the method to retrieve these URLs. Also provide backwards
819 compatibility for saved BuildStepStatus instances that didn't have
821 * buildbot/process/step.py (BuildStep.addURL): method to set these
822 URLs from within a BuildStep
823 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
824 (StepBox.getBox): give these external links a distinct CSS class
825 named "BuildStep external" so a .css file can display them
828 * buildbot/test/test_web.py (WaterfallSteps): test that we really
830 * buildbot/test/test_steps.py (Steps): test that we can all the
831 URLs. Also add a bunch of other tests on methods that can be
832 called from within BuildSteps
833 * buildbot/test/runutils.py (makeBuildStep): add utility function
835 2006-08-13 Brian Warner <warner@lothar.com>
837 * docs/buildbot.texinfo (BuildStep LogFiles): document them
839 2006-08-10 Brian Warner <warner@lothar.com>
841 * docs/buildbot.texinfo (Index of master.cfg keys): add another
842 index, this one of things like c['sources'] and c['schedulers']
843 (indices): it looks like my clever idea of putting the @fooindex
844 commands in between the @node and the @subsection (to make the
845 HREF anchor jump to slightly above the section title, which works
846 much better in html) confused texinfo horribly, so I'm moving the
847 index tags back to be just after the @subsection marker. I also
848 added extra lines between the @node/@section paragraph and the
849 index tags, since I think maybe texinfo wants to see these be
852 * docs/Makefile (images): make sure images get built when
854 * docs/images/Makefile: same
856 * buildbot/scripts/runner.py: rename 'buildbot master' to
857 'buildbot create-master', and 'buildbot slave' to 'buildbot
859 * docs/buildbot.texinfo: same
862 * docs/buildbot.texinfo: reimplement the "useful classes" index
863 with actual texinfo indices. The .info rendering is a bit
864 weird-looking but it works well, and the HTML rendering is quite
865 nice. This also puts the index targets in the regular flow of the
866 text, which is easier to maintain.
868 2006-08-06 Brian Warner <warner@lothar.com>
870 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
871 Kevin Turner to prefer the environ= argument be a list rather than
872 a string. If it is a list, it will be joined with a platform-local
873 os.pathsep delimiter, and then prepended to any existing
874 $PYTHONPATH value. This works better in cross-platform (i.e.
875 windows buildslaves) environments when you need to push multiple
876 directories onto the front of the path.
877 (SlaveShellCommand): documented the new magic
878 * docs/buildbot.texinfo (ShellCommand): documented the new magic
879 in a user-visible form
881 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
882 Turner to prefer lists over strings when creating/running VC
883 commands during unit tests. This is clearly necessary to survive
884 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
885 renamed the wq() function to qw() though, since that's how it's
886 spelled in perl. Eventually I'd prefer all commands to be
887 specified with lists.
889 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
890 which are deleted (or not yet created) correctly. Also add
891 failsafe code to not explode if the file-watching poller doesn't
892 get started. Thanks to JP Calderone for the catch and the poller
894 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
896 * buildbot/test/emitlogs.py: same
898 * NEWS: summarize recent changes
900 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
901 clause to avoid the "host key mismatch" warning
903 * buildbot/process/step_twisted.py (Trial.start): if the
904 buildslave is too old to understand logfiles=, fall back to
905 running 'cat _trial_temp/test.log' like before.
906 (Trial.commandComplete): same. this takes advantage of the
907 LoggingBuildStep refactoring to stall commandComplete long enough
908 to run a second RemoteShellCommand.
910 * buildbot/process/step.py (LoggingBuildStep.startCommand):
911 refactor command-completion handling, to allow methods like
912 commandComplete/createSummary/evaluateCommand to return Deferreds.
913 (LoggingBuildStep._commandComplete): delete the refactored method
914 (ShellCommand.setupLogfiles): if the buildslave is too old to
915 understand logfiles=, put a warning message both into twistd.log
916 and into the otherwise empty user-visible LogFiles.
918 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
919 callers to provide the slave-side logfile name, rather than
920 forcing it to come from the local name of the LogFile.
921 (BuildStep.getSlaveName): new method
923 * buildbot/process/base.py (Build.getSlaveName): new method, so
924 steps can find out which buildslave they're running on
926 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
927 to match the s/cvs_ver/command_version/ change
929 2006-08-05 Brian Warner <warner@lothar.com>
931 * buildbot/slave/commands.py (command_version): replace the CVS
932 auto-updated cvs_ver keyword with a manually-updated variable,
933 since CVS is no longer the master repository. Add a description of
934 the remote API change starting in this version (2.1), specifically
935 the fact that SlaveShellCommand now accepts 'initial_stdin',
936 'keep_stdin_open', and 'logfiles'.
938 2006-07-31 Brian Warner <warner@lothar.com>
940 * docs/buildbot.texinfo (System Architecture): Finally add lots of
941 diagrams to describe how the whole system fits together. The
942 images themselves are kept in SVG files, with ascii-art versions
943 in corresponding .txt files. Texinfo knows how to interpolate the
944 text version into .info files, reference the .png versions from
945 .html files, and include .eps versions in the .ps format.
946 * docs/images/Makefile: tools to create .png and .eps
947 * docs/images/*.svg: created pictures with Inkscape.
948 * .darcs-boring: ignore the generated .eps and .png files
950 2006-07-24 Brian Warner <warner@lothar.com>
952 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
953 Scheduler names, since they cause setServiceParent to explode
955 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
957 2006-07-20 Brian Warner <warner@lothar.com>
959 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
960 which runs the buildbot unit tests
962 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
963 classes that are useful in master.cfg
965 2006-07-15 Brian Warner <warner@lothar.com>
967 * Makefile (some-apidocs): new target to build only some epydocs
969 * setup.py: minor comment.. does the classifiers= argument prevent
970 the setup.py script from working on python2.2/2.3?
972 * buildbot/scripts/sample.cfg: update manhole example, arrange into
975 * buildbot/twcompat.py: fix minor typo in comments
977 * buildbot/manhole.py: move all Manhole-related code out to this
978 module. Implement SSH-based manholes (with TwistedConch), and move
979 to conch's nifty line-editing syntax-coloring REPL shell instead
980 of the boring non-editing monochromatic (and deprecated) old
982 * buildbot/master.py: remove all Manhole-related code
983 (BuildMaster.loadConfig._add): make sure the old manhole is
984 removed before we add the new one
985 * docs/buildbot.texinfo (Debug options): document new Manhole options
987 * buildbot/twcompat.py (_which): fix some epydoc issues
988 * buildbot/status/html.py (Waterfall.__init__): same
990 2006-06-29 Brian Warner <warner@lothar.com>
992 * buildbot/interfaces.py: get Interface from b.twcompat to hush
993 deprecation warnings under newer Twisteds (by using
994 zope.interface.Interface instead of old twisted.python.components
996 * buildbot/slave/interfaces.py: same
998 2006-06-28 Brian Warner <warner@lothar.com>
1000 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1001 svn commands, so it will fail immediately instead of hanging while
1002 it waits for a username/password to be typed in.
1004 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1005 log message if the step was shut down
1007 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1008 obsolete reference to mktap.
1010 2006-06-20 Brian Warner <warner@lothar.com>
1012 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1013 test to include new 'logfiles' argument sent from master to slave
1015 2006-06-19 Brian Warner <warner@lothar.com>
1017 * buildbot/process/step_twisted.py (Trial): track Progress from
1018 _trial_temp/test.log too
1020 * buildbot/process/step.py (OutputProgressObserver): generalize
1021 the earlier StdioProgressObserver into an OutputProgressObserver
1022 that can track LogFiles other than stdio.
1023 (LoggingBuildStep.__init__): same
1025 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1026 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1027 will fail under windows because of os.sep issues. It might have
1028 worked before if 'cat' was doing cygwin path conversion.
1030 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1031 creation of LogFileWatchers
1032 (ShellCommand._startCommand): and record the files that were
1033 watched in the 'headers' section of the ShellCommand output
1035 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1036 need to actually pass it to the slave if you want it to work.
1037 (ShellCommand): document it a bit
1039 * buildbot/test/test_shell.py: new test to validate LogFiles
1040 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1042 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1043 before printing the last batch of lines, to test that the polling
1044 logic is working properly
1046 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1047 handling, making it possible to track multiple logs for a single
1048 RemoteCommand. The previous single logfile is now known as the
1050 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1051 (RemoteShellCommand.__init__): accept logfiles=
1052 (LoggingBuildStep.startCommand): stdio_log is now one of many
1053 (ShellCommand): added logfiles= argument, as well as a class-level
1054 .logfiles attribute, which will be merged together to figure out
1055 which logfiles should be tracked. The latter maybe be useful for
1056 subclasses of ShellCommand which know they will aways produce
1057 secondary logfiles in the same location.
1059 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1060 and closeStdin() methods, preparing to make it possible to write
1061 to a ShellCommand's stdin at any time, not just at startup. These
1062 writes are buffered if the child process hasn't started yet.
1063 (LogFileWatcher): new helper class to watch arbitrary logfiles
1064 while a ShellCommand runs. This class polls the file every two
1065 seconds, and sends back 10k chunks to the buildmaster.
1066 (ShellCommand): rename stdin= to initialStdin=, and add
1067 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1069 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1070 key of "log" and a value of (logname, data).
1071 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1072 'logfiles' to the master-visible args dictionary.
1073 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1076 * buildbot/test/test_vc.py (Patch.testPatch): same
1079 * buildbot/test/emit.py: write to a logfile in the current
1080 directory. We use this to figure out what was used as a basedir
1081 rather than looking to see which copy of emit.py gets run, so that
1082 we can run the commands from inside _trial_temp rather than inside
1084 * buildbot/test/subdir/emit.py: same
1085 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1086 argument rather than running from buildbot/test/
1087 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1088 rather than using an implicit setUp()
1089 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1090 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1091 of assuming that we're running in buildbot/test/ (and that '.' is
1094 * buildbot/slave/commands.py (Command.doStart): refactor Command
1095 startup/completion a bit: now the SlaveBuilder calls doStart(),
1096 which is not meant for overridding by subclasses, and doStart()
1097 calls start(), which is. Likewise the SlaveBuilder calls
1098 doInterrupt(), and subclasses override interrupt(). This also puts
1099 responsibility for maintaining .running in Command rather than in
1101 (Command.doInterrupt): same
1102 (Command.commandComplete): same, this is called when the deferred
1103 returned by start() completes.
1104 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1105 (SlaveBuilder.remote_interruptCommand): same
1106 (SlaveBuilder.stopCommand): same
1108 2006-06-16 Brian Warner <warner@lothar.com>
1110 * buildbot/test/test_shell.py: new test file to contain everything
1111 relating to ShellCommand
1112 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1113 multiple logfiles in realtime" feature, not yet implemented
1114 * buildbot/test/emitlogs.py: support file for testLogFiles
1115 * docs/buildbot.texinfo (ShellCommand): document the feature
1117 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1119 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1120 for tests which exercise SlaveCommands in isolation.
1122 * buildbot/test/test_slavecommand.py: Move some utilities like
1123 SignalMixin and FakeSlaveBuilder from here ..
1124 * buildbot/test/runutils.py: .. to here, so they can be used by
1125 other test classes too
1126 * buildbot/test/test_vc.py: more SignalMixin refactoring
1127 * buildbot/test/test_control.py: same
1128 * buildbot/test/test_run.py: and some rmtree refactoring
1130 2006-06-15 Brian Warner <warner@lothar.com>
1132 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1133 'testBranch' to match other VC tests and have the tests run in
1134 roughly increasing order of dependency
1136 * buildbot/test/test_steps.py (LogObserver): new test to verify
1137 LogObservers can be created at various times and still get
1138 connected up properly
1140 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1141 to create BuildStepStatus instances that actually work.
1143 * buildbot/process/step.py (LogObserver): add outReceived and
1144 errReceived base methods, to be overridden
1146 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1147 API to take a name instead of a step, reducing the coupling
1148 somewhat. This returns the BuildStepStatus object so it can be
1149 passed to the new Step, instead of jamming it directly into the
1151 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1153 * buildbot/process/base.py (Build.setupBuild): use both methods
1154 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1155 process a bit to match
1157 2006-06-14 Brian Warner <warner@lothar.com>
1159 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1160 docs on writing new LogObserver classes
1161 (Writing New Status Plugins): brief docs on how Status Plugins fit
1164 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1165 implement a LogObserver that counts how many unit tests have been
1167 (Trial.__init__): wire it in
1168 * buildbot/test/test_twisted.py (Counter): unit test for it
1170 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1171 to new cmd.logs['stdio'] scheme
1172 (Trial.commandComplete): same
1173 (BuildDebs.commandComplete): same
1175 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1176 LogFiles, instead of just a single one. The old single logfile is
1177 now called "stdio". LoggedRemoteCommand no longer creates a
1178 LogFile for you (the code to do that was broken anyway). If you
1179 don't create a "stdio" LogFile, then stdout/stderr will be
1181 (LogObserver): implement "LogObservers", which a BuildStep can add
1182 to parse the output of a command in real-time. The primary use is
1183 to provide more useful information to the Progress code, allowing
1184 better ETA estimates.
1185 (LogLineObserver): utility subclass which feeds complete lines to
1186 the parser instead of bytes.
1187 (BuildStep.progressMetrics): this is safer as a tuple
1188 (BuildStep.setProgress): utility method, meant to be called by
1190 (BuildStep.addLogObserver): new method, to be called at any time
1191 during the BuildStep (even before any LogFiles have been created),
1192 to attach (or schedule for eventual attachment) a LogObserver to a
1194 (StdioProgressObserver): new LogObserver which replaces the old
1195 "output" progress gatherer
1196 (LoggingBuildStep.__init__): same
1197 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1198 (LoggingBuildStep._commandComplete): must use logs['stdio']
1199 instead of the old single ".log" attribute.
1200 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1201 functionality, now subsumed into StdioProgressObserver
1202 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1203 log name changed from "output" to "stdio".
1206 * buildbot/interfaces.py (ILogFile): add the Interface used from
1207 the BuildStep towards the LogFile
1208 (ILogObserver): and the one provided by a LogObserver
1209 * buildbot/status/builder.py (LogFile): implement it
1211 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1212 HEADER constants here ..
1213 * buildbot/status/builder.py (STDOUT): .. from here
1215 2006-06-13 Brian Warner <warner@lothar.com>
1217 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1218 compatibility with python2.2, which doesn't have the 'substr in
1220 (TestP4Poller.makeTime): utility function to construct the
1221 timestamp using the same strptime() approach as p4poller does. It
1222 turns out that time.mktime() behaves slightly differently under
1223 python2.2, probably something to do with the DST flag, and that
1224 causes the test to fail under python2.2. (changing the mktime()
1225 arguments to have dst=0 instead of -1 caused it to fail under
1226 python2.3. Go figure.)
1227 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1229 2006-06-12 Brian Warner <warner@lothar.com>
1231 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1232 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1233 contributing such an excellent patch, including docs and unit
1234 tests! This makes it *so* much easier to apply. I had to update
1235 test_vc.py to handle some recent refactorings, but everything else
1236 applied smoothly. The only remaining thing I'd like to fix would
1237 be to remove the hard-wired port 1666 used by p4d, and allow it to
1238 claim any unused port. This would allow two copies of the test
1239 suite to run on the same host at the same time, as well as
1240 allowing the test suite to run while a real (production) p4d was
1241 running on the same host. Oh, and maybe we should add a warning to
1242 step.P4 that gets emitted if the slave is too old to provide the
1243 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1244 * buildbot/slave/commands.py (P4): same
1245 (P4Sync): same, some minor updates
1246 * buildbot/changes/p4poller.py: same
1247 * docs/buildbot.texinfo: same
1248 * buildbot/test/test_p4poller.py: same
1249 * buildbot/test/test_vc.py (P4): same
1251 * setup.py: add Trove classifiers for PyPI
1253 2006-06-08 Brian Warner <warner@allmydata.com>
1255 * buildbot/status/client.py
1256 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1257 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1258 build needs to be IRemote'd separately, rather than IRemote'ing
1259 the whole list at once. I can't wait until newpb's serialization
1260 adapters make this unnecessary.
1262 2006-06-06 Brian Warner <warner@lothar.com>
1264 * buildbot/process/step.py (WithProperties): make this inherit
1265 from ComparableMixin, so that reloading an unchanged config file
1266 doesn't cause us to spuriously reload any Builders which use them.
1267 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1270 2006-06-03 Brian Warner <warner@lothar.com>
1272 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1273 running py2exe on windows, contributed by Mark Hammond. Addresses
1274 SF#1401121, but I think we still need to include
1275 buildbot/scripts/sample.cfg
1276 * setup.py: include buildbot_service.py as a script under windows
1277 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1278 a py2exe application), get the icon/css datafiles from a different
1281 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1282 double-escape the build URL. Thanks to Olivier Bonnet for the
1283 patch. Fixes SF#1452801.
1285 2006-06-02 Brian Warner <warner@lothar.com>
1287 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1288 first six columns of 'svnlook' output, not just the first column,
1289 since property changes appear in the other five. Thanks to Olivier
1290 Bonnet for the patch. Fixes SF#1398174.
1292 2006-06-01 Brian Warner <warner@lothar.com>
1294 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1295 the fake build, so that title= has something to be set to
1297 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1298 attribute of the "Build #NN" link in the yellow start-the-build
1299 box to the build's reason. This means that you get a little
1300 tooltip explaining why the build was done when you hover over the
1301 yellow box. Thanks to Zandr Milewski for the suggestion.
1303 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1304 (Box.setETA): handle ETA=None (by stopping the timer)
1305 (Box.update): make the [soon] text less different than the usual
1306 text, so the rest of the text doesn't flop around so much. It
1307 would be awfully nice to figure out how to center this stuff.
1308 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1310 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1311 by default, so that any ShellCommand which fails marks the overall
1312 build as a failure. I should have done this from the beginning.
1313 Add flunkOnFailure=False to the arguments if you want to turn off
1316 2006-05-30 Brian Warner <warner@lothar.com>
1318 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1319 last-build/current-build/current-step. Show what step is currently
1320 running. Show ETA for both the overall build and the current step.
1321 Update GTK calls to modern non-deprecated forms. There's still a
1322 lot of dead code and debug noise to remove.
1324 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1325 shows up properly in status displays
1327 2006-05-28 Brian Warner <warner@lothar.com>
1329 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1330 build we use to verify that WithProperties works:
1332 ** set flunkOnFailure=True so that build failures get noticed
1333 ** set workdir='.' so that the build succeeds, otherwise it is trying
1334 to touch 'build/something', and 'build/' doesn't exist because
1335 usually that's created by a Source step
1336 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1337 this test somehow triggers, in which the 'touch' process becomes
1338 a zombie and we wait for th etimeout before giving up on it.
1340 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1341 to log the Build results and step logs to the twisted log.
1342 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1343 what went wrong if a build was expected to succeed but didn't.
1345 * buildbot/process/step_twisted.py (Trial): set the default
1346 trialMode to '--reporter=bwverbose', which specifies verbose
1347 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1348 '-to', but those are completely missing in modern Twisteds.
1350 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1351 a localhost-only port, to encourage better security
1353 * docs/buildbot.texinfo (Change Sources): mention
1356 * .darcs-boring: add a Darcs boringfile
1358 * README (REQUIREMENTS): stop claiming compatibility with
1361 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1364 2006-05-27 Brian Warner <warner@lothar.com>
1366 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1367 * docs/buildbot.texinfo: same
1369 2006-05-23 Brian Warner <warner@lothar.com>
1371 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1372 * docs/buildbot.texinfo: set version to match
1373 * NEWS: update for 0.7.3
1375 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1376 give a quick mapping from VC system to possible ChangeSources
1377 (Build Properties): add 'buildername'
1379 * buildbot/process/base.py (Build.setupStatus): oops, set
1380 'buildername' and 'buildnumber' properties
1381 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1384 2006-05-22 Brian Warner <warner@lothar.com>
1386 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1387 property interpolation better
1389 * README (INSTALLATION): remove old '-v' argument from recommended
1392 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1393 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1396 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1397 'svnversion' instead of grepping the output of 'svn info', much
1398 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1399 Bonnet for the suggestion.
1400 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1401 require the WC_PATH argument, so run 'svnversion .' instead.
1403 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1404 aren't supposed to have 'self' in their argument list
1406 2006-05-21 Brian Warner <warner@lothar.com>
1408 * buildbot/process/step.py (ShellCommand.start): make
1409 testInterpolate pass. I was passing the uninterpolated command to
1410 the RemoteShellCommand constructor
1411 (ShellCommand._interpolateProperties): oops, handle non-list
1412 commands (i.e. strings with multiple words separated by spaces in
1413 them) properly, instead of forgetting about them.
1415 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1416 to actually try to use build properties in a real build. This test
1418 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1419 to start and evaluate builds
1421 * buildbot/test/test__versions.py: add a pseudo-test to record
1422 what version of Twisted/Python/Buildbot are running. This should
1423 show up at the beginning of _trial_tmp/test.log, and exists to help
1424 debug other problems.
1426 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1427 a filename to be served as 'robots.txt' to discourage web spiders.
1428 Adapted from a patch by Tobi Vollebregt, thanks!
1429 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1430 (Waterfall.test_waterfall): tweak the way that filenames are put
1431 into the config file, to accomodate windows pathnames better.
1433 * docs/buildbot.texinfo (HTML Waterfall): document it
1435 * buildbot/process/process_twisted.py
1436 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1437 changed the build process. The new setup.py no longer takes the
1439 (FullTwistedBuildFactory.__init__): same
1440 (TwistedReactorsBuildFactory.__init__): same
1442 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1443 be placed in the [hooks] section of the central repository (the
1444 one that everybody pushes changes to).
1446 2006-05-20 Brian Warner <warner@lothar.com>
1448 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1449 .darcs-context file, use binary mode. I think this was causing a
1450 Darcs failure under windows.
1452 2006-05-19 Brian Warner <warner@lothar.com>
1454 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1455 use a timezone string of +0000 and gmtime, since this timestamp is
1456 sent to a buildmaster and %z is broken.
1458 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1459 string and localtime, since this timestamp will only be consumed
1460 locally, and %z is broken.
1462 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1463 gmtime, since this timestamp is returned to the buildmaster, and
1466 2006-05-18 Brian Warner <warner@lothar.com>
1468 * NEWS: update in preparation for next release
1470 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1471 setup-repository and do-we-have-the-vc-tools code into a separate
1472 "helper" class, which sticks around in a single module-level
1473 object. This seems more likely to continue to work in the future
1474 than having it hide in the TestCase and hope that TestCases stick
1475 around for a long time.
1477 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1478 addremove' has been deprecated in recent versions of mercurial, so
1479 use 'hg add' instead
1481 2006-05-07 Brian Warner <warner@lothar.com>
1483 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1484 operating under windows, move the file before opening it, since
1485 you can't rename a file that somebody has open.
1487 * buildbot/process/base.py (Build.setupBuild): if something goes
1488 wrong while creating a Step, log the name and arguments, since the
1489 error message when you get the number of arguments wrong is really
1492 2006-05-06 Brian Warner <warner@lothar.com>
1494 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1495 bugs in twisted-specific code not covered by my unit tests, this
1496 time use 'cmd' argument instead of self.cmd
1498 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1499 fix stupid braino: either use startwith or find()==0, not both.
1500 (TwistedReactorsBuildFactory.__init__): another dumb typo
1502 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1503 mark this test as TODO under windows, since process-killing seems
1504 dodgy there. We'll come back to this later and try to fix it
1507 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1508 and don't include a timezone
1509 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1510 This should avoid the windows-with-verbose-timezone-name problem
1512 (Patch.testPatch): add a test which runs 'patch' with less
1513 overhead than the full VCBase.do_patch sequence, to try to isolate
1514 a windows test failure. This one uses slave.commands.ShellCommand
1515 and 'patch', but none of the VC code.
1517 * buildbot/slave/commands.py (getCommand): use which() to find the
1518 executables for 'cvs', 'svn', etc. This ought to help under
1521 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1522 working directory before starting. If an earlier test failed, the
1523 leftover directory would mistakenly flunk a later test.
1524 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1525 Make sure that we use the right commandlines if which("tla") picks
1526 up "tla.exe" (as it does under windows).
1527 (TlaSupport.do_get): factor out this tla-vs-baz difference
1528 (TlaSupport.vc_create): more tla-vs-baz differences
1530 * buildbot/test/test_slavecommand.py
1531 (ShellBase.testShellMissingCommand): stop trying to assert
1532 anything about the error message: different shells on different
1533 OSes with different languages makes it hard, and it really isn't
1534 that interesting of a thing to test anyway.
1536 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1537 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1538 "Panther"), because it has a bug which flunks a couple tests in
1539 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1540 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1541 able to test that yet.
1543 2006-04-30 Brian Warner <warner@lothar.com>
1545 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1546 make sure child commands emit messages in english, so our regexps
1547 will match. Thanks to Nikaus Giger for identifying the problems.
1548 (VCBase._do_vctest_export_1): mode="export" is not responsible
1549 for setting the "got_revision" property, since in many cases it is
1550 not convenient to determine.
1551 (SVNSupport.capable): when running 'svn --version' to check for
1552 ra_local, we want error messages in english
1553 * buildbot/test/test_slavecommand.py
1554 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1555 to emit the error message in english
1557 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1558 the environment with $LC_ALL="C" so that Commands which need to
1559 parse the output of their child processes can obtain it in
1561 (SVN.parseGotRevision): call "svn info" afterwards instead of
1562 watching the output of the "svn update" or "svn checkout".
1563 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1564 (Arch.parseGotRevision): same
1565 (Bazaar.parseGotRevision): same
1566 (Mercurial.parseGotRevision): same
1568 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1569 $LC_ALL="C" when running commands under 'buildbot try', too
1571 * buildbot/test/__init__.py: remove the global os.environ()
1572 setting, instead we do it just for the tests that run commands and
1573 need to parse their output.
1575 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1576 remove the overly-short .timeout on this test, because non-DNotify
1577 platforms must fall back to polling which happens at 10 second
1578 intervals, so a 5 second timeout would never succeed.
1580 2006-04-24 Brian Warner <warner@lothar.com>
1582 * docs/buildbot.texinfo (Installing the code): update trial
1583 invocation, SF#1469116 by Niklaus Giger.
1584 (Attributes of Changes): updated branch-name examples to be
1585 a bit more realistic, SF#1475240 by Stephen Davis.
1587 * contrib/windows/buildbot2.bat: utility wrapper for windows
1588 developers, contributed by Nick Trout (after a year of neglect..
1589 sorry!). SF#1194231.
1591 * buildbot/test/test_vc.py (*.capable): store the actual VC
1592 binary's pathname in VCS[vcname], so it can be retrieved later
1593 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1594 strip out non-numeric timezone information, specifically the funky
1595 German string that his system produced that confuses CVS.
1596 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1597 allow Darcs tests to work on windows
1598 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1599 procutils.which() everywhere, to allow tryclient to work under
1600 windows. Also from Niklaus Giger, SF#1463394.
1602 * buildbot/twcompat.py (which): move the replacement for a missing
1603 twisted.python.procutils.which from test_vc.py to here, so it can
1604 be used in other places too (specifically tryclient.py)
1606 2006-04-23 Brian Warner <warner@lothar.com>
1608 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1609 bare buildbotURL/projectName line with a proper DIV, along with a
1610 CSS class of "title", from Stefan Seefeld (SF#1461675).
1611 (WaterfallStatusResource.body0): remove the redundant 'table'
1612 class from the table
1613 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1614 to the top-row TR, and class="Activity" to the second-row TR,
1615 rather than putting them in the individual TD nodes.
1617 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1618 'got_revision' build property for all VC systems that implement
1619 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1621 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1622 to determine which revision we actually obtained
1623 (CVS.parseGotRevision): implement this for CVS, which just means
1624 to grab a timestamp. Not ideal, and it depends upon the buildslave
1625 having a clock that is reasonably well syncronized with the server,
1626 but it's better than nothing.
1627 (SVN.parseGotRevision): implement it for SVN, which is accurate
1628 (Darcs.parseGotRevision): same
1629 (Arch.parseGotRevision): same
1630 (Bazaar.parseGotRevision): same
1631 (Mercurial.parseGotRevision): same
1633 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1634 keep a record of all non-stdout/stderr/header/rc status updates,
1635 for the benefit of RemoteCommands that send other useful things,
1637 (Source.commandComplete): put any 'got_revision' status values
1638 into a build property of the same name
1641 * buildbot/process/step_twisted.py (Trial): update to deal with
1642 new ShellCommand refactoring
1644 * docs/buildbot.texinfo (Build Properties): document new feature
1645 that allows BuildSteps to get/set Build-wide properties like which
1646 revision was requested and/or checked out.
1648 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1649 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1650 it. Note that this bumps the persistenceVersion of the saved Build
1651 object, so add the necessary upgrade-old-version logic to include
1652 an empty properties dict.
1654 * buildbot/process/base.py (Build.setProperty): implement it
1655 (Build.getProperty): same
1656 (Build.startBuild): change build startup to set 'branch',
1657 'revision', and 'slavename' properties at the right time
1659 * buildbot/process/step.py (BuildStep.__init__): change setup to
1660 require 'build' argument in a better way
1661 (LoggingBuildStep): split ShellCommand into two pieces, for better
1662 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1663 a single RemoteCommand that sends stdout/stderr status text. It
1664 also provides the usual commandComplete / createSummary /
1665 evaluateCommand / getText methods to be overridden...
1666 (ShellCommand): .. whereas ShellCommand is specifically for
1667 running RemoteShellCommands. Other shell-like BuildSteps (like
1668 Source) can inherit from LoggingBuildStep instead of ShellCommand
1669 (WithProperties): marker class to do build-property interpolation
1670 (Source): inherit from LoggingBuildStep instead of ShellCommand
1673 * buildbot/test/test_properties.py: test new functionality
1675 2006-04-21 Brian Warner <warner@lothar.com>
1677 * buildbot/test/test_vc.py: rename testBranch to
1678 testCheckoutBranch to keep the tests in about the right
1681 2006-04-18 Brian Warner <warner@lothar.com>
1683 * docs/buildbot.texinfo (PBListener): improve cross-references
1684 between PBListener and 'buildbot statusgui', thanks to John Pye
1687 2006-04-17 Brian Warner <warner@lothar.com>
1689 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1690 running under Twisted-1.3.0, otherwise skipped tests are reported
1693 * all: use isinstance() instead of 'type(x) is foo', suggested by
1696 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1697 oops, fix a brain-fade from the other week, when making the
1698 addStep changes. I changed all the __init__ upcalls to use the
1699 wrong superclass name.
1700 (FullTwistedBuildFactory.__init__): same
1701 (TwistedDebsBuildFactory.__init__): same
1702 (TwistedReactorsBuildFactory.__init__): same
1703 (TwistedBuild.isFileImportant): use .startswith for clarity,
1704 thanks to Neal Norwitz for the suggestions.
1706 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1707 changes, then deliver them over PB to a remote buildmaster.
1709 * contrib/svnpoller.py: added script by John Pye to poll a remote
1710 SVN repository (by running 'svn log') from a cronjob, and run
1711 'buildbot sendchange' to deliver the changes to a remote
1713 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1714 modification of svnpoller.py), same purpose, but this one loops
1715 internally (rather than expecting to run from a cronjob) and works
1717 * contrib/README.txt: same
1719 2006-04-11 Brian Warner <warner@lothar.com>
1721 * all: fix a number of incorrect names and missing imports, thanks
1722 to Anthony Baxter for the patch.
1723 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1724 remove unused buggy method.
1725 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1726 comes from shutil, not "shutils"
1727 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1728 (Arch.checkSlaveVersion): same
1729 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1731 * buildbot/process/step_twisted2.py: add some missing imports
1732 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1733 this code used to live in twisted.internet.defer
1735 2006-04-10 Brian Warner <warner@lothar.com>
1737 * buildbot/process/step.py (Mercurial): add Mercurial support
1738 * buildbot/slave/commands.py (Mercurial): same
1739 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1740 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1741 not yet tested, but 'try' support *is* covered
1742 * docs/buildbot.texinfo (Mercurial): document it
1744 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1745 some debugging messages (turned off)
1746 * buildbot/test/test_vc.py: improve debug messages
1748 2006-04-07 Brian Warner <warner@lothar.com>
1750 * buildbot/test/test_vc.py (which): define our own which() in case
1751 we can't import twisted.python.procutils, because procutils doesn't
1752 exist in Twisted-1.3
1754 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1755 of SlaveLocks for performance tests
1757 * docs/examples/twisted_master.cfg: update to match current usage
1759 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1760 password, p4 binary, pollinterval, maximum history to check.
1761 Patch from an anonymous sf.net contributor, SF#1219384.
1762 * buildbot/process/step.py (P4Sync.__init__): add username,
1763 password, and client arguments.
1764 * buildbot/slave/commands.py (P4Sync): same
1766 2006-04-05 Brian Warner <warner@lothar.com>
1768 * buildbot/process/factory.py (BuildFactory.addStep): new method
1769 to add steps to a BuildFactory. Use it instead of f.steps.append,
1770 and you can probably avoid using the s() convenience function.
1771 Patch from Neal Norwitz, sf.net #1412605.
1772 (other): update all factories to use addStep
1773 * buildbot/process/process_twisted.py: update all factories to use
1776 2006-04-03 Brian Warner <warner@lothar.com>
1778 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1779 work under windows too. Adapted from a patch by Niklaus Giger,
1780 addresses SF#1463399.
1782 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1783 spawned commands emit parseable results in english and not some
1784 other language. Patch from Niklaus Giger, SF#1463395.
1786 * README (INSTALLATION): discourage users from running unit tests on
1787 a "network drive", patch from Niklaus Giger, SF#1463394.
1789 2006-03-22 Brian Warner <warner@lothar.com>
1791 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1792 function to turn a repository-relative pathname into a (branch,
1793 branch-relative-filename) tuple. Change this function to handle
1794 the branch naming policy used by your Subversion repository.
1795 Thanks to AllMyData.com for sponsoring this work.
1797 2006-03-16 Brian Warner <warner@lothar.com>
1799 * buildbot/scripts/sample.cfg: add python-mode declaration for
1800 vim. Thanks to John Pye for the patch.
1802 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1803 command line, mention the importance of running 'crontab' as the
1804 buildmaster/buildslave user. Thanks to John Pye for the catch.
1806 2006-03-13 Brian Warner <warner@lothar.com>
1808 * buildbot/status/words.py (IRC): add an optional password=
1809 argument, which will be sent to Nickserv in an IDENTIFY message at
1810 login, to claim the nickname. freenode requires this before the
1811 bot can sent (or reply to) private messages. Thanks to Clement
1812 Stenac for the patch.
1813 * docs/buildbot.texinfo (IRC Bot): document it
1815 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1816 larger than chunkSize. Fixes SF#1349253.
1817 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1818 (Log.testConsumer): update to match new internal chunking behavior
1820 2006-03-12 Brian Warner <warner@lothar.com>
1822 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1824 * buildbot/test/test_maildir.py (MaildirTest): rename the
1825 'timeout' method, as it collides with trial's internals
1827 * buildbot/scripts/runner.py: add 'buildbot restart' command
1828 (stop): don't sys.exit() out of here, otherwise restart can't work
1829 * docs/buildbot.texinfo (Shutdown): document it
1831 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1832 * buildbot/status/html.py (Waterfall.__init__): same
1833 * buildbot/process/builder.py (Builder.startBuild): same
1834 * buildbot/process/base.py (BuildRequest): same
1835 * buildbot/sourcestamp.py (SourceStamp): same
1836 * buildbot/scheduler.py (Nightly): same
1838 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1840 * docs/buildbot.texinfo: same
1842 2006-02-17 Brian Warner <warner@lothar.com>
1844 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1845 * docs/buildbot.texinfo: set version number to match
1846 * NEWS: update for 0.7.2
1848 2006-02-16 Brian Warner <warner@lothar.com>
1850 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1852 2006-02-09 Brian Warner <warner@lothar.com>
1854 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1855 add text to explain per-build branch parameters
1856 * NEWS: mention --umask
1858 2006-02-08 Brian Warner <warner@lothar.com>
1860 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1862 (SlaveOptions.optParameters): add --umask, to make it possible to
1863 make buildslave-generated files (including build products) be
1866 * buildbot/slave/bot.py (BuildSlave.startService): same
1868 2006-01-23 Brian Warner <warner@lothar.com>
1870 * buildbot/status/builder.py: urllib.quote() all URLs that include
1871 Builder names, so that builders can include characters like '/'
1872 and ' ' without completely breaking the resulting HTML. Thanks to
1873 Kevin Turner for the patch.
1874 * buildbot/status/html.py: same
1875 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1877 * NEWS: update in preparation for upcoming release
1879 2006-01-18 Brian Warner <warner@lothar.com>
1881 * docs/examples/twisted_master.cfg: update to match the Twisted
1882 buildbot: remove python2.2, switch to exarkun's buildslaves,
1883 disable the .deb builder until we figure out how to build twisted
1884 .debs from SVN, add some ktrace debugging to the OS-X build
1885 process and remove the qt build, remove threadless builders,
1886 change freebsd builder to use landonf's buildslave.
1888 2006-01-12 Brian Warner <warner@lothar.com>
1890 * buildbot/master.py (Manhole.__init__): let port= be a strports
1891 specification string, but handle a regular int for backwards
1892 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1893 used in master.cfg to limit connections to just the local host.
1894 (BuildMaster.loadConfig): same for c['slavePortnum']
1895 * buildbot/scheduler.py (Try_Userpass.__init__): same
1896 * buildbot/status/client.py (PBListener.__init__): same
1897 * buildbot/status/html.py (Waterfall.__init__): same, for both
1898 http_port and distrib_port. Include backwards-compatibility checks
1899 so distrib_port can be a filename string and still mean unix:/foo
1900 * docs/buildbot.texinfo (Setting the slaveport): document it
1901 (Debug options): same
1902 (HTML Waterfall): same
1905 * buildbot/test/test_config.py (ConfigTest): test it
1907 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1908 slaveport's disownServiceParent deferred to fire before opening
1909 the new one. Fixes an annoying bug in the unit tests.
1911 2006-01-03 Brian Warner <warner@lothar.com>
1913 * buildbot/master.py (BuildMaster): remove the .schedulers
1914 attribute, replacing it with an allSchedulers() method that looks
1915 for all IService children that implement IScheduler. Having only
1916 one parent/child relationship means fewer opportunities for bugs.
1917 (BuildMaster.allSchedulers): new method
1918 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1919 also fix ugly bug that caused any config-file reload to
1920 half-forget about the earlier Schedulers, causing an exception
1921 when a Change arrived and was handed to a half-connected
1922 Scheduler. The exception was in scheduler.py line 54ish:
1923 self.parent.submitBuildSet(bs)
1924 exceptions.AttributeError: 'NoneType' object has no attribute
1926 (BuildMaster.addChange): update to use allSchedulers()
1928 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1929 to work properly with twisted-1.3.0, where you must explicitly
1930 include the __implements__ from parent classes
1931 (BaseScheduler.__repr__): make it easier to distinguish distinct
1933 (BaseUpstreamScheduler.__implements__): same
1935 * buildbot/status/builder.py (Status.getSchedulers): update to
1937 * buildbot/test/test_run.py (Run.testMaster): same
1938 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1939 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1940 make sure Scheduler instances are left alone when an identical
1941 config file is reloaded
1942 (ConfigElements.testSchedulers): make sure Schedulers are properly
1945 * Makefile (TRIALARGS): my local default Twisted version is now
1946 2.1.0, update the trial arguments accordingly
1948 2005-12-22 Brian Warner <warner@lothar.com>
1950 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1953 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1954 addChange in the parent class, although I suspect this should be
1955 fixed better in the future.
1957 2005-11-26 Brian Warner <warner@lothar.com>
1959 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1960 explode when branch==None, thanks to Kevin Turner for the catch
1961 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1964 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1966 * docs/buildbot.texinfo: same
1968 2005-11-26 Brian Warner <warner@lothar.com>
1970 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1971 * docs/buildbot.texinfo: set version number to match
1973 2005-11-26 Brian Warner <warner@lothar.com>
1975 * NEWS: update for 0.7.1
1977 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1978 sure that unsubscribe works even if we never sent an ETA update.
1979 Also, don't explode on duplicate unsubscribe.
1980 (BuildStepStatus.addLog): make the convenience "return self"-added
1981 watcher automatically unsubscribe when the Step finishes.
1982 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1983 (BuildStatus.stepStarted): same auto-unsubscribe
1984 (BuilderStatus.buildStarted): same auto-unsubscribe
1986 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1988 (IStatusReceiver.stepStarted): same
1989 (IStatusReceiver.logStarted): same
1991 * buildbot/test/test_run.py (Status): move the Status test..
1992 * buildbot/test/test_status.py (Subscription): .. to here
1994 2005-11-25 Brian Warner <warner@lothar.com>
1996 * NEWS: more updates
1998 * buildbot/locks.py: fix the problem in which loading a master.cfg
1999 file that changes some Builders (but not all of them) can result
2000 in having multiple copies of the same Lock. Now, the real Locks
2001 are kept in a table inside the BotMaster, and the Builders/Steps
2002 use "LockIDs", which are still instances of MasterLock and
2003 SlaveLock. The real Locks are instances of the new RealMasterLock
2004 and RealSlaveLock classes.
2005 * buildbot/master.py (BotMaster.getLockByID): new method to
2006 convert LockIDs into real Locks.
2007 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2008 into real Locks before building
2009 * buildbot/process/step.py (BuildStep.startStep): same
2010 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2011 exercises the problem
2014 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2015 what Schedulers are available
2017 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2018 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2019 'cron'-style build scheduling at certain times of day, week,
2021 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2023 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2024 handling: treat self.fileIsImportant more as an attribute that
2025 contains a callable than as a method. If the attribute is None,
2026 don't call it and assume all filenames are important. It is still
2027 possible to provide a fileIsImportant method in a subclass,
2029 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2031 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2032 test using AnyBranchScheduler with fileIsImportant=None
2034 2005-11-24 Brian Warner <warner@lothar.com>
2036 * buildbot/test/test_config.py (StartService): don't claim a fixed
2037 port number, instead set slavePort=0 on the first pass, figure out
2038 what port was allocated, then switch to a config file that uses
2041 * buildbot/master.py (BuildMaster.loadConfig): close the old
2042 slaveport before opening the new one, because unit tests might
2043 replace slavePort=0 with the same allocated portnumber, and if we
2044 don't wait for the old port to close first, we get a "port already
2045 in use" error. There is a tiny race condition here, but the only
2046 threat is from other programs that bind (statically) to the same
2047 port number we happened to be allocated, and only if those
2048 programs use SO_REUSEADDR, and only if they get control in between
2051 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2053 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2054 deleted ChangeSources before adding any new ones
2055 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2056 compare_attrs, to make sure that a config-file reload does not
2057 unnecessarily replace an unmodified ChangeSource instance
2058 * buildbot/test/test_config.py (ConfigTest.testSources): update
2060 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2061 mean "don't build anything", and add a warning if it gets used
2062 because it isn't actually useful.
2064 * contrib/svn_buildbot.py: update example usage to match the port
2065 number that gets used by the PBChangeSource
2066 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2068 2005-11-22 Brian Warner <warner@lothar.com>
2070 * NEWS: start collecting items for next release
2072 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2073 revisions are strings
2074 (P4Sync.computeSourceRevision): same
2076 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2077 to the Buildbot's overall status page
2078 (StatusResourceBuilder.body): same
2080 2005-11-15 Brian Warner <warner@lothar.com>
2082 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2083 config-file loading, specifically to make sure old StatusTargets
2084 are finished shutting down before new ones start up (thus
2085 resolving a bug in which changing the Waterfall object would fail
2086 because both new and old instances were claiming the same
2087 listening port). Also load new Schedulers after all the new
2088 Builders are set up, in case they fire off a new build right away.
2089 * buildbot/test/test_config.py (StartService): test it
2091 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2092 the branch name to the mail body
2094 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2095 Without it, a config-file reload fails to update an existing
2097 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2098 username/passwd to compare_attrs, for the same reason
2099 * buildbot/status/html.py (Waterfall): add favicon to
2100 compare_attrs, same reason
2102 2005-11-05 Brian Warner <warner@lothar.com>
2104 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2105 baserev before stuffing it in the jobfile. This resolves problems
2106 under SVN (and probably Arch) where revisions are expressed as
2107 numbers. I'm inclined to use string-based revisions everywhere in
2108 the future, but this fix should be safe for now. Thanks to Steven
2109 Walter for the patch.
2111 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2112 binary mode when opening pickle files, to make windows work
2113 better. Thanks to Dobes Vandermeer for the catch.
2114 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2115 (BuilderStatus.getBuildByNumber): same
2116 (Status.builderAdded): same
2117 * buildbot/master.py (BuildMaster.loadChanges): same
2119 * buildbot/util.py (Swappable): delete unused leftover code
2121 * buildbot/process/step.py (SVN): when building on a non-default
2122 branch, add the word "[branch]" to the VC step's description, so
2123 it is obvious that we're not building the usual stuff. Likewise,
2124 when we are building a specific revision, add the text "rNNN" to
2125 indicate what that revision number is. Thanks to Brad Hards and
2126 Nathaniel Smith for the suggestion.
2127 (Darcs.startVC): same
2128 (Arch.startVC): same
2129 (Bazaar.startVC): same
2131 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2132 typo, caught by Mark Dillavou, closes SF#1216636.
2134 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2135 about a test to add some day
2137 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2138 the 'full-2.3' build, and the 'reactors' build is now run under
2139 python-2.4 because the buildslave no longer has gtk/etc bindings
2140 for earlier versions.
2142 2005-11-03 Brian Warner <warner@lothar.com>
2144 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2145 method, takes an IBuildStatus and rebuilds it. It might make more
2146 sense to add this to IBuildControl instead, but that instance goes
2147 away completely once the build has finished, and resubmitting
2148 builds can take place weeks later.
2149 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2150 * buildbot/status/html.py (StatusResourceBuild): also stash an
2151 IBuilderControl so we can use resubmitBuild.
2152 (StatusResourceBuild.body): render "resubmit" button if we can.
2153 Also add hrefs for each BuildStep
2154 (StatusResourceBuild.rebuild): add action for "resubmit" button
2155 (StatusResourceBuilder.getChild): give it an IBuilderControl
2157 * buildbot/status/builder.py (Status.getURLForThing): change the
2158 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2159 that live as targets of buttons like "stop" and "rebuild" can't
2161 * buildbot/status/builder.py (Status.getURLForThing): same
2162 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2163 (StepBox.getBox): same
2164 * buildbot/test/test_web.py (GetURL): same
2167 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2168 exclusivity checks after Source.__init__ upcall, so misspelled
2169 arguments will be reported more usefully
2170 (Darcs.__init__): same
2172 2005-10-29 Brian Warner <warner@lothar.com>
2174 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2175 builder. Move the Try scheduler off to a separate port.
2177 2005-10-27 Brian Warner <warner@lothar.com>
2179 * buildbot/clients/gtkPanes.py
2180 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2181 to cause the app to crash, now they don't.
2183 * buildbot/clients/debug.py: display the buildmaster's location
2184 in the window's title bar
2186 2005-10-26 Brian Warner <warner@lothar.com>
2188 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2189 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2190 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2192 * buildbot/status/html.py (td): put a single non-breaking space
2193 inside otherwise empty <td> elements, as a workaround for buggy
2194 browsers which would optimize them away (along with any associated
2195 styles, like the kind that create the waterfall grid borders).
2196 Patch from Frerich Raabe.
2198 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2199 argv-list as an argument, defaulting to ["-to"], which is
2200 appropriate for the Trial that comes with Twisted-2.1.0 and
2201 earlier. The Trial in current Twisted SVN wants
2202 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2203 defaults to an empty list.
2204 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2205 match it, now that trialMode= is a list instead of a single string
2207 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2209 * docs/buildbot.texinfo: same
2211 2005-10-24 Brian Warner <warner@lothar.com>
2213 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2214 * docs/buildbot.texinfo: set version number to match
2216 2005-10-24 Brian Warner <warner@lothar.com>
2218 * README: update for 0.7.0
2220 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2222 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2223 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2224 send the branch= argument unless the user really provided one, to
2225 retain compatibility with older buildmasters that don't accept
2227 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2230 * docs/buildbot.texinfo: update lots of stuff
2232 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2233 to the 'buildbot sendchange' command
2234 * buildbot/clients/sendchange.py (Sender.send): same
2235 * buildbot/changes/pb.py (ChangePerspective): same
2236 * buildbot/test/test_changes.py (Sender.testSender): test it
2238 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2239 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2240 for consistency with other BuildStep arguments that use camelCase.
2241 Well, at least more of them use camelCase (like flunkOnWarnings)
2242 than don't.. I wish I'd picked one style and stuck with it
2243 earlier. Annoying, but it's best done before the release, since
2244 these arguments didn't exist at all in 0.6.6 .
2246 * buildbot/test/test_vc.py (SVN.testCheckout): same
2247 (Darcs.testPatch): same
2248 * docs/buildbot.texinfo (SVN): document the change
2249 (Darcs): same, add some build-on-branch docs
2250 * docs/examples/twisted_master.cfg: match change
2252 * buildbot/process/step.py (BuildStep): rename
2253 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2254 how it is normally used.
2255 * buildbot/test/test_steps.py (Version.checkCompare): same
2257 * buildbot/process/step.py (CVS.startVC): refuse to build
2258 update/copy -style builds on a non-default branch with an old
2259 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2260 concern is that it will do a VC 'update' in an existing tree when
2261 it is supposed to be switching branches (and therefore clobbering
2262 the tree to do a full checkout), thus building the wrong source.
2263 This used to be a warning, but I think the confusion it is likely
2264 to cause warrants making it an error.
2265 (SVN.startVC): same, also make mode=export on old slaves an error
2266 (Darcs.startVC): same
2267 (Git.startVC): improve error message for non-Git-enabled slaves
2268 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2269 specific revision is built on a slave that doesn't pay attention
2270 to args['revision'], because for slowly-changing trees it will
2271 probably do the right thing, and because we have no way to tell
2272 whether we're asking it to build the most recent version or not.
2273 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2275 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2276 that 'master' is in host:portnum format, to catch errors sooner
2278 2005-10-23 Brian Warner <warner@lothar.com>
2280 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2281 when creating the list of warning messages, include the line
2282 immediately after each WARNING: line, since that's usually where
2283 the file and line number wind up.
2285 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2290 2005-10-22 Brian Warner <warner@lothar.com>
2292 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2293 patch from Brad Hards
2294 * buildbot/status/classic.css: same
2295 * buildbot/test/test_web.py (Waterfall): match changes
2297 * buildbot/test/test_steps.py (BuildStep.setUp): set
2298 nextBuildNumber so the test passes
2299 * buildbot/test/test_status.py (MyBuilder): same
2301 * buildbot/status/html.py (StatusResourceBuild.body): revision
2302 might be numeric, so stringify it before html-escapifying it
2303 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2304 timer for the upcoming build
2305 * buildbot/status/classic.css: add background-color attributes for
2306 offline/waiting/building classes
2308 * buildbot/status/builder.py (BuildStatus): derive from
2309 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2310 the default (i.e. unknown) .slavename to "???" instead of None,
2311 since even unknown slavenames need to be printed eventually.
2312 (BuilderStatus): also derive from styles.Versioned . More
2313 importantly, determine .nextBuildNumber at creation/unpickling
2314 time by scanning the directory of saved BuildStatus instances and
2315 choosing one larger than the highest-numbered one found. This
2316 should fix the problem where random errors during upgrades cause
2317 the buildbot to forget about earlier builds. .nextBuildNumber is
2318 no longer stored in the pickle.
2319 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2320 at least log the error. Also call Builder.determineNextBuildNumber
2321 once the basedir is set.
2323 * buildbot/master.py (BuildMaster.loadChanges): do
2324 styles.doUpgrade afterwards, in case I decide to make Changes
2325 derived from styles.Versioned some day and forget to make this
2329 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2330 when running under older pythons (<2.3) in which the shlex module
2331 doesn't have a 'split' function.
2333 * buildbot/process/step.py (ShellCommand.start): make
2334 errorMessages= be a list of strings to stuff in the log before the
2335 command actually starts. This makes it easier to flag multiple
2336 warning messages, e.g. when the Source steps have to deal with an
2338 (CVS.startVC): handle slaves that don't handle multiple branches
2339 by switching into 'clobber' mode
2340 (SVN.startVC): same. Also reject branches without base_url
2341 (Darcs.startVC): same. Also reject revision= in older slaves
2342 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2343 (Bazaar.startVC): same, and test for baz separately than for arch
2345 * buildbot/slave/commands.py (cvs_ver): document new features
2347 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2348 (BuildStep.slaveVersionNewEnough): more useful utility method
2349 * buildbot/test/test_steps.py (Version): start testing it
2351 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2352 the 'force' command requires python2.3, for the shlex.split method
2354 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2355 since we don't use it anymore. The Twisted buildbot uses a
2358 2005-10-21 Brian Warner <warner@lothar.com>
2360 * buildbot/process/process_twisted.py: rework all BuildFactory
2361 classes to take a 'source' step as an argument, instead of
2362 building up the SVN instance in the factory.
2363 * docs/examples/twisted_master.cfg: enable build-on-branch by
2364 providing a base_url and default_branch
2366 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2367 control over --branch and --revision, not that they are always
2369 * buildbot/status/html.py (StatusResourceBuilder.force): same
2370 (StatusResourceBuild.body): display SourceStamp components
2372 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2373 IRC 'force' command, so it can be shared with an eventual
2374 command-line-tool 'buildbot force' mode.
2375 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2377 2005-10-20 Brian Warner <warner@lothar.com>
2379 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2381 * docs/examples/twisted_master.cfg: update to use Schedulers
2383 * buildbot/scripts/sample.cfg: update with Schedulers
2385 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2386 method specifically for use by HTML "force build" button and the
2387 IRC "force" command. Raises an immediate error if there are no
2389 (IBuilderControl.requestBuild): make this just submit a build, not
2390 try to check for existing slaves or set up any when-finished
2391 Deferreds or anything.
2392 * buildbot/process/builder.py (BuilderControl): same
2393 * buildbot/status/html.py (StatusResourceBuilder.force): same
2394 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2395 * buildbot/test/test_slaves.py: same
2396 * buildbot/test/test_web.py: same
2398 2005-10-19 Brian Warner <warner@lothar.com>
2400 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2401 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2403 2005-10-18 Brian Warner <warner@lothar.com>
2405 * buildbot/status/html.py: provide 'status' argument to most
2406 StatusResourceFOO objects
2407 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2408 and Logfiles" section to make the Build page into a more-or-less
2409 comprehensive source of status information about the build
2411 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2412 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2414 2005-10-17 Brian Warner <warner@lothar.com>
2416 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2417 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2418 out what to do about other projects: the correct options for
2419 recent Twisteds will not work for older ones.
2421 2005-10-15 Brian Warner <warner@lothar.com>
2423 * buildbot/status/builder.py (Status.getURLForThing): add method
2424 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2425 use this in email/IRC status clients to make them more useful, by
2426 providing the end user with hints on where to learn more about the
2427 object being reported on.
2428 * buildbot/test/test_web.py (GetURL): tests for it
2430 2005-10-14 Brian Warner <warner@lothar.com>
2432 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2433 fix bug resulting from deferredResult changes
2435 2005-10-13 Brian Warner <warner@lothar.com>
2437 * buildbot/test/test_changes.py: remove use of deferredResult
2438 * buildbot/test/test_config.py: same
2439 * buildbot/test/test_control.py: same
2440 * buildbot/test/test_status.py: same
2441 * buildbot/test/test_vc.py: this is the only remaining use, since
2442 it gets used at module level. This needs to be replaced by some
2443 sort of class-level run-once routine.
2445 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2447 * lots: implement multiple slaves per Builder, which means multiple
2448 current builds per Builder. Some highlights:
2449 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2450 of (state,currentBuilds) instead of (state,currentBuild)
2451 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2452 (IBuildStatus.getSlavename): new method, so you can tell which
2453 slave got used. This only gets set when the build completes.
2454 (IBuildRequestStatus.getBuilds): new method
2456 * buildbot/process/builder.py (SlaveBuilder): add a .state
2457 attribute to track things like ATTACHING and IDLE and BUILDING,
2459 (Builder): .. the .slaves attribute here, which has been turned
2460 into a simple list of available slaves. Added a separate
2461 attaching_slaves list to track ones that are not yet ready for
2463 (Builder.fireTestEvent): put off the test-event callback for a
2464 reactor turn, to make tests a bit more consistent.
2465 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2466 ping fails due to an exception. This needs work, I'm worried that
2467 a code error could lead to a constantly re-connecting slave.
2468 Especially since I'm trying to move to a distinct remote_ping
2469 method, separate from the remote_print that we currently use.
2470 (BuilderControl.requestBuild): return a convenience Deferred that
2471 provides an IBuildStatus when the build finishes.
2472 (BuilderControl.ping): ping all connected slaves, only return True
2473 if they all respond.
2475 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2476 reconnect when we shut down.
2478 * buildbot/status/builder.py: implement new methods, convert
2479 one-build-at-a-time methods to handle multiple builds
2480 * buildbot/status/*.py: do the same in all default status targets
2481 * buildbot/status/html.py: report the build's slavename in the
2482 per-Build page, report all buildslaves on the per-Builder page
2484 * buildbot/test/test_run.py: update/create tests
2485 * buildbot/test/test_slaves.py: same
2486 * buildbot/test/test_scheduler.py: remove stale test
2488 * docs/buildbot.texinfo: document the new builder-specification
2489 'slavenames' parameter
2491 2005-10-12 Brian Warner <warner@lothar.com>
2493 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2494 report failure correctly, causing Dependent builds to run when
2495 they shouldn't have.
2496 * buildbot/status/builder.py (BuildSetStatus): same
2497 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2498 (Set.testSuccess): test the both-pass case too
2499 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2500 fix this test: it was ending too early, masking the failure before
2501 (Logger): specialized StatusReceiver to make sure the dependent
2502 builds aren't even started, much less completed.
2504 2005-10-07 Brian Warner <warner@lothar.com>
2506 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2507 bot.SlaveBuilder being disowned in the middle of a build
2509 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2510 this inherit from StatusReceiver. Also upcall in __init__. This
2511 fixes the embarrasing crash when the new buildSetSubmitted method
2512 is invoked and Waterfall/etc don't implement their own.
2513 * buildbot/test/test_run.py: add a TODO note about a test to catch
2514 just this sort of thing.
2516 * buildbot/process/builder.py (Builder.attached): remove the
2517 already-attached warning, this situation is normal. Add some
2518 comments explaining it.
2520 2005-10-02 Brian Warner <warner@lothar.com>
2522 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2523 OverflowError when setting up dnotify, because some 64-bit systems
2524 have problems with signed-vs-unsigned constants and trip up on the
2525 DN_MULTISHOT flag. Patch from Brad Hards.
2527 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2529 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2530 progressMetrics, description, descriptionDone to the 'parms' list,
2531 and make use the 'parms' list from the implementation class
2532 instead of only BuildStep to initialize the parameters. This
2533 allows buildbot.process.factory.s() to initialize all the parms,
2534 not just those defined in directly by BuildStep.
2536 2005-09-03 Brian Warner <warner@lothar.com>
2538 * NEWS: start adding items for the next release
2540 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2541 python2.2 tests, change 'Quick' builder to only use python2.3
2543 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2545 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2546 the "Ping Builder" button if the build control is available; the
2547 user sees an exception otherwise
2549 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2551 2005-09-01 Brian Warner <warner@lothar.com>
2553 * buildbot/interfaces.py (IBuilderStatus.getState): update
2554 signature, point out that 'build' can be None
2555 (IBuildStatus.getETA): point out ETA can be none
2557 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2559 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2561 2005-08-31 Brian Warner <warner@lothar.com>
2563 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2564 update to match correct signature: removed 'eta' argument
2565 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2567 2005-08-30 Brian Warner <warner@lothar.com>
2569 * buildbot/status/builder.py (LogFile): remove the assertion that
2570 blows up when you try to overwrite an existing logfile, instead
2571 just emit a warning. This case gets hit when the buildmaster is
2572 killed and doesn't get a chance to write out the serialized
2573 BuilderStatus object, so the .nextBuildNumber attribute gets out
2576 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2577 the 'buildbot sendchange' arguments, for the Darcs context file
2578 * docs/buildbot.texinfo (sendchange): document it
2580 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2581 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2582 (IStatus.getSchedulers): new method
2583 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2584 (Status.getSchedulers): implement
2585 * buildbot/process/builder.py (Builder): maintain
2586 BuilderStatus.pendingBuilds
2587 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2588 (TryBase.addChange): Try schedulers should ignore Changes
2590 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2591 for 'try' on CVS/SVN
2592 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2594 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2595 report status properly.
2596 (Try.createJob): implement unique buildset IDs
2598 * buildbot/status/client.py (StatusClientPerspective): add a
2599 perspective_getBuildSets method for the benefit of jobdir-style
2601 * docs/buildbot.texinfo (try): more docs
2602 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2605 2005-08-18 Brian Warner <warner@lothar.com>
2607 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2608 actually work. It's functional but still kind of clunky. Also, it
2609 only works with the pb-style.. needs to be made to work with the
2612 * buildbot/status/client.py (RemoteBuildSet): new class
2613 (RemoteBuildRequest): same
2614 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2615 object, not the internal BuildStatus object.
2616 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2617 outside of the usual buildStarted() return value.
2618 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2620 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2621 (Try_Userpass_Perspective.perspective_try): return a remotely
2622 usable BuildSetStatus object
2624 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2625 isStarted()/waitUntilStarted()
2627 2005-08-16 Brian Warner <warner@lothar.com>
2629 * buildbot/status/builder.py: implement IBuildSetStatus and
2630 IBuildRequestStatus, wire them into place.
2631 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2632 methods into the BuildSetStatus object.
2633 * buildbot/interfaces.py: same
2634 (IStatus.getBuildSets): new method to get pending BuildSets
2635 (IStatusReceiver.buildsetSubmitted): new method which hears about
2637 * buildbot/master.py (BuildMaster.submitBuildSet): same
2638 * buildbot/process/base.py (BuildRequest): same, replace
2639 waitUntilStarted with subscribe/unsubscribe
2640 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2641 subscribe instead of waitUntilStarted
2642 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2644 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2646 * buildbot/test/test_buildreq.py: update for new code
2647 * buildbot/test/test_control.py (Force.testRequest): same
2650 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2651 for Darcs to not use the tempfile module, so it works under
2652 python-2.2 too. We really didn't need the full cleverness of that
2653 module, since the slave has exclusive control of its own builddir.
2655 2005-08-15 Brian Warner <warner@lothar.com>
2657 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2658 for CVS trees. It doesn't work for non-trunk branches,
2660 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2663 * Makefile: make it easier to test against python2.2
2665 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2666 tearDown2, so things like Arch can unregister archives as they're
2667 shutting down. The previous subclass-override-tearDown technique
2668 resulted in a nested maybeWait() and test failures under
2671 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2672 where we can (Arch), add a branch= argument to set the branch used
2674 (BazExtractor): extract the branch too
2675 (TlaExtractor): same
2676 * buildbot/scripts/runner.py (TryOptions): add --branch
2677 * docs/buildbot.texinfo (try): document --branch/try_branch
2679 * buildbot/slave/commands.py (Darcs): implement get-revision for
2680 Darcs, so that 'try' will work. This requires the tempfile module
2683 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2684 of revisions, branches, and 'try' in the process.
2686 2005-08-11 Brian Warner <warner@lothar.com>
2688 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2689 this, it got broken at some point in the last few releases
2690 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2691 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2692 specifically the removal of ETA information from the tuple
2694 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2697 * docs/buildbot.texinfo (try): document both --builder and
2698 'try_builders' in .buildbot/options
2699 * buildbot/scripts/runner.py (TryOptions): add --builder,
2700 accumulate the values into opts['builders']
2701 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2702 * buildbot/test/test_runner.py (Try): add some quick tests to make
2703 sure 'buildbot try --options' and .buildbot/options get parsed
2704 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2705 use --builder control
2707 * docs/buildbot.texinfo (try): add --port argument to PB style
2709 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2710 actual SourceStamp. Still need to extract a branch name, somehow.
2711 (Try): finish implementing the try client side, still need a UI
2712 for specifying which builders to use
2713 (Try.getopt): factor our options/config-file reading
2714 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2716 * buildbot/test/test_vc.py: match SourceStampExtractor change
2718 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2719 causes the twisted log to be sent to stderr
2721 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2723 2005-08-10 Brian Warner <warner@lothar.com>
2725 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2726 style is 90% done, still missing status reporting or waiting for
2727 the buildsets to finish, and it is completely untested.
2729 * buildbot/trybuild.py: delete file, move contents to ..
2730 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2731 * buildbot/test/test_vc.py: match the move
2733 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2734 of the TryScheduler, no buildsetID or status-tracking support yet
2735 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2737 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2738 possible to set the basedir after __init__ time, so it is easier
2739 to use as a Service-child of the BuildMaster instance
2741 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2742 that delivers messages to its Service parent instead of requiring
2743 a subclass to be useful. This turns out to be much easier to build
2746 * buildbot/scripts/tryclient.py (createJob): utility code to
2747 create jobfiles, will eventually be used by 'buildbot try'
2749 2005-08-08 Brian Warner <warner@lothar.com>
2751 * docs/buildbot.texinfo (try): add docs on the
2752 as-yet-unimplemented Try scheduler
2754 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2755 * buildbot/test/test_scheduler.py: .. here
2756 (Scheduling.testTryJobdir): add placeholder test for 'try'
2758 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2759 addEntry merging (>=chunkSize) behavior
2760 (Log.testConsumer): update to handle new callLater(0) behavior
2762 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2763 both the MAX_LENGTH bugfix and the resumeProducing hang.
2765 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2766 put off the actual resumeProducing for a moment with
2767 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2768 causes large logfiles to hang midway through.
2770 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2771 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2772 and to improve memory usage when streaming the file out to a web
2774 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2775 make this work cleanly
2777 2005-08-03 Brian Warner <warner@lothar.com>
2779 * buildbot/trybuild.py: new file for 'try' utilities
2780 (getSourceStamp): run in a tree, find out the baserev+patch
2781 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2782 implemented for SVN and Darcs, still working on Arch. I don't know
2783 how to make CVS work yet.
2785 * docs/buildbot.texinfo: document the 'buildbot' command-line
2786 tool, including the not-yet-implemented 'try' feature, and the
2787 in-flux .buildbot/ options directory.
2789 2005-07-20 Brian Warner <warner@lothar.com>
2791 * buildbot/locks.py: added temporary id() numbers to Lock
2792 descriptions, to track down a not-really-sharing-the-Lock bug
2794 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2796 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2797 needed for python2.2 compatibility
2798 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2799 are from the __future__
2801 2005-07-19 Brian Warner <warner@lothar.com>
2803 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2804 message when schedulers use unknown builders
2806 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2807 SlaveLock('name') and MasterLock('name') are distinct
2809 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2810 c['schedulers'] in such a way that we can actually accept
2812 * buildbot/test/test_config.py: check it
2814 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2815 utility method to *all* the Schedulers
2816 (Periodic.listBuilderNames): same
2818 * docs/buildbot.texinfo (Interlocks): update chapter to match
2821 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2822 to make sure that c['sources'], c['schedulers'], and c['status']
2823 are all lists of the appropriate objects, and that the Schedulers
2824 all point to real Builders
2825 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2826 'listBuilderNames' utility method to support this
2827 * buildbot/scheduler.py: implement the utility method
2828 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2830 * docs/buildbot.texinfo: add some @cindex entries
2832 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2833 if it wasn't already set: most tla commands will fail unless one
2835 (Arch.createRepository): and disable bazaar's revision cache, since
2836 they cause test failures (the multiple repositories we create all
2837 interfere with each other through the cache)
2839 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2840 bring it properly up to date with twisted-2.0 test guidelines
2842 * buildbot/master.py (BuildMaster): remove references to old
2843 'interlock' module, this caused a bunch of post-merge test
2845 * buildbot/test/test_config.py: same
2846 * buildbot/process/base.py (Build): same
2848 * buildbot/test/test_slaves.py: stubs for new test case
2850 * buildbot/scheduler.py: add test-case-name tag
2851 * buildbot/test/test_buildreq.py: same
2853 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2854 unnecessary init code
2855 (Bot.remote_setBuilderList): match it
2857 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2859 * buildbot/changes/mail.py (parseSyncmail): update comment
2861 * buildbot/test/test_slavecommand.py: disable Shell tests on
2862 platforms that don't suport IReactorProcess
2864 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2865 all places where we open logfiles. It causes OS-X to open the file
2866 in some weird mode that that prevents us from mixing reads and
2867 writes to the same filehandle, which we depend upon to implement
2868 _generateChunks properly. This change doesn't appear to break
2869 win32, on which "b" and "t" are treated differently but a missing
2870 flag seems to be interpreted as "t".
2872 2005-07-18 Brian Warner <warner@lothar.com>
2874 * buildbot/slave/commands.py (ShellCommand): overhaul
2875 error-handling code, to try and make timeout/interrupt work
2876 properly, and make win32 happier
2877 * buildbot/test/test_slavecommand.py: clean up, stop using
2878 reactor.iterate, add tests for timeout and interrupt
2879 * buildbot/test/sleep.py: utility for a new timeout test
2881 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2882 code from the local-usebranches branch
2884 2005-07-17 Brian Warner <warner@lothar.com>
2886 * buildbot/process/process_twisted.py
2887 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2888 minutes, to match the other twisted BuildFactories, and don't
2889 excuse failures in c/qt/win32 reactors any more.
2891 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2892 'freebsd' builders, since the buildslaves have been unavailable
2895 2005-07-13 Brian Warner <warner@lothar.com>
2897 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2898 build-on-branch feature
2900 * buildbot/process/step.py (Darcs.__init__): add base_url and
2901 default_branch arguments, just like SVN
2902 (Arch.__init__): note that the version= argument is really the
2905 * buildbot/slave/commands.py (SourceBase): keep track of the
2906 repository+branch that was used for the last checkout in
2907 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2908 match, we clobber the directory and perform a fresh checkout
2909 rather than trying to do an in-place update. This should protect
2910 us against trying to get to branch B by doing an update in a tree
2911 obtained from branch A.
2912 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2913 (SVN.setup): same, just the svnurl
2914 (Darcs.setup): same, just the repourl
2915 (Arch.setup): same, arch coordinates (url), version, and
2916 buildconfig. Also pull the buildconfig from the args dictionary,
2917 which we weren't doing before, so the build-config was effectively
2919 (Arch.sourcedirIsUpdateable): don't try to update when we're
2920 moving to a specific revision: arch can't go backwards, so it is
2921 safer to just clobber the tree and checkout a new one at the
2923 (Bazaar.setup): same sourcedata as Arch
2925 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2926 use maybeWait, to work with twisted-1.3.0 and twcompat
2927 (Dependencies.testRun_Pass): same
2929 * buildbot/test/test_vc.py: rearrange, cleanup
2931 * buildbot/twcompat.py: add defer.waitForDeferred and
2932 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2933 can work under twisted-1.3.0 .
2935 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2936 now created at setUp time. This increases the runtime of the test
2937 suite considerably (from 91 seconds to 151), but it removes the
2938 need for an offline tarball, which should solve a problem I've
2939 seen where the test host has a different version of svn than the
2940 tarball build host. The new code also validates that mode=update
2941 really picks up recent commits. This approach will also make it
2942 easier to test out branches, because the code which creates the VC
2943 branches is next to the code which uses them. It will also make it
2944 possible to test some change-notification hooks, by actually
2945 performing a VC commit and watching to see the ChangeSource get
2948 2005-07-12 Brian Warner <warner@lothar.com>
2950 * docs/buildbot.texinfo (SVN): add branches example
2951 * docs/Makefile (buildbot.ps): add target for postscript manual
2953 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2954 * buildbot/test/test_locks.py: same
2956 * buildbot/process/step.py (Darcs): comment about default branches
2958 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2959 c['interlocks'] in the config file, complain if it is present.
2960 Scan all locks in c['builders'] to make sure the Locks they use
2962 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2963 add some tests to check for non-uniquely-named Locks
2964 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2965 since the unique-Lock validation code requires it now
2967 * buildbot/locks.py: fix test-case-name
2969 * buildbot/interlock.py: remove old file
2971 2005-07-11 Brian Warner <warner@lothar.com>
2973 * buildbot/test/test_interlock.py: rename to..
2974 * buildbot/test/test_locks.py: .. something shorter
2976 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2977 versions (after 2.0.1) changed internet.TCPClient to shut down the
2978 connection in stopService. Change the code to handle this
2981 * buildbot/process/base.py (Build): handle whole-Build locks
2982 * buildbot/process/builder.py (Builder.compareToSetup): same
2983 * buildbot/test/test_interlock.py: make tests work
2985 * buildbot/process/step.py (BuildStep.startStep): complain if a
2986 Step tries to claim a lock that's owned by its own Build
2987 (BuildStep.releaseLocks): typo
2989 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2990 file reloads don't replace unchanged Builders
2992 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2993 rewrite to cover new Locks instead of old c['interlocks']
2994 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2998 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2999 start the master and connect the buildslave
3001 * buildbot/process/step.py (FailingDummy.done): finish with a
3002 FAILURE status rather than raising an exception
3004 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3005 stringify a BuildRequest.reason that is None
3007 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3009 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3010 allow scheduler.Dependent to work
3011 * buildbot/buildset.py (BuildSet): set .reason and .results
3013 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3014 slaves, to make the test stop hanging. It still fails, of course,
3015 because I haven't even started to implement Locks.
3017 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3019 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3020 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3021 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3022 (Dependent): new class for downstream build dependencies
3023 * buildbot/test/test_dependencies.py: tests (still failing)
3025 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3027 2005-07-07 Brian Warner <warner@lothar.com>
3029 * buildbot/test/runutils.py (RunMixin): factored this class out..
3030 * buildbot/test/test_run.py: .. from here
3031 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3032 added new buildbot.locks tests (which all hang right now)
3033 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3034 * buildbot/process/step.py: claim/release per-BuildStep locks
3036 * docs/Makefile: add 'buildbot.html' target
3038 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3039 interpreted as "HEAD", so that all VC steps can accept branch=None
3040 and have it mean the "default branch".
3042 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3044 2005-07-07 Brian Warner <warner@lothar.com>
3046 * docs/examples/twisted_master.cfg: update to match current usage
3048 * docs/buildbot.texinfo (System Architecture): comment out the
3049 image, it doesn't exist yet and just screws up the HTML manual.
3051 2005-07-05 Brian Warner <warner@lothar.com>
3053 * debian/.cvsignore: oops, missed one. Removing leftover file.
3055 2005-06-17 Brian Warner <warner@lothar.com>
3057 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3058 changed its output in 1.2.0, don't mistakenly think that the
3059 subversion we find isn't capable of supporting our tests.
3061 * debian/*: remove the debian/ directory and its contents, to make
3062 life easier for the proper Debian maintainer
3064 * Makefile (release): same
3066 2005-06-07 Brian Warner <warner@lothar.com>
3068 * everything: create a distinct SourceStamp class to replace the
3069 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3070 Changed the signature of Source.startVC to include the revision
3071 information (instead of passing it through self.args). Implement
3072 branches for SVN (now only Darcs/Git is missing support). Add more
3075 2005-06-06 Brian Warner <warner@lothar.com>
3077 * everything: rearrange build scheduling. Create a new Scheduler
3078 object (configured in c['schedulers'], which submit BuildSets to a
3079 set of Builders. Builders can now use multiple slaves. Builds can
3080 be run on alternate branches, either requested manually or driven
3081 by changes. This changed some of the Status classes. Interlocks
3082 are out of service until they've been properly split into Locks
3083 and Dependencies. treeStableTimer, isFileImportant, and
3084 periodicBuild have all been moved from the Builder to the
3086 (BuilderStatus.currentBigState): removed the 'waiting' and
3087 'interlocked' states, removed the 'ETA' argument.
3089 2005-05-24 Brian Warner <warner@lothar.com>
3091 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3092 erroneously abandons the connection (in clientConnectionFailed)
3093 for non-UserErrors, which means that if we lose the connection due
3094 to a network problem or a timeout, we'll never try to reconnect.
3095 Fix this by not upcalling to the buggy parent method. Note:
3096 twisted-2.0 fixes this, but the function only has 3 lines so it
3097 makes more sense to copy it than to try and detect the buggyness
3098 of the parent class. Fixes SF#1207588.
3100 * buildbot/changes/changes.py (Change.branch): doh! Add a
3101 class-level attribute to accomodate old Change instances that were
3102 pickled before 0.6.5 (where .branch was added for new Changes).
3103 This fixes the exception that occurs when you try to look at an
3104 old Change (through asHTML).
3106 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3109 2005-05-23 Brian Warner <warner@lothar.com>
3111 * buildbot/__init__.py (version): release 0.6.6
3113 2005-05-23 Brian Warner <warner@lothar.com>
3115 * NEWS: update for 0.6.6 release
3116 * debian/changelog: same
3118 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3119 before starting: this was done by twistd back when we spawned it,
3120 now that we're importing the pieces and running them in the
3121 current process, we have to do it ourselves. This allows
3122 master.cfg to import files from the same directory without
3123 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3124 Stichele for the catch.
3125 (Options.opt_version): Add a --version command (actually, just make
3126 the existing --version command emit Buildbot's version too)
3128 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3129 fix to make this behave like other LogFiles, this time to handle
3130 existing LogFiles on disk. (add the missing .upgrade method)
3131 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3133 2005-05-21 Brian Warner <warner@lothar.com>
3135 * buildbot/test/test_runner.py (Create.testMaster): match the
3136 rawstring change in runner.py:masterTAC
3138 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3139 TwistedWords is installed
3140 * buildbot/test/test_status.py: same, with TwistedMail
3142 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3143 some old, deprecated, and removed config keys). This should enable
3144 you to use the base buildbot functionality with Twisted-2.0.0 when
3145 you don't also have TwistedWeb and TwistedWords installed
3147 2005-05-20 Brian Warner <warner@lothar.com>
3149 * buildbot/scripts/runner.py (run): call sendchange(), not
3150 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3151 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3152 (stop): don't wait for process to die when sending SIGHUP
3153 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3154 directory name gets interpreted, which you don't want
3157 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3160 2005-05-18 Brian Warner <warner@lothar.com>
3162 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3164 2005-05-18 Brian Warner <warner@lothar.com>
3166 * README: update for 0.6.5
3167 * debian/changelog: same
3169 * buildbot/changes/changes.py: rename tag= to branch=, since
3170 that's how we're using it, and my design for the upcoming "build a
3171 specific branch" feature wants it. also, tag= was too CVS-centric
3172 * buildbot/changes/mail.py (parseSyncmail): same
3173 * buildbot/process/base.py (Build.isBranchImportant): same
3174 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3175 * docs/buildbot.texinfo (Attributes of Changes): same
3177 * NEWS: update tag=, update for upcoming release
3179 2005-05-17 Brian Warner <warner@lothar.com>
3181 * buildbot/scripts/runner.py (stop): actually poll once per
3182 second, instead of re-killing the poor daemon once per second.
3183 Sleep briefly (0.1s) before the first poll, since there's a good
3184 chance we can avoid waiting the full second if the daemon shuts
3185 down quickly. Also remove the sys.exit() at the end.
3186 (start): remove the unneighborly sys.exit()
3188 * Makefile: improve permission-setting to not kick Arch so badly
3190 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3191 default --keepalive=600, since it doesn't hurt very much, and it's
3192 a hassle to discover that you need it.
3193 * buildbot/test/test_runner.py (Create.testSlave): test it
3195 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3196 IRC bot about EXCEPTION
3198 * buildbot/status/client.py (PBListener): upcall more correctly
3200 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3201 an exception mark the overall build with EXCEPTION, not SUCCESS
3203 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3205 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3206 * Makefile: update some release-related stuff
3208 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3209 gets called when there isn't actually an active process, just end
3210 the Command instead of blowing up. I don't know how it gets into
3211 this state, but the twisted win32 buildslave will sometimes hang,
3212 and when it shakes its head and comes back, it thinks it's still
3213 running a Command. The next build causes this command to be
3214 interrupted, but the lack of self.process.pid breaks the interrupt
3217 * NEWS: document changes since the last release
3219 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3220 look for Makefile.buildbot instead of a bare Makefile . The
3221 'buildbot start' does not install this file, so you have to
3222 manually copy it if you want to customize startup behavior.
3223 (createMaster): change 'buildbot master' command to create
3224 Makefile.sample instead of Makefile, to create master.cfg.sample
3225 instead of master.cfg (requiring you to copy it before the
3226 buildmaster can be started). Both sample files are kept up to
3227 date, i.e. they are overwritten if they have been changed. The
3228 'buildbot.tac' file is *not* overwritten, but if the new contents
3229 don't match the old, a 'buildbot.tac.new' file is created and the
3230 user is warned. This seems to be a much more sane way to handle
3231 startup files. Also, don't sys.exit(0) when done, so we can run
3232 unit tests against it.
3233 (createSlave): same. Don't overwrite the sample info/ files.
3234 * buildbot/scripts/sample.mk: remove. the contents were pulled
3235 into runner.py, since they need to match the behavior of start()
3239 * docs/buildbot.texinfo (Launching the daemons): document it
3240 * buildbot/test/test_runner.py (Create): test it
3242 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3243 version that can handle string-in-string tests, because otherwise
3244 python-2.2 fails the tests. It'd be tremendous if Trial's test
3245 took two strings under 2.2 too.
3247 * everything: fixed all deprecation warnings when running against
3248 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3249 few that come from Twisted itself). This involved putting most of
3250 the Twisted-version specific code in the new buildbot.twcompat
3251 module, and creating some abstract base classes in
3252 buildbot.changes.base and buildbot.status.base (which might be
3253 useful anyway). __implements__ is a nuisance and requires an ugly
3254 'if' clause everywhere.
3256 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3257 delay before finishing the test: it seems that smtp.sendmail
3258 doesn't hang up on the server, so we must wait a moment so it can
3259 hang up on us. This removes the trial warning about an unclean
3262 2005-05-16 Brian Warner <warner@lothar.com>
3264 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3265 tuple of (delay, repeats).
3266 * buildbot/test/test_vc.py (Retry): test it
3267 * docs/buildbot.texinfo (Source Checkout): document it
3268 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3269 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3270 doVCFull() are handled by re-trying the checkout (after a delay)
3271 some number of times.
3272 (ShellCommand._startCommand): make header lines easier to read
3274 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3276 (WebTest.test_logfile): make sure master gets shut down, silences
3277 some "unclean reactor" test errors
3279 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3280 reactor once after shutdown, something in certain versions of
3281 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3282 fails, svn-trunk is ok.
3284 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3285 second win32 error message
3287 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3288 validating the ETA, so the tests don't fail on slow systems
3290 2005-05-15 Brian Warner <warner@lothar.com>
3292 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3293 the new LogFile class, so upgrading works properly
3294 (LogFileProducer.resumeProducing): survive resumeProducing after
3295 we've exhausted the chunkGenerator
3297 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3299 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3300 (Log.testUpgrade): same
3302 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3303 Builds and logs with a cron job.
3305 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3306 of the old non-offline LogFile, added code to upgrade these to
3307 new-style contents-live-on-disk instances at load time (in a way
3308 that doesn't invalidate the old Build pickles, so upgrading to
3309 0.6.5 is not a one-way operation). Got rid of everything related
3311 (LogFile.__init__): create LogFiles with the parent step status,
3312 the log's name, and a builder-relative filename where it can keep
3313 the contents on disk.
3314 (LogFile.hasContents): new method, clients are advised to call it
3315 before getText or getChunks and friends. If it returns False, the
3316 log's contents have been deleted and getText() will raise an
3318 (LogFile.getChunks): made it a generator
3319 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3320 Consumer (except one that takes chunks instead of strings). This
3321 enables streaming of very large logfiles without storing the whole
3323 (BuildStatus.generateLogfileName): create names like
3324 12-log-compile-output, with a _0 suffix if required to be unique
3325 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3326 or earlier) logfiles into new-style ones
3327 (BuilderStatus): remove everything related to 'stub' builds. There
3328 is now only one build cache, and we don't strip logs from old
3330 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3331 since we no longer fight to keep it in the cache
3333 * buildbot/status/html.py (TextLog.render_GET): use a
3334 ChunkConsumer to stream the log entries efficiently.
3335 (ChunkConsumer): wrapper which consumes chunks and writes
3338 * buildbot/test/test_twisted.py (Parse.testParse): use a
3339 LogFile-like object instead of a real one
3341 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3342 (Log.testMerge3): validate more merge behavior
3343 (Log.testChunks): validate LogFile.getChunks
3344 (Log.testUpgrade): validate old-style LogFile upgrading
3345 (Log.testSubscribe): validate LogFile.subscribe
3346 (Log.testConsumer): validate LogFile.subscribeConsumer
3348 * buildbot/interfaces.py (IStatusLogStub): remove
3349 (IStatusLog.subscribeConsumer): new method
3350 (IStatusLog.hasContents): new method
3351 (IStatusLogConsumer): describes things passed to subscribeConsumer
3353 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3354 the log contents if it does not have any contents.
3355 (StatusResourceBuildStep.body): same
3356 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3358 2005-05-14 Brian Warner <warner@lothar.com>
3360 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3361 timeouts to try and make the windows metabuildslave not hang
3363 2005-05-13 Mike Taylor <bear@code-bear.com>
3365 * buildbot/slave/commands.py (rmdirRecursive): added a check
3366 to ensure the path passed into rmdirRecursive actually exists.
3367 On win32 a non-existant path would generate an exception.
3369 2005-05-13 Brian Warner <warner@lothar.com>
3371 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3372 shutil.rmtree which behaves correctly on windows in the face of
3373 files that you have to chmod before deleting. Thanks to Bear at
3374 the OSAF for the routine.
3375 (SourceBase.doClobber): use rmdirRecursive
3377 2005-05-12 Brian Warner <warner@lothar.com>
3379 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3380 method generate chunks instead of returning a big list. This
3381 allows the same method to be used for both old LogFile and new
3383 (OfflineLogFile.getText): use the generator
3384 (OfflineLogFile.subscribe): same
3385 * buildbot/status/html.py (TextLog.resumeProducing): same
3386 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3388 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3389 point out that OfflineLogFile does not currently work with
3390 html.Waterfall . Fixing this is high-priority.
3392 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3393 apparently windows defaults to using stdout
3395 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3396 better message on failure so I can figure out the win32 problem
3398 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3399 log messages to include more useful copies of the command being
3400 run, the argv array, and the child command's environment.
3401 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3403 2005-05-11 Brian Warner <warner@lothar.com>
3405 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3407 * Makefile: update the deb-snapshot version
3409 * docs/buildbot.texinfo: move all .xhtml docs into a new
3410 .texinfo-format document, adding a lot of material in the process.
3411 This is starting to look like a real user's manual. Removed all
3412 the Lore-related files: *.xhtml, *.css, template.tpl .
3413 * docs/Makefile: simple makefile to run 'makeinfo'
3414 * buildbot/scripts/sample.cfg: rearrange slightly
3415 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3417 2005-05-10 Brian Warner <warner@lothar.com>
3419 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3420 different name for the internal twistw module, handle it.
3422 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3423 * setup.py: .. and stop trying to install it
3425 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3426 'git'), the new linux kernel VC system (http://kernel.org/git/).
3427 Thanks to Brandon Philips for the patch.
3428 * buildbot/slave/commands.py (Git): same
3430 2005-05-06 Brian Warner <warner@lothar.com>
3432 * buildbot/status/builder.py (OfflineLogFile): replace the default
3433 LogFile with a form that appends its new contents to a disk file
3434 as they arrive. The complete log data is never kept in RAM. This
3435 is the first step towards handling very large (100MB+) logfiles
3436 without choking quite so badly. (The other half is
3437 producer/consumer on the HTML pages).
3438 (BuildStepStatus.addLog): use OfflineLogFile by default
3439 (BuildStatus.getLogfileName): helper code to give the
3440 OfflineLogFile a filename to work with
3442 * buildbot/test/test_status.py (Results.testAddResults): update
3443 tests to handle new asserts
3444 * buildbot/test/test_vc.py (Patch.doPatch): same
3445 * buildbot/test/test_steps.py (BuildStep.setUp): same
3447 2005-05-05 Brian Warner <warner@lothar.com>
3449 * buildbot/scripts/runner.py (start): if there is no Makefile,
3450 launch the app by importing twistd's internals and calling run(),
3451 rather than spawning a new twistd process. This stands a much
3452 better chance of working under windows.
3453 (stop): kill the process with os.kill instead of spawning
3454 /bin/kill, again to reduce the number of external programs which
3455 windows might not have in the PATH. Also wait up to 5 seconds for
3456 the process to go away, allowing things like 'buildbot stop;
3457 buildbot start' to be reliable in the face of slow shutdowns.
3459 * buildbot/master.py (Dispatcher.__getstate__): remove old
3460 .tap-related methods
3461 (BuildMaster.__getstate__): same
3463 * buildbot/slave/bot.py (makeService): same
3464 (Options.longdesc): same
3465 * buildbot/scripts/runner.py: copy over some old mktap option text
3467 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3468 'buildbot master' now creates a buildbot.tac file, so there is no
3469 longer a create-instance/save/reload sequence. mktap is dead, long
3471 * buildbot/scripts/sample.mk: use twistd -y, not -f
3472 * buildbot/test/test_config.py: remove mktap-based test
3473 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3474 * README: don't reference mktap
3476 * docs/source.xhtml: document some of the attributes that Changes
3479 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3481 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3482 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3483 * buildbot/changes/changes.py (Change)
3484 * buildbot/changes/mail.py (parseSyncmail)
3485 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3487 * buildbot/process/base.py (Build.isTagImportant)
3491 2005-05-04 Brian Warner <warner@lothar.com>
3493 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3494 connection after sending the change, so that unit tests don't
3495 complain about sockets being left around
3497 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3498 exception in phase=0 rendering
3499 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3501 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3503 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3504 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3505 and configuring builders with tuples.
3506 * buildbot/test/test_config.py: stop testing compatibility with
3507 deprecated config keys
3508 * buildbot/test/test_run.py: same
3510 2005-05-03 Brian Warner <warner@lothar.com>
3512 * contrib/arch_buildbot.py: survive if there are no logfiles
3513 (username): just use a string, os.getlogin isn't reliable
3515 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3516 so 'buildbot sendchange' actually works. The earlier test only
3517 covered the internal (non-reactor-running) form.
3519 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3520 script to notify the buildmaster about changes
3522 * buildbot/scripts/runner.py (sendchange): new command to send a
3523 change to a buildbot.changes.pb.PBChangeSource receiver.
3524 * buildbot/test/test_changes.py (Sender): test it
3526 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3527 after any reading of the config file, not just when we do it in
3528 startService. This makes some tests a bit cleaner.
3530 * buildbot/changes/pb.py: add some log messages
3532 * buildbot/process/base.py (Build.startBuild): fix a bug that
3533 caused an exception when the build terminated in the very first
3535 (Build.stepDone): let steps return a status of EXCEPTION. This
3536 terminates the build right away, and sets the build's overall
3537 status to EXCEPTION too.
3538 * buildbot/process/step.py (BuildStep.failed): return a status of
3539 EXCEPTION when that is what has happened.
3541 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3542 implement this, allowing Arch-based projects to get precise
3543 checkouts instead of always using the latest code
3544 (Bazaar): create variant of Arch to let folks use baz instead of
3545 tla. Requires a new buildslave too.
3546 * buildbot/slave/commands.py (Arch): add 'revision' argument
3547 (Bazaar): create variant of Arch that uses baz instead of tla.
3548 Remove the code that extracts the archive name from the
3549 register-archive output, since baz doesn't provide it, and require
3550 the user provide both the archive name and its location.
3551 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3553 2005-05-02 Brian Warner <warner@lothar.com>
3555 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3556 thanks to Nick Trout.
3558 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3559 deals better with source Makefile coming from a read-only CVS
3560 checkout. Thanks to Nick Trout for the catch.
3562 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3565 2005-04-28 Brian Warner <warner@lothar.com>
3567 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3569 * debian/changelog: update for 0.6.4
3571 2005-04-28 Brian Warner <warner@lothar.com>
3573 * README.w32: add a checklist of steps for getting buildbot
3575 * MANIFEST.in: include it in the tarball
3579 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3580 broken .tap files from 0.6.3 by getting rid of .services,
3581 .namedServices, and .change_svc at load time.
3583 2005-04-27 Brian Warner <warner@lothar.com>
3585 * NEWS: update in preparation for new release
3587 * buildbot/test/test_config.py (Save.testSave): don't pull in
3588 twisted.scripts.twistd, we don't need it and it isn't for windows
3591 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3592 accomodate win32 which can't do atomic-rename
3594 2005-04-27 Brian Warner <warner@lothar.com>
3596 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3597 timeouts to help the slow metabuildbot not flunk them so much
3598 (Disconnect.testBuild3): same
3599 (Disconnect.testBuild4): same
3600 (Disconnect.testInterrupt): same
3602 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3603 setup, it was completely broken for new buildmasters (those which
3604 did not have a 'change.pck' already saved. Thanks to Paul Warren
3605 for catching this (embarrassing!) bug.
3606 (Dispatcher.__getstate__): don't save our registered avatar
3607 factories, since they'll be re-populated when the config file is
3609 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3610 tests (since the real mktap-generated BuildMaster doesn't save
3612 (BuildMaster.__getstate__): don't save any service children,
3613 they'll all be re-populated when the config file is re-read.
3614 * buildbot/test/test_config.py (Save.testSave): test for this
3616 2005-04-26 Brian Warner <warner@lothar.com>
3618 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3619 rendered with Blender.. looks a bit nicer.
3620 * buildbot/docs/images/icon.blend: add the Blender file for it
3622 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3623 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3624 running under windows. This appears to be the best way to allow
3625 BuildSteps to do something normal like 'trial -v buildbot.test' or
3626 'make foo' and still expect it to work. The idea is to make the
3627 BuildSteps look as much like what a developer would type when
3628 compiling or testing the tree by hand. This approach probably has
3629 problems when there are spaces in the arguments, so if you've got
3630 windows buildslaves, you'll need to pay close attention to your
3633 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3634 timezone to the timestamp column.
3635 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3637 * buildbot/scripts/runner.py (loadOptions): do something sane for
3638 windows, I think. We use %APPDATA%/buildbot instead of
3639 ~/.buildbot, but we still search everywhere from the current
3640 directory up to the root for a .buildbot/ subdir. The "is it under
3641 $HOME" security test was replaced with "is it owned by the current
3642 user", which is only performed under posix.
3643 * buildbot/test/test_runner.py (Options.testFindOptions): update
3644 tests to match. The "is it owned by the current user" check is
3645 untested. The test has been re-enabled for windows.
3647 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3648 any "\n" in the expected output with the platform-specific line
3649 separator. Make this separator "\r\n" on PTYs under unix, they
3650 seem to do that and I don't know why
3652 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3653 windows for now, I don't know what ~/.buildbot/ should mean there.
3655 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3656 win32 compatibility, don't use "/tmp"
3657 (Basedir.testChangeBuilddir): remove more unixisms
3659 2005-04-26 Brian Warner <warner@lothar.com>
3661 * buildbot/test/test_control.py (Force.rmtree): python2.2
3662 compatibility, apparently its shutil.rmtree ignore_errors=
3663 argument is ignored.
3664 * buildbot/test/test_run.py (Run.rmtree): same
3665 (RunMixin.setUp): same
3667 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3670 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3671 'substring in string' operator, must use string.find(substr)!=-1
3672 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3673 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3675 * buildbot/scripts/runner.py (loadOptions): add code to search for
3676 ~/.buildbot/, a directory with things like 'options', containing
3677 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3678 the current directory, your $HOME directory, or anywhere
3679 inbetween, as long as you're somewhere inside your home directory.
3680 (debugclient): look in ~/.buildbot/options for master and passwd
3681 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3682 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3684 * buildbot/status/client.py (makeRemote): new approach to making
3685 IRemote(None) be None, which works under Twisted-2.0
3686 * buildbot/test/test_status.py (Client.testAdaptation): test it
3688 * buildbot/status/builder.py (Status.builderAdded): when loading a
3689 pickled BuilderStatus in from disk, set its name after loading.
3690 The config file might have changed its name (but not its
3691 directory) while it wasn't looking.
3693 * buildbot/process/builder.py (Builder.attached): always return a
3694 Deferred, even if the builder was already attached
3695 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3697 2005-04-25 Brian Warner <warner@lothar.com>
3699 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3700 category-related exception when announcing a build has finished
3702 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3703 reference no-longer-existent changemaster.sources
3704 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3706 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3709 2005-04-25 Brian Warner <warner@lothar.com>
3711 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3713 * debian/changelog: update for 0.6.3
3715 2005-04-25 Brian Warner <warner@lothar.com>
3717 * MANIFEST.in: make sure debug.glade is in the tarball
3719 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3721 * NEWS: update for the imminent 0.6.3 release
3723 * buildbot/status/html.py (HtmlResource.content): make the
3724 stylesheet <link> always point at "buildbot.css".
3725 (StatusResource.getChild): map "buildbot.css" to a static.File
3726 containing whatever css= argument was provided to Waterfall()
3727 (Waterfall): provide the "classic" css as the default.
3728 * docs/waterfall.classic.css: move default CSS from here ..
3729 * buildbot/status/classic.css: .. to here
3731 * MANIFEST.in: make sure classic.css is included in the tarball
3732 * setup.py: and that it is installed too, under buildbot/status/
3734 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3735 the module level, because buildbot.tap files from 0.6.2 don't have
3736 it in their attribute dictionary.
3738 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3739 really exists at startup, might save some confusion somewhere.
3741 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3743 * docs/waterfall.classic.css:
3744 add a stylesheet that's almost the same as the "classic"
3747 * buildbot/status/builder.py:
3748 add EXCEPTION as a result - this is a problem for the bot
3749 maintainer, not a build problem for the changers
3750 * buildbot/process/step.py:
3751 use EXCEPTION instead of FAILURE for exceptions
3752 * buildbot/status/html.py:
3753 add build_get_class to get a class out of a build/buildstep
3754 finish naming the classes
3755 split out sourceNames to changeNames and builderNames so we
3756 can style them separately
3757 * docs/config.xhtml:
3758 finish documenting classes as they are right now
3760 * buildbot/status/html.py:
3761 name the classes as we agreed on IRC
3762 * docs/config.xhtml:
3765 * buildbot/status/html.py:
3766 same for cssclass->class_
3768 * buildbot/status/html.py:
3769 as decided on IRC, use class_ for the "class" attribute to not
3770 conflict with the class keyword, and clean up the messy **{} stuff.
3772 * buildbot/status/mail.py:
3773 put back "builders" argument, and fix docstring, because the
3774 code *ignores* builders listed in this argument
3776 * buildbot/process/builder.py:
3777 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3779 * docs/config.xhtml:
3780 describe the category argument for builders
3782 * buildbot/status/builder.py:
3783 Fix a silly bug due to merging
3785 * buildbot/process/builder.py:
3786 remove category from the process Builder ...
3787 * buildbot/status/builder.py:
3788 ... and add it to BuilderStatus instead.
3789 Set category on unpickled builder statuses, they might not have it.
3790 * buildbot/master.py:
3791 include category when doing builderAdded
3792 * buildbot/status/mail.py:
3793 return None instead of self for builders we are not interested in.
3794 * buildbot/test/test_run.py:
3795 fix a bug due to only doing deferredResult on "dummy" waiting
3796 * buildbot/test/test_status.py:
3797 add checks for the Mail IStatusReceiver returning None or self
3799 * buildbot/status/html.py:
3800 fix testsuite by prefixing page title with BuildBot
3802 * buildbot/status/builder.py:
3803 have .category in builder status ...
3804 * buildbot/process/builder.py:
3805 ... and set it from Builder
3806 * buildbot/status/html.py:
3807 make .css a class variable
3808 * buildbot/test/test_status.py:
3809 write more tests to cover our categories stuff ...
3810 * buildbot/status/mail.py:
3811 ... and fix the bug that this uncovered
3813 * buildbot/changes/mail.py:
3814 * buildbot/changes/pb.py:
3815 * buildbot/master.py:
3816 * buildbot/process/base.py:
3817 * buildbot/process/factory.py:
3818 * buildbot/process/interlock.py:
3819 * buildbot/process/step.py:
3820 * buildbot/process/step_twisted.py:
3821 * buildbot/slave/commands.py:
3822 * buildbot/status/builder.py:
3823 * buildbot/status/client.py:
3824 * buildbot/status/html.py:
3825 * buildbot/status/mail.py:
3826 * buildbot/status/progress.py:
3827 * buildbot/test/test_changes.py:
3828 * buildbot/test/test_config.py:
3829 * buildbot/test/test_control.py:
3830 * buildbot/test/test_interlock.py:
3831 * buildbot/test/test_maildir.py:
3832 * buildbot/test/test_mailparse.py:
3833 * buildbot/test/test_run.py:
3834 * buildbot/test/test_slavecommand.py:
3835 * buildbot/test/test_status.py:
3836 * buildbot/test/test_steps.py:
3837 * buildbot/test/test_twisted.py:
3838 * buildbot/test/test_util.py:
3839 * buildbot/test/test_vc.py:
3840 * buildbot/test/test_web.py:
3842 add test-case-name at the top of a whole set of files
3844 * buildbot/status/builder.py:
3845 keep order of addition when getting builder names
3846 * buildbot/status/words.py:
3847 * buildbot/test/test_run.py:
3848 add test for getBuilderNames
3850 * buildbot/process/base.py:
3851 * buildbot/process/step.py:
3852 * buildbot/status/builder.py:
3853 * buildbot/status/html.py:
3854 make buildbot css-able
3855 replace the color code for purple with purple, don't understand
3856 why it wasn't purple to start with
3858 * buildbot/status/words.py:
3859 ok, so it doesn't look like BuilderStatus.remote is still valid.
3860 Use what waterfall uses instead.
3862 * buildbot/interfaces.py:
3863 * buildbot/status/builder.py:
3864 * buildbot/status/html.py:
3865 * buildbot/status/mail.py:
3866 * buildbot/status/words.py:
3867 * buildbot/test/test_run.py:
3868 use categories everywhere and make it be a list. More sensible
3869 for the future. Also make words actually respect this in
3872 * buildbot/interfaces.py:
3873 add category argument to getBuilderNames
3874 * buildbot/process/builder.py:
3875 * buildbot/status/builder.py:
3876 * buildbot/status/html.py:
3877 * buildbot/status/mail.py:
3878 * buildbot/status/words.py:
3879 * buildbot/test/test_run.py:
3880 move from specifying builders by name to specifying the category
3882 * buildbot/status/html.py:
3883 * buildbot/status/words.py:
3884 add "builders=" to __init__ of status clients so they can
3885 limit themselves to the given list of builders to report on
3887 * buildbot/status/html.py: set the title to the product name
3889 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3891 * buildbot/interfaces.py:
3892 * buildbot/status/builder.py:
3893 more documentation. Hm, not sure if ChangeLog entries make sense
3896 2005-04-23 Brian Warner <warner@lothar.com>
3898 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3900 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3902 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3903 the sub-commands that log buildmaster status to stdout and to a
3904 GUI window, respectively.
3906 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3907 functionality is working again, but all the step-status and ETA
3908 stuff is missing. Commented out a lot of code pending more
3911 * buildbot/status/client.py: make sure that IRemote(None) is None
3913 * buildbot/changes/changes.py: import defer, oops
3914 (ChangeMaster): remove the .sources list, rely upon the fact that
3915 MultiServices can be treated as sequences of their children. This
3916 cleans up the add/remove ChangeSource routines a lot, as we keep
3917 exactly one list of the current sources instead of three.
3919 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3920 up an empty ChangeMaster at init time.
3921 (BuildMaster.loadChanges): if there are changes to be had from
3922 disk, replace self.change_svc with the new ones. If not, keep
3923 using the empty ChangeMaster set up in __init__.
3924 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3925 instead of a separate list, makes the code a bit cleaner.
3926 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3927 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3928 Extend the test to make sure we can get rid of the sources when
3931 2005-04-22 Brian Warner <warner@lothar.com>
3933 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3934 and info/host files when making the slave directory
3936 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3937 whendone= argument, just return the Deferred and let the caller do
3938 what they want with it.
3939 (Disconnect.testBuild1): wait for shutdownSlave
3940 (Basedir.testChangeBuilddir): new test to make sure changes to the
3941 builddir actually get propagated to the slave
3943 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3944 explicit method, rather than passing the builddir in __init__ .
3945 Make sure to update self.basedir too, this was broken before.
3946 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3947 builders and for ones that have just had their builddir changed.
3948 (BotFactory): add a class-level .perspective attribute, so
3949 BuildSlave.waitUntilDisconnected won't get upset when the
3950 connection hasn't yet been established
3951 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3952 tests can reach through it to inspect the SlaveBuilders
3954 * buildbot/process/base.py (Build.buildException): explain the
3955 log.err with a log.msg
3956 * buildbot/process/builder.py (Builder.startBuild): same
3957 (Builder._startBuildFailed): improve error message
3959 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3960 occurred because we lost the brand-new connection, retry instead
3961 of giving up. If not, it's probably an authorization failure, and
3962 it makes sense to stop trying. Make sure we log.msg the reason
3963 that we're log.err'ing the failure, otherwise test failures are
3964 really hard to figure out.
3966 * buildbot/master.py: change loadConfig() to return a Deferred
3967 that doesn't fire until the change has been fully implemented.
3968 This means any connected slaves have been updated with the new
3969 builddir. This change makes it easier to test the code which
3970 actually implements this builddir-updating.
3971 (BotPerspective.addBuilder): return Deferred
3972 (BotPerspective.removeBuilder): same
3973 (BotPerspective.attached): same
3974 (BotPerspective._attached): same. finish with remote_print before
3975 starting the getSlaveInfo, instead of doing them in parallel
3976 (BotPerspective.list_done): same
3977 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3978 actually calling slave.disconnect()
3979 (BotMaster.addBuilder): same
3980 (BotMaster.removeBuilder): same
3981 (BuildMaster.loadConfig): same
3982 (BuildMaster.loadConfig_Slaves): same
3983 (BuildMaster.loadConfig_Sources): same
3984 (BuildMaster.loadConfig_Builders): same
3985 (BuildMaster.loadConfig_status): same
3987 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3988 a Deferred that fires when the source is finally removed
3990 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3991 the previous tree on win32, where we have to do it synchronously,
3992 make sure we return a Deferred anyway.
3993 (SourceBase.doCopy): same
3995 * buildbot/scripts/runner.py (statusgui): use the text client for
3996 now, while I rewrite the Gtk one
3997 * buildbot/clients/base.py: strip out old code, leaving just the
3998 basic print-message-on-event functionality. I also remove the
3999 ReconnectingPBClientFactory, but it does at least quit when it
4000 loses the connection instead of going silent
4002 2005-04-21 Brian Warner <warner@lothar.com>
4004 * Makefile: minor tweaks
4006 * NEWS: point out deprecation warnings, new features for
4009 * buildbot/master.py (BuildMaster.loadConfig): emit
4010 DeprecationWarnings for Builders defined with tuples. Rearrange
4011 code to facility removal of deprecated configuration keys in the
4014 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4015 'buildbot' command to put a little Makefile in the target that
4016 helps you re-create the buildbot.tap file, start or stop the
4017 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4018 all the files 0600, since they contain passwords.
4019 (start): if there is a Makefile, and /usr/bin/make exists, use
4020 'make start' in preference to a raw twistd command. This lets
4021 slave admins put things like PYTHONPATH variables in their
4022 Makefiles and have them still work when the slave is started with
4023 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4024 be nice to first try the 'make' command and only fall back to
4025 twistd if it fails. TODO: the Makefile's "start" command does not
4026 add the --reactor=win32 argument when running under windows.
4027 (Options.debugclient, Options.statusgui): add sub-commands to launch
4028 the debug client (formerly in contrib/debugclient.py) and the
4029 Gtk status application (currently broken)
4030 * buildbot/clients/debug.py: move from contrib/debugclient.py
4031 * buildbot/clients/debug.glade: same
4033 * buildbot/test/test_trial.py: remove it. This requires some
4034 functionality out of Twisted that isn't there yet, and until then
4035 having it around just confuses things.
4037 * buildbot/test/test_slavecommand.py (Shell): test both with and
4038 without PTYs, and make sure that command output is properly
4039 interleaved in the with-PTY case. I think the without-PTY test
4040 should pass on windows, where we never use PTYs anyway.
4042 2005-04-20 Brian Warner <warner@lothar.com>
4044 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4046 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4048 * NEWS: start creating entries for the next release
4050 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4052 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4053 (WebTest.test_webPathname): same
4054 (WebTest.test_webPathname_port): same
4055 (WebTest.test_waterfall): use the default favicon rather than
4056 rooting around the filesystem for it. Open the expected-icon file
4057 in binary mode, to make win32 tests happier (thanks to Nick Trout
4059 * buildbot/status/html.py (buildbot_icon): win32 portability
4061 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4062 win32-compatibility fixes from Nick Trout, the "file not found" message
4063 is different under windows
4064 (FakeSlaveBuilder.__init__): clean up setup a bit
4065 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4067 2005-04-19 Brian Warner <warner@lothar.com>
4069 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4070 skip-if-repositories-are-unavailable test to not kill the trial
4071 that comes with Twisted-1.3.0
4073 * setup.py: install buildbot.png icon file when installing code
4075 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4076 environment used by the command, at least on the child side.
4078 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4079 this method needs to be added and implemented because it gets
4080 called under heavy load. I don't quite understand the
4081 producer/consumer API enough to write it.
4082 (StatusResource.getChild): add a resource for /favicon.ico
4083 (Waterfall.__init__): add favicon= argument
4084 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4085 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4086 (WebTest.test_webPathname): same
4087 (WebTest.test_webPathname_port): same
4088 * docs/config.xhtml: mention favicon=
4089 * buildbot/buildbot.png: add a default icon, dorky as it is
4091 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4093 * buildbot/master.py:
4094 * buildbot/process/base.py:
4095 * buildbot/process/builder.py:
4096 * buildbot/process/interlock.py:
4097 * buildbot/status/builder.py:
4098 * buildbot/status/html.py:
4099 * buildbot/status/mail.py:
4100 * buildbot/status/words.py:
4101 new documentation while digging through the code
4103 2005-04-17 Brian Warner <warner@lothar.com>
4105 * general: try to fix file modes on all .py files: a+r, a-x,
4106 but let buildbot/clients/*.py be +x since they're tools
4108 * docs/epyrun (addMod): when an import fails, say why
4110 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4112 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4114 * buildbot/process/base.py:
4115 * buildbot/process/builder.py:
4116 * buildbot/status/builder.py:
4117 new documentation while digging through the code
4119 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4121 * buildbot/changes/changes.py:
4122 * buildbot/changes/p4poller.py:
4123 * buildbot/interfaces.py:
4124 * buildbot/process/base.py:
4125 * buildbot/process/builder.py:
4126 * buildbot/process/step.py:
4127 * buildbot/process/step_twisted.py:
4128 * buildbot/slave/bot.py:
4129 * buildbot/slave/commands.py:
4130 * buildbot/status/builder.py:
4131 fix all docstrings to make epydoc happy. In the process of fixing
4132 some, I also moved pieces of docs, and removed some deprecated
4135 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4137 * buildbot/process/builder.py:
4138 * buildbot/process/interlock.py:
4139 * buildbot/process/process_twisted.py:
4140 * buildbot/process/step.py:
4141 BuildProcess -> Build, as it looks like that's what happened
4142 * buildbot/process/base.py:
4143 * buildbot/process/factory.py:
4146 2005-04-17 Brian Warner <warner@lothar.com>
4148 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4149 update compile command to accomodate the Twisted split.. now
4150 instead of './setup.py build_ext -i', you do './setup.py all
4151 build_ext -i', to run build_ext over all sub-projects.
4152 (FullTwistedBuildFactory): same
4153 (TwistedReactorsBuildFactory): same
4155 * buildbot/status/html.py (TextLog.finished): null out self.req
4156 when we're done, otherwise the reference cycle of TextLog to .req
4157 to .notifications to a Deferred to TextLog.stop keeps them from
4158 being collected, and consumes a huge (610MB on pyramid at last
4159 check) amount of memory.
4161 2005-04-11 Brian Warner <warner@lothar.com>
4163 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4164 normalize the VC-repository location.. makes SVN happier with
4165 certain test environments.
4167 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4168 RemoteShellCommand gets its own .env dictionary, so that code in
4169 start() doesn't mutate the original. I think this should fix the
4170 step_twisted.Trial problem where multiple identical components
4171 kept getting added to PYTHONPATH= over and over again.
4173 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4174 adding epydoc-format docstrings to many classes. Thanks to Thomas
4175 Vander Stichele for the patches.
4176 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4177 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4178 * buildbot/slave/bot.py, commands.py, registry.py: same
4180 2005-04-05 Brian Warner <warner@lothar.com>
4182 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4183 preserve timestamps, helps incremental builds of large trees.
4184 Patch from Rene Rivera.
4186 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4187 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4190 2005-04-03 Brian Warner <warner@lothar.com>
4192 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4193 with one dict, apparently exec has some scoping bugs when used
4194 with both global/local dicts. Thanks to Nathaniel Smith for the
4197 2005-04-02 Brian Warner <warner@lothar.com>
4199 * buildbot/process/step_twisted.py (countFailedTests): the new
4200 trial in Twisted-2.0 emits a slightly different status line than
4201 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4202 mistakenly think the test count is unparseable.
4203 (Trial.start): note that for some reason each build causes another
4204 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4205 be fixed but I'm not sure quite where the problem is.
4207 2005-04-01 Brian Warner <warner@lothar.com>
4209 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4210 deferredResult to avoid hangs/warnings under twisted-2.0
4211 (RunMixin.tearDown): same
4212 (RunMixin.shutdownSlave): same
4213 (Disconnect.testIdle1): same
4214 (Disconnect.testBuild2): same: wait one second after the build
4215 finishes for test to really be done.. this should be cleaned up to
4216 avoid wasting that second. Builder.detach uses a callLater(0),
4217 either that should be done in-line (something else needed that
4218 behavior), or it should return a Deferred that fires when the
4219 builder is really offline.
4220 (Disconnect.testBuild3): same
4221 (Disconnect.testDisappear): same
4223 * buildbot/test/test_web.py: rearrange server-setup and teardown
4224 code to remove unclean-reactor warnings from twisted-2.0
4226 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4227 so the tests don't hang under twisted-2.0
4229 2005-03-31 Brian Warner <warner@lothar.com>
4231 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4232 caused a warning each time the master changed our set of builders
4234 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4235 w32, don't unlink the file unless it already exists. Thanks to
4236 Baptiste Lepilleur for the catch.
4237 (BuilderStatus.saveYourself): same
4239 2005-02-01 Brian Warner <warner@lothar.com>
4241 * buildbot/status/html.py (TextLog.getChild): use a /text child
4242 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4243 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4244 logfile as text/plain (no markup, no headers). This replaces the
4245 previous scheme (which used an ?text=1 argument), and gets us back
4246 to a relative link (which works better when the buildbot lives
4247 behind another web server, such as Apache configured as a reverse
4248 proxy). Thanks to Gerald Combs for spotting the problem.
4250 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4253 2004-12-13 Brian Warner <warner@lothar.com>
4255 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4257 * debian/changelog: update for 0.6.2
4258 * NEWS: finalize for 0.6.2
4260 2004-12-11 Brian Warner <warner@lothar.com>
4262 * NEWS: bring it up to date
4264 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4265 detection code. Require some sign of life from the buildmaster
4266 every BotFactory.keepaliveInterval seconds. Provoke this
4267 indication at BotFactory.keepaliveTimeout seconds before the
4268 deadline by sending a keepalive request. We don't actually care if
4269 that request is answered in a timely fashion, what we care about
4270 is that .activity() is called before the deadline. .activity() is
4271 triggered by any PB message from the master (including an ack to
4272 one of the slave's status-update messages). With this new scheme,
4273 large status messages over slow pipes are OK, as long as any given
4274 message can be sent (and thus acked) within .keepaliveTimeout
4275 seconds (which defaults to 30).
4276 (SlaveBuilder.remote_startCommand): record activity
4277 (SlaveBuilder.ackUpdate): same
4278 (SlaveBuilder.ackComplete): same
4279 (BotFactory.gotPerspective): same
4280 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4282 2004-12-09 Brian Warner <warner@lothar.com>
4284 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4287 * buildbot/process/step_twisted.py (Trial._commandComplete):
4288 update self.cmd when we start the 'cat test.log' transfer. Without
4289 this, we cannot interrupt the correct RemoteCommand when we lose
4292 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4293 trying to tell the slave to stop the command if we're already
4294 inactive, or if we no longer have a .remote
4296 * buildbot/process/builder.py (Builder._detached): don't let an
4297 exception in currentBuild.stopBuild() prevent the builder from
4298 being marked offline
4300 2004-12-07 Brian Warner <warner@lothar.com>
4302 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4303 KeyError that happens when you ask for a non-existent Builder, and
4304 translate it into a UsageError.
4306 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4307 losing the slave in the middle of a remote step is handled too
4309 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4310 be a Failure, so be sure to stringify it before using it as the
4311 contents of the 'interrupt' logfile
4312 (RemoteCommand.interrupt): use stringified 'why' in
4313 remote_interruptCommand too, just in case
4315 2004-12-06 Brian Warner <warner@lothar.com>
4317 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4318 instead of 'tla update', which is more efficient in case we've
4319 missed a couple of patches since the last update.
4321 * debian/changelog: update for previous (0.6.1) release. Obviously
4322 this needs to be handled better.
4324 2004-12-05 Brian Warner <warner@lothar.com>
4326 * NEWS: update for stuff since last release
4328 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4329 match the maybeDeferred change in Dispatcher.requestAvatar
4330 * buildbot/changes/pb.py (ChangePerspective.attached): same
4331 * buildbot/status/client.py (StatusClientPerspective.attached): same
4332 * buildbot/process/builder.py (Builder._attached3): same
4333 * buildbot/pbutil.py (NewCredPerspective.attached): same
4335 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4336 the date to the top-most box, if it is not the same as today's
4339 * docs/slave.xhtml: provide a buildslave setup checklist
4341 * docs/source.xhtml (Arch): correct terminology
4343 2004-12-04 Brian Warner <warner@lothar.com>
4345 * buildbot/test/test_slavecommand.py: use sys.executable instead
4346 of hard-coding 'python' for child commands, might help portability
4348 * docs/examples/twisted_master.cfg: update to current usage
4350 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4351 'stop build' command to the IRC bot
4353 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4354 message that broke PBChangeSource
4356 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4357 (SlaveBuilder): make some attributes class-level, remove the old
4358 "update queue" which existed to support resuming a build after the
4359 master connection was lost. Try to reimplement that feature later.
4360 (SlaveBuilder.stopCommand): clear self.command when the
4361 SlaveCommand finishes, so that we don't try to kill a leftover one
4363 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4366 * buildbot/slave/commands.py (SourceBase): set self.command for
4367 all VC commands, so they can be interrupted.
4369 2004-12-03 Brian Warner <warner@lothar.com>
4371 * buildbot/master.py: clean up slave-handling code, to handle
4372 slave-disconnect and multiple-connect better
4373 (BotPerspective): make these long-lasting, exactly one per bot
4374 listed in the config file.
4375 (BotPerspective.attached): if a slave connects while an existing
4376 one appears to still be connected, disconnect the old one first.
4377 (BotPerspective.disconnect): new method to forcibly disconnect a
4378 buildslave. Use some hacks to empty the transmit buffer quickly to
4379 avoid the long (20-min?) TCP timeout that could occur if the old
4380 slave has dropped off the net.
4381 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4382 own their own SlaveStatus objects. Remove .attached/.detached, add
4383 .addSlave/.removeSlave, treat slaves like Builders (config file
4384 parsing sends deltas to the BotMaster). Inform the slave
4385 instances, i.e. the BotPerspective, about addBuilder and
4387 (BotMaster.getPerspective): turns into a single dict lookup
4388 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4389 which gives BotPerspective.attached a chance to disconnect the old
4391 (BuildMaster.loadConfig): add code (disabled) to validate that all
4392 builders use known slaves (listed in c['bots']). The check won't
4393 work with tuple-specified builders, which are deprecated but not
4394 yet invalid, so the check is disabled for now.
4395 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4396 routine, do the add/changed/removed dance with them like we do
4398 (BuildMaster.loadConfig_Sources): move source-config into a
4399 separate routine too
4401 * buildbot/status/builder.py (Status.getSlave): get the
4402 SlaveStatus object from the BotPerspective, not the BotMaster.
4404 * buildbot/test/test_run.py: bunch of new tests for losing the
4405 buildslave at various points in the build, handling a slave that
4406 connects multiple times, and making sure we can interrupt a
4409 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4410 something other than 'Bot' for the Bot object, to make certain
4411 test cases easier to write.
4412 (BuildSlave.waitUntilDisconnected): utility method for testing
4414 2004-11-30 Brian Warner <warner@lothar.com>
4416 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4418 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4419 argument, return a Deferred that always fires with True or False.
4420 I don't use an errback to indicate 'ping failed' so that callers
4421 are free to ignore the deferred without causing spurious errors in
4423 * buildbot/process/builder.py (BuilderControl.ping): implement it
4425 * buildbot/test/test_run.py (Status.testDisappear): test ping
4426 (Status.disappearSlave): fix it
4428 2004-11-30 Brian Warner <warner@lothar.com>
4430 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4431 (IBuilderControl): add .getBuild(num), only works for the current
4432 build, of course, although it might be interesting to offer
4433 something for builds in the .waiting or .interlocked state.
4435 * buildbot/process/base.py (Build): have .stopBuild just do the
4436 interrupt, then let the build die by itself.
4437 (BuildControl): add .stopBuild, and add a point-event named
4438 'interrupt' just after the build so status viewers can tell that
4440 (BuilderControl): add .getBuild
4442 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4443 stops when you kill it, good for testing
4444 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4445 contains the 'reason' text.
4447 * buildbot/status/html.py: Add Stop Build button, if the build can
4448 still be stopped. Send a Redirect (to the top page) one second
4449 later, hopefully long enough for the interrupt to have an effect.
4450 Move make_row() up to top-level to share it between Stop Build and
4453 * buildbot/slave/commands.py: only kill the child process once
4455 * buildbot/test/test_run.py: add testInterrupt
4457 2004-11-29 Brian Warner <warner@lothar.com>
4459 * buildbot/process/base.py: Refactor command interruption. The
4460 Build is now responsible for noticing that the slave has gone
4461 away: Build.lostRemote() interrupts the current step and makes
4462 sure that no further ones will be started.
4464 * buildbot/process/builder.py: When the initial remote_startBuild
4465 message fails, log it: this usually indicates that the slave has
4466 gone away, but we don't really start paying attention until they
4467 fail to respond to the first step's command.
4469 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4470 slave disconnect. Now sports a new interrupt() method. Error
4471 handling was simplified a lot by chaining deferreds, so
4472 remoteFailed/remoteComplete were merged into a single
4473 remoteComplete method (which can now get a Failure object).
4474 Likewise failed/finished were merged into just _finished.
4475 (BuildStep): Add interrupt(why) method, and if why is a
4476 ConnectionLost Failure then the step is failed with some useful
4479 * buildbot/slave/bot.py: stop the current command when the remote
4480 Step reference is lost, and when the slave is shut down.
4481 (Bot): make it a MultiService, so it can have children. Use
4482 stopService to tell when the slave is shutting down.
4483 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4484 remote_interruptCommand (which asks the current SlaveCommand to
4485 stop but allows it to keep emitting status messages), and
4486 stopCommand (which tells it to shut up and die).
4488 * buildbot/slave/commands.py: make commands interruptible
4489 (ShellCommand.kill): factor out os.kill logic
4490 (Command): factor out setup()
4491 (Command.sendStatus): don't send status if .running is false, this
4492 happens when the command has been halted.
4493 (Command.interrupt): new method, used to tell the command to die
4494 (SlaveShellCommand): implement .interrupt
4495 (DummyCommand): implement .interrupt
4496 (SourceBase, etc): factor out setup(), don't continue substeps if
4499 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4500 so they can be called after finishing
4502 * buildbot/test/test_run.py: new tests for disconnect behavior,
4503 refactor slave-shutdown routines, add different kinds of
4506 2004-11-27 Brian Warner <warner@lothar.com>
4508 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4509 method to express ETA time like "2m45s" instead of "165 seconds"
4511 2004-11-24 Brian Warner <warner@lothar.com>
4513 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4514 archive after the test completes, to avoid cluttering the user's
4515 'tla archives' listing with a bogus entry. Arch doesn't happen to
4516 provide any way to override the use of ~/.arch-params/, so there
4517 isn't a convenient way to avoid touching the setup of the user who
4519 (VC_HTTP.testArchHTTP): same
4521 2004-11-23 Brian Warner <warner@lothar.com>
4523 * buildbot/status/html.py (TextLog): split render() up into
4524 render_HEAD and render_GET. Use a Producer when sending log
4525 chunks, to reduce memory requirements and avoid sending huge
4526 non-Banana-able strings over web.distrib connections. Requires
4527 peeking under the covers of IStatusLog.
4528 (TextLog.resumeProducing): fix the "as text" link, handle client
4529 disconnects that occur while we're still sending old chunks.
4531 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4532 use defer.succeed, not the non-existent defer.success
4533 (LogFile.waitUntilFinished): same
4534 (LogFile.subscribe): don't add watchers to a finished logfile
4536 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4539 2004-11-23 Brian Warner <warner@lothar.com>
4541 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4543 2004-11-23 Brian Warner <warner@lothar.com>
4545 * NEWS: update for the 0.6.1 release
4546 * MANIFEST.in: add new files
4548 * README (INSTALLATION): explain how to enable the extra VC tests
4550 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4551 level to, so old pickled builds can be displayed ok
4553 2004-11-22 Brian Warner <warner@lothar.com>
4555 * NEWS: summarize updates since last release
4557 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4558 Yoz Grahame. Closes SF#1050138.
4560 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4563 * buildbot/process/step_twisted.py (Trial): update docs a bit
4565 * docs/factories.xhtml: fix Trial factory docs to match reality.
4568 * buildbot/process/factory.py (Trial.__init__): add args for
4569 randomly= and recurse=, making them available to instantiators
4570 instead of only to subclassers. Closes: SF#1049759.
4572 2004-11-15 Brian Warner <warner@lothar.com>
4574 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4575 try to teach the Quick factory to use multiple versions of python
4577 2004-11-12 Brian Warner <warner@lothar.com>
4579 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4580 safer w32-compatible approach, and only use it on windows
4581 (BuildStatus.saveYourself): same
4583 2004-11-11 Brian Warner <warner@lothar.com>
4585 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4586 it: one string merge per chunk. There are now separate .entries
4587 and .runEntries lists: when enumerating over all chunks, make sure
4589 * buildbot/test/test_status.py (Log): more tests
4591 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4592 chunks together, up to 10kb per chunk. This ought to cut down on
4593 the CPU-burning overhead of large log files. Thanks to Alexander
4594 Staubo for spotting the problem.
4595 * buildbot/test/test_status.py (Log): tests for same
4597 2004-11-10 Brian Warner <warner@lothar.com>
4599 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4600 header to outbound mail
4601 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4603 2004-11-08 Brian Warner <warner@lothar.com>
4605 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4606 can't do os.rename() onto an existing file, so catch the exception
4607 and unlink the target file first. This introduces a slight window
4608 where the existing file could be lost, but the main failure case
4609 (disk full) should still be handled safely.
4610 (BuildStatus.saveYourself): same
4612 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4613 separator character instead of os.sep, because the filenames being
4614 split here are coming from the VC system, which can have a
4615 different pathname convention than the local host. This should
4616 help a buildmaster running on windows that uses a CVS repository
4617 which runs under unix.
4618 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4620 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4621 when there are no test failures to be parsed
4623 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4624 instead of the unix-specific os.system("cp"), thanks to Elliot
4625 Murphy for this and the other buildbot-vs-windows catches.
4626 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4628 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4629 echo the command as it is run
4631 * setup.py: install sample.mk too, not just sample.cfg
4632 (scripts): install contrib/windows/buildbot.bat on windows
4634 2004-11-07 Brian Warner <warner@lothar.com>
4636 * buildbot/process/builder.py (Builder._detached): clear the
4637 self.currentBuild reference, otherwise the next build will be
4638 skipped because we think the Builder is already in use.
4640 * docs/examples/twisted_master.cfg: update to match current usage
4641 on the Twisted buildbot
4643 2004-10-29 Brian Warner <warner@lothar.com>
4645 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4647 2004-10-28 Brian Warner <warner@lothar.com>
4649 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4650 have separate doVCUpdate/doVCFull methods. Catch an update failure
4651 and respond by clobbering the source directory and re-trying. This
4652 will handle local changes (like replacing a file with a directory)
4653 that will cause CVS and SVN updates to fail.
4654 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4656 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4659 2004-10-19 Brian Warner <warner@lothar.com>
4661 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4663 * buildbot/status/html.py (StatusResourceTestResults): display any
4664 TestResults that the Build might have
4665 (StatusResourceTestResult): and the logs for each TestResult
4666 (StatusResourceBuild): add link from the per-build page
4668 2004-10-15 Brian Warner <warner@lothar.com>
4670 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4671 the 'problems' portion of stdout, add TestResults to our build
4672 * buildbot/test/test_twisted.py (Parse.testParse): test it
4674 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4675 to retrieve a dict of accumulated test results
4676 (ITestResult): define what a single test result can do
4677 * buildbot/status/builder.py (TestResult): implement ITestResult
4678 (BuildStatus.getTestResults): retrieve dict of TestResults
4679 (BuildStatus.addTestResult): add TestResults
4680 * buildbot/test/test_status.py (Results.testAddResults): test it
4682 2004-10-14 Brian Warner <warner@lothar.com>
4684 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4685 instead of os.system("rm -rf") for win32 portability
4687 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4688 SignalMixin instead of starting/stopping the reactor, which is
4689 likely to cause problems with other tests
4691 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4692 self.copyComplete() call. Yoz Grahame makes the catch.
4694 * contrib/windows/buildbot.bat: helper script to deal with path
4695 issues. Thanks to Yoz Grahame.
4697 * buildbot/master.py (BuildMaster.startService): don't register a
4698 SIGHUP handler if the signal module has no SIGHUP attribute.
4699 Apparently win32 does this.
4701 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4703 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4704 test if the reactor can't offer UNIX sockets
4706 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4707 error introduced in the last commit. We really need that
4710 2004-10-12 Brian Warner <warner@lothar.com>
4712 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4713 when describing a maildir source. Thanks to Stephen Davis.
4715 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4718 * buildbot/scripts/runner.py (createMaster): install Makefile too
4719 (start): add --no_save to 'start' command
4720 * buildbot/scripts/sample.mk: simple convenience Makefile with
4721 start/stop/reload targets
4723 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4726 2004-09-30 Brian Warner <warner@lothar.com>
4728 * setup.py: Releasing buildbot-0.6.0
4730 2004-09-30 Brian Warner <warner@lothar.com>
4732 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4733 test_trial.py from the source tarball until support is complete.
4735 * NEWS: update for 0.6.0 release
4736 * buildbot/__init__.py (version): same
4739 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4740 'source' command to tell users where to get the Buildbot source
4742 * docs/examples/*.cfg: update to modern standards
4744 * NEWS: update for release
4746 * buildbot/scripts/runner.py (createMaster): remove the
4747 -shutdown.tap stuff now that it isn't necessary
4749 (start): launch buildbot.tap, not buildbot-shutdown.tap
4752 * buildbot/status/mail.py (Domain): shorten class name
4753 (MailNotifier): if lookup= is a string, pass it to Domain()
4754 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4755 (Mail.testBuild2): test the string-to-Domain shortcut
4756 (Mail.testMail): fix test
4759 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4762 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4763 more attributes on load
4764 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4765 to accomodate the whole waterfall page at once, and the thrashing
4766 results in a lot of unnecessary loads
4767 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4768 (BuilderStatus.saveYourself): same
4769 (BuilderStatus.eventGenerator): stop generating on the first missing
4770 build. We assume that saved builds are deleted oldest-first.
4771 (BuildStepStatus.__getstate__): .progress might not exist
4773 * buildbot/changes/changes.py (ChangeMaster): make it
4774 serializable, in $masterdir/changes.pck
4775 (ChangeMaster.stopService): save on shutdown
4776 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4777 * buildbot/test/test_config.py: load Changes before config file
4780 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4781 "Oh my god, you killed the command" header on a separate line
4783 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4784 skip over corrupted build pickles
4785 (BuilderStatus.getFullBuildByNumber): same
4786 (BuilderStatus.eventGenerator): skip over unavailable builds
4787 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4788 do an atomic rename. This prevents a corrupted pickle when some
4789 internal serialization error occurs.
4790 (BuilderStatus.saveYourself): same
4792 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4793 the timeout for shell commands, it got lost somehow
4795 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4796 run out of build steps, return the rest of the builder events
4798 * buildbot/interfaces.py (IBuilderControl.ping): add method
4800 * buildbot/process/builder.py (BuilderControl.ping): move
4801 slave-ping to BuilderControl, and fix the failure case in the
4802 process (Event.finish() is the verb, Event.finished is the noun).
4804 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4805 through the BuilderControl instead of the BuilderStatus
4806 (EventBox): add adapter for builder.Event, allowing builder events to
4807 be displayed in the waterfall display
4809 * buildbot/master.py (BotMaster.stopService): add a 'master
4810 shutdown' event to the builder's log
4811 (BuildMaster.startService): and a 'master started' on startup
4813 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4814 builder events into the BuildStep event stream
4815 (Status.builderAdded): add a 'builder created' event
4818 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4819 command to announce the completion of a running build
4820 (IrcStatusBot.command_FORCE): announce when the build finishes
4822 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4823 don't evict unfinished builds from the cache: they must stay in
4824 the full-cache until their logfiles have stopped changing. Make
4825 sure the eviction loop terminates if an unfinished build was hit.
4826 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4827 This lets exceptions be dumped in an email status message. Really
4828 we need LogFiles which contain both text and HTML, instead of two
4830 (BuildStatus.__getstate__): handle self.finished=False
4831 (Status.builderAdded): if the pickle is corrupted, abandon the
4832 history and create a new BuilderStatus object.
4834 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4835 self.progress attribute, helped one test which doesn't fully set
4836 up the Build object.
4838 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4839 IStatusLog methods into an Interface that is implemented by "stub"
4840 logs, for which all the actual text chunks are on disk (in the
4841 pickled Build instance). To show the log contents, you must first
4842 adapt the stub log to a full IStatusLog object.
4844 * buildbot/status/builder.py (LogFileStub): create separate stub
4845 log objects, which can be upgraded to a real one if necessary.
4846 (LogFile): make them persistable, and let them stubify themselves
4848 (BuildStepStatus): same
4850 (BuildStatus.saveYourself): save the whole build out to disk
4851 (BuilderStatus): make it persistable
4852 (BuilderStatus.saveYourself): save the builder to disk
4853 (BuilderStatus.addFullBuildToCache): implement two caches which
4854 hold Build objects: a small one which holds full Builds, and a
4855 larger one which holds "stubbed" Builds (ones with their LogFiles
4856 turned into LogFileStubs). This reduces memory usage by the
4857 buildmaster by not keeping more than a few (default is 2) whole
4858 build logs in RAM all the time.
4859 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4861 (BuilderStatus.eventGenerator): rewrite since .builds went away
4862 (BuilderStatus.buildStarted): remove the .builds array. Add the
4863 build to the "full" cache when it starts.
4864 (BuilderStatus._buildFinished): save the build to disk when it
4866 (Status): give it a basedir (same as the BuildMaster's basedir)
4867 where the builder pickles can be saved
4868 (Status.builderAdded): create the BuilderStatus ourselves, by
4869 loading a pickle from disk (or creating a new instance if there
4870 was none on disk). Return the BuilderStatus so the master can glue
4871 it into the new Builder object.
4873 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4874 all BuilderStatuses to save themselves out to disk. This is in
4875 lieu of saving anything important in the main Application pickle
4876 (the -shutdown.tap file).
4877 (BuildMaster.__init__): give Status() a basedir for its files
4878 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4879 to get the BuilderStatus, then give it to the Builder (instead of
4880 doing it the other way around). It's ok if the status announces
4881 the new Builder before it's really ready, as the outside world can
4882 only see the BuilderStatus object anyway (and it is ready before
4883 builderAdded returns). Use the builder's "builddir" (which
4884 normally specifies where the slave will run the builder) as the
4885 master's basedir (for saving serialized builds).
4887 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4888 coerce the logfile to IStatusLog before trying to get the text
4889 chunks out of it. This will pull the full (non-stubified) Build in
4890 from disk if necessary.
4891 (TextLog): fix the adapter registration
4893 * buildbot/test/test_control.py (Force.setUp): create the basedir
4894 * buildbot/test/test_web.py: same
4895 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4896 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4897 * buildbot/test/test_run.py (Run.testMaster): same
4898 (Status.setUp): same
4900 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4902 * buildbot/status/html.py (Waterfall.__init__): store actual
4903 allowForce flag passed in rather than using True for everyone;
4904 make sure setting it to False doesn't cause a NameError
4906 (StatusResourceBuilder.__init__) add the builder name to the page
4908 (StatusResourceBuilder.body) move HTML generation for a name/value
4909 row into a helper method (StatusResourceBuilder.make_row); only
4910 generate the "Force Build" form if allowForce was True and the
4911 slave is connected. Use class attributes in the generated HTML to
4912 spread a little CSS-joy.
4914 2004-09-28 Brian Warner <warner@lothar.com>
4916 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4917 warning-scanner to not ignore things like
4918 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4920 * buildbot/status/html.py (StatusResource.control): add some
4921 class-level values for .control in an attempt to make upgrading
4924 * buildbot/util.py (ComparableMixin): survive missing attributes,
4925 such as when a class is modified and we're comparing old instances
4928 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4929 failure handling, remove a redundant try/except block. Don't
4930 return the full traceback to the IRC channel.
4931 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4932 error messages. Get ETA properly.
4934 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4935 the reason, since (at least) IRC message will have <> in them.
4936 (StatusResourceBuilder.__init__): take an IBuilderControl
4937 (StatusResourceBuilder.force): use the IBuilderControl we get in
4938 the constructor instead of trying to make our own. Catch the
4939 new exceptions and ignore them for now (until we make an
4940 intermediate web page where we could show the error message)
4941 (StatusResource): create with an IControl, use it to give an
4942 IBuilderControl to all children
4943 (Waterfall): take an allowForce= option, pass an IControl object
4944 to StatusResource if it is True
4946 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4948 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4949 catch new exceptions and return string forms
4951 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4952 * buildbot/process/builder.py (Builder.forceBuild): raise them
4953 * buildbot/test/test_control.py (Force.testNoSlave): new test
4954 (Force.testBuilderInUse): same
4957 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4959 * buildbot/test/test_run.py: use IControl
4960 * buildbot/test/test_vc.py: same
4962 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4963 to use IControl. Still offline.
4964 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4966 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4967 who=None so periodic builds don't send out status mail
4968 (Builder.forceBuild): include reason in the log message
4969 (BuilderControl.forceBuild): rename 'name' to 'who'
4971 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4972 'who' parameter, but make it None by default so builds forced by
4973 slave admins don't cause status mail to be sent to anybody
4974 (BotMaster.forceBuild): same. this method is deprecated.
4975 (DebugPerspective.perspective_forceBuild): same, use IControl.
4976 (DebugPerspective.perspective_fakeChange): use IControl..
4977 (Dispatcher.requestAvatar): .. so don't set .changemaster
4979 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4980 parameter to avoid confusion with the name of the builder
4983 * buildbot/status/mail.py: refine comment about needing 2.3
4985 * buildbot/status/html.py: move all imports to the top
4987 * buildbot/test/test_control.py: test new interfaces
4988 * buildbot/test/test_run.py (Status): handle new interfaces
4989 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4991 * buildbot/process/base.py (BuildControl): implement IBuildControl
4992 and its lonely getStatus() method
4994 * buildbot/process/builder.py (BuilderControl): implement
4995 IBuilderControl, obtained by adapting the Builder instance
4996 (Builder.startBuild): return a BuilderControl instead of a
4997 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4998 accomplish the same thing.
5000 * buildbot/master.py: move all import statements to the top
5001 (Control): implement IControl, obtained by adapting the
5002 BuildMaster instance.
5004 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5005 IBuildControl. These are used to force builds. Eventually they
5006 will provide ways to reconfigure the Builders, pause or abandon a
5007 Build, and perhaps control the BuildMaster itself.
5009 2004-09-26 Brian Warner <warner@lothar.com>
5011 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5012 ends up comparing us against something without a .__class__
5014 2004-09-24 Brian Warner <warner@lothar.com>
5016 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5019 * Makefile: add 'deb-snapshot' target, to create a timestamped
5022 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5024 2004-09-23 Brian Warner <warner@lothar.com>
5026 * buildbot/__init__.py (version): move version string here
5027 * setup.py: get version string from buildbot.version
5028 * buildbot/status/html.py (WaterfallStatusResource.body): add
5029 buildbot version to the page footer
5030 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5033 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5034 slaves, let the second know where the first one is coming from
5035 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5036 see our exceptions. It would be nice if there were a way to just
5037 send them the exception type and value, not the full traceback.
5040 * buildbot/status/mail.py (MailNotifier): add a new argument
5041 sendToInterestedUsers=, which can be set to False to disable the
5042 usual send-to-blamelist behavior.
5043 (top): handle python-2.2 which has no email.MIMEMultipart
5044 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5045 (MailNotifier.disownServiceParent): unsubscribe on removal
5047 * buildbot/test/test_status.py (Mail.testBuild2): test it
5050 * buildbot/status/progress.py (Expectations.wavg): tolerate
5051 current=None, which happens when steps start failing badly
5052 * buildbot/test/test_status.py (Progress.testWavg): test for it
5054 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5055 doesn't understand args['revision'], emit a warning instead of
5056 bailing completely. Updating to -rHEAD is probably close enough.
5058 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5060 * buildbot/test/test_status.py: at least import bb.status.client
5061 even if we don't have any test coverage for it yet
5063 * contrib/svn_buildbot.py: don't require python2.3
5064 (main): wait, do require it (for sets.py), but explain how to
5065 make it work under python2.2
5067 2004-09-23 Brian Warner <warner@lothar.com>
5069 * contrib/svn_buildbot.py: include the revision number in the Change
5071 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5072 using util.now() because FreshCVS is a realtime service
5074 * buildbot/status/event.py: delete dead code
5075 * buildbot/process/step.py: don't import dead Event class
5076 * buildbot/process/step_twisted.py: same
5077 * buildbot/status/builder.py: same
5078 * buildbot/status/client.py: same
5080 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5082 * buildbot/changes/changes.py (Change): set .when from an __init__
5083 argument (which defaults to now()), rather than having
5084 ChangeMaster.addChange set it later.
5085 (ChangeMaster.addChange): same
5087 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5088 (parseSyncmail): same. Just use util.now() for now.
5089 (parseBonsaiMail): parse the timestamp field for when=
5091 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5092 instead of setting .when after the fact
5096 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5097 results when the target project uses retrial. Still under
5099 * buildbot/test/test_trial.py: same
5101 2004-09-21 Brian Warner <warner@lothar.com>
5103 * buildbot/status/mail.py (MailNotifier.__init__): include
5104 success/warnings/failure in the Subject line
5105 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5106 use step.logname for the addLogs=True attachment filenames
5107 * buildbot/test/test_status.py (Mail): test Subject lines
5108 (Mail.testLogs): test attachment filenames
5110 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5111 accept a 'who' argument from the debug tool
5112 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5113 * contrib/debug.glade: add text box to set 'who'
5115 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5116 .getBuilderName with .getBuilder().getName(), more flexible
5117 (IStatusLog.getName): logs have short names, but you can prefix
5118 them with log.getStep().getName() to make them more useful
5119 * buildbot/status/builder.py: same
5120 * buildbot/status/client.py: same
5121 * buildbot/status/html.py: same
5122 * buildbot/test/test_run.py (Status.testSlave): same
5123 * buildbot/process/step.py: tweak logfile names
5125 * buildbot/status/mail.py (MailNotifier): add lookup, change
5126 argument to extraRecipients. The notifier is now aimed at sending
5127 mail to the people involved in a particular build, with additional
5128 constant recipients as a secondary function.
5130 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5131 including slow-lookup and failing-lookup. Make sure the blamelist
5132 members are included.
5134 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5135 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5136 (IBuildStatus.getInterestedUsers): new method
5137 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5138 * buildbot/status/client.py (remote_getResponsibleUsers): same
5139 * buildbot/status/html.py (StatusResourceBuild.body): same
5140 * buildbot/test/test_run.py (Status.testSlave): same
5142 2004-09-20 Brian Warner <warner@lothar.com>
5144 * docs/users.xhtml: update concepts
5146 * Makefile: add a convenience makefile, for things like 'make
5147 test'. It is not included in the source tarball.
5149 2004-09-16 Brian Warner <warner@lothar.com>
5151 * NEWS: mention /usr/bin/buildbot, debian/*
5153 * debian/*: add preliminary debian packaging. Many thanks to
5154 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5155 it considerably since it left their hands, I am responsible for
5156 all breakage that's resulted.
5158 * bin/buildbot: create a top-level 'buildbot' command, to be
5159 installed in /usr/bin/buildbot . For now it's just a simple
5160 frontend to mktap/twistd/kill, but eventually it will be the entry
5161 point to the 'try' command and also a status client. It is also
5162 intended to support the upcoming debian-packaging init.d scripts.
5163 * buildbot/scripts/runner.py: the real work is done here
5164 * buildbot/scripts/__init__.py: need this too
5165 * buildbot/scripts/sample.cfg: this is installed in new
5166 buildmaster directories
5167 * setup.py: install new stuff
5169 2004-09-15 Brian Warner <warner@lothar.com>
5171 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5172 'file:' schema (the version shipped with OS-X was built without the
5174 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5175 updates the log-timestamp, to make sure it isn't still running after
5178 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5179 values to the config file.
5180 * docs/examples/hello.cfg: add examples
5181 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5182 * buildbot/status/builder.py (Status.getProjectURL): implement them
5183 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5184 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5185 * buildbot/status/html.py (WaterfallStatusResource): display them
5188 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5189 certain error cases don't suffer a secondary exception.
5190 (top): Skip tests if the corresponding VC tool is not installed.
5192 * buildbot/process/factory.py (Trial): introduce separate
5193 'buildpython' and 'trialpython' lists, since trialpython=[] is
5194 what you want to invoke /usr/bin/python, whereas ./setup.py is
5195 less likely to be executable. Add env= parameter to pass options
5196 to test cases (which is how I usually write tests, I don't know if
5197 anyone else does it this way).
5199 * buildbot/process/step_twisted.py (Trial): handle python=None.
5200 Require 'testpath' be a string, not a list. Fix tests= typo.
5201 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5203 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5204 way to deal with the possibility of removing the disconnect notify
5206 (CVS): add a 'login' parameter to give a password to 'cvs login',
5207 commonly used with pserver methods (where pw="" or pw="guest")
5209 * buildbot/slave/commands.py (SourceBase): move common args
5210 extraction and setup() to __init__, so everything is ready by the
5211 time setup() is called
5212 (CVS.start): call 'cvs login' if a password was supplied
5213 (ShellCommand): special-case PYTHONPATH: prepend the master's
5214 value to any existing slave-local value.
5216 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5217 don't have a remote, mark the builder as Offline. This whole
5218 function should probably go away and be replaced by individual
5220 (Builder.buildFinished): return the results to the build-finished
5221 deferred callback, helps with testing
5223 2004-09-14 Brian Warner <warner@lothar.com>
5225 * buildbot/test/test_vc.py: put all the repositories needed to run
5226 the complete tests into a single small (1.3MB) tarball, so I can
5227 make that tarball available on the buildbot web site. Test HTTP
5228 access (for Arch and Darcs) by spawning a temporary web server
5229 while the test runs.
5231 * docs/users.xhtml: new document, describe Buildbot's limited
5232 understanding of different human users
5234 * buildbot/test/test_vc.py: rearrange test cases a bit
5236 * buildbot/process/step_twisted.py (Trial): handle testpath=
5237 * buildbot/process/factory.py (Trial): update to use step.Trial
5239 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5241 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5242 the overall build text (which gives you 'failed 2 tests' rather
5244 (BuildStepStatus.text2): default to [], not None
5246 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5249 2004-09-12 Brian Warner <warner@lothar.com>
5251 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5252 log the whole exception if it's just an AttributeError (old slave)
5254 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5255 so (e.g.) sub-commands can be run in the right directory.
5256 (ShellCommand.start): accept an optional errorMessage= argument
5257 to make life easier for SVN.start
5258 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5260 (ShellCommand.start): move ['dir'] compatibility hack..
5261 (RemoteShellCommand.start): .. to here so everyone can use it
5263 * buildbot/process/step_twisted.py (Trial): use .workdir
5265 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5266 text displayed when debuild fails completely
5267 (Trial): snarf _trial_temp/test.log from the slave and display it
5269 2004-09-11 Brian Warner <warner@lothar.com>
5271 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5273 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5274 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5276 * buildbot/process/step.py (ShellCommand): call .createSummary
5277 before .evaluateCommand instead of the other way around. This
5278 makes it slightly easier to count warnings and then use that to
5279 set results=WARNINGS
5280 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5282 * buildbot/process/base.py (Build.buildFinished): update status
5283 before doing progress. It's embarrassing for the build to be stuck
5284 in the "building" state when an exceptions occurs elsewhere..
5286 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5287 python2.2 doesn't have 'sum'
5289 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5290 to prevent clients from accidentally sorting it
5292 * buildbot/master.py (Manhole): add username/password
5293 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5294 c['manholePort'], deprecate old usage
5295 * docs/config.xhtml: document c['manhole']
5296 * docs/examples/hello.cfg: show example of using a Manhole
5299 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5300 pretend the slave is up to date
5302 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5303 the module, overlaps with 'log', the local variable
5305 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5307 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5308 new method to let Steps find out the version of their
5309 corresponding SlaveCommand.
5310 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5311 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5312 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5314 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5315 (Arch.startVC): same
5316 (P4Sync.startVC): same
5318 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5319 Deferred so we can catch errors in remote_startCommand
5320 (RemoteShellCommand.start): same
5322 * docs/examples/twisted_master.cfg: update sample config file
5324 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5325 after connectionMade() is called, not before. Close stdin at that
5328 * buildbot/process/process_twisted.py: update to use Trial, clean
5329 up argument passing (move to argv arrays instead of string
5332 * buildbot/process/step_twisted.py (Trial): new step to replace
5333 RunUnitTests, usable by any trial-using project (not just
5334 Twisted). Arguments have changed, see the docstring for details.
5336 * buildbot/process/base.py (Build.startBuild): this now returns a
5337 Deferred. Exceptions that occur during setupBuild are now
5338 caught better and lead to fewer build_status weirdnesses, like
5339 finishing a build that was never started.
5340 (Build.buildFinished): fire the Deferred instead of calling
5341 builder.buildFinished directly. The callback argument is this
5342 Build, everything else can be extracted from it, including the
5343 new build.results attribute.
5344 * buildbot/process/builder.py (Builder.startBuild): same
5345 (Builder.buildFinished): same, extract results from build
5347 * buildbot/process/step.py (ShellCommands): remove dead code
5349 2004-09-08 Brian Warner <warner@lothar.com>
5351 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5352 doesn't try to use the leftover patched workdir
5353 (SourceStamp): test source-stamp computation for CVS and SVN
5355 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5356 patched workdir ('touch .buildbot-patched') so we don't try to
5358 (SourceBase.start): add ['revision'] for all Source steps
5359 (CVS): change args: use ['branch'] for -r, remove ['files']
5360 (CVS.buildVC): fix revision/branch stuff
5361 (SVN): add revision stuff
5363 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5364 kwargs (except 'workdir') to avoid silent spelling errors
5365 (ShellCommand.__init__): same
5366 (Source): new base class for CVS/SVN/etc. Factor out everything
5367 common, add revision computation (perform the checkout with a -D
5368 DATE or -r REVISION that gets exactly the sources described by the
5369 last Change), overridable with step.alwaysUseLatest. Add patch
5370 handling (build.getSourceStamp can trigger the use of a base
5371 revision and a patch).
5372 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5373 * docs/steps.xhtml: update docs
5374 * docs/source.xhtml: mention .checkoutDelay
5375 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5377 * buildbot/process/base.py (Build.setSourceStamp): add a
5378 .sourceStamp attribute to each Build. If set, this indicates that
5379 the build should be done with something other than the most
5380 recent source tree. This will be used to implement "try" builds.
5381 (Build.allChanges): new support method
5382 (Build.lastChangeTime): remove, functionality moved to Source steps
5383 (Build.setupBuild): copy the Step args before adding ['workdir'],
5384 to avoid modifying the BuildFactory (and thus triggering spurious
5388 * buildbot/status/html.py: rename s/commits/changes/
5389 (StatusResourceChanges): same
5390 (CommitBox.getBox): same, update URL
5391 (WaterfallStatusResource): same
5392 (StatusResource.getChild): same
5394 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5395 * contrib/debug.glade: add optional 'revision' to the fakeChange
5397 * buildbot/changes/changes.py (html_tmpl): display .revision
5398 (ChangeMaster.addChange): note .revision in log
5399 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5400 accept a ['revision'] attribute
5402 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5404 * buildbot/master.py (BotMaster.getPerspective): update the
5405 .connected flag in SlaveStatus when it connects
5406 (BotMaster.detach): and when it disconnects
5407 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5408 (BuildMaster.loadConfig_Builders): walk old list correctly
5410 * buildbot/test/test_config.py: fix prefix= usage
5412 2004-09-06 Brian Warner <warner@lothar.com>
5416 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5417 poll a P4 depot looking for recent changes. Thanks to Dave
5418 Peticolas for the contribution. Probably needs some testing after
5421 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5422 requires manual client setup for each buildslave. Rather
5423 experimental. Thanks again to Dave Peticolas.
5424 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5426 * buildbot/changes/changes.py (Change): add a .revision attribute,
5427 which will eventually be used to generate source-stamp values.
5429 * buildbot/process/step.py (RemoteCommand.start): use
5430 notifyOnDisconnect to notice when we lose the slave, then treat it
5431 like an exception. This allows LogFiles to be closed and the build
5432 to be wrapped up normally. Be sure to remove the disconnect
5433 notification when the step completes so we don't accumulate a
5434 bazillion such notifications which will fire weeks later (when the
5435 slave finally disconnects normally). Fixes SF#915807, thanks to
5436 spiv (Andrew Bennetts) for the report.
5437 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5438 really isn't Logged- specific
5439 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5440 header, since it's almost always going to be appended to an
5442 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5443 update test to handle use of notifyOnDisconnect
5445 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5446 don't clear .ETA and .currentBuild when going offline, let the
5447 current build clean up after itself
5449 * buildbot/process/builder.py (Builder.detached): wait a moment
5450 before doing things like stopping the current build, because the
5451 current step will probably notice the disconnect and cleanup the
5453 * buildbot/test/test_run.py (Status.tearDown): update test to
5454 handle asynchronous build-detachment
5456 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5458 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5459 hush a debug message
5461 2004-09-05 Brian Warner <warner@lothar.com>
5463 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5464 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5465 kernels do this: the fcntl module has the F_NOTIFY constant, but
5466 the kernel itself doesn't support the operation. Thanks to Olly
5467 Betts for spotting the problem.
5469 * buildbot/process/step.py (Darcs): new source-checkout command
5470 (Arch): new source-checkout command
5471 (todo_P4): fix constructor syntax, still just a placeholder
5472 * buildbot/test/test_vc.py (VC.testDarcs): test it
5473 (VC.testDarcsHTTP): same, via localhost HTTP
5475 (VC.testArchHTTP): same
5476 * NEWS: mention new features
5478 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5479 which tells the step to stash stdout text locally (in .stdout).
5480 Slave-side Commands can use this to make decisions based upon the
5481 output of the the ShellCommand (not just the exit code).
5482 (Darcs): New source-checkout command
5483 (Arch): New source-checkout command, uses .keepStdout in one place
5484 where it needs to discover the archive's default name.
5486 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5487 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5488 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5490 * buildbot/process/step.py (ShellCommand.describe): add an
5491 alternate .descriptionDone attribute which provides descriptive
5492 text when the step is complete. .description can be ["compiling"],
5493 for use while the step is running, then .descriptionDone can be
5494 ["compile"], used alone when the step succeeds or with "failed" when
5495 it does not. Updated other steps to use the new text.
5496 * buildbot/process/step_twisted.py: same
5497 * buildbot/test/test_run.py: update tests to match
5499 2004-08-30 Brian Warner <warner@lothar.com>
5501 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5502 (CVS.__init__): send 'patch' argument to slave
5503 (CVS.start): don't create the LoggedRemoteCommand until start(),
5504 so we can catch a .patch added after __init__
5505 (SVN.__init__): add 'patch' to SVN too
5508 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5509 argument, to let commands push data into the process' stdin pipe.
5510 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5511 is in use, since closing a PTY doesn't really affect the process
5512 in the right way (in particular, I couldn't run /usr/bin/patch
5514 (SourceBase.doPatch): handle 'patch' argument
5516 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5519 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5520 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5522 * buildbot/master.py (BotPerspective.got_commands): get command
5523 versions from slave, give to each builder
5524 * buildbot/process/builder.py (Builder.attached): stash slave
5525 command versions in .remoteCommands
5527 * docs/steps.xhtml: bring docs in-line with reality
5529 * buildbot/process/step.py (CVS.__init__): more brutal
5530 compatibility code removal
5531 (SVN.__init__): same
5533 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5534 (SlaveShellCommand.start): require ['workdir'] argument, remove
5535 the ['dir'] fallback (compatibility will come later)
5536 (SourceBase): update docs
5537 (SourceBase.start): remove ['directory'] fallback
5540 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5541 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5542 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5544 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5545 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5546 code.. I will figure out 0.5.0-compatibility hooks later)
5548 2004-08-30 Brian Warner <warner@lothar.com>
5550 * buildbot/process/process_twisted.py: rewrite in terms of new
5551 BuildFactory base class. It got significantly shorter. Yay
5554 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5555 work with the new "self.build isn't nailed down until we call
5556 step.start()" scheme: specifically, __init__ is called before the
5557 build has decided on which Changes are going in, so we don't scan
5558 build.allFiles() for .xhtml files until start()
5559 (HLint.commandComplete): use getText(), not getStdout()
5560 (RunUnitTests.start): same: don't use .build until start()
5561 (RunUnitTests.describe): oops, don't report (None) when using
5563 (RunUnitTests.commandComplete): use getText()
5564 (RunUnitTests.createSummary): same
5565 (BuildDebs.commandComplete): same
5567 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5568 set args['command'] until start(), since our BuildStep is allowed
5569 to change their mind up until that point
5570 (TreeSize.commandComplete): use getText(), not getStdout()
5572 * docs/examples/twisted_master.cfg: update to current standards
5574 * docs/factories.xhtml: update
5575 * buildbot/process/factory.py: implement all the common factories
5576 described in the docs. The Trial factory doesn't work yet, and
5577 I've probably broken all the process_twisted.py factories in the
5578 process. There are compatibility classes left in for things like
5579 the old BasicBuildFactory, but subclasses of them are unlikely to
5581 * docs/examples/glib_master.cfg: use new BuildFactories
5582 * docs/examples/hello.cfg: same
5584 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5585 explicit 'workdir' args
5587 * buildbot/process/base.py (BuildFactory): move factories to ..
5588 * buildbot/process/factory.py (BuildFactory): .. here
5589 * buildbot/process/process_twisted.py: handle move
5590 * buildbot/test/test_config.py: same
5591 * buildbot/test/test_run.py: same
5592 * buildbot/test/test_steps.py: same
5593 * buildbot/test/test_vc.py: same
5594 * docs/factories.xhtml: same
5596 * NEWS: mention config changes that require updating master.cfg
5598 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5599 argument to all steps that weren't given one already, pointing at
5600 the "build/" directory.
5602 * docs/examples/hello.cfg: remove explicit 'workdir' args
5604 * docs/factories.xhtml: document standard BuildFactory clases,
5605 including a bunch which are have not yet been written
5607 2004-08-29 Brian Warner <warner@lothar.com>
5609 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5610 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5611 buildbot.status.builder so they aren't quite so internal
5612 * buildbot/process/base.py, buildbot/process/builder.py: same
5613 * buildbot/process/maxq.py, buildbot/process/step.py: same
5614 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5615 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5616 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5618 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5619 to handle new getLogs()-returns-list behavior
5620 (StatusResourceBuildStep.getChild): same
5621 (StepBox.getBox): same
5622 (WaterfallStatusResource.phase0): same
5624 * docs/source.xhtml: document how Buildbot uses version-control
5625 systems (output side: how we get source trees)
5626 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5627 systems (input side: how we learn about Changes)
5629 * buildbot/master.py (Manhole): use ComparableMixin
5630 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5631 * buildbot/changes/mail.py (MaildirSource): same
5632 * buildbot/status/client.py (PBListener): same
5633 * buildbot/status/html.py (Waterfall): same
5634 * buildbot/status/words.py (IRC): same
5636 * NEWS: start describing new features
5638 * buildbot/status/mail.py (MailNotifier): finish implementation.
5639 The message body is still a bit sparse.
5640 * buildbot/test/test_status.py (Mail): test it
5642 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5643 and __hash__ methods I wind up adding everywhere. Specifically
5644 intended to support the buildbot config-file update scheme where
5645 we compare, say, the old list of IStatusTargets against the new
5646 one and don't touch something which shows up on both lists.
5647 * buildbot/test/test_util.py (Compare): test case for it
5649 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5650 return a list instead of a dict
5651 (IBuildStepStatus.getLogs): same. The idea is that steps create
5652 logs with vaguely unique names (although their uniqueness is not
5653 guaranteed). Thus a compilation step should create its sole
5654 logfile with the name 'compile', and contribute it to the
5655 BuildStatus. If a step has two logfiles, try to create them with
5656 different names (like 'test.log' and 'test.summary'), and only
5657 contribute the important ones to the overall BuildStatus.
5658 * buildbot/status/builder.py (Event.getLogs): same
5659 (BuildStepStatus): fix default .text and .results
5660 (BuildStepStatus.addLog): switch to list-like .getLogs()
5661 (BuildStepStatus.stepFinished): same
5662 (BuildStatus.text): fix default .text
5663 (BuildStatus.getLogs): temporary hack to return all logs (from all
5664 child BuildStepStatus objects). Needs to be fixed to only report
5665 the significant ones (as contributed by the steps themselves)
5666 * buildbot/test/test_run.py: handle list-like .getLogs()
5667 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5669 2004-08-28 Brian Warner <warner@lothar.com>
5671 * buildbot/process/builder.py (Builder.attached): serialize the
5672 attachment process, so the attach-watcher isn't called until the
5673 slave is really available. Add detached watchers too, which makes
5676 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5678 * buildbot/test/test_swap.py: remove dead code
5680 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5681 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5682 sort of as if the command being run exited with a -1. There may
5683 still be some holes in this scheme.
5684 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5685 -r option appears before the module list
5686 * buildbot/process/step.py (CVS): add 'revision' argument
5688 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5689 when sending updates or stepComplete messages to the master, since
5690 we don't currently care whether they arrive or not. When we revamp
5691 the master/slave protocol to really resume interrupted builds,
5692 this will need revisiting.
5693 (lostRemote): remove spurious print
5695 * buildbot/master.py (BotPerspective.attached): serialize the
5696 new-builder interrogation process, to make testing easier
5697 (BotMaster.waitUntilBuilderDetached): convenience function
5699 * buildbot/status/builder.py (BuilderStatus): prune old builds
5700 (BuildStatus.pruneSteps): .. and steps
5701 (BuildStepStatus.pruneLogs): .. and logs
5702 (BuilderStatus.getBuild): handle missing builds
5703 * buildbot/status/html.py (StatusResourceBuild.body): display build
5704 status in the per-build page
5705 (BuildBox.getBox): color finished builds in the per-build box
5707 2004-08-27 Brian Warner <warner@lothar.com>
5709 * buildbot/status/mail.py (MailNotifier): new notification class,
5712 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5713 variants of a common base class which handles all the mode= logic
5715 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5717 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5719 2004-08-26 Brian Warner <warner@lothar.com>
5721 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5724 * buildbot/test/test_run.py: update to new Logfile interface, new
5725 buildbot.slave modules
5726 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5728 * MANIFEST.in: new sample config file
5729 * docs/examples/hello.cfg: same
5731 * buildbot/process/step_twisted.py: remove dead import
5733 * buildbot/process/step.py (RemoteCommand.run): catch errors
5735 (RemoteCommand.remote_update): ignore updates that arrive after
5737 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5738 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5739 the responsibilities of the subclass's methods
5740 (BuildStep.failed): catch errors during failure processing
5741 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5742 (CVS): move to a mode= argument (described in docstring), rather
5743 than the ungainly clobber=/export=/copydir= combination.
5744 (SVN): add mode= functionality to SVN too
5745 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5747 * buildbot/process/base.py (Build.startNextStep): catch errors
5748 during s.startStep()
5750 * buildbot/clients/base.py: update to new PB client interface.
5751 gtkPanes is still broken
5753 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5754 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5755 * setup.py: add buildbot.slave module
5756 * buildbot/bb_tap.py: handle move
5757 * buildbot/slave/registry.py: place to register commands, w/versions
5758 * buildbot/slave/bot.py: major simplifications
5759 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5760 instead of a fixed table. Eventually this will make the slave more
5761 extensible. Use 'start' method on the command, not .startCommand.
5762 Fix unsafeTracebacks handling (I think).
5763 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5764 helper class with a .start method that returns a Deferred.
5765 SlaveShellCommand is the form reached by the buildmaster. Commands
5766 which use multiple ShellCommands can just chain them as Deferreds,
5767 with some helper methods in Command (_abandonOnFailure and
5768 _checkAbandoned) to bail on rc!=0.
5769 (CVSCommand): prefer new mode= argument
5770 (SVNFetch): add mode= argument
5772 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5773 put a useful reason string on the build
5775 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5776 core functionality into an IStatusLog object
5777 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5778 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5779 (StatusResourceBuild.body): use proper accessor methods
5780 * buildbot/status/client.py (RemoteLog): PB-access goes here
5781 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5782 which delivers log contents too
5783 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5784 * buildbot/status/event.py: remove old Logfile completely
5786 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5787 subscription interface for IStatusLog subscriptions just like all
5788 other the status subscriptions
5789 (IStatusReceiver.logChunk): method called on subscribers
5791 2004-08-24 Brian Warner <warner@lothar.com>
5793 * buildbot/process/builder.py (Builder._pong): oops, ping response
5794 includes a result (the implicit None returned by remote_print).
5795 Accept it so the _pong method handles the response correctly.
5797 2004-08-06 Brian Warner <warner@lothar.com>
5799 * buildbot/test/test_config.py: update IRC, PBListener tests
5801 * buildbot/status/client.py (StatusClientPerspective): total
5802 rewrite to match new IStatus interfaces. New subscription scheme.
5803 There are still a few optimizations to make (sending down extra
5804 information with event messages so the client doesn't have to do a
5805 round trip). The logfile-retrieval code is probably still broken.
5806 Moved the PB service into its own port, you can no longer share a
5807 TCP socket between a PBListener and, say, the slaveport (this
5808 should be fixed eventually).
5809 * buildbot/clients/base.py (Client): revamp to match. still needs
5810 a lot of work, but basic event reporting works fine. gtkPanes is
5813 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5814 instance talks to a single irc server. Threw out all the old
5815 multi-server handling code. Still need to add back in
5816 builder-control (i.e. "force build")
5818 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5819 more random text to the as-yet-unreachable per-step page
5821 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5822 rename to stepETAUpdate
5823 (BuildStatus.subscribe): add build-wide ETA updates
5824 (BuilderStatus.getState): remove more cruft
5825 (BuilderStatus.getCurrentBuild): remove more cruft
5826 (BuilderStatus.buildStarted): really handle tuple-subscription
5827 * buildbot/test/test_run.py (Status.testSlave): handle the
5828 stepETAUpdate rename
5830 * buildbot/master.py (BuildMaster): don't add a default
5831 StatusClientService. Don't add a default IrcStatusFactory. Both
5832 are now added through c['status'] in the config file. c['irc'] is
5833 accepted for backwards compatibility, the only quirk is you cannot
5834 use c['irc'] to specify IRC servers on ports other than 6667.
5836 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5837 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5838 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5839 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5842 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5843 the buildmaster to re-read its config file
5846 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5847 find out the port our server is running on
5848 (WebTest.test_webPathname_port): same
5850 * buildbot/test/test_config.py (testWebPortnum): test it
5851 (testWebPathname): ditto
5853 * docs/config.xhtml: document new c['status'] configuration option
5855 * buildbot/status/html.py (Waterfall): new top-level class which
5856 can be added to c['status']. This creates the Site as well as the
5857 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5858 reachable as .parent, for everything.
5860 * buildbot/master.py (Manhole): make it a normal service Child
5861 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5862 webPathname. It will eventually replace c['irc'] and the implicit
5863 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5864 in as (deprecated) backward compatibility hooks for now.
5867 * buildbot/process/builder.py (Builder.buildFinished): don't
5868 inform out builder_status about a finished build, as it finds out
5869 through its child BuildStatus object
5871 * buildbot/status/html.py: extensive revamp. Use adapters to make
5872 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5873 have both starting and finishing times and adjust the waterfall
5874 display accordingly, using spacers if necessary. Use SlaveStatus
5875 to get buildslave info.
5876 (StatusResourceBuildStep): new just-one-step resource, used to get
5877 logfiles. No actual href to it yet.
5879 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5880 the time being, until I get the file-naming scheme right
5882 * buildbot/status/builder.py (Event): clean started/finished names
5883 (BuildStatus.isFinished): .finished is not None is the right test
5884 (BuildStatus.buildStarted): track started/finished times ourselves
5885 (BuilderStatus.getSlave): provide access to SlaveStatus object
5886 (BuilderStatus.getLastFinishedBuild): all builds are now in
5887 .builds, even the currently-running one. Accomodate this change.
5888 (BuilderStatus.eventGenerator): new per-builder event generator.
5889 Returns BuildStepStatus and BuildStatus objects, since they can
5890 both be adapted as necessary.
5891 (BuilderStatus.addEvent): clean up started/finished attributes
5892 (BuilderStatus.startBuild,finishBuild): remove dead code
5893 (SlaveStatus): new object to provide ISlaveStatus
5895 * buildbot/process/step.py (ShellCommand.getColor): actually
5896 return the color instead of setting it ourselves
5897 (CVS.__init__): pull .timeout and .workdir options out of
5898 **kwargs, since BuildStep will ignore them. Without this neither
5899 will be sent to the slave correctly.
5900 (SVN.__init__): same
5902 * buildbot/process/builder.py (Builder): move flags to class-level
5904 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5905 SlaveStatus handle that
5907 * buildbot/process/base.py (Build.firstEvent): remove dead code
5908 (Build.stopBuild): bugfix
5910 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5912 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5913 (ChangeMaster.eventGenerator): yield Changes, since there are now
5914 Adapters to turn them into HTML boxes
5916 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5917 (BotPerspective.attached): feed a SlaveStatus object
5918 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5919 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5921 * buildbot/interfaces.py: API additions
5922 (ISlaveStatus): place to get slave status
5924 2004-08-04 Brian Warner <warner@lothar.com>
5926 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5927 the delay finishes, so the step is marked as SUCCESS
5929 * buildbot/test/test_run.py (Status.testSlave): cover more of
5930 IBuildStatus and IBuildStepStatus
5932 * buildbot/status/progress.py (StepProgress): move some flags to
5933 class-level attributes
5934 (StepProgress.remaining): if there are no other progress metrics
5935 to go by, fall back to elapsed time
5936 (StepProgress.setExpectations): take a dict of metrics instead of
5938 (BuildProgress.setExpectationsFrom): pull expectations from the
5939 Expectations, instead of having it push them to the BuildProgress
5940 (Expectations): move some flags to class-level attributes
5941 (Expectations.__init__): copy per-step times from the
5943 (Expectations.expectedBuildTime): new method for per-build ETA
5945 * buildbot/status/event.py (Logfile): move some flags to
5946 class-level attributes
5947 (Logfile.logProgressTo): better method name, let step set the
5948 progress axis name (instead of always being "output")
5950 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5951 times directly, rather than depending upon the (possibly missing)
5952 .progress object. Use 'None' to indicate "not started/finished
5954 (BuildStepStatus.getExpectations): oops, return the full list of
5956 (BuilderStatus._buildFinished): append finished builds to .builds
5958 * buildbot/process/step.py (BuildStep): add separate .useProgress
5959 flag, since empty .progressMetrics[] still implies that time is a
5961 (CVS): set up the cmd in __init__, instead of waiting for start()
5963 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5964 calculation, this will eventually turn into a proper sourceStamp
5965 (Build.setupBuild): tell the Progress to load from the Expectations,
5966 instead of having the Expectations stuff things into the Progress
5967 (Build.buildException): add a build-level errback to make sure the
5968 build's Deferred fires even in case of exceptions
5970 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5972 * buildbot/process/builder.py (Builder.forceBuild): convey the
5973 reason instead of creating a fake Change
5975 * docs/examples/twisted_master.cfg: update to match reality
5977 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5978 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5979 fix or remove broken/breaking tests
5981 * buildbot/status/event.py (Logfile.__len__): remove evil method
5983 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5984 missing .build, for test convenience
5986 * buildbot/process/step_twisted.py: import fixes
5988 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5990 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5991 .statusbag reference
5993 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5994 connection at shutdown, and stop it from reconnecting
5996 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5997 chase down remote-execution bugs
5999 * buildbot/process/step.py: more fixes, remove
6000 BuildStep.setStatus()
6001 * buildbot/status/builder.py: move setStatus() functionality into
6003 * buildbot/status/event.py: minor fixes
6005 2004-08-03 Brian Warner <warner@lothar.com>
6007 * buildbot/process/base.py, buildbot/process/builder.py
6008 * buildbot/process/step.py, buildbot/status/builder.py
6009 * buildbot/status/event.py, buildbot/test/test_run.py:
6010 fix status delivery, get a basic test case working
6011 * buildbot/master.py: finish implementing basic status delivery,
6012 temporarily disable HTML/IRC/PB status sources
6014 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6016 * buildbot/status/progress.py (BuildProgress): remove dead code
6018 * buildbot/interfaces.py
6019 * buildbot/process/base.py, buildbot/process/builder.py
6020 * buildbot/process/step.py, buildbot/process/step_twisted.py
6021 * buildbot/status/builder.py: Complete overhaul of the all
6022 status-delivery code, unifying all types of status clients (HTML,
6023 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6024 look like. This commit is a checkpointing of the work-in-progress:
6025 the input side is mostly done (Builders/Builds sending status
6026 to the BuilderStatus/BuildStatus objects), but the output side has
6027 not yet been started (HTML resources querying BuilderStatus
6028 objects). Things are probably very broken right now and may remain
6029 so for several weeks, I apologize for the disruption.
6031 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6032 HTML as the log's contents. Currently used for exception tracebacks.
6033 * buildbot/status/progress.py: minor spelling changes
6035 2004-08-02 Brian Warner <warner@lothar.com>
6037 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6038 in mozilla. Also added stylesheets copied from Twisted's docs.
6039 Remember that these files are meant to be run through Lore first.
6040 Thanks to Philipp Frauenfelder for the fixes.
6041 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6042 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6043 * docs/template.tpl: added a Lore template
6045 2004-07-29 Brian Warner <warner@lothar.com>
6047 * buildbot/interfaces.py: revamp status delivery. This is the
6048 preview: these are the Interfaces that will be provided by new
6049 Builder code, and to which the current HTML/IRC/PB status
6050 displayers will be adapted.
6052 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6053 on the SlaveBuilder, not the Bot.
6054 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6056 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6057 set .usePTY on the FakeSlaveBuilder
6059 2004-07-25 Brian Warner <warner@lothar.com>
6061 * buildbot/changes/freshcvs.py: add some debug log messages
6062 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6063 disabled 'setFilter' syntax
6064 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6065 don't end with a slash
6067 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6069 * setup.py: bump to 0.5.0+ while between releases
6071 2004-07-23 Brian Warner <warner@lothar.com>
6073 * setup.py (version): Releasing buildbot-0.5.0
6075 2004-07-23 Brian Warner <warner@lothar.com>
6077 * README: update for 0.5.0 release
6079 * NEWS: update for 0.5.0 release
6081 2004-07-22 Brian Warner <warner@lothar.com>
6083 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6084 mktap-time configuration flag (--usepty=1, --usepty=0)
6085 * buildbot/bot.py: same
6087 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6088 an 'info' directory being unwanted
6090 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6091 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6092 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6093 and earlier), use a FreshCVSSourceOldcred instead.
6094 (test): simple test routine: connect to server, print changes
6096 * buildbot/changes/changes.py (Change.getTime): make it possible
6097 to print un-timestamped changes
6099 * buildbot/master.py (makeApp): delete ancient dead code
6100 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6101 * buildbot/test/test_config.py (testFindConfigFile): test it
6103 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6104 instead of win32 one
6107 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6108 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6111 * buildbot/process/base.py (Builder.__init__): change constructor
6112 to accept a dictionary of config data, rather than discrete
6113 name/slave/builddir/factory arguments
6115 * docs/examples/twisted_master.cfg: update to new syntax
6116 * docs/examples/glib_master.cfg: same
6117 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6118 rough tests of the new syntax
6121 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6122 to be an int, which means "run a web.distrib sub-server on a TCP
6123 port". This lets you publish the buildbot status page to a remote
6124 twisted.web server (using distrib.ResourceSubscription). Also
6125 rename the local attributes used to hold these web things so
6126 they're more in touch with reality.
6127 * buildbot/test/test_web.py: test webPortnum and webPathname
6128 * docs/config.xhtml: document this new use of webPathname
6130 * docs/config.xhtml: new document, slightly ahead of reality
6132 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6133 'prefix' handling: treat it as a simple string to check with
6134 .startswith, instead of treating it as a directory. This allows
6135 sub-directories to be used. If you use prefix=, you should give it
6136 a string that starts just below the CVSROOT and ends with a slash.
6137 This prefix will be stripped from all filenames, and filenames
6138 which do not start with it will be ignored.
6140 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6142 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6143 and --exclude (inverse of --include). SVN post-commit hooks
6144 now have total control over which changes get sent to buildbot and which
6147 2004-07-10 Brian Warner <warner@lothar.com>
6149 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6150 test case to match new API
6152 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6153 which crashed HTML display when self.entries=[] (needed to
6154 distinguish between [], which means "no entries yet", and None,
6155 which means "the entries have been swapped out to disk, go fetch
6158 2004-07-04 Brian Warner <warner@lothar.com>
6160 * buildbot/process/step_twisted.py (countFailedTests): Count
6161 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6162 10kb from the end because any import errors are wedged there and
6163 they would make us think the test log was unparseable.
6164 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6166 2004-06-26 Brian Warner <warner@lothar.com>
6168 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6169 delete-*.pyc command into an actual BuildStep, so we can label it
6171 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6172 (FullTwistedBuildFactory): same
6174 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6176 * contrib/fakechange.py: Add an errback when sending the fake
6177 change, so we know it didn't work.
6179 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6181 * buildbot/process/step_twisted.py: Delete *.pyc files before
6182 calling trial, so it doesn't catch any old .pyc files whose .py
6183 files have been moved or deleted.
6185 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6186 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6187 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6188 instead of ["twisted.test"], so that the end result is "trial -R
6191 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6192 regular expression to match filenames that should be ignored when
6193 changed. Also add a --revision parameter that specifies the
6194 revision to examine, which is useful for debugging.
6196 2004-06-25 Brian Warner <warner@lothar.com>
6198 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6199 summary of warnings (like DeprecationWarnings), next to the
6202 2004-05-13 Brian Warner <warner@lothar.com>
6204 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6205 we now have a w32 build slave courtesy of Mike Taylor.
6207 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6208 so broken. Fixed a race condition that tripped up interlocked
6209 builds and caused the status to be stuck at "Interlocked" forever.
6210 The twisted buildbot's one interlocked build just so happened to
6211 never hit this case until recently (the feeding builds both pass
6212 before the interlocked build is attempted.. usually it has to wait
6214 (Builder._pong_failed): fix method signature
6216 * setup.py: bump to 0.4.3+ while between releases
6218 2004-04-30 Brian Warner <warner@lothar.com>
6220 * setup.py (version): Releasing buildbot-0.4.3
6222 2004-04-30 Brian Warner <warner@lothar.com>
6224 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6226 * README: update for 0.4.3 release
6228 * NEWS: update for 0.4.3 release
6230 * buildbot/master.py (BuildMaster.__getstate__): make sure
6231 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6233 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6234 .trial as a class attribute, for upgrade from 0.4.2
6236 * buildbot/changes/changes.py (Change.links): add .links for
6239 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6240 .textWatchers and .htmlWatchers at save time, since they are both
6241 volatile, should allow smooth 0.4.2 upgrade
6243 * buildbot/process/step.py (CVS.finishStatus): catch failed
6244 CVS/SVN commands so we can make the status box red
6246 2004-04-29 Brian Warner <warner@lothar.com>
6248 * buildbot/changes/freshcvs.py
6249 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6250 code to do setFilter(), which tells the freshcvs daemon to not
6251 send us stuff that we're not interested in. I will uncomment it
6252 when a new version of CVSToys is available in which setFilter()
6253 actually works, and I get a chance to test it better.
6255 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6257 * buildbot/master.py (Dispatcher): use a registration scheme
6258 instead of hardwired service names
6259 (BuildMaster): keep track of the Dispatcher to support
6262 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6263 PBChangeSource class instead of having it be an undocumented
6264 internal feature of the ChangeMaster. Split out the code into a
6266 * buildbot/changes/pb.py (PBChangeSource): same
6267 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6269 * docs/{factories|sources|steps}.xhtml: document some pieces
6271 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6272 using FCMaildirSource
6273 (f23osx): update OS-X builder to use python2.3, since the slave
6274 was updated to Panther (10.3.3)
6276 2004-03-21 Brian Warner <warner@lothar.com>
6278 * buildbot/process/process_twisted.py: factor out doCheckout, change
6279 to use SVN instead of CVS
6281 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6282 an SVN subclass easier
6283 (BasicSVN): subclass which uses Subversion instead of CVS
6285 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6287 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6289 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6291 2004-02-25 Brian Warner <warner@lothar.com>
6293 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6294 is now either a list (which is passed to spawnProcess directly) or
6295 a string (which gets passed to /bin/sh -c). This removes the useSH
6296 flag and the ArgslistCommand class. Also send status header at the
6297 start and end of each command, instead of having the master-side
6299 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6300 -r'. Update to use list-based arguments.
6301 (SVNFetch): use list-based arguments, use ['dir'] argument to
6303 * buildbot/test/test_steps.py (Commands): match changes
6305 * buildbot/process/step.py (InternalShellCommand.words): handle
6307 (SVN): inherit from CVS, cleanup
6309 * buildbot/status/event.py (Logfile.content): render in HTML, with
6310 stderr in red and headers (like the name of the command we're
6311 about to run) in blue. Add link to a second URL (url + "?text=1")
6312 to get just stdout/stderr in text/plain without markup. There is
6313 still a problem with .entries=None causing a crash, it seems to occur
6314 when the logfile is read before it is finished.
6316 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6317 timeout to the keepalives, and use it to explicitly do a
6318 loseConnection instead of waiting for TCP to notice the loss. This
6319 ought to clear up the silent-lossage problem.
6320 (unsafeTracebacks): pass exception tracebacks back to the master,
6321 makes it much easier to debug problems
6323 2004-02-23 Brian Warner <warner@lothar.com>
6325 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6326 the whole command to /bin/sh instead of execve [Johan Dahlin]
6327 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6328 '-r HEAD' [Johan Dahlin]
6329 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6331 * buildbot/changes/changes.py (Change): add links= argument, add
6332 asHTML method [Johan Dahlin]. Modified to make a bit more
6333 XHTMLish. Still not sure how to best use links= .
6335 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6336 Change.asHTML to display the change, not asText
6338 * buildbot/status/html.py (StatusResourceBuilder): web button to
6341 * buildbot/test/test_run.py: test to actually start a buildmaster
6344 * MANIFEST.in: bring back accidentally-dropped test helper files
6346 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6347 that require cvstoys if it is not installed
6349 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6350 values of "bin/trial" [Dave Peticolas]
6351 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6352 tests passed" when we didn't happen to run any tests
6354 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6355 flunkOnFailure [Johan Dahlin]
6357 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6358 multiple instances of the same Step class by suffixing "_2", etc,
6359 to the name until it is unique. This name needs to be unique
6360 because it is used as a key in the dictionary that tracks build
6362 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6365 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6367 2004-01-14 Brian Warner <warner@lothar.com>
6369 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6370 kicked from a channel, log it
6372 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6373 something over whatever IRC channels the buildmaster is currently
6374 connected to. Added to try and track down a problem in which the
6375 master thinks it is still connected but the IRCd doesn't see it. I
6376 used a styles.Versioned this time, so hopefully users won't have
6377 to rebuild their .tap files this time.
6378 * contrib/debug.glade: add a "Poke IRC" button
6379 * contrib/debugclient.py: same
6381 * setup.py: bump to 0.4.2+ while between releases
6383 2004-01-08 Brian Warner <warner@lothar.com>
6385 * setup.py (version): Releasing buildbot-0.4.2
6387 2004-01-08 Brian Warner <warner@lothar.com>
6389 * NEWS: update for 0.4.2 release
6391 * README: document how to run the tests, now that they all pass
6393 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6395 * buildbot/process/step.py (CVS): add a global_options= argument,
6396 which lets you set CVS global options for the command like "-r"
6397 for read-only checkout, or "-R" to avoid writing in the
6399 * buildbot/slavecommand.py (CVSCommand): same
6401 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6402 testing easier (it is turned off when testing, to avoid the
6405 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6406 to make it easier to test: break generateStepID() out to a
6407 separate function, only update statusbag if it exists.
6408 (ShellCommands): create useful text for dict-based commands too.
6410 * test/*, buildbot/test/*: move unit tests under the buildbot/
6412 * setup.py (packages): install buildbot.test too
6414 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6415 * buildbot/test/test_steps.py: fix it, tests pass now
6417 2004-01-06 Brian Warner <warner@lothar.com>
6419 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6420 freshcvs mail uses a slightly different syntax for new
6421 directories. Update parser to handle either.
6422 * test/test_mailparse.py (Test1.testMsg9): test for same
6424 2003-12-21 Brian Warner <warner@lothar.com>
6426 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6427 'warnOnWarnings' so that lintian errors mark the build orange
6429 2003-12-17 Brian Warner <warner@lothar.com>
6431 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6432 messages emitted by Bonsai, contributed by Stephen Davis.
6434 * test/*: moved all tests to use trial instead of unittest. Some
6435 still fail (test_steps, test_slavecommand, and test_process).
6437 * setup.py (version): bump to 0.4.1+ while between releases
6439 2003-12-09 Brian Warner <warner@lothar.com>
6441 * setup.py (version): Releasing buildbot-0.4.1
6443 2003-12-09 Brian Warner <warner@lothar.com>
6445 * NEWS: update for 0.4.1 release
6447 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6448 freebsd builder code a little bit
6450 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6451 don't try to compare attributes of different classes
6452 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6453 (MaildirSource.messageReceived): fix Change delivery
6455 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6456 into the config file's namespace before loading it, like the
6457 documentation claims it does
6458 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6459 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6460 daemon comes back online
6462 2003-12-08 Brian Warner <warner@lothar.com>
6464 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6465 so the example will work with online=0 as well
6467 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6468 fix the __implements__ line
6470 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6471 class a twisted.application.service.Service, use startService to
6474 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6475 directory fd instead of simple open(). I'm sure this used to work,
6476 but the current version of python refuses to open directories with
6479 2003-12-05 Brian Warner <warner@lothar.com>
6481 * setup.py (version): bump to 0.4.0+ while between releases
6483 2003-12-05 Brian Warner <warner@lothar.com>
6485 * setup.py (version): Releasing buildbot-0.4.0
6487 2003-12-05 Brian Warner <warner@lothar.com>
6489 * docs/examples/glib_master.cfg: replace old sample scripts with
6490 new-style config files
6491 * MANIFEST.in: include .cfg files in distribution tarball
6493 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6494 implement a dummy method to avoid the exception that occurs when
6495 freshcvs sends this to us.
6497 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6498 removed the method, as it broke reconnection. Apparently
6499 stopFactory is called each time the connection attempt fails. Must
6501 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6502 attribute before serialization, since without stopFactory the
6503 reconnect timer may still be active and they aren't serializable.
6505 * test/test_mailparse.py (ParseTest): test with 'self' argument
6507 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6508 argument, as these "functions" are invoked like methods from class
6509 attributes and therefore always get an instance as the first
6512 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6513 message: thanks to Stephen Davis for the catch
6515 2003-12-04 Brian Warner <warner@lothar.com>
6517 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6518 twisted's standard ReconnectingClientFactory. Handles both oldcred
6519 and newcred connections. Also has a bug-workaround for
6520 ReconnectingClientFactory serializing its connector when it
6523 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6524 pbutil. Replace makeApp stuff with proper newcred/mktap
6525 makeService(). Don't serialize Ephemerals on shutdown.
6527 * buildbot/changes/changes.py (ChangeMaster): make it a
6528 MultiService and add the sources as children, to get startService
6529 and stopService for free. This also gets rid of the .running flag.
6531 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6532 new pbutil, turn into a TCPClient at the same time (to get
6533 startService for free). Two variants exist: FreshCVSSourceOldcred
6534 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6535 yet, but when it does, we'll be ready).
6536 (FreshCVSSource.notify): handle paths which are empty after the
6537 prefix is stripped. This only happens when the top-level (prefix)
6538 directory is added, at the very beginning of a Repository's life.
6540 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6541 Now the only reconnecting code is in the factory where it belongs.
6542 (Builder.unsubscribe): unregister the disconnect callback when we
6543 delete the builder on command from the master (i.e. when the
6544 buildmaster is reconfigured and that builder goes away). This
6545 fixes a multiple-delete exception when the status client is shut
6547 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6550 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6551 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6553 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6555 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6556 a list of globs (ugh). The testdir will be searched for files
6557 named *.tests and run the tests in the order specified in each of
6558 those files. This allows for "dependancies" between tests to be
6561 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6562 argument to pass to run_maxq.py, instead of a glob.
6564 2003-10-17 Brian Warner <warner@lothar.com>
6566 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6567 files that live in the sandbox
6569 2003-10-15 Brian Warner <warner@lothar.com>
6571 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6572 spelling error in "docs" count-warnings output
6573 (HLint.start): stupid thinko meant .xhtml files were ignored
6575 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6576 tests now that cReactor is banished to the sandbox
6578 2003-10-10 Brian Warner <warner@lothar.com>
6580 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6581 scheme: now .xhtml are sources and .html are generated
6583 2003-10-08 Brian Warner <warner@lothar.com>
6585 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6586 we were ignoring the 'randomly' parameter.
6588 2003-10-01 Brian Warner <warner@lothar.com>
6590 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6591 posix, to kill sub-children of aborted slavecommands.
6593 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6594 Clean up initialization: lastBuildStatus remains None until the
6595 first build has been completed.
6597 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6598 None as a lastBuildStatus
6599 * buildbot/clients/gtkPanes.py: same
6601 * buildbot/status/client.py (StatusClientService): keep
6602 BuilderStatus objects in self.statusbags . These objects now live
6603 here in the StatusClientService and are referenced by the Builder
6604 object, rather than the other way around.
6605 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6606 * buildbot/process/base.py (Builder): same
6607 * test/test_config.py (ConfigTest.testBuilders): same
6609 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6610 an existing builder, leave the statusbag alone. This will preserve the
6613 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6614 hook. This will probably go away in favor of a class in upcoming
6617 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6618 serviceName from newcred FreshCVSNotifiee setup
6620 2003-09-29 Brian Warner <warner@lothar.com>
6622 * buildbot/process/process_twisted.py: switch to new reactor
6624 * docs/examples/twisted_master.cfg: same
6626 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6628 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6629 botmaster reference instead of the oldapp service lookup
6631 * buildbot/master.py (BuildMaster.__init__): give the
6632 StatusClientService a reference to the botmaster to make it easier to
6635 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6637 * buildbot/status/html.py (Box.td): escape hreffy things so you
6638 can have spaces in things like builder names
6639 (StatusResourceBuilder.body)
6640 (WaterfallStatusResource.body)
6641 (WaterfallStatusResource.body0): same
6643 2003-09-25 Brian Warner <warner@lothar.com>
6645 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6646 rearrange the builder list when adding or removing builders: keep
6647 them in the order the user requested.
6648 * test/test_config.py (ConfigTest.testBuilders): verify it
6650 * contrib/debug.glade: give the debug window a name
6652 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6653 now wait on multiple interlocks. Fix code relating to that.
6654 (Builder.checkInterlocks): same
6655 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6657 * buildbot/master.py (BuildMaster.loadConfig): move from
6658 deprecated pb.BrokerFactory to new pb.PBServerFactory
6659 * test/test_config.py (ConfigTest.testWebPathname): same
6661 * docs/examples/twisted_master.cfg: fix interlock declaration
6663 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6664 Interlocks to their Builders into interlock.py .
6665 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6667 * test/test_config.py (ConfigTest.testInterlocks): validate
6670 * buildbot/process/base.py (Builder.__init__): better comments
6671 * buildbot/process/interlock.py (Interlock.__repr__): same
6672 (Interlock.deactivate): add .active flag, move the code that
6673 attaches/detaches builders into the Interlock
6675 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6677 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6678 tests using the new run_maxq.py script, and reporting failures by
6681 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6682 tests, reporting their success or failure in a buildbot-friendly
6685 2003-09-24 Brian Warner <warner@lothar.com>
6687 * docs/examples/twisted_master.cfg: example of a new-style config
6688 file. This lives in the buildmaster base directory as
6691 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6692 button to make the master re-read its config file
6694 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6695 buildmaster configuration from a file. This file can be re-read
6696 later, and the buildmaster will update itself to match the new
6697 desired configuration. Also use new Twisted Application class.
6698 * test/Makefile, test/test_config.py: unit tests for same
6700 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6701 FreshCVSSources comparable, to support reload.
6702 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6704 * buildbot/process/base.py (Builder): make them comparable, make
6705 Interlocks easier to attach, to support reload. Handle
6706 re-attachment of remote slaves.
6707 * buildbot/process/interlock.py (Interlock): same
6709 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6710 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6711 buildmaster taps are now constructed with mktap.
6712 * buildbot/status/client.py (StatusClientService): same
6714 * buildbot/status/words.py: move to new Services, add support to
6715 connect to multiple networks, add reload support, allow nickname
6716 to be configured on a per-network basis
6718 2003-09-20 Brian Warner <warner@lothar.com>
6720 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6721 the freebsd builder, now that the machine has been upgraded and no
6722 longer has python2.2
6724 * setup.py (version): bump to 0.3.5+ while between releases
6726 2003-09-19 Brian Warner <warner@lothar.com>
6728 * setup.py (version): Releasing buildbot-0.3.5
6730 2003-09-19 Brian Warner <warner@lothar.com>
6732 * NEWS: add post-0.3.4 notes
6734 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6736 * MANIFEST.in: add contrib/*
6738 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6739 use a remote root now: cvs.twistedmatrix.com
6741 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6743 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6744 compatibility with old servers
6745 (FreshCVSSource.start): and provide a way to use it
6746 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6748 * docs/examples/twisted_master.py (twisted_app): update to new
6750 (twisted_app): listen on new ~buildbot socket
6751 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6753 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6754 to reduce cvs bandwidth (update instead of full checkout)
6756 2003-09-11 Brian Warner <warner@lothar.com>
6758 * contrib/fakechange.py: demo how to connect to the changemaster
6759 port. You can use this technique to submit changes to the
6760 buildmaster from source control systems that offer a hook to run a
6761 script when changes are committed.
6763 * contrib/debugclient.py: tool to connect to the debug port. You
6764 can use it to force builds, submit fake changes, and wiggle the
6767 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6768 'Dispatcher' realm to handle all the different kinds of
6769 connections and Perspectives: buildslaves, the changemaster port,
6770 the debug port, and the status client port. NewCredPerspectives
6771 now have .attached/.detached methods called with the remote 'mind'
6772 reference, much like old perspectives did. All the pb.Services
6773 turned into ordinary app.ApplicationServices .
6774 (DebugService): went away, DebugPerspectives are now created
6775 directly by the Dispatcher.
6776 (makeApp): changed interface a little bit
6778 * buildbot/changes/changes.py: newcred
6779 * buildbot/status/client.py: newcred
6781 * buildbot/clients/base.py: newcred client side changes
6782 * buildbot/bot.py: ditto
6784 * docs/examples/glib_master.py: handle new makeApp() interface
6785 * docs/examples/twisted_master.py: ditto
6787 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6788 base newcred Perspectives on. This should go away once Twisted
6789 itself provides something sensible.
6792 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6794 * contrib/svn_buildbot.py: A program that you can call from your
6795 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6796 when a change in an SVN repository has happened. See the top of
6797 the file for some minimal usage info.
6799 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6801 * buildbot/slavecommand.py (ArglistCommand): Add new
6802 ArglistCommand that takes an argument list rather than a string as
6803 a parameter. Using a st.split() for argv is very bad.
6805 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6806 update to a particular revision rather than always checking out
6807 (still not very smart about it, there may be cases where the
6808 checkout becomes inconsistent).
6810 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6812 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6813 SVN fetch support. It can checkout (not update!) a specified
6814 revision from a specified repository to a specified directory.
6816 * buildbot/status/progress.py (Expectations.update): Fix an
6817 obvious bug (apparently created by the change described in the
6818 previous ChangeLog message) by moving a check to *after* the
6819 variable it checks is defined.
6822 2003-09-08 Brian Warner <warner@lothar.com>
6824 * buildbot/status/progress.py (Expectations.update): hack to catch
6825 an exception TTimo sees: sometimes the update() method seems to
6826 get called before the step has actually finished, so the .stopTime
6827 is not set, so no totalTime() is available and we average None
6828 with the previous value. Catch this and just don't update the
6829 metrics, and emit a log message.
6831 2003-08-24 Brian Warner <warner@lothar.com>
6833 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6834 parameter to set copydir='original' in CVS commands.
6836 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6838 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6839 which tells the command to maintain a separate original-source CVS
6840 workspace. For each build, this workspace will be updated, then
6841 the tree copied into a new workdir. This reduces CVS bandwidth
6842 (from a full checkout to a mere update) while doubling the local
6843 disk usage (to keep two copies of the tree).
6845 2003-08-21 Brian Warner <warner@lothar.com>
6847 * buildbot/status/event.py (Logfile.addEntry): if the master web
6848 server dies while we're serving a page, request.write raises
6849 pb.DeadReferenceError . Catch this and treat it like a
6850 notifyFinish event by dropping the request.
6852 2003-08-18 Brian Warner <warner@lothar.com>
6854 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6855 (instead of blowing up) if a force-build command is given without
6858 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6859 don't blow up if there aren't yet any Changes in the list
6861 2003-08-02 Brian Warner <warner@lothar.com>
6863 * buildbot/bot.py (updateApplication): don't set the .tap name,
6864 since we shouldn't assume we own the whole .tap file
6866 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6867 'mktap buildbot' (without a subcommand) better
6869 2003-07-29 Brian Warner <warner@lothar.com>
6871 * buildbot/status/words.py
6872 (IrcStatusFactory.clientConnectionLost): when we lose the
6873 connection to the IRC server, schedule a reconnection attempt.
6875 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6876 use shutil.rmtree instead of forking off an "rm -rf" command.
6877 rmtree may take a while and will block until it finishes, so we
6878 use "rm -rf" if available.
6880 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6881 freebsd buildslave badly
6883 * setup.py (version): bump to 0.3.4+ while between releases
6885 2003-07-28 Brian Warner <warner@lothar.com>
6887 * setup.py (version): Releasing buildbot-0.3.4
6889 2003-07-28 Brian Warner <warner@lothar.com>
6891 * NEWS: update in preparation for release
6893 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6894 process.signalProcess instead of os.kill, to improve w32
6897 * docs/examples/twisted_master.py (twisted_app): turn off
6898 win32eventreactor: the tests hang the buildslave badly
6900 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6901 failed builds, since usually the failures are consistent
6903 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6904 add compileOpts/compileOpts2 to reactors build
6906 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6907 (twisted_app): use both default and win32eventreactor on w32 build.
6908 Use both default and kqreactor on freebsd build.
6910 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6911 add compileOpts2, which is put after the build_ext argument. w32
6912 needs "-c mingw32" here.
6914 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6915 touch .acqpath, it goes away in recent Twisted releases
6917 * docs/examples/twisted_master.py (twisted_app): use "python" for
6918 the w32 buildslave, not "python2.2"
6920 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6921 the directory exists.. should hush an exception under w32
6923 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6924 ProcessTerminated -provided values for signal and exitCode rather
6925 than parsing the unix status code directly. This should remove one
6926 more roadblock for a w32-hosted buildslave.
6928 * test/test_mailparse.py: add test cases for Syncmail parser
6930 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6931 temporary compatibility import. Note! Start importing
6932 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6934 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6936 2003-07-27 Brian Warner <warner@lothar.com>
6938 * NEWS: started adding new features
6940 * buildbot/changes/mail.py: start work on Syncmail parser, move
6941 mail sources into their own file
6943 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6944 as implementing IChangeSource
6945 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6947 * buildbot/interfaces.py: define the IChangeSource interface
6949 2003-07-26 Brian Warner <warner@lothar.com>
6951 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6953 2003-06-25 Brian Warner <warner@lothar.com>
6955 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6958 2003-06-17 Brian Warner <warner@lothar.com>
6960 * buildbot/status/words.py: clean up method usage to avoid error
6961 in silly IRC command
6962 (IrcStatusBot.emit_status): round off seconds display
6964 * buildbot/process/base.py (Build): delete the timer when saving
6965 to the .tap file, and restore it (if it should still be running)
6966 upon restore. This should fix the "next build in -34 seconds"
6967 messages that result when the master is restarted while builds are
6968 sitting in the .waiting slot. If the time for the build has
6969 already passed, start it very soon (in 1 second).
6971 * buildbot/status/words.py: more silly commands
6973 * README (REQUIREMENTS): add URLs to all required software
6975 * buildbot/status/words.py ('last'): mention results of, and time
6978 2003-05-28 Brian Warner <warner@lothar.com>
6980 * buildbot/status/words.py: add 'last' command
6981 (IrcStatusBot.emit_status): add current-small text to 'status' output
6983 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6984 (twisted_app): remove spaces from OS-X builder name
6986 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6987 * buildbot/status/words.py: IRC bot should actually be useful now
6989 2003-05-23 Brian Warner <warner@lothar.com>
6991 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6992 "slave information" from $(slavedir)/info/* . These files are
6993 maintained by the slave administrator, and describe the
6994 machine/environment that is hosting the slave. Information from
6995 them is put into the "Builder" HTML page. Still need to establish
6996 a set of well-known filenames and meanings for this data: at the
6997 moment, *all* info/* files are sent to the master, but only
6998 'admin' and 'host' are used on that end.
6999 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7000 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7001 * buildbot/master.py (BotPerspective.got_info): ditto
7003 2003-05-22 Brian Warner <warner@lothar.com>
7005 * setup.py (version): bump version to 0.3.3+ while between releases
7007 2003-05-21 Brian Warner <warner@lothar.com>
7009 * setup.py: Releasing buildbot-0.3.3
7011 2003-05-21 Brian Warner <warner@lothar.com>
7013 * NEWS: 0.3.3 news items
7015 * README: describe --keepalive and life behind a NAT box
7017 * buildbot/bot.py (Bot.connected): implement application-level
7018 keepalives to deal with NAT timeouts, turn them on with
7019 --keepalive option or when SO_KEEPALIVE doesn't work.
7021 * buildbot/master.py (BotPerspective): accept keepalives silently
7023 * buildbot/process/base.py (Build.buildException): CopiedFailures
7024 don't carry as much information as local ones, so don't try to
7025 create a big HTMLized version of them.
7027 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7028 log file when step fails due to an exception, such as when the slave
7031 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7032 --testmodule argument instead of grepping for test-case-name tags
7033 ourselves. Remove FindUnitTests code.
7034 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7036 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7038 2003-05-16 Brian Warner <warner@lothar.com>
7040 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7041 argument to allow things like CFLAGS=-O0 to be passed without relying
7042 upon /bin/sh processing on the slave.
7044 * buildbot/process/step.py (InternalShellCommand.start): send
7046 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7047 'split' instead of letting /bin/sh do it. This should also remove
7048 the need for /bin/sh on the buildslave, making it more likely to
7051 * buildbot/status/html.py: html-escape text in blamelist.
7052 Add "force build" button to the Builder page.
7054 * buildbot/process/step_twisted.py (countFailedTests): look at
7055 last 1000 characters for status line, as import errors can put it
7056 before the -200 point.
7058 2003-05-15 Brian Warner <warner@lothar.com>
7060 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7062 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7063 make 'clobber' a parameter, so it is possible to have builds which
7064 do full tests but do a cvs update instead of hammering the CVS
7065 server with a full checkout each build
7067 * buildbot/process/step.py (InternalShellCommand): bump default
7068 timeout to 20 minutes
7070 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7071 the master to trigger a build. Run it via manhole.
7073 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7074 allow slaves to trigger any build that they host, to make life
7075 easier for slave admins who are testing out new build processes
7077 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7078 don't flunk cReactor or qtreactor on failure, since they fail alot
7079 these days. Do warnOnFailure instead.
7081 * buildbot/process/base.py: change Builder.buildable from a list
7082 into a single slot. When we don't have a slave, new builds (once
7083 they make it past the timeout) are now merged into an existing
7084 buildable one instead of being queued. With this change, a slave
7085 which has been away for a while doesn't get pounded with all the
7086 builds it missed, but instead just does a single build.
7088 2003-05-07 Brian Warner <warner@lothar.com>
7090 * setup.py (version): bump version to 0.3.2+ while between releases
7092 2003-05-07 Brian Warner <warner@lothar.com>
7094 * setup.py: Releasing buildbot-0.3.2
7096 2003-05-07 Brian Warner <warner@lothar.com>
7098 * setup.py: fix major packaging error: include subdirectories!
7100 * NEWS: add changes since last release
7102 * README (REQUIREMENTS): update twisted/python dependencies
7104 * buildbot/status/builder.py (Builder.startBuild): change
7105 BuildProcess API: now they should call startBuild/finishBuild
7106 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7107 keeping a list of builds in the statusbag, to support other kinds of
7109 (Builder.addClient): send current-activity-small to new clients
7110 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7113 * buildbot/status/client.py: drop RemoteReferences at shutdown
7115 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7117 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7118 more debug messages for remote status client
7120 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7121 (.stepFailed): only fire the Deferred once, even if both
7122 stepComplete and stepFailed are called. I think this can happen if
7123 an exception occurs at a weird time.
7125 * buildbot/status/words.py: work-in-progress: IRC status delivery
7127 2003-05-05 Brian Warner <warner@lothar.com>
7129 * docs/examples/twisted_master.py (twisted_app): hush internal
7130 python2.3 distutils deprecation warnings
7131 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7132 add compileOpts= argument which inserts extra args before the
7133 "setup.py build_ext" command. This can be used to give -Wignore
7134 warnings, to hush some internal python-2.3 deprecation messages.
7136 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7137 the ['twisted.test'] default test case to make it easier to change
7140 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7141 * buildbot/clients/gtkPanes.py: ditto
7143 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7144 arg to collapse RunUnitTestsRandomly into RunUnitTests
7145 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7146 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7148 * buildbot/status/html.py (StatusResource): shuffle Resources
7149 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7150 would serve the waterfall display, but the internal links were
7151 only valid on the trailing-slash version. The correct behavior is
7152 for the non-slashed one to serve a Redirect to the slashed one.
7153 This only shows up when the buildbot page is hanging off another
7154 server, like a Twisted-Web distributed server.
7156 * buildbot/status/event.py (Event, RemoteEvent): make Events
7157 pb.Cacheable, with RemoteEvent as the cached version. This removes
7158 a lot of explicit send-an-update code.
7159 * buildbot/status/builder.py (Builder): remove send-update code
7160 * buildbot/status/client.py (ClientBuilder): remove send-update
7161 code, and log errors that occur during callRemote (mostly to catch
7162 InsecureJelly exceptions)
7164 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7165 run Lore with the same python used in the rest of the build
7167 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7169 * buildbot/process/step_twisted.py (HLint): accept 'python'
7170 argument. Catch rc!=0 and mark the step as failed. This marks the
7171 build orange ("has warnings").
7172 (RunUnitTestsJelly): move out to step_twisted2.py
7174 * buildbot/util.py (ignoreStaleRefs): add utility function
7176 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7177 don't fake ETA object, it's too hard to get right
7179 2003-05-02 Brian Warner <warner@lothar.com>
7181 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7183 2003-05-01 Brian Warner <warner@lothar.com>
7185 * buildbot/status/html.py (StatusResource.body): oops, I was
7186 missing a <tr>, causing the waterfall page to be misrendered in
7187 everything except Galeon.
7189 2003-04-29 Brian Warner <warner@lothar.com>
7191 * docs/examples/twisted_master.py: make debuild use python-2.2
7192 explicitly, now that Twisted stopped supporting 2.1
7194 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7195 handle tuple results too. I keep forgetting this, which suggests
7196 it needs to be rethought.
7198 * setup.py (setup): bump version to 0.3.1+ while between releases
7200 2003-04-29 Brian Warner <warner@lothar.com>
7202 * setup.py: Releasing buildbot-0.3.1
7204 2003-04-29 Brian Warner <warner@lothar.com>
7206 * README (SUPPORT): add plea to send questions to the mailing list
7208 * NEWS, MANIFEST.in: add description of recent changes
7210 * docs/examples/twisted_master.py: add the code used to create the
7211 Twisted buildmaster, with passwords and such removed out to a
7214 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7215 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7216 buildmasters to not require CVSToys be installed.
7217 * README, docs/examples/glib_master: update to match the change
7219 * buildbot/clients/base.py, buildbot/bot.py,
7220 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7221 ReconnectingPB from CVSToys distribution to remove CVSToys
7222 dependency for build slaves and status clients. Buildmasters which
7223 use FreshCVSSources still require cvstoys be installed, of course.
7225 2003-04-25 Brian Warner <warner@lothar.com>
7227 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7228 runTestsRandomly arg to turn on trial -z
7230 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7231 experimental code to use trial's machine-parseable output to get
7232 more detailed test results. Still has some major issues.
7233 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7236 * buildbot/status/builder.py (Builder.setCurrentBuild):
7237 anticipating moving build history into statusbag, not used yet
7239 * buildbot/status/tests.py: code to centralize test results,
7240 doesn't work quite yet
7242 * buildbot/status/event.py (Event): use hasattr("setName") instead
7243 of isinstance for now.. need better long-term solution
7245 * buildbot/status/html.py: Remove old imports
7247 2003-04-24 Brian Warner <warner@lothar.com>
7249 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7250 ignore changes under doc/fun/ and sandbox/
7252 * buildbot/process/step_twisted.py: update pushEvent and friends.
7254 * buildbot/status/html.py (Box.td): replace event.buildername with
7255 event.parent.getSwappableName(). Needs more thought.
7257 * buildbot/status/builder.py (Builder): Replace pushEvent and
7258 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7259 Tell events they are being pruned with event.delete().
7261 * buildbot/process/base.py (Build): Remove Builder status-handling
7262 methods. s/pushEvent/setCurrentActivity/.
7264 * buildbot/process/step.py (BuildStep): clean up status delivery.
7265 Gouse builder.statusbag methods instead of intermediate builder
7266 methods. s/updateLastEvent/updateCurrentActivity/.
7267 s/finalizeLastEvent/finishCurrentActivity/. Use
7268 addFileToCurrentActivity for summaryFunction.
7270 * buildbot/status/event.py (Logfile): put data in a Swappable when
7272 (Event): add more setter methods. Remove .buildername, use .parent
7273 and getSwappableName instead (needs more thought).
7275 * buildbot/util.py (Swappable):
7276 * test/test_swap.py: don't bother setting filename at __init__
7277 time, do it later. Change setFilename args to take parent first,
7278 since it provides the most significant part of the filename.
7280 2003-04-23 Brian Warner <warner@lothar.com>
7282 * buildbot/status/event.py (Logfile.addEntry): append to previous
7285 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7286 anticipating Swappable
7287 (InternalShellCommand.remoteUpdate): split out various log-adding
7288 methods so subclasses can snarf stdout separately
7290 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7291 in anticipation of Swappable build logs
7292 (Builder.testsFinished): anticipating TestResults, still disabled
7294 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7297 * buildbot/status/event.py (Logfile): add (disabled) support for
7298 Swappable, not ready for use yet
7300 * buildbot/util.py (Swappable): object which is swapped out to
7301 disk after some period of no use.
7302 * test/test_swap.py: test buildbot.utils.Swappable
7304 2003-04-14 Brian Warner <warner@lothar.com>
7306 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7307 periodic-build timer. Set the .periodicBuildTime on a builder
7308 instance to some number of seconds to activate it.
7310 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7312 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7313 a way that survives result tuples
7315 2003-04-12 Brian Warner <warner@lothar.com>
7317 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7318 return a dict instead of a tuple: allow summarizers to provide
7319 multiple summaries if they want
7320 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7321 (debuildSummarizer): summarize lintian warnings/errors
7323 2003-04-10 Brian Warner <warner@lothar.com>
7325 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7327 2003-04-09 Brian Warner <warner@lothar.com>
7329 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7330 empty summaries: happens when the tests fail so hard they don't emit
7331 a parseable summary line.
7333 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7334 Allow summaryFunction to return None to indicate no summary should
7337 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7338 writing to stale HTTP requests: notice when they disconnect and
7339 remove the request from the list. Also add CacheToFile from
7340 moshez, will be used later.
7342 2003-04-08 Brian Warner <warner@lothar.com>
7344 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7345 should be an int, not a list of strings
7347 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7348 if we weren't actually connected
7350 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7351 to show the tail end of the trial text output
7353 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7354 hook to summarize the results of a ShellCommand
7356 2003-04-07 Brian Warner <warner@lothar.com>
7358 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7359 twisted test suite code into a single class.
7360 * buildbot/process/process_twisted.py: same
7362 2003-04-04 Brian Warner <warner@lothar.com>
7364 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7366 * README (SLAVE): document use of mktap to create slave .tap file
7367 (REQUIREMENTS): describe dependencies
7369 * buildbot/bb_tap.py, buildbot/plugins.tml:
7370 * buildbot/bot.py (updateApplication): Add mktap support for creating
7371 buildslave .tap files
7373 2003-03-28 Brian Warner <warner@lothar.com>
7375 * buildbot/process/step.py (InternalShellCommand.finished): handle
7376 new tuple result values (fix embarrasing bug that appeared during
7379 2003-03-27 Brian Warner <warner@lothar.com>
7381 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7384 2003-03-25 Brian Warner <warner@lothar.com>
7386 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7387 to overall build status
7388 * buildbot/clients/base.py (Builder): improve event printing
7389 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7390 instead of generic ShellCommand
7391 (Build): Add .stopBuild, use it when slave is detached
7393 * buildbot/process/step.py (Configure,Test): give the steps their
7394 own names and status strings
7396 * buildbot/status/html.py (StatusResource): add "show" argument,
7397 lets you limit the set of Builders being displayed.
7399 2003-03-20 Brian Warner <warner@lothar.com>
7401 * buildbot/process/basic.py: removed
7403 2003-03-19 Brian Warner <warner@lothar.com>
7405 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7406 turn off process-docs by default
7408 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7409 when displaying build information without anything in allBuilds[]
7411 * buildbot/bot.py (makeApp): really take password from sys.argv
7413 2003-03-18 Brian Warner <warner@lothar.com>
7415 * buildbot/bot.py (buildApp): take password from sys.argv
7417 * README: replace with more useful text
7419 * setup.py: add a real one
7420 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7422 * docs/PyCon-2003/: added sources for PyCon paper.
7424 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7425 now Build objects control the process and Builder only handles
7426 slave stuff and distribution of changes/status. A new BuildFactory
7427 class creates Build objects on demand.
7429 Created ConfigurableBuild which takes a list of steps to run. This
7430 makes it a lot easier to set up a new kind of build and moves us
7431 closer to being able to configure a build from a web page.
7433 * buildbot/process/step_twisted.py, process_twisted.py: move to
7434 new model. A lot of code went away.
7436 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7437 send lots of empty progress messages to the client.
7439 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7441 2003-02-20 Brian Warner <warner@lothar.com>
7443 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7445 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7446 Twisted bug that prevented non-pty processes from working just got
7447 fixed, and the bug that leaks ptys is still being investigated.
7449 * buildbot/process/step.py (CVS): send timeout arg to slave
7451 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7452 builders coming and going
7453 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7454 from CVSToys, handle lost-buildmaster
7456 * buildbot/status/client.py (StatusClientService.removeBuilder):
7457 Clean up status client protocol: send builders (with references)
7458 as they are created, rather than sending a list and requiring the
7459 client to figure out which ones are new.
7460 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7461 attempts to force a build on an unknown builder
7463 2003-02-19 Brian Warner <warner@lothar.com>
7465 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7466 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7467 Twisted stops leaking them.
7468 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7469 builder goes to an idle state.
7471 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7472 I figure out why CVS commands hang without them, and/or I fix the
7473 hung-command timeout
7475 2003-02-16 Brian Warner <warner@lothar.com>
7477 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7478 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7479 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7480 GenerateDocs now that they are prefixed with WARNING:.
7482 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7483 use manual href target instead of request.childLink
7485 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7486 display every second, but update the ETA every 5 seconds (or
7487 whenever) as remote_progress messages arrive.
7490 2003-02-12 Brian Warner <warner@lothar.com>
7492 * *: import current sources from home CVS repository
7496 # add-log-time-format: add-log-iso8601-time-string