1 2007-09-30 Brian Warner <warner@lothar.com>
3 * contrib/darcs_buildbot.py: refactor internals a bit, make it
4 possible to use as an importable module (to make it easier to
5 write some unit tests for it)
7 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
8 DeprecationWarning for Waterfall, advising users to switch over to
11 * NEWS: update with user-visible changes since the last release
13 * buildbot/status/web/waterfall.py
14 (WaterfallStatusResource.get_reload_time): if the suggest a
15 reload time of less than 15 seconds, give them 15 seconds instead
16 of ignoring their request entirely, because that'd be confusing.
18 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
19 warning if we must invoke the last-change-is-most-recent guess
21 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
22 Waterfall is running in an upgraded master (which is the usual
23 case for folks who have followed the instructions to run
24 'upgrade-master' but who have not yet resolved all the
25 DeprecationWarnings), prefer the buildbot.css from public_html/
26 rather than the one passed in on the buildbot= argument.
27 Otherwise, the resulting pages don't quite use CSS right..
28 sometimes it works, sometimes it doesn't, and I don't know why.
29 Sites that are using custom CSS will see the default CSS until
30 they modify public_html/buildbot.css to include their
33 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
34 * buildbot/status/web/robots.txt (Disallow): update to cover all
35 dynamically-generated pages
37 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
38 include both 'trunk' and None in the output list, since some VC
39 systems (SVN, frequently) refer to trunk as 'trunk'.
41 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
42 point the 'welcome' link explicitly at index.html, rather than
43 '.', so that old Waterfall users can reach it and discover all the
46 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
47 build's text to the end of the line, without a CSS class so it
50 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
51 'max_search=' argument, to limit the number of builds that are
52 examined while trying to find ones that match the other criteria.
53 This helps to limit the work we do, since otherwise we might have
54 to trawl through all history.
55 (IBuilderStatus.generateFinishedBuilds): same
56 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
57 (BuilderStatus.generateFinishedBuilds): same
59 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
60 our got_revision before checking its length: SVN (at least) still
61 reports numeric values for this.
62 * buildbot/status/web/build.py (StatusResourceBuild.body): same
63 * buildbot/status/web/xmlrpc.py
64 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
65 serving a completely fake revision
67 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
68 basedir to sys.path, to mimic what a real buildmaster would have
69 access to, since it is common for master.cfg to import helper
70 classes from .py files in the buildmaster directory, and we want
71 config-file checking to accomodate this.
73 * buildbot/status/web/base.py (map_branches): when referring to
74 branches through WebStatus (i.e. by appending ?branch=FOO query
75 arguments to the URL), make "trunk" mean trunk, by mapping it to
76 None before passing it to generateFinishedBuilds() and the like.
77 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
78 (OneBoxPerBuilder.body): same, also improve display of branches in
80 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
81 (WaterfallStatusResource.buildGrid): same. Note that this filters
82 Changes as well as Builds.
83 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
84 caveat about trunk branches, now that it's fixed
86 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
87 from builder.py, use it on the Builder page too
89 * buildbot/status/web/builder.py (StatusResourceBuilder): same
90 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
91 names, add some CSS classes
92 * buildbot/status/web/classic.css (td.box): new class, for
95 * docs/buildbot.texinfo (WebStatus): update docs
97 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
98 the trailing "M" indicator that tells us this is a modified file.
99 This should help with mode="update" builds that modify files
100 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
103 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
104 new copies of files (to .new) when those files already exist,
105 check the master.cfg file for errors (and give DeprecationWarnings
106 a chance to be displayed).
107 * buildbot/test/test_runner.py: add more tests
108 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
110 2007-09-29 Brian Warner <warner@lothar.com>
112 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
113 the revision id from the last change in our list, since that's the
114 best we can do without knowing the full ancestry graph. Closes #103.
116 * buildbot/scripts/sample.cfg: use buildstep instances in
117 f.addStep, to demonstrate the (correct) modern usage.
118 * docs/examples/hello.cfg: bring this up to date. Closes #79.
119 * docs/examples/twisted_master.cfg: add a big warning about how
121 * docs/examples/glib_master.cfg: delete this one entirely, it is
122 ancient and not a very useful example anyways
124 * buildbot/status/web/base.py (HtmlResource.render): keep track of
125 HTTPChannels, so we can shut them down at reconfig time (when the
126 WebStatus goes away). Closes #102.
127 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
128 (WebStatus.registerChannel): same
129 (WebStatus.stopService): do .loseConnection() here
131 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
132 WebStatus, make sure all pages are still retrievable. I thought
133 this would exercise a bug, but it turns out that it was firefox
134 caching connections (and continuing to talk to the old WebStatus
135 even though I'd loaded a new one).
136 * buildbot/status/web/baseweb.py (WebStatus): add some comments
137 (WebStatus.__repr__): include id() in the repr
139 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
140 this to specify an errorparser. From Ted Mielczarek and the
141 mozilla crew. Closes #94.
143 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
144 bonsaipoller ignore funkyness in xml output for empy log
145 messages", from Axel Hecht. Closes #90.
146 * buildbot/test/test_bonsaipoller.py
147 (TestBonsaiPoller.testMergeEmptyLogMsg): same
149 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
150 respect 'builders' arg, from Ben Hearsum. Closes #89.
152 * buildbot/scripts/runner.py (stop): increase the timeout from 5
153 seconds to 10, to give heavily loaded machines a better chance to
154 finish shutting down. Addresses (partially) #68.
155 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
157 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
158 * buildbot/scripts/startup.py (Follower._failure): update message
160 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
161 team, to fix some bugs and avoid the use of blocking urlopen().
163 * buildbot/test/test_bonsaipoller.py: same
165 2007-09-28 Brian Warner <warner@lothar.com>
167 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
168 argument, to send email about buildslaves which are disconnected
169 for more than an hour. Closes #64.
170 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
172 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
173 (MailNotifier): add docs for this too
176 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
177 respect branch= queryargs, by restricting the builds displayed to
178 those matching the given branch names
179 * buildbot/status/web/waterfall.py (BuildTopBox): same
181 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
182 fix a test failure by adding .prepath to this fake object
184 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
185 up generation of relative URLs. With luck, this should play with
186 reverse proxies much better now.
187 * buildbot/test/test_webparts.py: new test for most of the subpages
188 * buildbot/test/test_web.py (base_config): add enough of a config
189 to exercise more Waterfall code
191 2007-09-27 Brian Warner <warner@lothar.com>
193 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
194 relative URL to the buildbot welcome page, rather than
196 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
198 * buildbot/status/web/base.py (HtmlResource.title): change the
199 default title of all Buildbot-generated page to "Buildbot"
200 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
201 change the title to include the Builder name
202 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
203 same, and also show the build number
204 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
205 redirect the browser to the Builder page
207 2007-09-26 Brian Warner <warner@lothar.com>
209 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
210 problem with the build links
212 2007-09-25 Brian Warner <warner@lothar.com>
214 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
215 to emit relative URLs instead of using URLPath,
217 * docs/buildbot.texinfo (WebStatus): provide an example
219 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
220 page, shows a simple table with one row per Builder. Still pretty
221 ugly, but functional.
222 * buildbot/status/web/index.html: reference it
224 * buildbot/status/web/waterfall.py (Spacer): make this *not*
225 inherit from builder.Event, so that show_events=false doesn't hide
226 spacers, since that would make the waterfall weirdly compressed.
228 * buildbot/status/web/waterfall.py (HELP): put the View button in
229 its own section, so it doesn't get visually confused with the
231 (WaterfallStatusResource.body): make the '[help]' links more
232 visually distinct from each other, and add a link to the Welcome
234 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
235 unused buildslaves without exploding
237 * buildbot/status/web/waterfall.py
238 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
239 it gives us absolute paths that break proxies
240 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
241 this, it was giving bad results when the Waterfall is behind a
244 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
245 new 'upgrade-master' command, which will bring an old buildmaster
246 directory up-to-date. Right now the only thing it does is populate
247 public_html/ if it wasn't already there. Still to do: check the
248 other files, add documentation.
249 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
250 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
252 2007-08-13 Brian Warner <warner@lothar.com>
254 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
255 that contains the checkin comments when you hover over the entry
256 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
259 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
262 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
263 page with versions of python, buildbot, and twisted
264 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
265 * buildbot/status/web/index.html: add links to most pages
266 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
268 * buildbot/status/web/robots.txt: put a robots.txt in new installs
269 which discourages robot access to all large dynamically-generated
270 pages. The intention is that the index page and the 'about' page
271 are the only ones which should be crawlable.
272 * buildbot/scripts/runner.py (Maker.public_html): same
274 * setup.py: ship index.html and robots.txt in source distributions
276 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
277 activate automatic reloading of the page (using a meta Refresh:
279 (WaterfallHelp): new page to explain all the nifty query arguments
280 you can use on the Waterfall, along with forms to set them for
281 you. From this page, you can add filters for builder=, branch=,
282 show_events=, as well as turning on reload=.
283 (WaterfallStatusResource.buildGrid): new query args: last_time=,
284 first_time=, show_time=, num_events= . The old show= is still
285 accepted, but the new builder= is preferred. We ignore empty
286 branch= arguments, to make the WaterfallHelp form easier to
288 (WaterfallStatusResource.head): new method to add text to the
290 * buildbot/status/web/base.py (HtmlResource.content): use head()
291 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
292 empty branch= arguments
293 (OneLinePerBuildOneBuilder.body): same
295 2007-08-12 Brian Warner <warner@lothar.com>
297 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
298 new query args: 'last_time' is a timestamp of the top-most event
299 on the display, 'first_time' is a timestamp for the bottom-most
300 event. 'show_time' is the difference between them, and overrides
301 'first_time'. 'num_events' puts an upper limit on the number of
302 timestamps that will be displayed on the left hand edge.
303 (WaterfallStatusResource.body): add a 'next page' link to the
304 bottom, which shows the events that come just after those shown on
305 the current page. This is a first step towards #67, but we need
306 some more controls before we can close that one.
308 * buildbot/buildslave.py (BuildSlave): these are now MultiService
309 instances too, and live as children of the BotMaster. The main
310 advantage of this approach is that BuildSlaves can know when they
311 are being removed (so they can shut off the upcoming
312 when-do-we-email-an-admin-because-we-lost-our-slave timer).
313 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
314 identify which service children are BuildSlaves
315 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
316 Checker updates here, but delegate the rest to..
317 (BotMaster.loadConfig_Slaves): .. here, which looks at the
318 BotMaster's service children to identify the old slaves. I think
319 the previous approach of using master.slaves was broken in the
320 face of config updates that modified BuildSlave instances but did
321 not completely replace them.
322 * docs/buildbot.texinfo (Developer's Appendix): note the change to
323 the Service hierarchy
325 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
326 page (at URL /buildslaves/) to view status of all buildslaves at
327 once, including how long it's been since we last heard from them,
328 and which Builders use them.
330 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
333 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
336 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
337 use the BuildSlave to keep track of the last time we've heard from
338 the buildslave. This is updated upon receipt of any message from
339 any SlaveBuilder (which generally means when RemoteCommands are
340 giving us status updates, as BuildSteps run). In the future this
341 will include slave pings too.
342 * buildbot/process/base.py
343 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
344 * buildbot/process/buildstep.py:
345 (BuildStep.setBuildSlave): accept that reference
346 (BuildStep.runCommand): pass the reference on to the RemoteCommand
347 (RemoteCommand.remote_update): update the timestamp
348 (RemoteCommand.remote_complete): same
349 * buildbot/test/runutils.py (StepTester.makeStep): match the change
350 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
351 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
352 interface to retrieve this timestamp
353 * buildbot/status/builder.py (SlaveStatus): track a copy of the
357 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
359 (OneLinePerBuild.body): use a <ul> instead of <div>s
360 (OneLinePerBuildOneBuilder.body): same
362 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
363 by adding the file's new name to the list of changed files. This
364 ought to be sufficient for things like isFileImportant and trial
365 tests that only exercise tests for files that have been modified.
368 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
369 XMLRPC server to the WebStatus page. This only has two methods
370 right now (getAllBuildsInInterval and getBuild), but we'll be
371 adding more in the future. This server is extracted from the
374 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
375 generateFinishedBuilds, and improve the data displayed.
376 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
377 the per-Build page, add some information like ETA and got_revision
378 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
379 adding a list of recently completed builds
380 * buildbot/status/web/base.py (css_classes): factor this out
382 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
383 new method, to make status display classes easier to write,
384 especially the WebStatus 'one_line_per_build' page.
385 (IBuilderStatus.generateFinishedBuilds): same
386 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
387 (Status.generateFinishedBuilds): implement it
389 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
390 'source' to be a BuildStep instance, since BuildFactory accepts
392 (CPAN.__init__): same
393 (Distutils.__init__): same
394 (Trial.__init__): same
396 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
397 this might raise KeyError
399 2007-08-07 Brian Warner <warner@lothar.com>
401 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
402 'Owner:' field of the view, rather than 'p4logname', since
403 p4logname comes from the buildslave's environment and seems
404 unlikely to ever do the right thing. Thanks to Wade Brainerd for
405 the patch. Closes #40.
407 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
408 which imposes a per-slave limit on how many builds are allowed to
409 run simultaneously. This has a the same scope than the SlaveLock,
410 but is different because max_builds= gives the buildmaster the
411 freedom to assign the build to a different slave, whereas the
412 SlaveLock doesn't get tested until after the build is irrevocably
413 assigned to a slave. Therefore using max_builds= will improve
414 utilization in the presence of multiple buildslaves that are
415 attached to the same Builder. This completes the incorporation of
416 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
417 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
418 any Builder finishes, potentially trigger *all* Builders, since
419 max_builds= may have stalled someone else while waiting for the
421 * buildbot/scripts/sample.cfg: mention max_builds=
422 * buildbot/test/test_run.py (ConcurrencyLimit): test it
423 * docs/buildbot.texinfo (Buildslave Specifiers): document it
425 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
426 inherit from RunMixin do not need to call master.stopService()
427 themselves, since RunMixin.tearDown does that. The double call
428 fails on Twisted-2.0.x, which didn't happen to protect against it.
429 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
431 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
432 from #48, this one to have the BuildSlave objects track
433 SlaveBuilders, so they'll be able to use that knowledge to
434 influence their canStartBuild() response.
435 * buildbot/process/builder.py (SlaveBuilder.attached): call it
436 (SlaveBuilder.detached): same
437 * buildbot/test/test_slaves.py (BuildSlave): test it
439 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
440 the second of Dustin's #48 patches, this one adding a method to
441 the BuildSlave that allows it to decide whether it is willing to
442 participate in a build or not.
443 (SlaveBuilder.isAvailable): use canStartBuild() to decide
445 * buildbot/test/test_run.py (CanStartBuild): test for it
447 * all: incorporate the first of four patches by Dustin Mitchell
448 from ticket #48, working towards improving control over slave
449 concurrency. The first patch is to use a long-lived BuildSlave
450 object per slave, on which other behavior can be added later. I've
451 modified his patch considerably.
452 * buildbot/buildslave.py (BuildSlave): move class out of
453 slave/__init__.py (where it would get loaded by the slave as well
454 as the master, making dependencies trickier), and merge it with
455 BotPerspective. Now these BuildSlave instances are created once in
456 the master.cfg file, and not destroyed until they are either
457 removed from the config file or changed so
458 much (name/password/class changes) that we cannot continue to use
459 the old one. This affects config files: they must use
460 'from buildbot.buildslave import BuildSlave' instead of using
461 'from buildbot.slave import BuildSlave'.
462 * buildbot/master.py: move BotPerspective out
463 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
464 add or remove as necessary, update the rest using data from
466 * buildbot/slave/__init__.py: move BuildSlave out
467 * buildbot/test/test*.py: import BuildSlave from the new place
468 * buildbot/scripts/sample.cfg: update to match
469 * docs/buildbot.texinfo: update to match
470 * buildbot/process/builder.py: update comments to match
472 2007-08-02 Brian Warner <warner@lothar.com>
474 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
475 one-line-per-build pages a bit, add a header, refactor slightly
477 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
478 the TimeOutError timer, patch by Dustin Mitchell.
480 2007-08-01 Brian Warner <warner@lothar.com>
482 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
483 mostly work (branch= is still ignored, we need a useful header)
484 (OneLinePerBuildOneBuilder.body): this too
486 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
487 bring this up-to-date w.r.t. recent refactorings, and fix
488 redirections to bounce the browser to the top page after hitting
489 the 'force' button. This needs to be improved, but at least it now
490 redirects to a valid page.
491 (StatusResourceBuilder.ping): same
492 (StatusResourceBuilder.getChild): same, although I think this code
493 might be dead anyways
495 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
496 a branch= query argument, to filter the display down to builds and
497 changes that involve the given branch. You can add multiple
498 branch= arguments to see multiple branches (using a logical OR).
499 Note that there is no way to include the default branch (i.e.
500 None, i.e. trunk) yet, there is still work to be done to allow for
501 simple+uniform names of branches (i.e. removing the VC-specific
502 details of how branches are implemented, so calling the branch
503 'beta4' even though the SVN checkout step requires
505 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
506 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
507 * buildbot/interfaces.py (IEventSource.eventGenerator): same
508 * docs/buildbot.texinfo (Buildbot Web Resources): document it
510 * all: bring import statements up-to-date: don't import
511 __future__, assume cPickle and cStringIO are always available.
512 Also remove #!/usr/bin/python lines from non-scripts, my editor
513 has been a bit over-enthusiastic about stuffing them into new .py
516 * buildbot/status/web/index.html: put a link to the waterfall page
517 on the index, otherwise first-time users of WebStatus aren't going
518 to see anything very interesting.
520 * buildbot/interfaces.py (IEventSource): document this interface.
521 Thanks to Dustin Mitchell for the patch. Closes #60.
522 * buildbot/status/builder.py (BuilderStatus): same
523 * buildbot/changes/changes.py (ChangeMaster): same
525 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
526 add a query arg of 'show_events=true' to display non-build events,
527 like slaves attaching/detaching and reconfig events, or
528 'show_events=false' to hide them. The default is 'true'.
529 * docs/buildbot.texinfo (Buildbot Web Resources): document it
531 * web-parts: merge in web-parts branch. Lots of changes. The new
532 functionality is to add buildbot.status.html.WebStatus, which is a
533 superset of the Waterfall that adds new status pages and serves
534 regular files from BASEDIR/public_html/ , which is now the preferred
535 place to put robots.txt, buildbot.css, and index.html .
536 * buildbot/scripts/runner.py: the 'create-master' command now
537 creates public_html/ too, and populates it with a couple of
539 * buildbot/status/web: split waterfall code into smaller pieces
541 2007-07-31 Brian Warner <warner@lothar.com>
543 * buildbot/scripts/startup.py (launch): import twistd.run in a
544 different way to hush pyflakes
545 * buildbot/process/builder.py: remove unused import
547 2007-07-30 Brian Warner <warner@lothar.com>
549 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
550 Mitchell: pass SourceStamps around rather than branch/version/etc
551 tuples. Thanks Dustin! Closes #70.
552 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
553 tuple rather than a list, to avoid surprising mutations
554 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
555 * buildbot/status/mail.py (MailNotifier.buildMessage): same
556 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
557 * buildbot/test/test_status.py (Subscription): same
558 * buildbot/test/test_control.py (Force): same
559 * buildbot/test/test_buildreq.py (Request.testMerge): same
561 2007-07-29 Brian Warner <warner@lothar.com>
563 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
564 variable, since it wasn't used and is confusing in the presence of
565 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
568 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
569 the Buildbot home-page link to point at buildbot.net instead of
570 sourceforge, and add a current-version query parameter so we can
571 get some statistics on which versions are in use out there.
573 2007-07-28 Brian Warner <warner@lothar.com>
575 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
576 with c['change_source'], leaving c['sources'] for backwards
577 compatibility (but deprecated), scheduled for removal in 0.8.0
578 * docs/buildbot.texinfo: same
579 * buildbot/test/test_config.py: verify that c['sources'] still works
580 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
581 * buildbot/scripts/sample.cfg: update to match
583 * buildbot/changes/mail.py (MaildirSource): parse with python's
584 stdlib 'email' module, which has been available since python2.2,
585 and drop use of the 'rfc822' module, which has been depreceated
587 * buildbot/test/test_maildir.py: same: use parse_file() not parse
589 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
590 this needs to match the renaming in test/mail/msg*
592 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
595 * buildbot/test/test_mailparse.py: rename sample emails a bit
596 * buildbot/test/mail/msg*: same
598 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
599 parser for the "commit-email.pl" script that is shipped with SVN,
600 written by Justin Mason. Thanks! Closes SF#1072845.
601 * buildbot/test/mail/svn-commit.*: sample messages
602 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
603 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
605 2007-07-27 Brian Warner <warner@lothar.com>
607 * buildbot/changes/mail.py: refactor: move parsing into a method
608 named 'parse', each parser type gets a separate subclass. Remove
609 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
610 to be a simple leading-substring match. Add a warning to the logs
611 if prefix= does not end in a slash, since that's probably a
612 mistake. Fix both places where a prefix= mismatch would skip all
613 subsequent files in the same email, instead of just skipping the
614 one that didn't match.
615 * buildbot/test/test_mailparse.py: match changes
617 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
618 docs on email-based ChangeSources
620 * docs/buildbot.texinfo (Getting Source Code Changes): move all
621 the changesource types up a level, removing the one-entry menu in
624 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
625 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
626 instances instead of tuples. Closes #63.
627 * buildbot/slave/__init__.py (BuildSlave): define marker class
628 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
629 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
630 * buildbot/test/test_*.py: update tests to match
631 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
632 the c['bots'] backwards-compatibility handler works
634 2007-07-26 Brian Warner <warner@lothar.com>
636 * buildbot/changes/hgbuildbot.py (hook): add an in-process
637 Mercurial change-sending hook, contributed by Frederic Leroy.
638 Thanks! Addresses #50.
639 * docs/buildbot.texinfo (MercurialHook): document it
641 * buildbot/changes/hgbuildbot.py: change the way imports are done,
642 to make it compatible with at least hg-0.9.1 and the current 0.9.4
644 2007-07-17 Brian Warner <warner@lothar.com>
646 * buildbot/process/buildstep.py (BuildStep.getLog): add a
647 convenience method to retrieve a log added with
648 addLog()/addCompleteLog()/etc or logfiles= . I should have added
651 2007-07-03 Brian Warner <warner@lothar.com>
653 * buildbot/slave/commands.py (ShellCommand._startCommand): when
654 logging the environment variables, put one variable on each line,
655 rather than having one really long line with all of them. This
656 should make them a bit more readable and not trigger the
657 horizontal scrollbar (when viewing it in a web browser) quite so
658 much. Thanks to Albert Hofkamp for the patch.
660 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
661 WithProperties instance. Thanks to Axel Hecht for the patch.
663 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
664 * docs/buildbot.texinfo (Build Properties): document it
665 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
666 workdir if it didn't already exist.
668 * docs/buildbot.texinfo (Scheduler Types): correct the description
669 of Dependent schedulers. Thanks to Greg Ward for the patch.
671 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
672 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
673 the patch. Closes #49.
675 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
676 0700 before removing it, to deal with situations where a build will
677 leave files around without write permissions and the 'copy' or
678 'clobber' VC checkout modes need to blow away the tree first.
679 Thanks to Steve Milner for the suggestion and the patch (which I
680 mangled horribly). Closes #29.
681 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
684 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
685 an allowReconnect= argument to let callers control whether they
686 want this don't-let-it-reconnect behavior, since some tests care.
687 Factor out the .continueTrying=False lines from those callers.
688 * buildbot/test/test_slaves.py: same
689 * buildbot/test/test_run.py: same
691 2007-07-02 Brian Warner <warner@lothar.com>
693 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
694 slave has been disappeared, don't let it reconnect. This was
695 causing an intermittent failure in test_slaves.py, when the slave
696 that was supposed to be gone managed to come back by the end of
697 the test and affect the count.
698 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
700 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
701 diagnostic messages to track down this problem
702 (Builder.startBuild): same
704 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
705 the slave randomly rather than always taking the first one. Thanks
706 to Pike for the patch. Closes #36.
707 * buildbot/test/test_slaves.py: match the change. to avoid huge
708 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
709 enables/disables the round-robin-ness (enabled by default), and
710 some unit tests disable it.
711 * docs/buildbot.texinfo (Buildmaster Architecture): document it
713 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
714 argument to 'buildmaster_host', to make it more obvious that this
715 points to the buildmaster. Thanks to Bob Proulx for the
717 * buildbot/scripts/runner.py (slaveTAC): same
718 * buildbot/test/test_runner.py (Create.testSlave): match the change
720 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
723 2007-06-17 Brian Warner <warner@lothar.com>
725 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
726 we can round-trip all of our current step classes by calling
727 getStepFactory() and using the results to make a clone of the
730 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
733 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
734 the config file, we're moving to using actual instances instead of
735 the (class, kwargs) 'step specification' tuples. BuildFactory
736 still keeps a list of tuples internally, but when real instances
737 are passed in to addStep(), they are asked for their class and
738 kwargs using the new BuildStep.getStepFactory method. BuildFactory
739 accepts both instances and the tuple form, and converts instances
740 to the tuple form, but the instance form is preferred because it
741 gives the Steps a chance to do argument validation. Closes: #11.
743 * buildbot/process/buildstep.py (BuildStep.__init__): record the
744 factory information necessary to implement getStepFactory. The
745 addFactoryArguments() method can be used to include arguments that
746 aren't passed to the BuildStep base class constructor.
747 (BuildStep.setBuild):
748 (BuildStep.setDefaultWorkdir): new methods to take parameters that
749 are needed for live BuildSteps but not to construct the specification
750 tuples that are stashed in the factory.
752 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
753 'workdir' into new BuildSteps by using methods instead of
754 arguments. This makes the constructor for BuildSteps a lot
757 * buildbot/steps/*.py: update to match this change. Basically this
758 means adding calls to addFactoryArguments() in the __init__
759 methods to capture the arguments that aren't passed through to the
761 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
762 the new workdir (if any) into the RemoteShellCommands arguments.
763 * buildbot/steps/source.py: allow workdir= to be optional,
764 implement setDefaultWorkdir() since we don't inherit from
765 (CVS): finally remove old clobber=/export=/copydir= arguments,
766 in favor of the mode= argument that's been around forever now.
767 * buildbot/steps/transfer.py: remove build= argument
769 * buildbot/test/*.py: update to match, generally by turning all
770 build= arguments into subsequent calls to s.setBuild()
771 * buildbot/test/test_config.py (Factories): verify that we can
772 use either BuildStep instances or class/kwarg tuples in both
773 BuildFactory.addStep and BuildFactory.__init__
775 * docs/buildbot.texinfo (Build Steps): document the new approach,
776 mention compatibility with the old approach, update all examples
777 to use the new style.
779 2007-06-16 Brian Warner <warner@lothar.com>
781 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
782 the LoopingCall, just eat the failure so that we'll poll again
783 next time. This should allow us to tolerate (e.g.) sf.net SVN
784 failures more gracefully. Many thanks to Dustin Mitchell for the
787 2007-05-17 Brian Warner <warner@lothar.com>
789 * buildbot/status/words.py: refactor the IRC status bot into
790 separate 'Contact' and 'Channel' classes. The base Contact class
791 contains the interaction code: commands and responses. The
792 IRCContact subclass (and IrcStatusBot 'Channel') handle the
793 IRC-specific aspects. The plan is to write other subclasses for
794 other IM protocols like AIM and Jabber.
796 2007-04-16 Brian Warner <warner@lothar.com>
798 * CREDITS: update list of contributors. Thank you all!
800 2007-04-13 Brian Warner <warner@lothar.com>
802 * buildbot/status/mail.py (MailNotifier): add the project name to
803 the subject line and message body, to make it easier to
804 distinguish email coming from different buildmasters. Thanks to
805 Benoit Sigoure for the patch.
806 * buildbot/test/test_status.py (Mail): update to match
808 2007-03-24 Brian Warner <warner@lothar.com>
810 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
811 avoid text-conversion problems between DOS/windows and unix.
812 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
814 2007-03-03 Brian Warner <warner@lothar.com>
816 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
817 warning about the use of Waterfall here
819 2007-03-01 Brian Warner <warner@lothar.com>
821 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
823 2007-02-28 Brian Warner <warner@lothar.com>
825 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
826 Lamb to use a more optimal form of 'p4 changes', to reduce server
827 load. He reports that this optimization was added to p4d release
828 2005.2, but it should work in all versions. Closes #27.
829 * buildbot/test/test_p4poller.py: match it
831 2007-02-27 Brian Warner <warner@lothar.com>
833 * buildbot/status/web/*.py: move all web status stuff into a
834 separate directory, in anticipation of splitting it into smaller
835 pieces and adding more files. html.py was getting way too big.
836 * buildbot/status/classic.css: move it too
837 * setup.py: add the new sub-package
838 * buildbot/test/test_web.py: match the changes
839 * MANIFEST.in: handle the move of classic.css
841 2007-02-07 Brian Warner <warner@lothar.com>
843 * contrib/OS-X/*: add some launchd .plist files for automatically
844 starting a buildmaster or buildslave under OS-X (10.4 or later).
845 Thanks to Mark Pauley for these.
847 2007-02-06 Brian Warner <warner@lothar.com>
849 * docs/buildbot.texinfo (Requirements): update requirements to
850 stop claiming compatibility with python-2.2 or twisted-1.3.x .
852 * README: mention python-2.5 and twisted-2.5 compatibility
854 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
856 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
858 * buildbot/status/builder.py: same, by requiring cStringIO
859 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
860 * buildbot/test/test_vc.py: same
861 * buildbot/test/test_web.py:
862 * buildbot/test/test_steps.py: same, remove unused import
864 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
867 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
868 see any Builders that don't have Schedulers to drive them
870 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
871 attributes this uses went away
873 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
874 dialog, to allow you to reset the buildmaster and force
875 connect/disconnect. Correctly handle losing the buildmaster
876 connection (by switching the display to the hexnut, at which point
877 you can use the 'Connect' menu item to reconnect).
879 * buildbot/steps/source.py (Source.start): if we're using a patch,
880 add it as a LogFile to the checkout/update step. This will turn
881 into a link on the waterfall page.
883 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
884 option, to take the patch from a pre-made file rather than
885 generating it from the local tree. Thanks to Robert Helmer for the
886 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
887 * buildbot/scripts/runner.py (TryOptions): add --diff,
888 --patchlevel, and --baserev options
889 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
890 as None, meaning HEAD.
891 * buildbot/sourcestamp.py (SourceStamp): update docstring to
892 indicate that baserev=None means HEAD
893 * docs/buildbot.texinfo (try --diff): document it
895 * buildbot/test/test_steps.py (BuildStep): remove use of
896 reactor.iterate(), although the technique I replaced it with is a
897 gross polling hack that must be cleaned up properly some day. This
898 was the last use of reactor.iterate in the entire tree, yay.
900 2007-02-05 Brian Warner <warner@lothar.com>
902 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
903 is one of the three known values, otherwise we emit some confusing
904 messages later on. Thanks to Grig Gheorghiu for the catch.
906 2007-01-30 Brian Warner <warner@lothar.com>
908 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
909 Hearsum contributed a patch to let BonsaiPoller work with results
910 that contain non-ascii characters. Closes SF#1632641.
912 2007-01-27 Brian Warner <warner@lothar.com>
914 * Makefile (release): produce both .tar.gz and .zip source bundles.
917 2007-01-23 Brian Warner <warner@lothar.com>
919 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
920 * buildbot/changes/monotone.py: same
922 * buildbot/changes/maildir.py: combine several files into one,
923 clean up maildir.py to use Services properly.
924 * buildbot/changes/maildirtwisted.py: remove
925 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
927 * buildbot/changes/mail.py: match the change
928 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
929 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
931 * buildbot/slave/commands.py (command_version): bump to "2.3" to
932 indicate that the buildslave knows about the 'bzr' command
934 2007-01-22 Brian Warner <warner@lothar.com>
936 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
937 'with', it will become a reserved work in python2.6 .
939 * contrib/bb_applet.py: add a simple gnome-panel applet, to
940 display a terse summary of buildbot status.
941 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
942 some icons, small versions of the Blender object that lives in
943 docs/images/icon.blend
945 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
946 * buildbot/slave/commands.py (Bzr): same
947 * buildbot/scripts/tryclient.py (BzrExtractor): same
948 (SourceStampExtractor.dovc): modify this to allow non-zero exit
949 status, since 'bzr diff' does that
950 * buildbot/test/test_vc.py (Bzr): same
951 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
955 2007-01-20 Brian Warner <warner@lothar.com>
957 * contrib/darcs_buildbot.py: tidy up the progress messages
959 2007-01-17 Brian Warner <warner@lothar.com>
961 * contrib/darcs_buildbot.py: enhance to handle multiple patches
962 being pushed at a time. This keeps state in the repository in a
963 small file named .darcs_buildbot-lastchange, but that shouldn't
964 interfere with normal repository operations. Fixes SF#1534049.
965 * buildbot/clients/sendchange.py (Sender): make a single Sender
966 capable of sending Changes with different usernames.
968 2006-12-11 Brian Warner <warner@lothar.com>
970 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
971 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
972 buildbot.changes.mail a long time ago, but I forgot to add the
973 DeprecationWarning until now.
975 * buildbot/process/maxq.py: remove this, the functionality now
976 lives in buildbot.steps.maxq
978 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
979 * buildbot/clients/gtkPanes.py: remove unused import
981 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
982 that was meant to provide a special Reporter to run inside trial
983 and give the buildslave lots of machine-readable status. We never
984 finished this project.
986 * buildbot/changes/bonsaipoller.py: remove unused imports
987 * buildbot/changes/svnpoller.py: same
988 * buildbot/process/builder.py: same
989 * buildbot/process/buildstep.py: same
990 * buildbot/slave/bot.py: hush pyflakes warning
991 * buildbot/status/tests.py: remove unused imports
992 * buildbot/status/tinderbox.py: same
993 * buildbot/steps/python_twisted.py: same
995 * buildbot/process/step.py: remove this file, these names were
996 deprecated in 0.7.5 and are now being removed.
997 * buildbot/process/step_twisted.py: same
998 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1000 * buildbot/twcompat.py: remove the empty file, yay it is gone
1002 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1003 tw-2.0.0 and newer have the method we need.
1004 (getProcessOutputAndValue): same
1005 (which): remove this method, tw-2.0.0 t.p.procutils has it
1007 * buildbot/twcompat.py (implements): remove this method
1008 * buildbot/*: import implements() from zope.interface directly
1010 * buildbot/status/mail.py: stop falling back to importing
1011 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1014 * buildbot/twcompat.py (Interface): remove this import
1015 * buildbot/*: import Interface from zope.interface directly
1017 * buildbot/twcompat.py (providedBy): remove this method
1018 * buildbot/*: turn all uses of providedBy(obj, iface) into
1019 iface.providedBy(obj)
1021 * buildbot/twcompat.py (maybeWait): remove this method, now that
1022 we no longer maintain compatibility with Twisted<=1.3.0 .
1023 Twisted-2.0.0 and later allow trial methods to return Deferreds
1025 * buildbot/test/*: remove all uses of maybeWait
1027 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1029 * docs/buildbot.texinfo: same
1031 2006-12-10 Brian Warner <warner@lothar.com>
1033 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1034 * docs/buildbot.texinfo: set version to match
1036 2006-12-10 Brian Warner <warner@lothar.com>
1038 * README (REQUIREMENTS): update for release
1039 * NEWS: update for release
1040 * buildbot/slave/commands.py (command_version): mention that this
1041 version (2.2) was released with buildbot-0.7.5
1043 * buildbot/test/test_config.py (StartService.testStartService):
1044 inhibit the usual read-config-on-startup behavior, since otherwise
1045 the log.err that gets recorded causes the test to fail
1047 * buildbot/status/builder.py (LogFile.finish): forget about all
1048 subscribers once the log has finished, since after that point
1049 we're never going to use them again. This might help free up some
1052 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1053 than the old/deprecated gtk.mainquit()
1055 2006-12-09 Brian Warner <warner@lothar.com>
1057 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1058 better when we can't open the masterdst file
1060 * buildbot/scripts/startup.py (Follower._failure): add missing
1061 import statement for BuildSlaveDetectedError
1063 * buildbot/steps/transfer.py (FileUpload): cleanup
1064 (FileDownload): same. Add tests for slave version, add mode=.
1065 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1066 (SlaveFileDownloadCommand): same
1067 * buildbot/test/test_transfer.py: enhance tests
1068 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1071 2006-12-08 Brian Warner <warner@lothar.com>
1073 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1074 both success *and* failure. Without this, the 'buildbot
1075 sendchange' command would hang if it could not contact the
1076 buildmaster or deliver the Change, which would generally cause the
1077 user's commit/record/checkin command to hang too. Thanks to
1078 Christian Unger for the catch.
1080 2006-12-06 Brian Warner <warner@lothar.com>
1082 * NEWS: update with items for the next release
1084 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1085 whimsical example pulled from a punch-drunk email I sent out late
1087 (Transferring Files): document some of the other parameters
1088 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1089 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1090 * buildbot/test/test_svnpoller.py: same
1091 * buildbot/changes/svnpoller.py (SVNPoller): same
1093 2006-11-26 Brian Warner <warner@lothar.com>
1095 * docs/buildbot.texinfo (Build Properties): remind users that
1096 WithProperties must appear in a command= list, not as a top-level
1098 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1099 we're sending a list or a single string to the RemoteShellCommand
1101 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1103 * buildbot/scripts/startup.py (start): skip the whole
1104 watch-the-logfile thing under windows, since it needs os.fork()
1106 * buildbot/scripts/runner.py (restart): remove the old message
1107 that got printed after the buildbot was restarted.. it most cases
1108 it didn't get printed at the right time anyways
1110 2006-11-25 Brian Warner <warner@lothar.com>
1112 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1113 follow twistd.log and print lines until the process has started
1114 started properly. For the buildmaster, this means until the config
1115 file has been parsed and accepted. For the buildslave, this means
1116 until we've connected to the master. We give up after 5 seconds in
1117 any case. Helpful error messages and troubleshooting suggestions
1118 are printed when we don't see a successful startup. This closes the
1119 remainder of SF#1517975.
1120 * buildbot/scripts/startup.py: moved app startup code to here
1121 * buildbot/scripts/logwatcher.py: utility class to follow log
1122 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1123 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1124 so the LogWatcher can tell the difference between a buildmaster
1127 2006-11-24 Brian Warner <warner@lothar.com>
1129 * docs/examples/twisted_master.cfg: update to match the version
1130 in use on twistedmatrix.com
1131 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1132 was using before stopped working, but 'irc.freenode.net' works
1135 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1138 * buildbot/clients/base.py (TextClient.not_connected): upon
1139 UnauthorizedLogin failures, remind the user to connect to the
1140 PBListener port instead of the slaveport.
1141 (TextClient.disconnected): shut down more quietly
1142 * docs/buildbot.texinfo (statuslog): add another reminder
1144 * buildbot/scripts/runner.py (Options.subCommands): rename
1145 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1146 'sighup' as an alias.
1147 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1148 reconfig command to follow twistd.log and print all of the lines
1149 from the start of the config-file reload to its completion. This
1150 should make it a lot easier to discover bugs in the config file.
1151 Use --quiet to disable this behavior. This addresses half of
1152 SF#1517975, the other half will be to add this same utility to
1153 'buildbot start' and 'buildbot restart'.
1154 * docs/buildbot.texinfo (Loading the Config File): same
1157 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1158 method, it has been deprecated for a long time. Use
1159 IBuilderControl.requestBuild instead.
1160 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1161 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1162 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1163 * buildbot/test/test_control.py (Force.testForce): same
1164 * buildbot/test/test_run.py: use requestBuild instead
1166 * buildbot/clients/debug.py: replace 'Force Build' button with
1167 'Request Build' (which just adds one to the queue), add Ping
1168 Builder, add branch/revision fields to Request Build.
1169 * buildbot/clients/debug.glade: same
1170 * buildbot/master.py: update interface to match. This creates an
1171 incompatibility between new debugclients and old buildmasters.
1173 * buildbot/process/builder.py (Builder._attached): delay the call
1174 to maybeStartBuild for a reactor turn, to avoid starting a build
1175 in the middle of a reconfig (say, if the new Builder uses a new
1176 slave which is already connected).
1178 2006-11-23 Brian Warner <warner@lothar.com>
1180 * buildbot/test/test_transfer.py: appease pyflakes
1181 * buildbot/test/test_steps.py: same
1183 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1184 keeps pyflakes from finding undefined names
1186 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1187 Builder no longer induces a disconnect/reconnect cycle. This means
1188 that any builds currently in progress will not be interrupted, and
1189 any builds which are queued in the Builder will not be lost. This
1190 is implemented by having the new Builder extract the state (i.e.
1191 all pending Builds and any desired SlaveBuilders) from the old
1193 (BotPerspective): refactor. The BotPerspective no longer keeps
1194 track of all the Builders that want to use this slave; instead, it
1195 asks the BotMaster each time it needs this list. This removes
1196 addBuilder and removeBuilder. Clean up attached() to acquire all
1197 the slave's information in a more atomic fashion. updateSlave() is
1198 now the way to make sure the slave is using the right set of
1199 Builders: just call it after everything else has been
1201 (BotMaster): refactor, removing addBuilder/removeBuilder and
1202 replacing them with an all-at-once setBuilders() call.
1204 * buildbot/test/test_slaves.py (Reconfig): new test case to
1205 exercise this functionality
1206 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1207 * buildbot/slave/commands.py (WaitCommand): same
1209 * docs/buildbot.texinfo (Loading the Config File): document the
1212 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1213 SlaveBuilder to have its parent Builder changed.
1214 (SlaveBuilder.isAvailable): new method to give access to state,
1215 which is now a private attribute
1216 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1217 the SlaveBuilder about how it is being used. These methods update
1218 its internal state. buildFinished() is now the place that invokes
1219 maybeStartBuild() on its parent Builder.
1220 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1221 new Builder to take over for an old one, transferring state from
1223 (Buider): refactor the way that SlaveBuilders are used to match,
1224 giving them a bit more autonomy.
1225 (Builder.buildFinished): this no longer calls maybeStartBuild():
1226 instead the SlaveBuilder calls it on whoever its parent Builder is
1227 at the time. This way, when an old Builder is replaced by a new
1228 one, and there was a build in progress during the transition, when
1229 that build finishes, it will be the new Builder that is told about
1230 the newly available slave so it can start a new build.
1232 * buildbot/process/base.py (Build.startBuild._release_slave): when
1233 the Build finishes, tell the SlaveBuilder that they've been
1236 * buildbot/status/builder.py (SlaveStatus): add some new setter
1237 methods for use by BotPerspective, to keep some attributes more
1240 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1241 called by the buildmaster.
1242 (Bot.setBuilderList): instead, we locally announce any leftover
1243 directories based upon which Builders we were told about. The
1244 master doesn't really care; it's the local admin who may or may not
1245 wish to delete them.
1248 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1249 to allow use of python2.4 or whatever. This tool still requires
1252 2006-11-19 Brian Warner <warner@lothar.com>
1254 * NEWS (IStatusLog.readlines): more news items
1256 2006-11-18 Brian Warner <warner@lothar.com>
1258 * NEWS: start collecting items for the next release.
1260 2006-11-04 Brian Warner <warner@lothar.com>
1262 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1263 Hearsum. Closes SF#1590310.
1264 * buildbot/test/test_bonsaipoller.py: and tests
1266 * buildbot/status/tinderbox.py
1267 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1268 status when the build results in WARNINGS. Patch from Dave
1269 Liebreich. Closes SF#1587352.
1271 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1272 linux-vs-osx behavior difference w.r.t. reading from files that
1273 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1274 to Mark Rowe for the patch.
1276 2006-10-15 Brian Warner <warner@lothar.com>
1278 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1279 method name was misspelled in the interface definition. Thanks to
1280 Roy Rapoport for the catch.
1282 2006-10-13 Brian Warner <warner@lothar.com>
1284 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1285 to match the great Steps renaming
1287 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1288 Maybe I should run my own unit tests before recording a big
1289 change. Good thing I've got a buildbot to remind me.
1291 2006-10-12 Brian Warner <warner@lothar.com>
1293 * buildbot/steps/transfer.py: rework __init__ and args setup
1294 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1296 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1297 when opening the target file, only catch IOError (to report via
1298 stderr/rc!=0), let the others be reported as normal exceptions
1300 2006-10-08 Brian Warner <warner@lothar.com>
1302 * contrib/svn_watcher.py: fix security holes by using proper argv
1303 arrays and subprocess.Popen() rather than commands.getoutput().
1304 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1305 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1306 probably be removed by the next release.
1309 2006-10-04 Brian Warner <warner@lothar.com>
1311 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1312 initial lines that weren't emitted by pyflakes. When the pyflakes
1313 command is run under a Makefile, 'make' will echo the command it
1314 runs to stdio, and that was getting logged as a "misc" warning.
1315 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1316 * buildbot/test/test_steps.py (testPyFlakes3): another test
1318 2006-10-01 Brian Warner <warner@lothar.com>
1320 * buildbot/status/html.py (HtmlResource.render): if we get a
1321 unicode object from our content() method, encode it into utf-8
1322 like we've been claiming to all along. This allows the comments
1323 and author names from svnpoller.py to be delivered properly.
1325 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1326 de-unicodify filenames before creating the Change, because the
1327 rest of buildbot is unlikely to handle them well. Leave the 'who'
1328 field as a unicode object.. I don't think there's anything that
1329 will break very soon, and it will probably nudge us towards
1330 accepting unicode everywhere sooner or later. Stop using the
1331 "date" field that comes out of SVN, since it is using the
1332 repository's clock (and timezone) and what we care about is the
1333 buildmaster's (otherwise Changes from the future show up later
1334 than the builds they triggered).
1335 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1338 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1339 Suvbersion repository polling ChangeSource. I've hacked it up
1340 considerably: any bugs are entirely my own fault. Thank you
1342 * buildbot/test/test_svnpoller.py: tests for it
1343 * docs/buildbot.texinfo (SvnSource): document it
1345 2006-09-30 Brian Warner <warner@lothar.com>
1347 * buildbot/scheduler.py (Periodic): submit a reason= to the
1348 BuildSet to indicate which Scheduler triggered the build. Thanks
1349 to Mateusz Loskot for the suggestion.
1351 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1353 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1354 changes: set self.loop in __init__, remove unused volatile=
1356 * docs/buildbot.texinfo (.buildbot config directory): add more
1357 docs on the .buildbot/options keys used by "buildbot try"
1358 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1359 (Try.deliverJob): same
1361 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1363 (BonsaiPoller): same
1365 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1366 close the filehandle when we stop watching the file. Before, the
1367 filehandle was only closed when the LogFileWatcher was
1368 garbage-collected, which could be quite a while in the future. If
1369 it was still open by the time the next build started, windows will
1370 refuse to let the new build delete the old build/ directory. Fixes
1371 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1372 #twisted for the catch.
1374 2006-09-29 Brian Warner <warner@lothar.com>
1376 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1379 2006-09-25 Brian Warner <warner@lothar.com>
1381 * setup.py: the new buildbot.steps module wasn't being installed.
1382 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1383 (testmsgs): add the extra stuff from buildbot/test/* so you can
1384 run unit tests on an installed copy of buildbot, not just from
1387 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1388 columns of 'svnlook changed' output contain status information, so
1389 strip [:4] instead of [:6]. Depending upon what the status flags
1390 were, this would sometimes lead to mangled filenames. Thanks to
1391 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1393 * buildbot/steps/source.py (Monotone): initial Monotone support,
1394 contributed by Nathaniel Smith. Still needs docs and tests, but
1395 this code has been in use on the Monotone buildbot for a long
1397 * buildbot/slave/commands.py (Monotone): slave-side support
1398 * buildbot/changes/monotone.py (MonotoneSource): polling change
1401 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1402 contributed a Change Source that polls a Bonsai server (a
1403 kind of web-based viewcvs CGI script).
1405 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1406 Hearsum contributed a status plugin which sends email in the same
1407 format that Tinderbox does: this allows a number of tinderbox
1408 tools to be driven by Buildbot instead. Thanks Ben!
1410 2006-09-24 Brian Warner <warner@lothar.com>
1412 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1413 Thanks to Robert Helmer for the patch.
1415 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1416 BuildStatus about the buildslave name at the *beginning* of the
1417 build, rather than at the end. Thanks to Alexander Lorenz for the
1419 * buildbot/status/html.py (StatusResourceBuild.body): always
1420 include the slavename in the build page, not just when the build
1422 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1423 slavename in the email message
1425 2006-09-21 Brian Warner <warner@lothar.com>
1427 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1429 * docs/examples/glib_master.cfg: same
1430 * docs/examples/hello.cfg: same
1431 * docs/examples/twisted_master.cfg: same, update to current usage
1433 2006-09-19 Brian Warner <warner@lothar.com>
1435 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1436 (PyFlakes.createSummary): make it compatible with python-2.2
1438 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1439 for at least the output-parsing parts of PyFlakes
1441 2006-09-18 Brian Warner <warner@lothar.com>
1443 * buildbot/steps/python.py: oops, fix import of StringIO
1445 2006-09-17 Brian Warner <warner@lothar.com>
1447 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1448 turns out that SVN-1.4.0 doesn't fail to update once you've
1449 replaced a file with a directory, unlike older versions of SVN and
1450 pretty much every other VC tool we support. Since what we really
1451 care about is that the update succeeds anyway, stop checking that
1452 the tree got clobbered and just assert that the build succeeded.
1453 (VCBase.printLogs): add a utility function for debugging
1455 * buildbot/process/step.py: oops, added extra imports by mistake
1457 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1458 rstrip() on the first line coming out of the 'p4 describe'
1459 process, to remove the stray ^M that Wade Brainerd reports seeing
1460 in the 'when' field. Fixes SF#1555985.
1462 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1463 message logged when c['schedulers'] is not right
1464 * buildbot/scheduler.py (Scheduler.__init__): improve error
1465 message when a Scheduler() is created with the wrong arguments
1466 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1467 verify that these error messages are emitted
1469 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1470 The idea is that all the base classes (like BuildStep and
1471 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1472 will be a leftover backwards-compatibility file that only contains
1473 aliases for the steps that were moved out to buildbot.steps.*
1474 * lots: change imports to match
1475 * buildbot/process/step.py: add a DeprecationWarning if it ever
1478 2006-09-12 Brian Warner <warner@lothar.com>
1480 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1481 builderNames= is actually a sequence, since if you happen to give
1482 it a single builder-specification dictionary instead, it won't get
1483 caught by the existing assert. Thanks to Brett Neely for the
1486 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1488 * docs/buildbot.texinfo (Python BuildSteps): document them
1489 (sendchange): include a link to PBChangeSource, since you need one
1491 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1493 * buildbot/steps/dummy.py: same
1495 2006-09-08 Brian Warner <warner@lothar.com>
1497 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1498 BuildStep which lets you transfer files from the master to the
1499 slave or vice versa. Thanks to Albert Hofkamp for the original
1500 patch. Fixes SF#1504631.
1501 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1503 (SlaveFileDownloadCommand): same
1504 * docs/buildbot.texinfo (Transferring Files): document it
1505 * buildbot/test/test_transfer.py: test it
1506 * buildbot/test/runutils.py (StepTester): new utility class for
1507 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1508 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1511 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1512 walk through StatusLogs one line at a time, mostly for the benefit
1513 of ShellCommand.createSummary methods. You can either walk through
1514 STDOUT or STDERR, but the default is STDOUT.
1516 * buildbot/status/builder.py (LogFile.readlines): implement it.
1517 Note that this is not yet memory-efficient, it just pulls the
1518 whole file into RAM and then splits it up with a StringIO.
1519 Eventually this should be a generator that only pulls chunks from
1521 * buildbot/test/test_status.py (Log.testReadlines): test it
1523 * docs/buildbot.texinfo: update to match changes
1524 * buildbot/process/factory.py: stop using old definitions
1525 * buildbot/process/process_twisted.py: same
1526 * buildbot/test/test_*.py: same
1528 * buildbot/process/step_twisted.py: move definition to..
1529 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1530 relative-import mechanisms prevent this from being named 'twisted'
1531 or 'python/twisted' as I would have preferred.
1533 * buildbot/process/maxq.py: move definition to..
1534 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1536 * buildbot/process/step.py: split the user-visible BuildSteps into
1537 separate files, all under buildbot/steps/
1538 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1539 * buildbot/steps/shell.py: this holds ShellCommand and friends
1540 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1542 2006-09-05 Brian Warner <warner@lothar.com>
1544 * lots: run pyflakes, removed a lot of unused imports, changed the
1545 form of some conditional imports to remove false pyflakes
1546 warnings. There are still a number of warnings left, mostly from
1547 imports that are done for their side-effects.
1548 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1551 2006-08-26 Brian Warner <warner@lothar.com>
1553 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1554 compatible with twisted-1.3.0, for some reason I just can't seem
1555 to let go of the past.
1557 2006-08-25 Brian Warner <warner@lothar.com>
1559 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1561 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1562 all logfiles= in startCommand(), rather than in start() . This
1563 makes it easier to have the 'stdio' log come before any secondary
1564 logfiles, which I feel makes the waterfall display more
1566 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1567 from ShellCommand up into LoggingBuildStep
1568 (LoggingBuildStep.__init__): move the handling of logfiles= from
1569 ShellCommand up to LoggingBuildStep, because startCommand is
1570 provided by LoggingBuildStep, whereas start() was specific to
1571 subclasses like ShellCommand and Source. This removes code
1572 duplication in those subclasses.
1573 (ShellCommand.__init__): same
1574 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1575 for a slave that's too old to understand logfiles= into a separate
1576 method, so it can live in ShellCommand. The rest of
1577 setupLogfiles() can live in LoggingBuildStep.
1579 2006-08-24 Brian Warner <warner@lothar.com>
1581 * buildbot/locks.py (BaseLock): you can now configure Locks to
1582 allow multiple simultaneous owners. They still default to
1583 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1585 * docs/buildbot.texinfo (Interlocks): document the new options
1586 * buildbot/test/test_locks.py: add a bunch of new unit tests
1587 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1588 waitUntilMaybeAvailable, not waitUntilAvailable
1589 * buildbot/process/step.py (BuildStep.acquireLocks): same
1590 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1591 the whole lockid in their constructor, not just the name. Also,
1592 keep track of which real locks we've handed out by the full
1593 lockid, not just class+name, otherwise changing just the maxCount=
1594 in the master.cfg file would not actually cause a behavioral
1597 2006-08-23 Brian Warner <warner@lothar.com>
1599 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1601 * docs/buildbot.texinfo: same
1603 2006-08-23 Brian Warner <warner@lothar.com>
1605 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1606 * docs/buildbot.texinfo: set version to match
1607 * NEWS: update for 0.7.4
1608 * buildbot/slave/commands.py (command_version): mention that this
1609 version (2.1) was released with buildbot-0.7.4
1611 2006-08-22 Brian Warner <warner@lothar.com>
1615 * CREDITS: new file, list of people who have helped. Thanks!
1616 * MANIFEST.in: ship it
1618 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1619 new diagrams, the user's manual is more informative than it was.
1620 Start shipping the .html user's manual (and generated .png
1622 * Makefile: update 'release' target to match
1624 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1625 test.. I think the web-parts effort will render it pointless well
1626 before it ever actually starts to work.
1628 2006-08-20 Brian Warner <warner@lothar.com>
1630 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1631 meaning of the prefix= argument. It is now just a string which is
1632 stripped from the beginning of the filename. If prefix= is set but
1633 not found on any given filename, that filename is ignored. If all
1634 filenames in a Change are ignored, the Change is dropped. This is
1635 much simpler than the previous sep= nonsense, and I should have
1636 implemented it this way from the beginning. Effectively resolves
1637 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1638 Gedminas for the catch and suggested fixes.
1639 (ChangePerspective.perspective_addChange): implement the actual
1641 * buildbot/test/test_changes.py (TestChangePerspective): test it
1642 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1643 how to properly use prefix=
1644 * docs/examples/twisted_master.cfg (source): update prefix= by
1645 adding the trailing slash
1648 * docs/examples/twisted_master.cfg: update to actual practice
1650 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1651 update test case to match new link text.. the HREF has both a
1652 class= setting and an enclosing [] pair that I didn't match in the
1655 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1656 list of strings is preferred over a single string with embedded
1658 (ShellCommand.description=): explain that either single strings or
1659 a list of strings is acceptable, and why you might prefer one over
1660 the other. Add an example. Fixes SF#1524659, thanks to Paul
1661 Winkler for the catch.
1662 (Build Steps): update to use f.addStep() rather than using s()
1663 and the constructor list
1665 * buildbot/process/step.py (ShellCommand): accept either a single
1666 string or a list of strings in both description= and
1668 * buildbot/test/test_steps.py (Steps.test_description): test it
1669 * buildbot/test/runutils.py (makeBuildStep): support for that test
1671 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1672 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1673 collecting the files and creating the patch.
1675 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1676 per-step URLs that will be displayed on the waterfall display,
1677 for things like the HTML output of code-coverage tools, when
1678 the results are hosted elsewhere.
1679 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1680 way to retrieve these URLs
1681 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1682 the method to retrieve these URLs. Also provide backwards
1683 compatibility for saved BuildStepStatus instances that didn't have
1685 * buildbot/process/step.py (BuildStep.addURL): method to set these
1686 URLs from within a BuildStep
1687 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1688 (StepBox.getBox): give these external links a distinct CSS class
1689 named "BuildStep external" so a .css file can display them
1692 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1694 * buildbot/test/test_steps.py (Steps): test that we can all the
1695 URLs. Also add a bunch of other tests on methods that can be
1696 called from within BuildSteps
1697 * buildbot/test/runutils.py (makeBuildStep): add utility function
1699 2006-08-13 Brian Warner <warner@lothar.com>
1701 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1703 2006-08-10 Brian Warner <warner@lothar.com>
1705 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1706 index, this one of things like c['sources'] and c['schedulers']
1707 (indices): it looks like my clever idea of putting the @fooindex
1708 commands in between the @node and the @subsection (to make the
1709 HREF anchor jump to slightly above the section title, which works
1710 much better in html) confused texinfo horribly, so I'm moving the
1711 index tags back to be just after the @subsection marker. I also
1712 added extra lines between the @node/@section paragraph and the
1713 index tags, since I think maybe texinfo wants to see these be
1714 separate paragraphs.
1716 * docs/Makefile (images): make sure images get built when
1717 rendering the manual
1718 * docs/images/Makefile: same
1720 * buildbot/scripts/runner.py: rename 'buildbot master' to
1721 'buildbot create-master', and 'buildbot slave' to 'buildbot
1723 * docs/buildbot.texinfo: same
1726 * docs/buildbot.texinfo: reimplement the "useful classes" index
1727 with actual texinfo indices. The .info rendering is a bit
1728 weird-looking but it works well, and the HTML rendering is quite
1729 nice. This also puts the index targets in the regular flow of the
1730 text, which is easier to maintain.
1732 2006-08-06 Brian Warner <warner@lothar.com>
1734 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1735 Kevin Turner to prefer the environ= argument be a list rather than
1736 a string. If it is a list, it will be joined with a platform-local
1737 os.pathsep delimiter, and then prepended to any existing
1738 $PYTHONPATH value. This works better in cross-platform (i.e.
1739 windows buildslaves) environments when you need to push multiple
1740 directories onto the front of the path.
1741 (SlaveShellCommand): documented the new magic
1742 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1743 in a user-visible form
1745 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1746 Turner to prefer lists over strings when creating/running VC
1747 commands during unit tests. This is clearly necessary to survive
1748 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1749 renamed the wq() function to qw() though, since that's how it's
1750 spelled in perl. Eventually I'd prefer all commands to be
1751 specified with lists.
1753 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1754 which are deleted (or not yet created) correctly. Also add
1755 failsafe code to not explode if the file-watching poller doesn't
1756 get started. Thanks to JP Calderone for the catch and the poller
1758 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1760 * buildbot/test/emitlogs.py: same
1762 * NEWS: summarize recent changes
1764 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1765 clause to avoid the "host key mismatch" warning
1767 * buildbot/process/step_twisted.py (Trial.start): if the
1768 buildslave is too old to understand logfiles=, fall back to
1769 running 'cat _trial_temp/test.log' like before.
1770 (Trial.commandComplete): same. this takes advantage of the
1771 LoggingBuildStep refactoring to stall commandComplete long enough
1772 to run a second RemoteShellCommand.
1774 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1775 refactor command-completion handling, to allow methods like
1776 commandComplete/createSummary/evaluateCommand to return Deferreds.
1777 (LoggingBuildStep._commandComplete): delete the refactored method
1778 (ShellCommand.setupLogfiles): if the buildslave is too old to
1779 understand logfiles=, put a warning message both into twistd.log
1780 and into the otherwise empty user-visible LogFiles.
1782 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1783 callers to provide the slave-side logfile name, rather than
1784 forcing it to come from the local name of the LogFile.
1785 (BuildStep.getSlaveName): new method
1787 * buildbot/process/base.py (Build.getSlaveName): new method, so
1788 steps can find out which buildslave they're running on
1790 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1791 to match the s/cvs_ver/command_version/ change
1793 2006-08-05 Brian Warner <warner@lothar.com>
1795 * buildbot/slave/commands.py (command_version): replace the CVS
1796 auto-updated cvs_ver keyword with a manually-updated variable,
1797 since CVS is no longer the master repository. Add a description of
1798 the remote API change starting in this version (2.1), specifically
1799 the fact that SlaveShellCommand now accepts 'initial_stdin',
1800 'keep_stdin_open', and 'logfiles'.
1802 2006-07-31 Brian Warner <warner@lothar.com>
1804 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1805 diagrams to describe how the whole system fits together. The
1806 images themselves are kept in SVG files, with ascii-art versions
1807 in corresponding .txt files. Texinfo knows how to interpolate the
1808 text version into .info files, reference the .png versions from
1809 .html files, and include .eps versions in the .ps format.
1810 * docs/images/Makefile: tools to create .png and .eps
1811 * docs/images/*.svg: created pictures with Inkscape.
1812 * .darcs-boring: ignore the generated .eps and .png files
1814 2006-07-24 Brian Warner <warner@lothar.com>
1816 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1817 Scheduler names, since they cause setServiceParent to explode
1819 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1821 2006-07-20 Brian Warner <warner@lothar.com>
1823 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1824 which runs the buildbot unit tests
1826 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1827 classes that are useful in master.cfg
1829 2006-07-15 Brian Warner <warner@lothar.com>
1831 * Makefile (some-apidocs): new target to build only some epydocs
1833 * setup.py: minor comment.. does the classifiers= argument prevent
1834 the setup.py script from working on python2.2/2.3?
1836 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1839 * buildbot/twcompat.py: fix minor typo in comments
1841 * buildbot/manhole.py: move all Manhole-related code out to this
1842 module. Implement SSH-based manholes (with TwistedConch), and move
1843 to conch's nifty line-editing syntax-coloring REPL shell instead
1844 of the boring non-editing monochromatic (and deprecated) old
1846 * buildbot/master.py: remove all Manhole-related code
1847 (BuildMaster.loadConfig._add): make sure the old manhole is
1848 removed before we add the new one
1849 * docs/buildbot.texinfo (Debug options): document new Manhole options
1851 * buildbot/twcompat.py (_which): fix some epydoc issues
1852 * buildbot/status/html.py (Waterfall.__init__): same
1854 2006-06-29 Brian Warner <warner@lothar.com>
1856 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1857 deprecation warnings under newer Twisteds (by using
1858 zope.interface.Interface instead of old twisted.python.components
1860 * buildbot/slave/interfaces.py: same
1862 2006-06-28 Brian Warner <warner@lothar.com>
1864 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1865 svn commands, so it will fail immediately instead of hanging while
1866 it waits for a username/password to be typed in.
1868 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1869 log message if the step was shut down
1871 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1872 obsolete reference to mktap.
1874 2006-06-20 Brian Warner <warner@lothar.com>
1876 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1877 test to include new 'logfiles' argument sent from master to slave
1879 2006-06-19 Brian Warner <warner@lothar.com>
1881 * buildbot/process/step_twisted.py (Trial): track Progress from
1882 _trial_temp/test.log too
1884 * buildbot/process/step.py (OutputProgressObserver): generalize
1885 the earlier StdioProgressObserver into an OutputProgressObserver
1886 that can track LogFiles other than stdio.
1887 (LoggingBuildStep.__init__): same
1889 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1890 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1891 will fail under windows because of os.sep issues. It might have
1892 worked before if 'cat' was doing cygwin path conversion.
1894 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1895 creation of LogFileWatchers
1896 (ShellCommand._startCommand): and record the files that were
1897 watched in the 'headers' section of the ShellCommand output
1899 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1900 need to actually pass it to the slave if you want it to work.
1901 (ShellCommand): document it a bit
1903 * buildbot/test/test_shell.py: new test to validate LogFiles
1904 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1906 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1907 before printing the last batch of lines, to test that the polling
1908 logic is working properly
1910 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1911 handling, making it possible to track multiple logs for a single
1912 RemoteCommand. The previous single logfile is now known as the
1914 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1915 (RemoteShellCommand.__init__): accept logfiles=
1916 (LoggingBuildStep.startCommand): stdio_log is now one of many
1917 (ShellCommand): added logfiles= argument, as well as a class-level
1918 .logfiles attribute, which will be merged together to figure out
1919 which logfiles should be tracked. The latter maybe be useful for
1920 subclasses of ShellCommand which know they will aways produce
1921 secondary logfiles in the same location.
1923 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1924 and closeStdin() methods, preparing to make it possible to write
1925 to a ShellCommand's stdin at any time, not just at startup. These
1926 writes are buffered if the child process hasn't started yet.
1927 (LogFileWatcher): new helper class to watch arbitrary logfiles
1928 while a ShellCommand runs. This class polls the file every two
1929 seconds, and sends back 10k chunks to the buildmaster.
1930 (ShellCommand): rename stdin= to initialStdin=, and add
1931 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1933 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1934 key of "log" and a value of (logname, data).
1935 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1936 'logfiles' to the master-visible args dictionary.
1937 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1940 * buildbot/test/test_vc.py (Patch.testPatch): same
1943 * buildbot/test/emit.py: write to a logfile in the current
1944 directory. We use this to figure out what was used as a basedir
1945 rather than looking to see which copy of emit.py gets run, so that
1946 we can run the commands from inside _trial_temp rather than inside
1948 * buildbot/test/subdir/emit.py: same
1949 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1950 argument rather than running from buildbot/test/
1951 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1952 rather than using an implicit setUp()
1953 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1954 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1955 of assuming that we're running in buildbot/test/ (and that '.' is
1958 * buildbot/slave/commands.py (Command.doStart): refactor Command
1959 startup/completion a bit: now the SlaveBuilder calls doStart(),
1960 which is not meant for overridding by subclasses, and doStart()
1961 calls start(), which is. Likewise the SlaveBuilder calls
1962 doInterrupt(), and subclasses override interrupt(). This also puts
1963 responsibility for maintaining .running in Command rather than in
1965 (Command.doInterrupt): same
1966 (Command.commandComplete): same, this is called when the deferred
1967 returned by start() completes.
1968 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1969 (SlaveBuilder.remote_interruptCommand): same
1970 (SlaveBuilder.stopCommand): same
1972 2006-06-16 Brian Warner <warner@lothar.com>
1974 * buildbot/test/test_shell.py: new test file to contain everything
1975 relating to ShellCommand
1976 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1977 multiple logfiles in realtime" feature, not yet implemented
1978 * buildbot/test/emitlogs.py: support file for testLogFiles
1979 * docs/buildbot.texinfo (ShellCommand): document the feature
1981 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1983 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1984 for tests which exercise SlaveCommands in isolation.
1986 * buildbot/test/test_slavecommand.py: Move some utilities like
1987 SignalMixin and FakeSlaveBuilder from here ..
1988 * buildbot/test/runutils.py: .. to here, so they can be used by
1989 other test classes too
1990 * buildbot/test/test_vc.py: more SignalMixin refactoring
1991 * buildbot/test/test_control.py: same
1992 * buildbot/test/test_run.py: and some rmtree refactoring
1994 2006-06-15 Brian Warner <warner@lothar.com>
1996 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1997 'testBranch' to match other VC tests and have the tests run in
1998 roughly increasing order of dependency
2000 * buildbot/test/test_steps.py (LogObserver): new test to verify
2001 LogObservers can be created at various times and still get
2002 connected up properly
2004 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2005 to create BuildStepStatus instances that actually work.
2007 * buildbot/process/step.py (LogObserver): add outReceived and
2008 errReceived base methods, to be overridden
2010 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2011 API to take a name instead of a step, reducing the coupling
2012 somewhat. This returns the BuildStepStatus object so it can be
2013 passed to the new Step, instead of jamming it directly into the
2015 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2017 * buildbot/process/base.py (Build.setupBuild): use both methods
2018 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2019 process a bit to match
2021 2006-06-14 Brian Warner <warner@lothar.com>
2023 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2024 docs on writing new LogObserver classes
2025 (Writing New Status Plugins): brief docs on how Status Plugins fit
2028 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2029 implement a LogObserver that counts how many unit tests have been
2031 (Trial.__init__): wire it in
2032 * buildbot/test/test_twisted.py (Counter): unit test for it
2034 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2035 to new cmd.logs['stdio'] scheme
2036 (Trial.commandComplete): same
2037 (BuildDebs.commandComplete): same
2039 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2040 LogFiles, instead of just a single one. The old single logfile is
2041 now called "stdio". LoggedRemoteCommand no longer creates a
2042 LogFile for you (the code to do that was broken anyway). If you
2043 don't create a "stdio" LogFile, then stdout/stderr will be
2045 (LogObserver): implement "LogObservers", which a BuildStep can add
2046 to parse the output of a command in real-time. The primary use is
2047 to provide more useful information to the Progress code, allowing
2048 better ETA estimates.
2049 (LogLineObserver): utility subclass which feeds complete lines to
2050 the parser instead of bytes.
2051 (BuildStep.progressMetrics): this is safer as a tuple
2052 (BuildStep.setProgress): utility method, meant to be called by
2054 (BuildStep.addLogObserver): new method, to be called at any time
2055 during the BuildStep (even before any LogFiles have been created),
2056 to attach (or schedule for eventual attachment) a LogObserver to a
2058 (StdioProgressObserver): new LogObserver which replaces the old
2059 "output" progress gatherer
2060 (LoggingBuildStep.__init__): same
2061 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2062 (LoggingBuildStep._commandComplete): must use logs['stdio']
2063 instead of the old single ".log" attribute.
2064 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2065 functionality, now subsumed into StdioProgressObserver
2066 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2067 log name changed from "output" to "stdio".
2070 * buildbot/interfaces.py (ILogFile): add the Interface used from
2071 the BuildStep towards the LogFile
2072 (ILogObserver): and the one provided by a LogObserver
2073 * buildbot/status/builder.py (LogFile): implement it
2075 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2076 HEADER constants here ..
2077 * buildbot/status/builder.py (STDOUT): .. from here
2079 2006-06-13 Brian Warner <warner@lothar.com>
2081 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2082 compatibility with python2.2, which doesn't have the 'substr in
2084 (TestP4Poller.makeTime): utility function to construct the
2085 timestamp using the same strptime() approach as p4poller does. It
2086 turns out that time.mktime() behaves slightly differently under
2087 python2.2, probably something to do with the DST flag, and that
2088 causes the test to fail under python2.2. (changing the mktime()
2089 arguments to have dst=0 instead of -1 caused it to fail under
2090 python2.3. Go figure.)
2091 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2093 2006-06-12 Brian Warner <warner@lothar.com>
2095 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2096 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2097 contributing such an excellent patch, including docs and unit
2098 tests! This makes it *so* much easier to apply. I had to update
2099 test_vc.py to handle some recent refactorings, but everything else
2100 applied smoothly. The only remaining thing I'd like to fix would
2101 be to remove the hard-wired port 1666 used by p4d, and allow it to
2102 claim any unused port. This would allow two copies of the test
2103 suite to run on the same host at the same time, as well as
2104 allowing the test suite to run while a real (production) p4d was
2105 running on the same host. Oh, and maybe we should add a warning to
2106 step.P4 that gets emitted if the slave is too old to provide the
2107 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2108 * buildbot/slave/commands.py (P4): same
2109 (P4Sync): same, some minor updates
2110 * buildbot/changes/p4poller.py: same
2111 * docs/buildbot.texinfo: same
2112 * buildbot/test/test_p4poller.py: same
2113 * buildbot/test/test_vc.py (P4): same
2115 * setup.py: add Trove classifiers for PyPI
2117 2006-06-08 Brian Warner <warner@allmydata.com>
2119 * buildbot/status/client.py
2120 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2121 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2122 build needs to be IRemote'd separately, rather than IRemote'ing
2123 the whole list at once. I can't wait until newpb's serialization
2124 adapters make this unnecessary.
2126 2006-06-06 Brian Warner <warner@lothar.com>
2128 * buildbot/process/step.py (WithProperties): make this inherit
2129 from ComparableMixin, so that reloading an unchanged config file
2130 doesn't cause us to spuriously reload any Builders which use them.
2131 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2134 2006-06-03 Brian Warner <warner@lothar.com>
2136 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2137 running py2exe on windows, contributed by Mark Hammond. Addresses
2138 SF#1401121, but I think we still need to include
2139 buildbot/scripts/sample.cfg
2140 * setup.py: include buildbot_service.py as a script under windows
2141 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2142 a py2exe application), get the icon/css datafiles from a different
2145 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2146 double-escape the build URL. Thanks to Olivier Bonnet for the
2147 patch. Fixes SF#1452801.
2149 2006-06-02 Brian Warner <warner@lothar.com>
2151 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2152 first six columns of 'svnlook' output, not just the first column,
2153 since property changes appear in the other five. Thanks to Olivier
2154 Bonnet for the patch. Fixes SF#1398174.
2156 2006-06-01 Brian Warner <warner@lothar.com>
2158 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2159 the fake build, so that title= has something to be set to
2161 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2162 attribute of the "Build #NN" link in the yellow start-the-build
2163 box to the build's reason. This means that you get a little
2164 tooltip explaining why the build was done when you hover over the
2165 yellow box. Thanks to Zandr Milewski for the suggestion.
2167 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2168 (Box.setETA): handle ETA=None (by stopping the timer)
2169 (Box.update): make the [soon] text less different than the usual
2170 text, so the rest of the text doesn't flop around so much. It
2171 would be awfully nice to figure out how to center this stuff.
2172 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2174 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2175 by default, so that any ShellCommand which fails marks the overall
2176 build as a failure. I should have done this from the beginning.
2177 Add flunkOnFailure=False to the arguments if you want to turn off
2180 2006-05-30 Brian Warner <warner@lothar.com>
2182 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2183 last-build/current-build/current-step. Show what step is currently
2184 running. Show ETA for both the overall build and the current step.
2185 Update GTK calls to modern non-deprecated forms. There's still a
2186 lot of dead code and debug noise to remove.
2188 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2189 shows up properly in status displays
2191 2006-05-28 Brian Warner <warner@lothar.com>
2193 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2194 build we use to verify that WithProperties works:
2196 ** set flunkOnFailure=True so that build failures get noticed
2197 ** set workdir='.' so that the build succeeds, otherwise it is trying
2198 to touch 'build/something', and 'build/' doesn't exist because
2199 usually that's created by a Source step
2200 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2201 this test somehow triggers, in which the 'touch' process becomes
2202 a zombie and we wait for th etimeout before giving up on it.
2204 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2205 to log the Build results and step logs to the twisted log.
2206 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2207 what went wrong if a build was expected to succeed but didn't.
2209 * buildbot/process/step_twisted.py (Trial): set the default
2210 trialMode to '--reporter=bwverbose', which specifies verbose
2211 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2212 '-to', but those are completely missing in modern Twisteds.
2214 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2215 a localhost-only port, to encourage better security
2217 * docs/buildbot.texinfo (Change Sources): mention
2220 * .darcs-boring: add a Darcs boringfile
2222 * README (REQUIREMENTS): stop claiming compatibility with
2225 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2228 2006-05-27 Brian Warner <warner@lothar.com>
2230 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2231 * docs/buildbot.texinfo: same
2233 2006-05-23 Brian Warner <warner@lothar.com>
2235 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2236 * docs/buildbot.texinfo: set version to match
2237 * NEWS: update for 0.7.3
2239 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2240 give a quick mapping from VC system to possible ChangeSources
2241 (Build Properties): add 'buildername'
2243 * buildbot/process/base.py (Build.setupStatus): oops, set
2244 'buildername' and 'buildnumber' properties
2245 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2248 2006-05-22 Brian Warner <warner@lothar.com>
2250 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2251 property interpolation better
2253 * README (INSTALLATION): remove old '-v' argument from recommended
2256 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2257 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2260 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2261 'svnversion' instead of grepping the output of 'svn info', much
2262 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2263 Bonnet for the suggestion.
2264 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2265 require the WC_PATH argument, so run 'svnversion .' instead.
2267 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2268 aren't supposed to have 'self' in their argument list
2270 2006-05-21 Brian Warner <warner@lothar.com>
2272 * buildbot/process/step.py (ShellCommand.start): make
2273 testInterpolate pass. I was passing the uninterpolated command to
2274 the RemoteShellCommand constructor
2275 (ShellCommand._interpolateProperties): oops, handle non-list
2276 commands (i.e. strings with multiple words separated by spaces in
2277 them) properly, instead of forgetting about them.
2279 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2280 to actually try to use build properties in a real build. This test
2282 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2283 to start and evaluate builds
2285 * buildbot/test/test__versions.py: add a pseudo-test to record
2286 what version of Twisted/Python/Buildbot are running. This should
2287 show up at the beginning of _trial_tmp/test.log, and exists to help
2288 debug other problems.
2290 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2291 a filename to be served as 'robots.txt' to discourage web spiders.
2292 Adapted from a patch by Tobi Vollebregt, thanks!
2293 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2294 (Waterfall.test_waterfall): tweak the way that filenames are put
2295 into the config file, to accomodate windows pathnames better.
2297 * docs/buildbot.texinfo (HTML Waterfall): document it
2299 * buildbot/process/process_twisted.py
2300 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2301 changed the build process. The new setup.py no longer takes the
2303 (FullTwistedBuildFactory.__init__): same
2304 (TwistedReactorsBuildFactory.__init__): same
2306 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2307 be placed in the [hooks] section of the central repository (the
2308 one that everybody pushes changes to).
2310 2006-05-20 Brian Warner <warner@lothar.com>
2312 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2313 .darcs-context file, use binary mode. I think this was causing a
2314 Darcs failure under windows.
2316 2006-05-19 Brian Warner <warner@lothar.com>
2318 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2319 use a timezone string of +0000 and gmtime, since this timestamp is
2320 sent to a buildmaster and %z is broken.
2322 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2323 string and localtime, since this timestamp will only be consumed
2324 locally, and %z is broken.
2326 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2327 gmtime, since this timestamp is returned to the buildmaster, and
2330 2006-05-18 Brian Warner <warner@lothar.com>
2332 * NEWS: update in preparation for next release
2334 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2335 setup-repository and do-we-have-the-vc-tools code into a separate
2336 "helper" class, which sticks around in a single module-level
2337 object. This seems more likely to continue to work in the future
2338 than having it hide in the TestCase and hope that TestCases stick
2339 around for a long time.
2341 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2342 addremove' has been deprecated in recent versions of mercurial, so
2343 use 'hg add' instead
2345 2006-05-07 Brian Warner <warner@lothar.com>
2347 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2348 operating under windows, move the file before opening it, since
2349 you can't rename a file that somebody has open.
2351 * buildbot/process/base.py (Build.setupBuild): if something goes
2352 wrong while creating a Step, log the name and arguments, since the
2353 error message when you get the number of arguments wrong is really
2356 2006-05-06 Brian Warner <warner@lothar.com>
2358 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2359 bugs in twisted-specific code not covered by my unit tests, this
2360 time use 'cmd' argument instead of self.cmd
2362 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2363 fix stupid braino: either use startwith or find()==0, not both.
2364 (TwistedReactorsBuildFactory.__init__): another dumb typo
2366 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2367 mark this test as TODO under windows, since process-killing seems
2368 dodgy there. We'll come back to this later and try to fix it
2371 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2372 and don't include a timezone
2373 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2374 This should avoid the windows-with-verbose-timezone-name problem
2376 (Patch.testPatch): add a test which runs 'patch' with less
2377 overhead than the full VCBase.do_patch sequence, to try to isolate
2378 a windows test failure. This one uses slave.commands.ShellCommand
2379 and 'patch', but none of the VC code.
2381 * buildbot/slave/commands.py (getCommand): use which() to find the
2382 executables for 'cvs', 'svn', etc. This ought to help under
2385 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2386 working directory before starting. If an earlier test failed, the
2387 leftover directory would mistakenly flunk a later test.
2388 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2389 Make sure that we use the right commandlines if which("tla") picks
2390 up "tla.exe" (as it does under windows).
2391 (TlaSupport.do_get): factor out this tla-vs-baz difference
2392 (TlaSupport.vc_create): more tla-vs-baz differences
2394 * buildbot/test/test_slavecommand.py
2395 (ShellBase.testShellMissingCommand): stop trying to assert
2396 anything about the error message: different shells on different
2397 OSes with different languages makes it hard, and it really isn't
2398 that interesting of a thing to test anyway.
2400 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2401 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2402 "Panther"), because it has a bug which flunks a couple tests in
2403 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2404 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2405 able to test that yet.
2407 2006-04-30 Brian Warner <warner@lothar.com>
2409 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2410 make sure child commands emit messages in english, so our regexps
2411 will match. Thanks to Nikaus Giger for identifying the problems.
2412 (VCBase._do_vctest_export_1): mode="export" is not responsible
2413 for setting the "got_revision" property, since in many cases it is
2414 not convenient to determine.
2415 (SVNSupport.capable): when running 'svn --version' to check for
2416 ra_local, we want error messages in english
2417 * buildbot/test/test_slavecommand.py
2418 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2419 to emit the error message in english
2421 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2422 the environment with $LC_ALL="C" so that Commands which need to
2423 parse the output of their child processes can obtain it in
2425 (SVN.parseGotRevision): call "svn info" afterwards instead of
2426 watching the output of the "svn update" or "svn checkout".
2427 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2428 (Arch.parseGotRevision): same
2429 (Bazaar.parseGotRevision): same
2430 (Mercurial.parseGotRevision): same
2432 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2433 $LC_ALL="C" when running commands under 'buildbot try', too
2435 * buildbot/test/__init__.py: remove the global os.environ()
2436 setting, instead we do it just for the tests that run commands and
2437 need to parse their output.
2439 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2440 remove the overly-short .timeout on this test, because non-DNotify
2441 platforms must fall back to polling which happens at 10 second
2442 intervals, so a 5 second timeout would never succeed.
2444 2006-04-24 Brian Warner <warner@lothar.com>
2446 * docs/buildbot.texinfo (Installing the code): update trial
2447 invocation, SF#1469116 by Niklaus Giger.
2448 (Attributes of Changes): updated branch-name examples to be
2449 a bit more realistic, SF#1475240 by Stephen Davis.
2451 * contrib/windows/buildbot2.bat: utility wrapper for windows
2452 developers, contributed by Nick Trout (after a year of neglect..
2453 sorry!). SF#1194231.
2455 * buildbot/test/test_vc.py (*.capable): store the actual VC
2456 binary's pathname in VCS[vcname], so it can be retrieved later
2457 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2458 strip out non-numeric timezone information, specifically the funky
2459 German string that his system produced that confuses CVS.
2460 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2461 allow Darcs tests to work on windows
2462 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2463 procutils.which() everywhere, to allow tryclient to work under
2464 windows. Also from Niklaus Giger, SF#1463394.
2466 * buildbot/twcompat.py (which): move the replacement for a missing
2467 twisted.python.procutils.which from test_vc.py to here, so it can
2468 be used in other places too (specifically tryclient.py)
2470 2006-04-23 Brian Warner <warner@lothar.com>
2472 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2473 bare buildbotURL/projectName line with a proper DIV, along with a
2474 CSS class of "title", from Stefan Seefeld (SF#1461675).
2475 (WaterfallStatusResource.body0): remove the redundant 'table'
2476 class from the table
2477 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2478 to the top-row TR, and class="Activity" to the second-row TR,
2479 rather than putting them in the individual TD nodes.
2481 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2482 'got_revision' build property for all VC systems that implement
2483 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2485 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2486 to determine which revision we actually obtained
2487 (CVS.parseGotRevision): implement this for CVS, which just means
2488 to grab a timestamp. Not ideal, and it depends upon the buildslave
2489 having a clock that is reasonably well syncronized with the server,
2490 but it's better than nothing.
2491 (SVN.parseGotRevision): implement it for SVN, which is accurate
2492 (Darcs.parseGotRevision): same
2493 (Arch.parseGotRevision): same
2494 (Bazaar.parseGotRevision): same
2495 (Mercurial.parseGotRevision): same
2497 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2498 keep a record of all non-stdout/stderr/header/rc status updates,
2499 for the benefit of RemoteCommands that send other useful things,
2501 (Source.commandComplete): put any 'got_revision' status values
2502 into a build property of the same name
2505 * buildbot/process/step_twisted.py (Trial): update to deal with
2506 new ShellCommand refactoring
2508 * docs/buildbot.texinfo (Build Properties): document new feature
2509 that allows BuildSteps to get/set Build-wide properties like which
2510 revision was requested and/or checked out.
2512 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2513 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2514 it. Note that this bumps the persistenceVersion of the saved Build
2515 object, so add the necessary upgrade-old-version logic to include
2516 an empty properties dict.
2518 * buildbot/process/base.py (Build.setProperty): implement it
2519 (Build.getProperty): same
2520 (Build.startBuild): change build startup to set 'branch',
2521 'revision', and 'slavename' properties at the right time
2523 * buildbot/process/step.py (BuildStep.__init__): change setup to
2524 require 'build' argument in a better way
2525 (LoggingBuildStep): split ShellCommand into two pieces, for better
2526 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2527 a single RemoteCommand that sends stdout/stderr status text. It
2528 also provides the usual commandComplete / createSummary /
2529 evaluateCommand / getText methods to be overridden...
2530 (ShellCommand): .. whereas ShellCommand is specifically for
2531 running RemoteShellCommands. Other shell-like BuildSteps (like
2532 Source) can inherit from LoggingBuildStep instead of ShellCommand
2533 (WithProperties): marker class to do build-property interpolation
2534 (Source): inherit from LoggingBuildStep instead of ShellCommand
2537 * buildbot/test/test_properties.py: test new functionality
2539 2006-04-21 Brian Warner <warner@lothar.com>
2541 * buildbot/test/test_vc.py: rename testBranch to
2542 testCheckoutBranch to keep the tests in about the right
2545 2006-04-18 Brian Warner <warner@lothar.com>
2547 * docs/buildbot.texinfo (PBListener): improve cross-references
2548 between PBListener and 'buildbot statusgui', thanks to John Pye
2551 2006-04-17 Brian Warner <warner@lothar.com>
2553 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2554 running under Twisted-1.3.0, otherwise skipped tests are reported
2557 * all: use isinstance() instead of 'type(x) is foo', suggested by
2560 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2561 oops, fix a brain-fade from the other week, when making the
2562 addStep changes. I changed all the __init__ upcalls to use the
2563 wrong superclass name.
2564 (FullTwistedBuildFactory.__init__): same
2565 (TwistedDebsBuildFactory.__init__): same
2566 (TwistedReactorsBuildFactory.__init__): same
2567 (TwistedBuild.isFileImportant): use .startswith for clarity,
2568 thanks to Neal Norwitz for the suggestions.
2570 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2571 changes, then deliver them over PB to a remote buildmaster.
2573 * contrib/svnpoller.py: added script by John Pye to poll a remote
2574 SVN repository (by running 'svn log') from a cronjob, and run
2575 'buildbot sendchange' to deliver the changes to a remote
2577 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2578 modification of svnpoller.py), same purpose, but this one loops
2579 internally (rather than expecting to run from a cronjob) and works
2581 * contrib/README.txt: same
2583 2006-04-11 Brian Warner <warner@lothar.com>
2585 * all: fix a number of incorrect names and missing imports, thanks
2586 to Anthony Baxter for the patch.
2587 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2588 remove unused buggy method.
2589 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2590 comes from shutil, not "shutils"
2591 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2592 (Arch.checkSlaveVersion): same
2593 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2595 * buildbot/process/step_twisted2.py: add some missing imports
2596 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2597 this code used to live in twisted.internet.defer
2599 2006-04-10 Brian Warner <warner@lothar.com>
2601 * buildbot/process/step.py (Mercurial): add Mercurial support
2602 * buildbot/slave/commands.py (Mercurial): same
2603 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2604 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2605 not yet tested, but 'try' support *is* covered
2606 * docs/buildbot.texinfo (Mercurial): document it
2608 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2609 some debugging messages (turned off)
2610 * buildbot/test/test_vc.py: improve debug messages
2612 2006-04-07 Brian Warner <warner@lothar.com>
2614 * buildbot/test/test_vc.py (which): define our own which() in case
2615 we can't import twisted.python.procutils, because procutils doesn't
2616 exist in Twisted-1.3
2618 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2619 of SlaveLocks for performance tests
2621 * docs/examples/twisted_master.cfg: update to match current usage
2623 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2624 password, p4 binary, pollinterval, maximum history to check.
2625 Patch from an anonymous sf.net contributor, SF#1219384.
2626 * buildbot/process/step.py (P4Sync.__init__): add username,
2627 password, and client arguments.
2628 * buildbot/slave/commands.py (P4Sync): same
2630 2006-04-05 Brian Warner <warner@lothar.com>
2632 * buildbot/process/factory.py (BuildFactory.addStep): new method
2633 to add steps to a BuildFactory. Use it instead of f.steps.append,
2634 and you can probably avoid using the s() convenience function.
2635 Patch from Neal Norwitz, sf.net #1412605.
2636 (other): update all factories to use addStep
2637 * buildbot/process/process_twisted.py: update all factories to use
2640 2006-04-03 Brian Warner <warner@lothar.com>
2642 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2643 work under windows too. Adapted from a patch by Niklaus Giger,
2644 addresses SF#1463399.
2646 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2647 spawned commands emit parseable results in english and not some
2648 other language. Patch from Niklaus Giger, SF#1463395.
2650 * README (INSTALLATION): discourage users from running unit tests on
2651 a "network drive", patch from Niklaus Giger, SF#1463394.
2653 2006-03-22 Brian Warner <warner@lothar.com>
2655 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2656 function to turn a repository-relative pathname into a (branch,
2657 branch-relative-filename) tuple. Change this function to handle
2658 the branch naming policy used by your Subversion repository.
2659 Thanks to AllMyData.com for sponsoring this work.
2661 2006-03-16 Brian Warner <warner@lothar.com>
2663 * buildbot/scripts/sample.cfg: add python-mode declaration for
2664 vim. Thanks to John Pye for the patch.
2666 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2667 command line, mention the importance of running 'crontab' as the
2668 buildmaster/buildslave user. Thanks to John Pye for the catch.
2670 2006-03-13 Brian Warner <warner@lothar.com>
2672 * buildbot/status/words.py (IRC): add an optional password=
2673 argument, which will be sent to Nickserv in an IDENTIFY message at
2674 login, to claim the nickname. freenode requires this before the
2675 bot can sent (or reply to) private messages. Thanks to Clement
2676 Stenac for the patch.
2677 * docs/buildbot.texinfo (IRC Bot): document it
2679 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2680 larger than chunkSize. Fixes SF#1349253.
2681 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2682 (Log.testConsumer): update to match new internal chunking behavior
2684 2006-03-12 Brian Warner <warner@lothar.com>
2686 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2688 * buildbot/test/test_maildir.py (MaildirTest): rename the
2689 'timeout' method, as it collides with trial's internals
2691 * buildbot/scripts/runner.py: add 'buildbot restart' command
2692 (stop): don't sys.exit() out of here, otherwise restart can't work
2693 * docs/buildbot.texinfo (Shutdown): document it
2695 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2696 * buildbot/status/html.py (Waterfall.__init__): same
2697 * buildbot/process/builder.py (Builder.startBuild): same
2698 * buildbot/process/base.py (BuildRequest): same
2699 * buildbot/sourcestamp.py (SourceStamp): same
2700 * buildbot/scheduler.py (Nightly): same
2702 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2704 * docs/buildbot.texinfo: same
2706 2006-02-17 Brian Warner <warner@lothar.com>
2708 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2709 * docs/buildbot.texinfo: set version number to match
2710 * NEWS: update for 0.7.2
2712 2006-02-16 Brian Warner <warner@lothar.com>
2714 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2716 2006-02-09 Brian Warner <warner@lothar.com>
2718 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2719 add text to explain per-build branch parameters
2720 * NEWS: mention --umask
2722 2006-02-08 Brian Warner <warner@lothar.com>
2724 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2726 (SlaveOptions.optParameters): add --umask, to make it possible to
2727 make buildslave-generated files (including build products) be
2730 * buildbot/slave/bot.py (BuildSlave.startService): same
2732 2006-01-23 Brian Warner <warner@lothar.com>
2734 * buildbot/status/builder.py: urllib.quote() all URLs that include
2735 Builder names, so that builders can include characters like '/'
2736 and ' ' without completely breaking the resulting HTML. Thanks to
2737 Kevin Turner for the patch.
2738 * buildbot/status/html.py: same
2739 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2741 * NEWS: update in preparation for upcoming release
2743 2006-01-18 Brian Warner <warner@lothar.com>
2745 * docs/examples/twisted_master.cfg: update to match the Twisted
2746 buildbot: remove python2.2, switch to exarkun's buildslaves,
2747 disable the .deb builder until we figure out how to build twisted
2748 .debs from SVN, add some ktrace debugging to the OS-X build
2749 process and remove the qt build, remove threadless builders,
2750 change freebsd builder to use landonf's buildslave.
2752 2006-01-12 Brian Warner <warner@lothar.com>
2754 * buildbot/master.py (Manhole.__init__): let port= be a strports
2755 specification string, but handle a regular int for backwards
2756 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2757 used in master.cfg to limit connections to just the local host.
2758 (BuildMaster.loadConfig): same for c['slavePortnum']
2759 * buildbot/scheduler.py (Try_Userpass.__init__): same
2760 * buildbot/status/client.py (PBListener.__init__): same
2761 * buildbot/status/html.py (Waterfall.__init__): same, for both
2762 http_port and distrib_port. Include backwards-compatibility checks
2763 so distrib_port can be a filename string and still mean unix:/foo
2764 * docs/buildbot.texinfo (Setting the slaveport): document it
2765 (Debug options): same
2766 (HTML Waterfall): same
2769 * buildbot/test/test_config.py (ConfigTest): test it
2771 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2772 slaveport's disownServiceParent deferred to fire before opening
2773 the new one. Fixes an annoying bug in the unit tests.
2775 2006-01-03 Brian Warner <warner@lothar.com>
2777 * buildbot/master.py (BuildMaster): remove the .schedulers
2778 attribute, replacing it with an allSchedulers() method that looks
2779 for all IService children that implement IScheduler. Having only
2780 one parent/child relationship means fewer opportunities for bugs.
2781 (BuildMaster.allSchedulers): new method
2782 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2783 also fix ugly bug that caused any config-file reload to
2784 half-forget about the earlier Schedulers, causing an exception
2785 when a Change arrived and was handed to a half-connected
2786 Scheduler. The exception was in scheduler.py line 54ish:
2787 self.parent.submitBuildSet(bs)
2788 exceptions.AttributeError: 'NoneType' object has no attribute
2790 (BuildMaster.addChange): update to use allSchedulers()
2792 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2793 to work properly with twisted-1.3.0, where you must explicitly
2794 include the __implements__ from parent classes
2795 (BaseScheduler.__repr__): make it easier to distinguish distinct
2797 (BaseUpstreamScheduler.__implements__): same
2799 * buildbot/status/builder.py (Status.getSchedulers): update to
2801 * buildbot/test/test_run.py (Run.testMaster): same
2802 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2803 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2804 make sure Scheduler instances are left alone when an identical
2805 config file is reloaded
2806 (ConfigElements.testSchedulers): make sure Schedulers are properly
2809 * Makefile (TRIALARGS): my local default Twisted version is now
2810 2.1.0, update the trial arguments accordingly
2812 2005-12-22 Brian Warner <warner@lothar.com>
2814 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2817 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2818 addChange in the parent class, although I suspect this should be
2819 fixed better in the future.
2821 2005-11-26 Brian Warner <warner@lothar.com>
2823 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2824 explode when branch==None, thanks to Kevin Turner for the catch
2825 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2828 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2830 * docs/buildbot.texinfo: same
2832 2005-11-26 Brian Warner <warner@lothar.com>
2834 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2835 * docs/buildbot.texinfo: set version number to match
2837 2005-11-26 Brian Warner <warner@lothar.com>
2839 * NEWS: update for 0.7.1
2841 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2842 sure that unsubscribe works even if we never sent an ETA update.
2843 Also, don't explode on duplicate unsubscribe.
2844 (BuildStepStatus.addLog): make the convenience "return self"-added
2845 watcher automatically unsubscribe when the Step finishes.
2846 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2847 (BuildStatus.stepStarted): same auto-unsubscribe
2848 (BuilderStatus.buildStarted): same auto-unsubscribe
2850 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2852 (IStatusReceiver.stepStarted): same
2853 (IStatusReceiver.logStarted): same
2855 * buildbot/test/test_run.py (Status): move the Status test..
2856 * buildbot/test/test_status.py (Subscription): .. to here
2858 2005-11-25 Brian Warner <warner@lothar.com>
2860 * NEWS: more updates
2862 * buildbot/locks.py: fix the problem in which loading a master.cfg
2863 file that changes some Builders (but not all of them) can result
2864 in having multiple copies of the same Lock. Now, the real Locks
2865 are kept in a table inside the BotMaster, and the Builders/Steps
2866 use "LockIDs", which are still instances of MasterLock and
2867 SlaveLock. The real Locks are instances of the new RealMasterLock
2868 and RealSlaveLock classes.
2869 * buildbot/master.py (BotMaster.getLockByID): new method to
2870 convert LockIDs into real Locks.
2871 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2872 into real Locks before building
2873 * buildbot/process/step.py (BuildStep.startStep): same
2874 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2875 exercises the problem
2878 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2879 what Schedulers are available
2881 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2882 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2883 'cron'-style build scheduling at certain times of day, week,
2885 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2887 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2888 handling: treat self.fileIsImportant more as an attribute that
2889 contains a callable than as a method. If the attribute is None,
2890 don't call it and assume all filenames are important. It is still
2891 possible to provide a fileIsImportant method in a subclass,
2893 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2895 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2896 test using AnyBranchScheduler with fileIsImportant=None
2898 2005-11-24 Brian Warner <warner@lothar.com>
2900 * buildbot/test/test_config.py (StartService): don't claim a fixed
2901 port number, instead set slavePort=0 on the first pass, figure out
2902 what port was allocated, then switch to a config file that uses
2905 * buildbot/master.py (BuildMaster.loadConfig): close the old
2906 slaveport before opening the new one, because unit tests might
2907 replace slavePort=0 with the same allocated portnumber, and if we
2908 don't wait for the old port to close first, we get a "port already
2909 in use" error. There is a tiny race condition here, but the only
2910 threat is from other programs that bind (statically) to the same
2911 port number we happened to be allocated, and only if those
2912 programs use SO_REUSEADDR, and only if they get control in between
2915 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2917 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2918 deleted ChangeSources before adding any new ones
2919 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2920 compare_attrs, to make sure that a config-file reload does not
2921 unnecessarily replace an unmodified ChangeSource instance
2922 * buildbot/test/test_config.py (ConfigTest.testSources): update
2924 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2925 mean "don't build anything", and add a warning if it gets used
2926 because it isn't actually useful.
2928 * contrib/svn_buildbot.py: update example usage to match the port
2929 number that gets used by the PBChangeSource
2930 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2932 2005-11-22 Brian Warner <warner@lothar.com>
2934 * NEWS: start collecting items for next release
2936 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2937 revisions are strings
2938 (P4Sync.computeSourceRevision): same
2940 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2941 to the Buildbot's overall status page
2942 (StatusResourceBuilder.body): same
2944 2005-11-15 Brian Warner <warner@lothar.com>
2946 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2947 config-file loading, specifically to make sure old StatusTargets
2948 are finished shutting down before new ones start up (thus
2949 resolving a bug in which changing the Waterfall object would fail
2950 because both new and old instances were claiming the same
2951 listening port). Also load new Schedulers after all the new
2952 Builders are set up, in case they fire off a new build right away.
2953 * buildbot/test/test_config.py (StartService): test it
2955 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2956 the branch name to the mail body
2958 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2959 Without it, a config-file reload fails to update an existing
2961 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2962 username/passwd to compare_attrs, for the same reason
2963 * buildbot/status/html.py (Waterfall): add favicon to
2964 compare_attrs, same reason
2966 2005-11-05 Brian Warner <warner@lothar.com>
2968 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2969 baserev before stuffing it in the jobfile. This resolves problems
2970 under SVN (and probably Arch) where revisions are expressed as
2971 numbers. I'm inclined to use string-based revisions everywhere in
2972 the future, but this fix should be safe for now. Thanks to Steven
2973 Walter for the patch.
2975 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2976 binary mode when opening pickle files, to make windows work
2977 better. Thanks to Dobes Vandermeer for the catch.
2978 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2979 (BuilderStatus.getBuildByNumber): same
2980 (Status.builderAdded): same
2981 * buildbot/master.py (BuildMaster.loadChanges): same
2983 * buildbot/util.py (Swappable): delete unused leftover code
2985 * buildbot/process/step.py (SVN): when building on a non-default
2986 branch, add the word "[branch]" to the VC step's description, so
2987 it is obvious that we're not building the usual stuff. Likewise,
2988 when we are building a specific revision, add the text "rNNN" to
2989 indicate what that revision number is. Thanks to Brad Hards and
2990 Nathaniel Smith for the suggestion.
2991 (Darcs.startVC): same
2992 (Arch.startVC): same
2993 (Bazaar.startVC): same
2995 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2996 typo, caught by Mark Dillavou, closes SF#1216636.
2998 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2999 about a test to add some day
3001 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3002 the 'full-2.3' build, and the 'reactors' build is now run under
3003 python-2.4 because the buildslave no longer has gtk/etc bindings
3004 for earlier versions.
3006 2005-11-03 Brian Warner <warner@lothar.com>
3008 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3009 method, takes an IBuildStatus and rebuilds it. It might make more
3010 sense to add this to IBuildControl instead, but that instance goes
3011 away completely once the build has finished, and resubmitting
3012 builds can take place weeks later.
3013 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3014 * buildbot/status/html.py (StatusResourceBuild): also stash an
3015 IBuilderControl so we can use resubmitBuild.
3016 (StatusResourceBuild.body): render "resubmit" button if we can.
3017 Also add hrefs for each BuildStep
3018 (StatusResourceBuild.rebuild): add action for "resubmit" button
3019 (StatusResourceBuilder.getChild): give it an IBuilderControl
3021 * buildbot/status/builder.py (Status.getURLForThing): change the
3022 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3023 that live as targets of buttons like "stop" and "rebuild" can't
3025 * buildbot/status/builder.py (Status.getURLForThing): same
3026 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3027 (StepBox.getBox): same
3028 * buildbot/test/test_web.py (GetURL): same
3031 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3032 exclusivity checks after Source.__init__ upcall, so misspelled
3033 arguments will be reported more usefully
3034 (Darcs.__init__): same
3036 2005-10-29 Brian Warner <warner@lothar.com>
3038 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3039 builder. Move the Try scheduler off to a separate port.
3041 2005-10-27 Brian Warner <warner@lothar.com>
3043 * buildbot/clients/gtkPanes.py
3044 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3045 to cause the app to crash, now they don't.
3047 * buildbot/clients/debug.py: display the buildmaster's location
3048 in the window's title bar
3050 2005-10-26 Brian Warner <warner@lothar.com>
3052 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3053 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3054 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3056 * buildbot/status/html.py (td): put a single non-breaking space
3057 inside otherwise empty <td> elements, as a workaround for buggy
3058 browsers which would optimize them away (along with any associated
3059 styles, like the kind that create the waterfall grid borders).
3060 Patch from Frerich Raabe.
3062 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3063 argv-list as an argument, defaulting to ["-to"], which is
3064 appropriate for the Trial that comes with Twisted-2.1.0 and
3065 earlier. The Trial in current Twisted SVN wants
3066 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3067 defaults to an empty list.
3068 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3069 match it, now that trialMode= is a list instead of a single string
3071 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3073 * docs/buildbot.texinfo: same
3075 2005-10-24 Brian Warner <warner@lothar.com>
3077 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3078 * docs/buildbot.texinfo: set version number to match
3080 2005-10-24 Brian Warner <warner@lothar.com>
3082 * README: update for 0.7.0
3084 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3086 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3087 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3088 send the branch= argument unless the user really provided one, to
3089 retain compatibility with older buildmasters that don't accept
3091 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3094 * docs/buildbot.texinfo: update lots of stuff
3096 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3097 to the 'buildbot sendchange' command
3098 * buildbot/clients/sendchange.py (Sender.send): same
3099 * buildbot/changes/pb.py (ChangePerspective): same
3100 * buildbot/test/test_changes.py (Sender.testSender): test it
3102 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3103 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3104 for consistency with other BuildStep arguments that use camelCase.
3105 Well, at least more of them use camelCase (like flunkOnWarnings)
3106 than don't.. I wish I'd picked one style and stuck with it
3107 earlier. Annoying, but it's best done before the release, since
3108 these arguments didn't exist at all in 0.6.6 .
3110 * buildbot/test/test_vc.py (SVN.testCheckout): same
3111 (Darcs.testPatch): same
3112 * docs/buildbot.texinfo (SVN): document the change
3113 (Darcs): same, add some build-on-branch docs
3114 * docs/examples/twisted_master.cfg: match change
3116 * buildbot/process/step.py (BuildStep): rename
3117 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3118 how it is normally used.
3119 * buildbot/test/test_steps.py (Version.checkCompare): same
3121 * buildbot/process/step.py (CVS.startVC): refuse to build
3122 update/copy -style builds on a non-default branch with an old
3123 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3124 concern is that it will do a VC 'update' in an existing tree when
3125 it is supposed to be switching branches (and therefore clobbering
3126 the tree to do a full checkout), thus building the wrong source.
3127 This used to be a warning, but I think the confusion it is likely
3128 to cause warrants making it an error.
3129 (SVN.startVC): same, also make mode=export on old slaves an error
3130 (Darcs.startVC): same
3131 (Git.startVC): improve error message for non-Git-enabled slaves
3132 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3133 specific revision is built on a slave that doesn't pay attention
3134 to args['revision'], because for slowly-changing trees it will
3135 probably do the right thing, and because we have no way to tell
3136 whether we're asking it to build the most recent version or not.
3137 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3139 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3140 that 'master' is in host:portnum format, to catch errors sooner
3142 2005-10-23 Brian Warner <warner@lothar.com>
3144 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3145 when creating the list of warning messages, include the line
3146 immediately after each WARNING: line, since that's usually where
3147 the file and line number wind up.
3149 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3154 2005-10-22 Brian Warner <warner@lothar.com>
3156 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3157 patch from Brad Hards
3158 * buildbot/status/classic.css: same
3159 * buildbot/test/test_web.py (Waterfall): match changes
3161 * buildbot/test/test_steps.py (BuildStep.setUp): set
3162 nextBuildNumber so the test passes
3163 * buildbot/test/test_status.py (MyBuilder): same
3165 * buildbot/status/html.py (StatusResourceBuild.body): revision
3166 might be numeric, so stringify it before html-escapifying it
3167 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3168 timer for the upcoming build
3169 * buildbot/status/classic.css: add background-color attributes for
3170 offline/waiting/building classes
3172 * buildbot/status/builder.py (BuildStatus): derive from
3173 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3174 the default (i.e. unknown) .slavename to "???" instead of None,
3175 since even unknown slavenames need to be printed eventually.
3176 (BuilderStatus): also derive from styles.Versioned . More
3177 importantly, determine .nextBuildNumber at creation/unpickling
3178 time by scanning the directory of saved BuildStatus instances and
3179 choosing one larger than the highest-numbered one found. This
3180 should fix the problem where random errors during upgrades cause
3181 the buildbot to forget about earlier builds. .nextBuildNumber is
3182 no longer stored in the pickle.
3183 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3184 at least log the error. Also call Builder.determineNextBuildNumber
3185 once the basedir is set.
3187 * buildbot/master.py (BuildMaster.loadChanges): do
3188 styles.doUpgrade afterwards, in case I decide to make Changes
3189 derived from styles.Versioned some day and forget to make this
3193 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3194 when running under older pythons (<2.3) in which the shlex module
3195 doesn't have a 'split' function.
3197 * buildbot/process/step.py (ShellCommand.start): make
3198 errorMessages= be a list of strings to stuff in the log before the
3199 command actually starts. This makes it easier to flag multiple
3200 warning messages, e.g. when the Source steps have to deal with an
3202 (CVS.startVC): handle slaves that don't handle multiple branches
3203 by switching into 'clobber' mode
3204 (SVN.startVC): same. Also reject branches without base_url
3205 (Darcs.startVC): same. Also reject revision= in older slaves
3206 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3207 (Bazaar.startVC): same, and test for baz separately than for arch
3209 * buildbot/slave/commands.py (cvs_ver): document new features
3211 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3212 (BuildStep.slaveVersionNewEnough): more useful utility method
3213 * buildbot/test/test_steps.py (Version): start testing it
3215 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3216 the 'force' command requires python2.3, for the shlex.split method
3218 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3219 since we don't use it anymore. The Twisted buildbot uses a
3222 2005-10-21 Brian Warner <warner@lothar.com>
3224 * buildbot/process/process_twisted.py: rework all BuildFactory
3225 classes to take a 'source' step as an argument, instead of
3226 building up the SVN instance in the factory.
3227 * docs/examples/twisted_master.cfg: enable build-on-branch by
3228 providing a base_url and default_branch
3230 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3231 control over --branch and --revision, not that they are always
3233 * buildbot/status/html.py (StatusResourceBuilder.force): same
3234 (StatusResourceBuild.body): display SourceStamp components
3236 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3237 IRC 'force' command, so it can be shared with an eventual
3238 command-line-tool 'buildbot force' mode.
3239 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3241 2005-10-20 Brian Warner <warner@lothar.com>
3243 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3245 * docs/examples/twisted_master.cfg: update to use Schedulers
3247 * buildbot/scripts/sample.cfg: update with Schedulers
3249 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3250 method specifically for use by HTML "force build" button and the
3251 IRC "force" command. Raises an immediate error if there are no
3253 (IBuilderControl.requestBuild): make this just submit a build, not
3254 try to check for existing slaves or set up any when-finished
3255 Deferreds or anything.
3256 * buildbot/process/builder.py (BuilderControl): same
3257 * buildbot/status/html.py (StatusResourceBuilder.force): same
3258 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3259 * buildbot/test/test_slaves.py: same
3260 * buildbot/test/test_web.py: same
3262 2005-10-19 Brian Warner <warner@lothar.com>
3264 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3265 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3267 2005-10-18 Brian Warner <warner@lothar.com>
3269 * buildbot/status/html.py: provide 'status' argument to most
3270 StatusResourceFOO objects
3271 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3272 and Logfiles" section to make the Build page into a more-or-less
3273 comprehensive source of status information about the build
3275 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3276 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3278 2005-10-17 Brian Warner <warner@lothar.com>
3280 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3281 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3282 out what to do about other projects: the correct options for
3283 recent Twisteds will not work for older ones.
3285 2005-10-15 Brian Warner <warner@lothar.com>
3287 * buildbot/status/builder.py (Status.getURLForThing): add method
3288 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3289 use this in email/IRC status clients to make them more useful, by
3290 providing the end user with hints on where to learn more about the
3291 object being reported on.
3292 * buildbot/test/test_web.py (GetURL): tests for it
3294 2005-10-14 Brian Warner <warner@lothar.com>
3296 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3297 fix bug resulting from deferredResult changes
3299 2005-10-13 Brian Warner <warner@lothar.com>
3301 * buildbot/test/test_changes.py: remove use of deferredResult
3302 * buildbot/test/test_config.py: same
3303 * buildbot/test/test_control.py: same
3304 * buildbot/test/test_status.py: same
3305 * buildbot/test/test_vc.py: this is the only remaining use, since
3306 it gets used at module level. This needs to be replaced by some
3307 sort of class-level run-once routine.
3309 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3311 * lots: implement multiple slaves per Builder, which means multiple
3312 current builds per Builder. Some highlights:
3313 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3314 of (state,currentBuilds) instead of (state,currentBuild)
3315 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3316 (IBuildStatus.getSlavename): new method, so you can tell which
3317 slave got used. This only gets set when the build completes.
3318 (IBuildRequestStatus.getBuilds): new method
3320 * buildbot/process/builder.py (SlaveBuilder): add a .state
3321 attribute to track things like ATTACHING and IDLE and BUILDING,
3323 (Builder): .. the .slaves attribute here, which has been turned
3324 into a simple list of available slaves. Added a separate
3325 attaching_slaves list to track ones that are not yet ready for
3327 (Builder.fireTestEvent): put off the test-event callback for a
3328 reactor turn, to make tests a bit more consistent.
3329 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3330 ping fails due to an exception. This needs work, I'm worried that
3331 a code error could lead to a constantly re-connecting slave.
3332 Especially since I'm trying to move to a distinct remote_ping
3333 method, separate from the remote_print that we currently use.
3334 (BuilderControl.requestBuild): return a convenience Deferred that
3335 provides an IBuildStatus when the build finishes.
3336 (BuilderControl.ping): ping all connected slaves, only return True
3337 if they all respond.
3339 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3340 reconnect when we shut down.
3342 * buildbot/status/builder.py: implement new methods, convert
3343 one-build-at-a-time methods to handle multiple builds
3344 * buildbot/status/*.py: do the same in all default status targets
3345 * buildbot/status/html.py: report the build's slavename in the
3346 per-Build page, report all buildslaves on the per-Builder page
3348 * buildbot/test/test_run.py: update/create tests
3349 * buildbot/test/test_slaves.py: same
3350 * buildbot/test/test_scheduler.py: remove stale test
3352 * docs/buildbot.texinfo: document the new builder-specification
3353 'slavenames' parameter
3355 2005-10-12 Brian Warner <warner@lothar.com>
3357 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3358 report failure correctly, causing Dependent builds to run when
3359 they shouldn't have.
3360 * buildbot/status/builder.py (BuildSetStatus): same
3361 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3362 (Set.testSuccess): test the both-pass case too
3363 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3364 fix this test: it was ending too early, masking the failure before
3365 (Logger): specialized StatusReceiver to make sure the dependent
3366 builds aren't even started, much less completed.
3368 2005-10-07 Brian Warner <warner@lothar.com>
3370 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3371 bot.SlaveBuilder being disowned in the middle of a build
3373 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3374 this inherit from StatusReceiver. Also upcall in __init__. This
3375 fixes the embarrasing crash when the new buildSetSubmitted method
3376 is invoked and Waterfall/etc don't implement their own.
3377 * buildbot/test/test_run.py: add a TODO note about a test to catch
3378 just this sort of thing.
3380 * buildbot/process/builder.py (Builder.attached): remove the
3381 already-attached warning, this situation is normal. Add some
3382 comments explaining it.
3384 2005-10-02 Brian Warner <warner@lothar.com>
3386 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3387 OverflowError when setting up dnotify, because some 64-bit systems
3388 have problems with signed-vs-unsigned constants and trip up on the
3389 DN_MULTISHOT flag. Patch from Brad Hards.
3391 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3393 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3394 progressMetrics, description, descriptionDone to the 'parms' list,
3395 and make use the 'parms' list from the implementation class
3396 instead of only BuildStep to initialize the parameters. This
3397 allows buildbot.process.factory.s() to initialize all the parms,
3398 not just those defined in directly by BuildStep.
3400 2005-09-03 Brian Warner <warner@lothar.com>
3402 * NEWS: start adding items for the next release
3404 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3405 python2.2 tests, change 'Quick' builder to only use python2.3
3407 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3409 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3410 the "Ping Builder" button if the build control is available; the
3411 user sees an exception otherwise
3413 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3415 2005-09-01 Brian Warner <warner@lothar.com>
3417 * buildbot/interfaces.py (IBuilderStatus.getState): update
3418 signature, point out that 'build' can be None
3419 (IBuildStatus.getETA): point out ETA can be none
3421 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3423 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3425 2005-08-31 Brian Warner <warner@lothar.com>
3427 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3428 update to match correct signature: removed 'eta' argument
3429 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3431 2005-08-30 Brian Warner <warner@lothar.com>
3433 * buildbot/status/builder.py (LogFile): remove the assertion that
3434 blows up when you try to overwrite an existing logfile, instead
3435 just emit a warning. This case gets hit when the buildmaster is
3436 killed and doesn't get a chance to write out the serialized
3437 BuilderStatus object, so the .nextBuildNumber attribute gets out
3440 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3441 the 'buildbot sendchange' arguments, for the Darcs context file
3442 * docs/buildbot.texinfo (sendchange): document it
3444 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3445 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3446 (IStatus.getSchedulers): new method
3447 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3448 (Status.getSchedulers): implement
3449 * buildbot/process/builder.py (Builder): maintain
3450 BuilderStatus.pendingBuilds
3451 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3452 (TryBase.addChange): Try schedulers should ignore Changes
3454 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3455 for 'try' on CVS/SVN
3456 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3458 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3459 report status properly.
3460 (Try.createJob): implement unique buildset IDs
3462 * buildbot/status/client.py (StatusClientPerspective): add a
3463 perspective_getBuildSets method for the benefit of jobdir-style
3465 * docs/buildbot.texinfo (try): more docs
3466 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3469 2005-08-18 Brian Warner <warner@lothar.com>
3471 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3472 actually work. It's functional but still kind of clunky. Also, it
3473 only works with the pb-style.. needs to be made to work with the
3476 * buildbot/status/client.py (RemoteBuildSet): new class
3477 (RemoteBuildRequest): same
3478 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3479 object, not the internal BuildStatus object.
3480 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3481 outside of the usual buildStarted() return value.
3482 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3484 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3485 (Try_Userpass_Perspective.perspective_try): return a remotely
3486 usable BuildSetStatus object
3488 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3489 isStarted()/waitUntilStarted()
3491 2005-08-16 Brian Warner <warner@lothar.com>
3493 * buildbot/status/builder.py: implement IBuildSetStatus and
3494 IBuildRequestStatus, wire them into place.
3495 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3496 methods into the BuildSetStatus object.
3497 * buildbot/interfaces.py: same
3498 (IStatus.getBuildSets): new method to get pending BuildSets
3499 (IStatusReceiver.buildsetSubmitted): new method which hears about
3501 * buildbot/master.py (BuildMaster.submitBuildSet): same
3502 * buildbot/process/base.py (BuildRequest): same, replace
3503 waitUntilStarted with subscribe/unsubscribe
3504 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3505 subscribe instead of waitUntilStarted
3506 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3508 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3510 * buildbot/test/test_buildreq.py: update for new code
3511 * buildbot/test/test_control.py (Force.testRequest): same
3514 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3515 for Darcs to not use the tempfile module, so it works under
3516 python-2.2 too. We really didn't need the full cleverness of that
3517 module, since the slave has exclusive control of its own builddir.
3519 2005-08-15 Brian Warner <warner@lothar.com>
3521 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3522 for CVS trees. It doesn't work for non-trunk branches,
3524 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3527 * Makefile: make it easier to test against python2.2
3529 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3530 tearDown2, so things like Arch can unregister archives as they're
3531 shutting down. The previous subclass-override-tearDown technique
3532 resulted in a nested maybeWait() and test failures under
3535 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3536 where we can (Arch), add a branch= argument to set the branch used
3538 (BazExtractor): extract the branch too
3539 (TlaExtractor): same
3540 * buildbot/scripts/runner.py (TryOptions): add --branch
3541 * docs/buildbot.texinfo (try): document --branch/try_branch
3543 * buildbot/slave/commands.py (Darcs): implement get-revision for
3544 Darcs, so that 'try' will work. This requires the tempfile module
3547 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3548 of revisions, branches, and 'try' in the process.
3550 2005-08-11 Brian Warner <warner@lothar.com>
3552 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3553 this, it got broken at some point in the last few releases
3554 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3555 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3556 specifically the removal of ETA information from the tuple
3558 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3561 * docs/buildbot.texinfo (try): document both --builder and
3562 'try_builders' in .buildbot/options
3563 * buildbot/scripts/runner.py (TryOptions): add --builder,
3564 accumulate the values into opts['builders']
3565 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3566 * buildbot/test/test_runner.py (Try): add some quick tests to make
3567 sure 'buildbot try --options' and .buildbot/options get parsed
3568 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3569 use --builder control
3571 * docs/buildbot.texinfo (try): add --port argument to PB style
3573 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3574 actual SourceStamp. Still need to extract a branch name, somehow.
3575 (Try): finish implementing the try client side, still need a UI
3576 for specifying which builders to use
3577 (Try.getopt): factor our options/config-file reading
3578 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3580 * buildbot/test/test_vc.py: match SourceStampExtractor change
3582 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3583 causes the twisted log to be sent to stderr
3585 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3587 2005-08-10 Brian Warner <warner@lothar.com>
3589 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3590 style is 90% done, still missing status reporting or waiting for
3591 the buildsets to finish, and it is completely untested.
3593 * buildbot/trybuild.py: delete file, move contents to ..
3594 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3595 * buildbot/test/test_vc.py: match the move
3597 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3598 of the TryScheduler, no buildsetID or status-tracking support yet
3599 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3601 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3602 possible to set the basedir after __init__ time, so it is easier
3603 to use as a Service-child of the BuildMaster instance
3605 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3606 that delivers messages to its Service parent instead of requiring
3607 a subclass to be useful. This turns out to be much easier to build
3610 * buildbot/scripts/tryclient.py (createJob): utility code to
3611 create jobfiles, will eventually be used by 'buildbot try'
3613 2005-08-08 Brian Warner <warner@lothar.com>
3615 * docs/buildbot.texinfo (try): add docs on the
3616 as-yet-unimplemented Try scheduler
3618 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3619 * buildbot/test/test_scheduler.py: .. here
3620 (Scheduling.testTryJobdir): add placeholder test for 'try'
3622 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3623 addEntry merging (>=chunkSize) behavior
3624 (Log.testConsumer): update to handle new callLater(0) behavior
3626 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3627 both the MAX_LENGTH bugfix and the resumeProducing hang.
3629 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3630 put off the actual resumeProducing for a moment with
3631 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3632 causes large logfiles to hang midway through.
3634 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3635 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3636 and to improve memory usage when streaming the file out to a web
3638 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3639 make this work cleanly
3641 2005-08-03 Brian Warner <warner@lothar.com>
3643 * buildbot/trybuild.py: new file for 'try' utilities
3644 (getSourceStamp): run in a tree, find out the baserev+patch
3645 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3646 implemented for SVN and Darcs, still working on Arch. I don't know
3647 how to make CVS work yet.
3649 * docs/buildbot.texinfo: document the 'buildbot' command-line
3650 tool, including the not-yet-implemented 'try' feature, and the
3651 in-flux .buildbot/ options directory.
3653 2005-07-20 Brian Warner <warner@lothar.com>
3655 * buildbot/locks.py: added temporary id() numbers to Lock
3656 descriptions, to track down a not-really-sharing-the-Lock bug
3658 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3660 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3661 needed for python2.2 compatibility
3662 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3663 are from the __future__
3665 2005-07-19 Brian Warner <warner@lothar.com>
3667 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3668 message when schedulers use unknown builders
3670 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3671 SlaveLock('name') and MasterLock('name') are distinct
3673 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3674 c['schedulers'] in such a way that we can actually accept
3676 * buildbot/test/test_config.py: check it
3678 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3679 utility method to *all* the Schedulers
3680 (Periodic.listBuilderNames): same
3682 * docs/buildbot.texinfo (Interlocks): update chapter to match
3685 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3686 to make sure that c['sources'], c['schedulers'], and c['status']
3687 are all lists of the appropriate objects, and that the Schedulers
3688 all point to real Builders
3689 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3690 'listBuilderNames' utility method to support this
3691 * buildbot/scheduler.py: implement the utility method
3692 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3694 * docs/buildbot.texinfo: add some @cindex entries
3696 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3697 if it wasn't already set: most tla commands will fail unless one
3699 (Arch.createRepository): and disable bazaar's revision cache, since
3700 they cause test failures (the multiple repositories we create all
3701 interfere with each other through the cache)
3703 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3704 bring it properly up to date with twisted-2.0 test guidelines
3706 * buildbot/master.py (BuildMaster): remove references to old
3707 'interlock' module, this caused a bunch of post-merge test
3709 * buildbot/test/test_config.py: same
3710 * buildbot/process/base.py (Build): same
3712 * buildbot/test/test_slaves.py: stubs for new test case
3714 * buildbot/scheduler.py: add test-case-name tag
3715 * buildbot/test/test_buildreq.py: same
3717 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3718 unnecessary init code
3719 (Bot.remote_setBuilderList): match it
3721 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3723 * buildbot/changes/mail.py (parseSyncmail): update comment
3725 * buildbot/test/test_slavecommand.py: disable Shell tests on
3726 platforms that don't suport IReactorProcess
3728 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3729 all places where we open logfiles. It causes OS-X to open the file
3730 in some weird mode that that prevents us from mixing reads and
3731 writes to the same filehandle, which we depend upon to implement
3732 _generateChunks properly. This change doesn't appear to break
3733 win32, on which "b" and "t" are treated differently but a missing
3734 flag seems to be interpreted as "t".
3736 2005-07-18 Brian Warner <warner@lothar.com>
3738 * buildbot/slave/commands.py (ShellCommand): overhaul
3739 error-handling code, to try and make timeout/interrupt work
3740 properly, and make win32 happier
3741 * buildbot/test/test_slavecommand.py: clean up, stop using
3742 reactor.iterate, add tests for timeout and interrupt
3743 * buildbot/test/sleep.py: utility for a new timeout test
3745 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3746 code from the local-usebranches branch
3748 2005-07-17 Brian Warner <warner@lothar.com>
3750 * buildbot/process/process_twisted.py
3751 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3752 minutes, to match the other twisted BuildFactories, and don't
3753 excuse failures in c/qt/win32 reactors any more.
3755 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3756 'freebsd' builders, since the buildslaves have been unavailable
3759 2005-07-13 Brian Warner <warner@lothar.com>
3761 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3762 build-on-branch feature
3764 * buildbot/process/step.py (Darcs.__init__): add base_url and
3765 default_branch arguments, just like SVN
3766 (Arch.__init__): note that the version= argument is really the
3769 * buildbot/slave/commands.py (SourceBase): keep track of the
3770 repository+branch that was used for the last checkout in
3771 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3772 match, we clobber the directory and perform a fresh checkout
3773 rather than trying to do an in-place update. This should protect
3774 us against trying to get to branch B by doing an update in a tree
3775 obtained from branch A.
3776 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3777 (SVN.setup): same, just the svnurl
3778 (Darcs.setup): same, just the repourl
3779 (Arch.setup): same, arch coordinates (url), version, and
3780 buildconfig. Also pull the buildconfig from the args dictionary,
3781 which we weren't doing before, so the build-config was effectively
3783 (Arch.sourcedirIsUpdateable): don't try to update when we're
3784 moving to a specific revision: arch can't go backwards, so it is
3785 safer to just clobber the tree and checkout a new one at the
3787 (Bazaar.setup): same sourcedata as Arch
3789 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3790 use maybeWait, to work with twisted-1.3.0 and twcompat
3791 (Dependencies.testRun_Pass): same
3793 * buildbot/test/test_vc.py: rearrange, cleanup
3795 * buildbot/twcompat.py: add defer.waitForDeferred and
3796 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3797 can work under twisted-1.3.0 .
3799 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3800 now created at setUp time. This increases the runtime of the test
3801 suite considerably (from 91 seconds to 151), but it removes the
3802 need for an offline tarball, which should solve a problem I've
3803 seen where the test host has a different version of svn than the
3804 tarball build host. The new code also validates that mode=update
3805 really picks up recent commits. This approach will also make it
3806 easier to test out branches, because the code which creates the VC
3807 branches is next to the code which uses them. It will also make it
3808 possible to test some change-notification hooks, by actually
3809 performing a VC commit and watching to see the ChangeSource get
3812 2005-07-12 Brian Warner <warner@lothar.com>
3814 * docs/buildbot.texinfo (SVN): add branches example
3815 * docs/Makefile (buildbot.ps): add target for postscript manual
3817 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3818 * buildbot/test/test_locks.py: same
3820 * buildbot/process/step.py (Darcs): comment about default branches
3822 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3823 c['interlocks'] in the config file, complain if it is present.
3824 Scan all locks in c['builders'] to make sure the Locks they use
3826 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3827 add some tests to check for non-uniquely-named Locks
3828 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3829 since the unique-Lock validation code requires it now
3831 * buildbot/locks.py: fix test-case-name
3833 * buildbot/interlock.py: remove old file
3835 2005-07-11 Brian Warner <warner@lothar.com>
3837 * buildbot/test/test_interlock.py: rename to..
3838 * buildbot/test/test_locks.py: .. something shorter
3840 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3841 versions (after 2.0.1) changed internet.TCPClient to shut down the
3842 connection in stopService. Change the code to handle this
3845 * buildbot/process/base.py (Build): handle whole-Build locks
3846 * buildbot/process/builder.py (Builder.compareToSetup): same
3847 * buildbot/test/test_interlock.py: make tests work
3849 * buildbot/process/step.py (BuildStep.startStep): complain if a
3850 Step tries to claim a lock that's owned by its own Build
3851 (BuildStep.releaseLocks): typo
3853 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3854 file reloads don't replace unchanged Builders
3856 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3857 rewrite to cover new Locks instead of old c['interlocks']
3858 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3862 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3863 start the master and connect the buildslave
3865 * buildbot/process/step.py (FailingDummy.done): finish with a
3866 FAILURE status rather than raising an exception
3868 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3869 stringify a BuildRequest.reason that is None
3871 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3873 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3874 allow scheduler.Dependent to work
3875 * buildbot/buildset.py (BuildSet): set .reason and .results
3877 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3878 slaves, to make the test stop hanging. It still fails, of course,
3879 because I haven't even started to implement Locks.
3881 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3883 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3884 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3885 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3886 (Dependent): new class for downstream build dependencies
3887 * buildbot/test/test_dependencies.py: tests (still failing)
3889 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3891 2005-07-07 Brian Warner <warner@lothar.com>
3893 * buildbot/test/runutils.py (RunMixin): factored this class out..
3894 * buildbot/test/test_run.py: .. from here
3895 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3896 added new buildbot.locks tests (which all hang right now)
3897 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3898 * buildbot/process/step.py: claim/release per-BuildStep locks
3900 * docs/Makefile: add 'buildbot.html' target
3902 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3903 interpreted as "HEAD", so that all VC steps can accept branch=None
3904 and have it mean the "default branch".
3906 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3908 2005-07-07 Brian Warner <warner@lothar.com>
3910 * docs/examples/twisted_master.cfg: update to match current usage
3912 * docs/buildbot.texinfo (System Architecture): comment out the
3913 image, it doesn't exist yet and just screws up the HTML manual.
3915 2005-07-05 Brian Warner <warner@lothar.com>
3917 * debian/.cvsignore: oops, missed one. Removing leftover file.
3919 2005-06-17 Brian Warner <warner@lothar.com>
3921 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3922 changed its output in 1.2.0, don't mistakenly think that the
3923 subversion we find isn't capable of supporting our tests.
3925 * debian/*: remove the debian/ directory and its contents, to make
3926 life easier for the proper Debian maintainer
3928 * Makefile (release): same
3930 2005-06-07 Brian Warner <warner@lothar.com>
3932 * everything: create a distinct SourceStamp class to replace the
3933 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3934 Changed the signature of Source.startVC to include the revision
3935 information (instead of passing it through self.args). Implement
3936 branches for SVN (now only Darcs/Git is missing support). Add more
3939 2005-06-06 Brian Warner <warner@lothar.com>
3941 * everything: rearrange build scheduling. Create a new Scheduler
3942 object (configured in c['schedulers'], which submit BuildSets to a
3943 set of Builders. Builders can now use multiple slaves. Builds can
3944 be run on alternate branches, either requested manually or driven
3945 by changes. This changed some of the Status classes. Interlocks
3946 are out of service until they've been properly split into Locks
3947 and Dependencies. treeStableTimer, isFileImportant, and
3948 periodicBuild have all been moved from the Builder to the
3950 (BuilderStatus.currentBigState): removed the 'waiting' and
3951 'interlocked' states, removed the 'ETA' argument.
3953 2005-05-24 Brian Warner <warner@lothar.com>
3955 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3956 erroneously abandons the connection (in clientConnectionFailed)
3957 for non-UserErrors, which means that if we lose the connection due
3958 to a network problem or a timeout, we'll never try to reconnect.
3959 Fix this by not upcalling to the buggy parent method. Note:
3960 twisted-2.0 fixes this, but the function only has 3 lines so it
3961 makes more sense to copy it than to try and detect the buggyness
3962 of the parent class. Fixes SF#1207588.
3964 * buildbot/changes/changes.py (Change.branch): doh! Add a
3965 class-level attribute to accomodate old Change instances that were
3966 pickled before 0.6.5 (where .branch was added for new Changes).
3967 This fixes the exception that occurs when you try to look at an
3968 old Change (through asHTML).
3970 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3973 2005-05-23 Brian Warner <warner@lothar.com>
3975 * buildbot/__init__.py (version): release 0.6.6
3977 2005-05-23 Brian Warner <warner@lothar.com>
3979 * NEWS: update for 0.6.6 release
3980 * debian/changelog: same
3982 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3983 before starting: this was done by twistd back when we spawned it,
3984 now that we're importing the pieces and running them in the
3985 current process, we have to do it ourselves. This allows
3986 master.cfg to import files from the same directory without
3987 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3988 Stichele for the catch.
3989 (Options.opt_version): Add a --version command (actually, just make
3990 the existing --version command emit Buildbot's version too)
3992 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3993 fix to make this behave like other LogFiles, this time to handle
3994 existing LogFiles on disk. (add the missing .upgrade method)
3995 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3997 2005-05-21 Brian Warner <warner@lothar.com>
3999 * buildbot/test/test_runner.py (Create.testMaster): match the
4000 rawstring change in runner.py:masterTAC
4002 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4003 TwistedWords is installed
4004 * buildbot/test/test_status.py: same, with TwistedMail
4006 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4007 some old, deprecated, and removed config keys). This should enable
4008 you to use the base buildbot functionality with Twisted-2.0.0 when
4009 you don't also have TwistedWeb and TwistedWords installed
4011 2005-05-20 Brian Warner <warner@lothar.com>
4013 * buildbot/scripts/runner.py (run): call sendchange(), not
4014 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4015 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4016 (stop): don't wait for process to die when sending SIGHUP
4017 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4018 directory name gets interpreted, which you don't want
4021 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4024 2005-05-18 Brian Warner <warner@lothar.com>
4026 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4028 2005-05-18 Brian Warner <warner@lothar.com>
4030 * README: update for 0.6.5
4031 * debian/changelog: same
4033 * buildbot/changes/changes.py: rename tag= to branch=, since
4034 that's how we're using it, and my design for the upcoming "build a
4035 specific branch" feature wants it. also, tag= was too CVS-centric
4036 * buildbot/changes/mail.py (parseSyncmail): same
4037 * buildbot/process/base.py (Build.isBranchImportant): same
4038 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4039 * docs/buildbot.texinfo (Attributes of Changes): same
4041 * NEWS: update tag=, update for upcoming release
4043 2005-05-17 Brian Warner <warner@lothar.com>
4045 * buildbot/scripts/runner.py (stop): actually poll once per
4046 second, instead of re-killing the poor daemon once per second.
4047 Sleep briefly (0.1s) before the first poll, since there's a good
4048 chance we can avoid waiting the full second if the daemon shuts
4049 down quickly. Also remove the sys.exit() at the end.
4050 (start): remove the unneighborly sys.exit()
4052 * Makefile: improve permission-setting to not kick Arch so badly
4054 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4055 default --keepalive=600, since it doesn't hurt very much, and it's
4056 a hassle to discover that you need it.
4057 * buildbot/test/test_runner.py (Create.testSlave): test it
4059 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4060 IRC bot about EXCEPTION
4062 * buildbot/status/client.py (PBListener): upcall more correctly
4064 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4065 an exception mark the overall build with EXCEPTION, not SUCCESS
4067 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4069 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4070 * Makefile: update some release-related stuff
4072 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4073 gets called when there isn't actually an active process, just end
4074 the Command instead of blowing up. I don't know how it gets into
4075 this state, but the twisted win32 buildslave will sometimes hang,
4076 and when it shakes its head and comes back, it thinks it's still
4077 running a Command. The next build causes this command to be
4078 interrupted, but the lack of self.process.pid breaks the interrupt
4081 * NEWS: document changes since the last release
4083 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4084 look for Makefile.buildbot instead of a bare Makefile . The
4085 'buildbot start' does not install this file, so you have to
4086 manually copy it if you want to customize startup behavior.
4087 (createMaster): change 'buildbot master' command to create
4088 Makefile.sample instead of Makefile, to create master.cfg.sample
4089 instead of master.cfg (requiring you to copy it before the
4090 buildmaster can be started). Both sample files are kept up to
4091 date, i.e. they are overwritten if they have been changed. The
4092 'buildbot.tac' file is *not* overwritten, but if the new contents
4093 don't match the old, a 'buildbot.tac.new' file is created and the
4094 user is warned. This seems to be a much more sane way to handle
4095 startup files. Also, don't sys.exit(0) when done, so we can run
4096 unit tests against it.
4097 (createSlave): same. Don't overwrite the sample info/ files.
4098 * buildbot/scripts/sample.mk: remove. the contents were pulled
4099 into runner.py, since they need to match the behavior of start()
4103 * docs/buildbot.texinfo (Launching the daemons): document it
4104 * buildbot/test/test_runner.py (Create): test it
4106 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4107 version that can handle string-in-string tests, because otherwise
4108 python-2.2 fails the tests. It'd be tremendous if Trial's test
4109 took two strings under 2.2 too.
4111 * everything: fixed all deprecation warnings when running against
4112 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4113 few that come from Twisted itself). This involved putting most of
4114 the Twisted-version specific code in the new buildbot.twcompat
4115 module, and creating some abstract base classes in
4116 buildbot.changes.base and buildbot.status.base (which might be
4117 useful anyway). __implements__ is a nuisance and requires an ugly
4118 'if' clause everywhere.
4120 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4121 delay before finishing the test: it seems that smtp.sendmail
4122 doesn't hang up on the server, so we must wait a moment so it can
4123 hang up on us. This removes the trial warning about an unclean
4126 2005-05-16 Brian Warner <warner@lothar.com>
4128 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4129 tuple of (delay, repeats).
4130 * buildbot/test/test_vc.py (Retry): test it
4131 * docs/buildbot.texinfo (Source Checkout): document it
4132 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4133 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4134 doVCFull() are handled by re-trying the checkout (after a delay)
4135 some number of times.
4136 (ShellCommand._startCommand): make header lines easier to read
4138 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4140 (WebTest.test_logfile): make sure master gets shut down, silences
4141 some "unclean reactor" test errors
4143 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4144 reactor once after shutdown, something in certain versions of
4145 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4146 fails, svn-trunk is ok.
4148 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4149 second win32 error message
4151 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4152 validating the ETA, so the tests don't fail on slow systems
4154 2005-05-15 Brian Warner <warner@lothar.com>
4156 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4157 the new LogFile class, so upgrading works properly
4158 (LogFileProducer.resumeProducing): survive resumeProducing after
4159 we've exhausted the chunkGenerator
4161 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4163 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4164 (Log.testUpgrade): same
4166 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4167 Builds and logs with a cron job.
4169 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4170 of the old non-offline LogFile, added code to upgrade these to
4171 new-style contents-live-on-disk instances at load time (in a way
4172 that doesn't invalidate the old Build pickles, so upgrading to
4173 0.6.5 is not a one-way operation). Got rid of everything related
4175 (LogFile.__init__): create LogFiles with the parent step status,
4176 the log's name, and a builder-relative filename where it can keep
4177 the contents on disk.
4178 (LogFile.hasContents): new method, clients are advised to call it
4179 before getText or getChunks and friends. If it returns False, the
4180 log's contents have been deleted and getText() will raise an
4182 (LogFile.getChunks): made it a generator
4183 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4184 Consumer (except one that takes chunks instead of strings). This
4185 enables streaming of very large logfiles without storing the whole
4187 (BuildStatus.generateLogfileName): create names like
4188 12-log-compile-output, with a _0 suffix if required to be unique
4189 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4190 or earlier) logfiles into new-style ones
4191 (BuilderStatus): remove everything related to 'stub' builds. There
4192 is now only one build cache, and we don't strip logs from old
4194 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4195 since we no longer fight to keep it in the cache
4197 * buildbot/status/html.py (TextLog.render_GET): use a
4198 ChunkConsumer to stream the log entries efficiently.
4199 (ChunkConsumer): wrapper which consumes chunks and writes
4202 * buildbot/test/test_twisted.py (Parse.testParse): use a
4203 LogFile-like object instead of a real one
4205 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4206 (Log.testMerge3): validate more merge behavior
4207 (Log.testChunks): validate LogFile.getChunks
4208 (Log.testUpgrade): validate old-style LogFile upgrading
4209 (Log.testSubscribe): validate LogFile.subscribe
4210 (Log.testConsumer): validate LogFile.subscribeConsumer
4212 * buildbot/interfaces.py (IStatusLogStub): remove
4213 (IStatusLog.subscribeConsumer): new method
4214 (IStatusLog.hasContents): new method
4215 (IStatusLogConsumer): describes things passed to subscribeConsumer
4217 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4218 the log contents if it does not have any contents.
4219 (StatusResourceBuildStep.body): same
4220 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4222 2005-05-14 Brian Warner <warner@lothar.com>
4224 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4225 timeouts to try and make the windows metabuildslave not hang
4227 2005-05-13 Mike Taylor <bear@code-bear.com>
4229 * buildbot/slave/commands.py (rmdirRecursive): added a check
4230 to ensure the path passed into rmdirRecursive actually exists.
4231 On win32 a non-existant path would generate an exception.
4233 2005-05-13 Brian Warner <warner@lothar.com>
4235 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4236 shutil.rmtree which behaves correctly on windows in the face of
4237 files that you have to chmod before deleting. Thanks to Bear at
4238 the OSAF for the routine.
4239 (SourceBase.doClobber): use rmdirRecursive
4241 2005-05-12 Brian Warner <warner@lothar.com>
4243 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4244 method generate chunks instead of returning a big list. This
4245 allows the same method to be used for both old LogFile and new
4247 (OfflineLogFile.getText): use the generator
4248 (OfflineLogFile.subscribe): same
4249 * buildbot/status/html.py (TextLog.resumeProducing): same
4250 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4252 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4253 point out that OfflineLogFile does not currently work with
4254 html.Waterfall . Fixing this is high-priority.
4256 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4257 apparently windows defaults to using stdout
4259 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4260 better message on failure so I can figure out the win32 problem
4262 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4263 log messages to include more useful copies of the command being
4264 run, the argv array, and the child command's environment.
4265 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4267 2005-05-11 Brian Warner <warner@lothar.com>
4269 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4271 * Makefile: update the deb-snapshot version
4273 * docs/buildbot.texinfo: move all .xhtml docs into a new
4274 .texinfo-format document, adding a lot of material in the process.
4275 This is starting to look like a real user's manual. Removed all
4276 the Lore-related files: *.xhtml, *.css, template.tpl .
4277 * docs/Makefile: simple makefile to run 'makeinfo'
4278 * buildbot/scripts/sample.cfg: rearrange slightly
4279 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4281 2005-05-10 Brian Warner <warner@lothar.com>
4283 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4284 different name for the internal twistw module, handle it.
4286 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4287 * setup.py: .. and stop trying to install it
4289 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4290 'git'), the new linux kernel VC system (http://kernel.org/git/).
4291 Thanks to Brandon Philips for the patch.
4292 * buildbot/slave/commands.py (Git): same
4294 2005-05-06 Brian Warner <warner@lothar.com>
4296 * buildbot/status/builder.py (OfflineLogFile): replace the default
4297 LogFile with a form that appends its new contents to a disk file
4298 as they arrive. The complete log data is never kept in RAM. This
4299 is the first step towards handling very large (100MB+) logfiles
4300 without choking quite so badly. (The other half is
4301 producer/consumer on the HTML pages).
4302 (BuildStepStatus.addLog): use OfflineLogFile by default
4303 (BuildStatus.getLogfileName): helper code to give the
4304 OfflineLogFile a filename to work with
4306 * buildbot/test/test_status.py (Results.testAddResults): update
4307 tests to handle new asserts
4308 * buildbot/test/test_vc.py (Patch.doPatch): same
4309 * buildbot/test/test_steps.py (BuildStep.setUp): same
4311 2005-05-05 Brian Warner <warner@lothar.com>
4313 * buildbot/scripts/runner.py (start): if there is no Makefile,
4314 launch the app by importing twistd's internals and calling run(),
4315 rather than spawning a new twistd process. This stands a much
4316 better chance of working under windows.
4317 (stop): kill the process with os.kill instead of spawning
4318 /bin/kill, again to reduce the number of external programs which
4319 windows might not have in the PATH. Also wait up to 5 seconds for
4320 the process to go away, allowing things like 'buildbot stop;
4321 buildbot start' to be reliable in the face of slow shutdowns.
4323 * buildbot/master.py (Dispatcher.__getstate__): remove old
4324 .tap-related methods
4325 (BuildMaster.__getstate__): same
4327 * buildbot/slave/bot.py (makeService): same
4328 (Options.longdesc): same
4329 * buildbot/scripts/runner.py: copy over some old mktap option text
4331 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4332 'buildbot master' now creates a buildbot.tac file, so there is no
4333 longer a create-instance/save/reload sequence. mktap is dead, long
4335 * buildbot/scripts/sample.mk: use twistd -y, not -f
4336 * buildbot/test/test_config.py: remove mktap-based test
4337 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4338 * README: don't reference mktap
4340 * docs/source.xhtml: document some of the attributes that Changes
4343 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4345 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4346 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4347 * buildbot/changes/changes.py (Change)
4348 * buildbot/changes/mail.py (parseSyncmail)
4349 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4351 * buildbot/process/base.py (Build.isTagImportant)
4355 2005-05-04 Brian Warner <warner@lothar.com>
4357 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4358 connection after sending the change, so that unit tests don't
4359 complain about sockets being left around
4361 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4362 exception in phase=0 rendering
4363 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4365 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4367 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4368 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4369 and configuring builders with tuples.
4370 * buildbot/test/test_config.py: stop testing compatibility with
4371 deprecated config keys
4372 * buildbot/test/test_run.py: same
4374 2005-05-03 Brian Warner <warner@lothar.com>
4376 * contrib/arch_buildbot.py: survive if there are no logfiles
4377 (username): just use a string, os.getlogin isn't reliable
4379 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4380 so 'buildbot sendchange' actually works. The earlier test only
4381 covered the internal (non-reactor-running) form.
4383 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4384 script to notify the buildmaster about changes
4386 * buildbot/scripts/runner.py (sendchange): new command to send a
4387 change to a buildbot.changes.pb.PBChangeSource receiver.
4388 * buildbot/test/test_changes.py (Sender): test it
4390 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4391 after any reading of the config file, not just when we do it in
4392 startService. This makes some tests a bit cleaner.
4394 * buildbot/changes/pb.py: add some log messages
4396 * buildbot/process/base.py (Build.startBuild): fix a bug that
4397 caused an exception when the build terminated in the very first
4399 (Build.stepDone): let steps return a status of EXCEPTION. This
4400 terminates the build right away, and sets the build's overall
4401 status to EXCEPTION too.
4402 * buildbot/process/step.py (BuildStep.failed): return a status of
4403 EXCEPTION when that is what has happened.
4405 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4406 implement this, allowing Arch-based projects to get precise
4407 checkouts instead of always using the latest code
4408 (Bazaar): create variant of Arch to let folks use baz instead of
4409 tla. Requires a new buildslave too.
4410 * buildbot/slave/commands.py (Arch): add 'revision' argument
4411 (Bazaar): create variant of Arch that uses baz instead of tla.
4412 Remove the code that extracts the archive name from the
4413 register-archive output, since baz doesn't provide it, and require
4414 the user provide both the archive name and its location.
4415 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4417 2005-05-02 Brian Warner <warner@lothar.com>
4419 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4420 thanks to Nick Trout.
4422 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4423 deals better with source Makefile coming from a read-only CVS
4424 checkout. Thanks to Nick Trout for the catch.
4426 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4429 2005-04-28 Brian Warner <warner@lothar.com>
4431 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4433 * debian/changelog: update for 0.6.4
4435 2005-04-28 Brian Warner <warner@lothar.com>
4437 * README.w32: add a checklist of steps for getting buildbot
4439 * MANIFEST.in: include it in the tarball
4443 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4444 broken .tap files from 0.6.3 by getting rid of .services,
4445 .namedServices, and .change_svc at load time.
4447 2005-04-27 Brian Warner <warner@lothar.com>
4449 * NEWS: update in preparation for new release
4451 * buildbot/test/test_config.py (Save.testSave): don't pull in
4452 twisted.scripts.twistd, we don't need it and it isn't for windows
4455 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4456 accomodate win32 which can't do atomic-rename
4458 2005-04-27 Brian Warner <warner@lothar.com>
4460 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4461 timeouts to help the slow metabuildbot not flunk them so much
4462 (Disconnect.testBuild3): same
4463 (Disconnect.testBuild4): same
4464 (Disconnect.testInterrupt): same
4466 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4467 setup, it was completely broken for new buildmasters (those which
4468 did not have a 'change.pck' already saved. Thanks to Paul Warren
4469 for catching this (embarrassing!) bug.
4470 (Dispatcher.__getstate__): don't save our registered avatar
4471 factories, since they'll be re-populated when the config file is
4473 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4474 tests (since the real mktap-generated BuildMaster doesn't save
4476 (BuildMaster.__getstate__): don't save any service children,
4477 they'll all be re-populated when the config file is re-read.
4478 * buildbot/test/test_config.py (Save.testSave): test for this
4480 2005-04-26 Brian Warner <warner@lothar.com>
4482 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4483 rendered with Blender.. looks a bit nicer.
4484 * buildbot/docs/images/icon.blend: add the Blender file for it
4486 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4487 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4488 running under windows. This appears to be the best way to allow
4489 BuildSteps to do something normal like 'trial -v buildbot.test' or
4490 'make foo' and still expect it to work. The idea is to make the
4491 BuildSteps look as much like what a developer would type when
4492 compiling or testing the tree by hand. This approach probably has
4493 problems when there are spaces in the arguments, so if you've got
4494 windows buildslaves, you'll need to pay close attention to your
4497 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4498 timezone to the timestamp column.
4499 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4501 * buildbot/scripts/runner.py (loadOptions): do something sane for
4502 windows, I think. We use %APPDATA%/buildbot instead of
4503 ~/.buildbot, but we still search everywhere from the current
4504 directory up to the root for a .buildbot/ subdir. The "is it under
4505 $HOME" security test was replaced with "is it owned by the current
4506 user", which is only performed under posix.
4507 * buildbot/test/test_runner.py (Options.testFindOptions): update
4508 tests to match. The "is it owned by the current user" check is
4509 untested. The test has been re-enabled for windows.
4511 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4512 any "\n" in the expected output with the platform-specific line
4513 separator. Make this separator "\r\n" on PTYs under unix, they
4514 seem to do that and I don't know why
4516 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4517 windows for now, I don't know what ~/.buildbot/ should mean there.
4519 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4520 win32 compatibility, don't use "/tmp"
4521 (Basedir.testChangeBuilddir): remove more unixisms
4523 2005-04-26 Brian Warner <warner@lothar.com>
4525 * buildbot/test/test_control.py (Force.rmtree): python2.2
4526 compatibility, apparently its shutil.rmtree ignore_errors=
4527 argument is ignored.
4528 * buildbot/test/test_run.py (Run.rmtree): same
4529 (RunMixin.setUp): same
4531 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4534 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4535 'substring in string' operator, must use string.find(substr)!=-1
4536 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4537 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4539 * buildbot/scripts/runner.py (loadOptions): add code to search for
4540 ~/.buildbot/, a directory with things like 'options', containing
4541 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4542 the current directory, your $HOME directory, or anywhere
4543 inbetween, as long as you're somewhere inside your home directory.
4544 (debugclient): look in ~/.buildbot/options for master and passwd
4545 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4546 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4548 * buildbot/status/client.py (makeRemote): new approach to making
4549 IRemote(None) be None, which works under Twisted-2.0
4550 * buildbot/test/test_status.py (Client.testAdaptation): test it
4552 * buildbot/status/builder.py (Status.builderAdded): when loading a
4553 pickled BuilderStatus in from disk, set its name after loading.
4554 The config file might have changed its name (but not its
4555 directory) while it wasn't looking.
4557 * buildbot/process/builder.py (Builder.attached): always return a
4558 Deferred, even if the builder was already attached
4559 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4561 2005-04-25 Brian Warner <warner@lothar.com>
4563 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4564 category-related exception when announcing a build has finished
4566 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4567 reference no-longer-existent changemaster.sources
4568 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4570 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4573 2005-04-25 Brian Warner <warner@lothar.com>
4575 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4577 * debian/changelog: update for 0.6.3
4579 2005-04-25 Brian Warner <warner@lothar.com>
4581 * MANIFEST.in: make sure debug.glade is in the tarball
4583 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4585 * NEWS: update for the imminent 0.6.3 release
4587 * buildbot/status/html.py (HtmlResource.content): make the
4588 stylesheet <link> always point at "buildbot.css".
4589 (StatusResource.getChild): map "buildbot.css" to a static.File
4590 containing whatever css= argument was provided to Waterfall()
4591 (Waterfall): provide the "classic" css as the default.
4592 * docs/waterfall.classic.css: move default CSS from here ..
4593 * buildbot/status/classic.css: .. to here
4595 * MANIFEST.in: make sure classic.css is included in the tarball
4596 * setup.py: and that it is installed too, under buildbot/status/
4598 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4599 the module level, because buildbot.tap files from 0.6.2 don't have
4600 it in their attribute dictionary.
4602 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4603 really exists at startup, might save some confusion somewhere.
4605 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4607 * docs/waterfall.classic.css:
4608 add a stylesheet that's almost the same as the "classic"
4611 * buildbot/status/builder.py:
4612 add EXCEPTION as a result - this is a problem for the bot
4613 maintainer, not a build problem for the changers
4614 * buildbot/process/step.py:
4615 use EXCEPTION instead of FAILURE for exceptions
4616 * buildbot/status/html.py:
4617 add build_get_class to get a class out of a build/buildstep
4618 finish naming the classes
4619 split out sourceNames to changeNames and builderNames so we
4620 can style them separately
4621 * docs/config.xhtml:
4622 finish documenting classes as they are right now
4624 * buildbot/status/html.py:
4625 name the classes as we agreed on IRC
4626 * docs/config.xhtml:
4629 * buildbot/status/html.py:
4630 same for cssclass->class_
4632 * buildbot/status/html.py:
4633 as decided on IRC, use class_ for the "class" attribute to not
4634 conflict with the class keyword, and clean up the messy **{} stuff.
4636 * buildbot/status/mail.py:
4637 put back "builders" argument, and fix docstring, because the
4638 code *ignores* builders listed in this argument
4640 * buildbot/process/builder.py:
4641 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4643 * docs/config.xhtml:
4644 describe the category argument for builders
4646 * buildbot/status/builder.py:
4647 Fix a silly bug due to merging
4649 * buildbot/process/builder.py:
4650 remove category from the process Builder ...
4651 * buildbot/status/builder.py:
4652 ... and add it to BuilderStatus instead.
4653 Set category on unpickled builder statuses, they might not have it.
4654 * buildbot/master.py:
4655 include category when doing builderAdded
4656 * buildbot/status/mail.py:
4657 return None instead of self for builders we are not interested in.
4658 * buildbot/test/test_run.py:
4659 fix a bug due to only doing deferredResult on "dummy" waiting
4660 * buildbot/test/test_status.py:
4661 add checks for the Mail IStatusReceiver returning None or self
4663 * buildbot/status/html.py:
4664 fix testsuite by prefixing page title with BuildBot
4666 * buildbot/status/builder.py:
4667 have .category in builder status ...
4668 * buildbot/process/builder.py:
4669 ... and set it from Builder
4670 * buildbot/status/html.py:
4671 make .css a class variable
4672 * buildbot/test/test_status.py:
4673 write more tests to cover our categories stuff ...
4674 * buildbot/status/mail.py:
4675 ... and fix the bug that this uncovered
4677 * buildbot/changes/mail.py:
4678 * buildbot/changes/pb.py:
4679 * buildbot/master.py:
4680 * buildbot/process/base.py:
4681 * buildbot/process/factory.py:
4682 * buildbot/process/interlock.py:
4683 * buildbot/process/step.py:
4684 * buildbot/process/step_twisted.py:
4685 * buildbot/slave/commands.py:
4686 * buildbot/status/builder.py:
4687 * buildbot/status/client.py:
4688 * buildbot/status/html.py:
4689 * buildbot/status/mail.py:
4690 * buildbot/status/progress.py:
4691 * buildbot/test/test_changes.py:
4692 * buildbot/test/test_config.py:
4693 * buildbot/test/test_control.py:
4694 * buildbot/test/test_interlock.py:
4695 * buildbot/test/test_maildir.py:
4696 * buildbot/test/test_mailparse.py:
4697 * buildbot/test/test_run.py:
4698 * buildbot/test/test_slavecommand.py:
4699 * buildbot/test/test_status.py:
4700 * buildbot/test/test_steps.py:
4701 * buildbot/test/test_twisted.py:
4702 * buildbot/test/test_util.py:
4703 * buildbot/test/test_vc.py:
4704 * buildbot/test/test_web.py:
4706 add test-case-name at the top of a whole set of files
4708 * buildbot/status/builder.py:
4709 keep order of addition when getting builder names
4710 * buildbot/status/words.py:
4711 * buildbot/test/test_run.py:
4712 add test for getBuilderNames
4714 * buildbot/process/base.py:
4715 * buildbot/process/step.py:
4716 * buildbot/status/builder.py:
4717 * buildbot/status/html.py:
4718 make buildbot css-able
4719 replace the color code for purple with purple, don't understand
4720 why it wasn't purple to start with
4722 * buildbot/status/words.py:
4723 ok, so it doesn't look like BuilderStatus.remote is still valid.
4724 Use what waterfall uses instead.
4726 * buildbot/interfaces.py:
4727 * buildbot/status/builder.py:
4728 * buildbot/status/html.py:
4729 * buildbot/status/mail.py:
4730 * buildbot/status/words.py:
4731 * buildbot/test/test_run.py:
4732 use categories everywhere and make it be a list. More sensible
4733 for the future. Also make words actually respect this in
4736 * buildbot/interfaces.py:
4737 add category argument to getBuilderNames
4738 * buildbot/process/builder.py:
4739 * buildbot/status/builder.py:
4740 * buildbot/status/html.py:
4741 * buildbot/status/mail.py:
4742 * buildbot/status/words.py:
4743 * buildbot/test/test_run.py:
4744 move from specifying builders by name to specifying the category
4746 * buildbot/status/html.py:
4747 * buildbot/status/words.py:
4748 add "builders=" to __init__ of status clients so they can
4749 limit themselves to the given list of builders to report on
4751 * buildbot/status/html.py: set the title to the product name
4753 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4755 * buildbot/interfaces.py:
4756 * buildbot/status/builder.py:
4757 more documentation. Hm, not sure if ChangeLog entries make sense
4760 2005-04-23 Brian Warner <warner@lothar.com>
4762 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4764 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4766 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4767 the sub-commands that log buildmaster status to stdout and to a
4768 GUI window, respectively.
4770 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4771 functionality is working again, but all the step-status and ETA
4772 stuff is missing. Commented out a lot of code pending more
4775 * buildbot/status/client.py: make sure that IRemote(None) is None
4777 * buildbot/changes/changes.py: import defer, oops
4778 (ChangeMaster): remove the .sources list, rely upon the fact that
4779 MultiServices can be treated as sequences of their children. This
4780 cleans up the add/remove ChangeSource routines a lot, as we keep
4781 exactly one list of the current sources instead of three.
4783 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4784 up an empty ChangeMaster at init time.
4785 (BuildMaster.loadChanges): if there are changes to be had from
4786 disk, replace self.change_svc with the new ones. If not, keep
4787 using the empty ChangeMaster set up in __init__.
4788 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4789 instead of a separate list, makes the code a bit cleaner.
4790 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4791 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4792 Extend the test to make sure we can get rid of the sources when
4795 2005-04-22 Brian Warner <warner@lothar.com>
4797 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4798 and info/host files when making the slave directory
4800 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4801 whendone= argument, just return the Deferred and let the caller do
4802 what they want with it.
4803 (Disconnect.testBuild1): wait for shutdownSlave
4804 (Basedir.testChangeBuilddir): new test to make sure changes to the
4805 builddir actually get propagated to the slave
4807 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4808 explicit method, rather than passing the builddir in __init__ .
4809 Make sure to update self.basedir too, this was broken before.
4810 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4811 builders and for ones that have just had their builddir changed.
4812 (BotFactory): add a class-level .perspective attribute, so
4813 BuildSlave.waitUntilDisconnected won't get upset when the
4814 connection hasn't yet been established
4815 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4816 tests can reach through it to inspect the SlaveBuilders
4818 * buildbot/process/base.py (Build.buildException): explain the
4819 log.err with a log.msg
4820 * buildbot/process/builder.py (Builder.startBuild): same
4821 (Builder._startBuildFailed): improve error message
4823 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4824 occurred because we lost the brand-new connection, retry instead
4825 of giving up. If not, it's probably an authorization failure, and
4826 it makes sense to stop trying. Make sure we log.msg the reason
4827 that we're log.err'ing the failure, otherwise test failures are
4828 really hard to figure out.
4830 * buildbot/master.py: change loadConfig() to return a Deferred
4831 that doesn't fire until the change has been fully implemented.
4832 This means any connected slaves have been updated with the new
4833 builddir. This change makes it easier to test the code which
4834 actually implements this builddir-updating.
4835 (BotPerspective.addBuilder): return Deferred
4836 (BotPerspective.removeBuilder): same
4837 (BotPerspective.attached): same
4838 (BotPerspective._attached): same. finish with remote_print before
4839 starting the getSlaveInfo, instead of doing them in parallel
4840 (BotPerspective.list_done): same
4841 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4842 actually calling slave.disconnect()
4843 (BotMaster.addBuilder): same
4844 (BotMaster.removeBuilder): same
4845 (BuildMaster.loadConfig): same
4846 (BuildMaster.loadConfig_Slaves): same
4847 (BuildMaster.loadConfig_Sources): same
4848 (BuildMaster.loadConfig_Builders): same
4849 (BuildMaster.loadConfig_status): same
4851 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4852 a Deferred that fires when the source is finally removed
4854 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4855 the previous tree on win32, where we have to do it synchronously,
4856 make sure we return a Deferred anyway.
4857 (SourceBase.doCopy): same
4859 * buildbot/scripts/runner.py (statusgui): use the text client for
4860 now, while I rewrite the Gtk one
4861 * buildbot/clients/base.py: strip out old code, leaving just the
4862 basic print-message-on-event functionality. I also remove the
4863 ReconnectingPBClientFactory, but it does at least quit when it
4864 loses the connection instead of going silent
4866 2005-04-21 Brian Warner <warner@lothar.com>
4868 * Makefile: minor tweaks
4870 * NEWS: point out deprecation warnings, new features for
4873 * buildbot/master.py (BuildMaster.loadConfig): emit
4874 DeprecationWarnings for Builders defined with tuples. Rearrange
4875 code to facility removal of deprecated configuration keys in the
4878 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4879 'buildbot' command to put a little Makefile in the target that
4880 helps you re-create the buildbot.tap file, start or stop the
4881 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4882 all the files 0600, since they contain passwords.
4883 (start): if there is a Makefile, and /usr/bin/make exists, use
4884 'make start' in preference to a raw twistd command. This lets
4885 slave admins put things like PYTHONPATH variables in their
4886 Makefiles and have them still work when the slave is started with
4887 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4888 be nice to first try the 'make' command and only fall back to
4889 twistd if it fails. TODO: the Makefile's "start" command does not
4890 add the --reactor=win32 argument when running under windows.
4891 (Options.debugclient, Options.statusgui): add sub-commands to launch
4892 the debug client (formerly in contrib/debugclient.py) and the
4893 Gtk status application (currently broken)
4894 * buildbot/clients/debug.py: move from contrib/debugclient.py
4895 * buildbot/clients/debug.glade: same
4897 * buildbot/test/test_trial.py: remove it. This requires some
4898 functionality out of Twisted that isn't there yet, and until then
4899 having it around just confuses things.
4901 * buildbot/test/test_slavecommand.py (Shell): test both with and
4902 without PTYs, and make sure that command output is properly
4903 interleaved in the with-PTY case. I think the without-PTY test
4904 should pass on windows, where we never use PTYs anyway.
4906 2005-04-20 Brian Warner <warner@lothar.com>
4908 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4910 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4912 * NEWS: start creating entries for the next release
4914 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4916 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4917 (WebTest.test_webPathname): same
4918 (WebTest.test_webPathname_port): same
4919 (WebTest.test_waterfall): use the default favicon rather than
4920 rooting around the filesystem for it. Open the expected-icon file
4921 in binary mode, to make win32 tests happier (thanks to Nick Trout
4923 * buildbot/status/html.py (buildbot_icon): win32 portability
4925 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4926 win32-compatibility fixes from Nick Trout, the "file not found" message
4927 is different under windows
4928 (FakeSlaveBuilder.__init__): clean up setup a bit
4929 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4931 2005-04-19 Brian Warner <warner@lothar.com>
4933 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4934 skip-if-repositories-are-unavailable test to not kill the trial
4935 that comes with Twisted-1.3.0
4937 * setup.py: install buildbot.png icon file when installing code
4939 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4940 environment used by the command, at least on the child side.
4942 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4943 this method needs to be added and implemented because it gets
4944 called under heavy load. I don't quite understand the
4945 producer/consumer API enough to write it.
4946 (StatusResource.getChild): add a resource for /favicon.ico
4947 (Waterfall.__init__): add favicon= argument
4948 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4949 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4950 (WebTest.test_webPathname): same
4951 (WebTest.test_webPathname_port): same
4952 * docs/config.xhtml: mention favicon=
4953 * buildbot/buildbot.png: add a default icon, dorky as it is
4955 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4957 * buildbot/master.py:
4958 * buildbot/process/base.py:
4959 * buildbot/process/builder.py:
4960 * buildbot/process/interlock.py:
4961 * buildbot/status/builder.py:
4962 * buildbot/status/html.py:
4963 * buildbot/status/mail.py:
4964 * buildbot/status/words.py:
4965 new documentation while digging through the code
4967 2005-04-17 Brian Warner <warner@lothar.com>
4969 * general: try to fix file modes on all .py files: a+r, a-x,
4970 but let buildbot/clients/*.py be +x since they're tools
4972 * docs/epyrun (addMod): when an import fails, say why
4974 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4976 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4978 * buildbot/process/base.py:
4979 * buildbot/process/builder.py:
4980 * buildbot/status/builder.py:
4981 new documentation while digging through the code
4983 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4985 * buildbot/changes/changes.py:
4986 * buildbot/changes/p4poller.py:
4987 * buildbot/interfaces.py:
4988 * buildbot/process/base.py:
4989 * buildbot/process/builder.py:
4990 * buildbot/process/step.py:
4991 * buildbot/process/step_twisted.py:
4992 * buildbot/slave/bot.py:
4993 * buildbot/slave/commands.py:
4994 * buildbot/status/builder.py:
4995 fix all docstrings to make epydoc happy. In the process of fixing
4996 some, I also moved pieces of docs, and removed some deprecated
4999 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5001 * buildbot/process/builder.py:
5002 * buildbot/process/interlock.py:
5003 * buildbot/process/process_twisted.py:
5004 * buildbot/process/step.py:
5005 BuildProcess -> Build, as it looks like that's what happened
5006 * buildbot/process/base.py:
5007 * buildbot/process/factory.py:
5010 2005-04-17 Brian Warner <warner@lothar.com>
5012 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5013 update compile command to accomodate the Twisted split.. now
5014 instead of './setup.py build_ext -i', you do './setup.py all
5015 build_ext -i', to run build_ext over all sub-projects.
5016 (FullTwistedBuildFactory): same
5017 (TwistedReactorsBuildFactory): same
5019 * buildbot/status/html.py (TextLog.finished): null out self.req
5020 when we're done, otherwise the reference cycle of TextLog to .req
5021 to .notifications to a Deferred to TextLog.stop keeps them from
5022 being collected, and consumes a huge (610MB on pyramid at last
5023 check) amount of memory.
5025 2005-04-11 Brian Warner <warner@lothar.com>
5027 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5028 normalize the VC-repository location.. makes SVN happier with
5029 certain test environments.
5031 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5032 RemoteShellCommand gets its own .env dictionary, so that code in
5033 start() doesn't mutate the original. I think this should fix the
5034 step_twisted.Trial problem where multiple identical components
5035 kept getting added to PYTHONPATH= over and over again.
5037 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5038 adding epydoc-format docstrings to many classes. Thanks to Thomas
5039 Vander Stichele for the patches.
5040 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5041 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5042 * buildbot/slave/bot.py, commands.py, registry.py: same
5044 2005-04-05 Brian Warner <warner@lothar.com>
5046 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5047 preserve timestamps, helps incremental builds of large trees.
5048 Patch from Rene Rivera.
5050 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5051 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5054 2005-04-03 Brian Warner <warner@lothar.com>
5056 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5057 with one dict, apparently exec has some scoping bugs when used
5058 with both global/local dicts. Thanks to Nathaniel Smith for the
5061 2005-04-02 Brian Warner <warner@lothar.com>
5063 * buildbot/process/step_twisted.py (countFailedTests): the new
5064 trial in Twisted-2.0 emits a slightly different status line than
5065 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5066 mistakenly think the test count is unparseable.
5067 (Trial.start): note that for some reason each build causes another
5068 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5069 be fixed but I'm not sure quite where the problem is.
5071 2005-04-01 Brian Warner <warner@lothar.com>
5073 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5074 deferredResult to avoid hangs/warnings under twisted-2.0
5075 (RunMixin.tearDown): same
5076 (RunMixin.shutdownSlave): same
5077 (Disconnect.testIdle1): same
5078 (Disconnect.testBuild2): same: wait one second after the build
5079 finishes for test to really be done.. this should be cleaned up to
5080 avoid wasting that second. Builder.detach uses a callLater(0),
5081 either that should be done in-line (something else needed that
5082 behavior), or it should return a Deferred that fires when the
5083 builder is really offline.
5084 (Disconnect.testBuild3): same
5085 (Disconnect.testDisappear): same
5087 * buildbot/test/test_web.py: rearrange server-setup and teardown
5088 code to remove unclean-reactor warnings from twisted-2.0
5090 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5091 so the tests don't hang under twisted-2.0
5093 2005-03-31 Brian Warner <warner@lothar.com>
5095 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5096 caused a warning each time the master changed our set of builders
5098 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5099 w32, don't unlink the file unless it already exists. Thanks to
5100 Baptiste Lepilleur for the catch.
5101 (BuilderStatus.saveYourself): same
5103 2005-02-01 Brian Warner <warner@lothar.com>
5105 * buildbot/status/html.py (TextLog.getChild): use a /text child
5106 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5107 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5108 logfile as text/plain (no markup, no headers). This replaces the
5109 previous scheme (which used an ?text=1 argument), and gets us back
5110 to a relative link (which works better when the buildbot lives
5111 behind another web server, such as Apache configured as a reverse
5112 proxy). Thanks to Gerald Combs for spotting the problem.
5114 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5117 2004-12-13 Brian Warner <warner@lothar.com>
5119 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5121 * debian/changelog: update for 0.6.2
5122 * NEWS: finalize for 0.6.2
5124 2004-12-11 Brian Warner <warner@lothar.com>
5126 * NEWS: bring it up to date
5128 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5129 detection code. Require some sign of life from the buildmaster
5130 every BotFactory.keepaliveInterval seconds. Provoke this
5131 indication at BotFactory.keepaliveTimeout seconds before the
5132 deadline by sending a keepalive request. We don't actually care if
5133 that request is answered in a timely fashion, what we care about
5134 is that .activity() is called before the deadline. .activity() is
5135 triggered by any PB message from the master (including an ack to
5136 one of the slave's status-update messages). With this new scheme,
5137 large status messages over slow pipes are OK, as long as any given
5138 message can be sent (and thus acked) within .keepaliveTimeout
5139 seconds (which defaults to 30).
5140 (SlaveBuilder.remote_startCommand): record activity
5141 (SlaveBuilder.ackUpdate): same
5142 (SlaveBuilder.ackComplete): same
5143 (BotFactory.gotPerspective): same
5144 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5146 2004-12-09 Brian Warner <warner@lothar.com>
5148 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5151 * buildbot/process/step_twisted.py (Trial._commandComplete):
5152 update self.cmd when we start the 'cat test.log' transfer. Without
5153 this, we cannot interrupt the correct RemoteCommand when we lose
5156 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5157 trying to tell the slave to stop the command if we're already
5158 inactive, or if we no longer have a .remote
5160 * buildbot/process/builder.py (Builder._detached): don't let an
5161 exception in currentBuild.stopBuild() prevent the builder from
5162 being marked offline
5164 2004-12-07 Brian Warner <warner@lothar.com>
5166 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5167 KeyError that happens when you ask for a non-existent Builder, and
5168 translate it into a UsageError.
5170 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5171 losing the slave in the middle of a remote step is handled too
5173 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5174 be a Failure, so be sure to stringify it before using it as the
5175 contents of the 'interrupt' logfile
5176 (RemoteCommand.interrupt): use stringified 'why' in
5177 remote_interruptCommand too, just in case
5179 2004-12-06 Brian Warner <warner@lothar.com>
5181 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5182 instead of 'tla update', which is more efficient in case we've
5183 missed a couple of patches since the last update.
5185 * debian/changelog: update for previous (0.6.1) release. Obviously
5186 this needs to be handled better.
5188 2004-12-05 Brian Warner <warner@lothar.com>
5190 * NEWS: update for stuff since last release
5192 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5193 match the maybeDeferred change in Dispatcher.requestAvatar
5194 * buildbot/changes/pb.py (ChangePerspective.attached): same
5195 * buildbot/status/client.py (StatusClientPerspective.attached): same
5196 * buildbot/process/builder.py (Builder._attached3): same
5197 * buildbot/pbutil.py (NewCredPerspective.attached): same
5199 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5200 the date to the top-most box, if it is not the same as today's
5203 * docs/slave.xhtml: provide a buildslave setup checklist
5205 * docs/source.xhtml (Arch): correct terminology
5207 2004-12-04 Brian Warner <warner@lothar.com>
5209 * buildbot/test/test_slavecommand.py: use sys.executable instead
5210 of hard-coding 'python' for child commands, might help portability
5212 * docs/examples/twisted_master.cfg: update to current usage
5214 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5215 'stop build' command to the IRC bot
5217 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5218 message that broke PBChangeSource
5220 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5221 (SlaveBuilder): make some attributes class-level, remove the old
5222 "update queue" which existed to support resuming a build after the
5223 master connection was lost. Try to reimplement that feature later.
5224 (SlaveBuilder.stopCommand): clear self.command when the
5225 SlaveCommand finishes, so that we don't try to kill a leftover one
5227 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5230 * buildbot/slave/commands.py (SourceBase): set self.command for
5231 all VC commands, so they can be interrupted.
5233 2004-12-03 Brian Warner <warner@lothar.com>
5235 * buildbot/master.py: clean up slave-handling code, to handle
5236 slave-disconnect and multiple-connect better
5237 (BotPerspective): make these long-lasting, exactly one per bot
5238 listed in the config file.
5239 (BotPerspective.attached): if a slave connects while an existing
5240 one appears to still be connected, disconnect the old one first.
5241 (BotPerspective.disconnect): new method to forcibly disconnect a
5242 buildslave. Use some hacks to empty the transmit buffer quickly to
5243 avoid the long (20-min?) TCP timeout that could occur if the old
5244 slave has dropped off the net.
5245 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5246 own their own SlaveStatus objects. Remove .attached/.detached, add
5247 .addSlave/.removeSlave, treat slaves like Builders (config file
5248 parsing sends deltas to the BotMaster). Inform the slave
5249 instances, i.e. the BotPerspective, about addBuilder and
5251 (BotMaster.getPerspective): turns into a single dict lookup
5252 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5253 which gives BotPerspective.attached a chance to disconnect the old
5255 (BuildMaster.loadConfig): add code (disabled) to validate that all
5256 builders use known slaves (listed in c['bots']). The check won't
5257 work with tuple-specified builders, which are deprecated but not
5258 yet invalid, so the check is disabled for now.
5259 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5260 routine, do the add/changed/removed dance with them like we do
5262 (BuildMaster.loadConfig_Sources): move source-config into a
5263 separate routine too
5265 * buildbot/status/builder.py (Status.getSlave): get the
5266 SlaveStatus object from the BotPerspective, not the BotMaster.
5268 * buildbot/test/test_run.py: bunch of new tests for losing the
5269 buildslave at various points in the build, handling a slave that
5270 connects multiple times, and making sure we can interrupt a
5273 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5274 something other than 'Bot' for the Bot object, to make certain
5275 test cases easier to write.
5276 (BuildSlave.waitUntilDisconnected): utility method for testing
5278 2004-11-30 Brian Warner <warner@lothar.com>
5280 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5282 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5283 argument, return a Deferred that always fires with True or False.
5284 I don't use an errback to indicate 'ping failed' so that callers
5285 are free to ignore the deferred without causing spurious errors in
5287 * buildbot/process/builder.py (BuilderControl.ping): implement it
5289 * buildbot/test/test_run.py (Status.testDisappear): test ping
5290 (Status.disappearSlave): fix it
5292 2004-11-30 Brian Warner <warner@lothar.com>
5294 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5295 (IBuilderControl): add .getBuild(num), only works for the current
5296 build, of course, although it might be interesting to offer
5297 something for builds in the .waiting or .interlocked state.
5299 * buildbot/process/base.py (Build): have .stopBuild just do the
5300 interrupt, then let the build die by itself.
5301 (BuildControl): add .stopBuild, and add a point-event named
5302 'interrupt' just after the build so status viewers can tell that
5304 (BuilderControl): add .getBuild
5306 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5307 stops when you kill it, good for testing
5308 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5309 contains the 'reason' text.
5311 * buildbot/status/html.py: Add Stop Build button, if the build can
5312 still be stopped. Send a Redirect (to the top page) one second
5313 later, hopefully long enough for the interrupt to have an effect.
5314 Move make_row() up to top-level to share it between Stop Build and
5317 * buildbot/slave/commands.py: only kill the child process once
5319 * buildbot/test/test_run.py: add testInterrupt
5321 2004-11-29 Brian Warner <warner@lothar.com>
5323 * buildbot/process/base.py: Refactor command interruption. The
5324 Build is now responsible for noticing that the slave has gone
5325 away: Build.lostRemote() interrupts the current step and makes
5326 sure that no further ones will be started.
5328 * buildbot/process/builder.py: When the initial remote_startBuild
5329 message fails, log it: this usually indicates that the slave has
5330 gone away, but we don't really start paying attention until they
5331 fail to respond to the first step's command.
5333 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5334 slave disconnect. Now sports a new interrupt() method. Error
5335 handling was simplified a lot by chaining deferreds, so
5336 remoteFailed/remoteComplete were merged into a single
5337 remoteComplete method (which can now get a Failure object).
5338 Likewise failed/finished were merged into just _finished.
5339 (BuildStep): Add interrupt(why) method, and if why is a
5340 ConnectionLost Failure then the step is failed with some useful
5343 * buildbot/slave/bot.py: stop the current command when the remote
5344 Step reference is lost, and when the slave is shut down.
5345 (Bot): make it a MultiService, so it can have children. Use
5346 stopService to tell when the slave is shutting down.
5347 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5348 remote_interruptCommand (which asks the current SlaveCommand to
5349 stop but allows it to keep emitting status messages), and
5350 stopCommand (which tells it to shut up and die).
5352 * buildbot/slave/commands.py: make commands interruptible
5353 (ShellCommand.kill): factor out os.kill logic
5354 (Command): factor out setup()
5355 (Command.sendStatus): don't send status if .running is false, this
5356 happens when the command has been halted.
5357 (Command.interrupt): new method, used to tell the command to die
5358 (SlaveShellCommand): implement .interrupt
5359 (DummyCommand): implement .interrupt
5360 (SourceBase, etc): factor out setup(), don't continue substeps if
5363 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5364 so they can be called after finishing
5366 * buildbot/test/test_run.py: new tests for disconnect behavior,
5367 refactor slave-shutdown routines, add different kinds of
5370 2004-11-27 Brian Warner <warner@lothar.com>
5372 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5373 method to express ETA time like "2m45s" instead of "165 seconds"
5375 2004-11-24 Brian Warner <warner@lothar.com>
5377 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5378 archive after the test completes, to avoid cluttering the user's
5379 'tla archives' listing with a bogus entry. Arch doesn't happen to
5380 provide any way to override the use of ~/.arch-params/, so there
5381 isn't a convenient way to avoid touching the setup of the user who
5383 (VC_HTTP.testArchHTTP): same
5385 2004-11-23 Brian Warner <warner@lothar.com>
5387 * buildbot/status/html.py (TextLog): split render() up into
5388 render_HEAD and render_GET. Use a Producer when sending log
5389 chunks, to reduce memory requirements and avoid sending huge
5390 non-Banana-able strings over web.distrib connections. Requires
5391 peeking under the covers of IStatusLog.
5392 (TextLog.resumeProducing): fix the "as text" link, handle client
5393 disconnects that occur while we're still sending old chunks.
5395 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5396 use defer.succeed, not the non-existent defer.success
5397 (LogFile.waitUntilFinished): same
5398 (LogFile.subscribe): don't add watchers to a finished logfile
5400 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5403 2004-11-23 Brian Warner <warner@lothar.com>
5405 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5407 2004-11-23 Brian Warner <warner@lothar.com>
5409 * NEWS: update for the 0.6.1 release
5410 * MANIFEST.in: add new files
5412 * README (INSTALLATION): explain how to enable the extra VC tests
5414 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5415 level to, so old pickled builds can be displayed ok
5417 2004-11-22 Brian Warner <warner@lothar.com>
5419 * NEWS: summarize updates since last release
5421 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5422 Yoz Grahame. Closes SF#1050138.
5424 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5427 * buildbot/process/step_twisted.py (Trial): update docs a bit
5429 * docs/factories.xhtml: fix Trial factory docs to match reality.
5432 * buildbot/process/factory.py (Trial.__init__): add args for
5433 randomly= and recurse=, making them available to instantiators
5434 instead of only to subclassers. Closes: SF#1049759.
5436 2004-11-15 Brian Warner <warner@lothar.com>
5438 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5439 try to teach the Quick factory to use multiple versions of python
5441 2004-11-12 Brian Warner <warner@lothar.com>
5443 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5444 safer w32-compatible approach, and only use it on windows
5445 (BuildStatus.saveYourself): same
5447 2004-11-11 Brian Warner <warner@lothar.com>
5449 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5450 it: one string merge per chunk. There are now separate .entries
5451 and .runEntries lists: when enumerating over all chunks, make sure
5453 * buildbot/test/test_status.py (Log): more tests
5455 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5456 chunks together, up to 10kb per chunk. This ought to cut down on
5457 the CPU-burning overhead of large log files. Thanks to Alexander
5458 Staubo for spotting the problem.
5459 * buildbot/test/test_status.py (Log): tests for same
5461 2004-11-10 Brian Warner <warner@lothar.com>
5463 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5464 header to outbound mail
5465 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5467 2004-11-08 Brian Warner <warner@lothar.com>
5469 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5470 can't do os.rename() onto an existing file, so catch the exception
5471 and unlink the target file first. This introduces a slight window
5472 where the existing file could be lost, but the main failure case
5473 (disk full) should still be handled safely.
5474 (BuildStatus.saveYourself): same
5476 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5477 separator character instead of os.sep, because the filenames being
5478 split here are coming from the VC system, which can have a
5479 different pathname convention than the local host. This should
5480 help a buildmaster running on windows that uses a CVS repository
5481 which runs under unix.
5482 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5484 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5485 when there are no test failures to be parsed
5487 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5488 instead of the unix-specific os.system("cp"), thanks to Elliot
5489 Murphy for this and the other buildbot-vs-windows catches.
5490 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5492 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5493 echo the command as it is run
5495 * setup.py: install sample.mk too, not just sample.cfg
5496 (scripts): install contrib/windows/buildbot.bat on windows
5498 2004-11-07 Brian Warner <warner@lothar.com>
5500 * buildbot/process/builder.py (Builder._detached): clear the
5501 self.currentBuild reference, otherwise the next build will be
5502 skipped because we think the Builder is already in use.
5504 * docs/examples/twisted_master.cfg: update to match current usage
5505 on the Twisted buildbot
5507 2004-10-29 Brian Warner <warner@lothar.com>
5509 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5511 2004-10-28 Brian Warner <warner@lothar.com>
5513 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5514 have separate doVCUpdate/doVCFull methods. Catch an update failure
5515 and respond by clobbering the source directory and re-trying. This
5516 will handle local changes (like replacing a file with a directory)
5517 that will cause CVS and SVN updates to fail.
5518 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5520 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5523 2004-10-19 Brian Warner <warner@lothar.com>
5525 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5527 * buildbot/status/html.py (StatusResourceTestResults): display any
5528 TestResults that the Build might have
5529 (StatusResourceTestResult): and the logs for each TestResult
5530 (StatusResourceBuild): add link from the per-build page
5532 2004-10-15 Brian Warner <warner@lothar.com>
5534 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5535 the 'problems' portion of stdout, add TestResults to our build
5536 * buildbot/test/test_twisted.py (Parse.testParse): test it
5538 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5539 to retrieve a dict of accumulated test results
5540 (ITestResult): define what a single test result can do
5541 * buildbot/status/builder.py (TestResult): implement ITestResult
5542 (BuildStatus.getTestResults): retrieve dict of TestResults
5543 (BuildStatus.addTestResult): add TestResults
5544 * buildbot/test/test_status.py (Results.testAddResults): test it
5546 2004-10-14 Brian Warner <warner@lothar.com>
5548 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5549 instead of os.system("rm -rf") for win32 portability
5551 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5552 SignalMixin instead of starting/stopping the reactor, which is
5553 likely to cause problems with other tests
5555 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5556 self.copyComplete() call. Yoz Grahame makes the catch.
5558 * contrib/windows/buildbot.bat: helper script to deal with path
5559 issues. Thanks to Yoz Grahame.
5561 * buildbot/master.py (BuildMaster.startService): don't register a
5562 SIGHUP handler if the signal module has no SIGHUP attribute.
5563 Apparently win32 does this.
5565 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5567 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5568 test if the reactor can't offer UNIX sockets
5570 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5571 error introduced in the last commit. We really need that
5574 2004-10-12 Brian Warner <warner@lothar.com>
5576 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5577 when describing a maildir source. Thanks to Stephen Davis.
5579 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5582 * buildbot/scripts/runner.py (createMaster): install Makefile too
5583 (start): add --no_save to 'start' command
5584 * buildbot/scripts/sample.mk: simple convenience Makefile with
5585 start/stop/reload targets
5587 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5590 2004-09-30 Brian Warner <warner@lothar.com>
5592 * setup.py: Releasing buildbot-0.6.0
5594 2004-09-30 Brian Warner <warner@lothar.com>
5596 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5597 test_trial.py from the source tarball until support is complete.
5599 * NEWS: update for 0.6.0 release
5600 * buildbot/__init__.py (version): same
5603 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5604 'source' command to tell users where to get the Buildbot source
5606 * docs/examples/*.cfg: update to modern standards
5608 * NEWS: update for release
5610 * buildbot/scripts/runner.py (createMaster): remove the
5611 -shutdown.tap stuff now that it isn't necessary
5613 (start): launch buildbot.tap, not buildbot-shutdown.tap
5616 * buildbot/status/mail.py (Domain): shorten class name
5617 (MailNotifier): if lookup= is a string, pass it to Domain()
5618 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5619 (Mail.testBuild2): test the string-to-Domain shortcut
5620 (Mail.testMail): fix test
5623 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5626 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5627 more attributes on load
5628 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5629 to accomodate the whole waterfall page at once, and the thrashing
5630 results in a lot of unnecessary loads
5631 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5632 (BuilderStatus.saveYourself): same
5633 (BuilderStatus.eventGenerator): stop generating on the first missing
5634 build. We assume that saved builds are deleted oldest-first.
5635 (BuildStepStatus.__getstate__): .progress might not exist
5637 * buildbot/changes/changes.py (ChangeMaster): make it
5638 serializable, in $masterdir/changes.pck
5639 (ChangeMaster.stopService): save on shutdown
5640 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5641 * buildbot/test/test_config.py: load Changes before config file
5644 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5645 "Oh my god, you killed the command" header on a separate line
5647 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5648 skip over corrupted build pickles
5649 (BuilderStatus.getFullBuildByNumber): same
5650 (BuilderStatus.eventGenerator): skip over unavailable builds
5651 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5652 do an atomic rename. This prevents a corrupted pickle when some
5653 internal serialization error occurs.
5654 (BuilderStatus.saveYourself): same
5656 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5657 the timeout for shell commands, it got lost somehow
5659 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5660 run out of build steps, return the rest of the builder events
5662 * buildbot/interfaces.py (IBuilderControl.ping): add method
5664 * buildbot/process/builder.py (BuilderControl.ping): move
5665 slave-ping to BuilderControl, and fix the failure case in the
5666 process (Event.finish() is the verb, Event.finished is the noun).
5668 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5669 through the BuilderControl instead of the BuilderStatus
5670 (EventBox): add adapter for builder.Event, allowing builder events to
5671 be displayed in the waterfall display
5673 * buildbot/master.py (BotMaster.stopService): add a 'master
5674 shutdown' event to the builder's log
5675 (BuildMaster.startService): and a 'master started' on startup
5677 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5678 builder events into the BuildStep event stream
5679 (Status.builderAdded): add a 'builder created' event
5682 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5683 command to announce the completion of a running build
5684 (IrcStatusBot.command_FORCE): announce when the build finishes
5686 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5687 don't evict unfinished builds from the cache: they must stay in
5688 the full-cache until their logfiles have stopped changing. Make
5689 sure the eviction loop terminates if an unfinished build was hit.
5690 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5691 This lets exceptions be dumped in an email status message. Really
5692 we need LogFiles which contain both text and HTML, instead of two
5694 (BuildStatus.__getstate__): handle self.finished=False
5695 (Status.builderAdded): if the pickle is corrupted, abandon the
5696 history and create a new BuilderStatus object.
5698 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5699 self.progress attribute, helped one test which doesn't fully set
5700 up the Build object.
5702 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5703 IStatusLog methods into an Interface that is implemented by "stub"
5704 logs, for which all the actual text chunks are on disk (in the
5705 pickled Build instance). To show the log contents, you must first
5706 adapt the stub log to a full IStatusLog object.
5708 * buildbot/status/builder.py (LogFileStub): create separate stub
5709 log objects, which can be upgraded to a real one if necessary.
5710 (LogFile): make them persistable, and let them stubify themselves
5712 (BuildStepStatus): same
5714 (BuildStatus.saveYourself): save the whole build out to disk
5715 (BuilderStatus): make it persistable
5716 (BuilderStatus.saveYourself): save the builder to disk
5717 (BuilderStatus.addFullBuildToCache): implement two caches which
5718 hold Build objects: a small one which holds full Builds, and a
5719 larger one which holds "stubbed" Builds (ones with their LogFiles
5720 turned into LogFileStubs). This reduces memory usage by the
5721 buildmaster by not keeping more than a few (default is 2) whole
5722 build logs in RAM all the time.
5723 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5725 (BuilderStatus.eventGenerator): rewrite since .builds went away
5726 (BuilderStatus.buildStarted): remove the .builds array. Add the
5727 build to the "full" cache when it starts.
5728 (BuilderStatus._buildFinished): save the build to disk when it
5730 (Status): give it a basedir (same as the BuildMaster's basedir)
5731 where the builder pickles can be saved
5732 (Status.builderAdded): create the BuilderStatus ourselves, by
5733 loading a pickle from disk (or creating a new instance if there
5734 was none on disk). Return the BuilderStatus so the master can glue
5735 it into the new Builder object.
5737 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5738 all BuilderStatuses to save themselves out to disk. This is in
5739 lieu of saving anything important in the main Application pickle
5740 (the -shutdown.tap file).
5741 (BuildMaster.__init__): give Status() a basedir for its files
5742 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5743 to get the BuilderStatus, then give it to the Builder (instead of
5744 doing it the other way around). It's ok if the status announces
5745 the new Builder before it's really ready, as the outside world can
5746 only see the BuilderStatus object anyway (and it is ready before
5747 builderAdded returns). Use the builder's "builddir" (which
5748 normally specifies where the slave will run the builder) as the
5749 master's basedir (for saving serialized builds).
5751 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5752 coerce the logfile to IStatusLog before trying to get the text
5753 chunks out of it. This will pull the full (non-stubified) Build in
5754 from disk if necessary.
5755 (TextLog): fix the adapter registration
5757 * buildbot/test/test_control.py (Force.setUp): create the basedir
5758 * buildbot/test/test_web.py: same
5759 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5760 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5761 * buildbot/test/test_run.py (Run.testMaster): same
5762 (Status.setUp): same
5764 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5766 * buildbot/status/html.py (Waterfall.__init__): store actual
5767 allowForce flag passed in rather than using True for everyone;
5768 make sure setting it to False doesn't cause a NameError
5770 (StatusResourceBuilder.__init__) add the builder name to the page
5772 (StatusResourceBuilder.body) move HTML generation for a name/value
5773 row into a helper method (StatusResourceBuilder.make_row); only
5774 generate the "Force Build" form if allowForce was True and the
5775 slave is connected. Use class attributes in the generated HTML to
5776 spread a little CSS-joy.
5778 2004-09-28 Brian Warner <warner@lothar.com>
5780 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5781 warning-scanner to not ignore things like
5782 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5784 * buildbot/status/html.py (StatusResource.control): add some
5785 class-level values for .control in an attempt to make upgrading
5788 * buildbot/util.py (ComparableMixin): survive missing attributes,
5789 such as when a class is modified and we're comparing old instances
5792 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5793 failure handling, remove a redundant try/except block. Don't
5794 return the full traceback to the IRC channel.
5795 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5796 error messages. Get ETA properly.
5798 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5799 the reason, since (at least) IRC message will have <> in them.
5800 (StatusResourceBuilder.__init__): take an IBuilderControl
5801 (StatusResourceBuilder.force): use the IBuilderControl we get in
5802 the constructor instead of trying to make our own. Catch the
5803 new exceptions and ignore them for now (until we make an
5804 intermediate web page where we could show the error message)
5805 (StatusResource): create with an IControl, use it to give an
5806 IBuilderControl to all children
5807 (Waterfall): take an allowForce= option, pass an IControl object
5808 to StatusResource if it is True
5810 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5812 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5813 catch new exceptions and return string forms
5815 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5816 * buildbot/process/builder.py (Builder.forceBuild): raise them
5817 * buildbot/test/test_control.py (Force.testNoSlave): new test
5818 (Force.testBuilderInUse): same
5821 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5823 * buildbot/test/test_run.py: use IControl
5824 * buildbot/test/test_vc.py: same
5826 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5827 to use IControl. Still offline.
5828 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5830 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5831 who=None so periodic builds don't send out status mail
5832 (Builder.forceBuild): include reason in the log message
5833 (BuilderControl.forceBuild): rename 'name' to 'who'
5835 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5836 'who' parameter, but make it None by default so builds forced by
5837 slave admins don't cause status mail to be sent to anybody
5838 (BotMaster.forceBuild): same. this method is deprecated.
5839 (DebugPerspective.perspective_forceBuild): same, use IControl.
5840 (DebugPerspective.perspective_fakeChange): use IControl..
5841 (Dispatcher.requestAvatar): .. so don't set .changemaster
5843 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5844 parameter to avoid confusion with the name of the builder
5847 * buildbot/status/mail.py: refine comment about needing 2.3
5849 * buildbot/status/html.py: move all imports to the top
5851 * buildbot/test/test_control.py: test new interfaces
5852 * buildbot/test/test_run.py (Status): handle new interfaces
5853 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5855 * buildbot/process/base.py (BuildControl): implement IBuildControl
5856 and its lonely getStatus() method
5858 * buildbot/process/builder.py (BuilderControl): implement
5859 IBuilderControl, obtained by adapting the Builder instance
5860 (Builder.startBuild): return a BuilderControl instead of a
5861 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5862 accomplish the same thing.
5864 * buildbot/master.py: move all import statements to the top
5865 (Control): implement IControl, obtained by adapting the
5866 BuildMaster instance.
5868 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5869 IBuildControl. These are used to force builds. Eventually they
5870 will provide ways to reconfigure the Builders, pause or abandon a
5871 Build, and perhaps control the BuildMaster itself.
5873 2004-09-26 Brian Warner <warner@lothar.com>
5875 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5876 ends up comparing us against something without a .__class__
5878 2004-09-24 Brian Warner <warner@lothar.com>
5880 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5883 * Makefile: add 'deb-snapshot' target, to create a timestamped
5886 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5888 2004-09-23 Brian Warner <warner@lothar.com>
5890 * buildbot/__init__.py (version): move version string here
5891 * setup.py: get version string from buildbot.version
5892 * buildbot/status/html.py (WaterfallStatusResource.body): add
5893 buildbot version to the page footer
5894 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5897 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5898 slaves, let the second know where the first one is coming from
5899 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5900 see our exceptions. It would be nice if there were a way to just
5901 send them the exception type and value, not the full traceback.
5904 * buildbot/status/mail.py (MailNotifier): add a new argument
5905 sendToInterestedUsers=, which can be set to False to disable the
5906 usual send-to-blamelist behavior.
5907 (top): handle python-2.2 which has no email.MIMEMultipart
5908 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5909 (MailNotifier.disownServiceParent): unsubscribe on removal
5911 * buildbot/test/test_status.py (Mail.testBuild2): test it
5914 * buildbot/status/progress.py (Expectations.wavg): tolerate
5915 current=None, which happens when steps start failing badly
5916 * buildbot/test/test_status.py (Progress.testWavg): test for it
5918 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5919 doesn't understand args['revision'], emit a warning instead of
5920 bailing completely. Updating to -rHEAD is probably close enough.
5922 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5924 * buildbot/test/test_status.py: at least import bb.status.client
5925 even if we don't have any test coverage for it yet
5927 * contrib/svn_buildbot.py: don't require python2.3
5928 (main): wait, do require it (for sets.py), but explain how to
5929 make it work under python2.2
5931 2004-09-23 Brian Warner <warner@lothar.com>
5933 * contrib/svn_buildbot.py: include the revision number in the Change
5935 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5936 using util.now() because FreshCVS is a realtime service
5938 * buildbot/status/event.py: delete dead code
5939 * buildbot/process/step.py: don't import dead Event class
5940 * buildbot/process/step_twisted.py: same
5941 * buildbot/status/builder.py: same
5942 * buildbot/status/client.py: same
5944 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5946 * buildbot/changes/changes.py (Change): set .when from an __init__
5947 argument (which defaults to now()), rather than having
5948 ChangeMaster.addChange set it later.
5949 (ChangeMaster.addChange): same
5951 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5952 (parseSyncmail): same. Just use util.now() for now.
5953 (parseBonsaiMail): parse the timestamp field for when=
5955 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5956 instead of setting .when after the fact
5960 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5961 results when the target project uses retrial. Still under
5963 * buildbot/test/test_trial.py: same
5965 2004-09-21 Brian Warner <warner@lothar.com>
5967 * buildbot/status/mail.py (MailNotifier.__init__): include
5968 success/warnings/failure in the Subject line
5969 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5970 use step.logname for the addLogs=True attachment filenames
5971 * buildbot/test/test_status.py (Mail): test Subject lines
5972 (Mail.testLogs): test attachment filenames
5974 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5975 accept a 'who' argument from the debug tool
5976 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5977 * contrib/debug.glade: add text box to set 'who'
5979 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5980 .getBuilderName with .getBuilder().getName(), more flexible
5981 (IStatusLog.getName): logs have short names, but you can prefix
5982 them with log.getStep().getName() to make them more useful
5983 * buildbot/status/builder.py: same
5984 * buildbot/status/client.py: same
5985 * buildbot/status/html.py: same
5986 * buildbot/test/test_run.py (Status.testSlave): same
5987 * buildbot/process/step.py: tweak logfile names
5989 * buildbot/status/mail.py (MailNotifier): add lookup, change
5990 argument to extraRecipients. The notifier is now aimed at sending
5991 mail to the people involved in a particular build, with additional
5992 constant recipients as a secondary function.
5994 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5995 including slow-lookup and failing-lookup. Make sure the blamelist
5996 members are included.
5998 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5999 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6000 (IBuildStatus.getInterestedUsers): new method
6001 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6002 * buildbot/status/client.py (remote_getResponsibleUsers): same
6003 * buildbot/status/html.py (StatusResourceBuild.body): same
6004 * buildbot/test/test_run.py (Status.testSlave): same
6006 2004-09-20 Brian Warner <warner@lothar.com>
6008 * docs/users.xhtml: update concepts
6010 * Makefile: add a convenience makefile, for things like 'make
6011 test'. It is not included in the source tarball.
6013 2004-09-16 Brian Warner <warner@lothar.com>
6015 * NEWS: mention /usr/bin/buildbot, debian/*
6017 * debian/*: add preliminary debian packaging. Many thanks to
6018 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6019 it considerably since it left their hands, I am responsible for
6020 all breakage that's resulted.
6022 * bin/buildbot: create a top-level 'buildbot' command, to be
6023 installed in /usr/bin/buildbot . For now it's just a simple
6024 frontend to mktap/twistd/kill, but eventually it will be the entry
6025 point to the 'try' command and also a status client. It is also
6026 intended to support the upcoming debian-packaging init.d scripts.
6027 * buildbot/scripts/runner.py: the real work is done here
6028 * buildbot/scripts/__init__.py: need this too
6029 * buildbot/scripts/sample.cfg: this is installed in new
6030 buildmaster directories
6031 * setup.py: install new stuff
6033 2004-09-15 Brian Warner <warner@lothar.com>
6035 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6036 'file:' schema (the version shipped with OS-X was built without the
6038 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6039 updates the log-timestamp, to make sure it isn't still running after
6042 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6043 values to the config file.
6044 * docs/examples/hello.cfg: add examples
6045 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6046 * buildbot/status/builder.py (Status.getProjectURL): implement them
6047 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6048 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6049 * buildbot/status/html.py (WaterfallStatusResource): display them
6052 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6053 certain error cases don't suffer a secondary exception.
6054 (top): Skip tests if the corresponding VC tool is not installed.
6056 * buildbot/process/factory.py (Trial): introduce separate
6057 'buildpython' and 'trialpython' lists, since trialpython=[] is
6058 what you want to invoke /usr/bin/python, whereas ./setup.py is
6059 less likely to be executable. Add env= parameter to pass options
6060 to test cases (which is how I usually write tests, I don't know if
6061 anyone else does it this way).
6063 * buildbot/process/step_twisted.py (Trial): handle python=None.
6064 Require 'testpath' be a string, not a list. Fix tests= typo.
6065 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6067 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6068 way to deal with the possibility of removing the disconnect notify
6070 (CVS): add a 'login' parameter to give a password to 'cvs login',
6071 commonly used with pserver methods (where pw="" or pw="guest")
6073 * buildbot/slave/commands.py (SourceBase): move common args
6074 extraction and setup() to __init__, so everything is ready by the
6075 time setup() is called
6076 (CVS.start): call 'cvs login' if a password was supplied
6077 (ShellCommand): special-case PYTHONPATH: prepend the master's
6078 value to any existing slave-local value.
6080 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6081 don't have a remote, mark the builder as Offline. This whole
6082 function should probably go away and be replaced by individual
6084 (Builder.buildFinished): return the results to the build-finished
6085 deferred callback, helps with testing
6087 2004-09-14 Brian Warner <warner@lothar.com>
6089 * buildbot/test/test_vc.py: put all the repositories needed to run
6090 the complete tests into a single small (1.3MB) tarball, so I can
6091 make that tarball available on the buildbot web site. Test HTTP
6092 access (for Arch and Darcs) by spawning a temporary web server
6093 while the test runs.
6095 * docs/users.xhtml: new document, describe Buildbot's limited
6096 understanding of different human users
6098 * buildbot/test/test_vc.py: rearrange test cases a bit
6100 * buildbot/process/step_twisted.py (Trial): handle testpath=
6101 * buildbot/process/factory.py (Trial): update to use step.Trial
6103 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6105 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6106 the overall build text (which gives you 'failed 2 tests' rather
6108 (BuildStepStatus.text2): default to [], not None
6110 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6113 2004-09-12 Brian Warner <warner@lothar.com>
6115 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6116 log the whole exception if it's just an AttributeError (old slave)
6118 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6119 so (e.g.) sub-commands can be run in the right directory.
6120 (ShellCommand.start): accept an optional errorMessage= argument
6121 to make life easier for SVN.start
6122 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6124 (ShellCommand.start): move ['dir'] compatibility hack..
6125 (RemoteShellCommand.start): .. to here so everyone can use it
6127 * buildbot/process/step_twisted.py (Trial): use .workdir
6129 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6130 text displayed when debuild fails completely
6131 (Trial): snarf _trial_temp/test.log from the slave and display it
6133 2004-09-11 Brian Warner <warner@lothar.com>
6135 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6137 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6138 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6140 * buildbot/process/step.py (ShellCommand): call .createSummary
6141 before .evaluateCommand instead of the other way around. This
6142 makes it slightly easier to count warnings and then use that to
6143 set results=WARNINGS
6144 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6146 * buildbot/process/base.py (Build.buildFinished): update status
6147 before doing progress. It's embarrassing for the build to be stuck
6148 in the "building" state when an exceptions occurs elsewhere..
6150 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6151 python2.2 doesn't have 'sum'
6153 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6154 to prevent clients from accidentally sorting it
6156 * buildbot/master.py (Manhole): add username/password
6157 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6158 c['manholePort'], deprecate old usage
6159 * docs/config.xhtml: document c['manhole']
6160 * docs/examples/hello.cfg: show example of using a Manhole
6163 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6164 pretend the slave is up to date
6166 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6167 the module, overlaps with 'log', the local variable
6169 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6171 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6172 new method to let Steps find out the version of their
6173 corresponding SlaveCommand.
6174 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6175 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6176 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6178 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6179 (Arch.startVC): same
6180 (P4Sync.startVC): same
6182 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6183 Deferred so we can catch errors in remote_startCommand
6184 (RemoteShellCommand.start): same
6186 * docs/examples/twisted_master.cfg: update sample config file
6188 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6189 after connectionMade() is called, not before. Close stdin at that
6192 * buildbot/process/process_twisted.py: update to use Trial, clean
6193 up argument passing (move to argv arrays instead of string
6196 * buildbot/process/step_twisted.py (Trial): new step to replace
6197 RunUnitTests, usable by any trial-using project (not just
6198 Twisted). Arguments have changed, see the docstring for details.
6200 * buildbot/process/base.py (Build.startBuild): this now returns a
6201 Deferred. Exceptions that occur during setupBuild are now
6202 caught better and lead to fewer build_status weirdnesses, like
6203 finishing a build that was never started.
6204 (Build.buildFinished): fire the Deferred instead of calling
6205 builder.buildFinished directly. The callback argument is this
6206 Build, everything else can be extracted from it, including the
6207 new build.results attribute.
6208 * buildbot/process/builder.py (Builder.startBuild): same
6209 (Builder.buildFinished): same, extract results from build
6211 * buildbot/process/step.py (ShellCommands): remove dead code
6213 2004-09-08 Brian Warner <warner@lothar.com>
6215 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6216 doesn't try to use the leftover patched workdir
6217 (SourceStamp): test source-stamp computation for CVS and SVN
6219 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6220 patched workdir ('touch .buildbot-patched') so we don't try to
6222 (SourceBase.start): add ['revision'] for all Source steps
6223 (CVS): change args: use ['branch'] for -r, remove ['files']
6224 (CVS.buildVC): fix revision/branch stuff
6225 (SVN): add revision stuff
6227 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6228 kwargs (except 'workdir') to avoid silent spelling errors
6229 (ShellCommand.__init__): same
6230 (Source): new base class for CVS/SVN/etc. Factor out everything
6231 common, add revision computation (perform the checkout with a -D
6232 DATE or -r REVISION that gets exactly the sources described by the
6233 last Change), overridable with step.alwaysUseLatest. Add patch
6234 handling (build.getSourceStamp can trigger the use of a base
6235 revision and a patch).
6236 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6237 * docs/steps.xhtml: update docs
6238 * docs/source.xhtml: mention .checkoutDelay
6239 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6241 * buildbot/process/base.py (Build.setSourceStamp): add a
6242 .sourceStamp attribute to each Build. If set, this indicates that
6243 the build should be done with something other than the most
6244 recent source tree. This will be used to implement "try" builds.
6245 (Build.allChanges): new support method
6246 (Build.lastChangeTime): remove, functionality moved to Source steps
6247 (Build.setupBuild): copy the Step args before adding ['workdir'],
6248 to avoid modifying the BuildFactory (and thus triggering spurious
6252 * buildbot/status/html.py: rename s/commits/changes/
6253 (StatusResourceChanges): same
6254 (CommitBox.getBox): same, update URL
6255 (WaterfallStatusResource): same
6256 (StatusResource.getChild): same
6258 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6259 * contrib/debug.glade: add optional 'revision' to the fakeChange
6261 * buildbot/changes/changes.py (html_tmpl): display .revision
6262 (ChangeMaster.addChange): note .revision in log
6263 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6264 accept a ['revision'] attribute
6266 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6268 * buildbot/master.py (BotMaster.getPerspective): update the
6269 .connected flag in SlaveStatus when it connects
6270 (BotMaster.detach): and when it disconnects
6271 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6272 (BuildMaster.loadConfig_Builders): walk old list correctly
6274 * buildbot/test/test_config.py: fix prefix= usage
6276 2004-09-06 Brian Warner <warner@lothar.com>
6280 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6281 poll a P4 depot looking for recent changes. Thanks to Dave
6282 Peticolas for the contribution. Probably needs some testing after
6285 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6286 requires manual client setup for each buildslave. Rather
6287 experimental. Thanks again to Dave Peticolas.
6288 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6290 * buildbot/changes/changes.py (Change): add a .revision attribute,
6291 which will eventually be used to generate source-stamp values.
6293 * buildbot/process/step.py (RemoteCommand.start): use
6294 notifyOnDisconnect to notice when we lose the slave, then treat it
6295 like an exception. This allows LogFiles to be closed and the build
6296 to be wrapped up normally. Be sure to remove the disconnect
6297 notification when the step completes so we don't accumulate a
6298 bazillion such notifications which will fire weeks later (when the
6299 slave finally disconnects normally). Fixes SF#915807, thanks to
6300 spiv (Andrew Bennetts) for the report.
6301 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6302 really isn't Logged- specific
6303 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6304 header, since it's almost always going to be appended to an
6306 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6307 update test to handle use of notifyOnDisconnect
6309 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6310 don't clear .ETA and .currentBuild when going offline, let the
6311 current build clean up after itself
6313 * buildbot/process/builder.py (Builder.detached): wait a moment
6314 before doing things like stopping the current build, because the
6315 current step will probably notice the disconnect and cleanup the
6317 * buildbot/test/test_run.py (Status.tearDown): update test to
6318 handle asynchronous build-detachment
6320 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6322 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6323 hush a debug message
6325 2004-09-05 Brian Warner <warner@lothar.com>
6327 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6328 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6329 kernels do this: the fcntl module has the F_NOTIFY constant, but
6330 the kernel itself doesn't support the operation. Thanks to Olly
6331 Betts for spotting the problem.
6333 * buildbot/process/step.py (Darcs): new source-checkout command
6334 (Arch): new source-checkout command
6335 (todo_P4): fix constructor syntax, still just a placeholder
6336 * buildbot/test/test_vc.py (VC.testDarcs): test it
6337 (VC.testDarcsHTTP): same, via localhost HTTP
6339 (VC.testArchHTTP): same
6340 * NEWS: mention new features
6342 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6343 which tells the step to stash stdout text locally (in .stdout).
6344 Slave-side Commands can use this to make decisions based upon the
6345 output of the the ShellCommand (not just the exit code).
6346 (Darcs): New source-checkout command
6347 (Arch): New source-checkout command, uses .keepStdout in one place
6348 where it needs to discover the archive's default name.
6350 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6351 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6352 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6354 * buildbot/process/step.py (ShellCommand.describe): add an
6355 alternate .descriptionDone attribute which provides descriptive
6356 text when the step is complete. .description can be ["compiling"],
6357 for use while the step is running, then .descriptionDone can be
6358 ["compile"], used alone when the step succeeds or with "failed" when
6359 it does not. Updated other steps to use the new text.
6360 * buildbot/process/step_twisted.py: same
6361 * buildbot/test/test_run.py: update tests to match
6363 2004-08-30 Brian Warner <warner@lothar.com>
6365 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6366 (CVS.__init__): send 'patch' argument to slave
6367 (CVS.start): don't create the LoggedRemoteCommand until start(),
6368 so we can catch a .patch added after __init__
6369 (SVN.__init__): add 'patch' to SVN too
6372 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6373 argument, to let commands push data into the process' stdin pipe.
6374 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6375 is in use, since closing a PTY doesn't really affect the process
6376 in the right way (in particular, I couldn't run /usr/bin/patch
6378 (SourceBase.doPatch): handle 'patch' argument
6380 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6383 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6384 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6386 * buildbot/master.py (BotPerspective.got_commands): get command
6387 versions from slave, give to each builder
6388 * buildbot/process/builder.py (Builder.attached): stash slave
6389 command versions in .remoteCommands
6391 * docs/steps.xhtml: bring docs in-line with reality
6393 * buildbot/process/step.py (CVS.__init__): more brutal
6394 compatibility code removal
6395 (SVN.__init__): same
6397 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6398 (SlaveShellCommand.start): require ['workdir'] argument, remove
6399 the ['dir'] fallback (compatibility will come later)
6400 (SourceBase): update docs
6401 (SourceBase.start): remove ['directory'] fallback
6404 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6405 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6406 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6408 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6409 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6410 code.. I will figure out 0.5.0-compatibility hooks later)
6412 2004-08-30 Brian Warner <warner@lothar.com>
6414 * buildbot/process/process_twisted.py: rewrite in terms of new
6415 BuildFactory base class. It got significantly shorter. Yay
6418 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6419 work with the new "self.build isn't nailed down until we call
6420 step.start()" scheme: specifically, __init__ is called before the
6421 build has decided on which Changes are going in, so we don't scan
6422 build.allFiles() for .xhtml files until start()
6423 (HLint.commandComplete): use getText(), not getStdout()
6424 (RunUnitTests.start): same: don't use .build until start()
6425 (RunUnitTests.describe): oops, don't report (None) when using
6427 (RunUnitTests.commandComplete): use getText()
6428 (RunUnitTests.createSummary): same
6429 (BuildDebs.commandComplete): same
6431 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6432 set args['command'] until start(), since our BuildStep is allowed
6433 to change their mind up until that point
6434 (TreeSize.commandComplete): use getText(), not getStdout()
6436 * docs/examples/twisted_master.cfg: update to current standards
6438 * docs/factories.xhtml: update
6439 * buildbot/process/factory.py: implement all the common factories
6440 described in the docs. The Trial factory doesn't work yet, and
6441 I've probably broken all the process_twisted.py factories in the
6442 process. There are compatibility classes left in for things like
6443 the old BasicBuildFactory, but subclasses of them are unlikely to
6445 * docs/examples/glib_master.cfg: use new BuildFactories
6446 * docs/examples/hello.cfg: same
6448 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6449 explicit 'workdir' args
6451 * buildbot/process/base.py (BuildFactory): move factories to ..
6452 * buildbot/process/factory.py (BuildFactory): .. here
6453 * buildbot/process/process_twisted.py: handle move
6454 * buildbot/test/test_config.py: same
6455 * buildbot/test/test_run.py: same
6456 * buildbot/test/test_steps.py: same
6457 * buildbot/test/test_vc.py: same
6458 * docs/factories.xhtml: same
6460 * NEWS: mention config changes that require updating master.cfg
6462 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6463 argument to all steps that weren't given one already, pointing at
6464 the "build/" directory.
6466 * docs/examples/hello.cfg: remove explicit 'workdir' args
6468 * docs/factories.xhtml: document standard BuildFactory clases,
6469 including a bunch which are have not yet been written
6471 2004-08-29 Brian Warner <warner@lothar.com>
6473 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6474 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6475 buildbot.status.builder so they aren't quite so internal
6476 * buildbot/process/base.py, buildbot/process/builder.py: same
6477 * buildbot/process/maxq.py, buildbot/process/step.py: same
6478 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6479 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6480 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6482 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6483 to handle new getLogs()-returns-list behavior
6484 (StatusResourceBuildStep.getChild): same
6485 (StepBox.getBox): same
6486 (WaterfallStatusResource.phase0): same
6488 * docs/source.xhtml: document how Buildbot uses version-control
6489 systems (output side: how we get source trees)
6490 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6491 systems (input side: how we learn about Changes)
6493 * buildbot/master.py (Manhole): use ComparableMixin
6494 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6495 * buildbot/changes/mail.py (MaildirSource): same
6496 * buildbot/status/client.py (PBListener): same
6497 * buildbot/status/html.py (Waterfall): same
6498 * buildbot/status/words.py (IRC): same
6500 * NEWS: start describing new features
6502 * buildbot/status/mail.py (MailNotifier): finish implementation.
6503 The message body is still a bit sparse.
6504 * buildbot/test/test_status.py (Mail): test it
6506 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6507 and __hash__ methods I wind up adding everywhere. Specifically
6508 intended to support the buildbot config-file update scheme where
6509 we compare, say, the old list of IStatusTargets against the new
6510 one and don't touch something which shows up on both lists.
6511 * buildbot/test/test_util.py (Compare): test case for it
6513 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6514 return a list instead of a dict
6515 (IBuildStepStatus.getLogs): same. The idea is that steps create
6516 logs with vaguely unique names (although their uniqueness is not
6517 guaranteed). Thus a compilation step should create its sole
6518 logfile with the name 'compile', and contribute it to the
6519 BuildStatus. If a step has two logfiles, try to create them with
6520 different names (like 'test.log' and 'test.summary'), and only
6521 contribute the important ones to the overall BuildStatus.
6522 * buildbot/status/builder.py (Event.getLogs): same
6523 (BuildStepStatus): fix default .text and .results
6524 (BuildStepStatus.addLog): switch to list-like .getLogs()
6525 (BuildStepStatus.stepFinished): same
6526 (BuildStatus.text): fix default .text
6527 (BuildStatus.getLogs): temporary hack to return all logs (from all
6528 child BuildStepStatus objects). Needs to be fixed to only report
6529 the significant ones (as contributed by the steps themselves)
6530 * buildbot/test/test_run.py: handle list-like .getLogs()
6531 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6533 2004-08-28 Brian Warner <warner@lothar.com>
6535 * buildbot/process/builder.py (Builder.attached): serialize the
6536 attachment process, so the attach-watcher isn't called until the
6537 slave is really available. Add detached watchers too, which makes
6540 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6542 * buildbot/test/test_swap.py: remove dead code
6544 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6545 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6546 sort of as if the command being run exited with a -1. There may
6547 still be some holes in this scheme.
6548 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6549 -r option appears before the module list
6550 * buildbot/process/step.py (CVS): add 'revision' argument
6552 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6553 when sending updates or stepComplete messages to the master, since
6554 we don't currently care whether they arrive or not. When we revamp
6555 the master/slave protocol to really resume interrupted builds,
6556 this will need revisiting.
6557 (lostRemote): remove spurious print
6559 * buildbot/master.py (BotPerspective.attached): serialize the
6560 new-builder interrogation process, to make testing easier
6561 (BotMaster.waitUntilBuilderDetached): convenience function
6563 * buildbot/status/builder.py (BuilderStatus): prune old builds
6564 (BuildStatus.pruneSteps): .. and steps
6565 (BuildStepStatus.pruneLogs): .. and logs
6566 (BuilderStatus.getBuild): handle missing builds
6567 * buildbot/status/html.py (StatusResourceBuild.body): display build
6568 status in the per-build page
6569 (BuildBox.getBox): color finished builds in the per-build box
6571 2004-08-27 Brian Warner <warner@lothar.com>
6573 * buildbot/status/mail.py (MailNotifier): new notification class,
6576 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6577 variants of a common base class which handles all the mode= logic
6579 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6581 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6583 2004-08-26 Brian Warner <warner@lothar.com>
6585 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6588 * buildbot/test/test_run.py: update to new Logfile interface, new
6589 buildbot.slave modules
6590 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6592 * MANIFEST.in: new sample config file
6593 * docs/examples/hello.cfg: same
6595 * buildbot/process/step_twisted.py: remove dead import
6597 * buildbot/process/step.py (RemoteCommand.run): catch errors
6599 (RemoteCommand.remote_update): ignore updates that arrive after
6601 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6602 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6603 the responsibilities of the subclass's methods
6604 (BuildStep.failed): catch errors during failure processing
6605 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6606 (CVS): move to a mode= argument (described in docstring), rather
6607 than the ungainly clobber=/export=/copydir= combination.
6608 (SVN): add mode= functionality to SVN too
6609 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6611 * buildbot/process/base.py (Build.startNextStep): catch errors
6612 during s.startStep()
6614 * buildbot/clients/base.py: update to new PB client interface.
6615 gtkPanes is still broken
6617 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6618 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6619 * setup.py: add buildbot.slave module
6620 * buildbot/bb_tap.py: handle move
6621 * buildbot/slave/registry.py: place to register commands, w/versions
6622 * buildbot/slave/bot.py: major simplifications
6623 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6624 instead of a fixed table. Eventually this will make the slave more
6625 extensible. Use 'start' method on the command, not .startCommand.
6626 Fix unsafeTracebacks handling (I think).
6627 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6628 helper class with a .start method that returns a Deferred.
6629 SlaveShellCommand is the form reached by the buildmaster. Commands
6630 which use multiple ShellCommands can just chain them as Deferreds,
6631 with some helper methods in Command (_abandonOnFailure and
6632 _checkAbandoned) to bail on rc!=0.
6633 (CVSCommand): prefer new mode= argument
6634 (SVNFetch): add mode= argument
6636 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6637 put a useful reason string on the build
6639 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6640 core functionality into an IStatusLog object
6641 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6642 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6643 (StatusResourceBuild.body): use proper accessor methods
6644 * buildbot/status/client.py (RemoteLog): PB-access goes here
6645 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6646 which delivers log contents too
6647 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6648 * buildbot/status/event.py: remove old Logfile completely
6650 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6651 subscription interface for IStatusLog subscriptions just like all
6652 other the status subscriptions
6653 (IStatusReceiver.logChunk): method called on subscribers
6655 2004-08-24 Brian Warner <warner@lothar.com>
6657 * buildbot/process/builder.py (Builder._pong): oops, ping response
6658 includes a result (the implicit None returned by remote_print).
6659 Accept it so the _pong method handles the response correctly.
6661 2004-08-06 Brian Warner <warner@lothar.com>
6663 * buildbot/test/test_config.py: update IRC, PBListener tests
6665 * buildbot/status/client.py (StatusClientPerspective): total
6666 rewrite to match new IStatus interfaces. New subscription scheme.
6667 There are still a few optimizations to make (sending down extra
6668 information with event messages so the client doesn't have to do a
6669 round trip). The logfile-retrieval code is probably still broken.
6670 Moved the PB service into its own port, you can no longer share a
6671 TCP socket between a PBListener and, say, the slaveport (this
6672 should be fixed eventually).
6673 * buildbot/clients/base.py (Client): revamp to match. still needs
6674 a lot of work, but basic event reporting works fine. gtkPanes is
6677 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6678 instance talks to a single irc server. Threw out all the old
6679 multi-server handling code. Still need to add back in
6680 builder-control (i.e. "force build")
6682 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6683 more random text to the as-yet-unreachable per-step page
6685 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6686 rename to stepETAUpdate
6687 (BuildStatus.subscribe): add build-wide ETA updates
6688 (BuilderStatus.getState): remove more cruft
6689 (BuilderStatus.getCurrentBuild): remove more cruft
6690 (BuilderStatus.buildStarted): really handle tuple-subscription
6691 * buildbot/test/test_run.py (Status.testSlave): handle the
6692 stepETAUpdate rename
6694 * buildbot/master.py (BuildMaster): don't add a default
6695 StatusClientService. Don't add a default IrcStatusFactory. Both
6696 are now added through c['status'] in the config file. c['irc'] is
6697 accepted for backwards compatibility, the only quirk is you cannot
6698 use c['irc'] to specify IRC servers on ports other than 6667.
6700 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6701 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6702 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6703 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6706 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6707 the buildmaster to re-read its config file
6710 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6711 find out the port our server is running on
6712 (WebTest.test_webPathname_port): same
6714 * buildbot/test/test_config.py (testWebPortnum): test it
6715 (testWebPathname): ditto
6717 * docs/config.xhtml: document new c['status'] configuration option
6719 * buildbot/status/html.py (Waterfall): new top-level class which
6720 can be added to c['status']. This creates the Site as well as the
6721 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6722 reachable as .parent, for everything.
6724 * buildbot/master.py (Manhole): make it a normal service Child
6725 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6726 webPathname. It will eventually replace c['irc'] and the implicit
6727 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6728 in as (deprecated) backward compatibility hooks for now.
6731 * buildbot/process/builder.py (Builder.buildFinished): don't
6732 inform out builder_status about a finished build, as it finds out
6733 through its child BuildStatus object
6735 * buildbot/status/html.py: extensive revamp. Use adapters to make
6736 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6737 have both starting and finishing times and adjust the waterfall
6738 display accordingly, using spacers if necessary. Use SlaveStatus
6739 to get buildslave info.
6740 (StatusResourceBuildStep): new just-one-step resource, used to get
6741 logfiles. No actual href to it yet.
6743 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6744 the time being, until I get the file-naming scheme right
6746 * buildbot/status/builder.py (Event): clean started/finished names
6747 (BuildStatus.isFinished): .finished is not None is the right test
6748 (BuildStatus.buildStarted): track started/finished times ourselves
6749 (BuilderStatus.getSlave): provide access to SlaveStatus object
6750 (BuilderStatus.getLastFinishedBuild): all builds are now in
6751 .builds, even the currently-running one. Accomodate this change.
6752 (BuilderStatus.eventGenerator): new per-builder event generator.
6753 Returns BuildStepStatus and BuildStatus objects, since they can
6754 both be adapted as necessary.
6755 (BuilderStatus.addEvent): clean up started/finished attributes
6756 (BuilderStatus.startBuild,finishBuild): remove dead code
6757 (SlaveStatus): new object to provide ISlaveStatus
6759 * buildbot/process/step.py (ShellCommand.getColor): actually
6760 return the color instead of setting it ourselves
6761 (CVS.__init__): pull .timeout and .workdir options out of
6762 **kwargs, since BuildStep will ignore them. Without this neither
6763 will be sent to the slave correctly.
6764 (SVN.__init__): same
6766 * buildbot/process/builder.py (Builder): move flags to class-level
6768 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6769 SlaveStatus handle that
6771 * buildbot/process/base.py (Build.firstEvent): remove dead code
6772 (Build.stopBuild): bugfix
6774 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6776 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6777 (ChangeMaster.eventGenerator): yield Changes, since there are now
6778 Adapters to turn them into HTML boxes
6780 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6781 (BotPerspective.attached): feed a SlaveStatus object
6782 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6783 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6785 * buildbot/interfaces.py: API additions
6786 (ISlaveStatus): place to get slave status
6788 2004-08-04 Brian Warner <warner@lothar.com>
6790 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6791 the delay finishes, so the step is marked as SUCCESS
6793 * buildbot/test/test_run.py (Status.testSlave): cover more of
6794 IBuildStatus and IBuildStepStatus
6796 * buildbot/status/progress.py (StepProgress): move some flags to
6797 class-level attributes
6798 (StepProgress.remaining): if there are no other progress metrics
6799 to go by, fall back to elapsed time
6800 (StepProgress.setExpectations): take a dict of metrics instead of
6802 (BuildProgress.setExpectationsFrom): pull expectations from the
6803 Expectations, instead of having it push them to the BuildProgress
6804 (Expectations): move some flags to class-level attributes
6805 (Expectations.__init__): copy per-step times from the
6807 (Expectations.expectedBuildTime): new method for per-build ETA
6809 * buildbot/status/event.py (Logfile): move some flags to
6810 class-level attributes
6811 (Logfile.logProgressTo): better method name, let step set the
6812 progress axis name (instead of always being "output")
6814 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6815 times directly, rather than depending upon the (possibly missing)
6816 .progress object. Use 'None' to indicate "not started/finished
6818 (BuildStepStatus.getExpectations): oops, return the full list of
6820 (BuilderStatus._buildFinished): append finished builds to .builds
6822 * buildbot/process/step.py (BuildStep): add separate .useProgress
6823 flag, since empty .progressMetrics[] still implies that time is a
6825 (CVS): set up the cmd in __init__, instead of waiting for start()
6827 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6828 calculation, this will eventually turn into a proper sourceStamp
6829 (Build.setupBuild): tell the Progress to load from the Expectations,
6830 instead of having the Expectations stuff things into the Progress
6831 (Build.buildException): add a build-level errback to make sure the
6832 build's Deferred fires even in case of exceptions
6834 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6836 * buildbot/process/builder.py (Builder.forceBuild): convey the
6837 reason instead of creating a fake Change
6839 * docs/examples/twisted_master.cfg: update to match reality
6841 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6842 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6843 fix or remove broken/breaking tests
6845 * buildbot/status/event.py (Logfile.__len__): remove evil method
6847 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6848 missing .build, for test convenience
6850 * buildbot/process/step_twisted.py: import fixes
6852 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6854 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6855 .statusbag reference
6857 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6858 connection at shutdown, and stop it from reconnecting
6860 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6861 chase down remote-execution bugs
6863 * buildbot/process/step.py: more fixes, remove
6864 BuildStep.setStatus()
6865 * buildbot/status/builder.py: move setStatus() functionality into
6867 * buildbot/status/event.py: minor fixes
6869 2004-08-03 Brian Warner <warner@lothar.com>
6871 * buildbot/process/base.py, buildbot/process/builder.py
6872 * buildbot/process/step.py, buildbot/status/builder.py
6873 * buildbot/status/event.py, buildbot/test/test_run.py:
6874 fix status delivery, get a basic test case working
6875 * buildbot/master.py: finish implementing basic status delivery,
6876 temporarily disable HTML/IRC/PB status sources
6878 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6880 * buildbot/status/progress.py (BuildProgress): remove dead code
6882 * buildbot/interfaces.py
6883 * buildbot/process/base.py, buildbot/process/builder.py
6884 * buildbot/process/step.py, buildbot/process/step_twisted.py
6885 * buildbot/status/builder.py: Complete overhaul of the all
6886 status-delivery code, unifying all types of status clients (HTML,
6887 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6888 look like. This commit is a checkpointing of the work-in-progress:
6889 the input side is mostly done (Builders/Builds sending status
6890 to the BuilderStatus/BuildStatus objects), but the output side has
6891 not yet been started (HTML resources querying BuilderStatus
6892 objects). Things are probably very broken right now and may remain
6893 so for several weeks, I apologize for the disruption.
6895 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6896 HTML as the log's contents. Currently used for exception tracebacks.
6897 * buildbot/status/progress.py: minor spelling changes
6899 2004-08-02 Brian Warner <warner@lothar.com>
6901 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6902 in mozilla. Also added stylesheets copied from Twisted's docs.
6903 Remember that these files are meant to be run through Lore first.
6904 Thanks to Philipp Frauenfelder for the fixes.
6905 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6906 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6907 * docs/template.tpl: added a Lore template
6909 2004-07-29 Brian Warner <warner@lothar.com>
6911 * buildbot/interfaces.py: revamp status delivery. This is the
6912 preview: these are the Interfaces that will be provided by new
6913 Builder code, and to which the current HTML/IRC/PB status
6914 displayers will be adapted.
6916 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6917 on the SlaveBuilder, not the Bot.
6918 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6920 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6921 set .usePTY on the FakeSlaveBuilder
6923 2004-07-25 Brian Warner <warner@lothar.com>
6925 * buildbot/changes/freshcvs.py: add some debug log messages
6926 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6927 disabled 'setFilter' syntax
6928 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6929 don't end with a slash
6931 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6933 * setup.py: bump to 0.5.0+ while between releases
6935 2004-07-23 Brian Warner <warner@lothar.com>
6937 * setup.py (version): Releasing buildbot-0.5.0
6939 2004-07-23 Brian Warner <warner@lothar.com>
6941 * README: update for 0.5.0 release
6943 * NEWS: update for 0.5.0 release
6945 2004-07-22 Brian Warner <warner@lothar.com>
6947 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6948 mktap-time configuration flag (--usepty=1, --usepty=0)
6949 * buildbot/bot.py: same
6951 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6952 an 'info' directory being unwanted
6954 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6955 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6956 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6957 and earlier), use a FreshCVSSourceOldcred instead.
6958 (test): simple test routine: connect to server, print changes
6960 * buildbot/changes/changes.py (Change.getTime): make it possible
6961 to print un-timestamped changes
6963 * buildbot/master.py (makeApp): delete ancient dead code
6964 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6965 * buildbot/test/test_config.py (testFindConfigFile): test it
6967 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6968 instead of win32 one
6971 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6972 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6975 * buildbot/process/base.py (Builder.__init__): change constructor
6976 to accept a dictionary of config data, rather than discrete
6977 name/slave/builddir/factory arguments
6979 * docs/examples/twisted_master.cfg: update to new syntax
6980 * docs/examples/glib_master.cfg: same
6981 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6982 rough tests of the new syntax
6985 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6986 to be an int, which means "run a web.distrib sub-server on a TCP
6987 port". This lets you publish the buildbot status page to a remote
6988 twisted.web server (using distrib.ResourceSubscription). Also
6989 rename the local attributes used to hold these web things so
6990 they're more in touch with reality.
6991 * buildbot/test/test_web.py: test webPortnum and webPathname
6992 * docs/config.xhtml: document this new use of webPathname
6994 * docs/config.xhtml: new document, slightly ahead of reality
6996 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6997 'prefix' handling: treat it as a simple string to check with
6998 .startswith, instead of treating it as a directory. This allows
6999 sub-directories to be used. If you use prefix=, you should give it
7000 a string that starts just below the CVSROOT and ends with a slash.
7001 This prefix will be stripped from all filenames, and filenames
7002 which do not start with it will be ignored.
7004 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7006 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7007 and --exclude (inverse of --include). SVN post-commit hooks
7008 now have total control over which changes get sent to buildbot and which
7011 2004-07-10 Brian Warner <warner@lothar.com>
7013 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7014 test case to match new API
7016 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7017 which crashed HTML display when self.entries=[] (needed to
7018 distinguish between [], which means "no entries yet", and None,
7019 which means "the entries have been swapped out to disk, go fetch
7022 2004-07-04 Brian Warner <warner@lothar.com>
7024 * buildbot/process/step_twisted.py (countFailedTests): Count
7025 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7026 10kb from the end because any import errors are wedged there and
7027 they would make us think the test log was unparseable.
7028 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7030 2004-06-26 Brian Warner <warner@lothar.com>
7032 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7033 delete-*.pyc command into an actual BuildStep, so we can label it
7035 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7036 (FullTwistedBuildFactory): same
7038 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7040 * contrib/fakechange.py: Add an errback when sending the fake
7041 change, so we know it didn't work.
7043 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7045 * buildbot/process/step_twisted.py: Delete *.pyc files before
7046 calling trial, so it doesn't catch any old .pyc files whose .py
7047 files have been moved or deleted.
7049 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7050 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7051 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7052 instead of ["twisted.test"], so that the end result is "trial -R
7055 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7056 regular expression to match filenames that should be ignored when
7057 changed. Also add a --revision parameter that specifies the
7058 revision to examine, which is useful for debugging.
7060 2004-06-25 Brian Warner <warner@lothar.com>
7062 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7063 summary of warnings (like DeprecationWarnings), next to the
7066 2004-05-13 Brian Warner <warner@lothar.com>
7068 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7069 we now have a w32 build slave courtesy of Mike Taylor.
7071 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7072 so broken. Fixed a race condition that tripped up interlocked
7073 builds and caused the status to be stuck at "Interlocked" forever.
7074 The twisted buildbot's one interlocked build just so happened to
7075 never hit this case until recently (the feeding builds both pass
7076 before the interlocked build is attempted.. usually it has to wait
7078 (Builder._pong_failed): fix method signature
7080 * setup.py: bump to 0.4.3+ while between releases
7082 2004-04-30 Brian Warner <warner@lothar.com>
7084 * setup.py (version): Releasing buildbot-0.4.3
7086 2004-04-30 Brian Warner <warner@lothar.com>
7088 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7090 * README: update for 0.4.3 release
7092 * NEWS: update for 0.4.3 release
7094 * buildbot/master.py (BuildMaster.__getstate__): make sure
7095 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7097 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7098 .trial as a class attribute, for upgrade from 0.4.2
7100 * buildbot/changes/changes.py (Change.links): add .links for
7103 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7104 .textWatchers and .htmlWatchers at save time, since they are both
7105 volatile, should allow smooth 0.4.2 upgrade
7107 * buildbot/process/step.py (CVS.finishStatus): catch failed
7108 CVS/SVN commands so we can make the status box red
7110 2004-04-29 Brian Warner <warner@lothar.com>
7112 * buildbot/changes/freshcvs.py
7113 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7114 code to do setFilter(), which tells the freshcvs daemon to not
7115 send us stuff that we're not interested in. I will uncomment it
7116 when a new version of CVSToys is available in which setFilter()
7117 actually works, and I get a chance to test it better.
7119 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7121 * buildbot/master.py (Dispatcher): use a registration scheme
7122 instead of hardwired service names
7123 (BuildMaster): keep track of the Dispatcher to support
7126 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7127 PBChangeSource class instead of having it be an undocumented
7128 internal feature of the ChangeMaster. Split out the code into a
7130 * buildbot/changes/pb.py (PBChangeSource): same
7131 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7133 * docs/{factories|sources|steps}.xhtml: document some pieces
7135 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7136 using FCMaildirSource
7137 (f23osx): update OS-X builder to use python2.3, since the slave
7138 was updated to Panther (10.3.3)
7140 2004-03-21 Brian Warner <warner@lothar.com>
7142 * buildbot/process/process_twisted.py: factor out doCheckout, change
7143 to use SVN instead of CVS
7145 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7146 an SVN subclass easier
7147 (BasicSVN): subclass which uses Subversion instead of CVS
7149 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7151 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7153 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7155 2004-02-25 Brian Warner <warner@lothar.com>
7157 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7158 is now either a list (which is passed to spawnProcess directly) or
7159 a string (which gets passed to /bin/sh -c). This removes the useSH
7160 flag and the ArgslistCommand class. Also send status header at the
7161 start and end of each command, instead of having the master-side
7163 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7164 -r'. Update to use list-based arguments.
7165 (SVNFetch): use list-based arguments, use ['dir'] argument to
7167 * buildbot/test/test_steps.py (Commands): match changes
7169 * buildbot/process/step.py (InternalShellCommand.words): handle
7171 (SVN): inherit from CVS, cleanup
7173 * buildbot/status/event.py (Logfile.content): render in HTML, with
7174 stderr in red and headers (like the name of the command we're
7175 about to run) in blue. Add link to a second URL (url + "?text=1")
7176 to get just stdout/stderr in text/plain without markup. There is
7177 still a problem with .entries=None causing a crash, it seems to occur
7178 when the logfile is read before it is finished.
7180 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7181 timeout to the keepalives, and use it to explicitly do a
7182 loseConnection instead of waiting for TCP to notice the loss. This
7183 ought to clear up the silent-lossage problem.
7184 (unsafeTracebacks): pass exception tracebacks back to the master,
7185 makes it much easier to debug problems
7187 2004-02-23 Brian Warner <warner@lothar.com>
7189 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7190 the whole command to /bin/sh instead of execve [Johan Dahlin]
7191 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7192 '-r HEAD' [Johan Dahlin]
7193 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7195 * buildbot/changes/changes.py (Change): add links= argument, add
7196 asHTML method [Johan Dahlin]. Modified to make a bit more
7197 XHTMLish. Still not sure how to best use links= .
7199 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7200 Change.asHTML to display the change, not asText
7202 * buildbot/status/html.py (StatusResourceBuilder): web button to
7205 * buildbot/test/test_run.py: test to actually start a buildmaster
7208 * MANIFEST.in: bring back accidentally-dropped test helper files
7210 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7211 that require cvstoys if it is not installed
7213 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7214 values of "bin/trial" [Dave Peticolas]
7215 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7216 tests passed" when we didn't happen to run any tests
7218 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7219 flunkOnFailure [Johan Dahlin]
7221 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7222 multiple instances of the same Step class by suffixing "_2", etc,
7223 to the name until it is unique. This name needs to be unique
7224 because it is used as a key in the dictionary that tracks build
7226 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7229 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7231 2004-01-14 Brian Warner <warner@lothar.com>
7233 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7234 kicked from a channel, log it
7236 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7237 something over whatever IRC channels the buildmaster is currently
7238 connected to. Added to try and track down a problem in which the
7239 master thinks it is still connected but the IRCd doesn't see it. I
7240 used a styles.Versioned this time, so hopefully users won't have
7241 to rebuild their .tap files this time.
7242 * contrib/debug.glade: add a "Poke IRC" button
7243 * contrib/debugclient.py: same
7245 * setup.py: bump to 0.4.2+ while between releases
7247 2004-01-08 Brian Warner <warner@lothar.com>
7249 * setup.py (version): Releasing buildbot-0.4.2
7251 2004-01-08 Brian Warner <warner@lothar.com>
7253 * NEWS: update for 0.4.2 release
7255 * README: document how to run the tests, now that they all pass
7257 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7259 * buildbot/process/step.py (CVS): add a global_options= argument,
7260 which lets you set CVS global options for the command like "-r"
7261 for read-only checkout, or "-R" to avoid writing in the
7263 * buildbot/slavecommand.py (CVSCommand): same
7265 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7266 testing easier (it is turned off when testing, to avoid the
7269 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7270 to make it easier to test: break generateStepID() out to a
7271 separate function, only update statusbag if it exists.
7272 (ShellCommands): create useful text for dict-based commands too.
7274 * test/*, buildbot/test/*: move unit tests under the buildbot/
7276 * setup.py (packages): install buildbot.test too
7278 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7279 * buildbot/test/test_steps.py: fix it, tests pass now
7281 2004-01-06 Brian Warner <warner@lothar.com>
7283 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7284 freshcvs mail uses a slightly different syntax for new
7285 directories. Update parser to handle either.
7286 * test/test_mailparse.py (Test1.testMsg9): test for same
7288 2003-12-21 Brian Warner <warner@lothar.com>
7290 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7291 'warnOnWarnings' so that lintian errors mark the build orange
7293 2003-12-17 Brian Warner <warner@lothar.com>
7295 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7296 messages emitted by Bonsai, contributed by Stephen Davis.
7298 * test/*: moved all tests to use trial instead of unittest. Some
7299 still fail (test_steps, test_slavecommand, and test_process).
7301 * setup.py (version): bump to 0.4.1+ while between releases
7303 2003-12-09 Brian Warner <warner@lothar.com>
7305 * setup.py (version): Releasing buildbot-0.4.1
7307 2003-12-09 Brian Warner <warner@lothar.com>
7309 * NEWS: update for 0.4.1 release
7311 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7312 freebsd builder code a little bit
7314 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7315 don't try to compare attributes of different classes
7316 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7317 (MaildirSource.messageReceived): fix Change delivery
7319 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7320 into the config file's namespace before loading it, like the
7321 documentation claims it does
7322 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7323 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7324 daemon comes back online
7326 2003-12-08 Brian Warner <warner@lothar.com>
7328 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7329 so the example will work with online=0 as well
7331 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7332 fix the __implements__ line
7334 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7335 class a twisted.application.service.Service, use startService to
7338 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7339 directory fd instead of simple open(). I'm sure this used to work,
7340 but the current version of python refuses to open directories with
7343 2003-12-05 Brian Warner <warner@lothar.com>
7345 * setup.py (version): bump to 0.4.0+ while between releases
7347 2003-12-05 Brian Warner <warner@lothar.com>
7349 * setup.py (version): Releasing buildbot-0.4.0
7351 2003-12-05 Brian Warner <warner@lothar.com>
7353 * docs/examples/glib_master.cfg: replace old sample scripts with
7354 new-style config files
7355 * MANIFEST.in: include .cfg files in distribution tarball
7357 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7358 implement a dummy method to avoid the exception that occurs when
7359 freshcvs sends this to us.
7361 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7362 removed the method, as it broke reconnection. Apparently
7363 stopFactory is called each time the connection attempt fails. Must
7365 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7366 attribute before serialization, since without stopFactory the
7367 reconnect timer may still be active and they aren't serializable.
7369 * test/test_mailparse.py (ParseTest): test with 'self' argument
7371 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7372 argument, as these "functions" are invoked like methods from class
7373 attributes and therefore always get an instance as the first
7376 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7377 message: thanks to Stephen Davis for the catch
7379 2003-12-04 Brian Warner <warner@lothar.com>
7381 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7382 twisted's standard ReconnectingClientFactory. Handles both oldcred
7383 and newcred connections. Also has a bug-workaround for
7384 ReconnectingClientFactory serializing its connector when it
7387 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7388 pbutil. Replace makeApp stuff with proper newcred/mktap
7389 makeService(). Don't serialize Ephemerals on shutdown.
7391 * buildbot/changes/changes.py (ChangeMaster): make it a
7392 MultiService and add the sources as children, to get startService
7393 and stopService for free. This also gets rid of the .running flag.
7395 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7396 new pbutil, turn into a TCPClient at the same time (to get
7397 startService for free). Two variants exist: FreshCVSSourceOldcred
7398 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7399 yet, but when it does, we'll be ready).
7400 (FreshCVSSource.notify): handle paths which are empty after the
7401 prefix is stripped. This only happens when the top-level (prefix)
7402 directory is added, at the very beginning of a Repository's life.
7404 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7405 Now the only reconnecting code is in the factory where it belongs.
7406 (Builder.unsubscribe): unregister the disconnect callback when we
7407 delete the builder on command from the master (i.e. when the
7408 buildmaster is reconfigured and that builder goes away). This
7409 fixes a multiple-delete exception when the status client is shut
7411 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7414 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7415 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7417 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7419 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7420 a list of globs (ugh). The testdir will be searched for files
7421 named *.tests and run the tests in the order specified in each of
7422 those files. This allows for "dependancies" between tests to be
7425 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7426 argument to pass to run_maxq.py, instead of a glob.
7428 2003-10-17 Brian Warner <warner@lothar.com>
7430 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7431 files that live in the sandbox
7433 2003-10-15 Brian Warner <warner@lothar.com>
7435 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7436 spelling error in "docs" count-warnings output
7437 (HLint.start): stupid thinko meant .xhtml files were ignored
7439 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7440 tests now that cReactor is banished to the sandbox
7442 2003-10-10 Brian Warner <warner@lothar.com>
7444 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7445 scheme: now .xhtml are sources and .html are generated
7447 2003-10-08 Brian Warner <warner@lothar.com>
7449 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7450 we were ignoring the 'randomly' parameter.
7452 2003-10-01 Brian Warner <warner@lothar.com>
7454 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7455 posix, to kill sub-children of aborted slavecommands.
7457 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7458 Clean up initialization: lastBuildStatus remains None until the
7459 first build has been completed.
7461 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7462 None as a lastBuildStatus
7463 * buildbot/clients/gtkPanes.py: same
7465 * buildbot/status/client.py (StatusClientService): keep
7466 BuilderStatus objects in self.statusbags . These objects now live
7467 here in the StatusClientService and are referenced by the Builder
7468 object, rather than the other way around.
7469 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7470 * buildbot/process/base.py (Builder): same
7471 * test/test_config.py (ConfigTest.testBuilders): same
7473 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7474 an existing builder, leave the statusbag alone. This will preserve the
7477 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7478 hook. This will probably go away in favor of a class in upcoming
7481 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7482 serviceName from newcred FreshCVSNotifiee setup
7484 2003-09-29 Brian Warner <warner@lothar.com>
7486 * buildbot/process/process_twisted.py: switch to new reactor
7488 * docs/examples/twisted_master.cfg: same
7490 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7492 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7493 botmaster reference instead of the oldapp service lookup
7495 * buildbot/master.py (BuildMaster.__init__): give the
7496 StatusClientService a reference to the botmaster to make it easier to
7499 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7501 * buildbot/status/html.py (Box.td): escape hreffy things so you
7502 can have spaces in things like builder names
7503 (StatusResourceBuilder.body)
7504 (WaterfallStatusResource.body)
7505 (WaterfallStatusResource.body0): same
7507 2003-09-25 Brian Warner <warner@lothar.com>
7509 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7510 rearrange the builder list when adding or removing builders: keep
7511 them in the order the user requested.
7512 * test/test_config.py (ConfigTest.testBuilders): verify it
7514 * contrib/debug.glade: give the debug window a name
7516 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7517 now wait on multiple interlocks. Fix code relating to that.
7518 (Builder.checkInterlocks): same
7519 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7521 * buildbot/master.py (BuildMaster.loadConfig): move from
7522 deprecated pb.BrokerFactory to new pb.PBServerFactory
7523 * test/test_config.py (ConfigTest.testWebPathname): same
7525 * docs/examples/twisted_master.cfg: fix interlock declaration
7527 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7528 Interlocks to their Builders into interlock.py .
7529 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7531 * test/test_config.py (ConfigTest.testInterlocks): validate
7534 * buildbot/process/base.py (Builder.__init__): better comments
7535 * buildbot/process/interlock.py (Interlock.__repr__): same
7536 (Interlock.deactivate): add .active flag, move the code that
7537 attaches/detaches builders into the Interlock
7539 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7541 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7542 tests using the new run_maxq.py script, and reporting failures by
7545 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7546 tests, reporting their success or failure in a buildbot-friendly
7549 2003-09-24 Brian Warner <warner@lothar.com>
7551 * docs/examples/twisted_master.cfg: example of a new-style config
7552 file. This lives in the buildmaster base directory as
7555 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7556 button to make the master re-read its config file
7558 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7559 buildmaster configuration from a file. This file can be re-read
7560 later, and the buildmaster will update itself to match the new
7561 desired configuration. Also use new Twisted Application class.
7562 * test/Makefile, test/test_config.py: unit tests for same
7564 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7565 FreshCVSSources comparable, to support reload.
7566 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7568 * buildbot/process/base.py (Builder): make them comparable, make
7569 Interlocks easier to attach, to support reload. Handle
7570 re-attachment of remote slaves.
7571 * buildbot/process/interlock.py (Interlock): same
7573 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7574 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7575 buildmaster taps are now constructed with mktap.
7576 * buildbot/status/client.py (StatusClientService): same
7578 * buildbot/status/words.py: move to new Services, add support to
7579 connect to multiple networks, add reload support, allow nickname
7580 to be configured on a per-network basis
7582 2003-09-20 Brian Warner <warner@lothar.com>
7584 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7585 the freebsd builder, now that the machine has been upgraded and no
7586 longer has python2.2
7588 * setup.py (version): bump to 0.3.5+ while between releases
7590 2003-09-19 Brian Warner <warner@lothar.com>
7592 * setup.py (version): Releasing buildbot-0.3.5
7594 2003-09-19 Brian Warner <warner@lothar.com>
7596 * NEWS: add post-0.3.4 notes
7598 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7600 * MANIFEST.in: add contrib/*
7602 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7603 use a remote root now: cvs.twistedmatrix.com
7605 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7607 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7608 compatibility with old servers
7609 (FreshCVSSource.start): and provide a way to use it
7610 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7612 * docs/examples/twisted_master.py (twisted_app): update to new
7614 (twisted_app): listen on new ~buildbot socket
7615 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7617 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7618 to reduce cvs bandwidth (update instead of full checkout)
7620 2003-09-11 Brian Warner <warner@lothar.com>
7622 * contrib/fakechange.py: demo how to connect to the changemaster
7623 port. You can use this technique to submit changes to the
7624 buildmaster from source control systems that offer a hook to run a
7625 script when changes are committed.
7627 * contrib/debugclient.py: tool to connect to the debug port. You
7628 can use it to force builds, submit fake changes, and wiggle the
7631 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7632 'Dispatcher' realm to handle all the different kinds of
7633 connections and Perspectives: buildslaves, the changemaster port,
7634 the debug port, and the status client port. NewCredPerspectives
7635 now have .attached/.detached methods called with the remote 'mind'
7636 reference, much like old perspectives did. All the pb.Services
7637 turned into ordinary app.ApplicationServices .
7638 (DebugService): went away, DebugPerspectives are now created
7639 directly by the Dispatcher.
7640 (makeApp): changed interface a little bit
7642 * buildbot/changes/changes.py: newcred
7643 * buildbot/status/client.py: newcred
7645 * buildbot/clients/base.py: newcred client side changes
7646 * buildbot/bot.py: ditto
7648 * docs/examples/glib_master.py: handle new makeApp() interface
7649 * docs/examples/twisted_master.py: ditto
7651 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7652 base newcred Perspectives on. This should go away once Twisted
7653 itself provides something sensible.
7656 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7658 * contrib/svn_buildbot.py: A program that you can call from your
7659 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7660 when a change in an SVN repository has happened. See the top of
7661 the file for some minimal usage info.
7663 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7665 * buildbot/slavecommand.py (ArglistCommand): Add new
7666 ArglistCommand that takes an argument list rather than a string as
7667 a parameter. Using a st.split() for argv is very bad.
7669 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7670 update to a particular revision rather than always checking out
7671 (still not very smart about it, there may be cases where the
7672 checkout becomes inconsistent).
7674 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7676 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7677 SVN fetch support. It can checkout (not update!) a specified
7678 revision from a specified repository to a specified directory.
7680 * buildbot/status/progress.py (Expectations.update): Fix an
7681 obvious bug (apparently created by the change described in the
7682 previous ChangeLog message) by moving a check to *after* the
7683 variable it checks is defined.
7686 2003-09-08 Brian Warner <warner@lothar.com>
7688 * buildbot/status/progress.py (Expectations.update): hack to catch
7689 an exception TTimo sees: sometimes the update() method seems to
7690 get called before the step has actually finished, so the .stopTime
7691 is not set, so no totalTime() is available and we average None
7692 with the previous value. Catch this and just don't update the
7693 metrics, and emit a log message.
7695 2003-08-24 Brian Warner <warner@lothar.com>
7697 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7698 parameter to set copydir='original' in CVS commands.
7700 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7702 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7703 which tells the command to maintain a separate original-source CVS
7704 workspace. For each build, this workspace will be updated, then
7705 the tree copied into a new workdir. This reduces CVS bandwidth
7706 (from a full checkout to a mere update) while doubling the local
7707 disk usage (to keep two copies of the tree).
7709 2003-08-21 Brian Warner <warner@lothar.com>
7711 * buildbot/status/event.py (Logfile.addEntry): if the master web
7712 server dies while we're serving a page, request.write raises
7713 pb.DeadReferenceError . Catch this and treat it like a
7714 notifyFinish event by dropping the request.
7716 2003-08-18 Brian Warner <warner@lothar.com>
7718 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7719 (instead of blowing up) if a force-build command is given without
7722 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7723 don't blow up if there aren't yet any Changes in the list
7725 2003-08-02 Brian Warner <warner@lothar.com>
7727 * buildbot/bot.py (updateApplication): don't set the .tap name,
7728 since we shouldn't assume we own the whole .tap file
7730 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7731 'mktap buildbot' (without a subcommand) better
7733 2003-07-29 Brian Warner <warner@lothar.com>
7735 * buildbot/status/words.py
7736 (IrcStatusFactory.clientConnectionLost): when we lose the
7737 connection to the IRC server, schedule a reconnection attempt.
7739 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7740 use shutil.rmtree instead of forking off an "rm -rf" command.
7741 rmtree may take a while and will block until it finishes, so we
7742 use "rm -rf" if available.
7744 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7745 freebsd buildslave badly
7747 * setup.py (version): bump to 0.3.4+ while between releases
7749 2003-07-28 Brian Warner <warner@lothar.com>
7751 * setup.py (version): Releasing buildbot-0.3.4
7753 2003-07-28 Brian Warner <warner@lothar.com>
7755 * NEWS: update in preparation for release
7757 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7758 process.signalProcess instead of os.kill, to improve w32
7761 * docs/examples/twisted_master.py (twisted_app): turn off
7762 win32eventreactor: the tests hang the buildslave badly
7764 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7765 failed builds, since usually the failures are consistent
7767 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7768 add compileOpts/compileOpts2 to reactors build
7770 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7771 (twisted_app): use both default and win32eventreactor on w32 build.
7772 Use both default and kqreactor on freebsd build.
7774 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7775 add compileOpts2, which is put after the build_ext argument. w32
7776 needs "-c mingw32" here.
7778 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7779 touch .acqpath, it goes away in recent Twisted releases
7781 * docs/examples/twisted_master.py (twisted_app): use "python" for
7782 the w32 buildslave, not "python2.2"
7784 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7785 the directory exists.. should hush an exception under w32
7787 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7788 ProcessTerminated -provided values for signal and exitCode rather
7789 than parsing the unix status code directly. This should remove one
7790 more roadblock for a w32-hosted buildslave.
7792 * test/test_mailparse.py: add test cases for Syncmail parser
7794 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7795 temporary compatibility import. Note! Start importing
7796 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7798 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7800 2003-07-27 Brian Warner <warner@lothar.com>
7802 * NEWS: started adding new features
7804 * buildbot/changes/mail.py: start work on Syncmail parser, move
7805 mail sources into their own file
7807 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7808 as implementing IChangeSource
7809 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7811 * buildbot/interfaces.py: define the IChangeSource interface
7813 2003-07-26 Brian Warner <warner@lothar.com>
7815 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7817 2003-06-25 Brian Warner <warner@lothar.com>
7819 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7822 2003-06-17 Brian Warner <warner@lothar.com>
7824 * buildbot/status/words.py: clean up method usage to avoid error
7825 in silly IRC command
7826 (IrcStatusBot.emit_status): round off seconds display
7828 * buildbot/process/base.py (Build): delete the timer when saving
7829 to the .tap file, and restore it (if it should still be running)
7830 upon restore. This should fix the "next build in -34 seconds"
7831 messages that result when the master is restarted while builds are
7832 sitting in the .waiting slot. If the time for the build has
7833 already passed, start it very soon (in 1 second).
7835 * buildbot/status/words.py: more silly commands
7837 * README (REQUIREMENTS): add URLs to all required software
7839 * buildbot/status/words.py ('last'): mention results of, and time
7842 2003-05-28 Brian Warner <warner@lothar.com>
7844 * buildbot/status/words.py: add 'last' command
7845 (IrcStatusBot.emit_status): add current-small text to 'status' output
7847 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7848 (twisted_app): remove spaces from OS-X builder name
7850 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7851 * buildbot/status/words.py: IRC bot should actually be useful now
7853 2003-05-23 Brian Warner <warner@lothar.com>
7855 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7856 "slave information" from $(slavedir)/info/* . These files are
7857 maintained by the slave administrator, and describe the
7858 machine/environment that is hosting the slave. Information from
7859 them is put into the "Builder" HTML page. Still need to establish
7860 a set of well-known filenames and meanings for this data: at the
7861 moment, *all* info/* files are sent to the master, but only
7862 'admin' and 'host' are used on that end.
7863 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7864 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7865 * buildbot/master.py (BotPerspective.got_info): ditto
7867 2003-05-22 Brian Warner <warner@lothar.com>
7869 * setup.py (version): bump version to 0.3.3+ while between releases
7871 2003-05-21 Brian Warner <warner@lothar.com>
7873 * setup.py: Releasing buildbot-0.3.3
7875 2003-05-21 Brian Warner <warner@lothar.com>
7877 * NEWS: 0.3.3 news items
7879 * README: describe --keepalive and life behind a NAT box
7881 * buildbot/bot.py (Bot.connected): implement application-level
7882 keepalives to deal with NAT timeouts, turn them on with
7883 --keepalive option or when SO_KEEPALIVE doesn't work.
7885 * buildbot/master.py (BotPerspective): accept keepalives silently
7887 * buildbot/process/base.py (Build.buildException): CopiedFailures
7888 don't carry as much information as local ones, so don't try to
7889 create a big HTMLized version of them.
7891 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7892 log file when step fails due to an exception, such as when the slave
7895 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7896 --testmodule argument instead of grepping for test-case-name tags
7897 ourselves. Remove FindUnitTests code.
7898 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7900 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7902 2003-05-16 Brian Warner <warner@lothar.com>
7904 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7905 argument to allow things like CFLAGS=-O0 to be passed without relying
7906 upon /bin/sh processing on the slave.
7908 * buildbot/process/step.py (InternalShellCommand.start): send
7910 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7911 'split' instead of letting /bin/sh do it. This should also remove
7912 the need for /bin/sh on the buildslave, making it more likely to
7915 * buildbot/status/html.py: html-escape text in blamelist.
7916 Add "force build" button to the Builder page.
7918 * buildbot/process/step_twisted.py (countFailedTests): look at
7919 last 1000 characters for status line, as import errors can put it
7920 before the -200 point.
7922 2003-05-15 Brian Warner <warner@lothar.com>
7924 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7926 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7927 make 'clobber' a parameter, so it is possible to have builds which
7928 do full tests but do a cvs update instead of hammering the CVS
7929 server with a full checkout each build
7931 * buildbot/process/step.py (InternalShellCommand): bump default
7932 timeout to 20 minutes
7934 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7935 the master to trigger a build. Run it via manhole.
7937 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7938 allow slaves to trigger any build that they host, to make life
7939 easier for slave admins who are testing out new build processes
7941 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7942 don't flunk cReactor or qtreactor on failure, since they fail alot
7943 these days. Do warnOnFailure instead.
7945 * buildbot/process/base.py: change Builder.buildable from a list
7946 into a single slot. When we don't have a slave, new builds (once
7947 they make it past the timeout) are now merged into an existing
7948 buildable one instead of being queued. With this change, a slave
7949 which has been away for a while doesn't get pounded with all the
7950 builds it missed, but instead just does a single build.
7952 2003-05-07 Brian Warner <warner@lothar.com>
7954 * setup.py (version): bump version to 0.3.2+ while between releases
7956 2003-05-07 Brian Warner <warner@lothar.com>
7958 * setup.py: Releasing buildbot-0.3.2
7960 2003-05-07 Brian Warner <warner@lothar.com>
7962 * setup.py: fix major packaging error: include subdirectories!
7964 * NEWS: add changes since last release
7966 * README (REQUIREMENTS): update twisted/python dependencies
7968 * buildbot/status/builder.py (Builder.startBuild): change
7969 BuildProcess API: now they should call startBuild/finishBuild
7970 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7971 keeping a list of builds in the statusbag, to support other kinds of
7973 (Builder.addClient): send current-activity-small to new clients
7974 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7977 * buildbot/status/client.py: drop RemoteReferences at shutdown
7979 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7981 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7982 more debug messages for remote status client
7984 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7985 (.stepFailed): only fire the Deferred once, even if both
7986 stepComplete and stepFailed are called. I think this can happen if
7987 an exception occurs at a weird time.
7989 * buildbot/status/words.py: work-in-progress: IRC status delivery
7991 2003-05-05 Brian Warner <warner@lothar.com>
7993 * docs/examples/twisted_master.py (twisted_app): hush internal
7994 python2.3 distutils deprecation warnings
7995 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7996 add compileOpts= argument which inserts extra args before the
7997 "setup.py build_ext" command. This can be used to give -Wignore
7998 warnings, to hush some internal python-2.3 deprecation messages.
8000 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8001 the ['twisted.test'] default test case to make it easier to change
8004 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8005 * buildbot/clients/gtkPanes.py: ditto
8007 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8008 arg to collapse RunUnitTestsRandomly into RunUnitTests
8009 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8010 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8012 * buildbot/status/html.py (StatusResource): shuffle Resources
8013 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8014 would serve the waterfall display, but the internal links were
8015 only valid on the trailing-slash version. The correct behavior is
8016 for the non-slashed one to serve a Redirect to the slashed one.
8017 This only shows up when the buildbot page is hanging off another
8018 server, like a Twisted-Web distributed server.
8020 * buildbot/status/event.py (Event, RemoteEvent): make Events
8021 pb.Cacheable, with RemoteEvent as the cached version. This removes
8022 a lot of explicit send-an-update code.
8023 * buildbot/status/builder.py (Builder): remove send-update code
8024 * buildbot/status/client.py (ClientBuilder): remove send-update
8025 code, and log errors that occur during callRemote (mostly to catch
8026 InsecureJelly exceptions)
8028 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8029 run Lore with the same python used in the rest of the build
8031 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8033 * buildbot/process/step_twisted.py (HLint): accept 'python'
8034 argument. Catch rc!=0 and mark the step as failed. This marks the
8035 build orange ("has warnings").
8036 (RunUnitTestsJelly): move out to step_twisted2.py
8038 * buildbot/util.py (ignoreStaleRefs): add utility function
8040 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8041 don't fake ETA object, it's too hard to get right
8043 2003-05-02 Brian Warner <warner@lothar.com>
8045 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8047 2003-05-01 Brian Warner <warner@lothar.com>
8049 * buildbot/status/html.py (StatusResource.body): oops, I was
8050 missing a <tr>, causing the waterfall page to be misrendered in
8051 everything except Galeon.
8053 2003-04-29 Brian Warner <warner@lothar.com>
8055 * docs/examples/twisted_master.py: make debuild use python-2.2
8056 explicitly, now that Twisted stopped supporting 2.1
8058 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8059 handle tuple results too. I keep forgetting this, which suggests
8060 it needs to be rethought.
8062 * setup.py (setup): bump version to 0.3.1+ while between releases
8064 2003-04-29 Brian Warner <warner@lothar.com>
8066 * setup.py: Releasing buildbot-0.3.1
8068 2003-04-29 Brian Warner <warner@lothar.com>
8070 * README (SUPPORT): add plea to send questions to the mailing list
8072 * NEWS, MANIFEST.in: add description of recent changes
8074 * docs/examples/twisted_master.py: add the code used to create the
8075 Twisted buildmaster, with passwords and such removed out to a
8078 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8079 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8080 buildmasters to not require CVSToys be installed.
8081 * README, docs/examples/glib_master: update to match the change
8083 * buildbot/clients/base.py, buildbot/bot.py,
8084 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8085 ReconnectingPB from CVSToys distribution to remove CVSToys
8086 dependency for build slaves and status clients. Buildmasters which
8087 use FreshCVSSources still require cvstoys be installed, of course.
8089 2003-04-25 Brian Warner <warner@lothar.com>
8091 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8092 runTestsRandomly arg to turn on trial -z
8094 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8095 experimental code to use trial's machine-parseable output to get
8096 more detailed test results. Still has some major issues.
8097 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8100 * buildbot/status/builder.py (Builder.setCurrentBuild):
8101 anticipating moving build history into statusbag, not used yet
8103 * buildbot/status/tests.py: code to centralize test results,
8104 doesn't work quite yet
8106 * buildbot/status/event.py (Event): use hasattr("setName") instead
8107 of isinstance for now.. need better long-term solution
8109 * buildbot/status/html.py: Remove old imports
8111 2003-04-24 Brian Warner <warner@lothar.com>
8113 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8114 ignore changes under doc/fun/ and sandbox/
8116 * buildbot/process/step_twisted.py: update pushEvent and friends.
8118 * buildbot/status/html.py (Box.td): replace event.buildername with
8119 event.parent.getSwappableName(). Needs more thought.
8121 * buildbot/status/builder.py (Builder): Replace pushEvent and
8122 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8123 Tell events they are being pruned with event.delete().
8125 * buildbot/process/base.py (Build): Remove Builder status-handling
8126 methods. s/pushEvent/setCurrentActivity/.
8128 * buildbot/process/step.py (BuildStep): clean up status delivery.
8129 Gouse builder.statusbag methods instead of intermediate builder
8130 methods. s/updateLastEvent/updateCurrentActivity/.
8131 s/finalizeLastEvent/finishCurrentActivity/. Use
8132 addFileToCurrentActivity for summaryFunction.
8134 * buildbot/status/event.py (Logfile): put data in a Swappable when
8136 (Event): add more setter methods. Remove .buildername, use .parent
8137 and getSwappableName instead (needs more thought).
8139 * buildbot/util.py (Swappable):
8140 * test/test_swap.py: don't bother setting filename at __init__
8141 time, do it later. Change setFilename args to take parent first,
8142 since it provides the most significant part of the filename.
8144 2003-04-23 Brian Warner <warner@lothar.com>
8146 * buildbot/status/event.py (Logfile.addEntry): append to previous
8149 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8150 anticipating Swappable
8151 (InternalShellCommand.remoteUpdate): split out various log-adding
8152 methods so subclasses can snarf stdout separately
8154 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8155 in anticipation of Swappable build logs
8156 (Builder.testsFinished): anticipating TestResults, still disabled
8158 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8161 * buildbot/status/event.py (Logfile): add (disabled) support for
8162 Swappable, not ready for use yet
8164 * buildbot/util.py (Swappable): object which is swapped out to
8165 disk after some period of no use.
8166 * test/test_swap.py: test buildbot.utils.Swappable
8168 2003-04-14 Brian Warner <warner@lothar.com>
8170 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8171 periodic-build timer. Set the .periodicBuildTime on a builder
8172 instance to some number of seconds to activate it.
8174 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8176 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8177 a way that survives result tuples
8179 2003-04-12 Brian Warner <warner@lothar.com>
8181 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8182 return a dict instead of a tuple: allow summarizers to provide
8183 multiple summaries if they want
8184 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8185 (debuildSummarizer): summarize lintian warnings/errors
8187 2003-04-10 Brian Warner <warner@lothar.com>
8189 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8191 2003-04-09 Brian Warner <warner@lothar.com>
8193 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8194 empty summaries: happens when the tests fail so hard they don't emit
8195 a parseable summary line.
8197 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8198 Allow summaryFunction to return None to indicate no summary should
8201 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8202 writing to stale HTTP requests: notice when they disconnect and
8203 remove the request from the list. Also add CacheToFile from
8204 moshez, will be used later.
8206 2003-04-08 Brian Warner <warner@lothar.com>
8208 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8209 should be an int, not a list of strings
8211 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8212 if we weren't actually connected
8214 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8215 to show the tail end of the trial text output
8217 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8218 hook to summarize the results of a ShellCommand
8220 2003-04-07 Brian Warner <warner@lothar.com>
8222 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8223 twisted test suite code into a single class.
8224 * buildbot/process/process_twisted.py: same
8226 2003-04-04 Brian Warner <warner@lothar.com>
8228 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8230 * README (SLAVE): document use of mktap to create slave .tap file
8231 (REQUIREMENTS): describe dependencies
8233 * buildbot/bb_tap.py, buildbot/plugins.tml:
8234 * buildbot/bot.py (updateApplication): Add mktap support for creating
8235 buildslave .tap files
8237 2003-03-28 Brian Warner <warner@lothar.com>
8239 * buildbot/process/step.py (InternalShellCommand.finished): handle
8240 new tuple result values (fix embarrasing bug that appeared during
8243 2003-03-27 Brian Warner <warner@lothar.com>
8245 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8248 2003-03-25 Brian Warner <warner@lothar.com>
8250 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8251 to overall build status
8252 * buildbot/clients/base.py (Builder): improve event printing
8253 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8254 instead of generic ShellCommand
8255 (Build): Add .stopBuild, use it when slave is detached
8257 * buildbot/process/step.py (Configure,Test): give the steps their
8258 own names and status strings
8260 * buildbot/status/html.py (StatusResource): add "show" argument,
8261 lets you limit the set of Builders being displayed.
8263 2003-03-20 Brian Warner <warner@lothar.com>
8265 * buildbot/process/basic.py: removed
8267 2003-03-19 Brian Warner <warner@lothar.com>
8269 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8270 turn off process-docs by default
8272 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8273 when displaying build information without anything in allBuilds[]
8275 * buildbot/bot.py (makeApp): really take password from sys.argv
8277 2003-03-18 Brian Warner <warner@lothar.com>
8279 * buildbot/bot.py (buildApp): take password from sys.argv
8281 * README: replace with more useful text
8283 * setup.py: add a real one
8284 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8286 * docs/PyCon-2003/: added sources for PyCon paper.
8288 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8289 now Build objects control the process and Builder only handles
8290 slave stuff and distribution of changes/status. A new BuildFactory
8291 class creates Build objects on demand.
8293 Created ConfigurableBuild which takes a list of steps to run. This
8294 makes it a lot easier to set up a new kind of build and moves us
8295 closer to being able to configure a build from a web page.
8297 * buildbot/process/step_twisted.py, process_twisted.py: move to
8298 new model. A lot of code went away.
8300 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8301 send lots of empty progress messages to the client.
8303 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8305 2003-02-20 Brian Warner <warner@lothar.com>
8307 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8309 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8310 Twisted bug that prevented non-pty processes from working just got
8311 fixed, and the bug that leaks ptys is still being investigated.
8313 * buildbot/process/step.py (CVS): send timeout arg to slave
8315 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8316 builders coming and going
8317 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8318 from CVSToys, handle lost-buildmaster
8320 * buildbot/status/client.py (StatusClientService.removeBuilder):
8321 Clean up status client protocol: send builders (with references)
8322 as they are created, rather than sending a list and requiring the
8323 client to figure out which ones are new.
8324 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8325 attempts to force a build on an unknown builder
8327 2003-02-19 Brian Warner <warner@lothar.com>
8329 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8330 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8331 Twisted stops leaking them.
8332 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8333 builder goes to an idle state.
8335 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8336 I figure out why CVS commands hang without them, and/or I fix the
8337 hung-command timeout
8339 2003-02-16 Brian Warner <warner@lothar.com>
8341 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8342 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8343 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8344 GenerateDocs now that they are prefixed with WARNING:.
8346 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8347 use manual href target instead of request.childLink
8349 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8350 display every second, but update the ETA every 5 seconds (or
8351 whenever) as remote_progress messages arrive.
8354 2003-02-12 Brian Warner <warner@lothar.com>
8356 * *: import current sources from home CVS repository
8360 # add-log-time-format: add-log-iso8601-time-string