1 2008-03-20 Brian Warner <warner@lothar.com>
3 * buildbot/scheduler.py (Triggerable): cleanup: wrap docstring
4 * buildbot/steps/trigger.py (Trigger): cleanup: rename schedulers=
5 to schedulerNames=, make updateSourceStamp=True by default, tolerate
6 missing got_revision property (i.e. if updateSourceStamp=True but
7 there was no checkout/update step run), add TODO notes for further
9 * buildbot/test/test_run.py (Triggers): update to match
10 * docs/buildbot.texinfo (Build Dependencies): same
12 * buildbot/slave/commands.py (SVN.doVCFull): merge Dustin's patch:
13 add --no-auth-cache option to svn invocations to avoid caching
14 buildbot's credentials. This also helps when users run a
15 buildslave from their personal account, to keep the buildslave
16 from clobbering their manually-provided svn password. Closes #188.
17 (SVN.doVCUpdate): do it for 'svn update' too.
19 * buildbot/steps/shell.py: merge Greg Ward's patch (via Dustin):
20 refactor WithProperties handling, allow WithProperties in more
22 * buildbot/process/buildstep.py: same
23 * buildbot/steps/transfer.py: same, allow WithProperties in filenames
25 * buildbot/steps/trigger.py: remove unused imports to hush pyflakes
27 * docs/buildbot.texinfo (Build Properties): fix up nodes+menus
29 2008-03-19 Brian Warner <warner@lothar.com>
31 * buildbot/status/web/xmlrpc.py (XMLRPCServer.xmlrpc_getAllBuilders):
32 merge Etienne Pierre's patch (via Dustin): add new XMLRPC methods.
33 (XMLRPCServer.xmlrpc_getStatus): same
34 (XMLRPCServer.xmlrpc_getLastBuilds): same, returns the last N
35 completed builds for a given Builder
37 * buildbot/test/test_config.py (ConfigTest.setUp): merge Dustin's
38 patch: suppress DeprecationWarnings in our tests of deprecated
39 features that aren't scheduled for removal quite yet. In the long
40 run, we'll remove the old features and the tests.
42 * NEWS: add a deprecation schedule
43 * buildbot/changes/freshcvsmail.py: remove this file, it was
44 replaced by mail.FCMaildirSource in the previous release.
46 * buildbot/test/runutils.py: set usePTY=False everywhere we aren't
47 explicitly testing =True, to avoid SIGHUP-based failures that I
48 now see about 10% of the time.
50 * buildbot/scheduler.py (Triggerable): merge Dustin's patch: add
51 "Triggerable" Schedulers, to start builds at specific phases of
52 other builds rather than in response to source code changes or
53 periodic timers. These phases are marked by "Trigger" steps, which
54 are configured with a list of Triggerable schedulers that they
55 should fire. Closes #56.
56 * buildbot/steps/trigger.py (Trigger): buildstep to match
57 * buildbot/test/test_run.py (Triggers): test for it
58 * docs/buildbot.texinfo (Build Dependencies): document it
59 (Triggering Schedulers): same
61 2008-03-18 Brian Warner <warner@lothar.com>
63 * buildbot/interfaces.py (ISourceStamp.getAbsoluteSourceStamp):
64 merge patch from Dustin to add "absolute source stamps": just like
65 normal SourceStamp instances except that they have a .revision
66 attribute copied out of the got_revision property of a build. If
67 the input SourceStamp says .revision=None (i.e. HEAD), and the
68 build is done when the tree is at r1234, then the "absolute"
69 SourceStamp should have .revision=1234 .
70 * buildbot/sourcestamp.py (SourceStamp.getAbsoluteSourceStamp): same
71 * buildbot/status/builder.py (BuildStatus.getSourceStamp): add
74 * buildbot/test/runutils.py (SetTestFlagStep): test utility class,
75 adding 'flags' that can be set by specific buildsteps. This makes
76 it easier to write tests that detect whether certain buildsteps
77 have been reached or not. Patch by Dustin Mitchell.
78 * buildbot/test/test_run.py (TestFlag.testTestFlag): test for it.
80 * buildbot/buildslave.py (BuildSlave.__repr__): protect against
81 .botmaster being empty, to allow pretty-printing of configuration
82 files before the twisted reactor starts. Patch from Dustin
85 * docs/buildbot.texinfo (Shutdown): make it clear that 'buildbot
86 reconfig' (which uses SIGHUP) doesn't work on windows. Acknowledge
87 the occasional failures in reconfig (and suggest 'buildbot
88 restart' as a fallback). Closes #105.
90 * buildbot/steps/shell.py (ShellCommand._interpolateProperties):
91 apply patch from Albert Hofkamp to allow WithProperties in
92 environment variables and the workdir= argument. Closes #52.
93 * buildbot/test/test_properties.py (Interpolate.testCustomBuildStep):
94 remove this test, it was pretty weird and didn't work with the
95 new _interpolateProperties approach.
97 * buildbot/test/test_vc.py (VCBase.connectSlave): turn off usePTY
98 for all slave commands: I'm seeing 'cp' and 'rm' fail with SIGHUP,
99 probably when we close stdin. This happens on my debian/sid
100 system, but not on older unixes, so I suspect some change in
101 behavior in the kernel or glibc or something similar.
103 2008-02-05 Brian Warner <warner@lothar.com>
105 * buildbot/buildslave.py (BuildSlave._missing_timer_fired): add a
106 To: header to the email message we're composing. Oops. Thanks
107 to Zandr Milewski for the catch.
108 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
111 2007-12-31 Brian Warner <warner@lothar.com>
113 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): remove
114 the short timeouts, these can cause false test failures on slow
115 systems, and were only needed while developing the recent patch
116 (Download.testLotsOfBlocks): same
118 * buildbot/scripts/reconfig.py (Reconfigurator.run): if we're on
119 windows, make 'buildbot reconfig' emit a warning message (since
120 there's no SIGHUP to be had) rather than just hanging. Addresses
121 #105, but we still need to document this somewhere. Thanks to
122 Ben Hearsum for the patch.
124 * buildbot/slave/commands.py (SlaveFileUploadCommand.start):
125 rewrite the main loop to avoid tail recursion, since Deferreds
126 don't optimize those out. Without this, at the end of the transfer
127 we'd hit a stack depth of about two or three frames per block
128 transferred, and for large transfers this would run into a "stack
129 depth exceeded" error. Closes #106.
130 (SlaveFileDownloadCommand.start): same, for downloads.
131 * buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): test it
132 (Download.testLotsOfBlocks): same
134 2007-12-22 Brian Warner <warner@lothar.com>
136 * buildbot/steps/shell.py (TreeSize): This never worked properly.
137 Fix it. Also, stash the tree size in a build property named
138 'tree-size-kb'. Note that this records size in KiB (1024 bytes),
139 not KB (1000 bytes), because that's what du will give us. This
141 * docs/buildbot.texinfo (TreeSize): document it
142 * buildbot/test/test_steps.py (TreeSize.testTreeSize): test it
144 * buildbot/steps/shell.py (WarningCountingShellCommand): utility
145 subclass which uses a regular expression to count warning messages
146 in the output. This also puts warning messages in a new 'warnings'
147 logfile, sets the 'warnings-count' build property with the total
148 count, and marks the step results as WARNINGS if there are any
149 warnings. Thanks to Roch Gadsdon (rochg) for the patch. Closes
151 (Compile): derive from WarningCountingShellCommand
153 * docs/buildbot.texinfo (Compile): document it
154 * buildbot/test/test_steps.py (Warnings): test it
156 * buildbot/slave/commands.py (ShellCommand._chunkForSend): don't
157 send more than 128kB of stdout/stderr/logfile text in a single PB
158 string, since PB has a hardwired limit of 640kB. This should fix
159 crashes that occur when the test process generates output very
160 very quickly. Patch by chops@demiurgestudios.com, thanks! I
161 haven't been able to reproduce this locally, but the potential bug
162 is clear. This should close #129.
164 2007-12-21 Brian Warner <warner@lothar.com>
166 * buildbot/scripts/startup.py (start): check to see if there's a
167 buildbot.tac before doing anything else. This improves the error
168 message when you do 'buildbot start' in the wrong directory.
170 * buildbot/scripts/logwatcher.py (LogWatcher.start): rewrite to
171 spawn /usr/bin/tail to follow the target's twistd.log . It turns
172 out that OS-X file EOF semantics are different, and the naive
173 read-then-read-again approach I was using doesn't work (the first
174 EOF we hit is sticky). tail gets it right, so rely upon it instead
175 of reimplementing the wheel. This should make 'buildbot start'
176 correctly follow the logfile on OS-X, thus closing #141.
178 2007-12-14 Brian Warner <warner@lothar.com>
180 * buildbot/steps/shell.py (ShellCommand.__init__): stash the
181 RemoteShellCommands args too, so things like 'workdir' and 'env'
182 and 'timeout' are preserved. This ought to fix #150.
183 * buildbot/test/test_steps.py (Steps.testClone): test it
185 2007-12-11 Brian Warner <warner@lothar.com>
187 * buildbot/scripts/startup.py (launch): use twisted.__version__,
188 rather than twisted.version, since the latter didn't appear until
189 Twisted-2.4.0 . This unbreaks 'buildbot start' on older Twisteds.
191 2007-12-08 Brian Warner <warner@lothar.com>
193 * docs/buildbot.texinfo (Git): document the fact that we require
194 Git 1.2.0 or later, and that the one shipped in dapper is too old.
196 * buildbot/scripts/startup.py (launch): twisted-2.5.0 and later
197 doesn't need twisted.scripts._twistw.run; instead, it uses
198 twisted.scripts.twistd.run on all platforms. Closes #53.
200 2007-11-30 Brian Warner <warner@lothar.com>
202 * buildbot/status/builder.py (BuilderStatus): small docs patches
203 from Greg Ward.. thanks!
204 * buildbot/process/base.py (Build): same
206 2007-11-29 Brian Warner <warner@lothar.com>
208 * buildbot/slave/commands.py (Mercurial._maybeFallback): add an
209 _abandonOnFailure call to the fallback, to skip the 'update' step
210 if the checkout fails.
211 (Mercurial._maybeFallback): More fixes: look for error messages
212 generated by every version of hg from 0.7 to the current 0.9.5,
213 including development versions as of rev 92991422a847. Also make
214 sure to return the exit code of non-fallbackable errors so that
215 other steps can attempt a workaround.
217 2007-11-28 Brian Warner <warner@lothar.com>
219 * buildbot/slave/commands.py (Mercurial._maybeFallback): improve
220 hg fallback so that it works when the client hg is new and the
221 server hg is old (the error message is different in this case).
223 2007-11-27 Brian Warner <warner@lothar.com>
225 * buildbot/test/test_p4poller.py: hush pyflakes warning
227 * buildbot/slave/commands.py (Mercurial._maybeFallback): when hg
228 is doing a 'clone' operation, to a remote repository (e.g. over
229 HTTP), and either the server or the client is hg-0.9.1 or older,
230 'hg clone' cannot accept a --rev argument: instead, you have to
231 clone the tip and then update back to the desired revision. Added
232 code to detect this failure mode and fall back to the clone+update
233 scheme. Closes #122 and #103.
234 (ShellCommand.__init__): add a keepStderr= flag to support this
236 * buildbot/test/test_vc.py (VCBase._do_vctest_clobber_2): add a
237 test that does a checkout to a specific version, to exercise the
238 mercurial limitation workaround.
239 (Mercurial.serveHTTP): add code to test hg checkout over HTTP,
240 using mercurial's built-in 'hg serve' command. Because of
241 limitations in hg, this code uses a randomly-selected TCP
242 port (rather than claiming a free one), so every once in a while
243 this test is going to fail because of a port-number collision.
245 * buildbot/test/test_vc.py (GitHelper.capable): skip Git tests if
246 the version of Git installed is older than 1.2.x . Git 1.1.3
247 doesn't accept 'git init' (it wants 'git init-db' instead) and the
248 branch tests fail. I know that Git 1.5.3.6 works. I don't know
249 what the dividing line is.. if someone can figure it out, please
250 update this check. Also, if someone can make buildbot's git
251 support handle older versions, please do that too! Addresses #130.
253 2007-11-21 Brian Warner <warner@lothar.com>
255 * lots: improve Git support, AMAZING patch from Haavard
256 Skinnemoen, complete with unit tests and docs, thanks! Closes #130.
257 * buildbot/scripts/tryclient.py (GitExtractor): add 'try' support
258 * buildbot/slave/commands.py (Git): accept branch and revisions,
259 and use 'git' instead of the 'cogito' wrapper
260 * buildbot/steps/source.py (Git.__init__): same
261 * buildbot/test/test_vc.py (BaseHelper.runCommand): offer control
263 (BaseHelper.do): same
264 (BaseHelper.dovc): same
265 (Git): unit tests for Git support. Wow!
266 * docs/buildbot.texinfo (Git): docs for Git support. Double Wow!
267 * contrib/git_buildbot.py: commit-hook script for git
270 * buildbot/changes/p4poller.py (P4Source._finished): don't let a
271 failure cause us to stop polling. Thanks to John Backstrand for
272 the patch. Closes #135.
273 * buildbot/test/test_p4poller.py (TestP4Poller.testFailedChanges):
275 (TestP4Poller.testFailedDescribe): same
277 * buildbot/status/web/waterfall.py (WaterfallStatusResource.body):
278 fix timezone calculation, we were always emitting DST, even in
279 winter. Thanks to Charles Lepple and John Saxton for the patch.
281 * buildbot/test/test_web.py (Waterfall.test_waterfall._check1): same
284 * lots: a whole batch of patches from Benoit Sigoure, referenced
285 in ticket #138. Thanks!
287 * buildbot/master.py (BuildMaster.loadConfig): builder names that
288 begin with an underscore are now reserved, so prohibit them from
289 appearing in the config file.
290 * NEWS: announce this change.
292 * buildbot/status/web/base.py: add buttons (to one_line_per_build
293 and one_box_per_builder) to force/stop builds on all Builders at
295 * buildbot/status/web/baseweb.py: same
296 (OneBoxPerBuilder.body): add links to the per-Builder page
298 * buildbot/status/web/builder.py: same
300 * buildbot/status/web/builder.py (StatusResourceBuilder.body):
301 factor out force/stop form generation
302 * buildbot/status/web/base.py: same
303 * buildbot/status/web/build.py: same
305 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
306 simplify some 'if' statements
307 (StatusResourceBuilder.build_line): add a 'Stop Build' button next
308 to the 'Force Build' button, so you can start and stop a build
310 (StatusResourceBuilder.force): redirect back to the waterfall,
311 rather than the index page
312 (StatusResourceBuilder.ping): same
313 * buildbot/status/web/build.py (StatusResourceBuild.stop): same
315 * buildbot/slave/bot.py (Bot.remote_setBuilderList): don't
316 consider the 'info' directory as a leftover directory. Patch from
317 Benoit Sigoure, ticket #138.
318 (others): remove trailing whitespace
320 2007-11-01 Brian Warner <warner@lothar.com>
322 * buildbot/status/web/builder.py (StatusResourceBuilder.build_line):
323 if there's no current step, don't try to display its description.
324 Same crash as in #96, this time in the web page. Closes #111.
326 * buildbot/status/web/base.py (OneLineMixin.make_line): tolerate
327 results == None (i.e. when the build hasn't finished yet);
328 previously this code exploded when trying to find a CSS class for
329 that results value. Patch from Greg Ward. Closes #118.
331 * buildbot/status/client.py (RemoteBuildStep.remote_getLogs):
332 IBuildStepStatus.getLogs() returns a list, not a dict. Patch from
333 Fabrice Crestois. Closes #121.
335 2007-10-31 Brian Warner <warner@lothar.com>
337 * buildbot/status/words.py (Contact.emit_status): if there's no
338 current step, don't try to display its description. This should
339 fix the crash when asking the irc bot about builds which are
340 waiting for a build-wide Lock. Closes #96.
342 * buildbot/status/tinderbox.py (TinderboxMailNotifier): add
343 'columnName' argument, from a patch by Ben Hearsum. Closes #120.
345 2007-10-16 Brian Warner <warner@lothar.com>
347 * buildbot/status/web/slaves.py (BuildSlavesResource.body): fix
348 timestamp, I was using %M (minutes) where I meant to be using
349 %b (abbreviated month name). Closes #109.
351 2007-10-13 Brian Warner <warner@lothar.com>
353 * README (COPYING): make it clear that buildbot is distributed under
355 * COPYING: add a copy of the GPLv2 to the source tree
356 * MANIFEST.in: .. and to the source distribution too
358 2007-10-10 Brian Warner <warner@lothar.com>
360 * buildbot/status/builder.py (Status.getURLForThing): update this
361 to match new URL layout, I completely forgot about it. Closes #112.
362 * buildbot/test/test_web.py (GetURL): add unit tests
364 * buildbot/status/web/build.py (BuildsResource.getChild): fix
365 silly typo which prevented the Build page from ever offering
366 control options like 'Stop Build'. Thanks to Aaron Hsieh for the
368 * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd
371 * buildbot/__init__.py (version): bump to 0.7.6+ while between
373 * docs/buildbot.texinfo: same
375 2007-09-30 Brian Warner <warner@lothar.com>
377 * buildbot/__init__.py (version): Releasing buildbot-0.7.6
378 * docs/buildbot.texinfo: same
380 2007-09-30 Brian Warner <warner@lothar.com>
382 * NEWS: small updates, remove duplicate items from the 0.7.5 notes
383 * setup.py: install all test files from buildbot/test/mail/* . Also
384 update URL to point at buildbot.net
385 * MANIFEST.in: update with new files
387 * buildbot/status/web/baseweb.py (WebStatus.setupSite): ugh, yes
388 auto-create an empty public_html directory, otherwise we get
389 internal server errors instead of 404s.
391 * README: reference buildbot.net, remove CVSToys section (does
392 anyone still use it?)
394 * buildbot/status/web/baseweb.py (WebStatus): emit a useful log
395 message when public_html/ is missing (indicating that you should
396 probably run 'upgrade-master'), and don't auto-create an empty
397 directory in that case.
399 * contrib/darcs_buildbot.py: refactor internals a bit, make it
400 possible to use as an importable module (to make it easier to
401 write some unit tests for it)
403 * buildbot/status/web/baseweb.py (Waterfall.__init__): add a
404 DeprecationWarning for Waterfall, advising users to switch over to
407 * NEWS: update with user-visible changes since the last release
409 * buildbot/status/web/waterfall.py
410 (WaterfallStatusResource.get_reload_time): if the suggest a
411 reload time of less than 15 seconds, give them 15 seconds instead
412 of ignoring their request entirely, because that'd be confusing.
414 * buildbot/steps/source.py (Mercurial.computeSourceRevision): log a
415 warning if we must invoke the last-change-is-most-recent guess
417 * buildbot/status/web/baseweb.py (Waterfall.__init__): if an old
418 Waterfall is running in an upgraded master (which is the usual
419 case for folks who have followed the instructions to run
420 'upgrade-master' but who have not yet resolved all the
421 DeprecationWarnings), prefer the buildbot.css from public_html/
422 rather than the one passed in on the buildbot= argument.
423 Otherwise, the resulting pages don't quite use CSS right..
424 sometimes it works, sometimes it doesn't, and I don't know why.
425 Sites that are using custom CSS will see the default CSS until
426 they modify public_html/buildbot.css to include their
429 * docs/buildbot.texinfo (WebStatus): explain robots.txt a bit more
430 * buildbot/status/web/robots.txt (Disallow): update to cover all
431 dynamically-generated pages
433 * buildbot/status/web/base.py (map_branches): when we see 'trunk',
434 include both 'trunk' and None in the output list, since some VC
435 systems (SVN, frequently) refer to trunk as 'trunk'.
437 * buildbot/status/web/waterfall.py (WaterfallStatusResource):
438 point the 'welcome' link explicitly at index.html, rather than
439 '.', so that old Waterfall users can reach it and discover all the
442 * buildbot/status/web/base.py (OneLineMixin.make_line): add the
443 build's text to the end of the line, without a CSS class so it
446 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): add a
447 'max_search=' argument, to limit the number of builds that are
448 examined while trying to find ones that match the other criteria.
449 This helps to limit the work we do, since otherwise we might have
450 to trawl through all history.
451 (IBuilderStatus.generateFinishedBuilds): same
452 * buildbot/status/builder.py (Status.generateFinishedBuilds): same
453 (BuilderStatus.generateFinishedBuilds): same
455 * buildbot/status/web/base.py (OneLineMixin.make_line): stringify
456 our got_revision before checking its length: SVN (at least) still
457 reports numeric values for this.
458 * buildbot/status/web/build.py (StatusResourceBuild.body): same
459 * buildbot/status/web/xmlrpc.py
460 (XMLRPCServer.xmlrpc_getAllBuildsInInterval): same, also stop
461 serving a completely fake revision
463 * buildbot/scripts/runner.py (Maker.check_master_cfg): prepend
464 basedir to sys.path, to mimic what a real buildmaster would have
465 access to, since it is common for master.cfg to import helper
466 classes from .py files in the buildmaster directory, and we want
467 config-file checking to accomodate this.
469 * buildbot/status/web/base.py (map_branches): when referring to
470 branches through WebStatus (i.e. by appending ?branch=FOO query
471 arguments to the URL), make "trunk" mean trunk, by mapping it to
472 None before passing it to generateFinishedBuilds() and the like.
473 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): same
474 (OneBoxPerBuilder.body): same, also improve display of branches in
476 * buildbot/status/web/waterfall.py (BuildTopBox.getBox): same
477 (WaterfallStatusResource.buildGrid): same. Note that this filters
478 Changes as well as Builds.
479 * docs/buildbot.texinfo (Buildbot Web Resources): remove the
480 caveat about trunk branches, now that it's fixed
482 * buildbot/status/web/base.py (OneLineMixin): refactor, move this
483 from builder.py, use it on the Builder page too
485 * buildbot/status/web/builder.py (StatusResourceBuilder): same
486 * buildbot/status/web/baseweb.py (OneLinePerBuild): display branch
487 names, add some CSS classes
488 * buildbot/status/web/classic.css (td.box): new class, for
491 * docs/buildbot.texinfo (WebStatus): update docs
493 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): remove
494 the trailing "M" indicator that tells us this is a modified file.
495 This should help with mode="update" builds that modify files
496 in-place. Thanks to "Oz" (chris at santacruzgames.com) for the
499 * buildbot/scripts/runner.py (upgradeMaster): improvements: write
500 new copies of files (to .new) when those files already exist,
501 check the master.cfg file for errors (and give DeprecationWarnings
502 a chance to be displayed).
503 * buildbot/test/test_runner.py: add more tests
504 * docs/buildbot.texinfo (Upgrading an Existing Buildmaster): docs
506 2007-09-29 Brian Warner <warner@lothar.com>
508 * buildbot/steps/source.py (Mercurial.computeSourceRevision): take
509 the revision id from the last change in our list, since that's the
510 best we can do without knowing the full ancestry graph. Closes #103.
512 * buildbot/scripts/sample.cfg: use buildstep instances in
513 f.addStep, to demonstrate the (correct) modern usage.
514 * docs/examples/hello.cfg: bring this up to date. Closes #79.
515 * docs/examples/twisted_master.cfg: add a big warning about how
517 * docs/examples/glib_master.cfg: delete this one entirely, it is
518 ancient and not a very useful example anyways
520 * buildbot/status/web/base.py (HtmlResource.render): keep track of
521 HTTPChannels, so we can shut them down at reconfig time (when the
522 WebStatus goes away). Closes #102.
523 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
524 (WebStatus.registerChannel): same
525 (WebStatus.stopService): do .loseConnection() here
527 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
528 WebStatus, make sure all pages are still retrievable. I thought
529 this would exercise a bug, but it turns out that it was firefox
530 caching connections (and continuing to talk to the old WebStatus
531 even though I'd loaded a new one).
532 * buildbot/status/web/baseweb.py (WebStatus): add some comments
533 (WebStatus.__repr__): include id() in the repr
535 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
536 this to specify an errorparser. From Ted Mielczarek and the
537 mozilla crew. Closes #94.
539 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
540 bonsaipoller ignore funkyness in xml output for empy log
541 messages", from Axel Hecht. Closes #90.
542 * buildbot/test/test_bonsaipoller.py
543 (TestBonsaiPoller.testMergeEmptyLogMsg): same
545 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
546 respect 'builders' arg, from Ben Hearsum. Closes #89.
548 * buildbot/scripts/runner.py (stop): increase the timeout from 5
549 seconds to 10, to give heavily loaded machines a better chance to
550 finish shutting down. Addresses (partially) #68.
551 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
553 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
554 * buildbot/scripts/startup.py (Follower._failure): update message
556 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
557 team, to fix some bugs and avoid the use of blocking urlopen().
559 * buildbot/test/test_bonsaipoller.py: same
561 2007-09-28 Brian Warner <warner@lothar.com>
563 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
564 argument, to send email about buildslaves which are disconnected
565 for more than an hour. Closes #64.
566 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
568 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
569 (MailNotifier): add docs for this too
572 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
573 respect branch= queryargs, by restricting the builds displayed to
574 those matching the given branch names
575 * buildbot/status/web/waterfall.py (BuildTopBox): same
577 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
578 fix a test failure by adding .prepath to this fake object
580 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
581 up generation of relative URLs. With luck, this should play with
582 reverse proxies much better now.
583 * buildbot/test/test_webparts.py: new test for most of the subpages
584 * buildbot/test/test_web.py (base_config): add enough of a config
585 to exercise more Waterfall code
587 2007-09-27 Brian Warner <warner@lothar.com>
589 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
590 relative URL to the buildbot welcome page, rather than
592 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
594 * buildbot/status/web/base.py (HtmlResource.title): change the
595 default title of all Buildbot-generated page to "Buildbot"
596 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
597 change the title to include the Builder name
598 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
599 same, and also show the build number
600 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
601 redirect the browser to the Builder page
603 2007-09-26 Brian Warner <warner@lothar.com>
605 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
606 problem with the build links
608 2007-09-25 Brian Warner <warner@lothar.com>
610 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
611 to emit relative URLs instead of using URLPath,
613 * docs/buildbot.texinfo (WebStatus): provide an example
615 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
616 page, shows a simple table with one row per Builder. Still pretty
617 ugly, but functional.
618 * buildbot/status/web/index.html: reference it
620 * buildbot/status/web/waterfall.py (Spacer): make this *not*
621 inherit from builder.Event, so that show_events=false doesn't hide
622 spacers, since that would make the waterfall weirdly compressed.
624 * buildbot/status/web/waterfall.py (HELP): put the View button in
625 its own section, so it doesn't get visually confused with the
627 (WaterfallStatusResource.body): make the '[help]' links more
628 visually distinct from each other, and add a link to the Welcome
630 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
631 unused buildslaves without exploding
633 * buildbot/status/web/waterfall.py
634 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
635 it gives us absolute paths that break proxies
636 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
637 this, it was giving bad results when the Waterfall is behind a
640 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
641 new 'upgrade-master' command, which will bring an old buildmaster
642 directory up-to-date. Right now the only thing it does is populate
643 public_html/ if it wasn't already there. Still to do: check the
644 other files, add documentation.
645 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
646 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
648 2007-08-13 Brian Warner <warner@lothar.com>
650 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
651 that contains the checkin comments when you hover over the entry
652 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
655 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
658 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
659 page with versions of python, buildbot, and twisted
660 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
661 * buildbot/status/web/index.html: add links to most pages
662 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
664 * buildbot/status/web/robots.txt: put a robots.txt in new installs
665 which discourages robot access to all large dynamically-generated
666 pages. The intention is that the index page and the 'about' page
667 are the only ones which should be crawlable.
668 * buildbot/scripts/runner.py (Maker.public_html): same
670 * setup.py: ship index.html and robots.txt in source distributions
672 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
673 activate automatic reloading of the page (using a meta Refresh:
675 (WaterfallHelp): new page to explain all the nifty query arguments
676 you can use on the Waterfall, along with forms to set them for
677 you. From this page, you can add filters for builder=, branch=,
678 show_events=, as well as turning on reload=.
679 (WaterfallStatusResource.buildGrid): new query args: last_time=,
680 first_time=, show_time=, num_events= . The old show= is still
681 accepted, but the new builder= is preferred. We ignore empty
682 branch= arguments, to make the WaterfallHelp form easier to
684 (WaterfallStatusResource.head): new method to add text to the
686 * buildbot/status/web/base.py (HtmlResource.content): use head()
687 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
688 empty branch= arguments
689 (OneLinePerBuildOneBuilder.body): same
691 2007-08-12 Brian Warner <warner@lothar.com>
693 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
694 new query args: 'last_time' is a timestamp of the top-most event
695 on the display, 'first_time' is a timestamp for the bottom-most
696 event. 'show_time' is the difference between them, and overrides
697 'first_time'. 'num_events' puts an upper limit on the number of
698 timestamps that will be displayed on the left hand edge.
699 (WaterfallStatusResource.body): add a 'next page' link to the
700 bottom, which shows the events that come just after those shown on
701 the current page. This is a first step towards #67, but we need
702 some more controls before we can close that one.
704 * buildbot/buildslave.py (BuildSlave): these are now MultiService
705 instances too, and live as children of the BotMaster. The main
706 advantage of this approach is that BuildSlaves can know when they
707 are being removed (so they can shut off the upcoming
708 when-do-we-email-an-admin-because-we-lost-our-slave timer).
709 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
710 identify which service children are BuildSlaves
711 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
712 Checker updates here, but delegate the rest to..
713 (BotMaster.loadConfig_Slaves): .. here, which looks at the
714 BotMaster's service children to identify the old slaves. I think
715 the previous approach of using master.slaves was broken in the
716 face of config updates that modified BuildSlave instances but did
717 not completely replace them.
718 * docs/buildbot.texinfo (Developer's Appendix): note the change to
719 the Service hierarchy
721 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
722 page (at URL /buildslaves/) to view status of all buildslaves at
723 once, including how long it's been since we last heard from them,
724 and which Builders use them.
726 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
729 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
732 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
733 use the BuildSlave to keep track of the last time we've heard from
734 the buildslave. This is updated upon receipt of any message from
735 any SlaveBuilder (which generally means when RemoteCommands are
736 giving us status updates, as BuildSteps run). In the future this
737 will include slave pings too.
738 * buildbot/process/base.py
739 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
740 * buildbot/process/buildstep.py:
741 (BuildStep.setBuildSlave): accept that reference
742 (BuildStep.runCommand): pass the reference on to the RemoteCommand
743 (RemoteCommand.remote_update): update the timestamp
744 (RemoteCommand.remote_complete): same
745 * buildbot/test/runutils.py (StepTester.makeStep): match the change
746 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
747 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
748 interface to retrieve this timestamp
749 * buildbot/status/builder.py (SlaveStatus): track a copy of the
753 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
755 (OneLinePerBuild.body): use a <ul> instead of <div>s
756 (OneLinePerBuildOneBuilder.body): same
758 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
759 by adding the file's new name to the list of changed files. This
760 ought to be sufficient for things like isFileImportant and trial
761 tests that only exercise tests for files that have been modified.
764 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
765 XMLRPC server to the WebStatus page. This only has two methods
766 right now (getAllBuildsInInterval and getBuild), but we'll be
767 adding more in the future. This server is extracted from the
770 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
771 generateFinishedBuilds, and improve the data displayed.
772 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
773 the per-Build page, add some information like ETA and got_revision
774 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
775 adding a list of recently completed builds
776 * buildbot/status/web/base.py (css_classes): factor this out
778 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
779 new method, to make status display classes easier to write,
780 especially the WebStatus 'one_line_per_build' page.
781 (IBuilderStatus.generateFinishedBuilds): same
782 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
783 (Status.generateFinishedBuilds): implement it
785 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
786 'source' to be a BuildStep instance, since BuildFactory accepts
788 (CPAN.__init__): same
789 (Distutils.__init__): same
790 (Trial.__init__): same
792 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
793 this might raise KeyError
795 2007-08-07 Brian Warner <warner@lothar.com>
797 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
798 'Owner:' field of the view, rather than 'p4logname', since
799 p4logname comes from the buildslave's environment and seems
800 unlikely to ever do the right thing. Thanks to Wade Brainerd for
801 the patch. Closes #40.
803 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
804 which imposes a per-slave limit on how many builds are allowed to
805 run simultaneously. This has a the same scope than the SlaveLock,
806 but is different because max_builds= gives the buildmaster the
807 freedom to assign the build to a different slave, whereas the
808 SlaveLock doesn't get tested until after the build is irrevocably
809 assigned to a slave. Therefore using max_builds= will improve
810 utilization in the presence of multiple buildslaves that are
811 attached to the same Builder. This completes the incorporation of
812 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
813 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
814 any Builder finishes, potentially trigger *all* Builders, since
815 max_builds= may have stalled someone else while waiting for the
817 * buildbot/scripts/sample.cfg: mention max_builds=
818 * buildbot/test/test_run.py (ConcurrencyLimit): test it
819 * docs/buildbot.texinfo (Buildslave Specifiers): document it
821 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
822 inherit from RunMixin do not need to call master.stopService()
823 themselves, since RunMixin.tearDown does that. The double call
824 fails on Twisted-2.0.x, which didn't happen to protect against it.
825 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
827 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
828 from #48, this one to have the BuildSlave objects track
829 SlaveBuilders, so they'll be able to use that knowledge to
830 influence their canStartBuild() response.
831 * buildbot/process/builder.py (SlaveBuilder.attached): call it
832 (SlaveBuilder.detached): same
833 * buildbot/test/test_slaves.py (BuildSlave): test it
835 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
836 the second of Dustin's #48 patches, this one adding a method to
837 the BuildSlave that allows it to decide whether it is willing to
838 participate in a build or not.
839 (SlaveBuilder.isAvailable): use canStartBuild() to decide
841 * buildbot/test/test_run.py (CanStartBuild): test for it
843 * all: incorporate the first of four patches by Dustin Mitchell
844 from ticket #48, working towards improving control over slave
845 concurrency. The first patch is to use a long-lived BuildSlave
846 object per slave, on which other behavior can be added later. I've
847 modified his patch considerably.
848 * buildbot/buildslave.py (BuildSlave): move class out of
849 slave/__init__.py (where it would get loaded by the slave as well
850 as the master, making dependencies trickier), and merge it with
851 BotPerspective. Now these BuildSlave instances are created once in
852 the master.cfg file, and not destroyed until they are either
853 removed from the config file or changed so
854 much (name/password/class changes) that we cannot continue to use
855 the old one. This affects config files: they must use
856 'from buildbot.buildslave import BuildSlave' instead of using
857 'from buildbot.slave import BuildSlave'.
858 * buildbot/master.py: move BotPerspective out
859 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
860 add or remove as necessary, update the rest using data from
862 * buildbot/slave/__init__.py: move BuildSlave out
863 * buildbot/test/test*.py: import BuildSlave from the new place
864 * buildbot/scripts/sample.cfg: update to match
865 * docs/buildbot.texinfo: update to match
866 * buildbot/process/builder.py: update comments to match
868 2007-08-02 Brian Warner <warner@lothar.com>
870 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
871 one-line-per-build pages a bit, add a header, refactor slightly
873 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
874 the TimeOutError timer, patch by Dustin Mitchell.
876 2007-08-01 Brian Warner <warner@lothar.com>
878 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
879 mostly work (branch= is still ignored, we need a useful header)
880 (OneLinePerBuildOneBuilder.body): this too
882 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
883 bring this up-to-date w.r.t. recent refactorings, and fix
884 redirections to bounce the browser to the top page after hitting
885 the 'force' button. This needs to be improved, but at least it now
886 redirects to a valid page.
887 (StatusResourceBuilder.ping): same
888 (StatusResourceBuilder.getChild): same, although I think this code
889 might be dead anyways
891 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
892 a branch= query argument, to filter the display down to builds and
893 changes that involve the given branch. You can add multiple
894 branch= arguments to see multiple branches (using a logical OR).
895 Note that there is no way to include the default branch (i.e.
896 None, i.e. trunk) yet, there is still work to be done to allow for
897 simple+uniform names of branches (i.e. removing the VC-specific
898 details of how branches are implemented, so calling the branch
899 'beta4' even though the SVN checkout step requires
901 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
902 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
903 * buildbot/interfaces.py (IEventSource.eventGenerator): same
904 * docs/buildbot.texinfo (Buildbot Web Resources): document it
906 * all: bring import statements up-to-date: don't import
907 __future__, assume cPickle and cStringIO are always available.
908 Also remove #!/usr/bin/python lines from non-scripts, my editor
909 has been a bit over-enthusiastic about stuffing them into new .py
912 * buildbot/status/web/index.html: put a link to the waterfall page
913 on the index, otherwise first-time users of WebStatus aren't going
914 to see anything very interesting.
916 * buildbot/interfaces.py (IEventSource): document this interface.
917 Thanks to Dustin Mitchell for the patch. Closes #60.
918 * buildbot/status/builder.py (BuilderStatus): same
919 * buildbot/changes/changes.py (ChangeMaster): same
921 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
922 add a query arg of 'show_events=true' to display non-build events,
923 like slaves attaching/detaching and reconfig events, or
924 'show_events=false' to hide them. The default is 'true'.
925 * docs/buildbot.texinfo (Buildbot Web Resources): document it
927 * web-parts: merge in web-parts branch. Lots of changes. The new
928 functionality is to add buildbot.status.html.WebStatus, which is a
929 superset of the Waterfall that adds new status pages and serves
930 regular files from BASEDIR/public_html/ , which is now the preferred
931 place to put robots.txt, buildbot.css, and index.html .
932 * buildbot/scripts/runner.py: the 'create-master' command now
933 creates public_html/ too, and populates it with a couple of
935 * buildbot/status/web: split waterfall code into smaller pieces
937 2007-07-31 Brian Warner <warner@lothar.com>
939 * buildbot/scripts/startup.py (launch): import twistd.run in a
940 different way to hush pyflakes
941 * buildbot/process/builder.py: remove unused import
943 2007-07-30 Brian Warner <warner@lothar.com>
945 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
946 Mitchell: pass SourceStamps around rather than branch/version/etc
947 tuples. Thanks Dustin! Closes #70.
948 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
949 tuple rather than a list, to avoid surprising mutations
950 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
951 * buildbot/status/mail.py (MailNotifier.buildMessage): same
952 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
953 * buildbot/test/test_status.py (Subscription): same
954 * buildbot/test/test_control.py (Force): same
955 * buildbot/test/test_buildreq.py (Request.testMerge): same
957 2007-07-29 Brian Warner <warner@lothar.com>
959 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
960 variable, since it wasn't used and is confusing in the presence of
961 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
964 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
965 the Buildbot home-page link to point at buildbot.net instead of
966 sourceforge, and add a current-version query parameter so we can
967 get some statistics on which versions are in use out there.
969 2007-07-28 Brian Warner <warner@lothar.com>
971 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
972 with c['change_source'], leaving c['sources'] for backwards
973 compatibility (but deprecated), scheduled for removal in 0.8.0
974 * docs/buildbot.texinfo: same
975 * buildbot/test/test_config.py: verify that c['sources'] still works
976 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
977 * buildbot/scripts/sample.cfg: update to match
979 * buildbot/changes/mail.py (MaildirSource): parse with python's
980 stdlib 'email' module, which has been available since python2.2,
981 and drop use of the 'rfc822' module, which has been depreceated
983 * buildbot/test/test_maildir.py: same: use parse_file() not parse
985 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
986 this needs to match the renaming in test/mail/msg*
988 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
991 * buildbot/test/test_mailparse.py: rename sample emails a bit
992 * buildbot/test/mail/msg*: same
994 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
995 parser for the "commit-email.pl" script that is shipped with SVN,
996 written by Justin Mason. Thanks! Closes SF#1072845.
997 * buildbot/test/mail/svn-commit.*: sample messages
998 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
999 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
1001 2007-07-27 Brian Warner <warner@lothar.com>
1003 * buildbot/changes/mail.py: refactor: move parsing into a method
1004 named 'parse', each parser type gets a separate subclass. Remove
1005 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
1006 to be a simple leading-substring match. Add a warning to the logs
1007 if prefix= does not end in a slash, since that's probably a
1008 mistake. Fix both places where a prefix= mismatch would skip all
1009 subsequent files in the same email, instead of just skipping the
1010 one that didn't match.
1011 * buildbot/test/test_mailparse.py: match changes
1013 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
1014 docs on email-based ChangeSources
1016 * docs/buildbot.texinfo (Getting Source Code Changes): move all
1017 the changesource types up a level, removing the one-entry menu in
1020 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
1021 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
1022 instances instead of tuples. Closes #63.
1023 * buildbot/slave/__init__.py (BuildSlave): define marker class
1024 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
1025 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
1026 * buildbot/test/test_*.py: update tests to match
1027 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
1028 the c['bots'] backwards-compatibility handler works
1030 2007-07-26 Brian Warner <warner@lothar.com>
1032 * buildbot/changes/hgbuildbot.py (hook): add an in-process
1033 Mercurial change-sending hook, contributed by Frederic Leroy.
1034 Thanks! Addresses #50.
1035 * docs/buildbot.texinfo (MercurialHook): document it
1037 * buildbot/changes/hgbuildbot.py: change the way imports are done,
1038 to make it compatible with at least hg-0.9.1 and the current 0.9.4
1040 2007-07-17 Brian Warner <warner@lothar.com>
1042 * buildbot/process/buildstep.py (BuildStep.getLog): add a
1043 convenience method to retrieve a log added with
1044 addLog()/addCompleteLog()/etc or logfiles= . I should have added
1045 this two years ago..
1047 2007-07-03 Brian Warner <warner@lothar.com>
1049 * buildbot/slave/commands.py (ShellCommand._startCommand): when
1050 logging the environment variables, put one variable on each line,
1051 rather than having one really long line with all of them. This
1052 should make them a bit more readable and not trigger the
1053 horizontal scrollbar (when viewing it in a web browser) quite so
1054 much. Thanks to Albert Hofkamp for the patch.
1056 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
1057 WithProperties instance. Thanks to Axel Hecht for the patch.
1059 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
1060 * docs/buildbot.texinfo (Build Properties): document it
1061 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
1062 workdir if it didn't already exist.
1064 * docs/buildbot.texinfo (Scheduler Types): correct the description
1065 of Dependent schedulers. Thanks to Greg Ward for the patch.
1067 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
1068 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
1069 the patch. Closes #49.
1071 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
1072 0700 before removing it, to deal with situations where a build will
1073 leave files around without write permissions and the 'copy' or
1074 'clobber' VC checkout modes need to blow away the tree first.
1075 Thanks to Steve Milner for the suggestion and the patch (which I
1076 mangled horribly). Closes #29.
1077 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
1080 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
1081 an allowReconnect= argument to let callers control whether they
1082 want this don't-let-it-reconnect behavior, since some tests care.
1083 Factor out the .continueTrying=False lines from those callers.
1084 * buildbot/test/test_slaves.py: same
1085 * buildbot/test/test_run.py: same
1087 2007-07-02 Brian Warner <warner@lothar.com>
1089 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
1090 slave has been disappeared, don't let it reconnect. This was
1091 causing an intermittent failure in test_slaves.py, when the slave
1092 that was supposed to be gone managed to come back by the end of
1093 the test and affect the count.
1094 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
1096 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
1097 diagnostic messages to track down this problem
1098 (Builder.startBuild): same
1100 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
1101 the slave randomly rather than always taking the first one. Thanks
1102 to Pike for the patch. Closes #36.
1103 * buildbot/test/test_slaves.py: match the change. to avoid huge
1104 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
1105 enables/disables the round-robin-ness (enabled by default), and
1106 some unit tests disable it.
1107 * docs/buildbot.texinfo (Buildmaster Architecture): document it
1109 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
1110 argument to 'buildmaster_host', to make it more obvious that this
1111 points to the buildmaster. Thanks to Bob Proulx for the
1113 * buildbot/scripts/runner.py (slaveTAC): same
1114 * buildbot/test/test_runner.py (Create.testSlave): match the change
1116 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
1119 2007-06-17 Brian Warner <warner@lothar.com>
1121 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
1122 we can round-trip all of our current step classes by calling
1123 getStepFactory() and using the results to make a clone of the
1126 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
1129 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
1130 the config file, we're moving to using actual instances instead of
1131 the (class, kwargs) 'step specification' tuples. BuildFactory
1132 still keeps a list of tuples internally, but when real instances
1133 are passed in to addStep(), they are asked for their class and
1134 kwargs using the new BuildStep.getStepFactory method. BuildFactory
1135 accepts both instances and the tuple form, and converts instances
1136 to the tuple form, but the instance form is preferred because it
1137 gives the Steps a chance to do argument validation. Closes: #11.
1139 * buildbot/process/buildstep.py (BuildStep.__init__): record the
1140 factory information necessary to implement getStepFactory. The
1141 addFactoryArguments() method can be used to include arguments that
1142 aren't passed to the BuildStep base class constructor.
1143 (BuildStep.setBuild):
1144 (BuildStep.setDefaultWorkdir): new methods to take parameters that
1145 are needed for live BuildSteps but not to construct the specification
1146 tuples that are stashed in the factory.
1148 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
1149 'workdir' into new BuildSteps by using methods instead of
1150 arguments. This makes the constructor for BuildSteps a lot
1153 * buildbot/steps/*.py: update to match this change. Basically this
1154 means adding calls to addFactoryArguments() in the __init__
1155 methods to capture the arguments that aren't passed through to the
1157 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
1158 the new workdir (if any) into the RemoteShellCommands arguments.
1159 * buildbot/steps/source.py: allow workdir= to be optional,
1160 implement setDefaultWorkdir() since we don't inherit from
1161 (CVS): finally remove old clobber=/export=/copydir= arguments,
1162 in favor of the mode= argument that's been around forever now.
1163 * buildbot/steps/transfer.py: remove build= argument
1165 * buildbot/test/*.py: update to match, generally by turning all
1166 build= arguments into subsequent calls to s.setBuild()
1167 * buildbot/test/test_config.py (Factories): verify that we can
1168 use either BuildStep instances or class/kwarg tuples in both
1169 BuildFactory.addStep and BuildFactory.__init__
1171 * docs/buildbot.texinfo (Build Steps): document the new approach,
1172 mention compatibility with the old approach, update all examples
1173 to use the new style.
1175 2007-06-16 Brian Warner <warner@lothar.com>
1177 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
1178 the LoopingCall, just eat the failure so that we'll poll again
1179 next time. This should allow us to tolerate (e.g.) sf.net SVN
1180 failures more gracefully. Many thanks to Dustin Mitchell for the
1183 2007-05-17 Brian Warner <warner@lothar.com>
1185 * buildbot/status/words.py: refactor the IRC status bot into
1186 separate 'Contact' and 'Channel' classes. The base Contact class
1187 contains the interaction code: commands and responses. The
1188 IRCContact subclass (and IrcStatusBot 'Channel') handle the
1189 IRC-specific aspects. The plan is to write other subclasses for
1190 other IM protocols like AIM and Jabber.
1192 2007-04-16 Brian Warner <warner@lothar.com>
1194 * CREDITS: update list of contributors. Thank you all!
1196 2007-04-13 Brian Warner <warner@lothar.com>
1198 * buildbot/status/mail.py (MailNotifier): add the project name to
1199 the subject line and message body, to make it easier to
1200 distinguish email coming from different buildmasters. Thanks to
1201 Benoit Sigoure for the patch.
1202 * buildbot/test/test_status.py (Mail): update to match
1204 2007-03-24 Brian Warner <warner@lothar.com>
1206 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
1207 avoid text-conversion problems between DOS/windows and unix.
1208 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
1210 2007-03-03 Brian Warner <warner@lothar.com>
1212 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
1213 warning about the use of Waterfall here
1215 2007-03-01 Brian Warner <warner@lothar.com>
1217 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
1219 2007-02-28 Brian Warner <warner@lothar.com>
1221 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
1222 Lamb to use a more optimal form of 'p4 changes', to reduce server
1223 load. He reports that this optimization was added to p4d release
1224 2005.2, but it should work in all versions. Closes #27.
1225 * buildbot/test/test_p4poller.py: match it
1227 2007-02-27 Brian Warner <warner@lothar.com>
1229 * buildbot/status/web/*.py: move all web status stuff into a
1230 separate directory, in anticipation of splitting it into smaller
1231 pieces and adding more files. html.py was getting way too big.
1232 * buildbot/status/classic.css: move it too
1233 * setup.py: add the new sub-package
1234 * buildbot/test/test_web.py: match the changes
1235 * MANIFEST.in: handle the move of classic.css
1237 2007-02-07 Brian Warner <warner@lothar.com>
1239 * contrib/OS-X/*: add some launchd .plist files for automatically
1240 starting a buildmaster or buildslave under OS-X (10.4 or later).
1241 Thanks to Mark Pauley for these.
1243 2007-02-06 Brian Warner <warner@lothar.com>
1245 * docs/buildbot.texinfo (Requirements): update requirements to
1246 stop claiming compatibility with python-2.2 or twisted-1.3.x .
1248 * README: mention python-2.5 and twisted-2.5 compatibility
1250 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
1252 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
1254 * buildbot/status/builder.py: same, by requiring cStringIO
1255 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
1256 * buildbot/test/test_vc.py: same
1257 * buildbot/test/test_web.py:
1258 * buildbot/test/test_steps.py: same, remove unused import
1260 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
1263 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
1264 see any Builders that don't have Schedulers to drive them
1266 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
1267 attributes this uses went away
1269 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
1270 dialog, to allow you to reset the buildmaster and force
1271 connect/disconnect. Correctly handle losing the buildmaster
1272 connection (by switching the display to the hexnut, at which point
1273 you can use the 'Connect' menu item to reconnect).
1275 * buildbot/steps/source.py (Source.start): if we're using a patch,
1276 add it as a LogFile to the checkout/update step. This will turn
1277 into a link on the waterfall page.
1279 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
1280 option, to take the patch from a pre-made file rather than
1281 generating it from the local tree. Thanks to Robert Helmer for the
1282 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
1283 * buildbot/scripts/runner.py (TryOptions): add --diff,
1284 --patchlevel, and --baserev options
1285 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
1286 as None, meaning HEAD.
1287 * buildbot/sourcestamp.py (SourceStamp): update docstring to
1288 indicate that baserev=None means HEAD
1289 * docs/buildbot.texinfo (try --diff): document it
1291 * buildbot/test/test_steps.py (BuildStep): remove use of
1292 reactor.iterate(), although the technique I replaced it with is a
1293 gross polling hack that must be cleaned up properly some day. This
1294 was the last use of reactor.iterate in the entire tree, yay.
1296 2007-02-05 Brian Warner <warner@lothar.com>
1298 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
1299 is one of the three known values, otherwise we emit some confusing
1300 messages later on. Thanks to Grig Gheorghiu for the catch.
1302 2007-01-30 Brian Warner <warner@lothar.com>
1304 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
1305 Hearsum contributed a patch to let BonsaiPoller work with results
1306 that contain non-ascii characters. Closes SF#1632641.
1308 2007-01-27 Brian Warner <warner@lothar.com>
1310 * Makefile (release): produce both .tar.gz and .zip source bundles.
1313 2007-01-23 Brian Warner <warner@lothar.com>
1315 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
1316 * buildbot/changes/monotone.py: same
1318 * buildbot/changes/maildir.py: combine several files into one,
1319 clean up maildir.py to use Services properly.
1320 * buildbot/changes/maildirtwisted.py: remove
1321 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
1323 * buildbot/changes/mail.py: match the change
1324 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
1325 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
1327 * buildbot/slave/commands.py (command_version): bump to "2.3" to
1328 indicate that the buildslave knows about the 'bzr' command
1330 2007-01-22 Brian Warner <warner@lothar.com>
1332 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
1333 'with', it will become a reserved work in python2.6 .
1335 * contrib/bb_applet.py: add a simple gnome-panel applet, to
1336 display a terse summary of buildbot status.
1337 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
1338 some icons, small versions of the Blender object that lives in
1339 docs/images/icon.blend
1341 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
1342 * buildbot/slave/commands.py (Bzr): same
1343 * buildbot/scripts/tryclient.py (BzrExtractor): same
1344 (SourceStampExtractor.dovc): modify this to allow non-zero exit
1345 status, since 'bzr diff' does that
1346 * buildbot/test/test_vc.py (Bzr): same
1347 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1351 2007-01-20 Brian Warner <warner@lothar.com>
1353 * contrib/darcs_buildbot.py: tidy up the progress messages
1355 2007-01-17 Brian Warner <warner@lothar.com>
1357 * contrib/darcs_buildbot.py: enhance to handle multiple patches
1358 being pushed at a time. This keeps state in the repository in a
1359 small file named .darcs_buildbot-lastchange, but that shouldn't
1360 interfere with normal repository operations. Fixes SF#1534049.
1361 * buildbot/clients/sendchange.py (Sender): make a single Sender
1362 capable of sending Changes with different usernames.
1364 2006-12-11 Brian Warner <warner@lothar.com>
1366 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
1367 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
1368 buildbot.changes.mail a long time ago, but I forgot to add the
1369 DeprecationWarning until now.
1371 * buildbot/process/maxq.py: remove this, the functionality now
1372 lives in buildbot.steps.maxq
1374 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
1375 * buildbot/clients/gtkPanes.py: remove unused import
1377 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
1378 that was meant to provide a special Reporter to run inside trial
1379 and give the buildslave lots of machine-readable status. We never
1380 finished this project.
1382 * buildbot/changes/bonsaipoller.py: remove unused imports
1383 * buildbot/changes/svnpoller.py: same
1384 * buildbot/process/builder.py: same
1385 * buildbot/process/buildstep.py: same
1386 * buildbot/slave/bot.py: hush pyflakes warning
1387 * buildbot/status/tests.py: remove unused imports
1388 * buildbot/status/tinderbox.py: same
1389 * buildbot/steps/python_twisted.py: same
1391 * buildbot/process/step.py: remove this file, these names were
1392 deprecated in 0.7.5 and are now being removed.
1393 * buildbot/process/step_twisted.py: same
1394 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
1396 * buildbot/twcompat.py: remove the empty file, yay it is gone
1398 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
1399 tw-2.0.0 and newer have the method we need.
1400 (getProcessOutputAndValue): same
1401 (which): remove this method, tw-2.0.0 t.p.procutils has it
1403 * buildbot/twcompat.py (implements): remove this method
1404 * buildbot/*: import implements() from zope.interface directly
1406 * buildbot/status/mail.py: stop falling back to importing
1407 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
1410 * buildbot/twcompat.py (Interface): remove this import
1411 * buildbot/*: import Interface from zope.interface directly
1413 * buildbot/twcompat.py (providedBy): remove this method
1414 * buildbot/*: turn all uses of providedBy(obj, iface) into
1415 iface.providedBy(obj)
1417 * buildbot/twcompat.py (maybeWait): remove this method, now that
1418 we no longer maintain compatibility with Twisted<=1.3.0 .
1419 Twisted-2.0.0 and later allow trial methods to return Deferreds
1421 * buildbot/test/*: remove all uses of maybeWait
1423 * buildbot/__init__.py (version): bump to 0.7.5+ while between
1425 * docs/buildbot.texinfo: same
1427 2006-12-10 Brian Warner <warner@lothar.com>
1429 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
1430 * docs/buildbot.texinfo: set version to match
1432 2006-12-10 Brian Warner <warner@lothar.com>
1434 * README (REQUIREMENTS): update for release
1435 * NEWS: update for release
1436 * buildbot/slave/commands.py (command_version): mention that this
1437 version (2.2) was released with buildbot-0.7.5
1439 * buildbot/test/test_config.py (StartService.testStartService):
1440 inhibit the usual read-config-on-startup behavior, since otherwise
1441 the log.err that gets recorded causes the test to fail
1443 * buildbot/status/builder.py (LogFile.finish): forget about all
1444 subscribers once the log has finished, since after that point
1445 we're never going to use them again. This might help free up some
1448 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
1449 than the old/deprecated gtk.mainquit()
1451 2006-12-09 Brian Warner <warner@lothar.com>
1453 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
1454 better when we can't open the masterdst file
1456 * buildbot/scripts/startup.py (Follower._failure): add missing
1457 import statement for BuildSlaveDetectedError
1459 * buildbot/steps/transfer.py (FileUpload): cleanup
1460 (FileDownload): same. Add tests for slave version, add mode=.
1461 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
1462 (SlaveFileDownloadCommand): same
1463 * buildbot/test/test_transfer.py: enhance tests
1464 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
1467 2006-12-08 Brian Warner <warner@lothar.com>
1469 * buildbot/scripts/runner.py (sendchange): halt the reactor on
1470 both success *and* failure. Without this, the 'buildbot
1471 sendchange' command would hang if it could not contact the
1472 buildmaster or deliver the Change, which would generally cause the
1473 user's commit/record/checkin command to hang too. Thanks to
1474 Christian Unger for the catch.
1476 2006-12-06 Brian Warner <warner@lothar.com>
1478 * NEWS: update with items for the next release
1480 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
1481 whimsical example pulled from a punch-drunk email I sent out late
1483 (Transferring Files): document some of the other parameters
1484 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
1485 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
1486 * buildbot/test/test_svnpoller.py: same
1487 * buildbot/changes/svnpoller.py (SVNPoller): same
1489 2006-11-26 Brian Warner <warner@lothar.com>
1491 * docs/buildbot.texinfo (Build Properties): remind users that
1492 WithProperties must appear in a command= list, not as a top-level
1494 * buildbot/steps/shell.py (ShellCommand.start): and assert that
1495 we're sending a list or a single string to the RemoteShellCommand
1497 * buildbot/scheduler.py (Nightly): Improve docs slightly.
1499 * buildbot/scripts/startup.py (start): skip the whole
1500 watch-the-logfile thing under windows, since it needs os.fork()
1502 * buildbot/scripts/runner.py (restart): remove the old message
1503 that got printed after the buildbot was restarted.. it most cases
1504 it didn't get printed at the right time anyways
1506 2006-11-25 Brian Warner <warner@lothar.com>
1508 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1509 follow twistd.log and print lines until the process has started
1510 started properly. For the buildmaster, this means until the config
1511 file has been parsed and accepted. For the buildslave, this means
1512 until we've connected to the master. We give up after 5 seconds in
1513 any case. Helpful error messages and troubleshooting suggestions
1514 are printed when we don't see a successful startup. This closes the
1515 remainder of SF#1517975.
1516 * buildbot/scripts/startup.py: moved app startup code to here
1517 * buildbot/scripts/logwatcher.py: utility class to follow log
1518 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1519 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1520 so the LogWatcher can tell the difference between a buildmaster
1523 2006-11-24 Brian Warner <warner@lothar.com>
1525 * docs/examples/twisted_master.cfg: update to match the version
1526 in use on twistedmatrix.com
1527 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1528 was using before stopped working, but 'irc.freenode.net' works
1531 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1534 * buildbot/clients/base.py (TextClient.not_connected): upon
1535 UnauthorizedLogin failures, remind the user to connect to the
1536 PBListener port instead of the slaveport.
1537 (TextClient.disconnected): shut down more quietly
1538 * docs/buildbot.texinfo (statuslog): add another reminder
1540 * buildbot/scripts/runner.py (Options.subCommands): rename
1541 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1542 'sighup' as an alias.
1543 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1544 reconfig command to follow twistd.log and print all of the lines
1545 from the start of the config-file reload to its completion. This
1546 should make it a lot easier to discover bugs in the config file.
1547 Use --quiet to disable this behavior. This addresses half of
1548 SF#1517975, the other half will be to add this same utility to
1549 'buildbot start' and 'buildbot restart'.
1550 * docs/buildbot.texinfo (Loading the Config File): same
1553 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1554 method, it has been deprecated for a long time. Use
1555 IBuilderControl.requestBuild instead.
1556 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1557 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1558 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1559 * buildbot/test/test_control.py (Force.testForce): same
1560 * buildbot/test/test_run.py: use requestBuild instead
1562 * buildbot/clients/debug.py: replace 'Force Build' button with
1563 'Request Build' (which just adds one to the queue), add Ping
1564 Builder, add branch/revision fields to Request Build.
1565 * buildbot/clients/debug.glade: same
1566 * buildbot/master.py: update interface to match. This creates an
1567 incompatibility between new debugclients and old buildmasters.
1569 * buildbot/process/builder.py (Builder._attached): delay the call
1570 to maybeStartBuild for a reactor turn, to avoid starting a build
1571 in the middle of a reconfig (say, if the new Builder uses a new
1572 slave which is already connected).
1574 2006-11-23 Brian Warner <warner@lothar.com>
1576 * buildbot/test/test_transfer.py: appease pyflakes
1577 * buildbot/test/test_steps.py: same
1579 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1580 keeps pyflakes from finding undefined names
1582 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1583 Builder no longer induces a disconnect/reconnect cycle. This means
1584 that any builds currently in progress will not be interrupted, and
1585 any builds which are queued in the Builder will not be lost. This
1586 is implemented by having the new Builder extract the state (i.e.
1587 all pending Builds and any desired SlaveBuilders) from the old
1589 (BotPerspective): refactor. The BotPerspective no longer keeps
1590 track of all the Builders that want to use this slave; instead, it
1591 asks the BotMaster each time it needs this list. This removes
1592 addBuilder and removeBuilder. Clean up attached() to acquire all
1593 the slave's information in a more atomic fashion. updateSlave() is
1594 now the way to make sure the slave is using the right set of
1595 Builders: just call it after everything else has been
1597 (BotMaster): refactor, removing addBuilder/removeBuilder and
1598 replacing them with an all-at-once setBuilders() call.
1600 * buildbot/test/test_slaves.py (Reconfig): new test case to
1601 exercise this functionality
1602 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1603 * buildbot/slave/commands.py (WaitCommand): same
1605 * docs/buildbot.texinfo (Loading the Config File): document the
1608 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1609 SlaveBuilder to have its parent Builder changed.
1610 (SlaveBuilder.isAvailable): new method to give access to state,
1611 which is now a private attribute
1612 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1613 the SlaveBuilder about how it is being used. These methods update
1614 its internal state. buildFinished() is now the place that invokes
1615 maybeStartBuild() on its parent Builder.
1616 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1617 new Builder to take over for an old one, transferring state from
1619 (Buider): refactor the way that SlaveBuilders are used to match,
1620 giving them a bit more autonomy.
1621 (Builder.buildFinished): this no longer calls maybeStartBuild():
1622 instead the SlaveBuilder calls it on whoever its parent Builder is
1623 at the time. This way, when an old Builder is replaced by a new
1624 one, and there was a build in progress during the transition, when
1625 that build finishes, it will be the new Builder that is told about
1626 the newly available slave so it can start a new build.
1628 * buildbot/process/base.py (Build.startBuild._release_slave): when
1629 the Build finishes, tell the SlaveBuilder that they've been
1632 * buildbot/status/builder.py (SlaveStatus): add some new setter
1633 methods for use by BotPerspective, to keep some attributes more
1636 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1637 called by the buildmaster.
1638 (Bot.setBuilderList): instead, we locally announce any leftover
1639 directories based upon which Builders we were told about. The
1640 master doesn't really care; it's the local admin who may or may not
1641 wish to delete them.
1644 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1645 to allow use of python2.4 or whatever. This tool still requires
1648 2006-11-19 Brian Warner <warner@lothar.com>
1650 * NEWS (IStatusLog.readlines): more news items
1652 2006-11-18 Brian Warner <warner@lothar.com>
1654 * NEWS: start collecting items for the next release.
1656 2006-11-04 Brian Warner <warner@lothar.com>
1658 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1659 Hearsum. Closes SF#1590310.
1660 * buildbot/test/test_bonsaipoller.py: and tests
1662 * buildbot/status/tinderbox.py
1663 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1664 status when the build results in WARNINGS. Patch from Dave
1665 Liebreich. Closes SF#1587352.
1667 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1668 linux-vs-osx behavior difference w.r.t. reading from files that
1669 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1670 to Mark Rowe for the patch.
1672 2006-10-15 Brian Warner <warner@lothar.com>
1674 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1675 method name was misspelled in the interface definition. Thanks to
1676 Roy Rapoport for the catch.
1678 2006-10-13 Brian Warner <warner@lothar.com>
1680 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1681 to match the great Steps renaming
1683 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1684 Maybe I should run my own unit tests before recording a big
1685 change. Good thing I've got a buildbot to remind me.
1687 2006-10-12 Brian Warner <warner@lothar.com>
1689 * buildbot/steps/transfer.py: rework __init__ and args setup
1690 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1692 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1693 when opening the target file, only catch IOError (to report via
1694 stderr/rc!=0), let the others be reported as normal exceptions
1696 2006-10-08 Brian Warner <warner@lothar.com>
1698 * contrib/svn_watcher.py: fix security holes by using proper argv
1699 arrays and subprocess.Popen() rather than commands.getoutput().
1700 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1701 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1702 probably be removed by the next release.
1705 2006-10-04 Brian Warner <warner@lothar.com>
1707 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1708 initial lines that weren't emitted by pyflakes. When the pyflakes
1709 command is run under a Makefile, 'make' will echo the command it
1710 runs to stdio, and that was getting logged as a "misc" warning.
1711 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1712 * buildbot/test/test_steps.py (testPyFlakes3): another test
1714 2006-10-01 Brian Warner <warner@lothar.com>
1716 * buildbot/status/html.py (HtmlResource.render): if we get a
1717 unicode object from our content() method, encode it into utf-8
1718 like we've been claiming to all along. This allows the comments
1719 and author names from svnpoller.py to be delivered properly.
1721 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1722 de-unicodify filenames before creating the Change, because the
1723 rest of buildbot is unlikely to handle them well. Leave the 'who'
1724 field as a unicode object.. I don't think there's anything that
1725 will break very soon, and it will probably nudge us towards
1726 accepting unicode everywhere sooner or later. Stop using the
1727 "date" field that comes out of SVN, since it is using the
1728 repository's clock (and timezone) and what we care about is the
1729 buildmaster's (otherwise Changes from the future show up later
1730 than the builds they triggered).
1731 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1734 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1735 Suvbersion repository polling ChangeSource. I've hacked it up
1736 considerably: any bugs are entirely my own fault. Thank you
1738 * buildbot/test/test_svnpoller.py: tests for it
1739 * docs/buildbot.texinfo (SvnSource): document it
1741 2006-09-30 Brian Warner <warner@lothar.com>
1743 * buildbot/scheduler.py (Periodic): submit a reason= to the
1744 BuildSet to indicate which Scheduler triggered the build. Thanks
1745 to Mateusz Loskot for the suggestion.
1747 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1749 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1750 changes: set self.loop in __init__, remove unused volatile=
1752 * docs/buildbot.texinfo (.buildbot config directory): add more
1753 docs on the .buildbot/options keys used by "buildbot try"
1754 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1755 (Try.deliverJob): same
1757 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1759 (BonsaiPoller): same
1761 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1762 close the filehandle when we stop watching the file. Before, the
1763 filehandle was only closed when the LogFileWatcher was
1764 garbage-collected, which could be quite a while in the future. If
1765 it was still open by the time the next build started, windows will
1766 refuse to let the new build delete the old build/ directory. Fixes
1767 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1768 #twisted for the catch.
1770 2006-09-29 Brian Warner <warner@lothar.com>
1772 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1775 2006-09-25 Brian Warner <warner@lothar.com>
1777 * setup.py: the new buildbot.steps module wasn't being installed.
1778 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1779 (testmsgs): add the extra stuff from buildbot/test/* so you can
1780 run unit tests on an installed copy of buildbot, not just from
1783 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1784 columns of 'svnlook changed' output contain status information, so
1785 strip [:4] instead of [:6]. Depending upon what the status flags
1786 were, this would sometimes lead to mangled filenames. Thanks to
1787 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1789 * buildbot/steps/source.py (Monotone): initial Monotone support,
1790 contributed by Nathaniel Smith. Still needs docs and tests, but
1791 this code has been in use on the Monotone buildbot for a long
1793 * buildbot/slave/commands.py (Monotone): slave-side support
1794 * buildbot/changes/monotone.py (MonotoneSource): polling change
1797 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1798 contributed a Change Source that polls a Bonsai server (a
1799 kind of web-based viewcvs CGI script).
1801 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1802 Hearsum contributed a status plugin which sends email in the same
1803 format that Tinderbox does: this allows a number of tinderbox
1804 tools to be driven by Buildbot instead. Thanks Ben!
1806 2006-09-24 Brian Warner <warner@lothar.com>
1808 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1809 Thanks to Robert Helmer for the patch.
1811 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1812 BuildStatus about the buildslave name at the *beginning* of the
1813 build, rather than at the end. Thanks to Alexander Lorenz for the
1815 * buildbot/status/html.py (StatusResourceBuild.body): always
1816 include the slavename in the build page, not just when the build
1818 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1819 slavename in the email message
1821 2006-09-21 Brian Warner <warner@lothar.com>
1823 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1825 * docs/examples/glib_master.cfg: same
1826 * docs/examples/hello.cfg: same
1827 * docs/examples/twisted_master.cfg: same, update to current usage
1829 2006-09-19 Brian Warner <warner@lothar.com>
1831 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1832 (PyFlakes.createSummary): make it compatible with python-2.2
1834 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1835 for at least the output-parsing parts of PyFlakes
1837 2006-09-18 Brian Warner <warner@lothar.com>
1839 * buildbot/steps/python.py: oops, fix import of StringIO
1841 2006-09-17 Brian Warner <warner@lothar.com>
1843 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1844 turns out that SVN-1.4.0 doesn't fail to update once you've
1845 replaced a file with a directory, unlike older versions of SVN and
1846 pretty much every other VC tool we support. Since what we really
1847 care about is that the update succeeds anyway, stop checking that
1848 the tree got clobbered and just assert that the build succeeded.
1849 (VCBase.printLogs): add a utility function for debugging
1851 * buildbot/process/step.py: oops, added extra imports by mistake
1853 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1854 rstrip() on the first line coming out of the 'p4 describe'
1855 process, to remove the stray ^M that Wade Brainerd reports seeing
1856 in the 'when' field. Fixes SF#1555985.
1858 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1859 message logged when c['schedulers'] is not right
1860 * buildbot/scheduler.py (Scheduler.__init__): improve error
1861 message when a Scheduler() is created with the wrong arguments
1862 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1863 verify that these error messages are emitted
1865 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1866 The idea is that all the base classes (like BuildStep and
1867 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1868 will be a leftover backwards-compatibility file that only contains
1869 aliases for the steps that were moved out to buildbot.steps.*
1870 * lots: change imports to match
1871 * buildbot/process/step.py: add a DeprecationWarning if it ever
1874 2006-09-12 Brian Warner <warner@lothar.com>
1876 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1877 builderNames= is actually a sequence, since if you happen to give
1878 it a single builder-specification dictionary instead, it won't get
1879 caught by the existing assert. Thanks to Brett Neely for the
1882 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1884 * docs/buildbot.texinfo (Python BuildSteps): document them
1885 (sendchange): include a link to PBChangeSource, since you need one
1887 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1889 * buildbot/steps/dummy.py: same
1891 2006-09-08 Brian Warner <warner@lothar.com>
1893 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1894 BuildStep which lets you transfer files from the master to the
1895 slave or vice versa. Thanks to Albert Hofkamp for the original
1896 patch. Fixes SF#1504631.
1897 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1899 (SlaveFileDownloadCommand): same
1900 * docs/buildbot.texinfo (Transferring Files): document it
1901 * buildbot/test/test_transfer.py: test it
1902 * buildbot/test/runutils.py (StepTester): new utility class for
1903 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1904 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1907 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1908 walk through StatusLogs one line at a time, mostly for the benefit
1909 of ShellCommand.createSummary methods. You can either walk through
1910 STDOUT or STDERR, but the default is STDOUT.
1912 * buildbot/status/builder.py (LogFile.readlines): implement it.
1913 Note that this is not yet memory-efficient, it just pulls the
1914 whole file into RAM and then splits it up with a StringIO.
1915 Eventually this should be a generator that only pulls chunks from
1917 * buildbot/test/test_status.py (Log.testReadlines): test it
1919 * docs/buildbot.texinfo: update to match changes
1920 * buildbot/process/factory.py: stop using old definitions
1921 * buildbot/process/process_twisted.py: same
1922 * buildbot/test/test_*.py: same
1924 * buildbot/process/step_twisted.py: move definition to..
1925 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1926 relative-import mechanisms prevent this from being named 'twisted'
1927 or 'python/twisted' as I would have preferred.
1929 * buildbot/process/maxq.py: move definition to..
1930 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1932 * buildbot/process/step.py: split the user-visible BuildSteps into
1933 separate files, all under buildbot/steps/
1934 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1935 * buildbot/steps/shell.py: this holds ShellCommand and friends
1936 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1938 2006-09-05 Brian Warner <warner@lothar.com>
1940 * lots: run pyflakes, removed a lot of unused imports, changed the
1941 form of some conditional imports to remove false pyflakes
1942 warnings. There are still a number of warnings left, mostly from
1943 imports that are done for their side-effects.
1944 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1947 2006-08-26 Brian Warner <warner@lothar.com>
1949 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1950 compatible with twisted-1.3.0, for some reason I just can't seem
1951 to let go of the past.
1953 2006-08-25 Brian Warner <warner@lothar.com>
1955 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1957 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1958 all logfiles= in startCommand(), rather than in start() . This
1959 makes it easier to have the 'stdio' log come before any secondary
1960 logfiles, which I feel makes the waterfall display more
1962 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1963 from ShellCommand up into LoggingBuildStep
1964 (LoggingBuildStep.__init__): move the handling of logfiles= from
1965 ShellCommand up to LoggingBuildStep, because startCommand is
1966 provided by LoggingBuildStep, whereas start() was specific to
1967 subclasses like ShellCommand and Source. This removes code
1968 duplication in those subclasses.
1969 (ShellCommand.__init__): same
1970 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1971 for a slave that's too old to understand logfiles= into a separate
1972 method, so it can live in ShellCommand. The rest of
1973 setupLogfiles() can live in LoggingBuildStep.
1975 2006-08-24 Brian Warner <warner@lothar.com>
1977 * buildbot/locks.py (BaseLock): you can now configure Locks to
1978 allow multiple simultaneous owners. They still default to
1979 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1981 * docs/buildbot.texinfo (Interlocks): document the new options
1982 * buildbot/test/test_locks.py: add a bunch of new unit tests
1983 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1984 waitUntilMaybeAvailable, not waitUntilAvailable
1985 * buildbot/process/step.py (BuildStep.acquireLocks): same
1986 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1987 the whole lockid in their constructor, not just the name. Also,
1988 keep track of which real locks we've handed out by the full
1989 lockid, not just class+name, otherwise changing just the maxCount=
1990 in the master.cfg file would not actually cause a behavioral
1993 2006-08-23 Brian Warner <warner@lothar.com>
1995 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1997 * docs/buildbot.texinfo: same
1999 2006-08-23 Brian Warner <warner@lothar.com>
2001 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
2002 * docs/buildbot.texinfo: set version to match
2003 * NEWS: update for 0.7.4
2004 * buildbot/slave/commands.py (command_version): mention that this
2005 version (2.1) was released with buildbot-0.7.4
2007 2006-08-22 Brian Warner <warner@lothar.com>
2011 * CREDITS: new file, list of people who have helped. Thanks!
2012 * MANIFEST.in: ship it
2014 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
2015 new diagrams, the user's manual is more informative than it was.
2016 Start shipping the .html user's manual (and generated .png
2018 * Makefile: update 'release' target to match
2020 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
2021 test.. I think the web-parts effort will render it pointless well
2022 before it ever actually starts to work.
2024 2006-08-20 Brian Warner <warner@lothar.com>
2026 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
2027 meaning of the prefix= argument. It is now just a string which is
2028 stripped from the beginning of the filename. If prefix= is set but
2029 not found on any given filename, that filename is ignored. If all
2030 filenames in a Change are ignored, the Change is dropped. This is
2031 much simpler than the previous sep= nonsense, and I should have
2032 implemented it this way from the beginning. Effectively resolves
2033 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
2034 Gedminas for the catch and suggested fixes.
2035 (ChangePerspective.perspective_addChange): implement the actual
2037 * buildbot/test/test_changes.py (TestChangePerspective): test it
2038 * docs/buildbot.texinfo (PBChangeSource): document it, explain
2039 how to properly use prefix=
2040 * docs/examples/twisted_master.cfg (source): update prefix= by
2041 adding the trailing slash
2044 * docs/examples/twisted_master.cfg: update to actual practice
2046 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
2047 update test case to match new link text.. the HREF has both a
2048 class= setting and an enclosing [] pair that I didn't match in the
2051 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
2052 list of strings is preferred over a single string with embedded
2054 (ShellCommand.description=): explain that either single strings or
2055 a list of strings is acceptable, and why you might prefer one over
2056 the other. Add an example. Fixes SF#1524659, thanks to Paul
2057 Winkler for the catch.
2058 (Build Steps): update to use f.addStep() rather than using s()
2059 and the constructor list
2061 * buildbot/process/step.py (ShellCommand): accept either a single
2062 string or a list of strings in both description= and
2064 * buildbot/test/test_steps.py (Steps.test_description): test it
2065 * buildbot/test/runutils.py (makeBuildStep): support for that test
2067 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
2068 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
2069 collecting the files and creating the patch.
2071 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
2072 per-step URLs that will be displayed on the waterfall display,
2073 for things like the HTML output of code-coverage tools, when
2074 the results are hosted elsewhere.
2075 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
2076 way to retrieve these URLs
2077 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
2078 the method to retrieve these URLs. Also provide backwards
2079 compatibility for saved BuildStepStatus instances that didn't have
2081 * buildbot/process/step.py (BuildStep.addURL): method to set these
2082 URLs from within a BuildStep
2083 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
2084 (StepBox.getBox): give these external links a distinct CSS class
2085 named "BuildStep external" so a .css file can display them
2088 * buildbot/test/test_web.py (WaterfallSteps): test that we really
2090 * buildbot/test/test_steps.py (Steps): test that we can all the
2091 URLs. Also add a bunch of other tests on methods that can be
2092 called from within BuildSteps
2093 * buildbot/test/runutils.py (makeBuildStep): add utility function
2095 2006-08-13 Brian Warner <warner@lothar.com>
2097 * docs/buildbot.texinfo (BuildStep LogFiles): document them
2099 2006-08-10 Brian Warner <warner@lothar.com>
2101 * docs/buildbot.texinfo (Index of master.cfg keys): add another
2102 index, this one of things like c['sources'] and c['schedulers']
2103 (indices): it looks like my clever idea of putting the @fooindex
2104 commands in between the @node and the @subsection (to make the
2105 HREF anchor jump to slightly above the section title, which works
2106 much better in html) confused texinfo horribly, so I'm moving the
2107 index tags back to be just after the @subsection marker. I also
2108 added extra lines between the @node/@section paragraph and the
2109 index tags, since I think maybe texinfo wants to see these be
2110 separate paragraphs.
2112 * docs/Makefile (images): make sure images get built when
2113 rendering the manual
2114 * docs/images/Makefile: same
2116 * buildbot/scripts/runner.py: rename 'buildbot master' to
2117 'buildbot create-master', and 'buildbot slave' to 'buildbot
2119 * docs/buildbot.texinfo: same
2122 * docs/buildbot.texinfo: reimplement the "useful classes" index
2123 with actual texinfo indices. The .info rendering is a bit
2124 weird-looking but it works well, and the HTML rendering is quite
2125 nice. This also puts the index targets in the regular flow of the
2126 text, which is easier to maintain.
2128 2006-08-06 Brian Warner <warner@lothar.com>
2130 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
2131 Kevin Turner to prefer the environ= argument be a list rather than
2132 a string. If it is a list, it will be joined with a platform-local
2133 os.pathsep delimiter, and then prepended to any existing
2134 $PYTHONPATH value. This works better in cross-platform (i.e.
2135 windows buildslaves) environments when you need to push multiple
2136 directories onto the front of the path.
2137 (SlaveShellCommand): documented the new magic
2138 * docs/buildbot.texinfo (ShellCommand): documented the new magic
2139 in a user-visible form
2141 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
2142 Turner to prefer lists over strings when creating/running VC
2143 commands during unit tests. This is clearly necessary to survive
2144 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
2145 renamed the wq() function to qw() though, since that's how it's
2146 spelled in perl. Eventually I'd prefer all commands to be
2147 specified with lists.
2149 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
2150 which are deleted (or not yet created) correctly. Also add
2151 failsafe code to not explode if the file-watching poller doesn't
2152 get started. Thanks to JP Calderone for the catch and the poller
2154 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
2156 * buildbot/test/emitlogs.py: same
2158 * NEWS: summarize recent changes
2160 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
2161 clause to avoid the "host key mismatch" warning
2163 * buildbot/process/step_twisted.py (Trial.start): if the
2164 buildslave is too old to understand logfiles=, fall back to
2165 running 'cat _trial_temp/test.log' like before.
2166 (Trial.commandComplete): same. this takes advantage of the
2167 LoggingBuildStep refactoring to stall commandComplete long enough
2168 to run a second RemoteShellCommand.
2170 * buildbot/process/step.py (LoggingBuildStep.startCommand):
2171 refactor command-completion handling, to allow methods like
2172 commandComplete/createSummary/evaluateCommand to return Deferreds.
2173 (LoggingBuildStep._commandComplete): delete the refactored method
2174 (ShellCommand.setupLogfiles): if the buildslave is too old to
2175 understand logfiles=, put a warning message both into twistd.log
2176 and into the otherwise empty user-visible LogFiles.
2178 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
2179 callers to provide the slave-side logfile name, rather than
2180 forcing it to come from the local name of the LogFile.
2181 (BuildStep.getSlaveName): new method
2183 * buildbot/process/base.py (Build.getSlaveName): new method, so
2184 steps can find out which buildslave they're running on
2186 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
2187 to match the s/cvs_ver/command_version/ change
2189 2006-08-05 Brian Warner <warner@lothar.com>
2191 * buildbot/slave/commands.py (command_version): replace the CVS
2192 auto-updated cvs_ver keyword with a manually-updated variable,
2193 since CVS is no longer the master repository. Add a description of
2194 the remote API change starting in this version (2.1), specifically
2195 the fact that SlaveShellCommand now accepts 'initial_stdin',
2196 'keep_stdin_open', and 'logfiles'.
2198 2006-07-31 Brian Warner <warner@lothar.com>
2200 * docs/buildbot.texinfo (System Architecture): Finally add lots of
2201 diagrams to describe how the whole system fits together. The
2202 images themselves are kept in SVG files, with ascii-art versions
2203 in corresponding .txt files. Texinfo knows how to interpolate the
2204 text version into .info files, reference the .png versions from
2205 .html files, and include .eps versions in the .ps format.
2206 * docs/images/Makefile: tools to create .png and .eps
2207 * docs/images/*.svg: created pictures with Inkscape.
2208 * .darcs-boring: ignore the generated .eps and .png files
2210 2006-07-24 Brian Warner <warner@lothar.com>
2212 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
2213 Scheduler names, since they cause setServiceParent to explode
2215 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
2217 2006-07-20 Brian Warner <warner@lothar.com>
2219 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
2220 which runs the buildbot unit tests
2222 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
2223 classes that are useful in master.cfg
2225 2006-07-15 Brian Warner <warner@lothar.com>
2227 * Makefile (some-apidocs): new target to build only some epydocs
2229 * setup.py: minor comment.. does the classifiers= argument prevent
2230 the setup.py script from working on python2.2/2.3?
2232 * buildbot/scripts/sample.cfg: update manhole example, arrange into
2235 * buildbot/twcompat.py: fix minor typo in comments
2237 * buildbot/manhole.py: move all Manhole-related code out to this
2238 module. Implement SSH-based manholes (with TwistedConch), and move
2239 to conch's nifty line-editing syntax-coloring REPL shell instead
2240 of the boring non-editing monochromatic (and deprecated) old
2242 * buildbot/master.py: remove all Manhole-related code
2243 (BuildMaster.loadConfig._add): make sure the old manhole is
2244 removed before we add the new one
2245 * docs/buildbot.texinfo (Debug options): document new Manhole options
2247 * buildbot/twcompat.py (_which): fix some epydoc issues
2248 * buildbot/status/html.py (Waterfall.__init__): same
2250 2006-06-29 Brian Warner <warner@lothar.com>
2252 * buildbot/interfaces.py: get Interface from b.twcompat to hush
2253 deprecation warnings under newer Twisteds (by using
2254 zope.interface.Interface instead of old twisted.python.components
2256 * buildbot/slave/interfaces.py: same
2258 2006-06-28 Brian Warner <warner@lothar.com>
2260 * buildbot/slave/commands.py (SVN): add --non-interactive to all
2261 svn commands, so it will fail immediately instead of hanging while
2262 it waits for a username/password to be typed in.
2264 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
2265 log message if the step was shut down
2267 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
2268 obsolete reference to mktap.
2270 2006-06-20 Brian Warner <warner@lothar.com>
2272 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
2273 test to include new 'logfiles' argument sent from master to slave
2275 2006-06-19 Brian Warner <warner@lothar.com>
2277 * buildbot/process/step_twisted.py (Trial): track Progress from
2278 _trial_temp/test.log too
2280 * buildbot/process/step.py (OutputProgressObserver): generalize
2281 the earlier StdioProgressObserver into an OutputProgressObserver
2282 that can track LogFiles other than stdio.
2283 (LoggingBuildStep.__init__): same
2285 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
2286 _trial_temp/test.log, not a separate 'cat' command. TODO: this
2287 will fail under windows because of os.sep issues. It might have
2288 worked before if 'cat' was doing cygwin path conversion.
2290 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
2291 creation of LogFileWatchers
2292 (ShellCommand._startCommand): and record the files that were
2293 watched in the 'headers' section of the ShellCommand output
2295 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
2296 need to actually pass it to the slave if you want it to work.
2297 (ShellCommand): document it a bit
2299 * buildbot/test/test_shell.py: new test to validate LogFiles
2300 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
2302 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
2303 before printing the last batch of lines, to test that the polling
2304 logic is working properly
2306 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
2307 handling, making it possible to track multiple logs for a single
2308 RemoteCommand. The previous single logfile is now known as the
2310 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
2311 (RemoteShellCommand.__init__): accept logfiles=
2312 (LoggingBuildStep.startCommand): stdio_log is now one of many
2313 (ShellCommand): added logfiles= argument, as well as a class-level
2314 .logfiles attribute, which will be merged together to figure out
2315 which logfiles should be tracked. The latter maybe be useful for
2316 subclasses of ShellCommand which know they will aways produce
2317 secondary logfiles in the same location.
2319 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
2320 and closeStdin() methods, preparing to make it possible to write
2321 to a ShellCommand's stdin at any time, not just at startup. These
2322 writes are buffered if the child process hasn't started yet.
2323 (LogFileWatcher): new helper class to watch arbitrary logfiles
2324 while a ShellCommand runs. This class polls the file every two
2325 seconds, and sends back 10k chunks to the buildmaster.
2326 (ShellCommand): rename stdin= to initialStdin=, and add
2327 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
2329 (ShellCommand.addLogfile): LogFile text is sent in updates with a
2330 key of "log" and a value of (logname, data).
2331 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
2332 'logfiles' to the master-visible args dictionary.
2333 (SourceBase.doPatch): match s/stdin/initialStdin/ change
2336 * buildbot/test/test_vc.py (Patch.testPatch): same
2339 * buildbot/test/emit.py: write to a logfile in the current
2340 directory. We use this to figure out what was used as a basedir
2341 rather than looking to see which copy of emit.py gets run, so that
2342 we can run the commands from inside _trial_temp rather than inside
2344 * buildbot/test/subdir/emit.py: same
2345 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
2346 argument rather than running from buildbot/test/
2347 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
2348 rather than using an implicit setUp()
2349 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
2350 (ShellBase.testShell1, etc): use explicit path to emit.py instead
2351 of assuming that we're running in buildbot/test/ (and that '.' is
2354 * buildbot/slave/commands.py (Command.doStart): refactor Command
2355 startup/completion a bit: now the SlaveBuilder calls doStart(),
2356 which is not meant for overridding by subclasses, and doStart()
2357 calls start(), which is. Likewise the SlaveBuilder calls
2358 doInterrupt(), and subclasses override interrupt(). This also puts
2359 responsibility for maintaining .running in Command rather than in
2361 (Command.doInterrupt): same
2362 (Command.commandComplete): same, this is called when the deferred
2363 returned by start() completes.
2364 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
2365 (SlaveBuilder.remote_interruptCommand): same
2366 (SlaveBuilder.stopCommand): same
2368 2006-06-16 Brian Warner <warner@lothar.com>
2370 * buildbot/test/test_shell.py: new test file to contain everything
2371 relating to ShellCommand
2372 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
2373 multiple logfiles in realtime" feature, not yet implemented
2374 * buildbot/test/emitlogs.py: support file for testLogFiles
2375 * docs/buildbot.texinfo (ShellCommand): document the feature
2377 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
2379 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
2380 for tests which exercise SlaveCommands in isolation.
2382 * buildbot/test/test_slavecommand.py: Move some utilities like
2383 SignalMixin and FakeSlaveBuilder from here ..
2384 * buildbot/test/runutils.py: .. to here, so they can be used by
2385 other test classes too
2386 * buildbot/test/test_vc.py: more SignalMixin refactoring
2387 * buildbot/test/test_control.py: same
2388 * buildbot/test/test_run.py: and some rmtree refactoring
2390 2006-06-15 Brian Warner <warner@lothar.com>
2392 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
2393 'testBranch' to match other VC tests and have the tests run in
2394 roughly increasing order of dependency
2396 * buildbot/test/test_steps.py (LogObserver): new test to verify
2397 LogObservers can be created at various times and still get
2398 connected up properly
2400 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
2401 to create BuildStepStatus instances that actually work.
2403 * buildbot/process/step.py (LogObserver): add outReceived and
2404 errReceived base methods, to be overridden
2406 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
2407 API to take a name instead of a step, reducing the coupling
2408 somewhat. This returns the BuildStepStatus object so it can be
2409 passed to the new Step, instead of jamming it directly into the
2411 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
2413 * buildbot/process/base.py (Build.setupBuild): use both methods
2414 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
2415 process a bit to match
2417 2006-06-14 Brian Warner <warner@lothar.com>
2419 * docs/buildbot.texinfo (Adding LogObservers): add some limited
2420 docs on writing new LogObserver classes
2421 (Writing New Status Plugins): brief docs on how Status Plugins fit
2424 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
2425 implement a LogObserver that counts how many unit tests have been
2427 (Trial.__init__): wire it in
2428 * buildbot/test/test_twisted.py (Counter): unit test for it
2430 * buildbot/process/step_twisted.py (HLint.commandComplete): update
2431 to new cmd.logs['stdio'] scheme
2432 (Trial.commandComplete): same
2433 (BuildDebs.commandComplete): same
2435 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
2436 LogFiles, instead of just a single one. The old single logfile is
2437 now called "stdio". LoggedRemoteCommand no longer creates a
2438 LogFile for you (the code to do that was broken anyway). If you
2439 don't create a "stdio" LogFile, then stdout/stderr will be
2441 (LogObserver): implement "LogObservers", which a BuildStep can add
2442 to parse the output of a command in real-time. The primary use is
2443 to provide more useful information to the Progress code, allowing
2444 better ETA estimates.
2445 (LogLineObserver): utility subclass which feeds complete lines to
2446 the parser instead of bytes.
2447 (BuildStep.progressMetrics): this is safer as a tuple
2448 (BuildStep.setProgress): utility method, meant to be called by
2450 (BuildStep.addLogObserver): new method, to be called at any time
2451 during the BuildStep (even before any LogFiles have been created),
2452 to attach (or schedule for eventual attachment) a LogObserver to a
2454 (StdioProgressObserver): new LogObserver which replaces the old
2455 "output" progress gatherer
2456 (LoggingBuildStep.__init__): same
2457 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
2458 (LoggingBuildStep._commandComplete): must use logs['stdio']
2459 instead of the old single ".log" attribute.
2460 * buildbot/status/builder.py (LogFile): remove old logProgressTo
2461 functionality, now subsumed into StdioProgressObserver
2462 * buildbot/test/test_status.py (Subscription._testSlave_2): the
2463 log name changed from "output" to "stdio".
2466 * buildbot/interfaces.py (ILogFile): add the Interface used from
2467 the BuildStep towards the LogFile
2468 (ILogObserver): and the one provided by a LogObserver
2469 * buildbot/status/builder.py (LogFile): implement it
2471 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
2472 HEADER constants here ..
2473 * buildbot/status/builder.py (STDOUT): .. from here
2475 2006-06-13 Brian Warner <warner@lothar.com>
2477 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
2478 compatibility with python2.2, which doesn't have the 'substr in
2480 (TestP4Poller.makeTime): utility function to construct the
2481 timestamp using the same strptime() approach as p4poller does. It
2482 turns out that time.mktime() behaves slightly differently under
2483 python2.2, probably something to do with the DST flag, and that
2484 causes the test to fail under python2.2. (changing the mktime()
2485 arguments to have dst=0 instead of -1 caused it to fail under
2486 python2.3. Go figure.)
2487 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
2489 2006-06-12 Brian Warner <warner@lothar.com>
2491 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
2492 proper Perforce (P4) support. Many many thanks to Scott Lamb for
2493 contributing such an excellent patch, including docs and unit
2494 tests! This makes it *so* much easier to apply. I had to update
2495 test_vc.py to handle some recent refactorings, but everything else
2496 applied smoothly. The only remaining thing I'd like to fix would
2497 be to remove the hard-wired port 1666 used by p4d, and allow it to
2498 claim any unused port. This would allow two copies of the test
2499 suite to run on the same host at the same time, as well as
2500 allowing the test suite to run while a real (production) p4d was
2501 running on the same host. Oh, and maybe we should add a warning to
2502 step.P4 that gets emitted if the slave is too old to provide the
2503 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
2504 * buildbot/slave/commands.py (P4): same
2505 (P4Sync): same, some minor updates
2506 * buildbot/changes/p4poller.py: same
2507 * docs/buildbot.texinfo: same
2508 * buildbot/test/test_p4poller.py: same
2509 * buildbot/test/test_vc.py (P4): same
2511 * setup.py: add Trove classifiers for PyPI
2513 2006-06-08 Brian Warner <warner@allmydata.com>
2515 * buildbot/status/client.py
2516 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2517 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2518 build needs to be IRemote'd separately, rather than IRemote'ing
2519 the whole list at once. I can't wait until newpb's serialization
2520 adapters make this unnecessary.
2522 2006-06-06 Brian Warner <warner@lothar.com>
2524 * buildbot/process/step.py (WithProperties): make this inherit
2525 from ComparableMixin, so that reloading an unchanged config file
2526 doesn't cause us to spuriously reload any Builders which use them.
2527 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2530 2006-06-03 Brian Warner <warner@lothar.com>
2532 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2533 running py2exe on windows, contributed by Mark Hammond. Addresses
2534 SF#1401121, but I think we still need to include
2535 buildbot/scripts/sample.cfg
2536 * setup.py: include buildbot_service.py as a script under windows
2537 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2538 a py2exe application), get the icon/css datafiles from a different
2541 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2542 double-escape the build URL. Thanks to Olivier Bonnet for the
2543 patch. Fixes SF#1452801.
2545 2006-06-02 Brian Warner <warner@lothar.com>
2547 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2548 first six columns of 'svnlook' output, not just the first column,
2549 since property changes appear in the other five. Thanks to Olivier
2550 Bonnet for the patch. Fixes SF#1398174.
2552 2006-06-01 Brian Warner <warner@lothar.com>
2554 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2555 the fake build, so that title= has something to be set to
2557 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2558 attribute of the "Build #NN" link in the yellow start-the-build
2559 box to the build's reason. This means that you get a little
2560 tooltip explaining why the build was done when you hover over the
2561 yellow box. Thanks to Zandr Milewski for the suggestion.
2563 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2564 (Box.setETA): handle ETA=None (by stopping the timer)
2565 (Box.update): make the [soon] text less different than the usual
2566 text, so the rest of the text doesn't flop around so much. It
2567 would be awfully nice to figure out how to center this stuff.
2568 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2570 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2571 by default, so that any ShellCommand which fails marks the overall
2572 build as a failure. I should have done this from the beginning.
2573 Add flunkOnFailure=False to the arguments if you want to turn off
2576 2006-05-30 Brian Warner <warner@lothar.com>
2578 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2579 last-build/current-build/current-step. Show what step is currently
2580 running. Show ETA for both the overall build and the current step.
2581 Update GTK calls to modern non-deprecated forms. There's still a
2582 lot of dead code and debug noise to remove.
2584 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2585 shows up properly in status displays
2587 2006-05-28 Brian Warner <warner@lothar.com>
2589 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2590 build we use to verify that WithProperties works:
2592 ** set flunkOnFailure=True so that build failures get noticed
2593 ** set workdir='.' so that the build succeeds, otherwise it is trying
2594 to touch 'build/something', and 'build/' doesn't exist because
2595 usually that's created by a Source step
2596 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2597 this test somehow triggers, in which the 'touch' process becomes
2598 a zombie and we wait for th etimeout before giving up on it.
2600 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2601 to log the Build results and step logs to the twisted log.
2602 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2603 what went wrong if a build was expected to succeed but didn't.
2605 * buildbot/process/step_twisted.py (Trial): set the default
2606 trialMode to '--reporter=bwverbose', which specifies verbose
2607 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2608 '-to', but those are completely missing in modern Twisteds.
2610 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2611 a localhost-only port, to encourage better security
2613 * docs/buildbot.texinfo (Change Sources): mention
2616 * .darcs-boring: add a Darcs boringfile
2618 * README (REQUIREMENTS): stop claiming compatibility with
2621 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2624 2006-05-27 Brian Warner <warner@lothar.com>
2626 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2627 * docs/buildbot.texinfo: same
2629 2006-05-23 Brian Warner <warner@lothar.com>
2631 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2632 * docs/buildbot.texinfo: set version to match
2633 * NEWS: update for 0.7.3
2635 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2636 give a quick mapping from VC system to possible ChangeSources
2637 (Build Properties): add 'buildername'
2639 * buildbot/process/base.py (Build.setupStatus): oops, set
2640 'buildername' and 'buildnumber' properties
2641 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2644 2006-05-22 Brian Warner <warner@lothar.com>
2646 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2647 property interpolation better
2649 * README (INSTALLATION): remove old '-v' argument from recommended
2652 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2653 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2656 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2657 'svnversion' instead of grepping the output of 'svn info', much
2658 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2659 Bonnet for the suggestion.
2660 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2661 require the WC_PATH argument, so run 'svnversion .' instead.
2663 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2664 aren't supposed to have 'self' in their argument list
2666 2006-05-21 Brian Warner <warner@lothar.com>
2668 * buildbot/process/step.py (ShellCommand.start): make
2669 testInterpolate pass. I was passing the uninterpolated command to
2670 the RemoteShellCommand constructor
2671 (ShellCommand._interpolateProperties): oops, handle non-list
2672 commands (i.e. strings with multiple words separated by spaces in
2673 them) properly, instead of forgetting about them.
2675 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2676 to actually try to use build properties in a real build. This test
2678 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2679 to start and evaluate builds
2681 * buildbot/test/test__versions.py: add a pseudo-test to record
2682 what version of Twisted/Python/Buildbot are running. This should
2683 show up at the beginning of _trial_tmp/test.log, and exists to help
2684 debug other problems.
2686 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2687 a filename to be served as 'robots.txt' to discourage web spiders.
2688 Adapted from a patch by Tobi Vollebregt, thanks!
2689 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2690 (Waterfall.test_waterfall): tweak the way that filenames are put
2691 into the config file, to accomodate windows pathnames better.
2693 * docs/buildbot.texinfo (HTML Waterfall): document it
2695 * buildbot/process/process_twisted.py
2696 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2697 changed the build process. The new setup.py no longer takes the
2699 (FullTwistedBuildFactory.__init__): same
2700 (TwistedReactorsBuildFactory.__init__): same
2702 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2703 be placed in the [hooks] section of the central repository (the
2704 one that everybody pushes changes to).
2706 2006-05-20 Brian Warner <warner@lothar.com>
2708 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2709 .darcs-context file, use binary mode. I think this was causing a
2710 Darcs failure under windows.
2712 2006-05-19 Brian Warner <warner@lothar.com>
2714 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2715 use a timezone string of +0000 and gmtime, since this timestamp is
2716 sent to a buildmaster and %z is broken.
2718 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2719 string and localtime, since this timestamp will only be consumed
2720 locally, and %z is broken.
2722 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2723 gmtime, since this timestamp is returned to the buildmaster, and
2726 2006-05-18 Brian Warner <warner@lothar.com>
2728 * NEWS: update in preparation for next release
2730 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2731 setup-repository and do-we-have-the-vc-tools code into a separate
2732 "helper" class, which sticks around in a single module-level
2733 object. This seems more likely to continue to work in the future
2734 than having it hide in the TestCase and hope that TestCases stick
2735 around for a long time.
2737 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2738 addremove' has been deprecated in recent versions of mercurial, so
2739 use 'hg add' instead
2741 2006-05-07 Brian Warner <warner@lothar.com>
2743 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2744 operating under windows, move the file before opening it, since
2745 you can't rename a file that somebody has open.
2747 * buildbot/process/base.py (Build.setupBuild): if something goes
2748 wrong while creating a Step, log the name and arguments, since the
2749 error message when you get the number of arguments wrong is really
2752 2006-05-06 Brian Warner <warner@lothar.com>
2754 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2755 bugs in twisted-specific code not covered by my unit tests, this
2756 time use 'cmd' argument instead of self.cmd
2758 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2759 fix stupid braino: either use startwith or find()==0, not both.
2760 (TwistedReactorsBuildFactory.__init__): another dumb typo
2762 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2763 mark this test as TODO under windows, since process-killing seems
2764 dodgy there. We'll come back to this later and try to fix it
2767 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2768 and don't include a timezone
2769 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2770 This should avoid the windows-with-verbose-timezone-name problem
2772 (Patch.testPatch): add a test which runs 'patch' with less
2773 overhead than the full VCBase.do_patch sequence, to try to isolate
2774 a windows test failure. This one uses slave.commands.ShellCommand
2775 and 'patch', but none of the VC code.
2777 * buildbot/slave/commands.py (getCommand): use which() to find the
2778 executables for 'cvs', 'svn', etc. This ought to help under
2781 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2782 working directory before starting. If an earlier test failed, the
2783 leftover directory would mistakenly flunk a later test.
2784 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2785 Make sure that we use the right commandlines if which("tla") picks
2786 up "tla.exe" (as it does under windows).
2787 (TlaSupport.do_get): factor out this tla-vs-baz difference
2788 (TlaSupport.vc_create): more tla-vs-baz differences
2790 * buildbot/test/test_slavecommand.py
2791 (ShellBase.testShellMissingCommand): stop trying to assert
2792 anything about the error message: different shells on different
2793 OSes with different languages makes it hard, and it really isn't
2794 that interesting of a thing to test anyway.
2796 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2797 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2798 "Panther"), because it has a bug which flunks a couple tests in
2799 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2800 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2801 able to test that yet.
2803 2006-04-30 Brian Warner <warner@lothar.com>
2805 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2806 make sure child commands emit messages in english, so our regexps
2807 will match. Thanks to Nikaus Giger for identifying the problems.
2808 (VCBase._do_vctest_export_1): mode="export" is not responsible
2809 for setting the "got_revision" property, since in many cases it is
2810 not convenient to determine.
2811 (SVNSupport.capable): when running 'svn --version' to check for
2812 ra_local, we want error messages in english
2813 * buildbot/test/test_slavecommand.py
2814 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2815 to emit the error message in english
2817 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2818 the environment with $LC_ALL="C" so that Commands which need to
2819 parse the output of their child processes can obtain it in
2821 (SVN.parseGotRevision): call "svn info" afterwards instead of
2822 watching the output of the "svn update" or "svn checkout".
2823 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2824 (Arch.parseGotRevision): same
2825 (Bazaar.parseGotRevision): same
2826 (Mercurial.parseGotRevision): same
2828 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2829 $LC_ALL="C" when running commands under 'buildbot try', too
2831 * buildbot/test/__init__.py: remove the global os.environ()
2832 setting, instead we do it just for the tests that run commands and
2833 need to parse their output.
2835 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2836 remove the overly-short .timeout on this test, because non-DNotify
2837 platforms must fall back to polling which happens at 10 second
2838 intervals, so a 5 second timeout would never succeed.
2840 2006-04-24 Brian Warner <warner@lothar.com>
2842 * docs/buildbot.texinfo (Installing the code): update trial
2843 invocation, SF#1469116 by Niklaus Giger.
2844 (Attributes of Changes): updated branch-name examples to be
2845 a bit more realistic, SF#1475240 by Stephen Davis.
2847 * contrib/windows/buildbot2.bat: utility wrapper for windows
2848 developers, contributed by Nick Trout (after a year of neglect..
2849 sorry!). SF#1194231.
2851 * buildbot/test/test_vc.py (*.capable): store the actual VC
2852 binary's pathname in VCS[vcname], so it can be retrieved later
2853 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2854 strip out non-numeric timezone information, specifically the funky
2855 German string that his system produced that confuses CVS.
2856 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2857 allow Darcs tests to work on windows
2858 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2859 procutils.which() everywhere, to allow tryclient to work under
2860 windows. Also from Niklaus Giger, SF#1463394.
2862 * buildbot/twcompat.py (which): move the replacement for a missing
2863 twisted.python.procutils.which from test_vc.py to here, so it can
2864 be used in other places too (specifically tryclient.py)
2866 2006-04-23 Brian Warner <warner@lothar.com>
2868 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2869 bare buildbotURL/projectName line with a proper DIV, along with a
2870 CSS class of "title", from Stefan Seefeld (SF#1461675).
2871 (WaterfallStatusResource.body0): remove the redundant 'table'
2872 class from the table
2873 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2874 to the top-row TR, and class="Activity" to the second-row TR,
2875 rather than putting them in the individual TD nodes.
2877 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2878 'got_revision' build property for all VC systems that implement
2879 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2881 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2882 to determine which revision we actually obtained
2883 (CVS.parseGotRevision): implement this for CVS, which just means
2884 to grab a timestamp. Not ideal, and it depends upon the buildslave
2885 having a clock that is reasonably well syncronized with the server,
2886 but it's better than nothing.
2887 (SVN.parseGotRevision): implement it for SVN, which is accurate
2888 (Darcs.parseGotRevision): same
2889 (Arch.parseGotRevision): same
2890 (Bazaar.parseGotRevision): same
2891 (Mercurial.parseGotRevision): same
2893 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2894 keep a record of all non-stdout/stderr/header/rc status updates,
2895 for the benefit of RemoteCommands that send other useful things,
2897 (Source.commandComplete): put any 'got_revision' status values
2898 into a build property of the same name
2901 * buildbot/process/step_twisted.py (Trial): update to deal with
2902 new ShellCommand refactoring
2904 * docs/buildbot.texinfo (Build Properties): document new feature
2905 that allows BuildSteps to get/set Build-wide properties like which
2906 revision was requested and/or checked out.
2908 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2909 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2910 it. Note that this bumps the persistenceVersion of the saved Build
2911 object, so add the necessary upgrade-old-version logic to include
2912 an empty properties dict.
2914 * buildbot/process/base.py (Build.setProperty): implement it
2915 (Build.getProperty): same
2916 (Build.startBuild): change build startup to set 'branch',
2917 'revision', and 'slavename' properties at the right time
2919 * buildbot/process/step.py (BuildStep.__init__): change setup to
2920 require 'build' argument in a better way
2921 (LoggingBuildStep): split ShellCommand into two pieces, for better
2922 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2923 a single RemoteCommand that sends stdout/stderr status text. It
2924 also provides the usual commandComplete / createSummary /
2925 evaluateCommand / getText methods to be overridden...
2926 (ShellCommand): .. whereas ShellCommand is specifically for
2927 running RemoteShellCommands. Other shell-like BuildSteps (like
2928 Source) can inherit from LoggingBuildStep instead of ShellCommand
2929 (WithProperties): marker class to do build-property interpolation
2930 (Source): inherit from LoggingBuildStep instead of ShellCommand
2933 * buildbot/test/test_properties.py: test new functionality
2935 2006-04-21 Brian Warner <warner@lothar.com>
2937 * buildbot/test/test_vc.py: rename testBranch to
2938 testCheckoutBranch to keep the tests in about the right
2941 2006-04-18 Brian Warner <warner@lothar.com>
2943 * docs/buildbot.texinfo (PBListener): improve cross-references
2944 between PBListener and 'buildbot statusgui', thanks to John Pye
2947 2006-04-17 Brian Warner <warner@lothar.com>
2949 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2950 running under Twisted-1.3.0, otherwise skipped tests are reported
2953 * all: use isinstance() instead of 'type(x) is foo', suggested by
2956 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2957 oops, fix a brain-fade from the other week, when making the
2958 addStep changes. I changed all the __init__ upcalls to use the
2959 wrong superclass name.
2960 (FullTwistedBuildFactory.__init__): same
2961 (TwistedDebsBuildFactory.__init__): same
2962 (TwistedReactorsBuildFactory.__init__): same
2963 (TwistedBuild.isFileImportant): use .startswith for clarity,
2964 thanks to Neal Norwitz for the suggestions.
2966 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2967 changes, then deliver them over PB to a remote buildmaster.
2969 * contrib/svnpoller.py: added script by John Pye to poll a remote
2970 SVN repository (by running 'svn log') from a cronjob, and run
2971 'buildbot sendchange' to deliver the changes to a remote
2973 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2974 modification of svnpoller.py), same purpose, but this one loops
2975 internally (rather than expecting to run from a cronjob) and works
2977 * contrib/README.txt: same
2979 2006-04-11 Brian Warner <warner@lothar.com>
2981 * all: fix a number of incorrect names and missing imports, thanks
2982 to Anthony Baxter for the patch.
2983 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2984 remove unused buggy method.
2985 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2986 comes from shutil, not "shutils"
2987 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2988 (Arch.checkSlaveVersion): same
2989 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2991 * buildbot/process/step_twisted2.py: add some missing imports
2992 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2993 this code used to live in twisted.internet.defer
2995 2006-04-10 Brian Warner <warner@lothar.com>
2997 * buildbot/process/step.py (Mercurial): add Mercurial support
2998 * buildbot/slave/commands.py (Mercurial): same
2999 * buildbot/scripts/tryclient.py (MercurialExtractor): same
3000 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
3001 not yet tested, but 'try' support *is* covered
3002 * docs/buildbot.texinfo (Mercurial): document it
3004 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
3005 some debugging messages (turned off)
3006 * buildbot/test/test_vc.py: improve debug messages
3008 2006-04-07 Brian Warner <warner@lothar.com>
3010 * buildbot/test/test_vc.py (which): define our own which() in case
3011 we can't import twisted.python.procutils, because procutils doesn't
3012 exist in Twisted-1.3
3014 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
3015 of SlaveLocks for performance tests
3017 * docs/examples/twisted_master.cfg: update to match current usage
3019 * buildbot/changes/p4poller.py (P4Source): add new arguments:
3020 password, p4 binary, pollinterval, maximum history to check.
3021 Patch from an anonymous sf.net contributor, SF#1219384.
3022 * buildbot/process/step.py (P4Sync.__init__): add username,
3023 password, and client arguments.
3024 * buildbot/slave/commands.py (P4Sync): same
3026 2006-04-05 Brian Warner <warner@lothar.com>
3028 * buildbot/process/factory.py (BuildFactory.addStep): new method
3029 to add steps to a BuildFactory. Use it instead of f.steps.append,
3030 and you can probably avoid using the s() convenience function.
3031 Patch from Neal Norwitz, sf.net #1412605.
3032 (other): update all factories to use addStep
3033 * buildbot/process/process_twisted.py: update all factories to use
3036 2006-04-03 Brian Warner <warner@lothar.com>
3038 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
3039 work under windows too. Adapted from a patch by Niklaus Giger,
3040 addresses SF#1463399.
3042 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
3043 spawned commands emit parseable results in english and not some
3044 other language. Patch from Niklaus Giger, SF#1463395.
3046 * README (INSTALLATION): discourage users from running unit tests on
3047 a "network drive", patch from Niklaus Giger, SF#1463394.
3049 2006-03-22 Brian Warner <warner@lothar.com>
3051 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
3052 function to turn a repository-relative pathname into a (branch,
3053 branch-relative-filename) tuple. Change this function to handle
3054 the branch naming policy used by your Subversion repository.
3055 Thanks to AllMyData.com for sponsoring this work.
3057 2006-03-16 Brian Warner <warner@lothar.com>
3059 * buildbot/scripts/sample.cfg: add python-mode declaration for
3060 vim. Thanks to John Pye for the patch.
3062 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
3063 command line, mention the importance of running 'crontab' as the
3064 buildmaster/buildslave user. Thanks to John Pye for the catch.
3066 2006-03-13 Brian Warner <warner@lothar.com>
3068 * buildbot/status/words.py (IRC): add an optional password=
3069 argument, which will be sent to Nickserv in an IDENTIFY message at
3070 login, to claim the nickname. freenode requires this before the
3071 bot can sent (or reply to) private messages. Thanks to Clement
3072 Stenac for the patch.
3073 * docs/buildbot.texinfo (IRC Bot): document it
3075 * buildbot/status/builder.py (LogFile.merge): don't write chunks
3076 larger than chunkSize. Fixes SF#1349253.
3077 * buildbot/test/test_status.py (Log.testLargeSummary): test it
3078 (Log.testConsumer): update to match new internal chunking behavior
3080 2006-03-12 Brian Warner <warner@lothar.com>
3082 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
3084 * buildbot/test/test_maildir.py (MaildirTest): rename the
3085 'timeout' method, as it collides with trial's internals
3087 * buildbot/scripts/runner.py: add 'buildbot restart' command
3088 (stop): don't sys.exit() out of here, otherwise restart can't work
3089 * docs/buildbot.texinfo (Shutdown): document it
3091 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
3092 * buildbot/status/html.py (Waterfall.__init__): same
3093 * buildbot/process/builder.py (Builder.startBuild): same
3094 * buildbot/process/base.py (BuildRequest): same
3095 * buildbot/sourcestamp.py (SourceStamp): same
3096 * buildbot/scheduler.py (Nightly): same
3098 * buildbot/__init__.py (version): bump to 0.7.2+ while between
3100 * docs/buildbot.texinfo: same
3102 2006-02-17 Brian Warner <warner@lothar.com>
3104 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
3105 * docs/buildbot.texinfo: set version number to match
3106 * NEWS: update for 0.7.2
3108 2006-02-16 Brian Warner <warner@lothar.com>
3110 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
3112 2006-02-09 Brian Warner <warner@lothar.com>
3114 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
3115 add text to explain per-build branch parameters
3116 * NEWS: mention --umask
3118 2006-02-08 Brian Warner <warner@lothar.com>
3120 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
3122 (SlaveOptions.optParameters): add --umask, to make it possible to
3123 make buildslave-generated files (including build products) be
3126 * buildbot/slave/bot.py (BuildSlave.startService): same
3128 2006-01-23 Brian Warner <warner@lothar.com>
3130 * buildbot/status/builder.py: urllib.quote() all URLs that include
3131 Builder names, so that builders can include characters like '/'
3132 and ' ' without completely breaking the resulting HTML. Thanks to
3133 Kevin Turner for the patch.
3134 * buildbot/status/html.py: same
3135 * buildbot/test/test_web.py (GetURL.testBuild): match changes
3137 * NEWS: update in preparation for upcoming release
3139 2006-01-18 Brian Warner <warner@lothar.com>
3141 * docs/examples/twisted_master.cfg: update to match the Twisted
3142 buildbot: remove python2.2, switch to exarkun's buildslaves,
3143 disable the .deb builder until we figure out how to build twisted
3144 .debs from SVN, add some ktrace debugging to the OS-X build
3145 process and remove the qt build, remove threadless builders,
3146 change freebsd builder to use landonf's buildslave.
3148 2006-01-12 Brian Warner <warner@lothar.com>
3150 * buildbot/master.py (Manhole.__init__): let port= be a strports
3151 specification string, but handle a regular int for backwards
3152 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
3153 used in master.cfg to limit connections to just the local host.
3154 (BuildMaster.loadConfig): same for c['slavePortnum']
3155 * buildbot/scheduler.py (Try_Userpass.__init__): same
3156 * buildbot/status/client.py (PBListener.__init__): same
3157 * buildbot/status/html.py (Waterfall.__init__): same, for both
3158 http_port and distrib_port. Include backwards-compatibility checks
3159 so distrib_port can be a filename string and still mean unix:/foo
3160 * docs/buildbot.texinfo (Setting the slaveport): document it
3161 (Debug options): same
3162 (HTML Waterfall): same
3165 * buildbot/test/test_config.py (ConfigTest): test it
3167 * buildbot/master.py (BuildMaster.loadConfig): wait for the
3168 slaveport's disownServiceParent deferred to fire before opening
3169 the new one. Fixes an annoying bug in the unit tests.
3171 2006-01-03 Brian Warner <warner@lothar.com>
3173 * buildbot/master.py (BuildMaster): remove the .schedulers
3174 attribute, replacing it with an allSchedulers() method that looks
3175 for all IService children that implement IScheduler. Having only
3176 one parent/child relationship means fewer opportunities for bugs.
3177 (BuildMaster.allSchedulers): new method
3178 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
3179 also fix ugly bug that caused any config-file reload to
3180 half-forget about the earlier Schedulers, causing an exception
3181 when a Change arrived and was handed to a half-connected
3182 Scheduler. The exception was in scheduler.py line 54ish:
3183 self.parent.submitBuildSet(bs)
3184 exceptions.AttributeError: 'NoneType' object has no attribute
3186 (BuildMaster.addChange): update to use allSchedulers()
3188 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
3189 to work properly with twisted-1.3.0, where you must explicitly
3190 include the __implements__ from parent classes
3191 (BaseScheduler.__repr__): make it easier to distinguish distinct
3193 (BaseUpstreamScheduler.__implements__): same
3195 * buildbot/status/builder.py (Status.getSchedulers): update to
3197 * buildbot/test/test_run.py (Run.testMaster): same
3198 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
3199 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
3200 make sure Scheduler instances are left alone when an identical
3201 config file is reloaded
3202 (ConfigElements.testSchedulers): make sure Schedulers are properly
3205 * Makefile (TRIALARGS): my local default Twisted version is now
3206 2.1.0, update the trial arguments accordingly
3208 2005-12-22 Brian Warner <warner@lothar.com>
3210 * docs/examples/twisted_master.cfg: merge changes from pyr: add
3213 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
3214 addChange in the parent class, although I suspect this should be
3215 fixed better in the future.
3217 2005-11-26 Brian Warner <warner@lothar.com>
3219 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
3220 explode when branch==None, thanks to Kevin Turner for the catch
3221 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
3224 * buildbot/__init__.py (version): bump to 0.7.1+ while between
3226 * docs/buildbot.texinfo: same
3228 2005-11-26 Brian Warner <warner@lothar.com>
3230 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
3231 * docs/buildbot.texinfo: set version number to match
3233 2005-11-26 Brian Warner <warner@lothar.com>
3235 * NEWS: update for 0.7.1
3237 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
3238 sure that unsubscribe works even if we never sent an ETA update.
3239 Also, don't explode on duplicate unsubscribe.
3240 (BuildStepStatus.addLog): make the convenience "return self"-added
3241 watcher automatically unsubscribe when the Step finishes.
3242 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
3243 (BuildStatus.stepStarted): same auto-unsubscribe
3244 (BuilderStatus.buildStarted): same auto-unsubscribe
3246 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
3248 (IStatusReceiver.stepStarted): same
3249 (IStatusReceiver.logStarted): same
3251 * buildbot/test/test_run.py (Status): move the Status test..
3252 * buildbot/test/test_status.py (Subscription): .. to here
3254 2005-11-25 Brian Warner <warner@lothar.com>
3256 * NEWS: more updates
3258 * buildbot/locks.py: fix the problem in which loading a master.cfg
3259 file that changes some Builders (but not all of them) can result
3260 in having multiple copies of the same Lock. Now, the real Locks
3261 are kept in a table inside the BotMaster, and the Builders/Steps
3262 use "LockIDs", which are still instances of MasterLock and
3263 SlaveLock. The real Locks are instances of the new RealMasterLock
3264 and RealSlaveLock classes.
3265 * buildbot/master.py (BotMaster.getLockByID): new method to
3266 convert LockIDs into real Locks.
3267 * buildbot/process/base.py (Build.startBuild): convert LockIDs
3268 into real Locks before building
3269 * buildbot/process/step.py (BuildStep.startStep): same
3270 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
3271 exercises the problem
3274 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
3275 what Schedulers are available
3277 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
3278 work by Dobes Vandermeer and hacked mercilessly by me. This offers
3279 'cron'-style build scheduling at certain times of day, week,
3281 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
3283 * buildbot/scheduler.py (Scheduler): change fileIsImportant
3284 handling: treat self.fileIsImportant more as an attribute that
3285 contains a callable than as a method. If the attribute is None,
3286 don't call it and assume all filenames are important. It is still
3287 possible to provide a fileIsImportant method in a subclass,
3289 (AnyBranchScheduler): handle fileIsImportant=None, previously it
3291 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
3292 test using AnyBranchScheduler with fileIsImportant=None
3294 2005-11-24 Brian Warner <warner@lothar.com>
3296 * buildbot/test/test_config.py (StartService): don't claim a fixed
3297 port number, instead set slavePort=0 on the first pass, figure out
3298 what port was allocated, then switch to a config file that uses
3301 * buildbot/master.py (BuildMaster.loadConfig): close the old
3302 slaveport before opening the new one, because unit tests might
3303 replace slavePort=0 with the same allocated portnumber, and if we
3304 don't wait for the old port to close first, we get a "port already
3305 in use" error. There is a tiny race condition here, but the only
3306 threat is from other programs that bind (statically) to the same
3307 port number we happened to be allocated, and only if those
3308 programs use SO_REUSEADDR, and only if they get control in between
3311 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
3313 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
3314 deleted ChangeSources before adding any new ones
3315 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
3316 compare_attrs, to make sure that a config-file reload does not
3317 unnecessarily replace an unmodified ChangeSource instance
3318 * buildbot/test/test_config.py (ConfigTest.testSources): update
3320 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
3321 mean "don't build anything", and add a warning if it gets used
3322 because it isn't actually useful.
3324 * contrib/svn_buildbot.py: update example usage to match the port
3325 number that gets used by the PBChangeSource
3326 * buildbot/scripts/sample.cfg: add example of PBChangeSource
3328 2005-11-22 Brian Warner <warner@lothar.com>
3330 * NEWS: start collecting items for next release
3332 * buildbot/process/step.py (SVN.computeSourceRevision): assume
3333 revisions are strings
3334 (P4Sync.computeSourceRevision): same
3336 * buildbot/status/html.py (StatusResourceBuild.body): add a link
3337 to the Buildbot's overall status page
3338 (StatusResourceBuilder.body): same
3340 2005-11-15 Brian Warner <warner@lothar.com>
3342 * buildbot/master.py (BuildMaster.loadConfig): serialize the
3343 config-file loading, specifically to make sure old StatusTargets
3344 are finished shutting down before new ones start up (thus
3345 resolving a bug in which changing the Waterfall object would fail
3346 because both new and old instances were claiming the same
3347 listening port). Also load new Schedulers after all the new
3348 Builders are set up, in case they fire off a new build right away.
3349 * buildbot/test/test_config.py (StartService): test it
3351 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
3352 the branch name to the mail body
3354 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
3355 Without it, a config-file reload fails to update an existing
3357 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
3358 username/passwd to compare_attrs, for the same reason
3359 * buildbot/status/html.py (Waterfall): add favicon to
3360 compare_attrs, same reason
3362 2005-11-05 Brian Warner <warner@lothar.com>
3364 * buildbot/scripts/tryclient.py (createJobfile): stringify the
3365 baserev before stuffing it in the jobfile. This resolves problems
3366 under SVN (and probably Arch) where revisions are expressed as
3367 numbers. I'm inclined to use string-based revisions everywhere in
3368 the future, but this fix should be safe for now. Thanks to Steven
3369 Walter for the patch.
3371 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
3372 binary mode when opening pickle files, to make windows work
3373 better. Thanks to Dobes Vandermeer for the catch.
3374 * buildbot/status/builder.py (BuildStatus.saveYourself): same
3375 (BuilderStatus.getBuildByNumber): same
3376 (Status.builderAdded): same
3377 * buildbot/master.py (BuildMaster.loadChanges): same
3379 * buildbot/util.py (Swappable): delete unused leftover code
3381 * buildbot/process/step.py (SVN): when building on a non-default
3382 branch, add the word "[branch]" to the VC step's description, so
3383 it is obvious that we're not building the usual stuff. Likewise,
3384 when we are building a specific revision, add the text "rNNN" to
3385 indicate what that revision number is. Thanks to Brad Hards and
3386 Nathaniel Smith for the suggestion.
3387 (Darcs.startVC): same
3388 (Arch.startVC): same
3389 (Bazaar.startVC): same
3391 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
3392 typo, caught by Mark Dillavou, closes SF#1216636.
3394 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
3395 about a test to add some day
3397 * docs/examples/twisted_master.cfg: update: bot1 can now handle
3398 the 'full-2.3' build, and the 'reactors' build is now run under
3399 python-2.4 because the buildslave no longer has gtk/etc bindings
3400 for earlier versions.
3402 2005-11-03 Brian Warner <warner@lothar.com>
3404 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
3405 method, takes an IBuildStatus and rebuilds it. It might make more
3406 sense to add this to IBuildControl instead, but that instance goes
3407 away completely once the build has finished, and resubmitting
3408 builds can take place weeks later.
3409 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
3410 * buildbot/status/html.py (StatusResourceBuild): also stash an
3411 IBuilderControl so we can use resubmitBuild.
3412 (StatusResourceBuild.body): render "resubmit" button if we can.
3413 Also add hrefs for each BuildStep
3414 (StatusResourceBuild.rebuild): add action for "resubmit" button
3415 (StatusResourceBuilder.getChild): give it an IBuilderControl
3417 * buildbot/status/builder.py (Status.getURLForThing): change the
3418 URL for BuildSteps to have a "step-" prefix, so the magic URLs
3419 that live as targets of buttons like "stop" and "rebuild" can't
3421 * buildbot/status/builder.py (Status.getURLForThing): same
3422 * buildbot/status/html.py (StatusResourceBuild.getChild): same
3423 (StepBox.getBox): same
3424 * buildbot/test/test_web.py (GetURL): same
3427 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
3428 exclusivity checks after Source.__init__ upcall, so misspelled
3429 arguments will be reported more usefully
3430 (Darcs.__init__): same
3432 2005-10-29 Brian Warner <warner@lothar.com>
3434 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
3435 builder. Move the Try scheduler off to a separate port.
3437 2005-10-27 Brian Warner <warner@lothar.com>
3439 * buildbot/clients/gtkPanes.py
3440 (TwoRowClient.remote_builderRemoved): disappearing Builders used
3441 to cause the app to crash, now they don't.
3443 * buildbot/clients/debug.py: display the buildmaster's location
3444 in the window's title bar
3446 2005-10-26 Brian Warner <warner@lothar.com>
3448 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
3449 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
3450 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
3452 * buildbot/status/html.py (td): put a single non-breaking space
3453 inside otherwise empty <td> elements, as a workaround for buggy
3454 browsers which would optimize them away (along with any associated
3455 styles, like the kind that create the waterfall grid borders).
3456 Patch from Frerich Raabe.
3458 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
3459 argv-list as an argument, defaulting to ["-to"], which is
3460 appropriate for the Trial that comes with Twisted-2.1.0 and
3461 earlier. The Trial in current Twisted SVN wants
3462 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
3463 defaults to an empty list.
3464 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
3465 match it, now that trialMode= is a list instead of a single string
3467 * buildbot/__init__.py (version): bump to 0.7.0+ while between
3469 * docs/buildbot.texinfo: same
3471 2005-10-24 Brian Warner <warner@lothar.com>
3473 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
3474 * docs/buildbot.texinfo: set version number to match
3476 2005-10-24 Brian Warner <warner@lothar.com>
3478 * README: update for 0.7.0
3480 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
3482 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
3483 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
3484 send the branch= argument unless the user really provided one, to
3485 retain compatibility with older buildmasters that don't accept
3487 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
3490 * docs/buildbot.texinfo: update lots of stuff
3492 * buildbot/scripts/runner.py (sendchange): add a --branch argument
3493 to the 'buildbot sendchange' command
3494 * buildbot/clients/sendchange.py (Sender.send): same
3495 * buildbot/changes/pb.py (ChangePerspective): same
3496 * buildbot/test/test_changes.py (Sender.testSender): test it
3498 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
3499 'default_branch' argument names to 'baseURL' and 'defaultBranch',
3500 for consistency with other BuildStep arguments that use camelCase.
3501 Well, at least more of them use camelCase (like flunkOnWarnings)
3502 than don't.. I wish I'd picked one style and stuck with it
3503 earlier. Annoying, but it's best done before the release, since
3504 these arguments didn't exist at all in 0.6.6 .
3506 * buildbot/test/test_vc.py (SVN.testCheckout): same
3507 (Darcs.testPatch): same
3508 * docs/buildbot.texinfo (SVN): document the change
3509 (Darcs): same, add some build-on-branch docs
3510 * docs/examples/twisted_master.cfg: match change
3512 * buildbot/process/step.py (BuildStep): rename
3513 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3514 how it is normally used.
3515 * buildbot/test/test_steps.py (Version.checkCompare): same
3517 * buildbot/process/step.py (CVS.startVC): refuse to build
3518 update/copy -style builds on a non-default branch with an old
3519 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3520 concern is that it will do a VC 'update' in an existing tree when
3521 it is supposed to be switching branches (and therefore clobbering
3522 the tree to do a full checkout), thus building the wrong source.
3523 This used to be a warning, but I think the confusion it is likely
3524 to cause warrants making it an error.
3525 (SVN.startVC): same, also make mode=export on old slaves an error
3526 (Darcs.startVC): same
3527 (Git.startVC): improve error message for non-Git-enabled slaves
3528 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3529 specific revision is built on a slave that doesn't pay attention
3530 to args['revision'], because for slowly-changing trees it will
3531 probably do the right thing, and because we have no way to tell
3532 whether we're asking it to build the most recent version or not.
3533 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3535 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3536 that 'master' is in host:portnum format, to catch errors sooner
3538 2005-10-23 Brian Warner <warner@lothar.com>
3540 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3541 when creating the list of warning messages, include the line
3542 immediately after each WARNING: line, since that's usually where
3543 the file and line number wind up.
3545 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3550 2005-10-22 Brian Warner <warner@lothar.com>
3552 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3553 patch from Brad Hards
3554 * buildbot/status/classic.css: same
3555 * buildbot/test/test_web.py (Waterfall): match changes
3557 * buildbot/test/test_steps.py (BuildStep.setUp): set
3558 nextBuildNumber so the test passes
3559 * buildbot/test/test_status.py (MyBuilder): same
3561 * buildbot/status/html.py (StatusResourceBuild.body): revision
3562 might be numeric, so stringify it before html-escapifying it
3563 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3564 timer for the upcoming build
3565 * buildbot/status/classic.css: add background-color attributes for
3566 offline/waiting/building classes
3568 * buildbot/status/builder.py (BuildStatus): derive from
3569 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3570 the default (i.e. unknown) .slavename to "???" instead of None,
3571 since even unknown slavenames need to be printed eventually.
3572 (BuilderStatus): also derive from styles.Versioned . More
3573 importantly, determine .nextBuildNumber at creation/unpickling
3574 time by scanning the directory of saved BuildStatus instances and
3575 choosing one larger than the highest-numbered one found. This
3576 should fix the problem where random errors during upgrades cause
3577 the buildbot to forget about earlier builds. .nextBuildNumber is
3578 no longer stored in the pickle.
3579 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3580 at least log the error. Also call Builder.determineNextBuildNumber
3581 once the basedir is set.
3583 * buildbot/master.py (BuildMaster.loadChanges): do
3584 styles.doUpgrade afterwards, in case I decide to make Changes
3585 derived from styles.Versioned some day and forget to make this
3589 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3590 when running under older pythons (<2.3) in which the shlex module
3591 doesn't have a 'split' function.
3593 * buildbot/process/step.py (ShellCommand.start): make
3594 errorMessages= be a list of strings to stuff in the log before the
3595 command actually starts. This makes it easier to flag multiple
3596 warning messages, e.g. when the Source steps have to deal with an
3598 (CVS.startVC): handle slaves that don't handle multiple branches
3599 by switching into 'clobber' mode
3600 (SVN.startVC): same. Also reject branches without base_url
3601 (Darcs.startVC): same. Also reject revision= in older slaves
3602 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3603 (Bazaar.startVC): same, and test for baz separately than for arch
3605 * buildbot/slave/commands.py (cvs_ver): document new features
3607 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3608 (BuildStep.slaveVersionNewEnough): more useful utility method
3609 * buildbot/test/test_steps.py (Version): start testing it
3611 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3612 the 'force' command requires python2.3, for the shlex.split method
3614 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3615 since we don't use it anymore. The Twisted buildbot uses a
3618 2005-10-21 Brian Warner <warner@lothar.com>
3620 * buildbot/process/process_twisted.py: rework all BuildFactory
3621 classes to take a 'source' step as an argument, instead of
3622 building up the SVN instance in the factory.
3623 * docs/examples/twisted_master.cfg: enable build-on-branch by
3624 providing a base_url and default_branch
3626 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3627 control over --branch and --revision, not that they are always
3629 * buildbot/status/html.py (StatusResourceBuilder.force): same
3630 (StatusResourceBuild.body): display SourceStamp components
3632 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3633 IRC 'force' command, so it can be shared with an eventual
3634 command-line-tool 'buildbot force' mode.
3635 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3637 2005-10-20 Brian Warner <warner@lothar.com>
3639 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3641 * docs/examples/twisted_master.cfg: update to use Schedulers
3643 * buildbot/scripts/sample.cfg: update with Schedulers
3645 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3646 method specifically for use by HTML "force build" button and the
3647 IRC "force" command. Raises an immediate error if there are no
3649 (IBuilderControl.requestBuild): make this just submit a build, not
3650 try to check for existing slaves or set up any when-finished
3651 Deferreds or anything.
3652 * buildbot/process/builder.py (BuilderControl): same
3653 * buildbot/status/html.py (StatusResourceBuilder.force): same
3654 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3655 * buildbot/test/test_slaves.py: same
3656 * buildbot/test/test_web.py: same
3658 2005-10-19 Brian Warner <warner@lothar.com>
3660 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3661 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3663 2005-10-18 Brian Warner <warner@lothar.com>
3665 * buildbot/status/html.py: provide 'status' argument to most
3666 StatusResourceFOO objects
3667 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3668 and Logfiles" section to make the Build page into a more-or-less
3669 comprehensive source of status information about the build
3671 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3672 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3674 2005-10-17 Brian Warner <warner@lothar.com>
3676 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3677 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3678 out what to do about other projects: the correct options for
3679 recent Twisteds will not work for older ones.
3681 2005-10-15 Brian Warner <warner@lothar.com>
3683 * buildbot/status/builder.py (Status.getURLForThing): add method
3684 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3685 use this in email/IRC status clients to make them more useful, by
3686 providing the end user with hints on where to learn more about the
3687 object being reported on.
3688 * buildbot/test/test_web.py (GetURL): tests for it
3690 2005-10-14 Brian Warner <warner@lothar.com>
3692 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3693 fix bug resulting from deferredResult changes
3695 2005-10-13 Brian Warner <warner@lothar.com>
3697 * buildbot/test/test_changes.py: remove use of deferredResult
3698 * buildbot/test/test_config.py: same
3699 * buildbot/test/test_control.py: same
3700 * buildbot/test/test_status.py: same
3701 * buildbot/test/test_vc.py: this is the only remaining use, since
3702 it gets used at module level. This needs to be replaced by some
3703 sort of class-level run-once routine.
3705 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3707 * lots: implement multiple slaves per Builder, which means multiple
3708 current builds per Builder. Some highlights:
3709 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3710 of (state,currentBuilds) instead of (state,currentBuild)
3711 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3712 (IBuildStatus.getSlavename): new method, so you can tell which
3713 slave got used. This only gets set when the build completes.
3714 (IBuildRequestStatus.getBuilds): new method
3716 * buildbot/process/builder.py (SlaveBuilder): add a .state
3717 attribute to track things like ATTACHING and IDLE and BUILDING,
3719 (Builder): .. the .slaves attribute here, which has been turned
3720 into a simple list of available slaves. Added a separate
3721 attaching_slaves list to track ones that are not yet ready for
3723 (Builder.fireTestEvent): put off the test-event callback for a
3724 reactor turn, to make tests a bit more consistent.
3725 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3726 ping fails due to an exception. This needs work, I'm worried that
3727 a code error could lead to a constantly re-connecting slave.
3728 Especially since I'm trying to move to a distinct remote_ping
3729 method, separate from the remote_print that we currently use.
3730 (BuilderControl.requestBuild): return a convenience Deferred that
3731 provides an IBuildStatus when the build finishes.
3732 (BuilderControl.ping): ping all connected slaves, only return True
3733 if they all respond.
3735 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3736 reconnect when we shut down.
3738 * buildbot/status/builder.py: implement new methods, convert
3739 one-build-at-a-time methods to handle multiple builds
3740 * buildbot/status/*.py: do the same in all default status targets
3741 * buildbot/status/html.py: report the build's slavename in the
3742 per-Build page, report all buildslaves on the per-Builder page
3744 * buildbot/test/test_run.py: update/create tests
3745 * buildbot/test/test_slaves.py: same
3746 * buildbot/test/test_scheduler.py: remove stale test
3748 * docs/buildbot.texinfo: document the new builder-specification
3749 'slavenames' parameter
3751 2005-10-12 Brian Warner <warner@lothar.com>
3753 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3754 report failure correctly, causing Dependent builds to run when
3755 they shouldn't have.
3756 * buildbot/status/builder.py (BuildSetStatus): same
3757 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3758 (Set.testSuccess): test the both-pass case too
3759 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3760 fix this test: it was ending too early, masking the failure before
3761 (Logger): specialized StatusReceiver to make sure the dependent
3762 builds aren't even started, much less completed.
3764 2005-10-07 Brian Warner <warner@lothar.com>
3766 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3767 bot.SlaveBuilder being disowned in the middle of a build
3769 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3770 this inherit from StatusReceiver. Also upcall in __init__. This
3771 fixes the embarrasing crash when the new buildSetSubmitted method
3772 is invoked and Waterfall/etc don't implement their own.
3773 * buildbot/test/test_run.py: add a TODO note about a test to catch
3774 just this sort of thing.
3776 * buildbot/process/builder.py (Builder.attached): remove the
3777 already-attached warning, this situation is normal. Add some
3778 comments explaining it.
3780 2005-10-02 Brian Warner <warner@lothar.com>
3782 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3783 OverflowError when setting up dnotify, because some 64-bit systems
3784 have problems with signed-vs-unsigned constants and trip up on the
3785 DN_MULTISHOT flag. Patch from Brad Hards.
3787 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3789 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3790 progressMetrics, description, descriptionDone to the 'parms' list,
3791 and make use the 'parms' list from the implementation class
3792 instead of only BuildStep to initialize the parameters. This
3793 allows buildbot.process.factory.s() to initialize all the parms,
3794 not just those defined in directly by BuildStep.
3796 2005-09-03 Brian Warner <warner@lothar.com>
3798 * NEWS: start adding items for the next release
3800 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3801 python2.2 tests, change 'Quick' builder to only use python2.3
3803 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3805 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3806 the "Ping Builder" button if the build control is available; the
3807 user sees an exception otherwise
3809 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3811 2005-09-01 Brian Warner <warner@lothar.com>
3813 * buildbot/interfaces.py (IBuilderStatus.getState): update
3814 signature, point out that 'build' can be None
3815 (IBuildStatus.getETA): point out ETA can be none
3817 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3819 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3821 2005-08-31 Brian Warner <warner@lothar.com>
3823 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3824 update to match correct signature: removed 'eta' argument
3825 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3827 2005-08-30 Brian Warner <warner@lothar.com>
3829 * buildbot/status/builder.py (LogFile): remove the assertion that
3830 blows up when you try to overwrite an existing logfile, instead
3831 just emit a warning. This case gets hit when the buildmaster is
3832 killed and doesn't get a chance to write out the serialized
3833 BuilderStatus object, so the .nextBuildNumber attribute gets out
3836 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3837 the 'buildbot sendchange' arguments, for the Darcs context file
3838 * docs/buildbot.texinfo (sendchange): document it
3840 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3841 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3842 (IStatus.getSchedulers): new method
3843 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3844 (Status.getSchedulers): implement
3845 * buildbot/process/builder.py (Builder): maintain
3846 BuilderStatus.pendingBuilds
3847 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3848 (TryBase.addChange): Try schedulers should ignore Changes
3850 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3851 for 'try' on CVS/SVN
3852 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3854 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3855 report status properly.
3856 (Try.createJob): implement unique buildset IDs
3858 * buildbot/status/client.py (StatusClientPerspective): add a
3859 perspective_getBuildSets method for the benefit of jobdir-style
3861 * docs/buildbot.texinfo (try): more docs
3862 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3865 2005-08-18 Brian Warner <warner@lothar.com>
3867 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3868 actually work. It's functional but still kind of clunky. Also, it
3869 only works with the pb-style.. needs to be made to work with the
3872 * buildbot/status/client.py (RemoteBuildSet): new class
3873 (RemoteBuildRequest): same
3874 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3875 object, not the internal BuildStatus object.
3876 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3877 outside of the usual buildStarted() return value.
3878 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3880 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3881 (Try_Userpass_Perspective.perspective_try): return a remotely
3882 usable BuildSetStatus object
3884 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3885 isStarted()/waitUntilStarted()
3887 2005-08-16 Brian Warner <warner@lothar.com>
3889 * buildbot/status/builder.py: implement IBuildSetStatus and
3890 IBuildRequestStatus, wire them into place.
3891 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3892 methods into the BuildSetStatus object.
3893 * buildbot/interfaces.py: same
3894 (IStatus.getBuildSets): new method to get pending BuildSets
3895 (IStatusReceiver.buildsetSubmitted): new method which hears about
3897 * buildbot/master.py (BuildMaster.submitBuildSet): same
3898 * buildbot/process/base.py (BuildRequest): same, replace
3899 waitUntilStarted with subscribe/unsubscribe
3900 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3901 subscribe instead of waitUntilStarted
3902 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3904 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3906 * buildbot/test/test_buildreq.py: update for new code
3907 * buildbot/test/test_control.py (Force.testRequest): same
3910 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3911 for Darcs to not use the tempfile module, so it works under
3912 python-2.2 too. We really didn't need the full cleverness of that
3913 module, since the slave has exclusive control of its own builddir.
3915 2005-08-15 Brian Warner <warner@lothar.com>
3917 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3918 for CVS trees. It doesn't work for non-trunk branches,
3920 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3923 * Makefile: make it easier to test against python2.2
3925 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3926 tearDown2, so things like Arch can unregister archives as they're
3927 shutting down. The previous subclass-override-tearDown technique
3928 resulted in a nested maybeWait() and test failures under
3931 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3932 where we can (Arch), add a branch= argument to set the branch used
3934 (BazExtractor): extract the branch too
3935 (TlaExtractor): same
3936 * buildbot/scripts/runner.py (TryOptions): add --branch
3937 * docs/buildbot.texinfo (try): document --branch/try_branch
3939 * buildbot/slave/commands.py (Darcs): implement get-revision for
3940 Darcs, so that 'try' will work. This requires the tempfile module
3943 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3944 of revisions, branches, and 'try' in the process.
3946 2005-08-11 Brian Warner <warner@lothar.com>
3948 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3949 this, it got broken at some point in the last few releases
3950 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3951 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3952 specifically the removal of ETA information from the tuple
3954 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3957 * docs/buildbot.texinfo (try): document both --builder and
3958 'try_builders' in .buildbot/options
3959 * buildbot/scripts/runner.py (TryOptions): add --builder,
3960 accumulate the values into opts['builders']
3961 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3962 * buildbot/test/test_runner.py (Try): add some quick tests to make
3963 sure 'buildbot try --options' and .buildbot/options get parsed
3964 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3965 use --builder control
3967 * docs/buildbot.texinfo (try): add --port argument to PB style
3969 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3970 actual SourceStamp. Still need to extract a branch name, somehow.
3971 (Try): finish implementing the try client side, still need a UI
3972 for specifying which builders to use
3973 (Try.getopt): factor our options/config-file reading
3974 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3976 * buildbot/test/test_vc.py: match SourceStampExtractor change
3978 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3979 causes the twisted log to be sent to stderr
3981 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3983 2005-08-10 Brian Warner <warner@lothar.com>
3985 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3986 style is 90% done, still missing status reporting or waiting for
3987 the buildsets to finish, and it is completely untested.
3989 * buildbot/trybuild.py: delete file, move contents to ..
3990 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3991 * buildbot/test/test_vc.py: match the move
3993 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3994 of the TryScheduler, no buildsetID or status-tracking support yet
3995 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3997 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3998 possible to set the basedir after __init__ time, so it is easier
3999 to use as a Service-child of the BuildMaster instance
4001 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
4002 that delivers messages to its Service parent instead of requiring
4003 a subclass to be useful. This turns out to be much easier to build
4006 * buildbot/scripts/tryclient.py (createJob): utility code to
4007 create jobfiles, will eventually be used by 'buildbot try'
4009 2005-08-08 Brian Warner <warner@lothar.com>
4011 * docs/buildbot.texinfo (try): add docs on the
4012 as-yet-unimplemented Try scheduler
4014 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
4015 * buildbot/test/test_scheduler.py: .. here
4016 (Scheduling.testTryJobdir): add placeholder test for 'try'
4018 * buildbot/test/test_status.py (Log.testMerge3): update to match new
4019 addEntry merging (>=chunkSize) behavior
4020 (Log.testConsumer): update to handle new callLater(0) behavior
4022 * buildbot/test/test_web.py: rearrange tests a bit, add test for
4023 both the MAX_LENGTH bugfix and the resumeProducing hang.
4025 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
4026 put off the actual resumeProducing for a moment with
4027 reactor.callLater(0). This works around a twisted-1.3.0 bug which
4028 causes large logfiles to hang midway through.
4030 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
4031 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
4032 and to improve memory usage when streaming the file out to a web
4034 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
4035 make this work cleanly
4037 2005-08-03 Brian Warner <warner@lothar.com>
4039 * buildbot/trybuild.py: new file for 'try' utilities
4040 (getSourceStamp): run in a tree, find out the baserev+patch
4041 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
4042 implemented for SVN and Darcs, still working on Arch. I don't know
4043 how to make CVS work yet.
4045 * docs/buildbot.texinfo: document the 'buildbot' command-line
4046 tool, including the not-yet-implemented 'try' feature, and the
4047 in-flux .buildbot/ options directory.
4049 2005-07-20 Brian Warner <warner@lothar.com>
4051 * buildbot/locks.py: added temporary id() numbers to Lock
4052 descriptions, to track down a not-really-sharing-the-Lock bug
4054 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
4056 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
4057 needed for python2.2 compatibility
4058 * buildbot/test/test_vc.py: python2.2 compatibility: generators
4059 are from the __future__
4061 2005-07-19 Brian Warner <warner@lothar.com>
4063 * buildbot/master.py (BuildMaster.loadConfig): give a better error
4064 message when schedulers use unknown builders
4066 * buildbot/process/builder.py (Builder.compareToSetup): make sure
4067 SlaveLock('name') and MasterLock('name') are distinct
4069 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
4070 c['schedulers'] in such a way that we can actually accept
4072 * buildbot/test/test_config.py: check it
4074 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
4075 utility method to *all* the Schedulers
4076 (Periodic.listBuilderNames): same
4078 * docs/buildbot.texinfo (Interlocks): update chapter to match
4081 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
4082 to make sure that c['sources'], c['schedulers'], and c['status']
4083 are all lists of the appropriate objects, and that the Schedulers
4084 all point to real Builders
4085 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
4086 'listBuilderNames' utility method to support this
4087 * buildbot/scheduler.py: implement the utility method
4088 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
4090 * docs/buildbot.texinfo: add some @cindex entries
4092 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
4093 if it wasn't already set: most tla commands will fail unless one
4095 (Arch.createRepository): and disable bazaar's revision cache, since
4096 they cause test failures (the multiple repositories we create all
4097 interfere with each other through the cache)
4099 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
4100 bring it properly up to date with twisted-2.0 test guidelines
4102 * buildbot/master.py (BuildMaster): remove references to old
4103 'interlock' module, this caused a bunch of post-merge test
4105 * buildbot/test/test_config.py: same
4106 * buildbot/process/base.py (Build): same
4108 * buildbot/test/test_slaves.py: stubs for new test case
4110 * buildbot/scheduler.py: add test-case-name tag
4111 * buildbot/test/test_buildreq.py: same
4113 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
4114 unnecessary init code
4115 (Bot.remote_setBuilderList): match it
4117 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
4119 * buildbot/changes/mail.py (parseSyncmail): update comment
4121 * buildbot/test/test_slavecommand.py: disable Shell tests on
4122 platforms that don't suport IReactorProcess
4124 * buildbot/status/builder.py (LogFile): remove the 't' mode from
4125 all places where we open logfiles. It causes OS-X to open the file
4126 in some weird mode that that prevents us from mixing reads and
4127 writes to the same filehandle, which we depend upon to implement
4128 _generateChunks properly. This change doesn't appear to break
4129 win32, on which "b" and "t" are treated differently but a missing
4130 flag seems to be interpreted as "t".
4132 2005-07-18 Brian Warner <warner@lothar.com>
4134 * buildbot/slave/commands.py (ShellCommand): overhaul
4135 error-handling code, to try and make timeout/interrupt work
4136 properly, and make win32 happier
4137 * buildbot/test/test_slavecommand.py: clean up, stop using
4138 reactor.iterate, add tests for timeout and interrupt
4139 * buildbot/test/sleep.py: utility for a new timeout test
4141 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
4142 code from the local-usebranches branch
4144 2005-07-17 Brian Warner <warner@lothar.com>
4146 * buildbot/process/process_twisted.py
4147 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
4148 minutes, to match the other twisted BuildFactories, and don't
4149 excuse failures in c/qt/win32 reactors any more.
4151 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
4152 'freebsd' builders, since the buildslaves have been unavailable
4155 2005-07-13 Brian Warner <warner@lothar.com>
4157 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
4158 build-on-branch feature
4160 * buildbot/process/step.py (Darcs.__init__): add base_url and
4161 default_branch arguments, just like SVN
4162 (Arch.__init__): note that the version= argument is really the
4165 * buildbot/slave/commands.py (SourceBase): keep track of the
4166 repository+branch that was used for the last checkout in
4167 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
4168 match, we clobber the directory and perform a fresh checkout
4169 rather than trying to do an in-place update. This should protect
4170 us against trying to get to branch B by doing an update in a tree
4171 obtained from branch A.
4172 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
4173 (SVN.setup): same, just the svnurl
4174 (Darcs.setup): same, just the repourl
4175 (Arch.setup): same, arch coordinates (url), version, and
4176 buildconfig. Also pull the buildconfig from the args dictionary,
4177 which we weren't doing before, so the build-config was effectively
4179 (Arch.sourcedirIsUpdateable): don't try to update when we're
4180 moving to a specific revision: arch can't go backwards, so it is
4181 safer to just clobber the tree and checkout a new one at the
4183 (Bazaar.setup): same sourcedata as Arch
4185 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
4186 use maybeWait, to work with twisted-1.3.0 and twcompat
4187 (Dependencies.testRun_Pass): same
4189 * buildbot/test/test_vc.py: rearrange, cleanup
4191 * buildbot/twcompat.py: add defer.waitForDeferred and
4192 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
4193 can work under twisted-1.3.0 .
4195 * buildbot/test/test_vc.py: rewrite. The sample repositories are
4196 now created at setUp time. This increases the runtime of the test
4197 suite considerably (from 91 seconds to 151), but it removes the
4198 need for an offline tarball, which should solve a problem I've
4199 seen where the test host has a different version of svn than the
4200 tarball build host. The new code also validates that mode=update
4201 really picks up recent commits. This approach will also make it
4202 easier to test out branches, because the code which creates the VC
4203 branches is next to the code which uses them. It will also make it
4204 possible to test some change-notification hooks, by actually
4205 performing a VC commit and watching to see the ChangeSource get
4208 2005-07-12 Brian Warner <warner@lothar.com>
4210 * docs/buildbot.texinfo (SVN): add branches example
4211 * docs/Makefile (buildbot.ps): add target for postscript manual
4213 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
4214 * buildbot/test/test_locks.py: same
4216 * buildbot/process/step.py (Darcs): comment about default branches
4218 * buildbot/master.py (BuildMaster.loadConfig): don't look for
4219 c['interlocks'] in the config file, complain if it is present.
4220 Scan all locks in c['builders'] to make sure the Locks they use
4222 * buildbot/test/test_config.py: remove old c['interlocks'] test,
4223 add some tests to check for non-uniquely-named Locks
4224 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
4225 since the unique-Lock validation code requires it now
4227 * buildbot/locks.py: fix test-case-name
4229 * buildbot/interlock.py: remove old file
4231 2005-07-11 Brian Warner <warner@lothar.com>
4233 * buildbot/test/test_interlock.py: rename to..
4234 * buildbot/test/test_locks.py: .. something shorter
4236 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
4237 versions (after 2.0.1) changed internet.TCPClient to shut down the
4238 connection in stopService. Change the code to handle this
4241 * buildbot/process/base.py (Build): handle whole-Build locks
4242 * buildbot/process/builder.py (Builder.compareToSetup): same
4243 * buildbot/test/test_interlock.py: make tests work
4245 * buildbot/process/step.py (BuildStep.startStep): complain if a
4246 Step tries to claim a lock that's owned by its own Build
4247 (BuildStep.releaseLocks): typo
4249 * buildbot/locks.py (MasterLock): use ComparableMixin so config
4250 file reloads don't replace unchanged Builders
4252 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
4253 rewrite to cover new Locks instead of old c['interlocks']
4254 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
4258 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
4259 start the master and connect the buildslave
4261 * buildbot/process/step.py (FailingDummy.done): finish with a
4262 FAILURE status rather than raising an exception
4264 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
4265 stringify a BuildRequest.reason that is None
4267 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
4269 * buildbot/status/builder.py (BuildSetStatus): implement enough to
4270 allow scheduler.Dependent to work
4271 * buildbot/buildset.py (BuildSet): set .reason and .results
4273 * buildbot/test/test_interlock.py (Locks.setUp): connect both
4274 slaves, to make the test stop hanging. It still fails, of course,
4275 because I haven't even started to implement Locks.
4277 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
4279 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
4280 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
4281 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
4282 (Dependent): new class for downstream build dependencies
4283 * buildbot/test/test_dependencies.py: tests (still failing)
4285 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
4287 2005-07-07 Brian Warner <warner@lothar.com>
4289 * buildbot/test/runutils.py (RunMixin): factored this class out..
4290 * buildbot/test/test_run.py: .. from here
4291 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
4292 added new buildbot.locks tests (which all hang right now)
4293 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
4294 * buildbot/process/step.py: claim/release per-BuildStep locks
4296 * docs/Makefile: add 'buildbot.html' target
4298 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
4299 interpreted as "HEAD", so that all VC steps can accept branch=None
4300 and have it mean the "default branch".
4302 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
4304 2005-07-07 Brian Warner <warner@lothar.com>
4306 * docs/examples/twisted_master.cfg: update to match current usage
4308 * docs/buildbot.texinfo (System Architecture): comment out the
4309 image, it doesn't exist yet and just screws up the HTML manual.
4311 2005-07-05 Brian Warner <warner@lothar.com>
4313 * debian/.cvsignore: oops, missed one. Removing leftover file.
4315 2005-06-17 Brian Warner <warner@lothar.com>
4317 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
4318 changed its output in 1.2.0, don't mistakenly think that the
4319 subversion we find isn't capable of supporting our tests.
4321 * debian/*: remove the debian/ directory and its contents, to make
4322 life easier for the proper Debian maintainer
4324 * Makefile (release): same
4326 2005-06-07 Brian Warner <warner@lothar.com>
4328 * everything: create a distinct SourceStamp class to replace the
4329 ungainly 4-tuple, let it handle merging instead of BuildRequest.
4330 Changed the signature of Source.startVC to include the revision
4331 information (instead of passing it through self.args). Implement
4332 branches for SVN (now only Darcs/Git is missing support). Add more
4335 2005-06-06 Brian Warner <warner@lothar.com>
4337 * everything: rearrange build scheduling. Create a new Scheduler
4338 object (configured in c['schedulers'], which submit BuildSets to a
4339 set of Builders. Builders can now use multiple slaves. Builds can
4340 be run on alternate branches, either requested manually or driven
4341 by changes. This changed some of the Status classes. Interlocks
4342 are out of service until they've been properly split into Locks
4343 and Dependencies. treeStableTimer, isFileImportant, and
4344 periodicBuild have all been moved from the Builder to the
4346 (BuilderStatus.currentBigState): removed the 'waiting' and
4347 'interlocked' states, removed the 'ETA' argument.
4349 2005-05-24 Brian Warner <warner@lothar.com>
4351 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
4352 erroneously abandons the connection (in clientConnectionFailed)
4353 for non-UserErrors, which means that if we lose the connection due
4354 to a network problem or a timeout, we'll never try to reconnect.
4355 Fix this by not upcalling to the buggy parent method. Note:
4356 twisted-2.0 fixes this, but the function only has 3 lines so it
4357 makes more sense to copy it than to try and detect the buggyness
4358 of the parent class. Fixes SF#1207588.
4360 * buildbot/changes/changes.py (Change.branch): doh! Add a
4361 class-level attribute to accomodate old Change instances that were
4362 pickled before 0.6.5 (where .branch was added for new Changes).
4363 This fixes the exception that occurs when you try to look at an
4364 old Change (through asHTML).
4366 * buildbot/__init__.py (version): bump to 0.6.6+ while between
4369 2005-05-23 Brian Warner <warner@lothar.com>
4371 * buildbot/__init__.py (version): release 0.6.6
4373 2005-05-23 Brian Warner <warner@lothar.com>
4375 * NEWS: update for 0.6.6 release
4376 * debian/changelog: same
4378 * buildbot/scripts/runner.py (start): put the basedir in sys.path
4379 before starting: this was done by twistd back when we spawned it,
4380 now that we're importing the pieces and running them in the
4381 current process, we have to do it ourselves. This allows
4382 master.cfg to import files from the same directory without
4383 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
4384 Stichele for the catch.
4385 (Options.opt_version): Add a --version command (actually, just make
4386 the existing --version command emit Buildbot's version too)
4388 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
4389 fix to make this behave like other LogFiles, this time to handle
4390 existing LogFiles on disk. (add the missing .upgrade method)
4391 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
4393 2005-05-21 Brian Warner <warner@lothar.com>
4395 * buildbot/test/test_runner.py (Create.testMaster): match the
4396 rawstring change in runner.py:masterTAC
4398 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
4399 TwistedWords is installed
4400 * buildbot/test/test_status.py: same, with TwistedMail
4402 * buildbot/master.py: remove old IRC/Waterfall imports (used by
4403 some old, deprecated, and removed config keys). This should enable
4404 you to use the base buildbot functionality with Twisted-2.0.0 when
4405 you don't also have TwistedWeb and TwistedWords installed
4407 2005-05-20 Brian Warner <warner@lothar.com>
4409 * buildbot/scripts/runner.py (run): call sendchange(), not
4410 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
4411 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
4412 (stop): don't wait for process to die when sending SIGHUP
4413 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
4414 directory name gets interpreted, which you don't want
4417 * buildbot/__init__.py (version): bump to 0.6.5+ while between
4420 2005-05-18 Brian Warner <warner@lothar.com>
4422 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
4424 2005-05-18 Brian Warner <warner@lothar.com>
4426 * README: update for 0.6.5
4427 * debian/changelog: same
4429 * buildbot/changes/changes.py: rename tag= to branch=, since
4430 that's how we're using it, and my design for the upcoming "build a
4431 specific branch" feature wants it. also, tag= was too CVS-centric
4432 * buildbot/changes/mail.py (parseSyncmail): same
4433 * buildbot/process/base.py (Build.isBranchImportant): same
4434 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
4435 * docs/buildbot.texinfo (Attributes of Changes): same
4437 * NEWS: update tag=, update for upcoming release
4439 2005-05-17 Brian Warner <warner@lothar.com>
4441 * buildbot/scripts/runner.py (stop): actually poll once per
4442 second, instead of re-killing the poor daemon once per second.
4443 Sleep briefly (0.1s) before the first poll, since there's a good
4444 chance we can avoid waiting the full second if the daemon shuts
4445 down quickly. Also remove the sys.exit() at the end.
4446 (start): remove the unneighborly sys.exit()
4448 * Makefile: improve permission-setting to not kick Arch so badly
4450 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
4451 default --keepalive=600, since it doesn't hurt very much, and it's
4452 a hassle to discover that you need it.
4453 * buildbot/test/test_runner.py (Create.testSlave): test it
4455 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
4456 IRC bot about EXCEPTION
4458 * buildbot/status/client.py (PBListener): upcall more correctly
4460 * buildbot/process/base.py (Build.allStepsDone): if a step caused
4461 an exception mark the overall build with EXCEPTION, not SUCCESS
4463 * buildbot/scripts/runner.py (makefile_sample): remove the leading
4465 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
4466 * Makefile: update some release-related stuff
4468 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
4469 gets called when there isn't actually an active process, just end
4470 the Command instead of blowing up. I don't know how it gets into
4471 this state, but the twisted win32 buildslave will sometimes hang,
4472 and when it shakes its head and comes back, it thinks it's still
4473 running a Command. The next build causes this command to be
4474 interrupted, but the lack of self.process.pid breaks the interrupt
4477 * NEWS: document changes since the last release
4479 * buildbot/scripts/runner.py (start): change 'buildbot start' to
4480 look for Makefile.buildbot instead of a bare Makefile . The
4481 'buildbot start' does not install this file, so you have to
4482 manually copy it if you want to customize startup behavior.
4483 (createMaster): change 'buildbot master' command to create
4484 Makefile.sample instead of Makefile, to create master.cfg.sample
4485 instead of master.cfg (requiring you to copy it before the
4486 buildmaster can be started). Both sample files are kept up to
4487 date, i.e. they are overwritten if they have been changed. The
4488 'buildbot.tac' file is *not* overwritten, but if the new contents
4489 don't match the old, a 'buildbot.tac.new' file is created and the
4490 user is warned. This seems to be a much more sane way to handle
4491 startup files. Also, don't sys.exit(0) when done, so we can run
4492 unit tests against it.
4493 (createSlave): same. Don't overwrite the sample info/ files.
4494 * buildbot/scripts/sample.mk: remove. the contents were pulled
4495 into runner.py, since they need to match the behavior of start()
4499 * docs/buildbot.texinfo (Launching the daemons): document it
4500 * buildbot/test/test_runner.py (Create): test it
4502 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
4503 version that can handle string-in-string tests, because otherwise
4504 python-2.2 fails the tests. It'd be tremendous if Trial's test
4505 took two strings under 2.2 too.
4507 * everything: fixed all deprecation warnings when running against
4508 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4509 few that come from Twisted itself). This involved putting most of
4510 the Twisted-version specific code in the new buildbot.twcompat
4511 module, and creating some abstract base classes in
4512 buildbot.changes.base and buildbot.status.base (which might be
4513 useful anyway). __implements__ is a nuisance and requires an ugly
4514 'if' clause everywhere.
4516 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4517 delay before finishing the test: it seems that smtp.sendmail
4518 doesn't hang up on the server, so we must wait a moment so it can
4519 hang up on us. This removes the trial warning about an unclean
4522 2005-05-16 Brian Warner <warner@lothar.com>
4524 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4525 tuple of (delay, repeats).
4526 * buildbot/test/test_vc.py (Retry): test it
4527 * docs/buildbot.texinfo (Source Checkout): document it
4528 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4529 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4530 doVCFull() are handled by re-trying the checkout (after a delay)
4531 some number of times.
4532 (ShellCommand._startCommand): make header lines easier to read
4534 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4536 (WebTest.test_logfile): make sure master gets shut down, silences
4537 some "unclean reactor" test errors
4539 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4540 reactor once after shutdown, something in certain versions of
4541 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4542 fails, svn-trunk is ok.
4544 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4545 second win32 error message
4547 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4548 validating the ETA, so the tests don't fail on slow systems
4550 2005-05-15 Brian Warner <warner@lothar.com>
4552 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4553 the new LogFile class, so upgrading works properly
4554 (LogFileProducer.resumeProducing): survive resumeProducing after
4555 we've exhausted the chunkGenerator
4557 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4559 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4560 (Log.testUpgrade): same
4562 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4563 Builds and logs with a cron job.
4565 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4566 of the old non-offline LogFile, added code to upgrade these to
4567 new-style contents-live-on-disk instances at load time (in a way
4568 that doesn't invalidate the old Build pickles, so upgrading to
4569 0.6.5 is not a one-way operation). Got rid of everything related
4571 (LogFile.__init__): create LogFiles with the parent step status,
4572 the log's name, and a builder-relative filename where it can keep
4573 the contents on disk.
4574 (LogFile.hasContents): new method, clients are advised to call it
4575 before getText or getChunks and friends. If it returns False, the
4576 log's contents have been deleted and getText() will raise an
4578 (LogFile.getChunks): made it a generator
4579 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4580 Consumer (except one that takes chunks instead of strings). This
4581 enables streaming of very large logfiles without storing the whole
4583 (BuildStatus.generateLogfileName): create names like
4584 12-log-compile-output, with a _0 suffix if required to be unique
4585 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4586 or earlier) logfiles into new-style ones
4587 (BuilderStatus): remove everything related to 'stub' builds. There
4588 is now only one build cache, and we don't strip logs from old
4590 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4591 since we no longer fight to keep it in the cache
4593 * buildbot/status/html.py (TextLog.render_GET): use a
4594 ChunkConsumer to stream the log entries efficiently.
4595 (ChunkConsumer): wrapper which consumes chunks and writes
4598 * buildbot/test/test_twisted.py (Parse.testParse): use a
4599 LogFile-like object instead of a real one
4601 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4602 (Log.testMerge3): validate more merge behavior
4603 (Log.testChunks): validate LogFile.getChunks
4604 (Log.testUpgrade): validate old-style LogFile upgrading
4605 (Log.testSubscribe): validate LogFile.subscribe
4606 (Log.testConsumer): validate LogFile.subscribeConsumer
4608 * buildbot/interfaces.py (IStatusLogStub): remove
4609 (IStatusLog.subscribeConsumer): new method
4610 (IStatusLog.hasContents): new method
4611 (IStatusLogConsumer): describes things passed to subscribeConsumer
4613 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4614 the log contents if it does not have any contents.
4615 (StatusResourceBuildStep.body): same
4616 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4618 2005-05-14 Brian Warner <warner@lothar.com>
4620 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4621 timeouts to try and make the windows metabuildslave not hang
4623 2005-05-13 Mike Taylor <bear@code-bear.com>
4625 * buildbot/slave/commands.py (rmdirRecursive): added a check
4626 to ensure the path passed into rmdirRecursive actually exists.
4627 On win32 a non-existant path would generate an exception.
4629 2005-05-13 Brian Warner <warner@lothar.com>
4631 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4632 shutil.rmtree which behaves correctly on windows in the face of
4633 files that you have to chmod before deleting. Thanks to Bear at
4634 the OSAF for the routine.
4635 (SourceBase.doClobber): use rmdirRecursive
4637 2005-05-12 Brian Warner <warner@lothar.com>
4639 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4640 method generate chunks instead of returning a big list. This
4641 allows the same method to be used for both old LogFile and new
4643 (OfflineLogFile.getText): use the generator
4644 (OfflineLogFile.subscribe): same
4645 * buildbot/status/html.py (TextLog.resumeProducing): same
4646 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4648 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4649 point out that OfflineLogFile does not currently work with
4650 html.Waterfall . Fixing this is high-priority.
4652 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4653 apparently windows defaults to using stdout
4655 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4656 better message on failure so I can figure out the win32 problem
4658 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4659 log messages to include more useful copies of the command being
4660 run, the argv array, and the child command's environment.
4661 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4663 2005-05-11 Brian Warner <warner@lothar.com>
4665 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4667 * Makefile: update the deb-snapshot version
4669 * docs/buildbot.texinfo: move all .xhtml docs into a new
4670 .texinfo-format document, adding a lot of material in the process.
4671 This is starting to look like a real user's manual. Removed all
4672 the Lore-related files: *.xhtml, *.css, template.tpl .
4673 * docs/Makefile: simple makefile to run 'makeinfo'
4674 * buildbot/scripts/sample.cfg: rearrange slightly
4675 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4677 2005-05-10 Brian Warner <warner@lothar.com>
4679 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4680 different name for the internal twistw module, handle it.
4682 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4683 * setup.py: .. and stop trying to install it
4685 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4686 'git'), the new linux kernel VC system (http://kernel.org/git/).
4687 Thanks to Brandon Philips for the patch.
4688 * buildbot/slave/commands.py (Git): same
4690 2005-05-06 Brian Warner <warner@lothar.com>
4692 * buildbot/status/builder.py (OfflineLogFile): replace the default
4693 LogFile with a form that appends its new contents to a disk file
4694 as they arrive. The complete log data is never kept in RAM. This
4695 is the first step towards handling very large (100MB+) logfiles
4696 without choking quite so badly. (The other half is
4697 producer/consumer on the HTML pages).
4698 (BuildStepStatus.addLog): use OfflineLogFile by default
4699 (BuildStatus.getLogfileName): helper code to give the
4700 OfflineLogFile a filename to work with
4702 * buildbot/test/test_status.py (Results.testAddResults): update
4703 tests to handle new asserts
4704 * buildbot/test/test_vc.py (Patch.doPatch): same
4705 * buildbot/test/test_steps.py (BuildStep.setUp): same
4707 2005-05-05 Brian Warner <warner@lothar.com>
4709 * buildbot/scripts/runner.py (start): if there is no Makefile,
4710 launch the app by importing twistd's internals and calling run(),
4711 rather than spawning a new twistd process. This stands a much
4712 better chance of working under windows.
4713 (stop): kill the process with os.kill instead of spawning
4714 /bin/kill, again to reduce the number of external programs which
4715 windows might not have in the PATH. Also wait up to 5 seconds for
4716 the process to go away, allowing things like 'buildbot stop;
4717 buildbot start' to be reliable in the face of slow shutdowns.
4719 * buildbot/master.py (Dispatcher.__getstate__): remove old
4720 .tap-related methods
4721 (BuildMaster.__getstate__): same
4723 * buildbot/slave/bot.py (makeService): same
4724 (Options.longdesc): same
4725 * buildbot/scripts/runner.py: copy over some old mktap option text
4727 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4728 'buildbot master' now creates a buildbot.tac file, so there is no
4729 longer a create-instance/save/reload sequence. mktap is dead, long
4731 * buildbot/scripts/sample.mk: use twistd -y, not -f
4732 * buildbot/test/test_config.py: remove mktap-based test
4733 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4734 * README: don't reference mktap
4736 * docs/source.xhtml: document some of the attributes that Changes
4739 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4741 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4742 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4743 * buildbot/changes/changes.py (Change)
4744 * buildbot/changes/mail.py (parseSyncmail)
4745 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4747 * buildbot/process/base.py (Build.isTagImportant)
4751 2005-05-04 Brian Warner <warner@lothar.com>
4753 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4754 connection after sending the change, so that unit tests don't
4755 complain about sockets being left around
4757 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4758 exception in phase=0 rendering
4759 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4761 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4763 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4764 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4765 and configuring builders with tuples.
4766 * buildbot/test/test_config.py: stop testing compatibility with
4767 deprecated config keys
4768 * buildbot/test/test_run.py: same
4770 2005-05-03 Brian Warner <warner@lothar.com>
4772 * contrib/arch_buildbot.py: survive if there are no logfiles
4773 (username): just use a string, os.getlogin isn't reliable
4775 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4776 so 'buildbot sendchange' actually works. The earlier test only
4777 covered the internal (non-reactor-running) form.
4779 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4780 script to notify the buildmaster about changes
4782 * buildbot/scripts/runner.py (sendchange): new command to send a
4783 change to a buildbot.changes.pb.PBChangeSource receiver.
4784 * buildbot/test/test_changes.py (Sender): test it
4786 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4787 after any reading of the config file, not just when we do it in
4788 startService. This makes some tests a bit cleaner.
4790 * buildbot/changes/pb.py: add some log messages
4792 * buildbot/process/base.py (Build.startBuild): fix a bug that
4793 caused an exception when the build terminated in the very first
4795 (Build.stepDone): let steps return a status of EXCEPTION. This
4796 terminates the build right away, and sets the build's overall
4797 status to EXCEPTION too.
4798 * buildbot/process/step.py (BuildStep.failed): return a status of
4799 EXCEPTION when that is what has happened.
4801 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4802 implement this, allowing Arch-based projects to get precise
4803 checkouts instead of always using the latest code
4804 (Bazaar): create variant of Arch to let folks use baz instead of
4805 tla. Requires a new buildslave too.
4806 * buildbot/slave/commands.py (Arch): add 'revision' argument
4807 (Bazaar): create variant of Arch that uses baz instead of tla.
4808 Remove the code that extracts the archive name from the
4809 register-archive output, since baz doesn't provide it, and require
4810 the user provide both the archive name and its location.
4811 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4813 2005-05-02 Brian Warner <warner@lothar.com>
4815 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4816 thanks to Nick Trout.
4818 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4819 deals better with source Makefile coming from a read-only CVS
4820 checkout. Thanks to Nick Trout for the catch.
4822 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4825 2005-04-28 Brian Warner <warner@lothar.com>
4827 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4829 * debian/changelog: update for 0.6.4
4831 2005-04-28 Brian Warner <warner@lothar.com>
4833 * README.w32: add a checklist of steps for getting buildbot
4835 * MANIFEST.in: include it in the tarball
4839 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4840 broken .tap files from 0.6.3 by getting rid of .services,
4841 .namedServices, and .change_svc at load time.
4843 2005-04-27 Brian Warner <warner@lothar.com>
4845 * NEWS: update in preparation for new release
4847 * buildbot/test/test_config.py (Save.testSave): don't pull in
4848 twisted.scripts.twistd, we don't need it and it isn't for windows
4851 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4852 accomodate win32 which can't do atomic-rename
4854 2005-04-27 Brian Warner <warner@lothar.com>
4856 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4857 timeouts to help the slow metabuildbot not flunk them so much
4858 (Disconnect.testBuild3): same
4859 (Disconnect.testBuild4): same
4860 (Disconnect.testInterrupt): same
4862 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4863 setup, it was completely broken for new buildmasters (those which
4864 did not have a 'change.pck' already saved. Thanks to Paul Warren
4865 for catching this (embarrassing!) bug.
4866 (Dispatcher.__getstate__): don't save our registered avatar
4867 factories, since they'll be re-populated when the config file is
4869 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4870 tests (since the real mktap-generated BuildMaster doesn't save
4872 (BuildMaster.__getstate__): don't save any service children,
4873 they'll all be re-populated when the config file is re-read.
4874 * buildbot/test/test_config.py (Save.testSave): test for this
4876 2005-04-26 Brian Warner <warner@lothar.com>
4878 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4879 rendered with Blender.. looks a bit nicer.
4880 * buildbot/docs/images/icon.blend: add the Blender file for it
4882 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4883 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4884 running under windows. This appears to be the best way to allow
4885 BuildSteps to do something normal like 'trial -v buildbot.test' or
4886 'make foo' and still expect it to work. The idea is to make the
4887 BuildSteps look as much like what a developer would type when
4888 compiling or testing the tree by hand. This approach probably has
4889 problems when there are spaces in the arguments, so if you've got
4890 windows buildslaves, you'll need to pay close attention to your
4893 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4894 timezone to the timestamp column.
4895 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4897 * buildbot/scripts/runner.py (loadOptions): do something sane for
4898 windows, I think. We use %APPDATA%/buildbot instead of
4899 ~/.buildbot, but we still search everywhere from the current
4900 directory up to the root for a .buildbot/ subdir. The "is it under
4901 $HOME" security test was replaced with "is it owned by the current
4902 user", which is only performed under posix.
4903 * buildbot/test/test_runner.py (Options.testFindOptions): update
4904 tests to match. The "is it owned by the current user" check is
4905 untested. The test has been re-enabled for windows.
4907 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4908 any "\n" in the expected output with the platform-specific line
4909 separator. Make this separator "\r\n" on PTYs under unix, they
4910 seem to do that and I don't know why
4912 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4913 windows for now, I don't know what ~/.buildbot/ should mean there.
4915 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4916 win32 compatibility, don't use "/tmp"
4917 (Basedir.testChangeBuilddir): remove more unixisms
4919 2005-04-26 Brian Warner <warner@lothar.com>
4921 * buildbot/test/test_control.py (Force.rmtree): python2.2
4922 compatibility, apparently its shutil.rmtree ignore_errors=
4923 argument is ignored.
4924 * buildbot/test/test_run.py (Run.rmtree): same
4925 (RunMixin.setUp): same
4927 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4930 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4931 'substring in string' operator, must use string.find(substr)!=-1
4932 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4933 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4935 * buildbot/scripts/runner.py (loadOptions): add code to search for
4936 ~/.buildbot/, a directory with things like 'options', containing
4937 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4938 the current directory, your $HOME directory, or anywhere
4939 inbetween, as long as you're somewhere inside your home directory.
4940 (debugclient): look in ~/.buildbot/options for master and passwd
4941 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4942 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4944 * buildbot/status/client.py (makeRemote): new approach to making
4945 IRemote(None) be None, which works under Twisted-2.0
4946 * buildbot/test/test_status.py (Client.testAdaptation): test it
4948 * buildbot/status/builder.py (Status.builderAdded): when loading a
4949 pickled BuilderStatus in from disk, set its name after loading.
4950 The config file might have changed its name (but not its
4951 directory) while it wasn't looking.
4953 * buildbot/process/builder.py (Builder.attached): always return a
4954 Deferred, even if the builder was already attached
4955 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4957 2005-04-25 Brian Warner <warner@lothar.com>
4959 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4960 category-related exception when announcing a build has finished
4962 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4963 reference no-longer-existent changemaster.sources
4964 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4966 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4969 2005-04-25 Brian Warner <warner@lothar.com>
4971 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4973 * debian/changelog: update for 0.6.3
4975 2005-04-25 Brian Warner <warner@lothar.com>
4977 * MANIFEST.in: make sure debug.glade is in the tarball
4979 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4981 * NEWS: update for the imminent 0.6.3 release
4983 * buildbot/status/html.py (HtmlResource.content): make the
4984 stylesheet <link> always point at "buildbot.css".
4985 (StatusResource.getChild): map "buildbot.css" to a static.File
4986 containing whatever css= argument was provided to Waterfall()
4987 (Waterfall): provide the "classic" css as the default.
4988 * docs/waterfall.classic.css: move default CSS from here ..
4989 * buildbot/status/classic.css: .. to here
4991 * MANIFEST.in: make sure classic.css is included in the tarball
4992 * setup.py: and that it is installed too, under buildbot/status/
4994 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4995 the module level, because buildbot.tap files from 0.6.2 don't have
4996 it in their attribute dictionary.
4998 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4999 really exists at startup, might save some confusion somewhere.
5001 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
5003 * docs/waterfall.classic.css:
5004 add a stylesheet that's almost the same as the "classic"
5007 * buildbot/status/builder.py:
5008 add EXCEPTION as a result - this is a problem for the bot
5009 maintainer, not a build problem for the changers
5010 * buildbot/process/step.py:
5011 use EXCEPTION instead of FAILURE for exceptions
5012 * buildbot/status/html.py:
5013 add build_get_class to get a class out of a build/buildstep
5014 finish naming the classes
5015 split out sourceNames to changeNames and builderNames so we
5016 can style them separately
5017 * docs/config.xhtml:
5018 finish documenting classes as they are right now
5020 * buildbot/status/html.py:
5021 name the classes as we agreed on IRC
5022 * docs/config.xhtml:
5025 * buildbot/status/html.py:
5026 same for cssclass->class_
5028 * buildbot/status/html.py:
5029 as decided on IRC, use class_ for the "class" attribute to not
5030 conflict with the class keyword, and clean up the messy **{} stuff.
5032 * buildbot/status/mail.py:
5033 put back "builders" argument, and fix docstring, because the
5034 code *ignores* builders listed in this argument
5036 * buildbot/process/builder.py:
5037 remove FIXME notes - category is now indeed a cvar of BuilderStatus
5039 * docs/config.xhtml:
5040 describe the category argument for builders
5042 * buildbot/status/builder.py:
5043 Fix a silly bug due to merging
5045 * buildbot/process/builder.py:
5046 remove category from the process Builder ...
5047 * buildbot/status/builder.py:
5048 ... and add it to BuilderStatus instead.
5049 Set category on unpickled builder statuses, they might not have it.
5050 * buildbot/master.py:
5051 include category when doing builderAdded
5052 * buildbot/status/mail.py:
5053 return None instead of self for builders we are not interested in.
5054 * buildbot/test/test_run.py:
5055 fix a bug due to only doing deferredResult on "dummy" waiting
5056 * buildbot/test/test_status.py:
5057 add checks for the Mail IStatusReceiver returning None or self
5059 * buildbot/status/html.py:
5060 fix testsuite by prefixing page title with BuildBot
5062 * buildbot/status/builder.py:
5063 have .category in builder status ...
5064 * buildbot/process/builder.py:
5065 ... and set it from Builder
5066 * buildbot/status/html.py:
5067 make .css a class variable
5068 * buildbot/test/test_status.py:
5069 write more tests to cover our categories stuff ...
5070 * buildbot/status/mail.py:
5071 ... and fix the bug that this uncovered
5073 * buildbot/changes/mail.py:
5074 * buildbot/changes/pb.py:
5075 * buildbot/master.py:
5076 * buildbot/process/base.py:
5077 * buildbot/process/factory.py:
5078 * buildbot/process/interlock.py:
5079 * buildbot/process/step.py:
5080 * buildbot/process/step_twisted.py:
5081 * buildbot/slave/commands.py:
5082 * buildbot/status/builder.py:
5083 * buildbot/status/client.py:
5084 * buildbot/status/html.py:
5085 * buildbot/status/mail.py:
5086 * buildbot/status/progress.py:
5087 * buildbot/test/test_changes.py:
5088 * buildbot/test/test_config.py:
5089 * buildbot/test/test_control.py:
5090 * buildbot/test/test_interlock.py:
5091 * buildbot/test/test_maildir.py:
5092 * buildbot/test/test_mailparse.py:
5093 * buildbot/test/test_run.py:
5094 * buildbot/test/test_slavecommand.py:
5095 * buildbot/test/test_status.py:
5096 * buildbot/test/test_steps.py:
5097 * buildbot/test/test_twisted.py:
5098 * buildbot/test/test_util.py:
5099 * buildbot/test/test_vc.py:
5100 * buildbot/test/test_web.py:
5102 add test-case-name at the top of a whole set of files
5104 * buildbot/status/builder.py:
5105 keep order of addition when getting builder names
5106 * buildbot/status/words.py:
5107 * buildbot/test/test_run.py:
5108 add test for getBuilderNames
5110 * buildbot/process/base.py:
5111 * buildbot/process/step.py:
5112 * buildbot/status/builder.py:
5113 * buildbot/status/html.py:
5114 make buildbot css-able
5115 replace the color code for purple with purple, don't understand
5116 why it wasn't purple to start with
5118 * buildbot/status/words.py:
5119 ok, so it doesn't look like BuilderStatus.remote is still valid.
5120 Use what waterfall uses instead.
5122 * buildbot/interfaces.py:
5123 * buildbot/status/builder.py:
5124 * buildbot/status/html.py:
5125 * buildbot/status/mail.py:
5126 * buildbot/status/words.py:
5127 * buildbot/test/test_run.py:
5128 use categories everywhere and make it be a list. More sensible
5129 for the future. Also make words actually respect this in
5132 * buildbot/interfaces.py:
5133 add category argument to getBuilderNames
5134 * buildbot/process/builder.py:
5135 * buildbot/status/builder.py:
5136 * buildbot/status/html.py:
5137 * buildbot/status/mail.py:
5138 * buildbot/status/words.py:
5139 * buildbot/test/test_run.py:
5140 move from specifying builders by name to specifying the category
5142 * buildbot/status/html.py:
5143 * buildbot/status/words.py:
5144 add "builders=" to __init__ of status clients so they can
5145 limit themselves to the given list of builders to report on
5147 * buildbot/status/html.py: set the title to the product name
5149 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
5151 * buildbot/interfaces.py:
5152 * buildbot/status/builder.py:
5153 more documentation. Hm, not sure if ChangeLog entries make sense
5156 2005-04-23 Brian Warner <warner@lothar.com>
5158 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
5160 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
5162 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
5163 the sub-commands that log buildmaster status to stdout and to a
5164 GUI window, respectively.
5166 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
5167 functionality is working again, but all the step-status and ETA
5168 stuff is missing. Commented out a lot of code pending more
5171 * buildbot/status/client.py: make sure that IRemote(None) is None
5173 * buildbot/changes/changes.py: import defer, oops
5174 (ChangeMaster): remove the .sources list, rely upon the fact that
5175 MultiServices can be treated as sequences of their children. This
5176 cleans up the add/remove ChangeSource routines a lot, as we keep
5177 exactly one list of the current sources instead of three.
5179 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
5180 up an empty ChangeMaster at init time.
5181 (BuildMaster.loadChanges): if there are changes to be had from
5182 disk, replace self.change_svc with the new ones. If not, keep
5183 using the empty ChangeMaster set up in __init__.
5184 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
5185 instead of a separate list, makes the code a bit cleaner.
5186 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
5187 (ConfigTest.testSources): same, also wait for loadConfig to finish.
5188 Extend the test to make sure we can get rid of the sources when
5191 2005-04-22 Brian Warner <warner@lothar.com>
5193 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
5194 and info/host files when making the slave directory
5196 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
5197 whendone= argument, just return the Deferred and let the caller do
5198 what they want with it.
5199 (Disconnect.testBuild1): wait for shutdownSlave
5200 (Basedir.testChangeBuilddir): new test to make sure changes to the
5201 builddir actually get propagated to the slave
5203 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
5204 explicit method, rather than passing the builddir in __init__ .
5205 Make sure to update self.basedir too, this was broken before.
5206 (Bot.remote_setBuilderList): use b.setBuilddir for both new
5207 builders and for ones that have just had their builddir changed.
5208 (BotFactory): add a class-level .perspective attribute, so
5209 BuildSlave.waitUntilDisconnected won't get upset when the
5210 connection hasn't yet been established
5211 (BuildSlave.__init__): keep track of the bot.Bot instance, so
5212 tests can reach through it to inspect the SlaveBuilders
5214 * buildbot/process/base.py (Build.buildException): explain the
5215 log.err with a log.msg
5216 * buildbot/process/builder.py (Builder.startBuild): same
5217 (Builder._startBuildFailed): improve error message
5219 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
5220 occurred because we lost the brand-new connection, retry instead
5221 of giving up. If not, it's probably an authorization failure, and
5222 it makes sense to stop trying. Make sure we log.msg the reason
5223 that we're log.err'ing the failure, otherwise test failures are
5224 really hard to figure out.
5226 * buildbot/master.py: change loadConfig() to return a Deferred
5227 that doesn't fire until the change has been fully implemented.
5228 This means any connected slaves have been updated with the new
5229 builddir. This change makes it easier to test the code which
5230 actually implements this builddir-updating.
5231 (BotPerspective.addBuilder): return Deferred
5232 (BotPerspective.removeBuilder): same
5233 (BotPerspective.attached): same
5234 (BotPerspective._attached): same. finish with remote_print before
5235 starting the getSlaveInfo, instead of doing them in parallel
5236 (BotPerspective.list_done): same
5237 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
5238 actually calling slave.disconnect()
5239 (BotMaster.addBuilder): same
5240 (BotMaster.removeBuilder): same
5241 (BuildMaster.loadConfig): same
5242 (BuildMaster.loadConfig_Slaves): same
5243 (BuildMaster.loadConfig_Sources): same
5244 (BuildMaster.loadConfig_Builders): same
5245 (BuildMaster.loadConfig_status): same
5247 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
5248 a Deferred that fires when the source is finally removed
5250 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
5251 the previous tree on win32, where we have to do it synchronously,
5252 make sure we return a Deferred anyway.
5253 (SourceBase.doCopy): same
5255 * buildbot/scripts/runner.py (statusgui): use the text client for
5256 now, while I rewrite the Gtk one
5257 * buildbot/clients/base.py: strip out old code, leaving just the
5258 basic print-message-on-event functionality. I also remove the
5259 ReconnectingPBClientFactory, but it does at least quit when it
5260 loses the connection instead of going silent
5262 2005-04-21 Brian Warner <warner@lothar.com>
5264 * Makefile: minor tweaks
5266 * NEWS: point out deprecation warnings, new features for
5269 * buildbot/master.py (BuildMaster.loadConfig): emit
5270 DeprecationWarnings for Builders defined with tuples. Rearrange
5271 code to facility removal of deprecated configuration keys in the
5274 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
5275 'buildbot' command to put a little Makefile in the target that
5276 helps you re-create the buildbot.tap file, start or stop the
5277 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
5278 all the files 0600, since they contain passwords.
5279 (start): if there is a Makefile, and /usr/bin/make exists, use
5280 'make start' in preference to a raw twistd command. This lets
5281 slave admins put things like PYTHONPATH variables in their
5282 Makefiles and have them still work when the slave is started with
5283 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
5284 be nice to first try the 'make' command and only fall back to
5285 twistd if it fails. TODO: the Makefile's "start" command does not
5286 add the --reactor=win32 argument when running under windows.
5287 (Options.debugclient, Options.statusgui): add sub-commands to launch
5288 the debug client (formerly in contrib/debugclient.py) and the
5289 Gtk status application (currently broken)
5290 * buildbot/clients/debug.py: move from contrib/debugclient.py
5291 * buildbot/clients/debug.glade: same
5293 * buildbot/test/test_trial.py: remove it. This requires some
5294 functionality out of Twisted that isn't there yet, and until then
5295 having it around just confuses things.
5297 * buildbot/test/test_slavecommand.py (Shell): test both with and
5298 without PTYs, and make sure that command output is properly
5299 interleaved in the with-PTY case. I think the without-PTY test
5300 should pass on windows, where we never use PTYs anyway.
5302 2005-04-20 Brian Warner <warner@lothar.com>
5304 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
5306 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
5308 * NEWS: start creating entries for the next release
5310 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
5312 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
5313 (WebTest.test_webPathname): same
5314 (WebTest.test_webPathname_port): same
5315 (WebTest.test_waterfall): use the default favicon rather than
5316 rooting around the filesystem for it. Open the expected-icon file
5317 in binary mode, to make win32 tests happier (thanks to Nick Trout
5319 * buildbot/status/html.py (buildbot_icon): win32 portability
5321 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
5322 win32-compatibility fixes from Nick Trout, the "file not found" message
5323 is different under windows
5324 (FakeSlaveBuilder.__init__): clean up setup a bit
5325 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
5327 2005-04-19 Brian Warner <warner@lothar.com>
5329 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
5330 skip-if-repositories-are-unavailable test to not kill the trial
5331 that comes with Twisted-1.3.0
5333 * setup.py: install buildbot.png icon file when installing code
5335 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
5336 environment used by the command, at least on the child side.
5338 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
5339 this method needs to be added and implemented because it gets
5340 called under heavy load. I don't quite understand the
5341 producer/consumer API enough to write it.
5342 (StatusResource.getChild): add a resource for /favicon.ico
5343 (Waterfall.__init__): add favicon= argument
5344 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
5345 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
5346 (WebTest.test_webPathname): same
5347 (WebTest.test_webPathname_port): same
5348 * docs/config.xhtml: mention favicon=
5349 * buildbot/buildbot.png: add a default icon, dorky as it is
5351 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
5353 * buildbot/master.py:
5354 * buildbot/process/base.py:
5355 * buildbot/process/builder.py:
5356 * buildbot/process/interlock.py:
5357 * buildbot/status/builder.py:
5358 * buildbot/status/html.py:
5359 * buildbot/status/mail.py:
5360 * buildbot/status/words.py:
5361 new documentation while digging through the code
5363 2005-04-17 Brian Warner <warner@lothar.com>
5365 * general: try to fix file modes on all .py files: a+r, a-x,
5366 but let buildbot/clients/*.py be +x since they're tools
5368 * docs/epyrun (addMod): when an import fails, say why
5370 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
5372 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5374 * buildbot/process/base.py:
5375 * buildbot/process/builder.py:
5376 * buildbot/status/builder.py:
5377 new documentation while digging through the code
5379 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5381 * buildbot/changes/changes.py:
5382 * buildbot/changes/p4poller.py:
5383 * buildbot/interfaces.py:
5384 * buildbot/process/base.py:
5385 * buildbot/process/builder.py:
5386 * buildbot/process/step.py:
5387 * buildbot/process/step_twisted.py:
5388 * buildbot/slave/bot.py:
5389 * buildbot/slave/commands.py:
5390 * buildbot/status/builder.py:
5391 fix all docstrings to make epydoc happy. In the process of fixing
5392 some, I also moved pieces of docs, and removed some deprecated
5395 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
5397 * buildbot/process/builder.py:
5398 * buildbot/process/interlock.py:
5399 * buildbot/process/process_twisted.py:
5400 * buildbot/process/step.py:
5401 BuildProcess -> Build, as it looks like that's what happened
5402 * buildbot/process/base.py:
5403 * buildbot/process/factory.py:
5406 2005-04-17 Brian Warner <warner@lothar.com>
5408 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5409 update compile command to accomodate the Twisted split.. now
5410 instead of './setup.py build_ext -i', you do './setup.py all
5411 build_ext -i', to run build_ext over all sub-projects.
5412 (FullTwistedBuildFactory): same
5413 (TwistedReactorsBuildFactory): same
5415 * buildbot/status/html.py (TextLog.finished): null out self.req
5416 when we're done, otherwise the reference cycle of TextLog to .req
5417 to .notifications to a Deferred to TextLog.stop keeps them from
5418 being collected, and consumes a huge (610MB on pyramid at last
5419 check) amount of memory.
5421 2005-04-11 Brian Warner <warner@lothar.com>
5423 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
5424 normalize the VC-repository location.. makes SVN happier with
5425 certain test environments.
5427 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
5428 RemoteShellCommand gets its own .env dictionary, so that code in
5429 start() doesn't mutate the original. I think this should fix the
5430 step_twisted.Trial problem where multiple identical components
5431 kept getting added to PYTHONPATH= over and over again.
5433 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
5434 adding epydoc-format docstrings to many classes. Thanks to Thomas
5435 Vander Stichele for the patches.
5436 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
5437 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
5438 * buildbot/slave/bot.py, commands.py, registry.py: same
5440 2005-04-05 Brian Warner <warner@lothar.com>
5442 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
5443 preserve timestamps, helps incremental builds of large trees.
5444 Patch from Rene Rivera.
5446 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
5447 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
5450 2005-04-03 Brian Warner <warner@lothar.com>
5452 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
5453 with one dict, apparently exec has some scoping bugs when used
5454 with both global/local dicts. Thanks to Nathaniel Smith for the
5457 2005-04-02 Brian Warner <warner@lothar.com>
5459 * buildbot/process/step_twisted.py (countFailedTests): the new
5460 trial in Twisted-2.0 emits a slightly different status line than
5461 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
5462 mistakenly think the test count is unparseable.
5463 (Trial.start): note that for some reason each build causes another
5464 copy of self.testpath to be prepended to PYTHONPATH. This needs to
5465 be fixed but I'm not sure quite where the problem is.
5467 2005-04-01 Brian Warner <warner@lothar.com>
5469 * buildbot/test/test_run.py (Run.testMaster): change some uses of
5470 deferredResult to avoid hangs/warnings under twisted-2.0
5471 (RunMixin.tearDown): same
5472 (RunMixin.shutdownSlave): same
5473 (Disconnect.testIdle1): same
5474 (Disconnect.testBuild2): same: wait one second after the build
5475 finishes for test to really be done.. this should be cleaned up to
5476 avoid wasting that second. Builder.detach uses a callLater(0),
5477 either that should be done in-line (something else needed that
5478 behavior), or it should return a Deferred that fires when the
5479 builder is really offline.
5480 (Disconnect.testBuild3): same
5481 (Disconnect.testDisappear): same
5483 * buildbot/test/test_web.py: rearrange server-setup and teardown
5484 code to remove unclean-reactor warnings from twisted-2.0
5486 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
5487 so the tests don't hang under twisted-2.0
5489 2005-03-31 Brian Warner <warner@lothar.com>
5491 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
5492 caused a warning each time the master changed our set of builders
5494 * buildbot/status/builder.py (BuildStatus.saveYourself): under
5495 w32, don't unlink the file unless it already exists. Thanks to
5496 Baptiste Lepilleur for the catch.
5497 (BuilderStatus.saveYourself): same
5499 2005-02-01 Brian Warner <warner@lothar.com>
5501 * buildbot/status/html.py (TextLog.getChild): use a /text child
5502 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
5503 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
5504 logfile as text/plain (no markup, no headers). This replaces the
5505 previous scheme (which used an ?text=1 argument), and gets us back
5506 to a relative link (which works better when the buildbot lives
5507 behind another web server, such as Apache configured as a reverse
5508 proxy). Thanks to Gerald Combs for spotting the problem.
5510 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5513 2004-12-13 Brian Warner <warner@lothar.com>
5515 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5517 * debian/changelog: update for 0.6.2
5518 * NEWS: finalize for 0.6.2
5520 2004-12-11 Brian Warner <warner@lothar.com>
5522 * NEWS: bring it up to date
5524 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5525 detection code. Require some sign of life from the buildmaster
5526 every BotFactory.keepaliveInterval seconds. Provoke this
5527 indication at BotFactory.keepaliveTimeout seconds before the
5528 deadline by sending a keepalive request. We don't actually care if
5529 that request is answered in a timely fashion, what we care about
5530 is that .activity() is called before the deadline. .activity() is
5531 triggered by any PB message from the master (including an ack to
5532 one of the slave's status-update messages). With this new scheme,
5533 large status messages over slow pipes are OK, as long as any given
5534 message can be sent (and thus acked) within .keepaliveTimeout
5535 seconds (which defaults to 30).
5536 (SlaveBuilder.remote_startCommand): record activity
5537 (SlaveBuilder.ackUpdate): same
5538 (SlaveBuilder.ackComplete): same
5539 (BotFactory.gotPerspective): same
5540 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5542 2004-12-09 Brian Warner <warner@lothar.com>
5544 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5547 * buildbot/process/step_twisted.py (Trial._commandComplete):
5548 update self.cmd when we start the 'cat test.log' transfer. Without
5549 this, we cannot interrupt the correct RemoteCommand when we lose
5552 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5553 trying to tell the slave to stop the command if we're already
5554 inactive, or if we no longer have a .remote
5556 * buildbot/process/builder.py (Builder._detached): don't let an
5557 exception in currentBuild.stopBuild() prevent the builder from
5558 being marked offline
5560 2004-12-07 Brian Warner <warner@lothar.com>
5562 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5563 KeyError that happens when you ask for a non-existent Builder, and
5564 translate it into a UsageError.
5566 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5567 losing the slave in the middle of a remote step is handled too
5569 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5570 be a Failure, so be sure to stringify it before using it as the
5571 contents of the 'interrupt' logfile
5572 (RemoteCommand.interrupt): use stringified 'why' in
5573 remote_interruptCommand too, just in case
5575 2004-12-06 Brian Warner <warner@lothar.com>
5577 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5578 instead of 'tla update', which is more efficient in case we've
5579 missed a couple of patches since the last update.
5581 * debian/changelog: update for previous (0.6.1) release. Obviously
5582 this needs to be handled better.
5584 2004-12-05 Brian Warner <warner@lothar.com>
5586 * NEWS: update for stuff since last release
5588 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5589 match the maybeDeferred change in Dispatcher.requestAvatar
5590 * buildbot/changes/pb.py (ChangePerspective.attached): same
5591 * buildbot/status/client.py (StatusClientPerspective.attached): same
5592 * buildbot/process/builder.py (Builder._attached3): same
5593 * buildbot/pbutil.py (NewCredPerspective.attached): same
5595 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5596 the date to the top-most box, if it is not the same as today's
5599 * docs/slave.xhtml: provide a buildslave setup checklist
5601 * docs/source.xhtml (Arch): correct terminology
5603 2004-12-04 Brian Warner <warner@lothar.com>
5605 * buildbot/test/test_slavecommand.py: use sys.executable instead
5606 of hard-coding 'python' for child commands, might help portability
5608 * docs/examples/twisted_master.cfg: update to current usage
5610 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5611 'stop build' command to the IRC bot
5613 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5614 message that broke PBChangeSource
5616 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5617 (SlaveBuilder): make some attributes class-level, remove the old
5618 "update queue" which existed to support resuming a build after the
5619 master connection was lost. Try to reimplement that feature later.
5620 (SlaveBuilder.stopCommand): clear self.command when the
5621 SlaveCommand finishes, so that we don't try to kill a leftover one
5623 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5626 * buildbot/slave/commands.py (SourceBase): set self.command for
5627 all VC commands, so they can be interrupted.
5629 2004-12-03 Brian Warner <warner@lothar.com>
5631 * buildbot/master.py: clean up slave-handling code, to handle
5632 slave-disconnect and multiple-connect better
5633 (BotPerspective): make these long-lasting, exactly one per bot
5634 listed in the config file.
5635 (BotPerspective.attached): if a slave connects while an existing
5636 one appears to still be connected, disconnect the old one first.
5637 (BotPerspective.disconnect): new method to forcibly disconnect a
5638 buildslave. Use some hacks to empty the transmit buffer quickly to
5639 avoid the long (20-min?) TCP timeout that could occur if the old
5640 slave has dropped off the net.
5641 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5642 own their own SlaveStatus objects. Remove .attached/.detached, add
5643 .addSlave/.removeSlave, treat slaves like Builders (config file
5644 parsing sends deltas to the BotMaster). Inform the slave
5645 instances, i.e. the BotPerspective, about addBuilder and
5647 (BotMaster.getPerspective): turns into a single dict lookup
5648 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5649 which gives BotPerspective.attached a chance to disconnect the old
5651 (BuildMaster.loadConfig): add code (disabled) to validate that all
5652 builders use known slaves (listed in c['bots']). The check won't
5653 work with tuple-specified builders, which are deprecated but not
5654 yet invalid, so the check is disabled for now.
5655 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5656 routine, do the add/changed/removed dance with them like we do
5658 (BuildMaster.loadConfig_Sources): move source-config into a
5659 separate routine too
5661 * buildbot/status/builder.py (Status.getSlave): get the
5662 SlaveStatus object from the BotPerspective, not the BotMaster.
5664 * buildbot/test/test_run.py: bunch of new tests for losing the
5665 buildslave at various points in the build, handling a slave that
5666 connects multiple times, and making sure we can interrupt a
5669 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5670 something other than 'Bot' for the Bot object, to make certain
5671 test cases easier to write.
5672 (BuildSlave.waitUntilDisconnected): utility method for testing
5674 2004-11-30 Brian Warner <warner@lothar.com>
5676 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5678 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5679 argument, return a Deferred that always fires with True or False.
5680 I don't use an errback to indicate 'ping failed' so that callers
5681 are free to ignore the deferred without causing spurious errors in
5683 * buildbot/process/builder.py (BuilderControl.ping): implement it
5685 * buildbot/test/test_run.py (Status.testDisappear): test ping
5686 (Status.disappearSlave): fix it
5688 2004-11-30 Brian Warner <warner@lothar.com>
5690 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5691 (IBuilderControl): add .getBuild(num), only works for the current
5692 build, of course, although it might be interesting to offer
5693 something for builds in the .waiting or .interlocked state.
5695 * buildbot/process/base.py (Build): have .stopBuild just do the
5696 interrupt, then let the build die by itself.
5697 (BuildControl): add .stopBuild, and add a point-event named
5698 'interrupt' just after the build so status viewers can tell that
5700 (BuilderControl): add .getBuild
5702 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5703 stops when you kill it, good for testing
5704 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5705 contains the 'reason' text.
5707 * buildbot/status/html.py: Add Stop Build button, if the build can
5708 still be stopped. Send a Redirect (to the top page) one second
5709 later, hopefully long enough for the interrupt to have an effect.
5710 Move make_row() up to top-level to share it between Stop Build and
5713 * buildbot/slave/commands.py: only kill the child process once
5715 * buildbot/test/test_run.py: add testInterrupt
5717 2004-11-29 Brian Warner <warner@lothar.com>
5719 * buildbot/process/base.py: Refactor command interruption. The
5720 Build is now responsible for noticing that the slave has gone
5721 away: Build.lostRemote() interrupts the current step and makes
5722 sure that no further ones will be started.
5724 * buildbot/process/builder.py: When the initial remote_startBuild
5725 message fails, log it: this usually indicates that the slave has
5726 gone away, but we don't really start paying attention until they
5727 fail to respond to the first step's command.
5729 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5730 slave disconnect. Now sports a new interrupt() method. Error
5731 handling was simplified a lot by chaining deferreds, so
5732 remoteFailed/remoteComplete were merged into a single
5733 remoteComplete method (which can now get a Failure object).
5734 Likewise failed/finished were merged into just _finished.
5735 (BuildStep): Add interrupt(why) method, and if why is a
5736 ConnectionLost Failure then the step is failed with some useful
5739 * buildbot/slave/bot.py: stop the current command when the remote
5740 Step reference is lost, and when the slave is shut down.
5741 (Bot): make it a MultiService, so it can have children. Use
5742 stopService to tell when the slave is shutting down.
5743 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5744 remote_interruptCommand (which asks the current SlaveCommand to
5745 stop but allows it to keep emitting status messages), and
5746 stopCommand (which tells it to shut up and die).
5748 * buildbot/slave/commands.py: make commands interruptible
5749 (ShellCommand.kill): factor out os.kill logic
5750 (Command): factor out setup()
5751 (Command.sendStatus): don't send status if .running is false, this
5752 happens when the command has been halted.
5753 (Command.interrupt): new method, used to tell the command to die
5754 (SlaveShellCommand): implement .interrupt
5755 (DummyCommand): implement .interrupt
5756 (SourceBase, etc): factor out setup(), don't continue substeps if
5759 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5760 so they can be called after finishing
5762 * buildbot/test/test_run.py: new tests for disconnect behavior,
5763 refactor slave-shutdown routines, add different kinds of
5766 2004-11-27 Brian Warner <warner@lothar.com>
5768 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5769 method to express ETA time like "2m45s" instead of "165 seconds"
5771 2004-11-24 Brian Warner <warner@lothar.com>
5773 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5774 archive after the test completes, to avoid cluttering the user's
5775 'tla archives' listing with a bogus entry. Arch doesn't happen to
5776 provide any way to override the use of ~/.arch-params/, so there
5777 isn't a convenient way to avoid touching the setup of the user who
5779 (VC_HTTP.testArchHTTP): same
5781 2004-11-23 Brian Warner <warner@lothar.com>
5783 * buildbot/status/html.py (TextLog): split render() up into
5784 render_HEAD and render_GET. Use a Producer when sending log
5785 chunks, to reduce memory requirements and avoid sending huge
5786 non-Banana-able strings over web.distrib connections. Requires
5787 peeking under the covers of IStatusLog.
5788 (TextLog.resumeProducing): fix the "as text" link, handle client
5789 disconnects that occur while we're still sending old chunks.
5791 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5792 use defer.succeed, not the non-existent defer.success
5793 (LogFile.waitUntilFinished): same
5794 (LogFile.subscribe): don't add watchers to a finished logfile
5796 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5799 2004-11-23 Brian Warner <warner@lothar.com>
5801 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5803 2004-11-23 Brian Warner <warner@lothar.com>
5805 * NEWS: update for the 0.6.1 release
5806 * MANIFEST.in: add new files
5808 * README (INSTALLATION): explain how to enable the extra VC tests
5810 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5811 level to, so old pickled builds can be displayed ok
5813 2004-11-22 Brian Warner <warner@lothar.com>
5815 * NEWS: summarize updates since last release
5817 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5818 Yoz Grahame. Closes SF#1050138.
5820 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5823 * buildbot/process/step_twisted.py (Trial): update docs a bit
5825 * docs/factories.xhtml: fix Trial factory docs to match reality.
5828 * buildbot/process/factory.py (Trial.__init__): add args for
5829 randomly= and recurse=, making them available to instantiators
5830 instead of only to subclassers. Closes: SF#1049759.
5832 2004-11-15 Brian Warner <warner@lothar.com>
5834 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5835 try to teach the Quick factory to use multiple versions of python
5837 2004-11-12 Brian Warner <warner@lothar.com>
5839 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5840 safer w32-compatible approach, and only use it on windows
5841 (BuildStatus.saveYourself): same
5843 2004-11-11 Brian Warner <warner@lothar.com>
5845 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5846 it: one string merge per chunk. There are now separate .entries
5847 and .runEntries lists: when enumerating over all chunks, make sure
5849 * buildbot/test/test_status.py (Log): more tests
5851 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5852 chunks together, up to 10kb per chunk. This ought to cut down on
5853 the CPU-burning overhead of large log files. Thanks to Alexander
5854 Staubo for spotting the problem.
5855 * buildbot/test/test_status.py (Log): tests for same
5857 2004-11-10 Brian Warner <warner@lothar.com>
5859 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5860 header to outbound mail
5861 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5863 2004-11-08 Brian Warner <warner@lothar.com>
5865 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5866 can't do os.rename() onto an existing file, so catch the exception
5867 and unlink the target file first. This introduces a slight window
5868 where the existing file could be lost, but the main failure case
5869 (disk full) should still be handled safely.
5870 (BuildStatus.saveYourself): same
5872 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5873 separator character instead of os.sep, because the filenames being
5874 split here are coming from the VC system, which can have a
5875 different pathname convention than the local host. This should
5876 help a buildmaster running on windows that uses a CVS repository
5877 which runs under unix.
5878 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5880 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5881 when there are no test failures to be parsed
5883 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5884 instead of the unix-specific os.system("cp"), thanks to Elliot
5885 Murphy for this and the other buildbot-vs-windows catches.
5886 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5888 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5889 echo the command as it is run
5891 * setup.py: install sample.mk too, not just sample.cfg
5892 (scripts): install contrib/windows/buildbot.bat on windows
5894 2004-11-07 Brian Warner <warner@lothar.com>
5896 * buildbot/process/builder.py (Builder._detached): clear the
5897 self.currentBuild reference, otherwise the next build will be
5898 skipped because we think the Builder is already in use.
5900 * docs/examples/twisted_master.cfg: update to match current usage
5901 on the Twisted buildbot
5903 2004-10-29 Brian Warner <warner@lothar.com>
5905 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5907 2004-10-28 Brian Warner <warner@lothar.com>
5909 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5910 have separate doVCUpdate/doVCFull methods. Catch an update failure
5911 and respond by clobbering the source directory and re-trying. This
5912 will handle local changes (like replacing a file with a directory)
5913 that will cause CVS and SVN updates to fail.
5914 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5916 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5919 2004-10-19 Brian Warner <warner@lothar.com>
5921 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5923 * buildbot/status/html.py (StatusResourceTestResults): display any
5924 TestResults that the Build might have
5925 (StatusResourceTestResult): and the logs for each TestResult
5926 (StatusResourceBuild): add link from the per-build page
5928 2004-10-15 Brian Warner <warner@lothar.com>
5930 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5931 the 'problems' portion of stdout, add TestResults to our build
5932 * buildbot/test/test_twisted.py (Parse.testParse): test it
5934 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5935 to retrieve a dict of accumulated test results
5936 (ITestResult): define what a single test result can do
5937 * buildbot/status/builder.py (TestResult): implement ITestResult
5938 (BuildStatus.getTestResults): retrieve dict of TestResults
5939 (BuildStatus.addTestResult): add TestResults
5940 * buildbot/test/test_status.py (Results.testAddResults): test it
5942 2004-10-14 Brian Warner <warner@lothar.com>
5944 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5945 instead of os.system("rm -rf") for win32 portability
5947 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5948 SignalMixin instead of starting/stopping the reactor, which is
5949 likely to cause problems with other tests
5951 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5952 self.copyComplete() call. Yoz Grahame makes the catch.
5954 * contrib/windows/buildbot.bat: helper script to deal with path
5955 issues. Thanks to Yoz Grahame.
5957 * buildbot/master.py (BuildMaster.startService): don't register a
5958 SIGHUP handler if the signal module has no SIGHUP attribute.
5959 Apparently win32 does this.
5961 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5963 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5964 test if the reactor can't offer UNIX sockets
5966 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5967 error introduced in the last commit. We really need that
5970 2004-10-12 Brian Warner <warner@lothar.com>
5972 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5973 when describing a maildir source. Thanks to Stephen Davis.
5975 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5978 * buildbot/scripts/runner.py (createMaster): install Makefile too
5979 (start): add --no_save to 'start' command
5980 * buildbot/scripts/sample.mk: simple convenience Makefile with
5981 start/stop/reload targets
5983 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5986 2004-09-30 Brian Warner <warner@lothar.com>
5988 * setup.py: Releasing buildbot-0.6.0
5990 2004-09-30 Brian Warner <warner@lothar.com>
5992 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5993 test_trial.py from the source tarball until support is complete.
5995 * NEWS: update for 0.6.0 release
5996 * buildbot/__init__.py (version): same
5999 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
6000 'source' command to tell users where to get the Buildbot source
6002 * docs/examples/*.cfg: update to modern standards
6004 * NEWS: update for release
6006 * buildbot/scripts/runner.py (createMaster): remove the
6007 -shutdown.tap stuff now that it isn't necessary
6009 (start): launch buildbot.tap, not buildbot-shutdown.tap
6012 * buildbot/status/mail.py (Domain): shorten class name
6013 (MailNotifier): if lookup= is a string, pass it to Domain()
6014 * buildbot/test/test_status.py (Mail.testBuild1): new class name
6015 (Mail.testBuild2): test the string-to-Domain shortcut
6016 (Mail.testMail): fix test
6019 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
6022 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
6023 more attributes on load
6024 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
6025 to accomodate the whole waterfall page at once, and the thrashing
6026 results in a lot of unnecessary loads
6027 (BuildStatus.saveYourself): use binary pickles, not fluffy text
6028 (BuilderStatus.saveYourself): same
6029 (BuilderStatus.eventGenerator): stop generating on the first missing
6030 build. We assume that saved builds are deleted oldest-first.
6031 (BuildStepStatus.__getstate__): .progress might not exist
6033 * buildbot/changes/changes.py (ChangeMaster): make it
6034 serializable, in $masterdir/changes.pck
6035 (ChangeMaster.stopService): save on shutdown
6036 * buildbot/master.py (BuildMaster.loadChanges): load at startup
6037 * buildbot/test/test_config.py: load Changes before config file
6040 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
6041 "Oh my god, you killed the command" header on a separate line
6043 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
6044 skip over corrupted build pickles
6045 (BuilderStatus.getFullBuildByNumber): same
6046 (BuilderStatus.eventGenerator): skip over unavailable builds
6047 (BuildStatus.saveYourself): save builds to a .tmp file first, then
6048 do an atomic rename. This prevents a corrupted pickle when some
6049 internal serialization error occurs.
6050 (BuilderStatus.saveYourself): same
6052 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
6053 the timeout for shell commands, it got lost somehow
6055 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
6056 run out of build steps, return the rest of the builder events
6058 * buildbot/interfaces.py (IBuilderControl.ping): add method
6060 * buildbot/process/builder.py (BuilderControl.ping): move
6061 slave-ping to BuilderControl, and fix the failure case in the
6062 process (Event.finish() is the verb, Event.finished is the noun).
6064 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
6065 through the BuilderControl instead of the BuilderStatus
6066 (EventBox): add adapter for builder.Event, allowing builder events to
6067 be displayed in the waterfall display
6069 * buildbot/master.py (BotMaster.stopService): add a 'master
6070 shutdown' event to the builder's log
6071 (BuildMaster.startService): and a 'master started' on startup
6073 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
6074 builder events into the BuildStep event stream
6075 (Status.builderAdded): add a 'builder created' event
6078 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
6079 command to announce the completion of a running build
6080 (IrcStatusBot.command_FORCE): announce when the build finishes
6082 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
6083 don't evict unfinished builds from the cache: they must stay in
6084 the full-cache until their logfiles have stopped changing. Make
6085 sure the eviction loop terminates if an unfinished build was hit.
6086 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
6087 This lets exceptions be dumped in an email status message. Really
6088 we need LogFiles which contain both text and HTML, instead of two
6090 (BuildStatus.__getstate__): handle self.finished=False
6091 (Status.builderAdded): if the pickle is corrupted, abandon the
6092 history and create a new BuilderStatus object.
6094 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
6095 self.progress attribute, helped one test which doesn't fully set
6096 up the Build object.
6098 * buildbot/interfaces.py (IStatusLogStub): split out some of the
6099 IStatusLog methods into an Interface that is implemented by "stub"
6100 logs, for which all the actual text chunks are on disk (in the
6101 pickled Build instance). To show the log contents, you must first
6102 adapt the stub log to a full IStatusLog object.
6104 * buildbot/status/builder.py (LogFileStub): create separate stub
6105 log objects, which can be upgraded to a real one if necessary.
6106 (LogFile): make them persistable, and let them stubify themselves
6108 (BuildStepStatus): same
6110 (BuildStatus.saveYourself): save the whole build out to disk
6111 (BuilderStatus): make it persistable
6112 (BuilderStatus.saveYourself): save the builder to disk
6113 (BuilderStatus.addFullBuildToCache): implement two caches which
6114 hold Build objects: a small one which holds full Builds, and a
6115 larger one which holds "stubbed" Builds (ones with their LogFiles
6116 turned into LogFileStubs). This reduces memory usage by the
6117 buildmaster by not keeping more than a few (default is 2) whole
6118 build logs in RAM all the time.
6119 (BuilderStatus.getBuild): rewrite to pull from disk (through the
6121 (BuilderStatus.eventGenerator): rewrite since .builds went away
6122 (BuilderStatus.buildStarted): remove the .builds array. Add the
6123 build to the "full" cache when it starts.
6124 (BuilderStatus._buildFinished): save the build to disk when it
6126 (Status): give it a basedir (same as the BuildMaster's basedir)
6127 where the builder pickles can be saved
6128 (Status.builderAdded): create the BuilderStatus ourselves, by
6129 loading a pickle from disk (or creating a new instance if there
6130 was none on disk). Return the BuilderStatus so the master can glue
6131 it into the new Builder object.
6133 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
6134 all BuilderStatuses to save themselves out to disk. This is in
6135 lieu of saving anything important in the main Application pickle
6136 (the -shutdown.tap file).
6137 (BuildMaster.__init__): give Status() a basedir for its files
6138 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
6139 to get the BuilderStatus, then give it to the Builder (instead of
6140 doing it the other way around). It's ok if the status announces
6141 the new Builder before it's really ready, as the outside world can
6142 only see the BuilderStatus object anyway (and it is ready before
6143 builderAdded returns). Use the builder's "builddir" (which
6144 normally specifies where the slave will run the builder) as the
6145 master's basedir (for saving serialized builds).
6147 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
6148 coerce the logfile to IStatusLog before trying to get the text
6149 chunks out of it. This will pull the full (non-stubified) Build in
6150 from disk if necessary.
6151 (TextLog): fix the adapter registration
6153 * buildbot/test/test_control.py (Force.setUp): create the basedir
6154 * buildbot/test/test_web.py: same
6155 * buildbot/test/test_vc.py (SetupMixin.setUp): same
6156 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
6157 * buildbot/test/test_run.py (Run.testMaster): same
6158 (Status.setUp): same
6160 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
6162 * buildbot/status/html.py (Waterfall.__init__): store actual
6163 allowForce flag passed in rather than using True for everyone;
6164 make sure setting it to False doesn't cause a NameError
6166 (StatusResourceBuilder.__init__) add the builder name to the page
6168 (StatusResourceBuilder.body) move HTML generation for a name/value
6169 row into a helper method (StatusResourceBuilder.make_row); only
6170 generate the "Force Build" form if allowForce was True and the
6171 slave is connected. Use class attributes in the generated HTML to
6172 spread a little CSS-joy.
6174 2004-09-28 Brian Warner <warner@lothar.com>
6176 * buildbot/process/step_twisted.py (Trial.createSummary): fix
6177 warning-scanner to not ignore things like
6178 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
6180 * buildbot/status/html.py (StatusResource.control): add some
6181 class-level values for .control in an attempt to make upgrading
6184 * buildbot/util.py (ComparableMixin): survive missing attributes,
6185 such as when a class is modified and we're comparing old instances
6188 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
6189 failure handling, remove a redundant try/except block. Don't
6190 return the full traceback to the IRC channel.
6191 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
6192 error messages. Get ETA properly.
6194 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
6195 the reason, since (at least) IRC message will have <> in them.
6196 (StatusResourceBuilder.__init__): take an IBuilderControl
6197 (StatusResourceBuilder.force): use the IBuilderControl we get in
6198 the constructor instead of trying to make our own. Catch the
6199 new exceptions and ignore them for now (until we make an
6200 intermediate web page where we could show the error message)
6201 (StatusResource): create with an IControl, use it to give an
6202 IBuilderControl to all children
6203 (Waterfall): take an allowForce= option, pass an IControl object
6204 to StatusResource if it is True
6206 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
6208 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6209 catch new exceptions and return string forms
6211 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
6212 * buildbot/process/builder.py (Builder.forceBuild): raise them
6213 * buildbot/test/test_control.py (Force.testNoSlave): new test
6214 (Force.testBuilderInUse): same
6217 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
6219 * buildbot/test/test_run.py: use IControl
6220 * buildbot/test/test_vc.py: same
6222 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
6223 to use IControl. Still offline.
6224 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
6226 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
6227 who=None so periodic builds don't send out status mail
6228 (Builder.forceBuild): include reason in the log message
6229 (BuilderControl.forceBuild): rename 'name' to 'who'
6231 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
6232 'who' parameter, but make it None by default so builds forced by
6233 slave admins don't cause status mail to be sent to anybody
6234 (BotMaster.forceBuild): same. this method is deprecated.
6235 (DebugPerspective.perspective_forceBuild): same, use IControl.
6236 (DebugPerspective.perspective_fakeChange): use IControl..
6237 (Dispatcher.requestAvatar): .. so don't set .changemaster
6239 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
6240 parameter to avoid confusion with the name of the builder
6243 * buildbot/status/mail.py: refine comment about needing 2.3
6245 * buildbot/status/html.py: move all imports to the top
6247 * buildbot/test/test_control.py: test new interfaces
6248 * buildbot/test/test_run.py (Status): handle new interfaces
6249 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
6251 * buildbot/process/base.py (BuildControl): implement IBuildControl
6252 and its lonely getStatus() method
6254 * buildbot/process/builder.py (BuilderControl): implement
6255 IBuilderControl, obtained by adapting the Builder instance
6256 (Builder.startBuild): return a BuilderControl instead of a
6257 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
6258 accomplish the same thing.
6260 * buildbot/master.py: move all import statements to the top
6261 (Control): implement IControl, obtained by adapting the
6262 BuildMaster instance.
6264 * buildbot/interfaces.py: add IControl, IBuilderControl, and
6265 IBuildControl. These are used to force builds. Eventually they
6266 will provide ways to reconfigure the Builders, pause or abandon a
6267 Build, and perhaps control the BuildMaster itself.
6269 2004-09-26 Brian Warner <warner@lothar.com>
6271 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
6272 ends up comparing us against something without a .__class__
6274 2004-09-24 Brian Warner <warner@lothar.com>
6276 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
6279 * Makefile: add 'deb-snapshot' target, to create a timestamped
6282 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
6284 2004-09-23 Brian Warner <warner@lothar.com>
6286 * buildbot/__init__.py (version): move version string here
6287 * setup.py: get version string from buildbot.version
6288 * buildbot/status/html.py (WaterfallStatusResource.body): add
6289 buildbot version to the page footer
6290 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
6293 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
6294 slaves, let the second know where the first one is coming from
6295 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
6296 see our exceptions. It would be nice if there were a way to just
6297 send them the exception type and value, not the full traceback.
6300 * buildbot/status/mail.py (MailNotifier): add a new argument
6301 sendToInterestedUsers=, which can be set to False to disable the
6302 usual send-to-blamelist behavior.
6303 (top): handle python-2.2 which has no email.MIMEMultipart
6304 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
6305 (MailNotifier.disownServiceParent): unsubscribe on removal
6307 * buildbot/test/test_status.py (Mail.testBuild2): test it
6310 * buildbot/status/progress.py (Expectations.wavg): tolerate
6311 current=None, which happens when steps start failing badly
6312 * buildbot/test/test_status.py (Progress.testWavg): test for it
6314 * buildbot/process/step.py (SVN.startVC): when the (old) slave
6315 doesn't understand args['revision'], emit a warning instead of
6316 bailing completely. Updating to -rHEAD is probably close enough.
6318 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
6320 * buildbot/test/test_status.py: at least import bb.status.client
6321 even if we don't have any test coverage for it yet
6323 * contrib/svn_buildbot.py: don't require python2.3
6324 (main): wait, do require it (for sets.py), but explain how to
6325 make it work under python2.2
6327 2004-09-23 Brian Warner <warner@lothar.com>
6329 * contrib/svn_buildbot.py: include the revision number in the Change
6331 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
6332 using util.now() because FreshCVS is a realtime service
6334 * buildbot/status/event.py: delete dead code
6335 * buildbot/process/step.py: don't import dead Event class
6336 * buildbot/process/step_twisted.py: same
6337 * buildbot/status/builder.py: same
6338 * buildbot/status/client.py: same
6340 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
6342 * buildbot/changes/changes.py (Change): set .when from an __init__
6343 argument (which defaults to now()), rather than having
6344 ChangeMaster.addChange set it later.
6345 (ChangeMaster.addChange): same
6347 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
6348 (parseSyncmail): same. Just use util.now() for now.
6349 (parseBonsaiMail): parse the timestamp field for when=
6351 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
6352 instead of setting .when after the fact
6356 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
6357 results when the target project uses retrial. Still under
6359 * buildbot/test/test_trial.py: same
6361 2004-09-21 Brian Warner <warner@lothar.com>
6363 * buildbot/status/mail.py (MailNotifier.__init__): include
6364 success/warnings/failure in the Subject line
6365 (MailNotifier.buildMessage): add the buildbot's URL to the body,
6366 use step.logname for the addLogs=True attachment filenames
6367 * buildbot/test/test_status.py (Mail): test Subject lines
6368 (Mail.testLogs): test attachment filenames
6370 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
6371 accept a 'who' argument from the debug tool
6372 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
6373 * contrib/debug.glade: add text box to set 'who'
6375 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
6376 .getBuilderName with .getBuilder().getName(), more flexible
6377 (IStatusLog.getName): logs have short names, but you can prefix
6378 them with log.getStep().getName() to make them more useful
6379 * buildbot/status/builder.py: same
6380 * buildbot/status/client.py: same
6381 * buildbot/status/html.py: same
6382 * buildbot/test/test_run.py (Status.testSlave): same
6383 * buildbot/process/step.py: tweak logfile names
6385 * buildbot/status/mail.py (MailNotifier): add lookup, change
6386 argument to extraRecipients. The notifier is now aimed at sending
6387 mail to the people involved in a particular build, with additional
6388 constant recipients as a secondary function.
6390 * buildbot/test/test_status.py: add coverage for IEmailLookup,
6391 including slow-lookup and failing-lookup. Make sure the blamelist
6392 members are included.
6394 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
6395 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
6396 (IBuildStatus.getInterestedUsers): new method
6397 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
6398 * buildbot/status/client.py (remote_getResponsibleUsers): same
6399 * buildbot/status/html.py (StatusResourceBuild.body): same
6400 * buildbot/test/test_run.py (Status.testSlave): same
6402 2004-09-20 Brian Warner <warner@lothar.com>
6404 * docs/users.xhtml: update concepts
6406 * Makefile: add a convenience makefile, for things like 'make
6407 test'. It is not included in the source tarball.
6409 2004-09-16 Brian Warner <warner@lothar.com>
6411 * NEWS: mention /usr/bin/buildbot, debian/*
6413 * debian/*: add preliminary debian packaging. Many thanks to
6414 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
6415 it considerably since it left their hands, I am responsible for
6416 all breakage that's resulted.
6418 * bin/buildbot: create a top-level 'buildbot' command, to be
6419 installed in /usr/bin/buildbot . For now it's just a simple
6420 frontend to mktap/twistd/kill, but eventually it will be the entry
6421 point to the 'try' command and also a status client. It is also
6422 intended to support the upcoming debian-packaging init.d scripts.
6423 * buildbot/scripts/runner.py: the real work is done here
6424 * buildbot/scripts/__init__.py: need this too
6425 * buildbot/scripts/sample.cfg: this is installed in new
6426 buildmaster directories
6427 * setup.py: install new stuff
6429 2004-09-15 Brian Warner <warner@lothar.com>
6431 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
6432 'file:' schema (the version shipped with OS-X was built without the
6434 (SetupMixin.tearDown): stop the goofy twisted.web timer which
6435 updates the log-timestamp, to make sure it isn't still running after
6438 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
6439 values to the config file.
6440 * docs/examples/hello.cfg: add examples
6441 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
6442 * buildbot/status/builder.py (Status.getProjectURL): implement them
6443 * buildbot/master.py (BuildMaster.loadConfig): set them from config
6444 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
6445 * buildbot/status/html.py (WaterfallStatusResource): display them
6448 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
6449 certain error cases don't suffer a secondary exception.
6450 (top): Skip tests if the corresponding VC tool is not installed.
6452 * buildbot/process/factory.py (Trial): introduce separate
6453 'buildpython' and 'trialpython' lists, since trialpython=[] is
6454 what you want to invoke /usr/bin/python, whereas ./setup.py is
6455 less likely to be executable. Add env= parameter to pass options
6456 to test cases (which is how I usually write tests, I don't know if
6457 anyone else does it this way).
6459 * buildbot/process/step_twisted.py (Trial): handle python=None.
6460 Require 'testpath' be a string, not a list. Fix tests= typo.
6461 (Trial.start): sanity-check any PYTHONPATH value for stringness.
6463 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
6464 way to deal with the possibility of removing the disconnect notify
6466 (CVS): add a 'login' parameter to give a password to 'cvs login',
6467 commonly used with pserver methods (where pw="" or pw="guest")
6469 * buildbot/slave/commands.py (SourceBase): move common args
6470 extraction and setup() to __init__, so everything is ready by the
6471 time setup() is called
6472 (CVS.start): call 'cvs login' if a password was supplied
6473 (ShellCommand): special-case PYTHONPATH: prepend the master's
6474 value to any existing slave-local value.
6476 * buildbot/process/builder.py (Builder.updateBigStatus): if we
6477 don't have a remote, mark the builder as Offline. This whole
6478 function should probably go away and be replaced by individual
6480 (Builder.buildFinished): return the results to the build-finished
6481 deferred callback, helps with testing
6483 2004-09-14 Brian Warner <warner@lothar.com>
6485 * buildbot/test/test_vc.py: put all the repositories needed to run
6486 the complete tests into a single small (1.3MB) tarball, so I can
6487 make that tarball available on the buildbot web site. Test HTTP
6488 access (for Arch and Darcs) by spawning a temporary web server
6489 while the test runs.
6491 * docs/users.xhtml: new document, describe Buildbot's limited
6492 understanding of different human users
6494 * buildbot/test/test_vc.py: rearrange test cases a bit
6496 * buildbot/process/step_twisted.py (Trial): handle testpath=
6497 * buildbot/process/factory.py (Trial): update to use step.Trial
6499 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
6501 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
6502 the overall build text (which gives you 'failed 2 tests' rather
6504 (BuildStepStatus.text2): default to [], not None
6506 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6509 2004-09-12 Brian Warner <warner@lothar.com>
6511 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6512 log the whole exception if it's just an AttributeError (old slave)
6514 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6515 so (e.g.) sub-commands can be run in the right directory.
6516 (ShellCommand.start): accept an optional errorMessage= argument
6517 to make life easier for SVN.start
6518 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6520 (ShellCommand.start): move ['dir'] compatibility hack..
6521 (RemoteShellCommand.start): .. to here so everyone can use it
6523 * buildbot/process/step_twisted.py (Trial): use .workdir
6525 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6526 text displayed when debuild fails completely
6527 (Trial): snarf _trial_temp/test.log from the slave and display it
6529 2004-09-11 Brian Warner <warner@lothar.com>
6531 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6533 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6534 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6536 * buildbot/process/step.py (ShellCommand): call .createSummary
6537 before .evaluateCommand instead of the other way around. This
6538 makes it slightly easier to count warnings and then use that to
6539 set results=WARNINGS
6540 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6542 * buildbot/process/base.py (Build.buildFinished): update status
6543 before doing progress. It's embarrassing for the build to be stuck
6544 in the "building" state when an exceptions occurs elsewhere..
6546 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6547 python2.2 doesn't have 'sum'
6549 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6550 to prevent clients from accidentally sorting it
6552 * buildbot/master.py (Manhole): add username/password
6553 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6554 c['manholePort'], deprecate old usage
6555 * docs/config.xhtml: document c['manhole']
6556 * docs/examples/hello.cfg: show example of using a Manhole
6559 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6560 pretend the slave is up to date
6562 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6563 the module, overlaps with 'log', the local variable
6565 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6567 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6568 new method to let Steps find out the version of their
6569 corresponding SlaveCommand.
6570 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6571 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6572 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6574 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6575 (Arch.startVC): same
6576 (P4Sync.startVC): same
6578 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6579 Deferred so we can catch errors in remote_startCommand
6580 (RemoteShellCommand.start): same
6582 * docs/examples/twisted_master.cfg: update sample config file
6584 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6585 after connectionMade() is called, not before. Close stdin at that
6588 * buildbot/process/process_twisted.py: update to use Trial, clean
6589 up argument passing (move to argv arrays instead of string
6592 * buildbot/process/step_twisted.py (Trial): new step to replace
6593 RunUnitTests, usable by any trial-using project (not just
6594 Twisted). Arguments have changed, see the docstring for details.
6596 * buildbot/process/base.py (Build.startBuild): this now returns a
6597 Deferred. Exceptions that occur during setupBuild are now
6598 caught better and lead to fewer build_status weirdnesses, like
6599 finishing a build that was never started.
6600 (Build.buildFinished): fire the Deferred instead of calling
6601 builder.buildFinished directly. The callback argument is this
6602 Build, everything else can be extracted from it, including the
6603 new build.results attribute.
6604 * buildbot/process/builder.py (Builder.startBuild): same
6605 (Builder.buildFinished): same, extract results from build
6607 * buildbot/process/step.py (ShellCommands): remove dead code
6609 2004-09-08 Brian Warner <warner@lothar.com>
6611 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6612 doesn't try to use the leftover patched workdir
6613 (SourceStamp): test source-stamp computation for CVS and SVN
6615 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6616 patched workdir ('touch .buildbot-patched') so we don't try to
6618 (SourceBase.start): add ['revision'] for all Source steps
6619 (CVS): change args: use ['branch'] for -r, remove ['files']
6620 (CVS.buildVC): fix revision/branch stuff
6621 (SVN): add revision stuff
6623 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6624 kwargs (except 'workdir') to avoid silent spelling errors
6625 (ShellCommand.__init__): same
6626 (Source): new base class for CVS/SVN/etc. Factor out everything
6627 common, add revision computation (perform the checkout with a -D
6628 DATE or -r REVISION that gets exactly the sources described by the
6629 last Change), overridable with step.alwaysUseLatest. Add patch
6630 handling (build.getSourceStamp can trigger the use of a base
6631 revision and a patch).
6632 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6633 * docs/steps.xhtml: update docs
6634 * docs/source.xhtml: mention .checkoutDelay
6635 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6637 * buildbot/process/base.py (Build.setSourceStamp): add a
6638 .sourceStamp attribute to each Build. If set, this indicates that
6639 the build should be done with something other than the most
6640 recent source tree. This will be used to implement "try" builds.
6641 (Build.allChanges): new support method
6642 (Build.lastChangeTime): remove, functionality moved to Source steps
6643 (Build.setupBuild): copy the Step args before adding ['workdir'],
6644 to avoid modifying the BuildFactory (and thus triggering spurious
6648 * buildbot/status/html.py: rename s/commits/changes/
6649 (StatusResourceChanges): same
6650 (CommitBox.getBox): same, update URL
6651 (WaterfallStatusResource): same
6652 (StatusResource.getChild): same
6654 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6655 * contrib/debug.glade: add optional 'revision' to the fakeChange
6657 * buildbot/changes/changes.py (html_tmpl): display .revision
6658 (ChangeMaster.addChange): note .revision in log
6659 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6660 accept a ['revision'] attribute
6662 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6664 * buildbot/master.py (BotMaster.getPerspective): update the
6665 .connected flag in SlaveStatus when it connects
6666 (BotMaster.detach): and when it disconnects
6667 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6668 (BuildMaster.loadConfig_Builders): walk old list correctly
6670 * buildbot/test/test_config.py: fix prefix= usage
6672 2004-09-06 Brian Warner <warner@lothar.com>
6676 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6677 poll a P4 depot looking for recent changes. Thanks to Dave
6678 Peticolas for the contribution. Probably needs some testing after
6681 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6682 requires manual client setup for each buildslave. Rather
6683 experimental. Thanks again to Dave Peticolas.
6684 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6686 * buildbot/changes/changes.py (Change): add a .revision attribute,
6687 which will eventually be used to generate source-stamp values.
6689 * buildbot/process/step.py (RemoteCommand.start): use
6690 notifyOnDisconnect to notice when we lose the slave, then treat it
6691 like an exception. This allows LogFiles to be closed and the build
6692 to be wrapped up normally. Be sure to remove the disconnect
6693 notification when the step completes so we don't accumulate a
6694 bazillion such notifications which will fire weeks later (when the
6695 slave finally disconnects normally). Fixes SF#915807, thanks to
6696 spiv (Andrew Bennetts) for the report.
6697 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6698 really isn't Logged- specific
6699 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6700 header, since it's almost always going to be appended to an
6702 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6703 update test to handle use of notifyOnDisconnect
6705 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6706 don't clear .ETA and .currentBuild when going offline, let the
6707 current build clean up after itself
6709 * buildbot/process/builder.py (Builder.detached): wait a moment
6710 before doing things like stopping the current build, because the
6711 current step will probably notice the disconnect and cleanup the
6713 * buildbot/test/test_run.py (Status.tearDown): update test to
6714 handle asynchronous build-detachment
6716 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6718 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6719 hush a debug message
6721 2004-09-05 Brian Warner <warner@lothar.com>
6723 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6724 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6725 kernels do this: the fcntl module has the F_NOTIFY constant, but
6726 the kernel itself doesn't support the operation. Thanks to Olly
6727 Betts for spotting the problem.
6729 * buildbot/process/step.py (Darcs): new source-checkout command
6730 (Arch): new source-checkout command
6731 (todo_P4): fix constructor syntax, still just a placeholder
6732 * buildbot/test/test_vc.py (VC.testDarcs): test it
6733 (VC.testDarcsHTTP): same, via localhost HTTP
6735 (VC.testArchHTTP): same
6736 * NEWS: mention new features
6738 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6739 which tells the step to stash stdout text locally (in .stdout).
6740 Slave-side Commands can use this to make decisions based upon the
6741 output of the the ShellCommand (not just the exit code).
6742 (Darcs): New source-checkout command
6743 (Arch): New source-checkout command, uses .keepStdout in one place
6744 where it needs to discover the archive's default name.
6746 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6747 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6748 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6750 * buildbot/process/step.py (ShellCommand.describe): add an
6751 alternate .descriptionDone attribute which provides descriptive
6752 text when the step is complete. .description can be ["compiling"],
6753 for use while the step is running, then .descriptionDone can be
6754 ["compile"], used alone when the step succeeds or with "failed" when
6755 it does not. Updated other steps to use the new text.
6756 * buildbot/process/step_twisted.py: same
6757 * buildbot/test/test_run.py: update tests to match
6759 2004-08-30 Brian Warner <warner@lothar.com>
6761 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6762 (CVS.__init__): send 'patch' argument to slave
6763 (CVS.start): don't create the LoggedRemoteCommand until start(),
6764 so we can catch a .patch added after __init__
6765 (SVN.__init__): add 'patch' to SVN too
6768 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6769 argument, to let commands push data into the process' stdin pipe.
6770 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6771 is in use, since closing a PTY doesn't really affect the process
6772 in the right way (in particular, I couldn't run /usr/bin/patch
6774 (SourceBase.doPatch): handle 'patch' argument
6776 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6779 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6780 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6782 * buildbot/master.py (BotPerspective.got_commands): get command
6783 versions from slave, give to each builder
6784 * buildbot/process/builder.py (Builder.attached): stash slave
6785 command versions in .remoteCommands
6787 * docs/steps.xhtml: bring docs in-line with reality
6789 * buildbot/process/step.py (CVS.__init__): more brutal
6790 compatibility code removal
6791 (SVN.__init__): same
6793 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6794 (SlaveShellCommand.start): require ['workdir'] argument, remove
6795 the ['dir'] fallback (compatibility will come later)
6796 (SourceBase): update docs
6797 (SourceBase.start): remove ['directory'] fallback
6800 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6801 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6802 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6804 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6805 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6806 code.. I will figure out 0.5.0-compatibility hooks later)
6808 2004-08-30 Brian Warner <warner@lothar.com>
6810 * buildbot/process/process_twisted.py: rewrite in terms of new
6811 BuildFactory base class. It got significantly shorter. Yay
6814 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6815 work with the new "self.build isn't nailed down until we call
6816 step.start()" scheme: specifically, __init__ is called before the
6817 build has decided on which Changes are going in, so we don't scan
6818 build.allFiles() for .xhtml files until start()
6819 (HLint.commandComplete): use getText(), not getStdout()
6820 (RunUnitTests.start): same: don't use .build until start()
6821 (RunUnitTests.describe): oops, don't report (None) when using
6823 (RunUnitTests.commandComplete): use getText()
6824 (RunUnitTests.createSummary): same
6825 (BuildDebs.commandComplete): same
6827 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6828 set args['command'] until start(), since our BuildStep is allowed
6829 to change their mind up until that point
6830 (TreeSize.commandComplete): use getText(), not getStdout()
6832 * docs/examples/twisted_master.cfg: update to current standards
6834 * docs/factories.xhtml: update
6835 * buildbot/process/factory.py: implement all the common factories
6836 described in the docs. The Trial factory doesn't work yet, and
6837 I've probably broken all the process_twisted.py factories in the
6838 process. There are compatibility classes left in for things like
6839 the old BasicBuildFactory, but subclasses of them are unlikely to
6841 * docs/examples/glib_master.cfg: use new BuildFactories
6842 * docs/examples/hello.cfg: same
6844 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6845 explicit 'workdir' args
6847 * buildbot/process/base.py (BuildFactory): move factories to ..
6848 * buildbot/process/factory.py (BuildFactory): .. here
6849 * buildbot/process/process_twisted.py: handle move
6850 * buildbot/test/test_config.py: same
6851 * buildbot/test/test_run.py: same
6852 * buildbot/test/test_steps.py: same
6853 * buildbot/test/test_vc.py: same
6854 * docs/factories.xhtml: same
6856 * NEWS: mention config changes that require updating master.cfg
6858 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6859 argument to all steps that weren't given one already, pointing at
6860 the "build/" directory.
6862 * docs/examples/hello.cfg: remove explicit 'workdir' args
6864 * docs/factories.xhtml: document standard BuildFactory clases,
6865 including a bunch which are have not yet been written
6867 2004-08-29 Brian Warner <warner@lothar.com>
6869 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6870 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6871 buildbot.status.builder so they aren't quite so internal
6872 * buildbot/process/base.py, buildbot/process/builder.py: same
6873 * buildbot/process/maxq.py, buildbot/process/step.py: same
6874 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6875 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6876 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6878 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6879 to handle new getLogs()-returns-list behavior
6880 (StatusResourceBuildStep.getChild): same
6881 (StepBox.getBox): same
6882 (WaterfallStatusResource.phase0): same
6884 * docs/source.xhtml: document how Buildbot uses version-control
6885 systems (output side: how we get source trees)
6886 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6887 systems (input side: how we learn about Changes)
6889 * buildbot/master.py (Manhole): use ComparableMixin
6890 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6891 * buildbot/changes/mail.py (MaildirSource): same
6892 * buildbot/status/client.py (PBListener): same
6893 * buildbot/status/html.py (Waterfall): same
6894 * buildbot/status/words.py (IRC): same
6896 * NEWS: start describing new features
6898 * buildbot/status/mail.py (MailNotifier): finish implementation.
6899 The message body is still a bit sparse.
6900 * buildbot/test/test_status.py (Mail): test it
6902 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6903 and __hash__ methods I wind up adding everywhere. Specifically
6904 intended to support the buildbot config-file update scheme where
6905 we compare, say, the old list of IStatusTargets against the new
6906 one and don't touch something which shows up on both lists.
6907 * buildbot/test/test_util.py (Compare): test case for it
6909 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6910 return a list instead of a dict
6911 (IBuildStepStatus.getLogs): same. The idea is that steps create
6912 logs with vaguely unique names (although their uniqueness is not
6913 guaranteed). Thus a compilation step should create its sole
6914 logfile with the name 'compile', and contribute it to the
6915 BuildStatus. If a step has two logfiles, try to create them with
6916 different names (like 'test.log' and 'test.summary'), and only
6917 contribute the important ones to the overall BuildStatus.
6918 * buildbot/status/builder.py (Event.getLogs): same
6919 (BuildStepStatus): fix default .text and .results
6920 (BuildStepStatus.addLog): switch to list-like .getLogs()
6921 (BuildStepStatus.stepFinished): same
6922 (BuildStatus.text): fix default .text
6923 (BuildStatus.getLogs): temporary hack to return all logs (from all
6924 child BuildStepStatus objects). Needs to be fixed to only report
6925 the significant ones (as contributed by the steps themselves)
6926 * buildbot/test/test_run.py: handle list-like .getLogs()
6927 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6929 2004-08-28 Brian Warner <warner@lothar.com>
6931 * buildbot/process/builder.py (Builder.attached): serialize the
6932 attachment process, so the attach-watcher isn't called until the
6933 slave is really available. Add detached watchers too, which makes
6936 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6938 * buildbot/test/test_swap.py: remove dead code
6940 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6941 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6942 sort of as if the command being run exited with a -1. There may
6943 still be some holes in this scheme.
6944 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6945 -r option appears before the module list
6946 * buildbot/process/step.py (CVS): add 'revision' argument
6948 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6949 when sending updates or stepComplete messages to the master, since
6950 we don't currently care whether they arrive or not. When we revamp
6951 the master/slave protocol to really resume interrupted builds,
6952 this will need revisiting.
6953 (lostRemote): remove spurious print
6955 * buildbot/master.py (BotPerspective.attached): serialize the
6956 new-builder interrogation process, to make testing easier
6957 (BotMaster.waitUntilBuilderDetached): convenience function
6959 * buildbot/status/builder.py (BuilderStatus): prune old builds
6960 (BuildStatus.pruneSteps): .. and steps
6961 (BuildStepStatus.pruneLogs): .. and logs
6962 (BuilderStatus.getBuild): handle missing builds
6963 * buildbot/status/html.py (StatusResourceBuild.body): display build
6964 status in the per-build page
6965 (BuildBox.getBox): color finished builds in the per-build box
6967 2004-08-27 Brian Warner <warner@lothar.com>
6969 * buildbot/status/mail.py (MailNotifier): new notification class,
6972 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6973 variants of a common base class which handles all the mode= logic
6975 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6977 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6979 2004-08-26 Brian Warner <warner@lothar.com>
6981 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6984 * buildbot/test/test_run.py: update to new Logfile interface, new
6985 buildbot.slave modules
6986 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6988 * MANIFEST.in: new sample config file
6989 * docs/examples/hello.cfg: same
6991 * buildbot/process/step_twisted.py: remove dead import
6993 * buildbot/process/step.py (RemoteCommand.run): catch errors
6995 (RemoteCommand.remote_update): ignore updates that arrive after
6997 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6998 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6999 the responsibilities of the subclass's methods
7000 (BuildStep.failed): catch errors during failure processing
7001 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
7002 (CVS): move to a mode= argument (described in docstring), rather
7003 than the ungainly clobber=/export=/copydir= combination.
7004 (SVN): add mode= functionality to SVN too
7005 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
7007 * buildbot/process/base.py (Build.startNextStep): catch errors
7008 during s.startStep()
7010 * buildbot/clients/base.py: update to new PB client interface.
7011 gtkPanes is still broken
7013 * buildbot/bot.py, buildbot/slavecommand.py: move to..
7014 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
7015 * setup.py: add buildbot.slave module
7016 * buildbot/bb_tap.py: handle move
7017 * buildbot/slave/registry.py: place to register commands, w/versions
7018 * buildbot/slave/bot.py: major simplifications
7019 (SlaveBuilder.remote_startCommand): use registry for slave commands,
7020 instead of a fixed table. Eventually this will make the slave more
7021 extensible. Use 'start' method on the command, not .startCommand.
7022 Fix unsafeTracebacks handling (I think).
7023 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
7024 helper class with a .start method that returns a Deferred.
7025 SlaveShellCommand is the form reached by the buildmaster. Commands
7026 which use multiple ShellCommands can just chain them as Deferreds,
7027 with some helper methods in Command (_abandonOnFailure and
7028 _checkAbandoned) to bail on rc!=0.
7029 (CVSCommand): prefer new mode= argument
7030 (SVNFetch): add mode= argument
7032 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
7033 put a useful reason string on the build
7035 * buildbot/status/builder.py (LogFile): do LogFile right: move the
7036 core functionality into an IStatusLog object
7037 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
7038 * buildbot/status/html.py (TextLog): HTML-rendering goes here
7039 (StatusResourceBuild.body): use proper accessor methods
7040 * buildbot/status/client.py (RemoteLog): PB-access goes here
7041 (StatusClientPerspective.perspective_subscribe): add "full" mode,
7042 which delivers log contents too
7043 (PBListener.__cmp__): make PBListeners comparable, thus removeable
7044 * buildbot/status/event.py: remove old Logfile completely
7046 * buildbot/interfaces.py (IStatusLog.subscribe): make the
7047 subscription interface for IStatusLog subscriptions just like all
7048 other the status subscriptions
7049 (IStatusReceiver.logChunk): method called on subscribers
7051 2004-08-24 Brian Warner <warner@lothar.com>
7053 * buildbot/process/builder.py (Builder._pong): oops, ping response
7054 includes a result (the implicit None returned by remote_print).
7055 Accept it so the _pong method handles the response correctly.
7057 2004-08-06 Brian Warner <warner@lothar.com>
7059 * buildbot/test/test_config.py: update IRC, PBListener tests
7061 * buildbot/status/client.py (StatusClientPerspective): total
7062 rewrite to match new IStatus interfaces. New subscription scheme.
7063 There are still a few optimizations to make (sending down extra
7064 information with event messages so the client doesn't have to do a
7065 round trip). The logfile-retrieval code is probably still broken.
7066 Moved the PB service into its own port, you can no longer share a
7067 TCP socket between a PBListener and, say, the slaveport (this
7068 should be fixed eventually).
7069 * buildbot/clients/base.py (Client): revamp to match. still needs
7070 a lot of work, but basic event reporting works fine. gtkPanes is
7073 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
7074 instance talks to a single irc server. Threw out all the old
7075 multi-server handling code. Still need to add back in
7076 builder-control (i.e. "force build")
7078 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
7079 more random text to the as-yet-unreachable per-step page
7081 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
7082 rename to stepETAUpdate
7083 (BuildStatus.subscribe): add build-wide ETA updates
7084 (BuilderStatus.getState): remove more cruft
7085 (BuilderStatus.getCurrentBuild): remove more cruft
7086 (BuilderStatus.buildStarted): really handle tuple-subscription
7087 * buildbot/test/test_run.py (Status.testSlave): handle the
7088 stepETAUpdate rename
7090 * buildbot/master.py (BuildMaster): don't add a default
7091 StatusClientService. Don't add a default IrcStatusFactory. Both
7092 are now added through c['status'] in the config file. c['irc'] is
7093 accepted for backwards compatibility, the only quirk is you cannot
7094 use c['irc'] to specify IRC servers on ports other than 6667.
7096 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
7097 (IStatusReceiver.buildStarted): allow update-interval on subscribe
7098 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
7099 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
7102 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
7103 the buildmaster to re-read its config file
7106 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
7107 find out the port our server is running on
7108 (WebTest.test_webPathname_port): same
7110 * buildbot/test/test_config.py (testWebPortnum): test it
7111 (testWebPathname): ditto
7113 * docs/config.xhtml: document new c['status'] configuration option
7115 * buildbot/status/html.py (Waterfall): new top-level class which
7116 can be added to c['status']. This creates the Site as well as the
7117 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
7118 reachable as .parent, for everything.
7120 * buildbot/master.py (Manhole): make it a normal service Child
7121 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
7122 webPathname. It will eventually replace c['irc'] and the implicit
7123 PB listener as well. c['webPortnum'] and c['webPathname'] are left
7124 in as (deprecated) backward compatibility hooks for now.
7127 * buildbot/process/builder.py (Builder.buildFinished): don't
7128 inform out builder_status about a finished build, as it finds out
7129 through its child BuildStatus object
7131 * buildbot/status/html.py: extensive revamp. Use adapters to make
7132 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
7133 have both starting and finishing times and adjust the waterfall
7134 display accordingly, using spacers if necessary. Use SlaveStatus
7135 to get buildslave info.
7136 (StatusResourceBuildStep): new just-one-step resource, used to get
7137 logfiles. No actual href to it yet.
7139 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
7140 the time being, until I get the file-naming scheme right
7142 * buildbot/status/builder.py (Event): clean started/finished names
7143 (BuildStatus.isFinished): .finished is not None is the right test
7144 (BuildStatus.buildStarted): track started/finished times ourselves
7145 (BuilderStatus.getSlave): provide access to SlaveStatus object
7146 (BuilderStatus.getLastFinishedBuild): all builds are now in
7147 .builds, even the currently-running one. Accomodate this change.
7148 (BuilderStatus.eventGenerator): new per-builder event generator.
7149 Returns BuildStepStatus and BuildStatus objects, since they can
7150 both be adapted as necessary.
7151 (BuilderStatus.addEvent): clean up started/finished attributes
7152 (BuilderStatus.startBuild,finishBuild): remove dead code
7153 (SlaveStatus): new object to provide ISlaveStatus
7155 * buildbot/process/step.py (ShellCommand.getColor): actually
7156 return the color instead of setting it ourselves
7157 (CVS.__init__): pull .timeout and .workdir options out of
7158 **kwargs, since BuildStep will ignore them. Without this neither
7159 will be sent to the slave correctly.
7160 (SVN.__init__): same
7162 * buildbot/process/builder.py (Builder): move flags to class-level
7164 (Builder.attached): remove .remoteInfo, let the BotPerspective and
7165 SlaveStatus handle that
7167 * buildbot/process/base.py (Build.firstEvent): remove dead code
7168 (Build.stopBuild): bugfix
7170 * buildbot/changes/pb.py (PBChangeSource.describe): add method
7172 * buildbot/changes/changes.py (Change): add IStatusEvent methods
7173 (ChangeMaster.eventGenerator): yield Changes, since there are now
7174 Adapters to turn them into HTML boxes
7176 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
7177 (BotPerspective.attached): feed a SlaveStatus object
7178 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
7179 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
7181 * buildbot/interfaces.py: API additions
7182 (ISlaveStatus): place to get slave status
7184 2004-08-04 Brian Warner <warner@lothar.com>
7186 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
7187 the delay finishes, so the step is marked as SUCCESS
7189 * buildbot/test/test_run.py (Status.testSlave): cover more of
7190 IBuildStatus and IBuildStepStatus
7192 * buildbot/status/progress.py (StepProgress): move some flags to
7193 class-level attributes
7194 (StepProgress.remaining): if there are no other progress metrics
7195 to go by, fall back to elapsed time
7196 (StepProgress.setExpectations): take a dict of metrics instead of
7198 (BuildProgress.setExpectationsFrom): pull expectations from the
7199 Expectations, instead of having it push them to the BuildProgress
7200 (Expectations): move some flags to class-level attributes
7201 (Expectations.__init__): copy per-step times from the
7203 (Expectations.expectedBuildTime): new method for per-build ETA
7205 * buildbot/status/event.py (Logfile): move some flags to
7206 class-level attributes
7207 (Logfile.logProgressTo): better method name, let step set the
7208 progress axis name (instead of always being "output")
7210 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
7211 times directly, rather than depending upon the (possibly missing)
7212 .progress object. Use 'None' to indicate "not started/finished
7214 (BuildStepStatus.getExpectations): oops, return the full list of
7216 (BuilderStatus._buildFinished): append finished builds to .builds
7218 * buildbot/process/step.py (BuildStep): add separate .useProgress
7219 flag, since empty .progressMetrics[] still implies that time is a
7221 (CVS): set up the cmd in __init__, instead of waiting for start()
7223 * buildbot/process/base.py (Build.startBuild): disable the 'when'
7224 calculation, this will eventually turn into a proper sourceStamp
7225 (Build.setupBuild): tell the Progress to load from the Expectations,
7226 instead of having the Expectations stuff things into the Progress
7227 (Build.buildException): add a build-level errback to make sure the
7228 build's Deferred fires even in case of exceptions
7230 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
7232 * buildbot/process/builder.py (Builder.forceBuild): convey the
7233 reason instead of creating a fake Change
7235 * docs/examples/twisted_master.cfg: update to match reality
7237 * buildbot/test/test_config.py, buildbot/test/test_process.py:
7238 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
7239 fix or remove broken/breaking tests
7241 * buildbot/status/event.py (Logfile.__len__): remove evil method
7243 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
7244 missing .build, for test convenience
7246 * buildbot/process/step_twisted.py: import fixes
7248 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
7250 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
7251 .statusbag reference
7253 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
7254 connection at shutdown, and stop it from reconnecting
7256 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
7257 chase down remote-execution bugs
7259 * buildbot/process/step.py: more fixes, remove
7260 BuildStep.setStatus()
7261 * buildbot/status/builder.py: move setStatus() functionality into
7263 * buildbot/status/event.py: minor fixes
7265 2004-08-03 Brian Warner <warner@lothar.com>
7267 * buildbot/process/base.py, buildbot/process/builder.py
7268 * buildbot/process/step.py, buildbot/status/builder.py
7269 * buildbot/status/event.py, buildbot/test/test_run.py:
7270 fix status delivery, get a basic test case working
7271 * buildbot/master.py: finish implementing basic status delivery,
7272 temporarily disable HTML/IRC/PB status sources
7274 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
7276 * buildbot/status/progress.py (BuildProgress): remove dead code
7278 * buildbot/interfaces.py
7279 * buildbot/process/base.py, buildbot/process/builder.py
7280 * buildbot/process/step.py, buildbot/process/step_twisted.py
7281 * buildbot/status/builder.py: Complete overhaul of the all
7282 status-delivery code, unifying all types of status clients (HTML,
7283 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
7284 look like. This commit is a checkpointing of the work-in-progress:
7285 the input side is mostly done (Builders/Builds sending status
7286 to the BuilderStatus/BuildStatus objects), but the output side has
7287 not yet been started (HTML resources querying BuilderStatus
7288 objects). Things are probably very broken right now and may remain
7289 so for several weeks, I apologize for the disruption.
7291 * buildbot/status/event.py: add a setHTML method to use pre-rendered
7292 HTML as the log's contents. Currently used for exception tracebacks.
7293 * buildbot/status/progress.py: minor spelling changes
7295 2004-08-02 Brian Warner <warner@lothar.com>
7297 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
7298 in mozilla. Also added stylesheets copied from Twisted's docs.
7299 Remember that these files are meant to be run through Lore first.
7300 Thanks to Philipp Frauenfelder for the fixes.
7301 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
7302 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
7303 * docs/template.tpl: added a Lore template
7305 2004-07-29 Brian Warner <warner@lothar.com>
7307 * buildbot/interfaces.py: revamp status delivery. This is the
7308 preview: these are the Interfaces that will be provided by new
7309 Builder code, and to which the current HTML/IRC/PB status
7310 displayers will be adapted.
7312 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
7313 on the SlaveBuilder, not the Bot.
7314 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
7316 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
7317 set .usePTY on the FakeSlaveBuilder
7319 2004-07-25 Brian Warner <warner@lothar.com>
7321 * buildbot/changes/freshcvs.py: add some debug log messages
7322 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
7323 disabled 'setFilter' syntax
7324 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
7325 don't end with a slash
7327 * buildbot/process/base.py (Builder._pong_failed): add TODO note
7329 * setup.py: bump to 0.5.0+ while between releases
7331 2004-07-23 Brian Warner <warner@lothar.com>
7333 * setup.py (version): Releasing buildbot-0.5.0
7335 2004-07-23 Brian Warner <warner@lothar.com>
7337 * README: update for 0.5.0 release
7339 * NEWS: update for 0.5.0 release
7341 2004-07-22 Brian Warner <warner@lothar.com>
7343 * buildbot/slavecommand.py (ShellCommand): make usePTY a
7344 mktap-time configuration flag (--usepty=1, --usepty=0)
7345 * buildbot/bot.py: same
7347 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
7348 an 'info' directory being unwanted
7350 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
7351 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
7352 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
7353 and earlier), use a FreshCVSSourceOldcred instead.
7354 (test): simple test routine: connect to server, print changes
7356 * buildbot/changes/changes.py (Change.getTime): make it possible
7357 to print un-timestamped changes
7359 * buildbot/master.py (makeApp): delete ancient dead code
7360 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
7361 * buildbot/test/test_config.py (testFindConfigFile): test it
7363 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
7364 instead of win32 one
7367 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
7368 now takes a dictionary instead of a tuple. See docs/config.xhtml for
7371 * buildbot/process/base.py (Builder.__init__): change constructor
7372 to accept a dictionary of config data, rather than discrete
7373 name/slave/builddir/factory arguments
7375 * docs/examples/twisted_master.cfg: update to new syntax
7376 * docs/examples/glib_master.cfg: same
7377 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
7378 rough tests of the new syntax
7381 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
7382 to be an int, which means "run a web.distrib sub-server on a TCP
7383 port". This lets you publish the buildbot status page to a remote
7384 twisted.web server (using distrib.ResourceSubscription). Also
7385 rename the local attributes used to hold these web things so
7386 they're more in touch with reality.
7387 * buildbot/test/test_web.py: test webPortnum and webPathname
7388 * docs/config.xhtml: document this new use of webPathname
7390 * docs/config.xhtml: new document, slightly ahead of reality
7392 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
7393 'prefix' handling: treat it as a simple string to check with
7394 .startswith, instead of treating it as a directory. This allows
7395 sub-directories to be used. If you use prefix=, you should give it
7396 a string that starts just below the CVSROOT and ends with a slash.
7397 This prefix will be stripped from all filenames, and filenames
7398 which do not start with it will be ignored.
7400 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
7402 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
7403 and --exclude (inverse of --include). SVN post-commit hooks
7404 now have total control over which changes get sent to buildbot and which
7407 2004-07-10 Brian Warner <warner@lothar.com>
7409 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
7410 test case to match new API
7412 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
7413 which crashed HTML display when self.entries=[] (needed to
7414 distinguish between [], which means "no entries yet", and None,
7415 which means "the entries have been swapped out to disk, go fetch
7418 2004-07-04 Brian Warner <warner@lothar.com>
7420 * buildbot/process/step_twisted.py (countFailedTests): Count
7421 skips, expectedFailures, and unexpectedSuccesses. Start scanning
7422 10kb from the end because any import errors are wedged there and
7423 they would make us think the test log was unparseable.
7424 (RunUnitTests.finishStatus): add skip/todo counts to the event box
7426 2004-06-26 Brian Warner <warner@lothar.com>
7428 * buildbot/process/step_twisted.py (RemovePYCs): turn the
7429 delete-*.pyc command into an actual BuildStep, so we can label it
7431 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7432 (FullTwistedBuildFactory): same
7434 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
7436 * contrib/fakechange.py: Add an errback when sending the fake
7437 change, so we know it didn't work.
7439 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
7441 * buildbot/process/step_twisted.py: Delete *.pyc files before
7442 calling trial, so it doesn't catch any old .pyc files whose .py
7443 files have been moved or deleted.
7445 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
7446 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
7447 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
7448 instead of ["twisted.test"], so that the end result is "trial -R
7451 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
7452 regular expression to match filenames that should be ignored when
7453 changed. Also add a --revision parameter that specifies the
7454 revision to examine, which is useful for debugging.
7456 2004-06-25 Brian Warner <warner@lothar.com>
7458 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
7459 summary of warnings (like DeprecationWarnings), next to the
7462 2004-05-13 Brian Warner <warner@lothar.com>
7464 * docs/examples/twisted_master.cfg: enable the win32 builder, as
7465 we now have a w32 build slave courtesy of Mike Taylor.
7467 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
7468 so broken. Fixed a race condition that tripped up interlocked
7469 builds and caused the status to be stuck at "Interlocked" forever.
7470 The twisted buildbot's one interlocked build just so happened to
7471 never hit this case until recently (the feeding builds both pass
7472 before the interlocked build is attempted.. usually it has to wait
7474 (Builder._pong_failed): fix method signature
7476 * setup.py: bump to 0.4.3+ while between releases
7478 2004-04-30 Brian Warner <warner@lothar.com>
7480 * setup.py (version): Releasing buildbot-0.4.3
7482 2004-04-30 Brian Warner <warner@lothar.com>
7484 * MANIFEST.in: add the doc fragments in docs/*.xhtml
7486 * README: update for 0.4.3 release
7488 * NEWS: update for 0.4.3 release
7490 * buildbot/master.py (BuildMaster.__getstate__): make sure
7491 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
7493 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
7494 .trial as a class attribute, for upgrade from 0.4.2
7496 * buildbot/changes/changes.py (Change.links): add .links for
7499 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
7500 .textWatchers and .htmlWatchers at save time, since they are both
7501 volatile, should allow smooth 0.4.2 upgrade
7503 * buildbot/process/step.py (CVS.finishStatus): catch failed
7504 CVS/SVN commands so we can make the status box red
7506 2004-04-29 Brian Warner <warner@lothar.com>
7508 * buildbot/changes/freshcvs.py
7509 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7510 code to do setFilter(), which tells the freshcvs daemon to not
7511 send us stuff that we're not interested in. I will uncomment it
7512 when a new version of CVSToys is available in which setFilter()
7513 actually works, and I get a chance to test it better.
7515 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7517 * buildbot/master.py (Dispatcher): use a registration scheme
7518 instead of hardwired service names
7519 (BuildMaster): keep track of the Dispatcher to support
7522 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7523 PBChangeSource class instead of having it be an undocumented
7524 internal feature of the ChangeMaster. Split out the code into a
7526 * buildbot/changes/pb.py (PBChangeSource): same
7527 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7529 * docs/{factories|sources|steps}.xhtml: document some pieces
7531 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7532 using FCMaildirSource
7533 (f23osx): update OS-X builder to use python2.3, since the slave
7534 was updated to Panther (10.3.3)
7536 2004-03-21 Brian Warner <warner@lothar.com>
7538 * buildbot/process/process_twisted.py: factor out doCheckout, change
7539 to use SVN instead of CVS
7541 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7542 an SVN subclass easier
7543 (BasicSVN): subclass which uses Subversion instead of CVS
7545 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7547 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7549 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7551 2004-02-25 Brian Warner <warner@lothar.com>
7553 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7554 is now either a list (which is passed to spawnProcess directly) or
7555 a string (which gets passed to /bin/sh -c). This removes the useSH
7556 flag and the ArgslistCommand class. Also send status header at the
7557 start and end of each command, instead of having the master-side
7559 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7560 -r'. Update to use list-based arguments.
7561 (SVNFetch): use list-based arguments, use ['dir'] argument to
7563 * buildbot/test/test_steps.py (Commands): match changes
7565 * buildbot/process/step.py (InternalShellCommand.words): handle
7567 (SVN): inherit from CVS, cleanup
7569 * buildbot/status/event.py (Logfile.content): render in HTML, with
7570 stderr in red and headers (like the name of the command we're
7571 about to run) in blue. Add link to a second URL (url + "?text=1")
7572 to get just stdout/stderr in text/plain without markup. There is
7573 still a problem with .entries=None causing a crash, it seems to occur
7574 when the logfile is read before it is finished.
7576 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7577 timeout to the keepalives, and use it to explicitly do a
7578 loseConnection instead of waiting for TCP to notice the loss. This
7579 ought to clear up the silent-lossage problem.
7580 (unsafeTracebacks): pass exception tracebacks back to the master,
7581 makes it much easier to debug problems
7583 2004-02-23 Brian Warner <warner@lothar.com>
7585 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7586 the whole command to /bin/sh instead of execve [Johan Dahlin]
7587 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7588 '-r HEAD' [Johan Dahlin]
7589 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7591 * buildbot/changes/changes.py (Change): add links= argument, add
7592 asHTML method [Johan Dahlin]. Modified to make a bit more
7593 XHTMLish. Still not sure how to best use links= .
7595 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7596 Change.asHTML to display the change, not asText
7598 * buildbot/status/html.py (StatusResourceBuilder): web button to
7601 * buildbot/test/test_run.py: test to actually start a buildmaster
7604 * MANIFEST.in: bring back accidentally-dropped test helper files
7606 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7607 that require cvstoys if it is not installed
7609 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7610 values of "bin/trial" [Dave Peticolas]
7611 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7612 tests passed" when we didn't happen to run any tests
7614 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7615 flunkOnFailure [Johan Dahlin]
7617 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7618 multiple instances of the same Step class by suffixing "_2", etc,
7619 to the name until it is unique. This name needs to be unique
7620 because it is used as a key in the dictionary that tracks build
7622 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7625 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7627 2004-01-14 Brian Warner <warner@lothar.com>
7629 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7630 kicked from a channel, log it
7632 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7633 something over whatever IRC channels the buildmaster is currently
7634 connected to. Added to try and track down a problem in which the
7635 master thinks it is still connected but the IRCd doesn't see it. I
7636 used a styles.Versioned this time, so hopefully users won't have
7637 to rebuild their .tap files this time.
7638 * contrib/debug.glade: add a "Poke IRC" button
7639 * contrib/debugclient.py: same
7641 * setup.py: bump to 0.4.2+ while between releases
7643 2004-01-08 Brian Warner <warner@lothar.com>
7645 * setup.py (version): Releasing buildbot-0.4.2
7647 2004-01-08 Brian Warner <warner@lothar.com>
7649 * NEWS: update for 0.4.2 release
7651 * README: document how to run the tests, now that they all pass
7653 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7655 * buildbot/process/step.py (CVS): add a global_options= argument,
7656 which lets you set CVS global options for the command like "-r"
7657 for read-only checkout, or "-R" to avoid writing in the
7659 * buildbot/slavecommand.py (CVSCommand): same
7661 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7662 testing easier (it is turned off when testing, to avoid the
7665 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7666 to make it easier to test: break generateStepID() out to a
7667 separate function, only update statusbag if it exists.
7668 (ShellCommands): create useful text for dict-based commands too.
7670 * test/*, buildbot/test/*: move unit tests under the buildbot/
7672 * setup.py (packages): install buildbot.test too
7674 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7675 * buildbot/test/test_steps.py: fix it, tests pass now
7677 2004-01-06 Brian Warner <warner@lothar.com>
7679 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7680 freshcvs mail uses a slightly different syntax for new
7681 directories. Update parser to handle either.
7682 * test/test_mailparse.py (Test1.testMsg9): test for same
7684 2003-12-21 Brian Warner <warner@lothar.com>
7686 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7687 'warnOnWarnings' so that lintian errors mark the build orange
7689 2003-12-17 Brian Warner <warner@lothar.com>
7691 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7692 messages emitted by Bonsai, contributed by Stephen Davis.
7694 * test/*: moved all tests to use trial instead of unittest. Some
7695 still fail (test_steps, test_slavecommand, and test_process).
7697 * setup.py (version): bump to 0.4.1+ while between releases
7699 2003-12-09 Brian Warner <warner@lothar.com>
7701 * setup.py (version): Releasing buildbot-0.4.1
7703 2003-12-09 Brian Warner <warner@lothar.com>
7705 * NEWS: update for 0.4.1 release
7707 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7708 freebsd builder code a little bit
7710 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7711 don't try to compare attributes of different classes
7712 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7713 (MaildirSource.messageReceived): fix Change delivery
7715 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7716 into the config file's namespace before loading it, like the
7717 documentation claims it does
7718 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7719 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7720 daemon comes back online
7722 2003-12-08 Brian Warner <warner@lothar.com>
7724 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7725 so the example will work with online=0 as well
7727 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7728 fix the __implements__ line
7730 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7731 class a twisted.application.service.Service, use startService to
7734 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7735 directory fd instead of simple open(). I'm sure this used to work,
7736 but the current version of python refuses to open directories with
7739 2003-12-05 Brian Warner <warner@lothar.com>
7741 * setup.py (version): bump to 0.4.0+ while between releases
7743 2003-12-05 Brian Warner <warner@lothar.com>
7745 * setup.py (version): Releasing buildbot-0.4.0
7747 2003-12-05 Brian Warner <warner@lothar.com>
7749 * docs/examples/glib_master.cfg: replace old sample scripts with
7750 new-style config files
7751 * MANIFEST.in: include .cfg files in distribution tarball
7753 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7754 implement a dummy method to avoid the exception that occurs when
7755 freshcvs sends this to us.
7757 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7758 removed the method, as it broke reconnection. Apparently
7759 stopFactory is called each time the connection attempt fails. Must
7761 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7762 attribute before serialization, since without stopFactory the
7763 reconnect timer may still be active and they aren't serializable.
7765 * test/test_mailparse.py (ParseTest): test with 'self' argument
7767 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7768 argument, as these "functions" are invoked like methods from class
7769 attributes and therefore always get an instance as the first
7772 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7773 message: thanks to Stephen Davis for the catch
7775 2003-12-04 Brian Warner <warner@lothar.com>
7777 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7778 twisted's standard ReconnectingClientFactory. Handles both oldcred
7779 and newcred connections. Also has a bug-workaround for
7780 ReconnectingClientFactory serializing its connector when it
7783 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7784 pbutil. Replace makeApp stuff with proper newcred/mktap
7785 makeService(). Don't serialize Ephemerals on shutdown.
7787 * buildbot/changes/changes.py (ChangeMaster): make it a
7788 MultiService and add the sources as children, to get startService
7789 and stopService for free. This also gets rid of the .running flag.
7791 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7792 new pbutil, turn into a TCPClient at the same time (to get
7793 startService for free). Two variants exist: FreshCVSSourceOldcred
7794 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7795 yet, but when it does, we'll be ready).
7796 (FreshCVSSource.notify): handle paths which are empty after the
7797 prefix is stripped. This only happens when the top-level (prefix)
7798 directory is added, at the very beginning of a Repository's life.
7800 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7801 Now the only reconnecting code is in the factory where it belongs.
7802 (Builder.unsubscribe): unregister the disconnect callback when we
7803 delete the builder on command from the master (i.e. when the
7804 buildmaster is reconfigured and that builder goes away). This
7805 fixes a multiple-delete exception when the status client is shut
7807 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7810 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7811 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7813 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7815 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7816 a list of globs (ugh). The testdir will be searched for files
7817 named *.tests and run the tests in the order specified in each of
7818 those files. This allows for "dependancies" between tests to be
7821 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7822 argument to pass to run_maxq.py, instead of a glob.
7824 2003-10-17 Brian Warner <warner@lothar.com>
7826 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7827 files that live in the sandbox
7829 2003-10-15 Brian Warner <warner@lothar.com>
7831 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7832 spelling error in "docs" count-warnings output
7833 (HLint.start): stupid thinko meant .xhtml files were ignored
7835 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7836 tests now that cReactor is banished to the sandbox
7838 2003-10-10 Brian Warner <warner@lothar.com>
7840 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7841 scheme: now .xhtml are sources and .html are generated
7843 2003-10-08 Brian Warner <warner@lothar.com>
7845 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7846 we were ignoring the 'randomly' parameter.
7848 2003-10-01 Brian Warner <warner@lothar.com>
7850 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7851 posix, to kill sub-children of aborted slavecommands.
7853 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7854 Clean up initialization: lastBuildStatus remains None until the
7855 first build has been completed.
7857 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7858 None as a lastBuildStatus
7859 * buildbot/clients/gtkPanes.py: same
7861 * buildbot/status/client.py (StatusClientService): keep
7862 BuilderStatus objects in self.statusbags . These objects now live
7863 here in the StatusClientService and are referenced by the Builder
7864 object, rather than the other way around.
7865 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7866 * buildbot/process/base.py (Builder): same
7867 * test/test_config.py (ConfigTest.testBuilders): same
7869 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7870 an existing builder, leave the statusbag alone. This will preserve the
7873 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7874 hook. This will probably go away in favor of a class in upcoming
7877 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7878 serviceName from newcred FreshCVSNotifiee setup
7880 2003-09-29 Brian Warner <warner@lothar.com>
7882 * buildbot/process/process_twisted.py: switch to new reactor
7884 * docs/examples/twisted_master.cfg: same
7886 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7888 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7889 botmaster reference instead of the oldapp service lookup
7891 * buildbot/master.py (BuildMaster.__init__): give the
7892 StatusClientService a reference to the botmaster to make it easier to
7895 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7897 * buildbot/status/html.py (Box.td): escape hreffy things so you
7898 can have spaces in things like builder names
7899 (StatusResourceBuilder.body)
7900 (WaterfallStatusResource.body)
7901 (WaterfallStatusResource.body0): same
7903 2003-09-25 Brian Warner <warner@lothar.com>
7905 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7906 rearrange the builder list when adding or removing builders: keep
7907 them in the order the user requested.
7908 * test/test_config.py (ConfigTest.testBuilders): verify it
7910 * contrib/debug.glade: give the debug window a name
7912 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7913 now wait on multiple interlocks. Fix code relating to that.
7914 (Builder.checkInterlocks): same
7915 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7917 * buildbot/master.py (BuildMaster.loadConfig): move from
7918 deprecated pb.BrokerFactory to new pb.PBServerFactory
7919 * test/test_config.py (ConfigTest.testWebPathname): same
7921 * docs/examples/twisted_master.cfg: fix interlock declaration
7923 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7924 Interlocks to their Builders into interlock.py .
7925 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7927 * test/test_config.py (ConfigTest.testInterlocks): validate
7930 * buildbot/process/base.py (Builder.__init__): better comments
7931 * buildbot/process/interlock.py (Interlock.__repr__): same
7932 (Interlock.deactivate): add .active flag, move the code that
7933 attaches/detaches builders into the Interlock
7935 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7937 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7938 tests using the new run_maxq.py script, and reporting failures by
7941 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7942 tests, reporting their success or failure in a buildbot-friendly
7945 2003-09-24 Brian Warner <warner@lothar.com>
7947 * docs/examples/twisted_master.cfg: example of a new-style config
7948 file. This lives in the buildmaster base directory as
7951 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7952 button to make the master re-read its config file
7954 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7955 buildmaster configuration from a file. This file can be re-read
7956 later, and the buildmaster will update itself to match the new
7957 desired configuration. Also use new Twisted Application class.
7958 * test/Makefile, test/test_config.py: unit tests for same
7960 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7961 FreshCVSSources comparable, to support reload.
7962 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7964 * buildbot/process/base.py (Builder): make them comparable, make
7965 Interlocks easier to attach, to support reload. Handle
7966 re-attachment of remote slaves.
7967 * buildbot/process/interlock.py (Interlock): same
7969 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7970 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7971 buildmaster taps are now constructed with mktap.
7972 * buildbot/status/client.py (StatusClientService): same
7974 * buildbot/status/words.py: move to new Services, add support to
7975 connect to multiple networks, add reload support, allow nickname
7976 to be configured on a per-network basis
7978 2003-09-20 Brian Warner <warner@lothar.com>
7980 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7981 the freebsd builder, now that the machine has been upgraded and no
7982 longer has python2.2
7984 * setup.py (version): bump to 0.3.5+ while between releases
7986 2003-09-19 Brian Warner <warner@lothar.com>
7988 * setup.py (version): Releasing buildbot-0.3.5
7990 2003-09-19 Brian Warner <warner@lothar.com>
7992 * NEWS: add post-0.3.4 notes
7994 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7996 * MANIFEST.in: add contrib/*
7998 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7999 use a remote root now: cvs.twistedmatrix.com
8001 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
8003 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
8004 compatibility with old servers
8005 (FreshCVSSource.start): and provide a way to use it
8006 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
8008 * docs/examples/twisted_master.py (twisted_app): update to new
8010 (twisted_app): listen on new ~buildbot socket
8011 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
8013 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
8014 to reduce cvs bandwidth (update instead of full checkout)
8016 2003-09-11 Brian Warner <warner@lothar.com>
8018 * contrib/fakechange.py: demo how to connect to the changemaster
8019 port. You can use this technique to submit changes to the
8020 buildmaster from source control systems that offer a hook to run a
8021 script when changes are committed.
8023 * contrib/debugclient.py: tool to connect to the debug port. You
8024 can use it to force builds, submit fake changes, and wiggle the
8027 * buildbot/master.py: the Big NewCred Reorganization. Use a single
8028 'Dispatcher' realm to handle all the different kinds of
8029 connections and Perspectives: buildslaves, the changemaster port,
8030 the debug port, and the status client port. NewCredPerspectives
8031 now have .attached/.detached methods called with the remote 'mind'
8032 reference, much like old perspectives did. All the pb.Services
8033 turned into ordinary app.ApplicationServices .
8034 (DebugService): went away, DebugPerspectives are now created
8035 directly by the Dispatcher.
8036 (makeApp): changed interface a little bit
8038 * buildbot/changes/changes.py: newcred
8039 * buildbot/status/client.py: newcred
8041 * buildbot/clients/base.py: newcred client side changes
8042 * buildbot/bot.py: ditto
8044 * docs/examples/glib_master.py: handle new makeApp() interface
8045 * docs/examples/twisted_master.py: ditto
8047 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
8048 base newcred Perspectives on. This should go away once Twisted
8049 itself provides something sensible.
8052 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
8054 * contrib/svn_buildbot.py: A program that you can call from your
8055 SVNREPO/hooks/post-commit file that will notify a BuildBot master
8056 when a change in an SVN repository has happened. See the top of
8057 the file for some minimal usage info.
8059 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8061 * buildbot/slavecommand.py (ArglistCommand): Add new
8062 ArglistCommand that takes an argument list rather than a string as
8063 a parameter. Using a st.split() for argv is very bad.
8065 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
8066 update to a particular revision rather than always checking out
8067 (still not very smart about it, there may be cases where the
8068 checkout becomes inconsistent).
8070 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
8072 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
8073 SVN fetch support. It can checkout (not update!) a specified
8074 revision from a specified repository to a specified directory.
8076 * buildbot/status/progress.py (Expectations.update): Fix an
8077 obvious bug (apparently created by the change described in the
8078 previous ChangeLog message) by moving a check to *after* the
8079 variable it checks is defined.
8082 2003-09-08 Brian Warner <warner@lothar.com>
8084 * buildbot/status/progress.py (Expectations.update): hack to catch
8085 an exception TTimo sees: sometimes the update() method seems to
8086 get called before the step has actually finished, so the .stopTime
8087 is not set, so no totalTime() is available and we average None
8088 with the previous value. Catch this and just don't update the
8089 metrics, and emit a log message.
8091 2003-08-24 Brian Warner <warner@lothar.com>
8093 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
8094 parameter to set copydir='original' in CVS commands.
8096 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
8098 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
8099 which tells the command to maintain a separate original-source CVS
8100 workspace. For each build, this workspace will be updated, then
8101 the tree copied into a new workdir. This reduces CVS bandwidth
8102 (from a full checkout to a mere update) while doubling the local
8103 disk usage (to keep two copies of the tree).
8105 2003-08-21 Brian Warner <warner@lothar.com>
8107 * buildbot/status/event.py (Logfile.addEntry): if the master web
8108 server dies while we're serving a page, request.write raises
8109 pb.DeadReferenceError . Catch this and treat it like a
8110 notifyFinish event by dropping the request.
8112 2003-08-18 Brian Warner <warner@lothar.com>
8114 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
8115 (instead of blowing up) if a force-build command is given without
8118 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
8119 don't blow up if there aren't yet any Changes in the list
8121 2003-08-02 Brian Warner <warner@lothar.com>
8123 * buildbot/bot.py (updateApplication): don't set the .tap name,
8124 since we shouldn't assume we own the whole .tap file
8126 * buildbot/bb_tap.py (updateApplication): clean up code, detect
8127 'mktap buildbot' (without a subcommand) better
8129 2003-07-29 Brian Warner <warner@lothar.com>
8131 * buildbot/status/words.py
8132 (IrcStatusFactory.clientConnectionLost): when we lose the
8133 connection to the IRC server, schedule a reconnection attempt.
8135 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
8136 use shutil.rmtree instead of forking off an "rm -rf" command.
8137 rmtree may take a while and will block until it finishes, so we
8138 use "rm -rf" if available.
8140 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
8141 freebsd buildslave badly
8143 * setup.py (version): bump to 0.3.4+ while between releases
8145 2003-07-28 Brian Warner <warner@lothar.com>
8147 * setup.py (version): Releasing buildbot-0.3.4
8149 2003-07-28 Brian Warner <warner@lothar.com>
8151 * NEWS: update in preparation for release
8153 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
8154 process.signalProcess instead of os.kill, to improve w32
8157 * docs/examples/twisted_master.py (twisted_app): turn off
8158 win32eventreactor: the tests hang the buildslave badly
8160 * buildbot/process/base.py (Build.buildFinished): update ETA even on
8161 failed builds, since usually the failures are consistent
8163 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8164 add compileOpts/compileOpts2 to reactors build
8166 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
8167 (twisted_app): use both default and win32eventreactor on w32 build.
8168 Use both default and kqreactor on freebsd build.
8170 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8171 add compileOpts2, which is put after the build_ext argument. w32
8172 needs "-c mingw32" here.
8174 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
8175 touch .acqpath, it goes away in recent Twisted releases
8177 * docs/examples/twisted_master.py (twisted_app): use "python" for
8178 the w32 buildslave, not "python2.2"
8180 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
8181 the directory exists.. should hush an exception under w32
8183 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
8184 ProcessTerminated -provided values for signal and exitCode rather
8185 than parsing the unix status code directly. This should remove one
8186 more roadblock for a w32-hosted buildslave.
8188 * test/test_mailparse.py: add test cases for Syncmail parser
8190 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
8191 temporary compatibility import. Note! Start importing
8192 FCMaildirSource from changes.mail instead of changes.freshcvsmail
8194 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
8196 2003-07-27 Brian Warner <warner@lothar.com>
8198 * NEWS: started adding new features
8200 * buildbot/changes/mail.py: start work on Syncmail parser, move
8201 mail sources into their own file
8203 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
8204 as implementing IChangeSource
8205 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
8207 * buildbot/interfaces.py: define the IChangeSource interface
8209 2003-07-26 Brian Warner <warner@lothar.com>
8211 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
8213 2003-06-25 Brian Warner <warner@lothar.com>
8215 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
8218 2003-06-17 Brian Warner <warner@lothar.com>
8220 * buildbot/status/words.py: clean up method usage to avoid error
8221 in silly IRC command
8222 (IrcStatusBot.emit_status): round off seconds display
8224 * buildbot/process/base.py (Build): delete the timer when saving
8225 to the .tap file, and restore it (if it should still be running)
8226 upon restore. This should fix the "next build in -34 seconds"
8227 messages that result when the master is restarted while builds are
8228 sitting in the .waiting slot. If the time for the build has
8229 already passed, start it very soon (in 1 second).
8231 * buildbot/status/words.py: more silly commands
8233 * README (REQUIREMENTS): add URLs to all required software
8235 * buildbot/status/words.py ('last'): mention results of, and time
8238 2003-05-28 Brian Warner <warner@lothar.com>
8240 * buildbot/status/words.py: add 'last' command
8241 (IrcStatusBot.emit_status): add current-small text to 'status' output
8243 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
8244 (twisted_app): remove spaces from OS-X builder name
8246 * buildbot/master.py (makeApp): add knob to turn on IRC bot
8247 * buildbot/status/words.py: IRC bot should actually be useful now
8249 2003-05-23 Brian Warner <warner@lothar.com>
8251 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
8252 "slave information" from $(slavedir)/info/* . These files are
8253 maintained by the slave administrator, and describe the
8254 machine/environment that is hosting the slave. Information from
8255 them is put into the "Builder" HTML page. Still need to establish
8256 a set of well-known filenames and meanings for this data: at the
8257 moment, *all* info/* files are sent to the master, but only
8258 'admin' and 'host' are used on that end.
8259 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
8260 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
8261 * buildbot/master.py (BotPerspective.got_info): ditto
8263 2003-05-22 Brian Warner <warner@lothar.com>
8265 * setup.py (version): bump version to 0.3.3+ while between releases
8267 2003-05-21 Brian Warner <warner@lothar.com>
8269 * setup.py: Releasing buildbot-0.3.3
8271 2003-05-21 Brian Warner <warner@lothar.com>
8273 * NEWS: 0.3.3 news items
8275 * README: describe --keepalive and life behind a NAT box
8277 * buildbot/bot.py (Bot.connected): implement application-level
8278 keepalives to deal with NAT timeouts, turn them on with
8279 --keepalive option or when SO_KEEPALIVE doesn't work.
8281 * buildbot/master.py (BotPerspective): accept keepalives silently
8283 * buildbot/process/base.py (Build.buildException): CopiedFailures
8284 don't carry as much information as local ones, so don't try to
8285 create a big HTMLized version of them.
8287 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
8288 log file when step fails due to an exception, such as when the slave
8291 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
8292 --testmodule argument instead of grepping for test-case-name tags
8293 ourselves. Remove FindUnitTests code.
8294 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
8296 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
8298 2003-05-16 Brian Warner <warner@lothar.com>
8300 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
8301 argument to allow things like CFLAGS=-O0 to be passed without relying
8302 upon /bin/sh processing on the slave.
8304 * buildbot/process/step.py (InternalShellCommand.start): send
8306 * buildbot/slavecommand.py (ShellCommand.start): create argv with
8307 'split' instead of letting /bin/sh do it. This should also remove
8308 the need for /bin/sh on the buildslave, making it more likely to
8311 * buildbot/status/html.py: html-escape text in blamelist.
8312 Add "force build" button to the Builder page.
8314 * buildbot/process/step_twisted.py (countFailedTests): look at
8315 last 1000 characters for status line, as import errors can put it
8316 before the -200 point.
8318 2003-05-15 Brian Warner <warner@lothar.com>
8320 * docs/examples/twisted_master.py: use clobber=0 for remote builds
8322 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8323 make 'clobber' a parameter, so it is possible to have builds which
8324 do full tests but do a cvs update instead of hammering the CVS
8325 server with a full checkout each build
8327 * buildbot/process/step.py (InternalShellCommand): bump default
8328 timeout to 20 minutes
8330 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
8331 the master to trigger a build. Run it via manhole.
8333 * buildbot/master.py (BotPerspective.perspective_forceBuild):
8334 allow slaves to trigger any build that they host, to make life
8335 easier for slave admins who are testing out new build processes
8337 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
8338 don't flunk cReactor or qtreactor on failure, since they fail alot
8339 these days. Do warnOnFailure instead.
8341 * buildbot/process/base.py: change Builder.buildable from a list
8342 into a single slot. When we don't have a slave, new builds (once
8343 they make it past the timeout) are now merged into an existing
8344 buildable one instead of being queued. With this change, a slave
8345 which has been away for a while doesn't get pounded with all the
8346 builds it missed, but instead just does a single build.
8348 2003-05-07 Brian Warner <warner@lothar.com>
8350 * setup.py (version): bump version to 0.3.2+ while between releases
8352 2003-05-07 Brian Warner <warner@lothar.com>
8354 * setup.py: Releasing buildbot-0.3.2
8356 2003-05-07 Brian Warner <warner@lothar.com>
8358 * setup.py: fix major packaging error: include subdirectories!
8360 * NEWS: add changes since last release
8362 * README (REQUIREMENTS): update twisted/python dependencies
8364 * buildbot/status/builder.py (Builder.startBuild): change
8365 BuildProcess API: now they should call startBuild/finishBuild
8366 instead of pushing firstEvent / setLastBuildStatus. Moving towards
8367 keeping a list of builds in the statusbag, to support other kinds of
8369 (Builder.addClient): send current-activity-small to new clients
8370 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
8373 * buildbot/status/client.py: drop RemoteReferences at shutdown
8375 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
8377 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
8378 more debug messages for remote status client
8380 * buildbot/process/step.py (InternalBuildStep.stepComplete)
8381 (.stepFailed): only fire the Deferred once, even if both
8382 stepComplete and stepFailed are called. I think this can happen if
8383 an exception occurs at a weird time.
8385 * buildbot/status/words.py: work-in-progress: IRC status delivery
8387 2003-05-05 Brian Warner <warner@lothar.com>
8389 * docs/examples/twisted_master.py (twisted_app): hush internal
8390 python2.3 distutils deprecation warnings
8391 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8392 add compileOpts= argument which inserts extra args before the
8393 "setup.py build_ext" command. This can be used to give -Wignore
8394 warnings, to hush some internal python-2.3 deprecation messages.
8396 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
8397 the ['twisted.test'] default test case to make it easier to change
8400 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
8401 * buildbot/clients/gtkPanes.py: ditto
8403 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
8404 arg to collapse RunUnitTestsRandomly into RunUnitTests
8405 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8406 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
8408 * buildbot/status/html.py (StatusResource): shuffle Resources
8409 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
8410 would serve the waterfall display, but the internal links were
8411 only valid on the trailing-slash version. The correct behavior is
8412 for the non-slashed one to serve a Redirect to the slashed one.
8413 This only shows up when the buildbot page is hanging off another
8414 server, like a Twisted-Web distributed server.
8416 * buildbot/status/event.py (Event, RemoteEvent): make Events
8417 pb.Cacheable, with RemoteEvent as the cached version. This removes
8418 a lot of explicit send-an-update code.
8419 * buildbot/status/builder.py (Builder): remove send-update code
8420 * buildbot/status/client.py (ClientBuilder): remove send-update
8421 code, and log errors that occur during callRemote (mostly to catch
8422 InsecureJelly exceptions)
8424 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
8425 run Lore with the same python used in the rest of the build
8427 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
8429 * buildbot/process/step_twisted.py (HLint): accept 'python'
8430 argument. Catch rc!=0 and mark the step as failed. This marks the
8431 build orange ("has warnings").
8432 (RunUnitTestsJelly): move out to step_twisted2.py
8434 * buildbot/util.py (ignoreStaleRefs): add utility function
8436 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
8437 don't fake ETA object, it's too hard to get right
8439 2003-05-02 Brian Warner <warner@lothar.com>
8441 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
8443 2003-05-01 Brian Warner <warner@lothar.com>
8445 * buildbot/status/html.py (StatusResource.body): oops, I was
8446 missing a <tr>, causing the waterfall page to be misrendered in
8447 everything except Galeon.
8449 2003-04-29 Brian Warner <warner@lothar.com>
8451 * docs/examples/twisted_master.py: make debuild use python-2.2
8452 explicitly, now that Twisted stopped supporting 2.1
8454 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
8455 handle tuple results too. I keep forgetting this, which suggests
8456 it needs to be rethought.
8458 * setup.py (setup): bump version to 0.3.1+ while between releases
8460 2003-04-29 Brian Warner <warner@lothar.com>
8462 * setup.py: Releasing buildbot-0.3.1
8464 2003-04-29 Brian Warner <warner@lothar.com>
8466 * README (SUPPORT): add plea to send questions to the mailing list
8468 * NEWS, MANIFEST.in: add description of recent changes
8470 * docs/examples/twisted_master.py: add the code used to create the
8471 Twisted buildmaster, with passwords and such removed out to a
8474 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
8475 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
8476 buildmasters to not require CVSToys be installed.
8477 * README, docs/examples/glib_master: update to match the change
8479 * buildbot/clients/base.py, buildbot/bot.py,
8480 buildbot/changes/changes.py, buildbot/pbutil.py: copy
8481 ReconnectingPB from CVSToys distribution to remove CVSToys
8482 dependency for build slaves and status clients. Buildmasters which
8483 use FreshCVSSources still require cvstoys be installed, of course.
8485 2003-04-25 Brian Warner <warner@lothar.com>
8487 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
8488 runTestsRandomly arg to turn on trial -z
8490 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
8491 experimental code to use trial's machine-parseable output to get
8492 more detailed test results. Still has some major issues.
8493 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
8496 * buildbot/status/builder.py (Builder.setCurrentBuild):
8497 anticipating moving build history into statusbag, not used yet
8499 * buildbot/status/tests.py: code to centralize test results,
8500 doesn't work quite yet
8502 * buildbot/status/event.py (Event): use hasattr("setName") instead
8503 of isinstance for now.. need better long-term solution
8505 * buildbot/status/html.py: Remove old imports
8507 2003-04-24 Brian Warner <warner@lothar.com>
8509 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8510 ignore changes under doc/fun/ and sandbox/
8512 * buildbot/process/step_twisted.py: update pushEvent and friends.
8514 * buildbot/status/html.py (Box.td): replace event.buildername with
8515 event.parent.getSwappableName(). Needs more thought.
8517 * buildbot/status/builder.py (Builder): Replace pushEvent and
8518 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8519 Tell events they are being pruned with event.delete().
8521 * buildbot/process/base.py (Build): Remove Builder status-handling
8522 methods. s/pushEvent/setCurrentActivity/.
8524 * buildbot/process/step.py (BuildStep): clean up status delivery.
8525 Gouse builder.statusbag methods instead of intermediate builder
8526 methods. s/updateLastEvent/updateCurrentActivity/.
8527 s/finalizeLastEvent/finishCurrentActivity/. Use
8528 addFileToCurrentActivity for summaryFunction.
8530 * buildbot/status/event.py (Logfile): put data in a Swappable when
8532 (Event): add more setter methods. Remove .buildername, use .parent
8533 and getSwappableName instead (needs more thought).
8535 * buildbot/util.py (Swappable):
8536 * test/test_swap.py: don't bother setting filename at __init__
8537 time, do it later. Change setFilename args to take parent first,
8538 since it provides the most significant part of the filename.
8540 2003-04-23 Brian Warner <warner@lothar.com>
8542 * buildbot/status/event.py (Logfile.addEntry): append to previous
8545 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8546 anticipating Swappable
8547 (InternalShellCommand.remoteUpdate): split out various log-adding
8548 methods so subclasses can snarf stdout separately
8550 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8551 in anticipation of Swappable build logs
8552 (Builder.testsFinished): anticipating TestResults, still disabled
8554 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8557 * buildbot/status/event.py (Logfile): add (disabled) support for
8558 Swappable, not ready for use yet
8560 * buildbot/util.py (Swappable): object which is swapped out to
8561 disk after some period of no use.
8562 * test/test_swap.py: test buildbot.utils.Swappable
8564 2003-04-14 Brian Warner <warner@lothar.com>
8566 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8567 periodic-build timer. Set the .periodicBuildTime on a builder
8568 instance to some number of seconds to activate it.
8570 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8572 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8573 a way that survives result tuples
8575 2003-04-12 Brian Warner <warner@lothar.com>
8577 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8578 return a dict instead of a tuple: allow summarizers to provide
8579 multiple summaries if they want
8580 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8581 (debuildSummarizer): summarize lintian warnings/errors
8583 2003-04-10 Brian Warner <warner@lothar.com>
8585 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8587 2003-04-09 Brian Warner <warner@lothar.com>
8589 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8590 empty summaries: happens when the tests fail so hard they don't emit
8591 a parseable summary line.
8593 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8594 Allow summaryFunction to return None to indicate no summary should
8597 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8598 writing to stale HTTP requests: notice when they disconnect and
8599 remove the request from the list. Also add CacheToFile from
8600 moshez, will be used later.
8602 2003-04-08 Brian Warner <warner@lothar.com>
8604 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8605 should be an int, not a list of strings
8607 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8608 if we weren't actually connected
8610 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8611 to show the tail end of the trial text output
8613 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8614 hook to summarize the results of a ShellCommand
8616 2003-04-07 Brian Warner <warner@lothar.com>
8618 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8619 twisted test suite code into a single class.
8620 * buildbot/process/process_twisted.py: same
8622 2003-04-04 Brian Warner <warner@lothar.com>
8624 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8626 * README (SLAVE): document use of mktap to create slave .tap file
8627 (REQUIREMENTS): describe dependencies
8629 * buildbot/bb_tap.py, buildbot/plugins.tml:
8630 * buildbot/bot.py (updateApplication): Add mktap support for creating
8631 buildslave .tap files
8633 2003-03-28 Brian Warner <warner@lothar.com>
8635 * buildbot/process/step.py (InternalShellCommand.finished): handle
8636 new tuple result values (fix embarrasing bug that appeared during
8639 2003-03-27 Brian Warner <warner@lothar.com>
8641 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8644 2003-03-25 Brian Warner <warner@lothar.com>
8646 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8647 to overall build status
8648 * buildbot/clients/base.py (Builder): improve event printing
8649 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8650 instead of generic ShellCommand
8651 (Build): Add .stopBuild, use it when slave is detached
8653 * buildbot/process/step.py (Configure,Test): give the steps their
8654 own names and status strings
8656 * buildbot/status/html.py (StatusResource): add "show" argument,
8657 lets you limit the set of Builders being displayed.
8659 2003-03-20 Brian Warner <warner@lothar.com>
8661 * buildbot/process/basic.py: removed
8663 2003-03-19 Brian Warner <warner@lothar.com>
8665 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8666 turn off process-docs by default
8668 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8669 when displaying build information without anything in allBuilds[]
8671 * buildbot/bot.py (makeApp): really take password from sys.argv
8673 2003-03-18 Brian Warner <warner@lothar.com>
8675 * buildbot/bot.py (buildApp): take password from sys.argv
8677 * README: replace with more useful text
8679 * setup.py: add a real one
8680 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8682 * docs/PyCon-2003/: added sources for PyCon paper.
8684 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8685 now Build objects control the process and Builder only handles
8686 slave stuff and distribution of changes/status. A new BuildFactory
8687 class creates Build objects on demand.
8689 Created ConfigurableBuild which takes a list of steps to run. This
8690 makes it a lot easier to set up a new kind of build and moves us
8691 closer to being able to configure a build from a web page.
8693 * buildbot/process/step_twisted.py, process_twisted.py: move to
8694 new model. A lot of code went away.
8696 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8697 send lots of empty progress messages to the client.
8699 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8701 2003-02-20 Brian Warner <warner@lothar.com>
8703 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8705 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8706 Twisted bug that prevented non-pty processes from working just got
8707 fixed, and the bug that leaks ptys is still being investigated.
8709 * buildbot/process/step.py (CVS): send timeout arg to slave
8711 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8712 builders coming and going
8713 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8714 from CVSToys, handle lost-buildmaster
8716 * buildbot/status/client.py (StatusClientService.removeBuilder):
8717 Clean up status client protocol: send builders (with references)
8718 as they are created, rather than sending a list and requiring the
8719 client to figure out which ones are new.
8720 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8721 attempts to force a build on an unknown builder
8723 2003-02-19 Brian Warner <warner@lothar.com>
8725 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8726 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8727 Twisted stops leaking them.
8728 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8729 builder goes to an idle state.
8731 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8732 I figure out why CVS commands hang without them, and/or I fix the
8733 hung-command timeout
8735 2003-02-16 Brian Warner <warner@lothar.com>
8737 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8738 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8739 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8740 GenerateDocs now that they are prefixed with WARNING:.
8742 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8743 use manual href target instead of request.childLink
8745 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8746 display every second, but update the ETA every 5 seconds (or
8747 whenever) as remote_progress messages arrive.
8750 2003-02-12 Brian Warner <warner@lothar.com>
8752 * *: import current sources from home CVS repository
8756 # add-log-time-format: add-log-iso8601-time-string