1 2006-12-11 Brian Warner <warner@lothar.com>
3 * buildbot/twcompat.py (maybeWait): remove this method, now that
4 we no longer maintain compatibility with Twisted<=1.3.0 .
5 Twisted-2.0.0 and later allow trial methods to return Deferreds
7 * buildbot/test/*: remove all uses of maybeWait
9 * buildbot/__init__.py (version): bump to 0.7.5+ while between
11 * docs/buildbot.texinfo: same
13 2006-12-10 Brian Warner <warner@lothar.com>
15 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
16 * docs/buildbot.texinfo: set version to match
18 2006-12-10 Brian Warner <warner@lothar.com>
20 * README (REQUIREMENTS): update for release
21 * NEWS: update for release
22 * buildbot/slave/commands.py (command_version): mention that this
23 version (2.2) was released with buildbot-0.7.5
25 * buildbot/test/test_config.py (StartService.testStartService):
26 inhibit the usual read-config-on-startup behavior, since otherwise
27 the log.err that gets recorded causes the test to fail
29 * buildbot/status/builder.py (LogFile.finish): forget about all
30 subscribers once the log has finished, since after that point
31 we're never going to use them again. This might help free up some
34 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
35 than the old/deprecated gtk.mainquit()
37 2006-12-09 Brian Warner <warner@lothar.com>
39 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
40 better when we can't open the masterdst file
42 * buildbot/scripts/startup.py (Follower._failure): add missing
43 import statement for BuildSlaveDetectedError
45 * buildbot/steps/transfer.py (FileUpload): cleanup
46 (FileDownload): same. Add tests for slave version, add mode=.
47 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
48 (SlaveFileDownloadCommand): same
49 * buildbot/test/test_transfer.py: enhance tests
50 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
53 2006-12-08 Brian Warner <warner@lothar.com>
55 * buildbot/scripts/runner.py (sendchange): halt the reactor on
56 both success *and* failure. Without this, the 'buildbot
57 sendchange' command would hang if it could not contact the
58 buildmaster or deliver the Change, which would generally cause the
59 user's commit/record/checkin command to hang too. Thanks to
60 Christian Unger for the catch.
62 2006-12-06 Brian Warner <warner@lothar.com>
64 * NEWS: update with items for the next release
66 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
67 whimsical example pulled from a punch-drunk email I sent out late
69 (Transferring Files): document some of the other parameters
70 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
71 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
72 * buildbot/test/test_svnpoller.py: same
73 * buildbot/changes/svnpoller.py (SVNPoller): same
75 2006-11-26 Brian Warner <warner@lothar.com>
77 * docs/buildbot.texinfo (Build Properties): remind users that
78 WithProperties must appear in a command= list, not as a top-level
80 * buildbot/steps/shell.py (ShellCommand.start): and assert that
81 we're sending a list or a single string to the RemoteShellCommand
83 * buildbot/scheduler.py (Nightly): Improve docs slightly.
85 * buildbot/scripts/startup.py (start): skip the whole
86 watch-the-logfile thing under windows, since it needs os.fork()
88 * buildbot/scripts/runner.py (restart): remove the old message
89 that got printed after the buildbot was restarted.. it most cases
90 it didn't get printed at the right time anyways
92 2006-11-25 Brian Warner <warner@lothar.com>
94 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
95 follow twistd.log and print lines until the process has started
96 started properly. For the buildmaster, this means until the config
97 file has been parsed and accepted. For the buildslave, this means
98 until we've connected to the master. We give up after 5 seconds in
99 any case. Helpful error messages and troubleshooting suggestions
100 are printed when we don't see a successful startup. This closes the
101 remainder of SF#1517975.
102 * buildbot/scripts/startup.py: moved app startup code to here
103 * buildbot/scripts/logwatcher.py: utility class to follow log
104 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
105 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
106 so the LogWatcher can tell the difference between a buildmaster
109 2006-11-24 Brian Warner <warner@lothar.com>
111 * docs/examples/twisted_master.cfg: update to match the version
112 in use on twistedmatrix.com
113 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
114 was using before stopped working, but 'irc.freenode.net' works
117 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
120 * buildbot/clients/base.py (TextClient.not_connected): upon
121 UnauthorizedLogin failures, remind the user to connect to the
122 PBListener port instead of the slaveport.
123 (TextClient.disconnected): shut down more quietly
124 * docs/buildbot.texinfo (statuslog): add another reminder
126 * buildbot/scripts/runner.py (Options.subCommands): rename
127 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
128 'sighup' as an alias.
129 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
130 reconfig command to follow twistd.log and print all of the lines
131 from the start of the config-file reload to its completion. This
132 should make it a lot easier to discover bugs in the config file.
133 Use --quiet to disable this behavior. This addresses half of
134 SF#1517975, the other half will be to add this same utility to
135 'buildbot start' and 'buildbot restart'.
136 * docs/buildbot.texinfo (Loading the Config File): same
139 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
140 method, it has been deprecated for a long time. Use
141 IBuilderControl.requestBuild instead.
142 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
143 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
144 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
145 * buildbot/test/test_control.py (Force.testForce): same
146 * buildbot/test/test_run.py: use requestBuild instead
148 * buildbot/clients/debug.py: replace 'Force Build' button with
149 'Request Build' (which just adds one to the queue), add Ping
150 Builder, add branch/revision fields to Request Build.
151 * buildbot/clients/debug.glade: same
152 * buildbot/master.py: update interface to match. This creates an
153 incompatibility between new debugclients and old buildmasters.
155 * buildbot/process/builder.py (Builder._attached): delay the call
156 to maybeStartBuild for a reactor turn, to avoid starting a build
157 in the middle of a reconfig (say, if the new Builder uses a new
158 slave which is already connected).
160 2006-11-23 Brian Warner <warner@lothar.com>
162 * buildbot/test/test_transfer.py: appease pyflakes
163 * buildbot/test/test_steps.py: same
165 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
166 keeps pyflakes from finding undefined names
168 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
169 Builder no longer induces a disconnect/reconnect cycle. This means
170 that any builds currently in progress will not be interrupted, and
171 any builds which are queued in the Builder will not be lost. This
172 is implemented by having the new Builder extract the state (i.e.
173 all pending Builds and any desired SlaveBuilders) from the old
175 (BotPerspective): refactor. The BotPerspective no longer keeps
176 track of all the Builders that want to use this slave; instead, it
177 asks the BotMaster each time it needs this list. This removes
178 addBuilder and removeBuilder. Clean up attached() to acquire all
179 the slave's information in a more atomic fashion. updateSlave() is
180 now the way to make sure the slave is using the right set of
181 Builders: just call it after everything else has been
183 (BotMaster): refactor, removing addBuilder/removeBuilder and
184 replacing them with an all-at-once setBuilders() call.
186 * buildbot/test/test_slaves.py (Reconfig): new test case to
187 exercise this functionality
188 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
189 * buildbot/slave/commands.py (WaitCommand): same
191 * docs/buildbot.texinfo (Loading the Config File): document the
194 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
195 SlaveBuilder to have its parent Builder changed.
196 (SlaveBuilder.isAvailable): new method to give access to state,
197 which is now a private attribute
198 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
199 the SlaveBuilder about how it is being used. These methods update
200 its internal state. buildFinished() is now the place that invokes
201 maybeStartBuild() on its parent Builder.
202 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
203 new Builder to take over for an old one, transferring state from
205 (Buider): refactor the way that SlaveBuilders are used to match,
206 giving them a bit more autonomy.
207 (Builder.buildFinished): this no longer calls maybeStartBuild():
208 instead the SlaveBuilder calls it on whoever its parent Builder is
209 at the time. This way, when an old Builder is replaced by a new
210 one, and there was a build in progress during the transition, when
211 that build finishes, it will be the new Builder that is told about
212 the newly available slave so it can start a new build.
214 * buildbot/process/base.py (Build.startBuild._release_slave): when
215 the Build finishes, tell the SlaveBuilder that they've been
218 * buildbot/status/builder.py (SlaveStatus): add some new setter
219 methods for use by BotPerspective, to keep some attributes more
222 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
223 called by the buildmaster.
224 (Bot.setBuilderList): instead, we locally announce any leftover
225 directories based upon which Builders we were told about. The
226 master doesn't really care; it's the local admin who may or may not
230 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
231 to allow use of python2.4 or whatever. This tool still requires
234 2006-11-19 Brian Warner <warner@lothar.com>
236 * NEWS (IStatusLog.readlines): more news items
238 2006-11-18 Brian Warner <warner@lothar.com>
240 * NEWS: start collecting items for the next release.
242 2006-11-04 Brian Warner <warner@lothar.com>
244 * buildbot/changes/bonsaipoller.py: apply updates from Ben
245 Hearsum. Closes SF#1590310.
246 * buildbot/test/test_bonsaipoller.py: and tests
248 * buildbot/status/tinderbox.py
249 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
250 status when the build results in WARNINGS. Patch from Dave
251 Liebreich. Closes SF#1587352.
253 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
254 linux-vs-osx behavior difference w.r.t. reading from files that
255 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
256 to Mark Rowe for the patch.
258 2006-10-15 Brian Warner <warner@lothar.com>
260 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
261 method name was misspelled in the interface definition. Thanks to
262 Roy Rapoport for the catch.
264 2006-10-13 Brian Warner <warner@lothar.com>
266 * docs/buildbot.texinfo (Adding LogObservers): update sample code
267 to match the great Steps renaming
269 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
270 Maybe I should run my own unit tests before recording a big
271 change. Good thing I've got a buildbot to remind me.
273 2006-10-12 Brian Warner <warner@lothar.com>
275 * buildbot/steps/transfer.py: rework __init__ and args setup
276 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
278 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
279 when opening the target file, only catch IOError (to report via
280 stderr/rc!=0), let the others be reported as normal exceptions
282 2006-10-08 Brian Warner <warner@lothar.com>
284 * contrib/svn_watcher.py: fix security holes by using proper argv
285 arrays and subprocess.Popen() rather than commands.getoutput().
286 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
287 is deprecated in favor of buildbot/changes/svnpoller.py, and will
288 probably be removed by the next release.
291 2006-10-04 Brian Warner <warner@lothar.com>
293 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
294 initial lines that weren't emitted by pyflakes. When the pyflakes
295 command is run under a Makefile, 'make' will echo the command it
296 runs to stdio, and that was getting logged as a "misc" warning.
297 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
298 * buildbot/test/test_steps.py (testPyFlakes3): another test
300 2006-10-01 Brian Warner <warner@lothar.com>
302 * buildbot/status/html.py (HtmlResource.render): if we get a
303 unicode object from our content() method, encode it into utf-8
304 like we've been claiming to all along. This allows the comments
305 and author names from svnpoller.py to be delivered properly.
307 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
308 de-unicodify filenames before creating the Change, because the
309 rest of buildbot is unlikely to handle them well. Leave the 'who'
310 field as a unicode object.. I don't think there's anything that
311 will break very soon, and it will probably nudge us towards
312 accepting unicode everywhere sooner or later. Stop using the
313 "date" field that comes out of SVN, since it is using the
314 repository's clock (and timezone) and what we care about is the
315 buildmaster's (otherwise Changes from the future show up later
316 than the builds they triggered).
317 * buildbot/test/test_svnpoller.py (Everything.test1): match the
320 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
321 Suvbersion repository polling ChangeSource. I've hacked it up
322 considerably: any bugs are entirely my own fault. Thank you
324 * buildbot/test/test_svnpoller.py: tests for it
325 * docs/buildbot.texinfo (SvnSource): document it
327 2006-09-30 Brian Warner <warner@lothar.com>
329 * buildbot/scheduler.py (Periodic): submit a reason= to the
330 BuildSet to indicate which Scheduler triggered the build. Thanks
331 to Mateusz Loskot for the suggestion.
333 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
335 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
336 changes: set self.loop in __init__, remove unused volatile=
338 * docs/buildbot.texinfo (.buildbot config directory): add more
339 docs on the .buildbot/options keys used by "buildbot try"
340 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
341 (Try.deliverJob): same
343 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
347 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
348 close the filehandle when we stop watching the file. Before, the
349 filehandle was only closed when the LogFileWatcher was
350 garbage-collected, which could be quite a while in the future. If
351 it was still open by the time the next build started, windows will
352 refuse to let the new build delete the old build/ directory. Fixes
353 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
354 #twisted for the catch.
356 2006-09-29 Brian Warner <warner@lothar.com>
358 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
361 2006-09-25 Brian Warner <warner@lothar.com>
363 * setup.py: the new buildbot.steps module wasn't being installed.
364 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
365 (testmsgs): add the extra stuff from buildbot/test/* so you can
366 run unit tests on an installed copy of buildbot, not just from
369 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
370 columns of 'svnlook changed' output contain status information, so
371 strip [:4] instead of [:6]. Depending upon what the status flags
372 were, this would sometimes lead to mangled filenames. Thanks to
373 Riccardo Magliocchetti for the patch. Closes SF#1545146.
375 * buildbot/steps/source.py (Monotone): initial Monotone support,
376 contributed by Nathaniel Smith. Still needs docs and tests, but
377 this code has been in use on the Monotone buildbot for a long
379 * buildbot/slave/commands.py (Monotone): slave-side support
380 * buildbot/changes/monotone.py (MonotoneSource): polling change
383 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
384 contributed a Change Source that polls a Bonsai server (a
385 kind of web-based viewcvs CGI script).
387 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
388 Hearsum contributed a status plugin which sends email in the same
389 format that Tinderbox does: this allows a number of tinderbox
390 tools to be driven by Buildbot instead. Thanks Ben!
392 2006-09-24 Brian Warner <warner@lothar.com>
394 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
395 Thanks to Robert Helmer for the patch.
397 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
398 BuildStatus about the buildslave name at the *beginning* of the
399 build, rather than at the end. Thanks to Alexander Lorenz for the
401 * buildbot/status/html.py (StatusResourceBuild.body): always
402 include the slavename in the build page, not just when the build
404 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
405 slavename in the email message
407 2006-09-21 Brian Warner <warner@lothar.com>
409 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
411 * docs/examples/glib_master.cfg: same
412 * docs/examples/hello.cfg: same
413 * docs/examples/twisted_master.cfg: same, update to current usage
415 2006-09-19 Brian Warner <warner@lothar.com>
417 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
418 (PyFlakes.createSummary): make it compatible with python-2.2
420 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
421 for at least the output-parsing parts of PyFlakes
423 2006-09-18 Brian Warner <warner@lothar.com>
425 * buildbot/steps/python.py: oops, fix import of StringIO
427 2006-09-17 Brian Warner <warner@lothar.com>
429 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
430 turns out that SVN-1.4.0 doesn't fail to update once you've
431 replaced a file with a directory, unlike older versions of SVN and
432 pretty much every other VC tool we support. Since what we really
433 care about is that the update succeeds anyway, stop checking that
434 the tree got clobbered and just assert that the build succeeded.
435 (VCBase.printLogs): add a utility function for debugging
437 * buildbot/process/step.py: oops, added extra imports by mistake
439 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
440 rstrip() on the first line coming out of the 'p4 describe'
441 process, to remove the stray ^M that Wade Brainerd reports seeing
442 in the 'when' field. Fixes SF#1555985.
444 * buildbot/master.py (BuildMaster.loadConfig): improve the error
445 message logged when c['schedulers'] is not right
446 * buildbot/scheduler.py (Scheduler.__init__): improve error
447 message when a Scheduler() is created with the wrong arguments
448 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
449 verify that these error messages are emitted
451 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
452 The idea is that all the base classes (like BuildStep and
453 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
454 will be a leftover backwards-compatibility file that only contains
455 aliases for the steps that were moved out to buildbot.steps.*
456 * lots: change imports to match
457 * buildbot/process/step.py: add a DeprecationWarning if it ever
460 2006-09-12 Brian Warner <warner@lothar.com>
462 * buildbot/scheduler.py (Scheduler.__init__): make sure that
463 builderNames= is actually a sequence, since if you happen to give
464 it a single builder-specification dictionary instead, it won't get
465 caught by the existing assert. Thanks to Brett Neely for the
468 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
470 * docs/buildbot.texinfo (Python BuildSteps): document them
471 (sendchange): include a link to PBChangeSource, since you need one
473 * buildbot/steps/shell.py: clean up test-case-name line, remove some
475 * buildbot/steps/dummy.py: same
477 2006-09-08 Brian Warner <warner@lothar.com>
479 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
480 BuildStep which lets you transfer files from the master to the
481 slave or vice versa. Thanks to Albert Hofkamp for the original
482 patch. Fixes SF#1504631.
483 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
485 (SlaveFileDownloadCommand): same
486 * docs/buildbot.texinfo (Transferring Files): document it
487 * buildbot/test/test_transfer.py: test it
488 * buildbot/test/runutils.py (StepTester): new utility class for
489 testing BuildSteps and RemoteCommands without Builds or Bots or PB
490 * buildbot/test/test_steps.py (CheckStepTester): validate that the
493 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
494 walk through StatusLogs one line at a time, mostly for the benefit
495 of ShellCommand.createSummary methods. You can either walk through
496 STDOUT or STDERR, but the default is STDOUT.
498 * buildbot/status/builder.py (LogFile.readlines): implement it.
499 Note that this is not yet memory-efficient, it just pulls the
500 whole file into RAM and then splits it up with a StringIO.
501 Eventually this should be a generator that only pulls chunks from
503 * buildbot/test/test_status.py (Log.testReadlines): test it
505 * docs/buildbot.texinfo: update to match changes
506 * buildbot/process/factory.py: stop using old definitions
507 * buildbot/process/process_twisted.py: same
508 * buildbot/test/test_*.py: same
510 * buildbot/process/step_twisted.py: move definition to..
511 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
512 relative-import mechanisms prevent this from being named 'twisted'
513 or 'python/twisted' as I would have preferred.
515 * buildbot/process/maxq.py: move definition to..
516 * buildbot/steps/maxq.py: .. here, leave a compatibility import
518 * buildbot/process/step.py: split the user-visible BuildSteps into
519 separate files, all under buildbot/steps/
520 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
521 * buildbot/steps/shell.py: this holds ShellCommand and friends
522 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
524 2006-09-05 Brian Warner <warner@lothar.com>
526 * lots: run pyflakes, removed a lot of unused imports, changed the
527 form of some conditional imports to remove false pyflakes
528 warnings. There are still a number of warnings left, mostly from
529 imports that are done for their side-effects.
530 * buildbot/test/test_vc.py: import twisted.python.failure, since it
533 2006-08-26 Brian Warner <warner@lothar.com>
535 * buildbot/test/test_locks.py (Unit.testLater): make the tests
536 compatible with twisted-1.3.0, for some reason I just can't seem
537 to let go of the past.
539 2006-08-25 Brian Warner <warner@lothar.com>
541 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
543 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
544 all logfiles= in startCommand(), rather than in start() . This
545 makes it easier to have the 'stdio' log come before any secondary
546 logfiles, which I feel makes the waterfall display more
548 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
549 from ShellCommand up into LoggingBuildStep
550 (LoggingBuildStep.__init__): move the handling of logfiles= from
551 ShellCommand up to LoggingBuildStep, because startCommand is
552 provided by LoggingBuildStep, whereas start() was specific to
553 subclasses like ShellCommand and Source. This removes code
554 duplication in those subclasses.
555 (ShellCommand.__init__): same
556 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
557 for a slave that's too old to understand logfiles= into a separate
558 method, so it can live in ShellCommand. The rest of
559 setupLogfiles() can live in LoggingBuildStep.
561 2006-08-24 Brian Warner <warner@lothar.com>
563 * buildbot/locks.py (BaseLock): you can now configure Locks to
564 allow multiple simultaneous owners. They still default to
565 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
567 * docs/buildbot.texinfo (Interlocks): document the new options
568 * buildbot/test/test_locks.py: add a bunch of new unit tests
569 * buildbot/process/base.py (Build.acquireLocks): locks now offer
570 waitUntilMaybeAvailable, not waitUntilAvailable
571 * buildbot/process/step.py (BuildStep.acquireLocks): same
572 * buildbot/master.py (BotMaster.getLockByID): real locks now use
573 the whole lockid in their constructor, not just the name. Also,
574 keep track of which real locks we've handed out by the full
575 lockid, not just class+name, otherwise changing just the maxCount=
576 in the master.cfg file would not actually cause a behavioral
579 2006-08-23 Brian Warner <warner@lothar.com>
581 * buildbot/__init__.py (version): bump to 0.7.4+ while between
583 * docs/buildbot.texinfo: same
585 2006-08-23 Brian Warner <warner@lothar.com>
587 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
588 * docs/buildbot.texinfo: set version to match
589 * NEWS: update for 0.7.4
590 * buildbot/slave/commands.py (command_version): mention that this
591 version (2.1) was released with buildbot-0.7.4
593 2006-08-22 Brian Warner <warner@lothar.com>
597 * CREDITS: new file, list of people who have helped. Thanks!
598 * MANIFEST.in: ship it
600 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
601 new diagrams, the user's manual is more informative than it was.
602 Start shipping the .html user's manual (and generated .png
604 * Makefile: update 'release' target to match
606 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
607 test.. I think the web-parts effort will render it pointless well
608 before it ever actually starts to work.
610 2006-08-20 Brian Warner <warner@lothar.com>
612 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
613 meaning of the prefix= argument. It is now just a string which is
614 stripped from the beginning of the filename. If prefix= is set but
615 not found on any given filename, that filename is ignored. If all
616 filenames in a Change are ignored, the Change is dropped. This is
617 much simpler than the previous sep= nonsense, and I should have
618 implemented it this way from the beginning. Effectively resolves
619 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
620 Gedminas for the catch and suggested fixes.
621 (ChangePerspective.perspective_addChange): implement the actual
623 * buildbot/test/test_changes.py (TestChangePerspective): test it
624 * docs/buildbot.texinfo (PBChangeSource): document it, explain
625 how to properly use prefix=
626 * docs/examples/twisted_master.cfg (source): update prefix= by
627 adding the trailing slash
630 * docs/examples/twisted_master.cfg: update to actual practice
632 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
633 update test case to match new link text.. the HREF has both a
634 class= setting and an enclosing [] pair that I didn't match in the
637 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
638 list of strings is preferred over a single string with embedded
640 (ShellCommand.description=): explain that either single strings or
641 a list of strings is acceptable, and why you might prefer one over
642 the other. Add an example. Fixes SF#1524659, thanks to Paul
643 Winkler for the catch.
644 (Build Steps): update to use f.addStep() rather than using s()
645 and the constructor list
647 * buildbot/process/step.py (ShellCommand): accept either a single
648 string or a list of strings in both description= and
650 * buildbot/test/test_steps.py (Steps.test_description): test it
651 * buildbot/test/runutils.py (makeBuildStep): support for that test
653 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
654 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
655 collecting the files and creating the patch.
657 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
658 per-step URLs that will be displayed on the waterfall display,
659 for things like the HTML output of code-coverage tools, when
660 the results are hosted elsewhere.
661 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
662 way to retrieve these URLs
663 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
664 the method to retrieve these URLs. Also provide backwards
665 compatibility for saved BuildStepStatus instances that didn't have
667 * buildbot/process/step.py (BuildStep.addURL): method to set these
668 URLs from within a BuildStep
669 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
670 (StepBox.getBox): give these external links a distinct CSS class
671 named "BuildStep external" so a .css file can display them
674 * buildbot/test/test_web.py (WaterfallSteps): test that we really
676 * buildbot/test/test_steps.py (Steps): test that we can all the
677 URLs. Also add a bunch of other tests on methods that can be
678 called from within BuildSteps
679 * buildbot/test/runutils.py (makeBuildStep): add utility function
681 2006-08-13 Brian Warner <warner@lothar.com>
683 * docs/buildbot.texinfo (BuildStep LogFiles): document them
685 2006-08-10 Brian Warner <warner@lothar.com>
687 * docs/buildbot.texinfo (Index of master.cfg keys): add another
688 index, this one of things like c['sources'] and c['schedulers']
689 (indices): it looks like my clever idea of putting the @fooindex
690 commands in between the @node and the @subsection (to make the
691 HREF anchor jump to slightly above the section title, which works
692 much better in html) confused texinfo horribly, so I'm moving the
693 index tags back to be just after the @subsection marker. I also
694 added extra lines between the @node/@section paragraph and the
695 index tags, since I think maybe texinfo wants to see these be
698 * docs/Makefile (images): make sure images get built when
700 * docs/images/Makefile: same
702 * buildbot/scripts/runner.py: rename 'buildbot master' to
703 'buildbot create-master', and 'buildbot slave' to 'buildbot
705 * docs/buildbot.texinfo: same
708 * docs/buildbot.texinfo: reimplement the "useful classes" index
709 with actual texinfo indices. The .info rendering is a bit
710 weird-looking but it works well, and the HTML rendering is quite
711 nice. This also puts the index targets in the regular flow of the
712 text, which is easier to maintain.
714 2006-08-06 Brian Warner <warner@lothar.com>
716 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
717 Kevin Turner to prefer the environ= argument be a list rather than
718 a string. If it is a list, it will be joined with a platform-local
719 os.pathsep delimiter, and then prepended to any existing
720 $PYTHONPATH value. This works better in cross-platform (i.e.
721 windows buildslaves) environments when you need to push multiple
722 directories onto the front of the path.
723 (SlaveShellCommand): documented the new magic
724 * docs/buildbot.texinfo (ShellCommand): documented the new magic
725 in a user-visible form
727 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
728 Turner to prefer lists over strings when creating/running VC
729 commands during unit tests. This is clearly necessary to survive
730 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
731 renamed the wq() function to qw() though, since that's how it's
732 spelled in perl. Eventually I'd prefer all commands to be
733 specified with lists.
735 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
736 which are deleted (or not yet created) correctly. Also add
737 failsafe code to not explode if the file-watching poller doesn't
738 get started. Thanks to JP Calderone for the catch and the poller
740 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
742 * buildbot/test/emitlogs.py: same
744 * NEWS: summarize recent changes
746 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
747 clause to avoid the "host key mismatch" warning
749 * buildbot/process/step_twisted.py (Trial.start): if the
750 buildslave is too old to understand logfiles=, fall back to
751 running 'cat _trial_temp/test.log' like before.
752 (Trial.commandComplete): same. this takes advantage of the
753 LoggingBuildStep refactoring to stall commandComplete long enough
754 to run a second RemoteShellCommand.
756 * buildbot/process/step.py (LoggingBuildStep.startCommand):
757 refactor command-completion handling, to allow methods like
758 commandComplete/createSummary/evaluateCommand to return Deferreds.
759 (LoggingBuildStep._commandComplete): delete the refactored method
760 (ShellCommand.setupLogfiles): if the buildslave is too old to
761 understand logfiles=, put a warning message both into twistd.log
762 and into the otherwise empty user-visible LogFiles.
764 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
765 callers to provide the slave-side logfile name, rather than
766 forcing it to come from the local name of the LogFile.
767 (BuildStep.getSlaveName): new method
769 * buildbot/process/base.py (Build.getSlaveName): new method, so
770 steps can find out which buildslave they're running on
772 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
773 to match the s/cvs_ver/command_version/ change
775 2006-08-05 Brian Warner <warner@lothar.com>
777 * buildbot/slave/commands.py (command_version): replace the CVS
778 auto-updated cvs_ver keyword with a manually-updated variable,
779 since CVS is no longer the master repository. Add a description of
780 the remote API change starting in this version (2.1), specifically
781 the fact that SlaveShellCommand now accepts 'initial_stdin',
782 'keep_stdin_open', and 'logfiles'.
784 2006-07-31 Brian Warner <warner@lothar.com>
786 * docs/buildbot.texinfo (System Architecture): Finally add lots of
787 diagrams to describe how the whole system fits together. The
788 images themselves are kept in SVG files, with ascii-art versions
789 in corresponding .txt files. Texinfo knows how to interpolate the
790 text version into .info files, reference the .png versions from
791 .html files, and include .eps versions in the .ps format.
792 * docs/images/Makefile: tools to create .png and .eps
793 * docs/images/*.svg: created pictures with Inkscape.
794 * .darcs-boring: ignore the generated .eps and .png files
796 2006-07-24 Brian Warner <warner@lothar.com>
798 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
799 Scheduler names, since they cause setServiceParent to explode
801 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
803 2006-07-20 Brian Warner <warner@lothar.com>
805 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
806 which runs the buildbot unit tests
808 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
809 classes that are useful in master.cfg
811 2006-07-15 Brian Warner <warner@lothar.com>
813 * Makefile (some-apidocs): new target to build only some epydocs
815 * setup.py: minor comment.. does the classifiers= argument prevent
816 the setup.py script from working on python2.2/2.3?
818 * buildbot/scripts/sample.cfg: update manhole example, arrange into
821 * buildbot/twcompat.py: fix minor typo in comments
823 * buildbot/manhole.py: move all Manhole-related code out to this
824 module. Implement SSH-based manholes (with TwistedConch), and move
825 to conch's nifty line-editing syntax-coloring REPL shell instead
826 of the boring non-editing monochromatic (and deprecated) old
828 * buildbot/master.py: remove all Manhole-related code
829 (BuildMaster.loadConfig._add): make sure the old manhole is
830 removed before we add the new one
831 * docs/buildbot.texinfo (Debug options): document new Manhole options
833 * buildbot/twcompat.py (_which): fix some epydoc issues
834 * buildbot/status/html.py (Waterfall.__init__): same
836 2006-06-29 Brian Warner <warner@lothar.com>
838 * buildbot/interfaces.py: get Interface from b.twcompat to hush
839 deprecation warnings under newer Twisteds (by using
840 zope.interface.Interface instead of old twisted.python.components
842 * buildbot/slave/interfaces.py: same
844 2006-06-28 Brian Warner <warner@lothar.com>
846 * buildbot/slave/commands.py (SVN): add --non-interactive to all
847 svn commands, so it will fail immediately instead of hanging while
848 it waits for a username/password to be typed in.
850 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
851 log message if the step was shut down
853 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
854 obsolete reference to mktap.
856 2006-06-20 Brian Warner <warner@lothar.com>
858 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
859 test to include new 'logfiles' argument sent from master to slave
861 2006-06-19 Brian Warner <warner@lothar.com>
863 * buildbot/process/step_twisted.py (Trial): track Progress from
864 _trial_temp/test.log too
866 * buildbot/process/step.py (OutputProgressObserver): generalize
867 the earlier StdioProgressObserver into an OutputProgressObserver
868 that can track LogFiles other than stdio.
869 (LoggingBuildStep.__init__): same
871 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
872 _trial_temp/test.log, not a separate 'cat' command. TODO: this
873 will fail under windows because of os.sep issues. It might have
874 worked before if 'cat' was doing cygwin path conversion.
876 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
877 creation of LogFileWatchers
878 (ShellCommand._startCommand): and record the files that were
879 watched in the 'headers' section of the ShellCommand output
881 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
882 need to actually pass it to the slave if you want it to work.
883 (ShellCommand): document it a bit
885 * buildbot/test/test_shell.py: new test to validate LogFiles
886 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
888 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
889 before printing the last batch of lines, to test that the polling
890 logic is working properly
892 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
893 handling, making it possible to track multiple logs for a single
894 RemoteCommand. The previous single logfile is now known as the
896 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
897 (RemoteShellCommand.__init__): accept logfiles=
898 (LoggingBuildStep.startCommand): stdio_log is now one of many
899 (ShellCommand): added logfiles= argument, as well as a class-level
900 .logfiles attribute, which will be merged together to figure out
901 which logfiles should be tracked. The latter maybe be useful for
902 subclasses of ShellCommand which know they will aways produce
903 secondary logfiles in the same location.
905 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
906 and closeStdin() methods, preparing to make it possible to write
907 to a ShellCommand's stdin at any time, not just at startup. These
908 writes are buffered if the child process hasn't started yet.
909 (LogFileWatcher): new helper class to watch arbitrary logfiles
910 while a ShellCommand runs. This class polls the file every two
911 seconds, and sends back 10k chunks to the buildmaster.
912 (ShellCommand): rename stdin= to initialStdin=, and add
913 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
915 (ShellCommand.addLogfile): LogFile text is sent in updates with a
916 key of "log" and a value of (logname, data).
917 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
918 'logfiles' to the master-visible args dictionary.
919 (SourceBase.doPatch): match s/stdin/initialStdin/ change
922 * buildbot/test/test_vc.py (Patch.testPatch): same
925 * buildbot/test/emit.py: write to a logfile in the current
926 directory. We use this to figure out what was used as a basedir
927 rather than looking to see which copy of emit.py gets run, so that
928 we can run the commands from inside _trial_temp rather than inside
930 * buildbot/test/subdir/emit.py: same
931 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
932 argument rather than running from buildbot/test/
933 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
934 rather than using an implicit setUp()
935 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
936 (ShellBase.testShell1, etc): use explicit path to emit.py instead
937 of assuming that we're running in buildbot/test/ (and that '.' is
940 * buildbot/slave/commands.py (Command.doStart): refactor Command
941 startup/completion a bit: now the SlaveBuilder calls doStart(),
942 which is not meant for overridding by subclasses, and doStart()
943 calls start(), which is. Likewise the SlaveBuilder calls
944 doInterrupt(), and subclasses override interrupt(). This also puts
945 responsibility for maintaining .running in Command rather than in
947 (Command.doInterrupt): same
948 (Command.commandComplete): same, this is called when the deferred
949 returned by start() completes.
950 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
951 (SlaveBuilder.remote_interruptCommand): same
952 (SlaveBuilder.stopCommand): same
954 2006-06-16 Brian Warner <warner@lothar.com>
956 * buildbot/test/test_shell.py: new test file to contain everything
957 relating to ShellCommand
958 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
959 multiple logfiles in realtime" feature, not yet implemented
960 * buildbot/test/emitlogs.py: support file for testLogFiles
961 * docs/buildbot.texinfo (ShellCommand): document the feature
963 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
965 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
966 for tests which exercise SlaveCommands in isolation.
968 * buildbot/test/test_slavecommand.py: Move some utilities like
969 SignalMixin and FakeSlaveBuilder from here ..
970 * buildbot/test/runutils.py: .. to here, so they can be used by
971 other test classes too
972 * buildbot/test/test_vc.py: more SignalMixin refactoring
973 * buildbot/test/test_control.py: same
974 * buildbot/test/test_run.py: and some rmtree refactoring
976 2006-06-15 Brian Warner <warner@lothar.com>
978 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
979 'testBranch' to match other VC tests and have the tests run in
980 roughly increasing order of dependency
982 * buildbot/test/test_steps.py (LogObserver): new test to verify
983 LogObservers can be created at various times and still get
984 connected up properly
986 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
987 to create BuildStepStatus instances that actually work.
989 * buildbot/process/step.py (LogObserver): add outReceived and
990 errReceived base methods, to be overridden
992 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
993 API to take a name instead of a step, reducing the coupling
994 somewhat. This returns the BuildStepStatus object so it can be
995 passed to the new Step, instead of jamming it directly into the
997 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
999 * buildbot/process/base.py (Build.setupBuild): use both methods
1000 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1001 process a bit to match
1003 2006-06-14 Brian Warner <warner@lothar.com>
1005 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1006 docs on writing new LogObserver classes
1007 (Writing New Status Plugins): brief docs on how Status Plugins fit
1010 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1011 implement a LogObserver that counts how many unit tests have been
1013 (Trial.__init__): wire it in
1014 * buildbot/test/test_twisted.py (Counter): unit test for it
1016 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1017 to new cmd.logs['stdio'] scheme
1018 (Trial.commandComplete): same
1019 (BuildDebs.commandComplete): same
1021 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1022 LogFiles, instead of just a single one. The old single logfile is
1023 now called "stdio". LoggedRemoteCommand no longer creates a
1024 LogFile for you (the code to do that was broken anyway). If you
1025 don't create a "stdio" LogFile, then stdout/stderr will be
1027 (LogObserver): implement "LogObservers", which a BuildStep can add
1028 to parse the output of a command in real-time. The primary use is
1029 to provide more useful information to the Progress code, allowing
1030 better ETA estimates.
1031 (LogLineObserver): utility subclass which feeds complete lines to
1032 the parser instead of bytes.
1033 (BuildStep.progressMetrics): this is safer as a tuple
1034 (BuildStep.setProgress): utility method, meant to be called by
1036 (BuildStep.addLogObserver): new method, to be called at any time
1037 during the BuildStep (even before any LogFiles have been created),
1038 to attach (or schedule for eventual attachment) a LogObserver to a
1040 (StdioProgressObserver): new LogObserver which replaces the old
1041 "output" progress gatherer
1042 (LoggingBuildStep.__init__): same
1043 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1044 (LoggingBuildStep._commandComplete): must use logs['stdio']
1045 instead of the old single ".log" attribute.
1046 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1047 functionality, now subsumed into StdioProgressObserver
1048 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1049 log name changed from "output" to "stdio".
1052 * buildbot/interfaces.py (ILogFile): add the Interface used from
1053 the BuildStep towards the LogFile
1054 (ILogObserver): and the one provided by a LogObserver
1055 * buildbot/status/builder.py (LogFile): implement it
1057 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1058 HEADER constants here ..
1059 * buildbot/status/builder.py (STDOUT): .. from here
1061 2006-06-13 Brian Warner <warner@lothar.com>
1063 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1064 compatibility with python2.2, which doesn't have the 'substr in
1066 (TestP4Poller.makeTime): utility function to construct the
1067 timestamp using the same strptime() approach as p4poller does. It
1068 turns out that time.mktime() behaves slightly differently under
1069 python2.2, probably something to do with the DST flag, and that
1070 causes the test to fail under python2.2. (changing the mktime()
1071 arguments to have dst=0 instead of -1 caused it to fail under
1072 python2.3. Go figure.)
1073 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1075 2006-06-12 Brian Warner <warner@lothar.com>
1077 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1078 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1079 contributing such an excellent patch, including docs and unit
1080 tests! This makes it *so* much easier to apply. I had to update
1081 test_vc.py to handle some recent refactorings, but everything else
1082 applied smoothly. The only remaining thing I'd like to fix would
1083 be to remove the hard-wired port 1666 used by p4d, and allow it to
1084 claim any unused port. This would allow two copies of the test
1085 suite to run on the same host at the same time, as well as
1086 allowing the test suite to run while a real (production) p4d was
1087 running on the same host. Oh, and maybe we should add a warning to
1088 step.P4 that gets emitted if the slave is too old to provide the
1089 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1090 * buildbot/slave/commands.py (P4): same
1091 (P4Sync): same, some minor updates
1092 * buildbot/changes/p4poller.py: same
1093 * docs/buildbot.texinfo: same
1094 * buildbot/test/test_p4poller.py: same
1095 * buildbot/test/test_vc.py (P4): same
1097 * setup.py: add Trove classifiers for PyPI
1099 2006-06-08 Brian Warner <warner@allmydata.com>
1101 * buildbot/status/client.py
1102 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
1103 changing this from getCurrentBuild() to getCurrentBuilds(). Each
1104 build needs to be IRemote'd separately, rather than IRemote'ing
1105 the whole list at once. I can't wait until newpb's serialization
1106 adapters make this unnecessary.
1108 2006-06-06 Brian Warner <warner@lothar.com>
1110 * buildbot/process/step.py (WithProperties): make this inherit
1111 from ComparableMixin, so that reloading an unchanged config file
1112 doesn't cause us to spuriously reload any Builders which use them.
1113 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
1116 2006-06-03 Brian Warner <warner@lothar.com>
1118 * contrib/windows/{setup.py, buildbot_service.py}: add support for
1119 running py2exe on windows, contributed by Mark Hammond. Addresses
1120 SF#1401121, but I think we still need to include
1121 buildbot/scripts/sample.cfg
1122 * setup.py: include buildbot_service.py as a script under windows
1123 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
1124 a py2exe application), get the icon/css datafiles from a different
1127 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
1128 double-escape the build URL. Thanks to Olivier Bonnet for the
1129 patch. Fixes SF#1452801.
1131 2006-06-02 Brian Warner <warner@lothar.com>
1133 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
1134 first six columns of 'svnlook' output, not just the first column,
1135 since property changes appear in the other five. Thanks to Olivier
1136 Bonnet for the patch. Fixes SF#1398174.
1138 2006-06-01 Brian Warner <warner@lothar.com>
1140 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
1141 the fake build, so that title= has something to be set to
1143 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
1144 attribute of the "Build #NN" link in the yellow start-the-build
1145 box to the build's reason. This means that you get a little
1146 tooltip explaining why the build was done when you hover over the
1147 yellow box. Thanks to Zandr Milewski for the suggestion.
1149 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
1150 (Box.setETA): handle ETA=None (by stopping the timer)
1151 (Box.update): make the [soon] text less different than the usual
1152 text, so the rest of the text doesn't flop around so much. It
1153 would be awfully nice to figure out how to center this stuff.
1154 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
1156 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
1157 by default, so that any ShellCommand which fails marks the overall
1158 build as a failure. I should have done this from the beginning.
1159 Add flunkOnFailure=False to the arguments if you want to turn off
1162 2006-05-30 Brian Warner <warner@lothar.com>
1164 * buildbot/clients/gtkPanes.py: add a third row: now it shows
1165 last-build/current-build/current-step. Show what step is currently
1166 running. Show ETA for both the overall build and the current step.
1167 Update GTK calls to modern non-deprecated forms. There's still a
1168 lot of dead code and debug noise to remove.
1170 * buildbot/process/step_twisted.py (Trial): set the step name, so it
1171 shows up properly in status displays
1173 2006-05-28 Brian Warner <warner@lothar.com>
1175 * buildbot/test/test_properties.py (Run.testInterpolate): on the
1176 build we use to verify that WithProperties works:
1178 ** set flunkOnFailure=True so that build failures get noticed
1179 ** set workdir='.' so that the build succeeds, otherwise it is trying
1180 to touch 'build/something', and 'build/' doesn't exist because
1181 usually that's created by a Source step
1182 ** set timeout=10, because Twisted-1.3.0 has a race condition that
1183 this test somehow triggers, in which the 'touch' process becomes
1184 a zombie and we wait for th etimeout before giving up on it.
1186 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
1187 to log the Build results and step logs to the twisted log.
1188 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
1189 what went wrong if a build was expected to succeed but didn't.
1191 * buildbot/process/step_twisted.py (Trial): set the default
1192 trialMode to '--reporter=bwverbose', which specifies verbose
1193 black-and-white text. Back in twisted-1.3/2.0 days we had to use
1194 '-to', but those are completely missing in modern Twisteds.
1196 * buildbot/scripts/sample.cfg: make the sample Manhole config use
1197 a localhost-only port, to encourage better security
1199 * docs/buildbot.texinfo (Change Sources): mention
1202 * .darcs-boring: add a Darcs boringfile
1204 * README (REQUIREMENTS): stop claiming compatibility with
1207 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
1210 2006-05-27 Brian Warner <warner@lothar.com>
1212 * buildbot/__init__.py: bump to 0.7.3+ while between releases
1213 * docs/buildbot.texinfo: same
1215 2006-05-23 Brian Warner <warner@lothar.com>
1217 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
1218 * docs/buildbot.texinfo: set version to match
1219 * NEWS: update for 0.7.3
1221 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
1222 give a quick mapping from VC system to possible ChangeSources
1223 (Build Properties): add 'buildername'
1225 * buildbot/process/base.py (Build.setupStatus): oops, set
1226 'buildername' and 'buildnumber' properties
1227 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
1230 2006-05-22 Brian Warner <warner@lothar.com>
1232 * docs/buildbot.texinfo (Build Properties): explain the syntax of
1233 property interpolation better
1235 * README (INSTALLATION): remove old '-v' argument from recommended
1238 * docs/buildbot.texinfo (ShellCommand): add docs for description=
1239 and descriptionDone= arguments. Thanks to Niklaus Giger for the
1242 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
1243 'svnversion' instead of grepping the output of 'svn info', much
1244 simpler and avoids CR/LF problems on windows. Thanks to Olivier
1245 Bonnet for the suggestion.
1246 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
1247 require the WC_PATH argument, so run 'svnversion .' instead.
1249 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
1250 aren't supposed to have 'self' in their argument list
1252 2006-05-21 Brian Warner <warner@lothar.com>
1254 * buildbot/process/step.py (ShellCommand.start): make
1255 testInterpolate pass. I was passing the uninterpolated command to
1256 the RemoteShellCommand constructor
1257 (ShellCommand._interpolateProperties): oops, handle non-list
1258 commands (i.e. strings with multiple words separated by spaces in
1259 them) properly, instead of forgetting about them.
1261 * buildbot/test/test_properties.py (Run.testInterpolate): new test
1262 to actually try to use build properties in a real build. This test
1264 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
1265 to start and evaluate builds
1267 * buildbot/test/test__versions.py: add a pseudo-test to record
1268 what version of Twisted/Python/Buildbot are running. This should
1269 show up at the beginning of _trial_tmp/test.log, and exists to help
1270 debug other problems.
1272 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
1273 a filename to be served as 'robots.txt' to discourage web spiders.
1274 Adapted from a patch by Tobi Vollebregt, thanks!
1275 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
1276 (Waterfall.test_waterfall): tweak the way that filenames are put
1277 into the config file, to accomodate windows pathnames better.
1279 * docs/buildbot.texinfo (HTML Waterfall): document it
1281 * buildbot/process/process_twisted.py
1282 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
1283 changed the build process. The new setup.py no longer takes the
1285 (FullTwistedBuildFactory.__init__): same
1286 (TwistedReactorsBuildFactory.__init__): same
1288 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
1289 be placed in the [hooks] section of the central repository (the
1290 one that everybody pushes changes to).
1292 2006-05-20 Brian Warner <warner@lothar.com>
1294 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
1295 .darcs-context file, use binary mode. I think this was causing a
1296 Darcs failure under windows.
1298 2006-05-19 Brian Warner <warner@lothar.com>
1300 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
1301 use a timezone string of +0000 and gmtime, since this timestamp is
1302 sent to a buildmaster and %z is broken.
1304 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
1305 string and localtime, since this timestamp will only be consumed
1306 locally, and %z is broken.
1308 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
1309 gmtime, since this timestamp is returned to the buildmaster, and
1312 2006-05-18 Brian Warner <warner@lothar.com>
1314 * NEWS: update in preparation for next release
1316 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
1317 setup-repository and do-we-have-the-vc-tools code into a separate
1318 "helper" class, which sticks around in a single module-level
1319 object. This seems more likely to continue to work in the future
1320 than having it hide in the TestCase and hope that TestCases stick
1321 around for a long time.
1323 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
1324 addremove' has been deprecated in recent versions of mercurial, so
1325 use 'hg add' instead
1327 2006-05-07 Brian Warner <warner@lothar.com>
1329 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
1330 operating under windows, move the file before opening it, since
1331 you can't rename a file that somebody has open.
1333 * buildbot/process/base.py (Build.setupBuild): if something goes
1334 wrong while creating a Step, log the name and arguments, since the
1335 error message when you get the number of arguments wrong is really
1338 2006-05-06 Brian Warner <warner@lothar.com>
1340 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
1341 bugs in twisted-specific code not covered by my unit tests, this
1342 time use 'cmd' argument instead of self.cmd
1344 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
1345 fix stupid braino: either use startwith or find()==0, not both.
1346 (TwistedReactorsBuildFactory.__init__): another dumb typo
1348 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
1349 mark this test as TODO under windows, since process-killing seems
1350 dodgy there. We'll come back to this later and try to fix it
1353 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
1354 and don't include a timezone
1355 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
1356 This should avoid the windows-with-verbose-timezone-name problem
1358 (Patch.testPatch): add a test which runs 'patch' with less
1359 overhead than the full VCBase.do_patch sequence, to try to isolate
1360 a windows test failure. This one uses slave.commands.ShellCommand
1361 and 'patch', but none of the VC code.
1363 * buildbot/slave/commands.py (getCommand): use which() to find the
1364 executables for 'cvs', 'svn', etc. This ought to help under
1367 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
1368 working directory before starting. If an earlier test failed, the
1369 leftover directory would mistakenly flunk a later test.
1370 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
1371 Make sure that we use the right commandlines if which("tla") picks
1372 up "tla.exe" (as it does under windows).
1373 (TlaSupport.do_get): factor out this tla-vs-baz difference
1374 (TlaSupport.vc_create): more tla-vs-baz differences
1376 * buildbot/test/test_slavecommand.py
1377 (ShellBase.testShellMissingCommand): stop trying to assert
1378 anything about the error message: different shells on different
1379 OSes with different languages makes it hard, and it really isn't
1380 that interesting of a thing to test anyway.
1382 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
1383 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1384 "Panther"), because it has a bug which flunks a couple tests in
1385 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1386 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1387 able to test that yet.
1389 2006-04-30 Brian Warner <warner@lothar.com>
1391 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1392 make sure child commands emit messages in english, so our regexps
1393 will match. Thanks to Nikaus Giger for identifying the problems.
1394 (VCBase._do_vctest_export_1): mode="export" is not responsible
1395 for setting the "got_revision" property, since in many cases it is
1396 not convenient to determine.
1397 (SVNSupport.capable): when running 'svn --version' to check for
1398 ra_local, we want error messages in english
1399 * buildbot/test/test_slavecommand.py
1400 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1401 to emit the error message in english
1403 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1404 the environment with $LC_ALL="C" so that Commands which need to
1405 parse the output of their child processes can obtain it in
1407 (SVN.parseGotRevision): call "svn info" afterwards instead of
1408 watching the output of the "svn update" or "svn checkout".
1409 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1410 (Arch.parseGotRevision): same
1411 (Bazaar.parseGotRevision): same
1412 (Mercurial.parseGotRevision): same
1414 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1415 $LC_ALL="C" when running commands under 'buildbot try', too
1417 * buildbot/test/__init__.py: remove the global os.environ()
1418 setting, instead we do it just for the tests that run commands and
1419 need to parse their output.
1421 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1422 remove the overly-short .timeout on this test, because non-DNotify
1423 platforms must fall back to polling which happens at 10 second
1424 intervals, so a 5 second timeout would never succeed.
1426 2006-04-24 Brian Warner <warner@lothar.com>
1428 * docs/buildbot.texinfo (Installing the code): update trial
1429 invocation, SF#1469116 by Niklaus Giger.
1430 (Attributes of Changes): updated branch-name examples to be
1431 a bit more realistic, SF#1475240 by Stephen Davis.
1433 * contrib/windows/buildbot2.bat: utility wrapper for windows
1434 developers, contributed by Nick Trout (after a year of neglect..
1435 sorry!). SF#1194231.
1437 * buildbot/test/test_vc.py (*.capable): store the actual VC
1438 binary's pathname in VCS[vcname], so it can be retrieved later
1439 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1440 strip out non-numeric timezone information, specifically the funky
1441 German string that his system produced that confuses CVS.
1442 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1443 allow Darcs tests to work on windows
1444 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1445 procutils.which() everywhere, to allow tryclient to work under
1446 windows. Also from Niklaus Giger, SF#1463394.
1448 * buildbot/twcompat.py (which): move the replacement for a missing
1449 twisted.python.procutils.which from test_vc.py to here, so it can
1450 be used in other places too (specifically tryclient.py)
1452 2006-04-23 Brian Warner <warner@lothar.com>
1454 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1455 bare buildbotURL/projectName line with a proper DIV, along with a
1456 CSS class of "title", from Stefan Seefeld (SF#1461675).
1457 (WaterfallStatusResource.body0): remove the redundant 'table'
1458 class from the table
1459 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1460 to the top-row TR, and class="Activity" to the second-row TR,
1461 rather than putting them in the individual TD nodes.
1463 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1464 'got_revision' build property for all VC systems that implement
1465 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1467 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1468 to determine which revision we actually obtained
1469 (CVS.parseGotRevision): implement this for CVS, which just means
1470 to grab a timestamp. Not ideal, and it depends upon the buildslave
1471 having a clock that is reasonably well syncronized with the server,
1472 but it's better than nothing.
1473 (SVN.parseGotRevision): implement it for SVN, which is accurate
1474 (Darcs.parseGotRevision): same
1475 (Arch.parseGotRevision): same
1476 (Bazaar.parseGotRevision): same
1477 (Mercurial.parseGotRevision): same
1479 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1480 keep a record of all non-stdout/stderr/header/rc status updates,
1481 for the benefit of RemoteCommands that send other useful things,
1483 (Source.commandComplete): put any 'got_revision' status values
1484 into a build property of the same name
1487 * buildbot/process/step_twisted.py (Trial): update to deal with
1488 new ShellCommand refactoring
1490 * docs/buildbot.texinfo (Build Properties): document new feature
1491 that allows BuildSteps to get/set Build-wide properties like which
1492 revision was requested and/or checked out.
1494 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1495 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1496 it. Note that this bumps the persistenceVersion of the saved Build
1497 object, so add the necessary upgrade-old-version logic to include
1498 an empty properties dict.
1500 * buildbot/process/base.py (Build.setProperty): implement it
1501 (Build.getProperty): same
1502 (Build.startBuild): change build startup to set 'branch',
1503 'revision', and 'slavename' properties at the right time
1505 * buildbot/process/step.py (BuildStep.__init__): change setup to
1506 require 'build' argument in a better way
1507 (LoggingBuildStep): split ShellCommand into two pieces, for better
1508 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1509 a single RemoteCommand that sends stdout/stderr status text. It
1510 also provides the usual commandComplete / createSummary /
1511 evaluateCommand / getText methods to be overridden...
1512 (ShellCommand): .. whereas ShellCommand is specifically for
1513 running RemoteShellCommands. Other shell-like BuildSteps (like
1514 Source) can inherit from LoggingBuildStep instead of ShellCommand
1515 (WithProperties): marker class to do build-property interpolation
1516 (Source): inherit from LoggingBuildStep instead of ShellCommand
1519 * buildbot/test/test_properties.py: test new functionality
1521 2006-04-21 Brian Warner <warner@lothar.com>
1523 * buildbot/test/test_vc.py: rename testBranch to
1524 testCheckoutBranch to keep the tests in about the right
1527 2006-04-18 Brian Warner <warner@lothar.com>
1529 * docs/buildbot.texinfo (PBListener): improve cross-references
1530 between PBListener and 'buildbot statusgui', thanks to John Pye
1533 2006-04-17 Brian Warner <warner@lothar.com>
1535 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1536 running under Twisted-1.3.0, otherwise skipped tests are reported
1539 * all: use isinstance() instead of 'type(x) is foo', suggested by
1542 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1543 oops, fix a brain-fade from the other week, when making the
1544 addStep changes. I changed all the __init__ upcalls to use the
1545 wrong superclass name.
1546 (FullTwistedBuildFactory.__init__): same
1547 (TwistedDebsBuildFactory.__init__): same
1548 (TwistedReactorsBuildFactory.__init__): same
1549 (TwistedBuild.isFileImportant): use .startswith for clarity,
1550 thanks to Neal Norwitz for the suggestions.
1552 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1553 changes, then deliver them over PB to a remote buildmaster.
1555 * contrib/svnpoller.py: added script by John Pye to poll a remote
1556 SVN repository (by running 'svn log') from a cronjob, and run
1557 'buildbot sendchange' to deliver the changes to a remote
1559 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1560 modification of svnpoller.py), same purpose, but this one loops
1561 internally (rather than expecting to run from a cronjob) and works
1563 * contrib/README.txt: same
1565 2006-04-11 Brian Warner <warner@lothar.com>
1567 * all: fix a number of incorrect names and missing imports, thanks
1568 to Anthony Baxter for the patch.
1569 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1570 remove unused buggy method.
1571 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1572 comes from shutil, not "shutils"
1573 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1574 (Arch.checkSlaveVersion): same
1575 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1577 * buildbot/process/step_twisted2.py: add some missing imports
1578 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1579 this code used to live in twisted.internet.defer
1581 2006-04-10 Brian Warner <warner@lothar.com>
1583 * buildbot/process/step.py (Mercurial): add Mercurial support
1584 * buildbot/slave/commands.py (Mercurial): same
1585 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1586 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1587 not yet tested, but 'try' support *is* covered
1588 * docs/buildbot.texinfo (Mercurial): document it
1590 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1591 some debugging messages (turned off)
1592 * buildbot/test/test_vc.py: improve debug messages
1594 2006-04-07 Brian Warner <warner@lothar.com>
1596 * buildbot/test/test_vc.py (which): define our own which() in case
1597 we can't import twisted.python.procutils, because procutils doesn't
1598 exist in Twisted-1.3
1600 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1601 of SlaveLocks for performance tests
1603 * docs/examples/twisted_master.cfg: update to match current usage
1605 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1606 password, p4 binary, pollinterval, maximum history to check.
1607 Patch from an anonymous sf.net contributor, SF#1219384.
1608 * buildbot/process/step.py (P4Sync.__init__): add username,
1609 password, and client arguments.
1610 * buildbot/slave/commands.py (P4Sync): same
1612 2006-04-05 Brian Warner <warner@lothar.com>
1614 * buildbot/process/factory.py (BuildFactory.addStep): new method
1615 to add steps to a BuildFactory. Use it instead of f.steps.append,
1616 and you can probably avoid using the s() convenience function.
1617 Patch from Neal Norwitz, sf.net #1412605.
1618 (other): update all factories to use addStep
1619 * buildbot/process/process_twisted.py: update all factories to use
1622 2006-04-03 Brian Warner <warner@lothar.com>
1624 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1625 work under windows too. Adapted from a patch by Niklaus Giger,
1626 addresses SF#1463399.
1628 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1629 spawned commands emit parseable results in english and not some
1630 other language. Patch from Niklaus Giger, SF#1463395.
1632 * README (INSTALLATION): discourage users from running unit tests on
1633 a "network drive", patch from Niklaus Giger, SF#1463394.
1635 2006-03-22 Brian Warner <warner@lothar.com>
1637 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1638 function to turn a repository-relative pathname into a (branch,
1639 branch-relative-filename) tuple. Change this function to handle
1640 the branch naming policy used by your Subversion repository.
1641 Thanks to AllMyData.com for sponsoring this work.
1643 2006-03-16 Brian Warner <warner@lothar.com>
1645 * buildbot/scripts/sample.cfg: add python-mode declaration for
1646 vim. Thanks to John Pye for the patch.
1648 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1649 command line, mention the importance of running 'crontab' as the
1650 buildmaster/buildslave user. Thanks to John Pye for the catch.
1652 2006-03-13 Brian Warner <warner@lothar.com>
1654 * buildbot/status/words.py (IRC): add an optional password=
1655 argument, which will be sent to Nickserv in an IDENTIFY message at
1656 login, to claim the nickname. freenode requires this before the
1657 bot can sent (or reply to) private messages. Thanks to Clement
1658 Stenac for the patch.
1659 * docs/buildbot.texinfo (IRC Bot): document it
1661 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1662 larger than chunkSize. Fixes SF#1349253.
1663 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1664 (Log.testConsumer): update to match new internal chunking behavior
1666 2006-03-12 Brian Warner <warner@lothar.com>
1668 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1670 * buildbot/test/test_maildir.py (MaildirTest): rename the
1671 'timeout' method, as it collides with trial's internals
1673 * buildbot/scripts/runner.py: add 'buildbot restart' command
1674 (stop): don't sys.exit() out of here, otherwise restart can't work
1675 * docs/buildbot.texinfo (Shutdown): document it
1677 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1678 * buildbot/status/html.py (Waterfall.__init__): same
1679 * buildbot/process/builder.py (Builder.startBuild): same
1680 * buildbot/process/base.py (BuildRequest): same
1681 * buildbot/sourcestamp.py (SourceStamp): same
1682 * buildbot/scheduler.py (Nightly): same
1684 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1686 * docs/buildbot.texinfo: same
1688 2006-02-17 Brian Warner <warner@lothar.com>
1690 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1691 * docs/buildbot.texinfo: set version number to match
1692 * NEWS: update for 0.7.2
1694 2006-02-16 Brian Warner <warner@lothar.com>
1696 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1698 2006-02-09 Brian Warner <warner@lothar.com>
1700 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1701 add text to explain per-build branch parameters
1702 * NEWS: mention --umask
1704 2006-02-08 Brian Warner <warner@lothar.com>
1706 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1708 (SlaveOptions.optParameters): add --umask, to make it possible to
1709 make buildslave-generated files (including build products) be
1712 * buildbot/slave/bot.py (BuildSlave.startService): same
1714 2006-01-23 Brian Warner <warner@lothar.com>
1716 * buildbot/status/builder.py: urllib.quote() all URLs that include
1717 Builder names, so that builders can include characters like '/'
1718 and ' ' without completely breaking the resulting HTML. Thanks to
1719 Kevin Turner for the patch.
1720 * buildbot/status/html.py: same
1721 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1723 * NEWS: update in preparation for upcoming release
1725 2006-01-18 Brian Warner <warner@lothar.com>
1727 * docs/examples/twisted_master.cfg: update to match the Twisted
1728 buildbot: remove python2.2, switch to exarkun's buildslaves,
1729 disable the .deb builder until we figure out how to build twisted
1730 .debs from SVN, add some ktrace debugging to the OS-X build
1731 process and remove the qt build, remove threadless builders,
1732 change freebsd builder to use landonf's buildslave.
1734 2006-01-12 Brian Warner <warner@lothar.com>
1736 * buildbot/master.py (Manhole.__init__): let port= be a strports
1737 specification string, but handle a regular int for backwards
1738 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1739 used in master.cfg to limit connections to just the local host.
1740 (BuildMaster.loadConfig): same for c['slavePortnum']
1741 * buildbot/scheduler.py (Try_Userpass.__init__): same
1742 * buildbot/status/client.py (PBListener.__init__): same
1743 * buildbot/status/html.py (Waterfall.__init__): same, for both
1744 http_port and distrib_port. Include backwards-compatibility checks
1745 so distrib_port can be a filename string and still mean unix:/foo
1746 * docs/buildbot.texinfo (Setting the slaveport): document it
1747 (Debug options): same
1748 (HTML Waterfall): same
1751 * buildbot/test/test_config.py (ConfigTest): test it
1753 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1754 slaveport's disownServiceParent deferred to fire before opening
1755 the new one. Fixes an annoying bug in the unit tests.
1757 2006-01-03 Brian Warner <warner@lothar.com>
1759 * buildbot/master.py (BuildMaster): remove the .schedulers
1760 attribute, replacing it with an allSchedulers() method that looks
1761 for all IService children that implement IScheduler. Having only
1762 one parent/child relationship means fewer opportunities for bugs.
1763 (BuildMaster.allSchedulers): new method
1764 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1765 also fix ugly bug that caused any config-file reload to
1766 half-forget about the earlier Schedulers, causing an exception
1767 when a Change arrived and was handed to a half-connected
1768 Scheduler. The exception was in scheduler.py line 54ish:
1769 self.parent.submitBuildSet(bs)
1770 exceptions.AttributeError: 'NoneType' object has no attribute
1772 (BuildMaster.addChange): update to use allSchedulers()
1774 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1775 to work properly with twisted-1.3.0, where you must explicitly
1776 include the __implements__ from parent classes
1777 (BaseScheduler.__repr__): make it easier to distinguish distinct
1779 (BaseUpstreamScheduler.__implements__): same
1781 * buildbot/status/builder.py (Status.getSchedulers): update to
1783 * buildbot/test/test_run.py (Run.testMaster): same
1784 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1785 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1786 make sure Scheduler instances are left alone when an identical
1787 config file is reloaded
1788 (ConfigElements.testSchedulers): make sure Schedulers are properly
1791 * Makefile (TRIALARGS): my local default Twisted version is now
1792 2.1.0, update the trial arguments accordingly
1794 2005-12-22 Brian Warner <warner@lothar.com>
1796 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1799 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1800 addChange in the parent class, although I suspect this should be
1801 fixed better in the future.
1803 2005-11-26 Brian Warner <warner@lothar.com>
1805 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1806 explode when branch==None, thanks to Kevin Turner for the catch
1807 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1810 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1812 * docs/buildbot.texinfo: same
1814 2005-11-26 Brian Warner <warner@lothar.com>
1816 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1817 * docs/buildbot.texinfo: set version number to match
1819 2005-11-26 Brian Warner <warner@lothar.com>
1821 * NEWS: update for 0.7.1
1823 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1824 sure that unsubscribe works even if we never sent an ETA update.
1825 Also, don't explode on duplicate unsubscribe.
1826 (BuildStepStatus.addLog): make the convenience "return self"-added
1827 watcher automatically unsubscribe when the Step finishes.
1828 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1829 (BuildStatus.stepStarted): same auto-unsubscribe
1830 (BuilderStatus.buildStarted): same auto-unsubscribe
1832 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1834 (IStatusReceiver.stepStarted): same
1835 (IStatusReceiver.logStarted): same
1837 * buildbot/test/test_run.py (Status): move the Status test..
1838 * buildbot/test/test_status.py (Subscription): .. to here
1840 2005-11-25 Brian Warner <warner@lothar.com>
1842 * NEWS: more updates
1844 * buildbot/locks.py: fix the problem in which loading a master.cfg
1845 file that changes some Builders (but not all of them) can result
1846 in having multiple copies of the same Lock. Now, the real Locks
1847 are kept in a table inside the BotMaster, and the Builders/Steps
1848 use "LockIDs", which are still instances of MasterLock and
1849 SlaveLock. The real Locks are instances of the new RealMasterLock
1850 and RealSlaveLock classes.
1851 * buildbot/master.py (BotMaster.getLockByID): new method to
1852 convert LockIDs into real Locks.
1853 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1854 into real Locks before building
1855 * buildbot/process/step.py (BuildStep.startStep): same
1856 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1857 exercises the problem
1860 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1861 what Schedulers are available
1863 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1864 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1865 'cron'-style build scheduling at certain times of day, week,
1867 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1869 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1870 handling: treat self.fileIsImportant more as an attribute that
1871 contains a callable than as a method. If the attribute is None,
1872 don't call it and assume all filenames are important. It is still
1873 possible to provide a fileIsImportant method in a subclass,
1875 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1877 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1878 test using AnyBranchScheduler with fileIsImportant=None
1880 2005-11-24 Brian Warner <warner@lothar.com>
1882 * buildbot/test/test_config.py (StartService): don't claim a fixed
1883 port number, instead set slavePort=0 on the first pass, figure out
1884 what port was allocated, then switch to a config file that uses
1887 * buildbot/master.py (BuildMaster.loadConfig): close the old
1888 slaveport before opening the new one, because unit tests might
1889 replace slavePort=0 with the same allocated portnumber, and if we
1890 don't wait for the old port to close first, we get a "port already
1891 in use" error. There is a tiny race condition here, but the only
1892 threat is from other programs that bind (statically) to the same
1893 port number we happened to be allocated, and only if those
1894 programs use SO_REUSEADDR, and only if they get control in between
1897 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1899 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1900 deleted ChangeSources before adding any new ones
1901 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1902 compare_attrs, to make sure that a config-file reload does not
1903 unnecessarily replace an unmodified ChangeSource instance
1904 * buildbot/test/test_config.py (ConfigTest.testSources): update
1906 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1907 mean "don't build anything", and add a warning if it gets used
1908 because it isn't actually useful.
1910 * contrib/svn_buildbot.py: update example usage to match the port
1911 number that gets used by the PBChangeSource
1912 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1914 2005-11-22 Brian Warner <warner@lothar.com>
1916 * NEWS: start collecting items for next release
1918 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1919 revisions are strings
1920 (P4Sync.computeSourceRevision): same
1922 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1923 to the Buildbot's overall status page
1924 (StatusResourceBuilder.body): same
1926 2005-11-15 Brian Warner <warner@lothar.com>
1928 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1929 config-file loading, specifically to make sure old StatusTargets
1930 are finished shutting down before new ones start up (thus
1931 resolving a bug in which changing the Waterfall object would fail
1932 because both new and old instances were claiming the same
1933 listening port). Also load new Schedulers after all the new
1934 Builders are set up, in case they fire off a new build right away.
1935 * buildbot/test/test_config.py (StartService): test it
1937 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1938 the branch name to the mail body
1940 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1941 Without it, a config-file reload fails to update an existing
1943 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1944 username/passwd to compare_attrs, for the same reason
1945 * buildbot/status/html.py (Waterfall): add favicon to
1946 compare_attrs, same reason
1948 2005-11-05 Brian Warner <warner@lothar.com>
1950 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1951 baserev before stuffing it in the jobfile. This resolves problems
1952 under SVN (and probably Arch) where revisions are expressed as
1953 numbers. I'm inclined to use string-based revisions everywhere in
1954 the future, but this fix should be safe for now. Thanks to Steven
1955 Walter for the patch.
1957 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1958 binary mode when opening pickle files, to make windows work
1959 better. Thanks to Dobes Vandermeer for the catch.
1960 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1961 (BuilderStatus.getBuildByNumber): same
1962 (Status.builderAdded): same
1963 * buildbot/master.py (BuildMaster.loadChanges): same
1965 * buildbot/util.py (Swappable): delete unused leftover code
1967 * buildbot/process/step.py (SVN): when building on a non-default
1968 branch, add the word "[branch]" to the VC step's description, so
1969 it is obvious that we're not building the usual stuff. Likewise,
1970 when we are building a specific revision, add the text "rNNN" to
1971 indicate what that revision number is. Thanks to Brad Hards and
1972 Nathaniel Smith for the suggestion.
1973 (Darcs.startVC): same
1974 (Arch.startVC): same
1975 (Bazaar.startVC): same
1977 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1978 typo, caught by Mark Dillavou, closes SF#1216636.
1980 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1981 about a test to add some day
1983 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1984 the 'full-2.3' build, and the 'reactors' build is now run under
1985 python-2.4 because the buildslave no longer has gtk/etc bindings
1986 for earlier versions.
1988 2005-11-03 Brian Warner <warner@lothar.com>
1990 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1991 method, takes an IBuildStatus and rebuilds it. It might make more
1992 sense to add this to IBuildControl instead, but that instance goes
1993 away completely once the build has finished, and resubmitting
1994 builds can take place weeks later.
1995 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1996 * buildbot/status/html.py (StatusResourceBuild): also stash an
1997 IBuilderControl so we can use resubmitBuild.
1998 (StatusResourceBuild.body): render "resubmit" button if we can.
1999 Also add hrefs for each BuildStep
2000 (StatusResourceBuild.rebuild): add action for "resubmit" button
2001 (StatusResourceBuilder.getChild): give it an IBuilderControl
2003 * buildbot/status/builder.py (Status.getURLForThing): change the
2004 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2005 that live as targets of buttons like "stop" and "rebuild" can't
2007 * buildbot/status/builder.py (Status.getURLForThing): same
2008 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2009 (StepBox.getBox): same
2010 * buildbot/test/test_web.py (GetURL): same
2013 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2014 exclusivity checks after Source.__init__ upcall, so misspelled
2015 arguments will be reported more usefully
2016 (Darcs.__init__): same
2018 2005-10-29 Brian Warner <warner@lothar.com>
2020 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2021 builder. Move the Try scheduler off to a separate port.
2023 2005-10-27 Brian Warner <warner@lothar.com>
2025 * buildbot/clients/gtkPanes.py
2026 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2027 to cause the app to crash, now they don't.
2029 * buildbot/clients/debug.py: display the buildmaster's location
2030 in the window's title bar
2032 2005-10-26 Brian Warner <warner@lothar.com>
2034 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2035 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2036 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2038 * buildbot/status/html.py (td): put a single non-breaking space
2039 inside otherwise empty <td> elements, as a workaround for buggy
2040 browsers which would optimize them away (along with any associated
2041 styles, like the kind that create the waterfall grid borders).
2042 Patch from Frerich Raabe.
2044 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2045 argv-list as an argument, defaulting to ["-to"], which is
2046 appropriate for the Trial that comes with Twisted-2.1.0 and
2047 earlier. The Trial in current Twisted SVN wants
2048 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2049 defaults to an empty list.
2050 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2051 match it, now that trialMode= is a list instead of a single string
2053 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2055 * docs/buildbot.texinfo: same
2057 2005-10-24 Brian Warner <warner@lothar.com>
2059 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2060 * docs/buildbot.texinfo: set version number to match
2062 2005-10-24 Brian Warner <warner@lothar.com>
2064 * README: update for 0.7.0
2066 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2068 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2069 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2070 send the branch= argument unless the user really provided one, to
2071 retain compatibility with older buildmasters that don't accept
2073 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2076 * docs/buildbot.texinfo: update lots of stuff
2078 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2079 to the 'buildbot sendchange' command
2080 * buildbot/clients/sendchange.py (Sender.send): same
2081 * buildbot/changes/pb.py (ChangePerspective): same
2082 * buildbot/test/test_changes.py (Sender.testSender): test it
2084 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2085 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2086 for consistency with other BuildStep arguments that use camelCase.
2087 Well, at least more of them use camelCase (like flunkOnWarnings)
2088 than don't.. I wish I'd picked one style and stuck with it
2089 earlier. Annoying, but it's best done before the release, since
2090 these arguments didn't exist at all in 0.6.6 .
2092 * buildbot/test/test_vc.py (SVN.testCheckout): same
2093 (Darcs.testPatch): same
2094 * docs/buildbot.texinfo (SVN): document the change
2095 (Darcs): same, add some build-on-branch docs
2096 * docs/examples/twisted_master.cfg: match change
2098 * buildbot/process/step.py (BuildStep): rename
2099 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
2100 how it is normally used.
2101 * buildbot/test/test_steps.py (Version.checkCompare): same
2103 * buildbot/process/step.py (CVS.startVC): refuse to build
2104 update/copy -style builds on a non-default branch with an old
2105 buildslave (<=0.6.6) that doesn't know how to do it properly. The
2106 concern is that it will do a VC 'update' in an existing tree when
2107 it is supposed to be switching branches (and therefore clobbering
2108 the tree to do a full checkout), thus building the wrong source.
2109 This used to be a warning, but I think the confusion it is likely
2110 to cause warrants making it an error.
2111 (SVN.startVC): same, also make mode=export on old slaves an error
2112 (Darcs.startVC): same
2113 (Git.startVC): improve error message for non-Git-enabled slaves
2114 (Arch.checkSlaveVersion): same. continue to emit a warning when a
2115 specific revision is built on a slave that doesn't pay attention
2116 to args['revision'], because for slowly-changing trees it will
2117 probably do the right thing, and because we have no way to tell
2118 whether we're asking it to build the most recent version or not.
2119 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
2121 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
2122 that 'master' is in host:portnum format, to catch errors sooner
2124 2005-10-23 Brian Warner <warner@lothar.com>
2126 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
2127 when creating the list of warning messages, include the line
2128 immediately after each WARNING: line, since that's usually where
2129 the file and line number wind up.
2131 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
2136 2005-10-22 Brian Warner <warner@lothar.com>
2138 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
2139 patch from Brad Hards
2140 * buildbot/status/classic.css: same
2141 * buildbot/test/test_web.py (Waterfall): match changes
2143 * buildbot/test/test_steps.py (BuildStep.setUp): set
2144 nextBuildNumber so the test passes
2145 * buildbot/test/test_status.py (MyBuilder): same
2147 * buildbot/status/html.py (StatusResourceBuild.body): revision
2148 might be numeric, so stringify it before html-escapifying it
2149 (CurrentBox.getBox): add a "waiting" state, and show a countdown
2150 timer for the upcoming build
2151 * buildbot/status/classic.css: add background-color attributes for
2152 offline/waiting/building classes
2154 * buildbot/status/builder.py (BuildStatus): derive from
2155 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
2156 the default (i.e. unknown) .slavename to "???" instead of None,
2157 since even unknown slavenames need to be printed eventually.
2158 (BuilderStatus): also derive from styles.Versioned . More
2159 importantly, determine .nextBuildNumber at creation/unpickling
2160 time by scanning the directory of saved BuildStatus instances and
2161 choosing one larger than the highest-numbered one found. This
2162 should fix the problem where random errors during upgrades cause
2163 the buildbot to forget about earlier builds. .nextBuildNumber is
2164 no longer stored in the pickle.
2165 (Status.builderAdded): if we can't unpickle the BuilderStatus,
2166 at least log the error. Also call Builder.determineNextBuildNumber
2167 once the basedir is set.
2169 * buildbot/master.py (BuildMaster.loadChanges): do
2170 styles.doUpgrade afterwards, in case I decide to make Changes
2171 derived from styles.Versioned some day and forget to make this
2175 * buildbot/test/test_runner.py (Options.testForceOptions): skip
2176 when running under older pythons (<2.3) in which the shlex module
2177 doesn't have a 'split' function.
2179 * buildbot/process/step.py (ShellCommand.start): make
2180 errorMessages= be a list of strings to stuff in the log before the
2181 command actually starts. This makes it easier to flag multiple
2182 warning messages, e.g. when the Source steps have to deal with an
2184 (CVS.startVC): handle slaves that don't handle multiple branches
2185 by switching into 'clobber' mode
2186 (SVN.startVC): same. Also reject branches without base_url
2187 (Darcs.startVC): same. Also reject revision= in older slaves
2188 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
2189 (Bazaar.startVC): same, and test for baz separately than for arch
2191 * buildbot/slave/commands.py (cvs_ver): document new features
2193 * buildbot/process/step.py (BuildStep.slaveVersion): document it
2194 (BuildStep.slaveVersionNewEnough): more useful utility method
2195 * buildbot/test/test_steps.py (Version): start testing it
2197 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
2198 the 'force' command requires python2.3, for the shlex.split method
2200 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
2201 since we don't use it anymore. The Twisted buildbot uses a
2204 2005-10-21 Brian Warner <warner@lothar.com>
2206 * buildbot/process/process_twisted.py: rework all BuildFactory
2207 classes to take a 'source' step as an argument, instead of
2208 building up the SVN instance in the factory.
2209 * docs/examples/twisted_master.cfg: enable build-on-branch by
2210 providing a base_url and default_branch
2212 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
2213 control over --branch and --revision, not that they are always
2215 * buildbot/status/html.py (StatusResourceBuilder.force): same
2216 (StatusResourceBuild.body): display SourceStamp components
2218 * buildbot/scripts/runner.py (ForceOptions): option parser for the
2219 IRC 'force' command, so it can be shared with an eventual
2220 command-line-tool 'buildbot force' mode.
2221 * buildbot/test/test_runner.py (Options.testForceOptions): test it
2223 2005-10-20 Brian Warner <warner@lothar.com>
2225 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
2227 * docs/examples/twisted_master.cfg: update to use Schedulers
2229 * buildbot/scripts/sample.cfg: update with Schedulers
2231 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
2232 method specifically for use by HTML "force build" button and the
2233 IRC "force" command. Raises an immediate error if there are no
2235 (IBuilderControl.requestBuild): make this just submit a build, not
2236 try to check for existing slaves or set up any when-finished
2237 Deferreds or anything.
2238 * buildbot/process/builder.py (BuilderControl): same
2239 * buildbot/status/html.py (StatusResourceBuilder.force): same
2240 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
2241 * buildbot/test/test_slaves.py: same
2242 * buildbot/test/test_web.py: same
2244 2005-10-19 Brian Warner <warner@lothar.com>
2246 * docs/examples/twisted_master.cfg: re-sync with reality: bring
2247 back python2.2 tests, turn off OS-X threadedselect-reactor tests
2249 2005-10-18 Brian Warner <warner@lothar.com>
2251 * buildbot/status/html.py: provide 'status' argument to most
2252 StatusResourceFOO objects
2253 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
2254 and Logfiles" section to make the Build page into a more-or-less
2255 comprehensive source of status information about the build
2257 * buildbot/status/mail.py (MailNotifier): include the Build's URL
2258 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
2260 2005-10-17 Brian Warner <warner@lothar.com>
2262 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
2263 arguments to accomodate Twisted >=2.1.0 . I will have to figure
2264 out what to do about other projects: the correct options for
2265 recent Twisteds will not work for older ones.
2267 2005-10-15 Brian Warner <warner@lothar.com>
2269 * buildbot/status/builder.py (Status.getURLForThing): add method
2270 to provide a URL for arbitrary IStatusFoo objects. The idea is to
2271 use this in email/IRC status clients to make them more useful, by
2272 providing the end user with hints on where to learn more about the
2273 object being reported on.
2274 * buildbot/test/test_web.py (GetURL): tests for it
2276 2005-10-14 Brian Warner <warner@lothar.com>
2278 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
2279 fix bug resulting from deferredResult changes
2281 2005-10-13 Brian Warner <warner@lothar.com>
2283 * buildbot/test/test_changes.py: remove use of deferredResult
2284 * buildbot/test/test_config.py: same
2285 * buildbot/test/test_control.py: same
2286 * buildbot/test/test_status.py: same
2287 * buildbot/test/test_vc.py: this is the only remaining use, since
2288 it gets used at module level. This needs to be replaced by some
2289 sort of class-level run-once routine.
2291 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
2293 * lots: implement multiple slaves per Builder, which means multiple
2294 current builds per Builder. Some highlights:
2295 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
2296 of (state,currentBuilds) instead of (state,currentBuild)
2297 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
2298 (IBuildStatus.getSlavename): new method, so you can tell which
2299 slave got used. This only gets set when the build completes.
2300 (IBuildRequestStatus.getBuilds): new method
2302 * buildbot/process/builder.py (SlaveBuilder): add a .state
2303 attribute to track things like ATTACHING and IDLE and BUILDING,
2305 (Builder): .. the .slaves attribute here, which has been turned
2306 into a simple list of available slaves. Added a separate
2307 attaching_slaves list to track ones that are not yet ready for
2309 (Builder.fireTestEvent): put off the test-event callback for a
2310 reactor turn, to make tests a bit more consistent.
2311 (Ping): cleaned up the slaveping a bit, now it disconnects if the
2312 ping fails due to an exception. This needs work, I'm worried that
2313 a code error could lead to a constantly re-connecting slave.
2314 Especially since I'm trying to move to a distinct remote_ping
2315 method, separate from the remote_print that we currently use.
2316 (BuilderControl.requestBuild): return a convenience Deferred that
2317 provides an IBuildStatus when the build finishes.
2318 (BuilderControl.ping): ping all connected slaves, only return True
2319 if they all respond.
2321 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
2322 reconnect when we shut down.
2324 * buildbot/status/builder.py: implement new methods, convert
2325 one-build-at-a-time methods to handle multiple builds
2326 * buildbot/status/*.py: do the same in all default status targets
2327 * buildbot/status/html.py: report the build's slavename in the
2328 per-Build page, report all buildslaves on the per-Builder page
2330 * buildbot/test/test_run.py: update/create tests
2331 * buildbot/test/test_slaves.py: same
2332 * buildbot/test/test_scheduler.py: remove stale test
2334 * docs/buildbot.texinfo: document the new builder-specification
2335 'slavenames' parameter
2337 2005-10-12 Brian Warner <warner@lothar.com>
2339 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
2340 report failure correctly, causing Dependent builds to run when
2341 they shouldn't have.
2342 * buildbot/status/builder.py (BuildSetStatus): same
2343 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
2344 (Set.testSuccess): test the both-pass case too
2345 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2346 fix this test: it was ending too early, masking the failure before
2347 (Logger): specialized StatusReceiver to make sure the dependent
2348 builds aren't even started, much less completed.
2350 2005-10-07 Brian Warner <warner@lothar.com>
2352 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
2353 bot.SlaveBuilder being disowned in the middle of a build
2355 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
2356 this inherit from StatusReceiver. Also upcall in __init__. This
2357 fixes the embarrasing crash when the new buildSetSubmitted method
2358 is invoked and Waterfall/etc don't implement their own.
2359 * buildbot/test/test_run.py: add a TODO note about a test to catch
2360 just this sort of thing.
2362 * buildbot/process/builder.py (Builder.attached): remove the
2363 already-attached warning, this situation is normal. Add some
2364 comments explaining it.
2366 2005-10-02 Brian Warner <warner@lothar.com>
2368 * buildbot/changes/maildir.py (Maildir.start): Tolerate
2369 OverflowError when setting up dnotify, because some 64-bit systems
2370 have problems with signed-vs-unsigned constants and trip up on the
2371 DN_MULTISHOT flag. Patch from Brad Hards.
2373 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
2375 * buildbot/process/step.py (BuildStep, ShellCommand): Add
2376 progressMetrics, description, descriptionDone to the 'parms' list,
2377 and make use the 'parms' list from the implementation class
2378 instead of only BuildStep to initialize the parameters. This
2379 allows buildbot.process.factory.s() to initialize all the parms,
2380 not just those defined in directly by BuildStep.
2382 2005-09-03 Brian Warner <warner@lothar.com>
2384 * NEWS: start adding items for the next release
2386 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2387 python2.2 tests, change 'Quick' builder to only use python2.3
2389 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2391 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2392 the "Ping Builder" button if the build control is available; the
2393 user sees an exception otherwise
2395 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2397 2005-09-01 Brian Warner <warner@lothar.com>
2399 * buildbot/interfaces.py (IBuilderStatus.getState): update
2400 signature, point out that 'build' can be None
2401 (IBuildStatus.getETA): point out ETA can be none
2403 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2405 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2407 2005-08-31 Brian Warner <warner@lothar.com>
2409 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2410 update to match correct signature: removed 'eta' argument
2411 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2413 2005-08-30 Brian Warner <warner@lothar.com>
2415 * buildbot/status/builder.py (LogFile): remove the assertion that
2416 blows up when you try to overwrite an existing logfile, instead
2417 just emit a warning. This case gets hit when the buildmaster is
2418 killed and doesn't get a chance to write out the serialized
2419 BuilderStatus object, so the .nextBuildNumber attribute gets out
2422 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2423 the 'buildbot sendchange' arguments, for the Darcs context file
2424 * docs/buildbot.texinfo (sendchange): document it
2426 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2427 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2428 (IStatus.getSchedulers): new method
2429 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2430 (Status.getSchedulers): implement
2431 * buildbot/process/builder.py (Builder): maintain
2432 BuilderStatus.pendingBuilds
2433 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2434 (TryBase.addChange): Try schedulers should ignore Changes
2436 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2437 for 'try' on CVS/SVN
2438 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2440 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2441 report status properly.
2442 (Try.createJob): implement unique buildset IDs
2444 * buildbot/status/client.py (StatusClientPerspective): add a
2445 perspective_getBuildSets method for the benefit of jobdir-style
2447 * docs/buildbot.texinfo (try): more docs
2448 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2451 2005-08-18 Brian Warner <warner@lothar.com>
2453 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2454 actually work. It's functional but still kind of clunky. Also, it
2455 only works with the pb-style.. needs to be made to work with the
2458 * buildbot/status/client.py (RemoteBuildSet): new class
2459 (RemoteBuildRequest): same
2460 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2461 object, not the internal BuildStatus object.
2462 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2463 outside of the usual buildStarted() return value.
2464 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2466 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2467 (Try_Userpass_Perspective.perspective_try): return a remotely
2468 usable BuildSetStatus object
2470 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2471 isStarted()/waitUntilStarted()
2473 2005-08-16 Brian Warner <warner@lothar.com>
2475 * buildbot/status/builder.py: implement IBuildSetStatus and
2476 IBuildRequestStatus, wire them into place.
2477 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2478 methods into the BuildSetStatus object.
2479 * buildbot/interfaces.py: same
2480 (IStatus.getBuildSets): new method to get pending BuildSets
2481 (IStatusReceiver.buildsetSubmitted): new method which hears about
2483 * buildbot/master.py (BuildMaster.submitBuildSet): same
2484 * buildbot/process/base.py (BuildRequest): same, replace
2485 waitUntilStarted with subscribe/unsubscribe
2486 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2487 subscribe instead of waitUntilStarted
2488 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2490 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2492 * buildbot/test/test_buildreq.py: update for new code
2493 * buildbot/test/test_control.py (Force.testRequest): same
2496 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2497 for Darcs to not use the tempfile module, so it works under
2498 python-2.2 too. We really didn't need the full cleverness of that
2499 module, since the slave has exclusive control of its own builddir.
2501 2005-08-15 Brian Warner <warner@lothar.com>
2503 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2504 for CVS trees. It doesn't work for non-trunk branches,
2506 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2509 * Makefile: make it easier to test against python2.2
2511 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2512 tearDown2, so things like Arch can unregister archives as they're
2513 shutting down. The previous subclass-override-tearDown technique
2514 resulted in a nested maybeWait() and test failures under
2517 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2518 where we can (Arch), add a branch= argument to set the branch used
2520 (BazExtractor): extract the branch too
2521 (TlaExtractor): same
2522 * buildbot/scripts/runner.py (TryOptions): add --branch
2523 * docs/buildbot.texinfo (try): document --branch/try_branch
2525 * buildbot/slave/commands.py (Darcs): implement get-revision for
2526 Darcs, so that 'try' will work. This requires the tempfile module
2529 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2530 of revisions, branches, and 'try' in the process.
2532 2005-08-11 Brian Warner <warner@lothar.com>
2534 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2535 this, it got broken at some point in the last few releases
2536 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2537 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2538 specifically the removal of ETA information from the tuple
2540 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2543 * docs/buildbot.texinfo (try): document both --builder and
2544 'try_builders' in .buildbot/options
2545 * buildbot/scripts/runner.py (TryOptions): add --builder,
2546 accumulate the values into opts['builders']
2547 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2548 * buildbot/test/test_runner.py (Try): add some quick tests to make
2549 sure 'buildbot try --options' and .buildbot/options get parsed
2550 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2551 use --builder control
2553 * docs/buildbot.texinfo (try): add --port argument to PB style
2555 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2556 actual SourceStamp. Still need to extract a branch name, somehow.
2557 (Try): finish implementing the try client side, still need a UI
2558 for specifying which builders to use
2559 (Try.getopt): factor our options/config-file reading
2560 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2562 * buildbot/test/test_vc.py: match SourceStampExtractor change
2564 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2565 causes the twisted log to be sent to stderr
2567 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2569 2005-08-10 Brian Warner <warner@lothar.com>
2571 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2572 style is 90% done, still missing status reporting or waiting for
2573 the buildsets to finish, and it is completely untested.
2575 * buildbot/trybuild.py: delete file, move contents to ..
2576 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2577 * buildbot/test/test_vc.py: match the move
2579 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2580 of the TryScheduler, no buildsetID or status-tracking support yet
2581 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2583 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2584 possible to set the basedir after __init__ time, so it is easier
2585 to use as a Service-child of the BuildMaster instance
2587 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2588 that delivers messages to its Service parent instead of requiring
2589 a subclass to be useful. This turns out to be much easier to build
2592 * buildbot/scripts/tryclient.py (createJob): utility code to
2593 create jobfiles, will eventually be used by 'buildbot try'
2595 2005-08-08 Brian Warner <warner@lothar.com>
2597 * docs/buildbot.texinfo (try): add docs on the
2598 as-yet-unimplemented Try scheduler
2600 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2601 * buildbot/test/test_scheduler.py: .. here
2602 (Scheduling.testTryJobdir): add placeholder test for 'try'
2604 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2605 addEntry merging (>=chunkSize) behavior
2606 (Log.testConsumer): update to handle new callLater(0) behavior
2608 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2609 both the MAX_LENGTH bugfix and the resumeProducing hang.
2611 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2612 put off the actual resumeProducing for a moment with
2613 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2614 causes large logfiles to hang midway through.
2616 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2617 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2618 and to improve memory usage when streaming the file out to a web
2620 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2621 make this work cleanly
2623 2005-08-03 Brian Warner <warner@lothar.com>
2625 * buildbot/trybuild.py: new file for 'try' utilities
2626 (getSourceStamp): run in a tree, find out the baserev+patch
2627 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2628 implemented for SVN and Darcs, still working on Arch. I don't know
2629 how to make CVS work yet.
2631 * docs/buildbot.texinfo: document the 'buildbot' command-line
2632 tool, including the not-yet-implemented 'try' feature, and the
2633 in-flux .buildbot/ options directory.
2635 2005-07-20 Brian Warner <warner@lothar.com>
2637 * buildbot/locks.py: added temporary id() numbers to Lock
2638 descriptions, to track down a not-really-sharing-the-Lock bug
2640 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2642 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2643 needed for python2.2 compatibility
2644 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2645 are from the __future__
2647 2005-07-19 Brian Warner <warner@lothar.com>
2649 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2650 message when schedulers use unknown builders
2652 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2653 SlaveLock('name') and MasterLock('name') are distinct
2655 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2656 c['schedulers'] in such a way that we can actually accept
2658 * buildbot/test/test_config.py: check it
2660 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2661 utility method to *all* the Schedulers
2662 (Periodic.listBuilderNames): same
2664 * docs/buildbot.texinfo (Interlocks): update chapter to match
2667 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2668 to make sure that c['sources'], c['schedulers'], and c['status']
2669 are all lists of the appropriate objects, and that the Schedulers
2670 all point to real Builders
2671 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2672 'listBuilderNames' utility method to support this
2673 * buildbot/scheduler.py: implement the utility method
2674 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2676 * docs/buildbot.texinfo: add some @cindex entries
2678 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2679 if it wasn't already set: most tla commands will fail unless one
2681 (Arch.createRepository): and disable bazaar's revision cache, since
2682 they cause test failures (the multiple repositories we create all
2683 interfere with each other through the cache)
2685 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2686 bring it properly up to date with twisted-2.0 test guidelines
2688 * buildbot/master.py (BuildMaster): remove references to old
2689 'interlock' module, this caused a bunch of post-merge test
2691 * buildbot/test/test_config.py: same
2692 * buildbot/process/base.py (Build): same
2694 * buildbot/test/test_slaves.py: stubs for new test case
2696 * buildbot/scheduler.py: add test-case-name tag
2697 * buildbot/test/test_buildreq.py: same
2699 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2700 unnecessary init code
2701 (Bot.remote_setBuilderList): match it
2703 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2705 * buildbot/changes/mail.py (parseSyncmail): update comment
2707 * buildbot/test/test_slavecommand.py: disable Shell tests on
2708 platforms that don't suport IReactorProcess
2710 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2711 all places where we open logfiles. It causes OS-X to open the file
2712 in some weird mode that that prevents us from mixing reads and
2713 writes to the same filehandle, which we depend upon to implement
2714 _generateChunks properly. This change doesn't appear to break
2715 win32, on which "b" and "t" are treated differently but a missing
2716 flag seems to be interpreted as "t".
2718 2005-07-18 Brian Warner <warner@lothar.com>
2720 * buildbot/slave/commands.py (ShellCommand): overhaul
2721 error-handling code, to try and make timeout/interrupt work
2722 properly, and make win32 happier
2723 * buildbot/test/test_slavecommand.py: clean up, stop using
2724 reactor.iterate, add tests for timeout and interrupt
2725 * buildbot/test/sleep.py: utility for a new timeout test
2727 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2728 code from the local-usebranches branch
2730 2005-07-17 Brian Warner <warner@lothar.com>
2732 * buildbot/process/process_twisted.py
2733 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2734 minutes, to match the other twisted BuildFactories, and don't
2735 excuse failures in c/qt/win32 reactors any more.
2737 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2738 'freebsd' builders, since the buildslaves have been unavailable
2741 2005-07-13 Brian Warner <warner@lothar.com>
2743 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2744 build-on-branch feature
2746 * buildbot/process/step.py (Darcs.__init__): add base_url and
2747 default_branch arguments, just like SVN
2748 (Arch.__init__): note that the version= argument is really the
2751 * buildbot/slave/commands.py (SourceBase): keep track of the
2752 repository+branch that was used for the last checkout in
2753 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2754 match, we clobber the directory and perform a fresh checkout
2755 rather than trying to do an in-place update. This should protect
2756 us against trying to get to branch B by doing an update in a tree
2757 obtained from branch A.
2758 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2759 (SVN.setup): same, just the svnurl
2760 (Darcs.setup): same, just the repourl
2761 (Arch.setup): same, arch coordinates (url), version, and
2762 buildconfig. Also pull the buildconfig from the args dictionary,
2763 which we weren't doing before, so the build-config was effectively
2765 (Arch.sourcedirIsUpdateable): don't try to update when we're
2766 moving to a specific revision: arch can't go backwards, so it is
2767 safer to just clobber the tree and checkout a new one at the
2769 (Bazaar.setup): same sourcedata as Arch
2771 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2772 use maybeWait, to work with twisted-1.3.0 and twcompat
2773 (Dependencies.testRun_Pass): same
2775 * buildbot/test/test_vc.py: rearrange, cleanup
2777 * buildbot/twcompat.py: add defer.waitForDeferred and
2778 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2779 can work under twisted-1.3.0 .
2781 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2782 now created at setUp time. This increases the runtime of the test
2783 suite considerably (from 91 seconds to 151), but it removes the
2784 need for an offline tarball, which should solve a problem I've
2785 seen where the test host has a different version of svn than the
2786 tarball build host. The new code also validates that mode=update
2787 really picks up recent commits. This approach will also make it
2788 easier to test out branches, because the code which creates the VC
2789 branches is next to the code which uses them. It will also make it
2790 possible to test some change-notification hooks, by actually
2791 performing a VC commit and watching to see the ChangeSource get
2794 2005-07-12 Brian Warner <warner@lothar.com>
2796 * docs/buildbot.texinfo (SVN): add branches example
2797 * docs/Makefile (buildbot.ps): add target for postscript manual
2799 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2800 * buildbot/test/test_locks.py: same
2802 * buildbot/process/step.py (Darcs): comment about default branches
2804 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2805 c['interlocks'] in the config file, complain if it is present.
2806 Scan all locks in c['builders'] to make sure the Locks they use
2808 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2809 add some tests to check for non-uniquely-named Locks
2810 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2811 since the unique-Lock validation code requires it now
2813 * buildbot/locks.py: fix test-case-name
2815 * buildbot/interlock.py: remove old file
2817 2005-07-11 Brian Warner <warner@lothar.com>
2819 * buildbot/test/test_interlock.py: rename to..
2820 * buildbot/test/test_locks.py: .. something shorter
2822 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2823 versions (after 2.0.1) changed internet.TCPClient to shut down the
2824 connection in stopService. Change the code to handle this
2827 * buildbot/process/base.py (Build): handle whole-Build locks
2828 * buildbot/process/builder.py (Builder.compareToSetup): same
2829 * buildbot/test/test_interlock.py: make tests work
2831 * buildbot/process/step.py (BuildStep.startStep): complain if a
2832 Step tries to claim a lock that's owned by its own Build
2833 (BuildStep.releaseLocks): typo
2835 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2836 file reloads don't replace unchanged Builders
2838 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2839 rewrite to cover new Locks instead of old c['interlocks']
2840 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2844 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2845 start the master and connect the buildslave
2847 * buildbot/process/step.py (FailingDummy.done): finish with a
2848 FAILURE status rather than raising an exception
2850 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2851 stringify a BuildRequest.reason that is None
2853 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2855 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2856 allow scheduler.Dependent to work
2857 * buildbot/buildset.py (BuildSet): set .reason and .results
2859 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2860 slaves, to make the test stop hanging. It still fails, of course,
2861 because I haven't even started to implement Locks.
2863 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2865 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2866 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2867 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2868 (Dependent): new class for downstream build dependencies
2869 * buildbot/test/test_dependencies.py: tests (still failing)
2871 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2873 2005-07-07 Brian Warner <warner@lothar.com>
2875 * buildbot/test/runutils.py (RunMixin): factored this class out..
2876 * buildbot/test/test_run.py: .. from here
2877 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2878 added new buildbot.locks tests (which all hang right now)
2879 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2880 * buildbot/process/step.py: claim/release per-BuildStep locks
2882 * docs/Makefile: add 'buildbot.html' target
2884 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2885 interpreted as "HEAD", so that all VC steps can accept branch=None
2886 and have it mean the "default branch".
2888 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2890 2005-07-07 Brian Warner <warner@lothar.com>
2892 * docs/examples/twisted_master.cfg: update to match current usage
2894 * docs/buildbot.texinfo (System Architecture): comment out the
2895 image, it doesn't exist yet and just screws up the HTML manual.
2897 2005-07-05 Brian Warner <warner@lothar.com>
2899 * debian/.cvsignore: oops, missed one. Removing leftover file.
2901 2005-06-17 Brian Warner <warner@lothar.com>
2903 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2904 changed its output in 1.2.0, don't mistakenly think that the
2905 subversion we find isn't capable of supporting our tests.
2907 * debian/*: remove the debian/ directory and its contents, to make
2908 life easier for the proper Debian maintainer
2910 * Makefile (release): same
2912 2005-06-07 Brian Warner <warner@lothar.com>
2914 * everything: create a distinct SourceStamp class to replace the
2915 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2916 Changed the signature of Source.startVC to include the revision
2917 information (instead of passing it through self.args). Implement
2918 branches for SVN (now only Darcs/Git is missing support). Add more
2921 2005-06-06 Brian Warner <warner@lothar.com>
2923 * everything: rearrange build scheduling. Create a new Scheduler
2924 object (configured in c['schedulers'], which submit BuildSets to a
2925 set of Builders. Builders can now use multiple slaves. Builds can
2926 be run on alternate branches, either requested manually or driven
2927 by changes. This changed some of the Status classes. Interlocks
2928 are out of service until they've been properly split into Locks
2929 and Dependencies. treeStableTimer, isFileImportant, and
2930 periodicBuild have all been moved from the Builder to the
2932 (BuilderStatus.currentBigState): removed the 'waiting' and
2933 'interlocked' states, removed the 'ETA' argument.
2935 2005-05-24 Brian Warner <warner@lothar.com>
2937 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2938 erroneously abandons the connection (in clientConnectionFailed)
2939 for non-UserErrors, which means that if we lose the connection due
2940 to a network problem or a timeout, we'll never try to reconnect.
2941 Fix this by not upcalling to the buggy parent method. Note:
2942 twisted-2.0 fixes this, but the function only has 3 lines so it
2943 makes more sense to copy it than to try and detect the buggyness
2944 of the parent class. Fixes SF#1207588.
2946 * buildbot/changes/changes.py (Change.branch): doh! Add a
2947 class-level attribute to accomodate old Change instances that were
2948 pickled before 0.6.5 (where .branch was added for new Changes).
2949 This fixes the exception that occurs when you try to look at an
2950 old Change (through asHTML).
2952 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2955 2005-05-23 Brian Warner <warner@lothar.com>
2957 * buildbot/__init__.py (version): release 0.6.6
2959 2005-05-23 Brian Warner <warner@lothar.com>
2961 * NEWS: update for 0.6.6 release
2962 * debian/changelog: same
2964 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2965 before starting: this was done by twistd back when we spawned it,
2966 now that we're importing the pieces and running them in the
2967 current process, we have to do it ourselves. This allows
2968 master.cfg to import files from the same directory without
2969 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2970 Stichele for the catch.
2971 (Options.opt_version): Add a --version command (actually, just make
2972 the existing --version command emit Buildbot's version too)
2974 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2975 fix to make this behave like other LogFiles, this time to handle
2976 existing LogFiles on disk. (add the missing .upgrade method)
2977 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2979 2005-05-21 Brian Warner <warner@lothar.com>
2981 * buildbot/test/test_runner.py (Create.testMaster): match the
2982 rawstring change in runner.py:masterTAC
2984 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2985 TwistedWords is installed
2986 * buildbot/test/test_status.py: same, with TwistedMail
2988 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2989 some old, deprecated, and removed config keys). This should enable
2990 you to use the base buildbot functionality with Twisted-2.0.0 when
2991 you don't also have TwistedWeb and TwistedWords installed
2993 2005-05-20 Brian Warner <warner@lothar.com>
2995 * buildbot/scripts/runner.py (run): call sendchange(), not
2996 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2997 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2998 (stop): don't wait for process to die when sending SIGHUP
2999 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3000 directory name gets interpreted, which you don't want
3003 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3006 2005-05-18 Brian Warner <warner@lothar.com>
3008 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3010 2005-05-18 Brian Warner <warner@lothar.com>
3012 * README: update for 0.6.5
3013 * debian/changelog: same
3015 * buildbot/changes/changes.py: rename tag= to branch=, since
3016 that's how we're using it, and my design for the upcoming "build a
3017 specific branch" feature wants it. also, tag= was too CVS-centric
3018 * buildbot/changes/mail.py (parseSyncmail): same
3019 * buildbot/process/base.py (Build.isBranchImportant): same
3020 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3021 * docs/buildbot.texinfo (Attributes of Changes): same
3023 * NEWS: update tag=, update for upcoming release
3025 2005-05-17 Brian Warner <warner@lothar.com>
3027 * buildbot/scripts/runner.py (stop): actually poll once per
3028 second, instead of re-killing the poor daemon once per second.
3029 Sleep briefly (0.1s) before the first poll, since there's a good
3030 chance we can avoid waiting the full second if the daemon shuts
3031 down quickly. Also remove the sys.exit() at the end.
3032 (start): remove the unneighborly sys.exit()
3034 * Makefile: improve permission-setting to not kick Arch so badly
3036 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3037 default --keepalive=600, since it doesn't hurt very much, and it's
3038 a hassle to discover that you need it.
3039 * buildbot/test/test_runner.py (Create.testSlave): test it
3041 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3042 IRC bot about EXCEPTION
3044 * buildbot/status/client.py (PBListener): upcall more correctly
3046 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3047 an exception mark the overall build with EXCEPTION, not SUCCESS
3049 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3051 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3052 * Makefile: update some release-related stuff
3054 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3055 gets called when there isn't actually an active process, just end
3056 the Command instead of blowing up. I don't know how it gets into
3057 this state, but the twisted win32 buildslave will sometimes hang,
3058 and when it shakes its head and comes back, it thinks it's still
3059 running a Command. The next build causes this command to be
3060 interrupted, but the lack of self.process.pid breaks the interrupt
3063 * NEWS: document changes since the last release
3065 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3066 look for Makefile.buildbot instead of a bare Makefile . The
3067 'buildbot start' does not install this file, so you have to
3068 manually copy it if you want to customize startup behavior.
3069 (createMaster): change 'buildbot master' command to create
3070 Makefile.sample instead of Makefile, to create master.cfg.sample
3071 instead of master.cfg (requiring you to copy it before the
3072 buildmaster can be started). Both sample files are kept up to
3073 date, i.e. they are overwritten if they have been changed. The
3074 'buildbot.tac' file is *not* overwritten, but if the new contents
3075 don't match the old, a 'buildbot.tac.new' file is created and the
3076 user is warned. This seems to be a much more sane way to handle
3077 startup files. Also, don't sys.exit(0) when done, so we can run
3078 unit tests against it.
3079 (createSlave): same. Don't overwrite the sample info/ files.
3080 * buildbot/scripts/sample.mk: remove. the contents were pulled
3081 into runner.py, since they need to match the behavior of start()
3085 * docs/buildbot.texinfo (Launching the daemons): document it
3086 * buildbot/test/test_runner.py (Create): test it
3088 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3089 version that can handle string-in-string tests, because otherwise
3090 python-2.2 fails the tests. It'd be tremendous if Trial's test
3091 took two strings under 2.2 too.
3093 * everything: fixed all deprecation warnings when running against
3094 Twisted-2.0 . (at least all the ones in buildbot code, there are a
3095 few that come from Twisted itself). This involved putting most of
3096 the Twisted-version specific code in the new buildbot.twcompat
3097 module, and creating some abstract base classes in
3098 buildbot.changes.base and buildbot.status.base (which might be
3099 useful anyway). __implements__ is a nuisance and requires an ugly
3100 'if' clause everywhere.
3102 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
3103 delay before finishing the test: it seems that smtp.sendmail
3104 doesn't hang up on the server, so we must wait a moment so it can
3105 hang up on us. This removes the trial warning about an unclean
3108 2005-05-16 Brian Warner <warner@lothar.com>
3110 * buildbot/process/step.py (Source): add 'retry' argument. It is a
3111 tuple of (delay, repeats).
3112 * buildbot/test/test_vc.py (Retry): test it
3113 * docs/buildbot.texinfo (Source Checkout): document it
3114 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
3115 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
3116 doVCFull() are handled by re-trying the checkout (after a delay)
3117 some number of times.
3118 (ShellCommand._startCommand): make header lines easier to read
3120 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
3122 (WebTest.test_logfile): make sure master gets shut down, silences
3123 some "unclean reactor" test errors
3125 * buildbot/test/test_changes.py (Sender.tearDown): spin the
3126 reactor once after shutdown, something in certain versions of
3127 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
3128 fails, svn-trunk is ok.
3130 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
3131 second win32 error message
3133 * buildbot/test/test_run.py (Status.testSlave): be smarter about
3134 validating the ETA, so the tests don't fail on slow systems
3136 2005-05-15 Brian Warner <warner@lothar.com>
3138 * buildbot/status/builder.py (HTMLLogFile): make this behave like
3139 the new LogFile class, so upgrading works properly
3140 (LogFileProducer.resumeProducing): survive resumeProducing after
3141 we've exhausted the chunkGenerator
3143 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
3145 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
3146 (Log.testUpgrade): same
3148 * docs/buildbot.texinfo (Maintenance): describe how to delete old
3149 Builds and logs with a cron job.
3151 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
3152 of the old non-offline LogFile, added code to upgrade these to
3153 new-style contents-live-on-disk instances at load time (in a way
3154 that doesn't invalidate the old Build pickles, so upgrading to
3155 0.6.5 is not a one-way operation). Got rid of everything related
3157 (LogFile.__init__): create LogFiles with the parent step status,
3158 the log's name, and a builder-relative filename where it can keep
3159 the contents on disk.
3160 (LogFile.hasContents): new method, clients are advised to call it
3161 before getText or getChunks and friends. If it returns False, the
3162 log's contents have been deleted and getText() will raise an
3164 (LogFile.getChunks): made it a generator
3165 (LogFile.subscribeConsumer): new method, takes a Twisted-style
3166 Consumer (except one that takes chunks instead of strings). This
3167 enables streaming of very large logfiles without storing the whole
3169 (BuildStatus.generateLogfileName): create names like
3170 12-log-compile-output, with a _0 suffix if required to be unique
3171 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
3172 or earlier) logfiles into new-style ones
3173 (BuilderStatus): remove everything related to 'stub' builds. There
3174 is now only one build cache, and we don't strip logs from old
3176 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
3177 since we no longer fight to keep it in the cache
3179 * buildbot/status/html.py (TextLog.render_GET): use a
3180 ChunkConsumer to stream the log entries efficiently.
3181 (ChunkConsumer): wrapper which consumes chunks and writes
3184 * buildbot/test/test_twisted.py (Parse.testParse): use a
3185 LogFile-like object instead of a real one
3187 * buildbot/test/test_status.py (MyLog): handle new LogFile code
3188 (Log.testMerge3): validate more merge behavior
3189 (Log.testChunks): validate LogFile.getChunks
3190 (Log.testUpgrade): validate old-style LogFile upgrading
3191 (Log.testSubscribe): validate LogFile.subscribe
3192 (Log.testConsumer): validate LogFile.subscribeConsumer
3194 * buildbot/interfaces.py (IStatusLogStub): remove
3195 (IStatusLog.subscribeConsumer): new method
3196 (IStatusLog.hasContents): new method
3197 (IStatusLogConsumer): describes things passed to subscribeConsumer
3199 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
3200 the log contents if it does not have any contents.
3201 (StatusResourceBuildStep.body): same
3202 (StatusResourceBuildStep.getChild): give a 404 for empty logs
3204 2005-05-14 Brian Warner <warner@lothar.com>
3206 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
3207 timeouts to try and make the windows metabuildslave not hang
3209 2005-05-13 Mike Taylor <bear@code-bear.com>
3211 * buildbot/slave/commands.py (rmdirRecursive): added a check
3212 to ensure the path passed into rmdirRecursive actually exists.
3213 On win32 a non-existant path would generate an exception.
3215 2005-05-13 Brian Warner <warner@lothar.com>
3217 * buildbot/slave/commands.py (rmdirRecursive): replacement for
3218 shutil.rmtree which behaves correctly on windows in the face of
3219 files that you have to chmod before deleting. Thanks to Bear at
3220 the OSAF for the routine.
3221 (SourceBase.doClobber): use rmdirRecursive
3223 2005-05-12 Brian Warner <warner@lothar.com>
3225 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
3226 method generate chunks instead of returning a big list. This
3227 allows the same method to be used for both old LogFile and new
3229 (OfflineLogFile.getText): use the generator
3230 (OfflineLogFile.subscribe): same
3231 * buildbot/status/html.py (TextLog.resumeProducing): same
3232 * buildbot/interfaces.py (IStatusLog.getChunks): document it
3234 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
3235 point out that OfflineLogFile does not currently work with
3236 html.Waterfall . Fixing this is high-priority.
3238 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
3239 apparently windows defaults to using stdout
3241 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
3242 better message on failure so I can figure out the win32 problem
3244 * buildbot/slave/commands.py (ShellCommand._startCommand): update
3245 log messages to include more useful copies of the command being
3246 run, the argv array, and the child command's environment.
3247 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
3249 2005-05-11 Brian Warner <warner@lothar.com>
3251 * setup.py: oops, install debug.glade so 'buildbot debugclient'
3253 * Makefile: update the deb-snapshot version
3255 * docs/buildbot.texinfo: move all .xhtml docs into a new
3256 .texinfo-format document, adding a lot of material in the process.
3257 This is starting to look like a real user's manual. Removed all
3258 the Lore-related files: *.xhtml, *.css, template.tpl .
3259 * docs/Makefile: simple makefile to run 'makeinfo'
3260 * buildbot/scripts/sample.cfg: rearrange slightly
3261 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
3263 2005-05-10 Brian Warner <warner@lothar.com>
3265 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
3266 different name for the internal twistw module, handle it.
3268 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
3269 * setup.py: .. and stop trying to install it
3271 * buildbot/process/step.py (Git): added support for 'cogito' (aka
3272 'git'), the new linux kernel VC system (http://kernel.org/git/).
3273 Thanks to Brandon Philips for the patch.
3274 * buildbot/slave/commands.py (Git): same
3276 2005-05-06 Brian Warner <warner@lothar.com>
3278 * buildbot/status/builder.py (OfflineLogFile): replace the default
3279 LogFile with a form that appends its new contents to a disk file
3280 as they arrive. The complete log data is never kept in RAM. This
3281 is the first step towards handling very large (100MB+) logfiles
3282 without choking quite so badly. (The other half is
3283 producer/consumer on the HTML pages).
3284 (BuildStepStatus.addLog): use OfflineLogFile by default
3285 (BuildStatus.getLogfileName): helper code to give the
3286 OfflineLogFile a filename to work with
3288 * buildbot/test/test_status.py (Results.testAddResults): update
3289 tests to handle new asserts
3290 * buildbot/test/test_vc.py (Patch.doPatch): same
3291 * buildbot/test/test_steps.py (BuildStep.setUp): same
3293 2005-05-05 Brian Warner <warner@lothar.com>
3295 * buildbot/scripts/runner.py (start): if there is no Makefile,
3296 launch the app by importing twistd's internals and calling run(),
3297 rather than spawning a new twistd process. This stands a much
3298 better chance of working under windows.
3299 (stop): kill the process with os.kill instead of spawning
3300 /bin/kill, again to reduce the number of external programs which
3301 windows might not have in the PATH. Also wait up to 5 seconds for
3302 the process to go away, allowing things like 'buildbot stop;
3303 buildbot start' to be reliable in the face of slow shutdowns.
3305 * buildbot/master.py (Dispatcher.__getstate__): remove old
3306 .tap-related methods
3307 (BuildMaster.__getstate__): same
3309 * buildbot/slave/bot.py (makeService): same
3310 (Options.longdesc): same
3311 * buildbot/scripts/runner.py: copy over some old mktap option text
3313 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
3314 'buildbot master' now creates a buildbot.tac file, so there is no
3315 longer a create-instance/save/reload sequence. mktap is dead, long
3317 * buildbot/scripts/sample.mk: use twistd -y, not -f
3318 * buildbot/test/test_config.py: remove mktap-based test
3319 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
3320 * README: don't reference mktap
3322 * docs/source.xhtml: document some of the attributes that Changes
3325 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
3327 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
3328 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
3329 * buildbot/changes/changes.py (Change)
3330 * buildbot/changes/mail.py (parseSyncmail)
3331 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
3333 * buildbot/process/base.py (Build.isTagImportant)
3337 2005-05-04 Brian Warner <warner@lothar.com>
3339 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
3340 connection after sending the change, so that unit tests don't
3341 complain about sockets being left around
3343 * buildbot/status/html.py (WaterfallStatusResource.body): fix
3344 exception in phase=0 rendering
3345 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3347 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
3349 * buildbot/master.py (BuildMaster.loadConfig): finally remove
3350 deprecated config keys: webPortnum, webPathname, irc, manholePort,
3351 and configuring builders with tuples.
3352 * buildbot/test/test_config.py: stop testing compatibility with
3353 deprecated config keys
3354 * buildbot/test/test_run.py: same
3356 2005-05-03 Brian Warner <warner@lothar.com>
3358 * contrib/arch_buildbot.py: survive if there are no logfiles
3359 (username): just use a string, os.getlogin isn't reliable
3361 * buildbot/scripts/runner.py (sendchange): oops, fix the command
3362 so 'buildbot sendchange' actually works. The earlier test only
3363 covered the internal (non-reactor-running) form.
3365 * contrib/arch_buildbot.py: utility that can run as an Arch hook
3366 script to notify the buildmaster about changes
3368 * buildbot/scripts/runner.py (sendchange): new command to send a
3369 change to a buildbot.changes.pb.PBChangeSource receiver.
3370 * buildbot/test/test_changes.py (Sender): test it
3372 * buildbot/master.py (BuildMaster.startService): mark .readConfig
3373 after any reading of the config file, not just when we do it in
3374 startService. This makes some tests a bit cleaner.
3376 * buildbot/changes/pb.py: add some log messages
3378 * buildbot/process/base.py (Build.startBuild): fix a bug that
3379 caused an exception when the build terminated in the very first
3381 (Build.stepDone): let steps return a status of EXCEPTION. This
3382 terminates the build right away, and sets the build's overall
3383 status to EXCEPTION too.
3384 * buildbot/process/step.py (BuildStep.failed): return a status of
3385 EXCEPTION when that is what has happened.
3387 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3388 implement this, allowing Arch-based projects to get precise
3389 checkouts instead of always using the latest code
3390 (Bazaar): create variant of Arch to let folks use baz instead of
3391 tla. Requires a new buildslave too.
3392 * buildbot/slave/commands.py (Arch): add 'revision' argument
3393 (Bazaar): create variant of Arch that uses baz instead of tla.
3394 Remove the code that extracts the archive name from the
3395 register-archive output, since baz doesn't provide it, and require
3396 the user provide both the archive name and its location.
3397 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3399 2005-05-02 Brian Warner <warner@lothar.com>
3401 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3402 thanks to Nick Trout.
3404 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3405 deals better with source Makefile coming from a read-only CVS
3406 checkout. Thanks to Nick Trout for the catch.
3408 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3411 2005-04-28 Brian Warner <warner@lothar.com>
3413 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3415 * debian/changelog: update for 0.6.4
3417 2005-04-28 Brian Warner <warner@lothar.com>
3419 * README.w32: add a checklist of steps for getting buildbot
3421 * MANIFEST.in: include it in the tarball
3425 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3426 broken .tap files from 0.6.3 by getting rid of .services,
3427 .namedServices, and .change_svc at load time.
3429 2005-04-27 Brian Warner <warner@lothar.com>
3431 * NEWS: update in preparation for new release
3433 * buildbot/test/test_config.py (Save.testSave): don't pull in
3434 twisted.scripts.twistd, we don't need it and it isn't for windows
3437 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3438 accomodate win32 which can't do atomic-rename
3440 2005-04-27 Brian Warner <warner@lothar.com>
3442 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3443 timeouts to help the slow metabuildbot not flunk them so much
3444 (Disconnect.testBuild3): same
3445 (Disconnect.testBuild4): same
3446 (Disconnect.testInterrupt): same
3448 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3449 setup, it was completely broken for new buildmasters (those which
3450 did not have a 'change.pck' already saved. Thanks to Paul Warren
3451 for catching this (embarrassing!) bug.
3452 (Dispatcher.__getstate__): don't save our registered avatar
3453 factories, since they'll be re-populated when the config file is
3455 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3456 tests (since the real mktap-generated BuildMaster doesn't save
3458 (BuildMaster.__getstate__): don't save any service children,
3459 they'll all be re-populated when the config file is re-read.
3460 * buildbot/test/test_config.py (Save.testSave): test for this
3462 2005-04-26 Brian Warner <warner@lothar.com>
3464 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3465 rendered with Blender.. looks a bit nicer.
3466 * buildbot/docs/images/icon.blend: add the Blender file for it
3468 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3469 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3470 running under windows. This appears to be the best way to allow
3471 BuildSteps to do something normal like 'trial -v buildbot.test' or
3472 'make foo' and still expect it to work. The idea is to make the
3473 BuildSteps look as much like what a developer would type when
3474 compiling or testing the tree by hand. This approach probably has
3475 problems when there are spaces in the arguments, so if you've got
3476 windows buildslaves, you'll need to pay close attention to your
3479 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3480 timezone to the timestamp column.
3481 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3483 * buildbot/scripts/runner.py (loadOptions): do something sane for
3484 windows, I think. We use %APPDATA%/buildbot instead of
3485 ~/.buildbot, but we still search everywhere from the current
3486 directory up to the root for a .buildbot/ subdir. The "is it under
3487 $HOME" security test was replaced with "is it owned by the current
3488 user", which is only performed under posix.
3489 * buildbot/test/test_runner.py (Options.testFindOptions): update
3490 tests to match. The "is it owned by the current user" check is
3491 untested. The test has been re-enabled for windows.
3493 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3494 any "\n" in the expected output with the platform-specific line
3495 separator. Make this separator "\r\n" on PTYs under unix, they
3496 seem to do that and I don't know why
3498 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3499 windows for now, I don't know what ~/.buildbot/ should mean there.
3501 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3502 win32 compatibility, don't use "/tmp"
3503 (Basedir.testChangeBuilddir): remove more unixisms
3505 2005-04-26 Brian Warner <warner@lothar.com>
3507 * buildbot/test/test_control.py (Force.rmtree): python2.2
3508 compatibility, apparently its shutil.rmtree ignore_errors=
3509 argument is ignored.
3510 * buildbot/test/test_run.py (Run.rmtree): same
3511 (RunMixin.setUp): same
3513 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3516 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3517 'substring in string' operator, must use string.find(substr)!=-1
3518 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3519 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3521 * buildbot/scripts/runner.py (loadOptions): add code to search for
3522 ~/.buildbot/, a directory with things like 'options', containing
3523 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3524 the current directory, your $HOME directory, or anywhere
3525 inbetween, as long as you're somewhere inside your home directory.
3526 (debugclient): look in ~/.buildbot/options for master and passwd
3527 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3528 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3530 * buildbot/status/client.py (makeRemote): new approach to making
3531 IRemote(None) be None, which works under Twisted-2.0
3532 * buildbot/test/test_status.py (Client.testAdaptation): test it
3534 * buildbot/status/builder.py (Status.builderAdded): when loading a
3535 pickled BuilderStatus in from disk, set its name after loading.
3536 The config file might have changed its name (but not its
3537 directory) while it wasn't looking.
3539 * buildbot/process/builder.py (Builder.attached): always return a
3540 Deferred, even if the builder was already attached
3541 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3543 2005-04-25 Brian Warner <warner@lothar.com>
3545 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3546 category-related exception when announcing a build has finished
3548 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3549 reference no-longer-existent changemaster.sources
3550 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3552 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3555 2005-04-25 Brian Warner <warner@lothar.com>
3557 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3559 * debian/changelog: update for 0.6.3
3561 2005-04-25 Brian Warner <warner@lothar.com>
3563 * MANIFEST.in: make sure debug.glade is in the tarball
3565 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3567 * NEWS: update for the imminent 0.6.3 release
3569 * buildbot/status/html.py (HtmlResource.content): make the
3570 stylesheet <link> always point at "buildbot.css".
3571 (StatusResource.getChild): map "buildbot.css" to a static.File
3572 containing whatever css= argument was provided to Waterfall()
3573 (Waterfall): provide the "classic" css as the default.
3574 * docs/waterfall.classic.css: move default CSS from here ..
3575 * buildbot/status/classic.css: .. to here
3577 * MANIFEST.in: make sure classic.css is included in the tarball
3578 * setup.py: and that it is installed too, under buildbot/status/
3580 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3581 the module level, because buildbot.tap files from 0.6.2 don't have
3582 it in their attribute dictionary.
3584 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3585 really exists at startup, might save some confusion somewhere.
3587 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3589 * docs/waterfall.classic.css:
3590 add a stylesheet that's almost the same as the "classic"
3593 * buildbot/status/builder.py:
3594 add EXCEPTION as a result - this is a problem for the bot
3595 maintainer, not a build problem for the changers
3596 * buildbot/process/step.py:
3597 use EXCEPTION instead of FAILURE for exceptions
3598 * buildbot/status/html.py:
3599 add build_get_class to get a class out of a build/buildstep
3600 finish naming the classes
3601 split out sourceNames to changeNames and builderNames so we
3602 can style them separately
3603 * docs/config.xhtml:
3604 finish documenting classes as they are right now
3606 * buildbot/status/html.py:
3607 name the classes as we agreed on IRC
3608 * docs/config.xhtml:
3611 * buildbot/status/html.py:
3612 same for cssclass->class_
3614 * buildbot/status/html.py:
3615 as decided on IRC, use class_ for the "class" attribute to not
3616 conflict with the class keyword, and clean up the messy **{} stuff.
3618 * buildbot/status/mail.py:
3619 put back "builders" argument, and fix docstring, because the
3620 code *ignores* builders listed in this argument
3622 * buildbot/process/builder.py:
3623 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3625 * docs/config.xhtml:
3626 describe the category argument for builders
3628 * buildbot/status/builder.py:
3629 Fix a silly bug due to merging
3631 * buildbot/process/builder.py:
3632 remove category from the process Builder ...
3633 * buildbot/status/builder.py:
3634 ... and add it to BuilderStatus instead.
3635 Set category on unpickled builder statuses, they might not have it.
3636 * buildbot/master.py:
3637 include category when doing builderAdded
3638 * buildbot/status/mail.py:
3639 return None instead of self for builders we are not interested in.
3640 * buildbot/test/test_run.py:
3641 fix a bug due to only doing deferredResult on "dummy" waiting
3642 * buildbot/test/test_status.py:
3643 add checks for the Mail IStatusReceiver returning None or self
3645 * buildbot/status/html.py:
3646 fix testsuite by prefixing page title with BuildBot
3648 * buildbot/status/builder.py:
3649 have .category in builder status ...
3650 * buildbot/process/builder.py:
3651 ... and set it from Builder
3652 * buildbot/status/html.py:
3653 make .css a class variable
3654 * buildbot/test/test_status.py:
3655 write more tests to cover our categories stuff ...
3656 * buildbot/status/mail.py:
3657 ... and fix the bug that this uncovered
3659 * buildbot/changes/mail.py:
3660 * buildbot/changes/pb.py:
3661 * buildbot/master.py:
3662 * buildbot/process/base.py:
3663 * buildbot/process/factory.py:
3664 * buildbot/process/interlock.py:
3665 * buildbot/process/step.py:
3666 * buildbot/process/step_twisted.py:
3667 * buildbot/slave/commands.py:
3668 * buildbot/status/builder.py:
3669 * buildbot/status/client.py:
3670 * buildbot/status/html.py:
3671 * buildbot/status/mail.py:
3672 * buildbot/status/progress.py:
3673 * buildbot/test/test_changes.py:
3674 * buildbot/test/test_config.py:
3675 * buildbot/test/test_control.py:
3676 * buildbot/test/test_interlock.py:
3677 * buildbot/test/test_maildir.py:
3678 * buildbot/test/test_mailparse.py:
3679 * buildbot/test/test_run.py:
3680 * buildbot/test/test_slavecommand.py:
3681 * buildbot/test/test_status.py:
3682 * buildbot/test/test_steps.py:
3683 * buildbot/test/test_twisted.py:
3684 * buildbot/test/test_util.py:
3685 * buildbot/test/test_vc.py:
3686 * buildbot/test/test_web.py:
3688 add test-case-name at the top of a whole set of files
3690 * buildbot/status/builder.py:
3691 keep order of addition when getting builder names
3692 * buildbot/status/words.py:
3693 * buildbot/test/test_run.py:
3694 add test for getBuilderNames
3696 * buildbot/process/base.py:
3697 * buildbot/process/step.py:
3698 * buildbot/status/builder.py:
3699 * buildbot/status/html.py:
3700 make buildbot css-able
3701 replace the color code for purple with purple, don't understand
3702 why it wasn't purple to start with
3704 * buildbot/status/words.py:
3705 ok, so it doesn't look like BuilderStatus.remote is still valid.
3706 Use what waterfall uses instead.
3708 * buildbot/interfaces.py:
3709 * buildbot/status/builder.py:
3710 * buildbot/status/html.py:
3711 * buildbot/status/mail.py:
3712 * buildbot/status/words.py:
3713 * buildbot/test/test_run.py:
3714 use categories everywhere and make it be a list. More sensible
3715 for the future. Also make words actually respect this in
3718 * buildbot/interfaces.py:
3719 add category argument to getBuilderNames
3720 * buildbot/process/builder.py:
3721 * buildbot/status/builder.py:
3722 * buildbot/status/html.py:
3723 * buildbot/status/mail.py:
3724 * buildbot/status/words.py:
3725 * buildbot/test/test_run.py:
3726 move from specifying builders by name to specifying the category
3728 * buildbot/status/html.py:
3729 * buildbot/status/words.py:
3730 add "builders=" to __init__ of status clients so they can
3731 limit themselves to the given list of builders to report on
3733 * buildbot/status/html.py: set the title to the product name
3735 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3737 * buildbot/interfaces.py:
3738 * buildbot/status/builder.py:
3739 more documentation. Hm, not sure if ChangeLog entries make sense
3742 2005-04-23 Brian Warner <warner@lothar.com>
3744 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3746 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3748 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3749 the sub-commands that log buildmaster status to stdout and to a
3750 GUI window, respectively.
3752 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3753 functionality is working again, but all the step-status and ETA
3754 stuff is missing. Commented out a lot of code pending more
3757 * buildbot/status/client.py: make sure that IRemote(None) is None
3759 * buildbot/changes/changes.py: import defer, oops
3760 (ChangeMaster): remove the .sources list, rely upon the fact that
3761 MultiServices can be treated as sequences of their children. This
3762 cleans up the add/remove ChangeSource routines a lot, as we keep
3763 exactly one list of the current sources instead of three.
3765 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3766 up an empty ChangeMaster at init time.
3767 (BuildMaster.loadChanges): if there are changes to be had from
3768 disk, replace self.change_svc with the new ones. If not, keep
3769 using the empty ChangeMaster set up in __init__.
3770 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3771 instead of a separate list, makes the code a bit cleaner.
3772 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3773 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3774 Extend the test to make sure we can get rid of the sources when
3777 2005-04-22 Brian Warner <warner@lothar.com>
3779 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3780 and info/host files when making the slave directory
3782 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3783 whendone= argument, just return the Deferred and let the caller do
3784 what they want with it.
3785 (Disconnect.testBuild1): wait for shutdownSlave
3786 (Basedir.testChangeBuilddir): new test to make sure changes to the
3787 builddir actually get propagated to the slave
3789 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3790 explicit method, rather than passing the builddir in __init__ .
3791 Make sure to update self.basedir too, this was broken before.
3792 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3793 builders and for ones that have just had their builddir changed.
3794 (BotFactory): add a class-level .perspective attribute, so
3795 BuildSlave.waitUntilDisconnected won't get upset when the
3796 connection hasn't yet been established
3797 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3798 tests can reach through it to inspect the SlaveBuilders
3800 * buildbot/process/base.py (Build.buildException): explain the
3801 log.err with a log.msg
3802 * buildbot/process/builder.py (Builder.startBuild): same
3803 (Builder._startBuildFailed): improve error message
3805 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3806 occurred because we lost the brand-new connection, retry instead
3807 of giving up. If not, it's probably an authorization failure, and
3808 it makes sense to stop trying. Make sure we log.msg the reason
3809 that we're log.err'ing the failure, otherwise test failures are
3810 really hard to figure out.
3812 * buildbot/master.py: change loadConfig() to return a Deferred
3813 that doesn't fire until the change has been fully implemented.
3814 This means any connected slaves have been updated with the new
3815 builddir. This change makes it easier to test the code which
3816 actually implements this builddir-updating.
3817 (BotPerspective.addBuilder): return Deferred
3818 (BotPerspective.removeBuilder): same
3819 (BotPerspective.attached): same
3820 (BotPerspective._attached): same. finish with remote_print before
3821 starting the getSlaveInfo, instead of doing them in parallel
3822 (BotPerspective.list_done): same
3823 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3824 actually calling slave.disconnect()
3825 (BotMaster.addBuilder): same
3826 (BotMaster.removeBuilder): same
3827 (BuildMaster.loadConfig): same
3828 (BuildMaster.loadConfig_Slaves): same
3829 (BuildMaster.loadConfig_Sources): same
3830 (BuildMaster.loadConfig_Builders): same
3831 (BuildMaster.loadConfig_status): same
3833 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3834 a Deferred that fires when the source is finally removed
3836 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3837 the previous tree on win32, where we have to do it synchronously,
3838 make sure we return a Deferred anyway.
3839 (SourceBase.doCopy): same
3841 * buildbot/scripts/runner.py (statusgui): use the text client for
3842 now, while I rewrite the Gtk one
3843 * buildbot/clients/base.py: strip out old code, leaving just the
3844 basic print-message-on-event functionality. I also remove the
3845 ReconnectingPBClientFactory, but it does at least quit when it
3846 loses the connection instead of going silent
3848 2005-04-21 Brian Warner <warner@lothar.com>
3850 * Makefile: minor tweaks
3852 * NEWS: point out deprecation warnings, new features for
3855 * buildbot/master.py (BuildMaster.loadConfig): emit
3856 DeprecationWarnings for Builders defined with tuples. Rearrange
3857 code to facility removal of deprecated configuration keys in the
3860 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3861 'buildbot' command to put a little Makefile in the target that
3862 helps you re-create the buildbot.tap file, start or stop the
3863 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3864 all the files 0600, since they contain passwords.
3865 (start): if there is a Makefile, and /usr/bin/make exists, use
3866 'make start' in preference to a raw twistd command. This lets
3867 slave admins put things like PYTHONPATH variables in their
3868 Makefiles and have them still work when the slave is started with
3869 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3870 be nice to first try the 'make' command and only fall back to
3871 twistd if it fails. TODO: the Makefile's "start" command does not
3872 add the --reactor=win32 argument when running under windows.
3873 (Options.debugclient, Options.statusgui): add sub-commands to launch
3874 the debug client (formerly in contrib/debugclient.py) and the
3875 Gtk status application (currently broken)
3876 * buildbot/clients/debug.py: move from contrib/debugclient.py
3877 * buildbot/clients/debug.glade: same
3879 * buildbot/test/test_trial.py: remove it. This requires some
3880 functionality out of Twisted that isn't there yet, and until then
3881 having it around just confuses things.
3883 * buildbot/test/test_slavecommand.py (Shell): test both with and
3884 without PTYs, and make sure that command output is properly
3885 interleaved in the with-PTY case. I think the without-PTY test
3886 should pass on windows, where we never use PTYs anyway.
3888 2005-04-20 Brian Warner <warner@lothar.com>
3890 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3892 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3894 * NEWS: start creating entries for the next release
3896 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3898 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3899 (WebTest.test_webPathname): same
3900 (WebTest.test_webPathname_port): same
3901 (WebTest.test_waterfall): use the default favicon rather than
3902 rooting around the filesystem for it. Open the expected-icon file
3903 in binary mode, to make win32 tests happier (thanks to Nick Trout
3905 * buildbot/status/html.py (buildbot_icon): win32 portability
3907 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3908 win32-compatibility fixes from Nick Trout, the "file not found" message
3909 is different under windows
3910 (FakeSlaveBuilder.__init__): clean up setup a bit
3911 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3913 2005-04-19 Brian Warner <warner@lothar.com>
3915 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3916 skip-if-repositories-are-unavailable test to not kill the trial
3917 that comes with Twisted-1.3.0
3919 * setup.py: install buildbot.png icon file when installing code
3921 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3922 environment used by the command, at least on the child side.
3924 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3925 this method needs to be added and implemented because it gets
3926 called under heavy load. I don't quite understand the
3927 producer/consumer API enough to write it.
3928 (StatusResource.getChild): add a resource for /favicon.ico
3929 (Waterfall.__init__): add favicon= argument
3930 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3931 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3932 (WebTest.test_webPathname): same
3933 (WebTest.test_webPathname_port): same
3934 * docs/config.xhtml: mention favicon=
3935 * buildbot/buildbot.png: add a default icon, dorky as it is
3937 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3939 * buildbot/master.py:
3940 * buildbot/process/base.py:
3941 * buildbot/process/builder.py:
3942 * buildbot/process/interlock.py:
3943 * buildbot/status/builder.py:
3944 * buildbot/status/html.py:
3945 * buildbot/status/mail.py:
3946 * buildbot/status/words.py:
3947 new documentation while digging through the code
3949 2005-04-17 Brian Warner <warner@lothar.com>
3951 * general: try to fix file modes on all .py files: a+r, a-x,
3952 but let buildbot/clients/*.py be +x since they're tools
3954 * docs/epyrun (addMod): when an import fails, say why
3956 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3958 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3960 * buildbot/process/base.py:
3961 * buildbot/process/builder.py:
3962 * buildbot/status/builder.py:
3963 new documentation while digging through the code
3965 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3967 * buildbot/changes/changes.py:
3968 * buildbot/changes/p4poller.py:
3969 * buildbot/interfaces.py:
3970 * buildbot/process/base.py:
3971 * buildbot/process/builder.py:
3972 * buildbot/process/step.py:
3973 * buildbot/process/step_twisted.py:
3974 * buildbot/slave/bot.py:
3975 * buildbot/slave/commands.py:
3976 * buildbot/status/builder.py:
3977 fix all docstrings to make epydoc happy. In the process of fixing
3978 some, I also moved pieces of docs, and removed some deprecated
3981 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3983 * buildbot/process/builder.py:
3984 * buildbot/process/interlock.py:
3985 * buildbot/process/process_twisted.py:
3986 * buildbot/process/step.py:
3987 BuildProcess -> Build, as it looks like that's what happened
3988 * buildbot/process/base.py:
3989 * buildbot/process/factory.py:
3992 2005-04-17 Brian Warner <warner@lothar.com>
3994 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3995 update compile command to accomodate the Twisted split.. now
3996 instead of './setup.py build_ext -i', you do './setup.py all
3997 build_ext -i', to run build_ext over all sub-projects.
3998 (FullTwistedBuildFactory): same
3999 (TwistedReactorsBuildFactory): same
4001 * buildbot/status/html.py (TextLog.finished): null out self.req
4002 when we're done, otherwise the reference cycle of TextLog to .req
4003 to .notifications to a Deferred to TextLog.stop keeps them from
4004 being collected, and consumes a huge (610MB on pyramid at last
4005 check) amount of memory.
4007 2005-04-11 Brian Warner <warner@lothar.com>
4009 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4010 normalize the VC-repository location.. makes SVN happier with
4011 certain test environments.
4013 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4014 RemoteShellCommand gets its own .env dictionary, so that code in
4015 start() doesn't mutate the original. I think this should fix the
4016 step_twisted.Trial problem where multiple identical components
4017 kept getting added to PYTHONPATH= over and over again.
4019 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4020 adding epydoc-format docstrings to many classes. Thanks to Thomas
4021 Vander Stichele for the patches.
4022 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4023 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4024 * buildbot/slave/bot.py, commands.py, registry.py: same
4026 2005-04-05 Brian Warner <warner@lothar.com>
4028 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4029 preserve timestamps, helps incremental builds of large trees.
4030 Patch from Rene Rivera.
4032 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4033 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4036 2005-04-03 Brian Warner <warner@lothar.com>
4038 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4039 with one dict, apparently exec has some scoping bugs when used
4040 with both global/local dicts. Thanks to Nathaniel Smith for the
4043 2005-04-02 Brian Warner <warner@lothar.com>
4045 * buildbot/process/step_twisted.py (countFailedTests): the new
4046 trial in Twisted-2.0 emits a slightly different status line than
4047 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4048 mistakenly think the test count is unparseable.
4049 (Trial.start): note that for some reason each build causes another
4050 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4051 be fixed but I'm not sure quite where the problem is.
4053 2005-04-01 Brian Warner <warner@lothar.com>
4055 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4056 deferredResult to avoid hangs/warnings under twisted-2.0
4057 (RunMixin.tearDown): same
4058 (RunMixin.shutdownSlave): same
4059 (Disconnect.testIdle1): same
4060 (Disconnect.testBuild2): same: wait one second after the build
4061 finishes for test to really be done.. this should be cleaned up to
4062 avoid wasting that second. Builder.detach uses a callLater(0),
4063 either that should be done in-line (something else needed that
4064 behavior), or it should return a Deferred that fires when the
4065 builder is really offline.
4066 (Disconnect.testBuild3): same
4067 (Disconnect.testDisappear): same
4069 * buildbot/test/test_web.py: rearrange server-setup and teardown
4070 code to remove unclean-reactor warnings from twisted-2.0
4072 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4073 so the tests don't hang under twisted-2.0
4075 2005-03-31 Brian Warner <warner@lothar.com>
4077 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4078 caused a warning each time the master changed our set of builders
4080 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4081 w32, don't unlink the file unless it already exists. Thanks to
4082 Baptiste Lepilleur for the catch.
4083 (BuilderStatus.saveYourself): same
4085 2005-02-01 Brian Warner <warner@lothar.com>
4087 * buildbot/status/html.py (TextLog.getChild): use a /text child
4088 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4089 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4090 logfile as text/plain (no markup, no headers). This replaces the
4091 previous scheme (which used an ?text=1 argument), and gets us back
4092 to a relative link (which works better when the buildbot lives
4093 behind another web server, such as Apache configured as a reverse
4094 proxy). Thanks to Gerald Combs for spotting the problem.
4096 * buildbot/__init__.py (version): bump to 0.6.2+ while between
4099 2004-12-13 Brian Warner <warner@lothar.com>
4101 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
4103 * debian/changelog: update for 0.6.2
4104 * NEWS: finalize for 0.6.2
4106 2004-12-11 Brian Warner <warner@lothar.com>
4108 * NEWS: bring it up to date
4110 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
4111 detection code. Require some sign of life from the buildmaster
4112 every BotFactory.keepaliveInterval seconds. Provoke this
4113 indication at BotFactory.keepaliveTimeout seconds before the
4114 deadline by sending a keepalive request. We don't actually care if
4115 that request is answered in a timely fashion, what we care about
4116 is that .activity() is called before the deadline. .activity() is
4117 triggered by any PB message from the master (including an ack to
4118 one of the slave's status-update messages). With this new scheme,
4119 large status messages over slow pipes are OK, as long as any given
4120 message can be sent (and thus acked) within .keepaliveTimeout
4121 seconds (which defaults to 30).
4122 (SlaveBuilder.remote_startCommand): record activity
4123 (SlaveBuilder.ackUpdate): same
4124 (SlaveBuilder.ackComplete): same
4125 (BotFactory.gotPerspective): same
4126 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
4128 2004-12-09 Brian Warner <warner@lothar.com>
4130 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
4133 * buildbot/process/step_twisted.py (Trial._commandComplete):
4134 update self.cmd when we start the 'cat test.log' transfer. Without
4135 this, we cannot interrupt the correct RemoteCommand when we lose
4138 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
4139 trying to tell the slave to stop the command if we're already
4140 inactive, or if we no longer have a .remote
4142 * buildbot/process/builder.py (Builder._detached): don't let an
4143 exception in currentBuild.stopBuild() prevent the builder from
4144 being marked offline
4146 2004-12-07 Brian Warner <warner@lothar.com>
4148 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
4149 KeyError that happens when you ask for a non-existent Builder, and
4150 translate it into a UsageError.
4152 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
4153 losing the slave in the middle of a remote step is handled too
4155 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
4156 be a Failure, so be sure to stringify it before using it as the
4157 contents of the 'interrupt' logfile
4158 (RemoteCommand.interrupt): use stringified 'why' in
4159 remote_interruptCommand too, just in case
4161 2004-12-06 Brian Warner <warner@lothar.com>
4163 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
4164 instead of 'tla update', which is more efficient in case we've
4165 missed a couple of patches since the last update.
4167 * debian/changelog: update for previous (0.6.1) release. Obviously
4168 this needs to be handled better.
4170 2004-12-05 Brian Warner <warner@lothar.com>
4172 * NEWS: update for stuff since last release
4174 * buildbot/master.py (DebugPerspective.attached): return 'self', to
4175 match the maybeDeferred change in Dispatcher.requestAvatar
4176 * buildbot/changes/pb.py (ChangePerspective.attached): same
4177 * buildbot/status/client.py (StatusClientPerspective.attached): same
4178 * buildbot/process/builder.py (Builder._attached3): same
4179 * buildbot/pbutil.py (NewCredPerspective.attached): same
4181 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
4182 the date to the top-most box, if it is not the same as today's
4185 * docs/slave.xhtml: provide a buildslave setup checklist
4187 * docs/source.xhtml (Arch): correct terminology
4189 2004-12-04 Brian Warner <warner@lothar.com>
4191 * buildbot/test/test_slavecommand.py: use sys.executable instead
4192 of hard-coding 'python' for child commands, might help portability
4194 * docs/examples/twisted_master.cfg: update to current usage
4196 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
4197 'stop build' command to the IRC bot
4199 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
4200 message that broke PBChangeSource
4202 * buildbot/slave/bot.py: clean up shutdown/lose-master code
4203 (SlaveBuilder): make some attributes class-level, remove the old
4204 "update queue" which existed to support resuming a build after the
4205 master connection was lost. Try to reimplement that feature later.
4206 (SlaveBuilder.stopCommand): clear self.command when the
4207 SlaveCommand finishes, so that we don't try to kill a leftover one
4209 (SlaveBuilder.commandComplete): same, merge with commandFailed and
4212 * buildbot/slave/commands.py (SourceBase): set self.command for
4213 all VC commands, so they can be interrupted.
4215 2004-12-03 Brian Warner <warner@lothar.com>
4217 * buildbot/master.py: clean up slave-handling code, to handle
4218 slave-disconnect and multiple-connect better
4219 (BotPerspective): make these long-lasting, exactly one per bot
4220 listed in the config file.
4221 (BotPerspective.attached): if a slave connects while an existing
4222 one appears to still be connected, disconnect the old one first.
4223 (BotPerspective.disconnect): new method to forcibly disconnect a
4224 buildslave. Use some hacks to empty the transmit buffer quickly to
4225 avoid the long (20-min?) TCP timeout that could occur if the old
4226 slave has dropped off the net.
4227 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
4228 own their own SlaveStatus objects. Remove .attached/.detached, add
4229 .addSlave/.removeSlave, treat slaves like Builders (config file
4230 parsing sends deltas to the BotMaster). Inform the slave
4231 instances, i.e. the BotPerspective, about addBuilder and
4233 (BotMaster.getPerspective): turns into a single dict lookup
4234 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
4235 which gives BotPerspective.attached a chance to disconnect the old
4237 (BuildMaster.loadConfig): add code (disabled) to validate that all
4238 builders use known slaves (listed in c['bots']). The check won't
4239 work with tuple-specified builders, which are deprecated but not
4240 yet invalid, so the check is disabled for now.
4241 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
4242 routine, do the add/changed/removed dance with them like we do
4244 (BuildMaster.loadConfig_Sources): move source-config into a
4245 separate routine too
4247 * buildbot/status/builder.py (Status.getSlave): get the
4248 SlaveStatus object from the BotPerspective, not the BotMaster.
4250 * buildbot/test/test_run.py: bunch of new tests for losing the
4251 buildslave at various points in the build, handling a slave that
4252 connects multiple times, and making sure we can interrupt a
4255 * buildbot/slave/bot.py (BuildSlave): make it possible to use
4256 something other than 'Bot' for the Bot object, to make certain
4257 test cases easier to write.
4258 (BuildSlave.waitUntilDisconnected): utility method for testing
4260 2004-11-30 Brian Warner <warner@lothar.com>
4262 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
4264 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
4265 argument, return a Deferred that always fires with True or False.
4266 I don't use an errback to indicate 'ping failed' so that callers
4267 are free to ignore the deferred without causing spurious errors in
4269 * buildbot/process/builder.py (BuilderControl.ping): implement it
4271 * buildbot/test/test_run.py (Status.testDisappear): test ping
4272 (Status.disappearSlave): fix it
4274 2004-11-30 Brian Warner <warner@lothar.com>
4276 * buildbot/interfaces.py (IBuildControl): add .stopBuild
4277 (IBuilderControl): add .getBuild(num), only works for the current
4278 build, of course, although it might be interesting to offer
4279 something for builds in the .waiting or .interlocked state.
4281 * buildbot/process/base.py (Build): have .stopBuild just do the
4282 interrupt, then let the build die by itself.
4283 (BuildControl): add .stopBuild, and add a point-event named
4284 'interrupt' just after the build so status viewers can tell that
4286 (BuilderControl): add .getBuild
4288 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
4289 stops when you kill it, good for testing
4290 (ShellCommand.interrupt): add a logfile named 'interrupt' which
4291 contains the 'reason' text.
4293 * buildbot/status/html.py: Add Stop Build button, if the build can
4294 still be stopped. Send a Redirect (to the top page) one second
4295 later, hopefully long enough for the interrupt to have an effect.
4296 Move make_row() up to top-level to share it between Stop Build and
4299 * buildbot/slave/commands.py: only kill the child process once
4301 * buildbot/test/test_run.py: add testInterrupt
4303 2004-11-29 Brian Warner <warner@lothar.com>
4305 * buildbot/process/base.py: Refactor command interruption. The
4306 Build is now responsible for noticing that the slave has gone
4307 away: Build.lostRemote() interrupts the current step and makes
4308 sure that no further ones will be started.
4310 * buildbot/process/builder.py: When the initial remote_startBuild
4311 message fails, log it: this usually indicates that the slave has
4312 gone away, but we don't really start paying attention until they
4313 fail to respond to the first step's command.
4315 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
4316 slave disconnect. Now sports a new interrupt() method. Error
4317 handling was simplified a lot by chaining deferreds, so
4318 remoteFailed/remoteComplete were merged into a single
4319 remoteComplete method (which can now get a Failure object).
4320 Likewise failed/finished were merged into just _finished.
4321 (BuildStep): Add interrupt(why) method, and if why is a
4322 ConnectionLost Failure then the step is failed with some useful
4325 * buildbot/slave/bot.py: stop the current command when the remote
4326 Step reference is lost, and when the slave is shut down.
4327 (Bot): make it a MultiService, so it can have children. Use
4328 stopService to tell when the slave is shutting down.
4329 (SlaveBuilder): make it a Service, and a child of the Bot. Add
4330 remote_interruptCommand (which asks the current SlaveCommand to
4331 stop but allows it to keep emitting status messages), and
4332 stopCommand (which tells it to shut up and die).
4334 * buildbot/slave/commands.py: make commands interruptible
4335 (ShellCommand.kill): factor out os.kill logic
4336 (Command): factor out setup()
4337 (Command.sendStatus): don't send status if .running is false, this
4338 happens when the command has been halted.
4339 (Command.interrupt): new method, used to tell the command to die
4340 (SlaveShellCommand): implement .interrupt
4341 (DummyCommand): implement .interrupt
4342 (SourceBase, etc): factor out setup(), don't continue substeps if
4345 * buildbot/status/builder.py: fix all waitUntilFinished() methods
4346 so they can be called after finishing
4348 * buildbot/test/test_run.py: new tests for disconnect behavior,
4349 refactor slave-shutdown routines, add different kinds of
4352 2004-11-27 Brian Warner <warner@lothar.com>
4354 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
4355 method to express ETA time like "2m45s" instead of "165 seconds"
4357 2004-11-24 Brian Warner <warner@lothar.com>
4359 * buildbot/test/test_vc.py (VC.testArch): unregister the test
4360 archive after the test completes, to avoid cluttering the user's
4361 'tla archives' listing with a bogus entry. Arch doesn't happen to
4362 provide any way to override the use of ~/.arch-params/, so there
4363 isn't a convenient way to avoid touching the setup of the user who
4365 (VC_HTTP.testArchHTTP): same
4367 2004-11-23 Brian Warner <warner@lothar.com>
4369 * buildbot/status/html.py (TextLog): split render() up into
4370 render_HEAD and render_GET. Use a Producer when sending log
4371 chunks, to reduce memory requirements and avoid sending huge
4372 non-Banana-able strings over web.distrib connections. Requires
4373 peeking under the covers of IStatusLog.
4374 (TextLog.resumeProducing): fix the "as text" link, handle client
4375 disconnects that occur while we're still sending old chunks.
4377 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
4378 use defer.succeed, not the non-existent defer.success
4379 (LogFile.waitUntilFinished): same
4380 (LogFile.subscribe): don't add watchers to a finished logfile
4382 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4385 2004-11-23 Brian Warner <warner@lothar.com>
4387 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4389 2004-11-23 Brian Warner <warner@lothar.com>
4391 * NEWS: update for the 0.6.1 release
4392 * MANIFEST.in: add new files
4394 * README (INSTALLATION): explain how to enable the extra VC tests
4396 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4397 level to, so old pickled builds can be displayed ok
4399 2004-11-22 Brian Warner <warner@lothar.com>
4401 * NEWS: summarize updates since last release
4403 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4404 Yoz Grahame. Closes SF#1050138.
4406 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4409 * buildbot/process/step_twisted.py (Trial): update docs a bit
4411 * docs/factories.xhtml: fix Trial factory docs to match reality.
4414 * buildbot/process/factory.py (Trial.__init__): add args for
4415 randomly= and recurse=, making them available to instantiators
4416 instead of only to subclassers. Closes: SF#1049759.
4418 2004-11-15 Brian Warner <warner@lothar.com>
4420 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4421 try to teach the Quick factory to use multiple versions of python
4423 2004-11-12 Brian Warner <warner@lothar.com>
4425 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4426 safer w32-compatible approach, and only use it on windows
4427 (BuildStatus.saveYourself): same
4429 2004-11-11 Brian Warner <warner@lothar.com>
4431 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4432 it: one string merge per chunk. There are now separate .entries
4433 and .runEntries lists: when enumerating over all chunks, make sure
4435 * buildbot/test/test_status.py (Log): more tests
4437 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4438 chunks together, up to 10kb per chunk. This ought to cut down on
4439 the CPU-burning overhead of large log files. Thanks to Alexander
4440 Staubo for spotting the problem.
4441 * buildbot/test/test_status.py (Log): tests for same
4443 2004-11-10 Brian Warner <warner@lothar.com>
4445 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4446 header to outbound mail
4447 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4449 2004-11-08 Brian Warner <warner@lothar.com>
4451 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4452 can't do os.rename() onto an existing file, so catch the exception
4453 and unlink the target file first. This introduces a slight window
4454 where the existing file could be lost, but the main failure case
4455 (disk full) should still be handled safely.
4456 (BuildStatus.saveYourself): same
4458 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4459 separator character instead of os.sep, because the filenames being
4460 split here are coming from the VC system, which can have a
4461 different pathname convention than the local host. This should
4462 help a buildmaster running on windows that uses a CVS repository
4463 which runs under unix.
4464 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4466 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4467 when there are no test failures to be parsed
4469 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4470 instead of the unix-specific os.system("cp"), thanks to Elliot
4471 Murphy for this and the other buildbot-vs-windows catches.
4472 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4474 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4475 echo the command as it is run
4477 * setup.py: install sample.mk too, not just sample.cfg
4478 (scripts): install contrib/windows/buildbot.bat on windows
4480 2004-11-07 Brian Warner <warner@lothar.com>
4482 * buildbot/process/builder.py (Builder._detached): clear the
4483 self.currentBuild reference, otherwise the next build will be
4484 skipped because we think the Builder is already in use.
4486 * docs/examples/twisted_master.cfg: update to match current usage
4487 on the Twisted buildbot
4489 2004-10-29 Brian Warner <warner@lothar.com>
4491 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4493 2004-10-28 Brian Warner <warner@lothar.com>
4495 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4496 have separate doVCUpdate/doVCFull methods. Catch an update failure
4497 and respond by clobbering the source directory and re-trying. This
4498 will handle local changes (like replacing a file with a directory)
4499 that will cause CVS and SVN updates to fail.
4500 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4502 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4505 2004-10-19 Brian Warner <warner@lothar.com>
4507 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4509 * buildbot/status/html.py (StatusResourceTestResults): display any
4510 TestResults that the Build might have
4511 (StatusResourceTestResult): and the logs for each TestResult
4512 (StatusResourceBuild): add link from the per-build page
4514 2004-10-15 Brian Warner <warner@lothar.com>
4516 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4517 the 'problems' portion of stdout, add TestResults to our build
4518 * buildbot/test/test_twisted.py (Parse.testParse): test it
4520 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4521 to retrieve a dict of accumulated test results
4522 (ITestResult): define what a single test result can do
4523 * buildbot/status/builder.py (TestResult): implement ITestResult
4524 (BuildStatus.getTestResults): retrieve dict of TestResults
4525 (BuildStatus.addTestResult): add TestResults
4526 * buildbot/test/test_status.py (Results.testAddResults): test it
4528 2004-10-14 Brian Warner <warner@lothar.com>
4530 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4531 instead of os.system("rm -rf") for win32 portability
4533 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4534 SignalMixin instead of starting/stopping the reactor, which is
4535 likely to cause problems with other tests
4537 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4538 self.copyComplete() call. Yoz Grahame makes the catch.
4540 * contrib/windows/buildbot.bat: helper script to deal with path
4541 issues. Thanks to Yoz Grahame.
4543 * buildbot/master.py (BuildMaster.startService): don't register a
4544 SIGHUP handler if the signal module has no SIGHUP attribute.
4545 Apparently win32 does this.
4547 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4549 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4550 test if the reactor can't offer UNIX sockets
4552 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4553 error introduced in the last commit. We really need that
4556 2004-10-12 Brian Warner <warner@lothar.com>
4558 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4559 when describing a maildir source. Thanks to Stephen Davis.
4561 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4564 * buildbot/scripts/runner.py (createMaster): install Makefile too
4565 (start): add --no_save to 'start' command
4566 * buildbot/scripts/sample.mk: simple convenience Makefile with
4567 start/stop/reload targets
4569 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4572 2004-09-30 Brian Warner <warner@lothar.com>
4574 * setup.py: Releasing buildbot-0.6.0
4576 2004-09-30 Brian Warner <warner@lothar.com>
4578 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4579 test_trial.py from the source tarball until support is complete.
4581 * NEWS: update for 0.6.0 release
4582 * buildbot/__init__.py (version): same
4585 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4586 'source' command to tell users where to get the Buildbot source
4588 * docs/examples/*.cfg: update to modern standards
4590 * NEWS: update for release
4592 * buildbot/scripts/runner.py (createMaster): remove the
4593 -shutdown.tap stuff now that it isn't necessary
4595 (start): launch buildbot.tap, not buildbot-shutdown.tap
4598 * buildbot/status/mail.py (Domain): shorten class name
4599 (MailNotifier): if lookup= is a string, pass it to Domain()
4600 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4601 (Mail.testBuild2): test the string-to-Domain shortcut
4602 (Mail.testMail): fix test
4605 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4608 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4609 more attributes on load
4610 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4611 to accomodate the whole waterfall page at once, and the thrashing
4612 results in a lot of unnecessary loads
4613 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4614 (BuilderStatus.saveYourself): same
4615 (BuilderStatus.eventGenerator): stop generating on the first missing
4616 build. We assume that saved builds are deleted oldest-first.
4617 (BuildStepStatus.__getstate__): .progress might not exist
4619 * buildbot/changes/changes.py (ChangeMaster): make it
4620 serializable, in $masterdir/changes.pck
4621 (ChangeMaster.stopService): save on shutdown
4622 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4623 * buildbot/test/test_config.py: load Changes before config file
4626 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4627 "Oh my god, you killed the command" header on a separate line
4629 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4630 skip over corrupted build pickles
4631 (BuilderStatus.getFullBuildByNumber): same
4632 (BuilderStatus.eventGenerator): skip over unavailable builds
4633 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4634 do an atomic rename. This prevents a corrupted pickle when some
4635 internal serialization error occurs.
4636 (BuilderStatus.saveYourself): same
4638 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4639 the timeout for shell commands, it got lost somehow
4641 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4642 run out of build steps, return the rest of the builder events
4644 * buildbot/interfaces.py (IBuilderControl.ping): add method
4646 * buildbot/process/builder.py (BuilderControl.ping): move
4647 slave-ping to BuilderControl, and fix the failure case in the
4648 process (Event.finish() is the verb, Event.finished is the noun).
4650 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4651 through the BuilderControl instead of the BuilderStatus
4652 (EventBox): add adapter for builder.Event, allowing builder events to
4653 be displayed in the waterfall display
4655 * buildbot/master.py (BotMaster.stopService): add a 'master
4656 shutdown' event to the builder's log
4657 (BuildMaster.startService): and a 'master started' on startup
4659 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4660 builder events into the BuildStep event stream
4661 (Status.builderAdded): add a 'builder created' event
4664 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4665 command to announce the completion of a running build
4666 (IrcStatusBot.command_FORCE): announce when the build finishes
4668 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4669 don't evict unfinished builds from the cache: they must stay in
4670 the full-cache until their logfiles have stopped changing. Make
4671 sure the eviction loop terminates if an unfinished build was hit.
4672 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4673 This lets exceptions be dumped in an email status message. Really
4674 we need LogFiles which contain both text and HTML, instead of two
4676 (BuildStatus.__getstate__): handle self.finished=False
4677 (Status.builderAdded): if the pickle is corrupted, abandon the
4678 history and create a new BuilderStatus object.
4680 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4681 self.progress attribute, helped one test which doesn't fully set
4682 up the Build object.
4684 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4685 IStatusLog methods into an Interface that is implemented by "stub"
4686 logs, for which all the actual text chunks are on disk (in the
4687 pickled Build instance). To show the log contents, you must first
4688 adapt the stub log to a full IStatusLog object.
4690 * buildbot/status/builder.py (LogFileStub): create separate stub
4691 log objects, which can be upgraded to a real one if necessary.
4692 (LogFile): make them persistable, and let them stubify themselves
4694 (BuildStepStatus): same
4696 (BuildStatus.saveYourself): save the whole build out to disk
4697 (BuilderStatus): make it persistable
4698 (BuilderStatus.saveYourself): save the builder to disk
4699 (BuilderStatus.addFullBuildToCache): implement two caches which
4700 hold Build objects: a small one which holds full Builds, and a
4701 larger one which holds "stubbed" Builds (ones with their LogFiles
4702 turned into LogFileStubs). This reduces memory usage by the
4703 buildmaster by not keeping more than a few (default is 2) whole
4704 build logs in RAM all the time.
4705 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4707 (BuilderStatus.eventGenerator): rewrite since .builds went away
4708 (BuilderStatus.buildStarted): remove the .builds array. Add the
4709 build to the "full" cache when it starts.
4710 (BuilderStatus._buildFinished): save the build to disk when it
4712 (Status): give it a basedir (same as the BuildMaster's basedir)
4713 where the builder pickles can be saved
4714 (Status.builderAdded): create the BuilderStatus ourselves, by
4715 loading a pickle from disk (or creating a new instance if there
4716 was none on disk). Return the BuilderStatus so the master can glue
4717 it into the new Builder object.
4719 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4720 all BuilderStatuses to save themselves out to disk. This is in
4721 lieu of saving anything important in the main Application pickle
4722 (the -shutdown.tap file).
4723 (BuildMaster.__init__): give Status() a basedir for its files
4724 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4725 to get the BuilderStatus, then give it to the Builder (instead of
4726 doing it the other way around). It's ok if the status announces
4727 the new Builder before it's really ready, as the outside world can
4728 only see the BuilderStatus object anyway (and it is ready before
4729 builderAdded returns). Use the builder's "builddir" (which
4730 normally specifies where the slave will run the builder) as the
4731 master's basedir (for saving serialized builds).
4733 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4734 coerce the logfile to IStatusLog before trying to get the text
4735 chunks out of it. This will pull the full (non-stubified) Build in
4736 from disk if necessary.
4737 (TextLog): fix the adapter registration
4739 * buildbot/test/test_control.py (Force.setUp): create the basedir
4740 * buildbot/test/test_web.py: same
4741 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4742 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4743 * buildbot/test/test_run.py (Run.testMaster): same
4744 (Status.setUp): same
4746 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4748 * buildbot/status/html.py (Waterfall.__init__): store actual
4749 allowForce flag passed in rather than using True for everyone;
4750 make sure setting it to False doesn't cause a NameError
4752 (StatusResourceBuilder.__init__) add the builder name to the page
4754 (StatusResourceBuilder.body) move HTML generation for a name/value
4755 row into a helper method (StatusResourceBuilder.make_row); only
4756 generate the "Force Build" form if allowForce was True and the
4757 slave is connected. Use class attributes in the generated HTML to
4758 spread a little CSS-joy.
4760 2004-09-28 Brian Warner <warner@lothar.com>
4762 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4763 warning-scanner to not ignore things like
4764 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4766 * buildbot/status/html.py (StatusResource.control): add some
4767 class-level values for .control in an attempt to make upgrading
4770 * buildbot/util.py (ComparableMixin): survive missing attributes,
4771 such as when a class is modified and we're comparing old instances
4774 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4775 failure handling, remove a redundant try/except block. Don't
4776 return the full traceback to the IRC channel.
4777 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4778 error messages. Get ETA properly.
4780 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4781 the reason, since (at least) IRC message will have <> in them.
4782 (StatusResourceBuilder.__init__): take an IBuilderControl
4783 (StatusResourceBuilder.force): use the IBuilderControl we get in
4784 the constructor instead of trying to make our own. Catch the
4785 new exceptions and ignore them for now (until we make an
4786 intermediate web page where we could show the error message)
4787 (StatusResource): create with an IControl, use it to give an
4788 IBuilderControl to all children
4789 (Waterfall): take an allowForce= option, pass an IControl object
4790 to StatusResource if it is True
4792 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4794 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4795 catch new exceptions and return string forms
4797 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4798 * buildbot/process/builder.py (Builder.forceBuild): raise them
4799 * buildbot/test/test_control.py (Force.testNoSlave): new test
4800 (Force.testBuilderInUse): same
4803 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4805 * buildbot/test/test_run.py: use IControl
4806 * buildbot/test/test_vc.py: same
4808 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4809 to use IControl. Still offline.
4810 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4812 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4813 who=None so periodic builds don't send out status mail
4814 (Builder.forceBuild): include reason in the log message
4815 (BuilderControl.forceBuild): rename 'name' to 'who'
4817 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4818 'who' parameter, but make it None by default so builds forced by
4819 slave admins don't cause status mail to be sent to anybody
4820 (BotMaster.forceBuild): same. this method is deprecated.
4821 (DebugPerspective.perspective_forceBuild): same, use IControl.
4822 (DebugPerspective.perspective_fakeChange): use IControl..
4823 (Dispatcher.requestAvatar): .. so don't set .changemaster
4825 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4826 parameter to avoid confusion with the name of the builder
4829 * buildbot/status/mail.py: refine comment about needing 2.3
4831 * buildbot/status/html.py: move all imports to the top
4833 * buildbot/test/test_control.py: test new interfaces
4834 * buildbot/test/test_run.py (Status): handle new interfaces
4835 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4837 * buildbot/process/base.py (BuildControl): implement IBuildControl
4838 and its lonely getStatus() method
4840 * buildbot/process/builder.py (BuilderControl): implement
4841 IBuilderControl, obtained by adapting the Builder instance
4842 (Builder.startBuild): return a BuilderControl instead of a
4843 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4844 accomplish the same thing.
4846 * buildbot/master.py: move all import statements to the top
4847 (Control): implement IControl, obtained by adapting the
4848 BuildMaster instance.
4850 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4851 IBuildControl. These are used to force builds. Eventually they
4852 will provide ways to reconfigure the Builders, pause or abandon a
4853 Build, and perhaps control the BuildMaster itself.
4855 2004-09-26 Brian Warner <warner@lothar.com>
4857 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4858 ends up comparing us against something without a .__class__
4860 2004-09-24 Brian Warner <warner@lothar.com>
4862 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4865 * Makefile: add 'deb-snapshot' target, to create a timestamped
4868 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4870 2004-09-23 Brian Warner <warner@lothar.com>
4872 * buildbot/__init__.py (version): move version string here
4873 * setup.py: get version string from buildbot.version
4874 * buildbot/status/html.py (WaterfallStatusResource.body): add
4875 buildbot version to the page footer
4876 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4879 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4880 slaves, let the second know where the first one is coming from
4881 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4882 see our exceptions. It would be nice if there were a way to just
4883 send them the exception type and value, not the full traceback.
4886 * buildbot/status/mail.py (MailNotifier): add a new argument
4887 sendToInterestedUsers=, which can be set to False to disable the
4888 usual send-to-blamelist behavior.
4889 (top): handle python-2.2 which has no email.MIMEMultipart
4890 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4891 (MailNotifier.disownServiceParent): unsubscribe on removal
4893 * buildbot/test/test_status.py (Mail.testBuild2): test it
4896 * buildbot/status/progress.py (Expectations.wavg): tolerate
4897 current=None, which happens when steps start failing badly
4898 * buildbot/test/test_status.py (Progress.testWavg): test for it
4900 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4901 doesn't understand args['revision'], emit a warning instead of
4902 bailing completely. Updating to -rHEAD is probably close enough.
4904 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4906 * buildbot/test/test_status.py: at least import bb.status.client
4907 even if we don't have any test coverage for it yet
4909 * contrib/svn_buildbot.py: don't require python2.3
4910 (main): wait, do require it (for sets.py), but explain how to
4911 make it work under python2.2
4913 2004-09-23 Brian Warner <warner@lothar.com>
4915 * contrib/svn_buildbot.py: include the revision number in the Change
4917 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4918 using util.now() because FreshCVS is a realtime service
4920 * buildbot/status/event.py: delete dead code
4921 * buildbot/process/step.py: don't import dead Event class
4922 * buildbot/process/step_twisted.py: same
4923 * buildbot/status/builder.py: same
4924 * buildbot/status/client.py: same
4926 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4928 * buildbot/changes/changes.py (Change): set .when from an __init__
4929 argument (which defaults to now()), rather than having
4930 ChangeMaster.addChange set it later.
4931 (ChangeMaster.addChange): same
4933 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4934 (parseSyncmail): same. Just use util.now() for now.
4935 (parseBonsaiMail): parse the timestamp field for when=
4937 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4938 instead of setting .when after the fact
4942 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4943 results when the target project uses retrial. Still under
4945 * buildbot/test/test_trial.py: same
4947 2004-09-21 Brian Warner <warner@lothar.com>
4949 * buildbot/status/mail.py (MailNotifier.__init__): include
4950 success/warnings/failure in the Subject line
4951 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4952 use step.logname for the addLogs=True attachment filenames
4953 * buildbot/test/test_status.py (Mail): test Subject lines
4954 (Mail.testLogs): test attachment filenames
4956 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4957 accept a 'who' argument from the debug tool
4958 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4959 * contrib/debug.glade: add text box to set 'who'
4961 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4962 .getBuilderName with .getBuilder().getName(), more flexible
4963 (IStatusLog.getName): logs have short names, but you can prefix
4964 them with log.getStep().getName() to make them more useful
4965 * buildbot/status/builder.py: same
4966 * buildbot/status/client.py: same
4967 * buildbot/status/html.py: same
4968 * buildbot/test/test_run.py (Status.testSlave): same
4969 * buildbot/process/step.py: tweak logfile names
4971 * buildbot/status/mail.py (MailNotifier): add lookup, change
4972 argument to extraRecipients. The notifier is now aimed at sending
4973 mail to the people involved in a particular build, with additional
4974 constant recipients as a secondary function.
4976 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4977 including slow-lookup and failing-lookup. Make sure the blamelist
4978 members are included.
4980 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4981 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4982 (IBuildStatus.getInterestedUsers): new method
4983 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4984 * buildbot/status/client.py (remote_getResponsibleUsers): same
4985 * buildbot/status/html.py (StatusResourceBuild.body): same
4986 * buildbot/test/test_run.py (Status.testSlave): same
4988 2004-09-20 Brian Warner <warner@lothar.com>
4990 * docs/users.xhtml: update concepts
4992 * Makefile: add a convenience makefile, for things like 'make
4993 test'. It is not included in the source tarball.
4995 2004-09-16 Brian Warner <warner@lothar.com>
4997 * NEWS: mention /usr/bin/buildbot, debian/*
4999 * debian/*: add preliminary debian packaging. Many thanks to
5000 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5001 it considerably since it left their hands, I am responsible for
5002 all breakage that's resulted.
5004 * bin/buildbot: create a top-level 'buildbot' command, to be
5005 installed in /usr/bin/buildbot . For now it's just a simple
5006 frontend to mktap/twistd/kill, but eventually it will be the entry
5007 point to the 'try' command and also a status client. It is also
5008 intended to support the upcoming debian-packaging init.d scripts.
5009 * buildbot/scripts/runner.py: the real work is done here
5010 * buildbot/scripts/__init__.py: need this too
5011 * buildbot/scripts/sample.cfg: this is installed in new
5012 buildmaster directories
5013 * setup.py: install new stuff
5015 2004-09-15 Brian Warner <warner@lothar.com>
5017 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5018 'file:' schema (the version shipped with OS-X was built without the
5020 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5021 updates the log-timestamp, to make sure it isn't still running after
5024 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5025 values to the config file.
5026 * docs/examples/hello.cfg: add examples
5027 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5028 * buildbot/status/builder.py (Status.getProjectURL): implement them
5029 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5030 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5031 * buildbot/status/html.py (WaterfallStatusResource): display them
5034 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5035 certain error cases don't suffer a secondary exception.
5036 (top): Skip tests if the corresponding VC tool is not installed.
5038 * buildbot/process/factory.py (Trial): introduce separate
5039 'buildpython' and 'trialpython' lists, since trialpython=[] is
5040 what you want to invoke /usr/bin/python, whereas ./setup.py is
5041 less likely to be executable. Add env= parameter to pass options
5042 to test cases (which is how I usually write tests, I don't know if
5043 anyone else does it this way).
5045 * buildbot/process/step_twisted.py (Trial): handle python=None.
5046 Require 'testpath' be a string, not a list. Fix tests= typo.
5047 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5049 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5050 way to deal with the possibility of removing the disconnect notify
5052 (CVS): add a 'login' parameter to give a password to 'cvs login',
5053 commonly used with pserver methods (where pw="" or pw="guest")
5055 * buildbot/slave/commands.py (SourceBase): move common args
5056 extraction and setup() to __init__, so everything is ready by the
5057 time setup() is called
5058 (CVS.start): call 'cvs login' if a password was supplied
5059 (ShellCommand): special-case PYTHONPATH: prepend the master's
5060 value to any existing slave-local value.
5062 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5063 don't have a remote, mark the builder as Offline. This whole
5064 function should probably go away and be replaced by individual
5066 (Builder.buildFinished): return the results to the build-finished
5067 deferred callback, helps with testing
5069 2004-09-14 Brian Warner <warner@lothar.com>
5071 * buildbot/test/test_vc.py: put all the repositories needed to run
5072 the complete tests into a single small (1.3MB) tarball, so I can
5073 make that tarball available on the buildbot web site. Test HTTP
5074 access (for Arch and Darcs) by spawning a temporary web server
5075 while the test runs.
5077 * docs/users.xhtml: new document, describe Buildbot's limited
5078 understanding of different human users
5080 * buildbot/test/test_vc.py: rearrange test cases a bit
5082 * buildbot/process/step_twisted.py (Trial): handle testpath=
5083 * buildbot/process/factory.py (Trial): update to use step.Trial
5085 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5087 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5088 the overall build text (which gives you 'failed 2 tests' rather
5090 (BuildStepStatus.text2): default to [], not None
5092 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
5095 2004-09-12 Brian Warner <warner@lothar.com>
5097 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
5098 log the whole exception if it's just an AttributeError (old slave)
5100 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
5101 so (e.g.) sub-commands can be run in the right directory.
5102 (ShellCommand.start): accept an optional errorMessage= argument
5103 to make life easier for SVN.start
5104 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
5106 (ShellCommand.start): move ['dir'] compatibility hack..
5107 (RemoteShellCommand.start): .. to here so everyone can use it
5109 * buildbot/process/step_twisted.py (Trial): use .workdir
5111 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
5112 text displayed when debuild fails completely
5113 (Trial): snarf _trial_temp/test.log from the slave and display it
5115 2004-09-11 Brian Warner <warner@lothar.com>
5117 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
5119 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
5120 set to 'twisted', so --recurse can find twisted/web/test/*, etc
5122 * buildbot/process/step.py (ShellCommand): call .createSummary
5123 before .evaluateCommand instead of the other way around. This
5124 makes it slightly easier to count warnings and then use that to
5125 set results=WARNINGS
5126 * buildbot/process/step_twisted.py: cosmetic, swap the methods
5128 * buildbot/process/base.py (Build.buildFinished): update status
5129 before doing progress. It's embarrassing for the build to be stuck
5130 in the "building" state when an exceptions occurs elsewhere..
5132 * buildbot/status/progress.py (Expectations.expectedBuildTime):
5133 python2.2 doesn't have 'sum'
5135 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
5136 to prevent clients from accidentally sorting it
5138 * buildbot/master.py (Manhole): add username/password
5139 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
5140 c['manholePort'], deprecate old usage
5141 * docs/config.xhtml: document c['manhole']
5142 * docs/examples/hello.cfg: show example of using a Manhole
5145 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
5146 pretend the slave is up to date
5148 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
5149 the module, overlaps with 'log', the local variable
5151 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
5153 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
5154 new method to let Steps find out the version of their
5155 corresponding SlaveCommand.
5156 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
5157 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
5158 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
5160 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
5161 (Arch.startVC): same
5162 (P4Sync.startVC): same
5164 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
5165 Deferred so we can catch errors in remote_startCommand
5166 (RemoteShellCommand.start): same
5168 * docs/examples/twisted_master.cfg: update sample config file
5170 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
5171 after connectionMade() is called, not before. Close stdin at that
5174 * buildbot/process/process_twisted.py: update to use Trial, clean
5175 up argument passing (move to argv arrays instead of string
5178 * buildbot/process/step_twisted.py (Trial): new step to replace
5179 RunUnitTests, usable by any trial-using project (not just
5180 Twisted). Arguments have changed, see the docstring for details.
5182 * buildbot/process/base.py (Build.startBuild): this now returns a
5183 Deferred. Exceptions that occur during setupBuild are now
5184 caught better and lead to fewer build_status weirdnesses, like
5185 finishing a build that was never started.
5186 (Build.buildFinished): fire the Deferred instead of calling
5187 builder.buildFinished directly. The callback argument is this
5188 Build, everything else can be extracted from it, including the
5189 new build.results attribute.
5190 * buildbot/process/builder.py (Builder.startBuild): same
5191 (Builder.buildFinished): same, extract results from build
5193 * buildbot/process/step.py (ShellCommands): remove dead code
5195 2004-09-08 Brian Warner <warner@lothar.com>
5197 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
5198 doesn't try to use the leftover patched workdir
5199 (SourceStamp): test source-stamp computation for CVS and SVN
5201 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
5202 patched workdir ('touch .buildbot-patched') so we don't try to
5204 (SourceBase.start): add ['revision'] for all Source steps
5205 (CVS): change args: use ['branch'] for -r, remove ['files']
5206 (CVS.buildVC): fix revision/branch stuff
5207 (SVN): add revision stuff
5209 * buildbot/process/step.py (BuildStep.__init__): reject unknown
5210 kwargs (except 'workdir') to avoid silent spelling errors
5211 (ShellCommand.__init__): same
5212 (Source): new base class for CVS/SVN/etc. Factor out everything
5213 common, add revision computation (perform the checkout with a -D
5214 DATE or -r REVISION that gets exactly the sources described by the
5215 last Change), overridable with step.alwaysUseLatest. Add patch
5216 handling (build.getSourceStamp can trigger the use of a base
5217 revision and a patch).
5218 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
5219 * docs/steps.xhtml: update docs
5220 * docs/source.xhtml: mention .checkoutDelay
5221 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
5223 * buildbot/process/base.py (Build.setSourceStamp): add a
5224 .sourceStamp attribute to each Build. If set, this indicates that
5225 the build should be done with something other than the most
5226 recent source tree. This will be used to implement "try" builds.
5227 (Build.allChanges): new support method
5228 (Build.lastChangeTime): remove, functionality moved to Source steps
5229 (Build.setupBuild): copy the Step args before adding ['workdir'],
5230 to avoid modifying the BuildFactory (and thus triggering spurious
5234 * buildbot/status/html.py: rename s/commits/changes/
5235 (StatusResourceChanges): same
5236 (CommitBox.getBox): same, update URL
5237 (WaterfallStatusResource): same
5238 (StatusResource.getChild): same
5240 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
5241 * contrib/debug.glade: add optional 'revision' to the fakeChange
5243 * buildbot/changes/changes.py (html_tmpl): display .revision
5244 (ChangeMaster.addChange): note .revision in log
5245 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
5246 accept a ['revision'] attribute
5248 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
5250 * buildbot/master.py (BotMaster.getPerspective): update the
5251 .connected flag in SlaveStatus when it connects
5252 (BotMaster.detach): and when it disconnects
5253 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
5254 (BuildMaster.loadConfig_Builders): walk old list correctly
5256 * buildbot/test/test_config.py: fix prefix= usage
5258 2004-09-06 Brian Warner <warner@lothar.com>
5262 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
5263 poll a P4 depot looking for recent changes. Thanks to Dave
5264 Peticolas for the contribution. Probably needs some testing after
5267 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
5268 requires manual client setup for each buildslave. Rather
5269 experimental. Thanks again to Dave Peticolas.
5270 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
5272 * buildbot/changes/changes.py (Change): add a .revision attribute,
5273 which will eventually be used to generate source-stamp values.
5275 * buildbot/process/step.py (RemoteCommand.start): use
5276 notifyOnDisconnect to notice when we lose the slave, then treat it
5277 like an exception. This allows LogFiles to be closed and the build
5278 to be wrapped up normally. Be sure to remove the disconnect
5279 notification when the step completes so we don't accumulate a
5280 bazillion such notifications which will fire weeks later (when the
5281 slave finally disconnects normally). Fixes SF#915807, thanks to
5282 spiv (Andrew Bennetts) for the report.
5283 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
5284 really isn't Logged- specific
5285 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
5286 header, since it's almost always going to be appended to an
5288 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
5289 update test to handle use of notifyOnDisconnect
5291 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
5292 don't clear .ETA and .currentBuild when going offline, let the
5293 current build clean up after itself
5295 * buildbot/process/builder.py (Builder.detached): wait a moment
5296 before doing things like stopping the current build, because the
5297 current step will probably notice the disconnect and cleanup the
5299 * buildbot/test/test_run.py (Status.tearDown): update test to
5300 handle asynchronous build-detachment
5302 * buildbot/process/base.py (Build.stopBuild): minor shuffles
5304 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
5305 hush a debug message
5307 2004-09-05 Brian Warner <warner@lothar.com>
5309 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
5310 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
5311 kernels do this: the fcntl module has the F_NOTIFY constant, but
5312 the kernel itself doesn't support the operation. Thanks to Olly
5313 Betts for spotting the problem.
5315 * buildbot/process/step.py (Darcs): new source-checkout command
5316 (Arch): new source-checkout command
5317 (todo_P4): fix constructor syntax, still just a placeholder
5318 * buildbot/test/test_vc.py (VC.testDarcs): test it
5319 (VC.testDarcsHTTP): same, via localhost HTTP
5321 (VC.testArchHTTP): same
5322 * NEWS: mention new features
5324 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
5325 which tells the step to stash stdout text locally (in .stdout).
5326 Slave-side Commands can use this to make decisions based upon the
5327 output of the the ShellCommand (not just the exit code).
5328 (Darcs): New source-checkout command
5329 (Arch): New source-checkout command, uses .keepStdout in one place
5330 where it needs to discover the archive's default name.
5332 * docs/steps.xhtml: Document options taken by Darcs and Arch.
5333 * docs/source.xhtml: add brief descriptions of Darcs and Arch
5334 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
5336 * buildbot/process/step.py (ShellCommand.describe): add an
5337 alternate .descriptionDone attribute which provides descriptive
5338 text when the step is complete. .description can be ["compiling"],
5339 for use while the step is running, then .descriptionDone can be
5340 ["compile"], used alone when the step succeeds or with "failed" when
5341 it does not. Updated other steps to use the new text.
5342 * buildbot/process/step_twisted.py: same
5343 * buildbot/test/test_run.py: update tests to match
5345 2004-08-30 Brian Warner <warner@lothar.com>
5347 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
5348 (CVS.__init__): send 'patch' argument to slave
5349 (CVS.start): don't create the LoggedRemoteCommand until start(),
5350 so we can catch a .patch added after __init__
5351 (SVN.__init__): add 'patch' to SVN too
5354 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
5355 argument, to let commands push data into the process' stdin pipe.
5356 Move usePTY to a per-instance attribute, and clear it if 'stdin'
5357 is in use, since closing a PTY doesn't really affect the process
5358 in the right way (in particular, I couldn't run /usr/bin/patch
5360 (SourceBase.doPatch): handle 'patch' argument
5362 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
5365 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
5366 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
5368 * buildbot/master.py (BotPerspective.got_commands): get command
5369 versions from slave, give to each builder
5370 * buildbot/process/builder.py (Builder.attached): stash slave
5371 command versions in .remoteCommands
5373 * docs/steps.xhtml: bring docs in-line with reality
5375 * buildbot/process/step.py (CVS.__init__): more brutal
5376 compatibility code removal
5377 (SVN.__init__): same
5379 * buildbot/slave/commands.py (SlaveShellCommand): update docs
5380 (SlaveShellCommand.start): require ['workdir'] argument, remove
5381 the ['dir'] fallback (compatibility will come later)
5382 (SourceBase): update docs
5383 (SourceBase.start): remove ['directory'] fallback
5386 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5387 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5388 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5390 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5391 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5392 code.. I will figure out 0.5.0-compatibility hooks later)
5394 2004-08-30 Brian Warner <warner@lothar.com>
5396 * buildbot/process/process_twisted.py: rewrite in terms of new
5397 BuildFactory base class. It got significantly shorter. Yay
5400 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5401 work with the new "self.build isn't nailed down until we call
5402 step.start()" scheme: specifically, __init__ is called before the
5403 build has decided on which Changes are going in, so we don't scan
5404 build.allFiles() for .xhtml files until start()
5405 (HLint.commandComplete): use getText(), not getStdout()
5406 (RunUnitTests.start): same: don't use .build until start()
5407 (RunUnitTests.describe): oops, don't report (None) when using
5409 (RunUnitTests.commandComplete): use getText()
5410 (RunUnitTests.createSummary): same
5411 (BuildDebs.commandComplete): same
5413 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5414 set args['command'] until start(), since our BuildStep is allowed
5415 to change their mind up until that point
5416 (TreeSize.commandComplete): use getText(), not getStdout()
5418 * docs/examples/twisted_master.cfg: update to current standards
5420 * docs/factories.xhtml: update
5421 * buildbot/process/factory.py: implement all the common factories
5422 described in the docs. The Trial factory doesn't work yet, and
5423 I've probably broken all the process_twisted.py factories in the
5424 process. There are compatibility classes left in for things like
5425 the old BasicBuildFactory, but subclasses of them are unlikely to
5427 * docs/examples/glib_master.cfg: use new BuildFactories
5428 * docs/examples/hello.cfg: same
5430 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5431 explicit 'workdir' args
5433 * buildbot/process/base.py (BuildFactory): move factories to ..
5434 * buildbot/process/factory.py (BuildFactory): .. here
5435 * buildbot/process/process_twisted.py: handle move
5436 * buildbot/test/test_config.py: same
5437 * buildbot/test/test_run.py: same
5438 * buildbot/test/test_steps.py: same
5439 * buildbot/test/test_vc.py: same
5440 * docs/factories.xhtml: same
5442 * NEWS: mention config changes that require updating master.cfg
5444 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5445 argument to all steps that weren't given one already, pointing at
5446 the "build/" directory.
5448 * docs/examples/hello.cfg: remove explicit 'workdir' args
5450 * docs/factories.xhtml: document standard BuildFactory clases,
5451 including a bunch which are have not yet been written
5453 2004-08-29 Brian Warner <warner@lothar.com>
5455 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5456 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5457 buildbot.status.builder so they aren't quite so internal
5458 * buildbot/process/base.py, buildbot/process/builder.py: same
5459 * buildbot/process/maxq.py, buildbot/process/step.py: same
5460 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5461 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5462 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5464 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5465 to handle new getLogs()-returns-list behavior
5466 (StatusResourceBuildStep.getChild): same
5467 (StepBox.getBox): same
5468 (WaterfallStatusResource.phase0): same
5470 * docs/source.xhtml: document how Buildbot uses version-control
5471 systems (output side: how we get source trees)
5472 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5473 systems (input side: how we learn about Changes)
5475 * buildbot/master.py (Manhole): use ComparableMixin
5476 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5477 * buildbot/changes/mail.py (MaildirSource): same
5478 * buildbot/status/client.py (PBListener): same
5479 * buildbot/status/html.py (Waterfall): same
5480 * buildbot/status/words.py (IRC): same
5482 * NEWS: start describing new features
5484 * buildbot/status/mail.py (MailNotifier): finish implementation.
5485 The message body is still a bit sparse.
5486 * buildbot/test/test_status.py (Mail): test it
5488 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5489 and __hash__ methods I wind up adding everywhere. Specifically
5490 intended to support the buildbot config-file update scheme where
5491 we compare, say, the old list of IStatusTargets against the new
5492 one and don't touch something which shows up on both lists.
5493 * buildbot/test/test_util.py (Compare): test case for it
5495 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5496 return a list instead of a dict
5497 (IBuildStepStatus.getLogs): same. The idea is that steps create
5498 logs with vaguely unique names (although their uniqueness is not
5499 guaranteed). Thus a compilation step should create its sole
5500 logfile with the name 'compile', and contribute it to the
5501 BuildStatus. If a step has two logfiles, try to create them with
5502 different names (like 'test.log' and 'test.summary'), and only
5503 contribute the important ones to the overall BuildStatus.
5504 * buildbot/status/builder.py (Event.getLogs): same
5505 (BuildStepStatus): fix default .text and .results
5506 (BuildStepStatus.addLog): switch to list-like .getLogs()
5507 (BuildStepStatus.stepFinished): same
5508 (BuildStatus.text): fix default .text
5509 (BuildStatus.getLogs): temporary hack to return all logs (from all
5510 child BuildStepStatus objects). Needs to be fixed to only report
5511 the significant ones (as contributed by the steps themselves)
5512 * buildbot/test/test_run.py: handle list-like .getLogs()
5513 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5515 2004-08-28 Brian Warner <warner@lothar.com>
5517 * buildbot/process/builder.py (Builder.attached): serialize the
5518 attachment process, so the attach-watcher isn't called until the
5519 slave is really available. Add detached watchers too, which makes
5522 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5524 * buildbot/test/test_swap.py: remove dead code
5526 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5527 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5528 sort of as if the command being run exited with a -1. There may
5529 still be some holes in this scheme.
5530 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5531 -r option appears before the module list
5532 * buildbot/process/step.py (CVS): add 'revision' argument
5534 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5535 when sending updates or stepComplete messages to the master, since
5536 we don't currently care whether they arrive or not. When we revamp
5537 the master/slave protocol to really resume interrupted builds,
5538 this will need revisiting.
5539 (lostRemote): remove spurious print
5541 * buildbot/master.py (BotPerspective.attached): serialize the
5542 new-builder interrogation process, to make testing easier
5543 (BotMaster.waitUntilBuilderDetached): convenience function
5545 * buildbot/status/builder.py (BuilderStatus): prune old builds
5546 (BuildStatus.pruneSteps): .. and steps
5547 (BuildStepStatus.pruneLogs): .. and logs
5548 (BuilderStatus.getBuild): handle missing builds
5549 * buildbot/status/html.py (StatusResourceBuild.body): display build
5550 status in the per-build page
5551 (BuildBox.getBox): color finished builds in the per-build box
5553 2004-08-27 Brian Warner <warner@lothar.com>
5555 * buildbot/status/mail.py (MailNotifier): new notification class,
5558 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5559 variants of a common base class which handles all the mode= logic
5561 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5563 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5565 2004-08-26 Brian Warner <warner@lothar.com>
5567 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5570 * buildbot/test/test_run.py: update to new Logfile interface, new
5571 buildbot.slave modules
5572 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5574 * MANIFEST.in: new sample config file
5575 * docs/examples/hello.cfg: same
5577 * buildbot/process/step_twisted.py: remove dead import
5579 * buildbot/process/step.py (RemoteCommand.run): catch errors
5581 (RemoteCommand.remote_update): ignore updates that arrive after
5583 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5584 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5585 the responsibilities of the subclass's methods
5586 (BuildStep.failed): catch errors during failure processing
5587 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5588 (CVS): move to a mode= argument (described in docstring), rather
5589 than the ungainly clobber=/export=/copydir= combination.
5590 (SVN): add mode= functionality to SVN too
5591 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5593 * buildbot/process/base.py (Build.startNextStep): catch errors
5594 during s.startStep()
5596 * buildbot/clients/base.py: update to new PB client interface.
5597 gtkPanes is still broken
5599 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5600 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5601 * setup.py: add buildbot.slave module
5602 * buildbot/bb_tap.py: handle move
5603 * buildbot/slave/registry.py: place to register commands, w/versions
5604 * buildbot/slave/bot.py: major simplifications
5605 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5606 instead of a fixed table. Eventually this will make the slave more
5607 extensible. Use 'start' method on the command, not .startCommand.
5608 Fix unsafeTracebacks handling (I think).
5609 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5610 helper class with a .start method that returns a Deferred.
5611 SlaveShellCommand is the form reached by the buildmaster. Commands
5612 which use multiple ShellCommands can just chain them as Deferreds,
5613 with some helper methods in Command (_abandonOnFailure and
5614 _checkAbandoned) to bail on rc!=0.
5615 (CVSCommand): prefer new mode= argument
5616 (SVNFetch): add mode= argument
5618 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5619 put a useful reason string on the build
5621 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5622 core functionality into an IStatusLog object
5623 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5624 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5625 (StatusResourceBuild.body): use proper accessor methods
5626 * buildbot/status/client.py (RemoteLog): PB-access goes here
5627 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5628 which delivers log contents too
5629 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5630 * buildbot/status/event.py: remove old Logfile completely
5632 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5633 subscription interface for IStatusLog subscriptions just like all
5634 other the status subscriptions
5635 (IStatusReceiver.logChunk): method called on subscribers
5637 2004-08-24 Brian Warner <warner@lothar.com>
5639 * buildbot/process/builder.py (Builder._pong): oops, ping response
5640 includes a result (the implicit None returned by remote_print).
5641 Accept it so the _pong method handles the response correctly.
5643 2004-08-06 Brian Warner <warner@lothar.com>
5645 * buildbot/test/test_config.py: update IRC, PBListener tests
5647 * buildbot/status/client.py (StatusClientPerspective): total
5648 rewrite to match new IStatus interfaces. New subscription scheme.
5649 There are still a few optimizations to make (sending down extra
5650 information with event messages so the client doesn't have to do a
5651 round trip). The logfile-retrieval code is probably still broken.
5652 Moved the PB service into its own port, you can no longer share a
5653 TCP socket between a PBListener and, say, the slaveport (this
5654 should be fixed eventually).
5655 * buildbot/clients/base.py (Client): revamp to match. still needs
5656 a lot of work, but basic event reporting works fine. gtkPanes is
5659 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5660 instance talks to a single irc server. Threw out all the old
5661 multi-server handling code. Still need to add back in
5662 builder-control (i.e. "force build")
5664 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5665 more random text to the as-yet-unreachable per-step page
5667 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5668 rename to stepETAUpdate
5669 (BuildStatus.subscribe): add build-wide ETA updates
5670 (BuilderStatus.getState): remove more cruft
5671 (BuilderStatus.getCurrentBuild): remove more cruft
5672 (BuilderStatus.buildStarted): really handle tuple-subscription
5673 * buildbot/test/test_run.py (Status.testSlave): handle the
5674 stepETAUpdate rename
5676 * buildbot/master.py (BuildMaster): don't add a default
5677 StatusClientService. Don't add a default IrcStatusFactory. Both
5678 are now added through c['status'] in the config file. c['irc'] is
5679 accepted for backwards compatibility, the only quirk is you cannot
5680 use c['irc'] to specify IRC servers on ports other than 6667.
5682 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5683 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5684 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5685 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5688 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5689 the buildmaster to re-read its config file
5692 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5693 find out the port our server is running on
5694 (WebTest.test_webPathname_port): same
5696 * buildbot/test/test_config.py (testWebPortnum): test it
5697 (testWebPathname): ditto
5699 * docs/config.xhtml: document new c['status'] configuration option
5701 * buildbot/status/html.py (Waterfall): new top-level class which
5702 can be added to c['status']. This creates the Site as well as the
5703 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5704 reachable as .parent, for everything.
5706 * buildbot/master.py (Manhole): make it a normal service Child
5707 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5708 webPathname. It will eventually replace c['irc'] and the implicit
5709 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5710 in as (deprecated) backward compatibility hooks for now.
5713 * buildbot/process/builder.py (Builder.buildFinished): don't
5714 inform out builder_status about a finished build, as it finds out
5715 through its child BuildStatus object
5717 * buildbot/status/html.py: extensive revamp. Use adapters to make
5718 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5719 have both starting and finishing times and adjust the waterfall
5720 display accordingly, using spacers if necessary. Use SlaveStatus
5721 to get buildslave info.
5722 (StatusResourceBuildStep): new just-one-step resource, used to get
5723 logfiles. No actual href to it yet.
5725 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5726 the time being, until I get the file-naming scheme right
5728 * buildbot/status/builder.py (Event): clean started/finished names
5729 (BuildStatus.isFinished): .finished is not None is the right test
5730 (BuildStatus.buildStarted): track started/finished times ourselves
5731 (BuilderStatus.getSlave): provide access to SlaveStatus object
5732 (BuilderStatus.getLastFinishedBuild): all builds are now in
5733 .builds, even the currently-running one. Accomodate this change.
5734 (BuilderStatus.eventGenerator): new per-builder event generator.
5735 Returns BuildStepStatus and BuildStatus objects, since they can
5736 both be adapted as necessary.
5737 (BuilderStatus.addEvent): clean up started/finished attributes
5738 (BuilderStatus.startBuild,finishBuild): remove dead code
5739 (SlaveStatus): new object to provide ISlaveStatus
5741 * buildbot/process/step.py (ShellCommand.getColor): actually
5742 return the color instead of setting it ourselves
5743 (CVS.__init__): pull .timeout and .workdir options out of
5744 **kwargs, since BuildStep will ignore them. Without this neither
5745 will be sent to the slave correctly.
5746 (SVN.__init__): same
5748 * buildbot/process/builder.py (Builder): move flags to class-level
5750 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5751 SlaveStatus handle that
5753 * buildbot/process/base.py (Build.firstEvent): remove dead code
5754 (Build.stopBuild): bugfix
5756 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5758 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5759 (ChangeMaster.eventGenerator): yield Changes, since there are now
5760 Adapters to turn them into HTML boxes
5762 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5763 (BotPerspective.attached): feed a SlaveStatus object
5764 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5765 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5767 * buildbot/interfaces.py: API additions
5768 (ISlaveStatus): place to get slave status
5770 2004-08-04 Brian Warner <warner@lothar.com>
5772 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5773 the delay finishes, so the step is marked as SUCCESS
5775 * buildbot/test/test_run.py (Status.testSlave): cover more of
5776 IBuildStatus and IBuildStepStatus
5778 * buildbot/status/progress.py (StepProgress): move some flags to
5779 class-level attributes
5780 (StepProgress.remaining): if there are no other progress metrics
5781 to go by, fall back to elapsed time
5782 (StepProgress.setExpectations): take a dict of metrics instead of
5784 (BuildProgress.setExpectationsFrom): pull expectations from the
5785 Expectations, instead of having it push them to the BuildProgress
5786 (Expectations): move some flags to class-level attributes
5787 (Expectations.__init__): copy per-step times from the
5789 (Expectations.expectedBuildTime): new method for per-build ETA
5791 * buildbot/status/event.py (Logfile): move some flags to
5792 class-level attributes
5793 (Logfile.logProgressTo): better method name, let step set the
5794 progress axis name (instead of always being "output")
5796 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5797 times directly, rather than depending upon the (possibly missing)
5798 .progress object. Use 'None' to indicate "not started/finished
5800 (BuildStepStatus.getExpectations): oops, return the full list of
5802 (BuilderStatus._buildFinished): append finished builds to .builds
5804 * buildbot/process/step.py (BuildStep): add separate .useProgress
5805 flag, since empty .progressMetrics[] still implies that time is a
5807 (CVS): set up the cmd in __init__, instead of waiting for start()
5809 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5810 calculation, this will eventually turn into a proper sourceStamp
5811 (Build.setupBuild): tell the Progress to load from the Expectations,
5812 instead of having the Expectations stuff things into the Progress
5813 (Build.buildException): add a build-level errback to make sure the
5814 build's Deferred fires even in case of exceptions
5816 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5818 * buildbot/process/builder.py (Builder.forceBuild): convey the
5819 reason instead of creating a fake Change
5821 * docs/examples/twisted_master.cfg: update to match reality
5823 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5824 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5825 fix or remove broken/breaking tests
5827 * buildbot/status/event.py (Logfile.__len__): remove evil method
5829 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5830 missing .build, for test convenience
5832 * buildbot/process/step_twisted.py: import fixes
5834 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5836 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5837 .statusbag reference
5839 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5840 connection at shutdown, and stop it from reconnecting
5842 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5843 chase down remote-execution bugs
5845 * buildbot/process/step.py: more fixes, remove
5846 BuildStep.setStatus()
5847 * buildbot/status/builder.py: move setStatus() functionality into
5849 * buildbot/status/event.py: minor fixes
5851 2004-08-03 Brian Warner <warner@lothar.com>
5853 * buildbot/process/base.py, buildbot/process/builder.py
5854 * buildbot/process/step.py, buildbot/status/builder.py
5855 * buildbot/status/event.py, buildbot/test/test_run.py:
5856 fix status delivery, get a basic test case working
5857 * buildbot/master.py: finish implementing basic status delivery,
5858 temporarily disable HTML/IRC/PB status sources
5860 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5862 * buildbot/status/progress.py (BuildProgress): remove dead code
5864 * buildbot/interfaces.py
5865 * buildbot/process/base.py, buildbot/process/builder.py
5866 * buildbot/process/step.py, buildbot/process/step_twisted.py
5867 * buildbot/status/builder.py: Complete overhaul of the all
5868 status-delivery code, unifying all types of status clients (HTML,
5869 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5870 look like. This commit is a checkpointing of the work-in-progress:
5871 the input side is mostly done (Builders/Builds sending status
5872 to the BuilderStatus/BuildStatus objects), but the output side has
5873 not yet been started (HTML resources querying BuilderStatus
5874 objects). Things are probably very broken right now and may remain
5875 so for several weeks, I apologize for the disruption.
5877 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5878 HTML as the log's contents. Currently used for exception tracebacks.
5879 * buildbot/status/progress.py: minor spelling changes
5881 2004-08-02 Brian Warner <warner@lothar.com>
5883 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5884 in mozilla. Also added stylesheets copied from Twisted's docs.
5885 Remember that these files are meant to be run through Lore first.
5886 Thanks to Philipp Frauenfelder for the fixes.
5887 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5888 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5889 * docs/template.tpl: added a Lore template
5891 2004-07-29 Brian Warner <warner@lothar.com>
5893 * buildbot/interfaces.py: revamp status delivery. This is the
5894 preview: these are the Interfaces that will be provided by new
5895 Builder code, and to which the current HTML/IRC/PB status
5896 displayers will be adapted.
5898 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5899 on the SlaveBuilder, not the Bot.
5900 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5902 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5903 set .usePTY on the FakeSlaveBuilder
5905 2004-07-25 Brian Warner <warner@lothar.com>
5907 * buildbot/changes/freshcvs.py: add some debug log messages
5908 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5909 disabled 'setFilter' syntax
5910 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5911 don't end with a slash
5913 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5915 * setup.py: bump to 0.5.0+ while between releases
5917 2004-07-23 Brian Warner <warner@lothar.com>
5919 * setup.py (version): Releasing buildbot-0.5.0
5921 2004-07-23 Brian Warner <warner@lothar.com>
5923 * README: update for 0.5.0 release
5925 * NEWS: update for 0.5.0 release
5927 2004-07-22 Brian Warner <warner@lothar.com>
5929 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5930 mktap-time configuration flag (--usepty=1, --usepty=0)
5931 * buildbot/bot.py: same
5933 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5934 an 'info' directory being unwanted
5936 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5937 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5938 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5939 and earlier), use a FreshCVSSourceOldcred instead.
5940 (test): simple test routine: connect to server, print changes
5942 * buildbot/changes/changes.py (Change.getTime): make it possible
5943 to print un-timestamped changes
5945 * buildbot/master.py (makeApp): delete ancient dead code
5946 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5947 * buildbot/test/test_config.py (testFindConfigFile): test it
5949 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5950 instead of win32 one
5953 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5954 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5957 * buildbot/process/base.py (Builder.__init__): change constructor
5958 to accept a dictionary of config data, rather than discrete
5959 name/slave/builddir/factory arguments
5961 * docs/examples/twisted_master.cfg: update to new syntax
5962 * docs/examples/glib_master.cfg: same
5963 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5964 rough tests of the new syntax
5967 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5968 to be an int, which means "run a web.distrib sub-server on a TCP
5969 port". This lets you publish the buildbot status page to a remote
5970 twisted.web server (using distrib.ResourceSubscription). Also
5971 rename the local attributes used to hold these web things so
5972 they're more in touch with reality.
5973 * buildbot/test/test_web.py: test webPortnum and webPathname
5974 * docs/config.xhtml: document this new use of webPathname
5976 * docs/config.xhtml: new document, slightly ahead of reality
5978 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5979 'prefix' handling: treat it as a simple string to check with
5980 .startswith, instead of treating it as a directory. This allows
5981 sub-directories to be used. If you use prefix=, you should give it
5982 a string that starts just below the CVSROOT and ends with a slash.
5983 This prefix will be stripped from all filenames, and filenames
5984 which do not start with it will be ignored.
5986 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5988 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5989 and --exclude (inverse of --include). SVN post-commit hooks
5990 now have total control over which changes get sent to buildbot and which
5993 2004-07-10 Brian Warner <warner@lothar.com>
5995 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5996 test case to match new API
5998 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5999 which crashed HTML display when self.entries=[] (needed to
6000 distinguish between [], which means "no entries yet", and None,
6001 which means "the entries have been swapped out to disk, go fetch
6004 2004-07-04 Brian Warner <warner@lothar.com>
6006 * buildbot/process/step_twisted.py (countFailedTests): Count
6007 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6008 10kb from the end because any import errors are wedged there and
6009 they would make us think the test log was unparseable.
6010 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6012 2004-06-26 Brian Warner <warner@lothar.com>
6014 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6015 delete-*.pyc command into an actual BuildStep, so we can label it
6017 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6018 (FullTwistedBuildFactory): same
6020 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6022 * contrib/fakechange.py: Add an errback when sending the fake
6023 change, so we know it didn't work.
6025 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6027 * buildbot/process/step_twisted.py: Delete *.pyc files before
6028 calling trial, so it doesn't catch any old .pyc files whose .py
6029 files have been moved or deleted.
6031 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6032 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6033 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6034 instead of ["twisted.test"], so that the end result is "trial -R
6037 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6038 regular expression to match filenames that should be ignored when
6039 changed. Also add a --revision parameter that specifies the
6040 revision to examine, which is useful for debugging.
6042 2004-06-25 Brian Warner <warner@lothar.com>
6044 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6045 summary of warnings (like DeprecationWarnings), next to the
6048 2004-05-13 Brian Warner <warner@lothar.com>
6050 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6051 we now have a w32 build slave courtesy of Mike Taylor.
6053 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6054 so broken. Fixed a race condition that tripped up interlocked
6055 builds and caused the status to be stuck at "Interlocked" forever.
6056 The twisted buildbot's one interlocked build just so happened to
6057 never hit this case until recently (the feeding builds both pass
6058 before the interlocked build is attempted.. usually it has to wait
6060 (Builder._pong_failed): fix method signature
6062 * setup.py: bump to 0.4.3+ while between releases
6064 2004-04-30 Brian Warner <warner@lothar.com>
6066 * setup.py (version): Releasing buildbot-0.4.3
6068 2004-04-30 Brian Warner <warner@lothar.com>
6070 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6072 * README: update for 0.4.3 release
6074 * NEWS: update for 0.4.3 release
6076 * buildbot/master.py (BuildMaster.__getstate__): make sure
6077 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6079 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6080 .trial as a class attribute, for upgrade from 0.4.2
6082 * buildbot/changes/changes.py (Change.links): add .links for
6085 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6086 .textWatchers and .htmlWatchers at save time, since they are both
6087 volatile, should allow smooth 0.4.2 upgrade
6089 * buildbot/process/step.py (CVS.finishStatus): catch failed
6090 CVS/SVN commands so we can make the status box red
6092 2004-04-29 Brian Warner <warner@lothar.com>
6094 * buildbot/changes/freshcvs.py
6095 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
6096 code to do setFilter(), which tells the freshcvs daemon to not
6097 send us stuff that we're not interested in. I will uncomment it
6098 when a new version of CVSToys is available in which setFilter()
6099 actually works, and I get a chance to test it better.
6101 * docs/examples/twisted_master.cfg: start using a PBChangeSource
6103 * buildbot/master.py (Dispatcher): use a registration scheme
6104 instead of hardwired service names
6105 (BuildMaster): keep track of the Dispatcher to support
6108 * buildbot/changes/changes.py (ChangeMaster): create a distinct
6109 PBChangeSource class instead of having it be an undocumented
6110 internal feature of the ChangeMaster. Split out the code into a
6112 * buildbot/changes/pb.py (PBChangeSource): same
6113 * buildbot/test/test_changes.py: a few tests for PBChangeSource
6115 * docs/{factories|sources|steps}.xhtml: document some pieces
6117 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
6118 using FCMaildirSource
6119 (f23osx): update OS-X builder to use python2.3, since the slave
6120 was updated to Panther (10.3.3)
6122 2004-03-21 Brian Warner <warner@lothar.com>
6124 * buildbot/process/process_twisted.py: factor out doCheckout, change
6125 to use SVN instead of CVS
6127 * buildbot/process/base.py (BasicBuildFactory): refactor to make
6128 an SVN subclass easier
6129 (BasicSVN): subclass which uses Subversion instead of CVS
6131 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
6133 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
6135 (CVSCommand.cvsComplete): don't assume chdir worked on win32
6137 2004-02-25 Brian Warner <warner@lothar.com>
6139 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
6140 is now either a list (which is passed to spawnProcess directly) or
6141 a string (which gets passed to /bin/sh -c). This removes the useSH
6142 flag and the ArgslistCommand class. Also send status header at the
6143 start and end of each command, instead of having the master-side
6145 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
6146 -r'. Update to use list-based arguments.
6147 (SVNFetch): use list-based arguments, use ['dir'] argument to
6149 * buildbot/test/test_steps.py (Commands): match changes
6151 * buildbot/process/step.py (InternalShellCommand.words): handle
6153 (SVN): inherit from CVS, cleanup
6155 * buildbot/status/event.py (Logfile.content): render in HTML, with
6156 stderr in red and headers (like the name of the command we're
6157 about to run) in blue. Add link to a second URL (url + "?text=1")
6158 to get just stdout/stderr in text/plain without markup. There is
6159 still a problem with .entries=None causing a crash, it seems to occur
6160 when the logfile is read before it is finished.
6162 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
6163 timeout to the keepalives, and use it to explicitly do a
6164 loseConnection instead of waiting for TCP to notice the loss. This
6165 ought to clear up the silent-lossage problem.
6166 (unsafeTracebacks): pass exception tracebacks back to the master,
6167 makes it much easier to debug problems
6169 2004-02-23 Brian Warner <warner@lothar.com>
6171 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
6172 the whole command to /bin/sh instead of execve [Johan Dahlin]
6173 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
6174 '-r HEAD' [Johan Dahlin]
6175 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
6177 * buildbot/changes/changes.py (Change): add links= argument, add
6178 asHTML method [Johan Dahlin]. Modified to make a bit more
6179 XHTMLish. Still not sure how to best use links= .
6181 * buildbot/status/html.py (StatusResourceCommits.getChild): use
6182 Change.asHTML to display the change, not asText
6184 * buildbot/status/html.py (StatusResourceBuilder): web button to
6187 * buildbot/test/test_run.py: test to actually start a buildmaster
6190 * MANIFEST.in: bring back accidentally-dropped test helper files
6192 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
6193 that require cvstoys if it is not installed
6195 * buildbot/process/step_twisted.py (RunUnitTests): allow other
6196 values of "bin/trial" [Dave Peticolas]
6197 (RunUnitTests.finishStatus): say "no tests run" instead of "0
6198 tests passed" when we didn't happen to run any tests
6200 * buildbot/process/step.py (Compile): use haltOnFailure instead of
6201 flunkOnFailure [Johan Dahlin]
6203 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
6204 multiple instances of the same Step class by suffixing "_2", etc,
6205 to the name until it is unique. This name needs to be unique
6206 because it is used as a key in the dictionary that tracks build
6208 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
6211 * buildbot/process/base.py (Builder.ping): add "ping slave" command
6213 2004-01-14 Brian Warner <warner@lothar.com>
6215 * buildbot/status/words.py (IrcStatusBot): when we leave or get
6216 kicked from a channel, log it
6218 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
6219 something over whatever IRC channels the buildmaster is currently
6220 connected to. Added to try and track down a problem in which the
6221 master thinks it is still connected but the IRCd doesn't see it. I
6222 used a styles.Versioned this time, so hopefully users won't have
6223 to rebuild their .tap files this time.
6224 * contrib/debug.glade: add a "Poke IRC" button
6225 * contrib/debugclient.py: same
6227 * setup.py: bump to 0.4.2+ while between releases
6229 2004-01-08 Brian Warner <warner@lothar.com>
6231 * setup.py (version): Releasing buildbot-0.4.2
6233 2004-01-08 Brian Warner <warner@lothar.com>
6235 * NEWS: update for 0.4.2 release
6237 * README: document how to run the tests, now that they all pass
6239 * buildbot/changes/maildir.py (Maildir.poll): minor comment
6241 * buildbot/process/step.py (CVS): add a global_options= argument,
6242 which lets you set CVS global options for the command like "-r"
6243 for read-only checkout, or "-R" to avoid writing in the
6245 * buildbot/slavecommand.py (CVSCommand): same
6247 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
6248 testing easier (it is turned off when testing, to avoid the
6251 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
6252 to make it easier to test: break generateStepID() out to a
6253 separate function, only update statusbag if it exists.
6254 (ShellCommands): create useful text for dict-based commands too.
6256 * test/*, buildbot/test/*: move unit tests under the buildbot/
6258 * setup.py (packages): install buildbot.test too
6260 * buildbot/test/test_slavecommand.py: fix it, tests pass now
6261 * buildbot/test/test_steps.py: fix it, tests pass now
6263 2004-01-06 Brian Warner <warner@lothar.com>
6265 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
6266 freshcvs mail uses a slightly different syntax for new
6267 directories. Update parser to handle either.
6268 * test/test_mailparse.py (Test1.testMsg9): test for same
6270 2003-12-21 Brian Warner <warner@lothar.com>
6272 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
6273 'warnOnWarnings' so that lintian errors mark the build orange
6275 2003-12-17 Brian Warner <warner@lothar.com>
6277 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
6278 messages emitted by Bonsai, contributed by Stephen Davis.
6280 * test/*: moved all tests to use trial instead of unittest. Some
6281 still fail (test_steps, test_slavecommand, and test_process).
6283 * setup.py (version): bump to 0.4.1+ while between releases
6285 2003-12-09 Brian Warner <warner@lothar.com>
6287 * setup.py (version): Releasing buildbot-0.4.1
6289 2003-12-09 Brian Warner <warner@lothar.com>
6291 * NEWS: update for 0.4.1 release
6293 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
6294 freebsd builder code a little bit
6296 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
6297 don't try to compare attributes of different classes
6298 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6299 (MaildirSource.messageReceived): fix Change delivery
6301 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
6302 into the config file's namespace before loading it, like the
6303 documentation claims it does
6304 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
6305 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
6306 daemon comes back online
6308 2003-12-08 Brian Warner <warner@lothar.com>
6310 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
6311 so the example will work with online=0 as well
6313 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
6314 fix the __implements__ line
6316 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
6317 class a twisted.application.service.Service, use startService to
6320 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
6321 directory fd instead of simple open(). I'm sure this used to work,
6322 but the current version of python refuses to open directories with
6325 2003-12-05 Brian Warner <warner@lothar.com>
6327 * setup.py (version): bump to 0.4.0+ while between releases
6329 2003-12-05 Brian Warner <warner@lothar.com>
6331 * setup.py (version): Releasing buildbot-0.4.0
6333 2003-12-05 Brian Warner <warner@lothar.com>
6335 * docs/examples/glib_master.cfg: replace old sample scripts with
6336 new-style config files
6337 * MANIFEST.in: include .cfg files in distribution tarball
6339 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
6340 implement a dummy method to avoid the exception that occurs when
6341 freshcvs sends this to us.
6343 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
6344 removed the method, as it broke reconnection. Apparently
6345 stopFactory is called each time the connection attempt fails. Must
6347 (ReconnectingPBClientFactory.__getstate__): squash the _callID
6348 attribute before serialization, since without stopFactory the
6349 reconnect timer may still be active and they aren't serializable.
6351 * test/test_mailparse.py (ParseTest): test with 'self' argument
6353 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
6354 argument, as these "functions" are invoked like methods from class
6355 attributes and therefore always get an instance as the first
6358 * buildbot/changes/maildir.py (Maildir.start): fix error in error
6359 message: thanks to Stephen Davis for the catch
6361 2003-12-04 Brian Warner <warner@lothar.com>
6363 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
6364 twisted's standard ReconnectingClientFactory. Handles both oldcred
6365 and newcred connections. Also has a bug-workaround for
6366 ReconnectingClientFactory serializing its connector when it
6369 * buildbot/bot.py (BotFactory): rewrite connection layer with new
6370 pbutil. Replace makeApp stuff with proper newcred/mktap
6371 makeService(). Don't serialize Ephemerals on shutdown.
6373 * buildbot/changes/changes.py (ChangeMaster): make it a
6374 MultiService and add the sources as children, to get startService
6375 and stopService for free. This also gets rid of the .running flag.
6377 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
6378 new pbutil, turn into a TCPClient at the same time (to get
6379 startService for free). Two variants exist: FreshCVSSourceOldcred
6380 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
6381 yet, but when it does, we'll be ready).
6382 (FreshCVSSource.notify): handle paths which are empty after the
6383 prefix is stripped. This only happens when the top-level (prefix)
6384 directory is added, at the very beginning of a Repository's life.
6386 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6387 Now the only reconnecting code is in the factory where it belongs.
6388 (Builder.unsubscribe): unregister the disconnect callback when we
6389 delete the builder on command from the master (i.e. when the
6390 buildmaster is reconfigured and that builder goes away). This
6391 fixes a multiple-delete exception when the status client is shut
6393 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6396 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6397 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6399 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6401 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6402 a list of globs (ugh). The testdir will be searched for files
6403 named *.tests and run the tests in the order specified in each of
6404 those files. This allows for "dependancies" between tests to be
6407 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6408 argument to pass to run_maxq.py, instead of a glob.
6410 2003-10-17 Brian Warner <warner@lothar.com>
6412 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6413 files that live in the sandbox
6415 2003-10-15 Brian Warner <warner@lothar.com>
6417 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6418 spelling error in "docs" count-warnings output
6419 (HLint.start): stupid thinko meant .xhtml files were ignored
6421 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6422 tests now that cReactor is banished to the sandbox
6424 2003-10-10 Brian Warner <warner@lothar.com>
6426 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6427 scheme: now .xhtml are sources and .html are generated
6429 2003-10-08 Brian Warner <warner@lothar.com>
6431 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6432 we were ignoring the 'randomly' parameter.
6434 2003-10-01 Brian Warner <warner@lothar.com>
6436 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6437 posix, to kill sub-children of aborted slavecommands.
6439 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6440 Clean up initialization: lastBuildStatus remains None until the
6441 first build has been completed.
6443 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6444 None as a lastBuildStatus
6445 * buildbot/clients/gtkPanes.py: same
6447 * buildbot/status/client.py (StatusClientService): keep
6448 BuilderStatus objects in self.statusbags . These objects now live
6449 here in the StatusClientService and are referenced by the Builder
6450 object, rather than the other way around.
6451 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6452 * buildbot/process/base.py (Builder): same
6453 * test/test_config.py (ConfigTest.testBuilders): same
6455 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6456 an existing builder, leave the statusbag alone. This will preserve the
6459 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6460 hook. This will probably go away in favor of a class in upcoming
6463 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6464 serviceName from newcred FreshCVSNotifiee setup
6466 2003-09-29 Brian Warner <warner@lothar.com>
6468 * buildbot/process/process_twisted.py: switch to new reactor
6470 * docs/examples/twisted_master.cfg: same
6472 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6474 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6475 botmaster reference instead of the oldapp service lookup
6477 * buildbot/master.py (BuildMaster.__init__): give the
6478 StatusClientService a reference to the botmaster to make it easier to
6481 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6483 * buildbot/status/html.py (Box.td): escape hreffy things so you
6484 can have spaces in things like builder names
6485 (StatusResourceBuilder.body)
6486 (WaterfallStatusResource.body)
6487 (WaterfallStatusResource.body0): same
6489 2003-09-25 Brian Warner <warner@lothar.com>
6491 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6492 rearrange the builder list when adding or removing builders: keep
6493 them in the order the user requested.
6494 * test/test_config.py (ConfigTest.testBuilders): verify it
6496 * contrib/debug.glade: give the debug window a name
6498 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6499 now wait on multiple interlocks. Fix code relating to that.
6500 (Builder.checkInterlocks): same
6501 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6503 * buildbot/master.py (BuildMaster.loadConfig): move from
6504 deprecated pb.BrokerFactory to new pb.PBServerFactory
6505 * test/test_config.py (ConfigTest.testWebPathname): same
6507 * docs/examples/twisted_master.cfg: fix interlock declaration
6509 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6510 Interlocks to their Builders into interlock.py .
6511 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6513 * test/test_config.py (ConfigTest.testInterlocks): validate
6516 * buildbot/process/base.py (Builder.__init__): better comments
6517 * buildbot/process/interlock.py (Interlock.__repr__): same
6518 (Interlock.deactivate): add .active flag, move the code that
6519 attaches/detaches builders into the Interlock
6521 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6523 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6524 tests using the new run_maxq.py script, and reporting failures by
6527 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6528 tests, reporting their success or failure in a buildbot-friendly
6531 2003-09-24 Brian Warner <warner@lothar.com>
6533 * docs/examples/twisted_master.cfg: example of a new-style config
6534 file. This lives in the buildmaster base directory as
6537 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6538 button to make the master re-read its config file
6540 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6541 buildmaster configuration from a file. This file can be re-read
6542 later, and the buildmaster will update itself to match the new
6543 desired configuration. Also use new Twisted Application class.
6544 * test/Makefile, test/test_config.py: unit tests for same
6546 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6547 FreshCVSSources comparable, to support reload.
6548 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6550 * buildbot/process/base.py (Builder): make them comparable, make
6551 Interlocks easier to attach, to support reload. Handle
6552 re-attachment of remote slaves.
6553 * buildbot/process/interlock.py (Interlock): same
6555 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6556 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6557 buildmaster taps are now constructed with mktap.
6558 * buildbot/status/client.py (StatusClientService): same
6560 * buildbot/status/words.py: move to new Services, add support to
6561 connect to multiple networks, add reload support, allow nickname
6562 to be configured on a per-network basis
6564 2003-09-20 Brian Warner <warner@lothar.com>
6566 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6567 the freebsd builder, now that the machine has been upgraded and no
6568 longer has python2.2
6570 * setup.py (version): bump to 0.3.5+ while between releases
6572 2003-09-19 Brian Warner <warner@lothar.com>
6574 * setup.py (version): Releasing buildbot-0.3.5
6576 2003-09-19 Brian Warner <warner@lothar.com>
6578 * NEWS: add post-0.3.4 notes
6580 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6582 * MANIFEST.in: add contrib/*
6584 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6585 use a remote root now: cvs.twistedmatrix.com
6587 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6589 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6590 compatibility with old servers
6591 (FreshCVSSource.start): and provide a way to use it
6592 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6594 * docs/examples/twisted_master.py (twisted_app): update to new
6596 (twisted_app): listen on new ~buildbot socket
6597 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6599 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6600 to reduce cvs bandwidth (update instead of full checkout)
6602 2003-09-11 Brian Warner <warner@lothar.com>
6604 * contrib/fakechange.py: demo how to connect to the changemaster
6605 port. You can use this technique to submit changes to the
6606 buildmaster from source control systems that offer a hook to run a
6607 script when changes are committed.
6609 * contrib/debugclient.py: tool to connect to the debug port. You
6610 can use it to force builds, submit fake changes, and wiggle the
6613 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6614 'Dispatcher' realm to handle all the different kinds of
6615 connections and Perspectives: buildslaves, the changemaster port,
6616 the debug port, and the status client port. NewCredPerspectives
6617 now have .attached/.detached methods called with the remote 'mind'
6618 reference, much like old perspectives did. All the pb.Services
6619 turned into ordinary app.ApplicationServices .
6620 (DebugService): went away, DebugPerspectives are now created
6621 directly by the Dispatcher.
6622 (makeApp): changed interface a little bit
6624 * buildbot/changes/changes.py: newcred
6625 * buildbot/status/client.py: newcred
6627 * buildbot/clients/base.py: newcred client side changes
6628 * buildbot/bot.py: ditto
6630 * docs/examples/glib_master.py: handle new makeApp() interface
6631 * docs/examples/twisted_master.py: ditto
6633 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6634 base newcred Perspectives on. This should go away once Twisted
6635 itself provides something sensible.
6638 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6640 * contrib/svn_buildbot.py: A program that you can call from your
6641 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6642 when a change in an SVN repository has happened. See the top of
6643 the file for some minimal usage info.
6645 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6647 * buildbot/slavecommand.py (ArglistCommand): Add new
6648 ArglistCommand that takes an argument list rather than a string as
6649 a parameter. Using a st.split() for argv is very bad.
6651 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6652 update to a particular revision rather than always checking out
6653 (still not very smart about it, there may be cases where the
6654 checkout becomes inconsistent).
6656 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6658 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6659 SVN fetch support. It can checkout (not update!) a specified
6660 revision from a specified repository to a specified directory.
6662 * buildbot/status/progress.py (Expectations.update): Fix an
6663 obvious bug (apparently created by the change described in the
6664 previous ChangeLog message) by moving a check to *after* the
6665 variable it checks is defined.
6668 2003-09-08 Brian Warner <warner@lothar.com>
6670 * buildbot/status/progress.py (Expectations.update): hack to catch
6671 an exception TTimo sees: sometimes the update() method seems to
6672 get called before the step has actually finished, so the .stopTime
6673 is not set, so no totalTime() is available and we average None
6674 with the previous value. Catch this and just don't update the
6675 metrics, and emit a log message.
6677 2003-08-24 Brian Warner <warner@lothar.com>
6679 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6680 parameter to set copydir='original' in CVS commands.
6682 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6684 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6685 which tells the command to maintain a separate original-source CVS
6686 workspace. For each build, this workspace will be updated, then
6687 the tree copied into a new workdir. This reduces CVS bandwidth
6688 (from a full checkout to a mere update) while doubling the local
6689 disk usage (to keep two copies of the tree).
6691 2003-08-21 Brian Warner <warner@lothar.com>
6693 * buildbot/status/event.py (Logfile.addEntry): if the master web
6694 server dies while we're serving a page, request.write raises
6695 pb.DeadReferenceError . Catch this and treat it like a
6696 notifyFinish event by dropping the request.
6698 2003-08-18 Brian Warner <warner@lothar.com>
6700 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6701 (instead of blowing up) if a force-build command is given without
6704 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6705 don't blow up if there aren't yet any Changes in the list
6707 2003-08-02 Brian Warner <warner@lothar.com>
6709 * buildbot/bot.py (updateApplication): don't set the .tap name,
6710 since we shouldn't assume we own the whole .tap file
6712 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6713 'mktap buildbot' (without a subcommand) better
6715 2003-07-29 Brian Warner <warner@lothar.com>
6717 * buildbot/status/words.py
6718 (IrcStatusFactory.clientConnectionLost): when we lose the
6719 connection to the IRC server, schedule a reconnection attempt.
6721 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6722 use shutil.rmtree instead of forking off an "rm -rf" command.
6723 rmtree may take a while and will block until it finishes, so we
6724 use "rm -rf" if available.
6726 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6727 freebsd buildslave badly
6729 * setup.py (version): bump to 0.3.4+ while between releases
6731 2003-07-28 Brian Warner <warner@lothar.com>
6733 * setup.py (version): Releasing buildbot-0.3.4
6735 2003-07-28 Brian Warner <warner@lothar.com>
6737 * NEWS: update in preparation for release
6739 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6740 process.signalProcess instead of os.kill, to improve w32
6743 * docs/examples/twisted_master.py (twisted_app): turn off
6744 win32eventreactor: the tests hang the buildslave badly
6746 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6747 failed builds, since usually the failures are consistent
6749 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6750 add compileOpts/compileOpts2 to reactors build
6752 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6753 (twisted_app): use both default and win32eventreactor on w32 build.
6754 Use both default and kqreactor on freebsd build.
6756 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6757 add compileOpts2, which is put after the build_ext argument. w32
6758 needs "-c mingw32" here.
6760 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6761 touch .acqpath, it goes away in recent Twisted releases
6763 * docs/examples/twisted_master.py (twisted_app): use "python" for
6764 the w32 buildslave, not "python2.2"
6766 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6767 the directory exists.. should hush an exception under w32
6769 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6770 ProcessTerminated -provided values for signal and exitCode rather
6771 than parsing the unix status code directly. This should remove one
6772 more roadblock for a w32-hosted buildslave.
6774 * test/test_mailparse.py: add test cases for Syncmail parser
6776 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6777 temporary compatibility import. Note! Start importing
6778 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6780 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6782 2003-07-27 Brian Warner <warner@lothar.com>
6784 * NEWS: started adding new features
6786 * buildbot/changes/mail.py: start work on Syncmail parser, move
6787 mail sources into their own file
6789 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6790 as implementing IChangeSource
6791 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6793 * buildbot/interfaces.py: define the IChangeSource interface
6795 2003-07-26 Brian Warner <warner@lothar.com>
6797 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6799 2003-06-25 Brian Warner <warner@lothar.com>
6801 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6804 2003-06-17 Brian Warner <warner@lothar.com>
6806 * buildbot/status/words.py: clean up method usage to avoid error
6807 in silly IRC command
6808 (IrcStatusBot.emit_status): round off seconds display
6810 * buildbot/process/base.py (Build): delete the timer when saving
6811 to the .tap file, and restore it (if it should still be running)
6812 upon restore. This should fix the "next build in -34 seconds"
6813 messages that result when the master is restarted while builds are
6814 sitting in the .waiting slot. If the time for the build has
6815 already passed, start it very soon (in 1 second).
6817 * buildbot/status/words.py: more silly commands
6819 * README (REQUIREMENTS): add URLs to all required software
6821 * buildbot/status/words.py ('last'): mention results of, and time
6824 2003-05-28 Brian Warner <warner@lothar.com>
6826 * buildbot/status/words.py: add 'last' command
6827 (IrcStatusBot.emit_status): add current-small text to 'status' output
6829 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6830 (twisted_app): remove spaces from OS-X builder name
6832 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6833 * buildbot/status/words.py: IRC bot should actually be useful now
6835 2003-05-23 Brian Warner <warner@lothar.com>
6837 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6838 "slave information" from $(slavedir)/info/* . These files are
6839 maintained by the slave administrator, and describe the
6840 machine/environment that is hosting the slave. Information from
6841 them is put into the "Builder" HTML page. Still need to establish
6842 a set of well-known filenames and meanings for this data: at the
6843 moment, *all* info/* files are sent to the master, but only
6844 'admin' and 'host' are used on that end.
6845 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6846 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6847 * buildbot/master.py (BotPerspective.got_info): ditto
6849 2003-05-22 Brian Warner <warner@lothar.com>
6851 * setup.py (version): bump version to 0.3.3+ while between releases
6853 2003-05-21 Brian Warner <warner@lothar.com>
6855 * setup.py: Releasing buildbot-0.3.3
6857 2003-05-21 Brian Warner <warner@lothar.com>
6859 * NEWS: 0.3.3 news items
6861 * README: describe --keepalive and life behind a NAT box
6863 * buildbot/bot.py (Bot.connected): implement application-level
6864 keepalives to deal with NAT timeouts, turn them on with
6865 --keepalive option or when SO_KEEPALIVE doesn't work.
6867 * buildbot/master.py (BotPerspective): accept keepalives silently
6869 * buildbot/process/base.py (Build.buildException): CopiedFailures
6870 don't carry as much information as local ones, so don't try to
6871 create a big HTMLized version of them.
6873 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6874 log file when step fails due to an exception, such as when the slave
6877 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6878 --testmodule argument instead of grepping for test-case-name tags
6879 ourselves. Remove FindUnitTests code.
6880 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6882 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6884 2003-05-16 Brian Warner <warner@lothar.com>
6886 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6887 argument to allow things like CFLAGS=-O0 to be passed without relying
6888 upon /bin/sh processing on the slave.
6890 * buildbot/process/step.py (InternalShellCommand.start): send
6892 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6893 'split' instead of letting /bin/sh do it. This should also remove
6894 the need for /bin/sh on the buildslave, making it more likely to
6897 * buildbot/status/html.py: html-escape text in blamelist.
6898 Add "force build" button to the Builder page.
6900 * buildbot/process/step_twisted.py (countFailedTests): look at
6901 last 1000 characters for status line, as import errors can put it
6902 before the -200 point.
6904 2003-05-15 Brian Warner <warner@lothar.com>
6906 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6908 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6909 make 'clobber' a parameter, so it is possible to have builds which
6910 do full tests but do a cvs update instead of hammering the CVS
6911 server with a full checkout each build
6913 * buildbot/process/step.py (InternalShellCommand): bump default
6914 timeout to 20 minutes
6916 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6917 the master to trigger a build. Run it via manhole.
6919 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6920 allow slaves to trigger any build that they host, to make life
6921 easier for slave admins who are testing out new build processes
6923 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6924 don't flunk cReactor or qtreactor on failure, since they fail alot
6925 these days. Do warnOnFailure instead.
6927 * buildbot/process/base.py: change Builder.buildable from a list
6928 into a single slot. When we don't have a slave, new builds (once
6929 they make it past the timeout) are now merged into an existing
6930 buildable one instead of being queued. With this change, a slave
6931 which has been away for a while doesn't get pounded with all the
6932 builds it missed, but instead just does a single build.
6934 2003-05-07 Brian Warner <warner@lothar.com>
6936 * setup.py (version): bump version to 0.3.2+ while between releases
6938 2003-05-07 Brian Warner <warner@lothar.com>
6940 * setup.py: Releasing buildbot-0.3.2
6942 2003-05-07 Brian Warner <warner@lothar.com>
6944 * setup.py: fix major packaging error: include subdirectories!
6946 * NEWS: add changes since last release
6948 * README (REQUIREMENTS): update twisted/python dependencies
6950 * buildbot/status/builder.py (Builder.startBuild): change
6951 BuildProcess API: now they should call startBuild/finishBuild
6952 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6953 keeping a list of builds in the statusbag, to support other kinds of
6955 (Builder.addClient): send current-activity-small to new clients
6956 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6959 * buildbot/status/client.py: drop RemoteReferences at shutdown
6961 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6963 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6964 more debug messages for remote status client
6966 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6967 (.stepFailed): only fire the Deferred once, even if both
6968 stepComplete and stepFailed are called. I think this can happen if
6969 an exception occurs at a weird time.
6971 * buildbot/status/words.py: work-in-progress: IRC status delivery
6973 2003-05-05 Brian Warner <warner@lothar.com>
6975 * docs/examples/twisted_master.py (twisted_app): hush internal
6976 python2.3 distutils deprecation warnings
6977 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6978 add compileOpts= argument which inserts extra args before the
6979 "setup.py build_ext" command. This can be used to give -Wignore
6980 warnings, to hush some internal python-2.3 deprecation messages.
6982 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6983 the ['twisted.test'] default test case to make it easier to change
6986 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6987 * buildbot/clients/gtkPanes.py: ditto
6989 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6990 arg to collapse RunUnitTestsRandomly into RunUnitTests
6991 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6992 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6994 * buildbot/status/html.py (StatusResource): shuffle Resources
6995 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6996 would serve the waterfall display, but the internal links were
6997 only valid on the trailing-slash version. The correct behavior is
6998 for the non-slashed one to serve a Redirect to the slashed one.
6999 This only shows up when the buildbot page is hanging off another
7000 server, like a Twisted-Web distributed server.
7002 * buildbot/status/event.py (Event, RemoteEvent): make Events
7003 pb.Cacheable, with RemoteEvent as the cached version. This removes
7004 a lot of explicit send-an-update code.
7005 * buildbot/status/builder.py (Builder): remove send-update code
7006 * buildbot/status/client.py (ClientBuilder): remove send-update
7007 code, and log errors that occur during callRemote (mostly to catch
7008 InsecureJelly exceptions)
7010 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7011 run Lore with the same python used in the rest of the build
7013 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7015 * buildbot/process/step_twisted.py (HLint): accept 'python'
7016 argument. Catch rc!=0 and mark the step as failed. This marks the
7017 build orange ("has warnings").
7018 (RunUnitTestsJelly): move out to step_twisted2.py
7020 * buildbot/util.py (ignoreStaleRefs): add utility function
7022 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7023 don't fake ETA object, it's too hard to get right
7025 2003-05-02 Brian Warner <warner@lothar.com>
7027 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7029 2003-05-01 Brian Warner <warner@lothar.com>
7031 * buildbot/status/html.py (StatusResource.body): oops, I was
7032 missing a <tr>, causing the waterfall page to be misrendered in
7033 everything except Galeon.
7035 2003-04-29 Brian Warner <warner@lothar.com>
7037 * docs/examples/twisted_master.py: make debuild use python-2.2
7038 explicitly, now that Twisted stopped supporting 2.1
7040 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7041 handle tuple results too. I keep forgetting this, which suggests
7042 it needs to be rethought.
7044 * setup.py (setup): bump version to 0.3.1+ while between releases
7046 2003-04-29 Brian Warner <warner@lothar.com>
7048 * setup.py: Releasing buildbot-0.3.1
7050 2003-04-29 Brian Warner <warner@lothar.com>
7052 * README (SUPPORT): add plea to send questions to the mailing list
7054 * NEWS, MANIFEST.in: add description of recent changes
7056 * docs/examples/twisted_master.py: add the code used to create the
7057 Twisted buildmaster, with passwords and such removed out to a
7060 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7061 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7062 buildmasters to not require CVSToys be installed.
7063 * README, docs/examples/glib_master: update to match the change
7065 * buildbot/clients/base.py, buildbot/bot.py,
7066 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7067 ReconnectingPB from CVSToys distribution to remove CVSToys
7068 dependency for build slaves and status clients. Buildmasters which
7069 use FreshCVSSources still require cvstoys be installed, of course.
7071 2003-04-25 Brian Warner <warner@lothar.com>
7073 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7074 runTestsRandomly arg to turn on trial -z
7076 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7077 experimental code to use trial's machine-parseable output to get
7078 more detailed test results. Still has some major issues.
7079 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7082 * buildbot/status/builder.py (Builder.setCurrentBuild):
7083 anticipating moving build history into statusbag, not used yet
7085 * buildbot/status/tests.py: code to centralize test results,
7086 doesn't work quite yet
7088 * buildbot/status/event.py (Event): use hasattr("setName") instead
7089 of isinstance for now.. need better long-term solution
7091 * buildbot/status/html.py: Remove old imports
7093 2003-04-24 Brian Warner <warner@lothar.com>
7095 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
7096 ignore changes under doc/fun/ and sandbox/
7098 * buildbot/process/step_twisted.py: update pushEvent and friends.
7100 * buildbot/status/html.py (Box.td): replace event.buildername with
7101 event.parent.getSwappableName(). Needs more thought.
7103 * buildbot/status/builder.py (Builder): Replace pushEvent and
7104 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
7105 Tell events they are being pruned with event.delete().
7107 * buildbot/process/base.py (Build): Remove Builder status-handling
7108 methods. s/pushEvent/setCurrentActivity/.
7110 * buildbot/process/step.py (BuildStep): clean up status delivery.
7111 Gouse builder.statusbag methods instead of intermediate builder
7112 methods. s/updateLastEvent/updateCurrentActivity/.
7113 s/finalizeLastEvent/finishCurrentActivity/. Use
7114 addFileToCurrentActivity for summaryFunction.
7116 * buildbot/status/event.py (Logfile): put data in a Swappable when
7118 (Event): add more setter methods. Remove .buildername, use .parent
7119 and getSwappableName instead (needs more thought).
7121 * buildbot/util.py (Swappable):
7122 * test/test_swap.py: don't bother setting filename at __init__
7123 time, do it later. Change setFilename args to take parent first,
7124 since it provides the most significant part of the filename.
7126 2003-04-23 Brian Warner <warner@lothar.com>
7128 * buildbot/status/event.py (Logfile.addEntry): append to previous
7131 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
7132 anticipating Swappable
7133 (InternalShellCommand.remoteUpdate): split out various log-adding
7134 methods so subclasses can snarf stdout separately
7136 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
7137 in anticipation of Swappable build logs
7138 (Builder.testsFinished): anticipating TestResults, still disabled
7140 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
7143 * buildbot/status/event.py (Logfile): add (disabled) support for
7144 Swappable, not ready for use yet
7146 * buildbot/util.py (Swappable): object which is swapped out to
7147 disk after some period of no use.
7148 * test/test_swap.py: test buildbot.utils.Swappable
7150 2003-04-14 Brian Warner <warner@lothar.com>
7152 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
7153 periodic-build timer. Set the .periodicBuildTime on a builder
7154 instance to some number of seconds to activate it.
7156 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
7158 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
7159 a way that survives result tuples
7161 2003-04-12 Brian Warner <warner@lothar.com>
7163 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7164 return a dict instead of a tuple: allow summarizers to provide
7165 multiple summaries if they want
7166 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
7167 (debuildSummarizer): summarize lintian warnings/errors
7169 2003-04-10 Brian Warner <warner@lothar.com>
7171 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
7173 2003-04-09 Brian Warner <warner@lothar.com>
7175 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
7176 empty summaries: happens when the tests fail so hard they don't emit
7177 a parseable summary line.
7179 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
7180 Allow summaryFunction to return None to indicate no summary should
7183 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
7184 writing to stale HTTP requests: notice when they disconnect and
7185 remove the request from the list. Also add CacheToFile from
7186 moshez, will be used later.
7188 2003-04-08 Brian Warner <warner@lothar.com>
7190 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
7191 should be an int, not a list of strings
7193 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
7194 if we weren't actually connected
7196 * buildbot/process/step_twisted.py (trialTextSummarizer): function
7197 to show the tail end of the trial text output
7199 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
7200 hook to summarize the results of a ShellCommand
7202 2003-04-07 Brian Warner <warner@lothar.com>
7204 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
7205 twisted test suite code into a single class.
7206 * buildbot/process/process_twisted.py: same
7208 2003-04-04 Brian Warner <warner@lothar.com>
7210 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
7212 * README (SLAVE): document use of mktap to create slave .tap file
7213 (REQUIREMENTS): describe dependencies
7215 * buildbot/bb_tap.py, buildbot/plugins.tml:
7216 * buildbot/bot.py (updateApplication): Add mktap support for creating
7217 buildslave .tap files
7219 2003-03-28 Brian Warner <warner@lothar.com>
7221 * buildbot/process/step.py (InternalShellCommand.finished): handle
7222 new tuple result values (fix embarrasing bug that appeared during
7225 2003-03-27 Brian Warner <warner@lothar.com>
7227 * docs/examples/glib_master.py, README: add sample buildmaster.tap
7230 2003-03-25 Brian Warner <warner@lothar.com>
7232 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
7233 to overall build status
7234 * buildbot/clients/base.py (Builder): improve event printing
7235 * buildbot/process/base.py (BasicBuildFactory): use specific steps
7236 instead of generic ShellCommand
7237 (Build): Add .stopBuild, use it when slave is detached
7239 * buildbot/process/step.py (Configure,Test): give the steps their
7240 own names and status strings
7242 * buildbot/status/html.py (StatusResource): add "show" argument,
7243 lets you limit the set of Builders being displayed.
7245 2003-03-20 Brian Warner <warner@lothar.com>
7247 * buildbot/process/basic.py: removed
7249 2003-03-19 Brian Warner <warner@lothar.com>
7251 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7252 turn off process-docs by default
7254 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
7255 when displaying build information without anything in allBuilds[]
7257 * buildbot/bot.py (makeApp): really take password from sys.argv
7259 2003-03-18 Brian Warner <warner@lothar.com>
7261 * buildbot/bot.py (buildApp): take password from sys.argv
7263 * README: replace with more useful text
7265 * setup.py: add a real one
7266 * MANIFEST.in, .cvsignore: more distutils packaging stuff
7268 * docs/PyCon-2003/: added sources for PyCon paper.
7270 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
7271 now Build objects control the process and Builder only handles
7272 slave stuff and distribution of changes/status. A new BuildFactory
7273 class creates Build objects on demand.
7275 Created ConfigurableBuild which takes a list of steps to run. This
7276 makes it a lot easier to set up a new kind of build and moves us
7277 closer to being able to configure a build from a web page.
7279 * buildbot/process/step_twisted.py, process_twisted.py: move to
7280 new model. A lot of code went away.
7282 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
7283 send lots of empty progress messages to the client.
7285 * buildbot/master.py (makeApp): enforce builder-name uniqueness
7287 2003-02-20 Brian Warner <warner@lothar.com>
7289 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
7291 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
7292 Twisted bug that prevented non-pty processes from working just got
7293 fixed, and the bug that leaks ptys is still being investigated.
7295 * buildbot/process/step.py (CVS): send timeout arg to slave
7297 * buildbot/clients/gtkPanes.py: add connection-status row, handle
7298 builders coming and going
7299 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
7300 from CVSToys, handle lost-buildmaster
7302 * buildbot/status/client.py (StatusClientService.removeBuilder):
7303 Clean up status client protocol: send builders (with references)
7304 as they are created, rather than sending a list and requiring the
7305 client to figure out which ones are new.
7306 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
7307 attempts to force a build on an unknown builder
7309 2003-02-19 Brian Warner <warner@lothar.com>
7311 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
7312 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
7313 Twisted stops leaking them.
7314 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
7315 builder goes to an idle state.
7317 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
7318 I figure out why CVS commands hang without them, and/or I fix the
7319 hung-command timeout
7321 2003-02-16 Brian Warner <warner@lothar.com>
7323 * buildbot/process/step_twisted.py: bin/hlint went away, replace
7324 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
7325 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
7326 GenerateDocs now that they are prefixed with WARNING:.
7328 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
7329 use manual href target instead of request.childLink
7331 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
7332 display every second, but update the ETA every 5 seconds (or
7333 whenever) as remote_progress messages arrive.
7336 2003-02-12 Brian Warner <warner@lothar.com>
7338 * *: import current sources from home CVS repository
7342 # add-log-time-format: add-log-iso8601-time-string