1 2006-09-25 Brian Warner <warner@lothar.com>
3 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
4 Hearsum contributed a status plugin which sends email in the same
5 format that Tinderbox does: this allows a number of tinderbox
6 tools to be driven by Buildbot instead. Thanks Ben!
8 2006-09-24 Brian Warner <warner@lothar.com>
10 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
11 Thanks to Robert Helmer for the patch.
13 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
14 BuildStatus about the buildslave name at the *beginning* of the
15 build, rather than at the end. Thanks to Alexander Lorenz for the
17 * buildbot/status/html.py (StatusResourceBuild.body): always
18 include the slavename in the build page, not just when the build
20 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
21 slavename in the email message
23 2006-09-21 Brian Warner <warner@lothar.com>
25 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
27 * docs/examples/glib_master.cfg: same
28 * docs/examples/hello.cfg: same
29 * docs/examples/twisted_master.cfg: same, update to current usage
31 2006-09-19 Brian Warner <warner@lothar.com>
33 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
34 (PyFlakes.createSummary): make it compatible with python-2.2
36 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
37 for at least the output-parsing parts of PyFlakes
39 2006-09-18 Brian Warner <warner@lothar.com>
41 * buildbot/steps/python.py: oops, fix import of StringIO
43 2006-09-17 Brian Warner <warner@lothar.com>
45 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
46 turns out that SVN-1.4.0 doesn't fail to update once you've
47 replaced a file with a directory, unlike older versions of SVN and
48 pretty much every other VC tool we support. Since what we really
49 care about is that the update succeeds anyway, stop checking that
50 the tree got clobbered and just assert that the build succeeded.
51 (VCBase.printLogs): add a utility function for debugging
53 * buildbot/process/step.py: oops, added extra imports by mistake
55 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
56 rstrip() on the first line coming out of the 'p4 describe'
57 process, to remove the stray ^M that Wade Brainerd reports seeing
58 in the 'when' field. Fixes SF#1555985.
60 * buildbot/master.py (BuildMaster.loadConfig): improve the error
61 message logged when c['schedulers'] is not right
62 * buildbot/scheduler.py (Scheduler.__init__): improve error
63 message when a Scheduler() is created with the wrong arguments
64 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
65 verify that these error messages are emitted
67 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
68 The idea is that all the base classes (like BuildStep and
69 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
70 will be a leftover backwards-compatibility file that only contains
71 aliases for the steps that were moved out to buildbot.steps.*
72 * lots: change imports to match
73 * buildbot/process/step.py: add a DeprecationWarning if it ever
76 2006-09-12 Brian Warner <warner@lothar.com>
78 * buildbot/scheduler.py (Scheduler.__init__): make sure that
79 builderNames= is actually a sequence, since if you happen to give
80 it a single builder-specification dictionary instead, it won't get
81 caught by the existing assert. Thanks to Brett Neely for the
84 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
86 * docs/buildbot.texinfo (Python BuildSteps): document them
87 (sendchange): include a link to PBChangeSource, since you need one
89 * buildbot/steps/shell.py: clean up test-case-name line, remove some
91 * buildbot/steps/dummy.py: same
93 2006-09-08 Brian Warner <warner@lothar.com>
95 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
96 BuildStep which lets you transfer files from the master to the
97 slave or vice versa. Thanks to Albert Hofkamp for the original
98 patch. Fixes SF#1504631.
99 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
101 (SlaveFileDownloadCommand): same
102 * docs/buildbot.texinfo (Transferring Files): document it
103 * buildbot/test/test_transfer.py: test it
104 * buildbot/test/runutils.py (StepTester): new utility class for
105 testing BuildSteps and RemoteCommands without Builds or Bots or PB
106 * buildbot/test/test_steps.py (CheckStepTester): validate that the
109 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
110 walk through StatusLogs one line at a time, mostly for the benefit
111 of ShellCommand.createSummary methods. You can either walk through
112 STDOUT or STDERR, but the default is STDOUT.
114 * buildbot/status/builder.py (LogFile.readlines): implement it.
115 Note that this is not yet memory-efficient, it just pulls the
116 whole file into RAM and then splits it up with a StringIO.
117 Eventually this should be a generator that only pulls chunks from
119 * buildbot/test/test_status.py (Log.testReadlines): test it
121 * docs/buildbot.texinfo: update to match changes
122 * buildbot/process/factory.py: stop using old definitions
123 * buildbot/process/process_twisted.py: same
124 * buildbot/test/test_*.py: same
126 * buildbot/process/step_twisted.py: move definition to..
127 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
128 relative-import mechanisms prevent this from being named 'twisted'
129 or 'python/twisted' as I would have preferred.
131 * buildbot/process/maxq.py: move definition to..
132 * buildbot/steps/maxq.py: .. here, leave a compatibility import
134 * buildbot/process/step.py: split the user-visible BuildSteps into
135 separate files, all under buildbot/steps/
136 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
137 * buildbot/steps/shell.py: this holds ShellCommand and friends
138 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
140 2006-09-05 Brian Warner <warner@lothar.com>
142 * lots: run pyflakes, removed a lot of unused imports, changed the
143 form of some conditional imports to remove false pyflakes
144 warnings. There are still a number of warnings left, mostly from
145 imports that are done for their side-effects.
146 * buildbot/test/test_vc.py: import twisted.python.failure, since it
149 2006-08-26 Brian Warner <warner@lothar.com>
151 * buildbot/test/test_locks.py (Unit.testLater): make the tests
152 compatible with twisted-1.3.0, for some reason I just can't seem
153 to let go of the past.
155 2006-08-25 Brian Warner <warner@lothar.com>
157 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
159 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
160 all logfiles= in startCommand(), rather than in start() . This
161 makes it easier to have the 'stdio' log come before any secondary
162 logfiles, which I feel makes the waterfall display more
164 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
165 from ShellCommand up into LoggingBuildStep
166 (LoggingBuildStep.__init__): move the handling of logfiles= from
167 ShellCommand up to LoggingBuildStep, because startCommand is
168 provided by LoggingBuildStep, whereas start() was specific to
169 subclasses like ShellCommand and Source. This removes code
170 duplication in those subclasses.
171 (ShellCommand.__init__): same
172 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
173 for a slave that's too old to understand logfiles= into a separate
174 method, so it can live in ShellCommand. The rest of
175 setupLogfiles() can live in LoggingBuildStep.
177 2006-08-24 Brian Warner <warner@lothar.com>
179 * buildbot/locks.py (BaseLock): you can now configure Locks to
180 allow multiple simultaneous owners. They still default to
181 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
183 * docs/buildbot.texinfo (Interlocks): document the new options
184 * buildbot/test/test_locks.py: add a bunch of new unit tests
185 * buildbot/process/base.py (Build.acquireLocks): locks now offer
186 waitUntilMaybeAvailable, not waitUntilAvailable
187 * buildbot/process/step.py (BuildStep.acquireLocks): same
188 * buildbot/master.py (BotMaster.getLockByID): real locks now use
189 the whole lockid in their constructor, not just the name. Also,
190 keep track of which real locks we've handed out by the full
191 lockid, not just class+name, otherwise changing just the maxCount=
192 in the master.cfg file would not actually cause a behavioral
195 2006-08-23 Brian Warner <warner@lothar.com>
197 * buildbot/__init__.py (version): bump to 0.7.4+ while between
199 * docs/buildbot.texinfo: same
201 2006-08-23 Brian Warner <warner@lothar.com>
203 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
204 * docs/buildbot.texinfo: set version to match
205 * NEWS: update for 0.7.4
206 * buildbot/slave/commands.py (command_version): mention that this
207 version (2.1) was released with buildbot-0.7.4
209 2006-08-22 Brian Warner <warner@lothar.com>
213 * CREDITS: new file, list of people who have helped. Thanks!
214 * MANIFEST.in: ship it
216 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
217 new diagrams, the user's manual is more informative than it was.
218 Start shipping the .html user's manual (and generated .png
220 * Makefile: update 'release' target to match
222 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
223 test.. I think the web-parts effort will render it pointless well
224 before it ever actually starts to work.
226 2006-08-20 Brian Warner <warner@lothar.com>
228 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
229 meaning of the prefix= argument. It is now just a string which is
230 stripped from the beginning of the filename. If prefix= is set but
231 not found on any given filename, that filename is ignored. If all
232 filenames in a Change are ignored, the Change is dropped. This is
233 much simpler than the previous sep= nonsense, and I should have
234 implemented it this way from the beginning. Effectively resolves
235 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
236 Gedminas for the catch and suggested fixes.
237 (ChangePerspective.perspective_addChange): implement the actual
239 * buildbot/test/test_changes.py (TestChangePerspective): test it
240 * docs/buildbot.texinfo (PBChangeSource): document it, explain
241 how to properly use prefix=
242 * docs/examples/twisted_master.cfg (source): update prefix= by
243 adding the trailing slash
246 * docs/examples/twisted_master.cfg: update to actual practice
248 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
249 update test case to match new link text.. the HREF has both a
250 class= setting and an enclosing [] pair that I didn't match in the
253 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
254 list of strings is preferred over a single string with embedded
256 (ShellCommand.description=): explain that either single strings or
257 a list of strings is acceptable, and why you might prefer one over
258 the other. Add an example. Fixes SF#1524659, thanks to Paul
259 Winkler for the catch.
260 (Build Steps): update to use f.addStep() rather than using s()
261 and the constructor list
263 * buildbot/process/step.py (ShellCommand): accept either a single
264 string or a list of strings in both description= and
266 * buildbot/test/test_steps.py (Steps.test_description): test it
267 * buildbot/test/runutils.py (makeBuildStep): support for that test
269 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
270 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
271 collecting the files and creating the patch.
273 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
274 per-step URLs that will be displayed on the waterfall display,
275 for things like the HTML output of code-coverage tools, when
276 the results are hosted elsewhere.
277 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
278 way to retrieve these URLs
279 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
280 the method to retrieve these URLs. Also provide backwards
281 compatibility for saved BuildStepStatus instances that didn't have
283 * buildbot/process/step.py (BuildStep.addURL): method to set these
284 URLs from within a BuildStep
285 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
286 (StepBox.getBox): give these external links a distinct CSS class
287 named "BuildStep external" so a .css file can display them
290 * buildbot/test/test_web.py (WaterfallSteps): test that we really
292 * buildbot/test/test_steps.py (Steps): test that we can all the
293 URLs. Also add a bunch of other tests on methods that can be
294 called from within BuildSteps
295 * buildbot/test/runutils.py (makeBuildStep): add utility function
297 2006-08-13 Brian Warner <warner@lothar.com>
299 * docs/buildbot.texinfo (BuildStep LogFiles): document them
301 2006-08-10 Brian Warner <warner@lothar.com>
303 * docs/buildbot.texinfo (Index of master.cfg keys): add another
304 index, this one of things like c['sources'] and c['schedulers']
305 (indices): it looks like my clever idea of putting the @fooindex
306 commands in between the @node and the @subsection (to make the
307 HREF anchor jump to slightly above the section title, which works
308 much better in html) confused texinfo horribly, so I'm moving the
309 index tags back to be just after the @subsection marker. I also
310 added extra lines between the @node/@section paragraph and the
311 index tags, since I think maybe texinfo wants to see these be
314 * docs/Makefile (images): make sure images get built when
316 * docs/images/Makefile: same
318 * buildbot/scripts/runner.py: rename 'buildbot master' to
319 'buildbot create-master', and 'buildbot slave' to 'buildbot
321 * docs/buildbot.texinfo: same
324 * docs/buildbot.texinfo: reimplement the "useful classes" index
325 with actual texinfo indices. The .info rendering is a bit
326 weird-looking but it works well, and the HTML rendering is quite
327 nice. This also puts the index targets in the regular flow of the
328 text, which is easier to maintain.
330 2006-08-06 Brian Warner <warner@lothar.com>
332 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
333 Kevin Turner to prefer the environ= argument be a list rather than
334 a string. If it is a list, it will be joined with a platform-local
335 os.pathsep delimiter, and then prepended to any existing
336 $PYTHONPATH value. This works better in cross-platform (i.e.
337 windows buildslaves) environments when you need to push multiple
338 directories onto the front of the path.
339 (SlaveShellCommand): documented the new magic
340 * docs/buildbot.texinfo (ShellCommand): documented the new magic
341 in a user-visible form
343 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
344 Turner to prefer lists over strings when creating/running VC
345 commands during unit tests. This is clearly necessary to survive
346 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
347 renamed the wq() function to qw() though, since that's how it's
348 spelled in perl. Eventually I'd prefer all commands to be
349 specified with lists.
351 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
352 which are deleted (or not yet created) correctly. Also add
353 failsafe code to not explode if the file-watching poller doesn't
354 get started. Thanks to JP Calderone for the catch and the poller
356 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
358 * buildbot/test/emitlogs.py: same
360 * NEWS: summarize recent changes
362 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
363 clause to avoid the "host key mismatch" warning
365 * buildbot/process/step_twisted.py (Trial.start): if the
366 buildslave is too old to understand logfiles=, fall back to
367 running 'cat _trial_temp/test.log' like before.
368 (Trial.commandComplete): same. this takes advantage of the
369 LoggingBuildStep refactoring to stall commandComplete long enough
370 to run a second RemoteShellCommand.
372 * buildbot/process/step.py (LoggingBuildStep.startCommand):
373 refactor command-completion handling, to allow methods like
374 commandComplete/createSummary/evaluateCommand to return Deferreds.
375 (LoggingBuildStep._commandComplete): delete the refactored method
376 (ShellCommand.setupLogfiles): if the buildslave is too old to
377 understand logfiles=, put a warning message both into twistd.log
378 and into the otherwise empty user-visible LogFiles.
380 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
381 callers to provide the slave-side logfile name, rather than
382 forcing it to come from the local name of the LogFile.
383 (BuildStep.getSlaveName): new method
385 * buildbot/process/base.py (Build.getSlaveName): new method, so
386 steps can find out which buildslave they're running on
388 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
389 to match the s/cvs_ver/command_version/ change
391 2006-08-05 Brian Warner <warner@lothar.com>
393 * buildbot/slave/commands.py (command_version): replace the CVS
394 auto-updated cvs_ver keyword with a manually-updated variable,
395 since CVS is no longer the master repository. Add a description of
396 the remote API change starting in this version (2.1), specifically
397 the fact that SlaveShellCommand now accepts 'initial_stdin',
398 'keep_stdin_open', and 'logfiles'.
400 2006-07-31 Brian Warner <warner@lothar.com>
402 * docs/buildbot.texinfo (System Architecture): Finally add lots of
403 diagrams to describe how the whole system fits together. The
404 images themselves are kept in SVG files, with ascii-art versions
405 in corresponding .txt files. Texinfo knows how to interpolate the
406 text version into .info files, reference the .png versions from
407 .html files, and include .eps versions in the .ps format.
408 * docs/images/Makefile: tools to create .png and .eps
409 * docs/images/*.svg: created pictures with Inkscape.
410 * .darcs-boring: ignore the generated .eps and .png files
412 2006-07-24 Brian Warner <warner@lothar.com>
414 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
415 Scheduler names, since they cause setServiceParent to explode
417 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
419 2006-07-20 Brian Warner <warner@lothar.com>
421 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
422 which runs the buildbot unit tests
424 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
425 classes that are useful in master.cfg
427 2006-07-15 Brian Warner <warner@lothar.com>
429 * Makefile (some-apidocs): new target to build only some epydocs
431 * setup.py: minor comment.. does the classifiers= argument prevent
432 the setup.py script from working on python2.2/2.3?
434 * buildbot/scripts/sample.cfg: update manhole example, arrange into
437 * buildbot/twcompat.py: fix minor typo in comments
439 * buildbot/manhole.py: move all Manhole-related code out to this
440 module. Implement SSH-based manholes (with TwistedConch), and move
441 to conch's nifty line-editing syntax-coloring REPL shell instead
442 of the boring non-editing monochromatic (and deprecated) old
444 * buildbot/master.py: remove all Manhole-related code
445 (BuildMaster.loadConfig._add): make sure the old manhole is
446 removed before we add the new one
447 * docs/buildbot.texinfo (Debug options): document new Manhole options
449 * buildbot/twcompat.py (_which): fix some epydoc issues
450 * buildbot/status/html.py (Waterfall.__init__): same
452 2006-06-29 Brian Warner <warner@lothar.com>
454 * buildbot/interfaces.py: get Interface from b.twcompat to hush
455 deprecation warnings under newer Twisteds (by using
456 zope.interface.Interface instead of old twisted.python.components
458 * buildbot/slave/interfaces.py: same
460 2006-06-28 Brian Warner <warner@lothar.com>
462 * buildbot/slave/commands.py (SVN): add --non-interactive to all
463 svn commands, so it will fail immediately instead of hanging while
464 it waits for a username/password to be typed in.
466 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
467 log message if the step was shut down
469 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
470 obsolete reference to mktap.
472 2006-06-20 Brian Warner <warner@lothar.com>
474 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
475 test to include new 'logfiles' argument sent from master to slave
477 2006-06-19 Brian Warner <warner@lothar.com>
479 * buildbot/process/step_twisted.py (Trial): track Progress from
480 _trial_temp/test.log too
482 * buildbot/process/step.py (OutputProgressObserver): generalize
483 the earlier StdioProgressObserver into an OutputProgressObserver
484 that can track LogFiles other than stdio.
485 (LoggingBuildStep.__init__): same
487 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
488 _trial_temp/test.log, not a separate 'cat' command. TODO: this
489 will fail under windows because of os.sep issues. It might have
490 worked before if 'cat' was doing cygwin path conversion.
492 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
493 creation of LogFileWatchers
494 (ShellCommand._startCommand): and record the files that were
495 watched in the 'headers' section of the ShellCommand output
497 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
498 need to actually pass it to the slave if you want it to work.
499 (ShellCommand): document it a bit
501 * buildbot/test/test_shell.py: new test to validate LogFiles
502 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
504 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
505 before printing the last batch of lines, to test that the polling
506 logic is working properly
508 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
509 handling, making it possible to track multiple logs for a single
510 RemoteCommand. The previous single logfile is now known as the
512 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
513 (RemoteShellCommand.__init__): accept logfiles=
514 (LoggingBuildStep.startCommand): stdio_log is now one of many
515 (ShellCommand): added logfiles= argument, as well as a class-level
516 .logfiles attribute, which will be merged together to figure out
517 which logfiles should be tracked. The latter maybe be useful for
518 subclasses of ShellCommand which know they will aways produce
519 secondary logfiles in the same location.
521 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
522 and closeStdin() methods, preparing to make it possible to write
523 to a ShellCommand's stdin at any time, not just at startup. These
524 writes are buffered if the child process hasn't started yet.
525 (LogFileWatcher): new helper class to watch arbitrary logfiles
526 while a ShellCommand runs. This class polls the file every two
527 seconds, and sends back 10k chunks to the buildmaster.
528 (ShellCommand): rename stdin= to initialStdin=, and add
529 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
531 (ShellCommand.addLogfile): LogFile text is sent in updates with a
532 key of "log" and a value of (logname, data).
533 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
534 'logfiles' to the master-visible args dictionary.
535 (SourceBase.doPatch): match s/stdin/initialStdin/ change
538 * buildbot/test/test_vc.py (Patch.testPatch): same
541 * buildbot/test/emit.py: write to a logfile in the current
542 directory. We use this to figure out what was used as a basedir
543 rather than looking to see which copy of emit.py gets run, so that
544 we can run the commands from inside _trial_temp rather than inside
546 * buildbot/test/subdir/emit.py: same
547 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
548 argument rather than running from buildbot/test/
549 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
550 rather than using an implicit setUp()
551 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
552 (ShellBase.testShell1, etc): use explicit path to emit.py instead
553 of assuming that we're running in buildbot/test/ (and that '.' is
556 * buildbot/slave/commands.py (Command.doStart): refactor Command
557 startup/completion a bit: now the SlaveBuilder calls doStart(),
558 which is not meant for overridding by subclasses, and doStart()
559 calls start(), which is. Likewise the SlaveBuilder calls
560 doInterrupt(), and subclasses override interrupt(). This also puts
561 responsibility for maintaining .running in Command rather than in
563 (Command.doInterrupt): same
564 (Command.commandComplete): same, this is called when the deferred
565 returned by start() completes.
566 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
567 (SlaveBuilder.remote_interruptCommand): same
568 (SlaveBuilder.stopCommand): same
570 2006-06-16 Brian Warner <warner@lothar.com>
572 * buildbot/test/test_shell.py: new test file to contain everything
573 relating to ShellCommand
574 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
575 multiple logfiles in realtime" feature, not yet implemented
576 * buildbot/test/emitlogs.py: support file for testLogFiles
577 * docs/buildbot.texinfo (ShellCommand): document the feature
579 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
581 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
582 for tests which exercise SlaveCommands in isolation.
584 * buildbot/test/test_slavecommand.py: Move some utilities like
585 SignalMixin and FakeSlaveBuilder from here ..
586 * buildbot/test/runutils.py: .. to here, so they can be used by
587 other test classes too
588 * buildbot/test/test_vc.py: more SignalMixin refactoring
589 * buildbot/test/test_control.py: same
590 * buildbot/test/test_run.py: and some rmtree refactoring
592 2006-06-15 Brian Warner <warner@lothar.com>
594 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
595 'testBranch' to match other VC tests and have the tests run in
596 roughly increasing order of dependency
598 * buildbot/test/test_steps.py (LogObserver): new test to verify
599 LogObservers can be created at various times and still get
600 connected up properly
602 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
603 to create BuildStepStatus instances that actually work.
605 * buildbot/process/step.py (LogObserver): add outReceived and
606 errReceived base methods, to be overridden
608 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
609 API to take a name instead of a step, reducing the coupling
610 somewhat. This returns the BuildStepStatus object so it can be
611 passed to the new Step, instead of jamming it directly into the
613 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
615 * buildbot/process/base.py (Build.setupBuild): use both methods
616 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
617 process a bit to match
619 2006-06-14 Brian Warner <warner@lothar.com>
621 * docs/buildbot.texinfo (Adding LogObservers): add some limited
622 docs on writing new LogObserver classes
623 (Writing New Status Plugins): brief docs on how Status Plugins fit
626 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
627 implement a LogObserver that counts how many unit tests have been
629 (Trial.__init__): wire it in
630 * buildbot/test/test_twisted.py (Counter): unit test for it
632 * buildbot/process/step_twisted.py (HLint.commandComplete): update
633 to new cmd.logs['stdio'] scheme
634 (Trial.commandComplete): same
635 (BuildDebs.commandComplete): same
637 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
638 LogFiles, instead of just a single one. The old single logfile is
639 now called "stdio". LoggedRemoteCommand no longer creates a
640 LogFile for you (the code to do that was broken anyway). If you
641 don't create a "stdio" LogFile, then stdout/stderr will be
643 (LogObserver): implement "LogObservers", which a BuildStep can add
644 to parse the output of a command in real-time. The primary use is
645 to provide more useful information to the Progress code, allowing
646 better ETA estimates.
647 (LogLineObserver): utility subclass which feeds complete lines to
648 the parser instead of bytes.
649 (BuildStep.progressMetrics): this is safer as a tuple
650 (BuildStep.setProgress): utility method, meant to be called by
652 (BuildStep.addLogObserver): new method, to be called at any time
653 during the BuildStep (even before any LogFiles have been created),
654 to attach (or schedule for eventual attachment) a LogObserver to a
656 (StdioProgressObserver): new LogObserver which replaces the old
657 "output" progress gatherer
658 (LoggingBuildStep.__init__): same
659 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
660 (LoggingBuildStep._commandComplete): must use logs['stdio']
661 instead of the old single ".log" attribute.
662 * buildbot/status/builder.py (LogFile): remove old logProgressTo
663 functionality, now subsumed into StdioProgressObserver
664 * buildbot/test/test_status.py (Subscription._testSlave_2): the
665 log name changed from "output" to "stdio".
668 * buildbot/interfaces.py (ILogFile): add the Interface used from
669 the BuildStep towards the LogFile
670 (ILogObserver): and the one provided by a LogObserver
671 * buildbot/status/builder.py (LogFile): implement it
673 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
674 HEADER constants here ..
675 * buildbot/status/builder.py (STDOUT): .. from here
677 2006-06-13 Brian Warner <warner@lothar.com>
679 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
680 compatibility with python2.2, which doesn't have the 'substr in
682 (TestP4Poller.makeTime): utility function to construct the
683 timestamp using the same strptime() approach as p4poller does. It
684 turns out that time.mktime() behaves slightly differently under
685 python2.2, probably something to do with the DST flag, and that
686 causes the test to fail under python2.2. (changing the mktime()
687 arguments to have dst=0 instead of -1 caused it to fail under
688 python2.3. Go figure.)
689 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
691 2006-06-12 Brian Warner <warner@lothar.com>
693 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
694 proper Perforce (P4) support. Many many thanks to Scott Lamb for
695 contributing such an excellent patch, including docs and unit
696 tests! This makes it *so* much easier to apply. I had to update
697 test_vc.py to handle some recent refactorings, but everything else
698 applied smoothly. The only remaining thing I'd like to fix would
699 be to remove the hard-wired port 1666 used by p4d, and allow it to
700 claim any unused port. This would allow two copies of the test
701 suite to run on the same host at the same time, as well as
702 allowing the test suite to run while a real (production) p4d was
703 running on the same host. Oh, and maybe we should add a warning to
704 step.P4 that gets emitted if the slave is too old to provide the
705 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
706 * buildbot/slave/commands.py (P4): same
707 (P4Sync): same, some minor updates
708 * buildbot/changes/p4poller.py: same
709 * docs/buildbot.texinfo: same
710 * buildbot/test/test_p4poller.py: same
711 * buildbot/test/test_vc.py (P4): same
713 * setup.py: add Trove classifiers for PyPI
715 2006-06-08 Brian Warner <warner@allmydata.com>
717 * buildbot/status/client.py
718 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
719 changing this from getCurrentBuild() to getCurrentBuilds(). Each
720 build needs to be IRemote'd separately, rather than IRemote'ing
721 the whole list at once. I can't wait until newpb's serialization
722 adapters make this unnecessary.
724 2006-06-06 Brian Warner <warner@lothar.com>
726 * buildbot/process/step.py (WithProperties): make this inherit
727 from ComparableMixin, so that reloading an unchanged config file
728 doesn't cause us to spuriously reload any Builders which use them.
729 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
732 2006-06-03 Brian Warner <warner@lothar.com>
734 * contrib/windows/{setup.py, buildbot_service.py}: add support for
735 running py2exe on windows, contributed by Mark Hammond. Addresses
736 SF#1401121, but I think we still need to include
737 buildbot/scripts/sample.cfg
738 * setup.py: include buildbot_service.py as a script under windows
739 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
740 a py2exe application), get the icon/css datafiles from a different
743 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
744 double-escape the build URL. Thanks to Olivier Bonnet for the
745 patch. Fixes SF#1452801.
747 2006-06-02 Brian Warner <warner@lothar.com>
749 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
750 first six columns of 'svnlook' output, not just the first column,
751 since property changes appear in the other five. Thanks to Olivier
752 Bonnet for the patch. Fixes SF#1398174.
754 2006-06-01 Brian Warner <warner@lothar.com>
756 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
757 the fake build, so that title= has something to be set to
759 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
760 attribute of the "Build #NN" link in the yellow start-the-build
761 box to the build's reason. This means that you get a little
762 tooltip explaining why the build was done when you hover over the
763 yellow box. Thanks to Zandr Milewski for the suggestion.
765 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
766 (Box.setETA): handle ETA=None (by stopping the timer)
767 (Box.update): make the [soon] text less different than the usual
768 text, so the rest of the text doesn't flop around so much. It
769 would be awfully nice to figure out how to center this stuff.
770 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
772 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
773 by default, so that any ShellCommand which fails marks the overall
774 build as a failure. I should have done this from the beginning.
775 Add flunkOnFailure=False to the arguments if you want to turn off
778 2006-05-30 Brian Warner <warner@lothar.com>
780 * buildbot/clients/gtkPanes.py: add a third row: now it shows
781 last-build/current-build/current-step. Show what step is currently
782 running. Show ETA for both the overall build and the current step.
783 Update GTK calls to modern non-deprecated forms. There's still a
784 lot of dead code and debug noise to remove.
786 * buildbot/process/step_twisted.py (Trial): set the step name, so it
787 shows up properly in status displays
789 2006-05-28 Brian Warner <warner@lothar.com>
791 * buildbot/test/test_properties.py (Run.testInterpolate): on the
792 build we use to verify that WithProperties works:
794 ** set flunkOnFailure=True so that build failures get noticed
795 ** set workdir='.' so that the build succeeds, otherwise it is trying
796 to touch 'build/something', and 'build/' doesn't exist because
797 usually that's created by a Source step
798 ** set timeout=10, because Twisted-1.3.0 has a race condition that
799 this test somehow triggers, in which the 'touch' process becomes
800 a zombie and we wait for th etimeout before giving up on it.
802 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
803 to log the Build results and step logs to the twisted log.
804 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
805 what went wrong if a build was expected to succeed but didn't.
807 * buildbot/process/step_twisted.py (Trial): set the default
808 trialMode to '--reporter=bwverbose', which specifies verbose
809 black-and-white text. Back in twisted-1.3/2.0 days we had to use
810 '-to', but those are completely missing in modern Twisteds.
812 * buildbot/scripts/sample.cfg: make the sample Manhole config use
813 a localhost-only port, to encourage better security
815 * docs/buildbot.texinfo (Change Sources): mention
818 * .darcs-boring: add a Darcs boringfile
820 * README (REQUIREMENTS): stop claiming compatibility with
823 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
826 2006-05-27 Brian Warner <warner@lothar.com>
828 * buildbot/__init__.py: bump to 0.7.3+ while between releases
829 * docs/buildbot.texinfo: same
831 2006-05-23 Brian Warner <warner@lothar.com>
833 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
834 * docs/buildbot.texinfo: set version to match
835 * NEWS: update for 0.7.3
837 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
838 give a quick mapping from VC system to possible ChangeSources
839 (Build Properties): add 'buildername'
841 * buildbot/process/base.py (Build.setupStatus): oops, set
842 'buildername' and 'buildnumber' properties
843 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
846 2006-05-22 Brian Warner <warner@lothar.com>
848 * docs/buildbot.texinfo (Build Properties): explain the syntax of
849 property interpolation better
851 * README (INSTALLATION): remove old '-v' argument from recommended
854 * docs/buildbot.texinfo (ShellCommand): add docs for description=
855 and descriptionDone= arguments. Thanks to Niklaus Giger for the
858 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
859 'svnversion' instead of grepping the output of 'svn info', much
860 simpler and avoids CR/LF problems on windows. Thanks to Olivier
861 Bonnet for the suggestion.
862 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
863 require the WC_PATH argument, so run 'svnversion .' instead.
865 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
866 aren't supposed to have 'self' in their argument list
868 2006-05-21 Brian Warner <warner@lothar.com>
870 * buildbot/process/step.py (ShellCommand.start): make
871 testInterpolate pass. I was passing the uninterpolated command to
872 the RemoteShellCommand constructor
873 (ShellCommand._interpolateProperties): oops, handle non-list
874 commands (i.e. strings with multiple words separated by spaces in
875 them) properly, instead of forgetting about them.
877 * buildbot/test/test_properties.py (Run.testInterpolate): new test
878 to actually try to use build properties in a real build. This test
880 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
881 to start and evaluate builds
883 * buildbot/test/test__versions.py: add a pseudo-test to record
884 what version of Twisted/Python/Buildbot are running. This should
885 show up at the beginning of _trial_tmp/test.log, and exists to help
886 debug other problems.
888 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
889 a filename to be served as 'robots.txt' to discourage web spiders.
890 Adapted from a patch by Tobi Vollebregt, thanks!
891 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
892 (Waterfall.test_waterfall): tweak the way that filenames are put
893 into the config file, to accomodate windows pathnames better.
895 * docs/buildbot.texinfo (HTML Waterfall): document it
897 * buildbot/process/process_twisted.py
898 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
899 changed the build process. The new setup.py no longer takes the
901 (FullTwistedBuildFactory.__init__): same
902 (TwistedReactorsBuildFactory.__init__): same
904 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
905 be placed in the [hooks] section of the central repository (the
906 one that everybody pushes changes to).
908 2006-05-20 Brian Warner <warner@lothar.com>
910 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
911 .darcs-context file, use binary mode. I think this was causing a
912 Darcs failure under windows.
914 2006-05-19 Brian Warner <warner@lothar.com>
916 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
917 use a timezone string of +0000 and gmtime, since this timestamp is
918 sent to a buildmaster and %z is broken.
920 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
921 string and localtime, since this timestamp will only be consumed
922 locally, and %z is broken.
924 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
925 gmtime, since this timestamp is returned to the buildmaster, and
928 2006-05-18 Brian Warner <warner@lothar.com>
930 * NEWS: update in preparation for next release
932 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
933 setup-repository and do-we-have-the-vc-tools code into a separate
934 "helper" class, which sticks around in a single module-level
935 object. This seems more likely to continue to work in the future
936 than having it hide in the TestCase and hope that TestCases stick
937 around for a long time.
939 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
940 addremove' has been deprecated in recent versions of mercurial, so
943 2006-05-07 Brian Warner <warner@lothar.com>
945 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
946 operating under windows, move the file before opening it, since
947 you can't rename a file that somebody has open.
949 * buildbot/process/base.py (Build.setupBuild): if something goes
950 wrong while creating a Step, log the name and arguments, since the
951 error message when you get the number of arguments wrong is really
954 2006-05-06 Brian Warner <warner@lothar.com>
956 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
957 bugs in twisted-specific code not covered by my unit tests, this
958 time use 'cmd' argument instead of self.cmd
960 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
961 fix stupid braino: either use startwith or find()==0, not both.
962 (TwistedReactorsBuildFactory.__init__): another dumb typo
964 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
965 mark this test as TODO under windows, since process-killing seems
966 dodgy there. We'll come back to this later and try to fix it
969 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
970 and don't include a timezone
971 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
972 This should avoid the windows-with-verbose-timezone-name problem
974 (Patch.testPatch): add a test which runs 'patch' with less
975 overhead than the full VCBase.do_patch sequence, to try to isolate
976 a windows test failure. This one uses slave.commands.ShellCommand
977 and 'patch', but none of the VC code.
979 * buildbot/slave/commands.py (getCommand): use which() to find the
980 executables for 'cvs', 'svn', etc. This ought to help under
983 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
984 working directory before starting. If an earlier test failed, the
985 leftover directory would mistakenly flunk a later test.
986 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
987 Make sure that we use the right commandlines if which("tla") picks
988 up "tla.exe" (as it does under windows).
989 (TlaSupport.do_get): factor out this tla-vs-baz difference
990 (TlaSupport.vc_create): more tla-vs-baz differences
992 * buildbot/test/test_slavecommand.py
993 (ShellBase.testShellMissingCommand): stop trying to assert
994 anything about the error message: different shells on different
995 OSes with different languages makes it hard, and it really isn't
996 that interesting of a thing to test anyway.
998 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
999 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
1000 "Panther"), because it has a bug which flunks a couple tests in
1001 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
1002 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
1003 able to test that yet.
1005 2006-04-30 Brian Warner <warner@lothar.com>
1007 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
1008 make sure child commands emit messages in english, so our regexps
1009 will match. Thanks to Nikaus Giger for identifying the problems.
1010 (VCBase._do_vctest_export_1): mode="export" is not responsible
1011 for setting the "got_revision" property, since in many cases it is
1012 not convenient to determine.
1013 (SVNSupport.capable): when running 'svn --version' to check for
1014 ra_local, we want error messages in english
1015 * buildbot/test/test_slavecommand.py
1016 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
1017 to emit the error message in english
1019 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
1020 the environment with $LC_ALL="C" so that Commands which need to
1021 parse the output of their child processes can obtain it in
1023 (SVN.parseGotRevision): call "svn info" afterwards instead of
1024 watching the output of the "svn update" or "svn checkout".
1025 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
1026 (Arch.parseGotRevision): same
1027 (Bazaar.parseGotRevision): same
1028 (Mercurial.parseGotRevision): same
1030 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
1031 $LC_ALL="C" when running commands under 'buildbot try', too
1033 * buildbot/test/__init__.py: remove the global os.environ()
1034 setting, instead we do it just for the tests that run commands and
1035 need to parse their output.
1037 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
1038 remove the overly-short .timeout on this test, because non-DNotify
1039 platforms must fall back to polling which happens at 10 second
1040 intervals, so a 5 second timeout would never succeed.
1042 2006-04-24 Brian Warner <warner@lothar.com>
1044 * docs/buildbot.texinfo (Installing the code): update trial
1045 invocation, SF#1469116 by Niklaus Giger.
1046 (Attributes of Changes): updated branch-name examples to be
1047 a bit more realistic, SF#1475240 by Stephen Davis.
1049 * contrib/windows/buildbot2.bat: utility wrapper for windows
1050 developers, contributed by Nick Trout (after a year of neglect..
1051 sorry!). SF#1194231.
1053 * buildbot/test/test_vc.py (*.capable): store the actual VC
1054 binary's pathname in VCS[vcname], so it can be retrieved later
1055 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
1056 strip out non-numeric timezone information, specifically the funky
1057 German string that his system produced that confuses CVS.
1058 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
1059 allow Darcs tests to work on windows
1060 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
1061 procutils.which() everywhere, to allow tryclient to work under
1062 windows. Also from Niklaus Giger, SF#1463394.
1064 * buildbot/twcompat.py (which): move the replacement for a missing
1065 twisted.python.procutils.which from test_vc.py to here, so it can
1066 be used in other places too (specifically tryclient.py)
1068 2006-04-23 Brian Warner <warner@lothar.com>
1070 * buildbot/status/html.py (StatusResourceBuild.body): replace the
1071 bare buildbotURL/projectName line with a proper DIV, along with a
1072 CSS class of "title", from Stefan Seefeld (SF#1461675).
1073 (WaterfallStatusResource.body0): remove the redundant 'table'
1074 class from the table
1075 (WaterfallStatusResource.body): same. Also add class="LastBuild"
1076 to the top-row TR, and class="Activity" to the second-row TR,
1077 rather than putting them in the individual TD nodes.
1079 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
1080 'got_revision' build property for all VC systems that implement
1081 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
1083 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
1084 to determine which revision we actually obtained
1085 (CVS.parseGotRevision): implement this for CVS, which just means
1086 to grab a timestamp. Not ideal, and it depends upon the buildslave
1087 having a clock that is reasonably well syncronized with the server,
1088 but it's better than nothing.
1089 (SVN.parseGotRevision): implement it for SVN, which is accurate
1090 (Darcs.parseGotRevision): same
1091 (Arch.parseGotRevision): same
1092 (Bazaar.parseGotRevision): same
1093 (Mercurial.parseGotRevision): same
1095 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
1096 keep a record of all non-stdout/stderr/header/rc status updates,
1097 for the benefit of RemoteCommands that send other useful things,
1099 (Source.commandComplete): put any 'got_revision' status values
1100 into a build property of the same name
1103 * buildbot/process/step_twisted.py (Trial): update to deal with
1104 new ShellCommand refactoring
1106 * docs/buildbot.texinfo (Build Properties): document new feature
1107 that allows BuildSteps to get/set Build-wide properties like which
1108 revision was requested and/or checked out.
1110 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
1111 * buildbot/status/builder.py (BuildStatus.getProperty): implement
1112 it. Note that this bumps the persistenceVersion of the saved Build
1113 object, so add the necessary upgrade-old-version logic to include
1114 an empty properties dict.
1116 * buildbot/process/base.py (Build.setProperty): implement it
1117 (Build.getProperty): same
1118 (Build.startBuild): change build startup to set 'branch',
1119 'revision', and 'slavename' properties at the right time
1121 * buildbot/process/step.py (BuildStep.__init__): change setup to
1122 require 'build' argument in a better way
1123 (LoggingBuildStep): split ShellCommand into two pieces, for better
1124 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
1125 a single RemoteCommand that sends stdout/stderr status text. It
1126 also provides the usual commandComplete / createSummary /
1127 evaluateCommand / getText methods to be overridden...
1128 (ShellCommand): .. whereas ShellCommand is specifically for
1129 running RemoteShellCommands. Other shell-like BuildSteps (like
1130 Source) can inherit from LoggingBuildStep instead of ShellCommand
1131 (WithProperties): marker class to do build-property interpolation
1132 (Source): inherit from LoggingBuildStep instead of ShellCommand
1135 * buildbot/test/test_properties.py: test new functionality
1137 2006-04-21 Brian Warner <warner@lothar.com>
1139 * buildbot/test/test_vc.py: rename testBranch to
1140 testCheckoutBranch to keep the tests in about the right
1143 2006-04-18 Brian Warner <warner@lothar.com>
1145 * docs/buildbot.texinfo (PBListener): improve cross-references
1146 between PBListener and 'buildbot statusgui', thanks to John Pye
1149 2006-04-17 Brian Warner <warner@lothar.com>
1151 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
1152 running under Twisted-1.3.0, otherwise skipped tests are reported
1155 * all: use isinstance() instead of 'type(x) is foo', suggested by
1158 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
1159 oops, fix a brain-fade from the other week, when making the
1160 addStep changes. I changed all the __init__ upcalls to use the
1161 wrong superclass name.
1162 (FullTwistedBuildFactory.__init__): same
1163 (TwistedDebsBuildFactory.__init__): same
1164 (TwistedReactorsBuildFactory.__init__): same
1165 (TwistedBuild.isFileImportant): use .startswith for clarity,
1166 thanks to Neal Norwitz for the suggestions.
1168 * contrib/viewcvspoll.py: script to poll a viewcvs database for
1169 changes, then deliver them over PB to a remote buildmaster.
1171 * contrib/svnpoller.py: added script by John Pye to poll a remote
1172 SVN repository (by running 'svn log') from a cronjob, and run
1173 'buildbot sendchange' to deliver the changes to a remote
1175 * contrib/svn_watcher.py: added script by Niklaus Giger (a
1176 modification of svnpoller.py), same purpose, but this one loops
1177 internally (rather than expecting to run from a cronjob) and works
1179 * contrib/README.txt: same
1181 2006-04-11 Brian Warner <warner@lothar.com>
1183 * all: fix a number of incorrect names and missing imports, thanks
1184 to Anthony Baxter for the patch.
1185 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
1186 remove unused buggy method.
1187 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
1188 comes from shutil, not "shutils"
1189 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
1190 (Arch.checkSlaveVersion): same
1191 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
1193 * buildbot/process/step_twisted2.py: add some missing imports
1194 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
1195 this code used to live in twisted.internet.defer
1197 2006-04-10 Brian Warner <warner@lothar.com>
1199 * buildbot/process/step.py (Mercurial): add Mercurial support
1200 * buildbot/slave/commands.py (Mercurial): same
1201 * buildbot/scripts/tryclient.py (MercurialExtractor): same
1202 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
1203 not yet tested, but 'try' support *is* covered
1204 * docs/buildbot.texinfo (Mercurial): document it
1206 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
1207 some debugging messages (turned off)
1208 * buildbot/test/test_vc.py: improve debug messages
1210 2006-04-07 Brian Warner <warner@lothar.com>
1212 * buildbot/test/test_vc.py (which): define our own which() in case
1213 we can't import twisted.python.procutils, because procutils doesn't
1214 exist in Twisted-1.3
1216 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
1217 of SlaveLocks for performance tests
1219 * docs/examples/twisted_master.cfg: update to match current usage
1221 * buildbot/changes/p4poller.py (P4Source): add new arguments:
1222 password, p4 binary, pollinterval, maximum history to check.
1223 Patch from an anonymous sf.net contributor, SF#1219384.
1224 * buildbot/process/step.py (P4Sync.__init__): add username,
1225 password, and client arguments.
1226 * buildbot/slave/commands.py (P4Sync): same
1228 2006-04-05 Brian Warner <warner@lothar.com>
1230 * buildbot/process/factory.py (BuildFactory.addStep): new method
1231 to add steps to a BuildFactory. Use it instead of f.steps.append,
1232 and you can probably avoid using the s() convenience function.
1233 Patch from Neal Norwitz, sf.net #1412605.
1234 (other): update all factories to use addStep
1235 * buildbot/process/process_twisted.py: update all factories to use
1238 2006-04-03 Brian Warner <warner@lothar.com>
1240 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
1241 work under windows too. Adapted from a patch by Niklaus Giger,
1242 addresses SF#1463399.
1244 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
1245 spawned commands emit parseable results in english and not some
1246 other language. Patch from Niklaus Giger, SF#1463395.
1248 * README (INSTALLATION): discourage users from running unit tests on
1249 a "network drive", patch from Niklaus Giger, SF#1463394.
1251 2006-03-22 Brian Warner <warner@lothar.com>
1253 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
1254 function to turn a repository-relative pathname into a (branch,
1255 branch-relative-filename) tuple. Change this function to handle
1256 the branch naming policy used by your Subversion repository.
1257 Thanks to AllMyData.com for sponsoring this work.
1259 2006-03-16 Brian Warner <warner@lothar.com>
1261 * buildbot/scripts/sample.cfg: add python-mode declaration for
1262 vim. Thanks to John Pye for the patch.
1264 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
1265 command line, mention the importance of running 'crontab' as the
1266 buildmaster/buildslave user. Thanks to John Pye for the catch.
1268 2006-03-13 Brian Warner <warner@lothar.com>
1270 * buildbot/status/words.py (IRC): add an optional password=
1271 argument, which will be sent to Nickserv in an IDENTIFY message at
1272 login, to claim the nickname. freenode requires this before the
1273 bot can sent (or reply to) private messages. Thanks to Clement
1274 Stenac for the patch.
1275 * docs/buildbot.texinfo (IRC Bot): document it
1277 * buildbot/status/builder.py (LogFile.merge): don't write chunks
1278 larger than chunkSize. Fixes SF#1349253.
1279 * buildbot/test/test_status.py (Log.testLargeSummary): test it
1280 (Log.testConsumer): update to match new internal chunking behavior
1282 2006-03-12 Brian Warner <warner@lothar.com>
1284 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
1286 * buildbot/test/test_maildir.py (MaildirTest): rename the
1287 'timeout' method, as it collides with trial's internals
1289 * buildbot/scripts/runner.py: add 'buildbot restart' command
1290 (stop): don't sys.exit() out of here, otherwise restart can't work
1291 * docs/buildbot.texinfo (Shutdown): document it
1293 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
1294 * buildbot/status/html.py (Waterfall.__init__): same
1295 * buildbot/process/builder.py (Builder.startBuild): same
1296 * buildbot/process/base.py (BuildRequest): same
1297 * buildbot/sourcestamp.py (SourceStamp): same
1298 * buildbot/scheduler.py (Nightly): same
1300 * buildbot/__init__.py (version): bump to 0.7.2+ while between
1302 * docs/buildbot.texinfo: same
1304 2006-02-17 Brian Warner <warner@lothar.com>
1306 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
1307 * docs/buildbot.texinfo: set version number to match
1308 * NEWS: update for 0.7.2
1310 2006-02-16 Brian Warner <warner@lothar.com>
1312 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
1314 2006-02-09 Brian Warner <warner@lothar.com>
1316 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
1317 add text to explain per-build branch parameters
1318 * NEWS: mention --umask
1320 2006-02-08 Brian Warner <warner@lothar.com>
1322 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
1324 (SlaveOptions.optParameters): add --umask, to make it possible to
1325 make buildslave-generated files (including build products) be
1328 * buildbot/slave/bot.py (BuildSlave.startService): same
1330 2006-01-23 Brian Warner <warner@lothar.com>
1332 * buildbot/status/builder.py: urllib.quote() all URLs that include
1333 Builder names, so that builders can include characters like '/'
1334 and ' ' without completely breaking the resulting HTML. Thanks to
1335 Kevin Turner for the patch.
1336 * buildbot/status/html.py: same
1337 * buildbot/test/test_web.py (GetURL.testBuild): match changes
1339 * NEWS: update in preparation for upcoming release
1341 2006-01-18 Brian Warner <warner@lothar.com>
1343 * docs/examples/twisted_master.cfg: update to match the Twisted
1344 buildbot: remove python2.2, switch to exarkun's buildslaves,
1345 disable the .deb builder until we figure out how to build twisted
1346 .debs from SVN, add some ktrace debugging to the OS-X build
1347 process and remove the qt build, remove threadless builders,
1348 change freebsd builder to use landonf's buildslave.
1350 2006-01-12 Brian Warner <warner@lothar.com>
1352 * buildbot/master.py (Manhole.__init__): let port= be a strports
1353 specification string, but handle a regular int for backwards
1354 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
1355 used in master.cfg to limit connections to just the local host.
1356 (BuildMaster.loadConfig): same for c['slavePortnum']
1357 * buildbot/scheduler.py (Try_Userpass.__init__): same
1358 * buildbot/status/client.py (PBListener.__init__): same
1359 * buildbot/status/html.py (Waterfall.__init__): same, for both
1360 http_port and distrib_port. Include backwards-compatibility checks
1361 so distrib_port can be a filename string and still mean unix:/foo
1362 * docs/buildbot.texinfo (Setting the slaveport): document it
1363 (Debug options): same
1364 (HTML Waterfall): same
1367 * buildbot/test/test_config.py (ConfigTest): test it
1369 * buildbot/master.py (BuildMaster.loadConfig): wait for the
1370 slaveport's disownServiceParent deferred to fire before opening
1371 the new one. Fixes an annoying bug in the unit tests.
1373 2006-01-03 Brian Warner <warner@lothar.com>
1375 * buildbot/master.py (BuildMaster): remove the .schedulers
1376 attribute, replacing it with an allSchedulers() method that looks
1377 for all IService children that implement IScheduler. Having only
1378 one parent/child relationship means fewer opportunities for bugs.
1379 (BuildMaster.allSchedulers): new method
1380 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
1381 also fix ugly bug that caused any config-file reload to
1382 half-forget about the earlier Schedulers, causing an exception
1383 when a Change arrived and was handed to a half-connected
1384 Scheduler. The exception was in scheduler.py line 54ish:
1385 self.parent.submitBuildSet(bs)
1386 exceptions.AttributeError: 'NoneType' object has no attribute
1388 (BuildMaster.addChange): update to use allSchedulers()
1390 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
1391 to work properly with twisted-1.3.0, where you must explicitly
1392 include the __implements__ from parent classes
1393 (BaseScheduler.__repr__): make it easier to distinguish distinct
1395 (BaseUpstreamScheduler.__implements__): same
1397 * buildbot/status/builder.py (Status.getSchedulers): update to
1399 * buildbot/test/test_run.py (Run.testMaster): same
1400 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
1401 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
1402 make sure Scheduler instances are left alone when an identical
1403 config file is reloaded
1404 (ConfigElements.testSchedulers): make sure Schedulers are properly
1407 * Makefile (TRIALARGS): my local default Twisted version is now
1408 2.1.0, update the trial arguments accordingly
1410 2005-12-22 Brian Warner <warner@lothar.com>
1412 * docs/examples/twisted_master.cfg: merge changes from pyr: add
1415 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
1416 addChange in the parent class, although I suspect this should be
1417 fixed better in the future.
1419 2005-11-26 Brian Warner <warner@lothar.com>
1421 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
1422 explode when branch==None, thanks to Kevin Turner for the catch
1423 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
1426 * buildbot/__init__.py (version): bump to 0.7.1+ while between
1428 * docs/buildbot.texinfo: same
1430 2005-11-26 Brian Warner <warner@lothar.com>
1432 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
1433 * docs/buildbot.texinfo: set version number to match
1435 2005-11-26 Brian Warner <warner@lothar.com>
1437 * NEWS: update for 0.7.1
1439 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
1440 sure that unsubscribe works even if we never sent an ETA update.
1441 Also, don't explode on duplicate unsubscribe.
1442 (BuildStepStatus.addLog): make the convenience "return self"-added
1443 watcher automatically unsubscribe when the Step finishes.
1444 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
1445 (BuildStatus.stepStarted): same auto-unsubscribe
1446 (BuilderStatus.buildStarted): same auto-unsubscribe
1448 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
1450 (IStatusReceiver.stepStarted): same
1451 (IStatusReceiver.logStarted): same
1453 * buildbot/test/test_run.py (Status): move the Status test..
1454 * buildbot/test/test_status.py (Subscription): .. to here
1456 2005-11-25 Brian Warner <warner@lothar.com>
1458 * NEWS: more updates
1460 * buildbot/locks.py: fix the problem in which loading a master.cfg
1461 file that changes some Builders (but not all of them) can result
1462 in having multiple copies of the same Lock. Now, the real Locks
1463 are kept in a table inside the BotMaster, and the Builders/Steps
1464 use "LockIDs", which are still instances of MasterLock and
1465 SlaveLock. The real Locks are instances of the new RealMasterLock
1466 and RealSlaveLock classes.
1467 * buildbot/master.py (BotMaster.getLockByID): new method to
1468 convert LockIDs into real Locks.
1469 * buildbot/process/base.py (Build.startBuild): convert LockIDs
1470 into real Locks before building
1471 * buildbot/process/step.py (BuildStep.startStep): same
1472 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
1473 exercises the problem
1476 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
1477 what Schedulers are available
1479 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
1480 work by Dobes Vandermeer and hacked mercilessly by me. This offers
1481 'cron'-style build scheduling at certain times of day, week,
1483 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
1485 * buildbot/scheduler.py (Scheduler): change fileIsImportant
1486 handling: treat self.fileIsImportant more as an attribute that
1487 contains a callable than as a method. If the attribute is None,
1488 don't call it and assume all filenames are important. It is still
1489 possible to provide a fileIsImportant method in a subclass,
1491 (AnyBranchScheduler): handle fileIsImportant=None, previously it
1493 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
1494 test using AnyBranchScheduler with fileIsImportant=None
1496 2005-11-24 Brian Warner <warner@lothar.com>
1498 * buildbot/test/test_config.py (StartService): don't claim a fixed
1499 port number, instead set slavePort=0 on the first pass, figure out
1500 what port was allocated, then switch to a config file that uses
1503 * buildbot/master.py (BuildMaster.loadConfig): close the old
1504 slaveport before opening the new one, because unit tests might
1505 replace slavePort=0 with the same allocated portnumber, and if we
1506 don't wait for the old port to close first, we get a "port already
1507 in use" error. There is a tiny race condition here, but the only
1508 threat is from other programs that bind (statically) to the same
1509 port number we happened to be allocated, and only if those
1510 programs use SO_REUSEADDR, and only if they get control in between
1513 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
1515 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
1516 deleted ChangeSources before adding any new ones
1517 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
1518 compare_attrs, to make sure that a config-file reload does not
1519 unnecessarily replace an unmodified ChangeSource instance
1520 * buildbot/test/test_config.py (ConfigTest.testSources): update
1522 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
1523 mean "don't build anything", and add a warning if it gets used
1524 because it isn't actually useful.
1526 * contrib/svn_buildbot.py: update example usage to match the port
1527 number that gets used by the PBChangeSource
1528 * buildbot/scripts/sample.cfg: add example of PBChangeSource
1530 2005-11-22 Brian Warner <warner@lothar.com>
1532 * NEWS: start collecting items for next release
1534 * buildbot/process/step.py (SVN.computeSourceRevision): assume
1535 revisions are strings
1536 (P4Sync.computeSourceRevision): same
1538 * buildbot/status/html.py (StatusResourceBuild.body): add a link
1539 to the Buildbot's overall status page
1540 (StatusResourceBuilder.body): same
1542 2005-11-15 Brian Warner <warner@lothar.com>
1544 * buildbot/master.py (BuildMaster.loadConfig): serialize the
1545 config-file loading, specifically to make sure old StatusTargets
1546 are finished shutting down before new ones start up (thus
1547 resolving a bug in which changing the Waterfall object would fail
1548 because both new and old instances were claiming the same
1549 listening port). Also load new Schedulers after all the new
1550 Builders are set up, in case they fire off a new build right away.
1551 * buildbot/test/test_config.py (StartService): test it
1553 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
1554 the branch name to the mail body
1556 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
1557 Without it, a config-file reload fails to update an existing
1559 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
1560 username/passwd to compare_attrs, for the same reason
1561 * buildbot/status/html.py (Waterfall): add favicon to
1562 compare_attrs, same reason
1564 2005-11-05 Brian Warner <warner@lothar.com>
1566 * buildbot/scripts/tryclient.py (createJobfile): stringify the
1567 baserev before stuffing it in the jobfile. This resolves problems
1568 under SVN (and probably Arch) where revisions are expressed as
1569 numbers. I'm inclined to use string-based revisions everywhere in
1570 the future, but this fix should be safe for now. Thanks to Steven
1571 Walter for the patch.
1573 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
1574 binary mode when opening pickle files, to make windows work
1575 better. Thanks to Dobes Vandermeer for the catch.
1576 * buildbot/status/builder.py (BuildStatus.saveYourself): same
1577 (BuilderStatus.getBuildByNumber): same
1578 (Status.builderAdded): same
1579 * buildbot/master.py (BuildMaster.loadChanges): same
1581 * buildbot/util.py (Swappable): delete unused leftover code
1583 * buildbot/process/step.py (SVN): when building on a non-default
1584 branch, add the word "[branch]" to the VC step's description, so
1585 it is obvious that we're not building the usual stuff. Likewise,
1586 when we are building a specific revision, add the text "rNNN" to
1587 indicate what that revision number is. Thanks to Brad Hards and
1588 Nathaniel Smith for the suggestion.
1589 (Darcs.startVC): same
1590 (Arch.startVC): same
1591 (Bazaar.startVC): same
1593 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
1594 typo, caught by Mark Dillavou, closes SF#1216636.
1596 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
1597 about a test to add some day
1599 * docs/examples/twisted_master.cfg: update: bot1 can now handle
1600 the 'full-2.3' build, and the 'reactors' build is now run under
1601 python-2.4 because the buildslave no longer has gtk/etc bindings
1602 for earlier versions.
1604 2005-11-03 Brian Warner <warner@lothar.com>
1606 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
1607 method, takes an IBuildStatus and rebuilds it. It might make more
1608 sense to add this to IBuildControl instead, but that instance goes
1609 away completely once the build has finished, and resubmitting
1610 builds can take place weeks later.
1611 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
1612 * buildbot/status/html.py (StatusResourceBuild): also stash an
1613 IBuilderControl so we can use resubmitBuild.
1614 (StatusResourceBuild.body): render "resubmit" button if we can.
1615 Also add hrefs for each BuildStep
1616 (StatusResourceBuild.rebuild): add action for "resubmit" button
1617 (StatusResourceBuilder.getChild): give it an IBuilderControl
1619 * buildbot/status/builder.py (Status.getURLForThing): change the
1620 URL for BuildSteps to have a "step-" prefix, so the magic URLs
1621 that live as targets of buttons like "stop" and "rebuild" can't
1623 * buildbot/status/builder.py (Status.getURLForThing): same
1624 * buildbot/status/html.py (StatusResourceBuild.getChild): same
1625 (StepBox.getBox): same
1626 * buildbot/test/test_web.py (GetURL): same
1629 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
1630 exclusivity checks after Source.__init__ upcall, so misspelled
1631 arguments will be reported more usefully
1632 (Darcs.__init__): same
1634 2005-10-29 Brian Warner <warner@lothar.com>
1636 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
1637 builder. Move the Try scheduler off to a separate port.
1639 2005-10-27 Brian Warner <warner@lothar.com>
1641 * buildbot/clients/gtkPanes.py
1642 (TwoRowClient.remote_builderRemoved): disappearing Builders used
1643 to cause the app to crash, now they don't.
1645 * buildbot/clients/debug.py: display the buildmaster's location
1646 in the window's title bar
1648 2005-10-26 Brian Warner <warner@lothar.com>
1650 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
1651 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
1652 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
1654 * buildbot/status/html.py (td): put a single non-breaking space
1655 inside otherwise empty <td> elements, as a workaround for buggy
1656 browsers which would optimize them away (along with any associated
1657 styles, like the kind that create the waterfall grid borders).
1658 Patch from Frerich Raabe.
1660 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
1661 argv-list as an argument, defaulting to ["-to"], which is
1662 appropriate for the Trial that comes with Twisted-2.1.0 and
1663 earlier. The Trial in current Twisted SVN wants
1664 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
1665 defaults to an empty list.
1666 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
1667 match it, now that trialMode= is a list instead of a single string
1669 * buildbot/__init__.py (version): bump to 0.7.0+ while between
1671 * docs/buildbot.texinfo: same
1673 2005-10-24 Brian Warner <warner@lothar.com>
1675 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
1676 * docs/buildbot.texinfo: set version number to match
1678 2005-10-24 Brian Warner <warner@lothar.com>
1680 * README: update for 0.7.0
1682 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
1684 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
1685 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
1686 send the branch= argument unless the user really provided one, to
1687 retain compatibility with older buildmasters that don't accept
1689 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
1692 * docs/buildbot.texinfo: update lots of stuff
1694 * buildbot/scripts/runner.py (sendchange): add a --branch argument
1695 to the 'buildbot sendchange' command
1696 * buildbot/clients/sendchange.py (Sender.send): same
1697 * buildbot/changes/pb.py (ChangePerspective): same
1698 * buildbot/test/test_changes.py (Sender.testSender): test it
1700 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
1701 'default_branch' argument names to 'baseURL' and 'defaultBranch',
1702 for consistency with other BuildStep arguments that use camelCase.
1703 Well, at least more of them use camelCase (like flunkOnWarnings)
1704 than don't.. I wish I'd picked one style and stuck with it
1705 earlier. Annoying, but it's best done before the release, since
1706 these arguments didn't exist at all in 0.6.6 .
1708 * buildbot/test/test_vc.py (SVN.testCheckout): same
1709 (Darcs.testPatch): same
1710 * docs/buildbot.texinfo (SVN): document the change
1711 (Darcs): same, add some build-on-branch docs
1712 * docs/examples/twisted_master.cfg: match change
1714 * buildbot/process/step.py (BuildStep): rename
1715 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
1716 how it is normally used.
1717 * buildbot/test/test_steps.py (Version.checkCompare): same
1719 * buildbot/process/step.py (CVS.startVC): refuse to build
1720 update/copy -style builds on a non-default branch with an old
1721 buildslave (<=0.6.6) that doesn't know how to do it properly. The
1722 concern is that it will do a VC 'update' in an existing tree when
1723 it is supposed to be switching branches (and therefore clobbering
1724 the tree to do a full checkout), thus building the wrong source.
1725 This used to be a warning, but I think the confusion it is likely
1726 to cause warrants making it an error.
1727 (SVN.startVC): same, also make mode=export on old slaves an error
1728 (Darcs.startVC): same
1729 (Git.startVC): improve error message for non-Git-enabled slaves
1730 (Arch.checkSlaveVersion): same. continue to emit a warning when a
1731 specific revision is built on a slave that doesn't pay attention
1732 to args['revision'], because for slowly-changing trees it will
1733 probably do the right thing, and because we have no way to tell
1734 whether we're asking it to build the most recent version or not.
1735 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
1737 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
1738 that 'master' is in host:portnum format, to catch errors sooner
1740 2005-10-23 Brian Warner <warner@lothar.com>
1742 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
1743 when creating the list of warning messages, include the line
1744 immediately after each WARNING: line, since that's usually where
1745 the file and line number wind up.
1747 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
1752 2005-10-22 Brian Warner <warner@lothar.com>
1754 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
1755 patch from Brad Hards
1756 * buildbot/status/classic.css: same
1757 * buildbot/test/test_web.py (Waterfall): match changes
1759 * buildbot/test/test_steps.py (BuildStep.setUp): set
1760 nextBuildNumber so the test passes
1761 * buildbot/test/test_status.py (MyBuilder): same
1763 * buildbot/status/html.py (StatusResourceBuild.body): revision
1764 might be numeric, so stringify it before html-escapifying it
1765 (CurrentBox.getBox): add a "waiting" state, and show a countdown
1766 timer for the upcoming build
1767 * buildbot/status/classic.css: add background-color attributes for
1768 offline/waiting/building classes
1770 * buildbot/status/builder.py (BuildStatus): derive from
1771 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
1772 the default (i.e. unknown) .slavename to "???" instead of None,
1773 since even unknown slavenames need to be printed eventually.
1774 (BuilderStatus): also derive from styles.Versioned . More
1775 importantly, determine .nextBuildNumber at creation/unpickling
1776 time by scanning the directory of saved BuildStatus instances and
1777 choosing one larger than the highest-numbered one found. This
1778 should fix the problem where random errors during upgrades cause
1779 the buildbot to forget about earlier builds. .nextBuildNumber is
1780 no longer stored in the pickle.
1781 (Status.builderAdded): if we can't unpickle the BuilderStatus,
1782 at least log the error. Also call Builder.determineNextBuildNumber
1783 once the basedir is set.
1785 * buildbot/master.py (BuildMaster.loadChanges): do
1786 styles.doUpgrade afterwards, in case I decide to make Changes
1787 derived from styles.Versioned some day and forget to make this
1791 * buildbot/test/test_runner.py (Options.testForceOptions): skip
1792 when running under older pythons (<2.3) in which the shlex module
1793 doesn't have a 'split' function.
1795 * buildbot/process/step.py (ShellCommand.start): make
1796 errorMessages= be a list of strings to stuff in the log before the
1797 command actually starts. This makes it easier to flag multiple
1798 warning messages, e.g. when the Source steps have to deal with an
1800 (CVS.startVC): handle slaves that don't handle multiple branches
1801 by switching into 'clobber' mode
1802 (SVN.startVC): same. Also reject branches without base_url
1803 (Darcs.startVC): same. Also reject revision= in older slaves
1804 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
1805 (Bazaar.startVC): same, and test for baz separately than for arch
1807 * buildbot/slave/commands.py (cvs_ver): document new features
1809 * buildbot/process/step.py (BuildStep.slaveVersion): document it
1810 (BuildStep.slaveVersionNewEnough): more useful utility method
1811 * buildbot/test/test_steps.py (Version): start testing it
1813 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
1814 the 'force' command requires python2.3, for the shlex.split method
1816 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
1817 since we don't use it anymore. The Twisted buildbot uses a
1820 2005-10-21 Brian Warner <warner@lothar.com>
1822 * buildbot/process/process_twisted.py: rework all BuildFactory
1823 classes to take a 'source' step as an argument, instead of
1824 building up the SVN instance in the factory.
1825 * docs/examples/twisted_master.cfg: enable build-on-branch by
1826 providing a base_url and default_branch
1828 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
1829 control over --branch and --revision, not that they are always
1831 * buildbot/status/html.py (StatusResourceBuilder.force): same
1832 (StatusResourceBuild.body): display SourceStamp components
1834 * buildbot/scripts/runner.py (ForceOptions): option parser for the
1835 IRC 'force' command, so it can be shared with an eventual
1836 command-line-tool 'buildbot force' mode.
1837 * buildbot/test/test_runner.py (Options.testForceOptions): test it
1839 2005-10-20 Brian Warner <warner@lothar.com>
1841 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
1843 * docs/examples/twisted_master.cfg: update to use Schedulers
1845 * buildbot/scripts/sample.cfg: update with Schedulers
1847 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
1848 method specifically for use by HTML "force build" button and the
1849 IRC "force" command. Raises an immediate error if there are no
1851 (IBuilderControl.requestBuild): make this just submit a build, not
1852 try to check for existing slaves or set up any when-finished
1853 Deferreds or anything.
1854 * buildbot/process/builder.py (BuilderControl): same
1855 * buildbot/status/html.py (StatusResourceBuilder.force): same
1856 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
1857 * buildbot/test/test_slaves.py: same
1858 * buildbot/test/test_web.py: same
1860 2005-10-19 Brian Warner <warner@lothar.com>
1862 * docs/examples/twisted_master.cfg: re-sync with reality: bring
1863 back python2.2 tests, turn off OS-X threadedselect-reactor tests
1865 2005-10-18 Brian Warner <warner@lothar.com>
1867 * buildbot/status/html.py: provide 'status' argument to most
1868 StatusResourceFOO objects
1869 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
1870 and Logfiles" section to make the Build page into a more-or-less
1871 comprehensive source of status information about the build
1873 * buildbot/status/mail.py (MailNotifier): include the Build's URL
1874 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
1876 2005-10-17 Brian Warner <warner@lothar.com>
1878 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
1879 arguments to accomodate Twisted >=2.1.0 . I will have to figure
1880 out what to do about other projects: the correct options for
1881 recent Twisteds will not work for older ones.
1883 2005-10-15 Brian Warner <warner@lothar.com>
1885 * buildbot/status/builder.py (Status.getURLForThing): add method
1886 to provide a URL for arbitrary IStatusFoo objects. The idea is to
1887 use this in email/IRC status clients to make them more useful, by
1888 providing the end user with hints on where to learn more about the
1889 object being reported on.
1890 * buildbot/test/test_web.py (GetURL): tests for it
1892 2005-10-14 Brian Warner <warner@lothar.com>
1894 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
1895 fix bug resulting from deferredResult changes
1897 2005-10-13 Brian Warner <warner@lothar.com>
1899 * buildbot/test/test_changes.py: remove use of deferredResult
1900 * buildbot/test/test_config.py: same
1901 * buildbot/test/test_control.py: same
1902 * buildbot/test/test_status.py: same
1903 * buildbot/test/test_vc.py: this is the only remaining use, since
1904 it gets used at module level. This needs to be replaced by some
1905 sort of class-level run-once routine.
1907 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
1909 * lots: implement multiple slaves per Builder, which means multiple
1910 current builds per Builder. Some highlights:
1911 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
1912 of (state,currentBuilds) instead of (state,currentBuild)
1913 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
1914 (IBuildStatus.getSlavename): new method, so you can tell which
1915 slave got used. This only gets set when the build completes.
1916 (IBuildRequestStatus.getBuilds): new method
1918 * buildbot/process/builder.py (SlaveBuilder): add a .state
1919 attribute to track things like ATTACHING and IDLE and BUILDING,
1921 (Builder): .. the .slaves attribute here, which has been turned
1922 into a simple list of available slaves. Added a separate
1923 attaching_slaves list to track ones that are not yet ready for
1925 (Builder.fireTestEvent): put off the test-event callback for a
1926 reactor turn, to make tests a bit more consistent.
1927 (Ping): cleaned up the slaveping a bit, now it disconnects if the
1928 ping fails due to an exception. This needs work, I'm worried that
1929 a code error could lead to a constantly re-connecting slave.
1930 Especially since I'm trying to move to a distinct remote_ping
1931 method, separate from the remote_print that we currently use.
1932 (BuilderControl.requestBuild): return a convenience Deferred that
1933 provides an IBuildStatus when the build finishes.
1934 (BuilderControl.ping): ping all connected slaves, only return True
1935 if they all respond.
1937 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
1938 reconnect when we shut down.
1940 * buildbot/status/builder.py: implement new methods, convert
1941 one-build-at-a-time methods to handle multiple builds
1942 * buildbot/status/*.py: do the same in all default status targets
1943 * buildbot/status/html.py: report the build's slavename in the
1944 per-Build page, report all buildslaves on the per-Builder page
1946 * buildbot/test/test_run.py: update/create tests
1947 * buildbot/test/test_slaves.py: same
1948 * buildbot/test/test_scheduler.py: remove stale test
1950 * docs/buildbot.texinfo: document the new builder-specification
1951 'slavenames' parameter
1953 2005-10-12 Brian Warner <warner@lothar.com>
1955 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
1956 report failure correctly, causing Dependent builds to run when
1957 they shouldn't have.
1958 * buildbot/status/builder.py (BuildSetStatus): same
1959 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
1960 (Set.testSuccess): test the both-pass case too
1961 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
1962 fix this test: it was ending too early, masking the failure before
1963 (Logger): specialized StatusReceiver to make sure the dependent
1964 builds aren't even started, much less completed.
1966 2005-10-07 Brian Warner <warner@lothar.com>
1968 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
1969 bot.SlaveBuilder being disowned in the middle of a build
1971 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
1972 this inherit from StatusReceiver. Also upcall in __init__. This
1973 fixes the embarrasing crash when the new buildSetSubmitted method
1974 is invoked and Waterfall/etc don't implement their own.
1975 * buildbot/test/test_run.py: add a TODO note about a test to catch
1976 just this sort of thing.
1978 * buildbot/process/builder.py (Builder.attached): remove the
1979 already-attached warning, this situation is normal. Add some
1980 comments explaining it.
1982 2005-10-02 Brian Warner <warner@lothar.com>
1984 * buildbot/changes/maildir.py (Maildir.start): Tolerate
1985 OverflowError when setting up dnotify, because some 64-bit systems
1986 have problems with signed-vs-unsigned constants and trip up on the
1987 DN_MULTISHOT flag. Patch from Brad Hards.
1989 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
1991 * buildbot/process/step.py (BuildStep, ShellCommand): Add
1992 progressMetrics, description, descriptionDone to the 'parms' list,
1993 and make use the 'parms' list from the implementation class
1994 instead of only BuildStep to initialize the parameters. This
1995 allows buildbot.process.factory.s() to initialize all the parms,
1996 not just those defined in directly by BuildStep.
1998 2005-09-03 Brian Warner <warner@lothar.com>
2000 * NEWS: start adding items for the next release
2002 * docs/examples/twisted_master.cfg: (sync with reality) turn off
2003 python2.2 tests, change 'Quick' builder to only use python2.3
2005 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
2007 * buildbot/status/html.py (StatusResourceBuilder.body): only show
2008 the "Ping Builder" button if the build control is available; the
2009 user sees an exception otherwise
2011 * docs/buildbot.texinfo (PBChangeSource): fix a typo
2013 2005-09-01 Brian Warner <warner@lothar.com>
2015 * buildbot/interfaces.py (IBuilderStatus.getState): update
2016 signature, point out that 'build' can be None
2017 (IBuildStatus.getETA): point out ETA can be none
2019 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
2021 * buildbot/status/words.py (IrcStatusBot.emit_status): same
2023 2005-08-31 Brian Warner <warner@lothar.com>
2025 * buildbot/status/base.py (StatusReceiver.builderChangedState):
2026 update to match correct signature: removed 'eta' argument
2027 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
2029 2005-08-30 Brian Warner <warner@lothar.com>
2031 * buildbot/status/builder.py (LogFile): remove the assertion that
2032 blows up when you try to overwrite an existing logfile, instead
2033 just emit a warning. This case gets hit when the buildmaster is
2034 killed and doesn't get a chance to write out the serialized
2035 BuilderStatus object, so the .nextBuildNumber attribute gets out
2038 * buildbot/scripts/runner.py (sendchange): add --revision_file to
2039 the 'buildbot sendchange' arguments, for the Darcs context file
2040 * docs/buildbot.texinfo (sendchange): document it
2042 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
2043 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
2044 (IStatus.getSchedulers): new method
2045 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
2046 (Status.getSchedulers): implement
2047 * buildbot/process/builder.py (Builder): maintain
2048 BuilderStatus.pendingBuilds
2049 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
2050 (TryBase.addChange): Try schedulers should ignore Changes
2052 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
2053 for 'try' on CVS/SVN
2054 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
2056 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
2057 report status properly.
2058 (Try.createJob): implement unique buildset IDs
2060 * buildbot/status/client.py (StatusClientPerspective): add a
2061 perspective_getBuildSets method for the benefit of jobdir-style
2063 * docs/buildbot.texinfo (try): more docs
2064 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
2067 2005-08-18 Brian Warner <warner@lothar.com>
2069 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
2070 actually work. It's functional but still kind of clunky. Also, it
2071 only works with the pb-style.. needs to be made to work with the
2074 * buildbot/status/client.py (RemoteBuildSet): new class
2075 (RemoteBuildRequest): same
2076 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
2077 object, not the internal BuildStatus object.
2078 (RemoteBuild.remote_subscribe): new method to subscribe to builds
2079 outside of the usual buildStarted() return value.
2080 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
2082 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
2083 (Try_Userpass_Perspective.perspective_try): return a remotely
2084 usable BuildSetStatus object
2086 * buildbot/interfaces.py (IBuildStatus): remove obsolete
2087 isStarted()/waitUntilStarted()
2089 2005-08-16 Brian Warner <warner@lothar.com>
2091 * buildbot/status/builder.py: implement IBuildSetStatus and
2092 IBuildRequestStatus, wire them into place.
2093 * buildbot/buildset.py: same. Add ID, move wait-until-finished
2094 methods into the BuildSetStatus object.
2095 * buildbot/interfaces.py: same
2096 (IStatus.getBuildSets): new method to get pending BuildSets
2097 (IStatusReceiver.buildsetSubmitted): new method which hears about
2099 * buildbot/master.py (BuildMaster.submitBuildSet): same
2100 * buildbot/process/base.py (BuildRequest): same, replace
2101 waitUntilStarted with subscribe/unsubscribe
2102 * buildbot/process/builder.py (BuilderControl.forceBuild): use
2103 subscribe instead of waitUntilStarted
2104 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
2106 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
2108 * buildbot/test/test_buildreq.py: update for new code
2109 * buildbot/test/test_control.py (Force.testRequest): same
2112 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
2113 for Darcs to not use the tempfile module, so it works under
2114 python-2.2 too. We really didn't need the full cleverness of that
2115 module, since the slave has exclusive control of its own builddir.
2117 2005-08-15 Brian Warner <warner@lothar.com>
2119 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
2120 for CVS trees. It doesn't work for non-trunk branches,
2122 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
2125 * Makefile: make it easier to test against python2.2
2127 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
2128 tearDown2, so things like Arch can unregister archives as they're
2129 shutting down. The previous subclass-override-tearDown technique
2130 resulted in a nested maybeWait() and test failures under
2133 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
2134 where we can (Arch), add a branch= argument to set the branch used
2136 (BazExtractor): extract the branch too
2137 (TlaExtractor): same
2138 * buildbot/scripts/runner.py (TryOptions): add --branch
2139 * docs/buildbot.texinfo (try): document --branch/try_branch
2141 * buildbot/slave/commands.py (Darcs): implement get-revision for
2142 Darcs, so that 'try' will work. This requires the tempfile module
2145 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
2146 of revisions, branches, and 'try' in the process.
2148 2005-08-11 Brian Warner <warner@lothar.com>
2150 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
2151 this, it got broken at some point in the last few releases
2152 * buildbot/status/words.py (IrcBuildRequest): reply was broken
2153 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
2154 specifically the removal of ETA information from the tuple
2156 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
2159 * docs/buildbot.texinfo (try): document both --builder and
2160 'try_builders' in .buildbot/options
2161 * buildbot/scripts/runner.py (TryOptions): add --builder,
2162 accumulate the values into opts['builders']
2163 * buildbot/scripts/tryclient.py (Try.__init__): set builders
2164 * buildbot/test/test_runner.py (Try): add some quick tests to make
2165 sure 'buildbot try --options' and .buildbot/options get parsed
2166 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2167 use --builder control
2169 * docs/buildbot.texinfo (try): add --port argument to PB style
2171 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
2172 actual SourceStamp. Still need to extract a branch name, somehow.
2173 (Try): finish implementing the try client side, still need a UI
2174 for specifying which builders to use
2175 (Try.getopt): factor our options/config-file reading
2176 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
2178 * buildbot/test/test_vc.py: match SourceStampExtractor change
2180 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
2181 causes the twisted log to be sent to stderr
2183 * buildbot/scheduler.py (Try_Userpass): implement the PB style
2185 2005-08-10 Brian Warner <warner@lothar.com>
2187 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
2188 style is 90% done, still missing status reporting or waiting for
2189 the buildsets to finish, and it is completely untested.
2191 * buildbot/trybuild.py: delete file, move contents to ..
2192 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
2193 * buildbot/test/test_vc.py: match the move
2195 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
2196 of the TryScheduler, no buildsetID or status-tracking support yet
2197 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
2199 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
2200 possible to set the basedir after __init__ time, so it is easier
2201 to use as a Service-child of the BuildMaster instance
2203 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
2204 that delivers messages to its Service parent instead of requiring
2205 a subclass to be useful. This turns out to be much easier to build
2208 * buildbot/scripts/tryclient.py (createJob): utility code to
2209 create jobfiles, will eventually be used by 'buildbot try'
2211 2005-08-08 Brian Warner <warner@lothar.com>
2213 * docs/buildbot.texinfo (try): add docs on the
2214 as-yet-unimplemented Try scheduler
2216 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
2217 * buildbot/test/test_scheduler.py: .. here
2218 (Scheduling.testTryJobdir): add placeholder test for 'try'
2220 * buildbot/test/test_status.py (Log.testMerge3): update to match new
2221 addEntry merging (>=chunkSize) behavior
2222 (Log.testConsumer): update to handle new callLater(0) behavior
2224 * buildbot/test/test_web.py: rearrange tests a bit, add test for
2225 both the MAX_LENGTH bugfix and the resumeProducing hang.
2227 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
2228 put off the actual resumeProducing for a moment with
2229 reactor.callLater(0). This works around a twisted-1.3.0 bug which
2230 causes large logfiles to hang midway through.
2232 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
2233 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
2234 and to improve memory usage when streaming the file out to a web
2236 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
2237 make this work cleanly
2239 2005-08-03 Brian Warner <warner@lothar.com>
2241 * buildbot/trybuild.py: new file for 'try' utilities
2242 (getSourceStamp): run in a tree, find out the baserev+patch
2243 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
2244 implemented for SVN and Darcs, still working on Arch. I don't know
2245 how to make CVS work yet.
2247 * docs/buildbot.texinfo: document the 'buildbot' command-line
2248 tool, including the not-yet-implemented 'try' feature, and the
2249 in-flux .buildbot/ options directory.
2251 2005-07-20 Brian Warner <warner@lothar.com>
2253 * buildbot/locks.py: added temporary id() numbers to Lock
2254 descriptions, to track down a not-really-sharing-the-Lock bug
2256 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
2258 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
2259 needed for python2.2 compatibility
2260 * buildbot/test/test_vc.py: python2.2 compatibility: generators
2261 are from the __future__
2263 2005-07-19 Brian Warner <warner@lothar.com>
2265 * buildbot/master.py (BuildMaster.loadConfig): give a better error
2266 message when schedulers use unknown builders
2268 * buildbot/process/builder.py (Builder.compareToSetup): make sure
2269 SlaveLock('name') and MasterLock('name') are distinct
2271 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
2272 c['schedulers'] in such a way that we can actually accept
2274 * buildbot/test/test_config.py: check it
2276 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
2277 utility method to *all* the Schedulers
2278 (Periodic.listBuilderNames): same
2280 * docs/buildbot.texinfo (Interlocks): update chapter to match
2283 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
2284 to make sure that c['sources'], c['schedulers'], and c['status']
2285 are all lists of the appropriate objects, and that the Schedulers
2286 all point to real Builders
2287 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
2288 'listBuilderNames' utility method to support this
2289 * buildbot/scheduler.py: implement the utility method
2290 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
2292 * docs/buildbot.texinfo: add some @cindex entries
2294 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
2295 if it wasn't already set: most tla commands will fail unless one
2297 (Arch.createRepository): and disable bazaar's revision cache, since
2298 they cause test failures (the multiple repositories we create all
2299 interfere with each other through the cache)
2301 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
2302 bring it properly up to date with twisted-2.0 test guidelines
2304 * buildbot/master.py (BuildMaster): remove references to old
2305 'interlock' module, this caused a bunch of post-merge test
2307 * buildbot/test/test_config.py: same
2308 * buildbot/process/base.py (Build): same
2310 * buildbot/test/test_slaves.py: stubs for new test case
2312 * buildbot/scheduler.py: add test-case-name tag
2313 * buildbot/test/test_buildreq.py: same
2315 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
2316 unnecessary init code
2317 (Bot.remote_setBuilderList): match it
2319 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
2321 * buildbot/changes/mail.py (parseSyncmail): update comment
2323 * buildbot/test/test_slavecommand.py: disable Shell tests on
2324 platforms that don't suport IReactorProcess
2326 * buildbot/status/builder.py (LogFile): remove the 't' mode from
2327 all places where we open logfiles. It causes OS-X to open the file
2328 in some weird mode that that prevents us from mixing reads and
2329 writes to the same filehandle, which we depend upon to implement
2330 _generateChunks properly. This change doesn't appear to break
2331 win32, on which "b" and "t" are treated differently but a missing
2332 flag seems to be interpreted as "t".
2334 2005-07-18 Brian Warner <warner@lothar.com>
2336 * buildbot/slave/commands.py (ShellCommand): overhaul
2337 error-handling code, to try and make timeout/interrupt work
2338 properly, and make win32 happier
2339 * buildbot/test/test_slavecommand.py: clean up, stop using
2340 reactor.iterate, add tests for timeout and interrupt
2341 * buildbot/test/sleep.py: utility for a new timeout test
2343 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
2344 code from the local-usebranches branch
2346 2005-07-17 Brian Warner <warner@lothar.com>
2348 * buildbot/process/process_twisted.py
2349 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
2350 minutes, to match the other twisted BuildFactories, and don't
2351 excuse failures in c/qt/win32 reactors any more.
2353 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
2354 'freebsd' builders, since the buildslaves have been unavailable
2357 2005-07-13 Brian Warner <warner@lothar.com>
2359 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
2360 build-on-branch feature
2362 * buildbot/process/step.py (Darcs.__init__): add base_url and
2363 default_branch arguments, just like SVN
2364 (Arch.__init__): note that the version= argument is really the
2367 * buildbot/slave/commands.py (SourceBase): keep track of the
2368 repository+branch that was used for the last checkout in
2369 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
2370 match, we clobber the directory and perform a fresh checkout
2371 rather than trying to do an in-place update. This should protect
2372 us against trying to get to branch B by doing an update in a tree
2373 obtained from branch A.
2374 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
2375 (SVN.setup): same, just the svnurl
2376 (Darcs.setup): same, just the repourl
2377 (Arch.setup): same, arch coordinates (url), version, and
2378 buildconfig. Also pull the buildconfig from the args dictionary,
2379 which we weren't doing before, so the build-config was effectively
2381 (Arch.sourcedirIsUpdateable): don't try to update when we're
2382 moving to a specific revision: arch can't go backwards, so it is
2383 safer to just clobber the tree and checkout a new one at the
2385 (Bazaar.setup): same sourcedata as Arch
2387 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
2388 use maybeWait, to work with twisted-1.3.0 and twcompat
2389 (Dependencies.testRun_Pass): same
2391 * buildbot/test/test_vc.py: rearrange, cleanup
2393 * buildbot/twcompat.py: add defer.waitForDeferred and
2394 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
2395 can work under twisted-1.3.0 .
2397 * buildbot/test/test_vc.py: rewrite. The sample repositories are
2398 now created at setUp time. This increases the runtime of the test
2399 suite considerably (from 91 seconds to 151), but it removes the
2400 need for an offline tarball, which should solve a problem I've
2401 seen where the test host has a different version of svn than the
2402 tarball build host. The new code also validates that mode=update
2403 really picks up recent commits. This approach will also make it
2404 easier to test out branches, because the code which creates the VC
2405 branches is next to the code which uses them. It will also make it
2406 possible to test some change-notification hooks, by actually
2407 performing a VC commit and watching to see the ChangeSource get
2410 2005-07-12 Brian Warner <warner@lothar.com>
2412 * docs/buildbot.texinfo (SVN): add branches example
2413 * docs/Makefile (buildbot.ps): add target for postscript manual
2415 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
2416 * buildbot/test/test_locks.py: same
2418 * buildbot/process/step.py (Darcs): comment about default branches
2420 * buildbot/master.py (BuildMaster.loadConfig): don't look for
2421 c['interlocks'] in the config file, complain if it is present.
2422 Scan all locks in c['builders'] to make sure the Locks they use
2424 * buildbot/test/test_config.py: remove old c['interlocks'] test,
2425 add some tests to check for non-uniquely-named Locks
2426 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
2427 since the unique-Lock validation code requires it now
2429 * buildbot/locks.py: fix test-case-name
2431 * buildbot/interlock.py: remove old file
2433 2005-07-11 Brian Warner <warner@lothar.com>
2435 * buildbot/test/test_interlock.py: rename to..
2436 * buildbot/test/test_locks.py: .. something shorter
2438 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
2439 versions (after 2.0.1) changed internet.TCPClient to shut down the
2440 connection in stopService. Change the code to handle this
2443 * buildbot/process/base.py (Build): handle whole-Build locks
2444 * buildbot/process/builder.py (Builder.compareToSetup): same
2445 * buildbot/test/test_interlock.py: make tests work
2447 * buildbot/process/step.py (BuildStep.startStep): complain if a
2448 Step tries to claim a lock that's owned by its own Build
2449 (BuildStep.releaseLocks): typo
2451 * buildbot/locks.py (MasterLock): use ComparableMixin so config
2452 file reloads don't replace unchanged Builders
2454 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
2455 rewrite to cover new Locks instead of old c['interlocks']
2456 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
2460 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
2461 start the master and connect the buildslave
2463 * buildbot/process/step.py (FailingDummy.done): finish with a
2464 FAILURE status rather than raising an exception
2466 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
2467 stringify a BuildRequest.reason that is None
2469 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
2471 * buildbot/status/builder.py (BuildSetStatus): implement enough to
2472 allow scheduler.Dependent to work
2473 * buildbot/buildset.py (BuildSet): set .reason and .results
2475 * buildbot/test/test_interlock.py (Locks.setUp): connect both
2476 slaves, to make the test stop hanging. It still fails, of course,
2477 because I haven't even started to implement Locks.
2479 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
2481 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
2482 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
2483 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
2484 (Dependent): new class for downstream build dependencies
2485 * buildbot/test/test_dependencies.py: tests (still failing)
2487 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
2489 2005-07-07 Brian Warner <warner@lothar.com>
2491 * buildbot/test/runutils.py (RunMixin): factored this class out..
2492 * buildbot/test/test_run.py: .. from here
2493 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
2494 added new buildbot.locks tests (which all hang right now)
2495 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
2496 * buildbot/process/step.py: claim/release per-BuildStep locks
2498 * docs/Makefile: add 'buildbot.html' target
2500 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
2501 interpreted as "HEAD", so that all VC steps can accept branch=None
2502 and have it mean the "default branch".
2504 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
2506 2005-07-07 Brian Warner <warner@lothar.com>
2508 * docs/examples/twisted_master.cfg: update to match current usage
2510 * docs/buildbot.texinfo (System Architecture): comment out the
2511 image, it doesn't exist yet and just screws up the HTML manual.
2513 2005-07-05 Brian Warner <warner@lothar.com>
2515 * debian/.cvsignore: oops, missed one. Removing leftover file.
2517 2005-06-17 Brian Warner <warner@lothar.com>
2519 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
2520 changed its output in 1.2.0, don't mistakenly think that the
2521 subversion we find isn't capable of supporting our tests.
2523 * debian/*: remove the debian/ directory and its contents, to make
2524 life easier for the proper Debian maintainer
2526 * Makefile (release): same
2528 2005-06-07 Brian Warner <warner@lothar.com>
2530 * everything: create a distinct SourceStamp class to replace the
2531 ungainly 4-tuple, let it handle merging instead of BuildRequest.
2532 Changed the signature of Source.startVC to include the revision
2533 information (instead of passing it through self.args). Implement
2534 branches for SVN (now only Darcs/Git is missing support). Add more
2537 2005-06-06 Brian Warner <warner@lothar.com>
2539 * everything: rearrange build scheduling. Create a new Scheduler
2540 object (configured in c['schedulers'], which submit BuildSets to a
2541 set of Builders. Builders can now use multiple slaves. Builds can
2542 be run on alternate branches, either requested manually or driven
2543 by changes. This changed some of the Status classes. Interlocks
2544 are out of service until they've been properly split into Locks
2545 and Dependencies. treeStableTimer, isFileImportant, and
2546 periodicBuild have all been moved from the Builder to the
2548 (BuilderStatus.currentBigState): removed the 'waiting' and
2549 'interlocked' states, removed the 'ETA' argument.
2551 2005-05-24 Brian Warner <warner@lothar.com>
2553 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
2554 erroneously abandons the connection (in clientConnectionFailed)
2555 for non-UserErrors, which means that if we lose the connection due
2556 to a network problem or a timeout, we'll never try to reconnect.
2557 Fix this by not upcalling to the buggy parent method. Note:
2558 twisted-2.0 fixes this, but the function only has 3 lines so it
2559 makes more sense to copy it than to try and detect the buggyness
2560 of the parent class. Fixes SF#1207588.
2562 * buildbot/changes/changes.py (Change.branch): doh! Add a
2563 class-level attribute to accomodate old Change instances that were
2564 pickled before 0.6.5 (where .branch was added for new Changes).
2565 This fixes the exception that occurs when you try to look at an
2566 old Change (through asHTML).
2568 * buildbot/__init__.py (version): bump to 0.6.6+ while between
2571 2005-05-23 Brian Warner <warner@lothar.com>
2573 * buildbot/__init__.py (version): release 0.6.6
2575 2005-05-23 Brian Warner <warner@lothar.com>
2577 * NEWS: update for 0.6.6 release
2578 * debian/changelog: same
2580 * buildbot/scripts/runner.py (start): put the basedir in sys.path
2581 before starting: this was done by twistd back when we spawned it,
2582 now that we're importing the pieces and running them in the
2583 current process, we have to do it ourselves. This allows
2584 master.cfg to import files from the same directory without
2585 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
2586 Stichele for the catch.
2587 (Options.opt_version): Add a --version command (actually, just make
2588 the existing --version command emit Buildbot's version too)
2590 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
2591 fix to make this behave like other LogFiles, this time to handle
2592 existing LogFiles on disk. (add the missing .upgrade method)
2593 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
2595 2005-05-21 Brian Warner <warner@lothar.com>
2597 * buildbot/test/test_runner.py (Create.testMaster): match the
2598 rawstring change in runner.py:masterTAC
2600 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
2601 TwistedWords is installed
2602 * buildbot/test/test_status.py: same, with TwistedMail
2604 * buildbot/master.py: remove old IRC/Waterfall imports (used by
2605 some old, deprecated, and removed config keys). This should enable
2606 you to use the base buildbot functionality with Twisted-2.0.0 when
2607 you don't also have TwistedWeb and TwistedWords installed
2609 2005-05-20 Brian Warner <warner@lothar.com>
2611 * buildbot/scripts/runner.py (run): call sendchange(), not
2612 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
2613 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
2614 (stop): don't wait for process to die when sending SIGHUP
2615 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
2616 directory name gets interpreted, which you don't want
2619 * buildbot/__init__.py (version): bump to 0.6.5+ while between
2622 2005-05-18 Brian Warner <warner@lothar.com>
2624 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
2626 2005-05-18 Brian Warner <warner@lothar.com>
2628 * README: update for 0.6.5
2629 * debian/changelog: same
2631 * buildbot/changes/changes.py: rename tag= to branch=, since
2632 that's how we're using it, and my design for the upcoming "build a
2633 specific branch" feature wants it. also, tag= was too CVS-centric
2634 * buildbot/changes/mail.py (parseSyncmail): same
2635 * buildbot/process/base.py (Build.isBranchImportant): same
2636 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
2637 * docs/buildbot.texinfo (Attributes of Changes): same
2639 * NEWS: update tag=, update for upcoming release
2641 2005-05-17 Brian Warner <warner@lothar.com>
2643 * buildbot/scripts/runner.py (stop): actually poll once per
2644 second, instead of re-killing the poor daemon once per second.
2645 Sleep briefly (0.1s) before the first poll, since there's a good
2646 chance we can avoid waiting the full second if the daemon shuts
2647 down quickly. Also remove the sys.exit() at the end.
2648 (start): remove the unneighborly sys.exit()
2650 * Makefile: improve permission-setting to not kick Arch so badly
2652 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
2653 default --keepalive=600, since it doesn't hurt very much, and it's
2654 a hassle to discover that you need it.
2655 * buildbot/test/test_runner.py (Create.testSlave): test it
2657 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
2658 IRC bot about EXCEPTION
2660 * buildbot/status/client.py (PBListener): upcall more correctly
2662 * buildbot/process/base.py (Build.allStepsDone): if a step caused
2663 an exception mark the overall build with EXCEPTION, not SUCCESS
2665 * buildbot/scripts/runner.py (makefile_sample): remove the leading
2667 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
2668 * Makefile: update some release-related stuff
2670 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
2671 gets called when there isn't actually an active process, just end
2672 the Command instead of blowing up. I don't know how it gets into
2673 this state, but the twisted win32 buildslave will sometimes hang,
2674 and when it shakes its head and comes back, it thinks it's still
2675 running a Command. The next build causes this command to be
2676 interrupted, but the lack of self.process.pid breaks the interrupt
2679 * NEWS: document changes since the last release
2681 * buildbot/scripts/runner.py (start): change 'buildbot start' to
2682 look for Makefile.buildbot instead of a bare Makefile . The
2683 'buildbot start' does not install this file, so you have to
2684 manually copy it if you want to customize startup behavior.
2685 (createMaster): change 'buildbot master' command to create
2686 Makefile.sample instead of Makefile, to create master.cfg.sample
2687 instead of master.cfg (requiring you to copy it before the
2688 buildmaster can be started). Both sample files are kept up to
2689 date, i.e. they are overwritten if they have been changed. The
2690 'buildbot.tac' file is *not* overwritten, but if the new contents
2691 don't match the old, a 'buildbot.tac.new' file is created and the
2692 user is warned. This seems to be a much more sane way to handle
2693 startup files. Also, don't sys.exit(0) when done, so we can run
2694 unit tests against it.
2695 (createSlave): same. Don't overwrite the sample info/ files.
2696 * buildbot/scripts/sample.mk: remove. the contents were pulled
2697 into runner.py, since they need to match the behavior of start()
2701 * docs/buildbot.texinfo (Launching the daemons): document it
2702 * buildbot/test/test_runner.py (Create): test it
2704 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
2705 version that can handle string-in-string tests, because otherwise
2706 python-2.2 fails the tests. It'd be tremendous if Trial's test
2707 took two strings under 2.2 too.
2709 * everything: fixed all deprecation warnings when running against
2710 Twisted-2.0 . (at least all the ones in buildbot code, there are a
2711 few that come from Twisted itself). This involved putting most of
2712 the Twisted-version specific code in the new buildbot.twcompat
2713 module, and creating some abstract base classes in
2714 buildbot.changes.base and buildbot.status.base (which might be
2715 useful anyway). __implements__ is a nuisance and requires an ugly
2716 'if' clause everywhere.
2718 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
2719 delay before finishing the test: it seems that smtp.sendmail
2720 doesn't hang up on the server, so we must wait a moment so it can
2721 hang up on us. This removes the trial warning about an unclean
2724 2005-05-16 Brian Warner <warner@lothar.com>
2726 * buildbot/process/step.py (Source): add 'retry' argument. It is a
2727 tuple of (delay, repeats).
2728 * buildbot/test/test_vc.py (Retry): test it
2729 * docs/buildbot.texinfo (Source Checkout): document it
2730 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
2731 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
2732 doVCFull() are handled by re-trying the checkout (after a delay)
2733 some number of times.
2734 (ShellCommand._startCommand): make header lines easier to read
2736 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
2738 (WebTest.test_logfile): make sure master gets shut down, silences
2739 some "unclean reactor" test errors
2741 * buildbot/test/test_changes.py (Sender.tearDown): spin the
2742 reactor once after shutdown, something in certain versions of
2743 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
2744 fails, svn-trunk is ok.
2746 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
2747 second win32 error message
2749 * buildbot/test/test_run.py (Status.testSlave): be smarter about
2750 validating the ETA, so the tests don't fail on slow systems
2752 2005-05-15 Brian Warner <warner@lothar.com>
2754 * buildbot/status/builder.py (HTMLLogFile): make this behave like
2755 the new LogFile class, so upgrading works properly
2756 (LogFileProducer.resumeProducing): survive resumeProducing after
2757 we've exhausted the chunkGenerator
2759 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
2761 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
2762 (Log.testUpgrade): same
2764 * docs/buildbot.texinfo (Maintenance): describe how to delete old
2765 Builds and logs with a cron job.
2767 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
2768 of the old non-offline LogFile, added code to upgrade these to
2769 new-style contents-live-on-disk instances at load time (in a way
2770 that doesn't invalidate the old Build pickles, so upgrading to
2771 0.6.5 is not a one-way operation). Got rid of everything related
2773 (LogFile.__init__): create LogFiles with the parent step status,
2774 the log's name, and a builder-relative filename where it can keep
2775 the contents on disk.
2776 (LogFile.hasContents): new method, clients are advised to call it
2777 before getText or getChunks and friends. If it returns False, the
2778 log's contents have been deleted and getText() will raise an
2780 (LogFile.getChunks): made it a generator
2781 (LogFile.subscribeConsumer): new method, takes a Twisted-style
2782 Consumer (except one that takes chunks instead of strings). This
2783 enables streaming of very large logfiles without storing the whole
2785 (BuildStatus.generateLogfileName): create names like
2786 12-log-compile-output, with a _0 suffix if required to be unique
2787 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
2788 or earlier) logfiles into new-style ones
2789 (BuilderStatus): remove everything related to 'stub' builds. There
2790 is now only one build cache, and we don't strip logs from old
2792 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
2793 since we no longer fight to keep it in the cache
2795 * buildbot/status/html.py (TextLog.render_GET): use a
2796 ChunkConsumer to stream the log entries efficiently.
2797 (ChunkConsumer): wrapper which consumes chunks and writes
2800 * buildbot/test/test_twisted.py (Parse.testParse): use a
2801 LogFile-like object instead of a real one
2803 * buildbot/test/test_status.py (MyLog): handle new LogFile code
2804 (Log.testMerge3): validate more merge behavior
2805 (Log.testChunks): validate LogFile.getChunks
2806 (Log.testUpgrade): validate old-style LogFile upgrading
2807 (Log.testSubscribe): validate LogFile.subscribe
2808 (Log.testConsumer): validate LogFile.subscribeConsumer
2810 * buildbot/interfaces.py (IStatusLogStub): remove
2811 (IStatusLog.subscribeConsumer): new method
2812 (IStatusLog.hasContents): new method
2813 (IStatusLogConsumer): describes things passed to subscribeConsumer
2815 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
2816 the log contents if it does not have any contents.
2817 (StatusResourceBuildStep.body): same
2818 (StatusResourceBuildStep.getChild): give a 404 for empty logs
2820 2005-05-14 Brian Warner <warner@lothar.com>
2822 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
2823 timeouts to try and make the windows metabuildslave not hang
2825 2005-05-13 Mike Taylor <bear@code-bear.com>
2827 * buildbot/slave/commands.py (rmdirRecursive): added a check
2828 to ensure the path passed into rmdirRecursive actually exists.
2829 On win32 a non-existant path would generate an exception.
2831 2005-05-13 Brian Warner <warner@lothar.com>
2833 * buildbot/slave/commands.py (rmdirRecursive): replacement for
2834 shutil.rmtree which behaves correctly on windows in the face of
2835 files that you have to chmod before deleting. Thanks to Bear at
2836 the OSAF for the routine.
2837 (SourceBase.doClobber): use rmdirRecursive
2839 2005-05-12 Brian Warner <warner@lothar.com>
2841 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
2842 method generate chunks instead of returning a big list. This
2843 allows the same method to be used for both old LogFile and new
2845 (OfflineLogFile.getText): use the generator
2846 (OfflineLogFile.subscribe): same
2847 * buildbot/status/html.py (TextLog.resumeProducing): same
2848 * buildbot/interfaces.py (IStatusLog.getChunks): document it
2850 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
2851 point out that OfflineLogFile does not currently work with
2852 html.Waterfall . Fixing this is high-priority.
2854 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
2855 apparently windows defaults to using stdout
2857 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
2858 better message on failure so I can figure out the win32 problem
2860 * buildbot/slave/commands.py (ShellCommand._startCommand): update
2861 log messages to include more useful copies of the command being
2862 run, the argv array, and the child command's environment.
2863 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
2865 2005-05-11 Brian Warner <warner@lothar.com>
2867 * setup.py: oops, install debug.glade so 'buildbot debugclient'
2869 * Makefile: update the deb-snapshot version
2871 * docs/buildbot.texinfo: move all .xhtml docs into a new
2872 .texinfo-format document, adding a lot of material in the process.
2873 This is starting to look like a real user's manual. Removed all
2874 the Lore-related files: *.xhtml, *.css, template.tpl .
2875 * docs/Makefile: simple makefile to run 'makeinfo'
2876 * buildbot/scripts/sample.cfg: rearrange slightly
2877 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
2879 2005-05-10 Brian Warner <warner@lothar.com>
2881 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
2882 different name for the internal twistw module, handle it.
2884 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
2885 * setup.py: .. and stop trying to install it
2887 * buildbot/process/step.py (Git): added support for 'cogito' (aka
2888 'git'), the new linux kernel VC system (http://kernel.org/git/).
2889 Thanks to Brandon Philips for the patch.
2890 * buildbot/slave/commands.py (Git): same
2892 2005-05-06 Brian Warner <warner@lothar.com>
2894 * buildbot/status/builder.py (OfflineLogFile): replace the default
2895 LogFile with a form that appends its new contents to a disk file
2896 as they arrive. The complete log data is never kept in RAM. This
2897 is the first step towards handling very large (100MB+) logfiles
2898 without choking quite so badly. (The other half is
2899 producer/consumer on the HTML pages).
2900 (BuildStepStatus.addLog): use OfflineLogFile by default
2901 (BuildStatus.getLogfileName): helper code to give the
2902 OfflineLogFile a filename to work with
2904 * buildbot/test/test_status.py (Results.testAddResults): update
2905 tests to handle new asserts
2906 * buildbot/test/test_vc.py (Patch.doPatch): same
2907 * buildbot/test/test_steps.py (BuildStep.setUp): same
2909 2005-05-05 Brian Warner <warner@lothar.com>
2911 * buildbot/scripts/runner.py (start): if there is no Makefile,
2912 launch the app by importing twistd's internals and calling run(),
2913 rather than spawning a new twistd process. This stands a much
2914 better chance of working under windows.
2915 (stop): kill the process with os.kill instead of spawning
2916 /bin/kill, again to reduce the number of external programs which
2917 windows might not have in the PATH. Also wait up to 5 seconds for
2918 the process to go away, allowing things like 'buildbot stop;
2919 buildbot start' to be reliable in the face of slow shutdowns.
2921 * buildbot/master.py (Dispatcher.__getstate__): remove old
2922 .tap-related methods
2923 (BuildMaster.__getstate__): same
2925 * buildbot/slave/bot.py (makeService): same
2926 (Options.longdesc): same
2927 * buildbot/scripts/runner.py: copy over some old mktap option text
2929 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
2930 'buildbot master' now creates a buildbot.tac file, so there is no
2931 longer a create-instance/save/reload sequence. mktap is dead, long
2933 * buildbot/scripts/sample.mk: use twistd -y, not -f
2934 * buildbot/test/test_config.py: remove mktap-based test
2935 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
2936 * README: don't reference mktap
2938 * docs/source.xhtml: document some of the attributes that Changes
2941 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
2943 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
2944 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
2945 * buildbot/changes/changes.py (Change)
2946 * buildbot/changes/mail.py (parseSyncmail)
2947 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
2949 * buildbot/process/base.py (Build.isTagImportant)
2953 2005-05-04 Brian Warner <warner@lothar.com>
2955 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
2956 connection after sending the change, so that unit tests don't
2957 complain about sockets being left around
2959 * buildbot/status/html.py (WaterfallStatusResource.body): fix
2960 exception in phase=0 rendering
2961 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
2963 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
2965 * buildbot/master.py (BuildMaster.loadConfig): finally remove
2966 deprecated config keys: webPortnum, webPathname, irc, manholePort,
2967 and configuring builders with tuples.
2968 * buildbot/test/test_config.py: stop testing compatibility with
2969 deprecated config keys
2970 * buildbot/test/test_run.py: same
2972 2005-05-03 Brian Warner <warner@lothar.com>
2974 * contrib/arch_buildbot.py: survive if there are no logfiles
2975 (username): just use a string, os.getlogin isn't reliable
2977 * buildbot/scripts/runner.py (sendchange): oops, fix the command
2978 so 'buildbot sendchange' actually works. The earlier test only
2979 covered the internal (non-reactor-running) form.
2981 * contrib/arch_buildbot.py: utility that can run as an Arch hook
2982 script to notify the buildmaster about changes
2984 * buildbot/scripts/runner.py (sendchange): new command to send a
2985 change to a buildbot.changes.pb.PBChangeSource receiver.
2986 * buildbot/test/test_changes.py (Sender): test it
2988 * buildbot/master.py (BuildMaster.startService): mark .readConfig
2989 after any reading of the config file, not just when we do it in
2990 startService. This makes some tests a bit cleaner.
2992 * buildbot/changes/pb.py: add some log messages
2994 * buildbot/process/base.py (Build.startBuild): fix a bug that
2995 caused an exception when the build terminated in the very first
2997 (Build.stepDone): let steps return a status of EXCEPTION. This
2998 terminates the build right away, and sets the build's overall
2999 status to EXCEPTION too.
3000 * buildbot/process/step.py (BuildStep.failed): return a status of
3001 EXCEPTION when that is what has happened.
3003 * buildbot/process/step.py (Arch.computeSourceRevision): finally
3004 implement this, allowing Arch-based projects to get precise
3005 checkouts instead of always using the latest code
3006 (Bazaar): create variant of Arch to let folks use baz instead of
3007 tla. Requires a new buildslave too.
3008 * buildbot/slave/commands.py (Arch): add 'revision' argument
3009 (Bazaar): create variant of Arch that uses baz instead of tla.
3010 Remove the code that extracts the archive name from the
3011 register-archive output, since baz doesn't provide it, and require
3012 the user provide both the archive name and its location.
3013 * buildbot/test/test_vc.py (VC.testBazaar): added tests
3015 2005-05-02 Brian Warner <warner@lothar.com>
3017 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
3018 thanks to Nick Trout.
3020 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
3021 deals better with source Makefile coming from a read-only CVS
3022 checkout. Thanks to Nick Trout for the catch.
3024 * buildbot/__init__.py (version): bump to 0.6.4+ while between
3027 2005-04-28 Brian Warner <warner@lothar.com>
3029 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
3031 * debian/changelog: update for 0.6.4
3033 2005-04-28 Brian Warner <warner@lothar.com>
3035 * README.w32: add a checklist of steps for getting buildbot
3037 * MANIFEST.in: include it in the tarball
3041 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
3042 broken .tap files from 0.6.3 by getting rid of .services,
3043 .namedServices, and .change_svc at load time.
3045 2005-04-27 Brian Warner <warner@lothar.com>
3047 * NEWS: update in preparation for new release
3049 * buildbot/test/test_config.py (Save.testSave): don't pull in
3050 twisted.scripts.twistd, we don't need it and it isn't for windows
3053 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
3054 accomodate win32 which can't do atomic-rename
3056 2005-04-27 Brian Warner <warner@lothar.com>
3058 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
3059 timeouts to help the slow metabuildbot not flunk them so much
3060 (Disconnect.testBuild3): same
3061 (Disconnect.testBuild4): same
3062 (Disconnect.testInterrupt): same
3064 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
3065 setup, it was completely broken for new buildmasters (those which
3066 did not have a 'change.pck' already saved. Thanks to Paul Warren
3067 for catching this (embarrassing!) bug.
3068 (Dispatcher.__getstate__): don't save our registered avatar
3069 factories, since they'll be re-populated when the config file is
3071 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
3072 tests (since the real mktap-generated BuildMaster doesn't save
3074 (BuildMaster.__getstate__): don't save any service children,
3075 they'll all be re-populated when the config file is re-read.
3076 * buildbot/test/test_config.py (Save.testSave): test for this
3078 2005-04-26 Brian Warner <warner@lothar.com>
3080 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
3081 rendered with Blender.. looks a bit nicer.
3082 * buildbot/docs/images/icon.blend: add the Blender file for it
3084 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
3085 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
3086 running under windows. This appears to be the best way to allow
3087 BuildSteps to do something normal like 'trial -v buildbot.test' or
3088 'make foo' and still expect it to work. The idea is to make the
3089 BuildSteps look as much like what a developer would type when
3090 compiling or testing the tree by hand. This approach probably has
3091 problems when there are spaces in the arguments, so if you've got
3092 windows buildslaves, you'll need to pay close attention to your
3095 * buildbot/status/html.py (WaterfallStatusResource.body): add the
3096 timezone to the timestamp column.
3097 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3099 * buildbot/scripts/runner.py (loadOptions): do something sane for
3100 windows, I think. We use %APPDATA%/buildbot instead of
3101 ~/.buildbot, but we still search everywhere from the current
3102 directory up to the root for a .buildbot/ subdir. The "is it under
3103 $HOME" security test was replaced with "is it owned by the current
3104 user", which is only performed under posix.
3105 * buildbot/test/test_runner.py (Options.testFindOptions): update
3106 tests to match. The "is it owned by the current user" check is
3107 untested. The test has been re-enabled for windows.
3109 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
3110 any "\n" in the expected output with the platform-specific line
3111 separator. Make this separator "\r\n" on PTYs under unix, they
3112 seem to do that and I don't know why
3114 * buildbot/test/test_runner.py (Options.optionsFile): disable on
3115 windows for now, I don't know what ~/.buildbot/ should mean there.
3117 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
3118 win32 compatibility, don't use "/tmp"
3119 (Basedir.testChangeBuilddir): remove more unixisms
3121 2005-04-26 Brian Warner <warner@lothar.com>
3123 * buildbot/test/test_control.py (Force.rmtree): python2.2
3124 compatibility, apparently its shutil.rmtree ignore_errors=
3125 argument is ignored.
3126 * buildbot/test/test_run.py (Run.rmtree): same
3127 (RunMixin.setUp): same
3129 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
3132 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
3133 'substring in string' operator, must use string.find(substr)!=-1
3134 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
3135 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
3137 * buildbot/scripts/runner.py (loadOptions): add code to search for
3138 ~/.buildbot/, a directory with things like 'options', containing
3139 defaults for various 'buildbot' subcommands. .buildbot/ can be in
3140 the current directory, your $HOME directory, or anywhere
3141 inbetween, as long as you're somewhere inside your home directory.
3142 (debugclient): look in ~/.buildbot/options for master and passwd
3143 (statuslog): look in ~/.buildbot/options for 'masterstatus'
3144 * buildbot/test/test_runner.py (Options.testFindOptions): test it
3146 * buildbot/status/client.py (makeRemote): new approach to making
3147 IRemote(None) be None, which works under Twisted-2.0
3148 * buildbot/test/test_status.py (Client.testAdaptation): test it
3150 * buildbot/status/builder.py (Status.builderAdded): when loading a
3151 pickled BuilderStatus in from disk, set its name after loading.
3152 The config file might have changed its name (but not its
3153 directory) while it wasn't looking.
3155 * buildbot/process/builder.py (Builder.attached): always return a
3156 Deferred, even if the builder was already attached
3157 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
3159 2005-04-25 Brian Warner <warner@lothar.com>
3161 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
3162 category-related exception when announcing a build has finished
3164 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
3165 reference no-longer-existent changemaster.sources
3166 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
3168 * buildbot/__init__.py (version): bump to 0.6.3+ while between
3171 2005-04-25 Brian Warner <warner@lothar.com>
3173 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
3175 * debian/changelog: update for 0.6.3
3177 2005-04-25 Brian Warner <warner@lothar.com>
3179 * MANIFEST.in: make sure debug.glade is in the tarball
3181 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
3183 * NEWS: update for the imminent 0.6.3 release
3185 * buildbot/status/html.py (HtmlResource.content): make the
3186 stylesheet <link> always point at "buildbot.css".
3187 (StatusResource.getChild): map "buildbot.css" to a static.File
3188 containing whatever css= argument was provided to Waterfall()
3189 (Waterfall): provide the "classic" css as the default.
3190 * docs/waterfall.classic.css: move default CSS from here ..
3191 * buildbot/status/classic.css: .. to here
3193 * MANIFEST.in: make sure classic.css is included in the tarball
3194 * setup.py: and that it is installed too, under buildbot/status/
3196 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
3197 the module level, because buildbot.tap files from 0.6.2 don't have
3198 it in their attribute dictionary.
3200 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
3201 really exists at startup, might save some confusion somewhere.
3203 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
3205 * docs/waterfall.classic.css:
3206 add a stylesheet that's almost the same as the "classic"
3209 * buildbot/status/builder.py:
3210 add EXCEPTION as a result - this is a problem for the bot
3211 maintainer, not a build problem for the changers
3212 * buildbot/process/step.py:
3213 use EXCEPTION instead of FAILURE for exceptions
3214 * buildbot/status/html.py:
3215 add build_get_class to get a class out of a build/buildstep
3216 finish naming the classes
3217 split out sourceNames to changeNames and builderNames so we
3218 can style them separately
3219 * docs/config.xhtml:
3220 finish documenting classes as they are right now
3222 * buildbot/status/html.py:
3223 name the classes as we agreed on IRC
3224 * docs/config.xhtml:
3227 * buildbot/status/html.py:
3228 same for cssclass->class_
3230 * buildbot/status/html.py:
3231 as decided on IRC, use class_ for the "class" attribute to not
3232 conflict with the class keyword, and clean up the messy **{} stuff.
3234 * buildbot/status/mail.py:
3235 put back "builders" argument, and fix docstring, because the
3236 code *ignores* builders listed in this argument
3238 * buildbot/process/builder.py:
3239 remove FIXME notes - category is now indeed a cvar of BuilderStatus
3241 * docs/config.xhtml:
3242 describe the category argument for builders
3244 * buildbot/status/builder.py:
3245 Fix a silly bug due to merging
3247 * buildbot/process/builder.py:
3248 remove category from the process Builder ...
3249 * buildbot/status/builder.py:
3250 ... and add it to BuilderStatus instead.
3251 Set category on unpickled builder statuses, they might not have it.
3252 * buildbot/master.py:
3253 include category when doing builderAdded
3254 * buildbot/status/mail.py:
3255 return None instead of self for builders we are not interested in.
3256 * buildbot/test/test_run.py:
3257 fix a bug due to only doing deferredResult on "dummy" waiting
3258 * buildbot/test/test_status.py:
3259 add checks for the Mail IStatusReceiver returning None or self
3261 * buildbot/status/html.py:
3262 fix testsuite by prefixing page title with BuildBot
3264 * buildbot/status/builder.py:
3265 have .category in builder status ...
3266 * buildbot/process/builder.py:
3267 ... and set it from Builder
3268 * buildbot/status/html.py:
3269 make .css a class variable
3270 * buildbot/test/test_status.py:
3271 write more tests to cover our categories stuff ...
3272 * buildbot/status/mail.py:
3273 ... and fix the bug that this uncovered
3275 * buildbot/changes/mail.py:
3276 * buildbot/changes/pb.py:
3277 * buildbot/master.py:
3278 * buildbot/process/base.py:
3279 * buildbot/process/factory.py:
3280 * buildbot/process/interlock.py:
3281 * buildbot/process/step.py:
3282 * buildbot/process/step_twisted.py:
3283 * buildbot/slave/commands.py:
3284 * buildbot/status/builder.py:
3285 * buildbot/status/client.py:
3286 * buildbot/status/html.py:
3287 * buildbot/status/mail.py:
3288 * buildbot/status/progress.py:
3289 * buildbot/test/test_changes.py:
3290 * buildbot/test/test_config.py:
3291 * buildbot/test/test_control.py:
3292 * buildbot/test/test_interlock.py:
3293 * buildbot/test/test_maildir.py:
3294 * buildbot/test/test_mailparse.py:
3295 * buildbot/test/test_run.py:
3296 * buildbot/test/test_slavecommand.py:
3297 * buildbot/test/test_status.py:
3298 * buildbot/test/test_steps.py:
3299 * buildbot/test/test_twisted.py:
3300 * buildbot/test/test_util.py:
3301 * buildbot/test/test_vc.py:
3302 * buildbot/test/test_web.py:
3304 add test-case-name at the top of a whole set of files
3306 * buildbot/status/builder.py:
3307 keep order of addition when getting builder names
3308 * buildbot/status/words.py:
3309 * buildbot/test/test_run.py:
3310 add test for getBuilderNames
3312 * buildbot/process/base.py:
3313 * buildbot/process/step.py:
3314 * buildbot/status/builder.py:
3315 * buildbot/status/html.py:
3316 make buildbot css-able
3317 replace the color code for purple with purple, don't understand
3318 why it wasn't purple to start with
3320 * buildbot/status/words.py:
3321 ok, so it doesn't look like BuilderStatus.remote is still valid.
3322 Use what waterfall uses instead.
3324 * buildbot/interfaces.py:
3325 * buildbot/status/builder.py:
3326 * buildbot/status/html.py:
3327 * buildbot/status/mail.py:
3328 * buildbot/status/words.py:
3329 * buildbot/test/test_run.py:
3330 use categories everywhere and make it be a list. More sensible
3331 for the future. Also make words actually respect this in
3334 * buildbot/interfaces.py:
3335 add category argument to getBuilderNames
3336 * buildbot/process/builder.py:
3337 * buildbot/status/builder.py:
3338 * buildbot/status/html.py:
3339 * buildbot/status/mail.py:
3340 * buildbot/status/words.py:
3341 * buildbot/test/test_run.py:
3342 move from specifying builders by name to specifying the category
3344 * buildbot/status/html.py:
3345 * buildbot/status/words.py:
3346 add "builders=" to __init__ of status clients so they can
3347 limit themselves to the given list of builders to report on
3349 * buildbot/status/html.py: set the title to the product name
3351 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
3353 * buildbot/interfaces.py:
3354 * buildbot/status/builder.py:
3355 more documentation. Hm, not sure if ChangeLog entries make sense
3358 2005-04-23 Brian Warner <warner@lothar.com>
3360 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
3362 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
3364 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
3365 the sub-commands that log buildmaster status to stdout and to a
3366 GUI window, respectively.
3368 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
3369 functionality is working again, but all the step-status and ETA
3370 stuff is missing. Commented out a lot of code pending more
3373 * buildbot/status/client.py: make sure that IRemote(None) is None
3375 * buildbot/changes/changes.py: import defer, oops
3376 (ChangeMaster): remove the .sources list, rely upon the fact that
3377 MultiServices can be treated as sequences of their children. This
3378 cleans up the add/remove ChangeSource routines a lot, as we keep
3379 exactly one list of the current sources instead of three.
3381 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
3382 up an empty ChangeMaster at init time.
3383 (BuildMaster.loadChanges): if there are changes to be had from
3384 disk, replace self.change_svc with the new ones. If not, keep
3385 using the empty ChangeMaster set up in __init__.
3386 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
3387 instead of a separate list, makes the code a bit cleaner.
3388 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
3389 (ConfigTest.testSources): same, also wait for loadConfig to finish.
3390 Extend the test to make sure we can get rid of the sources when
3393 2005-04-22 Brian Warner <warner@lothar.com>
3395 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
3396 and info/host files when making the slave directory
3398 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
3399 whendone= argument, just return the Deferred and let the caller do
3400 what they want with it.
3401 (Disconnect.testBuild1): wait for shutdownSlave
3402 (Basedir.testChangeBuilddir): new test to make sure changes to the
3403 builddir actually get propagated to the slave
3405 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
3406 explicit method, rather than passing the builddir in __init__ .
3407 Make sure to update self.basedir too, this was broken before.
3408 (Bot.remote_setBuilderList): use b.setBuilddir for both new
3409 builders and for ones that have just had their builddir changed.
3410 (BotFactory): add a class-level .perspective attribute, so
3411 BuildSlave.waitUntilDisconnected won't get upset when the
3412 connection hasn't yet been established
3413 (BuildSlave.__init__): keep track of the bot.Bot instance, so
3414 tests can reach through it to inspect the SlaveBuilders
3416 * buildbot/process/base.py (Build.buildException): explain the
3417 log.err with a log.msg
3418 * buildbot/process/builder.py (Builder.startBuild): same
3419 (Builder._startBuildFailed): improve error message
3421 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
3422 occurred because we lost the brand-new connection, retry instead
3423 of giving up. If not, it's probably an authorization failure, and
3424 it makes sense to stop trying. Make sure we log.msg the reason
3425 that we're log.err'ing the failure, otherwise test failures are
3426 really hard to figure out.
3428 * buildbot/master.py: change loadConfig() to return a Deferred
3429 that doesn't fire until the change has been fully implemented.
3430 This means any connected slaves have been updated with the new
3431 builddir. This change makes it easier to test the code which
3432 actually implements this builddir-updating.
3433 (BotPerspective.addBuilder): return Deferred
3434 (BotPerspective.removeBuilder): same
3435 (BotPerspective.attached): same
3436 (BotPerspective._attached): same. finish with remote_print before
3437 starting the getSlaveInfo, instead of doing them in parallel
3438 (BotPerspective.list_done): same
3439 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
3440 actually calling slave.disconnect()
3441 (BotMaster.addBuilder): same
3442 (BotMaster.removeBuilder): same
3443 (BuildMaster.loadConfig): same
3444 (BuildMaster.loadConfig_Slaves): same
3445 (BuildMaster.loadConfig_Sources): same
3446 (BuildMaster.loadConfig_Builders): same
3447 (BuildMaster.loadConfig_status): same
3449 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
3450 a Deferred that fires when the source is finally removed
3452 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
3453 the previous tree on win32, where we have to do it synchronously,
3454 make sure we return a Deferred anyway.
3455 (SourceBase.doCopy): same
3457 * buildbot/scripts/runner.py (statusgui): use the text client for
3458 now, while I rewrite the Gtk one
3459 * buildbot/clients/base.py: strip out old code, leaving just the
3460 basic print-message-on-event functionality. I also remove the
3461 ReconnectingPBClientFactory, but it does at least quit when it
3462 loses the connection instead of going silent
3464 2005-04-21 Brian Warner <warner@lothar.com>
3466 * Makefile: minor tweaks
3468 * NEWS: point out deprecation warnings, new features for
3471 * buildbot/master.py (BuildMaster.loadConfig): emit
3472 DeprecationWarnings for Builders defined with tuples. Rearrange
3473 code to facility removal of deprecated configuration keys in the
3476 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
3477 'buildbot' command to put a little Makefile in the target that
3478 helps you re-create the buildbot.tap file, start or stop the
3479 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
3480 all the files 0600, since they contain passwords.
3481 (start): if there is a Makefile, and /usr/bin/make exists, use
3482 'make start' in preference to a raw twistd command. This lets
3483 slave admins put things like PYTHONPATH variables in their
3484 Makefiles and have them still work when the slave is started with
3485 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
3486 be nice to first try the 'make' command and only fall back to
3487 twistd if it fails. TODO: the Makefile's "start" command does not
3488 add the --reactor=win32 argument when running under windows.
3489 (Options.debugclient, Options.statusgui): add sub-commands to launch
3490 the debug client (formerly in contrib/debugclient.py) and the
3491 Gtk status application (currently broken)
3492 * buildbot/clients/debug.py: move from contrib/debugclient.py
3493 * buildbot/clients/debug.glade: same
3495 * buildbot/test/test_trial.py: remove it. This requires some
3496 functionality out of Twisted that isn't there yet, and until then
3497 having it around just confuses things.
3499 * buildbot/test/test_slavecommand.py (Shell): test both with and
3500 without PTYs, and make sure that command output is properly
3501 interleaved in the with-PTY case. I think the without-PTY test
3502 should pass on windows, where we never use PTYs anyway.
3504 2005-04-20 Brian Warner <warner@lothar.com>
3506 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
3508 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
3510 * NEWS: start creating entries for the next release
3512 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
3514 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
3515 (WebTest.test_webPathname): same
3516 (WebTest.test_webPathname_port): same
3517 (WebTest.test_waterfall): use the default favicon rather than
3518 rooting around the filesystem for it. Open the expected-icon file
3519 in binary mode, to make win32 tests happier (thanks to Nick Trout
3521 * buildbot/status/html.py (buildbot_icon): win32 portability
3523 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
3524 win32-compatibility fixes from Nick Trout, the "file not found" message
3525 is different under windows
3526 (FakeSlaveBuilder.__init__): clean up setup a bit
3527 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
3529 2005-04-19 Brian Warner <warner@lothar.com>
3531 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
3532 skip-if-repositories-are-unavailable test to not kill the trial
3533 that comes with Twisted-1.3.0
3535 * setup.py: install buildbot.png icon file when installing code
3537 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
3538 environment used by the command, at least on the child side.
3540 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
3541 this method needs to be added and implemented because it gets
3542 called under heavy load. I don't quite understand the
3543 producer/consumer API enough to write it.
3544 (StatusResource.getChild): add a resource for /favicon.ico
3545 (Waterfall.__init__): add favicon= argument
3546 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
3547 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
3548 (WebTest.test_webPathname): same
3549 (WebTest.test_webPathname_port): same
3550 * docs/config.xhtml: mention favicon=
3551 * buildbot/buildbot.png: add a default icon, dorky as it is
3553 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
3555 * buildbot/master.py:
3556 * buildbot/process/base.py:
3557 * buildbot/process/builder.py:
3558 * buildbot/process/interlock.py:
3559 * buildbot/status/builder.py:
3560 * buildbot/status/html.py:
3561 * buildbot/status/mail.py:
3562 * buildbot/status/words.py:
3563 new documentation while digging through the code
3565 2005-04-17 Brian Warner <warner@lothar.com>
3567 * general: try to fix file modes on all .py files: a+r, a-x,
3568 but let buildbot/clients/*.py be +x since they're tools
3570 * docs/epyrun (addMod): when an import fails, say why
3572 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
3574 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3576 * buildbot/process/base.py:
3577 * buildbot/process/builder.py:
3578 * buildbot/status/builder.py:
3579 new documentation while digging through the code
3581 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3583 * buildbot/changes/changes.py:
3584 * buildbot/changes/p4poller.py:
3585 * buildbot/interfaces.py:
3586 * buildbot/process/base.py:
3587 * buildbot/process/builder.py:
3588 * buildbot/process/step.py:
3589 * buildbot/process/step_twisted.py:
3590 * buildbot/slave/bot.py:
3591 * buildbot/slave/commands.py:
3592 * buildbot/status/builder.py:
3593 fix all docstrings to make epydoc happy. In the process of fixing
3594 some, I also moved pieces of docs, and removed some deprecated
3597 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
3599 * buildbot/process/builder.py:
3600 * buildbot/process/interlock.py:
3601 * buildbot/process/process_twisted.py:
3602 * buildbot/process/step.py:
3603 BuildProcess -> Build, as it looks like that's what happened
3604 * buildbot/process/base.py:
3605 * buildbot/process/factory.py:
3608 2005-04-17 Brian Warner <warner@lothar.com>
3610 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
3611 update compile command to accomodate the Twisted split.. now
3612 instead of './setup.py build_ext -i', you do './setup.py all
3613 build_ext -i', to run build_ext over all sub-projects.
3614 (FullTwistedBuildFactory): same
3615 (TwistedReactorsBuildFactory): same
3617 * buildbot/status/html.py (TextLog.finished): null out self.req
3618 when we're done, otherwise the reference cycle of TextLog to .req
3619 to .notifications to a Deferred to TextLog.stop keeps them from
3620 being collected, and consumes a huge (610MB on pyramid at last
3621 check) amount of memory.
3623 2005-04-11 Brian Warner <warner@lothar.com>
3625 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
3626 normalize the VC-repository location.. makes SVN happier with
3627 certain test environments.
3629 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
3630 RemoteShellCommand gets its own .env dictionary, so that code in
3631 start() doesn't mutate the original. I think this should fix the
3632 step_twisted.Trial problem where multiple identical components
3633 kept getting added to PYTHONPATH= over and over again.
3635 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
3636 adding epydoc-format docstrings to many classes. Thanks to Thomas
3637 Vander Stichele for the patches.
3638 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
3639 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
3640 * buildbot/slave/bot.py, commands.py, registry.py: same
3642 2005-04-05 Brian Warner <warner@lothar.com>
3644 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
3645 preserve timestamps, helps incremental builds of large trees.
3646 Patch from Rene Rivera.
3648 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
3649 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
3652 2005-04-03 Brian Warner <warner@lothar.com>
3654 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
3655 with one dict, apparently exec has some scoping bugs when used
3656 with both global/local dicts. Thanks to Nathaniel Smith for the
3659 2005-04-02 Brian Warner <warner@lothar.com>
3661 * buildbot/process/step_twisted.py (countFailedTests): the new
3662 trial in Twisted-2.0 emits a slightly different status line than
3663 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
3664 mistakenly think the test count is unparseable.
3665 (Trial.start): note that for some reason each build causes another
3666 copy of self.testpath to be prepended to PYTHONPATH. This needs to
3667 be fixed but I'm not sure quite where the problem is.
3669 2005-04-01 Brian Warner <warner@lothar.com>
3671 * buildbot/test/test_run.py (Run.testMaster): change some uses of
3672 deferredResult to avoid hangs/warnings under twisted-2.0
3673 (RunMixin.tearDown): same
3674 (RunMixin.shutdownSlave): same
3675 (Disconnect.testIdle1): same
3676 (Disconnect.testBuild2): same: wait one second after the build
3677 finishes for test to really be done.. this should be cleaned up to
3678 avoid wasting that second. Builder.detach uses a callLater(0),
3679 either that should be done in-line (something else needed that
3680 behavior), or it should return a Deferred that fires when the
3681 builder is really offline.
3682 (Disconnect.testBuild3): same
3683 (Disconnect.testDisappear): same
3685 * buildbot/test/test_web.py: rearrange server-setup and teardown
3686 code to remove unclean-reactor warnings from twisted-2.0
3688 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
3689 so the tests don't hang under twisted-2.0
3691 2005-03-31 Brian Warner <warner@lothar.com>
3693 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
3694 caused a warning each time the master changed our set of builders
3696 * buildbot/status/builder.py (BuildStatus.saveYourself): under
3697 w32, don't unlink the file unless it already exists. Thanks to
3698 Baptiste Lepilleur for the catch.
3699 (BuilderStatus.saveYourself): same
3701 2005-02-01 Brian Warner <warner@lothar.com>
3703 * buildbot/status/html.py (TextLog.getChild): use a /text child
3704 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
3705 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
3706 logfile as text/plain (no markup, no headers). This replaces the
3707 previous scheme (which used an ?text=1 argument), and gets us back
3708 to a relative link (which works better when the buildbot lives
3709 behind another web server, such as Apache configured as a reverse
3710 proxy). Thanks to Gerald Combs for spotting the problem.
3712 * buildbot/__init__.py (version): bump to 0.6.2+ while between
3715 2004-12-13 Brian Warner <warner@lothar.com>
3717 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
3719 * debian/changelog: update for 0.6.2
3720 * NEWS: finalize for 0.6.2
3722 2004-12-11 Brian Warner <warner@lothar.com>
3724 * NEWS: bring it up to date
3726 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
3727 detection code. Require some sign of life from the buildmaster
3728 every BotFactory.keepaliveInterval seconds. Provoke this
3729 indication at BotFactory.keepaliveTimeout seconds before the
3730 deadline by sending a keepalive request. We don't actually care if
3731 that request is answered in a timely fashion, what we care about
3732 is that .activity() is called before the deadline. .activity() is
3733 triggered by any PB message from the master (including an ack to
3734 one of the slave's status-update messages). With this new scheme,
3735 large status messages over slow pipes are OK, as long as any given
3736 message can be sent (and thus acked) within .keepaliveTimeout
3737 seconds (which defaults to 30).
3738 (SlaveBuilder.remote_startCommand): record activity
3739 (SlaveBuilder.ackUpdate): same
3740 (SlaveBuilder.ackComplete): same
3741 (BotFactory.gotPerspective): same
3742 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
3744 2004-12-09 Brian Warner <warner@lothar.com>
3746 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
3749 * buildbot/process/step_twisted.py (Trial._commandComplete):
3750 update self.cmd when we start the 'cat test.log' transfer. Without
3751 this, we cannot interrupt the correct RemoteCommand when we lose
3754 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
3755 trying to tell the slave to stop the command if we're already
3756 inactive, or if we no longer have a .remote
3758 * buildbot/process/builder.py (Builder._detached): don't let an
3759 exception in currentBuild.stopBuild() prevent the builder from
3760 being marked offline
3762 2004-12-07 Brian Warner <warner@lothar.com>
3764 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
3765 KeyError that happens when you ask for a non-existent Builder, and
3766 translate it into a UsageError.
3768 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
3769 losing the slave in the middle of a remote step is handled too
3771 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
3772 be a Failure, so be sure to stringify it before using it as the
3773 contents of the 'interrupt' logfile
3774 (RemoteCommand.interrupt): use stringified 'why' in
3775 remote_interruptCommand too, just in case
3777 2004-12-06 Brian Warner <warner@lothar.com>
3779 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
3780 instead of 'tla update', which is more efficient in case we've
3781 missed a couple of patches since the last update.
3783 * debian/changelog: update for previous (0.6.1) release. Obviously
3784 this needs to be handled better.
3786 2004-12-05 Brian Warner <warner@lothar.com>
3788 * NEWS: update for stuff since last release
3790 * buildbot/master.py (DebugPerspective.attached): return 'self', to
3791 match the maybeDeferred change in Dispatcher.requestAvatar
3792 * buildbot/changes/pb.py (ChangePerspective.attached): same
3793 * buildbot/status/client.py (StatusClientPerspective.attached): same
3794 * buildbot/process/builder.py (Builder._attached3): same
3795 * buildbot/pbutil.py (NewCredPerspective.attached): same
3797 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
3798 the date to the top-most box, if it is not the same as today's
3801 * docs/slave.xhtml: provide a buildslave setup checklist
3803 * docs/source.xhtml (Arch): correct terminology
3805 2004-12-04 Brian Warner <warner@lothar.com>
3807 * buildbot/test/test_slavecommand.py: use sys.executable instead
3808 of hard-coding 'python' for child commands, might help portability
3810 * docs/examples/twisted_master.cfg: update to current usage
3812 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
3813 'stop build' command to the IRC bot
3815 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
3816 message that broke PBChangeSource
3818 * buildbot/slave/bot.py: clean up shutdown/lose-master code
3819 (SlaveBuilder): make some attributes class-level, remove the old
3820 "update queue" which existed to support resuming a build after the
3821 master connection was lost. Try to reimplement that feature later.
3822 (SlaveBuilder.stopCommand): clear self.command when the
3823 SlaveCommand finishes, so that we don't try to kill a leftover one
3825 (SlaveBuilder.commandComplete): same, merge with commandFailed and
3828 * buildbot/slave/commands.py (SourceBase): set self.command for
3829 all VC commands, so they can be interrupted.
3831 2004-12-03 Brian Warner <warner@lothar.com>
3833 * buildbot/master.py: clean up slave-handling code, to handle
3834 slave-disconnect and multiple-connect better
3835 (BotPerspective): make these long-lasting, exactly one per bot
3836 listed in the config file.
3837 (BotPerspective.attached): if a slave connects while an existing
3838 one appears to still be connected, disconnect the old one first.
3839 (BotPerspective.disconnect): new method to forcibly disconnect a
3840 buildslave. Use some hacks to empty the transmit buffer quickly to
3841 avoid the long (20-min?) TCP timeout that could occur if the old
3842 slave has dropped off the net.
3843 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
3844 own their own SlaveStatus objects. Remove .attached/.detached, add
3845 .addSlave/.removeSlave, treat slaves like Builders (config file
3846 parsing sends deltas to the BotMaster). Inform the slave
3847 instances, i.e. the BotPerspective, about addBuilder and
3849 (BotMaster.getPerspective): turns into a single dict lookup
3850 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
3851 which gives BotPerspective.attached a chance to disconnect the old
3853 (BuildMaster.loadConfig): add code (disabled) to validate that all
3854 builders use known slaves (listed in c['bots']). The check won't
3855 work with tuple-specified builders, which are deprecated but not
3856 yet invalid, so the check is disabled for now.
3857 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
3858 routine, do the add/changed/removed dance with them like we do
3860 (BuildMaster.loadConfig_Sources): move source-config into a
3861 separate routine too
3863 * buildbot/status/builder.py (Status.getSlave): get the
3864 SlaveStatus object from the BotPerspective, not the BotMaster.
3866 * buildbot/test/test_run.py: bunch of new tests for losing the
3867 buildslave at various points in the build, handling a slave that
3868 connects multiple times, and making sure we can interrupt a
3871 * buildbot/slave/bot.py (BuildSlave): make it possible to use
3872 something other than 'Bot' for the Bot object, to make certain
3873 test cases easier to write.
3874 (BuildSlave.waitUntilDisconnected): utility method for testing
3876 2004-11-30 Brian Warner <warner@lothar.com>
3878 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
3880 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
3881 argument, return a Deferred that always fires with True or False.
3882 I don't use an errback to indicate 'ping failed' so that callers
3883 are free to ignore the deferred without causing spurious errors in
3885 * buildbot/process/builder.py (BuilderControl.ping): implement it
3887 * buildbot/test/test_run.py (Status.testDisappear): test ping
3888 (Status.disappearSlave): fix it
3890 2004-11-30 Brian Warner <warner@lothar.com>
3892 * buildbot/interfaces.py (IBuildControl): add .stopBuild
3893 (IBuilderControl): add .getBuild(num), only works for the current
3894 build, of course, although it might be interesting to offer
3895 something for builds in the .waiting or .interlocked state.
3897 * buildbot/process/base.py (Build): have .stopBuild just do the
3898 interrupt, then let the build die by itself.
3899 (BuildControl): add .stopBuild, and add a point-event named
3900 'interrupt' just after the build so status viewers can tell that
3902 (BuilderControl): add .getBuild
3904 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
3905 stops when you kill it, good for testing
3906 (ShellCommand.interrupt): add a logfile named 'interrupt' which
3907 contains the 'reason' text.
3909 * buildbot/status/html.py: Add Stop Build button, if the build can
3910 still be stopped. Send a Redirect (to the top page) one second
3911 later, hopefully long enough for the interrupt to have an effect.
3912 Move make_row() up to top-level to share it between Stop Build and
3915 * buildbot/slave/commands.py: only kill the child process once
3917 * buildbot/test/test_run.py: add testInterrupt
3919 2004-11-29 Brian Warner <warner@lothar.com>
3921 * buildbot/process/base.py: Refactor command interruption. The
3922 Build is now responsible for noticing that the slave has gone
3923 away: Build.lostRemote() interrupts the current step and makes
3924 sure that no further ones will be started.
3926 * buildbot/process/builder.py: When the initial remote_startBuild
3927 message fails, log it: this usually indicates that the slave has
3928 gone away, but we don't really start paying attention until they
3929 fail to respond to the first step's command.
3931 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
3932 slave disconnect. Now sports a new interrupt() method. Error
3933 handling was simplified a lot by chaining deferreds, so
3934 remoteFailed/remoteComplete were merged into a single
3935 remoteComplete method (which can now get a Failure object).
3936 Likewise failed/finished were merged into just _finished.
3937 (BuildStep): Add interrupt(why) method, and if why is a
3938 ConnectionLost Failure then the step is failed with some useful
3941 * buildbot/slave/bot.py: stop the current command when the remote
3942 Step reference is lost, and when the slave is shut down.
3943 (Bot): make it a MultiService, so it can have children. Use
3944 stopService to tell when the slave is shutting down.
3945 (SlaveBuilder): make it a Service, and a child of the Bot. Add
3946 remote_interruptCommand (which asks the current SlaveCommand to
3947 stop but allows it to keep emitting status messages), and
3948 stopCommand (which tells it to shut up and die).
3950 * buildbot/slave/commands.py: make commands interruptible
3951 (ShellCommand.kill): factor out os.kill logic
3952 (Command): factor out setup()
3953 (Command.sendStatus): don't send status if .running is false, this
3954 happens when the command has been halted.
3955 (Command.interrupt): new method, used to tell the command to die
3956 (SlaveShellCommand): implement .interrupt
3957 (DummyCommand): implement .interrupt
3958 (SourceBase, etc): factor out setup(), don't continue substeps if
3961 * buildbot/status/builder.py: fix all waitUntilFinished() methods
3962 so they can be called after finishing
3964 * buildbot/test/test_run.py: new tests for disconnect behavior,
3965 refactor slave-shutdown routines, add different kinds of
3968 2004-11-27 Brian Warner <warner@lothar.com>
3970 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
3971 method to express ETA time like "2m45s" instead of "165 seconds"
3973 2004-11-24 Brian Warner <warner@lothar.com>
3975 * buildbot/test/test_vc.py (VC.testArch): unregister the test
3976 archive after the test completes, to avoid cluttering the user's
3977 'tla archives' listing with a bogus entry. Arch doesn't happen to
3978 provide any way to override the use of ~/.arch-params/, so there
3979 isn't a convenient way to avoid touching the setup of the user who
3981 (VC_HTTP.testArchHTTP): same
3983 2004-11-23 Brian Warner <warner@lothar.com>
3985 * buildbot/status/html.py (TextLog): split render() up into
3986 render_HEAD and render_GET. Use a Producer when sending log
3987 chunks, to reduce memory requirements and avoid sending huge
3988 non-Banana-able strings over web.distrib connections. Requires
3989 peeking under the covers of IStatusLog.
3990 (TextLog.resumeProducing): fix the "as text" link, handle client
3991 disconnects that occur while we're still sending old chunks.
3993 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
3994 use defer.succeed, not the non-existent defer.success
3995 (LogFile.waitUntilFinished): same
3996 (LogFile.subscribe): don't add watchers to a finished logfile
3998 * buildbot/__init__.py (version): bump to 0.6.1+ while between
4001 2004-11-23 Brian Warner <warner@lothar.com>
4003 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
4005 2004-11-23 Brian Warner <warner@lothar.com>
4007 * NEWS: update for the 0.6.1 release
4008 * MANIFEST.in: add new files
4010 * README (INSTALLATION): explain how to enable the extra VC tests
4012 * buildbot/status/builder.py (LogFile): add .runEntries at the class
4013 level to, so old pickled builds can be displayed ok
4015 2004-11-22 Brian Warner <warner@lothar.com>
4017 * NEWS: summarize updates since last release
4019 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
4020 Yoz Grahame. Closes SF#1050138.
4022 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
4025 * buildbot/process/step_twisted.py (Trial): update docs a bit
4027 * docs/factories.xhtml: fix Trial factory docs to match reality.
4030 * buildbot/process/factory.py (Trial.__init__): add args for
4031 randomly= and recurse=, making them available to instantiators
4032 instead of only to subclassers. Closes: SF#1049759.
4034 2004-11-15 Brian Warner <warner@lothar.com>
4036 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4037 try to teach the Quick factory to use multiple versions of python
4039 2004-11-12 Brian Warner <warner@lothar.com>
4041 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
4042 safer w32-compatible approach, and only use it on windows
4043 (BuildStatus.saveYourself): same
4045 2004-11-11 Brian Warner <warner@lothar.com>
4047 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
4048 it: one string merge per chunk. There are now separate .entries
4049 and .runEntries lists: when enumerating over all chunks, make sure
4051 * buildbot/test/test_status.py (Log): more tests
4053 * buildbot/status/builder.py (LogFile.addEntry): Merge string
4054 chunks together, up to 10kb per chunk. This ought to cut down on
4055 the CPU-burning overhead of large log files. Thanks to Alexander
4056 Staubo for spotting the problem.
4057 * buildbot/test/test_status.py (Log): tests for same
4059 2004-11-10 Brian Warner <warner@lothar.com>
4061 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
4062 header to outbound mail
4063 * buildbot/test/test_status.py (Mail.testBuild1): test for same
4065 2004-11-08 Brian Warner <warner@lothar.com>
4067 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
4068 can't do os.rename() onto an existing file, so catch the exception
4069 and unlink the target file first. This introduces a slight window
4070 where the existing file could be lost, but the main failure case
4071 (disk full) should still be handled safely.
4072 (BuildStatus.saveYourself): same
4074 * buildbot/changes/pb.py (ChangePerspective): use a configurable
4075 separator character instead of os.sep, because the filenames being
4076 split here are coming from the VC system, which can have a
4077 different pathname convention than the local host. This should
4078 help a buildmaster running on windows that uses a CVS repository
4079 which runs under unix.
4080 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
4082 * buildbot/process/step_twisted.py (Trial.createSummary): survive
4083 when there are no test failures to be parsed
4085 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
4086 instead of the unix-specific os.system("cp"), thanks to Elliot
4087 Murphy for this and the other buildbot-vs-windows catches.
4088 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
4090 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
4091 echo the command as it is run
4093 * setup.py: install sample.mk too, not just sample.cfg
4094 (scripts): install contrib/windows/buildbot.bat on windows
4096 2004-11-07 Brian Warner <warner@lothar.com>
4098 * buildbot/process/builder.py (Builder._detached): clear the
4099 self.currentBuild reference, otherwise the next build will be
4100 skipped because we think the Builder is already in use.
4102 * docs/examples/twisted_master.cfg: update to match current usage
4103 on the Twisted buildbot
4105 2004-10-29 Brian Warner <warner@lothar.com>
4107 * buildbot/status/mail.py (MailNotifier): fix typo in docs
4109 2004-10-28 Brian Warner <warner@lothar.com>
4111 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
4112 have separate doVCUpdate/doVCFull methods. Catch an update failure
4113 and respond by clobbering the source directory and re-trying. This
4114 will handle local changes (like replacing a file with a directory)
4115 that will cause CVS and SVN updates to fail.
4116 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
4118 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
4121 2004-10-19 Brian Warner <warner@lothar.com>
4123 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
4125 * buildbot/status/html.py (StatusResourceTestResults): display any
4126 TestResults that the Build might have
4127 (StatusResourceTestResult): and the logs for each TestResult
4128 (StatusResourceBuild): add link from the per-build page
4130 2004-10-15 Brian Warner <warner@lothar.com>
4132 * buildbot/process/step_twisted.py (Trial.createSummary): parse
4133 the 'problems' portion of stdout, add TestResults to our build
4134 * buildbot/test/test_twisted.py (Parse.testParse): test it
4136 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
4137 to retrieve a dict of accumulated test results
4138 (ITestResult): define what a single test result can do
4139 * buildbot/status/builder.py (TestResult): implement ITestResult
4140 (BuildStatus.getTestResults): retrieve dict of TestResults
4141 (BuildStatus.addTestResult): add TestResults
4142 * buildbot/test/test_status.py (Results.testAddResults): test it
4144 2004-10-14 Brian Warner <warner@lothar.com>
4146 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
4147 instead of os.system("rm -rf") for win32 portability
4149 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
4150 SignalMixin instead of starting/stopping the reactor, which is
4151 likely to cause problems with other tests
4153 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
4154 self.copyComplete() call. Yoz Grahame makes the catch.
4156 * contrib/windows/buildbot.bat: helper script to deal with path
4157 issues. Thanks to Yoz Grahame.
4159 * buildbot/master.py (BuildMaster.startService): don't register a
4160 SIGHUP handler if the signal module has no SIGHUP attribute.
4161 Apparently win32 does this.
4163 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
4165 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
4166 test if the reactor can't offer UNIX sockets
4168 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
4169 error introduced in the last commit. We really need that
4172 2004-10-12 Brian Warner <warner@lothar.com>
4174 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
4175 when describing a maildir source. Thanks to Stephen Davis.
4177 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
4180 * buildbot/scripts/runner.py (createMaster): install Makefile too
4181 (start): add --no_save to 'start' command
4182 * buildbot/scripts/sample.mk: simple convenience Makefile with
4183 start/stop/reload targets
4185 * buildbot/__init__.py (version): bump to 0.6.0+ while between
4188 2004-09-30 Brian Warner <warner@lothar.com>
4190 * setup.py: Releasing buildbot-0.6.0
4192 2004-09-30 Brian Warner <warner@lothar.com>
4194 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
4195 test_trial.py from the source tarball until support is complete.
4197 * NEWS: update for 0.6.0 release
4198 * buildbot/__init__.py (version): same
4201 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
4202 'source' command to tell users where to get the Buildbot source
4204 * docs/examples/*.cfg: update to modern standards
4206 * NEWS: update for release
4208 * buildbot/scripts/runner.py (createMaster): remove the
4209 -shutdown.tap stuff now that it isn't necessary
4211 (start): launch buildbot.tap, not buildbot-shutdown.tap
4214 * buildbot/status/mail.py (Domain): shorten class name
4215 (MailNotifier): if lookup= is a string, pass it to Domain()
4216 * buildbot/test/test_status.py (Mail.testBuild1): new class name
4217 (Mail.testBuild2): test the string-to-Domain shortcut
4218 (Mail.testMail): fix test
4221 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
4224 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
4225 more attributes on load
4226 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
4227 to accomodate the whole waterfall page at once, and the thrashing
4228 results in a lot of unnecessary loads
4229 (BuildStatus.saveYourself): use binary pickles, not fluffy text
4230 (BuilderStatus.saveYourself): same
4231 (BuilderStatus.eventGenerator): stop generating on the first missing
4232 build. We assume that saved builds are deleted oldest-first.
4233 (BuildStepStatus.__getstate__): .progress might not exist
4235 * buildbot/changes/changes.py (ChangeMaster): make it
4236 serializable, in $masterdir/changes.pck
4237 (ChangeMaster.stopService): save on shutdown
4238 * buildbot/master.py (BuildMaster.loadChanges): load at startup
4239 * buildbot/test/test_config.py: load Changes before config file
4242 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
4243 "Oh my god, you killed the command" header on a separate line
4245 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
4246 skip over corrupted build pickles
4247 (BuilderStatus.getFullBuildByNumber): same
4248 (BuilderStatus.eventGenerator): skip over unavailable builds
4249 (BuildStatus.saveYourself): save builds to a .tmp file first, then
4250 do an atomic rename. This prevents a corrupted pickle when some
4251 internal serialization error occurs.
4252 (BuilderStatus.saveYourself): same
4254 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
4255 the timeout for shell commands, it got lost somehow
4257 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
4258 run out of build steps, return the rest of the builder events
4260 * buildbot/interfaces.py (IBuilderControl.ping): add method
4262 * buildbot/process/builder.py (BuilderControl.ping): move
4263 slave-ping to BuilderControl, and fix the failure case in the
4264 process (Event.finish() is the verb, Event.finished is the noun).
4266 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
4267 through the BuilderControl instead of the BuilderStatus
4268 (EventBox): add adapter for builder.Event, allowing builder events to
4269 be displayed in the waterfall display
4271 * buildbot/master.py (BotMaster.stopService): add a 'master
4272 shutdown' event to the builder's log
4273 (BuildMaster.startService): and a 'master started' on startup
4275 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
4276 builder events into the BuildStep event stream
4277 (Status.builderAdded): add a 'builder created' event
4280 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
4281 command to announce the completion of a running build
4282 (IrcStatusBot.command_FORCE): announce when the build finishes
4284 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
4285 don't evict unfinished builds from the cache: they must stay in
4286 the full-cache until their logfiles have stopped changing. Make
4287 sure the eviction loop terminates if an unfinished build was hit.
4288 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
4289 This lets exceptions be dumped in an email status message. Really
4290 we need LogFiles which contain both text and HTML, instead of two
4292 (BuildStatus.__getstate__): handle self.finished=False
4293 (Status.builderAdded): if the pickle is corrupted, abandon the
4294 history and create a new BuilderStatus object.
4296 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
4297 self.progress attribute, helped one test which doesn't fully set
4298 up the Build object.
4300 * buildbot/interfaces.py (IStatusLogStub): split out some of the
4301 IStatusLog methods into an Interface that is implemented by "stub"
4302 logs, for which all the actual text chunks are on disk (in the
4303 pickled Build instance). To show the log contents, you must first
4304 adapt the stub log to a full IStatusLog object.
4306 * buildbot/status/builder.py (LogFileStub): create separate stub
4307 log objects, which can be upgraded to a real one if necessary.
4308 (LogFile): make them persistable, and let them stubify themselves
4310 (BuildStepStatus): same
4312 (BuildStatus.saveYourself): save the whole build out to disk
4313 (BuilderStatus): make it persistable
4314 (BuilderStatus.saveYourself): save the builder to disk
4315 (BuilderStatus.addFullBuildToCache): implement two caches which
4316 hold Build objects: a small one which holds full Builds, and a
4317 larger one which holds "stubbed" Builds (ones with their LogFiles
4318 turned into LogFileStubs). This reduces memory usage by the
4319 buildmaster by not keeping more than a few (default is 2) whole
4320 build logs in RAM all the time.
4321 (BuilderStatus.getBuild): rewrite to pull from disk (through the
4323 (BuilderStatus.eventGenerator): rewrite since .builds went away
4324 (BuilderStatus.buildStarted): remove the .builds array. Add the
4325 build to the "full" cache when it starts.
4326 (BuilderStatus._buildFinished): save the build to disk when it
4328 (Status): give it a basedir (same as the BuildMaster's basedir)
4329 where the builder pickles can be saved
4330 (Status.builderAdded): create the BuilderStatus ourselves, by
4331 loading a pickle from disk (or creating a new instance if there
4332 was none on disk). Return the BuilderStatus so the master can glue
4333 it into the new Builder object.
4335 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
4336 all BuilderStatuses to save themselves out to disk. This is in
4337 lieu of saving anything important in the main Application pickle
4338 (the -shutdown.tap file).
4339 (BuildMaster.__init__): give Status() a basedir for its files
4340 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
4341 to get the BuilderStatus, then give it to the Builder (instead of
4342 doing it the other way around). It's ok if the status announces
4343 the new Builder before it's really ready, as the outside world can
4344 only see the BuilderStatus object anyway (and it is ready before
4345 builderAdded returns). Use the builder's "builddir" (which
4346 normally specifies where the slave will run the builder) as the
4347 master's basedir (for saving serialized builds).
4349 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
4350 coerce the logfile to IStatusLog before trying to get the text
4351 chunks out of it. This will pull the full (non-stubified) Build in
4352 from disk if necessary.
4353 (TextLog): fix the adapter registration
4355 * buildbot/test/test_control.py (Force.setUp): create the basedir
4356 * buildbot/test/test_web.py: same
4357 * buildbot/test/test_vc.py (SetupMixin.setUp): same
4358 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
4359 * buildbot/test/test_run.py (Run.testMaster): same
4360 (Status.setUp): same
4362 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
4364 * buildbot/status/html.py (Waterfall.__init__): store actual
4365 allowForce flag passed in rather than using True for everyone;
4366 make sure setting it to False doesn't cause a NameError
4368 (StatusResourceBuilder.__init__) add the builder name to the page
4370 (StatusResourceBuilder.body) move HTML generation for a name/value
4371 row into a helper method (StatusResourceBuilder.make_row); only
4372 generate the "Force Build" form if allowForce was True and the
4373 slave is connected. Use class attributes in the generated HTML to
4374 spread a little CSS-joy.
4376 2004-09-28 Brian Warner <warner@lothar.com>
4378 * buildbot/process/step_twisted.py (Trial.createSummary): fix
4379 warning-scanner to not ignore things like
4380 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
4382 * buildbot/status/html.py (StatusResource.control): add some
4383 class-level values for .control in an attempt to make upgrading
4386 * buildbot/util.py (ComparableMixin): survive missing attributes,
4387 such as when a class is modified and we're comparing old instances
4390 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
4391 failure handling, remove a redundant try/except block. Don't
4392 return the full traceback to the IRC channel.
4393 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
4394 error messages. Get ETA properly.
4396 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
4397 the reason, since (at least) IRC message will have <> in them.
4398 (StatusResourceBuilder.__init__): take an IBuilderControl
4399 (StatusResourceBuilder.force): use the IBuilderControl we get in
4400 the constructor instead of trying to make our own. Catch the
4401 new exceptions and ignore them for now (until we make an
4402 intermediate web page where we could show the error message)
4403 (StatusResource): create with an IControl, use it to give an
4404 IBuilderControl to all children
4405 (Waterfall): take an allowForce= option, pass an IControl object
4406 to StatusResource if it is True
4408 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
4410 * buildbot/master.py (BotPerspective.perspective_forceBuild):
4411 catch new exceptions and return string forms
4413 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
4414 * buildbot/process/builder.py (Builder.forceBuild): raise them
4415 * buildbot/test/test_control.py (Force.testNoSlave): new test
4416 (Force.testBuilderInUse): same
4419 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
4421 * buildbot/test/test_run.py: use IControl
4422 * buildbot/test/test_vc.py: same
4424 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
4425 to use IControl. Still offline.
4426 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
4428 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
4429 who=None so periodic builds don't send out status mail
4430 (Builder.forceBuild): include reason in the log message
4431 (BuilderControl.forceBuild): rename 'name' to 'who'
4433 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
4434 'who' parameter, but make it None by default so builds forced by
4435 slave admins don't cause status mail to be sent to anybody
4436 (BotMaster.forceBuild): same. this method is deprecated.
4437 (DebugPerspective.perspective_forceBuild): same, use IControl.
4438 (DebugPerspective.perspective_fakeChange): use IControl..
4439 (Dispatcher.requestAvatar): .. so don't set .changemaster
4441 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
4442 parameter to avoid confusion with the name of the builder
4445 * buildbot/status/mail.py: refine comment about needing 2.3
4447 * buildbot/status/html.py: move all imports to the top
4449 * buildbot/test/test_control.py: test new interfaces
4450 * buildbot/test/test_run.py (Status): handle new interfaces
4451 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
4453 * buildbot/process/base.py (BuildControl): implement IBuildControl
4454 and its lonely getStatus() method
4456 * buildbot/process/builder.py (BuilderControl): implement
4457 IBuilderControl, obtained by adapting the Builder instance
4458 (Builder.startBuild): return a BuilderControl instead of a
4459 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
4460 accomplish the same thing.
4462 * buildbot/master.py: move all import statements to the top
4463 (Control): implement IControl, obtained by adapting the
4464 BuildMaster instance.
4466 * buildbot/interfaces.py: add IControl, IBuilderControl, and
4467 IBuildControl. These are used to force builds. Eventually they
4468 will provide ways to reconfigure the Builders, pause or abandon a
4469 Build, and perhaps control the BuildMaster itself.
4471 2004-09-26 Brian Warner <warner@lothar.com>
4473 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
4474 ends up comparing us against something without a .__class__
4476 2004-09-24 Brian Warner <warner@lothar.com>
4478 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
4481 * Makefile: add 'deb-snapshot' target, to create a timestamped
4484 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
4486 2004-09-23 Brian Warner <warner@lothar.com>
4488 * buildbot/__init__.py (version): move version string here
4489 * setup.py: get version string from buildbot.version
4490 * buildbot/status/html.py (WaterfallStatusResource.body): add
4491 buildbot version to the page footer
4492 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
4495 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
4496 slaves, let the second know where the first one is coming from
4497 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
4498 see our exceptions. It would be nice if there were a way to just
4499 send them the exception type and value, not the full traceback.
4502 * buildbot/status/mail.py (MailNotifier): add a new argument
4503 sendToInterestedUsers=, which can be set to False to disable the
4504 usual send-to-blamelist behavior.
4505 (top): handle python-2.2 which has no email.MIMEMultipart
4506 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
4507 (MailNotifier.disownServiceParent): unsubscribe on removal
4509 * buildbot/test/test_status.py (Mail.testBuild2): test it
4512 * buildbot/status/progress.py (Expectations.wavg): tolerate
4513 current=None, which happens when steps start failing badly
4514 * buildbot/test/test_status.py (Progress.testWavg): test for it
4516 * buildbot/process/step.py (SVN.startVC): when the (old) slave
4517 doesn't understand args['revision'], emit a warning instead of
4518 bailing completely. Updating to -rHEAD is probably close enough.
4520 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
4522 * buildbot/test/test_status.py: at least import bb.status.client
4523 even if we don't have any test coverage for it yet
4525 * contrib/svn_buildbot.py: don't require python2.3
4526 (main): wait, do require it (for sets.py), but explain how to
4527 make it work under python2.2
4529 2004-09-23 Brian Warner <warner@lothar.com>
4531 * contrib/svn_buildbot.py: include the revision number in the Change
4533 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
4534 using util.now() because FreshCVS is a realtime service
4536 * buildbot/status/event.py: delete dead code
4537 * buildbot/process/step.py: don't import dead Event class
4538 * buildbot/process/step_twisted.py: same
4539 * buildbot/status/builder.py: same
4540 * buildbot/status/client.py: same
4542 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
4544 * buildbot/changes/changes.py (Change): set .when from an __init__
4545 argument (which defaults to now()), rather than having
4546 ChangeMaster.addChange set it later.
4547 (ChangeMaster.addChange): same
4549 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
4550 (parseSyncmail): same. Just use util.now() for now.
4551 (parseBonsaiMail): parse the timestamp field for when=
4553 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
4554 instead of setting .when after the fact
4558 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
4559 results when the target project uses retrial. Still under
4561 * buildbot/test/test_trial.py: same
4563 2004-09-21 Brian Warner <warner@lothar.com>
4565 * buildbot/status/mail.py (MailNotifier.__init__): include
4566 success/warnings/failure in the Subject line
4567 (MailNotifier.buildMessage): add the buildbot's URL to the body,
4568 use step.logname for the addLogs=True attachment filenames
4569 * buildbot/test/test_status.py (Mail): test Subject lines
4570 (Mail.testLogs): test attachment filenames
4572 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
4573 accept a 'who' argument from the debug tool
4574 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
4575 * contrib/debug.glade: add text box to set 'who'
4577 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
4578 .getBuilderName with .getBuilder().getName(), more flexible
4579 (IStatusLog.getName): logs have short names, but you can prefix
4580 them with log.getStep().getName() to make them more useful
4581 * buildbot/status/builder.py: same
4582 * buildbot/status/client.py: same
4583 * buildbot/status/html.py: same
4584 * buildbot/test/test_run.py (Status.testSlave): same
4585 * buildbot/process/step.py: tweak logfile names
4587 * buildbot/status/mail.py (MailNotifier): add lookup, change
4588 argument to extraRecipients. The notifier is now aimed at sending
4589 mail to the people involved in a particular build, with additional
4590 constant recipients as a secondary function.
4592 * buildbot/test/test_status.py: add coverage for IEmailLookup,
4593 including slow-lookup and failing-lookup. Make sure the blamelist
4594 members are included.
4596 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
4597 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
4598 (IBuildStatus.getInterestedUsers): new method
4599 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
4600 * buildbot/status/client.py (remote_getResponsibleUsers): same
4601 * buildbot/status/html.py (StatusResourceBuild.body): same
4602 * buildbot/test/test_run.py (Status.testSlave): same
4604 2004-09-20 Brian Warner <warner@lothar.com>
4606 * docs/users.xhtml: update concepts
4608 * Makefile: add a convenience makefile, for things like 'make
4609 test'. It is not included in the source tarball.
4611 2004-09-16 Brian Warner <warner@lothar.com>
4613 * NEWS: mention /usr/bin/buildbot, debian/*
4615 * debian/*: add preliminary debian packaging. Many thanks to
4616 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
4617 it considerably since it left their hands, I am responsible for
4618 all breakage that's resulted.
4620 * bin/buildbot: create a top-level 'buildbot' command, to be
4621 installed in /usr/bin/buildbot . For now it's just a simple
4622 frontend to mktap/twistd/kill, but eventually it will be the entry
4623 point to the 'try' command and also a status client. It is also
4624 intended to support the upcoming debian-packaging init.d scripts.
4625 * buildbot/scripts/runner.py: the real work is done here
4626 * buildbot/scripts/__init__.py: need this too
4627 * buildbot/scripts/sample.cfg: this is installed in new
4628 buildmaster directories
4629 * setup.py: install new stuff
4631 2004-09-15 Brian Warner <warner@lothar.com>
4633 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
4634 'file:' schema (the version shipped with OS-X was built without the
4636 (SetupMixin.tearDown): stop the goofy twisted.web timer which
4637 updates the log-timestamp, to make sure it isn't still running after
4640 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
4641 values to the config file.
4642 * docs/examples/hello.cfg: add examples
4643 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
4644 * buildbot/status/builder.py (Status.getProjectURL): implement them
4645 * buildbot/master.py (BuildMaster.loadConfig): set them from config
4646 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
4647 * buildbot/status/html.py (WaterfallStatusResource): display them
4650 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
4651 certain error cases don't suffer a secondary exception.
4652 (top): Skip tests if the corresponding VC tool is not installed.
4654 * buildbot/process/factory.py (Trial): introduce separate
4655 'buildpython' and 'trialpython' lists, since trialpython=[] is
4656 what you want to invoke /usr/bin/python, whereas ./setup.py is
4657 less likely to be executable. Add env= parameter to pass options
4658 to test cases (which is how I usually write tests, I don't know if
4659 anyone else does it this way).
4661 * buildbot/process/step_twisted.py (Trial): handle python=None.
4662 Require 'testpath' be a string, not a list. Fix tests= typo.
4663 (Trial.start): sanity-check any PYTHONPATH value for stringness.
4665 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
4666 way to deal with the possibility of removing the disconnect notify
4668 (CVS): add a 'login' parameter to give a password to 'cvs login',
4669 commonly used with pserver methods (where pw="" or pw="guest")
4671 * buildbot/slave/commands.py (SourceBase): move common args
4672 extraction and setup() to __init__, so everything is ready by the
4673 time setup() is called
4674 (CVS.start): call 'cvs login' if a password was supplied
4675 (ShellCommand): special-case PYTHONPATH: prepend the master's
4676 value to any existing slave-local value.
4678 * buildbot/process/builder.py (Builder.updateBigStatus): if we
4679 don't have a remote, mark the builder as Offline. This whole
4680 function should probably go away and be replaced by individual
4682 (Builder.buildFinished): return the results to the build-finished
4683 deferred callback, helps with testing
4685 2004-09-14 Brian Warner <warner@lothar.com>
4687 * buildbot/test/test_vc.py: put all the repositories needed to run
4688 the complete tests into a single small (1.3MB) tarball, so I can
4689 make that tarball available on the buildbot web site. Test HTTP
4690 access (for Arch and Darcs) by spawning a temporary web server
4691 while the test runs.
4693 * docs/users.xhtml: new document, describe Buildbot's limited
4694 understanding of different human users
4696 * buildbot/test/test_vc.py: rearrange test cases a bit
4698 * buildbot/process/step_twisted.py (Trial): handle testpath=
4699 * buildbot/process/factory.py (Trial): update to use step.Trial
4701 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
4703 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
4704 the overall build text (which gives you 'failed 2 tests' rather
4706 (BuildStepStatus.text2): default to [], not None
4708 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
4711 2004-09-12 Brian Warner <warner@lothar.com>
4713 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
4714 log the whole exception if it's just an AttributeError (old slave)
4716 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
4717 so (e.g.) sub-commands can be run in the right directory.
4718 (ShellCommand.start): accept an optional errorMessage= argument
4719 to make life easier for SVN.start
4720 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
4722 (ShellCommand.start): move ['dir'] compatibility hack..
4723 (RemoteShellCommand.start): .. to here so everyone can use it
4725 * buildbot/process/step_twisted.py (Trial): use .workdir
4727 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
4728 text displayed when debuild fails completely
4729 (Trial): snarf _trial_temp/test.log from the slave and display it
4731 2004-09-11 Brian Warner <warner@lothar.com>
4733 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
4735 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
4736 set to 'twisted', so --recurse can find twisted/web/test/*, etc
4738 * buildbot/process/step.py (ShellCommand): call .createSummary
4739 before .evaluateCommand instead of the other way around. This
4740 makes it slightly easier to count warnings and then use that to
4741 set results=WARNINGS
4742 * buildbot/process/step_twisted.py: cosmetic, swap the methods
4744 * buildbot/process/base.py (Build.buildFinished): update status
4745 before doing progress. It's embarrassing for the build to be stuck
4746 in the "building" state when an exceptions occurs elsewhere..
4748 * buildbot/status/progress.py (Expectations.expectedBuildTime):
4749 python2.2 doesn't have 'sum'
4751 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
4752 to prevent clients from accidentally sorting it
4754 * buildbot/master.py (Manhole): add username/password
4755 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
4756 c['manholePort'], deprecate old usage
4757 * docs/config.xhtml: document c['manhole']
4758 * docs/examples/hello.cfg: show example of using a Manhole
4761 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
4762 pretend the slave is up to date
4764 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
4765 the module, overlaps with 'log', the local variable
4767 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
4769 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
4770 new method to let Steps find out the version of their
4771 corresponding SlaveCommand.
4772 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
4773 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
4774 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
4776 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
4777 (Arch.startVC): same
4778 (P4Sync.startVC): same
4780 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
4781 Deferred so we can catch errors in remote_startCommand
4782 (RemoteShellCommand.start): same
4784 * docs/examples/twisted_master.cfg: update sample config file
4786 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
4787 after connectionMade() is called, not before. Close stdin at that
4790 * buildbot/process/process_twisted.py: update to use Trial, clean
4791 up argument passing (move to argv arrays instead of string
4794 * buildbot/process/step_twisted.py (Trial): new step to replace
4795 RunUnitTests, usable by any trial-using project (not just
4796 Twisted). Arguments have changed, see the docstring for details.
4798 * buildbot/process/base.py (Build.startBuild): this now returns a
4799 Deferred. Exceptions that occur during setupBuild are now
4800 caught better and lead to fewer build_status weirdnesses, like
4801 finishing a build that was never started.
4802 (Build.buildFinished): fire the Deferred instead of calling
4803 builder.buildFinished directly. The callback argument is this
4804 Build, everything else can be extracted from it, including the
4805 new build.results attribute.
4806 * buildbot/process/builder.py (Builder.startBuild): same
4807 (Builder.buildFinished): same, extract results from build
4809 * buildbot/process/step.py (ShellCommands): remove dead code
4811 2004-09-08 Brian Warner <warner@lothar.com>
4813 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
4814 doesn't try to use the leftover patched workdir
4815 (SourceStamp): test source-stamp computation for CVS and SVN
4817 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
4818 patched workdir ('touch .buildbot-patched') so we don't try to
4820 (SourceBase.start): add ['revision'] for all Source steps
4821 (CVS): change args: use ['branch'] for -r, remove ['files']
4822 (CVS.buildVC): fix revision/branch stuff
4823 (SVN): add revision stuff
4825 * buildbot/process/step.py (BuildStep.__init__): reject unknown
4826 kwargs (except 'workdir') to avoid silent spelling errors
4827 (ShellCommand.__init__): same
4828 (Source): new base class for CVS/SVN/etc. Factor out everything
4829 common, add revision computation (perform the checkout with a -D
4830 DATE or -r REVISION that gets exactly the sources described by the
4831 last Change), overridable with step.alwaysUseLatest. Add patch
4832 handling (build.getSourceStamp can trigger the use of a base
4833 revision and a patch).
4834 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
4835 * docs/steps.xhtml: update docs
4836 * docs/source.xhtml: mention .checkoutDelay
4837 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
4839 * buildbot/process/base.py (Build.setSourceStamp): add a
4840 .sourceStamp attribute to each Build. If set, this indicates that
4841 the build should be done with something other than the most
4842 recent source tree. This will be used to implement "try" builds.
4843 (Build.allChanges): new support method
4844 (Build.lastChangeTime): remove, functionality moved to Source steps
4845 (Build.setupBuild): copy the Step args before adding ['workdir'],
4846 to avoid modifying the BuildFactory (and thus triggering spurious
4850 * buildbot/status/html.py: rename s/commits/changes/
4851 (StatusResourceChanges): same
4852 (CommitBox.getBox): same, update URL
4853 (WaterfallStatusResource): same
4854 (StatusResource.getChild): same
4856 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
4857 * contrib/debug.glade: add optional 'revision' to the fakeChange
4859 * buildbot/changes/changes.py (html_tmpl): display .revision
4860 (ChangeMaster.addChange): note .revision in log
4861 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
4862 accept a ['revision'] attribute
4864 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
4866 * buildbot/master.py (BotMaster.getPerspective): update the
4867 .connected flag in SlaveStatus when it connects
4868 (BotMaster.detach): and when it disconnects
4869 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
4870 (BuildMaster.loadConfig_Builders): walk old list correctly
4872 * buildbot/test/test_config.py: fix prefix= usage
4874 2004-09-06 Brian Warner <warner@lothar.com>
4878 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
4879 poll a P4 depot looking for recent changes. Thanks to Dave
4880 Peticolas for the contribution. Probably needs some testing after
4883 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
4884 requires manual client setup for each buildslave. Rather
4885 experimental. Thanks again to Dave Peticolas.
4886 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
4888 * buildbot/changes/changes.py (Change): add a .revision attribute,
4889 which will eventually be used to generate source-stamp values.
4891 * buildbot/process/step.py (RemoteCommand.start): use
4892 notifyOnDisconnect to notice when we lose the slave, then treat it
4893 like an exception. This allows LogFiles to be closed and the build
4894 to be wrapped up normally. Be sure to remove the disconnect
4895 notification when the step completes so we don't accumulate a
4896 bazillion such notifications which will fire weeks later (when the
4897 slave finally disconnects normally). Fixes SF#915807, thanks to
4898 spiv (Andrew Bennetts) for the report.
4899 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
4900 really isn't Logged- specific
4901 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
4902 header, since it's almost always going to be appended to an
4904 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
4905 update test to handle use of notifyOnDisconnect
4907 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
4908 don't clear .ETA and .currentBuild when going offline, let the
4909 current build clean up after itself
4911 * buildbot/process/builder.py (Builder.detached): wait a moment
4912 before doing things like stopping the current build, because the
4913 current step will probably notice the disconnect and cleanup the
4915 * buildbot/test/test_run.py (Status.tearDown): update test to
4916 handle asynchronous build-detachment
4918 * buildbot/process/base.py (Build.stopBuild): minor shuffles
4920 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
4921 hush a debug message
4923 2004-09-05 Brian Warner <warner@lothar.com>
4925 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
4926 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
4927 kernels do this: the fcntl module has the F_NOTIFY constant, but
4928 the kernel itself doesn't support the operation. Thanks to Olly
4929 Betts for spotting the problem.
4931 * buildbot/process/step.py (Darcs): new source-checkout command
4932 (Arch): new source-checkout command
4933 (todo_P4): fix constructor syntax, still just a placeholder
4934 * buildbot/test/test_vc.py (VC.testDarcs): test it
4935 (VC.testDarcsHTTP): same, via localhost HTTP
4937 (VC.testArchHTTP): same
4938 * NEWS: mention new features
4940 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
4941 which tells the step to stash stdout text locally (in .stdout).
4942 Slave-side Commands can use this to make decisions based upon the
4943 output of the the ShellCommand (not just the exit code).
4944 (Darcs): New source-checkout command
4945 (Arch): New source-checkout command, uses .keepStdout in one place
4946 where it needs to discover the archive's default name.
4948 * docs/steps.xhtml: Document options taken by Darcs and Arch.
4949 * docs/source.xhtml: add brief descriptions of Darcs and Arch
4950 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
4952 * buildbot/process/step.py (ShellCommand.describe): add an
4953 alternate .descriptionDone attribute which provides descriptive
4954 text when the step is complete. .description can be ["compiling"],
4955 for use while the step is running, then .descriptionDone can be
4956 ["compile"], used alone when the step succeeds or with "failed" when
4957 it does not. Updated other steps to use the new text.
4958 * buildbot/process/step_twisted.py: same
4959 * buildbot/test/test_run.py: update tests to match
4961 2004-08-30 Brian Warner <warner@lothar.com>
4963 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
4964 (CVS.__init__): send 'patch' argument to slave
4965 (CVS.start): don't create the LoggedRemoteCommand until start(),
4966 so we can catch a .patch added after __init__
4967 (SVN.__init__): add 'patch' to SVN too
4970 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
4971 argument, to let commands push data into the process' stdin pipe.
4972 Move usePTY to a per-instance attribute, and clear it if 'stdin'
4973 is in use, since closing a PTY doesn't really affect the process
4974 in the right way (in particular, I couldn't run /usr/bin/patch
4976 (SourceBase.doPatch): handle 'patch' argument
4978 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
4981 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
4982 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
4984 * buildbot/master.py (BotPerspective.got_commands): get command
4985 versions from slave, give to each builder
4986 * buildbot/process/builder.py (Builder.attached): stash slave
4987 command versions in .remoteCommands
4989 * docs/steps.xhtml: bring docs in-line with reality
4991 * buildbot/process/step.py (CVS.__init__): more brutal
4992 compatibility code removal
4993 (SVN.__init__): same
4995 * buildbot/slave/commands.py (SlaveShellCommand): update docs
4996 (SlaveShellCommand.start): require ['workdir'] argument, remove
4997 the ['dir'] fallback (compatibility will come later)
4998 (SourceBase): update docs
4999 (SourceBase.start): remove ['directory'] fallback
5002 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
5003 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5004 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
5006 * buildbot/process/step.py (RemoteShellCommand.__init__): add
5007 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
5008 code.. I will figure out 0.5.0-compatibility hooks later)
5010 2004-08-30 Brian Warner <warner@lothar.com>
5012 * buildbot/process/process_twisted.py: rewrite in terms of new
5013 BuildFactory base class. It got significantly shorter. Yay
5016 * buildbot/process/step_twisted.py (HLint.start): fix to make it
5017 work with the new "self.build isn't nailed down until we call
5018 step.start()" scheme: specifically, __init__ is called before the
5019 build has decided on which Changes are going in, so we don't scan
5020 build.allFiles() for .xhtml files until start()
5021 (HLint.commandComplete): use getText(), not getStdout()
5022 (RunUnitTests.start): same: don't use .build until start()
5023 (RunUnitTests.describe): oops, don't report (None) when using
5025 (RunUnitTests.commandComplete): use getText()
5026 (RunUnitTests.createSummary): same
5027 (BuildDebs.commandComplete): same
5029 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
5030 set args['command'] until start(), since our BuildStep is allowed
5031 to change their mind up until that point
5032 (TreeSize.commandComplete): use getText(), not getStdout()
5034 * docs/examples/twisted_master.cfg: update to current standards
5036 * docs/factories.xhtml: update
5037 * buildbot/process/factory.py: implement all the common factories
5038 described in the docs. The Trial factory doesn't work yet, and
5039 I've probably broken all the process_twisted.py factories in the
5040 process. There are compatibility classes left in for things like
5041 the old BasicBuildFactory, but subclasses of them are unlikely to
5043 * docs/examples/glib_master.cfg: use new BuildFactories
5044 * docs/examples/hello.cfg: same
5046 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
5047 explicit 'workdir' args
5049 * buildbot/process/base.py (BuildFactory): move factories to ..
5050 * buildbot/process/factory.py (BuildFactory): .. here
5051 * buildbot/process/process_twisted.py: handle move
5052 * buildbot/test/test_config.py: same
5053 * buildbot/test/test_run.py: same
5054 * buildbot/test/test_steps.py: same
5055 * buildbot/test/test_vc.py: same
5056 * docs/factories.xhtml: same
5058 * NEWS: mention config changes that require updating master.cfg
5060 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
5061 argument to all steps that weren't given one already, pointing at
5062 the "build/" directory.
5064 * docs/examples/hello.cfg: remove explicit 'workdir' args
5066 * docs/factories.xhtml: document standard BuildFactory clases,
5067 including a bunch which are have not yet been written
5069 2004-08-29 Brian Warner <warner@lothar.com>
5071 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
5072 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
5073 buildbot.status.builder so they aren't quite so internal
5074 * buildbot/process/base.py, buildbot/process/builder.py: same
5075 * buildbot/process/maxq.py, buildbot/process/step.py: same
5076 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
5077 * buildbot/status/mail.py, buildbot/test/test_run.py: same
5078 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
5080 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
5081 to handle new getLogs()-returns-list behavior
5082 (StatusResourceBuildStep.getChild): same
5083 (StepBox.getBox): same
5084 (WaterfallStatusResource.phase0): same
5086 * docs/source.xhtml: document how Buildbot uses version-control
5087 systems (output side: how we get source trees)
5088 * docs/changes.xhtml: rename from sources.xhtml, documents VC
5089 systems (input side: how we learn about Changes)
5091 * buildbot/master.py (Manhole): use ComparableMixin
5092 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
5093 * buildbot/changes/mail.py (MaildirSource): same
5094 * buildbot/status/client.py (PBListener): same
5095 * buildbot/status/html.py (Waterfall): same
5096 * buildbot/status/words.py (IRC): same
5098 * NEWS: start describing new features
5100 * buildbot/status/mail.py (MailNotifier): finish implementation.
5101 The message body is still a bit sparse.
5102 * buildbot/test/test_status.py (Mail): test it
5104 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
5105 and __hash__ methods I wind up adding everywhere. Specifically
5106 intended to support the buildbot config-file update scheme where
5107 we compare, say, the old list of IStatusTargets against the new
5108 one and don't touch something which shows up on both lists.
5109 * buildbot/test/test_util.py (Compare): test case for it
5111 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
5112 return a list instead of a dict
5113 (IBuildStepStatus.getLogs): same. The idea is that steps create
5114 logs with vaguely unique names (although their uniqueness is not
5115 guaranteed). Thus a compilation step should create its sole
5116 logfile with the name 'compile', and contribute it to the
5117 BuildStatus. If a step has two logfiles, try to create them with
5118 different names (like 'test.log' and 'test.summary'), and only
5119 contribute the important ones to the overall BuildStatus.
5120 * buildbot/status/builder.py (Event.getLogs): same
5121 (BuildStepStatus): fix default .text and .results
5122 (BuildStepStatus.addLog): switch to list-like .getLogs()
5123 (BuildStepStatus.stepFinished): same
5124 (BuildStatus.text): fix default .text
5125 (BuildStatus.getLogs): temporary hack to return all logs (from all
5126 child BuildStepStatus objects). Needs to be fixed to only report
5127 the significant ones (as contributed by the steps themselves)
5128 * buildbot/test/test_run.py: handle list-like .getLogs()
5129 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
5131 2004-08-28 Brian Warner <warner@lothar.com>
5133 * buildbot/process/builder.py (Builder.attached): serialize the
5134 attachment process, so the attach-watcher isn't called until the
5135 slave is really available. Add detached watchers too, which makes
5138 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
5140 * buildbot/test/test_swap.py: remove dead code
5142 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
5143 (ShellCommand.start): treat errors in _startCommand/spawnProcess
5144 sort of as if the command being run exited with a -1. There may
5145 still be some holes in this scheme.
5146 (CVSCommand): add 'revision' tag to the VC commands, make sure the
5147 -r option appears before the module list
5148 * buildbot/process/step.py (CVS): add 'revision' argument
5150 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
5151 when sending updates or stepComplete messages to the master, since
5152 we don't currently care whether they arrive or not. When we revamp
5153 the master/slave protocol to really resume interrupted builds,
5154 this will need revisiting.
5155 (lostRemote): remove spurious print
5157 * buildbot/master.py (BotPerspective.attached): serialize the
5158 new-builder interrogation process, to make testing easier
5159 (BotMaster.waitUntilBuilderDetached): convenience function
5161 * buildbot/status/builder.py (BuilderStatus): prune old builds
5162 (BuildStatus.pruneSteps): .. and steps
5163 (BuildStepStatus.pruneLogs): .. and logs
5164 (BuilderStatus.getBuild): handle missing builds
5165 * buildbot/status/html.py (StatusResourceBuild.body): display build
5166 status in the per-build page
5167 (BuildBox.getBox): color finished builds in the per-build box
5169 2004-08-27 Brian Warner <warner@lothar.com>
5171 * buildbot/status/mail.py (MailNotifier): new notification class,
5174 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
5175 variants of a common base class which handles all the mode= logic
5177 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
5179 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
5181 2004-08-26 Brian Warner <warner@lothar.com>
5183 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
5186 * buildbot/test/test_run.py: update to new Logfile interface, new
5187 buildbot.slave modules
5188 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
5190 * MANIFEST.in: new sample config file
5191 * docs/examples/hello.cfg: same
5193 * buildbot/process/step_twisted.py: remove dead import
5195 * buildbot/process/step.py (RemoteCommand.run): catch errors
5197 (RemoteCommand.remote_update): ignore updates that arrive after
5199 (RemoteCommand.remote_complete): ignore duplicate complete msgs
5200 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
5201 the responsibilities of the subclass's methods
5202 (BuildStep.failed): catch errors during failure processing
5203 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
5204 (CVS): move to a mode= argument (described in docstring), rather
5205 than the ungainly clobber=/export=/copydir= combination.
5206 (SVN): add mode= functionality to SVN too
5207 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
5209 * buildbot/process/base.py (Build.startNextStep): catch errors
5210 during s.startStep()
5212 * buildbot/clients/base.py: update to new PB client interface.
5213 gtkPanes is still broken
5215 * buildbot/bot.py, buildbot/slavecommand.py: move to..
5216 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
5217 * setup.py: add buildbot.slave module
5218 * buildbot/bb_tap.py: handle move
5219 * buildbot/slave/registry.py: place to register commands, w/versions
5220 * buildbot/slave/bot.py: major simplifications
5221 (SlaveBuilder.remote_startCommand): use registry for slave commands,
5222 instead of a fixed table. Eventually this will make the slave more
5223 extensible. Use 'start' method on the command, not .startCommand.
5224 Fix unsafeTracebacks handling (I think).
5225 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
5226 helper class with a .start method that returns a Deferred.
5227 SlaveShellCommand is the form reached by the buildmaster. Commands
5228 which use multiple ShellCommands can just chain them as Deferreds,
5229 with some helper methods in Command (_abandonOnFailure and
5230 _checkAbandoned) to bail on rc!=0.
5231 (CVSCommand): prefer new mode= argument
5232 (SVNFetch): add mode= argument
5234 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
5235 put a useful reason string on the build
5237 * buildbot/status/builder.py (LogFile): do LogFile right: move the
5238 core functionality into an IStatusLog object
5239 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
5240 * buildbot/status/html.py (TextLog): HTML-rendering goes here
5241 (StatusResourceBuild.body): use proper accessor methods
5242 * buildbot/status/client.py (RemoteLog): PB-access goes here
5243 (StatusClientPerspective.perspective_subscribe): add "full" mode,
5244 which delivers log contents too
5245 (PBListener.__cmp__): make PBListeners comparable, thus removeable
5246 * buildbot/status/event.py: remove old Logfile completely
5248 * buildbot/interfaces.py (IStatusLog.subscribe): make the
5249 subscription interface for IStatusLog subscriptions just like all
5250 other the status subscriptions
5251 (IStatusReceiver.logChunk): method called on subscribers
5253 2004-08-24 Brian Warner <warner@lothar.com>
5255 * buildbot/process/builder.py (Builder._pong): oops, ping response
5256 includes a result (the implicit None returned by remote_print).
5257 Accept it so the _pong method handles the response correctly.
5259 2004-08-06 Brian Warner <warner@lothar.com>
5261 * buildbot/test/test_config.py: update IRC, PBListener tests
5263 * buildbot/status/client.py (StatusClientPerspective): total
5264 rewrite to match new IStatus interfaces. New subscription scheme.
5265 There are still a few optimizations to make (sending down extra
5266 information with event messages so the client doesn't have to do a
5267 round trip). The logfile-retrieval code is probably still broken.
5268 Moved the PB service into its own port, you can no longer share a
5269 TCP socket between a PBListener and, say, the slaveport (this
5270 should be fixed eventually).
5271 * buildbot/clients/base.py (Client): revamp to match. still needs
5272 a lot of work, but basic event reporting works fine. gtkPanes is
5275 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
5276 instance talks to a single irc server. Threw out all the old
5277 multi-server handling code. Still need to add back in
5278 builder-control (i.e. "force build")
5280 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
5281 more random text to the as-yet-unreachable per-step page
5283 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
5284 rename to stepETAUpdate
5285 (BuildStatus.subscribe): add build-wide ETA updates
5286 (BuilderStatus.getState): remove more cruft
5287 (BuilderStatus.getCurrentBuild): remove more cruft
5288 (BuilderStatus.buildStarted): really handle tuple-subscription
5289 * buildbot/test/test_run.py (Status.testSlave): handle the
5290 stepETAUpdate rename
5292 * buildbot/master.py (BuildMaster): don't add a default
5293 StatusClientService. Don't add a default IrcStatusFactory. Both
5294 are now added through c['status'] in the config file. c['irc'] is
5295 accepted for backwards compatibility, the only quirk is you cannot
5296 use c['irc'] to specify IRC servers on ports other than 6667.
5298 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
5299 (IStatusReceiver.buildStarted): allow update-interval on subscribe
5300 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
5301 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
5304 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
5305 the buildmaster to re-read its config file
5308 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
5309 find out the port our server is running on
5310 (WebTest.test_webPathname_port): same
5312 * buildbot/test/test_config.py (testWebPortnum): test it
5313 (testWebPathname): ditto
5315 * docs/config.xhtml: document new c['status'] configuration option
5317 * buildbot/status/html.py (Waterfall): new top-level class which
5318 can be added to c['status']. This creates the Site as well as the
5319 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
5320 reachable as .parent, for everything.
5322 * buildbot/master.py (Manhole): make it a normal service Child
5323 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
5324 webPathname. It will eventually replace c['irc'] and the implicit
5325 PB listener as well. c['webPortnum'] and c['webPathname'] are left
5326 in as (deprecated) backward compatibility hooks for now.
5329 * buildbot/process/builder.py (Builder.buildFinished): don't
5330 inform out builder_status about a finished build, as it finds out
5331 through its child BuildStatus object
5333 * buildbot/status/html.py: extensive revamp. Use adapters to make
5334 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
5335 have both starting and finishing times and adjust the waterfall
5336 display accordingly, using spacers if necessary. Use SlaveStatus
5337 to get buildslave info.
5338 (StatusResourceBuildStep): new just-one-step resource, used to get
5339 logfiles. No actual href to it yet.
5341 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
5342 the time being, until I get the file-naming scheme right
5344 * buildbot/status/builder.py (Event): clean started/finished names
5345 (BuildStatus.isFinished): .finished is not None is the right test
5346 (BuildStatus.buildStarted): track started/finished times ourselves
5347 (BuilderStatus.getSlave): provide access to SlaveStatus object
5348 (BuilderStatus.getLastFinishedBuild): all builds are now in
5349 .builds, even the currently-running one. Accomodate this change.
5350 (BuilderStatus.eventGenerator): new per-builder event generator.
5351 Returns BuildStepStatus and BuildStatus objects, since they can
5352 both be adapted as necessary.
5353 (BuilderStatus.addEvent): clean up started/finished attributes
5354 (BuilderStatus.startBuild,finishBuild): remove dead code
5355 (SlaveStatus): new object to provide ISlaveStatus
5357 * buildbot/process/step.py (ShellCommand.getColor): actually
5358 return the color instead of setting it ourselves
5359 (CVS.__init__): pull .timeout and .workdir options out of
5360 **kwargs, since BuildStep will ignore them. Without this neither
5361 will be sent to the slave correctly.
5362 (SVN.__init__): same
5364 * buildbot/process/builder.py (Builder): move flags to class-level
5366 (Builder.attached): remove .remoteInfo, let the BotPerspective and
5367 SlaveStatus handle that
5369 * buildbot/process/base.py (Build.firstEvent): remove dead code
5370 (Build.stopBuild): bugfix
5372 * buildbot/changes/pb.py (PBChangeSource.describe): add method
5374 * buildbot/changes/changes.py (Change): add IStatusEvent methods
5375 (ChangeMaster.eventGenerator): yield Changes, since there are now
5376 Adapters to turn them into HTML boxes
5378 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
5379 (BotPerspective.attached): feed a SlaveStatus object
5380 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
5381 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
5383 * buildbot/interfaces.py: API additions
5384 (ISlaveStatus): place to get slave status
5386 2004-08-04 Brian Warner <warner@lothar.com>
5388 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
5389 the delay finishes, so the step is marked as SUCCESS
5391 * buildbot/test/test_run.py (Status.testSlave): cover more of
5392 IBuildStatus and IBuildStepStatus
5394 * buildbot/status/progress.py (StepProgress): move some flags to
5395 class-level attributes
5396 (StepProgress.remaining): if there are no other progress metrics
5397 to go by, fall back to elapsed time
5398 (StepProgress.setExpectations): take a dict of metrics instead of
5400 (BuildProgress.setExpectationsFrom): pull expectations from the
5401 Expectations, instead of having it push them to the BuildProgress
5402 (Expectations): move some flags to class-level attributes
5403 (Expectations.__init__): copy per-step times from the
5405 (Expectations.expectedBuildTime): new method for per-build ETA
5407 * buildbot/status/event.py (Logfile): move some flags to
5408 class-level attributes
5409 (Logfile.logProgressTo): better method name, let step set the
5410 progress axis name (instead of always being "output")
5412 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
5413 times directly, rather than depending upon the (possibly missing)
5414 .progress object. Use 'None' to indicate "not started/finished
5416 (BuildStepStatus.getExpectations): oops, return the full list of
5418 (BuilderStatus._buildFinished): append finished builds to .builds
5420 * buildbot/process/step.py (BuildStep): add separate .useProgress
5421 flag, since empty .progressMetrics[] still implies that time is a
5423 (CVS): set up the cmd in __init__, instead of waiting for start()
5425 * buildbot/process/base.py (Build.startBuild): disable the 'when'
5426 calculation, this will eventually turn into a proper sourceStamp
5427 (Build.setupBuild): tell the Progress to load from the Expectations,
5428 instead of having the Expectations stuff things into the Progress
5429 (Build.buildException): add a build-level errback to make sure the
5430 build's Deferred fires even in case of exceptions
5432 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
5434 * buildbot/process/builder.py (Builder.forceBuild): convey the
5435 reason instead of creating a fake Change
5437 * docs/examples/twisted_master.cfg: update to match reality
5439 * buildbot/test/test_config.py, buildbot/test/test_process.py:
5440 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
5441 fix or remove broken/breaking tests
5443 * buildbot/status/event.py (Logfile.__len__): remove evil method
5445 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
5446 missing .build, for test convenience
5448 * buildbot/process/step_twisted.py: import fixes
5450 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
5452 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
5453 .statusbag reference
5455 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
5456 connection at shutdown, and stop it from reconnecting
5458 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
5459 chase down remote-execution bugs
5461 * buildbot/process/step.py: more fixes, remove
5462 BuildStep.setStatus()
5463 * buildbot/status/builder.py: move setStatus() functionality into
5465 * buildbot/status/event.py: minor fixes
5467 2004-08-03 Brian Warner <warner@lothar.com>
5469 * buildbot/process/base.py, buildbot/process/builder.py
5470 * buildbot/process/step.py, buildbot/status/builder.py
5471 * buildbot/status/event.py, buildbot/test/test_run.py:
5472 fix status delivery, get a basic test case working
5473 * buildbot/master.py: finish implementing basic status delivery,
5474 temporarily disable HTML/IRC/PB status sources
5476 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
5478 * buildbot/status/progress.py (BuildProgress): remove dead code
5480 * buildbot/interfaces.py
5481 * buildbot/process/base.py, buildbot/process/builder.py
5482 * buildbot/process/step.py, buildbot/process/step_twisted.py
5483 * buildbot/status/builder.py: Complete overhaul of the all
5484 status-delivery code, unifying all types of status clients (HTML,
5485 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
5486 look like. This commit is a checkpointing of the work-in-progress:
5487 the input side is mostly done (Builders/Builds sending status
5488 to the BuilderStatus/BuildStatus objects), but the output side has
5489 not yet been started (HTML resources querying BuilderStatus
5490 objects). Things are probably very broken right now and may remain
5491 so for several weeks, I apologize for the disruption.
5493 * buildbot/status/event.py: add a setHTML method to use pre-rendered
5494 HTML as the log's contents. Currently used for exception tracebacks.
5495 * buildbot/status/progress.py: minor spelling changes
5497 2004-08-02 Brian Warner <warner@lothar.com>
5499 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
5500 in mozilla. Also added stylesheets copied from Twisted's docs.
5501 Remember that these files are meant to be run through Lore first.
5502 Thanks to Philipp Frauenfelder for the fixes.
5503 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
5504 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
5505 * docs/template.tpl: added a Lore template
5507 2004-07-29 Brian Warner <warner@lothar.com>
5509 * buildbot/interfaces.py: revamp status delivery. This is the
5510 preview: these are the Interfaces that will be provided by new
5511 Builder code, and to which the current HTML/IRC/PB status
5512 displayers will be adapted.
5514 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
5515 on the SlaveBuilder, not the Bot.
5516 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
5518 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
5519 set .usePTY on the FakeSlaveBuilder
5521 2004-07-25 Brian Warner <warner@lothar.com>
5523 * buildbot/changes/freshcvs.py: add some debug log messages
5524 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
5525 disabled 'setFilter' syntax
5526 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
5527 don't end with a slash
5529 * buildbot/process/base.py (Builder._pong_failed): add TODO note
5531 * setup.py: bump to 0.5.0+ while between releases
5533 2004-07-23 Brian Warner <warner@lothar.com>
5535 * setup.py (version): Releasing buildbot-0.5.0
5537 2004-07-23 Brian Warner <warner@lothar.com>
5539 * README: update for 0.5.0 release
5541 * NEWS: update for 0.5.0 release
5543 2004-07-22 Brian Warner <warner@lothar.com>
5545 * buildbot/slavecommand.py (ShellCommand): make usePTY a
5546 mktap-time configuration flag (--usepty=1, --usepty=0)
5547 * buildbot/bot.py: same
5549 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
5550 an 'info' directory being unwanted
5552 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
5553 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
5554 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
5555 and earlier), use a FreshCVSSourceOldcred instead.
5556 (test): simple test routine: connect to server, print changes
5558 * buildbot/changes/changes.py (Change.getTime): make it possible
5559 to print un-timestamped changes
5561 * buildbot/master.py (makeApp): delete ancient dead code
5562 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
5563 * buildbot/test/test_config.py (testFindConfigFile): test it
5565 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
5566 instead of win32 one
5569 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
5570 now takes a dictionary instead of a tuple. See docs/config.xhtml for
5573 * buildbot/process/base.py (Builder.__init__): change constructor
5574 to accept a dictionary of config data, rather than discrete
5575 name/slave/builddir/factory arguments
5577 * docs/examples/twisted_master.cfg: update to new syntax
5578 * docs/examples/glib_master.cfg: same
5579 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
5580 rough tests of the new syntax
5583 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
5584 to be an int, which means "run a web.distrib sub-server on a TCP
5585 port". This lets you publish the buildbot status page to a remote
5586 twisted.web server (using distrib.ResourceSubscription). Also
5587 rename the local attributes used to hold these web things so
5588 they're more in touch with reality.
5589 * buildbot/test/test_web.py: test webPortnum and webPathname
5590 * docs/config.xhtml: document this new use of webPathname
5592 * docs/config.xhtml: new document, slightly ahead of reality
5594 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
5595 'prefix' handling: treat it as a simple string to check with
5596 .startswith, instead of treating it as a directory. This allows
5597 sub-directories to be used. If you use prefix=, you should give it
5598 a string that starts just below the CVSROOT and ends with a slash.
5599 This prefix will be stripped from all filenames, and filenames
5600 which do not start with it will be ignored.
5602 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
5604 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
5605 and --exclude (inverse of --include). SVN post-commit hooks
5606 now have total control over which changes get sent to buildbot and which
5609 2004-07-10 Brian Warner <warner@lothar.com>
5611 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
5612 test case to match new API
5614 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
5615 which crashed HTML display when self.entries=[] (needed to
5616 distinguish between [], which means "no entries yet", and None,
5617 which means "the entries have been swapped out to disk, go fetch
5620 2004-07-04 Brian Warner <warner@lothar.com>
5622 * buildbot/process/step_twisted.py (countFailedTests): Count
5623 skips, expectedFailures, and unexpectedSuccesses. Start scanning
5624 10kb from the end because any import errors are wedged there and
5625 they would make us think the test log was unparseable.
5626 (RunUnitTests.finishStatus): add skip/todo counts to the event box
5628 2004-06-26 Brian Warner <warner@lothar.com>
5630 * buildbot/process/step_twisted.py (RemovePYCs): turn the
5631 delete-*.pyc command into an actual BuildStep, so we can label it
5633 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5634 (FullTwistedBuildFactory): same
5636 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
5638 * contrib/fakechange.py: Add an errback when sending the fake
5639 change, so we know it didn't work.
5641 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
5643 * buildbot/process/step_twisted.py: Delete *.pyc files before
5644 calling trial, so it doesn't catch any old .pyc files whose .py
5645 files have been moved or deleted.
5647 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
5648 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
5649 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
5650 instead of ["twisted.test"], so that the end result is "trial -R
5653 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
5654 regular expression to match filenames that should be ignored when
5655 changed. Also add a --revision parameter that specifies the
5656 revision to examine, which is useful for debugging.
5658 2004-06-25 Brian Warner <warner@lothar.com>
5660 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
5661 summary of warnings (like DeprecationWarnings), next to the
5664 2004-05-13 Brian Warner <warner@lothar.com>
5666 * docs/examples/twisted_master.cfg: enable the win32 builder, as
5667 we now have a w32 build slave courtesy of Mike Taylor.
5669 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
5670 so broken. Fixed a race condition that tripped up interlocked
5671 builds and caused the status to be stuck at "Interlocked" forever.
5672 The twisted buildbot's one interlocked build just so happened to
5673 never hit this case until recently (the feeding builds both pass
5674 before the interlocked build is attempted.. usually it has to wait
5676 (Builder._pong_failed): fix method signature
5678 * setup.py: bump to 0.4.3+ while between releases
5680 2004-04-30 Brian Warner <warner@lothar.com>
5682 * setup.py (version): Releasing buildbot-0.4.3
5684 2004-04-30 Brian Warner <warner@lothar.com>
5686 * MANIFEST.in: add the doc fragments in docs/*.xhtml
5688 * README: update for 0.4.3 release
5690 * NEWS: update for 0.4.3 release
5692 * buildbot/master.py (BuildMaster.__getstate__): make sure
5693 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
5695 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
5696 .trial as a class attribute, for upgrade from 0.4.2
5698 * buildbot/changes/changes.py (Change.links): add .links for
5701 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
5702 .textWatchers and .htmlWatchers at save time, since they are both
5703 volatile, should allow smooth 0.4.2 upgrade
5705 * buildbot/process/step.py (CVS.finishStatus): catch failed
5706 CVS/SVN commands so we can make the status box red
5708 2004-04-29 Brian Warner <warner@lothar.com>
5710 * buildbot/changes/freshcvs.py
5711 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
5712 code to do setFilter(), which tells the freshcvs daemon to not
5713 send us stuff that we're not interested in. I will uncomment it
5714 when a new version of CVSToys is available in which setFilter()
5715 actually works, and I get a chance to test it better.
5717 * docs/examples/twisted_master.cfg: start using a PBChangeSource
5719 * buildbot/master.py (Dispatcher): use a registration scheme
5720 instead of hardwired service names
5721 (BuildMaster): keep track of the Dispatcher to support
5724 * buildbot/changes/changes.py (ChangeMaster): create a distinct
5725 PBChangeSource class instead of having it be an undocumented
5726 internal feature of the ChangeMaster. Split out the code into a
5728 * buildbot/changes/pb.py (PBChangeSource): same
5729 * buildbot/test/test_changes.py: a few tests for PBChangeSource
5731 * docs/{factories|sources|steps}.xhtml: document some pieces
5733 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
5734 using FCMaildirSource
5735 (f23osx): update OS-X builder to use python2.3, since the slave
5736 was updated to Panther (10.3.3)
5738 2004-03-21 Brian Warner <warner@lothar.com>
5740 * buildbot/process/process_twisted.py: factor out doCheckout, change
5741 to use SVN instead of CVS
5743 * buildbot/process/base.py (BasicBuildFactory): refactor to make
5744 an SVN subclass easier
5745 (BasicSVN): subclass which uses Subversion instead of CVS
5747 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
5749 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
5751 (CVSCommand.cvsComplete): don't assume chdir worked on win32
5753 2004-02-25 Brian Warner <warner@lothar.com>
5755 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
5756 is now either a list (which is passed to spawnProcess directly) or
5757 a string (which gets passed to /bin/sh -c). This removes the useSH
5758 flag and the ArgslistCommand class. Also send status header at the
5759 start and end of each command, instead of having the master-side
5761 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
5762 -r'. Update to use list-based arguments.
5763 (SVNFetch): use list-based arguments, use ['dir'] argument to
5765 * buildbot/test/test_steps.py (Commands): match changes
5767 * buildbot/process/step.py (InternalShellCommand.words): handle
5769 (SVN): inherit from CVS, cleanup
5771 * buildbot/status/event.py (Logfile.content): render in HTML, with
5772 stderr in red and headers (like the name of the command we're
5773 about to run) in blue. Add link to a second URL (url + "?text=1")
5774 to get just stdout/stderr in text/plain without markup. There is
5775 still a problem with .entries=None causing a crash, it seems to occur
5776 when the logfile is read before it is finished.
5778 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
5779 timeout to the keepalives, and use it to explicitly do a
5780 loseConnection instead of waiting for TCP to notice the loss. This
5781 ought to clear up the silent-lossage problem.
5782 (unsafeTracebacks): pass exception tracebacks back to the master,
5783 makes it much easier to debug problems
5785 2004-02-23 Brian Warner <warner@lothar.com>
5787 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
5788 the whole command to /bin/sh instead of execve [Johan Dahlin]
5789 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
5790 '-r HEAD' [Johan Dahlin]
5791 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
5793 * buildbot/changes/changes.py (Change): add links= argument, add
5794 asHTML method [Johan Dahlin]. Modified to make a bit more
5795 XHTMLish. Still not sure how to best use links= .
5797 * buildbot/status/html.py (StatusResourceCommits.getChild): use
5798 Change.asHTML to display the change, not asText
5800 * buildbot/status/html.py (StatusResourceBuilder): web button to
5803 * buildbot/test/test_run.py: test to actually start a buildmaster
5806 * MANIFEST.in: bring back accidentally-dropped test helper files
5808 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
5809 that require cvstoys if it is not installed
5811 * buildbot/process/step_twisted.py (RunUnitTests): allow other
5812 values of "bin/trial" [Dave Peticolas]
5813 (RunUnitTests.finishStatus): say "no tests run" instead of "0
5814 tests passed" when we didn't happen to run any tests
5816 * buildbot/process/step.py (Compile): use haltOnFailure instead of
5817 flunkOnFailure [Johan Dahlin]
5819 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
5820 multiple instances of the same Step class by suffixing "_2", etc,
5821 to the name until it is unique. This name needs to be unique
5822 because it is used as a key in the dictionary that tracks build
5824 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
5827 * buildbot/process/base.py (Builder.ping): add "ping slave" command
5829 2004-01-14 Brian Warner <warner@lothar.com>
5831 * buildbot/status/words.py (IrcStatusBot): when we leave or get
5832 kicked from a channel, log it
5834 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
5835 something over whatever IRC channels the buildmaster is currently
5836 connected to. Added to try and track down a problem in which the
5837 master thinks it is still connected but the IRCd doesn't see it. I
5838 used a styles.Versioned this time, so hopefully users won't have
5839 to rebuild their .tap files this time.
5840 * contrib/debug.glade: add a "Poke IRC" button
5841 * contrib/debugclient.py: same
5843 * setup.py: bump to 0.4.2+ while between releases
5845 2004-01-08 Brian Warner <warner@lothar.com>
5847 * setup.py (version): Releasing buildbot-0.4.2
5849 2004-01-08 Brian Warner <warner@lothar.com>
5851 * NEWS: update for 0.4.2 release
5853 * README: document how to run the tests, now that they all pass
5855 * buildbot/changes/maildir.py (Maildir.poll): minor comment
5857 * buildbot/process/step.py (CVS): add a global_options= argument,
5858 which lets you set CVS global options for the command like "-r"
5859 for read-only checkout, or "-R" to avoid writing in the
5861 * buildbot/slavecommand.py (CVSCommand): same
5863 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
5864 testing easier (it is turned off when testing, to avoid the
5867 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
5868 to make it easier to test: break generateStepID() out to a
5869 separate function, only update statusbag if it exists.
5870 (ShellCommands): create useful text for dict-based commands too.
5872 * test/*, buildbot/test/*: move unit tests under the buildbot/
5874 * setup.py (packages): install buildbot.test too
5876 * buildbot/test/test_slavecommand.py: fix it, tests pass now
5877 * buildbot/test/test_steps.py: fix it, tests pass now
5879 2004-01-06 Brian Warner <warner@lothar.com>
5881 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
5882 freshcvs mail uses a slightly different syntax for new
5883 directories. Update parser to handle either.
5884 * test/test_mailparse.py (Test1.testMsg9): test for same
5886 2003-12-21 Brian Warner <warner@lothar.com>
5888 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
5889 'warnOnWarnings' so that lintian errors mark the build orange
5891 2003-12-17 Brian Warner <warner@lothar.com>
5893 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
5894 messages emitted by Bonsai, contributed by Stephen Davis.
5896 * test/*: moved all tests to use trial instead of unittest. Some
5897 still fail (test_steps, test_slavecommand, and test_process).
5899 * setup.py (version): bump to 0.4.1+ while between releases
5901 2003-12-09 Brian Warner <warner@lothar.com>
5903 * setup.py (version): Releasing buildbot-0.4.1
5905 2003-12-09 Brian Warner <warner@lothar.com>
5907 * NEWS: update for 0.4.1 release
5909 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
5910 freebsd builder code a little bit
5912 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
5913 don't try to compare attributes of different classes
5914 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
5915 (MaildirSource.messageReceived): fix Change delivery
5917 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
5918 into the config file's namespace before loading it, like the
5919 documentation claims it does
5920 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
5921 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
5922 daemon comes back online
5924 2003-12-08 Brian Warner <warner@lothar.com>
5926 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
5927 so the example will work with online=0 as well
5929 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
5930 fix the __implements__ line
5932 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
5933 class a twisted.application.service.Service, use startService to
5936 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
5937 directory fd instead of simple open(). I'm sure this used to work,
5938 but the current version of python refuses to open directories with
5941 2003-12-05 Brian Warner <warner@lothar.com>
5943 * setup.py (version): bump to 0.4.0+ while between releases
5945 2003-12-05 Brian Warner <warner@lothar.com>
5947 * setup.py (version): Releasing buildbot-0.4.0
5949 2003-12-05 Brian Warner <warner@lothar.com>
5951 * docs/examples/glib_master.cfg: replace old sample scripts with
5952 new-style config files
5953 * MANIFEST.in: include .cfg files in distribution tarball
5955 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
5956 implement a dummy method to avoid the exception that occurs when
5957 freshcvs sends this to us.
5959 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
5960 removed the method, as it broke reconnection. Apparently
5961 stopFactory is called each time the connection attempt fails. Must
5963 (ReconnectingPBClientFactory.__getstate__): squash the _callID
5964 attribute before serialization, since without stopFactory the
5965 reconnect timer may still be active and they aren't serializable.
5967 * test/test_mailparse.py (ParseTest): test with 'self' argument
5969 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
5970 argument, as these "functions" are invoked like methods from class
5971 attributes and therefore always get an instance as the first
5974 * buildbot/changes/maildir.py (Maildir.start): fix error in error
5975 message: thanks to Stephen Davis for the catch
5977 2003-12-04 Brian Warner <warner@lothar.com>
5979 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
5980 twisted's standard ReconnectingClientFactory. Handles both oldcred
5981 and newcred connections. Also has a bug-workaround for
5982 ReconnectingClientFactory serializing its connector when it
5985 * buildbot/bot.py (BotFactory): rewrite connection layer with new
5986 pbutil. Replace makeApp stuff with proper newcred/mktap
5987 makeService(). Don't serialize Ephemerals on shutdown.
5989 * buildbot/changes/changes.py (ChangeMaster): make it a
5990 MultiService and add the sources as children, to get startService
5991 and stopService for free. This also gets rid of the .running flag.
5993 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
5994 new pbutil, turn into a TCPClient at the same time (to get
5995 startService for free). Two variants exist: FreshCVSSourceOldcred
5996 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
5997 yet, but when it does, we'll be ready).
5998 (FreshCVSSource.notify): handle paths which are empty after the
5999 prefix is stripped. This only happens when the top-level (prefix)
6000 directory is added, at the very beginning of a Repository's life.
6002 * buildbot/clients/base.py: use new pbutil, clean up startup code.
6003 Now the only reconnecting code is in the factory where it belongs.
6004 (Builder.unsubscribe): unregister the disconnect callback when we
6005 delete the builder on command from the master (i.e. when the
6006 buildmaster is reconfigured and that builder goes away). This
6007 fixes a multiple-delete exception when the status client is shut
6009 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
6012 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
6013 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
6015 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
6017 * contrib/run_maxq.py: Accept a testdir as an argument rather than
6018 a list of globs (ugh). The testdir will be searched for files
6019 named *.tests and run the tests in the order specified in each of
6020 those files. This allows for "dependancies" between tests to be
6023 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
6024 argument to pass to run_maxq.py, instead of a glob.
6026 2003-10-17 Brian Warner <warner@lothar.com>
6028 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
6029 files that live in the sandbox
6031 2003-10-15 Brian Warner <warner@lothar.com>
6033 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
6034 spelling error in "docs" count-warnings output
6035 (HLint.start): stupid thinko meant .xhtml files were ignored
6037 * docs/examples/twisted_master.cfg (reactors): disable cReactor
6038 tests now that cReactor is banished to the sandbox
6040 2003-10-10 Brian Warner <warner@lothar.com>
6042 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
6043 scheme: now .xhtml are sources and .html are generated
6045 2003-10-08 Brian Warner <warner@lothar.com>
6047 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
6048 we were ignoring the 'randomly' parameter.
6050 2003-10-01 Brian Warner <warner@lothar.com>
6052 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
6053 posix, to kill sub-children of aborted slavecommands.
6055 * buildbot/status/builder.py: rename Builder to BuilderStatus.
6056 Clean up initialization: lastBuildStatus remains None until the
6057 first build has been completed.
6059 * buildbot/status/html.py (WaterfallStatusResource.body): handle
6060 None as a lastBuildStatus
6061 * buildbot/clients/gtkPanes.py: same
6063 * buildbot/status/client.py (StatusClientService): keep
6064 BuilderStatus objects in self.statusbags . These objects now live
6065 here in the StatusClientService and are referenced by the Builder
6066 object, rather than the other way around.
6067 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
6068 * buildbot/process/base.py (Builder): same
6069 * test/test_config.py (ConfigTest.testBuilders): same
6071 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
6072 an existing builder, leave the statusbag alone. This will preserve the
6075 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
6076 hook. This will probably go away in favor of a class in upcoming
6079 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
6080 serviceName from newcred FreshCVSNotifiee setup
6082 2003-09-29 Brian Warner <warner@lothar.com>
6084 * buildbot/process/process_twisted.py: switch to new reactor
6086 * docs/examples/twisted_master.cfg: same
6088 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
6090 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
6091 botmaster reference instead of the oldapp service lookup
6093 * buildbot/master.py (BuildMaster.__init__): give the
6094 StatusClientService a reference to the botmaster to make it easier to
6097 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6099 * buildbot/status/html.py (Box.td): escape hreffy things so you
6100 can have spaces in things like builder names
6101 (StatusResourceBuilder.body)
6102 (WaterfallStatusResource.body)
6103 (WaterfallStatusResource.body0): same
6105 2003-09-25 Brian Warner <warner@lothar.com>
6107 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
6108 rearrange the builder list when adding or removing builders: keep
6109 them in the order the user requested.
6110 * test/test_config.py (ConfigTest.testBuilders): verify it
6112 * contrib/debug.glade: give the debug window a name
6114 * buildbot/process/base.py (Builder.buildTimerFired): builders can
6115 now wait on multiple interlocks. Fix code relating to that.
6116 (Builder.checkInterlocks): same
6117 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
6119 * buildbot/master.py (BuildMaster.loadConfig): move from
6120 deprecated pb.BrokerFactory to new pb.PBServerFactory
6121 * test/test_config.py (ConfigTest.testWebPathname): same
6123 * docs/examples/twisted_master.cfg: fix interlock declaration
6125 * buildbot/master.py (BotMaster.addInterlock): move code to attach
6126 Interlocks to their Builders into interlock.py .
6127 (BuildMaster.loadConfig_Interlocks): fix interlock handling
6129 * test/test_config.py (ConfigTest.testInterlocks): validate
6132 * buildbot/process/base.py (Builder.__init__): better comments
6133 * buildbot/process/interlock.py (Interlock.__repr__): same
6134 (Interlock.deactivate): add .active flag, move the code that
6135 attaches/detaches builders into the Interlock
6137 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
6139 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
6140 tests using the new run_maxq.py script, and reporting failures by
6143 * contrib/run_maxq.py: Hacky little script for running a set of maxq
6144 tests, reporting their success or failure in a buildbot-friendly
6147 2003-09-24 Brian Warner <warner@lothar.com>
6149 * docs/examples/twisted_master.cfg: example of a new-style config
6150 file. This lives in the buildmaster base directory as
6153 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
6154 button to make the master re-read its config file
6156 * buildbot/master.py (BuildMaster.loadConfig): new code to load
6157 buildmaster configuration from a file. This file can be re-read
6158 later, and the buildmaster will update itself to match the new
6159 desired configuration. Also use new Twisted Application class.
6160 * test/Makefile, test/test_config.py: unit tests for same
6162 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
6163 FreshCVSSources comparable, to support reload.
6164 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
6166 * buildbot/process/base.py (Builder): make them comparable, make
6167 Interlocks easier to attach, to support reload. Handle
6168 re-attachment of remote slaves.
6169 * buildbot/process/interlock.py (Interlock): same
6171 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
6172 Twisted's new Application class. Requires Twisted >= 1.0.8 .
6173 buildmaster taps are now constructed with mktap.
6174 * buildbot/status/client.py (StatusClientService): same
6176 * buildbot/status/words.py: move to new Services, add support to
6177 connect to multiple networks, add reload support, allow nickname
6178 to be configured on a per-network basis
6180 2003-09-20 Brian Warner <warner@lothar.com>
6182 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
6183 the freebsd builder, now that the machine has been upgraded and no
6184 longer has python2.2
6186 * setup.py (version): bump to 0.3.5+ while between releases
6188 2003-09-19 Brian Warner <warner@lothar.com>
6190 * setup.py (version): Releasing buildbot-0.3.5
6192 2003-09-19 Brian Warner <warner@lothar.com>
6194 * NEWS: add post-0.3.4 notes
6196 * README (REQUIREMENTS): note twisted-1.0.7 requirement
6198 * MANIFEST.in: add contrib/*
6200 * docs/examples/twisted_master.py (twisted_app): all build slaves must
6201 use a remote root now: cvs.twistedmatrix.com
6203 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
6205 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
6206 compatibility with old servers
6207 (FreshCVSSource.start): and provide a way to use it
6208 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
6210 * docs/examples/twisted_master.py (twisted_app): update to new
6212 (twisted_app): listen on new ~buildbot socket
6213 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
6215 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
6216 to reduce cvs bandwidth (update instead of full checkout)
6218 2003-09-11 Brian Warner <warner@lothar.com>
6220 * contrib/fakechange.py: demo how to connect to the changemaster
6221 port. You can use this technique to submit changes to the
6222 buildmaster from source control systems that offer a hook to run a
6223 script when changes are committed.
6225 * contrib/debugclient.py: tool to connect to the debug port. You
6226 can use it to force builds, submit fake changes, and wiggle the
6229 * buildbot/master.py: the Big NewCred Reorganization. Use a single
6230 'Dispatcher' realm to handle all the different kinds of
6231 connections and Perspectives: buildslaves, the changemaster port,
6232 the debug port, and the status client port. NewCredPerspectives
6233 now have .attached/.detached methods called with the remote 'mind'
6234 reference, much like old perspectives did. All the pb.Services
6235 turned into ordinary app.ApplicationServices .
6236 (DebugService): went away, DebugPerspectives are now created
6237 directly by the Dispatcher.
6238 (makeApp): changed interface a little bit
6240 * buildbot/changes/changes.py: newcred
6241 * buildbot/status/client.py: newcred
6243 * buildbot/clients/base.py: newcred client side changes
6244 * buildbot/bot.py: ditto
6246 * docs/examples/glib_master.py: handle new makeApp() interface
6247 * docs/examples/twisted_master.py: ditto
6249 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
6250 base newcred Perspectives on. This should go away once Twisted
6251 itself provides something sensible.
6254 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
6256 * contrib/svn_buildbot.py: A program that you can call from your
6257 SVNREPO/hooks/post-commit file that will notify a BuildBot master
6258 when a change in an SVN repository has happened. See the top of
6259 the file for some minimal usage info.
6261 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6263 * buildbot/slavecommand.py (ArglistCommand): Add new
6264 ArglistCommand that takes an argument list rather than a string as
6265 a parameter. Using a st.split() for argv is very bad.
6267 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
6268 update to a particular revision rather than always checking out
6269 (still not very smart about it, there may be cases where the
6270 checkout becomes inconsistent).
6272 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
6274 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
6275 SVN fetch support. It can checkout (not update!) a specified
6276 revision from a specified repository to a specified directory.
6278 * buildbot/status/progress.py (Expectations.update): Fix an
6279 obvious bug (apparently created by the change described in the
6280 previous ChangeLog message) by moving a check to *after* the
6281 variable it checks is defined.
6284 2003-09-08 Brian Warner <warner@lothar.com>
6286 * buildbot/status/progress.py (Expectations.update): hack to catch
6287 an exception TTimo sees: sometimes the update() method seems to
6288 get called before the step has actually finished, so the .stopTime
6289 is not set, so no totalTime() is available and we average None
6290 with the previous value. Catch this and just don't update the
6291 metrics, and emit a log message.
6293 2003-08-24 Brian Warner <warner@lothar.com>
6295 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
6296 parameter to set copydir='original' in CVS commands.
6298 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
6300 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
6301 which tells the command to maintain a separate original-source CVS
6302 workspace. For each build, this workspace will be updated, then
6303 the tree copied into a new workdir. This reduces CVS bandwidth
6304 (from a full checkout to a mere update) while doubling the local
6305 disk usage (to keep two copies of the tree).
6307 2003-08-21 Brian Warner <warner@lothar.com>
6309 * buildbot/status/event.py (Logfile.addEntry): if the master web
6310 server dies while we're serving a page, request.write raises
6311 pb.DeadReferenceError . Catch this and treat it like a
6312 notifyFinish event by dropping the request.
6314 2003-08-18 Brian Warner <warner@lothar.com>
6316 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
6317 (instead of blowing up) if a force-build command is given without
6320 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
6321 don't blow up if there aren't yet any Changes in the list
6323 2003-08-02 Brian Warner <warner@lothar.com>
6325 * buildbot/bot.py (updateApplication): don't set the .tap name,
6326 since we shouldn't assume we own the whole .tap file
6328 * buildbot/bb_tap.py (updateApplication): clean up code, detect
6329 'mktap buildbot' (without a subcommand) better
6331 2003-07-29 Brian Warner <warner@lothar.com>
6333 * buildbot/status/words.py
6334 (IrcStatusFactory.clientConnectionLost): when we lose the
6335 connection to the IRC server, schedule a reconnection attempt.
6337 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
6338 use shutil.rmtree instead of forking off an "rm -rf" command.
6339 rmtree may take a while and will block until it finishes, so we
6340 use "rm -rf" if available.
6342 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
6343 freebsd buildslave badly
6345 * setup.py (version): bump to 0.3.4+ while between releases
6347 2003-07-28 Brian Warner <warner@lothar.com>
6349 * setup.py (version): Releasing buildbot-0.3.4
6351 2003-07-28 Brian Warner <warner@lothar.com>
6353 * NEWS: update in preparation for release
6355 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
6356 process.signalProcess instead of os.kill, to improve w32
6359 * docs/examples/twisted_master.py (twisted_app): turn off
6360 win32eventreactor: the tests hang the buildslave badly
6362 * buildbot/process/base.py (Build.buildFinished): update ETA even on
6363 failed builds, since usually the failures are consistent
6365 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6366 add compileOpts/compileOpts2 to reactors build
6368 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
6369 (twisted_app): use both default and win32eventreactor on w32 build.
6370 Use both default and kqreactor on freebsd build.
6372 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6373 add compileOpts2, which is put after the build_ext argument. w32
6374 needs "-c mingw32" here.
6376 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
6377 touch .acqpath, it goes away in recent Twisted releases
6379 * docs/examples/twisted_master.py (twisted_app): use "python" for
6380 the w32 buildslave, not "python2.2"
6382 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
6383 the directory exists.. should hush an exception under w32
6385 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
6386 ProcessTerminated -provided values for signal and exitCode rather
6387 than parsing the unix status code directly. This should remove one
6388 more roadblock for a w32-hosted buildslave.
6390 * test/test_mailparse.py: add test cases for Syncmail parser
6392 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
6393 temporary compatibility import. Note! Start importing
6394 FCMaildirSource from changes.mail instead of changes.freshcvsmail
6396 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
6398 2003-07-27 Brian Warner <warner@lothar.com>
6400 * NEWS: started adding new features
6402 * buildbot/changes/mail.py: start work on Syncmail parser, move
6403 mail sources into their own file
6405 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
6406 as implementing IChangeSource
6407 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
6409 * buildbot/interfaces.py: define the IChangeSource interface
6411 2003-07-26 Brian Warner <warner@lothar.com>
6413 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
6415 2003-06-25 Brian Warner <warner@lothar.com>
6417 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
6420 2003-06-17 Brian Warner <warner@lothar.com>
6422 * buildbot/status/words.py: clean up method usage to avoid error
6423 in silly IRC command
6424 (IrcStatusBot.emit_status): round off seconds display
6426 * buildbot/process/base.py (Build): delete the timer when saving
6427 to the .tap file, and restore it (if it should still be running)
6428 upon restore. This should fix the "next build in -34 seconds"
6429 messages that result when the master is restarted while builds are
6430 sitting in the .waiting slot. If the time for the build has
6431 already passed, start it very soon (in 1 second).
6433 * buildbot/status/words.py: more silly commands
6435 * README (REQUIREMENTS): add URLs to all required software
6437 * buildbot/status/words.py ('last'): mention results of, and time
6440 2003-05-28 Brian Warner <warner@lothar.com>
6442 * buildbot/status/words.py: add 'last' command
6443 (IrcStatusBot.emit_status): add current-small text to 'status' output
6445 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
6446 (twisted_app): remove spaces from OS-X builder name
6448 * buildbot/master.py (makeApp): add knob to turn on IRC bot
6449 * buildbot/status/words.py: IRC bot should actually be useful now
6451 2003-05-23 Brian Warner <warner@lothar.com>
6453 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
6454 "slave information" from $(slavedir)/info/* . These files are
6455 maintained by the slave administrator, and describe the
6456 machine/environment that is hosting the slave. Information from
6457 them is put into the "Builder" HTML page. Still need to establish
6458 a set of well-known filenames and meanings for this data: at the
6459 moment, *all* info/* files are sent to the master, but only
6460 'admin' and 'host' are used on that end.
6461 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
6462 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
6463 * buildbot/master.py (BotPerspective.got_info): ditto
6465 2003-05-22 Brian Warner <warner@lothar.com>
6467 * setup.py (version): bump version to 0.3.3+ while between releases
6469 2003-05-21 Brian Warner <warner@lothar.com>
6471 * setup.py: Releasing buildbot-0.3.3
6473 2003-05-21 Brian Warner <warner@lothar.com>
6475 * NEWS: 0.3.3 news items
6477 * README: describe --keepalive and life behind a NAT box
6479 * buildbot/bot.py (Bot.connected): implement application-level
6480 keepalives to deal with NAT timeouts, turn them on with
6481 --keepalive option or when SO_KEEPALIVE doesn't work.
6483 * buildbot/master.py (BotPerspective): accept keepalives silently
6485 * buildbot/process/base.py (Build.buildException): CopiedFailures
6486 don't carry as much information as local ones, so don't try to
6487 create a big HTMLized version of them.
6489 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
6490 log file when step fails due to an exception, such as when the slave
6493 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
6494 --testmodule argument instead of grepping for test-case-name tags
6495 ourselves. Remove FindUnitTests code.
6496 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
6498 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
6500 2003-05-16 Brian Warner <warner@lothar.com>
6502 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
6503 argument to allow things like CFLAGS=-O0 to be passed without relying
6504 upon /bin/sh processing on the slave.
6506 * buildbot/process/step.py (InternalShellCommand.start): send
6508 * buildbot/slavecommand.py (ShellCommand.start): create argv with
6509 'split' instead of letting /bin/sh do it. This should also remove
6510 the need for /bin/sh on the buildslave, making it more likely to
6513 * buildbot/status/html.py: html-escape text in blamelist.
6514 Add "force build" button to the Builder page.
6516 * buildbot/process/step_twisted.py (countFailedTests): look at
6517 last 1000 characters for status line, as import errors can put it
6518 before the -200 point.
6520 2003-05-15 Brian Warner <warner@lothar.com>
6522 * docs/examples/twisted_master.py: use clobber=0 for remote builds
6524 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6525 make 'clobber' a parameter, so it is possible to have builds which
6526 do full tests but do a cvs update instead of hammering the CVS
6527 server with a full checkout each build
6529 * buildbot/process/step.py (InternalShellCommand): bump default
6530 timeout to 20 minutes
6532 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
6533 the master to trigger a build. Run it via manhole.
6535 * buildbot/master.py (BotPerspective.perspective_forceBuild):
6536 allow slaves to trigger any build that they host, to make life
6537 easier for slave admins who are testing out new build processes
6539 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
6540 don't flunk cReactor or qtreactor on failure, since they fail alot
6541 these days. Do warnOnFailure instead.
6543 * buildbot/process/base.py: change Builder.buildable from a list
6544 into a single slot. When we don't have a slave, new builds (once
6545 they make it past the timeout) are now merged into an existing
6546 buildable one instead of being queued. With this change, a slave
6547 which has been away for a while doesn't get pounded with all the
6548 builds it missed, but instead just does a single build.
6550 2003-05-07 Brian Warner <warner@lothar.com>
6552 * setup.py (version): bump version to 0.3.2+ while between releases
6554 2003-05-07 Brian Warner <warner@lothar.com>
6556 * setup.py: Releasing buildbot-0.3.2
6558 2003-05-07 Brian Warner <warner@lothar.com>
6560 * setup.py: fix major packaging error: include subdirectories!
6562 * NEWS: add changes since last release
6564 * README (REQUIREMENTS): update twisted/python dependencies
6566 * buildbot/status/builder.py (Builder.startBuild): change
6567 BuildProcess API: now they should call startBuild/finishBuild
6568 instead of pushing firstEvent / setLastBuildStatus. Moving towards
6569 keeping a list of builds in the statusbag, to support other kinds of
6571 (Builder.addClient): send current-activity-small to new clients
6572 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
6575 * buildbot/status/client.py: drop RemoteReferences at shutdown
6577 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
6579 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
6580 more debug messages for remote status client
6582 * buildbot/process/step.py (InternalBuildStep.stepComplete)
6583 (.stepFailed): only fire the Deferred once, even if both
6584 stepComplete and stepFailed are called. I think this can happen if
6585 an exception occurs at a weird time.
6587 * buildbot/status/words.py: work-in-progress: IRC status delivery
6589 2003-05-05 Brian Warner <warner@lothar.com>
6591 * docs/examples/twisted_master.py (twisted_app): hush internal
6592 python2.3 distutils deprecation warnings
6593 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6594 add compileOpts= argument which inserts extra args before the
6595 "setup.py build_ext" command. This can be used to give -Wignore
6596 warnings, to hush some internal python-2.3 deprecation messages.
6598 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
6599 the ['twisted.test'] default test case to make it easier to change
6602 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
6603 * buildbot/clients/gtkPanes.py: ditto
6605 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
6606 arg to collapse RunUnitTestsRandomly into RunUnitTests
6607 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6608 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
6610 * buildbot/status/html.py (StatusResource): shuffle Resources
6611 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
6612 would serve the waterfall display, but the internal links were
6613 only valid on the trailing-slash version. The correct behavior is
6614 for the non-slashed one to serve a Redirect to the slashed one.
6615 This only shows up when the buildbot page is hanging off another
6616 server, like a Twisted-Web distributed server.
6618 * buildbot/status/event.py (Event, RemoteEvent): make Events
6619 pb.Cacheable, with RemoteEvent as the cached version. This removes
6620 a lot of explicit send-an-update code.
6621 * buildbot/status/builder.py (Builder): remove send-update code
6622 * buildbot/status/client.py (ClientBuilder): remove send-update
6623 code, and log errors that occur during callRemote (mostly to catch
6624 InsecureJelly exceptions)
6626 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6627 run Lore with the same python used in the rest of the build
6629 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
6631 * buildbot/process/step_twisted.py (HLint): accept 'python'
6632 argument. Catch rc!=0 and mark the step as failed. This marks the
6633 build orange ("has warnings").
6634 (RunUnitTestsJelly): move out to step_twisted2.py
6636 * buildbot/util.py (ignoreStaleRefs): add utility function
6638 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
6639 don't fake ETA object, it's too hard to get right
6641 2003-05-02 Brian Warner <warner@lothar.com>
6643 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
6645 2003-05-01 Brian Warner <warner@lothar.com>
6647 * buildbot/status/html.py (StatusResource.body): oops, I was
6648 missing a <tr>, causing the waterfall page to be misrendered in
6649 everything except Galeon.
6651 2003-04-29 Brian Warner <warner@lothar.com>
6653 * docs/examples/twisted_master.py: make debuild use python-2.2
6654 explicitly, now that Twisted stopped supporting 2.1
6656 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
6657 handle tuple results too. I keep forgetting this, which suggests
6658 it needs to be rethought.
6660 * setup.py (setup): bump version to 0.3.1+ while between releases
6662 2003-04-29 Brian Warner <warner@lothar.com>
6664 * setup.py: Releasing buildbot-0.3.1
6666 2003-04-29 Brian Warner <warner@lothar.com>
6668 * README (SUPPORT): add plea to send questions to the mailing list
6670 * NEWS, MANIFEST.in: add description of recent changes
6672 * docs/examples/twisted_master.py: add the code used to create the
6673 Twisted buildmaster, with passwords and such removed out to a
6676 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
6677 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
6678 buildmasters to not require CVSToys be installed.
6679 * README, docs/examples/glib_master: update to match the change
6681 * buildbot/clients/base.py, buildbot/bot.py,
6682 buildbot/changes/changes.py, buildbot/pbutil.py: copy
6683 ReconnectingPB from CVSToys distribution to remove CVSToys
6684 dependency for build slaves and status clients. Buildmasters which
6685 use FreshCVSSources still require cvstoys be installed, of course.
6687 2003-04-25 Brian Warner <warner@lothar.com>
6689 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
6690 runTestsRandomly arg to turn on trial -z
6692 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
6693 experimental code to use trial's machine-parseable output to get
6694 more detailed test results. Still has some major issues.
6695 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
6698 * buildbot/status/builder.py (Builder.setCurrentBuild):
6699 anticipating moving build history into statusbag, not used yet
6701 * buildbot/status/tests.py: code to centralize test results,
6702 doesn't work quite yet
6704 * buildbot/status/event.py (Event): use hasattr("setName") instead
6705 of isinstance for now.. need better long-term solution
6707 * buildbot/status/html.py: Remove old imports
6709 2003-04-24 Brian Warner <warner@lothar.com>
6711 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
6712 ignore changes under doc/fun/ and sandbox/
6714 * buildbot/process/step_twisted.py: update pushEvent and friends.
6716 * buildbot/status/html.py (Box.td): replace event.buildername with
6717 event.parent.getSwappableName(). Needs more thought.
6719 * buildbot/status/builder.py (Builder): Replace pushEvent and
6720 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
6721 Tell events they are being pruned with event.delete().
6723 * buildbot/process/base.py (Build): Remove Builder status-handling
6724 methods. s/pushEvent/setCurrentActivity/.
6726 * buildbot/process/step.py (BuildStep): clean up status delivery.
6727 Gouse builder.statusbag methods instead of intermediate builder
6728 methods. s/updateLastEvent/updateCurrentActivity/.
6729 s/finalizeLastEvent/finishCurrentActivity/. Use
6730 addFileToCurrentActivity for summaryFunction.
6732 * buildbot/status/event.py (Logfile): put data in a Swappable when
6734 (Event): add more setter methods. Remove .buildername, use .parent
6735 and getSwappableName instead (needs more thought).
6737 * buildbot/util.py (Swappable):
6738 * test/test_swap.py: don't bother setting filename at __init__
6739 time, do it later. Change setFilename args to take parent first,
6740 since it provides the most significant part of the filename.
6742 2003-04-23 Brian Warner <warner@lothar.com>
6744 * buildbot/status/event.py (Logfile.addEntry): append to previous
6747 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
6748 anticipating Swappable
6749 (InternalShellCommand.remoteUpdate): split out various log-adding
6750 methods so subclasses can snarf stdout separately
6752 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
6753 in anticipation of Swappable build logs
6754 (Builder.testsFinished): anticipating TestResults, still disabled
6756 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
6759 * buildbot/status/event.py (Logfile): add (disabled) support for
6760 Swappable, not ready for use yet
6762 * buildbot/util.py (Swappable): object which is swapped out to
6763 disk after some period of no use.
6764 * test/test_swap.py: test buildbot.utils.Swappable
6766 2003-04-14 Brian Warner <warner@lothar.com>
6768 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
6769 periodic-build timer. Set the .periodicBuildTime on a builder
6770 instance to some number of seconds to activate it.
6772 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
6774 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
6775 a way that survives result tuples
6777 2003-04-12 Brian Warner <warner@lothar.com>
6779 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6780 return a dict instead of a tuple: allow summarizers to provide
6781 multiple summaries if they want
6782 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
6783 (debuildSummarizer): summarize lintian warnings/errors
6785 2003-04-10 Brian Warner <warner@lothar.com>
6787 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
6789 2003-04-09 Brian Warner <warner@lothar.com>
6791 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
6792 empty summaries: happens when the tests fail so hard they don't emit
6793 a parseable summary line.
6795 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
6796 Allow summaryFunction to return None to indicate no summary should
6799 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
6800 writing to stale HTTP requests: notice when they disconnect and
6801 remove the request from the list. Also add CacheToFile from
6802 moshez, will be used later.
6804 2003-04-08 Brian Warner <warner@lothar.com>
6806 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
6807 should be an int, not a list of strings
6809 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
6810 if we weren't actually connected
6812 * buildbot/process/step_twisted.py (trialTextSummarizer): function
6813 to show the tail end of the trial text output
6815 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
6816 hook to summarize the results of a ShellCommand
6818 2003-04-07 Brian Warner <warner@lothar.com>
6820 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
6821 twisted test suite code into a single class.
6822 * buildbot/process/process_twisted.py: same
6824 2003-04-04 Brian Warner <warner@lothar.com>
6826 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
6828 * README (SLAVE): document use of mktap to create slave .tap file
6829 (REQUIREMENTS): describe dependencies
6831 * buildbot/bb_tap.py, buildbot/plugins.tml:
6832 * buildbot/bot.py (updateApplication): Add mktap support for creating
6833 buildslave .tap files
6835 2003-03-28 Brian Warner <warner@lothar.com>
6837 * buildbot/process/step.py (InternalShellCommand.finished): handle
6838 new tuple result values (fix embarrasing bug that appeared during
6841 2003-03-27 Brian Warner <warner@lothar.com>
6843 * docs/examples/glib_master.py, README: add sample buildmaster.tap
6846 2003-03-25 Brian Warner <warner@lothar.com>
6848 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
6849 to overall build status
6850 * buildbot/clients/base.py (Builder): improve event printing
6851 * buildbot/process/base.py (BasicBuildFactory): use specific steps
6852 instead of generic ShellCommand
6853 (Build): Add .stopBuild, use it when slave is detached
6855 * buildbot/process/step.py (Configure,Test): give the steps their
6856 own names and status strings
6858 * buildbot/status/html.py (StatusResource): add "show" argument,
6859 lets you limit the set of Builders being displayed.
6861 2003-03-20 Brian Warner <warner@lothar.com>
6863 * buildbot/process/basic.py: removed
6865 2003-03-19 Brian Warner <warner@lothar.com>
6867 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
6868 turn off process-docs by default
6870 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
6871 when displaying build information without anything in allBuilds[]
6873 * buildbot/bot.py (makeApp): really take password from sys.argv
6875 2003-03-18 Brian Warner <warner@lothar.com>
6877 * buildbot/bot.py (buildApp): take password from sys.argv
6879 * README: replace with more useful text
6881 * setup.py: add a real one
6882 * MANIFEST.in, .cvsignore: more distutils packaging stuff
6884 * docs/PyCon-2003/: added sources for PyCon paper.
6886 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
6887 now Build objects control the process and Builder only handles
6888 slave stuff and distribution of changes/status. A new BuildFactory
6889 class creates Build objects on demand.
6891 Created ConfigurableBuild which takes a list of steps to run. This
6892 makes it a lot easier to set up a new kind of build and moves us
6893 closer to being able to configure a build from a web page.
6895 * buildbot/process/step_twisted.py, process_twisted.py: move to
6896 new model. A lot of code went away.
6898 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
6899 send lots of empty progress messages to the client.
6901 * buildbot/master.py (makeApp): enforce builder-name uniqueness
6903 2003-02-20 Brian Warner <warner@lothar.com>
6905 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
6907 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
6908 Twisted bug that prevented non-pty processes from working just got
6909 fixed, and the bug that leaks ptys is still being investigated.
6911 * buildbot/process/step.py (CVS): send timeout arg to slave
6913 * buildbot/clients/gtkPanes.py: add connection-status row, handle
6914 builders coming and going
6915 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
6916 from CVSToys, handle lost-buildmaster
6918 * buildbot/status/client.py (StatusClientService.removeBuilder):
6919 Clean up status client protocol: send builders (with references)
6920 as they are created, rather than sending a list and requiring the
6921 client to figure out which ones are new.
6922 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
6923 attempts to force a build on an unknown builder
6925 2003-02-19 Brian Warner <warner@lothar.com>
6927 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
6928 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
6929 Twisted stops leaking them.
6930 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
6931 builder goes to an idle state.
6933 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
6934 I figure out why CVS commands hang without them, and/or I fix the
6935 hung-command timeout
6937 2003-02-16 Brian Warner <warner@lothar.com>
6939 * buildbot/process/step_twisted.py: bin/hlint went away, replace
6940 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
6941 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
6942 GenerateDocs now that they are prefixed with WARNING:.
6944 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
6945 use manual href target instead of request.childLink
6947 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
6948 display every second, but update the ETA every 5 seconds (or
6949 whenever) as remote_progress messages arrive.
6952 2003-02-12 Brian Warner <warner@lothar.com>
6954 * *: import current sources from home CVS repository
6958 # add-log-time-format: add-log-iso8601-time-string